Fix breakpoints on file reloads for PIE binaries
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-08-04 Alan Hayward <alan.hayward@arm.com>
2
3 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4
5 2019-07-04 Tom Tromey <tom@tromey.com>
6
7 PR tui/24724:
8 * tui/tui-winsource.c (tui_clear_source_content): Update.
9 (tui_source_window_base::set_is_exec_point_at): Fix comment.
10 (tui_update_breakpoint_info): Update.
11 (tui_set_exec_info_content): Update.
12 * tui/tui-source.c (tui_set_source_content_nil): Update.
13 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
14 has_break.
15 * tui/tui-data.h (enum tui_bp_flag): New.
16 (tui_bp_flags): New enum flags type.
17 (struct tui_source_element) <break_mode>: Change type. Rename
18 from has_break.
19 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
20 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
21 constants.
22 * tui/tui-winsource.h: Fix comment.
23
24 2019-07-04 Alan Hayward <alan.hayward@arm.com>
25
26 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
27 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
28 (store_fpregs_to_thread)
29 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
30 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
31 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
32 (IWMMXT_REGS_SIZE): Add define.
33 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
34 (fetch_vfp_regs, store_vfp_regs)
35 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
36 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
37
38 2019-07-04 Alan Hayward <alan.hayward@arm.com>
39
40 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
41 defines.
42 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
43 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
44 (ARM_INT_REGISTER_SIZE): ...to this.
45 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
46 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
47 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
48 (arm_linux_collect_gregset, supply_nwfpe_register)
49 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
50 defines.
51 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
52 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
53 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
54 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
55 (arm_return_in_memory, arm_store_return_value)
56 (arm_get_longjmp_target, arm_register_g_packet_guesses)
57 (arm_record_ld_st_multiple): Likewise.
58 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
59 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
60
61 2019-07-04 Alan Hayward <alan.hayward@arm.com>
62
63 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
64 AARCH64_DISPLACED_MODIFIED_INSNS.
65 * aarch64-tdep.c (struct aarch64_displaced_step_data)
66 (aarch64_displaced_step_copy_insn): Likewise.
67 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
68 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
69 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
70 ARM_DISPLACED_MODIFIED_INSNS.
71 * arm-tdep.c (arm_gdbarch_init): Likewise.
72 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
73 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
74 (struct arm_displaced_step_closure): Use
75 ARM_DISPLACED_MODIFIED_INSNS.
76
77 2019-07-04 Alan Hayward <alan.hayward@arm.com>
78
79 * features/Makefile: Remove unused xml files.
80 * features/aarch64.xml: Remove.
81 * features/i386/amd64-avx-avx512-linux.xml: Remove.
82 * features/i386/amd64-avx-avx512.xml: Remove.
83 * features/i386/amd64-avx-linux.xml: Remove.
84 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
85 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
86 * features/i386/amd64-avx-mpx-linux.xml: Remove.
87 * features/i386/amd64-avx-mpx.xml: Remove.
88 * features/i386/amd64-avx.xml: Remove.
89 * features/i386/amd64-linux.xml: Remove.
90 * features/i386/amd64-mpx-linux.xml: Remove.
91 * features/i386/amd64-mpx.xml: Remove.
92 * features/i386/amd64.xml: Remove.
93 * features/i386/i386-avx-avx512-linux.xml: Remove.
94 * features/i386/i386-avx-avx512.xml: Remove.
95 * features/i386/i386-avx-linux.xml: Remove.
96 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
97 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
98 * features/i386/i386-avx-mpx-linux.xml: Remove.
99 * features/i386/i386-avx-mpx.xml: Remove.
100 * features/i386/i386-avx.xml: Remove.
101 * features/i386/i386-linux.xml: Remove.
102 * features/i386/i386-mmx-linux.xml: Remove.
103 * features/i386/i386-mmx.xml: Remove.
104 * features/i386/i386-mpx-linux.xml: Remove.
105 * features/i386/i386-mpx.xml: Remove.
106 * features/i386/i386.xml: Remove.
107 * features/i386/x32-avx-avx512-linux.xml: Remove.
108 * features/i386/x32-avx-linux.xml: Remove.
109 * features/i386/x32-linux.xml: Remove.
110
111 2019-07-04 Alan Hayward <alan.hayward@arm.com>
112
113 * regformats/aarch64.dat: Remove.
114 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
115 * regformats/i386/amd64-avx-linux.dat: Remove.
116 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
117 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
118 * regformats/i386/amd64-linux.dat: Remove.
119 * regformats/i386/amd64-mpx-linux.dat: Remove.
120 * regformats/i386/amd64.dat: Remove.
121 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
122 * regformats/i386/i386-avx-linux.dat: Remove.
123 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
124 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
125 * regformats/i386/i386-linux.dat: Remove.
126 * regformats/i386/i386-mmx-linux.dat: Remove.
127 * regformats/i386/i386-mpx-linux.dat: Remove.
128 * regformats/i386/i386.dat: Remove.
129 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
130 * regformats/i386/x32-avx-linux.dat: Remove.
131 * regformats/i386/x32-linux.dat: Remove.
132
133 2019-07-04 Alan Hayward <alan.hayward@arm.com>
134
135 * aarch64-tdep.c: Remove xml self tests.
136 * amd64-linux-tdep.c: Likewise.
137 * amd64-tdep.c: Likewise.
138 * i386-linux-tdep.c: Likewise.
139 * i386-tdep.c: Likewise.
140
141 2019-07-03 Pedro Alves <palves@redhat.com>
142
143 PR cli/24732
144 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
145 (pipe_cmd_option_defs): New.
146 (make_pipe_cmd_options_def_group): New.
147 (pipe_command): Use gdb::option::process_options.
148 (pipe_command_completer): New function.
149 (_initialize_cli_cmds): Install completer for "pipe" command.
150
151 2019-07-03 Pedro Alves <palves@redhat.com>
152
153 * cli/cli-option.c (union option_value) <string>: New field.
154 (struct option_def_and_value): Add ctor, move ctor, dtor and
155 use DISABLE_COPY_AND_ASSIGN.
156 (option_def_and_value::clear_value): New.
157 (parse_option, save_option_value_in_ctx, get_val_type_str)
158 (add_setshow_cmds_for_options): Handle var_string.
159 * cli-option.h (union option_def::var_address) <string>: New
160 field.
161 (struct string_option_def): New.
162 * maint-test-options.c (struct test_options_opts): Add default
163 ctor and use DISABLE_COPY_AND_ASSIGN.
164 <string_opt>: New field.
165 (test_options_opts::~test_options_opts): New.
166 (test_options_opts::dump): Also dump "-string".
167 (test_options_option_defs): Install "string.
168
169 2019-07-03 Pedro Alves <palves@redhat.com>
170
171 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
172 option_value with a null enumeration.
173 (complete_options): Save the option values in the context.
174 (save_option_value_in_ctx): New, factored out from ...
175 (process_options): ... here.
176 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
177 of the function.
178 * maint-test-options.c (test_options_opts::dump): New, factored
179 out from ...
180 (maintenance_test_options_command_mode): ... here.
181 (maintenance_test_options_command_completion_result): Delete.
182 (maintenance_test_options_command_completion_text): Update
183 comment.
184 (maintenance_show_test_options_completion_result): Change
185 prototype. Just print
186 maintenance_test_options_command_completion_text.
187 (save_completion_result): New.
188 (maintenance_test_options_completer_mode): Pass options context to
189 complete_options, and then save a dump.
190 (_initialize_maint_test_options): Use add_cmd to install "maint
191 show test-options-completion-result".
192
193 2019-07-03 Pedro Alves <palves@redhat.com>
194
195 * NEWS (New commands): Mention "with" and "maint with".
196 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
197 (with_command, with_command_completer): New.
198 (pipe_command): Adjust to new repeat_previous
199 interface.
200 (_initialize_cli_cmds): Install the "with" command and its "w"
201 alias.
202 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
203 declarations.
204 * cli/cli-setshow.c (parse_cli_var_uinteger)
205 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
206 argument strings for all var_types.
207 (get_setshow_command_value_string): New, factored out from ...
208 (do_show_command): ... this.
209 * cli/cli-setshow.h: Include <string>.
210 (get_setshow_command_value_string): Declare.
211 * command.h (repeat_previous): Now returns const char *. Adjust
212 comment.
213 * maint.c: Include "cli/cli-cmds.h".
214 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
215 (_initialize_maint_cmds): Register the "maintenance with" command.
216 * top.c (repeat_previous): Move bits from pipe_command here:
217 Return the saved command line, if any; error out if there's no
218 command to relaunch.
219
220 2019-07-03 Pedro Alves <palves@redhat.com>
221
222 * NEWS (New commands): Mention "maint set/show test-settings"
223 instead of "maint test-settings".
224 * maint-test-settings.c (maintenance_test_settings_list): Delete.
225 (maintenance_test_settings_set_list): Rename to ...
226 (maintenance_set_test_settings_list): ... this.
227 (maintenance_test_settings_show_list): Rename to ...
228 (maintenance_show_test_settings_list): ... this.
229 (maintenance_test_settings_cmd): Delete.
230 (maintenance_test_settings_set_cmd): ...
231 (maintenance_set_test_settings_cmd): ... this.
232 (maintenance_test_settings_show_cmd): ...
233 (maintenance_show_test_settings_cmd): ... this.
234 (maintenance_test_settings_show_value_cmd):
235 (maintenance_show_test_settings_value_cmd): ... this.
236 (_initialize_maint_test_settings): No longer install the "maint
237 test-settings" prefix command. Rename "maint test-settings set"
238 to "maint set test-settings", and "maint test-settings show" to
239 "maint show test-settings". Adjust all subcommands.
240
241 2019-07-03 Pedro Alves <palves@redhat.com>
242
243 * maint-test-settings.c: Fix file's intro comment. Replace all
244 references to "test-options" with references to "test-settings",
245 in comments.
246
247 2019-07-03 Pedro Alves <palves@redhat.com>
248
249 * maint-test-settings.c (maintenance_test_settings_xxx)
250 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
251 New.
252 (maintenance_test_settings_enums): Use them.
253 (maintenance_test_settings_enum): Default to
254 maintenance_test_settings_xxx.
255 (_initialize_maint_test_settings): Initialize
256 MAINTENANCE_TEST_SETTINGS_FILENAME.
257
258 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
259
260 * breakpoint.h (remove_breakpoints_inf): Change return type to
261 void, move function documentation here.
262 * breakpoint.c (remove_breakpoints_inf): Change return type to
263 void, move function documentation to header.
264
265 2019-07-02 Pedro Alves <palves@redhat.com>
266
267 * NEWS (Completion improvements): Mention "info threads".
268 * thread.c (struct info_threads_opts, info_threads_option_defs)
269 (make_info_threads_options_def_group): New.
270 (info_threads_command): Use gdb::option::process_options.
271 (info_threads_command_completer): New.
272 (_initialize_thread): Use gdb::option::build_help to build the
273 help text for "info threads".
274
275 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
276
277 * defs.h (generic_load): Move from here...
278 * symfile.h (generic_load): ... to here. Rename name parameter
279 to args.
280 * symfile.c (generic_load): Add comment.
281
282 2019-07-01 Tom Tromey <tromey@adacore.com>
283
284 * dwarf2read.c
285 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
286 declaration of without_params. Fix formatting.
287
288 2019-07-01 Tom Tromey <tromey@adacore.com>
289
290 * ada-exp.y (find_primitive_type): Update.
291 * ada-lang.h (ada_lookup_symbol): Update.
292 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
293 parameter.
294 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
295
296 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
297
298 PR breakpoints/24541
299 * gdbarch.c: Regenerate.
300 * gdbarch.h: Regenerate.
301 * gdbarch.sh: Add 'stap_adjust_register'.
302 * i386-tdep.c: Include '<unordered_set>'.
303 (i386_stap_adjust_register): New function.
304 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
305 * stap-probe.c (stap_parse_register_operand): Call
306 'gdbarch_stap_adjust_register'.
307
308 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
309
310 PR python/24742
311 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
312 * python/python.c (do_start_initialization): Use 'xmalloc'
313 instead of 'PyMem_Malloc'.
314
315 2019-06-28 Tom Tromey <tromey@adacore.com>
316
317 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
318 for Ada.
319
320 2019-06-27 Tom Tromey <tromey@adacore.com>
321
322 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
323 objfile_key.
324 (arm_find_mapping_symbol, arm_record_special_symbol)
325 (_initialize_arm_tdep): Update.
326 (arm_objfile_data_free): Remove.
327
328 2019-06-27 Tom Tromey <tromey@adacore.com>
329
330 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
331 to cp_print_static_field.
332
333 2019-06-26 Tom Tromey <tromey@adacore.com>
334
335 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
336 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
337 declare.
338
339 2019-06-26 Alan Hayward <alan.hayward@arm.com>
340
341 * features/aarch64-core.c (create_feature_aarch64_core):
342 Regenerate.
343 * features/aarch64-core.xml: Add cpsr flags.
344
345 2019-06-26 Alan Hayward <alan.hayward@arm.com>
346
347 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
348 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
349
350 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
351
352 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
353 field.
354 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
355 use.
356 (arm_record_special_symbol): Don't insert new symbol in sorted
357 position, push it at the end.
358
359 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
360
361 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
362 (arm_mapping_symbol_s): Remove.
363 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
364 (arm_mapping_symbol_vec): New typedef.
365 (struct arm_per_objfile): Add constructor.
366 <section_maps>: Change type to
367 std::unique_ptr<arm_mapping_symbol_vec[]>.
368 (arm_compare_mapping_symbols): Remove.
369 (arm_find_mapping_symbol): Adjust to section_maps type change.
370 (arm_objfile_data_free): Call delete on arm_per_objfile.
371 (arm_record_special_symbol): Adjust to section_maps type change.
372 Allocate arm_per_objfile with new.
373
374 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
375
376 * cli/cli-cmds.c (alias_command): Compare the alias prefix
377 with the command prefix.
378
379 2019-06-25 Tom Tromey <tom@tromey.com>
380
381 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
382 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
383
384 2019-06-25 Tom Tromey <tom@tromey.com>
385
386 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
387 type.
388 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
389 protected.
390
391 2019-06-25 Tom Tromey <tom@tromey.com>
392
393 * tui/tui-winsource.c
394 (tui_source_window_base::set_is_exec_point_at): Add check against
395 LOA_ADDRESS.
396
397 2019-06-25 Tom Tromey <tom@tromey.com>
398
399 * tui/tui-source.c (tui_set_source_content): Don't check before
400 xfree.
401 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
402
403 2019-06-25 Tom Tromey <tom@tromey.com>
404
405 * tui/tui-winsource.h (tui_update_source_window_as_is)
406 (tui_alloc_source_buffer, tui_line_is_displayed)
407 (tui_addr_is_displayed): Change type of win_info.
408 * tui/tui-winsource.c (tui_update_source_window_as_is)
409 (tui_clear_source_content, tui_show_source_line)
410 (tui_show_source_content, tui_source_window_base::refill)
411 (tui_source_window_base::set_is_exec_point_at)
412 (tui_source_window_base::set_is_exec_point_at)
413 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
414 (tui_alloc_source_buffer, tui_line_is_displayed)
415 (tui_addr_is_displayed): Change type of win_info. Update.
416 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
417 (tui_source_window_base::do_make_visible_with_new_height):
418 Update.
419 * tui/tui-source.c (tui_set_source_content)
420 (tui_set_source_content_nil)
421 (tui_source_window::do_scroll_vertical): Update.
422 * tui/tui-layout.c (show_layout): Update.
423 * tui/tui-disasm.c (tui_set_disassem_content)
424 (tui_disasm_window::do_scroll_vertical): Update.
425 * tui/tui-data.h (tui_win_content): Remove.
426 (struct tui_gen_win_info) <content, content_size>: Remove.
427 (struct tui_source_element): Add initializers and destructor.
428 (union tui_which_element, struct tui_win_element): Remove.
429 (struct tui_source_window_base) <content>: New field.
430 (struct tui_data_window): Remove destructor.
431 (tui_alloc_content, tui_free_win_content)
432 (tui_free_all_source_wins_content): Don't declare.
433 * tui/tui-data.c (tui_initialize_static_data): Update.
434 (init_content_element, tui_alloc_content): Remove.
435 (~tui_gen_win_info): Update.
436 (~tui_data_window, tui_free_all_source_wins_content)
437 (tui_free_win_content, free_content, free_content_elements):
438 Remove.
439
440 2019-06-25 Tom Tromey <tom@tromey.com>
441
442 * tui/tui-winsource.h (tui_clear_source_content)
443 (tui_erase_source_content, tui_show_source_content): Change type
444 of win_info.
445 * tui/tui-winsource.c (tui_clear_source_content)
446 (tui_erase_source_content, tui_show_source_content): Change type
447 of win_info.
448 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
449 * tui/tui-source.h (tui_set_source_content_nil): Change type of
450 win_info.
451 * tui/tui-source.c (tui_set_source_content_nil): Change type of
452 win_info.
453 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
454
455 2019-06-25 Tom Tromey <tom@tromey.com>
456
457 * tui/tui-winsource.c (tui_clear_source_content)
458 (tui_source_window_base::set_is_exec_point_at): Update.
459 * tui/tui-source.c (tui_set_source_content_nil): Update.
460 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
461 a bool.
462 * tui/tui-data.c (init_content_element): Update.
463
464 2019-06-25 Tom Tromey <tom@tromey.com>
465
466 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
467 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
468 * tui/tui-layout.c (init_and_make_win): Update.
469 * tui/tui.h (enum tui_win_type): Update.
470 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
471 tui_win_is_auxillary.
472 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
473 tui_win_is_auxillary.
474
475 2019-06-25 Tom Tromey <tom@tromey.com>
476
477 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
478 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
479 (tui_delete_data_content_windows, tui_display_all_data)
480 (tui_data_window::do_scroll_vertical, tui_display_data_from):
481 Update.
482 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
483 * tui/tui-regs.c (tui_last_regs_line_no)
484 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
485 (tui_show_registers): Update.
486 (tui_show_register_group): Return void. Update.
487 (tui_display_registers_from, tui_display_reg_element_at_line)
488 (tui_display_registers_from_line, tui_check_register_values):
489 Update.
490 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
491 member.
492 (struct tui_data_window) <regs_content>: Now a std::vector.
493 <regs_content_count>: Remove.
494 (tui_add_content_elements, tui_free_data_content): Don't declare.
495 * tui/tui-data.c (tui_data_window::clear_detail): Update.
496 (init_content_element): Remove DATA_WIN case. Add assert.
497 (tui_add_content_elements): Remove.
498 (tui_data_window): Update.
499 (tui_free_data_content): Remove.
500 (free_content_elements): Remove DATA_WIN case.
501
502 2019-06-25 Tom Tromey <tom@tromey.com>
503
504 * tui/tui-data.c (tui_data_item_window): Update.
505 * tui/tui-windata.h (tui_check_data_values): Don't declare.
506 * tui/tui-windata.c (tui_display_all_data)
507 (tui_display_data_from_line): Update.
508 (tui_check_data_values): Remove.
509 * tui/tui-regs.c (tui_show_register_group)
510 (tui_display_reg_element_at_line): Update.
511 * tui/tui-hooks.c (tui_register_changed)
512 (tui_refresh_frame_and_register_information): Call
513 tui_check_register_values.
514 * tui/tui-data.h (struct tui_data_window) <data_content,
515 data_content_count, data_type>: Remove.
516 (enum tui_data_type): Remove.
517
518 * tui/tui-data.c (tui_data_window::clear_detail)
519 (~tui_data_window): Update.
520
521 2019-06-25 Tom Tromey <tom@tromey.com>
522
523 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
524 declare.
525 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
526 Rename from tui_first_data_item_displayed. Update.
527 (tui_data_window::refresh_all)
528 (tui_data_window::do_scroll_vertical): Update.
529 * tui/tui-data.h (struct tui_data_window)
530 <first_data_item_displayed>: Declare new method.
531
532 2019-06-25 Tom Tromey <tom@tromey.com>
533
534 * tui/tui-data.h (tui_init_generic_part): Don't declare.
535 * tui/tui-data.c (tui_init_generic_part): Remove, moving
536 contents...
537 (tui_initialize_static_data): ...here.
538
539 2019-06-25 Tom Tromey <tom@tromey.com>
540
541 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
542 (tui_display_registers_from, tui_check_register_values): Update.
543 (tui_display_register): Remove win_info parameter; update.
544 (tui_get_register): Change type of parameters.
545 * tui/tui-data.h (struct tui_data_element): Remove.
546 (union tui_which_element) <data>: Remove.
547 <data_window>: Change type.
548 (struct tui_data_item_window): New.
549 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
550 case. Add assert.
551 (~tui_data_item_window): New destructor.
552 (free_content_elements): Remove DATA_ITEM_WIN case.
553
554 2019-06-25 Tom Tromey <tom@tromey.com>
555
556 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
557 Remove.
558
559 2019-06-25 Tom Tromey <tom@tromey.com>
560
561 * tui/tui-data.h (struct tui_command_element): Remove.
562 (union tui_which_element) <command>: Remove.
563 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
564 assert.
565 (free_content_elements): Remove CMD_WIN case.
566
567 2019-06-25 Tom Tromey <tom@tromey.com>
568
569 * tui/tui-layout.c (tui_set_layout): Update.
570 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
571 * tui/tui-data.c (layout_def): Update.
572
573 2019-06-25 Tom Tromey <tom@tromey.com>
574
575 * tui/tui-wingeneral.c (tui_refresh_all): Update.
576 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
577 (tui_source_window_base::set_new_height): Update.
578 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
579 Update.
580 (tui_set_locator_fullname, tui_set_locator_info)
581 (tui_show_frame_info): Update.
582 * tui/tui-source.c (tui_set_source_content)
583 (tui_source_is_displayed): Update.
584 * tui/tui-layout.c (show_source_disasm_command, show_data)
585 (show_source_or_disasm_and_command): Update.
586 * tui/tui-disasm.c (tui_set_disassem_content)
587 (tui_get_begin_asm_address): Update.
588 * tui/tui-data.h (struct tui_locator_element): Remove.
589 (union tui_which_element) <locator>: Remove.
590 (struct tui_locator_window): New.
591 (tui_locator_win_info_ptr): Change return type.
592 * tui/tui-data.c (_locator): Change type.
593 (tui_locator_win_info_ptr): Change return type.
594 (init_content_element): Remove LOCATOR_WIN case. Add assert.
595 (tui_alloc_content): Add assert.
596
597 2019-06-25 Tom Tromey <tom@tromey.com>
598
599 * tui/tui-winsource.c
600 (tui_exec_info_window::maybe_allocate_content): New method.
601 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
602 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
603 (make_source_or_disasm_window): Add cast.
604 * tui/tui-data.h (union tui_which_element) <simple_string>:
605 Remove.
606 (struct tui_source_info): New.
607 (struct tui_source_window_base) <execution_info>: Change type.
608 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
609 case, and add assert.
610 (tui_alloc_content): Add assert.
611
612 2019-06-25 Tom Tromey <tom@tromey.com>
613
614 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
615 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
616 * tui/tui-data.c (tui_alloc_win_info): Remove.
617
618 2019-06-25 Tom Tromey <tom@tromey.com>
619
620 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
621 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
622 can_highlight.
623
624 2019-06-25 Tom Tromey <tom@tromey.com>
625
626 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
627 make_visible_with_new_height method.
628 (tui_win_info::make_visible_with_new_height): New method.
629 (tui_source_window_base::do_make_visible_with_new_height)
630 (tui_data_window::do_make_visible_with_new_height)
631 (tui_cmd_window::do_make_visible_with_new_height): New methods.
632 (make_visible_with_new_height): Remove.
633 (tui_resize_all, tui_adjust_win_heights): Use
634 make_visible_with_new_height method.
635 * tui/tui-data.h (struct tui_win_info)
636 <do_make_visible_with_new_height, make_visible_with_new_height>:
637 New methods.
638 (struct tui_source_window_base, struct tui_data_window)
639 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
640 methods.
641
642 2019-06-25 Tom Tromey <tom@tromey.com>
643
644 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
645 method.
646 (update_tab_width): Call update_tab_width method.
647 * tui/tui-data.h (struct tui_win_info)
648 (struct tui_source_window_base) <update_tab_width>: New methods.
649
650 2019-06-25 Tom Tromey <tom@tromey.com>
651
652 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
653 parameter.
654 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
655 parameter.
656 (tui_gen_win_info::make_visible): Update.
657 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
658 parameter.
659 * tui/tui-data.h (enum tui_box): New enum.
660 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
661
662 2019-06-25 Tom Tromey <tom@tromey.com>
663
664 * tui/tui-layout.c (make_source_or_disasm_window): Always use
665 init_and_make_win for EXEC_INFO_WIN.
666 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
667 longer inline.
668 (struct tui_win_info) <~tui_win_info>: Inline.
669 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
670 Don't declare.
671 * tui/tui-data.c (source_win, disasm_win): Remove globals.
672 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
673 Remove.
674 (tui_initialize_static_data): Update.
675 (~tui_gen_win_info): Handle more cleanup here.
676 (~tui_source_window_base): Delete "execution_info".
677 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
678
679 2019-06-25 Tom Tromey <tom@tromey.com>
680
681 * tui/tui-layout.c (make_command_window): Don't set
682 can_highlight.
683 (show_source_disasm_command): Call the reset method.
684 (show_data): Don't set can_highlight. Call the reset method.
685 (tui_gen_win_info::reset): Rename from init_gen_win_info
686 (init_and_make_win): Simplify. Return tui_gen_win_info.
687 (show_source_or_disasm_and_command): Call the reset method.
688 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
689 (struct tui_cmd_window): Set can_highlight.
690
691 2019-06-25 Tom Tromey <tom@tromey.com>
692
693 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
694 from make_visible.
695 (tui_make_visible, tui_make_invisible): Rewrite.
696 (tui_win_info::make_visible): Remove.
697 (tui_source_window_base::make_visible): Update.
698 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
699 method. Moved from...
700 (struct tui_win_info) <make_visible>: ...here.
701
702 2019-06-25 Tom Tromey <tom@tromey.com>
703
704 * tui/tui-winsource.c
705 (tui_source_window_base::do_scroll_horizontal): Remove direction
706 parameter.
707 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
708 direction parameter.
709 * tui/tui-win.c (tui_win_info::forward_scroll)
710 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
711 (tui_win_info::right_scroll): Update.
712 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
713 direction parameter.
714 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
715 direction parameter.
716 * tui/tui-data.h (enum tui_scroll_direction): Remove.
717 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
718 Remove direction parameter.
719 (struct tui_source_window_base, struct tui_source_window)
720 (struct tui_disasm_window, struct tui_data_window)
721 (struct tui_cmd_window): Update.
722
723 2019-06-25 Tom Tromey <tom@tromey.com>
724
725 * tui/tui-winsource.h (tui_set_exec_info_content)
726 (tui_show_exec_info_content, tui_erase_exec_info_content)
727 (tui_clear_exec_info_content, tui_update_exec_info): Change
728 argument to tui_source_window_base.
729 * tui/tui-winsource.c (tui_set_exec_info_content)
730 (tui_show_exec_info_content, tui_erase_exec_info_content)
731 (tui_clear_exec_info_content, tui_update_exec_info): Change
732 argument to tui_source_window_base.
733
734 2019-06-25 Tom Tromey <tom@tromey.com>
735
736 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
737 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
738
739 2019-06-25 Tom Tromey <tom@tromey.com>
740
741 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
742 check.
743
744 2019-06-25 Tom Tromey <tom@tromey.com>
745
746 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
747 type to void.
748 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
749 type to void.
750 * tui/tui-source.c (tui_set_source_content): Update.
751 * tui/tui-disasm.c (tui_set_disassem_content): Update.
752
753 2019-06-25 Tom Tromey <tom@tromey.com>
754
755 * tui/tui-win.c (window_name_completer, tui_set_focus)
756 (tui_all_windows_info): Use name method.
757 * tui/tui-data.h (struct tui_gen_win_info)
758 (struct tui_source_window, struct tui_disasm_window)
759 (struct tui_data_window, struct tui_cmd_window) <name>: New
760 method.
761 (tui_win_name): Don't declare.
762 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
763 (tui_win_name): Remove.
764
765 2019-06-25 Tom Tromey <tom@tromey.com>
766
767 * tui/tui-winsource.h (tui_update_source_window)
768 (tui_update_source_window_as_is): Change parameter type.
769 * tui/tui-winsource.c (tui_update_source_window): Change win_info
770 to be a tui_source_window_base.
771 (tui_update_source_window_as_is): Likewise.
772 * tui/tui-win.c (make_visible_with_new_height): Update.
773
774 2019-06-25 Tom Tromey <tom@tromey.com>
775
776 * tui/tui-winsource.c (tui_erase_source_content)
777 (tui_show_source_content, tui_show_exec_info_content)
778 (tui_erase_exec_info_content): Use refresh_window method.
779 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
780 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
781 from tui_refresh_win.
782 (tui_data_window::refresh_window): New method.
783 (tui_win_info::refresh, tui_source_window_base::refresh)
784 (tui_refresh_all): Use refresh_window method.
785 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
786 method.
787 * tui/tui-regs.c (tui_display_register): Call refresh_window
788 method.
789 * tui/tui-layout.c (show_source_disasm_command)
790 (show_source_or_disasm_and_command): Call refresh_window method.
791 * tui/tui-data.h (struct tui_gen_win_info)
792 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
793 New method.
794
795 2019-06-25 Tom Tromey <tom@tromey.com>
796
797 * tui/tui.c (tui_rl_other_window, tui_enable)
798 (tui_is_window_visible, tui_get_command_dimension): Update.
799 * tui/tui-winsource.c (tui_update_source_window_as_is)
800 (tui_clear_source_content, tui_erase_source_content)
801 (tui_show_source_line, tui_source_window_base::refill)
802 (tui_source_window_base::do_scroll_horizontal)
803 (tui_source_window_base::set_is_exec_point_at)
804 (tui_update_breakpoint_info, tui_set_exec_info_content)
805 (tui_alloc_source_buffer, tui_line_is_displayed)
806 (tui_addr_is_displayed): Update.
807 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
808 (tui_check_and_display_highlight_if_needed)
809 (tui_win_info::make_visible, tui_win_info::refresh)
810 (tui_refresh_all): Update.
811 * tui/tui-windata.c (tui_first_data_item_displayed)
812 (tui_delete_data_content_windows, tui_erase_data_content)
813 (tui_display_all_data, tui_data_window::refresh_all)
814 (tui_check_data_values): Update.
815 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
816 (tui_set_win_focus_to, tui_win_info::forward_scroll)
817 (tui_win_info::backward_scroll, tui_refresh_all_win)
818 (tui_resize_all, tui_set_focus, tui_all_windows_info)
819 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
820 (tui_source_window_base::set_new_height)
821 (tui_data_window::set_new_height)
822 (make_invisible_and_set_new_height)
823 (make_visible_with_new_height, new_height_ok)
824 (parse_scrolling_args): Update.
825 * tui/tui-stack.c (tui_show_frame_info): Update.
826 * tui/tui-source.c (tui_set_source_content)
827 (tui_set_source_content_nil, tui_source_is_displayed)
828 (tui_source_window::do_scroll_vertical): Update.
829 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
830 (tui_display_registers_from, tui_display_reg_element_at_line)
831 (tui_check_register_values, tui_reg_command): Update.
832 * tui/tui-layout.c (tui_default_win_height)
833 (show_source_disasm_command, show_data, init_and_make_win)
834 (show_source_or_disasm_and_command): Update.
835 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
836 (tui_redisplay_readline, tui_mld_flush)
837 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
838 (tui_getc): Update.
839 * tui/tui-disasm.c (tui_set_disassem_content)
840 (tui_disasm_window::do_scroll_vertical): Update.
841 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
842 Now virtual.
843 (struct tui_win_info): Derive from tui_gen_win_info.
844 <~tui_win_info>: Mark as override.
845 <generic>: Remove member.
846 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
847 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
848 (~tui_data_window, ~tui_win_info)
849 (tui_free_all_source_wins_content): Update.
850 * tui/tui-command.c (tui_refresh_cmd_win): Update.
851
852 2019-06-25 Tom Tromey <tom@tromey.com>
853
854 * tui/tui-layout.c (init_and_make_win): Use new.
855 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
856 destructor, initializers.
857 (tui_alloc_generic_win_info): Don't declare.
858 * tui/tui-data.c (_locator): Add argument to constructor.
859 (source_win, disasm_win): New globals.
860 (exec_info): Remove.
861 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
862 Update.
863 (tui_alloc_generic_win_info): Remove.
864 (init_content_element): Use new.
865 (tui_win_info::tui_win_info): Update.
866 (free_content_elements) <case DATA_WIN>: Use delete.
867
868 2019-06-25 Tom Tromey <tom@tromey.com>
869
870 * tui/tui-wingeneral.c (tui_refresh_win): Update.
871 * tui/tui-windata.c (tui_first_data_item_displayed)
872 (tui_delete_data_content_windows): Update.
873 * tui/tui-win.c (tui_data_window::set_new_height): Update.
874 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
875 (tui_display_registers_from, tui_check_register_values): Update.
876 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
877 pointer.
878 * tui/tui-data.c (init_content_element): Update. Allocate the new
879 window.
880 (tui_free_data_content): Update.
881 (free_content_elements) <case DATA_WIN>: Free the window.
882
883 2019-06-25 Tom Tromey <tom@tromey.com>
884
885 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
886 Update.
887 * tui/tui-layout.c (make_command_window)
888 (show_source_disasm_command, show_data, init_and_make_win)
889 (show_source_or_disasm_and_command): Update.
890 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
891 method.
892 <can_highight, is_highlighted>: Now bool.
893 (tui_set_win_highlight): Don't declare.
894 * tui/tui-data.c (tui_set_win_highlight): Remove.
895
896 2019-06-25 Tom Tromey <tom@tromey.com>
897
898 * tui/tui-wingeneral.c (make_visible): Remove check of window
899 type.
900
901 2019-06-25 Tom Tromey <tom@tromey.com>
902
903 * tui/tui-win.c (tui_win_info::max_height)
904 (tui_cmd_window::max_height): New methods.
905 (new_height_ok): Call max_height.
906 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
907 <max_height>: New method.
908
909 2019-06-25 Tom Tromey <tom@tromey.com>
910
911 * tui/tui-win.c (tui_source_window_base::set_new_height)
912 (tui_data_window::set_new_height): New methods.
913 (make_invisible_and_set_new_height): Call set_new_height method.
914 * tui/tui-data.h (struct tui_win_info)
915 (struct tui_source_window_base, struct tui_data_window)
916 <set_new_height>: New method.
917
918 2019-06-25 Tom Tromey <tom@tromey.com>
919
920 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
921 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
922 tui_refresh_data_win.
923 * tui/tui-win.c (tui_source_window_base::refresh_all): New
924 method.
925 (tui_refresh_all_win): Call the refresh_all method.
926 (tui_set_focus): Likewise.
927 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
928 (struct tui_source_window_base, struct tui_data_window) <refresh>:
929 Likewise.
930
931 2019-06-25 Tom Tromey <tom@tromey.com>
932
933 * tui/tui-winsource.h (tui_refill_source_window)
934 (tui_set_is_exec_point_at): Don't declare.
935 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
936 (tui_source_window_base::refill): Rename from
937 tui_refill_source_window.
938 (tui_source_window_base::do_scroll_horizontal): Update.
939 (tui_source_window_base::set_is_exec_point_at): Rename from
940 tui_set_is_exec_point_at.
941 (tui_update_all_breakpoint_info): Update.
942 * tui/tui-stack.c (tui_show_frame_info): Update.
943 * tui/tui-layout.c (show_data): Add cast.
944 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
945 * tui/tui-data.h (struct tui_source_window_base) <refill,
946 set_is_exec_point_at>: New methods.
947 (tui_source_windows, tui_add_to_source_windows): Update types.
948 (tui_add_to_source_windows): Remove redundant declaration.
949 * tui/tui-data.c (source_windows): Store tui_source_window_base.
950 (tui_source_windows): Change return type.
951 (tui_clear_source_windows_detail): Update.
952 (tui_add_to_source_windows): Change type of parameter.
953 (tui_free_all_source_wins_content): Update.
954
955 2019-06-25 Tom Tromey <tom@tromey.com>
956
957 * tui/tui-wingeneral.c (tui_win_info::refresh)
958 (tui_source_window_base::refresh): New methods.
959 (tui_refresh_all): Call the refresh method.
960 * tui/tui-data.h (struct tui_win_info)
961 (struct tui_source_window_base) <refresh>: New method.
962
963 2019-06-25 Tom Tromey <tom@tromey.com>
964
965 * tui/tui.h (tui_is_window_visible): Return bool.
966 * tui/tui.c (tui_is_window_visible): Return bool.
967 * tui/tui-wingeneral.c (tui_make_window, make_visible)
968 (tui_make_visible, tui_make_invisible)
969 (tui_win_info::make_visible)
970 (tui_source_window_base::make_visible, make_all_visible)
971 (tui_make_all_visible, tui_make_all_invisible): Update.
972 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
973 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
974 bool.
975 (struct tui_win_info, struct tui_source_window_base)
976 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
977 * tui/tui-data.c (tui_init_generic_part): Update.
978
979 2019-06-25 Tom Tromey <tom@tromey.com>
980
981 * tui/tui-wingeneral.c (tui_win_info::make_visible)
982 (tui_source_window_base::make_visible): New methods.
983 (make_all_visible): Make method call.
984 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
985 (struct tui_source_window_base, struct tui_cmd_window): Override
986 make_visible.
987 (tui_win_is_source_type): Don't declare.
988 * tui/tui-data.c (tui_win_is_source_type): Remove.
989
990 2019-06-25 Tom Tromey <tom@tromey.com>
991
992 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
993 NULL check.
994
995 2019-06-25 Tom Tromey <tom@tromey.com>
996
997 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
998 Inline constructor. Add initializers for members.
999 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1000 constructors; now inline in class.
1001
1002 2019-06-25 Tom Tromey <tom@tromey.com>
1003
1004 * tui/tui-regs.c (tui_show_registers): Update.
1005 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1006 bool.
1007 * tui/tui-data.c (tui_data_window::clear_detail)
1008 (tui_data_window): Update.
1009
1010 2019-06-25 Tom Tromey <tom@tromey.com>
1011
1012 * tui/tui-windata.c (tui_display_all_data)
1013 (tui_display_data_from_line, tui_display_data_from)
1014 (tui_check_data_values, tui_data_window::do_scroll_vertical):
1015 Update.
1016 * tui/tui-regs.c (tui_last_regs_line_no)
1017 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1018 (tui_show_registers, tui_show_register_group)
1019 (tui_display_registers_from, tui_display_reg_element_at_line)
1020 (tui_display_registers_from_line, tui_check_register_values)
1021 (tui_reg_next, tui_reg_prev): Update.
1022 * tui/tui-layout.c (tui_set_layout, show_data): Update.
1023 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
1024 tui_data_window.
1025 (struct tui_win_info) <detail>: Remove. Add new fields from
1026 tui_data_info.
1027 (TUI_DATA_WIN): Add cast.
1028 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1029 (~tui_data_window): Simplify.
1030
1031 2019-06-25 Tom Tromey <tom@tromey.com>
1032
1033 * tui/tui-layout.c (show_source_disasm_command)
1034 (show_source_or_disasm_and_command): Update.
1035 * tui/tui-io.c (update_cmdwin_start_line)
1036 (tui_redisplay_readline): Update.
1037 * tui/tui-data.h (struct tui_command_info): Remove.
1038 (struct tui_win_info) <detail>: Remove command_info member.
1039 (struct tui_data_window) <start_line>: New member, from
1040 tui_command_info.
1041 (TUI_CMD_WIN): Add casts.
1042
1043 2019-06-25 Tom Tromey <tom@tromey.com>
1044
1045 * tui/tui-winsource.c (tui_update_source_window)
1046 (tui_refill_source_window)
1047 (tui_source_window_base::do_scroll_horizontal)
1048 (tui_update_breakpoint_info, tui_set_exec_info_content)
1049 (tui_show_exec_info_content, tui_erase_exec_info_content)
1050 (tui_clear_exec_info_content): Update.
1051 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1052 Update.
1053 * tui/tui-win.c (make_invisible_and_set_new_height)
1054 (make_visible_with_new_height): Update.
1055 * tui/tui-source.c (tui_set_source_content)
1056 (tui_show_symtab_source): Update.
1057 * tui/tui-layout.c (extract_display_start_addr)
1058 (show_source_disasm_command, show_data)
1059 (make_source_or_disasm_window)
1060 (show_source_or_disasm_and_command): Update.
1061 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1062 (tui_disasm_window::do_scroll_vertical): Remove shadowing
1063 "gdbarch".
1064 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
1065 to tui_source_window_base.
1066 (struct tui_win_info) <detail>: Remove source_info member.
1067 (struct tui_source_window_base) <has_locator>: Inline.
1068 Move contents from tui_source_info; rename has_locator member to
1069 m_has_locator.
1070 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1071 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1072 header file.
1073 (tui_source_window_base::clear_detail, ~tui_source_window_base):
1074 Simplify.
1075 (tui_free_all_source_wins_content): Cast to
1076 tui_source_window_base.
1077
1078 2019-06-25 Tom Tromey <tom@tromey.com>
1079
1080 * tui/tui-win.c (make_invisible_and_set_new_height)
1081 (make_visible_with_new_height): Call has_locator method.
1082 * tui/tui-layout.c (show_source_disasm_command, show_data)
1083 (show_source_or_disasm_and_command): Update for bool change.
1084 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1085 (tui_win_info) <has_locator>: New method.
1086 (struct tui_source_window_base) <has_locator>: New method.
1087 (tui_win_has_locator): Don't declare.
1088 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1089 from tui_win_has_locator.
1090 (tui_source_window_base): Use false, not FALSE.
1091
1092 2019-06-25 Tom Tromey <tom@tromey.com>
1093
1094 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1095 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1096 clear_detail method directly.
1097 (tui_clear_win_detail): Remove.
1098
1099 2019-06-25 Tom Tromey <tom@tromey.com>
1100
1101 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1102 "this", not TUI_DISASM_WIN.
1103
1104 2019-06-25 Tom Tromey <tom@tromey.com>
1105
1106 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
1107 declare.
1108 * tui/tui-winsource.c
1109 (tui_source_window_base::do_scroll_horizontal): Rename from
1110 tui_horizontal_source_scroll.
1111 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1112 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1113 from tui_vertical_data_scroll.
1114 * tui/tui-win.h (tui_scroll): Don't declare.
1115 * tui/tui-win.c (tui_win_info::forward_scroll)
1116 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1117 (tui_win_info::right_scroll): Rename and update.
1118 (tui_scroll_forward_command, tui_scroll_backward_command)
1119 (tui_scroll_left_command, tui_scroll_right_command): Update.
1120 (tui_scroll): Remove.
1121 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1122 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1123 from tui_vertical_source_scroll.
1124 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1125 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1126 from tui_vertical_disassem_scroll.
1127 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1128 do_scroll_horizontal>: New methods.
1129 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1130 Likewise.
1131 (struct tui_source_window_base): Add do_scroll_horizontal.
1132 (struct tui_source_window, struct tui_disasm_window): Add
1133 do_scroll_vertical.
1134 (struct tui_data_window, struct tui_cmd_window): Add
1135 do_scroll_horizontal and do_scroll_vertical.
1136 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1137
1138 2019-06-25 Tom Tromey <tom@tromey.com>
1139
1140 * tui/tui-data.h (struct tui_source_window_base): New struct.
1141 (struct tui_source_window): Derive from tui_source_window_base.
1142 (struct tui_disasm_window): New struct.
1143 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1144 from tui_source_window::clear_detail.
1145 (tui_source_window_base): Rename from tui_source_window.
1146 (~tui_source_window_base): Rename from ~tui_source_window.
1147 (tui_alloc_win_info): Create a tui_disasm_window.
1148
1149 2019-06-25 Tom Tromey <tom@tromey.com>
1150
1151 * tui/tui-data.h (struct tui_source_window)
1152 (struct tui_data_window): Declare destructors.
1153 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1154 destructors.
1155 (tui_win_info): Simplify.
1156
1157 2019-06-25 Tom Tromey <tom@tromey.com>
1158
1159 * tui/tui-winsource.c (tui_display_main)
1160 (tui_update_source_windows_with_addr)
1161 (tui_update_all_breakpoint_info): Update.
1162 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1163 (new_height_ok, parse_scrolling_args): Update.
1164 * tui/tui-stack.c (tui_show_frame_info): Update.
1165 * tui/tui-data.h (struct tui_list): Remove.
1166 (tui_source_windows): Return a reference to a std::vector.
1167 * tui/tui-data.c (source_windows): Now a std::vector.
1168 (tui_source_windows): Change return type.
1169 (tui_clear_source_windows): Rewrite.
1170 (tui_clear_source_windows_detail, tui_add_to_source_windows)
1171 (tui_free_all_source_wins_content): Rewrite.
1172
1173 2019-06-25 Tom Tromey <tom@tromey.com>
1174
1175 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1176 (struct tui_data_window, struct tui_cmd_window): Declare
1177 clear_detail method.
1178 * tui/tui-data.c (tui_source_window::clear_detail)
1179 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1180 methods.
1181 (tui_clear_win_detail): Simplify.
1182
1183 2019-06-25 Tom Tromey <tom@tromey.com>
1184
1185 * tui/tui-layout.c (make_source_window, make_disasm_window)
1186 (make_source_or_disasm_window): Remove win_info_ptr parameter.
1187 Return the new window.
1188 (show_source_disasm_command, show_data)
1189 (show_source_or_disasm_and_command): Update.
1190
1191 2019-06-25 Tom Tromey <tom@tromey.com>
1192
1193 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1194 parameter. Return the new window.
1195 (show_source_disasm_command): Update and remove NULL check.
1196 (show_source_or_disasm_and_command): Update.
1197
1198 2019-06-25 Tom Tromey <tom@tromey.com>
1199
1200 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1201
1202 2019-06-25 Tom Tromey <tom@tromey.com>
1203
1204 * tui/tui-data.h (struct tui_win_info): Make constructor
1205 protected. Make destructor virtual. Add initializers.
1206 (tui_source_window, tui_data_window, tui_cmd_window): New
1207 classes.
1208 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
1209 constructor. Add "type" parameter.
1210 (tui_source_window, tui_data_window, tui_cmd_window): New
1211 constructors.
1212 (tui_alloc_win_info): Instantiate the appropriate subclass.
1213
1214 2019-06-25 Tom Tromey <tom@tromey.com>
1215
1216 * tui/tui-win.c (tui_resize_all): Use delete.
1217 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1218 destructor.
1219 (tui_free_window): Don't declare.
1220 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1221 Update.
1222
1223 2019-06-25 Tom Tromey <tom@tromey.com>
1224
1225 * tui/tui-data.h (struct tui_win_info): Add constructor.
1226 * tui/tui-data.c (tui_alloc_win_info): Use new.
1227 (tui_free_window): Use delete.
1228
1229 2019-06-22 Tom Tromey <tom@tromey.com>
1230
1231 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1232 declare.
1233 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1234
1235 2019-06-22 Tom Tromey <tom@tromey.com>
1236
1237 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1238 declare.
1239 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1240
1241 2019-06-22 Tom de Vries <tdevries@suse.de>
1242
1243 * dwarf2read.c (create_addrmap_from_aranges)
1244 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1245 instead of '%zu'.
1246
1247 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
1248
1249 * dwarf2read.h (dwarf2_section_info_def): Remove.
1250 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1251 * dwarf2read.c (struct dwo_sections) <types>: Change type to
1252 std::vector<dwarf2_section_info>.
1253 (struct dwo_file) <~dwo_file>: Remove.
1254 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1255 types field.
1256 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1257 (dwarf2_read_debug_names): Likewise.
1258 (create_debug_types_hash_table): Change parameter type to
1259 array_view, adjust code accordingly.
1260 (dwarf2_locate_dwo_sections): Adjust to std::vector.
1261 (partial_die_info::fixup): Likewise.
1262 (determine_prefix): Likewise.
1263 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1264
1265 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
1266
1267 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1268 gdb_bfd_ref_ptr.
1269 <~dwo_file>: Remove call to gdb_bfd_unref.
1270 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1271 gdb_bfd_ref_ptr::get.
1272
1273 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
1274
1275 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1276 type to htab_up.
1277 * dwarf2read.c (struct dwo_file): Initialize fields.
1278 <~dwo_file>: New.
1279 (free_dwo_file): Remove, move content to ~dwo_file.
1280 (struct dwo_file_deleter): Remove.
1281 (dwo_file_up>: Remove custom deleter.
1282 (free_dwo_files): Remove.
1283 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1284 dwo_files.
1285 (process_skeletonless_type_units): Call unique_ptr::get.
1286 (allocate_dwo_file_hash_table): Add deleter to created hash
1287 table. Change return type to htab_up.
1288 (lookup_dwo_file_slot): Don't memset dwo_file, call
1289 unique_ptr::get.
1290 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1291 (create_dwo_unit_in_dwp_v2): Likewise.
1292 (open_and_init_dwo_file): Likewise.
1293 (free_dwo_file_from_slot): Remove.
1294
1295 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
1296
1297 * dwarf2read.h (struct dwarf2_section_info) <readin,
1298 is_virtual>: Change type to bool.
1299 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1300 true instead of 1.
1301
1302 2019-06-19 Tom Tromey <tom@tromey.com>
1303
1304 * tui/tui-data.h (tui_init_content_element): Don't declare.
1305
1306 2019-06-19 Tom Tromey <tom@tromey.com>
1307
1308 * tui/tui-data.h (tui_init_win_info): Don't declare.
1309
1310 2019-06-19 Tom de Vries <tdevries@suse.de>
1311
1312 * dwarf2read.h (abstract_to_concrete): Change type to
1313 std::unordered_map<sect_offset, std::vector<sect_offset>,
1314 gdb::hash_enum<sect_offset>>.
1315
1316 2019-06-19 Tom Tromey <tromey@adacore.com>
1317
1318 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1319 EVAL_AVOID_SIDE_EFFECTS specially.
1320
1321 2019-06-19 Tom Tromey <tromey@adacore.com>
1322
1323 * source-cache.c (highlighter): New global.
1324 (source_cache::get_source_lines): Create a highlighter on demand.
1325
1326 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
1327
1328 * defs.h (deprecated_interactive_hook): Delete declaration.
1329 * interps.c (clear_interpreter_hooks): Remove use of
1330 deprecated_interactive_hook.
1331 * top.c (deprecated_interactive_hook): Delete definition.
1332 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1333
1334 2019-06-18 Tom de Vries <tdevries@suse.de>
1335
1336 PR gdb/24515
1337 * dwarf2read.h (abstract_to_concrete): Change type from
1338 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1339 std::unordered_map<sect_offset, std::vector<sect_offset>>.
1340 * dwarf2read.c (read_variable): Update.
1341 (dwarf2_fetch_die_loc_sect_off): Update.
1342
1343 2019-06-17 Tom de Vries <tdevries@suse.de>
1344
1345 PR gdb/24617
1346 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1347 accessing parent[parent_len - 1].
1348
1349 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
1350
1351 PR gdb/24364
1352 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1353 call dtrace_process_dof with NULL dof.
1354
1355 2019-06-16 Tom de Vries <tdevries@suse.de>
1356
1357 PR gdb/24445
1358 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1359
1360 2019-06-16 Tom Tromey <tom@tromey.com>
1361
1362 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1363 (make_all_visible): Use address of member.
1364
1365 2019-06-16 Tom Tromey <tom@tromey.com>
1366
1367 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1368 (tui_free_window, free_content, free_content_elements): Remove
1369 unnecessary cast.
1370 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1371 cast.
1372 * tui/tui-regs.c (tui_show_register_group)
1373 (tui_display_registers_from, tui_display_reg_element_at_line):
1374 Remove unnecessary cast.
1375
1376 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
1377
1378 * linux-nat.c (normal_mask): Delete.
1379 (_initialize_linux_nat): Don't initialise normal_mask.
1380
1381 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
1382
1383 PR gdb/24445
1384 * dwarf-index-write.h (write_psymtabs_to_index): Add
1385 dwz_basename parameter.
1386 * dwarf-index-write.c (write_gdbindex): Move file writing to
1387 write_gdbindex_1. Change return type void.
1388 (assert_file_size): Move up, remove filename parameter.
1389 (write_gdbindex_1): New function.
1390 (write_debug_names): Change return type to void, call
1391 assert_file_size.
1392 (struct index_wip_file): New struct.
1393 (write_psymtabs_to_index): Add dwz_basename parameter. Move
1394 file logic to index_wip_file. Write index for dwz file if
1395 needed.
1396 (save_gdb_index_command): Pass basename of dwz file, if present.
1397 * dwarf-index-cache.c (index_cache::store): Obtain and pass
1398 build-id of dwz file, if present.
1399 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1400 (dwarf2_get_dwz_file): Likewise.
1401 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1402 (dwarf2_get_dwz_file): Likewise.
1403
1404 2019-06-16 Tom Tromey <tom@tromey.com>
1405
1406 * coffread.c (process_coff_symbol): Use xstrdup.
1407 * value.c (create_internalvar): Use xstrdup.
1408
1409 2019-06-16 Tom Tromey <tom@tromey.com>
1410
1411 * valops.c (value_cast, value_slice): Remove unnecessary cast.
1412 * breakpoint.c (stopin_command, stopat_command)
1413 (until_break_command, decode_location_default): Remove unnecessary
1414 cast.
1415 * utils.c (subset_compare): Remove unnecessary cast.
1416 * ada-lang.c (ada_update_initial_language): Remove unnecessary
1417 cast.
1418 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1419 cast.
1420 * infcmd.c (path_command): Remove unnecessary cast.
1421 * coffread.c (decode_type): Remove unnecessary cast.
1422 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1423 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1424 * tui/tui-stack.c (tui_show_locator_content)
1425 (tui_show_frame_info): Remove unnecessary cast.
1426 * tui/tui-win.c (tui_scroll_forward_command)
1427 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1428 (parse_scrolling_args): Remove unnecessary cast.
1429 * tui/tui-data.c (init_win_info, tui_del_window)
1430 (tui_free_window, tui_del_data_windows, tui_free_data_content)
1431 (free_content_elements): Remove unnecessary cast.
1432 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1433 unnecessary cast.
1434 * tui/tui-source.c (tui_set_source_content)
1435 (tui_vertical_source_scroll): Remove unnecessary cast.
1436 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1437 cast.
1438 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1439 * tui/tui-regs.c (tui_display_registers_from)
1440 (tui_display_register): Remove unnecessary cast.
1441 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1442 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1443 (make_visible): Remove unnecessary cast.
1444 * tui/tui-winsource.c (tui_erase_source_content)
1445 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1446 unnecessary cast.
1447 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1448 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1449 * stabsread.c (read_type, read_array_type, read_range_type):
1450 Remove unnecessary cast.
1451 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1452 (parse_symbol, parse_type, upgrade_type, parse_external)
1453 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1454 unnecessary cast.
1455 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1456
1457 2019-06-16 Tom Tromey <tom@tromey.com>
1458
1459 * tui/tui-data.c (tui_alloc_generic_win_info)
1460 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1461 checks.
1462
1463 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
1464 Andrew Burgess <andrew.burgess@embecosm.com>
1465
1466 * f-typeprint.c (f_print_type): Don't return early for not
1467 associated or not allocated types.
1468 (f_type_print_varspec_suffix): Add print_rank parameter and print
1469 ranks of array types in case they dangling.
1470 (f_type_print_base): Add print_rank parameter.
1471
1472 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1473
1474 * NEWS: Mention new MI commands.
1475 * break-catch-throw.c (enum exception_event_kind): Move to
1476 breakpoint.h.
1477 (print_mention_exception_catchpoint): Output text as a single
1478 message.
1479 (catch_exception_command_1): Rename to...
1480 (catch_exception_event): ...this, make non-static, update header
1481 command, and change some parameter types.
1482 (catch_catch_command): Update for changes to
1483 catch_exception_command_1.
1484 (catch_throw_command): Likewise.
1485 (catch_rethrow_command): Likewise.
1486 * breakpoint.c (enum exception_event_kind): Delete.
1487 * breakpoint.h (enum exception_event_kind): Moved here from
1488 break-catch-throw.c.
1489 (catch_exception_event): Declare.
1490 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1491 (mi_cmd_catch_throw): New function.
1492 (mi_cmd_catch_rethrow): New function.
1493 (mi_cmd_catch_catch): New function.
1494 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1495 'catch-catch' entries.
1496 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1497 (mi_cmd_catch_rethrow): Declare.
1498 (mi_cmd_catch_catch): Declare.
1499
1500 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1501
1502 * annotate.c (annotate_source_line): Change return type to void,
1503 update implementation to match.
1504 * annotate.h (annotate_source_line): Change return type to void,
1505 update header comment.
1506 * stack.c (print_frame_info): Don't change what frame information
1507 is printed based on whether annotations are on or not.
1508
1509 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1510
1511 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1512 (annotate_source): Make static.
1513 (annotate_source_line): Moved from source.c and renamed from
1514 identify_source_line. Update the return type.
1515 * annotate.h (annotate_source): Delete declaration.
1516 (annotate_source_line): Declaration moved from source.h, and
1517 renamed from identify_source_line. Return type updated.
1518 * source.c (identify_source_line): Moved to annotate.c and renamed
1519 to annotate_source_line.
1520 (info_line_command): Remove check of annotation_level.
1521 * source.h (identify_source_line): Move declaration to annotate.h
1522 and rename to annotate_source_line.
1523 * stack.c: Add 'annotate.h' include.
1524 (print_frame_info): Remove check of annotation_level before
1525 calling annotate_source_line.
1526
1527 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1528
1529 * source-cache.c (source_cache::get_plain_source_lines): Use
1530 open_source_file_with_line_charpos instead of just
1531 open_source_file, remove call to find_source_lines.
1532 (source_cache::get_source_lines): Likewise.
1533 * source.c (find_source_lines): Make static.
1534 (get_filename_and_charpos): Renamed into...
1535 (open_source_file_with_line_charpos): ..this along with changes to
1536 return a scoped_fd, and some other minor clean ups.
1537 (identify_source_line): Use open_source_file_with_line_charpos.
1538 (search_command_helper): Use open_source_file_with_line_charpos
1539 instead of just open_source_file, remove call to
1540 find_source_lines.
1541 * source.h (open_source_file_with_line_charpos): Declare new
1542 function.
1543 (find_source_lines): Delete declaration.
1544
1545 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
1546
1547 * source.c (get_filename_and_charpos): Remove fullname
1548 parameter.
1549 (identify_source_line): Update call to get_filename_and_charpos.
1550
1551 2019-06-14 Tom Tromey <tromey@adacore.com>
1552
1553 PR gdb/24502:
1554 * ui-style.h (skip_ansi_escape): Update comment.
1555 * ui-file.h (class no_terminal_escape_file): New class.
1556 * ui-file.c (no_terminal_escape_file::write)
1557 (no_terminal_escape_file::puts): New methods.
1558 * cli/cli-logging.c (handle_redirections): Use
1559 no_terminal_escape_file.
1560
1561 2019-06-14 Tom Tromey <tromey@adacore.com>
1562
1563 * NEWS: Move convenience variable news above Python news.
1564
1565 2019-06-14 Tom Tromey <tom@tromey.com>
1566
1567 * gnulib: Move directory to top-level.
1568 * configure.ac: Don't configure gnulib.
1569 * configure: Rebuild.
1570 * common/common-defs.h: Use new path to gnulib.
1571 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1572 (GNULIB_H): Remove.
1573 (INCGNU): Look in new gnulib location.
1574 (HFILES_NO_SRCDIR): Remove gnulib files.
1575 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1576 (generated_files): Remove GNULIB_H.
1577 ($(LIBGNU), all-lib): Remove targets.
1578 (distclean): Don't mention GNULIB_BUILDDIR.
1579 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1580
1581 2019-06-14 Tom Tromey <tromey@adacore.com>
1582
1583 * symfile.c (add_symbol_file_command): Remove obsolete comment.
1584 Warn if symbol file does not provide any symbols.
1585
1586 2019-06-14 Tom Tromey <tromey@adacore.com>
1587
1588 * source.c (find_and_open_source): Respect basenames_may_differ.
1589
1590 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
1591
1592 * annotate.c (annotate_breakpoints_invalid): Make use of
1593 scoped_restore_terminal_state.
1594 (annotate_frames_invalid): Likewise.
1595
1596 2019-06-14 Tom Tromey <tromey@adacore.com>
1597
1598 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1599 allow assignment to an internalvar.
1600
1601 2019-06-14 Tom Tromey <tromey@adacore.com>
1602
1603 * ada-lex.l: Allow "_" in attribute names.
1604
1605 2019-06-14 Tom Tromey <tromey@adacore.com>
1606
1607 PR gdb/24653:
1608 * regcache.c (registers_changed): Don't call alloca.
1609 * top.c (execute_command): Don't call alloca.
1610
1611 2019-06-13 Pedro Alves <palves@redhat.com>
1612
1613 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1614 'expression'. When parsing an expression, error out if there's
1615 junk after "unlimited".
1616 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1617 (do_set_command): Adjust calls to is_unlimited_literal.
1618
1619 2019-06-13 Pedro Alves <palves@redhat.com>
1620
1621 * compile/compile.c (make_compile_options_def_group): Add braces
1622 around array_view initializer.
1623 * thread.c (make_thread_apply_all_options_def_group)
1624 (make_thread_apply_all_options_def_group): Likewise.
1625
1626 2019-06-13 Pedro Alves <palves@redhat.com>
1627
1628 * NEWS (New commands): Mention "maint test-options
1629 require-delimiter", "maint test-options unknown-is-error", "maint
1630 test-options unknown-is-operand" and "maint show
1631 test-options-completion-result".
1632 (New command options, command completion): New section.
1633 (Completion improvements): New section.
1634 Mention that you can abbreviate "unlimited".
1635
1636 2019-06-13 Pedro Alves <palves@redhat.com>
1637
1638 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1639 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1640 * unittests/cli-utils-selftests.c (test_parse_flags)
1641 (test_parse_flags_qcs): Delete.
1642 (test_cli_utils): Don't call deleted functions.
1643
1644 2019-06-13 Pedro Alves <palves@redhat.com>
1645
1646 * thread.c: Include "cli/cli-option.h".
1647 (tp_array_compar_ascending): Global.
1648 (tp_array_compar): Delete function.
1649 (tp_array_compar_ascending, tp_array_compar_descending): New
1650 functions.
1651 (ascending_option_def, qcs_flag_option_def)
1652 (thr_qcs_flags_option_defs)
1653 (make_thread_apply_all_options_def_group)
1654 (make_thread_apply_options_def_group): New.
1655 (thread_apply_all_command): Use gdb::option::process_options.
1656 (thread_apply_command_completer)
1657 (thread_apply_all_command_completer): New.
1658 (thread_apply_command): Use gdb::option::process_options.
1659 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1660 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
1661 to generate help text of "thread apply". Adjust "taas"'s help.
1662 * tid-parse.c (tid_range_parser::in_thread_range): New method.
1663 * tid-parse.h (tid_range_parser::in_thread_range): New method.
1664
1665 2019-06-13 Pedro Alves <palves@redhat.com>
1666
1667 * thread.c (thread_apply_command): Check for invalid TID with
1668 isdigit instead of !isalpha.
1669
1670 2019-06-13 Pedro Alves <palves@redhat.com>
1671
1672 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1673 (validate_flags_qcs): New.
1674 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1675 (validate_flags_qcs): Declare.
1676 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1677 (make_frame_apply_options_def_group): New.
1678 (frame_apply_command_count): Process options with
1679 gdb::option::process_options.
1680 (frame_apply_completer): New.
1681 (frame_apply_level_completer, frame_apply_all_completer)
1682 (frame_apply_completer): New.
1683 (_initialize_stack): Update help of "frame apply", "frame apply
1684 level", "frame apply all" and "faas" to mention supported options
1685 and install command completers.
1686 * stack.h (frame_apply_all_completer): Declare.
1687 * thread.c: Include "stack.h".
1688 (tfaas_command): Add "--".
1689 (_initialize_thread): Update help "tfaas" to mention supported
1690 options and install command completer.
1691
1692 2019-06-13 Pedro Alves <palves@redhat.com>
1693
1694 * completer.c (complete_nested_command_line): New.
1695 (gdb_completion_word_break_characters_throw): Add assertion.
1696 * completer.h (complete_nested_command_line): Declare.
1697
1698 2019-06-13 Pedro Alves <palves@redhat.com>
1699
1700 * stack.c (parse_backtrace_qualifiers): New.
1701 (backtrace_command): Use it.
1702 (backtrace_command_completer): Complete on qualifiers.
1703
1704 2019-06-13 Pedro Alves <palves@redhat.com>
1705
1706 * frame.c: Include "cli/cli-option.h.
1707 (user_set_backtrace_options): New.
1708 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1709 Delete.
1710 (get_prev_frame): Adjust.
1711 (boolean_option_def, uinteger_option_def)
1712 (set_backtrace_option_defs): New.
1713 (_initialize_frame): Adjust and use
1714 gdb::option::add_setshow_cmds_for_options to install "set
1715 backtrace past-main" and "set backtrace past-entry".
1716 * frame.h: Include "cli/cli-option.h".
1717 (struct frame_print_options): Forward declare.
1718 (print_frame_arguments_all, print_frame_arguments_scalars)
1719 (print_frame_arguments_none): Declare.
1720 (print_entry_values): Delete declaration.
1721 (struct frame_print_options, user_frame_print_options): New.
1722 (struct set_backtrace_options): New.
1723 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1724 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1725 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1726 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1727 (list_args_or_locals): Add frame_print_options parameter.
1728 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1729 * python/py-framefilter.c (enumerate_args): Pass down
1730 USER_FRAME_PRINT_OPTIONS.
1731 * stack.c: Include "cli/cli-option.h".
1732 (print_frame_arguments_all, print_frame_arguments_scalars)
1733 (print_frame_arguments_none): Declare.
1734 (print_raw_frame_arguments, print_entry_values): Delete.
1735 (user_frame_print_options): New.
1736 (boolean_option_def, enum_option_def, frame_print_option_defs):
1737 New.
1738 (struct backtrace_cmd_options): New.
1739 (bt_flag_option_def): New.
1740 (backtrace_command_option_defs): New.
1741 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1742 (print_frame_arg, read_frame_arg, print_frame_args)
1743 (print_frame_info, print_frame): Add frame_print_options parameter
1744 and use it.
1745 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1746 (backtrace_command_1): Add frame_print_options and
1747 backtrace_cmd_options parameters and use them.
1748 (make_backtrace_options_def_group): New.
1749 (backtrace_command): Process command options with
1750 gdb::option::process_options.
1751 (backtrace_command_completer): New.
1752 (_initialize_stack): Extend "backtrace"'s help to mention
1753 supported options. Install completer for "backtrace".
1754 Install some settings commands with add_setshow_cmds_for_options.
1755
1756 2019-06-13 Pedro Alves <palves@redhat.com>
1757
1758 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1759 and that "set/show print raw frame-arguments" are now deprecated.
1760
1761 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1762 command.
1763 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1764 * stack.c (_initialize_stack): Install "set/show print
1765 raw-frame-arguments", and deprecate "set/show print raw
1766 frame-arguments".
1767 * valprint.c (_initialize_valprint): Deprecate "set/show print
1768 raw".
1769
1770 2019-06-13 Pedro Alves <palves@redhat.com>
1771
1772 * compile/compile.c (struct compile_options): New.
1773 (compile_flag_option_def, compile_command_option_defs)
1774 (make_compile_options_def_group): New.
1775 (compile_file_command): Handle options with
1776 gdb::option::process_options.
1777 (compile_file_command_completer): New function.
1778 (compile_code_command): Handle options with
1779 gdb::option::process_options.
1780 (compile_code_command_completer): New function.
1781 (_initialize_compiler): Install completers for "compile code" and
1782 "compile file". Mention available options in "compile code" and
1783 "compile code"'s help.
1784 * completer.c (advance_to_completion_word): New, factored out from
1785 ...
1786 (advance_to_expression_complete_word_point): ... this.
1787 (advance_to_filename_complete_word_point): New.
1788 * completer.h (advance_to_filename_complete_word_point): New
1789 declaration.
1790
1791 2019-06-13 Pedro Alves <palves@redhat.com>
1792
1793 * compile/compile.c: Include "cli/cli-option.h".
1794 (compile_print_value): Scope data pointer is now a
1795 value_print_options pointer; adjust.
1796 (compile_print_command): Process options. Scope data pointer is
1797 now a value_print_options pointer; adjust.
1798 (_initialize_compile): Update "compile print"'s help to include
1799 supported options. Install a completer for "compile print".
1800 * cp-valprint.c (show_vtblprint, show_objectprint)
1801 (show_static_field_print): Delete.
1802 (_initialize_cp_valprint): Don't install "set print
1803 static-members", "set print vtbl", "set print object" here.
1804 * printcmd.c: Include "cli/cli-option.h" and
1805 "common/gdb_optional.h".
1806 (print_command_parse_format): Rework to fill in a
1807 value_print_options instead of a format_data.
1808 (print_value): Change parameter type from format_data pointer to
1809 value_print_options reference. Adjust.
1810 (print_command_1): Process options. Adjust to pass down a
1811 value_print_options.
1812 (print_command_completer): New.
1813 (_initialize_printcmd): Install print_command_completer as
1814 handle_brkchars completer for the "print" command. Update
1815 "print"'s help to include supported options.
1816 * valprint.c: Include "cli/cli-option.h".
1817 (show_vtblprint, show_objectprint, show_static_field_print): Moved
1818 here from cp-valprint.c.
1819 (boolean_option_def, uinteger_option_def)
1820 (value_print_option_defs, make_value_print_options_def_group):
1821 New. Use gdb::option::add_setshow_cmds_for_options to install
1822 "set print elements", "set print null-stop", "set print repeats",
1823 "set print pretty", "set print union", "set print array", "set
1824 print address", "set print symbol", "set print array-indexes".
1825 * valprint.h: Include <string> and "cli/cli-option.h".
1826 (make_value_print_options_def_group): Declare.
1827 (print_value): Change parameter type from format_data pointer to
1828 value_print_options reference.
1829 (print_command_completer): Declare.
1830
1831 2019-06-13 Pedro Alves <palves@redhat.com>
1832
1833 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1834 (COMMON_SFILES): Add maint-test-settings.c.
1835 * cli/cli-decode.c (boolean_enums): New global, factored out from
1836 ...
1837 (add_setshow_boolean_cmd): ... here.
1838 * cli/cli-decode.h (boolean_enums): Declare.
1839 * cli/cli-option.c: New file.
1840 * cli/cli-option.h: New file.
1841 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1842 factored out from ...
1843 (parse_cli_boolean_value(const char *)): ... this.
1844 (is_unlimited_literal): Change parameter type to pointer to
1845 pointer. Adjust and advance ARG pointer.
1846 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1847 (parse_cli_var_enum): New, factored out from ...
1848 (do_set_command): ... this. Adjust.
1849 * cli/cli-setshow.h (parse_cli_boolean_value)
1850 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1851 (parse_cli_var_enum): Declare.
1852 * cli/cli-utils.c: Include "cli/cli-option.h".
1853 (get_ulongest): New.
1854 * cli/cli-utils.h (get_ulongest): Declare.
1855 (check_for_argument): New overloads.
1856 * maint-test-options.c: New file.
1857
1858 2019-06-13 Pedro Alves <palves@redhat.com>
1859
1860 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1861 parse a range if "-" is at the end of the string.
1862
1863 2019-06-13 Pedro Alves <palves@redhat.com>
1864
1865 * cli/cli-setshow.c (parse_auto_binary_operation)
1866 (parse_cli_boolean_value): Don't allow "o".
1867
1868 2019-06-13 Pedro Alves <palves@redhat.com>
1869
1870 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1871 * NEWS: Mention maint test-settings KIND.
1872 * maint-test-settings.c: New file.
1873
1874 2019-06-13 Pedro Alves <palves@redhat.com>
1875
1876 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1877 completer.
1878 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1879 "set" completers.
1880
1881 2019-06-13 Pedro Alves <palves@redhat.com>
1882
1883 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1884 after item.
1885
1886 2019-06-13 Pedro Alves <palves@redhat.com>
1887
1888 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1889
1890 2019-06-13 Pedro Alves <palves@redhat.com>
1891
1892 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1893 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1894 call.
1895 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1896 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1897 calls.
1898 (check_for_argument): Skip spaces after argument.
1899
1900 2019-06-13 Pedro Alves <palves@redhat.com>
1901
1902 * thread.c (thread_apply_command): Adjust TID parsing.
1903 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1904 detected before end of string.
1905 (tid_is_in_list): Error out if LIST is invalid.
1906
1907 2019-06-13 Pedro Alves <palves@redhat.com>
1908
1909 * completer.c (complete_line_internal_1): Rewind completion word
1910 point.
1911 (completion_tracker::advance_custom_word_point_by): Change
1912 parameter type to int.
1913 * completer.h (completion_tracker::advance_custom_word_point_by):
1914 Likewise.
1915
1916 2019-06-13 Pedro Alves <palves@redhat.com>
1917
1918 * completer.c (advance_to_completion_word): Handle delimiters.
1919
1920 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
1921
1922 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1923
1924 2019-06-11 Tom Tromey <tom@tromey.com>
1925
1926 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1927 (xmalloc_failed): Move to alloc.c.
1928 * alloc.c: New file.
1929 * Makefile.in (COMMON_SFILES): Add alloc.c.
1930
1931 2019-06-11 Tom Tromey <tom@tromey.com>
1932
1933 * nat/linux-waitpid.c: Don't include server.h.
1934 (linux_debug): Remove.
1935 (my_waitpid): Update.
1936
1937 2019-06-11 Tom Tromey <tromey@adacore.com>
1938
1939 * infcall.c (_initialize_infcall): Remove trailing newline from
1940 help.
1941 * user-regs.c (_initialize_user_regs): Remove trailing newline
1942 from help.
1943 * typeprint.c (_initialize_typeprint): Remove trailing newline
1944 from help.
1945 * reverse.c (_initialize_reverse): Remove trailing newlines from
1946 help.
1947 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1948 from help.
1949 * language.c (add_set_language_command): Remove trailing newline
1950 from help.
1951 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1952 help.
1953 * disasm.c (_initialize_disasm): Remove trailing newline from
1954 help.
1955 * top.c (init_main): Remove trailing newline from help.
1956 * interps.c (_initialize_interpreter): Remove trailing newline
1957 from help.
1958 * btrace.c (_initialize_btrace): Remove trailing newlines from
1959 help.
1960 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1961 from help.
1962 * python/python.c (_initialize_python): Remove trailing newline
1963 from help.
1964 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1965 help.
1966 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1967 from help. Reformat some text.
1968 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1969 from help.
1970 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1971 newline from help.
1972
1973 2019-06-11 Tom Tromey <tromey@adacore.com>
1974
1975 * darwin-nat.c (darwin_decode_exception_message)
1976 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1977
1978 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
1979
1980 * valops.c (value_slice): Check for not allocated or not
1981 associated values.
1982
1983 2019-06-10 Tom de Vries <tdevries@suse.de>
1984
1985 PR gdb/24618
1986 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1987 sure an empty slot (defined by a 32-bit zero pair) is recognized as
1988 invalid.
1989
1990 2019-06-10 Tom de Vries <tdevries@suse.de>
1991
1992 PR gdb/24611
1993 * linespec.c (linespec_lexer_lex_string): Remove incorrect
1994 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
1995
1996 2019-06-10 Tom de Vries <tdevries@suse.de>
1997
1998 PR symtab/24545
1999 * symtab.c (struct demangled_name_entry): Add language field.
2000 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
2001 static minimal symbol". Set and use language field.
2002
2003 2019-06-10 Tom Tromey <tromey@adacore.com>
2004
2005 * ada-lang.c (_initialize_ada_language): Update help text.
2006
2007 2019-06-10 Tom Tromey <tromey@adacore.com>
2008
2009 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2010 with a newline.
2011 * guile/guile.c (handle_boot_error): Don't end warning with a
2012 newline.
2013 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2014 warning with a newline.
2015 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2016 newline.
2017 (s12z_frame_cache): Likewise.
2018 * dwarf-index-cache.c (index_cache::store): Don't end warning with
2019 a newline.
2020 * solib-svr4.c (disable_probes_interface): Don't end warning with
2021 a newline.
2022 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2023 newline.
2024 * python/python.c (do_finish_initialization): Don't end warning
2025 with a newline.
2026
2027 2019-06-10 Tom Tromey <tom@tromey.com>
2028
2029 * python/py-breakpoint.c (gdbpy_breakpoint_created)
2030 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2031 gdbpy_enter.
2032
2033 2019-06-10 Tom Tromey <tromey@adacore.com>
2034
2035 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2036 data.
2037 (elf_new_init): Don't call stabsread_new_init.
2038 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2039 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
2040 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2041
2042 2019-06-10 Tom de Vries <tdevries@suse.de>
2043
2044 PR symtab/16264
2045 PR symtab/24517
2046 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2047
2048 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
2049
2050 * source.c (find_and_open_source): Also rewrite relative file
2051 names.
2052
2053 2019-04-26 Amos Bird <amosbird@gmail.com>
2054
2055 * annotate.c (annotate_thread_exited): Add "thread-exited"
2056 annotation.
2057
2058 2019-06-06 Tom Tromey <tromey@adacore.com>
2059
2060 * maint.h (class scoped_command_stats): Use
2061 DISABLE_COPY_AND_ASSIGN.
2062 <print_time>: New method.
2063 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2064 print_time.
2065 (scoped_command_stats::print_time): New method.
2066
2067 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
2068
2069 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2070 instructions of lengths 6 or 8 bytes.
2071
2072 2019-06-04 Pedro Alves <palves@redhat.com>
2073
2074 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2075
2076 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2077 * breakpoint.c (condition_completer): Likewise.
2078 * cli/cli-dump.c (scan_expression): Likewise.
2079 * common/filestuff.c (mkdir_recursive): Likewise.
2080 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2081 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2082 (gdb_abspath): Likewise.
2083 * compile/compile-cplus-types.c
2084 (compile_cplus_instance::decl_name): Likewise.
2085 * completer.c (complete_explicit_location):
2086 (signal_completer, reg_or_group_completer_1): Likewise.
2087 * cp-support.c (cp_remove_params_if_any): Likewise.
2088 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2089 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2090 * infcmd.c (strip_bg_char): Likewise.
2091 * linespec.c (copy_token_string): Likewise.
2092 * mi/mi-main.c (output_cores): Likewise.
2093 * psymtab.c (psymtab_search_name):
2094 * symfile.c (test_set_ext_lang_command): Likewise.
2095 * target.c (target_fileio_read_stralloc): Likewise.
2096 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2097 * value.c (complete_internalvar): Likewise.
2098
2099 2019-06-04 Christian Biesinger <cbiesinger@google.com>
2100
2101 Add objfile property to gdb.Type.
2102 * NEWS: Mention Python API addition.
2103 * python/py-type.c (typy_get_objfile): New method.
2104
2105 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2106
2107 * NEWS: Mention the new set|show style [title|highlight].
2108 Mention changes to "show style", "help" and "apropos".
2109
2110 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2111
2112 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2113 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
2114 instead of print_help_for_command.
2115 (print_doc_of_command): New function.
2116 (help_list): Add 'apropos -v word' suggestion.
2117 (print_help_for_command): Style the command name using title style.
2118 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2119 (_initialize_cli_cmds): Describe -v in apropos_command help.
2120
2121 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2122
2123 * cli/cli-style.h (cli_style_option): Add name in constructor,
2124 add m_name class member, add constructor with intensity,
2125 add name class function.
2126 (cli_style_option::add_setshow_commands): Remove name argument.
2127 (highlight_style, title_style): New styles.
2128 * cli/cli-style.c (do_show): New function that shows a style
2129 characteristic styling the style name with itself.
2130 (set_style_name): New function.
2131 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2132 Update all callers according to the changes in cli/cli-style.h.
2133 * utils.h (fputs_highlighted): New function.
2134 * utils.c (fputs_highlighted): Likewise.
2135
2136 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2137
2138 * NEWS: Mention new pipe command and new convenience variables.
2139
2140 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2141
2142 * cli/cli-cmds.c (pipe_command): New function.
2143 (_initialize_cli_cmds): Call add_com for pipe_command.
2144 Define | as an alias for pipe.
2145 (exit_status_set_internal_vars): New function.
2146 (shell_escape): Call exit_status_set_internal_vars.
2147 cli/cli-decode.c (find_command_name_length): Recognize | as
2148 a single character command.
2149
2150 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2151
2152 * gdbcmd.h (execute_command_to_ui_file): New declaration.
2153 top.c (execute_command_to_ui_file): New function, mostly a copy
2154 of execute_command_to_string.
2155 (execute_command_to_string): Implement by calling
2156 execute_command_to_ui_file.
2157
2158 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2159
2160 * top.h (saved_command_line): Remove declaration.
2161 * top.c (previous_saved_command_line, previous_repeat_arguments):
2162 New variables.
2163 (saved_command_line): Make static, define together with other
2164 'repeat variables'.
2165 (dont_repeat): Clear repeat_arguments.
2166 (repeat_previous, get_saved_command_line, save_command_line):
2167 New functions.
2168 (gdb_init): Initialize saved_command_line
2169 and previous_saved_command_line.
2170 * main.c (captured_main_1): Remove saved_command_line initialization.
2171 * event-top.c (handle_line_of_input): Update to use
2172 the new 'repeat' related functions instead of direct access to
2173 saved_command_line.
2174 * command.h (repeat_previous, get_saved_command_line,
2175 save_command_line): New declarations.
2176 (dont_repeat): Add comment.
2177
2178 2019-05-30 Tom Tromey <tromey@adacore.com>
2179
2180 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2181 Fix comment.
2182 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2183
2184 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
2185
2186 PR cli/24587
2187 * completer.c (complete): Initialize variable word.
2188
2189 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
2190
2191 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2192 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2193 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2194 'body' is NULL to the outter 'if', protecting the '!is_define'
2195 situation as well.
2196
2197 2019-05-29 Tom Tromey <tromey@adacore.com>
2198
2199 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2200 (dwarf_unknown): New function.
2201 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2202 (dwarf_type_encoding_name): Use dwarf_unknown.
2203
2204 2019-05-29 Tom Tromey <tromey@adacore.com>
2205
2206 PR c++/20020:
2207 * cp-valprint.c (cp_print_value_fields): Call
2208 cp_print_static_field inside "try".
2209
2210 2019-05-29 Tom Tromey <tromey@adacore.com>
2211
2212 * inflow.c (struct terminal_info): Add default operator=.
2213 * configure: Rebuild.
2214 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2215 -Wdeprecated-copy-dtor, -Wredundant-move.
2216
2217 2019-05-29 Tom Tromey <tromey@adacore.com>
2218
2219 * NEWS: Add entry.
2220 * infcmd.c (print_return_value_1): Handle finish_print
2221 option.
2222 (show_print_finish): New function.
2223 (_initialize_infcmd): Add "set/show print finish" commands.
2224 * valprint.c (user_print_options): Initialize new member.
2225 * valprint.h (struct value_print_options) <finish_print>: New
2226 member.
2227
2228 2019-05-28 Tom Tromey <tromey@adacore.com>
2229
2230 * ada-lang.c (ada_remove_Xbn_suffix)
2231 (find_old_style_renaming_symbol)
2232 (parse_old_style_renaming): Remove.
2233 (ada_find_renaming_symbol): Don't call
2234 find_old_style_renaming_symbol.
2235 (ada_is_renaming_symbol): Rename from
2236 ada_find_renaming_symbol. Remove "block" parameter. Return
2237 bool. Now static.
2238 (ada_read_var_value): Update and simplify.
2239 * ada-exp.y (write_var_or_type): Remove old code.
2240
2241 2019-05-28 Alan Hayward <alan.hayward@arm.com>
2242
2243 * event-top.c: Remove include comment.
2244 * inflow.c (class scoped_ignore_sigttou): Move from here...
2245 * inflow.h (class scoped_ignore_sigttou): ...to here.
2246 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2247 * top.c: Remove include comment.
2248
2249 2019-05-27 Tom Tromey <tom@tromey.com>
2250
2251 * NEWS: Fix typo.
2252
2253 2019-05-22 Tom Tromey <tromey@adacore.com>
2254
2255 * target.c (target_follow_exec): Constify parameter.
2256 * target-delegates.c: Rebuild.
2257 * remote.c (remote_target::follow_exec): Constify parameter.
2258 * infrun.c (follow_exec): Constify parameter.
2259 * target.h (struct target_ops) <follow_exec>: Constify parameter.
2260 (target_follow_exec): Likewise.
2261
2262 2019-05-22 Alan Hayward <alan.hayward@arm.com>
2263
2264 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2265 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2266
2267 2019-05-22 Alan Hayward <alan.hayward@arm.com>
2268
2269 * NEWS: Add debugredirect and testsuite sections.
2270
2271 2019-05-22 Simon Cook <simon.cook@embecosm.com>
2272
2273 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2274 target descriptions using exclusively floating point register name
2275 aliases.
2276
2277 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
2278
2279 PR gdb/18644:
2280 * f-lang.c (build_fortran_types): Handle the case where
2281 gdbarch_floatformat_for_type returns a nullptr.
2282
2283 2019-05-21 Tom de Vries <tdevries@suse.de>
2284
2285 PR cli/24587
2286 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2287
2288 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
2289
2290 PR gdb/18644:
2291 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2292 16-byte floats.
2293 * i386-tdep.c (i386_floatformat_for_type): Use
2294 floatformats_ia64_quad for the 16-byte floating point component
2295 within a fortran 32-byte complex number.
2296
2297 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
2298
2299 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2300 delete default constructor.
2301 (find_partial_die): Update to return const struct.
2302 (partial_die_parent_scope): Move variable declaration into scope
2303 of its use and change its type to auto.
2304 (guess_partial_die_structure_name): Likewise.
2305 (partial_die_info::fixup): Likewise.
2306
2307 2019-05-17 Tom Tromey <tromey@adacore.com>
2308
2309 * source.c (find_and_open_source): Remove cast.
2310
2311 2019-05-17 Tom Tromey <tromey@adacore.com>
2312
2313 * annotate.c (annotate_source): Make "filename" const.
2314 * annotate.h (annotate_source): Use const.
2315
2316 2019-05-17 Alan Hayward <alan.hayward@arm.com>
2317
2318 * disasm.c (set_disassembler_options): Send errors to stderr.
2319
2320 2019-05-17 Alan Hayward <alan.hayward@arm.com>
2321
2322 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2323 (cli_interp_base::set_logging): Check debug_redirect.
2324 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2325 * cli/cli-logging.c (debug_redirect): Add static variable.
2326 (pop_output_files): Add default param.
2327 (handle_redirections): Print debug setting.
2328 (show_logging_command): Likewise.
2329 (_initialize_cli_logging): Add debugredirect command.
2330 * interps.c (current_interp_set_logging): Add debug_redirect
2331 parameter.
2332 * interps.h (set_logging): Add debug_redirect parameter.
2333 (current_interp_set_logging): Likewise.
2334 * mi/mi-common.h: Likewise.
2335 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2336
2337 2019-05-17 Alan Hayward <alan.hayward@arm.com>
2338 Tom Tromey <tromey@adacore.com>
2339
2340 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2341 directly.
2342 * cli/cli-interp.h (make_logging_output): Remove declaration.
2343 * cli/cli-logging.c (make_logging_output): Remove function.
2344 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2345 directly.
2346 * ui-file.c (tee_file::tee_file): Remove bools.
2347 (tee_file::~tee_file): Remove deletes.
2348 * ui-file.h (tee_file): Remove bools.
2349
2350 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
2351
2352 * mi/mi-cmds.h (mi_cmd_complete): New function.
2353 * mi/mi-main.c (mi_cmd_complete): Likewise.
2354 * mi/mi-cmds.c: Define new MI command -complete.
2355 * NEWS: Mention new -complete command.
2356
2357 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
2358
2359 * completer.h (complete): New function.
2360 * completer.c (complete): Likewise.
2361 * cli/cli-cmds.c: (complete_command): Update to use new complete()
2362 function defined in completer.h.
2363
2364 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
2365
2366 * MAINTAINERS (Write After Approval): Add myself.
2367
2368 2019-05-17 Tom de Vries <tdevries@suse.de>
2369
2370 PR gdb/24094
2371 * dwarf2read.c (struct cu_partial_die_info): New struct.
2372 (find_partial_die): Return cu_partial_die_info.
2373 (partial_die_parent_scope, guess_partial_die_structure_name)
2374 (partial_die_info::fixup): Handle new return type of find_partial_die.
2375
2376 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2377
2378 * stap-probe.c (stap_parse_register_operand): Make "regname" an
2379 "std::string", simplifying the algorithm.
2380
2381 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2382
2383 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2384 (stap_static_probe_ops::get_probes): Likewise.
2385
2386 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2387
2388 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2389 '-')" and "else if".
2390 (stap_parse_single_operand): Join checks for
2391 "gdbarch_stap_parse_special_token_p" and
2392 "gdbarch_stap_parse_special_token" in the same "if" statement.
2393 Invert check when verifying for operation on register
2394 displacement.
2395
2396 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2397
2398 * stap-probe.c (stap_get_opcode): Update comment.
2399 (stap_get_expected_argument_type): Likewise.
2400 (handle_stap_probe): Likewise.
2401
2402 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
2403
2404 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2405 return type to 'bool'. Adjust comment. Use 'bool' when
2406 appropriate.
2407 (i386_stap_parse_special_token_three_arg_disp): Likewise.
2408 * stap-probe.c (stap_parse_argument_1): Likewise.
2409 (stap_is_operator): Likewise.
2410 (stap_is_generic_prefix): Likewise.
2411 (stap_is_register_prefix): Likewise.
2412 (stap_is_register_indirection_prefix): Likewise.
2413 (stap_is_integer_prefix): Likewise.
2414 (stap_generic_check_suffix): Likewise.
2415 (stap_check_integer_suffix): Likewise.
2416 (stap_check_register_suffix): Likewise.
2417 (stap_check_register_indirection_suffix): Likewise.
2418 (stap_parse_register_operand): Likewise.
2419 (stap_parse_single_operand): Likewise.
2420 (stap_parse_argument_1): Likewise.
2421 (stap_probe::get_argument_count): Likewise.
2422 (stap_is_operator): Likewise.
2423
2424 2019-05-16 Tom Tromey <tromey@adacore.com>
2425
2426 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2427 keyword to foreach.
2428
2429 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
2430
2431 * linux-thread-db.c (try_thread_db_load_1): Change return type
2432 to bool.
2433 (try_thread_db_load): Likewise.
2434 (try_thread_db_load_from_pdir_1): Likewise.
2435 (try_thread_db_load_from_pdir): Likewise.
2436 (try_thread_db_load_from_sdir): Likewise.
2437 (try_thread_db_load_from_dir): Likewise.
2438 (thread_db_load_search): Likewise.
2439 (has_libpthread): Likewise.
2440 (thread_db_load): Likewise.
2441
2442 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
2443
2444 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2445 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2446 NULL, and complain/return if that's the case.
2447
2448 2019-05-15 John Darrington <john@darrington.wattle.id.au>
2449
2450 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2451 (advance, posn, abstract_read_memory): New functions.
2452 [struct mem_read_abstraction]: New struct.
2453 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2454
2455 2019-05-14 Tom Tromey <tromey@adacore.com>
2456
2457 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2458 value is not lval_memory.
2459
2460 2019-05-14 Tom Tromey <tromey@adacore.com>
2461
2462 * solib.c (info_sharedlibrary_command): Style the file name.
2463
2464 2019-05-14 Alan Hayward <alan.hayward@arm.com>
2465
2466 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2467 (aarch64_vnv_type): Likewise.
2468 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2469 * common/tdesc.c: Likewise.
2470 * common/tdesc.h (enum tdesc_type_kind): Likewise.
2471 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2472 * features/aarch64-fpu.xml: Add ieee half view.
2473 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2474 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2475 * gdbtypes.h (struct builtin_type): Likewise.
2476 (struct objfile_type): Likewise.
2477
2478 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
2479
2480 * language.c (language_sniff_from_mangled_name): Fix "langauge"
2481 typo.
2482 * location.h (string_to_event_location): Likewise.
2483
2484 2019-05-11 Joel Brobecker <brobecker@adacore.com>
2485
2486 GDB 8.3 released.
2487
2488 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
2489
2490 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2491 New variable declaration.
2492 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2493 New variable.
2494 (print_one_breakpoint): Use ui_out::test_flags and new global
2495 variable to compute use_fixed_output.
2496 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2497 Remove.
2498 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2499 (mi_multi_location_breakpoint_output_fixed): Remove.
2500 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2501 new variable.
2502 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2503 fix_multi_location_breakpoint_output flag if version >= 3.
2504 * ui-out.h (enum ui_out_flag)
2505 <fix_multi_location_breakpoint_output>: New enumerator.
2506
2507 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
2508
2509 * contrib/cc-with-tweaks.sh: Validate dwz's work.
2510
2511 2019-05-10 Tom Tromey <tromey@adacore.com>
2512
2513 * ada-lang.c (catch_ada_completer): New function.
2514 (_initialize_ada_language): Use it.
2515
2516 2019-05-10 Tom Tromey <tromey@adacore.com>
2517
2518 * thread.c (print_thread_info): Make "requested_threads" const.
2519 * gdbthread.h (print_thread_info): Make "requested_threads"
2520 const.
2521 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2522 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2523
2524 2019-05-08 Tom Tromey <tom@tromey.com>
2525
2526 * gdbtypes.c (objfile_type_data): Change type.
2527 (objfile_type, _initialize_gdbtypes): Update.
2528
2529 2019-05-08 Tom Tromey <tom@tromey.com>
2530
2531 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2532 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2533 (_initialize_dwarf2_frame): Update.
2534
2535 2019-05-08 Tom Tromey <tom@tromey.com>
2536
2537 * objc-lang.c (objc_objfile_data): Change type.
2538 (find_methods): Update.
2539 (_initialize_objc_lang): Remove.
2540
2541 2019-05-08 Tom Tromey <tom@tromey.com>
2542
2543 * stabsread.c (rs6000_builtin_type_data): Change type.
2544 (rs6000_builtin_type, _initialize_stabsread): Update.
2545
2546 2019-05-08 Tom Tromey <tom@tromey.com>
2547
2548 * mips-tdep.c (mips_pdr_data): Remove.
2549 (_initialize_mips_tdep): Update.
2550
2551 2019-05-08 Tom Tromey <tom@tromey.com>
2552
2553 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2554 (hppa_init_objfile_priv_data, read_unwind_info)
2555 (find_unwind_entry, _initialize_hppa_tdep): Update.
2556
2557 2019-05-08 Tom Tromey <tom@tromey.com>
2558
2559 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2560 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
2561 on obstack.
2562 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2563
2564 2019-05-08 Tom Tromey <tom@tromey.com>
2565
2566 * mdebugread.c (basic_type_data): Change type.
2567 (basic_type, _initialize_mdebugread): Update.
2568
2569 2019-05-08 Tom Tromey <tom@tromey.com>
2570
2571 * common/gdb_unique_ptr.h (struct noop_deleter): New.
2572
2573 2019-05-08 Tom Tromey <tom@tromey.com>
2574
2575 * nto-tdep.c (nto_inferior_data_reg): Change type.
2576 (nto_inferior_data): Update.
2577 (nto_inferior_data_cleanup, nto_new_inferior_data)
2578 (_initialize_nto_tdep): Remove.
2579 * nto-tdep.h (struct nto_inferior_data): Add initializers.
2580
2581 2019-05-08 Tom Tromey <tom@tromey.com>
2582
2583 * ada-lang.c (struct ada_inferior_data): Add initializers.
2584 (ada_inferior_data): Change type.
2585 (ada_inferior_data_cleanup): Remove.
2586 (get_ada_inferior_data, ada_inferior_exit)
2587 (struct ada_pspace_data): Add initializers, destructor.
2588 (ada_pspace_data_handle): Change type.
2589 (get_ada_pspace_data): Update.
2590 (ada_pspace_data_cleanup): Remove.
2591
2592 2019-05-08 Tom Tromey <tom@tromey.com>
2593
2594 * coffread.c (struct coff_symfile_info): Add initializers.
2595 (coff_objfile_data_key): Move lower. Change type.
2596 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2597 Update.
2598 (coff_free_info): Remove.
2599
2600 2019-05-08 Tom Tromey <tom@tromey.com>
2601
2602 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2603 (fbsd_pspace_data_handle): Move lower. Change type.
2604 (get_fbsd_pspace_data): Update.
2605 (fbsd_pspace_data_cleanup): Remove.
2606 (_initialize_fbsd_tdep): Update.
2607
2608 2019-05-08 Tom Tromey <tom@tromey.com>
2609
2610 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2611 (get_ada_tasks_pspace_data): Update.
2612 (ada_tasks_pspace_data_cleanup): Remove.
2613 (_initialize_tasks): Update.
2614 (ada_tasks_inferior_data_handle): Change type.
2615 (get_ada_tasks_inferior_data): Update.
2616 (ada_tasks_inferior_data_cleanup): Remove.
2617 (struct ada_tasks_pspace_data): Add initializers.
2618
2619 2019-05-08 Tom Tromey <tom@tromey.com>
2620
2621 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2622 * symfile-debug.c (debug_sym_get_probes): Change type.
2623 * stap-probe.c (handle_stap_probe):
2624 (stap_static_probe_ops::get_probes): Change type.
2625 * probe.h (class static_probe_ops) <get_probes>: Change type.
2626 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2627 (parse_probes_in_pspace): Update.
2628 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2629 Update.
2630 (any_static_probe_ops::get_probes): Change type.
2631 * elfread.c (elfread_data): New typedef.
2632 (probe_key): Change type.
2633 (elf_get_probes): Likewise. Update.
2634 (probe_key_free): Remove.
2635 (_initialize_elfread): Update.
2636 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2637 Change type.
2638 (dtrace_process_dof_probe, dtrace_process_dof)
2639 (dtrace_static_probe_ops::get_probe): Change type.
2640
2641 2019-05-08 Tom Tromey <tom@tromey.com>
2642
2643 * xcoffread.c (struct xcoff_symfile_info): Rename from
2644 coff_symfile_info. Add initializers.
2645 (xcoff_objfile_data_key): Move lower. Change type.
2646 (XCOFF_DATA): Rewrite.
2647 (xcoff_free_info): Remove.
2648 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2649 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2650 (xcoff_initial_scan): Update.
2651
2652 2019-05-08 Tom Tromey <tom@tromey.com>
2653
2654 * solib-svr4.c (struct svr4_info): Add initializers and
2655 destructor.
2656 <probes_table>: Now an htab_up.
2657 (solib_svr4_pspace_data): Change type.
2658 (free_probes_table): Simplify.
2659 (~svr4_info): Rename from svr4_pspace_data_cleanup.
2660 (get_svr4_info, probes_table_htab_remove_objfile_probes)
2661 (probes_table_remove_objfile_probes, register_solib_event_probe)
2662 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2663 (_initialize_svr4_solib): Update.
2664
2665 2019-05-08 Tom Tromey <tom@tromey.com>
2666
2667 * remote.c (remote_pspace_data): Change type.
2668 (remote_pspace_data_cleanup): Remove.
2669 (get_remote_exec_file, set_pspace_remote_exec_file)
2670 (_initialize_remote): Update.
2671
2672 2019-05-08 Tom Tromey <tom@tromey.com>
2673
2674 * breakpoint.c (breakpoint_objfile_key): Change type.
2675 (get_breakpoint_objfile_data): Update.
2676 (free_breakpoint_objfile_data): Remove.
2677 (_initialize_breakpoint): Update.
2678
2679 2019-05-08 Tom Tromey <tom@tromey.com>
2680
2681 * linux-tdep.c (struct linux_info): Add initializers.
2682 (linux_inferior_data): Move. Change type.
2683 (invalidate_linux_cache_inf): Update.
2684 (linux_inferior_data_cleanup): Remove.
2685 (get_linux_inferior_data, _initialize_linux_tdep): Update.
2686
2687 2019-05-08 Tom Tromey <tom@tromey.com>
2688
2689 * auxv.c (auxv_inferior_data): Move. Change type.
2690 (auxv_inferior_data_cleanup): Remove.
2691 (invalidate_auxv_cache_inf): Rewrite.
2692 (get_auxv_inferior_data, _initialize_auxv): Update.
2693
2694 2019-05-08 Tom Tromey <tom@tromey.com>
2695
2696 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2697 (symfile_debug_objfile_data_key): Change type.
2698 (symfile_debug_installed, debug_qf_has_symbols)
2699 (debug_qf_find_last_source_symtab)
2700 (debug_qf_forget_cached_source_info)
2701 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2702 (debug_qf_print_stats, debug_qf_dump)
2703 (debug_qf_expand_symtabs_for_function)
2704 (debug_qf_expand_all_symtabs)
2705 (debug_qf_expand_symtabs_with_fullname)
2706 (debug_qf_map_matching_symbols)
2707 (debug_qf_expand_symtabs_matching)
2708 (debug_qf_find_pc_sect_compunit_symtab)
2709 (debug_qf_map_symbol_filenames)
2710 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2711 (debug_sym_new_init, debug_sym_init, debug_sym_read)
2712 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2713 (debug_sym_read_linetable, debug_sym_relocate): Update.
2714 (symfile_debug_free_objfile): Remove.
2715 (install_symfile_debug_logging, _initialize_symfile_debug):
2716 Update.
2717
2718 2019-05-08 Tom Tromey <tom@tromey.com>
2719
2720 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2721 allocate_on_obstack.
2722 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2723 (get_dwarf2_per_objfile): Update.
2724 (set_dwarf2_per_objfile): Remove.
2725 (dwarf2_has_info, dwarf2_get_section_info): Update.
2726 (dwarf2_free_objfile): Remove.
2727 (_initialize_dwarf2_read): Update.
2728
2729 2019-05-08 Tom Tromey <tom@tromey.com>
2730
2731 * auto-load.c (struct auto_load_pspace_info): Add destructor and
2732 initializers.
2733 <unsupported_script_warning_printed,
2734 script_not_found_warning_printed>: Now bool.
2735 (auto_load_pspace_data): Change type.
2736 (~auto_load_pspace_info): Rename from
2737 auto_load_pspace_data_cleanup.
2738 (get_auto_load_pspace_data, init_loaded_scripts_info)
2739 (clear_section_scripts, maybe_print_unsupported_script_warning)
2740 (maybe_print_script_not_found_warning, _initialize_auto_load):
2741 Update.
2742
2743 2019-05-08 Tom Tromey <tom@tromey.com>
2744
2745 * objfiles.c (objfile_pspace_info): Add destructor and
2746 initializers.
2747 (objfiles_pspace_data): Change type.
2748 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2749 (get_objfile_pspace_data): Update.
2750 (objfiles_bfd_data): Change type.
2751 (get_objfile_bfd_data): Update.
2752 (objfile_bfd_data_free, _initialize_objfiles): Remove.
2753
2754 2019-05-08 Tom Tromey <tom@tromey.com>
2755
2756 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2757 Change type.
2758 (get_catch_syscall_inferior_data): Update.
2759 (catch_syscall_inferior_data_cleanup): Remove.
2760 (_initialize_break_catch_syscall): Update.
2761
2762 2019-05-08 Tom Tromey <tom@tromey.com>
2763
2764 * inflow.c (struct terminal_info): Add destructor and
2765 initializers.
2766 (inflow_inferior_data): Change type.
2767 (~terminal_info): Rename from inflow_inferior_data_cleanup.
2768 (get_inflow_inferior_data, inflow_inferior_exit)
2769 (swap_terminal_info, _initialize_inflow): Update.
2770
2771 2019-05-08 Tom Tromey <tom@tromey.com>
2772
2773 * target-dcache.c (target_dcache_cleanup): Remove.
2774 (target_dcache_aspace_key): Change type.
2775 (target_dcache_init_p, target_dcache_invalidate)
2776 (target_dcache_get, target_dcache_get_or_init)
2777 (_initialize_target_dcache): Update.
2778 * dcache.h (struct dcache_deleter): New.
2779
2780 2019-05-08 Tom Tromey <tom@tromey.com>
2781
2782 * symtab.c (struct symbol_cache): Add destructor and
2783 initializers.
2784 (symbol_cache_key): Move. Change type.
2785 (make_symbol_cache, free_symbol_cache): Remove.
2786 (get_symbol_cache): Update.
2787 (symbol_cache_cleanup): Remove.
2788 (ALL_PSPACES, symbol_cache_flush)
2789 (maintenance_print_symbol_cache)
2790 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2791 Update.
2792
2793 2019-05-08 Tom Tromey <tom@tromey.com>
2794
2795 * symtab.c (struct main_info): Add destructor and initializers.
2796 (main_progspace_key): Move. Change type.
2797 (get_main_info): Update.
2798 (main_info_cleanup): Remove.
2799 (_initialize_symtab): Update.
2800
2801 2019-05-08 Tom Tromey <tom@tromey.com>
2802
2803 * registry.h (DECLARE_REGISTRY): Define the _key class.
2804
2805 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
2806
2807 * NEWS: Merge two 'New commands' sections.
2808
2809 2019-05-08 Joel Brobecker <brobecker@adacore.com>
2810
2811 * ada-valprint.c (ada_val_print_gnat_array): Remove language
2812 parameter and use Ada language definition instead.
2813 (ada_val_print_ptr): Remove unused language parameter.
2814 (ada_val_print_num): Remove language parameter and use Ada language
2815 definition instead.
2816 (ada_val_print_enum, ada_val_print_flt): Remove unused language
2817 parameter.
2818 (ada_val_print_struct_union, ada_val_print_ref): Remove language
2819 parameter and use Ada language definition instead.
2820 (ada_val_print_1): Update all ada_val_print_xxx calls.
2821 Remove language parameter.
2822 (ada_val_print): Update ada_val_print_1 call.
2823
2824 2019-05-08 Tom Tromey <tromey@adacore.com>
2825
2826 * remote.c (remote_hw_watchpoint_limit)
2827 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2828 Now static.
2829
2830 2019-05-08 Tom Tromey <tromey@adacore.com>
2831
2832 * maint.c (_initialize_maint_cmds): Move initialization code to
2833 remote.c.
2834 (watchdog, show_watchdog): Move to remote.c.
2835 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
2836 "watchdog" static.
2837 (_initialize_remote): Move initialization code from maint.c.
2838 * defs.h (watchdog): Don't declare.
2839
2840 2019-05-08 Tom Tromey <tromey@adacore.com>
2841
2842 * tui/tui-interp.c: Include main.h.
2843 * interps.c: Include main.h.
2844 * main.h (interpreter_p): Declare.
2845 * defs.h (interpreter_p): Don't declare.
2846
2847 2019-05-08 Tom Tromey <tromey@adacore.com>
2848
2849 * dwarf2loc.c: Include dwarf2read.h.
2850 * defs.h (read_unsigned_leb128): Don't declare.
2851 * dwarf2read.h (read_unsigned_leb128): Declare.
2852
2853 2019-05-08 Tom Tromey <tromey@adacore.com>
2854
2855 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2856 method.
2857
2858 2019-05-08 Tom Tromey <tromey@adacore.com>
2859
2860 * utils.c (fputs_maybe_filtered): Reset style after paging, even
2861 when no wrap column is set.
2862
2863 2019-05-08 Tom Tromey <tromey@adacore.com>
2864
2865 * c-lang.c (c_get_string): Handle non-C-style arrays.
2866
2867 2019-05-08 Tom Tromey <tromey@adacore.com>
2868
2869 * typeprint.c (print_offset_data::update): Print the bit offset,
2870 not the number of bits remaining.
2871
2872 2019-05-08 Tom Tromey <tromey@adacore.com>
2873
2874 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2875 padding at end of comment.
2876
2877 2019-05-08 Tom Tromey <tromey@adacore.com>
2878
2879 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2880 Compare main types.
2881
2882 2019-05-06 Tom Tromey <tom@tromey.com>
2883
2884 * common/scoped_mmap.c: Include common-defs.h.
2885 * common/scoped_mmap.h: Don't include config.h.
2886
2887 2019-05-04 Tom Tromey <tom@tromey.com>
2888
2889 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2890 (struct aarch64_call_info): Add initializers.
2891 <si>: Now a std::vector.
2892 (pass_on_stack, aarch64_push_dummy_call): Update.
2893
2894 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
2895 Tom Tromey <tom@tromey.com>
2896
2897 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2898 (ppc_threads): Now a std::vector. Now static.
2899 (hwdebug_find_thread_points_by_tid)
2900 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2901 Update.
2902
2903 2019-05-04 Tom Tromey <tom@tromey.com>
2904
2905 * arc-tdep.c (arc_tdesc_init): Return bool.
2906
2907 2019-05-04 Tom Tromey <tom@tromey.com>
2908
2909 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2910 Use gdb_assert_not_reached.
2911
2912 2019-05-04 Tom Tromey <tom@tromey.com>
2913
2914 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2915 "false".
2916
2917 2019-05-04 Tom Tromey <tom@tromey.com>
2918
2919 * arc-tdep.c (arc_tdesc_init): Use bool.
2920
2921 2019-05-04 Tom Tromey <tom@tromey.com>
2922
2923 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2924
2925 2019-05-04 Tom Tromey <tom@tromey.com>
2926
2927 * cli/cli-cmds.c (valid_command_p): Return bool.
2928
2929 2019-05-04 Tom Tromey <tom@tromey.com>
2930
2931 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2932 * command.h (valid_user_defined_cmd_name_p): Channge return type.
2933
2934 2019-05-04 Raul Tambre <raul@tambre.ee>
2935
2936 * python/lib/gdb/prompt.py (_ExtendedPrompt)
2937 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2938 operator for comparison.
2939
2940 2019-05-04 Tom Tromey <tom@tromey.com>
2941
2942 * psymtab.c (psymbol_name_matches, match_partial_symbol)
2943 (lookup_partial_symbol, print_partial_symbols)
2944 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2945 (psymbol_compare): Update.
2946 (add_psymbol_to_bcache): Clear the entire psymbol.
2947 (maintenance_check_psymtabs): Update.
2948 * psympriv.h (struct partial_symbol): Don't derive from
2949 general_symbol_info.
2950 <obj_section, unrelocated_address, address,
2951 set_unrelocated_address>: Update.
2952 <ginfo>: New member.
2953 * dwarf-index-write.c (write_psymbols, debug_names::insert)
2954 (debug_names::write_psymbols): Update.
2955
2956 2019-05-04 Tom de Vries <tdevries@suse.de>
2957
2958 * contrib/cc-with-tweaks.sh: Support -n arg.
2959
2960 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2961
2962 * corelow.c (core_target::detach): Ensure frame cache and
2963 register caches are cleared.
2964 inferior.c (exit_inferior_1): Likewise.
2965
2966 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
2967 Tom Tromey <tom@tromey.com>
2968
2969 * dictionary.c (collate_pending_symbols_by_language): Remove
2970 "struct" from foreach.
2971 * symtab.c (lookup_global_symbol_from_objfile)
2972 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2973 foreach.
2974 * ser-tcp.c (net_open): Remove "struct" from foreach.
2975 * objfiles.c (objfile_relocate, objfile_rebase)
2976 (objfile_has_symbols): Remove "struct" from foreach.
2977 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2978 from foreach.
2979 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2980 foreach.
2981 * darwin-nat.c (thread_info_from_private_thread_info): Remove
2982 "struct" from foreach.
2983 * ada-lang.c (create_excep_cond_exprs)
2984 (ada_exception_catchpoint_cond_string): Remove "struct" from
2985 foreach.
2986
2987 2019-05-03 Tom Tromey <tromey@adacore.com>
2988
2989 * ada-exp.y (convert_char_literal): Check suffix of each
2990 enumerator.
2991
2992 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
2993
2994 PR ada/21406:
2995 * ada-exp.y (yywrap): Don't define.
2996 * ada-lex.l (%option): Add noyywrap
2997 (yywrap): Remove.
2998
2999 2019-05-03 Eli Zaretskii <eliz@gnu.org>
3000
3001 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3002 _WIN32_WINNT to the XP level, unless already defined to a higher
3003 level.
3004
3005 * unittests/parse-connection-spec-selftests.c:
3006 * ser-tcp.c:
3007 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
3008 override.
3009
3010 * symfile.c (find_separate_debug_file): Remove colon from the
3011 drive spec of DOS/Windows file names of the target, so that the
3012 file name produced from DEBUGDIR and the target's directory will
3013 be valid on DOS/Windows systems.
3014
3015 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
3016
3017 * rust-lang.c (val_print_struct): Handle printing structures
3018 containing strings.
3019
3020 2019-05-02 Tom Tromey <tromey@adacore.com>
3021
3022 * valarith.c (_initialize_valarith): Remove.
3023
3024 2019-05-01 Tom Tromey <tromey@adacore.com>
3025
3026 * ada-lang.c (ada_value_primitive_field): Treat more fields as
3027 bitfields.
3028
3029 2019-05-01 Tom Tromey <tromey@adacore.com>
3030
3031 * ada-lang.c (ada_value_assign): Correctly compute starting offset
3032 for big-endian copies.
3033
3034 2019-04-30 Ali Tamur <tamur@google.com>
3035 * gdb/dwarf2read.c (read_3_bytes): New declaration.
3036 (read_attribute_value): Added DW_FORM_strx1-4 cases.
3037 (read_3_bytes): New function.
3038
3039 2019-04-30 Joel Brobecker <brobecker@adacore.com>
3040
3041 * windows-nat.c (main_thread_id): Delete.
3042 (handle_output_debug_string): Replace main_thread_id by
3043 current_event.dwThreadId.
3044 (fake_create_process): Likewise.
3045 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3046 Do not set main_thread_id.
3047 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3048 current_event.dwThreadId.
3049 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3050
3051 2019-04-30 Joel Brobecker <brobecker@adacore.com>
3052
3053 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3054 Use current_event.dwThreadId instead of main_thread_id.
3055
3056 2019-04-30 Tom Tromey <tromey@adacore.com>
3057
3058 * ada-lang.c (ada_lookup_simple_minsyms): New function.
3059 (create_excep_cond_exprs): Iterate over program spaces.
3060 (ada_exception_catchpoint_cond_string): Examine all minimal
3061 symbols for exception types.
3062
3063 2019-04-30 Tom Tromey <tromey@adacore.com>
3064
3065 PR c++/24470:
3066 * dwarf2read.c (process_structure_scope): Handle case where type
3067 has template parameters but no symbol was created.
3068
3069 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3070 Chris January <chris.january@arm.com>
3071
3072 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3073 qualifier.
3074 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3075
3076 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3077
3078 * f-typeprint.c (f_print_type): Update rules for printing
3079 whitespace.
3080 (f_type_print_varspec_suffix): Likewise.
3081
3082 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3083 Chris January <chris.january@arm.com>
3084
3085 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3086 function arguments.
3087
3088 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3089
3090 * f-lang.c (build_fortran_types): Change name of void type to
3091 lower case.
3092 * f-typeprint.c (f_type_print_base): Print the name of the void
3093 type, rather than a fixed string.
3094 * f-valprint.c (f_decorations): Use lower case void string.
3095
3096 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3097 Chris January <chris.january@arm.com>
3098
3099 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3100 types for Fortran.
3101
3102 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3103 Chris January <chris.january@arm.com>
3104 David Lecomber <david.lecomber@arm.com>
3105
3106 * f-exp.y (BINOP_INTRINSIC): New token.
3107 (exp): New parser rule handling BINOP_INTRINSIC.
3108 (f77_keywords): Add new builtin procedures.
3109 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3110 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3111 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3112 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3113 (print_unop_subexp_f): New function.
3114 (print_binop_subexp_f): New function.
3115 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3116 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3117 (dump_subexp_body_f): Likewise.
3118 (operator_check_f): Likewise.
3119 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3120 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3121
3122 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3123
3124 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3125 UNOP_KIND.
3126 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3127 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3128 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3129 (operator_length_f): New fuction.
3130 (print_subexp_f): New function.
3131 (op_name_f): New function.
3132 (dump_subexp_body_f): New function.
3133 (operator_check_f): New function.
3134 (exp_descriptor_f): Replace standard expression handling functions
3135 with new functions.
3136 * gdb/fortran-operator.def: New file.
3137 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3138 * gdb/std-operator.def: Remove UNOP_KIND.
3139
3140 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
3141
3142 * std-operator.def: Remove unbalanced, stray double quote
3143 character.
3144
3145 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3146 Chris January <chris.january@arm.com>
3147 Daniel Everett <daniel.everett@arm.com>
3148 Nick Forrington <nick.forrington@arm.com>
3149 Richard Bunt <richard.bunt@arm.com>
3150
3151 * cp-valprint.c (cp_print_value_fields): Allow an additional level
3152 of depth when printing anonymous structs or unions.
3153 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3154 Don't print either the top-level value, or the children if the
3155 max-depth is exceeded.
3156 (ppscm_print_children): When printing the key of a map, allow one
3157 extra level of depth.
3158 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3159 print either the top-level value, or the children if the max-depth
3160 is exceeded.
3161 (print_children): When printing the key of a map, allow one extra
3162 level of depth.
3163 * python/py-value.c (valpy_format_string): Add max_depth keyword.
3164 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3165 (user_print_options): Initialise max_depth field.
3166 (val_print_scalar_or_string_type_p): New function.
3167 (val_print): Check to see if the max depth has been reached.
3168 (val_print_check_max_depth): Define new function.
3169 (show_print_max_depth): New function.
3170 (_initialize_valprint): Add 'print max-depth' option.
3171 * valprint.h (struct value_print_options) <max_depth>: New field.
3172 (val_print_check_max_depth): Declare new function.
3173 * NEWS: Document new feature.
3174
3175 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3176
3177 * ada-lang.c (ada_language_defn): Initialise new field.
3178 * c-lang.c (c_is_string_type_p): New function.
3179 (c_language_defn): Initialise new field.
3180 (cplus_language_defn): Initialise new field.
3181 (asm_language_defn): Initialise new field.
3182 (minimal_language_defn): Initialise new field.
3183 * c-lang.h (c_is_string_type_p): Declare new function.
3184 * d-lang.c (d_language_defn): Initialise new field.
3185 * f-lang.c (f_is_string_type_p): New function.
3186 (f_language_defn): Initialise new field.
3187 * go-lang.c (go_is_string_type_p): New function.
3188 (go_language_defn): Initialise new field.
3189 * language.c (default_is_string_type_p): New function.
3190 (unknown_language_defn): Initialise new field.
3191 (auto_language_defn): Initialise new field.
3192 * language.h (struct language_defn) <la_is_string_type_p>: New
3193 member variable.
3194 (default_is_string_type_p): Declare new function.
3195 * m2-lang.c (m2_language_defn): Initialise new field.
3196 * objc-lang.c (objc_language_defn): Initialise new field.
3197 * opencl-lang.c (opencl_language_defn): Initialise new field.
3198 * p-lang.c (pascal_is_string_type_p): New function.
3199 (pascal_language_defn): Initialise new field.
3200 * rust-lang.c (rust_is_string_type_p): New function.
3201 (rust_language_defn): Initialise new field.
3202
3203 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3204
3205 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3206 New field.
3207 * ada-lang.c (ada_language_defn): Initialise new field.
3208 * c-lang.c (c_language_defn): Likewise.
3209 (cplus_language_defn): Likewise.
3210 (asm_language_defn): Likewise.
3211 (minimal_language_defn): Likewise.
3212 * d-lang.c (d_language_defn): Likewise.
3213 * f-lang.c (f_language_defn): Likewise.
3214 * go-lang.c (go_language_defn): Likewise.
3215 * language.c (unknown_language_defn): Likewise.
3216 (auto_language_defn): Likewise.
3217 * m2-lang.c (m2_language_defn): Likewise.
3218 * objc-lang.c (objc_language_defn): Likewise.
3219 * opencl-lang.c (opencl_language_defn): Likewise.
3220 * p-lang.c (pascal_language_defn): Likewise.
3221 * rust-lang.c (rust_language_defn): Likewise.
3222
3223 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
3224
3225 * ada-lang.c (ada_is_character_type): Change return type to bool.
3226 (ada_is_string_type): Likewise.
3227 * ada-lang.h (ada_is_character_type): Update declaration
3228 (ada_is_string_type): Likewise.
3229
3230 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3231
3232 Support style in 'frame|thread apply'
3233
3234 * gdbcmd.h (execute_command_to_string): New term_out parameter.
3235 * record.c (record_start, record_stop): Update callers of
3236 execute_command_to_string with false.
3237 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3238 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3239 methods.
3240 (class string_file): New constructor with term_out parameter.
3241 Override methods term_out and can_emit_style_escape. New member
3242 term_out.
3243 (class stdio_file): Override can_emit_style_escape.
3244 (class tee_file): Override term_out and can_emit_style_escape.
3245 * utils.h (can_emit_style_escape): Remove.
3246 * utils.c (can_emit_style_escape): Likewise.
3247 Update all callers of can_emit_style_escape (SOMESTREAM) to
3248 SOMESTREAM->can_emit_style_escape.
3249 * source-cache.c (source_cache::get_source_lines): Likewise.
3250 * stack.c (frame_apply_command_count): Call execute_command_to_string
3251 passing the term_out characteristic of the current gdb_stdout.
3252 * thread.c (thr_try_catch_cmd): Likewise.
3253 * top.c (execute_command_to_string): pass term_out parameter
3254 to construct the string_file for the command output.
3255 * ui-file.c (term_cli_styling): New function (most code moved
3256 from utils.c can_emit_style_escape).
3257 (string_file::string_file, string_file::can_emit_style_escape,
3258 stdio_file::can_emit_style_escape, tee_file::term_out,
3259 tee_file::can_emit_style_escape): New functions.
3260
3261 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3262
3263 * NEWS: Mention the new set|show may-call-functions.
3264 * infcall.c (may_call_functions_p): New variable.
3265 (show_may_call_functions_p): New function.
3266 (call_function_by_hand_dummy): Throws an error if not
3267 may-call-functions.
3268 (_initialize_infcall): Call add_setshow_boolean_cmd for
3269 may-call-functions.
3270
3271 2019-04-25 Keith Seitz <keiths@redhat.com>
3272
3273 PR c++/24367
3274 * cp-support.c (inspect_type): Don't attempt substitutions
3275 of symbol with the same name.
3276
3277 2019-04-25 Tom Tromey <tromey@adacore.com>
3278
3279 PR gdb/24475:
3280 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3281 static.
3282
3283 2019-04-25 Tom Tromey <tromey@adacore.com>
3284
3285 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3286 rvalue reference.
3287 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3288 (gdb_xml_parser::parse): Use std::move.
3289 * python/python-internal.h (gdbpy_convert_exception): Take a const
3290 reference.
3291 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3292 std::move.
3293 * python/py-utils.c (gdbpy_convert_exception): Take a const
3294 reference.
3295 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3296 Use std::move.
3297 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3298 Use std::move.
3299 * mi/mi-main.c (mi_print_exception): Take a const reference.
3300 * main.c (handle_command_errors): Take a const reference.
3301 * linespec.c (parse_linespec): Use std::move.
3302 * infcall.c (run_inferior_call): Use std::move.
3303 (call_function_by_hand_dummy): Use std::move.
3304 * exec.c (try_open_exec_file): Use std::move.
3305 * exceptions.h (exception_print, exception_fprintf)
3306 (exception_print_same): Update.
3307 * exceptions.c (print_exception, exception_print)
3308 (exception_fprintf, exception_print_same): Change parameters to
3309 const reference.
3310 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3311 * common/new-op.c: Use std::move.
3312 * common/common-exceptions.h (struct gdb_exception): Add move
3313 constructor.
3314 (struct gdb_exception_error, struct gdb_exception_quit, struct
3315 gdb_quit_bad_alloc): Change constructor to move constructor.
3316 (throw_exception): Change parameter to rvalue reference.
3317 * common/common-exceptions.c (throw_exception): Take rvalue
3318 reference.
3319 * cli/cli-interp.c (safe_execute_command): Use std::move.
3320 * breakpoint.c (insert_bp_location, location_to_sals): Use
3321 std::move.
3322
3323 2019-04-25 Tom Tromey <tromey@adacore.com>
3324
3325 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3326 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3327 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3328 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3329 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3330 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3331 guile/scm-value.c: Use unpack.
3332 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3333 gdbscm_gdb_exception.
3334 (gdbscm_throw_gdb_exception): Likewise.
3335 (struct gdbscm_gdb_exception): New.
3336 (unpack): New function.
3337 (gdbscm_wrap): Use unpack.
3338
3339 2019-04-25 Tom Tromey <tromey@adacore.com>
3340
3341 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3342 (gdb_rl_callback_handler): Use std::move.
3343 * common/common-exceptions.h (struct gdb_exception): Add move
3344 assignment operator.
3345 (throw_exception_sjlj): Change "exception" to const reference.
3346 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3347 (throw_exception_sjlj): Change "exception" to const reference.
3348
3349 2019-04-25 Tom Tromey <tromey@adacore.com>
3350
3351 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3352 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3353 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3354 Update.
3355 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3356 Update.
3357 * mi/mi-interp.c (mi_interp::exec): Update.
3358 * linespec.c (parse_linespec): Update.
3359 * infcall.c (run_inferior_call): Update.
3360 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3361 * guile/scm-symbol.c (gdbscm_lookup_symbol)
3362 (gdbscm_lookup_global_symbol): Update.
3363 * guile/scm-param.c (gdbscm_parameter_value): Update.
3364 * guile/scm-frame.c (gdbscm_frame_read_register)
3365 (gdbscm_frame_read_var): Update.
3366 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3367 * exec.c (try_open_exec_file): Update.
3368 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3369 (gdb_rl_callback_handler): Update.
3370 * common/common-exceptions.h (exception_none): Don't declare.
3371 * common/common-exceptions.c (exception_none): Don't define.
3372 (struct catcher) <exception>: Update.
3373 * cli/cli-interp.c (safe_execute_command): Update.
3374 * breakpoint.c (insert_bp_location, location_to_sals): Update.
3375
3376 2019-04-25 Ali Tamur <tamur@google.com>
3377
3378 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3379 (read_attribute_value): Likewise.
3380 (dwarf2_read_addr_index): Update comment.
3381 (read_str_index): Add DW_FORM_strx.
3382 (dwarf2_string_attr): Likewise.
3383 (dwarf2_const_value_attr): Likewise.
3384 (dump_die_shallow): Likewise.
3385 (dwarf2_fetch_constant_bytes): Likewise.
3386 (skip_form_bytes): Likewise.
3387 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3388
3389 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
3390
3391 PR corefiles/11608
3392 PR corefiles/18187
3393 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3394 OFFSET. Verify if current mapping contains an ELF header.
3395 (linux_find_memory_regions_full): Adjust call to
3396 dump_mapping_p.
3397
3398 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
3399 Kang Li <kanglictf@gmail.com>
3400
3401 PR gdb/21600
3402
3403 * dwarf2-frame.c (read_initial_length): Be consistent about using
3404 unsigned representation of length.
3405 (decode_frame_entry_1): Likewise. Check for wraparound of
3406 end pointer as well as buffer overflow.
3407
3408 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
3409
3410 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3411 "vq".
3412
3413 2019-04-24 Tom Tromey <tromey@adacore.com>
3414
3415 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3416
3417 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3418
3419 * s12z-tdep.c (s12z_unwind_pc): Delete.
3420 (s12z_unwind_sp): Delete.
3421 (s12z_gdbarch_init): Don't register deleted functions with
3422 gdbarch.
3423
3424 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3425
3426 * rl78-tdep.c (rl78_unwind_sp): Delete.
3427 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3428
3429 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3430
3431 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3432 (xstormy16_unwind_pc): Delete.
3433 (xstormy16_dummy_id): Delete.
3434 (xstormy16_gdbarch_init): Don't register deleted functions with
3435 gdbarch.
3436
3437 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3438
3439 * vax-tdep.c (vax_unwind_pc): Delete.
3440 (vax_gdbarch_init): Don't register deleted function with gdbarch.
3441
3442 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3443
3444 * v850-tdep.c (v850_unwind_sp): Delete.
3445 (v850_unwind_pc): Delete.
3446 (v850_dummy_id): Delete.
3447 (v850_gdbarch_init): Don't register deleted functions with
3448 gdbarch.
3449
3450 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3451
3452 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3453 (tilegx_unwind_pc): Delete.
3454 (tilegx_unwind_dummy_id): Delete.
3455 (tilegx_gdbarch_init): Don't register deleted functions with
3456 gdbarch.
3457
3458 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3459
3460 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3461 (tic6x_dummy_id): Delete.
3462 (tic6x_gdbarch_init): Don't register deleted functions with
3463 gdbarch.
3464
3465 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3466
3467 * sparc-tdep.c (sparc_unwind_pc): Delete.
3468 (sparc32_gdbarch_init): Don't register deleted function with
3469 gdbarch.
3470
3471 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3472
3473 * sh-tdep.c (sh_unwind_sp): Delete.
3474 (sh_unwind_pc): Delete.
3475 (sh_dummy_id): Delete.
3476 (sh_gdbarch_init): Don't register deleted functions with
3477 gdbarch.
3478
3479 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3480
3481 * score-tdep.c (score_unwind_sp): Delete.
3482 (score_unwind_pc): Delete.
3483 (score_dummy_id): Delete.
3484 (score_gdbarch_init): Don't register deleted functions with
3485 gdbarch.
3486
3487 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3488
3489 * rx-tdep.c (rx_unwind_pc): Delete.
3490 (rx_unwind_sp): Delete.
3491 (rx_dummy_id): Delete.
3492 (rx_gdbarch_init): Don't register deleted functions with
3493 gdbarch. Update comment.
3494
3495 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3496
3497 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3498 (rs6000_dummy_id): Delete.
3499 (rs6000_gdbarch_init): Don't register deleted functions with
3500 gdbarch.
3501
3502 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3503
3504 * or1k-tdep.c (or1k_dummy_id): Delete.
3505 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3506
3507 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3508
3509 * nios2-tdep.c (nios2_dummy_id): Delete.
3510 (nios2_unwind_sp): Delete.
3511 (nios2_gdbarch_init): Don't register deleted functions with
3512 gdbarch.
3513
3514 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3515
3516 * nds32-tdep.c (nds32_dummy_id): Delete.
3517 (nds32_unwind_pc): Delete.
3518 (nds32_unwind_sp): Delete.
3519 (nds32_gdbarch_init): Don't register deleted functions with
3520 gdbarch.
3521
3522 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3523
3524 * msp430-tdep.c (msp430_unwind_pc): Delete.
3525 (msp430_unwind_sp): Delete.
3526 (msp430_dummy_id): Delete.
3527 (msp430_gdbarch_init): Don't register deleted functions with
3528 gdbarch.
3529
3530 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3531
3532 * moxie-tdep.c (moxie_unwind_sp): Delete.
3533 (moxie_unwind_pc): Delete.
3534 (moxie_dummy_id): Delete.
3535 (moxie_gdbarch_init): Don't register deleted functions with
3536 gdbarch.
3537
3538 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3539
3540 * mn10300-tdep.c (mn10300_dummy_id): Delete.
3541 (mn10300_unwind_pc): Delete.
3542 (mn10300_unwind_sp): Delete.
3543 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3544 mn10300_unwind_sp.
3545 (mn10300_frame_unwind_init): Don't register deleted functions with
3546 gdbarch.
3547
3548 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3549
3550 * mep-tdep.c (mep_unwind_pc): Delete.
3551 (mep_unwind_sp): Delete.
3552 (mep_dummy_id): Delete.
3553 (mep_gdbarch_init): Don't register deleted functions with
3554 gdbarch.
3555
3556 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3557
3558 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3559 (m68hc11_unwind_sp): Delete.
3560 (m68hc11_gdbarch_init): Don't register deleted functions with
3561 gdbarch.
3562
3563 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3564
3565 * m32r-tdep.c (m32r_unwind_sp): Delete.
3566 (m32r_unwind_pc): Delete.
3567 (m32r_dummy_id): Delete.
3568 (m32r_gdbarch_init): Don't register deleted functions with
3569 gdbarch.
3570
3571 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3572
3573 * m32c-tdep.c (m32c_unwind_pc): Delete.
3574 (m32c_unwind_sp): Delete.
3575 (m32c_dummy_id): Delete.
3576 (m32c_gdbarch_init): Don't register deleted functions with
3577 gdbarch.
3578
3579 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3580
3581 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3582 (lm32_unwind_pc): Delete.
3583 (lm32_dummy_id): Delete.
3584 (lm32_gdbarch_init): Don't register deleted functions with
3585 gdbarch.
3586
3587 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3588
3589 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3590 (iq2000_unwind_pc): Delete.
3591 (iq2000_dummy_id): Delete.
3592 (iq2000_gdbarch_init): Don't register deleted functions with
3593 gdbarch.
3594
3595 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3596
3597 * nds32-tdep.c (nds32_type_align): Delete.
3598 (nds32_push_dummy_call): Use type_align instead.
3599
3600 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3601
3602 * arm-tdep.c (arm_type_align): Only handle vector override case.
3603 (arm_push_dummy_call): Use type_align.
3604 (arm_gdbarch_init): Register arm_type_align gdbarch function.
3605
3606 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
3607
3608 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3609 case.
3610 (pass_on_stack): Use type_align.
3611 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3612 function.
3613
3614 2019-04-23 Tom Tromey <tromey@adacore.com>
3615
3616 * dwarf2read.c (line_header::file_name_at): Remove unused
3617 overload.
3618
3619 2019-04-23 Tom de Vries <tdevries@suse.de>
3620
3621 PR gdb/24438
3622 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3623 invocation.
3624
3625
3626 2019-03-27 Ali Tamur <tamur@google.com>
3627
3628 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3629 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3630 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3631 (dwarf_expr_context::get_addr_index): Likewise
3632 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3633 (symbol_needs_eval_context::get_addr_index): Likewise
3634 (disassemble_dwarf_expression): Add DW_OP_addrx
3635 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3636 (read_cutu_die_from_dwo): Update comment
3637 (skip_one_die): Add DW_FORM_addrx
3638 (read_attribute_value): Likewise
3639 (var_decode_location): Add DW_OP_addrx
3640 (dwarf2_const_value_attr): Add DW_FORM_addrx
3641 (dump_die_shallow): Likewise
3642 (dwarf2_fetch_constant_bytes): Likewise
3643 (decode_locdesc): Add DW_OP_addrx
3644 (skip_form_bytes): Add DW_FORM_addrx
3645
3646 2019-04-22 Ali Tamur <tamur@google.com>
3647
3648 * MAINTAINERS (Write After Approval): Add self.
3649
3650 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
3651
3652 * solib-svr4.c (get_svr4_info): Add pspace parameter.
3653 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3654 (open_symbol_file_object): Likewise.
3655 (svr4_default_sos): Add info parameter.
3656 (svr4_read_so_list): Likewise.
3657 (svr4_current_sos_direct): Adjust functions calls to pass down
3658 info.
3659 (svr4_current_sos_1): Add info parameter.
3660 (svr4_current_sos): Call get_svr4_info, pass info down to
3661 svr4_current_sos_1.
3662 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3663 get_svr4_info.
3664 (svr4_in_dynsym_resolve_code): Pass current_program_space to
3665 get_svr4_info.
3666 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3667 to get_svr4_info.
3668 (probes_table_remove_objfile_probes): Likewise.
3669 (register_solib_event_probe): Add info parameter.
3670 (solist_update_incremental): Pass info parameter down to
3671 svr4_read_so_list.
3672 (disable_probes_interface): Add info parameter.
3673 (svr4_handle_solib_event): Pass current_program_space to
3674 get_svr4_info. Adjust disable_probes_interface cleanup.
3675 (svr4_create_probe_breakpoints): Add info parameter, pass it
3676 down to register_solib_event_probe.
3677 (svr4_create_solib_event_breakpoints): Add info parameter,
3678 pass it down to svr4_create_probe_breakpoints.
3679 (enable_break): Pass info down to
3680 svr4_create_solib_event_breakpoints.
3681 (svr4_solib_create_inferior_hook): Pass current_program_space to
3682 get_svr4_info.
3683 (svr4_clear_solib): Likewise.
3684
3685 2019-04-22 Pedro Alves <palves@redhat.com>
3686
3687 * solib-svr4.c (svr4_free_objfile_observer): New.
3688 (probe_and_action::objfile): New field.
3689 (probes_table_htab_remove_objfile_probes)
3690 (probes_table_remove_objfile_probes): New functions.
3691 (register_solib_event_probe): Add 'objfile' parameter. Store it
3692 in the new probe_and_action. Don't store the probe in 'lookup'.
3693 (svr4_create_probe_breakpoints): Pass objfile to
3694 register_solib_event_probe.
3695 (_initialize_svr4_solib): Register a free_objfile observer.
3696
3697 2019-04-19 Tom Tromey <tom@tromey.com>
3698
3699 * common/queue.h: Remove.
3700
3701 2019-04-19 Tom Tromey <tom@tromey.com>
3702
3703 * event-loop.c: Don't include "common/queue.h".
3704
3705 2019-04-19 Tom Tromey <tom@tromey.com>
3706
3707 * remote.c (remote_target): Use delete.
3708 * remote-notif.h: Include <list>, not "common/queue.h".
3709 (notif_client_p): Remove typedef.
3710 (remote_notif_state): Add constructor, destructor, initializer.
3711 <notif_queue>: Now a std::list.
3712 (remote_notif_state_xfree): Don't declare.
3713 * remote-notif.c (remote_notif_process, handle_notification)
3714 (remote_notif_state_allocate): Update.
3715 (~remote_notif_state): Rename from remote_notif_state_xfree.
3716
3717 2019-04-19 Tom Tromey <tom@tromey.com>
3718
3719 * symfile.c (reread_symbols): Update.
3720 * objfiles.c (objfile_register_static_link)
3721 (objfile_lookup_static_link): Update
3722 (~objfile) Don't delete static_links.
3723 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3724
3725 2019-04-19 Tom Tromey <tom@tromey.com>
3726
3727 * type-stack.h (struct type_stack) <insert>: Constify string.
3728 * type-stack.c (type_stack::insert): Constify string.
3729 * gdbtypes.h (lookup_template_type): Update.
3730 (address_space_name_to_int): Update.
3731 * gdbtypes.c (address_space_name_to_int): Make space_identifier
3732 const.
3733 (lookup_template_type): Make name const.
3734 * c-exp.y: Update rules.
3735 (lex_one_token, classify_name, classify_inner_name)
3736 (c_print_token): Update.
3737 * p-exp.y: Update rules.
3738 (yylex): Update.
3739 * f-exp.y: Update rules.
3740 (yylex): Update.
3741 * d-exp.y: Update rules.
3742 (lex_one_token, classify_name, classify_inner_name): Update.
3743 * parse.c (write_dollar_variable, copy_name): Return std::string.
3744 * parser-defs.h (copy_name): Change return type.
3745 * m2-exp.y: Update rules.
3746 (yylex): Update.
3747 * go-exp.y (lex_one_token): Update.
3748 Update rules.
3749 (classify_unsafe_function, classify_packaged_name)
3750 (classify_name, yylex): Update.
3751
3752 2019-04-19 Sergei Trofimovich <siarheit@google.com>
3753
3754 * configure.ac: add --enable-source-highlight switch.
3755 * configure: Regenerate.
3756 * top.c (print_gdb_version): plumb --enable-source-highlight
3757 status to "show configuration".
3758
3759 2019-04-19 Tom Tromey <tromey@adacore.com>
3760
3761 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3762 Check ADA_TYPE_P.
3763 (empty_record, ada_template_to_fixed_record_type_1)
3764 (template_to_static_fixed_type)
3765 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3766 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3767 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3768 macros.
3769
3770 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
3771
3772 PR symtab/24423:
3773 * source.c (print_source_lines_base): Advance "iter" when a
3774 control character is seen.
3775
3776 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3777
3778 * inferior.h (struct infcall_suspend_state_deleter):
3779 Catch exception in destructor to avoid crash.
3780
3781 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3782
3783 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3784 close to the add_com "shell".
3785
3786 2019-04-18 Tom Tromey <tromey@adacore.com>
3787
3788 * process-stratum-target.h (class process_stratum_target)
3789 <stratum>: Add "final".
3790
3791 2019-04-17 Tom Tromey <tromey@adacore.com>
3792
3793 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3794 against nullptr before use.
3795
3796 2019-04-17 Alan Hayward <alan.hayward@arm.com>
3797
3798 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3799
3800 2019-04-17 Jim Wilson <jimw@sifive.com>
3801 Andrew Burgess <andrew.burgess@embecosm.com>
3802
3803 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3804 code read might fail, assume 4-byte breakpoint in that case.
3805
3806 2019-04-15 Leszek Swirski <leszeks@google.com>
3807
3808 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3809 rather than a hand-rolled POD check when checking for forced MEMORY
3810 classification.
3811
3812 2019-04-15 Alan Hayward <alan.hayward@arm.com>
3813
3814 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3815 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3816 function.
3817 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3818 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3819 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3820 declaration.
3821
3822 2019-04-15 Alan Hayward <alan.hayward@arm.com>
3823
3824 * aarch64-linux-nat.c
3825 (aarch64_linux_nat_target::thread_architecture): Add override.
3826 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3827 each VQ.
3828
3829 2019-04-15 Alan Hayward <alan.hayward@arm.com>
3830
3831 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3832
3833 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
3834
3835 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3836 target types of size 96-bits, add some additional comments, and
3837 check that the builtin type we found was the correct size.
3838
3839 2019-04-12 Eli Zaretskii <eliz@gnu.org>
3840
3841 * utils.c (prompt_for_continue): Don't restore the styling at the
3842 end, as applied_style has the wrong value. This fixes styling in
3843 long lists of file names that are interrupted by the "Continue?"
3844 prompt.
3845
3846 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
3847
3848 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3849 * c-lang.c (c_language_defn): Likewise.
3850 (cplus_language_defn): Likewise.
3851 (asm_language_defn): Likewise.
3852 (minimal_language_defn): Likewise.
3853 * d-lang.c (d_language_defn): Likewise.
3854 * f-lang.c (f_language_defn): Likewise.
3855 * go-lang.c (go_language_defn): Likewise.
3856 * language.c (unknown_language_defn): Likewise.
3857 (auto_language_defn): Likewise.
3858 * language.h (struct language_defn): Remove la_magic field.
3859 (LANG_MAGIC): Delete.
3860 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3861 * objc-lang.c (objc_language_defn): Likewise.
3862 * opencl-lang.c (opencl_language_defn): Likewise.
3863 * p-lang.c (pascal_language_defn): Likewise.
3864 * rust-lang.c (rust_language_defn): Likewise.
3865
3866 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
3867
3868 * riscv-tdep.c (riscv_type_align): New function.
3869 (riscv_type_alignment): Delete.
3870 (riscv_arg_location): Use 'type_align'.
3871 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3872
3873 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
3874
3875 * gdbtypes.c (type_align): A struct with no non-static fields also
3876 has alignment of 1.
3877
3878 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
3879
3880 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3881 component to 0.
3882 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3883 member.
3884 (riscv_struct_info::analyse): New implementation using new
3885 analyse_inner member function.
3886 (riscv_struct_info::field_offset): New member function.
3887 (riscv_struct_info::m_offsets): New member variable.
3888 (riscv_struct_info::analyse_inner): New private member function,
3889 takes the old implementation of riscv_struct_info::analyse but
3890 extended to track field offsets.
3891 (riscv_call_arg_struct): Update the struct folding special cases
3892 to handle cases where empty C++ structs, which are non-zero
3893 length, are found.
3894 (riscv_arg_location): Initialise the length of each location, a
3895 non-zero length now indicates the location is in use.
3896 (riscv_push_dummy_call): Allow for the first location having a
3897 non-zero offset when setting up arguments.
3898 (riscv_return_value): Likewise, but for return values.
3899
3900 2019-04-11 Tom Tromey <tromey@adacore.com>
3901
3902 * utils.c (internal_vproblem): Make "msg" const.
3903
3904 2019-04-11 Alan Hayward <alan.hayward@arm.com>
3905
3906 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3907 * trad-frame.c (trad_frame_reset_saved_regs): New function.
3908 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3909 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3910
3911 2019-04-10 Kevin Buettner <kevinb@redhat.com>
3912
3913 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3914 function.
3915 (fill_gregset): Call amd64_linux_collect_native_gregset instead
3916 of amd64_collect_native_gregset.
3917 (amd64_linux_nat_target::store_registers): Likewise.
3918
3919 2019-04-10 Tom Tromey <tom@tromey.com>
3920
3921 * symtab.c (lookup_global_symbol_from_objfile)
3922 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3923 * objfiles.h (class separate_debug_iterator): New.
3924 (class separate_debug_range): New.
3925 (struct objfile) <separate_debug_objfiles>: New method.
3926 (objfile_separate_debug_iterate): Don't declare.
3927 * objfiles.c (separate_debug_iterator::operator++): Rename from
3928 objfile_separate_debug_iterate.
3929 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3930 iterator.
3931 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3932 iterator.
3933
3934 2019-04-10 Tom Tromey <tom@tromey.com>
3935
3936 * symfile.c (reread_symbols): Remove old comment.
3937 * objfiles.c (free_all_objfiles): Fix a typo.
3938
3939 2019-04-10 Tom Tromey <tom@tromey.com>
3940
3941 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3942 * minsyms.c (lookup_minimal_symbol): Use foreach.
3943 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3944 (lookup_minimal_symbol_solib_trampoline): Likewise.
3945 * symfile.c (reread_symbols): Use foreach.
3946
3947 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
3948 Tom Tromey <tromey@adacore.com>
3949
3950 PR rust/24414:
3951 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3952 (rust_lex_int_test): Change "value" to be LONGEST.
3953 (rust_lex_tests): Add test for long integer literal.
3954
3955 2019-04-09 Tom Tromey <tromey@adacore.com>
3956
3957 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3958 to bool.
3959 (extended_remote_target::attach): Update.
3960 (remote_target::remote_notice_new_inferior): Update.
3961 (remote_target::add_current_inferior_and_thread): Update.
3962 * inferior.c (exit_inferior_1): Use "false".
3963 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3964
3965 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
3966
3967 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3968 the "start" command.
3969
3970 2019-04-08 Kevin Buettner <kevinb@redhat.com>
3971
3972 * python/py-inferior.c (infpy_thread_from_thread_handle):
3973 Adjust comments to reflect renaming of thread_from_thread_handle
3974 to thread_from_handle. Adjust keywords. Fix type error message.
3975 (inferior_object_methods): Add thread_from_handle. Retain
3976 thread_from_thread_handle, but mark it as deprecated.
3977
3978 2019-04-08 Kevin Buettner <kevinb@redhat.com>
3979
3980 * gdbthread.h (find_thread_by_handle): Revise declaration.
3981 * thread.c (find_thread_by_handle): Likewise. Adjust
3982 implementation too.
3983 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3984 support for buffer objects as handles.
3985
3986 2019-04-08 Kevin Buettner <kevinb@redhat.com>
3987
3988 * python/py-infthread.c (thpy_thread_handle): New function.
3989 (thread_object_methods): Register thpy_thread_handle.
3990
3991 2019-04-08 Kevin Buettner <kevinb@redhat.com>
3992
3993 * gdbthread.h (thread_to_thread_handle): Declare.
3994 * thread.c (gdbtypes.h): Include.
3995 (thread_to_thread_handle): New function.
3996
3997 * target.h (struct target_ops): Add thread_info_to_thread_handle.
3998 (target_thread_info_to_thread_handle): Declare.
3999 * target.c (target_thread_info_to_thread_handle): New function.
4000 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4001 * target-delegates.c: Regenerate.
4002
4003 * linux-thread-db.c (class thread_db_target): Add method
4004 thread_info_to_thread_handle.
4005 (thread_db_target::thread_info_to_thread_handle): Define.
4006 * remote.c (class remote_target): Add new method
4007 thread_info_to_thread_handle.
4008 (remote_target::thread_info_to_thread_handle): Define.
4009
4010 2019-04-08 Pedro Alves <palves@redhat.com>
4011
4012 * common/common-exceptions.c (throw_exception): Don't create
4013 named object to throw; throw directly.
4014 (throw_it): Likewise. Don't initialize gdb_exception::message
4015 here, with new; pass FMT and AP to the ctor instead.
4016 * common/common-exceptions.h: Include <string>.
4017 (gdb_exception::gdb_exception(enum return_reason, enum errors,
4018 const char *, va_list)): New ctor. Use std::make_shared.
4019 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4020 errors)): Delete.
4021 (gdb_exception_error::gdb_exception_error(enum errors, const char
4022 *, va_list)): New.
4023 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4024 Add assertion.
4025 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4026 errors)): Delete.
4027 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4028 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4029 Add assertion.
4030
4031 2019-04-08 Tom Tromey <tom@tromey.com>
4032
4033 * valops.c (value_rtti_indirect_type): Replace throw_exception
4034 with throw.
4035 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4036 with throw.
4037 * thread.c (thr_try_catch_cmd): Replace throw_exception with
4038 throw.
4039 * target.c (target_translate_tls_address): Replace throw_exception
4040 with throw.
4041 * stack.c (frame_apply_command_count): Replace throw_exception
4042 with throw.
4043 * solib-spu.c (append_ocl_sos): Replace throw_exception with
4044 throw.
4045 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4046 with throw.
4047 * rs6000-tdep.c (rs6000_frame_cache)
4048 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4049 * remote.c: Replace throw_exception with throw.
4050 * record-full.c (record_full_message, record_full_wait_1)
4051 (record_full_restore): Replace throw_exception with throw.
4052 * record-btrace.c:
4053 (get_thread_current_frame_id, record_btrace_start_replaying)
4054 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4055 (cmd_record_btrace_start): Replace throw_exception with throw.
4056 * parse.c (parse_exp_in_context_1): Replace throw_exception with
4057 throw.
4058 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4059 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4060 * linespec.c:
4061 (find_linespec_symbols): Replace throw_exception with throw.
4062 * infrun.c (displaced_step_prepare, resume): Replace
4063 throw_exception with throw.
4064 * infcmd.c (post_create_inferior): Replace throw_exception with
4065 throw.
4066 * inf-loop.c (inferior_event_handler): Replace throw_exception
4067 with throw.
4068 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4069 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4070 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4071 (get_prev_frame_always, get_frame_pc_if_available)
4072 (get_frame_address_in_block_if_available, get_frame_language):
4073 Replace throw_exception with throw.
4074 * frame-unwind.c (frame_unwind_try_unwinder): Replace
4075 throw_exception with throw.
4076 * eval.c (fetch_subexp_value, evaluate_var_value)
4077 (evaluate_funcall, evaluate_subexp_standard): Replace
4078 throw_exception with throw.
4079 * dwarf2loc.c (call_site_find_chain)
4080 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4081 Replace throw_exception with throw.
4082 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4083 with throw.
4084 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4085 throw.
4086 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4087 * completer.c (complete_line_internal): Replace throw_exception
4088 with throw.
4089 * compile/compile-object-run.c (compile_object_run): Replace
4090 throw_exception with throw.
4091 * cli/cli-script.c (process_next_line): Replace throw_exception
4092 with throw.
4093 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4094 (btrace_enable, btrace_maint_update_pt_packets): Replace
4095 throw_exception with throw.
4096 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4097 throw_exception with throw.
4098 * break-catch-throw.c (re_set_exception_catchpoint): Replace
4099 throw_exception with throw.
4100 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4101 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4102 * aarch64-tdep.c (aarch64_make_prologue_cache)
4103 (aarch64_make_stub_cache): Replace throw_exception with throw.
4104
4105 2019-04-08 Tom Tromey <tom@tromey.com>
4106
4107 * common/common-exceptions.c (throw_exception): Rename from
4108 throw_exception_cxx. Remove old copy. Make argument const.
4109 (throw_it): Create and throw exception objects directly.
4110 * common/common-exceptions.h (throw_exception): Make argument
4111 const.
4112 (struct gdb_exception_error): Add constructor.
4113 (struct gdb_exception_quit): Add constructor.
4114
4115 2019-04-08 Tom Tromey <tom@tromey.com>
4116
4117 * common/common-exceptions.h (exception_rethrow): Don't declare.
4118 (TRY_SJLJ): Update comment.
4119 (TRY, CATCH, END_CATCH): Remove.
4120 * common/common-exceptions.c (exception_rethrow): Remove.
4121
4122 2019-04-08 Tom Tromey <tom@tromey.com>
4123
4124 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4125 Remove.
4126 (gdb_exception_error): Rename from
4127 gdb_exception_RETURN_MASK_ERROR.
4128 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4129 (gdb_quit_bad_alloc): Update.
4130 * aarch64-tdep.c: Update.
4131 * ada-lang.c: Update.
4132 * ada-typeprint.c: Update.
4133 * ada-valprint.c: Update.
4134 * amd64-tdep.c: Update.
4135 * arch-utils.c: Update.
4136 * break-catch-throw.c: Update.
4137 * breakpoint.c: Update.
4138 * btrace.c: Update.
4139 * c-varobj.c: Update.
4140 * cli/cli-cmds.c: Update.
4141 * cli/cli-interp.c: Update.
4142 * cli/cli-script.c: Update.
4143 * common/common-exceptions.c: Update.
4144 * common/new-op.c: Update.
4145 * common/selftest.c: Update.
4146 * compile/compile-c-symbols.c: Update.
4147 * compile/compile-cplus-symbols.c: Update.
4148 * compile/compile-object-load.c: Update.
4149 * compile/compile-object-run.c: Update.
4150 * completer.c: Update.
4151 * corelow.c: Update.
4152 * cp-abi.c: Update.
4153 * cp-support.c: Update.
4154 * cp-valprint.c: Update.
4155 * darwin-nat.c: Update.
4156 * disasm-selftests.c: Update.
4157 * dtrace-probe.c: Update.
4158 * dwarf-index-cache.c: Update.
4159 * dwarf-index-write.c: Update.
4160 * dwarf2-frame-tailcall.c: Update.
4161 * dwarf2-frame.c: Update.
4162 * dwarf2loc.c: Update.
4163 * dwarf2read.c: Update.
4164 * eval.c: Update.
4165 * event-loop.c: Update.
4166 * event-top.c: Update.
4167 * exec.c: Update.
4168 * f-valprint.c: Update.
4169 * fbsd-tdep.c: Update.
4170 * frame-unwind.c: Update.
4171 * frame.c: Update.
4172 * gdbtypes.c: Update.
4173 * gnu-v3-abi.c: Update.
4174 * guile/guile-internal.h: Update.
4175 * guile/scm-block.c: Update.
4176 * guile/scm-breakpoint.c: Update.
4177 * guile/scm-cmd.c: Update.
4178 * guile/scm-disasm.c: Update.
4179 * guile/scm-frame.c: Update.
4180 * guile/scm-lazy-string.c: Update.
4181 * guile/scm-math.c: Update.
4182 * guile/scm-param.c: Update.
4183 * guile/scm-ports.c: Update.
4184 * guile/scm-pretty-print.c: Update.
4185 * guile/scm-symbol.c: Update.
4186 * guile/scm-symtab.c: Update.
4187 * guile/scm-type.c: Update.
4188 * guile/scm-value.c: Update.
4189 * i386-linux-tdep.c: Update.
4190 * i386-tdep.c: Update.
4191 * inf-loop.c: Update.
4192 * infcall.c: Update.
4193 * infcmd.c: Update.
4194 * infrun.c: Update.
4195 * jit.c: Update.
4196 * language.c: Update.
4197 * linespec.c: Update.
4198 * linux-fork.c: Update.
4199 * linux-nat.c: Update.
4200 * linux-tdep.c: Update.
4201 * linux-thread-db.c: Update.
4202 * main.c: Update.
4203 * mi/mi-cmd-break.c: Update.
4204 * mi/mi-cmd-stack.c: Update.
4205 * mi/mi-interp.c: Update.
4206 * mi/mi-main.c: Update.
4207 * objc-lang.c: Update.
4208 * p-valprint.c: Update.
4209 * parse.c: Update.
4210 * ppc-linux-tdep.c: Update.
4211 * printcmd.c: Update.
4212 * python/py-arch.c: Update.
4213 * python/py-breakpoint.c: Update.
4214 * python/py-cmd.c: Update.
4215 * python/py-finishbreakpoint.c: Update.
4216 * python/py-frame.c: Update.
4217 * python/py-framefilter.c: Update.
4218 * python/py-gdb-readline.c: Update.
4219 * python/py-inferior.c: Update.
4220 * python/py-infthread.c: Update.
4221 * python/py-lazy-string.c: Update.
4222 * python/py-linetable.c: Update.
4223 * python/py-objfile.c: Update.
4224 * python/py-param.c: Update.
4225 * python/py-prettyprint.c: Update.
4226 * python/py-progspace.c: Update.
4227 * python/py-record-btrace.c: Update.
4228 * python/py-record.c: Update.
4229 * python/py-symbol.c: Update.
4230 * python/py-type.c: Update.
4231 * python/py-unwind.c: Update.
4232 * python/py-utils.c: Update.
4233 * python/py-value.c: Update.
4234 * python/python.c: Update.
4235 * record-btrace.c: Update.
4236 * record-full.c: Update.
4237 * remote-fileio.c: Update.
4238 * remote.c: Update.
4239 * riscv-tdep.c: Update.
4240 * rs6000-aix-tdep.c: Update.
4241 * rs6000-tdep.c: Update.
4242 * rust-exp.y: Update.
4243 * rust-lang.c: Update.
4244 * s390-tdep.c: Update.
4245 * selftest-arch.c: Update.
4246 * solib-dsbt.c: Update.
4247 * solib-frv.c: Update.
4248 * solib-spu.c: Update.
4249 * solib-svr4.c: Update.
4250 * solib.c: Update.
4251 * sparc64-linux-tdep.c: Update.
4252 * stack.c: Update.
4253 * symfile-mem.c: Update.
4254 * symmisc.c: Update.
4255 * target.c: Update.
4256 * thread.c: Update.
4257 * top.c: Update.
4258 * tracefile-tfile.c: Update.
4259 * tui/tui.c: Update.
4260 * typeprint.c: Update.
4261 * unittests/cli-utils-selftests.c: Update.
4262 * unittests/parse-connection-spec-selftests.c: Update.
4263 * valops.c: Update.
4264 * valprint.c: Update.
4265 * value.c: Update.
4266 * varobj.c: Update.
4267 * windows-nat.c: Update.
4268 * x86-linux-nat.c: Update.
4269 * xml-support.c: Update.
4270
4271 2019-04-08 Tom Tromey <tom@tromey.com>
4272
4273 * xml-support.c: Use C++ exception handling.
4274 * x86-linux-nat.c: Use C++ exception handling.
4275 * windows-nat.c: Use C++ exception handling.
4276 * varobj.c: Use C++ exception handling.
4277 * value.c: Use C++ exception handling.
4278 * valprint.c: Use C++ exception handling.
4279 * valops.c: Use C++ exception handling.
4280 * unittests/parse-connection-spec-selftests.c: Use C++ exception
4281 handling.
4282 * unittests/cli-utils-selftests.c: Use C++ exception handling.
4283 * typeprint.c: Use C++ exception handling.
4284 * tui/tui.c: Use C++ exception handling.
4285 * tracefile-tfile.c: Use C++ exception handling.
4286 * top.c: Use C++ exception handling.
4287 * thread.c: Use C++ exception handling.
4288 * target.c: Use C++ exception handling.
4289 * symmisc.c: Use C++ exception handling.
4290 * symfile-mem.c: Use C++ exception handling.
4291 * stack.c: Use C++ exception handling.
4292 * sparc64-linux-tdep.c: Use C++ exception handling.
4293 * solib.c: Use C++ exception handling.
4294 * solib-svr4.c: Use C++ exception handling.
4295 * solib-spu.c: Use C++ exception handling.
4296 * solib-frv.c: Use C++ exception handling.
4297 * solib-dsbt.c: Use C++ exception handling.
4298 * selftest-arch.c: Use C++ exception handling.
4299 * s390-tdep.c: Use C++ exception handling.
4300 * rust-lang.c: Use C++ exception handling.
4301 * rust-exp.y: Use C++ exception handling.
4302 * rs6000-tdep.c: Use C++ exception handling.
4303 * rs6000-aix-tdep.c: Use C++ exception handling.
4304 * riscv-tdep.c: Use C++ exception handling.
4305 * remote.c: Use C++ exception handling.
4306 * remote-fileio.c: Use C++ exception handling.
4307 * record-full.c: Use C++ exception handling.
4308 * record-btrace.c: Use C++ exception handling.
4309 * python/python.c: Use C++ exception handling.
4310 * python/py-value.c: Use C++ exception handling.
4311 * python/py-utils.c: Use C++ exception handling.
4312 * python/py-unwind.c: Use C++ exception handling.
4313 * python/py-type.c: Use C++ exception handling.
4314 * python/py-symbol.c: Use C++ exception handling.
4315 * python/py-record.c: Use C++ exception handling.
4316 * python/py-record-btrace.c: Use C++ exception handling.
4317 * python/py-progspace.c: Use C++ exception handling.
4318 * python/py-prettyprint.c: Use C++ exception handling.
4319 * python/py-param.c: Use C++ exception handling.
4320 * python/py-objfile.c: Use C++ exception handling.
4321 * python/py-linetable.c: Use C++ exception handling.
4322 * python/py-lazy-string.c: Use C++ exception handling.
4323 * python/py-infthread.c: Use C++ exception handling.
4324 * python/py-inferior.c: Use C++ exception handling.
4325 * python/py-gdb-readline.c: Use C++ exception handling.
4326 * python/py-framefilter.c: Use C++ exception handling.
4327 * python/py-frame.c: Use C++ exception handling.
4328 * python/py-finishbreakpoint.c: Use C++ exception handling.
4329 * python/py-cmd.c: Use C++ exception handling.
4330 * python/py-breakpoint.c: Use C++ exception handling.
4331 * python/py-arch.c: Use C++ exception handling.
4332 * printcmd.c: Use C++ exception handling.
4333 * ppc-linux-tdep.c: Use C++ exception handling.
4334 * parse.c: Use C++ exception handling.
4335 * p-valprint.c: Use C++ exception handling.
4336 * objc-lang.c: Use C++ exception handling.
4337 * mi/mi-main.c: Use C++ exception handling.
4338 * mi/mi-interp.c: Use C++ exception handling.
4339 * mi/mi-cmd-stack.c: Use C++ exception handling.
4340 * mi/mi-cmd-break.c: Use C++ exception handling.
4341 * main.c: Use C++ exception handling.
4342 * linux-thread-db.c: Use C++ exception handling.
4343 * linux-tdep.c: Use C++ exception handling.
4344 * linux-nat.c: Use C++ exception handling.
4345 * linux-fork.c: Use C++ exception handling.
4346 * linespec.c: Use C++ exception handling.
4347 * language.c: Use C++ exception handling.
4348 * jit.c: Use C++ exception handling.
4349 * infrun.c: Use C++ exception handling.
4350 * infcmd.c: Use C++ exception handling.
4351 * infcall.c: Use C++ exception handling.
4352 * inf-loop.c: Use C++ exception handling.
4353 * i386-tdep.c: Use C++ exception handling.
4354 * i386-linux-tdep.c: Use C++ exception handling.
4355 * guile/scm-value.c: Use C++ exception handling.
4356 * guile/scm-type.c: Use C++ exception handling.
4357 * guile/scm-symtab.c: Use C++ exception handling.
4358 * guile/scm-symbol.c: Use C++ exception handling.
4359 * guile/scm-pretty-print.c: Use C++ exception handling.
4360 * guile/scm-ports.c: Use C++ exception handling.
4361 * guile/scm-param.c: Use C++ exception handling.
4362 * guile/scm-math.c: Use C++ exception handling.
4363 * guile/scm-lazy-string.c: Use C++ exception handling.
4364 * guile/scm-frame.c: Use C++ exception handling.
4365 * guile/scm-disasm.c: Use C++ exception handling.
4366 * guile/scm-cmd.c: Use C++ exception handling.
4367 * guile/scm-breakpoint.c: Use C++ exception handling.
4368 * guile/scm-block.c: Use C++ exception handling.
4369 * guile/guile-internal.h: Use C++ exception handling.
4370 * gnu-v3-abi.c: Use C++ exception handling.
4371 * gdbtypes.c: Use C++ exception handling.
4372 * frame.c: Use C++ exception handling.
4373 * frame-unwind.c: Use C++ exception handling.
4374 * fbsd-tdep.c: Use C++ exception handling.
4375 * f-valprint.c: Use C++ exception handling.
4376 * exec.c: Use C++ exception handling.
4377 * event-top.c: Use C++ exception handling.
4378 * event-loop.c: Use C++ exception handling.
4379 * eval.c: Use C++ exception handling.
4380 * dwarf2read.c: Use C++ exception handling.
4381 * dwarf2loc.c: Use C++ exception handling.
4382 * dwarf2-frame.c: Use C++ exception handling.
4383 * dwarf2-frame-tailcall.c: Use C++ exception handling.
4384 * dwarf-index-write.c: Use C++ exception handling.
4385 * dwarf-index-cache.c: Use C++ exception handling.
4386 * dtrace-probe.c: Use C++ exception handling.
4387 * disasm-selftests.c: Use C++ exception handling.
4388 * darwin-nat.c: Use C++ exception handling.
4389 * cp-valprint.c: Use C++ exception handling.
4390 * cp-support.c: Use C++ exception handling.
4391 * cp-abi.c: Use C++ exception handling.
4392 * corelow.c: Use C++ exception handling.
4393 * completer.c: Use C++ exception handling.
4394 * compile/compile-object-run.c: Use C++ exception handling.
4395 * compile/compile-object-load.c: Use C++ exception handling.
4396 * compile/compile-cplus-symbols.c: Use C++ exception handling.
4397 * compile/compile-c-symbols.c: Use C++ exception handling.
4398 * common/selftest.c: Use C++ exception handling.
4399 * common/new-op.c: Use C++ exception handling.
4400 * cli/cli-script.c: Use C++ exception handling.
4401 * cli/cli-interp.c: Use C++ exception handling.
4402 * cli/cli-cmds.c: Use C++ exception handling.
4403 * c-varobj.c: Use C++ exception handling.
4404 * btrace.c: Use C++ exception handling.
4405 * breakpoint.c: Use C++ exception handling.
4406 * break-catch-throw.c: Use C++ exception handling.
4407 * arch-utils.c: Use C++ exception handling.
4408 * amd64-tdep.c: Use C++ exception handling.
4409 * ada-valprint.c: Use C++ exception handling.
4410 * ada-typeprint.c: Use C++ exception handling.
4411 * ada-lang.c: Use C++ exception handling.
4412 * aarch64-tdep.c: Use C++ exception handling.
4413
4414 2019-04-08 Tom Tromey <tom@tromey.com>
4415
4416 * xml-support.c (gdb_xml_parser::parse): Update.
4417 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4418 * value.c (show_convenience): Update.
4419 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4420 (test_parse_flags_qcs): Update.
4421 * thread.c (thr_try_catch_cmd): Update.
4422 * target.c (target_translate_tls_address): Update.
4423 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4424 (info_frame_command_core, frame_apply_command_count): Update.
4425 * rust-exp.y (rust_lex_exception_test): Update.
4426 * riscv-tdep.c (riscv_print_one_register_info): Update.
4427 * remote.c (remote_target::enable_btrace): Update.
4428 * record-btrace.c (record_btrace_enable_warn): Update.
4429 * python/py-utils.c (gdbpy_convert_exception): Update.
4430 * printcmd.c (do_one_display, print_variable_and_value): Update.
4431 * mi/mi-main.c (mi_print_exception): Update.
4432 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4433 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4434 * linux-nat.c (linux_nat_target::attach): Update.
4435 * linux-fork.c (class scoped_switch_fork_info): Update.
4436 * infrun.c (displaced_step_prepare): Update.
4437 * infcall.c (call_function_by_hand_dummy): Update.
4438 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4439 * gnu-v3-abi.c (print_one_vtable): Update.
4440 * frame.c (get_prev_frame_always): Update.
4441 * f-valprint.c (info_common_command_for_block): Update.
4442 * exec.c (try_open_exec_file): Update.
4443 * exceptions.c (print_exception, exception_print)
4444 (exception_fprintf, exception_print_same): Update.
4445 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4446 * dwarf-index-cache.c (index_cache::store)
4447 (index_cache::lookup_gdb_index): Update.
4448 * darwin-nat.c (maybe_cache_shell): Update.
4449 * cp-valprint.c (cp_print_value_fields): Update.
4450 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4451 (gcc_cplus_symbol_address): Update.
4452 * compile/compile-c-symbols.c (gcc_convert_symbol)
4453 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4454 * common/selftest.c: Update.
4455 * common/common-exceptions.h (struct gdb_exception) <message>: Now
4456 a std::string.
4457 (exception_try_scope_entry, exception_try_scope_exit): Don't
4458 declare.
4459 (struct exception_try_scope): Remove.
4460 (TRY): Don't use exception_try_scope.
4461 (struct gdb_exception): Add constructor, operator=.
4462 <what>: New method.
4463 (struct gdb_exception_RETURN_MASK_ALL)
4464 (struct gdb_exception_RETURN_MASK_ERROR)
4465 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4466 (struct gdb_quit_bad_alloc): Update.
4467 * common/common-exceptions.c (exception_none): Change
4468 initializer.
4469 (struct catcher) <state, exception>: Initialize inline.
4470 <prev>: Remove member.
4471 (current_catcher): Remove.
4472 (catchers): New global.
4473 (exceptions_state_mc_init): Simplify.
4474 (catcher_pop): Remove.
4475 (exceptions_state_mc, exceptions_state_mc_catch): Update.
4476 (try_scope_depth, exception_try_scope_entry)
4477 (exception_try_scope_exit): Remove.
4478 (throw_exception_sjlj): Update.
4479 (exception_messages, exception_messages_size): Remove.
4480 (throw_it): Simplify.
4481 (gdb_exception_sliced_copy): Remove.
4482 (throw_exception_cxx): Update.
4483 * cli/cli-script.c (script_from_file): Update.
4484 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4485 Update.
4486 * ada-valprint.c (ada_val_print): Update.
4487 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4488 (create_excep_cond_exprs): Update.
4489
4490 2019-04-08 Tom Tromey <tom@tromey.com>
4491
4492 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4493 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4494 (TRY, CATCH, END_CATCH): Remove some definitions.
4495 * common/common-exceptions.c: Don't use GDB_XCPT.
4496 (catcher_list_size): Remove.
4497 (throw_exception, throw_it): Simplify.
4498
4499 2019-04-05 Tom Tromey <tom@tromey.com>
4500
4501 Revert the header-sorting patch.
4502 * ft32-tdep.c: Revert.
4503 * frv-tdep.c: Revert.
4504 * frv-linux-tdep.c: Revert.
4505 * frame.c: Revert.
4506 * frame-unwind.c: Revert.
4507 * frame-base.c: Revert.
4508 * fork-child.c: Revert.
4509 * findvar.c: Revert.
4510 * findcmd.c: Revert.
4511 * filesystem.c: Revert.
4512 * filename-seen-cache.h: Revert.
4513 * filename-seen-cache.c: Revert.
4514 * fbsd-tdep.c: Revert.
4515 * fbsd-nat.h: Revert.
4516 * fbsd-nat.c: Revert.
4517 * f-valprint.c: Revert.
4518 * f-typeprint.c: Revert.
4519 * f-lang.c: Revert.
4520 * extension.h: Revert.
4521 * extension.c: Revert.
4522 * extension-priv.h: Revert.
4523 * expprint.c: Revert.
4524 * exec.h: Revert.
4525 * exec.c: Revert.
4526 * exceptions.c: Revert.
4527 * event-top.c: Revert.
4528 * event-loop.c: Revert.
4529 * eval.c: Revert.
4530 * elfread.c: Revert.
4531 * dwarf2read.h: Revert.
4532 * dwarf2read.c: Revert.
4533 * dwarf2loc.c: Revert.
4534 * dwarf2expr.h: Revert.
4535 * dwarf2expr.c: Revert.
4536 * dwarf2-frame.c: Revert.
4537 * dwarf2-frame-tailcall.c: Revert.
4538 * dwarf-index-write.h: Revert.
4539 * dwarf-index-write.c: Revert.
4540 * dwarf-index-common.c: Revert.
4541 * dwarf-index-cache.h: Revert.
4542 * dwarf-index-cache.c: Revert.
4543 * dummy-frame.c: Revert.
4544 * dtrace-probe.c: Revert.
4545 * disasm.h: Revert.
4546 * disasm.c: Revert.
4547 * disasm-selftests.c: Revert.
4548 * dictionary.c: Revert.
4549 * dicos-tdep.c: Revert.
4550 * demangle.c: Revert.
4551 * dcache.h: Revert.
4552 * dcache.c: Revert.
4553 * darwin-nat.h: Revert.
4554 * darwin-nat.c: Revert.
4555 * darwin-nat-info.c: Revert.
4556 * d-valprint.c: Revert.
4557 * d-namespace.c: Revert.
4558 * d-lang.c: Revert.
4559 * ctf.c: Revert.
4560 * csky-tdep.c: Revert.
4561 * csky-linux-tdep.c: Revert.
4562 * cris-tdep.c: Revert.
4563 * cris-linux-tdep.c: Revert.
4564 * cp-valprint.c: Revert.
4565 * cp-support.c: Revert.
4566 * cp-namespace.c: Revert.
4567 * cp-abi.c: Revert.
4568 * corelow.c: Revert.
4569 * corefile.c: Revert.
4570 * continuations.c: Revert.
4571 * completer.h: Revert.
4572 * completer.c: Revert.
4573 * complaints.c: Revert.
4574 * coffread.c: Revert.
4575 * coff-pe-read.c: Revert.
4576 * cli-out.h: Revert.
4577 * cli-out.c: Revert.
4578 * charset.c: Revert.
4579 * c-varobj.c: Revert.
4580 * c-valprint.c: Revert.
4581 * c-typeprint.c: Revert.
4582 * c-lang.c: Revert.
4583 * buildsym.c: Revert.
4584 * buildsym-legacy.c: Revert.
4585 * build-id.h: Revert.
4586 * build-id.c: Revert.
4587 * btrace.c: Revert.
4588 * bsd-uthread.c: Revert.
4589 * breakpoint.h: Revert.
4590 * breakpoint.c: Revert.
4591 * break-catch-throw.c: Revert.
4592 * break-catch-syscall.c: Revert.
4593 * break-catch-sig.c: Revert.
4594 * blockframe.c: Revert.
4595 * block.c: Revert.
4596 * bfin-tdep.c: Revert.
4597 * bfin-linux-tdep.c: Revert.
4598 * bfd-target.c: Revert.
4599 * bcache.c: Revert.
4600 * ax-general.c: Revert.
4601 * ax-gdb.h: Revert.
4602 * ax-gdb.c: Revert.
4603 * avr-tdep.c: Revert.
4604 * auxv.c: Revert.
4605 * auto-load.c: Revert.
4606 * arm-wince-tdep.c: Revert.
4607 * arm-tdep.c: Revert.
4608 * arm-symbian-tdep.c: Revert.
4609 * arm-pikeos-tdep.c: Revert.
4610 * arm-obsd-tdep.c: Revert.
4611 * arm-nbsd-tdep.c: Revert.
4612 * arm-nbsd-nat.c: Revert.
4613 * arm-linux-tdep.c: Revert.
4614 * arm-linux-nat.c: Revert.
4615 * arm-fbsd-tdep.c: Revert.
4616 * arm-fbsd-nat.c: Revert.
4617 * arm-bsd-tdep.c: Revert.
4618 * arch-utils.c: Revert.
4619 * arc-tdep.c: Revert.
4620 * arc-newlib-tdep.c: Revert.
4621 * annotate.h: Revert.
4622 * annotate.c: Revert.
4623 * amd64-windows-tdep.c: Revert.
4624 * amd64-windows-nat.c: Revert.
4625 * amd64-tdep.c: Revert.
4626 * amd64-sol2-tdep.c: Revert.
4627 * amd64-obsd-tdep.c: Revert.
4628 * amd64-obsd-nat.c: Revert.
4629 * amd64-nbsd-tdep.c: Revert.
4630 * amd64-nbsd-nat.c: Revert.
4631 * amd64-nat.c: Revert.
4632 * amd64-linux-tdep.c: Revert.
4633 * amd64-linux-nat.c: Revert.
4634 * amd64-fbsd-tdep.c: Revert.
4635 * amd64-fbsd-nat.c: Revert.
4636 * amd64-dicos-tdep.c: Revert.
4637 * amd64-darwin-tdep.c: Revert.
4638 * amd64-bsd-nat.c: Revert.
4639 * alpha-tdep.c: Revert.
4640 * alpha-obsd-tdep.c: Revert.
4641 * alpha-nbsd-tdep.c: Revert.
4642 * alpha-mdebug-tdep.c: Revert.
4643 * alpha-linux-tdep.c: Revert.
4644 * alpha-linux-nat.c: Revert.
4645 * alpha-bsd-tdep.c: Revert.
4646 * alpha-bsd-nat.c: Revert.
4647 * aix-thread.c: Revert.
4648 * agent.c: Revert.
4649 * addrmap.c: Revert.
4650 * ada-varobj.c: Revert.
4651 * ada-valprint.c: Revert.
4652 * ada-typeprint.c: Revert.
4653 * ada-tasks.c: Revert.
4654 * ada-lang.c: Revert.
4655 * aarch64-tdep.c: Revert.
4656 * aarch64-ravenscar-thread.c: Revert.
4657 * aarch64-newlib-tdep.c: Revert.
4658 * aarch64-linux-tdep.c: Revert.
4659 * aarch64-linux-nat.c: Revert.
4660 * aarch64-fbsd-tdep.c: Revert.
4661 * aarch64-fbsd-nat.c: Revert.
4662 * aarch32-linux-nat.c: Revert.
4663
4664 2019-04-05 Tom Tromey <tom@tromey.com>
4665
4666 * ft32-tdep.c: Sort headers.
4667 * frv-tdep.c: Sort headers.
4668 * frv-linux-tdep.c: Sort headers.
4669 * frame.c: Sort headers.
4670 * frame-unwind.c: Sort headers.
4671 * frame-base.c: Sort headers.
4672 * fork-child.c: Sort headers.
4673 * findvar.c: Sort headers.
4674 * findcmd.c: Sort headers.
4675 * filesystem.c: Sort headers.
4676 * filename-seen-cache.h: Sort headers.
4677 * filename-seen-cache.c: Sort headers.
4678 * fbsd-tdep.c: Sort headers.
4679 * fbsd-nat.h: Sort headers.
4680 * fbsd-nat.c: Sort headers.
4681 * f-valprint.c: Sort headers.
4682 * f-typeprint.c: Sort headers.
4683 * f-lang.c: Sort headers.
4684 * extension.h: Sort headers.
4685 * extension.c: Sort headers.
4686 * extension-priv.h: Sort headers.
4687 * expprint.c: Sort headers.
4688 * exec.h: Sort headers.
4689 * exec.c: Sort headers.
4690 * exceptions.c: Sort headers.
4691 * event-top.c: Sort headers.
4692 * event-loop.c: Sort headers.
4693 * eval.c: Sort headers.
4694 * elfread.c: Sort headers.
4695 * dwarf2read.h: Sort headers.
4696 * dwarf2read.c: Sort headers.
4697 * dwarf2loc.c: Sort headers.
4698 * dwarf2expr.h: Sort headers.
4699 * dwarf2expr.c: Sort headers.
4700 * dwarf2-frame.c: Sort headers.
4701 * dwarf2-frame-tailcall.c: Sort headers.
4702 * dwarf-index-write.h: Sort headers.
4703 * dwarf-index-write.c: Sort headers.
4704 * dwarf-index-common.c: Sort headers.
4705 * dwarf-index-cache.h: Sort headers.
4706 * dwarf-index-cache.c: Sort headers.
4707 * dummy-frame.c: Sort headers.
4708 * dtrace-probe.c: Sort headers.
4709 * disasm.h: Sort headers.
4710 * disasm.c: Sort headers.
4711 * disasm-selftests.c: Sort headers.
4712 * dictionary.c: Sort headers.
4713 * dicos-tdep.c: Sort headers.
4714 * demangle.c: Sort headers.
4715 * dcache.h: Sort headers.
4716 * dcache.c: Sort headers.
4717 * darwin-nat.h: Sort headers.
4718 * darwin-nat.c: Sort headers.
4719 * darwin-nat-info.c: Sort headers.
4720 * d-valprint.c: Sort headers.
4721 * d-namespace.c: Sort headers.
4722 * d-lang.c: Sort headers.
4723 * ctf.c: Sort headers.
4724 * csky-tdep.c: Sort headers.
4725 * csky-linux-tdep.c: Sort headers.
4726 * cris-tdep.c: Sort headers.
4727 * cris-linux-tdep.c: Sort headers.
4728 * cp-valprint.c: Sort headers.
4729 * cp-support.c: Sort headers.
4730 * cp-namespace.c: Sort headers.
4731 * cp-abi.c: Sort headers.
4732 * corelow.c: Sort headers.
4733 * corefile.c: Sort headers.
4734 * continuations.c: Sort headers.
4735 * completer.h: Sort headers.
4736 * completer.c: Sort headers.
4737 * complaints.c: Sort headers.
4738 * coffread.c: Sort headers.
4739 * coff-pe-read.c: Sort headers.
4740 * cli-out.h: Sort headers.
4741 * cli-out.c: Sort headers.
4742 * charset.c: Sort headers.
4743 * c-varobj.c: Sort headers.
4744 * c-valprint.c: Sort headers.
4745 * c-typeprint.c: Sort headers.
4746 * c-lang.c: Sort headers.
4747 * buildsym.c: Sort headers.
4748 * buildsym-legacy.c: Sort headers.
4749 * build-id.h: Sort headers.
4750 * build-id.c: Sort headers.
4751 * btrace.c: Sort headers.
4752 * bsd-uthread.c: Sort headers.
4753 * breakpoint.h: Sort headers.
4754 * breakpoint.c: Sort headers.
4755 * break-catch-throw.c: Sort headers.
4756 * break-catch-syscall.c: Sort headers.
4757 * break-catch-sig.c: Sort headers.
4758 * blockframe.c: Sort headers.
4759 * block.c: Sort headers.
4760 * bfin-tdep.c: Sort headers.
4761 * bfin-linux-tdep.c: Sort headers.
4762 * bfd-target.c: Sort headers.
4763 * bcache.c: Sort headers.
4764 * ax-general.c: Sort headers.
4765 * ax-gdb.h: Sort headers.
4766 * ax-gdb.c: Sort headers.
4767 * avr-tdep.c: Sort headers.
4768 * auxv.c: Sort headers.
4769 * auto-load.c: Sort headers.
4770 * arm-wince-tdep.c: Sort headers.
4771 * arm-tdep.c: Sort headers.
4772 * arm-symbian-tdep.c: Sort headers.
4773 * arm-pikeos-tdep.c: Sort headers.
4774 * arm-obsd-tdep.c: Sort headers.
4775 * arm-nbsd-tdep.c: Sort headers.
4776 * arm-nbsd-nat.c: Sort headers.
4777 * arm-linux-tdep.c: Sort headers.
4778 * arm-linux-nat.c: Sort headers.
4779 * arm-fbsd-tdep.c: Sort headers.
4780 * arm-fbsd-nat.c: Sort headers.
4781 * arm-bsd-tdep.c: Sort headers.
4782 * arch-utils.c: Sort headers.
4783 * arc-tdep.c: Sort headers.
4784 * arc-newlib-tdep.c: Sort headers.
4785 * annotate.h: Sort headers.
4786 * annotate.c: Sort headers.
4787 * amd64-windows-tdep.c: Sort headers.
4788 * amd64-windows-nat.c: Sort headers.
4789 * amd64-tdep.c: Sort headers.
4790 * amd64-sol2-tdep.c: Sort headers.
4791 * amd64-obsd-tdep.c: Sort headers.
4792 * amd64-obsd-nat.c: Sort headers.
4793 * amd64-nbsd-tdep.c: Sort headers.
4794 * amd64-nbsd-nat.c: Sort headers.
4795 * amd64-nat.c: Sort headers.
4796 * amd64-linux-tdep.c: Sort headers.
4797 * amd64-linux-nat.c: Sort headers.
4798 * amd64-fbsd-tdep.c: Sort headers.
4799 * amd64-fbsd-nat.c: Sort headers.
4800 * amd64-dicos-tdep.c: Sort headers.
4801 * amd64-darwin-tdep.c: Sort headers.
4802 * amd64-bsd-nat.c: Sort headers.
4803 * alpha-tdep.c: Sort headers.
4804 * alpha-obsd-tdep.c: Sort headers.
4805 * alpha-nbsd-tdep.c: Sort headers.
4806 * alpha-mdebug-tdep.c: Sort headers.
4807 * alpha-linux-tdep.c: Sort headers.
4808 * alpha-linux-nat.c: Sort headers.
4809 * alpha-bsd-tdep.c: Sort headers.
4810 * alpha-bsd-nat.c: Sort headers.
4811 * aix-thread.c: Sort headers.
4812 * agent.c: Sort headers.
4813 * addrmap.c: Sort headers.
4814 * ada-varobj.c: Sort headers.
4815 * ada-valprint.c: Sort headers.
4816 * ada-typeprint.c: Sort headers.
4817 * ada-tasks.c: Sort headers.
4818 * ada-lang.c: Sort headers.
4819 * aarch64-tdep.c: Sort headers.
4820 * aarch64-ravenscar-thread.c: Sort headers.
4821 * aarch64-newlib-tdep.c: Sort headers.
4822 * aarch64-linux-tdep.c: Sort headers.
4823 * aarch64-linux-nat.c: Sort headers.
4824 * aarch64-fbsd-tdep.c: Sort headers.
4825 * aarch64-fbsd-nat.c: Sort headers.
4826 * aarch32-linux-nat.c: Sort headers.
4827
4828 2019-04-04 Tom Tromey <tom@tromey.com>
4829
4830 * varobj.c (varobj_create): Update.
4831 * rust-exp.y (struct rust_parser) <update_innermost_block,
4832 lookup_symbol>: New methods.
4833 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4834 Rename.
4835 (rust_parser::rust_lookup_type)
4836 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4837 * printcmd.c (display_command, do_one_display): Update.
4838 * parser-defs.h (struct parser_state) <parser_state>: Add
4839 "tracker" parameter.
4840 (block_tracker): New member.
4841 (class innermost_block_tracker) <innermost_block_tracker>: Add
4842 "types" parameter.
4843 <reset>: Remove method.
4844 (innermost_block): Don't declare.
4845 (null_post_parser): Update.
4846 * parse.c (innermost_block): Remove global.
4847 (write_dollar_variable): Update.
4848 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4849 Remove "tracker_types" parameter.
4850 (parse_expression): Add "tracker" parameter.
4851 (parse_expression_for_completion): Update.
4852 (null_post_parser): Add "tracker" parameter.
4853 * p-exp.y: Update rules.
4854 * m2-exp.y: Update rules.
4855 * language.h (struct language_defn) <la_post_parser>: Add
4856 "tracker" parameter.
4857 * go-exp.y: Update rules.
4858 * f-exp.y: Update rules.
4859 * expression.h (parse_expression, parse_exp_1): Add "tracker"
4860 parameter.
4861 * d-exp.y: Update rules.
4862 * c-exp.y: Update rules.
4863 * breakpoint.c (set_breakpoint_condition): Create an
4864 innermost_block_tracker.
4865 (watch_command_1): Likewise.
4866 * ada-lang.c (resolve): Add "tracker" parameter.
4867 (resolve_subexp): Likewise.
4868 * ada-exp.y (write_var_from_sym): Update.
4869
4870 2019-04-04 Tom Tromey <tom@tromey.com>
4871
4872 * type-stack.h: New file.
4873 * type-stack.c: New file.
4874 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4875 type-stack.h.
4876 (insert_into_type_stack, insert_type, push_type, push_type_int)
4877 (insert_type_address_space, pop_type, pop_type_int)
4878 (pop_typelist, pop_type_stack, append_type_stack)
4879 (push_type_stack, get_type_stack, push_typelist)
4880 (follow_type_instance_flags, follow_types): Don't declare.
4881 * parse.c (type_stack): Remove global.
4882 (parse_exp_in_context): Update.
4883 (insert_into_type_stack, insert_type, push_type, push_type_int)
4884 (insert_type_address_space, pop_type, pop_type_int)
4885 (pop_typelist, pop_type_stack, append_type_stack)
4886 (push_type_stack, get_type_stack, push_typelist)
4887 (follow_type_instance_flags, follow_types): Remove (moved to
4888 type-stack.c).
4889 * f-exp.y (type_stack): New global.
4890 Update rules.
4891 (push_kind_type, f_parse): Update.
4892 * d-exp.y (type_stack): New global.
4893 Update rules.
4894 (d_parse): Update.
4895 * c-exp.y (struct c_parse_state) <type_stack>: New member.
4896 Update rules.
4897 * Makefile.in (COMMON_SFILES): Add type-stack.c.
4898 (HFILES_NO_SRCDIR): Add type-stack.h.
4899
4900 2019-04-04 Tom Tromey <tom@tromey.com>
4901
4902 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4903 (rust_parser::convert_ast_to_expression, rust_parse)
4904 (rust_lex_test_completion, rust_lex_tests): Update.
4905 * parser-defs.h (struct expr_completion_state): New.
4906 (struct parser_state) <parser_state>: Add completion parameter.
4907 <mark_struct_expression, mark_completion_tag>: New methods.
4908 <parse_completion, m_completion_state>: New members.
4909 (prefixify_expression, null_post_parser): Update.
4910 (mark_struct_expression, mark_completion_tag): Don't declare.
4911 * parse.c (parse_completion, expout_last_struct)
4912 (expout_tag_completion_type, expout_completion_name): Remove
4913 globals.
4914 (parser_state::mark_struct_expression)
4915 (parser_state::mark_completion_tag): Now methods.
4916 (prefixify_expression): Add last_struct parameter.
4917 (prefixify_subexp): Likewise.
4918 (parse_exp_1): Update.
4919 (parse_exp_in_context): Add cstate parameter. Update.
4920 (parse_expression_for_completion): Create an
4921 expr_completion_state.
4922 (null_post_parser): Add "completion" parameter.
4923 * p-exp.y: Update rules.
4924 (yylex): Update.
4925 * language.h (struct language_defn) <la_post_parser>: Add
4926 "completing" parameter.
4927 * go-exp.y: Update rules.
4928 (lex_one_token): Update.
4929 * expression.h (parse_completion): Don't declare.
4930 * d-exp.y: Update rules.
4931 (lex_one_token): Update rules.
4932 * c-exp.y: Update rules.
4933 (lex_one_token): Update.
4934 * ada-lang.c (resolve): Add "parse_completion" parameter.
4935 (resolve_subexp): Likewise.
4936 (ada_resolve_function): Likewise.
4937
4938 2019-04-04 Tom Tromey <tom@tromey.com>
4939
4940 * parser-defs.h (struct parser_state) <start_arglist,
4941 end_arglist>: New methods.
4942 <arglist_len, m_funcall_chain>: New members.
4943 (arglist_len, start_arglist, end_arglist): Don't declare.
4944 * parse.c (arglist_len, funcall_chain): Remove global.
4945 (start_arglist, end_arglist): Remove functions.
4946 (parse_exp_in_context): Update.
4947 * p-exp.y: Update rules.
4948 * m2-exp.y: Update rules.
4949 * go-exp.y: Update rules.
4950 * f-exp.y: Update rules.
4951 * d-exp.y: Update rules.
4952 * c-exp.y: Update rules.
4953
4954 2019-04-04 Tom Tromey <tom@tromey.com>
4955
4956 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4957 lex_operator, push_back>: New methods.
4958 Update all rules.
4959 (rust_parser::lex_hex, lex_escape): Rename and update.
4960 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4961 (rust_parser::lex_operator): Rename and update.
4962 (rust_parser::lex_number, rustyylex, rustyyerror)
4963 (rust_lex_test_init, rust_lex_test_sequence)
4964 (rust_lex_test_push_back, rust_lex_tests): Update.
4965 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4966 parameter.
4967 <lexptr, prev_lexptr>: New members.
4968 (lexptr, prev_lexptr): Don't declare.
4969 * parse.c (lexptr, prev_lexptr): Remove globals.
4970 (parse_exp_in_context): Update.
4971 * p-exp.y (yylex, yyerror): Update.
4972 * m2-exp.y (parse_number, yylex, yyerror): Update.
4973 * go-exp.y (lex_one_token, yyerror): Update.
4974 * f-exp.y (match_string_literal, yylex, yyerror): Update.
4975 * d-exp.y (lex_one_token, yyerror): Update.
4976 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4977 (lex_one_token, yyerror): Update.
4978 * ada-lex.l (YY_INPUT): Update.
4979 (rewind_to_char): Update.
4980 * ada-exp.y (yyerror): Update.
4981
4982 2019-04-04 Tom Tromey <tom@tromey.com>
4983
4984 * rust-exp.y (rustyylex, rust_lex_tests): Update.
4985 * parser-defs.h (struct parser_state) <parser_state>: Add new
4986 parameter.
4987 <comma_terminates>: New member.
4988 (comma_terminates): Don't declare global.
4989 * parse.c (comma_terminates): Remove global.
4990 (parse_exp_in_context): Update.
4991 * p-exp.y (yylex): Update.
4992 * m2-exp.y (yylex): Update.
4993 * go-exp.y (lex_one_token): Update.
4994 * f-exp.y (yylex): Update.
4995 * d-exp.y (lex_one_token): Update.
4996 * c-exp.y (lex_one_token): Update.
4997 * ada-lex.l: Update.
4998
4999 2019-04-04 Tom Tromey <tom@tromey.com>
5000
5001 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5002 (rustyylex, rust_lex_test_init, rust_lex_test_one)
5003 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5004 * parser-defs.h (paren_depth): Don't declare.
5005 * parse.c (paren_depth): Remove global.
5006 (parse_exp_in_context): Update.
5007 * p-exp.y (paren_depth): New global.
5008 (pascal_parse): Initialize it.
5009 * m2-exp.y (paren_depth): New global.
5010 (m2_parse): Initialize it.
5011 * go-exp.y (paren_depth): New global.
5012 (go_parse): Initialize it.
5013 * f-exp.y (paren_depth): New global.
5014 (f_parse): Initialize it.
5015 * d-exp.y (paren_depth): New global.
5016 (d_parse): Initialize it.
5017 * c-exp.y (paren_depth): New global.
5018 (c_parse): Initialize it.
5019 * ada-lex.l (paren_depth): New global.
5020 (lexer_init): Initialize it.
5021
5022 2019-04-04 Tom Tromey <tom@tromey.com>
5023
5024 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5025 (rust_parser::convert_ast_to_type)
5026 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5027 * parser-defs.h (struct parser_state) <parser_state>: Add
5028 parameters. Initialize new members.
5029 <expression_context_block, expression_context_pc>: New members.
5030 * parse.c (expression_context_block, expression_context_pc):
5031 Remove globals.
5032 (parse_exp_in_context): Update.
5033 * p-exp.y: Update all rules.
5034 (yylex): Update.
5035 * m2-exp.y: Update all rules.
5036 (yylex): Update.
5037 * go-exp.y (yylex): Update.
5038 * f-exp.y (yylex): Update.
5039 * d-exp.y: Update all rules.
5040 (yylex): Update.
5041 * c-exp.y: Update all rules.
5042 (lex_one_token, classify_name, yylex, c_parse): Update.
5043 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5044
5045 2019-04-04 Tom Tromey <tom@tromey.com>
5046
5047 * gdbarch.h, gdbarch.c: Rebuild.
5048 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5049 * stap-probe.h:
5050 (struct stap_parse_info): Replace "parser_state" with
5051 "expr_builder".
5052 * parser-defs.h (struct expr_builder): Rename from "parser_state".
5053 (parser_state): New class.
5054 * parse.c (expr_builder): Rename.
5055 (expr_builder::release): Rename.
5056 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5057 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5058 (write_exp_elt_longcst, write_exp_elt_floatcst)
5059 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5060 (write_exp_string_vector, write_exp_bitstring)
5061 (write_exp_msymbol, mark_struct_expression)
5062 (write_dollar_variable)
5063 (insert_type_address_space, increase_expout_size): Replace
5064 "parser_state" with "expr_builder".
5065 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5066 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5067 "parser_state" with "expr_builder".
5068
5069 2019-04-04 Tom Tromey <tom@tromey.com>
5070
5071 * rust-exp.y: Replace "parse_language" with method call.
5072 * p-exp.y:
5073 (yylex): Replace "parse_language" with method call.
5074 * m2-exp.y:
5075 (yylex): Replace "parse_language" with method call.
5076 * go-exp.y (classify_name): Replace "parse_language" with method
5077 call.
5078 * f-exp.y (yylex): Replace "parse_language" with method call.
5079 * d-exp.y (lex_one_token): Replace "parse_language" with method
5080 call.
5081 * c-exp.y:
5082 (lex_one_token, classify_name, yylex): Replace "parse_language"
5083 with method call.
5084 * ada-exp.y (find_primitive_type, type_char)
5085 (type_system_address): Replace "parse_language" with method call.
5086
5087 2019-04-04 Tom Tromey <tom@tromey.com>
5088
5089 * rust-exp.y: Replace "parse_gdbarch" with method call.
5090 * parse.c (write_dollar_variable, insert_type_address_space):
5091 Replace "parse_gdbarch" with method call.
5092 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5093 call.
5094 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5095 call.
5096 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5097 "parse_gdbarch" with method call.
5098 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5099 with method call.
5100 * f-exp.y (parse_type, parse_f_type, yylex): Replace
5101 "parse_gdbarch" with method call.
5102 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5103 "parse_gdbarch" with method call.
5104 * c-exp.y (parse_type, parse_number, classify_name): Replace
5105 "parse_gdbarch" with method call.
5106 * ada-lex.l: Replace "parse_gdbarch" with method call.
5107 * ada-exp.y (parse_type, find_primitive_type, type_char)
5108 (type_system_address): Replace "parse_gdbarch" with method call.
5109
5110 2019-04-04 Tom Tromey <tom@tromey.com>
5111
5112 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5113 * stap-probe.c (stap_parse_argument): Update.
5114 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5115 initial_size parameter.
5116 * rust-exp.y (rust_lex_tests): Update.
5117 * parse.c (parser_state): Update.
5118 (parse_exp_in_context): Update.
5119 * parser-defs.h (struct parser_state) <parser_state>: Remove
5120 "initial_size" parameter.
5121
5122 2019-04-04 Tom Tromey <tom@tromey.com>
5123
5124 * parser-defs.h (increase_expout_size): Don't declare.
5125 * parse.c (increase_expout_size): Now static.
5126
5127 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
5128
5129 * gnu-nat.c (gnu_nat_target::wait): Fix
5130 target_waitstatus_to_string call.
5131
5132 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
5133
5134 * eval.c (evaluate_subexp_standard): Handle internal functions
5135 during Fortran function call handling.
5136
5137 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
5138
5139 * NEWS: Mention new internal functions.
5140 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5141 (read_base_type): Use dwarf2_init_complex_target_type.
5142 * value.c (creal_internal_fn): New function.
5143 (cimag_internal_fn): New function.
5144 (_initialize_values): Register new internal functions.
5145
5146 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5147
5148 * infrun.c (stop_all_threads): If debug_infrun, always
5149 trace the wait status after wait_one, using
5150 target_waitstatus_to_string and target_pid_to_str.
5151 (handle_inferior_event): Replace various trace of
5152 wait status kind by a single trace.
5153 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5154 wait status kind image by target_waitstatus_to_string.
5155 * target/waitstatus.c (target_waitstatus_to_string): Fix
5156 obsolete comment.
5157
5158 2019-04-01 Tom Tromey <tromey@adacore.com>
5159
5160 PR symtab/23331:
5161 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5162
5163 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
5164 Pedro Alves <palves@redhat.com>
5165
5166 * top.c (quit_force): Call 'finalize_values'.
5167 * value.c (finalize_values): New function.
5168 * value.h (finalize_values): Declare.
5169
5170 2019-03-30 Eli Zaretskii <eliz@gnu.org>
5171
5172 * NEWS: Announce $_gdb_major and $_gdb_minor.
5173
5174 * top.c (init_gdb_version_vars): New function.
5175 (gdb_init): Call init_gdb_version_vars.
5176
5177 2019-03-29 Tom Tromey <tromey@adacore.com>
5178
5179 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
5180 help text. Remove dead code.
5181
5182 2019-03-29 Keith Seitz <keiths@redhat.com>
5183
5184 From Siddhesh Poyarekar:
5185 * f-lang.h (f77_get_upperbound): Return LONGEST.
5186 (f77_get_lowerbound): Likewise.
5187 * f-typeprint.c (f_type_print_varspec_suffix): Expand
5188 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
5189 print them.
5190 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
5191 plongest to format print it.
5192 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5193 (f77_get_upperbound): Likewise.
5194 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5195 LOWER_BOUND to LONGEST.
5196 (f77_create_arrayprint_offset_tbl): Likewise.
5197
5198 2019-03-29 Keith Seitz <keiths@redhat.com>
5199
5200 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5201 %s/pulongest for TYPE_LENGTH instead of %d in format
5202 strings.
5203 * ada-typerint.c (ada_print_type): Likewise.
5204 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5205 * compile/compile-c-support.c (generate_register_struct): Likewise.
5206 * gdbtypes.c (recursive_dump_type): Likewise.
5207 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5208 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
5209 instead of %d in format strings.
5210 * riscv-tdep.c (riscv_type_alignment): Cast second argument
5211 to std::min to ULONGEST.
5212 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5213 instead of %d in format strings.
5214 * tracepoint.c (info_scope_command): Likewise.
5215 * typeprint.c (print_offset_data::update)
5216 (print_offset_data::finish): Likewise.
5217 * xtensa-tdep.c (xtensa_store_return_value)
5218 (xtensa_push_dummy_call): Likewise.
5219
5220 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
5221
5222 * windows-nat.c (display_selector): Fixed format specifications
5223 for 64-bit Cygwin.
5224
5225 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5226
5227 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5228
5229 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
5230
5231 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5232 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5233 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5234 (nios2_linux_init_abi): Install it.
5235
5236 2019-03-28 Alan Hayward <alan.hayward@arm.com>
5237
5238 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5239
5240 2019-03-28 Alan Hayward <alan.hayward@arm.com>
5241
5242 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5243
5244 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5245 Tom Tromey <tromey@adacore.com>
5246
5247 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5248
5249 2019-03-26 Joel Brobecker <brobecker@adacore.com>
5250
5251 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5252 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5253 method to compute the bounds of range types. Also print "[evaluated]"
5254 if the bounds' values come from a dynamic evaluation.
5255
5256 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
5257
5258 * cp-valprint.c (cp_print_value_fields): Don't print trailing
5259 whitespace when pretty printing is on.
5260
5261 2019-03-26 Alan Hayward <alan.hayward@arm.com>
5262
5263 * ppc-linux-nat.c: Add include.
5264
5265 2019-03-26 Alan Hayward <alan.hayward@arm.com>
5266
5267 * NEWS: Mention AArch64 Pointer Authentication.
5268
5269 2019-03-26 Alan Hayward <alan.hayward@arm.com>
5270
5271 * arm-linux-nat.c: Add include.
5272
5273 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
5274
5275 * source-cache.c (source_cache::get_source_lines): Re-read
5276 fullname after calling open_source_file.
5277
5278 2019-03-25 John Baldwin <jhb@FreeBSD.org>
5279
5280 * NEWS: Mention TLS support for FreeBSD.
5281
5282 2019-03-25 Tom Tromey <tromey@adacore.com>
5283
5284 * minsyms.c (BUNCH_SIZE): Update comment.
5285 (~minimal_symbol_reader): Remove old comment.
5286 (compact_minimal_symbols): Update comment.
5287 (minimal_symbol_reader::install): Remove old comment. Update
5288 other comments.
5289
5290 2019-03-25 Alan Hayward <alan.hayward@arm.com>
5291
5292 * s390-linux-nat.c: Add include.
5293
5294 2019-03-25 Alan Hayward <alan.hayward@arm.com>
5295
5296 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5297 Call linux_get_hwcap.
5298 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5299 Likewise.
5300 (aarch64_linux_get_hwcap): Remove function.
5301 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5302 declaration.
5303 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5304 linux_get_hwcap.
5305 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5306 * linux-tdep.c (linux_get_hwcap): Add function.
5307 (linux_get_hwcap2): Likewise.
5308 * linux-tdep.h (linux_get_hwcap): Add declaration.
5309 (linux_get_hwcap2): Likewise.
5310 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5311 (ppc_linux_get_hwcap2): Likewise.
5312 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5313 linux_get_hwcap.
5314 (ppc_linux_nat_target::insert_watchpoint): Likewise.
5315 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5316 (ppc_linux_nat_target::read_description): Likewise.
5317 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5318 * s390-linux-nat.c: Likewise.
5319 * s390-linux-tdep.c (s390_core_read_description): Likewise.
5320
5321 2019-03-24 Tom Tromey <tom@tromey.com>
5322
5323 * ada-lang.c (standard_lookup): Simplify initialization.
5324 (ada_lookup_symbol_nonlocal): Simplify return.
5325 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5326 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5327 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5328 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5329 initialization.
5330 * solib.c (solib_global_lookup): Simplify.
5331 * symtab.c (null_block_symbol): Remove.
5332 (symbol_cache_lookup): Simplify returns.
5333 (lookup_language_this): Simplify returns.
5334 (lookup_symbol_aux): Simplify return.
5335 (lookup_local_symbol): Simplify returns.
5336 (lookup_global_symbol_from_objfile): Simplify return.
5337 (lookup_symbol_in_objfile_symtabs)
5338 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5339 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5340 (lookup_static_symbol, lookup_global_symbol): Simplify return.
5341 * cp-namespace.c (cp_lookup_bare_symbol)
5342 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5343 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5344 (cp_lookup_nested_symbol): Don't use null_block_symbol.
5345 (cp_lookup_symbol_via_imports): Simplify initialization.
5346 (find_symbol_in_baseclass): Likewise.
5347 * symtab.h (null_block_symbol): Remove.
5348 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5349 (d_lookup_nested_symbol, d_lookup_symbol_imports)
5350 (d_lookup_symbol_module): Likewise.
5351 (find_symbol_in_baseclass): Simplify initialization.
5352
5353 2019-03-24 Tom Tromey <tom@tromey.com>
5354
5355 * expression.h: Don't include symtab.h.
5356 (struct block): Forward declare.
5357
5358 2019-03-24 Tom Tromey <tom@tromey.com>
5359
5360 * c-exp.y (typebase): Remove casts.
5361 * gdbtypes.c (lookup_unsigned_typename, )
5362 (lookup_signed_typename): Remove cast.
5363 * eval.c (parse_to_comma_and_eval): Remove cast.
5364 * parse.c (write_dollar_variable): Remove cast.
5365 * block.h (struct block) <superblock>: Now const.
5366 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5367 * psymtab.c (psym_map_matching_symbols): Make "block" const.
5368 (map_block): Make "block" const.
5369 * symfile.h (struct quick_symbol_functions)
5370 <map_matching_symbols>: Constify block argument to "callback".
5371 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5372 const.
5373 (find_pc_sect_compunit_symtab): Make "b" const.
5374 (find_symbol_at_address): Likewise.
5375 (search_symbols): Likewise.
5376 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5377 (dw2_debug_names_lookup_symbol): Likewise.
5378 (dw2_map_matching_symbols): Update.
5379 * p-valprint.c (pascal_val_print): Remove "block".
5380 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5381 (aux_add_nonlocal_symbols): Make "block" const.
5382 (resolve_subexp): Remove cast.
5383 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5384 const.
5385 (iterate_over_file_blocks): Likewise.
5386 * f-exp.y (%union) <bval>: Remove.
5387 * coffread.c (patch_opaque_types): Make "b" const.
5388 * spu-tdep.c (spu_catch_start): Make "block" const.
5389 * c-valprint.c (print_unpacked_pointer): Remove "block".
5390 * symmisc.c (dump_symtab_1): Make "b" const.
5391 (block_depth): Make "block" const.
5392 * d-exp.y (%union) <bval>: Remove.
5393 * cp-support.h (cp_lookup_rtti_type): Update.
5394 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5395 * psymtab.c (psym_lookup_symbol): Make "block" const.
5396 (maintenance_check_psymtabs): Make "b" const.
5397 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5398 (enumerate_locals, enumerate_args): Update.
5399 * python/py-symtab.c (stpy_global_block): Make "block" const.
5400 (stpy_static_block): Likewise.
5401 * inline-frame.c (block_starting_point_at): Make "new_block"
5402 const.
5403 * block.c (find_block_in_blockvector): Make return type const.
5404 (blockvector_for_pc_sect): Make "b" const.
5405 (find_block_in_blockvector): Make "b" const.
5406
5407 2019-03-23 Tom Tromey <tom@tromey.com>
5408
5409 * varobj.c (varobj_create): Update.
5410 * symfile.c (clear_symtab_users): Don't reset innermost_block.
5411 * printcmd.c (display_command, do_one_display): Don't reset
5412 innermost_block.
5413 * parser-defs.h (enum innermost_block_tracker_type): Move to
5414 expression.h.
5415 (innermost_block): Update comment.
5416 * parse.c (parse_exp_1): Add tracker_types parameter.
5417 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
5418 tracker_types parameter. Reset innermost_block.
5419 (parse_exp_in_context): Remove.
5420 (parse_expression_for_completion): Update.
5421 * objfiles.c (~objfile): Don't reset expression_context_block or
5422 innermost_block.
5423 * expression.h (enum innermost_block_tracker_type): Move from
5424 parser-defs.h.
5425 (parse_exp_1): Add tracker_types parameter.
5426 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5427 reset innermost_block.
5428
5429 2019-03-23 Tom Tromey <tom@tromey.com>
5430
5431 * objfiles.h: Include bcache.h.
5432
5433 2019-03-23 Tom Tromey <tom@tromey.com>
5434
5435 * linespec.c (get_current_search_block): Use
5436 scoped_restore_current_language.
5437 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5438
5439 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5440 Jiong Wang <jiong.wang@arm.com>
5441
5442 * aarch64-linux-tdep.c
5443 (aarch64_linux_iterate_over_regset_sections): Check for pauth
5444 section.
5445 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5446
5447 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5448 Jiong Wang <jiong.wang@arm.com>
5449
5450 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5451 instructions.
5452 (aarch64_analyze_prologue_test): Add PACIASP test.
5453 (aarch64_prologue_prev_register): Unmask PC value.
5454
5455 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5456 Jiong Wang <jiong.wang@arm.com>
5457
5458 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5459 (aarch64_dwarf2_prev_register): Unmask PC value.
5460 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5461 (aarch64_execute_dwarf_cfa_vendor_op): Check for
5462 DW_CFA_AARCH64_negate_ra_state.
5463 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5464
5465 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5466 Jiong Wang <jiong.wang@arm.com>
5467
5468 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5469 registers.
5470 (aarch64_pseudo_register_name): Likewise.
5471 (aarch64_pseudo_register_type): Likewise.
5472 (aarch64_pseudo_register_reggroup_p): Likewise.
5473 (aarch64_gdbarch_init): Add pauth registers.
5474 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5475 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5476 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5477 (struct gdbarch_tdep): Add regnum for ra_state.
5478
5479 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5480 Jiong Wang <jiong.wang@arm.com>
5481
5482 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5483
5484 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5485 Jiong Wang <jiong.wang@arm.com>
5486
5487 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5488 function.
5489 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5490 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5491 (aarch64_gdbarch_init): Add puth registers.
5492 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5493 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5494 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5495
5496 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5497 Jiong Wang <jiong.wang@arm.com>
5498
5499 * aarch64-linux-nat.c
5500 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5501 * aarch64-linux-tdep.c
5502 (aarch64_linux_core_read_description): Likewise.
5503 (aarch64_linux_get_hwcap): New function.
5504 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5505 (aarch64_linux_get_hwcap): New declaration.
5506
5507 2019-03-22 Alan Hayward <alan.hayward@arm.com>
5508 Jiong Wang <jiong.wang@arm.com>
5509
5510 * aarch64-linux-nat.c
5511 (aarch64_linux_nat_target::read_description): Add pauth param.
5512 * aarch64-linux-tdep.c
5513 (aarch64_linux_core_read_description): Likewise.
5514 * aarch64-tdep.c (struct target_desc): Add in pauth.
5515 (aarch64_read_description): Add pauth param.
5516 (aarch64_gdbarch_init): Likewise.
5517 * aarch64-tdep.h (aarch64_read_description): Likewise.
5518 * arch/aarch64.c (aarch64_create_target_description): Likewise.
5519 * arch/aarch64.h (aarch64_create_target_description): Likewise.
5520 * features/Makefile: Add new files.
5521 * features/aarch64-pauth.c: New file.
5522 * features/aarch64-pauth.xml: New file.
5523
5524 2019-03-20 Tom Tromey <tromey@adacore.com>
5525
5526 * infrun.c (handle_inferior_event): Rename from
5527 handle_inferior_event_1. Create a scoped_value_mark.
5528 (handle_inferior_event): Remove.
5529
5530 2019-03-19 Tom Tromey <tromey@adacore.com>
5531
5532 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5533 * infrun.h (print_stop_event): Add "displays" parameter.
5534 * infrun.c (print_stop_event): Add "displays" parameter.
5535
5536 2019-03-19 Pedro Alves <palves@redhat.com>
5537
5538 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5539 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
5540 to -1. Fix TABs vs spaces.
5541 (tui_ui_out::tui_ui_out): Don't initialize fields here.
5542 * tui/tui-out.h (tui_ui_out) Add intro comments.
5543 <m_line, m_start_of_line>: In-class initialize, and add describing
5544 comment.
5545
5546 2019-03-18 Alan Hayward <alan.hayward@arm.com>
5547
5548 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5549 variable names.
5550 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5551
5552 2019-03-18 Pedro Alves <palves@redhat.com>
5553 Eli Zaretskii <eliz@gnu.org>
5554
5555 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5556 m_line and m_start_of_line.
5557
5558 2019-03-18 Eli Zaretskii <eliz@gnu.org>
5559
5560 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5561 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5562 it returns a newline. This fixes a regression in TU mode, whereby
5563 the next line is output on the same screen line as the user input.
5564
5565 2019-03-18 Tom Tromey <tromey@adacore.com>
5566
5567 * minsyms.c (minimal_symbol_reader::install): Remove call to
5568 obstack_blank.
5569
5570 2019-03-18 Pedro Alves <palves@redhat.com>
5571
5572 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5573 New globals.
5574 (apply_style): New, factored out from ...
5575 (apply_ansi_escape): ... this. Handle reverse video mode.
5576 (tui_set_reverse_mode): New function.
5577 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5578 * tui/tui-winsource.c (tui_show_source_line): Use
5579 tui_set_reverse_mode instead of setting A_STANDOUT.
5580 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5581 New setter methods.
5582
5583 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
5584
5585 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5586 Handle tabs.
5587
5588 2019-03-18 Tom Tromey <tromey@adacore.com>
5589
5590 * ada-lang.c (empty_array): Add "high" parameter.
5591 (ada_evaluate_subexp): Update.
5592
5593 2019-03-17 Sergei Trofimovich <siarheit@google.com>
5594
5595 * unittests/string_view-selftests.c: Define
5596 _initialize_string_view_selftests unconditionally.
5597
5598 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
5599
5600 PR gdb/24350
5601 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5602
5603 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
5604
5605 PR gdb/24351
5606 * windows-nat.c (display_selector): Fix format specifiers.
5607
5608 2019-03-17 Eli Zaretskii <eliz@gnu.org>
5609
5610 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5611 tui_refill_source_window instead of tui_refresh_win, to update the
5612 current execution line. This fixes redisplay of the current line
5613 when stepping through the code with "next" or "step".
5614
5615 2019-03-16 Eli Zaretskii <eliz@gnu.org>
5616
5617 * source-cache.c (source_cache::get_source_lines): Call
5618 find_source_lines to initialize s->nlines. This fixes vertical
5619 scrolling of TUI source window when the DOWN arrow is pressed.
5620
5621 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5622
5623 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5624 linux-thread-db.c (_initialize_thread_db): Likewise.
5625
5626 2019-03-16 Eli Zaretskii <eliz@gnu.org>
5627
5628 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5629 wclrtoeol in tui_show_source_line". This reverts changes made in
5630 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5631
5632 2019-03-15 Tom Tromey <tom@tromey.com>
5633
5634 * symtab.h (struct minimal_symbol): Derive from
5635 general_symbol_info.
5636 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5637 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5638 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5639 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5640 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5641 (MSYMBOL_SEARCH_NAME): Update.
5642 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5643 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5644 * minsyms.c (minimal_symbol_reader::record_full): Update.
5645
5646 2019-03-15 Tom Tromey <tom@tromey.com>
5647
5648 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5649
5650 2019-03-15 Tom Tromey <tom@tromey.com>
5651
5652 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5653 unique_xmalloc_ptr.
5654 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5655 Update.
5656 * minsyms.c (lookup_minimal_symbol_by_pc_section)
5657 (build_minimal_symbol_hash_tables)
5658 (minimal_symbol_reader::install): Update.
5659
5660 2019-03-15 Tom Tromey <tom@tromey.com>
5661
5662 * symtab.c (create_demangled_names_hash): Update.
5663 (symbol_set_names): Update.
5664 * objfiles.h (struct objfile_per_bfd_storage)
5665 <demangled_names_hash>: Now an htab_up.
5666 * objfiles.c (objfile_per_bfd_storage): Simplify.
5667
5668 2019-03-15 Tom Tromey <tom@tromey.com>
5669
5670 * objfiles.h (struct objfile_per_bfd_storage): Declare
5671 destructor.
5672 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5673 New.
5674 (get_objfile_bfd_data): Use new. Don't initialize
5675 language_of_main.
5676 (free_objfile_per_bfd_storage): Remove.
5677 (objfile_bfd_data_free, objfile::~objfile): Use delete.
5678
5679 2019-03-15 Tom Tromey <tom@tromey.com>
5680
5681 * symfile.c (reread_symbols): Update.
5682 * objfiles.c (objfile::objfile): Update.
5683 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5684 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5685 comment.
5686 (minimal_symbol_reader::install): Update.
5687 (terminate_minimal_symbol_table): Remove.
5688 * jit.c (jit_object_close_impl): Update.
5689
5690 2019-03-15 Tom Tromey <tom@tromey.com>
5691
5692 * minsyms.c (minimal_symbol_reader::record_full): Remove some
5693 initializations.
5694
5695 2019-03-15 Tom Tromey <tom@tromey.com>
5696
5697 * objfiles.h (struct objfile_per_bfd_storage)
5698 <demangled_hash_languages>: Now a bitset.
5699 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5700 (lookup_minimal_symbol): Update.
5701
5702 2019-03-15 Tom Tromey <tom@tromey.com>
5703
5704 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5705 Don't return the symbol.
5706 * coffread.c (record_minimal_symbol): Use record_full.
5707
5708 2019-03-14 Eli Zaretskii <eliz@gnu.org>
5709
5710 The MS-Windows port of ncurses fails to switch to a color pair if
5711 one or both of the colors are the implicit default colors. This
5712 change records the default colors when TUI is initialized, and
5713 then specifies them explicitly when a color pair uses the default
5714 colors. This allows color styling in TUI mode on MS-Windows.
5715
5716 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
5717 ncurses_norm_attr.
5718 (tui_initialize_io) [__MINGW32__]: Record the default terminal
5719 colors in ncurses_norm_attr.
5720 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5721 "none", replace it with the default color recorded in
5722 ncurses_norm_attr.
5723
5724 2019-03-14 Tom Tromey <tromey@adacore.com>
5725
5726 * source-cache.h (class source_cache) <get_source_lines>: Return
5727 std::string.
5728 * source-cache.c (source_cache::extract_lines): Handle case where
5729 first_pos==npos. Return std::string.
5730 (source_cache::get_source_lines): Update.
5731
5732 2019-03-14 Tom Tromey <tromey@adacore.com>
5733
5734 * NEWS: Add item for "style sources" commands.
5735 * source-cache.c (source_cache::get_source_lines): Check
5736 source_styling.
5737 * cli/cli-style.c (source_styling): New global.
5738 (_initialize_cli_style): Add "style sources" commands.
5739 (show_style_sources): New function.
5740 * cli/cli-style.h (source_styling): Declare.
5741
5742 2019-03-14 Pedro Alves <palves@redhat.com>
5743 Tom Tromey <tromey@adacore.com>
5744
5745 * tui/tui-winsource.h (tui_refill_source_window): Declare.
5746 * tui/tui-winsource.c (tui_refill_source_window): New function,
5747 from...
5748 (tui_horizontal_source_scroll): ... here. Move some logic.
5749 * cli/cli-style.c (set_style_enabled): Notify new observable.
5750 * tui/tui-hooks.c (tui_redisplay_source): New function.
5751 (tui_attach_detach_observers): Attach or detach
5752 tui_redisplay_source.
5753 * observable.h (source_styling_changed): New observable.
5754 * observable.c: Define source_styling_changed observable.
5755
5756 2019-03-13 Tom Tromey <tromey@adacore.com>
5757
5758 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5759 (i386_gnu_nat_target::store_registers): Update.
5760 * target-debug.h (target_debug_print_std_string): New macro.
5761 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5762 * windows-tdep.c (display_one_tib): Update.
5763 * tui/tui-stack.c (tui_make_status_line): Update.
5764 * top.c (print_inferior_quit_action): Update.
5765 * thread.c (thr_try_catch_cmd): Update.
5766 (add_thread_with_info): Update.
5767 (thread_target_id_str): Update.
5768 (thr_try_catch_cmd): Update.
5769 (thread_command): Update.
5770 (thread_find_command): Update.
5771 * record-btrace.c (record_btrace_target::info_record)
5772 (record_btrace_resume_thread, record_btrace_target::resume)
5773 (record_btrace_cancel_resume, record_btrace_step_thread)
5774 (record_btrace_target::wait, record_btrace_target::wait)
5775 (record_btrace_target::wait, record_btrace_target::stop): Update.
5776 * progspace.c (print_program_space): Update.
5777 * process-stratum-target.c
5778 (process_stratum_target::thread_address_space): Update.
5779 * linux-fork.c (linux_fork_mourn_inferior)
5780 (detach_checkpoint_command, info_checkpoints_command)
5781 (linux_fork_context): Update.
5782 (linux_fork_detach): Update.
5783 (class scoped_switch_fork_info): Update.
5784 (delete_checkpoint_command): Update.
5785 * infrun.c (follow_fork_inferior): Update.
5786 (follow_fork_inferior): Update.
5787 (proceed_after_vfork_done): Update.
5788 (handle_vfork_child_exec_or_exit): Update.
5789 (follow_exec): Update.
5790 (displaced_step_prepare_throw): Update.
5791 (displaced_step_restore): Update.
5792 (start_step_over): Update.
5793 (resume_1): Update.
5794 (clear_proceed_status_thread): Update.
5795 (proceed): Update.
5796 (print_target_wait_results): Update.
5797 (do_target_wait): Update.
5798 (context_switch): Update.
5799 (stop_all_threads): Update.
5800 (restart_threads): Update.
5801 (finish_step_over): Update.
5802 (handle_signal_stop): Update.
5803 (switch_back_to_stepped_thread): Update.
5804 (keep_going_pass_signal): Update.
5805 (print_exited_reason): Update.
5806 (normal_stop): Update.
5807 * inferior.c (inferior_pid_to_str): Change return type.
5808 (print_selected_inferior): Update.
5809 (add_inferior): Update.
5810 (detach_inferior): Update.
5811 * dummy-frame.c (fprint_dummy_frames): Update.
5812 * dcache.c (dcache_info_1): Update.
5813 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5814 (btrace_fetch, btrace_clear): Update.
5815 * linux-tdep.c (linux_core_pid_to_str): Change return type.
5816 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5817 type.
5818 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5819 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5820 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5821 * gdbarch.c, gdbarch.h: Rebuild.
5822 * gdbarch.sh (core_pid_to_str): Change return type.
5823 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5824 return type.
5825 (windows_nat_target::pid_to_str): Change return type.
5826 (windows_delete_thread): Update.
5827 (windows_nat_target::attach): Update.
5828 (windows_nat_target::files_info): Update.
5829 * target-delegates.c: Rebuild.
5830 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5831 return type.
5832 (sol_thread_target::pid_to_str): Change return type.
5833 * remote.c (class remote_target) <pid_to_str>: Change return
5834 type.
5835 (remote_target::pid_to_str): Change return type.
5836 (extended_remote_target::attach, remote_target::remote_stop_ns)
5837 (remote_target::remote_notif_remove_queued_reply)
5838 (remote_target::push_stop_reply, remote_target::disable_btrace):
5839 Update.
5840 (extended_remote_target::attach): Update.
5841 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5842 type.
5843 (gdbsim_target::pid_to_str): Change return type.
5844 * ravenscar-thread.c (struct ravenscar_thread_target)
5845 <pid_to_str>: Change return type.
5846 (ravenscar_thread_target::pid_to_str): Change return type.
5847 * procfs.c (class procfs_target) <pid_to_str>: Change return
5848 type.
5849 (procfs_target::pid_to_str): Change return type.
5850 (procfs_target::attach): Update.
5851 (procfs_target::detach): Update.
5852 (procfs_target::fetch_registers): Update.
5853 (procfs_target::store_registers): Update.
5854 (procfs_target::wait): Update.
5855 (procfs_target::files_info): Update.
5856 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5857 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5858 return type.
5859 (nto_procfs_target::pid_to_str): Change return type.
5860 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5861 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5862 return type.
5863 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5864 (exit_lwp): Update.
5865 (attach_proc_task_lwp_callback, get_detach_signal)
5866 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5867 (linux_nat_target::resume, wait_lwp, stop_callback)
5868 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5869 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5870 (linux_nat_wait_1, resume_stopped_resumed_lwps)
5871 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5872 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5873 type.
5874 (inf_ptrace_target::attach): Update.
5875 (inf_ptrace_target::files_info): Update.
5876 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5877 type.
5878 (go32_nat_target::pid_to_str): Change return type.
5879 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5880 (gnu_nat_target::wait): Update.
5881 (gnu_nat_target::wait): Update.
5882 (gnu_nat_target::resume): Update.
5883 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5884 (fbsd_nat_target::wait): Update.
5885 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5886 type.
5887 (darwin_nat_target::attach): Update.
5888 * corelow.c (class core_target) <pid_to_str>: Change return type.
5889 (core_target::pid_to_str): Change return type.
5890 * target.c (normal_pid_to_str): Change return type.
5891 (default_pid_to_str): Likewise.
5892 (target_pid_to_str): Change return type.
5893 (target_translate_tls_address): Update.
5894 (target_announce_detach): Update.
5895 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5896 return type.
5897 (bsd_uthread_target::pid_to_str): Change return type.
5898 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5899 type.
5900 (bsd_kvm_target::pid_to_str): Change return type.
5901 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5902 return type.
5903 (aix_thread_target::pid_to_str): Change return type.
5904 * target.h (struct target_ops) <pid_to_str>: Change return type.
5905 (target_pid_to_str, normal_pid_to_str): Likewise.
5906 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5907 type.
5908 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5909 type.
5910 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5911 return type.
5912 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5913 type.
5914 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5915 type.
5916 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5917 return type.
5918
5919 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
5920
5921 * NEWS: Mention that the new default MI version is 3. Mention
5922 changes to the output of commands and events that deal with
5923 multi-location breakpoints.
5924 * breakpoint.c: Include "mi/mi-out.h".
5925 (print_one_breakpoint): Change output syntax if using MI version
5926 >= 3.
5927 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5928 New.
5929 (mi_multi_location_breakpoint_output_fixed): New.
5930 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5931 (mi_cmd_fix_multi_location_breakpoint_output): New.
5932 (mi_multi_location_breakpoint_output_fixed): New.
5933 * mi/mi-cmds.c (mi_cmds): Register command
5934 -fix-multi-location-breakpoint-output.
5935 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5936 interpreter "mi".
5937
5938 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
5939
5940 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5941 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5942 instantiate mi_ui_out based on interpreter name.
5943 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5944 * mi/mi-main.c (mi_load_progress): Likewise.
5945
5946 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5947
5948 * NEWS: Combine separate "New targets" sections for 8.3.
5949
5950 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5951
5952 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5953 (ppcfbsd_init_abi): Install gdbarch
5954 "fetch_tls_load_module_address" and "get_thread_local_address"
5955 methods.
5956
5957 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5958
5959 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5960 (riscv_fbsd_init_abi): Install gdbarch
5961 "fetch_tls_load_module_address" and "get_thread_local_address"
5962 methods.
5963
5964 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5965
5966 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5967 (i386fbsd_init_abi): Install gdbarch
5968 "fetch_tls_load_module_address" and "get_thread_local_address"
5969 methods.
5970
5971 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5972
5973 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5974 (amd64fbsd_init_abi): Install gdbarch
5975 "fetch_tls_load_module_address" and "get_thread_local_address"
5976 methods.
5977
5978 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5979
5980 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5981 (struct fbsd_pspace_data): New type.
5982 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5983 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5984 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5985 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5986 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5987
5988 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5989
5990 * gdbtypes.c (lookup_struct_elt): New function.
5991 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5992 * gdbtypes.h (struct struct_elt): New type.
5993 (lookup_struct_elt): New prototype.
5994
5995 2019-03-12 John Baldwin <jhb@FreeBSD.org>
5996
5997 * gdbtypes.c (lookup_struct_elt_type): Update comment and
5998 remove disabled code block.
5999
6000 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6001
6002 * gdbarch.sh (get_thread_local_address): New method.
6003 * gdbarch.h, gdbarch.c: Regenerate.
6004 * target.c (target_translate_tls_address): Use
6005 gdbarch_get_thread_local_address if present instead of
6006 target::get_thread_local_address.
6007
6008 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6009
6010 * target.h (target::get_thread_local_address): Update comment.
6011
6012 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6013
6014 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6015 objfile->separate_debug_objfile_backlink if not NULL.
6016
6017 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6018
6019 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6020 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6021 (amd64bsd_store_inferior_registers): Likewise.
6022 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6023 Enable segment base registers.
6024 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6025 PT_GETFSBASE and PT_GETGSBASE.
6026 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6027 PT_SETGSBASE.
6028 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6029 segment base registers.
6030 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6031
6032 2019-03-12 John Baldwin <jhb@FreeBSD.org>
6033
6034 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6035 Update calls to i386_target_description to add 'segments'
6036 parameter.
6037 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
6038 add segment base registers.
6039 * arch/i386.c (i386_create_target_description): Add 'segments'
6040 parameter to enable segment base registers.
6041 * arch/i386.h (i386_create_target_description): Likewise.
6042 * features/i386/32bit-segments.xml: New file.
6043 * features/i386/32bit-segments.c: Generate.
6044 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6045 call to i386_target_description to add 'segments' parameter.
6046 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6047 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6048 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6049 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6050 if feature is present.
6051 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6052 Add 'segments' parameter to call to i386_target_description.
6053 (i386_target_description): Add 'segments' parameter to enable
6054 segment base registers.
6055 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6056 to call to i386_target_description.
6057 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6058 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6059 Define I386_NUM_REGS.
6060 (i386_target_description): Add 'segments' parameter to enable
6061 segment base registers.
6062
6063 2019-03-12 Eli Zaretskii <eliz@gnu.org>
6064
6065 PR/24325
6066 * source-cache.c: #undef open and close, to avoid unresolved
6067 externals during linking.
6068
6069 2019-03-12 Tom Tromey <tromey@adacore.com>
6070
6071 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6072 const. Add initializers.
6073 (_initialize_remote): Don't initialize ptid globals.
6074
6075 2019-03-12 Pedro Alves <palves@redhat.com>
6076
6077 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6078
6079 2019-03-12 Pedro Alves <palves@redhat.com>
6080
6081 * cp-name-parser.y (main): Remove unused 'len' variable.
6082
6083 2019-03-12 Tom Tromey <tromey@adacore.com>
6084
6085 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6086 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6087
6088 2019-03-12 Tom Tromey <tromey@adacore.com>
6089
6090 * linux-nat.c (iterate_over_lwps): Update.
6091 (stop_callback): Remove parameter.
6092 (stop_wait_callback, detach_callback, resume_set_callback)
6093 (select_singlestep_lwp_callback, set_ignore_sigint)
6094 (status_callback, resumed_callback, resume_clear_callback)
6095 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6096 data parameter.
6097 (linux_nat_target::detach, linux_nat_target::resume)
6098 (linux_stop_and_wait_all_lwps, select_event_lwp)
6099 (linux_nat_filter_event, linux_nat_wait_1)
6100 (linux_nat_target::kill, linux_nat_target::stop)
6101 (linux_nat_target::stop): Update.
6102 (linux_nat_resume_callback): Change type.
6103 (resume_stopped_resumed_lwps, count_events_callback)
6104 (select_event_lwp_callback): Likewise.
6105 (linux_stop_lwp, linux_nat_stop_lwp): Update.
6106 * arm-linux-nat.c (struct update_registers_data): Remove.
6107 (update_registers_callback): Change type.
6108 (arm_linux_insert_hw_breakpoint1): Update.
6109 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6110 parameter.
6111 (x86_linux_dr_set_addr): Update.
6112 (x86_linux_dr_set_control): Update.
6113 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6114 (iterate_over_lwps): Use gdb::function_view.
6115 * nat/aarch64-linux-hw-point.c (struct
6116 aarch64_dr_update_callback_param): Remove.
6117 (debug_reg_change_callback): Change type.
6118 (aarch64_notify_debug_reg_change): Update.
6119 * s390-linux-nat.c (s390_refresh_per_info): Update.
6120
6121 2019-03-11 Tom Tromey <tromey@adacore.com>
6122
6123 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6124 redundant assignment to "this_cu".
6125
6126 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6127
6128 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6129
6130 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6131
6132 * gdbtypes.c (rank_one_type_parm_set): New function extracted
6133 from...
6134 (rank_one_type): ... this.
6135
6136 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6137
6138 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6139 from...
6140 (rank_one_type): ... this.
6141
6142 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6143
6144 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6145 from...
6146 (rank_one_type): ... this.
6147
6148 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6149
6150 * gdbtypes.c (rank_one_type_parm_float): New function extracted
6151 from...
6152 (rank_one_type): ... this.
6153
6154 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6155
6156 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6157 from...
6158 (rank_one_type): ... this.
6159
6160 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6161
6162 * gdbtypes.c (rank_one_type_parm_range): New function extracted
6163 from...
6164 (rank_one_type): ... this.
6165
6166 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6167
6168 * gdbtypes.c (rank_one_type_parm_char): New function extracted
6169 from...
6170 (rank_one_type): ... this.
6171
6172 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6173
6174 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6175 from...
6176 (rank_one_type): ... this.
6177
6178 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6179
6180 * gdbtypes.c (rank_one_type_parm_int): New function extracted
6181 from...
6182 (rank_one_type): ... this.
6183
6184 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6185
6186 * gdbtypes.c (rank_one_type_parm_func): New function extracted
6187 from...
6188 (rank_one_type): ... this.
6189
6190 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6191
6192 * gdbtypes.c (rank_one_type_parm_array): New function extracted
6193 from...
6194 (rank_one_type): ... this.
6195
6196 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
6197
6198 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6199 from...
6200 (rank_one_type): ... this.
6201
6202 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6203
6204 * inferior.c (initialize_inferiors): Ensure 'help set/show print
6205 inferior-events' shows the example events.
6206
6207 2019-03-08 Eli Zaretskii <eliz@gnu.org>
6208
6209 Support styling on native MS-Windows console
6210
6211 PR/24315
6212 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6213 on MS-Windows if $TERM is not defined.
6214
6215 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6216
6217 * posix-hdep.c (gdb_console_fputs):
6218 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6219 functions.
6220 * ui-file.h (gdb_console_fputs): Add prototype.
6221
6222 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6223 back to fputs only if the former returns zero.
6224
6225 2019-03-07 Tom Tromey <tom@tromey.com>
6226
6227 * symmisc.c (print_symbol_bcache_statistics): Update.
6228 (print_objfile_statistics): Update.
6229 * symfile.c (allocate_symtab): Update.
6230 * stabsread.c: Don't include bcache.h.
6231 * psymtab.h (struct psymbol_bcache): Don't declare.
6232 (class psymtab_storage) <psymbol_cache>: Now a bcache.
6233 (psymbol_bcache_init, psymbol_bcache_free)
6234 (psymbol_bcache_get_bcache): Don't declare.
6235 * psymtab.c (struct psymbol_bcache): Remove.
6236 (psymtab_storage::psymtab_storage): Update.
6237 (psymtab_storage::~psymtab_storage): Update.
6238 (psymbol_bcache_init, psymbol_bcache_free)
6239 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6240 (add_psymbol_to_bcache): Update.
6241 (allocate_psymtab): Update.
6242 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6243 macro_cache>: No longer pointers.
6244 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6245 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6246 * macrotab.c (macro_bcache): Update.
6247 * macroexp.c: Don't include bcache.h.
6248 * gdbtypes.c (check_types_worklist): Update.
6249 (types_deeply_equal): Remove TRY/CATCH. Update.
6250 * elfread.c (elf_symtab_read): Update.
6251 * dwarf2read.c: Don't include bcache.h.
6252 * buildsym.c (buildsym_compunit::get_macro_table): Update.
6253 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6254 (print_bcache_statistics, bcache_memory_used): Don't declare.
6255 (struct bcache): Move from bcache.c. Add constructor, destructor,
6256 methods. Rename all data members.
6257 * bcache.c (struct bcache): Move to bcache.h.
6258 (bcache::expand_hash_table): Rename from expand_hash_table.
6259 (bcache): Remove.
6260 (bcache::insert): Rename from bcache_full.
6261 (bcache::compare): Rename from bcache_compare.
6262 (bcache_xmalloc): Remove.
6263 (bcache::~bcache): Rename from bcache_xfree.
6264 (bcache::print_statistics): Rename from print_bcache_statistics.
6265 (bcache::memory_used): Rename from bcache_memory_used.
6266
6267 2019-03-07 Pedro Alves <palves@redhat.com>
6268
6269 * infrun.c (normal_stop): Also check for
6270 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6271
6272 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
6273
6274 * f-lang.c (value_from_host_double): Moved to...
6275 * value.c (value_from_host_double): ...here.
6276 * value.h (value_from_host_double): Declare.
6277 * guile/scm-math.c (vlscm_convert_typed_number): Use
6278 value_from_host_double.
6279 (vlscm_convert_number): Likewise.
6280 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6281 * python/py-value.c (convert_value_from_python): Likewise.
6282
6283 2019-03-06 Tom Tromey <tom@tromey.com>
6284
6285 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6286
6287 2019-03-06 Tom Tromey <tom@tromey.com>
6288
6289 * utils.h (free_current_contents): Don't declare.
6290 * utils.c (free_current_contents): Remove.
6291
6292 2019-03-06 Tom Tromey <tom@tromey.com>
6293
6294 * top.c (quit_force): Update.
6295 * main.c (captured_command_loop): Update.
6296 * common/new-op.c (operator new): Update.
6297 * common/common-exceptions.c (struct catcher)
6298 <save_cleanup_chain>: Remove member.
6299 (exceptions_state_mc_init): Update.
6300 (exception_try_scope_entry): Return nullptr.
6301 (exception_try_scope_exit, exception_rethrow)
6302 (throw_exception_sjlj, throw_exception_cxx): Update.
6303 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6304 (all_cleanups, do_cleanups, discard_cleanups)
6305 (discard_final_cleanups, save_cleanups, save_final_cleanups)
6306 (restore_cleanups, restore_final_cleanups): Don't declare.
6307 (do_final_cleanups): Remove parameter.
6308 * common/cleanups.c (cleanup_chain, make_cleanup)
6309 (make_cleanup_dtor, all_cleanups, do_cleanups)
6310 (discard_my_cleanups, discard_cleanups)
6311 (discard_final_cleanups, save_my_cleanups, save_cleanups)
6312 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6313 (null_cleanup): Remove.
6314 (do_final_cleanups): Remove parameter.
6315
6316 2019-03-06 Tom Tromey <tom@tromey.com>
6317
6318 * remote.c (remote_target::remote_parse_stop_reply): Use
6319 unique_xmalloc_ptr.
6320
6321 2019-03-06 Tom Tromey <tom@tromey.com>
6322
6323 * stabsread.c (struct stabs_field_info): Rename from field_info.
6324 <list, fnlist>: Add initializers.
6325 <obstack>: New member.
6326 (read_member_functions, read_struct_fields, read_baseclasses):
6327 Allocate on obstack. Don't use cleanups.
6328 (read_one_struct_field, read_member_functions, read_struct_fields)
6329 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6330 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6331 (read_struct_type): Update.
6332
6333 2019-03-06 Tom Tromey <tom@tromey.com>
6334
6335 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6336 * common/filestuff.h (make_cleanup_close): Don't declare.
6337 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6338 Remove.
6339
6340 2019-03-06 Tom Tromey <tom@tromey.com>
6341
6342 * solib-aix.c: Use make_scope_exit.
6343
6344 2019-03-06 Tom Tromey <tom@tromey.com>
6345
6346 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6347 Use make_scope_exit.
6348
6349 2019-03-06 Tom Tromey <tom@tromey.com>
6350
6351 * solib-svr4.c (disable_probes_interface): Remove parameter.
6352 (svr4_handle_solib_event): Use make_scope_exit.
6353
6354 2019-03-06 Tom Tromey <tom@tromey.com>
6355
6356 * remote.c (struct stop_reply_deleter): Remove.
6357 (stop_reply_up): Update.
6358 (struct stop_reply): Derive from notif_event. Don't typedef.
6359 <regcache>: Now a std::vector.
6360 (stop_reply_xfree): Remove.
6361 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6362 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
6363 (remote_target::discard_pending_stop_replies): Use delete.
6364 (remote_target::remote_parse_stop_reply): Update.
6365 (remote_target::process_stop_reply): Update.
6366 * remote-notif.h (struct notif_event): Add virtual destructor.
6367 Remove "dtr" member.
6368 (struct notif_client) <alloc_event>: Return a unique_ptr.
6369 (notif_event_xfree): Don't declare.
6370 (notif_event_up): New typedef.
6371 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6372 (notif_event_xfree, do_notif_event_xfree): Remove.
6373 (remote_notif_state_xfree): Update.
6374
6375 2019-03-06 Tom Tromey <tom@tromey.com>
6376
6377 * infrun.c (displaced_step_clear_cleanup): Now a
6378 forward_scope_exit type.
6379 (displaced_step_prepare_throw): Update.
6380 (displaced_step_fixup): Update.
6381
6382 2019-03-06 Tom Tromey <tom@tromey.com>
6383
6384 * inferior.h (class inferior): Update comment.
6385 * gdbthread.h (class thread_info): Update comment.
6386
6387 2019-03-06 Joel Brobecker <brobecker@adacore.com>
6388 Tom Tromey <tom@tromey.com>
6389
6390 * stabsread.h (struct stab_section_list): Remove.
6391 (coffstab_build_psymtabs): Update.
6392 * dbxread.c (symbuf_sections): Now a std::vector.
6393 (sect_idx): New global.
6394 (fill_symbuf): Update.
6395 (coffstab_build_psymtabs): Change type of stabsects parameter.
6396 Update.
6397 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6398 std::vector.
6399 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6400 (coff_locate_sections): Update.
6401 (coff_symfile_read): Remove cleanups. Update.
6402 (init_stringtab): Add storage parameter.
6403 (free_stringtab, free_stringtab_cleanup): Remove.
6404 (init_lineno): Add storage parameter.
6405 (free_linetab, free_linetab_cleanup): Remove.
6406
6407 2019-03-06 Pedro Alves <palves@redhat.com>
6408
6409 * linux-fork.c (fork_info::clobber_regs): Delete.
6410 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6411 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
6412 comment. Adjust.
6413 (scoped_switch_fork_info::scoped_switch_fork_info)
6414 (checkpoint_command, linux_fork_context): Adjust
6415 fork_save_infrun_state calls.
6416
6417 2019-03-06 Pedro Alves <palves@redhat.com>
6418
6419 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6420 (inf_has_multiple_threads): Return 'bool' and rewrite using
6421 inferior_info::threads().
6422
6423 2019-03-06 Pedro Alves <palves@redhat.com>
6424
6425 * linux-fork.c: Include <list>.
6426 (fork_list): Now a std::list instance.
6427 (fork_info): Add ctor, dtor, and in-class initialize all fields.
6428 (forks_exist_p, find_last_fork): Adjust.
6429 (new_fork): Delete.
6430 (one_fork_p): New.
6431 (add_fork): Adjust.
6432 (free_fork): Delete, folded into fork_info::~fork_info().
6433 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6434 Adjust.
6435 (init_fork_list): Delete.
6436 (linux_fork_killall, linux_fork_mourn_inferior)
6437 (linux_fork_detach, info_checkpoints_command): Adjust.
6438 (_initialize_linux_fork): No longer call init_fork_list.
6439
6440 2019-03-06 Pedro Alves <palves@redhat.com>
6441
6442 * linux-fork.c (new_fork): New, split out of ...
6443 (add_fork): ... this. Return void. Move "first fork" special
6444 case from here, to ...
6445 (checkpoint_command): ... here.
6446 * linux-linux.h (add_fork): Return void.
6447
6448 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6449
6450 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6451
6452 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6453 Chris January <chris.january@arm.com>
6454 David Lecomber <david.lecomber@arm.com>
6455
6456 * f-exp.y: New token, UNOP_INTRINSIC.
6457 (exp): New pattern using UNOP_INTRINSIC token.
6458 (f77_keywords): Add 'abs' keyword.
6459 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6460 (value_from_host_double): New function.
6461 (evaluate_subexp_f): Support UNOP_ABS.
6462
6463 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6464
6465 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6466 types.
6467
6468 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6469
6470 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6471 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6472 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6473
6474 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6475
6476 * f-exp.y (convert_to_kind_type): Handle more type kinds.
6477
6478 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6479 Chris January <chris.january@arm.com>
6480
6481 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6482 * f-exp.y: Define 'KIND' token.
6483 (exp): New pattern for KIND expressions.
6484 (ptype): Handle types with a kind extension.
6485 (direct_abs_decl): Extend to spot kind extensions.
6486 (f77_keywords): Add 'kind' to the list.
6487 (push_kind_type): New function.
6488 (convert_to_kind_type): New function.
6489 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6490 * parse.c (operator_length_standard): Likewise.
6491 * parser-defs.h (enum type_pieces): Add tp_kind.
6492 * std-operator.def: Add UNOP_KIND.
6493
6494 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6495
6496 * f-exp.y (f_parse): Set yydebug.
6497
6498 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6499
6500 * f-lang.c (evaluate_subexp_f): New function.
6501 (exp_descriptor_f): New global.
6502 (f_language_defn): Use exp_descriptor_f instead of
6503 exp_descriptor_standard.
6504
6505 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6506
6507 * f-exp.y (struct token): Add comments.
6508 (dot_ops): Remove uppercase versions and the end marker.
6509 (f77_keywords): Likewise.
6510 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6511 entries in the dot_ops array are case insensitive, and use
6512 strncasecmp to compare strings. Also some whitespace cleanup in
6513 this area. Similar for the f77_keywords array, except entries in
6514 this list might be case sensitive.
6515
6516 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
6517
6518 * f-exp.y (struct f77_boolean_val): Add comments.
6519 (boolean_values): Remove uppercase versions, and end marker.
6520 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6521 and use strncasecmp to achieve case insensitivity. Additionally,
6522 perform whitespace cleanup around this code.
6523
6524 2019-03-06 Tom Tromey <tromey@adacore.com>
6525
6526 * remote-sim.c (gdbsim_target_open): Use result of
6527 gdb_argv::release.
6528
6529 2019-03-06 Richard Bunt <richard.bunt@arm.com>
6530 Dirk Schubert <dirk.schubert@arm.com>
6531 Chris January <chris.january@arm.com>
6532
6533 * eval.c (evaluate_subexp_standard): Call Fortran argument
6534 wrapping logic.
6535 * f-lang.c (struct value): A value which can be passed into a
6536 Fortran function call.
6537 (fortran_argument_convert): Wrap Fortran arguments in a pointer
6538 where appropriate.
6539 (struct type): Value ready for a Fortran function call.
6540 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6541 is needed.
6542 * f-lang.h (fortran_argument_convert): Declaration.
6543 (fortran_preserve_arg_pointer): Declaration.
6544 * infcall.c (value_arg_coerce): Call Fortran argument logic.
6545
6546 2019-03-05 Tom Tromey <tromey@adacore.com>
6547
6548 * python/py-prettyprint.c (print_string_repr): Remove #if.
6549 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6550
6551 2019-03-05 Tom Tromey <tromey@adacore.com>
6552
6553 * target.c (the_dummy_target): Move later. Change type to
6554 "dummy_target".
6555 (initialize_targets): Don't initialize the_dummy_target.
6556
6557 2019-03-05 Tom Tromey <tromey@adacore.com>
6558
6559 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6560 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6561
6562 2019-03-05 Tom Tromey <tromey@adacore.com>
6563
6564 * windows-nat.c (windows_nat_target::attach)
6565 (windows_nat_target::detach): Don't call gdb_flush.
6566 * valprint.c (generic_val_print, val_print, val_print_string):
6567 Don't call gdb_flush.
6568 * utils.c (defaulted_query): Don't call gdb_flush.
6569 * typeprint.c (print_type_scalar): Don't call gdb_flush.
6570 * target.c (target_announce_detach): Don't call gdb_flush.
6571 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6572 * remote.c (extended_remote_target::attach): Don't call
6573 gdb_flush.
6574 * procfs.c (procfs_target::detach): Don't call gdb_flush.
6575 * printcmd.c (do_examine): Don't call gdb_flush.
6576 (info_display_command): Don't call gdb_flush.
6577 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6578 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6579 * memattr.c (info_mem_command): Don't call gdb_flush.
6580 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6581 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6582 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6583 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6584 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6585 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6586 (gnu_nat_target::detach): Don't call gdb_flush.
6587 * f-valprint.c (f_val_print): Don't call gdb_flush.
6588 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6589 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6590 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6591 gdb_flush.
6592 * c-valprint.c (c_val_print): Don't call gdb_flush.
6593 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6594
6595 2019-03-05 Tom Tromey <tromey@adacore.com>
6596
6597 * varobj.c (update_dynamic_varobj_children): Update.
6598 (install_default_visualizer): Use reset, not release.
6599 * value.c (set_internalvar): Update.
6600 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6601 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6602 ATTRIBUTE_UNUSED_RESULT.
6603
6604 2019-03-05 Tom Tromey <tromey@adacore.com>
6605
6606 * remote.c (class scoped_remote_fd) <release>: Add
6607 ATTRIBUTE_UNUSED_RESULT.
6608
6609 2019-03-05 Tom Tromey <tromey@adacore.com>
6610
6611 * macroexp.c (struct macro_buffer) <release>: Add
6612 ATTRIBUTE_UNUSED_RESULT.
6613
6614 2019-03-05 Tom Tromey <tromey@adacore.com>
6615
6616 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6617 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6618 ATTRIBUTE_UNUSED_RESULT.
6619
6620 2019-03-05 Tom Tromey <tromey@adacore.com>
6621
6622 * common/scoped_fd.h (class scoped_fd) <release>: Add
6623 ATTRIBUTE_UNUSED_RESULT.
6624
6625 2019-03-05 Tom Tromey <tromey@adacore.com>
6626
6627 * parser-defs.h (struct parser_state) <release>: Add
6628 ATTRIBUTE_UNUSED_RESULT.
6629
6630 2019-03-05 Tom Tromey <tromey@adacore.com>
6631
6632 * utils.h (class gdb_argv) <release>: Add
6633 ATTRIBUTE_UNUSED_RESULT.
6634 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6635
6636 2019-03-02 Eli Zaretskii <eliz@gnu.org>
6637
6638 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6639 for-loop range, to avoid compiler warnings.
6640
6641 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6642 avoid compiler warnings about unused variables.
6643
6644 * NEWS: Mention end of support for native debugging on MS-Windows
6645 before XP.
6646
6647 PR gdb/24292
6648 * common/netstuff.c:
6649 * gdbserver/gdbreplay.c
6650 * gdbserver/remote-utils.c:
6651 * ser-tcp.c:
6652 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6653 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
6654 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6655 'getaddrinfo' and 'freeaddrinfo' were not available before
6656 Windows XP, and mingw.org's MinGW headers by default define
6657 _WIN32_WINNT to 0x500.
6658
6659 2019-03-01 Gary Benson <gbenson@redhat.com>
6660
6661 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6662
6663 2019-02-28 Brian Vandenberg <phantall@gmail.com>
6664 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
6665
6666 PR gdb/8527
6667 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6668 set_sigint_trap, clear_sigint_trap.
6669
6670 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6671
6672 * target.c (target_detach): Clear the regcache and the
6673 frame cache.
6674
6675 2019-02-27 Pedro Alves <palves@redhat.com>
6676
6677 * utils.c (set_screen_size): When we cap the height/width sizes,
6678 tweak the corresponding command variable to show "unlimited":
6679
6680 2019-02-27 Saagar Jha <saagar@saagarjha.com>
6681 Pedro Alves <palves@redhat.com>
6682
6683 * utils.c (set_screen_size): Reduce "infinite" rows and columns
6684 before calling rl_set_screen_size.
6685
6686 2019-02-27 Tom Tromey <tromey@adacore.com>
6687
6688 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6689 define.
6690 * python/py-value.c: Remove Python 2.4 workaround.
6691 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6692 workaround.
6693 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6694 Python 2.4 workaround.
6695 * python/python-internal.h: Remove Python 2.4 comment.
6696 (Py_ssize_t): Don't define.
6697 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6698 (gdb_Py_DECREF): Remove Python 2.4 workaround.
6699 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6700 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6701 * python/python.c (do_start_initialization): Remove Python 2.4
6702 workaround.
6703 * python/py-prettyprint.c (class dummy_python_frame): Remove.
6704 (print_children): Remove Python 2.4 workaround.
6705 * python/py-inferior.c (buffer_procs): Remove Python 2.4
6706 workaround.
6707 (CHARBUFFERPROC_NAME): Remove.
6708 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6709 Python 2.4 workaround.
6710
6711 2019-02-27 Kevin Buettner <kevinb@redhat.com>
6712
6713 * NEWS: Note minimum Python version.
6714
6715 2019-02-27 Kevin Buettner <kevinb@redhat.com>
6716
6717 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6718 code from these functions. Remove corresponding ifdefs. Use
6719 Py_buffer_up instead of explicit calls to PyBuffer_Release.
6720 Remove gotos and target of gotos.
6721 (infpy_search_memory): Likewise.
6722
6723 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6724
6725 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6726 (hppa_gdbarch_init): Don't register deleted functions with
6727 gdbarch.
6728
6729 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6730
6731 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6732 (h8300_unwind_sp): Delete.
6733 (h8300_dummy_id): Delete.
6734 (h8300_gdbarch_init): Don't register deleted functions with
6735 gdbarch.
6736
6737 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6738
6739 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6740 (ft32_unwind_pc): Delete.
6741 (ft32_unwind_sp): Delete.
6742 (ft32_gdbarch_init): Don't register deleted functions with
6743 gdbarch.
6744
6745 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6746
6747 * gdb/frv-tdep.c (frv_dummy_id): Delete.
6748 (frv_unwind_pc): Delete.
6749 (frv_unwind_sp): Delete.
6750 (frv_gdbarch_init): Don't register deleted functions with
6751 gdbarch.
6752
6753 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6754
6755 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6756 (riscv_unwind_pc): Delete.
6757 (riscv_unwind_sp): Delete.
6758 (riscv_gdbarch_init): Don't register deleted functions with
6759 gdbarch.
6760
6761 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6762
6763 * gdb/csky-tdep.c (csky_dummy_id): Delete.
6764 (csky_unwind_pc): Delete.
6765 (csky_unwind_sp): Delete.
6766 (csky_gdbarch_init): Don't register deleted functions with
6767 gdbarch.
6768
6769 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6770
6771 * gdb/cris-tdep.c (cris_dummy_id): Delete.
6772 (cris_unwind_pc): Delete.
6773 (cris_unwind_sp): Delete.
6774 (cris_gdbarch_init): Don't register deleted functions with
6775 gdbarch.
6776
6777 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6778
6779 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6780 (bfin_unwind_pc): Delete.
6781 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6782
6783 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6784
6785 * gdb/arm-tdep.c (arm_dummy_id): Delete.
6786 (arm_unwind_pc): Delete.
6787 (arm_unwind_sp): Delete.
6788 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6789
6790 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6791
6792 * gdb/arc-tdep.c (arc_dummy_id): Delete.
6793 (arc_unwind_pc): Delete.
6794 (arc_unwind_sp): Delete.
6795 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6796
6797 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6798
6799 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6800 (alpha_unwind_pc): Delete.
6801 (alpha_gdbarch_init): Don't register deleted functions with
6802 gdbarch.
6803
6804 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6805
6806 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6807 (aarch64_unwind_pc): Delete.
6808 (aarch64_unwind_sp): Delete.
6809 (aarch64_gdbarch_init): Don't register deleted functions with
6810 gdbarch.
6811
6812 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6813
6814 * gdbtypes.c (type_align): Don't consider static members when
6815 computing structure alignment.
6816
6817 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
6818
6819 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6820 return 0 for other types.
6821 * arch-utils.c (default_type_align): Always return 0.
6822 * gdbarch.h: Regenerate.
6823 * gdbarch.sh (type_align): Extend comment.
6824 * gdbtypes.c (type_align): Add additional comments, always call
6825 gdbarch_type_align before applying the default rules.
6826 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6827 generic code will then apply a suitable default.
6828 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6829 types, return 0 for other types.
6830
6831 2019-02-27 Joel Brobecker <brobecker@adacore.com>
6832
6833 * NEWS: Create a new section for the next release branch.
6834 Rename the section of the current branch, now that it has
6835 been cut.
6836
6837 2019-02-27 Joel Brobecker <brobecker@adacore.com>
6838
6839 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6840 * version.in: Bump version to 8.3.50.DATE-git.
6841
6842 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
6843
6844 * aix-thread.c (ptid_cmp): Remove unused variable.
6845 (get_signaled_thread): Likewise.
6846 (store_regs_user_thread): Likewise.
6847 (store_regs_kernel_thread): Likewise.
6848 (fetch_regs_kernel_thread): Remove shadowed variable.
6849
6850 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
6851
6852 * features/riscv/32bit-cpu.xml: Add register numbers.
6853 * features/riscv/32bit-fpu.c: Regenerate.
6854 * features/riscv/32bit-fpu.xml: Add register numbers.
6855 * features/riscv/64bit-cpu.xml: Add register numbers.
6856 * features/riscv/64bit-fpu.c: Regenerate.
6857 * features/riscv/64bit-fpu.xml: Add register numbers.
6858
6859 2019-02-26 Kevin Buettner <kevinb@redhat.com>
6860
6861 * NEWS: Mention two argument form of gdb.Value constructor.
6862 * python/py-value.c (convert_buffer_and_type_to_value): New
6863 function.
6864 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6865 Add support for handling an optional second argument. Call
6866 convert_buffer_and_type_to_value as appropriate.
6867 * python/python-internal.h (Py_buffer_deleter): New struct.
6868 (Py_buffer_up): New typedef.
6869
6870 2019-02-25 John Baldwin <jhb@FreeBSD.org>
6871
6872 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6873 instead of releasing ownership.
6874
6875 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
6876
6877 * dwarf2read.c (open_and_init_dwp_file): Call
6878 elf_numsections instead of bfd_count_sections to initialize
6879 dwp_file->num_sections.
6880
6881 2019-02-25 Tom Tromey <tromey@adacore.com>
6882
6883 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6884
6885 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
6886
6887 * gcore.in: Add '--readnever' option when invoking GDB.
6888
6889 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
6890
6891 * MAINTAINERS: Update my email address.
6892
6893 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
6894
6895 * build-id.c (build_id_to_debug_bfd_1): New function.
6896 (build_id_to_debug_bfd): Look for separate debug file in
6897 sysroot.
6898
6899 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
6900
6901 * gdbarch.sh: Update the copyright year range that is placed into
6902 generated files.
6903
6904 2019-02-22 Keith Seitz <keiths@redhat.com>
6905
6906 PR symtab/23853
6907 * linespec.c (create_sals_line_offset): Search for the default
6908 symtab's filename instead of its fullname.
6909
6910 2019-02-21 Alan Hayward <alan.hayward@arm.com>
6911
6912 * NEWS: Update style defaults.
6913
6914 2019-02-21 Alan Hayward <alan.hayward@arm.com>
6915
6916 * main.c (captured_main_1): Disable styling in batch mode.
6917
6918 2019-02-20 Tom Tromey <tom@tromey.com>
6919
6920 * symtab.c (symtab_symbol_info): Fix typos.
6921
6922 2019-02-20 Tom Tromey <tromey@adacore.com>
6923
6924 * findcmd.c (_initialize_mem_search): Use upper case for
6925 metasyntactic variables.
6926
6927 2019-02-20 Alan Hayward <alan.hayward@arm.com>
6928
6929 * aarch64-tdep.c (aarch64_add_reggroups): New function.
6930 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6931
6932 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
6933
6934 * top.h (source_file_name): Change to std::string.
6935 * top.c (source_file_name): Likewise.
6936 (command_line_input): Adjust.
6937 * cli/cli-script.c (script_from_file): Adjust.
6938
6939 2019-02-19 Tom Tromey <tromey@adacore.com>
6940
6941 * ravenscar-thread.c
6942 (ravenscar_thread_target::update_thread_list): Don't call
6943 ada_build_task_list.
6944 * ada-lang.h (ada_build_task_list): Don't declare.
6945 * ada-tasks.c (struct ada_tasks_inferior_data)
6946 <task_list_valid_p>: Now bool.
6947 (read_known_tasks, ada_task_list_changed)
6948 (ada_tasks_invalidate_inferior_data): Update.
6949 (read_known_tasks_array): Return bool.
6950 (read_known_tasks_list): Likewise.
6951 (read_known_tasks): Return void.
6952 (ada_build_task_list): Now static.
6953
6954 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
6955
6956 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6957 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6958
6959 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6960
6961 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6962 variant for ada_tasks_pspace_data_handle and
6963 ada_tasks_inferior_data_handle.
6964 (ada_tasks_pspace_data_cleanup): New function.
6965 (ada_tasks_inferior_data_cleanup): New function.
6966
6967 2019-02-17 Tom Tromey <tom@tromey.com>
6968
6969 * macrotab.h (macro_source_fullname): Return a std::string.
6970 * macrotab.c (macro_include, check_for_redefinition)
6971 (macro_undef, macro_lookup_definition, foreach_macro)
6972 (foreach_macro_in_scope): Update.
6973 (macro_source_fullname): Return a std::string.
6974 * macrocmd.c (show_pp_source_pos): Update.
6975
6976 2019-02-17 Tom Tromey <tom@tromey.com>
6977
6978 * macrocmd.c (show_pp_source_pos): Style the file names.
6979
6980 2019-02-17 Tom Tromey <tom@tromey.com>
6981
6982 PR tui/24197:
6983 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6984
6985 2019-02-17 Tom Tromey <tom@tromey.com>
6986
6987 * ada-lang.c (user_select_syms): Use filtered printing.
6988 * utils.c (wrap_style): New global.
6989 (desired_style): Remove.
6990 (emit_style_escape): Add stream parameter.
6991 (set_output_style, reset_terminal_style, prompt_for_continue):
6992 Update.
6993 (flush_wrap_buffer): Only flush gdb_stdout.
6994 (wrap_here): Set wrap_style.
6995 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
6996 treat escape sequences as a character. Change when wrap buffer is
6997 flushed.
6998 (fputs_styled): Do not set the output style when the default is
6999 requested.
7000 * ui-style.h (struct ui_file_style) <is_default>: New method.
7001 * source.c (print_source_lines_base): Emit escape sequences in one
7002 piece.
7003
7004 2019-02-17 Joel Brobecker <brobecker@adacore.com>
7005
7006 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7007 integers and enumeration types.
7008
7009 2019-02-17 Joel Brobecker <brobecker@adacore.com>
7010
7011 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7012 instead of lookup_symbol_in_language
7013 (do_exact_match): New function.
7014 (ada_get_symbol_name_matcher): Return do_exact_match when
7015 doing a verbatim match.
7016
7017 2019-02-15 Tom Tromey <tromey@adacore.com>
7018
7019 * ravenscar-thread.c (ravenscar_thread_target::resume)
7020 (ravenscar_thread_target::wait): Special case wildcard requests.
7021
7022 2019-02-15 Tom Tromey <tromey@adacore.com>
7023
7024 * ravenscar-thread.c (base_ptid): Remove.
7025 (struct ravenscar_thread_target) <close>: New method.
7026 <m_base_ptid>: New member.
7027 <update_inferior_ptid, active_task, task_is_currently_active,
7028 runtime_initialized>: Declare methods.
7029 <ravenscar_thread_target>: Add constructor.
7030 (ravenscar_thread_target::task_is_currently_active)
7031 (ravenscar_thread_target::update_inferior_ptid)
7032 (ravenscar_runtime_initialized): Rename. Now methods.
7033 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7034 (ravenscar_thread_target::update_thread_list): Update.
7035 (ravenscar_thread_target::active_task): Now method.
7036 (ravenscar_thread_target::store_registers)
7037 (ravenscar_thread_target::prepare_to_store)
7038 (ravenscar_thread_target::prepare_to_store)
7039 (ravenscar_thread_target::mourn_inferior): Update.
7040 (ravenscar_inferior_created): Use "new" to create target.
7041 (ravenscar_thread_target::get_ada_task_ptid): Update.
7042 (_initialize_ravenscar): Don't initialize base_ptid.
7043 (ravenscar_ops): Remove global.
7044
7045 2019-02-15 Tom Tromey <tromey@adacore.com>
7046
7047 * target.h (push_target): Declare new overload.
7048 * target.c (push_target): New overload, taking an rvalue reference.
7049 * remote.c (remote_target::open_1): Use push_target overload.
7050 * corelow.c (core_target_open): Use push_target overload.
7051
7052 2019-02-15 Tom Tromey <tromey@adacore.com>
7053
7054 * ravenscar-thread.c (is_ravenscar_task)
7055 (ravenscar_task_is_currently_active): Return bool.
7056 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7057 (_initialize_ravenscar): Remove "(void)".
7058 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7059 Return bool.
7060
7061 2019-02-15 Tom Tromey <tromey@adacore.com>
7062
7063 * ravenscar-thread.c (ravenscar_runtime_initializer)
7064 (has_ravenscar_runtime, get_running_thread_id)
7065 (ravenscar_thread_target::resume): Fix indentation.
7066
7067 2019-02-15 Tom Tromey <tromey@adacore.com>
7068
7069 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7070 from ravenscar_arch_ops.
7071 (sparc_ravenscar_ops::fetch_registers)
7072 (sparc_ravenscar_ops::store_registers): Now methods.
7073 (sparc_ravenscar_prepare_to_store): Remove.
7074 (sparc_ravenscar_ops): Redefine.
7075 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7076 methods and destructor. Remove members.
7077 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7078 (ravenscar_thread_target::store_registers)
7079 (ravenscar_thread_target::prepare_to_store): Update.
7080 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7081 Remove.
7082 (struct ppc_ravenscar_powerpc_ops): Derive from
7083 ravenscar_arch_ops.
7084 (ppc_ravenscar_powerpc_ops::fetch_registers)
7085 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7086 (ppc_ravenscar_powerpc_ops): Redefine.
7087 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7088 (ppc_ravenscar_e500_ops::fetch_registers)
7089 (ppc_ravenscar_e500_ops::store_registers): Now methods.
7090 (ppc_ravenscar_e500_ops): Redefine.
7091 * aarch64-ravenscar-thread.c
7092 (aarch64_ravenscar_generic_prepare_to_store): Remove.
7093 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7094 (aarch64_ravenscar_fetch_registers)
7095 (aarch64_ravenscar_store_registers): Now methods.
7096 (aarch64_ravenscar_ops): Redefine.
7097
7098 2019-02-15 Tom Tromey <tromey@adacore.com>
7099
7100 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7101 (ravenscar_thread_target::stopped_by_hw_breakpoint)
7102 (ravenscar_thread_target::stopped_by_watchpoint)
7103 (ravenscar_thread_target::stopped_data_address)
7104 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7105
7106 2019-02-15 Tom Tromey <tromey@adacore.com>
7107
7108 * ravenscar-thread.c: Fix some typos.
7109
7110 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7111 Tom Tromey <tromey@adacore.com>
7112
7113 * ada-lang.c (ada_exception_sal): Change addr_string to a
7114 std::string.
7115 (create_ada_exception_catchpoint): Update.
7116
7117 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7118 Tom Tromey <tromey@adacore.com>
7119
7120 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7121 (bp_location_ops): Remove.
7122 (base_breakpoint_allocate_location): Update.
7123 (free_bp_location): Update.
7124 * ada-lang.c (class ada_catchpoint_location)
7125 <ada_catchpoint_location>: Remove ops parameter.
7126 (ada_catchpoint_location_dtor): Remove.
7127 (ada_catchpoint_location_ops): Remove.
7128 (allocate_location_exception): Update.
7129 * breakpoint.h (struct bp_location_ops): Remove.
7130 (class bp_location) <bp_location>: Remove bp_location_ops
7131 parameter.
7132 <~bp_location>: Add destructor.
7133 <ops>: Remove.
7134
7135 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
7136 Pedro Alves <palves@redhat.com>
7137
7138 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7139 'PATH_MAX'.
7140
7141 2019-02-14 David Michael <fedora.dm0@gmail.com>
7142 Samuel Thibault <samuel.thibault@gnu.org>
7143 Thomas Schwinge <thomas@codesourcery.com>
7144
7145 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7146 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7147
7148 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
7149
7150 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7151 (check_empty): Use "const char *".
7152
7153 * gnu-nat.c (gnu_nat_target::detach): Instead of
7154 'detach_inferior (pid)' call
7155 'detach_inferior (find_inferior_pid (pid))'.
7156
7157 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7158 'nat/fork-inferior.o'.
7159 * gnu-nat.c: #include "nat/fork-inferior.h".
7160
7161 * gnu-nat.c (gnu_nat_target::detach): Instead of
7162 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7163 * gnu-nat.h: #include "inf-child.h".
7164 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7165 'i386_gnu_nat_target::fetch_registers'.
7166 (gnu_store_registers): Rename/move to
7167 'i386_gnu_nat_target::store_registers'.
7168
7169 * config/i386/nm-i386gnu.h: Don't "#include" any files.
7170 * gnu-nat.h (mach_thread_info): New function.
7171 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7172
7173 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7174
7175 2019-02-14 Frederic Konrad <konrad@adacore.com>
7176
7177 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7178
7179 2019-02-14 Joel Brobecker <brobecker@adacore.com>
7180
7181 * windows-nat.c (windows_add_thread): Add new parameter
7182 "main_thread_p" with default value set to false. Update
7183 function documentation as well as all callers.
7184 (windows_delete_thread): Likewise.
7185 (fake_create_process): Update call to windows_add_thread.
7186 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7187 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7188 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7189 call to windows_delete_thread.
7190
7191 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
7192
7193 * MAINTAINERS: Add Andrew Burgess as global maintainer.
7194
7195 2019-02-12 John Baldwin <jhb@FreeBSD.org>
7196
7197 * symfile.c (find_separate_debug_file): Use canonical path of
7198 sysroot with child_path instead of gdb_sysroot if it is valid.
7199
7200 2019-02-12 John Baldwin <jhb@FreeBSD.org>
7201
7202 * symfile.c (find_separate_debug_file): Use child_path to
7203 determine if an object file is under a sysroot.
7204
7205 2019-02-12 John Baldwin <jhb@FreeBSD.org>
7206
7207 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7208 unittests/child-path-selftests.c.
7209 * common/pathstuff.c (child_path): New function.
7210 * common/pathstuff.h (child_path): New prototype.
7211 * unittests/child-path-selftests.c: New file.
7212
7213 2019-02-12 John Baldwin <jhb@FreeBSD.org>
7214
7215 * symfile.c (find_separate_debug_file): Look for separate debug
7216 files in debug directories under the sysroot.
7217
7218 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7219
7220 * symtab.h (struct minimal_symbol data_p): New const method.
7221 (struct minimal_symbol text_p): Likewise.
7222 * symtab.c (output_source_filename): Use file name style
7223 to print file name.
7224 (print_symbol_info): Likewise.
7225 (print_msymbol_info): Use address style to print addresses.
7226 Use function name style to print executable text symbols.
7227 (expand_symtab_containing_pc): Use data_p.
7228 (find_pc_sect_compunit_symtab): Likewise.
7229
7230 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7231
7232 * breakpoint.c (describe_other_breakpoints): Use address style
7233 to print addresses.
7234 (say_where): Likewise.
7235
7236 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7237
7238 * ada-typeprint.c (print_func_type): Print function name
7239 style to print function name.
7240 * c-typeprint.c (c_print_type_1): Likewise.
7241
7242 2019-02-11 Alan Hayward <alan.hayward@arm.com>
7243
7244 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7245 for execve.
7246
7247 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7248
7249 * c-exp.y (direct_abs_decl): Use emplace_back to record the
7250 type_stack.
7251
7252 2019-02-10 Joel Brobecker <brobecker@adacore.com>
7253
7254 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7255 TYPE_CODE_REF types.
7256
7257 2019-02-08 Jim Wilson <jimw@sifive.com>
7258
7259 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7260 (riscv_linux_fregset): New.
7261 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7262
7263 2019-02-07 Tom Tromey <tom@tromey.com>
7264
7265 * thread.c (thread_cancel_execution_command): Update.
7266 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7267 methods.
7268 (struct thread_fsm_ops): Remove.
7269 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7270 (thread_fsm_should_stop, thread_fsm_return_value)
7271 (thread_fsm_set_finished, thread_fsm_finished_p)
7272 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7273 Don't declare.
7274 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7275 * infrun.c (clear_proceed_status_thread)
7276 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7277 (print_stop_event): Update.
7278 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7279 Add constructor.
7280 (step_command_fsm_ops): Remove.
7281 (new_step_command_fsm): Remove.
7282 (step_1): Update.
7283 (step_command_fsm::should_stop): Rename from
7284 step_command_fsm_should_stop.
7285 (step_command_fsm::clean_up): Rename from
7286 step_command_fsm_clean_up.
7287 (step_command_fsm::do_async_reply_reason): Rename from
7288 step_command_fsm_async_reply_reason.
7289 (struct until_next_fsm): Inherit from thread_fsm. Add
7290 constructor.
7291 (until_next_fsm_ops): Remove.
7292 (new_until_next_fsm): Remove.
7293 (until_next_fsm::should_stop): Rename from
7294 until_next_fsm_should_stop.
7295 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7296 (until_next_fsm::do_async_reply_reason): Rename from
7297 until_next_fsm_async_reply_reason.
7298 (struct finish_command_fsm): Inherit from thread_fsm. Add
7299 constructor. Change type of breakpoint.
7300 (finish_command_fsm_ops): Remove.
7301 (new_finish_command_fsm): Remove.
7302 (finish_command_fsm::should_stop): Rename from
7303 finish_command_fsm_should_stop.
7304 (finish_command_fsm::clean_up): Rename from
7305 finish_command_fsm_clean_up.
7306 (finish_command_fsm::return_value): Rename from
7307 finish_command_fsm_return_value.
7308 (finish_command_fsm::do_async_reply_reason): Rename from
7309 finish_command_fsm_async_reply_reason.
7310 (finish_command): Update.
7311 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7312 Add constructor.
7313 (call_thread_fsm_ops): Remove.
7314 (call_thread_fsm::call_thread_fsm): Rename from
7315 new_call_thread_fsm.
7316 (call_thread_fsm::should_stop): Rename from
7317 call_thread_fsm_should_stop.
7318 (call_thread_fsm::should_notify_stop): Rename from
7319 call_thread_fsm_should_notify_stop.
7320 (run_inferior_call, call_function_by_hand_dummy): Update.
7321 * cli/cli-interp.c (should_print_stop_to_console): Update.
7322 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7323 Add constructor. Change type of location_breakpoint,
7324 caller_breakpoint.
7325 (until_break_fsm_ops): Remove.
7326 (new_until_break_fsm): Remove.
7327 (until_break_fsm::should_stop): Rename from
7328 until_break_fsm_should_stop.
7329 (until_break_fsm::clean_up): Rename from
7330 until_break_fsm_clean_up.
7331 (until_break_fsm::do_async_reply_reason): Rename from
7332 until_break_fsm_async_reply_reason.
7333 (until_break_command): Update.
7334 * thread-fsm.c: Remove.
7335 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7336
7337 2019-02-07 Tom Tromey <tom@tromey.com>
7338
7339 * yy-remap.h: Add include guard.
7340 * xtensa-tdep.h: Add include guard.
7341 * xcoffread.h: Rename include guard.
7342 * varobj-iter.h: Add include guard.
7343 * tui/tui.h: Rename include guard.
7344 * tui/tui-winsource.h: Rename include guard.
7345 * tui/tui-wingeneral.h: Rename include guard.
7346 * tui/tui-windata.h: Rename include guard.
7347 * tui/tui-win.h: Rename include guard.
7348 * tui/tui-stack.h: Rename include guard.
7349 * tui/tui-source.h: Rename include guard.
7350 * tui/tui-regs.h: Rename include guard.
7351 * tui/tui-out.h: Rename include guard.
7352 * tui/tui-layout.h: Rename include guard.
7353 * tui/tui-io.h: Rename include guard.
7354 * tui/tui-hooks.h: Rename include guard.
7355 * tui/tui-file.h: Rename include guard.
7356 * tui/tui-disasm.h: Rename include guard.
7357 * tui/tui-data.h: Rename include guard.
7358 * tui/tui-command.h: Rename include guard.
7359 * tic6x-tdep.h: Add include guard.
7360 * target/waitstatus.h: Rename include guard.
7361 * target/wait.h: Rename include guard.
7362 * target/target.h: Rename include guard.
7363 * target/resume.h: Rename include guard.
7364 * target-float.h: Rename include guard.
7365 * stabsread.h: Add include guard.
7366 * rs6000-tdep.h: Add include guard.
7367 * riscv-fbsd-tdep.h: Add include guard.
7368 * regformats/regdef.h: Rename include guard.
7369 * record.h: Rename include guard.
7370 * python/python.h: Rename include guard.
7371 * python/python-internal.h: Rename include guard.
7372 * python/py-stopevent.h: Rename include guard.
7373 * python/py-ref.h: Rename include guard.
7374 * python/py-record.h: Rename include guard.
7375 * python/py-record-full.h: Rename include guard.
7376 * python/py-record-btrace.h: Rename include guard.
7377 * python/py-instruction.h: Rename include guard.
7378 * python/py-events.h: Rename include guard.
7379 * python/py-event.h: Rename include guard.
7380 * procfs.h: Add include guard.
7381 * proc-utils.h: Add include guard.
7382 * p-lang.h: Add include guard.
7383 * or1k-tdep.h: Rename include guard.
7384 * observable.h: Rename include guard.
7385 * nto-tdep.h: Rename include guard.
7386 * nat/x86-linux.h: Rename include guard.
7387 * nat/x86-linux-dregs.h: Rename include guard.
7388 * nat/x86-gcc-cpuid.h: Add include guard.
7389 * nat/x86-dregs.h: Rename include guard.
7390 * nat/x86-cpuid.h: Rename include guard.
7391 * nat/ppc-linux.h: Rename include guard.
7392 * nat/mips-linux-watch.h: Rename include guard.
7393 * nat/linux-waitpid.h: Rename include guard.
7394 * nat/linux-ptrace.h: Rename include guard.
7395 * nat/linux-procfs.h: Rename include guard.
7396 * nat/linux-osdata.h: Rename include guard.
7397 * nat/linux-nat.h: Rename include guard.
7398 * nat/linux-namespaces.h: Rename include guard.
7399 * nat/linux-btrace.h: Rename include guard.
7400 * nat/glibc_thread_db.h: Rename include guard.
7401 * nat/gdb_thread_db.h: Rename include guard.
7402 * nat/gdb_ptrace.h: Rename include guard.
7403 * nat/fork-inferior.h: Rename include guard.
7404 * nat/amd64-linux-siginfo.h: Rename include guard.
7405 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7406 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7407 * nat/aarch64-linux.h: Rename include guard.
7408 * nat/aarch64-linux-hw-point.h: Rename include guard.
7409 * mn10300-tdep.h: Add include guard.
7410 * mips-linux-tdep.h: Add include guard.
7411 * mi/mi-parse.h: Rename include guard.
7412 * mi/mi-out.h: Rename include guard.
7413 * mi/mi-main.h: Rename include guard.
7414 * mi/mi-interp.h: Rename include guard.
7415 * mi/mi-getopt.h: Rename include guard.
7416 * mi/mi-console.h: Rename include guard.
7417 * mi/mi-common.h: Rename include guard.
7418 * mi/mi-cmds.h: Rename include guard.
7419 * mi/mi-cmd-break.h: Rename include guard.
7420 * m2-lang.h: Add include guard.
7421 * location.h: Rename include guard.
7422 * linux-record.h: Rename include guard.
7423 * linux-nat.h: Add include guard.
7424 * linux-fork.h: Add include guard.
7425 * i386-darwin-tdep.h: Rename include guard.
7426 * hppa-linux-offsets.h: Add include guard.
7427 * guile/guile.h: Rename include guard.
7428 * guile/guile-internal.h: Rename include guard.
7429 * gnu-nat.h: Rename include guard.
7430 * gdb-stabs.h: Rename include guard.
7431 * frv-tdep.h: Add include guard.
7432 * f-lang.h: Add include guard.
7433 * event-loop.h: Add include guard.
7434 * darwin-nat.h: Rename include guard.
7435 * cp-abi.h: Rename include guard.
7436 * config/sparc/nm-sol2.h: Rename include guard.
7437 * config/nm-nto.h: Rename include guard.
7438 * config/nm-linux.h: Add include guard.
7439 * config/i386/nm-i386gnu.h: Rename include guard.
7440 * config/djgpp/nl_types.h: Rename include guard.
7441 * config/djgpp/langinfo.h: Rename include guard.
7442 * compile/gcc-cp-plugin.h: Add include guard.
7443 * compile/gcc-c-plugin.h: Add include guard.
7444 * compile/compile.h: Rename include guard.
7445 * compile/compile-object-run.h: Rename include guard.
7446 * compile/compile-object-load.h: Rename include guard.
7447 * compile/compile-internal.h: Rename include guard.
7448 * compile/compile-cplus.h: Rename include guard.
7449 * compile/compile-c.h: Rename include guard.
7450 * common/xml-utils.h: Rename include guard.
7451 * common/x86-xstate.h: Rename include guard.
7452 * common/version.h: Rename include guard.
7453 * common/vec.h: Rename include guard.
7454 * common/tdesc.h: Rename include guard.
7455 * common/selftest.h: Rename include guard.
7456 * common/scoped_restore.h: Rename include guard.
7457 * common/scoped_mmap.h: Rename include guard.
7458 * common/scoped_fd.h: Rename include guard.
7459 * common/safe-iterator.h: Rename include guard.
7460 * common/run-time-clock.h: Rename include guard.
7461 * common/refcounted-object.h: Rename include guard.
7462 * common/queue.h: Rename include guard.
7463 * common/ptid.h: Rename include guard.
7464 * common/print-utils.h: Rename include guard.
7465 * common/preprocessor.h: Rename include guard.
7466 * common/pathstuff.h: Rename include guard.
7467 * common/observable.h: Rename include guard.
7468 * common/netstuff.h: Rename include guard.
7469 * common/job-control.h: Rename include guard.
7470 * common/host-defs.h: Rename include guard.
7471 * common/gdb_wait.h: Rename include guard.
7472 * common/gdb_vecs.h: Rename include guard.
7473 * common/gdb_unlinker.h: Rename include guard.
7474 * common/gdb_unique_ptr.h: Rename include guard.
7475 * common/gdb_tilde_expand.h: Rename include guard.
7476 * common/gdb_sys_time.h: Rename include guard.
7477 * common/gdb_string_view.h: Rename include guard.
7478 * common/gdb_splay_tree.h: Rename include guard.
7479 * common/gdb_setjmp.h: Rename include guard.
7480 * common/gdb_ref_ptr.h: Rename include guard.
7481 * common/gdb_optional.h: Rename include guard.
7482 * common/gdb_locale.h: Rename include guard.
7483 * common/gdb_assert.h: Rename include guard.
7484 * common/filtered-iterator.h: Rename include guard.
7485 * common/filestuff.h: Rename include guard.
7486 * common/fileio.h: Rename include guard.
7487 * common/environ.h: Rename include guard.
7488 * common/common-utils.h: Rename include guard.
7489 * common/common-types.h: Rename include guard.
7490 * common/common-regcache.h: Rename include guard.
7491 * common/common-inferior.h: Rename include guard.
7492 * common/common-gdbthread.h: Rename include guard.
7493 * common/common-exceptions.h: Rename include guard.
7494 * common/common-defs.h: Rename include guard.
7495 * common/common-debug.h: Rename include guard.
7496 * common/cleanups.h: Rename include guard.
7497 * common/buffer.h: Rename include guard.
7498 * common/btrace-common.h: Rename include guard.
7499 * common/break-common.h: Rename include guard.
7500 * cli/cli-utils.h: Rename include guard.
7501 * cli/cli-style.h: Rename include guard.
7502 * cli/cli-setshow.h: Rename include guard.
7503 * cli/cli-script.h: Rename include guard.
7504 * cli/cli-interp.h: Rename include guard.
7505 * cli/cli-decode.h: Rename include guard.
7506 * cli/cli-cmds.h: Rename include guard.
7507 * charset-list.h: Add include guard.
7508 * buildsym-legacy.h: Rename include guard.
7509 * bfin-tdep.h: Add include guard.
7510 * ax.h: Rename include guard.
7511 * arm-linux-tdep.h: Add include guard.
7512 * arm-fbsd-tdep.h: Add include guard.
7513 * arch/xtensa.h: Rename include guard.
7514 * arch/tic6x.h: Add include guard.
7515 * arch/i386.h: Add include guard.
7516 * arch/arm.h: Rename include guard.
7517 * arch/arm-linux.h: Rename include guard.
7518 * arch/arm-get-next-pcs.h: Rename include guard.
7519 * arch/amd64.h: Add include guard.
7520 * arch/aarch64-insn.h: Rename include guard.
7521 * arch-utils.h: Rename include guard.
7522 * annotate.h: Add include guard.
7523 * amd64-darwin-tdep.h: Rename include guard.
7524 * aarch64-linux-tdep.h: Add include guard.
7525 * aarch64-fbsd-tdep.h: Add include guard.
7526 * aarch32-linux-nat.h: Add include guard.
7527
7528 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7529
7530 * macrotab.c (macro_define_internal): New function that
7531 factorizes macro_define_object_internal and macro_define_function
7532 code.
7533 (macro_define_object_internal): Use macro_define_internal.
7534 (macro_define_function): Likewise.
7535
7536 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7537
7538 * macrocmd.c (extract_identifier): Return
7539 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7540 callers.
7541
7542 2019-02-06 John Baldwin <jhb@FreeBSD.org>
7543
7544 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7545
7546 2019-02-05 Tom Tromey <tom@tromey.com>
7547
7548 * target.c (target_stack::unpush): Move assertion earlier.
7549
7550 2019-01-30 Tom Tromey <tom@tromey.com>
7551
7552 PR python/23615:
7553 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7554 (gdbpy_parse_and_eval): Likewise.
7555 * python/python-internal.h (gdbpy_allow_threads): New class.
7556
7557 2019-01-28 John Baldwin <jhb@FreeBSD.org>
7558
7559 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7560 (aarch64_fbsd_fpregmap): Move earlier.
7561 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7562 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7563 instead of individual calls to trad_frame_set_reg_addr.
7564 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7565 earlier.
7566 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7567 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7568 instead of individual calls to trad_frame_set_reg_addr.
7569
7570 2019-01-28 Alan Hayward <alan.hayward@arm.com>
7571
7572 * CONTRIBUTE: Replace contribution list with wiki link.
7573
7574 2019-01-25 Tom Tromey <tom@tromey.com>
7575
7576 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7577
7578 2019-01-25 Tom Tromey <tom@tromey.com>
7579
7580 * xtensa-linux-nat.c: Fix common/ includes.
7581 * xml-support.h: Fix common/ includes.
7582 * xml-support.c: Fix common/ includes.
7583 * x86-linux-nat.c: Fix common/ includes.
7584 * windows-nat.c: Fix common/ includes.
7585 * varobj.h: Fix common/ includes.
7586 * varobj.c: Fix common/ includes.
7587 * value.c: Fix common/ includes.
7588 * valops.c: Fix common/ includes.
7589 * utils.c: Fix common/ includes.
7590 * unittests/xml-utils-selftests.c: Fix common/ includes.
7591 * unittests/utils-selftests.c: Fix common/ includes.
7592 * unittests/unpack-selftests.c: Fix common/ includes.
7593 * unittests/tracepoint-selftests.c: Fix common/ includes.
7594 * unittests/style-selftests.c: Fix common/ includes.
7595 * unittests/string_view-selftests.c: Fix common/ includes.
7596 * unittests/scoped_restore-selftests.c: Fix common/ includes.
7597 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7598 * unittests/scoped_fd-selftests.c: Fix common/ includes.
7599 * unittests/rsp-low-selftests.c: Fix common/ includes.
7600 * unittests/parse-connection-spec-selftests.c: Fix common/
7601 includes.
7602 * unittests/optional-selftests.c: Fix common/ includes.
7603 * unittests/offset-type-selftests.c: Fix common/ includes.
7604 * unittests/observable-selftests.c: Fix common/ includes.
7605 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7606 * unittests/memrange-selftests.c: Fix common/ includes.
7607 * unittests/memory-map-selftests.c: Fix common/ includes.
7608 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7609 * unittests/function-view-selftests.c: Fix common/ includes.
7610 * unittests/environ-selftests.c: Fix common/ includes.
7611 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7612 * unittests/common-utils-selftests.c: Fix common/ includes.
7613 * unittests/cli-utils-selftests.c: Fix common/ includes.
7614 * unittests/array-view-selftests.c: Fix common/ includes.
7615 * ui-file.c: Fix common/ includes.
7616 * tui/tui-io.c: Fix common/ includes.
7617 * tracepoint.h: Fix common/ includes.
7618 * tracepoint.c: Fix common/ includes.
7619 * tracefile-tfile.c: Fix common/ includes.
7620 * top.h: Fix common/ includes.
7621 * top.c: Fix common/ includes.
7622 * thread.c: Fix common/ includes.
7623 * target/waitstatus.h: Fix common/ includes.
7624 * target/waitstatus.c: Fix common/ includes.
7625 * target.h: Fix common/ includes.
7626 * target.c: Fix common/ includes.
7627 * target-memory.c: Fix common/ includes.
7628 * target-descriptions.c: Fix common/ includes.
7629 * symtab.h: Fix common/ includes.
7630 * symfile.c: Fix common/ includes.
7631 * stap-probe.c: Fix common/ includes.
7632 * spu-linux-nat.c: Fix common/ includes.
7633 * sparc-nat.c: Fix common/ includes.
7634 * source.c: Fix common/ includes.
7635 * solib.c: Fix common/ includes.
7636 * solib-target.c: Fix common/ includes.
7637 * ser-unix.c: Fix common/ includes.
7638 * ser-tcp.c: Fix common/ includes.
7639 * ser-pipe.c: Fix common/ includes.
7640 * ser-base.c: Fix common/ includes.
7641 * selftest-arch.c: Fix common/ includes.
7642 * s12z-tdep.c: Fix common/ includes.
7643 * rust-exp.y: Fix common/ includes.
7644 * rs6000-aix-tdep.c: Fix common/ includes.
7645 * riscv-tdep.c: Fix common/ includes.
7646 * remote.c: Fix common/ includes.
7647 * remote-notif.h: Fix common/ includes.
7648 * remote-fileio.h: Fix common/ includes.
7649 * remote-fileio.c: Fix common/ includes.
7650 * regcache.h: Fix common/ includes.
7651 * regcache.c: Fix common/ includes.
7652 * record-btrace.c: Fix common/ includes.
7653 * python/python.c: Fix common/ includes.
7654 * python/py-type.c: Fix common/ includes.
7655 * python/py-inferior.c: Fix common/ includes.
7656 * progspace.h: Fix common/ includes.
7657 * producer.c: Fix common/ includes.
7658 * procfs.c: Fix common/ includes.
7659 * proc-api.c: Fix common/ includes.
7660 * printcmd.c: Fix common/ includes.
7661 * ppc-linux-nat.c: Fix common/ includes.
7662 * parser-defs.h: Fix common/ includes.
7663 * osdata.c: Fix common/ includes.
7664 * obsd-nat.c: Fix common/ includes.
7665 * nat/x86-linux.c: Fix common/ includes.
7666 * nat/x86-linux-dregs.c: Fix common/ includes.
7667 * nat/x86-dregs.h: Fix common/ includes.
7668 * nat/x86-dregs.c: Fix common/ includes.
7669 * nat/ppc-linux.c: Fix common/ includes.
7670 * nat/mips-linux-watch.h: Fix common/ includes.
7671 * nat/mips-linux-watch.c: Fix common/ includes.
7672 * nat/linux-waitpid.c: Fix common/ includes.
7673 * nat/linux-ptrace.h: Fix common/ includes.
7674 * nat/linux-ptrace.c: Fix common/ includes.
7675 * nat/linux-procfs.c: Fix common/ includes.
7676 * nat/linux-personality.c: Fix common/ includes.
7677 * nat/linux-osdata.c: Fix common/ includes.
7678 * nat/linux-namespaces.c: Fix common/ includes.
7679 * nat/linux-btrace.h: Fix common/ includes.
7680 * nat/linux-btrace.c: Fix common/ includes.
7681 * nat/fork-inferior.c: Fix common/ includes.
7682 * nat/amd64-linux-siginfo.c: Fix common/ includes.
7683 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7684 * nat/aarch64-linux.c: Fix common/ includes.
7685 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7686 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7687 * namespace.h: Fix common/ includes.
7688 * mips-linux-tdep.c: Fix common/ includes.
7689 * minsyms.c: Fix common/ includes.
7690 * mi/mi-parse.h: Fix common/ includes.
7691 * mi/mi-main.c: Fix common/ includes.
7692 * mi/mi-cmd-env.c: Fix common/ includes.
7693 * memrange.h: Fix common/ includes.
7694 * memattr.c: Fix common/ includes.
7695 * maint.h: Fix common/ includes.
7696 * maint.c: Fix common/ includes.
7697 * main.c: Fix common/ includes.
7698 * machoread.c: Fix common/ includes.
7699 * location.c: Fix common/ includes.
7700 * linux-thread-db.c: Fix common/ includes.
7701 * linux-nat.c: Fix common/ includes.
7702 * linux-fork.c: Fix common/ includes.
7703 * inline-frame.c: Fix common/ includes.
7704 * infrun.c: Fix common/ includes.
7705 * inflow.c: Fix common/ includes.
7706 * inferior.h: Fix common/ includes.
7707 * inferior.c: Fix common/ includes.
7708 * infcmd.c: Fix common/ includes.
7709 * inf-ptrace.c: Fix common/ includes.
7710 * inf-child.c: Fix common/ includes.
7711 * ia64-linux-nat.c: Fix common/ includes.
7712 * i387-tdep.c: Fix common/ includes.
7713 * i386-tdep.c: Fix common/ includes.
7714 * i386-linux-tdep.c: Fix common/ includes.
7715 * i386-linux-nat.c: Fix common/ includes.
7716 * i386-go32-tdep.c: Fix common/ includes.
7717 * i386-fbsd-tdep.c: Fix common/ includes.
7718 * i386-fbsd-nat.c: Fix common/ includes.
7719 * guile/scm-type.c: Fix common/ includes.
7720 * guile/guile.c: Fix common/ includes.
7721 * go32-nat.c: Fix common/ includes.
7722 * gnu-nat.c: Fix common/ includes.
7723 * gdbthread.h: Fix common/ includes.
7724 * gdbarch-selftests.c: Fix common/ includes.
7725 * gdb_usleep.c: Fix common/ includes.
7726 * gdb_select.h: Fix common/ includes.
7727 * gdb_bfd.c: Fix common/ includes.
7728 * gcore.c: Fix common/ includes.
7729 * fork-child.c: Fix common/ includes.
7730 * findvar.c: Fix common/ includes.
7731 * fbsd-nat.c: Fix common/ includes.
7732 * event-top.c: Fix common/ includes.
7733 * event-loop.c: Fix common/ includes.
7734 * dwarf2read.c: Fix common/ includes.
7735 * dwarf2loc.c: Fix common/ includes.
7736 * dwarf2-frame.c: Fix common/ includes.
7737 * dwarf-index-cache.c: Fix common/ includes.
7738 * dtrace-probe.c: Fix common/ includes.
7739 * disasm-selftests.c: Fix common/ includes.
7740 * defs.h: Fix common/ includes.
7741 * csky-tdep.c: Fix common/ includes.
7742 * cp-valprint.c: Fix common/ includes.
7743 * cp-support.h: Fix common/ includes.
7744 * cp-support.c: Fix common/ includes.
7745 * corelow.c: Fix common/ includes.
7746 * completer.h: Fix common/ includes.
7747 * completer.c: Fix common/ includes.
7748 * compile/compile.c: Fix common/ includes.
7749 * compile/compile-loc2c.c: Fix common/ includes.
7750 * compile/compile-cplus-types.c: Fix common/ includes.
7751 * compile/compile-cplus-symbols.c: Fix common/ includes.
7752 * command.h: Fix common/ includes.
7753 * cli/cli-dump.c: Fix common/ includes.
7754 * cli/cli-cmds.c: Fix common/ includes.
7755 * charset.c: Fix common/ includes.
7756 * build-id.c: Fix common/ includes.
7757 * btrace.h: Fix common/ includes.
7758 * btrace.c: Fix common/ includes.
7759 * breakpoint.h: Fix common/ includes.
7760 * breakpoint.c: Fix common/ includes.
7761 * ax.h:
7762 (enum agent_op): Fix common/ includes.
7763 * ax-general.c (struct aop_map): Fix common/ includes.
7764 * ax-gdb.c: Fix common/ includes.
7765 * auxv.c: Fix common/ includes.
7766 * auto-load.c: Fix common/ includes.
7767 * arm-tdep.c: Fix common/ includes.
7768 * arch/riscv.c: Fix common/ includes.
7769 * arch/ppc-linux-common.c: Fix common/ includes.
7770 * arch/i386.c: Fix common/ includes.
7771 * arch/arm.c: Fix common/ includes.
7772 * arch/arm-linux.c: Fix common/ includes.
7773 * arch/arm-get-next-pcs.c: Fix common/ includes.
7774 * arch/amd64.c: Fix common/ includes.
7775 * arch/aarch64.c: Fix common/ includes.
7776 * arch/aarch64-insn.c: Fix common/ includes.
7777 * arch-utils.c: Fix common/ includes.
7778 * amd64-windows-tdep.c: Fix common/ includes.
7779 * amd64-tdep.c: Fix common/ includes.
7780 * amd64-sol2-tdep.c: Fix common/ includes.
7781 * amd64-obsd-tdep.c: Fix common/ includes.
7782 * amd64-nbsd-tdep.c: Fix common/ includes.
7783 * amd64-linux-tdep.c: Fix common/ includes.
7784 * amd64-linux-nat.c: Fix common/ includes.
7785 * amd64-fbsd-tdep.c: Fix common/ includes.
7786 * amd64-fbsd-nat.c: Fix common/ includes.
7787 * amd64-dicos-tdep.c: Fix common/ includes.
7788 * amd64-darwin-tdep.c: Fix common/ includes.
7789 * agent.c: Fix common/ includes.
7790 * ada-lang.h: Fix common/ includes.
7791 * ada-lang.c: Fix common/ includes.
7792 * aarch64-tdep.c: Fix common/ includes.
7793
7794 2019-01-25 Tom Tromey <tom@tromey.com>
7795
7796 * common/create-version.sh: Use common/version.h.
7797
7798 2019-01-24 Pedro Alves <palves@redhat.com>
7799
7800 * infrun.c (signal_stop, signal_print, signal_program)
7801 (signal_catch, signal_pass): Now arrays instead of pointers.
7802 (update_signals_program_target, do_target_resume)
7803 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7804 * linux-nat.c (linux_nat_target::pass_signals)
7805 (linux_nat_target::create_inferior, linux_nat_target::attach):
7806 Adjust.
7807 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7808 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7809 * procfs.c (procfs_target::pass_signals): Adjust.
7810 * record-full.c (record_full_target::resume): Adjust.
7811 * remote.c (remote_target::pass_signals)
7812 (remote_target::program_signals): Adjust.
7813 * target-debug.h (target_debug_print_signals): Now takes a
7814 gdb::array_view as parameter. Adjust.
7815 * target.h (target_ops) <pass_signals, program_signals>: Replace
7816 pointer and length parameters with gdb::array_view.
7817 (target_pass_signals, target_program_signals): Likewise.
7818 * target-delegates.c: Regenerate.
7819
7820 2019-01-24 Pedro Alves <palves@redhat.com>
7821
7822 * common/forward-scope-exit.h
7823 (forward_scope_exit::forward_scope_exit): Pass arguments to
7824 m_bind_function directly, instead of creating a std::bind and
7825 copying that.
7826
7827 2019-01-24 Alan Hayward <alan.hayward@arm.com>
7828
7829 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7830 for static members.
7831 (pass_in_v_vfp_candidate): Likewise.
7832
7833 2019-01-23 Tom Tromey <tom@tromey.com>
7834 Pedro Alves <palves@redhat.com>
7835
7836 * regcache.c (class regcache_invalidator): Remove.
7837 (regcache::raw_write): Use make_scope_exit.
7838
7839 2019-01-23 Tom Tromey <tom@tromey.com>
7840
7841 * ui-out.h (class ui_out_emit_type): Update comment.
7842
7843 2019-01-23 Tom Tromey <tom@tromey.com>
7844
7845 * infrun.c (fetch_inferior_event): Update comment.
7846
7847 2019-01-23 Tom Tromey <tom@tromey.com>
7848 Pedro Alves <palves@redhat.com>
7849
7850 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7851 parameter.
7852 (fetch_inferior_event): Use SCOPE_EXIT.
7853
7854
7855 2019-01-23 Tom Tromey <tom@tromey.com>
7856 Pedro Alves <palves@redhat.com>
7857
7858 * infrun.c (disable_thread_events): Delete.
7859 (stop_all_threads): Use SCOPE_EXIT.
7860
7861 2019-01-23 Tom Tromey <tom@tromey.com>
7862 Pedro Alves <palves@redhat.com>
7863
7864 * symfile.c: Include forward-scope-exit.h.
7865 (clear_symtab_users_cleanup): Replace forward declaration with
7866 a FORWARD_SCOPE_EXIT.
7867 (syms_from_objfile_1): Use the forward_scope_exit and
7868 gdb::optional instead of cleanup_function.
7869 (reread_symbols): Use the forward_scope_exit instead of
7870 cleanup_function.
7871 (clear_symtab_users_cleanup): Remove function.
7872
7873 2019-01-23 Tom Tromey <tom@tromey.com>
7874 Pedro Alves <palves@redhat.com>
7875
7876 * linux-nat.c: Include scope-exit.h.
7877 (cleanup_target_stop): Remove.
7878 (linux_nat_target::static_tracepoint_markers_by_strid): Use
7879 SCOPE_EXIT.
7880
7881 2019-01-23 Tom Tromey <tom@tromey.com>
7882 Pedro Alves <palves@redhat.com>
7883
7884 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7885 (call_function_by_hand_dummy): Use SCOPE_EXIT.
7886
7887 2019-01-23 Tom Tromey <tom@tromey.com>
7888 Andrew Burgess <andrew.burgess@embecosm.com>
7889 Pedro Alves <palves@redhat.com>
7890
7891 * infrun.c (fetch_inferior_event): Use scope_exit.
7892 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7893 * top.c (execute_command): Use scope_exit.
7894 * breakpoint.c (bpstat_do_actions): Use scope_exit.
7895 * utils.c (do_bpstat_clear_actions_cleanup)
7896 (make_bpstat_clear_actions_cleanup): Remove.
7897
7898 2019-01-23 Tom Tromey <tom@tromey.com>
7899 Pedro Alves <palves@redhat.com>
7900
7901 * infrun.c: Include "common/scope-exit.h"
7902 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7903 (wait_for_inferior): Use SCOPE_EXIT.
7904 (fetch_inferior_event): Use scope_exit.
7905
7906 2019-01-23 Tom Tromey <tom@tromey.com>
7907 Pedro Alves <palves@redhat.com>
7908
7909 * breakpoint.c (create_breakpoint): Remove cleanup.
7910
7911 2019-01-23 Tom Tromey <tom@tromey.com>
7912 Andrew Burgess <andrew.burgess@embecosm.com>
7913 Pedro Alves <palves@redhat.com>
7914
7915 2019-01-23 Pedro Alves <palves@redhat.com>
7916
7917 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7918
7919 2019-01-23 Pedro Alves <palves@redhat.com>
7920 Andrew Burgess <andrew.burgess@embecosm.com>
7921
7922 * gdbthread.h: Include "common/forward-scope-exit.h".
7923 (scoped_finish_thread_state): Redefine custom class in terms of
7924 forward_scope_exit.
7925
7926 2019-01-23 Pedro Alves <palves@redhat.com>
7927 Andrew Burgess <andrew.burgess@embecosm.com>
7928
7929 * common/forward-scope-exit.h: New file.
7930
7931 2019-01-23 Pedro Alves <palves@redhat.com>
7932 Andrew Burgess <andrew.burgess@embecosm.com>
7933 Tom Tromey <tom@tromey.com>
7934
7935 * common/scope-exit.h: New file.
7936
7937 2019-01-23 Pedro Alves <palves@redhat.com>
7938
7939 * common/preprocessor.h (ESC): Rename to ...
7940 (ESC_PARENS): ... this.
7941 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7942 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7943
7944 2019-01-23 Tom Tromey <tom@tromey.com>
7945
7946 * language.h (class scoped_switch_to_sym_language_if_auto):
7947 Initialize m_lang in both cases.
7948
7949 2019-01-23 Alan Hayward <alan.hayward@arm.com>
7950
7951 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7952 with XCNEW.
7953
7954 2019-01-22 Tom Tromey <tom@tromey.com>
7955
7956 * corelow.c: Do not include sys/file.h.
7957
7958 2019-01-22 Tom Tromey <tom@tromey.com>
7959
7960 * tui/tui-wingeneral.h: Include gdb_curses.h.
7961
7962 2019-01-22 Tom Tromey <tom@tromey.com>
7963
7964 * source-cache.h (class source_cache) <get_source_lines,
7965 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7966
7967 2019-01-22 Tom Tromey <tom@tromey.com>
7968
7969 * remote-fileio.h (struct remote_target): Declare.
7970
7971 2019-01-22 Tom Tromey <tom@tromey.com>
7972
7973 * python/py-arch.c: Do not include py-ref.h.
7974 * python/py-bpevent.c: Do not include py-ref.h.
7975 * python/py-cmd.c: Do not include py-ref.h.
7976 * python/py-continueevent.c: Do not include py-ref.h.
7977 * python/py-event.h: Do not include py-ref.h.
7978 * python/py-evtregistry.c: Do not include py-ref.h.
7979 * python/py-finishbreakpoint.c: Do not include py-ref.h.
7980 * python/py-frame.c: Do not include py-ref.h.
7981 * python/py-framefilter.c: Do not include py-ref.h.
7982 * python/py-function.c: Do not include py-ref.h.
7983 * python/py-infevents.c: Do not include py-ref.h.
7984 * python/py-linetable.c: Do not include py-ref.h.
7985 * python/py-objfile.c: Do not include py-ref.h.
7986 * python/py-param.c: Do not include py-ref.h.
7987 * python/py-prettyprint.c: Do not include py-ref.h.
7988 * python/py-progspace.c: Do not include py-ref.h.
7989 * python/py-symbol.c: Do not include py-ref.h.
7990 * python/py-symtab.c: Do not include py-ref.h.
7991 * python/py-type.c: Do not include py-ref.h.
7992 * python/py-unwind.c: Do not include py-ref.h.
7993 * python/py-utils.c: Do not include py-ref.h.
7994 * python/py-value.c: Do not include py-ref.h.
7995 * python/py-varobj.c: Do not include py-ref.h.
7996 * python/py-xmethods.c: Do not include py-ref.h.
7997 * python/python.c: Do not include py-ref.h.
7998 * varobj.c: Do not include py-ref.h.
7999
8000 2019-01-22 Tom Tromey <tom@tromey.com>
8001
8002 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8003 keyword for bcache.
8004
8005 2019-01-22 Tom Tromey <tom@tromey.com>
8006
8007 * compile/compile-cplus-types.c: Remove a comment by #include.
8008
8009 2019-01-22 Tom Tromey <tom@tromey.com>
8010
8011 * compile/gcc-c-plugin.h: Include compile-internal.h.
8012
8013 2019-01-22 Tom Tromey <tom@tromey.com>
8014
8015 * stabsread.c (EXTERN): Do not define.
8016 (symnum, next_symbol_text_func, processing_gcc_compilation)
8017 (within_function, global_sym_chain, global_stabs)
8018 (previous_stab_code, this_object_header_files)
8019 (n_this_object_header_files)
8020 (n_allocated_this_object_header_files): Define.
8021 * stabsread.h (EXTERN): Never define. Use "extern".
8022
8023 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8024
8025 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8026 history_value.
8027
8028 2019-01-21 Tom Tromey <tom@tromey.com>
8029
8030 * ui-out.c: Fix includes.
8031 * tui/tui-source.c: Fix includes.
8032 * target.c: Fix includes.
8033 * remote.c: Fix includes.
8034 * regcache.c: Fix includes.
8035 * python/py-block.c: Fix includes.
8036 * printcmd.c: Fix includes.
8037 * or1k-tdep.c: Fix includes.
8038 * mi/mi-main.c: Fix includes.
8039 * m32r-tdep.c: Fix includes.
8040 * csky-tdep.c: Fix includes.
8041 * compile/compile-cplus-types.c: Fix includes.
8042 * cli/cli-interp.c: Fix includes.
8043
8044 2019-01-21 Alan Hayward <alan.hayward@arm.com>
8045
8046 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8047 for padding.
8048
8049 2019-01-16 Tom Tromey <tom@tromey.com>
8050
8051 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
8052 earlier.
8053 (struct objfile) <msymbols_range>: Move from top level.
8054 <msymbols>: New method.
8055 (class objfile_msymbols): Remove.
8056 * symtab.c (default_collect_symbol_completion_matches_break_on):
8057 Update.
8058 * symmisc.c (dump_msymbols): Update.
8059 * stabsread.c (scan_file_globals): Update.
8060 * objc-lang.c (info_selectors_command, info_classes_command)
8061 (find_methods): Update.
8062 * minsyms.c (find_solib_trampoline_target): Update.
8063 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8064 * coffread.c (coff_symfile_read): Update.
8065 * ada-lang.c (ada_lookup_simple_minsym)
8066 (ada_collect_symbol_completion_matches): Update.
8067
8068 2019-01-16 Tom Tromey <tom@tromey.com>
8069
8070 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8071 type. Remove no-argument constructor.
8072 <iterator::operator++>: Simplify.
8073 <begin>: Update.
8074 <end>: Use minimal_symbol_count.
8075
8076 2019-01-16 Tom Tromey <tom@tromey.com>
8077
8078 * objfiles.h (struct objfile) <psymtabs>: New method.
8079 (class objfile_psymtabs): Remove.
8080 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8081 typedef.
8082 <range>: New method.
8083 (require_partial_symbols): Change return type.
8084 * psymtab.c (require_partial_symbols)
8085 (psym_expand_symtabs_matching): Update.
8086 * mdebugread.c (parse_partial_symbols): Update.
8087 * dbxread.c (dbx_end_psymtab): Update.
8088
8089 2019-01-15 Tom Tromey <tom@tromey.com>
8090
8091 * symtab.c (lookup_objfile_from_block)
8092 (lookup_symbol_in_objfile_symtabs)
8093 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8094 (find_line_symtab, info_sources_command)
8095 (default_collect_symbol_completion_matches_break_on)
8096 (make_source_files_completion_list): Update.
8097 * symmisc.c (print_objfile_statistics, dump_objfile)
8098 (maintenance_print_symbols, maintenance_info_symtabs)
8099 (maintenance_check_symtabs, maintenance_info_line_tables):
8100 Update.
8101 * source.c (select_source_symtab)
8102 (forget_cached_source_info_for_objfile): Update.
8103 * objfiles.h (class objfile_compunits): Remove.
8104 (struct objfile) <compunits_range>: New typedef.
8105 (compunits): New method.
8106 * objfiles.c (objfile_relocate1): Update.
8107 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8108 * maint.c (count_symtabs_and_blocks): Update.
8109 * linespec.c (iterate_over_all_matching_symtabs): Update.
8110 * cp-support.c (add_symbol_overload_list_qualified): Update.
8111 * coffread.c (coff_symtab_read): Update.
8112 * ada-lang.c (add_nonlocal_symbols)
8113 (ada_collect_symbol_completion_matches)
8114 (ada_add_global_exceptions): Update.
8115
8116 2019-01-15 Tom Tromey <tom@tromey.com>
8117
8118 * progspace.h (program_space) <objfiles_safe_range>: New
8119 typedef.
8120 <objfiles_safe>: New method.
8121 * objfiles.h (class all_objfiles_safe): Remove.
8122 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8123 * jit.c (jit_inferior_exit_hook): Update.
8124
8125 2019-01-17 Tom Tromey <tom@tromey.com>
8126
8127 * progspace.h (program_space) <objfiles_range>: New typedef.
8128 <objfiles>: New method.
8129 <objfiles_head>: Rename from objfiles.
8130 (object_files): Update.
8131 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8132 * guile/scm-pretty-print.c
8133 (ppscm_find_pretty_printer_from_objfiles): Update.
8134 * guile/scm-objfile.c (gdbscm_objfiles): Update.
8135 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8136 Update.
8137 * python/py-progspace.c (pspy_get_objfiles): Update.
8138 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8139 Update.
8140 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8141 (objfpy_lookup_objfile_by_build_id): Update.
8142 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8143 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8144 Update.
8145 * symtab.c (iterate_over_symtabs, matching_obj_sections)
8146 (expand_symtab_containing_pc, lookup_objfile_from_block)
8147 (lookup_static_symbol, basic_lookup_transparent_type)
8148 (find_pc_sect_compunit_symtab, find_symbol_at_address)
8149 (find_line_symtab, info_sources_command)
8150 (default_collect_symbol_completion_matches_break_on)
8151 (make_source_files_completion_list, find_main_name): Update.
8152 * symmisc.c (print_symbol_bcache_statistics)
8153 (print_objfile_statistics, maintenance_print_symbols)
8154 (maintenance_print_msymbols, maintenance_print_objfiles)
8155 (maintenance_info_symtabs, maintenance_check_symtabs)
8156 (maintenance_expand_symtabs, maintenance_info_line_tables):
8157 Update.
8158 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8159 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8160 (map_overlay_command, unmap_overlay_command)
8161 (simple_overlay_update, expand_symtabs_matching)
8162 (map_symbol_filenames): Update.
8163 * symfile-debug.c (set_debug_symfile): Update.
8164 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8165 Update.
8166 * source.c (select_source_symtab, forget_cached_source_info):
8167 Update.
8168 * solib.c (solib_read_symbols): Update.
8169 * solib-spu.c (append_ocl_sos): Update.
8170 * psymtab.c (maintenance_print_psymbols)
8171 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8172 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8173 * printcmd.c (info_symbol_command): Update.
8174 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8175 Update.
8176 * objfiles.h (class all_objfiles): Remove.
8177 * objfiles.c (have_partial_symbols, have_full_symbols)
8178 (have_minimal_symbols, qsort_cmp, update_section_map)
8179 (shared_objfile_contains_address_p)
8180 (default_iterate_over_objfiles_in_search_order): Update.
8181 * objc-lang.c (info_selectors_command, info_classes_command)
8182 (find_methods): Update.
8183 * minsyms.c (find_solib_trampoline_target): Update.
8184 * maint.c (maintenance_info_sections)
8185 (maintenance_translate_address, count_symtabs_and_blocks):
8186 Update.
8187 * main.c (captured_main_1): Update.
8188 * linux-thread-db.c (try_thread_db_load_from_pdir)
8189 (has_libpthread): Update.
8190 * linespec.c (iterate_over_all_matching_symtabs)
8191 (search_minsyms_for_name): Update.
8192 * jit.c (jit_find_objf_with_entry_addr): Update.
8193 * hppa-tdep.c (find_unwind_entry)
8194 (hppa_lookup_stub_minimal_symbol): Update.
8195 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8196 Update.
8197 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8198 (elf_gnu_ifunc_resolve_by_got): Update.
8199 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8200 * dwarf-index-write.c (save_gdb_index_command): Update.
8201 * cp-support.c (add_symbol_overload_list_qualified): Update.
8202 * breakpoint.c (create_overlay_event_breakpoint)
8203 (create_longjmp_master_breakpoint)
8204 (create_std_terminate_master_breakpoint)
8205 (create_exception_master_breakpoint): Update.
8206 * blockframe.c (find_pc_partial_function): Update.
8207 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8208 (ada_collect_symbol_completion_matches)
8209 (ada_add_global_exceptions): Update.
8210
8211 2019-01-17 Tom Tromey <tom@tromey.com>
8212
8213 * solib-target.c (lm_info_target_p): Remove typedef. Don't
8214 declare VEC.
8215 (solib_target_parse_libraries): Change return type.
8216 (library_list_start_segment, library_list_start_section)
8217 (library_list_end_library, library_list_start_library); Update.
8218 (solib_target_free_library_list): Remove.
8219 (solib_target_parse_libraries): Remove cleanup. Change return
8220 type.
8221 (solib_target_current_sos): Update.
8222
8223 2019-01-17 Tom Tromey <tromey@bapiya>
8224
8225 * valprint.c: Replace "the the" with "the".
8226 * symtab.c: Replace "the the" with "the".
8227 * solib.c: Replace "the the" with "the".
8228 * solib-dsbt.c: Replace "the the" with "the".
8229 * linespec.c: Replace "the the" with "the".
8230 * dwarf2loc.h: Replace "the the" with "the".
8231 * amd64-windows-tdep.c: Replace "the the" with "the".
8232 * aarch64-tdep.c: Replace "the the" with "the".
8233
8234 2019-01-16 Keith Seitz <keiths@redhat.com>
8235
8236 PR gdb/23773
8237 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8238 <builder>: Rename to ..
8239 <m_builder>: ... this and make private.
8240 (dwarf2_cu::get_builder): New method. Change all users of
8241 `builder' to use this method.
8242 (dwarf2_start_symtab): Move to ...
8243 (dwarf2_cu::start_symtab): ... here. Update all callers
8244 (setup_type_unit_groups): Move to ...
8245 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
8246 callers.
8247 (dwarf2_cu::reset_builder): New method.
8248 (process_full_compunit, process_full_type_unit): Use
8249 dwarf2_cu::reset_builder.
8250 (follow_die_offset): Record the ancestor CU if it is different
8251 from the followed DIE's CU.
8252 (follow_die_sig_1): Likewise.
8253
8254 2019-01-15 Tom Tromey <tom@tromey.com>
8255
8256 * remote.c (class remote_state) <buf>: Now a char_vector.
8257 <buf_size>: Remove.
8258 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
8259 parameter.
8260 (remote_target::getpkt_or_notif_sane_1)
8261 (remote_target::getpkt_sane)
8262 (remote_target::getpkt_or_notif_sane): Likewise.
8263 (class remote_target) <putpkt>: New overload.
8264 (remote_target::read_frame): Change type of "buf_p". Remove
8265 sizeof_p parameter.
8266 (packet_ok): New overload.
8267 (packet_check_result): New overload.
8268 Update all uses.
8269
8270 2019-01-14 Tom Tromey <tom@tromey.com>
8271
8272 * remote-notif.c (handle_notification, remote_notif_ack)
8273 (remote_notif_parse): Make "buf" const.
8274 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8275 const.
8276 (remote_notif_parse, remote_notif_ack, handle_notification):
8277 Likewise.
8278 * remote.c (remote_notif_stop_parse): Make "buf" const.
8279 (remote_target::remote_parse_stop_reply): Make "buf" const.
8280 (remote_notif_stop_ack): Make "buf" const.
8281
8282 2019-01-14 Tom Tromey <tom@tromey.com>
8283
8284 * remote.c (remote_console_output): Make parameter const.
8285
8286 2019-01-14 Tom Tromey <tom@tromey.com>
8287
8288 * target-debug.h (target_debug_print_signals): Constify.
8289 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8290 * procfs.c (procfs_target::pass_signals): Update.
8291 * linux-nat.c (linux_nat_target::pass_signals): Update.
8292 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8293 * target-delegates.c: Rebuild.
8294 * remote.c (remote_target::program_signals): Update.
8295 (remote_target::pass_signals): Update.
8296 * target.c (target_pass_signals): Constify argument.
8297 (target_program_signals): Likewise.
8298 * target.h (struct target_ops) <pass_signals, program_signals>:
8299 Constify argument.
8300 (target_pass_signals, target_program_signals): Constify argument.
8301
8302 2019-01-14 Tom Tromey <tom@tromey.com>
8303
8304 PR tui/28819:
8305 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8306
8307 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
8308
8309 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8310 field.
8311 * rs6000-tdep.c: Include reggroups.h.
8312 (IS_V_ALIAS_PSEUDOREG): Define.
8313 (rs6000_register_name): Return names for the "vX" aliases.
8314 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8315 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
8316 aliases. Call default_register_reggroup_p for all other
8317 pseudo-registers.
8318 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8319 New functions.
8320 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8321 Handle "vX" aliases.
8322 (v_alias_pseudo_register_collect): New function.
8323 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8324 (rs6000_gdbarch_init): Initialize "vX" aliases as
8325 pseudo-registers. Restore registration of
8326 rs6000_pseudo_register_reggroup_p with
8327 set_tdesc_pseudo_register_reggroup_p.
8328
8329 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
8330
8331 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8332 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8333 set_gdbarch_num_pseudo_regs.
8334
8335 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8336
8337 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8338 Remove arg prefixname, add do_set and do_show.
8339 Add member functions set_list and show_list.
8340 * cli/cli-style.c (class cli_style_option): Update accordingly.
8341 (style_set_list): Move to file scope.
8342 (style_show_list): Likewise.
8343 (set_style): Call help_list.
8344 (show_style): Call cmd_show_list.
8345 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8346 Update to use the new macro.
8347
8348 2019-10-12 Joel Brobecker <brobecker@adacore.com>
8349
8350 * ada-lang.c (_initialize_ada_language): Expand the help text
8351 for the "catch exception" command.
8352
8353 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8354
8355 * symtab.c (matching_obj_sections): Initialize obj,
8356 declare it closer to its usage.
8357
8358 2019-01-10 Tom Tromey <tom@tromey.com>
8359
8360 * thread-iter.h (inf_threads_iterator): Use next_iterator.
8361 (basic_inf_threads_range): Remove.
8362 (inf_threads_range, inf_non_exited_threads_range)
8363 (safe_inf_threads_range): Use next_adapter.
8364
8365 2019-01-10 Keith Seitz <keiths@redhat.com>
8366
8367 PR gdb/23712
8368 PR symtab/23010
8369 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8370 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8371
8372 2019-01-10 Keith Seitz <keiths@redhat.com>
8373
8374 PR gdb/23712
8375 PR symtab/23010
8376 * dictionary.c (pending_to_vector): Remove.
8377 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8378 Remove _1 suffix, replacing functions of the same name. Update
8379 all callers.
8380 (dict_create_hashed, dict_create_hashed_expandable)
8381 (dict_create_linear, dict_create_linear_expandable, dict_free)
8382 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8383 Make functions static.
8384
8385 2019-01-10 Keith Seitz <keiths@redhat.com>
8386
8387 PR gdb/23712
8388 PR symtab/23010
8389 * dictionary.h (struct dictionary): Replace declaration with
8390 multidictionary.
8391 (dict_create_hashed, dict_create_hashed_expandable)
8392 (dict_create_linear, dict_create_linear_expandable)
8393 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8394 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8395 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8396 taking multidictionary argument.
8397 [ALL_DICT_SYMBOLS]: Update for multidictionary.
8398 * block.h (struct block) <dict>: Change to multidictionary
8399 and rename `multidict'.
8400 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8401 symmisc.c: Update all dictionary references to multidictionary.
8402
8403 2019-01-10 Keith Seitz <keiths@redhat.com>
8404
8405 PR gdb/23712
8406 PR symtab/23010
8407 * dictionary.c: Include unordered_map.
8408 (pending_to_vector): New function.
8409 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8410 Rewrite the non-"_1" functions to take vector instead
8411 of linked list.
8412 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8413 "new" _1 versions of the same name.
8414 (multidictionary): Define.
8415 (std::hash<enum language): New definition.
8416 (collate_pending_symbols_by_language, mdict_create_hashed)
8417 (mdict_create_hashed_expandable, mdict_create_linear)
8418 (mdict_create_linear_expandable, mdict_free)
8419 (find_language_dictionary, create_new_language_dictionary)
8420 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8421 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8422 (mdict_size, mdict_empty): New functions.
8423 * dictionary.h (mdict_iterator): Define.
8424
8425 2019-01-10 Pedro Alves <palves@redhat.com>
8426
8427 * breakpoint.c (read_uploaded_action)
8428 (create_tracepoint_from_upload): Adjust to use
8429 gdb::unique_xmalloc_ptr.
8430 * ctf.c (ctf_write_uploaded_tp):
8431 (SET_ARRAY_FIELD): Use emplace_back.
8432 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8433 * tracefile-tfile.c (tfile_write_uploaded_tp):
8434 * tracepoint.c (parse_tracepoint_definition): Adjust to use
8435 gdb::unique_xmalloc_ptr.
8436 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8437 at_string, cond_string, cmd_strings>: Replace char pointers
8438 with gdb::unique_xmalloc_ptr.
8439
8440 2019-01-10 Pedro Alves <palves@redhat.com>
8441
8442 * solib-target.c (library_list_start_library): Don't xstrdup name.
8443
8444 2019-01-10 Pedro Alves <palves@redhat.com>
8445
8446 * mdebugread.c (parse_partial_symbols): Use
8447 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8448
8449 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
8450
8451 * linux-fork.c (scoped_switch_fork_info)
8452 <~scoped_switch_fork_info>: Fix incorrect variable name.
8453
8454 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
8455
8456 * linux-fork.c (scoped_switch_fork_info)
8457 <scoped_switch_fork_info>: Make explicit.
8458 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8459
8460 2019-01-10 Tom Tromey <tom@tromey.com>
8461
8462 * objfiles.h (objfile::reset_psymtabs): Update.
8463 * objfiles.c (objfile::objfile): Update.
8464 * psymtab.h (psymtab_storage::obstack): Update.
8465 (psymtab_storage::m_obstack): Use gdb::optional.
8466 (class psymtab_storage): Update comment. Remove objfile
8467 parameter.
8468 * psymtab.c (psymtab_storage::psymtab_storage): Update.
8469
8470 2019-01-10 Tom Tromey <tom@tromey.com>
8471
8472 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8473 <free_psymtabs>: Now private.
8474 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8475 (allocate_psymtab): Use new method.
8476
8477 2019-01-10 Tom Tromey <tom@tromey.com>
8478
8479 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8480 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8481 * mdebugread.c (parse_partial_symbols): Use
8482 allocate_dependencies.
8483 * dwarf2read.c (dwarf2_create_include_psymtab): Use
8484 allocate_dependencies.
8485 (process_psymtab_comp_unit_reader)
8486 (build_type_psymtab_dependencies): Likewise.
8487 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8488
8489 2019-01-10 Tom Tromey <tom@tromey.com>
8490
8491 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8492 PSYMBOL_SET_LANGUAGE.
8493 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8494
8495 2019-01-10 Tom Tromey <tom@tromey.com>
8496
8497 * psymtab.h (psymtab_storage::obstack): New method.
8498 <m_obstack>: Rename from obstack; now private.
8499 * psymtab.c (psymtab_storage): Update.
8500 * dwarf2read.c (create_addrmap_from_index)
8501 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8502 Update.
8503
8504 2019-01-10 Tom Tromey <tom@tromey.com>
8505
8506 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8507 * objfiles.h (objfile::reset_psymtabs): New method.
8508
8509 2019-01-10 Tom Tromey <tom@tromey.com>
8510
8511 * symmisc.c (print_symbol_bcache_statistics): Update.
8512 (print_objfile_statistics): Update.
8513 * symfile.c (reread_symbols): Update.
8514 * psymtab.h (class psymtab_storage): New.
8515 * psymtab.c (psymtab_storage): New constructor.
8516 (~psymtab_storage): New destructor.
8517 (require_partial_symbols): Update.
8518 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8519 (find_pc_sect_psymtab, find_pc_sect_psymbol)
8520 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8521 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8522 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8523 (start_psymtab_common, end_psymtab_common)
8524 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8525 (allocate_psymtab): Update.
8526 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8527 Update.
8528 (dump_psymtab_addrmap, maintenance_print_psymbols)
8529 (maintenance_check_psymtabs): Update.
8530 (class objfile_psymtabs): Move to objfiles.h.
8531 * psympriv.h (discard_psymtab): Now inline.
8532 (psymtab_discarder::psymtab_discarder): Update.
8533 (psymtab_discarder::~psymtab_discarder): Update.
8534 (ALL_OBJFILE_PSYMTABS): Rewrite.
8535 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8536 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8537 Remove fields.
8538 <partial_symtabs>: New field.
8539 (class objfile_psymtabs): Move from psymtab.h. Update.
8540 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8541 psymbol_cache.
8542 (objfile::~objfile): Don't destroy psymbol_cache.
8543 * mdebugread.c (parse_partial_symbols): Update.
8544 * dwarf2read.c (create_addrmap_from_index)
8545 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8546 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8547 (add_partial_subprogram, dwarf2_ranges_read): Update.
8548 * dwarf-index-write.c (write_address_map)
8549 (write_one_signatured_type, recursively_write_psymbols)
8550 (class debug_names, class debug_names, write_psymtabs_to_index):
8551 Update.
8552
8553 2019-01-10 Tom Tromey <tom@tromey.com>
8554
8555 * symtab.h (SYMBOL_SET_NAMES): Update.
8556 (symbol_set_names): Update.
8557 (MSYMBOL_SET_NAMES): Update.
8558 * symtab.c (symbol_set_names): Change argument to be an
8559 objfile_per_bfd_storage.
8560 * psymtab.c (add_psymbol_to_bcache): Update.
8561 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8562
8563 2019-01-10 Tom Tromey <tom@tromey.com>
8564
8565 * symtab.c (create_demangled_names_hash): Change argument to be an
8566 objfile_per_bfd_storage.
8567 (symbol_set_names): Update.
8568
8569 2019-01-10 Tom Tromey <tom@tromey.com>
8570
8571 * xcoffread.c (xcoff_initial_scan): Unconditionally call
8572 init_psymbol_list.
8573 * psymtab.c (init_psymbol_list): Do nothing if already called.
8574 * psympriv.h (init_psymbol_list): Add comment.
8575 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8576 init_psymbol_list.
8577 * dbxread.c (dbx_symfile_read): Unconditionally call
8578 init_psymbol_list.
8579
8580 2019-01-10 Tom Tromey <tom@tromey.com>
8581
8582 * xcoffread.c (scan_xcoff_symtab): Update.
8583 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8584 "where".
8585 * mdebugread.c (parse_partial_symbols)
8586 (handle_psymbol_enumerators): Update.
8587 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8588 * dbxread.c (read_dbx_symtab): Update.
8589 * psympriv.h (psymbol_placement): New enum.
8590 (add_psymbol_to_list): Update.
8591
8592 2019-01-10 Tom Tromey <tom@tromey.com>
8593
8594 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8595 static_psymbols parameters.
8596 (scan_xcoff_symtab): Update.
8597 * psymtab.c (start_psymtab_common): Remove global_psymbols and
8598 static_psymbols parameters.
8599 * psympriv.h (start_psymtab_common): Update.
8600 * mdebugread.c (parse_partial_symbols): Update.
8601 * dwarf2read.c (create_partial_symtab): Update.
8602 * dbxread.c (read_dbx_symtab): Update.
8603 (start_psymtab): Remove global_psymbols and static_psymbols
8604 parameters.
8605
8606 2019-01-10 Tom Tromey <tom@tromey.com>
8607
8608 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8609 * psymtab.c (allocate_psymtab): Add comment.
8610 * psympriv.h (allocate_psymtab): Add comment.
8611 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8612 initializations.
8613 * dbxread.c (dbx_end_psymtab): Remove some initializations.
8614
8615 2019-01-10 Tom Tromey <tom@tromey.com>
8616
8617 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8618 Don't declare.
8619 * mipsread.c: Include mdebugread.h.
8620 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8621 Declare.
8622 * elfread.c: Include mdebugread.h.
8623
8624 2019-01-09 Tom Tromey <tom@tromey.com>
8625
8626 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8627 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8628 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8629 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8630 (psym_lookup_symbol, psym_find_last_source_symtab)
8631 (psym_forget_cached_source_info, psym_print_stats)
8632 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8633 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8634 (psym_map_matching_symbols, psym_expand_symtabs_matching)
8635 (psym_find_compunit_symtab_by_address)
8636 (maintenance_print_psymbols, maintenance_info_psymtabs)
8637 (maintenance_check_psymtabs): Use ranged for.
8638 * psymtab.h (class objfile_psymtabs): New.
8639 (require_partial_symbols): Return objfile_psymtabs.
8640 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8641
8642 2019-01-09 Tom Tromey <tom@tromey.com>
8643
8644 * symfile.c (overlay_invalidate_all, find_pc_overlay)
8645 (find_pc_mapped_section, list_overlays_command)
8646 (map_overlay_command, unmap_overlay_command)
8647 (simple_overlay_update): Use all_objfiles.
8648 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8649 * printcmd.c (info_symbol_command): Use all_objfiles.
8650 * objfiles.h (ALL_OBJSECTIONS): Remove.
8651 * maint.c (maintenance_translate_address): Use all_objfiles.
8652 * gcore.c (gcore_create_callback): Use all_objfiles.
8653 (objfile_find_memory_regions): Likewise.
8654
8655 2019-01-09 Tom Tromey <tom@tromey.com>
8656
8657 * symtab.c (find_line_symtab, info_sources_command)
8658 (make_source_files_completion_list): Use objfile_compunits.
8659 * source.c (select_source_symtab): Use objfile_compunits.
8660 * objfiles.h (struct objfile): Update comment.
8661 (ALL_OBJFILES): Remove.
8662 (ALL_FILETABS): Remove.
8663 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8664 objfile_compunits.
8665
8666 2019-01-09 Tom Tromey <tom@tromey.com>
8667
8668 * symmisc.c (print_objfile_statistics, dump_objfile)
8669 (maintenance_print_symbols): Use compunit_filetabs.
8670 * source.c (forget_cached_source_info_for_objfile): Use
8671 compunit_filetabs.
8672 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8673 (ALL_FILETABS): Use compunit_filetabs.
8674 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8675 * coffread.c (coff_symtab_read): Use compunit_filetabs.
8676
8677 2019-01-09 Tom Tromey <tom@tromey.com>
8678
8679 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8680 (compunit_filetabs): New.
8681 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8682 compunit_filetabs.
8683 (info_sources_command, make_source_files_completion_list): Remove
8684 declaration.
8685 * symmisc.c (print_objfile_statistics, dump_objfile)
8686 (maintenance_print_symbols): Remove declaration.
8687 (maintenance_info_symtabs): Use compunit_filetabs.
8688 (maintenance_info_line_tables): Likewise.
8689 * source.c (select_source_symtab): Change local variable name.
8690 (forget_cached_source_info_for_objfile): Remove declaration.
8691 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8692 * objfiles.c (objfile_relocate1): Remove declaration.
8693 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8694 declaration.
8695 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8696 * coffread.c (coff_symtab_read): Remove declaration.
8697 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8698 compunit_filetabs.
8699
8700 2019-01-09 Tom Tromey <tom@tromey.com>
8701
8702 * symtab.c (lookup_objfile_from_block)
8703 (find_pc_sect_compunit_symtab, search_symbols)
8704 (default_collect_symbol_completion_matches_break_on): Use
8705 objfile_compunits.
8706 * objfiles.h (ALL_COMPUNITS): Remove.
8707 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8708 * cp-support.c (add_symbol_overload_list_qualified): Use
8709 objfile_compunits.
8710 * ada-lang.c (ada_collect_symbol_completion_matches)
8711 (ada_add_global_exceptions): Use objfile_compunits.
8712
8713 2019-01-09 Tom Tromey <tom@tromey.com>
8714
8715 * source.c (select_source_symtab)
8716 (forget_cached_source_info_for_objfile): Remove declaration.
8717 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8718 declaration.
8719 * maint.c (count_symtabs_and_blocks): Remove declaration.
8720 * cp-support.c (add_symbol_overload_list_qualified): Remove
8721 declaration.
8722 * coffread.c (coff_symtab_read): Remove declaration.
8723 * symtab.c (lookup_symbol_in_objfile_symtabs)
8724 (basic_lookup_transparent_type_1): Use objfile_compunits.
8725 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8726 (info_sources_command, search_symbols)
8727 (default_collect_symbol_completion_matches_break_on)
8728 (make_source_files_completion_list): Remove declaration.
8729 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8730 (ada_collect_symbol_completion_matches)
8731 (ada_add_global_exceptions): Remove declaration.
8732 * linespec.c (iterate_over_all_matching_symtabs): Use
8733 objfile_compunits.
8734 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8735 (class objfile_compunits): New.
8736 (ALL_COMPUNITS): Use objfile_compunits.
8737 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8738 (maintenance_check_symtabs, maintenance_info_line_tables): Use
8739 objfile_compunits.
8740 * objfiles.c (objfile_relocate1): Use objfile_compunits.
8741
8742 2019-01-09 Tom Tromey <tom@tromey.com>
8743
8744 * symtab.c (search_symbols)
8745 (default_collect_symbol_completion_matches_break_on): Use
8746 objfile_msymbols.
8747 * ada-lang.c (ada_lookup_simple_minsym)
8748 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8749 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8750 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8751 objfile_msymbols.
8752 * coffread.c (coff_symfile_read): Use objfile_msymbols.
8753 * symmisc.c (dump_msymbols): Use objfile_msymbols.
8754 * objc-lang.c (find_methods): Use objfile_msymbols.
8755 (info_selectors_command, info_classes_command): Likewise.
8756 * stabsread.c (scan_file_globals): Use objfile_msymbols.
8757 * objfiles.h (class objfile_msymbols): New.
8758 (ALL_OBJFILE_MSYMBOLS): Remove.
8759 (ALL_MSYMBOLS): Remove.
8760
8761 2019-01-09 Tom Tromey <tom@tromey.com>
8762
8763 * common/next-iterator.h (next_adapter): Add Iterator template
8764 parameter.
8765 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8766 (class all_objfiles_safe): New.
8767 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8768 * objfiles.c (put_objfile_before): Update comment.
8769 (add_separate_debug_objfile): Likewise.
8770 (free_all_objfiles): Use all_objfiles_safe.
8771 (objfile_purge_solibs): Likewise.
8772
8773 2019-01-09 Tom Tromey <tom@tromey.com>
8774
8775 * symtab.c (iterate_over_symtabs, matching_obj_sections)
8776 (expand_symtab_containing_pc, lookup_static_symbol)
8777 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8778 (find_symbol_at_address, find_line_symtab, find_main_name): Use
8779 all_objfiles.
8780 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8781 * breakpoint.c (create_overlay_event_breakpoint)
8782 (create_longjmp_master_breakpoint)
8783 (create_std_terminate_master_breakpoint)
8784 (create_exception_master_breakpoint): Use all_objfiles.
8785 * linux-thread-db.c (try_thread_db_load_from_pdir)
8786 (has_libpthread): Use all_objfiles.
8787 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8788 * linespec.c (iterate_over_all_matching_symtabs)
8789 (search_minsyms_for_name): Use all_objfiles.
8790 * maint.c (maintenance_info_sections): Use all_objfiles.
8791 * main.c (captured_main_1): Use all_objfiles.
8792 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8793 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8794 * guile/scm-pretty-print.c
8795 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8796 * solib-spu.c (append_ocl_sos): Use all_objfiles.
8797 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8798 (maintenance_print_msymbols): Use all_objfiles.
8799 * source.c (select_source_symtab): Use all_objfiles.
8800 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8801 * symfile.c (remove_symbol_file_command)
8802 (expand_symtabs_matching, map_symbol_filenames): Use
8803 all_objfiles.
8804 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8805 all_objfiles.
8806 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8807 * objc-lang.c (find_methods): Use all_objfiles.
8808 * objfiles.c (have_partial_symbols, have_full_symbols)
8809 (have_minimal_symbols, qsort_cmp)
8810 (default_iterate_over_objfiles_in_search_order): Use
8811 all_objfiles.
8812 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8813 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8814 (maintenance_check_psymtabs): Use all_objfiles.
8815 (ALL_PSYMTABS): Remove.
8816 * compile/compile-object-run.c (do_module_cleanup): Use
8817 all_objfiles.
8818 * blockframe.c (find_pc_partial_function): Use all_objfiles.
8819 * cp-support.c (add_symbol_overload_list_qualified): Use
8820 all_objfiles.
8821 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8822 Use all_objfiles.
8823 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8824 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8825 all_objfiles.
8826 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8827 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8828 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8829 Uses all_objfiles.
8830 * solib.c (solib_read_symbols): Use all_objfiles
8831
8832 2019-01-09 Tom Tromey <tom@tromey.com>
8833
8834 * probe.c (parse_probes_in_pspace): Use all_objfiles.
8835 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8836 all_objfiles.
8837 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8838 * symmisc.c (print_symbol_bcache_statistics)
8839 (print_objfile_statistics, maintenance_print_objfiles)
8840 (maintenance_info_symtabs, maintenance_check_symtabs)
8841 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8842 all_objfiles.
8843 * source.c (forget_cached_source_info): Use all_objfiles.
8844 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8845 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8846 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8847 * objfiles.c (update_section_map): Use all_objfiles.
8848 (shared_objfile_contains_address_p): Likewise.
8849 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8850 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8851
8852 2019-01-09 Tom Tromey <tom@tromey.com>
8853
8854 * common/next-iterator.h: New file.
8855 * objfiles.h (class all_objfiles): New.
8856 (struct objfile_iterator): New.
8857
8858 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8859
8860 * NEWS: Move the description of the changed "frame", "select-frame",
8861 and "info frame" commands to the Changed commands section.
8862
8863 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
8864
8865 * gdbtypes.c (check_stub_method_group): Remove handling of old
8866 mangling schemes.
8867 * linespec.c (find_methods): Likewise.
8868 * stabsread.c (read_member_functions): Likewise.
8869 * valops.c (search_struct_method): Likewise.
8870 (value_struct_elt_for_reference): Likewise.
8871 * NEWS: Mention this change.
8872
8873 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
8874
8875 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8876 print_source_lines.
8877 * source.c (print_source_lines_base): Update line number check.
8878 (print_source_lines): New function.
8879 (source_lines_range::source_lines_range): New function.
8880 * source.h (class source_lines_range): New class.
8881 (print_source_lines): New declaration.
8882
8883 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8884
8885 * linespec.c (linespec_state_destructor): Free self->canonical_names.
8886
8887 2019-01-08 Tom Tromey <tom@tromey.com>
8888 Simon Marchi <simon.marchi@ericsson.com>
8889
8890 PR gdb/24060
8891 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8892 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8893 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8894 * f-exp.y (DOLLAR_VARIABLE): Likewise.
8895 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8896 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8897
8898 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
8899
8900 * source.c (select_source_symtab): Move header comment to
8901 declaration in source.h.
8902 (forget_cached_source_info_for_objfile): Likewise.
8903 (forget_cached_source_info): Likewise.
8904 (identify_source_line): Likewise.
8905 * source.h (identify_source_line): Move declaration from symtab.h
8906 and add comment from source.c
8907 (print_source_lines): Likewise.
8908 (forget_cached_source_info_for_objfile): Likewise.
8909 (forget_cached_source_info): Likewise.
8910 (select_source_symtab): Likewise.
8911 (enum print_source_lines_flag): Move definition from symtab.h.
8912 * symtab.h (identify_source_line): Move declaration to source.h.
8913 (print_source_lines): Likewise.
8914 (forget_cached_source_info_for_objfile): Likewise.
8915 (forget_cached_source_info): Likewise.
8916 (select_source_symtab): Likewise.
8917 (enum print_source_lines_flag): Move definition to source.h.
8918 * tui/tui-hooks.c: Add 'source.h' include.
8919
8920 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
8921
8922 * source.c (print_source_lines_base): Handle requests to print
8923 reverse line number sequences, and guard against empty lines
8924 string.
8925
8926 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
8927
8928 * source.c (print_source_lines_base): Fix skip of '\r' if next
8929 character is '\n'.
8930
8931 2019-01-06 Tom Tromey <tom@tromey.com>
8932
8933 * c-exp.y (struct c_parse_state) <macro_original_text,
8934 expansion_obstack>: New member.
8935 (macro_original_text, expansion_obstack): Remove globals.
8936 (scan_macro_expansion, scanning_macro_expansion)
8937 (finished_macro_expansion): Update.
8938 (scan_macro_cleanup): Remove.
8939 (yylex, c_parse): Update.
8940
8941 2019-01-06 Tom Tromey <tom@tromey.com>
8942
8943 * c-exp.y (struct c_parse_state) <strings>: New member.
8944 (operator_stoken): Update.
8945
8946 2019-01-06 Tom Tromey <tom@tromey.com>
8947
8948 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
8949 (union type_stack_elt) <typelist_val>: Now a pointer to
8950 std::vector.
8951 (type_stack_cleanup): Don't declare.
8952 (push_typelist): Update.
8953 * parse.c (pop_typelist): Return a std::vector.
8954 (push_typelist): Take a std::vector.
8955 (follow_types): Update. Do not free args.
8956 (type_stack_cleanup): Remove.
8957 * c-exp.y (struct c_parse_state): New.
8958 (cpstate): New global.
8959 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8960 (nonempty_typelist): Update.
8961 (func_mod): Create a new vector.
8962 (c_parse): Create a c_parse_state.
8963 (check_parameter_typelist): Do not delete params.
8964 (function_method): Update. Do not delete type_list.
8965
8966 2019-01-06 Tom Tromey <tom@tromey.com>
8967
8968 PR gdb/28155:
8969 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8970 check_typedef.
8971 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8972 (print_return_value): Likewise.
8973
8974 2019-01-05 Tom Tromey <tom@tromey.com>
8975
8976 * contrib/cleanup_check.py: Remove.
8977 * contrib/gcc-with-excheck: Remove.
8978 * contrib/exsummary.py: Remove.
8979 * contrib/excheck.py: Remove.
8980
8981 2019-01-05 Joel Brobecker <brobecker@adacore.com>
8982
8983 * thread.c (delete_thread_1): Add gdb_assert that THR is not
8984 NULL. Initialize tpprev to NULL instead of assigning it
8985 to NULL on the next statement.
8986 * windows-nat.c (windows_delete_thread): Remove check for
8987 main_thread_id before printing thread exit notifications.
8988 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8989 Remove thread ID check against main_thread_id.
8990 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8991 windows_delete_thread.
8992 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8993
8994 2019-01-04 Tom Tromey <tom@tromey.com>
8995
8996 * compile/compile.c (_initialize_compile): Use upper case for
8997 metasyntactic variables.
8998 * symmisc.c (_initialize_symmisc): Use upper case for
8999 metasyntactic variables.
9000 * psymtab.c (_initialize_psymtab): Use upper case for
9001 metasyntactic variables.
9002 * demangle.c (demangle_command): Use upper case for metasyntactic
9003 variables.
9004 (_initialize_demangler): Likewise.
9005 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9006 variables.
9007
9008 2019-01-03 Tom Tromey <tom@tromey.com>
9009
9010 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9011
9012 2019-01-03 Tom Tromey <tom@tromey.com>
9013
9014 * python/py-symtab.c (salpy_str): Update.
9015 (struct salpy_sal_object) <symtab>: Now a PyObject.
9016 (salpy_dealloc): Update.
9017 (del_objfile_sal): Use gdbpy_ref.
9018
9019 2019-01-03 Tom Tromey <tom@tromey.com>
9020
9021 * python/py-type.c (convert_field): Use new_reference. Return
9022 gdbpy_ref.
9023 (make_fielditem): Return gdbpy_ref.
9024 (typy_fields): Update.
9025 (typy_getitem): Update.
9026 (field_name): Return gdbpy_ref. Use new_reference.
9027 (typy_iterator_iternext): Update.
9028
9029 2019-01-03 Tom Tromey <tom@tromey.com>
9030
9031 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9032
9033 2019-01-03 Tom Tromey <tom@tromey.com>
9034
9035 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9036 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9037 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9038 (pspy_set_frame_filters, pspy_set_frame_unwinders)
9039 (pspy_set_type_printers): Likewise.
9040 * python/py-function.c (fnpy_init): Use gdbpy_ref.
9041 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9042 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9043 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9044 (objfpy_set_type_printers): Likewise.
9045
9046 2019-01-03 Tom Tromey <tom@tromey.com>
9047
9048 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9049 (gdbpy_print_stack): Use gdbpy_err_fetch.
9050 * python/python-internal.h (class gdbpy_err_fetch): New class.
9051 (class gdbpy_enter) <m_error_type, m_error_value,
9052 m_error_traceback>: Remove.
9053 <m_error>: New member.
9054 (gdbpy_exception_to_string): Don't declare.
9055 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9056 * python/py-value.c (convert_value_from_python): Use
9057 gdbpy_err_fetch.
9058 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9059 gdbpy_exception_to_string.
9060 (gdbpy_handle_exception): Use gdbpy_err_fetch.
9061 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9062 gdbpy_err_fetch.
9063
9064 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9065
9066 * linux-nat.c (delete_lwp_cleanup): Delete.
9067 (struct lwp_deleter): New struct.
9068 (lwp_info_up): New typedef.
9069 (linux_nat_target::follow_fork): Delete cleanup, and make use of
9070 lwp_info_up.
9071
9072 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9073
9074 * linux-fork.c (class scoped_switch_fork_info): New class.
9075 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9076
9077 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9078
9079 * valops.c (find_overload_match): Remove use of null_cleanup, and
9080 calls to do_cleanups.
9081
9082 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9083
9084 * compile/compile-cplus-types.c
9085 (compile_cplus_instance::decl_name): Handle changes to
9086 cp_func_name.
9087 * cp-support.c (cp_func_name): Update header comment, update
9088 return type.
9089 * cp-support.h (cp_func_name): Update return type in declaration.
9090 * valops.c (find_overload_match): Move temp_func local to top
9091 level of function and change its type. Use temp_func to hold and
9092 delete temporary string obtained from cp_func_name.
9093
9094 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
9095
9096 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9097 gdb::char_vector, remove cleanup, and update uses of `msg`.
9098
9099 2019-01-03 Jim Wilson <jimw@sifive.com>
9100
9101 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9102
9103 2019-01-02 Tom Tromey <tom@tromey.com>
9104
9105 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9106 (tdesc_parse_xml): Remove cleanups.
9107 * target-descriptions.h (make_cleanup_free_target_description):
9108 Don't declare.
9109 (target_desc_deleter): New struct.
9110 (target_desc_up): New typedef.
9111 * target-descriptions.c (target_desc_deleter::operator()): Rename
9112 from free_target_description.
9113 (make_cleanup_free_target_description): Remove.
9114
9115 2019-01-02 Tom Tromey <tom@tromey.com>
9116
9117 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
9118 constructor, destructor.
9119 (linespec_parser): Remove typedef.
9120 (~linespec_parser): Rename from linespec_parser_delete.
9121 (linespec_lex_to_end, linespec_complete_label)
9122 (linespec_complete): Update.
9123 (decode_line_full): Remove cleanups.
9124 (decode_line_1): Update.
9125
9126 2019-01-02 Tom Tromey <tom@tromey.com>
9127
9128 * python/python-internal.h (inferior_to_inferior_object): Change
9129 return type.
9130 * python/py-exitedevent.c (create_exited_event_object): Update.
9131 * python/py-inferior.c (inferior_to_inferior_object): Return
9132 gdbpy_ref.
9133 (python_new_inferior, python_inferior_deleted)
9134 (thread_to_thread_object, delete_thread_object)
9135 (build_inferior_list, gdbpy_selected_inferior): Update.
9136 * python/py-infthread.c (create_thread_object): Update. Also fail
9137 if inferior_to_inferior_object fails.
9138
9139 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
9140
9141 * inferior.h (class inferior) <displaced_step_state>: New field.
9142 * infrun.h (struct displaced_step_state): Move here from
9143 infrun.c. Initialize fields, add constructor.
9144 <inf>: Remove field.
9145 <reset>: New method.
9146 * infrun.c (struct displaced_step_inferior_state): Move to
9147 infrun.h.
9148 (displaced_step_inferior_states): Remove.
9149 (get_displaced_stepping_state): Adust.
9150 (displaced_step_in_progress_any_inferior): Adjust.
9151 (displaced_step_in_progress_thread): Adjust.
9152 (displaced_step_in_progress): Adjust.
9153 (add_displaced_stepping_state): Remove.
9154 (get_displaced_step_closure_by_addr): Adjust.
9155 (remove_displaced_stepping_state): Remove.
9156 (infrun_inferior_exit): Call displaced_step_state.reset.
9157 (use_displaced_stepping): Don't check for NULL.
9158 (displaced_step_prepare_throw): Call
9159 get_displaced_stepping_state.
9160 (displaced_step_fixup): Don't check for NULL.
9161 (prepare_for_detach): Don't check for NULL.
9162
9163 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9164
9165 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9166 in case of call that did not complete.
9167
9168 2019-01-02 Andrey Utkin <autkin@undo.io>
9169
9170 * symfile.c (find_separate_debug_file): Fix search of debug files for
9171 remote debuggee.
9172
9173 2019-01-02 Tom Tromey <tom@tromey.com>
9174
9175 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9176 indentation.
9177 * python/py-frame.c (frapy_older): Remove cast.
9178 (frapy_newer): Likewise.
9179 * python/py-breakpoint.c (local_setattro): Remove cast.
9180 * python/py-arch.c (archpy_name): Remove local variable.
9181 * python/py-type.c (gdbpy_lookup_type): Remove cast.
9182
9183 2019-01-02 Joel Brobecker <brobecker@adacore.com>
9184
9185 * unittests/basic_string_view/element_access/char/empty.cc:
9186 Fix year range in copyright header.
9187
9188 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
9189
9190 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9191 Delete.
9192 <operator==>: Update with for removed field.
9193 <hash>: Likewise.
9194 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9195 <isa_features>: ...this.
9196 <abi_features>: New field.
9197 (riscv_isa_flen): Update comment.
9198 (riscv_abi_xlen): New declaration.
9199 (riscv_abi_flen): New declaration.
9200 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9201 isa_features.
9202 (riscv_abi_xlen): New function.
9203 (riscv_isa_flen): Update to get answer from isa_features.
9204 (riscv_abi_flen): New function.
9205 (riscv_has_fp_abi): Update to get answer from abi_features.
9206 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9207 xlen and flen.
9208 (riscv_call_info) <xlen, flen>: Update comment.
9209 (riscv_call_arg_struct): Remove invalid assertions
9210 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9211 is removed.
9212 (riscv_gdbarch_init): Gather isa features and abi features
9213 separately, ensure both match on the gdbarch when reusing an old
9214 gdbarch. Relax an error check to allow 32-bit abi float to run on
9215 a target with 64-bit float hardware.
9216
9217 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9218
9219 * source.c (search_command_helper): Stop reverse search
9220 when line 1 has been searched.
9221
9222 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9223
9224 * record-full.c (record_full_base_target::close): Rewrite
9225 record_full_core_buf_list free logic.
9226
9227 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9228
9229 * break-catch-syscall.c (print_one_catch_syscall): xfree
9230 the last text.
9231
9232 2019-01-01 Joel Brobecker <brobecker@adacore.com>
9233
9234 * top.c (print_gdb_version): Update Copyright year in version
9235 message.
9236
9237 2019-01-01 Joel Brobecker <brobecker@adacore.com>
9238
9239 Update copyright year range in all GDB files.
9240
9241 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
9242
9243 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9244
9245 For older changes see ChangeLog-2018.
9246 \f
9247 Local Variables:
9248 mode: change-log
9249 left-margin: 8
9250 fill-column: 74
9251 version-control: never
9252 coding: utf-8
9253 End:
9254
This page took 0.244229 seconds and 4 git commands to generate.