gdb/ChangeLog

   1 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
   2
   3         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
   4         when unwrapping single-field structs.
   5
   6 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
   7
   8         * dwarf2read.c: Remove includes.
   9
  10 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
  11
  12         * ui-out.c (ui_out::call_do_message): Silence
  13         -Wformat-nonliteral warning.
  14
  15 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
  16
  17         * breakpoint.c: Remove some includes: continuations.h, skip.h,
  18         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
  19         include: readline/tilde.h.
  20
  21 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  22
  23         * remote.c (remote_target::get_trace_status): Remove declaration of
  24         trace_regblock_size.
  25
  26 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
  29         (show_user): Remove declaration of cmdlist.
  30         * cli/cli-cmds.h (max_user_call_depth): Declare.
  31         * cli/cli-script.c (execute_user_command): Remove declaration
  32         of max_user_call_depth.
  33
  34 2019-10-11  Jim Wilson  <jimw@sifive.com>
  35
  36         * gdbsupport/print-utils.h (pulongest): Fix comment.
  37         (plongest): Likewise.
  38         (phex): Add missing comment, mention leading zeros.
  39         (phex_nz): Add mention of no leading zeros to comment.
  40
  41         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
  42         plongest instead of unsigned long long cast.
  43
  44 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
  45
  46         * main.c (captured_main_1): Include gdbtk.h and remove declarations
  47         for external_editor_command and gdbtk_test.
  48
  49 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
  50
  51         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
  52         * varobj.c (varobjdebug): Move comment to...
  53         * varobj.h (varobjdebug): ...here, and declare.
  54
  55 2019-10-09  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
  58         erase_data_content.
  59
  60 2019-10-09  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
  63         * tui/tui-stack.c (tui_locator_window::rerender): Update.
  64         * tui/tui-command.c (tui_cmd_window::resize)
  65         (tui_refresh_cmd_win): Update.
  66         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
  67         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
  68         * tui/tui-data.c (~tui_gen_win_info): Remove.
  69         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  70         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
  71         (tui_redisplay_readline, tui_mld_flush)
  72         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
  73         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
  74         (tui_data_window::erase_data_content)
  75         (tui_data_item_window::rerender)
  76         (tui_data_item_window::refresh_window): Update.
  77         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
  78         (box_win, tui_gen_win_info::make_window)
  79         (tui_gen_win_info::make_visible): Update.
  80         (tui_delete_win): Remove.
  81         * tui/tui-winsource.c
  82         (tui_source_window_base::do_erase_source_content): Update.
  83         (tui_show_source_line, tui_source_window_base::update_tab_width)
  84         (tui_source_window_base::update_exec_info): Update.
  85         * tui/tui-data.h (struct curses_deleter): New.
  86         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
  87         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
  88
  89 2019-10-09  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
  92
  93 2019-10-09  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
  96         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
  97
  98 2019-10-09  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 101         window height directly.
 102         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 103         declare.
 104         * tui/tui-layout.c (tui_default_win_height): Remove.
 105         (tui_default_win_viewport_height): Remove.
 106
 107 2019-10-09  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui.h: Remove comments.
 110
 111 2019-10-09  Tom de Vries  <tdevries@suse.de>
 112
 113         * python/lib/gdb/printer/bound_registers.py: Use
 114         '^builtin_type_bound128' as regexp argument for
 115         add_builtin_pretty_printer.
 116
 117 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 118
 119         * guile/guile.c (guile_extension_script_ops): Remove forward
 120         declaration and mark as static.
 121         (guile_script_ops): Likewise.
 122         (extension_language_guile): Move further down in the file so
 123         it can reference the definitions for guile_{extension_,}script_ops.
 124
 125 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 126
 127         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 128         except SORTL, DFLTCC, and KDSA.
 129
 130 2019-10-08  Tom Tromey  <tromey@adacore.com>
 131
 132         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 133         (struct safe_symbol_file_add_args): Remove.
 134
 135 2019-10-08  Tom Tromey  <tromey@adacore.com>
 136
 137         * windows-nat.c: Don't include buildsym-legacy.h.
 138
 139 2019-10-08  Tom Tromey  <tromey@adacore.com>
 140
 141         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 142
 143 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 144
 145         * gdbtypes.c (overload_debug): Move comment to header.
 146         * gdbtypes.h (overload_debug): Declare.
 147         * valops.c: Remove declaration of overload_debug, instead
 148         include gdbtypes.h.
 149
 150 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 153         through _().
 154         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 155         move comment...
 156         * language.h (lang_frame_mismatch_warn): ... here. Also add
 157         declaration.
 158         * top.c (lang_frame_mismatch_warn): Remove declaration.
 159         (check_frame_language_change): Pass lang_frame_mismatch_warn
 160         through _().
 161
 162 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 163
 164         * c-lang.h (vtbl_ptr_name): Declare.
 165         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 166         it from the header.
 167         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 168
 169 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 170
 171         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 172         gdb_static_assert.
 173
 174 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 175
 176         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 177         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 178         * ctfread.c: New file.
 179         * ctfread.h: New file.
 180         * elfread.c: Include ctfread.h.
 181         (struct elfinfo text_p): New member ctfsect.
 182         (elf_locate_sections): Mark CTF section.
 183         (elf_symfile_read): Call elfctf_build_psymtabs.
 184         * Makefile.in (LIBCTF): Add.
 185         (CLIBS): Use it.
 186         (CDEPS): Likewise.
 187         (DIST): Add ctfread.c.
 188
 189 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * ctfread.c (struct nextfield): Renamed to ...
 192         (struct ctf_nextfield): ... this.
 193         (struct field_info): Renamed to ...
 194         (strut ctf_field_info): ... this.
 195         (attach_fields_to_type): Update for renamed structures.
 196         (ctf_add_member_cb): Likewise.
 197         (ctf_add_enum_member_cb): Likewise.
 198         (process_struct_members): Likewise.
 199         (process_enum_type): Likewise.
 200
 201 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 202
 203         * tracectf.h: Rename, was ctf.h.
 204         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 205         * tracefile.c: Likewise.
 206         * tracepoint.c: Remove unused include ctf.h.
 207         * mi/mi-main.c: Likewise.
 208         * Makefile.in Replace ctf.c with tracectf.c.
 209
 210 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 211
 212         * version.in: Change version number to "9.0.50.DATE-git".
 213
 214 2019-10-03  Tom Tromey  <tom@tromey.com>
 215
 216         PR rust/24976:
 217         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 218
 219 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 220
 221         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 222         cp_search_name_hash.
 223         * NEWS: Add entry about nested function support.
 224
 225 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 226             Andrew Burgess  <andrew.burgess@embecosm.com>
 227
 228         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 229         for nested static variables when searchin VAR_DOMAIN.
 230         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 231         global scope, update comment.
 232         (add_partial_subprogram): Call add_partial_subprogram recursively
 233         for nested subroutines when processinng Fortran.
 234         (load_partial_dies): Process the child entities of a subprogram
 235         when processing Fortran.
 236         (partial_die_parent_scope): Handle building scope
 237         for Fortran nested functions.
 238         (process_die): Record that nested functions have a scope.
 239         (new_symbol): Always record Fortran subprograms on the global
 240         symbol list.
 241         (determine_prefix): How to build the prefix for Fortran
 242         subprograms.
 243
 244 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 245
 246         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 247         have just sent the thread a SIGSTOP and are waiting for it to
 248         arrive.
 249
 250 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 251
 252         * btrace.c (btrace_add_pc): Remove whitespace before the template
 253         parameter in 'std::vector <...>'.
 254         (parse_xml_btrace_block): Likewise.
 255         (btrace_maint_decode_pt): Likewise.
 256         (btrace_maint_update_packets): Likewise.
 257         (btrace_maint_print_packets): Likewise.
 258         * btrace.h (struct btrace_maint_info): Likewise.
 259         * dwarf2read.c (struct type_unit_group): Likewise.
 260         (build_type_psymtabs_reader): Likewise.
 261         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 262         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 263         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 264
 265 2019-10-03  Tom de Vries  <tdevries@suse.de>
 266
 267         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 268         the first line of the help text for set/show style metadata.
 269
 270 2019-10-02  Tom Tromey  <tromey@adacore.com>
 271
 272         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 273         * gdbsupport/common-inferior.c: New file.
 274         * infcmd.c (startup_with_shell): Don't define.
 275         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 276         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 277         * inferior.h (startup_with_shell): Don't declare.
 278
 279 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 280
 281         * gdbsupport/gdb_assert.h: Include errors.h.
 282         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 283
 284 2019-10-02  Tom Tromey  <tromey@adacore.com>
 285
 286         * NEWS: Add $_ada_exception entry.
 287         * ada-lang.c (struct ada_catchpoint): Add constructor.
 288         <m_kind>: New member.
 289         (allocate_location_exception, re_set_exception): Remove
 290         "ex" parameter.
 291         (should_stop_exception): Compute $_ada_exception.
 292         (check_status_exception, print_it_exception)
 293         (print_one_exception, print_mention_exception): Remove
 294         "ex" parameter.
 295         (allocate_location_catch_exception, re_set_catch_exception)
 296         (check_status_exception, print_it_catch_exception)
 297         (print_one_catch_exception, print_mention_catch_exception)
 298         (print_recreate_catch_exception)
 299         (allocate_location_catch_exception_unhandled)
 300         (re_set_catch_exception_unhandled)
 301         (check_status_exception, print_it_catch_exception_unhandled)
 302         (print_one_catch_exception_unhandled)
 303         (print_mention_catch_exception_unhandled)
 304         (print_recreate_catch_exception_unhandled)
 305         (allocate_location_catch_assert, re_set_catch_assert)
 306         (check_status_assert, print_it_catch_assert)
 307         (print_one_catch_assert, print_mention_catch_assert)
 308         (print_recreate_catch_assert)
 309         (allocate_location_catch_handlers, re_set_catch_handlers)
 310         (check_status_handlers, print_it_catch_handlers)
 311         (print_one_catch_handlers, print_mention_catch_handlers)
 312         (print_recreate_catch_handlers): Remove.
 313         (create_ada_exception_catchpoint): Update.
 314         (initialize_ada_catchpoint_ops): Update.
 315
 316 2019-10-02  Tom Tromey  <tromey@adacore.com>
 317
 318         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 319         (create_excep_cond_exprs): Simplify exception string computation.
 320         (ada_exception_catchpoint_cond_string): Likewise.
 321
 322 2019-10-02  Tom Tromey  <tromey@adacore.com>
 323
 324         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 325         * ada-lang.c (lesseq_defined_than): Handle
 326         LOC_STATIC.
 327         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 328         parameter.
 329         (dwarf2_has_info): Likewise.
 330         (new_symbol): Set maybe_copied on symbol when
 331         appropriate.
 332         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 333         parameter.
 334         <can_copy>: New member.
 335         * elfread.c (record_minimal_symbol): Set maybe_copied
 336         on symbol when appropriate.
 337         (elf_symfile_read): Update call to dwarf2_has_info.
 338         * minsyms.c (lookup_minimal_symbol_linkage): New
 339         function.
 340         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 341         * symtab.c (get_symbol_address, get_msymbol_address):
 342         New functions.
 343         * symtab.h (get_symbol_address, get_msymbol_address):
 344         Declare.
 345         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 346         maybe_copied.
 347         (struct symbol, struct minimal_symbol) <maybe_copied>:
 348         New member.
 349
 350 2019-10-02  Tom Tromey  <tromey@adacore.com>
 351
 352         * source.c (struct current_source_location): New.
 353         (current_source_key): New global.
 354         (current_source_symtab, current_source_line)
 355         (current_source_pspace): Remove.
 356         (get_source_location): New function.
 357         (get_current_source_symtab_and_line)
 358         (set_default_source_symtab_and_line)
 359         (set_current_source_symtab_and_line)
 360         (clear_current_source_symtab_and_line, select_source_symtab)
 361         (info_source_command, print_source_lines_base)
 362         (info_line_command, search_command_helper, _initialize_source):
 363         Update.
 364
 365 2019-10-02  Tom Tromey  <tromey@adacore.com>
 366
 367         * source.c (select_source_symtab): Don't call
 368         decode_line_with_current_source.
 369
 370 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * symtab.c (lookup_global_symbol): Search global block.
 373
 374 2019-10-02  Tom Tromey  <tromey@adacore.com>
 375
 376         * coffread.c (process_coff_symbol): Update.
 377         * dwarf2read.c (var_decode_location, new_symbol): Update.
 378         * mdebugread.c (parse_symbol): Update.
 379         * objfiles.c (relocate_one_symbol): Update.
 380         * stabsread.c (define_symbol, fix_common_block)
 381         (scan_file_globals): Update.
 382         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 383         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 384         * xcoffread.c (process_xcoff_symbol): Update.
 385
 386 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 387
 388         * MAINTAINERS: Update my email address.
 389
 390 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 393         std::vector.
 394         (build_type_psymtabs_reader): Update for std::vector.
 395         (build_type_psymtab_dependencies): Likewise.
 396         * dwarf2read.h: Remove use of DEF_VEC_P.
 397         (typedef sig_type_ptr): Delete.
 398
 399 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 400
 401         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 402         to std::vector.
 403         (btrace_maint_decode_pt): Likewise, and move allocation of the
 404         vector outside of the loop.
 405         (btrace_maint_update_packets): Update to handle change from VEC to
 406         std::vector.
 407         (btrace_maint_print_packets): Likewise.
 408         (maint_info_btrace_cmd): Likewise.
 409         * btrace.h: Remove use of DEF_VEC_O.
 410         (typedef btrace_pt_packet_s): Delete.
 411         (struct btrace_maint_info) <packets>: Change fromm VEC to
 412         std::vector.
 413         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 414
 415 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 418         make accesses into the vector constant references.
 419         (btrace_add_pc): Update for std::vector.
 420         (btrace_stitch_bts): Likewise.
 421         (parse_xml_btrace_block): Likewise.
 422         (btrace_maint_update_packets): Likewise.
 423         (btrace_maint_print_packets): Likewise.
 424         (maint_info_btrace_cmd): Likewise.
 425         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 426         std::vector.
 427         (btrace_data::empty): Likewise.
 428         (btrace_data_append): Likewise.
 429         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 430         (typedef btrace_block_s): Delete.
 431         (struct btrace_block): Add constructor.
 432         (struct btrace_data_bts) <blocks>: Change to std::vector.
 433         * nat/linux-btrace.c (perf_event_read_bts): Update for
 434         std::vector.
 435         (linux_read_bts): Likewise.
 436
 437 2019-10-01  Tom Tromey  <tom@tromey.com>
 438
 439         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 440
 441 2019-10-01  Tom Tromey  <tom@tromey.com>
 442
 443         * stack.c (print_frame, info_frame_command_core): Use
 444         styled_string.
 445         * linux-thread-db.c (try_thread_db_load_1)
 446         (try_thread_db_load_from_pdir_1): Use styled_string.
 447         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 448         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 449         (maybe_print_unsupported_script_warning)
 450         (maybe_print_script_not_found_warning): Use styled_string.
 451         * ada-lang.c (user_select_syms): Use styled_string.
 452
 453 2019-10-01  Tom Tromey  <tom@tromey.com>
 454
 455         * p-lang.c (pascal_printstr): Use metadata style.
 456         * value.c (show_convenience): Use metadata style.
 457         * valprint.c (valprint_check_validity, val_print_optimized_out)
 458         (val_print_not_saved, val_print_unavailable)
 459         (val_print_invalid_address, generic_val_print, val_print)
 460         (value_check_printable, val_print_array_elements): Use metadata
 461         style.
 462         * ui-out.h (class ui_out) <field_fmt>: New overload.
 463         <do_field_fmt>: Add style parameter.
 464         * ui-out.c (ui_out::field_fmt): New overload.
 465         * typeprint.c (type_print_unknown_return_type)
 466         (val_print_not_allocated, val_print_not_associated): Use metadata
 467         style.
 468         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 469         parameter.
 470         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 471         * tracepoint.c (tvariables_info_1): Use metadata style.
 472         * stack.c (print_frame_arg, print_frame_info, print_frame)
 473         (info_frame_command_core): Use metadata style.
 474         * skip.c (info_skip_command): Use metadata style.
 475         * rust-lang.c (rust_print_enum): Use metadata style.
 476         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 477         metadata style.
 478         * python/py-framefilter.c (py_print_single_arg): Use metadata
 479         style.
 480         * printcmd.c (do_one_display, print_variable_and_value): Use
 481         metadata style.
 482         * p-valprint.c (pascal_val_print)
 483         (pascal_object_print_value_fields): Use metadata style.
 484         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 485         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 486         parameter.
 487         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 488         * m2-valprint.c (m2_print_long_set): Use metadata style.
 489         * m2-typeprint.c (m2_print_type): Use metadata style.
 490         * infcmd.c (print_return_value_1): Use metadata style.
 491         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 492         * f-valprint.c (info_common_command_for_block): Use metadata
 493         style.
 494         * f-typeprint.c (f_type_print_base): Use metadata style.
 495         * expprint.c (print_subexp_standard): Use metadata style.
 496         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 497         * cli/cli-style.h (class cli_style_option): Add constructor.
 498         (metadata_style): Declare.
 499         * cli/cli-style.c (metadata_style): New global.
 500         (_initialize_cli_style): Register metadata style.
 501         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 502         parameter.
 503         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 504         * c-typeprint.c (c_type_print_base_struct_union)
 505         (c_type_print_base_1): Use metadata style.
 506         * breakpoint.c (watchpoint_value_print)
 507         (print_one_breakpoint_location): Use metadata style.
 508         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 509         style.
 510         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 511         style.
 512         * ada-valprint.c (val_print_packed_array_elements, printstr)
 513         (print_field_values, ada_val_print_ref, ada_val_print): Use
 514         metadata style.
 515         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 516         style.
 517         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 518         style.
 519         * ada-lang.c (user_select_syms): Use metadata style.
 520
 521 2019-10-01  Tom Tromey  <tom@tromey.com>
 522
 523         * cli/cli-cmds.c (pwd_command): Style output.
 524
 525 2019-10-01  Pedro Alves  <palves@redhat.com>
 526             Tom Tromey  <tom@tromey.com>
 527
 528         * symtab.c (print_symbol_info): Use %ps.
 529         (print_msymbol_info): Use %ps.
 530         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 531         * printcmd.c (print_variable_and_value): Use %ps.
 532         * macrocmd.c (show_pp_source_pos): Use %ps.
 533         * infrun.c (print_exited_reason): Use ui_out::message.
 534         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 535         (describe_other_breakpoints): Use ui_out::message and new
 536         formats.
 537         (say_where): Use new formats.
 538         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 539         and new formats.
 540
 541 2019-10-01  Pedro Alves  <palves@redhat.com>
 542             Tom Tromey  <tom@tromey.com>
 543
 544         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 545         (test_gdb_formats): New function.
 546         (run_tests): Call it.
 547         (test_format_specifier): Update.
 548         * utils.h (fputs_filtered): Update comment.
 549         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 550         (fputs_styled_unfiltered): Declare.
 551         * utils.c (fputs_styled_unfiltered): New function.
 552         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 553         (vfprintf_filtered): Update.
 554         (vfprintf_unfiltered, vprintf_filtered): Update.
 555         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 556         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 557         disallow_ui_out_field>: New constants.
 558         (enum class field_kind): New.
 559         (struct base_field_s, struct signed_field_s): New.
 560         (signed_field): New function.
 561         (struct string_field_s): New.
 562         (string_field): New function.
 563         (struct styled_string_s): New.
 564         (styled_string): New function.
 565         (class ui_out) <message>: Add comment.
 566         <vmessage, call_do_message>: New methods.
 567         <do_message>: Add style parameter.
 568         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 569         methods.
 570         (ui_out::message): Rewrite.
 571         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 572         parameter.
 573         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 574         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 575         gdb_extensions parameter.
 576         (class format_piece): Add parameter to constructor.
 577         (n_int_args): New field.
 578         * gdbsupport/format.c (format_pieces::format_pieces): Add
 579         gdb_extensions parameter.  Handle '*'.
 580         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 581         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 582         vfprintf_styled_no_gdbfmt.
 583         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 584         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 585         unfiltered output.
 586         * ui-style.h (struct ui_file_style) <ptr>: New method.
 587
 588 2019-10-01  Tom Tromey  <tom@tromey.com>
 589
 590         * unittests/format_pieces-selftests.c: Update.  Add final format.
 591         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 592         empty literal pieces.
 593
 594 2019-10-01  Tom Tromey  <tom@tromey.com>
 595
 596         * ui-out.h (enum class ui_out_style_kind): Remove.
 597         (class ui_out) <field_string, field_stsream, do_field_string>:
 598         Change type of "style".
 599         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 600         (ui_out::field_string): Update.
 601         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 602         of "style".
 603         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 604         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 605         * stack.c (print_frame_arg, print_frame_info, print_frame):
 606         Update.
 607         * source.c (print_source_lines_base): Update.
 608         * solib.c (info_sharedlibrary_command): Update.
 609         * skip.c (info_skip_command): Update.
 610         * record-btrace.c (btrace_call_history_src_line)
 611         (btrace_call_history): Update.
 612         * python/py-framefilter.c (py_print_frame): Update.
 613         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 614         "style".
 615         * mi/mi-out.c (mi_ui_out::do_table_header)
 616         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 617         (mi_ui_out::do_field_string): Update.
 618         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 619         Update.
 620         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 621         "style".
 622         * cli-out.c (cli_ui_out::do_table_header)
 623         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 624         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 625         (cli_ui_out::do_field_fmt): Update.
 626         * breakpoint.c (print_breakpoint_location): Update.
 627         (update_static_tracepoint): Update.
 628
 629 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 630
 631         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 632         conversion of gdb_datadir.
 633         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 634         remove not needed c_str ().
 635
 636 2019-09-30  Ali Tamur <tamur@google.com>
 637
 638         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 639         (dwarf2_string_attr): Likewise.
 640
 641 2019-09-30  Ali Tamur <tamur@google.com>
 642
 643         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 644         (process_full_type_unit): Likewise.
 645         (dump_die_shallow): Likewise.
 646         (cu_debug_loc_section): Likewise.
 647
 648 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 649
 650         * minsyms.c (compare_minimal_symbols): Rename to...
 651         (minimal_symbol_is_less_than): ...this, and adjust to STL
 652         conventions (return bool, take arguments as references)
 653         (minimal_symbol_reader::install): Call std::sort instead
 654         of qsort.
 655
 656 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 657
 658         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 659         hash and why.
 660         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 661         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 662
 663 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 664
 665         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 666         * psympriv.h (add_psymbol_to_list): Move comment here and update
 667         it.
 668
 669 2019-09-29  Tom de Vries  <tdevries@suse.de>
 670
 671         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 672         Use $tmpdir/$(basename "$output_file").dwz instead of
 673         "${output_file}.dwz".
 674
 675 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 676
 677         PR gdb/25045
 678         * hppa-linux-nat.c: Include gdbarch.h.
 679
 680 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 681
 682         * blockframe.c (find_pc_partial_function): Change return type to bool.
 683         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 684         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 685         (stub_gnu_ifunc_resolve_name): Likewise.
 686         * symtab.c (compare_filenames_for_search): Likewise.
 687         (compare_glob_filenames_for_search): Likewise.
 688         (matching_obj_sections): Likewise.
 689         (symbol_matches_domain): Likewise.
 690         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 691         (find_line_pc): Change return type to bool.
 692         (find_line_pc_range): Likewise.
 693         (producer_is_realview): Likewise.
 694         * symtab.h (symbol_matches_domain): Likewise.
 695         (find_pc_partial_function): Likewise.
 696         (find_pc_line_pc_range): Likewise.
 697         (in_gnu_ifunc_stub): Likewise.
 698         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 699         (find_line_pc): Likewise.
 700         (find_line_pc_range): Likewise.
 701         (matching_obj_sections): Likewise.
 702         (find_line_symtab): Change out parameter to bool.
 703         (producer_is_realview): Change return type to bool.
 704         (compare_filenames_for_search): Likewise.
 705         (compare_glob_filenames_for_search): Likewise.
 706
 707 2019-09-26  Tom Tromey  <tom@tromey.com>
 708
 709         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 710         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 711         * gdb_usleep.h: Remove.
 712         * gdb_usleep.c: Remove.
 713         * utils.c: Don't include gdb_usleep.h.
 714
 715 2019-09-26  Tom Tromey  <tromey@adacore.com>
 716
 717         * python/py-type.c (type_to_type_object): Call check_typedef
 718         for stub types.
 719
 720 2019-09-26  Tom Tromey  <tom@tromey.com>
 721
 722         * utils.h (initialize_utils): Don't declare.
 723         * top.c (gdb_init): Don't call initialize_utils.
 724         * utils.c (initialize_utils): Remove.  Move contents...
 725         (_initialize_utils): ... here.
 726
 727 2019-09-25  Tom Tromey  <tom@tromey.com>
 728
 729         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 730         * utils.h (make_hex_string): Don't declare.
 731         * utils.c (make_hex_string): Remove.
 732
 733 2019-09-24  Tom de Vries  <tdevries@suse.de>
 734
 735         PR gdb/23815
 736         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 737         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 738
 739 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 740
 741         * NEWS: Mention new simulator port for PRU.
 742
 743 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 744
 745         * ada-exp.y (write_object_remaining): Update.
 746         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 747         and eliminate the static buffer.
 748         (ada_decode_symbol): Update.
 749         (ada_la_decode): Update.
 750         (ada_sniff_from_mangled_name): Update.
 751         (is_valid_name_for_wild_match): Update.
 752         (ada_lookup_name_info::matches): Update and simplify.
 753         (name_matches_regex): Update.
 754         (ada_add_global_exceptions): Update.
 755         * ada-lang.h (ada_decode): Update signature.
 756         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 757         * dwarf-index-write.c (debug_names::insert): Update.
 758
 759 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 760
 761         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 762         formatting.
 763
 764 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 765
 766         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 767         Change "nonzero" to "true" in documentation.
 768
 769 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 770
 771         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 772         (_initialize_darwin_solib): Don't set
 773         darwin_so_ops.lookup_lib_global_symbol.
 774         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 775         set_gdbarch_iterate_over_objfiles_in_search_order.
 776         (elf_lookup_lib_symbol): Rename to...
 777         (svr4_iterate_over_objfiles_in_search_order): this, and update
 778         to iterate semantics.
 779         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 780         * solib.c (solib_global_lookup): Remove.
 781         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 782         (solib_global_lookup): Remove.
 783         * symtab.c (lookup_global_or_static_symbol): Remove call to
 784         solib_global_lookup.
 785
 786 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 787
 788         * NEWS: Move entries about default MI version now being
 789         version 3, and about the GDB/MI fix for multi-location
 790         breakpoints to the "since GDB 8.3" section.
 791
 792 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 793
 794         GDB 8.3.1 released.
 795
 796 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 797
 798         * NEWS: Mention that Cell/B.E. debugging support was removed.
 799         * MAINTAINERS: Remove spu target.
 800
 801         * config/djgpp/fnchange.lst: Remove entries for removed files.
 802
 803         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 804         spu-multiarch.o, and spu-tdep.o.
 805         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 806         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 807         spu-multiarch.c, and spu-tdep.c.
 808         * spu-linux-nat.c: Remove file.
 809         * spu-multiarch.c: Remove file.
 810         * spu-tdep.c: Remove file.
 811         * spu-tdep.h: Remove file.
 812         * solib-spu.c: Remove file.
 813         * solib-spu.h: Remove file.
 814
 815         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 816         * configure.nat (spu-linux): Remove.
 817         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 818         solib-multiarch.o from gdb_target_obs.
 819         (spu*-*-*): Remove.
 820
 821         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 822         feature flag.
 823         (ppc_linux_no_features): Update.
 824         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 825         Cell/B.E. support.
 826         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 827         (tdesc_powerpc_cell64l): Likewise.
 828         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 829         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 830         Cell/B.E. support.
 831         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 832         Do not include "features/rs6000/powerpc-cell32l.c" or
 833         "features/rs6000/powerpc-cell64l.c".
 834         (ppc_linux_spu_section): Remove.
 835         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 836         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 837         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 838         (ppc_linux_spe_context_lookup): Remove.
 839         (ppc_linux_spe_context_inferior_created): Remove.
 840         (ppc_linux_spe_context_solib_loaded): Remove.
 841         (ppc_linux_spe_context_solib_unloaded): Remove.
 842         (ppc_linux_spe_context): Remove.
 843         (struct ppu2spu_cache): Remove.
 844         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 845         (struct ppu2spu_data): Remove.
 846         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 847         ppu2spu_unwind): Remove.
 848         (ppc_linux_init_abi): Remove Cell/B.E. support.
 849         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 850
 851         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 852         (rs6000/powerpc-cell64l-expedite): Likewise
 853         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 854         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 855         rs6000/powerpc-cell64l.xml.
 856         * features/rs6000/powerpc-cell32l.xml: Remove.
 857         * features/rs6000/powerpc-cell64l.xml: Likewise.
 858         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 859         * features/rs6000/powerpc-cell64l.c: Likewise.
 860         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 861         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 862         * regformats/reg-spu.dat: Remove.
 863
 864         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 865         * corelow.c (struct spuid_list): Remove.
 866         (add_to_spuid_list): Remove.
 867         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 868         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 869         (remote_protocol_features): Remove associated entries.
 870         (_initialize_remote): No longer initialize them.
 871         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 872         * linux-nat.c (SPUFS_MAGIC): Remove.
 873         (linux_proc_xfer_spu): Remove.
 874         (spu_enumerate_spu_ids): Remove.
 875         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 876         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 877         (linux_make_corefile_notes): No longer call it.
 878
 879         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 880         (cooked_write_test): Likewise.
 881
 882 2019-09-20  Tom Tromey  <tom@tromey.com>
 883
 884         * NEWS: Mention case-sensitivity of TUI commands.
 885         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 886         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 887         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 888
 889 2019-09-20  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-source.c (tui_source_window::set_contents): Use
 892         make_unique_xstrdup.
 893         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 894         make_unique_xstrdup.
 895
 896 2019-09-20  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-data.c: Remove separator comments.
 899         * tui/tui-layout.c: Remove separator comments.
 900         * tui/tui-win.c: Remove separator comments.
 901         * tui/tui-wingeneral.c: Remove separator comments.
 902
 903 2019-09-20  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui.h (strcat_to_buf): Don't declare.
 906         * tui/tui.c (strcat_to_buf): Remove.
 907
 908 2019-09-20  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 911         from "fullname".
 912         * tui/tui-source.c (tui_source_window::set_contents)
 913         (tui_source_window::location_matches_p)
 914         (tui_source_window::maybe_update): Update.
 915
 916 2019-09-20  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 919         Update.
 920         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 921         prefix.
 922         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 923         (tui_data_window::line_from_reg_element_no)
 924         (tui_data_window::first_reg_element_no_inline)
 925         (tui_data_window::show_registers)
 926         (tui_data_window::show_register_group)
 927         (tui_data_window::display_registers_from)
 928         (tui_data_window::display_registers_from_line)
 929         (tui_data_window::first_data_item_displayed)
 930         (tui_data_window::delete_data_content_windows)
 931         (tui_data_window::erase_data_content)
 932         (tui_data_window::do_scroll_vertical)
 933         (tui_data_window::refresh_window)
 934         (tui_data_window::check_register_values): Update.
 935
 936 2019-09-20  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 939         (struct tui_locator_window) <full_name, proc_name>: Now
 940         std::string.
 941         * tui/tui-stack.c (tui_locator_window::make_status_line)
 942         (tui_locator_window::set_locator_fullname)
 943         (tui_locator_window::set_locator_info): Update.
 944         * tui/tui-source.c (tui_source_window::set_contents)
 945         (tui_source_window::showing_source_p): Update.
 946
 947 2019-09-20  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 950         Don't call tui_locator_win_info_ptr.
 951
 952 2019-09-20  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 955
 956 2019-09-20  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 959         height for locator.
 960         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 961         * tui/tui-layout.c (show_source_disasm_command, show_data)
 962         (show_source_or_disasm_and_command): Use 1 as height for locator.
 963
 964 2019-09-20  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui.c (tui_enable): Update.
 967         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 968         Update.
 969         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 970         Update.
 971         * tui/tui-data.c (win_resized): Now bool.
 972         (tui_win_resized): Return bool.
 973         (tui_set_win_resized_to): Accept a bool.
 974
 975 2019-09-20  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 978         Change type of "refresh_values_only".
 979         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 980         type of "refresh_values_only".
 981
 982 2019-09-20  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 985         std::string.
 986         (tui_disassemble): Add "pos" parameter.
 987         (tui_disasm_window::set_contents): Simplify.
 988
 989 2019-09-20  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-winsource.h (struct tui_source_window_base)
 992         <show_source_content>: Now private.
 993         * tui/tui-winsource.c
 994         (tui_source_window_base::show_source_content): Don't handle empty
 995         content case.
 996
 997 2019-09-20  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-layout.c (show_source_disasm_command)
1000         (show_source_or_disasm_and_command): Don't call
1001         show_source_content.
1002
1003 2019-09-20  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1006         Declare.
1007         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1008         from tui_make_status_line.
1009         (tui_locator_window::rerender): Update.
1010
1011 2019-09-20  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1014         (tui_locator_window::rerender): Update.
1015
1016 2019-09-20  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-winsource.h (struct tui_source_window_base)
1019         <~tui_source_window_base>: Don't declare.
1020         <fullname>: Remove.
1021         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1022         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1023         member.
1024         * tui/tui-source.c (tui_source_window::set_contents): Update.
1025         (tui_source_window::location_matches_p)
1026         (tui_source_window::maybe_update): Update.
1027
1028 2019-09-20  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.h (~tui_source_element): Remove.
1031         (tui_source_element): Update.
1032         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1033         * tui/tui-winsource.c (tui_show_source_line): Update.
1034         * tui/tui-source.c (tui_source_window::set_contents): Update.
1035         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1036
1037 2019-09-20  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1040         declare.
1041         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1042         tui_clear_source_windows_detail.
1043         * tui/tui-winsource.h (struct tui_source_window_base)
1044         <clear_detail>: Don't declare.
1045         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1046         Remove.
1047         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1048
1049 2019-09-20  Tom Tromey  <tromey@adacore.com>
1050
1051         PR ada/24919:
1052         * block.c (contained_in): Fix final return value.
1053
1054 2019-09-20  Alan Modra  <amodra@gmail.com>
1055
1056         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1057         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1058         (read_indirect_string_from_dwz): Use bfd accessor.
1059         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1060         * machoread.c (macho_symfile_read_all_oso): Likewise.
1061         * solib.c (solib_bfd_open): Likewise.
1062
1063 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1064
1065         * eval.c: Move declaration of overload_resolution to...
1066         * value.h: ...here.
1067
1068 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1069
1070         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1071         * arm-linux-tdep.c: Likewise.
1072         * arm-nbsd-nat.c: Likewise.
1073         * arm-tdep.h: Declare arm_apcs_32.
1074         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1075
1076 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1077
1078         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1079         * dwarf2read.h: Declare dwarf_always_disassemble.
1080
1081 2019-09-19  Tom de Vries  <tdevries@suse.de>
1082
1083         PR gdb/25009
1084         * source-cache.c (source_cache::ensure): Catch exception thrown during
1085         construction of the highlighter.
1086
1087 2019-09-18  Alan Modra  <amodra@gmail.com>
1088
1089         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1090         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1091         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1092         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1093         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1094         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1095         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1096         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1097         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1098         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1099         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1100         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1101         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1102         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1103         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1104         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1105         * mi/mi-interp.c: Update throughout for bfd section macro and
1106         function changes.
1107         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1108         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1109
1110 2019-09-18  Tom Tromey  <tom@tromey.com>
1111
1112         * NEWS: Add entry.
1113         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1114         call rl_initialize.
1115         (tui_enable): Do not call rl_initialize.
1116
1117 2019-09-18  Christian Groessler  <chris@groessler.org>
1118
1119         * alpha-linux-nat.c: Include gdbarch.h.
1120
1121 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1122
1123         * ui-file.c: Include cli/cli-style.h.
1124         (term_cli_styling): Remove cli_styling declaration.
1125
1126 2019-09-18  Alan Modra  <amodra@gmail.com>
1127
1128         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1129         to bfd_asymbol_section.
1130
1131 2019-09-18  Alan Modra  <amodra@gmail.com>
1132
1133         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1134         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1135         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1136
1137 2019-09-18  Alan Modra  <amodra@gmail.com>
1138
1139         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1140         * spu-linux-nat.c (spu_bfd_open): Likewise.
1141
1142 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1143
1144         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1145         to bool to match definition in dwarf2read.c.
1146
1147 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1148
1149         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1150         (print_signatures): Likewise.
1151         (trust_pad_over_xvs): Likewise.
1152         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1153         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1154         * arm-linux-nat.c (arm_apcs_32): Likewise.
1155         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1156         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1157         * arm-tdep.c (arm_debug): Likewise.
1158         (arm_apcs_32): Likewise.
1159         * auto-load.c (debug_auto_load): Likewise.
1160         (auto_load_gdb_scripts): Likewise.
1161         (global_auto_load): Likewise.
1162         (auto_load_local_gdbinit): Likewise.
1163         (auto_load_local_gdbinit_loaded): Likewise.
1164         * auto-load.h (global_auto_load): Likewise.
1165         (auto_load_local_gdbinit): Likewise.
1166         (auto_load_local_gdbinit_loaded): Likewise.
1167         * breakpoint.c (disconnected_dprintf): Likewise.
1168         (breakpoint_proceeded): Likewise.
1169         (automatic_hardware_breakpoints): Likewise.
1170         (always_inserted_mode): Likewise.
1171         (target_exact_watchpoints): Likewise.
1172         (_initialize_breakpoint): Update.
1173         * breakpoint.h (target_exact_watchpoints): Change to bool.
1174         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1175         * cli/cli-cmds.c (trace_commands): Likewise.
1176         * cli/cli-cmds.h (trace_commands): Likewise.
1177         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1178         to bool*.
1179         * cli/cli-logging.c (logging_overwrite): Change to bool.
1180         (logging_redirect): Likewise.
1181         (debug_redirect): Likewise.
1182         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1183         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1184         to bool.
1185         <boolean_option_def>: Update.
1186         (struct flag_option_def): Change default type of Context to bool
1187         from int.
1188         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1189         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1190         (get_setshow_command_value_string): Likewise.
1191         * cli/cli-style.c (cli_styling): Change to bool.
1192         (source_styling): Likewise.
1193         * cli/cli-style.h (source_styling): Likewise.
1194         (cli_styling): Likewise.
1195         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1196         to bool.
1197         * command.h (var_types): Update comment.
1198         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1199         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1200         bool.
1201         (debug_compile_cplus_scopes): Likewise.
1202         * compile/compile-internal.h (compile_debug): Likewise.
1203         * compile/compile.c (compile_debug): Likewise.
1204         (struct compile_options) <raw>: Likewise.
1205         * cp-support.c (catch_demangler_crashes): Likewise.
1206         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1207         (usr_cmd_cris_dwarf2_cfi): Likewise.
1208         * csky-tdep.c (csky_debug): Likewise.
1209         * darwin-nat.c (enable_mach_exceptions): Likewise.
1210         * dcache.c (dcache_enabled_p): Likewise.
1211         * defs.h (info_verbose): Likewise.
1212         * demangle.c (demangle): Likewise.
1213         (asm_demangle): Likewise.
1214         * dwarf-index-cache.c (debug_index_cache): Likewise.
1215         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1216         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1217         * dwarf2read.c (check_physname): Likewise.
1218         (use_deprecated_index_sections): Likewise.
1219         (dwarf_always_disassemble): Likewise.
1220         * eval.c (overload_resolution): Likewise.
1221         * event-top.c (set_editing_cmd_var): Likewise.
1222         (exec_done_display_p): Likewise.
1223         * event-top.h (set_editing_cmd_var): Likewise.
1224         (exec_done_display_p): Likewise.
1225         * exec.c (write_files): Likewise.
1226         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1227         (debug_fbsd_nat): Likewise.
1228         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1229         Likewise.
1230         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1231         <backtrace_past_entry> Likewise.
1232         * gdb-demangle.h (demangle): Likewise.
1233         (asm_demangle): Likewise.
1234         * gdb_bfd.c (bfd_sharing): Likewise.
1235         * gdbcore.h (write_files): Likewise.
1236         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1237         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1238         * gdbthread.h (print_thread_events): Likewise.
1239         * gdbtypes.c (opaque_type_resolution): Likewise.
1240         (strict_type_checking): Likewise.
1241         * gnu-nat.c (gnu_debug_flag): Likewise.
1242         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1243         * guile/scm-param.c (pascm_variable): Add boolval.
1244         (add_setshow_generic): Update.
1245         (pascm_param_value): Update.
1246         (pascm_set_param_value_x): Update.
1247         * hppa-tdep.c (hppa_debug): Change to bool..
1248         * infcall.c (may_call_functions_p): Likewise.
1249         (coerce_float_to_double_p): Likewise.
1250         (unwind_on_signal_p): Likewise.
1251         (unwind_on_terminating_exception_p): Likewise.
1252         * infcmd.c (startup_with_shell): Likewise.
1253         * inferior.c (print_inferior_events): Likewise.
1254         * inferior.h (startup_with_shell): Likewise.
1255         (print_inferior_events): Likewise.
1256         * infrun.c (step_stop_if_no_debug): Likewise.
1257         (detach_fork): Likewise.
1258         (debug_displaced): Likewise.
1259         (disable_randomization): Likewise.
1260         (non_stop): Likewise.
1261         (non_stop_1): Likewise.
1262         (observer_mode): Likewise.
1263         (observer_mode_1): Likewise.
1264         (set_observer_mode): Update.
1265         (sched_multi): Change to bool.
1266         * infrun.h (debug_displaced): Likewise.
1267         (sched_multi): Likewise.
1268         (step_stop_if_no_debug): Likewise.
1269         (non_stop): Likewise.
1270         (disable_randomization): Likewise.
1271         * linux-tdep.c (use_coredump_filter): Likewise.
1272         (dump_excluded_mappings): Likewise.
1273         * linux-thread-db.c (auto_load_thread_db): Likewise.
1274         (check_thread_db_on_load): Likewise.
1275         * main.c (captured_main_1): Update.
1276         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1277         xx2_opt, boolean_opt>: Change to bool.
1278         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1279         * maint.c (maintenance_profile_p): Likewise.
1280         (per_command_time): Likewise.
1281         (per_command_space): Likewise.
1282         (per_command_symtab): Likewise.
1283         * memattr.c (inaccessible_by_default): Likewise.
1284         * mi/mi-main.c (mi_async): Likewise.
1285         (mi_async_1): Likewise.
1286         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1287         * nat/fork-inferior.h (startup_with_shell): Likewise.
1288         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1289         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1290         * nios2-tdep.c (nios2_debug): Likewise.
1291         * or1k-tdep.c (or1k_debug): Likewise.
1292         * parse.c (parser_debug): Likewise.
1293         * parser-defs.h (parser_debug): Likewise.
1294         * printcmd.c (print_symbol_filename): Likewise.
1295         * proc-api.c (procfs_trace): Likewise.
1296         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1297         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1298         (set_parameter_value): Update.
1299         (add_setshow_generic): Update.
1300         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1301         to bool*.
1302         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1303         int*.
1304         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1305         * record-btrace.c (record_btrace_target::store_registers): Update.
1306         * record-full.c (record_full_memory_query): Change to bool.
1307         (record_full_stop_at_limit): Likewise.
1308         * record-full.h (record_full_memory_query): Likewise.
1309         * remote-notif.c (notif_debug): Likewise.
1310         * remote-notif.h (notif_debug): Likewise.
1311         * remote.c (use_range_stepping): Likewise.
1312         (interrupt_on_connect): Likewise.
1313         (remote_break): Likewise.
1314         * ser-tcp.c (tcp_auto_retry): Likewise.
1315         * ser-unix.c (serial_hwflow): Likewise.
1316         * skip.c (debug_skip): Likewise.
1317         * solib-aix.c (solib_aix_debug): Likewise.
1318         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1319         (spu_auto_flush_cache_p): Likewise.
1320         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1321         Likewise.
1322         (struct info_print_options) <quiet>: Likewise.
1323         * symfile-debug.c (debug_symfile): Likewise.
1324         * symfile.c (auto_solib_add): Likewise.
1325         (separate_debug_file_debug): Likewise.
1326         * symfile.h (auto_solib_add): Likewise.
1327         (separate_debug_file_debug): Likewise.
1328         * symtab.c (basenames_may_differ): Likewise.
1329         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1330         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1331         (struct info_types_options) <quiet>: Likewise.
1332         * symtab.h (demangle): Likewise.
1333         (basenames_may_differ): Likewise.
1334         * target-dcache.c (stack_cache_enabled_1): Likewise.
1335         (code_cache_enabled_1): Likewise.
1336         * target.c (trust_readonly): Likewise.
1337         (may_write_registers): Likewise.
1338         (may_write_memory): Likewise.
1339         (may_insert_breakpoints): Likewise.
1340         (may_insert_tracepoints): Likewise.
1341         (may_insert_fast_tracepoints): Likewise.
1342         (may_stop): Likewise.
1343         (auto_connect_native_target): Likewise.
1344         (target_stop_and_wait): Update.
1345         (target_async_permitted): Change to bool.
1346         (target_async_permitted_1): Likewise.
1347         (may_write_registers_1): Likewise.
1348         (may_write_memory_1): Likewise.
1349         (may_insert_breakpoints_1): Likewise.
1350         (may_insert_tracepoints_1): Likewise.
1351         (may_insert_fast_tracepoints_1): Likewise.
1352         (may_stop_1): Likewise.
1353         * target.h (target_async_permitted): Likewise.
1354         (may_write_registers): Likewise.
1355         (may_write_memory): Likewise.
1356         (may_insert_breakpoints): Likewise.
1357         (may_insert_tracepoints): Likewise.
1358         (may_insert_fast_tracepoints): Likewise.
1359         (may_stop): Likewise.
1360         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1361         (make_thread_apply_all_options_def_group): Change argument from int*
1362         to bool*.
1363         (thread_apply_all_command): Update.
1364         (print_thread_events): Change to bool.
1365         * top.c (confirm): Likewise.
1366         (command_editing_p): Likewise.
1367         (history_expansion_p): Likewise.
1368         (write_history_p): Likewise.
1369         (info_verbose): Likewise.
1370         * top.h (confirm): Likewise.
1371         (history_expansion_p): Likewise.
1372         * tracepoint.c (disconnected_tracing): Likewise.
1373         (circular_trace_buffer): Likewise.
1374         * typeprint.c (print_methods): Likewise.
1375         (print_typedefs): Likewise.
1376         * utils.c (debug_timestamp): Likewise.
1377         (sevenbit_strings): Likewise.
1378         (pagination_enabled): Likewise.
1379         * utils.h (sevenbit_strings): Likewise.
1380         (pagination_enabled): Likewise.
1381         * valops.c (overload_resolution): Likewise.
1382         * valprint.h (struct value_print_options) <prettyformat_arrays,
1383         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1384         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1385         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1386         Likewise.
1387         * windows-nat.c (new_console): Likewise.
1388         (cygwin_exceptions): Likewise.
1389         (new_group): Likewise.
1390         (debug_exec): Likewise.
1391         (debug_events): Likewise.
1392         (debug_memory): Likewise.
1393         (debug_exceptions): Likewise.
1394         (useshell): Likewise.
1395         * windows-tdep.c (maint_display_all_tib): Likewise.
1396         * xml-support.c (debug_xml): Likewise.
1397
1398 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1399
1400         * source.c (prepare_path_for_appending): New function.
1401         (openp): Make use of new function.
1402         (find_and_open_source): Search for the compilation directory and
1403         source file as a relative path beneath the directory search path.
1404
1405 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * source-cache.c (source_cache::get_line_charpos): Catch
1408         exceptions and return false, this matches the behaviour documented
1409         in the header file.
1410
1411 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1412
1413         * ada-tasks.c (info_task): Remove quoting of the task's name.
1414
1415 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1416
1417         * symfile.c (auto_solib_add): Replace comment with a reference
1418         to the header file.
1419
1420 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1421
1422         * NEWS: Mention that gdb can now be compiled with Python 3
1423         on Windows.
1424
1425 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * maint.c (maint_print_section_data::maint_print_section_data):
1428         Force use of 'float log10 (float)' by casting the argument to
1429         float.
1430
1431 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1432
1433         * maint.c: Add 'cmath' include.
1434         (struct maint_print_section_data): New structure.
1435         (print_section_index): New function.
1436         (print_bfd_section_info): Add header comment, small whitespace
1437         cleanup, and update to call new print_section_index function.
1438         (print_objfile_section_info): Likewise.
1439         (maint_obj_section_from_bfd_section): New function.
1440         (print_bfd_section_info_maybe_relocated): New function.
1441         (maintenance_info_sections): Add header comment, always use
1442         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1443
1444 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1445
1446         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1447         inner scope, add check that the objfile has psymtabs before
1448         checking psymtabs_addrmap.
1449         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1450
1451 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1452
1453         * NEWS: Announce that Ada task names are now shown at more places,
1454         and between quotes (except in info task output).
1455         * gdb/ada-tasks.c (task_to_str): New function.
1456         (display_current_task_id): Call task_to_str.
1457         (task_command_1): Likewise.
1458         (print_ada_task_info): In non-mi mode, Properly align headers and data
1459         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1460
1461 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1462
1463         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1464         prstatus.pr_lwp.pr_info instead of making it up.
1465
1466 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1467
1468         * auto-load.c (auto_load_expand_dir_vars): Update.
1469         * defs.h (gdb_datadir): Change to std::string.
1470         (python_libdir): Likewise.
1471         (relocate_gdb_directory): Change return type to std::string.
1472         * guile/guile.c (gdbscm_data_directory): Update.
1473         (initialize_scheme_side): Update.
1474         * jit.c (jit_reader_dir): Change to std::string.
1475         (jit_reader_load_command): Update.
1476         * main.c (gdb_datadir): Change to std::string.
1477         (python_libdir): Likewise.
1478         (set_gdb_data_directory): Update.
1479         (relocate_path): Change to return std::string.
1480         (relocate_gdb_directory): Change to return std::string.
1481         (relocate_gdbinit_path_maybe_in_datadir): Update.
1482         (captured_main_1): Update.
1483         * python/python.c (do_start_initialization): Update.
1484         * top.c (show_gdb_datadir): Update.
1485         * xml-syscall.c (xml_init_syscalls_info): Update.
1486         (init_syscalls_info): Update.
1487
1488 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1489
1490         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1491         out of get_init_files.
1492         (get_init_files): Update.
1493
1494 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1495
1496         * main.c (get_init_files): Change to use std::string.
1497         (captured_main_1): Update.
1498         (print_gdb_help): Update.
1499
1500 2019-09-11  Ali Tamur  <tamur@google.com>
1501
1502         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1503         implementation.
1504
1505 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1506
1507         * dbxread.c (read_dbx_symtab): Update.
1508         * dwarf2read.c (load_partial_dies): Update.
1509         * mdebugread.c (parse_partial_symbols): Update.
1510         (handle_psymbol_enumerators): Update.
1511         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1512         * psymtab.c (add_psymbol_to_bcache): Likewise.
1513         (add_psymbol_to_list): Likewise.
1514         * symtab.c (symbol_set_names): Likewise.
1515         * symtab.h (symbol_set_names): Likewise.
1516         * xcoffread.c (scan_xcoff_symtab): Update.
1517
1518 2019-09-11  Tom Tromey  <tom@tromey.com>
1519
1520         * symfile-mem.c (symbol_file_add_from_memory): Use
1521         bfd_set_filename.
1522         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1523         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1524
1525 2019-09-10  Tom Tromey  <tromey@adacore.com>
1526
1527         * dwarf-index-write.c (write_psymbols): Extend error message.
1528         (debug_names::insert): Add Ada code.
1529         (debug_names::write_psymbols): Remove Ada check.
1530         (debug_names) <m_string_obstack>: New member.
1531         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1532         (gdb_index_symbol_name_matcher::matches): Remove.
1533         (mapped_index_base::find_name_components_bounds): Add "lang"
1534         parameter.
1535         (mapped_index_base::build_name_components): Also split names
1536         according to Ada syntax.
1537         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1538         type of "match_callback".
1539         (check_match, check_find_bounds_finds)
1540         (dw2_expand_symtabs_matching): Update.
1541         (dw2_debug_names_iterator): Add new constructor.
1542         (dw2_debug_names_map_matching_symbols): New function.
1543         (dw2_debug_names_expand_symtabs_matching): Update.
1544         (dwarf2_debug_names_functions): Use
1545         dw2_debug_names_map_matching_symbols.
1546
1547 2019-09-10  Tom Tromey  <tromey@adacore.com>
1548
1549         * dwarf2read.c (dw2_get_file_names_reader): Add the
1550         CU's file name to the results.
1551
1552 2019-09-10  Tom Tromey  <tromey@adacore.com>
1553
1554         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1555         map_matching_symbols.  Update.
1556         * dwarf2read.c (dw2_map_matching_symbols): Update.
1557         * psymtab.c (match_partial_symbol): Change type; update.
1558         (psym_map_matching_symbols): Likewise.
1559         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1560         type; update.
1561         * symfile.h (struct quick_symbol_functions)
1562         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1563         Remove "match".
1564
1565 2019-09-10  Tom Tromey  <tromey@adacore.com>
1566
1567         * psymtab.c (map_block): Remove.
1568         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1569         * symtab.c (iterate_over_symbols_terminated): New function.
1570         * symtab.c (iterate_over_symbols_terminated): Declare.
1571
1572 2019-09-10  Tom Tromey  <tromey@adacore.com>
1573
1574         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1575         * language.h (struct language_defn) <la_iterate_over_symbols>:
1576         Return bool.
1577         * symtab.c (iterate_over_symbols): Return bool.
1578         * symtab.h (iterate_over_symbols): Return bool.
1579
1580 2019-09-10  Tom Tromey  <tromey@adacore.com>
1581
1582         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1583         (add_nonlocal_symbols): Update.
1584         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1585         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1586         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1587         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1588         Change type of "callback".  Remove "data".
1589
1590
1591 2019-09-09  Ali Tamur  <tamur@google.com>
1592
1593         * dwarf2read.c (comp_unit_head): Update comment.
1594         (dwarf2_dwo_name): New function declaration.
1595         (dwarf_unit_type_name): New function declaration.
1596         (read_comp_unit_head): Add support for new compilation units,
1597         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1598         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1599         (currently named as "signature") in their header. Also clarify error
1600         messages.
1601         (lookup_dwo_id): New function. Returns the dwo id of the given
1602         compile unit.
1603         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1604         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1605         functions.
1606         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1607         (dwarf2_dwo_name): Get the dwo name if present.
1608         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1609         purposes.
1610
1611 2019-09-09  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1614
1615 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1616
1617         * python/python.c (do_start_initialization): Make progname_copy static,
1618         to avoid a leak report.
1619
1620 2019-09-08  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1623
1624 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1625
1626         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1627         Change type to gdb::optional<block_enum>.
1628         (dw2_symtab_iter_init): Change block_index parameter type
1629         to gdb::optional<block_enum>.
1630         (dw2_lookup_symbol): Change block_index parameter
1631         type to block_enum.c
1632         (dw2_debug_names_lookup_symbol): Likewise.
1633         * psymtab.c (psym_lookup_symbol): Likewise.
1634         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1635         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1636         Likewise.
1637
1638 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1639
1640         * defs.h (relocate_gdb_directory): Change int to bool in
1641         signature and rename flag to relocatable.
1642         * main.c (relocate_path): Likewise.
1643         (relocate_gdb_directory): Likewise.
1644
1645 2019-09-06  Alan Modra  <amodra@gmail.com>
1646
1647         * coffread.c (coff_symfile_read): Constify filename variable.
1648         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1649         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1650         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1651         * solib.c (reload_shared_libraries_1): Likewise.
1652         * symfile.c (reread_symbols): Likewise.
1653         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1654         * solib-darwin.c (darwin_bfd_open): Likewise.
1655         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1656
1657 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1660         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1661
1662 2019-09-03  Tom Tromey  <tromey@adacore.com>
1663
1664         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1665         types.
1666         (has_negatives): Unbias a range type bound.
1667         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1668         * gdbtypes.c (operator==): Handle new field.
1669         (create_range_type): Add "bias" parameter.
1670         (create_static_range_type, resolve_dynamic_range): Update.
1671         * gdbtypes.h (struct range_bounds) <bias>: New member.
1672         (create_range_type): Add bias parameter.
1673         * printcmd.c (print_scalar_formatted): Unbias range types.
1674         * value.c (unpack_long): Unbias range types.
1675         (pack_long): Bias range types.
1676
1677 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1678
1679         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1680         probe arguments.
1681
1682 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1683
1684         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1685         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1686         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1687         (compile_probe_arg): Likewise.
1688         * probe.h (get_argument_count): Likewise.
1689         * solib-svr4.c (solib_event_probe_action): Likewise.
1690         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1691
1692 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1693
1694         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1695         code to here...
1696         (svr4_create_solib_event_breakpoints): ...from here.
1697
1698 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1699
1700         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1701         suffix from warning message.
1702
1703 2019-08-30  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-winsource.h (struct tui_source_window_base)
1706         <refresh_all>: Don't declare.
1707         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1708         Remove.
1709         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1710         tui_show_locator_content.
1711         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1712         declare.
1713         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1714         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1715         declare.
1716
1717 2019-08-30  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1720
1721 2019-08-30  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1724         Remove unnecessary forward declarations.
1725
1726 2019-08-30  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1729         rerender.
1730         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1731         tui_show_locator_content.
1732
1733 2019-08-30  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1736         (tui_locator_window::rerender): Rewrite using body of previous
1737         tui_show_locator_content.
1738
1739 2019-08-30  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1742         set_locator_fullname>: New methods.
1743         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1744         Rename from tui_set_locator_fullname.
1745         (tui_locator_window::set_locator_info): Rename from
1746         tui_set_locator_info.  Return bool.
1747         (tui_update_locator_fullname, tui_show_frame_info): Update.
1748
1749 2019-08-30  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1752
1753 2019-08-30  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1756         call touchwin.
1757
1758 2019-08-30  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-wingeneral.c (box_win): Assume win_info and
1761         win_info->handle cannot be NULL.
1762
1763 2019-08-30  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1766         refresh_window>: Declare.
1767         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1768         resize.
1769         (tui_data_item_window::rerender): Rename from
1770         tui_display_register.
1771         (tui_data_item_window::refresh_window): New method.
1772         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1773         no-op.
1774
1775 2019-08-30  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1778         regs_column_count, current_group>: Move later.  Now private.
1779         <get_current_group>: New method.
1780         * tui/tui-regs.c (tui_reg_command): Update.
1781         * tui/tui-layout.c (tui_set_layout): Update.
1782
1783 2019-08-30  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1786         (tui_data_window::rerender): Don't call
1787         check_and_display_highlight_if_needed.
1788         (tui_data_window::refresh_all): Remove call to
1789         erase_data_content.
1790
1791 2019-08-30  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1794         (tui_data_window::display_registers_from)
1795         (tui_data_window::display_reg_element_at_line)
1796         (tui_data_window::display_registers_from_line): Remove checks of
1797         "empty".
1798
1799 2019-08-30  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1802         Don't declare.
1803         * tui/tui-regs.c (tui_data_window::show_registers): Call
1804         rerender.
1805         (tui_data_window::rerender): Rename from display_all_data.
1806         (tui_data_window::rerender): Remove old implementation.
1807
1808 2019-08-30  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1811         text.
1812         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1813
1814 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1815             Sergio Durigan Junior  <sergiodj@redhat.com>
1816
1817         PR win32/24284
1818         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1819
1820 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1821
1822         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1823         when searching for types.
1824
1825 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         * f-lang.c (f_language_defn): Use f_print_typedef.
1828         * f-lang.h (f_print_typedef): Declare.
1829         * f-typeprint.c (f_print_typedef): Define.
1830
1831 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1832
1833         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1834
1835 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * cli/cli-utils.c (info_print_options_defs): Delete.
1838         (make_info_print_options_def_group): Delete.
1839         (extract_info_print_options): Delete.
1840         (info_print_command_completer): Delete.
1841         (info_print_args_help): Add extra parameter, and optionally
1842         include text about -n flag.
1843         * cli/cli-utils.h (struct info_print_options): Delete.
1844         (extract_info_print_options): Delete declaration.
1845         (info_print_command_completer): Delete declaration.
1846         (info_print_args_help): Add extra parameter, extend header
1847         comment.
1848         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1849         search_symbols.
1850         * stack.c (struct info_print_options): New type.
1851         (info_print_options_defs): New file scoped variable.
1852         (make_info_print_options_def_group): New static function.
1853         (info_print_command_completer): New static function.
1854         (info_locals_command): Update to use new local functions.
1855         (info_args_command): Likewise.
1856         (_initialize_stack): Add extra parameter to calls to
1857         info_print_args_help.
1858         * symtab.c (search_symbols): Add extra parameter, use this to
1859         possibly excluse non-debug symbols.
1860         (symtab_symbol_info): Add extra parameter, which is passed on to
1861         search_symbols.
1862         (struct info_print_options): New type.
1863         (info_print_options_defs): New file scoped variable.
1864         (make_info_print_options_def_group): New static function.
1865         (info_print_command_completer): New static function.
1866         (info_variables_command): Update to use local functions, and pass
1867         extra parameter through to symtab_symbol_info.
1868         (info_functions_command): Likewise.
1869         (info_types_command): Pass additional argument through to
1870         symtab_symbol_info.
1871         (rbreak_command): Pass extra argument to search_symbols.
1872         (_initialize_symtab): Add extra arguments for calls to
1873         info_print_args_help, and update help text for 'info variables',
1874         'whereis', and 'info functions' commands.
1875         * symtab.h (search_symbols): Add extra argument to declaration.
1876         * NEWS: Mention new flags.
1877
1878 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1879
1880         * symtab.c (lookup_static_symbol): Call the new function (and move
1881         it down to be next to lookup_global_symbol).
1882         (struct global_sym_lookup_data): Add block_enum member and rename to...
1883         (struct global_or_static_sym_lookup_data): ...this.
1884         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1885         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1886         (lookup_symbol_global_or_static_iterator_cb): ...this.
1887         (lookup_global_or_static_symbol): New function.
1888         (lookup_global_symbol): Call new function.
1889
1890 2019-08-26  Tom de Vries  <tdevries@suse.de>
1891
1892         PR c++/24852
1893         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1894         when pc_probe.prob == NULL.
1895
1896 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1897
1898         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1899         variable symbol_linkage to symbol_linkage_.
1900
1901 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1902
1903         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1904         represent whether the symbol is static, dynamic, or we don't
1905         know.
1906
1907 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1908
1909         * gdb/rx-tdep.c (rx_register_names): New.
1910         (rx_register_name): Delete.
1911         (rx_psw_type): Delete.
1912         (rx_fpsw_type): Delete.
1913         (rx_register_type): Delete.
1914         (rx_gdbarch_init): Convert target-descriptions.
1915         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1916         * gdb/features/Makefile: Add rx.xml.
1917         * gdb/features/rx.xml: New.
1918         * gdb/features/rx.c: Generated.
1919         * gdb/NEWS: Mention target description support.
1920
1921 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1922
1923         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1924         *slot_ptr.
1925
1926 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1927
1928         * configure.ac: Don't check for 'dlfcn.h' (moved to
1929         gdbsupport/common.m4).
1930         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1931         'gdbsupport/'.
1932         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1933         * compile/compile-c-support.c: Include
1934         'gdbsupport/gdb-dlfcn.h'.
1935         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1936         * gdb-dlfcn.c: Move to...
1937         * gdbsupport/gdb-dlfcn.c: ... here.
1938         * gdb-dlfcn.h: Move to...
1939         * gdbsupport/gdb-dlfcn.h: ... here.
1940
1941 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1942
1943         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1944         the offset field signed.
1945
1946 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1947
1948         * python/lib/gdb/__init__.py (_execute_file): New function.
1949         * python/python.c (python_run_simple_file): Call gdb._execute_file
1950         on Windows.
1951
1952 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1955         all uses as this was never set to anything but a zero value.
1956
1957 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1958
1959         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1960
1961 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1962
1963         * tui/tui-data.h (tui_gen_win_info): Add an =default
1964         move constructor, required by some GCC versions.
1965
1966 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1967
1968         * go32-nat.c (go32_sysinfo): Add hygon_p.
1969
1970 2019-08-20  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1973         line_from_reg_element_no, first_reg_element_no_inline,
1974         display_all_data, delete_data_content_windows,
1975         erase_data_content>: Now private.
1976
1977 2019-08-20  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1980         (tui_unhighlight_win, tui_highlight_win)
1981         (tui_win_info::make_window): Update.
1982         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1983
1984 2019-08-20  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1987         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1988         (MAX_PID_WIDTH): Move to tui-stack.c.
1989         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1990         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1991         (MAX_PID_WIDTH): Move from tui-data.h.
1992
1993 2019-08-20  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1996         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1997         (box_win): Update.
1998         (tui_gen_win_info::make_window): Rename from tui_make_window.
1999         (tui_win_info::make_window): New method.
2000         (tui_gen_win_info::make_visible): Update.
2001         * tui/tui-source.c (tui_source_window::set_contents): Update.
2002         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2003         (tui_data_window::display_registers_from): Update.
2004         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2005         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2006         Declare.
2007         <can_box>: Remove.
2008         <title>: Remove.
2009         (struct tui_win_info) <make_window>: Declare.
2010         <can_box>: Now virtual.
2011         <title>: New member.
2012         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2013         * tui/tui-command.c (tui_cmd_window::resize): Update.
2014
2015 2019-08-20  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2018         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2019         (tui_data_window::check_register_values): Update.
2020
2021 2019-08-20  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-regs.h (struct tui_data_window): Use
2024         DISABLE_COPY_AND_ASSIGN.
2025         <regs_content>: Change type, removing unique_ptr.
2026         <tui_data_window>: Add move constructor.
2027         * tui/tui-regs.c (tui_data_window::show_registers)
2028         (tui_data_window::show_register_group)
2029         (tui_data_window::display_registers_from)
2030         (tui_data_window::display_registers_from)
2031         (tui_data_window::first_data_item_displayed)
2032         (tui_data_window::delete_data_content_windows)
2033         (tui_data_window::rerender, tui_data_window::refresh_window)
2034         (tui_data_window::check_register_values): Update.
2035
2036 2019-08-20  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2039         show_register_group>: Declare.
2040         (tui_show_register_group): Don't declare.
2041         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2042         tui_show_registers.
2043         (tui_data_window::show_register_group): Rename from
2044         tui_show_register_group.
2045         (tui_data_window::check_register_values, tui_reg_command):
2046         Update.
2047         * tui/tui-layout.c (tui_set_layout): Update.
2048
2049 2019-08-20  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2052         Declare.
2053         (tui_check_register_values): Don't declare.
2054         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2055         from tui_check_register_values.
2056         * tui/tui-hooks.c (tui_register_changed): Update.
2057
2058 2019-08-20  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-regs.c (tui_reg_layout): Move later.
2061         (tui_show_registers): Don't enable TUI mode or change layout.
2062
2063 2019-08-20  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-regs.h (struct tui_data_item_window)
2066         <~tui_data_item_window>: Remove.
2067         <content>: Now a unique_xmalloc_ptr.
2068         * tui/tui-regs.c (tui_register_format): Return a
2069         unique_xmalloc_ptr.
2070         (tui_get_register): Update.
2071         (~tui_data_item_window): Remove.
2072         (tui_data_window::display_registers_from, tui_display_register):
2073         Update.
2074         * tui/tui-io.h (tui_expand_tabs): Update.
2075         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2076         Remove "col" parameter.
2077
2078 2019-08-20  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2081         field.
2082         * tui/tui-regs.c (~tui_data_item_window): Update.
2083
2084 2019-08-20  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2087         earlier.
2088
2089 2019-08-20  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2092
2093 2019-08-20  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-source.h (struct tui_source_window): Update.
2096         * tui/tui-regs.c (tui_show_registers): Update.
2097         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2098         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2099         (NO_REGS_STRING): Remove defines.
2100
2101 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2102
2103         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2104         unnecessary thread walk if remote doesn't support the packet.
2105
2106 2019-08-19  Tom Tromey  <tromey@adacore.com>
2107
2108         * python/py-value.c (value_has_field): Fix indentation.
2109
2110 2019-08-19  Tom Tromey  <tromey@adacore.com>
2111
2112         * printcmd.c (do_one_display, info_display_command): Update.
2113         * block.h (contained_in): Return bool.  Add allow_nested
2114         parameter.
2115         * block.c (contained_in): Return bool.  Add allow_nested
2116         parameter.
2117
2118 2019-08-19  Tom Tromey  <tom@tromey.com>
2119
2120         * configure: Rebuild.
2121         * configure.ac: Disallow the combination of -static-libstdc++ and
2122         source highlight.
2123         * source-cache.c (get_language_name): Handle rust.
2124         (source_cache::get_source_lines): Ignore highlighting exceptions.
2125
2126 2019-08-16  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2129         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2130         (struct tui_source_window_base) <make_visible, refresh_window,
2131         resize>: Remove methods.
2132         <execution_info>: Remove field.
2133         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2134         (tui_show_source_line, tui_source_window_base)
2135         (~tui_source_window_base): Update.
2136         (tui_source_window_base::resize)
2137         (tui_source_window_base::make_visible)
2138         (tui_source_window_base::refresh_window): Remove.
2139         (tui_source_window_base::update_exec_info): Update.
2140         * tui/tui-source.c (tui_source_window::set_contents): Update.
2141         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2142
2143 2019-08-16  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2146         deprecated_query_hook.
2147
2148 2019-08-16  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2151         (tui_update_source_windows_with_line): Update.
2152         * tui/tui-source.h (struct tui_source_window)
2153         <show_symtab_source>: Declare.
2154         (tui_show_symtab_source): Don't declare.
2155         * tui/tui-source.c (tui_show_symtab_source): Rename from
2156         tui_show_symtab_source.
2157
2158 2019-08-16  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.h (struct tui_source_window_base)
2161         <set_contents>: Declare.
2162         * tui/tui-winsource.c
2163         (tui_source_window_base::update_source_window_as_is): Update.
2164         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2165         Declare.
2166         (tui_set_source_content): Don't declare.
2167         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2168         tui_set_source_content.
2169         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2170         Declare.
2171         (tui_set_disassem_content): Don't declare.
2172         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2173         tui_set_disassem_content.
2174
2175 2019-08-16  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (struct tui_source_window_base)
2178         <update_breakpoint_info>: Declare.
2179         (tui_update_breakpoint_info): Don't declare.
2180         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2181         (tui_update_all_breakpoint_info): Update.
2182         (tui_source_window_base::update_breakpoint_info): Rename from
2183         tui_update_breakpoint_info.
2184         (tui_source_window_base::update_exec_info): Update.
2185
2186 2019-08-16  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.h (struct tui_source_window_base)
2189         <update_source_window>: Declare.
2190         (tui_update_source_window): Don't declare.
2191         * tui/tui-winsource.c
2192         (tui_source_window_base::update_source_window): Rename from
2193         tui_update_source_window.
2194         (tui_source_window_base::rerender): Update.
2195         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2196         * tui/tui-disasm.c (tui_show_disassem)
2197         (tui_show_disassem_and_update_source)
2198         (tui_disasm_window::maybe_update): Update.
2199
2200 2019-08-16  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-winsource.h (struct tui_source_window_base)
2203         <update_source_window_as_is>: Declare.
2204         (tui_update_source_window_as_is): Don't declare.
2205         * tui/tui-winsource.c (tui_update_source_window): Update
2206         (tui_source_window_base::update_source_window_as_is): Rename from
2207         tui_update_source_window_as_is.
2208         (tui_source_window_base::refill): Update.
2209         * tui/tui-source.c (tui_show_symtab_source): Update.
2210         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2211         Update.
2212
2213 2019-08-16  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-winsource.h (tui_update_source_window)
2216         (tui_update_source_window_as_is): Remove "noerror" parameter.
2217         * tui/tui-winsource.c (tui_update_source_window)
2218         (tui_update_source_window_as_is): Remove "noerror" parameter.
2219         (tui_update_source_windows_with_addr)
2220         (tui_update_source_windows_with_line)
2221         (tui_source_window_base::rerender)
2222         (tui_source_window_base::refill): Update.
2223         * tui/tui-source.h (tui_set_source_content)
2224         (tui_show_symtab_source): Remove "noerror" parameter.
2225         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2226         parameter.
2227         (tui_show_symtab_source): Likewise.
2228         (tui_source_window::maybe_update): Update.
2229         * tui/tui-disasm.c (tui_show_disassem)
2230         (tui_show_disassem_and_update_source)
2231         (tui_disasm_window::do_scroll_vertical)
2232         (tui_disasm_window::maybe_update): Update.
2233
2234 2019-08-16  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui.c (tui_is_window_visible): Update.
2237         * tui/tui-wingeneral.c (tui_make_window)
2238         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2239         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2240         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2241         (tui_set_win_height_command, parse_scrolling_args): Update.
2242         * tui/tui-source.c (tui_source_window::style_changed): Update.
2243         * tui/tui-regs.c (tui_show_registers)
2244         (tui_data_window::first_data_item_displayed)
2245         (tui_data_window::delete_data_content_windows)
2246         (tui_check_register_values, tui_reg_command): Update.
2247         * tui/tui-disasm.c (tui_show_disassem): Update.
2248         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2249         method.
2250         <is_visible>: Remove field.
2251         * tui/tui-data.c (tui_next_win, tui_prev_win)
2252         (tui_delete_invisible_windows): Update.
2253
2254 2019-08-16  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.h (struct tui_source_window_base)
2257         <m_has_locator>: Remove.
2258         * tui/tui-layout.c (show_source_disasm_command, show_data)
2259         (show_source_or_disasm_and_command): Update.
2260
2261 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2262
2263         * NEWS (Other MI changes): New subsection.
2264         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2265         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2266         * arch-utils.c (default_get_pc_address_flags): New function.
2267         * arch-utils.h (default_get_pc_address_flags): New declaration.
2268         * gdbarch.sh: Add get_pc_address_flags.
2269         * gdbarch.c: Regenerate.
2270         * gdbarch.h: Likewise.
2271         * stack.c (print_pc): New function.
2272         (print_frame_info) (print_frame): Call print_pc.
2273
2274 2019-08-16  Tom de Vries  <tdevries@suse.de>
2275
2276         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2277         print_objfile_section_info.
2278
2279 2019-08-15  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2282         calling update_cmdwin_start_line.
2283         * tui/tui-winsource.h (struct tui_source_window_base)
2284         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2285         <rerender>: Declare.
2286         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2287         Call rerender.
2288         (tui_source_window_base::set_new_height): Remove.
2289         (tui_source_window_base::rerender): Rename from
2290         do_make_visible_with_new_height.
2291         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2292         resize method.
2293         (tui_win_info::make_invisible_and_set_new_height)
2294         (tui_win_info::make_visible_with_new_height): Remove.
2295         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2296         Declare.
2297         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2298         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2299         do_make_visible_with_new_height>: Don't declare.
2300         <rerender>: Declare.
2301         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2302         set_new_height.
2303         (tui_data_window::do_make_visible_with_new_height): Remove.
2304         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2305         call tui_show_locator_content.
2306         (tui_gen_win_info::resize): Call rerender.
2307         (show_source_or_disasm_and_command): Don't call
2308         tui_show_locator_content.
2309         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2310         method.
2311         (struct tui_win_info) <rerender>: Declare.
2312         <set_new_height, make_invisible_and_set_new_height,
2313         make_visible_with_new_height>: Don't declare.
2314         * tui/tui-data.c (tui_win_list::rerender): New method.
2315         * tui/tui-command.h (struct tui_cmd_window)
2316         <do_make_visible_with_new_height>: Don't declare.
2317         * tui/tui-command.c
2318         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2319
2320 2019-08-15  Tom Tromey  <tromey@adacore.com>
2321
2322         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2323         * ada-lang.c (ada_enum_name): Likewise.
2324
2325 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2326
2327         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2328         leading underscore.
2329         (GdbOutputErrorFile): Likewise.
2330         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2331         accordingly.
2332         (execute_unwinders): Rename to have a leading underscore.
2333         (auto_load_packages): Likewise.
2334         (global scope): Adjust call to auto_load_packages accordingly.
2335         (GdbSetPythonDirectory): Likewise.
2336         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2337         instead of execute_unwinders.
2338
2339 2019-08-15  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2342         (show_data): Don't change window visibility.
2343         (tui_gen_win_info::resize): Remove special case for command
2344         window.  Use wresize, when available.
2345         (show_source_or_disasm_and_command): Don't change window
2346         visibility.
2347         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2348         <make_visible>: New method.
2349         * tui/tui-command.c (tui_cmd_window::resize): New method.
2350
2351 2019-08-15  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2354         (struct tui_source_windows): New.
2355         * tui/tui-winsource.c (tui_display_main): Update.
2356         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2357         (new_height_ok, parse_scrolling_args): Update.
2358         * tui/tui-layout.c (show_layout, show_data): Update.
2359         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2360         (tui_add_to_source_windows): Don't declare.
2361         * tui/tui-data.c (source_windows, tui_source_windows)
2362         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2363
2364 2019-08-15  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2367         Rename from reset.
2368         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2369         * tui/tui-layout.c (show_source_disasm_command, show_data):
2370         Update.
2371         (tui_gen_win_info::resize): Rename.
2372         (show_source_or_disasm_and_command): Update.
2373         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2374         reset.
2375
2376 2019-08-15  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2379         * tui/tui-interp.c (tui_interp::init): Don't call
2380         tui_initialize_static_data.
2381         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2382
2383 2019-08-15  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2386         examine tui_win_list.
2387
2388 2019-08-15  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2391         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2392         tui_clear_source_content.
2393         (tui_clear_source_content): Remove.
2394         (tui_source_window_base::do_erase_source_content): Hoist call to
2395         content.clear().
2396         * tui/tui-stack.c (tui_show_frame_info): Don't call
2397         tui_clear_source_content.
2398
2399 2019-08-15  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-winsource.h (struct tui_source_window_base)
2402         <do_erase_source_content>: New method.
2403         <erase_source_content>: New method.
2404         (tui_erase_source_content): Don't declare.
2405         * tui/tui-winsource.c (tui_clear_source_content): Update.
2406         (tui_source_window_base::do_erase_source_content): Rename from
2407         tui_erase_source_content.
2408         (tui_source_window_base::show_source_content): Update.
2409         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2410         * tui/tui-source.h (struct tui_source_window)
2411         <erase_source_content>: New method.
2412         * tui/tui-disasm.h (struct tui_disasm_window)
2413         <erase_source_content>: New method.
2414
2415 2019-08-15  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2418         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2419         constructor.
2420         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2421         * tui/tui-source.c (tui_set_source_content): Update.
2422         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2423
2424 2019-08-15  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2427         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2428         tui-source.c.
2429         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2430         Declare.
2431         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2432         method.
2433         (tui_source_window::maybe_update): Update.
2434
2435 2019-08-15  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2438         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2439         tui-disasm.c.
2440         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2441         Declare.
2442         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2443         method.
2444         (tui_disasm_window::maybe_update): Update.
2445
2446 2019-08-15  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-winsource.h (struct tui_source_window_base)
2449         <maybe_update>: Declare.
2450         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2451         method.
2452         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2453         Declare.
2454         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2455         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2456         Declare.
2457         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2458
2459 2019-08-15  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2462
2463 2019-08-15  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-wingeneral.c: Include tui-stack.h.
2466         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2467         (struct tui_locator_window): Move from tui-data.h.
2468         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2469         (tui_initialize_static_data): Move from tui-data.c.
2470         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2471         (struct tui_locator_window): Move to tui-stack.c.
2472         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2473         (tui_initialize_static_data): Move to tui-stack.c.
2474
2475 2019-08-15  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-layout.c (show_source_disasm_command)
2478         (show_source_or_disasm_and_command): Use make_visible method, not
2479         tui_make_window.
2480         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2481         Remove.
2482
2483 2019-08-15  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-wingeneral.h (tui_make_window): Update.
2486         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2487         parameter.
2488         (tui_gen_win_info::make_visible): Update.
2489         * tui/tui-regs.c (tui_data_window::display_registers_from):
2490         Update.
2491         * tui/tui-layout.c (show_source_disasm_command)
2492         (show_source_or_disasm_and_command): Update.
2493         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2494         (enum tui_box): Remove.
2495         (struct tui_win_info) <can_box>: New method.
2496         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2497         method.
2498
2499 2019-08-15  Tom de Vries  <tdevries@suse.de>
2500
2501         * linux-nat-trad.c: Include gdbarch.h.
2502
2503 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2504
2505         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2506         register sizes.
2507
2508 2019-08-14  Tom Tromey  <tromey@adacore.com>
2509
2510         * darwin-nat.c: Include gdbarch.h.
2511         * darwin-nat-info.c: Include gdbarch.h.
2512
2513 2019-08-13  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2516         Remove.
2517         * tui/tui-data.c (tui_initialize_static_data): Update.
2518
2519 2019-08-13  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-winsource.h (struct tui_exec_info_window)
2522         <~tui_exec_info_window, maybe_allocate_content, get_content,
2523         m_content>: Remove.
2524         (struct tui_source_window_base) <set_exec_info_content,
2525         show_exec_info_content>: Don't declare.
2526         * tui/tui-winsource.c
2527         (tui_exec_info_window::maybe_allocate_content): Remove.
2528         (tui_source_window_base::update_exec_info): Rename from
2529         set_exec_info_content.
2530         (tui_source_window_base::show_exec_info_content)
2531         (tui_source_window_base::update_exec_info): Remove.
2532
2533 2019-08-13  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2536         declare.
2537         * tui/tui-winsource.c (tui_update_source_window_as_is)
2538         (tui_update_source_windows_with_addr, tui_erase_source_content):
2539         Update.
2540         (tui_clear_exec_info_content): Remove.
2541
2542 2019-08-13  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2545         declare.
2546         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2547         call tui_erase_exec_info_content.
2548         (tui_clear_exec_info_content): Rename from
2549         tui_erase_exec_info_content.
2550         (tui_clear_exec_info_content): Delete.
2551
2552 2019-08-13  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-winsource.h (struct tui_source_window_base)
2555         <show_exec_info_content>: Declare.
2556         (tui_show_exec_info_content): Don't declare.
2557         * tui/tui-winsource.c
2558         (tui_source_window_base::show_exec_info_content): Rename from
2559         tui_show_exec_info_content.
2560         (tui_source_window_base::update_exec_info): Update.
2561
2562 2019-08-13  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2565         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2566         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2567         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2568         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2569         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2570         ... here.
2571
2572 2019-08-13  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-winsource.h (struct tui_source_window_base)
2575         <update_exec_info>: Declare.
2576         (tui_update_exec_info): Don't declare.
2577         * tui/tui-winsource.c (tui_update_source_window_as_is)
2578         (tui_source_window_base::refresh_all)
2579         (tui_update_all_breakpoint_info): Update.
2580         (tui_source_window_base::update_exec_info): Rename from
2581         tui_update_exec_info.
2582         * tui/tui-stack.c (tui_show_frame_info): Update.
2583
2584 2019-08-13  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-winsource.h (struct tui_source_window_base)
2587         <set_exec_info_content>: Declare.
2588         (tui_set_exec_info_content): Don't declare.
2589         * tui/tui-winsource.c
2590         (tui_source_window_base::set_exec_info_content): Rename from
2591         tui_set_exec_info_content.
2592         (tui_update_exec_info): Update.
2593
2594 2019-08-13  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-winsource.h (struct tui_source_window_base)
2597         <show_source_content>: Declare.
2598         (tui_show_source_content): Don't declare.
2599         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2600         (tui_source_window_base::show_source_content): Rename from
2601         tui_show_source_content.
2602         (tui_source_window_base::refresh_all): Update.
2603         * tui/tui-layout.c (show_source_disasm_command)
2604         (show_source_or_disasm_and_command): Update.
2605
2606 2019-08-13  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-winsource.c (tui_erase_source_content)
2609         (tui_show_source_content, tui_source_window_base::refresh_all):
2610         Update.
2611         * tui/tui-wingeneral.h
2612         (tui_check_and_display_highlight_if_needed): Don't declare.
2613         * tui/tui-wingeneral.c
2614         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2615         check_and_display_highlight_if_needed.
2616         * tui/tui-win.c (tui_rehighlight_all)
2617         (tui_win_info::make_visible_with_new_height): Update.
2618         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2619         (tui_data_window::erase_data_content)
2620         (tui_data_window::display_all_data): Update.
2621         * tui/tui-data.h (struct tui_win_info)
2622         <check_and_display_highlight_if_needed>: Declare.
2623
2624 2019-08-13  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-win.c (tui_resize_all): Call
2627         tui_delete_invisible_windows.
2628         * tui/tui-layout.c (show_layout): Call
2629         tui_delete_invisible_windows.
2630         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2631         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2632
2633 2019-08-13  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2636         tui_add_win_to_layout.
2637
2638 2019-08-13  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2641         * tui/tui-layout.c (tui_default_win_height): Now static.
2642
2643 2019-08-13  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2646         single switch.
2647         (show_source_disasm_command, show_source_or_disasm_and_command):
2648         Don't check current layout.
2649
2650 2019-08-13  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-wingeneral.c (make_all_visible): Remove.
2653         (tui_make_all_invisible): Simplify.
2654         * tui/tui-layout.c (tui_make_all_invisible): Move from
2655         tui-wingeneral.c; simplify.
2656         (show_layout): Hoist call to tui_make_all_invisible.
2657         (show_data): Don't call tui_make_all_invisible.
2658
2659 2019-08-13  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2662         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2663
2664 2019-08-13  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2667         tui-data.c.
2668         (show_source_disasm_command, show_data)
2669         (show_source_or_disasm_and_command): Don't use
2670         tui_set_current_layout_to.
2671         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2672         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2673         tui-layout.c.
2674         (tui_set_current_layout_to): Remove.
2675
2676 2019-08-13  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-layout.c (tui_set_layout): Update.
2679         * tui/tui-data.h (struct tui_layout_def): Remove.
2680         (tui_layout_def): Don't declare.
2681         * tui/tui-data.c (layout_def): Remove.
2682         (tui_layout_def): Remove.
2683
2684 2019-08-13  Tom Tromey  <tom@tromey.com>
2685
2686         * tui/tui-winsource.h (struct tui_source_window_base)
2687         <clear_detail>: No longer "override".
2688         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2689         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2690         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2691         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2692         Remove.
2693         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2694
2695 2019-08-13  Tom Tromey  <tromey@adacore.com>
2696
2697         * tracepoint.c: Don't include readline.h or history.h.
2698
2699 2019-08-12  Tom Tromey  <tom@tromey.com>
2700
2701         * configure: Rebuild.
2702         * configure.ac: Check for readline 7.
2703         * NEWS: Mention readline 7 requirement.
2704         * README: Update.
2705
2706 2019-08-12  Tom Tromey  <tom@tromey.com>
2707
2708         * mingw-hdep.c (gdb_select): Remove readline hack.
2709
2710 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2711
2712         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2713         when the function fails.
2714
2715 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2716
2717         * s390-tdep.c (s390_type_align): New function.
2718         (s390_gdbarch_init): Set it as type_align gdbarch method.
2719
2720 2019-08-09  Tom de Vries  <tdevries@suse.de>
2721
2722         PR gdb/24591
2723         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2724         pc_low with relocation offset.
2725
2726 2019-08-07  Tom Tromey  <tromey@adacore.com>
2727
2728         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2729         (print_frame_args): Update.
2730         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2731         Update.
2732         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2733         * frame.h (struct frame_arg): Add initializers.
2734         <error>: Now a unique_xmalloc_ptr.
2735
2736 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2737
2738         * NEWS: Expand the Pointer Authentication entry.
2739         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2740         (aarch64_frame_unmask_lr): ... to this.
2741         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2742         Call aarch64_frame_unmask_lr.
2743         * frame.c (struct frame_info): Add "masked" variable.
2744         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2745         (fprint_frame): Check for masked pc.
2746         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2747         declarations.
2748         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2749         * stack.c (print_frame): Check for masked pc.
2750
2751 2019-08-06  Tom Tromey  <tom@tromey.com>
2752
2753         * stabsread.c (patch_block_stabs, read_one_struct_field)
2754         (read_enum_type): Use obstack_strndup.
2755         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2756         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2757         * dwarf2read.c (guess_full_die_structure_name)
2758         (anonymous_struct_prefix): Use obstack_strndup.
2759         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2760         * c-exp.y (yylex): Use obstack_strndup.
2761         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2762         (write_var_or_type): Use obstack_strndup.
2763
2764 2019-08-06  Tom Tromey  <tom@tromey.com>
2765
2766         * symfile.c (reread_symbols): Use obstack_strdup.
2767         * stabsread.c (read_type): Use obstack_strdup.
2768         * gdb_obstack.h (obstack_strdup): New overload.
2769         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2770         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2771         (dwarf2_canonicalize_name): Use obstack_strdup.
2772         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2773         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2774         Use obstack_strdup.
2775
2776 2019-08-06  Tom Tromey  <tom@tromey.com>
2777
2778         * gdb_obstack.h (obstack_strdup): Define.
2779         * gdb_obstack.c (obstack_strdup): Don't define.
2780
2781 2019-08-06  Tom Tromey  <tom@tromey.com>
2782
2783         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2784         obstack_strdup.
2785         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2786         obstack_strdup.
2787         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2788         * stabsread.c (common_block_start): Use obstack_strdup.
2789         * objfiles.c (set_objfile_main_name, objfile): Use
2790         obstack_strdup.
2791         * namespace.c (add_using_directive): Use obstack_strdup.
2792         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2793         * jit.c (finalize_symtab): Use obstack_strdup.
2794         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2795         (guess_partial_die_structure_name, partial_die_info::fixup)
2796         (dwarf2_name): Use obstack_strdup.
2797         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2798         obstack_strdup.
2799         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2800         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2801         obstack_strdup.
2802         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2803
2804 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2805
2806         * unittests/help-doc-selftests.c: New file.
2807         * Makefile.in: Add the new file.
2808
2809 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2810
2811         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2812         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2813         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2814         the trailing '.' is not output, and the first character is uppercased.
2815         (print_help_for_command): Update call to print_doc_line.
2816         (print_doc_of_command): Likewise.
2817         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2818         * cli/cli-option.c (append_indented_doc): Do not append newline.
2819         (build_help_option): Append newline after first appended_indented_doc
2820         only if a second call is done.
2821         (build_help): Append 2 new lines before each option, except the first
2822         one.
2823         * compile/compile.c (_initialize_compile): Add new lines after
2824         %OPTIONS%, when not at the end of the help.
2825         Change help doc or code
2826         producing the help doc to respect the invariants.
2827         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2828         Also removed the new line after 'Options:', as all other commands
2829         do not put an empty line between 'Options:' and the first option.
2830         * printcmd.c (_initialize_printcmd): Likewise.
2831         * stack.c (_initialize_stack): Likewise.
2832         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2833         incorrectly telling COMMAND is optional.
2834         * ada-lang.c (_initialize_ada_language): Change help doc or code
2835         producing the help doc to respect the invariants.
2836         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2837         * breakpoint.c (_initialize_breakpoint): Likewise.
2838         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2839         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2840         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2841         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2842         _initialize_cli_style): Likewise.
2843         * corelow.c (core_target_info): Likewise.
2844         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2845         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2846         * filesystem.c (_initialize_filesystem): Likewise.
2847         * frame.c (_initialize_frame): Likewise.
2848         * gnu-nat.c (add_task_commands): Likewise.
2849         * infcall.c (_initialize_infcall): Likewise.
2850         * infcmd.c (_initialize_infcmd): Likewise.
2851         * interps.c (_initialize_interpreter): Likewise.
2852         * language.c (_initialize_language): Likewise.
2853         * linux-fork.c (_initialize_linux_fork): Likewise.
2854         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2855         * maint.c (_initialize_maint_cmds): Likewise.
2856         * memattr.c (_initialize_mem): Likewise.
2857         * printcmd.c (_initialize_printcmd): Likewise.
2858         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2859         _RegEx): Likewise.
2860         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2861         * record-btrace.c (_initialize_record_btrace): Likewise.
2862         * record-full.c (_initialize_record_full): Likewise.
2863         * record.c (_initialize_record): Likewise.
2864         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2865         * regcache.c (_initialize_regcache): Likewise.
2866         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2867         _initialize_remote): Likewise.
2868         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2869         * serial.c (_initialize_serial): Likewise.
2870         * skip.c (_initialize_step_skip): Likewise.
2871         * source.c (_initialize_source): Likewise.
2872         * stack.c (_initialize_stack): Likewise.
2873         * symfile.c (_initialize_symfile): Likewise.
2874         * symtab.c (_initialize_symtab): Likewise.
2875         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2876         * top.c (init_main): Likewise.
2877         * tracefile-tfile.c (tfile_target_info): Likewise.
2878         * tracepoint.c (_initialize_tracepoint): Likewise.
2879         * tui/tui-win.c (_initialize_tui_win): Likewise.
2880         * utils.c (add_internal_problem_command): Likewise.
2881         * valprint.c (value_print_option_defs): Likewise.
2882
2883 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2884
2885         PR build/24886
2886         * configure.ac: Drop enable-libmcheck support.
2887         * configure, config.in: Rebuild.
2888         * libmcheck.m4: Remove.
2889         * acinclude.m4: Don't include it.
2890         * Makefile.in: Don't distribute it.
2891         * top.c (print_gdb_configuration): Don't mention it.
2892
2893 2019-08-06  Tom Tromey  <tom@tromey.com>
2894
2895         * utils.c (set_output_style): Sometimes pass stream to
2896         emit_style_escape.
2897         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2898         * record-btrace.c (btrace_insn_history): Update.
2899         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2900         method.
2901         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2902         Update initializers.
2903         <m_uiout>: New field.
2904         <m_di>: Move lower.
2905         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2906         Remove "uiout" parameter.
2907         (dump_insns): Update.
2908         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2909         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2910
2911 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2912
2913         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2914         (error_in_psymtab_expansion): Likewise.
2915         (lookup_symbol_via_quick_fns): Likewise.
2916         (basic_lookup_transparent_type_quick): Likewise.
2917         (basic_lookup_transparent_type_1): Likewise.
2918
2919 2019-08-06  Tom Tromey  <tromey@adacore.com>
2920
2921         * source.c (last_source_error): Now bool.
2922         (print_source_lines_base): Make "noprint" bool.  Only open
2923         source file when last_source_visited changes.
2924
2925 2019-08-06  Tom Tromey  <tromey@adacore.com>
2926
2927         * annotate.c (annotate_source_line): Use g_source_cache.
2928         * source-cache.c (source_cache::get_plain_source_lines): Change
2929         parameters.  Populate m_offset_cache.
2930         (source_cache::ensure): New method.
2931         (source_cache::get_line_charpos): New method.
2932         (extract_lines): Move lower.  Change parameters.
2933         (source_cache::get_source_lines): Move lower.
2934         * source-cache.h (class source_cache): Update comment.
2935         <get_line_charpos>: New method.
2936         <get_source_lines>: Update comment.
2937         <clear>: Clear m_offset_cache.
2938         <get_plain_source_lines>: Change parameters.
2939         <ensure>: New method
2940         <m_offset_cache>: New member.
2941         * source.c (forget_cached_source_info_for_objfile): Update.
2942         (info_source_command): Use g_source_cache.
2943         (find_source_lines, open_source_file_with_line_charpos): Remove.
2944         (print_source_lines_base, search_command_helper): Use g_source_cache.
2945         * source.h (open_source_file_with_line_charpos): Don't declare.
2946         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2947         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2948         Use g_source_cache.
2949
2950 2019-08-06  Tom Tromey  <tromey@adacore.com>
2951
2952         * source-cache.c (source_cache::get_plain_source_lines):
2953         Remove "first_line" and "last_line" parameters.
2954         (source_cache::get_source_lines): Cache plain text.
2955         * source-cache.h (class source_cache)
2956         <get_plain_source_lines>: Update.
2957
2958 2019-08-06  Tom Tromey  <tromey@adacore.com>
2959
2960         * source-cache.c (extract_lines): No longer a method.
2961         Changed type of parameter.  Include final newline.
2962         (selftests::extract_lines_test): New function.
2963         (_initialize_source_cache): Likewise.
2964         * source-cache.h (class source_cache)
2965         <extract_lines>: Don't declare.
2966
2967 2019-08-06  Tom Tromey  <tromey@adacore.com>
2968
2969         * breakpoint.c (init_breakpoint_sal): Update.
2970         (breakpoint): Update.
2971         * breakpoint.h (struct breakpoint) <filter>: Now a
2972         unique_xmalloc_ptr.
2973
2974 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2975
2976         * NEWS: Mention dictionary access on blocks.
2977         * python/py-block.c (blpy_getitem): New function.
2978         (block_object_as_mapping): New struct.
2979         (block_object_type): Use new struct for tp_as_mapping field.
2980
2981 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2982
2983         * objfiles.h (objfile): Add a comment describing partial symbols.
2984
2985 2019-08-05  Tom Tromey  <tromey@adacore.com>
2986
2987         * compile/compile.c (_initialize_compile): Use _(), not N_().
2988         * thread.c (_initialize_thread): Use _(), not N_().
2989         * stack.c (_initialize_stack): Use _(), not N_().
2990         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2991
2992 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2993
2994         * dwarf2read.c (struct dw2_symtab_iterator):
2995         <want_specific_block>: Remove.
2996         <block_index>: Change type to gdb::optional.
2997         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2998         change type of BLOCK_INDEX parameter to gdb::optional.
2999         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3000         (dw2_lookup_symbol): Don't pass argument for
3001         WANT_SPECIFIC_BLOCK.
3002         (dw2_expand_symtabs_for_function): Don't pass argument for
3003         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3004         (class dw2_debug_names_iterator)
3005         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3006         parameter, change BLOCK_INDEX type to gdb::optional.
3007         <m_want_specific_block>: Remove.
3008         <m_block_index>: Change type to gdb::optional.
3009         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3010         gdb::optional.  Re-write in function of gdb::optional.
3011         (dw2_debug_names_lookup_symbol): Don't pass argument for
3012         WANT_SPECIFIC_BLOCK.
3013         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3014         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3015         BLOCK_INDEX.
3016
3017 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3018
3019         * NEWS: Mention changes to "info sources" command.
3020
3021 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3022
3023         * symtab.c (filename_partial_match_opts): New struct type.
3024         (struct output_source_filename_data): New members
3025         regexp, c_regexp, partial_match.
3026         (output_source_filename): Use new members to decide to print file.
3027         (info_sources_option_defs): New variable.
3028         (make_info_sources_options_def_group, print_info_sources_header,
3029         info_sources_command_completer):
3030         New functions.
3031         (info_sources_command): Read new optional arguments.
3032         (_initialize_symtab): Update info sources help.
3033
3034 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3035
3036         * ada-lang.c (exception_support_info_v0): Renamed from...
3037         (default_exception_support_info): ... this.  Create new
3038         definition for v1.
3039         (ada_has_this_exception_support): Look up catch_handlers_sym.
3040         (ada_exception_support_info_sniffer): Try v0 after default.
3041
3042 2019-08-01  Tom Tromey  <tromey@adacore.com>
3043
3044         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3045         gdbarch.h.
3046
3047 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3048
3049         * s12z-tdep.c: Fix include path for s12z-opc.h.
3050
3051 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3052
3053         * NEWS: Require GNU make 3.82.
3054
3055 2019-07-16  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3058         declare.
3059
3060 2019-07-30  Tom Tromey  <tromey@adacore.com>
3061
3062         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3063
3064 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3065
3066         * printcmd.c (print_address_symbolic): Print negative offsets.
3067         (build_address_symbolic): Force signed arithmetic when computing
3068         offset.
3069
3070 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3071
3072         PR/24474: Add a function to lookup static variables.
3073         * NEWS: Mention this new function.
3074         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3075         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3076         * python/python.c (python_GdbMethods): Add new function.
3077
3078 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3079
3080         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3081         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3082         (objfpy_lookup_static_symbol): New function.
3083         (objfile_object_methods): Add new functions.
3084
3085 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3086
3087         * NEWS: Mention 'set|show print frame-info'.  Mention new
3088         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3089         backtrace argument.  Mention that python frame filtering code
3090         is now consistent with what 'backtrace' command prints.
3091
3092 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3093
3094         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3095         comments.
3096         (print_frame_info_auto, print_frame_info_source_line,
3097         print_frame_info_location, print_frame_info_source_and_location,
3098         print_frame_info_location_and_address, print_frame_info_short_location):
3099         New declarations.
3100         (struct frame_print_options): New member print_frame_info.
3101         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3102         * stack.h (get_user_print_what_frame_info): New declaration.
3103         (frame_show_address): New declaration.
3104         * stack.c (print_frame_arguments_choices): New value 'presence'.
3105         (print_frame_info_auto, print_frame_info_source_line,
3106         print_frame_info_location, print_frame_info_source_and_location,
3107         print_frame_info_location_and_address, print_frame_info_short_location,
3108         print_frame_info_choices, print_frame_info_print_what): New definitions.
3109         (print_frame_args): Only print dots for args if print frame-arguments
3110         is 'presence'.
3111         (frame_print_option_defs): New element for "frame-info".
3112         (get_user_print_what_frame_info): New function.
3113         (frame_show_address): Make non static.  Move comment to stack.h.
3114         (print_frame_info_to_print_what): New function.
3115         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3116         to decide what to print.
3117         (backtrace_command_1): Handle the new print_frame_arguments_presence
3118         value.
3119         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3120         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3121         (py_print_frame): In non-mi mode, use LOCATION as default for
3122         print_what, similarly to frame information printed directly by
3123         backtrace command. Handle frame-info user option in non MI mode.
3124
3125 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3126
3127         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3128         Add case for debugging 32-bit target on 64-bit host.  Revise
3129         comment.
3130
3131 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3132
3133         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3134         instead of find_function_entry_range_from_pc.
3135
3136 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3137
3138         * stack.c (find_frame_funname): Remove code which preferred
3139         minsym over symtab sym in "certain pathological cases".
3140
3141         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3142         parameter.  Change type of "do_demangle" to bool.
3143         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3144         Pass suitable "prefer_sym_over_minsym" flag to
3145         build_address_symbolic().  Don't output "+" for negative offsets.
3146         * printcmd.c (print_address_symbolic): Update invocation of
3147         build_address_symbolic to include a "prefer_sym_over_minsym"
3148         flag.
3149         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3150         Restrict cases in which use of minimal symbol is preferred to that
3151         of a found symbol.  Update comments.
3152
3153         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3154         for entry pc when entry pc is out of range for that FDE.
3155
3156 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3157
3158         PR gdb/24839:
3159         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3160         type.
3161
3162 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3163
3164         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3165         this function's Python signature.
3166
3167
3168 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3169
3170         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3171         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3172         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3173         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3174         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3175
3176
3177 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3178
3179         * h8300-tdep.c (h8300_register_name_common): New.
3180         h8300_register_name): Use h8300_register_name_common.
3181         (h8300s_register_name): Likewise.
3182         (h8300sx_register_name): Likewise.
3183         (h8300h_register_nam): New.
3184         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3185
3186
3187 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3188
3189         * arm-tdep.c (arm_skip_cmse_entry): New function.
3190         (arm_is_sgstubs_section): New function.
3191         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3192
3193 2019-07-22  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3196         Don't self-assign.
3197
3198 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3201         type_print.
3202
3203 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3206         so that GDB doesn't match any msymbols when searching in the
3207         TYPES_DOMAIN.
3208         (print_symbol_info): Print using typedef_print or type_print based
3209         on the type of the symbol.  Add updated FIXME comment moved from...
3210         (_initialize_symtab): ... move and update FIXME comment to above.
3211
3212 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * NEWS: Mention adding -q option to "info types".
3215         * symtab.c (struct info_types_options): New struct.
3216         (info_types_options_defs): New variable.
3217         (make_info_types_options_def_group): New function.
3218         (info_types_command): Use gdb::option framework to parse options.
3219         (info_types_command_completer): New function.
3220         (_initialize_symtab): Extend the help text on "info types" and
3221         register command completer.
3222
3223 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3224
3225         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3226         (lookup_symbol_in_objfile): Change int to block_enum and add a
3227         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3228
3229 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3230
3231         * MAINTAINERS (Write After Approval): Add self.
3232
3233 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3236         instruction to the dummy code region.
3237
3238 2019-07-19  Tom Tromey  <tromey@adacore.com>
3239
3240         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3241         (ARGSUSED, PARAMS, __func__): Remove rules.
3242
3243 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3244
3245         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3246         * features/arm/arm-with-iwmmxt.c: Remove.
3247         * features/arm/arm-with-iwmmxt.xml: Remove.
3248         * features/arm/arm-with-m-fpa-layout.c: Remove.
3249         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3250         * features/arm/arm-with-m-vfp-d16.c: Remove.
3251         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3252         * features/arm/arm-with-m.c: Remove.
3253         * features/arm/arm-with-m.xml: Remove.
3254         * features/arm/arm-with-neon.c: Remove.
3255         * features/arm/arm-with-neon.xml: Remove.
3256         * features/arm/arm-with-vfpv2.c: Remove.
3257         * features/arm/arm-with-vfpv2.xml: Remove.
3258         * features/arm/arm-with-vfpv3.c: Remove.
3259         * features/arm/arm-with-vfpv3.xml: Remove.
3260
3261 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3262
3263         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3264
3265 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3266
3267         * arch/aarch32.c (aarch32_create_target_description): Create
3268         target descriptions using features.
3269         * arch/arm.c (arm_create_target_description)
3270         (arm_create_mprofile_target_description): Likewise.
3271         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3272
3273 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3274
3275         * Makefile.in: Add new files.
3276         * aarch32-tdep.c: New file.
3277         * aarch32-tdep.h: New file.
3278         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3279         Call aarch32_read_description.
3280         * arch/aarch32.c: New file.
3281         * arch/aarch32.h: New file.
3282         * arch/arm.c (arm_create_target_description)
3283         (arm_create_mprofile_target_description): New function.
3284         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3285         (arm_create_target_description)
3286         (arm_create_mprofile_target_description): New declaration.
3287         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3288         read_description functions.
3289         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3290         Likewise.
3291         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3292         * arm-tdep.c (tdesc_arm_list): New variable.
3293         (arm_register_g_packet_guesses): Call create description functions.
3294         (arm_read_description) (arm_read_mprofile_description): New
3295         function.
3296         * arm-tdep.h (arm_read_description)
3297         (arm_read_mprofile_description): Add declaration.
3298         * configure.tgt: Add new files.
3299
3300 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3301
3302         * top.c (new_ui_command): Open specified terminal just once.
3303
3304 2019-07-18  Tom Tromey  <tromey@adacore.com>
3305
3306         * symtab.c (main_name): Constify return type.
3307         * symfile.c (set_initial_language): Update.
3308         * symtab.h (main_name): Constify return type.
3309
3310 2019-07-17  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-winsource.c (tui_update_source_window)
3313         (tui_update_source_window_as_is)
3314         (tui_update_source_windows_with_line): Remove return.
3315         * tui/tui-disasm.c (tui_show_disassem)
3316         (tui_show_disassem_and_update_source): Remove return.
3317         * tui/tui.c (tui_reset): Remove return.
3318         * tui/tui-wingeneral.c
3319         (tui_check_and_display_highlight_if_needed): Remove return.
3320
3321 2019-07-17  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3324
3325 2019-07-17  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.h (struct tui_exec_info_window)
3328         (struct tui_source_window_base): Move from tui-data.h.
3329         * tui/tui-winsource.c: Move many method definitions from
3330         elsewhere.  Remove "structuring" comments.
3331         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3332         (tui_source_window_base::refresh_window): Move to
3333         tui-winsource.c.
3334         * tui/tui-win.c (tui_source_window_base::refresh_all)
3335         (tui_source_window_base::update_tab_width)
3336         (tui_source_window_base::set_new_height)
3337         (tui_source_window_base::do_make_visible_with_new_height): Move to
3338         tui-winsource.c.
3339         * tui/tui-source.h: Update.
3340         * tui/tui-source.c (tui_source_window_base::reset): Move to
3341         tui-winsource.c.
3342         * tui/tui-disasm.h: Update.
3343         * tui/tui-data.h (struct tui_exec_info_window): Move to
3344         tui-winsource.h.
3345         (struct tui_source_window_base): Likewise.
3346         * tui/tui-data.c (tui_source_window_base::clear_detail)
3347         (tui_source_window_base, ~tui_source_window_base): Move to
3348         tui-winsource.c.
3349
3350 2019-07-17  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-win.c (tui_resize_all)
3353         (tui_source_window_base::update_tab_width)
3354         (tui_adjust_win_heights): Update.
3355         (tui_win_info::make_invisible_and_set_new_height): Rename from
3356         make_invisible_and_set_new_height.
3357         * tui/tui-data.h (struct tui_win_info)
3358         <make_invisible_and_set_new_height>: New method.
3359
3360 2019-07-17  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui.c: Update.
3363         * tui/tui-source.h (struct tui_source_window): Move from
3364         tui-data.h.
3365         * tui/tui-layout.c: Update.
3366         * tui/tui-disasm.c: Update.
3367         * tui/tui-data.h (struct tui_source_window): Move to
3368         tui-source.h.
3369
3370 2019-07-17  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3373         tui-data.h.
3374         * tui/tui-data.h (struct tui_disasm_window): Move to
3375         tui-disasm.h.
3376
3377 2019-07-17  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-regs.h (struct tui_data_item_window): Move from
3380         tui-data.h.
3381         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3382         * tui/tui-data.h (struct tui_data_item_window): Move to
3383         tui-regs.h.
3384         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3385
3386 2019-07-17  Tom Tromey  <tom@tromey.com>
3387
3388         * tui/tui.c: Update.
3389         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3390         (tui_cmd_window::max_height): Move to tui-command.c.
3391         * tui/tui-layout.c: Update.
3392         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3393         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3394         tui-command.c.
3395         * tui/tui-command.h (struct tui_cmd_window): Move from
3396         tui-data.h.
3397         * tui/tui-command.c: Remove "structuring" comments.
3398         (tui_cmd_window::clear_detail)
3399         (tui_cmd_window::do_make_visible_with_new_height)
3400         (tui_cmd_window::max_height): Move from elsewhere.
3401
3402 2019-07-17  Tom Tromey  <tom@tromey.com>
3403
3404         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3405         Now static.
3406         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3407         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3408
3409 2019-07-17  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui.c: Update.
3412         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3413         tui-regs.c.
3414         * tui/tui-windata.h: Remove file.
3415         * tui/tui-windata.c: Remove file.
3416         * tui/tui-win.c (tui_data_window::set_new_height)
3417         (tui_data_window::do_make_visible_with_new_height): Move to
3418         tui-regs.c.
3419         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3420         * tui/tui-regs.c: Remove "structuring" comments.
3421         (tui_data_window::first_data_item_displayed)
3422         (tui_data_window::delete_data_content_windows)
3423         (tui_data_window::erase_data_content)
3424         (tui_data_window::display_all_data)
3425         (tui_data_window::refresh_all)
3426         (tui_data_window::do_scroll_vertical)
3427         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3428         (tui_data_window::do_make_visible_with_new_height)
3429         (tui_data_window::refresh_window): Move from elsewhere.
3430         (_initialize_tui_regs): Move to end of file.
3431         * tui/tui-layout.c: Update.
3432         * tui/tui-hooks.c: Update.
3433         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3434         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3435         tui-regs.c.
3436         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3437
3438 2019-07-17  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3441         seen.
3442
3443 2019-07-17  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-win.c (tui_source_window_base::set_new_height)
3446         (tui_source_window_base::do_make_visible_with_new_height): Use
3447         m_has_locator field directly.
3448         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3449         method.
3450         (struct tui_source_window_base) <has_locator>: Likewise.
3451
3452 2019-07-17  Tom Tromey  <tom@tromey.com>
3453
3454         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3455         Don't declare.
3456         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3457         Remove.
3458         * tui/tui-win.c (tui_source_window_base::set_new_height)
3459         (tui_source_window_base::set_new_height)
3460         (make_invisible_and_set_new_height)
3461         (tui_source_window_base::do_make_visible_with_new_height)
3462         (tui_source_window_base::do_make_visible_with_new_height):
3463         Update.
3464         * tui/tui-layout.c (show_source_disasm_command, show_data)
3465         (show_source_or_disasm_and_command): Update.
3466         * tui/tui-layout.c (show_layout): Update.
3467
3468 2019-07-17  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-layout.c (make_data_window): Remove.
3471         (show_data): Unify creation and re-initialization cases.
3472
3473 2019-07-17  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-layout.c (make_source_window, make_disasm_window):
3476         Remove.
3477         (show_data): Unify creation and re-initialization cases.
3478
3479 2019-07-17  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-layout.c (make_command_window): Remove.
3482         (show_source_disasm_command, show_source_or_disasm_and_command):
3483         Unify creation and re-initialization cases.
3484
3485 2019-07-17  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3488         creation and re-initialization cases.
3489
3490 2019-07-17  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-regs.c (tui_get_register): Return void.
3493
3494 2019-07-17  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3497         Simplify.
3498
3499 2019-07-17  Tom Tromey  <tom@tromey.com>
3500
3501         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3502         resetting.
3503
3504 2019-07-17  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3507         * tui/tui-regs.c (tui_reg_layout): New function.
3508         (tui_show_registers, tui_reg_command): Use it.
3509         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3510         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3511         parameters.
3512         (tui_layout_command): Remove.
3513
3514 2019-07-17  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-layout.h (tui/tui-layout): Return void.
3517         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3518
3519 2019-07-17  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-layout.c (show_source_disasm_command, show_data):
3522         Update.
3523         (reset_locator): Remove.
3524         (show_source_or_disasm_and_command): Update.
3525
3526 2019-07-17  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-source.c (tui_source_window_base::reset): Remove
3529         win_type parameter.
3530         * tui/tui-layout.c (make_command_window, make_source_window)
3531         (make_disasm_window, make_data_window)
3532         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3533         (reset_locator, show_source_or_disasm_and_command): Update.
3534         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3535         win_type parameter.
3536         (struct tui_source_window_base) <reset>: Likewise.
3537
3538 2019-07-17  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-layout.c (show_source_disasm_command): Use
3541         reset_locator.
3542         (reset_locator): New function.
3543         (init_and_make_win): Remove.
3544         (show_source_or_disasm_and_command): Use reset_locator.
3545
3546 2019-07-17  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3549         condition.
3550         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3551         Remove condition.
3552         * tui/tui-source.c (tui_source_window_base::reset): New method.
3553         * tui/tui-layout.c (make_command_window): Don't call
3554         init_and_make_win.
3555         (make_source_window, make_disasm_window): Don't call
3556         make_source_or_disasm_window.
3557         (make_data_window): Don't call init_and_make_win.  Change calling
3558         convention.
3559         (show_source_disasm_command, show_data): Simplify.
3560         (make_source_or_disasm_window): Remove.
3561         (show_source_or_disasm_and_command): Simplify.
3562         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3563         (struct tui_source_window_base) <reset>: Likewise.
3564         <execution_info>: Remove initializer.
3565         * tui/tui-data.c (tui_source_window_base): Initialize
3566         execution_info.
3567
3568 2019-07-17  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3571         variable.
3572
3573 2019-07-17  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui.c (tui_rl_other_window): Update.
3576         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3577         superclass method first.  Always iterate over regs_content.
3578         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3579         method.
3580         * tui/tui-win.c (tui_set_focus_command): Update.
3581
3582 2019-07-17  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-win.c (tui_set_focus_command): Rename from
3585         tui_set_focus.  Call tui_enable.
3586         (tui_set_focus_command): Remove.
3587
3588 2019-07-17  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3591         refresh_window.
3592         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3593         touchwin.
3594         (tui_data_window::refresh_window): Call refresh_window on data
3595         items.  Always call superclass refresh_window.
3596         (tui_win_info::refresh): Remove.
3597         (tui_source_window_base::refresh_window): Update.
3598         (tui_refresh_all): Update.
3599         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3600         refresh_window.
3601         (show_source_or_disasm_and_command): Likewise.
3602         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3603         (struct tui_source_window_base) <refresh>: Likewise.
3604
3605 2019-07-17  Tom Tromey  <tom@tromey.com>
3606
3607         * tui/tui-winsource.c (tui_clear_source_content)
3608         (tui_show_source_content): Update.
3609         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3610         whether content is empty.
3611         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3612         Remove.
3613
3614 2019-07-17  Tom Tromey  <tom@tromey.com>
3615
3616         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3617         window's contents.
3618         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3619         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3620
3621 2019-07-17  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3624         (struct tui_data_item_window): Update.
3625
3626 2019-07-17  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3629         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3630         defines.
3631
3632 2019-07-17  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-winsource.h (tui_erase_source_content)
3635         (tui_clear_source_content): Remove "display_prompt" parameter.
3636         * tui/tui-winsource.c (tui_update_source_window_as_is)
3637         (tui_update_source_windows_with_addr): Update.
3638         (tui_clear_source_content): Remove "display_prompt" parameter.
3639         (tui_erase_source_content): Likewise.  Simplify.
3640         (tui_show_source_content): Update.
3641         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3642         * tui/tui-stack.c (tui_show_frame_info): Update.
3643         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3644         Remove defines.
3645
3646 2019-07-17  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3649         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3650         parameter.
3651         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3652         parameter.
3653
3654 2019-07-17  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-winsource.c (tui_clear_source_content)
3657         (tui_show_source_content, tui_show_exec_info_content)
3658         (tui_clear_exec_info_content): Update.
3659         * tui/tui-stack.c (tui_show_locator_content): Update.
3660         (tui_show_frame_info): Update.
3661         * tui/tui-source.h (tui_source_window): Don't declare.
3662         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3663         from tui_source_is_displayed.
3664         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3665         Remove field.
3666         (struct tui_source_window_base) <content_in_use>: New field.  Now
3667         bool.
3668         (struct tui_source_window) <showing_source_p>: New method.
3669         (TUI_SRC_WIN): Change cast.
3670         * tui/tui-data.c (tui_initialize_static_data): Update.
3671
3672 2019-07-17  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3675         location_matches_p.
3676         * tui/tui-source.c (tui_source_window::location_matches_p): New
3677         method.
3678         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3679         method.
3680         * tui/tui-data.h (struct tui_source_window_base)
3681         <location_matches_p>: New method.
3682         (struct tui_source_window, struct tui_disasm_window)
3683         <location_matches_p>: Likewise.
3684
3685 2019-07-17  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-win.c (tui_set_win_height_command): Rename from
3688         tui_set_win_height.
3689         (tui_set_win_height_command): Remove.
3690
3691 2019-07-17  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-source.c (tui_source_window): New constructor.  Add
3694         observer.
3695         (~tui_source_window): New destructor.
3696         (tui_source_window::style_changed): New method.
3697         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3698         (tui_attach_detach_observers): Update.
3699         * tui/tui-data.h (struct tui_source_window): Make constructor not
3700         inline.  Add destructor.
3701         (struct tui_source_window) <style_changed>: New method.
3702         <m_observable>: New member.
3703
3704 2019-07-17  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3707         * tui/tui-win.c (tui_resize_all): Fix typo.
3708
3709 2019-07-17  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3712         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3713         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3714         * tui/tui-win.c (window_name_completer): Use foreach.
3715         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3716         (update_tab_width): Likewise.
3717         * tui/tui-layout.c (show_layout): Update.
3718         * tui/tui-data.h (class tui_window_iterator): New.
3719         (struct all_tui_windows): New.
3720         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3721
3722 2019-07-17  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3725         parameter.  Don't reference globals.
3726         (tui_reg_command): Update.
3727
3728 2019-07-17  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui-regs.c (tui_show_registers): Simplify.
3731
3732 2019-07-17  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-regs.c (tui_show_registers): Update.
3735         (tui_show_register_group): Add win_info parameter.
3736
3737 2019-07-17  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3740         Rename from tui_display_reg_element_at_line.
3741         (tui_data_window::display_registers_from_line): Update.
3742         * tui/tui-data.h (struct tui_data_window)
3743         <display_reg_element_at_line>: New method.
3744
3745 2019-07-17  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui-regs.h (tui_display_registers_from)
3748         (tui_display_registers_from_line): Don't declare.
3749         * tui/tui-windata.c (tui_data_window::display_all_data)
3750         (tui_data_window::refresh_all)
3751         (tui_data_window::do_scroll_vertical): Update.
3752         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3753         from tui_display_registers_from.
3754         (tui_display_reg_element_at_line): Update.
3755         (tui_data_window::display_registers_from_line): Rename from
3756         tui_display_registers_from_line.
3757         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3758         display_registers_from_line>: New methods.
3759
3760 2019-07-17  Tom Tromey  <tom@tromey.com>
3761
3762         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3763         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3764         from tui_erase_data_content.
3765         (tui_data_window::display_all_data)
3766         (tui_data_window::refresh_all)
3767         (tui_data_window::do_scroll_vertical): Update.
3768         * tui/tui-regs.c (tui_show_registers): Update.
3769         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3770         New method.
3771
3772 2019-07-17  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3775         declare.
3776         * tui/tui-windata.c
3777         (tui_data_window::delete_data_content_windows): Rename from
3778         tui_delete_data_content_windows.
3779         (tui_data_window::display_all_data)
3780         (tui_data_window::do_scroll_vertical): Update.
3781         * tui/tui-data.h (struct tui_data_window)
3782         <delete_data_content_windows>: New method.
3783
3784 2019-07-17  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3787         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3788
3789 2019-07-17  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3792         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3793         from tui_display_all_data.
3794         * tui/tui-win.c
3795         (tui_data_window::do_make_visible_with_new_height): Update.
3796         * tui/tui-regs.c (tui_show_registers): Update.
3797         * tui/tui-layout.c (tui_set_layout): Update.
3798         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3799         method.
3800
3801 2019-07-17  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3804         * tui/tui-windata.c (tui_display_data_from): Remove.
3805         (tui_data_window::refresh_all): Update.
3806
3807 2019-07-17  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3810         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3811         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3812         tui_display_registers_from_line.
3813         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3814         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3815         "force_display" parameter.
3816
3817 2019-07-17  Tom Tromey  <tom@tromey.com>
3818
3819         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3820         declare.
3821         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3822         Rename from tui_first_reg_element_no_inline.
3823         (tui_display_reg_element_at_line)
3824         (tui_display_registers_from_line): Update.
3825         * tui/tui-data.h (struct tui_data_window)
3826         <first_reg_element_no_inline>: New method.
3827
3828 2019-07-17  Tom Tromey  <tom@tromey.com>
3829
3830         * tui/tui-windata.c (tui_display_data_from)
3831         (tui_data_window::do_scroll_vertical): Update.
3832         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3833         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3834         Rename from tui_line_from_reg_element_no.
3835         (tui_display_registers_from_line): Update.
3836         * tui/tui-data.h (struct tui_data_window)
3837         <line_from_reg_element_no>: New method.
3838
3839 2019-07-17  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3842         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3843         tui_last_regs_line_no.
3844         (tui_display_reg_element_at_line)
3845         (tui_display_registers_from_line): Update.
3846         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3847         method.
3848
3849 2019-07-17  Tom Tromey  <tom@tromey.com>
3850
3851         PR tui/24722:
3852         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3853         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3854         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3855         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3856         (tui_update_breakpoint_info): Likewise.
3857         * tui/tui-hooks.c (tui_event_create_breakpoint)
3858         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3859         Update.
3860
3861 2019-07-17  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3864
3865 2019-07-17  Tom Tromey  <tom@tromey.com>
3866
3867         * tui/tui-winsource.c (tui_update_source_window_as_is)
3868         (tui_update_source_windows_with_addr): Update.
3869         * tui/tui-source.h (tui_set_source_content)
3870         (tui_show_symtab_source): Add "win_info" parameter.
3871         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3872         parameter.
3873         (tui_show_symtab_source): Likewise.
3874
3875 2019-07-17  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-wingeneral.c
3878         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3879
3880 2019-07-17  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3883         (struct tui_cmd_window) <can_scroll>: New method.
3884         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3885         method.
3886
3887 2019-07-17  Tom Tromey  <tromey@adacore.com>
3888
3889         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3890         do_field_signed>: Rename.  Change type of "value".
3891         * ui-out.c (ui_out::field_signed): Rename from field_int.
3892         Change type of "value".
3893         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3894         type of "value".
3895         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3896         do_field_int.  Change type of "value".
3897         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3898         do_field_int.  Change type of "value".
3899         * tracepoint.c (trace_status_mi, tfind_1)
3900         (print_one_static_tracepoint_marker): Update.
3901         * thread.c (print_thread_info_1, print_selected_thread_frame):
3902         Update.
3903         * stack.c (print_frame, print_frame_info): Update.
3904         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3905         Update.
3906         * source.c (print_source_lines_base): Update.
3907         * skip.c (info_skip_command): Update.
3908         * record-btrace.c (btrace_ui_out_decode_error)
3909         (btrace_call_history_src_line): Update.
3910         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3911         Update.
3912         * progspace.c (print_program_space): Update.
3913         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3914         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3915         do_field_int.  Change type of "value".
3916         * mi/mi-out.c (mi_ui_out::do_table_begin)
3917         (mi_ui_out::do_table_header): Update.
3918         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3919         type of "value".
3920         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3921         (mi_cmd_data_list_changed_registers, output_register)
3922         (mi_cmd_data_read_memory, mi_load_progress)
3923         (mi_cmd_trace_frame_collected): Update.
3924         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3925         Update.
3926         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3927         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3928         (mi_cmd_var_list_children, varobj_update_one): Update.
3929         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3930         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3931         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3932         * inferior.c (print_inferior): Update.
3933         * gdb_bfd.c (print_one_bfd): Update.
3934         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3935         Update.
3936         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3937         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3938         do_field_int.  Change type of "value".
3939         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3940         do_field_int.  Change type of "value".
3941         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3942         (print_one_breakpoint_location, print_it_catch_fork)
3943         (print_one_catch_fork, print_it_catch_vfork)
3944         (print_one_catch_vfork, print_it_catch_solib)
3945         (print_it_catch_exec, print_it_ranged_breakpoint)
3946         (print_mention_watchpoint, print_mention_masked_watchpoint)
3947         (bkpt_print_it, update_static_tracepoint): Update.
3948         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3949         * break-catch-syscall.c (print_it_catch_syscall): Update.
3950         * ada-tasks.c (print_ada_task_info): Update.
3951         * ada-lang.c (print_it_exception, print_mention_exception):
3952         Update.
3953
3954 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         PR breakpoints/24541
3957         * gdbarch.c: Regenerate.
3958         * gdbarch.h: Regenerate.
3959         * gdbarch.sh: Adjust return type and parameter types for
3960         'stap_adjust_register'.
3961         (i386_stap_adjust_register): Adjust signature and return new
3962         register name.
3963         * stap-probe.c (stap_parse_register_operand): Adjust use of
3964         'gdbarch_stap_adjust_register'.
3965
3966 2019-07-17  Tom Tromey  <tromey@adacore.com>
3967
3968         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3969         declare VEC.
3970         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3971         std::vector.
3972         (struct s390_process_info): Add initializers.
3973         (s390_add_process): Use new.
3974         (s390_linux_nat_target::low_forget_process): Use delete.
3975         (s390_linux_nat_target::low_new_fork)
3976         (s390_linux_nat_target::stopped_by_watchpoint)
3977         (s390_linux_nat_target::low_prepare_to_resume)
3978         (s390_linux_nat_target::insert_watchpoint)
3979         (s390_linux_nat_target::insert_hw_breakpoint)
3980         (s390_linux_nat_target::remove_watchpoint)
3981         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3982
3983 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3984
3985         * aarch64-fbsd-nat.c: Include regcache.h.
3986         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3987         argument.
3988         (aarch64_fbsd_nat_target::fetch_registers)
3989         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3990         variable.
3991         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3992
3993 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3994
3995         * fbsd-nat.c: Include gdbarch.h.
3996
3997 2019-07-15  Tom Tromey  <tromey@adacore.com>
3998
3999         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4000
4001 2019-07-15  Tom Tromey  <tromey@adacore.com>
4002
4003         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4004         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4005         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4006         * cli-out.c (cli_ui_out::do_field_int): New method.
4007         * ui-out.c (ui_out::field_unsigned): New method.
4008         * symfile.c (generic_load): Use field_unsigned.
4009         (print_transfer_performance): Likewise.
4010         * record-btrace.c (ui_out_field_uint): Remove.
4011         (btrace_call_history_insn_range, btrace_call_history): Use
4012         field_unsigned.
4013         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4014         field_unsigned.
4015         * ui-out.h (class ui_out) <field_unsigned>: New method.
4016         <do_field_unsigned>: Likewise.
4017
4018 2019-07-15  Tom Tromey  <tromey@adacore.com>
4019
4020         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4021         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4022         * target.c (flash_erase_command): Use field_string.
4023         * infrun.c (print_signal_received_reason): Use field_string.
4024         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4025         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4026         field_string.
4027         * ada-tasks.c (print_ada_task_info): Use field_string.
4028
4029 2019-07-15  Tom Tromey  <tromey@adacore.com>
4030
4031         * target.c (flash_erase_command): Use field_core_addr.
4032         * symfile.c (generic_load): Use field_core_addr.
4033         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4034         Use field_core_addr.
4035         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4036         field_core_addr.
4037
4038 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4041         value if its desired type is smaller than a CORE_ADDR and signed.
4042
4043 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4046         of changes to field names, and use new is_reference field to
4047         decide if a property is a reference or not.
4048         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4049         field.
4050         (struct dwarf2_property_baton): Update header comment, rename
4051         'referenced_type' to 'property_type' and update comments.
4052         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4053         default property type, store in property baton, update to take
4054         accound of renamed field.
4055         (read_func_scope): Update call to attr_to_dynamic_prop.
4056         (read_array_type): Likewise.
4057         (dwarf2_per_cu_addr_sized_int_type): New function.
4058         (read_subrange_index_type): Move type finding code to
4059         dwarf2_per_cu_addr_sized_int_type.
4060         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4061         (dwarf2_per_cu_addr_type): New function.
4062         (set_die_type): Update calls to attr_to_dynamic_prop.
4063
4064 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * dwarf2read.c (read_subrange_index_type): New function.
4067         (read_subrange_type): Move code into new function and call it.
4068         * gdbtypes.c (create_range_type): Add some asserts.
4069
4070 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4073         update return statements.
4074         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4075         declaration, and update comment to match.
4076         * gdbtypes.c (resolve_dynamic_array): Update call to
4077         dwarf2_evaluate_property to match new return type.
4078
4079 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4080
4081         * valarith.c (value_subscripted_rvalue): Change lowerbound
4082         parameter type from int to LONGEST.
4083         * value.h (value_subscripted_rvalue): Likewise in declaration.
4084
4085 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * cli/cli-utils.c (info_print_command_completer): New function.
4088         * cli/cli-utils.h: Add 'completer.h' include, and forward
4089         declaration for 'struct cmd_list_element'.
4090         (info_print_command_completer): Declare.
4091         * stack.c (_initialize_stack): Add completer for 'info locals' and
4092         'info args'.
4093         * symtab.c (_initialize_symtab): Add completer for 'info
4094         variables' and 'info functions'.
4095         * NEWS: Mention completion for additional info commands.
4096
4097 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * cli/cli-utils.c (extract_info_print_args): Delete.
4100         (extract_arg_maybe_quoted): Delete.
4101         (info_print_options_defs): New variable.
4102         (make_info_print_options_def_group): New function.
4103         (extract_info_print_options): Define new function.
4104         * cli/cli-utils.h (extract_info_print_args): Delete.
4105         (struct info_print_options): New structure.
4106         (extract_info_print_options): Declare new function.
4107         * stack.c (info_locals_command): Update to use new
4108         extract_info_print_options, also add a header comment.
4109         (info_args_command): Likewise.
4110         * symtab.c (info_variables_command): Likewise.
4111         (info_functions_command): Likewise.
4112
4113 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4116         to extract string arguments.
4117         * common/common-utils.c (extract_string_maybe_quoted): New function.
4118         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4119
4120 2019-07-11  Tom Tromey  <tromey@adacore.com>
4121
4122         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4123         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4124         * top.h (gdbinit): Don't declare.
4125         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4126         into...
4127         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4128         * top.c (gdb_init): Don't call init_cli_cmds.
4129         (gdbinit): Remove.
4130         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4131
4132 2019-07-11  Tom Tromey  <tromey@adacore.com>
4133
4134         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4135         after it has been moved.
4136
4137 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4138
4139         * valops.c (value_must_coerce_to_target): Change return type to
4140         bool.
4141         * value.h (value_must_coerce_to_target): Likewise.
4142
4143 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4144
4145         * breakpoint.c (is_hardware_watchpoint): Remove
4146         forward-declaration.
4147         (is_masked_watchpoint): Change return type to bool.
4148         (is_tracepoint): Likewise.
4149         (is_breakpoint): Likewise.
4150         (is_hardware_watchpoint): Likewise.
4151         (is_watchpoint): Likewise.
4152         (is_no_memory_software_watchpoint): Likewise.
4153         (is_catchpoint): Likewise.
4154         (breakpoint_1): Make FILTER parameter's return type bool.
4155         is_masked_watchpoint): Change return type to bool.
4156         (save_breakpoints): Make FILTER parameter's return type bool.
4157         * breakpoint.h (is_breakpoint): Change return type to bool.
4158         (is_watchpoint): Likewise.
4159         (is_catchpoint): Likewise.
4160         (is_tracepoint): Likewise.
4161
4162 2019-07-10  Tom Tromey  <tom@tromey.com>
4163
4164         * defs.h: Don't include gdbarch.h.
4165         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4166         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4167         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4168         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4169         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4170         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4171         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4172         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4173         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4174         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4175         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4176         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4177         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4178         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4179         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4180         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4181         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4182         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4183         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4184         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4185         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4186         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4187         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4188         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4189         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4190         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4191         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4192
4193 2019-07-10  Tom Tromey  <tromey@adacore.com>
4194
4195         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4196         * breakpoint.c (init_ada_exception_breakpoint): Register as
4197         bp_catchpoint.
4198         (print_one_breakpoint_location, print_one_breakpoint): Use
4199         is_ada_exception_catchpoint.
4200         * ada-lang.c (class ada_catchpoint_location): Pass
4201         bp_loc_software_breakpoint to bp_location constructor.
4202         (is_ada_exception_catchpoint): New function.
4203
4204 2019-07-10  Tom Tromey  <tromey@adacore.com>
4205
4206         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4207         VEC.
4208         (struct arm_exidx_entry): New method operator<.
4209         (struct arm_exidx_data) <section_maps>: Change type.
4210         (arm_exidx_data_free): Remove.
4211         (arm_exidx_data_key): Change type.  Move lower.
4212         (arm_exidx_new_objfile): Update.
4213         (arm_compare_exidx_entries): Remove.
4214         (arm_find_exidx_entry, _initialize_arm_tdep)
4215
4216 2019-07-10  Tom Tromey  <tromey@adacore.com>
4217
4218         * solib-spu.c (ocl_program_data_key): Change type.
4219         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4220         Update.
4221
4222 2019-07-10  Tom Tromey  <tromey@adacore.com>
4223
4224         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4225         (struct solib_aix_inferior_data) <library_list>: Change type.
4226         (solib_aix_inferior_data_handle): Change type.
4227         (get_solib_aix_inferior_data): Update.
4228         (solib_aix_free_library_list): Remove.
4229         (library_list_start_library): Update.
4230         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4231         return type.
4232         (solib_aix_get_library_list)
4233         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4234         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4235
4236 2019-07-10  Tom Tromey  <tromey@adacore.com>
4237
4238         * solib-dsbt.c (struct dsbt_info): Add initializers.
4239         (solib_dsbt_pspace_data): Change type.
4240         (dsbt_pspace_data_cleanup): Remove.
4241         (get_dsbt_info, _initialize_dsbt_solib): Update.
4242
4243 2019-07-10  Tom Tromey  <tromey@adacore.com>
4244
4245         * spu-tdep.c (spu_overlay_data): Change type.
4246         (spu_get_overlay_table, spu_overlay_new_objfile)
4247         (_initialize_spu_tdep): Update.
4248
4249 2019-07-10  Tom Tromey  <tromey@adacore.com>
4250
4251         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4252         destructor.
4253         (dbx_objfile_data_key): Change type and declare later.
4254         (DBX_SYMFILE_INFO): Rewrite.
4255         * dbxread.c (dbx_objfile_data_key): Change type.
4256         (dbx_symfile_init): Update.
4257         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4258         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4259         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4260
4261 2019-07-10  Tom Tromey  <tromey@adacore.com>
4262
4263         * jit.c (jit_program_space_key): Change type.  Move lower.
4264         (get_jit_program_space_data): Update.
4265         (jit_program_space_data_cleanup): Remove.
4266         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4267         Update.
4268         (struct jit_program_space_data): Add initializers.
4269
4270 2019-07-10  Tom Tromey  <tromey@adacore.com>
4271
4272         * solib-darwin.c (struct darwin_info): Add initializers.
4273         (solib_darwin_pspace_data): Change type.
4274         (darwin_pspace_data_cleanup): Remove.
4275         (get_darwin_info, _initialize_darwin_solib): Update.
4276
4277 2019-07-10  Tom Tromey  <tromey@adacore.com>
4278
4279         * remote-sim.c (struct sim_inferior_data): Add initializers,
4280         constructor, and destructor.
4281         (sim_inferior_data_key): Change type.  Move lower.
4282         (check_for_duplicate_sim_descriptor): Update.
4283         (get_sim_inferior_data): Use new.  Update.
4284         (~sim_inferior_data_cleanup): Rename from
4285         sim_inferior_data_cleanup.  Simplify.
4286         (gdbsim_close_inferior, simulator_command)
4287         (sim_command_completer, _initialize_remote_sim): Update.
4288         (next_pid, INITIAL_PID): Move earlier.
4289
4290 2019-07-10  Tom Tromey  <tromey@adacore.com>
4291
4292         * python/python-internal.h (create_thread_object): Return
4293         gdbpy_ref.
4294         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4295         * python/py-inferior.c (struct threadlist_entry): Add
4296         constructor.
4297         <thread_obj>: Now a gdbpy_ref.
4298         (thread_to_thread_object): Update.
4299         (add_thread_object): Use new.
4300         (delete_thread_object): Use delete.
4301         (infpy_threads): Update.
4302         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4303         GIL.
4304
4305 2019-07-10  Tom Tromey  <tromey@adacore.com>
4306
4307         * valops.c (value_cast): Specialize error message for Ada.
4308
4309 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4310
4311         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4312
4313 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4314
4315         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4316         bpstat_should_step): Return bool, adjust comments.
4317         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4318         bpstat_should_step): Likewise.
4319
4320 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4321
4322         * features/Makefile: Use feature target descriptions for Arm.
4323         * features/arm/arm-core.c: Generate new file.
4324         * features/arm/arm-fpa.c: Likewise.
4325         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4326         * features/arm/arm-m-profile.c: Likewise.
4327         * features/arm/arm-vfpv2.c: Likewise.
4328         * features/arm/arm-vfpv3.c: Likewise.
4329         * features/arm/xscale-iwmmxt.c: Likewise.
4330         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4331
4332 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4333
4334         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4335         ptrace earlier.
4336
4337 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4338
4339         * features/aarch64-pauth.c: Regenerate.
4340
4341 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4342
4343         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4344         bool.
4345         (bpstat_what): Use false instead of 0.
4346
4347 2019-07-09  Pedro Alves  <palves@redhat.com>
4348
4349         * break-catch-throw.c (is_exception_catchpoint): New.
4350         * breakpoint.c (print_one_breakpoint_location): New parameter
4351         'raw_loc'.  Handle it.  Use
4352         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4353         looking at the breakpoint's type.
4354         (print_one_breakpoint): If handling "maint info breakpoints", also
4355         print locations of exception catchpoints.
4356         * breakpoint.h (is_exception_catchpoint): Declare.
4357
4358 2019-07-09  Pedro Alves  <palves@redhat.com>
4359
4360         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4361         "addr" field.
4362         (allocate_location_exception_catchpoint): New.
4363         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4364         (initialize_throw_catchpoint_ops): Install
4365         allocate_location_exception_catchpoint as allocate_location
4366         method.
4367         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4368         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4369         bp_loc_other.
4370         (breakpoint_address_is_meaningful): Delete.
4371         (bl_address_is_meaningful): New.
4372         (breakpoint_locations_match): Adjust comment.
4373         (bp_location_from_bp_type): New, factored out of...
4374         (bp_location::bp_location(breakpoint *)): ... this.
4375         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4376         factored out of...
4377         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4378         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4379         breakpoint_address_is_meaningful.
4380         (bp_locations_compare): Adjust comment.
4381         (update_global_location_list): Use bl_address_is_meaningful
4382         instead of breakpoint_address_is_meaningful.
4383         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4384         explicit.
4385         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4386         * python/py-breakpoint.c (bppy_get_location): No longer check
4387         whether location is null.
4388
4389 2019-07-09  Pedro Alves  <palves@redhat.com>
4390
4391         PR c++/15468
4392         * breakpoint.c (print_one_breakpoint_location): Remove
4393         single-location assert.
4394
4395 2019-07-09  Tom Tromey  <tom@tromey.com>
4396
4397         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4398         * configure: Rebuild.
4399         * configure.ac: Change common to gdbsupport.
4400         * gdbsupport: Rename from common.
4401         * acinclude.m4: Change common to gdbsupport.
4402         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4403         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4404         gdbsupport.
4405         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4406         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4407         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4408         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4409         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4410         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4411         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4412         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4413         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4414         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4415         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4416         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4417         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4418         coff-pe-read.c, command.h, compile/compile-c-support.c,
4419         compile/compile-c.h, compile/compile-cplus-symbols.c,
4420         compile/compile-cplus-types.c, compile/compile-cplus.h,
4421         compile/compile-loc2c.c, compile/compile.c, completer.c,
4422         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4423         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4424         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4425         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4426         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4427         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4428         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4429         features/aarch64-core.c, features/aarch64-fpu.c,
4430         features/aarch64-pauth.c, features/aarch64-sve.c,
4431         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4432         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4433         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4434         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4435         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4436         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4437         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4438         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4439         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4440         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4441         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4442         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4443         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4444         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4445         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4446         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4447         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4448         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4449         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4450         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4451         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4452         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4453         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4454         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4455         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4456         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4457         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4458         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4459         minsyms.c, mips-linux-tdep.c, namespace.h,
4460         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4461         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4462         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4463         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4464         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4465         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4466         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4467         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4468         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4469         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4470         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4471         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4472         procfs.c, producer.c, progspace.h, psymtab.h,
4473         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4474         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4475         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4476         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4477         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4478         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4479         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4480         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4481         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4482         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4483         target-memory.c, target.c, target.h, target/waitstatus.c,
4484         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4485         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4486         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4487         unittests/array-view-selftests.c,
4488         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4489         unittests/common-utils-selftests.c,
4490         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4491         unittests/format_pieces-selftests.c,
4492         unittests/function-view-selftests.c,
4493         unittests/lookup_name_info-selftests.c,
4494         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4495         unittests/mkdir-recursive-selftests.c,
4496         unittests/observable-selftests.c,
4497         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4498         unittests/parse-connection-spec-selftests.c,
4499         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4500         unittests/scoped_fd-selftests.c,
4501         unittests/scoped_mmap-selftests.c,
4502         unittests/scoped_restore-selftests.c,
4503         unittests/string_view-selftests.c, unittests/style-selftests.c,
4504         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4505         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4506         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4507         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4508         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4509         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4510
4511 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4514         bool value.
4515         (decode_digits_ordinary): Set explicit_line field in sal.
4516         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4517         symtab_and_line that was set on an explicit line number in
4518         assembler code.  Do always update the recorded symtab and line if
4519         we do skip the prologue.
4520
4521 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * breakpoint.c (set_breakpoint_location_function): Remove
4524         explicit_loc parameter.
4525         (momentary_breakpoint_from_master): Update call to
4526         set_breakpoint_location_function.
4527         (add_location_to_breakpoint): Likewise.
4528
4529 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4532         required features based on default bfd type when no specific bfd
4533         is present.
4534
4535 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4536
4537         * NEWS: Mention that GDB printf and eval commands can now print
4538         C-style and Ada-style convenience var strings without
4539         calling the inferior.
4540         * printcmd.c (printf_c_string): Locally print GDB internal var
4541         instead of transiting via the inferior.
4542         (printf_wide_c_string): Likewise.
4543
4544 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4545
4546         PR breakpoints/25011
4547         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4548
4549 2019-07-04  Tom Tromey  <tom@tromey.com>
4550
4551         PR tui/24724:
4552         * tui/tui-winsource.c (tui_clear_source_content): Update.
4553         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4554         (tui_update_breakpoint_info): Update.
4555         (tui_set_exec_info_content): Update.
4556         * tui/tui-source.c (tui_set_source_content_nil): Update.
4557         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4558         has_break.
4559         * tui/tui-data.h (enum tui_bp_flag): New.
4560         (tui_bp_flags): New enum flags type.
4561         (struct tui_source_element) <break_mode>: Change type.  Rename
4562         from has_break.
4563         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4564         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4565         constants.
4566         * tui/tui-winsource.h: Fix comment.
4567
4568 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4569
4570         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4571         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4572         (store_fpregs_to_thread)
4573         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4574         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4575         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4576         (IWMMXT_REGS_SIZE): Add define.
4577         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4578         (fetch_vfp_regs, store_vfp_regs)
4579         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4580         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4581
4582 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4583
4584         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4585         defines.
4586         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4587         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4588         (ARM_INT_REGISTER_SIZE): ...to this.
4589         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4590         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4591         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4592         (arm_linux_collect_gregset, supply_nwfpe_register)
4593         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4594         defines.
4595         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4596         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4597         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4598         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4599         (arm_return_in_memory, arm_store_return_value)
4600         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4601         (arm_record_ld_st_multiple): Likewise.
4602         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4603         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4604
4605 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4606
4607         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4608         AARCH64_DISPLACED_MODIFIED_INSNS.
4609         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4610         (aarch64_displaced_step_copy_insn): Likewise.
4611         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4612         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4613         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4614         ARM_DISPLACED_MODIFIED_INSNS.
4615         * arm-tdep.c (arm_gdbarch_init): Likewise.
4616         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4617         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4618         (struct arm_displaced_step_closure): Use
4619         ARM_DISPLACED_MODIFIED_INSNS.
4620
4621 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4622
4623         * features/Makefile: Remove unused xml files.
4624         * features/aarch64.xml: Remove.
4625         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4626         * features/i386/amd64-avx-avx512.xml: Remove.
4627         * features/i386/amd64-avx-linux.xml: Remove.
4628         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4629         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4630         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4631         * features/i386/amd64-avx-mpx.xml: Remove.
4632         * features/i386/amd64-avx.xml: Remove.
4633         * features/i386/amd64-linux.xml: Remove.
4634         * features/i386/amd64-mpx-linux.xml: Remove.
4635         * features/i386/amd64-mpx.xml: Remove.
4636         * features/i386/amd64.xml: Remove.
4637         * features/i386/i386-avx-avx512-linux.xml: Remove.
4638         * features/i386/i386-avx-avx512.xml: Remove.
4639         * features/i386/i386-avx-linux.xml: Remove.
4640         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4641         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4642         * features/i386/i386-avx-mpx-linux.xml: Remove.
4643         * features/i386/i386-avx-mpx.xml: Remove.
4644         * features/i386/i386-avx.xml: Remove.
4645         * features/i386/i386-linux.xml: Remove.
4646         * features/i386/i386-mmx-linux.xml: Remove.
4647         * features/i386/i386-mmx.xml: Remove.
4648         * features/i386/i386-mpx-linux.xml: Remove.
4649         * features/i386/i386-mpx.xml: Remove.
4650         * features/i386/i386.xml: Remove.
4651         * features/i386/x32-avx-avx512-linux.xml: Remove.
4652         * features/i386/x32-avx-linux.xml: Remove.
4653         * features/i386/x32-linux.xml: Remove.
4654
4655 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4656
4657         * regformats/aarch64.dat: Remove.
4658         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4659         * regformats/i386/amd64-avx-linux.dat: Remove.
4660         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4661         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4662         * regformats/i386/amd64-linux.dat: Remove.
4663         * regformats/i386/amd64-mpx-linux.dat: Remove.
4664         * regformats/i386/amd64.dat: Remove.
4665         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4666         * regformats/i386/i386-avx-linux.dat: Remove.
4667         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4668         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4669         * regformats/i386/i386-linux.dat: Remove.
4670         * regformats/i386/i386-mmx-linux.dat: Remove.
4671         * regformats/i386/i386-mpx-linux.dat: Remove.
4672         * regformats/i386/i386.dat: Remove.
4673         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4674         * regformats/i386/x32-avx-linux.dat: Remove.
4675         * regformats/i386/x32-linux.dat: Remove.
4676
4677 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4678
4679         * aarch64-tdep.c: Remove xml self tests.
4680         * amd64-linux-tdep.c: Likewise.
4681         * amd64-tdep.c: Likewise.
4682         * i386-linux-tdep.c: Likewise.
4683         * i386-tdep.c: Likewise.
4684
4685 2019-07-03  Pedro Alves  <palves@redhat.com>
4686
4687         PR cli/24732
4688         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4689         (pipe_cmd_option_defs): New.
4690         (make_pipe_cmd_options_def_group): New.
4691         (pipe_command): Use gdb::option::process_options.
4692         (pipe_command_completer): New function.
4693         (_initialize_cli_cmds): Install completer for "pipe" command.
4694
4695 2019-07-03  Pedro Alves  <palves@redhat.com>
4696
4697         * cli/cli-option.c (union option_value) <string>: New field.
4698         (struct option_def_and_value): Add ctor, move ctor, dtor and
4699         use DISABLE_COPY_AND_ASSIGN.
4700         (option_def_and_value::clear_value): New.
4701         (parse_option, save_option_value_in_ctx, get_val_type_str)
4702         (add_setshow_cmds_for_options): Handle var_string.
4703         * cli-option.h (union option_def::var_address) <string>: New
4704         field.
4705         (struct string_option_def): New.
4706         * maint-test-options.c (struct test_options_opts): Add default
4707         ctor and use DISABLE_COPY_AND_ASSIGN.
4708         <string_opt>: New field.
4709         (test_options_opts::~test_options_opts): New.
4710         (test_options_opts::dump): Also dump "-string".
4711         (test_options_option_defs): Install "string.
4712
4713 2019-07-03  Pedro Alves  <palves@redhat.com>
4714
4715         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4716         option_value with a null enumeration.
4717         (complete_options): Save the option values in the context.
4718         (save_option_value_in_ctx): New, factored out from ...
4719         (process_options): ... here.
4720         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4721         of the function.
4722         * maint-test-options.c (test_options_opts::dump): New, factored
4723         out from ...
4724         (maintenance_test_options_command_mode): ... here.
4725         (maintenance_test_options_command_completion_result): Delete.
4726         (maintenance_test_options_command_completion_text): Update
4727         comment.
4728         (maintenance_show_test_options_completion_result): Change
4729         prototype.  Just print
4730         maintenance_test_options_command_completion_text.
4731         (save_completion_result): New.
4732         (maintenance_test_options_completer_mode): Pass options context to
4733         complete_options, and then save a dump.
4734         (_initialize_maint_test_options): Use add_cmd to install "maint
4735         show test-options-completion-result".
4736
4737 2019-07-03  Pedro Alves  <palves@redhat.com>
4738
4739         * NEWS (New commands): Mention "with" and "maint with".
4740         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4741         (with_command, with_command_completer): New.
4742         (pipe_command): Adjust to new repeat_previous
4743         interface.
4744         (_initialize_cli_cmds): Install the "with" command and its "w"
4745         alias.
4746         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4747         declarations.
4748         * cli/cli-setshow.c (parse_cli_var_uinteger)
4749         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4750         argument strings for all var_types.
4751         (get_setshow_command_value_string): New, factored out from ...
4752         (do_show_command): ... this.
4753         * cli/cli-setshow.h: Include <string>.
4754         (get_setshow_command_value_string): Declare.
4755         * command.h (repeat_previous): Now returns const char *.  Adjust
4756         comment.
4757         * maint.c: Include "cli/cli-cmds.h".
4758         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4759         (_initialize_maint_cmds): Register the "maintenance with" command.
4760         * top.c (repeat_previous): Move bits from pipe_command here:
4761         Return the saved command line, if any; error out if there's no
4762         command to relaunch.
4763
4764 2019-07-03  Pedro Alves  <palves@redhat.com>
4765
4766         * NEWS (New commands): Mention "maint set/show test-settings"
4767         instead of "maint test-settings".
4768         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4769         (maintenance_test_settings_set_list): Rename to ...
4770         (maintenance_set_test_settings_list): ... this.
4771         (maintenance_test_settings_show_list): Rename to  ...
4772         (maintenance_show_test_settings_list): ... this.
4773         (maintenance_test_settings_cmd): Delete.
4774         (maintenance_test_settings_set_cmd): ...
4775         (maintenance_set_test_settings_cmd): ... this.
4776         (maintenance_test_settings_show_cmd): ...
4777         (maintenance_show_test_settings_cmd): ... this.
4778         (maintenance_test_settings_show_value_cmd):
4779         (maintenance_show_test_settings_value_cmd): ... this.
4780         (_initialize_maint_test_settings): No longer install the "maint
4781         test-settings" prefix command.  Rename "maint test-settings set"
4782         to "maint set test-settings", and "maint test-settings show" to
4783         "maint show test-settings".  Adjust all subcommands.
4784
4785 2019-07-03  Pedro Alves  <palves@redhat.com>
4786
4787         * maint-test-settings.c: Fix file's intro comment.  Replace all
4788         references to "test-options" with references to "test-settings",
4789         in comments.
4790
4791 2019-07-03  Pedro Alves  <palves@redhat.com>
4792
4793         * maint-test-settings.c (maintenance_test_settings_xxx)
4794         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4795         New.
4796         (maintenance_test_settings_enums): Use them.
4797         (maintenance_test_settings_enum): Default to
4798         maintenance_test_settings_xxx.
4799         (_initialize_maint_test_settings): Initialize
4800         MAINTENANCE_TEST_SETTINGS_FILENAME.
4801
4802 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4803
4804         * breakpoint.h (remove_breakpoints_inf): Change return type to
4805         void, move function documentation here.
4806         * breakpoint.c (remove_breakpoints_inf): Change return type to
4807         void, move function documentation to header.
4808
4809 2019-07-02  Pedro Alves  <palves@redhat.com>
4810
4811         * NEWS (Completion improvements): Mention "info threads".
4812         * thread.c (struct info_threads_opts, info_threads_option_defs)
4813         (make_info_threads_options_def_group): New.
4814         (info_threads_command): Use gdb::option::process_options.
4815         (info_threads_command_completer): New.
4816         (_initialize_thread): Use gdb::option::build_help to build the
4817         help text for "info threads".
4818
4819 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4820
4821         * defs.h (generic_load): Move from here...
4822         * symfile.h (generic_load): ... to here.  Rename name parameter
4823         to args.
4824         * symfile.c (generic_load): Add comment.
4825
4826 2019-07-01  Tom Tromey  <tromey@adacore.com>
4827
4828         * dwarf2read.c
4829         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4830         declaration of without_params.  Fix formatting.
4831
4832 2019-07-01  Tom Tromey  <tromey@adacore.com>
4833
4834         * ada-exp.y (find_primitive_type): Update.
4835         * ada-lang.h (ada_lookup_symbol): Update.
4836         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4837         parameter.
4838         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4839
4840 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4841
4842         PR breakpoints/24541
4843         * gdbarch.c: Regenerate.
4844         * gdbarch.h: Regenerate.
4845         * gdbarch.sh: Add 'stap_adjust_register'.
4846         * i386-tdep.c: Include '<unordered_set>'.
4847         (i386_stap_adjust_register): New function.
4848         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4849         * stap-probe.c (stap_parse_register_operand): Call
4850         'gdbarch_stap_adjust_register'.
4851
4852 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4853
4854         PR python/24742
4855         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4856         * python/python.c (do_start_initialization): Use 'xmalloc'
4857         instead of 'PyMem_Malloc'.
4858
4859 2019-06-28  Tom Tromey  <tromey@adacore.com>
4860
4861         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4862         for Ada.
4863
4864 2019-06-27  Tom Tromey  <tromey@adacore.com>
4865
4866         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4867         objfile_key.
4868         (arm_find_mapping_symbol, arm_record_special_symbol)
4869         (_initialize_arm_tdep): Update.
4870         (arm_objfile_data_free): Remove.
4871
4872 2019-06-27  Tom Tromey  <tromey@adacore.com>
4873
4874         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4875         to cp_print_static_field.
4876
4877 2019-06-26  Tom Tromey  <tromey@adacore.com>
4878
4879         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4880         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4881         declare.
4882
4883 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4884
4885         * features/aarch64-core.c (create_feature_aarch64_core):
4886         Regenerate.
4887         * features/aarch64-core.xml: Add cpsr flags.
4888
4889 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4890
4891         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4892         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4893
4894 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4895
4896         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4897         field.
4898         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4899         use.
4900         (arm_record_special_symbol): Don't insert new symbol in sorted
4901         position, push it at the end.
4902
4903 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4904
4905         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4906         (arm_mapping_symbol_s): Remove.
4907         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4908         (arm_mapping_symbol_vec): New typedef.
4909         (struct arm_per_objfile): Add constructor.
4910         <section_maps>: Change type to
4911         std::unique_ptr<arm_mapping_symbol_vec[]>.
4912         (arm_compare_mapping_symbols): Remove.
4913         (arm_find_mapping_symbol): Adjust to section_maps type change.
4914         (arm_objfile_data_free): Call delete on arm_per_objfile.
4915         (arm_record_special_symbol): Adjust to section_maps type change.
4916         Allocate arm_per_objfile with new.
4917
4918 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4919
4920         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4921         with the command prefix.
4922
4923 2019-06-25  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4926         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4927
4928 2019-06-25  Tom Tromey  <tom@tromey.com>
4929
4930         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4931         type.
4932         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4933         protected.
4934
4935 2019-06-25  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-winsource.c
4938         (tui_source_window_base::set_is_exec_point_at): Add check against
4939         LOA_ADDRESS.
4940
4941 2019-06-25  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-source.c (tui_set_source_content): Don't check before
4944         xfree.
4945         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4946
4947 2019-06-25  Tom Tromey  <tom@tromey.com>
4948
4949         * tui/tui-winsource.h (tui_update_source_window_as_is)
4950         (tui_alloc_source_buffer, tui_line_is_displayed)
4951         (tui_addr_is_displayed): Change type of win_info.
4952         * tui/tui-winsource.c (tui_update_source_window_as_is)
4953         (tui_clear_source_content, tui_show_source_line)
4954         (tui_show_source_content, tui_source_window_base::refill)
4955         (tui_source_window_base::set_is_exec_point_at)
4956         (tui_source_window_base::set_is_exec_point_at)
4957         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4958         (tui_alloc_source_buffer, tui_line_is_displayed)
4959         (tui_addr_is_displayed): Change type of win_info.  Update.
4960         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4961         (tui_source_window_base::do_make_visible_with_new_height):
4962         Update.
4963         * tui/tui-source.c (tui_set_source_content)
4964         (tui_set_source_content_nil)
4965         (tui_source_window::do_scroll_vertical): Update.
4966         * tui/tui-layout.c (show_layout): Update.
4967         * tui/tui-disasm.c (tui_set_disassem_content)
4968         (tui_disasm_window::do_scroll_vertical): Update.
4969         * tui/tui-data.h (tui_win_content): Remove.
4970         (struct tui_gen_win_info) <content, content_size>: Remove.
4971         (struct tui_source_element): Add initializers and destructor.
4972         (union tui_which_element, struct tui_win_element): Remove.
4973         (struct tui_source_window_base) <content>: New field.
4974         (struct tui_data_window): Remove destructor.
4975         (tui_alloc_content, tui_free_win_content)
4976         (tui_free_all_source_wins_content): Don't declare.
4977         * tui/tui-data.c (tui_initialize_static_data): Update.
4978         (init_content_element, tui_alloc_content): Remove.
4979         (~tui_gen_win_info): Update.
4980         (~tui_data_window, tui_free_all_source_wins_content)
4981         (tui_free_win_content, free_content, free_content_elements):
4982         Remove.
4983
4984 2019-06-25  Tom Tromey  <tom@tromey.com>
4985
4986         * tui/tui-winsource.h (tui_clear_source_content)
4987         (tui_erase_source_content, tui_show_source_content): Change type
4988         of win_info.
4989         * tui/tui-winsource.c (tui_clear_source_content)
4990         (tui_erase_source_content, tui_show_source_content): Change type
4991         of win_info.
4992         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4993         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4994         win_info.
4995         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4996         win_info.
4997         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4998
4999 2019-06-25  Tom Tromey  <tom@tromey.com>
5000
5001         * tui/tui-winsource.c (tui_clear_source_content)
5002         (tui_source_window_base::set_is_exec_point_at): Update.
5003         * tui/tui-source.c (tui_set_source_content_nil): Update.
5004         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5005         a bool.
5006         * tui/tui-data.c (init_content_element): Update.
5007
5008 2019-06-25  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5011         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5012         * tui/tui-layout.c (init_and_make_win): Update.
5013         * tui/tui.h (enum tui_win_type): Update.
5014         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5015         tui_win_is_auxillary.
5016         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5017         tui_win_is_auxillary.
5018
5019 2019-06-25  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5022         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5023         (tui_delete_data_content_windows, tui_display_all_data)
5024         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5025         Update.
5026         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5027         * tui/tui-regs.c (tui_last_regs_line_no)
5028         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5029         (tui_show_registers): Update.
5030         (tui_show_register_group): Return void.  Update.
5031         (tui_display_registers_from, tui_display_reg_element_at_line)
5032         (tui_display_registers_from_line, tui_check_register_values):
5033         Update.
5034         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5035         member.
5036         (struct tui_data_window) <regs_content>: Now a std::vector.
5037         <regs_content_count>: Remove.
5038         (tui_add_content_elements, tui_free_data_content): Don't declare.
5039         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5040         (init_content_element): Remove DATA_WIN case.  Add assert.
5041         (tui_add_content_elements): Remove.
5042         (tui_data_window): Update.
5043         (tui_free_data_content): Remove.
5044         (free_content_elements): Remove DATA_WIN case.
5045
5046 2019-06-25  Tom Tromey  <tom@tromey.com>
5047
5048         * tui/tui-data.c (tui_data_item_window): Update.
5049         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5050         * tui/tui-windata.c (tui_display_all_data)
5051         (tui_display_data_from_line): Update.
5052         (tui_check_data_values): Remove.
5053         * tui/tui-regs.c (tui_show_register_group)
5054         (tui_display_reg_element_at_line): Update.
5055         * tui/tui-hooks.c (tui_register_changed)
5056         (tui_refresh_frame_and_register_information): Call
5057         tui_check_register_values.
5058         * tui/tui-data.h (struct tui_data_window) <data_content,
5059         data_content_count, data_type>: Remove.
5060         (enum tui_data_type): Remove.
5061
5062         * tui/tui-data.c (tui_data_window::clear_detail)
5063         (~tui_data_window): Update.
5064
5065 2019-06-25  Tom Tromey  <tom@tromey.com>
5066
5067         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5068         declare.
5069         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5070         Rename from tui_first_data_item_displayed.  Update.
5071         (tui_data_window::refresh_all)
5072         (tui_data_window::do_scroll_vertical): Update.
5073         * tui/tui-data.h (struct tui_data_window)
5074         <first_data_item_displayed>: Declare new method.
5075
5076 2019-06-25  Tom Tromey  <tom@tromey.com>
5077
5078         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5079         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5080         contents...
5081         (tui_initialize_static_data): ...here.
5082
5083 2019-06-25  Tom Tromey  <tom@tromey.com>
5084
5085         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5086         (tui_display_registers_from, tui_check_register_values): Update.
5087         (tui_display_register): Remove win_info parameter; update.
5088         (tui_get_register): Change type of parameters.
5089         * tui/tui-data.h (struct tui_data_element): Remove.
5090         (union tui_which_element) <data>: Remove.
5091         <data_window>: Change type.
5092         (struct tui_data_item_window): New.
5093         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5094         case.  Add assert.
5095         (~tui_data_item_window): New destructor.
5096         (free_content_elements): Remove DATA_ITEM_WIN case.
5097
5098 2019-06-25  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5101         Remove.
5102
5103 2019-06-25  Tom Tromey  <tom@tromey.com>
5104
5105         * tui/tui-data.h (struct tui_command_element): Remove.
5106         (union tui_which_element) <command>: Remove.
5107         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5108         assert.
5109         (free_content_elements): Remove CMD_WIN case.
5110
5111 2019-06-25  Tom Tromey  <tom@tromey.com>
5112
5113         * tui/tui-layout.c (tui_set_layout): Update.
5114         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5115         * tui/tui-data.c (layout_def): Update.
5116
5117 2019-06-25  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5120         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5121         (tui_source_window_base::set_new_height): Update.
5122         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5123         Update.
5124         (tui_set_locator_fullname, tui_set_locator_info)
5125         (tui_show_frame_info): Update.
5126         * tui/tui-source.c (tui_set_source_content)
5127         (tui_source_is_displayed): Update.
5128         * tui/tui-layout.c (show_source_disasm_command, show_data)
5129         (show_source_or_disasm_and_command): Update.
5130         * tui/tui-disasm.c (tui_set_disassem_content)
5131         (tui_get_begin_asm_address): Update.
5132         * tui/tui-data.h (struct tui_locator_element): Remove.
5133         (union tui_which_element) <locator>: Remove.
5134         (struct tui_locator_window): New.
5135         (tui_locator_win_info_ptr): Change return type.
5136         * tui/tui-data.c (_locator): Change type.
5137         (tui_locator_win_info_ptr): Change return type.
5138         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5139         (tui_alloc_content): Add assert.
5140
5141 2019-06-25  Tom Tromey  <tom@tromey.com>
5142
5143         * tui/tui-winsource.c
5144         (tui_exec_info_window::maybe_allocate_content): New method.
5145         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5146         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5147         (make_source_or_disasm_window): Add cast.
5148         * tui/tui-data.h (union tui_which_element) <simple_string>:
5149         Remove.
5150         (struct tui_source_info): New.
5151         (struct tui_source_window_base) <execution_info>: Change type.
5152         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5153         case, and add assert.
5154         (tui_alloc_content): Add assert.
5155
5156 2019-06-25  Tom Tromey  <tom@tromey.com>
5157
5158         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5159         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5160         * tui/tui-data.c (tui_alloc_win_info): Remove.
5161
5162 2019-06-25  Tom Tromey  <tom@tromey.com>
5163
5164         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5165         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5166         can_highlight.
5167
5168 2019-06-25  Tom Tromey  <tom@tromey.com>
5169
5170         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5171         make_visible_with_new_height method.
5172         (tui_win_info::make_visible_with_new_height): New method.
5173         (tui_source_window_base::do_make_visible_with_new_height)
5174         (tui_data_window::do_make_visible_with_new_height)
5175         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5176         (make_visible_with_new_height): Remove.
5177         (tui_resize_all, tui_adjust_win_heights): Use
5178         make_visible_with_new_height method.
5179         * tui/tui-data.h (struct tui_win_info)
5180         <do_make_visible_with_new_height, make_visible_with_new_height>:
5181         New methods.
5182         (struct tui_source_window_base, struct tui_data_window)
5183         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5184         methods.
5185
5186 2019-06-25  Tom Tromey  <tom@tromey.com>
5187
5188         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5189         method.
5190         (update_tab_width): Call update_tab_width method.
5191         * tui/tui-data.h (struct tui_win_info)
5192         (struct tui_source_window_base) <update_tab_width>: New methods.
5193
5194 2019-06-25  Tom Tromey  <tom@tromey.com>
5195
5196         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5197         parameter.
5198         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5199         parameter.
5200         (tui_gen_win_info::make_visible): Update.
5201         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5202         parameter.
5203         * tui/tui-data.h (enum tui_box): New enum.
5204         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5205
5206 2019-06-25  Tom Tromey  <tom@tromey.com>
5207
5208         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5209         init_and_make_win for EXEC_INFO_WIN.
5210         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5211         longer inline.
5212         (struct tui_win_info) <~tui_win_info>: Inline.
5213         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5214         Don't declare.
5215         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5216         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5217         Remove.
5218         (tui_initialize_static_data): Update.
5219         (~tui_gen_win_info): Handle more cleanup here.
5220         (~tui_source_window_base): Delete "execution_info".
5221         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5222
5223 2019-06-25  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-layout.c (make_command_window): Don't set
5226         can_highlight.
5227         (show_source_disasm_command): Call the reset method.
5228         (show_data): Don't set can_highlight.  Call the reset method.
5229         (tui_gen_win_info::reset): Rename from init_gen_win_info
5230         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5231         (show_source_or_disasm_and_command): Call the reset method.
5232         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5233         (struct tui_cmd_window): Set can_highlight.
5234
5235 2019-06-25  Tom Tromey  <tom@tromey.com>
5236
5237         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5238         from make_visible.
5239         (tui_make_visible, tui_make_invisible): Rewrite.
5240         (tui_win_info::make_visible): Remove.
5241         (tui_source_window_base::make_visible): Update.
5242         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5243         method.  Moved from...
5244         (struct tui_win_info) <make_visible>: ...here.
5245
5246 2019-06-25  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-winsource.c
5249         (tui_source_window_base::do_scroll_horizontal): Remove direction
5250         parameter.
5251         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5252         direction parameter.
5253         * tui/tui-win.c (tui_win_info::forward_scroll)
5254         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5255         (tui_win_info::right_scroll): Update.
5256         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5257         direction parameter.
5258         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5259         direction parameter.
5260         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5261         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5262         Remove direction parameter.
5263         (struct tui_source_window_base, struct tui_source_window)
5264         (struct tui_disasm_window, struct tui_data_window)
5265         (struct tui_cmd_window): Update.
5266
5267 2019-06-25  Tom Tromey  <tom@tromey.com>
5268
5269         * tui/tui-winsource.h (tui_set_exec_info_content)
5270         (tui_show_exec_info_content, tui_erase_exec_info_content)
5271         (tui_clear_exec_info_content, tui_update_exec_info): Change
5272         argument to tui_source_window_base.
5273         * tui/tui-winsource.c (tui_set_exec_info_content)
5274         (tui_show_exec_info_content, tui_erase_exec_info_content)
5275         (tui_clear_exec_info_content, tui_update_exec_info): Change
5276         argument to tui_source_window_base.
5277
5278 2019-06-25  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5281         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5282
5283 2019-06-25  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5286         check.
5287
5288 2019-06-25  Tom Tromey  <tom@tromey.com>
5289
5290         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5291         type to void.
5292         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5293         type to void.
5294         * tui/tui-source.c (tui_set_source_content): Update.
5295         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5296
5297 2019-06-25  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui-win.c (window_name_completer, tui_set_focus)
5300         (tui_all_windows_info): Use name method.
5301         * tui/tui-data.h (struct tui_gen_win_info)
5302         (struct tui_source_window, struct tui_disasm_window)
5303         (struct tui_data_window, struct tui_cmd_window) <name>: New
5304         method.
5305         (tui_win_name): Don't declare.
5306         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5307         (tui_win_name): Remove.
5308
5309 2019-06-25  Tom Tromey  <tom@tromey.com>
5310
5311         * tui/tui-winsource.h (tui_update_source_window)
5312         (tui_update_source_window_as_is): Change parameter type.
5313         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5314         to be a tui_source_window_base.
5315         (tui_update_source_window_as_is): Likewise.
5316         * tui/tui-win.c (make_visible_with_new_height): Update.
5317
5318 2019-06-25  Tom Tromey  <tom@tromey.com>
5319
5320         * tui/tui-winsource.c (tui_erase_source_content)
5321         (tui_show_source_content, tui_show_exec_info_content)
5322         (tui_erase_exec_info_content): Use refresh_window method.
5323         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5324         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5325         from tui_refresh_win.
5326         (tui_data_window::refresh_window): New method.
5327         (tui_win_info::refresh, tui_source_window_base::refresh)
5328         (tui_refresh_all): Use refresh_window method.
5329         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5330         method.
5331         * tui/tui-regs.c (tui_display_register): Call refresh_window
5332         method.
5333         * tui/tui-layout.c (show_source_disasm_command)
5334         (show_source_or_disasm_and_command): Call refresh_window method.
5335         * tui/tui-data.h (struct tui_gen_win_info)
5336         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5337         New method.
5338
5339 2019-06-25  Tom Tromey  <tom@tromey.com>
5340
5341         * tui/tui.c (tui_rl_other_window, tui_enable)
5342         (tui_is_window_visible, tui_get_command_dimension): Update.
5343         * tui/tui-winsource.c (tui_update_source_window_as_is)
5344         (tui_clear_source_content, tui_erase_source_content)
5345         (tui_show_source_line, tui_source_window_base::refill)
5346         (tui_source_window_base::do_scroll_horizontal)
5347         (tui_source_window_base::set_is_exec_point_at)
5348         (tui_update_breakpoint_info, tui_set_exec_info_content)
5349         (tui_alloc_source_buffer, tui_line_is_displayed)
5350         (tui_addr_is_displayed): Update.
5351         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5352         (tui_check_and_display_highlight_if_needed)
5353         (tui_win_info::make_visible, tui_win_info::refresh)
5354         (tui_refresh_all): Update.
5355         * tui/tui-windata.c (tui_first_data_item_displayed)
5356         (tui_delete_data_content_windows, tui_erase_data_content)
5357         (tui_display_all_data, tui_data_window::refresh_all)
5358         (tui_check_data_values): Update.
5359         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5360         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5361         (tui_win_info::backward_scroll, tui_refresh_all_win)
5362         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5363         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5364         (tui_source_window_base::set_new_height)
5365         (tui_data_window::set_new_height)
5366         (make_invisible_and_set_new_height)
5367         (make_visible_with_new_height, new_height_ok)
5368         (parse_scrolling_args): Update.
5369         * tui/tui-stack.c (tui_show_frame_info): Update.
5370         * tui/tui-source.c (tui_set_source_content)
5371         (tui_set_source_content_nil, tui_source_is_displayed)
5372         (tui_source_window::do_scroll_vertical): Update.
5373         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5374         (tui_display_registers_from, tui_display_reg_element_at_line)
5375         (tui_check_register_values, tui_reg_command): Update.
5376         * tui/tui-layout.c (tui_default_win_height)
5377         (show_source_disasm_command, show_data, init_and_make_win)
5378         (show_source_or_disasm_and_command): Update.
5379         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5380         (tui_redisplay_readline, tui_mld_flush)
5381         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5382         (tui_getc): Update.
5383         * tui/tui-disasm.c (tui_set_disassem_content)
5384         (tui_disasm_window::do_scroll_vertical): Update.
5385         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5386         Now virtual.
5387         (struct tui_win_info): Derive from tui_gen_win_info.
5388         <~tui_win_info>: Mark as override.
5389         <generic>: Remove member.
5390         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5391         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5392         (~tui_data_window, ~tui_win_info)
5393         (tui_free_all_source_wins_content): Update.
5394         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5395
5396 2019-06-25  Tom Tromey  <tom@tromey.com>
5397
5398         * tui/tui-layout.c (init_and_make_win): Use new.
5399         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5400         destructor, initializers.
5401         (tui_alloc_generic_win_info): Don't declare.
5402         * tui/tui-data.c (_locator): Add argument to constructor.
5403         (source_win, disasm_win): New globals.
5404         (exec_info): Remove.
5405         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5406         Update.
5407         (tui_alloc_generic_win_info): Remove.
5408         (init_content_element): Use new.
5409         (tui_win_info::tui_win_info): Update.
5410         (free_content_elements) <case DATA_WIN>: Use delete.
5411
5412 2019-06-25  Tom Tromey  <tom@tromey.com>
5413
5414         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5415         * tui/tui-windata.c (tui_first_data_item_displayed)
5416         (tui_delete_data_content_windows): Update.
5417         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5418         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5419         (tui_display_registers_from, tui_check_register_values): Update.
5420         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5421         pointer.
5422         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5423         window.
5424         (tui_free_data_content): Update.
5425         (free_content_elements) <case DATA_WIN>: Free the window.
5426
5427 2019-06-25  Tom Tromey  <tom@tromey.com>
5428
5429         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5430         Update.
5431         * tui/tui-layout.c (make_command_window)
5432         (show_source_disasm_command, show_data, init_and_make_win)
5433         (show_source_or_disasm_and_command): Update.
5434         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5435         method.
5436         <can_highight, is_highlighted>: Now bool.
5437         (tui_set_win_highlight): Don't declare.
5438         * tui/tui-data.c (tui_set_win_highlight): Remove.
5439
5440 2019-06-25  Tom Tromey  <tom@tromey.com>
5441
5442         * tui/tui-wingeneral.c (make_visible): Remove check of window
5443         type.
5444
5445 2019-06-25  Tom Tromey  <tom@tromey.com>
5446
5447         * tui/tui-win.c (tui_win_info::max_height)
5448         (tui_cmd_window::max_height): New methods.
5449         (new_height_ok): Call max_height.
5450         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5451         <max_height>: New method.
5452
5453 2019-06-25  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-win.c (tui_source_window_base::set_new_height)
5456         (tui_data_window::set_new_height): New methods.
5457         (make_invisible_and_set_new_height): Call set_new_height method.
5458         * tui/tui-data.h (struct tui_win_info)
5459         (struct tui_source_window_base, struct tui_data_window)
5460         <set_new_height>: New method.
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5465         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5466         tui_refresh_data_win.
5467         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5468         method.
5469         (tui_refresh_all_win): Call the refresh_all method.
5470         (tui_set_focus): Likewise.
5471         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5472         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5473         Likewise.
5474
5475 2019-06-25  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-winsource.h (tui_refill_source_window)
5478         (tui_set_is_exec_point_at): Don't declare.
5479         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5480         (tui_source_window_base::refill): Rename from
5481         tui_refill_source_window.
5482         (tui_source_window_base::do_scroll_horizontal): Update.
5483         (tui_source_window_base::set_is_exec_point_at): Rename from
5484         tui_set_is_exec_point_at.
5485         (tui_update_all_breakpoint_info): Update.
5486         * tui/tui-stack.c (tui_show_frame_info): Update.
5487         * tui/tui-layout.c (show_data): Add cast.
5488         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5489         * tui/tui-data.h (struct tui_source_window_base) <refill,
5490         set_is_exec_point_at>: New methods.
5491         (tui_source_windows, tui_add_to_source_windows): Update types.
5492         (tui_add_to_source_windows): Remove redundant declaration.
5493         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5494         (tui_source_windows): Change return type.
5495         (tui_clear_source_windows_detail): Update.
5496         (tui_add_to_source_windows): Change type of parameter.
5497         (tui_free_all_source_wins_content): Update.
5498
5499 2019-06-25  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-wingeneral.c (tui_win_info::refresh)
5502         (tui_source_window_base::refresh): New methods.
5503         (tui_refresh_all): Call the refresh method.
5504         * tui/tui-data.h (struct tui_win_info)
5505         (struct tui_source_window_base) <refresh>: New method.
5506
5507 2019-06-25  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui.h (tui_is_window_visible): Return bool.
5510         * tui/tui.c (tui_is_window_visible): Return bool.
5511         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5512         (tui_make_visible, tui_make_invisible)
5513         (tui_win_info::make_visible)
5514         (tui_source_window_base::make_visible, make_all_visible)
5515         (tui_make_all_visible, tui_make_all_invisible): Update.
5516         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5517         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5518         bool.
5519         (struct tui_win_info, struct tui_source_window_base)
5520         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5521         * tui/tui-data.c (tui_init_generic_part): Update.
5522
5523 2019-06-25  Tom Tromey  <tom@tromey.com>
5524
5525         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5526         (tui_source_window_base::make_visible): New methods.
5527         (make_all_visible): Make method call.
5528         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5529         (struct tui_source_window_base, struct tui_cmd_window): Override
5530         make_visible.
5531         (tui_win_is_source_type): Don't declare.
5532         * tui/tui-data.c (tui_win_is_source_type): Remove.
5533
5534 2019-06-25  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5537         NULL check.
5538
5539 2019-06-25  Tom Tromey  <tom@tromey.com>
5540
5541         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5542         Inline constructor.  Add initializers for members.
5543         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5544         constructors; now inline in class.
5545
5546 2019-06-25  Tom Tromey  <tom@tromey.com>
5547
5548         * tui/tui-regs.c (tui_show_registers): Update.
5549         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5550         bool.
5551         * tui/tui-data.c (tui_data_window::clear_detail)
5552         (tui_data_window): Update.
5553
5554 2019-06-25  Tom Tromey  <tom@tromey.com>
5555
5556         * tui/tui-windata.c (tui_display_all_data)
5557         (tui_display_data_from_line, tui_display_data_from)
5558         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5559         Update.
5560         * tui/tui-regs.c (tui_last_regs_line_no)
5561         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5562         (tui_show_registers, tui_show_register_group)
5563         (tui_display_registers_from, tui_display_reg_element_at_line)
5564         (tui_display_registers_from_line, tui_check_register_values)
5565         (tui_reg_next, tui_reg_prev): Update.
5566         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5567         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5568         tui_data_window.
5569         (struct tui_win_info) <detail>: Remove.  Add new fields from
5570         tui_data_info.
5571         (TUI_DATA_WIN): Add cast.
5572         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5573         (~tui_data_window): Simplify.
5574
5575 2019-06-25  Tom Tromey  <tom@tromey.com>
5576
5577         * tui/tui-layout.c (show_source_disasm_command)
5578         (show_source_or_disasm_and_command): Update.
5579         * tui/tui-io.c (update_cmdwin_start_line)
5580         (tui_redisplay_readline): Update.
5581         * tui/tui-data.h (struct tui_command_info): Remove.
5582         (struct tui_win_info) <detail>: Remove command_info member.
5583         (struct tui_data_window) <start_line>: New member, from
5584         tui_command_info.
5585         (TUI_CMD_WIN): Add casts.
5586
5587 2019-06-25  Tom Tromey  <tom@tromey.com>
5588
5589         * tui/tui-winsource.c (tui_update_source_window)
5590         (tui_refill_source_window)
5591         (tui_source_window_base::do_scroll_horizontal)
5592         (tui_update_breakpoint_info, tui_set_exec_info_content)
5593         (tui_show_exec_info_content, tui_erase_exec_info_content)
5594         (tui_clear_exec_info_content): Update.
5595         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5596         Update.
5597         * tui/tui-win.c (make_invisible_and_set_new_height)
5598         (make_visible_with_new_height): Update.
5599         * tui/tui-source.c (tui_set_source_content)
5600         (tui_show_symtab_source): Update.
5601         * tui/tui-layout.c (extract_display_start_addr)
5602         (show_source_disasm_command, show_data)
5603         (make_source_or_disasm_window)
5604         (show_source_or_disasm_and_command): Update.
5605         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5606         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5607         "gdbarch".
5608         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5609         to tui_source_window_base.
5610         (struct tui_win_info) <detail>: Remove source_info member.
5611         (struct tui_source_window_base) <has_locator>: Inline.
5612         Move contents from tui_source_info; rename has_locator member to
5613         m_has_locator.
5614         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5615         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5616         header file.
5617         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5618         Simplify.
5619         (tui_free_all_source_wins_content): Cast to
5620         tui_source_window_base.
5621
5622 2019-06-25  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-win.c (make_invisible_and_set_new_height)
5625         (make_visible_with_new_height): Call has_locator method.
5626         * tui/tui-layout.c (show_source_disasm_command, show_data)
5627         (show_source_or_disasm_and_command): Update for bool change.
5628         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5629         (tui_win_info) <has_locator>: New method.
5630         (struct tui_source_window_base) <has_locator>: New method.
5631         (tui_win_has_locator): Don't declare.
5632         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5633         from tui_win_has_locator.
5634         (tui_source_window_base): Use false, not FALSE.
5635
5636 2019-06-25  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5639         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5640         clear_detail method directly.
5641         (tui_clear_win_detail): Remove.
5642
5643 2019-06-25  Tom Tromey  <tom@tromey.com>
5644
5645         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5646         "this", not TUI_DISASM_WIN.
5647
5648 2019-06-25  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5651         declare.
5652         * tui/tui-winsource.c
5653         (tui_source_window_base::do_scroll_horizontal): Rename from
5654         tui_horizontal_source_scroll.
5655         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5656         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5657         from tui_vertical_data_scroll.
5658         * tui/tui-win.h (tui_scroll): Don't declare.
5659         * tui/tui-win.c (tui_win_info::forward_scroll)
5660         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5661         (tui_win_info::right_scroll): Rename and update.
5662         (tui_scroll_forward_command, tui_scroll_backward_command)
5663         (tui_scroll_left_command, tui_scroll_right_command): Update.
5664         (tui_scroll): Remove.
5665         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5666         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5667         from tui_vertical_source_scroll.
5668         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5669         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5670         from tui_vertical_disassem_scroll.
5671         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5672         do_scroll_horizontal>: New methods.
5673         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5674         Likewise.
5675         (struct tui_source_window_base): Add do_scroll_horizontal.
5676         (struct tui_source_window, struct tui_disasm_window): Add
5677         do_scroll_vertical.
5678         (struct tui_data_window, struct tui_cmd_window): Add
5679         do_scroll_horizontal and do_scroll_vertical.
5680         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5681
5682 2019-06-25  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-data.h (struct tui_source_window_base): New struct.
5685         (struct tui_source_window): Derive from tui_source_window_base.
5686         (struct tui_disasm_window): New struct.
5687         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5688         from tui_source_window::clear_detail.
5689         (tui_source_window_base): Rename from tui_source_window.
5690         (~tui_source_window_base): Rename from ~tui_source_window.
5691         (tui_alloc_win_info): Create a tui_disasm_window.
5692
5693 2019-06-25  Tom Tromey  <tom@tromey.com>
5694
5695         * tui/tui-data.h (struct tui_source_window)
5696         (struct tui_data_window): Declare destructors.
5697         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5698         destructors.
5699         (tui_win_info): Simplify.
5700
5701 2019-06-25  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui-winsource.c (tui_display_main)
5704         (tui_update_source_windows_with_addr)
5705         (tui_update_all_breakpoint_info): Update.
5706         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5707         (new_height_ok, parse_scrolling_args): Update.
5708         * tui/tui-stack.c (tui_show_frame_info): Update.
5709         * tui/tui-data.h (struct tui_list): Remove.
5710         (tui_source_windows): Return a reference to a std::vector.
5711         * tui/tui-data.c (source_windows): Now a std::vector.
5712         (tui_source_windows): Change return type.
5713         (tui_clear_source_windows): Rewrite.
5714         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5715         (tui_free_all_source_wins_content): Rewrite.
5716
5717 2019-06-25  Tom Tromey  <tom@tromey.com>
5718
5719         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5720         (struct tui_data_window, struct tui_cmd_window): Declare
5721         clear_detail method.
5722         * tui/tui-data.c (tui_source_window::clear_detail)
5723         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5724         methods.
5725         (tui_clear_win_detail): Simplify.
5726
5727 2019-06-25  Tom Tromey  <tom@tromey.com>
5728
5729         * tui/tui-layout.c (make_source_window, make_disasm_window)
5730         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5731         Return the new window.
5732         (show_source_disasm_command, show_data)
5733         (show_source_or_disasm_and_command): Update.
5734
5735 2019-06-25  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5738         parameter.  Return the new window.
5739         (show_source_disasm_command): Update and remove NULL check.
5740         (show_source_or_disasm_and_command): Update.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5745
5746 2019-06-25  Tom Tromey  <tom@tromey.com>
5747
5748         * tui/tui-data.h (struct tui_win_info): Make constructor
5749         protected.  Make destructor virtual.  Add initializers.
5750         (tui_source_window, tui_data_window, tui_cmd_window): New
5751         classes.
5752         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5753         constructor.  Add "type" parameter.
5754         (tui_source_window, tui_data_window, tui_cmd_window): New
5755         constructors.
5756         (tui_alloc_win_info): Instantiate the appropriate subclass.
5757
5758 2019-06-25  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-win.c (tui_resize_all): Use delete.
5761         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5762         destructor.
5763         (tui_free_window): Don't declare.
5764         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5765         Update.
5766
5767 2019-06-25  Tom Tromey  <tom@tromey.com>
5768
5769         * tui/tui-data.h (struct tui_win_info): Add constructor.
5770         * tui/tui-data.c (tui_alloc_win_info): Use new.
5771         (tui_free_window): Use delete.
5772
5773 2019-06-22  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5776         declare.
5777         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5778
5779 2019-06-22  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5782         declare.
5783         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5784
5785 2019-06-22  Tom de Vries  <tdevries@suse.de>
5786
5787         * dwarf2read.c (create_addrmap_from_aranges)
5788         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5789         instead of '%zu'.
5790
5791 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5792
5793         * dwarf2read.h (dwarf2_section_info_def): Remove.
5794         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5795         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5796         std::vector<dwarf2_section_info>.
5797         (struct dwo_file) <~dwo_file>: Remove.
5798         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5799         types field.
5800         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5801         (dwarf2_read_debug_names): Likewise.
5802         (create_debug_types_hash_table): Change parameter type to
5803         array_view, adjust code accordingly.
5804         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5805         (partial_die_info::fixup): Likewise.
5806         (determine_prefix): Likewise.
5807         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5808
5809 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5810
5811         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5812         gdb_bfd_ref_ptr.
5813         <~dwo_file>: Remove call to gdb_bfd_unref.
5814         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5815         gdb_bfd_ref_ptr::get.
5816
5817 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5818
5819         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5820         type to htab_up.
5821         * dwarf2read.c (struct dwo_file): Initialize fields.
5822         <~dwo_file>: New.
5823         (free_dwo_file): Remove, move content to ~dwo_file.
5824         (struct dwo_file_deleter): Remove.
5825         (dwo_file_up>: Remove custom deleter.
5826         (free_dwo_files): Remove.
5827         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5828         dwo_files.
5829         (process_skeletonless_type_units): Call unique_ptr::get.
5830         (allocate_dwo_file_hash_table): Add deleter to created hash
5831         table.  Change return type to htab_up.
5832         (lookup_dwo_file_slot): Don't memset dwo_file, call
5833         unique_ptr::get.
5834         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5835         (create_dwo_unit_in_dwp_v2): Likewise.
5836         (open_and_init_dwo_file): Likewise.
5837         (free_dwo_file_from_slot): Remove.
5838
5839 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5840
5841         * dwarf2read.h (struct dwarf2_section_info) <readin,
5842         is_virtual>: Change type to bool.
5843         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5844         true instead of 1.
5845
5846 2019-06-19  Tom Tromey  <tom@tromey.com>
5847
5848         * tui/tui-data.h (tui_init_content_element): Don't declare.
5849
5850 2019-06-19  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-data.h (tui_init_win_info): Don't declare.
5853
5854 2019-06-19  Tom de Vries  <tdevries@suse.de>
5855
5856         * dwarf2read.h (abstract_to_concrete): Change type to
5857         std::unordered_map<sect_offset, std::vector<sect_offset>,
5858         gdb::hash_enum<sect_offset>>.
5859
5860 2019-06-19  Tom Tromey  <tromey@adacore.com>
5861
5862         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5863         EVAL_AVOID_SIDE_EFFECTS specially.
5864
5865 2019-06-19  Tom Tromey  <tromey@adacore.com>
5866
5867         * source-cache.c (highlighter): New global.
5868         (source_cache::get_source_lines): Create a highlighter on demand.
5869
5870 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * defs.h (deprecated_interactive_hook): Delete declaration.
5873         * interps.c (clear_interpreter_hooks): Remove use of
5874         deprecated_interactive_hook.
5875         * top.c (deprecated_interactive_hook): Delete definition.
5876         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5877
5878 2019-06-18  Tom de Vries  <tdevries@suse.de>
5879
5880         PR gdb/24515
5881         * dwarf2read.h (abstract_to_concrete): Change type from
5882         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5883         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5884         * dwarf2read.c (read_variable): Update.
5885         (dwarf2_fetch_die_loc_sect_off): Update.
5886
5887 2019-06-17  Tom de Vries  <tdevries@suse.de>
5888
5889         PR gdb/24617
5890         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5891         accessing parent[parent_len - 1].
5892
5893 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5894
5895         PR gdb/24364
5896         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5897         call dtrace_process_dof with NULL dof.
5898
5899 2019-06-16  Tom de Vries  <tdevries@suse.de>
5900
5901         PR gdb/24445
5902         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5903
5904 2019-06-16  Tom Tromey  <tom@tromey.com>
5905
5906         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5907         (make_all_visible): Use address of member.
5908
5909 2019-06-16  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5912         (tui_free_window, free_content, free_content_elements): Remove
5913         unnecessary cast.
5914         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5915         cast.
5916         * tui/tui-regs.c (tui_show_register_group)
5917         (tui_display_registers_from, tui_display_reg_element_at_line):
5918         Remove unnecessary cast.
5919
5920 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * linux-nat.c (normal_mask): Delete.
5923         (_initialize_linux_nat): Don't initialise normal_mask.
5924
5925 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5926
5927         PR gdb/24445
5928         * dwarf-index-write.h (write_psymtabs_to_index): Add
5929         dwz_basename parameter.
5930         * dwarf-index-write.c (write_gdbindex): Move file writing to
5931         write_gdbindex_1.  Change return type void.
5932         (assert_file_size): Move up, remove filename parameter.
5933         (write_gdbindex_1): New function.
5934         (write_debug_names): Change return type to void, call
5935         assert_file_size.
5936         (struct index_wip_file): New struct.
5937         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5938         file logic to index_wip_file.  Write index for dwz file if
5939         needed.
5940         (save_gdb_index_command): Pass basename of dwz file, if present.
5941         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5942         build-id of dwz file, if present.
5943         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5944         (dwarf2_get_dwz_file): Likewise.
5945         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5946         (dwarf2_get_dwz_file): Likewise.
5947
5948 2019-06-16  Tom Tromey  <tom@tromey.com>
5949
5950         * coffread.c (process_coff_symbol): Use xstrdup.
5951         * value.c (create_internalvar): Use xstrdup.
5952
5953 2019-06-16  Tom Tromey  <tom@tromey.com>
5954
5955         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5956         * breakpoint.c (stopin_command, stopat_command)
5957         (until_break_command, decode_location_default): Remove unnecessary
5958         cast.
5959         * utils.c (subset_compare): Remove unnecessary cast.
5960         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5961         cast.
5962         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5963         cast.
5964         * infcmd.c (path_command): Remove unnecessary cast.
5965         * coffread.c (decode_type): Remove unnecessary cast.
5966         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5967         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5968         * tui/tui-stack.c (tui_show_locator_content)
5969         (tui_show_frame_info): Remove unnecessary cast.
5970         * tui/tui-win.c (tui_scroll_forward_command)
5971         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5972         (parse_scrolling_args): Remove unnecessary cast.
5973         * tui/tui-data.c (init_win_info, tui_del_window)
5974         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5975         (free_content_elements): Remove unnecessary cast.
5976         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5977         unnecessary cast.
5978         * tui/tui-source.c (tui_set_source_content)
5979         (tui_vertical_source_scroll): Remove unnecessary cast.
5980         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5981         cast.
5982         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5983         * tui/tui-regs.c (tui_display_registers_from)
5984         (tui_display_register): Remove unnecessary cast.
5985         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5986         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5987         (make_visible): Remove unnecessary cast.
5988         * tui/tui-winsource.c (tui_erase_source_content)
5989         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5990         unnecessary cast.
5991         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5992         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5993         * stabsread.c (read_type, read_array_type, read_range_type):
5994         Remove unnecessary cast.
5995         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5996         (parse_symbol, parse_type, upgrade_type, parse_external)
5997         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5998         unnecessary cast.
5999         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6000
6001 2019-06-16  Tom Tromey  <tom@tromey.com>
6002
6003         * tui/tui-data.c (tui_alloc_generic_win_info)
6004         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6005         checks.
6006
6007 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6008             Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * f-typeprint.c (f_print_type): Don't return early for not
6011         associated or not allocated types.
6012         (f_type_print_varspec_suffix): Add print_rank parameter and print
6013         ranks of array types in case they dangling.
6014         (f_type_print_base): Add print_rank parameter.
6015
6016 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * NEWS: Mention new MI commands.
6019         * break-catch-throw.c (enum exception_event_kind): Move to
6020         breakpoint.h.
6021         (print_mention_exception_catchpoint): Output text as a single
6022         message.
6023         (catch_exception_command_1): Rename to...
6024         (catch_exception_event): ...this, make non-static, update header
6025         command, and change some parameter types.
6026         (catch_catch_command): Update for changes to
6027         catch_exception_command_1.
6028         (catch_throw_command): Likewise.
6029         (catch_rethrow_command): Likewise.
6030         * breakpoint.c (enum exception_event_kind): Delete.
6031         * breakpoint.h (enum exception_event_kind): Moved here from
6032         break-catch-throw.c.
6033         (catch_exception_event): Declare.
6034         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6035         (mi_cmd_catch_throw): New function.
6036         (mi_cmd_catch_rethrow): New function.
6037         (mi_cmd_catch_catch): New function.
6038         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6039         'catch-catch' entries.
6040         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6041         (mi_cmd_catch_rethrow): Declare.
6042         (mi_cmd_catch_catch): Declare.
6043
6044 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * annotate.c (annotate_source_line): Change return type to void,
6047         update implementation to match.
6048         * annotate.h (annotate_source_line): Change return type to void,
6049         update header comment.
6050         * stack.c (print_frame_info): Don't change what frame information
6051         is printed based on whether annotations are on or not.
6052
6053 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6056         (annotate_source): Make static.
6057         (annotate_source_line): Moved from source.c and renamed from
6058         identify_source_line.  Update the return type.
6059         * annotate.h (annotate_source): Delete declaration.
6060         (annotate_source_line): Declaration moved from source.h, and
6061         renamed from identify_source_line.  Return type updated.
6062         * source.c (identify_source_line): Moved to annotate.c and renamed
6063         to annotate_source_line.
6064         (info_line_command): Remove check of annotation_level.
6065         * source.h (identify_source_line): Move declaration to annotate.h
6066         and rename to annotate_source_line.
6067         * stack.c: Add 'annotate.h' include.
6068         (print_frame_info): Remove check of annotation_level before
6069         calling annotate_source_line.
6070
6071 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * source-cache.c (source_cache::get_plain_source_lines): Use
6074         open_source_file_with_line_charpos instead of just
6075         open_source_file, remove call to find_source_lines.
6076         (source_cache::get_source_lines): Likewise.
6077         * source.c (find_source_lines): Make static.
6078         (get_filename_and_charpos): Renamed into...
6079         (open_source_file_with_line_charpos): ..this along with changes to
6080         return a scoped_fd, and some other minor clean ups.
6081         (identify_source_line): Use open_source_file_with_line_charpos.
6082         (search_command_helper): Use open_source_file_with_line_charpos
6083         instead of just open_source_file, remove call to
6084         find_source_lines.
6085         * source.h (open_source_file_with_line_charpos): Declare new
6086         function.
6087         (find_source_lines): Delete declaration.
6088
6089 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         * source.c (get_filename_and_charpos): Remove fullname
6092         parameter.
6093         (identify_source_line): Update call to get_filename_and_charpos.
6094
6095 2019-06-14  Tom Tromey  <tromey@adacore.com>
6096
6097         PR gdb/24502:
6098         * ui-style.h (skip_ansi_escape): Update comment.
6099         * ui-file.h (class no_terminal_escape_file): New class.
6100         * ui-file.c (no_terminal_escape_file::write)
6101         (no_terminal_escape_file::puts): New methods.
6102         * cli/cli-logging.c (handle_redirections): Use
6103         no_terminal_escape_file.
6104
6105 2019-06-14  Tom Tromey  <tromey@adacore.com>
6106
6107         * NEWS: Move convenience variable news above Python news.
6108
6109 2019-06-14  Tom Tromey  <tom@tromey.com>
6110
6111         * gnulib: Move directory to top-level.
6112         * configure.ac: Don't configure gnulib.
6113         * configure: Rebuild.
6114         * common/common-defs.h: Use new path to gnulib.
6115         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6116         (GNULIB_H): Remove.
6117         (INCGNU): Look in new gnulib location.
6118         (HFILES_NO_SRCDIR): Remove gnulib files.
6119         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6120         (generated_files): Remove GNULIB_H.
6121         ($(LIBGNU), all-lib): Remove targets.
6122         (distclean): Don't mention GNULIB_BUILDDIR.
6123         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6124
6125 2019-06-14  Tom Tromey  <tromey@adacore.com>
6126
6127         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6128         Warn if symbol file does not provide any symbols.
6129
6130 2019-06-14  Tom Tromey  <tromey@adacore.com>
6131
6132         * source.c (find_and_open_source): Respect basenames_may_differ.
6133
6134 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6135
6136         * annotate.c (annotate_breakpoints_invalid): Make use of
6137         scoped_restore_terminal_state.
6138         (annotate_frames_invalid): Likewise.
6139
6140 2019-06-14  Tom Tromey  <tromey@adacore.com>
6141
6142         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6143         allow assignment to an internalvar.
6144
6145 2019-06-14  Tom Tromey  <tromey@adacore.com>
6146
6147         * ada-lex.l: Allow "_" in attribute names.
6148
6149 2019-06-14  Tom Tromey  <tromey@adacore.com>
6150
6151         PR gdb/24653:
6152         * regcache.c (registers_changed): Don't call alloca.
6153         * top.c (execute_command): Don't call alloca.
6154
6155 2019-06-13  Pedro Alves  <palves@redhat.com>
6156
6157         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6158         'expression'.  When parsing an expression, error out if there's
6159         junk after "unlimited".
6160         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6161         (do_set_command): Adjust calls to is_unlimited_literal.
6162
6163 2019-06-13  Pedro Alves  <palves@redhat.com>
6164
6165         * compile/compile.c (make_compile_options_def_group): Add braces
6166         around array_view initializer.
6167         * thread.c (make_thread_apply_all_options_def_group)
6168         (make_thread_apply_all_options_def_group): Likewise.
6169
6170 2019-06-13  Pedro Alves  <palves@redhat.com>
6171
6172         * NEWS (New commands): Mention "maint test-options
6173         require-delimiter", "maint test-options unknown-is-error", "maint
6174         test-options unknown-is-operand" and "maint show
6175         test-options-completion-result".
6176         (New command options, command completion): New section.
6177         (Completion improvements): New section.
6178         Mention that you can abbreviate "unlimited".
6179
6180 2019-06-13  Pedro Alves  <palves@redhat.com>
6181
6182         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6183         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6184         * unittests/cli-utils-selftests.c (test_parse_flags)
6185         (test_parse_flags_qcs): Delete.
6186         (test_cli_utils): Don't call deleted functions.
6187
6188 2019-06-13  Pedro Alves  <palves@redhat.com>
6189
6190         * thread.c: Include "cli/cli-option.h".
6191         (tp_array_compar_ascending): Global.
6192         (tp_array_compar): Delete function.
6193         (tp_array_compar_ascending, tp_array_compar_descending): New
6194         functions.
6195         (ascending_option_def, qcs_flag_option_def)
6196         (thr_qcs_flags_option_defs)
6197         (make_thread_apply_all_options_def_group)
6198         (make_thread_apply_options_def_group): New.
6199         (thread_apply_all_command): Use gdb::option::process_options.
6200         (thread_apply_command_completer)
6201         (thread_apply_all_command_completer): New.
6202         (thread_apply_command): Use gdb::option::process_options.
6203         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6204         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6205         to generate help text of "thread apply".  Adjust "taas"'s help.
6206         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6207         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6208
6209 2019-06-13  Pedro Alves  <palves@redhat.com>
6210
6211         * thread.c (thread_apply_command): Check for invalid TID with
6212         isdigit instead of !isalpha.
6213
6214 2019-06-13  Pedro Alves  <palves@redhat.com>
6215
6216         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6217         (validate_flags_qcs): New.
6218         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6219         (validate_flags_qcs): Declare.
6220         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6221         (make_frame_apply_options_def_group): New.
6222         (frame_apply_command_count): Process options with
6223         gdb::option::process_options.
6224         (frame_apply_completer): New.
6225         (frame_apply_level_completer, frame_apply_all_completer)
6226         (frame_apply_completer): New.
6227         (_initialize_stack): Update help of "frame apply", "frame apply
6228         level", "frame apply all" and "faas" to mention supported options
6229         and install command completers.
6230         * stack.h (frame_apply_all_completer): Declare.
6231         * thread.c: Include "stack.h".
6232         (tfaas_command): Add "--".
6233         (_initialize_thread): Update help "tfaas" to mention supported
6234         options and install command completer.
6235
6236 2019-06-13  Pedro Alves  <palves@redhat.com>
6237
6238         * completer.c (complete_nested_command_line): New.
6239         (gdb_completion_word_break_characters_throw): Add assertion.
6240         * completer.h (complete_nested_command_line): Declare.
6241
6242 2019-06-13  Pedro Alves  <palves@redhat.com>
6243
6244         * stack.c (parse_backtrace_qualifiers): New.
6245         (backtrace_command): Use it.
6246         (backtrace_command_completer): Complete on qualifiers.
6247
6248 2019-06-13  Pedro Alves  <palves@redhat.com>
6249
6250         * frame.c: Include "cli/cli-option.h.
6251         (user_set_backtrace_options): New.
6252         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6253         Delete.
6254         (get_prev_frame): Adjust.
6255         (boolean_option_def, uinteger_option_def)
6256         (set_backtrace_option_defs): New.
6257         (_initialize_frame): Adjust and use
6258         gdb::option::add_setshow_cmds_for_options to install "set
6259         backtrace past-main" and "set backtrace past-entry".
6260         * frame.h: Include "cli/cli-option.h".
6261         (struct frame_print_options): Forward declare.
6262         (print_frame_arguments_all, print_frame_arguments_scalars)
6263         (print_frame_arguments_none): Declare.
6264         (print_entry_values): Delete declaration.
6265         (struct frame_print_options, user_frame_print_options): New.
6266         (struct set_backtrace_options): New.
6267         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6268         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6269         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6270         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6271         (list_args_or_locals): Add frame_print_options parameter.
6272         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6273         * python/py-framefilter.c (enumerate_args): Pass down
6274         USER_FRAME_PRINT_OPTIONS.
6275         * stack.c: Include "cli/cli-option.h".
6276         (print_frame_arguments_all, print_frame_arguments_scalars)
6277         (print_frame_arguments_none): Declare.
6278         (print_raw_frame_arguments, print_entry_values): Delete.
6279         (user_frame_print_options): New.
6280         (boolean_option_def, enum_option_def, frame_print_option_defs):
6281         New.
6282         (struct backtrace_cmd_options): New.
6283         (bt_flag_option_def): New.
6284         (backtrace_command_option_defs): New.
6285         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6286         (print_frame_arg, read_frame_arg, print_frame_args)
6287         (print_frame_info, print_frame): Add frame_print_options parameter
6288         and use it.
6289         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6290         (backtrace_command_1): Add frame_print_options and
6291         backtrace_cmd_options parameters and use them.
6292         (make_backtrace_options_def_group): New.
6293         (backtrace_command): Process command options with
6294         gdb::option::process_options.
6295         (backtrace_command_completer): New.
6296         (_initialize_stack): Extend "backtrace"'s help to mention
6297         supported options.  Install completer for "backtrace".
6298         Install some settings commands with add_setshow_cmds_for_options.
6299
6300 2019-06-13  Pedro Alves  <palves@redhat.com>
6301
6302         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6303         and that "set/show print raw frame-arguments" are now deprecated.
6304
6305         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6306         command.
6307         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6308         * stack.c (_initialize_stack): Install "set/show print
6309         raw-frame-arguments", and deprecate "set/show print raw
6310         frame-arguments".
6311         * valprint.c (_initialize_valprint): Deprecate "set/show print
6312         raw".
6313
6314 2019-06-13  Pedro Alves  <palves@redhat.com>
6315
6316         * compile/compile.c (struct compile_options): New.
6317         (compile_flag_option_def, compile_command_option_defs)
6318         (make_compile_options_def_group): New.
6319         (compile_file_command): Handle options with
6320         gdb::option::process_options.
6321         (compile_file_command_completer): New function.
6322         (compile_code_command): Handle options with
6323         gdb::option::process_options.
6324         (compile_code_command_completer): New function.
6325         (_initialize_compiler): Install completers for "compile code" and
6326         "compile file".  Mention available options in "compile code" and
6327         "compile code"'s help.
6328         * completer.c (advance_to_completion_word): New, factored out from
6329         ...
6330         (advance_to_expression_complete_word_point): ... this.
6331         (advance_to_filename_complete_word_point): New.
6332         * completer.h (advance_to_filename_complete_word_point): New
6333         declaration.
6334
6335 2019-06-13  Pedro Alves  <palves@redhat.com>
6336
6337         * compile/compile.c: Include "cli/cli-option.h".
6338         (compile_print_value): Scope data pointer is now a
6339         value_print_options pointer; adjust.
6340         (compile_print_command): Process options.  Scope data pointer is
6341         now a value_print_options pointer; adjust.
6342         (_initialize_compile): Update "compile print"'s help to include
6343         supported options.  Install a completer for "compile print".
6344         * cp-valprint.c (show_vtblprint, show_objectprint)
6345         (show_static_field_print): Delete.
6346         (_initialize_cp_valprint): Don't install "set print
6347         static-members", "set print vtbl", "set print object" here.
6348         * printcmd.c: Include "cli/cli-option.h" and
6349         "common/gdb_optional.h".
6350         (print_command_parse_format): Rework to fill in a
6351         value_print_options instead of a format_data.
6352         (print_value): Change parameter type from format_data pointer to
6353         value_print_options reference.  Adjust.
6354         (print_command_1): Process options.  Adjust to pass down a
6355         value_print_options.
6356         (print_command_completer): New.
6357         (_initialize_printcmd): Install print_command_completer as
6358         handle_brkchars completer for the "print" command.  Update
6359         "print"'s help to include supported options.
6360         * valprint.c: Include "cli/cli-option.h".
6361         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6362         here from cp-valprint.c.
6363         (boolean_option_def, uinteger_option_def)
6364         (value_print_option_defs, make_value_print_options_def_group):
6365         New.  Use gdb::option::add_setshow_cmds_for_options to install
6366         "set print elements", "set print null-stop", "set print repeats",
6367         "set print pretty", "set print union", "set print array", "set
6368         print address", "set print symbol", "set print array-indexes".
6369         * valprint.h: Include <string> and "cli/cli-option.h".
6370         (make_value_print_options_def_group): Declare.
6371         (print_value): Change parameter type from format_data pointer to
6372         value_print_options reference.
6373         (print_command_completer): Declare.
6374
6375 2019-06-13  Pedro Alves  <palves@redhat.com>
6376
6377         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6378         (COMMON_SFILES): Add maint-test-settings.c.
6379         * cli/cli-decode.c (boolean_enums): New global, factored out from
6380         ...
6381         (add_setshow_boolean_cmd): ... here.
6382         * cli/cli-decode.h (boolean_enums): Declare.
6383         * cli/cli-option.c: New file.
6384         * cli/cli-option.h: New file.
6385         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6386         factored out from ...
6387         (parse_cli_boolean_value(const char *)): ... this.
6388         (is_unlimited_literal): Change parameter type to pointer to
6389         pointer.  Adjust and advance ARG pointer.
6390         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6391         (parse_cli_var_enum): New, factored out from ...
6392         (do_set_command): ... this.  Adjust.
6393         * cli/cli-setshow.h (parse_cli_boolean_value)
6394         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6395         (parse_cli_var_enum): Declare.
6396         * cli/cli-utils.c: Include "cli/cli-option.h".
6397         (get_ulongest): New.
6398         * cli/cli-utils.h (get_ulongest): Declare.
6399         (check_for_argument): New overloads.
6400         * maint-test-options.c: New file.
6401
6402 2019-06-13  Pedro Alves  <palves@redhat.com>
6403
6404         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6405         parse a range if "-" is at the end of the string.
6406
6407 2019-06-13  Pedro Alves  <palves@redhat.com>
6408
6409         * cli/cli-setshow.c (parse_auto_binary_operation)
6410         (parse_cli_boolean_value): Don't allow "o".
6411
6412 2019-06-13  Pedro Alves  <palves@redhat.com>
6413
6414         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6415         * NEWS: Mention maint test-settings KIND.
6416         * maint-test-settings.c: New file.
6417
6418 2019-06-13  Pedro Alves  <palves@redhat.com>
6419
6420         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6421         completer.
6422         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6423         "set" completers.
6424
6425 2019-06-13  Pedro Alves  <palves@redhat.com>
6426
6427         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6428         after item.
6429
6430 2019-06-13  Pedro Alves  <palves@redhat.com>
6431
6432         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6433
6434 2019-06-13  Pedro Alves <palves@redhat.com>
6435
6436         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6437         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6438         call.
6439         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6440         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6441         calls.
6442         (check_for_argument): Skip spaces after argument.
6443
6444 2019-06-13  Pedro Alves  <palves@redhat.com>
6445
6446         * thread.c (thread_apply_command): Adjust TID parsing.
6447         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6448         detected before end of string.
6449         (tid_is_in_list): Error out if LIST is invalid.
6450
6451 2019-06-13  Pedro Alves  <palves@redhat.com>
6452
6453         * completer.c (complete_line_internal_1): Rewind completion word
6454         point.
6455         (completion_tracker::advance_custom_word_point_by): Change
6456         parameter type to int.
6457         * completer.h (completion_tracker::advance_custom_word_point_by):
6458         Likewise.
6459
6460 2019-06-13  Pedro Alves  <palves@redhat.com>
6461
6462         * completer.c (advance_to_completion_word): Handle delimiters.
6463
6464 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6465
6466         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6467
6468 2019-06-11  Tom Tromey  <tom@tromey.com>
6469
6470         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6471         (xmalloc_failed): Move to alloc.c.
6472         * alloc.c: New file.
6473         * Makefile.in (COMMON_SFILES): Add alloc.c.
6474
6475 2019-06-11  Tom Tromey  <tom@tromey.com>
6476
6477         * nat/linux-waitpid.c: Don't include server.h.
6478         (linux_debug): Remove.
6479         (my_waitpid): Update.
6480
6481 2019-06-11  Tom Tromey  <tromey@adacore.com>
6482
6483         * infcall.c (_initialize_infcall): Remove trailing newline from
6484         help.
6485         * user-regs.c (_initialize_user_regs): Remove trailing newline
6486         from help.
6487         * typeprint.c (_initialize_typeprint): Remove trailing newline
6488         from help.
6489         * reverse.c (_initialize_reverse): Remove trailing newlines from
6490         help.
6491         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6492         from help.
6493         * language.c (add_set_language_command): Remove trailing newline
6494         from help.
6495         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6496         help.
6497         * disasm.c (_initialize_disasm): Remove trailing newline from
6498         help.
6499         * top.c (init_main): Remove trailing newline from help.
6500         * interps.c (_initialize_interpreter): Remove trailing newline
6501         from help.
6502         * btrace.c (_initialize_btrace): Remove trailing newlines from
6503         help.
6504         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6505         from help.
6506         * python/python.c (_initialize_python): Remove trailing newline
6507         from help.
6508         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6509         help.
6510         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6511         from help.  Reformat some text.
6512         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6513         from help.
6514         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6515         newline from help.
6516
6517 2019-06-11  Tom Tromey  <tromey@adacore.com>
6518
6519         * darwin-nat.c (darwin_decode_exception_message)
6520         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6521
6522 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6523
6524         * valops.c (value_slice): Check for not allocated or not
6525         associated values.
6526
6527 2019-06-10  Tom de Vries  <tdevries@suse.de>
6528
6529         PR gdb/24618
6530         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6531         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6532         invalid.
6533
6534 2019-06-10  Tom de Vries  <tdevries@suse.de>
6535
6536         PR gdb/24611
6537         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6538         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6539
6540 2019-06-10  Tom de Vries  <tdevries@suse.de>
6541
6542         PR symtab/24545
6543         * symtab.c (struct demangled_name_entry): Add language field.
6544         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6545         static minimal symbol".  Set and use language field.
6546
6547 2019-06-10  Tom Tromey  <tromey@adacore.com>
6548
6549         * ada-lang.c (_initialize_ada_language): Update help text.
6550
6551 2019-06-10  Tom Tromey  <tromey@adacore.com>
6552
6553         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6554         with a newline.
6555         * guile/guile.c (handle_boot_error): Don't end warning with a
6556         newline.
6557         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6558         warning with a newline.
6559         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6560         newline.
6561         (s12z_frame_cache): Likewise.
6562         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6563         a newline.
6564         * solib-svr4.c (disable_probes_interface): Don't end warning with
6565         a newline.
6566         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6567         newline.
6568         * python/python.c (do_finish_initialization): Don't end warning
6569         with a newline.
6570
6571 2019-06-10  Tom Tromey  <tom@tromey.com>
6572
6573         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6574         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6575         gdbpy_enter.
6576
6577 2019-06-10  Tom Tromey  <tromey@adacore.com>
6578
6579         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6580         data.
6581         (elf_new_init): Don't call stabsread_new_init.
6582         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6583         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6584         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6585
6586 2019-06-10  Tom de Vries  <tdevries@suse.de>
6587
6588         PR symtab/16264
6589         PR symtab/24517
6590         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6591
6592 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6593
6594         * source.c (find_and_open_source): Also rewrite relative file
6595         names.
6596
6597 2019-04-26  Amos Bird  <amosbird@gmail.com>
6598
6599         * annotate.c (annotate_thread_exited): Add "thread-exited"
6600         annotation.
6601
6602 2019-06-06  Tom Tromey  <tromey@adacore.com>
6603
6604         * maint.h (class scoped_command_stats): Use
6605         DISABLE_COPY_AND_ASSIGN.
6606         <print_time>: New method.
6607         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6608         print_time.
6609         (scoped_command_stats::print_time): New method.
6610
6611 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6614         instructions of lengths 6 or 8 bytes.
6615
6616 2019-06-04  Pedro Alves  <palves@redhat.com>
6617
6618         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6619
6620         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6621         * breakpoint.c (condition_completer): Likewise.
6622         * cli/cli-dump.c (scan_expression): Likewise.
6623         * common/filestuff.c (mkdir_recursive): Likewise.
6624         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6625         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6626         (gdb_abspath): Likewise.
6627         * compile/compile-cplus-types.c
6628         (compile_cplus_instance::decl_name): Likewise.
6629         * completer.c (complete_explicit_location):
6630         (signal_completer, reg_or_group_completer_1): Likewise.
6631         * cp-support.c (cp_remove_params_if_any): Likewise.
6632         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6633         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6634         * infcmd.c (strip_bg_char): Likewise.
6635         * linespec.c (copy_token_string): Likewise.
6636         * mi/mi-main.c (output_cores): Likewise.
6637         * psymtab.c (psymtab_search_name):
6638         * symfile.c (test_set_ext_lang_command): Likewise.
6639         * target.c (target_fileio_read_stralloc): Likewise.
6640         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6641         * value.c (complete_internalvar): Likewise.
6642
6643 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6644
6645         Add objfile property to gdb.Type.
6646         * NEWS: Mention Python API addition.
6647         * python/py-type.c (typy_get_objfile): New method.
6648
6649 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6650
6651         * NEWS: Mention the new set|show style [title|highlight].
6652         Mention changes to "show style", "help" and "apropos".
6653
6654 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6655
6656         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6657         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6658         instead of print_help_for_command.
6659         (print_doc_of_command): New function.
6660         (help_list): Add 'apropos -v word' suggestion.
6661         (print_help_for_command): Style the command name using title style.
6662         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6663         (_initialize_cli_cmds): Describe -v in apropos_command help.
6664
6665 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6666
6667         * cli/cli-style.h (cli_style_option): Add name in constructor,
6668         add m_name class member, add constructor with intensity,
6669         add name class function.
6670         (cli_style_option::add_setshow_commands): Remove name argument.
6671         (highlight_style, title_style): New styles.
6672         * cli/cli-style.c (do_show): New function that shows a style
6673         characteristic styling the style name with itself.
6674         (set_style_name): New function.
6675         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6676         Update all callers according to the changes in cli/cli-style.h.
6677         * utils.h (fputs_highlighted): New function.
6678         * utils.c (fputs_highlighted): Likewise.
6679
6680 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6681
6682         * NEWS: Mention new pipe command and new convenience variables.
6683
6684 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6685
6686         * cli/cli-cmds.c (pipe_command): New function.
6687         (_initialize_cli_cmds): Call add_com for pipe_command.
6688         Define | as an alias for pipe.
6689         (exit_status_set_internal_vars): New function.
6690         (shell_escape): Call exit_status_set_internal_vars.
6691         cli/cli-decode.c (find_command_name_length): Recognize | as
6692         a single character command.
6693
6694 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6695
6696         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6697         top.c (execute_command_to_ui_file): New function, mostly a copy
6698         of execute_command_to_string.
6699         (execute_command_to_string): Implement by calling
6700         execute_command_to_ui_file.
6701
6702 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6703
6704         * top.h (saved_command_line): Remove declaration.
6705         * top.c (previous_saved_command_line, previous_repeat_arguments):
6706         New variables.
6707         (saved_command_line): Make static, define together with other
6708         'repeat variables'.
6709         (dont_repeat): Clear repeat_arguments.
6710         (repeat_previous, get_saved_command_line, save_command_line):
6711         New functions.
6712         (gdb_init): Initialize saved_command_line
6713         and previous_saved_command_line.
6714         * main.c (captured_main_1): Remove saved_command_line initialization.
6715         * event-top.c (handle_line_of_input): Update to use
6716         the new 'repeat' related functions instead of direct access to
6717         saved_command_line.
6718         * command.h (repeat_previous, get_saved_command_line,
6719         save_command_line): New declarations.
6720         (dont_repeat): Add comment.
6721
6722 2019-05-30  Tom Tromey  <tromey@adacore.com>
6723
6724         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6725         Fix comment.
6726         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6727
6728 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6729
6730         PR cli/24587
6731         * completer.c (complete): Initialize variable word.
6732
6733 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6734
6735         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6736         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6737         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6738         'body' is NULL to the outter 'if', protecting the '!is_define'
6739         situation as well.
6740
6741 2019-05-29  Tom Tromey  <tromey@adacore.com>
6742
6743         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6744         (dwarf_unknown): New function.
6745         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6746         (dwarf_type_encoding_name): Use dwarf_unknown.
6747
6748 2019-05-29  Tom Tromey  <tromey@adacore.com>
6749
6750         PR c++/20020:
6751         * cp-valprint.c (cp_print_value_fields): Call
6752         cp_print_static_field inside "try".
6753
6754 2019-05-29  Tom Tromey  <tromey@adacore.com>
6755
6756         * inflow.c (struct terminal_info): Add default operator=.
6757         * configure: Rebuild.
6758         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6759         -Wdeprecated-copy-dtor, -Wredundant-move.
6760
6761 2019-05-29  Tom Tromey  <tromey@adacore.com>
6762
6763         * NEWS: Add entry.
6764         * infcmd.c (print_return_value_1): Handle finish_print
6765         option.
6766         (show_print_finish): New function.
6767         (_initialize_infcmd): Add "set/show print finish" commands.
6768         * valprint.c (user_print_options): Initialize new member.
6769         * valprint.h (struct value_print_options) <finish_print>: New
6770         member.
6771
6772 2019-05-28  Tom Tromey  <tromey@adacore.com>
6773
6774         * ada-lang.c (ada_remove_Xbn_suffix)
6775         (find_old_style_renaming_symbol)
6776         (parse_old_style_renaming): Remove.
6777         (ada_find_renaming_symbol): Don't call
6778         find_old_style_renaming_symbol.
6779         (ada_is_renaming_symbol): Rename from
6780         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6781         bool.  Now static.
6782         (ada_read_var_value): Update and simplify.
6783         * ada-exp.y (write_var_or_type): Remove old code.
6784
6785 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6786
6787         PR gdb/25010
6788         * event-top.c: Remove include comment.
6789         * inflow.c (class scoped_ignore_sigttou): Move from here...
6790         * inflow.h (class scoped_ignore_sigttou): ...to here.
6791         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6792         * top.c:  Remove include comment.
6793
6794 2019-05-27  Tom Tromey  <tom@tromey.com>
6795
6796         * NEWS: Fix typo.
6797
6798 2019-05-22  Tom Tromey  <tromey@adacore.com>
6799
6800         * target.c (target_follow_exec): Constify parameter.
6801         * target-delegates.c: Rebuild.
6802         * remote.c (remote_target::follow_exec): Constify parameter.
6803         * infrun.c (follow_exec): Constify parameter.
6804         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6805         (target_follow_exec): Likewise.
6806
6807 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6808
6809         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6810         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6811
6812 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6813
6814         * NEWS: Add debugredirect and testsuite sections.
6815
6816 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6817
6818         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6819         target descriptions using exclusively floating point register name
6820         aliases.
6821
6822 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6823
6824         PR gdb/18644:
6825         * f-lang.c (build_fortran_types): Handle the case where
6826         gdbarch_floatformat_for_type returns a nullptr.
6827
6828 2019-05-21  Tom de Vries  <tdevries@suse.de>
6829
6830         PR cli/24587
6831         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6832
6833 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6834
6835         PR gdb/18644:
6836         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6837         16-byte floats.
6838         * i386-tdep.c (i386_floatformat_for_type): Use
6839         floatformats_ia64_quad for the 16-byte floating point component
6840         within a fortran 32-byte complex number.
6841
6842 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6845         delete default constructor.
6846         (find_partial_die): Update to return const struct.
6847         (partial_die_parent_scope): Move variable declaration into scope
6848         of its use and change its type to auto.
6849         (guess_partial_die_structure_name): Likewise.
6850         (partial_die_info::fixup): Likewise.
6851
6852 2019-05-17  Tom Tromey  <tromey@adacore.com>
6853
6854         * source.c (find_and_open_source): Remove cast.
6855
6856 2019-05-17  Tom Tromey  <tromey@adacore.com>
6857
6858         * annotate.c (annotate_source): Make "filename" const.
6859         * annotate.h (annotate_source): Use const.
6860
6861 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6862
6863         * disasm.c (set_disassembler_options): Send errors to stderr.
6864
6865 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6866
6867         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6868         (cli_interp_base::set_logging): Check debug_redirect.
6869         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6870         * cli/cli-logging.c (debug_redirect): Add static variable.
6871         (pop_output_files): Add default param.
6872         (handle_redirections): Print debug setting.
6873         (show_logging_command): Likewise.
6874         (_initialize_cli_logging): Add debugredirect command.
6875         * interps.c (current_interp_set_logging): Add debug_redirect
6876         parameter.
6877         * interps.h (set_logging): Add debug_redirect parameter.
6878         (current_interp_set_logging): Likewise.
6879         * mi/mi-common.h: Likewise.
6880         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6881
6882 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6883             Tom Tromey  <tromey@adacore.com>
6884
6885         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6886         directly.
6887         * cli/cli-interp.h (make_logging_output): Remove declaration.
6888         * cli/cli-logging.c (make_logging_output): Remove function.
6889         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6890         directly.
6891         * ui-file.c (tee_file::tee_file): Remove bools.
6892         (tee_file::~tee_file): Remove deletes.
6893         * ui-file.h (tee_file): Remove bools.
6894
6895 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6896
6897         * mi/mi-cmds.h (mi_cmd_complete): New function.
6898         * mi/mi-main.c (mi_cmd_complete): Likewise.
6899         * mi/mi-cmds.c: Define new MI command -complete.
6900         * NEWS: Mention new -complete command.
6901
6902 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6903
6904         * completer.h (complete): New function.
6905         * completer.c (complete): Likewise.
6906         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6907         function defined in completer.h.
6908
6909 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6910
6911         * MAINTAINERS (Write After Approval): Add myself.
6912
6913 2019-05-17  Tom de Vries  <tdevries@suse.de>
6914
6915         PR gdb/24094
6916         * dwarf2read.c (struct cu_partial_die_info): New struct.
6917         (find_partial_die): Return cu_partial_die_info.
6918         (partial_die_parent_scope, guess_partial_die_structure_name)
6919         (partial_die_info::fixup): Handle new return type of find_partial_die.
6920
6921 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6922
6923         PR breakpoints/24541
6924         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6925         "std::string", simplifying the algorithm.
6926
6927 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6928
6929         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6930         (stap_static_probe_ops::get_probes): Likewise.
6931
6932 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6933
6934         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6935         '-')" and "else if".
6936         (stap_parse_single_operand): Join checks for
6937         "gdbarch_stap_parse_special_token_p" and
6938         "gdbarch_stap_parse_special_token" in the same "if" statement.
6939         Invert check when verifying for operation on register
6940         displacement.
6941
6942 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6943
6944         * stap-probe.c (stap_get_opcode): Update comment.
6945         (stap_get_expected_argument_type): Likewise.
6946         (handle_stap_probe): Likewise.
6947
6948 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6949
6950         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6951         return type to 'bool'.  Adjust comment.  Use 'bool' when
6952         appropriate.
6953         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6954         * stap-probe.c (stap_parse_argument_1): Likewise.
6955         (stap_is_operator): Likewise.
6956         (stap_is_generic_prefix): Likewise.
6957         (stap_is_register_prefix): Likewise.
6958         (stap_is_register_indirection_prefix): Likewise.
6959         (stap_is_integer_prefix): Likewise.
6960         (stap_generic_check_suffix): Likewise.
6961         (stap_check_integer_suffix): Likewise.
6962         (stap_check_register_suffix): Likewise.
6963         (stap_check_register_indirection_suffix): Likewise.
6964         (stap_parse_register_operand): Likewise.
6965         (stap_parse_single_operand): Likewise.
6966         (stap_parse_argument_1): Likewise.
6967         (stap_probe::get_argument_count): Likewise.
6968         (stap_is_operator): Likewise.
6969
6970 2019-05-16  Tom Tromey  <tromey@adacore.com>
6971
6972         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6973         keyword to foreach.
6974
6975 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6976
6977         * linux-thread-db.c (try_thread_db_load_1): Change return type
6978         to bool.
6979         (try_thread_db_load): Likewise.
6980         (try_thread_db_load_from_pdir_1): Likewise.
6981         (try_thread_db_load_from_pdir): Likewise.
6982         (try_thread_db_load_from_sdir): Likewise.
6983         (try_thread_db_load_from_dir): Likewise.
6984         (thread_db_load_search): Likewise.
6985         (has_libpthread): Likewise.
6986         (thread_db_load): Likewise.
6987
6988 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6989
6990         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6991         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6992         NULL, and complain/return if that's the case.
6993
6994 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6995
6996         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6997         (advance, posn, abstract_read_memory): New functions.
6998         [struct mem_read_abstraction]: New struct.
6999         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7000
7001 2019-05-14  Tom Tromey  <tromey@adacore.com>
7002
7003         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7004         value is not lval_memory.
7005
7006 2019-05-14  Tom Tromey  <tromey@adacore.com>
7007
7008         * solib.c (info_sharedlibrary_command): Style the file name.
7009
7010 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7011
7012         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7013         (aarch64_vnv_type): Likewise.
7014         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7015         * common/tdesc.c: Likewise.
7016         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7017         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7018         * features/aarch64-fpu.xml: Add ieee half view.
7019         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7020         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7021         * gdbtypes.h (struct builtin_type): Likewise.
7022         (struct objfile_type): Likewise.
7023
7024 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7025
7026         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7027         typo.
7028         * location.h (string_to_event_location): Likewise.
7029
7030 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7031
7032         GDB 8.3 released.
7033
7034 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7035
7036         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7037         New variable declaration.
7038         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7039         New variable.
7040         (print_one_breakpoint): Use ui_out::test_flags and new global
7041         variable to compute use_fixed_output.
7042         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7043         Remove.
7044         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7045         (mi_multi_location_breakpoint_output_fixed): Remove.
7046         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7047         new variable.
7048         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7049         fix_multi_location_breakpoint_output flag if version >= 3.
7050         * ui-out.h (enum ui_out_flag)
7051         <fix_multi_location_breakpoint_output>: New enumerator.
7052
7053 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7054
7055         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7056
7057 2019-05-10  Tom Tromey  <tromey@adacore.com>
7058
7059         * ada-lang.c (catch_ada_completer): New function.
7060         (_initialize_ada_language): Use it.
7061
7062 2019-05-10  Tom Tromey  <tromey@adacore.com>
7063
7064         * thread.c (print_thread_info): Make "requested_threads" const.
7065         * gdbthread.h (print_thread_info): Make "requested_threads"
7066         const.
7067         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7068         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7069
7070 2019-05-08  Tom Tromey  <tom@tromey.com>
7071
7072         * gdbtypes.c (objfile_type_data): Change type.
7073         (objfile_type, _initialize_gdbtypes): Update.
7074
7075 2019-05-08  Tom Tromey  <tom@tromey.com>
7076
7077         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7078         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7079         (_initialize_dwarf2_frame): Update.
7080
7081 2019-05-08  Tom Tromey  <tom@tromey.com>
7082
7083         * objc-lang.c (objc_objfile_data): Change type.
7084         (find_methods): Update.
7085         (_initialize_objc_lang): Remove.
7086
7087 2019-05-08  Tom Tromey  <tom@tromey.com>
7088
7089         * stabsread.c (rs6000_builtin_type_data): Change type.
7090         (rs6000_builtin_type, _initialize_stabsread): Update.
7091
7092 2019-05-08  Tom Tromey  <tom@tromey.com>
7093
7094         * mips-tdep.c (mips_pdr_data): Remove.
7095         (_initialize_mips_tdep): Update.
7096
7097 2019-05-08  Tom Tromey  <tom@tromey.com>
7098
7099         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7100         (hppa_init_objfile_priv_data, read_unwind_info)
7101         (find_unwind_entry, _initialize_hppa_tdep): Update.
7102
7103 2019-05-08  Tom Tromey  <tom@tromey.com>
7104
7105         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7106         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7107         on obstack.
7108         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7109
7110 2019-05-08  Tom Tromey  <tom@tromey.com>
7111
7112         * mdebugread.c (basic_type_data): Change type.
7113         (basic_type, _initialize_mdebugread): Update.
7114
7115 2019-05-08  Tom Tromey  <tom@tromey.com>
7116
7117         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7118
7119 2019-05-08  Tom Tromey  <tom@tromey.com>
7120
7121         * nto-tdep.c (nto_inferior_data_reg): Change type.
7122         (nto_inferior_data): Update.
7123         (nto_inferior_data_cleanup, nto_new_inferior_data)
7124         (_initialize_nto_tdep): Remove.
7125         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7126
7127 2019-05-08  Tom Tromey  <tom@tromey.com>
7128
7129         * ada-lang.c (struct ada_inferior_data): Add initializers.
7130         (ada_inferior_data): Change type.
7131         (ada_inferior_data_cleanup): Remove.
7132         (get_ada_inferior_data, ada_inferior_exit)
7133         (struct ada_pspace_data): Add initializers, destructor.
7134         (ada_pspace_data_handle): Change type.
7135         (get_ada_pspace_data): Update.
7136         (ada_pspace_data_cleanup): Remove.
7137
7138 2019-05-08  Tom Tromey  <tom@tromey.com>
7139
7140         * coffread.c (struct coff_symfile_info): Add initializers.
7141         (coff_objfile_data_key): Move lower.  Change type.
7142         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7143         Update.
7144         (coff_free_info): Remove.
7145
7146 2019-05-08  Tom Tromey  <tom@tromey.com>
7147
7148         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7149         (fbsd_pspace_data_handle): Move lower.  Change type.
7150         (get_fbsd_pspace_data): Update.
7151         (fbsd_pspace_data_cleanup): Remove.
7152         (_initialize_fbsd_tdep): Update.
7153
7154 2019-05-08  Tom Tromey  <tom@tromey.com>
7155
7156         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7157         (get_ada_tasks_pspace_data): Update.
7158         (ada_tasks_pspace_data_cleanup): Remove.
7159         (_initialize_tasks): Update.
7160         (ada_tasks_inferior_data_handle): Change type.
7161         (get_ada_tasks_inferior_data): Update.
7162         (ada_tasks_inferior_data_cleanup): Remove.
7163         (struct ada_tasks_pspace_data): Add initializers.
7164
7165 2019-05-08  Tom Tromey  <tom@tromey.com>
7166
7167         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7168         * symfile-debug.c (debug_sym_get_probes): Change type.
7169         * stap-probe.c (handle_stap_probe):
7170         (stap_static_probe_ops::get_probes): Change type.
7171         * probe.h (class static_probe_ops) <get_probes>: Change type.
7172         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7173         (parse_probes_in_pspace): Update.
7174         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7175         Update.
7176         (any_static_probe_ops::get_probes): Change type.
7177         * elfread.c (elfread_data): New typedef.
7178         (probe_key): Change type.
7179         (elf_get_probes): Likewise.  Update.
7180         (probe_key_free): Remove.
7181         (_initialize_elfread): Update.
7182         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7183         Change type.
7184         (dtrace_process_dof_probe, dtrace_process_dof)
7185         (dtrace_static_probe_ops::get_probe): Change type.
7186
7187 2019-05-08  Tom Tromey  <tom@tromey.com>
7188
7189         * xcoffread.c (struct xcoff_symfile_info): Rename from
7190         coff_symfile_info.  Add initializers.
7191         (xcoff_objfile_data_key): Move lower.  Change type.
7192         (XCOFF_DATA): Rewrite.
7193         (xcoff_free_info): Remove.
7194         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7195         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7196         (xcoff_initial_scan): Update.
7197
7198 2019-05-08  Tom Tromey  <tom@tromey.com>
7199
7200         * solib-svr4.c (struct svr4_info): Add initializers and
7201         destructor.
7202         <probes_table>: Now an htab_up.
7203         (solib_svr4_pspace_data): Change type.
7204         (free_probes_table): Simplify.
7205         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7206         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7207         (probes_table_remove_objfile_probes, register_solib_event_probe)
7208         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7209         (_initialize_svr4_solib): Update.
7210
7211 2019-05-08  Tom Tromey  <tom@tromey.com>
7212
7213         * remote.c (remote_pspace_data): Change type.
7214         (remote_pspace_data_cleanup): Remove.
7215         (get_remote_exec_file, set_pspace_remote_exec_file)
7216         (_initialize_remote): Update.
7217
7218 2019-05-08  Tom Tromey  <tom@tromey.com>
7219
7220         * breakpoint.c (breakpoint_objfile_key): Change type.
7221         (get_breakpoint_objfile_data): Update.
7222         (free_breakpoint_objfile_data): Remove.
7223         (_initialize_breakpoint): Update.
7224
7225 2019-05-08  Tom Tromey  <tom@tromey.com>
7226
7227         * linux-tdep.c (struct linux_info): Add initializers.
7228         (linux_inferior_data): Move.  Change type.
7229         (invalidate_linux_cache_inf): Update.
7230         (linux_inferior_data_cleanup): Remove.
7231         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7232
7233 2019-05-08  Tom Tromey  <tom@tromey.com>
7234
7235         * auxv.c (auxv_inferior_data): Move.  Change type.
7236         (auxv_inferior_data_cleanup): Remove.
7237         (invalidate_auxv_cache_inf): Rewrite.
7238         (get_auxv_inferior_data, _initialize_auxv): Update.
7239
7240 2019-05-08  Tom Tromey  <tom@tromey.com>
7241
7242         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7243         (symfile_debug_objfile_data_key): Change type.
7244         (symfile_debug_installed, debug_qf_has_symbols)
7245         (debug_qf_find_last_source_symtab)
7246         (debug_qf_forget_cached_source_info)
7247         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7248         (debug_qf_print_stats, debug_qf_dump)
7249         (debug_qf_expand_symtabs_for_function)
7250         (debug_qf_expand_all_symtabs)
7251         (debug_qf_expand_symtabs_with_fullname)
7252         (debug_qf_map_matching_symbols)
7253         (debug_qf_expand_symtabs_matching)
7254         (debug_qf_find_pc_sect_compunit_symtab)
7255         (debug_qf_map_symbol_filenames)
7256         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7257         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7258         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7259         (debug_sym_read_linetable, debug_sym_relocate): Update.
7260         (symfile_debug_free_objfile): Remove.
7261         (install_symfile_debug_logging, _initialize_symfile_debug):
7262         Update.
7263
7264 2019-05-08  Tom Tromey  <tom@tromey.com>
7265
7266         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7267         allocate_on_obstack.
7268         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7269         (get_dwarf2_per_objfile): Update.
7270         (set_dwarf2_per_objfile): Remove.
7271         (dwarf2_has_info, dwarf2_get_section_info): Update.
7272         (dwarf2_free_objfile): Remove.
7273         (_initialize_dwarf2_read): Update.
7274
7275 2019-05-08  Tom Tromey  <tom@tromey.com>
7276
7277         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7278         initializers.
7279         <unsupported_script_warning_printed,
7280         script_not_found_warning_printed>: Now bool.
7281         (auto_load_pspace_data): Change type.
7282         (~auto_load_pspace_info): Rename from
7283         auto_load_pspace_data_cleanup.
7284         (get_auto_load_pspace_data, init_loaded_scripts_info)
7285         (clear_section_scripts, maybe_print_unsupported_script_warning)
7286         (maybe_print_script_not_found_warning, _initialize_auto_load):
7287         Update.
7288
7289 2019-05-08  Tom Tromey  <tom@tromey.com>
7290
7291         * objfiles.c (objfile_pspace_info): Add destructor and
7292         initializers.
7293         (objfiles_pspace_data): Change type.
7294         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7295         (get_objfile_pspace_data): Update.
7296         (objfiles_bfd_data): Change type.
7297         (get_objfile_bfd_data): Update.
7298         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7299
7300 2019-05-08  Tom Tromey  <tom@tromey.com>
7301
7302         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7303         Change type.
7304         (get_catch_syscall_inferior_data): Update.
7305         (catch_syscall_inferior_data_cleanup): Remove.
7306         (_initialize_break_catch_syscall): Update.
7307
7308 2019-05-08  Tom Tromey  <tom@tromey.com>
7309
7310         * inflow.c (struct terminal_info): Add destructor and
7311         initializers.
7312         (inflow_inferior_data): Change type.
7313         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7314         (get_inflow_inferior_data, inflow_inferior_exit)
7315         (swap_terminal_info, _initialize_inflow): Update.
7316
7317 2019-05-08  Tom Tromey  <tom@tromey.com>
7318
7319         * target-dcache.c (target_dcache_cleanup): Remove.
7320         (target_dcache_aspace_key): Change type.
7321         (target_dcache_init_p, target_dcache_invalidate)
7322         (target_dcache_get, target_dcache_get_or_init)
7323         (_initialize_target_dcache): Update.
7324         * dcache.h (struct dcache_deleter): New.
7325
7326 2019-05-08  Tom Tromey  <tom@tromey.com>
7327
7328         * symtab.c (struct symbol_cache): Add destructor and
7329         initializers.
7330         (symbol_cache_key): Move.  Change type.
7331         (make_symbol_cache, free_symbol_cache): Remove.
7332         (get_symbol_cache): Update.
7333         (symbol_cache_cleanup): Remove.
7334         (ALL_PSPACES, symbol_cache_flush)
7335         (maintenance_print_symbol_cache)
7336         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7337         Update.
7338
7339 2019-05-08  Tom Tromey  <tom@tromey.com>
7340
7341         * symtab.c (struct main_info): Add destructor and initializers.
7342         (main_progspace_key): Move.  Change type.
7343         (get_main_info): Update.
7344         (main_info_cleanup): Remove.
7345         (_initialize_symtab): Update.
7346
7347 2019-05-08  Tom Tromey  <tom@tromey.com>
7348
7349         * registry.h (DECLARE_REGISTRY): Define the _key class.
7350
7351 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * NEWS: Merge two 'New commands' sections.
7354
7355 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7356
7357         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7358         parameter and use Ada language definition instead.
7359         (ada_val_print_ptr): Remove unused language parameter.
7360         (ada_val_print_num): Remove language parameter and use Ada language
7361         definition instead.
7362         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7363         parameter.
7364         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7365         parameter and use Ada language definition instead.
7366         (ada_val_print_1): Update all ada_val_print_xxx calls.
7367         Remove language parameter.
7368         (ada_val_print): Update ada_val_print_1 call.
7369
7370 2019-05-08  Tom Tromey  <tromey@adacore.com>
7371
7372         * remote.c (remote_hw_watchpoint_limit)
7373         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7374         Now static.
7375
7376 2019-05-08  Tom Tromey  <tromey@adacore.com>
7377
7378         * maint.c (_initialize_maint_cmds): Move initialization code to
7379         remote.c.
7380         (watchdog, show_watchdog): Move to remote.c.
7381         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7382         "watchdog" static.
7383         (_initialize_remote): Move initialization code from maint.c.
7384         * defs.h (watchdog): Don't declare.
7385
7386 2019-05-08  Tom Tromey  <tromey@adacore.com>
7387
7388         * tui/tui-interp.c: Include main.h.
7389         * interps.c: Include main.h.
7390         * main.h (interpreter_p): Declare.
7391         * defs.h (interpreter_p): Don't declare.
7392
7393 2019-05-08  Tom Tromey  <tromey@adacore.com>
7394
7395         * dwarf2loc.c: Include dwarf2read.h.
7396         * defs.h (read_unsigned_leb128): Don't declare.
7397         * dwarf2read.h (read_unsigned_leb128): Declare.
7398
7399 2019-05-08  Tom Tromey  <tromey@adacore.com>
7400
7401         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7402         method.
7403
7404 2019-05-08  Tom Tromey  <tromey@adacore.com>
7405
7406         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7407         when no wrap column is set.
7408
7409 2019-05-08  Tom Tromey  <tromey@adacore.com>
7410
7411         * c-lang.c (c_get_string): Handle non-C-style arrays.
7412
7413 2019-05-08  Tom Tromey  <tromey@adacore.com>
7414
7415         * typeprint.c (print_offset_data::update): Print the bit offset,
7416         not the number of bits remaining.
7417
7418 2019-05-08  Tom Tromey  <tromey@adacore.com>
7419
7420         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7421         padding at end of comment.
7422
7423 2019-05-08  Tom Tromey  <tromey@adacore.com>
7424
7425         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7426         Compare main types.
7427
7428 2019-05-06  Tom Tromey  <tom@tromey.com>
7429
7430         * common/scoped_mmap.c: Include common-defs.h.
7431         * common/scoped_mmap.h: Don't include config.h.
7432
7433 2019-05-04  Tom Tromey  <tom@tromey.com>
7434
7435         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7436         (struct aarch64_call_info): Add initializers.
7437         <si>: Now a std::vector.
7438         (pass_on_stack, aarch64_push_dummy_call): Update.
7439
7440 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7441             Tom Tromey  <tom@tromey.com>
7442
7443         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7444         (ppc_threads): Now a std::vector.  Now static.
7445         (hwdebug_find_thread_points_by_tid)
7446         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7447         Update.
7448
7449 2019-05-04  Tom Tromey  <tom@tromey.com>
7450
7451         * arc-tdep.c (arc_tdesc_init): Return bool.
7452
7453 2019-05-04  Tom Tromey  <tom@tromey.com>
7454
7455         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7456         Use gdb_assert_not_reached.
7457
7458 2019-05-04  Tom Tromey  <tom@tromey.com>
7459
7460         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7461         "false".
7462
7463 2019-05-04  Tom Tromey  <tom@tromey.com>
7464
7465         * arc-tdep.c (arc_tdesc_init): Use bool.
7466
7467 2019-05-04  Tom Tromey  <tom@tromey.com>
7468
7469         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7470
7471 2019-05-04  Tom Tromey  <tom@tromey.com>
7472
7473         * cli/cli-cmds.c (valid_command_p): Return bool.
7474
7475 2019-05-04  Tom Tromey  <tom@tromey.com>
7476
7477         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7478         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7479
7480 2019-05-04  Raul Tambre  <raul@tambre.ee>
7481
7482         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7483         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7484         operator for comparison.
7485
7486 2019-05-04  Tom Tromey  <tom@tromey.com>
7487
7488         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7489         (lookup_partial_symbol, print_partial_symbols)
7490         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7491         (psymbol_compare): Update.
7492         (add_psymbol_to_bcache): Clear the entire psymbol.
7493         (maintenance_check_psymtabs): Update.
7494         * psympriv.h (struct partial_symbol): Don't derive from
7495         general_symbol_info.
7496         <obj_section, unrelocated_address, address,
7497         set_unrelocated_address>: Update.
7498         <ginfo>: New member.
7499         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7500         (debug_names::write_psymbols): Update.
7501
7502 2019-05-04  Tom de Vries  <tdevries@suse.de>
7503
7504         * contrib/cc-with-tweaks.sh: Support -n arg.
7505
7506 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7507
7508         * corelow.c (core_target::detach): Ensure frame cache and
7509         register caches are cleared.
7510         inferior.c (exit_inferior_1): Likewise.
7511
7512 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7513             Tom Tromey  <tom@tromey.com>
7514
7515         * dictionary.c (collate_pending_symbols_by_language): Remove
7516         "struct" from foreach.
7517         * symtab.c (lookup_global_symbol_from_objfile)
7518         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7519         foreach.
7520         * ser-tcp.c (net_open): Remove "struct" from foreach.
7521         * objfiles.c (objfile_relocate, objfile_rebase)
7522         (objfile_has_symbols): Remove "struct" from foreach.
7523         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7524         from foreach.
7525         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7526         foreach.
7527         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7528         "struct" from foreach.
7529         * ada-lang.c (create_excep_cond_exprs)
7530         (ada_exception_catchpoint_cond_string): Remove "struct" from
7531         foreach.
7532
7533 2019-05-03  Tom Tromey  <tromey@adacore.com>
7534
7535         * ada-exp.y (convert_char_literal): Check suffix of each
7536         enumerator.
7537
7538 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7539
7540         PR ada/21406:
7541         * ada-exp.y (yywrap): Don't define.
7542         * ada-lex.l (%option): Add noyywrap
7543         (yywrap): Remove.
7544
7545 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7546
7547         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7548         _WIN32_WINNT to the XP level, unless already defined to a higher
7549         level.
7550
7551         * unittests/parse-connection-spec-selftests.c:
7552         * ser-tcp.c:
7553         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7554         override.
7555
7556         * symfile.c (find_separate_debug_file): Remove colon from the
7557         drive spec of DOS/Windows file names of the target, so that the
7558         file name produced from DEBUGDIR and the target's directory will
7559         be valid on DOS/Windows systems.
7560
7561 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7562
7563         * rust-lang.c (val_print_struct): Handle printing structures
7564         containing strings.
7565
7566 2019-05-02  Tom Tromey  <tromey@adacore.com>
7567
7568         * valarith.c (_initialize_valarith): Remove.
7569
7570 2019-05-01  Tom Tromey  <tromey@adacore.com>
7571
7572         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7573         bitfields.
7574
7575 2019-05-01  Tom Tromey  <tromey@adacore.com>
7576
7577         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7578         for big-endian copies.
7579
7580 2019-04-30  Ali Tamur  <tamur@google.com>
7581         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7582         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7583         (read_3_bytes): New function.
7584
7585 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7586
7587         * windows-nat.c (main_thread_id): Delete.
7588         (handle_output_debug_string): Replace main_thread_id by
7589         current_event.dwThreadId.
7590         (fake_create_process): Likewise.
7591         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7592         Do not set main_thread_id.
7593         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7594         current_event.dwThreadId.
7595         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7596
7597 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7598
7599         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7600         Use current_event.dwThreadId instead of main_thread_id.
7601
7602 2019-04-30  Tom Tromey  <tromey@adacore.com>
7603
7604         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7605         (create_excep_cond_exprs): Iterate over program spaces.
7606         (ada_exception_catchpoint_cond_string): Examine all minimal
7607         symbols for exception types.
7608
7609 2019-04-30  Tom Tromey  <tromey@adacore.com>
7610
7611         PR c++/24470:
7612         * dwarf2read.c (process_structure_scope): Handle case where type
7613         has template parameters but no symbol was created.
7614
7615 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7616             Chris January  <chris.january@arm.com>
7617
7618         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7619         qualifier.
7620         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7621
7622 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * f-typeprint.c (f_print_type): Update rules for printing
7625         whitespace.
7626         (f_type_print_varspec_suffix): Likewise.
7627
7628 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7629             Chris January  <chris.january@arm.com>
7630
7631         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7632         function arguments.
7633
7634 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7635
7636         * f-lang.c (build_fortran_types): Change name of void type to
7637         lower case.
7638         * f-typeprint.c (f_type_print_base): Print the name of the void
7639         type, rather than a fixed string.
7640         * f-valprint.c (f_decorations): Use lower case void string.
7641
7642 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7643             Chris January  <chris.january@arm.com>
7644
7645         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7646         types for Fortran.
7647
7648 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7649             Chris January  <chris.january@arm.com>
7650             David Lecomber  <david.lecomber@arm.com>
7651
7652         * f-exp.y (BINOP_INTRINSIC): New token.
7653         (exp): New parser rule handling BINOP_INTRINSIC.
7654         (f77_keywords): Add new builtin procedures.
7655         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7656         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7657         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7658         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7659         (print_unop_subexp_f): New function.
7660         (print_binop_subexp_f): New function.
7661         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7662         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7663         (dump_subexp_body_f): Likewise.
7664         (operator_check_f): Likewise.
7665         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7666         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7667
7668 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7671         UNOP_KIND.
7672         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7673         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7674         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7675         (operator_length_f): New fuction.
7676         (print_subexp_f): New function.
7677         (op_name_f): New function.
7678         (dump_subexp_body_f): New function.
7679         (operator_check_f): New function.
7680         (exp_descriptor_f): Replace standard expression handling functions
7681         with new functions.
7682         * gdb/fortran-operator.def: New file.
7683         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7684         * gdb/std-operator.def: Remove UNOP_KIND.
7685
7686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7687
7688         * std-operator.def: Remove unbalanced, stray double quote
7689         character.
7690
7691 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7692             Chris January  <chris.january@arm.com>
7693             Daniel Everett  <daniel.everett@arm.com>
7694             Nick Forrington  <nick.forrington@arm.com>
7695             Richard Bunt  <richard.bunt@arm.com>
7696
7697         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7698         of depth when printing anonymous structs or unions.
7699         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7700         Don't print either the top-level value, or the children if the
7701         max-depth is exceeded.
7702         (ppscm_print_children): When printing the key of a map, allow one
7703         extra level of depth.
7704         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7705         print either the top-level value, or the children if the max-depth
7706         is exceeded.
7707         (print_children): When printing the key of a map, allow one extra
7708         level of depth.
7709         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7710         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7711         (user_print_options): Initialise max_depth field.
7712         (val_print_scalar_or_string_type_p): New function.
7713         (val_print): Check to see if the max depth has been reached.
7714         (val_print_check_max_depth): Define new function.
7715         (show_print_max_depth): New function.
7716         (_initialize_valprint): Add 'print max-depth' option.
7717         * valprint.h (struct value_print_options) <max_depth>: New field.
7718         (val_print_check_max_depth): Declare new function.
7719         * NEWS: Document new feature.
7720
7721 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * ada-lang.c (ada_language_defn): Initialise new field.
7724         * c-lang.c (c_is_string_type_p): New function.
7725         (c_language_defn): Initialise new field.
7726         (cplus_language_defn): Initialise new field.
7727         (asm_language_defn): Initialise new field.
7728         (minimal_language_defn): Initialise new field.
7729         * c-lang.h (c_is_string_type_p): Declare new function.
7730         * d-lang.c (d_language_defn): Initialise new field.
7731         * f-lang.c (f_is_string_type_p): New function.
7732         (f_language_defn): Initialise new field.
7733         * go-lang.c (go_is_string_type_p): New function.
7734         (go_language_defn): Initialise new field.
7735         * language.c (default_is_string_type_p): New function.
7736         (unknown_language_defn): Initialise new field.
7737         (auto_language_defn): Initialise new field.
7738         * language.h (struct language_defn) <la_is_string_type_p>: New
7739         member variable.
7740         (default_is_string_type_p): Declare new function.
7741         * m2-lang.c (m2_language_defn): Initialise new field.
7742         * objc-lang.c (objc_language_defn): Initialise new field.
7743         * opencl-lang.c (opencl_language_defn): Initialise new field.
7744         * p-lang.c (pascal_is_string_type_p): New function.
7745         (pascal_language_defn): Initialise new field.
7746         * rust-lang.c (rust_is_string_type_p): New function.
7747         (rust_language_defn): Initialise new field.
7748
7749 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7752         New field.
7753         * ada-lang.c (ada_language_defn): Initialise new field.
7754         * c-lang.c (c_language_defn): Likewise.
7755         (cplus_language_defn): Likewise.
7756         (asm_language_defn): Likewise.
7757         (minimal_language_defn): Likewise.
7758         * d-lang.c (d_language_defn): Likewise.
7759         * f-lang.c (f_language_defn): Likewise.
7760         * go-lang.c (go_language_defn): Likewise.
7761         * language.c (unknown_language_defn): Likewise.
7762         (auto_language_defn): Likewise.
7763         * m2-lang.c (m2_language_defn): Likewise.
7764         * objc-lang.c (objc_language_defn): Likewise.
7765         * opencl-lang.c (opencl_language_defn): Likewise.
7766         * p-lang.c (pascal_language_defn): Likewise.
7767         * rust-lang.c (rust_language_defn): Likewise.
7768
7769 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * ada-lang.c (ada_is_character_type): Change return type to bool.
7772         (ada_is_string_type): Likewise.
7773         * ada-lang.h (ada_is_character_type): Update declaration
7774         (ada_is_string_type): Likewise.
7775
7776 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7777
7778         Support style in 'frame|thread apply'
7779
7780         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7781         * record.c (record_start, record_stop): Update callers of
7782         execute_command_to_string with false.
7783         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7784         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7785         methods.
7786         (class string_file): New constructor with term_out parameter.
7787         Override methods term_out and can_emit_style_escape.  New member
7788         term_out.
7789         (class stdio_file): Override can_emit_style_escape.
7790         (class tee_file): Override term_out and can_emit_style_escape.
7791         * utils.h (can_emit_style_escape): Remove.
7792         * utils.c (can_emit_style_escape): Likewise.
7793         Update all callers of can_emit_style_escape (SOMESTREAM) to
7794         SOMESTREAM->can_emit_style_escape.
7795         * source-cache.c (source_cache::get_source_lines): Likewise.
7796         * stack.c (frame_apply_command_count): Call execute_command_to_string
7797         passing the term_out characteristic of the current gdb_stdout.
7798         * thread.c (thr_try_catch_cmd): Likewise.
7799         * top.c (execute_command_to_string): pass term_out parameter
7800         to construct the string_file for the command output.
7801         * ui-file.c (term_cli_styling): New function (most code moved
7802         from utils.c can_emit_style_escape).
7803         (string_file::string_file, string_file::can_emit_style_escape,
7804         stdio_file::can_emit_style_escape, tee_file::term_out,
7805         tee_file::can_emit_style_escape): New functions.
7806
7807 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7808
7809         * NEWS: Mention the new set|show may-call-functions.
7810         * infcall.c (may_call_functions_p): New variable.
7811         (show_may_call_functions_p): New function.
7812         (call_function_by_hand_dummy): Throws an error if not
7813         may-call-functions.
7814         (_initialize_infcall): Call add_setshow_boolean_cmd for
7815         may-call-functions.
7816
7817 2019-04-25  Keith Seitz  <keiths@redhat.com>
7818
7819         PR c++/24367
7820         * cp-support.c (inspect_type): Don't attempt substitutions
7821         of symbol with the same name.
7822
7823 2019-04-25  Tom Tromey  <tromey@adacore.com>
7824
7825         PR gdb/24475:
7826         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7827         static.
7828
7829 2019-04-25  Tom Tromey  <tromey@adacore.com>
7830
7831         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7832         rvalue reference.
7833         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7834         (gdb_xml_parser::parse): Use std::move.
7835         * python/python-internal.h (gdbpy_convert_exception): Take a const
7836         reference.
7837         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7838         std::move.
7839         * python/py-utils.c (gdbpy_convert_exception): Take a const
7840         reference.
7841         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7842         Use std::move.
7843         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7844         Use std::move.
7845         * mi/mi-main.c (mi_print_exception): Take a const reference.
7846         * main.c (handle_command_errors): Take a const reference.
7847         * linespec.c (parse_linespec): Use std::move.
7848         * infcall.c (run_inferior_call): Use std::move.
7849         (call_function_by_hand_dummy): Use std::move.
7850         * exec.c (try_open_exec_file): Use std::move.
7851         * exceptions.h (exception_print, exception_fprintf)
7852         (exception_print_same): Update.
7853         * exceptions.c (print_exception, exception_print)
7854         (exception_fprintf, exception_print_same): Change parameters to
7855         const reference.
7856         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7857         * common/new-op.c: Use std::move.
7858         * common/common-exceptions.h (struct gdb_exception): Add move
7859         constructor.
7860         (struct gdb_exception_error, struct gdb_exception_quit, struct
7861         gdb_quit_bad_alloc): Change constructor to move constructor.
7862         (throw_exception): Change parameter to rvalue reference.
7863         * common/common-exceptions.c (throw_exception): Take rvalue
7864         reference.
7865         * cli/cli-interp.c (safe_execute_command): Use std::move.
7866         * breakpoint.c (insert_bp_location, location_to_sals): Use
7867         std::move.
7868
7869 2019-04-25  Tom Tromey  <tromey@adacore.com>
7870
7871         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7872         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7873         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7874         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7875         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7876         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7877         guile/scm-value.c: Use unpack.
7878         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7879         gdbscm_gdb_exception.
7880         (gdbscm_throw_gdb_exception): Likewise.
7881         (struct gdbscm_gdb_exception): New.
7882         (unpack): New function.
7883         (gdbscm_wrap): Use unpack.
7884
7885 2019-04-25  Tom Tromey  <tromey@adacore.com>
7886
7887         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7888         (gdb_rl_callback_handler): Use std::move.
7889         * common/common-exceptions.h (struct gdb_exception): Add move
7890         assignment operator.
7891         (throw_exception_sjlj): Change "exception" to const reference.
7892         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7893         (throw_exception_sjlj): Change "exception" to const reference.
7894
7895 2019-04-25  Tom Tromey  <tromey@adacore.com>
7896
7897         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7898         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7899         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7900         Update.
7901         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7902         Update.
7903         * mi/mi-interp.c (mi_interp::exec): Update.
7904         * linespec.c (parse_linespec): Update.
7905         * infcall.c (run_inferior_call): Update.
7906         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7907         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7908         (gdbscm_lookup_global_symbol): Update.
7909         * guile/scm-param.c (gdbscm_parameter_value): Update.
7910         * guile/scm-frame.c (gdbscm_frame_read_register)
7911         (gdbscm_frame_read_var): Update.
7912         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7913         * exec.c (try_open_exec_file): Update.
7914         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7915         (gdb_rl_callback_handler): Update.
7916         * common/common-exceptions.h (exception_none): Don't declare.
7917         * common/common-exceptions.c (exception_none): Don't define.
7918         (struct catcher) <exception>: Update.
7919         * cli/cli-interp.c (safe_execute_command): Update.
7920         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7921
7922 2019-04-25  Ali Tamur  <tamur@google.com>
7923
7924         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7925         (read_attribute_value): Likewise.
7926         (dwarf2_read_addr_index): Update comment.
7927         (read_str_index): Add DW_FORM_strx.
7928         (dwarf2_string_attr): Likewise.
7929         (dwarf2_const_value_attr): Likewise.
7930         (dump_die_shallow): Likewise.
7931         (dwarf2_fetch_constant_bytes): Likewise.
7932         (skip_form_bytes): Likewise.
7933         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7934
7935 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7936
7937         PR corefiles/11608
7938         PR corefiles/18187
7939         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7940         OFFSET.  Verify if current mapping contains an ELF header.
7941         (linux_find_memory_regions_full): Adjust call to
7942         dump_mapping_p.
7943
7944 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7945             Kang Li <kanglictf@gmail.com>
7946
7947         PR gdb/21600
7948
7949         * dwarf2-frame.c (read_initial_length): Be consistent about using
7950         unsigned representation of length.
7951         (decode_frame_entry_1): Likewise.  Check for wraparound of
7952         end pointer as well as buffer overflow.
7953
7954 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7955
7956         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7957         "vq".
7958
7959 2019-04-24  Tom Tromey  <tromey@adacore.com>
7960
7961         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7962
7963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * s12z-tdep.c (s12z_unwind_pc): Delete.
7966         (s12z_unwind_sp): Delete.
7967         (s12z_gdbarch_init): Don't register deleted functions with
7968         gdbarch.
7969
7970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7971
7972         * rl78-tdep.c (rl78_unwind_sp): Delete.
7973         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7974
7975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7976
7977         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7978         (xstormy16_unwind_pc): Delete.
7979         (xstormy16_dummy_id): Delete.
7980         (xstormy16_gdbarch_init): Don't register deleted functions with
7981         gdbarch.
7982
7983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7984
7985         * vax-tdep.c (vax_unwind_pc): Delete.
7986         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7987
7988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7989
7990         * v850-tdep.c (v850_unwind_sp): Delete.
7991         (v850_unwind_pc): Delete.
7992         (v850_dummy_id): Delete.
7993         (v850_gdbarch_init): Don't register deleted functions with
7994         gdbarch.
7995
7996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7999         (tilegx_unwind_pc): Delete.
8000         (tilegx_unwind_dummy_id): Delete.
8001         (tilegx_gdbarch_init): Don't register deleted functions with
8002         gdbarch.
8003
8004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8005
8006         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8007         (tic6x_dummy_id): Delete.
8008         (tic6x_gdbarch_init): Don't register deleted functions with
8009         gdbarch.
8010
8011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8012
8013         * sparc-tdep.c (sparc_unwind_pc): Delete.
8014         (sparc32_gdbarch_init): Don't register deleted function with
8015         gdbarch.
8016
8017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * sh-tdep.c (sh_unwind_sp): Delete.
8020         (sh_unwind_pc): Delete.
8021         (sh_dummy_id): Delete.
8022         (sh_gdbarch_init): Don't register deleted functions with
8023         gdbarch.
8024
8025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8026
8027         * score-tdep.c (score_unwind_sp): Delete.
8028         (score_unwind_pc): Delete.
8029         (score_dummy_id): Delete.
8030         (score_gdbarch_init): Don't register deleted functions with
8031         gdbarch.
8032
8033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8034
8035         * rx-tdep.c (rx_unwind_pc): Delete.
8036         (rx_unwind_sp): Delete.
8037         (rx_dummy_id): Delete.
8038         (rx_gdbarch_init): Don't register deleted functions with
8039         gdbarch.  Update comment.
8040
8041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8042
8043         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8044         (rs6000_dummy_id): Delete.
8045         (rs6000_gdbarch_init): Don't register deleted functions with
8046         gdbarch.
8047
8048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * or1k-tdep.c (or1k_dummy_id): Delete.
8051         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8052
8053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8054
8055         * nios2-tdep.c (nios2_dummy_id): Delete.
8056         (nios2_unwind_sp): Delete.
8057         (nios2_gdbarch_init): Don't register deleted functions with
8058         gdbarch.
8059
8060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * nds32-tdep.c (nds32_dummy_id): Delete.
8063         (nds32_unwind_pc): Delete.
8064         (nds32_unwind_sp): Delete.
8065         (nds32_gdbarch_init): Don't register deleted functions with
8066         gdbarch.
8067
8068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * msp430-tdep.c (msp430_unwind_pc): Delete.
8071         (msp430_unwind_sp): Delete.
8072         (msp430_dummy_id): Delete.
8073         (msp430_gdbarch_init): Don't register deleted functions with
8074         gdbarch.
8075
8076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * moxie-tdep.c (moxie_unwind_sp): Delete.
8079         (moxie_unwind_pc): Delete.
8080         (moxie_dummy_id): Delete.
8081         (moxie_gdbarch_init): Don't register deleted functions with
8082         gdbarch.
8083
8084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8085
8086         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8087         (mn10300_unwind_pc): Delete.
8088         (mn10300_unwind_sp): Delete.
8089         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8090         mn10300_unwind_sp.
8091         (mn10300_frame_unwind_init): Don't register deleted functions with
8092         gdbarch.
8093
8094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * mep-tdep.c (mep_unwind_pc): Delete.
8097         (mep_unwind_sp): Delete.
8098         (mep_dummy_id): Delete.
8099         (mep_gdbarch_init): Don't register deleted functions with
8100         gdbarch.
8101
8102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8105         (m68hc11_unwind_sp): Delete.
8106         (m68hc11_gdbarch_init): Don't register deleted functions with
8107         gdbarch.
8108
8109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8110
8111         * m32r-tdep.c (m32r_unwind_sp): Delete.
8112         (m32r_unwind_pc): Delete.
8113         (m32r_dummy_id): Delete.
8114         (m32r_gdbarch_init): Don't register deleted functions with
8115         gdbarch.
8116
8117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8118
8119         * m32c-tdep.c (m32c_unwind_pc): Delete.
8120         (m32c_unwind_sp): Delete.
8121         (m32c_dummy_id): Delete.
8122         (m32c_gdbarch_init): Don't register deleted functions with
8123         gdbarch.
8124
8125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8126
8127         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8128         (lm32_unwind_pc): Delete.
8129         (lm32_dummy_id): Delete.
8130         (lm32_gdbarch_init): Don't register deleted functions with
8131         gdbarch.
8132
8133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8134
8135         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8136         (iq2000_unwind_pc): Delete.
8137         (iq2000_dummy_id): Delete.
8138         (iq2000_gdbarch_init): Don't register deleted functions with
8139         gdbarch.
8140
8141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * nds32-tdep.c (nds32_type_align): Delete.
8144         (nds32_push_dummy_call): Use type_align instead.
8145
8146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * arm-tdep.c (arm_type_align): Only handle vector override case.
8149         (arm_push_dummy_call): Use type_align.
8150         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8151
8152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8153
8154         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8155         case.
8156         (pass_on_stack): Use type_align.
8157         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8158         function.
8159
8160 2019-04-23  Tom Tromey  <tromey@adacore.com>
8161
8162         * dwarf2read.c (line_header::file_name_at): Remove unused
8163         overload.
8164
8165 2019-04-23  Tom de Vries  <tdevries@suse.de>
8166
8167         PR gdb/24438
8168         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8169         invocation.
8170
8171
8172 2019-03-27  Ali Tamur  <tamur@google.com>
8173
8174         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8175         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8176         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8177         (dwarf_expr_context::get_addr_index): Likewise
8178         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8179         (symbol_needs_eval_context::get_addr_index): Likewise
8180         (disassemble_dwarf_expression): Add DW_OP_addrx
8181         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8182         (read_cutu_die_from_dwo): Update comment
8183         (skip_one_die): Add DW_FORM_addrx
8184         (read_attribute_value): Likewise
8185         (var_decode_location): Add DW_OP_addrx
8186         (dwarf2_const_value_attr): Add DW_FORM_addrx
8187         (dump_die_shallow): Likewise
8188         (dwarf2_fetch_constant_bytes): Likewise
8189         (decode_locdesc): Add DW_OP_addrx
8190         (skip_form_bytes): Add DW_FORM_addrx
8191
8192 2019-04-22  Ali Tamur  <tamur@google.com>
8193
8194         * MAINTAINERS (Write After Approval): Add self.
8195
8196 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8197
8198         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8199         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8200         (open_symbol_file_object): Likewise.
8201         (svr4_default_sos): Add info parameter.
8202         (svr4_read_so_list): Likewise.
8203         (svr4_current_sos_direct): Adjust functions calls to pass down
8204         info.
8205         (svr4_current_sos_1): Add info parameter.
8206         (svr4_current_sos): Call get_svr4_info, pass info down to
8207         svr4_current_sos_1.
8208         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8209         get_svr4_info.
8210         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8211         get_svr4_info.
8212         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8213         to get_svr4_info.
8214         (probes_table_remove_objfile_probes): Likewise.
8215         (register_solib_event_probe): Add info parameter.
8216         (solist_update_incremental): Pass info parameter down to
8217         svr4_read_so_list.
8218         (disable_probes_interface): Add info parameter.
8219         (svr4_handle_solib_event): Pass current_program_space to
8220         get_svr4_info.  Adjust disable_probes_interface cleanup.
8221         (svr4_create_probe_breakpoints): Add info parameter, pass it
8222         down to register_solib_event_probe.
8223         (svr4_create_solib_event_breakpoints): Add info parameter,
8224         pass it down to svr4_create_probe_breakpoints.
8225         (enable_break): Pass info down to
8226         svr4_create_solib_event_breakpoints.
8227         (svr4_solib_create_inferior_hook): Pass current_program_space to
8228         get_svr4_info.
8229         (svr4_clear_solib): Likewise.
8230
8231 2019-04-22  Pedro Alves  <palves@redhat.com>
8232
8233         * solib-svr4.c (svr4_free_objfile_observer): New.
8234         (probe_and_action::objfile): New field.
8235         (probes_table_htab_remove_objfile_probes)
8236         (probes_table_remove_objfile_probes): New functions.
8237         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8238         in the new probe_and_action.  Don't store the probe in 'lookup'.
8239         (svr4_create_probe_breakpoints): Pass objfile to
8240         register_solib_event_probe.
8241         (_initialize_svr4_solib): Register a free_objfile observer.
8242
8243 2019-04-19  Tom Tromey  <tom@tromey.com>
8244
8245         * common/queue.h: Remove.
8246
8247 2019-04-19  Tom Tromey  <tom@tromey.com>
8248
8249         * event-loop.c: Don't include "common/queue.h".
8250
8251 2019-04-19  Tom Tromey  <tom@tromey.com>
8252
8253         * remote.c (remote_target): Use delete.
8254         * remote-notif.h: Include <list>, not "common/queue.h".
8255         (notif_client_p): Remove typedef.
8256         (remote_notif_state): Add constructor, destructor, initializer.
8257         <notif_queue>: Now a std::list.
8258         (remote_notif_state_xfree): Don't declare.
8259         * remote-notif.c (remote_notif_process, handle_notification)
8260         (remote_notif_state_allocate): Update.
8261         (~remote_notif_state): Rename from remote_notif_state_xfree.
8262
8263 2019-04-19  Tom Tromey  <tom@tromey.com>
8264
8265         * symfile.c (reread_symbols): Update.
8266         * objfiles.c (objfile_register_static_link)
8267         (objfile_lookup_static_link): Update
8268         (~objfile) Don't delete static_links.
8269         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8270
8271 2019-04-19  Tom Tromey  <tom@tromey.com>
8272
8273         * type-stack.h (struct type_stack) <insert>: Constify string.
8274         * type-stack.c (type_stack::insert): Constify string.
8275         * gdbtypes.h (lookup_template_type): Update.
8276         (address_space_name_to_int): Update.
8277         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8278         const.
8279         (lookup_template_type): Make name const.
8280         * c-exp.y: Update rules.
8281         (lex_one_token, classify_name, classify_inner_name)
8282         (c_print_token): Update.
8283         * p-exp.y: Update rules.
8284         (yylex): Update.
8285         * f-exp.y: Update rules.
8286         (yylex): Update.
8287         * d-exp.y: Update rules.
8288         (lex_one_token, classify_name, classify_inner_name): Update.
8289         * parse.c (write_dollar_variable, copy_name): Return std::string.
8290         * parser-defs.h (copy_name): Change return type.
8291         * m2-exp.y: Update rules.
8292         (yylex): Update.
8293         * go-exp.y (lex_one_token): Update.
8294         Update rules.
8295         (classify_unsafe_function, classify_packaged_name)
8296         (classify_name, yylex): Update.
8297
8298 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8299
8300         * configure.ac: add --enable-source-highlight switch.
8301         * configure: Regenerate.
8302         * top.c (print_gdb_version): plumb --enable-source-highlight
8303         status to "show configuration".
8304
8305 2019-04-19  Tom Tromey  <tromey@adacore.com>
8306
8307         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8308         Check ADA_TYPE_P.
8309         (empty_record, ada_template_to_fixed_record_type_1)
8310         (template_to_static_fixed_type)
8311         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8312         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8313         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8314         macros.
8315
8316 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8317
8318         PR symtab/24423:
8319         * source.c (print_source_lines_base): Advance "iter" when a
8320         control character is seen.
8321
8322 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8323
8324         * inferior.h (struct infcall_suspend_state_deleter):
8325         Catch exception in destructor to avoid crash.
8326
8327 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8328
8329         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8330         close to the add_com "shell".
8331
8332 2019-04-18  Tom Tromey  <tromey@adacore.com>
8333
8334         * process-stratum-target.h (class process_stratum_target)
8335         <stratum>: Add "final".
8336
8337 2019-04-17  Tom Tromey  <tromey@adacore.com>
8338
8339         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8340         against nullptr before use.
8341
8342 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8343
8344         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8345
8346 2019-04-17  Jim Wilson  <jimw@sifive.com>
8347             Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8350         code read might fail, assume 4-byte breakpoint in that case.
8351
8352 2019-04-15  Leszek Swirski  <leszeks@google.com>
8353
8354         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8355         rather than a hand-rolled POD check when checking for forced MEMORY
8356         classification.
8357
8358 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8359
8360         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8361         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8362         function.
8363         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8364         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8365         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8366         declaration.
8367
8368 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8369
8370         * aarch64-linux-nat.c
8371         (aarch64_linux_nat_target::thread_architecture): Add override.
8372         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8373         each VQ.
8374
8375 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8376
8377         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8378
8379 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8382         target types of size 96-bits, add some additional comments, and
8383         check that the builtin type we found was the correct size.
8384
8385 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8386
8387         * utils.c (prompt_for_continue): Don't restore the styling at the
8388         end, as applied_style has the wrong value.  This fixes styling in
8389         long lists of file names that are interrupted by the "Continue?"
8390         prompt.
8391
8392 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8393
8394         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8395         * c-lang.c (c_language_defn): Likewise.
8396         (cplus_language_defn): Likewise.
8397         (asm_language_defn): Likewise.
8398         (minimal_language_defn): Likewise.
8399         * d-lang.c (d_language_defn): Likewise.
8400         * f-lang.c (f_language_defn): Likewise.
8401         * go-lang.c (go_language_defn): Likewise.
8402         * language.c (unknown_language_defn): Likewise.
8403         (auto_language_defn): Likewise.
8404         * language.h (struct language_defn): Remove la_magic field.
8405         (LANG_MAGIC): Delete.
8406         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8407         * objc-lang.c (objc_language_defn): Likewise.
8408         * opencl-lang.c (opencl_language_defn): Likewise.
8409         * p-lang.c (pascal_language_defn): Likewise.
8410         * rust-lang.c (rust_language_defn): Likewise.
8411
8412 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8413
8414         * riscv-tdep.c (riscv_type_align): New function.
8415         (riscv_type_alignment): Delete.
8416         (riscv_arg_location): Use 'type_align'.
8417         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8418
8419 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8420
8421         * gdbtypes.c (type_align): A struct with no non-static fields also
8422         has alignment of 1.
8423
8424 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8425
8426         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8427         component to 0.
8428         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8429         member.
8430         (riscv_struct_info::analyse): New implementation using new
8431         analyse_inner member function.
8432         (riscv_struct_info::field_offset): New member function.
8433         (riscv_struct_info::m_offsets): New member variable.
8434         (riscv_struct_info::analyse_inner): New private member function,
8435         takes the old implementation of riscv_struct_info::analyse but
8436         extended to track field offsets.
8437         (riscv_call_arg_struct): Update the struct folding special cases
8438         to handle cases where empty C++ structs, which are non-zero
8439         length, are found.
8440         (riscv_arg_location): Initialise the length of each location, a
8441         non-zero length now indicates the location is in use.
8442         (riscv_push_dummy_call): Allow for the first location having a
8443         non-zero offset when setting up arguments.
8444         (riscv_return_value): Likewise, but for return values.
8445
8446 2019-04-11  Tom Tromey  <tromey@adacore.com>
8447
8448         * utils.c (internal_vproblem): Make "msg" const.
8449
8450 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8451
8452         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8453         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8454         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8455         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8456
8457 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8458
8459         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8460         function.
8461         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8462         of amd64_collect_native_gregset.
8463         (amd64_linux_nat_target::store_registers): Likewise.
8464
8465 2019-04-10  Tom Tromey  <tom@tromey.com>
8466
8467         * symtab.c (lookup_global_symbol_from_objfile)
8468         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8469         * objfiles.h (class separate_debug_iterator): New.
8470         (class separate_debug_range): New.
8471         (struct objfile) <separate_debug_objfiles>: New method.
8472         (objfile_separate_debug_iterate): Don't declare.
8473         * objfiles.c (separate_debug_iterator::operator++): Rename from
8474         objfile_separate_debug_iterate.
8475         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8476         iterator.
8477         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8478         iterator.
8479
8480 2019-04-10  Tom Tromey  <tom@tromey.com>
8481
8482         * symfile.c (reread_symbols): Remove old comment.
8483         * objfiles.c (free_all_objfiles): Fix a typo.
8484
8485 2019-04-10  Tom Tromey  <tom@tromey.com>
8486
8487         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8488         * minsyms.c (lookup_minimal_symbol): Use foreach.
8489         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8490         (lookup_minimal_symbol_solib_trampoline): Likewise.
8491         * symfile.c (reread_symbols): Use foreach.
8492
8493 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8494             Tom Tromey  <tromey@adacore.com>
8495
8496         PR rust/24414:
8497         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8498         (rust_lex_int_test): Change "value" to be LONGEST.
8499         (rust_lex_tests): Add test for long integer literal.
8500
8501 2019-04-09  Tom Tromey  <tromey@adacore.com>
8502
8503         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8504         to bool.
8505         (extended_remote_target::attach): Update.
8506         (remote_target::remote_notice_new_inferior): Update.
8507         (remote_target::add_current_inferior_and_thread): Update.
8508         * inferior.c (exit_inferior_1): Use "false".
8509         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8510
8511 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8512
8513         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8514         the "start" command.
8515
8516 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8517
8518         * python/py-inferior.c (infpy_thread_from_thread_handle):
8519         Adjust comments to reflect renaming of thread_from_thread_handle
8520         to thread_from_handle.  Adjust keywords.  Fix type error message.
8521         (inferior_object_methods): Add thread_from_handle.  Retain
8522         thread_from_thread_handle, but mark it as deprecated.
8523
8524 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8525
8526         * gdbthread.h (find_thread_by_handle): Revise declaration.
8527         * thread.c (find_thread_by_handle): Likewise.  Adjust
8528         implementation too.
8529         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8530         support for buffer objects as handles.
8531
8532 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8533
8534         * python/py-infthread.c (thpy_thread_handle): New function.
8535         (thread_object_methods): Register thpy_thread_handle.
8536
8537 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8538
8539         * gdbthread.h (thread_to_thread_handle): Declare.
8540         * thread.c (gdbtypes.h): Include.
8541         (thread_to_thread_handle): New function.
8542
8543         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8544         (target_thread_info_to_thread_handle): Declare.
8545         * target.c (target_thread_info_to_thread_handle): New function.
8546         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8547         * target-delegates.c: Regenerate.
8548
8549         * linux-thread-db.c (class thread_db_target): Add method
8550         thread_info_to_thread_handle.
8551         (thread_db_target::thread_info_to_thread_handle): Define.
8552         * remote.c (class remote_target): Add new method
8553         thread_info_to_thread_handle.
8554         (remote_target::thread_info_to_thread_handle): Define.
8555
8556 2019-04-08  Pedro Alves  <palves@redhat.com>
8557
8558         * common/common-exceptions.c (throw_exception): Don't create
8559         named object to throw; throw directly.
8560         (throw_it): Likewise.  Don't initialize gdb_exception::message
8561         here, with new; pass FMT and AP to the ctor instead.
8562         * common/common-exceptions.h: Include <string>.
8563         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8564         const char *, va_list)): New ctor.  Use std::make_shared.
8565         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8566         errors)): Delete.
8567         (gdb_exception_error::gdb_exception_error(enum errors, const char
8568         *, va_list)): New.
8569         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8570         Add assertion.
8571         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8572         errors)): Delete.
8573         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8574         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8575         Add assertion.
8576
8577 2019-04-08  Tom Tromey  <tom@tromey.com>
8578
8579         * valops.c (value_rtti_indirect_type): Replace throw_exception
8580         with throw.
8581         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8582         with throw.
8583         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8584         throw.
8585         * target.c (target_translate_tls_address): Replace throw_exception
8586         with throw.
8587         * stack.c (frame_apply_command_count): Replace throw_exception
8588         with throw.
8589         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8590         throw.
8591         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8592         with throw.
8593         * rs6000-tdep.c (rs6000_frame_cache)
8594         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8595         * remote.c: Replace throw_exception with throw.
8596         * record-full.c (record_full_message, record_full_wait_1)
8597         (record_full_restore): Replace throw_exception with throw.
8598         * record-btrace.c:
8599         (get_thread_current_frame_id, record_btrace_start_replaying)
8600         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8601         (cmd_record_btrace_start): Replace throw_exception with throw.
8602         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8603         throw.
8604         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8605         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8606         * linespec.c:
8607         (find_linespec_symbols): Replace throw_exception with throw.
8608         * infrun.c (displaced_step_prepare, resume): Replace
8609         throw_exception with throw.
8610         * infcmd.c (post_create_inferior): Replace throw_exception with
8611         throw.
8612         * inf-loop.c (inferior_event_handler): Replace throw_exception
8613         with throw.
8614         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8615         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8616         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8617         (get_prev_frame_always, get_frame_pc_if_available)
8618         (get_frame_address_in_block_if_available, get_frame_language):
8619         Replace throw_exception with throw.
8620         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8621         throw_exception with throw.
8622         * eval.c (fetch_subexp_value, evaluate_var_value)
8623         (evaluate_funcall, evaluate_subexp_standard): Replace
8624         throw_exception with throw.
8625         * dwarf2loc.c (call_site_find_chain)
8626         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8627         Replace throw_exception with throw.
8628         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8629         with throw.
8630         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8631         throw.
8632         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8633         * completer.c (complete_line_internal): Replace throw_exception
8634         with throw.
8635         * compile/compile-object-run.c (compile_object_run): Replace
8636         throw_exception with throw.
8637         * cli/cli-script.c (process_next_line): Replace throw_exception
8638         with throw.
8639         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8640         (btrace_enable, btrace_maint_update_pt_packets): Replace
8641         throw_exception with throw.
8642         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8643         throw_exception with throw.
8644         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8645         throw_exception with throw.
8646         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8647         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8648         * aarch64-tdep.c (aarch64_make_prologue_cache)
8649         (aarch64_make_stub_cache): Replace throw_exception with throw.
8650
8651 2019-04-08  Tom Tromey  <tom@tromey.com>
8652
8653         * common/common-exceptions.c (throw_exception): Rename from
8654         throw_exception_cxx.  Remove old copy.  Make argument const.
8655         (throw_it): Create and throw exception objects directly.
8656         * common/common-exceptions.h (throw_exception): Make argument
8657         const.
8658         (struct gdb_exception_error): Add constructor.
8659         (struct gdb_exception_quit): Add constructor.
8660
8661 2019-04-08  Tom Tromey  <tom@tromey.com>
8662
8663         * common/common-exceptions.h (exception_rethrow): Don't declare.
8664         (TRY_SJLJ): Update comment.
8665         (TRY, CATCH, END_CATCH): Remove.
8666         * common/common-exceptions.c (exception_rethrow): Remove.
8667
8668 2019-04-08  Tom Tromey  <tom@tromey.com>
8669
8670         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8671         Remove.
8672         (gdb_exception_error): Rename from
8673         gdb_exception_RETURN_MASK_ERROR.
8674         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8675         (gdb_quit_bad_alloc): Update.
8676         * aarch64-tdep.c: Update.
8677         * ada-lang.c: Update.
8678         * ada-typeprint.c: Update.
8679         * ada-valprint.c: Update.
8680         * amd64-tdep.c: Update.
8681         * arch-utils.c: Update.
8682         * break-catch-throw.c: Update.
8683         * breakpoint.c: Update.
8684         * btrace.c: Update.
8685         * c-varobj.c: Update.
8686         * cli/cli-cmds.c: Update.
8687         * cli/cli-interp.c: Update.
8688         * cli/cli-script.c: Update.
8689         * common/common-exceptions.c: Update.
8690         * common/new-op.c: Update.
8691         * common/selftest.c: Update.
8692         * compile/compile-c-symbols.c: Update.
8693         * compile/compile-cplus-symbols.c: Update.
8694         * compile/compile-object-load.c: Update.
8695         * compile/compile-object-run.c: Update.
8696         * completer.c: Update.
8697         * corelow.c: Update.
8698         * cp-abi.c: Update.
8699         * cp-support.c: Update.
8700         * cp-valprint.c: Update.
8701         * darwin-nat.c: Update.
8702         * disasm-selftests.c: Update.
8703         * dtrace-probe.c: Update.
8704         * dwarf-index-cache.c: Update.
8705         * dwarf-index-write.c: Update.
8706         * dwarf2-frame-tailcall.c: Update.
8707         * dwarf2-frame.c: Update.
8708         * dwarf2loc.c: Update.
8709         * dwarf2read.c: Update.
8710         * eval.c: Update.
8711         * event-loop.c: Update.
8712         * event-top.c: Update.
8713         * exec.c: Update.
8714         * f-valprint.c: Update.
8715         * fbsd-tdep.c: Update.
8716         * frame-unwind.c: Update.
8717         * frame.c: Update.
8718         * gdbtypes.c: Update.
8719         * gnu-v3-abi.c: Update.
8720         * guile/guile-internal.h: Update.
8721         * guile/scm-block.c: Update.
8722         * guile/scm-breakpoint.c: Update.
8723         * guile/scm-cmd.c: Update.
8724         * guile/scm-disasm.c: Update.
8725         * guile/scm-frame.c: Update.
8726         * guile/scm-lazy-string.c: Update.
8727         * guile/scm-math.c: Update.
8728         * guile/scm-param.c: Update.
8729         * guile/scm-ports.c: Update.
8730         * guile/scm-pretty-print.c: Update.
8731         * guile/scm-symbol.c: Update.
8732         * guile/scm-symtab.c: Update.
8733         * guile/scm-type.c: Update.
8734         * guile/scm-value.c: Update.
8735         * i386-linux-tdep.c: Update.
8736         * i386-tdep.c: Update.
8737         * inf-loop.c: Update.
8738         * infcall.c: Update.
8739         * infcmd.c: Update.
8740         * infrun.c: Update.
8741         * jit.c: Update.
8742         * language.c: Update.
8743         * linespec.c: Update.
8744         * linux-fork.c: Update.
8745         * linux-nat.c: Update.
8746         * linux-tdep.c: Update.
8747         * linux-thread-db.c: Update.
8748         * main.c: Update.
8749         * mi/mi-cmd-break.c: Update.
8750         * mi/mi-cmd-stack.c: Update.
8751         * mi/mi-interp.c: Update.
8752         * mi/mi-main.c: Update.
8753         * objc-lang.c: Update.
8754         * p-valprint.c: Update.
8755         * parse.c: Update.
8756         * ppc-linux-tdep.c: Update.
8757         * printcmd.c: Update.
8758         * python/py-arch.c: Update.
8759         * python/py-breakpoint.c: Update.
8760         * python/py-cmd.c: Update.
8761         * python/py-finishbreakpoint.c: Update.
8762         * python/py-frame.c: Update.
8763         * python/py-framefilter.c: Update.
8764         * python/py-gdb-readline.c: Update.
8765         * python/py-inferior.c: Update.
8766         * python/py-infthread.c: Update.
8767         * python/py-lazy-string.c: Update.
8768         * python/py-linetable.c: Update.
8769         * python/py-objfile.c: Update.
8770         * python/py-param.c: Update.
8771         * python/py-prettyprint.c: Update.
8772         * python/py-progspace.c: Update.
8773         * python/py-record-btrace.c: Update.
8774         * python/py-record.c: Update.
8775         * python/py-symbol.c: Update.
8776         * python/py-type.c: Update.
8777         * python/py-unwind.c: Update.
8778         * python/py-utils.c: Update.
8779         * python/py-value.c: Update.
8780         * python/python.c: Update.
8781         * record-btrace.c: Update.
8782         * record-full.c: Update.
8783         * remote-fileio.c: Update.
8784         * remote.c: Update.
8785         * riscv-tdep.c: Update.
8786         * rs6000-aix-tdep.c: Update.
8787         * rs6000-tdep.c: Update.
8788         * rust-exp.y: Update.
8789         * rust-lang.c: Update.
8790         * s390-tdep.c: Update.
8791         * selftest-arch.c: Update.
8792         * solib-dsbt.c: Update.
8793         * solib-frv.c: Update.
8794         * solib-spu.c: Update.
8795         * solib-svr4.c: Update.
8796         * solib.c: Update.
8797         * sparc64-linux-tdep.c: Update.
8798         * stack.c: Update.
8799         * symfile-mem.c: Update.
8800         * symmisc.c: Update.
8801         * target.c: Update.
8802         * thread.c: Update.
8803         * top.c: Update.
8804         * tracefile-tfile.c: Update.
8805         * tui/tui.c: Update.
8806         * typeprint.c: Update.
8807         * unittests/cli-utils-selftests.c: Update.
8808         * unittests/parse-connection-spec-selftests.c: Update.
8809         * valops.c: Update.
8810         * valprint.c: Update.
8811         * value.c: Update.
8812         * varobj.c: Update.
8813         * windows-nat.c: Update.
8814         * x86-linux-nat.c: Update.
8815         * xml-support.c: Update.
8816
8817 2019-04-08  Tom Tromey  <tom@tromey.com>
8818
8819         * xml-support.c: Use C++ exception handling.
8820         * x86-linux-nat.c: Use C++ exception handling.
8821         * windows-nat.c: Use C++ exception handling.
8822         * varobj.c: Use C++ exception handling.
8823         * value.c: Use C++ exception handling.
8824         * valprint.c: Use C++ exception handling.
8825         * valops.c: Use C++ exception handling.
8826         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8827         handling.
8828         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8829         * typeprint.c: Use C++ exception handling.
8830         * tui/tui.c: Use C++ exception handling.
8831         * tracefile-tfile.c: Use C++ exception handling.
8832         * top.c: Use C++ exception handling.
8833         * thread.c: Use C++ exception handling.
8834         * target.c: Use C++ exception handling.
8835         * symmisc.c: Use C++ exception handling.
8836         * symfile-mem.c: Use C++ exception handling.
8837         * stack.c: Use C++ exception handling.
8838         * sparc64-linux-tdep.c: Use C++ exception handling.
8839         * solib.c: Use C++ exception handling.
8840         * solib-svr4.c: Use C++ exception handling.
8841         * solib-spu.c: Use C++ exception handling.
8842         * solib-frv.c: Use C++ exception handling.
8843         * solib-dsbt.c: Use C++ exception handling.
8844         * selftest-arch.c: Use C++ exception handling.
8845         * s390-tdep.c: Use C++ exception handling.
8846         * rust-lang.c: Use C++ exception handling.
8847         * rust-exp.y: Use C++ exception handling.
8848         * rs6000-tdep.c: Use C++ exception handling.
8849         * rs6000-aix-tdep.c: Use C++ exception handling.
8850         * riscv-tdep.c: Use C++ exception handling.
8851         * remote.c: Use C++ exception handling.
8852         * remote-fileio.c: Use C++ exception handling.
8853         * record-full.c: Use C++ exception handling.
8854         * record-btrace.c: Use C++ exception handling.
8855         * python/python.c: Use C++ exception handling.
8856         * python/py-value.c: Use C++ exception handling.
8857         * python/py-utils.c: Use C++ exception handling.
8858         * python/py-unwind.c: Use C++ exception handling.
8859         * python/py-type.c: Use C++ exception handling.
8860         * python/py-symbol.c: Use C++ exception handling.
8861         * python/py-record.c: Use C++ exception handling.
8862         * python/py-record-btrace.c: Use C++ exception handling.
8863         * python/py-progspace.c: Use C++ exception handling.
8864         * python/py-prettyprint.c: Use C++ exception handling.
8865         * python/py-param.c: Use C++ exception handling.
8866         * python/py-objfile.c: Use C++ exception handling.
8867         * python/py-linetable.c: Use C++ exception handling.
8868         * python/py-lazy-string.c: Use C++ exception handling.
8869         * python/py-infthread.c: Use C++ exception handling.
8870         * python/py-inferior.c: Use C++ exception handling.
8871         * python/py-gdb-readline.c: Use C++ exception handling.
8872         * python/py-framefilter.c: Use C++ exception handling.
8873         * python/py-frame.c: Use C++ exception handling.
8874         * python/py-finishbreakpoint.c: Use C++ exception handling.
8875         * python/py-cmd.c: Use C++ exception handling.
8876         * python/py-breakpoint.c: Use C++ exception handling.
8877         * python/py-arch.c: Use C++ exception handling.
8878         * printcmd.c: Use C++ exception handling.
8879         * ppc-linux-tdep.c: Use C++ exception handling.
8880         * parse.c: Use C++ exception handling.
8881         * p-valprint.c: Use C++ exception handling.
8882         * objc-lang.c: Use C++ exception handling.
8883         * mi/mi-main.c: Use C++ exception handling.
8884         * mi/mi-interp.c: Use C++ exception handling.
8885         * mi/mi-cmd-stack.c: Use C++ exception handling.
8886         * mi/mi-cmd-break.c: Use C++ exception handling.
8887         * main.c: Use C++ exception handling.
8888         * linux-thread-db.c: Use C++ exception handling.
8889         * linux-tdep.c: Use C++ exception handling.
8890         * linux-nat.c: Use C++ exception handling.
8891         * linux-fork.c: Use C++ exception handling.
8892         * linespec.c: Use C++ exception handling.
8893         * language.c: Use C++ exception handling.
8894         * jit.c: Use C++ exception handling.
8895         * infrun.c: Use C++ exception handling.
8896         * infcmd.c: Use C++ exception handling.
8897         * infcall.c: Use C++ exception handling.
8898         * inf-loop.c: Use C++ exception handling.
8899         * i386-tdep.c: Use C++ exception handling.
8900         * i386-linux-tdep.c: Use C++ exception handling.
8901         * guile/scm-value.c: Use C++ exception handling.
8902         * guile/scm-type.c: Use C++ exception handling.
8903         * guile/scm-symtab.c: Use C++ exception handling.
8904         * guile/scm-symbol.c: Use C++ exception handling.
8905         * guile/scm-pretty-print.c: Use C++ exception handling.
8906         * guile/scm-ports.c: Use C++ exception handling.
8907         * guile/scm-param.c: Use C++ exception handling.
8908         * guile/scm-math.c: Use C++ exception handling.
8909         * guile/scm-lazy-string.c: Use C++ exception handling.
8910         * guile/scm-frame.c: Use C++ exception handling.
8911         * guile/scm-disasm.c: Use C++ exception handling.
8912         * guile/scm-cmd.c: Use C++ exception handling.
8913         * guile/scm-breakpoint.c: Use C++ exception handling.
8914         * guile/scm-block.c: Use C++ exception handling.
8915         * guile/guile-internal.h: Use C++ exception handling.
8916         * gnu-v3-abi.c: Use C++ exception handling.
8917         * gdbtypes.c: Use C++ exception handling.
8918         * frame.c: Use C++ exception handling.
8919         * frame-unwind.c: Use C++ exception handling.
8920         * fbsd-tdep.c: Use C++ exception handling.
8921         * f-valprint.c: Use C++ exception handling.
8922         * exec.c: Use C++ exception handling.
8923         * event-top.c: Use C++ exception handling.
8924         * event-loop.c: Use C++ exception handling.
8925         * eval.c: Use C++ exception handling.
8926         * dwarf2read.c: Use C++ exception handling.
8927         * dwarf2loc.c: Use C++ exception handling.
8928         * dwarf2-frame.c: Use C++ exception handling.
8929         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8930         * dwarf-index-write.c: Use C++ exception handling.
8931         * dwarf-index-cache.c: Use C++ exception handling.
8932         * dtrace-probe.c: Use C++ exception handling.
8933         * disasm-selftests.c: Use C++ exception handling.
8934         * darwin-nat.c: Use C++ exception handling.
8935         * cp-valprint.c: Use C++ exception handling.
8936         * cp-support.c: Use C++ exception handling.
8937         * cp-abi.c: Use C++ exception handling.
8938         * corelow.c: Use C++ exception handling.
8939         * completer.c: Use C++ exception handling.
8940         * compile/compile-object-run.c: Use C++ exception handling.
8941         * compile/compile-object-load.c: Use C++ exception handling.
8942         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8943         * compile/compile-c-symbols.c: Use C++ exception handling.
8944         * common/selftest.c: Use C++ exception handling.
8945         * common/new-op.c: Use C++ exception handling.
8946         * cli/cli-script.c: Use C++ exception handling.
8947         * cli/cli-interp.c: Use C++ exception handling.
8948         * cli/cli-cmds.c: Use C++ exception handling.
8949         * c-varobj.c: Use C++ exception handling.
8950         * btrace.c: Use C++ exception handling.
8951         * breakpoint.c: Use C++ exception handling.
8952         * break-catch-throw.c: Use C++ exception handling.
8953         * arch-utils.c: Use C++ exception handling.
8954         * amd64-tdep.c: Use C++ exception handling.
8955         * ada-valprint.c: Use C++ exception handling.
8956         * ada-typeprint.c: Use C++ exception handling.
8957         * ada-lang.c: Use C++ exception handling.
8958         * aarch64-tdep.c: Use C++ exception handling.
8959
8960 2019-04-08  Tom Tromey  <tom@tromey.com>
8961
8962         * xml-support.c (gdb_xml_parser::parse): Update.
8963         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8964         * value.c (show_convenience): Update.
8965         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8966         (test_parse_flags_qcs): Update.
8967         * thread.c (thr_try_catch_cmd): Update.
8968         * target.c (target_translate_tls_address): Update.
8969         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8970         (info_frame_command_core, frame_apply_command_count): Update.
8971         * rust-exp.y (rust_lex_exception_test): Update.
8972         * riscv-tdep.c (riscv_print_one_register_info): Update.
8973         * remote.c (remote_target::enable_btrace): Update.
8974         * record-btrace.c (record_btrace_enable_warn): Update.
8975         * python/py-utils.c (gdbpy_convert_exception): Update.
8976         * printcmd.c (do_one_display, print_variable_and_value): Update.
8977         * mi/mi-main.c (mi_print_exception): Update.
8978         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8979         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8980         * linux-nat.c (linux_nat_target::attach): Update.
8981         * linux-fork.c (class scoped_switch_fork_info): Update.
8982         * infrun.c (displaced_step_prepare): Update.
8983         * infcall.c (call_function_by_hand_dummy): Update.
8984         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8985         * gnu-v3-abi.c (print_one_vtable): Update.
8986         * frame.c (get_prev_frame_always): Update.
8987         * f-valprint.c (info_common_command_for_block): Update.
8988         * exec.c (try_open_exec_file): Update.
8989         * exceptions.c (print_exception, exception_print)
8990         (exception_fprintf, exception_print_same): Update.
8991         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8992         * dwarf-index-cache.c (index_cache::store)
8993         (index_cache::lookup_gdb_index): Update.
8994         * darwin-nat.c (maybe_cache_shell): Update.
8995         * cp-valprint.c (cp_print_value_fields): Update.
8996         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8997         (gcc_cplus_symbol_address): Update.
8998         * compile/compile-c-symbols.c (gcc_convert_symbol)
8999         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9000         * common/selftest.c: Update.
9001         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9002         a std::string.
9003         (exception_try_scope_entry, exception_try_scope_exit): Don't
9004         declare.
9005         (struct exception_try_scope): Remove.
9006         (TRY): Don't use exception_try_scope.
9007         (struct gdb_exception): Add constructor, operator=.
9008         <what>: New method.
9009         (struct gdb_exception_RETURN_MASK_ALL)
9010         (struct gdb_exception_RETURN_MASK_ERROR)
9011         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9012         (struct gdb_quit_bad_alloc): Update.
9013         * common/common-exceptions.c (exception_none): Change
9014         initializer.
9015         (struct catcher) <state, exception>: Initialize inline.
9016         <prev>: Remove member.
9017         (current_catcher): Remove.
9018         (catchers): New global.
9019         (exceptions_state_mc_init): Simplify.
9020         (catcher_pop): Remove.
9021         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9022         (try_scope_depth, exception_try_scope_entry)
9023         (exception_try_scope_exit): Remove.
9024         (throw_exception_sjlj): Update.
9025         (exception_messages, exception_messages_size): Remove.
9026         (throw_it): Simplify.
9027         (gdb_exception_sliced_copy): Remove.
9028         (throw_exception_cxx): Update.
9029         * cli/cli-script.c (script_from_file): Update.
9030         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9031         Update.
9032         * ada-valprint.c (ada_val_print): Update.
9033         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9034         (create_excep_cond_exprs): Update.
9035
9036 2019-04-08  Tom Tromey  <tom@tromey.com>
9037
9038         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9039         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9040         (TRY, CATCH, END_CATCH): Remove some definitions.
9041         * common/common-exceptions.c: Don't use GDB_XCPT.
9042         (catcher_list_size): Remove.
9043         (throw_exception, throw_it): Simplify.
9044
9045 2019-04-05  Tom Tromey  <tom@tromey.com>
9046
9047         Revert the header-sorting patch.
9048         * ft32-tdep.c: Revert.
9049         * frv-tdep.c: Revert.
9050         * frv-linux-tdep.c: Revert.
9051         * frame.c: Revert.
9052         * frame-unwind.c: Revert.
9053         * frame-base.c: Revert.
9054         * fork-child.c: Revert.
9055         * findvar.c: Revert.
9056         * findcmd.c: Revert.
9057         * filesystem.c: Revert.
9058         * filename-seen-cache.h: Revert.
9059         * filename-seen-cache.c: Revert.
9060         * fbsd-tdep.c: Revert.
9061         * fbsd-nat.h: Revert.
9062         * fbsd-nat.c: Revert.
9063         * f-valprint.c: Revert.
9064         * f-typeprint.c: Revert.
9065         * f-lang.c: Revert.
9066         * extension.h: Revert.
9067         * extension.c: Revert.
9068         * extension-priv.h: Revert.
9069         * expprint.c: Revert.
9070         * exec.h: Revert.
9071         * exec.c: Revert.
9072         * exceptions.c: Revert.
9073         * event-top.c: Revert.
9074         * event-loop.c: Revert.
9075         * eval.c: Revert.
9076         * elfread.c: Revert.
9077         * dwarf2read.h: Revert.
9078         * dwarf2read.c: Revert.
9079         * dwarf2loc.c: Revert.
9080         * dwarf2expr.h: Revert.
9081         * dwarf2expr.c: Revert.
9082         * dwarf2-frame.c: Revert.
9083         * dwarf2-frame-tailcall.c: Revert.
9084         * dwarf-index-write.h: Revert.
9085         * dwarf-index-write.c: Revert.
9086         * dwarf-index-common.c: Revert.
9087         * dwarf-index-cache.h: Revert.
9088         * dwarf-index-cache.c: Revert.
9089         * dummy-frame.c: Revert.
9090         * dtrace-probe.c: Revert.
9091         * disasm.h: Revert.
9092         * disasm.c: Revert.
9093         * disasm-selftests.c: Revert.
9094         * dictionary.c: Revert.
9095         * dicos-tdep.c: Revert.
9096         * demangle.c: Revert.
9097         * dcache.h: Revert.
9098         * dcache.c: Revert.
9099         * darwin-nat.h: Revert.
9100         * darwin-nat.c: Revert.
9101         * darwin-nat-info.c: Revert.
9102         * d-valprint.c: Revert.
9103         * d-namespace.c: Revert.
9104         * d-lang.c: Revert.
9105         * ctf.c: Revert.
9106         * csky-tdep.c: Revert.
9107         * csky-linux-tdep.c: Revert.
9108         * cris-tdep.c: Revert.
9109         * cris-linux-tdep.c: Revert.
9110         * cp-valprint.c: Revert.
9111         * cp-support.c: Revert.
9112         * cp-namespace.c: Revert.
9113         * cp-abi.c: Revert.
9114         * corelow.c: Revert.
9115         * corefile.c: Revert.
9116         * continuations.c: Revert.
9117         * completer.h: Revert.
9118         * completer.c: Revert.
9119         * complaints.c: Revert.
9120         * coffread.c: Revert.
9121         * coff-pe-read.c: Revert.
9122         * cli-out.h: Revert.
9123         * cli-out.c: Revert.
9124         * charset.c: Revert.
9125         * c-varobj.c: Revert.
9126         * c-valprint.c: Revert.
9127         * c-typeprint.c: Revert.
9128         * c-lang.c: Revert.
9129         * buildsym.c: Revert.
9130         * buildsym-legacy.c: Revert.
9131         * build-id.h: Revert.
9132         * build-id.c: Revert.
9133         * btrace.c: Revert.
9134         * bsd-uthread.c: Revert.
9135         * breakpoint.h: Revert.
9136         * breakpoint.c: Revert.
9137         * break-catch-throw.c: Revert.
9138         * break-catch-syscall.c: Revert.
9139         * break-catch-sig.c: Revert.
9140         * blockframe.c: Revert.
9141         * block.c: Revert.
9142         * bfin-tdep.c: Revert.
9143         * bfin-linux-tdep.c: Revert.
9144         * bfd-target.c: Revert.
9145         * bcache.c: Revert.
9146         * ax-general.c: Revert.
9147         * ax-gdb.h: Revert.
9148         * ax-gdb.c: Revert.
9149         * avr-tdep.c: Revert.
9150         * auxv.c: Revert.
9151         * auto-load.c: Revert.
9152         * arm-wince-tdep.c: Revert.
9153         * arm-tdep.c: Revert.
9154         * arm-symbian-tdep.c: Revert.
9155         * arm-pikeos-tdep.c: Revert.
9156         * arm-obsd-tdep.c: Revert.
9157         * arm-nbsd-tdep.c: Revert.
9158         * arm-nbsd-nat.c: Revert.
9159         * arm-linux-tdep.c: Revert.
9160         * arm-linux-nat.c: Revert.
9161         * arm-fbsd-tdep.c: Revert.
9162         * arm-fbsd-nat.c: Revert.
9163         * arm-bsd-tdep.c: Revert.
9164         * arch-utils.c: Revert.
9165         * arc-tdep.c: Revert.
9166         * arc-newlib-tdep.c: Revert.
9167         * annotate.h: Revert.
9168         * annotate.c: Revert.
9169         * amd64-windows-tdep.c: Revert.
9170         * amd64-windows-nat.c: Revert.
9171         * amd64-tdep.c: Revert.
9172         * amd64-sol2-tdep.c: Revert.
9173         * amd64-obsd-tdep.c: Revert.
9174         * amd64-obsd-nat.c: Revert.
9175         * amd64-nbsd-tdep.c: Revert.
9176         * amd64-nbsd-nat.c: Revert.
9177         * amd64-nat.c: Revert.
9178         * amd64-linux-tdep.c: Revert.
9179         * amd64-linux-nat.c: Revert.
9180         * amd64-fbsd-tdep.c: Revert.
9181         * amd64-fbsd-nat.c: Revert.
9182         * amd64-dicos-tdep.c: Revert.
9183         * amd64-darwin-tdep.c: Revert.
9184         * amd64-bsd-nat.c: Revert.
9185         * alpha-tdep.c: Revert.
9186         * alpha-obsd-tdep.c: Revert.
9187         * alpha-nbsd-tdep.c: Revert.
9188         * alpha-mdebug-tdep.c: Revert.
9189         * alpha-linux-tdep.c: Revert.
9190         * alpha-linux-nat.c: Revert.
9191         * alpha-bsd-tdep.c: Revert.
9192         * alpha-bsd-nat.c: Revert.
9193         * aix-thread.c: Revert.
9194         * agent.c: Revert.
9195         * addrmap.c: Revert.
9196         * ada-varobj.c: Revert.
9197         * ada-valprint.c: Revert.
9198         * ada-typeprint.c: Revert.
9199         * ada-tasks.c: Revert.
9200         * ada-lang.c: Revert.
9201         * aarch64-tdep.c: Revert.
9202         * aarch64-ravenscar-thread.c: Revert.
9203         * aarch64-newlib-tdep.c: Revert.
9204         * aarch64-linux-tdep.c: Revert.
9205         * aarch64-linux-nat.c: Revert.
9206         * aarch64-fbsd-tdep.c: Revert.
9207         * aarch64-fbsd-nat.c: Revert.
9208         * aarch32-linux-nat.c: Revert.
9209
9210 2019-04-05  Tom Tromey  <tom@tromey.com>
9211
9212         * ft32-tdep.c: Sort headers.
9213         * frv-tdep.c: Sort headers.
9214         * frv-linux-tdep.c: Sort headers.
9215         * frame.c: Sort headers.
9216         * frame-unwind.c: Sort headers.
9217         * frame-base.c: Sort headers.
9218         * fork-child.c: Sort headers.
9219         * findvar.c: Sort headers.
9220         * findcmd.c: Sort headers.
9221         * filesystem.c: Sort headers.
9222         * filename-seen-cache.h: Sort headers.
9223         * filename-seen-cache.c: Sort headers.
9224         * fbsd-tdep.c: Sort headers.
9225         * fbsd-nat.h: Sort headers.
9226         * fbsd-nat.c: Sort headers.
9227         * f-valprint.c: Sort headers.
9228         * f-typeprint.c: Sort headers.
9229         * f-lang.c: Sort headers.
9230         * extension.h: Sort headers.
9231         * extension.c: Sort headers.
9232         * extension-priv.h: Sort headers.
9233         * expprint.c: Sort headers.
9234         * exec.h: Sort headers.
9235         * exec.c: Sort headers.
9236         * exceptions.c: Sort headers.
9237         * event-top.c: Sort headers.
9238         * event-loop.c: Sort headers.
9239         * eval.c: Sort headers.
9240         * elfread.c: Sort headers.
9241         * dwarf2read.h: Sort headers.
9242         * dwarf2read.c: Sort headers.
9243         * dwarf2loc.c: Sort headers.
9244         * dwarf2expr.h: Sort headers.
9245         * dwarf2expr.c: Sort headers.
9246         * dwarf2-frame.c: Sort headers.
9247         * dwarf2-frame-tailcall.c: Sort headers.
9248         * dwarf-index-write.h: Sort headers.
9249         * dwarf-index-write.c: Sort headers.
9250         * dwarf-index-common.c: Sort headers.
9251         * dwarf-index-cache.h: Sort headers.
9252         * dwarf-index-cache.c: Sort headers.
9253         * dummy-frame.c: Sort headers.
9254         * dtrace-probe.c: Sort headers.
9255         * disasm.h: Sort headers.
9256         * disasm.c: Sort headers.
9257         * disasm-selftests.c: Sort headers.
9258         * dictionary.c: Sort headers.
9259         * dicos-tdep.c: Sort headers.
9260         * demangle.c: Sort headers.
9261         * dcache.h: Sort headers.
9262         * dcache.c: Sort headers.
9263         * darwin-nat.h: Sort headers.
9264         * darwin-nat.c: Sort headers.
9265         * darwin-nat-info.c: Sort headers.
9266         * d-valprint.c: Sort headers.
9267         * d-namespace.c: Sort headers.
9268         * d-lang.c: Sort headers.
9269         * ctf.c: Sort headers.
9270         * csky-tdep.c: Sort headers.
9271         * csky-linux-tdep.c: Sort headers.
9272         * cris-tdep.c: Sort headers.
9273         * cris-linux-tdep.c: Sort headers.
9274         * cp-valprint.c: Sort headers.
9275         * cp-support.c: Sort headers.
9276         * cp-namespace.c: Sort headers.
9277         * cp-abi.c: Sort headers.
9278         * corelow.c: Sort headers.
9279         * corefile.c: Sort headers.
9280         * continuations.c: Sort headers.
9281         * completer.h: Sort headers.
9282         * completer.c: Sort headers.
9283         * complaints.c: Sort headers.
9284         * coffread.c: Sort headers.
9285         * coff-pe-read.c: Sort headers.
9286         * cli-out.h: Sort headers.
9287         * cli-out.c: Sort headers.
9288         * charset.c: Sort headers.
9289         * c-varobj.c: Sort headers.
9290         * c-valprint.c: Sort headers.
9291         * c-typeprint.c: Sort headers.
9292         * c-lang.c: Sort headers.
9293         * buildsym.c: Sort headers.
9294         * buildsym-legacy.c: Sort headers.
9295         * build-id.h: Sort headers.
9296         * build-id.c: Sort headers.
9297         * btrace.c: Sort headers.
9298         * bsd-uthread.c: Sort headers.
9299         * breakpoint.h: Sort headers.
9300         * breakpoint.c: Sort headers.
9301         * break-catch-throw.c: Sort headers.
9302         * break-catch-syscall.c: Sort headers.
9303         * break-catch-sig.c: Sort headers.
9304         * blockframe.c: Sort headers.
9305         * block.c: Sort headers.
9306         * bfin-tdep.c: Sort headers.
9307         * bfin-linux-tdep.c: Sort headers.
9308         * bfd-target.c: Sort headers.
9309         * bcache.c: Sort headers.
9310         * ax-general.c: Sort headers.
9311         * ax-gdb.h: Sort headers.
9312         * ax-gdb.c: Sort headers.
9313         * avr-tdep.c: Sort headers.
9314         * auxv.c: Sort headers.
9315         * auto-load.c: Sort headers.
9316         * arm-wince-tdep.c: Sort headers.
9317         * arm-tdep.c: Sort headers.
9318         * arm-symbian-tdep.c: Sort headers.
9319         * arm-pikeos-tdep.c: Sort headers.
9320         * arm-obsd-tdep.c: Sort headers.
9321         * arm-nbsd-tdep.c: Sort headers.
9322         * arm-nbsd-nat.c: Sort headers.
9323         * arm-linux-tdep.c: Sort headers.
9324         * arm-linux-nat.c: Sort headers.
9325         * arm-fbsd-tdep.c: Sort headers.
9326         * arm-fbsd-nat.c: Sort headers.
9327         * arm-bsd-tdep.c: Sort headers.
9328         * arch-utils.c: Sort headers.
9329         * arc-tdep.c: Sort headers.
9330         * arc-newlib-tdep.c: Sort headers.
9331         * annotate.h: Sort headers.
9332         * annotate.c: Sort headers.
9333         * amd64-windows-tdep.c: Sort headers.
9334         * amd64-windows-nat.c: Sort headers.
9335         * amd64-tdep.c: Sort headers.
9336         * amd64-sol2-tdep.c: Sort headers.
9337         * amd64-obsd-tdep.c: Sort headers.
9338         * amd64-obsd-nat.c: Sort headers.
9339         * amd64-nbsd-tdep.c: Sort headers.
9340         * amd64-nbsd-nat.c: Sort headers.
9341         * amd64-nat.c: Sort headers.
9342         * amd64-linux-tdep.c: Sort headers.
9343         * amd64-linux-nat.c: Sort headers.
9344         * amd64-fbsd-tdep.c: Sort headers.
9345         * amd64-fbsd-nat.c: Sort headers.
9346         * amd64-dicos-tdep.c: Sort headers.
9347         * amd64-darwin-tdep.c: Sort headers.
9348         * amd64-bsd-nat.c: Sort headers.
9349         * alpha-tdep.c: Sort headers.
9350         * alpha-obsd-tdep.c: Sort headers.
9351         * alpha-nbsd-tdep.c: Sort headers.
9352         * alpha-mdebug-tdep.c: Sort headers.
9353         * alpha-linux-tdep.c: Sort headers.
9354         * alpha-linux-nat.c: Sort headers.
9355         * alpha-bsd-tdep.c: Sort headers.
9356         * alpha-bsd-nat.c: Sort headers.
9357         * aix-thread.c: Sort headers.
9358         * agent.c: Sort headers.
9359         * addrmap.c: Sort headers.
9360         * ada-varobj.c: Sort headers.
9361         * ada-valprint.c: Sort headers.
9362         * ada-typeprint.c: Sort headers.
9363         * ada-tasks.c: Sort headers.
9364         * ada-lang.c: Sort headers.
9365         * aarch64-tdep.c: Sort headers.
9366         * aarch64-ravenscar-thread.c: Sort headers.
9367         * aarch64-newlib-tdep.c: Sort headers.
9368         * aarch64-linux-tdep.c: Sort headers.
9369         * aarch64-linux-nat.c: Sort headers.
9370         * aarch64-fbsd-tdep.c: Sort headers.
9371         * aarch64-fbsd-nat.c: Sort headers.
9372         * aarch32-linux-nat.c: Sort headers.
9373
9374 2019-04-04  Tom Tromey  <tom@tromey.com>
9375
9376         * varobj.c (varobj_create): Update.
9377         * rust-exp.y (struct rust_parser) <update_innermost_block,
9378         lookup_symbol>: New methods.
9379         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9380         Rename.
9381         (rust_parser::rust_lookup_type)
9382         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9383         * printcmd.c (display_command, do_one_display): Update.
9384         * parser-defs.h (struct parser_state) <parser_state>: Add
9385         "tracker" parameter.
9386         (block_tracker): New member.
9387         (class innermost_block_tracker) <innermost_block_tracker>: Add
9388         "types" parameter.
9389         <reset>: Remove method.
9390         (innermost_block): Don't declare.
9391         (null_post_parser): Update.
9392         * parse.c (innermost_block): Remove global.
9393         (write_dollar_variable): Update.
9394         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9395         Remove "tracker_types" parameter.
9396         (parse_expression): Add "tracker" parameter.
9397         (parse_expression_for_completion): Update.
9398         (null_post_parser): Add "tracker" parameter.
9399         * p-exp.y: Update rules.
9400         * m2-exp.y: Update rules.
9401         * language.h (struct language_defn) <la_post_parser>: Add
9402         "tracker" parameter.
9403         * go-exp.y: Update rules.
9404         * f-exp.y: Update rules.
9405         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9406         parameter.
9407         * d-exp.y: Update rules.
9408         * c-exp.y: Update rules.
9409         * breakpoint.c (set_breakpoint_condition): Create an
9410         innermost_block_tracker.
9411         (watch_command_1): Likewise.
9412         * ada-lang.c (resolve): Add "tracker" parameter.
9413         (resolve_subexp): Likewise.
9414         * ada-exp.y (write_var_from_sym): Update.
9415
9416 2019-04-04  Tom Tromey  <tom@tromey.com>
9417
9418         * type-stack.h: New file.
9419         * type-stack.c: New file.
9420         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9421         type-stack.h.
9422         (insert_into_type_stack, insert_type, push_type, push_type_int)
9423         (insert_type_address_space, pop_type, pop_type_int)
9424         (pop_typelist, pop_type_stack, append_type_stack)
9425         (push_type_stack, get_type_stack, push_typelist)
9426         (follow_type_instance_flags, follow_types): Don't declare.
9427         * parse.c (type_stack): Remove global.
9428         (parse_exp_in_context): Update.
9429         (insert_into_type_stack, insert_type, push_type, push_type_int)
9430         (insert_type_address_space, pop_type, pop_type_int)
9431         (pop_typelist, pop_type_stack, append_type_stack)
9432         (push_type_stack, get_type_stack, push_typelist)
9433         (follow_type_instance_flags, follow_types): Remove (moved to
9434         type-stack.c).
9435         * f-exp.y (type_stack): New global.
9436         Update rules.
9437         (push_kind_type, f_parse): Update.
9438         * d-exp.y (type_stack): New global.
9439         Update rules.
9440         (d_parse): Update.
9441         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9442         Update rules.
9443         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9444         (HFILES_NO_SRCDIR): Add type-stack.h.
9445
9446 2019-04-04  Tom Tromey  <tom@tromey.com>
9447
9448         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9449         (rust_parser::convert_ast_to_expression, rust_parse)
9450         (rust_lex_test_completion, rust_lex_tests): Update.
9451         * parser-defs.h (struct expr_completion_state): New.
9452         (struct parser_state) <parser_state>: Add completion parameter.
9453         <mark_struct_expression, mark_completion_tag>: New methods.
9454         <parse_completion, m_completion_state>: New members.
9455         (prefixify_expression, null_post_parser): Update.
9456         (mark_struct_expression, mark_completion_tag): Don't declare.
9457         * parse.c (parse_completion, expout_last_struct)
9458         (expout_tag_completion_type, expout_completion_name): Remove
9459         globals.
9460         (parser_state::mark_struct_expression)
9461         (parser_state::mark_completion_tag): Now methods.
9462         (prefixify_expression): Add last_struct parameter.
9463         (prefixify_subexp): Likewise.
9464         (parse_exp_1): Update.
9465         (parse_exp_in_context): Add cstate parameter.  Update.
9466         (parse_expression_for_completion): Create an
9467         expr_completion_state.
9468         (null_post_parser): Add "completion" parameter.
9469         * p-exp.y: Update rules.
9470         (yylex): Update.
9471         * language.h (struct language_defn) <la_post_parser>: Add
9472         "completing" parameter.
9473         * go-exp.y: Update rules.
9474         (lex_one_token): Update.
9475         * expression.h (parse_completion): Don't declare.
9476         * d-exp.y: Update rules.
9477         (lex_one_token): Update rules.
9478         * c-exp.y: Update rules.
9479         (lex_one_token): Update.
9480         * ada-lang.c (resolve): Add "parse_completion" parameter.
9481         (resolve_subexp): Likewise.
9482         (ada_resolve_function): Likewise.
9483
9484 2019-04-04  Tom Tromey  <tom@tromey.com>
9485
9486         * parser-defs.h (struct parser_state) <start_arglist,
9487         end_arglist>: New methods.
9488         <arglist_len, m_funcall_chain>: New members.
9489         (arglist_len, start_arglist, end_arglist): Don't declare.
9490         * parse.c (arglist_len, funcall_chain): Remove global.
9491         (start_arglist, end_arglist): Remove functions.
9492         (parse_exp_in_context): Update.
9493         * p-exp.y: Update rules.
9494         * m2-exp.y: Update rules.
9495         * go-exp.y: Update rules.
9496         * f-exp.y: Update rules.
9497         * d-exp.y: Update rules.
9498         * c-exp.y: Update rules.
9499
9500 2019-04-04  Tom Tromey  <tom@tromey.com>
9501
9502         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9503         lex_operator, push_back>: New methods.
9504         Update all rules.
9505         (rust_parser::lex_hex, lex_escape): Rename and update.
9506         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9507         (rust_parser::lex_operator): Rename and update.
9508         (rust_parser::lex_number, rustyylex, rustyyerror)
9509         (rust_lex_test_init, rust_lex_test_sequence)
9510         (rust_lex_test_push_back, rust_lex_tests): Update.
9511         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9512         parameter.
9513         <lexptr, prev_lexptr>: New members.
9514         (lexptr, prev_lexptr): Don't declare.
9515         * parse.c (lexptr, prev_lexptr): Remove globals.
9516         (parse_exp_in_context): Update.
9517         * p-exp.y (yylex, yyerror): Update.
9518         * m2-exp.y (parse_number, yylex, yyerror): Update.
9519         * go-exp.y (lex_one_token, yyerror): Update.
9520         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9521         * d-exp.y (lex_one_token, yyerror): Update.
9522         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9523         (lex_one_token, yyerror): Update.
9524         * ada-lex.l (YY_INPUT): Update.
9525         (rewind_to_char): Update.
9526         * ada-exp.y (yyerror): Update.
9527
9528 2019-04-04  Tom Tromey  <tom@tromey.com>
9529
9530         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9531         * parser-defs.h (struct parser_state) <parser_state>: Add new
9532         parameter.
9533         <comma_terminates>: New member.
9534         (comma_terminates): Don't declare global.
9535         * parse.c (comma_terminates): Remove global.
9536         (parse_exp_in_context): Update.
9537         * p-exp.y (yylex): Update.
9538         * m2-exp.y (yylex): Update.
9539         * go-exp.y (lex_one_token): Update.
9540         * f-exp.y (yylex): Update.
9541         * d-exp.y (lex_one_token): Update.
9542         * c-exp.y (lex_one_token): Update.
9543         * ada-lex.l: Update.
9544
9545 2019-04-04  Tom Tromey  <tom@tromey.com>
9546
9547         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9548         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9549         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9550         * parser-defs.h (paren_depth): Don't declare.
9551         * parse.c (paren_depth): Remove global.
9552         (parse_exp_in_context): Update.
9553         * p-exp.y (paren_depth): New global.
9554         (pascal_parse): Initialize it.
9555         * m2-exp.y (paren_depth): New global.
9556         (m2_parse): Initialize it.
9557         * go-exp.y (paren_depth): New global.
9558         (go_parse): Initialize it.
9559         * f-exp.y (paren_depth): New global.
9560         (f_parse): Initialize it.
9561         * d-exp.y (paren_depth): New global.
9562         (d_parse): Initialize it.
9563         * c-exp.y (paren_depth): New global.
9564         (c_parse): Initialize it.
9565         * ada-lex.l (paren_depth): New global.
9566         (lexer_init): Initialize it.
9567
9568 2019-04-04  Tom Tromey  <tom@tromey.com>
9569
9570         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9571         (rust_parser::convert_ast_to_type)
9572         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9573         * parser-defs.h (struct parser_state) <parser_state>: Add
9574         parameters.  Initialize new members.
9575         <expression_context_block, expression_context_pc>: New members.
9576         * parse.c (expression_context_block, expression_context_pc):
9577         Remove globals.
9578         (parse_exp_in_context): Update.
9579         * p-exp.y: Update all rules.
9580         (yylex): Update.
9581         * m2-exp.y: Update all rules.
9582         (yylex): Update.
9583         * go-exp.y (yylex): Update.
9584         * f-exp.y (yylex): Update.
9585         * d-exp.y: Update all rules.
9586         (yylex): Update.
9587         * c-exp.y: Update all rules.
9588         (lex_one_token, classify_name, yylex, c_parse): Update.
9589         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9590
9591 2019-04-04  Tom Tromey  <tom@tromey.com>
9592
9593         * gdbarch.h, gdbarch.c: Rebuild.
9594         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9595         * stap-probe.h:
9596         (struct stap_parse_info): Replace "parser_state" with
9597         "expr_builder".
9598         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9599         (parser_state): New class.
9600         * parse.c (expr_builder): Rename.
9601         (expr_builder::release): Rename.
9602         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9603         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9604         (write_exp_elt_longcst, write_exp_elt_floatcst)
9605         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9606         (write_exp_string_vector, write_exp_bitstring)
9607         (write_exp_msymbol, mark_struct_expression)
9608         (write_dollar_variable)
9609         (insert_type_address_space, increase_expout_size): Replace
9610         "parser_state" with "expr_builder".
9611         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9612         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9613         "parser_state" with "expr_builder".
9614
9615 2019-04-04  Tom Tromey  <tom@tromey.com>
9616
9617         * rust-exp.y: Replace "parse_language" with method call.
9618         * p-exp.y:
9619         (yylex): Replace "parse_language" with method call.
9620         * m2-exp.y:
9621         (yylex): Replace "parse_language" with method call.
9622         * go-exp.y (classify_name): Replace "parse_language" with method
9623         call.
9624         * f-exp.y (yylex): Replace "parse_language" with method call.
9625         * d-exp.y (lex_one_token): Replace "parse_language" with method
9626         call.
9627         * c-exp.y:
9628         (lex_one_token, classify_name, yylex): Replace "parse_language"
9629         with method call.
9630         * ada-exp.y (find_primitive_type, type_char)
9631         (type_system_address): Replace "parse_language" with method call.
9632
9633 2019-04-04  Tom Tromey  <tom@tromey.com>
9634
9635         * rust-exp.y: Replace "parse_gdbarch" with method call.
9636         * parse.c (write_dollar_variable, insert_type_address_space):
9637         Replace "parse_gdbarch" with method call.
9638         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9639         call.
9640         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9641         call.
9642         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9643         "parse_gdbarch" with method call.
9644         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9645         with method call.
9646         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9647         "parse_gdbarch" with method call.
9648         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9649         "parse_gdbarch" with method call.
9650         * c-exp.y (parse_type, parse_number, classify_name): Replace
9651         "parse_gdbarch" with method call.
9652         * ada-lex.l: Replace "parse_gdbarch" with method call.
9653         * ada-exp.y (parse_type, find_primitive_type, type_char)
9654         (type_system_address): Replace "parse_gdbarch" with method call.
9655
9656 2019-04-04  Tom Tromey  <tom@tromey.com>
9657
9658         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9659         * stap-probe.c (stap_parse_argument): Update.
9660         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9661         initial_size parameter.
9662         * rust-exp.y (rust_lex_tests): Update.
9663         * parse.c (parser_state): Update.
9664         (parse_exp_in_context): Update.
9665         * parser-defs.h (struct parser_state) <parser_state>: Remove
9666         "initial_size" parameter.
9667
9668 2019-04-04  Tom Tromey  <tom@tromey.com>
9669
9670         * parser-defs.h (increase_expout_size): Don't declare.
9671         * parse.c (increase_expout_size): Now static.
9672
9673 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9674
9675         * gnu-nat.c (gnu_nat_target::wait): Fix
9676         target_waitstatus_to_string call.
9677
9678 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9679
9680         * eval.c (evaluate_subexp_standard): Handle internal functions
9681         during Fortran function call handling.
9682
9683 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9684
9685         * NEWS: Mention new internal functions.
9686         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9687         (read_base_type): Use dwarf2_init_complex_target_type.
9688         * value.c (creal_internal_fn): New function.
9689         (cimag_internal_fn): New function.
9690         (_initialize_values): Register new internal functions.
9691
9692 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9693
9694         * infrun.c (stop_all_threads): If debug_infrun, always
9695         trace the wait status after wait_one, using
9696         target_waitstatus_to_string and target_pid_to_str.
9697         (handle_inferior_event): Replace various trace of
9698         wait status kind by a single trace.
9699         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9700         wait status kind image by target_waitstatus_to_string.
9701         * target/waitstatus.c (target_waitstatus_to_string): Fix
9702         obsolete comment.
9703
9704 2019-04-01  Tom Tromey  <tromey@adacore.com>
9705
9706         PR symtab/23331:
9707         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9708
9709 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9710             Pedro Alves  <palves@redhat.com>
9711
9712         * top.c (quit_force): Call 'finalize_values'.
9713         * value.c (finalize_values): New function.
9714         * value.h (finalize_values): Declare.
9715
9716 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9717
9718         * NEWS: Announce $_gdb_major and $_gdb_minor.
9719
9720         * top.c (init_gdb_version_vars): New function.
9721         (gdb_init): Call init_gdb_version_vars.
9722
9723 2019-03-29  Tom Tromey  <tromey@adacore.com>
9724
9725         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9726         help text.  Remove dead code.
9727
9728 2019-03-29  Keith Seitz  <keiths@redhat.com>
9729
9730         From Siddhesh Poyarekar:
9731         * f-lang.h (f77_get_upperbound): Return LONGEST.
9732         (f77_get_lowerbound): Likewise.
9733         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9734         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9735         print them.
9736         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9737         plongest to format print it.
9738         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9739         (f77_get_upperbound): Likewise.
9740         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9741         LOWER_BOUND to LONGEST.
9742         (f77_create_arrayprint_offset_tbl): Likewise.
9743
9744 2019-03-29  Keith Seitz  <keiths@redhat.com>
9745
9746         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9747         %s/pulongest for TYPE_LENGTH instead of %d in format
9748         strings.
9749         * ada-typerint.c (ada_print_type): Likewise.
9750         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9751         * compile/compile-c-support.c (generate_register_struct): Likewise.
9752         * gdbtypes.c (recursive_dump_type): Likewise.
9753         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9754         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9755         instead of %d in format strings.
9756         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9757         to std::min to ULONGEST.
9758         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9759         instead of %d in format strings.
9760         * tracepoint.c (info_scope_command): Likewise.
9761         * typeprint.c (print_offset_data::update)
9762         (print_offset_data::finish): Likewise.
9763         * xtensa-tdep.c (xtensa_store_return_value)
9764         (xtensa_push_dummy_call): Likewise.
9765
9766 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9767
9768         * windows-nat.c (display_selector): Fixed format specifications
9769         for 64-bit Cygwin.
9770
9771 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9772
9773         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9774
9775 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9776
9777         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9778         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9779         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9780         (nios2_linux_init_abi): Install it.
9781
9782 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9783
9784         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9785
9786 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9787
9788         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9789
9790 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9791             Tom Tromey  <tromey@adacore.com>
9792
9793         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9794
9795 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9796
9797         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9798         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9799         method to compute the bounds of range types. Also print "[evaluated]"
9800         if the bounds' values come from a dynamic evaluation.
9801
9802 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9803
9804         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9805         whitespace when pretty printing is on.
9806
9807 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9808
9809         * ppc-linux-nat.c: Add include.
9810
9811 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9812
9813         * NEWS: Mention AArch64 Pointer Authentication.
9814
9815 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9816
9817         * arm-linux-nat.c: Add include.
9818
9819 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9820
9821         * source-cache.c (source_cache::get_source_lines): Re-read
9822         fullname after calling open_source_file.
9823
9824 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9825
9826         * NEWS: Mention TLS support for FreeBSD.
9827
9828 2019-03-25  Tom Tromey  <tromey@adacore.com>
9829
9830         * minsyms.c (BUNCH_SIZE): Update comment.
9831         (~minimal_symbol_reader): Remove old comment.
9832         (compact_minimal_symbols): Update comment.
9833         (minimal_symbol_reader::install): Remove old comment.  Update
9834         other comments.
9835
9836 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9837
9838         * s390-linux-nat.c: Add include.
9839
9840 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9841
9842         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9843         Call linux_get_hwcap.
9844         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9845         Likewise.
9846         (aarch64_linux_get_hwcap): Remove function.
9847         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9848         declaration.
9849         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9850         linux_get_hwcap.
9851         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9852         * linux-tdep.c (linux_get_hwcap): Add function.
9853         (linux_get_hwcap2): Likewise.
9854         * linux-tdep.h (linux_get_hwcap): Add declaration.
9855         (linux_get_hwcap2): Likewise.
9856         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9857         (ppc_linux_get_hwcap2): Likewise.
9858         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9859         linux_get_hwcap.
9860         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9861         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9862         (ppc_linux_nat_target::read_description): Likewise.
9863         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9864         * s390-linux-nat.c: Likewise.
9865         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9866
9867 2019-03-24  Tom Tromey  <tom@tromey.com>
9868
9869         * ada-lang.c (standard_lookup): Simplify initialization.
9870         (ada_lookup_symbol_nonlocal): Simplify return.
9871         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9872         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9873         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9874         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9875         initialization.
9876         * solib.c (solib_global_lookup): Simplify.
9877         * symtab.c (null_block_symbol): Remove.
9878         (symbol_cache_lookup): Simplify returns.
9879         (lookup_language_this): Simplify returns.
9880         (lookup_symbol_aux): Simplify return.
9881         (lookup_local_symbol): Simplify returns.
9882         (lookup_global_symbol_from_objfile): Simplify return.
9883         (lookup_symbol_in_objfile_symtabs)
9884         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9885         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9886         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9887         * cp-namespace.c (cp_lookup_bare_symbol)
9888         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9889         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9890         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9891         (cp_lookup_symbol_via_imports): Simplify initialization.
9892         (find_symbol_in_baseclass): Likewise.
9893         * symtab.h (null_block_symbol): Remove.
9894         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9895         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9896         (d_lookup_symbol_module): Likewise.
9897         (find_symbol_in_baseclass): Simplify initialization.
9898
9899 2019-03-24  Tom Tromey  <tom@tromey.com>
9900
9901         * expression.h: Don't include symtab.h.
9902         (struct block): Forward declare.
9903
9904 2019-03-24  Tom Tromey  <tom@tromey.com>
9905
9906         * c-exp.y (typebase): Remove casts.
9907         * gdbtypes.c (lookup_unsigned_typename, )
9908         (lookup_signed_typename): Remove cast.
9909         * eval.c (parse_to_comma_and_eval): Remove cast.
9910         * parse.c (write_dollar_variable): Remove cast.
9911         * block.h (struct block) <superblock>: Now const.
9912         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9913         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9914         (map_block): Make "block" const.
9915         * symfile.h (struct quick_symbol_functions)
9916         <map_matching_symbols>: Constify block argument to "callback".
9917         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9918         const.
9919         (find_pc_sect_compunit_symtab): Make "b" const.
9920         (find_symbol_at_address): Likewise.
9921         (search_symbols): Likewise.
9922         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9923         (dw2_debug_names_lookup_symbol): Likewise.
9924         (dw2_map_matching_symbols): Update.
9925         * p-valprint.c (pascal_val_print): Remove "block".
9926         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9927         (aux_add_nonlocal_symbols): Make "block" const.
9928         (resolve_subexp): Remove cast.
9929         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9930         const.
9931         (iterate_over_file_blocks): Likewise.
9932         * f-exp.y (%union) <bval>: Remove.
9933         * coffread.c (patch_opaque_types): Make "b" const.
9934         * spu-tdep.c (spu_catch_start): Make "block" const.
9935         * c-valprint.c (print_unpacked_pointer): Remove "block".
9936         * symmisc.c (dump_symtab_1): Make "b" const.
9937         (block_depth): Make "block" const.
9938         * d-exp.y (%union) <bval>: Remove.
9939         * cp-support.h (cp_lookup_rtti_type): Update.
9940         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9941         * psymtab.c (psym_lookup_symbol): Make "block" const.
9942         (maintenance_check_psymtabs): Make "b" const.
9943         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9944         (enumerate_locals, enumerate_args): Update.
9945         * python/py-symtab.c (stpy_global_block): Make "block" const.
9946         (stpy_static_block): Likewise.
9947         * inline-frame.c (block_starting_point_at): Make "new_block"
9948         const.
9949         * block.c (find_block_in_blockvector): Make return type const.
9950         (blockvector_for_pc_sect): Make "b" const.
9951         (find_block_in_blockvector): Make "b" const.
9952
9953 2019-03-23  Tom Tromey  <tom@tromey.com>
9954
9955         * varobj.c (varobj_create): Update.
9956         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9957         * printcmd.c (display_command, do_one_display): Don't reset
9958         innermost_block.
9959         * parser-defs.h (enum innermost_block_tracker_type): Move to
9960         expression.h.
9961         (innermost_block): Update comment.
9962         * parse.c (parse_exp_1): Add tracker_types parameter.
9963         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9964         tracker_types parameter.  Reset innermost_block.
9965         (parse_exp_in_context): Remove.
9966         (parse_expression_for_completion): Update.
9967         * objfiles.c (~objfile): Don't reset expression_context_block or
9968         innermost_block.
9969         * expression.h (enum innermost_block_tracker_type): Move from
9970         parser-defs.h.
9971         (parse_exp_1): Add tracker_types parameter.
9972         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9973         reset innermost_block.
9974
9975 2019-03-23  Tom Tromey  <tom@tromey.com>
9976
9977         * objfiles.h: Include bcache.h.
9978
9979 2019-03-23  Tom Tromey  <tom@tromey.com>
9980
9981         * linespec.c (get_current_search_block): Use
9982         scoped_restore_current_language.
9983         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9984
9985 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9986             Jiong Wang  <jiong.wang@arm.com>
9987
9988         * aarch64-linux-tdep.c
9989         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9990         section.
9991         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9992
9993 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9994             Jiong Wang  <jiong.wang@arm.com>
9995
9996         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9997         instructions.
9998         (aarch64_analyze_prologue_test): Add PACIASP test.
9999         (aarch64_prologue_prev_register): Unmask PC value.
10000
10001 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10002             Jiong Wang  <jiong.wang@arm.com>
10003
10004         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10005         (aarch64_dwarf2_prev_register): Unmask PC value.
10006         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10007         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10008         DW_CFA_AARCH64_negate_ra_state.
10009         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10010
10011 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10012             Jiong Wang  <jiong.wang@arm.com>
10013
10014         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10015         registers.
10016         (aarch64_pseudo_register_name): Likewise.
10017         (aarch64_pseudo_register_type): Likewise.
10018         (aarch64_pseudo_register_reggroup_p): Likewise.
10019         (aarch64_gdbarch_init): Add pauth registers.
10020         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10021         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10022         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10023         (struct gdbarch_tdep): Add regnum for ra_state.
10024
10025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10026             Jiong Wang  <jiong.wang@arm.com>
10027
10028         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10029
10030 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10031             Jiong Wang  <jiong.wang@arm.com>
10032
10033         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10034         function.
10035         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10036         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10037         (aarch64_gdbarch_init): Add puth registers.
10038         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10039         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10040         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10041
10042 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10043             Jiong Wang  <jiong.wang@arm.com>
10044
10045         * aarch64-linux-nat.c
10046         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10047         * aarch64-linux-tdep.c
10048         (aarch64_linux_core_read_description): Likewise.
10049         (aarch64_linux_get_hwcap): New function.
10050         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10051         (aarch64_linux_get_hwcap): New declaration.
10052
10053 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10054             Jiong Wang  <jiong.wang@arm.com>
10055
10056         * aarch64-linux-nat.c
10057         (aarch64_linux_nat_target::read_description): Add pauth param.
10058         * aarch64-linux-tdep.c
10059         (aarch64_linux_core_read_description): Likewise.
10060         * aarch64-tdep.c (struct target_desc): Add in pauth.
10061         (aarch64_read_description): Add pauth param.
10062         (aarch64_gdbarch_init): Likewise.
10063         * aarch64-tdep.h (aarch64_read_description): Likewise.
10064         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10065         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10066         * features/Makefile: Add new files.
10067         * features/aarch64-pauth.c: New file.
10068         * features/aarch64-pauth.xml: New file.
10069
10070 2019-03-20  Tom Tromey  <tromey@adacore.com>
10071
10072         * infrun.c (handle_inferior_event): Rename from
10073         handle_inferior_event_1.  Create a scoped_value_mark.
10074         (handle_inferior_event): Remove.
10075
10076 2019-03-19  Tom Tromey  <tromey@adacore.com>
10077
10078         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10079         * infrun.h (print_stop_event): Add "displays" parameter.
10080         * infrun.c (print_stop_event): Add "displays" parameter.
10081
10082 2019-03-19  Pedro Alves  <palves@redhat.com>
10083
10084         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10085         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10086         to -1.  Fix TABs vs spaces.
10087         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10088         * tui/tui-out.h (tui_ui_out) Add intro comments.
10089         <m_line, m_start_of_line>: In-class initialize, and add describing
10090         comment.
10091
10092 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10093
10094         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10095         variable names.
10096         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10097
10098 2019-03-18  Pedro Alves  <palves@redhat.com>
10099             Eli Zaretskii <eliz@gnu.org>
10100
10101         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10102         m_line and m_start_of_line.
10103
10104 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10105
10106         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10107         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10108         it returns a newline.  This fixes a regression in TU mode, whereby
10109         the next line is output on the same screen line as the user input.
10110
10111 2019-03-18  Tom Tromey  <tromey@adacore.com>
10112
10113         * minsyms.c (minimal_symbol_reader::install): Remove call to
10114         obstack_blank.
10115
10116 2019-03-18  Pedro Alves  <palves@redhat.com>
10117
10118         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10119         New globals.
10120         (apply_style): New, factored out from ...
10121         (apply_ansi_escape): ... this.  Handle reverse video mode.
10122         (tui_set_reverse_mode): New function.
10123         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10124         * tui/tui-winsource.c (tui_show_source_line): Use
10125         tui_set_reverse_mode instead of setting A_STANDOUT.
10126         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10127         New setter methods.
10128
10129 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10130
10131         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10132         Handle tabs.
10133
10134 2019-03-18  Tom Tromey  <tromey@adacore.com>
10135
10136         * ada-lang.c (empty_array): Add "high" parameter.
10137         (ada_evaluate_subexp): Update.
10138
10139 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10140
10141         * unittests/string_view-selftests.c: Define
10142         _initialize_string_view_selftests unconditionally.
10143
10144 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10145
10146         PR gdb/24350
10147         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10148
10149 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10150
10151         PR gdb/24351
10152         * windows-nat.c (display_selector): Fix format specifiers.
10153
10154 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10155
10156         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10157         tui_refill_source_window instead of tui_refresh_win, to update the
10158         current execution line.  This fixes redisplay of the current line
10159         when stepping through the code with "next" or "step".
10160
10161 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10162
10163         * source-cache.c (source_cache::get_source_lines): Call
10164         find_source_lines to initialize s->nlines.  This fixes vertical
10165         scrolling of TUI source window when the DOWN arrow is pressed.
10166
10167 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10168
10169         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10170         linux-thread-db.c (_initialize_thread_db): Likewise.
10171
10172 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10173
10174         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10175         wclrtoeol in tui_show_source_line".  This reverts changes made in
10176         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10177
10178 2019-03-15  Tom Tromey  <tom@tromey.com>
10179
10180         * symtab.h (struct minimal_symbol): Derive from
10181         general_symbol_info.
10182         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10183         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10184         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10185         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10186         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10187         (MSYMBOL_SEARCH_NAME): Update.
10188         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10189         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10190         * minsyms.c (minimal_symbol_reader::record_full): Update.
10191
10192 2019-03-15  Tom Tromey  <tom@tromey.com>
10193
10194         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10195
10196 2019-03-15  Tom Tromey  <tom@tromey.com>
10197
10198         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10199         unique_xmalloc_ptr.
10200         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10201         Update.
10202         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10203         (build_minimal_symbol_hash_tables)
10204         (minimal_symbol_reader::install): Update.
10205
10206 2019-03-15  Tom Tromey  <tom@tromey.com>
10207
10208         * symtab.c (create_demangled_names_hash): Update.
10209         (symbol_set_names): Update.
10210         * objfiles.h (struct objfile_per_bfd_storage)
10211         <demangled_names_hash>: Now an htab_up.
10212         * objfiles.c (objfile_per_bfd_storage): Simplify.
10213
10214 2019-03-15  Tom Tromey  <tom@tromey.com>
10215
10216         * objfiles.h (struct objfile_per_bfd_storage): Declare
10217         destructor.
10218         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10219         New.
10220         (get_objfile_bfd_data): Use new.  Don't initialize
10221         language_of_main.
10222         (free_objfile_per_bfd_storage): Remove.
10223         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10224
10225 2019-03-15  Tom Tromey  <tom@tromey.com>
10226
10227         * symfile.c (reread_symbols): Update.
10228         * objfiles.c (objfile::objfile): Update.
10229         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10230         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10231         comment.
10232         (minimal_symbol_reader::install): Update.
10233         (terminate_minimal_symbol_table): Remove.
10234         * jit.c (jit_object_close_impl): Update.
10235
10236 2019-03-15  Tom Tromey  <tom@tromey.com>
10237
10238         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10239         initializations.
10240
10241 2019-03-15  Tom Tromey  <tom@tromey.com>
10242
10243         * objfiles.h (struct objfile_per_bfd_storage)
10244         <demangled_hash_languages>: Now a bitset.
10245         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10246         (lookup_minimal_symbol): Update.
10247
10248 2019-03-15  Tom Tromey  <tom@tromey.com>
10249
10250         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10251         Don't return the symbol.
10252         * coffread.c (record_minimal_symbol): Use record_full.
10253
10254 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10255
10256         The MS-Windows port of ncurses fails to switch to a color pair if
10257         one or both of the colors are the implicit default colors.  This
10258         change records the default colors when TUI is initialized, and
10259         then specifies them explicitly when a color pair uses the default
10260         colors.  This allows color styling in TUI mode on MS-Windows.
10261
10262         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10263         ncurses_norm_attr.
10264         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10265         colors in ncurses_norm_attr.
10266         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10267         "none", replace it with the default color recorded in
10268         ncurses_norm_attr.
10269
10270 2019-03-14  Tom Tromey  <tromey@adacore.com>
10271
10272         * source-cache.h (class source_cache) <get_source_lines>: Return
10273         std::string.
10274         * source-cache.c (source_cache::extract_lines): Handle case where
10275         first_pos==npos.  Return std::string.
10276         (source_cache::get_source_lines): Update.
10277
10278 2019-03-14  Tom Tromey  <tromey@adacore.com>
10279
10280         * NEWS: Add item for "style sources" commands.
10281         * source-cache.c (source_cache::get_source_lines): Check
10282         source_styling.
10283         * cli/cli-style.c (source_styling): New global.
10284         (_initialize_cli_style): Add "style sources" commands.
10285         (show_style_sources): New function.
10286         * cli/cli-style.h (source_styling): Declare.
10287
10288 2019-03-14  Pedro Alves  <palves@redhat.com>
10289             Tom Tromey  <tromey@adacore.com>
10290
10291         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10292         * tui/tui-winsource.c (tui_refill_source_window): New function,
10293         from...
10294         (tui_horizontal_source_scroll): ... here.  Move some logic.
10295         * cli/cli-style.c (set_style_enabled): Notify new observable.
10296         * tui/tui-hooks.c (tui_redisplay_source): New function.
10297         (tui_attach_detach_observers): Attach or detach
10298         tui_redisplay_source.
10299         * observable.h (source_styling_changed): New observable.
10300         * observable.c: Define source_styling_changed observable.
10301
10302 2019-03-13  Tom Tromey  <tromey@adacore.com>
10303
10304         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10305         (i386_gnu_nat_target::store_registers): Update.
10306         * target-debug.h (target_debug_print_std_string): New macro.
10307         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10308         * windows-tdep.c (display_one_tib): Update.
10309         * tui/tui-stack.c (tui_make_status_line): Update.
10310         * top.c (print_inferior_quit_action): Update.
10311         * thread.c (thr_try_catch_cmd): Update.
10312         (add_thread_with_info): Update.
10313         (thread_target_id_str): Update.
10314         (thr_try_catch_cmd): Update.
10315         (thread_command): Update.
10316         (thread_find_command): Update.
10317         * record-btrace.c (record_btrace_target::info_record)
10318         (record_btrace_resume_thread, record_btrace_target::resume)
10319         (record_btrace_cancel_resume, record_btrace_step_thread)
10320         (record_btrace_target::wait, record_btrace_target::wait)
10321         (record_btrace_target::wait, record_btrace_target::stop): Update.
10322         * progspace.c (print_program_space): Update.
10323         * process-stratum-target.c
10324         (process_stratum_target::thread_address_space): Update.
10325         * linux-fork.c (linux_fork_mourn_inferior)
10326         (detach_checkpoint_command, info_checkpoints_command)
10327         (linux_fork_context): Update.
10328         (linux_fork_detach): Update.
10329         (class scoped_switch_fork_info): Update.
10330         (delete_checkpoint_command): Update.
10331         * infrun.c (follow_fork_inferior): Update.
10332         (follow_fork_inferior): Update.
10333         (proceed_after_vfork_done): Update.
10334         (handle_vfork_child_exec_or_exit): Update.
10335         (follow_exec): Update.
10336         (displaced_step_prepare_throw): Update.
10337         (displaced_step_restore): Update.
10338         (start_step_over): Update.
10339         (resume_1): Update.
10340         (clear_proceed_status_thread): Update.
10341         (proceed): Update.
10342         (print_target_wait_results): Update.
10343         (do_target_wait): Update.
10344         (context_switch): Update.
10345         (stop_all_threads): Update.
10346         (restart_threads): Update.
10347         (finish_step_over): Update.
10348         (handle_signal_stop): Update.
10349         (switch_back_to_stepped_thread): Update.
10350         (keep_going_pass_signal): Update.
10351         (print_exited_reason): Update.
10352         (normal_stop): Update.
10353         * inferior.c (inferior_pid_to_str): Change return type.
10354         (print_selected_inferior): Update.
10355         (add_inferior): Update.
10356         (detach_inferior): Update.
10357         * dummy-frame.c (fprint_dummy_frames): Update.
10358         * dcache.c (dcache_info_1): Update.
10359         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10360         (btrace_fetch, btrace_clear): Update.
10361         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10362         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10363         type.
10364         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10365         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10366         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10367         * gdbarch.c, gdbarch.h: Rebuild.
10368         * gdbarch.sh (core_pid_to_str): Change return type.
10369         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10370         return type.
10371         (windows_nat_target::pid_to_str): Change return type.
10372         (windows_delete_thread): Update.
10373         (windows_nat_target::attach): Update.
10374         (windows_nat_target::files_info): Update.
10375         * target-delegates.c: Rebuild.
10376         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10377         return type.
10378         (sol_thread_target::pid_to_str): Change return type.
10379         * remote.c (class remote_target) <pid_to_str>: Change return
10380         type.
10381         (remote_target::pid_to_str): Change return type.
10382         (extended_remote_target::attach, remote_target::remote_stop_ns)
10383         (remote_target::remote_notif_remove_queued_reply)
10384         (remote_target::push_stop_reply, remote_target::disable_btrace):
10385         Update.
10386         (extended_remote_target::attach): Update.
10387         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10388         type.
10389         (gdbsim_target::pid_to_str): Change return type.
10390         * ravenscar-thread.c (struct ravenscar_thread_target)
10391         <pid_to_str>: Change return type.
10392         (ravenscar_thread_target::pid_to_str): Change return type.
10393         * procfs.c (class procfs_target) <pid_to_str>: Change return
10394         type.
10395         (procfs_target::pid_to_str): Change return type.
10396         (procfs_target::attach): Update.
10397         (procfs_target::detach): Update.
10398         (procfs_target::fetch_registers): Update.
10399         (procfs_target::store_registers): Update.
10400         (procfs_target::wait): Update.
10401         (procfs_target::files_info): Update.
10402         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10403         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10404         return type.
10405         (nto_procfs_target::pid_to_str): Change return type.
10406         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10407         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10408         return type.
10409         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10410         (exit_lwp): Update.
10411         (attach_proc_task_lwp_callback, get_detach_signal)
10412         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10413         (linux_nat_target::resume, wait_lwp, stop_callback)
10414         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10415         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10416         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10417         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10418         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10419         type.
10420         (inf_ptrace_target::attach): Update.
10421         (inf_ptrace_target::files_info): Update.
10422         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10423         type.
10424         (go32_nat_target::pid_to_str): Change return type.
10425         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10426         (gnu_nat_target::wait): Update.
10427         (gnu_nat_target::wait): Update.
10428         (gnu_nat_target::resume): Update.
10429         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10430         (fbsd_nat_target::wait): Update.
10431         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10432         type.
10433         (darwin_nat_target::attach): Update.
10434         * corelow.c (class core_target) <pid_to_str>: Change return type.
10435         (core_target::pid_to_str): Change return type.
10436         * target.c (normal_pid_to_str): Change return type.
10437         (default_pid_to_str): Likewise.
10438         (target_pid_to_str): Change return type.
10439         (target_translate_tls_address): Update.
10440         (target_announce_detach): Update.
10441         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10442         return type.
10443         (bsd_uthread_target::pid_to_str): Change return type.
10444         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10445         type.
10446         (bsd_kvm_target::pid_to_str): Change return type.
10447         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10448         return type.
10449         (aix_thread_target::pid_to_str): Change return type.
10450         * target.h (struct target_ops) <pid_to_str>: Change return type.
10451         (target_pid_to_str, normal_pid_to_str): Likewise.
10452         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10453         type.
10454         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10455         type.
10456         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10457         return type.
10458         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10459         type.
10460         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10461         type.
10462         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10463         return type.
10464
10465 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10466
10467         * NEWS: Mention that the new default MI version is 3.  Mention
10468         changes to the output of commands and events that deal with
10469         multi-location breakpoints.
10470         * breakpoint.c: Include "mi/mi-out.h".
10471         (print_one_breakpoint): Change output syntax if using MI version
10472         >= 3.
10473         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10474         New.
10475         (mi_multi_location_breakpoint_output_fixed): New.
10476         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10477         (mi_cmd_fix_multi_location_breakpoint_output): New.
10478         (mi_multi_location_breakpoint_output_fixed): New.
10479         * mi/mi-cmds.c (mi_cmds): Register command
10480         -fix-multi-location-breakpoint-output.
10481         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10482         interpreter "mi".
10483
10484 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10485
10486         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10487         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10488         instantiate mi_ui_out based on interpreter name.
10489         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10490         * mi/mi-main.c (mi_load_progress): Likewise.
10491
10492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10493
10494         * NEWS: Combine separate "New targets" sections for 8.3.
10495
10496 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10497
10498         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10499         (ppcfbsd_init_abi): Install gdbarch
10500         "fetch_tls_load_module_address" and "get_thread_local_address"
10501         methods.
10502
10503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10504
10505         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10506         (riscv_fbsd_init_abi): Install gdbarch
10507         "fetch_tls_load_module_address" and "get_thread_local_address"
10508         methods.
10509
10510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10511
10512         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10513         (i386fbsd_init_abi): Install gdbarch
10514         "fetch_tls_load_module_address" and "get_thread_local_address"
10515         methods.
10516
10517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10518
10519         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10520         (amd64fbsd_init_abi): Install gdbarch
10521         "fetch_tls_load_module_address" and "get_thread_local_address"
10522         methods.
10523
10524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10525
10526         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10527         (struct fbsd_pspace_data): New type.
10528         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10529         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10530         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10531         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10532         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10533
10534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10535
10536         * gdbtypes.c (lookup_struct_elt): New function.
10537         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10538         * gdbtypes.h (struct struct_elt): New type.
10539         (lookup_struct_elt): New prototype.
10540
10541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10542
10543         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10544         remove disabled code block.
10545
10546 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10547
10548         * gdbarch.sh (get_thread_local_address): New method.
10549         * gdbarch.h, gdbarch.c: Regenerate.
10550         * target.c (target_translate_tls_address): Use
10551         gdbarch_get_thread_local_address if present instead of
10552         target::get_thread_local_address.
10553
10554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10555
10556         * target.h (target::get_thread_local_address): Update comment.
10557
10558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10559
10560         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10561         objfile->separate_debug_objfile_backlink if not NULL.
10562
10563 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10564
10565         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10566         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10567         (amd64bsd_store_inferior_registers): Likewise.
10568         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10569         Enable segment base registers.
10570         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10571         PT_GETFSBASE and PT_GETGSBASE.
10572         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10573         PT_SETGSBASE.
10574         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10575         segment base registers.
10576         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10577
10578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10579
10580         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10581         Update calls to i386_target_description to add 'segments'
10582         parameter.
10583         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10584         add segment base registers.
10585         * arch/i386.c (i386_create_target_description): Add 'segments'
10586         parameter to enable segment base registers.
10587         * arch/i386.h (i386_create_target_description): Likewise.
10588         * features/i386/32bit-segments.xml: New file.
10589         * features/i386/32bit-segments.c: Generate.
10590         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10591         call to i386_target_description to add 'segments' parameter.
10592         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10593         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10594         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10595         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10596         if feature is present.
10597         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10598         Add 'segments' parameter to call to i386_target_description.
10599         (i386_target_description): Add 'segments' parameter to enable
10600         segment base registers.
10601         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10602         to call to i386_target_description.
10603         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10604         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10605         Define I386_NUM_REGS.
10606         (i386_target_description): Add 'segments' parameter to enable
10607         segment base registers.
10608
10609 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10610
10611         PR/24325
10612         * source-cache.c: #undef open and close, to avoid unresolved
10613         externals during linking.
10614
10615 2019-03-12  Tom Tromey  <tromey@adacore.com>
10616
10617         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10618         const.  Add initializers.
10619         (_initialize_remote): Don't initialize ptid globals.
10620
10621 2019-03-12  Pedro Alves  <palves@redhat.com>
10622
10623         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10624
10625 2019-03-12  Pedro Alves  <palves@redhat.com>
10626
10627         * cp-name-parser.y (main): Remove unused 'len' variable.
10628
10629 2019-03-12  Tom Tromey  <tromey@adacore.com>
10630
10631         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10632         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10633
10634 2019-03-12  Tom Tromey  <tromey@adacore.com>
10635
10636         * linux-nat.c (iterate_over_lwps): Update.
10637         (stop_callback): Remove parameter.
10638         (stop_wait_callback, detach_callback, resume_set_callback)
10639         (select_singlestep_lwp_callback, set_ignore_sigint)
10640         (status_callback, resumed_callback, resume_clear_callback)
10641         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10642         data parameter.
10643         (linux_nat_target::detach, linux_nat_target::resume)
10644         (linux_stop_and_wait_all_lwps, select_event_lwp)
10645         (linux_nat_filter_event, linux_nat_wait_1)
10646         (linux_nat_target::kill, linux_nat_target::stop)
10647         (linux_nat_target::stop): Update.
10648         (linux_nat_resume_callback): Change type.
10649         (resume_stopped_resumed_lwps, count_events_callback)
10650         (select_event_lwp_callback): Likewise.
10651         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10652         * arm-linux-nat.c (struct update_registers_data): Remove.
10653         (update_registers_callback): Change type.
10654         (arm_linux_insert_hw_breakpoint1): Update.
10655         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10656         parameter.
10657         (x86_linux_dr_set_addr): Update.
10658         (x86_linux_dr_set_control): Update.
10659         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10660         (iterate_over_lwps): Use gdb::function_view.
10661         * nat/aarch64-linux-hw-point.c (struct
10662         aarch64_dr_update_callback_param): Remove.
10663         (debug_reg_change_callback): Change type.
10664         (aarch64_notify_debug_reg_change): Update.
10665         * s390-linux-nat.c (s390_refresh_per_info): Update.
10666
10667 2019-03-11  Tom Tromey  <tromey@adacore.com>
10668
10669         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10670         redundant assignment to "this_cu".
10671
10672 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10673
10674         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10675
10676 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10677
10678         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10679         from...
10680         (rank_one_type): ... this.
10681
10682 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10683
10684         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10685         from...
10686         (rank_one_type): ... this.
10687
10688 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10689
10690         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10691         from...
10692         (rank_one_type): ... this.
10693
10694 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10695
10696         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10697         from...
10698         (rank_one_type): ... this.
10699
10700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10701
10702         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10703         from...
10704         (rank_one_type): ... this.
10705
10706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10707
10708         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10709         from...
10710         (rank_one_type): ... this.
10711
10712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10713
10714         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10715         from...
10716         (rank_one_type): ... this.
10717
10718 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10719
10720         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10721         from...
10722         (rank_one_type): ... this.
10723
10724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10725
10726         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10727         from...
10728         (rank_one_type): ... this.
10729
10730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10731
10732         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10733         from...
10734         (rank_one_type): ... this.
10735
10736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10737
10738         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10739         from...
10740         (rank_one_type): ... this.
10741
10742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10743
10744         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10745         from...
10746         (rank_one_type): ... this.
10747
10748 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10749
10750         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10751         inferior-events' shows the example events.
10752
10753 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10754
10755         Support styling on native MS-Windows console
10756
10757         PR/24315
10758         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10759         on MS-Windows if $TERM is not defined.
10760
10761         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10762
10763         * posix-hdep.c (gdb_console_fputs):
10764         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10765         functions.
10766         * ui-file.h (gdb_console_fputs): Add prototype.
10767
10768         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10769         back to fputs only if the former returns zero.
10770
10771 2019-03-07  Tom Tromey  <tom@tromey.com>
10772
10773         * symmisc.c (print_symbol_bcache_statistics): Update.
10774         (print_objfile_statistics): Update.
10775         * symfile.c (allocate_symtab): Update.
10776         * stabsread.c: Don't include bcache.h.
10777         * psymtab.h (struct psymbol_bcache): Don't declare.
10778         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10779         (psymbol_bcache_init, psymbol_bcache_free)
10780         (psymbol_bcache_get_bcache): Don't declare.
10781         * psymtab.c (struct psymbol_bcache): Remove.
10782         (psymtab_storage::psymtab_storage): Update.
10783         (psymtab_storage::~psymtab_storage): Update.
10784         (psymbol_bcache_init, psymbol_bcache_free)
10785         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10786         (add_psymbol_to_bcache): Update.
10787         (allocate_psymtab): Update.
10788         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10789         macro_cache>: No longer pointers.
10790         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10791         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10792         * macrotab.c (macro_bcache): Update.
10793         * macroexp.c: Don't include bcache.h.
10794         * gdbtypes.c (check_types_worklist): Update.
10795         (types_deeply_equal): Remove TRY/CATCH.  Update.
10796         * elfread.c (elf_symtab_read): Update.
10797         * dwarf2read.c: Don't include bcache.h.
10798         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10799         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10800         (print_bcache_statistics, bcache_memory_used): Don't declare.
10801         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10802         methods.  Rename all data members.
10803         * bcache.c (struct bcache): Move to bcache.h.
10804         (bcache::expand_hash_table): Rename from expand_hash_table.
10805         (bcache): Remove.
10806         (bcache::insert): Rename from bcache_full.
10807         (bcache::compare): Rename from bcache_compare.
10808         (bcache_xmalloc): Remove.
10809         (bcache::~bcache): Rename from bcache_xfree.
10810         (bcache::print_statistics): Rename from print_bcache_statistics.
10811         (bcache::memory_used): Rename from bcache_memory_used.
10812
10813 2019-03-07  Pedro Alves  <palves@redhat.com>
10814
10815         * infrun.c (normal_stop): Also check for
10816         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10817
10818 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10819
10820         * f-lang.c (value_from_host_double): Moved to...
10821         * value.c (value_from_host_double): ...here.
10822         * value.h (value_from_host_double): Declare.
10823         * guile/scm-math.c (vlscm_convert_typed_number): Use
10824         value_from_host_double.
10825         (vlscm_convert_number): Likewise.
10826         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10827         * python/py-value.c (convert_value_from_python): Likewise.
10828
10829 2019-03-06  Tom Tromey  <tom@tromey.com>
10830
10831         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10832
10833 2019-03-06  Tom Tromey  <tom@tromey.com>
10834
10835         * utils.h (free_current_contents): Don't declare.
10836         * utils.c (free_current_contents): Remove.
10837
10838 2019-03-06  Tom Tromey  <tom@tromey.com>
10839
10840         * top.c (quit_force): Update.
10841         * main.c (captured_command_loop): Update.
10842         * common/new-op.c (operator new): Update.
10843         * common/common-exceptions.c (struct catcher)
10844         <save_cleanup_chain>: Remove member.
10845         (exceptions_state_mc_init): Update.
10846         (exception_try_scope_entry): Return nullptr.
10847         (exception_try_scope_exit, exception_rethrow)
10848         (throw_exception_sjlj, throw_exception_cxx): Update.
10849         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10850         (all_cleanups, do_cleanups, discard_cleanups)
10851         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10852         (restore_cleanups, restore_final_cleanups): Don't declare.
10853         (do_final_cleanups): Remove parameter.
10854         * common/cleanups.c (cleanup_chain, make_cleanup)
10855         (make_cleanup_dtor, all_cleanups, do_cleanups)
10856         (discard_my_cleanups, discard_cleanups)
10857         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10858         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10859         (null_cleanup): Remove.
10860         (do_final_cleanups): Remove parameter.
10861
10862 2019-03-06  Tom Tromey  <tom@tromey.com>
10863
10864         * remote.c (remote_target::remote_parse_stop_reply): Use
10865         unique_xmalloc_ptr.
10866
10867 2019-03-06  Tom Tromey  <tom@tromey.com>
10868
10869         * stabsread.c (struct stabs_field_info): Rename from field_info.
10870         <list, fnlist>: Add initializers.
10871         <obstack>: New member.
10872         (read_member_functions, read_struct_fields, read_baseclasses):
10873         Allocate on obstack.  Don't use cleanups.
10874         (read_one_struct_field, read_member_functions, read_struct_fields)
10875         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10876         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10877         (read_struct_type): Update.
10878
10879 2019-03-06  Tom Tromey  <tom@tromey.com>
10880
10881         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10882         * common/filestuff.h (make_cleanup_close): Don't declare.
10883         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10884         Remove.
10885
10886 2019-03-06  Tom Tromey  <tom@tromey.com>
10887
10888         * solib-aix.c: Use make_scope_exit.
10889
10890 2019-03-06  Tom Tromey  <tom@tromey.com>
10891
10892         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10893         Use make_scope_exit.
10894
10895 2019-03-06  Tom Tromey  <tom@tromey.com>
10896
10897         * solib-svr4.c (disable_probes_interface): Remove parameter.
10898         (svr4_handle_solib_event): Use make_scope_exit.
10899
10900 2019-03-06  Tom Tromey  <tom@tromey.com>
10901
10902         * remote.c (struct stop_reply_deleter): Remove.
10903         (stop_reply_up): Update.
10904         (struct stop_reply): Derive from notif_event.  Don't typedef.
10905         <regcache>: Now a std::vector.
10906         (stop_reply_xfree): Remove.
10907         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10908         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10909         (remote_target::discard_pending_stop_replies): Use delete.
10910         (remote_target::remote_parse_stop_reply): Update.
10911         (remote_target::process_stop_reply): Update.
10912         * remote-notif.h (struct notif_event): Add virtual destructor.
10913         Remove "dtr" member.
10914         (struct notif_client) <alloc_event>: Return a unique_ptr.
10915         (notif_event_xfree): Don't declare.
10916         (notif_event_up): New typedef.
10917         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10918         (notif_event_xfree, do_notif_event_xfree): Remove.
10919         (remote_notif_state_xfree): Update.
10920
10921 2019-03-06  Tom Tromey  <tom@tromey.com>
10922
10923         * infrun.c (displaced_step_clear_cleanup): Now a
10924         forward_scope_exit type.
10925         (displaced_step_prepare_throw): Update.
10926         (displaced_step_fixup): Update.
10927
10928 2019-03-06  Tom Tromey  <tom@tromey.com>
10929
10930         * inferior.h (class inferior): Update comment.
10931         * gdbthread.h (class thread_info): Update comment.
10932
10933 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10934             Tom Tromey  <tom@tromey.com>
10935
10936         * stabsread.h (struct stab_section_list): Remove.
10937         (coffstab_build_psymtabs): Update.
10938         * dbxread.c (symbuf_sections): Now a std::vector.
10939         (sect_idx): New global.
10940         (fill_symbuf): Update.
10941         (coffstab_build_psymtabs): Change type of stabsects parameter.
10942         Update.
10943         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10944         std::vector.
10945         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10946         (coff_locate_sections): Update.
10947         (coff_symfile_read): Remove cleanups.  Update.
10948         (init_stringtab): Add storage parameter.
10949         (free_stringtab, free_stringtab_cleanup): Remove.
10950         (init_lineno): Add storage parameter.
10951         (free_linetab, free_linetab_cleanup): Remove.
10952
10953 2019-03-06  Pedro Alves  <palves@redhat.com>
10954
10955         * linux-fork.c (fork_info::clobber_regs): Delete.
10956         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10957         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10958         comment.  Adjust.
10959         (scoped_switch_fork_info::scoped_switch_fork_info)
10960         (checkpoint_command, linux_fork_context): Adjust
10961         fork_save_infrun_state calls.
10962
10963 2019-03-06  Pedro Alves  <palves@redhat.com>
10964
10965         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10966         (inf_has_multiple_threads): Return 'bool' and rewrite using
10967         inferior_info::threads().
10968
10969 2019-03-06  Pedro Alves  <palves@redhat.com>
10970
10971         * linux-fork.c: Include <list>.
10972         (fork_list): Now a std::list instance.
10973         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10974         (forks_exist_p, find_last_fork): Adjust.
10975         (new_fork): Delete.
10976         (one_fork_p): New.
10977         (add_fork): Adjust.
10978         (free_fork): Delete, folded into fork_info::~fork_info().
10979         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10980         Adjust.
10981         (init_fork_list): Delete.
10982         (linux_fork_killall, linux_fork_mourn_inferior)
10983         (linux_fork_detach, info_checkpoints_command): Adjust.
10984         (_initialize_linux_fork): No longer call init_fork_list.
10985
10986 2019-03-06  Pedro Alves  <palves@redhat.com>
10987
10988         * linux-fork.c (new_fork): New, split out of ...
10989         (add_fork): ... this.  Return void.  Move "first fork" special
10990         case from here, to ...
10991         (checkpoint_command): ... here.
10992         * linux-linux.h (add_fork): Return void.
10993
10994 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10995
10996         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10997
10998 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10999             Chris January  <chris.january@arm.com>
11000             David Lecomber  <david.lecomber@arm.com>
11001
11002         * f-exp.y: New token, UNOP_INTRINSIC.
11003         (exp): New pattern using UNOP_INTRINSIC token.
11004         (f77_keywords): Add 'abs' keyword.
11005         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11006         (value_from_host_double): New function.
11007         (evaluate_subexp_f): Support UNOP_ABS.
11008
11009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11010
11011         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11012         types.
11013
11014 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11015
11016         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11017         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11018         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11019
11020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11021
11022         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11023
11024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11025             Chris January  <chris.january@arm.com>
11026
11027         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11028         * f-exp.y: Define 'KIND' token.
11029         (exp): New pattern for KIND expressions.
11030         (ptype): Handle types with a kind extension.
11031         (direct_abs_decl): Extend to spot kind extensions.
11032         (f77_keywords): Add 'kind' to the list.
11033         (push_kind_type): New function.
11034         (convert_to_kind_type): New function.
11035         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11036         * parse.c (operator_length_standard): Likewise.
11037         * parser-defs.h (enum type_pieces): Add tp_kind.
11038         * std-operator.def: Add UNOP_KIND.
11039
11040 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11041
11042         * f-exp.y (f_parse): Set yydebug.
11043
11044 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11045
11046         * f-lang.c (evaluate_subexp_f): New function.
11047         (exp_descriptor_f): New global.
11048         (f_language_defn): Use exp_descriptor_f instead of
11049         exp_descriptor_standard.
11050
11051 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11052
11053         * f-exp.y (struct token): Add comments.
11054         (dot_ops): Remove uppercase versions and the end marker.
11055         (f77_keywords): Likewise.
11056         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11057         entries in the dot_ops array are case insensitive, and use
11058         strncasecmp to compare strings.  Also some whitespace cleanup in
11059         this area.  Similar for the f77_keywords array, except entries in
11060         this list might be case sensitive.
11061
11062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11063
11064         * f-exp.y (struct f77_boolean_val): Add comments.
11065         (boolean_values): Remove uppercase versions, and end marker.
11066         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11067         and use strncasecmp to achieve case insensitivity.  Additionally,
11068         perform whitespace cleanup around this code.
11069
11070 2019-03-06  Tom Tromey  <tromey@adacore.com>
11071
11072         * remote-sim.c (gdbsim_target_open): Use result of
11073         gdb_argv::release.
11074
11075 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11076         Dirk Schubert  <dirk.schubert@arm.com>
11077         Chris January  <chris.january@arm.com>
11078
11079         * eval.c (evaluate_subexp_standard): Call Fortran argument
11080         wrapping logic.
11081         * f-lang.c (struct value): A value which can be passed into a
11082         Fortran function call.
11083         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11084         where appropriate.
11085         (struct type): Value ready for a Fortran function call.
11086         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11087         is needed.
11088         * f-lang.h (fortran_argument_convert): Declaration.
11089         (fortran_preserve_arg_pointer): Declaration.
11090         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11091
11092 2019-03-05  Tom Tromey  <tromey@adacore.com>
11093
11094         * python/py-prettyprint.c (print_string_repr): Remove #if.
11095         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11096
11097 2019-03-05  Tom Tromey  <tromey@adacore.com>
11098
11099         * target.c (the_dummy_target): Move later.  Change type to
11100         "dummy_target".
11101         (initialize_targets): Don't initialize the_dummy_target.
11102
11103 2019-03-05  Tom Tromey  <tromey@adacore.com>
11104
11105         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11106         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11107
11108 2019-03-05  Tom Tromey  <tromey@adacore.com>
11109
11110         * windows-nat.c (windows_nat_target::attach)
11111         (windows_nat_target::detach): Don't call gdb_flush.
11112         * valprint.c (generic_val_print, val_print, val_print_string):
11113         Don't call gdb_flush.
11114         * utils.c (defaulted_query): Don't call gdb_flush.
11115         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11116         * target.c (target_announce_detach): Don't call gdb_flush.
11117         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11118         * remote.c (extended_remote_target::attach): Don't call
11119         gdb_flush.
11120         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11121         * printcmd.c (do_examine): Don't call gdb_flush.
11122         (info_display_command): Don't call gdb_flush.
11123         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11124         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11125         * memattr.c (info_mem_command): Don't call gdb_flush.
11126         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11127         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11128         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11129         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11130         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11131         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11132         (gnu_nat_target::detach): Don't call gdb_flush.
11133         * f-valprint.c (f_val_print): Don't call gdb_flush.
11134         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11135         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11136         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11137         gdb_flush.
11138         * c-valprint.c (c_val_print): Don't call gdb_flush.
11139         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11140
11141 2019-03-05  Tom Tromey  <tromey@adacore.com>
11142
11143         * varobj.c (update_dynamic_varobj_children): Update.
11144         (install_default_visualizer): Use reset, not release.
11145         * value.c (set_internalvar): Update.
11146         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11147         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11148         ATTRIBUTE_UNUSED_RESULT.
11149
11150 2019-03-05  Tom Tromey  <tromey@adacore.com>
11151
11152         * remote.c (class scoped_remote_fd) <release>: Add
11153         ATTRIBUTE_UNUSED_RESULT.
11154
11155 2019-03-05  Tom Tromey  <tromey@adacore.com>
11156
11157         * macroexp.c (struct macro_buffer) <release>: Add
11158         ATTRIBUTE_UNUSED_RESULT.
11159
11160 2019-03-05  Tom Tromey  <tromey@adacore.com>
11161
11162         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11163         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11164         ATTRIBUTE_UNUSED_RESULT.
11165
11166 2019-03-05  Tom Tromey  <tromey@adacore.com>
11167
11168         * common/scoped_fd.h (class scoped_fd) <release>: Add
11169         ATTRIBUTE_UNUSED_RESULT.
11170
11171 2019-03-05  Tom Tromey  <tromey@adacore.com>
11172
11173         * parser-defs.h (struct parser_state) <release>: Add
11174         ATTRIBUTE_UNUSED_RESULT.
11175
11176 2019-03-05  Tom Tromey  <tromey@adacore.com>
11177
11178         * utils.h (class gdb_argv) <release>: Add
11179         ATTRIBUTE_UNUSED_RESULT.
11180         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11181
11182 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11183
11184         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11185         for-loop range, to avoid compiler warnings.
11186
11187         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11188         avoid compiler warnings about unused variables.
11189
11190         * NEWS: Mention end of support for native debugging on MS-Windows
11191         before XP.
11192
11193         PR gdb/24292
11194         * common/netstuff.c:
11195         * gdbserver/gdbreplay.c
11196         * gdbserver/remote-utils.c:
11197         * ser-tcp.c:
11198         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11199         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11200         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11201         'getaddrinfo' and 'freeaddrinfo' were not available before
11202         Windows XP, and mingw.org's MinGW headers by default define
11203         _WIN32_WINNT to 0x500.
11204
11205 2019-03-01  Gary Benson <gbenson@redhat.com>
11206
11207         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11208
11209 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11210             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11211
11212         PR gdb/8527
11213         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11214         set_sigint_trap, clear_sigint_trap.
11215
11216 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11217
11218         * target.c (target_detach): Clear the regcache and the
11219         frame cache.
11220
11221 2019-02-27  Pedro Alves  <palves@redhat.com>
11222
11223         * utils.c (set_screen_size): When we cap the height/width sizes,
11224         tweak the corresponding command variable to show "unlimited":
11225
11226 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11227             Pedro Alves  <palves@redhat.com>
11228
11229         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11230         before calling rl_set_screen_size.
11231
11232 2019-02-27  Tom Tromey  <tromey@adacore.com>
11233
11234         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11235         define.
11236         * python/py-value.c: Remove Python 2.4 workaround.
11237         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11238         workaround.
11239         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11240         Python 2.4 workaround.
11241         * python/python-internal.h: Remove Python 2.4 comment.
11242         (Py_ssize_t): Don't define.
11243         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11244         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11245         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11246         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11247         * python/python.c (do_start_initialization): Remove Python 2.4
11248         workaround.
11249         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11250         (print_children): Remove Python 2.4 workaround.
11251         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11252         workaround.
11253         (CHARBUFFERPROC_NAME): Remove.
11254         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11255         Python 2.4 workaround.
11256
11257 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11258
11259         * NEWS: Note minimum Python version.
11260
11261 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11262
11263         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11264         code from these functions.  Remove corresponding ifdefs.  Use
11265         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11266         Remove gotos and target of gotos.
11267         (infpy_search_memory): Likewise.
11268
11269 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11270
11271         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11272         (hppa_gdbarch_init): Don't register deleted functions with
11273         gdbarch.
11274
11275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11276
11277         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11278         (h8300_unwind_sp): Delete.
11279         (h8300_dummy_id): Delete.
11280         (h8300_gdbarch_init): Don't register deleted functions with
11281         gdbarch.
11282
11283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11284
11285         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11286         (ft32_unwind_pc): Delete.
11287         (ft32_unwind_sp): Delete.
11288         (ft32_gdbarch_init): Don't register deleted functions with
11289         gdbarch.
11290
11291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11294         (frv_unwind_pc): Delete.
11295         (frv_unwind_sp): Delete.
11296         (frv_gdbarch_init): Don't register deleted functions with
11297         gdbarch.
11298
11299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11300
11301         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11302         (riscv_unwind_pc): Delete.
11303         (riscv_unwind_sp): Delete.
11304         (riscv_gdbarch_init): Don't register deleted functions with
11305         gdbarch.
11306
11307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11308
11309         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11310         (csky_unwind_pc): Delete.
11311         (csky_unwind_sp): Delete.
11312         (csky_gdbarch_init): Don't register deleted functions with
11313         gdbarch.
11314
11315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11316
11317         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11318         (cris_unwind_pc): Delete.
11319         (cris_unwind_sp): Delete.
11320         (cris_gdbarch_init): Don't register deleted functions with
11321         gdbarch.
11322
11323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11324
11325         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11326         (bfin_unwind_pc): Delete.
11327         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11328
11329 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11330
11331         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11332         (arm_unwind_pc): Delete.
11333         (arm_unwind_sp): Delete.
11334         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11335
11336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11337
11338         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11339         (arc_unwind_pc): Delete.
11340         (arc_unwind_sp): Delete.
11341         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11342
11343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11344
11345         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11346         (alpha_unwind_pc): Delete.
11347         (alpha_gdbarch_init): Don't register deleted functions with
11348         gdbarch.
11349
11350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11351
11352         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11353         (aarch64_unwind_pc): Delete.
11354         (aarch64_unwind_sp): Delete.
11355         (aarch64_gdbarch_init): Don't register deleted functions with
11356         gdbarch.
11357
11358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11359
11360         * gdbtypes.c (type_align): Don't consider static members when
11361         computing structure alignment.
11362
11363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11364
11365         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11366         return 0 for other types.
11367         * arch-utils.c (default_type_align): Always return 0.
11368         * gdbarch.h: Regenerate.
11369         * gdbarch.sh (type_align): Extend comment.
11370         * gdbtypes.c (type_align): Add additional comments, always call
11371         gdbarch_type_align before applying the default rules.
11372         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11373         generic code will then apply a suitable default.
11374         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11375         types, return 0 for other types.
11376
11377 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11378
11379         * NEWS: Create a new section for the next release branch.
11380         Rename the section of the current branch, now that it has
11381         been cut.
11382
11383 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11384
11385         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11386         * version.in: Bump version to 8.3.50.DATE-git.
11387
11388 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11389
11390         * aix-thread.c (ptid_cmp): Remove unused variable.
11391         (get_signaled_thread): Likewise.
11392         (store_regs_user_thread): Likewise.
11393         (store_regs_kernel_thread): Likewise.
11394         (fetch_regs_kernel_thread): Remove shadowed variable.
11395
11396 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11397
11398         * features/riscv/32bit-cpu.xml: Add register numbers.
11399         * features/riscv/32bit-fpu.c: Regenerate.
11400         * features/riscv/32bit-fpu.xml: Add register numbers.
11401         * features/riscv/64bit-cpu.xml: Add register numbers.
11402         * features/riscv/64bit-fpu.c: Regenerate.
11403         * features/riscv/64bit-fpu.xml: Add register numbers.
11404
11405 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11406
11407         * NEWS: Mention two argument form of gdb.Value constructor.
11408         * python/py-value.c (convert_buffer_and_type_to_value): New
11409         function.
11410         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11411         Add support for handling an optional second argument.  Call
11412         convert_buffer_and_type_to_value as appropriate.
11413         * python/python-internal.h (Py_buffer_deleter): New struct.
11414         (Py_buffer_up): New typedef.
11415
11416 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11417
11418         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11419         instead of releasing ownership.
11420
11421 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11422
11423         * dwarf2read.c (open_and_init_dwp_file): Call
11424         elf_numsections instead of bfd_count_sections to initialize
11425         dwp_file->num_sections.
11426
11427 2019-02-25  Tom Tromey  <tromey@adacore.com>
11428
11429         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11430
11431 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11432
11433         * gcore.in: Add '--readnever' option when invoking GDB.
11434
11435 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11436
11437         * MAINTAINERS: Update my email address.
11438
11439 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11440
11441         * build-id.c (build_id_to_debug_bfd_1): New function.
11442         (build_id_to_debug_bfd): Look for separate debug file in
11443         sysroot.
11444
11445 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * gdbarch.sh: Update the copyright year range that is placed into
11448         generated files.
11449
11450 2019-02-22  Keith Seitz  <keiths@redhat.com>
11451
11452         PR symtab/23853
11453         * linespec.c (create_sals_line_offset): Search for the default
11454         symtab's filename instead of its fullname.
11455
11456 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11457
11458         * NEWS: Update style defaults.
11459
11460 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11461
11462         * main.c (captured_main_1): Disable styling in batch mode.
11463
11464 2019-02-20  Tom Tromey  <tom@tromey.com>
11465
11466         * symtab.c (symtab_symbol_info): Fix typos.
11467
11468 2019-02-20  Tom Tromey  <tromey@adacore.com>
11469
11470         * findcmd.c (_initialize_mem_search): Use upper case for
11471         metasyntactic variables.
11472
11473 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11474
11475         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11476         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11477
11478 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11479
11480         * top.h (source_file_name): Change to std::string.
11481         * top.c (source_file_name): Likewise.
11482         (command_line_input): Adjust.
11483         * cli/cli-script.c (script_from_file): Adjust.
11484
11485 2019-02-19  Tom Tromey  <tromey@adacore.com>
11486
11487         * ravenscar-thread.c
11488         (ravenscar_thread_target::update_thread_list): Don't call
11489         ada_build_task_list.
11490         * ada-lang.h (ada_build_task_list): Don't declare.
11491         * ada-tasks.c (struct ada_tasks_inferior_data)
11492         <task_list_valid_p>: Now bool.
11493         (read_known_tasks, ada_task_list_changed)
11494         (ada_tasks_invalidate_inferior_data): Update.
11495         (read_known_tasks_array): Return bool.
11496         (read_known_tasks_list): Likewise.
11497         (read_known_tasks): Return void.
11498         (ada_build_task_list): Now static.
11499
11500 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11501
11502         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11503         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11504
11505 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11506
11507         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11508         variant for ada_tasks_pspace_data_handle and
11509         ada_tasks_inferior_data_handle.
11510         (ada_tasks_pspace_data_cleanup): New function.
11511         (ada_tasks_inferior_data_cleanup): New function.
11512
11513 2019-02-17  Tom Tromey  <tom@tromey.com>
11514
11515         * macrotab.h (macro_source_fullname): Return a std::string.
11516         * macrotab.c (macro_include, check_for_redefinition)
11517         (macro_undef, macro_lookup_definition, foreach_macro)
11518         (foreach_macro_in_scope): Update.
11519         (macro_source_fullname): Return a std::string.
11520         * macrocmd.c (show_pp_source_pos): Update.
11521
11522 2019-02-17  Tom Tromey  <tom@tromey.com>
11523
11524         * macrocmd.c (show_pp_source_pos): Style the file names.
11525
11526 2019-02-17  Tom Tromey  <tom@tromey.com>
11527
11528         PR tui/24197:
11529         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11530
11531 2019-02-17  Tom Tromey  <tom@tromey.com>
11532
11533         * ada-lang.c (user_select_syms): Use filtered printing.
11534         * utils.c (wrap_style): New global.
11535         (desired_style): Remove.
11536         (emit_style_escape): Add stream parameter.
11537         (set_output_style, reset_terminal_style, prompt_for_continue):
11538         Update.
11539         (flush_wrap_buffer): Only flush gdb_stdout.
11540         (wrap_here): Set wrap_style.
11541         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11542         treat escape sequences as a character.  Change when wrap buffer is
11543         flushed.
11544         (fputs_styled): Do not set the output style when the default is
11545         requested.
11546         * ui-style.h (struct ui_file_style) <is_default>: New method.
11547         * source.c (print_source_lines_base): Emit escape sequences in one
11548         piece.
11549
11550 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11551
11552         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11553         integers and enumeration types.
11554
11555 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11556
11557         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11558         instead of lookup_symbol_in_language
11559         (do_exact_match): New function.
11560         (ada_get_symbol_name_matcher): Return do_exact_match when
11561         doing a verbatim match.
11562
11563 2019-02-15  Tom Tromey  <tromey@adacore.com>
11564
11565         * ravenscar-thread.c (ravenscar_thread_target::resume)
11566         (ravenscar_thread_target::wait): Special case wildcard requests.
11567
11568 2019-02-15  Tom Tromey  <tromey@adacore.com>
11569
11570         * ravenscar-thread.c (base_ptid): Remove.
11571         (struct ravenscar_thread_target) <close>: New method.
11572         <m_base_ptid>: New member.
11573         <update_inferior_ptid, active_task, task_is_currently_active,
11574         runtime_initialized>: Declare methods.
11575         <ravenscar_thread_target>: Add constructor.
11576         (ravenscar_thread_target::task_is_currently_active)
11577         (ravenscar_thread_target::update_inferior_ptid)
11578         (ravenscar_runtime_initialized): Rename.  Now methods.
11579         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11580         (ravenscar_thread_target::update_thread_list): Update.
11581         (ravenscar_thread_target::active_task): Now method.
11582         (ravenscar_thread_target::store_registers)
11583         (ravenscar_thread_target::prepare_to_store)
11584         (ravenscar_thread_target::prepare_to_store)
11585         (ravenscar_thread_target::mourn_inferior): Update.
11586         (ravenscar_inferior_created): Use "new" to create target.
11587         (ravenscar_thread_target::get_ada_task_ptid): Update.
11588         (_initialize_ravenscar): Don't initialize base_ptid.
11589         (ravenscar_ops): Remove global.
11590
11591 2019-02-15  Tom Tromey  <tromey@adacore.com>
11592
11593         * target.h (push_target): Declare new overload.
11594         * target.c (push_target): New overload, taking an rvalue reference.
11595         * remote.c (remote_target::open_1): Use push_target overload.
11596         * corelow.c (core_target_open): Use push_target overload.
11597
11598 2019-02-15  Tom Tromey  <tromey@adacore.com>
11599
11600         * ravenscar-thread.c (is_ravenscar_task)
11601         (ravenscar_task_is_currently_active): Return bool.
11602         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11603         (_initialize_ravenscar): Remove "(void)".
11604         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11605         Return bool.
11606
11607 2019-02-15  Tom Tromey  <tromey@adacore.com>
11608
11609         * ravenscar-thread.c (ravenscar_runtime_initializer)
11610         (has_ravenscar_runtime, get_running_thread_id)
11611         (ravenscar_thread_target::resume): Fix indentation.
11612
11613 2019-02-15  Tom Tromey  <tromey@adacore.com>
11614
11615         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11616         from ravenscar_arch_ops.
11617         (sparc_ravenscar_ops::fetch_registers)
11618         (sparc_ravenscar_ops::store_registers): Now methods.
11619         (sparc_ravenscar_prepare_to_store): Remove.
11620         (sparc_ravenscar_ops): Redefine.
11621         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11622         methods and destructor.  Remove members.
11623         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11624         (ravenscar_thread_target::store_registers)
11625         (ravenscar_thread_target::prepare_to_store): Update.
11626         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11627         Remove.
11628         (struct ppc_ravenscar_powerpc_ops): Derive from
11629         ravenscar_arch_ops.
11630         (ppc_ravenscar_powerpc_ops::fetch_registers)
11631         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11632         (ppc_ravenscar_powerpc_ops): Redefine.
11633         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11634         (ppc_ravenscar_e500_ops::fetch_registers)
11635         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11636         (ppc_ravenscar_e500_ops): Redefine.
11637         * aarch64-ravenscar-thread.c
11638         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11639         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11640         (aarch64_ravenscar_fetch_registers)
11641         (aarch64_ravenscar_store_registers): Now methods.
11642         (aarch64_ravenscar_ops): Redefine.
11643
11644 2019-02-15  Tom Tromey  <tromey@adacore.com>
11645
11646         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11647         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11648         (ravenscar_thread_target::stopped_by_watchpoint)
11649         (ravenscar_thread_target::stopped_data_address)
11650         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11651
11652 2019-02-15  Tom Tromey  <tromey@adacore.com>
11653
11654         * ravenscar-thread.c: Fix some typos.
11655
11656 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11657             Tom Tromey  <tromey@adacore.com>
11658
11659         * ada-lang.c (ada_exception_sal): Change addr_string to a
11660         std::string.
11661         (create_ada_exception_catchpoint): Update.
11662
11663 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11664             Tom Tromey  <tromey@adacore.com>
11665
11666         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11667         (bp_location_ops): Remove.
11668         (base_breakpoint_allocate_location): Update.
11669         (free_bp_location): Update.
11670         * ada-lang.c (class ada_catchpoint_location)
11671         <ada_catchpoint_location>: Remove ops parameter.
11672         (ada_catchpoint_location_dtor): Remove.
11673         (ada_catchpoint_location_ops): Remove.
11674         (allocate_location_exception): Update.
11675         * breakpoint.h (struct bp_location_ops): Remove.
11676         (class bp_location) <bp_location>: Remove bp_location_ops
11677         parameter.
11678         <~bp_location>: Add destructor.
11679         <ops>: Remove.
11680
11681 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11682             Pedro Alves  <palves@redhat.com>
11683
11684         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11685         'PATH_MAX'.
11686
11687 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11688             Samuel Thibault  <samuel.thibault@gnu.org>
11689             Thomas Schwinge  <thomas@codesourcery.com>
11690
11691         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11692         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11693
11694 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11695
11696         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11697         (check_empty): Use "const char *".
11698
11699         * gnu-nat.c (gnu_nat_target::detach): Instead of
11700         'detach_inferior (pid)' call
11701         'detach_inferior (find_inferior_pid (pid))'.
11702
11703         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11704         'nat/fork-inferior.o'.
11705         * gnu-nat.c: #include "nat/fork-inferior.h".
11706
11707         * gnu-nat.c (gnu_nat_target::detach): Instead of
11708         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11709         * gnu-nat.h: #include "inf-child.h".
11710         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11711         'i386_gnu_nat_target::fetch_registers'.
11712         (gnu_store_registers): Rename/move to
11713         'i386_gnu_nat_target::store_registers'.
11714
11715         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11716         * gnu-nat.h (mach_thread_info): New function.
11717         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11718
11719         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11720
11721 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11722
11723         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11724
11725 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11726
11727         * windows-nat.c (windows_add_thread): Add new parameter
11728         "main_thread_p" with default value set to false.  Update
11729         function documentation as well as all callers.
11730         (windows_delete_thread): Likewise.
11731         (fake_create_process): Update call to windows_add_thread.
11732         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11733         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11734         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11735         call to windows_delete_thread.
11736
11737 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11738
11739         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11740
11741 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11742
11743         * symfile.c (find_separate_debug_file): Use canonical path of
11744         sysroot with child_path instead of gdb_sysroot if it is valid.
11745
11746 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11747
11748         * symfile.c (find_separate_debug_file): Use child_path to
11749         determine if an object file is under a sysroot.
11750
11751 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11752
11753         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11754         unittests/child-path-selftests.c.
11755         * common/pathstuff.c (child_path): New function.
11756         * common/pathstuff.h (child_path): New prototype.
11757         * unittests/child-path-selftests.c: New file.
11758
11759 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11760
11761         * symfile.c (find_separate_debug_file): Look for separate debug
11762         files in debug directories under the sysroot.
11763
11764 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11765
11766         * symtab.h (struct minimal_symbol data_p): New const method.
11767         (struct minimal_symbol text_p): Likewise.
11768         * symtab.c (output_source_filename): Use file name style
11769         to print file name.
11770         (print_symbol_info): Likewise.
11771         (print_msymbol_info): Use address style to print addresses.
11772         Use function name style to print executable text symbols.
11773         (expand_symtab_containing_pc): Use data_p.
11774         (find_pc_sect_compunit_symtab): Likewise.
11775
11776 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11777
11778         * breakpoint.c (describe_other_breakpoints): Use address style
11779         to print addresses.
11780         (say_where): Likewise.
11781
11782 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11783
11784         * ada-typeprint.c (print_func_type): Print function name
11785         style to print function name.
11786         * c-typeprint.c (c_print_type_1): Likewise.
11787
11788 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11789
11790         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11791         for execve.
11792
11793 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11794
11795         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11796         type_stack.
11797
11798 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11799
11800         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11801         TYPE_CODE_REF types.
11802
11803 2019-02-08  Jim Wilson  <jimw@sifive.com>
11804
11805         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11806         (riscv_linux_fregset): New.
11807         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11808
11809 2019-02-07  Tom Tromey  <tom@tromey.com>
11810
11811         * thread.c (thread_cancel_execution_command): Update.
11812         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11813         methods.
11814         (struct thread_fsm_ops): Remove.
11815         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11816         (thread_fsm_should_stop, thread_fsm_return_value)
11817         (thread_fsm_set_finished, thread_fsm_finished_p)
11818         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11819         Don't declare.
11820         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11821         * infrun.c (clear_proceed_status_thread)
11822         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11823         (print_stop_event): Update.
11824         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11825         Add constructor.
11826         (step_command_fsm_ops): Remove.
11827         (new_step_command_fsm): Remove.
11828         (step_1): Update.
11829         (step_command_fsm::should_stop): Rename from
11830         step_command_fsm_should_stop.
11831         (step_command_fsm::clean_up): Rename from
11832         step_command_fsm_clean_up.
11833         (step_command_fsm::do_async_reply_reason): Rename from
11834         step_command_fsm_async_reply_reason.
11835         (struct until_next_fsm): Inherit from thread_fsm.  Add
11836         constructor.
11837         (until_next_fsm_ops): Remove.
11838         (new_until_next_fsm): Remove.
11839         (until_next_fsm::should_stop): Rename from
11840         until_next_fsm_should_stop.
11841         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11842         (until_next_fsm::do_async_reply_reason): Rename from
11843         until_next_fsm_async_reply_reason.
11844         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11845         constructor.  Change type of breakpoint.
11846         (finish_command_fsm_ops): Remove.
11847         (new_finish_command_fsm): Remove.
11848         (finish_command_fsm::should_stop): Rename from
11849         finish_command_fsm_should_stop.
11850         (finish_command_fsm::clean_up): Rename from
11851         finish_command_fsm_clean_up.
11852         (finish_command_fsm::return_value): Rename from
11853         finish_command_fsm_return_value.
11854         (finish_command_fsm::do_async_reply_reason): Rename from
11855         finish_command_fsm_async_reply_reason.
11856         (finish_command): Update.
11857         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11858         Add constructor.
11859         (call_thread_fsm_ops): Remove.
11860         (call_thread_fsm::call_thread_fsm): Rename from
11861         new_call_thread_fsm.
11862         (call_thread_fsm::should_stop): Rename from
11863         call_thread_fsm_should_stop.
11864         (call_thread_fsm::should_notify_stop): Rename from
11865         call_thread_fsm_should_notify_stop.
11866         (run_inferior_call, call_function_by_hand_dummy): Update.
11867         * cli/cli-interp.c (should_print_stop_to_console): Update.
11868         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11869         Add constructor.  Change type of location_breakpoint,
11870         caller_breakpoint.
11871         (until_break_fsm_ops): Remove.
11872         (new_until_break_fsm): Remove.
11873         (until_break_fsm::should_stop): Rename from
11874         until_break_fsm_should_stop.
11875         (until_break_fsm::clean_up): Rename from
11876         until_break_fsm_clean_up.
11877         (until_break_fsm::do_async_reply_reason): Rename from
11878         until_break_fsm_async_reply_reason.
11879         (until_break_command): Update.
11880         * thread-fsm.c: Remove.
11881         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11882
11883 2019-02-07  Tom Tromey  <tom@tromey.com>
11884
11885         * yy-remap.h: Add include guard.
11886         * xtensa-tdep.h: Add include guard.
11887         * xcoffread.h: Rename include guard.
11888         * varobj-iter.h: Add include guard.
11889         * tui/tui.h: Rename include guard.
11890         * tui/tui-winsource.h: Rename include guard.
11891         * tui/tui-wingeneral.h: Rename include guard.
11892         * tui/tui-windata.h: Rename include guard.
11893         * tui/tui-win.h: Rename include guard.
11894         * tui/tui-stack.h: Rename include guard.
11895         * tui/tui-source.h: Rename include guard.
11896         * tui/tui-regs.h: Rename include guard.
11897         * tui/tui-out.h: Rename include guard.
11898         * tui/tui-layout.h: Rename include guard.
11899         * tui/tui-io.h: Rename include guard.
11900         * tui/tui-hooks.h: Rename include guard.
11901         * tui/tui-file.h: Rename include guard.
11902         * tui/tui-disasm.h: Rename include guard.
11903         * tui/tui-data.h: Rename include guard.
11904         * tui/tui-command.h: Rename include guard.
11905         * tic6x-tdep.h: Add include guard.
11906         * target/waitstatus.h: Rename include guard.
11907         * target/wait.h: Rename include guard.
11908         * target/target.h: Rename include guard.
11909         * target/resume.h: Rename include guard.
11910         * target-float.h: Rename include guard.
11911         * stabsread.h: Add include guard.
11912         * rs6000-tdep.h: Add include guard.
11913         * riscv-fbsd-tdep.h: Add include guard.
11914         * regformats/regdef.h: Rename include guard.
11915         * record.h: Rename include guard.
11916         * python/python.h: Rename include guard.
11917         * python/python-internal.h: Rename include guard.
11918         * python/py-stopevent.h: Rename include guard.
11919         * python/py-ref.h: Rename include guard.
11920         * python/py-record.h: Rename include guard.
11921         * python/py-record-full.h: Rename include guard.
11922         * python/py-record-btrace.h: Rename include guard.
11923         * python/py-instruction.h: Rename include guard.
11924         * python/py-events.h: Rename include guard.
11925         * python/py-event.h: Rename include guard.
11926         * procfs.h: Add include guard.
11927         * proc-utils.h: Add include guard.
11928         * p-lang.h: Add include guard.
11929         * or1k-tdep.h: Rename include guard.
11930         * observable.h: Rename include guard.
11931         * nto-tdep.h: Rename include guard.
11932         * nat/x86-linux.h: Rename include guard.
11933         * nat/x86-linux-dregs.h: Rename include guard.
11934         * nat/x86-gcc-cpuid.h: Add include guard.
11935         * nat/x86-dregs.h: Rename include guard.
11936         * nat/x86-cpuid.h: Rename include guard.
11937         * nat/ppc-linux.h: Rename include guard.
11938         * nat/mips-linux-watch.h: Rename include guard.
11939         * nat/linux-waitpid.h: Rename include guard.
11940         * nat/linux-ptrace.h: Rename include guard.
11941         * nat/linux-procfs.h: Rename include guard.
11942         * nat/linux-osdata.h: Rename include guard.
11943         * nat/linux-nat.h: Rename include guard.
11944         * nat/linux-namespaces.h: Rename include guard.
11945         * nat/linux-btrace.h: Rename include guard.
11946         * nat/glibc_thread_db.h: Rename include guard.
11947         * nat/gdb_thread_db.h: Rename include guard.
11948         * nat/gdb_ptrace.h: Rename include guard.
11949         * nat/fork-inferior.h: Rename include guard.
11950         * nat/amd64-linux-siginfo.h: Rename include guard.
11951         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11952         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11953         * nat/aarch64-linux.h: Rename include guard.
11954         * nat/aarch64-linux-hw-point.h: Rename include guard.
11955         * mn10300-tdep.h: Add include guard.
11956         * mips-linux-tdep.h: Add include guard.
11957         * mi/mi-parse.h: Rename include guard.
11958         * mi/mi-out.h: Rename include guard.
11959         * mi/mi-main.h: Rename include guard.
11960         * mi/mi-interp.h: Rename include guard.
11961         * mi/mi-getopt.h: Rename include guard.
11962         * mi/mi-console.h: Rename include guard.
11963         * mi/mi-common.h: Rename include guard.
11964         * mi/mi-cmds.h: Rename include guard.
11965         * mi/mi-cmd-break.h: Rename include guard.
11966         * m2-lang.h: Add include guard.
11967         * location.h: Rename include guard.
11968         * linux-record.h: Rename include guard.
11969         * linux-nat.h: Add include guard.
11970         * linux-fork.h: Add include guard.
11971         * i386-darwin-tdep.h: Rename include guard.
11972         * hppa-linux-offsets.h: Add include guard.
11973         * guile/guile.h: Rename include guard.
11974         * guile/guile-internal.h: Rename include guard.
11975         * gnu-nat.h: Rename include guard.
11976         * gdb-stabs.h: Rename include guard.
11977         * frv-tdep.h: Add include guard.
11978         * f-lang.h: Add include guard.
11979         * event-loop.h: Add include guard.
11980         * darwin-nat.h: Rename include guard.
11981         * cp-abi.h: Rename include guard.
11982         * config/sparc/nm-sol2.h: Rename include guard.
11983         * config/nm-nto.h: Rename include guard.
11984         * config/nm-linux.h: Add include guard.
11985         * config/i386/nm-i386gnu.h: Rename include guard.
11986         * config/djgpp/nl_types.h: Rename include guard.
11987         * config/djgpp/langinfo.h: Rename include guard.
11988         * compile/gcc-cp-plugin.h: Add include guard.
11989         * compile/gcc-c-plugin.h: Add include guard.
11990         * compile/compile.h: Rename include guard.
11991         * compile/compile-object-run.h: Rename include guard.
11992         * compile/compile-object-load.h: Rename include guard.
11993         * compile/compile-internal.h: Rename include guard.
11994         * compile/compile-cplus.h: Rename include guard.
11995         * compile/compile-c.h: Rename include guard.
11996         * common/xml-utils.h: Rename include guard.
11997         * common/x86-xstate.h: Rename include guard.
11998         * common/version.h: Rename include guard.
11999         * common/vec.h: Rename include guard.
12000         * common/tdesc.h: Rename include guard.
12001         * common/selftest.h: Rename include guard.
12002         * common/scoped_restore.h: Rename include guard.
12003         * common/scoped_mmap.h: Rename include guard.
12004         * common/scoped_fd.h: Rename include guard.
12005         * common/safe-iterator.h: Rename include guard.
12006         * common/run-time-clock.h: Rename include guard.
12007         * common/refcounted-object.h: Rename include guard.
12008         * common/queue.h: Rename include guard.
12009         * common/ptid.h: Rename include guard.
12010         * common/print-utils.h: Rename include guard.
12011         * common/preprocessor.h: Rename include guard.
12012         * common/pathstuff.h: Rename include guard.
12013         * common/observable.h: Rename include guard.
12014         * common/netstuff.h: Rename include guard.
12015         * common/job-control.h: Rename include guard.
12016         * common/host-defs.h: Rename include guard.
12017         * common/gdb_wait.h: Rename include guard.
12018         * common/gdb_vecs.h: Rename include guard.
12019         * common/gdb_unlinker.h: Rename include guard.
12020         * common/gdb_unique_ptr.h: Rename include guard.
12021         * common/gdb_tilde_expand.h: Rename include guard.
12022         * common/gdb_sys_time.h: Rename include guard.
12023         * common/gdb_string_view.h: Rename include guard.
12024         * common/gdb_splay_tree.h: Rename include guard.
12025         * common/gdb_setjmp.h: Rename include guard.
12026         * common/gdb_ref_ptr.h: Rename include guard.
12027         * common/gdb_optional.h: Rename include guard.
12028         * common/gdb_locale.h: Rename include guard.
12029         * common/gdb_assert.h: Rename include guard.
12030         * common/filtered-iterator.h: Rename include guard.
12031         * common/filestuff.h: Rename include guard.
12032         * common/fileio.h: Rename include guard.
12033         * common/environ.h: Rename include guard.
12034         * common/common-utils.h: Rename include guard.
12035         * common/common-types.h: Rename include guard.
12036         * common/common-regcache.h: Rename include guard.
12037         * common/common-inferior.h: Rename include guard.
12038         * common/common-gdbthread.h: Rename include guard.
12039         * common/common-exceptions.h: Rename include guard.
12040         * common/common-defs.h: Rename include guard.
12041         * common/common-debug.h: Rename include guard.
12042         * common/cleanups.h: Rename include guard.
12043         * common/buffer.h: Rename include guard.
12044         * common/btrace-common.h: Rename include guard.
12045         * common/break-common.h: Rename include guard.
12046         * cli/cli-utils.h: Rename include guard.
12047         * cli/cli-style.h: Rename include guard.
12048         * cli/cli-setshow.h: Rename include guard.
12049         * cli/cli-script.h: Rename include guard.
12050         * cli/cli-interp.h: Rename include guard.
12051         * cli/cli-decode.h: Rename include guard.
12052         * cli/cli-cmds.h: Rename include guard.
12053         * charset-list.h: Add include guard.
12054         * buildsym-legacy.h: Rename include guard.
12055         * bfin-tdep.h: Add include guard.
12056         * ax.h: Rename include guard.
12057         * arm-linux-tdep.h: Add include guard.
12058         * arm-fbsd-tdep.h: Add include guard.
12059         * arch/xtensa.h: Rename include guard.
12060         * arch/tic6x.h: Add include guard.
12061         * arch/i386.h: Add include guard.
12062         * arch/arm.h: Rename include guard.
12063         * arch/arm-linux.h: Rename include guard.
12064         * arch/arm-get-next-pcs.h: Rename include guard.
12065         * arch/amd64.h: Add include guard.
12066         * arch/aarch64-insn.h: Rename include guard.
12067         * arch-utils.h: Rename include guard.
12068         * annotate.h: Add include guard.
12069         * amd64-darwin-tdep.h: Rename include guard.
12070         * aarch64-linux-tdep.h: Add include guard.
12071         * aarch64-fbsd-tdep.h: Add include guard.
12072         * aarch32-linux-nat.h: Add include guard.
12073
12074 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12075
12076         * macrotab.c (macro_define_internal): New function that
12077         factorizes macro_define_object_internal and macro_define_function
12078         code.
12079         (macro_define_object_internal): Use macro_define_internal.
12080         (macro_define_function): Likewise.
12081
12082 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12083
12084         * macrocmd.c (extract_identifier): Return
12085         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12086         callers.
12087
12088 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12089
12090         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12091
12092 2019-02-05  Tom Tromey  <tom@tromey.com>
12093
12094         * target.c (target_stack::unpush): Move assertion earlier.
12095
12096 2019-01-30  Tom Tromey  <tom@tromey.com>
12097
12098         PR python/23615:
12099         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12100         (gdbpy_parse_and_eval): Likewise.
12101         * python/python-internal.h (gdbpy_allow_threads): New class.
12102
12103 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12104
12105         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12106         (aarch64_fbsd_fpregmap): Move earlier.
12107         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12108         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12109         instead of individual calls to trad_frame_set_reg_addr.
12110         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12111         earlier.
12112         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12113         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12114         instead of individual calls to trad_frame_set_reg_addr.
12115
12116 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12117
12118         * CONTRIBUTE: Replace contribution list with wiki link.
12119
12120 2019-01-25  Tom Tromey  <tom@tromey.com>
12121
12122         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12123
12124 2019-01-25  Tom Tromey  <tom@tromey.com>
12125
12126         * xtensa-linux-nat.c: Fix common/ includes.
12127         * xml-support.h: Fix common/ includes.
12128         * xml-support.c: Fix common/ includes.
12129         * x86-linux-nat.c: Fix common/ includes.
12130         * windows-nat.c: Fix common/ includes.
12131         * varobj.h: Fix common/ includes.
12132         * varobj.c: Fix common/ includes.
12133         * value.c: Fix common/ includes.
12134         * valops.c: Fix common/ includes.
12135         * utils.c: Fix common/ includes.
12136         * unittests/xml-utils-selftests.c: Fix common/ includes.
12137         * unittests/utils-selftests.c: Fix common/ includes.
12138         * unittests/unpack-selftests.c: Fix common/ includes.
12139         * unittests/tracepoint-selftests.c: Fix common/ includes.
12140         * unittests/style-selftests.c: Fix common/ includes.
12141         * unittests/string_view-selftests.c: Fix common/ includes.
12142         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12143         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12144         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12145         * unittests/rsp-low-selftests.c: Fix common/ includes.
12146         * unittests/parse-connection-spec-selftests.c: Fix common/
12147         includes.
12148         * unittests/optional-selftests.c: Fix common/ includes.
12149         * unittests/offset-type-selftests.c: Fix common/ includes.
12150         * unittests/observable-selftests.c: Fix common/ includes.
12151         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12152         * unittests/memrange-selftests.c: Fix common/ includes.
12153         * unittests/memory-map-selftests.c: Fix common/ includes.
12154         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12155         * unittests/function-view-selftests.c: Fix common/ includes.
12156         * unittests/environ-selftests.c: Fix common/ includes.
12157         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12158         * unittests/common-utils-selftests.c: Fix common/ includes.
12159         * unittests/cli-utils-selftests.c: Fix common/ includes.
12160         * unittests/array-view-selftests.c: Fix common/ includes.
12161         * ui-file.c: Fix common/ includes.
12162         * tui/tui-io.c: Fix common/ includes.
12163         * tracepoint.h: Fix common/ includes.
12164         * tracepoint.c: Fix common/ includes.
12165         * tracefile-tfile.c: Fix common/ includes.
12166         * top.h: Fix common/ includes.
12167         * top.c: Fix common/ includes.
12168         * thread.c: Fix common/ includes.
12169         * target/waitstatus.h: Fix common/ includes.
12170         * target/waitstatus.c: Fix common/ includes.
12171         * target.h: Fix common/ includes.
12172         * target.c: Fix common/ includes.
12173         * target-memory.c: Fix common/ includes.
12174         * target-descriptions.c: Fix common/ includes.
12175         * symtab.h: Fix common/ includes.
12176         * symfile.c: Fix common/ includes.
12177         * stap-probe.c: Fix common/ includes.
12178         * spu-linux-nat.c: Fix common/ includes.
12179         * sparc-nat.c: Fix common/ includes.
12180         * source.c: Fix common/ includes.
12181         * solib.c: Fix common/ includes.
12182         * solib-target.c: Fix common/ includes.
12183         * ser-unix.c: Fix common/ includes.
12184         * ser-tcp.c: Fix common/ includes.
12185         * ser-pipe.c: Fix common/ includes.
12186         * ser-base.c: Fix common/ includes.
12187         * selftest-arch.c: Fix common/ includes.
12188         * s12z-tdep.c: Fix common/ includes.
12189         * rust-exp.y: Fix common/ includes.
12190         * rs6000-aix-tdep.c: Fix common/ includes.
12191         * riscv-tdep.c: Fix common/ includes.
12192         * remote.c: Fix common/ includes.
12193         * remote-notif.h: Fix common/ includes.
12194         * remote-fileio.h: Fix common/ includes.
12195         * remote-fileio.c: Fix common/ includes.
12196         * regcache.h: Fix common/ includes.
12197         * regcache.c: Fix common/ includes.
12198         * record-btrace.c: Fix common/ includes.
12199         * python/python.c: Fix common/ includes.
12200         * python/py-type.c: Fix common/ includes.
12201         * python/py-inferior.c: Fix common/ includes.
12202         * progspace.h: Fix common/ includes.
12203         * producer.c: Fix common/ includes.
12204         * procfs.c: Fix common/ includes.
12205         * proc-api.c: Fix common/ includes.
12206         * printcmd.c: Fix common/ includes.
12207         * ppc-linux-nat.c: Fix common/ includes.
12208         * parser-defs.h: Fix common/ includes.
12209         * osdata.c: Fix common/ includes.
12210         * obsd-nat.c: Fix common/ includes.
12211         * nat/x86-linux.c: Fix common/ includes.
12212         * nat/x86-linux-dregs.c: Fix common/ includes.
12213         * nat/x86-dregs.h: Fix common/ includes.
12214         * nat/x86-dregs.c: Fix common/ includes.
12215         * nat/ppc-linux.c: Fix common/ includes.
12216         * nat/mips-linux-watch.h: Fix common/ includes.
12217         * nat/mips-linux-watch.c: Fix common/ includes.
12218         * nat/linux-waitpid.c: Fix common/ includes.
12219         * nat/linux-ptrace.h: Fix common/ includes.
12220         * nat/linux-ptrace.c: Fix common/ includes.
12221         * nat/linux-procfs.c: Fix common/ includes.
12222         * nat/linux-personality.c: Fix common/ includes.
12223         * nat/linux-osdata.c: Fix common/ includes.
12224         * nat/linux-namespaces.c: Fix common/ includes.
12225         * nat/linux-btrace.h: Fix common/ includes.
12226         * nat/linux-btrace.c: Fix common/ includes.
12227         * nat/fork-inferior.c: Fix common/ includes.
12228         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12229         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12230         * nat/aarch64-linux.c: Fix common/ includes.
12231         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12232         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12233         * namespace.h: Fix common/ includes.
12234         * mips-linux-tdep.c: Fix common/ includes.
12235         * minsyms.c: Fix common/ includes.
12236         * mi/mi-parse.h: Fix common/ includes.
12237         * mi/mi-main.c: Fix common/ includes.
12238         * mi/mi-cmd-env.c: Fix common/ includes.
12239         * memrange.h: Fix common/ includes.
12240         * memattr.c: Fix common/ includes.
12241         * maint.h: Fix common/ includes.
12242         * maint.c: Fix common/ includes.
12243         * main.c: Fix common/ includes.
12244         * machoread.c: Fix common/ includes.
12245         * location.c: Fix common/ includes.
12246         * linux-thread-db.c: Fix common/ includes.
12247         * linux-nat.c: Fix common/ includes.
12248         * linux-fork.c: Fix common/ includes.
12249         * inline-frame.c: Fix common/ includes.
12250         * infrun.c: Fix common/ includes.
12251         * inflow.c: Fix common/ includes.
12252         * inferior.h: Fix common/ includes.
12253         * inferior.c: Fix common/ includes.
12254         * infcmd.c: Fix common/ includes.
12255         * inf-ptrace.c: Fix common/ includes.
12256         * inf-child.c: Fix common/ includes.
12257         * ia64-linux-nat.c: Fix common/ includes.
12258         * i387-tdep.c: Fix common/ includes.
12259         * i386-tdep.c: Fix common/ includes.
12260         * i386-linux-tdep.c: Fix common/ includes.
12261         * i386-linux-nat.c: Fix common/ includes.
12262         * i386-go32-tdep.c: Fix common/ includes.
12263         * i386-fbsd-tdep.c: Fix common/ includes.
12264         * i386-fbsd-nat.c: Fix common/ includes.
12265         * guile/scm-type.c: Fix common/ includes.
12266         * guile/guile.c: Fix common/ includes.
12267         * go32-nat.c: Fix common/ includes.
12268         * gnu-nat.c: Fix common/ includes.
12269         * gdbthread.h: Fix common/ includes.
12270         * gdbarch-selftests.c: Fix common/ includes.
12271         * gdb_usleep.c: Fix common/ includes.
12272         * gdb_select.h: Fix common/ includes.
12273         * gdb_bfd.c: Fix common/ includes.
12274         * gcore.c: Fix common/ includes.
12275         * fork-child.c: Fix common/ includes.
12276         * findvar.c: Fix common/ includes.
12277         * fbsd-nat.c: Fix common/ includes.
12278         * event-top.c: Fix common/ includes.
12279         * event-loop.c: Fix common/ includes.
12280         * dwarf2read.c: Fix common/ includes.
12281         * dwarf2loc.c: Fix common/ includes.
12282         * dwarf2-frame.c: Fix common/ includes.
12283         * dwarf-index-cache.c: Fix common/ includes.
12284         * dtrace-probe.c: Fix common/ includes.
12285         * disasm-selftests.c: Fix common/ includes.
12286         * defs.h: Fix common/ includes.
12287         * csky-tdep.c: Fix common/ includes.
12288         * cp-valprint.c: Fix common/ includes.
12289         * cp-support.h: Fix common/ includes.
12290         * cp-support.c: Fix common/ includes.
12291         * corelow.c: Fix common/ includes.
12292         * completer.h: Fix common/ includes.
12293         * completer.c: Fix common/ includes.
12294         * compile/compile.c: Fix common/ includes.
12295         * compile/compile-loc2c.c: Fix common/ includes.
12296         * compile/compile-cplus-types.c: Fix common/ includes.
12297         * compile/compile-cplus-symbols.c: Fix common/ includes.
12298         * command.h: Fix common/ includes.
12299         * cli/cli-dump.c: Fix common/ includes.
12300         * cli/cli-cmds.c: Fix common/ includes.
12301         * charset.c: Fix common/ includes.
12302         * build-id.c: Fix common/ includes.
12303         * btrace.h: Fix common/ includes.
12304         * btrace.c: Fix common/ includes.
12305         * breakpoint.h: Fix common/ includes.
12306         * breakpoint.c: Fix common/ includes.
12307         * ax.h:
12308         (enum agent_op): Fix common/ includes.
12309         * ax-general.c (struct aop_map): Fix common/ includes.
12310         * ax-gdb.c: Fix common/ includes.
12311         * auxv.c: Fix common/ includes.
12312         * auto-load.c: Fix common/ includes.
12313         * arm-tdep.c: Fix common/ includes.
12314         * arch/riscv.c: Fix common/ includes.
12315         * arch/ppc-linux-common.c: Fix common/ includes.
12316         * arch/i386.c: Fix common/ includes.
12317         * arch/arm.c: Fix common/ includes.
12318         * arch/arm-linux.c: Fix common/ includes.
12319         * arch/arm-get-next-pcs.c: Fix common/ includes.
12320         * arch/amd64.c: Fix common/ includes.
12321         * arch/aarch64.c: Fix common/ includes.
12322         * arch/aarch64-insn.c: Fix common/ includes.
12323         * arch-utils.c: Fix common/ includes.
12324         * amd64-windows-tdep.c: Fix common/ includes.
12325         * amd64-tdep.c: Fix common/ includes.
12326         * amd64-sol2-tdep.c: Fix common/ includes.
12327         * amd64-obsd-tdep.c: Fix common/ includes.
12328         * amd64-nbsd-tdep.c: Fix common/ includes.
12329         * amd64-linux-tdep.c: Fix common/ includes.
12330         * amd64-linux-nat.c: Fix common/ includes.
12331         * amd64-fbsd-tdep.c: Fix common/ includes.
12332         * amd64-fbsd-nat.c: Fix common/ includes.
12333         * amd64-dicos-tdep.c: Fix common/ includes.
12334         * amd64-darwin-tdep.c: Fix common/ includes.
12335         * agent.c: Fix common/ includes.
12336         * ada-lang.h: Fix common/ includes.
12337         * ada-lang.c: Fix common/ includes.
12338         * aarch64-tdep.c: Fix common/ includes.
12339
12340 2019-01-25  Tom Tromey  <tom@tromey.com>
12341
12342         * common/create-version.sh: Use common/version.h.
12343
12344 2019-01-24  Pedro Alves  <palves@redhat.com>
12345
12346         * infrun.c (signal_stop, signal_print, signal_program)
12347         (signal_catch, signal_pass): Now arrays instead of pointers.
12348         (update_signals_program_target, do_target_resume)
12349         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12350         * linux-nat.c (linux_nat_target::pass_signals)
12351         (linux_nat_target::create_inferior, linux_nat_target::attach):
12352         Adjust.
12353         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12354         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12355         * procfs.c (procfs_target::pass_signals): Adjust.
12356         * record-full.c (record_full_target::resume): Adjust.
12357         * remote.c (remote_target::pass_signals)
12358         (remote_target::program_signals): Adjust.
12359         * target-debug.h (target_debug_print_signals): Now takes a
12360         gdb::array_view as parameter.  Adjust.
12361         * target.h (target_ops) <pass_signals, program_signals>: Replace
12362         pointer and length parameters with gdb::array_view.
12363         (target_pass_signals, target_program_signals): Likewise.
12364         * target-delegates.c: Regenerate.
12365
12366 2019-01-24  Pedro Alves  <palves@redhat.com>
12367
12368         * common/forward-scope-exit.h
12369         (forward_scope_exit::forward_scope_exit): Pass arguments to
12370         m_bind_function directly, instead of creating a std::bind and
12371         copying that.
12372
12373 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12374
12375         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12376         for static members.
12377         (pass_in_v_vfp_candidate): Likewise.
12378
12379 2019-01-23  Tom Tromey  <tom@tromey.com>
12380             Pedro Alves  <palves@redhat.com>
12381
12382         * regcache.c (class regcache_invalidator): Remove.
12383         (regcache::raw_write): Use make_scope_exit.
12384
12385 2019-01-23  Tom Tromey  <tom@tromey.com>
12386
12387         * ui-out.h (class ui_out_emit_type): Update comment.
12388
12389 2019-01-23  Tom Tromey  <tom@tromey.com>
12390
12391         * infrun.c (fetch_inferior_event): Update comment.
12392
12393 2019-01-23  Tom Tromey  <tom@tromey.com>
12394             Pedro Alves  <palves@redhat.com>
12395
12396         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12397         parameter.
12398         (fetch_inferior_event): Use SCOPE_EXIT.
12399
12400
12401 2019-01-23  Tom Tromey  <tom@tromey.com>
12402             Pedro Alves  <palves@redhat.com>
12403
12404         * infrun.c (disable_thread_events): Delete.
12405         (stop_all_threads): Use SCOPE_EXIT.
12406
12407 2019-01-23  Tom Tromey  <tom@tromey.com>
12408             Pedro Alves  <palves@redhat.com>
12409
12410         * symfile.c: Include forward-scope-exit.h.
12411         (clear_symtab_users_cleanup): Replace forward declaration with
12412         a FORWARD_SCOPE_EXIT.
12413         (syms_from_objfile_1): Use the forward_scope_exit and
12414         gdb::optional instead of cleanup_function.
12415         (reread_symbols): Use the forward_scope_exit instead of
12416         cleanup_function.
12417         (clear_symtab_users_cleanup): Remove function.
12418
12419 2019-01-23  Tom Tromey  <tom@tromey.com>
12420             Pedro Alves  <palves@redhat.com>
12421
12422         * linux-nat.c: Include scope-exit.h.
12423         (cleanup_target_stop): Remove.
12424         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12425         SCOPE_EXIT.
12426
12427 2019-01-23  Tom Tromey  <tom@tromey.com>
12428             Pedro Alves  <palves@redhat.com>
12429
12430         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12431         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12432
12433 2019-01-23  Tom Tromey  <tom@tromey.com>
12434             Andrew Burgess  <andrew.burgess@embecosm.com>
12435             Pedro Alves  <palves@redhat.com>
12436
12437         * infrun.c (fetch_inferior_event): Use scope_exit.
12438         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12439         * top.c (execute_command): Use scope_exit.
12440         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12441         * utils.c (do_bpstat_clear_actions_cleanup)
12442         (make_bpstat_clear_actions_cleanup): Remove.
12443
12444 2019-01-23  Tom Tromey  <tom@tromey.com>
12445             Pedro Alves  <palves@redhat.com>
12446
12447         * infrun.c: Include "common/scope-exit.h"
12448         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12449         (wait_for_inferior): Use SCOPE_EXIT.
12450         (fetch_inferior_event): Use scope_exit.
12451
12452 2019-01-23  Tom Tromey  <tom@tromey.com>
12453             Pedro Alves  <palves@redhat.com>
12454
12455         * breakpoint.c (create_breakpoint): Remove cleanup.
12456
12457 2019-01-23  Tom Tromey  <tom@tromey.com>
12458             Andrew Burgess  <andrew.burgess@embecosm.com>
12459             Pedro Alves  <palves@redhat.com>
12460
12461 2019-01-23  Pedro Alves  <palves@redhat.com>
12462
12463         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12464
12465 2019-01-23  Pedro Alves  <palves@redhat.com>
12466             Andrew Burgess  <andrew.burgess@embecosm.com>
12467
12468         * gdbthread.h: Include "common/forward-scope-exit.h".
12469         (scoped_finish_thread_state): Redefine custom class in terms of
12470         forward_scope_exit.
12471
12472 2019-01-23  Pedro Alves  <palves@redhat.com>
12473             Andrew Burgess  <andrew.burgess@embecosm.com>
12474
12475         * common/forward-scope-exit.h: New file.
12476
12477 2019-01-23  Pedro Alves  <palves@redhat.com>
12478             Andrew Burgess  <andrew.burgess@embecosm.com>
12479             Tom Tromey  <tom@tromey.com>
12480
12481         * common/scope-exit.h: New file.
12482
12483 2019-01-23  Pedro Alves  <palves@redhat.com>
12484
12485         * common/preprocessor.h (ESC): Rename to ...
12486         (ESC_PARENS): ... this.
12487         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12488         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12489
12490 2019-01-23  Tom Tromey  <tom@tromey.com>
12491
12492         * language.h (class scoped_switch_to_sym_language_if_auto):
12493         Initialize m_lang in both cases.
12494
12495 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12496
12497         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12498         with XCNEW.
12499
12500 2019-01-22  Tom Tromey  <tom@tromey.com>
12501
12502         * corelow.c: Do not include sys/file.h.
12503
12504 2019-01-22  Tom Tromey  <tom@tromey.com>
12505
12506         * tui/tui-wingeneral.h: Include gdb_curses.h.
12507
12508 2019-01-22  Tom Tromey  <tom@tromey.com>
12509
12510         * source-cache.h (class source_cache) <get_source_lines,
12511         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12512
12513 2019-01-22  Tom Tromey  <tom@tromey.com>
12514
12515         * remote-fileio.h (struct remote_target): Declare.
12516
12517 2019-01-22  Tom Tromey  <tom@tromey.com>
12518
12519         * python/py-arch.c: Do not include py-ref.h.
12520         * python/py-bpevent.c: Do not include py-ref.h.
12521         * python/py-cmd.c: Do not include py-ref.h.
12522         * python/py-continueevent.c: Do not include py-ref.h.
12523         * python/py-event.h: Do not include py-ref.h.
12524         * python/py-evtregistry.c: Do not include py-ref.h.
12525         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12526         * python/py-frame.c: Do not include py-ref.h.
12527         * python/py-framefilter.c: Do not include py-ref.h.
12528         * python/py-function.c: Do not include py-ref.h.
12529         * python/py-infevents.c: Do not include py-ref.h.
12530         * python/py-linetable.c: Do not include py-ref.h.
12531         * python/py-objfile.c: Do not include py-ref.h.
12532         * python/py-param.c: Do not include py-ref.h.
12533         * python/py-prettyprint.c: Do not include py-ref.h.
12534         * python/py-progspace.c: Do not include py-ref.h.
12535         * python/py-symbol.c: Do not include py-ref.h.
12536         * python/py-symtab.c: Do not include py-ref.h.
12537         * python/py-type.c: Do not include py-ref.h.
12538         * python/py-unwind.c: Do not include py-ref.h.
12539         * python/py-utils.c: Do not include py-ref.h.
12540         * python/py-value.c: Do not include py-ref.h.
12541         * python/py-varobj.c: Do not include py-ref.h.
12542         * python/py-xmethods.c: Do not include py-ref.h.
12543         * python/python.c: Do not include py-ref.h.
12544         * varobj.c: Do not include py-ref.h.
12545
12546 2019-01-22  Tom Tromey  <tom@tromey.com>
12547
12548         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12549         keyword for bcache.
12550
12551 2019-01-22  Tom Tromey  <tom@tromey.com>
12552
12553         * compile/compile-cplus-types.c: Remove a comment by #include.
12554
12555 2019-01-22  Tom Tromey  <tom@tromey.com>
12556
12557         * compile/gcc-c-plugin.h: Include compile-internal.h.
12558
12559 2019-01-22  Tom Tromey  <tom@tromey.com>
12560
12561         * stabsread.c (EXTERN): Do not define.
12562         (symnum, next_symbol_text_func, processing_gcc_compilation)
12563         (within_function, global_sym_chain, global_stabs)
12564         (previous_stab_code, this_object_header_files)
12565         (n_this_object_header_files)
12566         (n_allocated_this_object_header_files): Define.
12567         * stabsread.h (EXTERN): Never define.  Use "extern".
12568
12569 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12570
12571         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12572         history_value.
12573
12574 2019-01-21  Tom Tromey  <tom@tromey.com>
12575
12576         * ui-out.c: Fix includes.
12577         * tui/tui-source.c: Fix includes.
12578         * target.c: Fix includes.
12579         * remote.c: Fix includes.
12580         * regcache.c: Fix includes.
12581         * python/py-block.c: Fix includes.
12582         * printcmd.c: Fix includes.
12583         * or1k-tdep.c: Fix includes.
12584         * mi/mi-main.c: Fix includes.
12585         * m32r-tdep.c: Fix includes.
12586         * csky-tdep.c: Fix includes.
12587         * compile/compile-cplus-types.c: Fix includes.
12588         * cli/cli-interp.c: Fix includes.
12589
12590 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12591
12592         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12593         for padding.
12594
12595 2019-01-16  Tom Tromey  <tom@tromey.com>
12596
12597         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12598         earlier.
12599         (struct objfile) <msymbols_range>: Move from top level.
12600         <msymbols>: New method.
12601         (class objfile_msymbols): Remove.
12602         * symtab.c (default_collect_symbol_completion_matches_break_on):
12603         Update.
12604         * symmisc.c (dump_msymbols): Update.
12605         * stabsread.c (scan_file_globals): Update.
12606         * objc-lang.c (info_selectors_command, info_classes_command)
12607         (find_methods): Update.
12608         * minsyms.c (find_solib_trampoline_target): Update.
12609         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12610         * coffread.c (coff_symfile_read): Update.
12611         * ada-lang.c (ada_lookup_simple_minsym)
12612         (ada_collect_symbol_completion_matches): Update.
12613
12614 2019-01-16  Tom Tromey  <tom@tromey.com>
12615
12616         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12617         type.  Remove no-argument constructor.
12618         <iterator::operator++>: Simplify.
12619         <begin>: Update.
12620         <end>: Use minimal_symbol_count.
12621
12622 2019-01-16  Tom Tromey  <tom@tromey.com>
12623
12624         * objfiles.h (struct objfile) <psymtabs>: New method.
12625         (class objfile_psymtabs): Remove.
12626         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12627         typedef.
12628         <range>: New method.
12629         (require_partial_symbols): Change return type.
12630         * psymtab.c (require_partial_symbols)
12631         (psym_expand_symtabs_matching): Update.
12632         * mdebugread.c (parse_partial_symbols): Update.
12633         * dbxread.c (dbx_end_psymtab): Update.
12634
12635 2019-01-15  Tom Tromey  <tom@tromey.com>
12636
12637         * symtab.c (lookup_objfile_from_block)
12638         (lookup_symbol_in_objfile_symtabs)
12639         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12640         (find_line_symtab, info_sources_command)
12641         (default_collect_symbol_completion_matches_break_on)
12642         (make_source_files_completion_list): Update.
12643         * symmisc.c (print_objfile_statistics, dump_objfile)
12644         (maintenance_print_symbols, maintenance_info_symtabs)
12645         (maintenance_check_symtabs, maintenance_info_line_tables):
12646         Update.
12647         * source.c (select_source_symtab)
12648         (forget_cached_source_info_for_objfile): Update.
12649         * objfiles.h (class objfile_compunits): Remove.
12650         (struct objfile) <compunits_range>: New typedef.
12651         (compunits): New method.
12652         * objfiles.c (objfile_relocate1): Update.
12653         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12654         * maint.c (count_symtabs_and_blocks): Update.
12655         * linespec.c (iterate_over_all_matching_symtabs): Update.
12656         * cp-support.c (add_symbol_overload_list_qualified): Update.
12657         * coffread.c (coff_symtab_read): Update.
12658         * ada-lang.c (add_nonlocal_symbols)
12659         (ada_collect_symbol_completion_matches)
12660         (ada_add_global_exceptions): Update.
12661
12662 2019-01-15  Tom Tromey  <tom@tromey.com>
12663
12664         * progspace.h (program_space) <objfiles_safe_range>: New
12665         typedef.
12666         <objfiles_safe>: New method.
12667         * objfiles.h (class all_objfiles_safe): Remove.
12668         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12669         * jit.c (jit_inferior_exit_hook): Update.
12670
12671 2019-01-17  Tom Tromey  <tom@tromey.com>
12672
12673         * progspace.h (program_space) <objfiles_range>: New typedef.
12674         <objfiles>: New method.
12675         <objfiles_head>: Rename from objfiles.
12676         (object_files): Update.
12677         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12678         * guile/scm-pretty-print.c
12679         (ppscm_find_pretty_printer_from_objfiles): Update.
12680         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12681         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12682         Update.
12683         * python/py-progspace.c (pspy_get_objfiles): Update.
12684         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12685         Update.
12686         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12687         (objfpy_lookup_objfile_by_build_id): Update.
12688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12689         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12690         Update.
12691         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12692         (expand_symtab_containing_pc, lookup_objfile_from_block)
12693         (lookup_static_symbol, basic_lookup_transparent_type)
12694         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12695         (find_line_symtab, info_sources_command)
12696         (default_collect_symbol_completion_matches_break_on)
12697         (make_source_files_completion_list, find_main_name): Update.
12698         * symmisc.c (print_symbol_bcache_statistics)
12699         (print_objfile_statistics, maintenance_print_symbols)
12700         (maintenance_print_msymbols, maintenance_print_objfiles)
12701         (maintenance_info_symtabs, maintenance_check_symtabs)
12702         (maintenance_expand_symtabs, maintenance_info_line_tables):
12703         Update.
12704         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12705         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12706         (map_overlay_command, unmap_overlay_command)
12707         (simple_overlay_update, expand_symtabs_matching)
12708         (map_symbol_filenames): Update.
12709         * symfile-debug.c (set_debug_symfile): Update.
12710         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12711         Update.
12712         * source.c (select_source_symtab, forget_cached_source_info):
12713         Update.
12714         * solib.c (solib_read_symbols): Update.
12715         * solib-spu.c (append_ocl_sos): Update.
12716         * psymtab.c (maintenance_print_psymbols)
12717         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12718         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12719         * printcmd.c (info_symbol_command): Update.
12720         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12721         Update.
12722         * objfiles.h (class all_objfiles): Remove.
12723         * objfiles.c (have_partial_symbols, have_full_symbols)
12724         (have_minimal_symbols, qsort_cmp, update_section_map)
12725         (shared_objfile_contains_address_p)
12726         (default_iterate_over_objfiles_in_search_order): Update.
12727         * objc-lang.c (info_selectors_command, info_classes_command)
12728         (find_methods): Update.
12729         * minsyms.c (find_solib_trampoline_target): Update.
12730         * maint.c (maintenance_info_sections)
12731         (maintenance_translate_address, count_symtabs_and_blocks):
12732         Update.
12733         * main.c (captured_main_1): Update.
12734         * linux-thread-db.c (try_thread_db_load_from_pdir)
12735         (has_libpthread): Update.
12736         * linespec.c (iterate_over_all_matching_symtabs)
12737         (search_minsyms_for_name): Update.
12738         * jit.c (jit_find_objf_with_entry_addr): Update.
12739         * hppa-tdep.c (find_unwind_entry)
12740         (hppa_lookup_stub_minimal_symbol): Update.
12741         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12742         Update.
12743         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12744         (elf_gnu_ifunc_resolve_by_got): Update.
12745         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12746         * dwarf-index-write.c (save_gdb_index_command): Update.
12747         * cp-support.c (add_symbol_overload_list_qualified): Update.
12748         * breakpoint.c (create_overlay_event_breakpoint)
12749         (create_longjmp_master_breakpoint)
12750         (create_std_terminate_master_breakpoint)
12751         (create_exception_master_breakpoint): Update.
12752         * blockframe.c (find_pc_partial_function): Update.
12753         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12754         (ada_collect_symbol_completion_matches)
12755         (ada_add_global_exceptions): Update.
12756
12757 2019-01-17  Tom Tromey  <tom@tromey.com>
12758
12759         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12760         declare VEC.
12761         (solib_target_parse_libraries): Change return type.
12762         (library_list_start_segment, library_list_start_section)
12763         (library_list_end_library, library_list_start_library); Update.
12764         (solib_target_free_library_list): Remove.
12765         (solib_target_parse_libraries): Remove cleanup.  Change return
12766         type.
12767         (solib_target_current_sos): Update.
12768
12769 2019-01-17  Tom Tromey  <tromey@bapiya>
12770
12771         * valprint.c: Replace "the the" with "the".
12772         * symtab.c: Replace "the the" with "the".
12773         * solib.c: Replace "the the" with "the".
12774         * solib-dsbt.c: Replace "the the" with "the".
12775         * linespec.c: Replace "the the" with "the".
12776         * dwarf2loc.h: Replace "the the" with "the".
12777         * amd64-windows-tdep.c: Replace "the the" with "the".
12778         * aarch64-tdep.c: Replace "the the" with "the".
12779
12780 2019-01-16  Keith Seitz  <keiths@redhat.com>
12781
12782         PR gdb/23773
12783         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12784         <builder>: Rename to ..
12785         <m_builder>: ... this and make private.
12786         (dwarf2_cu::get_builder): New method.  Change all users of
12787         `builder' to use this method.
12788         (dwarf2_start_symtab): Move to ...
12789         (dwarf2_cu::start_symtab): ... here.  Update all callers
12790         (setup_type_unit_groups): Move to ...
12791         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12792         callers.
12793         (dwarf2_cu::reset_builder): New method.
12794         (process_full_compunit, process_full_type_unit): Use
12795         dwarf2_cu::reset_builder.
12796         (follow_die_offset): Record the ancestor CU if it is different
12797         from the followed DIE's CU.
12798         (follow_die_sig_1): Likewise.
12799
12800 2019-01-15  Tom Tromey  <tom@tromey.com>
12801
12802         * remote.c (class remote_state) <buf>: Now a char_vector.
12803         <buf_size>: Remove.
12804         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12805         parameter.
12806         (remote_target::getpkt_or_notif_sane_1)
12807         (remote_target::getpkt_sane)
12808         (remote_target::getpkt_or_notif_sane): Likewise.
12809         (class remote_target) <putpkt>: New overload.
12810         (remote_target::read_frame): Change type of "buf_p".  Remove
12811         sizeof_p parameter.
12812         (packet_ok): New overload.
12813         (packet_check_result): New overload.
12814         Update all uses.
12815
12816 2019-01-14  Tom Tromey  <tom@tromey.com>
12817
12818         * remote-notif.c (handle_notification, remote_notif_ack)
12819         (remote_notif_parse): Make "buf" const.
12820         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12821         const.
12822         (remote_notif_parse, remote_notif_ack, handle_notification):
12823         Likewise.
12824         * remote.c (remote_notif_stop_parse): Make "buf" const.
12825         (remote_target::remote_parse_stop_reply): Make "buf" const.
12826         (remote_notif_stop_ack): Make "buf" const.
12827
12828 2019-01-14  Tom Tromey  <tom@tromey.com>
12829
12830         * remote.c (remote_console_output): Make parameter const.
12831
12832 2019-01-14  Tom Tromey  <tom@tromey.com>
12833
12834         * target-debug.h (target_debug_print_signals): Constify.
12835         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12836         * procfs.c (procfs_target::pass_signals): Update.
12837         * linux-nat.c (linux_nat_target::pass_signals): Update.
12838         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12839         * target-delegates.c: Rebuild.
12840         * remote.c (remote_target::program_signals): Update.
12841         (remote_target::pass_signals): Update.
12842         * target.c (target_pass_signals): Constify argument.
12843         (target_program_signals): Likewise.
12844         * target.h (struct target_ops) <pass_signals, program_signals>:
12845         Constify argument.
12846         (target_pass_signals, target_program_signals): Constify argument.
12847
12848 2019-01-14  Tom Tromey  <tom@tromey.com>
12849
12850         PR tui/28819:
12851         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12852
12853 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12854
12855         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12856         field.
12857         * rs6000-tdep.c: Include reggroups.h.
12858         (IS_V_ALIAS_PSEUDOREG): Define.
12859         (rs6000_register_name): Return names for the "vX" aliases.
12860         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12861         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12862         aliases.  Call default_register_reggroup_p for all other
12863         pseudo-registers.
12864         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12865         New functions.
12866         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12867         Handle "vX" aliases.
12868         (v_alias_pseudo_register_collect): New function.
12869         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12870         (rs6000_gdbarch_init): Initialize "vX" aliases as
12871         pseudo-registers.  Restore registration of
12872         rs6000_pseudo_register_reggroup_p with
12873         set_tdesc_pseudo_register_reggroup_p.
12874
12875 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12876
12877         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12878         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12879         set_gdbarch_num_pseudo_regs.
12880
12881 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12882
12883         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12884         Remove arg prefixname, add do_set and do_show.
12885         Add member functions set_list and show_list.
12886         * cli/cli-style.c (class cli_style_option): Update accordingly.
12887         (style_set_list): Move to file scope.
12888         (style_show_list): Likewise.
12889         (set_style): Call help_list.
12890         (show_style): Call cmd_show_list.
12891         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12892         Update to use the new macro.
12893
12894 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12895
12896         * ada-lang.c (_initialize_ada_language): Expand the help text
12897         for the "catch exception" command.
12898
12899 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12900
12901         * symtab.c (matching_obj_sections): Initialize obj,
12902         declare it closer to its usage.
12903
12904 2019-01-10  Tom Tromey  <tom@tromey.com>
12905
12906         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12907         (basic_inf_threads_range): Remove.
12908         (inf_threads_range, inf_non_exited_threads_range)
12909         (safe_inf_threads_range): Use next_adapter.
12910
12911 2019-01-10  Keith Seitz  <keiths@redhat.com>
12912
12913         PR gdb/23712
12914         PR symtab/23010
12915         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12916         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12917
12918 2019-01-10  Keith Seitz  <keiths@redhat.com>
12919
12920         PR gdb/23712
12921         PR symtab/23010
12922         * dictionary.c (pending_to_vector): Remove.
12923         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12924         Remove _1 suffix, replacing functions of the same name.  Update
12925         all callers.
12926         (dict_create_hashed, dict_create_hashed_expandable)
12927         (dict_create_linear, dict_create_linear_expandable, dict_free)
12928         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12929         Make functions static.
12930
12931 2019-01-10  Keith Seitz  <keiths@redhat.com>
12932
12933         PR gdb/23712
12934         PR symtab/23010
12935         * dictionary.h (struct dictionary): Replace declaration with
12936         multidictionary.
12937         (dict_create_hashed, dict_create_hashed_expandable)
12938         (dict_create_linear, dict_create_linear_expandable)
12939         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12940         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12941         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12942         taking multidictionary argument.
12943         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12944         * block.h (struct block) <dict>: Change to multidictionary
12945         and rename `multidict'.
12946         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12947         symmisc.c: Update all dictionary references to multidictionary.
12948
12949 2019-01-10  Keith Seitz  <keiths@redhat.com>
12950
12951         PR gdb/23712
12952         PR symtab/23010
12953         * dictionary.c: Include unordered_map.
12954         (pending_to_vector): New function.
12955         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12956         Rewrite the non-"_1" functions to take vector instead
12957         of linked list.
12958         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12959         "new" _1 versions of the same name.
12960         (multidictionary): Define.
12961         (std::hash<enum language): New definition.
12962         (collate_pending_symbols_by_language, mdict_create_hashed)
12963         (mdict_create_hashed_expandable, mdict_create_linear)
12964         (mdict_create_linear_expandable, mdict_free)
12965         (find_language_dictionary, create_new_language_dictionary)
12966         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12967         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12968         (mdict_size, mdict_empty): New functions.
12969         * dictionary.h (mdict_iterator): Define.
12970
12971 2019-01-10  Pedro Alves  <palves@redhat.com>
12972
12973         * breakpoint.c (read_uploaded_action)
12974         (create_tracepoint_from_upload): Adjust to use
12975         gdb::unique_xmalloc_ptr.
12976         * ctf.c (ctf_write_uploaded_tp):
12977         (SET_ARRAY_FIELD): Use emplace_back.
12978         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12979         * tracefile-tfile.c (tfile_write_uploaded_tp):
12980         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12981         gdb::unique_xmalloc_ptr.
12982         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12983         at_string, cond_string, cmd_strings>: Replace char pointers
12984         with gdb::unique_xmalloc_ptr.
12985
12986 2019-01-10  Pedro Alves  <palves@redhat.com>
12987
12988         * solib-target.c (library_list_start_library): Don't xstrdup name.
12989
12990 2019-01-10  Pedro Alves  <palves@redhat.com>
12991
12992         * mdebugread.c (parse_partial_symbols): Use
12993         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12994
12995 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12996
12997         * linux-fork.c (scoped_switch_fork_info)
12998         <~scoped_switch_fork_info>: Fix incorrect variable name.
12999
13000 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13001
13002         * linux-fork.c (scoped_switch_fork_info)
13003         <scoped_switch_fork_info>: Make explicit.
13004         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13005
13006 2019-01-10  Tom Tromey  <tom@tromey.com>
13007
13008         * objfiles.h (objfile::reset_psymtabs): Update.
13009         * objfiles.c (objfile::objfile): Update.
13010         * psymtab.h (psymtab_storage::obstack): Update.
13011         (psymtab_storage::m_obstack): Use gdb::optional.
13012         (class psymtab_storage): Update comment.  Remove objfile
13013         parameter.
13014         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13015
13016 2019-01-10  Tom Tromey  <tom@tromey.com>
13017
13018         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13019         <free_psymtabs>: Now private.
13020         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13021         (allocate_psymtab): Use new method.
13022
13023 2019-01-10  Tom Tromey  <tom@tromey.com>
13024
13025         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13026         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13027         * mdebugread.c (parse_partial_symbols): Use
13028         allocate_dependencies.
13029         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13030         allocate_dependencies.
13031         (process_psymtab_comp_unit_reader)
13032         (build_type_psymtab_dependencies): Likewise.
13033         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13034
13035 2019-01-10  Tom Tromey  <tom@tromey.com>
13036
13037         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13038         PSYMBOL_SET_LANGUAGE.
13039         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13040
13041 2019-01-10  Tom Tromey  <tom@tromey.com>
13042
13043         * psymtab.h (psymtab_storage::obstack): New method.
13044         <m_obstack>: Rename from obstack; now private.
13045         * psymtab.c (psymtab_storage): Update.
13046         * dwarf2read.c (create_addrmap_from_index)
13047         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13048         Update.
13049
13050 2019-01-10  Tom Tromey  <tom@tromey.com>
13051
13052         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13053         * objfiles.h (objfile::reset_psymtabs): New method.
13054
13055 2019-01-10  Tom Tromey  <tom@tromey.com>
13056
13057         * symmisc.c (print_symbol_bcache_statistics): Update.
13058         (print_objfile_statistics): Update.
13059         * symfile.c (reread_symbols): Update.
13060         * psymtab.h (class psymtab_storage): New.
13061         * psymtab.c (psymtab_storage): New constructor.
13062         (~psymtab_storage): New destructor.
13063         (require_partial_symbols): Update.
13064         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13065         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13066         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13067         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13068         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13069         (start_psymtab_common, end_psymtab_common)
13070         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13071         (allocate_psymtab): Update.
13072         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13073         Update.
13074         (dump_psymtab_addrmap, maintenance_print_psymbols)
13075         (maintenance_check_psymtabs): Update.
13076         (class objfile_psymtabs): Move to objfiles.h.
13077         * psympriv.h (discard_psymtab): Now inline.
13078         (psymtab_discarder::psymtab_discarder): Update.
13079         (psymtab_discarder::~psymtab_discarder): Update.
13080         (ALL_OBJFILE_PSYMTABS): Rewrite.
13081         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13082         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13083         Remove fields.
13084         <partial_symtabs>: New field.
13085         (class objfile_psymtabs): Move from psymtab.h.  Update.
13086         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13087         psymbol_cache.
13088         (objfile::~objfile): Don't destroy psymbol_cache.
13089         * mdebugread.c (parse_partial_symbols): Update.
13090         * dwarf2read.c (create_addrmap_from_index)
13091         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13092         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13093         (add_partial_subprogram, dwarf2_ranges_read): Update.
13094         * dwarf-index-write.c (write_address_map)
13095         (write_one_signatured_type, recursively_write_psymbols)
13096         (class debug_names, class debug_names, write_psymtabs_to_index):
13097         Update.
13098
13099 2019-01-10  Tom Tromey  <tom@tromey.com>
13100
13101         * symtab.h (SYMBOL_SET_NAMES): Update.
13102         (symbol_set_names): Update.
13103         (MSYMBOL_SET_NAMES): Update.
13104         * symtab.c (symbol_set_names): Change argument to be an
13105         objfile_per_bfd_storage.
13106         * psymtab.c (add_psymbol_to_bcache): Update.
13107         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13108
13109 2019-01-10  Tom Tromey  <tom@tromey.com>
13110
13111         * symtab.c (create_demangled_names_hash): Change argument to be an
13112         objfile_per_bfd_storage.
13113         (symbol_set_names): Update.
13114
13115 2019-01-10  Tom Tromey  <tom@tromey.com>
13116
13117         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13118         init_psymbol_list.
13119         * psymtab.c (init_psymbol_list): Do nothing if already called.
13120         * psympriv.h (init_psymbol_list): Add comment.
13121         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13122         init_psymbol_list.
13123         * dbxread.c (dbx_symfile_read): Unconditionally call
13124         init_psymbol_list.
13125
13126 2019-01-10  Tom Tromey  <tom@tromey.com>
13127
13128         * xcoffread.c (scan_xcoff_symtab): Update.
13129         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13130         "where".
13131         * mdebugread.c (parse_partial_symbols)
13132         (handle_psymbol_enumerators): Update.
13133         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13134         * dbxread.c (read_dbx_symtab): Update.
13135         * psympriv.h (psymbol_placement): New enum.
13136         (add_psymbol_to_list): Update.
13137
13138 2019-01-10  Tom Tromey  <tom@tromey.com>
13139
13140         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13141         static_psymbols parameters.
13142         (scan_xcoff_symtab): Update.
13143         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13144         static_psymbols parameters.
13145         * psympriv.h (start_psymtab_common): Update.
13146         * mdebugread.c (parse_partial_symbols): Update.
13147         * dwarf2read.c (create_partial_symtab): Update.
13148         * dbxread.c (read_dbx_symtab): Update.
13149         (start_psymtab): Remove global_psymbols and static_psymbols
13150         parameters.
13151
13152 2019-01-10  Tom Tromey  <tom@tromey.com>
13153
13154         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13155         * psymtab.c (allocate_psymtab): Add comment.
13156         * psympriv.h (allocate_psymtab): Add comment.
13157         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13158         initializations.
13159         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13160
13161 2019-01-10  Tom Tromey  <tom@tromey.com>
13162
13163         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13164         Don't declare.
13165         * mipsread.c: Include mdebugread.h.
13166         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13167         Declare.
13168         * elfread.c: Include mdebugread.h.
13169
13170 2019-01-09  Tom Tromey  <tom@tromey.com>
13171
13172         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13173         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13174         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13175         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13176         (psym_lookup_symbol, psym_find_last_source_symtab)
13177         (psym_forget_cached_source_info, psym_print_stats)
13178         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13179         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13180         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13181         (psym_find_compunit_symtab_by_address)
13182         (maintenance_print_psymbols, maintenance_info_psymtabs)
13183         (maintenance_check_psymtabs): Use ranged for.
13184         * psymtab.h (class objfile_psymtabs): New.
13185         (require_partial_symbols): Return objfile_psymtabs.
13186         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13187
13188 2019-01-09  Tom Tromey  <tom@tromey.com>
13189
13190         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13191         (find_pc_mapped_section, list_overlays_command)
13192         (map_overlay_command, unmap_overlay_command)
13193         (simple_overlay_update): Use all_objfiles.
13194         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13195         * printcmd.c (info_symbol_command): Use all_objfiles.
13196         * objfiles.h (ALL_OBJSECTIONS): Remove.
13197         * maint.c (maintenance_translate_address): Use all_objfiles.
13198         * gcore.c (gcore_create_callback): Use all_objfiles.
13199         (objfile_find_memory_regions): Likewise.
13200
13201 2019-01-09  Tom Tromey  <tom@tromey.com>
13202
13203         * symtab.c (find_line_symtab, info_sources_command)
13204         (make_source_files_completion_list): Use objfile_compunits.
13205         * source.c (select_source_symtab): Use objfile_compunits.
13206         * objfiles.h (struct objfile): Update comment.
13207         (ALL_OBJFILES): Remove.
13208         (ALL_FILETABS): Remove.
13209         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13210         objfile_compunits.
13211
13212 2019-01-09  Tom Tromey  <tom@tromey.com>
13213
13214         * symmisc.c (print_objfile_statistics, dump_objfile)
13215         (maintenance_print_symbols): Use compunit_filetabs.
13216         * source.c (forget_cached_source_info_for_objfile): Use
13217         compunit_filetabs.
13218         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13219         (ALL_FILETABS): Use compunit_filetabs.
13220         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13221         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13222
13223 2019-01-09  Tom Tromey  <tom@tromey.com>
13224
13225         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13226         (compunit_filetabs): New.
13227         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13228         compunit_filetabs.
13229         (info_sources_command, make_source_files_completion_list): Remove
13230         declaration.
13231         * symmisc.c (print_objfile_statistics, dump_objfile)
13232         (maintenance_print_symbols): Remove declaration.
13233         (maintenance_info_symtabs): Use compunit_filetabs.
13234         (maintenance_info_line_tables): Likewise.
13235         * source.c (select_source_symtab): Change local variable name.
13236         (forget_cached_source_info_for_objfile): Remove declaration.
13237         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13238         * objfiles.c (objfile_relocate1): Remove declaration.
13239         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13240         declaration.
13241         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13242         * coffread.c (coff_symtab_read): Remove declaration.
13243         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13244         compunit_filetabs.
13245
13246 2019-01-09  Tom Tromey  <tom@tromey.com>
13247
13248         * symtab.c (lookup_objfile_from_block)
13249         (find_pc_sect_compunit_symtab, search_symbols)
13250         (default_collect_symbol_completion_matches_break_on): Use
13251         objfile_compunits.
13252         * objfiles.h (ALL_COMPUNITS): Remove.
13253         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13254         * cp-support.c (add_symbol_overload_list_qualified): Use
13255         objfile_compunits.
13256         * ada-lang.c (ada_collect_symbol_completion_matches)
13257         (ada_add_global_exceptions): Use objfile_compunits.
13258
13259 2019-01-09  Tom Tromey  <tom@tromey.com>
13260
13261         * source.c (select_source_symtab)
13262         (forget_cached_source_info_for_objfile): Remove declaration.
13263         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13264         declaration.
13265         * maint.c (count_symtabs_and_blocks): Remove declaration.
13266         * cp-support.c (add_symbol_overload_list_qualified): Remove
13267         declaration.
13268         * coffread.c (coff_symtab_read): Remove declaration.
13269         * symtab.c (lookup_symbol_in_objfile_symtabs)
13270         (basic_lookup_transparent_type_1): Use objfile_compunits.
13271         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13272         (info_sources_command, search_symbols)
13273         (default_collect_symbol_completion_matches_break_on)
13274         (make_source_files_completion_list): Remove declaration.
13275         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13276         (ada_collect_symbol_completion_matches)
13277         (ada_add_global_exceptions): Remove declaration.
13278         * linespec.c (iterate_over_all_matching_symtabs): Use
13279         objfile_compunits.
13280         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13281         (class objfile_compunits): New.
13282         (ALL_COMPUNITS): Use objfile_compunits.
13283         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13284         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13285         objfile_compunits.
13286         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13287
13288 2019-01-09  Tom Tromey  <tom@tromey.com>
13289
13290         * symtab.c (search_symbols)
13291         (default_collect_symbol_completion_matches_break_on): Use
13292         objfile_msymbols.
13293         * ada-lang.c (ada_lookup_simple_minsym)
13294         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13295         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13296         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13297         objfile_msymbols.
13298         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13299         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13300         * objc-lang.c (find_methods): Use objfile_msymbols.
13301         (info_selectors_command, info_classes_command): Likewise.
13302         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13303         * objfiles.h (class objfile_msymbols): New.
13304         (ALL_OBJFILE_MSYMBOLS): Remove.
13305         (ALL_MSYMBOLS): Remove.
13306
13307 2019-01-09  Tom Tromey  <tom@tromey.com>
13308
13309         * common/next-iterator.h (next_adapter): Add Iterator template
13310         parameter.
13311         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13312         (class all_objfiles_safe): New.
13313         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13314         * objfiles.c (put_objfile_before): Update comment.
13315         (add_separate_debug_objfile): Likewise.
13316         (free_all_objfiles): Use all_objfiles_safe.
13317         (objfile_purge_solibs): Likewise.
13318
13319 2019-01-09  Tom Tromey  <tom@tromey.com>
13320
13321         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13322         (expand_symtab_containing_pc, lookup_static_symbol)
13323         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13324         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13325         all_objfiles.
13326         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13327         * breakpoint.c (create_overlay_event_breakpoint)
13328         (create_longjmp_master_breakpoint)
13329         (create_std_terminate_master_breakpoint)
13330         (create_exception_master_breakpoint): Use all_objfiles.
13331         * linux-thread-db.c (try_thread_db_load_from_pdir)
13332         (has_libpthread): Use all_objfiles.
13333         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13334         * linespec.c (iterate_over_all_matching_symtabs)
13335         (search_minsyms_for_name): Use all_objfiles.
13336         * maint.c (maintenance_info_sections): Use all_objfiles.
13337         * main.c (captured_main_1): Use all_objfiles.
13338         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13339         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13340         * guile/scm-pretty-print.c
13341         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13342         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13343         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13344         (maintenance_print_msymbols): Use all_objfiles.
13345         * source.c (select_source_symtab): Use all_objfiles.
13346         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13347         * symfile.c (remove_symbol_file_command)
13348         (expand_symtabs_matching, map_symbol_filenames): Use
13349         all_objfiles.
13350         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13351         all_objfiles.
13352         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13353         * objc-lang.c (find_methods): Use all_objfiles.
13354         * objfiles.c (have_partial_symbols, have_full_symbols)
13355         (have_minimal_symbols, qsort_cmp)
13356         (default_iterate_over_objfiles_in_search_order): Use
13357         all_objfiles.
13358         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13359         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13360         (maintenance_check_psymtabs): Use all_objfiles.
13361         (ALL_PSYMTABS): Remove.
13362         * compile/compile-object-run.c (do_module_cleanup): Use
13363         all_objfiles.
13364         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13365         * cp-support.c (add_symbol_overload_list_qualified): Use
13366         all_objfiles.
13367         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13368         Use all_objfiles.
13369         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13370         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13371         all_objfiles.
13372         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13373         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13374         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13375         Uses all_objfiles.
13376         * solib.c (solib_read_symbols): Use all_objfiles
13377
13378 2019-01-09  Tom Tromey  <tom@tromey.com>
13379
13380         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13381         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13382         all_objfiles.
13383         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13384         * symmisc.c (print_symbol_bcache_statistics)
13385         (print_objfile_statistics, maintenance_print_objfiles)
13386         (maintenance_info_symtabs, maintenance_check_symtabs)
13387         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13388         all_objfiles.
13389         * source.c (forget_cached_source_info): Use all_objfiles.
13390         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13391         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13392         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13393         * objfiles.c (update_section_map): Use all_objfiles.
13394         (shared_objfile_contains_address_p): Likewise.
13395         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13396         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13397
13398 2019-01-09  Tom Tromey  <tom@tromey.com>
13399
13400         * common/next-iterator.h: New file.
13401         * objfiles.h (class all_objfiles): New.
13402         (struct objfile_iterator): New.
13403
13404 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13405
13406         * NEWS: Move the description of the changed "frame", "select-frame",
13407          and "info frame" commands to the Changed commands section.
13408
13409 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13410
13411         * gdbtypes.c (check_stub_method_group): Remove handling of old
13412         mangling schemes.
13413         * linespec.c (find_methods): Likewise.
13414         * stabsread.c (read_member_functions): Likewise.
13415         * valops.c (search_struct_method): Likewise.
13416         (value_struct_elt_for_reference): Likewise.
13417         * NEWS: Mention this change.
13418
13419 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13420
13421         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13422         print_source_lines.
13423         * source.c (print_source_lines_base): Update line number check.
13424         (print_source_lines): New function.
13425         (source_lines_range::source_lines_range): New function.
13426         * source.h (class source_lines_range): New class.
13427         (print_source_lines): New declaration.
13428
13429 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13430
13431         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13432
13433 2019-01-08  Tom Tromey  <tom@tromey.com>
13434             Simon Marchi  <simon.marchi@ericsson.com>
13435
13436         PR gdb/24060
13437         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13438         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13439         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13440         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13441         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13442         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13443
13444 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13445
13446         * source.c (select_source_symtab): Move header comment to
13447         declaration in source.h.
13448         (forget_cached_source_info_for_objfile): Likewise.
13449         (forget_cached_source_info): Likewise.
13450         (identify_source_line): Likewise.
13451         * source.h (identify_source_line): Move declaration from symtab.h
13452         and add comment from source.c
13453         (print_source_lines): Likewise.
13454         (forget_cached_source_info_for_objfile): Likewise.
13455         (forget_cached_source_info): Likewise.
13456         (select_source_symtab): Likewise.
13457         (enum print_source_lines_flag): Move definition from symtab.h.
13458         * symtab.h (identify_source_line): Move declaration to source.h.
13459         (print_source_lines): Likewise.
13460         (forget_cached_source_info_for_objfile): Likewise.
13461         (forget_cached_source_info): Likewise.
13462         (select_source_symtab): Likewise.
13463         (enum print_source_lines_flag): Move definition to source.h.
13464         * tui/tui-hooks.c: Add 'source.h' include.
13465
13466 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13467
13468         * source.c (print_source_lines_base): Handle requests to print
13469         reverse line number sequences, and guard against empty lines
13470         string.
13471
13472 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13473
13474         * source.c (print_source_lines_base): Fix skip of '\r' if next
13475         character is '\n'.
13476
13477 2019-01-06  Tom Tromey  <tom@tromey.com>
13478
13479         * c-exp.y (struct c_parse_state) <macro_original_text,
13480         expansion_obstack>: New member.
13481         (macro_original_text, expansion_obstack): Remove globals.
13482         (scan_macro_expansion, scanning_macro_expansion)
13483         (finished_macro_expansion): Update.
13484         (scan_macro_cleanup): Remove.
13485         (yylex, c_parse): Update.
13486
13487 2019-01-06  Tom Tromey  <tom@tromey.com>
13488
13489         * c-exp.y (struct c_parse_state) <strings>: New member.
13490         (operator_stoken): Update.
13491
13492 2019-01-06  Tom Tromey  <tom@tromey.com>
13493
13494         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13495         (union type_stack_elt) <typelist_val>: Now a pointer to
13496         std::vector.
13497         (type_stack_cleanup): Don't declare.
13498         (push_typelist): Update.
13499         * parse.c (pop_typelist): Return a std::vector.
13500         (push_typelist): Take a std::vector.
13501         (follow_types): Update.  Do not free args.
13502         (type_stack_cleanup): Remove.
13503         * c-exp.y (struct c_parse_state): New.
13504         (cpstate): New global.
13505         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13506         (nonempty_typelist): Update.
13507         (func_mod): Create a new vector.
13508         (c_parse): Create a c_parse_state.
13509         (check_parameter_typelist): Do not delete params.
13510         (function_method): Update.  Do not delete type_list.
13511
13512 2019-01-06  Tom Tromey  <tom@tromey.com>
13513
13514         PR gdb/28155:
13515         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13516         check_typedef.
13517         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13518         (print_return_value): Likewise.
13519
13520 2019-01-05  Tom Tromey  <tom@tromey.com>
13521
13522         * contrib/cleanup_check.py: Remove.
13523         * contrib/gcc-with-excheck: Remove.
13524         * contrib/exsummary.py: Remove.
13525         * contrib/excheck.py: Remove.
13526
13527 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13528
13529         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13530         NULL. Initialize tpprev to NULL instead of assigning it
13531         to NULL on the next statement.
13532         * windows-nat.c (windows_delete_thread): Remove check for
13533         main_thread_id before printing thread exit notifications.
13534         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13535         Remove thread ID check against main_thread_id.
13536         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13537         windows_delete_thread.
13538         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13539
13540 2019-01-04  Tom Tromey  <tom@tromey.com>
13541
13542         * compile/compile.c (_initialize_compile): Use upper case for
13543         metasyntactic variables.
13544         * symmisc.c (_initialize_symmisc): Use upper case for
13545         metasyntactic variables.
13546         * psymtab.c (_initialize_psymtab): Use upper case for
13547         metasyntactic variables.
13548         * demangle.c (demangle_command): Use upper case for metasyntactic
13549         variables.
13550         (_initialize_demangler): Likewise.
13551         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13552         variables.
13553
13554 2019-01-03  Tom Tromey  <tom@tromey.com>
13555
13556         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13557
13558 2019-01-03  Tom Tromey  <tom@tromey.com>
13559
13560         * python/py-symtab.c (salpy_str): Update.
13561         (struct salpy_sal_object) <symtab>: Now a PyObject.
13562         (salpy_dealloc): Update.
13563         (del_objfile_sal): Use gdbpy_ref.
13564
13565 2019-01-03  Tom Tromey  <tom@tromey.com>
13566
13567         * python/py-type.c (convert_field): Use new_reference.  Return
13568         gdbpy_ref.
13569         (make_fielditem): Return gdbpy_ref.
13570         (typy_fields): Update.
13571         (typy_getitem): Update.
13572         (field_name): Return gdbpy_ref.  Use new_reference.
13573         (typy_iterator_iternext): Update.
13574
13575 2019-01-03  Tom Tromey  <tom@tromey.com>
13576
13577         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13578
13579 2019-01-03  Tom Tromey  <tom@tromey.com>
13580
13581         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13582         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13583         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13584         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13585         (pspy_set_type_printers): Likewise.
13586         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13587         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13588         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13589         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13590         (objfpy_set_type_printers): Likewise.
13591
13592 2019-01-03  Tom Tromey  <tom@tromey.com>
13593
13594         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13595         (gdbpy_print_stack): Use gdbpy_err_fetch.
13596         * python/python-internal.h (class gdbpy_err_fetch): New class.
13597         (class gdbpy_enter) <m_error_type, m_error_value,
13598         m_error_traceback>: Remove.
13599         <m_error>: New member.
13600         (gdbpy_exception_to_string): Don't declare.
13601         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13602         * python/py-value.c (convert_value_from_python): Use
13603         gdbpy_err_fetch.
13604         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13605         gdbpy_exception_to_string.
13606         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13607         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13608         gdbpy_err_fetch.
13609
13610 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13611
13612         * linux-nat.c (delete_lwp_cleanup): Delete.
13613         (struct lwp_deleter): New struct.
13614         (lwp_info_up): New typedef.
13615         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13616         lwp_info_up.
13617
13618 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13619
13620         * linux-fork.c (class scoped_switch_fork_info): New class.
13621         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13622
13623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13624
13625         * valops.c (find_overload_match): Remove use of null_cleanup, and
13626         calls to do_cleanups.
13627
13628 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13629
13630         * compile/compile-cplus-types.c
13631         (compile_cplus_instance::decl_name): Handle changes to
13632         cp_func_name.
13633         * cp-support.c (cp_func_name): Update header comment, update
13634         return type.
13635         * cp-support.h (cp_func_name): Update return type in declaration.
13636         * valops.c (find_overload_match): Move temp_func local to top
13637         level of function and change its type.  Use temp_func to hold and
13638         delete temporary string obtained from cp_func_name.
13639
13640 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13641
13642         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13643         gdb::char_vector, remove cleanup, and update uses of `msg`.
13644
13645 2019-01-03  Jim Wilson  <jimw@sifive.com>
13646
13647         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13648
13649 2019-01-02  Tom Tromey  <tom@tromey.com>
13650
13651         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13652         (tdesc_parse_xml): Remove cleanups.
13653         * target-descriptions.h (make_cleanup_free_target_description):
13654         Don't declare.
13655         (target_desc_deleter): New struct.
13656         (target_desc_up): New typedef.
13657         * target-descriptions.c (target_desc_deleter::operator()): Rename
13658         from free_target_description.
13659         (make_cleanup_free_target_description): Remove.
13660
13661 2019-01-02  Tom Tromey  <tom@tromey.com>
13662
13663         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13664         constructor, destructor.
13665         (linespec_parser): Remove typedef.
13666         (~linespec_parser): Rename from linespec_parser_delete.
13667         (linespec_lex_to_end, linespec_complete_label)
13668         (linespec_complete): Update.
13669         (decode_line_full): Remove cleanups.
13670         (decode_line_1): Update.
13671
13672 2019-01-02  Tom Tromey  <tom@tromey.com>
13673
13674         * python/python-internal.h (inferior_to_inferior_object): Change
13675         return type.
13676         * python/py-exitedevent.c (create_exited_event_object): Update.
13677         * python/py-inferior.c (inferior_to_inferior_object): Return
13678         gdbpy_ref.
13679         (python_new_inferior, python_inferior_deleted)
13680         (thread_to_thread_object, delete_thread_object)
13681         (build_inferior_list, gdbpy_selected_inferior): Update.
13682         * python/py-infthread.c (create_thread_object): Update.  Also fail
13683         if inferior_to_inferior_object fails.
13684
13685 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13686
13687         * inferior.h (class inferior) <displaced_step_state>: New field.
13688         * infrun.h (struct displaced_step_state): Move here from
13689         infrun.c.  Initialize fields, add constructor.
13690         <inf>: Remove field.
13691         <reset>: New method.
13692         * infrun.c (struct displaced_step_inferior_state): Move to
13693         infrun.h.
13694         (displaced_step_inferior_states): Remove.
13695         (get_displaced_stepping_state): Adust.
13696         (displaced_step_in_progress_any_inferior): Adjust.
13697         (displaced_step_in_progress_thread): Adjust.
13698         (displaced_step_in_progress): Adjust.
13699         (add_displaced_stepping_state): Remove.
13700         (get_displaced_step_closure_by_addr): Adjust.
13701         (remove_displaced_stepping_state): Remove.
13702         (infrun_inferior_exit): Call displaced_step_state.reset.
13703         (use_displaced_stepping): Don't check for NULL.
13704         (displaced_step_prepare_throw): Call
13705         get_displaced_stepping_state.
13706         (displaced_step_fixup): Don't check for NULL.
13707         (prepare_for_detach): Don't check for NULL.
13708
13709 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13710
13711         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13712          in case of call that did not complete.
13713
13714 2019-01-02  Andrey Utkin  <autkin@undo.io>
13715
13716         * symfile.c (find_separate_debug_file): Fix search of debug files for
13717         remote debuggee.
13718
13719 2019-01-02  Tom Tromey  <tom@tromey.com>
13720
13721         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13722         indentation.
13723         * python/py-frame.c (frapy_older): Remove cast.
13724         (frapy_newer): Likewise.
13725         * python/py-breakpoint.c (local_setattro): Remove cast.
13726         * python/py-arch.c (archpy_name): Remove local variable.
13727         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13728
13729 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13730
13731         * unittests/basic_string_view/element_access/char/empty.cc:
13732         Fix year range in copyright header.
13733
13734 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13735
13736         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13737         Delete.
13738         <operator==>: Update with for removed field.
13739         <hash>: Likewise.
13740         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13741         <isa_features>: ...this.
13742         <abi_features>: New field.
13743         (riscv_isa_flen): Update comment.
13744         (riscv_abi_xlen): New declaration.
13745         (riscv_abi_flen): New declaration.
13746         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13747         isa_features.
13748         (riscv_abi_xlen): New function.
13749         (riscv_isa_flen): Update to get answer from isa_features.
13750         (riscv_abi_flen): New function.
13751         (riscv_has_fp_abi): Update to get answer from abi_features.
13752         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13753         xlen and flen.
13754         (riscv_call_info) <xlen, flen>: Update comment.
13755         (riscv_call_arg_struct): Remove invalid assertions
13756         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13757         is removed.
13758         (riscv_gdbarch_init): Gather isa features and abi features
13759         separately, ensure both match on the gdbarch when reusing an old
13760         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13761         a target with 64-bit float hardware.
13762
13763 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13764
13765         * source.c (search_command_helper): Stop reverse search
13766         when line 1 has been searched.
13767
13768 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13769
13770         * record-full.c (record_full_base_target::close): Rewrite
13771         record_full_core_buf_list free logic.
13772
13773 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13774
13775         * break-catch-syscall.c (print_one_catch_syscall): xfree
13776         the last text.
13777
13778 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13779
13780         * top.c (print_gdb_version): Update Copyright year in version
13781         message.
13782
13783 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13784
13785         Update copyright year range in all GDB files.
13786
13787 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13788
13789         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13790
13791 For older changes see ChangeLog-2018.
13792 \f
13793 Local Variables:
13794 mode: change-log
13795 left-margin: 8
13796 fill-column: 74
13797 version-control: never
13798 coding: utf-8
13799 End:
13800