gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_erase_source_content)
   4         (tui_show_source_content, tui_show_exec_info_content)
   5         (tui_erase_exec_info_content): Use refresh_window method.
   6         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
   7         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
   8         from tui_refresh_win.
   9         (tui_data_window::refresh_window): New method.
  10         (tui_win_info::refresh, tui_source_window_base::refresh)
  11         (tui_refresh_all): Use refresh_window method.
  12         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
  13         method.
  14         * tui/tui-regs.c (tui_display_register): Call refresh_window
  15         method.
  16         * tui/tui-layout.c (show_source_disasm_command)
  17         (show_source_or_disasm_and_command): Call refresh_window method.
  18         * tui/tui-data.h (struct tui_gen_win_info)
  19         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
  20         New method.
  21
  22 2019-06-25  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui.c (tui_rl_other_window, tui_enable)
  25         (tui_is_window_visible, tui_get_command_dimension): Update.
  26         * tui/tui-winsource.c (tui_update_source_window_as_is)
  27         (tui_clear_source_content, tui_erase_source_content)
  28         (tui_show_source_line, tui_source_window_base::refill)
  29         (tui_source_window_base::do_scroll_horizontal)
  30         (tui_source_window_base::set_is_exec_point_at)
  31         (tui_update_breakpoint_info, tui_set_exec_info_content)
  32         (tui_alloc_source_buffer, tui_line_is_displayed)
  33         (tui_addr_is_displayed): Update.
  34         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  35         (tui_check_and_display_highlight_if_needed)
  36         (tui_win_info::make_visible, tui_win_info::refresh)
  37         (tui_refresh_all): Update.
  38         * tui/tui-windata.c (tui_first_data_item_displayed)
  39         (tui_delete_data_content_windows, tui_erase_data_content)
  40         (tui_display_all_data, tui_data_window::refresh_all)
  41         (tui_check_data_values): Update.
  42         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
  43         (tui_set_win_focus_to, tui_win_info::forward_scroll)
  44         (tui_win_info::backward_scroll, tui_refresh_all_win)
  45         (tui_resize_all, tui_set_focus, tui_all_windows_info)
  46         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
  47         (tui_source_window_base::set_new_height)
  48         (tui_data_window::set_new_height)
  49         (make_invisible_and_set_new_height)
  50         (make_visible_with_new_height, new_height_ok)
  51         (parse_scrolling_args): Update.
  52         * tui/tui-stack.c (tui_show_frame_info): Update.
  53         * tui/tui-source.c (tui_set_source_content)
  54         (tui_set_source_content_nil, tui_source_is_displayed)
  55         (tui_source_window::do_scroll_vertical): Update.
  56         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  57         (tui_display_registers_from, tui_display_reg_element_at_line)
  58         (tui_check_register_values, tui_reg_command): Update.
  59         * tui/tui-layout.c (tui_default_win_height)
  60         (show_source_disasm_command, show_data, init_and_make_win)
  61         (show_source_or_disasm_and_command): Update.
  62         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
  63         (tui_redisplay_readline, tui_mld_flush)
  64         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
  65         (tui_getc): Update.
  66         * tui/tui-disasm.c (tui_set_disassem_content)
  67         (tui_disasm_window::do_scroll_vertical): Update.
  68         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
  69         Now virtual.
  70         (struct tui_win_info): Derive from tui_gen_win_info.
  71         <~tui_win_info>: Mark as override.
  72         <generic>: Remove member.
  73         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
  74         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
  75         (~tui_data_window, ~tui_win_info)
  76         (tui_free_all_source_wins_content): Update.
  77         * tui/tui-command.c (tui_refresh_cmd_win): Update.
  78
  79 2019-06-25  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-layout.c (init_and_make_win): Use new.
  82         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
  83         destructor, initializers.
  84         (tui_alloc_generic_win_info): Don't declare.
  85         * tui/tui-data.c (_locator): Add argument to constructor.
  86         (source_win, disasm_win): New globals.
  87         (exec_info): Remove.
  88         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  89         Update.
  90         (tui_alloc_generic_win_info): Remove.
  91         (init_content_element): Use new.
  92         (tui_win_info::tui_win_info): Update.
  93         (free_content_elements) <case DATA_WIN>: Use delete.
  94
  95 2019-06-25  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-wingeneral.c (tui_refresh_win): Update.
  98         * tui/tui-windata.c (tui_first_data_item_displayed)
  99         (tui_delete_data_content_windows): Update.
 100         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 101         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 102         (tui_display_registers_from, tui_check_register_values): Update.
 103         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 104         pointer.
 105         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 106         window.
 107         (tui_free_data_content): Update.
 108         (free_content_elements) <case DATA_WIN>: Free the window.
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 113         Update.
 114         * tui/tui-layout.c (make_command_window)
 115         (show_source_disasm_command, show_data, init_and_make_win)
 116         (show_source_or_disasm_and_command): Update.
 117         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 118         method.
 119         <can_highight, is_highlighted>: Now bool.
 120         (tui_set_win_highlight): Don't declare.
 121         * tui/tui-data.c (tui_set_win_highlight): Remove.
 122
 123 2019-06-25  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-wingeneral.c (make_visible): Remove check of window
 126         type.
 127
 128 2019-06-25  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-win.c (tui_win_info::max_height)
 131         (tui_cmd_window::max_height): New methods.
 132         (new_height_ok): Call max_height.
 133         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 134         <max_height>: New method.
 135
 136 2019-06-25  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-win.c (tui_source_window_base::set_new_height)
 139         (tui_data_window::set_new_height): New methods.
 140         (make_invisible_and_set_new_height): Call set_new_height method.
 141         * tui/tui-data.h (struct tui_win_info)
 142         (struct tui_source_window_base, struct tui_data_window)
 143         <set_new_height>: New method.
 144
 145 2019-06-25  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 148         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 149         tui_refresh_data_win.
 150         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 151         method.
 152         (tui_refresh_all_win): Call the refresh_all method.
 153         (tui_set_focus): Likewise.
 154         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 155         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 156         Likewise.
 157
 158 2019-06-25  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-winsource.h (tui_refill_source_window)
 161         (tui_set_is_exec_point_at): Don't declare.
 162         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 163         (tui_source_window_base::refill): Rename from
 164         tui_refill_source_window.
 165         (tui_source_window_base::do_scroll_horizontal): Update.
 166         (tui_source_window_base::set_is_exec_point_at): Rename from
 167         tui_set_is_exec_point_at.
 168         (tui_update_all_breakpoint_info): Update.
 169         * tui/tui-stack.c (tui_show_frame_info): Update.
 170         * tui/tui-layout.c (show_data): Add cast.
 171         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 172         * tui/tui-data.h (struct tui_source_window_base) <refill,
 173         set_is_exec_point_at>: New methods.
 174         (tui_source_windows, tui_add_to_source_windows): Update types.
 175         (tui_add_to_source_windows): Remove redundant declaration.
 176         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 177         (tui_source_windows): Change return type.
 178         (tui_clear_source_windows_detail): Update.
 179         (tui_add_to_source_windows): Change type of parameter.
 180         (tui_free_all_source_wins_content): Update.
 181
 182 2019-06-25  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-wingeneral.c (tui_win_info::refresh)
 185         (tui_source_window_base::refresh): New methods.
 186         (tui_refresh_all): Call the refresh method.
 187         * tui/tui-data.h (struct tui_win_info)
 188         (struct tui_source_window_base) <refresh>: New method.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui.h (tui_is_window_visible): Return bool.
 193         * tui/tui.c (tui_is_window_visible): Return bool.
 194         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 195         (tui_make_visible, tui_make_invisible)
 196         (tui_win_info::make_visible)
 197         (tui_source_window_base::make_visible, make_all_visible)
 198         (tui_make_all_visible, tui_make_all_invisible): Update.
 199         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 200         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 201         bool.
 202         (struct tui_win_info, struct tui_source_window_base)
 203         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 204         * tui/tui-data.c (tui_init_generic_part): Update.
 205
 206 2019-06-25  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 209         (tui_source_window_base::make_visible): New methods.
 210         (make_all_visible): Make method call.
 211         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 212         (struct tui_source_window_base, struct tui_cmd_window): Override
 213         make_visible.
 214         (tui_win_is_source_type): Don't declare.
 215         * tui/tui-data.c (tui_win_is_source_type): Remove.
 216
 217 2019-06-25  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 220         NULL check.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 225         Inline constructor.  Add initializers for members.
 226         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 227         constructors; now inline in class.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-regs.c (tui_show_registers): Update.
 232         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 233         bool.
 234         * tui/tui-data.c (tui_data_window::clear_detail)
 235         (tui_data_window): Update.
 236
 237 2019-06-25  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-windata.c (tui_display_all_data)
 240         (tui_display_data_from_line, tui_display_data_from)
 241         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 242         Update.
 243         * tui/tui-regs.c (tui_last_regs_line_no)
 244         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 245         (tui_show_registers, tui_show_register_group)
 246         (tui_display_registers_from, tui_display_reg_element_at_line)
 247         (tui_display_registers_from_line, tui_check_register_values)
 248         (tui_reg_next, tui_reg_prev): Update.
 249         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 250         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 251         tui_data_window.
 252         (struct tui_win_info) <detail>: Remove.  Add new fields from
 253         tui_data_info.
 254         (TUI_DATA_WIN): Add cast.
 255         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 256         (~tui_data_window): Simplify.
 257
 258 2019-06-25  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-layout.c (show_source_disasm_command)
 261         (show_source_or_disasm_and_command): Update.
 262         * tui/tui-io.c (update_cmdwin_start_line)
 263         (tui_redisplay_readline): Update.
 264         * tui/tui-data.h (struct tui_command_info): Remove.
 265         (struct tui_win_info) <detail>: Remove command_info member.
 266         (struct tui_data_window) <start_line>: New member, from
 267         tui_command_info.
 268         (TUI_CMD_WIN): Add casts.
 269
 270 2019-06-25  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-winsource.c (tui_update_source_window)
 273         (tui_refill_source_window)
 274         (tui_source_window_base::do_scroll_horizontal)
 275         (tui_update_breakpoint_info, tui_set_exec_info_content)
 276         (tui_show_exec_info_content, tui_erase_exec_info_content)
 277         (tui_clear_exec_info_content): Update.
 278         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 279         Update.
 280         * tui/tui-win.c (make_invisible_and_set_new_height)
 281         (make_visible_with_new_height): Update.
 282         * tui/tui-source.c (tui_set_source_content)
 283         (tui_show_symtab_source): Update.
 284         * tui/tui-layout.c (extract_display_start_addr)
 285         (show_source_disasm_command, show_data)
 286         (make_source_or_disasm_window)
 287         (show_source_or_disasm_and_command): Update.
 288         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 289         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 290         "gdbarch".
 291         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 292         to tui_source_window_base.
 293         (struct tui_win_info) <detail>: Remove source_info member.
 294         (struct tui_source_window_base) <has_locator>: Inline.
 295         Move contents from tui_source_info; rename has_locator member to
 296         m_has_locator.
 297         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 298         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 299         header file.
 300         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 301         Simplify.
 302         (tui_free_all_source_wins_content): Cast to
 303         tui_source_window_base.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-win.c (make_invisible_and_set_new_height)
 308         (make_visible_with_new_height): Call has_locator method.
 309         * tui/tui-layout.c (show_source_disasm_command, show_data)
 310         (show_source_or_disasm_and_command): Update for bool change.
 311         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 312         (tui_win_info) <has_locator>: New method.
 313         (struct tui_source_window_base) <has_locator>: New method.
 314         (tui_win_has_locator): Don't declare.
 315         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 316         from tui_win_has_locator.
 317         (tui_source_window_base): Use false, not FALSE.
 318
 319 2019-06-25  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 322         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 323         clear_detail method directly.
 324         (tui_clear_win_detail): Remove.
 325
 326 2019-06-25  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 329         "this", not TUI_DISASM_WIN.
 330
 331 2019-06-25  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 334         declare.
 335         * tui/tui-winsource.c
 336         (tui_source_window_base::do_scroll_horizontal): Rename from
 337         tui_horizontal_source_scroll.
 338         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 339         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 340         from tui_vertical_data_scroll.
 341         * tui/tui-win.h (tui_scroll): Don't declare.
 342         * tui/tui-win.c (tui_win_info::forward_scroll)
 343         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 344         (tui_win_info::right_scroll): Rename and update.
 345         (tui_scroll_forward_command, tui_scroll_backward_command)
 346         (tui_scroll_left_command, tui_scroll_right_command): Update.
 347         (tui_scroll): Remove.
 348         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 349         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 350         from tui_vertical_source_scroll.
 351         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 352         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 353         from tui_vertical_disassem_scroll.
 354         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 355         do_scroll_horizontal>: New methods.
 356         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 357         Likewise.
 358         (struct tui_source_window_base): Add do_scroll_horizontal.
 359         (struct tui_source_window, struct tui_disasm_window): Add
 360         do_scroll_vertical.
 361         (struct tui_data_window, struct tui_cmd_window): Add
 362         do_scroll_horizontal and do_scroll_vertical.
 363         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 364
 365 2019-06-25  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-data.h (struct tui_source_window_base): New struct.
 368         (struct tui_source_window): Derive from tui_source_window_base.
 369         (struct tui_disasm_window): New struct.
 370         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 371         from tui_source_window::clear_detail.
 372         (tui_source_window_base): Rename from tui_source_window.
 373         (~tui_source_window_base): Rename from ~tui_source_window.
 374         (tui_alloc_win_info): Create a tui_disasm_window.
 375
 376 2019-06-25  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-data.h (struct tui_source_window)
 379         (struct tui_data_window): Declare destructors.
 380         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 381         destructors.
 382         (tui_win_info): Simplify.
 383
 384 2019-06-25  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-winsource.c (tui_display_main)
 387         (tui_update_source_windows_with_addr)
 388         (tui_update_all_breakpoint_info): Update.
 389         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 390         (new_height_ok, parse_scrolling_args): Update.
 391         * tui/tui-stack.c (tui_show_frame_info): Update.
 392         * tui/tui-data.h (struct tui_list): Remove.
 393         (tui_source_windows): Return a reference to a std::vector.
 394         * tui/tui-data.c (source_windows): Now a std::vector.
 395         (tui_source_windows): Change return type.
 396         (tui_clear_source_windows): Rewrite.
 397         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 398         (tui_free_all_source_wins_content): Rewrite.
 399
 400 2019-06-25  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 403         (struct tui_data_window, struct tui_cmd_window): Declare
 404         clear_detail method.
 405         * tui/tui-data.c (tui_source_window::clear_detail)
 406         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 407         methods.
 408         (tui_clear_win_detail): Simplify.
 409
 410 2019-06-25  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-layout.c (make_source_window, make_disasm_window)
 413         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 414         Return the new window.
 415         (show_source_disasm_command, show_data)
 416         (show_source_or_disasm_and_command): Update.
 417
 418 2019-06-25  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 421         parameter.  Return the new window.
 422         (show_source_disasm_command): Update and remove NULL check.
 423         (show_source_or_disasm_and_command): Update.
 424
 425 2019-06-25  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 428
 429 2019-06-25  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-data.h (struct tui_win_info): Make constructor
 432         protected.  Make destructor virtual.  Add initializers.
 433         (tui_source_window, tui_data_window, tui_cmd_window): New
 434         classes.
 435         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 436         constructor.  Add "type" parameter.
 437         (tui_source_window, tui_data_window, tui_cmd_window): New
 438         constructors.
 439         (tui_alloc_win_info): Instantiate the appropriate subclass.
 440
 441 2019-06-25  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-win.c (tui_resize_all): Use delete.
 444         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 445         destructor.
 446         (tui_free_window): Don't declare.
 447         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 448         Update.
 449
 450 2019-06-25  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-data.h (struct tui_win_info): Add constructor.
 453         * tui/tui-data.c (tui_alloc_win_info): Use new.
 454         (tui_free_window): Use delete.
 455
 456 2019-06-22  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 459         declare.
 460         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 461
 462 2019-06-22  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 465         declare.
 466         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 467
 468 2019-06-22  Tom de Vries  <tdevries@suse.de>
 469
 470         * dwarf2read.c (create_addrmap_from_aranges)
 471         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 472         instead of '%zu'.
 473
 474 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 475
 476         * dwarf2read.h (dwarf2_section_info_def): Remove.
 477         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 478         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 479         std::vector<dwarf2_section_info>.
 480         (struct dwo_file) <~dwo_file>: Remove.
 481         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 482         types field.
 483         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 484         (dwarf2_read_debug_names): Likewise.
 485         (create_debug_types_hash_table): Change parameter type to
 486         array_view, adjust code accordingly.
 487         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 488         (partial_die_info::fixup): Likewise.
 489         (determine_prefix): Likewise.
 490         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 491
 492 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 493
 494         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 495         gdb_bfd_ref_ptr.
 496         <~dwo_file>: Remove call to gdb_bfd_unref.
 497         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 498         gdb_bfd_ref_ptr::get.
 499
 500 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 501
 502         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 503         type to htab_up.
 504         * dwarf2read.c (struct dwo_file): Initialize fields.
 505         <~dwo_file>: New.
 506         (free_dwo_file): Remove, move content to ~dwo_file.
 507         (struct dwo_file_deleter): Remove.
 508         (dwo_file_up>: Remove custom deleter.
 509         (free_dwo_files): Remove.
 510         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 511         dwo_files.
 512         (process_skeletonless_type_units): Call unique_ptr::get.
 513         (allocate_dwo_file_hash_table): Add deleter to created hash
 514         table.  Change return type to htab_up.
 515         (lookup_dwo_file_slot): Don't memset dwo_file, call
 516         unique_ptr::get.
 517         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 518         (create_dwo_unit_in_dwp_v2): Likewise.
 519         (open_and_init_dwo_file): Likewise.
 520         (free_dwo_file_from_slot): Remove.
 521
 522 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 523
 524         * dwarf2read.h (struct dwarf2_section_info) <readin,
 525         is_virtual>: Change type to bool.
 526         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 527         true instead of 1.
 528
 529 2019-06-19  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-data.h (tui_init_content_element): Don't declare.
 532
 533 2019-06-19  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-data.h (tui_init_win_info): Don't declare.
 536
 537 2019-06-19  Tom de Vries  <tdevries@suse.de>
 538
 539         * dwarf2read.h (abstract_to_concrete): Change type to
 540         std::unordered_map<sect_offset, std::vector<sect_offset>,
 541         gdb::hash_enum<sect_offset>>.
 542
 543 2019-06-19  Tom Tromey  <tromey@adacore.com>
 544
 545         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 546         EVAL_AVOID_SIDE_EFFECTS specially.
 547
 548 2019-06-19  Tom Tromey  <tromey@adacore.com>
 549
 550         * source-cache.c (highlighter): New global.
 551         (source_cache::get_source_lines): Create a highlighter on demand.
 552
 553 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * defs.h (deprecated_interactive_hook): Delete declaration.
 556         * interps.c (clear_interpreter_hooks): Remove use of
 557         deprecated_interactive_hook.
 558         * top.c (deprecated_interactive_hook): Delete definition.
 559         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 560
 561 2019-06-18  Tom de Vries  <tdevries@suse.de>
 562
 563         PR gdb/24515
 564         * dwarf2read.h (abstract_to_concrete): Change type from
 565         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 566         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 567         * dwarf2read.c (read_variable): Update.
 568         (dwarf2_fetch_die_loc_sect_off): Update.
 569
 570 2019-06-17  Tom de Vries  <tdevries@suse.de>
 571
 572         PR gdb/24617
 573         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 574         accessing parent[parent_len - 1].
 575
 576 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 577
 578         PR gdb/24364
 579         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 580         call dtrace_process_dof with NULL dof.
 581
 582 2019-06-16  Tom de Vries  <tdevries@suse.de>
 583
 584         PR gdb/24445
 585         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 586
 587 2019-06-16  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 590         (make_all_visible): Use address of member.
 591
 592 2019-06-16  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 595         (tui_free_window, free_content, free_content_elements): Remove
 596         unnecessary cast.
 597         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 598         cast.
 599         * tui/tui-regs.c (tui_show_register_group)
 600         (tui_display_registers_from, tui_display_reg_element_at_line):
 601         Remove unnecessary cast.
 602
 603 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * linux-nat.c (normal_mask): Delete.
 606         (_initialize_linux_nat): Don't initialise normal_mask.
 607
 608 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 609
 610         PR gdb/24445
 611         * dwarf-index-write.h (write_psymtabs_to_index): Add
 612         dwz_basename parameter.
 613         * dwarf-index-write.c (write_gdbindex): Move file writing to
 614         write_gdbindex_1.  Change return type void.
 615         (assert_file_size): Move up, remove filename parameter.
 616         (write_gdbindex_1): New function.
 617         (write_debug_names): Change return type to void, call
 618         assert_file_size.
 619         (struct index_wip_file): New struct.
 620         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 621         file logic to index_wip_file.  Write index for dwz file if
 622         needed.
 623         (save_gdb_index_command): Pass basename of dwz file, if present.
 624         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 625         build-id of dwz file, if present.
 626         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 627         (dwarf2_get_dwz_file): Likewise.
 628         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 629         (dwarf2_get_dwz_file): Likewise.
 630
 631 2019-06-16  Tom Tromey  <tom@tromey.com>
 632
 633         * coffread.c (process_coff_symbol): Use xstrdup.
 634         * value.c (create_internalvar): Use xstrdup.
 635
 636 2019-06-16  Tom Tromey  <tom@tromey.com>
 637
 638         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 639         * breakpoint.c (stopin_command, stopat_command)
 640         (until_break_command, decode_location_default): Remove unnecessary
 641         cast.
 642         * utils.c (subset_compare): Remove unnecessary cast.
 643         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 644         cast.
 645         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 646         cast.
 647         * infcmd.c (path_command): Remove unnecessary cast.
 648         * coffread.c (decode_type): Remove unnecessary cast.
 649         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 650         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 651         * tui/tui-stack.c (tui_show_locator_content)
 652         (tui_show_frame_info): Remove unnecessary cast.
 653         * tui/tui-win.c (tui_scroll_forward_command)
 654         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 655         (parse_scrolling_args): Remove unnecessary cast.
 656         * tui/tui-data.c (init_win_info, tui_del_window)
 657         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 658         (free_content_elements): Remove unnecessary cast.
 659         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 660         unnecessary cast.
 661         * tui/tui-source.c (tui_set_source_content)
 662         (tui_vertical_source_scroll): Remove unnecessary cast.
 663         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 664         cast.
 665         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 666         * tui/tui-regs.c (tui_display_registers_from)
 667         (tui_display_register): Remove unnecessary cast.
 668         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 669         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 670         (make_visible): Remove unnecessary cast.
 671         * tui/tui-winsource.c (tui_erase_source_content)
 672         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 673         unnecessary cast.
 674         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 675         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 676         * stabsread.c (read_type, read_array_type, read_range_type):
 677         Remove unnecessary cast.
 678         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 679         (parse_symbol, parse_type, upgrade_type, parse_external)
 680         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 681         unnecessary cast.
 682         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 683
 684 2019-06-16  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-data.c (tui_alloc_generic_win_info)
 687         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 688         checks.
 689
 690 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 691             Andrew Burgess  <andrew.burgess@embecosm.com>
 692
 693         * f-typeprint.c (f_print_type): Don't return early for not
 694         associated or not allocated types.
 695         (f_type_print_varspec_suffix): Add print_rank parameter and print
 696         ranks of array types in case they dangling.
 697         (f_type_print_base): Add print_rank parameter.
 698
 699 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 700
 701         * NEWS: Mention new MI commands.
 702         * break-catch-throw.c (enum exception_event_kind): Move to
 703         breakpoint.h.
 704         (print_mention_exception_catchpoint): Output text as a single
 705         message.
 706         (catch_exception_command_1): Rename to...
 707         (catch_exception_event): ...this, make non-static, update header
 708         command, and change some parameter types.
 709         (catch_catch_command): Update for changes to
 710         catch_exception_command_1.
 711         (catch_throw_command): Likewise.
 712         (catch_rethrow_command): Likewise.
 713         * breakpoint.c (enum exception_event_kind): Delete.
 714         * breakpoint.h (enum exception_event_kind): Moved here from
 715         break-catch-throw.c.
 716         (catch_exception_event): Declare.
 717         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 718         (mi_cmd_catch_throw): New function.
 719         (mi_cmd_catch_rethrow): New function.
 720         (mi_cmd_catch_catch): New function.
 721         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 722         'catch-catch' entries.
 723         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 724         (mi_cmd_catch_rethrow): Declare.
 725         (mi_cmd_catch_catch): Declare.
 726
 727 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * annotate.c (annotate_source_line): Change return type to void,
 730         update implementation to match.
 731         * annotate.h (annotate_source_line): Change return type to void,
 732         update header comment.
 733         * stack.c (print_frame_info): Don't change what frame information
 734         is printed based on whether annotations are on or not.
 735
 736 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 739         (annotate_source): Make static.
 740         (annotate_source_line): Moved from source.c and renamed from
 741         identify_source_line.  Update the return type.
 742         * annotate.h (annotate_source): Delete declaration.
 743         (annotate_source_line): Declaration moved from source.h, and
 744         renamed from identify_source_line.  Return type updated.
 745         * source.c (identify_source_line): Moved to annotate.c and renamed
 746         to annotate_source_line.
 747         (info_line_command): Remove check of annotation_level.
 748         * source.h (identify_source_line): Move declaration to annotate.h
 749         and rename to annotate_source_line.
 750         * stack.c: Add 'annotate.h' include.
 751         (print_frame_info): Remove check of annotation_level before
 752         calling annotate_source_line.
 753
 754 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * source-cache.c (source_cache::get_plain_source_lines): Use
 757         open_source_file_with_line_charpos instead of just
 758         open_source_file, remove call to find_source_lines.
 759         (source_cache::get_source_lines): Likewise.
 760         * source.c (find_source_lines): Make static.
 761         (get_filename_and_charpos): Renamed into...
 762         (open_source_file_with_line_charpos): ..this along with changes to
 763         return a scoped_fd, and some other minor clean ups.
 764         (identify_source_line): Use open_source_file_with_line_charpos.
 765         (search_command_helper): Use open_source_file_with_line_charpos
 766         instead of just open_source_file, remove call to
 767         find_source_lines.
 768         * source.h (open_source_file_with_line_charpos): Declare new
 769         function.
 770         (find_source_lines): Delete declaration.
 771
 772 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 773
 774         * source.c (get_filename_and_charpos): Remove fullname
 775         parameter.
 776         (identify_source_line): Update call to get_filename_and_charpos.
 777
 778 2019-06-14  Tom Tromey  <tromey@adacore.com>
 779
 780         PR gdb/24502:
 781         * ui-style.h (skip_ansi_escape): Update comment.
 782         * ui-file.h (class no_terminal_escape_file): New class.
 783         * ui-file.c (no_terminal_escape_file::write)
 784         (no_terminal_escape_file::puts): New methods.
 785         * cli/cli-logging.c (handle_redirections): Use
 786         no_terminal_escape_file.
 787
 788 2019-06-14  Tom Tromey  <tromey@adacore.com>
 789
 790         * NEWS: Move convenience variable news above Python news.
 791
 792 2019-06-14  Tom Tromey  <tom@tromey.com>
 793
 794         * gnulib: Move directory to top-level.
 795         * configure.ac: Don't configure gnulib.
 796         * configure: Rebuild.
 797         * common/common-defs.h: Use new path to gnulib.
 798         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 799         (GNULIB_H): Remove.
 800         (INCGNU): Look in new gnulib location.
 801         (HFILES_NO_SRCDIR): Remove gnulib files.
 802         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 803         (generated_files): Remove GNULIB_H.
 804         ($(LIBGNU), all-lib): Remove targets.
 805         (distclean): Don't mention GNULIB_BUILDDIR.
 806         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 807
 808 2019-06-14  Tom Tromey  <tromey@adacore.com>
 809
 810         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 811         Warn if symbol file does not provide any symbols.
 812
 813 2019-06-14  Tom Tromey  <tromey@adacore.com>
 814
 815         * source.c (find_and_open_source): Respect basenames_may_differ.
 816
 817 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 818
 819         * annotate.c (annotate_breakpoints_invalid): Make use of
 820         scoped_restore_terminal_state.
 821         (annotate_frames_invalid): Likewise.
 822
 823 2019-06-14  Tom Tromey  <tromey@adacore.com>
 824
 825         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 826         allow assignment to an internalvar.
 827
 828 2019-06-14  Tom Tromey  <tromey@adacore.com>
 829
 830         * ada-lex.l: Allow "_" in attribute names.
 831
 832 2019-06-14  Tom Tromey  <tromey@adacore.com>
 833
 834         PR gdb/24653:
 835         * regcache.c (registers_changed): Don't call alloca.
 836         * top.c (execute_command): Don't call alloca.
 837
 838 2019-06-13  Pedro Alves  <palves@redhat.com>
 839
 840         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 841         'expression'.  When parsing an expression, error out if there's
 842         junk after "unlimited".
 843         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 844         (do_set_command): Adjust calls to is_unlimited_literal.
 845
 846 2019-06-13  Pedro Alves  <palves@redhat.com>
 847
 848         * compile/compile.c (make_compile_options_def_group): Add braces
 849         around array_view initializer.
 850         * thread.c (make_thread_apply_all_options_def_group)
 851         (make_thread_apply_all_options_def_group): Likewise.
 852
 853 2019-06-13  Pedro Alves  <palves@redhat.com>
 854
 855         * NEWS (New commands): Mention "maint test-options
 856         require-delimiter", "maint test-options unknown-is-error", "maint
 857         test-options unknown-is-operand" and "maint show
 858         test-options-completion-result".
 859         (New command options, command completion): New section.
 860         (Completion improvements): New section.
 861         Mention that you can abbreviate "unlimited".
 862
 863 2019-06-13  Pedro Alves  <palves@redhat.com>
 864
 865         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 866         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 867         * unittests/cli-utils-selftests.c (test_parse_flags)
 868         (test_parse_flags_qcs): Delete.
 869         (test_cli_utils): Don't call deleted functions.
 870
 871 2019-06-13  Pedro Alves  <palves@redhat.com>
 872
 873         * thread.c: Include "cli/cli-option.h".
 874         (tp_array_compar_ascending): Global.
 875         (tp_array_compar): Delete function.
 876         (tp_array_compar_ascending, tp_array_compar_descending): New
 877         functions.
 878         (ascending_option_def, qcs_flag_option_def)
 879         (thr_qcs_flags_option_defs)
 880         (make_thread_apply_all_options_def_group)
 881         (make_thread_apply_options_def_group): New.
 882         (thread_apply_all_command): Use gdb::option::process_options.
 883         (thread_apply_command_completer)
 884         (thread_apply_all_command_completer): New.
 885         (thread_apply_command): Use gdb::option::process_options.
 886         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 887         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 888         to generate help text of "thread apply".  Adjust "taas"'s help.
 889         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 890         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 891
 892 2019-06-13  Pedro Alves  <palves@redhat.com>
 893
 894         * thread.c (thread_apply_command): Check for invalid TID with
 895         isdigit instead of !isalpha.
 896
 897 2019-06-13  Pedro Alves  <palves@redhat.com>
 898
 899         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 900         (validate_flags_qcs): New.
 901         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 902         (validate_flags_qcs): Declare.
 903         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 904         (make_frame_apply_options_def_group): New.
 905         (frame_apply_command_count): Process options with
 906         gdb::option::process_options.
 907         (frame_apply_completer): New.
 908         (frame_apply_level_completer, frame_apply_all_completer)
 909         (frame_apply_completer): New.
 910         (_initialize_stack): Update help of "frame apply", "frame apply
 911         level", "frame apply all" and "faas" to mention supported options
 912         and install command completers.
 913         * stack.h (frame_apply_all_completer): Declare.
 914         * thread.c: Include "stack.h".
 915         (tfaas_command): Add "--".
 916         (_initialize_thread): Update help "tfaas" to mention supported
 917         options and install command completer.
 918
 919 2019-06-13  Pedro Alves  <palves@redhat.com>
 920
 921         * completer.c (complete_nested_command_line): New.
 922         (gdb_completion_word_break_characters_throw): Add assertion.
 923         * completer.h (complete_nested_command_line): Declare.
 924
 925 2019-06-13  Pedro Alves  <palves@redhat.com>
 926
 927         * stack.c (parse_backtrace_qualifiers): New.
 928         (backtrace_command): Use it.
 929         (backtrace_command_completer): Complete on qualifiers.
 930
 931 2019-06-13  Pedro Alves  <palves@redhat.com>
 932
 933         * frame.c: Include "cli/cli-option.h.
 934         (user_set_backtrace_options): New.
 935         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 936         Delete.
 937         (get_prev_frame): Adjust.
 938         (boolean_option_def, uinteger_option_def)
 939         (set_backtrace_option_defs): New.
 940         (_initialize_frame): Adjust and use
 941         gdb::option::add_setshow_cmds_for_options to install "set
 942         backtrace past-main" and "set backtrace past-entry".
 943         * frame.h: Include "cli/cli-option.h".
 944         (struct frame_print_options): Forward declare.
 945         (print_frame_arguments_all, print_frame_arguments_scalars)
 946         (print_frame_arguments_none): Declare.
 947         (print_entry_values): Delete declaration.
 948         (struct frame_print_options, user_frame_print_options): New.
 949         (struct set_backtrace_options): New.
 950         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 951         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 952         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 953         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 954         (list_args_or_locals): Add frame_print_options parameter.
 955         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 956         * python/py-framefilter.c (enumerate_args): Pass down
 957         USER_FRAME_PRINT_OPTIONS.
 958         * stack.c: Include "cli/cli-option.h".
 959         (print_frame_arguments_all, print_frame_arguments_scalars)
 960         (print_frame_arguments_none): Declare.
 961         (print_raw_frame_arguments, print_entry_values): Delete.
 962         (user_frame_print_options): New.
 963         (boolean_option_def, enum_option_def, frame_print_option_defs):
 964         New.
 965         (struct backtrace_cmd_options): New.
 966         (bt_flag_option_def): New.
 967         (backtrace_command_option_defs): New.
 968         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 969         (print_frame_arg, read_frame_arg, print_frame_args)
 970         (print_frame_info, print_frame): Add frame_print_options parameter
 971         and use it.
 972         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 973         (backtrace_command_1): Add frame_print_options and
 974         backtrace_cmd_options parameters and use them.
 975         (make_backtrace_options_def_group): New.
 976         (backtrace_command): Process command options with
 977         gdb::option::process_options.
 978         (backtrace_command_completer): New.
 979         (_initialize_stack): Extend "backtrace"'s help to mention
 980         supported options.  Install completer for "backtrace".
 981         Install some settings commands with add_setshow_cmds_for_options.
 982
 983 2019-06-13  Pedro Alves  <palves@redhat.com>
 984
 985         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 986         and that "set/show print raw frame-arguments" are now deprecated.
 987
 988         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 989         command.
 990         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 991         * stack.c (_initialize_stack): Install "set/show print
 992         raw-frame-arguments", and deprecate "set/show print raw
 993         frame-arguments".
 994         * valprint.c (_initialize_valprint): Deprecate "set/show print
 995         raw".
 996
 997 2019-06-13  Pedro Alves  <palves@redhat.com>
 998
 999         * compile/compile.c (struct compile_options): New.
1000         (compile_flag_option_def, compile_command_option_defs)
1001         (make_compile_options_def_group): New.
1002         (compile_file_command): Handle options with
1003         gdb::option::process_options.
1004         (compile_file_command_completer): New function.
1005         (compile_code_command): Handle options with
1006         gdb::option::process_options.
1007         (compile_code_command_completer): New function.
1008         (_initialize_compiler): Install completers for "compile code" and
1009         "compile file".  Mention available options in "compile code" and
1010         "compile code"'s help.
1011         * completer.c (advance_to_completion_word): New, factored out from
1012         ...
1013         (advance_to_expression_complete_word_point): ... this.
1014         (advance_to_filename_complete_word_point): New.
1015         * completer.h (advance_to_filename_complete_word_point): New
1016         declaration.
1017
1018 2019-06-13  Pedro Alves  <palves@redhat.com>
1019
1020         * compile/compile.c: Include "cli/cli-option.h".
1021         (compile_print_value): Scope data pointer is now a
1022         value_print_options pointer; adjust.
1023         (compile_print_command): Process options.  Scope data pointer is
1024         now a value_print_options pointer; adjust.
1025         (_initialize_compile): Update "compile print"'s help to include
1026         supported options.  Install a completer for "compile print".
1027         * cp-valprint.c (show_vtblprint, show_objectprint)
1028         (show_static_field_print): Delete.
1029         (_initialize_cp_valprint): Don't install "set print
1030         static-members", "set print vtbl", "set print object" here.
1031         * printcmd.c: Include "cli/cli-option.h" and
1032         "common/gdb_optional.h".
1033         (print_command_parse_format): Rework to fill in a
1034         value_print_options instead of a format_data.
1035         (print_value): Change parameter type from format_data pointer to
1036         value_print_options reference.  Adjust.
1037         (print_command_1): Process options.  Adjust to pass down a
1038         value_print_options.
1039         (print_command_completer): New.
1040         (_initialize_printcmd): Install print_command_completer as
1041         handle_brkchars completer for the "print" command.  Update
1042         "print"'s help to include supported options.
1043         * valprint.c: Include "cli/cli-option.h".
1044         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1045         here from cp-valprint.c.
1046         (boolean_option_def, uinteger_option_def)
1047         (value_print_option_defs, make_value_print_options_def_group):
1048         New.  Use gdb::option::add_setshow_cmds_for_options to install
1049         "set print elements", "set print null-stop", "set print repeats",
1050         "set print pretty", "set print union", "set print array", "set
1051         print address", "set print symbol", "set print array-indexes".
1052         * valprint.h: Include <string> and "cli/cli-option.h".
1053         (make_value_print_options_def_group): Declare.
1054         (print_value): Change parameter type from format_data pointer to
1055         value_print_options reference.
1056         (print_command_completer): Declare.
1057
1058 2019-06-13  Pedro Alves  <palves@redhat.com>
1059
1060         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1061         (COMMON_SFILES): Add maint-test-settings.c.
1062         * cli/cli-decode.c (boolean_enums): New global, factored out from
1063         ...
1064         (add_setshow_boolean_cmd): ... here.
1065         * cli/cli-decode.h (boolean_enums): Declare.
1066         * cli/cli-option.c: New file.
1067         * cli/cli-option.h: New file.
1068         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1069         factored out from ...
1070         (parse_cli_boolean_value(const char *)): ... this.
1071         (is_unlimited_literal): Change parameter type to pointer to
1072         pointer.  Adjust and advance ARG pointer.
1073         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1074         (parse_cli_var_enum): New, factored out from ...
1075         (do_set_command): ... this.  Adjust.
1076         * cli/cli-setshow.h (parse_cli_boolean_value)
1077         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1078         (parse_cli_var_enum): Declare.
1079         * cli/cli-utils.c: Include "cli/cli-option.h".
1080         (get_ulongest): New.
1081         * cli/cli-utils.h (get_ulongest): Declare.
1082         (check_for_argument): New overloads.
1083         * maint-test-options.c: New file.
1084
1085 2019-06-13  Pedro Alves  <palves@redhat.com>
1086
1087         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1088         parse a range if "-" is at the end of the string.
1089
1090 2019-06-13  Pedro Alves  <palves@redhat.com>
1091
1092         * cli/cli-setshow.c (parse_auto_binary_operation)
1093         (parse_cli_boolean_value): Don't allow "o".
1094
1095 2019-06-13  Pedro Alves  <palves@redhat.com>
1096
1097         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1098         * NEWS: Mention maint test-settings KIND.
1099         * maint-test-settings.c: New file.
1100
1101 2019-06-13  Pedro Alves  <palves@redhat.com>
1102
1103         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1104         completer.
1105         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1106         "set" completers.
1107
1108 2019-06-13  Pedro Alves  <palves@redhat.com>
1109
1110         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1111         after item.
1112
1113 2019-06-13  Pedro Alves  <palves@redhat.com>
1114
1115         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1116
1117 2019-06-13  Pedro Alves <palves@redhat.com>
1118
1119         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1120         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1121         call.
1122         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1123         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1124         calls.
1125         (check_for_argument): Skip spaces after argument.
1126
1127 2019-06-13  Pedro Alves  <palves@redhat.com>
1128
1129         * thread.c (thread_apply_command): Adjust TID parsing.
1130         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1131         detected before end of string.
1132         (tid_is_in_list): Error out if LIST is invalid.
1133
1134 2019-06-13  Pedro Alves  <palves@redhat.com>
1135
1136         * completer.c (complete_line_internal_1): Rewind completion word
1137         point.
1138         (completion_tracker::advance_custom_word_point_by): Change
1139         parameter type to int.
1140         * completer.h (completion_tracker::advance_custom_word_point_by):
1141         Likewise.
1142
1143 2019-06-13  Pedro Alves  <palves@redhat.com>
1144
1145         * completer.c (advance_to_completion_word): Handle delimiters.
1146
1147 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1148
1149         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1150
1151 2019-06-11  Tom Tromey  <tom@tromey.com>
1152
1153         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1154         (xmalloc_failed): Move to alloc.c.
1155         * alloc.c: New file.
1156         * Makefile.in (COMMON_SFILES): Add alloc.c.
1157
1158 2019-06-11  Tom Tromey  <tom@tromey.com>
1159
1160         * nat/linux-waitpid.c: Don't include server.h.
1161         (linux_debug): Remove.
1162         (my_waitpid): Update.
1163
1164 2019-06-11  Tom Tromey  <tromey@adacore.com>
1165
1166         * infcall.c (_initialize_infcall): Remove trailing newline from
1167         help.
1168         * user-regs.c (_initialize_user_regs): Remove trailing newline
1169         from help.
1170         * typeprint.c (_initialize_typeprint): Remove trailing newline
1171         from help.
1172         * reverse.c (_initialize_reverse): Remove trailing newlines from
1173         help.
1174         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1175         from help.
1176         * language.c (add_set_language_command): Remove trailing newline
1177         from help.
1178         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1179         help.
1180         * disasm.c (_initialize_disasm): Remove trailing newline from
1181         help.
1182         * top.c (init_main): Remove trailing newline from help.
1183         * interps.c (_initialize_interpreter): Remove trailing newline
1184         from help.
1185         * btrace.c (_initialize_btrace): Remove trailing newlines from
1186         help.
1187         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1188         from help.
1189         * python/python.c (_initialize_python): Remove trailing newline
1190         from help.
1191         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1192         help.
1193         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1194         from help.  Reformat some text.
1195         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1196         from help.
1197         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1198         newline from help.
1199
1200 2019-06-11  Tom Tromey  <tromey@adacore.com>
1201
1202         * darwin-nat.c (darwin_decode_exception_message)
1203         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1204
1205 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * valops.c (value_slice): Check for not allocated or not
1208         associated values.
1209
1210 2019-06-10  Tom de Vries  <tdevries@suse.de>
1211
1212         PR gdb/24618
1213         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1214         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1215         invalid.
1216
1217 2019-06-10  Tom de Vries  <tdevries@suse.de>
1218
1219         PR gdb/24611
1220         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1221         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1222
1223 2019-06-10  Tom de Vries  <tdevries@suse.de>
1224
1225         PR symtab/24545
1226         * symtab.c (struct demangled_name_entry): Add language field.
1227         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1228         static minimal symbol".  Set and use language field.
1229
1230 2019-06-10  Tom Tromey  <tromey@adacore.com>
1231
1232         * ada-lang.c (_initialize_ada_language): Update help text.
1233
1234 2019-06-10  Tom Tromey  <tromey@adacore.com>
1235
1236         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1237         with a newline.
1238         * guile/guile.c (handle_boot_error): Don't end warning with a
1239         newline.
1240         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1241         warning with a newline.
1242         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1243         newline.
1244         (s12z_frame_cache): Likewise.
1245         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1246         a newline.
1247         * solib-svr4.c (disable_probes_interface): Don't end warning with
1248         a newline.
1249         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1250         newline.
1251         * python/python.c (do_finish_initialization): Don't end warning
1252         with a newline.
1253
1254 2019-06-10  Tom Tromey  <tom@tromey.com>
1255
1256         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1257         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1258         gdbpy_enter.
1259
1260 2019-06-10  Tom Tromey  <tromey@adacore.com>
1261
1262         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1263         data.
1264         (elf_new_init): Don't call stabsread_new_init.
1265         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1266         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1267         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1268
1269 2019-06-10  Tom de Vries  <tdevries@suse.de>
1270
1271         PR symtab/16264
1272         PR symtab/24517
1273         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1274
1275 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1276
1277         * source.c (find_and_open_source): Also rewrite relative file
1278         names.
1279
1280 2019-04-26  Amos Bird  <amosbird@gmail.com>
1281
1282         * annotate.c (annotate_thread_exited): Add "thread-exited"
1283         annotation.
1284
1285 2019-06-06  Tom Tromey  <tromey@adacore.com>
1286
1287         * maint.h (class scoped_command_stats): Use
1288         DISABLE_COPY_AND_ASSIGN.
1289         <print_time>: New method.
1290         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1291         print_time.
1292         (scoped_command_stats::print_time): New method.
1293
1294 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1297         instructions of lengths 6 or 8 bytes.
1298
1299 2019-06-04  Pedro Alves  <palves@redhat.com>
1300
1301         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1302
1303         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1304         * breakpoint.c (condition_completer): Likewise.
1305         * cli/cli-dump.c (scan_expression): Likewise.
1306         * common/filestuff.c (mkdir_recursive): Likewise.
1307         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1308         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1309         (gdb_abspath): Likewise.
1310         * compile/compile-cplus-types.c
1311         (compile_cplus_instance::decl_name): Likewise.
1312         * completer.c (complete_explicit_location):
1313         (signal_completer, reg_or_group_completer_1): Likewise.
1314         * cp-support.c (cp_remove_params_if_any): Likewise.
1315         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1316         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1317         * infcmd.c (strip_bg_char): Likewise.
1318         * linespec.c (copy_token_string): Likewise.
1319         * mi/mi-main.c (output_cores): Likewise.
1320         * psymtab.c (psymtab_search_name):
1321         * symfile.c (test_set_ext_lang_command): Likewise.
1322         * target.c (target_fileio_read_stralloc): Likewise.
1323         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1324         * value.c (complete_internalvar): Likewise.
1325
1326 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1327
1328         Add objfile property to gdb.Type.
1329         * NEWS: Mention Python API addition.
1330         * python/py-type.c (typy_get_objfile): New method.
1331
1332 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1333
1334         * NEWS: Mention the new set|show style [title|highlight].
1335         Mention changes to "show style", "help" and "apropos".
1336
1337 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1338
1339         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1340         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1341         instead of print_help_for_command.
1342         (print_doc_of_command): New function.
1343         (help_list): Add 'apropos -v word' suggestion.
1344         (print_help_for_command): Style the command name using title style.
1345         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1346         (_initialize_cli_cmds): Describe -v in apropos_command help.
1347
1348 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1349
1350         * cli/cli-style.h (cli_style_option): Add name in constructor,
1351         add m_name class member, add constructor with intensity,
1352         add name class function.
1353         (cli_style_option::add_setshow_commands): Remove name argument.
1354         (highlight_style, title_style): New styles.
1355         * cli/cli-style.c (do_show): New function that shows a style
1356         characteristic styling the style name with itself.
1357         (set_style_name): New function.
1358         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1359         Update all callers according to the changes in cli/cli-style.h.
1360         * utils.h (fputs_highlighted): New function.
1361         * utils.c (fputs_highlighted): Likewise.
1362
1363 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1364
1365         * NEWS: Mention new pipe command and new convenience variables.
1366
1367 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368
1369         * cli/cli-cmds.c (pipe_command): New function.
1370         (_initialize_cli_cmds): Call add_com for pipe_command.
1371         Define | as an alias for pipe.
1372         (exit_status_set_internal_vars): New function.
1373         (shell_escape): Call exit_status_set_internal_vars.
1374         cli/cli-decode.c (find_command_name_length): Recognize | as
1375         a single character command.
1376
1377 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1378
1379         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1380         top.c (execute_command_to_ui_file): New function, mostly a copy
1381         of execute_command_to_string.
1382         (execute_command_to_string): Implement by calling
1383         execute_command_to_ui_file.
1384
1385 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1386
1387         * top.h (saved_command_line): Remove declaration.
1388         * top.c (previous_saved_command_line, previous_repeat_arguments):
1389         New variables.
1390         (saved_command_line): Make static, define together with other
1391         'repeat variables'.
1392         (dont_repeat): Clear repeat_arguments.
1393         (repeat_previous, get_saved_command_line, save_command_line):
1394         New functions.
1395         (gdb_init): Initialize saved_command_line
1396         and previous_saved_command_line.
1397         * main.c (captured_main_1): Remove saved_command_line initialization.
1398         * event-top.c (handle_line_of_input): Update to use
1399         the new 'repeat' related functions instead of direct access to
1400         saved_command_line.
1401         * command.h (repeat_previous, get_saved_command_line,
1402         save_command_line): New declarations.
1403         (dont_repeat): Add comment.
1404
1405 2019-05-30  Tom Tromey  <tromey@adacore.com>
1406
1407         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1408         Fix comment.
1409         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1410
1411 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1412
1413         PR cli/24587
1414         * completer.c (complete): Initialize variable word.
1415
1416 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1417
1418         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1419         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1420         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1421         'body' is NULL to the outter 'if', protecting the '!is_define'
1422         situation as well.
1423
1424 2019-05-29  Tom Tromey  <tromey@adacore.com>
1425
1426         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1427         (dwarf_unknown): New function.
1428         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1429         (dwarf_type_encoding_name): Use dwarf_unknown.
1430
1431 2019-05-29  Tom Tromey  <tromey@adacore.com>
1432
1433         PR c++/20020:
1434         * cp-valprint.c (cp_print_value_fields): Call
1435         cp_print_static_field inside "try".
1436
1437 2019-05-29  Tom Tromey  <tromey@adacore.com>
1438
1439         * inflow.c (struct terminal_info): Add default operator=.
1440         * configure: Rebuild.
1441         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1442         -Wdeprecated-copy-dtor, -Wredundant-move.
1443
1444 2019-05-29  Tom Tromey  <tromey@adacore.com>
1445
1446         * NEWS: Add entry.
1447         * infcmd.c (print_return_value_1): Handle finish_print
1448         option.
1449         (show_print_finish): New function.
1450         (_initialize_infcmd): Add "set/show print finish" commands.
1451         * valprint.c (user_print_options): Initialize new member.
1452         * valprint.h (struct value_print_options) <finish_print>: New
1453         member.
1454
1455 2019-05-28  Tom Tromey  <tromey@adacore.com>
1456
1457         * ada-lang.c (ada_remove_Xbn_suffix)
1458         (find_old_style_renaming_symbol)
1459         (parse_old_style_renaming): Remove.
1460         (ada_find_renaming_symbol): Don't call
1461         find_old_style_renaming_symbol.
1462         (ada_is_renaming_symbol): Rename from
1463         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1464         bool.  Now static.
1465         (ada_read_var_value): Update and simplify.
1466         * ada-exp.y (write_var_or_type): Remove old code.
1467
1468 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1469
1470         * event-top.c: Remove include comment.
1471         * inflow.c (class scoped_ignore_sigttou): Move from here...
1472         * inflow.h (class scoped_ignore_sigttou): ...to here.
1473         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1474         * top.c:  Remove include comment.
1475
1476 2019-05-27  Tom Tromey  <tom@tromey.com>
1477
1478         * NEWS: Fix typo.
1479
1480 2019-05-22  Tom Tromey  <tromey@adacore.com>
1481
1482         * target.c (target_follow_exec): Constify parameter.
1483         * target-delegates.c: Rebuild.
1484         * remote.c (remote_target::follow_exec): Constify parameter.
1485         * infrun.c (follow_exec): Constify parameter.
1486         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1487         (target_follow_exec): Likewise.
1488
1489 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1490
1491         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1492         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1493
1494 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1495
1496         * NEWS: Add debugredirect and testsuite sections.
1497
1498 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1499
1500         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1501         target descriptions using exclusively floating point register name
1502         aliases.
1503
1504 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         PR gdb/18644:
1507         * f-lang.c (build_fortran_types): Handle the case where
1508         gdbarch_floatformat_for_type returns a nullptr.
1509
1510 2019-05-21  Tom de Vries  <tdevries@suse.de>
1511
1512         PR cli/24587
1513         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1514
1515 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         PR gdb/18644:
1518         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1519         16-byte floats.
1520         * i386-tdep.c (i386_floatformat_for_type): Use
1521         floatformats_ia64_quad for the 16-byte floating point component
1522         within a fortran 32-byte complex number.
1523
1524 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1527         delete default constructor.
1528         (find_partial_die): Update to return const struct.
1529         (partial_die_parent_scope): Move variable declaration into scope
1530         of its use and change its type to auto.
1531         (guess_partial_die_structure_name): Likewise.
1532         (partial_die_info::fixup): Likewise.
1533
1534 2019-05-17  Tom Tromey  <tromey@adacore.com>
1535
1536         * source.c (find_and_open_source): Remove cast.
1537
1538 2019-05-17  Tom Tromey  <tromey@adacore.com>
1539
1540         * annotate.c (annotate_source): Make "filename" const.
1541         * annotate.h (annotate_source): Use const.
1542
1543 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1544
1545         * disasm.c (set_disassembler_options): Send errors to stderr.
1546
1547 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1550         (cli_interp_base::set_logging): Check debug_redirect.
1551         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1552         * cli/cli-logging.c (debug_redirect): Add static variable.
1553         (pop_output_files): Add default param.
1554         (handle_redirections): Print debug setting.
1555         (show_logging_command): Likewise.
1556         (_initialize_cli_logging): Add debugredirect command.
1557         * interps.c (current_interp_set_logging): Add debug_redirect
1558         parameter.
1559         * interps.h (set_logging): Add debug_redirect parameter.
1560         (current_interp_set_logging): Likewise.
1561         * mi/mi-common.h: Likewise.
1562         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1563
1564 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1565             Tom Tromey  <tromey@adacore.com>
1566
1567         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1568         directly.
1569         * cli/cli-interp.h (make_logging_output): Remove declaration.
1570         * cli/cli-logging.c (make_logging_output): Remove function.
1571         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1572         directly.
1573         * ui-file.c (tee_file::tee_file): Remove bools.
1574         (tee_file::~tee_file): Remove deletes.
1575         * ui-file.h (tee_file): Remove bools.
1576
1577 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1578
1579         * mi/mi-cmds.h (mi_cmd_complete): New function.
1580         * mi/mi-main.c (mi_cmd_complete): Likewise.
1581         * mi/mi-cmds.c: Define new MI command -complete.
1582         * NEWS: Mention new -complete command.
1583
1584 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1585
1586         * completer.h (complete): New function.
1587         * completer.c (complete): Likewise.
1588         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1589         function defined in completer.h.
1590
1591 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1592
1593         * MAINTAINERS (Write After Approval): Add myself.
1594
1595 2019-05-17  Tom de Vries  <tdevries@suse.de>
1596
1597         PR gdb/24094
1598         * dwarf2read.c (struct cu_partial_die_info): New struct.
1599         (find_partial_die): Return cu_partial_die_info.
1600         (partial_die_parent_scope, guess_partial_die_structure_name)
1601         (partial_die_info::fixup): Handle new return type of find_partial_die.
1602
1603 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1604
1605         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1606         "std::string", simplifying the algorithm.
1607
1608 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1609
1610         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1611         (stap_static_probe_ops::get_probes): Likewise.
1612
1613 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1614
1615         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1616         '-')" and "else if".
1617         (stap_parse_single_operand): Join checks for
1618         "gdbarch_stap_parse_special_token_p" and
1619         "gdbarch_stap_parse_special_token" in the same "if" statement.
1620         Invert check when verifying for operation on register
1621         displacement.
1622
1623 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1624
1625         * stap-probe.c (stap_get_opcode): Update comment.
1626         (stap_get_expected_argument_type): Likewise.
1627         (handle_stap_probe): Likewise.
1628
1629 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1630
1631         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1632         return type to 'bool'.  Adjust comment.  Use 'bool' when
1633         appropriate.
1634         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1635         * stap-probe.c (stap_parse_argument_1): Likewise.
1636         (stap_is_operator): Likewise.
1637         (stap_is_generic_prefix): Likewise.
1638         (stap_is_register_prefix): Likewise.
1639         (stap_is_register_indirection_prefix): Likewise.
1640         (stap_is_integer_prefix): Likewise.
1641         (stap_generic_check_suffix): Likewise.
1642         (stap_check_integer_suffix): Likewise.
1643         (stap_check_register_suffix): Likewise.
1644         (stap_check_register_indirection_suffix): Likewise.
1645         (stap_parse_register_operand): Likewise.
1646         (stap_parse_single_operand): Likewise.
1647         (stap_parse_argument_1): Likewise.
1648         (stap_probe::get_argument_count): Likewise.
1649         (stap_is_operator): Likewise.
1650
1651 2019-05-16  Tom Tromey  <tromey@adacore.com>
1652
1653         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1654         keyword to foreach.
1655
1656 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1657
1658         * linux-thread-db.c (try_thread_db_load_1): Change return type
1659         to bool.
1660         (try_thread_db_load): Likewise.
1661         (try_thread_db_load_from_pdir_1): Likewise.
1662         (try_thread_db_load_from_pdir): Likewise.
1663         (try_thread_db_load_from_sdir): Likewise.
1664         (try_thread_db_load_from_dir): Likewise.
1665         (thread_db_load_search): Likewise.
1666         (has_libpthread): Likewise.
1667         (thread_db_load): Likewise.
1668
1669 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1670
1671         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1672         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1673         NULL, and complain/return if that's the case.
1674
1675 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1676
1677         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1678         (advance, posn, abstract_read_memory): New functions.
1679         [struct mem_read_abstraction]: New struct.
1680         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1681
1682 2019-05-14  Tom Tromey  <tromey@adacore.com>
1683
1684         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1685         value is not lval_memory.
1686
1687 2019-05-14  Tom Tromey  <tromey@adacore.com>
1688
1689         * solib.c (info_sharedlibrary_command): Style the file name.
1690
1691 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1692
1693         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1694         (aarch64_vnv_type): Likewise.
1695         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1696         * common/tdesc.c: Likewise.
1697         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1698         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1699         * features/aarch64-fpu.xml: Add ieee half view.
1700         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1701         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1702         * gdbtypes.h (struct builtin_type): Likewise.
1703         (struct objfile_type): Likewise.
1704
1705 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1706
1707         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1708         typo.
1709         * location.h (string_to_event_location): Likewise.
1710
1711 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1712
1713         GDB 8.3 released.
1714
1715 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1716
1717         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1718         New variable declaration.
1719         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1720         New variable.
1721         (print_one_breakpoint): Use ui_out::test_flags and new global
1722         variable to compute use_fixed_output.
1723         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1724         Remove.
1725         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1726         (mi_multi_location_breakpoint_output_fixed): Remove.
1727         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1728         new variable.
1729         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1730         fix_multi_location_breakpoint_output flag if version >= 3.
1731         * ui-out.h (enum ui_out_flag)
1732         <fix_multi_location_breakpoint_output>: New enumerator.
1733
1734 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1735
1736         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1737
1738 2019-05-10  Tom Tromey  <tromey@adacore.com>
1739
1740         * ada-lang.c (catch_ada_completer): New function.
1741         (_initialize_ada_language): Use it.
1742
1743 2019-05-10  Tom Tromey  <tromey@adacore.com>
1744
1745         * thread.c (print_thread_info): Make "requested_threads" const.
1746         * gdbthread.h (print_thread_info): Make "requested_threads"
1747         const.
1748         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1749         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1750
1751 2019-05-08  Tom Tromey  <tom@tromey.com>
1752
1753         * gdbtypes.c (objfile_type_data): Change type.
1754         (objfile_type, _initialize_gdbtypes): Update.
1755
1756 2019-05-08  Tom Tromey  <tom@tromey.com>
1757
1758         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1759         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1760         (_initialize_dwarf2_frame): Update.
1761
1762 2019-05-08  Tom Tromey  <tom@tromey.com>
1763
1764         * objc-lang.c (objc_objfile_data): Change type.
1765         (find_methods): Update.
1766         (_initialize_objc_lang): Remove.
1767
1768 2019-05-08  Tom Tromey  <tom@tromey.com>
1769
1770         * stabsread.c (rs6000_builtin_type_data): Change type.
1771         (rs6000_builtin_type, _initialize_stabsread): Update.
1772
1773 2019-05-08  Tom Tromey  <tom@tromey.com>
1774
1775         * mips-tdep.c (mips_pdr_data): Remove.
1776         (_initialize_mips_tdep): Update.
1777
1778 2019-05-08  Tom Tromey  <tom@tromey.com>
1779
1780         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1781         (hppa_init_objfile_priv_data, read_unwind_info)
1782         (find_unwind_entry, _initialize_hppa_tdep): Update.
1783
1784 2019-05-08  Tom Tromey  <tom@tromey.com>
1785
1786         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1787         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1788         on obstack.
1789         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1790
1791 2019-05-08  Tom Tromey  <tom@tromey.com>
1792
1793         * mdebugread.c (basic_type_data): Change type.
1794         (basic_type, _initialize_mdebugread): Update.
1795
1796 2019-05-08  Tom Tromey  <tom@tromey.com>
1797
1798         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1799
1800 2019-05-08  Tom Tromey  <tom@tromey.com>
1801
1802         * nto-tdep.c (nto_inferior_data_reg): Change type.
1803         (nto_inferior_data): Update.
1804         (nto_inferior_data_cleanup, nto_new_inferior_data)
1805         (_initialize_nto_tdep): Remove.
1806         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1807
1808 2019-05-08  Tom Tromey  <tom@tromey.com>
1809
1810         * ada-lang.c (struct ada_inferior_data): Add initializers.
1811         (ada_inferior_data): Change type.
1812         (ada_inferior_data_cleanup): Remove.
1813         (get_ada_inferior_data, ada_inferior_exit)
1814         (struct ada_pspace_data): Add initializers, destructor.
1815         (ada_pspace_data_handle): Change type.
1816         (get_ada_pspace_data): Update.
1817         (ada_pspace_data_cleanup): Remove.
1818
1819 2019-05-08  Tom Tromey  <tom@tromey.com>
1820
1821         * coffread.c (struct coff_symfile_info): Add initializers.
1822         (coff_objfile_data_key): Move lower.  Change type.
1823         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1824         Update.
1825         (coff_free_info): Remove.
1826
1827 2019-05-08  Tom Tromey  <tom@tromey.com>
1828
1829         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1830         (fbsd_pspace_data_handle): Move lower.  Change type.
1831         (get_fbsd_pspace_data): Update.
1832         (fbsd_pspace_data_cleanup): Remove.
1833         (_initialize_fbsd_tdep): Update.
1834
1835 2019-05-08  Tom Tromey  <tom@tromey.com>
1836
1837         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1838         (get_ada_tasks_pspace_data): Update.
1839         (ada_tasks_pspace_data_cleanup): Remove.
1840         (_initialize_tasks): Update.
1841         (ada_tasks_inferior_data_handle): Change type.
1842         (get_ada_tasks_inferior_data): Update.
1843         (ada_tasks_inferior_data_cleanup): Remove.
1844         (struct ada_tasks_pspace_data): Add initializers.
1845
1846 2019-05-08  Tom Tromey  <tom@tromey.com>
1847
1848         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1849         * symfile-debug.c (debug_sym_get_probes): Change type.
1850         * stap-probe.c (handle_stap_probe):
1851         (stap_static_probe_ops::get_probes): Change type.
1852         * probe.h (class static_probe_ops) <get_probes>: Change type.
1853         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1854         (parse_probes_in_pspace): Update.
1855         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1856         Update.
1857         (any_static_probe_ops::get_probes): Change type.
1858         * elfread.c (elfread_data): New typedef.
1859         (probe_key): Change type.
1860         (elf_get_probes): Likewise.  Update.
1861         (probe_key_free): Remove.
1862         (_initialize_elfread): Update.
1863         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1864         Change type.
1865         (dtrace_process_dof_probe, dtrace_process_dof)
1866         (dtrace_static_probe_ops::get_probe): Change type.
1867
1868 2019-05-08  Tom Tromey  <tom@tromey.com>
1869
1870         * xcoffread.c (struct xcoff_symfile_info): Rename from
1871         coff_symfile_info.  Add initializers.
1872         (xcoff_objfile_data_key): Move lower.  Change type.
1873         (XCOFF_DATA): Rewrite.
1874         (xcoff_free_info): Remove.
1875         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1876         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1877         (xcoff_initial_scan): Update.
1878
1879 2019-05-08  Tom Tromey  <tom@tromey.com>
1880
1881         * solib-svr4.c (struct svr4_info): Add initializers and
1882         destructor.
1883         <probes_table>: Now an htab_up.
1884         (solib_svr4_pspace_data): Change type.
1885         (free_probes_table): Simplify.
1886         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1887         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1888         (probes_table_remove_objfile_probes, register_solib_event_probe)
1889         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1890         (_initialize_svr4_solib): Update.
1891
1892 2019-05-08  Tom Tromey  <tom@tromey.com>
1893
1894         * remote.c (remote_pspace_data): Change type.
1895         (remote_pspace_data_cleanup): Remove.
1896         (get_remote_exec_file, set_pspace_remote_exec_file)
1897         (_initialize_remote): Update.
1898
1899 2019-05-08  Tom Tromey  <tom@tromey.com>
1900
1901         * breakpoint.c (breakpoint_objfile_key): Change type.
1902         (get_breakpoint_objfile_data): Update.
1903         (free_breakpoint_objfile_data): Remove.
1904         (_initialize_breakpoint): Update.
1905
1906 2019-05-08  Tom Tromey  <tom@tromey.com>
1907
1908         * linux-tdep.c (struct linux_info): Add initializers.
1909         (linux_inferior_data): Move.  Change type.
1910         (invalidate_linux_cache_inf): Update.
1911         (linux_inferior_data_cleanup): Remove.
1912         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1913
1914 2019-05-08  Tom Tromey  <tom@tromey.com>
1915
1916         * auxv.c (auxv_inferior_data): Move.  Change type.
1917         (auxv_inferior_data_cleanup): Remove.
1918         (invalidate_auxv_cache_inf): Rewrite.
1919         (get_auxv_inferior_data, _initialize_auxv): Update.
1920
1921 2019-05-08  Tom Tromey  <tom@tromey.com>
1922
1923         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1924         (symfile_debug_objfile_data_key): Change type.
1925         (symfile_debug_installed, debug_qf_has_symbols)
1926         (debug_qf_find_last_source_symtab)
1927         (debug_qf_forget_cached_source_info)
1928         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1929         (debug_qf_print_stats, debug_qf_dump)
1930         (debug_qf_expand_symtabs_for_function)
1931         (debug_qf_expand_all_symtabs)
1932         (debug_qf_expand_symtabs_with_fullname)
1933         (debug_qf_map_matching_symbols)
1934         (debug_qf_expand_symtabs_matching)
1935         (debug_qf_find_pc_sect_compunit_symtab)
1936         (debug_qf_map_symbol_filenames)
1937         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1938         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1939         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1940         (debug_sym_read_linetable, debug_sym_relocate): Update.
1941         (symfile_debug_free_objfile): Remove.
1942         (install_symfile_debug_logging, _initialize_symfile_debug):
1943         Update.
1944
1945 2019-05-08  Tom Tromey  <tom@tromey.com>
1946
1947         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1948         allocate_on_obstack.
1949         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1950         (get_dwarf2_per_objfile): Update.
1951         (set_dwarf2_per_objfile): Remove.
1952         (dwarf2_has_info, dwarf2_get_section_info): Update.
1953         (dwarf2_free_objfile): Remove.
1954         (_initialize_dwarf2_read): Update.
1955
1956 2019-05-08  Tom Tromey  <tom@tromey.com>
1957
1958         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1959         initializers.
1960         <unsupported_script_warning_printed,
1961         script_not_found_warning_printed>: Now bool.
1962         (auto_load_pspace_data): Change type.
1963         (~auto_load_pspace_info): Rename from
1964         auto_load_pspace_data_cleanup.
1965         (get_auto_load_pspace_data, init_loaded_scripts_info)
1966         (clear_section_scripts, maybe_print_unsupported_script_warning)
1967         (maybe_print_script_not_found_warning, _initialize_auto_load):
1968         Update.
1969
1970 2019-05-08  Tom Tromey  <tom@tromey.com>
1971
1972         * objfiles.c (objfile_pspace_info): Add destructor and
1973         initializers.
1974         (objfiles_pspace_data): Change type.
1975         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1976         (get_objfile_pspace_data): Update.
1977         (objfiles_bfd_data): Change type.
1978         (get_objfile_bfd_data): Update.
1979         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1980
1981 2019-05-08  Tom Tromey  <tom@tromey.com>
1982
1983         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1984         Change type.
1985         (get_catch_syscall_inferior_data): Update.
1986         (catch_syscall_inferior_data_cleanup): Remove.
1987         (_initialize_break_catch_syscall): Update.
1988
1989 2019-05-08  Tom Tromey  <tom@tromey.com>
1990
1991         * inflow.c (struct terminal_info): Add destructor and
1992         initializers.
1993         (inflow_inferior_data): Change type.
1994         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1995         (get_inflow_inferior_data, inflow_inferior_exit)
1996         (swap_terminal_info, _initialize_inflow): Update.
1997
1998 2019-05-08  Tom Tromey  <tom@tromey.com>
1999
2000         * target-dcache.c (target_dcache_cleanup): Remove.
2001         (target_dcache_aspace_key): Change type.
2002         (target_dcache_init_p, target_dcache_invalidate)
2003         (target_dcache_get, target_dcache_get_or_init)
2004         (_initialize_target_dcache): Update.
2005         * dcache.h (struct dcache_deleter): New.
2006
2007 2019-05-08  Tom Tromey  <tom@tromey.com>
2008
2009         * symtab.c (struct symbol_cache): Add destructor and
2010         initializers.
2011         (symbol_cache_key): Move.  Change type.
2012         (make_symbol_cache, free_symbol_cache): Remove.
2013         (get_symbol_cache): Update.
2014         (symbol_cache_cleanup): Remove.
2015         (ALL_PSPACES, symbol_cache_flush)
2016         (maintenance_print_symbol_cache)
2017         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2018         Update.
2019
2020 2019-05-08  Tom Tromey  <tom@tromey.com>
2021
2022         * symtab.c (struct main_info): Add destructor and initializers.
2023         (main_progspace_key): Move.  Change type.
2024         (get_main_info): Update.
2025         (main_info_cleanup): Remove.
2026         (_initialize_symtab): Update.
2027
2028 2019-05-08  Tom Tromey  <tom@tromey.com>
2029
2030         * registry.h (DECLARE_REGISTRY): Define the _key class.
2031
2032 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2033
2034         * NEWS: Merge two 'New commands' sections.
2035
2036 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2037
2038         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2039         parameter and use Ada language definition instead.
2040         (ada_val_print_ptr): Remove unused language parameter.
2041         (ada_val_print_num): Remove language parameter and use Ada language
2042         definition instead.
2043         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2044         parameter.
2045         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2046         parameter and use Ada language definition instead.
2047         (ada_val_print_1): Update all ada_val_print_xxx calls.
2048         Remove language parameter.
2049         (ada_val_print): Update ada_val_print_1 call.
2050
2051 2019-05-08  Tom Tromey  <tromey@adacore.com>
2052
2053         * remote.c (remote_hw_watchpoint_limit)
2054         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2055         Now static.
2056
2057 2019-05-08  Tom Tromey  <tromey@adacore.com>
2058
2059         * maint.c (_initialize_maint_cmds): Move initialization code to
2060         remote.c.
2061         (watchdog, show_watchdog): Move to remote.c.
2062         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2063         "watchdog" static.
2064         (_initialize_remote): Move initialization code from maint.c.
2065         * defs.h (watchdog): Don't declare.
2066
2067 2019-05-08  Tom Tromey  <tromey@adacore.com>
2068
2069         * tui/tui-interp.c: Include main.h.
2070         * interps.c: Include main.h.
2071         * main.h (interpreter_p): Declare.
2072         * defs.h (interpreter_p): Don't declare.
2073
2074 2019-05-08  Tom Tromey  <tromey@adacore.com>
2075
2076         * dwarf2loc.c: Include dwarf2read.h.
2077         * defs.h (read_unsigned_leb128): Don't declare.
2078         * dwarf2read.h (read_unsigned_leb128): Declare.
2079
2080 2019-05-08  Tom Tromey  <tromey@adacore.com>
2081
2082         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2083         method.
2084
2085 2019-05-08  Tom Tromey  <tromey@adacore.com>
2086
2087         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2088         when no wrap column is set.
2089
2090 2019-05-08  Tom Tromey  <tromey@adacore.com>
2091
2092         * c-lang.c (c_get_string): Handle non-C-style arrays.
2093
2094 2019-05-08  Tom Tromey  <tromey@adacore.com>
2095
2096         * typeprint.c (print_offset_data::update): Print the bit offset,
2097         not the number of bits remaining.
2098
2099 2019-05-08  Tom Tromey  <tromey@adacore.com>
2100
2101         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2102         padding at end of comment.
2103
2104 2019-05-08  Tom Tromey  <tromey@adacore.com>
2105
2106         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2107         Compare main types.
2108
2109 2019-05-06  Tom Tromey  <tom@tromey.com>
2110
2111         * common/scoped_mmap.c: Include common-defs.h.
2112         * common/scoped_mmap.h: Don't include config.h.
2113
2114 2019-05-04  Tom Tromey  <tom@tromey.com>
2115
2116         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2117         (struct aarch64_call_info): Add initializers.
2118         <si>: Now a std::vector.
2119         (pass_on_stack, aarch64_push_dummy_call): Update.
2120
2121 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2122             Tom Tromey  <tom@tromey.com>
2123
2124         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2125         (ppc_threads): Now a std::vector.  Now static.
2126         (hwdebug_find_thread_points_by_tid)
2127         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2128         Update.
2129
2130 2019-05-04  Tom Tromey  <tom@tromey.com>
2131
2132         * arc-tdep.c (arc_tdesc_init): Return bool.
2133
2134 2019-05-04  Tom Tromey  <tom@tromey.com>
2135
2136         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2137         Use gdb_assert_not_reached.
2138
2139 2019-05-04  Tom Tromey  <tom@tromey.com>
2140
2141         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2142         "false".
2143
2144 2019-05-04  Tom Tromey  <tom@tromey.com>
2145
2146         * arc-tdep.c (arc_tdesc_init): Use bool.
2147
2148 2019-05-04  Tom Tromey  <tom@tromey.com>
2149
2150         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2151
2152 2019-05-04  Tom Tromey  <tom@tromey.com>
2153
2154         * cli/cli-cmds.c (valid_command_p): Return bool.
2155
2156 2019-05-04  Tom Tromey  <tom@tromey.com>
2157
2158         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2159         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2160
2161 2019-05-04  Raul Tambre  <raul@tambre.ee>
2162
2163         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2164         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2165         operator for comparison.
2166
2167 2019-05-04  Tom Tromey  <tom@tromey.com>
2168
2169         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2170         (lookup_partial_symbol, print_partial_symbols)
2171         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2172         (psymbol_compare): Update.
2173         (add_psymbol_to_bcache): Clear the entire psymbol.
2174         (maintenance_check_psymtabs): Update.
2175         * psympriv.h (struct partial_symbol): Don't derive from
2176         general_symbol_info.
2177         <obj_section, unrelocated_address, address,
2178         set_unrelocated_address>: Update.
2179         <ginfo>: New member.
2180         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2181         (debug_names::write_psymbols): Update.
2182
2183 2019-05-04  Tom de Vries  <tdevries@suse.de>
2184
2185         * contrib/cc-with-tweaks.sh: Support -n arg.
2186
2187 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2188
2189         * corelow.c (core_target::detach): Ensure frame cache and
2190         register caches are cleared.
2191         inferior.c (exit_inferior_1): Likewise.
2192
2193 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2194             Tom Tromey  <tom@tromey.com>
2195
2196         * dictionary.c (collate_pending_symbols_by_language): Remove
2197         "struct" from foreach.
2198         * symtab.c (lookup_global_symbol_from_objfile)
2199         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2200         foreach.
2201         * ser-tcp.c (net_open): Remove "struct" from foreach.
2202         * objfiles.c (objfile_relocate, objfile_rebase)
2203         (objfile_has_symbols): Remove "struct" from foreach.
2204         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2205         from foreach.
2206         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2207         foreach.
2208         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2209         "struct" from foreach.
2210         * ada-lang.c (create_excep_cond_exprs)
2211         (ada_exception_catchpoint_cond_string): Remove "struct" from
2212         foreach.
2213
2214 2019-05-03  Tom Tromey  <tromey@adacore.com>
2215
2216         * ada-exp.y (convert_char_literal): Check suffix of each
2217         enumerator.
2218
2219 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2220
2221         PR ada/21406:
2222         * ada-exp.y (yywrap): Don't define.
2223         * ada-lex.l (%option): Add noyywrap
2224         (yywrap): Remove.
2225
2226 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2227
2228         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2229         _WIN32_WINNT to the XP level, unless already defined to a higher
2230         level.
2231
2232         * unittests/parse-connection-spec-selftests.c:
2233         * ser-tcp.c:
2234         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2235         override.
2236
2237         * symfile.c (find_separate_debug_file): Remove colon from the
2238         drive spec of DOS/Windows file names of the target, so that the
2239         file name produced from DEBUGDIR and the target's directory will
2240         be valid on DOS/Windows systems.
2241
2242 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * rust-lang.c (val_print_struct): Handle printing structures
2245         containing strings.
2246
2247 2019-05-02  Tom Tromey  <tromey@adacore.com>
2248
2249         * valarith.c (_initialize_valarith): Remove.
2250
2251 2019-05-01  Tom Tromey  <tromey@adacore.com>
2252
2253         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2254         bitfields.
2255
2256 2019-05-01  Tom Tromey  <tromey@adacore.com>
2257
2258         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2259         for big-endian copies.
2260
2261 2019-04-30  Ali Tamur  <tamur@google.com>
2262         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2263         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2264         (read_3_bytes): New function.
2265
2266 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2267
2268         * windows-nat.c (main_thread_id): Delete.
2269         (handle_output_debug_string): Replace main_thread_id by
2270         current_event.dwThreadId.
2271         (fake_create_process): Likewise.
2272         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2273         Do not set main_thread_id.
2274         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2275         current_event.dwThreadId.
2276         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2277
2278 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2279
2280         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2281         Use current_event.dwThreadId instead of main_thread_id.
2282
2283 2019-04-30  Tom Tromey  <tromey@adacore.com>
2284
2285         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2286         (create_excep_cond_exprs): Iterate over program spaces.
2287         (ada_exception_catchpoint_cond_string): Examine all minimal
2288         symbols for exception types.
2289
2290 2019-04-30  Tom Tromey  <tromey@adacore.com>
2291
2292         PR c++/24470:
2293         * dwarf2read.c (process_structure_scope): Handle case where type
2294         has template parameters but no symbol was created.
2295
2296 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2297             Chris January  <chris.january@arm.com>
2298
2299         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2300         qualifier.
2301         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2302
2303 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * f-typeprint.c (f_print_type): Update rules for printing
2306         whitespace.
2307         (f_type_print_varspec_suffix): Likewise.
2308
2309 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2310             Chris January  <chris.january@arm.com>
2311
2312         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2313         function arguments.
2314
2315 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * f-lang.c (build_fortran_types): Change name of void type to
2318         lower case.
2319         * f-typeprint.c (f_type_print_base): Print the name of the void
2320         type, rather than a fixed string.
2321         * f-valprint.c (f_decorations): Use lower case void string.
2322
2323 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2324             Chris January  <chris.january@arm.com>
2325
2326         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2327         types for Fortran.
2328
2329 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2330             Chris January  <chris.january@arm.com>
2331             David Lecomber  <david.lecomber@arm.com>
2332
2333         * f-exp.y (BINOP_INTRINSIC): New token.
2334         (exp): New parser rule handling BINOP_INTRINSIC.
2335         (f77_keywords): Add new builtin procedures.
2336         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2337         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2338         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2339         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2340         (print_unop_subexp_f): New function.
2341         (print_binop_subexp_f): New function.
2342         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2343         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2344         (dump_subexp_body_f): Likewise.
2345         (operator_check_f): Likewise.
2346         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2347         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2348
2349 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2352         UNOP_KIND.
2353         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2354         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2355         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2356         (operator_length_f): New fuction.
2357         (print_subexp_f): New function.
2358         (op_name_f): New function.
2359         (dump_subexp_body_f): New function.
2360         (operator_check_f): New function.
2361         (exp_descriptor_f): Replace standard expression handling functions
2362         with new functions.
2363         * gdb/fortran-operator.def: New file.
2364         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2365         * gdb/std-operator.def: Remove UNOP_KIND.
2366
2367 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * std-operator.def: Remove unbalanced, stray double quote
2370         character.
2371
2372 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2373             Chris January  <chris.january@arm.com>
2374             Daniel Everett  <daniel.everett@arm.com>
2375             Nick Forrington  <nick.forrington@arm.com>
2376             Richard Bunt  <richard.bunt@arm.com>
2377
2378         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2379         of depth when printing anonymous structs or unions.
2380         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2381         Don't print either the top-level value, or the children if the
2382         max-depth is exceeded.
2383         (ppscm_print_children): When printing the key of a map, allow one
2384         extra level of depth.
2385         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2386         print either the top-level value, or the children if the max-depth
2387         is exceeded.
2388         (print_children): When printing the key of a map, allow one extra
2389         level of depth.
2390         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2391         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2392         (user_print_options): Initialise max_depth field.
2393         (val_print_scalar_or_string_type_p): New function.
2394         (val_print): Check to see if the max depth has been reached.
2395         (val_print_check_max_depth): Define new function.
2396         (show_print_max_depth): New function.
2397         (_initialize_valprint): Add 'print max-depth' option.
2398         * valprint.h (struct value_print_options) <max_depth>: New field.
2399         (val_print_check_max_depth): Declare new function.
2400         * NEWS: Document new feature.
2401
2402 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * ada-lang.c (ada_language_defn): Initialise new field.
2405         * c-lang.c (c_is_string_type_p): New function.
2406         (c_language_defn): Initialise new field.
2407         (cplus_language_defn): Initialise new field.
2408         (asm_language_defn): Initialise new field.
2409         (minimal_language_defn): Initialise new field.
2410         * c-lang.h (c_is_string_type_p): Declare new function.
2411         * d-lang.c (d_language_defn): Initialise new field.
2412         * f-lang.c (f_is_string_type_p): New function.
2413         (f_language_defn): Initialise new field.
2414         * go-lang.c (go_is_string_type_p): New function.
2415         (go_language_defn): Initialise new field.
2416         * language.c (default_is_string_type_p): New function.
2417         (unknown_language_defn): Initialise new field.
2418         (auto_language_defn): Initialise new field.
2419         * language.h (struct language_defn) <la_is_string_type_p>: New
2420         member variable.
2421         (default_is_string_type_p): Declare new function.
2422         * m2-lang.c (m2_language_defn): Initialise new field.
2423         * objc-lang.c (objc_language_defn): Initialise new field.
2424         * opencl-lang.c (opencl_language_defn): Initialise new field.
2425         * p-lang.c (pascal_is_string_type_p): New function.
2426         (pascal_language_defn): Initialise new field.
2427         * rust-lang.c (rust_is_string_type_p): New function.
2428         (rust_language_defn): Initialise new field.
2429
2430 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2433         New field.
2434         * ada-lang.c (ada_language_defn): Initialise new field.
2435         * c-lang.c (c_language_defn): Likewise.
2436         (cplus_language_defn): Likewise.
2437         (asm_language_defn): Likewise.
2438         (minimal_language_defn): Likewise.
2439         * d-lang.c (d_language_defn): Likewise.
2440         * f-lang.c (f_language_defn): Likewise.
2441         * go-lang.c (go_language_defn): Likewise.
2442         * language.c (unknown_language_defn): Likewise.
2443         (auto_language_defn): Likewise.
2444         * m2-lang.c (m2_language_defn): Likewise.
2445         * objc-lang.c (objc_language_defn): Likewise.
2446         * opencl-lang.c (opencl_language_defn): Likewise.
2447         * p-lang.c (pascal_language_defn): Likewise.
2448         * rust-lang.c (rust_language_defn): Likewise.
2449
2450 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * ada-lang.c (ada_is_character_type): Change return type to bool.
2453         (ada_is_string_type): Likewise.
2454         * ada-lang.h (ada_is_character_type): Update declaration
2455         (ada_is_string_type): Likewise.
2456
2457 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2458
2459         Support style in 'frame|thread apply'
2460
2461         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2462         * record.c (record_start, record_stop): Update callers of
2463         execute_command_to_string with false.
2464         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2465         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2466         methods.
2467         (class string_file): New constructor with term_out parameter.
2468         Override methods term_out and can_emit_style_escape.  New member
2469         term_out.
2470         (class stdio_file): Override can_emit_style_escape.
2471         (class tee_file): Override term_out and can_emit_style_escape.
2472         * utils.h (can_emit_style_escape): Remove.
2473         * utils.c (can_emit_style_escape): Likewise.
2474         Update all callers of can_emit_style_escape (SOMESTREAM) to
2475         SOMESTREAM->can_emit_style_escape.
2476         * source-cache.c (source_cache::get_source_lines): Likewise.
2477         * stack.c (frame_apply_command_count): Call execute_command_to_string
2478         passing the term_out characteristic of the current gdb_stdout.
2479         * thread.c (thr_try_catch_cmd): Likewise.
2480         * top.c (execute_command_to_string): pass term_out parameter
2481         to construct the string_file for the command output.
2482         * ui-file.c (term_cli_styling): New function (most code moved
2483         from utils.c can_emit_style_escape).
2484         (string_file::string_file, string_file::can_emit_style_escape,
2485         stdio_file::can_emit_style_escape, tee_file::term_out,
2486         tee_file::can_emit_style_escape): New functions.
2487
2488 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2489
2490         * NEWS: Mention the new set|show may-call-functions.
2491         * infcall.c (may_call_functions_p): New variable.
2492         (show_may_call_functions_p): New function.
2493         (call_function_by_hand_dummy): Throws an error if not
2494         may-call-functions.
2495         (_initialize_infcall): Call add_setshow_boolean_cmd for
2496         may-call-functions.
2497
2498 2019-04-25  Keith Seitz  <keiths@redhat.com>
2499
2500         PR c++/24367
2501         * cp-support.c (inspect_type): Don't attempt substitutions
2502         of symbol with the same name.
2503
2504 2019-04-25  Tom Tromey  <tromey@adacore.com>
2505
2506         PR gdb/24475:
2507         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2508         static.
2509
2510 2019-04-25  Tom Tromey  <tromey@adacore.com>
2511
2512         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2513         rvalue reference.
2514         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2515         (gdb_xml_parser::parse): Use std::move.
2516         * python/python-internal.h (gdbpy_convert_exception): Take a const
2517         reference.
2518         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2519         std::move.
2520         * python/py-utils.c (gdbpy_convert_exception): Take a const
2521         reference.
2522         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2523         Use std::move.
2524         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2525         Use std::move.
2526         * mi/mi-main.c (mi_print_exception): Take a const reference.
2527         * main.c (handle_command_errors): Take a const reference.
2528         * linespec.c (parse_linespec): Use std::move.
2529         * infcall.c (run_inferior_call): Use std::move.
2530         (call_function_by_hand_dummy): Use std::move.
2531         * exec.c (try_open_exec_file): Use std::move.
2532         * exceptions.h (exception_print, exception_fprintf)
2533         (exception_print_same): Update.
2534         * exceptions.c (print_exception, exception_print)
2535         (exception_fprintf, exception_print_same): Change parameters to
2536         const reference.
2537         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2538         * common/new-op.c: Use std::move.
2539         * common/common-exceptions.h (struct gdb_exception): Add move
2540         constructor.
2541         (struct gdb_exception_error, struct gdb_exception_quit, struct
2542         gdb_quit_bad_alloc): Change constructor to move constructor.
2543         (throw_exception): Change parameter to rvalue reference.
2544         * common/common-exceptions.c (throw_exception): Take rvalue
2545         reference.
2546         * cli/cli-interp.c (safe_execute_command): Use std::move.
2547         * breakpoint.c (insert_bp_location, location_to_sals): Use
2548         std::move.
2549
2550 2019-04-25  Tom Tromey  <tromey@adacore.com>
2551
2552         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2553         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2554         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2555         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2556         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2557         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2558         guile/scm-value.c: Use unpack.
2559         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2560         gdbscm_gdb_exception.
2561         (gdbscm_throw_gdb_exception): Likewise.
2562         (struct gdbscm_gdb_exception): New.
2563         (unpack): New function.
2564         (gdbscm_wrap): Use unpack.
2565
2566 2019-04-25  Tom Tromey  <tromey@adacore.com>
2567
2568         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2569         (gdb_rl_callback_handler): Use std::move.
2570         * common/common-exceptions.h (struct gdb_exception): Add move
2571         assignment operator.
2572         (throw_exception_sjlj): Change "exception" to const reference.
2573         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2574         (throw_exception_sjlj): Change "exception" to const reference.
2575
2576 2019-04-25  Tom Tromey  <tromey@adacore.com>
2577
2578         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2579         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2580         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2581         Update.
2582         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2583         Update.
2584         * mi/mi-interp.c (mi_interp::exec): Update.
2585         * linespec.c (parse_linespec): Update.
2586         * infcall.c (run_inferior_call): Update.
2587         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2588         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2589         (gdbscm_lookup_global_symbol): Update.
2590         * guile/scm-param.c (gdbscm_parameter_value): Update.
2591         * guile/scm-frame.c (gdbscm_frame_read_register)
2592         (gdbscm_frame_read_var): Update.
2593         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2594         * exec.c (try_open_exec_file): Update.
2595         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2596         (gdb_rl_callback_handler): Update.
2597         * common/common-exceptions.h (exception_none): Don't declare.
2598         * common/common-exceptions.c (exception_none): Don't define.
2599         (struct catcher) <exception>: Update.
2600         * cli/cli-interp.c (safe_execute_command): Update.
2601         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2602
2603 2019-04-25  Ali Tamur  <tamur@google.com>
2604
2605         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2606         (read_attribute_value): Likewise.
2607         (dwarf2_read_addr_index): Update comment.
2608         (read_str_index): Add DW_FORM_strx.
2609         (dwarf2_string_attr): Likewise.
2610         (dwarf2_const_value_attr): Likewise.
2611         (dump_die_shallow): Likewise.
2612         (dwarf2_fetch_constant_bytes): Likewise.
2613         (skip_form_bytes): Likewise.
2614         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2615
2616 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2617
2618         PR corefiles/11608
2619         PR corefiles/18187
2620         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2621         OFFSET.  Verify if current mapping contains an ELF header.
2622         (linux_find_memory_regions_full): Adjust call to
2623         dump_mapping_p.
2624
2625 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2626             Kang Li <kanglictf@gmail.com>
2627
2628         PR gdb/21600
2629
2630         * dwarf2-frame.c (read_initial_length): Be consistent about using
2631         unsigned representation of length.
2632         (decode_frame_entry_1): Likewise.  Check for wraparound of
2633         end pointer as well as buffer overflow.
2634
2635 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2636
2637         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2638         "vq".
2639
2640 2019-04-24  Tom Tromey  <tromey@adacore.com>
2641
2642         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2643
2644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * s12z-tdep.c (s12z_unwind_pc): Delete.
2647         (s12z_unwind_sp): Delete.
2648         (s12z_gdbarch_init): Don't register deleted functions with
2649         gdbarch.
2650
2651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * rl78-tdep.c (rl78_unwind_sp): Delete.
2654         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2655
2656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2659         (xstormy16_unwind_pc): Delete.
2660         (xstormy16_dummy_id): Delete.
2661         (xstormy16_gdbarch_init): Don't register deleted functions with
2662         gdbarch.
2663
2664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * vax-tdep.c (vax_unwind_pc): Delete.
2667         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2668
2669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * v850-tdep.c (v850_unwind_sp): Delete.
2672         (v850_unwind_pc): Delete.
2673         (v850_dummy_id): Delete.
2674         (v850_gdbarch_init): Don't register deleted functions with
2675         gdbarch.
2676
2677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2680         (tilegx_unwind_pc): Delete.
2681         (tilegx_unwind_dummy_id): Delete.
2682         (tilegx_gdbarch_init): Don't register deleted functions with
2683         gdbarch.
2684
2685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2688         (tic6x_dummy_id): Delete.
2689         (tic6x_gdbarch_init): Don't register deleted functions with
2690         gdbarch.
2691
2692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * sparc-tdep.c (sparc_unwind_pc): Delete.
2695         (sparc32_gdbarch_init): Don't register deleted function with
2696         gdbarch.
2697
2698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * sh-tdep.c (sh_unwind_sp): Delete.
2701         (sh_unwind_pc): Delete.
2702         (sh_dummy_id): Delete.
2703         (sh_gdbarch_init): Don't register deleted functions with
2704         gdbarch.
2705
2706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * score-tdep.c (score_unwind_sp): Delete.
2709         (score_unwind_pc): Delete.
2710         (score_dummy_id): Delete.
2711         (score_gdbarch_init): Don't register deleted functions with
2712         gdbarch.
2713
2714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2715
2716         * rx-tdep.c (rx_unwind_pc): Delete.
2717         (rx_unwind_sp): Delete.
2718         (rx_dummy_id): Delete.
2719         (rx_gdbarch_init): Don't register deleted functions with
2720         gdbarch.  Update comment.
2721
2722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2725         (rs6000_dummy_id): Delete.
2726         (rs6000_gdbarch_init): Don't register deleted functions with
2727         gdbarch.
2728
2729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * or1k-tdep.c (or1k_dummy_id): Delete.
2732         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2733
2734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2735
2736         * nios2-tdep.c (nios2_dummy_id): Delete.
2737         (nios2_unwind_sp): Delete.
2738         (nios2_gdbarch_init): Don't register deleted functions with
2739         gdbarch.
2740
2741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2742
2743         * nds32-tdep.c (nds32_dummy_id): Delete.
2744         (nds32_unwind_pc): Delete.
2745         (nds32_unwind_sp): Delete.
2746         (nds32_gdbarch_init): Don't register deleted functions with
2747         gdbarch.
2748
2749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * msp430-tdep.c (msp430_unwind_pc): Delete.
2752         (msp430_unwind_sp): Delete.
2753         (msp430_dummy_id): Delete.
2754         (msp430_gdbarch_init): Don't register deleted functions with
2755         gdbarch.
2756
2757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * moxie-tdep.c (moxie_unwind_sp): Delete.
2760         (moxie_unwind_pc): Delete.
2761         (moxie_dummy_id): Delete.
2762         (moxie_gdbarch_init): Don't register deleted functions with
2763         gdbarch.
2764
2765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2768         (mn10300_unwind_pc): Delete.
2769         (mn10300_unwind_sp): Delete.
2770         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2771         mn10300_unwind_sp.
2772         (mn10300_frame_unwind_init): Don't register deleted functions with
2773         gdbarch.
2774
2775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * mep-tdep.c (mep_unwind_pc): Delete.
2778         (mep_unwind_sp): Delete.
2779         (mep_dummy_id): Delete.
2780         (mep_gdbarch_init): Don't register deleted functions with
2781         gdbarch.
2782
2783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2784
2785         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2786         (m68hc11_unwind_sp): Delete.
2787         (m68hc11_gdbarch_init): Don't register deleted functions with
2788         gdbarch.
2789
2790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2791
2792         * m32r-tdep.c (m32r_unwind_sp): Delete.
2793         (m32r_unwind_pc): Delete.
2794         (m32r_dummy_id): Delete.
2795         (m32r_gdbarch_init): Don't register deleted functions with
2796         gdbarch.
2797
2798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * m32c-tdep.c (m32c_unwind_pc): Delete.
2801         (m32c_unwind_sp): Delete.
2802         (m32c_dummy_id): Delete.
2803         (m32c_gdbarch_init): Don't register deleted functions with
2804         gdbarch.
2805
2806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2809         (lm32_unwind_pc): Delete.
2810         (lm32_dummy_id): Delete.
2811         (lm32_gdbarch_init): Don't register deleted functions with
2812         gdbarch.
2813
2814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2817         (iq2000_unwind_pc): Delete.
2818         (iq2000_dummy_id): Delete.
2819         (iq2000_gdbarch_init): Don't register deleted functions with
2820         gdbarch.
2821
2822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2823
2824         * nds32-tdep.c (nds32_type_align): Delete.
2825         (nds32_push_dummy_call): Use type_align instead.
2826
2827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * arm-tdep.c (arm_type_align): Only handle vector override case.
2830         (arm_push_dummy_call): Use type_align.
2831         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2832
2833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2836         case.
2837         (pass_on_stack): Use type_align.
2838         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2839         function.
2840
2841 2019-04-23  Tom Tromey  <tromey@adacore.com>
2842
2843         * dwarf2read.c (line_header::file_name_at): Remove unused
2844         overload.
2845
2846 2019-04-23  Tom de Vries  <tdevries@suse.de>
2847
2848         PR gdb/24438
2849         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2850         invocation.
2851
2852
2853 2019-03-27  Ali Tamur  <tamur@google.com>
2854
2855         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2856         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2857         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2858         (dwarf_expr_context::get_addr_index): Likewise
2859         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2860         (symbol_needs_eval_context::get_addr_index): Likewise
2861         (disassemble_dwarf_expression): Add DW_OP_addrx
2862         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2863         (read_cutu_die_from_dwo): Update comment
2864         (skip_one_die): Add DW_FORM_addrx
2865         (read_attribute_value): Likewise
2866         (var_decode_location): Add DW_OP_addrx
2867         (dwarf2_const_value_attr): Add DW_FORM_addrx
2868         (dump_die_shallow): Likewise
2869         (dwarf2_fetch_constant_bytes): Likewise
2870         (decode_locdesc): Add DW_OP_addrx
2871         (skip_form_bytes): Add DW_FORM_addrx
2872
2873 2019-04-22  Ali Tamur  <tamur@google.com>
2874
2875         * MAINTAINERS (Write After Approval): Add self.
2876
2877 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2878
2879         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2880         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2881         (open_symbol_file_object): Likewise.
2882         (svr4_default_sos): Add info parameter.
2883         (svr4_read_so_list): Likewise.
2884         (svr4_current_sos_direct): Adjust functions calls to pass down
2885         info.
2886         (svr4_current_sos_1): Add info parameter.
2887         (svr4_current_sos): Call get_svr4_info, pass info down to
2888         svr4_current_sos_1.
2889         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2890         get_svr4_info.
2891         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2892         get_svr4_info.
2893         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2894         to get_svr4_info.
2895         (probes_table_remove_objfile_probes): Likewise.
2896         (register_solib_event_probe): Add info parameter.
2897         (solist_update_incremental): Pass info parameter down to
2898         svr4_read_so_list.
2899         (disable_probes_interface): Add info parameter.
2900         (svr4_handle_solib_event): Pass current_program_space to
2901         get_svr4_info.  Adjust disable_probes_interface cleanup.
2902         (svr4_create_probe_breakpoints): Add info parameter, pass it
2903         down to register_solib_event_probe.
2904         (svr4_create_solib_event_breakpoints): Add info parameter,
2905         pass it down to svr4_create_probe_breakpoints.
2906         (enable_break): Pass info down to
2907         svr4_create_solib_event_breakpoints.
2908         (svr4_solib_create_inferior_hook): Pass current_program_space to
2909         get_svr4_info.
2910         (svr4_clear_solib): Likewise.
2911
2912 2019-04-22  Pedro Alves  <palves@redhat.com>
2913
2914         * solib-svr4.c (svr4_free_objfile_observer): New.
2915         (probe_and_action::objfile): New field.
2916         (probes_table_htab_remove_objfile_probes)
2917         (probes_table_remove_objfile_probes): New functions.
2918         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2919         in the new probe_and_action.  Don't store the probe in 'lookup'.
2920         (svr4_create_probe_breakpoints): Pass objfile to
2921         register_solib_event_probe.
2922         (_initialize_svr4_solib): Register a free_objfile observer.
2923
2924 2019-04-19  Tom Tromey  <tom@tromey.com>
2925
2926         * common/queue.h: Remove.
2927
2928 2019-04-19  Tom Tromey  <tom@tromey.com>
2929
2930         * event-loop.c: Don't include "common/queue.h".
2931
2932 2019-04-19  Tom Tromey  <tom@tromey.com>
2933
2934         * remote.c (remote_target): Use delete.
2935         * remote-notif.h: Include <list>, not "common/queue.h".
2936         (notif_client_p): Remove typedef.
2937         (remote_notif_state): Add constructor, destructor, initializer.
2938         <notif_queue>: Now a std::list.
2939         (remote_notif_state_xfree): Don't declare.
2940         * remote-notif.c (remote_notif_process, handle_notification)
2941         (remote_notif_state_allocate): Update.
2942         (~remote_notif_state): Rename from remote_notif_state_xfree.
2943
2944 2019-04-19  Tom Tromey  <tom@tromey.com>
2945
2946         * symfile.c (reread_symbols): Update.
2947         * objfiles.c (objfile_register_static_link)
2948         (objfile_lookup_static_link): Update
2949         (~objfile) Don't delete static_links.
2950         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2951
2952 2019-04-19  Tom Tromey  <tom@tromey.com>
2953
2954         * type-stack.h (struct type_stack) <insert>: Constify string.
2955         * type-stack.c (type_stack::insert): Constify string.
2956         * gdbtypes.h (lookup_template_type): Update.
2957         (address_space_name_to_int): Update.
2958         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2959         const.
2960         (lookup_template_type): Make name const.
2961         * c-exp.y: Update rules.
2962         (lex_one_token, classify_name, classify_inner_name)
2963         (c_print_token): Update.
2964         * p-exp.y: Update rules.
2965         (yylex): Update.
2966         * f-exp.y: Update rules.
2967         (yylex): Update.
2968         * d-exp.y: Update rules.
2969         (lex_one_token, classify_name, classify_inner_name): Update.
2970         * parse.c (write_dollar_variable, copy_name): Return std::string.
2971         * parser-defs.h (copy_name): Change return type.
2972         * m2-exp.y: Update rules.
2973         (yylex): Update.
2974         * go-exp.y (lex_one_token): Update.
2975         Update rules.
2976         (classify_unsafe_function, classify_packaged_name)
2977         (classify_name, yylex): Update.
2978
2979 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2980
2981         * configure.ac: add --enable-source-highlight switch.
2982         * configure: Regenerate.
2983         * top.c (print_gdb_version): plumb --enable-source-highlight
2984         status to "show configuration".
2985
2986 2019-04-19  Tom Tromey  <tromey@adacore.com>
2987
2988         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2989         Check ADA_TYPE_P.
2990         (empty_record, ada_template_to_fixed_record_type_1)
2991         (template_to_static_fixed_type)
2992         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2993         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2994         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2995         macros.
2996
2997 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2998
2999         PR symtab/24423:
3000         * source.c (print_source_lines_base): Advance "iter" when a
3001         control character is seen.
3002
3003 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3004
3005         * inferior.h (struct infcall_suspend_state_deleter):
3006         Catch exception in destructor to avoid crash.
3007
3008 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3009
3010         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3011         close to the add_com "shell".
3012
3013 2019-04-18  Tom Tromey  <tromey@adacore.com>
3014
3015         * process-stratum-target.h (class process_stratum_target)
3016         <stratum>: Add "final".
3017
3018 2019-04-17  Tom Tromey  <tromey@adacore.com>
3019
3020         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3021         against nullptr before use.
3022
3023 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3024
3025         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3026
3027 2019-04-17  Jim Wilson  <jimw@sifive.com>
3028             Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3031         code read might fail, assume 4-byte breakpoint in that case.
3032
3033 2019-04-15  Leszek Swirski  <leszeks@google.com>
3034
3035         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3036         rather than a hand-rolled POD check when checking for forced MEMORY
3037         classification.
3038
3039 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3040
3041         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3042         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3043         function.
3044         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3045         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3046         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3047         declaration.
3048
3049 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3050
3051         * aarch64-linux-nat.c
3052         (aarch64_linux_nat_target::thread_architecture): Add override.
3053         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3054         each VQ.
3055
3056 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3057
3058         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3059
3060 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3063         target types of size 96-bits, add some additional comments, and
3064         check that the builtin type we found was the correct size.
3065
3066 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3067
3068         * utils.c (prompt_for_continue): Don't restore the styling at the
3069         end, as applied_style has the wrong value.  This fixes styling in
3070         long lists of file names that are interrupted by the "Continue?"
3071         prompt.
3072
3073 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3076         * c-lang.c (c_language_defn): Likewise.
3077         (cplus_language_defn): Likewise.
3078         (asm_language_defn): Likewise.
3079         (minimal_language_defn): Likewise.
3080         * d-lang.c (d_language_defn): Likewise.
3081         * f-lang.c (f_language_defn): Likewise.
3082         * go-lang.c (go_language_defn): Likewise.
3083         * language.c (unknown_language_defn): Likewise.
3084         (auto_language_defn): Likewise.
3085         * language.h (struct language_defn): Remove la_magic field.
3086         (LANG_MAGIC): Delete.
3087         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3088         * objc-lang.c (objc_language_defn): Likewise.
3089         * opencl-lang.c (opencl_language_defn): Likewise.
3090         * p-lang.c (pascal_language_defn): Likewise.
3091         * rust-lang.c (rust_language_defn): Likewise.
3092
3093 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * riscv-tdep.c (riscv_type_align): New function.
3096         (riscv_type_alignment): Delete.
3097         (riscv_arg_location): Use 'type_align'.
3098         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3099
3100 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * gdbtypes.c (type_align): A struct with no non-static fields also
3103         has alignment of 1.
3104
3105 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3108         component to 0.
3109         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3110         member.
3111         (riscv_struct_info::analyse): New implementation using new
3112         analyse_inner member function.
3113         (riscv_struct_info::field_offset): New member function.
3114         (riscv_struct_info::m_offsets): New member variable.
3115         (riscv_struct_info::analyse_inner): New private member function,
3116         takes the old implementation of riscv_struct_info::analyse but
3117         extended to track field offsets.
3118         (riscv_call_arg_struct): Update the struct folding special cases
3119         to handle cases where empty C++ structs, which are non-zero
3120         length, are found.
3121         (riscv_arg_location): Initialise the length of each location, a
3122         non-zero length now indicates the location is in use.
3123         (riscv_push_dummy_call): Allow for the first location having a
3124         non-zero offset when setting up arguments.
3125         (riscv_return_value): Likewise, but for return values.
3126
3127 2019-04-11  Tom Tromey  <tromey@adacore.com>
3128
3129         * utils.c (internal_vproblem): Make "msg" const.
3130
3131 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3132
3133         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3134         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3135         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3136         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3137
3138 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3139
3140         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3141         function.
3142         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3143         of amd64_collect_native_gregset.
3144         (amd64_linux_nat_target::store_registers): Likewise.
3145
3146 2019-04-10  Tom Tromey  <tom@tromey.com>
3147
3148         * symtab.c (lookup_global_symbol_from_objfile)
3149         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3150         * objfiles.h (class separate_debug_iterator): New.
3151         (class separate_debug_range): New.
3152         (struct objfile) <separate_debug_objfiles>: New method.
3153         (objfile_separate_debug_iterate): Don't declare.
3154         * objfiles.c (separate_debug_iterator::operator++): Rename from
3155         objfile_separate_debug_iterate.
3156         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3157         iterator.
3158         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3159         iterator.
3160
3161 2019-04-10  Tom Tromey  <tom@tromey.com>
3162
3163         * symfile.c (reread_symbols): Remove old comment.
3164         * objfiles.c (free_all_objfiles): Fix a typo.
3165
3166 2019-04-10  Tom Tromey  <tom@tromey.com>
3167
3168         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3169         * minsyms.c (lookup_minimal_symbol): Use foreach.
3170         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3171         (lookup_minimal_symbol_solib_trampoline): Likewise.
3172         * symfile.c (reread_symbols): Use foreach.
3173
3174 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3175             Tom Tromey  <tromey@adacore.com>
3176
3177         PR rust/24414:
3178         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3179         (rust_lex_int_test): Change "value" to be LONGEST.
3180         (rust_lex_tests): Add test for long integer literal.
3181
3182 2019-04-09  Tom Tromey  <tromey@adacore.com>
3183
3184         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3185         to bool.
3186         (extended_remote_target::attach): Update.
3187         (remote_target::remote_notice_new_inferior): Update.
3188         (remote_target::add_current_inferior_and_thread): Update.
3189         * inferior.c (exit_inferior_1): Use "false".
3190         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3191
3192 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3193
3194         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3195         the "start" command.
3196
3197 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3198
3199         * python/py-inferior.c (infpy_thread_from_thread_handle):
3200         Adjust comments to reflect renaming of thread_from_thread_handle
3201         to thread_from_handle.  Adjust keywords.  Fix type error message.
3202         (inferior_object_methods): Add thread_from_handle.  Retain
3203         thread_from_thread_handle, but mark it as deprecated.
3204
3205 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3206
3207         * gdbthread.h (find_thread_by_handle): Revise declaration.
3208         * thread.c (find_thread_by_handle): Likewise.  Adjust
3209         implementation too.
3210         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3211         support for buffer objects as handles.
3212
3213 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3214
3215         * python/py-infthread.c (thpy_thread_handle): New function.
3216         (thread_object_methods): Register thpy_thread_handle.
3217
3218 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3219
3220         * gdbthread.h (thread_to_thread_handle): Declare.
3221         * thread.c (gdbtypes.h): Include.
3222         (thread_to_thread_handle): New function.
3223
3224         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3225         (target_thread_info_to_thread_handle): Declare.
3226         * target.c (target_thread_info_to_thread_handle): New function.
3227         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3228         * target-delegates.c: Regenerate.
3229
3230         * linux-thread-db.c (class thread_db_target): Add method
3231         thread_info_to_thread_handle.
3232         (thread_db_target::thread_info_to_thread_handle): Define.
3233         * remote.c (class remote_target): Add new method
3234         thread_info_to_thread_handle.
3235         (remote_target::thread_info_to_thread_handle): Define.
3236
3237 2019-04-08  Pedro Alves  <palves@redhat.com>
3238
3239         * common/common-exceptions.c (throw_exception): Don't create
3240         named object to throw; throw directly.
3241         (throw_it): Likewise.  Don't initialize gdb_exception::message
3242         here, with new; pass FMT and AP to the ctor instead.
3243         * common/common-exceptions.h: Include <string>.
3244         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3245         const char *, va_list)): New ctor.  Use std::make_shared.
3246         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3247         errors)): Delete.
3248         (gdb_exception_error::gdb_exception_error(enum errors, const char
3249         *, va_list)): New.
3250         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3251         Add assertion.
3252         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3253         errors)): Delete.
3254         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3255         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3256         Add assertion.
3257
3258 2019-04-08  Tom Tromey  <tom@tromey.com>
3259
3260         * valops.c (value_rtti_indirect_type): Replace throw_exception
3261         with throw.
3262         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3263         with throw.
3264         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3265         throw.
3266         * target.c (target_translate_tls_address): Replace throw_exception
3267         with throw.
3268         * stack.c (frame_apply_command_count): Replace throw_exception
3269         with throw.
3270         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3271         throw.
3272         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3273         with throw.
3274         * rs6000-tdep.c (rs6000_frame_cache)
3275         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3276         * remote.c: Replace throw_exception with throw.
3277         * record-full.c (record_full_message, record_full_wait_1)
3278         (record_full_restore): Replace throw_exception with throw.
3279         * record-btrace.c:
3280         (get_thread_current_frame_id, record_btrace_start_replaying)
3281         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3282         (cmd_record_btrace_start): Replace throw_exception with throw.
3283         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3284         throw.
3285         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3286         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3287         * linespec.c:
3288         (find_linespec_symbols): Replace throw_exception with throw.
3289         * infrun.c (displaced_step_prepare, resume): Replace
3290         throw_exception with throw.
3291         * infcmd.c (post_create_inferior): Replace throw_exception with
3292         throw.
3293         * inf-loop.c (inferior_event_handler): Replace throw_exception
3294         with throw.
3295         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3296         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3297         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3298         (get_prev_frame_always, get_frame_pc_if_available)
3299         (get_frame_address_in_block_if_available, get_frame_language):
3300         Replace throw_exception with throw.
3301         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3302         throw_exception with throw.
3303         * eval.c (fetch_subexp_value, evaluate_var_value)
3304         (evaluate_funcall, evaluate_subexp_standard): Replace
3305         throw_exception with throw.
3306         * dwarf2loc.c (call_site_find_chain)
3307         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3308         Replace throw_exception with throw.
3309         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3310         with throw.
3311         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3312         throw.
3313         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3314         * completer.c (complete_line_internal): Replace throw_exception
3315         with throw.
3316         * compile/compile-object-run.c (compile_object_run): Replace
3317         throw_exception with throw.
3318         * cli/cli-script.c (process_next_line): Replace throw_exception
3319         with throw.
3320         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3321         (btrace_enable, btrace_maint_update_pt_packets): Replace
3322         throw_exception with throw.
3323         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3324         throw_exception with throw.
3325         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3326         throw_exception with throw.
3327         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3328         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3329         * aarch64-tdep.c (aarch64_make_prologue_cache)
3330         (aarch64_make_stub_cache): Replace throw_exception with throw.
3331
3332 2019-04-08  Tom Tromey  <tom@tromey.com>
3333
3334         * common/common-exceptions.c (throw_exception): Rename from
3335         throw_exception_cxx.  Remove old copy.  Make argument const.
3336         (throw_it): Create and throw exception objects directly.
3337         * common/common-exceptions.h (throw_exception): Make argument
3338         const.
3339         (struct gdb_exception_error): Add constructor.
3340         (struct gdb_exception_quit): Add constructor.
3341
3342 2019-04-08  Tom Tromey  <tom@tromey.com>
3343
3344         * common/common-exceptions.h (exception_rethrow): Don't declare.
3345         (TRY_SJLJ): Update comment.
3346         (TRY, CATCH, END_CATCH): Remove.
3347         * common/common-exceptions.c (exception_rethrow): Remove.
3348
3349 2019-04-08  Tom Tromey  <tom@tromey.com>
3350
3351         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3352         Remove.
3353         (gdb_exception_error): Rename from
3354         gdb_exception_RETURN_MASK_ERROR.
3355         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3356         (gdb_quit_bad_alloc): Update.
3357         * aarch64-tdep.c: Update.
3358         * ada-lang.c: Update.
3359         * ada-typeprint.c: Update.
3360         * ada-valprint.c: Update.
3361         * amd64-tdep.c: Update.
3362         * arch-utils.c: Update.
3363         * break-catch-throw.c: Update.
3364         * breakpoint.c: Update.
3365         * btrace.c: Update.
3366         * c-varobj.c: Update.
3367         * cli/cli-cmds.c: Update.
3368         * cli/cli-interp.c: Update.
3369         * cli/cli-script.c: Update.
3370         * common/common-exceptions.c: Update.
3371         * common/new-op.c: Update.
3372         * common/selftest.c: Update.
3373         * compile/compile-c-symbols.c: Update.
3374         * compile/compile-cplus-symbols.c: Update.
3375         * compile/compile-object-load.c: Update.
3376         * compile/compile-object-run.c: Update.
3377         * completer.c: Update.
3378         * corelow.c: Update.
3379         * cp-abi.c: Update.
3380         * cp-support.c: Update.
3381         * cp-valprint.c: Update.
3382         * darwin-nat.c: Update.
3383         * disasm-selftests.c: Update.
3384         * dtrace-probe.c: Update.
3385         * dwarf-index-cache.c: Update.
3386         * dwarf-index-write.c: Update.
3387         * dwarf2-frame-tailcall.c: Update.
3388         * dwarf2-frame.c: Update.
3389         * dwarf2loc.c: Update.
3390         * dwarf2read.c: Update.
3391         * eval.c: Update.
3392         * event-loop.c: Update.
3393         * event-top.c: Update.
3394         * exec.c: Update.
3395         * f-valprint.c: Update.
3396         * fbsd-tdep.c: Update.
3397         * frame-unwind.c: Update.
3398         * frame.c: Update.
3399         * gdbtypes.c: Update.
3400         * gnu-v3-abi.c: Update.
3401         * guile/guile-internal.h: Update.
3402         * guile/scm-block.c: Update.
3403         * guile/scm-breakpoint.c: Update.
3404         * guile/scm-cmd.c: Update.
3405         * guile/scm-disasm.c: Update.
3406         * guile/scm-frame.c: Update.
3407         * guile/scm-lazy-string.c: Update.
3408         * guile/scm-math.c: Update.
3409         * guile/scm-param.c: Update.
3410         * guile/scm-ports.c: Update.
3411         * guile/scm-pretty-print.c: Update.
3412         * guile/scm-symbol.c: Update.
3413         * guile/scm-symtab.c: Update.
3414         * guile/scm-type.c: Update.
3415         * guile/scm-value.c: Update.
3416         * i386-linux-tdep.c: Update.
3417         * i386-tdep.c: Update.
3418         * inf-loop.c: Update.
3419         * infcall.c: Update.
3420         * infcmd.c: Update.
3421         * infrun.c: Update.
3422         * jit.c: Update.
3423         * language.c: Update.
3424         * linespec.c: Update.
3425         * linux-fork.c: Update.
3426         * linux-nat.c: Update.
3427         * linux-tdep.c: Update.
3428         * linux-thread-db.c: Update.
3429         * main.c: Update.
3430         * mi/mi-cmd-break.c: Update.
3431         * mi/mi-cmd-stack.c: Update.
3432         * mi/mi-interp.c: Update.
3433         * mi/mi-main.c: Update.
3434         * objc-lang.c: Update.
3435         * p-valprint.c: Update.
3436         * parse.c: Update.
3437         * ppc-linux-tdep.c: Update.
3438         * printcmd.c: Update.
3439         * python/py-arch.c: Update.
3440         * python/py-breakpoint.c: Update.
3441         * python/py-cmd.c: Update.
3442         * python/py-finishbreakpoint.c: Update.
3443         * python/py-frame.c: Update.
3444         * python/py-framefilter.c: Update.
3445         * python/py-gdb-readline.c: Update.
3446         * python/py-inferior.c: Update.
3447         * python/py-infthread.c: Update.
3448         * python/py-lazy-string.c: Update.
3449         * python/py-linetable.c: Update.
3450         * python/py-objfile.c: Update.
3451         * python/py-param.c: Update.
3452         * python/py-prettyprint.c: Update.
3453         * python/py-progspace.c: Update.
3454         * python/py-record-btrace.c: Update.
3455         * python/py-record.c: Update.
3456         * python/py-symbol.c: Update.
3457         * python/py-type.c: Update.
3458         * python/py-unwind.c: Update.
3459         * python/py-utils.c: Update.
3460         * python/py-value.c: Update.
3461         * python/python.c: Update.
3462         * record-btrace.c: Update.
3463         * record-full.c: Update.
3464         * remote-fileio.c: Update.
3465         * remote.c: Update.
3466         * riscv-tdep.c: Update.
3467         * rs6000-aix-tdep.c: Update.
3468         * rs6000-tdep.c: Update.
3469         * rust-exp.y: Update.
3470         * rust-lang.c: Update.
3471         * s390-tdep.c: Update.
3472         * selftest-arch.c: Update.
3473         * solib-dsbt.c: Update.
3474         * solib-frv.c: Update.
3475         * solib-spu.c: Update.
3476         * solib-svr4.c: Update.
3477         * solib.c: Update.
3478         * sparc64-linux-tdep.c: Update.
3479         * stack.c: Update.
3480         * symfile-mem.c: Update.
3481         * symmisc.c: Update.
3482         * target.c: Update.
3483         * thread.c: Update.
3484         * top.c: Update.
3485         * tracefile-tfile.c: Update.
3486         * tui/tui.c: Update.
3487         * typeprint.c: Update.
3488         * unittests/cli-utils-selftests.c: Update.
3489         * unittests/parse-connection-spec-selftests.c: Update.
3490         * valops.c: Update.
3491         * valprint.c: Update.
3492         * value.c: Update.
3493         * varobj.c: Update.
3494         * windows-nat.c: Update.
3495         * x86-linux-nat.c: Update.
3496         * xml-support.c: Update.
3497
3498 2019-04-08  Tom Tromey  <tom@tromey.com>
3499
3500         * xml-support.c: Use C++ exception handling.
3501         * x86-linux-nat.c: Use C++ exception handling.
3502         * windows-nat.c: Use C++ exception handling.
3503         * varobj.c: Use C++ exception handling.
3504         * value.c: Use C++ exception handling.
3505         * valprint.c: Use C++ exception handling.
3506         * valops.c: Use C++ exception handling.
3507         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3508         handling.
3509         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3510         * typeprint.c: Use C++ exception handling.
3511         * tui/tui.c: Use C++ exception handling.
3512         * tracefile-tfile.c: Use C++ exception handling.
3513         * top.c: Use C++ exception handling.
3514         * thread.c: Use C++ exception handling.
3515         * target.c: Use C++ exception handling.
3516         * symmisc.c: Use C++ exception handling.
3517         * symfile-mem.c: Use C++ exception handling.
3518         * stack.c: Use C++ exception handling.
3519         * sparc64-linux-tdep.c: Use C++ exception handling.
3520         * solib.c: Use C++ exception handling.
3521         * solib-svr4.c: Use C++ exception handling.
3522         * solib-spu.c: Use C++ exception handling.
3523         * solib-frv.c: Use C++ exception handling.
3524         * solib-dsbt.c: Use C++ exception handling.
3525         * selftest-arch.c: Use C++ exception handling.
3526         * s390-tdep.c: Use C++ exception handling.
3527         * rust-lang.c: Use C++ exception handling.
3528         * rust-exp.y: Use C++ exception handling.
3529         * rs6000-tdep.c: Use C++ exception handling.
3530         * rs6000-aix-tdep.c: Use C++ exception handling.
3531         * riscv-tdep.c: Use C++ exception handling.
3532         * remote.c: Use C++ exception handling.
3533         * remote-fileio.c: Use C++ exception handling.
3534         * record-full.c: Use C++ exception handling.
3535         * record-btrace.c: Use C++ exception handling.
3536         * python/python.c: Use C++ exception handling.
3537         * python/py-value.c: Use C++ exception handling.
3538         * python/py-utils.c: Use C++ exception handling.
3539         * python/py-unwind.c: Use C++ exception handling.
3540         * python/py-type.c: Use C++ exception handling.
3541         * python/py-symbol.c: Use C++ exception handling.
3542         * python/py-record.c: Use C++ exception handling.
3543         * python/py-record-btrace.c: Use C++ exception handling.
3544         * python/py-progspace.c: Use C++ exception handling.
3545         * python/py-prettyprint.c: Use C++ exception handling.
3546         * python/py-param.c: Use C++ exception handling.
3547         * python/py-objfile.c: Use C++ exception handling.
3548         * python/py-linetable.c: Use C++ exception handling.
3549         * python/py-lazy-string.c: Use C++ exception handling.
3550         * python/py-infthread.c: Use C++ exception handling.
3551         * python/py-inferior.c: Use C++ exception handling.
3552         * python/py-gdb-readline.c: Use C++ exception handling.
3553         * python/py-framefilter.c: Use C++ exception handling.
3554         * python/py-frame.c: Use C++ exception handling.
3555         * python/py-finishbreakpoint.c: Use C++ exception handling.
3556         * python/py-cmd.c: Use C++ exception handling.
3557         * python/py-breakpoint.c: Use C++ exception handling.
3558         * python/py-arch.c: Use C++ exception handling.
3559         * printcmd.c: Use C++ exception handling.
3560         * ppc-linux-tdep.c: Use C++ exception handling.
3561         * parse.c: Use C++ exception handling.
3562         * p-valprint.c: Use C++ exception handling.
3563         * objc-lang.c: Use C++ exception handling.
3564         * mi/mi-main.c: Use C++ exception handling.
3565         * mi/mi-interp.c: Use C++ exception handling.
3566         * mi/mi-cmd-stack.c: Use C++ exception handling.
3567         * mi/mi-cmd-break.c: Use C++ exception handling.
3568         * main.c: Use C++ exception handling.
3569         * linux-thread-db.c: Use C++ exception handling.
3570         * linux-tdep.c: Use C++ exception handling.
3571         * linux-nat.c: Use C++ exception handling.
3572         * linux-fork.c: Use C++ exception handling.
3573         * linespec.c: Use C++ exception handling.
3574         * language.c: Use C++ exception handling.
3575         * jit.c: Use C++ exception handling.
3576         * infrun.c: Use C++ exception handling.
3577         * infcmd.c: Use C++ exception handling.
3578         * infcall.c: Use C++ exception handling.
3579         * inf-loop.c: Use C++ exception handling.
3580         * i386-tdep.c: Use C++ exception handling.
3581         * i386-linux-tdep.c: Use C++ exception handling.
3582         * guile/scm-value.c: Use C++ exception handling.
3583         * guile/scm-type.c: Use C++ exception handling.
3584         * guile/scm-symtab.c: Use C++ exception handling.
3585         * guile/scm-symbol.c: Use C++ exception handling.
3586         * guile/scm-pretty-print.c: Use C++ exception handling.
3587         * guile/scm-ports.c: Use C++ exception handling.
3588         * guile/scm-param.c: Use C++ exception handling.
3589         * guile/scm-math.c: Use C++ exception handling.
3590         * guile/scm-lazy-string.c: Use C++ exception handling.
3591         * guile/scm-frame.c: Use C++ exception handling.
3592         * guile/scm-disasm.c: Use C++ exception handling.
3593         * guile/scm-cmd.c: Use C++ exception handling.
3594         * guile/scm-breakpoint.c: Use C++ exception handling.
3595         * guile/scm-block.c: Use C++ exception handling.
3596         * guile/guile-internal.h: Use C++ exception handling.
3597         * gnu-v3-abi.c: Use C++ exception handling.
3598         * gdbtypes.c: Use C++ exception handling.
3599         * frame.c: Use C++ exception handling.
3600         * frame-unwind.c: Use C++ exception handling.
3601         * fbsd-tdep.c: Use C++ exception handling.
3602         * f-valprint.c: Use C++ exception handling.
3603         * exec.c: Use C++ exception handling.
3604         * event-top.c: Use C++ exception handling.
3605         * event-loop.c: Use C++ exception handling.
3606         * eval.c: Use C++ exception handling.
3607         * dwarf2read.c: Use C++ exception handling.
3608         * dwarf2loc.c: Use C++ exception handling.
3609         * dwarf2-frame.c: Use C++ exception handling.
3610         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3611         * dwarf-index-write.c: Use C++ exception handling.
3612         * dwarf-index-cache.c: Use C++ exception handling.
3613         * dtrace-probe.c: Use C++ exception handling.
3614         * disasm-selftests.c: Use C++ exception handling.
3615         * darwin-nat.c: Use C++ exception handling.
3616         * cp-valprint.c: Use C++ exception handling.
3617         * cp-support.c: Use C++ exception handling.
3618         * cp-abi.c: Use C++ exception handling.
3619         * corelow.c: Use C++ exception handling.
3620         * completer.c: Use C++ exception handling.
3621         * compile/compile-object-run.c: Use C++ exception handling.
3622         * compile/compile-object-load.c: Use C++ exception handling.
3623         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3624         * compile/compile-c-symbols.c: Use C++ exception handling.
3625         * common/selftest.c: Use C++ exception handling.
3626         * common/new-op.c: Use C++ exception handling.
3627         * cli/cli-script.c: Use C++ exception handling.
3628         * cli/cli-interp.c: Use C++ exception handling.
3629         * cli/cli-cmds.c: Use C++ exception handling.
3630         * c-varobj.c: Use C++ exception handling.
3631         * btrace.c: Use C++ exception handling.
3632         * breakpoint.c: Use C++ exception handling.
3633         * break-catch-throw.c: Use C++ exception handling.
3634         * arch-utils.c: Use C++ exception handling.
3635         * amd64-tdep.c: Use C++ exception handling.
3636         * ada-valprint.c: Use C++ exception handling.
3637         * ada-typeprint.c: Use C++ exception handling.
3638         * ada-lang.c: Use C++ exception handling.
3639         * aarch64-tdep.c: Use C++ exception handling.
3640
3641 2019-04-08  Tom Tromey  <tom@tromey.com>
3642
3643         * xml-support.c (gdb_xml_parser::parse): Update.
3644         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3645         * value.c (show_convenience): Update.
3646         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3647         (test_parse_flags_qcs): Update.
3648         * thread.c (thr_try_catch_cmd): Update.
3649         * target.c (target_translate_tls_address): Update.
3650         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3651         (info_frame_command_core, frame_apply_command_count): Update.
3652         * rust-exp.y (rust_lex_exception_test): Update.
3653         * riscv-tdep.c (riscv_print_one_register_info): Update.
3654         * remote.c (remote_target::enable_btrace): Update.
3655         * record-btrace.c (record_btrace_enable_warn): Update.
3656         * python/py-utils.c (gdbpy_convert_exception): Update.
3657         * printcmd.c (do_one_display, print_variable_and_value): Update.
3658         * mi/mi-main.c (mi_print_exception): Update.
3659         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3660         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3661         * linux-nat.c (linux_nat_target::attach): Update.
3662         * linux-fork.c (class scoped_switch_fork_info): Update.
3663         * infrun.c (displaced_step_prepare): Update.
3664         * infcall.c (call_function_by_hand_dummy): Update.
3665         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3666         * gnu-v3-abi.c (print_one_vtable): Update.
3667         * frame.c (get_prev_frame_always): Update.
3668         * f-valprint.c (info_common_command_for_block): Update.
3669         * exec.c (try_open_exec_file): Update.
3670         * exceptions.c (print_exception, exception_print)
3671         (exception_fprintf, exception_print_same): Update.
3672         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3673         * dwarf-index-cache.c (index_cache::store)
3674         (index_cache::lookup_gdb_index): Update.
3675         * darwin-nat.c (maybe_cache_shell): Update.
3676         * cp-valprint.c (cp_print_value_fields): Update.
3677         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3678         (gcc_cplus_symbol_address): Update.
3679         * compile/compile-c-symbols.c (gcc_convert_symbol)
3680         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3681         * common/selftest.c: Update.
3682         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3683         a std::string.
3684         (exception_try_scope_entry, exception_try_scope_exit): Don't
3685         declare.
3686         (struct exception_try_scope): Remove.
3687         (TRY): Don't use exception_try_scope.
3688         (struct gdb_exception): Add constructor, operator=.
3689         <what>: New method.
3690         (struct gdb_exception_RETURN_MASK_ALL)
3691         (struct gdb_exception_RETURN_MASK_ERROR)
3692         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3693         (struct gdb_quit_bad_alloc): Update.
3694         * common/common-exceptions.c (exception_none): Change
3695         initializer.
3696         (struct catcher) <state, exception>: Initialize inline.
3697         <prev>: Remove member.
3698         (current_catcher): Remove.
3699         (catchers): New global.
3700         (exceptions_state_mc_init): Simplify.
3701         (catcher_pop): Remove.
3702         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3703         (try_scope_depth, exception_try_scope_entry)
3704         (exception_try_scope_exit): Remove.
3705         (throw_exception_sjlj): Update.
3706         (exception_messages, exception_messages_size): Remove.
3707         (throw_it): Simplify.
3708         (gdb_exception_sliced_copy): Remove.
3709         (throw_exception_cxx): Update.
3710         * cli/cli-script.c (script_from_file): Update.
3711         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3712         Update.
3713         * ada-valprint.c (ada_val_print): Update.
3714         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3715         (create_excep_cond_exprs): Update.
3716
3717 2019-04-08  Tom Tromey  <tom@tromey.com>
3718
3719         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3720         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3721         (TRY, CATCH, END_CATCH): Remove some definitions.
3722         * common/common-exceptions.c: Don't use GDB_XCPT.
3723         (catcher_list_size): Remove.
3724         (throw_exception, throw_it): Simplify.
3725
3726 2019-04-05  Tom Tromey  <tom@tromey.com>
3727
3728         Revert the header-sorting patch.
3729         * ft32-tdep.c: Revert.
3730         * frv-tdep.c: Revert.
3731         * frv-linux-tdep.c: Revert.
3732         * frame.c: Revert.
3733         * frame-unwind.c: Revert.
3734         * frame-base.c: Revert.
3735         * fork-child.c: Revert.
3736         * findvar.c: Revert.
3737         * findcmd.c: Revert.
3738         * filesystem.c: Revert.
3739         * filename-seen-cache.h: Revert.
3740         * filename-seen-cache.c: Revert.
3741         * fbsd-tdep.c: Revert.
3742         * fbsd-nat.h: Revert.
3743         * fbsd-nat.c: Revert.
3744         * f-valprint.c: Revert.
3745         * f-typeprint.c: Revert.
3746         * f-lang.c: Revert.
3747         * extension.h: Revert.
3748         * extension.c: Revert.
3749         * extension-priv.h: Revert.
3750         * expprint.c: Revert.
3751         * exec.h: Revert.
3752         * exec.c: Revert.
3753         * exceptions.c: Revert.
3754         * event-top.c: Revert.
3755         * event-loop.c: Revert.
3756         * eval.c: Revert.
3757         * elfread.c: Revert.
3758         * dwarf2read.h: Revert.
3759         * dwarf2read.c: Revert.
3760         * dwarf2loc.c: Revert.
3761         * dwarf2expr.h: Revert.
3762         * dwarf2expr.c: Revert.
3763         * dwarf2-frame.c: Revert.
3764         * dwarf2-frame-tailcall.c: Revert.
3765         * dwarf-index-write.h: Revert.
3766         * dwarf-index-write.c: Revert.
3767         * dwarf-index-common.c: Revert.
3768         * dwarf-index-cache.h: Revert.
3769         * dwarf-index-cache.c: Revert.
3770         * dummy-frame.c: Revert.
3771         * dtrace-probe.c: Revert.
3772         * disasm.h: Revert.
3773         * disasm.c: Revert.
3774         * disasm-selftests.c: Revert.
3775         * dictionary.c: Revert.
3776         * dicos-tdep.c: Revert.
3777         * demangle.c: Revert.
3778         * dcache.h: Revert.
3779         * dcache.c: Revert.
3780         * darwin-nat.h: Revert.
3781         * darwin-nat.c: Revert.
3782         * darwin-nat-info.c: Revert.
3783         * d-valprint.c: Revert.
3784         * d-namespace.c: Revert.
3785         * d-lang.c: Revert.
3786         * ctf.c: Revert.
3787         * csky-tdep.c: Revert.
3788         * csky-linux-tdep.c: Revert.
3789         * cris-tdep.c: Revert.
3790         * cris-linux-tdep.c: Revert.
3791         * cp-valprint.c: Revert.
3792         * cp-support.c: Revert.
3793         * cp-namespace.c: Revert.
3794         * cp-abi.c: Revert.
3795         * corelow.c: Revert.
3796         * corefile.c: Revert.
3797         * continuations.c: Revert.
3798         * completer.h: Revert.
3799         * completer.c: Revert.
3800         * complaints.c: Revert.
3801         * coffread.c: Revert.
3802         * coff-pe-read.c: Revert.
3803         * cli-out.h: Revert.
3804         * cli-out.c: Revert.
3805         * charset.c: Revert.
3806         * c-varobj.c: Revert.
3807         * c-valprint.c: Revert.
3808         * c-typeprint.c: Revert.
3809         * c-lang.c: Revert.
3810         * buildsym.c: Revert.
3811         * buildsym-legacy.c: Revert.
3812         * build-id.h: Revert.
3813         * build-id.c: Revert.
3814         * btrace.c: Revert.
3815         * bsd-uthread.c: Revert.
3816         * breakpoint.h: Revert.
3817         * breakpoint.c: Revert.
3818         * break-catch-throw.c: Revert.
3819         * break-catch-syscall.c: Revert.
3820         * break-catch-sig.c: Revert.
3821         * blockframe.c: Revert.
3822         * block.c: Revert.
3823         * bfin-tdep.c: Revert.
3824         * bfin-linux-tdep.c: Revert.
3825         * bfd-target.c: Revert.
3826         * bcache.c: Revert.
3827         * ax-general.c: Revert.
3828         * ax-gdb.h: Revert.
3829         * ax-gdb.c: Revert.
3830         * avr-tdep.c: Revert.
3831         * auxv.c: Revert.
3832         * auto-load.c: Revert.
3833         * arm-wince-tdep.c: Revert.
3834         * arm-tdep.c: Revert.
3835         * arm-symbian-tdep.c: Revert.
3836         * arm-pikeos-tdep.c: Revert.
3837         * arm-obsd-tdep.c: Revert.
3838         * arm-nbsd-tdep.c: Revert.
3839         * arm-nbsd-nat.c: Revert.
3840         * arm-linux-tdep.c: Revert.
3841         * arm-linux-nat.c: Revert.
3842         * arm-fbsd-tdep.c: Revert.
3843         * arm-fbsd-nat.c: Revert.
3844         * arm-bsd-tdep.c: Revert.
3845         * arch-utils.c: Revert.
3846         * arc-tdep.c: Revert.
3847         * arc-newlib-tdep.c: Revert.
3848         * annotate.h: Revert.
3849         * annotate.c: Revert.
3850         * amd64-windows-tdep.c: Revert.
3851         * amd64-windows-nat.c: Revert.
3852         * amd64-tdep.c: Revert.
3853         * amd64-sol2-tdep.c: Revert.
3854         * amd64-obsd-tdep.c: Revert.
3855         * amd64-obsd-nat.c: Revert.
3856         * amd64-nbsd-tdep.c: Revert.
3857         * amd64-nbsd-nat.c: Revert.
3858         * amd64-nat.c: Revert.
3859         * amd64-linux-tdep.c: Revert.
3860         * amd64-linux-nat.c: Revert.
3861         * amd64-fbsd-tdep.c: Revert.
3862         * amd64-fbsd-nat.c: Revert.
3863         * amd64-dicos-tdep.c: Revert.
3864         * amd64-darwin-tdep.c: Revert.
3865         * amd64-bsd-nat.c: Revert.
3866         * alpha-tdep.c: Revert.
3867         * alpha-obsd-tdep.c: Revert.
3868         * alpha-nbsd-tdep.c: Revert.
3869         * alpha-mdebug-tdep.c: Revert.
3870         * alpha-linux-tdep.c: Revert.
3871         * alpha-linux-nat.c: Revert.
3872         * alpha-bsd-tdep.c: Revert.
3873         * alpha-bsd-nat.c: Revert.
3874         * aix-thread.c: Revert.
3875         * agent.c: Revert.
3876         * addrmap.c: Revert.
3877         * ada-varobj.c: Revert.
3878         * ada-valprint.c: Revert.
3879         * ada-typeprint.c: Revert.
3880         * ada-tasks.c: Revert.
3881         * ada-lang.c: Revert.
3882         * aarch64-tdep.c: Revert.
3883         * aarch64-ravenscar-thread.c: Revert.
3884         * aarch64-newlib-tdep.c: Revert.
3885         * aarch64-linux-tdep.c: Revert.
3886         * aarch64-linux-nat.c: Revert.
3887         * aarch64-fbsd-tdep.c: Revert.
3888         * aarch64-fbsd-nat.c: Revert.
3889         * aarch32-linux-nat.c: Revert.
3890
3891 2019-04-05  Tom Tromey  <tom@tromey.com>
3892
3893         * ft32-tdep.c: Sort headers.
3894         * frv-tdep.c: Sort headers.
3895         * frv-linux-tdep.c: Sort headers.
3896         * frame.c: Sort headers.
3897         * frame-unwind.c: Sort headers.
3898         * frame-base.c: Sort headers.
3899         * fork-child.c: Sort headers.
3900         * findvar.c: Sort headers.
3901         * findcmd.c: Sort headers.
3902         * filesystem.c: Sort headers.
3903         * filename-seen-cache.h: Sort headers.
3904         * filename-seen-cache.c: Sort headers.
3905         * fbsd-tdep.c: Sort headers.
3906         * fbsd-nat.h: Sort headers.
3907         * fbsd-nat.c: Sort headers.
3908         * f-valprint.c: Sort headers.
3909         * f-typeprint.c: Sort headers.
3910         * f-lang.c: Sort headers.
3911         * extension.h: Sort headers.
3912         * extension.c: Sort headers.
3913         * extension-priv.h: Sort headers.
3914         * expprint.c: Sort headers.
3915         * exec.h: Sort headers.
3916         * exec.c: Sort headers.
3917         * exceptions.c: Sort headers.
3918         * event-top.c: Sort headers.
3919         * event-loop.c: Sort headers.
3920         * eval.c: Sort headers.
3921         * elfread.c: Sort headers.
3922         * dwarf2read.h: Sort headers.
3923         * dwarf2read.c: Sort headers.
3924         * dwarf2loc.c: Sort headers.
3925         * dwarf2expr.h: Sort headers.
3926         * dwarf2expr.c: Sort headers.
3927         * dwarf2-frame.c: Sort headers.
3928         * dwarf2-frame-tailcall.c: Sort headers.
3929         * dwarf-index-write.h: Sort headers.
3930         * dwarf-index-write.c: Sort headers.
3931         * dwarf-index-common.c: Sort headers.
3932         * dwarf-index-cache.h: Sort headers.
3933         * dwarf-index-cache.c: Sort headers.
3934         * dummy-frame.c: Sort headers.
3935         * dtrace-probe.c: Sort headers.
3936         * disasm.h: Sort headers.
3937         * disasm.c: Sort headers.
3938         * disasm-selftests.c: Sort headers.
3939         * dictionary.c: Sort headers.
3940         * dicos-tdep.c: Sort headers.
3941         * demangle.c: Sort headers.
3942         * dcache.h: Sort headers.
3943         * dcache.c: Sort headers.
3944         * darwin-nat.h: Sort headers.
3945         * darwin-nat.c: Sort headers.
3946         * darwin-nat-info.c: Sort headers.
3947         * d-valprint.c: Sort headers.
3948         * d-namespace.c: Sort headers.
3949         * d-lang.c: Sort headers.
3950         * ctf.c: Sort headers.
3951         * csky-tdep.c: Sort headers.
3952         * csky-linux-tdep.c: Sort headers.
3953         * cris-tdep.c: Sort headers.
3954         * cris-linux-tdep.c: Sort headers.
3955         * cp-valprint.c: Sort headers.
3956         * cp-support.c: Sort headers.
3957         * cp-namespace.c: Sort headers.
3958         * cp-abi.c: Sort headers.
3959         * corelow.c: Sort headers.
3960         * corefile.c: Sort headers.
3961         * continuations.c: Sort headers.
3962         * completer.h: Sort headers.
3963         * completer.c: Sort headers.
3964         * complaints.c: Sort headers.
3965         * coffread.c: Sort headers.
3966         * coff-pe-read.c: Sort headers.
3967         * cli-out.h: Sort headers.
3968         * cli-out.c: Sort headers.
3969         * charset.c: Sort headers.
3970         * c-varobj.c: Sort headers.
3971         * c-valprint.c: Sort headers.
3972         * c-typeprint.c: Sort headers.
3973         * c-lang.c: Sort headers.
3974         * buildsym.c: Sort headers.
3975         * buildsym-legacy.c: Sort headers.
3976         * build-id.h: Sort headers.
3977         * build-id.c: Sort headers.
3978         * btrace.c: Sort headers.
3979         * bsd-uthread.c: Sort headers.
3980         * breakpoint.h: Sort headers.
3981         * breakpoint.c: Sort headers.
3982         * break-catch-throw.c: Sort headers.
3983         * break-catch-syscall.c: Sort headers.
3984         * break-catch-sig.c: Sort headers.
3985         * blockframe.c: Sort headers.
3986         * block.c: Sort headers.
3987         * bfin-tdep.c: Sort headers.
3988         * bfin-linux-tdep.c: Sort headers.
3989         * bfd-target.c: Sort headers.
3990         * bcache.c: Sort headers.
3991         * ax-general.c: Sort headers.
3992         * ax-gdb.h: Sort headers.
3993         * ax-gdb.c: Sort headers.
3994         * avr-tdep.c: Sort headers.
3995         * auxv.c: Sort headers.
3996         * auto-load.c: Sort headers.
3997         * arm-wince-tdep.c: Sort headers.
3998         * arm-tdep.c: Sort headers.
3999         * arm-symbian-tdep.c: Sort headers.
4000         * arm-pikeos-tdep.c: Sort headers.
4001         * arm-obsd-tdep.c: Sort headers.
4002         * arm-nbsd-tdep.c: Sort headers.
4003         * arm-nbsd-nat.c: Sort headers.
4004         * arm-linux-tdep.c: Sort headers.
4005         * arm-linux-nat.c: Sort headers.
4006         * arm-fbsd-tdep.c: Sort headers.
4007         * arm-fbsd-nat.c: Sort headers.
4008         * arm-bsd-tdep.c: Sort headers.
4009         * arch-utils.c: Sort headers.
4010         * arc-tdep.c: Sort headers.
4011         * arc-newlib-tdep.c: Sort headers.
4012         * annotate.h: Sort headers.
4013         * annotate.c: Sort headers.
4014         * amd64-windows-tdep.c: Sort headers.
4015         * amd64-windows-nat.c: Sort headers.
4016         * amd64-tdep.c: Sort headers.
4017         * amd64-sol2-tdep.c: Sort headers.
4018         * amd64-obsd-tdep.c: Sort headers.
4019         * amd64-obsd-nat.c: Sort headers.
4020         * amd64-nbsd-tdep.c: Sort headers.
4021         * amd64-nbsd-nat.c: Sort headers.
4022         * amd64-nat.c: Sort headers.
4023         * amd64-linux-tdep.c: Sort headers.
4024         * amd64-linux-nat.c: Sort headers.
4025         * amd64-fbsd-tdep.c: Sort headers.
4026         * amd64-fbsd-nat.c: Sort headers.
4027         * amd64-dicos-tdep.c: Sort headers.
4028         * amd64-darwin-tdep.c: Sort headers.
4029         * amd64-bsd-nat.c: Sort headers.
4030         * alpha-tdep.c: Sort headers.
4031         * alpha-obsd-tdep.c: Sort headers.
4032         * alpha-nbsd-tdep.c: Sort headers.
4033         * alpha-mdebug-tdep.c: Sort headers.
4034         * alpha-linux-tdep.c: Sort headers.
4035         * alpha-linux-nat.c: Sort headers.
4036         * alpha-bsd-tdep.c: Sort headers.
4037         * alpha-bsd-nat.c: Sort headers.
4038         * aix-thread.c: Sort headers.
4039         * agent.c: Sort headers.
4040         * addrmap.c: Sort headers.
4041         * ada-varobj.c: Sort headers.
4042         * ada-valprint.c: Sort headers.
4043         * ada-typeprint.c: Sort headers.
4044         * ada-tasks.c: Sort headers.
4045         * ada-lang.c: Sort headers.
4046         * aarch64-tdep.c: Sort headers.
4047         * aarch64-ravenscar-thread.c: Sort headers.
4048         * aarch64-newlib-tdep.c: Sort headers.
4049         * aarch64-linux-tdep.c: Sort headers.
4050         * aarch64-linux-nat.c: Sort headers.
4051         * aarch64-fbsd-tdep.c: Sort headers.
4052         * aarch64-fbsd-nat.c: Sort headers.
4053         * aarch32-linux-nat.c: Sort headers.
4054
4055 2019-04-04  Tom Tromey  <tom@tromey.com>
4056
4057         * varobj.c (varobj_create): Update.
4058         * rust-exp.y (struct rust_parser) <update_innermost_block,
4059         lookup_symbol>: New methods.
4060         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4061         Rename.
4062         (rust_parser::rust_lookup_type)
4063         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4064         * printcmd.c (display_command, do_one_display): Update.
4065         * parser-defs.h (struct parser_state) <parser_state>: Add
4066         "tracker" parameter.
4067         (block_tracker): New member.
4068         (class innermost_block_tracker) <innermost_block_tracker>: Add
4069         "types" parameter.
4070         <reset>: Remove method.
4071         (innermost_block): Don't declare.
4072         (null_post_parser): Update.
4073         * parse.c (innermost_block): Remove global.
4074         (write_dollar_variable): Update.
4075         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4076         Remove "tracker_types" parameter.
4077         (parse_expression): Add "tracker" parameter.
4078         (parse_expression_for_completion): Update.
4079         (null_post_parser): Add "tracker" parameter.
4080         * p-exp.y: Update rules.
4081         * m2-exp.y: Update rules.
4082         * language.h (struct language_defn) <la_post_parser>: Add
4083         "tracker" parameter.
4084         * go-exp.y: Update rules.
4085         * f-exp.y: Update rules.
4086         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4087         parameter.
4088         * d-exp.y: Update rules.
4089         * c-exp.y: Update rules.
4090         * breakpoint.c (set_breakpoint_condition): Create an
4091         innermost_block_tracker.
4092         (watch_command_1): Likewise.
4093         * ada-lang.c (resolve): Add "tracker" parameter.
4094         (resolve_subexp): Likewise.
4095         * ada-exp.y (write_var_from_sym): Update.
4096
4097 2019-04-04  Tom Tromey  <tom@tromey.com>
4098
4099         * type-stack.h: New file.
4100         * type-stack.c: New file.
4101         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4102         type-stack.h.
4103         (insert_into_type_stack, insert_type, push_type, push_type_int)
4104         (insert_type_address_space, pop_type, pop_type_int)
4105         (pop_typelist, pop_type_stack, append_type_stack)
4106         (push_type_stack, get_type_stack, push_typelist)
4107         (follow_type_instance_flags, follow_types): Don't declare.
4108         * parse.c (type_stack): Remove global.
4109         (parse_exp_in_context): Update.
4110         (insert_into_type_stack, insert_type, push_type, push_type_int)
4111         (insert_type_address_space, pop_type, pop_type_int)
4112         (pop_typelist, pop_type_stack, append_type_stack)
4113         (push_type_stack, get_type_stack, push_typelist)
4114         (follow_type_instance_flags, follow_types): Remove (moved to
4115         type-stack.c).
4116         * f-exp.y (type_stack): New global.
4117         Update rules.
4118         (push_kind_type, f_parse): Update.
4119         * d-exp.y (type_stack): New global.
4120         Update rules.
4121         (d_parse): Update.
4122         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4123         Update rules.
4124         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4125         (HFILES_NO_SRCDIR): Add type-stack.h.
4126
4127 2019-04-04  Tom Tromey  <tom@tromey.com>
4128
4129         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4130         (rust_parser::convert_ast_to_expression, rust_parse)
4131         (rust_lex_test_completion, rust_lex_tests): Update.
4132         * parser-defs.h (struct expr_completion_state): New.
4133         (struct parser_state) <parser_state>: Add completion parameter.
4134         <mark_struct_expression, mark_completion_tag>: New methods.
4135         <parse_completion, m_completion_state>: New members.
4136         (prefixify_expression, null_post_parser): Update.
4137         (mark_struct_expression, mark_completion_tag): Don't declare.
4138         * parse.c (parse_completion, expout_last_struct)
4139         (expout_tag_completion_type, expout_completion_name): Remove
4140         globals.
4141         (parser_state::mark_struct_expression)
4142         (parser_state::mark_completion_tag): Now methods.
4143         (prefixify_expression): Add last_struct parameter.
4144         (prefixify_subexp): Likewise.
4145         (parse_exp_1): Update.
4146         (parse_exp_in_context): Add cstate parameter.  Update.
4147         (parse_expression_for_completion): Create an
4148         expr_completion_state.
4149         (null_post_parser): Add "completion" parameter.
4150         * p-exp.y: Update rules.
4151         (yylex): Update.
4152         * language.h (struct language_defn) <la_post_parser>: Add
4153         "completing" parameter.
4154         * go-exp.y: Update rules.
4155         (lex_one_token): Update.
4156         * expression.h (parse_completion): Don't declare.
4157         * d-exp.y: Update rules.
4158         (lex_one_token): Update rules.
4159         * c-exp.y: Update rules.
4160         (lex_one_token): Update.
4161         * ada-lang.c (resolve): Add "parse_completion" parameter.
4162         (resolve_subexp): Likewise.
4163         (ada_resolve_function): Likewise.
4164
4165 2019-04-04  Tom Tromey  <tom@tromey.com>
4166
4167         * parser-defs.h (struct parser_state) <start_arglist,
4168         end_arglist>: New methods.
4169         <arglist_len, m_funcall_chain>: New members.
4170         (arglist_len, start_arglist, end_arglist): Don't declare.
4171         * parse.c (arglist_len, funcall_chain): Remove global.
4172         (start_arglist, end_arglist): Remove functions.
4173         (parse_exp_in_context): Update.
4174         * p-exp.y: Update rules.
4175         * m2-exp.y: Update rules.
4176         * go-exp.y: Update rules.
4177         * f-exp.y: Update rules.
4178         * d-exp.y: Update rules.
4179         * c-exp.y: Update rules.
4180
4181 2019-04-04  Tom Tromey  <tom@tromey.com>
4182
4183         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4184         lex_operator, push_back>: New methods.
4185         Update all rules.
4186         (rust_parser::lex_hex, lex_escape): Rename and update.
4187         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4188         (rust_parser::lex_operator): Rename and update.
4189         (rust_parser::lex_number, rustyylex, rustyyerror)
4190         (rust_lex_test_init, rust_lex_test_sequence)
4191         (rust_lex_test_push_back, rust_lex_tests): Update.
4192         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4193         parameter.
4194         <lexptr, prev_lexptr>: New members.
4195         (lexptr, prev_lexptr): Don't declare.
4196         * parse.c (lexptr, prev_lexptr): Remove globals.
4197         (parse_exp_in_context): Update.
4198         * p-exp.y (yylex, yyerror): Update.
4199         * m2-exp.y (parse_number, yylex, yyerror): Update.
4200         * go-exp.y (lex_one_token, yyerror): Update.
4201         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4202         * d-exp.y (lex_one_token, yyerror): Update.
4203         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4204         (lex_one_token, yyerror): Update.
4205         * ada-lex.l (YY_INPUT): Update.
4206         (rewind_to_char): Update.
4207         * ada-exp.y (yyerror): Update.
4208
4209 2019-04-04  Tom Tromey  <tom@tromey.com>
4210
4211         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4212         * parser-defs.h (struct parser_state) <parser_state>: Add new
4213         parameter.
4214         <comma_terminates>: New member.
4215         (comma_terminates): Don't declare global.
4216         * parse.c (comma_terminates): Remove global.
4217         (parse_exp_in_context): Update.
4218         * p-exp.y (yylex): Update.
4219         * m2-exp.y (yylex): Update.
4220         * go-exp.y (lex_one_token): Update.
4221         * f-exp.y (yylex): Update.
4222         * d-exp.y (lex_one_token): Update.
4223         * c-exp.y (lex_one_token): Update.
4224         * ada-lex.l: Update.
4225
4226 2019-04-04  Tom Tromey  <tom@tromey.com>
4227
4228         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4229         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4230         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4231         * parser-defs.h (paren_depth): Don't declare.
4232         * parse.c (paren_depth): Remove global.
4233         (parse_exp_in_context): Update.
4234         * p-exp.y (paren_depth): New global.
4235         (pascal_parse): Initialize it.
4236         * m2-exp.y (paren_depth): New global.
4237         (m2_parse): Initialize it.
4238         * go-exp.y (paren_depth): New global.
4239         (go_parse): Initialize it.
4240         * f-exp.y (paren_depth): New global.
4241         (f_parse): Initialize it.
4242         * d-exp.y (paren_depth): New global.
4243         (d_parse): Initialize it.
4244         * c-exp.y (paren_depth): New global.
4245         (c_parse): Initialize it.
4246         * ada-lex.l (paren_depth): New global.
4247         (lexer_init): Initialize it.
4248
4249 2019-04-04  Tom Tromey  <tom@tromey.com>
4250
4251         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4252         (rust_parser::convert_ast_to_type)
4253         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4254         * parser-defs.h (struct parser_state) <parser_state>: Add
4255         parameters.  Initialize new members.
4256         <expression_context_block, expression_context_pc>: New members.
4257         * parse.c (expression_context_block, expression_context_pc):
4258         Remove globals.
4259         (parse_exp_in_context): Update.
4260         * p-exp.y: Update all rules.
4261         (yylex): Update.
4262         * m2-exp.y: Update all rules.
4263         (yylex): Update.
4264         * go-exp.y (yylex): Update.
4265         * f-exp.y (yylex): Update.
4266         * d-exp.y: Update all rules.
4267         (yylex): Update.
4268         * c-exp.y: Update all rules.
4269         (lex_one_token, classify_name, yylex, c_parse): Update.
4270         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4271
4272 2019-04-04  Tom Tromey  <tom@tromey.com>
4273
4274         * gdbarch.h, gdbarch.c: Rebuild.
4275         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4276         * stap-probe.h:
4277         (struct stap_parse_info): Replace "parser_state" with
4278         "expr_builder".
4279         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4280         (parser_state): New class.
4281         * parse.c (expr_builder): Rename.
4282         (expr_builder::release): Rename.
4283         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4284         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4285         (write_exp_elt_longcst, write_exp_elt_floatcst)
4286         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4287         (write_exp_string_vector, write_exp_bitstring)
4288         (write_exp_msymbol, mark_struct_expression)
4289         (write_dollar_variable)
4290         (insert_type_address_space, increase_expout_size): Replace
4291         "parser_state" with "expr_builder".
4292         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4293         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4294         "parser_state" with "expr_builder".
4295
4296 2019-04-04  Tom Tromey  <tom@tromey.com>
4297
4298         * rust-exp.y: Replace "parse_language" with method call.
4299         * p-exp.y:
4300         (yylex): Replace "parse_language" with method call.
4301         * m2-exp.y:
4302         (yylex): Replace "parse_language" with method call.
4303         * go-exp.y (classify_name): Replace "parse_language" with method
4304         call.
4305         * f-exp.y (yylex): Replace "parse_language" with method call.
4306         * d-exp.y (lex_one_token): Replace "parse_language" with method
4307         call.
4308         * c-exp.y:
4309         (lex_one_token, classify_name, yylex): Replace "parse_language"
4310         with method call.
4311         * ada-exp.y (find_primitive_type, type_char)
4312         (type_system_address): Replace "parse_language" with method call.
4313
4314 2019-04-04  Tom Tromey  <tom@tromey.com>
4315
4316         * rust-exp.y: Replace "parse_gdbarch" with method call.
4317         * parse.c (write_dollar_variable, insert_type_address_space):
4318         Replace "parse_gdbarch" with method call.
4319         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4320         call.
4321         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4322         call.
4323         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4324         "parse_gdbarch" with method call.
4325         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4326         with method call.
4327         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4328         "parse_gdbarch" with method call.
4329         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4330         "parse_gdbarch" with method call.
4331         * c-exp.y (parse_type, parse_number, classify_name): Replace
4332         "parse_gdbarch" with method call.
4333         * ada-lex.l: Replace "parse_gdbarch" with method call.
4334         * ada-exp.y (parse_type, find_primitive_type, type_char)
4335         (type_system_address): Replace "parse_gdbarch" with method call.
4336
4337 2019-04-04  Tom Tromey  <tom@tromey.com>
4338
4339         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4340         * stap-probe.c (stap_parse_argument): Update.
4341         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4342         initial_size parameter.
4343         * rust-exp.y (rust_lex_tests): Update.
4344         * parse.c (parser_state): Update.
4345         (parse_exp_in_context): Update.
4346         * parser-defs.h (struct parser_state) <parser_state>: Remove
4347         "initial_size" parameter.
4348
4349 2019-04-04  Tom Tromey  <tom@tromey.com>
4350
4351         * parser-defs.h (increase_expout_size): Don't declare.
4352         * parse.c (increase_expout_size): Now static.
4353
4354 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4355
4356         * gnu-nat.c (gnu_nat_target::wait): Fix
4357         target_waitstatus_to_string call.
4358
4359 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * eval.c (evaluate_subexp_standard): Handle internal functions
4362         during Fortran function call handling.
4363
4364 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4365
4366         * NEWS: Mention new internal functions.
4367         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4368         (read_base_type): Use dwarf2_init_complex_target_type.
4369         * value.c (creal_internal_fn): New function.
4370         (cimag_internal_fn): New function.
4371         (_initialize_values): Register new internal functions.
4372
4373 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4374
4375         * infrun.c (stop_all_threads): If debug_infrun, always
4376         trace the wait status after wait_one, using
4377         target_waitstatus_to_string and target_pid_to_str.
4378         (handle_inferior_event): Replace various trace of
4379         wait status kind by a single trace.
4380         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4381         wait status kind image by target_waitstatus_to_string.
4382         * target/waitstatus.c (target_waitstatus_to_string): Fix
4383         obsolete comment.
4384
4385 2019-04-01  Tom Tromey  <tromey@adacore.com>
4386
4387         PR symtab/23331:
4388         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4389
4390 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4391             Pedro Alves  <palves@redhat.com>
4392
4393         * top.c (quit_force): Call 'finalize_values'.
4394         * value.c (finalize_values): New function.
4395         * value.h (finalize_values): Declare.
4396
4397 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4398
4399         * NEWS: Announce $_gdb_major and $_gdb_minor.
4400
4401         * top.c (init_gdb_version_vars): New function.
4402         (gdb_init): Call init_gdb_version_vars.
4403
4404 2019-03-29  Tom Tromey  <tromey@adacore.com>
4405
4406         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4407         help text.  Remove dead code.
4408
4409 2019-03-29  Keith Seitz  <keiths@redhat.com>
4410
4411         From Siddhesh Poyarekar:
4412         * f-lang.h (f77_get_upperbound): Return LONGEST.
4413         (f77_get_lowerbound): Likewise.
4414         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4415         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4416         print them.
4417         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4418         plongest to format print it.
4419         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4420         (f77_get_upperbound): Likewise.
4421         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4422         LOWER_BOUND to LONGEST.
4423         (f77_create_arrayprint_offset_tbl): Likewise.
4424
4425 2019-03-29  Keith Seitz  <keiths@redhat.com>
4426
4427         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4428         %s/pulongest for TYPE_LENGTH instead of %d in format
4429         strings.
4430         * ada-typerint.c (ada_print_type): Likewise.
4431         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4432         * compile/compile-c-support.c (generate_register_struct): Likewise.
4433         * gdbtypes.c (recursive_dump_type): Likewise.
4434         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4435         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4436         instead of %d in format strings.
4437         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4438         to std::min to ULONGEST.
4439         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4440         instead of %d in format strings.
4441         * tracepoint.c (info_scope_command): Likewise.
4442         * typeprint.c (print_offset_data::update)
4443         (print_offset_data::finish): Likewise.
4444         * xtensa-tdep.c (xtensa_store_return_value)
4445         (xtensa_push_dummy_call): Likewise.
4446
4447 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4448
4449         * windows-nat.c (display_selector): Fixed format specifications
4450         for 64-bit Cygwin.
4451
4452 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4453
4454         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4455
4456 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4457
4458         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4459         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4460         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4461         (nios2_linux_init_abi): Install it.
4462
4463 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4464
4465         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4466
4467 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4468
4469         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4470
4471 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4472             Tom Tromey  <tromey@adacore.com>
4473
4474         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4475
4476 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4477
4478         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4479         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4480         method to compute the bounds of range types. Also print "[evaluated]"
4481         if the bounds' values come from a dynamic evaluation.
4482
4483 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4486         whitespace when pretty printing is on.
4487
4488 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4489
4490         * ppc-linux-nat.c: Add include.
4491
4492 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4493
4494         * NEWS: Mention AArch64 Pointer Authentication.
4495
4496 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4497
4498         * arm-linux-nat.c: Add include.
4499
4500 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4501
4502         * source-cache.c (source_cache::get_source_lines): Re-read
4503         fullname after calling open_source_file.
4504
4505 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4506
4507         * NEWS: Mention TLS support for FreeBSD.
4508
4509 2019-03-25  Tom Tromey  <tromey@adacore.com>
4510
4511         * minsyms.c (BUNCH_SIZE): Update comment.
4512         (~minimal_symbol_reader): Remove old comment.
4513         (compact_minimal_symbols): Update comment.
4514         (minimal_symbol_reader::install): Remove old comment.  Update
4515         other comments.
4516
4517 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4518
4519         * s390-linux-nat.c: Add include.
4520
4521 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4522
4523         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4524         Call linux_get_hwcap.
4525         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4526         Likewise.
4527         (aarch64_linux_get_hwcap): Remove function.
4528         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4529         declaration.
4530         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4531         linux_get_hwcap.
4532         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4533         * linux-tdep.c (linux_get_hwcap): Add function.
4534         (linux_get_hwcap2): Likewise.
4535         * linux-tdep.h (linux_get_hwcap): Add declaration.
4536         (linux_get_hwcap2): Likewise.
4537         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4538         (ppc_linux_get_hwcap2): Likewise.
4539         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4540         linux_get_hwcap.
4541         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4542         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4543         (ppc_linux_nat_target::read_description): Likewise.
4544         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4545         * s390-linux-nat.c: Likewise.
4546         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4547
4548 2019-03-24  Tom Tromey  <tom@tromey.com>
4549
4550         * ada-lang.c (standard_lookup): Simplify initialization.
4551         (ada_lookup_symbol_nonlocal): Simplify return.
4552         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4553         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4554         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4555         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4556         initialization.
4557         * solib.c (solib_global_lookup): Simplify.
4558         * symtab.c (null_block_symbol): Remove.
4559         (symbol_cache_lookup): Simplify returns.
4560         (lookup_language_this): Simplify returns.
4561         (lookup_symbol_aux): Simplify return.
4562         (lookup_local_symbol): Simplify returns.
4563         (lookup_global_symbol_from_objfile): Simplify return.
4564         (lookup_symbol_in_objfile_symtabs)
4565         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4566         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4567         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4568         * cp-namespace.c (cp_lookup_bare_symbol)
4569         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4570         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4571         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4572         (cp_lookup_symbol_via_imports): Simplify initialization.
4573         (find_symbol_in_baseclass): Likewise.
4574         * symtab.h (null_block_symbol): Remove.
4575         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4576         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4577         (d_lookup_symbol_module): Likewise.
4578         (find_symbol_in_baseclass): Simplify initialization.
4579
4580 2019-03-24  Tom Tromey  <tom@tromey.com>
4581
4582         * expression.h: Don't include symtab.h.
4583         (struct block): Forward declare.
4584
4585 2019-03-24  Tom Tromey  <tom@tromey.com>
4586
4587         * c-exp.y (typebase): Remove casts.
4588         * gdbtypes.c (lookup_unsigned_typename, )
4589         (lookup_signed_typename): Remove cast.
4590         * eval.c (parse_to_comma_and_eval): Remove cast.
4591         * parse.c (write_dollar_variable): Remove cast.
4592         * block.h (struct block) <superblock>: Now const.
4593         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4594         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4595         (map_block): Make "block" const.
4596         * symfile.h (struct quick_symbol_functions)
4597         <map_matching_symbols>: Constify block argument to "callback".
4598         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4599         const.
4600         (find_pc_sect_compunit_symtab): Make "b" const.
4601         (find_symbol_at_address): Likewise.
4602         (search_symbols): Likewise.
4603         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4604         (dw2_debug_names_lookup_symbol): Likewise.
4605         (dw2_map_matching_symbols): Update.
4606         * p-valprint.c (pascal_val_print): Remove "block".
4607         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4608         (aux_add_nonlocal_symbols): Make "block" const.
4609         (resolve_subexp): Remove cast.
4610         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4611         const.
4612         (iterate_over_file_blocks): Likewise.
4613         * f-exp.y (%union) <bval>: Remove.
4614         * coffread.c (patch_opaque_types): Make "b" const.
4615         * spu-tdep.c (spu_catch_start): Make "block" const.
4616         * c-valprint.c (print_unpacked_pointer): Remove "block".
4617         * symmisc.c (dump_symtab_1): Make "b" const.
4618         (block_depth): Make "block" const.
4619         * d-exp.y (%union) <bval>: Remove.
4620         * cp-support.h (cp_lookup_rtti_type): Update.
4621         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4622         * psymtab.c (psym_lookup_symbol): Make "block" const.
4623         (maintenance_check_psymtabs): Make "b" const.
4624         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4625         (enumerate_locals, enumerate_args): Update.
4626         * python/py-symtab.c (stpy_global_block): Make "block" const.
4627         (stpy_static_block): Likewise.
4628         * inline-frame.c (block_starting_point_at): Make "new_block"
4629         const.
4630         * block.c (find_block_in_blockvector): Make return type const.
4631         (blockvector_for_pc_sect): Make "b" const.
4632         (find_block_in_blockvector): Make "b" const.
4633
4634 2019-03-23  Tom Tromey  <tom@tromey.com>
4635
4636         * varobj.c (varobj_create): Update.
4637         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4638         * printcmd.c (display_command, do_one_display): Don't reset
4639         innermost_block.
4640         * parser-defs.h (enum innermost_block_tracker_type): Move to
4641         expression.h.
4642         (innermost_block): Update comment.
4643         * parse.c (parse_exp_1): Add tracker_types parameter.
4644         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4645         tracker_types parameter.  Reset innermost_block.
4646         (parse_exp_in_context): Remove.
4647         (parse_expression_for_completion): Update.
4648         * objfiles.c (~objfile): Don't reset expression_context_block or
4649         innermost_block.
4650         * expression.h (enum innermost_block_tracker_type): Move from
4651         parser-defs.h.
4652         (parse_exp_1): Add tracker_types parameter.
4653         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4654         reset innermost_block.
4655
4656 2019-03-23  Tom Tromey  <tom@tromey.com>
4657
4658         * objfiles.h: Include bcache.h.
4659
4660 2019-03-23  Tom Tromey  <tom@tromey.com>
4661
4662         * linespec.c (get_current_search_block): Use
4663         scoped_restore_current_language.
4664         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4665
4666 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4667             Jiong Wang  <jiong.wang@arm.com>
4668
4669         * aarch64-linux-tdep.c
4670         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4671         section.
4672         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4673
4674 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4675             Jiong Wang  <jiong.wang@arm.com>
4676
4677         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4678         instructions.
4679         (aarch64_analyze_prologue_test): Add PACIASP test.
4680         (aarch64_prologue_prev_register): Unmask PC value.
4681
4682 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4683             Jiong Wang  <jiong.wang@arm.com>
4684
4685         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4686         (aarch64_dwarf2_prev_register): Unmask PC value.
4687         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4688         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4689         DW_CFA_AARCH64_negate_ra_state.
4690         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4691
4692 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4693             Jiong Wang  <jiong.wang@arm.com>
4694
4695         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4696         registers.
4697         (aarch64_pseudo_register_name): Likewise.
4698         (aarch64_pseudo_register_type): Likewise.
4699         (aarch64_pseudo_register_reggroup_p): Likewise.
4700         (aarch64_gdbarch_init): Add pauth registers.
4701         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4702         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4703         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4704         (struct gdbarch_tdep): Add regnum for ra_state.
4705
4706 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4707             Jiong Wang  <jiong.wang@arm.com>
4708
4709         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4710
4711 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4712             Jiong Wang  <jiong.wang@arm.com>
4713
4714         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4715         function.
4716         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4717         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4718         (aarch64_gdbarch_init): Add puth registers.
4719         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4720         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4721         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4722
4723 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4724             Jiong Wang  <jiong.wang@arm.com>
4725
4726         * aarch64-linux-nat.c
4727         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4728         * aarch64-linux-tdep.c
4729         (aarch64_linux_core_read_description): Likewise.
4730         (aarch64_linux_get_hwcap): New function.
4731         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4732         (aarch64_linux_get_hwcap): New declaration.
4733
4734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4735             Jiong Wang  <jiong.wang@arm.com>
4736
4737         * aarch64-linux-nat.c
4738         (aarch64_linux_nat_target::read_description): Add pauth param.
4739         * aarch64-linux-tdep.c
4740         (aarch64_linux_core_read_description): Likewise.
4741         * aarch64-tdep.c (struct target_desc): Add in pauth.
4742         (aarch64_read_description): Add pauth param.
4743         (aarch64_gdbarch_init): Likewise.
4744         * aarch64-tdep.h (aarch64_read_description): Likewise.
4745         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4746         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4747         * features/Makefile: Add new files.
4748         * features/aarch64-pauth.c: New file.
4749         * features/aarch64-pauth.xml: New file.
4750
4751 2019-03-20  Tom Tromey  <tromey@adacore.com>
4752
4753         * infrun.c (handle_inferior_event): Rename from
4754         handle_inferior_event_1.  Create a scoped_value_mark.
4755         (handle_inferior_event): Remove.
4756
4757 2019-03-19  Tom Tromey  <tromey@adacore.com>
4758
4759         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4760         * infrun.h (print_stop_event): Add "displays" parameter.
4761         * infrun.c (print_stop_event): Add "displays" parameter.
4762
4763 2019-03-19  Pedro Alves  <palves@redhat.com>
4764
4765         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4766         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4767         to -1.  Fix TABs vs spaces.
4768         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4769         * tui/tui-out.h (tui_ui_out) Add intro comments.
4770         <m_line, m_start_of_line>: In-class initialize, and add describing
4771         comment.
4772
4773 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4774
4775         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4776         variable names.
4777         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4778
4779 2019-03-18  Pedro Alves  <palves@redhat.com>
4780             Eli Zaretskii <eliz@gnu.org>
4781
4782         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4783         m_line and m_start_of_line.
4784
4785 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4786
4787         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4788         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4789         it returns a newline.  This fixes a regression in TU mode, whereby
4790         the next line is output on the same screen line as the user input.
4791
4792 2019-03-18  Tom Tromey  <tromey@adacore.com>
4793
4794         * minsyms.c (minimal_symbol_reader::install): Remove call to
4795         obstack_blank.
4796
4797 2019-03-18  Pedro Alves  <palves@redhat.com>
4798
4799         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4800         New globals.
4801         (apply_style): New, factored out from ...
4802         (apply_ansi_escape): ... this.  Handle reverse video mode.
4803         (tui_set_reverse_mode): New function.
4804         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4805         * tui/tui-winsource.c (tui_show_source_line): Use
4806         tui_set_reverse_mode instead of setting A_STANDOUT.
4807         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4808         New setter methods.
4809
4810 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4811
4812         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4813         Handle tabs.
4814
4815 2019-03-18  Tom Tromey  <tromey@adacore.com>
4816
4817         * ada-lang.c (empty_array): Add "high" parameter.
4818         (ada_evaluate_subexp): Update.
4819
4820 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4821
4822         * unittests/string_view-selftests.c: Define
4823         _initialize_string_view_selftests unconditionally.
4824
4825 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4826
4827         PR gdb/24350
4828         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4829
4830 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4831
4832         PR gdb/24351
4833         * windows-nat.c (display_selector): Fix format specifiers.
4834
4835 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4836
4837         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4838         tui_refill_source_window instead of tui_refresh_win, to update the
4839         current execution line.  This fixes redisplay of the current line
4840         when stepping through the code with "next" or "step".
4841
4842 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4843
4844         * source-cache.c (source_cache::get_source_lines): Call
4845         find_source_lines to initialize s->nlines.  This fixes vertical
4846         scrolling of TUI source window when the DOWN arrow is pressed.
4847
4848 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4849
4850         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4851         linux-thread-db.c (_initialize_thread_db): Likewise.
4852
4853 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4854
4855         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4856         wclrtoeol in tui_show_source_line".  This reverts changes made in
4857         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4858
4859 2019-03-15  Tom Tromey  <tom@tromey.com>
4860
4861         * symtab.h (struct minimal_symbol): Derive from
4862         general_symbol_info.
4863         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4864         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4865         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4866         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4867         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4868         (MSYMBOL_SEARCH_NAME): Update.
4869         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4870         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4871         * minsyms.c (minimal_symbol_reader::record_full): Update.
4872
4873 2019-03-15  Tom Tromey  <tom@tromey.com>
4874
4875         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4876
4877 2019-03-15  Tom Tromey  <tom@tromey.com>
4878
4879         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4880         unique_xmalloc_ptr.
4881         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4882         Update.
4883         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4884         (build_minimal_symbol_hash_tables)
4885         (minimal_symbol_reader::install): Update.
4886
4887 2019-03-15  Tom Tromey  <tom@tromey.com>
4888
4889         * symtab.c (create_demangled_names_hash): Update.
4890         (symbol_set_names): Update.
4891         * objfiles.h (struct objfile_per_bfd_storage)
4892         <demangled_names_hash>: Now an htab_up.
4893         * objfiles.c (objfile_per_bfd_storage): Simplify.
4894
4895 2019-03-15  Tom Tromey  <tom@tromey.com>
4896
4897         * objfiles.h (struct objfile_per_bfd_storage): Declare
4898         destructor.
4899         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4900         New.
4901         (get_objfile_bfd_data): Use new.  Don't initialize
4902         language_of_main.
4903         (free_objfile_per_bfd_storage): Remove.
4904         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4905
4906 2019-03-15  Tom Tromey  <tom@tromey.com>
4907
4908         * symfile.c (reread_symbols): Update.
4909         * objfiles.c (objfile::objfile): Update.
4910         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4911         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4912         comment.
4913         (minimal_symbol_reader::install): Update.
4914         (terminate_minimal_symbol_table): Remove.
4915         * jit.c (jit_object_close_impl): Update.
4916
4917 2019-03-15  Tom Tromey  <tom@tromey.com>
4918
4919         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4920         initializations.
4921
4922 2019-03-15  Tom Tromey  <tom@tromey.com>
4923
4924         * objfiles.h (struct objfile_per_bfd_storage)
4925         <demangled_hash_languages>: Now a bitset.
4926         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4927         (lookup_minimal_symbol): Update.
4928
4929 2019-03-15  Tom Tromey  <tom@tromey.com>
4930
4931         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4932         Don't return the symbol.
4933         * coffread.c (record_minimal_symbol): Use record_full.
4934
4935 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4936
4937         The MS-Windows port of ncurses fails to switch to a color pair if
4938         one or both of the colors are the implicit default colors.  This
4939         change records the default colors when TUI is initialized, and
4940         then specifies them explicitly when a color pair uses the default
4941         colors.  This allows color styling in TUI mode on MS-Windows.
4942
4943         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4944         ncurses_norm_attr.
4945         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4946         colors in ncurses_norm_attr.
4947         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4948         "none", replace it with the default color recorded in
4949         ncurses_norm_attr.
4950
4951 2019-03-14  Tom Tromey  <tromey@adacore.com>
4952
4953         * source-cache.h (class source_cache) <get_source_lines>: Return
4954         std::string.
4955         * source-cache.c (source_cache::extract_lines): Handle case where
4956         first_pos==npos.  Return std::string.
4957         (source_cache::get_source_lines): Update.
4958
4959 2019-03-14  Tom Tromey  <tromey@adacore.com>
4960
4961         * NEWS: Add item for "style sources" commands.
4962         * source-cache.c (source_cache::get_source_lines): Check
4963         source_styling.
4964         * cli/cli-style.c (source_styling): New global.
4965         (_initialize_cli_style): Add "style sources" commands.
4966         (show_style_sources): New function.
4967         * cli/cli-style.h (source_styling): Declare.
4968
4969 2019-03-14  Pedro Alves  <palves@redhat.com>
4970             Tom Tromey  <tromey@adacore.com>
4971
4972         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4973         * tui/tui-winsource.c (tui_refill_source_window): New function,
4974         from...
4975         (tui_horizontal_source_scroll): ... here.  Move some logic.
4976         * cli/cli-style.c (set_style_enabled): Notify new observable.
4977         * tui/tui-hooks.c (tui_redisplay_source): New function.
4978         (tui_attach_detach_observers): Attach or detach
4979         tui_redisplay_source.
4980         * observable.h (source_styling_changed): New observable.
4981         * observable.c: Define source_styling_changed observable.
4982
4983 2019-03-13  Tom Tromey  <tromey@adacore.com>
4984
4985         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4986         (i386_gnu_nat_target::store_registers): Update.
4987         * target-debug.h (target_debug_print_std_string): New macro.
4988         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4989         * windows-tdep.c (display_one_tib): Update.
4990         * tui/tui-stack.c (tui_make_status_line): Update.
4991         * top.c (print_inferior_quit_action): Update.
4992         * thread.c (thr_try_catch_cmd): Update.
4993         (add_thread_with_info): Update.
4994         (thread_target_id_str): Update.
4995         (thr_try_catch_cmd): Update.
4996         (thread_command): Update.
4997         (thread_find_command): Update.
4998         * record-btrace.c (record_btrace_target::info_record)
4999         (record_btrace_resume_thread, record_btrace_target::resume)
5000         (record_btrace_cancel_resume, record_btrace_step_thread)
5001         (record_btrace_target::wait, record_btrace_target::wait)
5002         (record_btrace_target::wait, record_btrace_target::stop): Update.
5003         * progspace.c (print_program_space): Update.
5004         * process-stratum-target.c
5005         (process_stratum_target::thread_address_space): Update.
5006         * linux-fork.c (linux_fork_mourn_inferior)
5007         (detach_checkpoint_command, info_checkpoints_command)
5008         (linux_fork_context): Update.
5009         (linux_fork_detach): Update.
5010         (class scoped_switch_fork_info): Update.
5011         (delete_checkpoint_command): Update.
5012         * infrun.c (follow_fork_inferior): Update.
5013         (follow_fork_inferior): Update.
5014         (proceed_after_vfork_done): Update.
5015         (handle_vfork_child_exec_or_exit): Update.
5016         (follow_exec): Update.
5017         (displaced_step_prepare_throw): Update.
5018         (displaced_step_restore): Update.
5019         (start_step_over): Update.
5020         (resume_1): Update.
5021         (clear_proceed_status_thread): Update.
5022         (proceed): Update.
5023         (print_target_wait_results): Update.
5024         (do_target_wait): Update.
5025         (context_switch): Update.
5026         (stop_all_threads): Update.
5027         (restart_threads): Update.
5028         (finish_step_over): Update.
5029         (handle_signal_stop): Update.
5030         (switch_back_to_stepped_thread): Update.
5031         (keep_going_pass_signal): Update.
5032         (print_exited_reason): Update.
5033         (normal_stop): Update.
5034         * inferior.c (inferior_pid_to_str): Change return type.
5035         (print_selected_inferior): Update.
5036         (add_inferior): Update.
5037         (detach_inferior): Update.
5038         * dummy-frame.c (fprint_dummy_frames): Update.
5039         * dcache.c (dcache_info_1): Update.
5040         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5041         (btrace_fetch, btrace_clear): Update.
5042         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5043         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5044         type.
5045         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5046         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5047         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5048         * gdbarch.c, gdbarch.h: Rebuild.
5049         * gdbarch.sh (core_pid_to_str): Change return type.
5050         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5051         return type.
5052         (windows_nat_target::pid_to_str): Change return type.
5053         (windows_delete_thread): Update.
5054         (windows_nat_target::attach): Update.
5055         (windows_nat_target::files_info): Update.
5056         * target-delegates.c: Rebuild.
5057         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5058         return type.
5059         (sol_thread_target::pid_to_str): Change return type.
5060         * remote.c (class remote_target) <pid_to_str>: Change return
5061         type.
5062         (remote_target::pid_to_str): Change return type.
5063         (extended_remote_target::attach, remote_target::remote_stop_ns)
5064         (remote_target::remote_notif_remove_queued_reply)
5065         (remote_target::push_stop_reply, remote_target::disable_btrace):
5066         Update.
5067         (extended_remote_target::attach): Update.
5068         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5069         type.
5070         (gdbsim_target::pid_to_str): Change return type.
5071         * ravenscar-thread.c (struct ravenscar_thread_target)
5072         <pid_to_str>: Change return type.
5073         (ravenscar_thread_target::pid_to_str): Change return type.
5074         * procfs.c (class procfs_target) <pid_to_str>: Change return
5075         type.
5076         (procfs_target::pid_to_str): Change return type.
5077         (procfs_target::attach): Update.
5078         (procfs_target::detach): Update.
5079         (procfs_target::fetch_registers): Update.
5080         (procfs_target::store_registers): Update.
5081         (procfs_target::wait): Update.
5082         (procfs_target::files_info): Update.
5083         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5084         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5085         return type.
5086         (nto_procfs_target::pid_to_str): Change return type.
5087         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5088         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5089         return type.
5090         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5091         (exit_lwp): Update.
5092         (attach_proc_task_lwp_callback, get_detach_signal)
5093         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5094         (linux_nat_target::resume, wait_lwp, stop_callback)
5095         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5096         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5097         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5098         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5099         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5100         type.
5101         (inf_ptrace_target::attach): Update.
5102         (inf_ptrace_target::files_info): Update.
5103         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5104         type.
5105         (go32_nat_target::pid_to_str): Change return type.
5106         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5107         (gnu_nat_target::wait): Update.
5108         (gnu_nat_target::wait): Update.
5109         (gnu_nat_target::resume): Update.
5110         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5111         (fbsd_nat_target::wait): Update.
5112         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5113         type.
5114         (darwin_nat_target::attach): Update.
5115         * corelow.c (class core_target) <pid_to_str>: Change return type.
5116         (core_target::pid_to_str): Change return type.
5117         * target.c (normal_pid_to_str): Change return type.
5118         (default_pid_to_str): Likewise.
5119         (target_pid_to_str): Change return type.
5120         (target_translate_tls_address): Update.
5121         (target_announce_detach): Update.
5122         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5123         return type.
5124         (bsd_uthread_target::pid_to_str): Change return type.
5125         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5126         type.
5127         (bsd_kvm_target::pid_to_str): Change return type.
5128         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5129         return type.
5130         (aix_thread_target::pid_to_str): Change return type.
5131         * target.h (struct target_ops) <pid_to_str>: Change return type.
5132         (target_pid_to_str, normal_pid_to_str): Likewise.
5133         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5134         type.
5135         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5136         type.
5137         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5138         return type.
5139         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5140         type.
5141         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5142         type.
5143         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5144         return type.
5145
5146 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5147
5148         * NEWS: Mention that the new default MI version is 3.  Mention
5149         changes to the output of commands and events that deal with
5150         multi-location breakpoints.
5151         * breakpoint.c: Include "mi/mi-out.h".
5152         (print_one_breakpoint): Change output syntax if using MI version
5153         >= 3.
5154         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5155         New.
5156         (mi_multi_location_breakpoint_output_fixed): New.
5157         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5158         (mi_cmd_fix_multi_location_breakpoint_output): New.
5159         (mi_multi_location_breakpoint_output_fixed): New.
5160         * mi/mi-cmds.c (mi_cmds): Register command
5161         -fix-multi-location-breakpoint-output.
5162         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5163         interpreter "mi".
5164
5165 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5166
5167         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5168         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5169         instantiate mi_ui_out based on interpreter name.
5170         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5171         * mi/mi-main.c (mi_load_progress): Likewise.
5172
5173 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5174
5175         * NEWS: Combine separate "New targets" sections for 8.3.
5176
5177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5178
5179         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5180         (ppcfbsd_init_abi): Install gdbarch
5181         "fetch_tls_load_module_address" and "get_thread_local_address"
5182         methods.
5183
5184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5185
5186         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5187         (riscv_fbsd_init_abi): Install gdbarch
5188         "fetch_tls_load_module_address" and "get_thread_local_address"
5189         methods.
5190
5191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5192
5193         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5194         (i386fbsd_init_abi): Install gdbarch
5195         "fetch_tls_load_module_address" and "get_thread_local_address"
5196         methods.
5197
5198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5199
5200         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5201         (amd64fbsd_init_abi): Install gdbarch
5202         "fetch_tls_load_module_address" and "get_thread_local_address"
5203         methods.
5204
5205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5206
5207         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5208         (struct fbsd_pspace_data): New type.
5209         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5210         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5211         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5212         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5213         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5214
5215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5216
5217         * gdbtypes.c (lookup_struct_elt): New function.
5218         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5219         * gdbtypes.h (struct struct_elt): New type.
5220         (lookup_struct_elt): New prototype.
5221
5222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5223
5224         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5225         remove disabled code block.
5226
5227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5228
5229         * gdbarch.sh (get_thread_local_address): New method.
5230         * gdbarch.h, gdbarch.c: Regenerate.
5231         * target.c (target_translate_tls_address): Use
5232         gdbarch_get_thread_local_address if present instead of
5233         target::get_thread_local_address.
5234
5235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5236
5237         * target.h (target::get_thread_local_address): Update comment.
5238
5239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5240
5241         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5242         objfile->separate_debug_objfile_backlink if not NULL.
5243
5244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5245
5246         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5247         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5248         (amd64bsd_store_inferior_registers): Likewise.
5249         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5250         Enable segment base registers.
5251         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5252         PT_GETFSBASE and PT_GETGSBASE.
5253         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5254         PT_SETGSBASE.
5255         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5256         segment base registers.
5257         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5258
5259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5260
5261         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5262         Update calls to i386_target_description to add 'segments'
5263         parameter.
5264         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5265         add segment base registers.
5266         * arch/i386.c (i386_create_target_description): Add 'segments'
5267         parameter to enable segment base registers.
5268         * arch/i386.h (i386_create_target_description): Likewise.
5269         * features/i386/32bit-segments.xml: New file.
5270         * features/i386/32bit-segments.c: Generate.
5271         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5272         call to i386_target_description to add 'segments' parameter.
5273         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5274         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5275         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5276         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5277         if feature is present.
5278         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5279         Add 'segments' parameter to call to i386_target_description.
5280         (i386_target_description): Add 'segments' parameter to enable
5281         segment base registers.
5282         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5283         to call to i386_target_description.
5284         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5285         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5286         Define I386_NUM_REGS.
5287         (i386_target_description): Add 'segments' parameter to enable
5288         segment base registers.
5289
5290 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5291
5292         PR/24325
5293         * source-cache.c: #undef open and close, to avoid unresolved
5294         externals during linking.
5295
5296 2019-03-12  Tom Tromey  <tromey@adacore.com>
5297
5298         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5299         const.  Add initializers.
5300         (_initialize_remote): Don't initialize ptid globals.
5301
5302 2019-03-12  Pedro Alves  <palves@redhat.com>
5303
5304         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5305
5306 2019-03-12  Pedro Alves  <palves@redhat.com>
5307
5308         * cp-name-parser.y (main): Remove unused 'len' variable.
5309
5310 2019-03-12  Tom Tromey  <tromey@adacore.com>
5311
5312         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5313         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5314
5315 2019-03-12  Tom Tromey  <tromey@adacore.com>
5316
5317         * linux-nat.c (iterate_over_lwps): Update.
5318         (stop_callback): Remove parameter.
5319         (stop_wait_callback, detach_callback, resume_set_callback)
5320         (select_singlestep_lwp_callback, set_ignore_sigint)
5321         (status_callback, resumed_callback, resume_clear_callback)
5322         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5323         data parameter.
5324         (linux_nat_target::detach, linux_nat_target::resume)
5325         (linux_stop_and_wait_all_lwps, select_event_lwp)
5326         (linux_nat_filter_event, linux_nat_wait_1)
5327         (linux_nat_target::kill, linux_nat_target::stop)
5328         (linux_nat_target::stop): Update.
5329         (linux_nat_resume_callback): Change type.
5330         (resume_stopped_resumed_lwps, count_events_callback)
5331         (select_event_lwp_callback): Likewise.
5332         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5333         * arm-linux-nat.c (struct update_registers_data): Remove.
5334         (update_registers_callback): Change type.
5335         (arm_linux_insert_hw_breakpoint1): Update.
5336         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5337         parameter.
5338         (x86_linux_dr_set_addr): Update.
5339         (x86_linux_dr_set_control): Update.
5340         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5341         (iterate_over_lwps): Use gdb::function_view.
5342         * nat/aarch64-linux-hw-point.c (struct
5343         aarch64_dr_update_callback_param): Remove.
5344         (debug_reg_change_callback): Change type.
5345         (aarch64_notify_debug_reg_change): Update.
5346         * s390-linux-nat.c (s390_refresh_per_info): Update.
5347
5348 2019-03-11  Tom Tromey  <tromey@adacore.com>
5349
5350         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5351         redundant assignment to "this_cu".
5352
5353 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5354
5355         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5356
5357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5358
5359         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5360         from...
5361         (rank_one_type): ... this.
5362
5363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5364
5365         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5366         from...
5367         (rank_one_type): ... this.
5368
5369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5370
5371         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5372         from...
5373         (rank_one_type): ... this.
5374
5375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5376
5377         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5378         from...
5379         (rank_one_type): ... this.
5380
5381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5382
5383         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5384         from...
5385         (rank_one_type): ... this.
5386
5387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5388
5389         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5390         from...
5391         (rank_one_type): ... this.
5392
5393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5394
5395         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5396         from...
5397         (rank_one_type): ... this.
5398
5399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5400
5401         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5402         from...
5403         (rank_one_type): ... this.
5404
5405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5406
5407         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5408         from...
5409         (rank_one_type): ... this.
5410
5411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5412
5413         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5414         from...
5415         (rank_one_type): ... this.
5416
5417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5418
5419         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5420         from...
5421         (rank_one_type): ... this.
5422
5423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5424
5425         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5426         from...
5427         (rank_one_type): ... this.
5428
5429 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5430
5431         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5432         inferior-events' shows the example events.
5433
5434 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5435
5436         Support styling on native MS-Windows console
5437
5438         PR/24315
5439         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5440         on MS-Windows if $TERM is not defined.
5441
5442         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5443
5444         * posix-hdep.c (gdb_console_fputs):
5445         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5446         functions.
5447         * ui-file.h (gdb_console_fputs): Add prototype.
5448
5449         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5450         back to fputs only if the former returns zero.
5451
5452 2019-03-07  Tom Tromey  <tom@tromey.com>
5453
5454         * symmisc.c (print_symbol_bcache_statistics): Update.
5455         (print_objfile_statistics): Update.
5456         * symfile.c (allocate_symtab): Update.
5457         * stabsread.c: Don't include bcache.h.
5458         * psymtab.h (struct psymbol_bcache): Don't declare.
5459         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5460         (psymbol_bcache_init, psymbol_bcache_free)
5461         (psymbol_bcache_get_bcache): Don't declare.
5462         * psymtab.c (struct psymbol_bcache): Remove.
5463         (psymtab_storage::psymtab_storage): Update.
5464         (psymtab_storage::~psymtab_storage): Update.
5465         (psymbol_bcache_init, psymbol_bcache_free)
5466         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5467         (add_psymbol_to_bcache): Update.
5468         (allocate_psymtab): Update.
5469         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5470         macro_cache>: No longer pointers.
5471         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5472         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5473         * macrotab.c (macro_bcache): Update.
5474         * macroexp.c: Don't include bcache.h.
5475         * gdbtypes.c (check_types_worklist): Update.
5476         (types_deeply_equal): Remove TRY/CATCH.  Update.
5477         * elfread.c (elf_symtab_read): Update.
5478         * dwarf2read.c: Don't include bcache.h.
5479         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5480         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5481         (print_bcache_statistics, bcache_memory_used): Don't declare.
5482         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5483         methods.  Rename all data members.
5484         * bcache.c (struct bcache): Move to bcache.h.
5485         (bcache::expand_hash_table): Rename from expand_hash_table.
5486         (bcache): Remove.
5487         (bcache::insert): Rename from bcache_full.
5488         (bcache::compare): Rename from bcache_compare.
5489         (bcache_xmalloc): Remove.
5490         (bcache::~bcache): Rename from bcache_xfree.
5491         (bcache::print_statistics): Rename from print_bcache_statistics.
5492         (bcache::memory_used): Rename from bcache_memory_used.
5493
5494 2019-03-07  Pedro Alves  <palves@redhat.com>
5495
5496         * infrun.c (normal_stop): Also check for
5497         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5498
5499 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * f-lang.c (value_from_host_double): Moved to...
5502         * value.c (value_from_host_double): ...here.
5503         * value.h (value_from_host_double): Declare.
5504         * guile/scm-math.c (vlscm_convert_typed_number): Use
5505         value_from_host_double.
5506         (vlscm_convert_number): Likewise.
5507         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5508         * python/py-value.c (convert_value_from_python): Likewise.
5509
5510 2019-03-06  Tom Tromey  <tom@tromey.com>
5511
5512         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5513
5514 2019-03-06  Tom Tromey  <tom@tromey.com>
5515
5516         * utils.h (free_current_contents): Don't declare.
5517         * utils.c (free_current_contents): Remove.
5518
5519 2019-03-06  Tom Tromey  <tom@tromey.com>
5520
5521         * top.c (quit_force): Update.
5522         * main.c (captured_command_loop): Update.
5523         * common/new-op.c (operator new): Update.
5524         * common/common-exceptions.c (struct catcher)
5525         <save_cleanup_chain>: Remove member.
5526         (exceptions_state_mc_init): Update.
5527         (exception_try_scope_entry): Return nullptr.
5528         (exception_try_scope_exit, exception_rethrow)
5529         (throw_exception_sjlj, throw_exception_cxx): Update.
5530         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5531         (all_cleanups, do_cleanups, discard_cleanups)
5532         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5533         (restore_cleanups, restore_final_cleanups): Don't declare.
5534         (do_final_cleanups): Remove parameter.
5535         * common/cleanups.c (cleanup_chain, make_cleanup)
5536         (make_cleanup_dtor, all_cleanups, do_cleanups)
5537         (discard_my_cleanups, discard_cleanups)
5538         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5539         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5540         (null_cleanup): Remove.
5541         (do_final_cleanups): Remove parameter.
5542
5543 2019-03-06  Tom Tromey  <tom@tromey.com>
5544
5545         * remote.c (remote_target::remote_parse_stop_reply): Use
5546         unique_xmalloc_ptr.
5547
5548 2019-03-06  Tom Tromey  <tom@tromey.com>
5549
5550         * stabsread.c (struct stabs_field_info): Rename from field_info.
5551         <list, fnlist>: Add initializers.
5552         <obstack>: New member.
5553         (read_member_functions, read_struct_fields, read_baseclasses):
5554         Allocate on obstack.  Don't use cleanups.
5555         (read_one_struct_field, read_member_functions, read_struct_fields)
5556         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5557         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5558         (read_struct_type): Update.
5559
5560 2019-03-06  Tom Tromey  <tom@tromey.com>
5561
5562         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5563         * common/filestuff.h (make_cleanup_close): Don't declare.
5564         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5565         Remove.
5566
5567 2019-03-06  Tom Tromey  <tom@tromey.com>
5568
5569         * solib-aix.c: Use make_scope_exit.
5570
5571 2019-03-06  Tom Tromey  <tom@tromey.com>
5572
5573         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5574         Use make_scope_exit.
5575
5576 2019-03-06  Tom Tromey  <tom@tromey.com>
5577
5578         * solib-svr4.c (disable_probes_interface): Remove parameter.
5579         (svr4_handle_solib_event): Use make_scope_exit.
5580
5581 2019-03-06  Tom Tromey  <tom@tromey.com>
5582
5583         * remote.c (struct stop_reply_deleter): Remove.
5584         (stop_reply_up): Update.
5585         (struct stop_reply): Derive from notif_event.  Don't typedef.
5586         <regcache>: Now a std::vector.
5587         (stop_reply_xfree): Remove.
5588         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5589         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5590         (remote_target::discard_pending_stop_replies): Use delete.
5591         (remote_target::remote_parse_stop_reply): Update.
5592         (remote_target::process_stop_reply): Update.
5593         * remote-notif.h (struct notif_event): Add virtual destructor.
5594         Remove "dtr" member.
5595         (struct notif_client) <alloc_event>: Return a unique_ptr.
5596         (notif_event_xfree): Don't declare.
5597         (notif_event_up): New typedef.
5598         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5599         (notif_event_xfree, do_notif_event_xfree): Remove.
5600         (remote_notif_state_xfree): Update.
5601
5602 2019-03-06  Tom Tromey  <tom@tromey.com>
5603
5604         * infrun.c (displaced_step_clear_cleanup): Now a
5605         forward_scope_exit type.
5606         (displaced_step_prepare_throw): Update.
5607         (displaced_step_fixup): Update.
5608
5609 2019-03-06  Tom Tromey  <tom@tromey.com>
5610
5611         * inferior.h (class inferior): Update comment.
5612         * gdbthread.h (class thread_info): Update comment.
5613
5614 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5615             Tom Tromey  <tom@tromey.com>
5616
5617         * stabsread.h (struct stab_section_list): Remove.
5618         (coffstab_build_psymtabs): Update.
5619         * dbxread.c (symbuf_sections): Now a std::vector.
5620         (sect_idx): New global.
5621         (fill_symbuf): Update.
5622         (coffstab_build_psymtabs): Change type of stabsects parameter.
5623         Update.
5624         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5625         std::vector.
5626         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5627         (coff_locate_sections): Update.
5628         (coff_symfile_read): Remove cleanups.  Update.
5629         (init_stringtab): Add storage parameter.
5630         (free_stringtab, free_stringtab_cleanup): Remove.
5631         (init_lineno): Add storage parameter.
5632         (free_linetab, free_linetab_cleanup): Remove.
5633
5634 2019-03-06  Pedro Alves  <palves@redhat.com>
5635
5636         * linux-fork.c (fork_info::clobber_regs): Delete.
5637         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5638         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5639         comment.  Adjust.
5640         (scoped_switch_fork_info::scoped_switch_fork_info)
5641         (checkpoint_command, linux_fork_context): Adjust
5642         fork_save_infrun_state calls.
5643
5644 2019-03-06  Pedro Alves  <palves@redhat.com>
5645
5646         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5647         (inf_has_multiple_threads): Return 'bool' and rewrite using
5648         inferior_info::threads().
5649
5650 2019-03-06  Pedro Alves  <palves@redhat.com>
5651
5652         * linux-fork.c: Include <list>.
5653         (fork_list): Now a std::list instance.
5654         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5655         (forks_exist_p, find_last_fork): Adjust.
5656         (new_fork): Delete.
5657         (one_fork_p): New.
5658         (add_fork): Adjust.
5659         (free_fork): Delete, folded into fork_info::~fork_info().
5660         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5661         Adjust.
5662         (init_fork_list): Delete.
5663         (linux_fork_killall, linux_fork_mourn_inferior)
5664         (linux_fork_detach, info_checkpoints_command): Adjust.
5665         (_initialize_linux_fork): No longer call init_fork_list.
5666
5667 2019-03-06  Pedro Alves  <palves@redhat.com>
5668
5669         * linux-fork.c (new_fork): New, split out of ...
5670         (add_fork): ... this.  Return void.  Move "first fork" special
5671         case from here, to ...
5672         (checkpoint_command): ... here.
5673         * linux-linux.h (add_fork): Return void.
5674
5675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5678
5679 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5680             Chris January  <chris.january@arm.com>
5681             David Lecomber  <david.lecomber@arm.com>
5682
5683         * f-exp.y: New token, UNOP_INTRINSIC.
5684         (exp): New pattern using UNOP_INTRINSIC token.
5685         (f77_keywords): Add 'abs' keyword.
5686         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5687         (value_from_host_double): New function.
5688         (evaluate_subexp_f): Support UNOP_ABS.
5689
5690 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5691
5692         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5693         types.
5694
5695 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5698         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5699         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5700
5701 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5702
5703         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5704
5705 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5706             Chris January  <chris.january@arm.com>
5707
5708         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5709         * f-exp.y: Define 'KIND' token.
5710         (exp): New pattern for KIND expressions.
5711         (ptype): Handle types with a kind extension.
5712         (direct_abs_decl): Extend to spot kind extensions.
5713         (f77_keywords): Add 'kind' to the list.
5714         (push_kind_type): New function.
5715         (convert_to_kind_type): New function.
5716         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5717         * parse.c (operator_length_standard): Likewise.
5718         * parser-defs.h (enum type_pieces): Add tp_kind.
5719         * std-operator.def: Add UNOP_KIND.
5720
5721 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5722
5723         * f-exp.y (f_parse): Set yydebug.
5724
5725 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5726
5727         * f-lang.c (evaluate_subexp_f): New function.
5728         (exp_descriptor_f): New global.
5729         (f_language_defn): Use exp_descriptor_f instead of
5730         exp_descriptor_standard.
5731
5732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * f-exp.y (struct token): Add comments.
5735         (dot_ops): Remove uppercase versions and the end marker.
5736         (f77_keywords): Likewise.
5737         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5738         entries in the dot_ops array are case insensitive, and use
5739         strncasecmp to compare strings.  Also some whitespace cleanup in
5740         this area.  Similar for the f77_keywords array, except entries in
5741         this list might be case sensitive.
5742
5743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5744
5745         * f-exp.y (struct f77_boolean_val): Add comments.
5746         (boolean_values): Remove uppercase versions, and end marker.
5747         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5748         and use strncasecmp to achieve case insensitivity.  Additionally,
5749         perform whitespace cleanup around this code.
5750
5751 2019-03-06  Tom Tromey  <tromey@adacore.com>
5752
5753         * remote-sim.c (gdbsim_target_open): Use result of
5754         gdb_argv::release.
5755
5756 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5757         Dirk Schubert  <dirk.schubert@arm.com>
5758         Chris January  <chris.january@arm.com>
5759
5760         * eval.c (evaluate_subexp_standard): Call Fortran argument
5761         wrapping logic.
5762         * f-lang.c (struct value): A value which can be passed into a
5763         Fortran function call.
5764         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5765         where appropriate.
5766         (struct type): Value ready for a Fortran function call.
5767         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5768         is needed.
5769         * f-lang.h (fortran_argument_convert): Declaration.
5770         (fortran_preserve_arg_pointer): Declaration.
5771         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5772
5773 2019-03-05  Tom Tromey  <tromey@adacore.com>
5774
5775         * python/py-prettyprint.c (print_string_repr): Remove #if.
5776         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5777
5778 2019-03-05  Tom Tromey  <tromey@adacore.com>
5779
5780         * target.c (the_dummy_target): Move later.  Change type to
5781         "dummy_target".
5782         (initialize_targets): Don't initialize the_dummy_target.
5783
5784 2019-03-05  Tom Tromey  <tromey@adacore.com>
5785
5786         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5787         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5788
5789 2019-03-05  Tom Tromey  <tromey@adacore.com>
5790
5791         * windows-nat.c (windows_nat_target::attach)
5792         (windows_nat_target::detach): Don't call gdb_flush.
5793         * valprint.c (generic_val_print, val_print, val_print_string):
5794         Don't call gdb_flush.
5795         * utils.c (defaulted_query): Don't call gdb_flush.
5796         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5797         * target.c (target_announce_detach): Don't call gdb_flush.
5798         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5799         * remote.c (extended_remote_target::attach): Don't call
5800         gdb_flush.
5801         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5802         * printcmd.c (do_examine): Don't call gdb_flush.
5803         (info_display_command): Don't call gdb_flush.
5804         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5805         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5806         * memattr.c (info_mem_command): Don't call gdb_flush.
5807         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5808         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5809         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5810         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5811         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5812         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5813         (gnu_nat_target::detach): Don't call gdb_flush.
5814         * f-valprint.c (f_val_print): Don't call gdb_flush.
5815         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5816         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5817         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5818         gdb_flush.
5819         * c-valprint.c (c_val_print): Don't call gdb_flush.
5820         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5821
5822 2019-03-05  Tom Tromey  <tromey@adacore.com>
5823
5824         * varobj.c (update_dynamic_varobj_children): Update.
5825         (install_default_visualizer): Use reset, not release.
5826         * value.c (set_internalvar): Update.
5827         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5828         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5829         ATTRIBUTE_UNUSED_RESULT.
5830
5831 2019-03-05  Tom Tromey  <tromey@adacore.com>
5832
5833         * remote.c (class scoped_remote_fd) <release>: Add
5834         ATTRIBUTE_UNUSED_RESULT.
5835
5836 2019-03-05  Tom Tromey  <tromey@adacore.com>
5837
5838         * macroexp.c (struct macro_buffer) <release>: Add
5839         ATTRIBUTE_UNUSED_RESULT.
5840
5841 2019-03-05  Tom Tromey  <tromey@adacore.com>
5842
5843         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5844         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5845         ATTRIBUTE_UNUSED_RESULT.
5846
5847 2019-03-05  Tom Tromey  <tromey@adacore.com>
5848
5849         * common/scoped_fd.h (class scoped_fd) <release>: Add
5850         ATTRIBUTE_UNUSED_RESULT.
5851
5852 2019-03-05  Tom Tromey  <tromey@adacore.com>
5853
5854         * parser-defs.h (struct parser_state) <release>: Add
5855         ATTRIBUTE_UNUSED_RESULT.
5856
5857 2019-03-05  Tom Tromey  <tromey@adacore.com>
5858
5859         * utils.h (class gdb_argv) <release>: Add
5860         ATTRIBUTE_UNUSED_RESULT.
5861         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5862
5863 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5864
5865         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5866         for-loop range, to avoid compiler warnings.
5867
5868         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5869         avoid compiler warnings about unused variables.
5870
5871         * NEWS: Mention end of support for native debugging on MS-Windows
5872         before XP.
5873
5874         PR gdb/24292
5875         * common/netstuff.c:
5876         * gdbserver/gdbreplay.c
5877         * gdbserver/remote-utils.c:
5878         * ser-tcp.c:
5879         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5880         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5881         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5882         'getaddrinfo' and 'freeaddrinfo' were not available before
5883         Windows XP, and mingw.org's MinGW headers by default define
5884         _WIN32_WINNT to 0x500.
5885
5886 2019-03-01  Gary Benson <gbenson@redhat.com>
5887
5888         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5889
5890 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5891             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5892
5893         PR gdb/8527
5894         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5895         set_sigint_trap, clear_sigint_trap.
5896
5897 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5898
5899         * target.c (target_detach): Clear the regcache and the
5900         frame cache.
5901
5902 2019-02-27  Pedro Alves  <palves@redhat.com>
5903
5904         * utils.c (set_screen_size): When we cap the height/width sizes,
5905         tweak the corresponding command variable to show "unlimited":
5906
5907 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5908             Pedro Alves  <palves@redhat.com>
5909
5910         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5911         before calling rl_set_screen_size.
5912
5913 2019-02-27  Tom Tromey  <tromey@adacore.com>
5914
5915         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5916         define.
5917         * python/py-value.c: Remove Python 2.4 workaround.
5918         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5919         workaround.
5920         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5921         Python 2.4 workaround.
5922         * python/python-internal.h: Remove Python 2.4 comment.
5923         (Py_ssize_t): Don't define.
5924         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5925         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5926         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5927         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5928         * python/python.c (do_start_initialization): Remove Python 2.4
5929         workaround.
5930         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5931         (print_children): Remove Python 2.4 workaround.
5932         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5933         workaround.
5934         (CHARBUFFERPROC_NAME): Remove.
5935         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5936         Python 2.4 workaround.
5937
5938 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5939
5940         * NEWS: Note minimum Python version.
5941
5942 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5943
5944         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5945         code from these functions.  Remove corresponding ifdefs.  Use
5946         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5947         Remove gotos and target of gotos.
5948         (infpy_search_memory): Likewise.
5949
5950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5953         (hppa_gdbarch_init): Don't register deleted functions with
5954         gdbarch.
5955
5956 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5959         (h8300_unwind_sp): Delete.
5960         (h8300_dummy_id): Delete.
5961         (h8300_gdbarch_init): Don't register deleted functions with
5962         gdbarch.
5963
5964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5967         (ft32_unwind_pc): Delete.
5968         (ft32_unwind_sp): Delete.
5969         (ft32_gdbarch_init): Don't register deleted functions with
5970         gdbarch.
5971
5972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5975         (frv_unwind_pc): Delete.
5976         (frv_unwind_sp): Delete.
5977         (frv_gdbarch_init): Don't register deleted functions with
5978         gdbarch.
5979
5980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5981
5982         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5983         (riscv_unwind_pc): Delete.
5984         (riscv_unwind_sp): Delete.
5985         (riscv_gdbarch_init): Don't register deleted functions with
5986         gdbarch.
5987
5988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5989
5990         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5991         (csky_unwind_pc): Delete.
5992         (csky_unwind_sp): Delete.
5993         (csky_gdbarch_init): Don't register deleted functions with
5994         gdbarch.
5995
5996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5999         (cris_unwind_pc): Delete.
6000         (cris_unwind_sp): Delete.
6001         (cris_gdbarch_init): Don't register deleted functions with
6002         gdbarch.
6003
6004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6007         (bfin_unwind_pc): Delete.
6008         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6009
6010 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6011
6012         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6013         (arm_unwind_pc): Delete.
6014         (arm_unwind_sp): Delete.
6015         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6016
6017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6020         (arc_unwind_pc): Delete.
6021         (arc_unwind_sp): Delete.
6022         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6023
6024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6027         (alpha_unwind_pc): Delete.
6028         (alpha_gdbarch_init): Don't register deleted functions with
6029         gdbarch.
6030
6031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6034         (aarch64_unwind_pc): Delete.
6035         (aarch64_unwind_sp): Delete.
6036         (aarch64_gdbarch_init): Don't register deleted functions with
6037         gdbarch.
6038
6039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * gdbtypes.c (type_align): Don't consider static members when
6042         computing structure alignment.
6043
6044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6047         return 0 for other types.
6048         * arch-utils.c (default_type_align): Always return 0.
6049         * gdbarch.h: Regenerate.
6050         * gdbarch.sh (type_align): Extend comment.
6051         * gdbtypes.c (type_align): Add additional comments, always call
6052         gdbarch_type_align before applying the default rules.
6053         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6054         generic code will then apply a suitable default.
6055         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6056         types, return 0 for other types.
6057
6058 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6059
6060         * NEWS: Create a new section for the next release branch.
6061         Rename the section of the current branch, now that it has
6062         been cut.
6063
6064 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6065
6066         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6067         * version.in: Bump version to 8.3.50.DATE-git.
6068
6069 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6070
6071         * aix-thread.c (ptid_cmp): Remove unused variable.
6072         (get_signaled_thread): Likewise.
6073         (store_regs_user_thread): Likewise.
6074         (store_regs_kernel_thread): Likewise.
6075         (fetch_regs_kernel_thread): Remove shadowed variable.
6076
6077 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6078
6079         * features/riscv/32bit-cpu.xml: Add register numbers.
6080         * features/riscv/32bit-fpu.c: Regenerate.
6081         * features/riscv/32bit-fpu.xml: Add register numbers.
6082         * features/riscv/64bit-cpu.xml: Add register numbers.
6083         * features/riscv/64bit-fpu.c: Regenerate.
6084         * features/riscv/64bit-fpu.xml: Add register numbers.
6085
6086 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6087
6088         * NEWS: Mention two argument form of gdb.Value constructor.
6089         * python/py-value.c (convert_buffer_and_type_to_value): New
6090         function.
6091         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6092         Add support for handling an optional second argument.  Call
6093         convert_buffer_and_type_to_value as appropriate.
6094         * python/python-internal.h (Py_buffer_deleter): New struct.
6095         (Py_buffer_up): New typedef.
6096
6097 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6098
6099         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6100         instead of releasing ownership.
6101
6102 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6103
6104         * dwarf2read.c (open_and_init_dwp_file): Call
6105         elf_numsections instead of bfd_count_sections to initialize
6106         dwp_file->num_sections.
6107
6108 2019-02-25  Tom Tromey  <tromey@adacore.com>
6109
6110         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6111
6112 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6113
6114         * gcore.in: Add '--readnever' option when invoking GDB.
6115
6116 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6117
6118         * MAINTAINERS: Update my email address.
6119
6120 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6121
6122         * build-id.c (build_id_to_debug_bfd_1): New function.
6123         (build_id_to_debug_bfd): Look for separate debug file in
6124         sysroot.
6125
6126 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6127
6128         * gdbarch.sh: Update the copyright year range that is placed into
6129         generated files.
6130
6131 2019-02-22  Keith Seitz  <keiths@redhat.com>
6132
6133         PR symtab/23853
6134         * linespec.c (create_sals_line_offset): Search for the default
6135         symtab's filename instead of its fullname.
6136
6137 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6138
6139         * NEWS: Update style defaults.
6140
6141 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6142
6143         * main.c (captured_main_1): Disable styling in batch mode.
6144
6145 2019-02-20  Tom Tromey  <tom@tromey.com>
6146
6147         * symtab.c (symtab_symbol_info): Fix typos.
6148
6149 2019-02-20  Tom Tromey  <tromey@adacore.com>
6150
6151         * findcmd.c (_initialize_mem_search): Use upper case for
6152         metasyntactic variables.
6153
6154 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6155
6156         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6157         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6158
6159 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6160
6161         * top.h (source_file_name): Change to std::string.
6162         * top.c (source_file_name): Likewise.
6163         (command_line_input): Adjust.
6164         * cli/cli-script.c (script_from_file): Adjust.
6165
6166 2019-02-19  Tom Tromey  <tromey@adacore.com>
6167
6168         * ravenscar-thread.c
6169         (ravenscar_thread_target::update_thread_list): Don't call
6170         ada_build_task_list.
6171         * ada-lang.h (ada_build_task_list): Don't declare.
6172         * ada-tasks.c (struct ada_tasks_inferior_data)
6173         <task_list_valid_p>: Now bool.
6174         (read_known_tasks, ada_task_list_changed)
6175         (ada_tasks_invalidate_inferior_data): Update.
6176         (read_known_tasks_array): Return bool.
6177         (read_known_tasks_list): Likewise.
6178         (read_known_tasks): Return void.
6179         (ada_build_task_list): Now static.
6180
6181 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6184         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6185
6186 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6187
6188         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6189         variant for ada_tasks_pspace_data_handle and
6190         ada_tasks_inferior_data_handle.
6191         (ada_tasks_pspace_data_cleanup): New function.
6192         (ada_tasks_inferior_data_cleanup): New function.
6193
6194 2019-02-17  Tom Tromey  <tom@tromey.com>
6195
6196         * macrotab.h (macro_source_fullname): Return a std::string.
6197         * macrotab.c (macro_include, check_for_redefinition)
6198         (macro_undef, macro_lookup_definition, foreach_macro)
6199         (foreach_macro_in_scope): Update.
6200         (macro_source_fullname): Return a std::string.
6201         * macrocmd.c (show_pp_source_pos): Update.
6202
6203 2019-02-17  Tom Tromey  <tom@tromey.com>
6204
6205         * macrocmd.c (show_pp_source_pos): Style the file names.
6206
6207 2019-02-17  Tom Tromey  <tom@tromey.com>
6208
6209         PR tui/24197:
6210         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6211
6212 2019-02-17  Tom Tromey  <tom@tromey.com>
6213
6214         * ada-lang.c (user_select_syms): Use filtered printing.
6215         * utils.c (wrap_style): New global.
6216         (desired_style): Remove.
6217         (emit_style_escape): Add stream parameter.
6218         (set_output_style, reset_terminal_style, prompt_for_continue):
6219         Update.
6220         (flush_wrap_buffer): Only flush gdb_stdout.
6221         (wrap_here): Set wrap_style.
6222         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6223         treat escape sequences as a character.  Change when wrap buffer is
6224         flushed.
6225         (fputs_styled): Do not set the output style when the default is
6226         requested.
6227         * ui-style.h (struct ui_file_style) <is_default>: New method.
6228         * source.c (print_source_lines_base): Emit escape sequences in one
6229         piece.
6230
6231 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6232
6233         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6234         integers and enumeration types.
6235
6236 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6237
6238         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6239         instead of lookup_symbol_in_language
6240         (do_exact_match): New function.
6241         (ada_get_symbol_name_matcher): Return do_exact_match when
6242         doing a verbatim match.
6243
6244 2019-02-15  Tom Tromey  <tromey@adacore.com>
6245
6246         * ravenscar-thread.c (ravenscar_thread_target::resume)
6247         (ravenscar_thread_target::wait): Special case wildcard requests.
6248
6249 2019-02-15  Tom Tromey  <tromey@adacore.com>
6250
6251         * ravenscar-thread.c (base_ptid): Remove.
6252         (struct ravenscar_thread_target) <close>: New method.
6253         <m_base_ptid>: New member.
6254         <update_inferior_ptid, active_task, task_is_currently_active,
6255         runtime_initialized>: Declare methods.
6256         <ravenscar_thread_target>: Add constructor.
6257         (ravenscar_thread_target::task_is_currently_active)
6258         (ravenscar_thread_target::update_inferior_ptid)
6259         (ravenscar_runtime_initialized): Rename.  Now methods.
6260         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6261         (ravenscar_thread_target::update_thread_list): Update.
6262         (ravenscar_thread_target::active_task): Now method.
6263         (ravenscar_thread_target::store_registers)
6264         (ravenscar_thread_target::prepare_to_store)
6265         (ravenscar_thread_target::prepare_to_store)
6266         (ravenscar_thread_target::mourn_inferior): Update.
6267         (ravenscar_inferior_created): Use "new" to create target.
6268         (ravenscar_thread_target::get_ada_task_ptid): Update.
6269         (_initialize_ravenscar): Don't initialize base_ptid.
6270         (ravenscar_ops): Remove global.
6271
6272 2019-02-15  Tom Tromey  <tromey@adacore.com>
6273
6274         * target.h (push_target): Declare new overload.
6275         * target.c (push_target): New overload, taking an rvalue reference.
6276         * remote.c (remote_target::open_1): Use push_target overload.
6277         * corelow.c (core_target_open): Use push_target overload.
6278
6279 2019-02-15  Tom Tromey  <tromey@adacore.com>
6280
6281         * ravenscar-thread.c (is_ravenscar_task)
6282         (ravenscar_task_is_currently_active): Return bool.
6283         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6284         (_initialize_ravenscar): Remove "(void)".
6285         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6286         Return bool.
6287
6288 2019-02-15  Tom Tromey  <tromey@adacore.com>
6289
6290         * ravenscar-thread.c (ravenscar_runtime_initializer)
6291         (has_ravenscar_runtime, get_running_thread_id)
6292         (ravenscar_thread_target::resume): Fix indentation.
6293
6294 2019-02-15  Tom Tromey  <tromey@adacore.com>
6295
6296         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6297         from ravenscar_arch_ops.
6298         (sparc_ravenscar_ops::fetch_registers)
6299         (sparc_ravenscar_ops::store_registers): Now methods.
6300         (sparc_ravenscar_prepare_to_store): Remove.
6301         (sparc_ravenscar_ops): Redefine.
6302         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6303         methods and destructor.  Remove members.
6304         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6305         (ravenscar_thread_target::store_registers)
6306         (ravenscar_thread_target::prepare_to_store): Update.
6307         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6308         Remove.
6309         (struct ppc_ravenscar_powerpc_ops): Derive from
6310         ravenscar_arch_ops.
6311         (ppc_ravenscar_powerpc_ops::fetch_registers)
6312         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6313         (ppc_ravenscar_powerpc_ops): Redefine.
6314         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6315         (ppc_ravenscar_e500_ops::fetch_registers)
6316         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6317         (ppc_ravenscar_e500_ops): Redefine.
6318         * aarch64-ravenscar-thread.c
6319         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6320         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6321         (aarch64_ravenscar_fetch_registers)
6322         (aarch64_ravenscar_store_registers): Now methods.
6323         (aarch64_ravenscar_ops): Redefine.
6324
6325 2019-02-15  Tom Tromey  <tromey@adacore.com>
6326
6327         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6328         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6329         (ravenscar_thread_target::stopped_by_watchpoint)
6330         (ravenscar_thread_target::stopped_data_address)
6331         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6332
6333 2019-02-15  Tom Tromey  <tromey@adacore.com>
6334
6335         * ravenscar-thread.c: Fix some typos.
6336
6337 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6338             Tom Tromey  <tromey@adacore.com>
6339
6340         * ada-lang.c (ada_exception_sal): Change addr_string to a
6341         std::string.
6342         (create_ada_exception_catchpoint): Update.
6343
6344 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6345             Tom Tromey  <tromey@adacore.com>
6346
6347         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6348         (bp_location_ops): Remove.
6349         (base_breakpoint_allocate_location): Update.
6350         (free_bp_location): Update.
6351         * ada-lang.c (class ada_catchpoint_location)
6352         <ada_catchpoint_location>: Remove ops parameter.
6353         (ada_catchpoint_location_dtor): Remove.
6354         (ada_catchpoint_location_ops): Remove.
6355         (allocate_location_exception): Update.
6356         * breakpoint.h (struct bp_location_ops): Remove.
6357         (class bp_location) <bp_location>: Remove bp_location_ops
6358         parameter.
6359         <~bp_location>: Add destructor.
6360         <ops>: Remove.
6361
6362 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6363             Pedro Alves  <palves@redhat.com>
6364
6365         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6366         'PATH_MAX'.
6367
6368 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6369             Samuel Thibault  <samuel.thibault@gnu.org>
6370             Thomas Schwinge  <thomas@codesourcery.com>
6371
6372         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6373         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6374
6375 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6376
6377         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6378         (check_empty): Use "const char *".
6379
6380         * gnu-nat.c (gnu_nat_target::detach): Instead of
6381         'detach_inferior (pid)' call
6382         'detach_inferior (find_inferior_pid (pid))'.
6383
6384         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6385         'nat/fork-inferior.o'.
6386         * gnu-nat.c: #include "nat/fork-inferior.h".
6387
6388         * gnu-nat.c (gnu_nat_target::detach): Instead of
6389         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6390         * gnu-nat.h: #include "inf-child.h".
6391         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6392         'i386_gnu_nat_target::fetch_registers'.
6393         (gnu_store_registers): Rename/move to
6394         'i386_gnu_nat_target::store_registers'.
6395
6396         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6397         * gnu-nat.h (mach_thread_info): New function.
6398         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6399
6400         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6401
6402 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6403
6404         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6405
6406 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6407
6408         * windows-nat.c (windows_add_thread): Add new parameter
6409         "main_thread_p" with default value set to false.  Update
6410         function documentation as well as all callers.
6411         (windows_delete_thread): Likewise.
6412         (fake_create_process): Update call to windows_add_thread.
6413         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6414         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6415         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6416         call to windows_delete_thread.
6417
6418 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6419
6420         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6421
6422 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6423
6424         * symfile.c (find_separate_debug_file): Use canonical path of
6425         sysroot with child_path instead of gdb_sysroot if it is valid.
6426
6427 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6428
6429         * symfile.c (find_separate_debug_file): Use child_path to
6430         determine if an object file is under a sysroot.
6431
6432 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6433
6434         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6435         unittests/child-path-selftests.c.
6436         * common/pathstuff.c (child_path): New function.
6437         * common/pathstuff.h (child_path): New prototype.
6438         * unittests/child-path-selftests.c: New file.
6439
6440 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6441
6442         * symfile.c (find_separate_debug_file): Look for separate debug
6443         files in debug directories under the sysroot.
6444
6445 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6446
6447         * symtab.h (struct minimal_symbol data_p): New const method.
6448         (struct minimal_symbol text_p): Likewise.
6449         * symtab.c (output_source_filename): Use file name style
6450         to print file name.
6451         (print_symbol_info): Likewise.
6452         (print_msymbol_info): Use address style to print addresses.
6453         Use function name style to print executable text symbols.
6454         (expand_symtab_containing_pc): Use data_p.
6455         (find_pc_sect_compunit_symtab): Likewise.
6456
6457 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6458
6459         * breakpoint.c (describe_other_breakpoints): Use address style
6460         to print addresses.
6461         (say_where): Likewise.
6462
6463 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6464
6465         * ada-typeprint.c (print_func_type): Print function name
6466         style to print function name.
6467         * c-typeprint.c (c_print_type_1): Likewise.
6468
6469 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6470
6471         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6472         for execve.
6473
6474 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6475
6476         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6477         type_stack.
6478
6479 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6480
6481         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6482         TYPE_CODE_REF types.
6483
6484 2019-02-08  Jim Wilson  <jimw@sifive.com>
6485
6486         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6487         (riscv_linux_fregset): New.
6488         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6489
6490 2019-02-07  Tom Tromey  <tom@tromey.com>
6491
6492         * thread.c (thread_cancel_execution_command): Update.
6493         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6494         methods.
6495         (struct thread_fsm_ops): Remove.
6496         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6497         (thread_fsm_should_stop, thread_fsm_return_value)
6498         (thread_fsm_set_finished, thread_fsm_finished_p)
6499         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6500         Don't declare.
6501         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6502         * infrun.c (clear_proceed_status_thread)
6503         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6504         (print_stop_event): Update.
6505         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6506         Add constructor.
6507         (step_command_fsm_ops): Remove.
6508         (new_step_command_fsm): Remove.
6509         (step_1): Update.
6510         (step_command_fsm::should_stop): Rename from
6511         step_command_fsm_should_stop.
6512         (step_command_fsm::clean_up): Rename from
6513         step_command_fsm_clean_up.
6514         (step_command_fsm::do_async_reply_reason): Rename from
6515         step_command_fsm_async_reply_reason.
6516         (struct until_next_fsm): Inherit from thread_fsm.  Add
6517         constructor.
6518         (until_next_fsm_ops): Remove.
6519         (new_until_next_fsm): Remove.
6520         (until_next_fsm::should_stop): Rename from
6521         until_next_fsm_should_stop.
6522         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6523         (until_next_fsm::do_async_reply_reason): Rename from
6524         until_next_fsm_async_reply_reason.
6525         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6526         constructor.  Change type of breakpoint.
6527         (finish_command_fsm_ops): Remove.
6528         (new_finish_command_fsm): Remove.
6529         (finish_command_fsm::should_stop): Rename from
6530         finish_command_fsm_should_stop.
6531         (finish_command_fsm::clean_up): Rename from
6532         finish_command_fsm_clean_up.
6533         (finish_command_fsm::return_value): Rename from
6534         finish_command_fsm_return_value.
6535         (finish_command_fsm::do_async_reply_reason): Rename from
6536         finish_command_fsm_async_reply_reason.
6537         (finish_command): Update.
6538         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6539         Add constructor.
6540         (call_thread_fsm_ops): Remove.
6541         (call_thread_fsm::call_thread_fsm): Rename from
6542         new_call_thread_fsm.
6543         (call_thread_fsm::should_stop): Rename from
6544         call_thread_fsm_should_stop.
6545         (call_thread_fsm::should_notify_stop): Rename from
6546         call_thread_fsm_should_notify_stop.
6547         (run_inferior_call, call_function_by_hand_dummy): Update.
6548         * cli/cli-interp.c (should_print_stop_to_console): Update.
6549         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6550         Add constructor.  Change type of location_breakpoint,
6551         caller_breakpoint.
6552         (until_break_fsm_ops): Remove.
6553         (new_until_break_fsm): Remove.
6554         (until_break_fsm::should_stop): Rename from
6555         until_break_fsm_should_stop.
6556         (until_break_fsm::clean_up): Rename from
6557         until_break_fsm_clean_up.
6558         (until_break_fsm::do_async_reply_reason): Rename from
6559         until_break_fsm_async_reply_reason.
6560         (until_break_command): Update.
6561         * thread-fsm.c: Remove.
6562         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6563
6564 2019-02-07  Tom Tromey  <tom@tromey.com>
6565
6566         * yy-remap.h: Add include guard.
6567         * xtensa-tdep.h: Add include guard.
6568         * xcoffread.h: Rename include guard.
6569         * varobj-iter.h: Add include guard.
6570         * tui/tui.h: Rename include guard.
6571         * tui/tui-winsource.h: Rename include guard.
6572         * tui/tui-wingeneral.h: Rename include guard.
6573         * tui/tui-windata.h: Rename include guard.
6574         * tui/tui-win.h: Rename include guard.
6575         * tui/tui-stack.h: Rename include guard.
6576         * tui/tui-source.h: Rename include guard.
6577         * tui/tui-regs.h: Rename include guard.
6578         * tui/tui-out.h: Rename include guard.
6579         * tui/tui-layout.h: Rename include guard.
6580         * tui/tui-io.h: Rename include guard.
6581         * tui/tui-hooks.h: Rename include guard.
6582         * tui/tui-file.h: Rename include guard.
6583         * tui/tui-disasm.h: Rename include guard.
6584         * tui/tui-data.h: Rename include guard.
6585         * tui/tui-command.h: Rename include guard.
6586         * tic6x-tdep.h: Add include guard.
6587         * target/waitstatus.h: Rename include guard.
6588         * target/wait.h: Rename include guard.
6589         * target/target.h: Rename include guard.
6590         * target/resume.h: Rename include guard.
6591         * target-float.h: Rename include guard.
6592         * stabsread.h: Add include guard.
6593         * rs6000-tdep.h: Add include guard.
6594         * riscv-fbsd-tdep.h: Add include guard.
6595         * regformats/regdef.h: Rename include guard.
6596         * record.h: Rename include guard.
6597         * python/python.h: Rename include guard.
6598         * python/python-internal.h: Rename include guard.
6599         * python/py-stopevent.h: Rename include guard.
6600         * python/py-ref.h: Rename include guard.
6601         * python/py-record.h: Rename include guard.
6602         * python/py-record-full.h: Rename include guard.
6603         * python/py-record-btrace.h: Rename include guard.
6604         * python/py-instruction.h: Rename include guard.
6605         * python/py-events.h: Rename include guard.
6606         * python/py-event.h: Rename include guard.
6607         * procfs.h: Add include guard.
6608         * proc-utils.h: Add include guard.
6609         * p-lang.h: Add include guard.
6610         * or1k-tdep.h: Rename include guard.
6611         * observable.h: Rename include guard.
6612         * nto-tdep.h: Rename include guard.
6613         * nat/x86-linux.h: Rename include guard.
6614         * nat/x86-linux-dregs.h: Rename include guard.
6615         * nat/x86-gcc-cpuid.h: Add include guard.
6616         * nat/x86-dregs.h: Rename include guard.
6617         * nat/x86-cpuid.h: Rename include guard.
6618         * nat/ppc-linux.h: Rename include guard.
6619         * nat/mips-linux-watch.h: Rename include guard.
6620         * nat/linux-waitpid.h: Rename include guard.
6621         * nat/linux-ptrace.h: Rename include guard.
6622         * nat/linux-procfs.h: Rename include guard.
6623         * nat/linux-osdata.h: Rename include guard.
6624         * nat/linux-nat.h: Rename include guard.
6625         * nat/linux-namespaces.h: Rename include guard.
6626         * nat/linux-btrace.h: Rename include guard.
6627         * nat/glibc_thread_db.h: Rename include guard.
6628         * nat/gdb_thread_db.h: Rename include guard.
6629         * nat/gdb_ptrace.h: Rename include guard.
6630         * nat/fork-inferior.h: Rename include guard.
6631         * nat/amd64-linux-siginfo.h: Rename include guard.
6632         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6633         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6634         * nat/aarch64-linux.h: Rename include guard.
6635         * nat/aarch64-linux-hw-point.h: Rename include guard.
6636         * mn10300-tdep.h: Add include guard.
6637         * mips-linux-tdep.h: Add include guard.
6638         * mi/mi-parse.h: Rename include guard.
6639         * mi/mi-out.h: Rename include guard.
6640         * mi/mi-main.h: Rename include guard.
6641         * mi/mi-interp.h: Rename include guard.
6642         * mi/mi-getopt.h: Rename include guard.
6643         * mi/mi-console.h: Rename include guard.
6644         * mi/mi-common.h: Rename include guard.
6645         * mi/mi-cmds.h: Rename include guard.
6646         * mi/mi-cmd-break.h: Rename include guard.
6647         * m2-lang.h: Add include guard.
6648         * location.h: Rename include guard.
6649         * linux-record.h: Rename include guard.
6650         * linux-nat.h: Add include guard.
6651         * linux-fork.h: Add include guard.
6652         * i386-darwin-tdep.h: Rename include guard.
6653         * hppa-linux-offsets.h: Add include guard.
6654         * guile/guile.h: Rename include guard.
6655         * guile/guile-internal.h: Rename include guard.
6656         * gnu-nat.h: Rename include guard.
6657         * gdb-stabs.h: Rename include guard.
6658         * frv-tdep.h: Add include guard.
6659         * f-lang.h: Add include guard.
6660         * event-loop.h: Add include guard.
6661         * darwin-nat.h: Rename include guard.
6662         * cp-abi.h: Rename include guard.
6663         * config/sparc/nm-sol2.h: Rename include guard.
6664         * config/nm-nto.h: Rename include guard.
6665         * config/nm-linux.h: Add include guard.
6666         * config/i386/nm-i386gnu.h: Rename include guard.
6667         * config/djgpp/nl_types.h: Rename include guard.
6668         * config/djgpp/langinfo.h: Rename include guard.
6669         * compile/gcc-cp-plugin.h: Add include guard.
6670         * compile/gcc-c-plugin.h: Add include guard.
6671         * compile/compile.h: Rename include guard.
6672         * compile/compile-object-run.h: Rename include guard.
6673         * compile/compile-object-load.h: Rename include guard.
6674         * compile/compile-internal.h: Rename include guard.
6675         * compile/compile-cplus.h: Rename include guard.
6676         * compile/compile-c.h: Rename include guard.
6677         * common/xml-utils.h: Rename include guard.
6678         * common/x86-xstate.h: Rename include guard.
6679         * common/version.h: Rename include guard.
6680         * common/vec.h: Rename include guard.
6681         * common/tdesc.h: Rename include guard.
6682         * common/selftest.h: Rename include guard.
6683         * common/scoped_restore.h: Rename include guard.
6684         * common/scoped_mmap.h: Rename include guard.
6685         * common/scoped_fd.h: Rename include guard.
6686         * common/safe-iterator.h: Rename include guard.
6687         * common/run-time-clock.h: Rename include guard.
6688         * common/refcounted-object.h: Rename include guard.
6689         * common/queue.h: Rename include guard.
6690         * common/ptid.h: Rename include guard.
6691         * common/print-utils.h: Rename include guard.
6692         * common/preprocessor.h: Rename include guard.
6693         * common/pathstuff.h: Rename include guard.
6694         * common/observable.h: Rename include guard.
6695         * common/netstuff.h: Rename include guard.
6696         * common/job-control.h: Rename include guard.
6697         * common/host-defs.h: Rename include guard.
6698         * common/gdb_wait.h: Rename include guard.
6699         * common/gdb_vecs.h: Rename include guard.
6700         * common/gdb_unlinker.h: Rename include guard.
6701         * common/gdb_unique_ptr.h: Rename include guard.
6702         * common/gdb_tilde_expand.h: Rename include guard.
6703         * common/gdb_sys_time.h: Rename include guard.
6704         * common/gdb_string_view.h: Rename include guard.
6705         * common/gdb_splay_tree.h: Rename include guard.
6706         * common/gdb_setjmp.h: Rename include guard.
6707         * common/gdb_ref_ptr.h: Rename include guard.
6708         * common/gdb_optional.h: Rename include guard.
6709         * common/gdb_locale.h: Rename include guard.
6710         * common/gdb_assert.h: Rename include guard.
6711         * common/filtered-iterator.h: Rename include guard.
6712         * common/filestuff.h: Rename include guard.
6713         * common/fileio.h: Rename include guard.
6714         * common/environ.h: Rename include guard.
6715         * common/common-utils.h: Rename include guard.
6716         * common/common-types.h: Rename include guard.
6717         * common/common-regcache.h: Rename include guard.
6718         * common/common-inferior.h: Rename include guard.
6719         * common/common-gdbthread.h: Rename include guard.
6720         * common/common-exceptions.h: Rename include guard.
6721         * common/common-defs.h: Rename include guard.
6722         * common/common-debug.h: Rename include guard.
6723         * common/cleanups.h: Rename include guard.
6724         * common/buffer.h: Rename include guard.
6725         * common/btrace-common.h: Rename include guard.
6726         * common/break-common.h: Rename include guard.
6727         * cli/cli-utils.h: Rename include guard.
6728         * cli/cli-style.h: Rename include guard.
6729         * cli/cli-setshow.h: Rename include guard.
6730         * cli/cli-script.h: Rename include guard.
6731         * cli/cli-interp.h: Rename include guard.
6732         * cli/cli-decode.h: Rename include guard.
6733         * cli/cli-cmds.h: Rename include guard.
6734         * charset-list.h: Add include guard.
6735         * buildsym-legacy.h: Rename include guard.
6736         * bfin-tdep.h: Add include guard.
6737         * ax.h: Rename include guard.
6738         * arm-linux-tdep.h: Add include guard.
6739         * arm-fbsd-tdep.h: Add include guard.
6740         * arch/xtensa.h: Rename include guard.
6741         * arch/tic6x.h: Add include guard.
6742         * arch/i386.h: Add include guard.
6743         * arch/arm.h: Rename include guard.
6744         * arch/arm-linux.h: Rename include guard.
6745         * arch/arm-get-next-pcs.h: Rename include guard.
6746         * arch/amd64.h: Add include guard.
6747         * arch/aarch64-insn.h: Rename include guard.
6748         * arch-utils.h: Rename include guard.
6749         * annotate.h: Add include guard.
6750         * amd64-darwin-tdep.h: Rename include guard.
6751         * aarch64-linux-tdep.h: Add include guard.
6752         * aarch64-fbsd-tdep.h: Add include guard.
6753         * aarch32-linux-nat.h: Add include guard.
6754
6755 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6756
6757         * macrotab.c (macro_define_internal): New function that
6758         factorizes macro_define_object_internal and macro_define_function
6759         code.
6760         (macro_define_object_internal): Use macro_define_internal.
6761         (macro_define_function): Likewise.
6762
6763 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6764
6765         * macrocmd.c (extract_identifier): Return
6766         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6767         callers.
6768
6769 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6770
6771         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6772
6773 2019-02-05  Tom Tromey  <tom@tromey.com>
6774
6775         * target.c (target_stack::unpush): Move assertion earlier.
6776
6777 2019-01-30  Tom Tromey  <tom@tromey.com>
6778
6779         PR python/23615:
6780         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6781         (gdbpy_parse_and_eval): Likewise.
6782         * python/python-internal.h (gdbpy_allow_threads): New class.
6783
6784 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6785
6786         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6787         (aarch64_fbsd_fpregmap): Move earlier.
6788         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6789         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6790         instead of individual calls to trad_frame_set_reg_addr.
6791         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6792         earlier.
6793         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6794         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6795         instead of individual calls to trad_frame_set_reg_addr.
6796
6797 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6798
6799         * CONTRIBUTE: Replace contribution list with wiki link.
6800
6801 2019-01-25  Tom Tromey  <tom@tromey.com>
6802
6803         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6804
6805 2019-01-25  Tom Tromey  <tom@tromey.com>
6806
6807         * xtensa-linux-nat.c: Fix common/ includes.
6808         * xml-support.h: Fix common/ includes.
6809         * xml-support.c: Fix common/ includes.
6810         * x86-linux-nat.c: Fix common/ includes.
6811         * windows-nat.c: Fix common/ includes.
6812         * varobj.h: Fix common/ includes.
6813         * varobj.c: Fix common/ includes.
6814         * value.c: Fix common/ includes.
6815         * valops.c: Fix common/ includes.
6816         * utils.c: Fix common/ includes.
6817         * unittests/xml-utils-selftests.c: Fix common/ includes.
6818         * unittests/utils-selftests.c: Fix common/ includes.
6819         * unittests/unpack-selftests.c: Fix common/ includes.
6820         * unittests/tracepoint-selftests.c: Fix common/ includes.
6821         * unittests/style-selftests.c: Fix common/ includes.
6822         * unittests/string_view-selftests.c: Fix common/ includes.
6823         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6824         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6825         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6826         * unittests/rsp-low-selftests.c: Fix common/ includes.
6827         * unittests/parse-connection-spec-selftests.c: Fix common/
6828         includes.
6829         * unittests/optional-selftests.c: Fix common/ includes.
6830         * unittests/offset-type-selftests.c: Fix common/ includes.
6831         * unittests/observable-selftests.c: Fix common/ includes.
6832         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6833         * unittests/memrange-selftests.c: Fix common/ includes.
6834         * unittests/memory-map-selftests.c: Fix common/ includes.
6835         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6836         * unittests/function-view-selftests.c: Fix common/ includes.
6837         * unittests/environ-selftests.c: Fix common/ includes.
6838         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6839         * unittests/common-utils-selftests.c: Fix common/ includes.
6840         * unittests/cli-utils-selftests.c: Fix common/ includes.
6841         * unittests/array-view-selftests.c: Fix common/ includes.
6842         * ui-file.c: Fix common/ includes.
6843         * tui/tui-io.c: Fix common/ includes.
6844         * tracepoint.h: Fix common/ includes.
6845         * tracepoint.c: Fix common/ includes.
6846         * tracefile-tfile.c: Fix common/ includes.
6847         * top.h: Fix common/ includes.
6848         * top.c: Fix common/ includes.
6849         * thread.c: Fix common/ includes.
6850         * target/waitstatus.h: Fix common/ includes.
6851         * target/waitstatus.c: Fix common/ includes.
6852         * target.h: Fix common/ includes.
6853         * target.c: Fix common/ includes.
6854         * target-memory.c: Fix common/ includes.
6855         * target-descriptions.c: Fix common/ includes.
6856         * symtab.h: Fix common/ includes.
6857         * symfile.c: Fix common/ includes.
6858         * stap-probe.c: Fix common/ includes.
6859         * spu-linux-nat.c: Fix common/ includes.
6860         * sparc-nat.c: Fix common/ includes.
6861         * source.c: Fix common/ includes.
6862         * solib.c: Fix common/ includes.
6863         * solib-target.c: Fix common/ includes.
6864         * ser-unix.c: Fix common/ includes.
6865         * ser-tcp.c: Fix common/ includes.
6866         * ser-pipe.c: Fix common/ includes.
6867         * ser-base.c: Fix common/ includes.
6868         * selftest-arch.c: Fix common/ includes.
6869         * s12z-tdep.c: Fix common/ includes.
6870         * rust-exp.y: Fix common/ includes.
6871         * rs6000-aix-tdep.c: Fix common/ includes.
6872         * riscv-tdep.c: Fix common/ includes.
6873         * remote.c: Fix common/ includes.
6874         * remote-notif.h: Fix common/ includes.
6875         * remote-fileio.h: Fix common/ includes.
6876         * remote-fileio.c: Fix common/ includes.
6877         * regcache.h: Fix common/ includes.
6878         * regcache.c: Fix common/ includes.
6879         * record-btrace.c: Fix common/ includes.
6880         * python/python.c: Fix common/ includes.
6881         * python/py-type.c: Fix common/ includes.
6882         * python/py-inferior.c: Fix common/ includes.
6883         * progspace.h: Fix common/ includes.
6884         * producer.c: Fix common/ includes.
6885         * procfs.c: Fix common/ includes.
6886         * proc-api.c: Fix common/ includes.
6887         * printcmd.c: Fix common/ includes.
6888         * ppc-linux-nat.c: Fix common/ includes.
6889         * parser-defs.h: Fix common/ includes.
6890         * osdata.c: Fix common/ includes.
6891         * obsd-nat.c: Fix common/ includes.
6892         * nat/x86-linux.c: Fix common/ includes.
6893         * nat/x86-linux-dregs.c: Fix common/ includes.
6894         * nat/x86-dregs.h: Fix common/ includes.
6895         * nat/x86-dregs.c: Fix common/ includes.
6896         * nat/ppc-linux.c: Fix common/ includes.
6897         * nat/mips-linux-watch.h: Fix common/ includes.
6898         * nat/mips-linux-watch.c: Fix common/ includes.
6899         * nat/linux-waitpid.c: Fix common/ includes.
6900         * nat/linux-ptrace.h: Fix common/ includes.
6901         * nat/linux-ptrace.c: Fix common/ includes.
6902         * nat/linux-procfs.c: Fix common/ includes.
6903         * nat/linux-personality.c: Fix common/ includes.
6904         * nat/linux-osdata.c: Fix common/ includes.
6905         * nat/linux-namespaces.c: Fix common/ includes.
6906         * nat/linux-btrace.h: Fix common/ includes.
6907         * nat/linux-btrace.c: Fix common/ includes.
6908         * nat/fork-inferior.c: Fix common/ includes.
6909         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6910         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6911         * nat/aarch64-linux.c: Fix common/ includes.
6912         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6913         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6914         * namespace.h: Fix common/ includes.
6915         * mips-linux-tdep.c: Fix common/ includes.
6916         * minsyms.c: Fix common/ includes.
6917         * mi/mi-parse.h: Fix common/ includes.
6918         * mi/mi-main.c: Fix common/ includes.
6919         * mi/mi-cmd-env.c: Fix common/ includes.
6920         * memrange.h: Fix common/ includes.
6921         * memattr.c: Fix common/ includes.
6922         * maint.h: Fix common/ includes.
6923         * maint.c: Fix common/ includes.
6924         * main.c: Fix common/ includes.
6925         * machoread.c: Fix common/ includes.
6926         * location.c: Fix common/ includes.
6927         * linux-thread-db.c: Fix common/ includes.
6928         * linux-nat.c: Fix common/ includes.
6929         * linux-fork.c: Fix common/ includes.
6930         * inline-frame.c: Fix common/ includes.
6931         * infrun.c: Fix common/ includes.
6932         * inflow.c: Fix common/ includes.
6933         * inferior.h: Fix common/ includes.
6934         * inferior.c: Fix common/ includes.
6935         * infcmd.c: Fix common/ includes.
6936         * inf-ptrace.c: Fix common/ includes.
6937         * inf-child.c: Fix common/ includes.
6938         * ia64-linux-nat.c: Fix common/ includes.
6939         * i387-tdep.c: Fix common/ includes.
6940         * i386-tdep.c: Fix common/ includes.
6941         * i386-linux-tdep.c: Fix common/ includes.
6942         * i386-linux-nat.c: Fix common/ includes.
6943         * i386-go32-tdep.c: Fix common/ includes.
6944         * i386-fbsd-tdep.c: Fix common/ includes.
6945         * i386-fbsd-nat.c: Fix common/ includes.
6946         * guile/scm-type.c: Fix common/ includes.
6947         * guile/guile.c: Fix common/ includes.
6948         * go32-nat.c: Fix common/ includes.
6949         * gnu-nat.c: Fix common/ includes.
6950         * gdbthread.h: Fix common/ includes.
6951         * gdbarch-selftests.c: Fix common/ includes.
6952         * gdb_usleep.c: Fix common/ includes.
6953         * gdb_select.h: Fix common/ includes.
6954         * gdb_bfd.c: Fix common/ includes.
6955         * gcore.c: Fix common/ includes.
6956         * fork-child.c: Fix common/ includes.
6957         * findvar.c: Fix common/ includes.
6958         * fbsd-nat.c: Fix common/ includes.
6959         * event-top.c: Fix common/ includes.
6960         * event-loop.c: Fix common/ includes.
6961         * dwarf2read.c: Fix common/ includes.
6962         * dwarf2loc.c: Fix common/ includes.
6963         * dwarf2-frame.c: Fix common/ includes.
6964         * dwarf-index-cache.c: Fix common/ includes.
6965         * dtrace-probe.c: Fix common/ includes.
6966         * disasm-selftests.c: Fix common/ includes.
6967         * defs.h: Fix common/ includes.
6968         * csky-tdep.c: Fix common/ includes.
6969         * cp-valprint.c: Fix common/ includes.
6970         * cp-support.h: Fix common/ includes.
6971         * cp-support.c: Fix common/ includes.
6972         * corelow.c: Fix common/ includes.
6973         * completer.h: Fix common/ includes.
6974         * completer.c: Fix common/ includes.
6975         * compile/compile.c: Fix common/ includes.
6976         * compile/compile-loc2c.c: Fix common/ includes.
6977         * compile/compile-cplus-types.c: Fix common/ includes.
6978         * compile/compile-cplus-symbols.c: Fix common/ includes.
6979         * command.h: Fix common/ includes.
6980         * cli/cli-dump.c: Fix common/ includes.
6981         * cli/cli-cmds.c: Fix common/ includes.
6982         * charset.c: Fix common/ includes.
6983         * build-id.c: Fix common/ includes.
6984         * btrace.h: Fix common/ includes.
6985         * btrace.c: Fix common/ includes.
6986         * breakpoint.h: Fix common/ includes.
6987         * breakpoint.c: Fix common/ includes.
6988         * ax.h:
6989         (enum agent_op): Fix common/ includes.
6990         * ax-general.c (struct aop_map): Fix common/ includes.
6991         * ax-gdb.c: Fix common/ includes.
6992         * auxv.c: Fix common/ includes.
6993         * auto-load.c: Fix common/ includes.
6994         * arm-tdep.c: Fix common/ includes.
6995         * arch/riscv.c: Fix common/ includes.
6996         * arch/ppc-linux-common.c: Fix common/ includes.
6997         * arch/i386.c: Fix common/ includes.
6998         * arch/arm.c: Fix common/ includes.
6999         * arch/arm-linux.c: Fix common/ includes.
7000         * arch/arm-get-next-pcs.c: Fix common/ includes.
7001         * arch/amd64.c: Fix common/ includes.
7002         * arch/aarch64.c: Fix common/ includes.
7003         * arch/aarch64-insn.c: Fix common/ includes.
7004         * arch-utils.c: Fix common/ includes.
7005         * amd64-windows-tdep.c: Fix common/ includes.
7006         * amd64-tdep.c: Fix common/ includes.
7007         * amd64-sol2-tdep.c: Fix common/ includes.
7008         * amd64-obsd-tdep.c: Fix common/ includes.
7009         * amd64-nbsd-tdep.c: Fix common/ includes.
7010         * amd64-linux-tdep.c: Fix common/ includes.
7011         * amd64-linux-nat.c: Fix common/ includes.
7012         * amd64-fbsd-tdep.c: Fix common/ includes.
7013         * amd64-fbsd-nat.c: Fix common/ includes.
7014         * amd64-dicos-tdep.c: Fix common/ includes.
7015         * amd64-darwin-tdep.c: Fix common/ includes.
7016         * agent.c: Fix common/ includes.
7017         * ada-lang.h: Fix common/ includes.
7018         * ada-lang.c: Fix common/ includes.
7019         * aarch64-tdep.c: Fix common/ includes.
7020
7021 2019-01-25  Tom Tromey  <tom@tromey.com>
7022
7023         * common/create-version.sh: Use common/version.h.
7024
7025 2019-01-24  Pedro Alves  <palves@redhat.com>
7026
7027         * infrun.c (signal_stop, signal_print, signal_program)
7028         (signal_catch, signal_pass): Now arrays instead of pointers.
7029         (update_signals_program_target, do_target_resume)
7030         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7031         * linux-nat.c (linux_nat_target::pass_signals)
7032         (linux_nat_target::create_inferior, linux_nat_target::attach):
7033         Adjust.
7034         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7035         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7036         * procfs.c (procfs_target::pass_signals): Adjust.
7037         * record-full.c (record_full_target::resume): Adjust.
7038         * remote.c (remote_target::pass_signals)
7039         (remote_target::program_signals): Adjust.
7040         * target-debug.h (target_debug_print_signals): Now takes a
7041         gdb::array_view as parameter.  Adjust.
7042         * target.h (target_ops) <pass_signals, program_signals>: Replace
7043         pointer and length parameters with gdb::array_view.
7044         (target_pass_signals, target_program_signals): Likewise.
7045         * target-delegates.c: Regenerate.
7046
7047 2019-01-24  Pedro Alves  <palves@redhat.com>
7048
7049         * common/forward-scope-exit.h
7050         (forward_scope_exit::forward_scope_exit): Pass arguments to
7051         m_bind_function directly, instead of creating a std::bind and
7052         copying that.
7053
7054 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7055
7056         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7057         for static members.
7058         (pass_in_v_vfp_candidate): Likewise.
7059
7060 2019-01-23  Tom Tromey  <tom@tromey.com>
7061             Pedro Alves  <palves@redhat.com>
7062
7063         * regcache.c (class regcache_invalidator): Remove.
7064         (regcache::raw_write): Use make_scope_exit.
7065
7066 2019-01-23  Tom Tromey  <tom@tromey.com>
7067
7068         * ui-out.h (class ui_out_emit_type): Update comment.
7069
7070 2019-01-23  Tom Tromey  <tom@tromey.com>
7071
7072         * infrun.c (fetch_inferior_event): Update comment.
7073
7074 2019-01-23  Tom Tromey  <tom@tromey.com>
7075             Pedro Alves  <palves@redhat.com>
7076
7077         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7078         parameter.
7079         (fetch_inferior_event): Use SCOPE_EXIT.
7080
7081
7082 2019-01-23  Tom Tromey  <tom@tromey.com>
7083             Pedro Alves  <palves@redhat.com>
7084
7085         * infrun.c (disable_thread_events): Delete.
7086         (stop_all_threads): Use SCOPE_EXIT.
7087
7088 2019-01-23  Tom Tromey  <tom@tromey.com>
7089             Pedro Alves  <palves@redhat.com>
7090
7091         * symfile.c: Include forward-scope-exit.h.
7092         (clear_symtab_users_cleanup): Replace forward declaration with
7093         a FORWARD_SCOPE_EXIT.
7094         (syms_from_objfile_1): Use the forward_scope_exit and
7095         gdb::optional instead of cleanup_function.
7096         (reread_symbols): Use the forward_scope_exit instead of
7097         cleanup_function.
7098         (clear_symtab_users_cleanup): Remove function.
7099
7100 2019-01-23  Tom Tromey  <tom@tromey.com>
7101             Pedro Alves  <palves@redhat.com>
7102
7103         * linux-nat.c: Include scope-exit.h.
7104         (cleanup_target_stop): Remove.
7105         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7106         SCOPE_EXIT.
7107
7108 2019-01-23  Tom Tromey  <tom@tromey.com>
7109             Pedro Alves  <palves@redhat.com>
7110
7111         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7112         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7113
7114 2019-01-23  Tom Tromey  <tom@tromey.com>
7115             Andrew Burgess  <andrew.burgess@embecosm.com>
7116             Pedro Alves  <palves@redhat.com>
7117
7118         * infrun.c (fetch_inferior_event): Use scope_exit.
7119         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7120         * top.c (execute_command): Use scope_exit.
7121         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7122         * utils.c (do_bpstat_clear_actions_cleanup)
7123         (make_bpstat_clear_actions_cleanup): Remove.
7124
7125 2019-01-23  Tom Tromey  <tom@tromey.com>
7126             Pedro Alves  <palves@redhat.com>
7127
7128         * infrun.c: Include "common/scope-exit.h"
7129         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7130         (wait_for_inferior): Use SCOPE_EXIT.
7131         (fetch_inferior_event): Use scope_exit.
7132
7133 2019-01-23  Tom Tromey  <tom@tromey.com>
7134             Pedro Alves  <palves@redhat.com>
7135
7136         * breakpoint.c (create_breakpoint): Remove cleanup.
7137
7138 2019-01-23  Tom Tromey  <tom@tromey.com>
7139             Andrew Burgess  <andrew.burgess@embecosm.com>
7140             Pedro Alves  <palves@redhat.com>
7141
7142 2019-01-23  Pedro Alves  <palves@redhat.com>
7143
7144         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7145
7146 2019-01-23  Pedro Alves  <palves@redhat.com>
7147             Andrew Burgess  <andrew.burgess@embecosm.com>
7148
7149         * gdbthread.h: Include "common/forward-scope-exit.h".
7150         (scoped_finish_thread_state): Redefine custom class in terms of
7151         forward_scope_exit.
7152
7153 2019-01-23  Pedro Alves  <palves@redhat.com>
7154             Andrew Burgess  <andrew.burgess@embecosm.com>
7155
7156         * common/forward-scope-exit.h: New file.
7157
7158 2019-01-23  Pedro Alves  <palves@redhat.com>
7159             Andrew Burgess  <andrew.burgess@embecosm.com>
7160             Tom Tromey  <tom@tromey.com>
7161
7162         * common/scope-exit.h: New file.
7163
7164 2019-01-23  Pedro Alves  <palves@redhat.com>
7165
7166         * common/preprocessor.h (ESC): Rename to ...
7167         (ESC_PARENS): ... this.
7168         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7169         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7170
7171 2019-01-23  Tom Tromey  <tom@tromey.com>
7172
7173         * language.h (class scoped_switch_to_sym_language_if_auto):
7174         Initialize m_lang in both cases.
7175
7176 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7177
7178         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7179         with XCNEW.
7180
7181 2019-01-22  Tom Tromey  <tom@tromey.com>
7182
7183         * corelow.c: Do not include sys/file.h.
7184
7185 2019-01-22  Tom Tromey  <tom@tromey.com>
7186
7187         * tui/tui-wingeneral.h: Include gdb_curses.h.
7188
7189 2019-01-22  Tom Tromey  <tom@tromey.com>
7190
7191         * source-cache.h (class source_cache) <get_source_lines,
7192         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7193
7194 2019-01-22  Tom Tromey  <tom@tromey.com>
7195
7196         * remote-fileio.h (struct remote_target): Declare.
7197
7198 2019-01-22  Tom Tromey  <tom@tromey.com>
7199
7200         * python/py-arch.c: Do not include py-ref.h.
7201         * python/py-bpevent.c: Do not include py-ref.h.
7202         * python/py-cmd.c: Do not include py-ref.h.
7203         * python/py-continueevent.c: Do not include py-ref.h.
7204         * python/py-event.h: Do not include py-ref.h.
7205         * python/py-evtregistry.c: Do not include py-ref.h.
7206         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7207         * python/py-frame.c: Do not include py-ref.h.
7208         * python/py-framefilter.c: Do not include py-ref.h.
7209         * python/py-function.c: Do not include py-ref.h.
7210         * python/py-infevents.c: Do not include py-ref.h.
7211         * python/py-linetable.c: Do not include py-ref.h.
7212         * python/py-objfile.c: Do not include py-ref.h.
7213         * python/py-param.c: Do not include py-ref.h.
7214         * python/py-prettyprint.c: Do not include py-ref.h.
7215         * python/py-progspace.c: Do not include py-ref.h.
7216         * python/py-symbol.c: Do not include py-ref.h.
7217         * python/py-symtab.c: Do not include py-ref.h.
7218         * python/py-type.c: Do not include py-ref.h.
7219         * python/py-unwind.c: Do not include py-ref.h.
7220         * python/py-utils.c: Do not include py-ref.h.
7221         * python/py-value.c: Do not include py-ref.h.
7222         * python/py-varobj.c: Do not include py-ref.h.
7223         * python/py-xmethods.c: Do not include py-ref.h.
7224         * python/python.c: Do not include py-ref.h.
7225         * varobj.c: Do not include py-ref.h.
7226
7227 2019-01-22  Tom Tromey  <tom@tromey.com>
7228
7229         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7230         keyword for bcache.
7231
7232 2019-01-22  Tom Tromey  <tom@tromey.com>
7233
7234         * compile/compile-cplus-types.c: Remove a comment by #include.
7235
7236 2019-01-22  Tom Tromey  <tom@tromey.com>
7237
7238         * compile/gcc-c-plugin.h: Include compile-internal.h.
7239
7240 2019-01-22  Tom Tromey  <tom@tromey.com>
7241
7242         * stabsread.c (EXTERN): Do not define.
7243         (symnum, next_symbol_text_func, processing_gcc_compilation)
7244         (within_function, global_sym_chain, global_stabs)
7245         (previous_stab_code, this_object_header_files)
7246         (n_this_object_header_files)
7247         (n_allocated_this_object_header_files): Define.
7248         * stabsread.h (EXTERN): Never define.  Use "extern".
7249
7250 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7251
7252         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7253         history_value.
7254
7255 2019-01-21  Tom Tromey  <tom@tromey.com>
7256
7257         * ui-out.c: Fix includes.
7258         * tui/tui-source.c: Fix includes.
7259         * target.c: Fix includes.
7260         * remote.c: Fix includes.
7261         * regcache.c: Fix includes.
7262         * python/py-block.c: Fix includes.
7263         * printcmd.c: Fix includes.
7264         * or1k-tdep.c: Fix includes.
7265         * mi/mi-main.c: Fix includes.
7266         * m32r-tdep.c: Fix includes.
7267         * csky-tdep.c: Fix includes.
7268         * compile/compile-cplus-types.c: Fix includes.
7269         * cli/cli-interp.c: Fix includes.
7270
7271 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7272
7273         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7274         for padding.
7275
7276 2019-01-16  Tom Tromey  <tom@tromey.com>
7277
7278         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7279         earlier.
7280         (struct objfile) <msymbols_range>: Move from top level.
7281         <msymbols>: New method.
7282         (class objfile_msymbols): Remove.
7283         * symtab.c (default_collect_symbol_completion_matches_break_on):
7284         Update.
7285         * symmisc.c (dump_msymbols): Update.
7286         * stabsread.c (scan_file_globals): Update.
7287         * objc-lang.c (info_selectors_command, info_classes_command)
7288         (find_methods): Update.
7289         * minsyms.c (find_solib_trampoline_target): Update.
7290         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7291         * coffread.c (coff_symfile_read): Update.
7292         * ada-lang.c (ada_lookup_simple_minsym)
7293         (ada_collect_symbol_completion_matches): Update.
7294
7295 2019-01-16  Tom Tromey  <tom@tromey.com>
7296
7297         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7298         type.  Remove no-argument constructor.
7299         <iterator::operator++>: Simplify.
7300         <begin>: Update.
7301         <end>: Use minimal_symbol_count.
7302
7303 2019-01-16  Tom Tromey  <tom@tromey.com>
7304
7305         * objfiles.h (struct objfile) <psymtabs>: New method.
7306         (class objfile_psymtabs): Remove.
7307         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7308         typedef.
7309         <range>: New method.
7310         (require_partial_symbols): Change return type.
7311         * psymtab.c (require_partial_symbols)
7312         (psym_expand_symtabs_matching): Update.
7313         * mdebugread.c (parse_partial_symbols): Update.
7314         * dbxread.c (dbx_end_psymtab): Update.
7315
7316 2019-01-15  Tom Tromey  <tom@tromey.com>
7317
7318         * symtab.c (lookup_objfile_from_block)
7319         (lookup_symbol_in_objfile_symtabs)
7320         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7321         (find_line_symtab, info_sources_command)
7322         (default_collect_symbol_completion_matches_break_on)
7323         (make_source_files_completion_list): Update.
7324         * symmisc.c (print_objfile_statistics, dump_objfile)
7325         (maintenance_print_symbols, maintenance_info_symtabs)
7326         (maintenance_check_symtabs, maintenance_info_line_tables):
7327         Update.
7328         * source.c (select_source_symtab)
7329         (forget_cached_source_info_for_objfile): Update.
7330         * objfiles.h (class objfile_compunits): Remove.
7331         (struct objfile) <compunits_range>: New typedef.
7332         (compunits): New method.
7333         * objfiles.c (objfile_relocate1): Update.
7334         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7335         * maint.c (count_symtabs_and_blocks): Update.
7336         * linespec.c (iterate_over_all_matching_symtabs): Update.
7337         * cp-support.c (add_symbol_overload_list_qualified): Update.
7338         * coffread.c (coff_symtab_read): Update.
7339         * ada-lang.c (add_nonlocal_symbols)
7340         (ada_collect_symbol_completion_matches)
7341         (ada_add_global_exceptions): Update.
7342
7343 2019-01-15  Tom Tromey  <tom@tromey.com>
7344
7345         * progspace.h (program_space) <objfiles_safe_range>: New
7346         typedef.
7347         <objfiles_safe>: New method.
7348         * objfiles.h (class all_objfiles_safe): Remove.
7349         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7350         * jit.c (jit_inferior_exit_hook): Update.
7351
7352 2019-01-17  Tom Tromey  <tom@tromey.com>
7353
7354         * progspace.h (program_space) <objfiles_range>: New typedef.
7355         <objfiles>: New method.
7356         <objfiles_head>: Rename from objfiles.
7357         (object_files): Update.
7358         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7359         * guile/scm-pretty-print.c
7360         (ppscm_find_pretty_printer_from_objfiles): Update.
7361         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7362         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7363         Update.
7364         * python/py-progspace.c (pspy_get_objfiles): Update.
7365         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7366         Update.
7367         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7368         (objfpy_lookup_objfile_by_build_id): Update.
7369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7370         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7371         Update.
7372         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7373         (expand_symtab_containing_pc, lookup_objfile_from_block)
7374         (lookup_static_symbol, basic_lookup_transparent_type)
7375         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7376         (find_line_symtab, info_sources_command)
7377         (default_collect_symbol_completion_matches_break_on)
7378         (make_source_files_completion_list, find_main_name): Update.
7379         * symmisc.c (print_symbol_bcache_statistics)
7380         (print_objfile_statistics, maintenance_print_symbols)
7381         (maintenance_print_msymbols, maintenance_print_objfiles)
7382         (maintenance_info_symtabs, maintenance_check_symtabs)
7383         (maintenance_expand_symtabs, maintenance_info_line_tables):
7384         Update.
7385         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7386         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7387         (map_overlay_command, unmap_overlay_command)
7388         (simple_overlay_update, expand_symtabs_matching)
7389         (map_symbol_filenames): Update.
7390         * symfile-debug.c (set_debug_symfile): Update.
7391         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7392         Update.
7393         * source.c (select_source_symtab, forget_cached_source_info):
7394         Update.
7395         * solib.c (solib_read_symbols): Update.
7396         * solib-spu.c (append_ocl_sos): Update.
7397         * psymtab.c (maintenance_print_psymbols)
7398         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7399         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7400         * printcmd.c (info_symbol_command): Update.
7401         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7402         Update.
7403         * objfiles.h (class all_objfiles): Remove.
7404         * objfiles.c (have_partial_symbols, have_full_symbols)
7405         (have_minimal_symbols, qsort_cmp, update_section_map)
7406         (shared_objfile_contains_address_p)
7407         (default_iterate_over_objfiles_in_search_order): Update.
7408         * objc-lang.c (info_selectors_command, info_classes_command)
7409         (find_methods): Update.
7410         * minsyms.c (find_solib_trampoline_target): Update.
7411         * maint.c (maintenance_info_sections)
7412         (maintenance_translate_address, count_symtabs_and_blocks):
7413         Update.
7414         * main.c (captured_main_1): Update.
7415         * linux-thread-db.c (try_thread_db_load_from_pdir)
7416         (has_libpthread): Update.
7417         * linespec.c (iterate_over_all_matching_symtabs)
7418         (search_minsyms_for_name): Update.
7419         * jit.c (jit_find_objf_with_entry_addr): Update.
7420         * hppa-tdep.c (find_unwind_entry)
7421         (hppa_lookup_stub_minimal_symbol): Update.
7422         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7423         Update.
7424         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7425         (elf_gnu_ifunc_resolve_by_got): Update.
7426         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7427         * dwarf-index-write.c (save_gdb_index_command): Update.
7428         * cp-support.c (add_symbol_overload_list_qualified): Update.
7429         * breakpoint.c (create_overlay_event_breakpoint)
7430         (create_longjmp_master_breakpoint)
7431         (create_std_terminate_master_breakpoint)
7432         (create_exception_master_breakpoint): Update.
7433         * blockframe.c (find_pc_partial_function): Update.
7434         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7435         (ada_collect_symbol_completion_matches)
7436         (ada_add_global_exceptions): Update.
7437
7438 2019-01-17  Tom Tromey  <tom@tromey.com>
7439
7440         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7441         declare VEC.
7442         (solib_target_parse_libraries): Change return type.
7443         (library_list_start_segment, library_list_start_section)
7444         (library_list_end_library, library_list_start_library); Update.
7445         (solib_target_free_library_list): Remove.
7446         (solib_target_parse_libraries): Remove cleanup.  Change return
7447         type.
7448         (solib_target_current_sos): Update.
7449
7450 2019-01-17  Tom Tromey  <tromey@bapiya>
7451
7452         * valprint.c: Replace "the the" with "the".
7453         * symtab.c: Replace "the the" with "the".
7454         * solib.c: Replace "the the" with "the".
7455         * solib-dsbt.c: Replace "the the" with "the".
7456         * linespec.c: Replace "the the" with "the".
7457         * dwarf2loc.h: Replace "the the" with "the".
7458         * amd64-windows-tdep.c: Replace "the the" with "the".
7459         * aarch64-tdep.c: Replace "the the" with "the".
7460
7461 2019-01-16  Keith Seitz  <keiths@redhat.com>
7462
7463         PR gdb/23773
7464         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7465         <builder>: Rename to ..
7466         <m_builder>: ... this and make private.
7467         (dwarf2_cu::get_builder): New method.  Change all users of
7468         `builder' to use this method.
7469         (dwarf2_start_symtab): Move to ...
7470         (dwarf2_cu::start_symtab): ... here.  Update all callers
7471         (setup_type_unit_groups): Move to ...
7472         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7473         callers.
7474         (dwarf2_cu::reset_builder): New method.
7475         (process_full_compunit, process_full_type_unit): Use
7476         dwarf2_cu::reset_builder.
7477         (follow_die_offset): Record the ancestor CU if it is different
7478         from the followed DIE's CU.
7479         (follow_die_sig_1): Likewise.
7480
7481 2019-01-15  Tom Tromey  <tom@tromey.com>
7482
7483         * remote.c (class remote_state) <buf>: Now a char_vector.
7484         <buf_size>: Remove.
7485         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7486         parameter.
7487         (remote_target::getpkt_or_notif_sane_1)
7488         (remote_target::getpkt_sane)
7489         (remote_target::getpkt_or_notif_sane): Likewise.
7490         (class remote_target) <putpkt>: New overload.
7491         (remote_target::read_frame): Change type of "buf_p".  Remove
7492         sizeof_p parameter.
7493         (packet_ok): New overload.
7494         (packet_check_result): New overload.
7495         Update all uses.
7496
7497 2019-01-14  Tom Tromey  <tom@tromey.com>
7498
7499         * remote-notif.c (handle_notification, remote_notif_ack)
7500         (remote_notif_parse): Make "buf" const.
7501         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7502         const.
7503         (remote_notif_parse, remote_notif_ack, handle_notification):
7504         Likewise.
7505         * remote.c (remote_notif_stop_parse): Make "buf" const.
7506         (remote_target::remote_parse_stop_reply): Make "buf" const.
7507         (remote_notif_stop_ack): Make "buf" const.
7508
7509 2019-01-14  Tom Tromey  <tom@tromey.com>
7510
7511         * remote.c (remote_console_output): Make parameter const.
7512
7513 2019-01-14  Tom Tromey  <tom@tromey.com>
7514
7515         * target-debug.h (target_debug_print_signals): Constify.
7516         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7517         * procfs.c (procfs_target::pass_signals): Update.
7518         * linux-nat.c (linux_nat_target::pass_signals): Update.
7519         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7520         * target-delegates.c: Rebuild.
7521         * remote.c (remote_target::program_signals): Update.
7522         (remote_target::pass_signals): Update.
7523         * target.c (target_pass_signals): Constify argument.
7524         (target_program_signals): Likewise.
7525         * target.h (struct target_ops) <pass_signals, program_signals>:
7526         Constify argument.
7527         (target_pass_signals, target_program_signals): Constify argument.
7528
7529 2019-01-14  Tom Tromey  <tom@tromey.com>
7530
7531         PR tui/28819:
7532         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7533
7534 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7535
7536         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7537         field.
7538         * rs6000-tdep.c: Include reggroups.h.
7539         (IS_V_ALIAS_PSEUDOREG): Define.
7540         (rs6000_register_name): Return names for the "vX" aliases.
7541         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7542         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7543         aliases.  Call default_register_reggroup_p for all other
7544         pseudo-registers.
7545         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7546         New functions.
7547         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7548         Handle "vX" aliases.
7549         (v_alias_pseudo_register_collect): New function.
7550         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7551         (rs6000_gdbarch_init): Initialize "vX" aliases as
7552         pseudo-registers.  Restore registration of
7553         rs6000_pseudo_register_reggroup_p with
7554         set_tdesc_pseudo_register_reggroup_p.
7555
7556 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7557
7558         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7559         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7560         set_gdbarch_num_pseudo_regs.
7561
7562 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7563
7564         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7565         Remove arg prefixname, add do_set and do_show.
7566         Add member functions set_list and show_list.
7567         * cli/cli-style.c (class cli_style_option): Update accordingly.
7568         (style_set_list): Move to file scope.
7569         (style_show_list): Likewise.
7570         (set_style): Call help_list.
7571         (show_style): Call cmd_show_list.
7572         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7573         Update to use the new macro.
7574
7575 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7576
7577         * ada-lang.c (_initialize_ada_language): Expand the help text
7578         for the "catch exception" command.
7579
7580 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7581
7582         * symtab.c (matching_obj_sections): Initialize obj,
7583         declare it closer to its usage.
7584
7585 2019-01-10  Tom Tromey  <tom@tromey.com>
7586
7587         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7588         (basic_inf_threads_range): Remove.
7589         (inf_threads_range, inf_non_exited_threads_range)
7590         (safe_inf_threads_range): Use next_adapter.
7591
7592 2019-01-10  Keith Seitz  <keiths@redhat.com>
7593
7594         PR gdb/23712
7595         PR symtab/23010
7596         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7597         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7598
7599 2019-01-10  Keith Seitz  <keiths@redhat.com>
7600
7601         PR gdb/23712
7602         PR symtab/23010
7603         * dictionary.c (pending_to_vector): Remove.
7604         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7605         Remove _1 suffix, replacing functions of the same name.  Update
7606         all callers.
7607         (dict_create_hashed, dict_create_hashed_expandable)
7608         (dict_create_linear, dict_create_linear_expandable, dict_free)
7609         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7610         Make functions static.
7611
7612 2019-01-10  Keith Seitz  <keiths@redhat.com>
7613
7614         PR gdb/23712
7615         PR symtab/23010
7616         * dictionary.h (struct dictionary): Replace declaration with
7617         multidictionary.
7618         (dict_create_hashed, dict_create_hashed_expandable)
7619         (dict_create_linear, dict_create_linear_expandable)
7620         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7621         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7622         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7623         taking multidictionary argument.
7624         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7625         * block.h (struct block) <dict>: Change to multidictionary
7626         and rename `multidict'.
7627         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7628         symmisc.c: Update all dictionary references to multidictionary.
7629
7630 2019-01-10  Keith Seitz  <keiths@redhat.com>
7631
7632         PR gdb/23712
7633         PR symtab/23010
7634         * dictionary.c: Include unordered_map.
7635         (pending_to_vector): New function.
7636         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7637         Rewrite the non-"_1" functions to take vector instead
7638         of linked list.
7639         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7640         "new" _1 versions of the same name.
7641         (multidictionary): Define.
7642         (std::hash<enum language): New definition.
7643         (collate_pending_symbols_by_language, mdict_create_hashed)
7644         (mdict_create_hashed_expandable, mdict_create_linear)
7645         (mdict_create_linear_expandable, mdict_free)
7646         (find_language_dictionary, create_new_language_dictionary)
7647         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7648         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7649         (mdict_size, mdict_empty): New functions.
7650         * dictionary.h (mdict_iterator): Define.
7651
7652 2019-01-10  Pedro Alves  <palves@redhat.com>
7653
7654         * breakpoint.c (read_uploaded_action)
7655         (create_tracepoint_from_upload): Adjust to use
7656         gdb::unique_xmalloc_ptr.
7657         * ctf.c (ctf_write_uploaded_tp):
7658         (SET_ARRAY_FIELD): Use emplace_back.
7659         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7660         * tracefile-tfile.c (tfile_write_uploaded_tp):
7661         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7662         gdb::unique_xmalloc_ptr.
7663         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7664         at_string, cond_string, cmd_strings>: Replace char pointers
7665         with gdb::unique_xmalloc_ptr.
7666
7667 2019-01-10  Pedro Alves  <palves@redhat.com>
7668
7669         * solib-target.c (library_list_start_library): Don't xstrdup name.
7670
7671 2019-01-10  Pedro Alves  <palves@redhat.com>
7672
7673         * mdebugread.c (parse_partial_symbols): Use
7674         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7675
7676 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * linux-fork.c (scoped_switch_fork_info)
7679         <~scoped_switch_fork_info>: Fix incorrect variable name.
7680
7681 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7682
7683         * linux-fork.c (scoped_switch_fork_info)
7684         <scoped_switch_fork_info>: Make explicit.
7685         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7686
7687 2019-01-10  Tom Tromey  <tom@tromey.com>
7688
7689         * objfiles.h (objfile::reset_psymtabs): Update.
7690         * objfiles.c (objfile::objfile): Update.
7691         * psymtab.h (psymtab_storage::obstack): Update.
7692         (psymtab_storage::m_obstack): Use gdb::optional.
7693         (class psymtab_storage): Update comment.  Remove objfile
7694         parameter.
7695         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7696
7697 2019-01-10  Tom Tromey  <tom@tromey.com>
7698
7699         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7700         <free_psymtabs>: Now private.
7701         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7702         (allocate_psymtab): Use new method.
7703
7704 2019-01-10  Tom Tromey  <tom@tromey.com>
7705
7706         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7707         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7708         * mdebugread.c (parse_partial_symbols): Use
7709         allocate_dependencies.
7710         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7711         allocate_dependencies.
7712         (process_psymtab_comp_unit_reader)
7713         (build_type_psymtab_dependencies): Likewise.
7714         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7715
7716 2019-01-10  Tom Tromey  <tom@tromey.com>
7717
7718         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7719         PSYMBOL_SET_LANGUAGE.
7720         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7721
7722 2019-01-10  Tom Tromey  <tom@tromey.com>
7723
7724         * psymtab.h (psymtab_storage::obstack): New method.
7725         <m_obstack>: Rename from obstack; now private.
7726         * psymtab.c (psymtab_storage): Update.
7727         * dwarf2read.c (create_addrmap_from_index)
7728         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7729         Update.
7730
7731 2019-01-10  Tom Tromey  <tom@tromey.com>
7732
7733         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7734         * objfiles.h (objfile::reset_psymtabs): New method.
7735
7736 2019-01-10  Tom Tromey  <tom@tromey.com>
7737
7738         * symmisc.c (print_symbol_bcache_statistics): Update.
7739         (print_objfile_statistics): Update.
7740         * symfile.c (reread_symbols): Update.
7741         * psymtab.h (class psymtab_storage): New.
7742         * psymtab.c (psymtab_storage): New constructor.
7743         (~psymtab_storage): New destructor.
7744         (require_partial_symbols): Update.
7745         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7746         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7747         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7748         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7749         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7750         (start_psymtab_common, end_psymtab_common)
7751         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7752         (allocate_psymtab): Update.
7753         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7754         Update.
7755         (dump_psymtab_addrmap, maintenance_print_psymbols)
7756         (maintenance_check_psymtabs): Update.
7757         (class objfile_psymtabs): Move to objfiles.h.
7758         * psympriv.h (discard_psymtab): Now inline.
7759         (psymtab_discarder::psymtab_discarder): Update.
7760         (psymtab_discarder::~psymtab_discarder): Update.
7761         (ALL_OBJFILE_PSYMTABS): Rewrite.
7762         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7763         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7764         Remove fields.
7765         <partial_symtabs>: New field.
7766         (class objfile_psymtabs): Move from psymtab.h.  Update.
7767         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7768         psymbol_cache.
7769         (objfile::~objfile): Don't destroy psymbol_cache.
7770         * mdebugread.c (parse_partial_symbols): Update.
7771         * dwarf2read.c (create_addrmap_from_index)
7772         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7773         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7774         (add_partial_subprogram, dwarf2_ranges_read): Update.
7775         * dwarf-index-write.c (write_address_map)
7776         (write_one_signatured_type, recursively_write_psymbols)
7777         (class debug_names, class debug_names, write_psymtabs_to_index):
7778         Update.
7779
7780 2019-01-10  Tom Tromey  <tom@tromey.com>
7781
7782         * symtab.h (SYMBOL_SET_NAMES): Update.
7783         (symbol_set_names): Update.
7784         (MSYMBOL_SET_NAMES): Update.
7785         * symtab.c (symbol_set_names): Change argument to be an
7786         objfile_per_bfd_storage.
7787         * psymtab.c (add_psymbol_to_bcache): Update.
7788         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7789
7790 2019-01-10  Tom Tromey  <tom@tromey.com>
7791
7792         * symtab.c (create_demangled_names_hash): Change argument to be an
7793         objfile_per_bfd_storage.
7794         (symbol_set_names): Update.
7795
7796 2019-01-10  Tom Tromey  <tom@tromey.com>
7797
7798         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7799         init_psymbol_list.
7800         * psymtab.c (init_psymbol_list): Do nothing if already called.
7801         * psympriv.h (init_psymbol_list): Add comment.
7802         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7803         init_psymbol_list.
7804         * dbxread.c (dbx_symfile_read): Unconditionally call
7805         init_psymbol_list.
7806
7807 2019-01-10  Tom Tromey  <tom@tromey.com>
7808
7809         * xcoffread.c (scan_xcoff_symtab): Update.
7810         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7811         "where".
7812         * mdebugread.c (parse_partial_symbols)
7813         (handle_psymbol_enumerators): Update.
7814         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7815         * dbxread.c (read_dbx_symtab): Update.
7816         * psympriv.h (psymbol_placement): New enum.
7817         (add_psymbol_to_list): Update.
7818
7819 2019-01-10  Tom Tromey  <tom@tromey.com>
7820
7821         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7822         static_psymbols parameters.
7823         (scan_xcoff_symtab): Update.
7824         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7825         static_psymbols parameters.
7826         * psympriv.h (start_psymtab_common): Update.
7827         * mdebugread.c (parse_partial_symbols): Update.
7828         * dwarf2read.c (create_partial_symtab): Update.
7829         * dbxread.c (read_dbx_symtab): Update.
7830         (start_psymtab): Remove global_psymbols and static_psymbols
7831         parameters.
7832
7833 2019-01-10  Tom Tromey  <tom@tromey.com>
7834
7835         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7836         * psymtab.c (allocate_psymtab): Add comment.
7837         * psympriv.h (allocate_psymtab): Add comment.
7838         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7839         initializations.
7840         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7841
7842 2019-01-10  Tom Tromey  <tom@tromey.com>
7843
7844         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7845         Don't declare.
7846         * mipsread.c: Include mdebugread.h.
7847         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7848         Declare.
7849         * elfread.c: Include mdebugread.h.
7850
7851 2019-01-09  Tom Tromey  <tom@tromey.com>
7852
7853         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7854         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7855         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7856         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7857         (psym_lookup_symbol, psym_find_last_source_symtab)
7858         (psym_forget_cached_source_info, psym_print_stats)
7859         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7860         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7861         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7862         (psym_find_compunit_symtab_by_address)
7863         (maintenance_print_psymbols, maintenance_info_psymtabs)
7864         (maintenance_check_psymtabs): Use ranged for.
7865         * psymtab.h (class objfile_psymtabs): New.
7866         (require_partial_symbols): Return objfile_psymtabs.
7867         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7868
7869 2019-01-09  Tom Tromey  <tom@tromey.com>
7870
7871         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7872         (find_pc_mapped_section, list_overlays_command)
7873         (map_overlay_command, unmap_overlay_command)
7874         (simple_overlay_update): Use all_objfiles.
7875         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7876         * printcmd.c (info_symbol_command): Use all_objfiles.
7877         * objfiles.h (ALL_OBJSECTIONS): Remove.
7878         * maint.c (maintenance_translate_address): Use all_objfiles.
7879         * gcore.c (gcore_create_callback): Use all_objfiles.
7880         (objfile_find_memory_regions): Likewise.
7881
7882 2019-01-09  Tom Tromey  <tom@tromey.com>
7883
7884         * symtab.c (find_line_symtab, info_sources_command)
7885         (make_source_files_completion_list): Use objfile_compunits.
7886         * source.c (select_source_symtab): Use objfile_compunits.
7887         * objfiles.h (struct objfile): Update comment.
7888         (ALL_OBJFILES): Remove.
7889         (ALL_FILETABS): Remove.
7890         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7891         objfile_compunits.
7892
7893 2019-01-09  Tom Tromey  <tom@tromey.com>
7894
7895         * symmisc.c (print_objfile_statistics, dump_objfile)
7896         (maintenance_print_symbols): Use compunit_filetabs.
7897         * source.c (forget_cached_source_info_for_objfile): Use
7898         compunit_filetabs.
7899         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7900         (ALL_FILETABS): Use compunit_filetabs.
7901         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7902         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7903
7904 2019-01-09  Tom Tromey  <tom@tromey.com>
7905
7906         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7907         (compunit_filetabs): New.
7908         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7909         compunit_filetabs.
7910         (info_sources_command, make_source_files_completion_list): Remove
7911         declaration.
7912         * symmisc.c (print_objfile_statistics, dump_objfile)
7913         (maintenance_print_symbols): Remove declaration.
7914         (maintenance_info_symtabs): Use compunit_filetabs.
7915         (maintenance_info_line_tables): Likewise.
7916         * source.c (select_source_symtab): Change local variable name.
7917         (forget_cached_source_info_for_objfile): Remove declaration.
7918         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7919         * objfiles.c (objfile_relocate1): Remove declaration.
7920         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7921         declaration.
7922         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7923         * coffread.c (coff_symtab_read): Remove declaration.
7924         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7925         compunit_filetabs.
7926
7927 2019-01-09  Tom Tromey  <tom@tromey.com>
7928
7929         * symtab.c (lookup_objfile_from_block)
7930         (find_pc_sect_compunit_symtab, search_symbols)
7931         (default_collect_symbol_completion_matches_break_on): Use
7932         objfile_compunits.
7933         * objfiles.h (ALL_COMPUNITS): Remove.
7934         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7935         * cp-support.c (add_symbol_overload_list_qualified): Use
7936         objfile_compunits.
7937         * ada-lang.c (ada_collect_symbol_completion_matches)
7938         (ada_add_global_exceptions): Use objfile_compunits.
7939
7940 2019-01-09  Tom Tromey  <tom@tromey.com>
7941
7942         * source.c (select_source_symtab)
7943         (forget_cached_source_info_for_objfile): Remove declaration.
7944         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7945         declaration.
7946         * maint.c (count_symtabs_and_blocks): Remove declaration.
7947         * cp-support.c (add_symbol_overload_list_qualified): Remove
7948         declaration.
7949         * coffread.c (coff_symtab_read): Remove declaration.
7950         * symtab.c (lookup_symbol_in_objfile_symtabs)
7951         (basic_lookup_transparent_type_1): Use objfile_compunits.
7952         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7953         (info_sources_command, search_symbols)
7954         (default_collect_symbol_completion_matches_break_on)
7955         (make_source_files_completion_list): Remove declaration.
7956         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7957         (ada_collect_symbol_completion_matches)
7958         (ada_add_global_exceptions): Remove declaration.
7959         * linespec.c (iterate_over_all_matching_symtabs): Use
7960         objfile_compunits.
7961         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7962         (class objfile_compunits): New.
7963         (ALL_COMPUNITS): Use objfile_compunits.
7964         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7965         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7966         objfile_compunits.
7967         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7968
7969 2019-01-09  Tom Tromey  <tom@tromey.com>
7970
7971         * symtab.c (search_symbols)
7972         (default_collect_symbol_completion_matches_break_on): Use
7973         objfile_msymbols.
7974         * ada-lang.c (ada_lookup_simple_minsym)
7975         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7976         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7977         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7978         objfile_msymbols.
7979         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7980         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7981         * objc-lang.c (find_methods): Use objfile_msymbols.
7982         (info_selectors_command, info_classes_command): Likewise.
7983         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7984         * objfiles.h (class objfile_msymbols): New.
7985         (ALL_OBJFILE_MSYMBOLS): Remove.
7986         (ALL_MSYMBOLS): Remove.
7987
7988 2019-01-09  Tom Tromey  <tom@tromey.com>
7989
7990         * common/next-iterator.h (next_adapter): Add Iterator template
7991         parameter.
7992         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7993         (class all_objfiles_safe): New.
7994         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7995         * objfiles.c (put_objfile_before): Update comment.
7996         (add_separate_debug_objfile): Likewise.
7997         (free_all_objfiles): Use all_objfiles_safe.
7998         (objfile_purge_solibs): Likewise.
7999
8000 2019-01-09  Tom Tromey  <tom@tromey.com>
8001
8002         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8003         (expand_symtab_containing_pc, lookup_static_symbol)
8004         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8005         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8006         all_objfiles.
8007         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8008         * breakpoint.c (create_overlay_event_breakpoint)
8009         (create_longjmp_master_breakpoint)
8010         (create_std_terminate_master_breakpoint)
8011         (create_exception_master_breakpoint): Use all_objfiles.
8012         * linux-thread-db.c (try_thread_db_load_from_pdir)
8013         (has_libpthread): Use all_objfiles.
8014         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8015         * linespec.c (iterate_over_all_matching_symtabs)
8016         (search_minsyms_for_name): Use all_objfiles.
8017         * maint.c (maintenance_info_sections): Use all_objfiles.
8018         * main.c (captured_main_1): Use all_objfiles.
8019         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8020         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8021         * guile/scm-pretty-print.c
8022         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8023         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8024         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8025         (maintenance_print_msymbols): Use all_objfiles.
8026         * source.c (select_source_symtab): Use all_objfiles.
8027         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8028         * symfile.c (remove_symbol_file_command)
8029         (expand_symtabs_matching, map_symbol_filenames): Use
8030         all_objfiles.
8031         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8032         all_objfiles.
8033         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8034         * objc-lang.c (find_methods): Use all_objfiles.
8035         * objfiles.c (have_partial_symbols, have_full_symbols)
8036         (have_minimal_symbols, qsort_cmp)
8037         (default_iterate_over_objfiles_in_search_order): Use
8038         all_objfiles.
8039         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8040         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8041         (maintenance_check_psymtabs): Use all_objfiles.
8042         (ALL_PSYMTABS): Remove.
8043         * compile/compile-object-run.c (do_module_cleanup): Use
8044         all_objfiles.
8045         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8046         * cp-support.c (add_symbol_overload_list_qualified): Use
8047         all_objfiles.
8048         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8049         Use all_objfiles.
8050         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8051         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8052         all_objfiles.
8053         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8054         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8055         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8056         Uses all_objfiles.
8057         * solib.c (solib_read_symbols): Use all_objfiles
8058
8059 2019-01-09  Tom Tromey  <tom@tromey.com>
8060
8061         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8062         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8063         all_objfiles.
8064         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8065         * symmisc.c (print_symbol_bcache_statistics)
8066         (print_objfile_statistics, maintenance_print_objfiles)
8067         (maintenance_info_symtabs, maintenance_check_symtabs)
8068         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8069         all_objfiles.
8070         * source.c (forget_cached_source_info): Use all_objfiles.
8071         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8072         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8073         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8074         * objfiles.c (update_section_map): Use all_objfiles.
8075         (shared_objfile_contains_address_p): Likewise.
8076         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8077         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8078
8079 2019-01-09  Tom Tromey  <tom@tromey.com>
8080
8081         * common/next-iterator.h: New file.
8082         * objfiles.h (class all_objfiles): New.
8083         (struct objfile_iterator): New.
8084
8085 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8086
8087         * NEWS: Move the description of the changed "frame", "select-frame",
8088          and "info frame" commands to the Changed commands section.
8089
8090 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8091
8092         * gdbtypes.c (check_stub_method_group): Remove handling of old
8093         mangling schemes.
8094         * linespec.c (find_methods): Likewise.
8095         * stabsread.c (read_member_functions): Likewise.
8096         * valops.c (search_struct_method): Likewise.
8097         (value_struct_elt_for_reference): Likewise.
8098         * NEWS: Mention this change.
8099
8100 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8101
8102         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8103         print_source_lines.
8104         * source.c (print_source_lines_base): Update line number check.
8105         (print_source_lines): New function.
8106         (source_lines_range::source_lines_range): New function.
8107         * source.h (class source_lines_range): New class.
8108         (print_source_lines): New declaration.
8109
8110 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8111
8112         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8113
8114 2019-01-08  Tom Tromey  <tom@tromey.com>
8115             Simon Marchi  <simon.marchi@ericsson.com>
8116
8117         PR gdb/24060
8118         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8119         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8120         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8121         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8122         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8123         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8124
8125 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8126
8127         * source.c (select_source_symtab): Move header comment to
8128         declaration in source.h.
8129         (forget_cached_source_info_for_objfile): Likewise.
8130         (forget_cached_source_info): Likewise.
8131         (identify_source_line): Likewise.
8132         * source.h (identify_source_line): Move declaration from symtab.h
8133         and add comment from source.c
8134         (print_source_lines): Likewise.
8135         (forget_cached_source_info_for_objfile): Likewise.
8136         (forget_cached_source_info): Likewise.
8137         (select_source_symtab): Likewise.
8138         (enum print_source_lines_flag): Move definition from symtab.h.
8139         * symtab.h (identify_source_line): Move declaration to source.h.
8140         (print_source_lines): Likewise.
8141         (forget_cached_source_info_for_objfile): Likewise.
8142         (forget_cached_source_info): Likewise.
8143         (select_source_symtab): Likewise.
8144         (enum print_source_lines_flag): Move definition to source.h.
8145         * tui/tui-hooks.c: Add 'source.h' include.
8146
8147 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8148
8149         * source.c (print_source_lines_base): Handle requests to print
8150         reverse line number sequences, and guard against empty lines
8151         string.
8152
8153 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8154
8155         * source.c (print_source_lines_base): Fix skip of '\r' if next
8156         character is '\n'.
8157
8158 2019-01-06  Tom Tromey  <tom@tromey.com>
8159
8160         * c-exp.y (struct c_parse_state) <macro_original_text,
8161         expansion_obstack>: New member.
8162         (macro_original_text, expansion_obstack): Remove globals.
8163         (scan_macro_expansion, scanning_macro_expansion)
8164         (finished_macro_expansion): Update.
8165         (scan_macro_cleanup): Remove.
8166         (yylex, c_parse): Update.
8167
8168 2019-01-06  Tom Tromey  <tom@tromey.com>
8169
8170         * c-exp.y (struct c_parse_state) <strings>: New member.
8171         (operator_stoken): Update.
8172
8173 2019-01-06  Tom Tromey  <tom@tromey.com>
8174
8175         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8176         (union type_stack_elt) <typelist_val>: Now a pointer to
8177         std::vector.
8178         (type_stack_cleanup): Don't declare.
8179         (push_typelist): Update.
8180         * parse.c (pop_typelist): Return a std::vector.
8181         (push_typelist): Take a std::vector.
8182         (follow_types): Update.  Do not free args.
8183         (type_stack_cleanup): Remove.
8184         * c-exp.y (struct c_parse_state): New.
8185         (cpstate): New global.
8186         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8187         (nonempty_typelist): Update.
8188         (func_mod): Create a new vector.
8189         (c_parse): Create a c_parse_state.
8190         (check_parameter_typelist): Do not delete params.
8191         (function_method): Update.  Do not delete type_list.
8192
8193 2019-01-06  Tom Tromey  <tom@tromey.com>
8194
8195         PR gdb/28155:
8196         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8197         check_typedef.
8198         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8199         (print_return_value): Likewise.
8200
8201 2019-01-05  Tom Tromey  <tom@tromey.com>
8202
8203         * contrib/cleanup_check.py: Remove.
8204         * contrib/gcc-with-excheck: Remove.
8205         * contrib/exsummary.py: Remove.
8206         * contrib/excheck.py: Remove.
8207
8208 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8209
8210         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8211         NULL. Initialize tpprev to NULL instead of assigning it
8212         to NULL on the next statement.
8213         * windows-nat.c (windows_delete_thread): Remove check for
8214         main_thread_id before printing thread exit notifications.
8215         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8216         Remove thread ID check against main_thread_id.
8217         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8218         windows_delete_thread.
8219         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8220
8221 2019-01-04  Tom Tromey  <tom@tromey.com>
8222
8223         * compile/compile.c (_initialize_compile): Use upper case for
8224         metasyntactic variables.
8225         * symmisc.c (_initialize_symmisc): Use upper case for
8226         metasyntactic variables.
8227         * psymtab.c (_initialize_psymtab): Use upper case for
8228         metasyntactic variables.
8229         * demangle.c (demangle_command): Use upper case for metasyntactic
8230         variables.
8231         (_initialize_demangler): Likewise.
8232         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8233         variables.
8234
8235 2019-01-03  Tom Tromey  <tom@tromey.com>
8236
8237         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8238
8239 2019-01-03  Tom Tromey  <tom@tromey.com>
8240
8241         * python/py-symtab.c (salpy_str): Update.
8242         (struct salpy_sal_object) <symtab>: Now a PyObject.
8243         (salpy_dealloc): Update.
8244         (del_objfile_sal): Use gdbpy_ref.
8245
8246 2019-01-03  Tom Tromey  <tom@tromey.com>
8247
8248         * python/py-type.c (convert_field): Use new_reference.  Return
8249         gdbpy_ref.
8250         (make_fielditem): Return gdbpy_ref.
8251         (typy_fields): Update.
8252         (typy_getitem): Update.
8253         (field_name): Return gdbpy_ref.  Use new_reference.
8254         (typy_iterator_iternext): Update.
8255
8256 2019-01-03  Tom Tromey  <tom@tromey.com>
8257
8258         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8259
8260 2019-01-03  Tom Tromey  <tom@tromey.com>
8261
8262         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8263         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8264         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8265         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8266         (pspy_set_type_printers): Likewise.
8267         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8268         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8269         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8270         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8271         (objfpy_set_type_printers): Likewise.
8272
8273 2019-01-03  Tom Tromey  <tom@tromey.com>
8274
8275         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8276         (gdbpy_print_stack): Use gdbpy_err_fetch.
8277         * python/python-internal.h (class gdbpy_err_fetch): New class.
8278         (class gdbpy_enter) <m_error_type, m_error_value,
8279         m_error_traceback>: Remove.
8280         <m_error>: New member.
8281         (gdbpy_exception_to_string): Don't declare.
8282         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8283         * python/py-value.c (convert_value_from_python): Use
8284         gdbpy_err_fetch.
8285         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8286         gdbpy_exception_to_string.
8287         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8288         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8289         gdbpy_err_fetch.
8290
8291 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8292
8293         * linux-nat.c (delete_lwp_cleanup): Delete.
8294         (struct lwp_deleter): New struct.
8295         (lwp_info_up): New typedef.
8296         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8297         lwp_info_up.
8298
8299 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8300
8301         * linux-fork.c (class scoped_switch_fork_info): New class.
8302         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8303
8304 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * valops.c (find_overload_match): Remove use of null_cleanup, and
8307         calls to do_cleanups.
8308
8309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * compile/compile-cplus-types.c
8312         (compile_cplus_instance::decl_name): Handle changes to
8313         cp_func_name.
8314         * cp-support.c (cp_func_name): Update header comment, update
8315         return type.
8316         * cp-support.h (cp_func_name): Update return type in declaration.
8317         * valops.c (find_overload_match): Move temp_func local to top
8318         level of function and change its type.  Use temp_func to hold and
8319         delete temporary string obtained from cp_func_name.
8320
8321 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8322
8323         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8324         gdb::char_vector, remove cleanup, and update uses of `msg`.
8325
8326 2019-01-03  Jim Wilson  <jimw@sifive.com>
8327
8328         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8329
8330 2019-01-02  Tom Tromey  <tom@tromey.com>
8331
8332         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8333         (tdesc_parse_xml): Remove cleanups.
8334         * target-descriptions.h (make_cleanup_free_target_description):
8335         Don't declare.
8336         (target_desc_deleter): New struct.
8337         (target_desc_up): New typedef.
8338         * target-descriptions.c (target_desc_deleter::operator()): Rename
8339         from free_target_description.
8340         (make_cleanup_free_target_description): Remove.
8341
8342 2019-01-02  Tom Tromey  <tom@tromey.com>
8343
8344         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8345         constructor, destructor.
8346         (linespec_parser): Remove typedef.
8347         (~linespec_parser): Rename from linespec_parser_delete.
8348         (linespec_lex_to_end, linespec_complete_label)
8349         (linespec_complete): Update.
8350         (decode_line_full): Remove cleanups.
8351         (decode_line_1): Update.
8352
8353 2019-01-02  Tom Tromey  <tom@tromey.com>
8354
8355         * python/python-internal.h (inferior_to_inferior_object): Change
8356         return type.
8357         * python/py-exitedevent.c (create_exited_event_object): Update.
8358         * python/py-inferior.c (inferior_to_inferior_object): Return
8359         gdbpy_ref.
8360         (python_new_inferior, python_inferior_deleted)
8361         (thread_to_thread_object, delete_thread_object)
8362         (build_inferior_list, gdbpy_selected_inferior): Update.
8363         * python/py-infthread.c (create_thread_object): Update.  Also fail
8364         if inferior_to_inferior_object fails.
8365
8366 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8367
8368         * inferior.h (class inferior) <displaced_step_state>: New field.
8369         * infrun.h (struct displaced_step_state): Move here from
8370         infrun.c.  Initialize fields, add constructor.
8371         <inf>: Remove field.
8372         <reset>: New method.
8373         * infrun.c (struct displaced_step_inferior_state): Move to
8374         infrun.h.
8375         (displaced_step_inferior_states): Remove.
8376         (get_displaced_stepping_state): Adust.
8377         (displaced_step_in_progress_any_inferior): Adjust.
8378         (displaced_step_in_progress_thread): Adjust.
8379         (displaced_step_in_progress): Adjust.
8380         (add_displaced_stepping_state): Remove.
8381         (get_displaced_step_closure_by_addr): Adjust.
8382         (remove_displaced_stepping_state): Remove.
8383         (infrun_inferior_exit): Call displaced_step_state.reset.
8384         (use_displaced_stepping): Don't check for NULL.
8385         (displaced_step_prepare_throw): Call
8386         get_displaced_stepping_state.
8387         (displaced_step_fixup): Don't check for NULL.
8388         (prepare_for_detach): Don't check for NULL.
8389
8390 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8391
8392         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8393          in case of call that did not complete.
8394
8395 2019-01-02  Andrey Utkin  <autkin@undo.io>
8396
8397         * symfile.c (find_separate_debug_file): Fix search of debug files for
8398         remote debuggee.
8399
8400 2019-01-02  Tom Tromey  <tom@tromey.com>
8401
8402         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8403         indentation.
8404         * python/py-frame.c (frapy_older): Remove cast.
8405         (frapy_newer): Likewise.
8406         * python/py-breakpoint.c (local_setattro): Remove cast.
8407         * python/py-arch.c (archpy_name): Remove local variable.
8408         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8409
8410 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8411
8412         * unittests/basic_string_view/element_access/char/empty.cc:
8413         Fix year range in copyright header.
8414
8415 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8416
8417         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8418         Delete.
8419         <operator==>: Update with for removed field.
8420         <hash>: Likewise.
8421         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8422         <isa_features>: ...this.
8423         <abi_features>: New field.
8424         (riscv_isa_flen): Update comment.
8425         (riscv_abi_xlen): New declaration.
8426         (riscv_abi_flen): New declaration.
8427         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8428         isa_features.
8429         (riscv_abi_xlen): New function.
8430         (riscv_isa_flen): Update to get answer from isa_features.
8431         (riscv_abi_flen): New function.
8432         (riscv_has_fp_abi): Update to get answer from abi_features.
8433         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8434         xlen and flen.
8435         (riscv_call_info) <xlen, flen>: Update comment.
8436         (riscv_call_arg_struct): Remove invalid assertions
8437         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8438         is removed.
8439         (riscv_gdbarch_init): Gather isa features and abi features
8440         separately, ensure both match on the gdbarch when reusing an old
8441         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8442         a target with 64-bit float hardware.
8443
8444 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8445
8446         * source.c (search_command_helper): Stop reverse search
8447         when line 1 has been searched.
8448
8449 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8450
8451         * record-full.c (record_full_base_target::close): Rewrite
8452         record_full_core_buf_list free logic.
8453
8454 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8455
8456         * break-catch-syscall.c (print_one_catch_syscall): xfree
8457         the last text.
8458
8459 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8460
8461         * top.c (print_gdb_version): Update Copyright year in version
8462         message.
8463
8464 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8465
8466         Update copyright year range in all GDB files.
8467
8468 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8469
8470         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8471
8472 For older changes see ChangeLog-2018.
8473 \f
8474 Local Variables:
8475 mode: change-log
8476 left-margin: 8
8477 fill-column: 74
8478 version-control: never
8479 coding: utf-8
8480 End:
8481