gdb/ChangeLog

   1 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * main.c (get_init_files): Change to use std::string.
   4         (captured_main_1): Update.
   5         (print_gdb_help): Update.
   6
   7 2019-09-11  Ali Tamur  <tamur@google.com>
   8
   9         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
  10         implementation.
  11
  12 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * dbxread.c (read_dbx_symtab): Update.
  15         * dwarf2read.c (load_partial_dies): Update.
  16         * mdebugread.c (parse_partial_symbols): Update.
  17         (handle_psymbol_enumerators): Update.
  18         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
  19         * psymtab.c (add_psymbol_to_bcache): Likewise.
  20         (add_psymbol_to_list): Likewise.
  21         * symtab.c (symbol_set_names): Likewise.
  22         * symtab.h (symbol_set_names): Likewise.
  23         * xcoffread.c (scan_xcoff_symtab): Update.
  24
  25 2019-09-11  Tom Tromey  <tom@tromey.com>
  26
  27         * symfile-mem.c (symbol_file_add_from_memory): Use
  28         bfd_set_filename.
  29         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
  30         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
  31
  32 2019-09-10  Tom Tromey  <tromey@adacore.com>
  33
  34         * dwarf-index-write.c (write_psymbols): Extend error message.
  35         (debug_names::insert): Add Ada code.
  36         (debug_names::write_psymbols): Remove Ada check.
  37         (debug_names) <m_string_obstack>: New member.
  38         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
  39         (gdb_index_symbol_name_matcher::matches): Remove.
  40         (mapped_index_base::find_name_components_bounds): Add "lang"
  41         parameter.
  42         (mapped_index_base::build_name_components): Also split names
  43         according to Ada syntax.
  44         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
  45         type of "match_callback".
  46         (check_match, check_find_bounds_finds)
  47         (dw2_expand_symtabs_matching): Update.
  48         (dw2_debug_names_iterator): Add new constructor.
  49         (dw2_debug_names_map_matching_symbols): New function.
  50         (dw2_debug_names_expand_symtabs_matching): Update.
  51         (dwarf2_debug_names_functions): Use
  52         dw2_debug_names_map_matching_symbols.
  53
  54 2019-09-10  Tom Tromey  <tromey@adacore.com>
  55
  56         * dwarf2read.c (dw2_get_file_names_reader): Add the
  57         CU's file name to the results.
  58
  59 2019-09-10  Tom Tromey  <tromey@adacore.com>
  60
  61         * ada-lang.c (add_nonlocal_symbols): Combine calls to
  62         map_matching_symbols.  Update.
  63         * dwarf2read.c (dw2_map_matching_symbols): Update.
  64         * psymtab.c (match_partial_symbol): Change type; update.
  65         (psym_map_matching_symbols): Likewise.
  66         * symfile-debug.c (debug_qf_map_matching_symbols): Change
  67         type; update.
  68         * symfile.h (struct quick_symbol_functions)
  69         <map_matching_symbols>: Change "name" to be a lookup_name_info.
  70         Remove "match".
  71
  72 2019-09-10  Tom Tromey  <tromey@adacore.com>
  73
  74         * psymtab.c (map_block): Remove.
  75         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
  76         * symtab.c (iterate_over_symbols_terminated): New function.
  77         * symtab.c (iterate_over_symbols_terminated): Declare.
  78
  79 2019-09-10  Tom Tromey  <tromey@adacore.com>
  80
  81         * ada-lang.c (ada_iterate_over_symbols): Return bool.
  82         * language.h (struct language_defn) <la_iterate_over_symbols>:
  83         Return bool.
  84         * symtab.c (iterate_over_symbols): Return bool.
  85         * symtab.h (iterate_over_symbols): Return bool.
  86
  87 2019-09-10  Tom Tromey  <tromey@adacore.com>
  88
  89         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  90         (add_nonlocal_symbols): Update.
  91         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  92         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  93         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  94         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  95         Change type of "callback".  Remove "data".
  96
  97
  98 2019-09-09  Ali Tamur  <tamur@google.com>
  99
 100         * dwarf2read.c (comp_unit_head): Update comment.
 101         (dwarf2_dwo_name): New function declaration.
 102         (dwarf_unit_type_name): New function declaration.
 103         (read_comp_unit_head): Add support for new compilation units,
 104         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 105         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 106         (currently named as "signature") in their header. Also clarify error
 107         messages.
 108         (lookup_dwo_id): New function. Returns the dwo id of the given
 109         compile unit.
 110         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 111         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 112         functions.
 113         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 114         (dwarf2_dwo_name): Get the dwo name if present.
 115         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 116         purposes.
 117
 118 2019-09-09  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 121
 122 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 123
 124         * python/python.c (do_start_initialization): Make progname_copy static,
 125         to avoid a leak report.
 126
 127 2019-09-08  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 130
 131 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 132
 133         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 134         Change type to gdb::optional<block_enum>.
 135         (dw2_symtab_iter_init): Change block_index parameter type
 136         to gdb::optional<block_enum>.
 137         (dw2_lookup_symbol): Change block_index parameter
 138         type to block_enum.c
 139         (dw2_debug_names_lookup_symbol): Likewise.
 140         * psymtab.c (psym_lookup_symbol): Likewise.
 141         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 142         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 143         Likewise.
 144
 145 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 146
 147         * defs.h (relocate_gdb_directory): Change int to bool in
 148         signature and rename flag to relocatable.
 149         * main.c (relocate_path): Likewise.
 150         (relocate_gdb_directory): Likewise.
 151
 152 2019-09-06  Alan Modra  <amodra@gmail.com>
 153
 154         * coffread.c (coff_symfile_read): Constify filename variable.
 155         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 156         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 157         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 158         * solib.c (reload_shared_libraries_1): Likewise.
 159         * symfile.c (reread_symbols): Likewise.
 160         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 161         * solib-darwin.c (darwin_bfd_open): Likewise.
 162         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 163
 164 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 167         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 168
 169 2019-09-03  Tom Tromey  <tromey@adacore.com>
 170
 171         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 172         types.
 173         (has_negatives): Unbias a range type bound.
 174         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 175         * gdbtypes.c (operator==): Handle new field.
 176         (create_range_type): Add "bias" parameter.
 177         (create_static_range_type, resolve_dynamic_range): Update.
 178         * gdbtypes.h (struct range_bounds) <bias>: New member.
 179         (create_range_type): Add bias parameter.
 180         * printcmd.c (print_scalar_formatted): Unbias range types.
 181         * value.c (unpack_long): Unbias range types.
 182         (pack_long): Bias range types.
 183
 184 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 185
 186         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 187         probe arguments.
 188
 189 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 190
 191         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 192         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 193         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 194         (compile_probe_arg): Likewise.
 195         * probe.h (get_argument_count): Likewise.
 196         * solib-svr4.c (solib_event_probe_action): Likewise.
 197         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 198
 199 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 200
 201         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 202         code to here...
 203         (svr4_create_solib_event_breakpoints): ...from here.
 204
 205 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 206
 207         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 208         suffix from warning message.
 209
 210 2019-08-30  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-winsource.h (struct tui_source_window_base)
 213         <refresh_all>: Don't declare.
 214         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 215         Remove.
 216         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 217         tui_show_locator_content.
 218         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 219         declare.
 220         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 221         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 222         declare.
 223
 224 2019-08-30  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 227
 228 2019-08-30  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 231         Remove unnecessary forward declarations.
 232
 233 2019-08-30  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 236         rerender.
 237         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 238         tui_show_locator_content.
 239
 240 2019-08-30  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 243         (tui_locator_window::rerender): Rewrite using body of previous
 244         tui_show_locator_content.
 245
 246 2019-08-30  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 249         set_locator_fullname>: New methods.
 250         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 251         Rename from tui_set_locator_fullname.
 252         (tui_locator_window::set_locator_info): Rename from
 253         tui_set_locator_info.  Return bool.
 254         (tui_update_locator_fullname, tui_show_frame_info): Update.
 255
 256 2019-08-30  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 259
 260 2019-08-30  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 263         call touchwin.
 264
 265 2019-08-30  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-wingeneral.c (box_win): Assume win_info and
 268         win_info->handle cannot be NULL.
 269
 270 2019-08-30  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 273         refresh_window>: Declare.
 274         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 275         resize.
 276         (tui_data_item_window::rerender): Rename from
 277         tui_display_register.
 278         (tui_data_item_window::refresh_window): New method.
 279         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 280         no-op.
 281
 282 2019-08-30  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 285         regs_column_count, current_group>: Move later.  Now private.
 286         <get_current_group>: New method.
 287         * tui/tui-regs.c (tui_reg_command): Update.
 288         * tui/tui-layout.c (tui_set_layout): Update.
 289
 290 2019-08-30  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 293         (tui_data_window::rerender): Don't call
 294         check_and_display_highlight_if_needed.
 295         (tui_data_window::refresh_all): Remove call to
 296         erase_data_content.
 297
 298 2019-08-30  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 301         (tui_data_window::display_registers_from)
 302         (tui_data_window::display_reg_element_at_line)
 303         (tui_data_window::display_registers_from_line): Remove checks of
 304         "empty".
 305
 306 2019-08-30  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 309         Don't declare.
 310         * tui/tui-regs.c (tui_data_window::show_registers): Call
 311         rerender.
 312         (tui_data_window::rerender): Rename from display_all_data.
 313         (tui_data_window::rerender): Remove old implementation.
 314
 315 2019-08-30  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 318         text.
 319         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 320
 321 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 322             Sergio Durigan Junior  <sergiodj@redhat.com>
 323
 324         PR win32/24284
 325         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 326
 327 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 330         when searching for types.
 331
 332 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 333
 334         * f-lang.c (f_language_defn): Use f_print_typedef.
 335         * f-lang.h (f_print_typedef): Declare.
 336         * f-typeprint.c (f_print_typedef): Define.
 337
 338 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 339
 340         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 341
 342 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * cli/cli-utils.c (info_print_options_defs): Delete.
 345         (make_info_print_options_def_group): Delete.
 346         (extract_info_print_options): Delete.
 347         (info_print_command_completer): Delete.
 348         (info_print_args_help): Add extra parameter, and optionally
 349         include text about -n flag.
 350         * cli/cli-utils.h (struct info_print_options): Delete.
 351         (extract_info_print_options): Delete declaration.
 352         (info_print_command_completer): Delete declaration.
 353         (info_print_args_help): Add extra parameter, extend header
 354         comment.
 355         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 356         search_symbols.
 357         * stack.c (struct info_print_options): New type.
 358         (info_print_options_defs): New file scoped variable.
 359         (make_info_print_options_def_group): New static function.
 360         (info_print_command_completer): New static function.
 361         (info_locals_command): Update to use new local functions.
 362         (info_args_command): Likewise.
 363         (_initialize_stack): Add extra parameter to calls to
 364         info_print_args_help.
 365         * symtab.c (search_symbols): Add extra parameter, use this to
 366         possibly excluse non-debug symbols.
 367         (symtab_symbol_info): Add extra parameter, which is passed on to
 368         search_symbols.
 369         (struct info_print_options): New type.
 370         (info_print_options_defs): New file scoped variable.
 371         (make_info_print_options_def_group): New static function.
 372         (info_print_command_completer): New static function.
 373         (info_variables_command): Update to use local functions, and pass
 374         extra parameter through to symtab_symbol_info.
 375         (info_functions_command): Likewise.
 376         (info_types_command): Pass additional argument through to
 377         symtab_symbol_info.
 378         (rbreak_command): Pass extra argument to search_symbols.
 379         (_initialize_symtab): Add extra arguments for calls to
 380         info_print_args_help, and update help text for 'info variables',
 381         'whereis', and 'info functions' commands.
 382         * symtab.h (search_symbols): Add extra argument to declaration.
 383         * NEWS: Mention new flags.
 384
 385 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 386
 387         * symtab.c (lookup_static_symbol): Call the new function (and move
 388         it down to be next to lookup_global_symbol).
 389         (struct global_sym_lookup_data): Add block_enum member and rename to...
 390         (struct global_or_static_sym_lookup_data): ...this.
 391         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 392         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 393         (lookup_symbol_global_or_static_iterator_cb): ...this.
 394         (lookup_global_or_static_symbol): New function.
 395         (lookup_global_symbol): Call new function.
 396
 397 2019-08-26  Tom de Vries  <tdevries@suse.de>
 398
 399         PR c++/24852
 400         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 401         when pc_probe.prob == NULL.
 402
 403 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 404
 405         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 406         variable symbol_linkage to symbol_linkage_.
 407
 408 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 409
 410         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 411         represent whether the symbol is static, dynamic, or we don't
 412         know.
 413
 414 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 415
 416         * gdb/rx-tdep.c (rx_register_names): New.
 417         (rx_register_name): Delete.
 418         (rx_psw_type): Delete.
 419         (rx_fpsw_type): Delete.
 420         (rx_register_type): Delete.
 421         (rx_gdbarch_init): Convert target-descriptions.
 422         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 423         * gdb/features/Makefile: Add rx.xml.
 424         * gdb/features/rx.xml: New.
 425         * gdb/features/rx.c: Generated.
 426         * gdb/NEWS: Mention target description support.
 427
 428 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 431         *slot_ptr.
 432
 433 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 434
 435         * configure.ac: Don't check for 'dlfcn.h' (moved to
 436         gdbsupport/common.m4).
 437         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 438         'gdbsupport/'.
 439         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 440         * compile/compile-c-support.c: Include
 441         'gdbsupport/gdb-dlfcn.h'.
 442         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 443         * gdb-dlfcn.c: Move to...
 444         * gdbsupport/gdb-dlfcn.c: ... here.
 445         * gdb-dlfcn.h: Move to...
 446         * gdbsupport/gdb-dlfcn.h: ... here.
 447
 448 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 449
 450         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 451         the offset field signed.
 452
 453 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 454
 455         * python/lib/gdb/__init__.py (_execute_file): New function.
 456         * python/python.c (python_run_simple_file): Call gdb._execute_file
 457         on Windows.
 458
 459 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 462         all uses as this was never set to anything but a zero value.
 463
 464 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 465
 466         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 467
 468 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 469
 470         * tui/tui-data.h (tui_gen_win_info): Add an =default
 471         move constructor, required by some GCC versions.
 472
 473 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 474
 475         * go32-nat.c (go32_sysinfo): Add hygon_p.
 476
 477 2019-08-20  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 480         line_from_reg_element_no, first_reg_element_no_inline,
 481         display_all_data, delete_data_content_windows,
 482         erase_data_content>: Now private.
 483
 484 2019-08-20  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 487         (tui_unhighlight_win, tui_highlight_win)
 488         (tui_win_info::make_window): Update.
 489         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 490
 491 2019-08-20  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 494         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 495         (MAX_PID_WIDTH): Move to tui-stack.c.
 496         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 497         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 498         (MAX_PID_WIDTH): Move from tui-data.h.
 499
 500 2019-08-20  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 503         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 504         (box_win): Update.
 505         (tui_gen_win_info::make_window): Rename from tui_make_window.
 506         (tui_win_info::make_window): New method.
 507         (tui_gen_win_info::make_visible): Update.
 508         * tui/tui-source.c (tui_source_window::set_contents): Update.
 509         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 510         (tui_data_window::display_registers_from): Update.
 511         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 512         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 513         Declare.
 514         <can_box>: Remove.
 515         <title>: Remove.
 516         (struct tui_win_info) <make_window>: Declare.
 517         <can_box>: Now virtual.
 518         <title>: New member.
 519         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 520         * tui/tui-command.c (tui_cmd_window::resize): Update.
 521
 522 2019-08-20  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 525         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 526         (tui_data_window::check_register_values): Update.
 527
 528 2019-08-20  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-regs.h (struct tui_data_window): Use
 531         DISABLE_COPY_AND_ASSIGN.
 532         <regs_content>: Change type, removing unique_ptr.
 533         <tui_data_window>: Add move constructor.
 534         * tui/tui-regs.c (tui_data_window::show_registers)
 535         (tui_data_window::show_register_group)
 536         (tui_data_window::display_registers_from)
 537         (tui_data_window::display_registers_from)
 538         (tui_data_window::first_data_item_displayed)
 539         (tui_data_window::delete_data_content_windows)
 540         (tui_data_window::rerender, tui_data_window::refresh_window)
 541         (tui_data_window::check_register_values): Update.
 542
 543 2019-08-20  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 546         show_register_group>: Declare.
 547         (tui_show_register_group): Don't declare.
 548         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 549         tui_show_registers.
 550         (tui_data_window::show_register_group): Rename from
 551         tui_show_register_group.
 552         (tui_data_window::check_register_values, tui_reg_command):
 553         Update.
 554         * tui/tui-layout.c (tui_set_layout): Update.
 555
 556 2019-08-20  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 559         Declare.
 560         (tui_check_register_values): Don't declare.
 561         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 562         from tui_check_register_values.
 563         * tui/tui-hooks.c (tui_register_changed): Update.
 564
 565 2019-08-20  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-regs.c (tui_reg_layout): Move later.
 568         (tui_show_registers): Don't enable TUI mode or change layout.
 569
 570 2019-08-20  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-regs.h (struct tui_data_item_window)
 573         <~tui_data_item_window>: Remove.
 574         <content>: Now a unique_xmalloc_ptr.
 575         * tui/tui-regs.c (tui_register_format): Return a
 576         unique_xmalloc_ptr.
 577         (tui_get_register): Update.
 578         (~tui_data_item_window): Remove.
 579         (tui_data_window::display_registers_from, tui_display_register):
 580         Update.
 581         * tui/tui-io.h (tui_expand_tabs): Update.
 582         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 583         Remove "col" parameter.
 584
 585 2019-08-20  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 588         field.
 589         * tui/tui-regs.c (~tui_data_item_window): Update.
 590
 591 2019-08-20  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 594         earlier.
 595
 596 2019-08-20  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 599
 600 2019-08-20  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-source.h (struct tui_source_window): Update.
 603         * tui/tui-regs.c (tui_show_registers): Update.
 604         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 605         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 606         (NO_REGS_STRING): Remove defines.
 607
 608 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 609
 610         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 611         unnecessary thread walk if remote doesn't support the packet.
 612
 613 2019-08-19  Tom Tromey  <tromey@adacore.com>
 614
 615         * python/py-value.c (value_has_field): Fix indentation.
 616
 617 2019-08-19  Tom Tromey  <tromey@adacore.com>
 618
 619         * printcmd.c (do_one_display, info_display_command): Update.
 620         * block.h (contained_in): Return bool.  Add allow_nested
 621         parameter.
 622         * block.c (contained_in): Return bool.  Add allow_nested
 623         parameter.
 624
 625 2019-08-19  Tom Tromey  <tom@tromey.com>
 626
 627         * configure: Rebuild.
 628         * configure.ac: Disallow the combination of -static-libstdc++ and
 629         source highlight.
 630         * source-cache.c (get_language_name): Handle rust.
 631         (source_cache::get_source_lines): Ignore highlighting exceptions.
 632
 633 2019-08-16  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 636         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 637         (struct tui_source_window_base) <make_visible, refresh_window,
 638         resize>: Remove methods.
 639         <execution_info>: Remove field.
 640         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 641         (tui_show_source_line, tui_source_window_base)
 642         (~tui_source_window_base): Update.
 643         (tui_source_window_base::resize)
 644         (tui_source_window_base::make_visible)
 645         (tui_source_window_base::refresh_window): Remove.
 646         (tui_source_window_base::update_exec_info): Update.
 647         * tui/tui-source.c (tui_source_window::set_contents): Update.
 648         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 649
 650 2019-08-16  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 653         deprecated_query_hook.
 654
 655 2019-08-16  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 658         (tui_update_source_windows_with_line): Update.
 659         * tui/tui-source.h (struct tui_source_window)
 660         <show_symtab_source>: Declare.
 661         (tui_show_symtab_source): Don't declare.
 662         * tui/tui-source.c (tui_show_symtab_source): Rename from
 663         tui_show_symtab_source.
 664
 665 2019-08-16  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-winsource.h (struct tui_source_window_base)
 668         <set_contents>: Declare.
 669         * tui/tui-winsource.c
 670         (tui_source_window_base::update_source_window_as_is): Update.
 671         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 672         Declare.
 673         (tui_set_source_content): Don't declare.
 674         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 675         tui_set_source_content.
 676         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 677         Declare.
 678         (tui_set_disassem_content): Don't declare.
 679         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 680         tui_set_disassem_content.
 681
 682 2019-08-16  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-winsource.h (struct tui_source_window_base)
 685         <update_breakpoint_info>: Declare.
 686         (tui_update_breakpoint_info): Don't declare.
 687         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 688         (tui_update_all_breakpoint_info): Update.
 689         (tui_source_window_base::update_breakpoint_info): Rename from
 690         tui_update_breakpoint_info.
 691         (tui_source_window_base::update_exec_info): Update.
 692
 693 2019-08-16  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-winsource.h (struct tui_source_window_base)
 696         <update_source_window>: Declare.
 697         (tui_update_source_window): Don't declare.
 698         * tui/tui-winsource.c
 699         (tui_source_window_base::update_source_window): Rename from
 700         tui_update_source_window.
 701         (tui_source_window_base::rerender): Update.
 702         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 703         * tui/tui-disasm.c (tui_show_disassem)
 704         (tui_show_disassem_and_update_source)
 705         (tui_disasm_window::maybe_update): Update.
 706
 707 2019-08-16  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-winsource.h (struct tui_source_window_base)
 710         <update_source_window_as_is>: Declare.
 711         (tui_update_source_window_as_is): Don't declare.
 712         * tui/tui-winsource.c (tui_update_source_window): Update
 713         (tui_source_window_base::update_source_window_as_is): Rename from
 714         tui_update_source_window_as_is.
 715         (tui_source_window_base::refill): Update.
 716         * tui/tui-source.c (tui_show_symtab_source): Update.
 717         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 718         Update.
 719
 720 2019-08-16  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-winsource.h (tui_update_source_window)
 723         (tui_update_source_window_as_is): Remove "noerror" parameter.
 724         * tui/tui-winsource.c (tui_update_source_window)
 725         (tui_update_source_window_as_is): Remove "noerror" parameter.
 726         (tui_update_source_windows_with_addr)
 727         (tui_update_source_windows_with_line)
 728         (tui_source_window_base::rerender)
 729         (tui_source_window_base::refill): Update.
 730         * tui/tui-source.h (tui_set_source_content)
 731         (tui_show_symtab_source): Remove "noerror" parameter.
 732         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 733         parameter.
 734         (tui_show_symtab_source): Likewise.
 735         (tui_source_window::maybe_update): Update.
 736         * tui/tui-disasm.c (tui_show_disassem)
 737         (tui_show_disassem_and_update_source)
 738         (tui_disasm_window::do_scroll_vertical)
 739         (tui_disasm_window::maybe_update): Update.
 740
 741 2019-08-16  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui.c (tui_is_window_visible): Update.
 744         * tui/tui-wingeneral.c (tui_make_window)
 745         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 746         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 747         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 748         (tui_set_win_height_command, parse_scrolling_args): Update.
 749         * tui/tui-source.c (tui_source_window::style_changed): Update.
 750         * tui/tui-regs.c (tui_show_registers)
 751         (tui_data_window::first_data_item_displayed)
 752         (tui_data_window::delete_data_content_windows)
 753         (tui_check_register_values, tui_reg_command): Update.
 754         * tui/tui-disasm.c (tui_show_disassem): Update.
 755         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 756         method.
 757         <is_visible>: Remove field.
 758         * tui/tui-data.c (tui_next_win, tui_prev_win)
 759         (tui_delete_invisible_windows): Update.
 760
 761 2019-08-16  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-winsource.h (struct tui_source_window_base)
 764         <m_has_locator>: Remove.
 765         * tui/tui-layout.c (show_source_disasm_command, show_data)
 766         (show_source_or_disasm_and_command): Update.
 767
 768 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 769
 770         * NEWS (Other MI changes): New subsection.
 771         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 772         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 773         * arch-utils.c (default_get_pc_address_flags): New function.
 774         * arch-utils.h (default_get_pc_address_flags): New declaration.
 775         * gdbarch.sh: Add get_pc_address_flags.
 776         * gdbarch.c: Regenerate.
 777         * gdbarch.h: Likewise.
 778         * stack.c (print_pc): New function.
 779         (print_frame_info) (print_frame): Call print_pc.
 780
 781 2019-08-16  Tom de Vries  <tdevries@suse.de>
 782
 783         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 784         print_objfile_section_info.
 785
 786 2019-08-15  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 789         calling update_cmdwin_start_line.
 790         * tui/tui-winsource.h (struct tui_source_window_base)
 791         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 792         <rerender>: Declare.
 793         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 794         Call rerender.
 795         (tui_source_window_base::set_new_height): Remove.
 796         (tui_source_window_base::rerender): Rename from
 797         do_make_visible_with_new_height.
 798         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 799         resize method.
 800         (tui_win_info::make_invisible_and_set_new_height)
 801         (tui_win_info::make_visible_with_new_height): Remove.
 802         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 803         Declare.
 804         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 805         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 806         do_make_visible_with_new_height>: Don't declare.
 807         <rerender>: Declare.
 808         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 809         set_new_height.
 810         (tui_data_window::do_make_visible_with_new_height): Remove.
 811         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 812         call tui_show_locator_content.
 813         (tui_gen_win_info::resize): Call rerender.
 814         (show_source_or_disasm_and_command): Don't call
 815         tui_show_locator_content.
 816         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 817         method.
 818         (struct tui_win_info) <rerender>: Declare.
 819         <set_new_height, make_invisible_and_set_new_height,
 820         make_visible_with_new_height>: Don't declare.
 821         * tui/tui-data.c (tui_win_list::rerender): New method.
 822         * tui/tui-command.h (struct tui_cmd_window)
 823         <do_make_visible_with_new_height>: Don't declare.
 824         * tui/tui-command.c
 825         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 826
 827 2019-08-15  Tom Tromey  <tromey@adacore.com>
 828
 829         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 830         * ada-lang.c (ada_enum_name): Likewise.
 831
 832 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 833
 834         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 835         leading underscore.
 836         (GdbOutputErrorFile): Likewise.
 837         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 838         accordingly.
 839         (execute_unwinders): Rename to have a leading underscore.
 840         (auto_load_packages): Likewise.
 841         (global scope): Adjust call to auto_load_packages accordingly.
 842         (GdbSetPythonDirectory): Likewise.
 843         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 844         instead of execute_unwinders.
 845
 846 2019-08-15  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 849         (show_data): Don't change window visibility.
 850         (tui_gen_win_info::resize): Remove special case for command
 851         window.  Use wresize, when available.
 852         (show_source_or_disasm_and_command): Don't change window
 853         visibility.
 854         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 855         <make_visible>: New method.
 856         * tui/tui-command.c (tui_cmd_window::resize): New method.
 857
 858 2019-08-15  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 861         (struct tui_source_windows): New.
 862         * tui/tui-winsource.c (tui_display_main): Update.
 863         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 864         (new_height_ok, parse_scrolling_args): Update.
 865         * tui/tui-layout.c (show_layout, show_data): Update.
 866         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 867         (tui_add_to_source_windows): Don't declare.
 868         * tui/tui-data.c (source_windows, tui_source_windows)
 869         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 870
 871 2019-08-15  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 874         Rename from reset.
 875         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 876         * tui/tui-layout.c (show_source_disasm_command, show_data):
 877         Update.
 878         (tui_gen_win_info::resize): Rename.
 879         (show_source_or_disasm_and_command): Update.
 880         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 881         reset.
 882
 883 2019-08-15  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 886         * tui/tui-interp.c (tui_interp::init): Don't call
 887         tui_initialize_static_data.
 888         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 889
 890 2019-08-15  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 893         examine tui_win_list.
 894
 895 2019-08-15  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 898         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 899         tui_clear_source_content.
 900         (tui_clear_source_content): Remove.
 901         (tui_source_window_base::do_erase_source_content): Hoist call to
 902         content.clear().
 903         * tui/tui-stack.c (tui_show_frame_info): Don't call
 904         tui_clear_source_content.
 905
 906 2019-08-15  Tom Tromey  <tom@tromey.com>
 907
 908         * tui/tui-winsource.h (struct tui_source_window_base)
 909         <do_erase_source_content>: New method.
 910         <erase_source_content>: New method.
 911         (tui_erase_source_content): Don't declare.
 912         * tui/tui-winsource.c (tui_clear_source_content): Update.
 913         (tui_source_window_base::do_erase_source_content): Rename from
 914         tui_erase_source_content.
 915         (tui_source_window_base::show_source_content): Update.
 916         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 917         * tui/tui-source.h (struct tui_source_window)
 918         <erase_source_content>: New method.
 919         * tui/tui-disasm.h (struct tui_disasm_window)
 920         <erase_source_content>: New method.
 921
 922 2019-08-15  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 925         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 926         constructor.
 927         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 928         * tui/tui-source.c (tui_set_source_content): Update.
 929         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 930
 931 2019-08-15  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 934         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 935         tui-source.c.
 936         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 937         Declare.
 938         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 939         method.
 940         (tui_source_window::maybe_update): Update.
 941
 942 2019-08-15  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 945         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 946         tui-disasm.c.
 947         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 948         Declare.
 949         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 950         method.
 951         (tui_disasm_window::maybe_update): Update.
 952
 953 2019-08-15  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-winsource.h (struct tui_source_window_base)
 956         <maybe_update>: Declare.
 957         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 958         method.
 959         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 960         Declare.
 961         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 962         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 963         Declare.
 964         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 965
 966 2019-08-15  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 969
 970 2019-08-15  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-wingeneral.c: Include tui-stack.h.
 973         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 974         (struct tui_locator_window): Move from tui-data.h.
 975         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 976         (tui_initialize_static_data): Move from tui-data.c.
 977         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 978         (struct tui_locator_window): Move to tui-stack.c.
 979         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 980         (tui_initialize_static_data): Move to tui-stack.c.
 981
 982 2019-08-15  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-layout.c (show_source_disasm_command)
 985         (show_source_or_disasm_and_command): Use make_visible method, not
 986         tui_make_window.
 987         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 988         Remove.
 989
 990 2019-08-15  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-wingeneral.h (tui_make_window): Update.
 993         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 994         parameter.
 995         (tui_gen_win_info::make_visible): Update.
 996         * tui/tui-regs.c (tui_data_window::display_registers_from):
 997         Update.
 998         * tui/tui-layout.c (show_source_disasm_command)
 999         (show_source_or_disasm_and_command): Update.
1000         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1001         (enum tui_box): Remove.
1002         (struct tui_win_info) <can_box>: New method.
1003         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1004         method.
1005
1006 2019-08-15  Tom de Vries  <tdevries@suse.de>
1007
1008         * linux-nat-trad.c: Include gdbarch.h.
1009
1010 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1011
1012         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1013         register sizes.
1014
1015 2019-08-14  Tom Tromey  <tromey@adacore.com>
1016
1017         * darwin-nat.c: Include gdbarch.h.
1018         * darwin-nat-info.c: Include gdbarch.h.
1019
1020 2019-08-13  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1023         Remove.
1024         * tui/tui-data.c (tui_initialize_static_data): Update.
1025
1026 2019-08-13  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-winsource.h (struct tui_exec_info_window)
1029         <~tui_exec_info_window, maybe_allocate_content, get_content,
1030         m_content>: Remove.
1031         (struct tui_source_window_base) <set_exec_info_content,
1032         show_exec_info_content>: Don't declare.
1033         * tui/tui-winsource.c
1034         (tui_exec_info_window::maybe_allocate_content): Remove.
1035         (tui_source_window_base::update_exec_info): Rename from
1036         set_exec_info_content.
1037         (tui_source_window_base::show_exec_info_content)
1038         (tui_source_window_base::update_exec_info): Remove.
1039
1040 2019-08-13  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1043         declare.
1044         * tui/tui-winsource.c (tui_update_source_window_as_is)
1045         (tui_update_source_windows_with_addr, tui_erase_source_content):
1046         Update.
1047         (tui_clear_exec_info_content): Remove.
1048
1049 2019-08-13  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1052         declare.
1053         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1054         call tui_erase_exec_info_content.
1055         (tui_clear_exec_info_content): Rename from
1056         tui_erase_exec_info_content.
1057         (tui_clear_exec_info_content): Delete.
1058
1059 2019-08-13  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-winsource.h (struct tui_source_window_base)
1062         <show_exec_info_content>: Declare.
1063         (tui_show_exec_info_content): Don't declare.
1064         * tui/tui-winsource.c
1065         (tui_source_window_base::show_exec_info_content): Rename from
1066         tui_show_exec_info_content.
1067         (tui_source_window_base::update_exec_info): Update.
1068
1069 2019-08-13  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1072         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1073         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1074         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1075         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1076         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1077         ... here.
1078
1079 2019-08-13  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-winsource.h (struct tui_source_window_base)
1082         <update_exec_info>: Declare.
1083         (tui_update_exec_info): Don't declare.
1084         * tui/tui-winsource.c (tui_update_source_window_as_is)
1085         (tui_source_window_base::refresh_all)
1086         (tui_update_all_breakpoint_info): Update.
1087         (tui_source_window_base::update_exec_info): Rename from
1088         tui_update_exec_info.
1089         * tui/tui-stack.c (tui_show_frame_info): Update.
1090
1091 2019-08-13  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-winsource.h (struct tui_source_window_base)
1094         <set_exec_info_content>: Declare.
1095         (tui_set_exec_info_content): Don't declare.
1096         * tui/tui-winsource.c
1097         (tui_source_window_base::set_exec_info_content): Rename from
1098         tui_set_exec_info_content.
1099         (tui_update_exec_info): Update.
1100
1101 2019-08-13  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-winsource.h (struct tui_source_window_base)
1104         <show_source_content>: Declare.
1105         (tui_show_source_content): Don't declare.
1106         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1107         (tui_source_window_base::show_source_content): Rename from
1108         tui_show_source_content.
1109         (tui_source_window_base::refresh_all): Update.
1110         * tui/tui-layout.c (show_source_disasm_command)
1111         (show_source_or_disasm_and_command): Update.
1112
1113 2019-08-13  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-winsource.c (tui_erase_source_content)
1116         (tui_show_source_content, tui_source_window_base::refresh_all):
1117         Update.
1118         * tui/tui-wingeneral.h
1119         (tui_check_and_display_highlight_if_needed): Don't declare.
1120         * tui/tui-wingeneral.c
1121         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1122         check_and_display_highlight_if_needed.
1123         * tui/tui-win.c (tui_rehighlight_all)
1124         (tui_win_info::make_visible_with_new_height): Update.
1125         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1126         (tui_data_window::erase_data_content)
1127         (tui_data_window::display_all_data): Update.
1128         * tui/tui-data.h (struct tui_win_info)
1129         <check_and_display_highlight_if_needed>: Declare.
1130
1131 2019-08-13  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-win.c (tui_resize_all): Call
1134         tui_delete_invisible_windows.
1135         * tui/tui-layout.c (show_layout): Call
1136         tui_delete_invisible_windows.
1137         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1138         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1139
1140 2019-08-13  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1143         tui_add_win_to_layout.
1144
1145 2019-08-13  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1148         * tui/tui-layout.c (tui_default_win_height): Now static.
1149
1150 2019-08-13  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1153         single switch.
1154         (show_source_disasm_command, show_source_or_disasm_and_command):
1155         Don't check current layout.
1156
1157 2019-08-13  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-wingeneral.c (make_all_visible): Remove.
1160         (tui_make_all_invisible): Simplify.
1161         * tui/tui-layout.c (tui_make_all_invisible): Move from
1162         tui-wingeneral.c; simplify.
1163         (show_layout): Hoist call to tui_make_all_invisible.
1164         (show_data): Don't call tui_make_all_invisible.
1165
1166 2019-08-13  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1169         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1170
1171 2019-08-13  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1174         tui-data.c.
1175         (show_source_disasm_command, show_data)
1176         (show_source_or_disasm_and_command): Don't use
1177         tui_set_current_layout_to.
1178         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1179         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1180         tui-layout.c.
1181         (tui_set_current_layout_to): Remove.
1182
1183 2019-08-13  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-layout.c (tui_set_layout): Update.
1186         * tui/tui-data.h (struct tui_layout_def): Remove.
1187         (tui_layout_def): Don't declare.
1188         * tui/tui-data.c (layout_def): Remove.
1189         (tui_layout_def): Remove.
1190
1191 2019-08-13  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-winsource.h (struct tui_source_window_base)
1194         <clear_detail>: No longer "override".
1195         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1196         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1197         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1198         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1199         Remove.
1200         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1201
1202 2019-08-13  Tom Tromey  <tromey@adacore.com>
1203
1204         * tracepoint.c: Don't include readline.h or history.h.
1205
1206 2019-08-12  Tom Tromey  <tom@tromey.com>
1207
1208         * configure: Rebuild.
1209         * configure.ac: Check for readline 7.
1210         * NEWS: Mention readline 7 requirement.
1211         * README: Update.
1212
1213 2019-08-12  Tom Tromey  <tom@tromey.com>
1214
1215         * mingw-hdep.c (gdb_select): Remove readline hack.
1216
1217 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1218
1219         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1220         when the function fails.
1221
1222 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1223
1224         * s390-tdep.c (s390_type_align): New function.
1225         (s390_gdbarch_init): Set it as type_align gdbarch method.
1226
1227 2019-08-09  Tom de Vries  <tdevries@suse.de>
1228
1229         PR gdb/24591
1230         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1231         pc_low with relocation offset.
1232
1233 2019-08-07  Tom Tromey  <tromey@adacore.com>
1234
1235         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1236         (print_frame_args): Update.
1237         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1238         Update.
1239         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1240         * frame.h (struct frame_arg): Add initializers.
1241         <error>: Now a unique_xmalloc_ptr.
1242
1243 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1244
1245         * NEWS: Expand the Pointer Authentication entry.
1246         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1247         (aarch64_frame_unmask_lr): ... to this.
1248         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1249         Call aarch64_frame_unmask_lr.
1250         * frame.c (struct frame_info): Add "masked" variable.
1251         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1252         (fprint_frame): Check for masked pc.
1253         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1254         declarations.
1255         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1256         * stack.c (print_frame): Check for masked pc.
1257
1258 2019-08-06  Tom Tromey  <tom@tromey.com>
1259
1260         * stabsread.c (patch_block_stabs, read_one_struct_field)
1261         (read_enum_type): Use obstack_strndup.
1262         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1263         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1264         * dwarf2read.c (guess_full_die_structure_name)
1265         (anonymous_struct_prefix): Use obstack_strndup.
1266         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1267         * c-exp.y (yylex): Use obstack_strndup.
1268         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1269         (write_var_or_type): Use obstack_strndup.
1270
1271 2019-08-06  Tom Tromey  <tom@tromey.com>
1272
1273         * symfile.c (reread_symbols): Use obstack_strdup.
1274         * stabsread.c (read_type): Use obstack_strdup.
1275         * gdb_obstack.h (obstack_strdup): New overload.
1276         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1277         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1278         (dwarf2_canonicalize_name): Use obstack_strdup.
1279         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1280         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1281         Use obstack_strdup.
1282
1283 2019-08-06  Tom Tromey  <tom@tromey.com>
1284
1285         * gdb_obstack.h (obstack_strdup): Define.
1286         * gdb_obstack.c (obstack_strdup): Don't define.
1287
1288 2019-08-06  Tom Tromey  <tom@tromey.com>
1289
1290         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1291         obstack_strdup.
1292         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1293         obstack_strdup.
1294         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1295         * stabsread.c (common_block_start): Use obstack_strdup.
1296         * objfiles.c (set_objfile_main_name, objfile): Use
1297         obstack_strdup.
1298         * namespace.c (add_using_directive): Use obstack_strdup.
1299         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1300         * jit.c (finalize_symtab): Use obstack_strdup.
1301         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1302         (guess_partial_die_structure_name, partial_die_info::fixup)
1303         (dwarf2_name): Use obstack_strdup.
1304         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1305         obstack_strdup.
1306         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1307         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1308         obstack_strdup.
1309         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1310
1311 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1312
1313         * unittests/help-doc-selftests.c: New file.
1314         * Makefile.in: Add the new file.
1315
1316 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1317
1318         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1319         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1320         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1321         the trailing '.' is not output, and the first character is uppercased.
1322         (print_help_for_command): Update call to print_doc_line.
1323         (print_doc_of_command): Likewise.
1324         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1325         * cli/cli-option.c (append_indented_doc): Do not append newline.
1326         (build_help_option): Append newline after first appended_indented_doc
1327         only if a second call is done.
1328         (build_help): Append 2 new lines before each option, except the first
1329         one.
1330         * compile/compile.c (_initialize_compile): Add new lines after
1331         %OPTIONS%, when not at the end of the help.
1332         Change help doc or code
1333         producing the help doc to respect the invariants.
1334         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1335         Also removed the new line after 'Options:', as all other commands
1336         do not put an empty line between 'Options:' and the first option.
1337         * printcmd.c (_initialize_printcmd): Likewise.
1338         * stack.c (_initialize_stack): Likewise.
1339         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1340         incorrectly telling COMMAND is optional.
1341         * ada-lang.c (_initialize_ada_language): Change help doc or code
1342         producing the help doc to respect the invariants.
1343         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1344         * breakpoint.c (_initialize_breakpoint): Likewise.
1345         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1346         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1347         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1348         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1349         _initialize_cli_style): Likewise.
1350         * corelow.c (core_target_info): Likewise.
1351         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1352         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1353         * filesystem.c (_initialize_filesystem): Likewise.
1354         * frame.c (_initialize_frame): Likewise.
1355         * gnu-nat.c (add_task_commands): Likewise.
1356         * infcall.c (_initialize_infcall): Likewise.
1357         * infcmd.c (_initialize_infcmd): Likewise.
1358         * interps.c (_initialize_interpreter): Likewise.
1359         * language.c (_initialize_language): Likewise.
1360         * linux-fork.c (_initialize_linux_fork): Likewise.
1361         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1362         * maint.c (_initialize_maint_cmds): Likewise.
1363         * memattr.c (_initialize_mem): Likewise.
1364         * printcmd.c (_initialize_printcmd): Likewise.
1365         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1366         _RegEx): Likewise.
1367         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1368         * record-btrace.c (_initialize_record_btrace): Likewise.
1369         * record-full.c (_initialize_record_full): Likewise.
1370         * record.c (_initialize_record): Likewise.
1371         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1372         * regcache.c (_initialize_regcache): Likewise.
1373         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1374         _initialize_remote): Likewise.
1375         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1376         * serial.c (_initialize_serial): Likewise.
1377         * skip.c (_initialize_step_skip): Likewise.
1378         * source.c (_initialize_source): Likewise.
1379         * stack.c (_initialize_stack): Likewise.
1380         * symfile.c (_initialize_symfile): Likewise.
1381         * symtab.c (_initialize_symtab): Likewise.
1382         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1383         * top.c (init_main): Likewise.
1384         * tracefile-tfile.c (tfile_target_info): Likewise.
1385         * tracepoint.c (_initialize_tracepoint): Likewise.
1386         * tui/tui-win.c (_initialize_tui_win): Likewise.
1387         * utils.c (add_internal_problem_command): Likewise.
1388         * valprint.c (value_print_option_defs): Likewise.
1389
1390 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1391
1392         PR build/24886
1393         * configure.ac: Drop enable-libmcheck support.
1394         * configure, config.in: Rebuild.
1395         * libmcheck.m4: Remove.
1396         * acinclude.m4: Don't include it.
1397         * Makefile.in: Don't distribute it.
1398         * top.c (print_gdb_configuration): Don't mention it.
1399
1400 2019-08-06  Tom Tromey  <tom@tromey.com>
1401
1402         * utils.c (set_output_style): Sometimes pass stream to
1403         emit_style_escape.
1404         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1405         * record-btrace.c (btrace_insn_history): Update.
1406         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1407         method.
1408         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1409         Update initializers.
1410         <m_uiout>: New field.
1411         <m_di>: Move lower.
1412         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1413         Remove "uiout" parameter.
1414         (dump_insns): Update.
1415         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1416         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1417
1418 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1419
1420         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1421         (error_in_psymtab_expansion): Likewise.
1422         (lookup_symbol_via_quick_fns): Likewise.
1423         (basic_lookup_transparent_type_quick): Likewise.
1424         (basic_lookup_transparent_type_1): Likewise.
1425
1426 2019-08-06  Tom Tromey  <tromey@adacore.com>
1427
1428         * source.c (last_source_error): Now bool.
1429         (print_source_lines_base): Make "noprint" bool.  Only open
1430         source file when last_source_visited changes.
1431
1432 2019-08-06  Tom Tromey  <tromey@adacore.com>
1433
1434         * annotate.c (annotate_source_line): Use g_source_cache.
1435         * source-cache.c (source_cache::get_plain_source_lines): Change
1436         parameters.  Populate m_offset_cache.
1437         (source_cache::ensure): New method.
1438         (source_cache::get_line_charpos): New method.
1439         (extract_lines): Move lower.  Change parameters.
1440         (source_cache::get_source_lines): Move lower.
1441         * source-cache.h (class source_cache): Update comment.
1442         <get_line_charpos>: New method.
1443         <get_source_lines>: Update comment.
1444         <clear>: Clear m_offset_cache.
1445         <get_plain_source_lines>: Change parameters.
1446         <ensure>: New method
1447         <m_offset_cache>: New member.
1448         * source.c (forget_cached_source_info_for_objfile): Update.
1449         (info_source_command): Use g_source_cache.
1450         (find_source_lines, open_source_file_with_line_charpos): Remove.
1451         (print_source_lines_base, search_command_helper): Use g_source_cache.
1452         * source.h (open_source_file_with_line_charpos): Don't declare.
1453         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1454         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1455         Use g_source_cache.
1456
1457 2019-08-06  Tom Tromey  <tromey@adacore.com>
1458
1459         * source-cache.c (source_cache::get_plain_source_lines):
1460         Remove "first_line" and "last_line" parameters.
1461         (source_cache::get_source_lines): Cache plain text.
1462         * source-cache.h (class source_cache)
1463         <get_plain_source_lines>: Update.
1464
1465 2019-08-06  Tom Tromey  <tromey@adacore.com>
1466
1467         * source-cache.c (extract_lines): No longer a method.
1468         Changed type of parameter.  Include final newline.
1469         (selftests::extract_lines_test): New function.
1470         (_initialize_source_cache): Likewise.
1471         * source-cache.h (class source_cache)
1472         <extract_lines>: Don't declare.
1473
1474 2019-08-06  Tom Tromey  <tromey@adacore.com>
1475
1476         * breakpoint.c (init_breakpoint_sal): Update.
1477         (breakpoint): Update.
1478         * breakpoint.h (struct breakpoint) <filter>: Now a
1479         unique_xmalloc_ptr.
1480
1481 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1482
1483         * NEWS: Mention dictionary access on blocks.
1484         * python/py-block.c (blpy_getitem): New function.
1485         (block_object_as_mapping): New struct.
1486         (block_object_type): Use new struct for tp_as_mapping field.
1487
1488 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1489
1490         * objfiles.h (objfile): Add a comment describing partial symbols.
1491
1492 2019-08-05  Tom Tromey  <tromey@adacore.com>
1493
1494         * compile/compile.c (_initialize_compile): Use _(), not N_().
1495         * thread.c (_initialize_thread): Use _(), not N_().
1496         * stack.c (_initialize_stack): Use _(), not N_().
1497         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1498
1499 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1500
1501         * dwarf2read.c (struct dw2_symtab_iterator):
1502         <want_specific_block>: Remove.
1503         <block_index>: Change type to gdb::optional.
1504         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1505         change type of BLOCK_INDEX parameter to gdb::optional.
1506         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1507         (dw2_lookup_symbol): Don't pass argument for
1508         WANT_SPECIFIC_BLOCK.
1509         (dw2_expand_symtabs_for_function): Don't pass argument for
1510         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1511         (class dw2_debug_names_iterator)
1512         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1513         parameter, change BLOCK_INDEX type to gdb::optional.
1514         <m_want_specific_block>: Remove.
1515         <m_block_index>: Change type to gdb::optional.
1516         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1517         gdb::optional.  Re-write in function of gdb::optional.
1518         (dw2_debug_names_lookup_symbol): Don't pass argument for
1519         WANT_SPECIFIC_BLOCK.
1520         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1521         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1522         BLOCK_INDEX.
1523
1524 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1525
1526         * NEWS: Mention changes to "info sources" command.
1527
1528 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1529
1530         * symtab.c (filename_partial_match_opts): New struct type.
1531         (struct output_source_filename_data): New members
1532         regexp, c_regexp, partial_match.
1533         (output_source_filename): Use new members to decide to print file.
1534         (info_sources_option_defs): New variable.
1535         (make_info_sources_options_def_group, print_info_sources_header,
1536         info_sources_command_completer):
1537         New functions.
1538         (info_sources_command): Read new optional arguments.
1539         (_initialize_symtab): Update info sources help.
1540
1541 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1542
1543         * ada-lang.c (exception_support_info_v0): Renamed from...
1544         (default_exception_support_info): ... this.  Create new
1545         definition for v1.
1546         (ada_has_this_exception_support): Look up catch_handlers_sym.
1547         (ada_exception_support_info_sniffer): Try v0 after default.
1548
1549 2019-08-01  Tom Tromey  <tromey@adacore.com>
1550
1551         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1552         gdbarch.h.
1553
1554 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1555
1556         * s12z-tdep.c: Fix include path for s12z-opc.h.
1557
1558 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1559
1560         * NEWS: Require GNU make 3.82.
1561
1562 2019-07-16  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1565         declare.
1566
1567 2019-07-30  Tom Tromey  <tromey@adacore.com>
1568
1569         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1570
1571 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1572
1573         * printcmd.c (print_address_symbolic): Print negative offsets.
1574         (build_address_symbolic): Force signed arithmetic when computing
1575         offset.
1576
1577 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1578
1579         PR/24474: Add a function to lookup static variables.
1580         * NEWS: Mention this new function.
1581         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1582         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1583         * python/python.c (python_GdbMethods): Add new function.
1584
1585 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1586
1587         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1588         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1589         (objfpy_lookup_static_symbol): New function.
1590         (objfile_object_methods): Add new functions.
1591
1592 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1593
1594         * NEWS: Mention 'set|show print frame-info'.  Mention new
1595         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1596         backtrace argument.  Mention that python frame filtering code
1597         is now consistent with what 'backtrace' command prints.
1598
1599 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1600
1601         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1602         comments.
1603         (print_frame_info_auto, print_frame_info_source_line,
1604         print_frame_info_location, print_frame_info_source_and_location,
1605         print_frame_info_location_and_address, print_frame_info_short_location):
1606         New declarations.
1607         (struct frame_print_options): New member print_frame_info.
1608         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1609         * stack.h (get_user_print_what_frame_info): New declaration.
1610         (frame_show_address): New declaration.
1611         * stack.c (print_frame_arguments_choices): New value 'presence'.
1612         (print_frame_info_auto, print_frame_info_source_line,
1613         print_frame_info_location, print_frame_info_source_and_location,
1614         print_frame_info_location_and_address, print_frame_info_short_location,
1615         print_frame_info_choices, print_frame_info_print_what): New definitions.
1616         (print_frame_args): Only print dots for args if print frame-arguments
1617         is 'presence'.
1618         (frame_print_option_defs): New element for "frame-info".
1619         (get_user_print_what_frame_info): New function.
1620         (frame_show_address): Make non static.  Move comment to stack.h.
1621         (print_frame_info_to_print_what): New function.
1622         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1623         to decide what to print.
1624         (backtrace_command_1): Handle the new print_frame_arguments_presence
1625         value.
1626         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1627         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1628         (py_print_frame): In non-mi mode, use LOCATION as default for
1629         print_what, similarly to frame information printed directly by
1630         backtrace command. Handle frame-info user option in non MI mode.
1631
1632 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1633
1634         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1635         Add case for debugging 32-bit target on 64-bit host.  Revise
1636         comment.
1637
1638 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1639
1640         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1641         instead of find_function_entry_range_from_pc.
1642
1643 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1644
1645         * stack.c (find_frame_funname): Remove code which preferred
1646         minsym over symtab sym in "certain pathological cases".
1647
1648         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1649         parameter.  Change type of "do_demangle" to bool.
1650         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1651         Pass suitable "prefer_sym_over_minsym" flag to
1652         build_address_symbolic().  Don't output "+" for negative offsets.
1653         * printcmd.c (print_address_symbolic): Update invocation of
1654         build_address_symbolic to include a "prefer_sym_over_minsym"
1655         flag.
1656         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1657         Restrict cases in which use of minimal symbol is preferred to that
1658         of a found symbol.  Update comments.
1659
1660         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1661         for entry pc when entry pc is out of range for that FDE.
1662
1663 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1664
1665         PR gdb/24839:
1666         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1667         type.
1668
1669 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1670
1671         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1672         this function's Python signature.
1673
1674
1675 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1676
1677         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1678         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1679         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1680         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1681         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1682
1683
1684 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1685
1686         * h8300-tdep.c (h8300_register_name_common): New.
1687         h8300_register_name): Use h8300_register_name_common.
1688         (h8300s_register_name): Likewise.
1689         (h8300sx_register_name): Likewise.
1690         (h8300h_register_nam): New.
1691         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1692
1693
1694 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1695
1696         * arm-tdep.c (arm_skip_cmse_entry): New function.
1697         (arm_is_sgstubs_section): New function.
1698         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1699
1700 2019-07-22  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1703         Don't self-assign.
1704
1705 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1706
1707         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1708         type_print.
1709
1710 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1713         so that GDB doesn't match any msymbols when searching in the
1714         TYPES_DOMAIN.
1715         (print_symbol_info): Print using typedef_print or type_print based
1716         on the type of the symbol.  Add updated FIXME comment moved from...
1717         (_initialize_symtab): ... move and update FIXME comment to above.
1718
1719 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * NEWS: Mention adding -q option to "info types".
1722         * symtab.c (struct info_types_options): New struct.
1723         (info_types_options_defs): New variable.
1724         (make_info_types_options_def_group): New function.
1725         (info_types_command): Use gdb::option framework to parse options.
1726         (info_types_command_completer): New function.
1727         (_initialize_symtab): Extend the help text on "info types" and
1728         register command completer.
1729
1730 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1731
1732         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1733         (lookup_symbol_in_objfile): Change int to block_enum and add a
1734         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1735
1736 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1737
1738         * MAINTAINERS (Write After Approval): Add self.
1739
1740 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1743         instruction to the dummy code region.
1744
1745 2019-07-19  Tom Tromey  <tromey@adacore.com>
1746
1747         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1748         (ARGSUSED, PARAMS, __func__): Remove rules.
1749
1750 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1751
1752         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1753         * features/arm/arm-with-iwmmxt.c: Remove.
1754         * features/arm/arm-with-iwmmxt.xml: Remove.
1755         * features/arm/arm-with-m-fpa-layout.c: Remove.
1756         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1757         * features/arm/arm-with-m-vfp-d16.c: Remove.
1758         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1759         * features/arm/arm-with-m.c: Remove.
1760         * features/arm/arm-with-m.xml: Remove.
1761         * features/arm/arm-with-neon.c: Remove.
1762         * features/arm/arm-with-neon.xml: Remove.
1763         * features/arm/arm-with-vfpv2.c: Remove.
1764         * features/arm/arm-with-vfpv2.xml: Remove.
1765         * features/arm/arm-with-vfpv3.c: Remove.
1766         * features/arm/arm-with-vfpv3.xml: Remove.
1767
1768 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1769
1770         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1771
1772 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1773
1774         * arch/aarch32.c (aarch32_create_target_description): Create
1775         target descriptions using features.
1776         * arch/arm.c (arm_create_target_description)
1777         (arm_create_mprofile_target_description): Likewise.
1778         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1779
1780 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1781
1782         * Makefile.in: Add new files.
1783         * aarch32-tdep.c: New file.
1784         * aarch32-tdep.h: New file.
1785         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1786         Call aarch32_read_description.
1787         * arch/aarch32.c: New file.
1788         * arch/aarch32.h: New file.
1789         * arch/arm.c (arm_create_target_description)
1790         (arm_create_mprofile_target_description): New function.
1791         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1792         (arm_create_target_description)
1793         (arm_create_mprofile_target_description): New declaration.
1794         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1795         read_description functions.
1796         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1797         Likewise.
1798         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1799         * arm-tdep.c (tdesc_arm_list): New variable.
1800         (arm_register_g_packet_guesses): Call create description functions.
1801         (arm_read_description) (arm_read_mprofile_description): New
1802         function.
1803         * arm-tdep.h (arm_read_description)
1804         (arm_read_mprofile_description): Add declaration.
1805         * configure.tgt: Add new files.
1806
1807 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1808
1809         * top.c (new_ui_command): Open specified terminal just once.
1810
1811 2019-07-18  Tom Tromey  <tromey@adacore.com>
1812
1813         * symtab.c (main_name): Constify return type.
1814         * symfile.c (set_initial_language): Update.
1815         * symtab.h (main_name): Constify return type.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-winsource.c (tui_update_source_window)
1820         (tui_update_source_window_as_is)
1821         (tui_update_source_windows_with_line): Remove return.
1822         * tui/tui-disasm.c (tui_show_disassem)
1823         (tui_show_disassem_and_update_source): Remove return.
1824         * tui/tui.c (tui_reset): Remove return.
1825         * tui/tui-wingeneral.c
1826         (tui_check_and_display_highlight_if_needed): Remove return.
1827
1828 2019-07-17  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1831
1832 2019-07-17  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-winsource.h (struct tui_exec_info_window)
1835         (struct tui_source_window_base): Move from tui-data.h.
1836         * tui/tui-winsource.c: Move many method definitions from
1837         elsewhere.  Remove "structuring" comments.
1838         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1839         (tui_source_window_base::refresh_window): Move to
1840         tui-winsource.c.
1841         * tui/tui-win.c (tui_source_window_base::refresh_all)
1842         (tui_source_window_base::update_tab_width)
1843         (tui_source_window_base::set_new_height)
1844         (tui_source_window_base::do_make_visible_with_new_height): Move to
1845         tui-winsource.c.
1846         * tui/tui-source.h: Update.
1847         * tui/tui-source.c (tui_source_window_base::reset): Move to
1848         tui-winsource.c.
1849         * tui/tui-disasm.h: Update.
1850         * tui/tui-data.h (struct tui_exec_info_window): Move to
1851         tui-winsource.h.
1852         (struct tui_source_window_base): Likewise.
1853         * tui/tui-data.c (tui_source_window_base::clear_detail)
1854         (tui_source_window_base, ~tui_source_window_base): Move to
1855         tui-winsource.c.
1856
1857 2019-07-17  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-win.c (tui_resize_all)
1860         (tui_source_window_base::update_tab_width)
1861         (tui_adjust_win_heights): Update.
1862         (tui_win_info::make_invisible_and_set_new_height): Rename from
1863         make_invisible_and_set_new_height.
1864         * tui/tui-data.h (struct tui_win_info)
1865         <make_invisible_and_set_new_height>: New method.
1866
1867 2019-07-17  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui.c: Update.
1870         * tui/tui-source.h (struct tui_source_window): Move from
1871         tui-data.h.
1872         * tui/tui-layout.c: Update.
1873         * tui/tui-disasm.c: Update.
1874         * tui/tui-data.h (struct tui_source_window): Move to
1875         tui-source.h.
1876
1877 2019-07-17  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1880         tui-data.h.
1881         * tui/tui-data.h (struct tui_disasm_window): Move to
1882         tui-disasm.h.
1883
1884 2019-07-17  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-regs.h (struct tui_data_item_window): Move from
1887         tui-data.h.
1888         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1889         * tui/tui-data.h (struct tui_data_item_window): Move to
1890         tui-regs.h.
1891         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1892
1893 2019-07-17  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui.c: Update.
1896         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1897         (tui_cmd_window::max_height): Move to tui-command.c.
1898         * tui/tui-layout.c: Update.
1899         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1900         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1901         tui-command.c.
1902         * tui/tui-command.h (struct tui_cmd_window): Move from
1903         tui-data.h.
1904         * tui/tui-command.c: Remove "structuring" comments.
1905         (tui_cmd_window::clear_detail)
1906         (tui_cmd_window::do_make_visible_with_new_height)
1907         (tui_cmd_window::max_height): Move from elsewhere.
1908
1909 2019-07-17  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1912         Now static.
1913         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1914         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1915
1916 2019-07-17  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui.c: Update.
1919         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1920         tui-regs.c.
1921         * tui/tui-windata.h: Remove file.
1922         * tui/tui-windata.c: Remove file.
1923         * tui/tui-win.c (tui_data_window::set_new_height)
1924         (tui_data_window::do_make_visible_with_new_height): Move to
1925         tui-regs.c.
1926         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1927         * tui/tui-regs.c: Remove "structuring" comments.
1928         (tui_data_window::first_data_item_displayed)
1929         (tui_data_window::delete_data_content_windows)
1930         (tui_data_window::erase_data_content)
1931         (tui_data_window::display_all_data)
1932         (tui_data_window::refresh_all)
1933         (tui_data_window::do_scroll_vertical)
1934         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1935         (tui_data_window::do_make_visible_with_new_height)
1936         (tui_data_window::refresh_window): Move from elsewhere.
1937         (_initialize_tui_regs): Move to end of file.
1938         * tui/tui-layout.c: Update.
1939         * tui/tui-hooks.c: Update.
1940         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1941         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1942         tui-regs.c.
1943         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1944
1945 2019-07-17  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1948         seen.
1949
1950 2019-07-17  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-win.c (tui_source_window_base::set_new_height)
1953         (tui_source_window_base::do_make_visible_with_new_height): Use
1954         m_has_locator field directly.
1955         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1956         method.
1957         (struct tui_source_window_base) <has_locator>: Likewise.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1962         Don't declare.
1963         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1964         Remove.
1965         * tui/tui-win.c (tui_source_window_base::set_new_height)
1966         (tui_source_window_base::set_new_height)
1967         (make_invisible_and_set_new_height)
1968         (tui_source_window_base::do_make_visible_with_new_height)
1969         (tui_source_window_base::do_make_visible_with_new_height):
1970         Update.
1971         * tui/tui-layout.c (show_source_disasm_command, show_data)
1972         (show_source_or_disasm_and_command): Update.
1973         * tui/tui-layout.c (show_layout): Update.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-layout.c (make_data_window): Remove.
1978         (show_data): Unify creation and re-initialization cases.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-layout.c (make_source_window, make_disasm_window):
1983         Remove.
1984         (show_data): Unify creation and re-initialization cases.
1985
1986 2019-07-17  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-layout.c (make_command_window): Remove.
1989         (show_source_disasm_command, show_source_or_disasm_and_command):
1990         Unify creation and re-initialization cases.
1991
1992 2019-07-17  Tom Tromey  <tom@tromey.com>
1993
1994         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1995         creation and re-initialization cases.
1996
1997 2019-07-17  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-regs.c (tui_get_register): Return void.
2000
2001 2019-07-17  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2004         Simplify.
2005
2006 2019-07-17  Tom Tromey  <tom@tromey.com>
2007
2008         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2009         resetting.
2010
2011 2019-07-17  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2014         * tui/tui-regs.c (tui_reg_layout): New function.
2015         (tui_show_registers, tui_reg_command): Use it.
2016         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2017         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2018         parameters.
2019         (tui_layout_command): Remove.
2020
2021 2019-07-17  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-layout.h (tui/tui-layout): Return void.
2024         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2025
2026 2019-07-17  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-layout.c (show_source_disasm_command, show_data):
2029         Update.
2030         (reset_locator): Remove.
2031         (show_source_or_disasm_and_command): Update.
2032
2033 2019-07-17  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-source.c (tui_source_window_base::reset): Remove
2036         win_type parameter.
2037         * tui/tui-layout.c (make_command_window, make_source_window)
2038         (make_disasm_window, make_data_window)
2039         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2040         (reset_locator, show_source_or_disasm_and_command): Update.
2041         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2042         win_type parameter.
2043         (struct tui_source_window_base) <reset>: Likewise.
2044
2045 2019-07-17  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-layout.c (show_source_disasm_command): Use
2048         reset_locator.
2049         (reset_locator): New function.
2050         (init_and_make_win): Remove.
2051         (show_source_or_disasm_and_command): Use reset_locator.
2052
2053 2019-07-17  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2056         condition.
2057         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2058         Remove condition.
2059         * tui/tui-source.c (tui_source_window_base::reset): New method.
2060         * tui/tui-layout.c (make_command_window): Don't call
2061         init_and_make_win.
2062         (make_source_window, make_disasm_window): Don't call
2063         make_source_or_disasm_window.
2064         (make_data_window): Don't call init_and_make_win.  Change calling
2065         convention.
2066         (show_source_disasm_command, show_data): Simplify.
2067         (make_source_or_disasm_window): Remove.
2068         (show_source_or_disasm_and_command): Simplify.
2069         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2070         (struct tui_source_window_base) <reset>: Likewise.
2071         <execution_info>: Remove initializer.
2072         * tui/tui-data.c (tui_source_window_base): Initialize
2073         execution_info.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2078         variable.
2079
2080 2019-07-17  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui.c (tui_rl_other_window): Update.
2083         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2084         superclass method first.  Always iterate over regs_content.
2085         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2086         method.
2087         * tui/tui-win.c (tui_set_focus_command): Update.
2088
2089 2019-07-17  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-win.c (tui_set_focus_command): Rename from
2092         tui_set_focus.  Call tui_enable.
2093         (tui_set_focus_command): Remove.
2094
2095 2019-07-17  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2098         refresh_window.
2099         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2100         touchwin.
2101         (tui_data_window::refresh_window): Call refresh_window on data
2102         items.  Always call superclass refresh_window.
2103         (tui_win_info::refresh): Remove.
2104         (tui_source_window_base::refresh_window): Update.
2105         (tui_refresh_all): Update.
2106         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2107         refresh_window.
2108         (show_source_or_disasm_and_command): Likewise.
2109         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2110         (struct tui_source_window_base) <refresh>: Likewise.
2111
2112 2019-07-17  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-winsource.c (tui_clear_source_content)
2115         (tui_show_source_content): Update.
2116         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2117         whether content is empty.
2118         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2119         Remove.
2120
2121 2019-07-17  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2124         window's contents.
2125         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2126         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2127
2128 2019-07-17  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2131         (struct tui_data_item_window): Update.
2132
2133 2019-07-17  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2136         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2137         defines.
2138
2139 2019-07-17  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-winsource.h (tui_erase_source_content)
2142         (tui_clear_source_content): Remove "display_prompt" parameter.
2143         * tui/tui-winsource.c (tui_update_source_window_as_is)
2144         (tui_update_source_windows_with_addr): Update.
2145         (tui_clear_source_content): Remove "display_prompt" parameter.
2146         (tui_erase_source_content): Likewise.  Simplify.
2147         (tui_show_source_content): Update.
2148         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2149         * tui/tui-stack.c (tui_show_frame_info): Update.
2150         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2151         Remove defines.
2152
2153 2019-07-17  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2156         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2157         parameter.
2158         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2159         parameter.
2160
2161 2019-07-17  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-winsource.c (tui_clear_source_content)
2164         (tui_show_source_content, tui_show_exec_info_content)
2165         (tui_clear_exec_info_content): Update.
2166         * tui/tui-stack.c (tui_show_locator_content): Update.
2167         (tui_show_frame_info): Update.
2168         * tui/tui-source.h (tui_source_window): Don't declare.
2169         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2170         from tui_source_is_displayed.
2171         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2172         Remove field.
2173         (struct tui_source_window_base) <content_in_use>: New field.  Now
2174         bool.
2175         (struct tui_source_window) <showing_source_p>: New method.
2176         (TUI_SRC_WIN): Change cast.
2177         * tui/tui-data.c (tui_initialize_static_data): Update.
2178
2179 2019-07-17  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2182         location_matches_p.
2183         * tui/tui-source.c (tui_source_window::location_matches_p): New
2184         method.
2185         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2186         method.
2187         * tui/tui-data.h (struct tui_source_window_base)
2188         <location_matches_p>: New method.
2189         (struct tui_source_window, struct tui_disasm_window)
2190         <location_matches_p>: Likewise.
2191
2192 2019-07-17  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-win.c (tui_set_win_height_command): Rename from
2195         tui_set_win_height.
2196         (tui_set_win_height_command): Remove.
2197
2198 2019-07-17  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-source.c (tui_source_window): New constructor.  Add
2201         observer.
2202         (~tui_source_window): New destructor.
2203         (tui_source_window::style_changed): New method.
2204         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2205         (tui_attach_detach_observers): Update.
2206         * tui/tui-data.h (struct tui_source_window): Make constructor not
2207         inline.  Add destructor.
2208         (struct tui_source_window) <style_changed>: New method.
2209         <m_observable>: New member.
2210
2211 2019-07-17  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2214         * tui/tui-win.c (tui_resize_all): Fix typo.
2215
2216 2019-07-17  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2219         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2220         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2221         * tui/tui-win.c (window_name_completer): Use foreach.
2222         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2223         (update_tab_width): Likewise.
2224         * tui/tui-layout.c (show_layout): Update.
2225         * tui/tui-data.h (class tui_window_iterator): New.
2226         (struct all_tui_windows): New.
2227         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2228
2229 2019-07-17  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2232         parameter.  Don't reference globals.
2233         (tui_reg_command): Update.
2234
2235 2019-07-17  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-regs.c (tui_show_registers): Simplify.
2238
2239 2019-07-17  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-regs.c (tui_show_registers): Update.
2242         (tui_show_register_group): Add win_info parameter.
2243
2244 2019-07-17  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2247         Rename from tui_display_reg_element_at_line.
2248         (tui_data_window::display_registers_from_line): Update.
2249         * tui/tui-data.h (struct tui_data_window)
2250         <display_reg_element_at_line>: New method.
2251
2252 2019-07-17  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-regs.h (tui_display_registers_from)
2255         (tui_display_registers_from_line): Don't declare.
2256         * tui/tui-windata.c (tui_data_window::display_all_data)
2257         (tui_data_window::refresh_all)
2258         (tui_data_window::do_scroll_vertical): Update.
2259         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2260         from tui_display_registers_from.
2261         (tui_display_reg_element_at_line): Update.
2262         (tui_data_window::display_registers_from_line): Rename from
2263         tui_display_registers_from_line.
2264         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2265         display_registers_from_line>: New methods.
2266
2267 2019-07-17  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2270         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2271         from tui_erase_data_content.
2272         (tui_data_window::display_all_data)
2273         (tui_data_window::refresh_all)
2274         (tui_data_window::do_scroll_vertical): Update.
2275         * tui/tui-regs.c (tui_show_registers): Update.
2276         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2277         New method.
2278
2279 2019-07-17  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2282         declare.
2283         * tui/tui-windata.c
2284         (tui_data_window::delete_data_content_windows): Rename from
2285         tui_delete_data_content_windows.
2286         (tui_data_window::display_all_data)
2287         (tui_data_window::do_scroll_vertical): Update.
2288         * tui/tui-data.h (struct tui_data_window)
2289         <delete_data_content_windows>: New method.
2290
2291 2019-07-17  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2294         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2295
2296 2019-07-17  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2299         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2300         from tui_display_all_data.
2301         * tui/tui-win.c
2302         (tui_data_window::do_make_visible_with_new_height): Update.
2303         * tui/tui-regs.c (tui_show_registers): Update.
2304         * tui/tui-layout.c (tui_set_layout): Update.
2305         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2306         method.
2307
2308 2019-07-17  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2311         * tui/tui-windata.c (tui_display_data_from): Remove.
2312         (tui_data_window::refresh_all): Update.
2313
2314 2019-07-17  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2317         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2318         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2319         tui_display_registers_from_line.
2320         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2321         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2322         "force_display" parameter.
2323
2324 2019-07-17  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2327         declare.
2328         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2329         Rename from tui_first_reg_element_no_inline.
2330         (tui_display_reg_element_at_line)
2331         (tui_display_registers_from_line): Update.
2332         * tui/tui-data.h (struct tui_data_window)
2333         <first_reg_element_no_inline>: New method.
2334
2335 2019-07-17  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-windata.c (tui_display_data_from)
2338         (tui_data_window::do_scroll_vertical): Update.
2339         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2340         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2341         Rename from tui_line_from_reg_element_no.
2342         (tui_display_registers_from_line): Update.
2343         * tui/tui-data.h (struct tui_data_window)
2344         <line_from_reg_element_no>: New method.
2345
2346 2019-07-17  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2349         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2350         tui_last_regs_line_no.
2351         (tui_display_reg_element_at_line)
2352         (tui_display_registers_from_line): Update.
2353         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2354         method.
2355
2356 2019-07-17  Tom Tromey  <tom@tromey.com>
2357
2358         PR tui/24722:
2359         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2360         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2361         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2362         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2363         (tui_update_breakpoint_info): Likewise.
2364         * tui/tui-hooks.c (tui_event_create_breakpoint)
2365         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2366         Update.
2367
2368 2019-07-17  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2371
2372 2019-07-17  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-winsource.c (tui_update_source_window_as_is)
2375         (tui_update_source_windows_with_addr): Update.
2376         * tui/tui-source.h (tui_set_source_content)
2377         (tui_show_symtab_source): Add "win_info" parameter.
2378         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2379         parameter.
2380         (tui_show_symtab_source): Likewise.
2381
2382 2019-07-17  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-wingeneral.c
2385         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2386
2387 2019-07-17  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2390         (struct tui_cmd_window) <can_scroll>: New method.
2391         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2392         method.
2393
2394 2019-07-17  Tom Tromey  <tromey@adacore.com>
2395
2396         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2397         do_field_signed>: Rename.  Change type of "value".
2398         * ui-out.c (ui_out::field_signed): Rename from field_int.
2399         Change type of "value".
2400         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2401         type of "value".
2402         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2403         do_field_int.  Change type of "value".
2404         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2405         do_field_int.  Change type of "value".
2406         * tracepoint.c (trace_status_mi, tfind_1)
2407         (print_one_static_tracepoint_marker): Update.
2408         * thread.c (print_thread_info_1, print_selected_thread_frame):
2409         Update.
2410         * stack.c (print_frame, print_frame_info): Update.
2411         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2412         Update.
2413         * source.c (print_source_lines_base): Update.
2414         * skip.c (info_skip_command): Update.
2415         * record-btrace.c (btrace_ui_out_decode_error)
2416         (btrace_call_history_src_line): Update.
2417         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2418         Update.
2419         * progspace.c (print_program_space): Update.
2420         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2421         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2422         do_field_int.  Change type of "value".
2423         * mi/mi-out.c (mi_ui_out::do_table_begin)
2424         (mi_ui_out::do_table_header): Update.
2425         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2426         type of "value".
2427         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2428         (mi_cmd_data_list_changed_registers, output_register)
2429         (mi_cmd_data_read_memory, mi_load_progress)
2430         (mi_cmd_trace_frame_collected): Update.
2431         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2432         Update.
2433         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2434         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2435         (mi_cmd_var_list_children, varobj_update_one): Update.
2436         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2437         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2439         * inferior.c (print_inferior): Update.
2440         * gdb_bfd.c (print_one_bfd): Update.
2441         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2442         Update.
2443         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2444         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2445         do_field_int.  Change type of "value".
2446         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2447         do_field_int.  Change type of "value".
2448         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2449         (print_one_breakpoint_location, print_it_catch_fork)
2450         (print_one_catch_fork, print_it_catch_vfork)
2451         (print_one_catch_vfork, print_it_catch_solib)
2452         (print_it_catch_exec, print_it_ranged_breakpoint)
2453         (print_mention_watchpoint, print_mention_masked_watchpoint)
2454         (bkpt_print_it, update_static_tracepoint): Update.
2455         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2456         * break-catch-syscall.c (print_it_catch_syscall): Update.
2457         * ada-tasks.c (print_ada_task_info): Update.
2458         * ada-lang.c (print_it_exception, print_mention_exception):
2459         Update.
2460
2461 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         PR breakpoints/24541
2464         * gdbarch.c: Regenerate.
2465         * gdbarch.h: Regenerate.
2466         * gdbarch.sh: Adjust return type and parameter types for
2467         'stap_adjust_register'.
2468         (i386_stap_adjust_register): Adjust signature and return new
2469         register name.
2470         * stap-probe.c (stap_parse_register_operand): Adjust use of
2471         'gdbarch_stap_adjust_register'.
2472
2473 2019-07-17  Tom Tromey  <tromey@adacore.com>
2474
2475         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2476         declare VEC.
2477         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2478         std::vector.
2479         (struct s390_process_info): Add initializers.
2480         (s390_add_process): Use new.
2481         (s390_linux_nat_target::low_forget_process): Use delete.
2482         (s390_linux_nat_target::low_new_fork)
2483         (s390_linux_nat_target::stopped_by_watchpoint)
2484         (s390_linux_nat_target::low_prepare_to_resume)
2485         (s390_linux_nat_target::insert_watchpoint)
2486         (s390_linux_nat_target::insert_hw_breakpoint)
2487         (s390_linux_nat_target::remove_watchpoint)
2488         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2489
2490 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2491
2492         * aarch64-fbsd-nat.c: Include regcache.h.
2493         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2494         argument.
2495         (aarch64_fbsd_nat_target::fetch_registers)
2496         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2497         variable.
2498         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2499
2500 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2501
2502         * fbsd-nat.c: Include gdbarch.h.
2503
2504 2019-07-15  Tom Tromey  <tromey@adacore.com>
2505
2506         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2507
2508 2019-07-15  Tom Tromey  <tromey@adacore.com>
2509
2510         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2511         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2512         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2513         * cli-out.c (cli_ui_out::do_field_int): New method.
2514         * ui-out.c (ui_out::field_unsigned): New method.
2515         * symfile.c (generic_load): Use field_unsigned.
2516         (print_transfer_performance): Likewise.
2517         * record-btrace.c (ui_out_field_uint): Remove.
2518         (btrace_call_history_insn_range, btrace_call_history): Use
2519         field_unsigned.
2520         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2521         field_unsigned.
2522         * ui-out.h (class ui_out) <field_unsigned>: New method.
2523         <do_field_unsigned>: Likewise.
2524
2525 2019-07-15  Tom Tromey  <tromey@adacore.com>
2526
2527         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2528         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2529         * target.c (flash_erase_command): Use field_string.
2530         * infrun.c (print_signal_received_reason): Use field_string.
2531         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2532         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2533         field_string.
2534         * ada-tasks.c (print_ada_task_info): Use field_string.
2535
2536 2019-07-15  Tom Tromey  <tromey@adacore.com>
2537
2538         * target.c (flash_erase_command): Use field_core_addr.
2539         * symfile.c (generic_load): Use field_core_addr.
2540         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2541         Use field_core_addr.
2542         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2543         field_core_addr.
2544
2545 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2548         value if its desired type is smaller than a CORE_ADDR and signed.
2549
2550 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2551
2552         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2553         of changes to field names, and use new is_reference field to
2554         decide if a property is a reference or not.
2555         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2556         field.
2557         (struct dwarf2_property_baton): Update header comment, rename
2558         'referenced_type' to 'property_type' and update comments.
2559         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2560         default property type, store in property baton, update to take
2561         accound of renamed field.
2562         (read_func_scope): Update call to attr_to_dynamic_prop.
2563         (read_array_type): Likewise.
2564         (dwarf2_per_cu_addr_sized_int_type): New function.
2565         (read_subrange_index_type): Move type finding code to
2566         dwarf2_per_cu_addr_sized_int_type.
2567         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2568         (dwarf2_per_cu_addr_type): New function.
2569         (set_die_type): Update calls to attr_to_dynamic_prop.
2570
2571 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * dwarf2read.c (read_subrange_index_type): New function.
2574         (read_subrange_type): Move code into new function and call it.
2575         * gdbtypes.c (create_range_type): Add some asserts.
2576
2577 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2578
2579         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2580         update return statements.
2581         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2582         declaration, and update comment to match.
2583         * gdbtypes.c (resolve_dynamic_array): Update call to
2584         dwarf2_evaluate_property to match new return type.
2585
2586 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * valarith.c (value_subscripted_rvalue): Change lowerbound
2589         parameter type from int to LONGEST.
2590         * value.h (value_subscripted_rvalue): Likewise in declaration.
2591
2592 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * cli/cli-utils.c (info_print_command_completer): New function.
2595         * cli/cli-utils.h: Add 'completer.h' include, and forward
2596         declaration for 'struct cmd_list_element'.
2597         (info_print_command_completer): Declare.
2598         * stack.c (_initialize_stack): Add completer for 'info locals' and
2599         'info args'.
2600         * symtab.c (_initialize_symtab): Add completer for 'info
2601         variables' and 'info functions'.
2602         * NEWS: Mention completion for additional info commands.
2603
2604 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2605
2606         * cli/cli-utils.c (extract_info_print_args): Delete.
2607         (extract_arg_maybe_quoted): Delete.
2608         (info_print_options_defs): New variable.
2609         (make_info_print_options_def_group): New function.
2610         (extract_info_print_options): Define new function.
2611         * cli/cli-utils.h (extract_info_print_args): Delete.
2612         (struct info_print_options): New structure.
2613         (extract_info_print_options): Declare new function.
2614         * stack.c (info_locals_command): Update to use new
2615         extract_info_print_options, also add a header comment.
2616         (info_args_command): Likewise.
2617         * symtab.c (info_variables_command): Likewise.
2618         (info_functions_command): Likewise.
2619
2620 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2623         to extract string arguments.
2624         * common/common-utils.c (extract_string_maybe_quoted): New function.
2625         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2626
2627 2019-07-11  Tom Tromey  <tromey@adacore.com>
2628
2629         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2630         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2631         * top.h (gdbinit): Don't declare.
2632         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2633         into...
2634         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2635         * top.c (gdb_init): Don't call init_cli_cmds.
2636         (gdbinit): Remove.
2637         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2638
2639 2019-07-11  Tom Tromey  <tromey@adacore.com>
2640
2641         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2642         after it has been moved.
2643
2644 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2645
2646         * valops.c (value_must_coerce_to_target): Change return type to
2647         bool.
2648         * value.h (value_must_coerce_to_target): Likewise.
2649
2650 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2651
2652         * breakpoint.c (is_hardware_watchpoint): Remove
2653         forward-declaration.
2654         (is_masked_watchpoint): Change return type to bool.
2655         (is_tracepoint): Likewise.
2656         (is_breakpoint): Likewise.
2657         (is_hardware_watchpoint): Likewise.
2658         (is_watchpoint): Likewise.
2659         (is_no_memory_software_watchpoint): Likewise.
2660         (is_catchpoint): Likewise.
2661         (breakpoint_1): Make FILTER parameter's return type bool.
2662         is_masked_watchpoint): Change return type to bool.
2663         (save_breakpoints): Make FILTER parameter's return type bool.
2664         * breakpoint.h (is_breakpoint): Change return type to bool.
2665         (is_watchpoint): Likewise.
2666         (is_catchpoint): Likewise.
2667         (is_tracepoint): Likewise.
2668
2669 2019-07-10  Tom Tromey  <tom@tromey.com>
2670
2671         * defs.h: Don't include gdbarch.h.
2672         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2673         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2674         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2675         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2676         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2677         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2678         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2679         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2680         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2681         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2682         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2683         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2684         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2685         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2686         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2687         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2688         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2689         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2690         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2691         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2692         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2693         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2694         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2695         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2696         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2697         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2698         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2699
2700 2019-07-10  Tom Tromey  <tromey@adacore.com>
2701
2702         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2703         * breakpoint.c (init_ada_exception_breakpoint): Register as
2704         bp_catchpoint.
2705         (print_one_breakpoint_location, print_one_breakpoint): Use
2706         is_ada_exception_catchpoint.
2707         * ada-lang.c (class ada_catchpoint_location): Pass
2708         bp_loc_software_breakpoint to bp_location constructor.
2709         (is_ada_exception_catchpoint): New function.
2710
2711 2019-07-10  Tom Tromey  <tromey@adacore.com>
2712
2713         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2714         VEC.
2715         (struct arm_exidx_entry): New method operator<.
2716         (struct arm_exidx_data) <section_maps>: Change type.
2717         (arm_exidx_data_free): Remove.
2718         (arm_exidx_data_key): Change type.  Move lower.
2719         (arm_exidx_new_objfile): Update.
2720         (arm_compare_exidx_entries): Remove.
2721         (arm_find_exidx_entry, _initialize_arm_tdep)
2722
2723 2019-07-10  Tom Tromey  <tromey@adacore.com>
2724
2725         * solib-spu.c (ocl_program_data_key): Change type.
2726         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2727         Update.
2728
2729 2019-07-10  Tom Tromey  <tromey@adacore.com>
2730
2731         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2732         (struct solib_aix_inferior_data) <library_list>: Change type.
2733         (solib_aix_inferior_data_handle): Change type.
2734         (get_solib_aix_inferior_data): Update.
2735         (solib_aix_free_library_list): Remove.
2736         (library_list_start_library): Update.
2737         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2738         return type.
2739         (solib_aix_get_library_list)
2740         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2741         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2742
2743 2019-07-10  Tom Tromey  <tromey@adacore.com>
2744
2745         * solib-dsbt.c (struct dsbt_info): Add initializers.
2746         (solib_dsbt_pspace_data): Change type.
2747         (dsbt_pspace_data_cleanup): Remove.
2748         (get_dsbt_info, _initialize_dsbt_solib): Update.
2749
2750 2019-07-10  Tom Tromey  <tromey@adacore.com>
2751
2752         * spu-tdep.c (spu_overlay_data): Change type.
2753         (spu_get_overlay_table, spu_overlay_new_objfile)
2754         (_initialize_spu_tdep): Update.
2755
2756 2019-07-10  Tom Tromey  <tromey@adacore.com>
2757
2758         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2759         destructor.
2760         (dbx_objfile_data_key): Change type and declare later.
2761         (DBX_SYMFILE_INFO): Rewrite.
2762         * dbxread.c (dbx_objfile_data_key): Change type.
2763         (dbx_symfile_init): Update.
2764         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2765         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2766         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2767
2768 2019-07-10  Tom Tromey  <tromey@adacore.com>
2769
2770         * jit.c (jit_program_space_key): Change type.  Move lower.
2771         (get_jit_program_space_data): Update.
2772         (jit_program_space_data_cleanup): Remove.
2773         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2774         Update.
2775         (struct jit_program_space_data): Add initializers.
2776
2777 2019-07-10  Tom Tromey  <tromey@adacore.com>
2778
2779         * solib-darwin.c (struct darwin_info): Add initializers.
2780         (solib_darwin_pspace_data): Change type.
2781         (darwin_pspace_data_cleanup): Remove.
2782         (get_darwin_info, _initialize_darwin_solib): Update.
2783
2784 2019-07-10  Tom Tromey  <tromey@adacore.com>
2785
2786         * remote-sim.c (struct sim_inferior_data): Add initializers,
2787         constructor, and destructor.
2788         (sim_inferior_data_key): Change type.  Move lower.
2789         (check_for_duplicate_sim_descriptor): Update.
2790         (get_sim_inferior_data): Use new.  Update.
2791         (~sim_inferior_data_cleanup): Rename from
2792         sim_inferior_data_cleanup.  Simplify.
2793         (gdbsim_close_inferior, simulator_command)
2794         (sim_command_completer, _initialize_remote_sim): Update.
2795         (next_pid, INITIAL_PID): Move earlier.
2796
2797 2019-07-10  Tom Tromey  <tromey@adacore.com>
2798
2799         * python/python-internal.h (create_thread_object): Return
2800         gdbpy_ref.
2801         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2802         * python/py-inferior.c (struct threadlist_entry): Add
2803         constructor.
2804         <thread_obj>: Now a gdbpy_ref.
2805         (thread_to_thread_object): Update.
2806         (add_thread_object): Use new.
2807         (delete_thread_object): Use delete.
2808         (infpy_threads): Update.
2809         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2810         GIL.
2811
2812 2019-07-10  Tom Tromey  <tromey@adacore.com>
2813
2814         * valops.c (value_cast): Specialize error message for Ada.
2815
2816 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2817
2818         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2819
2820 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2821
2822         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2823         bpstat_should_step): Return bool, adjust comments.
2824         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2825         bpstat_should_step): Likewise.
2826
2827 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2828
2829         * features/Makefile: Use feature target descriptions for Arm.
2830         * features/arm/arm-core.c: Generate new file.
2831         * features/arm/arm-fpa.c: Likewise.
2832         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2833         * features/arm/arm-m-profile.c: Likewise.
2834         * features/arm/arm-vfpv2.c: Likewise.
2835         * features/arm/arm-vfpv3.c: Likewise.
2836         * features/arm/xscale-iwmmxt.c: Likewise.
2837         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2838
2839 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2840
2841         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2842         ptrace earlier.
2843
2844 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2845
2846         * features/aarch64-pauth.c: Regenerate.
2847
2848 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2849
2850         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2851         bool.
2852         (bpstat_what): Use false instead of 0.
2853
2854 2019-07-09  Pedro Alves  <palves@redhat.com>
2855
2856         * break-catch-throw.c (is_exception_catchpoint): New.
2857         * breakpoint.c (print_one_breakpoint_location): New parameter
2858         'raw_loc'.  Handle it.  Use
2859         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2860         looking at the breakpoint's type.
2861         (print_one_breakpoint): If handling "maint info breakpoints", also
2862         print locations of exception catchpoints.
2863         * breakpoint.h (is_exception_catchpoint): Declare.
2864
2865 2019-07-09  Pedro Alves  <palves@redhat.com>
2866
2867         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2868         "addr" field.
2869         (allocate_location_exception_catchpoint): New.
2870         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2871         (initialize_throw_catchpoint_ops): Install
2872         allocate_location_exception_catchpoint as allocate_location
2873         method.
2874         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2875         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2876         bp_loc_other.
2877         (breakpoint_address_is_meaningful): Delete.
2878         (bl_address_is_meaningful): New.
2879         (breakpoint_locations_match): Adjust comment.
2880         (bp_location_from_bp_type): New, factored out of...
2881         (bp_location::bp_location(breakpoint *)): ... this.
2882         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2883         factored out of...
2884         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2885         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2886         breakpoint_address_is_meaningful.
2887         (bp_locations_compare): Adjust comment.
2888         (update_global_location_list): Use bl_address_is_meaningful
2889         instead of breakpoint_address_is_meaningful.
2890         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2891         explicit.
2892         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2893         * python/py-breakpoint.c (bppy_get_location): No longer check
2894         whether location is null.
2895
2896 2019-07-09  Pedro Alves  <palves@redhat.com>
2897
2898         PR c++/15468
2899         * breakpoint.c (print_one_breakpoint_location): Remove
2900         single-location assert.
2901
2902 2019-07-09  Tom Tromey  <tom@tromey.com>
2903
2904         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2905         * configure: Rebuild.
2906         * configure.ac: Change common to gdbsupport.
2907         * gdbsupport: Rename from common.
2908         * acinclude.m4: Change common to gdbsupport.
2909         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2910         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2911         gdbsupport.
2912         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2913         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2914         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2915         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2916         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2917         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2918         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2919         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2920         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2921         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2922         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2923         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2924         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2925         coff-pe-read.c, command.h, compile/compile-c-support.c,
2926         compile/compile-c.h, compile/compile-cplus-symbols.c,
2927         compile/compile-cplus-types.c, compile/compile-cplus.h,
2928         compile/compile-loc2c.c, compile/compile.c, completer.c,
2929         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2930         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2931         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2932         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2933         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2934         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2935         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2936         features/aarch64-core.c, features/aarch64-fpu.c,
2937         features/aarch64-pauth.c, features/aarch64-sve.c,
2938         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2939         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2940         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2941         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2942         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2943         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2944         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2945         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2946         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2947         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2948         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2949         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2950         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2951         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2952         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2953         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2954         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2955         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2956         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2957         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2958         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2959         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2960         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2961         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2962         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2963         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2964         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2965         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2966         minsyms.c, mips-linux-tdep.c, namespace.h,
2967         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2968         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2969         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2970         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2971         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2972         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2973         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2974         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2975         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2976         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2977         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2978         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2979         procfs.c, producer.c, progspace.h, psymtab.h,
2980         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2981         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2982         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2983         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2984         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2985         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2986         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2987         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2988         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2989         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2990         target-memory.c, target.c, target.h, target/waitstatus.c,
2991         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2992         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2993         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2994         unittests/array-view-selftests.c,
2995         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2996         unittests/common-utils-selftests.c,
2997         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2998         unittests/format_pieces-selftests.c,
2999         unittests/function-view-selftests.c,
3000         unittests/lookup_name_info-selftests.c,
3001         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3002         unittests/mkdir-recursive-selftests.c,
3003         unittests/observable-selftests.c,
3004         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3005         unittests/parse-connection-spec-selftests.c,
3006         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3007         unittests/scoped_fd-selftests.c,
3008         unittests/scoped_mmap-selftests.c,
3009         unittests/scoped_restore-selftests.c,
3010         unittests/string_view-selftests.c, unittests/style-selftests.c,
3011         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3012         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3013         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3014         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3015         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3016         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3017
3018 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3021         bool value.
3022         (decode_digits_ordinary): Set explicit_line field in sal.
3023         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3024         symtab_and_line that was set on an explicit line number in
3025         assembler code.  Do always update the recorded symtab and line if
3026         we do skip the prologue.
3027
3028 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * breakpoint.c (set_breakpoint_location_function): Remove
3031         explicit_loc parameter.
3032         (momentary_breakpoint_from_master): Update call to
3033         set_breakpoint_location_function.
3034         (add_location_to_breakpoint): Likewise.
3035
3036 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3039         required features based on default bfd type when no specific bfd
3040         is present.
3041
3042 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3043
3044         * NEWS: Mention that GDB printf and eval commands can now print
3045         C-style and Ada-style convenience var strings without
3046         calling the inferior.
3047         * printcmd.c (printf_c_string): Locally print GDB internal var
3048         instead of transiting via the inferior.
3049         (printf_wide_c_string): Likewise.
3050
3051 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3052
3053         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3054
3055 2019-07-04  Tom Tromey  <tom@tromey.com>
3056
3057         PR tui/24724:
3058         * tui/tui-winsource.c (tui_clear_source_content): Update.
3059         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3060         (tui_update_breakpoint_info): Update.
3061         (tui_set_exec_info_content): Update.
3062         * tui/tui-source.c (tui_set_source_content_nil): Update.
3063         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3064         has_break.
3065         * tui/tui-data.h (enum tui_bp_flag): New.
3066         (tui_bp_flags): New enum flags type.
3067         (struct tui_source_element) <break_mode>: Change type.  Rename
3068         from has_break.
3069         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3070         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3071         constants.
3072         * tui/tui-winsource.h: Fix comment.
3073
3074 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3075
3076         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3077         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3078         (store_fpregs_to_thread)
3079         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3080         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3081         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3082         (IWMMXT_REGS_SIZE): Add define.
3083         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3084         (fetch_vfp_regs, store_vfp_regs)
3085         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3086         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3087
3088 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3089
3090         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3091         defines.
3092         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3093         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3094         (ARM_INT_REGISTER_SIZE): ...to this.
3095         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3096         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3097         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3098         (arm_linux_collect_gregset, supply_nwfpe_register)
3099         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3100         defines.
3101         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3102         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3103         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3104         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3105         (arm_return_in_memory, arm_store_return_value)
3106         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3107         (arm_record_ld_st_multiple): Likewise.
3108         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3109         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3110
3111 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3112
3113         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3114         AARCH64_DISPLACED_MODIFIED_INSNS.
3115         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3116         (aarch64_displaced_step_copy_insn): Likewise.
3117         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3118         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3119         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3120         ARM_DISPLACED_MODIFIED_INSNS.
3121         * arm-tdep.c (arm_gdbarch_init): Likewise.
3122         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3123         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3124         (struct arm_displaced_step_closure): Use
3125         ARM_DISPLACED_MODIFIED_INSNS.
3126
3127 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3128
3129         * features/Makefile: Remove unused xml files.
3130         * features/aarch64.xml: Remove.
3131         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3132         * features/i386/amd64-avx-avx512.xml: Remove.
3133         * features/i386/amd64-avx-linux.xml: Remove.
3134         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3135         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3136         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3137         * features/i386/amd64-avx-mpx.xml: Remove.
3138         * features/i386/amd64-avx.xml: Remove.
3139         * features/i386/amd64-linux.xml: Remove.
3140         * features/i386/amd64-mpx-linux.xml: Remove.
3141         * features/i386/amd64-mpx.xml: Remove.
3142         * features/i386/amd64.xml: Remove.
3143         * features/i386/i386-avx-avx512-linux.xml: Remove.
3144         * features/i386/i386-avx-avx512.xml: Remove.
3145         * features/i386/i386-avx-linux.xml: Remove.
3146         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3147         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3148         * features/i386/i386-avx-mpx-linux.xml: Remove.
3149         * features/i386/i386-avx-mpx.xml: Remove.
3150         * features/i386/i386-avx.xml: Remove.
3151         * features/i386/i386-linux.xml: Remove.
3152         * features/i386/i386-mmx-linux.xml: Remove.
3153         * features/i386/i386-mmx.xml: Remove.
3154         * features/i386/i386-mpx-linux.xml: Remove.
3155         * features/i386/i386-mpx.xml: Remove.
3156         * features/i386/i386.xml: Remove.
3157         * features/i386/x32-avx-avx512-linux.xml: Remove.
3158         * features/i386/x32-avx-linux.xml: Remove.
3159         * features/i386/x32-linux.xml: Remove.
3160
3161 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3162
3163         * regformats/aarch64.dat: Remove.
3164         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3165         * regformats/i386/amd64-avx-linux.dat: Remove.
3166         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3167         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3168         * regformats/i386/amd64-linux.dat: Remove.
3169         * regformats/i386/amd64-mpx-linux.dat: Remove.
3170         * regformats/i386/amd64.dat: Remove.
3171         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3172         * regformats/i386/i386-avx-linux.dat: Remove.
3173         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3174         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3175         * regformats/i386/i386-linux.dat: Remove.
3176         * regformats/i386/i386-mmx-linux.dat: Remove.
3177         * regformats/i386/i386-mpx-linux.dat: Remove.
3178         * regformats/i386/i386.dat: Remove.
3179         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3180         * regformats/i386/x32-avx-linux.dat: Remove.
3181         * regformats/i386/x32-linux.dat: Remove.
3182
3183 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3184
3185         * aarch64-tdep.c: Remove xml self tests.
3186         * amd64-linux-tdep.c: Likewise.
3187         * amd64-tdep.c: Likewise.
3188         * i386-linux-tdep.c: Likewise.
3189         * i386-tdep.c: Likewise.
3190
3191 2019-07-03  Pedro Alves  <palves@redhat.com>
3192
3193         PR cli/24732
3194         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3195         (pipe_cmd_option_defs): New.
3196         (make_pipe_cmd_options_def_group): New.
3197         (pipe_command): Use gdb::option::process_options.
3198         (pipe_command_completer): New function.
3199         (_initialize_cli_cmds): Install completer for "pipe" command.
3200
3201 2019-07-03  Pedro Alves  <palves@redhat.com>
3202
3203         * cli/cli-option.c (union option_value) <string>: New field.
3204         (struct option_def_and_value): Add ctor, move ctor, dtor and
3205         use DISABLE_COPY_AND_ASSIGN.
3206         (option_def_and_value::clear_value): New.
3207         (parse_option, save_option_value_in_ctx, get_val_type_str)
3208         (add_setshow_cmds_for_options): Handle var_string.
3209         * cli-option.h (union option_def::var_address) <string>: New
3210         field.
3211         (struct string_option_def): New.
3212         * maint-test-options.c (struct test_options_opts): Add default
3213         ctor and use DISABLE_COPY_AND_ASSIGN.
3214         <string_opt>: New field.
3215         (test_options_opts::~test_options_opts): New.
3216         (test_options_opts::dump): Also dump "-string".
3217         (test_options_option_defs): Install "string.
3218
3219 2019-07-03  Pedro Alves  <palves@redhat.com>
3220
3221         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3222         option_value with a null enumeration.
3223         (complete_options): Save the option values in the context.
3224         (save_option_value_in_ctx): New, factored out from ...
3225         (process_options): ... here.
3226         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3227         of the function.
3228         * maint-test-options.c (test_options_opts::dump): New, factored
3229         out from ...
3230         (maintenance_test_options_command_mode): ... here.
3231         (maintenance_test_options_command_completion_result): Delete.
3232         (maintenance_test_options_command_completion_text): Update
3233         comment.
3234         (maintenance_show_test_options_completion_result): Change
3235         prototype.  Just print
3236         maintenance_test_options_command_completion_text.
3237         (save_completion_result): New.
3238         (maintenance_test_options_completer_mode): Pass options context to
3239         complete_options, and then save a dump.
3240         (_initialize_maint_test_options): Use add_cmd to install "maint
3241         show test-options-completion-result".
3242
3243 2019-07-03  Pedro Alves  <palves@redhat.com>
3244
3245         * NEWS (New commands): Mention "with" and "maint with".
3246         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3247         (with_command, with_command_completer): New.
3248         (pipe_command): Adjust to new repeat_previous
3249         interface.
3250         (_initialize_cli_cmds): Install the "with" command and its "w"
3251         alias.
3252         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3253         declarations.
3254         * cli/cli-setshow.c (parse_cli_var_uinteger)
3255         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3256         argument strings for all var_types.
3257         (get_setshow_command_value_string): New, factored out from ...
3258         (do_show_command): ... this.
3259         * cli/cli-setshow.h: Include <string>.
3260         (get_setshow_command_value_string): Declare.
3261         * command.h (repeat_previous): Now returns const char *.  Adjust
3262         comment.
3263         * maint.c: Include "cli/cli-cmds.h".
3264         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3265         (_initialize_maint_cmds): Register the "maintenance with" command.
3266         * top.c (repeat_previous): Move bits from pipe_command here:
3267         Return the saved command line, if any; error out if there's no
3268         command to relaunch.
3269
3270 2019-07-03  Pedro Alves  <palves@redhat.com>
3271
3272         * NEWS (New commands): Mention "maint set/show test-settings"
3273         instead of "maint test-settings".
3274         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3275         (maintenance_test_settings_set_list): Rename to ...
3276         (maintenance_set_test_settings_list): ... this.
3277         (maintenance_test_settings_show_list): Rename to  ...
3278         (maintenance_show_test_settings_list): ... this.
3279         (maintenance_test_settings_cmd): Delete.
3280         (maintenance_test_settings_set_cmd): ...
3281         (maintenance_set_test_settings_cmd): ... this.
3282         (maintenance_test_settings_show_cmd): ...
3283         (maintenance_show_test_settings_cmd): ... this.
3284         (maintenance_test_settings_show_value_cmd):
3285         (maintenance_show_test_settings_value_cmd): ... this.
3286         (_initialize_maint_test_settings): No longer install the "maint
3287         test-settings" prefix command.  Rename "maint test-settings set"
3288         to "maint set test-settings", and "maint test-settings show" to
3289         "maint show test-settings".  Adjust all subcommands.
3290
3291 2019-07-03  Pedro Alves  <palves@redhat.com>
3292
3293         * maint-test-settings.c: Fix file's intro comment.  Replace all
3294         references to "test-options" with references to "test-settings",
3295         in comments.
3296
3297 2019-07-03  Pedro Alves  <palves@redhat.com>
3298
3299         * maint-test-settings.c (maintenance_test_settings_xxx)
3300         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3301         New.
3302         (maintenance_test_settings_enums): Use them.
3303         (maintenance_test_settings_enum): Default to
3304         maintenance_test_settings_xxx.
3305         (_initialize_maint_test_settings): Initialize
3306         MAINTENANCE_TEST_SETTINGS_FILENAME.
3307
3308 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3309
3310         * breakpoint.h (remove_breakpoints_inf): Change return type to
3311         void, move function documentation here.
3312         * breakpoint.c (remove_breakpoints_inf): Change return type to
3313         void, move function documentation to header.
3314
3315 2019-07-02  Pedro Alves  <palves@redhat.com>
3316
3317         * NEWS (Completion improvements): Mention "info threads".
3318         * thread.c (struct info_threads_opts, info_threads_option_defs)
3319         (make_info_threads_options_def_group): New.
3320         (info_threads_command): Use gdb::option::process_options.
3321         (info_threads_command_completer): New.
3322         (_initialize_thread): Use gdb::option::build_help to build the
3323         help text for "info threads".
3324
3325 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3326
3327         * defs.h (generic_load): Move from here...
3328         * symfile.h (generic_load): ... to here.  Rename name parameter
3329         to args.
3330         * symfile.c (generic_load): Add comment.
3331
3332 2019-07-01  Tom Tromey  <tromey@adacore.com>
3333
3334         * dwarf2read.c
3335         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3336         declaration of without_params.  Fix formatting.
3337
3338 2019-07-01  Tom Tromey  <tromey@adacore.com>
3339
3340         * ada-exp.y (find_primitive_type): Update.
3341         * ada-lang.h (ada_lookup_symbol): Update.
3342         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3343         parameter.
3344         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3345
3346 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3347
3348         PR breakpoints/24541
3349         * gdbarch.c: Regenerate.
3350         * gdbarch.h: Regenerate.
3351         * gdbarch.sh: Add 'stap_adjust_register'.
3352         * i386-tdep.c: Include '<unordered_set>'.
3353         (i386_stap_adjust_register): New function.
3354         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3355         * stap-probe.c (stap_parse_register_operand): Call
3356         'gdbarch_stap_adjust_register'.
3357
3358 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3359
3360         PR python/24742
3361         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3362         * python/python.c (do_start_initialization): Use 'xmalloc'
3363         instead of 'PyMem_Malloc'.
3364
3365 2019-06-28  Tom Tromey  <tromey@adacore.com>
3366
3367         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3368         for Ada.
3369
3370 2019-06-27  Tom Tromey  <tromey@adacore.com>
3371
3372         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3373         objfile_key.
3374         (arm_find_mapping_symbol, arm_record_special_symbol)
3375         (_initialize_arm_tdep): Update.
3376         (arm_objfile_data_free): Remove.
3377
3378 2019-06-27  Tom Tromey  <tromey@adacore.com>
3379
3380         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3381         to cp_print_static_field.
3382
3383 2019-06-26  Tom Tromey  <tromey@adacore.com>
3384
3385         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3386         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3387         declare.
3388
3389 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3390
3391         * features/aarch64-core.c (create_feature_aarch64_core):
3392         Regenerate.
3393         * features/aarch64-core.xml: Add cpsr flags.
3394
3395 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3396
3397         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3398         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3399
3400 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3401
3402         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3403         field.
3404         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3405         use.
3406         (arm_record_special_symbol): Don't insert new symbol in sorted
3407         position, push it at the end.
3408
3409 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3410
3411         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3412         (arm_mapping_symbol_s): Remove.
3413         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3414         (arm_mapping_symbol_vec): New typedef.
3415         (struct arm_per_objfile): Add constructor.
3416         <section_maps>: Change type to
3417         std::unique_ptr<arm_mapping_symbol_vec[]>.
3418         (arm_compare_mapping_symbols): Remove.
3419         (arm_find_mapping_symbol): Adjust to section_maps type change.
3420         (arm_objfile_data_free): Call delete on arm_per_objfile.
3421         (arm_record_special_symbol): Adjust to section_maps type change.
3422         Allocate arm_per_objfile with new.
3423
3424 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3425
3426         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3427         with the command prefix.
3428
3429 2019-06-25  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3432         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3433
3434 2019-06-25  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3437         type.
3438         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3439         protected.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-winsource.c
3444         (tui_source_window_base::set_is_exec_point_at): Add check against
3445         LOA_ADDRESS.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-source.c (tui_set_source_content): Don't check before
3450         xfree.
3451         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-winsource.h (tui_update_source_window_as_is)
3456         (tui_alloc_source_buffer, tui_line_is_displayed)
3457         (tui_addr_is_displayed): Change type of win_info.
3458         * tui/tui-winsource.c (tui_update_source_window_as_is)
3459         (tui_clear_source_content, tui_show_source_line)
3460         (tui_show_source_content, tui_source_window_base::refill)
3461         (tui_source_window_base::set_is_exec_point_at)
3462         (tui_source_window_base::set_is_exec_point_at)
3463         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3464         (tui_alloc_source_buffer, tui_line_is_displayed)
3465         (tui_addr_is_displayed): Change type of win_info.  Update.
3466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3467         (tui_source_window_base::do_make_visible_with_new_height):
3468         Update.
3469         * tui/tui-source.c (tui_set_source_content)
3470         (tui_set_source_content_nil)
3471         (tui_source_window::do_scroll_vertical): Update.
3472         * tui/tui-layout.c (show_layout): Update.
3473         * tui/tui-disasm.c (tui_set_disassem_content)
3474         (tui_disasm_window::do_scroll_vertical): Update.
3475         * tui/tui-data.h (tui_win_content): Remove.
3476         (struct tui_gen_win_info) <content, content_size>: Remove.
3477         (struct tui_source_element): Add initializers and destructor.
3478         (union tui_which_element, struct tui_win_element): Remove.
3479         (struct tui_source_window_base) <content>: New field.
3480         (struct tui_data_window): Remove destructor.
3481         (tui_alloc_content, tui_free_win_content)
3482         (tui_free_all_source_wins_content): Don't declare.
3483         * tui/tui-data.c (tui_initialize_static_data): Update.
3484         (init_content_element, tui_alloc_content): Remove.
3485         (~tui_gen_win_info): Update.
3486         (~tui_data_window, tui_free_all_source_wins_content)
3487         (tui_free_win_content, free_content, free_content_elements):
3488         Remove.
3489
3490 2019-06-25  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-winsource.h (tui_clear_source_content)
3493         (tui_erase_source_content, tui_show_source_content): Change type
3494         of win_info.
3495         * tui/tui-winsource.c (tui_clear_source_content)
3496         (tui_erase_source_content, tui_show_source_content): Change type
3497         of win_info.
3498         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3499         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3500         win_info.
3501         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3502         win_info.
3503         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-winsource.c (tui_clear_source_content)
3508         (tui_source_window_base::set_is_exec_point_at): Update.
3509         * tui/tui-source.c (tui_set_source_content_nil): Update.
3510         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3511         a bool.
3512         * tui/tui-data.c (init_content_element): Update.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3517         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3518         * tui/tui-layout.c (init_and_make_win): Update.
3519         * tui/tui.h (enum tui_win_type): Update.
3520         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3521         tui_win_is_auxillary.
3522         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3523         tui_win_is_auxillary.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3528         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3529         (tui_delete_data_content_windows, tui_display_all_data)
3530         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3531         Update.
3532         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3533         * tui/tui-regs.c (tui_last_regs_line_no)
3534         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3535         (tui_show_registers): Update.
3536         (tui_show_register_group): Return void.  Update.
3537         (tui_display_registers_from, tui_display_reg_element_at_line)
3538         (tui_display_registers_from_line, tui_check_register_values):
3539         Update.
3540         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3541         member.
3542         (struct tui_data_window) <regs_content>: Now a std::vector.
3543         <regs_content_count>: Remove.
3544         (tui_add_content_elements, tui_free_data_content): Don't declare.
3545         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3546         (init_content_element): Remove DATA_WIN case.  Add assert.
3547         (tui_add_content_elements): Remove.
3548         (tui_data_window): Update.
3549         (tui_free_data_content): Remove.
3550         (free_content_elements): Remove DATA_WIN case.
3551
3552 2019-06-25  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-data.c (tui_data_item_window): Update.
3555         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3556         * tui/tui-windata.c (tui_display_all_data)
3557         (tui_display_data_from_line): Update.
3558         (tui_check_data_values): Remove.
3559         * tui/tui-regs.c (tui_show_register_group)
3560         (tui_display_reg_element_at_line): Update.
3561         * tui/tui-hooks.c (tui_register_changed)
3562         (tui_refresh_frame_and_register_information): Call
3563         tui_check_register_values.
3564         * tui/tui-data.h (struct tui_data_window) <data_content,
3565         data_content_count, data_type>: Remove.
3566         (enum tui_data_type): Remove.
3567
3568         * tui/tui-data.c (tui_data_window::clear_detail)
3569         (~tui_data_window): Update.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3574         declare.
3575         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3576         Rename from tui_first_data_item_displayed.  Update.
3577         (tui_data_window::refresh_all)
3578         (tui_data_window::do_scroll_vertical): Update.
3579         * tui/tui-data.h (struct tui_data_window)
3580         <first_data_item_displayed>: Declare new method.
3581
3582 2019-06-25  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3585         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3586         contents...
3587         (tui_initialize_static_data): ...here.
3588
3589 2019-06-25  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3592         (tui_display_registers_from, tui_check_register_values): Update.
3593         (tui_display_register): Remove win_info parameter; update.
3594         (tui_get_register): Change type of parameters.
3595         * tui/tui-data.h (struct tui_data_element): Remove.
3596         (union tui_which_element) <data>: Remove.
3597         <data_window>: Change type.
3598         (struct tui_data_item_window): New.
3599         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3600         case.  Add assert.
3601         (~tui_data_item_window): New destructor.
3602         (free_content_elements): Remove DATA_ITEM_WIN case.
3603
3604 2019-06-25  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3607         Remove.
3608
3609 2019-06-25  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-data.h (struct tui_command_element): Remove.
3612         (union tui_which_element) <command>: Remove.
3613         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3614         assert.
3615         (free_content_elements): Remove CMD_WIN case.
3616
3617 2019-06-25  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-layout.c (tui_set_layout): Update.
3620         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3621         * tui/tui-data.c (layout_def): Update.
3622
3623 2019-06-25  Tom Tromey  <tom@tromey.com>
3624
3625         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3626         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3627         (tui_source_window_base::set_new_height): Update.
3628         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3629         Update.
3630         (tui_set_locator_fullname, tui_set_locator_info)
3631         (tui_show_frame_info): Update.
3632         * tui/tui-source.c (tui_set_source_content)
3633         (tui_source_is_displayed): Update.
3634         * tui/tui-layout.c (show_source_disasm_command, show_data)
3635         (show_source_or_disasm_and_command): Update.
3636         * tui/tui-disasm.c (tui_set_disassem_content)
3637         (tui_get_begin_asm_address): Update.
3638         * tui/tui-data.h (struct tui_locator_element): Remove.
3639         (union tui_which_element) <locator>: Remove.
3640         (struct tui_locator_window): New.
3641         (tui_locator_win_info_ptr): Change return type.
3642         * tui/tui-data.c (_locator): Change type.
3643         (tui_locator_win_info_ptr): Change return type.
3644         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3645         (tui_alloc_content): Add assert.
3646
3647 2019-06-25  Tom Tromey  <tom@tromey.com>
3648
3649         * tui/tui-winsource.c
3650         (tui_exec_info_window::maybe_allocate_content): New method.
3651         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3652         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3653         (make_source_or_disasm_window): Add cast.
3654         * tui/tui-data.h (union tui_which_element) <simple_string>:
3655         Remove.
3656         (struct tui_source_info): New.
3657         (struct tui_source_window_base) <execution_info>: Change type.
3658         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3659         case, and add assert.
3660         (tui_alloc_content): Add assert.
3661
3662 2019-06-25  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3665         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3666         * tui/tui-data.c (tui_alloc_win_info): Remove.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3671         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3672         can_highlight.
3673
3674 2019-06-25  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3677         make_visible_with_new_height method.
3678         (tui_win_info::make_visible_with_new_height): New method.
3679         (tui_source_window_base::do_make_visible_with_new_height)
3680         (tui_data_window::do_make_visible_with_new_height)
3681         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3682         (make_visible_with_new_height): Remove.
3683         (tui_resize_all, tui_adjust_win_heights): Use
3684         make_visible_with_new_height method.
3685         * tui/tui-data.h (struct tui_win_info)
3686         <do_make_visible_with_new_height, make_visible_with_new_height>:
3687         New methods.
3688         (struct tui_source_window_base, struct tui_data_window)
3689         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3690         methods.
3691
3692 2019-06-25  Tom Tromey  <tom@tromey.com>
3693
3694         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3695         method.
3696         (update_tab_width): Call update_tab_width method.
3697         * tui/tui-data.h (struct tui_win_info)
3698         (struct tui_source_window_base) <update_tab_width>: New methods.
3699
3700 2019-06-25  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3703         parameter.
3704         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3705         parameter.
3706         (tui_gen_win_info::make_visible): Update.
3707         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3708         parameter.
3709         * tui/tui-data.h (enum tui_box): New enum.
3710         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3711
3712 2019-06-25  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3715         init_and_make_win for EXEC_INFO_WIN.
3716         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3717         longer inline.
3718         (struct tui_win_info) <~tui_win_info>: Inline.
3719         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3720         Don't declare.
3721         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3722         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3723         Remove.
3724         (tui_initialize_static_data): Update.
3725         (~tui_gen_win_info): Handle more cleanup here.
3726         (~tui_source_window_base): Delete "execution_info".
3727         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3728
3729 2019-06-25  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-layout.c (make_command_window): Don't set
3732         can_highlight.
3733         (show_source_disasm_command): Call the reset method.
3734         (show_data): Don't set can_highlight.  Call the reset method.
3735         (tui_gen_win_info::reset): Rename from init_gen_win_info
3736         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3737         (show_source_or_disasm_and_command): Call the reset method.
3738         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3739         (struct tui_cmd_window): Set can_highlight.
3740
3741 2019-06-25  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3744         from make_visible.
3745         (tui_make_visible, tui_make_invisible): Rewrite.
3746         (tui_win_info::make_visible): Remove.
3747         (tui_source_window_base::make_visible): Update.
3748         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3749         method.  Moved from...
3750         (struct tui_win_info) <make_visible>: ...here.
3751
3752 2019-06-25  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-winsource.c
3755         (tui_source_window_base::do_scroll_horizontal): Remove direction
3756         parameter.
3757         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3758         direction parameter.
3759         * tui/tui-win.c (tui_win_info::forward_scroll)
3760         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3761         (tui_win_info::right_scroll): Update.
3762         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3763         direction parameter.
3764         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3765         direction parameter.
3766         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3767         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3768         Remove direction parameter.
3769         (struct tui_source_window_base, struct tui_source_window)
3770         (struct tui_disasm_window, struct tui_data_window)
3771         (struct tui_cmd_window): Update.
3772
3773 2019-06-25  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui-winsource.h (tui_set_exec_info_content)
3776         (tui_show_exec_info_content, tui_erase_exec_info_content)
3777         (tui_clear_exec_info_content, tui_update_exec_info): Change
3778         argument to tui_source_window_base.
3779         * tui/tui-winsource.c (tui_set_exec_info_content)
3780         (tui_show_exec_info_content, tui_erase_exec_info_content)
3781         (tui_clear_exec_info_content, tui_update_exec_info): Change
3782         argument to tui_source_window_base.
3783
3784 2019-06-25  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3787         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3788
3789 2019-06-25  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3792         check.
3793
3794 2019-06-25  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3797         type to void.
3798         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3799         type to void.
3800         * tui/tui-source.c (tui_set_source_content): Update.
3801         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3802
3803 2019-06-25  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-win.c (window_name_completer, tui_set_focus)
3806         (tui_all_windows_info): Use name method.
3807         * tui/tui-data.h (struct tui_gen_win_info)
3808         (struct tui_source_window, struct tui_disasm_window)
3809         (struct tui_data_window, struct tui_cmd_window) <name>: New
3810         method.
3811         (tui_win_name): Don't declare.
3812         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3813         (tui_win_name): Remove.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-winsource.h (tui_update_source_window)
3818         (tui_update_source_window_as_is): Change parameter type.
3819         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3820         to be a tui_source_window_base.
3821         (tui_update_source_window_as_is): Likewise.
3822         * tui/tui-win.c (make_visible_with_new_height): Update.
3823
3824 2019-06-25  Tom Tromey  <tom@tromey.com>
3825
3826         * tui/tui-winsource.c (tui_erase_source_content)
3827         (tui_show_source_content, tui_show_exec_info_content)
3828         (tui_erase_exec_info_content): Use refresh_window method.
3829         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3830         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3831         from tui_refresh_win.
3832         (tui_data_window::refresh_window): New method.
3833         (tui_win_info::refresh, tui_source_window_base::refresh)
3834         (tui_refresh_all): Use refresh_window method.
3835         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3836         method.
3837         * tui/tui-regs.c (tui_display_register): Call refresh_window
3838         method.
3839         * tui/tui-layout.c (show_source_disasm_command)
3840         (show_source_or_disasm_and_command): Call refresh_window method.
3841         * tui/tui-data.h (struct tui_gen_win_info)
3842         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3843         New method.
3844
3845 2019-06-25  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui.c (tui_rl_other_window, tui_enable)
3848         (tui_is_window_visible, tui_get_command_dimension): Update.
3849         * tui/tui-winsource.c (tui_update_source_window_as_is)
3850         (tui_clear_source_content, tui_erase_source_content)
3851         (tui_show_source_line, tui_source_window_base::refill)
3852         (tui_source_window_base::do_scroll_horizontal)
3853         (tui_source_window_base::set_is_exec_point_at)
3854         (tui_update_breakpoint_info, tui_set_exec_info_content)
3855         (tui_alloc_source_buffer, tui_line_is_displayed)
3856         (tui_addr_is_displayed): Update.
3857         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3858         (tui_check_and_display_highlight_if_needed)
3859         (tui_win_info::make_visible, tui_win_info::refresh)
3860         (tui_refresh_all): Update.
3861         * tui/tui-windata.c (tui_first_data_item_displayed)
3862         (tui_delete_data_content_windows, tui_erase_data_content)
3863         (tui_display_all_data, tui_data_window::refresh_all)
3864         (tui_check_data_values): Update.
3865         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3866         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3867         (tui_win_info::backward_scroll, tui_refresh_all_win)
3868         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3869         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3870         (tui_source_window_base::set_new_height)
3871         (tui_data_window::set_new_height)
3872         (make_invisible_and_set_new_height)
3873         (make_visible_with_new_height, new_height_ok)
3874         (parse_scrolling_args): Update.
3875         * tui/tui-stack.c (tui_show_frame_info): Update.
3876         * tui/tui-source.c (tui_set_source_content)
3877         (tui_set_source_content_nil, tui_source_is_displayed)
3878         (tui_source_window::do_scroll_vertical): Update.
3879         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3880         (tui_display_registers_from, tui_display_reg_element_at_line)
3881         (tui_check_register_values, tui_reg_command): Update.
3882         * tui/tui-layout.c (tui_default_win_height)
3883         (show_source_disasm_command, show_data, init_and_make_win)
3884         (show_source_or_disasm_and_command): Update.
3885         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3886         (tui_redisplay_readline, tui_mld_flush)
3887         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3888         (tui_getc): Update.
3889         * tui/tui-disasm.c (tui_set_disassem_content)
3890         (tui_disasm_window::do_scroll_vertical): Update.
3891         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3892         Now virtual.
3893         (struct tui_win_info): Derive from tui_gen_win_info.
3894         <~tui_win_info>: Mark as override.
3895         <generic>: Remove member.
3896         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3897         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3898         (~tui_data_window, ~tui_win_info)
3899         (tui_free_all_source_wins_content): Update.
3900         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3901
3902 2019-06-25  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-layout.c (init_and_make_win): Use new.
3905         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3906         destructor, initializers.
3907         (tui_alloc_generic_win_info): Don't declare.
3908         * tui/tui-data.c (_locator): Add argument to constructor.
3909         (source_win, disasm_win): New globals.
3910         (exec_info): Remove.
3911         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3912         Update.
3913         (tui_alloc_generic_win_info): Remove.
3914         (init_content_element): Use new.
3915         (tui_win_info::tui_win_info): Update.
3916         (free_content_elements) <case DATA_WIN>: Use delete.
3917
3918 2019-06-25  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3921         * tui/tui-windata.c (tui_first_data_item_displayed)
3922         (tui_delete_data_content_windows): Update.
3923         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3924         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3925         (tui_display_registers_from, tui_check_register_values): Update.
3926         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3927         pointer.
3928         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3929         window.
3930         (tui_free_data_content): Update.
3931         (free_content_elements) <case DATA_WIN>: Free the window.
3932
3933 2019-06-25  Tom Tromey  <tom@tromey.com>
3934
3935         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3936         Update.
3937         * tui/tui-layout.c (make_command_window)
3938         (show_source_disasm_command, show_data, init_and_make_win)
3939         (show_source_or_disasm_and_command): Update.
3940         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3941         method.
3942         <can_highight, is_highlighted>: Now bool.
3943         (tui_set_win_highlight): Don't declare.
3944         * tui/tui-data.c (tui_set_win_highlight): Remove.
3945
3946 2019-06-25  Tom Tromey  <tom@tromey.com>
3947
3948         * tui/tui-wingeneral.c (make_visible): Remove check of window
3949         type.
3950
3951 2019-06-25  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-win.c (tui_win_info::max_height)
3954         (tui_cmd_window::max_height): New methods.
3955         (new_height_ok): Call max_height.
3956         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3957         <max_height>: New method.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-win.c (tui_source_window_base::set_new_height)
3962         (tui_data_window::set_new_height): New methods.
3963         (make_invisible_and_set_new_height): Call set_new_height method.
3964         * tui/tui-data.h (struct tui_win_info)
3965         (struct tui_source_window_base, struct tui_data_window)
3966         <set_new_height>: New method.
3967
3968 2019-06-25  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3971         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3972         tui_refresh_data_win.
3973         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3974         method.
3975         (tui_refresh_all_win): Call the refresh_all method.
3976         (tui_set_focus): Likewise.
3977         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3978         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3979         Likewise.
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui-winsource.h (tui_refill_source_window)
3984         (tui_set_is_exec_point_at): Don't declare.
3985         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3986         (tui_source_window_base::refill): Rename from
3987         tui_refill_source_window.
3988         (tui_source_window_base::do_scroll_horizontal): Update.
3989         (tui_source_window_base::set_is_exec_point_at): Rename from
3990         tui_set_is_exec_point_at.
3991         (tui_update_all_breakpoint_info): Update.
3992         * tui/tui-stack.c (tui_show_frame_info): Update.
3993         * tui/tui-layout.c (show_data): Add cast.
3994         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3995         * tui/tui-data.h (struct tui_source_window_base) <refill,
3996         set_is_exec_point_at>: New methods.
3997         (tui_source_windows, tui_add_to_source_windows): Update types.
3998         (tui_add_to_source_windows): Remove redundant declaration.
3999         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4000         (tui_source_windows): Change return type.
4001         (tui_clear_source_windows_detail): Update.
4002         (tui_add_to_source_windows): Change type of parameter.
4003         (tui_free_all_source_wins_content): Update.
4004
4005 2019-06-25  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-wingeneral.c (tui_win_info::refresh)
4008         (tui_source_window_base::refresh): New methods.
4009         (tui_refresh_all): Call the refresh method.
4010         * tui/tui-data.h (struct tui_win_info)
4011         (struct tui_source_window_base) <refresh>: New method.
4012
4013 2019-06-25  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui.h (tui_is_window_visible): Return bool.
4016         * tui/tui.c (tui_is_window_visible): Return bool.
4017         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4018         (tui_make_visible, tui_make_invisible)
4019         (tui_win_info::make_visible)
4020         (tui_source_window_base::make_visible, make_all_visible)
4021         (tui_make_all_visible, tui_make_all_invisible): Update.
4022         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4023         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4024         bool.
4025         (struct tui_win_info, struct tui_source_window_base)
4026         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4027         * tui/tui-data.c (tui_init_generic_part): Update.
4028
4029 2019-06-25  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4032         (tui_source_window_base::make_visible): New methods.
4033         (make_all_visible): Make method call.
4034         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4035         (struct tui_source_window_base, struct tui_cmd_window): Override
4036         make_visible.
4037         (tui_win_is_source_type): Don't declare.
4038         * tui/tui-data.c (tui_win_is_source_type): Remove.
4039
4040 2019-06-25  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4043         NULL check.
4044
4045 2019-06-25  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4048         Inline constructor.  Add initializers for members.
4049         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4050         constructors; now inline in class.
4051
4052 2019-06-25  Tom Tromey  <tom@tromey.com>
4053
4054         * tui/tui-regs.c (tui_show_registers): Update.
4055         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4056         bool.
4057         * tui/tui-data.c (tui_data_window::clear_detail)
4058         (tui_data_window): Update.
4059
4060 2019-06-25  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-windata.c (tui_display_all_data)
4063         (tui_display_data_from_line, tui_display_data_from)
4064         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4065         Update.
4066         * tui/tui-regs.c (tui_last_regs_line_no)
4067         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4068         (tui_show_registers, tui_show_register_group)
4069         (tui_display_registers_from, tui_display_reg_element_at_line)
4070         (tui_display_registers_from_line, tui_check_register_values)
4071         (tui_reg_next, tui_reg_prev): Update.
4072         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4073         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4074         tui_data_window.
4075         (struct tui_win_info) <detail>: Remove.  Add new fields from
4076         tui_data_info.
4077         (TUI_DATA_WIN): Add cast.
4078         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4079         (~tui_data_window): Simplify.
4080
4081 2019-06-25  Tom Tromey  <tom@tromey.com>
4082
4083         * tui/tui-layout.c (show_source_disasm_command)
4084         (show_source_or_disasm_and_command): Update.
4085         * tui/tui-io.c (update_cmdwin_start_line)
4086         (tui_redisplay_readline): Update.
4087         * tui/tui-data.h (struct tui_command_info): Remove.
4088         (struct tui_win_info) <detail>: Remove command_info member.
4089         (struct tui_data_window) <start_line>: New member, from
4090         tui_command_info.
4091         (TUI_CMD_WIN): Add casts.
4092
4093 2019-06-25  Tom Tromey  <tom@tromey.com>
4094
4095         * tui/tui-winsource.c (tui_update_source_window)
4096         (tui_refill_source_window)
4097         (tui_source_window_base::do_scroll_horizontal)
4098         (tui_update_breakpoint_info, tui_set_exec_info_content)
4099         (tui_show_exec_info_content, tui_erase_exec_info_content)
4100         (tui_clear_exec_info_content): Update.
4101         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4102         Update.
4103         * tui/tui-win.c (make_invisible_and_set_new_height)
4104         (make_visible_with_new_height): Update.
4105         * tui/tui-source.c (tui_set_source_content)
4106         (tui_show_symtab_source): Update.
4107         * tui/tui-layout.c (extract_display_start_addr)
4108         (show_source_disasm_command, show_data)
4109         (make_source_or_disasm_window)
4110         (show_source_or_disasm_and_command): Update.
4111         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4112         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4113         "gdbarch".
4114         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4115         to tui_source_window_base.
4116         (struct tui_win_info) <detail>: Remove source_info member.
4117         (struct tui_source_window_base) <has_locator>: Inline.
4118         Move contents from tui_source_info; rename has_locator member to
4119         m_has_locator.
4120         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4121         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4122         header file.
4123         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4124         Simplify.
4125         (tui_free_all_source_wins_content): Cast to
4126         tui_source_window_base.
4127
4128 2019-06-25  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-win.c (make_invisible_and_set_new_height)
4131         (make_visible_with_new_height): Call has_locator method.
4132         * tui/tui-layout.c (show_source_disasm_command, show_data)
4133         (show_source_or_disasm_and_command): Update for bool change.
4134         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4135         (tui_win_info) <has_locator>: New method.
4136         (struct tui_source_window_base) <has_locator>: New method.
4137         (tui_win_has_locator): Don't declare.
4138         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4139         from tui_win_has_locator.
4140         (tui_source_window_base): Use false, not FALSE.
4141
4142 2019-06-25  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4145         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4146         clear_detail method directly.
4147         (tui_clear_win_detail): Remove.
4148
4149 2019-06-25  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4152         "this", not TUI_DISASM_WIN.
4153
4154 2019-06-25  Tom Tromey  <tom@tromey.com>
4155
4156         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4157         declare.
4158         * tui/tui-winsource.c
4159         (tui_source_window_base::do_scroll_horizontal): Rename from
4160         tui_horizontal_source_scroll.
4161         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4162         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4163         from tui_vertical_data_scroll.
4164         * tui/tui-win.h (tui_scroll): Don't declare.
4165         * tui/tui-win.c (tui_win_info::forward_scroll)
4166         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4167         (tui_win_info::right_scroll): Rename and update.
4168         (tui_scroll_forward_command, tui_scroll_backward_command)
4169         (tui_scroll_left_command, tui_scroll_right_command): Update.
4170         (tui_scroll): Remove.
4171         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4172         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4173         from tui_vertical_source_scroll.
4174         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4175         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4176         from tui_vertical_disassem_scroll.
4177         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4178         do_scroll_horizontal>: New methods.
4179         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4180         Likewise.
4181         (struct tui_source_window_base): Add do_scroll_horizontal.
4182         (struct tui_source_window, struct tui_disasm_window): Add
4183         do_scroll_vertical.
4184         (struct tui_data_window, struct tui_cmd_window): Add
4185         do_scroll_horizontal and do_scroll_vertical.
4186         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4187
4188 2019-06-25  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-data.h (struct tui_source_window_base): New struct.
4191         (struct tui_source_window): Derive from tui_source_window_base.
4192         (struct tui_disasm_window): New struct.
4193         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4194         from tui_source_window::clear_detail.
4195         (tui_source_window_base): Rename from tui_source_window.
4196         (~tui_source_window_base): Rename from ~tui_source_window.
4197         (tui_alloc_win_info): Create a tui_disasm_window.
4198
4199 2019-06-25  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-data.h (struct tui_source_window)
4202         (struct tui_data_window): Declare destructors.
4203         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4204         destructors.
4205         (tui_win_info): Simplify.
4206
4207 2019-06-25  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-winsource.c (tui_display_main)
4210         (tui_update_source_windows_with_addr)
4211         (tui_update_all_breakpoint_info): Update.
4212         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4213         (new_height_ok, parse_scrolling_args): Update.
4214         * tui/tui-stack.c (tui_show_frame_info): Update.
4215         * tui/tui-data.h (struct tui_list): Remove.
4216         (tui_source_windows): Return a reference to a std::vector.
4217         * tui/tui-data.c (source_windows): Now a std::vector.
4218         (tui_source_windows): Change return type.
4219         (tui_clear_source_windows): Rewrite.
4220         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4221         (tui_free_all_source_wins_content): Rewrite.
4222
4223 2019-06-25  Tom Tromey  <tom@tromey.com>
4224
4225         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4226         (struct tui_data_window, struct tui_cmd_window): Declare
4227         clear_detail method.
4228         * tui/tui-data.c (tui_source_window::clear_detail)
4229         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4230         methods.
4231         (tui_clear_win_detail): Simplify.
4232
4233 2019-06-25  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-layout.c (make_source_window, make_disasm_window)
4236         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4237         Return the new window.
4238         (show_source_disasm_command, show_data)
4239         (show_source_or_disasm_and_command): Update.
4240
4241 2019-06-25  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4244         parameter.  Return the new window.
4245         (show_source_disasm_command): Update and remove NULL check.
4246         (show_source_or_disasm_and_command): Update.
4247
4248 2019-06-25  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4251
4252 2019-06-25  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-data.h (struct tui_win_info): Make constructor
4255         protected.  Make destructor virtual.  Add initializers.
4256         (tui_source_window, tui_data_window, tui_cmd_window): New
4257         classes.
4258         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4259         constructor.  Add "type" parameter.
4260         (tui_source_window, tui_data_window, tui_cmd_window): New
4261         constructors.
4262         (tui_alloc_win_info): Instantiate the appropriate subclass.
4263
4264 2019-06-25  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-win.c (tui_resize_all): Use delete.
4267         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4268         destructor.
4269         (tui_free_window): Don't declare.
4270         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4271         Update.
4272
4273 2019-06-25  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-data.h (struct tui_win_info): Add constructor.
4276         * tui/tui-data.c (tui_alloc_win_info): Use new.
4277         (tui_free_window): Use delete.
4278
4279 2019-06-22  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4282         declare.
4283         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4284
4285 2019-06-22  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4288         declare.
4289         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4290
4291 2019-06-22  Tom de Vries  <tdevries@suse.de>
4292
4293         * dwarf2read.c (create_addrmap_from_aranges)
4294         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4295         instead of '%zu'.
4296
4297 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4298
4299         * dwarf2read.h (dwarf2_section_info_def): Remove.
4300         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4301         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4302         std::vector<dwarf2_section_info>.
4303         (struct dwo_file) <~dwo_file>: Remove.
4304         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4305         types field.
4306         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4307         (dwarf2_read_debug_names): Likewise.
4308         (create_debug_types_hash_table): Change parameter type to
4309         array_view, adjust code accordingly.
4310         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4311         (partial_die_info::fixup): Likewise.
4312         (determine_prefix): Likewise.
4313         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4314
4315 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4316
4317         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4318         gdb_bfd_ref_ptr.
4319         <~dwo_file>: Remove call to gdb_bfd_unref.
4320         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4321         gdb_bfd_ref_ptr::get.
4322
4323 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4324
4325         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4326         type to htab_up.
4327         * dwarf2read.c (struct dwo_file): Initialize fields.
4328         <~dwo_file>: New.
4329         (free_dwo_file): Remove, move content to ~dwo_file.
4330         (struct dwo_file_deleter): Remove.
4331         (dwo_file_up>: Remove custom deleter.
4332         (free_dwo_files): Remove.
4333         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4334         dwo_files.
4335         (process_skeletonless_type_units): Call unique_ptr::get.
4336         (allocate_dwo_file_hash_table): Add deleter to created hash
4337         table.  Change return type to htab_up.
4338         (lookup_dwo_file_slot): Don't memset dwo_file, call
4339         unique_ptr::get.
4340         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4341         (create_dwo_unit_in_dwp_v2): Likewise.
4342         (open_and_init_dwo_file): Likewise.
4343         (free_dwo_file_from_slot): Remove.
4344
4345 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4346
4347         * dwarf2read.h (struct dwarf2_section_info) <readin,
4348         is_virtual>: Change type to bool.
4349         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4350         true instead of 1.
4351
4352 2019-06-19  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-data.h (tui_init_content_element): Don't declare.
4355
4356 2019-06-19  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui-data.h (tui_init_win_info): Don't declare.
4359
4360 2019-06-19  Tom de Vries  <tdevries@suse.de>
4361
4362         * dwarf2read.h (abstract_to_concrete): Change type to
4363         std::unordered_map<sect_offset, std::vector<sect_offset>,
4364         gdb::hash_enum<sect_offset>>.
4365
4366 2019-06-19  Tom Tromey  <tromey@adacore.com>
4367
4368         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4369         EVAL_AVOID_SIDE_EFFECTS specially.
4370
4371 2019-06-19  Tom Tromey  <tromey@adacore.com>
4372
4373         * source-cache.c (highlighter): New global.
4374         (source_cache::get_source_lines): Create a highlighter on demand.
4375
4376 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * defs.h (deprecated_interactive_hook): Delete declaration.
4379         * interps.c (clear_interpreter_hooks): Remove use of
4380         deprecated_interactive_hook.
4381         * top.c (deprecated_interactive_hook): Delete definition.
4382         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4383
4384 2019-06-18  Tom de Vries  <tdevries@suse.de>
4385
4386         PR gdb/24515
4387         * dwarf2read.h (abstract_to_concrete): Change type from
4388         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4389         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4390         * dwarf2read.c (read_variable): Update.
4391         (dwarf2_fetch_die_loc_sect_off): Update.
4392
4393 2019-06-17  Tom de Vries  <tdevries@suse.de>
4394
4395         PR gdb/24617
4396         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4397         accessing parent[parent_len - 1].
4398
4399 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4400
4401         PR gdb/24364
4402         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4403         call dtrace_process_dof with NULL dof.
4404
4405 2019-06-16  Tom de Vries  <tdevries@suse.de>
4406
4407         PR gdb/24445
4408         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4409
4410 2019-06-16  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4413         (make_all_visible): Use address of member.
4414
4415 2019-06-16  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4418         (tui_free_window, free_content, free_content_elements): Remove
4419         unnecessary cast.
4420         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4421         cast.
4422         * tui/tui-regs.c (tui_show_register_group)
4423         (tui_display_registers_from, tui_display_reg_element_at_line):
4424         Remove unnecessary cast.
4425
4426 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * linux-nat.c (normal_mask): Delete.
4429         (_initialize_linux_nat): Don't initialise normal_mask.
4430
4431 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4432
4433         PR gdb/24445
4434         * dwarf-index-write.h (write_psymtabs_to_index): Add
4435         dwz_basename parameter.
4436         * dwarf-index-write.c (write_gdbindex): Move file writing to
4437         write_gdbindex_1.  Change return type void.
4438         (assert_file_size): Move up, remove filename parameter.
4439         (write_gdbindex_1): New function.
4440         (write_debug_names): Change return type to void, call
4441         assert_file_size.
4442         (struct index_wip_file): New struct.
4443         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4444         file logic to index_wip_file.  Write index for dwz file if
4445         needed.
4446         (save_gdb_index_command): Pass basename of dwz file, if present.
4447         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4448         build-id of dwz file, if present.
4449         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4450         (dwarf2_get_dwz_file): Likewise.
4451         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4452         (dwarf2_get_dwz_file): Likewise.
4453
4454 2019-06-16  Tom Tromey  <tom@tromey.com>
4455
4456         * coffread.c (process_coff_symbol): Use xstrdup.
4457         * value.c (create_internalvar): Use xstrdup.
4458
4459 2019-06-16  Tom Tromey  <tom@tromey.com>
4460
4461         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4462         * breakpoint.c (stopin_command, stopat_command)
4463         (until_break_command, decode_location_default): Remove unnecessary
4464         cast.
4465         * utils.c (subset_compare): Remove unnecessary cast.
4466         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4467         cast.
4468         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4469         cast.
4470         * infcmd.c (path_command): Remove unnecessary cast.
4471         * coffread.c (decode_type): Remove unnecessary cast.
4472         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4473         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4474         * tui/tui-stack.c (tui_show_locator_content)
4475         (tui_show_frame_info): Remove unnecessary cast.
4476         * tui/tui-win.c (tui_scroll_forward_command)
4477         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4478         (parse_scrolling_args): Remove unnecessary cast.
4479         * tui/tui-data.c (init_win_info, tui_del_window)
4480         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4481         (free_content_elements): Remove unnecessary cast.
4482         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4483         unnecessary cast.
4484         * tui/tui-source.c (tui_set_source_content)
4485         (tui_vertical_source_scroll): Remove unnecessary cast.
4486         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4487         cast.
4488         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4489         * tui/tui-regs.c (tui_display_registers_from)
4490         (tui_display_register): Remove unnecessary cast.
4491         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4492         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4493         (make_visible): Remove unnecessary cast.
4494         * tui/tui-winsource.c (tui_erase_source_content)
4495         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4496         unnecessary cast.
4497         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4498         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4499         * stabsread.c (read_type, read_array_type, read_range_type):
4500         Remove unnecessary cast.
4501         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4502         (parse_symbol, parse_type, upgrade_type, parse_external)
4503         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4504         unnecessary cast.
4505         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4506
4507 2019-06-16  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-data.c (tui_alloc_generic_win_info)
4510         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4511         checks.
4512
4513 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4514             Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * f-typeprint.c (f_print_type): Don't return early for not
4517         associated or not allocated types.
4518         (f_type_print_varspec_suffix): Add print_rank parameter and print
4519         ranks of array types in case they dangling.
4520         (f_type_print_base): Add print_rank parameter.
4521
4522 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * NEWS: Mention new MI commands.
4525         * break-catch-throw.c (enum exception_event_kind): Move to
4526         breakpoint.h.
4527         (print_mention_exception_catchpoint): Output text as a single
4528         message.
4529         (catch_exception_command_1): Rename to...
4530         (catch_exception_event): ...this, make non-static, update header
4531         command, and change some parameter types.
4532         (catch_catch_command): Update for changes to
4533         catch_exception_command_1.
4534         (catch_throw_command): Likewise.
4535         (catch_rethrow_command): Likewise.
4536         * breakpoint.c (enum exception_event_kind): Delete.
4537         * breakpoint.h (enum exception_event_kind): Moved here from
4538         break-catch-throw.c.
4539         (catch_exception_event): Declare.
4540         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4541         (mi_cmd_catch_throw): New function.
4542         (mi_cmd_catch_rethrow): New function.
4543         (mi_cmd_catch_catch): New function.
4544         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4545         'catch-catch' entries.
4546         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4547         (mi_cmd_catch_rethrow): Declare.
4548         (mi_cmd_catch_catch): Declare.
4549
4550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * annotate.c (annotate_source_line): Change return type to void,
4553         update implementation to match.
4554         * annotate.h (annotate_source_line): Change return type to void,
4555         update header comment.
4556         * stack.c (print_frame_info): Don't change what frame information
4557         is printed based on whether annotations are on or not.
4558
4559 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4562         (annotate_source): Make static.
4563         (annotate_source_line): Moved from source.c and renamed from
4564         identify_source_line.  Update the return type.
4565         * annotate.h (annotate_source): Delete declaration.
4566         (annotate_source_line): Declaration moved from source.h, and
4567         renamed from identify_source_line.  Return type updated.
4568         * source.c (identify_source_line): Moved to annotate.c and renamed
4569         to annotate_source_line.
4570         (info_line_command): Remove check of annotation_level.
4571         * source.h (identify_source_line): Move declaration to annotate.h
4572         and rename to annotate_source_line.
4573         * stack.c: Add 'annotate.h' include.
4574         (print_frame_info): Remove check of annotation_level before
4575         calling annotate_source_line.
4576
4577 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * source-cache.c (source_cache::get_plain_source_lines): Use
4580         open_source_file_with_line_charpos instead of just
4581         open_source_file, remove call to find_source_lines.
4582         (source_cache::get_source_lines): Likewise.
4583         * source.c (find_source_lines): Make static.
4584         (get_filename_and_charpos): Renamed into...
4585         (open_source_file_with_line_charpos): ..this along with changes to
4586         return a scoped_fd, and some other minor clean ups.
4587         (identify_source_line): Use open_source_file_with_line_charpos.
4588         (search_command_helper): Use open_source_file_with_line_charpos
4589         instead of just open_source_file, remove call to
4590         find_source_lines.
4591         * source.h (open_source_file_with_line_charpos): Declare new
4592         function.
4593         (find_source_lines): Delete declaration.
4594
4595 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * source.c (get_filename_and_charpos): Remove fullname
4598         parameter.
4599         (identify_source_line): Update call to get_filename_and_charpos.
4600
4601 2019-06-14  Tom Tromey  <tromey@adacore.com>
4602
4603         PR gdb/24502:
4604         * ui-style.h (skip_ansi_escape): Update comment.
4605         * ui-file.h (class no_terminal_escape_file): New class.
4606         * ui-file.c (no_terminal_escape_file::write)
4607         (no_terminal_escape_file::puts): New methods.
4608         * cli/cli-logging.c (handle_redirections): Use
4609         no_terminal_escape_file.
4610
4611 2019-06-14  Tom Tromey  <tromey@adacore.com>
4612
4613         * NEWS: Move convenience variable news above Python news.
4614
4615 2019-06-14  Tom Tromey  <tom@tromey.com>
4616
4617         * gnulib: Move directory to top-level.
4618         * configure.ac: Don't configure gnulib.
4619         * configure: Rebuild.
4620         * common/common-defs.h: Use new path to gnulib.
4621         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4622         (GNULIB_H): Remove.
4623         (INCGNU): Look in new gnulib location.
4624         (HFILES_NO_SRCDIR): Remove gnulib files.
4625         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4626         (generated_files): Remove GNULIB_H.
4627         ($(LIBGNU), all-lib): Remove targets.
4628         (distclean): Don't mention GNULIB_BUILDDIR.
4629         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4630
4631 2019-06-14  Tom Tromey  <tromey@adacore.com>
4632
4633         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4634         Warn if symbol file does not provide any symbols.
4635
4636 2019-06-14  Tom Tromey  <tromey@adacore.com>
4637
4638         * source.c (find_and_open_source): Respect basenames_may_differ.
4639
4640 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * annotate.c (annotate_breakpoints_invalid): Make use of
4643         scoped_restore_terminal_state.
4644         (annotate_frames_invalid): Likewise.
4645
4646 2019-06-14  Tom Tromey  <tromey@adacore.com>
4647
4648         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4649         allow assignment to an internalvar.
4650
4651 2019-06-14  Tom Tromey  <tromey@adacore.com>
4652
4653         * ada-lex.l: Allow "_" in attribute names.
4654
4655 2019-06-14  Tom Tromey  <tromey@adacore.com>
4656
4657         PR gdb/24653:
4658         * regcache.c (registers_changed): Don't call alloca.
4659         * top.c (execute_command): Don't call alloca.
4660
4661 2019-06-13  Pedro Alves  <palves@redhat.com>
4662
4663         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4664         'expression'.  When parsing an expression, error out if there's
4665         junk after "unlimited".
4666         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4667         (do_set_command): Adjust calls to is_unlimited_literal.
4668
4669 2019-06-13  Pedro Alves  <palves@redhat.com>
4670
4671         * compile/compile.c (make_compile_options_def_group): Add braces
4672         around array_view initializer.
4673         * thread.c (make_thread_apply_all_options_def_group)
4674         (make_thread_apply_all_options_def_group): Likewise.
4675
4676 2019-06-13  Pedro Alves  <palves@redhat.com>
4677
4678         * NEWS (New commands): Mention "maint test-options
4679         require-delimiter", "maint test-options unknown-is-error", "maint
4680         test-options unknown-is-operand" and "maint show
4681         test-options-completion-result".
4682         (New command options, command completion): New section.
4683         (Completion improvements): New section.
4684         Mention that you can abbreviate "unlimited".
4685
4686 2019-06-13  Pedro Alves  <palves@redhat.com>
4687
4688         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4689         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4690         * unittests/cli-utils-selftests.c (test_parse_flags)
4691         (test_parse_flags_qcs): Delete.
4692         (test_cli_utils): Don't call deleted functions.
4693
4694 2019-06-13  Pedro Alves  <palves@redhat.com>
4695
4696         * thread.c: Include "cli/cli-option.h".
4697         (tp_array_compar_ascending): Global.
4698         (tp_array_compar): Delete function.
4699         (tp_array_compar_ascending, tp_array_compar_descending): New
4700         functions.
4701         (ascending_option_def, qcs_flag_option_def)
4702         (thr_qcs_flags_option_defs)
4703         (make_thread_apply_all_options_def_group)
4704         (make_thread_apply_options_def_group): New.
4705         (thread_apply_all_command): Use gdb::option::process_options.
4706         (thread_apply_command_completer)
4707         (thread_apply_all_command_completer): New.
4708         (thread_apply_command): Use gdb::option::process_options.
4709         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4710         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4711         to generate help text of "thread apply".  Adjust "taas"'s help.
4712         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4713         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4714
4715 2019-06-13  Pedro Alves  <palves@redhat.com>
4716
4717         * thread.c (thread_apply_command): Check for invalid TID with
4718         isdigit instead of !isalpha.
4719
4720 2019-06-13  Pedro Alves  <palves@redhat.com>
4721
4722         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4723         (validate_flags_qcs): New.
4724         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4725         (validate_flags_qcs): Declare.
4726         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4727         (make_frame_apply_options_def_group): New.
4728         (frame_apply_command_count): Process options with
4729         gdb::option::process_options.
4730         (frame_apply_completer): New.
4731         (frame_apply_level_completer, frame_apply_all_completer)
4732         (frame_apply_completer): New.
4733         (_initialize_stack): Update help of "frame apply", "frame apply
4734         level", "frame apply all" and "faas" to mention supported options
4735         and install command completers.
4736         * stack.h (frame_apply_all_completer): Declare.
4737         * thread.c: Include "stack.h".
4738         (tfaas_command): Add "--".
4739         (_initialize_thread): Update help "tfaas" to mention supported
4740         options and install command completer.
4741
4742 2019-06-13  Pedro Alves  <palves@redhat.com>
4743
4744         * completer.c (complete_nested_command_line): New.
4745         (gdb_completion_word_break_characters_throw): Add assertion.
4746         * completer.h (complete_nested_command_line): Declare.
4747
4748 2019-06-13  Pedro Alves  <palves@redhat.com>
4749
4750         * stack.c (parse_backtrace_qualifiers): New.
4751         (backtrace_command): Use it.
4752         (backtrace_command_completer): Complete on qualifiers.
4753
4754 2019-06-13  Pedro Alves  <palves@redhat.com>
4755
4756         * frame.c: Include "cli/cli-option.h.
4757         (user_set_backtrace_options): New.
4758         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4759         Delete.
4760         (get_prev_frame): Adjust.
4761         (boolean_option_def, uinteger_option_def)
4762         (set_backtrace_option_defs): New.
4763         (_initialize_frame): Adjust and use
4764         gdb::option::add_setshow_cmds_for_options to install "set
4765         backtrace past-main" and "set backtrace past-entry".
4766         * frame.h: Include "cli/cli-option.h".
4767         (struct frame_print_options): Forward declare.
4768         (print_frame_arguments_all, print_frame_arguments_scalars)
4769         (print_frame_arguments_none): Declare.
4770         (print_entry_values): Delete declaration.
4771         (struct frame_print_options, user_frame_print_options): New.
4772         (struct set_backtrace_options): New.
4773         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4774         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4775         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4776         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4777         (list_args_or_locals): Add frame_print_options parameter.
4778         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4779         * python/py-framefilter.c (enumerate_args): Pass down
4780         USER_FRAME_PRINT_OPTIONS.
4781         * stack.c: Include "cli/cli-option.h".
4782         (print_frame_arguments_all, print_frame_arguments_scalars)
4783         (print_frame_arguments_none): Declare.
4784         (print_raw_frame_arguments, print_entry_values): Delete.
4785         (user_frame_print_options): New.
4786         (boolean_option_def, enum_option_def, frame_print_option_defs):
4787         New.
4788         (struct backtrace_cmd_options): New.
4789         (bt_flag_option_def): New.
4790         (backtrace_command_option_defs): New.
4791         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4792         (print_frame_arg, read_frame_arg, print_frame_args)
4793         (print_frame_info, print_frame): Add frame_print_options parameter
4794         and use it.
4795         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4796         (backtrace_command_1): Add frame_print_options and
4797         backtrace_cmd_options parameters and use them.
4798         (make_backtrace_options_def_group): New.
4799         (backtrace_command): Process command options with
4800         gdb::option::process_options.
4801         (backtrace_command_completer): New.
4802         (_initialize_stack): Extend "backtrace"'s help to mention
4803         supported options.  Install completer for "backtrace".
4804         Install some settings commands with add_setshow_cmds_for_options.
4805
4806 2019-06-13  Pedro Alves  <palves@redhat.com>
4807
4808         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4809         and that "set/show print raw frame-arguments" are now deprecated.
4810
4811         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4812         command.
4813         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4814         * stack.c (_initialize_stack): Install "set/show print
4815         raw-frame-arguments", and deprecate "set/show print raw
4816         frame-arguments".
4817         * valprint.c (_initialize_valprint): Deprecate "set/show print
4818         raw".
4819
4820 2019-06-13  Pedro Alves  <palves@redhat.com>
4821
4822         * compile/compile.c (struct compile_options): New.
4823         (compile_flag_option_def, compile_command_option_defs)
4824         (make_compile_options_def_group): New.
4825         (compile_file_command): Handle options with
4826         gdb::option::process_options.
4827         (compile_file_command_completer): New function.
4828         (compile_code_command): Handle options with
4829         gdb::option::process_options.
4830         (compile_code_command_completer): New function.
4831         (_initialize_compiler): Install completers for "compile code" and
4832         "compile file".  Mention available options in "compile code" and
4833         "compile code"'s help.
4834         * completer.c (advance_to_completion_word): New, factored out from
4835         ...
4836         (advance_to_expression_complete_word_point): ... this.
4837         (advance_to_filename_complete_word_point): New.
4838         * completer.h (advance_to_filename_complete_word_point): New
4839         declaration.
4840
4841 2019-06-13  Pedro Alves  <palves@redhat.com>
4842
4843         * compile/compile.c: Include "cli/cli-option.h".
4844         (compile_print_value): Scope data pointer is now a
4845         value_print_options pointer; adjust.
4846         (compile_print_command): Process options.  Scope data pointer is
4847         now a value_print_options pointer; adjust.
4848         (_initialize_compile): Update "compile print"'s help to include
4849         supported options.  Install a completer for "compile print".
4850         * cp-valprint.c (show_vtblprint, show_objectprint)
4851         (show_static_field_print): Delete.
4852         (_initialize_cp_valprint): Don't install "set print
4853         static-members", "set print vtbl", "set print object" here.
4854         * printcmd.c: Include "cli/cli-option.h" and
4855         "common/gdb_optional.h".
4856         (print_command_parse_format): Rework to fill in a
4857         value_print_options instead of a format_data.
4858         (print_value): Change parameter type from format_data pointer to
4859         value_print_options reference.  Adjust.
4860         (print_command_1): Process options.  Adjust to pass down a
4861         value_print_options.
4862         (print_command_completer): New.
4863         (_initialize_printcmd): Install print_command_completer as
4864         handle_brkchars completer for the "print" command.  Update
4865         "print"'s help to include supported options.
4866         * valprint.c: Include "cli/cli-option.h".
4867         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4868         here from cp-valprint.c.
4869         (boolean_option_def, uinteger_option_def)
4870         (value_print_option_defs, make_value_print_options_def_group):
4871         New.  Use gdb::option::add_setshow_cmds_for_options to install
4872         "set print elements", "set print null-stop", "set print repeats",
4873         "set print pretty", "set print union", "set print array", "set
4874         print address", "set print symbol", "set print array-indexes".
4875         * valprint.h: Include <string> and "cli/cli-option.h".
4876         (make_value_print_options_def_group): Declare.
4877         (print_value): Change parameter type from format_data pointer to
4878         value_print_options reference.
4879         (print_command_completer): Declare.
4880
4881 2019-06-13  Pedro Alves  <palves@redhat.com>
4882
4883         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4884         (COMMON_SFILES): Add maint-test-settings.c.
4885         * cli/cli-decode.c (boolean_enums): New global, factored out from
4886         ...
4887         (add_setshow_boolean_cmd): ... here.
4888         * cli/cli-decode.h (boolean_enums): Declare.
4889         * cli/cli-option.c: New file.
4890         * cli/cli-option.h: New file.
4891         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4892         factored out from ...
4893         (parse_cli_boolean_value(const char *)): ... this.
4894         (is_unlimited_literal): Change parameter type to pointer to
4895         pointer.  Adjust and advance ARG pointer.
4896         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4897         (parse_cli_var_enum): New, factored out from ...
4898         (do_set_command): ... this.  Adjust.
4899         * cli/cli-setshow.h (parse_cli_boolean_value)
4900         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4901         (parse_cli_var_enum): Declare.
4902         * cli/cli-utils.c: Include "cli/cli-option.h".
4903         (get_ulongest): New.
4904         * cli/cli-utils.h (get_ulongest): Declare.
4905         (check_for_argument): New overloads.
4906         * maint-test-options.c: New file.
4907
4908 2019-06-13  Pedro Alves  <palves@redhat.com>
4909
4910         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4911         parse a range if "-" is at the end of the string.
4912
4913 2019-06-13  Pedro Alves  <palves@redhat.com>
4914
4915         * cli/cli-setshow.c (parse_auto_binary_operation)
4916         (parse_cli_boolean_value): Don't allow "o".
4917
4918 2019-06-13  Pedro Alves  <palves@redhat.com>
4919
4920         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4921         * NEWS: Mention maint test-settings KIND.
4922         * maint-test-settings.c: New file.
4923
4924 2019-06-13  Pedro Alves  <palves@redhat.com>
4925
4926         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4927         completer.
4928         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4929         "set" completers.
4930
4931 2019-06-13  Pedro Alves  <palves@redhat.com>
4932
4933         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4934         after item.
4935
4936 2019-06-13  Pedro Alves  <palves@redhat.com>
4937
4938         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4939
4940 2019-06-13  Pedro Alves <palves@redhat.com>
4941
4942         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4943         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4944         call.
4945         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4946         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4947         calls.
4948         (check_for_argument): Skip spaces after argument.
4949
4950 2019-06-13  Pedro Alves  <palves@redhat.com>
4951
4952         * thread.c (thread_apply_command): Adjust TID parsing.
4953         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4954         detected before end of string.
4955         (tid_is_in_list): Error out if LIST is invalid.
4956
4957 2019-06-13  Pedro Alves  <palves@redhat.com>
4958
4959         * completer.c (complete_line_internal_1): Rewind completion word
4960         point.
4961         (completion_tracker::advance_custom_word_point_by): Change
4962         parameter type to int.
4963         * completer.h (completion_tracker::advance_custom_word_point_by):
4964         Likewise.
4965
4966 2019-06-13  Pedro Alves  <palves@redhat.com>
4967
4968         * completer.c (advance_to_completion_word): Handle delimiters.
4969
4970 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4971
4972         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4973
4974 2019-06-11  Tom Tromey  <tom@tromey.com>
4975
4976         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4977         (xmalloc_failed): Move to alloc.c.
4978         * alloc.c: New file.
4979         * Makefile.in (COMMON_SFILES): Add alloc.c.
4980
4981 2019-06-11  Tom Tromey  <tom@tromey.com>
4982
4983         * nat/linux-waitpid.c: Don't include server.h.
4984         (linux_debug): Remove.
4985         (my_waitpid): Update.
4986
4987 2019-06-11  Tom Tromey  <tromey@adacore.com>
4988
4989         * infcall.c (_initialize_infcall): Remove trailing newline from
4990         help.
4991         * user-regs.c (_initialize_user_regs): Remove trailing newline
4992         from help.
4993         * typeprint.c (_initialize_typeprint): Remove trailing newline
4994         from help.
4995         * reverse.c (_initialize_reverse): Remove trailing newlines from
4996         help.
4997         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4998         from help.
4999         * language.c (add_set_language_command): Remove trailing newline
5000         from help.
5001         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5002         help.
5003         * disasm.c (_initialize_disasm): Remove trailing newline from
5004         help.
5005         * top.c (init_main): Remove trailing newline from help.
5006         * interps.c (_initialize_interpreter): Remove trailing newline
5007         from help.
5008         * btrace.c (_initialize_btrace): Remove trailing newlines from
5009         help.
5010         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5011         from help.
5012         * python/python.c (_initialize_python): Remove trailing newline
5013         from help.
5014         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5015         help.
5016         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5017         from help.  Reformat some text.
5018         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5019         from help.
5020         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5021         newline from help.
5022
5023 2019-06-11  Tom Tromey  <tromey@adacore.com>
5024
5025         * darwin-nat.c (darwin_decode_exception_message)
5026         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5027
5028 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * valops.c (value_slice): Check for not allocated or not
5031         associated values.
5032
5033 2019-06-10  Tom de Vries  <tdevries@suse.de>
5034
5035         PR gdb/24618
5036         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5037         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5038         invalid.
5039
5040 2019-06-10  Tom de Vries  <tdevries@suse.de>
5041
5042         PR gdb/24611
5043         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5044         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5045
5046 2019-06-10  Tom de Vries  <tdevries@suse.de>
5047
5048         PR symtab/24545
5049         * symtab.c (struct demangled_name_entry): Add language field.
5050         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5051         static minimal symbol".  Set and use language field.
5052
5053 2019-06-10  Tom Tromey  <tromey@adacore.com>
5054
5055         * ada-lang.c (_initialize_ada_language): Update help text.
5056
5057 2019-06-10  Tom Tromey  <tromey@adacore.com>
5058
5059         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5060         with a newline.
5061         * guile/guile.c (handle_boot_error): Don't end warning with a
5062         newline.
5063         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5064         warning with a newline.
5065         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5066         newline.
5067         (s12z_frame_cache): Likewise.
5068         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5069         a newline.
5070         * solib-svr4.c (disable_probes_interface): Don't end warning with
5071         a newline.
5072         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5073         newline.
5074         * python/python.c (do_finish_initialization): Don't end warning
5075         with a newline.
5076
5077 2019-06-10  Tom Tromey  <tom@tromey.com>
5078
5079         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5080         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5081         gdbpy_enter.
5082
5083 2019-06-10  Tom Tromey  <tromey@adacore.com>
5084
5085         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5086         data.
5087         (elf_new_init): Don't call stabsread_new_init.
5088         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5089         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5090         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5091
5092 2019-06-10  Tom de Vries  <tdevries@suse.de>
5093
5094         PR symtab/16264
5095         PR symtab/24517
5096         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5097
5098 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5099
5100         * source.c (find_and_open_source): Also rewrite relative file
5101         names.
5102
5103 2019-04-26  Amos Bird  <amosbird@gmail.com>
5104
5105         * annotate.c (annotate_thread_exited): Add "thread-exited"
5106         annotation.
5107
5108 2019-06-06  Tom Tromey  <tromey@adacore.com>
5109
5110         * maint.h (class scoped_command_stats): Use
5111         DISABLE_COPY_AND_ASSIGN.
5112         <print_time>: New method.
5113         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5114         print_time.
5115         (scoped_command_stats::print_time): New method.
5116
5117 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5120         instructions of lengths 6 or 8 bytes.
5121
5122 2019-06-04  Pedro Alves  <palves@redhat.com>
5123
5124         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5125
5126         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5127         * breakpoint.c (condition_completer): Likewise.
5128         * cli/cli-dump.c (scan_expression): Likewise.
5129         * common/filestuff.c (mkdir_recursive): Likewise.
5130         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5131         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5132         (gdb_abspath): Likewise.
5133         * compile/compile-cplus-types.c
5134         (compile_cplus_instance::decl_name): Likewise.
5135         * completer.c (complete_explicit_location):
5136         (signal_completer, reg_or_group_completer_1): Likewise.
5137         * cp-support.c (cp_remove_params_if_any): Likewise.
5138         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5139         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5140         * infcmd.c (strip_bg_char): Likewise.
5141         * linespec.c (copy_token_string): Likewise.
5142         * mi/mi-main.c (output_cores): Likewise.
5143         * psymtab.c (psymtab_search_name):
5144         * symfile.c (test_set_ext_lang_command): Likewise.
5145         * target.c (target_fileio_read_stralloc): Likewise.
5146         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5147         * value.c (complete_internalvar): Likewise.
5148
5149 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5150
5151         Add objfile property to gdb.Type.
5152         * NEWS: Mention Python API addition.
5153         * python/py-type.c (typy_get_objfile): New method.
5154
5155 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5156
5157         * NEWS: Mention the new set|show style [title|highlight].
5158         Mention changes to "show style", "help" and "apropos".
5159
5160 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5161
5162         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5163         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5164         instead of print_help_for_command.
5165         (print_doc_of_command): New function.
5166         (help_list): Add 'apropos -v word' suggestion.
5167         (print_help_for_command): Style the command name using title style.
5168         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5169         (_initialize_cli_cmds): Describe -v in apropos_command help.
5170
5171 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5172
5173         * cli/cli-style.h (cli_style_option): Add name in constructor,
5174         add m_name class member, add constructor with intensity,
5175         add name class function.
5176         (cli_style_option::add_setshow_commands): Remove name argument.
5177         (highlight_style, title_style): New styles.
5178         * cli/cli-style.c (do_show): New function that shows a style
5179         characteristic styling the style name with itself.
5180         (set_style_name): New function.
5181         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5182         Update all callers according to the changes in cli/cli-style.h.
5183         * utils.h (fputs_highlighted): New function.
5184         * utils.c (fputs_highlighted): Likewise.
5185
5186 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5187
5188         * NEWS: Mention new pipe command and new convenience variables.
5189
5190 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5191
5192         * cli/cli-cmds.c (pipe_command): New function.
5193         (_initialize_cli_cmds): Call add_com for pipe_command.
5194         Define | as an alias for pipe.
5195         (exit_status_set_internal_vars): New function.
5196         (shell_escape): Call exit_status_set_internal_vars.
5197         cli/cli-decode.c (find_command_name_length): Recognize | as
5198         a single character command.
5199
5200 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5201
5202         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5203         top.c (execute_command_to_ui_file): New function, mostly a copy
5204         of execute_command_to_string.
5205         (execute_command_to_string): Implement by calling
5206         execute_command_to_ui_file.
5207
5208 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5209
5210         * top.h (saved_command_line): Remove declaration.
5211         * top.c (previous_saved_command_line, previous_repeat_arguments):
5212         New variables.
5213         (saved_command_line): Make static, define together with other
5214         'repeat variables'.
5215         (dont_repeat): Clear repeat_arguments.
5216         (repeat_previous, get_saved_command_line, save_command_line):
5217         New functions.
5218         (gdb_init): Initialize saved_command_line
5219         and previous_saved_command_line.
5220         * main.c (captured_main_1): Remove saved_command_line initialization.
5221         * event-top.c (handle_line_of_input): Update to use
5222         the new 'repeat' related functions instead of direct access to
5223         saved_command_line.
5224         * command.h (repeat_previous, get_saved_command_line,
5225         save_command_line): New declarations.
5226         (dont_repeat): Add comment.
5227
5228 2019-05-30  Tom Tromey  <tromey@adacore.com>
5229
5230         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5231         Fix comment.
5232         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5233
5234 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5235
5236         PR cli/24587
5237         * completer.c (complete): Initialize variable word.
5238
5239 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5240
5241         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5242         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5243         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5244         'body' is NULL to the outter 'if', protecting the '!is_define'
5245         situation as well.
5246
5247 2019-05-29  Tom Tromey  <tromey@adacore.com>
5248
5249         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5250         (dwarf_unknown): New function.
5251         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5252         (dwarf_type_encoding_name): Use dwarf_unknown.
5253
5254 2019-05-29  Tom Tromey  <tromey@adacore.com>
5255
5256         PR c++/20020:
5257         * cp-valprint.c (cp_print_value_fields): Call
5258         cp_print_static_field inside "try".
5259
5260 2019-05-29  Tom Tromey  <tromey@adacore.com>
5261
5262         * inflow.c (struct terminal_info): Add default operator=.
5263         * configure: Rebuild.
5264         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5265         -Wdeprecated-copy-dtor, -Wredundant-move.
5266
5267 2019-05-29  Tom Tromey  <tromey@adacore.com>
5268
5269         * NEWS: Add entry.
5270         * infcmd.c (print_return_value_1): Handle finish_print
5271         option.
5272         (show_print_finish): New function.
5273         (_initialize_infcmd): Add "set/show print finish" commands.
5274         * valprint.c (user_print_options): Initialize new member.
5275         * valprint.h (struct value_print_options) <finish_print>: New
5276         member.
5277
5278 2019-05-28  Tom Tromey  <tromey@adacore.com>
5279
5280         * ada-lang.c (ada_remove_Xbn_suffix)
5281         (find_old_style_renaming_symbol)
5282         (parse_old_style_renaming): Remove.
5283         (ada_find_renaming_symbol): Don't call
5284         find_old_style_renaming_symbol.
5285         (ada_is_renaming_symbol): Rename from
5286         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5287         bool.  Now static.
5288         (ada_read_var_value): Update and simplify.
5289         * ada-exp.y (write_var_or_type): Remove old code.
5290
5291 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5292
5293         * event-top.c: Remove include comment.
5294         * inflow.c (class scoped_ignore_sigttou): Move from here...
5295         * inflow.h (class scoped_ignore_sigttou): ...to here.
5296         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5297         * top.c:  Remove include comment.
5298
5299 2019-05-27  Tom Tromey  <tom@tromey.com>
5300
5301         * NEWS: Fix typo.
5302
5303 2019-05-22  Tom Tromey  <tromey@adacore.com>
5304
5305         * target.c (target_follow_exec): Constify parameter.
5306         * target-delegates.c: Rebuild.
5307         * remote.c (remote_target::follow_exec): Constify parameter.
5308         * infrun.c (follow_exec): Constify parameter.
5309         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5310         (target_follow_exec): Likewise.
5311
5312 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5313
5314         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5315         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5316
5317 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5318
5319         * NEWS: Add debugredirect and testsuite sections.
5320
5321 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5322
5323         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5324         target descriptions using exclusively floating point register name
5325         aliases.
5326
5327 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5328
5329         PR gdb/18644:
5330         * f-lang.c (build_fortran_types): Handle the case where
5331         gdbarch_floatformat_for_type returns a nullptr.
5332
5333 2019-05-21  Tom de Vries  <tdevries@suse.de>
5334
5335         PR cli/24587
5336         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5337
5338 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5339
5340         PR gdb/18644:
5341         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5342         16-byte floats.
5343         * i386-tdep.c (i386_floatformat_for_type): Use
5344         floatformats_ia64_quad for the 16-byte floating point component
5345         within a fortran 32-byte complex number.
5346
5347 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5348
5349         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5350         delete default constructor.
5351         (find_partial_die): Update to return const struct.
5352         (partial_die_parent_scope): Move variable declaration into scope
5353         of its use and change its type to auto.
5354         (guess_partial_die_structure_name): Likewise.
5355         (partial_die_info::fixup): Likewise.
5356
5357 2019-05-17  Tom Tromey  <tromey@adacore.com>
5358
5359         * source.c (find_and_open_source): Remove cast.
5360
5361 2019-05-17  Tom Tromey  <tromey@adacore.com>
5362
5363         * annotate.c (annotate_source): Make "filename" const.
5364         * annotate.h (annotate_source): Use const.
5365
5366 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5367
5368         * disasm.c (set_disassembler_options): Send errors to stderr.
5369
5370 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5371
5372         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5373         (cli_interp_base::set_logging): Check debug_redirect.
5374         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5375         * cli/cli-logging.c (debug_redirect): Add static variable.
5376         (pop_output_files): Add default param.
5377         (handle_redirections): Print debug setting.
5378         (show_logging_command): Likewise.
5379         (_initialize_cli_logging): Add debugredirect command.
5380         * interps.c (current_interp_set_logging): Add debug_redirect
5381         parameter.
5382         * interps.h (set_logging): Add debug_redirect parameter.
5383         (current_interp_set_logging): Likewise.
5384         * mi/mi-common.h: Likewise.
5385         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5386
5387 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5388             Tom Tromey  <tromey@adacore.com>
5389
5390         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5391         directly.
5392         * cli/cli-interp.h (make_logging_output): Remove declaration.
5393         * cli/cli-logging.c (make_logging_output): Remove function.
5394         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5395         directly.
5396         * ui-file.c (tee_file::tee_file): Remove bools.
5397         (tee_file::~tee_file): Remove deletes.
5398         * ui-file.h (tee_file): Remove bools.
5399
5400 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5401
5402         * mi/mi-cmds.h (mi_cmd_complete): New function.
5403         * mi/mi-main.c (mi_cmd_complete): Likewise.
5404         * mi/mi-cmds.c: Define new MI command -complete.
5405         * NEWS: Mention new -complete command.
5406
5407 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5408
5409         * completer.h (complete): New function.
5410         * completer.c (complete): Likewise.
5411         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5412         function defined in completer.h.
5413
5414 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5415
5416         * MAINTAINERS (Write After Approval): Add myself.
5417
5418 2019-05-17  Tom de Vries  <tdevries@suse.de>
5419
5420         PR gdb/24094
5421         * dwarf2read.c (struct cu_partial_die_info): New struct.
5422         (find_partial_die): Return cu_partial_die_info.
5423         (partial_die_parent_scope, guess_partial_die_structure_name)
5424         (partial_die_info::fixup): Handle new return type of find_partial_die.
5425
5426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5427
5428         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5429         "std::string", simplifying the algorithm.
5430
5431 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5432
5433         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5434         (stap_static_probe_ops::get_probes): Likewise.
5435
5436 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5437
5438         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5439         '-')" and "else if".
5440         (stap_parse_single_operand): Join checks for
5441         "gdbarch_stap_parse_special_token_p" and
5442         "gdbarch_stap_parse_special_token" in the same "if" statement.
5443         Invert check when verifying for operation on register
5444         displacement.
5445
5446 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5447
5448         * stap-probe.c (stap_get_opcode): Update comment.
5449         (stap_get_expected_argument_type): Likewise.
5450         (handle_stap_probe): Likewise.
5451
5452 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5453
5454         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5455         return type to 'bool'.  Adjust comment.  Use 'bool' when
5456         appropriate.
5457         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5458         * stap-probe.c (stap_parse_argument_1): Likewise.
5459         (stap_is_operator): Likewise.
5460         (stap_is_generic_prefix): Likewise.
5461         (stap_is_register_prefix): Likewise.
5462         (stap_is_register_indirection_prefix): Likewise.
5463         (stap_is_integer_prefix): Likewise.
5464         (stap_generic_check_suffix): Likewise.
5465         (stap_check_integer_suffix): Likewise.
5466         (stap_check_register_suffix): Likewise.
5467         (stap_check_register_indirection_suffix): Likewise.
5468         (stap_parse_register_operand): Likewise.
5469         (stap_parse_single_operand): Likewise.
5470         (stap_parse_argument_1): Likewise.
5471         (stap_probe::get_argument_count): Likewise.
5472         (stap_is_operator): Likewise.
5473
5474 2019-05-16  Tom Tromey  <tromey@adacore.com>
5475
5476         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5477         keyword to foreach.
5478
5479 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5480
5481         * linux-thread-db.c (try_thread_db_load_1): Change return type
5482         to bool.
5483         (try_thread_db_load): Likewise.
5484         (try_thread_db_load_from_pdir_1): Likewise.
5485         (try_thread_db_load_from_pdir): Likewise.
5486         (try_thread_db_load_from_sdir): Likewise.
5487         (try_thread_db_load_from_dir): Likewise.
5488         (thread_db_load_search): Likewise.
5489         (has_libpthread): Likewise.
5490         (thread_db_load): Likewise.
5491
5492 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5493
5494         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5495         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5496         NULL, and complain/return if that's the case.
5497
5498 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5499
5500         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5501         (advance, posn, abstract_read_memory): New functions.
5502         [struct mem_read_abstraction]: New struct.
5503         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5504
5505 2019-05-14  Tom Tromey  <tromey@adacore.com>
5506
5507         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5508         value is not lval_memory.
5509
5510 2019-05-14  Tom Tromey  <tromey@adacore.com>
5511
5512         * solib.c (info_sharedlibrary_command): Style the file name.
5513
5514 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5515
5516         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5517         (aarch64_vnv_type): Likewise.
5518         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5519         * common/tdesc.c: Likewise.
5520         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5521         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5522         * features/aarch64-fpu.xml: Add ieee half view.
5523         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5524         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5525         * gdbtypes.h (struct builtin_type): Likewise.
5526         (struct objfile_type): Likewise.
5527
5528 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5529
5530         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5531         typo.
5532         * location.h (string_to_event_location): Likewise.
5533
5534 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5535
5536         GDB 8.3 released.
5537
5538 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5539
5540         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5541         New variable declaration.
5542         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5543         New variable.
5544         (print_one_breakpoint): Use ui_out::test_flags and new global
5545         variable to compute use_fixed_output.
5546         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5547         Remove.
5548         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5549         (mi_multi_location_breakpoint_output_fixed): Remove.
5550         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5551         new variable.
5552         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5553         fix_multi_location_breakpoint_output flag if version >= 3.
5554         * ui-out.h (enum ui_out_flag)
5555         <fix_multi_location_breakpoint_output>: New enumerator.
5556
5557 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5558
5559         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5560
5561 2019-05-10  Tom Tromey  <tromey@adacore.com>
5562
5563         * ada-lang.c (catch_ada_completer): New function.
5564         (_initialize_ada_language): Use it.
5565
5566 2019-05-10  Tom Tromey  <tromey@adacore.com>
5567
5568         * thread.c (print_thread_info): Make "requested_threads" const.
5569         * gdbthread.h (print_thread_info): Make "requested_threads"
5570         const.
5571         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5572         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5573
5574 2019-05-08  Tom Tromey  <tom@tromey.com>
5575
5576         * gdbtypes.c (objfile_type_data): Change type.
5577         (objfile_type, _initialize_gdbtypes): Update.
5578
5579 2019-05-08  Tom Tromey  <tom@tromey.com>
5580
5581         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5582         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5583         (_initialize_dwarf2_frame): Update.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * objc-lang.c (objc_objfile_data): Change type.
5588         (find_methods): Update.
5589         (_initialize_objc_lang): Remove.
5590
5591 2019-05-08  Tom Tromey  <tom@tromey.com>
5592
5593         * stabsread.c (rs6000_builtin_type_data): Change type.
5594         (rs6000_builtin_type, _initialize_stabsread): Update.
5595
5596 2019-05-08  Tom Tromey  <tom@tromey.com>
5597
5598         * mips-tdep.c (mips_pdr_data): Remove.
5599         (_initialize_mips_tdep): Update.
5600
5601 2019-05-08  Tom Tromey  <tom@tromey.com>
5602
5603         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5604         (hppa_init_objfile_priv_data, read_unwind_info)
5605         (find_unwind_entry, _initialize_hppa_tdep): Update.
5606
5607 2019-05-08  Tom Tromey  <tom@tromey.com>
5608
5609         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5610         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5611         on obstack.
5612         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5613
5614 2019-05-08  Tom Tromey  <tom@tromey.com>
5615
5616         * mdebugread.c (basic_type_data): Change type.
5617         (basic_type, _initialize_mdebugread): Update.
5618
5619 2019-05-08  Tom Tromey  <tom@tromey.com>
5620
5621         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5622
5623 2019-05-08  Tom Tromey  <tom@tromey.com>
5624
5625         * nto-tdep.c (nto_inferior_data_reg): Change type.
5626         (nto_inferior_data): Update.
5627         (nto_inferior_data_cleanup, nto_new_inferior_data)
5628         (_initialize_nto_tdep): Remove.
5629         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5630
5631 2019-05-08  Tom Tromey  <tom@tromey.com>
5632
5633         * ada-lang.c (struct ada_inferior_data): Add initializers.
5634         (ada_inferior_data): Change type.
5635         (ada_inferior_data_cleanup): Remove.
5636         (get_ada_inferior_data, ada_inferior_exit)
5637         (struct ada_pspace_data): Add initializers, destructor.
5638         (ada_pspace_data_handle): Change type.
5639         (get_ada_pspace_data): Update.
5640         (ada_pspace_data_cleanup): Remove.
5641
5642 2019-05-08  Tom Tromey  <tom@tromey.com>
5643
5644         * coffread.c (struct coff_symfile_info): Add initializers.
5645         (coff_objfile_data_key): Move lower.  Change type.
5646         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5647         Update.
5648         (coff_free_info): Remove.
5649
5650 2019-05-08  Tom Tromey  <tom@tromey.com>
5651
5652         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5653         (fbsd_pspace_data_handle): Move lower.  Change type.
5654         (get_fbsd_pspace_data): Update.
5655         (fbsd_pspace_data_cleanup): Remove.
5656         (_initialize_fbsd_tdep): Update.
5657
5658 2019-05-08  Tom Tromey  <tom@tromey.com>
5659
5660         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5661         (get_ada_tasks_pspace_data): Update.
5662         (ada_tasks_pspace_data_cleanup): Remove.
5663         (_initialize_tasks): Update.
5664         (ada_tasks_inferior_data_handle): Change type.
5665         (get_ada_tasks_inferior_data): Update.
5666         (ada_tasks_inferior_data_cleanup): Remove.
5667         (struct ada_tasks_pspace_data): Add initializers.
5668
5669 2019-05-08  Tom Tromey  <tom@tromey.com>
5670
5671         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5672         * symfile-debug.c (debug_sym_get_probes): Change type.
5673         * stap-probe.c (handle_stap_probe):
5674         (stap_static_probe_ops::get_probes): Change type.
5675         * probe.h (class static_probe_ops) <get_probes>: Change type.
5676         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5677         (parse_probes_in_pspace): Update.
5678         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5679         Update.
5680         (any_static_probe_ops::get_probes): Change type.
5681         * elfread.c (elfread_data): New typedef.
5682         (probe_key): Change type.
5683         (elf_get_probes): Likewise.  Update.
5684         (probe_key_free): Remove.
5685         (_initialize_elfread): Update.
5686         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5687         Change type.
5688         (dtrace_process_dof_probe, dtrace_process_dof)
5689         (dtrace_static_probe_ops::get_probe): Change type.
5690
5691 2019-05-08  Tom Tromey  <tom@tromey.com>
5692
5693         * xcoffread.c (struct xcoff_symfile_info): Rename from
5694         coff_symfile_info.  Add initializers.
5695         (xcoff_objfile_data_key): Move lower.  Change type.
5696         (XCOFF_DATA): Rewrite.
5697         (xcoff_free_info): Remove.
5698         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5699         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5700         (xcoff_initial_scan): Update.
5701
5702 2019-05-08  Tom Tromey  <tom@tromey.com>
5703
5704         * solib-svr4.c (struct svr4_info): Add initializers and
5705         destructor.
5706         <probes_table>: Now an htab_up.
5707         (solib_svr4_pspace_data): Change type.
5708         (free_probes_table): Simplify.
5709         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5710         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5711         (probes_table_remove_objfile_probes, register_solib_event_probe)
5712         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5713         (_initialize_svr4_solib): Update.
5714
5715 2019-05-08  Tom Tromey  <tom@tromey.com>
5716
5717         * remote.c (remote_pspace_data): Change type.
5718         (remote_pspace_data_cleanup): Remove.
5719         (get_remote_exec_file, set_pspace_remote_exec_file)
5720         (_initialize_remote): Update.
5721
5722 2019-05-08  Tom Tromey  <tom@tromey.com>
5723
5724         * breakpoint.c (breakpoint_objfile_key): Change type.
5725         (get_breakpoint_objfile_data): Update.
5726         (free_breakpoint_objfile_data): Remove.
5727         (_initialize_breakpoint): Update.
5728
5729 2019-05-08  Tom Tromey  <tom@tromey.com>
5730
5731         * linux-tdep.c (struct linux_info): Add initializers.
5732         (linux_inferior_data): Move.  Change type.
5733         (invalidate_linux_cache_inf): Update.
5734         (linux_inferior_data_cleanup): Remove.
5735         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5736
5737 2019-05-08  Tom Tromey  <tom@tromey.com>
5738
5739         * auxv.c (auxv_inferior_data): Move.  Change type.
5740         (auxv_inferior_data_cleanup): Remove.
5741         (invalidate_auxv_cache_inf): Rewrite.
5742         (get_auxv_inferior_data, _initialize_auxv): Update.
5743
5744 2019-05-08  Tom Tromey  <tom@tromey.com>
5745
5746         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5747         (symfile_debug_objfile_data_key): Change type.
5748         (symfile_debug_installed, debug_qf_has_symbols)
5749         (debug_qf_find_last_source_symtab)
5750         (debug_qf_forget_cached_source_info)
5751         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5752         (debug_qf_print_stats, debug_qf_dump)
5753         (debug_qf_expand_symtabs_for_function)
5754         (debug_qf_expand_all_symtabs)
5755         (debug_qf_expand_symtabs_with_fullname)
5756         (debug_qf_map_matching_symbols)
5757         (debug_qf_expand_symtabs_matching)
5758         (debug_qf_find_pc_sect_compunit_symtab)
5759         (debug_qf_map_symbol_filenames)
5760         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5761         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5762         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5763         (debug_sym_read_linetable, debug_sym_relocate): Update.
5764         (symfile_debug_free_objfile): Remove.
5765         (install_symfile_debug_logging, _initialize_symfile_debug):
5766         Update.
5767
5768 2019-05-08  Tom Tromey  <tom@tromey.com>
5769
5770         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5771         allocate_on_obstack.
5772         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5773         (get_dwarf2_per_objfile): Update.
5774         (set_dwarf2_per_objfile): Remove.
5775         (dwarf2_has_info, dwarf2_get_section_info): Update.
5776         (dwarf2_free_objfile): Remove.
5777         (_initialize_dwarf2_read): Update.
5778
5779 2019-05-08  Tom Tromey  <tom@tromey.com>
5780
5781         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5782         initializers.
5783         <unsupported_script_warning_printed,
5784         script_not_found_warning_printed>: Now bool.
5785         (auto_load_pspace_data): Change type.
5786         (~auto_load_pspace_info): Rename from
5787         auto_load_pspace_data_cleanup.
5788         (get_auto_load_pspace_data, init_loaded_scripts_info)
5789         (clear_section_scripts, maybe_print_unsupported_script_warning)
5790         (maybe_print_script_not_found_warning, _initialize_auto_load):
5791         Update.
5792
5793 2019-05-08  Tom Tromey  <tom@tromey.com>
5794
5795         * objfiles.c (objfile_pspace_info): Add destructor and
5796         initializers.
5797         (objfiles_pspace_data): Change type.
5798         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5799         (get_objfile_pspace_data): Update.
5800         (objfiles_bfd_data): Change type.
5801         (get_objfile_bfd_data): Update.
5802         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5803
5804 2019-05-08  Tom Tromey  <tom@tromey.com>
5805
5806         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5807         Change type.
5808         (get_catch_syscall_inferior_data): Update.
5809         (catch_syscall_inferior_data_cleanup): Remove.
5810         (_initialize_break_catch_syscall): Update.
5811
5812 2019-05-08  Tom Tromey  <tom@tromey.com>
5813
5814         * inflow.c (struct terminal_info): Add destructor and
5815         initializers.
5816         (inflow_inferior_data): Change type.
5817         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5818         (get_inflow_inferior_data, inflow_inferior_exit)
5819         (swap_terminal_info, _initialize_inflow): Update.
5820
5821 2019-05-08  Tom Tromey  <tom@tromey.com>
5822
5823         * target-dcache.c (target_dcache_cleanup): Remove.
5824         (target_dcache_aspace_key): Change type.
5825         (target_dcache_init_p, target_dcache_invalidate)
5826         (target_dcache_get, target_dcache_get_or_init)
5827         (_initialize_target_dcache): Update.
5828         * dcache.h (struct dcache_deleter): New.
5829
5830 2019-05-08  Tom Tromey  <tom@tromey.com>
5831
5832         * symtab.c (struct symbol_cache): Add destructor and
5833         initializers.
5834         (symbol_cache_key): Move.  Change type.
5835         (make_symbol_cache, free_symbol_cache): Remove.
5836         (get_symbol_cache): Update.
5837         (symbol_cache_cleanup): Remove.
5838         (ALL_PSPACES, symbol_cache_flush)
5839         (maintenance_print_symbol_cache)
5840         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5841         Update.
5842
5843 2019-05-08  Tom Tromey  <tom@tromey.com>
5844
5845         * symtab.c (struct main_info): Add destructor and initializers.
5846         (main_progspace_key): Move.  Change type.
5847         (get_main_info): Update.
5848         (main_info_cleanup): Remove.
5849         (_initialize_symtab): Update.
5850
5851 2019-05-08  Tom Tromey  <tom@tromey.com>
5852
5853         * registry.h (DECLARE_REGISTRY): Define the _key class.
5854
5855 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * NEWS: Merge two 'New commands' sections.
5858
5859 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5860
5861         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5862         parameter and use Ada language definition instead.
5863         (ada_val_print_ptr): Remove unused language parameter.
5864         (ada_val_print_num): Remove language parameter and use Ada language
5865         definition instead.
5866         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5867         parameter.
5868         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5869         parameter and use Ada language definition instead.
5870         (ada_val_print_1): Update all ada_val_print_xxx calls.
5871         Remove language parameter.
5872         (ada_val_print): Update ada_val_print_1 call.
5873
5874 2019-05-08  Tom Tromey  <tromey@adacore.com>
5875
5876         * remote.c (remote_hw_watchpoint_limit)
5877         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5878         Now static.
5879
5880 2019-05-08  Tom Tromey  <tromey@adacore.com>
5881
5882         * maint.c (_initialize_maint_cmds): Move initialization code to
5883         remote.c.
5884         (watchdog, show_watchdog): Move to remote.c.
5885         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5886         "watchdog" static.
5887         (_initialize_remote): Move initialization code from maint.c.
5888         * defs.h (watchdog): Don't declare.
5889
5890 2019-05-08  Tom Tromey  <tromey@adacore.com>
5891
5892         * tui/tui-interp.c: Include main.h.
5893         * interps.c: Include main.h.
5894         * main.h (interpreter_p): Declare.
5895         * defs.h (interpreter_p): Don't declare.
5896
5897 2019-05-08  Tom Tromey  <tromey@adacore.com>
5898
5899         * dwarf2loc.c: Include dwarf2read.h.
5900         * defs.h (read_unsigned_leb128): Don't declare.
5901         * dwarf2read.h (read_unsigned_leb128): Declare.
5902
5903 2019-05-08  Tom Tromey  <tromey@adacore.com>
5904
5905         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5906         method.
5907
5908 2019-05-08  Tom Tromey  <tromey@adacore.com>
5909
5910         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5911         when no wrap column is set.
5912
5913 2019-05-08  Tom Tromey  <tromey@adacore.com>
5914
5915         * c-lang.c (c_get_string): Handle non-C-style arrays.
5916
5917 2019-05-08  Tom Tromey  <tromey@adacore.com>
5918
5919         * typeprint.c (print_offset_data::update): Print the bit offset,
5920         not the number of bits remaining.
5921
5922 2019-05-08  Tom Tromey  <tromey@adacore.com>
5923
5924         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5925         padding at end of comment.
5926
5927 2019-05-08  Tom Tromey  <tromey@adacore.com>
5928
5929         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5930         Compare main types.
5931
5932 2019-05-06  Tom Tromey  <tom@tromey.com>
5933
5934         * common/scoped_mmap.c: Include common-defs.h.
5935         * common/scoped_mmap.h: Don't include config.h.
5936
5937 2019-05-04  Tom Tromey  <tom@tromey.com>
5938
5939         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5940         (struct aarch64_call_info): Add initializers.
5941         <si>: Now a std::vector.
5942         (pass_on_stack, aarch64_push_dummy_call): Update.
5943
5944 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5945             Tom Tromey  <tom@tromey.com>
5946
5947         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5948         (ppc_threads): Now a std::vector.  Now static.
5949         (hwdebug_find_thread_points_by_tid)
5950         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5951         Update.
5952
5953 2019-05-04  Tom Tromey  <tom@tromey.com>
5954
5955         * arc-tdep.c (arc_tdesc_init): Return bool.
5956
5957 2019-05-04  Tom Tromey  <tom@tromey.com>
5958
5959         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5960         Use gdb_assert_not_reached.
5961
5962 2019-05-04  Tom Tromey  <tom@tromey.com>
5963
5964         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5965         "false".
5966
5967 2019-05-04  Tom Tromey  <tom@tromey.com>
5968
5969         * arc-tdep.c (arc_tdesc_init): Use bool.
5970
5971 2019-05-04  Tom Tromey  <tom@tromey.com>
5972
5973         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5974
5975 2019-05-04  Tom Tromey  <tom@tromey.com>
5976
5977         * cli/cli-cmds.c (valid_command_p): Return bool.
5978
5979 2019-05-04  Tom Tromey  <tom@tromey.com>
5980
5981         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5982         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5983
5984 2019-05-04  Raul Tambre  <raul@tambre.ee>
5985
5986         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5987         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5988         operator for comparison.
5989
5990 2019-05-04  Tom Tromey  <tom@tromey.com>
5991
5992         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5993         (lookup_partial_symbol, print_partial_symbols)
5994         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5995         (psymbol_compare): Update.
5996         (add_psymbol_to_bcache): Clear the entire psymbol.
5997         (maintenance_check_psymtabs): Update.
5998         * psympriv.h (struct partial_symbol): Don't derive from
5999         general_symbol_info.
6000         <obj_section, unrelocated_address, address,
6001         set_unrelocated_address>: Update.
6002         <ginfo>: New member.
6003         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6004         (debug_names::write_psymbols): Update.
6005
6006 2019-05-04  Tom de Vries  <tdevries@suse.de>
6007
6008         * contrib/cc-with-tweaks.sh: Support -n arg.
6009
6010 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6011
6012         * corelow.c (core_target::detach): Ensure frame cache and
6013         register caches are cleared.
6014         inferior.c (exit_inferior_1): Likewise.
6015
6016 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6017             Tom Tromey  <tom@tromey.com>
6018
6019         * dictionary.c (collate_pending_symbols_by_language): Remove
6020         "struct" from foreach.
6021         * symtab.c (lookup_global_symbol_from_objfile)
6022         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6023         foreach.
6024         * ser-tcp.c (net_open): Remove "struct" from foreach.
6025         * objfiles.c (objfile_relocate, objfile_rebase)
6026         (objfile_has_symbols): Remove "struct" from foreach.
6027         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6028         from foreach.
6029         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6030         foreach.
6031         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6032         "struct" from foreach.
6033         * ada-lang.c (create_excep_cond_exprs)
6034         (ada_exception_catchpoint_cond_string): Remove "struct" from
6035         foreach.
6036
6037 2019-05-03  Tom Tromey  <tromey@adacore.com>
6038
6039         * ada-exp.y (convert_char_literal): Check suffix of each
6040         enumerator.
6041
6042 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6043
6044         PR ada/21406:
6045         * ada-exp.y (yywrap): Don't define.
6046         * ada-lex.l (%option): Add noyywrap
6047         (yywrap): Remove.
6048
6049 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6050
6051         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6052         _WIN32_WINNT to the XP level, unless already defined to a higher
6053         level.
6054
6055         * unittests/parse-connection-spec-selftests.c:
6056         * ser-tcp.c:
6057         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6058         override.
6059
6060         * symfile.c (find_separate_debug_file): Remove colon from the
6061         drive spec of DOS/Windows file names of the target, so that the
6062         file name produced from DEBUGDIR and the target's directory will
6063         be valid on DOS/Windows systems.
6064
6065 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * rust-lang.c (val_print_struct): Handle printing structures
6068         containing strings.
6069
6070 2019-05-02  Tom Tromey  <tromey@adacore.com>
6071
6072         * valarith.c (_initialize_valarith): Remove.
6073
6074 2019-05-01  Tom Tromey  <tromey@adacore.com>
6075
6076         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6077         bitfields.
6078
6079 2019-05-01  Tom Tromey  <tromey@adacore.com>
6080
6081         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6082         for big-endian copies.
6083
6084 2019-04-30  Ali Tamur  <tamur@google.com>
6085         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6086         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6087         (read_3_bytes): New function.
6088
6089 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6090
6091         * windows-nat.c (main_thread_id): Delete.
6092         (handle_output_debug_string): Replace main_thread_id by
6093         current_event.dwThreadId.
6094         (fake_create_process): Likewise.
6095         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6096         Do not set main_thread_id.
6097         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6098         current_event.dwThreadId.
6099         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6100
6101 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6102
6103         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6104         Use current_event.dwThreadId instead of main_thread_id.
6105
6106 2019-04-30  Tom Tromey  <tromey@adacore.com>
6107
6108         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6109         (create_excep_cond_exprs): Iterate over program spaces.
6110         (ada_exception_catchpoint_cond_string): Examine all minimal
6111         symbols for exception types.
6112
6113 2019-04-30  Tom Tromey  <tromey@adacore.com>
6114
6115         PR c++/24470:
6116         * dwarf2read.c (process_structure_scope): Handle case where type
6117         has template parameters but no symbol was created.
6118
6119 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6120             Chris January  <chris.january@arm.com>
6121
6122         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6123         qualifier.
6124         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6125
6126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6127
6128         * f-typeprint.c (f_print_type): Update rules for printing
6129         whitespace.
6130         (f_type_print_varspec_suffix): Likewise.
6131
6132 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6133             Chris January  <chris.january@arm.com>
6134
6135         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6136         function arguments.
6137
6138 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * f-lang.c (build_fortran_types): Change name of void type to
6141         lower case.
6142         * f-typeprint.c (f_type_print_base): Print the name of the void
6143         type, rather than a fixed string.
6144         * f-valprint.c (f_decorations): Use lower case void string.
6145
6146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6147             Chris January  <chris.january@arm.com>
6148
6149         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6150         types for Fortran.
6151
6152 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6153             Chris January  <chris.january@arm.com>
6154             David Lecomber  <david.lecomber@arm.com>
6155
6156         * f-exp.y (BINOP_INTRINSIC): New token.
6157         (exp): New parser rule handling BINOP_INTRINSIC.
6158         (f77_keywords): Add new builtin procedures.
6159         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6160         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6161         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6162         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6163         (print_unop_subexp_f): New function.
6164         (print_binop_subexp_f): New function.
6165         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6166         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6167         (dump_subexp_body_f): Likewise.
6168         (operator_check_f): Likewise.
6169         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6170         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6171
6172 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6175         UNOP_KIND.
6176         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6177         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6178         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6179         (operator_length_f): New fuction.
6180         (print_subexp_f): New function.
6181         (op_name_f): New function.
6182         (dump_subexp_body_f): New function.
6183         (operator_check_f): New function.
6184         (exp_descriptor_f): Replace standard expression handling functions
6185         with new functions.
6186         * gdb/fortran-operator.def: New file.
6187         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6188         * gdb/std-operator.def: Remove UNOP_KIND.
6189
6190 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6191
6192         * std-operator.def: Remove unbalanced, stray double quote
6193         character.
6194
6195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6196             Chris January  <chris.january@arm.com>
6197             Daniel Everett  <daniel.everett@arm.com>
6198             Nick Forrington  <nick.forrington@arm.com>
6199             Richard Bunt  <richard.bunt@arm.com>
6200
6201         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6202         of depth when printing anonymous structs or unions.
6203         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6204         Don't print either the top-level value, or the children if the
6205         max-depth is exceeded.
6206         (ppscm_print_children): When printing the key of a map, allow one
6207         extra level of depth.
6208         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6209         print either the top-level value, or the children if the max-depth
6210         is exceeded.
6211         (print_children): When printing the key of a map, allow one extra
6212         level of depth.
6213         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6214         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6215         (user_print_options): Initialise max_depth field.
6216         (val_print_scalar_or_string_type_p): New function.
6217         (val_print): Check to see if the max depth has been reached.
6218         (val_print_check_max_depth): Define new function.
6219         (show_print_max_depth): New function.
6220         (_initialize_valprint): Add 'print max-depth' option.
6221         * valprint.h (struct value_print_options) <max_depth>: New field.
6222         (val_print_check_max_depth): Declare new function.
6223         * NEWS: Document new feature.
6224
6225 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6226
6227         * ada-lang.c (ada_language_defn): Initialise new field.
6228         * c-lang.c (c_is_string_type_p): New function.
6229         (c_language_defn): Initialise new field.
6230         (cplus_language_defn): Initialise new field.
6231         (asm_language_defn): Initialise new field.
6232         (minimal_language_defn): Initialise new field.
6233         * c-lang.h (c_is_string_type_p): Declare new function.
6234         * d-lang.c (d_language_defn): Initialise new field.
6235         * f-lang.c (f_is_string_type_p): New function.
6236         (f_language_defn): Initialise new field.
6237         * go-lang.c (go_is_string_type_p): New function.
6238         (go_language_defn): Initialise new field.
6239         * language.c (default_is_string_type_p): New function.
6240         (unknown_language_defn): Initialise new field.
6241         (auto_language_defn): Initialise new field.
6242         * language.h (struct language_defn) <la_is_string_type_p>: New
6243         member variable.
6244         (default_is_string_type_p): Declare new function.
6245         * m2-lang.c (m2_language_defn): Initialise new field.
6246         * objc-lang.c (objc_language_defn): Initialise new field.
6247         * opencl-lang.c (opencl_language_defn): Initialise new field.
6248         * p-lang.c (pascal_is_string_type_p): New function.
6249         (pascal_language_defn): Initialise new field.
6250         * rust-lang.c (rust_is_string_type_p): New function.
6251         (rust_language_defn): Initialise new field.
6252
6253 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6256         New field.
6257         * ada-lang.c (ada_language_defn): Initialise new field.
6258         * c-lang.c (c_language_defn): Likewise.
6259         (cplus_language_defn): Likewise.
6260         (asm_language_defn): Likewise.
6261         (minimal_language_defn): Likewise.
6262         * d-lang.c (d_language_defn): Likewise.
6263         * f-lang.c (f_language_defn): Likewise.
6264         * go-lang.c (go_language_defn): Likewise.
6265         * language.c (unknown_language_defn): Likewise.
6266         (auto_language_defn): Likewise.
6267         * m2-lang.c (m2_language_defn): Likewise.
6268         * objc-lang.c (objc_language_defn): Likewise.
6269         * opencl-lang.c (opencl_language_defn): Likewise.
6270         * p-lang.c (pascal_language_defn): Likewise.
6271         * rust-lang.c (rust_language_defn): Likewise.
6272
6273 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6274
6275         * ada-lang.c (ada_is_character_type): Change return type to bool.
6276         (ada_is_string_type): Likewise.
6277         * ada-lang.h (ada_is_character_type): Update declaration
6278         (ada_is_string_type): Likewise.
6279
6280 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6281
6282         Support style in 'frame|thread apply'
6283
6284         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6285         * record.c (record_start, record_stop): Update callers of
6286         execute_command_to_string with false.
6287         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6288         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6289         methods.
6290         (class string_file): New constructor with term_out parameter.
6291         Override methods term_out and can_emit_style_escape.  New member
6292         term_out.
6293         (class stdio_file): Override can_emit_style_escape.
6294         (class tee_file): Override term_out and can_emit_style_escape.
6295         * utils.h (can_emit_style_escape): Remove.
6296         * utils.c (can_emit_style_escape): Likewise.
6297         Update all callers of can_emit_style_escape (SOMESTREAM) to
6298         SOMESTREAM->can_emit_style_escape.
6299         * source-cache.c (source_cache::get_source_lines): Likewise.
6300         * stack.c (frame_apply_command_count): Call execute_command_to_string
6301         passing the term_out characteristic of the current gdb_stdout.
6302         * thread.c (thr_try_catch_cmd): Likewise.
6303         * top.c (execute_command_to_string): pass term_out parameter
6304         to construct the string_file for the command output.
6305         * ui-file.c (term_cli_styling): New function (most code moved
6306         from utils.c can_emit_style_escape).
6307         (string_file::string_file, string_file::can_emit_style_escape,
6308         stdio_file::can_emit_style_escape, tee_file::term_out,
6309         tee_file::can_emit_style_escape): New functions.
6310
6311 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6312
6313         * NEWS: Mention the new set|show may-call-functions.
6314         * infcall.c (may_call_functions_p): New variable.
6315         (show_may_call_functions_p): New function.
6316         (call_function_by_hand_dummy): Throws an error if not
6317         may-call-functions.
6318         (_initialize_infcall): Call add_setshow_boolean_cmd for
6319         may-call-functions.
6320
6321 2019-04-25  Keith Seitz  <keiths@redhat.com>
6322
6323         PR c++/24367
6324         * cp-support.c (inspect_type): Don't attempt substitutions
6325         of symbol with the same name.
6326
6327 2019-04-25  Tom Tromey  <tromey@adacore.com>
6328
6329         PR gdb/24475:
6330         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6331         static.
6332
6333 2019-04-25  Tom Tromey  <tromey@adacore.com>
6334
6335         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6336         rvalue reference.
6337         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6338         (gdb_xml_parser::parse): Use std::move.
6339         * python/python-internal.h (gdbpy_convert_exception): Take a const
6340         reference.
6341         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6342         std::move.
6343         * python/py-utils.c (gdbpy_convert_exception): Take a const
6344         reference.
6345         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6346         Use std::move.
6347         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6348         Use std::move.
6349         * mi/mi-main.c (mi_print_exception): Take a const reference.
6350         * main.c (handle_command_errors): Take a const reference.
6351         * linespec.c (parse_linespec): Use std::move.
6352         * infcall.c (run_inferior_call): Use std::move.
6353         (call_function_by_hand_dummy): Use std::move.
6354         * exec.c (try_open_exec_file): Use std::move.
6355         * exceptions.h (exception_print, exception_fprintf)
6356         (exception_print_same): Update.
6357         * exceptions.c (print_exception, exception_print)
6358         (exception_fprintf, exception_print_same): Change parameters to
6359         const reference.
6360         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6361         * common/new-op.c: Use std::move.
6362         * common/common-exceptions.h (struct gdb_exception): Add move
6363         constructor.
6364         (struct gdb_exception_error, struct gdb_exception_quit, struct
6365         gdb_quit_bad_alloc): Change constructor to move constructor.
6366         (throw_exception): Change parameter to rvalue reference.
6367         * common/common-exceptions.c (throw_exception): Take rvalue
6368         reference.
6369         * cli/cli-interp.c (safe_execute_command): Use std::move.
6370         * breakpoint.c (insert_bp_location, location_to_sals): Use
6371         std::move.
6372
6373 2019-04-25  Tom Tromey  <tromey@adacore.com>
6374
6375         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6376         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6377         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6378         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6379         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6380         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6381         guile/scm-value.c: Use unpack.
6382         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6383         gdbscm_gdb_exception.
6384         (gdbscm_throw_gdb_exception): Likewise.
6385         (struct gdbscm_gdb_exception): New.
6386         (unpack): New function.
6387         (gdbscm_wrap): Use unpack.
6388
6389 2019-04-25  Tom Tromey  <tromey@adacore.com>
6390
6391         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6392         (gdb_rl_callback_handler): Use std::move.
6393         * common/common-exceptions.h (struct gdb_exception): Add move
6394         assignment operator.
6395         (throw_exception_sjlj): Change "exception" to const reference.
6396         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6397         (throw_exception_sjlj): Change "exception" to const reference.
6398
6399 2019-04-25  Tom Tromey  <tromey@adacore.com>
6400
6401         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6402         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6403         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6404         Update.
6405         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6406         Update.
6407         * mi/mi-interp.c (mi_interp::exec): Update.
6408         * linespec.c (parse_linespec): Update.
6409         * infcall.c (run_inferior_call): Update.
6410         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6411         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6412         (gdbscm_lookup_global_symbol): Update.
6413         * guile/scm-param.c (gdbscm_parameter_value): Update.
6414         * guile/scm-frame.c (gdbscm_frame_read_register)
6415         (gdbscm_frame_read_var): Update.
6416         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6417         * exec.c (try_open_exec_file): Update.
6418         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6419         (gdb_rl_callback_handler): Update.
6420         * common/common-exceptions.h (exception_none): Don't declare.
6421         * common/common-exceptions.c (exception_none): Don't define.
6422         (struct catcher) <exception>: Update.
6423         * cli/cli-interp.c (safe_execute_command): Update.
6424         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6425
6426 2019-04-25  Ali Tamur  <tamur@google.com>
6427
6428         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6429         (read_attribute_value): Likewise.
6430         (dwarf2_read_addr_index): Update comment.
6431         (read_str_index): Add DW_FORM_strx.
6432         (dwarf2_string_attr): Likewise.
6433         (dwarf2_const_value_attr): Likewise.
6434         (dump_die_shallow): Likewise.
6435         (dwarf2_fetch_constant_bytes): Likewise.
6436         (skip_form_bytes): Likewise.
6437         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6438
6439 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6440
6441         PR corefiles/11608
6442         PR corefiles/18187
6443         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6444         OFFSET.  Verify if current mapping contains an ELF header.
6445         (linux_find_memory_regions_full): Adjust call to
6446         dump_mapping_p.
6447
6448 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6449             Kang Li <kanglictf@gmail.com>
6450
6451         PR gdb/21600
6452
6453         * dwarf2-frame.c (read_initial_length): Be consistent about using
6454         unsigned representation of length.
6455         (decode_frame_entry_1): Likewise.  Check for wraparound of
6456         end pointer as well as buffer overflow.
6457
6458 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6459
6460         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6461         "vq".
6462
6463 2019-04-24  Tom Tromey  <tromey@adacore.com>
6464
6465         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6466
6467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * s12z-tdep.c (s12z_unwind_pc): Delete.
6470         (s12z_unwind_sp): Delete.
6471         (s12z_gdbarch_init): Don't register deleted functions with
6472         gdbarch.
6473
6474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * rl78-tdep.c (rl78_unwind_sp): Delete.
6477         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6478
6479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6482         (xstormy16_unwind_pc): Delete.
6483         (xstormy16_dummy_id): Delete.
6484         (xstormy16_gdbarch_init): Don't register deleted functions with
6485         gdbarch.
6486
6487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6488
6489         * vax-tdep.c (vax_unwind_pc): Delete.
6490         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6491
6492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * v850-tdep.c (v850_unwind_sp): Delete.
6495         (v850_unwind_pc): Delete.
6496         (v850_dummy_id): Delete.
6497         (v850_gdbarch_init): Don't register deleted functions with
6498         gdbarch.
6499
6500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6501
6502         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6503         (tilegx_unwind_pc): Delete.
6504         (tilegx_unwind_dummy_id): Delete.
6505         (tilegx_gdbarch_init): Don't register deleted functions with
6506         gdbarch.
6507
6508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6509
6510         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6511         (tic6x_dummy_id): Delete.
6512         (tic6x_gdbarch_init): Don't register deleted functions with
6513         gdbarch.
6514
6515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * sparc-tdep.c (sparc_unwind_pc): Delete.
6518         (sparc32_gdbarch_init): Don't register deleted function with
6519         gdbarch.
6520
6521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * sh-tdep.c (sh_unwind_sp): Delete.
6524         (sh_unwind_pc): Delete.
6525         (sh_dummy_id): Delete.
6526         (sh_gdbarch_init): Don't register deleted functions with
6527         gdbarch.
6528
6529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6530
6531         * score-tdep.c (score_unwind_sp): Delete.
6532         (score_unwind_pc): Delete.
6533         (score_dummy_id): Delete.
6534         (score_gdbarch_init): Don't register deleted functions with
6535         gdbarch.
6536
6537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * rx-tdep.c (rx_unwind_pc): Delete.
6540         (rx_unwind_sp): Delete.
6541         (rx_dummy_id): Delete.
6542         (rx_gdbarch_init): Don't register deleted functions with
6543         gdbarch.  Update comment.
6544
6545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6546
6547         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6548         (rs6000_dummy_id): Delete.
6549         (rs6000_gdbarch_init): Don't register deleted functions with
6550         gdbarch.
6551
6552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6553
6554         * or1k-tdep.c (or1k_dummy_id): Delete.
6555         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6556
6557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * nios2-tdep.c (nios2_dummy_id): Delete.
6560         (nios2_unwind_sp): Delete.
6561         (nios2_gdbarch_init): Don't register deleted functions with
6562         gdbarch.
6563
6564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * nds32-tdep.c (nds32_dummy_id): Delete.
6567         (nds32_unwind_pc): Delete.
6568         (nds32_unwind_sp): Delete.
6569         (nds32_gdbarch_init): Don't register deleted functions with
6570         gdbarch.
6571
6572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * msp430-tdep.c (msp430_unwind_pc): Delete.
6575         (msp430_unwind_sp): Delete.
6576         (msp430_dummy_id): Delete.
6577         (msp430_gdbarch_init): Don't register deleted functions with
6578         gdbarch.
6579
6580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6581
6582         * moxie-tdep.c (moxie_unwind_sp): Delete.
6583         (moxie_unwind_pc): Delete.
6584         (moxie_dummy_id): Delete.
6585         (moxie_gdbarch_init): Don't register deleted functions with
6586         gdbarch.
6587
6588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6591         (mn10300_unwind_pc): Delete.
6592         (mn10300_unwind_sp): Delete.
6593         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6594         mn10300_unwind_sp.
6595         (mn10300_frame_unwind_init): Don't register deleted functions with
6596         gdbarch.
6597
6598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6599
6600         * mep-tdep.c (mep_unwind_pc): Delete.
6601         (mep_unwind_sp): Delete.
6602         (mep_dummy_id): Delete.
6603         (mep_gdbarch_init): Don't register deleted functions with
6604         gdbarch.
6605
6606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6607
6608         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6609         (m68hc11_unwind_sp): Delete.
6610         (m68hc11_gdbarch_init): Don't register deleted functions with
6611         gdbarch.
6612
6613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * m32r-tdep.c (m32r_unwind_sp): Delete.
6616         (m32r_unwind_pc): Delete.
6617         (m32r_dummy_id): Delete.
6618         (m32r_gdbarch_init): Don't register deleted functions with
6619         gdbarch.
6620
6621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * m32c-tdep.c (m32c_unwind_pc): Delete.
6624         (m32c_unwind_sp): Delete.
6625         (m32c_dummy_id): Delete.
6626         (m32c_gdbarch_init): Don't register deleted functions with
6627         gdbarch.
6628
6629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6630
6631         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6632         (lm32_unwind_pc): Delete.
6633         (lm32_dummy_id): Delete.
6634         (lm32_gdbarch_init): Don't register deleted functions with
6635         gdbarch.
6636
6637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6638
6639         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6640         (iq2000_unwind_pc): Delete.
6641         (iq2000_dummy_id): Delete.
6642         (iq2000_gdbarch_init): Don't register deleted functions with
6643         gdbarch.
6644
6645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6646
6647         * nds32-tdep.c (nds32_type_align): Delete.
6648         (nds32_push_dummy_call): Use type_align instead.
6649
6650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * arm-tdep.c (arm_type_align): Only handle vector override case.
6653         (arm_push_dummy_call): Use type_align.
6654         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6655
6656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6657
6658         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6659         case.
6660         (pass_on_stack): Use type_align.
6661         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6662         function.
6663
6664 2019-04-23  Tom Tromey  <tromey@adacore.com>
6665
6666         * dwarf2read.c (line_header::file_name_at): Remove unused
6667         overload.
6668
6669 2019-04-23  Tom de Vries  <tdevries@suse.de>
6670
6671         PR gdb/24438
6672         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6673         invocation.
6674
6675
6676 2019-03-27  Ali Tamur  <tamur@google.com>
6677
6678         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6679         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6680         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6681         (dwarf_expr_context::get_addr_index): Likewise
6682         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6683         (symbol_needs_eval_context::get_addr_index): Likewise
6684         (disassemble_dwarf_expression): Add DW_OP_addrx
6685         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6686         (read_cutu_die_from_dwo): Update comment
6687         (skip_one_die): Add DW_FORM_addrx
6688         (read_attribute_value): Likewise
6689         (var_decode_location): Add DW_OP_addrx
6690         (dwarf2_const_value_attr): Add DW_FORM_addrx
6691         (dump_die_shallow): Likewise
6692         (dwarf2_fetch_constant_bytes): Likewise
6693         (decode_locdesc): Add DW_OP_addrx
6694         (skip_form_bytes): Add DW_FORM_addrx
6695
6696 2019-04-22  Ali Tamur  <tamur@google.com>
6697
6698         * MAINTAINERS (Write After Approval): Add self.
6699
6700 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6701
6702         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6703         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6704         (open_symbol_file_object): Likewise.
6705         (svr4_default_sos): Add info parameter.
6706         (svr4_read_so_list): Likewise.
6707         (svr4_current_sos_direct): Adjust functions calls to pass down
6708         info.
6709         (svr4_current_sos_1): Add info parameter.
6710         (svr4_current_sos): Call get_svr4_info, pass info down to
6711         svr4_current_sos_1.
6712         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6713         get_svr4_info.
6714         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6715         get_svr4_info.
6716         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6717         to get_svr4_info.
6718         (probes_table_remove_objfile_probes): Likewise.
6719         (register_solib_event_probe): Add info parameter.
6720         (solist_update_incremental): Pass info parameter down to
6721         svr4_read_so_list.
6722         (disable_probes_interface): Add info parameter.
6723         (svr4_handle_solib_event): Pass current_program_space to
6724         get_svr4_info.  Adjust disable_probes_interface cleanup.
6725         (svr4_create_probe_breakpoints): Add info parameter, pass it
6726         down to register_solib_event_probe.
6727         (svr4_create_solib_event_breakpoints): Add info parameter,
6728         pass it down to svr4_create_probe_breakpoints.
6729         (enable_break): Pass info down to
6730         svr4_create_solib_event_breakpoints.
6731         (svr4_solib_create_inferior_hook): Pass current_program_space to
6732         get_svr4_info.
6733         (svr4_clear_solib): Likewise.
6734
6735 2019-04-22  Pedro Alves  <palves@redhat.com>
6736
6737         * solib-svr4.c (svr4_free_objfile_observer): New.
6738         (probe_and_action::objfile): New field.
6739         (probes_table_htab_remove_objfile_probes)
6740         (probes_table_remove_objfile_probes): New functions.
6741         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6742         in the new probe_and_action.  Don't store the probe in 'lookup'.
6743         (svr4_create_probe_breakpoints): Pass objfile to
6744         register_solib_event_probe.
6745         (_initialize_svr4_solib): Register a free_objfile observer.
6746
6747 2019-04-19  Tom Tromey  <tom@tromey.com>
6748
6749         * common/queue.h: Remove.
6750
6751 2019-04-19  Tom Tromey  <tom@tromey.com>
6752
6753         * event-loop.c: Don't include "common/queue.h".
6754
6755 2019-04-19  Tom Tromey  <tom@tromey.com>
6756
6757         * remote.c (remote_target): Use delete.
6758         * remote-notif.h: Include <list>, not "common/queue.h".
6759         (notif_client_p): Remove typedef.
6760         (remote_notif_state): Add constructor, destructor, initializer.
6761         <notif_queue>: Now a std::list.
6762         (remote_notif_state_xfree): Don't declare.
6763         * remote-notif.c (remote_notif_process, handle_notification)
6764         (remote_notif_state_allocate): Update.
6765         (~remote_notif_state): Rename from remote_notif_state_xfree.
6766
6767 2019-04-19  Tom Tromey  <tom@tromey.com>
6768
6769         * symfile.c (reread_symbols): Update.
6770         * objfiles.c (objfile_register_static_link)
6771         (objfile_lookup_static_link): Update
6772         (~objfile) Don't delete static_links.
6773         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6774
6775 2019-04-19  Tom Tromey  <tom@tromey.com>
6776
6777         * type-stack.h (struct type_stack) <insert>: Constify string.
6778         * type-stack.c (type_stack::insert): Constify string.
6779         * gdbtypes.h (lookup_template_type): Update.
6780         (address_space_name_to_int): Update.
6781         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6782         const.
6783         (lookup_template_type): Make name const.
6784         * c-exp.y: Update rules.
6785         (lex_one_token, classify_name, classify_inner_name)
6786         (c_print_token): Update.
6787         * p-exp.y: Update rules.
6788         (yylex): Update.
6789         * f-exp.y: Update rules.
6790         (yylex): Update.
6791         * d-exp.y: Update rules.
6792         (lex_one_token, classify_name, classify_inner_name): Update.
6793         * parse.c (write_dollar_variable, copy_name): Return std::string.
6794         * parser-defs.h (copy_name): Change return type.
6795         * m2-exp.y: Update rules.
6796         (yylex): Update.
6797         * go-exp.y (lex_one_token): Update.
6798         Update rules.
6799         (classify_unsafe_function, classify_packaged_name)
6800         (classify_name, yylex): Update.
6801
6802 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6803
6804         * configure.ac: add --enable-source-highlight switch.
6805         * configure: Regenerate.
6806         * top.c (print_gdb_version): plumb --enable-source-highlight
6807         status to "show configuration".
6808
6809 2019-04-19  Tom Tromey  <tromey@adacore.com>
6810
6811         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6812         Check ADA_TYPE_P.
6813         (empty_record, ada_template_to_fixed_record_type_1)
6814         (template_to_static_fixed_type)
6815         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6816         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6817         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6818         macros.
6819
6820 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6821
6822         PR symtab/24423:
6823         * source.c (print_source_lines_base): Advance "iter" when a
6824         control character is seen.
6825
6826 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6827
6828         * inferior.h (struct infcall_suspend_state_deleter):
6829         Catch exception in destructor to avoid crash.
6830
6831 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6832
6833         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6834         close to the add_com "shell".
6835
6836 2019-04-18  Tom Tromey  <tromey@adacore.com>
6837
6838         * process-stratum-target.h (class process_stratum_target)
6839         <stratum>: Add "final".
6840
6841 2019-04-17  Tom Tromey  <tromey@adacore.com>
6842
6843         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6844         against nullptr before use.
6845
6846 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6847
6848         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6849
6850 2019-04-17  Jim Wilson  <jimw@sifive.com>
6851             Andrew Burgess  <andrew.burgess@embecosm.com>
6852
6853         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6854         code read might fail, assume 4-byte breakpoint in that case.
6855
6856 2019-04-15  Leszek Swirski  <leszeks@google.com>
6857
6858         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6859         rather than a hand-rolled POD check when checking for forced MEMORY
6860         classification.
6861
6862 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6863
6864         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6865         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6866         function.
6867         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6868         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6869         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6870         declaration.
6871
6872 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6873
6874         * aarch64-linux-nat.c
6875         (aarch64_linux_nat_target::thread_architecture): Add override.
6876         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6877         each VQ.
6878
6879 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6880
6881         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6882
6883 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6884
6885         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6886         target types of size 96-bits, add some additional comments, and
6887         check that the builtin type we found was the correct size.
6888
6889 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6890
6891         * utils.c (prompt_for_continue): Don't restore the styling at the
6892         end, as applied_style has the wrong value.  This fixes styling in
6893         long lists of file names that are interrupted by the "Continue?"
6894         prompt.
6895
6896 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6897
6898         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6899         * c-lang.c (c_language_defn): Likewise.
6900         (cplus_language_defn): Likewise.
6901         (asm_language_defn): Likewise.
6902         (minimal_language_defn): Likewise.
6903         * d-lang.c (d_language_defn): Likewise.
6904         * f-lang.c (f_language_defn): Likewise.
6905         * go-lang.c (go_language_defn): Likewise.
6906         * language.c (unknown_language_defn): Likewise.
6907         (auto_language_defn): Likewise.
6908         * language.h (struct language_defn): Remove la_magic field.
6909         (LANG_MAGIC): Delete.
6910         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6911         * objc-lang.c (objc_language_defn): Likewise.
6912         * opencl-lang.c (opencl_language_defn): Likewise.
6913         * p-lang.c (pascal_language_defn): Likewise.
6914         * rust-lang.c (rust_language_defn): Likewise.
6915
6916 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6917
6918         * riscv-tdep.c (riscv_type_align): New function.
6919         (riscv_type_alignment): Delete.
6920         (riscv_arg_location): Use 'type_align'.
6921         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6922
6923 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6924
6925         * gdbtypes.c (type_align): A struct with no non-static fields also
6926         has alignment of 1.
6927
6928 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6929
6930         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6931         component to 0.
6932         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6933         member.
6934         (riscv_struct_info::analyse): New implementation using new
6935         analyse_inner member function.
6936         (riscv_struct_info::field_offset): New member function.
6937         (riscv_struct_info::m_offsets): New member variable.
6938         (riscv_struct_info::analyse_inner): New private member function,
6939         takes the old implementation of riscv_struct_info::analyse but
6940         extended to track field offsets.
6941         (riscv_call_arg_struct): Update the struct folding special cases
6942         to handle cases where empty C++ structs, which are non-zero
6943         length, are found.
6944         (riscv_arg_location): Initialise the length of each location, a
6945         non-zero length now indicates the location is in use.
6946         (riscv_push_dummy_call): Allow for the first location having a
6947         non-zero offset when setting up arguments.
6948         (riscv_return_value): Likewise, but for return values.
6949
6950 2019-04-11  Tom Tromey  <tromey@adacore.com>
6951
6952         * utils.c (internal_vproblem): Make "msg" const.
6953
6954 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6955
6956         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6957         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6958         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6959         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6960
6961 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6962
6963         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6964         function.
6965         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6966         of amd64_collect_native_gregset.
6967         (amd64_linux_nat_target::store_registers): Likewise.
6968
6969 2019-04-10  Tom Tromey  <tom@tromey.com>
6970
6971         * symtab.c (lookup_global_symbol_from_objfile)
6972         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6973         * objfiles.h (class separate_debug_iterator): New.
6974         (class separate_debug_range): New.
6975         (struct objfile) <separate_debug_objfiles>: New method.
6976         (objfile_separate_debug_iterate): Don't declare.
6977         * objfiles.c (separate_debug_iterator::operator++): Rename from
6978         objfile_separate_debug_iterate.
6979         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6980         iterator.
6981         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6982         iterator.
6983
6984 2019-04-10  Tom Tromey  <tom@tromey.com>
6985
6986         * symfile.c (reread_symbols): Remove old comment.
6987         * objfiles.c (free_all_objfiles): Fix a typo.
6988
6989 2019-04-10  Tom Tromey  <tom@tromey.com>
6990
6991         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6992         * minsyms.c (lookup_minimal_symbol): Use foreach.
6993         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6994         (lookup_minimal_symbol_solib_trampoline): Likewise.
6995         * symfile.c (reread_symbols): Use foreach.
6996
6997 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6998             Tom Tromey  <tromey@adacore.com>
6999
7000         PR rust/24414:
7001         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7002         (rust_lex_int_test): Change "value" to be LONGEST.
7003         (rust_lex_tests): Add test for long integer literal.
7004
7005 2019-04-09  Tom Tromey  <tromey@adacore.com>
7006
7007         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7008         to bool.
7009         (extended_remote_target::attach): Update.
7010         (remote_target::remote_notice_new_inferior): Update.
7011         (remote_target::add_current_inferior_and_thread): Update.
7012         * inferior.c (exit_inferior_1): Use "false".
7013         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7014
7015 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7016
7017         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7018         the "start" command.
7019
7020 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7021
7022         * python/py-inferior.c (infpy_thread_from_thread_handle):
7023         Adjust comments to reflect renaming of thread_from_thread_handle
7024         to thread_from_handle.  Adjust keywords.  Fix type error message.
7025         (inferior_object_methods): Add thread_from_handle.  Retain
7026         thread_from_thread_handle, but mark it as deprecated.
7027
7028 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7029
7030         * gdbthread.h (find_thread_by_handle): Revise declaration.
7031         * thread.c (find_thread_by_handle): Likewise.  Adjust
7032         implementation too.
7033         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7034         support for buffer objects as handles.
7035
7036 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7037
7038         * python/py-infthread.c (thpy_thread_handle): New function.
7039         (thread_object_methods): Register thpy_thread_handle.
7040
7041 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7042
7043         * gdbthread.h (thread_to_thread_handle): Declare.
7044         * thread.c (gdbtypes.h): Include.
7045         (thread_to_thread_handle): New function.
7046
7047         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7048         (target_thread_info_to_thread_handle): Declare.
7049         * target.c (target_thread_info_to_thread_handle): New function.
7050         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7051         * target-delegates.c: Regenerate.
7052
7053         * linux-thread-db.c (class thread_db_target): Add method
7054         thread_info_to_thread_handle.
7055         (thread_db_target::thread_info_to_thread_handle): Define.
7056         * remote.c (class remote_target): Add new method
7057         thread_info_to_thread_handle.
7058         (remote_target::thread_info_to_thread_handle): Define.
7059
7060 2019-04-08  Pedro Alves  <palves@redhat.com>
7061
7062         * common/common-exceptions.c (throw_exception): Don't create
7063         named object to throw; throw directly.
7064         (throw_it): Likewise.  Don't initialize gdb_exception::message
7065         here, with new; pass FMT and AP to the ctor instead.
7066         * common/common-exceptions.h: Include <string>.
7067         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7068         const char *, va_list)): New ctor.  Use std::make_shared.
7069         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7070         errors)): Delete.
7071         (gdb_exception_error::gdb_exception_error(enum errors, const char
7072         *, va_list)): New.
7073         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7074         Add assertion.
7075         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7076         errors)): Delete.
7077         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7078         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7079         Add assertion.
7080
7081 2019-04-08  Tom Tromey  <tom@tromey.com>
7082
7083         * valops.c (value_rtti_indirect_type): Replace throw_exception
7084         with throw.
7085         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7086         with throw.
7087         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7088         throw.
7089         * target.c (target_translate_tls_address): Replace throw_exception
7090         with throw.
7091         * stack.c (frame_apply_command_count): Replace throw_exception
7092         with throw.
7093         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7094         throw.
7095         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7096         with throw.
7097         * rs6000-tdep.c (rs6000_frame_cache)
7098         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7099         * remote.c: Replace throw_exception with throw.
7100         * record-full.c (record_full_message, record_full_wait_1)
7101         (record_full_restore): Replace throw_exception with throw.
7102         * record-btrace.c:
7103         (get_thread_current_frame_id, record_btrace_start_replaying)
7104         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7105         (cmd_record_btrace_start): Replace throw_exception with throw.
7106         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7107         throw.
7108         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7109         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7110         * linespec.c:
7111         (find_linespec_symbols): Replace throw_exception with throw.
7112         * infrun.c (displaced_step_prepare, resume): Replace
7113         throw_exception with throw.
7114         * infcmd.c (post_create_inferior): Replace throw_exception with
7115         throw.
7116         * inf-loop.c (inferior_event_handler): Replace throw_exception
7117         with throw.
7118         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7119         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7120         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7121         (get_prev_frame_always, get_frame_pc_if_available)
7122         (get_frame_address_in_block_if_available, get_frame_language):
7123         Replace throw_exception with throw.
7124         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7125         throw_exception with throw.
7126         * eval.c (fetch_subexp_value, evaluate_var_value)
7127         (evaluate_funcall, evaluate_subexp_standard): Replace
7128         throw_exception with throw.
7129         * dwarf2loc.c (call_site_find_chain)
7130         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7131         Replace throw_exception with throw.
7132         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7133         with throw.
7134         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7135         throw.
7136         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7137         * completer.c (complete_line_internal): Replace throw_exception
7138         with throw.
7139         * compile/compile-object-run.c (compile_object_run): Replace
7140         throw_exception with throw.
7141         * cli/cli-script.c (process_next_line): Replace throw_exception
7142         with throw.
7143         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7144         (btrace_enable, btrace_maint_update_pt_packets): Replace
7145         throw_exception with throw.
7146         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7147         throw_exception with throw.
7148         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7149         throw_exception with throw.
7150         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7151         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7152         * aarch64-tdep.c (aarch64_make_prologue_cache)
7153         (aarch64_make_stub_cache): Replace throw_exception with throw.
7154
7155 2019-04-08  Tom Tromey  <tom@tromey.com>
7156
7157         * common/common-exceptions.c (throw_exception): Rename from
7158         throw_exception_cxx.  Remove old copy.  Make argument const.
7159         (throw_it): Create and throw exception objects directly.
7160         * common/common-exceptions.h (throw_exception): Make argument
7161         const.
7162         (struct gdb_exception_error): Add constructor.
7163         (struct gdb_exception_quit): Add constructor.
7164
7165 2019-04-08  Tom Tromey  <tom@tromey.com>
7166
7167         * common/common-exceptions.h (exception_rethrow): Don't declare.
7168         (TRY_SJLJ): Update comment.
7169         (TRY, CATCH, END_CATCH): Remove.
7170         * common/common-exceptions.c (exception_rethrow): Remove.
7171
7172 2019-04-08  Tom Tromey  <tom@tromey.com>
7173
7174         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7175         Remove.
7176         (gdb_exception_error): Rename from
7177         gdb_exception_RETURN_MASK_ERROR.
7178         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7179         (gdb_quit_bad_alloc): Update.
7180         * aarch64-tdep.c: Update.
7181         * ada-lang.c: Update.
7182         * ada-typeprint.c: Update.
7183         * ada-valprint.c: Update.
7184         * amd64-tdep.c: Update.
7185         * arch-utils.c: Update.
7186         * break-catch-throw.c: Update.
7187         * breakpoint.c: Update.
7188         * btrace.c: Update.
7189         * c-varobj.c: Update.
7190         * cli/cli-cmds.c: Update.
7191         * cli/cli-interp.c: Update.
7192         * cli/cli-script.c: Update.
7193         * common/common-exceptions.c: Update.
7194         * common/new-op.c: Update.
7195         * common/selftest.c: Update.
7196         * compile/compile-c-symbols.c: Update.
7197         * compile/compile-cplus-symbols.c: Update.
7198         * compile/compile-object-load.c: Update.
7199         * compile/compile-object-run.c: Update.
7200         * completer.c: Update.
7201         * corelow.c: Update.
7202         * cp-abi.c: Update.
7203         * cp-support.c: Update.
7204         * cp-valprint.c: Update.
7205         * darwin-nat.c: Update.
7206         * disasm-selftests.c: Update.
7207         * dtrace-probe.c: Update.
7208         * dwarf-index-cache.c: Update.
7209         * dwarf-index-write.c: Update.
7210         * dwarf2-frame-tailcall.c: Update.
7211         * dwarf2-frame.c: Update.
7212         * dwarf2loc.c: Update.
7213         * dwarf2read.c: Update.
7214         * eval.c: Update.
7215         * event-loop.c: Update.
7216         * event-top.c: Update.
7217         * exec.c: Update.
7218         * f-valprint.c: Update.
7219         * fbsd-tdep.c: Update.
7220         * frame-unwind.c: Update.
7221         * frame.c: Update.
7222         * gdbtypes.c: Update.
7223         * gnu-v3-abi.c: Update.
7224         * guile/guile-internal.h: Update.
7225         * guile/scm-block.c: Update.
7226         * guile/scm-breakpoint.c: Update.
7227         * guile/scm-cmd.c: Update.
7228         * guile/scm-disasm.c: Update.
7229         * guile/scm-frame.c: Update.
7230         * guile/scm-lazy-string.c: Update.
7231         * guile/scm-math.c: Update.
7232         * guile/scm-param.c: Update.
7233         * guile/scm-ports.c: Update.
7234         * guile/scm-pretty-print.c: Update.
7235         * guile/scm-symbol.c: Update.
7236         * guile/scm-symtab.c: Update.
7237         * guile/scm-type.c: Update.
7238         * guile/scm-value.c: Update.
7239         * i386-linux-tdep.c: Update.
7240         * i386-tdep.c: Update.
7241         * inf-loop.c: Update.
7242         * infcall.c: Update.
7243         * infcmd.c: Update.
7244         * infrun.c: Update.
7245         * jit.c: Update.
7246         * language.c: Update.
7247         * linespec.c: Update.
7248         * linux-fork.c: Update.
7249         * linux-nat.c: Update.
7250         * linux-tdep.c: Update.
7251         * linux-thread-db.c: Update.
7252         * main.c: Update.
7253         * mi/mi-cmd-break.c: Update.
7254         * mi/mi-cmd-stack.c: Update.
7255         * mi/mi-interp.c: Update.
7256         * mi/mi-main.c: Update.
7257         * objc-lang.c: Update.
7258         * p-valprint.c: Update.
7259         * parse.c: Update.
7260         * ppc-linux-tdep.c: Update.
7261         * printcmd.c: Update.
7262         * python/py-arch.c: Update.
7263         * python/py-breakpoint.c: Update.
7264         * python/py-cmd.c: Update.
7265         * python/py-finishbreakpoint.c: Update.
7266         * python/py-frame.c: Update.
7267         * python/py-framefilter.c: Update.
7268         * python/py-gdb-readline.c: Update.
7269         * python/py-inferior.c: Update.
7270         * python/py-infthread.c: Update.
7271         * python/py-lazy-string.c: Update.
7272         * python/py-linetable.c: Update.
7273         * python/py-objfile.c: Update.
7274         * python/py-param.c: Update.
7275         * python/py-prettyprint.c: Update.
7276         * python/py-progspace.c: Update.
7277         * python/py-record-btrace.c: Update.
7278         * python/py-record.c: Update.
7279         * python/py-symbol.c: Update.
7280         * python/py-type.c: Update.
7281         * python/py-unwind.c: Update.
7282         * python/py-utils.c: Update.
7283         * python/py-value.c: Update.
7284         * python/python.c: Update.
7285         * record-btrace.c: Update.
7286         * record-full.c: Update.
7287         * remote-fileio.c: Update.
7288         * remote.c: Update.
7289         * riscv-tdep.c: Update.
7290         * rs6000-aix-tdep.c: Update.
7291         * rs6000-tdep.c: Update.
7292         * rust-exp.y: Update.
7293         * rust-lang.c: Update.
7294         * s390-tdep.c: Update.
7295         * selftest-arch.c: Update.
7296         * solib-dsbt.c: Update.
7297         * solib-frv.c: Update.
7298         * solib-spu.c: Update.
7299         * solib-svr4.c: Update.
7300         * solib.c: Update.
7301         * sparc64-linux-tdep.c: Update.
7302         * stack.c: Update.
7303         * symfile-mem.c: Update.
7304         * symmisc.c: Update.
7305         * target.c: Update.
7306         * thread.c: Update.
7307         * top.c: Update.
7308         * tracefile-tfile.c: Update.
7309         * tui/tui.c: Update.
7310         * typeprint.c: Update.
7311         * unittests/cli-utils-selftests.c: Update.
7312         * unittests/parse-connection-spec-selftests.c: Update.
7313         * valops.c: Update.
7314         * valprint.c: Update.
7315         * value.c: Update.
7316         * varobj.c: Update.
7317         * windows-nat.c: Update.
7318         * x86-linux-nat.c: Update.
7319         * xml-support.c: Update.
7320
7321 2019-04-08  Tom Tromey  <tom@tromey.com>
7322
7323         * xml-support.c: Use C++ exception handling.
7324         * x86-linux-nat.c: Use C++ exception handling.
7325         * windows-nat.c: Use C++ exception handling.
7326         * varobj.c: Use C++ exception handling.
7327         * value.c: Use C++ exception handling.
7328         * valprint.c: Use C++ exception handling.
7329         * valops.c: Use C++ exception handling.
7330         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7331         handling.
7332         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7333         * typeprint.c: Use C++ exception handling.
7334         * tui/tui.c: Use C++ exception handling.
7335         * tracefile-tfile.c: Use C++ exception handling.
7336         * top.c: Use C++ exception handling.
7337         * thread.c: Use C++ exception handling.
7338         * target.c: Use C++ exception handling.
7339         * symmisc.c: Use C++ exception handling.
7340         * symfile-mem.c: Use C++ exception handling.
7341         * stack.c: Use C++ exception handling.
7342         * sparc64-linux-tdep.c: Use C++ exception handling.
7343         * solib.c: Use C++ exception handling.
7344         * solib-svr4.c: Use C++ exception handling.
7345         * solib-spu.c: Use C++ exception handling.
7346         * solib-frv.c: Use C++ exception handling.
7347         * solib-dsbt.c: Use C++ exception handling.
7348         * selftest-arch.c: Use C++ exception handling.
7349         * s390-tdep.c: Use C++ exception handling.
7350         * rust-lang.c: Use C++ exception handling.
7351         * rust-exp.y: Use C++ exception handling.
7352         * rs6000-tdep.c: Use C++ exception handling.
7353         * rs6000-aix-tdep.c: Use C++ exception handling.
7354         * riscv-tdep.c: Use C++ exception handling.
7355         * remote.c: Use C++ exception handling.
7356         * remote-fileio.c: Use C++ exception handling.
7357         * record-full.c: Use C++ exception handling.
7358         * record-btrace.c: Use C++ exception handling.
7359         * python/python.c: Use C++ exception handling.
7360         * python/py-value.c: Use C++ exception handling.
7361         * python/py-utils.c: Use C++ exception handling.
7362         * python/py-unwind.c: Use C++ exception handling.
7363         * python/py-type.c: Use C++ exception handling.
7364         * python/py-symbol.c: Use C++ exception handling.
7365         * python/py-record.c: Use C++ exception handling.
7366         * python/py-record-btrace.c: Use C++ exception handling.
7367         * python/py-progspace.c: Use C++ exception handling.
7368         * python/py-prettyprint.c: Use C++ exception handling.
7369         * python/py-param.c: Use C++ exception handling.
7370         * python/py-objfile.c: Use C++ exception handling.
7371         * python/py-linetable.c: Use C++ exception handling.
7372         * python/py-lazy-string.c: Use C++ exception handling.
7373         * python/py-infthread.c: Use C++ exception handling.
7374         * python/py-inferior.c: Use C++ exception handling.
7375         * python/py-gdb-readline.c: Use C++ exception handling.
7376         * python/py-framefilter.c: Use C++ exception handling.
7377         * python/py-frame.c: Use C++ exception handling.
7378         * python/py-finishbreakpoint.c: Use C++ exception handling.
7379         * python/py-cmd.c: Use C++ exception handling.
7380         * python/py-breakpoint.c: Use C++ exception handling.
7381         * python/py-arch.c: Use C++ exception handling.
7382         * printcmd.c: Use C++ exception handling.
7383         * ppc-linux-tdep.c: Use C++ exception handling.
7384         * parse.c: Use C++ exception handling.
7385         * p-valprint.c: Use C++ exception handling.
7386         * objc-lang.c: Use C++ exception handling.
7387         * mi/mi-main.c: Use C++ exception handling.
7388         * mi/mi-interp.c: Use C++ exception handling.
7389         * mi/mi-cmd-stack.c: Use C++ exception handling.
7390         * mi/mi-cmd-break.c: Use C++ exception handling.
7391         * main.c: Use C++ exception handling.
7392         * linux-thread-db.c: Use C++ exception handling.
7393         * linux-tdep.c: Use C++ exception handling.
7394         * linux-nat.c: Use C++ exception handling.
7395         * linux-fork.c: Use C++ exception handling.
7396         * linespec.c: Use C++ exception handling.
7397         * language.c: Use C++ exception handling.
7398         * jit.c: Use C++ exception handling.
7399         * infrun.c: Use C++ exception handling.
7400         * infcmd.c: Use C++ exception handling.
7401         * infcall.c: Use C++ exception handling.
7402         * inf-loop.c: Use C++ exception handling.
7403         * i386-tdep.c: Use C++ exception handling.
7404         * i386-linux-tdep.c: Use C++ exception handling.
7405         * guile/scm-value.c: Use C++ exception handling.
7406         * guile/scm-type.c: Use C++ exception handling.
7407         * guile/scm-symtab.c: Use C++ exception handling.
7408         * guile/scm-symbol.c: Use C++ exception handling.
7409         * guile/scm-pretty-print.c: Use C++ exception handling.
7410         * guile/scm-ports.c: Use C++ exception handling.
7411         * guile/scm-param.c: Use C++ exception handling.
7412         * guile/scm-math.c: Use C++ exception handling.
7413         * guile/scm-lazy-string.c: Use C++ exception handling.
7414         * guile/scm-frame.c: Use C++ exception handling.
7415         * guile/scm-disasm.c: Use C++ exception handling.
7416         * guile/scm-cmd.c: Use C++ exception handling.
7417         * guile/scm-breakpoint.c: Use C++ exception handling.
7418         * guile/scm-block.c: Use C++ exception handling.
7419         * guile/guile-internal.h: Use C++ exception handling.
7420         * gnu-v3-abi.c: Use C++ exception handling.
7421         * gdbtypes.c: Use C++ exception handling.
7422         * frame.c: Use C++ exception handling.
7423         * frame-unwind.c: Use C++ exception handling.
7424         * fbsd-tdep.c: Use C++ exception handling.
7425         * f-valprint.c: Use C++ exception handling.
7426         * exec.c: Use C++ exception handling.
7427         * event-top.c: Use C++ exception handling.
7428         * event-loop.c: Use C++ exception handling.
7429         * eval.c: Use C++ exception handling.
7430         * dwarf2read.c: Use C++ exception handling.
7431         * dwarf2loc.c: Use C++ exception handling.
7432         * dwarf2-frame.c: Use C++ exception handling.
7433         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7434         * dwarf-index-write.c: Use C++ exception handling.
7435         * dwarf-index-cache.c: Use C++ exception handling.
7436         * dtrace-probe.c: Use C++ exception handling.
7437         * disasm-selftests.c: Use C++ exception handling.
7438         * darwin-nat.c: Use C++ exception handling.
7439         * cp-valprint.c: Use C++ exception handling.
7440         * cp-support.c: Use C++ exception handling.
7441         * cp-abi.c: Use C++ exception handling.
7442         * corelow.c: Use C++ exception handling.
7443         * completer.c: Use C++ exception handling.
7444         * compile/compile-object-run.c: Use C++ exception handling.
7445         * compile/compile-object-load.c: Use C++ exception handling.
7446         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7447         * compile/compile-c-symbols.c: Use C++ exception handling.
7448         * common/selftest.c: Use C++ exception handling.
7449         * common/new-op.c: Use C++ exception handling.
7450         * cli/cli-script.c: Use C++ exception handling.
7451         * cli/cli-interp.c: Use C++ exception handling.
7452         * cli/cli-cmds.c: Use C++ exception handling.
7453         * c-varobj.c: Use C++ exception handling.
7454         * btrace.c: Use C++ exception handling.
7455         * breakpoint.c: Use C++ exception handling.
7456         * break-catch-throw.c: Use C++ exception handling.
7457         * arch-utils.c: Use C++ exception handling.
7458         * amd64-tdep.c: Use C++ exception handling.
7459         * ada-valprint.c: Use C++ exception handling.
7460         * ada-typeprint.c: Use C++ exception handling.
7461         * ada-lang.c: Use C++ exception handling.
7462         * aarch64-tdep.c: Use C++ exception handling.
7463
7464 2019-04-08  Tom Tromey  <tom@tromey.com>
7465
7466         * xml-support.c (gdb_xml_parser::parse): Update.
7467         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7468         * value.c (show_convenience): Update.
7469         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7470         (test_parse_flags_qcs): Update.
7471         * thread.c (thr_try_catch_cmd): Update.
7472         * target.c (target_translate_tls_address): Update.
7473         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7474         (info_frame_command_core, frame_apply_command_count): Update.
7475         * rust-exp.y (rust_lex_exception_test): Update.
7476         * riscv-tdep.c (riscv_print_one_register_info): Update.
7477         * remote.c (remote_target::enable_btrace): Update.
7478         * record-btrace.c (record_btrace_enable_warn): Update.
7479         * python/py-utils.c (gdbpy_convert_exception): Update.
7480         * printcmd.c (do_one_display, print_variable_and_value): Update.
7481         * mi/mi-main.c (mi_print_exception): Update.
7482         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7483         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7484         * linux-nat.c (linux_nat_target::attach): Update.
7485         * linux-fork.c (class scoped_switch_fork_info): Update.
7486         * infrun.c (displaced_step_prepare): Update.
7487         * infcall.c (call_function_by_hand_dummy): Update.
7488         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7489         * gnu-v3-abi.c (print_one_vtable): Update.
7490         * frame.c (get_prev_frame_always): Update.
7491         * f-valprint.c (info_common_command_for_block): Update.
7492         * exec.c (try_open_exec_file): Update.
7493         * exceptions.c (print_exception, exception_print)
7494         (exception_fprintf, exception_print_same): Update.
7495         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7496         * dwarf-index-cache.c (index_cache::store)
7497         (index_cache::lookup_gdb_index): Update.
7498         * darwin-nat.c (maybe_cache_shell): Update.
7499         * cp-valprint.c (cp_print_value_fields): Update.
7500         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7501         (gcc_cplus_symbol_address): Update.
7502         * compile/compile-c-symbols.c (gcc_convert_symbol)
7503         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7504         * common/selftest.c: Update.
7505         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7506         a std::string.
7507         (exception_try_scope_entry, exception_try_scope_exit): Don't
7508         declare.
7509         (struct exception_try_scope): Remove.
7510         (TRY): Don't use exception_try_scope.
7511         (struct gdb_exception): Add constructor, operator=.
7512         <what>: New method.
7513         (struct gdb_exception_RETURN_MASK_ALL)
7514         (struct gdb_exception_RETURN_MASK_ERROR)
7515         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7516         (struct gdb_quit_bad_alloc): Update.
7517         * common/common-exceptions.c (exception_none): Change
7518         initializer.
7519         (struct catcher) <state, exception>: Initialize inline.
7520         <prev>: Remove member.
7521         (current_catcher): Remove.
7522         (catchers): New global.
7523         (exceptions_state_mc_init): Simplify.
7524         (catcher_pop): Remove.
7525         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7526         (try_scope_depth, exception_try_scope_entry)
7527         (exception_try_scope_exit): Remove.
7528         (throw_exception_sjlj): Update.
7529         (exception_messages, exception_messages_size): Remove.
7530         (throw_it): Simplify.
7531         (gdb_exception_sliced_copy): Remove.
7532         (throw_exception_cxx): Update.
7533         * cli/cli-script.c (script_from_file): Update.
7534         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7535         Update.
7536         * ada-valprint.c (ada_val_print): Update.
7537         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7538         (create_excep_cond_exprs): Update.
7539
7540 2019-04-08  Tom Tromey  <tom@tromey.com>
7541
7542         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7543         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7544         (TRY, CATCH, END_CATCH): Remove some definitions.
7545         * common/common-exceptions.c: Don't use GDB_XCPT.
7546         (catcher_list_size): Remove.
7547         (throw_exception, throw_it): Simplify.
7548
7549 2019-04-05  Tom Tromey  <tom@tromey.com>
7550
7551         Revert the header-sorting patch.
7552         * ft32-tdep.c: Revert.
7553         * frv-tdep.c: Revert.
7554         * frv-linux-tdep.c: Revert.
7555         * frame.c: Revert.
7556         * frame-unwind.c: Revert.
7557         * frame-base.c: Revert.
7558         * fork-child.c: Revert.
7559         * findvar.c: Revert.
7560         * findcmd.c: Revert.
7561         * filesystem.c: Revert.
7562         * filename-seen-cache.h: Revert.
7563         * filename-seen-cache.c: Revert.
7564         * fbsd-tdep.c: Revert.
7565         * fbsd-nat.h: Revert.
7566         * fbsd-nat.c: Revert.
7567         * f-valprint.c: Revert.
7568         * f-typeprint.c: Revert.
7569         * f-lang.c: Revert.
7570         * extension.h: Revert.
7571         * extension.c: Revert.
7572         * extension-priv.h: Revert.
7573         * expprint.c: Revert.
7574         * exec.h: Revert.
7575         * exec.c: Revert.
7576         * exceptions.c: Revert.
7577         * event-top.c: Revert.
7578         * event-loop.c: Revert.
7579         * eval.c: Revert.
7580         * elfread.c: Revert.
7581         * dwarf2read.h: Revert.
7582         * dwarf2read.c: Revert.
7583         * dwarf2loc.c: Revert.
7584         * dwarf2expr.h: Revert.
7585         * dwarf2expr.c: Revert.
7586         * dwarf2-frame.c: Revert.
7587         * dwarf2-frame-tailcall.c: Revert.
7588         * dwarf-index-write.h: Revert.
7589         * dwarf-index-write.c: Revert.
7590         * dwarf-index-common.c: Revert.
7591         * dwarf-index-cache.h: Revert.
7592         * dwarf-index-cache.c: Revert.
7593         * dummy-frame.c: Revert.
7594         * dtrace-probe.c: Revert.
7595         * disasm.h: Revert.
7596         * disasm.c: Revert.
7597         * disasm-selftests.c: Revert.
7598         * dictionary.c: Revert.
7599         * dicos-tdep.c: Revert.
7600         * demangle.c: Revert.
7601         * dcache.h: Revert.
7602         * dcache.c: Revert.
7603         * darwin-nat.h: Revert.
7604         * darwin-nat.c: Revert.
7605         * darwin-nat-info.c: Revert.
7606         * d-valprint.c: Revert.
7607         * d-namespace.c: Revert.
7608         * d-lang.c: Revert.
7609         * ctf.c: Revert.
7610         * csky-tdep.c: Revert.
7611         * csky-linux-tdep.c: Revert.
7612         * cris-tdep.c: Revert.
7613         * cris-linux-tdep.c: Revert.
7614         * cp-valprint.c: Revert.
7615         * cp-support.c: Revert.
7616         * cp-namespace.c: Revert.
7617         * cp-abi.c: Revert.
7618         * corelow.c: Revert.
7619         * corefile.c: Revert.
7620         * continuations.c: Revert.
7621         * completer.h: Revert.
7622         * completer.c: Revert.
7623         * complaints.c: Revert.
7624         * coffread.c: Revert.
7625         * coff-pe-read.c: Revert.
7626         * cli-out.h: Revert.
7627         * cli-out.c: Revert.
7628         * charset.c: Revert.
7629         * c-varobj.c: Revert.
7630         * c-valprint.c: Revert.
7631         * c-typeprint.c: Revert.
7632         * c-lang.c: Revert.
7633         * buildsym.c: Revert.
7634         * buildsym-legacy.c: Revert.
7635         * build-id.h: Revert.
7636         * build-id.c: Revert.
7637         * btrace.c: Revert.
7638         * bsd-uthread.c: Revert.
7639         * breakpoint.h: Revert.
7640         * breakpoint.c: Revert.
7641         * break-catch-throw.c: Revert.
7642         * break-catch-syscall.c: Revert.
7643         * break-catch-sig.c: Revert.
7644         * blockframe.c: Revert.
7645         * block.c: Revert.
7646         * bfin-tdep.c: Revert.
7647         * bfin-linux-tdep.c: Revert.
7648         * bfd-target.c: Revert.
7649         * bcache.c: Revert.
7650         * ax-general.c: Revert.
7651         * ax-gdb.h: Revert.
7652         * ax-gdb.c: Revert.
7653         * avr-tdep.c: Revert.
7654         * auxv.c: Revert.
7655         * auto-load.c: Revert.
7656         * arm-wince-tdep.c: Revert.
7657         * arm-tdep.c: Revert.
7658         * arm-symbian-tdep.c: Revert.
7659         * arm-pikeos-tdep.c: Revert.
7660         * arm-obsd-tdep.c: Revert.
7661         * arm-nbsd-tdep.c: Revert.
7662         * arm-nbsd-nat.c: Revert.
7663         * arm-linux-tdep.c: Revert.
7664         * arm-linux-nat.c: Revert.
7665         * arm-fbsd-tdep.c: Revert.
7666         * arm-fbsd-nat.c: Revert.
7667         * arm-bsd-tdep.c: Revert.
7668         * arch-utils.c: Revert.
7669         * arc-tdep.c: Revert.
7670         * arc-newlib-tdep.c: Revert.
7671         * annotate.h: Revert.
7672         * annotate.c: Revert.
7673         * amd64-windows-tdep.c: Revert.
7674         * amd64-windows-nat.c: Revert.
7675         * amd64-tdep.c: Revert.
7676         * amd64-sol2-tdep.c: Revert.
7677         * amd64-obsd-tdep.c: Revert.
7678         * amd64-obsd-nat.c: Revert.
7679         * amd64-nbsd-tdep.c: Revert.
7680         * amd64-nbsd-nat.c: Revert.
7681         * amd64-nat.c: Revert.
7682         * amd64-linux-tdep.c: Revert.
7683         * amd64-linux-nat.c: Revert.
7684         * amd64-fbsd-tdep.c: Revert.
7685         * amd64-fbsd-nat.c: Revert.
7686         * amd64-dicos-tdep.c: Revert.
7687         * amd64-darwin-tdep.c: Revert.
7688         * amd64-bsd-nat.c: Revert.
7689         * alpha-tdep.c: Revert.
7690         * alpha-obsd-tdep.c: Revert.
7691         * alpha-nbsd-tdep.c: Revert.
7692         * alpha-mdebug-tdep.c: Revert.
7693         * alpha-linux-tdep.c: Revert.
7694         * alpha-linux-nat.c: Revert.
7695         * alpha-bsd-tdep.c: Revert.
7696         * alpha-bsd-nat.c: Revert.
7697         * aix-thread.c: Revert.
7698         * agent.c: Revert.
7699         * addrmap.c: Revert.
7700         * ada-varobj.c: Revert.
7701         * ada-valprint.c: Revert.
7702         * ada-typeprint.c: Revert.
7703         * ada-tasks.c: Revert.
7704         * ada-lang.c: Revert.
7705         * aarch64-tdep.c: Revert.
7706         * aarch64-ravenscar-thread.c: Revert.
7707         * aarch64-newlib-tdep.c: Revert.
7708         * aarch64-linux-tdep.c: Revert.
7709         * aarch64-linux-nat.c: Revert.
7710         * aarch64-fbsd-tdep.c: Revert.
7711         * aarch64-fbsd-nat.c: Revert.
7712         * aarch32-linux-nat.c: Revert.
7713
7714 2019-04-05  Tom Tromey  <tom@tromey.com>
7715
7716         * ft32-tdep.c: Sort headers.
7717         * frv-tdep.c: Sort headers.
7718         * frv-linux-tdep.c: Sort headers.
7719         * frame.c: Sort headers.
7720         * frame-unwind.c: Sort headers.
7721         * frame-base.c: Sort headers.
7722         * fork-child.c: Sort headers.
7723         * findvar.c: Sort headers.
7724         * findcmd.c: Sort headers.
7725         * filesystem.c: Sort headers.
7726         * filename-seen-cache.h: Sort headers.
7727         * filename-seen-cache.c: Sort headers.
7728         * fbsd-tdep.c: Sort headers.
7729         * fbsd-nat.h: Sort headers.
7730         * fbsd-nat.c: Sort headers.
7731         * f-valprint.c: Sort headers.
7732         * f-typeprint.c: Sort headers.
7733         * f-lang.c: Sort headers.
7734         * extension.h: Sort headers.
7735         * extension.c: Sort headers.
7736         * extension-priv.h: Sort headers.
7737         * expprint.c: Sort headers.
7738         * exec.h: Sort headers.
7739         * exec.c: Sort headers.
7740         * exceptions.c: Sort headers.
7741         * event-top.c: Sort headers.
7742         * event-loop.c: Sort headers.
7743         * eval.c: Sort headers.
7744         * elfread.c: Sort headers.
7745         * dwarf2read.h: Sort headers.
7746         * dwarf2read.c: Sort headers.
7747         * dwarf2loc.c: Sort headers.
7748         * dwarf2expr.h: Sort headers.
7749         * dwarf2expr.c: Sort headers.
7750         * dwarf2-frame.c: Sort headers.
7751         * dwarf2-frame-tailcall.c: Sort headers.
7752         * dwarf-index-write.h: Sort headers.
7753         * dwarf-index-write.c: Sort headers.
7754         * dwarf-index-common.c: Sort headers.
7755         * dwarf-index-cache.h: Sort headers.
7756         * dwarf-index-cache.c: Sort headers.
7757         * dummy-frame.c: Sort headers.
7758         * dtrace-probe.c: Sort headers.
7759         * disasm.h: Sort headers.
7760         * disasm.c: Sort headers.
7761         * disasm-selftests.c: Sort headers.
7762         * dictionary.c: Sort headers.
7763         * dicos-tdep.c: Sort headers.
7764         * demangle.c: Sort headers.
7765         * dcache.h: Sort headers.
7766         * dcache.c: Sort headers.
7767         * darwin-nat.h: Sort headers.
7768         * darwin-nat.c: Sort headers.
7769         * darwin-nat-info.c: Sort headers.
7770         * d-valprint.c: Sort headers.
7771         * d-namespace.c: Sort headers.
7772         * d-lang.c: Sort headers.
7773         * ctf.c: Sort headers.
7774         * csky-tdep.c: Sort headers.
7775         * csky-linux-tdep.c: Sort headers.
7776         * cris-tdep.c: Sort headers.
7777         * cris-linux-tdep.c: Sort headers.
7778         * cp-valprint.c: Sort headers.
7779         * cp-support.c: Sort headers.
7780         * cp-namespace.c: Sort headers.
7781         * cp-abi.c: Sort headers.
7782         * corelow.c: Sort headers.
7783         * corefile.c: Sort headers.
7784         * continuations.c: Sort headers.
7785         * completer.h: Sort headers.
7786         * completer.c: Sort headers.
7787         * complaints.c: Sort headers.
7788         * coffread.c: Sort headers.
7789         * coff-pe-read.c: Sort headers.
7790         * cli-out.h: Sort headers.
7791         * cli-out.c: Sort headers.
7792         * charset.c: Sort headers.
7793         * c-varobj.c: Sort headers.
7794         * c-valprint.c: Sort headers.
7795         * c-typeprint.c: Sort headers.
7796         * c-lang.c: Sort headers.
7797         * buildsym.c: Sort headers.
7798         * buildsym-legacy.c: Sort headers.
7799         * build-id.h: Sort headers.
7800         * build-id.c: Sort headers.
7801         * btrace.c: Sort headers.
7802         * bsd-uthread.c: Sort headers.
7803         * breakpoint.h: Sort headers.
7804         * breakpoint.c: Sort headers.
7805         * break-catch-throw.c: Sort headers.
7806         * break-catch-syscall.c: Sort headers.
7807         * break-catch-sig.c: Sort headers.
7808         * blockframe.c: Sort headers.
7809         * block.c: Sort headers.
7810         * bfin-tdep.c: Sort headers.
7811         * bfin-linux-tdep.c: Sort headers.
7812         * bfd-target.c: Sort headers.
7813         * bcache.c: Sort headers.
7814         * ax-general.c: Sort headers.
7815         * ax-gdb.h: Sort headers.
7816         * ax-gdb.c: Sort headers.
7817         * avr-tdep.c: Sort headers.
7818         * auxv.c: Sort headers.
7819         * auto-load.c: Sort headers.
7820         * arm-wince-tdep.c: Sort headers.
7821         * arm-tdep.c: Sort headers.
7822         * arm-symbian-tdep.c: Sort headers.
7823         * arm-pikeos-tdep.c: Sort headers.
7824         * arm-obsd-tdep.c: Sort headers.
7825         * arm-nbsd-tdep.c: Sort headers.
7826         * arm-nbsd-nat.c: Sort headers.
7827         * arm-linux-tdep.c: Sort headers.
7828         * arm-linux-nat.c: Sort headers.
7829         * arm-fbsd-tdep.c: Sort headers.
7830         * arm-fbsd-nat.c: Sort headers.
7831         * arm-bsd-tdep.c: Sort headers.
7832         * arch-utils.c: Sort headers.
7833         * arc-tdep.c: Sort headers.
7834         * arc-newlib-tdep.c: Sort headers.
7835         * annotate.h: Sort headers.
7836         * annotate.c: Sort headers.
7837         * amd64-windows-tdep.c: Sort headers.
7838         * amd64-windows-nat.c: Sort headers.
7839         * amd64-tdep.c: Sort headers.
7840         * amd64-sol2-tdep.c: Sort headers.
7841         * amd64-obsd-tdep.c: Sort headers.
7842         * amd64-obsd-nat.c: Sort headers.
7843         * amd64-nbsd-tdep.c: Sort headers.
7844         * amd64-nbsd-nat.c: Sort headers.
7845         * amd64-nat.c: Sort headers.
7846         * amd64-linux-tdep.c: Sort headers.
7847         * amd64-linux-nat.c: Sort headers.
7848         * amd64-fbsd-tdep.c: Sort headers.
7849         * amd64-fbsd-nat.c: Sort headers.
7850         * amd64-dicos-tdep.c: Sort headers.
7851         * amd64-darwin-tdep.c: Sort headers.
7852         * amd64-bsd-nat.c: Sort headers.
7853         * alpha-tdep.c: Sort headers.
7854         * alpha-obsd-tdep.c: Sort headers.
7855         * alpha-nbsd-tdep.c: Sort headers.
7856         * alpha-mdebug-tdep.c: Sort headers.
7857         * alpha-linux-tdep.c: Sort headers.
7858         * alpha-linux-nat.c: Sort headers.
7859         * alpha-bsd-tdep.c: Sort headers.
7860         * alpha-bsd-nat.c: Sort headers.
7861         * aix-thread.c: Sort headers.
7862         * agent.c: Sort headers.
7863         * addrmap.c: Sort headers.
7864         * ada-varobj.c: Sort headers.
7865         * ada-valprint.c: Sort headers.
7866         * ada-typeprint.c: Sort headers.
7867         * ada-tasks.c: Sort headers.
7868         * ada-lang.c: Sort headers.
7869         * aarch64-tdep.c: Sort headers.
7870         * aarch64-ravenscar-thread.c: Sort headers.
7871         * aarch64-newlib-tdep.c: Sort headers.
7872         * aarch64-linux-tdep.c: Sort headers.
7873         * aarch64-linux-nat.c: Sort headers.
7874         * aarch64-fbsd-tdep.c: Sort headers.
7875         * aarch64-fbsd-nat.c: Sort headers.
7876         * aarch32-linux-nat.c: Sort headers.
7877
7878 2019-04-04  Tom Tromey  <tom@tromey.com>
7879
7880         * varobj.c (varobj_create): Update.
7881         * rust-exp.y (struct rust_parser) <update_innermost_block,
7882         lookup_symbol>: New methods.
7883         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7884         Rename.
7885         (rust_parser::rust_lookup_type)
7886         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7887         * printcmd.c (display_command, do_one_display): Update.
7888         * parser-defs.h (struct parser_state) <parser_state>: Add
7889         "tracker" parameter.
7890         (block_tracker): New member.
7891         (class innermost_block_tracker) <innermost_block_tracker>: Add
7892         "types" parameter.
7893         <reset>: Remove method.
7894         (innermost_block): Don't declare.
7895         (null_post_parser): Update.
7896         * parse.c (innermost_block): Remove global.
7897         (write_dollar_variable): Update.
7898         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7899         Remove "tracker_types" parameter.
7900         (parse_expression): Add "tracker" parameter.
7901         (parse_expression_for_completion): Update.
7902         (null_post_parser): Add "tracker" parameter.
7903         * p-exp.y: Update rules.
7904         * m2-exp.y: Update rules.
7905         * language.h (struct language_defn) <la_post_parser>: Add
7906         "tracker" parameter.
7907         * go-exp.y: Update rules.
7908         * f-exp.y: Update rules.
7909         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7910         parameter.
7911         * d-exp.y: Update rules.
7912         * c-exp.y: Update rules.
7913         * breakpoint.c (set_breakpoint_condition): Create an
7914         innermost_block_tracker.
7915         (watch_command_1): Likewise.
7916         * ada-lang.c (resolve): Add "tracker" parameter.
7917         (resolve_subexp): Likewise.
7918         * ada-exp.y (write_var_from_sym): Update.
7919
7920 2019-04-04  Tom Tromey  <tom@tromey.com>
7921
7922         * type-stack.h: New file.
7923         * type-stack.c: New file.
7924         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7925         type-stack.h.
7926         (insert_into_type_stack, insert_type, push_type, push_type_int)
7927         (insert_type_address_space, pop_type, pop_type_int)
7928         (pop_typelist, pop_type_stack, append_type_stack)
7929         (push_type_stack, get_type_stack, push_typelist)
7930         (follow_type_instance_flags, follow_types): Don't declare.
7931         * parse.c (type_stack): Remove global.
7932         (parse_exp_in_context): Update.
7933         (insert_into_type_stack, insert_type, push_type, push_type_int)
7934         (insert_type_address_space, pop_type, pop_type_int)
7935         (pop_typelist, pop_type_stack, append_type_stack)
7936         (push_type_stack, get_type_stack, push_typelist)
7937         (follow_type_instance_flags, follow_types): Remove (moved to
7938         type-stack.c).
7939         * f-exp.y (type_stack): New global.
7940         Update rules.
7941         (push_kind_type, f_parse): Update.
7942         * d-exp.y (type_stack): New global.
7943         Update rules.
7944         (d_parse): Update.
7945         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7946         Update rules.
7947         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7948         (HFILES_NO_SRCDIR): Add type-stack.h.
7949
7950 2019-04-04  Tom Tromey  <tom@tromey.com>
7951
7952         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7953         (rust_parser::convert_ast_to_expression, rust_parse)
7954         (rust_lex_test_completion, rust_lex_tests): Update.
7955         * parser-defs.h (struct expr_completion_state): New.
7956         (struct parser_state) <parser_state>: Add completion parameter.
7957         <mark_struct_expression, mark_completion_tag>: New methods.
7958         <parse_completion, m_completion_state>: New members.
7959         (prefixify_expression, null_post_parser): Update.
7960         (mark_struct_expression, mark_completion_tag): Don't declare.
7961         * parse.c (parse_completion, expout_last_struct)
7962         (expout_tag_completion_type, expout_completion_name): Remove
7963         globals.
7964         (parser_state::mark_struct_expression)
7965         (parser_state::mark_completion_tag): Now methods.
7966         (prefixify_expression): Add last_struct parameter.
7967         (prefixify_subexp): Likewise.
7968         (parse_exp_1): Update.
7969         (parse_exp_in_context): Add cstate parameter.  Update.
7970         (parse_expression_for_completion): Create an
7971         expr_completion_state.
7972         (null_post_parser): Add "completion" parameter.
7973         * p-exp.y: Update rules.
7974         (yylex): Update.
7975         * language.h (struct language_defn) <la_post_parser>: Add
7976         "completing" parameter.
7977         * go-exp.y: Update rules.
7978         (lex_one_token): Update.
7979         * expression.h (parse_completion): Don't declare.
7980         * d-exp.y: Update rules.
7981         (lex_one_token): Update rules.
7982         * c-exp.y: Update rules.
7983         (lex_one_token): Update.
7984         * ada-lang.c (resolve): Add "parse_completion" parameter.
7985         (resolve_subexp): Likewise.
7986         (ada_resolve_function): Likewise.
7987
7988 2019-04-04  Tom Tromey  <tom@tromey.com>
7989
7990         * parser-defs.h (struct parser_state) <start_arglist,
7991         end_arglist>: New methods.
7992         <arglist_len, m_funcall_chain>: New members.
7993         (arglist_len, start_arglist, end_arglist): Don't declare.
7994         * parse.c (arglist_len, funcall_chain): Remove global.
7995         (start_arglist, end_arglist): Remove functions.
7996         (parse_exp_in_context): Update.
7997         * p-exp.y: Update rules.
7998         * m2-exp.y: Update rules.
7999         * go-exp.y: Update rules.
8000         * f-exp.y: Update rules.
8001         * d-exp.y: Update rules.
8002         * c-exp.y: Update rules.
8003
8004 2019-04-04  Tom Tromey  <tom@tromey.com>
8005
8006         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8007         lex_operator, push_back>: New methods.
8008         Update all rules.
8009         (rust_parser::lex_hex, lex_escape): Rename and update.
8010         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8011         (rust_parser::lex_operator): Rename and update.
8012         (rust_parser::lex_number, rustyylex, rustyyerror)
8013         (rust_lex_test_init, rust_lex_test_sequence)
8014         (rust_lex_test_push_back, rust_lex_tests): Update.
8015         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8016         parameter.
8017         <lexptr, prev_lexptr>: New members.
8018         (lexptr, prev_lexptr): Don't declare.
8019         * parse.c (lexptr, prev_lexptr): Remove globals.
8020         (parse_exp_in_context): Update.
8021         * p-exp.y (yylex, yyerror): Update.
8022         * m2-exp.y (parse_number, yylex, yyerror): Update.
8023         * go-exp.y (lex_one_token, yyerror): Update.
8024         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8025         * d-exp.y (lex_one_token, yyerror): Update.
8026         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8027         (lex_one_token, yyerror): Update.
8028         * ada-lex.l (YY_INPUT): Update.
8029         (rewind_to_char): Update.
8030         * ada-exp.y (yyerror): Update.
8031
8032 2019-04-04  Tom Tromey  <tom@tromey.com>
8033
8034         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8035         * parser-defs.h (struct parser_state) <parser_state>: Add new
8036         parameter.
8037         <comma_terminates>: New member.
8038         (comma_terminates): Don't declare global.
8039         * parse.c (comma_terminates): Remove global.
8040         (parse_exp_in_context): Update.
8041         * p-exp.y (yylex): Update.
8042         * m2-exp.y (yylex): Update.
8043         * go-exp.y (lex_one_token): Update.
8044         * f-exp.y (yylex): Update.
8045         * d-exp.y (lex_one_token): Update.
8046         * c-exp.y (lex_one_token): Update.
8047         * ada-lex.l: Update.
8048
8049 2019-04-04  Tom Tromey  <tom@tromey.com>
8050
8051         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8052         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8053         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8054         * parser-defs.h (paren_depth): Don't declare.
8055         * parse.c (paren_depth): Remove global.
8056         (parse_exp_in_context): Update.
8057         * p-exp.y (paren_depth): New global.
8058         (pascal_parse): Initialize it.
8059         * m2-exp.y (paren_depth): New global.
8060         (m2_parse): Initialize it.
8061         * go-exp.y (paren_depth): New global.
8062         (go_parse): Initialize it.
8063         * f-exp.y (paren_depth): New global.
8064         (f_parse): Initialize it.
8065         * d-exp.y (paren_depth): New global.
8066         (d_parse): Initialize it.
8067         * c-exp.y (paren_depth): New global.
8068         (c_parse): Initialize it.
8069         * ada-lex.l (paren_depth): New global.
8070         (lexer_init): Initialize it.
8071
8072 2019-04-04  Tom Tromey  <tom@tromey.com>
8073
8074         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8075         (rust_parser::convert_ast_to_type)
8076         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8077         * parser-defs.h (struct parser_state) <parser_state>: Add
8078         parameters.  Initialize new members.
8079         <expression_context_block, expression_context_pc>: New members.
8080         * parse.c (expression_context_block, expression_context_pc):
8081         Remove globals.
8082         (parse_exp_in_context): Update.
8083         * p-exp.y: Update all rules.
8084         (yylex): Update.
8085         * m2-exp.y: Update all rules.
8086         (yylex): Update.
8087         * go-exp.y (yylex): Update.
8088         * f-exp.y (yylex): Update.
8089         * d-exp.y: Update all rules.
8090         (yylex): Update.
8091         * c-exp.y: Update all rules.
8092         (lex_one_token, classify_name, yylex, c_parse): Update.
8093         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8094
8095 2019-04-04  Tom Tromey  <tom@tromey.com>
8096
8097         * gdbarch.h, gdbarch.c: Rebuild.
8098         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8099         * stap-probe.h:
8100         (struct stap_parse_info): Replace "parser_state" with
8101         "expr_builder".
8102         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8103         (parser_state): New class.
8104         * parse.c (expr_builder): Rename.
8105         (expr_builder::release): Rename.
8106         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8107         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8108         (write_exp_elt_longcst, write_exp_elt_floatcst)
8109         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8110         (write_exp_string_vector, write_exp_bitstring)
8111         (write_exp_msymbol, mark_struct_expression)
8112         (write_dollar_variable)
8113         (insert_type_address_space, increase_expout_size): Replace
8114         "parser_state" with "expr_builder".
8115         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8116         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8117         "parser_state" with "expr_builder".
8118
8119 2019-04-04  Tom Tromey  <tom@tromey.com>
8120
8121         * rust-exp.y: Replace "parse_language" with method call.
8122         * p-exp.y:
8123         (yylex): Replace "parse_language" with method call.
8124         * m2-exp.y:
8125         (yylex): Replace "parse_language" with method call.
8126         * go-exp.y (classify_name): Replace "parse_language" with method
8127         call.
8128         * f-exp.y (yylex): Replace "parse_language" with method call.
8129         * d-exp.y (lex_one_token): Replace "parse_language" with method
8130         call.
8131         * c-exp.y:
8132         (lex_one_token, classify_name, yylex): Replace "parse_language"
8133         with method call.
8134         * ada-exp.y (find_primitive_type, type_char)
8135         (type_system_address): Replace "parse_language" with method call.
8136
8137 2019-04-04  Tom Tromey  <tom@tromey.com>
8138
8139         * rust-exp.y: Replace "parse_gdbarch" with method call.
8140         * parse.c (write_dollar_variable, insert_type_address_space):
8141         Replace "parse_gdbarch" with method call.
8142         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8143         call.
8144         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8145         call.
8146         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8147         "parse_gdbarch" with method call.
8148         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8149         with method call.
8150         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8151         "parse_gdbarch" with method call.
8152         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8153         "parse_gdbarch" with method call.
8154         * c-exp.y (parse_type, parse_number, classify_name): Replace
8155         "parse_gdbarch" with method call.
8156         * ada-lex.l: Replace "parse_gdbarch" with method call.
8157         * ada-exp.y (parse_type, find_primitive_type, type_char)
8158         (type_system_address): Replace "parse_gdbarch" with method call.
8159
8160 2019-04-04  Tom Tromey  <tom@tromey.com>
8161
8162         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8163         * stap-probe.c (stap_parse_argument): Update.
8164         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8165         initial_size parameter.
8166         * rust-exp.y (rust_lex_tests): Update.
8167         * parse.c (parser_state): Update.
8168         (parse_exp_in_context): Update.
8169         * parser-defs.h (struct parser_state) <parser_state>: Remove
8170         "initial_size" parameter.
8171
8172 2019-04-04  Tom Tromey  <tom@tromey.com>
8173
8174         * parser-defs.h (increase_expout_size): Don't declare.
8175         * parse.c (increase_expout_size): Now static.
8176
8177 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8178
8179         * gnu-nat.c (gnu_nat_target::wait): Fix
8180         target_waitstatus_to_string call.
8181
8182 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * eval.c (evaluate_subexp_standard): Handle internal functions
8185         during Fortran function call handling.
8186
8187 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * NEWS: Mention new internal functions.
8190         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8191         (read_base_type): Use dwarf2_init_complex_target_type.
8192         * value.c (creal_internal_fn): New function.
8193         (cimag_internal_fn): New function.
8194         (_initialize_values): Register new internal functions.
8195
8196 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8197
8198         * infrun.c (stop_all_threads): If debug_infrun, always
8199         trace the wait status after wait_one, using
8200         target_waitstatus_to_string and target_pid_to_str.
8201         (handle_inferior_event): Replace various trace of
8202         wait status kind by a single trace.
8203         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8204         wait status kind image by target_waitstatus_to_string.
8205         * target/waitstatus.c (target_waitstatus_to_string): Fix
8206         obsolete comment.
8207
8208 2019-04-01  Tom Tromey  <tromey@adacore.com>
8209
8210         PR symtab/23331:
8211         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8212
8213 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8214             Pedro Alves  <palves@redhat.com>
8215
8216         * top.c (quit_force): Call 'finalize_values'.
8217         * value.c (finalize_values): New function.
8218         * value.h (finalize_values): Declare.
8219
8220 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8221
8222         * NEWS: Announce $_gdb_major and $_gdb_minor.
8223
8224         * top.c (init_gdb_version_vars): New function.
8225         (gdb_init): Call init_gdb_version_vars.
8226
8227 2019-03-29  Tom Tromey  <tromey@adacore.com>
8228
8229         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8230         help text.  Remove dead code.
8231
8232 2019-03-29  Keith Seitz  <keiths@redhat.com>
8233
8234         From Siddhesh Poyarekar:
8235         * f-lang.h (f77_get_upperbound): Return LONGEST.
8236         (f77_get_lowerbound): Likewise.
8237         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8238         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8239         print them.
8240         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8241         plongest to format print it.
8242         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8243         (f77_get_upperbound): Likewise.
8244         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8245         LOWER_BOUND to LONGEST.
8246         (f77_create_arrayprint_offset_tbl): Likewise.
8247
8248 2019-03-29  Keith Seitz  <keiths@redhat.com>
8249
8250         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8251         %s/pulongest for TYPE_LENGTH instead of %d in format
8252         strings.
8253         * ada-typerint.c (ada_print_type): Likewise.
8254         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8255         * compile/compile-c-support.c (generate_register_struct): Likewise.
8256         * gdbtypes.c (recursive_dump_type): Likewise.
8257         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8258         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8259         instead of %d in format strings.
8260         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8261         to std::min to ULONGEST.
8262         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8263         instead of %d in format strings.
8264         * tracepoint.c (info_scope_command): Likewise.
8265         * typeprint.c (print_offset_data::update)
8266         (print_offset_data::finish): Likewise.
8267         * xtensa-tdep.c (xtensa_store_return_value)
8268         (xtensa_push_dummy_call): Likewise.
8269
8270 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8271
8272         * windows-nat.c (display_selector): Fixed format specifications
8273         for 64-bit Cygwin.
8274
8275 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8276
8277         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8278
8279 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8280
8281         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8282         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8283         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8284         (nios2_linux_init_abi): Install it.
8285
8286 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8287
8288         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8289
8290 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8291
8292         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8293
8294 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8295             Tom Tromey  <tromey@adacore.com>
8296
8297         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8298
8299 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8300
8301         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8302         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8303         method to compute the bounds of range types. Also print "[evaluated]"
8304         if the bounds' values come from a dynamic evaluation.
8305
8306 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8309         whitespace when pretty printing is on.
8310
8311 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8312
8313         * ppc-linux-nat.c: Add include.
8314
8315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8316
8317         * NEWS: Mention AArch64 Pointer Authentication.
8318
8319 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8320
8321         * arm-linux-nat.c: Add include.
8322
8323 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8324
8325         * source-cache.c (source_cache::get_source_lines): Re-read
8326         fullname after calling open_source_file.
8327
8328 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8329
8330         * NEWS: Mention TLS support for FreeBSD.
8331
8332 2019-03-25  Tom Tromey  <tromey@adacore.com>
8333
8334         * minsyms.c (BUNCH_SIZE): Update comment.
8335         (~minimal_symbol_reader): Remove old comment.
8336         (compact_minimal_symbols): Update comment.
8337         (minimal_symbol_reader::install): Remove old comment.  Update
8338         other comments.
8339
8340 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8341
8342         * s390-linux-nat.c: Add include.
8343
8344 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8345
8346         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8347         Call linux_get_hwcap.
8348         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8349         Likewise.
8350         (aarch64_linux_get_hwcap): Remove function.
8351         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8352         declaration.
8353         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8354         linux_get_hwcap.
8355         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8356         * linux-tdep.c (linux_get_hwcap): Add function.
8357         (linux_get_hwcap2): Likewise.
8358         * linux-tdep.h (linux_get_hwcap): Add declaration.
8359         (linux_get_hwcap2): Likewise.
8360         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8361         (ppc_linux_get_hwcap2): Likewise.
8362         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8363         linux_get_hwcap.
8364         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8365         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8366         (ppc_linux_nat_target::read_description): Likewise.
8367         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8368         * s390-linux-nat.c: Likewise.
8369         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8370
8371 2019-03-24  Tom Tromey  <tom@tromey.com>
8372
8373         * ada-lang.c (standard_lookup): Simplify initialization.
8374         (ada_lookup_symbol_nonlocal): Simplify return.
8375         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8376         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8377         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8378         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8379         initialization.
8380         * solib.c (solib_global_lookup): Simplify.
8381         * symtab.c (null_block_symbol): Remove.
8382         (symbol_cache_lookup): Simplify returns.
8383         (lookup_language_this): Simplify returns.
8384         (lookup_symbol_aux): Simplify return.
8385         (lookup_local_symbol): Simplify returns.
8386         (lookup_global_symbol_from_objfile): Simplify return.
8387         (lookup_symbol_in_objfile_symtabs)
8388         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8389         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8390         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8391         * cp-namespace.c (cp_lookup_bare_symbol)
8392         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8393         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8394         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8395         (cp_lookup_symbol_via_imports): Simplify initialization.
8396         (find_symbol_in_baseclass): Likewise.
8397         * symtab.h (null_block_symbol): Remove.
8398         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8399         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8400         (d_lookup_symbol_module): Likewise.
8401         (find_symbol_in_baseclass): Simplify initialization.
8402
8403 2019-03-24  Tom Tromey  <tom@tromey.com>
8404
8405         * expression.h: Don't include symtab.h.
8406         (struct block): Forward declare.
8407
8408 2019-03-24  Tom Tromey  <tom@tromey.com>
8409
8410         * c-exp.y (typebase): Remove casts.
8411         * gdbtypes.c (lookup_unsigned_typename, )
8412         (lookup_signed_typename): Remove cast.
8413         * eval.c (parse_to_comma_and_eval): Remove cast.
8414         * parse.c (write_dollar_variable): Remove cast.
8415         * block.h (struct block) <superblock>: Now const.
8416         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8417         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8418         (map_block): Make "block" const.
8419         * symfile.h (struct quick_symbol_functions)
8420         <map_matching_symbols>: Constify block argument to "callback".
8421         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8422         const.
8423         (find_pc_sect_compunit_symtab): Make "b" const.
8424         (find_symbol_at_address): Likewise.
8425         (search_symbols): Likewise.
8426         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8427         (dw2_debug_names_lookup_symbol): Likewise.
8428         (dw2_map_matching_symbols): Update.
8429         * p-valprint.c (pascal_val_print): Remove "block".
8430         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8431         (aux_add_nonlocal_symbols): Make "block" const.
8432         (resolve_subexp): Remove cast.
8433         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8434         const.
8435         (iterate_over_file_blocks): Likewise.
8436         * f-exp.y (%union) <bval>: Remove.
8437         * coffread.c (patch_opaque_types): Make "b" const.
8438         * spu-tdep.c (spu_catch_start): Make "block" const.
8439         * c-valprint.c (print_unpacked_pointer): Remove "block".
8440         * symmisc.c (dump_symtab_1): Make "b" const.
8441         (block_depth): Make "block" const.
8442         * d-exp.y (%union) <bval>: Remove.
8443         * cp-support.h (cp_lookup_rtti_type): Update.
8444         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8445         * psymtab.c (psym_lookup_symbol): Make "block" const.
8446         (maintenance_check_psymtabs): Make "b" const.
8447         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8448         (enumerate_locals, enumerate_args): Update.
8449         * python/py-symtab.c (stpy_global_block): Make "block" const.
8450         (stpy_static_block): Likewise.
8451         * inline-frame.c (block_starting_point_at): Make "new_block"
8452         const.
8453         * block.c (find_block_in_blockvector): Make return type const.
8454         (blockvector_for_pc_sect): Make "b" const.
8455         (find_block_in_blockvector): Make "b" const.
8456
8457 2019-03-23  Tom Tromey  <tom@tromey.com>
8458
8459         * varobj.c (varobj_create): Update.
8460         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8461         * printcmd.c (display_command, do_one_display): Don't reset
8462         innermost_block.
8463         * parser-defs.h (enum innermost_block_tracker_type): Move to
8464         expression.h.
8465         (innermost_block): Update comment.
8466         * parse.c (parse_exp_1): Add tracker_types parameter.
8467         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8468         tracker_types parameter.  Reset innermost_block.
8469         (parse_exp_in_context): Remove.
8470         (parse_expression_for_completion): Update.
8471         * objfiles.c (~objfile): Don't reset expression_context_block or
8472         innermost_block.
8473         * expression.h (enum innermost_block_tracker_type): Move from
8474         parser-defs.h.
8475         (parse_exp_1): Add tracker_types parameter.
8476         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8477         reset innermost_block.
8478
8479 2019-03-23  Tom Tromey  <tom@tromey.com>
8480
8481         * objfiles.h: Include bcache.h.
8482
8483 2019-03-23  Tom Tromey  <tom@tromey.com>
8484
8485         * linespec.c (get_current_search_block): Use
8486         scoped_restore_current_language.
8487         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8488
8489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8490             Jiong Wang  <jiong.wang@arm.com>
8491
8492         * aarch64-linux-tdep.c
8493         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8494         section.
8495         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8496
8497 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8498             Jiong Wang  <jiong.wang@arm.com>
8499
8500         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8501         instructions.
8502         (aarch64_analyze_prologue_test): Add PACIASP test.
8503         (aarch64_prologue_prev_register): Unmask PC value.
8504
8505 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8506             Jiong Wang  <jiong.wang@arm.com>
8507
8508         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8509         (aarch64_dwarf2_prev_register): Unmask PC value.
8510         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8511         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8512         DW_CFA_AARCH64_negate_ra_state.
8513         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8514
8515 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8516             Jiong Wang  <jiong.wang@arm.com>
8517
8518         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8519         registers.
8520         (aarch64_pseudo_register_name): Likewise.
8521         (aarch64_pseudo_register_type): Likewise.
8522         (aarch64_pseudo_register_reggroup_p): Likewise.
8523         (aarch64_gdbarch_init): Add pauth registers.
8524         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8525         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8526         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8527         (struct gdbarch_tdep): Add regnum for ra_state.
8528
8529 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8530             Jiong Wang  <jiong.wang@arm.com>
8531
8532         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8533
8534 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8535             Jiong Wang  <jiong.wang@arm.com>
8536
8537         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8538         function.
8539         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8540         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8541         (aarch64_gdbarch_init): Add puth registers.
8542         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8543         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8544         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8545
8546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8547             Jiong Wang  <jiong.wang@arm.com>
8548
8549         * aarch64-linux-nat.c
8550         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8551         * aarch64-linux-tdep.c
8552         (aarch64_linux_core_read_description): Likewise.
8553         (aarch64_linux_get_hwcap): New function.
8554         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8555         (aarch64_linux_get_hwcap): New declaration.
8556
8557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8558             Jiong Wang  <jiong.wang@arm.com>
8559
8560         * aarch64-linux-nat.c
8561         (aarch64_linux_nat_target::read_description): Add pauth param.
8562         * aarch64-linux-tdep.c
8563         (aarch64_linux_core_read_description): Likewise.
8564         * aarch64-tdep.c (struct target_desc): Add in pauth.
8565         (aarch64_read_description): Add pauth param.
8566         (aarch64_gdbarch_init): Likewise.
8567         * aarch64-tdep.h (aarch64_read_description): Likewise.
8568         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8569         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8570         * features/Makefile: Add new files.
8571         * features/aarch64-pauth.c: New file.
8572         * features/aarch64-pauth.xml: New file.
8573
8574 2019-03-20  Tom Tromey  <tromey@adacore.com>
8575
8576         * infrun.c (handle_inferior_event): Rename from
8577         handle_inferior_event_1.  Create a scoped_value_mark.
8578         (handle_inferior_event): Remove.
8579
8580 2019-03-19  Tom Tromey  <tromey@adacore.com>
8581
8582         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8583         * infrun.h (print_stop_event): Add "displays" parameter.
8584         * infrun.c (print_stop_event): Add "displays" parameter.
8585
8586 2019-03-19  Pedro Alves  <palves@redhat.com>
8587
8588         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8589         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8590         to -1.  Fix TABs vs spaces.
8591         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8592         * tui/tui-out.h (tui_ui_out) Add intro comments.
8593         <m_line, m_start_of_line>: In-class initialize, and add describing
8594         comment.
8595
8596 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8597
8598         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8599         variable names.
8600         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8601
8602 2019-03-18  Pedro Alves  <palves@redhat.com>
8603             Eli Zaretskii <eliz@gnu.org>
8604
8605         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8606         m_line and m_start_of_line.
8607
8608 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8609
8610         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8611         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8612         it returns a newline.  This fixes a regression in TU mode, whereby
8613         the next line is output on the same screen line as the user input.
8614
8615 2019-03-18  Tom Tromey  <tromey@adacore.com>
8616
8617         * minsyms.c (minimal_symbol_reader::install): Remove call to
8618         obstack_blank.
8619
8620 2019-03-18  Pedro Alves  <palves@redhat.com>
8621
8622         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8623         New globals.
8624         (apply_style): New, factored out from ...
8625         (apply_ansi_escape): ... this.  Handle reverse video mode.
8626         (tui_set_reverse_mode): New function.
8627         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8628         * tui/tui-winsource.c (tui_show_source_line): Use
8629         tui_set_reverse_mode instead of setting A_STANDOUT.
8630         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8631         New setter methods.
8632
8633 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8634
8635         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8636         Handle tabs.
8637
8638 2019-03-18  Tom Tromey  <tromey@adacore.com>
8639
8640         * ada-lang.c (empty_array): Add "high" parameter.
8641         (ada_evaluate_subexp): Update.
8642
8643 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8644
8645         * unittests/string_view-selftests.c: Define
8646         _initialize_string_view_selftests unconditionally.
8647
8648 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8649
8650         PR gdb/24350
8651         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8652
8653 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8654
8655         PR gdb/24351
8656         * windows-nat.c (display_selector): Fix format specifiers.
8657
8658 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8659
8660         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8661         tui_refill_source_window instead of tui_refresh_win, to update the
8662         current execution line.  This fixes redisplay of the current line
8663         when stepping through the code with "next" or "step".
8664
8665 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8666
8667         * source-cache.c (source_cache::get_source_lines): Call
8668         find_source_lines to initialize s->nlines.  This fixes vertical
8669         scrolling of TUI source window when the DOWN arrow is pressed.
8670
8671 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8672
8673         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8674         linux-thread-db.c (_initialize_thread_db): Likewise.
8675
8676 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8677
8678         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8679         wclrtoeol in tui_show_source_line".  This reverts changes made in
8680         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8681
8682 2019-03-15  Tom Tromey  <tom@tromey.com>
8683
8684         * symtab.h (struct minimal_symbol): Derive from
8685         general_symbol_info.
8686         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8687         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8688         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8689         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8690         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8691         (MSYMBOL_SEARCH_NAME): Update.
8692         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8693         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8694         * minsyms.c (minimal_symbol_reader::record_full): Update.
8695
8696 2019-03-15  Tom Tromey  <tom@tromey.com>
8697
8698         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8699
8700 2019-03-15  Tom Tromey  <tom@tromey.com>
8701
8702         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8703         unique_xmalloc_ptr.
8704         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8705         Update.
8706         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8707         (build_minimal_symbol_hash_tables)
8708         (minimal_symbol_reader::install): Update.
8709
8710 2019-03-15  Tom Tromey  <tom@tromey.com>
8711
8712         * symtab.c (create_demangled_names_hash): Update.
8713         (symbol_set_names): Update.
8714         * objfiles.h (struct objfile_per_bfd_storage)
8715         <demangled_names_hash>: Now an htab_up.
8716         * objfiles.c (objfile_per_bfd_storage): Simplify.
8717
8718 2019-03-15  Tom Tromey  <tom@tromey.com>
8719
8720         * objfiles.h (struct objfile_per_bfd_storage): Declare
8721         destructor.
8722         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8723         New.
8724         (get_objfile_bfd_data): Use new.  Don't initialize
8725         language_of_main.
8726         (free_objfile_per_bfd_storage): Remove.
8727         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8728
8729 2019-03-15  Tom Tromey  <tom@tromey.com>
8730
8731         * symfile.c (reread_symbols): Update.
8732         * objfiles.c (objfile::objfile): Update.
8733         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8734         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8735         comment.
8736         (minimal_symbol_reader::install): Update.
8737         (terminate_minimal_symbol_table): Remove.
8738         * jit.c (jit_object_close_impl): Update.
8739
8740 2019-03-15  Tom Tromey  <tom@tromey.com>
8741
8742         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8743         initializations.
8744
8745 2019-03-15  Tom Tromey  <tom@tromey.com>
8746
8747         * objfiles.h (struct objfile_per_bfd_storage)
8748         <demangled_hash_languages>: Now a bitset.
8749         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8750         (lookup_minimal_symbol): Update.
8751
8752 2019-03-15  Tom Tromey  <tom@tromey.com>
8753
8754         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8755         Don't return the symbol.
8756         * coffread.c (record_minimal_symbol): Use record_full.
8757
8758 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8759
8760         The MS-Windows port of ncurses fails to switch to a color pair if
8761         one or both of the colors are the implicit default colors.  This
8762         change records the default colors when TUI is initialized, and
8763         then specifies them explicitly when a color pair uses the default
8764         colors.  This allows color styling in TUI mode on MS-Windows.
8765
8766         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8767         ncurses_norm_attr.
8768         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8769         colors in ncurses_norm_attr.
8770         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8771         "none", replace it with the default color recorded in
8772         ncurses_norm_attr.
8773
8774 2019-03-14  Tom Tromey  <tromey@adacore.com>
8775
8776         * source-cache.h (class source_cache) <get_source_lines>: Return
8777         std::string.
8778         * source-cache.c (source_cache::extract_lines): Handle case where
8779         first_pos==npos.  Return std::string.
8780         (source_cache::get_source_lines): Update.
8781
8782 2019-03-14  Tom Tromey  <tromey@adacore.com>
8783
8784         * NEWS: Add item for "style sources" commands.
8785         * source-cache.c (source_cache::get_source_lines): Check
8786         source_styling.
8787         * cli/cli-style.c (source_styling): New global.
8788         (_initialize_cli_style): Add "style sources" commands.
8789         (show_style_sources): New function.
8790         * cli/cli-style.h (source_styling): Declare.
8791
8792 2019-03-14  Pedro Alves  <palves@redhat.com>
8793             Tom Tromey  <tromey@adacore.com>
8794
8795         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8796         * tui/tui-winsource.c (tui_refill_source_window): New function,
8797         from...
8798         (tui_horizontal_source_scroll): ... here.  Move some logic.
8799         * cli/cli-style.c (set_style_enabled): Notify new observable.
8800         * tui/tui-hooks.c (tui_redisplay_source): New function.
8801         (tui_attach_detach_observers): Attach or detach
8802         tui_redisplay_source.
8803         * observable.h (source_styling_changed): New observable.
8804         * observable.c: Define source_styling_changed observable.
8805
8806 2019-03-13  Tom Tromey  <tromey@adacore.com>
8807
8808         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8809         (i386_gnu_nat_target::store_registers): Update.
8810         * target-debug.h (target_debug_print_std_string): New macro.
8811         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8812         * windows-tdep.c (display_one_tib): Update.
8813         * tui/tui-stack.c (tui_make_status_line): Update.
8814         * top.c (print_inferior_quit_action): Update.
8815         * thread.c (thr_try_catch_cmd): Update.
8816         (add_thread_with_info): Update.
8817         (thread_target_id_str): Update.
8818         (thr_try_catch_cmd): Update.
8819         (thread_command): Update.
8820         (thread_find_command): Update.
8821         * record-btrace.c (record_btrace_target::info_record)
8822         (record_btrace_resume_thread, record_btrace_target::resume)
8823         (record_btrace_cancel_resume, record_btrace_step_thread)
8824         (record_btrace_target::wait, record_btrace_target::wait)
8825         (record_btrace_target::wait, record_btrace_target::stop): Update.
8826         * progspace.c (print_program_space): Update.
8827         * process-stratum-target.c
8828         (process_stratum_target::thread_address_space): Update.
8829         * linux-fork.c (linux_fork_mourn_inferior)
8830         (detach_checkpoint_command, info_checkpoints_command)
8831         (linux_fork_context): Update.
8832         (linux_fork_detach): Update.
8833         (class scoped_switch_fork_info): Update.
8834         (delete_checkpoint_command): Update.
8835         * infrun.c (follow_fork_inferior): Update.
8836         (follow_fork_inferior): Update.
8837         (proceed_after_vfork_done): Update.
8838         (handle_vfork_child_exec_or_exit): Update.
8839         (follow_exec): Update.
8840         (displaced_step_prepare_throw): Update.
8841         (displaced_step_restore): Update.
8842         (start_step_over): Update.
8843         (resume_1): Update.
8844         (clear_proceed_status_thread): Update.
8845         (proceed): Update.
8846         (print_target_wait_results): Update.
8847         (do_target_wait): Update.
8848         (context_switch): Update.
8849         (stop_all_threads): Update.
8850         (restart_threads): Update.
8851         (finish_step_over): Update.
8852         (handle_signal_stop): Update.
8853         (switch_back_to_stepped_thread): Update.
8854         (keep_going_pass_signal): Update.
8855         (print_exited_reason): Update.
8856         (normal_stop): Update.
8857         * inferior.c (inferior_pid_to_str): Change return type.
8858         (print_selected_inferior): Update.
8859         (add_inferior): Update.
8860         (detach_inferior): Update.
8861         * dummy-frame.c (fprint_dummy_frames): Update.
8862         * dcache.c (dcache_info_1): Update.
8863         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8864         (btrace_fetch, btrace_clear): Update.
8865         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8866         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8867         type.
8868         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8869         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8870         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8871         * gdbarch.c, gdbarch.h: Rebuild.
8872         * gdbarch.sh (core_pid_to_str): Change return type.
8873         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8874         return type.
8875         (windows_nat_target::pid_to_str): Change return type.
8876         (windows_delete_thread): Update.
8877         (windows_nat_target::attach): Update.
8878         (windows_nat_target::files_info): Update.
8879         * target-delegates.c: Rebuild.
8880         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8881         return type.
8882         (sol_thread_target::pid_to_str): Change return type.
8883         * remote.c (class remote_target) <pid_to_str>: Change return
8884         type.
8885         (remote_target::pid_to_str): Change return type.
8886         (extended_remote_target::attach, remote_target::remote_stop_ns)
8887         (remote_target::remote_notif_remove_queued_reply)
8888         (remote_target::push_stop_reply, remote_target::disable_btrace):
8889         Update.
8890         (extended_remote_target::attach): Update.
8891         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8892         type.
8893         (gdbsim_target::pid_to_str): Change return type.
8894         * ravenscar-thread.c (struct ravenscar_thread_target)
8895         <pid_to_str>: Change return type.
8896         (ravenscar_thread_target::pid_to_str): Change return type.
8897         * procfs.c (class procfs_target) <pid_to_str>: Change return
8898         type.
8899         (procfs_target::pid_to_str): Change return type.
8900         (procfs_target::attach): Update.
8901         (procfs_target::detach): Update.
8902         (procfs_target::fetch_registers): Update.
8903         (procfs_target::store_registers): Update.
8904         (procfs_target::wait): Update.
8905         (procfs_target::files_info): Update.
8906         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8907         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8908         return type.
8909         (nto_procfs_target::pid_to_str): Change return type.
8910         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8911         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8912         return type.
8913         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8914         (exit_lwp): Update.
8915         (attach_proc_task_lwp_callback, get_detach_signal)
8916         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8917         (linux_nat_target::resume, wait_lwp, stop_callback)
8918         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8919         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8920         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8921         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8922         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8923         type.
8924         (inf_ptrace_target::attach): Update.
8925         (inf_ptrace_target::files_info): Update.
8926         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8927         type.
8928         (go32_nat_target::pid_to_str): Change return type.
8929         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8930         (gnu_nat_target::wait): Update.
8931         (gnu_nat_target::wait): Update.
8932         (gnu_nat_target::resume): Update.
8933         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8934         (fbsd_nat_target::wait): Update.
8935         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8936         type.
8937         (darwin_nat_target::attach): Update.
8938         * corelow.c (class core_target) <pid_to_str>: Change return type.
8939         (core_target::pid_to_str): Change return type.
8940         * target.c (normal_pid_to_str): Change return type.
8941         (default_pid_to_str): Likewise.
8942         (target_pid_to_str): Change return type.
8943         (target_translate_tls_address): Update.
8944         (target_announce_detach): Update.
8945         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8946         return type.
8947         (bsd_uthread_target::pid_to_str): Change return type.
8948         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8949         type.
8950         (bsd_kvm_target::pid_to_str): Change return type.
8951         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8952         return type.
8953         (aix_thread_target::pid_to_str): Change return type.
8954         * target.h (struct target_ops) <pid_to_str>: Change return type.
8955         (target_pid_to_str, normal_pid_to_str): Likewise.
8956         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8957         type.
8958         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8959         type.
8960         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8961         return type.
8962         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8963         type.
8964         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8965         type.
8966         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8967         return type.
8968
8969 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8970
8971         * NEWS: Mention that the new default MI version is 3.  Mention
8972         changes to the output of commands and events that deal with
8973         multi-location breakpoints.
8974         * breakpoint.c: Include "mi/mi-out.h".
8975         (print_one_breakpoint): Change output syntax if using MI version
8976         >= 3.
8977         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8978         New.
8979         (mi_multi_location_breakpoint_output_fixed): New.
8980         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8981         (mi_cmd_fix_multi_location_breakpoint_output): New.
8982         (mi_multi_location_breakpoint_output_fixed): New.
8983         * mi/mi-cmds.c (mi_cmds): Register command
8984         -fix-multi-location-breakpoint-output.
8985         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8986         interpreter "mi".
8987
8988 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8989
8990         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8991         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8992         instantiate mi_ui_out based on interpreter name.
8993         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8994         * mi/mi-main.c (mi_load_progress): Likewise.
8995
8996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8997
8998         * NEWS: Combine separate "New targets" sections for 8.3.
8999
9000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9001
9002         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9003         (ppcfbsd_init_abi): Install gdbarch
9004         "fetch_tls_load_module_address" and "get_thread_local_address"
9005         methods.
9006
9007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9008
9009         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9010         (riscv_fbsd_init_abi): Install gdbarch
9011         "fetch_tls_load_module_address" and "get_thread_local_address"
9012         methods.
9013
9014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9015
9016         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9017         (i386fbsd_init_abi): Install gdbarch
9018         "fetch_tls_load_module_address" and "get_thread_local_address"
9019         methods.
9020
9021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9022
9023         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9024         (amd64fbsd_init_abi): Install gdbarch
9025         "fetch_tls_load_module_address" and "get_thread_local_address"
9026         methods.
9027
9028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9029
9030         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9031         (struct fbsd_pspace_data): New type.
9032         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9033         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9034         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9035         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9036         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9037
9038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9039
9040         * gdbtypes.c (lookup_struct_elt): New function.
9041         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9042         * gdbtypes.h (struct struct_elt): New type.
9043         (lookup_struct_elt): New prototype.
9044
9045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9046
9047         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9048         remove disabled code block.
9049
9050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9051
9052         * gdbarch.sh (get_thread_local_address): New method.
9053         * gdbarch.h, gdbarch.c: Regenerate.
9054         * target.c (target_translate_tls_address): Use
9055         gdbarch_get_thread_local_address if present instead of
9056         target::get_thread_local_address.
9057
9058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9059
9060         * target.h (target::get_thread_local_address): Update comment.
9061
9062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9063
9064         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9065         objfile->separate_debug_objfile_backlink if not NULL.
9066
9067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9068
9069         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9070         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9071         (amd64bsd_store_inferior_registers): Likewise.
9072         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9073         Enable segment base registers.
9074         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9075         PT_GETFSBASE and PT_GETGSBASE.
9076         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9077         PT_SETGSBASE.
9078         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9079         segment base registers.
9080         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9081
9082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9083
9084         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9085         Update calls to i386_target_description to add 'segments'
9086         parameter.
9087         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9088         add segment base registers.
9089         * arch/i386.c (i386_create_target_description): Add 'segments'
9090         parameter to enable segment base registers.
9091         * arch/i386.h (i386_create_target_description): Likewise.
9092         * features/i386/32bit-segments.xml: New file.
9093         * features/i386/32bit-segments.c: Generate.
9094         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9095         call to i386_target_description to add 'segments' parameter.
9096         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9097         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9098         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9099         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9100         if feature is present.
9101         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9102         Add 'segments' parameter to call to i386_target_description.
9103         (i386_target_description): Add 'segments' parameter to enable
9104         segment base registers.
9105         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9106         to call to i386_target_description.
9107         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9108         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9109         Define I386_NUM_REGS.
9110         (i386_target_description): Add 'segments' parameter to enable
9111         segment base registers.
9112
9113 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9114
9115         PR/24325
9116         * source-cache.c: #undef open and close, to avoid unresolved
9117         externals during linking.
9118
9119 2019-03-12  Tom Tromey  <tromey@adacore.com>
9120
9121         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9122         const.  Add initializers.
9123         (_initialize_remote): Don't initialize ptid globals.
9124
9125 2019-03-12  Pedro Alves  <palves@redhat.com>
9126
9127         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9128
9129 2019-03-12  Pedro Alves  <palves@redhat.com>
9130
9131         * cp-name-parser.y (main): Remove unused 'len' variable.
9132
9133 2019-03-12  Tom Tromey  <tromey@adacore.com>
9134
9135         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9136         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9137
9138 2019-03-12  Tom Tromey  <tromey@adacore.com>
9139
9140         * linux-nat.c (iterate_over_lwps): Update.
9141         (stop_callback): Remove parameter.
9142         (stop_wait_callback, detach_callback, resume_set_callback)
9143         (select_singlestep_lwp_callback, set_ignore_sigint)
9144         (status_callback, resumed_callback, resume_clear_callback)
9145         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9146         data parameter.
9147         (linux_nat_target::detach, linux_nat_target::resume)
9148         (linux_stop_and_wait_all_lwps, select_event_lwp)
9149         (linux_nat_filter_event, linux_nat_wait_1)
9150         (linux_nat_target::kill, linux_nat_target::stop)
9151         (linux_nat_target::stop): Update.
9152         (linux_nat_resume_callback): Change type.
9153         (resume_stopped_resumed_lwps, count_events_callback)
9154         (select_event_lwp_callback): Likewise.
9155         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9156         * arm-linux-nat.c (struct update_registers_data): Remove.
9157         (update_registers_callback): Change type.
9158         (arm_linux_insert_hw_breakpoint1): Update.
9159         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9160         parameter.
9161         (x86_linux_dr_set_addr): Update.
9162         (x86_linux_dr_set_control): Update.
9163         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9164         (iterate_over_lwps): Use gdb::function_view.
9165         * nat/aarch64-linux-hw-point.c (struct
9166         aarch64_dr_update_callback_param): Remove.
9167         (debug_reg_change_callback): Change type.
9168         (aarch64_notify_debug_reg_change): Update.
9169         * s390-linux-nat.c (s390_refresh_per_info): Update.
9170
9171 2019-03-11  Tom Tromey  <tromey@adacore.com>
9172
9173         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9174         redundant assignment to "this_cu".
9175
9176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9177
9178         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9179
9180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9181
9182         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9183         from...
9184         (rank_one_type): ... this.
9185
9186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9187
9188         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9189         from...
9190         (rank_one_type): ... this.
9191
9192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9193
9194         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9195         from...
9196         (rank_one_type): ... this.
9197
9198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9199
9200         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9201         from...
9202         (rank_one_type): ... this.
9203
9204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9205
9206         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9207         from...
9208         (rank_one_type): ... this.
9209
9210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9211
9212         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9213         from...
9214         (rank_one_type): ... this.
9215
9216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9217
9218         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9219         from...
9220         (rank_one_type): ... this.
9221
9222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9223
9224         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9225         from...
9226         (rank_one_type): ... this.
9227
9228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9229
9230         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9231         from...
9232         (rank_one_type): ... this.
9233
9234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9235
9236         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9237         from...
9238         (rank_one_type): ... this.
9239
9240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9241
9242         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9243         from...
9244         (rank_one_type): ... this.
9245
9246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9247
9248         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9249         from...
9250         (rank_one_type): ... this.
9251
9252 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9253
9254         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9255         inferior-events' shows the example events.
9256
9257 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9258
9259         Support styling on native MS-Windows console
9260
9261         PR/24315
9262         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9263         on MS-Windows if $TERM is not defined.
9264
9265         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9266
9267         * posix-hdep.c (gdb_console_fputs):
9268         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9269         functions.
9270         * ui-file.h (gdb_console_fputs): Add prototype.
9271
9272         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9273         back to fputs only if the former returns zero.
9274
9275 2019-03-07  Tom Tromey  <tom@tromey.com>
9276
9277         * symmisc.c (print_symbol_bcache_statistics): Update.
9278         (print_objfile_statistics): Update.
9279         * symfile.c (allocate_symtab): Update.
9280         * stabsread.c: Don't include bcache.h.
9281         * psymtab.h (struct psymbol_bcache): Don't declare.
9282         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9283         (psymbol_bcache_init, psymbol_bcache_free)
9284         (psymbol_bcache_get_bcache): Don't declare.
9285         * psymtab.c (struct psymbol_bcache): Remove.
9286         (psymtab_storage::psymtab_storage): Update.
9287         (psymtab_storage::~psymtab_storage): Update.
9288         (psymbol_bcache_init, psymbol_bcache_free)
9289         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9290         (add_psymbol_to_bcache): Update.
9291         (allocate_psymtab): Update.
9292         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9293         macro_cache>: No longer pointers.
9294         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9295         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9296         * macrotab.c (macro_bcache): Update.
9297         * macroexp.c: Don't include bcache.h.
9298         * gdbtypes.c (check_types_worklist): Update.
9299         (types_deeply_equal): Remove TRY/CATCH.  Update.
9300         * elfread.c (elf_symtab_read): Update.
9301         * dwarf2read.c: Don't include bcache.h.
9302         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9303         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9304         (print_bcache_statistics, bcache_memory_used): Don't declare.
9305         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9306         methods.  Rename all data members.
9307         * bcache.c (struct bcache): Move to bcache.h.
9308         (bcache::expand_hash_table): Rename from expand_hash_table.
9309         (bcache): Remove.
9310         (bcache::insert): Rename from bcache_full.
9311         (bcache::compare): Rename from bcache_compare.
9312         (bcache_xmalloc): Remove.
9313         (bcache::~bcache): Rename from bcache_xfree.
9314         (bcache::print_statistics): Rename from print_bcache_statistics.
9315         (bcache::memory_used): Rename from bcache_memory_used.
9316
9317 2019-03-07  Pedro Alves  <palves@redhat.com>
9318
9319         * infrun.c (normal_stop): Also check for
9320         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9321
9322 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9323
9324         * f-lang.c (value_from_host_double): Moved to...
9325         * value.c (value_from_host_double): ...here.
9326         * value.h (value_from_host_double): Declare.
9327         * guile/scm-math.c (vlscm_convert_typed_number): Use
9328         value_from_host_double.
9329         (vlscm_convert_number): Likewise.
9330         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9331         * python/py-value.c (convert_value_from_python): Likewise.
9332
9333 2019-03-06  Tom Tromey  <tom@tromey.com>
9334
9335         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9336
9337 2019-03-06  Tom Tromey  <tom@tromey.com>
9338
9339         * utils.h (free_current_contents): Don't declare.
9340         * utils.c (free_current_contents): Remove.
9341
9342 2019-03-06  Tom Tromey  <tom@tromey.com>
9343
9344         * top.c (quit_force): Update.
9345         * main.c (captured_command_loop): Update.
9346         * common/new-op.c (operator new): Update.
9347         * common/common-exceptions.c (struct catcher)
9348         <save_cleanup_chain>: Remove member.
9349         (exceptions_state_mc_init): Update.
9350         (exception_try_scope_entry): Return nullptr.
9351         (exception_try_scope_exit, exception_rethrow)
9352         (throw_exception_sjlj, throw_exception_cxx): Update.
9353         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9354         (all_cleanups, do_cleanups, discard_cleanups)
9355         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9356         (restore_cleanups, restore_final_cleanups): Don't declare.
9357         (do_final_cleanups): Remove parameter.
9358         * common/cleanups.c (cleanup_chain, make_cleanup)
9359         (make_cleanup_dtor, all_cleanups, do_cleanups)
9360         (discard_my_cleanups, discard_cleanups)
9361         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9362         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9363         (null_cleanup): Remove.
9364         (do_final_cleanups): Remove parameter.
9365
9366 2019-03-06  Tom Tromey  <tom@tromey.com>
9367
9368         * remote.c (remote_target::remote_parse_stop_reply): Use
9369         unique_xmalloc_ptr.
9370
9371 2019-03-06  Tom Tromey  <tom@tromey.com>
9372
9373         * stabsread.c (struct stabs_field_info): Rename from field_info.
9374         <list, fnlist>: Add initializers.
9375         <obstack>: New member.
9376         (read_member_functions, read_struct_fields, read_baseclasses):
9377         Allocate on obstack.  Don't use cleanups.
9378         (read_one_struct_field, read_member_functions, read_struct_fields)
9379         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9380         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9381         (read_struct_type): Update.
9382
9383 2019-03-06  Tom Tromey  <tom@tromey.com>
9384
9385         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9386         * common/filestuff.h (make_cleanup_close): Don't declare.
9387         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9388         Remove.
9389
9390 2019-03-06  Tom Tromey  <tom@tromey.com>
9391
9392         * solib-aix.c: Use make_scope_exit.
9393
9394 2019-03-06  Tom Tromey  <tom@tromey.com>
9395
9396         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9397         Use make_scope_exit.
9398
9399 2019-03-06  Tom Tromey  <tom@tromey.com>
9400
9401         * solib-svr4.c (disable_probes_interface): Remove parameter.
9402         (svr4_handle_solib_event): Use make_scope_exit.
9403
9404 2019-03-06  Tom Tromey  <tom@tromey.com>
9405
9406         * remote.c (struct stop_reply_deleter): Remove.
9407         (stop_reply_up): Update.
9408         (struct stop_reply): Derive from notif_event.  Don't typedef.
9409         <regcache>: Now a std::vector.
9410         (stop_reply_xfree): Remove.
9411         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9412         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9413         (remote_target::discard_pending_stop_replies): Use delete.
9414         (remote_target::remote_parse_stop_reply): Update.
9415         (remote_target::process_stop_reply): Update.
9416         * remote-notif.h (struct notif_event): Add virtual destructor.
9417         Remove "dtr" member.
9418         (struct notif_client) <alloc_event>: Return a unique_ptr.
9419         (notif_event_xfree): Don't declare.
9420         (notif_event_up): New typedef.
9421         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9422         (notif_event_xfree, do_notif_event_xfree): Remove.
9423         (remote_notif_state_xfree): Update.
9424
9425 2019-03-06  Tom Tromey  <tom@tromey.com>
9426
9427         * infrun.c (displaced_step_clear_cleanup): Now a
9428         forward_scope_exit type.
9429         (displaced_step_prepare_throw): Update.
9430         (displaced_step_fixup): Update.
9431
9432 2019-03-06  Tom Tromey  <tom@tromey.com>
9433
9434         * inferior.h (class inferior): Update comment.
9435         * gdbthread.h (class thread_info): Update comment.
9436
9437 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9438             Tom Tromey  <tom@tromey.com>
9439
9440         * stabsread.h (struct stab_section_list): Remove.
9441         (coffstab_build_psymtabs): Update.
9442         * dbxread.c (symbuf_sections): Now a std::vector.
9443         (sect_idx): New global.
9444         (fill_symbuf): Update.
9445         (coffstab_build_psymtabs): Change type of stabsects parameter.
9446         Update.
9447         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9448         std::vector.
9449         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9450         (coff_locate_sections): Update.
9451         (coff_symfile_read): Remove cleanups.  Update.
9452         (init_stringtab): Add storage parameter.
9453         (free_stringtab, free_stringtab_cleanup): Remove.
9454         (init_lineno): Add storage parameter.
9455         (free_linetab, free_linetab_cleanup): Remove.
9456
9457 2019-03-06  Pedro Alves  <palves@redhat.com>
9458
9459         * linux-fork.c (fork_info::clobber_regs): Delete.
9460         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9461         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9462         comment.  Adjust.
9463         (scoped_switch_fork_info::scoped_switch_fork_info)
9464         (checkpoint_command, linux_fork_context): Adjust
9465         fork_save_infrun_state calls.
9466
9467 2019-03-06  Pedro Alves  <palves@redhat.com>
9468
9469         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9470         (inf_has_multiple_threads): Return 'bool' and rewrite using
9471         inferior_info::threads().
9472
9473 2019-03-06  Pedro Alves  <palves@redhat.com>
9474
9475         * linux-fork.c: Include <list>.
9476         (fork_list): Now a std::list instance.
9477         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9478         (forks_exist_p, find_last_fork): Adjust.
9479         (new_fork): Delete.
9480         (one_fork_p): New.
9481         (add_fork): Adjust.
9482         (free_fork): Delete, folded into fork_info::~fork_info().
9483         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9484         Adjust.
9485         (init_fork_list): Delete.
9486         (linux_fork_killall, linux_fork_mourn_inferior)
9487         (linux_fork_detach, info_checkpoints_command): Adjust.
9488         (_initialize_linux_fork): No longer call init_fork_list.
9489
9490 2019-03-06  Pedro Alves  <palves@redhat.com>
9491
9492         * linux-fork.c (new_fork): New, split out of ...
9493         (add_fork): ... this.  Return void.  Move "first fork" special
9494         case from here, to ...
9495         (checkpoint_command): ... here.
9496         * linux-linux.h (add_fork): Return void.
9497
9498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9499
9500         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9501
9502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9503             Chris January  <chris.january@arm.com>
9504             David Lecomber  <david.lecomber@arm.com>
9505
9506         * f-exp.y: New token, UNOP_INTRINSIC.
9507         (exp): New pattern using UNOP_INTRINSIC token.
9508         (f77_keywords): Add 'abs' keyword.
9509         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9510         (value_from_host_double): New function.
9511         (evaluate_subexp_f): Support UNOP_ABS.
9512
9513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9516         types.
9517
9518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9519
9520         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9521         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9522         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9523
9524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9525
9526         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9527
9528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9529             Chris January  <chris.january@arm.com>
9530
9531         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9532         * f-exp.y: Define 'KIND' token.
9533         (exp): New pattern for KIND expressions.
9534         (ptype): Handle types with a kind extension.
9535         (direct_abs_decl): Extend to spot kind extensions.
9536         (f77_keywords): Add 'kind' to the list.
9537         (push_kind_type): New function.
9538         (convert_to_kind_type): New function.
9539         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9540         * parse.c (operator_length_standard): Likewise.
9541         * parser-defs.h (enum type_pieces): Add tp_kind.
9542         * std-operator.def: Add UNOP_KIND.
9543
9544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9545
9546         * f-exp.y (f_parse): Set yydebug.
9547
9548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9549
9550         * f-lang.c (evaluate_subexp_f): New function.
9551         (exp_descriptor_f): New global.
9552         (f_language_defn): Use exp_descriptor_f instead of
9553         exp_descriptor_standard.
9554
9555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9556
9557         * f-exp.y (struct token): Add comments.
9558         (dot_ops): Remove uppercase versions and the end marker.
9559         (f77_keywords): Likewise.
9560         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9561         entries in the dot_ops array are case insensitive, and use
9562         strncasecmp to compare strings.  Also some whitespace cleanup in
9563         this area.  Similar for the f77_keywords array, except entries in
9564         this list might be case sensitive.
9565
9566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * f-exp.y (struct f77_boolean_val): Add comments.
9569         (boolean_values): Remove uppercase versions, and end marker.
9570         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9571         and use strncasecmp to achieve case insensitivity.  Additionally,
9572         perform whitespace cleanup around this code.
9573
9574 2019-03-06  Tom Tromey  <tromey@adacore.com>
9575
9576         * remote-sim.c (gdbsim_target_open): Use result of
9577         gdb_argv::release.
9578
9579 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9580         Dirk Schubert  <dirk.schubert@arm.com>
9581         Chris January  <chris.january@arm.com>
9582
9583         * eval.c (evaluate_subexp_standard): Call Fortran argument
9584         wrapping logic.
9585         * f-lang.c (struct value): A value which can be passed into a
9586         Fortran function call.
9587         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9588         where appropriate.
9589         (struct type): Value ready for a Fortran function call.
9590         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9591         is needed.
9592         * f-lang.h (fortran_argument_convert): Declaration.
9593         (fortran_preserve_arg_pointer): Declaration.
9594         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9595
9596 2019-03-05  Tom Tromey  <tromey@adacore.com>
9597
9598         * python/py-prettyprint.c (print_string_repr): Remove #if.
9599         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9600
9601 2019-03-05  Tom Tromey  <tromey@adacore.com>
9602
9603         * target.c (the_dummy_target): Move later.  Change type to
9604         "dummy_target".
9605         (initialize_targets): Don't initialize the_dummy_target.
9606
9607 2019-03-05  Tom Tromey  <tromey@adacore.com>
9608
9609         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9610         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9611
9612 2019-03-05  Tom Tromey  <tromey@adacore.com>
9613
9614         * windows-nat.c (windows_nat_target::attach)
9615         (windows_nat_target::detach): Don't call gdb_flush.
9616         * valprint.c (generic_val_print, val_print, val_print_string):
9617         Don't call gdb_flush.
9618         * utils.c (defaulted_query): Don't call gdb_flush.
9619         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9620         * target.c (target_announce_detach): Don't call gdb_flush.
9621         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9622         * remote.c (extended_remote_target::attach): Don't call
9623         gdb_flush.
9624         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9625         * printcmd.c (do_examine): Don't call gdb_flush.
9626         (info_display_command): Don't call gdb_flush.
9627         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9628         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9629         * memattr.c (info_mem_command): Don't call gdb_flush.
9630         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9631         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9632         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9633         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9634         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9635         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9636         (gnu_nat_target::detach): Don't call gdb_flush.
9637         * f-valprint.c (f_val_print): Don't call gdb_flush.
9638         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9639         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9640         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9641         gdb_flush.
9642         * c-valprint.c (c_val_print): Don't call gdb_flush.
9643         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9644
9645 2019-03-05  Tom Tromey  <tromey@adacore.com>
9646
9647         * varobj.c (update_dynamic_varobj_children): Update.
9648         (install_default_visualizer): Use reset, not release.
9649         * value.c (set_internalvar): Update.
9650         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9651         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9652         ATTRIBUTE_UNUSED_RESULT.
9653
9654 2019-03-05  Tom Tromey  <tromey@adacore.com>
9655
9656         * remote.c (class scoped_remote_fd) <release>: Add
9657         ATTRIBUTE_UNUSED_RESULT.
9658
9659 2019-03-05  Tom Tromey  <tromey@adacore.com>
9660
9661         * macroexp.c (struct macro_buffer) <release>: Add
9662         ATTRIBUTE_UNUSED_RESULT.
9663
9664 2019-03-05  Tom Tromey  <tromey@adacore.com>
9665
9666         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9667         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9668         ATTRIBUTE_UNUSED_RESULT.
9669
9670 2019-03-05  Tom Tromey  <tromey@adacore.com>
9671
9672         * common/scoped_fd.h (class scoped_fd) <release>: Add
9673         ATTRIBUTE_UNUSED_RESULT.
9674
9675 2019-03-05  Tom Tromey  <tromey@adacore.com>
9676
9677         * parser-defs.h (struct parser_state) <release>: Add
9678         ATTRIBUTE_UNUSED_RESULT.
9679
9680 2019-03-05  Tom Tromey  <tromey@adacore.com>
9681
9682         * utils.h (class gdb_argv) <release>: Add
9683         ATTRIBUTE_UNUSED_RESULT.
9684         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9685
9686 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9687
9688         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9689         for-loop range, to avoid compiler warnings.
9690
9691         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9692         avoid compiler warnings about unused variables.
9693
9694         * NEWS: Mention end of support for native debugging on MS-Windows
9695         before XP.
9696
9697         PR gdb/24292
9698         * common/netstuff.c:
9699         * gdbserver/gdbreplay.c
9700         * gdbserver/remote-utils.c:
9701         * ser-tcp.c:
9702         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9703         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9704         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9705         'getaddrinfo' and 'freeaddrinfo' were not available before
9706         Windows XP, and mingw.org's MinGW headers by default define
9707         _WIN32_WINNT to 0x500.
9708
9709 2019-03-01  Gary Benson <gbenson@redhat.com>
9710
9711         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9712
9713 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9714             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9715
9716         PR gdb/8527
9717         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9718         set_sigint_trap, clear_sigint_trap.
9719
9720 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9721
9722         * target.c (target_detach): Clear the regcache and the
9723         frame cache.
9724
9725 2019-02-27  Pedro Alves  <palves@redhat.com>
9726
9727         * utils.c (set_screen_size): When we cap the height/width sizes,
9728         tweak the corresponding command variable to show "unlimited":
9729
9730 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9731             Pedro Alves  <palves@redhat.com>
9732
9733         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9734         before calling rl_set_screen_size.
9735
9736 2019-02-27  Tom Tromey  <tromey@adacore.com>
9737
9738         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9739         define.
9740         * python/py-value.c: Remove Python 2.4 workaround.
9741         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9742         workaround.
9743         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9744         Python 2.4 workaround.
9745         * python/python-internal.h: Remove Python 2.4 comment.
9746         (Py_ssize_t): Don't define.
9747         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9748         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9749         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9750         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9751         * python/python.c (do_start_initialization): Remove Python 2.4
9752         workaround.
9753         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9754         (print_children): Remove Python 2.4 workaround.
9755         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9756         workaround.
9757         (CHARBUFFERPROC_NAME): Remove.
9758         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9759         Python 2.4 workaround.
9760
9761 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9762
9763         * NEWS: Note minimum Python version.
9764
9765 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9766
9767         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9768         code from these functions.  Remove corresponding ifdefs.  Use
9769         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9770         Remove gotos and target of gotos.
9771         (infpy_search_memory): Likewise.
9772
9773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9774
9775         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9776         (hppa_gdbarch_init): Don't register deleted functions with
9777         gdbarch.
9778
9779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9780
9781         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9782         (h8300_unwind_sp): Delete.
9783         (h8300_dummy_id): Delete.
9784         (h8300_gdbarch_init): Don't register deleted functions with
9785         gdbarch.
9786
9787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9788
9789         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9790         (ft32_unwind_pc): Delete.
9791         (ft32_unwind_sp): Delete.
9792         (ft32_gdbarch_init): Don't register deleted functions with
9793         gdbarch.
9794
9795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9796
9797         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9798         (frv_unwind_pc): Delete.
9799         (frv_unwind_sp): Delete.
9800         (frv_gdbarch_init): Don't register deleted functions with
9801         gdbarch.
9802
9803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9804
9805         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9806         (riscv_unwind_pc): Delete.
9807         (riscv_unwind_sp): Delete.
9808         (riscv_gdbarch_init): Don't register deleted functions with
9809         gdbarch.
9810
9811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9812
9813         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9814         (csky_unwind_pc): Delete.
9815         (csky_unwind_sp): Delete.
9816         (csky_gdbarch_init): Don't register deleted functions with
9817         gdbarch.
9818
9819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9820
9821         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9822         (cris_unwind_pc): Delete.
9823         (cris_unwind_sp): Delete.
9824         (cris_gdbarch_init): Don't register deleted functions with
9825         gdbarch.
9826
9827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9828
9829         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9830         (bfin_unwind_pc): Delete.
9831         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9832
9833 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9834
9835         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9836         (arm_unwind_pc): Delete.
9837         (arm_unwind_sp): Delete.
9838         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9839
9840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9841
9842         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9843         (arc_unwind_pc): Delete.
9844         (arc_unwind_sp): Delete.
9845         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9846
9847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9848
9849         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9850         (alpha_unwind_pc): Delete.
9851         (alpha_gdbarch_init): Don't register deleted functions with
9852         gdbarch.
9853
9854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9855
9856         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9857         (aarch64_unwind_pc): Delete.
9858         (aarch64_unwind_sp): Delete.
9859         (aarch64_gdbarch_init): Don't register deleted functions with
9860         gdbarch.
9861
9862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9863
9864         * gdbtypes.c (type_align): Don't consider static members when
9865         computing structure alignment.
9866
9867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9868
9869         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9870         return 0 for other types.
9871         * arch-utils.c (default_type_align): Always return 0.
9872         * gdbarch.h: Regenerate.
9873         * gdbarch.sh (type_align): Extend comment.
9874         * gdbtypes.c (type_align): Add additional comments, always call
9875         gdbarch_type_align before applying the default rules.
9876         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9877         generic code will then apply a suitable default.
9878         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9879         types, return 0 for other types.
9880
9881 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9882
9883         * NEWS: Create a new section for the next release branch.
9884         Rename the section of the current branch, now that it has
9885         been cut.
9886
9887 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9888
9889         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9890         * version.in: Bump version to 8.3.50.DATE-git.
9891
9892 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9893
9894         * aix-thread.c (ptid_cmp): Remove unused variable.
9895         (get_signaled_thread): Likewise.
9896         (store_regs_user_thread): Likewise.
9897         (store_regs_kernel_thread): Likewise.
9898         (fetch_regs_kernel_thread): Remove shadowed variable.
9899
9900 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9901
9902         * features/riscv/32bit-cpu.xml: Add register numbers.
9903         * features/riscv/32bit-fpu.c: Regenerate.
9904         * features/riscv/32bit-fpu.xml: Add register numbers.
9905         * features/riscv/64bit-cpu.xml: Add register numbers.
9906         * features/riscv/64bit-fpu.c: Regenerate.
9907         * features/riscv/64bit-fpu.xml: Add register numbers.
9908
9909 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9910
9911         * NEWS: Mention two argument form of gdb.Value constructor.
9912         * python/py-value.c (convert_buffer_and_type_to_value): New
9913         function.
9914         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9915         Add support for handling an optional second argument.  Call
9916         convert_buffer_and_type_to_value as appropriate.
9917         * python/python-internal.h (Py_buffer_deleter): New struct.
9918         (Py_buffer_up): New typedef.
9919
9920 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9921
9922         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9923         instead of releasing ownership.
9924
9925 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9926
9927         * dwarf2read.c (open_and_init_dwp_file): Call
9928         elf_numsections instead of bfd_count_sections to initialize
9929         dwp_file->num_sections.
9930
9931 2019-02-25  Tom Tromey  <tromey@adacore.com>
9932
9933         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9934
9935 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9936
9937         * gcore.in: Add '--readnever' option when invoking GDB.
9938
9939 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9940
9941         * MAINTAINERS: Update my email address.
9942
9943 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9944
9945         * build-id.c (build_id_to_debug_bfd_1): New function.
9946         (build_id_to_debug_bfd): Look for separate debug file in
9947         sysroot.
9948
9949 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9950
9951         * gdbarch.sh: Update the copyright year range that is placed into
9952         generated files.
9953
9954 2019-02-22  Keith Seitz  <keiths@redhat.com>
9955
9956         PR symtab/23853
9957         * linespec.c (create_sals_line_offset): Search for the default
9958         symtab's filename instead of its fullname.
9959
9960 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9961
9962         * NEWS: Update style defaults.
9963
9964 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9965
9966         * main.c (captured_main_1): Disable styling in batch mode.
9967
9968 2019-02-20  Tom Tromey  <tom@tromey.com>
9969
9970         * symtab.c (symtab_symbol_info): Fix typos.
9971
9972 2019-02-20  Tom Tromey  <tromey@adacore.com>
9973
9974         * findcmd.c (_initialize_mem_search): Use upper case for
9975         metasyntactic variables.
9976
9977 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9978
9979         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9980         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9981
9982 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9983
9984         * top.h (source_file_name): Change to std::string.
9985         * top.c (source_file_name): Likewise.
9986         (command_line_input): Adjust.
9987         * cli/cli-script.c (script_from_file): Adjust.
9988
9989 2019-02-19  Tom Tromey  <tromey@adacore.com>
9990
9991         * ravenscar-thread.c
9992         (ravenscar_thread_target::update_thread_list): Don't call
9993         ada_build_task_list.
9994         * ada-lang.h (ada_build_task_list): Don't declare.
9995         * ada-tasks.c (struct ada_tasks_inferior_data)
9996         <task_list_valid_p>: Now bool.
9997         (read_known_tasks, ada_task_list_changed)
9998         (ada_tasks_invalidate_inferior_data): Update.
9999         (read_known_tasks_array): Return bool.
10000         (read_known_tasks_list): Likewise.
10001         (read_known_tasks): Return void.
10002         (ada_build_task_list): Now static.
10003
10004 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10005
10006         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10007         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10008
10009 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10010
10011         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10012         variant for ada_tasks_pspace_data_handle and
10013         ada_tasks_inferior_data_handle.
10014         (ada_tasks_pspace_data_cleanup): New function.
10015         (ada_tasks_inferior_data_cleanup): New function.
10016
10017 2019-02-17  Tom Tromey  <tom@tromey.com>
10018
10019         * macrotab.h (macro_source_fullname): Return a std::string.
10020         * macrotab.c (macro_include, check_for_redefinition)
10021         (macro_undef, macro_lookup_definition, foreach_macro)
10022         (foreach_macro_in_scope): Update.
10023         (macro_source_fullname): Return a std::string.
10024         * macrocmd.c (show_pp_source_pos): Update.
10025
10026 2019-02-17  Tom Tromey  <tom@tromey.com>
10027
10028         * macrocmd.c (show_pp_source_pos): Style the file names.
10029
10030 2019-02-17  Tom Tromey  <tom@tromey.com>
10031
10032         PR tui/24197:
10033         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10034
10035 2019-02-17  Tom Tromey  <tom@tromey.com>
10036
10037         * ada-lang.c (user_select_syms): Use filtered printing.
10038         * utils.c (wrap_style): New global.
10039         (desired_style): Remove.
10040         (emit_style_escape): Add stream parameter.
10041         (set_output_style, reset_terminal_style, prompt_for_continue):
10042         Update.
10043         (flush_wrap_buffer): Only flush gdb_stdout.
10044         (wrap_here): Set wrap_style.
10045         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10046         treat escape sequences as a character.  Change when wrap buffer is
10047         flushed.
10048         (fputs_styled): Do not set the output style when the default is
10049         requested.
10050         * ui-style.h (struct ui_file_style) <is_default>: New method.
10051         * source.c (print_source_lines_base): Emit escape sequences in one
10052         piece.
10053
10054 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10055
10056         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10057         integers and enumeration types.
10058
10059 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10060
10061         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10062         instead of lookup_symbol_in_language
10063         (do_exact_match): New function.
10064         (ada_get_symbol_name_matcher): Return do_exact_match when
10065         doing a verbatim match.
10066
10067 2019-02-15  Tom Tromey  <tromey@adacore.com>
10068
10069         * ravenscar-thread.c (ravenscar_thread_target::resume)
10070         (ravenscar_thread_target::wait): Special case wildcard requests.
10071
10072 2019-02-15  Tom Tromey  <tromey@adacore.com>
10073
10074         * ravenscar-thread.c (base_ptid): Remove.
10075         (struct ravenscar_thread_target) <close>: New method.
10076         <m_base_ptid>: New member.
10077         <update_inferior_ptid, active_task, task_is_currently_active,
10078         runtime_initialized>: Declare methods.
10079         <ravenscar_thread_target>: Add constructor.
10080         (ravenscar_thread_target::task_is_currently_active)
10081         (ravenscar_thread_target::update_inferior_ptid)
10082         (ravenscar_runtime_initialized): Rename.  Now methods.
10083         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10084         (ravenscar_thread_target::update_thread_list): Update.
10085         (ravenscar_thread_target::active_task): Now method.
10086         (ravenscar_thread_target::store_registers)
10087         (ravenscar_thread_target::prepare_to_store)
10088         (ravenscar_thread_target::prepare_to_store)
10089         (ravenscar_thread_target::mourn_inferior): Update.
10090         (ravenscar_inferior_created): Use "new" to create target.
10091         (ravenscar_thread_target::get_ada_task_ptid): Update.
10092         (_initialize_ravenscar): Don't initialize base_ptid.
10093         (ravenscar_ops): Remove global.
10094
10095 2019-02-15  Tom Tromey  <tromey@adacore.com>
10096
10097         * target.h (push_target): Declare new overload.
10098         * target.c (push_target): New overload, taking an rvalue reference.
10099         * remote.c (remote_target::open_1): Use push_target overload.
10100         * corelow.c (core_target_open): Use push_target overload.
10101
10102 2019-02-15  Tom Tromey  <tromey@adacore.com>
10103
10104         * ravenscar-thread.c (is_ravenscar_task)
10105         (ravenscar_task_is_currently_active): Return bool.
10106         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10107         (_initialize_ravenscar): Remove "(void)".
10108         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10109         Return bool.
10110
10111 2019-02-15  Tom Tromey  <tromey@adacore.com>
10112
10113         * ravenscar-thread.c (ravenscar_runtime_initializer)
10114         (has_ravenscar_runtime, get_running_thread_id)
10115         (ravenscar_thread_target::resume): Fix indentation.
10116
10117 2019-02-15  Tom Tromey  <tromey@adacore.com>
10118
10119         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10120         from ravenscar_arch_ops.
10121         (sparc_ravenscar_ops::fetch_registers)
10122         (sparc_ravenscar_ops::store_registers): Now methods.
10123         (sparc_ravenscar_prepare_to_store): Remove.
10124         (sparc_ravenscar_ops): Redefine.
10125         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10126         methods and destructor.  Remove members.
10127         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10128         (ravenscar_thread_target::store_registers)
10129         (ravenscar_thread_target::prepare_to_store): Update.
10130         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10131         Remove.
10132         (struct ppc_ravenscar_powerpc_ops): Derive from
10133         ravenscar_arch_ops.
10134         (ppc_ravenscar_powerpc_ops::fetch_registers)
10135         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10136         (ppc_ravenscar_powerpc_ops): Redefine.
10137         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10138         (ppc_ravenscar_e500_ops::fetch_registers)
10139         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10140         (ppc_ravenscar_e500_ops): Redefine.
10141         * aarch64-ravenscar-thread.c
10142         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10143         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10144         (aarch64_ravenscar_fetch_registers)
10145         (aarch64_ravenscar_store_registers): Now methods.
10146         (aarch64_ravenscar_ops): Redefine.
10147
10148 2019-02-15  Tom Tromey  <tromey@adacore.com>
10149
10150         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10151         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10152         (ravenscar_thread_target::stopped_by_watchpoint)
10153         (ravenscar_thread_target::stopped_data_address)
10154         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10155
10156 2019-02-15  Tom Tromey  <tromey@adacore.com>
10157
10158         * ravenscar-thread.c: Fix some typos.
10159
10160 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10161             Tom Tromey  <tromey@adacore.com>
10162
10163         * ada-lang.c (ada_exception_sal): Change addr_string to a
10164         std::string.
10165         (create_ada_exception_catchpoint): Update.
10166
10167 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10168             Tom Tromey  <tromey@adacore.com>
10169
10170         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10171         (bp_location_ops): Remove.
10172         (base_breakpoint_allocate_location): Update.
10173         (free_bp_location): Update.
10174         * ada-lang.c (class ada_catchpoint_location)
10175         <ada_catchpoint_location>: Remove ops parameter.
10176         (ada_catchpoint_location_dtor): Remove.
10177         (ada_catchpoint_location_ops): Remove.
10178         (allocate_location_exception): Update.
10179         * breakpoint.h (struct bp_location_ops): Remove.
10180         (class bp_location) <bp_location>: Remove bp_location_ops
10181         parameter.
10182         <~bp_location>: Add destructor.
10183         <ops>: Remove.
10184
10185 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10186             Pedro Alves  <palves@redhat.com>
10187
10188         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10189         'PATH_MAX'.
10190
10191 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10192             Samuel Thibault  <samuel.thibault@gnu.org>
10193             Thomas Schwinge  <thomas@codesourcery.com>
10194
10195         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10196         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10197
10198 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10199
10200         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10201         (check_empty): Use "const char *".
10202
10203         * gnu-nat.c (gnu_nat_target::detach): Instead of
10204         'detach_inferior (pid)' call
10205         'detach_inferior (find_inferior_pid (pid))'.
10206
10207         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10208         'nat/fork-inferior.o'.
10209         * gnu-nat.c: #include "nat/fork-inferior.h".
10210
10211         * gnu-nat.c (gnu_nat_target::detach): Instead of
10212         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10213         * gnu-nat.h: #include "inf-child.h".
10214         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10215         'i386_gnu_nat_target::fetch_registers'.
10216         (gnu_store_registers): Rename/move to
10217         'i386_gnu_nat_target::store_registers'.
10218
10219         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10220         * gnu-nat.h (mach_thread_info): New function.
10221         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10222
10223         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10224
10225 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10226
10227         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10228
10229 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10230
10231         * windows-nat.c (windows_add_thread): Add new parameter
10232         "main_thread_p" with default value set to false.  Update
10233         function documentation as well as all callers.
10234         (windows_delete_thread): Likewise.
10235         (fake_create_process): Update call to windows_add_thread.
10236         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10237         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10238         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10239         call to windows_delete_thread.
10240
10241 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10242
10243         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10244
10245 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10246
10247         * symfile.c (find_separate_debug_file): Use canonical path of
10248         sysroot with child_path instead of gdb_sysroot if it is valid.
10249
10250 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10251
10252         * symfile.c (find_separate_debug_file): Use child_path to
10253         determine if an object file is under a sysroot.
10254
10255 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10256
10257         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10258         unittests/child-path-selftests.c.
10259         * common/pathstuff.c (child_path): New function.
10260         * common/pathstuff.h (child_path): New prototype.
10261         * unittests/child-path-selftests.c: New file.
10262
10263 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10264
10265         * symfile.c (find_separate_debug_file): Look for separate debug
10266         files in debug directories under the sysroot.
10267
10268 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10269
10270         * symtab.h (struct minimal_symbol data_p): New const method.
10271         (struct minimal_symbol text_p): Likewise.
10272         * symtab.c (output_source_filename): Use file name style
10273         to print file name.
10274         (print_symbol_info): Likewise.
10275         (print_msymbol_info): Use address style to print addresses.
10276         Use function name style to print executable text symbols.
10277         (expand_symtab_containing_pc): Use data_p.
10278         (find_pc_sect_compunit_symtab): Likewise.
10279
10280 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10281
10282         * breakpoint.c (describe_other_breakpoints): Use address style
10283         to print addresses.
10284         (say_where): Likewise.
10285
10286 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10287
10288         * ada-typeprint.c (print_func_type): Print function name
10289         style to print function name.
10290         * c-typeprint.c (c_print_type_1): Likewise.
10291
10292 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10293
10294         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10295         for execve.
10296
10297 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298
10299         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10300         type_stack.
10301
10302 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10303
10304         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10305         TYPE_CODE_REF types.
10306
10307 2019-02-08  Jim Wilson  <jimw@sifive.com>
10308
10309         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10310         (riscv_linux_fregset): New.
10311         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10312
10313 2019-02-07  Tom Tromey  <tom@tromey.com>
10314
10315         * thread.c (thread_cancel_execution_command): Update.
10316         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10317         methods.
10318         (struct thread_fsm_ops): Remove.
10319         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10320         (thread_fsm_should_stop, thread_fsm_return_value)
10321         (thread_fsm_set_finished, thread_fsm_finished_p)
10322         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10323         Don't declare.
10324         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10325         * infrun.c (clear_proceed_status_thread)
10326         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10327         (print_stop_event): Update.
10328         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10329         Add constructor.
10330         (step_command_fsm_ops): Remove.
10331         (new_step_command_fsm): Remove.
10332         (step_1): Update.
10333         (step_command_fsm::should_stop): Rename from
10334         step_command_fsm_should_stop.
10335         (step_command_fsm::clean_up): Rename from
10336         step_command_fsm_clean_up.
10337         (step_command_fsm::do_async_reply_reason): Rename from
10338         step_command_fsm_async_reply_reason.
10339         (struct until_next_fsm): Inherit from thread_fsm.  Add
10340         constructor.
10341         (until_next_fsm_ops): Remove.
10342         (new_until_next_fsm): Remove.
10343         (until_next_fsm::should_stop): Rename from
10344         until_next_fsm_should_stop.
10345         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10346         (until_next_fsm::do_async_reply_reason): Rename from
10347         until_next_fsm_async_reply_reason.
10348         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10349         constructor.  Change type of breakpoint.
10350         (finish_command_fsm_ops): Remove.
10351         (new_finish_command_fsm): Remove.
10352         (finish_command_fsm::should_stop): Rename from
10353         finish_command_fsm_should_stop.
10354         (finish_command_fsm::clean_up): Rename from
10355         finish_command_fsm_clean_up.
10356         (finish_command_fsm::return_value): Rename from
10357         finish_command_fsm_return_value.
10358         (finish_command_fsm::do_async_reply_reason): Rename from
10359         finish_command_fsm_async_reply_reason.
10360         (finish_command): Update.
10361         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10362         Add constructor.
10363         (call_thread_fsm_ops): Remove.
10364         (call_thread_fsm::call_thread_fsm): Rename from
10365         new_call_thread_fsm.
10366         (call_thread_fsm::should_stop): Rename from
10367         call_thread_fsm_should_stop.
10368         (call_thread_fsm::should_notify_stop): Rename from
10369         call_thread_fsm_should_notify_stop.
10370         (run_inferior_call, call_function_by_hand_dummy): Update.
10371         * cli/cli-interp.c (should_print_stop_to_console): Update.
10372         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10373         Add constructor.  Change type of location_breakpoint,
10374         caller_breakpoint.
10375         (until_break_fsm_ops): Remove.
10376         (new_until_break_fsm): Remove.
10377         (until_break_fsm::should_stop): Rename from
10378         until_break_fsm_should_stop.
10379         (until_break_fsm::clean_up): Rename from
10380         until_break_fsm_clean_up.
10381         (until_break_fsm::do_async_reply_reason): Rename from
10382         until_break_fsm_async_reply_reason.
10383         (until_break_command): Update.
10384         * thread-fsm.c: Remove.
10385         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10386
10387 2019-02-07  Tom Tromey  <tom@tromey.com>
10388
10389         * yy-remap.h: Add include guard.
10390         * xtensa-tdep.h: Add include guard.
10391         * xcoffread.h: Rename include guard.
10392         * varobj-iter.h: Add include guard.
10393         * tui/tui.h: Rename include guard.
10394         * tui/tui-winsource.h: Rename include guard.
10395         * tui/tui-wingeneral.h: Rename include guard.
10396         * tui/tui-windata.h: Rename include guard.
10397         * tui/tui-win.h: Rename include guard.
10398         * tui/tui-stack.h: Rename include guard.
10399         * tui/tui-source.h: Rename include guard.
10400         * tui/tui-regs.h: Rename include guard.
10401         * tui/tui-out.h: Rename include guard.
10402         * tui/tui-layout.h: Rename include guard.
10403         * tui/tui-io.h: Rename include guard.
10404         * tui/tui-hooks.h: Rename include guard.
10405         * tui/tui-file.h: Rename include guard.
10406         * tui/tui-disasm.h: Rename include guard.
10407         * tui/tui-data.h: Rename include guard.
10408         * tui/tui-command.h: Rename include guard.
10409         * tic6x-tdep.h: Add include guard.
10410         * target/waitstatus.h: Rename include guard.
10411         * target/wait.h: Rename include guard.
10412         * target/target.h: Rename include guard.
10413         * target/resume.h: Rename include guard.
10414         * target-float.h: Rename include guard.
10415         * stabsread.h: Add include guard.
10416         * rs6000-tdep.h: Add include guard.
10417         * riscv-fbsd-tdep.h: Add include guard.
10418         * regformats/regdef.h: Rename include guard.
10419         * record.h: Rename include guard.
10420         * python/python.h: Rename include guard.
10421         * python/python-internal.h: Rename include guard.
10422         * python/py-stopevent.h: Rename include guard.
10423         * python/py-ref.h: Rename include guard.
10424         * python/py-record.h: Rename include guard.
10425         * python/py-record-full.h: Rename include guard.
10426         * python/py-record-btrace.h: Rename include guard.
10427         * python/py-instruction.h: Rename include guard.
10428         * python/py-events.h: Rename include guard.
10429         * python/py-event.h: Rename include guard.
10430         * procfs.h: Add include guard.
10431         * proc-utils.h: Add include guard.
10432         * p-lang.h: Add include guard.
10433         * or1k-tdep.h: Rename include guard.
10434         * observable.h: Rename include guard.
10435         * nto-tdep.h: Rename include guard.
10436         * nat/x86-linux.h: Rename include guard.
10437         * nat/x86-linux-dregs.h: Rename include guard.
10438         * nat/x86-gcc-cpuid.h: Add include guard.
10439         * nat/x86-dregs.h: Rename include guard.
10440         * nat/x86-cpuid.h: Rename include guard.
10441         * nat/ppc-linux.h: Rename include guard.
10442         * nat/mips-linux-watch.h: Rename include guard.
10443         * nat/linux-waitpid.h: Rename include guard.
10444         * nat/linux-ptrace.h: Rename include guard.
10445         * nat/linux-procfs.h: Rename include guard.
10446         * nat/linux-osdata.h: Rename include guard.
10447         * nat/linux-nat.h: Rename include guard.
10448         * nat/linux-namespaces.h: Rename include guard.
10449         * nat/linux-btrace.h: Rename include guard.
10450         * nat/glibc_thread_db.h: Rename include guard.
10451         * nat/gdb_thread_db.h: Rename include guard.
10452         * nat/gdb_ptrace.h: Rename include guard.
10453         * nat/fork-inferior.h: Rename include guard.
10454         * nat/amd64-linux-siginfo.h: Rename include guard.
10455         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10456         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10457         * nat/aarch64-linux.h: Rename include guard.
10458         * nat/aarch64-linux-hw-point.h: Rename include guard.
10459         * mn10300-tdep.h: Add include guard.
10460         * mips-linux-tdep.h: Add include guard.
10461         * mi/mi-parse.h: Rename include guard.
10462         * mi/mi-out.h: Rename include guard.
10463         * mi/mi-main.h: Rename include guard.
10464         * mi/mi-interp.h: Rename include guard.
10465         * mi/mi-getopt.h: Rename include guard.
10466         * mi/mi-console.h: Rename include guard.
10467         * mi/mi-common.h: Rename include guard.
10468         * mi/mi-cmds.h: Rename include guard.
10469         * mi/mi-cmd-break.h: Rename include guard.
10470         * m2-lang.h: Add include guard.
10471         * location.h: Rename include guard.
10472         * linux-record.h: Rename include guard.
10473         * linux-nat.h: Add include guard.
10474         * linux-fork.h: Add include guard.
10475         * i386-darwin-tdep.h: Rename include guard.
10476         * hppa-linux-offsets.h: Add include guard.
10477         * guile/guile.h: Rename include guard.
10478         * guile/guile-internal.h: Rename include guard.
10479         * gnu-nat.h: Rename include guard.
10480         * gdb-stabs.h: Rename include guard.
10481         * frv-tdep.h: Add include guard.
10482         * f-lang.h: Add include guard.
10483         * event-loop.h: Add include guard.
10484         * darwin-nat.h: Rename include guard.
10485         * cp-abi.h: Rename include guard.
10486         * config/sparc/nm-sol2.h: Rename include guard.
10487         * config/nm-nto.h: Rename include guard.
10488         * config/nm-linux.h: Add include guard.
10489         * config/i386/nm-i386gnu.h: Rename include guard.
10490         * config/djgpp/nl_types.h: Rename include guard.
10491         * config/djgpp/langinfo.h: Rename include guard.
10492         * compile/gcc-cp-plugin.h: Add include guard.
10493         * compile/gcc-c-plugin.h: Add include guard.
10494         * compile/compile.h: Rename include guard.
10495         * compile/compile-object-run.h: Rename include guard.
10496         * compile/compile-object-load.h: Rename include guard.
10497         * compile/compile-internal.h: Rename include guard.
10498         * compile/compile-cplus.h: Rename include guard.
10499         * compile/compile-c.h: Rename include guard.
10500         * common/xml-utils.h: Rename include guard.
10501         * common/x86-xstate.h: Rename include guard.
10502         * common/version.h: Rename include guard.
10503         * common/vec.h: Rename include guard.
10504         * common/tdesc.h: Rename include guard.
10505         * common/selftest.h: Rename include guard.
10506         * common/scoped_restore.h: Rename include guard.
10507         * common/scoped_mmap.h: Rename include guard.
10508         * common/scoped_fd.h: Rename include guard.
10509         * common/safe-iterator.h: Rename include guard.
10510         * common/run-time-clock.h: Rename include guard.
10511         * common/refcounted-object.h: Rename include guard.
10512         * common/queue.h: Rename include guard.
10513         * common/ptid.h: Rename include guard.
10514         * common/print-utils.h: Rename include guard.
10515         * common/preprocessor.h: Rename include guard.
10516         * common/pathstuff.h: Rename include guard.
10517         * common/observable.h: Rename include guard.
10518         * common/netstuff.h: Rename include guard.
10519         * common/job-control.h: Rename include guard.
10520         * common/host-defs.h: Rename include guard.
10521         * common/gdb_wait.h: Rename include guard.
10522         * common/gdb_vecs.h: Rename include guard.
10523         * common/gdb_unlinker.h: Rename include guard.
10524         * common/gdb_unique_ptr.h: Rename include guard.
10525         * common/gdb_tilde_expand.h: Rename include guard.
10526         * common/gdb_sys_time.h: Rename include guard.
10527         * common/gdb_string_view.h: Rename include guard.
10528         * common/gdb_splay_tree.h: Rename include guard.
10529         * common/gdb_setjmp.h: Rename include guard.
10530         * common/gdb_ref_ptr.h: Rename include guard.
10531         * common/gdb_optional.h: Rename include guard.
10532         * common/gdb_locale.h: Rename include guard.
10533         * common/gdb_assert.h: Rename include guard.
10534         * common/filtered-iterator.h: Rename include guard.
10535         * common/filestuff.h: Rename include guard.
10536         * common/fileio.h: Rename include guard.
10537         * common/environ.h: Rename include guard.
10538         * common/common-utils.h: Rename include guard.
10539         * common/common-types.h: Rename include guard.
10540         * common/common-regcache.h: Rename include guard.
10541         * common/common-inferior.h: Rename include guard.
10542         * common/common-gdbthread.h: Rename include guard.
10543         * common/common-exceptions.h: Rename include guard.
10544         * common/common-defs.h: Rename include guard.
10545         * common/common-debug.h: Rename include guard.
10546         * common/cleanups.h: Rename include guard.
10547         * common/buffer.h: Rename include guard.
10548         * common/btrace-common.h: Rename include guard.
10549         * common/break-common.h: Rename include guard.
10550         * cli/cli-utils.h: Rename include guard.
10551         * cli/cli-style.h: Rename include guard.
10552         * cli/cli-setshow.h: Rename include guard.
10553         * cli/cli-script.h: Rename include guard.
10554         * cli/cli-interp.h: Rename include guard.
10555         * cli/cli-decode.h: Rename include guard.
10556         * cli/cli-cmds.h: Rename include guard.
10557         * charset-list.h: Add include guard.
10558         * buildsym-legacy.h: Rename include guard.
10559         * bfin-tdep.h: Add include guard.
10560         * ax.h: Rename include guard.
10561         * arm-linux-tdep.h: Add include guard.
10562         * arm-fbsd-tdep.h: Add include guard.
10563         * arch/xtensa.h: Rename include guard.
10564         * arch/tic6x.h: Add include guard.
10565         * arch/i386.h: Add include guard.
10566         * arch/arm.h: Rename include guard.
10567         * arch/arm-linux.h: Rename include guard.
10568         * arch/arm-get-next-pcs.h: Rename include guard.
10569         * arch/amd64.h: Add include guard.
10570         * arch/aarch64-insn.h: Rename include guard.
10571         * arch-utils.h: Rename include guard.
10572         * annotate.h: Add include guard.
10573         * amd64-darwin-tdep.h: Rename include guard.
10574         * aarch64-linux-tdep.h: Add include guard.
10575         * aarch64-fbsd-tdep.h: Add include guard.
10576         * aarch32-linux-nat.h: Add include guard.
10577
10578 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10579
10580         * macrotab.c (macro_define_internal): New function that
10581         factorizes macro_define_object_internal and macro_define_function
10582         code.
10583         (macro_define_object_internal): Use macro_define_internal.
10584         (macro_define_function): Likewise.
10585
10586 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10587
10588         * macrocmd.c (extract_identifier): Return
10589         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10590         callers.
10591
10592 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10593
10594         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10595
10596 2019-02-05  Tom Tromey  <tom@tromey.com>
10597
10598         * target.c (target_stack::unpush): Move assertion earlier.
10599
10600 2019-01-30  Tom Tromey  <tom@tromey.com>
10601
10602         PR python/23615:
10603         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10604         (gdbpy_parse_and_eval): Likewise.
10605         * python/python-internal.h (gdbpy_allow_threads): New class.
10606
10607 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10608
10609         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10610         (aarch64_fbsd_fpregmap): Move earlier.
10611         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10612         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10613         instead of individual calls to trad_frame_set_reg_addr.
10614         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10615         earlier.
10616         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10617         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10618         instead of individual calls to trad_frame_set_reg_addr.
10619
10620 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10621
10622         * CONTRIBUTE: Replace contribution list with wiki link.
10623
10624 2019-01-25  Tom Tromey  <tom@tromey.com>
10625
10626         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10627
10628 2019-01-25  Tom Tromey  <tom@tromey.com>
10629
10630         * xtensa-linux-nat.c: Fix common/ includes.
10631         * xml-support.h: Fix common/ includes.
10632         * xml-support.c: Fix common/ includes.
10633         * x86-linux-nat.c: Fix common/ includes.
10634         * windows-nat.c: Fix common/ includes.
10635         * varobj.h: Fix common/ includes.
10636         * varobj.c: Fix common/ includes.
10637         * value.c: Fix common/ includes.
10638         * valops.c: Fix common/ includes.
10639         * utils.c: Fix common/ includes.
10640         * unittests/xml-utils-selftests.c: Fix common/ includes.
10641         * unittests/utils-selftests.c: Fix common/ includes.
10642         * unittests/unpack-selftests.c: Fix common/ includes.
10643         * unittests/tracepoint-selftests.c: Fix common/ includes.
10644         * unittests/style-selftests.c: Fix common/ includes.
10645         * unittests/string_view-selftests.c: Fix common/ includes.
10646         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10647         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10648         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10649         * unittests/rsp-low-selftests.c: Fix common/ includes.
10650         * unittests/parse-connection-spec-selftests.c: Fix common/
10651         includes.
10652         * unittests/optional-selftests.c: Fix common/ includes.
10653         * unittests/offset-type-selftests.c: Fix common/ includes.
10654         * unittests/observable-selftests.c: Fix common/ includes.
10655         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10656         * unittests/memrange-selftests.c: Fix common/ includes.
10657         * unittests/memory-map-selftests.c: Fix common/ includes.
10658         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10659         * unittests/function-view-selftests.c: Fix common/ includes.
10660         * unittests/environ-selftests.c: Fix common/ includes.
10661         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10662         * unittests/common-utils-selftests.c: Fix common/ includes.
10663         * unittests/cli-utils-selftests.c: Fix common/ includes.
10664         * unittests/array-view-selftests.c: Fix common/ includes.
10665         * ui-file.c: Fix common/ includes.
10666         * tui/tui-io.c: Fix common/ includes.
10667         * tracepoint.h: Fix common/ includes.
10668         * tracepoint.c: Fix common/ includes.
10669         * tracefile-tfile.c: Fix common/ includes.
10670         * top.h: Fix common/ includes.
10671         * top.c: Fix common/ includes.
10672         * thread.c: Fix common/ includes.
10673         * target/waitstatus.h: Fix common/ includes.
10674         * target/waitstatus.c: Fix common/ includes.
10675         * target.h: Fix common/ includes.
10676         * target.c: Fix common/ includes.
10677         * target-memory.c: Fix common/ includes.
10678         * target-descriptions.c: Fix common/ includes.
10679         * symtab.h: Fix common/ includes.
10680         * symfile.c: Fix common/ includes.
10681         * stap-probe.c: Fix common/ includes.
10682         * spu-linux-nat.c: Fix common/ includes.
10683         * sparc-nat.c: Fix common/ includes.
10684         * source.c: Fix common/ includes.
10685         * solib.c: Fix common/ includes.
10686         * solib-target.c: Fix common/ includes.
10687         * ser-unix.c: Fix common/ includes.
10688         * ser-tcp.c: Fix common/ includes.
10689         * ser-pipe.c: Fix common/ includes.
10690         * ser-base.c: Fix common/ includes.
10691         * selftest-arch.c: Fix common/ includes.
10692         * s12z-tdep.c: Fix common/ includes.
10693         * rust-exp.y: Fix common/ includes.
10694         * rs6000-aix-tdep.c: Fix common/ includes.
10695         * riscv-tdep.c: Fix common/ includes.
10696         * remote.c: Fix common/ includes.
10697         * remote-notif.h: Fix common/ includes.
10698         * remote-fileio.h: Fix common/ includes.
10699         * remote-fileio.c: Fix common/ includes.
10700         * regcache.h: Fix common/ includes.
10701         * regcache.c: Fix common/ includes.
10702         * record-btrace.c: Fix common/ includes.
10703         * python/python.c: Fix common/ includes.
10704         * python/py-type.c: Fix common/ includes.
10705         * python/py-inferior.c: Fix common/ includes.
10706         * progspace.h: Fix common/ includes.
10707         * producer.c: Fix common/ includes.
10708         * procfs.c: Fix common/ includes.
10709         * proc-api.c: Fix common/ includes.
10710         * printcmd.c: Fix common/ includes.
10711         * ppc-linux-nat.c: Fix common/ includes.
10712         * parser-defs.h: Fix common/ includes.
10713         * osdata.c: Fix common/ includes.
10714         * obsd-nat.c: Fix common/ includes.
10715         * nat/x86-linux.c: Fix common/ includes.
10716         * nat/x86-linux-dregs.c: Fix common/ includes.
10717         * nat/x86-dregs.h: Fix common/ includes.
10718         * nat/x86-dregs.c: Fix common/ includes.
10719         * nat/ppc-linux.c: Fix common/ includes.
10720         * nat/mips-linux-watch.h: Fix common/ includes.
10721         * nat/mips-linux-watch.c: Fix common/ includes.
10722         * nat/linux-waitpid.c: Fix common/ includes.
10723         * nat/linux-ptrace.h: Fix common/ includes.
10724         * nat/linux-ptrace.c: Fix common/ includes.
10725         * nat/linux-procfs.c: Fix common/ includes.
10726         * nat/linux-personality.c: Fix common/ includes.
10727         * nat/linux-osdata.c: Fix common/ includes.
10728         * nat/linux-namespaces.c: Fix common/ includes.
10729         * nat/linux-btrace.h: Fix common/ includes.
10730         * nat/linux-btrace.c: Fix common/ includes.
10731         * nat/fork-inferior.c: Fix common/ includes.
10732         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10733         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10734         * nat/aarch64-linux.c: Fix common/ includes.
10735         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10736         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10737         * namespace.h: Fix common/ includes.
10738         * mips-linux-tdep.c: Fix common/ includes.
10739         * minsyms.c: Fix common/ includes.
10740         * mi/mi-parse.h: Fix common/ includes.
10741         * mi/mi-main.c: Fix common/ includes.
10742         * mi/mi-cmd-env.c: Fix common/ includes.
10743         * memrange.h: Fix common/ includes.
10744         * memattr.c: Fix common/ includes.
10745         * maint.h: Fix common/ includes.
10746         * maint.c: Fix common/ includes.
10747         * main.c: Fix common/ includes.
10748         * machoread.c: Fix common/ includes.
10749         * location.c: Fix common/ includes.
10750         * linux-thread-db.c: Fix common/ includes.
10751         * linux-nat.c: Fix common/ includes.
10752         * linux-fork.c: Fix common/ includes.
10753         * inline-frame.c: Fix common/ includes.
10754         * infrun.c: Fix common/ includes.
10755         * inflow.c: Fix common/ includes.
10756         * inferior.h: Fix common/ includes.
10757         * inferior.c: Fix common/ includes.
10758         * infcmd.c: Fix common/ includes.
10759         * inf-ptrace.c: Fix common/ includes.
10760         * inf-child.c: Fix common/ includes.
10761         * ia64-linux-nat.c: Fix common/ includes.
10762         * i387-tdep.c: Fix common/ includes.
10763         * i386-tdep.c: Fix common/ includes.
10764         * i386-linux-tdep.c: Fix common/ includes.
10765         * i386-linux-nat.c: Fix common/ includes.
10766         * i386-go32-tdep.c: Fix common/ includes.
10767         * i386-fbsd-tdep.c: Fix common/ includes.
10768         * i386-fbsd-nat.c: Fix common/ includes.
10769         * guile/scm-type.c: Fix common/ includes.
10770         * guile/guile.c: Fix common/ includes.
10771         * go32-nat.c: Fix common/ includes.
10772         * gnu-nat.c: Fix common/ includes.
10773         * gdbthread.h: Fix common/ includes.
10774         * gdbarch-selftests.c: Fix common/ includes.
10775         * gdb_usleep.c: Fix common/ includes.
10776         * gdb_select.h: Fix common/ includes.
10777         * gdb_bfd.c: Fix common/ includes.
10778         * gcore.c: Fix common/ includes.
10779         * fork-child.c: Fix common/ includes.
10780         * findvar.c: Fix common/ includes.
10781         * fbsd-nat.c: Fix common/ includes.
10782         * event-top.c: Fix common/ includes.
10783         * event-loop.c: Fix common/ includes.
10784         * dwarf2read.c: Fix common/ includes.
10785         * dwarf2loc.c: Fix common/ includes.
10786         * dwarf2-frame.c: Fix common/ includes.
10787         * dwarf-index-cache.c: Fix common/ includes.
10788         * dtrace-probe.c: Fix common/ includes.
10789         * disasm-selftests.c: Fix common/ includes.
10790         * defs.h: Fix common/ includes.
10791         * csky-tdep.c: Fix common/ includes.
10792         * cp-valprint.c: Fix common/ includes.
10793         * cp-support.h: Fix common/ includes.
10794         * cp-support.c: Fix common/ includes.
10795         * corelow.c: Fix common/ includes.
10796         * completer.h: Fix common/ includes.
10797         * completer.c: Fix common/ includes.
10798         * compile/compile.c: Fix common/ includes.
10799         * compile/compile-loc2c.c: Fix common/ includes.
10800         * compile/compile-cplus-types.c: Fix common/ includes.
10801         * compile/compile-cplus-symbols.c: Fix common/ includes.
10802         * command.h: Fix common/ includes.
10803         * cli/cli-dump.c: Fix common/ includes.
10804         * cli/cli-cmds.c: Fix common/ includes.
10805         * charset.c: Fix common/ includes.
10806         * build-id.c: Fix common/ includes.
10807         * btrace.h: Fix common/ includes.
10808         * btrace.c: Fix common/ includes.
10809         * breakpoint.h: Fix common/ includes.
10810         * breakpoint.c: Fix common/ includes.
10811         * ax.h:
10812         (enum agent_op): Fix common/ includes.
10813         * ax-general.c (struct aop_map): Fix common/ includes.
10814         * ax-gdb.c: Fix common/ includes.
10815         * auxv.c: Fix common/ includes.
10816         * auto-load.c: Fix common/ includes.
10817         * arm-tdep.c: Fix common/ includes.
10818         * arch/riscv.c: Fix common/ includes.
10819         * arch/ppc-linux-common.c: Fix common/ includes.
10820         * arch/i386.c: Fix common/ includes.
10821         * arch/arm.c: Fix common/ includes.
10822         * arch/arm-linux.c: Fix common/ includes.
10823         * arch/arm-get-next-pcs.c: Fix common/ includes.
10824         * arch/amd64.c: Fix common/ includes.
10825         * arch/aarch64.c: Fix common/ includes.
10826         * arch/aarch64-insn.c: Fix common/ includes.
10827         * arch-utils.c: Fix common/ includes.
10828         * amd64-windows-tdep.c: Fix common/ includes.
10829         * amd64-tdep.c: Fix common/ includes.
10830         * amd64-sol2-tdep.c: Fix common/ includes.
10831         * amd64-obsd-tdep.c: Fix common/ includes.
10832         * amd64-nbsd-tdep.c: Fix common/ includes.
10833         * amd64-linux-tdep.c: Fix common/ includes.
10834         * amd64-linux-nat.c: Fix common/ includes.
10835         * amd64-fbsd-tdep.c: Fix common/ includes.
10836         * amd64-fbsd-nat.c: Fix common/ includes.
10837         * amd64-dicos-tdep.c: Fix common/ includes.
10838         * amd64-darwin-tdep.c: Fix common/ includes.
10839         * agent.c: Fix common/ includes.
10840         * ada-lang.h: Fix common/ includes.
10841         * ada-lang.c: Fix common/ includes.
10842         * aarch64-tdep.c: Fix common/ includes.
10843
10844 2019-01-25  Tom Tromey  <tom@tromey.com>
10845
10846         * common/create-version.sh: Use common/version.h.
10847
10848 2019-01-24  Pedro Alves  <palves@redhat.com>
10849
10850         * infrun.c (signal_stop, signal_print, signal_program)
10851         (signal_catch, signal_pass): Now arrays instead of pointers.
10852         (update_signals_program_target, do_target_resume)
10853         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10854         * linux-nat.c (linux_nat_target::pass_signals)
10855         (linux_nat_target::create_inferior, linux_nat_target::attach):
10856         Adjust.
10857         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10858         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10859         * procfs.c (procfs_target::pass_signals): Adjust.
10860         * record-full.c (record_full_target::resume): Adjust.
10861         * remote.c (remote_target::pass_signals)
10862         (remote_target::program_signals): Adjust.
10863         * target-debug.h (target_debug_print_signals): Now takes a
10864         gdb::array_view as parameter.  Adjust.
10865         * target.h (target_ops) <pass_signals, program_signals>: Replace
10866         pointer and length parameters with gdb::array_view.
10867         (target_pass_signals, target_program_signals): Likewise.
10868         * target-delegates.c: Regenerate.
10869
10870 2019-01-24  Pedro Alves  <palves@redhat.com>
10871
10872         * common/forward-scope-exit.h
10873         (forward_scope_exit::forward_scope_exit): Pass arguments to
10874         m_bind_function directly, instead of creating a std::bind and
10875         copying that.
10876
10877 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10878
10879         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10880         for static members.
10881         (pass_in_v_vfp_candidate): Likewise.
10882
10883 2019-01-23  Tom Tromey  <tom@tromey.com>
10884             Pedro Alves  <palves@redhat.com>
10885
10886         * regcache.c (class regcache_invalidator): Remove.
10887         (regcache::raw_write): Use make_scope_exit.
10888
10889 2019-01-23  Tom Tromey  <tom@tromey.com>
10890
10891         * ui-out.h (class ui_out_emit_type): Update comment.
10892
10893 2019-01-23  Tom Tromey  <tom@tromey.com>
10894
10895         * infrun.c (fetch_inferior_event): Update comment.
10896
10897 2019-01-23  Tom Tromey  <tom@tromey.com>
10898             Pedro Alves  <palves@redhat.com>
10899
10900         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10901         parameter.
10902         (fetch_inferior_event): Use SCOPE_EXIT.
10903
10904
10905 2019-01-23  Tom Tromey  <tom@tromey.com>
10906             Pedro Alves  <palves@redhat.com>
10907
10908         * infrun.c (disable_thread_events): Delete.
10909         (stop_all_threads): Use SCOPE_EXIT.
10910
10911 2019-01-23  Tom Tromey  <tom@tromey.com>
10912             Pedro Alves  <palves@redhat.com>
10913
10914         * symfile.c: Include forward-scope-exit.h.
10915         (clear_symtab_users_cleanup): Replace forward declaration with
10916         a FORWARD_SCOPE_EXIT.
10917         (syms_from_objfile_1): Use the forward_scope_exit and
10918         gdb::optional instead of cleanup_function.
10919         (reread_symbols): Use the forward_scope_exit instead of
10920         cleanup_function.
10921         (clear_symtab_users_cleanup): Remove function.
10922
10923 2019-01-23  Tom Tromey  <tom@tromey.com>
10924             Pedro Alves  <palves@redhat.com>
10925
10926         * linux-nat.c: Include scope-exit.h.
10927         (cleanup_target_stop): Remove.
10928         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10929         SCOPE_EXIT.
10930
10931 2019-01-23  Tom Tromey  <tom@tromey.com>
10932             Pedro Alves  <palves@redhat.com>
10933
10934         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10935         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10936
10937 2019-01-23  Tom Tromey  <tom@tromey.com>
10938             Andrew Burgess  <andrew.burgess@embecosm.com>
10939             Pedro Alves  <palves@redhat.com>
10940
10941         * infrun.c (fetch_inferior_event): Use scope_exit.
10942         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10943         * top.c (execute_command): Use scope_exit.
10944         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10945         * utils.c (do_bpstat_clear_actions_cleanup)
10946         (make_bpstat_clear_actions_cleanup): Remove.
10947
10948 2019-01-23  Tom Tromey  <tom@tromey.com>
10949             Pedro Alves  <palves@redhat.com>
10950
10951         * infrun.c: Include "common/scope-exit.h"
10952         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10953         (wait_for_inferior): Use SCOPE_EXIT.
10954         (fetch_inferior_event): Use scope_exit.
10955
10956 2019-01-23  Tom Tromey  <tom@tromey.com>
10957             Pedro Alves  <palves@redhat.com>
10958
10959         * breakpoint.c (create_breakpoint): Remove cleanup.
10960
10961 2019-01-23  Tom Tromey  <tom@tromey.com>
10962             Andrew Burgess  <andrew.burgess@embecosm.com>
10963             Pedro Alves  <palves@redhat.com>
10964
10965 2019-01-23  Pedro Alves  <palves@redhat.com>
10966
10967         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10968
10969 2019-01-23  Pedro Alves  <palves@redhat.com>
10970             Andrew Burgess  <andrew.burgess@embecosm.com>
10971
10972         * gdbthread.h: Include "common/forward-scope-exit.h".
10973         (scoped_finish_thread_state): Redefine custom class in terms of
10974         forward_scope_exit.
10975
10976 2019-01-23  Pedro Alves  <palves@redhat.com>
10977             Andrew Burgess  <andrew.burgess@embecosm.com>
10978
10979         * common/forward-scope-exit.h: New file.
10980
10981 2019-01-23  Pedro Alves  <palves@redhat.com>
10982             Andrew Burgess  <andrew.burgess@embecosm.com>
10983             Tom Tromey  <tom@tromey.com>
10984
10985         * common/scope-exit.h: New file.
10986
10987 2019-01-23  Pedro Alves  <palves@redhat.com>
10988
10989         * common/preprocessor.h (ESC): Rename to ...
10990         (ESC_PARENS): ... this.
10991         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10992         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10993
10994 2019-01-23  Tom Tromey  <tom@tromey.com>
10995
10996         * language.h (class scoped_switch_to_sym_language_if_auto):
10997         Initialize m_lang in both cases.
10998
10999 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11000
11001         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11002         with XCNEW.
11003
11004 2019-01-22  Tom Tromey  <tom@tromey.com>
11005
11006         * corelow.c: Do not include sys/file.h.
11007
11008 2019-01-22  Tom Tromey  <tom@tromey.com>
11009
11010         * tui/tui-wingeneral.h: Include gdb_curses.h.
11011
11012 2019-01-22  Tom Tromey  <tom@tromey.com>
11013
11014         * source-cache.h (class source_cache) <get_source_lines,
11015         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11016
11017 2019-01-22  Tom Tromey  <tom@tromey.com>
11018
11019         * remote-fileio.h (struct remote_target): Declare.
11020
11021 2019-01-22  Tom Tromey  <tom@tromey.com>
11022
11023         * python/py-arch.c: Do not include py-ref.h.
11024         * python/py-bpevent.c: Do not include py-ref.h.
11025         * python/py-cmd.c: Do not include py-ref.h.
11026         * python/py-continueevent.c: Do not include py-ref.h.
11027         * python/py-event.h: Do not include py-ref.h.
11028         * python/py-evtregistry.c: Do not include py-ref.h.
11029         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11030         * python/py-frame.c: Do not include py-ref.h.
11031         * python/py-framefilter.c: Do not include py-ref.h.
11032         * python/py-function.c: Do not include py-ref.h.
11033         * python/py-infevents.c: Do not include py-ref.h.
11034         * python/py-linetable.c: Do not include py-ref.h.
11035         * python/py-objfile.c: Do not include py-ref.h.
11036         * python/py-param.c: Do not include py-ref.h.
11037         * python/py-prettyprint.c: Do not include py-ref.h.
11038         * python/py-progspace.c: Do not include py-ref.h.
11039         * python/py-symbol.c: Do not include py-ref.h.
11040         * python/py-symtab.c: Do not include py-ref.h.
11041         * python/py-type.c: Do not include py-ref.h.
11042         * python/py-unwind.c: Do not include py-ref.h.
11043         * python/py-utils.c: Do not include py-ref.h.
11044         * python/py-value.c: Do not include py-ref.h.
11045         * python/py-varobj.c: Do not include py-ref.h.
11046         * python/py-xmethods.c: Do not include py-ref.h.
11047         * python/python.c: Do not include py-ref.h.
11048         * varobj.c: Do not include py-ref.h.
11049
11050 2019-01-22  Tom Tromey  <tom@tromey.com>
11051
11052         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11053         keyword for bcache.
11054
11055 2019-01-22  Tom Tromey  <tom@tromey.com>
11056
11057         * compile/compile-cplus-types.c: Remove a comment by #include.
11058
11059 2019-01-22  Tom Tromey  <tom@tromey.com>
11060
11061         * compile/gcc-c-plugin.h: Include compile-internal.h.
11062
11063 2019-01-22  Tom Tromey  <tom@tromey.com>
11064
11065         * stabsread.c (EXTERN): Do not define.
11066         (symnum, next_symbol_text_func, processing_gcc_compilation)
11067         (within_function, global_sym_chain, global_stabs)
11068         (previous_stab_code, this_object_header_files)
11069         (n_this_object_header_files)
11070         (n_allocated_this_object_header_files): Define.
11071         * stabsread.h (EXTERN): Never define.  Use "extern".
11072
11073 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11074
11075         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11076         history_value.
11077
11078 2019-01-21  Tom Tromey  <tom@tromey.com>
11079
11080         * ui-out.c: Fix includes.
11081         * tui/tui-source.c: Fix includes.
11082         * target.c: Fix includes.
11083         * remote.c: Fix includes.
11084         * regcache.c: Fix includes.
11085         * python/py-block.c: Fix includes.
11086         * printcmd.c: Fix includes.
11087         * or1k-tdep.c: Fix includes.
11088         * mi/mi-main.c: Fix includes.
11089         * m32r-tdep.c: Fix includes.
11090         * csky-tdep.c: Fix includes.
11091         * compile/compile-cplus-types.c: Fix includes.
11092         * cli/cli-interp.c: Fix includes.
11093
11094 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11095
11096         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11097         for padding.
11098
11099 2019-01-16  Tom Tromey  <tom@tromey.com>
11100
11101         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11102         earlier.
11103         (struct objfile) <msymbols_range>: Move from top level.
11104         <msymbols>: New method.
11105         (class objfile_msymbols): Remove.
11106         * symtab.c (default_collect_symbol_completion_matches_break_on):
11107         Update.
11108         * symmisc.c (dump_msymbols): Update.
11109         * stabsread.c (scan_file_globals): Update.
11110         * objc-lang.c (info_selectors_command, info_classes_command)
11111         (find_methods): Update.
11112         * minsyms.c (find_solib_trampoline_target): Update.
11113         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11114         * coffread.c (coff_symfile_read): Update.
11115         * ada-lang.c (ada_lookup_simple_minsym)
11116         (ada_collect_symbol_completion_matches): Update.
11117
11118 2019-01-16  Tom Tromey  <tom@tromey.com>
11119
11120         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11121         type.  Remove no-argument constructor.
11122         <iterator::operator++>: Simplify.
11123         <begin>: Update.
11124         <end>: Use minimal_symbol_count.
11125
11126 2019-01-16  Tom Tromey  <tom@tromey.com>
11127
11128         * objfiles.h (struct objfile) <psymtabs>: New method.
11129         (class objfile_psymtabs): Remove.
11130         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11131         typedef.
11132         <range>: New method.
11133         (require_partial_symbols): Change return type.
11134         * psymtab.c (require_partial_symbols)
11135         (psym_expand_symtabs_matching): Update.
11136         * mdebugread.c (parse_partial_symbols): Update.
11137         * dbxread.c (dbx_end_psymtab): Update.
11138
11139 2019-01-15  Tom Tromey  <tom@tromey.com>
11140
11141         * symtab.c (lookup_objfile_from_block)
11142         (lookup_symbol_in_objfile_symtabs)
11143         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11144         (find_line_symtab, info_sources_command)
11145         (default_collect_symbol_completion_matches_break_on)
11146         (make_source_files_completion_list): Update.
11147         * symmisc.c (print_objfile_statistics, dump_objfile)
11148         (maintenance_print_symbols, maintenance_info_symtabs)
11149         (maintenance_check_symtabs, maintenance_info_line_tables):
11150         Update.
11151         * source.c (select_source_symtab)
11152         (forget_cached_source_info_for_objfile): Update.
11153         * objfiles.h (class objfile_compunits): Remove.
11154         (struct objfile) <compunits_range>: New typedef.
11155         (compunits): New method.
11156         * objfiles.c (objfile_relocate1): Update.
11157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11158         * maint.c (count_symtabs_and_blocks): Update.
11159         * linespec.c (iterate_over_all_matching_symtabs): Update.
11160         * cp-support.c (add_symbol_overload_list_qualified): Update.
11161         * coffread.c (coff_symtab_read): Update.
11162         * ada-lang.c (add_nonlocal_symbols)
11163         (ada_collect_symbol_completion_matches)
11164         (ada_add_global_exceptions): Update.
11165
11166 2019-01-15  Tom Tromey  <tom@tromey.com>
11167
11168         * progspace.h (program_space) <objfiles_safe_range>: New
11169         typedef.
11170         <objfiles_safe>: New method.
11171         * objfiles.h (class all_objfiles_safe): Remove.
11172         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11173         * jit.c (jit_inferior_exit_hook): Update.
11174
11175 2019-01-17  Tom Tromey  <tom@tromey.com>
11176
11177         * progspace.h (program_space) <objfiles_range>: New typedef.
11178         <objfiles>: New method.
11179         <objfiles_head>: Rename from objfiles.
11180         (object_files): Update.
11181         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11182         * guile/scm-pretty-print.c
11183         (ppscm_find_pretty_printer_from_objfiles): Update.
11184         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11185         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11186         Update.
11187         * python/py-progspace.c (pspy_get_objfiles): Update.
11188         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11189         Update.
11190         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11191         (objfpy_lookup_objfile_by_build_id): Update.
11192         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11193         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11194         Update.
11195         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11196         (expand_symtab_containing_pc, lookup_objfile_from_block)
11197         (lookup_static_symbol, basic_lookup_transparent_type)
11198         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11199         (find_line_symtab, info_sources_command)
11200         (default_collect_symbol_completion_matches_break_on)
11201         (make_source_files_completion_list, find_main_name): Update.
11202         * symmisc.c (print_symbol_bcache_statistics)
11203         (print_objfile_statistics, maintenance_print_symbols)
11204         (maintenance_print_msymbols, maintenance_print_objfiles)
11205         (maintenance_info_symtabs, maintenance_check_symtabs)
11206         (maintenance_expand_symtabs, maintenance_info_line_tables):
11207         Update.
11208         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11209         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11210         (map_overlay_command, unmap_overlay_command)
11211         (simple_overlay_update, expand_symtabs_matching)
11212         (map_symbol_filenames): Update.
11213         * symfile-debug.c (set_debug_symfile): Update.
11214         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11215         Update.
11216         * source.c (select_source_symtab, forget_cached_source_info):
11217         Update.
11218         * solib.c (solib_read_symbols): Update.
11219         * solib-spu.c (append_ocl_sos): Update.
11220         * psymtab.c (maintenance_print_psymbols)
11221         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11222         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11223         * printcmd.c (info_symbol_command): Update.
11224         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11225         Update.
11226         * objfiles.h (class all_objfiles): Remove.
11227         * objfiles.c (have_partial_symbols, have_full_symbols)
11228         (have_minimal_symbols, qsort_cmp, update_section_map)
11229         (shared_objfile_contains_address_p)
11230         (default_iterate_over_objfiles_in_search_order): Update.
11231         * objc-lang.c (info_selectors_command, info_classes_command)
11232         (find_methods): Update.
11233         * minsyms.c (find_solib_trampoline_target): Update.
11234         * maint.c (maintenance_info_sections)
11235         (maintenance_translate_address, count_symtabs_and_blocks):
11236         Update.
11237         * main.c (captured_main_1): Update.
11238         * linux-thread-db.c (try_thread_db_load_from_pdir)
11239         (has_libpthread): Update.
11240         * linespec.c (iterate_over_all_matching_symtabs)
11241         (search_minsyms_for_name): Update.
11242         * jit.c (jit_find_objf_with_entry_addr): Update.
11243         * hppa-tdep.c (find_unwind_entry)
11244         (hppa_lookup_stub_minimal_symbol): Update.
11245         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11246         Update.
11247         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11248         (elf_gnu_ifunc_resolve_by_got): Update.
11249         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11250         * dwarf-index-write.c (save_gdb_index_command): Update.
11251         * cp-support.c (add_symbol_overload_list_qualified): Update.
11252         * breakpoint.c (create_overlay_event_breakpoint)
11253         (create_longjmp_master_breakpoint)
11254         (create_std_terminate_master_breakpoint)
11255         (create_exception_master_breakpoint): Update.
11256         * blockframe.c (find_pc_partial_function): Update.
11257         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11258         (ada_collect_symbol_completion_matches)
11259         (ada_add_global_exceptions): Update.
11260
11261 2019-01-17  Tom Tromey  <tom@tromey.com>
11262
11263         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11264         declare VEC.
11265         (solib_target_parse_libraries): Change return type.
11266         (library_list_start_segment, library_list_start_section)
11267         (library_list_end_library, library_list_start_library); Update.
11268         (solib_target_free_library_list): Remove.
11269         (solib_target_parse_libraries): Remove cleanup.  Change return
11270         type.
11271         (solib_target_current_sos): Update.
11272
11273 2019-01-17  Tom Tromey  <tromey@bapiya>
11274
11275         * valprint.c: Replace "the the" with "the".
11276         * symtab.c: Replace "the the" with "the".
11277         * solib.c: Replace "the the" with "the".
11278         * solib-dsbt.c: Replace "the the" with "the".
11279         * linespec.c: Replace "the the" with "the".
11280         * dwarf2loc.h: Replace "the the" with "the".
11281         * amd64-windows-tdep.c: Replace "the the" with "the".
11282         * aarch64-tdep.c: Replace "the the" with "the".
11283
11284 2019-01-16  Keith Seitz  <keiths@redhat.com>
11285
11286         PR gdb/23773
11287         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11288         <builder>: Rename to ..
11289         <m_builder>: ... this and make private.
11290         (dwarf2_cu::get_builder): New method.  Change all users of
11291         `builder' to use this method.
11292         (dwarf2_start_symtab): Move to ...
11293         (dwarf2_cu::start_symtab): ... here.  Update all callers
11294         (setup_type_unit_groups): Move to ...
11295         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11296         callers.
11297         (dwarf2_cu::reset_builder): New method.
11298         (process_full_compunit, process_full_type_unit): Use
11299         dwarf2_cu::reset_builder.
11300         (follow_die_offset): Record the ancestor CU if it is different
11301         from the followed DIE's CU.
11302         (follow_die_sig_1): Likewise.
11303
11304 2019-01-15  Tom Tromey  <tom@tromey.com>
11305
11306         * remote.c (class remote_state) <buf>: Now a char_vector.
11307         <buf_size>: Remove.
11308         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11309         parameter.
11310         (remote_target::getpkt_or_notif_sane_1)
11311         (remote_target::getpkt_sane)
11312         (remote_target::getpkt_or_notif_sane): Likewise.
11313         (class remote_target) <putpkt>: New overload.
11314         (remote_target::read_frame): Change type of "buf_p".  Remove
11315         sizeof_p parameter.
11316         (packet_ok): New overload.
11317         (packet_check_result): New overload.
11318         Update all uses.
11319
11320 2019-01-14  Tom Tromey  <tom@tromey.com>
11321
11322         * remote-notif.c (handle_notification, remote_notif_ack)
11323         (remote_notif_parse): Make "buf" const.
11324         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11325         const.
11326         (remote_notif_parse, remote_notif_ack, handle_notification):
11327         Likewise.
11328         * remote.c (remote_notif_stop_parse): Make "buf" const.
11329         (remote_target::remote_parse_stop_reply): Make "buf" const.
11330         (remote_notif_stop_ack): Make "buf" const.
11331
11332 2019-01-14  Tom Tromey  <tom@tromey.com>
11333
11334         * remote.c (remote_console_output): Make parameter const.
11335
11336 2019-01-14  Tom Tromey  <tom@tromey.com>
11337
11338         * target-debug.h (target_debug_print_signals): Constify.
11339         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11340         * procfs.c (procfs_target::pass_signals): Update.
11341         * linux-nat.c (linux_nat_target::pass_signals): Update.
11342         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11343         * target-delegates.c: Rebuild.
11344         * remote.c (remote_target::program_signals): Update.
11345         (remote_target::pass_signals): Update.
11346         * target.c (target_pass_signals): Constify argument.
11347         (target_program_signals): Likewise.
11348         * target.h (struct target_ops) <pass_signals, program_signals>:
11349         Constify argument.
11350         (target_pass_signals, target_program_signals): Constify argument.
11351
11352 2019-01-14  Tom Tromey  <tom@tromey.com>
11353
11354         PR tui/28819:
11355         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11356
11357 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11358
11359         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11360         field.
11361         * rs6000-tdep.c: Include reggroups.h.
11362         (IS_V_ALIAS_PSEUDOREG): Define.
11363         (rs6000_register_name): Return names for the "vX" aliases.
11364         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11365         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11366         aliases.  Call default_register_reggroup_p for all other
11367         pseudo-registers.
11368         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11369         New functions.
11370         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11371         Handle "vX" aliases.
11372         (v_alias_pseudo_register_collect): New function.
11373         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11374         (rs6000_gdbarch_init): Initialize "vX" aliases as
11375         pseudo-registers.  Restore registration of
11376         rs6000_pseudo_register_reggroup_p with
11377         set_tdesc_pseudo_register_reggroup_p.
11378
11379 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11380
11381         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11382         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11383         set_gdbarch_num_pseudo_regs.
11384
11385 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11386
11387         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11388         Remove arg prefixname, add do_set and do_show.
11389         Add member functions set_list and show_list.
11390         * cli/cli-style.c (class cli_style_option): Update accordingly.
11391         (style_set_list): Move to file scope.
11392         (style_show_list): Likewise.
11393         (set_style): Call help_list.
11394         (show_style): Call cmd_show_list.
11395         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11396         Update to use the new macro.
11397
11398 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11399
11400         * ada-lang.c (_initialize_ada_language): Expand the help text
11401         for the "catch exception" command.
11402
11403 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11404
11405         * symtab.c (matching_obj_sections): Initialize obj,
11406         declare it closer to its usage.
11407
11408 2019-01-10  Tom Tromey  <tom@tromey.com>
11409
11410         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11411         (basic_inf_threads_range): Remove.
11412         (inf_threads_range, inf_non_exited_threads_range)
11413         (safe_inf_threads_range): Use next_adapter.
11414
11415 2019-01-10  Keith Seitz  <keiths@redhat.com>
11416
11417         PR gdb/23712
11418         PR symtab/23010
11419         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11420         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11421
11422 2019-01-10  Keith Seitz  <keiths@redhat.com>
11423
11424         PR gdb/23712
11425         PR symtab/23010
11426         * dictionary.c (pending_to_vector): Remove.
11427         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11428         Remove _1 suffix, replacing functions of the same name.  Update
11429         all callers.
11430         (dict_create_hashed, dict_create_hashed_expandable)
11431         (dict_create_linear, dict_create_linear_expandable, dict_free)
11432         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11433         Make functions static.
11434
11435 2019-01-10  Keith Seitz  <keiths@redhat.com>
11436
11437         PR gdb/23712
11438         PR symtab/23010
11439         * dictionary.h (struct dictionary): Replace declaration with
11440         multidictionary.
11441         (dict_create_hashed, dict_create_hashed_expandable)
11442         (dict_create_linear, dict_create_linear_expandable)
11443         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11444         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11445         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11446         taking multidictionary argument.
11447         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11448         * block.h (struct block) <dict>: Change to multidictionary
11449         and rename `multidict'.
11450         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11451         symmisc.c: Update all dictionary references to multidictionary.
11452
11453 2019-01-10  Keith Seitz  <keiths@redhat.com>
11454
11455         PR gdb/23712
11456         PR symtab/23010
11457         * dictionary.c: Include unordered_map.
11458         (pending_to_vector): New function.
11459         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11460         Rewrite the non-"_1" functions to take vector instead
11461         of linked list.
11462         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11463         "new" _1 versions of the same name.
11464         (multidictionary): Define.
11465         (std::hash<enum language): New definition.
11466         (collate_pending_symbols_by_language, mdict_create_hashed)
11467         (mdict_create_hashed_expandable, mdict_create_linear)
11468         (mdict_create_linear_expandable, mdict_free)
11469         (find_language_dictionary, create_new_language_dictionary)
11470         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11471         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11472         (mdict_size, mdict_empty): New functions.
11473         * dictionary.h (mdict_iterator): Define.
11474
11475 2019-01-10  Pedro Alves  <palves@redhat.com>
11476
11477         * breakpoint.c (read_uploaded_action)
11478         (create_tracepoint_from_upload): Adjust to use
11479         gdb::unique_xmalloc_ptr.
11480         * ctf.c (ctf_write_uploaded_tp):
11481         (SET_ARRAY_FIELD): Use emplace_back.
11482         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11483         * tracefile-tfile.c (tfile_write_uploaded_tp):
11484         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11485         gdb::unique_xmalloc_ptr.
11486         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11487         at_string, cond_string, cmd_strings>: Replace char pointers
11488         with gdb::unique_xmalloc_ptr.
11489
11490 2019-01-10  Pedro Alves  <palves@redhat.com>
11491
11492         * solib-target.c (library_list_start_library): Don't xstrdup name.
11493
11494 2019-01-10  Pedro Alves  <palves@redhat.com>
11495
11496         * mdebugread.c (parse_partial_symbols): Use
11497         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11498
11499 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11500
11501         * linux-fork.c (scoped_switch_fork_info)
11502         <~scoped_switch_fork_info>: Fix incorrect variable name.
11503
11504 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11505
11506         * linux-fork.c (scoped_switch_fork_info)
11507         <scoped_switch_fork_info>: Make explicit.
11508         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11509
11510 2019-01-10  Tom Tromey  <tom@tromey.com>
11511
11512         * objfiles.h (objfile::reset_psymtabs): Update.
11513         * objfiles.c (objfile::objfile): Update.
11514         * psymtab.h (psymtab_storage::obstack): Update.
11515         (psymtab_storage::m_obstack): Use gdb::optional.
11516         (class psymtab_storage): Update comment.  Remove objfile
11517         parameter.
11518         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11519
11520 2019-01-10  Tom Tromey  <tom@tromey.com>
11521
11522         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11523         <free_psymtabs>: Now private.
11524         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11525         (allocate_psymtab): Use new method.
11526
11527 2019-01-10  Tom Tromey  <tom@tromey.com>
11528
11529         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11530         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11531         * mdebugread.c (parse_partial_symbols): Use
11532         allocate_dependencies.
11533         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11534         allocate_dependencies.
11535         (process_psymtab_comp_unit_reader)
11536         (build_type_psymtab_dependencies): Likewise.
11537         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11538
11539 2019-01-10  Tom Tromey  <tom@tromey.com>
11540
11541         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11542         PSYMBOL_SET_LANGUAGE.
11543         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11544
11545 2019-01-10  Tom Tromey  <tom@tromey.com>
11546
11547         * psymtab.h (psymtab_storage::obstack): New method.
11548         <m_obstack>: Rename from obstack; now private.
11549         * psymtab.c (psymtab_storage): Update.
11550         * dwarf2read.c (create_addrmap_from_index)
11551         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11552         Update.
11553
11554 2019-01-10  Tom Tromey  <tom@tromey.com>
11555
11556         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11557         * objfiles.h (objfile::reset_psymtabs): New method.
11558
11559 2019-01-10  Tom Tromey  <tom@tromey.com>
11560
11561         * symmisc.c (print_symbol_bcache_statistics): Update.
11562         (print_objfile_statistics): Update.
11563         * symfile.c (reread_symbols): Update.
11564         * psymtab.h (class psymtab_storage): New.
11565         * psymtab.c (psymtab_storage): New constructor.
11566         (~psymtab_storage): New destructor.
11567         (require_partial_symbols): Update.
11568         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11569         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11570         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11571         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11572         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11573         (start_psymtab_common, end_psymtab_common)
11574         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11575         (allocate_psymtab): Update.
11576         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11577         Update.
11578         (dump_psymtab_addrmap, maintenance_print_psymbols)
11579         (maintenance_check_psymtabs): Update.
11580         (class objfile_psymtabs): Move to objfiles.h.
11581         * psympriv.h (discard_psymtab): Now inline.
11582         (psymtab_discarder::psymtab_discarder): Update.
11583         (psymtab_discarder::~psymtab_discarder): Update.
11584         (ALL_OBJFILE_PSYMTABS): Rewrite.
11585         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11586         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11587         Remove fields.
11588         <partial_symtabs>: New field.
11589         (class objfile_psymtabs): Move from psymtab.h.  Update.
11590         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11591         psymbol_cache.
11592         (objfile::~objfile): Don't destroy psymbol_cache.
11593         * mdebugread.c (parse_partial_symbols): Update.
11594         * dwarf2read.c (create_addrmap_from_index)
11595         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11596         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11597         (add_partial_subprogram, dwarf2_ranges_read): Update.
11598         * dwarf-index-write.c (write_address_map)
11599         (write_one_signatured_type, recursively_write_psymbols)
11600         (class debug_names, class debug_names, write_psymtabs_to_index):
11601         Update.
11602
11603 2019-01-10  Tom Tromey  <tom@tromey.com>
11604
11605         * symtab.h (SYMBOL_SET_NAMES): Update.
11606         (symbol_set_names): Update.
11607         (MSYMBOL_SET_NAMES): Update.
11608         * symtab.c (symbol_set_names): Change argument to be an
11609         objfile_per_bfd_storage.
11610         * psymtab.c (add_psymbol_to_bcache): Update.
11611         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11612
11613 2019-01-10  Tom Tromey  <tom@tromey.com>
11614
11615         * symtab.c (create_demangled_names_hash): Change argument to be an
11616         objfile_per_bfd_storage.
11617         (symbol_set_names): Update.
11618
11619 2019-01-10  Tom Tromey  <tom@tromey.com>
11620
11621         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11622         init_psymbol_list.
11623         * psymtab.c (init_psymbol_list): Do nothing if already called.
11624         * psympriv.h (init_psymbol_list): Add comment.
11625         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11626         init_psymbol_list.
11627         * dbxread.c (dbx_symfile_read): Unconditionally call
11628         init_psymbol_list.
11629
11630 2019-01-10  Tom Tromey  <tom@tromey.com>
11631
11632         * xcoffread.c (scan_xcoff_symtab): Update.
11633         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11634         "where".
11635         * mdebugread.c (parse_partial_symbols)
11636         (handle_psymbol_enumerators): Update.
11637         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11638         * dbxread.c (read_dbx_symtab): Update.
11639         * psympriv.h (psymbol_placement): New enum.
11640         (add_psymbol_to_list): Update.
11641
11642 2019-01-10  Tom Tromey  <tom@tromey.com>
11643
11644         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11645         static_psymbols parameters.
11646         (scan_xcoff_symtab): Update.
11647         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11648         static_psymbols parameters.
11649         * psympriv.h (start_psymtab_common): Update.
11650         * mdebugread.c (parse_partial_symbols): Update.
11651         * dwarf2read.c (create_partial_symtab): Update.
11652         * dbxread.c (read_dbx_symtab): Update.
11653         (start_psymtab): Remove global_psymbols and static_psymbols
11654         parameters.
11655
11656 2019-01-10  Tom Tromey  <tom@tromey.com>
11657
11658         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11659         * psymtab.c (allocate_psymtab): Add comment.
11660         * psympriv.h (allocate_psymtab): Add comment.
11661         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11662         initializations.
11663         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11664
11665 2019-01-10  Tom Tromey  <tom@tromey.com>
11666
11667         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11668         Don't declare.
11669         * mipsread.c: Include mdebugread.h.
11670         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11671         Declare.
11672         * elfread.c: Include mdebugread.h.
11673
11674 2019-01-09  Tom Tromey  <tom@tromey.com>
11675
11676         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11677         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11678         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11679         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11680         (psym_lookup_symbol, psym_find_last_source_symtab)
11681         (psym_forget_cached_source_info, psym_print_stats)
11682         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11683         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11684         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11685         (psym_find_compunit_symtab_by_address)
11686         (maintenance_print_psymbols, maintenance_info_psymtabs)
11687         (maintenance_check_psymtabs): Use ranged for.
11688         * psymtab.h (class objfile_psymtabs): New.
11689         (require_partial_symbols): Return objfile_psymtabs.
11690         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11691
11692 2019-01-09  Tom Tromey  <tom@tromey.com>
11693
11694         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11695         (find_pc_mapped_section, list_overlays_command)
11696         (map_overlay_command, unmap_overlay_command)
11697         (simple_overlay_update): Use all_objfiles.
11698         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11699         * printcmd.c (info_symbol_command): Use all_objfiles.
11700         * objfiles.h (ALL_OBJSECTIONS): Remove.
11701         * maint.c (maintenance_translate_address): Use all_objfiles.
11702         * gcore.c (gcore_create_callback): Use all_objfiles.
11703         (objfile_find_memory_regions): Likewise.
11704
11705 2019-01-09  Tom Tromey  <tom@tromey.com>
11706
11707         * symtab.c (find_line_symtab, info_sources_command)
11708         (make_source_files_completion_list): Use objfile_compunits.
11709         * source.c (select_source_symtab): Use objfile_compunits.
11710         * objfiles.h (struct objfile): Update comment.
11711         (ALL_OBJFILES): Remove.
11712         (ALL_FILETABS): Remove.
11713         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11714         objfile_compunits.
11715
11716 2019-01-09  Tom Tromey  <tom@tromey.com>
11717
11718         * symmisc.c (print_objfile_statistics, dump_objfile)
11719         (maintenance_print_symbols): Use compunit_filetabs.
11720         * source.c (forget_cached_source_info_for_objfile): Use
11721         compunit_filetabs.
11722         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11723         (ALL_FILETABS): Use compunit_filetabs.
11724         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11725         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11726
11727 2019-01-09  Tom Tromey  <tom@tromey.com>
11728
11729         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11730         (compunit_filetabs): New.
11731         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11732         compunit_filetabs.
11733         (info_sources_command, make_source_files_completion_list): Remove
11734         declaration.
11735         * symmisc.c (print_objfile_statistics, dump_objfile)
11736         (maintenance_print_symbols): Remove declaration.
11737         (maintenance_info_symtabs): Use compunit_filetabs.
11738         (maintenance_info_line_tables): Likewise.
11739         * source.c (select_source_symtab): Change local variable name.
11740         (forget_cached_source_info_for_objfile): Remove declaration.
11741         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11742         * objfiles.c (objfile_relocate1): Remove declaration.
11743         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11744         declaration.
11745         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11746         * coffread.c (coff_symtab_read): Remove declaration.
11747         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11748         compunit_filetabs.
11749
11750 2019-01-09  Tom Tromey  <tom@tromey.com>
11751
11752         * symtab.c (lookup_objfile_from_block)
11753         (find_pc_sect_compunit_symtab, search_symbols)
11754         (default_collect_symbol_completion_matches_break_on): Use
11755         objfile_compunits.
11756         * objfiles.h (ALL_COMPUNITS): Remove.
11757         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11758         * cp-support.c (add_symbol_overload_list_qualified): Use
11759         objfile_compunits.
11760         * ada-lang.c (ada_collect_symbol_completion_matches)
11761         (ada_add_global_exceptions): Use objfile_compunits.
11762
11763 2019-01-09  Tom Tromey  <tom@tromey.com>
11764
11765         * source.c (select_source_symtab)
11766         (forget_cached_source_info_for_objfile): Remove declaration.
11767         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11768         declaration.
11769         * maint.c (count_symtabs_and_blocks): Remove declaration.
11770         * cp-support.c (add_symbol_overload_list_qualified): Remove
11771         declaration.
11772         * coffread.c (coff_symtab_read): Remove declaration.
11773         * symtab.c (lookup_symbol_in_objfile_symtabs)
11774         (basic_lookup_transparent_type_1): Use objfile_compunits.
11775         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11776         (info_sources_command, search_symbols)
11777         (default_collect_symbol_completion_matches_break_on)
11778         (make_source_files_completion_list): Remove declaration.
11779         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11780         (ada_collect_symbol_completion_matches)
11781         (ada_add_global_exceptions): Remove declaration.
11782         * linespec.c (iterate_over_all_matching_symtabs): Use
11783         objfile_compunits.
11784         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11785         (class objfile_compunits): New.
11786         (ALL_COMPUNITS): Use objfile_compunits.
11787         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11788         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11789         objfile_compunits.
11790         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11791
11792 2019-01-09  Tom Tromey  <tom@tromey.com>
11793
11794         * symtab.c (search_symbols)
11795         (default_collect_symbol_completion_matches_break_on): Use
11796         objfile_msymbols.
11797         * ada-lang.c (ada_lookup_simple_minsym)
11798         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11799         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11800         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11801         objfile_msymbols.
11802         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11803         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11804         * objc-lang.c (find_methods): Use objfile_msymbols.
11805         (info_selectors_command, info_classes_command): Likewise.
11806         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11807         * objfiles.h (class objfile_msymbols): New.
11808         (ALL_OBJFILE_MSYMBOLS): Remove.
11809         (ALL_MSYMBOLS): Remove.
11810
11811 2019-01-09  Tom Tromey  <tom@tromey.com>
11812
11813         * common/next-iterator.h (next_adapter): Add Iterator template
11814         parameter.
11815         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11816         (class all_objfiles_safe): New.
11817         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11818         * objfiles.c (put_objfile_before): Update comment.
11819         (add_separate_debug_objfile): Likewise.
11820         (free_all_objfiles): Use all_objfiles_safe.
11821         (objfile_purge_solibs): Likewise.
11822
11823 2019-01-09  Tom Tromey  <tom@tromey.com>
11824
11825         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11826         (expand_symtab_containing_pc, lookup_static_symbol)
11827         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11828         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11829         all_objfiles.
11830         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11831         * breakpoint.c (create_overlay_event_breakpoint)
11832         (create_longjmp_master_breakpoint)
11833         (create_std_terminate_master_breakpoint)
11834         (create_exception_master_breakpoint): Use all_objfiles.
11835         * linux-thread-db.c (try_thread_db_load_from_pdir)
11836         (has_libpthread): Use all_objfiles.
11837         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11838         * linespec.c (iterate_over_all_matching_symtabs)
11839         (search_minsyms_for_name): Use all_objfiles.
11840         * maint.c (maintenance_info_sections): Use all_objfiles.
11841         * main.c (captured_main_1): Use all_objfiles.
11842         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11843         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11844         * guile/scm-pretty-print.c
11845         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11846         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11847         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11848         (maintenance_print_msymbols): Use all_objfiles.
11849         * source.c (select_source_symtab): Use all_objfiles.
11850         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11851         * symfile.c (remove_symbol_file_command)
11852         (expand_symtabs_matching, map_symbol_filenames): Use
11853         all_objfiles.
11854         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11855         all_objfiles.
11856         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11857         * objc-lang.c (find_methods): Use all_objfiles.
11858         * objfiles.c (have_partial_symbols, have_full_symbols)
11859         (have_minimal_symbols, qsort_cmp)
11860         (default_iterate_over_objfiles_in_search_order): Use
11861         all_objfiles.
11862         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11863         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11864         (maintenance_check_psymtabs): Use all_objfiles.
11865         (ALL_PSYMTABS): Remove.
11866         * compile/compile-object-run.c (do_module_cleanup): Use
11867         all_objfiles.
11868         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11869         * cp-support.c (add_symbol_overload_list_qualified): Use
11870         all_objfiles.
11871         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11872         Use all_objfiles.
11873         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11874         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11875         all_objfiles.
11876         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11877         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11878         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11879         Uses all_objfiles.
11880         * solib.c (solib_read_symbols): Use all_objfiles
11881
11882 2019-01-09  Tom Tromey  <tom@tromey.com>
11883
11884         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11885         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11886         all_objfiles.
11887         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11888         * symmisc.c (print_symbol_bcache_statistics)
11889         (print_objfile_statistics, maintenance_print_objfiles)
11890         (maintenance_info_symtabs, maintenance_check_symtabs)
11891         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11892         all_objfiles.
11893         * source.c (forget_cached_source_info): Use all_objfiles.
11894         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11895         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11896         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11897         * objfiles.c (update_section_map): Use all_objfiles.
11898         (shared_objfile_contains_address_p): Likewise.
11899         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11900         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11901
11902 2019-01-09  Tom Tromey  <tom@tromey.com>
11903
11904         * common/next-iterator.h: New file.
11905         * objfiles.h (class all_objfiles): New.
11906         (struct objfile_iterator): New.
11907
11908 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11909
11910         * NEWS: Move the description of the changed "frame", "select-frame",
11911          and "info frame" commands to the Changed commands section.
11912
11913 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11914
11915         * gdbtypes.c (check_stub_method_group): Remove handling of old
11916         mangling schemes.
11917         * linespec.c (find_methods): Likewise.
11918         * stabsread.c (read_member_functions): Likewise.
11919         * valops.c (search_struct_method): Likewise.
11920         (value_struct_elt_for_reference): Likewise.
11921         * NEWS: Mention this change.
11922
11923 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11924
11925         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11926         print_source_lines.
11927         * source.c (print_source_lines_base): Update line number check.
11928         (print_source_lines): New function.
11929         (source_lines_range::source_lines_range): New function.
11930         * source.h (class source_lines_range): New class.
11931         (print_source_lines): New declaration.
11932
11933 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11934
11935         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11936
11937 2019-01-08  Tom Tromey  <tom@tromey.com>
11938             Simon Marchi  <simon.marchi@ericsson.com>
11939
11940         PR gdb/24060
11941         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11942         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11943         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11944         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11945         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11946         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11947
11948 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11949
11950         * source.c (select_source_symtab): Move header comment to
11951         declaration in source.h.
11952         (forget_cached_source_info_for_objfile): Likewise.
11953         (forget_cached_source_info): Likewise.
11954         (identify_source_line): Likewise.
11955         * source.h (identify_source_line): Move declaration from symtab.h
11956         and add comment from source.c
11957         (print_source_lines): Likewise.
11958         (forget_cached_source_info_for_objfile): Likewise.
11959         (forget_cached_source_info): Likewise.
11960         (select_source_symtab): Likewise.
11961         (enum print_source_lines_flag): Move definition from symtab.h.
11962         * symtab.h (identify_source_line): Move declaration to source.h.
11963         (print_source_lines): Likewise.
11964         (forget_cached_source_info_for_objfile): Likewise.
11965         (forget_cached_source_info): Likewise.
11966         (select_source_symtab): Likewise.
11967         (enum print_source_lines_flag): Move definition to source.h.
11968         * tui/tui-hooks.c: Add 'source.h' include.
11969
11970 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11971
11972         * source.c (print_source_lines_base): Handle requests to print
11973         reverse line number sequences, and guard against empty lines
11974         string.
11975
11976 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11977
11978         * source.c (print_source_lines_base): Fix skip of '\r' if next
11979         character is '\n'.
11980
11981 2019-01-06  Tom Tromey  <tom@tromey.com>
11982
11983         * c-exp.y (struct c_parse_state) <macro_original_text,
11984         expansion_obstack>: New member.
11985         (macro_original_text, expansion_obstack): Remove globals.
11986         (scan_macro_expansion, scanning_macro_expansion)
11987         (finished_macro_expansion): Update.
11988         (scan_macro_cleanup): Remove.
11989         (yylex, c_parse): Update.
11990
11991 2019-01-06  Tom Tromey  <tom@tromey.com>
11992
11993         * c-exp.y (struct c_parse_state) <strings>: New member.
11994         (operator_stoken): Update.
11995
11996 2019-01-06  Tom Tromey  <tom@tromey.com>
11997
11998         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11999         (union type_stack_elt) <typelist_val>: Now a pointer to
12000         std::vector.
12001         (type_stack_cleanup): Don't declare.
12002         (push_typelist): Update.
12003         * parse.c (pop_typelist): Return a std::vector.
12004         (push_typelist): Take a std::vector.
12005         (follow_types): Update.  Do not free args.
12006         (type_stack_cleanup): Remove.
12007         * c-exp.y (struct c_parse_state): New.
12008         (cpstate): New global.
12009         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12010         (nonempty_typelist): Update.
12011         (func_mod): Create a new vector.
12012         (c_parse): Create a c_parse_state.
12013         (check_parameter_typelist): Do not delete params.
12014         (function_method): Update.  Do not delete type_list.
12015
12016 2019-01-06  Tom Tromey  <tom@tromey.com>
12017
12018         PR gdb/28155:
12019         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12020         check_typedef.
12021         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12022         (print_return_value): Likewise.
12023
12024 2019-01-05  Tom Tromey  <tom@tromey.com>
12025
12026         * contrib/cleanup_check.py: Remove.
12027         * contrib/gcc-with-excheck: Remove.
12028         * contrib/exsummary.py: Remove.
12029         * contrib/excheck.py: Remove.
12030
12031 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12032
12033         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12034         NULL. Initialize tpprev to NULL instead of assigning it
12035         to NULL on the next statement.
12036         * windows-nat.c (windows_delete_thread): Remove check for
12037         main_thread_id before printing thread exit notifications.
12038         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12039         Remove thread ID check against main_thread_id.
12040         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12041         windows_delete_thread.
12042         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12043
12044 2019-01-04  Tom Tromey  <tom@tromey.com>
12045
12046         * compile/compile.c (_initialize_compile): Use upper case for
12047         metasyntactic variables.
12048         * symmisc.c (_initialize_symmisc): Use upper case for
12049         metasyntactic variables.
12050         * psymtab.c (_initialize_psymtab): Use upper case for
12051         metasyntactic variables.
12052         * demangle.c (demangle_command): Use upper case for metasyntactic
12053         variables.
12054         (_initialize_demangler): Likewise.
12055         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12056         variables.
12057
12058 2019-01-03  Tom Tromey  <tom@tromey.com>
12059
12060         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12061
12062 2019-01-03  Tom Tromey  <tom@tromey.com>
12063
12064         * python/py-symtab.c (salpy_str): Update.
12065         (struct salpy_sal_object) <symtab>: Now a PyObject.
12066         (salpy_dealloc): Update.
12067         (del_objfile_sal): Use gdbpy_ref.
12068
12069 2019-01-03  Tom Tromey  <tom@tromey.com>
12070
12071         * python/py-type.c (convert_field): Use new_reference.  Return
12072         gdbpy_ref.
12073         (make_fielditem): Return gdbpy_ref.
12074         (typy_fields): Update.
12075         (typy_getitem): Update.
12076         (field_name): Return gdbpy_ref.  Use new_reference.
12077         (typy_iterator_iternext): Update.
12078
12079 2019-01-03  Tom Tromey  <tom@tromey.com>
12080
12081         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12082
12083 2019-01-03  Tom Tromey  <tom@tromey.com>
12084
12085         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12086         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12087         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12088         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12089         (pspy_set_type_printers): Likewise.
12090         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12091         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12092         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12093         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12094         (objfpy_set_type_printers): Likewise.
12095
12096 2019-01-03  Tom Tromey  <tom@tromey.com>
12097
12098         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12099         (gdbpy_print_stack): Use gdbpy_err_fetch.
12100         * python/python-internal.h (class gdbpy_err_fetch): New class.
12101         (class gdbpy_enter) <m_error_type, m_error_value,
12102         m_error_traceback>: Remove.
12103         <m_error>: New member.
12104         (gdbpy_exception_to_string): Don't declare.
12105         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12106         * python/py-value.c (convert_value_from_python): Use
12107         gdbpy_err_fetch.
12108         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12109         gdbpy_exception_to_string.
12110         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12111         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12112         gdbpy_err_fetch.
12113
12114 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12115
12116         * linux-nat.c (delete_lwp_cleanup): Delete.
12117         (struct lwp_deleter): New struct.
12118         (lwp_info_up): New typedef.
12119         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12120         lwp_info_up.
12121
12122 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12123
12124         * linux-fork.c (class scoped_switch_fork_info): New class.
12125         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12126
12127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12128
12129         * valops.c (find_overload_match): Remove use of null_cleanup, and
12130         calls to do_cleanups.
12131
12132 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12133
12134         * compile/compile-cplus-types.c
12135         (compile_cplus_instance::decl_name): Handle changes to
12136         cp_func_name.
12137         * cp-support.c (cp_func_name): Update header comment, update
12138         return type.
12139         * cp-support.h (cp_func_name): Update return type in declaration.
12140         * valops.c (find_overload_match): Move temp_func local to top
12141         level of function and change its type.  Use temp_func to hold and
12142         delete temporary string obtained from cp_func_name.
12143
12144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12145
12146         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12147         gdb::char_vector, remove cleanup, and update uses of `msg`.
12148
12149 2019-01-03  Jim Wilson  <jimw@sifive.com>
12150
12151         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12152
12153 2019-01-02  Tom Tromey  <tom@tromey.com>
12154
12155         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12156         (tdesc_parse_xml): Remove cleanups.
12157         * target-descriptions.h (make_cleanup_free_target_description):
12158         Don't declare.
12159         (target_desc_deleter): New struct.
12160         (target_desc_up): New typedef.
12161         * target-descriptions.c (target_desc_deleter::operator()): Rename
12162         from free_target_description.
12163         (make_cleanup_free_target_description): Remove.
12164
12165 2019-01-02  Tom Tromey  <tom@tromey.com>
12166
12167         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12168         constructor, destructor.
12169         (linespec_parser): Remove typedef.
12170         (~linespec_parser): Rename from linespec_parser_delete.
12171         (linespec_lex_to_end, linespec_complete_label)
12172         (linespec_complete): Update.
12173         (decode_line_full): Remove cleanups.
12174         (decode_line_1): Update.
12175
12176 2019-01-02  Tom Tromey  <tom@tromey.com>
12177
12178         * python/python-internal.h (inferior_to_inferior_object): Change
12179         return type.
12180         * python/py-exitedevent.c (create_exited_event_object): Update.
12181         * python/py-inferior.c (inferior_to_inferior_object): Return
12182         gdbpy_ref.
12183         (python_new_inferior, python_inferior_deleted)
12184         (thread_to_thread_object, delete_thread_object)
12185         (build_inferior_list, gdbpy_selected_inferior): Update.
12186         * python/py-infthread.c (create_thread_object): Update.  Also fail
12187         if inferior_to_inferior_object fails.
12188
12189 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12190
12191         * inferior.h (class inferior) <displaced_step_state>: New field.
12192         * infrun.h (struct displaced_step_state): Move here from
12193         infrun.c.  Initialize fields, add constructor.
12194         <inf>: Remove field.
12195         <reset>: New method.
12196         * infrun.c (struct displaced_step_inferior_state): Move to
12197         infrun.h.
12198         (displaced_step_inferior_states): Remove.
12199         (get_displaced_stepping_state): Adust.
12200         (displaced_step_in_progress_any_inferior): Adjust.
12201         (displaced_step_in_progress_thread): Adjust.
12202         (displaced_step_in_progress): Adjust.
12203         (add_displaced_stepping_state): Remove.
12204         (get_displaced_step_closure_by_addr): Adjust.
12205         (remove_displaced_stepping_state): Remove.
12206         (infrun_inferior_exit): Call displaced_step_state.reset.
12207         (use_displaced_stepping): Don't check for NULL.
12208         (displaced_step_prepare_throw): Call
12209         get_displaced_stepping_state.
12210         (displaced_step_fixup): Don't check for NULL.
12211         (prepare_for_detach): Don't check for NULL.
12212
12213 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12214
12215         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12216          in case of call that did not complete.
12217
12218 2019-01-02  Andrey Utkin  <autkin@undo.io>
12219
12220         * symfile.c (find_separate_debug_file): Fix search of debug files for
12221         remote debuggee.
12222
12223 2019-01-02  Tom Tromey  <tom@tromey.com>
12224
12225         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12226         indentation.
12227         * python/py-frame.c (frapy_older): Remove cast.
12228         (frapy_newer): Likewise.
12229         * python/py-breakpoint.c (local_setattro): Remove cast.
12230         * python/py-arch.c (archpy_name): Remove local variable.
12231         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12232
12233 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12234
12235         * unittests/basic_string_view/element_access/char/empty.cc:
12236         Fix year range in copyright header.
12237
12238 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12239
12240         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12241         Delete.
12242         <operator==>: Update with for removed field.
12243         <hash>: Likewise.
12244         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12245         <isa_features>: ...this.
12246         <abi_features>: New field.
12247         (riscv_isa_flen): Update comment.
12248         (riscv_abi_xlen): New declaration.
12249         (riscv_abi_flen): New declaration.
12250         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12251         isa_features.
12252         (riscv_abi_xlen): New function.
12253         (riscv_isa_flen): Update to get answer from isa_features.
12254         (riscv_abi_flen): New function.
12255         (riscv_has_fp_abi): Update to get answer from abi_features.
12256         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12257         xlen and flen.
12258         (riscv_call_info) <xlen, flen>: Update comment.
12259         (riscv_call_arg_struct): Remove invalid assertions
12260         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12261         is removed.
12262         (riscv_gdbarch_init): Gather isa features and abi features
12263         separately, ensure both match on the gdbarch when reusing an old
12264         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12265         a target with 64-bit float hardware.
12266
12267 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12268
12269         * source.c (search_command_helper): Stop reverse search
12270         when line 1 has been searched.
12271
12272 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12273
12274         * record-full.c (record_full_base_target::close): Rewrite
12275         record_full_core_buf_list free logic.
12276
12277 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12278
12279         * break-catch-syscall.c (print_one_catch_syscall): xfree
12280         the last text.
12281
12282 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12283
12284         * top.c (print_gdb_version): Update Copyright year in version
12285         message.
12286
12287 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12288
12289         Update copyright year range in all GDB files.
12290
12291 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12292
12293         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12294
12295 For older changes see ChangeLog-2018.
12296 \f
12297 Local Variables:
12298 mode: change-log
12299 left-margin: 8
12300 fill-column: 74
12301 version-control: never
12302 coding: utf-8
12303 End:
12304