gdb/ChangeLog

   1 2019-06-27  Tom Tromey  <tromey@adacore.com>
   2
   3         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
   4         to cp_print_static_field.
   5
   6 2019-06-26  Tom Tromey  <tromey@adacore.com>
   7
   8         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
   9         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  10         declare.
  11
  12 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  13
  14         * features/aarch64-core.c (create_feature_aarch64_core):
  15         Regenerate.
  16         * features/aarch64-core.xml: Add cpsr flags.
  17
  18 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  21         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  22
  23 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  24
  25         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  26         field.
  27         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  28         use.
  29         (arm_record_special_symbol): Don't insert new symbol in sorted
  30         position, push it at the end.
  31
  32 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  33
  34         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  35         (arm_mapping_symbol_s): Remove.
  36         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  37         (arm_mapping_symbol_vec): New typedef.
  38         (struct arm_per_objfile): Add constructor.
  39         <section_maps>: Change type to
  40         std::unique_ptr<arm_mapping_symbol_vec[]>.
  41         (arm_compare_mapping_symbols): Remove.
  42         (arm_find_mapping_symbol): Adjust to section_maps type change.
  43         (arm_objfile_data_free): Call delete on arm_per_objfile.
  44         (arm_record_special_symbol): Adjust to section_maps type change.
  45         Allocate arm_per_objfile with new.
  46
  47 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  48
  49         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  50         with the command prefix.
  51
  52 2019-06-25  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  55         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  56
  57 2019-06-25  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  60         type.
  61         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  62         protected.
  63
  64 2019-06-25  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-winsource.c
  67         (tui_source_window_base::set_is_exec_point_at): Add check against
  68         LOA_ADDRESS.
  69
  70 2019-06-25  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-source.c (tui_set_source_content): Don't check before
  73         xfree.
  74         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  75
  76 2019-06-25  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-winsource.h (tui_update_source_window_as_is)
  79         (tui_alloc_source_buffer, tui_line_is_displayed)
  80         (tui_addr_is_displayed): Change type of win_info.
  81         * tui/tui-winsource.c (tui_update_source_window_as_is)
  82         (tui_clear_source_content, tui_show_source_line)
  83         (tui_show_source_content, tui_source_window_base::refill)
  84         (tui_source_window_base::set_is_exec_point_at)
  85         (tui_source_window_base::set_is_exec_point_at)
  86         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  87         (tui_alloc_source_buffer, tui_line_is_displayed)
  88         (tui_addr_is_displayed): Change type of win_info.  Update.
  89         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  90         (tui_source_window_base::do_make_visible_with_new_height):
  91         Update.
  92         * tui/tui-source.c (tui_set_source_content)
  93         (tui_set_source_content_nil)
  94         (tui_source_window::do_scroll_vertical): Update.
  95         * tui/tui-layout.c (show_layout): Update.
  96         * tui/tui-disasm.c (tui_set_disassem_content)
  97         (tui_disasm_window::do_scroll_vertical): Update.
  98         * tui/tui-data.h (tui_win_content): Remove.
  99         (struct tui_gen_win_info) <content, content_size>: Remove.
 100         (struct tui_source_element): Add initializers and destructor.
 101         (union tui_which_element, struct tui_win_element): Remove.
 102         (struct tui_source_window_base) <content>: New field.
 103         (struct tui_data_window): Remove destructor.
 104         (tui_alloc_content, tui_free_win_content)
 105         (tui_free_all_source_wins_content): Don't declare.
 106         * tui/tui-data.c (tui_initialize_static_data): Update.
 107         (init_content_element, tui_alloc_content): Remove.
 108         (~tui_gen_win_info): Update.
 109         (~tui_data_window, tui_free_all_source_wins_content)
 110         (tui_free_win_content, free_content, free_content_elements):
 111         Remove.
 112
 113 2019-06-25  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.h (tui_clear_source_content)
 116         (tui_erase_source_content, tui_show_source_content): Change type
 117         of win_info.
 118         * tui/tui-winsource.c (tui_clear_source_content)
 119         (tui_erase_source_content, tui_show_source_content): Change type
 120         of win_info.
 121         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 122         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 123         win_info.
 124         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 125         win_info.
 126         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 127
 128 2019-06-25  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.c (tui_clear_source_content)
 131         (tui_source_window_base::set_is_exec_point_at): Update.
 132         * tui/tui-source.c (tui_set_source_content_nil): Update.
 133         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 134         a bool.
 135         * tui/tui-data.c (init_content_element): Update.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 140         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 141         * tui/tui-layout.c (init_and_make_win): Update.
 142         * tui/tui.h (enum tui_win_type): Update.
 143         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 144         tui_win_is_auxillary.
 145         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 146         tui_win_is_auxillary.
 147
 148 2019-06-25  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 151         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 152         (tui_delete_data_content_windows, tui_display_all_data)
 153         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 154         Update.
 155         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 156         * tui/tui-regs.c (tui_last_regs_line_no)
 157         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 158         (tui_show_registers): Update.
 159         (tui_show_register_group): Return void.  Update.
 160         (tui_display_registers_from, tui_display_reg_element_at_line)
 161         (tui_display_registers_from_line, tui_check_register_values):
 162         Update.
 163         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 164         member.
 165         (struct tui_data_window) <regs_content>: Now a std::vector.
 166         <regs_content_count>: Remove.
 167         (tui_add_content_elements, tui_free_data_content): Don't declare.
 168         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 169         (init_content_element): Remove DATA_WIN case.  Add assert.
 170         (tui_add_content_elements): Remove.
 171         (tui_data_window): Update.
 172         (tui_free_data_content): Remove.
 173         (free_content_elements): Remove DATA_WIN case.
 174
 175 2019-06-25  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-data.c (tui_data_item_window): Update.
 178         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 179         * tui/tui-windata.c (tui_display_all_data)
 180         (tui_display_data_from_line): Update.
 181         (tui_check_data_values): Remove.
 182         * tui/tui-regs.c (tui_show_register_group)
 183         (tui_display_reg_element_at_line): Update.
 184         * tui/tui-hooks.c (tui_register_changed)
 185         (tui_refresh_frame_and_register_information): Call
 186         tui_check_register_values.
 187         * tui/tui-data.h (struct tui_data_window) <data_content,
 188         data_content_count, data_type>: Remove.
 189         (enum tui_data_type): Remove.
 190
 191         * tui/tui-data.c (tui_data_window::clear_detail)
 192         (~tui_data_window): Update.
 193
 194 2019-06-25  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 197         declare.
 198         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 199         Rename from tui_first_data_item_displayed.  Update.
 200         (tui_data_window::refresh_all)
 201         (tui_data_window::do_scroll_vertical): Update.
 202         * tui/tui-data.h (struct tui_data_window)
 203         <first_data_item_displayed>: Declare new method.
 204
 205 2019-06-25  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 208         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 209         contents...
 210         (tui_initialize_static_data): ...here.
 211
 212 2019-06-25  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 215         (tui_display_registers_from, tui_check_register_values): Update.
 216         (tui_display_register): Remove win_info parameter; update.
 217         (tui_get_register): Change type of parameters.
 218         * tui/tui-data.h (struct tui_data_element): Remove.
 219         (union tui_which_element) <data>: Remove.
 220         <data_window>: Change type.
 221         (struct tui_data_item_window): New.
 222         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 223         case.  Add assert.
 224         (~tui_data_item_window): New destructor.
 225         (free_content_elements): Remove DATA_ITEM_WIN case.
 226
 227 2019-06-25  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 230         Remove.
 231
 232 2019-06-25  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-data.h (struct tui_command_element): Remove.
 235         (union tui_which_element) <command>: Remove.
 236         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 237         assert.
 238         (free_content_elements): Remove CMD_WIN case.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-layout.c (tui_set_layout): Update.
 243         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 244         * tui/tui-data.c (layout_def): Update.
 245
 246 2019-06-25  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 249         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 250         (tui_source_window_base::set_new_height): Update.
 251         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 252         Update.
 253         (tui_set_locator_fullname, tui_set_locator_info)
 254         (tui_show_frame_info): Update.
 255         * tui/tui-source.c (tui_set_source_content)
 256         (tui_source_is_displayed): Update.
 257         * tui/tui-layout.c (show_source_disasm_command, show_data)
 258         (show_source_or_disasm_and_command): Update.
 259         * tui/tui-disasm.c (tui_set_disassem_content)
 260         (tui_get_begin_asm_address): Update.
 261         * tui/tui-data.h (struct tui_locator_element): Remove.
 262         (union tui_which_element) <locator>: Remove.
 263         (struct tui_locator_window): New.
 264         (tui_locator_win_info_ptr): Change return type.
 265         * tui/tui-data.c (_locator): Change type.
 266         (tui_locator_win_info_ptr): Change return type.
 267         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 268         (tui_alloc_content): Add assert.
 269
 270 2019-06-25  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-winsource.c
 273         (tui_exec_info_window::maybe_allocate_content): New method.
 274         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 275         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 276         (make_source_or_disasm_window): Add cast.
 277         * tui/tui-data.h (union tui_which_element) <simple_string>:
 278         Remove.
 279         (struct tui_source_info): New.
 280         (struct tui_source_window_base) <execution_info>: Change type.
 281         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 282         case, and add assert.
 283         (tui_alloc_content): Add assert.
 284
 285 2019-06-25  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 288         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 289         * tui/tui-data.c (tui_alloc_win_info): Remove.
 290
 291 2019-06-25  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 294         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 295         can_highlight.
 296
 297 2019-06-25  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 300         make_visible_with_new_height method.
 301         (tui_win_info::make_visible_with_new_height): New method.
 302         (tui_source_window_base::do_make_visible_with_new_height)
 303         (tui_data_window::do_make_visible_with_new_height)
 304         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 305         (make_visible_with_new_height): Remove.
 306         (tui_resize_all, tui_adjust_win_heights): Use
 307         make_visible_with_new_height method.
 308         * tui/tui-data.h (struct tui_win_info)
 309         <do_make_visible_with_new_height, make_visible_with_new_height>:
 310         New methods.
 311         (struct tui_source_window_base, struct tui_data_window)
 312         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 313         methods.
 314
 315 2019-06-25  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 318         method.
 319         (update_tab_width): Call update_tab_width method.
 320         * tui/tui-data.h (struct tui_win_info)
 321         (struct tui_source_window_base) <update_tab_width>: New methods.
 322
 323 2019-06-25  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 326         parameter.
 327         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 328         parameter.
 329         (tui_gen_win_info::make_visible): Update.
 330         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 331         parameter.
 332         * tui/tui-data.h (enum tui_box): New enum.
 333         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 338         init_and_make_win for EXEC_INFO_WIN.
 339         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 340         longer inline.
 341         (struct tui_win_info) <~tui_win_info>: Inline.
 342         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 343         Don't declare.
 344         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 345         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 346         Remove.
 347         (tui_initialize_static_data): Update.
 348         (~tui_gen_win_info): Handle more cleanup here.
 349         (~tui_source_window_base): Delete "execution_info".
 350         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 351
 352 2019-06-25  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-layout.c (make_command_window): Don't set
 355         can_highlight.
 356         (show_source_disasm_command): Call the reset method.
 357         (show_data): Don't set can_highlight.  Call the reset method.
 358         (tui_gen_win_info::reset): Rename from init_gen_win_info
 359         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 360         (show_source_or_disasm_and_command): Call the reset method.
 361         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 362         (struct tui_cmd_window): Set can_highlight.
 363
 364 2019-06-25  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 367         from make_visible.
 368         (tui_make_visible, tui_make_invisible): Rewrite.
 369         (tui_win_info::make_visible): Remove.
 370         (tui_source_window_base::make_visible): Update.
 371         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 372         method.  Moved from...
 373         (struct tui_win_info) <make_visible>: ...here.
 374
 375 2019-06-25  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-winsource.c
 378         (tui_source_window_base::do_scroll_horizontal): Remove direction
 379         parameter.
 380         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 381         direction parameter.
 382         * tui/tui-win.c (tui_win_info::forward_scroll)
 383         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 384         (tui_win_info::right_scroll): Update.
 385         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 386         direction parameter.
 387         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 388         direction parameter.
 389         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 390         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 391         Remove direction parameter.
 392         (struct tui_source_window_base, struct tui_source_window)
 393         (struct tui_disasm_window, struct tui_data_window)
 394         (struct tui_cmd_window): Update.
 395
 396 2019-06-25  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.h (tui_set_exec_info_content)
 399         (tui_show_exec_info_content, tui_erase_exec_info_content)
 400         (tui_clear_exec_info_content, tui_update_exec_info): Change
 401         argument to tui_source_window_base.
 402         * tui/tui-winsource.c (tui_set_exec_info_content)
 403         (tui_show_exec_info_content, tui_erase_exec_info_content)
 404         (tui_clear_exec_info_content, tui_update_exec_info): Change
 405         argument to tui_source_window_base.
 406
 407 2019-06-25  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 410         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 411
 412 2019-06-25  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 415         check.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 420         type to void.
 421         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 422         type to void.
 423         * tui/tui-source.c (tui_set_source_content): Update.
 424         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 425
 426 2019-06-25  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-win.c (window_name_completer, tui_set_focus)
 429         (tui_all_windows_info): Use name method.
 430         * tui/tui-data.h (struct tui_gen_win_info)
 431         (struct tui_source_window, struct tui_disasm_window)
 432         (struct tui_data_window, struct tui_cmd_window) <name>: New
 433         method.
 434         (tui_win_name): Don't declare.
 435         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 436         (tui_win_name): Remove.
 437
 438 2019-06-25  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-winsource.h (tui_update_source_window)
 441         (tui_update_source_window_as_is): Change parameter type.
 442         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 443         to be a tui_source_window_base.
 444         (tui_update_source_window_as_is): Likewise.
 445         * tui/tui-win.c (make_visible_with_new_height): Update.
 446
 447 2019-06-25  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.c (tui_erase_source_content)
 450         (tui_show_source_content, tui_show_exec_info_content)
 451         (tui_erase_exec_info_content): Use refresh_window method.
 452         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 453         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 454         from tui_refresh_win.
 455         (tui_data_window::refresh_window): New method.
 456         (tui_win_info::refresh, tui_source_window_base::refresh)
 457         (tui_refresh_all): Use refresh_window method.
 458         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 459         method.
 460         * tui/tui-regs.c (tui_display_register): Call refresh_window
 461         method.
 462         * tui/tui-layout.c (show_source_disasm_command)
 463         (show_source_or_disasm_and_command): Call refresh_window method.
 464         * tui/tui-data.h (struct tui_gen_win_info)
 465         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 466         New method.
 467
 468 2019-06-25  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui.c (tui_rl_other_window, tui_enable)
 471         (tui_is_window_visible, tui_get_command_dimension): Update.
 472         * tui/tui-winsource.c (tui_update_source_window_as_is)
 473         (tui_clear_source_content, tui_erase_source_content)
 474         (tui_show_source_line, tui_source_window_base::refill)
 475         (tui_source_window_base::do_scroll_horizontal)
 476         (tui_source_window_base::set_is_exec_point_at)
 477         (tui_update_breakpoint_info, tui_set_exec_info_content)
 478         (tui_alloc_source_buffer, tui_line_is_displayed)
 479         (tui_addr_is_displayed): Update.
 480         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 481         (tui_check_and_display_highlight_if_needed)
 482         (tui_win_info::make_visible, tui_win_info::refresh)
 483         (tui_refresh_all): Update.
 484         * tui/tui-windata.c (tui_first_data_item_displayed)
 485         (tui_delete_data_content_windows, tui_erase_data_content)
 486         (tui_display_all_data, tui_data_window::refresh_all)
 487         (tui_check_data_values): Update.
 488         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 489         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 490         (tui_win_info::backward_scroll, tui_refresh_all_win)
 491         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 492         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 493         (tui_source_window_base::set_new_height)
 494         (tui_data_window::set_new_height)
 495         (make_invisible_and_set_new_height)
 496         (make_visible_with_new_height, new_height_ok)
 497         (parse_scrolling_args): Update.
 498         * tui/tui-stack.c (tui_show_frame_info): Update.
 499         * tui/tui-source.c (tui_set_source_content)
 500         (tui_set_source_content_nil, tui_source_is_displayed)
 501         (tui_source_window::do_scroll_vertical): Update.
 502         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 503         (tui_display_registers_from, tui_display_reg_element_at_line)
 504         (tui_check_register_values, tui_reg_command): Update.
 505         * tui/tui-layout.c (tui_default_win_height)
 506         (show_source_disasm_command, show_data, init_and_make_win)
 507         (show_source_or_disasm_and_command): Update.
 508         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 509         (tui_redisplay_readline, tui_mld_flush)
 510         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 511         (tui_getc): Update.
 512         * tui/tui-disasm.c (tui_set_disassem_content)
 513         (tui_disasm_window::do_scroll_vertical): Update.
 514         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 515         Now virtual.
 516         (struct tui_win_info): Derive from tui_gen_win_info.
 517         <~tui_win_info>: Mark as override.
 518         <generic>: Remove member.
 519         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 520         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 521         (~tui_data_window, ~tui_win_info)
 522         (tui_free_all_source_wins_content): Update.
 523         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 524
 525 2019-06-25  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-layout.c (init_and_make_win): Use new.
 528         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 529         destructor, initializers.
 530         (tui_alloc_generic_win_info): Don't declare.
 531         * tui/tui-data.c (_locator): Add argument to constructor.
 532         (source_win, disasm_win): New globals.
 533         (exec_info): Remove.
 534         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 535         Update.
 536         (tui_alloc_generic_win_info): Remove.
 537         (init_content_element): Use new.
 538         (tui_win_info::tui_win_info): Update.
 539         (free_content_elements) <case DATA_WIN>: Use delete.
 540
 541 2019-06-25  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 544         * tui/tui-windata.c (tui_first_data_item_displayed)
 545         (tui_delete_data_content_windows): Update.
 546         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 547         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 548         (tui_display_registers_from, tui_check_register_values): Update.
 549         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 550         pointer.
 551         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 552         window.
 553         (tui_free_data_content): Update.
 554         (free_content_elements) <case DATA_WIN>: Free the window.
 555
 556 2019-06-25  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 559         Update.
 560         * tui/tui-layout.c (make_command_window)
 561         (show_source_disasm_command, show_data, init_and_make_win)
 562         (show_source_or_disasm_and_command): Update.
 563         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 564         method.
 565         <can_highight, is_highlighted>: Now bool.
 566         (tui_set_win_highlight): Don't declare.
 567         * tui/tui-data.c (tui_set_win_highlight): Remove.
 568
 569 2019-06-25  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-wingeneral.c (make_visible): Remove check of window
 572         type.
 573
 574 2019-06-25  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-win.c (tui_win_info::max_height)
 577         (tui_cmd_window::max_height): New methods.
 578         (new_height_ok): Call max_height.
 579         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 580         <max_height>: New method.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-win.c (tui_source_window_base::set_new_height)
 585         (tui_data_window::set_new_height): New methods.
 586         (make_invisible_and_set_new_height): Call set_new_height method.
 587         * tui/tui-data.h (struct tui_win_info)
 588         (struct tui_source_window_base, struct tui_data_window)
 589         <set_new_height>: New method.
 590
 591 2019-06-25  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 594         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 595         tui_refresh_data_win.
 596         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 597         method.
 598         (tui_refresh_all_win): Call the refresh_all method.
 599         (tui_set_focus): Likewise.
 600         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 601         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 602         Likewise.
 603
 604 2019-06-25  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-winsource.h (tui_refill_source_window)
 607         (tui_set_is_exec_point_at): Don't declare.
 608         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 609         (tui_source_window_base::refill): Rename from
 610         tui_refill_source_window.
 611         (tui_source_window_base::do_scroll_horizontal): Update.
 612         (tui_source_window_base::set_is_exec_point_at): Rename from
 613         tui_set_is_exec_point_at.
 614         (tui_update_all_breakpoint_info): Update.
 615         * tui/tui-stack.c (tui_show_frame_info): Update.
 616         * tui/tui-layout.c (show_data): Add cast.
 617         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 618         * tui/tui-data.h (struct tui_source_window_base) <refill,
 619         set_is_exec_point_at>: New methods.
 620         (tui_source_windows, tui_add_to_source_windows): Update types.
 621         (tui_add_to_source_windows): Remove redundant declaration.
 622         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 623         (tui_source_windows): Change return type.
 624         (tui_clear_source_windows_detail): Update.
 625         (tui_add_to_source_windows): Change type of parameter.
 626         (tui_free_all_source_wins_content): Update.
 627
 628 2019-06-25  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-wingeneral.c (tui_win_info::refresh)
 631         (tui_source_window_base::refresh): New methods.
 632         (tui_refresh_all): Call the refresh method.
 633         * tui/tui-data.h (struct tui_win_info)
 634         (struct tui_source_window_base) <refresh>: New method.
 635
 636 2019-06-25  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui.h (tui_is_window_visible): Return bool.
 639         * tui/tui.c (tui_is_window_visible): Return bool.
 640         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 641         (tui_make_visible, tui_make_invisible)
 642         (tui_win_info::make_visible)
 643         (tui_source_window_base::make_visible, make_all_visible)
 644         (tui_make_all_visible, tui_make_all_invisible): Update.
 645         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 646         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 647         bool.
 648         (struct tui_win_info, struct tui_source_window_base)
 649         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 650         * tui/tui-data.c (tui_init_generic_part): Update.
 651
 652 2019-06-25  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 655         (tui_source_window_base::make_visible): New methods.
 656         (make_all_visible): Make method call.
 657         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 658         (struct tui_source_window_base, struct tui_cmd_window): Override
 659         make_visible.
 660         (tui_win_is_source_type): Don't declare.
 661         * tui/tui-data.c (tui_win_is_source_type): Remove.
 662
 663 2019-06-25  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 666         NULL check.
 667
 668 2019-06-25  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 671         Inline constructor.  Add initializers for members.
 672         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 673         constructors; now inline in class.
 674
 675 2019-06-25  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-regs.c (tui_show_registers): Update.
 678         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 679         bool.
 680         * tui/tui-data.c (tui_data_window::clear_detail)
 681         (tui_data_window): Update.
 682
 683 2019-06-25  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-windata.c (tui_display_all_data)
 686         (tui_display_data_from_line, tui_display_data_from)
 687         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 688         Update.
 689         * tui/tui-regs.c (tui_last_regs_line_no)
 690         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 691         (tui_show_registers, tui_show_register_group)
 692         (tui_display_registers_from, tui_display_reg_element_at_line)
 693         (tui_display_registers_from_line, tui_check_register_values)
 694         (tui_reg_next, tui_reg_prev): Update.
 695         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 696         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 697         tui_data_window.
 698         (struct tui_win_info) <detail>: Remove.  Add new fields from
 699         tui_data_info.
 700         (TUI_DATA_WIN): Add cast.
 701         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 702         (~tui_data_window): Simplify.
 703
 704 2019-06-25  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-layout.c (show_source_disasm_command)
 707         (show_source_or_disasm_and_command): Update.
 708         * tui/tui-io.c (update_cmdwin_start_line)
 709         (tui_redisplay_readline): Update.
 710         * tui/tui-data.h (struct tui_command_info): Remove.
 711         (struct tui_win_info) <detail>: Remove command_info member.
 712         (struct tui_data_window) <start_line>: New member, from
 713         tui_command_info.
 714         (TUI_CMD_WIN): Add casts.
 715
 716 2019-06-25  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-winsource.c (tui_update_source_window)
 719         (tui_refill_source_window)
 720         (tui_source_window_base::do_scroll_horizontal)
 721         (tui_update_breakpoint_info, tui_set_exec_info_content)
 722         (tui_show_exec_info_content, tui_erase_exec_info_content)
 723         (tui_clear_exec_info_content): Update.
 724         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 725         Update.
 726         * tui/tui-win.c (make_invisible_and_set_new_height)
 727         (make_visible_with_new_height): Update.
 728         * tui/tui-source.c (tui_set_source_content)
 729         (tui_show_symtab_source): Update.
 730         * tui/tui-layout.c (extract_display_start_addr)
 731         (show_source_disasm_command, show_data)
 732         (make_source_or_disasm_window)
 733         (show_source_or_disasm_and_command): Update.
 734         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 735         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 736         "gdbarch".
 737         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 738         to tui_source_window_base.
 739         (struct tui_win_info) <detail>: Remove source_info member.
 740         (struct tui_source_window_base) <has_locator>: Inline.
 741         Move contents from tui_source_info; rename has_locator member to
 742         m_has_locator.
 743         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 744         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 745         header file.
 746         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 747         Simplify.
 748         (tui_free_all_source_wins_content): Cast to
 749         tui_source_window_base.
 750
 751 2019-06-25  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-win.c (make_invisible_and_set_new_height)
 754         (make_visible_with_new_height): Call has_locator method.
 755         * tui/tui-layout.c (show_source_disasm_command, show_data)
 756         (show_source_or_disasm_and_command): Update for bool change.
 757         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 758         (tui_win_info) <has_locator>: New method.
 759         (struct tui_source_window_base) <has_locator>: New method.
 760         (tui_win_has_locator): Don't declare.
 761         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 762         from tui_win_has_locator.
 763         (tui_source_window_base): Use false, not FALSE.
 764
 765 2019-06-25  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 768         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 769         clear_detail method directly.
 770         (tui_clear_win_detail): Remove.
 771
 772 2019-06-25  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 775         "this", not TUI_DISASM_WIN.
 776
 777 2019-06-25  Tom Tromey  <tom@tromey.com>
 778
 779         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 780         declare.
 781         * tui/tui-winsource.c
 782         (tui_source_window_base::do_scroll_horizontal): Rename from
 783         tui_horizontal_source_scroll.
 784         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 785         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 786         from tui_vertical_data_scroll.
 787         * tui/tui-win.h (tui_scroll): Don't declare.
 788         * tui/tui-win.c (tui_win_info::forward_scroll)
 789         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 790         (tui_win_info::right_scroll): Rename and update.
 791         (tui_scroll_forward_command, tui_scroll_backward_command)
 792         (tui_scroll_left_command, tui_scroll_right_command): Update.
 793         (tui_scroll): Remove.
 794         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 795         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 796         from tui_vertical_source_scroll.
 797         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 798         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 799         from tui_vertical_disassem_scroll.
 800         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 801         do_scroll_horizontal>: New methods.
 802         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 803         Likewise.
 804         (struct tui_source_window_base): Add do_scroll_horizontal.
 805         (struct tui_source_window, struct tui_disasm_window): Add
 806         do_scroll_vertical.
 807         (struct tui_data_window, struct tui_cmd_window): Add
 808         do_scroll_horizontal and do_scroll_vertical.
 809         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 810
 811 2019-06-25  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-data.h (struct tui_source_window_base): New struct.
 814         (struct tui_source_window): Derive from tui_source_window_base.
 815         (struct tui_disasm_window): New struct.
 816         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 817         from tui_source_window::clear_detail.
 818         (tui_source_window_base): Rename from tui_source_window.
 819         (~tui_source_window_base): Rename from ~tui_source_window.
 820         (tui_alloc_win_info): Create a tui_disasm_window.
 821
 822 2019-06-25  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-data.h (struct tui_source_window)
 825         (struct tui_data_window): Declare destructors.
 826         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 827         destructors.
 828         (tui_win_info): Simplify.
 829
 830 2019-06-25  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-winsource.c (tui_display_main)
 833         (tui_update_source_windows_with_addr)
 834         (tui_update_all_breakpoint_info): Update.
 835         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 836         (new_height_ok, parse_scrolling_args): Update.
 837         * tui/tui-stack.c (tui_show_frame_info): Update.
 838         * tui/tui-data.h (struct tui_list): Remove.
 839         (tui_source_windows): Return a reference to a std::vector.
 840         * tui/tui-data.c (source_windows): Now a std::vector.
 841         (tui_source_windows): Change return type.
 842         (tui_clear_source_windows): Rewrite.
 843         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 844         (tui_free_all_source_wins_content): Rewrite.
 845
 846 2019-06-25  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 849         (struct tui_data_window, struct tui_cmd_window): Declare
 850         clear_detail method.
 851         * tui/tui-data.c (tui_source_window::clear_detail)
 852         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 853         methods.
 854         (tui_clear_win_detail): Simplify.
 855
 856 2019-06-25  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-layout.c (make_source_window, make_disasm_window)
 859         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 860         Return the new window.
 861         (show_source_disasm_command, show_data)
 862         (show_source_or_disasm_and_command): Update.
 863
 864 2019-06-25  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 867         parameter.  Return the new window.
 868         (show_source_disasm_command): Update and remove NULL check.
 869         (show_source_or_disasm_and_command): Update.
 870
 871 2019-06-25  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 874
 875 2019-06-25  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-data.h (struct tui_win_info): Make constructor
 878         protected.  Make destructor virtual.  Add initializers.
 879         (tui_source_window, tui_data_window, tui_cmd_window): New
 880         classes.
 881         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 882         constructor.  Add "type" parameter.
 883         (tui_source_window, tui_data_window, tui_cmd_window): New
 884         constructors.
 885         (tui_alloc_win_info): Instantiate the appropriate subclass.
 886
 887 2019-06-25  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-win.c (tui_resize_all): Use delete.
 890         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 891         destructor.
 892         (tui_free_window): Don't declare.
 893         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 894         Update.
 895
 896 2019-06-25  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-data.h (struct tui_win_info): Add constructor.
 899         * tui/tui-data.c (tui_alloc_win_info): Use new.
 900         (tui_free_window): Use delete.
 901
 902 2019-06-22  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 905         declare.
 906         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 907
 908 2019-06-22  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 911         declare.
 912         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 913
 914 2019-06-22  Tom de Vries  <tdevries@suse.de>
 915
 916         * dwarf2read.c (create_addrmap_from_aranges)
 917         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 918         instead of '%zu'.
 919
 920 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 921
 922         * dwarf2read.h (dwarf2_section_info_def): Remove.
 923         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 924         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 925         std::vector<dwarf2_section_info>.
 926         (struct dwo_file) <~dwo_file>: Remove.
 927         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 928         types field.
 929         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 930         (dwarf2_read_debug_names): Likewise.
 931         (create_debug_types_hash_table): Change parameter type to
 932         array_view, adjust code accordingly.
 933         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 934         (partial_die_info::fixup): Likewise.
 935         (determine_prefix): Likewise.
 936         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 937
 938 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 939
 940         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 941         gdb_bfd_ref_ptr.
 942         <~dwo_file>: Remove call to gdb_bfd_unref.
 943         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 944         gdb_bfd_ref_ptr::get.
 945
 946 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 947
 948         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 949         type to htab_up.
 950         * dwarf2read.c (struct dwo_file): Initialize fields.
 951         <~dwo_file>: New.
 952         (free_dwo_file): Remove, move content to ~dwo_file.
 953         (struct dwo_file_deleter): Remove.
 954         (dwo_file_up>: Remove custom deleter.
 955         (free_dwo_files): Remove.
 956         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 957         dwo_files.
 958         (process_skeletonless_type_units): Call unique_ptr::get.
 959         (allocate_dwo_file_hash_table): Add deleter to created hash
 960         table.  Change return type to htab_up.
 961         (lookup_dwo_file_slot): Don't memset dwo_file, call
 962         unique_ptr::get.
 963         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 964         (create_dwo_unit_in_dwp_v2): Likewise.
 965         (open_and_init_dwo_file): Likewise.
 966         (free_dwo_file_from_slot): Remove.
 967
 968 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 969
 970         * dwarf2read.h (struct dwarf2_section_info) <readin,
 971         is_virtual>: Change type to bool.
 972         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 973         true instead of 1.
 974
 975 2019-06-19  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-data.h (tui_init_content_element): Don't declare.
 978
 979 2019-06-19  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-data.h (tui_init_win_info): Don't declare.
 982
 983 2019-06-19  Tom de Vries  <tdevries@suse.de>
 984
 985         * dwarf2read.h (abstract_to_concrete): Change type to
 986         std::unordered_map<sect_offset, std::vector<sect_offset>,
 987         gdb::hash_enum<sect_offset>>.
 988
 989 2019-06-19  Tom Tromey  <tromey@adacore.com>
 990
 991         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 992         EVAL_AVOID_SIDE_EFFECTS specially.
 993
 994 2019-06-19  Tom Tromey  <tromey@adacore.com>
 995
 996         * source-cache.c (highlighter): New global.
 997         (source_cache::get_source_lines): Create a highlighter on demand.
 998
 999 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * defs.h (deprecated_interactive_hook): Delete declaration.
1002         * interps.c (clear_interpreter_hooks): Remove use of
1003         deprecated_interactive_hook.
1004         * top.c (deprecated_interactive_hook): Delete definition.
1005         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1006
1007 2019-06-18  Tom de Vries  <tdevries@suse.de>
1008
1009         PR gdb/24515
1010         * dwarf2read.h (abstract_to_concrete): Change type from
1011         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1012         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1013         * dwarf2read.c (read_variable): Update.
1014         (dwarf2_fetch_die_loc_sect_off): Update.
1015
1016 2019-06-17  Tom de Vries  <tdevries@suse.de>
1017
1018         PR gdb/24617
1019         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1020         accessing parent[parent_len - 1].
1021
1022 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1023
1024         PR gdb/24364
1025         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1026         call dtrace_process_dof with NULL dof.
1027
1028 2019-06-16  Tom de Vries  <tdevries@suse.de>
1029
1030         PR gdb/24445
1031         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1032
1033 2019-06-16  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1036         (make_all_visible): Use address of member.
1037
1038 2019-06-16  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1041         (tui_free_window, free_content, free_content_elements): Remove
1042         unnecessary cast.
1043         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1044         cast.
1045         * tui/tui-regs.c (tui_show_register_group)
1046         (tui_display_registers_from, tui_display_reg_element_at_line):
1047         Remove unnecessary cast.
1048
1049 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         * linux-nat.c (normal_mask): Delete.
1052         (_initialize_linux_nat): Don't initialise normal_mask.
1053
1054 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1055
1056         PR gdb/24445
1057         * dwarf-index-write.h (write_psymtabs_to_index): Add
1058         dwz_basename parameter.
1059         * dwarf-index-write.c (write_gdbindex): Move file writing to
1060         write_gdbindex_1.  Change return type void.
1061         (assert_file_size): Move up, remove filename parameter.
1062         (write_gdbindex_1): New function.
1063         (write_debug_names): Change return type to void, call
1064         assert_file_size.
1065         (struct index_wip_file): New struct.
1066         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1067         file logic to index_wip_file.  Write index for dwz file if
1068         needed.
1069         (save_gdb_index_command): Pass basename of dwz file, if present.
1070         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1071         build-id of dwz file, if present.
1072         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1073         (dwarf2_get_dwz_file): Likewise.
1074         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1075         (dwarf2_get_dwz_file): Likewise.
1076
1077 2019-06-16  Tom Tromey  <tom@tromey.com>
1078
1079         * coffread.c (process_coff_symbol): Use xstrdup.
1080         * value.c (create_internalvar): Use xstrdup.
1081
1082 2019-06-16  Tom Tromey  <tom@tromey.com>
1083
1084         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1085         * breakpoint.c (stopin_command, stopat_command)
1086         (until_break_command, decode_location_default): Remove unnecessary
1087         cast.
1088         * utils.c (subset_compare): Remove unnecessary cast.
1089         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1090         cast.
1091         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1092         cast.
1093         * infcmd.c (path_command): Remove unnecessary cast.
1094         * coffread.c (decode_type): Remove unnecessary cast.
1095         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1096         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1097         * tui/tui-stack.c (tui_show_locator_content)
1098         (tui_show_frame_info): Remove unnecessary cast.
1099         * tui/tui-win.c (tui_scroll_forward_command)
1100         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1101         (parse_scrolling_args): Remove unnecessary cast.
1102         * tui/tui-data.c (init_win_info, tui_del_window)
1103         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1104         (free_content_elements): Remove unnecessary cast.
1105         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1106         unnecessary cast.
1107         * tui/tui-source.c (tui_set_source_content)
1108         (tui_vertical_source_scroll): Remove unnecessary cast.
1109         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1110         cast.
1111         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1112         * tui/tui-regs.c (tui_display_registers_from)
1113         (tui_display_register): Remove unnecessary cast.
1114         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1115         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1116         (make_visible): Remove unnecessary cast.
1117         * tui/tui-winsource.c (tui_erase_source_content)
1118         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1119         unnecessary cast.
1120         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1121         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1122         * stabsread.c (read_type, read_array_type, read_range_type):
1123         Remove unnecessary cast.
1124         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1125         (parse_symbol, parse_type, upgrade_type, parse_external)
1126         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1127         unnecessary cast.
1128         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1129
1130 2019-06-16  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-data.c (tui_alloc_generic_win_info)
1133         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1134         checks.
1135
1136 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1137             Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * f-typeprint.c (f_print_type): Don't return early for not
1140         associated or not allocated types.
1141         (f_type_print_varspec_suffix): Add print_rank parameter and print
1142         ranks of array types in case they dangling.
1143         (f_type_print_base): Add print_rank parameter.
1144
1145 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * NEWS: Mention new MI commands.
1148         * break-catch-throw.c (enum exception_event_kind): Move to
1149         breakpoint.h.
1150         (print_mention_exception_catchpoint): Output text as a single
1151         message.
1152         (catch_exception_command_1): Rename to...
1153         (catch_exception_event): ...this, make non-static, update header
1154         command, and change some parameter types.
1155         (catch_catch_command): Update for changes to
1156         catch_exception_command_1.
1157         (catch_throw_command): Likewise.
1158         (catch_rethrow_command): Likewise.
1159         * breakpoint.c (enum exception_event_kind): Delete.
1160         * breakpoint.h (enum exception_event_kind): Moved here from
1161         break-catch-throw.c.
1162         (catch_exception_event): Declare.
1163         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1164         (mi_cmd_catch_throw): New function.
1165         (mi_cmd_catch_rethrow): New function.
1166         (mi_cmd_catch_catch): New function.
1167         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1168         'catch-catch' entries.
1169         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1170         (mi_cmd_catch_rethrow): Declare.
1171         (mi_cmd_catch_catch): Declare.
1172
1173 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * annotate.c (annotate_source_line): Change return type to void,
1176         update implementation to match.
1177         * annotate.h (annotate_source_line): Change return type to void,
1178         update header comment.
1179         * stack.c (print_frame_info): Don't change what frame information
1180         is printed based on whether annotations are on or not.
1181
1182 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1185         (annotate_source): Make static.
1186         (annotate_source_line): Moved from source.c and renamed from
1187         identify_source_line.  Update the return type.
1188         * annotate.h (annotate_source): Delete declaration.
1189         (annotate_source_line): Declaration moved from source.h, and
1190         renamed from identify_source_line.  Return type updated.
1191         * source.c (identify_source_line): Moved to annotate.c and renamed
1192         to annotate_source_line.
1193         (info_line_command): Remove check of annotation_level.
1194         * source.h (identify_source_line): Move declaration to annotate.h
1195         and rename to annotate_source_line.
1196         * stack.c: Add 'annotate.h' include.
1197         (print_frame_info): Remove check of annotation_level before
1198         calling annotate_source_line.
1199
1200 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * source-cache.c (source_cache::get_plain_source_lines): Use
1203         open_source_file_with_line_charpos instead of just
1204         open_source_file, remove call to find_source_lines.
1205         (source_cache::get_source_lines): Likewise.
1206         * source.c (find_source_lines): Make static.
1207         (get_filename_and_charpos): Renamed into...
1208         (open_source_file_with_line_charpos): ..this along with changes to
1209         return a scoped_fd, and some other minor clean ups.
1210         (identify_source_line): Use open_source_file_with_line_charpos.
1211         (search_command_helper): Use open_source_file_with_line_charpos
1212         instead of just open_source_file, remove call to
1213         find_source_lines.
1214         * source.h (open_source_file_with_line_charpos): Declare new
1215         function.
1216         (find_source_lines): Delete declaration.
1217
1218 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * source.c (get_filename_and_charpos): Remove fullname
1221         parameter.
1222         (identify_source_line): Update call to get_filename_and_charpos.
1223
1224 2019-06-14  Tom Tromey  <tromey@adacore.com>
1225
1226         PR gdb/24502:
1227         * ui-style.h (skip_ansi_escape): Update comment.
1228         * ui-file.h (class no_terminal_escape_file): New class.
1229         * ui-file.c (no_terminal_escape_file::write)
1230         (no_terminal_escape_file::puts): New methods.
1231         * cli/cli-logging.c (handle_redirections): Use
1232         no_terminal_escape_file.
1233
1234 2019-06-14  Tom Tromey  <tromey@adacore.com>
1235
1236         * NEWS: Move convenience variable news above Python news.
1237
1238 2019-06-14  Tom Tromey  <tom@tromey.com>
1239
1240         * gnulib: Move directory to top-level.
1241         * configure.ac: Don't configure gnulib.
1242         * configure: Rebuild.
1243         * common/common-defs.h: Use new path to gnulib.
1244         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1245         (GNULIB_H): Remove.
1246         (INCGNU): Look in new gnulib location.
1247         (HFILES_NO_SRCDIR): Remove gnulib files.
1248         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1249         (generated_files): Remove GNULIB_H.
1250         ($(LIBGNU), all-lib): Remove targets.
1251         (distclean): Don't mention GNULIB_BUILDDIR.
1252         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1253
1254 2019-06-14  Tom Tromey  <tromey@adacore.com>
1255
1256         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1257         Warn if symbol file does not provide any symbols.
1258
1259 2019-06-14  Tom Tromey  <tromey@adacore.com>
1260
1261         * source.c (find_and_open_source): Respect basenames_may_differ.
1262
1263 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * annotate.c (annotate_breakpoints_invalid): Make use of
1266         scoped_restore_terminal_state.
1267         (annotate_frames_invalid): Likewise.
1268
1269 2019-06-14  Tom Tromey  <tromey@adacore.com>
1270
1271         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1272         allow assignment to an internalvar.
1273
1274 2019-06-14  Tom Tromey  <tromey@adacore.com>
1275
1276         * ada-lex.l: Allow "_" in attribute names.
1277
1278 2019-06-14  Tom Tromey  <tromey@adacore.com>
1279
1280         PR gdb/24653:
1281         * regcache.c (registers_changed): Don't call alloca.
1282         * top.c (execute_command): Don't call alloca.
1283
1284 2019-06-13  Pedro Alves  <palves@redhat.com>
1285
1286         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1287         'expression'.  When parsing an expression, error out if there's
1288         junk after "unlimited".
1289         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1290         (do_set_command): Adjust calls to is_unlimited_literal.
1291
1292 2019-06-13  Pedro Alves  <palves@redhat.com>
1293
1294         * compile/compile.c (make_compile_options_def_group): Add braces
1295         around array_view initializer.
1296         * thread.c (make_thread_apply_all_options_def_group)
1297         (make_thread_apply_all_options_def_group): Likewise.
1298
1299 2019-06-13  Pedro Alves  <palves@redhat.com>
1300
1301         * NEWS (New commands): Mention "maint test-options
1302         require-delimiter", "maint test-options unknown-is-error", "maint
1303         test-options unknown-is-operand" and "maint show
1304         test-options-completion-result".
1305         (New command options, command completion): New section.
1306         (Completion improvements): New section.
1307         Mention that you can abbreviate "unlimited".
1308
1309 2019-06-13  Pedro Alves  <palves@redhat.com>
1310
1311         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1312         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1313         * unittests/cli-utils-selftests.c (test_parse_flags)
1314         (test_parse_flags_qcs): Delete.
1315         (test_cli_utils): Don't call deleted functions.
1316
1317 2019-06-13  Pedro Alves  <palves@redhat.com>
1318
1319         * thread.c: Include "cli/cli-option.h".
1320         (tp_array_compar_ascending): Global.
1321         (tp_array_compar): Delete function.
1322         (tp_array_compar_ascending, tp_array_compar_descending): New
1323         functions.
1324         (ascending_option_def, qcs_flag_option_def)
1325         (thr_qcs_flags_option_defs)
1326         (make_thread_apply_all_options_def_group)
1327         (make_thread_apply_options_def_group): New.
1328         (thread_apply_all_command): Use gdb::option::process_options.
1329         (thread_apply_command_completer)
1330         (thread_apply_all_command_completer): New.
1331         (thread_apply_command): Use gdb::option::process_options.
1332         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1333         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1334         to generate help text of "thread apply".  Adjust "taas"'s help.
1335         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1336         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1337
1338 2019-06-13  Pedro Alves  <palves@redhat.com>
1339
1340         * thread.c (thread_apply_command): Check for invalid TID with
1341         isdigit instead of !isalpha.
1342
1343 2019-06-13  Pedro Alves  <palves@redhat.com>
1344
1345         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1346         (validate_flags_qcs): New.
1347         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1348         (validate_flags_qcs): Declare.
1349         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1350         (make_frame_apply_options_def_group): New.
1351         (frame_apply_command_count): Process options with
1352         gdb::option::process_options.
1353         (frame_apply_completer): New.
1354         (frame_apply_level_completer, frame_apply_all_completer)
1355         (frame_apply_completer): New.
1356         (_initialize_stack): Update help of "frame apply", "frame apply
1357         level", "frame apply all" and "faas" to mention supported options
1358         and install command completers.
1359         * stack.h (frame_apply_all_completer): Declare.
1360         * thread.c: Include "stack.h".
1361         (tfaas_command): Add "--".
1362         (_initialize_thread): Update help "tfaas" to mention supported
1363         options and install command completer.
1364
1365 2019-06-13  Pedro Alves  <palves@redhat.com>
1366
1367         * completer.c (complete_nested_command_line): New.
1368         (gdb_completion_word_break_characters_throw): Add assertion.
1369         * completer.h (complete_nested_command_line): Declare.
1370
1371 2019-06-13  Pedro Alves  <palves@redhat.com>
1372
1373         * stack.c (parse_backtrace_qualifiers): New.
1374         (backtrace_command): Use it.
1375         (backtrace_command_completer): Complete on qualifiers.
1376
1377 2019-06-13  Pedro Alves  <palves@redhat.com>
1378
1379         * frame.c: Include "cli/cli-option.h.
1380         (user_set_backtrace_options): New.
1381         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1382         Delete.
1383         (get_prev_frame): Adjust.
1384         (boolean_option_def, uinteger_option_def)
1385         (set_backtrace_option_defs): New.
1386         (_initialize_frame): Adjust and use
1387         gdb::option::add_setshow_cmds_for_options to install "set
1388         backtrace past-main" and "set backtrace past-entry".
1389         * frame.h: Include "cli/cli-option.h".
1390         (struct frame_print_options): Forward declare.
1391         (print_frame_arguments_all, print_frame_arguments_scalars)
1392         (print_frame_arguments_none): Declare.
1393         (print_entry_values): Delete declaration.
1394         (struct frame_print_options, user_frame_print_options): New.
1395         (struct set_backtrace_options): New.
1396         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1397         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1398         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1399         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1400         (list_args_or_locals): Add frame_print_options parameter.
1401         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1402         * python/py-framefilter.c (enumerate_args): Pass down
1403         USER_FRAME_PRINT_OPTIONS.
1404         * stack.c: Include "cli/cli-option.h".
1405         (print_frame_arguments_all, print_frame_arguments_scalars)
1406         (print_frame_arguments_none): Declare.
1407         (print_raw_frame_arguments, print_entry_values): Delete.
1408         (user_frame_print_options): New.
1409         (boolean_option_def, enum_option_def, frame_print_option_defs):
1410         New.
1411         (struct backtrace_cmd_options): New.
1412         (bt_flag_option_def): New.
1413         (backtrace_command_option_defs): New.
1414         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1415         (print_frame_arg, read_frame_arg, print_frame_args)
1416         (print_frame_info, print_frame): Add frame_print_options parameter
1417         and use it.
1418         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1419         (backtrace_command_1): Add frame_print_options and
1420         backtrace_cmd_options parameters and use them.
1421         (make_backtrace_options_def_group): New.
1422         (backtrace_command): Process command options with
1423         gdb::option::process_options.
1424         (backtrace_command_completer): New.
1425         (_initialize_stack): Extend "backtrace"'s help to mention
1426         supported options.  Install completer for "backtrace".
1427         Install some settings commands with add_setshow_cmds_for_options.
1428
1429 2019-06-13  Pedro Alves  <palves@redhat.com>
1430
1431         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1432         and that "set/show print raw frame-arguments" are now deprecated.
1433
1434         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1435         command.
1436         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1437         * stack.c (_initialize_stack): Install "set/show print
1438         raw-frame-arguments", and deprecate "set/show print raw
1439         frame-arguments".
1440         * valprint.c (_initialize_valprint): Deprecate "set/show print
1441         raw".
1442
1443 2019-06-13  Pedro Alves  <palves@redhat.com>
1444
1445         * compile/compile.c (struct compile_options): New.
1446         (compile_flag_option_def, compile_command_option_defs)
1447         (make_compile_options_def_group): New.
1448         (compile_file_command): Handle options with
1449         gdb::option::process_options.
1450         (compile_file_command_completer): New function.
1451         (compile_code_command): Handle options with
1452         gdb::option::process_options.
1453         (compile_code_command_completer): New function.
1454         (_initialize_compiler): Install completers for "compile code" and
1455         "compile file".  Mention available options in "compile code" and
1456         "compile code"'s help.
1457         * completer.c (advance_to_completion_word): New, factored out from
1458         ...
1459         (advance_to_expression_complete_word_point): ... this.
1460         (advance_to_filename_complete_word_point): New.
1461         * completer.h (advance_to_filename_complete_word_point): New
1462         declaration.
1463
1464 2019-06-13  Pedro Alves  <palves@redhat.com>
1465
1466         * compile/compile.c: Include "cli/cli-option.h".
1467         (compile_print_value): Scope data pointer is now a
1468         value_print_options pointer; adjust.
1469         (compile_print_command): Process options.  Scope data pointer is
1470         now a value_print_options pointer; adjust.
1471         (_initialize_compile): Update "compile print"'s help to include
1472         supported options.  Install a completer for "compile print".
1473         * cp-valprint.c (show_vtblprint, show_objectprint)
1474         (show_static_field_print): Delete.
1475         (_initialize_cp_valprint): Don't install "set print
1476         static-members", "set print vtbl", "set print object" here.
1477         * printcmd.c: Include "cli/cli-option.h" and
1478         "common/gdb_optional.h".
1479         (print_command_parse_format): Rework to fill in a
1480         value_print_options instead of a format_data.
1481         (print_value): Change parameter type from format_data pointer to
1482         value_print_options reference.  Adjust.
1483         (print_command_1): Process options.  Adjust to pass down a
1484         value_print_options.
1485         (print_command_completer): New.
1486         (_initialize_printcmd): Install print_command_completer as
1487         handle_brkchars completer for the "print" command.  Update
1488         "print"'s help to include supported options.
1489         * valprint.c: Include "cli/cli-option.h".
1490         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1491         here from cp-valprint.c.
1492         (boolean_option_def, uinteger_option_def)
1493         (value_print_option_defs, make_value_print_options_def_group):
1494         New.  Use gdb::option::add_setshow_cmds_for_options to install
1495         "set print elements", "set print null-stop", "set print repeats",
1496         "set print pretty", "set print union", "set print array", "set
1497         print address", "set print symbol", "set print array-indexes".
1498         * valprint.h: Include <string> and "cli/cli-option.h".
1499         (make_value_print_options_def_group): Declare.
1500         (print_value): Change parameter type from format_data pointer to
1501         value_print_options reference.
1502         (print_command_completer): Declare.
1503
1504 2019-06-13  Pedro Alves  <palves@redhat.com>
1505
1506         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1507         (COMMON_SFILES): Add maint-test-settings.c.
1508         * cli/cli-decode.c (boolean_enums): New global, factored out from
1509         ...
1510         (add_setshow_boolean_cmd): ... here.
1511         * cli/cli-decode.h (boolean_enums): Declare.
1512         * cli/cli-option.c: New file.
1513         * cli/cli-option.h: New file.
1514         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1515         factored out from ...
1516         (parse_cli_boolean_value(const char *)): ... this.
1517         (is_unlimited_literal): Change parameter type to pointer to
1518         pointer.  Adjust and advance ARG pointer.
1519         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1520         (parse_cli_var_enum): New, factored out from ...
1521         (do_set_command): ... this.  Adjust.
1522         * cli/cli-setshow.h (parse_cli_boolean_value)
1523         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1524         (parse_cli_var_enum): Declare.
1525         * cli/cli-utils.c: Include "cli/cli-option.h".
1526         (get_ulongest): New.
1527         * cli/cli-utils.h (get_ulongest): Declare.
1528         (check_for_argument): New overloads.
1529         * maint-test-options.c: New file.
1530
1531 2019-06-13  Pedro Alves  <palves@redhat.com>
1532
1533         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1534         parse a range if "-" is at the end of the string.
1535
1536 2019-06-13  Pedro Alves  <palves@redhat.com>
1537
1538         * cli/cli-setshow.c (parse_auto_binary_operation)
1539         (parse_cli_boolean_value): Don't allow "o".
1540
1541 2019-06-13  Pedro Alves  <palves@redhat.com>
1542
1543         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1544         * NEWS: Mention maint test-settings KIND.
1545         * maint-test-settings.c: New file.
1546
1547 2019-06-13  Pedro Alves  <palves@redhat.com>
1548
1549         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1550         completer.
1551         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1552         "set" completers.
1553
1554 2019-06-13  Pedro Alves  <palves@redhat.com>
1555
1556         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1557         after item.
1558
1559 2019-06-13  Pedro Alves  <palves@redhat.com>
1560
1561         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1562
1563 2019-06-13  Pedro Alves <palves@redhat.com>
1564
1565         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1566         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1567         call.
1568         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1569         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1570         calls.
1571         (check_for_argument): Skip spaces after argument.
1572
1573 2019-06-13  Pedro Alves  <palves@redhat.com>
1574
1575         * thread.c (thread_apply_command): Adjust TID parsing.
1576         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1577         detected before end of string.
1578         (tid_is_in_list): Error out if LIST is invalid.
1579
1580 2019-06-13  Pedro Alves  <palves@redhat.com>
1581
1582         * completer.c (complete_line_internal_1): Rewind completion word
1583         point.
1584         (completion_tracker::advance_custom_word_point_by): Change
1585         parameter type to int.
1586         * completer.h (completion_tracker::advance_custom_word_point_by):
1587         Likewise.
1588
1589 2019-06-13  Pedro Alves  <palves@redhat.com>
1590
1591         * completer.c (advance_to_completion_word): Handle delimiters.
1592
1593 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1594
1595         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1596
1597 2019-06-11  Tom Tromey  <tom@tromey.com>
1598
1599         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1600         (xmalloc_failed): Move to alloc.c.
1601         * alloc.c: New file.
1602         * Makefile.in (COMMON_SFILES): Add alloc.c.
1603
1604 2019-06-11  Tom Tromey  <tom@tromey.com>
1605
1606         * nat/linux-waitpid.c: Don't include server.h.
1607         (linux_debug): Remove.
1608         (my_waitpid): Update.
1609
1610 2019-06-11  Tom Tromey  <tromey@adacore.com>
1611
1612         * infcall.c (_initialize_infcall): Remove trailing newline from
1613         help.
1614         * user-regs.c (_initialize_user_regs): Remove trailing newline
1615         from help.
1616         * typeprint.c (_initialize_typeprint): Remove trailing newline
1617         from help.
1618         * reverse.c (_initialize_reverse): Remove trailing newlines from
1619         help.
1620         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1621         from help.
1622         * language.c (add_set_language_command): Remove trailing newline
1623         from help.
1624         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1625         help.
1626         * disasm.c (_initialize_disasm): Remove trailing newline from
1627         help.
1628         * top.c (init_main): Remove trailing newline from help.
1629         * interps.c (_initialize_interpreter): Remove trailing newline
1630         from help.
1631         * btrace.c (_initialize_btrace): Remove trailing newlines from
1632         help.
1633         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1634         from help.
1635         * python/python.c (_initialize_python): Remove trailing newline
1636         from help.
1637         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1638         help.
1639         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1640         from help.  Reformat some text.
1641         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1642         from help.
1643         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1644         newline from help.
1645
1646 2019-06-11  Tom Tromey  <tromey@adacore.com>
1647
1648         * darwin-nat.c (darwin_decode_exception_message)
1649         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1650
1651 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * valops.c (value_slice): Check for not allocated or not
1654         associated values.
1655
1656 2019-06-10  Tom de Vries  <tdevries@suse.de>
1657
1658         PR gdb/24618
1659         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1660         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1661         invalid.
1662
1663 2019-06-10  Tom de Vries  <tdevries@suse.de>
1664
1665         PR gdb/24611
1666         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1667         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1668
1669 2019-06-10  Tom de Vries  <tdevries@suse.de>
1670
1671         PR symtab/24545
1672         * symtab.c (struct demangled_name_entry): Add language field.
1673         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1674         static minimal symbol".  Set and use language field.
1675
1676 2019-06-10  Tom Tromey  <tromey@adacore.com>
1677
1678         * ada-lang.c (_initialize_ada_language): Update help text.
1679
1680 2019-06-10  Tom Tromey  <tromey@adacore.com>
1681
1682         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1683         with a newline.
1684         * guile/guile.c (handle_boot_error): Don't end warning with a
1685         newline.
1686         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1687         warning with a newline.
1688         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1689         newline.
1690         (s12z_frame_cache): Likewise.
1691         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1692         a newline.
1693         * solib-svr4.c (disable_probes_interface): Don't end warning with
1694         a newline.
1695         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1696         newline.
1697         * python/python.c (do_finish_initialization): Don't end warning
1698         with a newline.
1699
1700 2019-06-10  Tom Tromey  <tom@tromey.com>
1701
1702         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1703         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1704         gdbpy_enter.
1705
1706 2019-06-10  Tom Tromey  <tromey@adacore.com>
1707
1708         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1709         data.
1710         (elf_new_init): Don't call stabsread_new_init.
1711         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1712         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1713         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1714
1715 2019-06-10  Tom de Vries  <tdevries@suse.de>
1716
1717         PR symtab/16264
1718         PR symtab/24517
1719         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1720
1721 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1722
1723         * source.c (find_and_open_source): Also rewrite relative file
1724         names.
1725
1726 2019-04-26  Amos Bird  <amosbird@gmail.com>
1727
1728         * annotate.c (annotate_thread_exited): Add "thread-exited"
1729         annotation.
1730
1731 2019-06-06  Tom Tromey  <tromey@adacore.com>
1732
1733         * maint.h (class scoped_command_stats): Use
1734         DISABLE_COPY_AND_ASSIGN.
1735         <print_time>: New method.
1736         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1737         print_time.
1738         (scoped_command_stats::print_time): New method.
1739
1740 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1743         instructions of lengths 6 or 8 bytes.
1744
1745 2019-06-04  Pedro Alves  <palves@redhat.com>
1746
1747         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1748
1749         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1750         * breakpoint.c (condition_completer): Likewise.
1751         * cli/cli-dump.c (scan_expression): Likewise.
1752         * common/filestuff.c (mkdir_recursive): Likewise.
1753         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1754         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1755         (gdb_abspath): Likewise.
1756         * compile/compile-cplus-types.c
1757         (compile_cplus_instance::decl_name): Likewise.
1758         * completer.c (complete_explicit_location):
1759         (signal_completer, reg_or_group_completer_1): Likewise.
1760         * cp-support.c (cp_remove_params_if_any): Likewise.
1761         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1762         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1763         * infcmd.c (strip_bg_char): Likewise.
1764         * linespec.c (copy_token_string): Likewise.
1765         * mi/mi-main.c (output_cores): Likewise.
1766         * psymtab.c (psymtab_search_name):
1767         * symfile.c (test_set_ext_lang_command): Likewise.
1768         * target.c (target_fileio_read_stralloc): Likewise.
1769         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1770         * value.c (complete_internalvar): Likewise.
1771
1772 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1773
1774         Add objfile property to gdb.Type.
1775         * NEWS: Mention Python API addition.
1776         * python/py-type.c (typy_get_objfile): New method.
1777
1778 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1779
1780         * NEWS: Mention the new set|show style [title|highlight].
1781         Mention changes to "show style", "help" and "apropos".
1782
1783 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1784
1785         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1786         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1787         instead of print_help_for_command.
1788         (print_doc_of_command): New function.
1789         (help_list): Add 'apropos -v word' suggestion.
1790         (print_help_for_command): Style the command name using title style.
1791         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1792         (_initialize_cli_cmds): Describe -v in apropos_command help.
1793
1794 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1795
1796         * cli/cli-style.h (cli_style_option): Add name in constructor,
1797         add m_name class member, add constructor with intensity,
1798         add name class function.
1799         (cli_style_option::add_setshow_commands): Remove name argument.
1800         (highlight_style, title_style): New styles.
1801         * cli/cli-style.c (do_show): New function that shows a style
1802         characteristic styling the style name with itself.
1803         (set_style_name): New function.
1804         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1805         Update all callers according to the changes in cli/cli-style.h.
1806         * utils.h (fputs_highlighted): New function.
1807         * utils.c (fputs_highlighted): Likewise.
1808
1809 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1810
1811         * NEWS: Mention new pipe command and new convenience variables.
1812
1813 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1814
1815         * cli/cli-cmds.c (pipe_command): New function.
1816         (_initialize_cli_cmds): Call add_com for pipe_command.
1817         Define | as an alias for pipe.
1818         (exit_status_set_internal_vars): New function.
1819         (shell_escape): Call exit_status_set_internal_vars.
1820         cli/cli-decode.c (find_command_name_length): Recognize | as
1821         a single character command.
1822
1823 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1826         top.c (execute_command_to_ui_file): New function, mostly a copy
1827         of execute_command_to_string.
1828         (execute_command_to_string): Implement by calling
1829         execute_command_to_ui_file.
1830
1831 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1832
1833         * top.h (saved_command_line): Remove declaration.
1834         * top.c (previous_saved_command_line, previous_repeat_arguments):
1835         New variables.
1836         (saved_command_line): Make static, define together with other
1837         'repeat variables'.
1838         (dont_repeat): Clear repeat_arguments.
1839         (repeat_previous, get_saved_command_line, save_command_line):
1840         New functions.
1841         (gdb_init): Initialize saved_command_line
1842         and previous_saved_command_line.
1843         * main.c (captured_main_1): Remove saved_command_line initialization.
1844         * event-top.c (handle_line_of_input): Update to use
1845         the new 'repeat' related functions instead of direct access to
1846         saved_command_line.
1847         * command.h (repeat_previous, get_saved_command_line,
1848         save_command_line): New declarations.
1849         (dont_repeat): Add comment.
1850
1851 2019-05-30  Tom Tromey  <tromey@adacore.com>
1852
1853         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1854         Fix comment.
1855         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1856
1857 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1858
1859         PR cli/24587
1860         * completer.c (complete): Initialize variable word.
1861
1862 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1863
1864         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1865         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1866         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1867         'body' is NULL to the outter 'if', protecting the '!is_define'
1868         situation as well.
1869
1870 2019-05-29  Tom Tromey  <tromey@adacore.com>
1871
1872         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1873         (dwarf_unknown): New function.
1874         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1875         (dwarf_type_encoding_name): Use dwarf_unknown.
1876
1877 2019-05-29  Tom Tromey  <tromey@adacore.com>
1878
1879         PR c++/20020:
1880         * cp-valprint.c (cp_print_value_fields): Call
1881         cp_print_static_field inside "try".
1882
1883 2019-05-29  Tom Tromey  <tromey@adacore.com>
1884
1885         * inflow.c (struct terminal_info): Add default operator=.
1886         * configure: Rebuild.
1887         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1888         -Wdeprecated-copy-dtor, -Wredundant-move.
1889
1890 2019-05-29  Tom Tromey  <tromey@adacore.com>
1891
1892         * NEWS: Add entry.
1893         * infcmd.c (print_return_value_1): Handle finish_print
1894         option.
1895         (show_print_finish): New function.
1896         (_initialize_infcmd): Add "set/show print finish" commands.
1897         * valprint.c (user_print_options): Initialize new member.
1898         * valprint.h (struct value_print_options) <finish_print>: New
1899         member.
1900
1901 2019-05-28  Tom Tromey  <tromey@adacore.com>
1902
1903         * ada-lang.c (ada_remove_Xbn_suffix)
1904         (find_old_style_renaming_symbol)
1905         (parse_old_style_renaming): Remove.
1906         (ada_find_renaming_symbol): Don't call
1907         find_old_style_renaming_symbol.
1908         (ada_is_renaming_symbol): Rename from
1909         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1910         bool.  Now static.
1911         (ada_read_var_value): Update and simplify.
1912         * ada-exp.y (write_var_or_type): Remove old code.
1913
1914 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1915
1916         * event-top.c: Remove include comment.
1917         * inflow.c (class scoped_ignore_sigttou): Move from here...
1918         * inflow.h (class scoped_ignore_sigttou): ...to here.
1919         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1920         * top.c:  Remove include comment.
1921
1922 2019-05-27  Tom Tromey  <tom@tromey.com>
1923
1924         * NEWS: Fix typo.
1925
1926 2019-05-22  Tom Tromey  <tromey@adacore.com>
1927
1928         * target.c (target_follow_exec): Constify parameter.
1929         * target-delegates.c: Rebuild.
1930         * remote.c (remote_target::follow_exec): Constify parameter.
1931         * infrun.c (follow_exec): Constify parameter.
1932         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1933         (target_follow_exec): Likewise.
1934
1935 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1936
1937         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1938         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1939
1940 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1941
1942         * NEWS: Add debugredirect and testsuite sections.
1943
1944 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1945
1946         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1947         target descriptions using exclusively floating point register name
1948         aliases.
1949
1950 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         PR gdb/18644:
1953         * f-lang.c (build_fortran_types): Handle the case where
1954         gdbarch_floatformat_for_type returns a nullptr.
1955
1956 2019-05-21  Tom de Vries  <tdevries@suse.de>
1957
1958         PR cli/24587
1959         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1960
1961 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1962
1963         PR gdb/18644:
1964         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1965         16-byte floats.
1966         * i386-tdep.c (i386_floatformat_for_type): Use
1967         floatformats_ia64_quad for the 16-byte floating point component
1968         within a fortran 32-byte complex number.
1969
1970 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1973         delete default constructor.
1974         (find_partial_die): Update to return const struct.
1975         (partial_die_parent_scope): Move variable declaration into scope
1976         of its use and change its type to auto.
1977         (guess_partial_die_structure_name): Likewise.
1978         (partial_die_info::fixup): Likewise.
1979
1980 2019-05-17  Tom Tromey  <tromey@adacore.com>
1981
1982         * source.c (find_and_open_source): Remove cast.
1983
1984 2019-05-17  Tom Tromey  <tromey@adacore.com>
1985
1986         * annotate.c (annotate_source): Make "filename" const.
1987         * annotate.h (annotate_source): Use const.
1988
1989 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1990
1991         * disasm.c (set_disassembler_options): Send errors to stderr.
1992
1993 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1994
1995         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1996         (cli_interp_base::set_logging): Check debug_redirect.
1997         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1998         * cli/cli-logging.c (debug_redirect): Add static variable.
1999         (pop_output_files): Add default param.
2000         (handle_redirections): Print debug setting.
2001         (show_logging_command): Likewise.
2002         (_initialize_cli_logging): Add debugredirect command.
2003         * interps.c (current_interp_set_logging): Add debug_redirect
2004         parameter.
2005         * interps.h (set_logging): Add debug_redirect parameter.
2006         (current_interp_set_logging): Likewise.
2007         * mi/mi-common.h: Likewise.
2008         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2009
2010 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2011             Tom Tromey  <tromey@adacore.com>
2012
2013         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2014         directly.
2015         * cli/cli-interp.h (make_logging_output): Remove declaration.
2016         * cli/cli-logging.c (make_logging_output): Remove function.
2017         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2018         directly.
2019         * ui-file.c (tee_file::tee_file): Remove bools.
2020         (tee_file::~tee_file): Remove deletes.
2021         * ui-file.h (tee_file): Remove bools.
2022
2023 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2024
2025         * mi/mi-cmds.h (mi_cmd_complete): New function.
2026         * mi/mi-main.c (mi_cmd_complete): Likewise.
2027         * mi/mi-cmds.c: Define new MI command -complete.
2028         * NEWS: Mention new -complete command.
2029
2030 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2031
2032         * completer.h (complete): New function.
2033         * completer.c (complete): Likewise.
2034         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2035         function defined in completer.h.
2036
2037 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2038
2039         * MAINTAINERS (Write After Approval): Add myself.
2040
2041 2019-05-17  Tom de Vries  <tdevries@suse.de>
2042
2043         PR gdb/24094
2044         * dwarf2read.c (struct cu_partial_die_info): New struct.
2045         (find_partial_die): Return cu_partial_die_info.
2046         (partial_die_parent_scope, guess_partial_die_structure_name)
2047         (partial_die_info::fixup): Handle new return type of find_partial_die.
2048
2049 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2050
2051         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2052         "std::string", simplifying the algorithm.
2053
2054 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2055
2056         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2057         (stap_static_probe_ops::get_probes): Likewise.
2058
2059 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2060
2061         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2062         '-')" and "else if".
2063         (stap_parse_single_operand): Join checks for
2064         "gdbarch_stap_parse_special_token_p" and
2065         "gdbarch_stap_parse_special_token" in the same "if" statement.
2066         Invert check when verifying for operation on register
2067         displacement.
2068
2069 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2070
2071         * stap-probe.c (stap_get_opcode): Update comment.
2072         (stap_get_expected_argument_type): Likewise.
2073         (handle_stap_probe): Likewise.
2074
2075 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2076
2077         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2078         return type to 'bool'.  Adjust comment.  Use 'bool' when
2079         appropriate.
2080         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2081         * stap-probe.c (stap_parse_argument_1): Likewise.
2082         (stap_is_operator): Likewise.
2083         (stap_is_generic_prefix): Likewise.
2084         (stap_is_register_prefix): Likewise.
2085         (stap_is_register_indirection_prefix): Likewise.
2086         (stap_is_integer_prefix): Likewise.
2087         (stap_generic_check_suffix): Likewise.
2088         (stap_check_integer_suffix): Likewise.
2089         (stap_check_register_suffix): Likewise.
2090         (stap_check_register_indirection_suffix): Likewise.
2091         (stap_parse_register_operand): Likewise.
2092         (stap_parse_single_operand): Likewise.
2093         (stap_parse_argument_1): Likewise.
2094         (stap_probe::get_argument_count): Likewise.
2095         (stap_is_operator): Likewise.
2096
2097 2019-05-16  Tom Tromey  <tromey@adacore.com>
2098
2099         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2100         keyword to foreach.
2101
2102 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2103
2104         * linux-thread-db.c (try_thread_db_load_1): Change return type
2105         to bool.
2106         (try_thread_db_load): Likewise.
2107         (try_thread_db_load_from_pdir_1): Likewise.
2108         (try_thread_db_load_from_pdir): Likewise.
2109         (try_thread_db_load_from_sdir): Likewise.
2110         (try_thread_db_load_from_dir): Likewise.
2111         (thread_db_load_search): Likewise.
2112         (has_libpthread): Likewise.
2113         (thread_db_load): Likewise.
2114
2115 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2116
2117         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2118         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2119         NULL, and complain/return if that's the case.
2120
2121 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2122
2123         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2124         (advance, posn, abstract_read_memory): New functions.
2125         [struct mem_read_abstraction]: New struct.
2126         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2127
2128 2019-05-14  Tom Tromey  <tromey@adacore.com>
2129
2130         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2131         value is not lval_memory.
2132
2133 2019-05-14  Tom Tromey  <tromey@adacore.com>
2134
2135         * solib.c (info_sharedlibrary_command): Style the file name.
2136
2137 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2138
2139         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2140         (aarch64_vnv_type): Likewise.
2141         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2142         * common/tdesc.c: Likewise.
2143         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2144         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2145         * features/aarch64-fpu.xml: Add ieee half view.
2146         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2147         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2148         * gdbtypes.h (struct builtin_type): Likewise.
2149         (struct objfile_type): Likewise.
2150
2151 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2152
2153         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2154         typo.
2155         * location.h (string_to_event_location): Likewise.
2156
2157 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2158
2159         GDB 8.3 released.
2160
2161 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2162
2163         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2164         New variable declaration.
2165         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2166         New variable.
2167         (print_one_breakpoint): Use ui_out::test_flags and new global
2168         variable to compute use_fixed_output.
2169         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2170         Remove.
2171         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2172         (mi_multi_location_breakpoint_output_fixed): Remove.
2173         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2174         new variable.
2175         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2176         fix_multi_location_breakpoint_output flag if version >= 3.
2177         * ui-out.h (enum ui_out_flag)
2178         <fix_multi_location_breakpoint_output>: New enumerator.
2179
2180 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2181
2182         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2183
2184 2019-05-10  Tom Tromey  <tromey@adacore.com>
2185
2186         * ada-lang.c (catch_ada_completer): New function.
2187         (_initialize_ada_language): Use it.
2188
2189 2019-05-10  Tom Tromey  <tromey@adacore.com>
2190
2191         * thread.c (print_thread_info): Make "requested_threads" const.
2192         * gdbthread.h (print_thread_info): Make "requested_threads"
2193         const.
2194         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2195         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2196
2197 2019-05-08  Tom Tromey  <tom@tromey.com>
2198
2199         * gdbtypes.c (objfile_type_data): Change type.
2200         (objfile_type, _initialize_gdbtypes): Update.
2201
2202 2019-05-08  Tom Tromey  <tom@tromey.com>
2203
2204         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2205         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2206         (_initialize_dwarf2_frame): Update.
2207
2208 2019-05-08  Tom Tromey  <tom@tromey.com>
2209
2210         * objc-lang.c (objc_objfile_data): Change type.
2211         (find_methods): Update.
2212         (_initialize_objc_lang): Remove.
2213
2214 2019-05-08  Tom Tromey  <tom@tromey.com>
2215
2216         * stabsread.c (rs6000_builtin_type_data): Change type.
2217         (rs6000_builtin_type, _initialize_stabsread): Update.
2218
2219 2019-05-08  Tom Tromey  <tom@tromey.com>
2220
2221         * mips-tdep.c (mips_pdr_data): Remove.
2222         (_initialize_mips_tdep): Update.
2223
2224 2019-05-08  Tom Tromey  <tom@tromey.com>
2225
2226         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2227         (hppa_init_objfile_priv_data, read_unwind_info)
2228         (find_unwind_entry, _initialize_hppa_tdep): Update.
2229
2230 2019-05-08  Tom Tromey  <tom@tromey.com>
2231
2232         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2233         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2234         on obstack.
2235         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2236
2237 2019-05-08  Tom Tromey  <tom@tromey.com>
2238
2239         * mdebugread.c (basic_type_data): Change type.
2240         (basic_type, _initialize_mdebugread): Update.
2241
2242 2019-05-08  Tom Tromey  <tom@tromey.com>
2243
2244         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2245
2246 2019-05-08  Tom Tromey  <tom@tromey.com>
2247
2248         * nto-tdep.c (nto_inferior_data_reg): Change type.
2249         (nto_inferior_data): Update.
2250         (nto_inferior_data_cleanup, nto_new_inferior_data)
2251         (_initialize_nto_tdep): Remove.
2252         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2253
2254 2019-05-08  Tom Tromey  <tom@tromey.com>
2255
2256         * ada-lang.c (struct ada_inferior_data): Add initializers.
2257         (ada_inferior_data): Change type.
2258         (ada_inferior_data_cleanup): Remove.
2259         (get_ada_inferior_data, ada_inferior_exit)
2260         (struct ada_pspace_data): Add initializers, destructor.
2261         (ada_pspace_data_handle): Change type.
2262         (get_ada_pspace_data): Update.
2263         (ada_pspace_data_cleanup): Remove.
2264
2265 2019-05-08  Tom Tromey  <tom@tromey.com>
2266
2267         * coffread.c (struct coff_symfile_info): Add initializers.
2268         (coff_objfile_data_key): Move lower.  Change type.
2269         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2270         Update.
2271         (coff_free_info): Remove.
2272
2273 2019-05-08  Tom Tromey  <tom@tromey.com>
2274
2275         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2276         (fbsd_pspace_data_handle): Move lower.  Change type.
2277         (get_fbsd_pspace_data): Update.
2278         (fbsd_pspace_data_cleanup): Remove.
2279         (_initialize_fbsd_tdep): Update.
2280
2281 2019-05-08  Tom Tromey  <tom@tromey.com>
2282
2283         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2284         (get_ada_tasks_pspace_data): Update.
2285         (ada_tasks_pspace_data_cleanup): Remove.
2286         (_initialize_tasks): Update.
2287         (ada_tasks_inferior_data_handle): Change type.
2288         (get_ada_tasks_inferior_data): Update.
2289         (ada_tasks_inferior_data_cleanup): Remove.
2290         (struct ada_tasks_pspace_data): Add initializers.
2291
2292 2019-05-08  Tom Tromey  <tom@tromey.com>
2293
2294         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2295         * symfile-debug.c (debug_sym_get_probes): Change type.
2296         * stap-probe.c (handle_stap_probe):
2297         (stap_static_probe_ops::get_probes): Change type.
2298         * probe.h (class static_probe_ops) <get_probes>: Change type.
2299         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2300         (parse_probes_in_pspace): Update.
2301         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2302         Update.
2303         (any_static_probe_ops::get_probes): Change type.
2304         * elfread.c (elfread_data): New typedef.
2305         (probe_key): Change type.
2306         (elf_get_probes): Likewise.  Update.
2307         (probe_key_free): Remove.
2308         (_initialize_elfread): Update.
2309         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2310         Change type.
2311         (dtrace_process_dof_probe, dtrace_process_dof)
2312         (dtrace_static_probe_ops::get_probe): Change type.
2313
2314 2019-05-08  Tom Tromey  <tom@tromey.com>
2315
2316         * xcoffread.c (struct xcoff_symfile_info): Rename from
2317         coff_symfile_info.  Add initializers.
2318         (xcoff_objfile_data_key): Move lower.  Change type.
2319         (XCOFF_DATA): Rewrite.
2320         (xcoff_free_info): Remove.
2321         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2322         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2323         (xcoff_initial_scan): Update.
2324
2325 2019-05-08  Tom Tromey  <tom@tromey.com>
2326
2327         * solib-svr4.c (struct svr4_info): Add initializers and
2328         destructor.
2329         <probes_table>: Now an htab_up.
2330         (solib_svr4_pspace_data): Change type.
2331         (free_probes_table): Simplify.
2332         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2333         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2334         (probes_table_remove_objfile_probes, register_solib_event_probe)
2335         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2336         (_initialize_svr4_solib): Update.
2337
2338 2019-05-08  Tom Tromey  <tom@tromey.com>
2339
2340         * remote.c (remote_pspace_data): Change type.
2341         (remote_pspace_data_cleanup): Remove.
2342         (get_remote_exec_file, set_pspace_remote_exec_file)
2343         (_initialize_remote): Update.
2344
2345 2019-05-08  Tom Tromey  <tom@tromey.com>
2346
2347         * breakpoint.c (breakpoint_objfile_key): Change type.
2348         (get_breakpoint_objfile_data): Update.
2349         (free_breakpoint_objfile_data): Remove.
2350         (_initialize_breakpoint): Update.
2351
2352 2019-05-08  Tom Tromey  <tom@tromey.com>
2353
2354         * linux-tdep.c (struct linux_info): Add initializers.
2355         (linux_inferior_data): Move.  Change type.
2356         (invalidate_linux_cache_inf): Update.
2357         (linux_inferior_data_cleanup): Remove.
2358         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2359
2360 2019-05-08  Tom Tromey  <tom@tromey.com>
2361
2362         * auxv.c (auxv_inferior_data): Move.  Change type.
2363         (auxv_inferior_data_cleanup): Remove.
2364         (invalidate_auxv_cache_inf): Rewrite.
2365         (get_auxv_inferior_data, _initialize_auxv): Update.
2366
2367 2019-05-08  Tom Tromey  <tom@tromey.com>
2368
2369         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2370         (symfile_debug_objfile_data_key): Change type.
2371         (symfile_debug_installed, debug_qf_has_symbols)
2372         (debug_qf_find_last_source_symtab)
2373         (debug_qf_forget_cached_source_info)
2374         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2375         (debug_qf_print_stats, debug_qf_dump)
2376         (debug_qf_expand_symtabs_for_function)
2377         (debug_qf_expand_all_symtabs)
2378         (debug_qf_expand_symtabs_with_fullname)
2379         (debug_qf_map_matching_symbols)
2380         (debug_qf_expand_symtabs_matching)
2381         (debug_qf_find_pc_sect_compunit_symtab)
2382         (debug_qf_map_symbol_filenames)
2383         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2384         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2385         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2386         (debug_sym_read_linetable, debug_sym_relocate): Update.
2387         (symfile_debug_free_objfile): Remove.
2388         (install_symfile_debug_logging, _initialize_symfile_debug):
2389         Update.
2390
2391 2019-05-08  Tom Tromey  <tom@tromey.com>
2392
2393         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2394         allocate_on_obstack.
2395         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2396         (get_dwarf2_per_objfile): Update.
2397         (set_dwarf2_per_objfile): Remove.
2398         (dwarf2_has_info, dwarf2_get_section_info): Update.
2399         (dwarf2_free_objfile): Remove.
2400         (_initialize_dwarf2_read): Update.
2401
2402 2019-05-08  Tom Tromey  <tom@tromey.com>
2403
2404         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2405         initializers.
2406         <unsupported_script_warning_printed,
2407         script_not_found_warning_printed>: Now bool.
2408         (auto_load_pspace_data): Change type.
2409         (~auto_load_pspace_info): Rename from
2410         auto_load_pspace_data_cleanup.
2411         (get_auto_load_pspace_data, init_loaded_scripts_info)
2412         (clear_section_scripts, maybe_print_unsupported_script_warning)
2413         (maybe_print_script_not_found_warning, _initialize_auto_load):
2414         Update.
2415
2416 2019-05-08  Tom Tromey  <tom@tromey.com>
2417
2418         * objfiles.c (objfile_pspace_info): Add destructor and
2419         initializers.
2420         (objfiles_pspace_data): Change type.
2421         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2422         (get_objfile_pspace_data): Update.
2423         (objfiles_bfd_data): Change type.
2424         (get_objfile_bfd_data): Update.
2425         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2426
2427 2019-05-08  Tom Tromey  <tom@tromey.com>
2428
2429         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2430         Change type.
2431         (get_catch_syscall_inferior_data): Update.
2432         (catch_syscall_inferior_data_cleanup): Remove.
2433         (_initialize_break_catch_syscall): Update.
2434
2435 2019-05-08  Tom Tromey  <tom@tromey.com>
2436
2437         * inflow.c (struct terminal_info): Add destructor and
2438         initializers.
2439         (inflow_inferior_data): Change type.
2440         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2441         (get_inflow_inferior_data, inflow_inferior_exit)
2442         (swap_terminal_info, _initialize_inflow): Update.
2443
2444 2019-05-08  Tom Tromey  <tom@tromey.com>
2445
2446         * target-dcache.c (target_dcache_cleanup): Remove.
2447         (target_dcache_aspace_key): Change type.
2448         (target_dcache_init_p, target_dcache_invalidate)
2449         (target_dcache_get, target_dcache_get_or_init)
2450         (_initialize_target_dcache): Update.
2451         * dcache.h (struct dcache_deleter): New.
2452
2453 2019-05-08  Tom Tromey  <tom@tromey.com>
2454
2455         * symtab.c (struct symbol_cache): Add destructor and
2456         initializers.
2457         (symbol_cache_key): Move.  Change type.
2458         (make_symbol_cache, free_symbol_cache): Remove.
2459         (get_symbol_cache): Update.
2460         (symbol_cache_cleanup): Remove.
2461         (ALL_PSPACES, symbol_cache_flush)
2462         (maintenance_print_symbol_cache)
2463         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2464         Update.
2465
2466 2019-05-08  Tom Tromey  <tom@tromey.com>
2467
2468         * symtab.c (struct main_info): Add destructor and initializers.
2469         (main_progspace_key): Move.  Change type.
2470         (get_main_info): Update.
2471         (main_info_cleanup): Remove.
2472         (_initialize_symtab): Update.
2473
2474 2019-05-08  Tom Tromey  <tom@tromey.com>
2475
2476         * registry.h (DECLARE_REGISTRY): Define the _key class.
2477
2478 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * NEWS: Merge two 'New commands' sections.
2481
2482 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2483
2484         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2485         parameter and use Ada language definition instead.
2486         (ada_val_print_ptr): Remove unused language parameter.
2487         (ada_val_print_num): Remove language parameter and use Ada language
2488         definition instead.
2489         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2490         parameter.
2491         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2492         parameter and use Ada language definition instead.
2493         (ada_val_print_1): Update all ada_val_print_xxx calls.
2494         Remove language parameter.
2495         (ada_val_print): Update ada_val_print_1 call.
2496
2497 2019-05-08  Tom Tromey  <tromey@adacore.com>
2498
2499         * remote.c (remote_hw_watchpoint_limit)
2500         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2501         Now static.
2502
2503 2019-05-08  Tom Tromey  <tromey@adacore.com>
2504
2505         * maint.c (_initialize_maint_cmds): Move initialization code to
2506         remote.c.
2507         (watchdog, show_watchdog): Move to remote.c.
2508         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2509         "watchdog" static.
2510         (_initialize_remote): Move initialization code from maint.c.
2511         * defs.h (watchdog): Don't declare.
2512
2513 2019-05-08  Tom Tromey  <tromey@adacore.com>
2514
2515         * tui/tui-interp.c: Include main.h.
2516         * interps.c: Include main.h.
2517         * main.h (interpreter_p): Declare.
2518         * defs.h (interpreter_p): Don't declare.
2519
2520 2019-05-08  Tom Tromey  <tromey@adacore.com>
2521
2522         * dwarf2loc.c: Include dwarf2read.h.
2523         * defs.h (read_unsigned_leb128): Don't declare.
2524         * dwarf2read.h (read_unsigned_leb128): Declare.
2525
2526 2019-05-08  Tom Tromey  <tromey@adacore.com>
2527
2528         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2529         method.
2530
2531 2019-05-08  Tom Tromey  <tromey@adacore.com>
2532
2533         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2534         when no wrap column is set.
2535
2536 2019-05-08  Tom Tromey  <tromey@adacore.com>
2537
2538         * c-lang.c (c_get_string): Handle non-C-style arrays.
2539
2540 2019-05-08  Tom Tromey  <tromey@adacore.com>
2541
2542         * typeprint.c (print_offset_data::update): Print the bit offset,
2543         not the number of bits remaining.
2544
2545 2019-05-08  Tom Tromey  <tromey@adacore.com>
2546
2547         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2548         padding at end of comment.
2549
2550 2019-05-08  Tom Tromey  <tromey@adacore.com>
2551
2552         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2553         Compare main types.
2554
2555 2019-05-06  Tom Tromey  <tom@tromey.com>
2556
2557         * common/scoped_mmap.c: Include common-defs.h.
2558         * common/scoped_mmap.h: Don't include config.h.
2559
2560 2019-05-04  Tom Tromey  <tom@tromey.com>
2561
2562         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2563         (struct aarch64_call_info): Add initializers.
2564         <si>: Now a std::vector.
2565         (pass_on_stack, aarch64_push_dummy_call): Update.
2566
2567 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2568             Tom Tromey  <tom@tromey.com>
2569
2570         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2571         (ppc_threads): Now a std::vector.  Now static.
2572         (hwdebug_find_thread_points_by_tid)
2573         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2574         Update.
2575
2576 2019-05-04  Tom Tromey  <tom@tromey.com>
2577
2578         * arc-tdep.c (arc_tdesc_init): Return bool.
2579
2580 2019-05-04  Tom Tromey  <tom@tromey.com>
2581
2582         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2583         Use gdb_assert_not_reached.
2584
2585 2019-05-04  Tom Tromey  <tom@tromey.com>
2586
2587         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2588         "false".
2589
2590 2019-05-04  Tom Tromey  <tom@tromey.com>
2591
2592         * arc-tdep.c (arc_tdesc_init): Use bool.
2593
2594 2019-05-04  Tom Tromey  <tom@tromey.com>
2595
2596         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2597
2598 2019-05-04  Tom Tromey  <tom@tromey.com>
2599
2600         * cli/cli-cmds.c (valid_command_p): Return bool.
2601
2602 2019-05-04  Tom Tromey  <tom@tromey.com>
2603
2604         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2605         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2606
2607 2019-05-04  Raul Tambre  <raul@tambre.ee>
2608
2609         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2610         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2611         operator for comparison.
2612
2613 2019-05-04  Tom Tromey  <tom@tromey.com>
2614
2615         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2616         (lookup_partial_symbol, print_partial_symbols)
2617         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2618         (psymbol_compare): Update.
2619         (add_psymbol_to_bcache): Clear the entire psymbol.
2620         (maintenance_check_psymtabs): Update.
2621         * psympriv.h (struct partial_symbol): Don't derive from
2622         general_symbol_info.
2623         <obj_section, unrelocated_address, address,
2624         set_unrelocated_address>: Update.
2625         <ginfo>: New member.
2626         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2627         (debug_names::write_psymbols): Update.
2628
2629 2019-05-04  Tom de Vries  <tdevries@suse.de>
2630
2631         * contrib/cc-with-tweaks.sh: Support -n arg.
2632
2633 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2634
2635         * corelow.c (core_target::detach): Ensure frame cache and
2636         register caches are cleared.
2637         inferior.c (exit_inferior_1): Likewise.
2638
2639 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2640             Tom Tromey  <tom@tromey.com>
2641
2642         * dictionary.c (collate_pending_symbols_by_language): Remove
2643         "struct" from foreach.
2644         * symtab.c (lookup_global_symbol_from_objfile)
2645         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2646         foreach.
2647         * ser-tcp.c (net_open): Remove "struct" from foreach.
2648         * objfiles.c (objfile_relocate, objfile_rebase)
2649         (objfile_has_symbols): Remove "struct" from foreach.
2650         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2651         from foreach.
2652         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2653         foreach.
2654         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2655         "struct" from foreach.
2656         * ada-lang.c (create_excep_cond_exprs)
2657         (ada_exception_catchpoint_cond_string): Remove "struct" from
2658         foreach.
2659
2660 2019-05-03  Tom Tromey  <tromey@adacore.com>
2661
2662         * ada-exp.y (convert_char_literal): Check suffix of each
2663         enumerator.
2664
2665 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2666
2667         PR ada/21406:
2668         * ada-exp.y (yywrap): Don't define.
2669         * ada-lex.l (%option): Add noyywrap
2670         (yywrap): Remove.
2671
2672 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2673
2674         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2675         _WIN32_WINNT to the XP level, unless already defined to a higher
2676         level.
2677
2678         * unittests/parse-connection-spec-selftests.c:
2679         * ser-tcp.c:
2680         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2681         override.
2682
2683         * symfile.c (find_separate_debug_file): Remove colon from the
2684         drive spec of DOS/Windows file names of the target, so that the
2685         file name produced from DEBUGDIR and the target's directory will
2686         be valid on DOS/Windows systems.
2687
2688 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * rust-lang.c (val_print_struct): Handle printing structures
2691         containing strings.
2692
2693 2019-05-02  Tom Tromey  <tromey@adacore.com>
2694
2695         * valarith.c (_initialize_valarith): Remove.
2696
2697 2019-05-01  Tom Tromey  <tromey@adacore.com>
2698
2699         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2700         bitfields.
2701
2702 2019-05-01  Tom Tromey  <tromey@adacore.com>
2703
2704         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2705         for big-endian copies.
2706
2707 2019-04-30  Ali Tamur  <tamur@google.com>
2708         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2709         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2710         (read_3_bytes): New function.
2711
2712 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2713
2714         * windows-nat.c (main_thread_id): Delete.
2715         (handle_output_debug_string): Replace main_thread_id by
2716         current_event.dwThreadId.
2717         (fake_create_process): Likewise.
2718         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2719         Do not set main_thread_id.
2720         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2721         current_event.dwThreadId.
2722         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2723
2724 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2725
2726         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2727         Use current_event.dwThreadId instead of main_thread_id.
2728
2729 2019-04-30  Tom Tromey  <tromey@adacore.com>
2730
2731         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2732         (create_excep_cond_exprs): Iterate over program spaces.
2733         (ada_exception_catchpoint_cond_string): Examine all minimal
2734         symbols for exception types.
2735
2736 2019-04-30  Tom Tromey  <tromey@adacore.com>
2737
2738         PR c++/24470:
2739         * dwarf2read.c (process_structure_scope): Handle case where type
2740         has template parameters but no symbol was created.
2741
2742 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2743             Chris January  <chris.january@arm.com>
2744
2745         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2746         qualifier.
2747         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2748
2749 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * f-typeprint.c (f_print_type): Update rules for printing
2752         whitespace.
2753         (f_type_print_varspec_suffix): Likewise.
2754
2755 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2756             Chris January  <chris.january@arm.com>
2757
2758         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2759         function arguments.
2760
2761 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2762
2763         * f-lang.c (build_fortran_types): Change name of void type to
2764         lower case.
2765         * f-typeprint.c (f_type_print_base): Print the name of the void
2766         type, rather than a fixed string.
2767         * f-valprint.c (f_decorations): Use lower case void string.
2768
2769 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2770             Chris January  <chris.january@arm.com>
2771
2772         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2773         types for Fortran.
2774
2775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2776             Chris January  <chris.january@arm.com>
2777             David Lecomber  <david.lecomber@arm.com>
2778
2779         * f-exp.y (BINOP_INTRINSIC): New token.
2780         (exp): New parser rule handling BINOP_INTRINSIC.
2781         (f77_keywords): Add new builtin procedures.
2782         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2783         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2784         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2785         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2786         (print_unop_subexp_f): New function.
2787         (print_binop_subexp_f): New function.
2788         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2789         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2790         (dump_subexp_body_f): Likewise.
2791         (operator_check_f): Likewise.
2792         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2793         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2794
2795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2796
2797         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2798         UNOP_KIND.
2799         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2800         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2801         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2802         (operator_length_f): New fuction.
2803         (print_subexp_f): New function.
2804         (op_name_f): New function.
2805         (dump_subexp_body_f): New function.
2806         (operator_check_f): New function.
2807         (exp_descriptor_f): Replace standard expression handling functions
2808         with new functions.
2809         * gdb/fortran-operator.def: New file.
2810         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2811         * gdb/std-operator.def: Remove UNOP_KIND.
2812
2813 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * std-operator.def: Remove unbalanced, stray double quote
2816         character.
2817
2818 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2819             Chris January  <chris.january@arm.com>
2820             Daniel Everett  <daniel.everett@arm.com>
2821             Nick Forrington  <nick.forrington@arm.com>
2822             Richard Bunt  <richard.bunt@arm.com>
2823
2824         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2825         of depth when printing anonymous structs or unions.
2826         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2827         Don't print either the top-level value, or the children if the
2828         max-depth is exceeded.
2829         (ppscm_print_children): When printing the key of a map, allow one
2830         extra level of depth.
2831         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2832         print either the top-level value, or the children if the max-depth
2833         is exceeded.
2834         (print_children): When printing the key of a map, allow one extra
2835         level of depth.
2836         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2837         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2838         (user_print_options): Initialise max_depth field.
2839         (val_print_scalar_or_string_type_p): New function.
2840         (val_print): Check to see if the max depth has been reached.
2841         (val_print_check_max_depth): Define new function.
2842         (show_print_max_depth): New function.
2843         (_initialize_valprint): Add 'print max-depth' option.
2844         * valprint.h (struct value_print_options) <max_depth>: New field.
2845         (val_print_check_max_depth): Declare new function.
2846         * NEWS: Document new feature.
2847
2848 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * ada-lang.c (ada_language_defn): Initialise new field.
2851         * c-lang.c (c_is_string_type_p): New function.
2852         (c_language_defn): Initialise new field.
2853         (cplus_language_defn): Initialise new field.
2854         (asm_language_defn): Initialise new field.
2855         (minimal_language_defn): Initialise new field.
2856         * c-lang.h (c_is_string_type_p): Declare new function.
2857         * d-lang.c (d_language_defn): Initialise new field.
2858         * f-lang.c (f_is_string_type_p): New function.
2859         (f_language_defn): Initialise new field.
2860         * go-lang.c (go_is_string_type_p): New function.
2861         (go_language_defn): Initialise new field.
2862         * language.c (default_is_string_type_p): New function.
2863         (unknown_language_defn): Initialise new field.
2864         (auto_language_defn): Initialise new field.
2865         * language.h (struct language_defn) <la_is_string_type_p>: New
2866         member variable.
2867         (default_is_string_type_p): Declare new function.
2868         * m2-lang.c (m2_language_defn): Initialise new field.
2869         * objc-lang.c (objc_language_defn): Initialise new field.
2870         * opencl-lang.c (opencl_language_defn): Initialise new field.
2871         * p-lang.c (pascal_is_string_type_p): New function.
2872         (pascal_language_defn): Initialise new field.
2873         * rust-lang.c (rust_is_string_type_p): New function.
2874         (rust_language_defn): Initialise new field.
2875
2876 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2879         New field.
2880         * ada-lang.c (ada_language_defn): Initialise new field.
2881         * c-lang.c (c_language_defn): Likewise.
2882         (cplus_language_defn): Likewise.
2883         (asm_language_defn): Likewise.
2884         (minimal_language_defn): Likewise.
2885         * d-lang.c (d_language_defn): Likewise.
2886         * f-lang.c (f_language_defn): Likewise.
2887         * go-lang.c (go_language_defn): Likewise.
2888         * language.c (unknown_language_defn): Likewise.
2889         (auto_language_defn): Likewise.
2890         * m2-lang.c (m2_language_defn): Likewise.
2891         * objc-lang.c (objc_language_defn): Likewise.
2892         * opencl-lang.c (opencl_language_defn): Likewise.
2893         * p-lang.c (pascal_language_defn): Likewise.
2894         * rust-lang.c (rust_language_defn): Likewise.
2895
2896 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * ada-lang.c (ada_is_character_type): Change return type to bool.
2899         (ada_is_string_type): Likewise.
2900         * ada-lang.h (ada_is_character_type): Update declaration
2901         (ada_is_string_type): Likewise.
2902
2903 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2904
2905         Support style in 'frame|thread apply'
2906
2907         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2908         * record.c (record_start, record_stop): Update callers of
2909         execute_command_to_string with false.
2910         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2911         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2912         methods.
2913         (class string_file): New constructor with term_out parameter.
2914         Override methods term_out and can_emit_style_escape.  New member
2915         term_out.
2916         (class stdio_file): Override can_emit_style_escape.
2917         (class tee_file): Override term_out and can_emit_style_escape.
2918         * utils.h (can_emit_style_escape): Remove.
2919         * utils.c (can_emit_style_escape): Likewise.
2920         Update all callers of can_emit_style_escape (SOMESTREAM) to
2921         SOMESTREAM->can_emit_style_escape.
2922         * source-cache.c (source_cache::get_source_lines): Likewise.
2923         * stack.c (frame_apply_command_count): Call execute_command_to_string
2924         passing the term_out characteristic of the current gdb_stdout.
2925         * thread.c (thr_try_catch_cmd): Likewise.
2926         * top.c (execute_command_to_string): pass term_out parameter
2927         to construct the string_file for the command output.
2928         * ui-file.c (term_cli_styling): New function (most code moved
2929         from utils.c can_emit_style_escape).
2930         (string_file::string_file, string_file::can_emit_style_escape,
2931         stdio_file::can_emit_style_escape, tee_file::term_out,
2932         tee_file::can_emit_style_escape): New functions.
2933
2934 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2935
2936         * NEWS: Mention the new set|show may-call-functions.
2937         * infcall.c (may_call_functions_p): New variable.
2938         (show_may_call_functions_p): New function.
2939         (call_function_by_hand_dummy): Throws an error if not
2940         may-call-functions.
2941         (_initialize_infcall): Call add_setshow_boolean_cmd for
2942         may-call-functions.
2943
2944 2019-04-25  Keith Seitz  <keiths@redhat.com>
2945
2946         PR c++/24367
2947         * cp-support.c (inspect_type): Don't attempt substitutions
2948         of symbol with the same name.
2949
2950 2019-04-25  Tom Tromey  <tromey@adacore.com>
2951
2952         PR gdb/24475:
2953         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2954         static.
2955
2956 2019-04-25  Tom Tromey  <tromey@adacore.com>
2957
2958         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2959         rvalue reference.
2960         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2961         (gdb_xml_parser::parse): Use std::move.
2962         * python/python-internal.h (gdbpy_convert_exception): Take a const
2963         reference.
2964         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2965         std::move.
2966         * python/py-utils.c (gdbpy_convert_exception): Take a const
2967         reference.
2968         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2969         Use std::move.
2970         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2971         Use std::move.
2972         * mi/mi-main.c (mi_print_exception): Take a const reference.
2973         * main.c (handle_command_errors): Take a const reference.
2974         * linespec.c (parse_linespec): Use std::move.
2975         * infcall.c (run_inferior_call): Use std::move.
2976         (call_function_by_hand_dummy): Use std::move.
2977         * exec.c (try_open_exec_file): Use std::move.
2978         * exceptions.h (exception_print, exception_fprintf)
2979         (exception_print_same): Update.
2980         * exceptions.c (print_exception, exception_print)
2981         (exception_fprintf, exception_print_same): Change parameters to
2982         const reference.
2983         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2984         * common/new-op.c: Use std::move.
2985         * common/common-exceptions.h (struct gdb_exception): Add move
2986         constructor.
2987         (struct gdb_exception_error, struct gdb_exception_quit, struct
2988         gdb_quit_bad_alloc): Change constructor to move constructor.
2989         (throw_exception): Change parameter to rvalue reference.
2990         * common/common-exceptions.c (throw_exception): Take rvalue
2991         reference.
2992         * cli/cli-interp.c (safe_execute_command): Use std::move.
2993         * breakpoint.c (insert_bp_location, location_to_sals): Use
2994         std::move.
2995
2996 2019-04-25  Tom Tromey  <tromey@adacore.com>
2997
2998         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2999         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3000         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3001         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3002         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3003         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3004         guile/scm-value.c: Use unpack.
3005         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3006         gdbscm_gdb_exception.
3007         (gdbscm_throw_gdb_exception): Likewise.
3008         (struct gdbscm_gdb_exception): New.
3009         (unpack): New function.
3010         (gdbscm_wrap): Use unpack.
3011
3012 2019-04-25  Tom Tromey  <tromey@adacore.com>
3013
3014         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3015         (gdb_rl_callback_handler): Use std::move.
3016         * common/common-exceptions.h (struct gdb_exception): Add move
3017         assignment operator.
3018         (throw_exception_sjlj): Change "exception" to const reference.
3019         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3020         (throw_exception_sjlj): Change "exception" to const reference.
3021
3022 2019-04-25  Tom Tromey  <tromey@adacore.com>
3023
3024         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3025         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3026         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3027         Update.
3028         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3029         Update.
3030         * mi/mi-interp.c (mi_interp::exec): Update.
3031         * linespec.c (parse_linespec): Update.
3032         * infcall.c (run_inferior_call): Update.
3033         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3034         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3035         (gdbscm_lookup_global_symbol): Update.
3036         * guile/scm-param.c (gdbscm_parameter_value): Update.
3037         * guile/scm-frame.c (gdbscm_frame_read_register)
3038         (gdbscm_frame_read_var): Update.
3039         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3040         * exec.c (try_open_exec_file): Update.
3041         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3042         (gdb_rl_callback_handler): Update.
3043         * common/common-exceptions.h (exception_none): Don't declare.
3044         * common/common-exceptions.c (exception_none): Don't define.
3045         (struct catcher) <exception>: Update.
3046         * cli/cli-interp.c (safe_execute_command): Update.
3047         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3048
3049 2019-04-25  Ali Tamur  <tamur@google.com>
3050
3051         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3052         (read_attribute_value): Likewise.
3053         (dwarf2_read_addr_index): Update comment.
3054         (read_str_index): Add DW_FORM_strx.
3055         (dwarf2_string_attr): Likewise.
3056         (dwarf2_const_value_attr): Likewise.
3057         (dump_die_shallow): Likewise.
3058         (dwarf2_fetch_constant_bytes): Likewise.
3059         (skip_form_bytes): Likewise.
3060         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3061
3062 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3063
3064         PR corefiles/11608
3065         PR corefiles/18187
3066         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3067         OFFSET.  Verify if current mapping contains an ELF header.
3068         (linux_find_memory_regions_full): Adjust call to
3069         dump_mapping_p.
3070
3071 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3072             Kang Li <kanglictf@gmail.com>
3073
3074         PR gdb/21600
3075
3076         * dwarf2-frame.c (read_initial_length): Be consistent about using
3077         unsigned representation of length.
3078         (decode_frame_entry_1): Likewise.  Check for wraparound of
3079         end pointer as well as buffer overflow.
3080
3081 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3082
3083         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3084         "vq".
3085
3086 2019-04-24  Tom Tromey  <tromey@adacore.com>
3087
3088         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3089
3090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3091
3092         * s12z-tdep.c (s12z_unwind_pc): Delete.
3093         (s12z_unwind_sp): Delete.
3094         (s12z_gdbarch_init): Don't register deleted functions with
3095         gdbarch.
3096
3097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * rl78-tdep.c (rl78_unwind_sp): Delete.
3100         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3101
3102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3103
3104         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3105         (xstormy16_unwind_pc): Delete.
3106         (xstormy16_dummy_id): Delete.
3107         (xstormy16_gdbarch_init): Don't register deleted functions with
3108         gdbarch.
3109
3110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * vax-tdep.c (vax_unwind_pc): Delete.
3113         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3114
3115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3116
3117         * v850-tdep.c (v850_unwind_sp): Delete.
3118         (v850_unwind_pc): Delete.
3119         (v850_dummy_id): Delete.
3120         (v850_gdbarch_init): Don't register deleted functions with
3121         gdbarch.
3122
3123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3126         (tilegx_unwind_pc): Delete.
3127         (tilegx_unwind_dummy_id): Delete.
3128         (tilegx_gdbarch_init): Don't register deleted functions with
3129         gdbarch.
3130
3131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3134         (tic6x_dummy_id): Delete.
3135         (tic6x_gdbarch_init): Don't register deleted functions with
3136         gdbarch.
3137
3138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3139
3140         * sparc-tdep.c (sparc_unwind_pc): Delete.
3141         (sparc32_gdbarch_init): Don't register deleted function with
3142         gdbarch.
3143
3144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3145
3146         * sh-tdep.c (sh_unwind_sp): Delete.
3147         (sh_unwind_pc): Delete.
3148         (sh_dummy_id): Delete.
3149         (sh_gdbarch_init): Don't register deleted functions with
3150         gdbarch.
3151
3152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3153
3154         * score-tdep.c (score_unwind_sp): Delete.
3155         (score_unwind_pc): Delete.
3156         (score_dummy_id): Delete.
3157         (score_gdbarch_init): Don't register deleted functions with
3158         gdbarch.
3159
3160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * rx-tdep.c (rx_unwind_pc): Delete.
3163         (rx_unwind_sp): Delete.
3164         (rx_dummy_id): Delete.
3165         (rx_gdbarch_init): Don't register deleted functions with
3166         gdbarch.  Update comment.
3167
3168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3171         (rs6000_dummy_id): Delete.
3172         (rs6000_gdbarch_init): Don't register deleted functions with
3173         gdbarch.
3174
3175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * or1k-tdep.c (or1k_dummy_id): Delete.
3178         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3179
3180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3181
3182         * nios2-tdep.c (nios2_dummy_id): Delete.
3183         (nios2_unwind_sp): Delete.
3184         (nios2_gdbarch_init): Don't register deleted functions with
3185         gdbarch.
3186
3187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3188
3189         * nds32-tdep.c (nds32_dummy_id): Delete.
3190         (nds32_unwind_pc): Delete.
3191         (nds32_unwind_sp): Delete.
3192         (nds32_gdbarch_init): Don't register deleted functions with
3193         gdbarch.
3194
3195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3196
3197         * msp430-tdep.c (msp430_unwind_pc): Delete.
3198         (msp430_unwind_sp): Delete.
3199         (msp430_dummy_id): Delete.
3200         (msp430_gdbarch_init): Don't register deleted functions with
3201         gdbarch.
3202
3203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * moxie-tdep.c (moxie_unwind_sp): Delete.
3206         (moxie_unwind_pc): Delete.
3207         (moxie_dummy_id): Delete.
3208         (moxie_gdbarch_init): Don't register deleted functions with
3209         gdbarch.
3210
3211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3214         (mn10300_unwind_pc): Delete.
3215         (mn10300_unwind_sp): Delete.
3216         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3217         mn10300_unwind_sp.
3218         (mn10300_frame_unwind_init): Don't register deleted functions with
3219         gdbarch.
3220
3221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3222
3223         * mep-tdep.c (mep_unwind_pc): Delete.
3224         (mep_unwind_sp): Delete.
3225         (mep_dummy_id): Delete.
3226         (mep_gdbarch_init): Don't register deleted functions with
3227         gdbarch.
3228
3229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3230
3231         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3232         (m68hc11_unwind_sp): Delete.
3233         (m68hc11_gdbarch_init): Don't register deleted functions with
3234         gdbarch.
3235
3236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3237
3238         * m32r-tdep.c (m32r_unwind_sp): Delete.
3239         (m32r_unwind_pc): Delete.
3240         (m32r_dummy_id): Delete.
3241         (m32r_gdbarch_init): Don't register deleted functions with
3242         gdbarch.
3243
3244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3245
3246         * m32c-tdep.c (m32c_unwind_pc): Delete.
3247         (m32c_unwind_sp): Delete.
3248         (m32c_dummy_id): Delete.
3249         (m32c_gdbarch_init): Don't register deleted functions with
3250         gdbarch.
3251
3252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3255         (lm32_unwind_pc): Delete.
3256         (lm32_dummy_id): Delete.
3257         (lm32_gdbarch_init): Don't register deleted functions with
3258         gdbarch.
3259
3260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3261
3262         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3263         (iq2000_unwind_pc): Delete.
3264         (iq2000_dummy_id): Delete.
3265         (iq2000_gdbarch_init): Don't register deleted functions with
3266         gdbarch.
3267
3268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * nds32-tdep.c (nds32_type_align): Delete.
3271         (nds32_push_dummy_call): Use type_align instead.
3272
3273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * arm-tdep.c (arm_type_align): Only handle vector override case.
3276         (arm_push_dummy_call): Use type_align.
3277         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3278
3279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3282         case.
3283         (pass_on_stack): Use type_align.
3284         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3285         function.
3286
3287 2019-04-23  Tom Tromey  <tromey@adacore.com>
3288
3289         * dwarf2read.c (line_header::file_name_at): Remove unused
3290         overload.
3291
3292 2019-04-23  Tom de Vries  <tdevries@suse.de>
3293
3294         PR gdb/24438
3295         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3296         invocation.
3297
3298
3299 2019-03-27  Ali Tamur  <tamur@google.com>
3300
3301         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3302         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3303         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3304         (dwarf_expr_context::get_addr_index): Likewise
3305         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3306         (symbol_needs_eval_context::get_addr_index): Likewise
3307         (disassemble_dwarf_expression): Add DW_OP_addrx
3308         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3309         (read_cutu_die_from_dwo): Update comment
3310         (skip_one_die): Add DW_FORM_addrx
3311         (read_attribute_value): Likewise
3312         (var_decode_location): Add DW_OP_addrx
3313         (dwarf2_const_value_attr): Add DW_FORM_addrx
3314         (dump_die_shallow): Likewise
3315         (dwarf2_fetch_constant_bytes): Likewise
3316         (decode_locdesc): Add DW_OP_addrx
3317         (skip_form_bytes): Add DW_FORM_addrx
3318
3319 2019-04-22  Ali Tamur  <tamur@google.com>
3320
3321         * MAINTAINERS (Write After Approval): Add self.
3322
3323 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3324
3325         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3326         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3327         (open_symbol_file_object): Likewise.
3328         (svr4_default_sos): Add info parameter.
3329         (svr4_read_so_list): Likewise.
3330         (svr4_current_sos_direct): Adjust functions calls to pass down
3331         info.
3332         (svr4_current_sos_1): Add info parameter.
3333         (svr4_current_sos): Call get_svr4_info, pass info down to
3334         svr4_current_sos_1.
3335         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3336         get_svr4_info.
3337         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3338         get_svr4_info.
3339         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3340         to get_svr4_info.
3341         (probes_table_remove_objfile_probes): Likewise.
3342         (register_solib_event_probe): Add info parameter.
3343         (solist_update_incremental): Pass info parameter down to
3344         svr4_read_so_list.
3345         (disable_probes_interface): Add info parameter.
3346         (svr4_handle_solib_event): Pass current_program_space to
3347         get_svr4_info.  Adjust disable_probes_interface cleanup.
3348         (svr4_create_probe_breakpoints): Add info parameter, pass it
3349         down to register_solib_event_probe.
3350         (svr4_create_solib_event_breakpoints): Add info parameter,
3351         pass it down to svr4_create_probe_breakpoints.
3352         (enable_break): Pass info down to
3353         svr4_create_solib_event_breakpoints.
3354         (svr4_solib_create_inferior_hook): Pass current_program_space to
3355         get_svr4_info.
3356         (svr4_clear_solib): Likewise.
3357
3358 2019-04-22  Pedro Alves  <palves@redhat.com>
3359
3360         * solib-svr4.c (svr4_free_objfile_observer): New.
3361         (probe_and_action::objfile): New field.
3362         (probes_table_htab_remove_objfile_probes)
3363         (probes_table_remove_objfile_probes): New functions.
3364         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3365         in the new probe_and_action.  Don't store the probe in 'lookup'.
3366         (svr4_create_probe_breakpoints): Pass objfile to
3367         register_solib_event_probe.
3368         (_initialize_svr4_solib): Register a free_objfile observer.
3369
3370 2019-04-19  Tom Tromey  <tom@tromey.com>
3371
3372         * common/queue.h: Remove.
3373
3374 2019-04-19  Tom Tromey  <tom@tromey.com>
3375
3376         * event-loop.c: Don't include "common/queue.h".
3377
3378 2019-04-19  Tom Tromey  <tom@tromey.com>
3379
3380         * remote.c (remote_target): Use delete.
3381         * remote-notif.h: Include <list>, not "common/queue.h".
3382         (notif_client_p): Remove typedef.
3383         (remote_notif_state): Add constructor, destructor, initializer.
3384         <notif_queue>: Now a std::list.
3385         (remote_notif_state_xfree): Don't declare.
3386         * remote-notif.c (remote_notif_process, handle_notification)
3387         (remote_notif_state_allocate): Update.
3388         (~remote_notif_state): Rename from remote_notif_state_xfree.
3389
3390 2019-04-19  Tom Tromey  <tom@tromey.com>
3391
3392         * symfile.c (reread_symbols): Update.
3393         * objfiles.c (objfile_register_static_link)
3394         (objfile_lookup_static_link): Update
3395         (~objfile) Don't delete static_links.
3396         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3397
3398 2019-04-19  Tom Tromey  <tom@tromey.com>
3399
3400         * type-stack.h (struct type_stack) <insert>: Constify string.
3401         * type-stack.c (type_stack::insert): Constify string.
3402         * gdbtypes.h (lookup_template_type): Update.
3403         (address_space_name_to_int): Update.
3404         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3405         const.
3406         (lookup_template_type): Make name const.
3407         * c-exp.y: Update rules.
3408         (lex_one_token, classify_name, classify_inner_name)
3409         (c_print_token): Update.
3410         * p-exp.y: Update rules.
3411         (yylex): Update.
3412         * f-exp.y: Update rules.
3413         (yylex): Update.
3414         * d-exp.y: Update rules.
3415         (lex_one_token, classify_name, classify_inner_name): Update.
3416         * parse.c (write_dollar_variable, copy_name): Return std::string.
3417         * parser-defs.h (copy_name): Change return type.
3418         * m2-exp.y: Update rules.
3419         (yylex): Update.
3420         * go-exp.y (lex_one_token): Update.
3421         Update rules.
3422         (classify_unsafe_function, classify_packaged_name)
3423         (classify_name, yylex): Update.
3424
3425 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3426
3427         * configure.ac: add --enable-source-highlight switch.
3428         * configure: Regenerate.
3429         * top.c (print_gdb_version): plumb --enable-source-highlight
3430         status to "show configuration".
3431
3432 2019-04-19  Tom Tromey  <tromey@adacore.com>
3433
3434         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3435         Check ADA_TYPE_P.
3436         (empty_record, ada_template_to_fixed_record_type_1)
3437         (template_to_static_fixed_type)
3438         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3439         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3440         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3441         macros.
3442
3443 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3444
3445         PR symtab/24423:
3446         * source.c (print_source_lines_base): Advance "iter" when a
3447         control character is seen.
3448
3449 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3450
3451         * inferior.h (struct infcall_suspend_state_deleter):
3452         Catch exception in destructor to avoid crash.
3453
3454 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3455
3456         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3457         close to the add_com "shell".
3458
3459 2019-04-18  Tom Tromey  <tromey@adacore.com>
3460
3461         * process-stratum-target.h (class process_stratum_target)
3462         <stratum>: Add "final".
3463
3464 2019-04-17  Tom Tromey  <tromey@adacore.com>
3465
3466         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3467         against nullptr before use.
3468
3469 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3470
3471         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3472
3473 2019-04-17  Jim Wilson  <jimw@sifive.com>
3474             Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3477         code read might fail, assume 4-byte breakpoint in that case.
3478
3479 2019-04-15  Leszek Swirski  <leszeks@google.com>
3480
3481         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3482         rather than a hand-rolled POD check when checking for forced MEMORY
3483         classification.
3484
3485 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3486
3487         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3488         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3489         function.
3490         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3491         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3492         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3493         declaration.
3494
3495 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3496
3497         * aarch64-linux-nat.c
3498         (aarch64_linux_nat_target::thread_architecture): Add override.
3499         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3500         each VQ.
3501
3502 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3503
3504         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3505
3506 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3507
3508         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3509         target types of size 96-bits, add some additional comments, and
3510         check that the builtin type we found was the correct size.
3511
3512 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3513
3514         * utils.c (prompt_for_continue): Don't restore the styling at the
3515         end, as applied_style has the wrong value.  This fixes styling in
3516         long lists of file names that are interrupted by the "Continue?"
3517         prompt.
3518
3519 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3522         * c-lang.c (c_language_defn): Likewise.
3523         (cplus_language_defn): Likewise.
3524         (asm_language_defn): Likewise.
3525         (minimal_language_defn): Likewise.
3526         * d-lang.c (d_language_defn): Likewise.
3527         * f-lang.c (f_language_defn): Likewise.
3528         * go-lang.c (go_language_defn): Likewise.
3529         * language.c (unknown_language_defn): Likewise.
3530         (auto_language_defn): Likewise.
3531         * language.h (struct language_defn): Remove la_magic field.
3532         (LANG_MAGIC): Delete.
3533         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3534         * objc-lang.c (objc_language_defn): Likewise.
3535         * opencl-lang.c (opencl_language_defn): Likewise.
3536         * p-lang.c (pascal_language_defn): Likewise.
3537         * rust-lang.c (rust_language_defn): Likewise.
3538
3539 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3540
3541         * riscv-tdep.c (riscv_type_align): New function.
3542         (riscv_type_alignment): Delete.
3543         (riscv_arg_location): Use 'type_align'.
3544         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3545
3546 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * gdbtypes.c (type_align): A struct with no non-static fields also
3549         has alignment of 1.
3550
3551 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3554         component to 0.
3555         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3556         member.
3557         (riscv_struct_info::analyse): New implementation using new
3558         analyse_inner member function.
3559         (riscv_struct_info::field_offset): New member function.
3560         (riscv_struct_info::m_offsets): New member variable.
3561         (riscv_struct_info::analyse_inner): New private member function,
3562         takes the old implementation of riscv_struct_info::analyse but
3563         extended to track field offsets.
3564         (riscv_call_arg_struct): Update the struct folding special cases
3565         to handle cases where empty C++ structs, which are non-zero
3566         length, are found.
3567         (riscv_arg_location): Initialise the length of each location, a
3568         non-zero length now indicates the location is in use.
3569         (riscv_push_dummy_call): Allow for the first location having a
3570         non-zero offset when setting up arguments.
3571         (riscv_return_value): Likewise, but for return values.
3572
3573 2019-04-11  Tom Tromey  <tromey@adacore.com>
3574
3575         * utils.c (internal_vproblem): Make "msg" const.
3576
3577 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3578
3579         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3580         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3581         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3582         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3583
3584 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3585
3586         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3587         function.
3588         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3589         of amd64_collect_native_gregset.
3590         (amd64_linux_nat_target::store_registers): Likewise.
3591
3592 2019-04-10  Tom Tromey  <tom@tromey.com>
3593
3594         * symtab.c (lookup_global_symbol_from_objfile)
3595         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3596         * objfiles.h (class separate_debug_iterator): New.
3597         (class separate_debug_range): New.
3598         (struct objfile) <separate_debug_objfiles>: New method.
3599         (objfile_separate_debug_iterate): Don't declare.
3600         * objfiles.c (separate_debug_iterator::operator++): Rename from
3601         objfile_separate_debug_iterate.
3602         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3603         iterator.
3604         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3605         iterator.
3606
3607 2019-04-10  Tom Tromey  <tom@tromey.com>
3608
3609         * symfile.c (reread_symbols): Remove old comment.
3610         * objfiles.c (free_all_objfiles): Fix a typo.
3611
3612 2019-04-10  Tom Tromey  <tom@tromey.com>
3613
3614         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3615         * minsyms.c (lookup_minimal_symbol): Use foreach.
3616         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3617         (lookup_minimal_symbol_solib_trampoline): Likewise.
3618         * symfile.c (reread_symbols): Use foreach.
3619
3620 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3621             Tom Tromey  <tromey@adacore.com>
3622
3623         PR rust/24414:
3624         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3625         (rust_lex_int_test): Change "value" to be LONGEST.
3626         (rust_lex_tests): Add test for long integer literal.
3627
3628 2019-04-09  Tom Tromey  <tromey@adacore.com>
3629
3630         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3631         to bool.
3632         (extended_remote_target::attach): Update.
3633         (remote_target::remote_notice_new_inferior): Update.
3634         (remote_target::add_current_inferior_and_thread): Update.
3635         * inferior.c (exit_inferior_1): Use "false".
3636         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3637
3638 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3639
3640         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3641         the "start" command.
3642
3643 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3644
3645         * python/py-inferior.c (infpy_thread_from_thread_handle):
3646         Adjust comments to reflect renaming of thread_from_thread_handle
3647         to thread_from_handle.  Adjust keywords.  Fix type error message.
3648         (inferior_object_methods): Add thread_from_handle.  Retain
3649         thread_from_thread_handle, but mark it as deprecated.
3650
3651 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3652
3653         * gdbthread.h (find_thread_by_handle): Revise declaration.
3654         * thread.c (find_thread_by_handle): Likewise.  Adjust
3655         implementation too.
3656         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3657         support for buffer objects as handles.
3658
3659 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3660
3661         * python/py-infthread.c (thpy_thread_handle): New function.
3662         (thread_object_methods): Register thpy_thread_handle.
3663
3664 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3665
3666         * gdbthread.h (thread_to_thread_handle): Declare.
3667         * thread.c (gdbtypes.h): Include.
3668         (thread_to_thread_handle): New function.
3669
3670         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3671         (target_thread_info_to_thread_handle): Declare.
3672         * target.c (target_thread_info_to_thread_handle): New function.
3673         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3674         * target-delegates.c: Regenerate.
3675
3676         * linux-thread-db.c (class thread_db_target): Add method
3677         thread_info_to_thread_handle.
3678         (thread_db_target::thread_info_to_thread_handle): Define.
3679         * remote.c (class remote_target): Add new method
3680         thread_info_to_thread_handle.
3681         (remote_target::thread_info_to_thread_handle): Define.
3682
3683 2019-04-08  Pedro Alves  <palves@redhat.com>
3684
3685         * common/common-exceptions.c (throw_exception): Don't create
3686         named object to throw; throw directly.
3687         (throw_it): Likewise.  Don't initialize gdb_exception::message
3688         here, with new; pass FMT and AP to the ctor instead.
3689         * common/common-exceptions.h: Include <string>.
3690         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3691         const char *, va_list)): New ctor.  Use std::make_shared.
3692         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3693         errors)): Delete.
3694         (gdb_exception_error::gdb_exception_error(enum errors, const char
3695         *, va_list)): New.
3696         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3697         Add assertion.
3698         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3699         errors)): Delete.
3700         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3701         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3702         Add assertion.
3703
3704 2019-04-08  Tom Tromey  <tom@tromey.com>
3705
3706         * valops.c (value_rtti_indirect_type): Replace throw_exception
3707         with throw.
3708         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3709         with throw.
3710         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3711         throw.
3712         * target.c (target_translate_tls_address): Replace throw_exception
3713         with throw.
3714         * stack.c (frame_apply_command_count): Replace throw_exception
3715         with throw.
3716         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3717         throw.
3718         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3719         with throw.
3720         * rs6000-tdep.c (rs6000_frame_cache)
3721         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3722         * remote.c: Replace throw_exception with throw.
3723         * record-full.c (record_full_message, record_full_wait_1)
3724         (record_full_restore): Replace throw_exception with throw.
3725         * record-btrace.c:
3726         (get_thread_current_frame_id, record_btrace_start_replaying)
3727         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3728         (cmd_record_btrace_start): Replace throw_exception with throw.
3729         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3730         throw.
3731         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3732         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3733         * linespec.c:
3734         (find_linespec_symbols): Replace throw_exception with throw.
3735         * infrun.c (displaced_step_prepare, resume): Replace
3736         throw_exception with throw.
3737         * infcmd.c (post_create_inferior): Replace throw_exception with
3738         throw.
3739         * inf-loop.c (inferior_event_handler): Replace throw_exception
3740         with throw.
3741         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3742         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3743         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3744         (get_prev_frame_always, get_frame_pc_if_available)
3745         (get_frame_address_in_block_if_available, get_frame_language):
3746         Replace throw_exception with throw.
3747         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3748         throw_exception with throw.
3749         * eval.c (fetch_subexp_value, evaluate_var_value)
3750         (evaluate_funcall, evaluate_subexp_standard): Replace
3751         throw_exception with throw.
3752         * dwarf2loc.c (call_site_find_chain)
3753         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3754         Replace throw_exception with throw.
3755         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3756         with throw.
3757         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3758         throw.
3759         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3760         * completer.c (complete_line_internal): Replace throw_exception
3761         with throw.
3762         * compile/compile-object-run.c (compile_object_run): Replace
3763         throw_exception with throw.
3764         * cli/cli-script.c (process_next_line): Replace throw_exception
3765         with throw.
3766         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3767         (btrace_enable, btrace_maint_update_pt_packets): Replace
3768         throw_exception with throw.
3769         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3770         throw_exception with throw.
3771         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3772         throw_exception with throw.
3773         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3774         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3775         * aarch64-tdep.c (aarch64_make_prologue_cache)
3776         (aarch64_make_stub_cache): Replace throw_exception with throw.
3777
3778 2019-04-08  Tom Tromey  <tom@tromey.com>
3779
3780         * common/common-exceptions.c (throw_exception): Rename from
3781         throw_exception_cxx.  Remove old copy.  Make argument const.
3782         (throw_it): Create and throw exception objects directly.
3783         * common/common-exceptions.h (throw_exception): Make argument
3784         const.
3785         (struct gdb_exception_error): Add constructor.
3786         (struct gdb_exception_quit): Add constructor.
3787
3788 2019-04-08  Tom Tromey  <tom@tromey.com>
3789
3790         * common/common-exceptions.h (exception_rethrow): Don't declare.
3791         (TRY_SJLJ): Update comment.
3792         (TRY, CATCH, END_CATCH): Remove.
3793         * common/common-exceptions.c (exception_rethrow): Remove.
3794
3795 2019-04-08  Tom Tromey  <tom@tromey.com>
3796
3797         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3798         Remove.
3799         (gdb_exception_error): Rename from
3800         gdb_exception_RETURN_MASK_ERROR.
3801         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3802         (gdb_quit_bad_alloc): Update.
3803         * aarch64-tdep.c: Update.
3804         * ada-lang.c: Update.
3805         * ada-typeprint.c: Update.
3806         * ada-valprint.c: Update.
3807         * amd64-tdep.c: Update.
3808         * arch-utils.c: Update.
3809         * break-catch-throw.c: Update.
3810         * breakpoint.c: Update.
3811         * btrace.c: Update.
3812         * c-varobj.c: Update.
3813         * cli/cli-cmds.c: Update.
3814         * cli/cli-interp.c: Update.
3815         * cli/cli-script.c: Update.
3816         * common/common-exceptions.c: Update.
3817         * common/new-op.c: Update.
3818         * common/selftest.c: Update.
3819         * compile/compile-c-symbols.c: Update.
3820         * compile/compile-cplus-symbols.c: Update.
3821         * compile/compile-object-load.c: Update.
3822         * compile/compile-object-run.c: Update.
3823         * completer.c: Update.
3824         * corelow.c: Update.
3825         * cp-abi.c: Update.
3826         * cp-support.c: Update.
3827         * cp-valprint.c: Update.
3828         * darwin-nat.c: Update.
3829         * disasm-selftests.c: Update.
3830         * dtrace-probe.c: Update.
3831         * dwarf-index-cache.c: Update.
3832         * dwarf-index-write.c: Update.
3833         * dwarf2-frame-tailcall.c: Update.
3834         * dwarf2-frame.c: Update.
3835         * dwarf2loc.c: Update.
3836         * dwarf2read.c: Update.
3837         * eval.c: Update.
3838         * event-loop.c: Update.
3839         * event-top.c: Update.
3840         * exec.c: Update.
3841         * f-valprint.c: Update.
3842         * fbsd-tdep.c: Update.
3843         * frame-unwind.c: Update.
3844         * frame.c: Update.
3845         * gdbtypes.c: Update.
3846         * gnu-v3-abi.c: Update.
3847         * guile/guile-internal.h: Update.
3848         * guile/scm-block.c: Update.
3849         * guile/scm-breakpoint.c: Update.
3850         * guile/scm-cmd.c: Update.
3851         * guile/scm-disasm.c: Update.
3852         * guile/scm-frame.c: Update.
3853         * guile/scm-lazy-string.c: Update.
3854         * guile/scm-math.c: Update.
3855         * guile/scm-param.c: Update.
3856         * guile/scm-ports.c: Update.
3857         * guile/scm-pretty-print.c: Update.
3858         * guile/scm-symbol.c: Update.
3859         * guile/scm-symtab.c: Update.
3860         * guile/scm-type.c: Update.
3861         * guile/scm-value.c: Update.
3862         * i386-linux-tdep.c: Update.
3863         * i386-tdep.c: Update.
3864         * inf-loop.c: Update.
3865         * infcall.c: Update.
3866         * infcmd.c: Update.
3867         * infrun.c: Update.
3868         * jit.c: Update.
3869         * language.c: Update.
3870         * linespec.c: Update.
3871         * linux-fork.c: Update.
3872         * linux-nat.c: Update.
3873         * linux-tdep.c: Update.
3874         * linux-thread-db.c: Update.
3875         * main.c: Update.
3876         * mi/mi-cmd-break.c: Update.
3877         * mi/mi-cmd-stack.c: Update.
3878         * mi/mi-interp.c: Update.
3879         * mi/mi-main.c: Update.
3880         * objc-lang.c: Update.
3881         * p-valprint.c: Update.
3882         * parse.c: Update.
3883         * ppc-linux-tdep.c: Update.
3884         * printcmd.c: Update.
3885         * python/py-arch.c: Update.
3886         * python/py-breakpoint.c: Update.
3887         * python/py-cmd.c: Update.
3888         * python/py-finishbreakpoint.c: Update.
3889         * python/py-frame.c: Update.
3890         * python/py-framefilter.c: Update.
3891         * python/py-gdb-readline.c: Update.
3892         * python/py-inferior.c: Update.
3893         * python/py-infthread.c: Update.
3894         * python/py-lazy-string.c: Update.
3895         * python/py-linetable.c: Update.
3896         * python/py-objfile.c: Update.
3897         * python/py-param.c: Update.
3898         * python/py-prettyprint.c: Update.
3899         * python/py-progspace.c: Update.
3900         * python/py-record-btrace.c: Update.
3901         * python/py-record.c: Update.
3902         * python/py-symbol.c: Update.
3903         * python/py-type.c: Update.
3904         * python/py-unwind.c: Update.
3905         * python/py-utils.c: Update.
3906         * python/py-value.c: Update.
3907         * python/python.c: Update.
3908         * record-btrace.c: Update.
3909         * record-full.c: Update.
3910         * remote-fileio.c: Update.
3911         * remote.c: Update.
3912         * riscv-tdep.c: Update.
3913         * rs6000-aix-tdep.c: Update.
3914         * rs6000-tdep.c: Update.
3915         * rust-exp.y: Update.
3916         * rust-lang.c: Update.
3917         * s390-tdep.c: Update.
3918         * selftest-arch.c: Update.
3919         * solib-dsbt.c: Update.
3920         * solib-frv.c: Update.
3921         * solib-spu.c: Update.
3922         * solib-svr4.c: Update.
3923         * solib.c: Update.
3924         * sparc64-linux-tdep.c: Update.
3925         * stack.c: Update.
3926         * symfile-mem.c: Update.
3927         * symmisc.c: Update.
3928         * target.c: Update.
3929         * thread.c: Update.
3930         * top.c: Update.
3931         * tracefile-tfile.c: Update.
3932         * tui/tui.c: Update.
3933         * typeprint.c: Update.
3934         * unittests/cli-utils-selftests.c: Update.
3935         * unittests/parse-connection-spec-selftests.c: Update.
3936         * valops.c: Update.
3937         * valprint.c: Update.
3938         * value.c: Update.
3939         * varobj.c: Update.
3940         * windows-nat.c: Update.
3941         * x86-linux-nat.c: Update.
3942         * xml-support.c: Update.
3943
3944 2019-04-08  Tom Tromey  <tom@tromey.com>
3945
3946         * xml-support.c: Use C++ exception handling.
3947         * x86-linux-nat.c: Use C++ exception handling.
3948         * windows-nat.c: Use C++ exception handling.
3949         * varobj.c: Use C++ exception handling.
3950         * value.c: Use C++ exception handling.
3951         * valprint.c: Use C++ exception handling.
3952         * valops.c: Use C++ exception handling.
3953         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3954         handling.
3955         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3956         * typeprint.c: Use C++ exception handling.
3957         * tui/tui.c: Use C++ exception handling.
3958         * tracefile-tfile.c: Use C++ exception handling.
3959         * top.c: Use C++ exception handling.
3960         * thread.c: Use C++ exception handling.
3961         * target.c: Use C++ exception handling.
3962         * symmisc.c: Use C++ exception handling.
3963         * symfile-mem.c: Use C++ exception handling.
3964         * stack.c: Use C++ exception handling.
3965         * sparc64-linux-tdep.c: Use C++ exception handling.
3966         * solib.c: Use C++ exception handling.
3967         * solib-svr4.c: Use C++ exception handling.
3968         * solib-spu.c: Use C++ exception handling.
3969         * solib-frv.c: Use C++ exception handling.
3970         * solib-dsbt.c: Use C++ exception handling.
3971         * selftest-arch.c: Use C++ exception handling.
3972         * s390-tdep.c: Use C++ exception handling.
3973         * rust-lang.c: Use C++ exception handling.
3974         * rust-exp.y: Use C++ exception handling.
3975         * rs6000-tdep.c: Use C++ exception handling.
3976         * rs6000-aix-tdep.c: Use C++ exception handling.
3977         * riscv-tdep.c: Use C++ exception handling.
3978         * remote.c: Use C++ exception handling.
3979         * remote-fileio.c: Use C++ exception handling.
3980         * record-full.c: Use C++ exception handling.
3981         * record-btrace.c: Use C++ exception handling.
3982         * python/python.c: Use C++ exception handling.
3983         * python/py-value.c: Use C++ exception handling.
3984         * python/py-utils.c: Use C++ exception handling.
3985         * python/py-unwind.c: Use C++ exception handling.
3986         * python/py-type.c: Use C++ exception handling.
3987         * python/py-symbol.c: Use C++ exception handling.
3988         * python/py-record.c: Use C++ exception handling.
3989         * python/py-record-btrace.c: Use C++ exception handling.
3990         * python/py-progspace.c: Use C++ exception handling.
3991         * python/py-prettyprint.c: Use C++ exception handling.
3992         * python/py-param.c: Use C++ exception handling.
3993         * python/py-objfile.c: Use C++ exception handling.
3994         * python/py-linetable.c: Use C++ exception handling.
3995         * python/py-lazy-string.c: Use C++ exception handling.
3996         * python/py-infthread.c: Use C++ exception handling.
3997         * python/py-inferior.c: Use C++ exception handling.
3998         * python/py-gdb-readline.c: Use C++ exception handling.
3999         * python/py-framefilter.c: Use C++ exception handling.
4000         * python/py-frame.c: Use C++ exception handling.
4001         * python/py-finishbreakpoint.c: Use C++ exception handling.
4002         * python/py-cmd.c: Use C++ exception handling.
4003         * python/py-breakpoint.c: Use C++ exception handling.
4004         * python/py-arch.c: Use C++ exception handling.
4005         * printcmd.c: Use C++ exception handling.
4006         * ppc-linux-tdep.c: Use C++ exception handling.
4007         * parse.c: Use C++ exception handling.
4008         * p-valprint.c: Use C++ exception handling.
4009         * objc-lang.c: Use C++ exception handling.
4010         * mi/mi-main.c: Use C++ exception handling.
4011         * mi/mi-interp.c: Use C++ exception handling.
4012         * mi/mi-cmd-stack.c: Use C++ exception handling.
4013         * mi/mi-cmd-break.c: Use C++ exception handling.
4014         * main.c: Use C++ exception handling.
4015         * linux-thread-db.c: Use C++ exception handling.
4016         * linux-tdep.c: Use C++ exception handling.
4017         * linux-nat.c: Use C++ exception handling.
4018         * linux-fork.c: Use C++ exception handling.
4019         * linespec.c: Use C++ exception handling.
4020         * language.c: Use C++ exception handling.
4021         * jit.c: Use C++ exception handling.
4022         * infrun.c: Use C++ exception handling.
4023         * infcmd.c: Use C++ exception handling.
4024         * infcall.c: Use C++ exception handling.
4025         * inf-loop.c: Use C++ exception handling.
4026         * i386-tdep.c: Use C++ exception handling.
4027         * i386-linux-tdep.c: Use C++ exception handling.
4028         * guile/scm-value.c: Use C++ exception handling.
4029         * guile/scm-type.c: Use C++ exception handling.
4030         * guile/scm-symtab.c: Use C++ exception handling.
4031         * guile/scm-symbol.c: Use C++ exception handling.
4032         * guile/scm-pretty-print.c: Use C++ exception handling.
4033         * guile/scm-ports.c: Use C++ exception handling.
4034         * guile/scm-param.c: Use C++ exception handling.
4035         * guile/scm-math.c: Use C++ exception handling.
4036         * guile/scm-lazy-string.c: Use C++ exception handling.
4037         * guile/scm-frame.c: Use C++ exception handling.
4038         * guile/scm-disasm.c: Use C++ exception handling.
4039         * guile/scm-cmd.c: Use C++ exception handling.
4040         * guile/scm-breakpoint.c: Use C++ exception handling.
4041         * guile/scm-block.c: Use C++ exception handling.
4042         * guile/guile-internal.h: Use C++ exception handling.
4043         * gnu-v3-abi.c: Use C++ exception handling.
4044         * gdbtypes.c: Use C++ exception handling.
4045         * frame.c: Use C++ exception handling.
4046         * frame-unwind.c: Use C++ exception handling.
4047         * fbsd-tdep.c: Use C++ exception handling.
4048         * f-valprint.c: Use C++ exception handling.
4049         * exec.c: Use C++ exception handling.
4050         * event-top.c: Use C++ exception handling.
4051         * event-loop.c: Use C++ exception handling.
4052         * eval.c: Use C++ exception handling.
4053         * dwarf2read.c: Use C++ exception handling.
4054         * dwarf2loc.c: Use C++ exception handling.
4055         * dwarf2-frame.c: Use C++ exception handling.
4056         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4057         * dwarf-index-write.c: Use C++ exception handling.
4058         * dwarf-index-cache.c: Use C++ exception handling.
4059         * dtrace-probe.c: Use C++ exception handling.
4060         * disasm-selftests.c: Use C++ exception handling.
4061         * darwin-nat.c: Use C++ exception handling.
4062         * cp-valprint.c: Use C++ exception handling.
4063         * cp-support.c: Use C++ exception handling.
4064         * cp-abi.c: Use C++ exception handling.
4065         * corelow.c: Use C++ exception handling.
4066         * completer.c: Use C++ exception handling.
4067         * compile/compile-object-run.c: Use C++ exception handling.
4068         * compile/compile-object-load.c: Use C++ exception handling.
4069         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4070         * compile/compile-c-symbols.c: Use C++ exception handling.
4071         * common/selftest.c: Use C++ exception handling.
4072         * common/new-op.c: Use C++ exception handling.
4073         * cli/cli-script.c: Use C++ exception handling.
4074         * cli/cli-interp.c: Use C++ exception handling.
4075         * cli/cli-cmds.c: Use C++ exception handling.
4076         * c-varobj.c: Use C++ exception handling.
4077         * btrace.c: Use C++ exception handling.
4078         * breakpoint.c: Use C++ exception handling.
4079         * break-catch-throw.c: Use C++ exception handling.
4080         * arch-utils.c: Use C++ exception handling.
4081         * amd64-tdep.c: Use C++ exception handling.
4082         * ada-valprint.c: Use C++ exception handling.
4083         * ada-typeprint.c: Use C++ exception handling.
4084         * ada-lang.c: Use C++ exception handling.
4085         * aarch64-tdep.c: Use C++ exception handling.
4086
4087 2019-04-08  Tom Tromey  <tom@tromey.com>
4088
4089         * xml-support.c (gdb_xml_parser::parse): Update.
4090         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4091         * value.c (show_convenience): Update.
4092         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4093         (test_parse_flags_qcs): Update.
4094         * thread.c (thr_try_catch_cmd): Update.
4095         * target.c (target_translate_tls_address): Update.
4096         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4097         (info_frame_command_core, frame_apply_command_count): Update.
4098         * rust-exp.y (rust_lex_exception_test): Update.
4099         * riscv-tdep.c (riscv_print_one_register_info): Update.
4100         * remote.c (remote_target::enable_btrace): Update.
4101         * record-btrace.c (record_btrace_enable_warn): Update.
4102         * python/py-utils.c (gdbpy_convert_exception): Update.
4103         * printcmd.c (do_one_display, print_variable_and_value): Update.
4104         * mi/mi-main.c (mi_print_exception): Update.
4105         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4106         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4107         * linux-nat.c (linux_nat_target::attach): Update.
4108         * linux-fork.c (class scoped_switch_fork_info): Update.
4109         * infrun.c (displaced_step_prepare): Update.
4110         * infcall.c (call_function_by_hand_dummy): Update.
4111         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4112         * gnu-v3-abi.c (print_one_vtable): Update.
4113         * frame.c (get_prev_frame_always): Update.
4114         * f-valprint.c (info_common_command_for_block): Update.
4115         * exec.c (try_open_exec_file): Update.
4116         * exceptions.c (print_exception, exception_print)
4117         (exception_fprintf, exception_print_same): Update.
4118         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4119         * dwarf-index-cache.c (index_cache::store)
4120         (index_cache::lookup_gdb_index): Update.
4121         * darwin-nat.c (maybe_cache_shell): Update.
4122         * cp-valprint.c (cp_print_value_fields): Update.
4123         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4124         (gcc_cplus_symbol_address): Update.
4125         * compile/compile-c-symbols.c (gcc_convert_symbol)
4126         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4127         * common/selftest.c: Update.
4128         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4129         a std::string.
4130         (exception_try_scope_entry, exception_try_scope_exit): Don't
4131         declare.
4132         (struct exception_try_scope): Remove.
4133         (TRY): Don't use exception_try_scope.
4134         (struct gdb_exception): Add constructor, operator=.
4135         <what>: New method.
4136         (struct gdb_exception_RETURN_MASK_ALL)
4137         (struct gdb_exception_RETURN_MASK_ERROR)
4138         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4139         (struct gdb_quit_bad_alloc): Update.
4140         * common/common-exceptions.c (exception_none): Change
4141         initializer.
4142         (struct catcher) <state, exception>: Initialize inline.
4143         <prev>: Remove member.
4144         (current_catcher): Remove.
4145         (catchers): New global.
4146         (exceptions_state_mc_init): Simplify.
4147         (catcher_pop): Remove.
4148         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4149         (try_scope_depth, exception_try_scope_entry)
4150         (exception_try_scope_exit): Remove.
4151         (throw_exception_sjlj): Update.
4152         (exception_messages, exception_messages_size): Remove.
4153         (throw_it): Simplify.
4154         (gdb_exception_sliced_copy): Remove.
4155         (throw_exception_cxx): Update.
4156         * cli/cli-script.c (script_from_file): Update.
4157         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4158         Update.
4159         * ada-valprint.c (ada_val_print): Update.
4160         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4161         (create_excep_cond_exprs): Update.
4162
4163 2019-04-08  Tom Tromey  <tom@tromey.com>
4164
4165         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4166         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4167         (TRY, CATCH, END_CATCH): Remove some definitions.
4168         * common/common-exceptions.c: Don't use GDB_XCPT.
4169         (catcher_list_size): Remove.
4170         (throw_exception, throw_it): Simplify.
4171
4172 2019-04-05  Tom Tromey  <tom@tromey.com>
4173
4174         Revert the header-sorting patch.
4175         * ft32-tdep.c: Revert.
4176         * frv-tdep.c: Revert.
4177         * frv-linux-tdep.c: Revert.
4178         * frame.c: Revert.
4179         * frame-unwind.c: Revert.
4180         * frame-base.c: Revert.
4181         * fork-child.c: Revert.
4182         * findvar.c: Revert.
4183         * findcmd.c: Revert.
4184         * filesystem.c: Revert.
4185         * filename-seen-cache.h: Revert.
4186         * filename-seen-cache.c: Revert.
4187         * fbsd-tdep.c: Revert.
4188         * fbsd-nat.h: Revert.
4189         * fbsd-nat.c: Revert.
4190         * f-valprint.c: Revert.
4191         * f-typeprint.c: Revert.
4192         * f-lang.c: Revert.
4193         * extension.h: Revert.
4194         * extension.c: Revert.
4195         * extension-priv.h: Revert.
4196         * expprint.c: Revert.
4197         * exec.h: Revert.
4198         * exec.c: Revert.
4199         * exceptions.c: Revert.
4200         * event-top.c: Revert.
4201         * event-loop.c: Revert.
4202         * eval.c: Revert.
4203         * elfread.c: Revert.
4204         * dwarf2read.h: Revert.
4205         * dwarf2read.c: Revert.
4206         * dwarf2loc.c: Revert.
4207         * dwarf2expr.h: Revert.
4208         * dwarf2expr.c: Revert.
4209         * dwarf2-frame.c: Revert.
4210         * dwarf2-frame-tailcall.c: Revert.
4211         * dwarf-index-write.h: Revert.
4212         * dwarf-index-write.c: Revert.
4213         * dwarf-index-common.c: Revert.
4214         * dwarf-index-cache.h: Revert.
4215         * dwarf-index-cache.c: Revert.
4216         * dummy-frame.c: Revert.
4217         * dtrace-probe.c: Revert.
4218         * disasm.h: Revert.
4219         * disasm.c: Revert.
4220         * disasm-selftests.c: Revert.
4221         * dictionary.c: Revert.
4222         * dicos-tdep.c: Revert.
4223         * demangle.c: Revert.
4224         * dcache.h: Revert.
4225         * dcache.c: Revert.
4226         * darwin-nat.h: Revert.
4227         * darwin-nat.c: Revert.
4228         * darwin-nat-info.c: Revert.
4229         * d-valprint.c: Revert.
4230         * d-namespace.c: Revert.
4231         * d-lang.c: Revert.
4232         * ctf.c: Revert.
4233         * csky-tdep.c: Revert.
4234         * csky-linux-tdep.c: Revert.
4235         * cris-tdep.c: Revert.
4236         * cris-linux-tdep.c: Revert.
4237         * cp-valprint.c: Revert.
4238         * cp-support.c: Revert.
4239         * cp-namespace.c: Revert.
4240         * cp-abi.c: Revert.
4241         * corelow.c: Revert.
4242         * corefile.c: Revert.
4243         * continuations.c: Revert.
4244         * completer.h: Revert.
4245         * completer.c: Revert.
4246         * complaints.c: Revert.
4247         * coffread.c: Revert.
4248         * coff-pe-read.c: Revert.
4249         * cli-out.h: Revert.
4250         * cli-out.c: Revert.
4251         * charset.c: Revert.
4252         * c-varobj.c: Revert.
4253         * c-valprint.c: Revert.
4254         * c-typeprint.c: Revert.
4255         * c-lang.c: Revert.
4256         * buildsym.c: Revert.
4257         * buildsym-legacy.c: Revert.
4258         * build-id.h: Revert.
4259         * build-id.c: Revert.
4260         * btrace.c: Revert.
4261         * bsd-uthread.c: Revert.
4262         * breakpoint.h: Revert.
4263         * breakpoint.c: Revert.
4264         * break-catch-throw.c: Revert.
4265         * break-catch-syscall.c: Revert.
4266         * break-catch-sig.c: Revert.
4267         * blockframe.c: Revert.
4268         * block.c: Revert.
4269         * bfin-tdep.c: Revert.
4270         * bfin-linux-tdep.c: Revert.
4271         * bfd-target.c: Revert.
4272         * bcache.c: Revert.
4273         * ax-general.c: Revert.
4274         * ax-gdb.h: Revert.
4275         * ax-gdb.c: Revert.
4276         * avr-tdep.c: Revert.
4277         * auxv.c: Revert.
4278         * auto-load.c: Revert.
4279         * arm-wince-tdep.c: Revert.
4280         * arm-tdep.c: Revert.
4281         * arm-symbian-tdep.c: Revert.
4282         * arm-pikeos-tdep.c: Revert.
4283         * arm-obsd-tdep.c: Revert.
4284         * arm-nbsd-tdep.c: Revert.
4285         * arm-nbsd-nat.c: Revert.
4286         * arm-linux-tdep.c: Revert.
4287         * arm-linux-nat.c: Revert.
4288         * arm-fbsd-tdep.c: Revert.
4289         * arm-fbsd-nat.c: Revert.
4290         * arm-bsd-tdep.c: Revert.
4291         * arch-utils.c: Revert.
4292         * arc-tdep.c: Revert.
4293         * arc-newlib-tdep.c: Revert.
4294         * annotate.h: Revert.
4295         * annotate.c: Revert.
4296         * amd64-windows-tdep.c: Revert.
4297         * amd64-windows-nat.c: Revert.
4298         * amd64-tdep.c: Revert.
4299         * amd64-sol2-tdep.c: Revert.
4300         * amd64-obsd-tdep.c: Revert.
4301         * amd64-obsd-nat.c: Revert.
4302         * amd64-nbsd-tdep.c: Revert.
4303         * amd64-nbsd-nat.c: Revert.
4304         * amd64-nat.c: Revert.
4305         * amd64-linux-tdep.c: Revert.
4306         * amd64-linux-nat.c: Revert.
4307         * amd64-fbsd-tdep.c: Revert.
4308         * amd64-fbsd-nat.c: Revert.
4309         * amd64-dicos-tdep.c: Revert.
4310         * amd64-darwin-tdep.c: Revert.
4311         * amd64-bsd-nat.c: Revert.
4312         * alpha-tdep.c: Revert.
4313         * alpha-obsd-tdep.c: Revert.
4314         * alpha-nbsd-tdep.c: Revert.
4315         * alpha-mdebug-tdep.c: Revert.
4316         * alpha-linux-tdep.c: Revert.
4317         * alpha-linux-nat.c: Revert.
4318         * alpha-bsd-tdep.c: Revert.
4319         * alpha-bsd-nat.c: Revert.
4320         * aix-thread.c: Revert.
4321         * agent.c: Revert.
4322         * addrmap.c: Revert.
4323         * ada-varobj.c: Revert.
4324         * ada-valprint.c: Revert.
4325         * ada-typeprint.c: Revert.
4326         * ada-tasks.c: Revert.
4327         * ada-lang.c: Revert.
4328         * aarch64-tdep.c: Revert.
4329         * aarch64-ravenscar-thread.c: Revert.
4330         * aarch64-newlib-tdep.c: Revert.
4331         * aarch64-linux-tdep.c: Revert.
4332         * aarch64-linux-nat.c: Revert.
4333         * aarch64-fbsd-tdep.c: Revert.
4334         * aarch64-fbsd-nat.c: Revert.
4335         * aarch32-linux-nat.c: Revert.
4336
4337 2019-04-05  Tom Tromey  <tom@tromey.com>
4338
4339         * ft32-tdep.c: Sort headers.
4340         * frv-tdep.c: Sort headers.
4341         * frv-linux-tdep.c: Sort headers.
4342         * frame.c: Sort headers.
4343         * frame-unwind.c: Sort headers.
4344         * frame-base.c: Sort headers.
4345         * fork-child.c: Sort headers.
4346         * findvar.c: Sort headers.
4347         * findcmd.c: Sort headers.
4348         * filesystem.c: Sort headers.
4349         * filename-seen-cache.h: Sort headers.
4350         * filename-seen-cache.c: Sort headers.
4351         * fbsd-tdep.c: Sort headers.
4352         * fbsd-nat.h: Sort headers.
4353         * fbsd-nat.c: Sort headers.
4354         * f-valprint.c: Sort headers.
4355         * f-typeprint.c: Sort headers.
4356         * f-lang.c: Sort headers.
4357         * extension.h: Sort headers.
4358         * extension.c: Sort headers.
4359         * extension-priv.h: Sort headers.
4360         * expprint.c: Sort headers.
4361         * exec.h: Sort headers.
4362         * exec.c: Sort headers.
4363         * exceptions.c: Sort headers.
4364         * event-top.c: Sort headers.
4365         * event-loop.c: Sort headers.
4366         * eval.c: Sort headers.
4367         * elfread.c: Sort headers.
4368         * dwarf2read.h: Sort headers.
4369         * dwarf2read.c: Sort headers.
4370         * dwarf2loc.c: Sort headers.
4371         * dwarf2expr.h: Sort headers.
4372         * dwarf2expr.c: Sort headers.
4373         * dwarf2-frame.c: Sort headers.
4374         * dwarf2-frame-tailcall.c: Sort headers.
4375         * dwarf-index-write.h: Sort headers.
4376         * dwarf-index-write.c: Sort headers.
4377         * dwarf-index-common.c: Sort headers.
4378         * dwarf-index-cache.h: Sort headers.
4379         * dwarf-index-cache.c: Sort headers.
4380         * dummy-frame.c: Sort headers.
4381         * dtrace-probe.c: Sort headers.
4382         * disasm.h: Sort headers.
4383         * disasm.c: Sort headers.
4384         * disasm-selftests.c: Sort headers.
4385         * dictionary.c: Sort headers.
4386         * dicos-tdep.c: Sort headers.
4387         * demangle.c: Sort headers.
4388         * dcache.h: Sort headers.
4389         * dcache.c: Sort headers.
4390         * darwin-nat.h: Sort headers.
4391         * darwin-nat.c: Sort headers.
4392         * darwin-nat-info.c: Sort headers.
4393         * d-valprint.c: Sort headers.
4394         * d-namespace.c: Sort headers.
4395         * d-lang.c: Sort headers.
4396         * ctf.c: Sort headers.
4397         * csky-tdep.c: Sort headers.
4398         * csky-linux-tdep.c: Sort headers.
4399         * cris-tdep.c: Sort headers.
4400         * cris-linux-tdep.c: Sort headers.
4401         * cp-valprint.c: Sort headers.
4402         * cp-support.c: Sort headers.
4403         * cp-namespace.c: Sort headers.
4404         * cp-abi.c: Sort headers.
4405         * corelow.c: Sort headers.
4406         * corefile.c: Sort headers.
4407         * continuations.c: Sort headers.
4408         * completer.h: Sort headers.
4409         * completer.c: Sort headers.
4410         * complaints.c: Sort headers.
4411         * coffread.c: Sort headers.
4412         * coff-pe-read.c: Sort headers.
4413         * cli-out.h: Sort headers.
4414         * cli-out.c: Sort headers.
4415         * charset.c: Sort headers.
4416         * c-varobj.c: Sort headers.
4417         * c-valprint.c: Sort headers.
4418         * c-typeprint.c: Sort headers.
4419         * c-lang.c: Sort headers.
4420         * buildsym.c: Sort headers.
4421         * buildsym-legacy.c: Sort headers.
4422         * build-id.h: Sort headers.
4423         * build-id.c: Sort headers.
4424         * btrace.c: Sort headers.
4425         * bsd-uthread.c: Sort headers.
4426         * breakpoint.h: Sort headers.
4427         * breakpoint.c: Sort headers.
4428         * break-catch-throw.c: Sort headers.
4429         * break-catch-syscall.c: Sort headers.
4430         * break-catch-sig.c: Sort headers.
4431         * blockframe.c: Sort headers.
4432         * block.c: Sort headers.
4433         * bfin-tdep.c: Sort headers.
4434         * bfin-linux-tdep.c: Sort headers.
4435         * bfd-target.c: Sort headers.
4436         * bcache.c: Sort headers.
4437         * ax-general.c: Sort headers.
4438         * ax-gdb.h: Sort headers.
4439         * ax-gdb.c: Sort headers.
4440         * avr-tdep.c: Sort headers.
4441         * auxv.c: Sort headers.
4442         * auto-load.c: Sort headers.
4443         * arm-wince-tdep.c: Sort headers.
4444         * arm-tdep.c: Sort headers.
4445         * arm-symbian-tdep.c: Sort headers.
4446         * arm-pikeos-tdep.c: Sort headers.
4447         * arm-obsd-tdep.c: Sort headers.
4448         * arm-nbsd-tdep.c: Sort headers.
4449         * arm-nbsd-nat.c: Sort headers.
4450         * arm-linux-tdep.c: Sort headers.
4451         * arm-linux-nat.c: Sort headers.
4452         * arm-fbsd-tdep.c: Sort headers.
4453         * arm-fbsd-nat.c: Sort headers.
4454         * arm-bsd-tdep.c: Sort headers.
4455         * arch-utils.c: Sort headers.
4456         * arc-tdep.c: Sort headers.
4457         * arc-newlib-tdep.c: Sort headers.
4458         * annotate.h: Sort headers.
4459         * annotate.c: Sort headers.
4460         * amd64-windows-tdep.c: Sort headers.
4461         * amd64-windows-nat.c: Sort headers.
4462         * amd64-tdep.c: Sort headers.
4463         * amd64-sol2-tdep.c: Sort headers.
4464         * amd64-obsd-tdep.c: Sort headers.
4465         * amd64-obsd-nat.c: Sort headers.
4466         * amd64-nbsd-tdep.c: Sort headers.
4467         * amd64-nbsd-nat.c: Sort headers.
4468         * amd64-nat.c: Sort headers.
4469         * amd64-linux-tdep.c: Sort headers.
4470         * amd64-linux-nat.c: Sort headers.
4471         * amd64-fbsd-tdep.c: Sort headers.
4472         * amd64-fbsd-nat.c: Sort headers.
4473         * amd64-dicos-tdep.c: Sort headers.
4474         * amd64-darwin-tdep.c: Sort headers.
4475         * amd64-bsd-nat.c: Sort headers.
4476         * alpha-tdep.c: Sort headers.
4477         * alpha-obsd-tdep.c: Sort headers.
4478         * alpha-nbsd-tdep.c: Sort headers.
4479         * alpha-mdebug-tdep.c: Sort headers.
4480         * alpha-linux-tdep.c: Sort headers.
4481         * alpha-linux-nat.c: Sort headers.
4482         * alpha-bsd-tdep.c: Sort headers.
4483         * alpha-bsd-nat.c: Sort headers.
4484         * aix-thread.c: Sort headers.
4485         * agent.c: Sort headers.
4486         * addrmap.c: Sort headers.
4487         * ada-varobj.c: Sort headers.
4488         * ada-valprint.c: Sort headers.
4489         * ada-typeprint.c: Sort headers.
4490         * ada-tasks.c: Sort headers.
4491         * ada-lang.c: Sort headers.
4492         * aarch64-tdep.c: Sort headers.
4493         * aarch64-ravenscar-thread.c: Sort headers.
4494         * aarch64-newlib-tdep.c: Sort headers.
4495         * aarch64-linux-tdep.c: Sort headers.
4496         * aarch64-linux-nat.c: Sort headers.
4497         * aarch64-fbsd-tdep.c: Sort headers.
4498         * aarch64-fbsd-nat.c: Sort headers.
4499         * aarch32-linux-nat.c: Sort headers.
4500
4501 2019-04-04  Tom Tromey  <tom@tromey.com>
4502
4503         * varobj.c (varobj_create): Update.
4504         * rust-exp.y (struct rust_parser) <update_innermost_block,
4505         lookup_symbol>: New methods.
4506         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4507         Rename.
4508         (rust_parser::rust_lookup_type)
4509         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4510         * printcmd.c (display_command, do_one_display): Update.
4511         * parser-defs.h (struct parser_state) <parser_state>: Add
4512         "tracker" parameter.
4513         (block_tracker): New member.
4514         (class innermost_block_tracker) <innermost_block_tracker>: Add
4515         "types" parameter.
4516         <reset>: Remove method.
4517         (innermost_block): Don't declare.
4518         (null_post_parser): Update.
4519         * parse.c (innermost_block): Remove global.
4520         (write_dollar_variable): Update.
4521         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4522         Remove "tracker_types" parameter.
4523         (parse_expression): Add "tracker" parameter.
4524         (parse_expression_for_completion): Update.
4525         (null_post_parser): Add "tracker" parameter.
4526         * p-exp.y: Update rules.
4527         * m2-exp.y: Update rules.
4528         * language.h (struct language_defn) <la_post_parser>: Add
4529         "tracker" parameter.
4530         * go-exp.y: Update rules.
4531         * f-exp.y: Update rules.
4532         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4533         parameter.
4534         * d-exp.y: Update rules.
4535         * c-exp.y: Update rules.
4536         * breakpoint.c (set_breakpoint_condition): Create an
4537         innermost_block_tracker.
4538         (watch_command_1): Likewise.
4539         * ada-lang.c (resolve): Add "tracker" parameter.
4540         (resolve_subexp): Likewise.
4541         * ada-exp.y (write_var_from_sym): Update.
4542
4543 2019-04-04  Tom Tromey  <tom@tromey.com>
4544
4545         * type-stack.h: New file.
4546         * type-stack.c: New file.
4547         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4548         type-stack.h.
4549         (insert_into_type_stack, insert_type, push_type, push_type_int)
4550         (insert_type_address_space, pop_type, pop_type_int)
4551         (pop_typelist, pop_type_stack, append_type_stack)
4552         (push_type_stack, get_type_stack, push_typelist)
4553         (follow_type_instance_flags, follow_types): Don't declare.
4554         * parse.c (type_stack): Remove global.
4555         (parse_exp_in_context): Update.
4556         (insert_into_type_stack, insert_type, push_type, push_type_int)
4557         (insert_type_address_space, pop_type, pop_type_int)
4558         (pop_typelist, pop_type_stack, append_type_stack)
4559         (push_type_stack, get_type_stack, push_typelist)
4560         (follow_type_instance_flags, follow_types): Remove (moved to
4561         type-stack.c).
4562         * f-exp.y (type_stack): New global.
4563         Update rules.
4564         (push_kind_type, f_parse): Update.
4565         * d-exp.y (type_stack): New global.
4566         Update rules.
4567         (d_parse): Update.
4568         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4569         Update rules.
4570         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4571         (HFILES_NO_SRCDIR): Add type-stack.h.
4572
4573 2019-04-04  Tom Tromey  <tom@tromey.com>
4574
4575         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4576         (rust_parser::convert_ast_to_expression, rust_parse)
4577         (rust_lex_test_completion, rust_lex_tests): Update.
4578         * parser-defs.h (struct expr_completion_state): New.
4579         (struct parser_state) <parser_state>: Add completion parameter.
4580         <mark_struct_expression, mark_completion_tag>: New methods.
4581         <parse_completion, m_completion_state>: New members.
4582         (prefixify_expression, null_post_parser): Update.
4583         (mark_struct_expression, mark_completion_tag): Don't declare.
4584         * parse.c (parse_completion, expout_last_struct)
4585         (expout_tag_completion_type, expout_completion_name): Remove
4586         globals.
4587         (parser_state::mark_struct_expression)
4588         (parser_state::mark_completion_tag): Now methods.
4589         (prefixify_expression): Add last_struct parameter.
4590         (prefixify_subexp): Likewise.
4591         (parse_exp_1): Update.
4592         (parse_exp_in_context): Add cstate parameter.  Update.
4593         (parse_expression_for_completion): Create an
4594         expr_completion_state.
4595         (null_post_parser): Add "completion" parameter.
4596         * p-exp.y: Update rules.
4597         (yylex): Update.
4598         * language.h (struct language_defn) <la_post_parser>: Add
4599         "completing" parameter.
4600         * go-exp.y: Update rules.
4601         (lex_one_token): Update.
4602         * expression.h (parse_completion): Don't declare.
4603         * d-exp.y: Update rules.
4604         (lex_one_token): Update rules.
4605         * c-exp.y: Update rules.
4606         (lex_one_token): Update.
4607         * ada-lang.c (resolve): Add "parse_completion" parameter.
4608         (resolve_subexp): Likewise.
4609         (ada_resolve_function): Likewise.
4610
4611 2019-04-04  Tom Tromey  <tom@tromey.com>
4612
4613         * parser-defs.h (struct parser_state) <start_arglist,
4614         end_arglist>: New methods.
4615         <arglist_len, m_funcall_chain>: New members.
4616         (arglist_len, start_arglist, end_arglist): Don't declare.
4617         * parse.c (arglist_len, funcall_chain): Remove global.
4618         (start_arglist, end_arglist): Remove functions.
4619         (parse_exp_in_context): Update.
4620         * p-exp.y: Update rules.
4621         * m2-exp.y: Update rules.
4622         * go-exp.y: Update rules.
4623         * f-exp.y: Update rules.
4624         * d-exp.y: Update rules.
4625         * c-exp.y: Update rules.
4626
4627 2019-04-04  Tom Tromey  <tom@tromey.com>
4628
4629         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4630         lex_operator, push_back>: New methods.
4631         Update all rules.
4632         (rust_parser::lex_hex, lex_escape): Rename and update.
4633         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4634         (rust_parser::lex_operator): Rename and update.
4635         (rust_parser::lex_number, rustyylex, rustyyerror)
4636         (rust_lex_test_init, rust_lex_test_sequence)
4637         (rust_lex_test_push_back, rust_lex_tests): Update.
4638         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4639         parameter.
4640         <lexptr, prev_lexptr>: New members.
4641         (lexptr, prev_lexptr): Don't declare.
4642         * parse.c (lexptr, prev_lexptr): Remove globals.
4643         (parse_exp_in_context): Update.
4644         * p-exp.y (yylex, yyerror): Update.
4645         * m2-exp.y (parse_number, yylex, yyerror): Update.
4646         * go-exp.y (lex_one_token, yyerror): Update.
4647         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4648         * d-exp.y (lex_one_token, yyerror): Update.
4649         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4650         (lex_one_token, yyerror): Update.
4651         * ada-lex.l (YY_INPUT): Update.
4652         (rewind_to_char): Update.
4653         * ada-exp.y (yyerror): Update.
4654
4655 2019-04-04  Tom Tromey  <tom@tromey.com>
4656
4657         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4658         * parser-defs.h (struct parser_state) <parser_state>: Add new
4659         parameter.
4660         <comma_terminates>: New member.
4661         (comma_terminates): Don't declare global.
4662         * parse.c (comma_terminates): Remove global.
4663         (parse_exp_in_context): Update.
4664         * p-exp.y (yylex): Update.
4665         * m2-exp.y (yylex): Update.
4666         * go-exp.y (lex_one_token): Update.
4667         * f-exp.y (yylex): Update.
4668         * d-exp.y (lex_one_token): Update.
4669         * c-exp.y (lex_one_token): Update.
4670         * ada-lex.l: Update.
4671
4672 2019-04-04  Tom Tromey  <tom@tromey.com>
4673
4674         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4675         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4676         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4677         * parser-defs.h (paren_depth): Don't declare.
4678         * parse.c (paren_depth): Remove global.
4679         (parse_exp_in_context): Update.
4680         * p-exp.y (paren_depth): New global.
4681         (pascal_parse): Initialize it.
4682         * m2-exp.y (paren_depth): New global.
4683         (m2_parse): Initialize it.
4684         * go-exp.y (paren_depth): New global.
4685         (go_parse): Initialize it.
4686         * f-exp.y (paren_depth): New global.
4687         (f_parse): Initialize it.
4688         * d-exp.y (paren_depth): New global.
4689         (d_parse): Initialize it.
4690         * c-exp.y (paren_depth): New global.
4691         (c_parse): Initialize it.
4692         * ada-lex.l (paren_depth): New global.
4693         (lexer_init): Initialize it.
4694
4695 2019-04-04  Tom Tromey  <tom@tromey.com>
4696
4697         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4698         (rust_parser::convert_ast_to_type)
4699         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4700         * parser-defs.h (struct parser_state) <parser_state>: Add
4701         parameters.  Initialize new members.
4702         <expression_context_block, expression_context_pc>: New members.
4703         * parse.c (expression_context_block, expression_context_pc):
4704         Remove globals.
4705         (parse_exp_in_context): Update.
4706         * p-exp.y: Update all rules.
4707         (yylex): Update.
4708         * m2-exp.y: Update all rules.
4709         (yylex): Update.
4710         * go-exp.y (yylex): Update.
4711         * f-exp.y (yylex): Update.
4712         * d-exp.y: Update all rules.
4713         (yylex): Update.
4714         * c-exp.y: Update all rules.
4715         (lex_one_token, classify_name, yylex, c_parse): Update.
4716         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4717
4718 2019-04-04  Tom Tromey  <tom@tromey.com>
4719
4720         * gdbarch.h, gdbarch.c: Rebuild.
4721         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4722         * stap-probe.h:
4723         (struct stap_parse_info): Replace "parser_state" with
4724         "expr_builder".
4725         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4726         (parser_state): New class.
4727         * parse.c (expr_builder): Rename.
4728         (expr_builder::release): Rename.
4729         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4730         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4731         (write_exp_elt_longcst, write_exp_elt_floatcst)
4732         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4733         (write_exp_string_vector, write_exp_bitstring)
4734         (write_exp_msymbol, mark_struct_expression)
4735         (write_dollar_variable)
4736         (insert_type_address_space, increase_expout_size): Replace
4737         "parser_state" with "expr_builder".
4738         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4739         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4740         "parser_state" with "expr_builder".
4741
4742 2019-04-04  Tom Tromey  <tom@tromey.com>
4743
4744         * rust-exp.y: Replace "parse_language" with method call.
4745         * p-exp.y:
4746         (yylex): Replace "parse_language" with method call.
4747         * m2-exp.y:
4748         (yylex): Replace "parse_language" with method call.
4749         * go-exp.y (classify_name): Replace "parse_language" with method
4750         call.
4751         * f-exp.y (yylex): Replace "parse_language" with method call.
4752         * d-exp.y (lex_one_token): Replace "parse_language" with method
4753         call.
4754         * c-exp.y:
4755         (lex_one_token, classify_name, yylex): Replace "parse_language"
4756         with method call.
4757         * ada-exp.y (find_primitive_type, type_char)
4758         (type_system_address): Replace "parse_language" with method call.
4759
4760 2019-04-04  Tom Tromey  <tom@tromey.com>
4761
4762         * rust-exp.y: Replace "parse_gdbarch" with method call.
4763         * parse.c (write_dollar_variable, insert_type_address_space):
4764         Replace "parse_gdbarch" with method call.
4765         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4766         call.
4767         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4768         call.
4769         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4770         "parse_gdbarch" with method call.
4771         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4772         with method call.
4773         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4774         "parse_gdbarch" with method call.
4775         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4776         "parse_gdbarch" with method call.
4777         * c-exp.y (parse_type, parse_number, classify_name): Replace
4778         "parse_gdbarch" with method call.
4779         * ada-lex.l: Replace "parse_gdbarch" with method call.
4780         * ada-exp.y (parse_type, find_primitive_type, type_char)
4781         (type_system_address): Replace "parse_gdbarch" with method call.
4782
4783 2019-04-04  Tom Tromey  <tom@tromey.com>
4784
4785         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4786         * stap-probe.c (stap_parse_argument): Update.
4787         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4788         initial_size parameter.
4789         * rust-exp.y (rust_lex_tests): Update.
4790         * parse.c (parser_state): Update.
4791         (parse_exp_in_context): Update.
4792         * parser-defs.h (struct parser_state) <parser_state>: Remove
4793         "initial_size" parameter.
4794
4795 2019-04-04  Tom Tromey  <tom@tromey.com>
4796
4797         * parser-defs.h (increase_expout_size): Don't declare.
4798         * parse.c (increase_expout_size): Now static.
4799
4800 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4801
4802         * gnu-nat.c (gnu_nat_target::wait): Fix
4803         target_waitstatus_to_string call.
4804
4805 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * eval.c (evaluate_subexp_standard): Handle internal functions
4808         during Fortran function call handling.
4809
4810 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4811
4812         * NEWS: Mention new internal functions.
4813         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4814         (read_base_type): Use dwarf2_init_complex_target_type.
4815         * value.c (creal_internal_fn): New function.
4816         (cimag_internal_fn): New function.
4817         (_initialize_values): Register new internal functions.
4818
4819 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4820
4821         * infrun.c (stop_all_threads): If debug_infrun, always
4822         trace the wait status after wait_one, using
4823         target_waitstatus_to_string and target_pid_to_str.
4824         (handle_inferior_event): Replace various trace of
4825         wait status kind by a single trace.
4826         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4827         wait status kind image by target_waitstatus_to_string.
4828         * target/waitstatus.c (target_waitstatus_to_string): Fix
4829         obsolete comment.
4830
4831 2019-04-01  Tom Tromey  <tromey@adacore.com>
4832
4833         PR symtab/23331:
4834         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4835
4836 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4837             Pedro Alves  <palves@redhat.com>
4838
4839         * top.c (quit_force): Call 'finalize_values'.
4840         * value.c (finalize_values): New function.
4841         * value.h (finalize_values): Declare.
4842
4843 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4844
4845         * NEWS: Announce $_gdb_major and $_gdb_minor.
4846
4847         * top.c (init_gdb_version_vars): New function.
4848         (gdb_init): Call init_gdb_version_vars.
4849
4850 2019-03-29  Tom Tromey  <tromey@adacore.com>
4851
4852         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4853         help text.  Remove dead code.
4854
4855 2019-03-29  Keith Seitz  <keiths@redhat.com>
4856
4857         From Siddhesh Poyarekar:
4858         * f-lang.h (f77_get_upperbound): Return LONGEST.
4859         (f77_get_lowerbound): Likewise.
4860         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4861         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4862         print them.
4863         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4864         plongest to format print it.
4865         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4866         (f77_get_upperbound): Likewise.
4867         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4868         LOWER_BOUND to LONGEST.
4869         (f77_create_arrayprint_offset_tbl): Likewise.
4870
4871 2019-03-29  Keith Seitz  <keiths@redhat.com>
4872
4873         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4874         %s/pulongest for TYPE_LENGTH instead of %d in format
4875         strings.
4876         * ada-typerint.c (ada_print_type): Likewise.
4877         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4878         * compile/compile-c-support.c (generate_register_struct): Likewise.
4879         * gdbtypes.c (recursive_dump_type): Likewise.
4880         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4881         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4882         instead of %d in format strings.
4883         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4884         to std::min to ULONGEST.
4885         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4886         instead of %d in format strings.
4887         * tracepoint.c (info_scope_command): Likewise.
4888         * typeprint.c (print_offset_data::update)
4889         (print_offset_data::finish): Likewise.
4890         * xtensa-tdep.c (xtensa_store_return_value)
4891         (xtensa_push_dummy_call): Likewise.
4892
4893 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4894
4895         * windows-nat.c (display_selector): Fixed format specifications
4896         for 64-bit Cygwin.
4897
4898 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4899
4900         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4901
4902 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4903
4904         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4905         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4906         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4907         (nios2_linux_init_abi): Install it.
4908
4909 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4910
4911         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4912
4913 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4914
4915         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4916
4917 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4918             Tom Tromey  <tromey@adacore.com>
4919
4920         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4921
4922 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4923
4924         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4925         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4926         method to compute the bounds of range types. Also print "[evaluated]"
4927         if the bounds' values come from a dynamic evaluation.
4928
4929 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4930
4931         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4932         whitespace when pretty printing is on.
4933
4934 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4935
4936         * ppc-linux-nat.c: Add include.
4937
4938 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4939
4940         * NEWS: Mention AArch64 Pointer Authentication.
4941
4942 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4943
4944         * arm-linux-nat.c: Add include.
4945
4946 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4947
4948         * source-cache.c (source_cache::get_source_lines): Re-read
4949         fullname after calling open_source_file.
4950
4951 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4952
4953         * NEWS: Mention TLS support for FreeBSD.
4954
4955 2019-03-25  Tom Tromey  <tromey@adacore.com>
4956
4957         * minsyms.c (BUNCH_SIZE): Update comment.
4958         (~minimal_symbol_reader): Remove old comment.
4959         (compact_minimal_symbols): Update comment.
4960         (minimal_symbol_reader::install): Remove old comment.  Update
4961         other comments.
4962
4963 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4964
4965         * s390-linux-nat.c: Add include.
4966
4967 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4968
4969         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4970         Call linux_get_hwcap.
4971         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4972         Likewise.
4973         (aarch64_linux_get_hwcap): Remove function.
4974         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4975         declaration.
4976         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4977         linux_get_hwcap.
4978         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4979         * linux-tdep.c (linux_get_hwcap): Add function.
4980         (linux_get_hwcap2): Likewise.
4981         * linux-tdep.h (linux_get_hwcap): Add declaration.
4982         (linux_get_hwcap2): Likewise.
4983         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4984         (ppc_linux_get_hwcap2): Likewise.
4985         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4986         linux_get_hwcap.
4987         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4988         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4989         (ppc_linux_nat_target::read_description): Likewise.
4990         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4991         * s390-linux-nat.c: Likewise.
4992         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4993
4994 2019-03-24  Tom Tromey  <tom@tromey.com>
4995
4996         * ada-lang.c (standard_lookup): Simplify initialization.
4997         (ada_lookup_symbol_nonlocal): Simplify return.
4998         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4999         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5000         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5001         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5002         initialization.
5003         * solib.c (solib_global_lookup): Simplify.
5004         * symtab.c (null_block_symbol): Remove.
5005         (symbol_cache_lookup): Simplify returns.
5006         (lookup_language_this): Simplify returns.
5007         (lookup_symbol_aux): Simplify return.
5008         (lookup_local_symbol): Simplify returns.
5009         (lookup_global_symbol_from_objfile): Simplify return.
5010         (lookup_symbol_in_objfile_symtabs)
5011         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5012         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5013         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5014         * cp-namespace.c (cp_lookup_bare_symbol)
5015         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5016         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5017         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5018         (cp_lookup_symbol_via_imports): Simplify initialization.
5019         (find_symbol_in_baseclass): Likewise.
5020         * symtab.h (null_block_symbol): Remove.
5021         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5022         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5023         (d_lookup_symbol_module): Likewise.
5024         (find_symbol_in_baseclass): Simplify initialization.
5025
5026 2019-03-24  Tom Tromey  <tom@tromey.com>
5027
5028         * expression.h: Don't include symtab.h.
5029         (struct block): Forward declare.
5030
5031 2019-03-24  Tom Tromey  <tom@tromey.com>
5032
5033         * c-exp.y (typebase): Remove casts.
5034         * gdbtypes.c (lookup_unsigned_typename, )
5035         (lookup_signed_typename): Remove cast.
5036         * eval.c (parse_to_comma_and_eval): Remove cast.
5037         * parse.c (write_dollar_variable): Remove cast.
5038         * block.h (struct block) <superblock>: Now const.
5039         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5040         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5041         (map_block): Make "block" const.
5042         * symfile.h (struct quick_symbol_functions)
5043         <map_matching_symbols>: Constify block argument to "callback".
5044         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5045         const.
5046         (find_pc_sect_compunit_symtab): Make "b" const.
5047         (find_symbol_at_address): Likewise.
5048         (search_symbols): Likewise.
5049         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5050         (dw2_debug_names_lookup_symbol): Likewise.
5051         (dw2_map_matching_symbols): Update.
5052         * p-valprint.c (pascal_val_print): Remove "block".
5053         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5054         (aux_add_nonlocal_symbols): Make "block" const.
5055         (resolve_subexp): Remove cast.
5056         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5057         const.
5058         (iterate_over_file_blocks): Likewise.
5059         * f-exp.y (%union) <bval>: Remove.
5060         * coffread.c (patch_opaque_types): Make "b" const.
5061         * spu-tdep.c (spu_catch_start): Make "block" const.
5062         * c-valprint.c (print_unpacked_pointer): Remove "block".
5063         * symmisc.c (dump_symtab_1): Make "b" const.
5064         (block_depth): Make "block" const.
5065         * d-exp.y (%union) <bval>: Remove.
5066         * cp-support.h (cp_lookup_rtti_type): Update.
5067         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5068         * psymtab.c (psym_lookup_symbol): Make "block" const.
5069         (maintenance_check_psymtabs): Make "b" const.
5070         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5071         (enumerate_locals, enumerate_args): Update.
5072         * python/py-symtab.c (stpy_global_block): Make "block" const.
5073         (stpy_static_block): Likewise.
5074         * inline-frame.c (block_starting_point_at): Make "new_block"
5075         const.
5076         * block.c (find_block_in_blockvector): Make return type const.
5077         (blockvector_for_pc_sect): Make "b" const.
5078         (find_block_in_blockvector): Make "b" const.
5079
5080 2019-03-23  Tom Tromey  <tom@tromey.com>
5081
5082         * varobj.c (varobj_create): Update.
5083         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5084         * printcmd.c (display_command, do_one_display): Don't reset
5085         innermost_block.
5086         * parser-defs.h (enum innermost_block_tracker_type): Move to
5087         expression.h.
5088         (innermost_block): Update comment.
5089         * parse.c (parse_exp_1): Add tracker_types parameter.
5090         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5091         tracker_types parameter.  Reset innermost_block.
5092         (parse_exp_in_context): Remove.
5093         (parse_expression_for_completion): Update.
5094         * objfiles.c (~objfile): Don't reset expression_context_block or
5095         innermost_block.
5096         * expression.h (enum innermost_block_tracker_type): Move from
5097         parser-defs.h.
5098         (parse_exp_1): Add tracker_types parameter.
5099         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5100         reset innermost_block.
5101
5102 2019-03-23  Tom Tromey  <tom@tromey.com>
5103
5104         * objfiles.h: Include bcache.h.
5105
5106 2019-03-23  Tom Tromey  <tom@tromey.com>
5107
5108         * linespec.c (get_current_search_block): Use
5109         scoped_restore_current_language.
5110         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5111
5112 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5113             Jiong Wang  <jiong.wang@arm.com>
5114
5115         * aarch64-linux-tdep.c
5116         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5117         section.
5118         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5119
5120 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5121             Jiong Wang  <jiong.wang@arm.com>
5122
5123         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5124         instructions.
5125         (aarch64_analyze_prologue_test): Add PACIASP test.
5126         (aarch64_prologue_prev_register): Unmask PC value.
5127
5128 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5129             Jiong Wang  <jiong.wang@arm.com>
5130
5131         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5132         (aarch64_dwarf2_prev_register): Unmask PC value.
5133         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5134         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5135         DW_CFA_AARCH64_negate_ra_state.
5136         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5137
5138 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5139             Jiong Wang  <jiong.wang@arm.com>
5140
5141         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5142         registers.
5143         (aarch64_pseudo_register_name): Likewise.
5144         (aarch64_pseudo_register_type): Likewise.
5145         (aarch64_pseudo_register_reggroup_p): Likewise.
5146         (aarch64_gdbarch_init): Add pauth registers.
5147         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5148         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5149         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5150         (struct gdbarch_tdep): Add regnum for ra_state.
5151
5152 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5153             Jiong Wang  <jiong.wang@arm.com>
5154
5155         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5156
5157 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5158             Jiong Wang  <jiong.wang@arm.com>
5159
5160         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5161         function.
5162         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5163         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5164         (aarch64_gdbarch_init): Add puth registers.
5165         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5166         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5167         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5168
5169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5170             Jiong Wang  <jiong.wang@arm.com>
5171
5172         * aarch64-linux-nat.c
5173         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5174         * aarch64-linux-tdep.c
5175         (aarch64_linux_core_read_description): Likewise.
5176         (aarch64_linux_get_hwcap): New function.
5177         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5178         (aarch64_linux_get_hwcap): New declaration.
5179
5180 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5181             Jiong Wang  <jiong.wang@arm.com>
5182
5183         * aarch64-linux-nat.c
5184         (aarch64_linux_nat_target::read_description): Add pauth param.
5185         * aarch64-linux-tdep.c
5186         (aarch64_linux_core_read_description): Likewise.
5187         * aarch64-tdep.c (struct target_desc): Add in pauth.
5188         (aarch64_read_description): Add pauth param.
5189         (aarch64_gdbarch_init): Likewise.
5190         * aarch64-tdep.h (aarch64_read_description): Likewise.
5191         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5192         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5193         * features/Makefile: Add new files.
5194         * features/aarch64-pauth.c: New file.
5195         * features/aarch64-pauth.xml: New file.
5196
5197 2019-03-20  Tom Tromey  <tromey@adacore.com>
5198
5199         * infrun.c (handle_inferior_event): Rename from
5200         handle_inferior_event_1.  Create a scoped_value_mark.
5201         (handle_inferior_event): Remove.
5202
5203 2019-03-19  Tom Tromey  <tromey@adacore.com>
5204
5205         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5206         * infrun.h (print_stop_event): Add "displays" parameter.
5207         * infrun.c (print_stop_event): Add "displays" parameter.
5208
5209 2019-03-19  Pedro Alves  <palves@redhat.com>
5210
5211         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5212         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5213         to -1.  Fix TABs vs spaces.
5214         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5215         * tui/tui-out.h (tui_ui_out) Add intro comments.
5216         <m_line, m_start_of_line>: In-class initialize, and add describing
5217         comment.
5218
5219 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5220
5221         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5222         variable names.
5223         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5224
5225 2019-03-18  Pedro Alves  <palves@redhat.com>
5226             Eli Zaretskii <eliz@gnu.org>
5227
5228         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5229         m_line and m_start_of_line.
5230
5231 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5232
5233         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5234         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5235         it returns a newline.  This fixes a regression in TU mode, whereby
5236         the next line is output on the same screen line as the user input.
5237
5238 2019-03-18  Tom Tromey  <tromey@adacore.com>
5239
5240         * minsyms.c (minimal_symbol_reader::install): Remove call to
5241         obstack_blank.
5242
5243 2019-03-18  Pedro Alves  <palves@redhat.com>
5244
5245         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5246         New globals.
5247         (apply_style): New, factored out from ...
5248         (apply_ansi_escape): ... this.  Handle reverse video mode.
5249         (tui_set_reverse_mode): New function.
5250         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5251         * tui/tui-winsource.c (tui_show_source_line): Use
5252         tui_set_reverse_mode instead of setting A_STANDOUT.
5253         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5254         New setter methods.
5255
5256 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5257
5258         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5259         Handle tabs.
5260
5261 2019-03-18  Tom Tromey  <tromey@adacore.com>
5262
5263         * ada-lang.c (empty_array): Add "high" parameter.
5264         (ada_evaluate_subexp): Update.
5265
5266 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5267
5268         * unittests/string_view-selftests.c: Define
5269         _initialize_string_view_selftests unconditionally.
5270
5271 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5272
5273         PR gdb/24350
5274         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5275
5276 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5277
5278         PR gdb/24351
5279         * windows-nat.c (display_selector): Fix format specifiers.
5280
5281 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5282
5283         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5284         tui_refill_source_window instead of tui_refresh_win, to update the
5285         current execution line.  This fixes redisplay of the current line
5286         when stepping through the code with "next" or "step".
5287
5288 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5289
5290         * source-cache.c (source_cache::get_source_lines): Call
5291         find_source_lines to initialize s->nlines.  This fixes vertical
5292         scrolling of TUI source window when the DOWN arrow is pressed.
5293
5294 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5295
5296         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5297         linux-thread-db.c (_initialize_thread_db): Likewise.
5298
5299 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5300
5301         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5302         wclrtoeol in tui_show_source_line".  This reverts changes made in
5303         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5304
5305 2019-03-15  Tom Tromey  <tom@tromey.com>
5306
5307         * symtab.h (struct minimal_symbol): Derive from
5308         general_symbol_info.
5309         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5310         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5311         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5312         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5313         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5314         (MSYMBOL_SEARCH_NAME): Update.
5315         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5316         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5317         * minsyms.c (minimal_symbol_reader::record_full): Update.
5318
5319 2019-03-15  Tom Tromey  <tom@tromey.com>
5320
5321         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5322
5323 2019-03-15  Tom Tromey  <tom@tromey.com>
5324
5325         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5326         unique_xmalloc_ptr.
5327         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5328         Update.
5329         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5330         (build_minimal_symbol_hash_tables)
5331         (minimal_symbol_reader::install): Update.
5332
5333 2019-03-15  Tom Tromey  <tom@tromey.com>
5334
5335         * symtab.c (create_demangled_names_hash): Update.
5336         (symbol_set_names): Update.
5337         * objfiles.h (struct objfile_per_bfd_storage)
5338         <demangled_names_hash>: Now an htab_up.
5339         * objfiles.c (objfile_per_bfd_storage): Simplify.
5340
5341 2019-03-15  Tom Tromey  <tom@tromey.com>
5342
5343         * objfiles.h (struct objfile_per_bfd_storage): Declare
5344         destructor.
5345         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5346         New.
5347         (get_objfile_bfd_data): Use new.  Don't initialize
5348         language_of_main.
5349         (free_objfile_per_bfd_storage): Remove.
5350         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5351
5352 2019-03-15  Tom Tromey  <tom@tromey.com>
5353
5354         * symfile.c (reread_symbols): Update.
5355         * objfiles.c (objfile::objfile): Update.
5356         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5357         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5358         comment.
5359         (minimal_symbol_reader::install): Update.
5360         (terminate_minimal_symbol_table): Remove.
5361         * jit.c (jit_object_close_impl): Update.
5362
5363 2019-03-15  Tom Tromey  <tom@tromey.com>
5364
5365         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5366         initializations.
5367
5368 2019-03-15  Tom Tromey  <tom@tromey.com>
5369
5370         * objfiles.h (struct objfile_per_bfd_storage)
5371         <demangled_hash_languages>: Now a bitset.
5372         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5373         (lookup_minimal_symbol): Update.
5374
5375 2019-03-15  Tom Tromey  <tom@tromey.com>
5376
5377         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5378         Don't return the symbol.
5379         * coffread.c (record_minimal_symbol): Use record_full.
5380
5381 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5382
5383         The MS-Windows port of ncurses fails to switch to a color pair if
5384         one or both of the colors are the implicit default colors.  This
5385         change records the default colors when TUI is initialized, and
5386         then specifies them explicitly when a color pair uses the default
5387         colors.  This allows color styling in TUI mode on MS-Windows.
5388
5389         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5390         ncurses_norm_attr.
5391         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5392         colors in ncurses_norm_attr.
5393         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5394         "none", replace it with the default color recorded in
5395         ncurses_norm_attr.
5396
5397 2019-03-14  Tom Tromey  <tromey@adacore.com>
5398
5399         * source-cache.h (class source_cache) <get_source_lines>: Return
5400         std::string.
5401         * source-cache.c (source_cache::extract_lines): Handle case where
5402         first_pos==npos.  Return std::string.
5403         (source_cache::get_source_lines): Update.
5404
5405 2019-03-14  Tom Tromey  <tromey@adacore.com>
5406
5407         * NEWS: Add item for "style sources" commands.
5408         * source-cache.c (source_cache::get_source_lines): Check
5409         source_styling.
5410         * cli/cli-style.c (source_styling): New global.
5411         (_initialize_cli_style): Add "style sources" commands.
5412         (show_style_sources): New function.
5413         * cli/cli-style.h (source_styling): Declare.
5414
5415 2019-03-14  Pedro Alves  <palves@redhat.com>
5416             Tom Tromey  <tromey@adacore.com>
5417
5418         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5419         * tui/tui-winsource.c (tui_refill_source_window): New function,
5420         from...
5421         (tui_horizontal_source_scroll): ... here.  Move some logic.
5422         * cli/cli-style.c (set_style_enabled): Notify new observable.
5423         * tui/tui-hooks.c (tui_redisplay_source): New function.
5424         (tui_attach_detach_observers): Attach or detach
5425         tui_redisplay_source.
5426         * observable.h (source_styling_changed): New observable.
5427         * observable.c: Define source_styling_changed observable.
5428
5429 2019-03-13  Tom Tromey  <tromey@adacore.com>
5430
5431         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5432         (i386_gnu_nat_target::store_registers): Update.
5433         * target-debug.h (target_debug_print_std_string): New macro.
5434         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5435         * windows-tdep.c (display_one_tib): Update.
5436         * tui/tui-stack.c (tui_make_status_line): Update.
5437         * top.c (print_inferior_quit_action): Update.
5438         * thread.c (thr_try_catch_cmd): Update.
5439         (add_thread_with_info): Update.
5440         (thread_target_id_str): Update.
5441         (thr_try_catch_cmd): Update.
5442         (thread_command): Update.
5443         (thread_find_command): Update.
5444         * record-btrace.c (record_btrace_target::info_record)
5445         (record_btrace_resume_thread, record_btrace_target::resume)
5446         (record_btrace_cancel_resume, record_btrace_step_thread)
5447         (record_btrace_target::wait, record_btrace_target::wait)
5448         (record_btrace_target::wait, record_btrace_target::stop): Update.
5449         * progspace.c (print_program_space): Update.
5450         * process-stratum-target.c
5451         (process_stratum_target::thread_address_space): Update.
5452         * linux-fork.c (linux_fork_mourn_inferior)
5453         (detach_checkpoint_command, info_checkpoints_command)
5454         (linux_fork_context): Update.
5455         (linux_fork_detach): Update.
5456         (class scoped_switch_fork_info): Update.
5457         (delete_checkpoint_command): Update.
5458         * infrun.c (follow_fork_inferior): Update.
5459         (follow_fork_inferior): Update.
5460         (proceed_after_vfork_done): Update.
5461         (handle_vfork_child_exec_or_exit): Update.
5462         (follow_exec): Update.
5463         (displaced_step_prepare_throw): Update.
5464         (displaced_step_restore): Update.
5465         (start_step_over): Update.
5466         (resume_1): Update.
5467         (clear_proceed_status_thread): Update.
5468         (proceed): Update.
5469         (print_target_wait_results): Update.
5470         (do_target_wait): Update.
5471         (context_switch): Update.
5472         (stop_all_threads): Update.
5473         (restart_threads): Update.
5474         (finish_step_over): Update.
5475         (handle_signal_stop): Update.
5476         (switch_back_to_stepped_thread): Update.
5477         (keep_going_pass_signal): Update.
5478         (print_exited_reason): Update.
5479         (normal_stop): Update.
5480         * inferior.c (inferior_pid_to_str): Change return type.
5481         (print_selected_inferior): Update.
5482         (add_inferior): Update.
5483         (detach_inferior): Update.
5484         * dummy-frame.c (fprint_dummy_frames): Update.
5485         * dcache.c (dcache_info_1): Update.
5486         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5487         (btrace_fetch, btrace_clear): Update.
5488         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5489         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5490         type.
5491         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5492         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5493         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5494         * gdbarch.c, gdbarch.h: Rebuild.
5495         * gdbarch.sh (core_pid_to_str): Change return type.
5496         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5497         return type.
5498         (windows_nat_target::pid_to_str): Change return type.
5499         (windows_delete_thread): Update.
5500         (windows_nat_target::attach): Update.
5501         (windows_nat_target::files_info): Update.
5502         * target-delegates.c: Rebuild.
5503         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5504         return type.
5505         (sol_thread_target::pid_to_str): Change return type.
5506         * remote.c (class remote_target) <pid_to_str>: Change return
5507         type.
5508         (remote_target::pid_to_str): Change return type.
5509         (extended_remote_target::attach, remote_target::remote_stop_ns)
5510         (remote_target::remote_notif_remove_queued_reply)
5511         (remote_target::push_stop_reply, remote_target::disable_btrace):
5512         Update.
5513         (extended_remote_target::attach): Update.
5514         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5515         type.
5516         (gdbsim_target::pid_to_str): Change return type.
5517         * ravenscar-thread.c (struct ravenscar_thread_target)
5518         <pid_to_str>: Change return type.
5519         (ravenscar_thread_target::pid_to_str): Change return type.
5520         * procfs.c (class procfs_target) <pid_to_str>: Change return
5521         type.
5522         (procfs_target::pid_to_str): Change return type.
5523         (procfs_target::attach): Update.
5524         (procfs_target::detach): Update.
5525         (procfs_target::fetch_registers): Update.
5526         (procfs_target::store_registers): Update.
5527         (procfs_target::wait): Update.
5528         (procfs_target::files_info): Update.
5529         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5530         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5531         return type.
5532         (nto_procfs_target::pid_to_str): Change return type.
5533         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5534         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5535         return type.
5536         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5537         (exit_lwp): Update.
5538         (attach_proc_task_lwp_callback, get_detach_signal)
5539         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5540         (linux_nat_target::resume, wait_lwp, stop_callback)
5541         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5542         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5543         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5544         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5545         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5546         type.
5547         (inf_ptrace_target::attach): Update.
5548         (inf_ptrace_target::files_info): Update.
5549         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5550         type.
5551         (go32_nat_target::pid_to_str): Change return type.
5552         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5553         (gnu_nat_target::wait): Update.
5554         (gnu_nat_target::wait): Update.
5555         (gnu_nat_target::resume): Update.
5556         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5557         (fbsd_nat_target::wait): Update.
5558         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5559         type.
5560         (darwin_nat_target::attach): Update.
5561         * corelow.c (class core_target) <pid_to_str>: Change return type.
5562         (core_target::pid_to_str): Change return type.
5563         * target.c (normal_pid_to_str): Change return type.
5564         (default_pid_to_str): Likewise.
5565         (target_pid_to_str): Change return type.
5566         (target_translate_tls_address): Update.
5567         (target_announce_detach): Update.
5568         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5569         return type.
5570         (bsd_uthread_target::pid_to_str): Change return type.
5571         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5572         type.
5573         (bsd_kvm_target::pid_to_str): Change return type.
5574         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5575         return type.
5576         (aix_thread_target::pid_to_str): Change return type.
5577         * target.h (struct target_ops) <pid_to_str>: Change return type.
5578         (target_pid_to_str, normal_pid_to_str): Likewise.
5579         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5580         type.
5581         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5582         type.
5583         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5584         return type.
5585         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5586         type.
5587         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5588         type.
5589         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5590         return type.
5591
5592 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5593
5594         * NEWS: Mention that the new default MI version is 3.  Mention
5595         changes to the output of commands and events that deal with
5596         multi-location breakpoints.
5597         * breakpoint.c: Include "mi/mi-out.h".
5598         (print_one_breakpoint): Change output syntax if using MI version
5599         >= 3.
5600         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5601         New.
5602         (mi_multi_location_breakpoint_output_fixed): New.
5603         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5604         (mi_cmd_fix_multi_location_breakpoint_output): New.
5605         (mi_multi_location_breakpoint_output_fixed): New.
5606         * mi/mi-cmds.c (mi_cmds): Register command
5607         -fix-multi-location-breakpoint-output.
5608         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5609         interpreter "mi".
5610
5611 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5612
5613         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5614         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5615         instantiate mi_ui_out based on interpreter name.
5616         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5617         * mi/mi-main.c (mi_load_progress): Likewise.
5618
5619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5620
5621         * NEWS: Combine separate "New targets" sections for 8.3.
5622
5623 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5624
5625         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5626         (ppcfbsd_init_abi): Install gdbarch
5627         "fetch_tls_load_module_address" and "get_thread_local_address"
5628         methods.
5629
5630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5631
5632         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5633         (riscv_fbsd_init_abi): Install gdbarch
5634         "fetch_tls_load_module_address" and "get_thread_local_address"
5635         methods.
5636
5637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5638
5639         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5640         (i386fbsd_init_abi): Install gdbarch
5641         "fetch_tls_load_module_address" and "get_thread_local_address"
5642         methods.
5643
5644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5645
5646         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5647         (amd64fbsd_init_abi): Install gdbarch
5648         "fetch_tls_load_module_address" and "get_thread_local_address"
5649         methods.
5650
5651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5652
5653         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5654         (struct fbsd_pspace_data): New type.
5655         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5656         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5657         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5658         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5659         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5660
5661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5662
5663         * gdbtypes.c (lookup_struct_elt): New function.
5664         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5665         * gdbtypes.h (struct struct_elt): New type.
5666         (lookup_struct_elt): New prototype.
5667
5668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5669
5670         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5671         remove disabled code block.
5672
5673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5674
5675         * gdbarch.sh (get_thread_local_address): New method.
5676         * gdbarch.h, gdbarch.c: Regenerate.
5677         * target.c (target_translate_tls_address): Use
5678         gdbarch_get_thread_local_address if present instead of
5679         target::get_thread_local_address.
5680
5681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5682
5683         * target.h (target::get_thread_local_address): Update comment.
5684
5685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5686
5687         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5688         objfile->separate_debug_objfile_backlink if not NULL.
5689
5690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5691
5692         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5693         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5694         (amd64bsd_store_inferior_registers): Likewise.
5695         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5696         Enable segment base registers.
5697         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5698         PT_GETFSBASE and PT_GETGSBASE.
5699         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5700         PT_SETGSBASE.
5701         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5702         segment base registers.
5703         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5704
5705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5706
5707         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5708         Update calls to i386_target_description to add 'segments'
5709         parameter.
5710         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5711         add segment base registers.
5712         * arch/i386.c (i386_create_target_description): Add 'segments'
5713         parameter to enable segment base registers.
5714         * arch/i386.h (i386_create_target_description): Likewise.
5715         * features/i386/32bit-segments.xml: New file.
5716         * features/i386/32bit-segments.c: Generate.
5717         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5718         call to i386_target_description to add 'segments' parameter.
5719         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5720         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5721         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5722         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5723         if feature is present.
5724         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5725         Add 'segments' parameter to call to i386_target_description.
5726         (i386_target_description): Add 'segments' parameter to enable
5727         segment base registers.
5728         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5729         to call to i386_target_description.
5730         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5731         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5732         Define I386_NUM_REGS.
5733         (i386_target_description): Add 'segments' parameter to enable
5734         segment base registers.
5735
5736 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5737
5738         PR/24325
5739         * source-cache.c: #undef open and close, to avoid unresolved
5740         externals during linking.
5741
5742 2019-03-12  Tom Tromey  <tromey@adacore.com>
5743
5744         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5745         const.  Add initializers.
5746         (_initialize_remote): Don't initialize ptid globals.
5747
5748 2019-03-12  Pedro Alves  <palves@redhat.com>
5749
5750         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5751
5752 2019-03-12  Pedro Alves  <palves@redhat.com>
5753
5754         * cp-name-parser.y (main): Remove unused 'len' variable.
5755
5756 2019-03-12  Tom Tromey  <tromey@adacore.com>
5757
5758         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5759         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5760
5761 2019-03-12  Tom Tromey  <tromey@adacore.com>
5762
5763         * linux-nat.c (iterate_over_lwps): Update.
5764         (stop_callback): Remove parameter.
5765         (stop_wait_callback, detach_callback, resume_set_callback)
5766         (select_singlestep_lwp_callback, set_ignore_sigint)
5767         (status_callback, resumed_callback, resume_clear_callback)
5768         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5769         data parameter.
5770         (linux_nat_target::detach, linux_nat_target::resume)
5771         (linux_stop_and_wait_all_lwps, select_event_lwp)
5772         (linux_nat_filter_event, linux_nat_wait_1)
5773         (linux_nat_target::kill, linux_nat_target::stop)
5774         (linux_nat_target::stop): Update.
5775         (linux_nat_resume_callback): Change type.
5776         (resume_stopped_resumed_lwps, count_events_callback)
5777         (select_event_lwp_callback): Likewise.
5778         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5779         * arm-linux-nat.c (struct update_registers_data): Remove.
5780         (update_registers_callback): Change type.
5781         (arm_linux_insert_hw_breakpoint1): Update.
5782         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5783         parameter.
5784         (x86_linux_dr_set_addr): Update.
5785         (x86_linux_dr_set_control): Update.
5786         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5787         (iterate_over_lwps): Use gdb::function_view.
5788         * nat/aarch64-linux-hw-point.c (struct
5789         aarch64_dr_update_callback_param): Remove.
5790         (debug_reg_change_callback): Change type.
5791         (aarch64_notify_debug_reg_change): Update.
5792         * s390-linux-nat.c (s390_refresh_per_info): Update.
5793
5794 2019-03-11  Tom Tromey  <tromey@adacore.com>
5795
5796         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5797         redundant assignment to "this_cu".
5798
5799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5800
5801         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5802
5803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5804
5805         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5806         from...
5807         (rank_one_type): ... this.
5808
5809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5810
5811         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5812         from...
5813         (rank_one_type): ... this.
5814
5815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5816
5817         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5818         from...
5819         (rank_one_type): ... this.
5820
5821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5822
5823         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5824         from...
5825         (rank_one_type): ... this.
5826
5827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5828
5829         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5830         from...
5831         (rank_one_type): ... this.
5832
5833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5834
5835         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5836         from...
5837         (rank_one_type): ... this.
5838
5839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5840
5841         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5842         from...
5843         (rank_one_type): ... this.
5844
5845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5846
5847         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5848         from...
5849         (rank_one_type): ... this.
5850
5851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5852
5853         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5854         from...
5855         (rank_one_type): ... this.
5856
5857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5858
5859         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5860         from...
5861         (rank_one_type): ... this.
5862
5863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5864
5865         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5866         from...
5867         (rank_one_type): ... this.
5868
5869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5870
5871         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5872         from...
5873         (rank_one_type): ... this.
5874
5875 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5876
5877         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5878         inferior-events' shows the example events.
5879
5880 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5881
5882         Support styling on native MS-Windows console
5883
5884         PR/24315
5885         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5886         on MS-Windows if $TERM is not defined.
5887
5888         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5889
5890         * posix-hdep.c (gdb_console_fputs):
5891         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5892         functions.
5893         * ui-file.h (gdb_console_fputs): Add prototype.
5894
5895         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5896         back to fputs only if the former returns zero.
5897
5898 2019-03-07  Tom Tromey  <tom@tromey.com>
5899
5900         * symmisc.c (print_symbol_bcache_statistics): Update.
5901         (print_objfile_statistics): Update.
5902         * symfile.c (allocate_symtab): Update.
5903         * stabsread.c: Don't include bcache.h.
5904         * psymtab.h (struct psymbol_bcache): Don't declare.
5905         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5906         (psymbol_bcache_init, psymbol_bcache_free)
5907         (psymbol_bcache_get_bcache): Don't declare.
5908         * psymtab.c (struct psymbol_bcache): Remove.
5909         (psymtab_storage::psymtab_storage): Update.
5910         (psymtab_storage::~psymtab_storage): Update.
5911         (psymbol_bcache_init, psymbol_bcache_free)
5912         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5913         (add_psymbol_to_bcache): Update.
5914         (allocate_psymtab): Update.
5915         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5916         macro_cache>: No longer pointers.
5917         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5918         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5919         * macrotab.c (macro_bcache): Update.
5920         * macroexp.c: Don't include bcache.h.
5921         * gdbtypes.c (check_types_worklist): Update.
5922         (types_deeply_equal): Remove TRY/CATCH.  Update.
5923         * elfread.c (elf_symtab_read): Update.
5924         * dwarf2read.c: Don't include bcache.h.
5925         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5926         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5927         (print_bcache_statistics, bcache_memory_used): Don't declare.
5928         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5929         methods.  Rename all data members.
5930         * bcache.c (struct bcache): Move to bcache.h.
5931         (bcache::expand_hash_table): Rename from expand_hash_table.
5932         (bcache): Remove.
5933         (bcache::insert): Rename from bcache_full.
5934         (bcache::compare): Rename from bcache_compare.
5935         (bcache_xmalloc): Remove.
5936         (bcache::~bcache): Rename from bcache_xfree.
5937         (bcache::print_statistics): Rename from print_bcache_statistics.
5938         (bcache::memory_used): Rename from bcache_memory_used.
5939
5940 2019-03-07  Pedro Alves  <palves@redhat.com>
5941
5942         * infrun.c (normal_stop): Also check for
5943         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5944
5945 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * f-lang.c (value_from_host_double): Moved to...
5948         * value.c (value_from_host_double): ...here.
5949         * value.h (value_from_host_double): Declare.
5950         * guile/scm-math.c (vlscm_convert_typed_number): Use
5951         value_from_host_double.
5952         (vlscm_convert_number): Likewise.
5953         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5954         * python/py-value.c (convert_value_from_python): Likewise.
5955
5956 2019-03-06  Tom Tromey  <tom@tromey.com>
5957
5958         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5959
5960 2019-03-06  Tom Tromey  <tom@tromey.com>
5961
5962         * utils.h (free_current_contents): Don't declare.
5963         * utils.c (free_current_contents): Remove.
5964
5965 2019-03-06  Tom Tromey  <tom@tromey.com>
5966
5967         * top.c (quit_force): Update.
5968         * main.c (captured_command_loop): Update.
5969         * common/new-op.c (operator new): Update.
5970         * common/common-exceptions.c (struct catcher)
5971         <save_cleanup_chain>: Remove member.
5972         (exceptions_state_mc_init): Update.
5973         (exception_try_scope_entry): Return nullptr.
5974         (exception_try_scope_exit, exception_rethrow)
5975         (throw_exception_sjlj, throw_exception_cxx): Update.
5976         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5977         (all_cleanups, do_cleanups, discard_cleanups)
5978         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5979         (restore_cleanups, restore_final_cleanups): Don't declare.
5980         (do_final_cleanups): Remove parameter.
5981         * common/cleanups.c (cleanup_chain, make_cleanup)
5982         (make_cleanup_dtor, all_cleanups, do_cleanups)
5983         (discard_my_cleanups, discard_cleanups)
5984         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5985         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5986         (null_cleanup): Remove.
5987         (do_final_cleanups): Remove parameter.
5988
5989 2019-03-06  Tom Tromey  <tom@tromey.com>
5990
5991         * remote.c (remote_target::remote_parse_stop_reply): Use
5992         unique_xmalloc_ptr.
5993
5994 2019-03-06  Tom Tromey  <tom@tromey.com>
5995
5996         * stabsread.c (struct stabs_field_info): Rename from field_info.
5997         <list, fnlist>: Add initializers.
5998         <obstack>: New member.
5999         (read_member_functions, read_struct_fields, read_baseclasses):
6000         Allocate on obstack.  Don't use cleanups.
6001         (read_one_struct_field, read_member_functions, read_struct_fields)
6002         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6003         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6004         (read_struct_type): Update.
6005
6006 2019-03-06  Tom Tromey  <tom@tromey.com>
6007
6008         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6009         * common/filestuff.h (make_cleanup_close): Don't declare.
6010         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6011         Remove.
6012
6013 2019-03-06  Tom Tromey  <tom@tromey.com>
6014
6015         * solib-aix.c: Use make_scope_exit.
6016
6017 2019-03-06  Tom Tromey  <tom@tromey.com>
6018
6019         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6020         Use make_scope_exit.
6021
6022 2019-03-06  Tom Tromey  <tom@tromey.com>
6023
6024         * solib-svr4.c (disable_probes_interface): Remove parameter.
6025         (svr4_handle_solib_event): Use make_scope_exit.
6026
6027 2019-03-06  Tom Tromey  <tom@tromey.com>
6028
6029         * remote.c (struct stop_reply_deleter): Remove.
6030         (stop_reply_up): Update.
6031         (struct stop_reply): Derive from notif_event.  Don't typedef.
6032         <regcache>: Now a std::vector.
6033         (stop_reply_xfree): Remove.
6034         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6035         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6036         (remote_target::discard_pending_stop_replies): Use delete.
6037         (remote_target::remote_parse_stop_reply): Update.
6038         (remote_target::process_stop_reply): Update.
6039         * remote-notif.h (struct notif_event): Add virtual destructor.
6040         Remove "dtr" member.
6041         (struct notif_client) <alloc_event>: Return a unique_ptr.
6042         (notif_event_xfree): Don't declare.
6043         (notif_event_up): New typedef.
6044         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6045         (notif_event_xfree, do_notif_event_xfree): Remove.
6046         (remote_notif_state_xfree): Update.
6047
6048 2019-03-06  Tom Tromey  <tom@tromey.com>
6049
6050         * infrun.c (displaced_step_clear_cleanup): Now a
6051         forward_scope_exit type.
6052         (displaced_step_prepare_throw): Update.
6053         (displaced_step_fixup): Update.
6054
6055 2019-03-06  Tom Tromey  <tom@tromey.com>
6056
6057         * inferior.h (class inferior): Update comment.
6058         * gdbthread.h (class thread_info): Update comment.
6059
6060 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6061             Tom Tromey  <tom@tromey.com>
6062
6063         * stabsread.h (struct stab_section_list): Remove.
6064         (coffstab_build_psymtabs): Update.
6065         * dbxread.c (symbuf_sections): Now a std::vector.
6066         (sect_idx): New global.
6067         (fill_symbuf): Update.
6068         (coffstab_build_psymtabs): Change type of stabsects parameter.
6069         Update.
6070         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6071         std::vector.
6072         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6073         (coff_locate_sections): Update.
6074         (coff_symfile_read): Remove cleanups.  Update.
6075         (init_stringtab): Add storage parameter.
6076         (free_stringtab, free_stringtab_cleanup): Remove.
6077         (init_lineno): Add storage parameter.
6078         (free_linetab, free_linetab_cleanup): Remove.
6079
6080 2019-03-06  Pedro Alves  <palves@redhat.com>
6081
6082         * linux-fork.c (fork_info::clobber_regs): Delete.
6083         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6084         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6085         comment.  Adjust.
6086         (scoped_switch_fork_info::scoped_switch_fork_info)
6087         (checkpoint_command, linux_fork_context): Adjust
6088         fork_save_infrun_state calls.
6089
6090 2019-03-06  Pedro Alves  <palves@redhat.com>
6091
6092         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6093         (inf_has_multiple_threads): Return 'bool' and rewrite using
6094         inferior_info::threads().
6095
6096 2019-03-06  Pedro Alves  <palves@redhat.com>
6097
6098         * linux-fork.c: Include <list>.
6099         (fork_list): Now a std::list instance.
6100         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6101         (forks_exist_p, find_last_fork): Adjust.
6102         (new_fork): Delete.
6103         (one_fork_p): New.
6104         (add_fork): Adjust.
6105         (free_fork): Delete, folded into fork_info::~fork_info().
6106         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6107         Adjust.
6108         (init_fork_list): Delete.
6109         (linux_fork_killall, linux_fork_mourn_inferior)
6110         (linux_fork_detach, info_checkpoints_command): Adjust.
6111         (_initialize_linux_fork): No longer call init_fork_list.
6112
6113 2019-03-06  Pedro Alves  <palves@redhat.com>
6114
6115         * linux-fork.c (new_fork): New, split out of ...
6116         (add_fork): ... this.  Return void.  Move "first fork" special
6117         case from here, to ...
6118         (checkpoint_command): ... here.
6119         * linux-linux.h (add_fork): Return void.
6120
6121 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6122
6123         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6124
6125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6126             Chris January  <chris.january@arm.com>
6127             David Lecomber  <david.lecomber@arm.com>
6128
6129         * f-exp.y: New token, UNOP_INTRINSIC.
6130         (exp): New pattern using UNOP_INTRINSIC token.
6131         (f77_keywords): Add 'abs' keyword.
6132         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6133         (value_from_host_double): New function.
6134         (evaluate_subexp_f): Support UNOP_ABS.
6135
6136 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6139         types.
6140
6141 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6142
6143         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6144         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6145         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6146
6147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6148
6149         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6150
6151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6152             Chris January  <chris.january@arm.com>
6153
6154         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6155         * f-exp.y: Define 'KIND' token.
6156         (exp): New pattern for KIND expressions.
6157         (ptype): Handle types with a kind extension.
6158         (direct_abs_decl): Extend to spot kind extensions.
6159         (f77_keywords): Add 'kind' to the list.
6160         (push_kind_type): New function.
6161         (convert_to_kind_type): New function.
6162         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6163         * parse.c (operator_length_standard): Likewise.
6164         * parser-defs.h (enum type_pieces): Add tp_kind.
6165         * std-operator.def: Add UNOP_KIND.
6166
6167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * f-exp.y (f_parse): Set yydebug.
6170
6171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6172
6173         * f-lang.c (evaluate_subexp_f): New function.
6174         (exp_descriptor_f): New global.
6175         (f_language_defn): Use exp_descriptor_f instead of
6176         exp_descriptor_standard.
6177
6178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * f-exp.y (struct token): Add comments.
6181         (dot_ops): Remove uppercase versions and the end marker.
6182         (f77_keywords): Likewise.
6183         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6184         entries in the dot_ops array are case insensitive, and use
6185         strncasecmp to compare strings.  Also some whitespace cleanup in
6186         this area.  Similar for the f77_keywords array, except entries in
6187         this list might be case sensitive.
6188
6189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * f-exp.y (struct f77_boolean_val): Add comments.
6192         (boolean_values): Remove uppercase versions, and end marker.
6193         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6194         and use strncasecmp to achieve case insensitivity.  Additionally,
6195         perform whitespace cleanup around this code.
6196
6197 2019-03-06  Tom Tromey  <tromey@adacore.com>
6198
6199         * remote-sim.c (gdbsim_target_open): Use result of
6200         gdb_argv::release.
6201
6202 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6203         Dirk Schubert  <dirk.schubert@arm.com>
6204         Chris January  <chris.january@arm.com>
6205
6206         * eval.c (evaluate_subexp_standard): Call Fortran argument
6207         wrapping logic.
6208         * f-lang.c (struct value): A value which can be passed into a
6209         Fortran function call.
6210         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6211         where appropriate.
6212         (struct type): Value ready for a Fortran function call.
6213         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6214         is needed.
6215         * f-lang.h (fortran_argument_convert): Declaration.
6216         (fortran_preserve_arg_pointer): Declaration.
6217         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6218
6219 2019-03-05  Tom Tromey  <tromey@adacore.com>
6220
6221         * python/py-prettyprint.c (print_string_repr): Remove #if.
6222         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6223
6224 2019-03-05  Tom Tromey  <tromey@adacore.com>
6225
6226         * target.c (the_dummy_target): Move later.  Change type to
6227         "dummy_target".
6228         (initialize_targets): Don't initialize the_dummy_target.
6229
6230 2019-03-05  Tom Tromey  <tromey@adacore.com>
6231
6232         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6233         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6234
6235 2019-03-05  Tom Tromey  <tromey@adacore.com>
6236
6237         * windows-nat.c (windows_nat_target::attach)
6238         (windows_nat_target::detach): Don't call gdb_flush.
6239         * valprint.c (generic_val_print, val_print, val_print_string):
6240         Don't call gdb_flush.
6241         * utils.c (defaulted_query): Don't call gdb_flush.
6242         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6243         * target.c (target_announce_detach): Don't call gdb_flush.
6244         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6245         * remote.c (extended_remote_target::attach): Don't call
6246         gdb_flush.
6247         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6248         * printcmd.c (do_examine): Don't call gdb_flush.
6249         (info_display_command): Don't call gdb_flush.
6250         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6251         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6252         * memattr.c (info_mem_command): Don't call gdb_flush.
6253         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6254         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6255         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6256         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6257         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6258         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6259         (gnu_nat_target::detach): Don't call gdb_flush.
6260         * f-valprint.c (f_val_print): Don't call gdb_flush.
6261         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6262         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6263         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6264         gdb_flush.
6265         * c-valprint.c (c_val_print): Don't call gdb_flush.
6266         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6267
6268 2019-03-05  Tom Tromey  <tromey@adacore.com>
6269
6270         * varobj.c (update_dynamic_varobj_children): Update.
6271         (install_default_visualizer): Use reset, not release.
6272         * value.c (set_internalvar): Update.
6273         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6274         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6275         ATTRIBUTE_UNUSED_RESULT.
6276
6277 2019-03-05  Tom Tromey  <tromey@adacore.com>
6278
6279         * remote.c (class scoped_remote_fd) <release>: Add
6280         ATTRIBUTE_UNUSED_RESULT.
6281
6282 2019-03-05  Tom Tromey  <tromey@adacore.com>
6283
6284         * macroexp.c (struct macro_buffer) <release>: Add
6285         ATTRIBUTE_UNUSED_RESULT.
6286
6287 2019-03-05  Tom Tromey  <tromey@adacore.com>
6288
6289         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6290         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6291         ATTRIBUTE_UNUSED_RESULT.
6292
6293 2019-03-05  Tom Tromey  <tromey@adacore.com>
6294
6295         * common/scoped_fd.h (class scoped_fd) <release>: Add
6296         ATTRIBUTE_UNUSED_RESULT.
6297
6298 2019-03-05  Tom Tromey  <tromey@adacore.com>
6299
6300         * parser-defs.h (struct parser_state) <release>: Add
6301         ATTRIBUTE_UNUSED_RESULT.
6302
6303 2019-03-05  Tom Tromey  <tromey@adacore.com>
6304
6305         * utils.h (class gdb_argv) <release>: Add
6306         ATTRIBUTE_UNUSED_RESULT.
6307         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6308
6309 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6310
6311         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6312         for-loop range, to avoid compiler warnings.
6313
6314         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6315         avoid compiler warnings about unused variables.
6316
6317         * NEWS: Mention end of support for native debugging on MS-Windows
6318         before XP.
6319
6320         PR gdb/24292
6321         * common/netstuff.c:
6322         * gdbserver/gdbreplay.c
6323         * gdbserver/remote-utils.c:
6324         * ser-tcp.c:
6325         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6326         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6327         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6328         'getaddrinfo' and 'freeaddrinfo' were not available before
6329         Windows XP, and mingw.org's MinGW headers by default define
6330         _WIN32_WINNT to 0x500.
6331
6332 2019-03-01  Gary Benson <gbenson@redhat.com>
6333
6334         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6335
6336 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6337             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6338
6339         PR gdb/8527
6340         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6341         set_sigint_trap, clear_sigint_trap.
6342
6343 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6344
6345         * target.c (target_detach): Clear the regcache and the
6346         frame cache.
6347
6348 2019-02-27  Pedro Alves  <palves@redhat.com>
6349
6350         * utils.c (set_screen_size): When we cap the height/width sizes,
6351         tweak the corresponding command variable to show "unlimited":
6352
6353 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6354             Pedro Alves  <palves@redhat.com>
6355
6356         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6357         before calling rl_set_screen_size.
6358
6359 2019-02-27  Tom Tromey  <tromey@adacore.com>
6360
6361         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6362         define.
6363         * python/py-value.c: Remove Python 2.4 workaround.
6364         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6365         workaround.
6366         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6367         Python 2.4 workaround.
6368         * python/python-internal.h: Remove Python 2.4 comment.
6369         (Py_ssize_t): Don't define.
6370         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6371         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6372         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6373         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6374         * python/python.c (do_start_initialization): Remove Python 2.4
6375         workaround.
6376         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6377         (print_children): Remove Python 2.4 workaround.
6378         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6379         workaround.
6380         (CHARBUFFERPROC_NAME): Remove.
6381         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6382         Python 2.4 workaround.
6383
6384 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6385
6386         * NEWS: Note minimum Python version.
6387
6388 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6389
6390         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6391         code from these functions.  Remove corresponding ifdefs.  Use
6392         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6393         Remove gotos and target of gotos.
6394         (infpy_search_memory): Likewise.
6395
6396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6399         (hppa_gdbarch_init): Don't register deleted functions with
6400         gdbarch.
6401
6402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6403
6404         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6405         (h8300_unwind_sp): Delete.
6406         (h8300_dummy_id): Delete.
6407         (h8300_gdbarch_init): Don't register deleted functions with
6408         gdbarch.
6409
6410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6413         (ft32_unwind_pc): Delete.
6414         (ft32_unwind_sp): Delete.
6415         (ft32_gdbarch_init): Don't register deleted functions with
6416         gdbarch.
6417
6418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6421         (frv_unwind_pc): Delete.
6422         (frv_unwind_sp): Delete.
6423         (frv_gdbarch_init): Don't register deleted functions with
6424         gdbarch.
6425
6426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6429         (riscv_unwind_pc): Delete.
6430         (riscv_unwind_sp): Delete.
6431         (riscv_gdbarch_init): Don't register deleted functions with
6432         gdbarch.
6433
6434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6437         (csky_unwind_pc): Delete.
6438         (csky_unwind_sp): Delete.
6439         (csky_gdbarch_init): Don't register deleted functions with
6440         gdbarch.
6441
6442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6445         (cris_unwind_pc): Delete.
6446         (cris_unwind_sp): Delete.
6447         (cris_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6453         (bfin_unwind_pc): Delete.
6454         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6455
6456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6459         (arm_unwind_pc): Delete.
6460         (arm_unwind_sp): Delete.
6461         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6462
6463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6466         (arc_unwind_pc): Delete.
6467         (arc_unwind_sp): Delete.
6468         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6469
6470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6471
6472         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6473         (alpha_unwind_pc): Delete.
6474         (alpha_gdbarch_init): Don't register deleted functions with
6475         gdbarch.
6476
6477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6480         (aarch64_unwind_pc): Delete.
6481         (aarch64_unwind_sp): Delete.
6482         (aarch64_gdbarch_init): Don't register deleted functions with
6483         gdbarch.
6484
6485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6486
6487         * gdbtypes.c (type_align): Don't consider static members when
6488         computing structure alignment.
6489
6490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6491
6492         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6493         return 0 for other types.
6494         * arch-utils.c (default_type_align): Always return 0.
6495         * gdbarch.h: Regenerate.
6496         * gdbarch.sh (type_align): Extend comment.
6497         * gdbtypes.c (type_align): Add additional comments, always call
6498         gdbarch_type_align before applying the default rules.
6499         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6500         generic code will then apply a suitable default.
6501         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6502         types, return 0 for other types.
6503
6504 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6505
6506         * NEWS: Create a new section for the next release branch.
6507         Rename the section of the current branch, now that it has
6508         been cut.
6509
6510 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6511
6512         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6513         * version.in: Bump version to 8.3.50.DATE-git.
6514
6515 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6516
6517         * aix-thread.c (ptid_cmp): Remove unused variable.
6518         (get_signaled_thread): Likewise.
6519         (store_regs_user_thread): Likewise.
6520         (store_regs_kernel_thread): Likewise.
6521         (fetch_regs_kernel_thread): Remove shadowed variable.
6522
6523 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6524
6525         * features/riscv/32bit-cpu.xml: Add register numbers.
6526         * features/riscv/32bit-fpu.c: Regenerate.
6527         * features/riscv/32bit-fpu.xml: Add register numbers.
6528         * features/riscv/64bit-cpu.xml: Add register numbers.
6529         * features/riscv/64bit-fpu.c: Regenerate.
6530         * features/riscv/64bit-fpu.xml: Add register numbers.
6531
6532 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6533
6534         * NEWS: Mention two argument form of gdb.Value constructor.
6535         * python/py-value.c (convert_buffer_and_type_to_value): New
6536         function.
6537         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6538         Add support for handling an optional second argument.  Call
6539         convert_buffer_and_type_to_value as appropriate.
6540         * python/python-internal.h (Py_buffer_deleter): New struct.
6541         (Py_buffer_up): New typedef.
6542
6543 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6544
6545         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6546         instead of releasing ownership.
6547
6548 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6549
6550         * dwarf2read.c (open_and_init_dwp_file): Call
6551         elf_numsections instead of bfd_count_sections to initialize
6552         dwp_file->num_sections.
6553
6554 2019-02-25  Tom Tromey  <tromey@adacore.com>
6555
6556         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6557
6558 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6559
6560         * gcore.in: Add '--readnever' option when invoking GDB.
6561
6562 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6563
6564         * MAINTAINERS: Update my email address.
6565
6566 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6567
6568         * build-id.c (build_id_to_debug_bfd_1): New function.
6569         (build_id_to_debug_bfd): Look for separate debug file in
6570         sysroot.
6571
6572 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * gdbarch.sh: Update the copyright year range that is placed into
6575         generated files.
6576
6577 2019-02-22  Keith Seitz  <keiths@redhat.com>
6578
6579         PR symtab/23853
6580         * linespec.c (create_sals_line_offset): Search for the default
6581         symtab's filename instead of its fullname.
6582
6583 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6584
6585         * NEWS: Update style defaults.
6586
6587 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6588
6589         * main.c (captured_main_1): Disable styling in batch mode.
6590
6591 2019-02-20  Tom Tromey  <tom@tromey.com>
6592
6593         * symtab.c (symtab_symbol_info): Fix typos.
6594
6595 2019-02-20  Tom Tromey  <tromey@adacore.com>
6596
6597         * findcmd.c (_initialize_mem_search): Use upper case for
6598         metasyntactic variables.
6599
6600 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6601
6602         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6603         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6604
6605 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6606
6607         * top.h (source_file_name): Change to std::string.
6608         * top.c (source_file_name): Likewise.
6609         (command_line_input): Adjust.
6610         * cli/cli-script.c (script_from_file): Adjust.
6611
6612 2019-02-19  Tom Tromey  <tromey@adacore.com>
6613
6614         * ravenscar-thread.c
6615         (ravenscar_thread_target::update_thread_list): Don't call
6616         ada_build_task_list.
6617         * ada-lang.h (ada_build_task_list): Don't declare.
6618         * ada-tasks.c (struct ada_tasks_inferior_data)
6619         <task_list_valid_p>: Now bool.
6620         (read_known_tasks, ada_task_list_changed)
6621         (ada_tasks_invalidate_inferior_data): Update.
6622         (read_known_tasks_array): Return bool.
6623         (read_known_tasks_list): Likewise.
6624         (read_known_tasks): Return void.
6625         (ada_build_task_list): Now static.
6626
6627 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6630         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6631
6632 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6633
6634         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6635         variant for ada_tasks_pspace_data_handle and
6636         ada_tasks_inferior_data_handle.
6637         (ada_tasks_pspace_data_cleanup): New function.
6638         (ada_tasks_inferior_data_cleanup): New function.
6639
6640 2019-02-17  Tom Tromey  <tom@tromey.com>
6641
6642         * macrotab.h (macro_source_fullname): Return a std::string.
6643         * macrotab.c (macro_include, check_for_redefinition)
6644         (macro_undef, macro_lookup_definition, foreach_macro)
6645         (foreach_macro_in_scope): Update.
6646         (macro_source_fullname): Return a std::string.
6647         * macrocmd.c (show_pp_source_pos): Update.
6648
6649 2019-02-17  Tom Tromey  <tom@tromey.com>
6650
6651         * macrocmd.c (show_pp_source_pos): Style the file names.
6652
6653 2019-02-17  Tom Tromey  <tom@tromey.com>
6654
6655         PR tui/24197:
6656         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6657
6658 2019-02-17  Tom Tromey  <tom@tromey.com>
6659
6660         * ada-lang.c (user_select_syms): Use filtered printing.
6661         * utils.c (wrap_style): New global.
6662         (desired_style): Remove.
6663         (emit_style_escape): Add stream parameter.
6664         (set_output_style, reset_terminal_style, prompt_for_continue):
6665         Update.
6666         (flush_wrap_buffer): Only flush gdb_stdout.
6667         (wrap_here): Set wrap_style.
6668         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6669         treat escape sequences as a character.  Change when wrap buffer is
6670         flushed.
6671         (fputs_styled): Do not set the output style when the default is
6672         requested.
6673         * ui-style.h (struct ui_file_style) <is_default>: New method.
6674         * source.c (print_source_lines_base): Emit escape sequences in one
6675         piece.
6676
6677 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6678
6679         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6680         integers and enumeration types.
6681
6682 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6683
6684         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6685         instead of lookup_symbol_in_language
6686         (do_exact_match): New function.
6687         (ada_get_symbol_name_matcher): Return do_exact_match when
6688         doing a verbatim match.
6689
6690 2019-02-15  Tom Tromey  <tromey@adacore.com>
6691
6692         * ravenscar-thread.c (ravenscar_thread_target::resume)
6693         (ravenscar_thread_target::wait): Special case wildcard requests.
6694
6695 2019-02-15  Tom Tromey  <tromey@adacore.com>
6696
6697         * ravenscar-thread.c (base_ptid): Remove.
6698         (struct ravenscar_thread_target) <close>: New method.
6699         <m_base_ptid>: New member.
6700         <update_inferior_ptid, active_task, task_is_currently_active,
6701         runtime_initialized>: Declare methods.
6702         <ravenscar_thread_target>: Add constructor.
6703         (ravenscar_thread_target::task_is_currently_active)
6704         (ravenscar_thread_target::update_inferior_ptid)
6705         (ravenscar_runtime_initialized): Rename.  Now methods.
6706         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6707         (ravenscar_thread_target::update_thread_list): Update.
6708         (ravenscar_thread_target::active_task): Now method.
6709         (ravenscar_thread_target::store_registers)
6710         (ravenscar_thread_target::prepare_to_store)
6711         (ravenscar_thread_target::prepare_to_store)
6712         (ravenscar_thread_target::mourn_inferior): Update.
6713         (ravenscar_inferior_created): Use "new" to create target.
6714         (ravenscar_thread_target::get_ada_task_ptid): Update.
6715         (_initialize_ravenscar): Don't initialize base_ptid.
6716         (ravenscar_ops): Remove global.
6717
6718 2019-02-15  Tom Tromey  <tromey@adacore.com>
6719
6720         * target.h (push_target): Declare new overload.
6721         * target.c (push_target): New overload, taking an rvalue reference.
6722         * remote.c (remote_target::open_1): Use push_target overload.
6723         * corelow.c (core_target_open): Use push_target overload.
6724
6725 2019-02-15  Tom Tromey  <tromey@adacore.com>
6726
6727         * ravenscar-thread.c (is_ravenscar_task)
6728         (ravenscar_task_is_currently_active): Return bool.
6729         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6730         (_initialize_ravenscar): Remove "(void)".
6731         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6732         Return bool.
6733
6734 2019-02-15  Tom Tromey  <tromey@adacore.com>
6735
6736         * ravenscar-thread.c (ravenscar_runtime_initializer)
6737         (has_ravenscar_runtime, get_running_thread_id)
6738         (ravenscar_thread_target::resume): Fix indentation.
6739
6740 2019-02-15  Tom Tromey  <tromey@adacore.com>
6741
6742         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6743         from ravenscar_arch_ops.
6744         (sparc_ravenscar_ops::fetch_registers)
6745         (sparc_ravenscar_ops::store_registers): Now methods.
6746         (sparc_ravenscar_prepare_to_store): Remove.
6747         (sparc_ravenscar_ops): Redefine.
6748         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6749         methods and destructor.  Remove members.
6750         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6751         (ravenscar_thread_target::store_registers)
6752         (ravenscar_thread_target::prepare_to_store): Update.
6753         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6754         Remove.
6755         (struct ppc_ravenscar_powerpc_ops): Derive from
6756         ravenscar_arch_ops.
6757         (ppc_ravenscar_powerpc_ops::fetch_registers)
6758         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6759         (ppc_ravenscar_powerpc_ops): Redefine.
6760         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6761         (ppc_ravenscar_e500_ops::fetch_registers)
6762         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6763         (ppc_ravenscar_e500_ops): Redefine.
6764         * aarch64-ravenscar-thread.c
6765         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6766         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6767         (aarch64_ravenscar_fetch_registers)
6768         (aarch64_ravenscar_store_registers): Now methods.
6769         (aarch64_ravenscar_ops): Redefine.
6770
6771 2019-02-15  Tom Tromey  <tromey@adacore.com>
6772
6773         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6774         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6775         (ravenscar_thread_target::stopped_by_watchpoint)
6776         (ravenscar_thread_target::stopped_data_address)
6777         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6778
6779 2019-02-15  Tom Tromey  <tromey@adacore.com>
6780
6781         * ravenscar-thread.c: Fix some typos.
6782
6783 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6784             Tom Tromey  <tromey@adacore.com>
6785
6786         * ada-lang.c (ada_exception_sal): Change addr_string to a
6787         std::string.
6788         (create_ada_exception_catchpoint): Update.
6789
6790 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6791             Tom Tromey  <tromey@adacore.com>
6792
6793         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6794         (bp_location_ops): Remove.
6795         (base_breakpoint_allocate_location): Update.
6796         (free_bp_location): Update.
6797         * ada-lang.c (class ada_catchpoint_location)
6798         <ada_catchpoint_location>: Remove ops parameter.
6799         (ada_catchpoint_location_dtor): Remove.
6800         (ada_catchpoint_location_ops): Remove.
6801         (allocate_location_exception): Update.
6802         * breakpoint.h (struct bp_location_ops): Remove.
6803         (class bp_location) <bp_location>: Remove bp_location_ops
6804         parameter.
6805         <~bp_location>: Add destructor.
6806         <ops>: Remove.
6807
6808 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6809             Pedro Alves  <palves@redhat.com>
6810
6811         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6812         'PATH_MAX'.
6813
6814 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6815             Samuel Thibault  <samuel.thibault@gnu.org>
6816             Thomas Schwinge  <thomas@codesourcery.com>
6817
6818         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6819         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6820
6821 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6822
6823         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6824         (check_empty): Use "const char *".
6825
6826         * gnu-nat.c (gnu_nat_target::detach): Instead of
6827         'detach_inferior (pid)' call
6828         'detach_inferior (find_inferior_pid (pid))'.
6829
6830         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6831         'nat/fork-inferior.o'.
6832         * gnu-nat.c: #include "nat/fork-inferior.h".
6833
6834         * gnu-nat.c (gnu_nat_target::detach): Instead of
6835         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6836         * gnu-nat.h: #include "inf-child.h".
6837         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6838         'i386_gnu_nat_target::fetch_registers'.
6839         (gnu_store_registers): Rename/move to
6840         'i386_gnu_nat_target::store_registers'.
6841
6842         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6843         * gnu-nat.h (mach_thread_info): New function.
6844         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6845
6846         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6847
6848 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6849
6850         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6851
6852 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6853
6854         * windows-nat.c (windows_add_thread): Add new parameter
6855         "main_thread_p" with default value set to false.  Update
6856         function documentation as well as all callers.
6857         (windows_delete_thread): Likewise.
6858         (fake_create_process): Update call to windows_add_thread.
6859         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6860         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6861         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6862         call to windows_delete_thread.
6863
6864 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6865
6866         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6867
6868 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6869
6870         * symfile.c (find_separate_debug_file): Use canonical path of
6871         sysroot with child_path instead of gdb_sysroot if it is valid.
6872
6873 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6874
6875         * symfile.c (find_separate_debug_file): Use child_path to
6876         determine if an object file is under a sysroot.
6877
6878 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6879
6880         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6881         unittests/child-path-selftests.c.
6882         * common/pathstuff.c (child_path): New function.
6883         * common/pathstuff.h (child_path): New prototype.
6884         * unittests/child-path-selftests.c: New file.
6885
6886 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6887
6888         * symfile.c (find_separate_debug_file): Look for separate debug
6889         files in debug directories under the sysroot.
6890
6891 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6892
6893         * symtab.h (struct minimal_symbol data_p): New const method.
6894         (struct minimal_symbol text_p): Likewise.
6895         * symtab.c (output_source_filename): Use file name style
6896         to print file name.
6897         (print_symbol_info): Likewise.
6898         (print_msymbol_info): Use address style to print addresses.
6899         Use function name style to print executable text symbols.
6900         (expand_symtab_containing_pc): Use data_p.
6901         (find_pc_sect_compunit_symtab): Likewise.
6902
6903 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6904
6905         * breakpoint.c (describe_other_breakpoints): Use address style
6906         to print addresses.
6907         (say_where): Likewise.
6908
6909 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6910
6911         * ada-typeprint.c (print_func_type): Print function name
6912         style to print function name.
6913         * c-typeprint.c (c_print_type_1): Likewise.
6914
6915 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6916
6917         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6918         for execve.
6919
6920 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6921
6922         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6923         type_stack.
6924
6925 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6926
6927         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6928         TYPE_CODE_REF types.
6929
6930 2019-02-08  Jim Wilson  <jimw@sifive.com>
6931
6932         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6933         (riscv_linux_fregset): New.
6934         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6935
6936 2019-02-07  Tom Tromey  <tom@tromey.com>
6937
6938         * thread.c (thread_cancel_execution_command): Update.
6939         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6940         methods.
6941         (struct thread_fsm_ops): Remove.
6942         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6943         (thread_fsm_should_stop, thread_fsm_return_value)
6944         (thread_fsm_set_finished, thread_fsm_finished_p)
6945         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6946         Don't declare.
6947         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6948         * infrun.c (clear_proceed_status_thread)
6949         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6950         (print_stop_event): Update.
6951         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6952         Add constructor.
6953         (step_command_fsm_ops): Remove.
6954         (new_step_command_fsm): Remove.
6955         (step_1): Update.
6956         (step_command_fsm::should_stop): Rename from
6957         step_command_fsm_should_stop.
6958         (step_command_fsm::clean_up): Rename from
6959         step_command_fsm_clean_up.
6960         (step_command_fsm::do_async_reply_reason): Rename from
6961         step_command_fsm_async_reply_reason.
6962         (struct until_next_fsm): Inherit from thread_fsm.  Add
6963         constructor.
6964         (until_next_fsm_ops): Remove.
6965         (new_until_next_fsm): Remove.
6966         (until_next_fsm::should_stop): Rename from
6967         until_next_fsm_should_stop.
6968         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6969         (until_next_fsm::do_async_reply_reason): Rename from
6970         until_next_fsm_async_reply_reason.
6971         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6972         constructor.  Change type of breakpoint.
6973         (finish_command_fsm_ops): Remove.
6974         (new_finish_command_fsm): Remove.
6975         (finish_command_fsm::should_stop): Rename from
6976         finish_command_fsm_should_stop.
6977         (finish_command_fsm::clean_up): Rename from
6978         finish_command_fsm_clean_up.
6979         (finish_command_fsm::return_value): Rename from
6980         finish_command_fsm_return_value.
6981         (finish_command_fsm::do_async_reply_reason): Rename from
6982         finish_command_fsm_async_reply_reason.
6983         (finish_command): Update.
6984         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6985         Add constructor.
6986         (call_thread_fsm_ops): Remove.
6987         (call_thread_fsm::call_thread_fsm): Rename from
6988         new_call_thread_fsm.
6989         (call_thread_fsm::should_stop): Rename from
6990         call_thread_fsm_should_stop.
6991         (call_thread_fsm::should_notify_stop): Rename from
6992         call_thread_fsm_should_notify_stop.
6993         (run_inferior_call, call_function_by_hand_dummy): Update.
6994         * cli/cli-interp.c (should_print_stop_to_console): Update.
6995         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6996         Add constructor.  Change type of location_breakpoint,
6997         caller_breakpoint.
6998         (until_break_fsm_ops): Remove.
6999         (new_until_break_fsm): Remove.
7000         (until_break_fsm::should_stop): Rename from
7001         until_break_fsm_should_stop.
7002         (until_break_fsm::clean_up): Rename from
7003         until_break_fsm_clean_up.
7004         (until_break_fsm::do_async_reply_reason): Rename from
7005         until_break_fsm_async_reply_reason.
7006         (until_break_command): Update.
7007         * thread-fsm.c: Remove.
7008         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7009
7010 2019-02-07  Tom Tromey  <tom@tromey.com>
7011
7012         * yy-remap.h: Add include guard.
7013         * xtensa-tdep.h: Add include guard.
7014         * xcoffread.h: Rename include guard.
7015         * varobj-iter.h: Add include guard.
7016         * tui/tui.h: Rename include guard.
7017         * tui/tui-winsource.h: Rename include guard.
7018         * tui/tui-wingeneral.h: Rename include guard.
7019         * tui/tui-windata.h: Rename include guard.
7020         * tui/tui-win.h: Rename include guard.
7021         * tui/tui-stack.h: Rename include guard.
7022         * tui/tui-source.h: Rename include guard.
7023         * tui/tui-regs.h: Rename include guard.
7024         * tui/tui-out.h: Rename include guard.
7025         * tui/tui-layout.h: Rename include guard.
7026         * tui/tui-io.h: Rename include guard.
7027         * tui/tui-hooks.h: Rename include guard.
7028         * tui/tui-file.h: Rename include guard.
7029         * tui/tui-disasm.h: Rename include guard.
7030         * tui/tui-data.h: Rename include guard.
7031         * tui/tui-command.h: Rename include guard.
7032         * tic6x-tdep.h: Add include guard.
7033         * target/waitstatus.h: Rename include guard.
7034         * target/wait.h: Rename include guard.
7035         * target/target.h: Rename include guard.
7036         * target/resume.h: Rename include guard.
7037         * target-float.h: Rename include guard.
7038         * stabsread.h: Add include guard.
7039         * rs6000-tdep.h: Add include guard.
7040         * riscv-fbsd-tdep.h: Add include guard.
7041         * regformats/regdef.h: Rename include guard.
7042         * record.h: Rename include guard.
7043         * python/python.h: Rename include guard.
7044         * python/python-internal.h: Rename include guard.
7045         * python/py-stopevent.h: Rename include guard.
7046         * python/py-ref.h: Rename include guard.
7047         * python/py-record.h: Rename include guard.
7048         * python/py-record-full.h: Rename include guard.
7049         * python/py-record-btrace.h: Rename include guard.
7050         * python/py-instruction.h: Rename include guard.
7051         * python/py-events.h: Rename include guard.
7052         * python/py-event.h: Rename include guard.
7053         * procfs.h: Add include guard.
7054         * proc-utils.h: Add include guard.
7055         * p-lang.h: Add include guard.
7056         * or1k-tdep.h: Rename include guard.
7057         * observable.h: Rename include guard.
7058         * nto-tdep.h: Rename include guard.
7059         * nat/x86-linux.h: Rename include guard.
7060         * nat/x86-linux-dregs.h: Rename include guard.
7061         * nat/x86-gcc-cpuid.h: Add include guard.
7062         * nat/x86-dregs.h: Rename include guard.
7063         * nat/x86-cpuid.h: Rename include guard.
7064         * nat/ppc-linux.h: Rename include guard.
7065         * nat/mips-linux-watch.h: Rename include guard.
7066         * nat/linux-waitpid.h: Rename include guard.
7067         * nat/linux-ptrace.h: Rename include guard.
7068         * nat/linux-procfs.h: Rename include guard.
7069         * nat/linux-osdata.h: Rename include guard.
7070         * nat/linux-nat.h: Rename include guard.
7071         * nat/linux-namespaces.h: Rename include guard.
7072         * nat/linux-btrace.h: Rename include guard.
7073         * nat/glibc_thread_db.h: Rename include guard.
7074         * nat/gdb_thread_db.h: Rename include guard.
7075         * nat/gdb_ptrace.h: Rename include guard.
7076         * nat/fork-inferior.h: Rename include guard.
7077         * nat/amd64-linux-siginfo.h: Rename include guard.
7078         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7079         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7080         * nat/aarch64-linux.h: Rename include guard.
7081         * nat/aarch64-linux-hw-point.h: Rename include guard.
7082         * mn10300-tdep.h: Add include guard.
7083         * mips-linux-tdep.h: Add include guard.
7084         * mi/mi-parse.h: Rename include guard.
7085         * mi/mi-out.h: Rename include guard.
7086         * mi/mi-main.h: Rename include guard.
7087         * mi/mi-interp.h: Rename include guard.
7088         * mi/mi-getopt.h: Rename include guard.
7089         * mi/mi-console.h: Rename include guard.
7090         * mi/mi-common.h: Rename include guard.
7091         * mi/mi-cmds.h: Rename include guard.
7092         * mi/mi-cmd-break.h: Rename include guard.
7093         * m2-lang.h: Add include guard.
7094         * location.h: Rename include guard.
7095         * linux-record.h: Rename include guard.
7096         * linux-nat.h: Add include guard.
7097         * linux-fork.h: Add include guard.
7098         * i386-darwin-tdep.h: Rename include guard.
7099         * hppa-linux-offsets.h: Add include guard.
7100         * guile/guile.h: Rename include guard.
7101         * guile/guile-internal.h: Rename include guard.
7102         * gnu-nat.h: Rename include guard.
7103         * gdb-stabs.h: Rename include guard.
7104         * frv-tdep.h: Add include guard.
7105         * f-lang.h: Add include guard.
7106         * event-loop.h: Add include guard.
7107         * darwin-nat.h: Rename include guard.
7108         * cp-abi.h: Rename include guard.
7109         * config/sparc/nm-sol2.h: Rename include guard.
7110         * config/nm-nto.h: Rename include guard.
7111         * config/nm-linux.h: Add include guard.
7112         * config/i386/nm-i386gnu.h: Rename include guard.
7113         * config/djgpp/nl_types.h: Rename include guard.
7114         * config/djgpp/langinfo.h: Rename include guard.
7115         * compile/gcc-cp-plugin.h: Add include guard.
7116         * compile/gcc-c-plugin.h: Add include guard.
7117         * compile/compile.h: Rename include guard.
7118         * compile/compile-object-run.h: Rename include guard.
7119         * compile/compile-object-load.h: Rename include guard.
7120         * compile/compile-internal.h: Rename include guard.
7121         * compile/compile-cplus.h: Rename include guard.
7122         * compile/compile-c.h: Rename include guard.
7123         * common/xml-utils.h: Rename include guard.
7124         * common/x86-xstate.h: Rename include guard.
7125         * common/version.h: Rename include guard.
7126         * common/vec.h: Rename include guard.
7127         * common/tdesc.h: Rename include guard.
7128         * common/selftest.h: Rename include guard.
7129         * common/scoped_restore.h: Rename include guard.
7130         * common/scoped_mmap.h: Rename include guard.
7131         * common/scoped_fd.h: Rename include guard.
7132         * common/safe-iterator.h: Rename include guard.
7133         * common/run-time-clock.h: Rename include guard.
7134         * common/refcounted-object.h: Rename include guard.
7135         * common/queue.h: Rename include guard.
7136         * common/ptid.h: Rename include guard.
7137         * common/print-utils.h: Rename include guard.
7138         * common/preprocessor.h: Rename include guard.
7139         * common/pathstuff.h: Rename include guard.
7140         * common/observable.h: Rename include guard.
7141         * common/netstuff.h: Rename include guard.
7142         * common/job-control.h: Rename include guard.
7143         * common/host-defs.h: Rename include guard.
7144         * common/gdb_wait.h: Rename include guard.
7145         * common/gdb_vecs.h: Rename include guard.
7146         * common/gdb_unlinker.h: Rename include guard.
7147         * common/gdb_unique_ptr.h: Rename include guard.
7148         * common/gdb_tilde_expand.h: Rename include guard.
7149         * common/gdb_sys_time.h: Rename include guard.
7150         * common/gdb_string_view.h: Rename include guard.
7151         * common/gdb_splay_tree.h: Rename include guard.
7152         * common/gdb_setjmp.h: Rename include guard.
7153         * common/gdb_ref_ptr.h: Rename include guard.
7154         * common/gdb_optional.h: Rename include guard.
7155         * common/gdb_locale.h: Rename include guard.
7156         * common/gdb_assert.h: Rename include guard.
7157         * common/filtered-iterator.h: Rename include guard.
7158         * common/filestuff.h: Rename include guard.
7159         * common/fileio.h: Rename include guard.
7160         * common/environ.h: Rename include guard.
7161         * common/common-utils.h: Rename include guard.
7162         * common/common-types.h: Rename include guard.
7163         * common/common-regcache.h: Rename include guard.
7164         * common/common-inferior.h: Rename include guard.
7165         * common/common-gdbthread.h: Rename include guard.
7166         * common/common-exceptions.h: Rename include guard.
7167         * common/common-defs.h: Rename include guard.
7168         * common/common-debug.h: Rename include guard.
7169         * common/cleanups.h: Rename include guard.
7170         * common/buffer.h: Rename include guard.
7171         * common/btrace-common.h: Rename include guard.
7172         * common/break-common.h: Rename include guard.
7173         * cli/cli-utils.h: Rename include guard.
7174         * cli/cli-style.h: Rename include guard.
7175         * cli/cli-setshow.h: Rename include guard.
7176         * cli/cli-script.h: Rename include guard.
7177         * cli/cli-interp.h: Rename include guard.
7178         * cli/cli-decode.h: Rename include guard.
7179         * cli/cli-cmds.h: Rename include guard.
7180         * charset-list.h: Add include guard.
7181         * buildsym-legacy.h: Rename include guard.
7182         * bfin-tdep.h: Add include guard.
7183         * ax.h: Rename include guard.
7184         * arm-linux-tdep.h: Add include guard.
7185         * arm-fbsd-tdep.h: Add include guard.
7186         * arch/xtensa.h: Rename include guard.
7187         * arch/tic6x.h: Add include guard.
7188         * arch/i386.h: Add include guard.
7189         * arch/arm.h: Rename include guard.
7190         * arch/arm-linux.h: Rename include guard.
7191         * arch/arm-get-next-pcs.h: Rename include guard.
7192         * arch/amd64.h: Add include guard.
7193         * arch/aarch64-insn.h: Rename include guard.
7194         * arch-utils.h: Rename include guard.
7195         * annotate.h: Add include guard.
7196         * amd64-darwin-tdep.h: Rename include guard.
7197         * aarch64-linux-tdep.h: Add include guard.
7198         * aarch64-fbsd-tdep.h: Add include guard.
7199         * aarch32-linux-nat.h: Add include guard.
7200
7201 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7202
7203         * macrotab.c (macro_define_internal): New function that
7204         factorizes macro_define_object_internal and macro_define_function
7205         code.
7206         (macro_define_object_internal): Use macro_define_internal.
7207         (macro_define_function): Likewise.
7208
7209 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7210
7211         * macrocmd.c (extract_identifier): Return
7212         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7213         callers.
7214
7215 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7216
7217         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7218
7219 2019-02-05  Tom Tromey  <tom@tromey.com>
7220
7221         * target.c (target_stack::unpush): Move assertion earlier.
7222
7223 2019-01-30  Tom Tromey  <tom@tromey.com>
7224
7225         PR python/23615:
7226         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7227         (gdbpy_parse_and_eval): Likewise.
7228         * python/python-internal.h (gdbpy_allow_threads): New class.
7229
7230 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7231
7232         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7233         (aarch64_fbsd_fpregmap): Move earlier.
7234         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7235         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7236         instead of individual calls to trad_frame_set_reg_addr.
7237         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7238         earlier.
7239         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7240         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7241         instead of individual calls to trad_frame_set_reg_addr.
7242
7243 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7244
7245         * CONTRIBUTE: Replace contribution list with wiki link.
7246
7247 2019-01-25  Tom Tromey  <tom@tromey.com>
7248
7249         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7250
7251 2019-01-25  Tom Tromey  <tom@tromey.com>
7252
7253         * xtensa-linux-nat.c: Fix common/ includes.
7254         * xml-support.h: Fix common/ includes.
7255         * xml-support.c: Fix common/ includes.
7256         * x86-linux-nat.c: Fix common/ includes.
7257         * windows-nat.c: Fix common/ includes.
7258         * varobj.h: Fix common/ includes.
7259         * varobj.c: Fix common/ includes.
7260         * value.c: Fix common/ includes.
7261         * valops.c: Fix common/ includes.
7262         * utils.c: Fix common/ includes.
7263         * unittests/xml-utils-selftests.c: Fix common/ includes.
7264         * unittests/utils-selftests.c: Fix common/ includes.
7265         * unittests/unpack-selftests.c: Fix common/ includes.
7266         * unittests/tracepoint-selftests.c: Fix common/ includes.
7267         * unittests/style-selftests.c: Fix common/ includes.
7268         * unittests/string_view-selftests.c: Fix common/ includes.
7269         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7270         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7271         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7272         * unittests/rsp-low-selftests.c: Fix common/ includes.
7273         * unittests/parse-connection-spec-selftests.c: Fix common/
7274         includes.
7275         * unittests/optional-selftests.c: Fix common/ includes.
7276         * unittests/offset-type-selftests.c: Fix common/ includes.
7277         * unittests/observable-selftests.c: Fix common/ includes.
7278         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7279         * unittests/memrange-selftests.c: Fix common/ includes.
7280         * unittests/memory-map-selftests.c: Fix common/ includes.
7281         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7282         * unittests/function-view-selftests.c: Fix common/ includes.
7283         * unittests/environ-selftests.c: Fix common/ includes.
7284         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7285         * unittests/common-utils-selftests.c: Fix common/ includes.
7286         * unittests/cli-utils-selftests.c: Fix common/ includes.
7287         * unittests/array-view-selftests.c: Fix common/ includes.
7288         * ui-file.c: Fix common/ includes.
7289         * tui/tui-io.c: Fix common/ includes.
7290         * tracepoint.h: Fix common/ includes.
7291         * tracepoint.c: Fix common/ includes.
7292         * tracefile-tfile.c: Fix common/ includes.
7293         * top.h: Fix common/ includes.
7294         * top.c: Fix common/ includes.
7295         * thread.c: Fix common/ includes.
7296         * target/waitstatus.h: Fix common/ includes.
7297         * target/waitstatus.c: Fix common/ includes.
7298         * target.h: Fix common/ includes.
7299         * target.c: Fix common/ includes.
7300         * target-memory.c: Fix common/ includes.
7301         * target-descriptions.c: Fix common/ includes.
7302         * symtab.h: Fix common/ includes.
7303         * symfile.c: Fix common/ includes.
7304         * stap-probe.c: Fix common/ includes.
7305         * spu-linux-nat.c: Fix common/ includes.
7306         * sparc-nat.c: Fix common/ includes.
7307         * source.c: Fix common/ includes.
7308         * solib.c: Fix common/ includes.
7309         * solib-target.c: Fix common/ includes.
7310         * ser-unix.c: Fix common/ includes.
7311         * ser-tcp.c: Fix common/ includes.
7312         * ser-pipe.c: Fix common/ includes.
7313         * ser-base.c: Fix common/ includes.
7314         * selftest-arch.c: Fix common/ includes.
7315         * s12z-tdep.c: Fix common/ includes.
7316         * rust-exp.y: Fix common/ includes.
7317         * rs6000-aix-tdep.c: Fix common/ includes.
7318         * riscv-tdep.c: Fix common/ includes.
7319         * remote.c: Fix common/ includes.
7320         * remote-notif.h: Fix common/ includes.
7321         * remote-fileio.h: Fix common/ includes.
7322         * remote-fileio.c: Fix common/ includes.
7323         * regcache.h: Fix common/ includes.
7324         * regcache.c: Fix common/ includes.
7325         * record-btrace.c: Fix common/ includes.
7326         * python/python.c: Fix common/ includes.
7327         * python/py-type.c: Fix common/ includes.
7328         * python/py-inferior.c: Fix common/ includes.
7329         * progspace.h: Fix common/ includes.
7330         * producer.c: Fix common/ includes.
7331         * procfs.c: Fix common/ includes.
7332         * proc-api.c: Fix common/ includes.
7333         * printcmd.c: Fix common/ includes.
7334         * ppc-linux-nat.c: Fix common/ includes.
7335         * parser-defs.h: Fix common/ includes.
7336         * osdata.c: Fix common/ includes.
7337         * obsd-nat.c: Fix common/ includes.
7338         * nat/x86-linux.c: Fix common/ includes.
7339         * nat/x86-linux-dregs.c: Fix common/ includes.
7340         * nat/x86-dregs.h: Fix common/ includes.
7341         * nat/x86-dregs.c: Fix common/ includes.
7342         * nat/ppc-linux.c: Fix common/ includes.
7343         * nat/mips-linux-watch.h: Fix common/ includes.
7344         * nat/mips-linux-watch.c: Fix common/ includes.
7345         * nat/linux-waitpid.c: Fix common/ includes.
7346         * nat/linux-ptrace.h: Fix common/ includes.
7347         * nat/linux-ptrace.c: Fix common/ includes.
7348         * nat/linux-procfs.c: Fix common/ includes.
7349         * nat/linux-personality.c: Fix common/ includes.
7350         * nat/linux-osdata.c: Fix common/ includes.
7351         * nat/linux-namespaces.c: Fix common/ includes.
7352         * nat/linux-btrace.h: Fix common/ includes.
7353         * nat/linux-btrace.c: Fix common/ includes.
7354         * nat/fork-inferior.c: Fix common/ includes.
7355         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7356         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7357         * nat/aarch64-linux.c: Fix common/ includes.
7358         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7359         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7360         * namespace.h: Fix common/ includes.
7361         * mips-linux-tdep.c: Fix common/ includes.
7362         * minsyms.c: Fix common/ includes.
7363         * mi/mi-parse.h: Fix common/ includes.
7364         * mi/mi-main.c: Fix common/ includes.
7365         * mi/mi-cmd-env.c: Fix common/ includes.
7366         * memrange.h: Fix common/ includes.
7367         * memattr.c: Fix common/ includes.
7368         * maint.h: Fix common/ includes.
7369         * maint.c: Fix common/ includes.
7370         * main.c: Fix common/ includes.
7371         * machoread.c: Fix common/ includes.
7372         * location.c: Fix common/ includes.
7373         * linux-thread-db.c: Fix common/ includes.
7374         * linux-nat.c: Fix common/ includes.
7375         * linux-fork.c: Fix common/ includes.
7376         * inline-frame.c: Fix common/ includes.
7377         * infrun.c: Fix common/ includes.
7378         * inflow.c: Fix common/ includes.
7379         * inferior.h: Fix common/ includes.
7380         * inferior.c: Fix common/ includes.
7381         * infcmd.c: Fix common/ includes.
7382         * inf-ptrace.c: Fix common/ includes.
7383         * inf-child.c: Fix common/ includes.
7384         * ia64-linux-nat.c: Fix common/ includes.
7385         * i387-tdep.c: Fix common/ includes.
7386         * i386-tdep.c: Fix common/ includes.
7387         * i386-linux-tdep.c: Fix common/ includes.
7388         * i386-linux-nat.c: Fix common/ includes.
7389         * i386-go32-tdep.c: Fix common/ includes.
7390         * i386-fbsd-tdep.c: Fix common/ includes.
7391         * i386-fbsd-nat.c: Fix common/ includes.
7392         * guile/scm-type.c: Fix common/ includes.
7393         * guile/guile.c: Fix common/ includes.
7394         * go32-nat.c: Fix common/ includes.
7395         * gnu-nat.c: Fix common/ includes.
7396         * gdbthread.h: Fix common/ includes.
7397         * gdbarch-selftests.c: Fix common/ includes.
7398         * gdb_usleep.c: Fix common/ includes.
7399         * gdb_select.h: Fix common/ includes.
7400         * gdb_bfd.c: Fix common/ includes.
7401         * gcore.c: Fix common/ includes.
7402         * fork-child.c: Fix common/ includes.
7403         * findvar.c: Fix common/ includes.
7404         * fbsd-nat.c: Fix common/ includes.
7405         * event-top.c: Fix common/ includes.
7406         * event-loop.c: Fix common/ includes.
7407         * dwarf2read.c: Fix common/ includes.
7408         * dwarf2loc.c: Fix common/ includes.
7409         * dwarf2-frame.c: Fix common/ includes.
7410         * dwarf-index-cache.c: Fix common/ includes.
7411         * dtrace-probe.c: Fix common/ includes.
7412         * disasm-selftests.c: Fix common/ includes.
7413         * defs.h: Fix common/ includes.
7414         * csky-tdep.c: Fix common/ includes.
7415         * cp-valprint.c: Fix common/ includes.
7416         * cp-support.h: Fix common/ includes.
7417         * cp-support.c: Fix common/ includes.
7418         * corelow.c: Fix common/ includes.
7419         * completer.h: Fix common/ includes.
7420         * completer.c: Fix common/ includes.
7421         * compile/compile.c: Fix common/ includes.
7422         * compile/compile-loc2c.c: Fix common/ includes.
7423         * compile/compile-cplus-types.c: Fix common/ includes.
7424         * compile/compile-cplus-symbols.c: Fix common/ includes.
7425         * command.h: Fix common/ includes.
7426         * cli/cli-dump.c: Fix common/ includes.
7427         * cli/cli-cmds.c: Fix common/ includes.
7428         * charset.c: Fix common/ includes.
7429         * build-id.c: Fix common/ includes.
7430         * btrace.h: Fix common/ includes.
7431         * btrace.c: Fix common/ includes.
7432         * breakpoint.h: Fix common/ includes.
7433         * breakpoint.c: Fix common/ includes.
7434         * ax.h:
7435         (enum agent_op): Fix common/ includes.
7436         * ax-general.c (struct aop_map): Fix common/ includes.
7437         * ax-gdb.c: Fix common/ includes.
7438         * auxv.c: Fix common/ includes.
7439         * auto-load.c: Fix common/ includes.
7440         * arm-tdep.c: Fix common/ includes.
7441         * arch/riscv.c: Fix common/ includes.
7442         * arch/ppc-linux-common.c: Fix common/ includes.
7443         * arch/i386.c: Fix common/ includes.
7444         * arch/arm.c: Fix common/ includes.
7445         * arch/arm-linux.c: Fix common/ includes.
7446         * arch/arm-get-next-pcs.c: Fix common/ includes.
7447         * arch/amd64.c: Fix common/ includes.
7448         * arch/aarch64.c: Fix common/ includes.
7449         * arch/aarch64-insn.c: Fix common/ includes.
7450         * arch-utils.c: Fix common/ includes.
7451         * amd64-windows-tdep.c: Fix common/ includes.
7452         * amd64-tdep.c: Fix common/ includes.
7453         * amd64-sol2-tdep.c: Fix common/ includes.
7454         * amd64-obsd-tdep.c: Fix common/ includes.
7455         * amd64-nbsd-tdep.c: Fix common/ includes.
7456         * amd64-linux-tdep.c: Fix common/ includes.
7457         * amd64-linux-nat.c: Fix common/ includes.
7458         * amd64-fbsd-tdep.c: Fix common/ includes.
7459         * amd64-fbsd-nat.c: Fix common/ includes.
7460         * amd64-dicos-tdep.c: Fix common/ includes.
7461         * amd64-darwin-tdep.c: Fix common/ includes.
7462         * agent.c: Fix common/ includes.
7463         * ada-lang.h: Fix common/ includes.
7464         * ada-lang.c: Fix common/ includes.
7465         * aarch64-tdep.c: Fix common/ includes.
7466
7467 2019-01-25  Tom Tromey  <tom@tromey.com>
7468
7469         * common/create-version.sh: Use common/version.h.
7470
7471 2019-01-24  Pedro Alves  <palves@redhat.com>
7472
7473         * infrun.c (signal_stop, signal_print, signal_program)
7474         (signal_catch, signal_pass): Now arrays instead of pointers.
7475         (update_signals_program_target, do_target_resume)
7476         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7477         * linux-nat.c (linux_nat_target::pass_signals)
7478         (linux_nat_target::create_inferior, linux_nat_target::attach):
7479         Adjust.
7480         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7481         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7482         * procfs.c (procfs_target::pass_signals): Adjust.
7483         * record-full.c (record_full_target::resume): Adjust.
7484         * remote.c (remote_target::pass_signals)
7485         (remote_target::program_signals): Adjust.
7486         * target-debug.h (target_debug_print_signals): Now takes a
7487         gdb::array_view as parameter.  Adjust.
7488         * target.h (target_ops) <pass_signals, program_signals>: Replace
7489         pointer and length parameters with gdb::array_view.
7490         (target_pass_signals, target_program_signals): Likewise.
7491         * target-delegates.c: Regenerate.
7492
7493 2019-01-24  Pedro Alves  <palves@redhat.com>
7494
7495         * common/forward-scope-exit.h
7496         (forward_scope_exit::forward_scope_exit): Pass arguments to
7497         m_bind_function directly, instead of creating a std::bind and
7498         copying that.
7499
7500 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7501
7502         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7503         for static members.
7504         (pass_in_v_vfp_candidate): Likewise.
7505
7506 2019-01-23  Tom Tromey  <tom@tromey.com>
7507             Pedro Alves  <palves@redhat.com>
7508
7509         * regcache.c (class regcache_invalidator): Remove.
7510         (regcache::raw_write): Use make_scope_exit.
7511
7512 2019-01-23  Tom Tromey  <tom@tromey.com>
7513
7514         * ui-out.h (class ui_out_emit_type): Update comment.
7515
7516 2019-01-23  Tom Tromey  <tom@tromey.com>
7517
7518         * infrun.c (fetch_inferior_event): Update comment.
7519
7520 2019-01-23  Tom Tromey  <tom@tromey.com>
7521             Pedro Alves  <palves@redhat.com>
7522
7523         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7524         parameter.
7525         (fetch_inferior_event): Use SCOPE_EXIT.
7526
7527
7528 2019-01-23  Tom Tromey  <tom@tromey.com>
7529             Pedro Alves  <palves@redhat.com>
7530
7531         * infrun.c (disable_thread_events): Delete.
7532         (stop_all_threads): Use SCOPE_EXIT.
7533
7534 2019-01-23  Tom Tromey  <tom@tromey.com>
7535             Pedro Alves  <palves@redhat.com>
7536
7537         * symfile.c: Include forward-scope-exit.h.
7538         (clear_symtab_users_cleanup): Replace forward declaration with
7539         a FORWARD_SCOPE_EXIT.
7540         (syms_from_objfile_1): Use the forward_scope_exit and
7541         gdb::optional instead of cleanup_function.
7542         (reread_symbols): Use the forward_scope_exit instead of
7543         cleanup_function.
7544         (clear_symtab_users_cleanup): Remove function.
7545
7546 2019-01-23  Tom Tromey  <tom@tromey.com>
7547             Pedro Alves  <palves@redhat.com>
7548
7549         * linux-nat.c: Include scope-exit.h.
7550         (cleanup_target_stop): Remove.
7551         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7552         SCOPE_EXIT.
7553
7554 2019-01-23  Tom Tromey  <tom@tromey.com>
7555             Pedro Alves  <palves@redhat.com>
7556
7557         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7558         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7559
7560 2019-01-23  Tom Tromey  <tom@tromey.com>
7561             Andrew Burgess  <andrew.burgess@embecosm.com>
7562             Pedro Alves  <palves@redhat.com>
7563
7564         * infrun.c (fetch_inferior_event): Use scope_exit.
7565         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7566         * top.c (execute_command): Use scope_exit.
7567         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7568         * utils.c (do_bpstat_clear_actions_cleanup)
7569         (make_bpstat_clear_actions_cleanup): Remove.
7570
7571 2019-01-23  Tom Tromey  <tom@tromey.com>
7572             Pedro Alves  <palves@redhat.com>
7573
7574         * infrun.c: Include "common/scope-exit.h"
7575         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7576         (wait_for_inferior): Use SCOPE_EXIT.
7577         (fetch_inferior_event): Use scope_exit.
7578
7579 2019-01-23  Tom Tromey  <tom@tromey.com>
7580             Pedro Alves  <palves@redhat.com>
7581
7582         * breakpoint.c (create_breakpoint): Remove cleanup.
7583
7584 2019-01-23  Tom Tromey  <tom@tromey.com>
7585             Andrew Burgess  <andrew.burgess@embecosm.com>
7586             Pedro Alves  <palves@redhat.com>
7587
7588 2019-01-23  Pedro Alves  <palves@redhat.com>
7589
7590         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7591
7592 2019-01-23  Pedro Alves  <palves@redhat.com>
7593             Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * gdbthread.h: Include "common/forward-scope-exit.h".
7596         (scoped_finish_thread_state): Redefine custom class in terms of
7597         forward_scope_exit.
7598
7599 2019-01-23  Pedro Alves  <palves@redhat.com>
7600             Andrew Burgess  <andrew.burgess@embecosm.com>
7601
7602         * common/forward-scope-exit.h: New file.
7603
7604 2019-01-23  Pedro Alves  <palves@redhat.com>
7605             Andrew Burgess  <andrew.burgess@embecosm.com>
7606             Tom Tromey  <tom@tromey.com>
7607
7608         * common/scope-exit.h: New file.
7609
7610 2019-01-23  Pedro Alves  <palves@redhat.com>
7611
7612         * common/preprocessor.h (ESC): Rename to ...
7613         (ESC_PARENS): ... this.
7614         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7615         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7616
7617 2019-01-23  Tom Tromey  <tom@tromey.com>
7618
7619         * language.h (class scoped_switch_to_sym_language_if_auto):
7620         Initialize m_lang in both cases.
7621
7622 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7623
7624         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7625         with XCNEW.
7626
7627 2019-01-22  Tom Tromey  <tom@tromey.com>
7628
7629         * corelow.c: Do not include sys/file.h.
7630
7631 2019-01-22  Tom Tromey  <tom@tromey.com>
7632
7633         * tui/tui-wingeneral.h: Include gdb_curses.h.
7634
7635 2019-01-22  Tom Tromey  <tom@tromey.com>
7636
7637         * source-cache.h (class source_cache) <get_source_lines,
7638         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7639
7640 2019-01-22  Tom Tromey  <tom@tromey.com>
7641
7642         * remote-fileio.h (struct remote_target): Declare.
7643
7644 2019-01-22  Tom Tromey  <tom@tromey.com>
7645
7646         * python/py-arch.c: Do not include py-ref.h.
7647         * python/py-bpevent.c: Do not include py-ref.h.
7648         * python/py-cmd.c: Do not include py-ref.h.
7649         * python/py-continueevent.c: Do not include py-ref.h.
7650         * python/py-event.h: Do not include py-ref.h.
7651         * python/py-evtregistry.c: Do not include py-ref.h.
7652         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7653         * python/py-frame.c: Do not include py-ref.h.
7654         * python/py-framefilter.c: Do not include py-ref.h.
7655         * python/py-function.c: Do not include py-ref.h.
7656         * python/py-infevents.c: Do not include py-ref.h.
7657         * python/py-linetable.c: Do not include py-ref.h.
7658         * python/py-objfile.c: Do not include py-ref.h.
7659         * python/py-param.c: Do not include py-ref.h.
7660         * python/py-prettyprint.c: Do not include py-ref.h.
7661         * python/py-progspace.c: Do not include py-ref.h.
7662         * python/py-symbol.c: Do not include py-ref.h.
7663         * python/py-symtab.c: Do not include py-ref.h.
7664         * python/py-type.c: Do not include py-ref.h.
7665         * python/py-unwind.c: Do not include py-ref.h.
7666         * python/py-utils.c: Do not include py-ref.h.
7667         * python/py-value.c: Do not include py-ref.h.
7668         * python/py-varobj.c: Do not include py-ref.h.
7669         * python/py-xmethods.c: Do not include py-ref.h.
7670         * python/python.c: Do not include py-ref.h.
7671         * varobj.c: Do not include py-ref.h.
7672
7673 2019-01-22  Tom Tromey  <tom@tromey.com>
7674
7675         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7676         keyword for bcache.
7677
7678 2019-01-22  Tom Tromey  <tom@tromey.com>
7679
7680         * compile/compile-cplus-types.c: Remove a comment by #include.
7681
7682 2019-01-22  Tom Tromey  <tom@tromey.com>
7683
7684         * compile/gcc-c-plugin.h: Include compile-internal.h.
7685
7686 2019-01-22  Tom Tromey  <tom@tromey.com>
7687
7688         * stabsread.c (EXTERN): Do not define.
7689         (symnum, next_symbol_text_func, processing_gcc_compilation)
7690         (within_function, global_sym_chain, global_stabs)
7691         (previous_stab_code, this_object_header_files)
7692         (n_this_object_header_files)
7693         (n_allocated_this_object_header_files): Define.
7694         * stabsread.h (EXTERN): Never define.  Use "extern".
7695
7696 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7697
7698         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7699         history_value.
7700
7701 2019-01-21  Tom Tromey  <tom@tromey.com>
7702
7703         * ui-out.c: Fix includes.
7704         * tui/tui-source.c: Fix includes.
7705         * target.c: Fix includes.
7706         * remote.c: Fix includes.
7707         * regcache.c: Fix includes.
7708         * python/py-block.c: Fix includes.
7709         * printcmd.c: Fix includes.
7710         * or1k-tdep.c: Fix includes.
7711         * mi/mi-main.c: Fix includes.
7712         * m32r-tdep.c: Fix includes.
7713         * csky-tdep.c: Fix includes.
7714         * compile/compile-cplus-types.c: Fix includes.
7715         * cli/cli-interp.c: Fix includes.
7716
7717 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7718
7719         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7720         for padding.
7721
7722 2019-01-16  Tom Tromey  <tom@tromey.com>
7723
7724         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7725         earlier.
7726         (struct objfile) <msymbols_range>: Move from top level.
7727         <msymbols>: New method.
7728         (class objfile_msymbols): Remove.
7729         * symtab.c (default_collect_symbol_completion_matches_break_on):
7730         Update.
7731         * symmisc.c (dump_msymbols): Update.
7732         * stabsread.c (scan_file_globals): Update.
7733         * objc-lang.c (info_selectors_command, info_classes_command)
7734         (find_methods): Update.
7735         * minsyms.c (find_solib_trampoline_target): Update.
7736         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7737         * coffread.c (coff_symfile_read): Update.
7738         * ada-lang.c (ada_lookup_simple_minsym)
7739         (ada_collect_symbol_completion_matches): Update.
7740
7741 2019-01-16  Tom Tromey  <tom@tromey.com>
7742
7743         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7744         type.  Remove no-argument constructor.
7745         <iterator::operator++>: Simplify.
7746         <begin>: Update.
7747         <end>: Use minimal_symbol_count.
7748
7749 2019-01-16  Tom Tromey  <tom@tromey.com>
7750
7751         * objfiles.h (struct objfile) <psymtabs>: New method.
7752         (class objfile_psymtabs): Remove.
7753         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7754         typedef.
7755         <range>: New method.
7756         (require_partial_symbols): Change return type.
7757         * psymtab.c (require_partial_symbols)
7758         (psym_expand_symtabs_matching): Update.
7759         * mdebugread.c (parse_partial_symbols): Update.
7760         * dbxread.c (dbx_end_psymtab): Update.
7761
7762 2019-01-15  Tom Tromey  <tom@tromey.com>
7763
7764         * symtab.c (lookup_objfile_from_block)
7765         (lookup_symbol_in_objfile_symtabs)
7766         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7767         (find_line_symtab, info_sources_command)
7768         (default_collect_symbol_completion_matches_break_on)
7769         (make_source_files_completion_list): Update.
7770         * symmisc.c (print_objfile_statistics, dump_objfile)
7771         (maintenance_print_symbols, maintenance_info_symtabs)
7772         (maintenance_check_symtabs, maintenance_info_line_tables):
7773         Update.
7774         * source.c (select_source_symtab)
7775         (forget_cached_source_info_for_objfile): Update.
7776         * objfiles.h (class objfile_compunits): Remove.
7777         (struct objfile) <compunits_range>: New typedef.
7778         (compunits): New method.
7779         * objfiles.c (objfile_relocate1): Update.
7780         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7781         * maint.c (count_symtabs_and_blocks): Update.
7782         * linespec.c (iterate_over_all_matching_symtabs): Update.
7783         * cp-support.c (add_symbol_overload_list_qualified): Update.
7784         * coffread.c (coff_symtab_read): Update.
7785         * ada-lang.c (add_nonlocal_symbols)
7786         (ada_collect_symbol_completion_matches)
7787         (ada_add_global_exceptions): Update.
7788
7789 2019-01-15  Tom Tromey  <tom@tromey.com>
7790
7791         * progspace.h (program_space) <objfiles_safe_range>: New
7792         typedef.
7793         <objfiles_safe>: New method.
7794         * objfiles.h (class all_objfiles_safe): Remove.
7795         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7796         * jit.c (jit_inferior_exit_hook): Update.
7797
7798 2019-01-17  Tom Tromey  <tom@tromey.com>
7799
7800         * progspace.h (program_space) <objfiles_range>: New typedef.
7801         <objfiles>: New method.
7802         <objfiles_head>: Rename from objfiles.
7803         (object_files): Update.
7804         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7805         * guile/scm-pretty-print.c
7806         (ppscm_find_pretty_printer_from_objfiles): Update.
7807         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7808         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7809         Update.
7810         * python/py-progspace.c (pspy_get_objfiles): Update.
7811         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7812         Update.
7813         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7814         (objfpy_lookup_objfile_by_build_id): Update.
7815         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7816         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7817         Update.
7818         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7819         (expand_symtab_containing_pc, lookup_objfile_from_block)
7820         (lookup_static_symbol, basic_lookup_transparent_type)
7821         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7822         (find_line_symtab, info_sources_command)
7823         (default_collect_symbol_completion_matches_break_on)
7824         (make_source_files_completion_list, find_main_name): Update.
7825         * symmisc.c (print_symbol_bcache_statistics)
7826         (print_objfile_statistics, maintenance_print_symbols)
7827         (maintenance_print_msymbols, maintenance_print_objfiles)
7828         (maintenance_info_symtabs, maintenance_check_symtabs)
7829         (maintenance_expand_symtabs, maintenance_info_line_tables):
7830         Update.
7831         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7832         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7833         (map_overlay_command, unmap_overlay_command)
7834         (simple_overlay_update, expand_symtabs_matching)
7835         (map_symbol_filenames): Update.
7836         * symfile-debug.c (set_debug_symfile): Update.
7837         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7838         Update.
7839         * source.c (select_source_symtab, forget_cached_source_info):
7840         Update.
7841         * solib.c (solib_read_symbols): Update.
7842         * solib-spu.c (append_ocl_sos): Update.
7843         * psymtab.c (maintenance_print_psymbols)
7844         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7845         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7846         * printcmd.c (info_symbol_command): Update.
7847         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7848         Update.
7849         * objfiles.h (class all_objfiles): Remove.
7850         * objfiles.c (have_partial_symbols, have_full_symbols)
7851         (have_minimal_symbols, qsort_cmp, update_section_map)
7852         (shared_objfile_contains_address_p)
7853         (default_iterate_over_objfiles_in_search_order): Update.
7854         * objc-lang.c (info_selectors_command, info_classes_command)
7855         (find_methods): Update.
7856         * minsyms.c (find_solib_trampoline_target): Update.
7857         * maint.c (maintenance_info_sections)
7858         (maintenance_translate_address, count_symtabs_and_blocks):
7859         Update.
7860         * main.c (captured_main_1): Update.
7861         * linux-thread-db.c (try_thread_db_load_from_pdir)
7862         (has_libpthread): Update.
7863         * linespec.c (iterate_over_all_matching_symtabs)
7864         (search_minsyms_for_name): Update.
7865         * jit.c (jit_find_objf_with_entry_addr): Update.
7866         * hppa-tdep.c (find_unwind_entry)
7867         (hppa_lookup_stub_minimal_symbol): Update.
7868         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7869         Update.
7870         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7871         (elf_gnu_ifunc_resolve_by_got): Update.
7872         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7873         * dwarf-index-write.c (save_gdb_index_command): Update.
7874         * cp-support.c (add_symbol_overload_list_qualified): Update.
7875         * breakpoint.c (create_overlay_event_breakpoint)
7876         (create_longjmp_master_breakpoint)
7877         (create_std_terminate_master_breakpoint)
7878         (create_exception_master_breakpoint): Update.
7879         * blockframe.c (find_pc_partial_function): Update.
7880         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7881         (ada_collect_symbol_completion_matches)
7882         (ada_add_global_exceptions): Update.
7883
7884 2019-01-17  Tom Tromey  <tom@tromey.com>
7885
7886         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7887         declare VEC.
7888         (solib_target_parse_libraries): Change return type.
7889         (library_list_start_segment, library_list_start_section)
7890         (library_list_end_library, library_list_start_library); Update.
7891         (solib_target_free_library_list): Remove.
7892         (solib_target_parse_libraries): Remove cleanup.  Change return
7893         type.
7894         (solib_target_current_sos): Update.
7895
7896 2019-01-17  Tom Tromey  <tromey@bapiya>
7897
7898         * valprint.c: Replace "the the" with "the".
7899         * symtab.c: Replace "the the" with "the".
7900         * solib.c: Replace "the the" with "the".
7901         * solib-dsbt.c: Replace "the the" with "the".
7902         * linespec.c: Replace "the the" with "the".
7903         * dwarf2loc.h: Replace "the the" with "the".
7904         * amd64-windows-tdep.c: Replace "the the" with "the".
7905         * aarch64-tdep.c: Replace "the the" with "the".
7906
7907 2019-01-16  Keith Seitz  <keiths@redhat.com>
7908
7909         PR gdb/23773
7910         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7911         <builder>: Rename to ..
7912         <m_builder>: ... this and make private.
7913         (dwarf2_cu::get_builder): New method.  Change all users of
7914         `builder' to use this method.
7915         (dwarf2_start_symtab): Move to ...
7916         (dwarf2_cu::start_symtab): ... here.  Update all callers
7917         (setup_type_unit_groups): Move to ...
7918         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7919         callers.
7920         (dwarf2_cu::reset_builder): New method.
7921         (process_full_compunit, process_full_type_unit): Use
7922         dwarf2_cu::reset_builder.
7923         (follow_die_offset): Record the ancestor CU if it is different
7924         from the followed DIE's CU.
7925         (follow_die_sig_1): Likewise.
7926
7927 2019-01-15  Tom Tromey  <tom@tromey.com>
7928
7929         * remote.c (class remote_state) <buf>: Now a char_vector.
7930         <buf_size>: Remove.
7931         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7932         parameter.
7933         (remote_target::getpkt_or_notif_sane_1)
7934         (remote_target::getpkt_sane)
7935         (remote_target::getpkt_or_notif_sane): Likewise.
7936         (class remote_target) <putpkt>: New overload.
7937         (remote_target::read_frame): Change type of "buf_p".  Remove
7938         sizeof_p parameter.
7939         (packet_ok): New overload.
7940         (packet_check_result): New overload.
7941         Update all uses.
7942
7943 2019-01-14  Tom Tromey  <tom@tromey.com>
7944
7945         * remote-notif.c (handle_notification, remote_notif_ack)
7946         (remote_notif_parse): Make "buf" const.
7947         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7948         const.
7949         (remote_notif_parse, remote_notif_ack, handle_notification):
7950         Likewise.
7951         * remote.c (remote_notif_stop_parse): Make "buf" const.
7952         (remote_target::remote_parse_stop_reply): Make "buf" const.
7953         (remote_notif_stop_ack): Make "buf" const.
7954
7955 2019-01-14  Tom Tromey  <tom@tromey.com>
7956
7957         * remote.c (remote_console_output): Make parameter const.
7958
7959 2019-01-14  Tom Tromey  <tom@tromey.com>
7960
7961         * target-debug.h (target_debug_print_signals): Constify.
7962         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7963         * procfs.c (procfs_target::pass_signals): Update.
7964         * linux-nat.c (linux_nat_target::pass_signals): Update.
7965         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7966         * target-delegates.c: Rebuild.
7967         * remote.c (remote_target::program_signals): Update.
7968         (remote_target::pass_signals): Update.
7969         * target.c (target_pass_signals): Constify argument.
7970         (target_program_signals): Likewise.
7971         * target.h (struct target_ops) <pass_signals, program_signals>:
7972         Constify argument.
7973         (target_pass_signals, target_program_signals): Constify argument.
7974
7975 2019-01-14  Tom Tromey  <tom@tromey.com>
7976
7977         PR tui/28819:
7978         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7979
7980 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7981
7982         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7983         field.
7984         * rs6000-tdep.c: Include reggroups.h.
7985         (IS_V_ALIAS_PSEUDOREG): Define.
7986         (rs6000_register_name): Return names for the "vX" aliases.
7987         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7988         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7989         aliases.  Call default_register_reggroup_p for all other
7990         pseudo-registers.
7991         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7992         New functions.
7993         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7994         Handle "vX" aliases.
7995         (v_alias_pseudo_register_collect): New function.
7996         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7997         (rs6000_gdbarch_init): Initialize "vX" aliases as
7998         pseudo-registers.  Restore registration of
7999         rs6000_pseudo_register_reggroup_p with
8000         set_tdesc_pseudo_register_reggroup_p.
8001
8002 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8003
8004         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8005         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8006         set_gdbarch_num_pseudo_regs.
8007
8008 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8009
8010         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8011         Remove arg prefixname, add do_set and do_show.
8012         Add member functions set_list and show_list.
8013         * cli/cli-style.c (class cli_style_option): Update accordingly.
8014         (style_set_list): Move to file scope.
8015         (style_show_list): Likewise.
8016         (set_style): Call help_list.
8017         (show_style): Call cmd_show_list.
8018         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8019         Update to use the new macro.
8020
8021 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8022
8023         * ada-lang.c (_initialize_ada_language): Expand the help text
8024         for the "catch exception" command.
8025
8026 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8027
8028         * symtab.c (matching_obj_sections): Initialize obj,
8029         declare it closer to its usage.
8030
8031 2019-01-10  Tom Tromey  <tom@tromey.com>
8032
8033         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8034         (basic_inf_threads_range): Remove.
8035         (inf_threads_range, inf_non_exited_threads_range)
8036         (safe_inf_threads_range): Use next_adapter.
8037
8038 2019-01-10  Keith Seitz  <keiths@redhat.com>
8039
8040         PR gdb/23712
8041         PR symtab/23010
8042         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8043         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8044
8045 2019-01-10  Keith Seitz  <keiths@redhat.com>
8046
8047         PR gdb/23712
8048         PR symtab/23010
8049         * dictionary.c (pending_to_vector): Remove.
8050         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8051         Remove _1 suffix, replacing functions of the same name.  Update
8052         all callers.
8053         (dict_create_hashed, dict_create_hashed_expandable)
8054         (dict_create_linear, dict_create_linear_expandable, dict_free)
8055         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8056         Make functions static.
8057
8058 2019-01-10  Keith Seitz  <keiths@redhat.com>
8059
8060         PR gdb/23712
8061         PR symtab/23010
8062         * dictionary.h (struct dictionary): Replace declaration with
8063         multidictionary.
8064         (dict_create_hashed, dict_create_hashed_expandable)
8065         (dict_create_linear, dict_create_linear_expandable)
8066         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8067         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8068         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8069         taking multidictionary argument.
8070         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8071         * block.h (struct block) <dict>: Change to multidictionary
8072         and rename `multidict'.
8073         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8074         symmisc.c: Update all dictionary references to multidictionary.
8075
8076 2019-01-10  Keith Seitz  <keiths@redhat.com>
8077
8078         PR gdb/23712
8079         PR symtab/23010
8080         * dictionary.c: Include unordered_map.
8081         (pending_to_vector): New function.
8082         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8083         Rewrite the non-"_1" functions to take vector instead
8084         of linked list.
8085         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8086         "new" _1 versions of the same name.
8087         (multidictionary): Define.
8088         (std::hash<enum language): New definition.
8089         (collate_pending_symbols_by_language, mdict_create_hashed)
8090         (mdict_create_hashed_expandable, mdict_create_linear)
8091         (mdict_create_linear_expandable, mdict_free)
8092         (find_language_dictionary, create_new_language_dictionary)
8093         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8094         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8095         (mdict_size, mdict_empty): New functions.
8096         * dictionary.h (mdict_iterator): Define.
8097
8098 2019-01-10  Pedro Alves  <palves@redhat.com>
8099
8100         * breakpoint.c (read_uploaded_action)
8101         (create_tracepoint_from_upload): Adjust to use
8102         gdb::unique_xmalloc_ptr.
8103         * ctf.c (ctf_write_uploaded_tp):
8104         (SET_ARRAY_FIELD): Use emplace_back.
8105         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8106         * tracefile-tfile.c (tfile_write_uploaded_tp):
8107         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8108         gdb::unique_xmalloc_ptr.
8109         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8110         at_string, cond_string, cmd_strings>: Replace char pointers
8111         with gdb::unique_xmalloc_ptr.
8112
8113 2019-01-10  Pedro Alves  <palves@redhat.com>
8114
8115         * solib-target.c (library_list_start_library): Don't xstrdup name.
8116
8117 2019-01-10  Pedro Alves  <palves@redhat.com>
8118
8119         * mdebugread.c (parse_partial_symbols): Use
8120         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8121
8122 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8123
8124         * linux-fork.c (scoped_switch_fork_info)
8125         <~scoped_switch_fork_info>: Fix incorrect variable name.
8126
8127 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8128
8129         * linux-fork.c (scoped_switch_fork_info)
8130         <scoped_switch_fork_info>: Make explicit.
8131         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8132
8133 2019-01-10  Tom Tromey  <tom@tromey.com>
8134
8135         * objfiles.h (objfile::reset_psymtabs): Update.
8136         * objfiles.c (objfile::objfile): Update.
8137         * psymtab.h (psymtab_storage::obstack): Update.
8138         (psymtab_storage::m_obstack): Use gdb::optional.
8139         (class psymtab_storage): Update comment.  Remove objfile
8140         parameter.
8141         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8142
8143 2019-01-10  Tom Tromey  <tom@tromey.com>
8144
8145         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8146         <free_psymtabs>: Now private.
8147         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8148         (allocate_psymtab): Use new method.
8149
8150 2019-01-10  Tom Tromey  <tom@tromey.com>
8151
8152         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8153         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8154         * mdebugread.c (parse_partial_symbols): Use
8155         allocate_dependencies.
8156         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8157         allocate_dependencies.
8158         (process_psymtab_comp_unit_reader)
8159         (build_type_psymtab_dependencies): Likewise.
8160         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8161
8162 2019-01-10  Tom Tromey  <tom@tromey.com>
8163
8164         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8165         PSYMBOL_SET_LANGUAGE.
8166         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8167
8168 2019-01-10  Tom Tromey  <tom@tromey.com>
8169
8170         * psymtab.h (psymtab_storage::obstack): New method.
8171         <m_obstack>: Rename from obstack; now private.
8172         * psymtab.c (psymtab_storage): Update.
8173         * dwarf2read.c (create_addrmap_from_index)
8174         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8175         Update.
8176
8177 2019-01-10  Tom Tromey  <tom@tromey.com>
8178
8179         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8180         * objfiles.h (objfile::reset_psymtabs): New method.
8181
8182 2019-01-10  Tom Tromey  <tom@tromey.com>
8183
8184         * symmisc.c (print_symbol_bcache_statistics): Update.
8185         (print_objfile_statistics): Update.
8186         * symfile.c (reread_symbols): Update.
8187         * psymtab.h (class psymtab_storage): New.
8188         * psymtab.c (psymtab_storage): New constructor.
8189         (~psymtab_storage): New destructor.
8190         (require_partial_symbols): Update.
8191         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8192         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8193         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8194         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8195         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8196         (start_psymtab_common, end_psymtab_common)
8197         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8198         (allocate_psymtab): Update.
8199         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8200         Update.
8201         (dump_psymtab_addrmap, maintenance_print_psymbols)
8202         (maintenance_check_psymtabs): Update.
8203         (class objfile_psymtabs): Move to objfiles.h.
8204         * psympriv.h (discard_psymtab): Now inline.
8205         (psymtab_discarder::psymtab_discarder): Update.
8206         (psymtab_discarder::~psymtab_discarder): Update.
8207         (ALL_OBJFILE_PSYMTABS): Rewrite.
8208         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8209         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8210         Remove fields.
8211         <partial_symtabs>: New field.
8212         (class objfile_psymtabs): Move from psymtab.h.  Update.
8213         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8214         psymbol_cache.
8215         (objfile::~objfile): Don't destroy psymbol_cache.
8216         * mdebugread.c (parse_partial_symbols): Update.
8217         * dwarf2read.c (create_addrmap_from_index)
8218         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8219         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8220         (add_partial_subprogram, dwarf2_ranges_read): Update.
8221         * dwarf-index-write.c (write_address_map)
8222         (write_one_signatured_type, recursively_write_psymbols)
8223         (class debug_names, class debug_names, write_psymtabs_to_index):
8224         Update.
8225
8226 2019-01-10  Tom Tromey  <tom@tromey.com>
8227
8228         * symtab.h (SYMBOL_SET_NAMES): Update.
8229         (symbol_set_names): Update.
8230         (MSYMBOL_SET_NAMES): Update.
8231         * symtab.c (symbol_set_names): Change argument to be an
8232         objfile_per_bfd_storage.
8233         * psymtab.c (add_psymbol_to_bcache): Update.
8234         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8235
8236 2019-01-10  Tom Tromey  <tom@tromey.com>
8237
8238         * symtab.c (create_demangled_names_hash): Change argument to be an
8239         objfile_per_bfd_storage.
8240         (symbol_set_names): Update.
8241
8242 2019-01-10  Tom Tromey  <tom@tromey.com>
8243
8244         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8245         init_psymbol_list.
8246         * psymtab.c (init_psymbol_list): Do nothing if already called.
8247         * psympriv.h (init_psymbol_list): Add comment.
8248         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8249         init_psymbol_list.
8250         * dbxread.c (dbx_symfile_read): Unconditionally call
8251         init_psymbol_list.
8252
8253 2019-01-10  Tom Tromey  <tom@tromey.com>
8254
8255         * xcoffread.c (scan_xcoff_symtab): Update.
8256         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8257         "where".
8258         * mdebugread.c (parse_partial_symbols)
8259         (handle_psymbol_enumerators): Update.
8260         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8261         * dbxread.c (read_dbx_symtab): Update.
8262         * psympriv.h (psymbol_placement): New enum.
8263         (add_psymbol_to_list): Update.
8264
8265 2019-01-10  Tom Tromey  <tom@tromey.com>
8266
8267         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8268         static_psymbols parameters.
8269         (scan_xcoff_symtab): Update.
8270         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8271         static_psymbols parameters.
8272         * psympriv.h (start_psymtab_common): Update.
8273         * mdebugread.c (parse_partial_symbols): Update.
8274         * dwarf2read.c (create_partial_symtab): Update.
8275         * dbxread.c (read_dbx_symtab): Update.
8276         (start_psymtab): Remove global_psymbols and static_psymbols
8277         parameters.
8278
8279 2019-01-10  Tom Tromey  <tom@tromey.com>
8280
8281         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8282         * psymtab.c (allocate_psymtab): Add comment.
8283         * psympriv.h (allocate_psymtab): Add comment.
8284         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8285         initializations.
8286         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8287
8288 2019-01-10  Tom Tromey  <tom@tromey.com>
8289
8290         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8291         Don't declare.
8292         * mipsread.c: Include mdebugread.h.
8293         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8294         Declare.
8295         * elfread.c: Include mdebugread.h.
8296
8297 2019-01-09  Tom Tromey  <tom@tromey.com>
8298
8299         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8300         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8301         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8302         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8303         (psym_lookup_symbol, psym_find_last_source_symtab)
8304         (psym_forget_cached_source_info, psym_print_stats)
8305         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8306         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8307         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8308         (psym_find_compunit_symtab_by_address)
8309         (maintenance_print_psymbols, maintenance_info_psymtabs)
8310         (maintenance_check_psymtabs): Use ranged for.
8311         * psymtab.h (class objfile_psymtabs): New.
8312         (require_partial_symbols): Return objfile_psymtabs.
8313         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8314
8315 2019-01-09  Tom Tromey  <tom@tromey.com>
8316
8317         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8318         (find_pc_mapped_section, list_overlays_command)
8319         (map_overlay_command, unmap_overlay_command)
8320         (simple_overlay_update): Use all_objfiles.
8321         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8322         * printcmd.c (info_symbol_command): Use all_objfiles.
8323         * objfiles.h (ALL_OBJSECTIONS): Remove.
8324         * maint.c (maintenance_translate_address): Use all_objfiles.
8325         * gcore.c (gcore_create_callback): Use all_objfiles.
8326         (objfile_find_memory_regions): Likewise.
8327
8328 2019-01-09  Tom Tromey  <tom@tromey.com>
8329
8330         * symtab.c (find_line_symtab, info_sources_command)
8331         (make_source_files_completion_list): Use objfile_compunits.
8332         * source.c (select_source_symtab): Use objfile_compunits.
8333         * objfiles.h (struct objfile): Update comment.
8334         (ALL_OBJFILES): Remove.
8335         (ALL_FILETABS): Remove.
8336         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8337         objfile_compunits.
8338
8339 2019-01-09  Tom Tromey  <tom@tromey.com>
8340
8341         * symmisc.c (print_objfile_statistics, dump_objfile)
8342         (maintenance_print_symbols): Use compunit_filetabs.
8343         * source.c (forget_cached_source_info_for_objfile): Use
8344         compunit_filetabs.
8345         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8346         (ALL_FILETABS): Use compunit_filetabs.
8347         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8348         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8349
8350 2019-01-09  Tom Tromey  <tom@tromey.com>
8351
8352         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8353         (compunit_filetabs): New.
8354         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8355         compunit_filetabs.
8356         (info_sources_command, make_source_files_completion_list): Remove
8357         declaration.
8358         * symmisc.c (print_objfile_statistics, dump_objfile)
8359         (maintenance_print_symbols): Remove declaration.
8360         (maintenance_info_symtabs): Use compunit_filetabs.
8361         (maintenance_info_line_tables): Likewise.
8362         * source.c (select_source_symtab): Change local variable name.
8363         (forget_cached_source_info_for_objfile): Remove declaration.
8364         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8365         * objfiles.c (objfile_relocate1): Remove declaration.
8366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8367         declaration.
8368         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8369         * coffread.c (coff_symtab_read): Remove declaration.
8370         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8371         compunit_filetabs.
8372
8373 2019-01-09  Tom Tromey  <tom@tromey.com>
8374
8375         * symtab.c (lookup_objfile_from_block)
8376         (find_pc_sect_compunit_symtab, search_symbols)
8377         (default_collect_symbol_completion_matches_break_on): Use
8378         objfile_compunits.
8379         * objfiles.h (ALL_COMPUNITS): Remove.
8380         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8381         * cp-support.c (add_symbol_overload_list_qualified): Use
8382         objfile_compunits.
8383         * ada-lang.c (ada_collect_symbol_completion_matches)
8384         (ada_add_global_exceptions): Use objfile_compunits.
8385
8386 2019-01-09  Tom Tromey  <tom@tromey.com>
8387
8388         * source.c (select_source_symtab)
8389         (forget_cached_source_info_for_objfile): Remove declaration.
8390         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8391         declaration.
8392         * maint.c (count_symtabs_and_blocks): Remove declaration.
8393         * cp-support.c (add_symbol_overload_list_qualified): Remove
8394         declaration.
8395         * coffread.c (coff_symtab_read): Remove declaration.
8396         * symtab.c (lookup_symbol_in_objfile_symtabs)
8397         (basic_lookup_transparent_type_1): Use objfile_compunits.
8398         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8399         (info_sources_command, search_symbols)
8400         (default_collect_symbol_completion_matches_break_on)
8401         (make_source_files_completion_list): Remove declaration.
8402         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8403         (ada_collect_symbol_completion_matches)
8404         (ada_add_global_exceptions): Remove declaration.
8405         * linespec.c (iterate_over_all_matching_symtabs): Use
8406         objfile_compunits.
8407         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8408         (class objfile_compunits): New.
8409         (ALL_COMPUNITS): Use objfile_compunits.
8410         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8411         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8412         objfile_compunits.
8413         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8414
8415 2019-01-09  Tom Tromey  <tom@tromey.com>
8416
8417         * symtab.c (search_symbols)
8418         (default_collect_symbol_completion_matches_break_on): Use
8419         objfile_msymbols.
8420         * ada-lang.c (ada_lookup_simple_minsym)
8421         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8422         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8423         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8424         objfile_msymbols.
8425         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8426         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8427         * objc-lang.c (find_methods): Use objfile_msymbols.
8428         (info_selectors_command, info_classes_command): Likewise.
8429         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8430         * objfiles.h (class objfile_msymbols): New.
8431         (ALL_OBJFILE_MSYMBOLS): Remove.
8432         (ALL_MSYMBOLS): Remove.
8433
8434 2019-01-09  Tom Tromey  <tom@tromey.com>
8435
8436         * common/next-iterator.h (next_adapter): Add Iterator template
8437         parameter.
8438         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8439         (class all_objfiles_safe): New.
8440         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8441         * objfiles.c (put_objfile_before): Update comment.
8442         (add_separate_debug_objfile): Likewise.
8443         (free_all_objfiles): Use all_objfiles_safe.
8444         (objfile_purge_solibs): Likewise.
8445
8446 2019-01-09  Tom Tromey  <tom@tromey.com>
8447
8448         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8449         (expand_symtab_containing_pc, lookup_static_symbol)
8450         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8451         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8452         all_objfiles.
8453         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8454         * breakpoint.c (create_overlay_event_breakpoint)
8455         (create_longjmp_master_breakpoint)
8456         (create_std_terminate_master_breakpoint)
8457         (create_exception_master_breakpoint): Use all_objfiles.
8458         * linux-thread-db.c (try_thread_db_load_from_pdir)
8459         (has_libpthread): Use all_objfiles.
8460         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8461         * linespec.c (iterate_over_all_matching_symtabs)
8462         (search_minsyms_for_name): Use all_objfiles.
8463         * maint.c (maintenance_info_sections): Use all_objfiles.
8464         * main.c (captured_main_1): Use all_objfiles.
8465         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8466         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8467         * guile/scm-pretty-print.c
8468         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8469         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8470         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8471         (maintenance_print_msymbols): Use all_objfiles.
8472         * source.c (select_source_symtab): Use all_objfiles.
8473         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8474         * symfile.c (remove_symbol_file_command)
8475         (expand_symtabs_matching, map_symbol_filenames): Use
8476         all_objfiles.
8477         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8478         all_objfiles.
8479         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8480         * objc-lang.c (find_methods): Use all_objfiles.
8481         * objfiles.c (have_partial_symbols, have_full_symbols)
8482         (have_minimal_symbols, qsort_cmp)
8483         (default_iterate_over_objfiles_in_search_order): Use
8484         all_objfiles.
8485         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8486         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8487         (maintenance_check_psymtabs): Use all_objfiles.
8488         (ALL_PSYMTABS): Remove.
8489         * compile/compile-object-run.c (do_module_cleanup): Use
8490         all_objfiles.
8491         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8492         * cp-support.c (add_symbol_overload_list_qualified): Use
8493         all_objfiles.
8494         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8495         Use all_objfiles.
8496         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8497         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8498         all_objfiles.
8499         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8500         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8501         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8502         Uses all_objfiles.
8503         * solib.c (solib_read_symbols): Use all_objfiles
8504
8505 2019-01-09  Tom Tromey  <tom@tromey.com>
8506
8507         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8508         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8509         all_objfiles.
8510         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8511         * symmisc.c (print_symbol_bcache_statistics)
8512         (print_objfile_statistics, maintenance_print_objfiles)
8513         (maintenance_info_symtabs, maintenance_check_symtabs)
8514         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8515         all_objfiles.
8516         * source.c (forget_cached_source_info): Use all_objfiles.
8517         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8518         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8519         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8520         * objfiles.c (update_section_map): Use all_objfiles.
8521         (shared_objfile_contains_address_p): Likewise.
8522         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8523         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8524
8525 2019-01-09  Tom Tromey  <tom@tromey.com>
8526
8527         * common/next-iterator.h: New file.
8528         * objfiles.h (class all_objfiles): New.
8529         (struct objfile_iterator): New.
8530
8531 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8532
8533         * NEWS: Move the description of the changed "frame", "select-frame",
8534          and "info frame" commands to the Changed commands section.
8535
8536 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8537
8538         * gdbtypes.c (check_stub_method_group): Remove handling of old
8539         mangling schemes.
8540         * linespec.c (find_methods): Likewise.
8541         * stabsread.c (read_member_functions): Likewise.
8542         * valops.c (search_struct_method): Likewise.
8543         (value_struct_elt_for_reference): Likewise.
8544         * NEWS: Mention this change.
8545
8546 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8547
8548         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8549         print_source_lines.
8550         * source.c (print_source_lines_base): Update line number check.
8551         (print_source_lines): New function.
8552         (source_lines_range::source_lines_range): New function.
8553         * source.h (class source_lines_range): New class.
8554         (print_source_lines): New declaration.
8555
8556 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8557
8558         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8559
8560 2019-01-08  Tom Tromey  <tom@tromey.com>
8561             Simon Marchi  <simon.marchi@ericsson.com>
8562
8563         PR gdb/24060
8564         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8565         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8566         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8567         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8568         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8569         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8570
8571 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8572
8573         * source.c (select_source_symtab): Move header comment to
8574         declaration in source.h.
8575         (forget_cached_source_info_for_objfile): Likewise.
8576         (forget_cached_source_info): Likewise.
8577         (identify_source_line): Likewise.
8578         * source.h (identify_source_line): Move declaration from symtab.h
8579         and add comment from source.c
8580         (print_source_lines): Likewise.
8581         (forget_cached_source_info_for_objfile): Likewise.
8582         (forget_cached_source_info): Likewise.
8583         (select_source_symtab): Likewise.
8584         (enum print_source_lines_flag): Move definition from symtab.h.
8585         * symtab.h (identify_source_line): Move declaration to source.h.
8586         (print_source_lines): Likewise.
8587         (forget_cached_source_info_for_objfile): Likewise.
8588         (forget_cached_source_info): Likewise.
8589         (select_source_symtab): Likewise.
8590         (enum print_source_lines_flag): Move definition to source.h.
8591         * tui/tui-hooks.c: Add 'source.h' include.
8592
8593 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8594
8595         * source.c (print_source_lines_base): Handle requests to print
8596         reverse line number sequences, and guard against empty lines
8597         string.
8598
8599 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8600
8601         * source.c (print_source_lines_base): Fix skip of '\r' if next
8602         character is '\n'.
8603
8604 2019-01-06  Tom Tromey  <tom@tromey.com>
8605
8606         * c-exp.y (struct c_parse_state) <macro_original_text,
8607         expansion_obstack>: New member.
8608         (macro_original_text, expansion_obstack): Remove globals.
8609         (scan_macro_expansion, scanning_macro_expansion)
8610         (finished_macro_expansion): Update.
8611         (scan_macro_cleanup): Remove.
8612         (yylex, c_parse): Update.
8613
8614 2019-01-06  Tom Tromey  <tom@tromey.com>
8615
8616         * c-exp.y (struct c_parse_state) <strings>: New member.
8617         (operator_stoken): Update.
8618
8619 2019-01-06  Tom Tromey  <tom@tromey.com>
8620
8621         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8622         (union type_stack_elt) <typelist_val>: Now a pointer to
8623         std::vector.
8624         (type_stack_cleanup): Don't declare.
8625         (push_typelist): Update.
8626         * parse.c (pop_typelist): Return a std::vector.
8627         (push_typelist): Take a std::vector.
8628         (follow_types): Update.  Do not free args.
8629         (type_stack_cleanup): Remove.
8630         * c-exp.y (struct c_parse_state): New.
8631         (cpstate): New global.
8632         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8633         (nonempty_typelist): Update.
8634         (func_mod): Create a new vector.
8635         (c_parse): Create a c_parse_state.
8636         (check_parameter_typelist): Do not delete params.
8637         (function_method): Update.  Do not delete type_list.
8638
8639 2019-01-06  Tom Tromey  <tom@tromey.com>
8640
8641         PR gdb/28155:
8642         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8643         check_typedef.
8644         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8645         (print_return_value): Likewise.
8646
8647 2019-01-05  Tom Tromey  <tom@tromey.com>
8648
8649         * contrib/cleanup_check.py: Remove.
8650         * contrib/gcc-with-excheck: Remove.
8651         * contrib/exsummary.py: Remove.
8652         * contrib/excheck.py: Remove.
8653
8654 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8655
8656         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8657         NULL. Initialize tpprev to NULL instead of assigning it
8658         to NULL on the next statement.
8659         * windows-nat.c (windows_delete_thread): Remove check for
8660         main_thread_id before printing thread exit notifications.
8661         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8662         Remove thread ID check against main_thread_id.
8663         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8664         windows_delete_thread.
8665         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8666
8667 2019-01-04  Tom Tromey  <tom@tromey.com>
8668
8669         * compile/compile.c (_initialize_compile): Use upper case for
8670         metasyntactic variables.
8671         * symmisc.c (_initialize_symmisc): Use upper case for
8672         metasyntactic variables.
8673         * psymtab.c (_initialize_psymtab): Use upper case for
8674         metasyntactic variables.
8675         * demangle.c (demangle_command): Use upper case for metasyntactic
8676         variables.
8677         (_initialize_demangler): Likewise.
8678         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8679         variables.
8680
8681 2019-01-03  Tom Tromey  <tom@tromey.com>
8682
8683         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8684
8685 2019-01-03  Tom Tromey  <tom@tromey.com>
8686
8687         * python/py-symtab.c (salpy_str): Update.
8688         (struct salpy_sal_object) <symtab>: Now a PyObject.
8689         (salpy_dealloc): Update.
8690         (del_objfile_sal): Use gdbpy_ref.
8691
8692 2019-01-03  Tom Tromey  <tom@tromey.com>
8693
8694         * python/py-type.c (convert_field): Use new_reference.  Return
8695         gdbpy_ref.
8696         (make_fielditem): Return gdbpy_ref.
8697         (typy_fields): Update.
8698         (typy_getitem): Update.
8699         (field_name): Return gdbpy_ref.  Use new_reference.
8700         (typy_iterator_iternext): Update.
8701
8702 2019-01-03  Tom Tromey  <tom@tromey.com>
8703
8704         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8705
8706 2019-01-03  Tom Tromey  <tom@tromey.com>
8707
8708         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8709         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8710         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8711         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8712         (pspy_set_type_printers): Likewise.
8713         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8714         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8715         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8716         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8717         (objfpy_set_type_printers): Likewise.
8718
8719 2019-01-03  Tom Tromey  <tom@tromey.com>
8720
8721         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8722         (gdbpy_print_stack): Use gdbpy_err_fetch.
8723         * python/python-internal.h (class gdbpy_err_fetch): New class.
8724         (class gdbpy_enter) <m_error_type, m_error_value,
8725         m_error_traceback>: Remove.
8726         <m_error>: New member.
8727         (gdbpy_exception_to_string): Don't declare.
8728         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8729         * python/py-value.c (convert_value_from_python): Use
8730         gdbpy_err_fetch.
8731         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8732         gdbpy_exception_to_string.
8733         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8734         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8735         gdbpy_err_fetch.
8736
8737 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * linux-nat.c (delete_lwp_cleanup): Delete.
8740         (struct lwp_deleter): New struct.
8741         (lwp_info_up): New typedef.
8742         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8743         lwp_info_up.
8744
8745 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8746
8747         * linux-fork.c (class scoped_switch_fork_info): New class.
8748         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8749
8750 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8751
8752         * valops.c (find_overload_match): Remove use of null_cleanup, and
8753         calls to do_cleanups.
8754
8755 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8756
8757         * compile/compile-cplus-types.c
8758         (compile_cplus_instance::decl_name): Handle changes to
8759         cp_func_name.
8760         * cp-support.c (cp_func_name): Update header comment, update
8761         return type.
8762         * cp-support.h (cp_func_name): Update return type in declaration.
8763         * valops.c (find_overload_match): Move temp_func local to top
8764         level of function and change its type.  Use temp_func to hold and
8765         delete temporary string obtained from cp_func_name.
8766
8767 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8768
8769         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8770         gdb::char_vector, remove cleanup, and update uses of `msg`.
8771
8772 2019-01-03  Jim Wilson  <jimw@sifive.com>
8773
8774         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8775
8776 2019-01-02  Tom Tromey  <tom@tromey.com>
8777
8778         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8779         (tdesc_parse_xml): Remove cleanups.
8780         * target-descriptions.h (make_cleanup_free_target_description):
8781         Don't declare.
8782         (target_desc_deleter): New struct.
8783         (target_desc_up): New typedef.
8784         * target-descriptions.c (target_desc_deleter::operator()): Rename
8785         from free_target_description.
8786         (make_cleanup_free_target_description): Remove.
8787
8788 2019-01-02  Tom Tromey  <tom@tromey.com>
8789
8790         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8791         constructor, destructor.
8792         (linespec_parser): Remove typedef.
8793         (~linespec_parser): Rename from linespec_parser_delete.
8794         (linespec_lex_to_end, linespec_complete_label)
8795         (linespec_complete): Update.
8796         (decode_line_full): Remove cleanups.
8797         (decode_line_1): Update.
8798
8799 2019-01-02  Tom Tromey  <tom@tromey.com>
8800
8801         * python/python-internal.h (inferior_to_inferior_object): Change
8802         return type.
8803         * python/py-exitedevent.c (create_exited_event_object): Update.
8804         * python/py-inferior.c (inferior_to_inferior_object): Return
8805         gdbpy_ref.
8806         (python_new_inferior, python_inferior_deleted)
8807         (thread_to_thread_object, delete_thread_object)
8808         (build_inferior_list, gdbpy_selected_inferior): Update.
8809         * python/py-infthread.c (create_thread_object): Update.  Also fail
8810         if inferior_to_inferior_object fails.
8811
8812 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8813
8814         * inferior.h (class inferior) <displaced_step_state>: New field.
8815         * infrun.h (struct displaced_step_state): Move here from
8816         infrun.c.  Initialize fields, add constructor.
8817         <inf>: Remove field.
8818         <reset>: New method.
8819         * infrun.c (struct displaced_step_inferior_state): Move to
8820         infrun.h.
8821         (displaced_step_inferior_states): Remove.
8822         (get_displaced_stepping_state): Adust.
8823         (displaced_step_in_progress_any_inferior): Adjust.
8824         (displaced_step_in_progress_thread): Adjust.
8825         (displaced_step_in_progress): Adjust.
8826         (add_displaced_stepping_state): Remove.
8827         (get_displaced_step_closure_by_addr): Adjust.
8828         (remove_displaced_stepping_state): Remove.
8829         (infrun_inferior_exit): Call displaced_step_state.reset.
8830         (use_displaced_stepping): Don't check for NULL.
8831         (displaced_step_prepare_throw): Call
8832         get_displaced_stepping_state.
8833         (displaced_step_fixup): Don't check for NULL.
8834         (prepare_for_detach): Don't check for NULL.
8835
8836 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8837
8838         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8839          in case of call that did not complete.
8840
8841 2019-01-02  Andrey Utkin  <autkin@undo.io>
8842
8843         * symfile.c (find_separate_debug_file): Fix search of debug files for
8844         remote debuggee.
8845
8846 2019-01-02  Tom Tromey  <tom@tromey.com>
8847
8848         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8849         indentation.
8850         * python/py-frame.c (frapy_older): Remove cast.
8851         (frapy_newer): Likewise.
8852         * python/py-breakpoint.c (local_setattro): Remove cast.
8853         * python/py-arch.c (archpy_name): Remove local variable.
8854         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8855
8856 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8857
8858         * unittests/basic_string_view/element_access/char/empty.cc:
8859         Fix year range in copyright header.
8860
8861 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8862
8863         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8864         Delete.
8865         <operator==>: Update with for removed field.
8866         <hash>: Likewise.
8867         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8868         <isa_features>: ...this.
8869         <abi_features>: New field.
8870         (riscv_isa_flen): Update comment.
8871         (riscv_abi_xlen): New declaration.
8872         (riscv_abi_flen): New declaration.
8873         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8874         isa_features.
8875         (riscv_abi_xlen): New function.
8876         (riscv_isa_flen): Update to get answer from isa_features.
8877         (riscv_abi_flen): New function.
8878         (riscv_has_fp_abi): Update to get answer from abi_features.
8879         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8880         xlen and flen.
8881         (riscv_call_info) <xlen, flen>: Update comment.
8882         (riscv_call_arg_struct): Remove invalid assertions
8883         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8884         is removed.
8885         (riscv_gdbarch_init): Gather isa features and abi features
8886         separately, ensure both match on the gdbarch when reusing an old
8887         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8888         a target with 64-bit float hardware.
8889
8890 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8891
8892         * source.c (search_command_helper): Stop reverse search
8893         when line 1 has been searched.
8894
8895 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8896
8897         * record-full.c (record_full_base_target::close): Rewrite
8898         record_full_core_buf_list free logic.
8899
8900 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8901
8902         * break-catch-syscall.c (print_one_catch_syscall): xfree
8903         the last text.
8904
8905 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8906
8907         * top.c (print_gdb_version): Update Copyright year in version
8908         message.
8909
8910 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8911
8912         Update copyright year range in all GDB files.
8913
8914 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8915
8916         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8917
8918 For older changes see ChangeLog-2018.
8919 \f
8920 Local Variables:
8921 mode: change-log
8922 left-margin: 8
8923 fill-column: 74
8924 version-control: never
8925 coding: utf-8
8926 End:
8927