gdb/ChangeLog

   1 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
   2
   3         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
   4         'nat/fork-inferior.o'.
   5         * gnu-nat.c: #include "nat/fork-inferior.h".
   6
   7         * gnu-nat.c (gnu_nat_target::detach): Instead of
   8         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
   9         * gnu-nat.h: #include "inf-child.h".
  10         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  11         'i386_gnu_nat_target::fetch_registers'.
  12         (gnu_store_registers): Rename/move to
  13         'i386_gnu_nat_target::store_registers'.
  14
  15         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  16         * gnu-nat.h (mach_thread_info): New function.
  17         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  18
  19         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  20
  21 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  22
  23         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  24
  25 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  26
  27         * windows-nat.c (windows_add_thread): Add new parameter
  28         "main_thread_p" with default value set to false.  Update
  29         function documentation as well as all callers.
  30         (windows_delete_thread): Likewise.
  31         (fake_create_process): Update call to windows_add_thread.
  32         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  33         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  34         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  35         call to windows_delete_thread.
  36
  37 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  38
  39         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  40
  41 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  42
  43         * symfile.c (find_separate_debug_file): Use canonical path of
  44         sysroot with child_path instead of gdb_sysroot if it is valid.
  45
  46 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  47
  48         * symfile.c (find_separate_debug_file): Use child_path to
  49         determine if an object file is under a sysroot.
  50
  51 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  52
  53         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  54         unittests/child-path-selftests.c.
  55         * common/pathstuff.c (child_path): New function.
  56         * common/pathstuff.h (child_path): New prototype.
  57         * unittests/child-path-selftests.c: New file.
  58
  59 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  60
  61         * symfile.c (find_separate_debug_file): Look for separate debug
  62         files in debug directories under the sysroot.
  63
  64 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  65
  66         * symtab.h (struct minimal_symbol data_p): New const method.
  67         (struct minimal_symbol text_p): Likewise.
  68         * symtab.c (output_source_filename): Use file name style
  69         to print file name.
  70         (print_symbol_info): Likewise.
  71         (print_msymbol_info): Use address style to print addresses.
  72         Use function name style to print executable text symbols.
  73         (expand_symtab_containing_pc): Use data_p.
  74         (find_pc_sect_compunit_symtab): Likewise.
  75
  76 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  77
  78         * breakpoint.c (describe_other_breakpoints): Use address style
  79         to print addresses.
  80         (say_where): Likewise.
  81
  82 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  83
  84         * ada-typeprint.c (print_func_type): Print function name
  85         style to print function name.
  86         * c-typeprint.c (c_print_type_1): Likewise.
  87
  88 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
  89
  90         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
  91         for execve.
  92
  93 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  94
  95         * c-exp.y (direct_abs_decl): Use emplace_back to record the
  96         type_stack.
  97
  98 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
  99
 100         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 101         TYPE_CODE_REF types.
 102
 103 2019-02-08  Jim Wilson  <jimw@sifive.com>
 104
 105         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 106         (riscv_linux_fregset): New.
 107         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 108
 109 2019-02-07  Tom Tromey  <tom@tromey.com>
 110
 111         * thread.c (thread_cancel_execution_command): Update.
 112         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 113         methods.
 114         (struct thread_fsm_ops): Remove.
 115         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 116         (thread_fsm_should_stop, thread_fsm_return_value)
 117         (thread_fsm_set_finished, thread_fsm_finished_p)
 118         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 119         Don't declare.
 120         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 121         * infrun.c (clear_proceed_status_thread)
 122         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 123         (print_stop_event): Update.
 124         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 125         Add constructor.
 126         (step_command_fsm_ops): Remove.
 127         (new_step_command_fsm): Remove.
 128         (step_1): Update.
 129         (step_command_fsm::should_stop): Rename from
 130         step_command_fsm_should_stop.
 131         (step_command_fsm::clean_up): Rename from
 132         step_command_fsm_clean_up.
 133         (step_command_fsm::do_async_reply_reason): Rename from
 134         step_command_fsm_async_reply_reason.
 135         (struct until_next_fsm): Inherit from thread_fsm.  Add
 136         constructor.
 137         (until_next_fsm_ops): Remove.
 138         (new_until_next_fsm): Remove.
 139         (until_next_fsm::should_stop): Rename from
 140         until_next_fsm_should_stop.
 141         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 142         (until_next_fsm::do_async_reply_reason): Rename from
 143         until_next_fsm_async_reply_reason.
 144         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 145         constructor.  Change type of breakpoint.
 146         (finish_command_fsm_ops): Remove.
 147         (new_finish_command_fsm): Remove.
 148         (finish_command_fsm::should_stop): Rename from
 149         finish_command_fsm_should_stop.
 150         (finish_command_fsm::clean_up): Rename from
 151         finish_command_fsm_clean_up.
 152         (finish_command_fsm::return_value): Rename from
 153         finish_command_fsm_return_value.
 154         (finish_command_fsm::do_async_reply_reason): Rename from
 155         finish_command_fsm_async_reply_reason.
 156         (finish_command): Update.
 157         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 158         Add constructor.
 159         (call_thread_fsm_ops): Remove.
 160         (call_thread_fsm::call_thread_fsm): Rename from
 161         new_call_thread_fsm.
 162         (call_thread_fsm::should_stop): Rename from
 163         call_thread_fsm_should_stop.
 164         (call_thread_fsm::should_notify_stop): Rename from
 165         call_thread_fsm_should_notify_stop.
 166         (run_inferior_call, call_function_by_hand_dummy): Update.
 167         * cli/cli-interp.c (should_print_stop_to_console): Update.
 168         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 169         Add constructor.  Change type of location_breakpoint,
 170         caller_breakpoint.
 171         (until_break_fsm_ops): Remove.
 172         (new_until_break_fsm): Remove.
 173         (until_break_fsm::should_stop): Rename from
 174         until_break_fsm_should_stop.
 175         (until_break_fsm::clean_up): Rename from
 176         until_break_fsm_clean_up.
 177         (until_break_fsm::do_async_reply_reason): Rename from
 178         until_break_fsm_async_reply_reason.
 179         (until_break_command): Update.
 180         * thread-fsm.c: Remove.
 181         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 182
 183 2019-02-07  Tom Tromey  <tom@tromey.com>
 184
 185         * yy-remap.h: Add include guard.
 186         * xtensa-tdep.h: Add include guard.
 187         * xcoffread.h: Rename include guard.
 188         * varobj-iter.h: Add include guard.
 189         * tui/tui.h: Rename include guard.
 190         * tui/tui-winsource.h: Rename include guard.
 191         * tui/tui-wingeneral.h: Rename include guard.
 192         * tui/tui-windata.h: Rename include guard.
 193         * tui/tui-win.h: Rename include guard.
 194         * tui/tui-stack.h: Rename include guard.
 195         * tui/tui-source.h: Rename include guard.
 196         * tui/tui-regs.h: Rename include guard.
 197         * tui/tui-out.h: Rename include guard.
 198         * tui/tui-layout.h: Rename include guard.
 199         * tui/tui-io.h: Rename include guard.
 200         * tui/tui-hooks.h: Rename include guard.
 201         * tui/tui-file.h: Rename include guard.
 202         * tui/tui-disasm.h: Rename include guard.
 203         * tui/tui-data.h: Rename include guard.
 204         * tui/tui-command.h: Rename include guard.
 205         * tic6x-tdep.h: Add include guard.
 206         * target/waitstatus.h: Rename include guard.
 207         * target/wait.h: Rename include guard.
 208         * target/target.h: Rename include guard.
 209         * target/resume.h: Rename include guard.
 210         * target-float.h: Rename include guard.
 211         * stabsread.h: Add include guard.
 212         * rs6000-tdep.h: Add include guard.
 213         * riscv-fbsd-tdep.h: Add include guard.
 214         * regformats/regdef.h: Rename include guard.
 215         * record.h: Rename include guard.
 216         * python/python.h: Rename include guard.
 217         * python/python-internal.h: Rename include guard.
 218         * python/py-stopevent.h: Rename include guard.
 219         * python/py-ref.h: Rename include guard.
 220         * python/py-record.h: Rename include guard.
 221         * python/py-record-full.h: Rename include guard.
 222         * python/py-record-btrace.h: Rename include guard.
 223         * python/py-instruction.h: Rename include guard.
 224         * python/py-events.h: Rename include guard.
 225         * python/py-event.h: Rename include guard.
 226         * procfs.h: Add include guard.
 227         * proc-utils.h: Add include guard.
 228         * p-lang.h: Add include guard.
 229         * or1k-tdep.h: Rename include guard.
 230         * observable.h: Rename include guard.
 231         * nto-tdep.h: Rename include guard.
 232         * nat/x86-linux.h: Rename include guard.
 233         * nat/x86-linux-dregs.h: Rename include guard.
 234         * nat/x86-gcc-cpuid.h: Add include guard.
 235         * nat/x86-dregs.h: Rename include guard.
 236         * nat/x86-cpuid.h: Rename include guard.
 237         * nat/ppc-linux.h: Rename include guard.
 238         * nat/mips-linux-watch.h: Rename include guard.
 239         * nat/linux-waitpid.h: Rename include guard.
 240         * nat/linux-ptrace.h: Rename include guard.
 241         * nat/linux-procfs.h: Rename include guard.
 242         * nat/linux-osdata.h: Rename include guard.
 243         * nat/linux-nat.h: Rename include guard.
 244         * nat/linux-namespaces.h: Rename include guard.
 245         * nat/linux-btrace.h: Rename include guard.
 246         * nat/glibc_thread_db.h: Rename include guard.
 247         * nat/gdb_thread_db.h: Rename include guard.
 248         * nat/gdb_ptrace.h: Rename include guard.
 249         * nat/fork-inferior.h: Rename include guard.
 250         * nat/amd64-linux-siginfo.h: Rename include guard.
 251         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 252         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 253         * nat/aarch64-linux.h: Rename include guard.
 254         * nat/aarch64-linux-hw-point.h: Rename include guard.
 255         * mn10300-tdep.h: Add include guard.
 256         * mips-linux-tdep.h: Add include guard.
 257         * mi/mi-parse.h: Rename include guard.
 258         * mi/mi-out.h: Rename include guard.
 259         * mi/mi-main.h: Rename include guard.
 260         * mi/mi-interp.h: Rename include guard.
 261         * mi/mi-getopt.h: Rename include guard.
 262         * mi/mi-console.h: Rename include guard.
 263         * mi/mi-common.h: Rename include guard.
 264         * mi/mi-cmds.h: Rename include guard.
 265         * mi/mi-cmd-break.h: Rename include guard.
 266         * m2-lang.h: Add include guard.
 267         * location.h: Rename include guard.
 268         * linux-record.h: Rename include guard.
 269         * linux-nat.h: Add include guard.
 270         * linux-fork.h: Add include guard.
 271         * i386-darwin-tdep.h: Rename include guard.
 272         * hppa-linux-offsets.h: Add include guard.
 273         * guile/guile.h: Rename include guard.
 274         * guile/guile-internal.h: Rename include guard.
 275         * gnu-nat.h: Rename include guard.
 276         * gdb-stabs.h: Rename include guard.
 277         * frv-tdep.h: Add include guard.
 278         * f-lang.h: Add include guard.
 279         * event-loop.h: Add include guard.
 280         * darwin-nat.h: Rename include guard.
 281         * cp-abi.h: Rename include guard.
 282         * config/sparc/nm-sol2.h: Rename include guard.
 283         * config/nm-nto.h: Rename include guard.
 284         * config/nm-linux.h: Add include guard.
 285         * config/i386/nm-i386gnu.h: Rename include guard.
 286         * config/djgpp/nl_types.h: Rename include guard.
 287         * config/djgpp/langinfo.h: Rename include guard.
 288         * compile/gcc-cp-plugin.h: Add include guard.
 289         * compile/gcc-c-plugin.h: Add include guard.
 290         * compile/compile.h: Rename include guard.
 291         * compile/compile-object-run.h: Rename include guard.
 292         * compile/compile-object-load.h: Rename include guard.
 293         * compile/compile-internal.h: Rename include guard.
 294         * compile/compile-cplus.h: Rename include guard.
 295         * compile/compile-c.h: Rename include guard.
 296         * common/xml-utils.h: Rename include guard.
 297         * common/x86-xstate.h: Rename include guard.
 298         * common/version.h: Rename include guard.
 299         * common/vec.h: Rename include guard.
 300         * common/tdesc.h: Rename include guard.
 301         * common/selftest.h: Rename include guard.
 302         * common/scoped_restore.h: Rename include guard.
 303         * common/scoped_mmap.h: Rename include guard.
 304         * common/scoped_fd.h: Rename include guard.
 305         * common/safe-iterator.h: Rename include guard.
 306         * common/run-time-clock.h: Rename include guard.
 307         * common/refcounted-object.h: Rename include guard.
 308         * common/queue.h: Rename include guard.
 309         * common/ptid.h: Rename include guard.
 310         * common/print-utils.h: Rename include guard.
 311         * common/preprocessor.h: Rename include guard.
 312         * common/pathstuff.h: Rename include guard.
 313         * common/observable.h: Rename include guard.
 314         * common/netstuff.h: Rename include guard.
 315         * common/job-control.h: Rename include guard.
 316         * common/host-defs.h: Rename include guard.
 317         * common/gdb_wait.h: Rename include guard.
 318         * common/gdb_vecs.h: Rename include guard.
 319         * common/gdb_unlinker.h: Rename include guard.
 320         * common/gdb_unique_ptr.h: Rename include guard.
 321         * common/gdb_tilde_expand.h: Rename include guard.
 322         * common/gdb_sys_time.h: Rename include guard.
 323         * common/gdb_string_view.h: Rename include guard.
 324         * common/gdb_splay_tree.h: Rename include guard.
 325         * common/gdb_setjmp.h: Rename include guard.
 326         * common/gdb_ref_ptr.h: Rename include guard.
 327         * common/gdb_optional.h: Rename include guard.
 328         * common/gdb_locale.h: Rename include guard.
 329         * common/gdb_assert.h: Rename include guard.
 330         * common/filtered-iterator.h: Rename include guard.
 331         * common/filestuff.h: Rename include guard.
 332         * common/fileio.h: Rename include guard.
 333         * common/environ.h: Rename include guard.
 334         * common/common-utils.h: Rename include guard.
 335         * common/common-types.h: Rename include guard.
 336         * common/common-regcache.h: Rename include guard.
 337         * common/common-inferior.h: Rename include guard.
 338         * common/common-gdbthread.h: Rename include guard.
 339         * common/common-exceptions.h: Rename include guard.
 340         * common/common-defs.h: Rename include guard.
 341         * common/common-debug.h: Rename include guard.
 342         * common/cleanups.h: Rename include guard.
 343         * common/buffer.h: Rename include guard.
 344         * common/btrace-common.h: Rename include guard.
 345         * common/break-common.h: Rename include guard.
 346         * cli/cli-utils.h: Rename include guard.
 347         * cli/cli-style.h: Rename include guard.
 348         * cli/cli-setshow.h: Rename include guard.
 349         * cli/cli-script.h: Rename include guard.
 350         * cli/cli-interp.h: Rename include guard.
 351         * cli/cli-decode.h: Rename include guard.
 352         * cli/cli-cmds.h: Rename include guard.
 353         * charset-list.h: Add include guard.
 354         * buildsym-legacy.h: Rename include guard.
 355         * bfin-tdep.h: Add include guard.
 356         * ax.h: Rename include guard.
 357         * arm-linux-tdep.h: Add include guard.
 358         * arm-fbsd-tdep.h: Add include guard.
 359         * arch/xtensa.h: Rename include guard.
 360         * arch/tic6x.h: Add include guard.
 361         * arch/i386.h: Add include guard.
 362         * arch/arm.h: Rename include guard.
 363         * arch/arm-linux.h: Rename include guard.
 364         * arch/arm-get-next-pcs.h: Rename include guard.
 365         * arch/amd64.h: Add include guard.
 366         * arch/aarch64-insn.h: Rename include guard.
 367         * arch-utils.h: Rename include guard.
 368         * annotate.h: Add include guard.
 369         * amd64-darwin-tdep.h: Rename include guard.
 370         * aarch64-linux-tdep.h: Add include guard.
 371         * aarch64-fbsd-tdep.h: Add include guard.
 372         * aarch32-linux-nat.h: Add include guard.
 373
 374 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 375
 376         * macrotab.c (macro_define_internal): New function that
 377         factorizes macro_define_object_internal and macro_define_function
 378         code.
 379         (macro_define_object_internal): Use macro_define_internal.
 380         (macro_define_function): Likewise.
 381
 382 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 383
 384         * macrocmd.c (extract_identifier): Return
 385         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 386         callers.
 387
 388 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 389
 390         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 391
 392 2019-02-05  Tom Tromey  <tom@tromey.com>
 393
 394         * target.c (target_stack::unpush): Move assertion earlier.
 395
 396 2019-01-30  Tom Tromey  <tom@tromey.com>
 397
 398         PR python/23615:
 399         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 400         (gdbpy_parse_and_eval): Likewise.
 401         * python/python-internal.h (gdbpy_allow_threads): New class.
 402
 403 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 404
 405         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 406         (aarch64_fbsd_fpregmap): Move earlier.
 407         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 408         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 409         instead of individual calls to trad_frame_set_reg_addr.
 410         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 411         earlier.
 412         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 413         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 414         instead of individual calls to trad_frame_set_reg_addr.
 415
 416 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 417
 418         * CONTRIBUTE: Replace contribution list with wiki link.
 419
 420 2019-01-25  Tom Tromey  <tom@tromey.com>
 421
 422         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 423
 424 2019-01-25  Tom Tromey  <tom@tromey.com>
 425
 426         * xtensa-linux-nat.c: Fix common/ includes.
 427         * xml-support.h: Fix common/ includes.
 428         * xml-support.c: Fix common/ includes.
 429         * x86-linux-nat.c: Fix common/ includes.
 430         * windows-nat.c: Fix common/ includes.
 431         * varobj.h: Fix common/ includes.
 432         * varobj.c: Fix common/ includes.
 433         * value.c: Fix common/ includes.
 434         * valops.c: Fix common/ includes.
 435         * utils.c: Fix common/ includes.
 436         * unittests/xml-utils-selftests.c: Fix common/ includes.
 437         * unittests/utils-selftests.c: Fix common/ includes.
 438         * unittests/unpack-selftests.c: Fix common/ includes.
 439         * unittests/tracepoint-selftests.c: Fix common/ includes.
 440         * unittests/style-selftests.c: Fix common/ includes.
 441         * unittests/string_view-selftests.c: Fix common/ includes.
 442         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 443         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 444         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 445         * unittests/rsp-low-selftests.c: Fix common/ includes.
 446         * unittests/parse-connection-spec-selftests.c: Fix common/
 447         includes.
 448         * unittests/optional-selftests.c: Fix common/ includes.
 449         * unittests/offset-type-selftests.c: Fix common/ includes.
 450         * unittests/observable-selftests.c: Fix common/ includes.
 451         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 452         * unittests/memrange-selftests.c: Fix common/ includes.
 453         * unittests/memory-map-selftests.c: Fix common/ includes.
 454         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 455         * unittests/function-view-selftests.c: Fix common/ includes.
 456         * unittests/environ-selftests.c: Fix common/ includes.
 457         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 458         * unittests/common-utils-selftests.c: Fix common/ includes.
 459         * unittests/cli-utils-selftests.c: Fix common/ includes.
 460         * unittests/array-view-selftests.c: Fix common/ includes.
 461         * ui-file.c: Fix common/ includes.
 462         * tui/tui-io.c: Fix common/ includes.
 463         * tracepoint.h: Fix common/ includes.
 464         * tracepoint.c: Fix common/ includes.
 465         * tracefile-tfile.c: Fix common/ includes.
 466         * top.h: Fix common/ includes.
 467         * top.c: Fix common/ includes.
 468         * thread.c: Fix common/ includes.
 469         * target/waitstatus.h: Fix common/ includes.
 470         * target/waitstatus.c: Fix common/ includes.
 471         * target.h: Fix common/ includes.
 472         * target.c: Fix common/ includes.
 473         * target-memory.c: Fix common/ includes.
 474         * target-descriptions.c: Fix common/ includes.
 475         * symtab.h: Fix common/ includes.
 476         * symfile.c: Fix common/ includes.
 477         * stap-probe.c: Fix common/ includes.
 478         * spu-linux-nat.c: Fix common/ includes.
 479         * sparc-nat.c: Fix common/ includes.
 480         * source.c: Fix common/ includes.
 481         * solib.c: Fix common/ includes.
 482         * solib-target.c: Fix common/ includes.
 483         * ser-unix.c: Fix common/ includes.
 484         * ser-tcp.c: Fix common/ includes.
 485         * ser-pipe.c: Fix common/ includes.
 486         * ser-base.c: Fix common/ includes.
 487         * selftest-arch.c: Fix common/ includes.
 488         * s12z-tdep.c: Fix common/ includes.
 489         * rust-exp.y: Fix common/ includes.
 490         * rs6000-aix-tdep.c: Fix common/ includes.
 491         * riscv-tdep.c: Fix common/ includes.
 492         * remote.c: Fix common/ includes.
 493         * remote-notif.h: Fix common/ includes.
 494         * remote-fileio.h: Fix common/ includes.
 495         * remote-fileio.c: Fix common/ includes.
 496         * regcache.h: Fix common/ includes.
 497         * regcache.c: Fix common/ includes.
 498         * record-btrace.c: Fix common/ includes.
 499         * python/python.c: Fix common/ includes.
 500         * python/py-type.c: Fix common/ includes.
 501         * python/py-inferior.c: Fix common/ includes.
 502         * progspace.h: Fix common/ includes.
 503         * producer.c: Fix common/ includes.
 504         * procfs.c: Fix common/ includes.
 505         * proc-api.c: Fix common/ includes.
 506         * printcmd.c: Fix common/ includes.
 507         * ppc-linux-nat.c: Fix common/ includes.
 508         * parser-defs.h: Fix common/ includes.
 509         * osdata.c: Fix common/ includes.
 510         * obsd-nat.c: Fix common/ includes.
 511         * nat/x86-linux.c: Fix common/ includes.
 512         * nat/x86-linux-dregs.c: Fix common/ includes.
 513         * nat/x86-dregs.h: Fix common/ includes.
 514         * nat/x86-dregs.c: Fix common/ includes.
 515         * nat/ppc-linux.c: Fix common/ includes.
 516         * nat/mips-linux-watch.h: Fix common/ includes.
 517         * nat/mips-linux-watch.c: Fix common/ includes.
 518         * nat/linux-waitpid.c: Fix common/ includes.
 519         * nat/linux-ptrace.h: Fix common/ includes.
 520         * nat/linux-ptrace.c: Fix common/ includes.
 521         * nat/linux-procfs.c: Fix common/ includes.
 522         * nat/linux-personality.c: Fix common/ includes.
 523         * nat/linux-osdata.c: Fix common/ includes.
 524         * nat/linux-namespaces.c: Fix common/ includes.
 525         * nat/linux-btrace.h: Fix common/ includes.
 526         * nat/linux-btrace.c: Fix common/ includes.
 527         * nat/fork-inferior.c: Fix common/ includes.
 528         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 529         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 530         * nat/aarch64-linux.c: Fix common/ includes.
 531         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 532         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 533         * namespace.h: Fix common/ includes.
 534         * mips-linux-tdep.c: Fix common/ includes.
 535         * minsyms.c: Fix common/ includes.
 536         * mi/mi-parse.h: Fix common/ includes.
 537         * mi/mi-main.c: Fix common/ includes.
 538         * mi/mi-cmd-env.c: Fix common/ includes.
 539         * memrange.h: Fix common/ includes.
 540         * memattr.c: Fix common/ includes.
 541         * maint.h: Fix common/ includes.
 542         * maint.c: Fix common/ includes.
 543         * main.c: Fix common/ includes.
 544         * machoread.c: Fix common/ includes.
 545         * location.c: Fix common/ includes.
 546         * linux-thread-db.c: Fix common/ includes.
 547         * linux-nat.c: Fix common/ includes.
 548         * linux-fork.c: Fix common/ includes.
 549         * inline-frame.c: Fix common/ includes.
 550         * infrun.c: Fix common/ includes.
 551         * inflow.c: Fix common/ includes.
 552         * inferior.h: Fix common/ includes.
 553         * inferior.c: Fix common/ includes.
 554         * infcmd.c: Fix common/ includes.
 555         * inf-ptrace.c: Fix common/ includes.
 556         * inf-child.c: Fix common/ includes.
 557         * ia64-linux-nat.c: Fix common/ includes.
 558         * i387-tdep.c: Fix common/ includes.
 559         * i386-tdep.c: Fix common/ includes.
 560         * i386-linux-tdep.c: Fix common/ includes.
 561         * i386-linux-nat.c: Fix common/ includes.
 562         * i386-go32-tdep.c: Fix common/ includes.
 563         * i386-fbsd-tdep.c: Fix common/ includes.
 564         * i386-fbsd-nat.c: Fix common/ includes.
 565         * guile/scm-type.c: Fix common/ includes.
 566         * guile/guile.c: Fix common/ includes.
 567         * go32-nat.c: Fix common/ includes.
 568         * gnu-nat.c: Fix common/ includes.
 569         * gdbthread.h: Fix common/ includes.
 570         * gdbarch-selftests.c: Fix common/ includes.
 571         * gdb_usleep.c: Fix common/ includes.
 572         * gdb_select.h: Fix common/ includes.
 573         * gdb_bfd.c: Fix common/ includes.
 574         * gcore.c: Fix common/ includes.
 575         * fork-child.c: Fix common/ includes.
 576         * findvar.c: Fix common/ includes.
 577         * fbsd-nat.c: Fix common/ includes.
 578         * event-top.c: Fix common/ includes.
 579         * event-loop.c: Fix common/ includes.
 580         * dwarf2read.c: Fix common/ includes.
 581         * dwarf2loc.c: Fix common/ includes.
 582         * dwarf2-frame.c: Fix common/ includes.
 583         * dwarf-index-cache.c: Fix common/ includes.
 584         * dtrace-probe.c: Fix common/ includes.
 585         * disasm-selftests.c: Fix common/ includes.
 586         * defs.h: Fix common/ includes.
 587         * csky-tdep.c: Fix common/ includes.
 588         * cp-valprint.c: Fix common/ includes.
 589         * cp-support.h: Fix common/ includes.
 590         * cp-support.c: Fix common/ includes.
 591         * corelow.c: Fix common/ includes.
 592         * completer.h: Fix common/ includes.
 593         * completer.c: Fix common/ includes.
 594         * compile/compile.c: Fix common/ includes.
 595         * compile/compile-loc2c.c: Fix common/ includes.
 596         * compile/compile-cplus-types.c: Fix common/ includes.
 597         * compile/compile-cplus-symbols.c: Fix common/ includes.
 598         * command.h: Fix common/ includes.
 599         * cli/cli-dump.c: Fix common/ includes.
 600         * cli/cli-cmds.c: Fix common/ includes.
 601         * charset.c: Fix common/ includes.
 602         * build-id.c: Fix common/ includes.
 603         * btrace.h: Fix common/ includes.
 604         * btrace.c: Fix common/ includes.
 605         * breakpoint.h: Fix common/ includes.
 606         * breakpoint.c: Fix common/ includes.
 607         * ax.h:
 608         (enum agent_op): Fix common/ includes.
 609         * ax-general.c (struct aop_map): Fix common/ includes.
 610         * ax-gdb.c: Fix common/ includes.
 611         * auxv.c: Fix common/ includes.
 612         * auto-load.c: Fix common/ includes.
 613         * arm-tdep.c: Fix common/ includes.
 614         * arch/riscv.c: Fix common/ includes.
 615         * arch/ppc-linux-common.c: Fix common/ includes.
 616         * arch/i386.c: Fix common/ includes.
 617         * arch/arm.c: Fix common/ includes.
 618         * arch/arm-linux.c: Fix common/ includes.
 619         * arch/arm-get-next-pcs.c: Fix common/ includes.
 620         * arch/amd64.c: Fix common/ includes.
 621         * arch/aarch64.c: Fix common/ includes.
 622         * arch/aarch64-insn.c: Fix common/ includes.
 623         * arch-utils.c: Fix common/ includes.
 624         * amd64-windows-tdep.c: Fix common/ includes.
 625         * amd64-tdep.c: Fix common/ includes.
 626         * amd64-sol2-tdep.c: Fix common/ includes.
 627         * amd64-obsd-tdep.c: Fix common/ includes.
 628         * amd64-nbsd-tdep.c: Fix common/ includes.
 629         * amd64-linux-tdep.c: Fix common/ includes.
 630         * amd64-linux-nat.c: Fix common/ includes.
 631         * amd64-fbsd-tdep.c: Fix common/ includes.
 632         * amd64-fbsd-nat.c: Fix common/ includes.
 633         * amd64-dicos-tdep.c: Fix common/ includes.
 634         * amd64-darwin-tdep.c: Fix common/ includes.
 635         * agent.c: Fix common/ includes.
 636         * ada-lang.h: Fix common/ includes.
 637         * ada-lang.c: Fix common/ includes.
 638         * aarch64-tdep.c: Fix common/ includes.
 639
 640 2019-01-25  Tom Tromey  <tom@tromey.com>
 641
 642         * common/create-version.sh: Use common/version.h.
 643
 644 2019-01-24  Pedro Alves  <palves@redhat.com>
 645
 646         * infrun.c (signal_stop, signal_print, signal_program)
 647         (signal_catch, signal_pass): Now arrays instead of pointers.
 648         (update_signals_program_target, do_target_resume)
 649         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 650         * linux-nat.c (linux_nat_target::pass_signals)
 651         (linux_nat_target::create_inferior, linux_nat_target::attach):
 652         Adjust.
 653         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 654         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 655         * procfs.c (procfs_target::pass_signals): Adjust.
 656         * record-full.c (record_full_target::resume): Adjust.
 657         * remote.c (remote_target::pass_signals)
 658         (remote_target::program_signals): Adjust.
 659         * target-debug.h (target_debug_print_signals): Now takes a
 660         gdb::array_view as parameter.  Adjust.
 661         * target.h (target_ops) <pass_signals, program_signals>: Replace
 662         pointer and length parameters with gdb::array_view.
 663         (target_pass_signals, target_program_signals): Likewise.
 664         * target-delegates.c: Regenerate.
 665
 666 2019-01-24  Pedro Alves  <palves@redhat.com>
 667
 668         * common/forward-scope-exit.h
 669         (forward_scope_exit::forward_scope_exit): Pass arguments to
 670         m_bind_function directly, instead of creating a std::bind and
 671         copying that.
 672
 673 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 674
 675         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 676         for static members.
 677         (pass_in_v_vfp_candidate): Likewise.
 678
 679 2019-01-23  Tom Tromey  <tom@tromey.com>
 680             Pedro Alves  <palves@redhat.com>
 681
 682         * regcache.c (class regcache_invalidator): Remove.
 683         (regcache::raw_write): Use make_scope_exit.
 684
 685 2019-01-23  Tom Tromey  <tom@tromey.com>
 686
 687         * ui-out.h (class ui_out_emit_type): Update comment.
 688
 689 2019-01-23  Tom Tromey  <tom@tromey.com>
 690
 691         * infrun.c (fetch_inferior_event): Update comment.
 692
 693 2019-01-23  Tom Tromey  <tom@tromey.com>
 694             Pedro Alves  <palves@redhat.com>
 695
 696         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 697         parameter.
 698         (fetch_inferior_event): Use SCOPE_EXIT.
 699
 700
 701 2019-01-23  Tom Tromey  <tom@tromey.com>
 702             Pedro Alves  <palves@redhat.com>
 703
 704         * infrun.c (disable_thread_events): Delete.
 705         (stop_all_threads): Use SCOPE_EXIT.
 706
 707 2019-01-23  Tom Tromey  <tom@tromey.com>
 708             Pedro Alves  <palves@redhat.com>
 709
 710         * symfile.c: Include forward-scope-exit.h.
 711         (clear_symtab_users_cleanup): Replace forward declaration with
 712         a FORWARD_SCOPE_EXIT.
 713         (syms_from_objfile_1): Use the forward_scope_exit and
 714         gdb::optional instead of cleanup_function.
 715         (reread_symbols): Use the forward_scope_exit instead of
 716         cleanup_function.
 717         (clear_symtab_users_cleanup): Remove function.
 718
 719 2019-01-23  Tom Tromey  <tom@tromey.com>
 720             Pedro Alves  <palves@redhat.com>
 721
 722         * linux-nat.c: Include scope-exit.h.
 723         (cleanup_target_stop): Remove.
 724         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 725         SCOPE_EXIT.
 726
 727 2019-01-23  Tom Tromey  <tom@tromey.com>
 728             Pedro Alves  <palves@redhat.com>
 729
 730         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 731         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 732
 733 2019-01-23  Tom Tromey  <tom@tromey.com>
 734             Andrew Burgess  <andrew.burgess@embecosm.com>
 735             Pedro Alves  <palves@redhat.com>
 736
 737         * infrun.c (fetch_inferior_event): Use scope_exit.
 738         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 739         * top.c (execute_command): Use scope_exit.
 740         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 741         * utils.c (do_bpstat_clear_actions_cleanup)
 742         (make_bpstat_clear_actions_cleanup): Remove.
 743
 744 2019-01-23  Tom Tromey  <tom@tromey.com>
 745             Pedro Alves  <palves@redhat.com>
 746
 747         * infrun.c: Include "common/scope-exit.h"
 748         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 749         (wait_for_inferior): Use SCOPE_EXIT.
 750         (fetch_inferior_event): Use scope_exit.
 751
 752 2019-01-23  Tom Tromey  <tom@tromey.com>
 753             Pedro Alves  <palves@redhat.com>
 754
 755         * breakpoint.c (create_breakpoint): Remove cleanup.
 756
 757 2019-01-23  Tom Tromey  <tom@tromey.com>
 758             Andrew Burgess  <andrew.burgess@embecosm.com>
 759             Pedro Alves  <palves@redhat.com>
 760
 761 2019-01-23  Pedro Alves  <palves@redhat.com>
 762
 763         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 764
 765 2019-01-23  Pedro Alves  <palves@redhat.com>
 766             Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * gdbthread.h: Include "common/forward-scope-exit.h".
 769         (scoped_finish_thread_state): Redefine custom class in terms of
 770         forward_scope_exit.
 771
 772 2019-01-23  Pedro Alves  <palves@redhat.com>
 773             Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * common/forward-scope-exit.h: New file.
 776
 777 2019-01-23  Pedro Alves  <palves@redhat.com>
 778             Andrew Burgess  <andrew.burgess@embecosm.com>
 779             Tom Tromey  <tom@tromey.com>
 780
 781         * common/scope-exit.h: New file.
 782
 783 2019-01-23  Pedro Alves  <palves@redhat.com>
 784
 785         * common/preprocessor.h (ESC): Rename to ...
 786         (ESC_PARENS): ... this.
 787         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 788         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 789
 790 2019-01-23  Tom Tromey  <tom@tromey.com>
 791
 792         * language.h (class scoped_switch_to_sym_language_if_auto):
 793         Initialize m_lang in both cases.
 794
 795 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 796
 797         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 798         with XCNEW.
 799
 800 2019-01-22  Tom Tromey  <tom@tromey.com>
 801
 802         * corelow.c: Do not include sys/file.h.
 803
 804 2019-01-22  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-wingeneral.h: Include gdb_curses.h.
 807
 808 2019-01-22  Tom Tromey  <tom@tromey.com>
 809
 810         * source-cache.h (class source_cache) <get_source_lines,
 811         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 812
 813 2019-01-22  Tom Tromey  <tom@tromey.com>
 814
 815         * remote-fileio.h (struct remote_target): Declare.
 816
 817 2019-01-22  Tom Tromey  <tom@tromey.com>
 818
 819         * python/py-arch.c: Do not include py-ref.h.
 820         * python/py-bpevent.c: Do not include py-ref.h.
 821         * python/py-cmd.c: Do not include py-ref.h.
 822         * python/py-continueevent.c: Do not include py-ref.h.
 823         * python/py-event.h: Do not include py-ref.h.
 824         * python/py-evtregistry.c: Do not include py-ref.h.
 825         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 826         * python/py-frame.c: Do not include py-ref.h.
 827         * python/py-framefilter.c: Do not include py-ref.h.
 828         * python/py-function.c: Do not include py-ref.h.
 829         * python/py-infevents.c: Do not include py-ref.h.
 830         * python/py-linetable.c: Do not include py-ref.h.
 831         * python/py-objfile.c: Do not include py-ref.h.
 832         * python/py-param.c: Do not include py-ref.h.
 833         * python/py-prettyprint.c: Do not include py-ref.h.
 834         * python/py-progspace.c: Do not include py-ref.h.
 835         * python/py-symbol.c: Do not include py-ref.h.
 836         * python/py-symtab.c: Do not include py-ref.h.
 837         * python/py-type.c: Do not include py-ref.h.
 838         * python/py-unwind.c: Do not include py-ref.h.
 839         * python/py-utils.c: Do not include py-ref.h.
 840         * python/py-value.c: Do not include py-ref.h.
 841         * python/py-varobj.c: Do not include py-ref.h.
 842         * python/py-xmethods.c: Do not include py-ref.h.
 843         * python/python.c: Do not include py-ref.h.
 844         * varobj.c: Do not include py-ref.h.
 845
 846 2019-01-22  Tom Tromey  <tom@tromey.com>
 847
 848         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 849         keyword for bcache.
 850
 851 2019-01-22  Tom Tromey  <tom@tromey.com>
 852
 853         * compile/compile-cplus-types.c: Remove a comment by #include.
 854
 855 2019-01-22  Tom Tromey  <tom@tromey.com>
 856
 857         * compile/gcc-c-plugin.h: Include compile-internal.h.
 858
 859 2019-01-22  Tom Tromey  <tom@tromey.com>
 860
 861         * stabsread.c (EXTERN): Do not define.
 862         (symnum, next_symbol_text_func, processing_gcc_compilation)
 863         (within_function, global_sym_chain, global_stabs)
 864         (previous_stab_code, this_object_header_files)
 865         (n_this_object_header_files)
 866         (n_allocated_this_object_header_files): Define.
 867         * stabsread.h (EXTERN): Never define.  Use "extern".
 868
 869 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 870
 871         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 872         history_value.
 873
 874 2019-01-21  Tom Tromey  <tom@tromey.com>
 875
 876         * ui-out.c: Fix includes.
 877         * tui/tui-source.c: Fix includes.
 878         * target.c: Fix includes.
 879         * remote.c: Fix includes.
 880         * regcache.c: Fix includes.
 881         * python/py-block.c: Fix includes.
 882         * printcmd.c: Fix includes.
 883         * or1k-tdep.c: Fix includes.
 884         * mi/mi-main.c: Fix includes.
 885         * m32r-tdep.c: Fix includes.
 886         * csky-tdep.c: Fix includes.
 887         * compile/compile-cplus-types.c: Fix includes.
 888         * cli/cli-interp.c: Fix includes.
 889
 890 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 893         for padding.
 894
 895 2019-01-16  Tom Tromey  <tom@tromey.com>
 896
 897         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 898         earlier.
 899         (struct objfile) <msymbols_range>: Move from top level.
 900         <msymbols>: New method.
 901         (class objfile_msymbols): Remove.
 902         * symtab.c (default_collect_symbol_completion_matches_break_on):
 903         Update.
 904         * symmisc.c (dump_msymbols): Update.
 905         * stabsread.c (scan_file_globals): Update.
 906         * objc-lang.c (info_selectors_command, info_classes_command)
 907         (find_methods): Update.
 908         * minsyms.c (find_solib_trampoline_target): Update.
 909         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 910         * coffread.c (coff_symfile_read): Update.
 911         * ada-lang.c (ada_lookup_simple_minsym)
 912         (ada_collect_symbol_completion_matches): Update.
 913
 914 2019-01-16  Tom Tromey  <tom@tromey.com>
 915
 916         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 917         type.  Remove no-argument constructor.
 918         <iterator::operator++>: Simplify.
 919         <begin>: Update.
 920         <end>: Use minimal_symbol_count.
 921
 922 2019-01-16  Tom Tromey  <tom@tromey.com>
 923
 924         * objfiles.h (struct objfile) <psymtabs>: New method.
 925         (class objfile_psymtabs): Remove.
 926         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 927         typedef.
 928         <range>: New method.
 929         (require_partial_symbols): Change return type.
 930         * psymtab.c (require_partial_symbols)
 931         (psym_expand_symtabs_matching): Update.
 932         * mdebugread.c (parse_partial_symbols): Update.
 933         * dbxread.c (dbx_end_psymtab): Update.
 934
 935 2019-01-15  Tom Tromey  <tom@tromey.com>
 936
 937         * symtab.c (lookup_objfile_from_block)
 938         (lookup_symbol_in_objfile_symtabs)
 939         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 940         (find_line_symtab, info_sources_command)
 941         (default_collect_symbol_completion_matches_break_on)
 942         (make_source_files_completion_list): Update.
 943         * symmisc.c (print_objfile_statistics, dump_objfile)
 944         (maintenance_print_symbols, maintenance_info_symtabs)
 945         (maintenance_check_symtabs, maintenance_info_line_tables):
 946         Update.
 947         * source.c (select_source_symtab)
 948         (forget_cached_source_info_for_objfile): Update.
 949         * objfiles.h (class objfile_compunits): Remove.
 950         (struct objfile) <compunits_range>: New typedef.
 951         (compunits): New method.
 952         * objfiles.c (objfile_relocate1): Update.
 953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 954         * maint.c (count_symtabs_and_blocks): Update.
 955         * linespec.c (iterate_over_all_matching_symtabs): Update.
 956         * cp-support.c (add_symbol_overload_list_qualified): Update.
 957         * coffread.c (coff_symtab_read): Update.
 958         * ada-lang.c (add_nonlocal_symbols)
 959         (ada_collect_symbol_completion_matches)
 960         (ada_add_global_exceptions): Update.
 961
 962 2019-01-15  Tom Tromey  <tom@tromey.com>
 963
 964         * progspace.h (program_space) <objfiles_safe_range>: New
 965         typedef.
 966         <objfiles_safe>: New method.
 967         * objfiles.h (class all_objfiles_safe): Remove.
 968         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 969         * jit.c (jit_inferior_exit_hook): Update.
 970
 971 2019-01-17  Tom Tromey  <tom@tromey.com>
 972
 973         * progspace.h (program_space) <objfiles_range>: New typedef.
 974         <objfiles>: New method.
 975         <objfiles_head>: Rename from objfiles.
 976         (object_files): Update.
 977         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 978         * guile/scm-pretty-print.c
 979         (ppscm_find_pretty_printer_from_objfiles): Update.
 980         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 981         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 982         Update.
 983         * python/py-progspace.c (pspy_get_objfiles): Update.
 984         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 985         Update.
 986         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 987         (objfpy_lookup_objfile_by_build_id): Update.
 988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 989         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 990         Update.
 991         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 992         (expand_symtab_containing_pc, lookup_objfile_from_block)
 993         (lookup_static_symbol, basic_lookup_transparent_type)
 994         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 995         (find_line_symtab, info_sources_command)
 996         (default_collect_symbol_completion_matches_break_on)
 997         (make_source_files_completion_list, find_main_name): Update.
 998         * symmisc.c (print_symbol_bcache_statistics)
 999         (print_objfile_statistics, maintenance_print_symbols)
1000         (maintenance_print_msymbols, maintenance_print_objfiles)
1001         (maintenance_info_symtabs, maintenance_check_symtabs)
1002         (maintenance_expand_symtabs, maintenance_info_line_tables):
1003         Update.
1004         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1005         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1006         (map_overlay_command, unmap_overlay_command)
1007         (simple_overlay_update, expand_symtabs_matching)
1008         (map_symbol_filenames): Update.
1009         * symfile-debug.c (set_debug_symfile): Update.
1010         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1011         Update.
1012         * source.c (select_source_symtab, forget_cached_source_info):
1013         Update.
1014         * solib.c (solib_read_symbols): Update.
1015         * solib-spu.c (append_ocl_sos): Update.
1016         * psymtab.c (maintenance_print_psymbols)
1017         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1018         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1019         * printcmd.c (info_symbol_command): Update.
1020         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1021         Update.
1022         * objfiles.h (class all_objfiles): Remove.
1023         * objfiles.c (have_partial_symbols, have_full_symbols)
1024         (have_minimal_symbols, qsort_cmp, update_section_map)
1025         (shared_objfile_contains_address_p)
1026         (default_iterate_over_objfiles_in_search_order): Update.
1027         * objc-lang.c (info_selectors_command, info_classes_command)
1028         (find_methods): Update.
1029         * minsyms.c (find_solib_trampoline_target): Update.
1030         * maint.c (maintenance_info_sections)
1031         (maintenance_translate_address, count_symtabs_and_blocks):
1032         Update.
1033         * main.c (captured_main_1): Update.
1034         * linux-thread-db.c (try_thread_db_load_from_pdir)
1035         (has_libpthread): Update.
1036         * linespec.c (iterate_over_all_matching_symtabs)
1037         (search_minsyms_for_name): Update.
1038         * jit.c (jit_find_objf_with_entry_addr): Update.
1039         * hppa-tdep.c (find_unwind_entry)
1040         (hppa_lookup_stub_minimal_symbol): Update.
1041         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1042         Update.
1043         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1044         (elf_gnu_ifunc_resolve_by_got): Update.
1045         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1046         * dwarf-index-write.c (save_gdb_index_command): Update.
1047         * cp-support.c (add_symbol_overload_list_qualified): Update.
1048         * breakpoint.c (create_overlay_event_breakpoint)
1049         (create_longjmp_master_breakpoint)
1050         (create_std_terminate_master_breakpoint)
1051         (create_exception_master_breakpoint): Update.
1052         * blockframe.c (find_pc_partial_function): Update.
1053         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1054         (ada_collect_symbol_completion_matches)
1055         (ada_add_global_exceptions): Update.
1056
1057 2019-01-17  Tom Tromey  <tom@tromey.com>
1058
1059         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1060         declare VEC.
1061         (solib_target_parse_libraries): Change return type.
1062         (library_list_start_segment, library_list_start_section)
1063         (library_list_end_library, library_list_start_library); Update.
1064         (solib_target_free_library_list): Remove.
1065         (solib_target_parse_libraries): Remove cleanup.  Change return
1066         type.
1067         (solib_target_current_sos): Update.
1068
1069 2019-01-17  Tom Tromey  <tromey@bapiya>
1070
1071         * valprint.c: Replace "the the" with "the".
1072         * symtab.c: Replace "the the" with "the".
1073         * solib.c: Replace "the the" with "the".
1074         * solib-dsbt.c: Replace "the the" with "the".
1075         * linespec.c: Replace "the the" with "the".
1076         * dwarf2loc.h: Replace "the the" with "the".
1077         * amd64-windows-tdep.c: Replace "the the" with "the".
1078         * aarch64-tdep.c: Replace "the the" with "the".
1079
1080 2019-01-16  Keith Seitz  <keiths@redhat.com>
1081
1082         PR gdb/23773
1083         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1084         <builder>: Rename to ..
1085         <m_builder>: ... this and make private.
1086         (dwarf2_cu::get_builder): New method.  Change all users of
1087         `builder' to use this method.
1088         (dwarf2_start_symtab): Move to ...
1089         (dwarf2_cu::start_symtab): ... here.  Update all callers
1090         (setup_type_unit_groups): Move to ...
1091         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1092         callers.
1093         (dwarf2_cu::reset_builder): New method.
1094         (process_full_compunit, process_full_type_unit): Use
1095         dwarf2_cu::reset_builder.
1096         (follow_die_offset): Record the ancestor CU if it is different
1097         from the followed DIE's CU.
1098         (follow_die_sig_1): Likewise.
1099
1100 2019-01-15  Tom Tromey  <tom@tromey.com>
1101
1102         * remote.c (class remote_state) <buf>: Now a char_vector.
1103         <buf_size>: Remove.
1104         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1105         parameter.
1106         (remote_target::getpkt_or_notif_sane_1)
1107         (remote_target::getpkt_sane)
1108         (remote_target::getpkt_or_notif_sane): Likewise.
1109         (class remote_target) <putpkt>: New overload.
1110         (remote_target::read_frame): Change type of "buf_p".  Remove
1111         sizeof_p parameter.
1112         (packet_ok): New overload.
1113         (packet_check_result): New overload.
1114         Update all uses.
1115
1116 2019-01-14  Tom Tromey  <tom@tromey.com>
1117
1118         * remote-notif.c (handle_notification, remote_notif_ack)
1119         (remote_notif_parse): Make "buf" const.
1120         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1121         const.
1122         (remote_notif_parse, remote_notif_ack, handle_notification):
1123         Likewise.
1124         * remote.c (remote_notif_stop_parse): Make "buf" const.
1125         (remote_target::remote_parse_stop_reply): Make "buf" const.
1126         (remote_notif_stop_ack): Make "buf" const.
1127
1128 2019-01-14  Tom Tromey  <tom@tromey.com>
1129
1130         * remote.c (remote_console_output): Make parameter const.
1131
1132 2019-01-14  Tom Tromey  <tom@tromey.com>
1133
1134         * target-debug.h (target_debug_print_signals): Constify.
1135         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1136         * procfs.c (procfs_target::pass_signals): Update.
1137         * linux-nat.c (linux_nat_target::pass_signals): Update.
1138         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1139         * target-delegates.c: Rebuild.
1140         * remote.c (remote_target::program_signals): Update.
1141         (remote_target::pass_signals): Update.
1142         * target.c (target_pass_signals): Constify argument.
1143         (target_program_signals): Likewise.
1144         * target.h (struct target_ops) <pass_signals, program_signals>:
1145         Constify argument.
1146         (target_pass_signals, target_program_signals): Constify argument.
1147
1148 2019-01-14  Tom Tromey  <tom@tromey.com>
1149
1150         PR tui/28819:
1151         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1152
1153 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1154
1155         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1156         field.
1157         * rs6000-tdep.c: Include reggroups.h.
1158         (IS_V_ALIAS_PSEUDOREG): Define.
1159         (rs6000_register_name): Return names for the "vX" aliases.
1160         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1161         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1162         aliases.  Call default_register_reggroup_p for all other
1163         pseudo-registers.
1164         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1165         New functions.
1166         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1167         Handle "vX" aliases.
1168         (v_alias_pseudo_register_collect): New function.
1169         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1170         (rs6000_gdbarch_init): Initialize "vX" aliases as
1171         pseudo-registers.  Restore registration of
1172         rs6000_pseudo_register_reggroup_p with
1173         set_tdesc_pseudo_register_reggroup_p.
1174
1175 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1176
1177         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1178         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1179         set_gdbarch_num_pseudo_regs.
1180
1181 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1182
1183         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1184         Remove arg prefixname, add do_set and do_show.
1185         Add member functions set_list and show_list.
1186         * cli/cli-style.c (class cli_style_option): Update accordingly.
1187         (style_set_list): Move to file scope.
1188         (style_show_list): Likewise.
1189         (set_style): Call help_list.
1190         (show_style): Call cmd_show_list.
1191         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1192         Update to use the new macro.
1193
1194 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1195
1196         * ada-lang.c (_initialize_ada_language): Expand the help text
1197         for the "catch exception" command.
1198
1199 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1200
1201         * symtab.c (matching_obj_sections): Initialize obj,
1202         declare it closer to its usage.
1203
1204 2019-01-10  Tom Tromey  <tom@tromey.com>
1205
1206         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1207         (basic_inf_threads_range): Remove.
1208         (inf_threads_range, inf_non_exited_threads_range)
1209         (safe_inf_threads_range): Use next_adapter.
1210
1211 2019-01-10  Keith Seitz  <keiths@redhat.com>
1212
1213         PR gdb/23712
1214         PR symtab/23010
1215         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1216         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1217
1218 2019-01-10  Keith Seitz  <keiths@redhat.com>
1219
1220         PR gdb/23712
1221         PR symtab/23010
1222         * dictionary.c (pending_to_vector): Remove.
1223         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1224         Remove _1 suffix, replacing functions of the same name.  Update
1225         all callers.
1226         (dict_create_hashed, dict_create_hashed_expandable)
1227         (dict_create_linear, dict_create_linear_expandable, dict_free)
1228         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1229         Make functions static.
1230
1231 2019-01-10  Keith Seitz  <keiths@redhat.com>
1232
1233         PR gdb/23712
1234         PR symtab/23010
1235         * dictionary.h (struct dictionary): Replace declaration with
1236         multidictionary.
1237         (dict_create_hashed, dict_create_hashed_expandable)
1238         (dict_create_linear, dict_create_linear_expandable)
1239         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1240         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1241         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1242         taking multidictionary argument.
1243         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1244         * block.h (struct block) <dict>: Change to multidictionary
1245         and rename `multidict'.
1246         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1247         symmisc.c: Update all dictionary references to multidictionary.
1248
1249 2019-01-10  Keith Seitz  <keiths@redhat.com>
1250
1251         PR gdb/23712
1252         PR symtab/23010
1253         * dictionary.c: Include unordered_map.
1254         (pending_to_vector): New function.
1255         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1256         Rewrite the non-"_1" functions to take vector instead
1257         of linked list.
1258         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1259         "new" _1 versions of the same name.
1260         (multidictionary): Define.
1261         (std::hash<enum language): New definition.
1262         (collate_pending_symbols_by_language, mdict_create_hashed)
1263         (mdict_create_hashed_expandable, mdict_create_linear)
1264         (mdict_create_linear_expandable, mdict_free)
1265         (find_language_dictionary, create_new_language_dictionary)
1266         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1267         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1268         (mdict_size, mdict_empty): New functions.
1269         * dictionary.h (mdict_iterator): Define.
1270
1271 2019-01-10  Pedro Alves  <palves@redhat.com>
1272
1273         * breakpoint.c (read_uploaded_action)
1274         (create_tracepoint_from_upload): Adjust to use
1275         gdb::unique_xmalloc_ptr.
1276         * ctf.c (ctf_write_uploaded_tp):
1277         (SET_ARRAY_FIELD): Use emplace_back.
1278         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1279         * tracefile-tfile.c (tfile_write_uploaded_tp):
1280         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1281         gdb::unique_xmalloc_ptr.
1282         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1283         at_string, cond_string, cmd_strings>: Replace char pointers
1284         with gdb::unique_xmalloc_ptr.
1285
1286 2019-01-10  Pedro Alves  <palves@redhat.com>
1287
1288         * solib-target.c (library_list_start_library): Don't xstrdup name.
1289
1290 2019-01-10  Pedro Alves  <palves@redhat.com>
1291
1292         * mdebugread.c (parse_partial_symbols): Use
1293         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1294
1295 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * linux-fork.c (scoped_switch_fork_info)
1298         <~scoped_switch_fork_info>: Fix incorrect variable name.
1299
1300 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * linux-fork.c (scoped_switch_fork_info)
1303         <scoped_switch_fork_info>: Make explicit.
1304         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1305
1306 2019-01-10  Tom Tromey  <tom@tromey.com>
1307
1308         * objfiles.h (objfile::reset_psymtabs): Update.
1309         * objfiles.c (objfile::objfile): Update.
1310         * psymtab.h (psymtab_storage::obstack): Update.
1311         (psymtab_storage::m_obstack): Use gdb::optional.
1312         (class psymtab_storage): Update comment.  Remove objfile
1313         parameter.
1314         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1315
1316 2019-01-10  Tom Tromey  <tom@tromey.com>
1317
1318         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1319         <free_psymtabs>: Now private.
1320         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1321         (allocate_psymtab): Use new method.
1322
1323 2019-01-10  Tom Tromey  <tom@tromey.com>
1324
1325         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1326         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1327         * mdebugread.c (parse_partial_symbols): Use
1328         allocate_dependencies.
1329         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1330         allocate_dependencies.
1331         (process_psymtab_comp_unit_reader)
1332         (build_type_psymtab_dependencies): Likewise.
1333         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1334
1335 2019-01-10  Tom Tromey  <tom@tromey.com>
1336
1337         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1338         PSYMBOL_SET_LANGUAGE.
1339         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1340
1341 2019-01-10  Tom Tromey  <tom@tromey.com>
1342
1343         * psymtab.h (psymtab_storage::obstack): New method.
1344         <m_obstack>: Rename from obstack; now private.
1345         * psymtab.c (psymtab_storage): Update.
1346         * dwarf2read.c (create_addrmap_from_index)
1347         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1348         Update.
1349
1350 2019-01-10  Tom Tromey  <tom@tromey.com>
1351
1352         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1353         * objfiles.h (objfile::reset_psymtabs): New method.
1354
1355 2019-01-10  Tom Tromey  <tom@tromey.com>
1356
1357         * symmisc.c (print_symbol_bcache_statistics): Update.
1358         (print_objfile_statistics): Update.
1359         * symfile.c (reread_symbols): Update.
1360         * psymtab.h (class psymtab_storage): New.
1361         * psymtab.c (psymtab_storage): New constructor.
1362         (~psymtab_storage): New destructor.
1363         (require_partial_symbols): Update.
1364         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1365         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1366         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1367         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1368         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1369         (start_psymtab_common, end_psymtab_common)
1370         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1371         (allocate_psymtab): Update.
1372         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1373         Update.
1374         (dump_psymtab_addrmap, maintenance_print_psymbols)
1375         (maintenance_check_psymtabs): Update.
1376         (class objfile_psymtabs): Move to objfiles.h.
1377         * psympriv.h (discard_psymtab): Now inline.
1378         (psymtab_discarder::psymtab_discarder): Update.
1379         (psymtab_discarder::~psymtab_discarder): Update.
1380         (ALL_OBJFILE_PSYMTABS): Rewrite.
1381         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1382         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1383         Remove fields.
1384         <partial_symtabs>: New field.
1385         (class objfile_psymtabs): Move from psymtab.h.  Update.
1386         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1387         psymbol_cache.
1388         (objfile::~objfile): Don't destroy psymbol_cache.
1389         * mdebugread.c (parse_partial_symbols): Update.
1390         * dwarf2read.c (create_addrmap_from_index)
1391         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1392         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1393         (add_partial_subprogram, dwarf2_ranges_read): Update.
1394         * dwarf-index-write.c (write_address_map)
1395         (write_one_signatured_type, recursively_write_psymbols)
1396         (class debug_names, class debug_names, write_psymtabs_to_index):
1397         Update.
1398
1399 2019-01-10  Tom Tromey  <tom@tromey.com>
1400
1401         * symtab.h (SYMBOL_SET_NAMES): Update.
1402         (symbol_set_names): Update.
1403         (MSYMBOL_SET_NAMES): Update.
1404         * symtab.c (symbol_set_names): Change argument to be an
1405         objfile_per_bfd_storage.
1406         * psymtab.c (add_psymbol_to_bcache): Update.
1407         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1408
1409 2019-01-10  Tom Tromey  <tom@tromey.com>
1410
1411         * symtab.c (create_demangled_names_hash): Change argument to be an
1412         objfile_per_bfd_storage.
1413         (symbol_set_names): Update.
1414
1415 2019-01-10  Tom Tromey  <tom@tromey.com>
1416
1417         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1418         init_psymbol_list.
1419         * psymtab.c (init_psymbol_list): Do nothing if already called.
1420         * psympriv.h (init_psymbol_list): Add comment.
1421         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1422         init_psymbol_list.
1423         * dbxread.c (dbx_symfile_read): Unconditionally call
1424         init_psymbol_list.
1425
1426 2019-01-10  Tom Tromey  <tom@tromey.com>
1427
1428         * xcoffread.c (scan_xcoff_symtab): Update.
1429         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1430         "where".
1431         * mdebugread.c (parse_partial_symbols)
1432         (handle_psymbol_enumerators): Update.
1433         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1434         * dbxread.c (read_dbx_symtab): Update.
1435         * psympriv.h (psymbol_placement): New enum.
1436         (add_psymbol_to_list): Update.
1437
1438 2019-01-10  Tom Tromey  <tom@tromey.com>
1439
1440         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1441         static_psymbols parameters.
1442         (scan_xcoff_symtab): Update.
1443         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1444         static_psymbols parameters.
1445         * psympriv.h (start_psymtab_common): Update.
1446         * mdebugread.c (parse_partial_symbols): Update.
1447         * dwarf2read.c (create_partial_symtab): Update.
1448         * dbxread.c (read_dbx_symtab): Update.
1449         (start_psymtab): Remove global_psymbols and static_psymbols
1450         parameters.
1451
1452 2019-01-10  Tom Tromey  <tom@tromey.com>
1453
1454         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1455         * psymtab.c (allocate_psymtab): Add comment.
1456         * psympriv.h (allocate_psymtab): Add comment.
1457         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1458         initializations.
1459         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1460
1461 2019-01-10  Tom Tromey  <tom@tromey.com>
1462
1463         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1464         Don't declare.
1465         * mipsread.c: Include mdebugread.h.
1466         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1467         Declare.
1468         * elfread.c: Include mdebugread.h.
1469
1470 2019-01-09  Tom Tromey  <tom@tromey.com>
1471
1472         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1473         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1474         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1475         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1476         (psym_lookup_symbol, psym_find_last_source_symtab)
1477         (psym_forget_cached_source_info, psym_print_stats)
1478         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1479         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1480         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1481         (psym_find_compunit_symtab_by_address)
1482         (maintenance_print_psymbols, maintenance_info_psymtabs)
1483         (maintenance_check_psymtabs): Use ranged for.
1484         * psymtab.h (class objfile_psymtabs): New.
1485         (require_partial_symbols): Return objfile_psymtabs.
1486         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1487
1488 2019-01-09  Tom Tromey  <tom@tromey.com>
1489
1490         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1491         (find_pc_mapped_section, list_overlays_command)
1492         (map_overlay_command, unmap_overlay_command)
1493         (simple_overlay_update): Use all_objfiles.
1494         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1495         * printcmd.c (info_symbol_command): Use all_objfiles.
1496         * objfiles.h (ALL_OBJSECTIONS): Remove.
1497         * maint.c (maintenance_translate_address): Use all_objfiles.
1498         * gcore.c (gcore_create_callback): Use all_objfiles.
1499         (objfile_find_memory_regions): Likewise.
1500
1501 2019-01-09  Tom Tromey  <tom@tromey.com>
1502
1503         * symtab.c (find_line_symtab, info_sources_command)
1504         (make_source_files_completion_list): Use objfile_compunits.
1505         * source.c (select_source_symtab): Use objfile_compunits.
1506         * objfiles.h (struct objfile): Update comment.
1507         (ALL_OBJFILES): Remove.
1508         (ALL_FILETABS): Remove.
1509         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1510         objfile_compunits.
1511
1512 2019-01-09  Tom Tromey  <tom@tromey.com>
1513
1514         * symmisc.c (print_objfile_statistics, dump_objfile)
1515         (maintenance_print_symbols): Use compunit_filetabs.
1516         * source.c (forget_cached_source_info_for_objfile): Use
1517         compunit_filetabs.
1518         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1519         (ALL_FILETABS): Use compunit_filetabs.
1520         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1521         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1522
1523 2019-01-09  Tom Tromey  <tom@tromey.com>
1524
1525         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1526         (compunit_filetabs): New.
1527         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1528         compunit_filetabs.
1529         (info_sources_command, make_source_files_completion_list): Remove
1530         declaration.
1531         * symmisc.c (print_objfile_statistics, dump_objfile)
1532         (maintenance_print_symbols): Remove declaration.
1533         (maintenance_info_symtabs): Use compunit_filetabs.
1534         (maintenance_info_line_tables): Likewise.
1535         * source.c (select_source_symtab): Change local variable name.
1536         (forget_cached_source_info_for_objfile): Remove declaration.
1537         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1538         * objfiles.c (objfile_relocate1): Remove declaration.
1539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1540         declaration.
1541         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1542         * coffread.c (coff_symtab_read): Remove declaration.
1543         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1544         compunit_filetabs.
1545
1546 2019-01-09  Tom Tromey  <tom@tromey.com>
1547
1548         * symtab.c (lookup_objfile_from_block)
1549         (find_pc_sect_compunit_symtab, search_symbols)
1550         (default_collect_symbol_completion_matches_break_on): Use
1551         objfile_compunits.
1552         * objfiles.h (ALL_COMPUNITS): Remove.
1553         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1554         * cp-support.c (add_symbol_overload_list_qualified): Use
1555         objfile_compunits.
1556         * ada-lang.c (ada_collect_symbol_completion_matches)
1557         (ada_add_global_exceptions): Use objfile_compunits.
1558
1559 2019-01-09  Tom Tromey  <tom@tromey.com>
1560
1561         * source.c (select_source_symtab)
1562         (forget_cached_source_info_for_objfile): Remove declaration.
1563         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1564         declaration.
1565         * maint.c (count_symtabs_and_blocks): Remove declaration.
1566         * cp-support.c (add_symbol_overload_list_qualified): Remove
1567         declaration.
1568         * coffread.c (coff_symtab_read): Remove declaration.
1569         * symtab.c (lookup_symbol_in_objfile_symtabs)
1570         (basic_lookup_transparent_type_1): Use objfile_compunits.
1571         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1572         (info_sources_command, search_symbols)
1573         (default_collect_symbol_completion_matches_break_on)
1574         (make_source_files_completion_list): Remove declaration.
1575         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1576         (ada_collect_symbol_completion_matches)
1577         (ada_add_global_exceptions): Remove declaration.
1578         * linespec.c (iterate_over_all_matching_symtabs): Use
1579         objfile_compunits.
1580         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1581         (class objfile_compunits): New.
1582         (ALL_COMPUNITS): Use objfile_compunits.
1583         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1584         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1585         objfile_compunits.
1586         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1587
1588 2019-01-09  Tom Tromey  <tom@tromey.com>
1589
1590         * symtab.c (search_symbols)
1591         (default_collect_symbol_completion_matches_break_on): Use
1592         objfile_msymbols.
1593         * ada-lang.c (ada_lookup_simple_minsym)
1594         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1595         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1596         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1597         objfile_msymbols.
1598         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1599         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1600         * objc-lang.c (find_methods): Use objfile_msymbols.
1601         (info_selectors_command, info_classes_command): Likewise.
1602         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1603         * objfiles.h (class objfile_msymbols): New.
1604         (ALL_OBJFILE_MSYMBOLS): Remove.
1605         (ALL_MSYMBOLS): Remove.
1606
1607 2019-01-09  Tom Tromey  <tom@tromey.com>
1608
1609         * common/next-iterator.h (next_adapter): Add Iterator template
1610         parameter.
1611         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1612         (class all_objfiles_safe): New.
1613         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1614         * objfiles.c (put_objfile_before): Update comment.
1615         (add_separate_debug_objfile): Likewise.
1616         (free_all_objfiles): Use all_objfiles_safe.
1617         (objfile_purge_solibs): Likewise.
1618
1619 2019-01-09  Tom Tromey  <tom@tromey.com>
1620
1621         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1622         (expand_symtab_containing_pc, lookup_static_symbol)
1623         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1624         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1625         all_objfiles.
1626         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1627         * breakpoint.c (create_overlay_event_breakpoint)
1628         (create_longjmp_master_breakpoint)
1629         (create_std_terminate_master_breakpoint)
1630         (create_exception_master_breakpoint): Use all_objfiles.
1631         * linux-thread-db.c (try_thread_db_load_from_pdir)
1632         (has_libpthread): Use all_objfiles.
1633         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1634         * linespec.c (iterate_over_all_matching_symtabs)
1635         (search_minsyms_for_name): Use all_objfiles.
1636         * maint.c (maintenance_info_sections): Use all_objfiles.
1637         * main.c (captured_main_1): Use all_objfiles.
1638         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1639         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1640         * guile/scm-pretty-print.c
1641         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1642         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1643         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1644         (maintenance_print_msymbols): Use all_objfiles.
1645         * source.c (select_source_symtab): Use all_objfiles.
1646         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1647         * symfile.c (remove_symbol_file_command)
1648         (expand_symtabs_matching, map_symbol_filenames): Use
1649         all_objfiles.
1650         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1651         all_objfiles.
1652         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1653         * objc-lang.c (find_methods): Use all_objfiles.
1654         * objfiles.c (have_partial_symbols, have_full_symbols)
1655         (have_minimal_symbols, qsort_cmp)
1656         (default_iterate_over_objfiles_in_search_order): Use
1657         all_objfiles.
1658         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1659         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1660         (maintenance_check_psymtabs): Use all_objfiles.
1661         (ALL_PSYMTABS): Remove.
1662         * compile/compile-object-run.c (do_module_cleanup): Use
1663         all_objfiles.
1664         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1665         * cp-support.c (add_symbol_overload_list_qualified): Use
1666         all_objfiles.
1667         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1668         Use all_objfiles.
1669         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1670         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1671         all_objfiles.
1672         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1673         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1674         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1675         Uses all_objfiles.
1676         * solib.c (solib_read_symbols): Use all_objfiles
1677
1678 2019-01-09  Tom Tromey  <tom@tromey.com>
1679
1680         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1681         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1682         all_objfiles.
1683         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1684         * symmisc.c (print_symbol_bcache_statistics)
1685         (print_objfile_statistics, maintenance_print_objfiles)
1686         (maintenance_info_symtabs, maintenance_check_symtabs)
1687         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1688         all_objfiles.
1689         * source.c (forget_cached_source_info): Use all_objfiles.
1690         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1691         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1692         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1693         * objfiles.c (update_section_map): Use all_objfiles.
1694         (shared_objfile_contains_address_p): Likewise.
1695         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1696         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1697
1698 2019-01-09  Tom Tromey  <tom@tromey.com>
1699
1700         * common/next-iterator.h: New file.
1701         * objfiles.h (class all_objfiles): New.
1702         (struct objfile_iterator): New.
1703
1704 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1705
1706         * NEWS: Move the description of the changed "frame", "select-frame",
1707          and "info frame" commands to the Changed commands section.
1708
1709 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1710
1711         * gdbtypes.c (check_stub_method_group): Remove handling of old
1712         mangling schemes.
1713         * linespec.c (find_methods): Likewise.
1714         * stabsread.c (read_member_functions): Likewise.
1715         * valops.c (search_struct_method): Likewise.
1716         (value_struct_elt_for_reference): Likewise.
1717         * NEWS: Mention this change.
1718
1719 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1722         print_source_lines.
1723         * source.c (print_source_lines_base): Update line number check.
1724         (print_source_lines): New function.
1725         (source_lines_range::source_lines_range): New function.
1726         * source.h (class source_lines_range): New class.
1727         (print_source_lines): New declaration.
1728
1729 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1730
1731         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1732
1733 2019-01-08  Tom Tromey  <tom@tromey.com>
1734             Simon Marchi  <simon.marchi@ericsson.com>
1735
1736         PR gdb/24060
1737         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1738         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1739         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1740         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1741         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1742         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1743
1744 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1745
1746         * source.c (select_source_symtab): Move header comment to
1747         declaration in source.h.
1748         (forget_cached_source_info_for_objfile): Likewise.
1749         (forget_cached_source_info): Likewise.
1750         (identify_source_line): Likewise.
1751         * source.h (identify_source_line): Move declaration from symtab.h
1752         and add comment from source.c
1753         (print_source_lines): Likewise.
1754         (forget_cached_source_info_for_objfile): Likewise.
1755         (forget_cached_source_info): Likewise.
1756         (select_source_symtab): Likewise.
1757         (enum print_source_lines_flag): Move definition from symtab.h.
1758         * symtab.h (identify_source_line): Move declaration to source.h.
1759         (print_source_lines): Likewise.
1760         (forget_cached_source_info_for_objfile): Likewise.
1761         (forget_cached_source_info): Likewise.
1762         (select_source_symtab): Likewise.
1763         (enum print_source_lines_flag): Move definition to source.h.
1764         * tui/tui-hooks.c: Add 'source.h' include.
1765
1766 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1767
1768         * source.c (print_source_lines_base): Handle requests to print
1769         reverse line number sequences, and guard against empty lines
1770         string.
1771
1772 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1773
1774         * source.c (print_source_lines_base): Fix skip of '\r' if next
1775         character is '\n'.
1776
1777 2019-01-06  Tom Tromey  <tom@tromey.com>
1778
1779         * c-exp.y (struct c_parse_state) <macro_original_text,
1780         expansion_obstack>: New member.
1781         (macro_original_text, expansion_obstack): Remove globals.
1782         (scan_macro_expansion, scanning_macro_expansion)
1783         (finished_macro_expansion): Update.
1784         (scan_macro_cleanup): Remove.
1785         (yylex, c_parse): Update.
1786
1787 2019-01-06  Tom Tromey  <tom@tromey.com>
1788
1789         * c-exp.y (struct c_parse_state) <strings>: New member.
1790         (operator_stoken): Update.
1791
1792 2019-01-06  Tom Tromey  <tom@tromey.com>
1793
1794         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1795         (union type_stack_elt) <typelist_val>: Now a pointer to
1796         std::vector.
1797         (type_stack_cleanup): Don't declare.
1798         (push_typelist): Update.
1799         * parse.c (pop_typelist): Return a std::vector.
1800         (push_typelist): Take a std::vector.
1801         (follow_types): Update.  Do not free args.
1802         (type_stack_cleanup): Remove.
1803         * c-exp.y (struct c_parse_state): New.
1804         (cpstate): New global.
1805         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1806         (nonempty_typelist): Update.
1807         (func_mod): Create a new vector.
1808         (c_parse): Create a c_parse_state.
1809         (check_parameter_typelist): Do not delete params.
1810         (function_method): Update.  Do not delete type_list.
1811
1812 2019-01-06  Tom Tromey  <tom@tromey.com>
1813
1814         PR gdb/28155:
1815         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1816         check_typedef.
1817         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1818         (print_return_value): Likewise.
1819
1820 2019-01-05  Tom Tromey  <tom@tromey.com>
1821
1822         * contrib/cleanup_check.py: Remove.
1823         * contrib/gcc-with-excheck: Remove.
1824         * contrib/exsummary.py: Remove.
1825         * contrib/excheck.py: Remove.
1826
1827 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1828
1829         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1830         NULL. Initialize tpprev to NULL instead of assigning it
1831         to NULL on the next statement.
1832         * windows-nat.c (windows_delete_thread): Remove check for
1833         main_thread_id before printing thread exit notifications.
1834         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1835         Remove thread ID check against main_thread_id.
1836         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1837         windows_delete_thread.
1838         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1839
1840 2019-01-04  Tom Tromey  <tom@tromey.com>
1841
1842         * compile/compile.c (_initialize_compile): Use upper case for
1843         metasyntactic variables.
1844         * symmisc.c (_initialize_symmisc): Use upper case for
1845         metasyntactic variables.
1846         * psymtab.c (_initialize_psymtab): Use upper case for
1847         metasyntactic variables.
1848         * demangle.c (demangle_command): Use upper case for metasyntactic
1849         variables.
1850         (_initialize_demangler): Likewise.
1851         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1852         variables.
1853
1854 2019-01-03  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1857
1858 2019-01-03  Tom Tromey  <tom@tromey.com>
1859
1860         * python/py-symtab.c (salpy_str): Update.
1861         (struct salpy_sal_object) <symtab>: Now a PyObject.
1862         (salpy_dealloc): Update.
1863         (del_objfile_sal): Use gdbpy_ref.
1864
1865 2019-01-03  Tom Tromey  <tom@tromey.com>
1866
1867         * python/py-type.c (convert_field): Use new_reference.  Return
1868         gdbpy_ref.
1869         (make_fielditem): Return gdbpy_ref.
1870         (typy_fields): Update.
1871         (typy_getitem): Update.
1872         (field_name): Return gdbpy_ref.  Use new_reference.
1873         (typy_iterator_iternext): Update.
1874
1875 2019-01-03  Tom Tromey  <tom@tromey.com>
1876
1877         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1878
1879 2019-01-03  Tom Tromey  <tom@tromey.com>
1880
1881         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1882         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1883         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1884         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1885         (pspy_set_type_printers): Likewise.
1886         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1887         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1888         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1889         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1890         (objfpy_set_type_printers): Likewise.
1891
1892 2019-01-03  Tom Tromey  <tom@tromey.com>
1893
1894         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1895         (gdbpy_print_stack): Use gdbpy_err_fetch.
1896         * python/python-internal.h (class gdbpy_err_fetch): New class.
1897         (class gdbpy_enter) <m_error_type, m_error_value,
1898         m_error_traceback>: Remove.
1899         <m_error>: New member.
1900         (gdbpy_exception_to_string): Don't declare.
1901         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1902         * python/py-value.c (convert_value_from_python): Use
1903         gdbpy_err_fetch.
1904         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1905         gdbpy_exception_to_string.
1906         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1907         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1908         gdbpy_err_fetch.
1909
1910 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * linux-nat.c (delete_lwp_cleanup): Delete.
1913         (struct lwp_deleter): New struct.
1914         (lwp_info_up): New typedef.
1915         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1916         lwp_info_up.
1917
1918 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * linux-fork.c (class scoped_switch_fork_info): New class.
1921         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1922
1923 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * valops.c (find_overload_match): Remove use of null_cleanup, and
1926         calls to do_cleanups.
1927
1928 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * compile/compile-cplus-types.c
1931         (compile_cplus_instance::decl_name): Handle changes to
1932         cp_func_name.
1933         * cp-support.c (cp_func_name): Update header comment, update
1934         return type.
1935         * cp-support.h (cp_func_name): Update return type in declaration.
1936         * valops.c (find_overload_match): Move temp_func local to top
1937         level of function and change its type.  Use temp_func to hold and
1938         delete temporary string obtained from cp_func_name.
1939
1940 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1943         gdb::char_vector, remove cleanup, and update uses of `msg`.
1944
1945 2019-01-03  Jim Wilson  <jimw@sifive.com>
1946
1947         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1948
1949 2019-01-02  Tom Tromey  <tom@tromey.com>
1950
1951         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1952         (tdesc_parse_xml): Remove cleanups.
1953         * target-descriptions.h (make_cleanup_free_target_description):
1954         Don't declare.
1955         (target_desc_deleter): New struct.
1956         (target_desc_up): New typedef.
1957         * target-descriptions.c (target_desc_deleter::operator()): Rename
1958         from free_target_description.
1959         (make_cleanup_free_target_description): Remove.
1960
1961 2019-01-02  Tom Tromey  <tom@tromey.com>
1962
1963         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1964         constructor, destructor.
1965         (linespec_parser): Remove typedef.
1966         (~linespec_parser): Rename from linespec_parser_delete.
1967         (linespec_lex_to_end, linespec_complete_label)
1968         (linespec_complete): Update.
1969         (decode_line_full): Remove cleanups.
1970         (decode_line_1): Update.
1971
1972 2019-01-02  Tom Tromey  <tom@tromey.com>
1973
1974         * python/python-internal.h (inferior_to_inferior_object): Change
1975         return type.
1976         * python/py-exitedevent.c (create_exited_event_object): Update.
1977         * python/py-inferior.c (inferior_to_inferior_object): Return
1978         gdbpy_ref.
1979         (python_new_inferior, python_inferior_deleted)
1980         (thread_to_thread_object, delete_thread_object)
1981         (build_inferior_list, gdbpy_selected_inferior): Update.
1982         * python/py-infthread.c (create_thread_object): Update.  Also fail
1983         if inferior_to_inferior_object fails.
1984
1985 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1986
1987         * inferior.h (class inferior) <displaced_step_state>: New field.
1988         * infrun.h (struct displaced_step_state): Move here from
1989         infrun.c.  Initialize fields, add constructor.
1990         <inf>: Remove field.
1991         <reset>: New method.
1992         * infrun.c (struct displaced_step_inferior_state): Move to
1993         infrun.h.
1994         (displaced_step_inferior_states): Remove.
1995         (get_displaced_stepping_state): Adust.
1996         (displaced_step_in_progress_any_inferior): Adjust.
1997         (displaced_step_in_progress_thread): Adjust.
1998         (displaced_step_in_progress): Adjust.
1999         (add_displaced_stepping_state): Remove.
2000         (get_displaced_step_closure_by_addr): Adjust.
2001         (remove_displaced_stepping_state): Remove.
2002         (infrun_inferior_exit): Call displaced_step_state.reset.
2003         (use_displaced_stepping): Don't check for NULL.
2004         (displaced_step_prepare_throw): Call
2005         get_displaced_stepping_state.
2006         (displaced_step_fixup): Don't check for NULL.
2007         (prepare_for_detach): Don't check for NULL.
2008
2009 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2010
2011         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2012          in case of call that did not complete.
2013
2014 2019-01-02  Andrey Utkin  <autkin@undo.io>
2015
2016         * symfile.c (find_separate_debug_file): Fix search of debug files for
2017         remote debuggee.
2018
2019 2019-01-02  Tom Tromey  <tom@tromey.com>
2020
2021         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2022         indentation.
2023         * python/py-frame.c (frapy_older): Remove cast.
2024         (frapy_newer): Likewise.
2025         * python/py-breakpoint.c (local_setattro): Remove cast.
2026         * python/py-arch.c (archpy_name): Remove local variable.
2027         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2028
2029 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2030
2031         * unittests/basic_string_view/element_access/char/empty.cc:
2032         Fix year range in copyright header.
2033
2034 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2037         Delete.
2038         <operator==>: Update with for removed field.
2039         <hash>: Likewise.
2040         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2041         <isa_features>: ...this.
2042         <abi_features>: New field.
2043         (riscv_isa_flen): Update comment.
2044         (riscv_abi_xlen): New declaration.
2045         (riscv_abi_flen): New declaration.
2046         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2047         isa_features.
2048         (riscv_abi_xlen): New function.
2049         (riscv_isa_flen): Update to get answer from isa_features.
2050         (riscv_abi_flen): New function.
2051         (riscv_has_fp_abi): Update to get answer from abi_features.
2052         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2053         xlen and flen.
2054         (riscv_call_info) <xlen, flen>: Update comment.
2055         (riscv_call_arg_struct): Remove invalid assertions
2056         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2057         is removed.
2058         (riscv_gdbarch_init): Gather isa features and abi features
2059         separately, ensure both match on the gdbarch when reusing an old
2060         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2061         a target with 64-bit float hardware.
2062
2063 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2064
2065         * source.c (search_command_helper): Stop reverse search
2066         when line 1 has been searched.
2067
2068 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2069
2070         * record-full.c (record_full_base_target::close): Rewrite
2071         record_full_core_buf_list free logic.
2072
2073 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2074
2075         * break-catch-syscall.c (print_one_catch_syscall): xfree
2076         the last text.
2077
2078 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2079
2080         * top.c (print_gdb_version): Update Copyright year in version
2081         message.
2082
2083 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2084
2085         Update copyright year range in all GDB files.
2086
2087 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2088
2089         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2090
2091 For older changes see ChangeLog-2018.
2092 \f
2093 Local Variables:
2094 mode: change-log
2095 left-margin: 8
2096 fill-column: 74
2097 version-control: never
2098 coding: utf-8
2099 End:
2100