gdb/ChangeLog

   1 2019-02-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * ravenscar-thread.c (is_ravenscar_task)
   4         (ravenscar_task_is_currently_active): Return bool.
   5         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
   6         (_initialize_ravenscar): Remove "(void)".
   7         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
   8         Return bool.
   9
  10 2019-02-15  Tom Tromey  <tromey@adacore.com>
  11
  12         * ravenscar-thread.c (ravenscar_runtime_initializer)
  13         (has_ravenscar_runtime, get_running_thread_id)
  14         (ravenscar_thread_target::resume): Fix indentation.
  15
  16 2019-02-15  Tom Tromey  <tromey@adacore.com>
  17
  18         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  19         from ravenscar_arch_ops.
  20         (sparc_ravenscar_ops::fetch_registers)
  21         (sparc_ravenscar_ops::store_registers): Now methods.
  22         (sparc_ravenscar_prepare_to_store): Remove.
  23         (sparc_ravenscar_ops): Redefine.
  24         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  25         methods and destructor.  Remove members.
  26         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  27         (ravenscar_thread_target::store_registers)
  28         (ravenscar_thread_target::prepare_to_store): Update.
  29         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
  30         Remove.
  31         (struct ppc_ravenscar_powerpc_ops): Derive from
  32         ravenscar_arch_ops.
  33         (ppc_ravenscar_powerpc_ops::fetch_registers)
  34         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
  35         (ppc_ravenscar_powerpc_ops): Redefine.
  36         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
  37         (ppc_ravenscar_e500_ops::fetch_registers)
  38         (ppc_ravenscar_e500_ops::store_registers): Now methods.
  39         (ppc_ravenscar_e500_ops): Redefine.
  40         * aarch64-ravenscar-thread.c
  41         (aarch64_ravenscar_generic_prepare_to_store): Remove.
  42         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
  43         (aarch64_ravenscar_fetch_registers)
  44         (aarch64_ravenscar_store_registers): Now methods.
  45         (aarch64_ravenscar_ops): Redefine.
  46
  47 2019-02-15  Tom Tromey  <tromey@adacore.com>
  48
  49         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
  50         (ravenscar_thread_target::stopped_by_hw_breakpoint)
  51         (ravenscar_thread_target::stopped_by_watchpoint)
  52         (ravenscar_thread_target::stopped_data_address)
  53         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
  54
  55 2019-02-15  Tom Tromey  <tromey@adacore.com>
  56
  57         * ravenscar-thread.c: Fix some typos.
  58
  59 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  60             Tom Tromey  <tromey@adacore.com>
  61
  62         * ada-lang.c (ada_exception_sal): Change addr_string to a
  63         std::string.
  64         (create_ada_exception_catchpoint): Update.
  65
  66 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  67             Tom Tromey  <tromey@adacore.com>
  68
  69         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
  70         (bp_location_ops): Remove.
  71         (base_breakpoint_allocate_location): Update.
  72         (free_bp_location): Update.
  73         * ada-lang.c (class ada_catchpoint_location)
  74         <ada_catchpoint_location>: Remove ops parameter.
  75         (ada_catchpoint_location_dtor): Remove.
  76         (ada_catchpoint_location_ops): Remove.
  77         (allocate_location_exception): Update.
  78         * breakpoint.h (struct bp_location_ops): Remove.
  79         (class bp_location) <bp_location>: Remove bp_location_ops
  80         parameter.
  81         <~bp_location>: Add destructor.
  82         <ops>: Remove.
  83
  84 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  85             Pedro Alves  <palves@redhat.com>
  86
  87         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
  88         'PATH_MAX'.
  89
  90 2019-02-14  David Michael  <fedora.dm0@gmail.com>
  91             Samuel Thibault  <samuel.thibault@gnu.org>
  92             Thomas Schwinge  <thomas@codesourcery.com>
  93
  94         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
  95         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
  96
  97 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  98
  99         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 100         (check_empty): Use "const char *".
 101
 102         * gnu-nat.c (gnu_nat_target::detach): Instead of
 103         'detach_inferior (pid)' call
 104         'detach_inferior (find_inferior_pid (pid))'.
 105
 106         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 107         'nat/fork-inferior.o'.
 108         * gnu-nat.c: #include "nat/fork-inferior.h".
 109
 110         * gnu-nat.c (gnu_nat_target::detach): Instead of
 111         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 112         * gnu-nat.h: #include "inf-child.h".
 113         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 114         'i386_gnu_nat_target::fetch_registers'.
 115         (gnu_store_registers): Rename/move to
 116         'i386_gnu_nat_target::store_registers'.
 117
 118         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 119         * gnu-nat.h (mach_thread_info): New function.
 120         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 121
 122         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 123
 124 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 125
 126         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 127
 128 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 129
 130         * windows-nat.c (windows_add_thread): Add new parameter
 131         "main_thread_p" with default value set to false.  Update
 132         function documentation as well as all callers.
 133         (windows_delete_thread): Likewise.
 134         (fake_create_process): Update call to windows_add_thread.
 135         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 136         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 137         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 138         call to windows_delete_thread.
 139
 140 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 141
 142         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 143
 144 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 145
 146         * symfile.c (find_separate_debug_file): Use canonical path of
 147         sysroot with child_path instead of gdb_sysroot if it is valid.
 148
 149 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 150
 151         * symfile.c (find_separate_debug_file): Use child_path to
 152         determine if an object file is under a sysroot.
 153
 154 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 155
 156         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 157         unittests/child-path-selftests.c.
 158         * common/pathstuff.c (child_path): New function.
 159         * common/pathstuff.h (child_path): New prototype.
 160         * unittests/child-path-selftests.c: New file.
 161
 162 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 163
 164         * symfile.c (find_separate_debug_file): Look for separate debug
 165         files in debug directories under the sysroot.
 166
 167 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 168
 169         * symtab.h (struct minimal_symbol data_p): New const method.
 170         (struct minimal_symbol text_p): Likewise.
 171         * symtab.c (output_source_filename): Use file name style
 172         to print file name.
 173         (print_symbol_info): Likewise.
 174         (print_msymbol_info): Use address style to print addresses.
 175         Use function name style to print executable text symbols.
 176         (expand_symtab_containing_pc): Use data_p.
 177         (find_pc_sect_compunit_symtab): Likewise.
 178
 179 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 180
 181         * breakpoint.c (describe_other_breakpoints): Use address style
 182         to print addresses.
 183         (say_where): Likewise.
 184
 185 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 186
 187         * ada-typeprint.c (print_func_type): Print function name
 188         style to print function name.
 189         * c-typeprint.c (c_print_type_1): Likewise.
 190
 191 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 192
 193         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 194         for execve.
 195
 196 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 197
 198         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 199         type_stack.
 200
 201 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 202
 203         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 204         TYPE_CODE_REF types.
 205
 206 2019-02-08  Jim Wilson  <jimw@sifive.com>
 207
 208         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 209         (riscv_linux_fregset): New.
 210         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 211
 212 2019-02-07  Tom Tromey  <tom@tromey.com>
 213
 214         * thread.c (thread_cancel_execution_command): Update.
 215         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 216         methods.
 217         (struct thread_fsm_ops): Remove.
 218         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 219         (thread_fsm_should_stop, thread_fsm_return_value)
 220         (thread_fsm_set_finished, thread_fsm_finished_p)
 221         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 222         Don't declare.
 223         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 224         * infrun.c (clear_proceed_status_thread)
 225         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 226         (print_stop_event): Update.
 227         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 228         Add constructor.
 229         (step_command_fsm_ops): Remove.
 230         (new_step_command_fsm): Remove.
 231         (step_1): Update.
 232         (step_command_fsm::should_stop): Rename from
 233         step_command_fsm_should_stop.
 234         (step_command_fsm::clean_up): Rename from
 235         step_command_fsm_clean_up.
 236         (step_command_fsm::do_async_reply_reason): Rename from
 237         step_command_fsm_async_reply_reason.
 238         (struct until_next_fsm): Inherit from thread_fsm.  Add
 239         constructor.
 240         (until_next_fsm_ops): Remove.
 241         (new_until_next_fsm): Remove.
 242         (until_next_fsm::should_stop): Rename from
 243         until_next_fsm_should_stop.
 244         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 245         (until_next_fsm::do_async_reply_reason): Rename from
 246         until_next_fsm_async_reply_reason.
 247         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 248         constructor.  Change type of breakpoint.
 249         (finish_command_fsm_ops): Remove.
 250         (new_finish_command_fsm): Remove.
 251         (finish_command_fsm::should_stop): Rename from
 252         finish_command_fsm_should_stop.
 253         (finish_command_fsm::clean_up): Rename from
 254         finish_command_fsm_clean_up.
 255         (finish_command_fsm::return_value): Rename from
 256         finish_command_fsm_return_value.
 257         (finish_command_fsm::do_async_reply_reason): Rename from
 258         finish_command_fsm_async_reply_reason.
 259         (finish_command): Update.
 260         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 261         Add constructor.
 262         (call_thread_fsm_ops): Remove.
 263         (call_thread_fsm::call_thread_fsm): Rename from
 264         new_call_thread_fsm.
 265         (call_thread_fsm::should_stop): Rename from
 266         call_thread_fsm_should_stop.
 267         (call_thread_fsm::should_notify_stop): Rename from
 268         call_thread_fsm_should_notify_stop.
 269         (run_inferior_call, call_function_by_hand_dummy): Update.
 270         * cli/cli-interp.c (should_print_stop_to_console): Update.
 271         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 272         Add constructor.  Change type of location_breakpoint,
 273         caller_breakpoint.
 274         (until_break_fsm_ops): Remove.
 275         (new_until_break_fsm): Remove.
 276         (until_break_fsm::should_stop): Rename from
 277         until_break_fsm_should_stop.
 278         (until_break_fsm::clean_up): Rename from
 279         until_break_fsm_clean_up.
 280         (until_break_fsm::do_async_reply_reason): Rename from
 281         until_break_fsm_async_reply_reason.
 282         (until_break_command): Update.
 283         * thread-fsm.c: Remove.
 284         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 285
 286 2019-02-07  Tom Tromey  <tom@tromey.com>
 287
 288         * yy-remap.h: Add include guard.
 289         * xtensa-tdep.h: Add include guard.
 290         * xcoffread.h: Rename include guard.
 291         * varobj-iter.h: Add include guard.
 292         * tui/tui.h: Rename include guard.
 293         * tui/tui-winsource.h: Rename include guard.
 294         * tui/tui-wingeneral.h: Rename include guard.
 295         * tui/tui-windata.h: Rename include guard.
 296         * tui/tui-win.h: Rename include guard.
 297         * tui/tui-stack.h: Rename include guard.
 298         * tui/tui-source.h: Rename include guard.
 299         * tui/tui-regs.h: Rename include guard.
 300         * tui/tui-out.h: Rename include guard.
 301         * tui/tui-layout.h: Rename include guard.
 302         * tui/tui-io.h: Rename include guard.
 303         * tui/tui-hooks.h: Rename include guard.
 304         * tui/tui-file.h: Rename include guard.
 305         * tui/tui-disasm.h: Rename include guard.
 306         * tui/tui-data.h: Rename include guard.
 307         * tui/tui-command.h: Rename include guard.
 308         * tic6x-tdep.h: Add include guard.
 309         * target/waitstatus.h: Rename include guard.
 310         * target/wait.h: Rename include guard.
 311         * target/target.h: Rename include guard.
 312         * target/resume.h: Rename include guard.
 313         * target-float.h: Rename include guard.
 314         * stabsread.h: Add include guard.
 315         * rs6000-tdep.h: Add include guard.
 316         * riscv-fbsd-tdep.h: Add include guard.
 317         * regformats/regdef.h: Rename include guard.
 318         * record.h: Rename include guard.
 319         * python/python.h: Rename include guard.
 320         * python/python-internal.h: Rename include guard.
 321         * python/py-stopevent.h: Rename include guard.
 322         * python/py-ref.h: Rename include guard.
 323         * python/py-record.h: Rename include guard.
 324         * python/py-record-full.h: Rename include guard.
 325         * python/py-record-btrace.h: Rename include guard.
 326         * python/py-instruction.h: Rename include guard.
 327         * python/py-events.h: Rename include guard.
 328         * python/py-event.h: Rename include guard.
 329         * procfs.h: Add include guard.
 330         * proc-utils.h: Add include guard.
 331         * p-lang.h: Add include guard.
 332         * or1k-tdep.h: Rename include guard.
 333         * observable.h: Rename include guard.
 334         * nto-tdep.h: Rename include guard.
 335         * nat/x86-linux.h: Rename include guard.
 336         * nat/x86-linux-dregs.h: Rename include guard.
 337         * nat/x86-gcc-cpuid.h: Add include guard.
 338         * nat/x86-dregs.h: Rename include guard.
 339         * nat/x86-cpuid.h: Rename include guard.
 340         * nat/ppc-linux.h: Rename include guard.
 341         * nat/mips-linux-watch.h: Rename include guard.
 342         * nat/linux-waitpid.h: Rename include guard.
 343         * nat/linux-ptrace.h: Rename include guard.
 344         * nat/linux-procfs.h: Rename include guard.
 345         * nat/linux-osdata.h: Rename include guard.
 346         * nat/linux-nat.h: Rename include guard.
 347         * nat/linux-namespaces.h: Rename include guard.
 348         * nat/linux-btrace.h: Rename include guard.
 349         * nat/glibc_thread_db.h: Rename include guard.
 350         * nat/gdb_thread_db.h: Rename include guard.
 351         * nat/gdb_ptrace.h: Rename include guard.
 352         * nat/fork-inferior.h: Rename include guard.
 353         * nat/amd64-linux-siginfo.h: Rename include guard.
 354         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 355         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 356         * nat/aarch64-linux.h: Rename include guard.
 357         * nat/aarch64-linux-hw-point.h: Rename include guard.
 358         * mn10300-tdep.h: Add include guard.
 359         * mips-linux-tdep.h: Add include guard.
 360         * mi/mi-parse.h: Rename include guard.
 361         * mi/mi-out.h: Rename include guard.
 362         * mi/mi-main.h: Rename include guard.
 363         * mi/mi-interp.h: Rename include guard.
 364         * mi/mi-getopt.h: Rename include guard.
 365         * mi/mi-console.h: Rename include guard.
 366         * mi/mi-common.h: Rename include guard.
 367         * mi/mi-cmds.h: Rename include guard.
 368         * mi/mi-cmd-break.h: Rename include guard.
 369         * m2-lang.h: Add include guard.
 370         * location.h: Rename include guard.
 371         * linux-record.h: Rename include guard.
 372         * linux-nat.h: Add include guard.
 373         * linux-fork.h: Add include guard.
 374         * i386-darwin-tdep.h: Rename include guard.
 375         * hppa-linux-offsets.h: Add include guard.
 376         * guile/guile.h: Rename include guard.
 377         * guile/guile-internal.h: Rename include guard.
 378         * gnu-nat.h: Rename include guard.
 379         * gdb-stabs.h: Rename include guard.
 380         * frv-tdep.h: Add include guard.
 381         * f-lang.h: Add include guard.
 382         * event-loop.h: Add include guard.
 383         * darwin-nat.h: Rename include guard.
 384         * cp-abi.h: Rename include guard.
 385         * config/sparc/nm-sol2.h: Rename include guard.
 386         * config/nm-nto.h: Rename include guard.
 387         * config/nm-linux.h: Add include guard.
 388         * config/i386/nm-i386gnu.h: Rename include guard.
 389         * config/djgpp/nl_types.h: Rename include guard.
 390         * config/djgpp/langinfo.h: Rename include guard.
 391         * compile/gcc-cp-plugin.h: Add include guard.
 392         * compile/gcc-c-plugin.h: Add include guard.
 393         * compile/compile.h: Rename include guard.
 394         * compile/compile-object-run.h: Rename include guard.
 395         * compile/compile-object-load.h: Rename include guard.
 396         * compile/compile-internal.h: Rename include guard.
 397         * compile/compile-cplus.h: Rename include guard.
 398         * compile/compile-c.h: Rename include guard.
 399         * common/xml-utils.h: Rename include guard.
 400         * common/x86-xstate.h: Rename include guard.
 401         * common/version.h: Rename include guard.
 402         * common/vec.h: Rename include guard.
 403         * common/tdesc.h: Rename include guard.
 404         * common/selftest.h: Rename include guard.
 405         * common/scoped_restore.h: Rename include guard.
 406         * common/scoped_mmap.h: Rename include guard.
 407         * common/scoped_fd.h: Rename include guard.
 408         * common/safe-iterator.h: Rename include guard.
 409         * common/run-time-clock.h: Rename include guard.
 410         * common/refcounted-object.h: Rename include guard.
 411         * common/queue.h: Rename include guard.
 412         * common/ptid.h: Rename include guard.
 413         * common/print-utils.h: Rename include guard.
 414         * common/preprocessor.h: Rename include guard.
 415         * common/pathstuff.h: Rename include guard.
 416         * common/observable.h: Rename include guard.
 417         * common/netstuff.h: Rename include guard.
 418         * common/job-control.h: Rename include guard.
 419         * common/host-defs.h: Rename include guard.
 420         * common/gdb_wait.h: Rename include guard.
 421         * common/gdb_vecs.h: Rename include guard.
 422         * common/gdb_unlinker.h: Rename include guard.
 423         * common/gdb_unique_ptr.h: Rename include guard.
 424         * common/gdb_tilde_expand.h: Rename include guard.
 425         * common/gdb_sys_time.h: Rename include guard.
 426         * common/gdb_string_view.h: Rename include guard.
 427         * common/gdb_splay_tree.h: Rename include guard.
 428         * common/gdb_setjmp.h: Rename include guard.
 429         * common/gdb_ref_ptr.h: Rename include guard.
 430         * common/gdb_optional.h: Rename include guard.
 431         * common/gdb_locale.h: Rename include guard.
 432         * common/gdb_assert.h: Rename include guard.
 433         * common/filtered-iterator.h: Rename include guard.
 434         * common/filestuff.h: Rename include guard.
 435         * common/fileio.h: Rename include guard.
 436         * common/environ.h: Rename include guard.
 437         * common/common-utils.h: Rename include guard.
 438         * common/common-types.h: Rename include guard.
 439         * common/common-regcache.h: Rename include guard.
 440         * common/common-inferior.h: Rename include guard.
 441         * common/common-gdbthread.h: Rename include guard.
 442         * common/common-exceptions.h: Rename include guard.
 443         * common/common-defs.h: Rename include guard.
 444         * common/common-debug.h: Rename include guard.
 445         * common/cleanups.h: Rename include guard.
 446         * common/buffer.h: Rename include guard.
 447         * common/btrace-common.h: Rename include guard.
 448         * common/break-common.h: Rename include guard.
 449         * cli/cli-utils.h: Rename include guard.
 450         * cli/cli-style.h: Rename include guard.
 451         * cli/cli-setshow.h: Rename include guard.
 452         * cli/cli-script.h: Rename include guard.
 453         * cli/cli-interp.h: Rename include guard.
 454         * cli/cli-decode.h: Rename include guard.
 455         * cli/cli-cmds.h: Rename include guard.
 456         * charset-list.h: Add include guard.
 457         * buildsym-legacy.h: Rename include guard.
 458         * bfin-tdep.h: Add include guard.
 459         * ax.h: Rename include guard.
 460         * arm-linux-tdep.h: Add include guard.
 461         * arm-fbsd-tdep.h: Add include guard.
 462         * arch/xtensa.h: Rename include guard.
 463         * arch/tic6x.h: Add include guard.
 464         * arch/i386.h: Add include guard.
 465         * arch/arm.h: Rename include guard.
 466         * arch/arm-linux.h: Rename include guard.
 467         * arch/arm-get-next-pcs.h: Rename include guard.
 468         * arch/amd64.h: Add include guard.
 469         * arch/aarch64-insn.h: Rename include guard.
 470         * arch-utils.h: Rename include guard.
 471         * annotate.h: Add include guard.
 472         * amd64-darwin-tdep.h: Rename include guard.
 473         * aarch64-linux-tdep.h: Add include guard.
 474         * aarch64-fbsd-tdep.h: Add include guard.
 475         * aarch32-linux-nat.h: Add include guard.
 476
 477 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 478
 479         * macrotab.c (macro_define_internal): New function that
 480         factorizes macro_define_object_internal and macro_define_function
 481         code.
 482         (macro_define_object_internal): Use macro_define_internal.
 483         (macro_define_function): Likewise.
 484
 485 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 486
 487         * macrocmd.c (extract_identifier): Return
 488         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 489         callers.
 490
 491 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 492
 493         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 494
 495 2019-02-05  Tom Tromey  <tom@tromey.com>
 496
 497         * target.c (target_stack::unpush): Move assertion earlier.
 498
 499 2019-01-30  Tom Tromey  <tom@tromey.com>
 500
 501         PR python/23615:
 502         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 503         (gdbpy_parse_and_eval): Likewise.
 504         * python/python-internal.h (gdbpy_allow_threads): New class.
 505
 506 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 507
 508         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 509         (aarch64_fbsd_fpregmap): Move earlier.
 510         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 511         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 512         instead of individual calls to trad_frame_set_reg_addr.
 513         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 514         earlier.
 515         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 516         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 517         instead of individual calls to trad_frame_set_reg_addr.
 518
 519 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 520
 521         * CONTRIBUTE: Replace contribution list with wiki link.
 522
 523 2019-01-25  Tom Tromey  <tom@tromey.com>
 524
 525         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 526
 527 2019-01-25  Tom Tromey  <tom@tromey.com>
 528
 529         * xtensa-linux-nat.c: Fix common/ includes.
 530         * xml-support.h: Fix common/ includes.
 531         * xml-support.c: Fix common/ includes.
 532         * x86-linux-nat.c: Fix common/ includes.
 533         * windows-nat.c: Fix common/ includes.
 534         * varobj.h: Fix common/ includes.
 535         * varobj.c: Fix common/ includes.
 536         * value.c: Fix common/ includes.
 537         * valops.c: Fix common/ includes.
 538         * utils.c: Fix common/ includes.
 539         * unittests/xml-utils-selftests.c: Fix common/ includes.
 540         * unittests/utils-selftests.c: Fix common/ includes.
 541         * unittests/unpack-selftests.c: Fix common/ includes.
 542         * unittests/tracepoint-selftests.c: Fix common/ includes.
 543         * unittests/style-selftests.c: Fix common/ includes.
 544         * unittests/string_view-selftests.c: Fix common/ includes.
 545         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 546         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 547         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 548         * unittests/rsp-low-selftests.c: Fix common/ includes.
 549         * unittests/parse-connection-spec-selftests.c: Fix common/
 550         includes.
 551         * unittests/optional-selftests.c: Fix common/ includes.
 552         * unittests/offset-type-selftests.c: Fix common/ includes.
 553         * unittests/observable-selftests.c: Fix common/ includes.
 554         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 555         * unittests/memrange-selftests.c: Fix common/ includes.
 556         * unittests/memory-map-selftests.c: Fix common/ includes.
 557         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 558         * unittests/function-view-selftests.c: Fix common/ includes.
 559         * unittests/environ-selftests.c: Fix common/ includes.
 560         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 561         * unittests/common-utils-selftests.c: Fix common/ includes.
 562         * unittests/cli-utils-selftests.c: Fix common/ includes.
 563         * unittests/array-view-selftests.c: Fix common/ includes.
 564         * ui-file.c: Fix common/ includes.
 565         * tui/tui-io.c: Fix common/ includes.
 566         * tracepoint.h: Fix common/ includes.
 567         * tracepoint.c: Fix common/ includes.
 568         * tracefile-tfile.c: Fix common/ includes.
 569         * top.h: Fix common/ includes.
 570         * top.c: Fix common/ includes.
 571         * thread.c: Fix common/ includes.
 572         * target/waitstatus.h: Fix common/ includes.
 573         * target/waitstatus.c: Fix common/ includes.
 574         * target.h: Fix common/ includes.
 575         * target.c: Fix common/ includes.
 576         * target-memory.c: Fix common/ includes.
 577         * target-descriptions.c: Fix common/ includes.
 578         * symtab.h: Fix common/ includes.
 579         * symfile.c: Fix common/ includes.
 580         * stap-probe.c: Fix common/ includes.
 581         * spu-linux-nat.c: Fix common/ includes.
 582         * sparc-nat.c: Fix common/ includes.
 583         * source.c: Fix common/ includes.
 584         * solib.c: Fix common/ includes.
 585         * solib-target.c: Fix common/ includes.
 586         * ser-unix.c: Fix common/ includes.
 587         * ser-tcp.c: Fix common/ includes.
 588         * ser-pipe.c: Fix common/ includes.
 589         * ser-base.c: Fix common/ includes.
 590         * selftest-arch.c: Fix common/ includes.
 591         * s12z-tdep.c: Fix common/ includes.
 592         * rust-exp.y: Fix common/ includes.
 593         * rs6000-aix-tdep.c: Fix common/ includes.
 594         * riscv-tdep.c: Fix common/ includes.
 595         * remote.c: Fix common/ includes.
 596         * remote-notif.h: Fix common/ includes.
 597         * remote-fileio.h: Fix common/ includes.
 598         * remote-fileio.c: Fix common/ includes.
 599         * regcache.h: Fix common/ includes.
 600         * regcache.c: Fix common/ includes.
 601         * record-btrace.c: Fix common/ includes.
 602         * python/python.c: Fix common/ includes.
 603         * python/py-type.c: Fix common/ includes.
 604         * python/py-inferior.c: Fix common/ includes.
 605         * progspace.h: Fix common/ includes.
 606         * producer.c: Fix common/ includes.
 607         * procfs.c: Fix common/ includes.
 608         * proc-api.c: Fix common/ includes.
 609         * printcmd.c: Fix common/ includes.
 610         * ppc-linux-nat.c: Fix common/ includes.
 611         * parser-defs.h: Fix common/ includes.
 612         * osdata.c: Fix common/ includes.
 613         * obsd-nat.c: Fix common/ includes.
 614         * nat/x86-linux.c: Fix common/ includes.
 615         * nat/x86-linux-dregs.c: Fix common/ includes.
 616         * nat/x86-dregs.h: Fix common/ includes.
 617         * nat/x86-dregs.c: Fix common/ includes.
 618         * nat/ppc-linux.c: Fix common/ includes.
 619         * nat/mips-linux-watch.h: Fix common/ includes.
 620         * nat/mips-linux-watch.c: Fix common/ includes.
 621         * nat/linux-waitpid.c: Fix common/ includes.
 622         * nat/linux-ptrace.h: Fix common/ includes.
 623         * nat/linux-ptrace.c: Fix common/ includes.
 624         * nat/linux-procfs.c: Fix common/ includes.
 625         * nat/linux-personality.c: Fix common/ includes.
 626         * nat/linux-osdata.c: Fix common/ includes.
 627         * nat/linux-namespaces.c: Fix common/ includes.
 628         * nat/linux-btrace.h: Fix common/ includes.
 629         * nat/linux-btrace.c: Fix common/ includes.
 630         * nat/fork-inferior.c: Fix common/ includes.
 631         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 632         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 633         * nat/aarch64-linux.c: Fix common/ includes.
 634         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 635         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 636         * namespace.h: Fix common/ includes.
 637         * mips-linux-tdep.c: Fix common/ includes.
 638         * minsyms.c: Fix common/ includes.
 639         * mi/mi-parse.h: Fix common/ includes.
 640         * mi/mi-main.c: Fix common/ includes.
 641         * mi/mi-cmd-env.c: Fix common/ includes.
 642         * memrange.h: Fix common/ includes.
 643         * memattr.c: Fix common/ includes.
 644         * maint.h: Fix common/ includes.
 645         * maint.c: Fix common/ includes.
 646         * main.c: Fix common/ includes.
 647         * machoread.c: Fix common/ includes.
 648         * location.c: Fix common/ includes.
 649         * linux-thread-db.c: Fix common/ includes.
 650         * linux-nat.c: Fix common/ includes.
 651         * linux-fork.c: Fix common/ includes.
 652         * inline-frame.c: Fix common/ includes.
 653         * infrun.c: Fix common/ includes.
 654         * inflow.c: Fix common/ includes.
 655         * inferior.h: Fix common/ includes.
 656         * inferior.c: Fix common/ includes.
 657         * infcmd.c: Fix common/ includes.
 658         * inf-ptrace.c: Fix common/ includes.
 659         * inf-child.c: Fix common/ includes.
 660         * ia64-linux-nat.c: Fix common/ includes.
 661         * i387-tdep.c: Fix common/ includes.
 662         * i386-tdep.c: Fix common/ includes.
 663         * i386-linux-tdep.c: Fix common/ includes.
 664         * i386-linux-nat.c: Fix common/ includes.
 665         * i386-go32-tdep.c: Fix common/ includes.
 666         * i386-fbsd-tdep.c: Fix common/ includes.
 667         * i386-fbsd-nat.c: Fix common/ includes.
 668         * guile/scm-type.c: Fix common/ includes.
 669         * guile/guile.c: Fix common/ includes.
 670         * go32-nat.c: Fix common/ includes.
 671         * gnu-nat.c: Fix common/ includes.
 672         * gdbthread.h: Fix common/ includes.
 673         * gdbarch-selftests.c: Fix common/ includes.
 674         * gdb_usleep.c: Fix common/ includes.
 675         * gdb_select.h: Fix common/ includes.
 676         * gdb_bfd.c: Fix common/ includes.
 677         * gcore.c: Fix common/ includes.
 678         * fork-child.c: Fix common/ includes.
 679         * findvar.c: Fix common/ includes.
 680         * fbsd-nat.c: Fix common/ includes.
 681         * event-top.c: Fix common/ includes.
 682         * event-loop.c: Fix common/ includes.
 683         * dwarf2read.c: Fix common/ includes.
 684         * dwarf2loc.c: Fix common/ includes.
 685         * dwarf2-frame.c: Fix common/ includes.
 686         * dwarf-index-cache.c: Fix common/ includes.
 687         * dtrace-probe.c: Fix common/ includes.
 688         * disasm-selftests.c: Fix common/ includes.
 689         * defs.h: Fix common/ includes.
 690         * csky-tdep.c: Fix common/ includes.
 691         * cp-valprint.c: Fix common/ includes.
 692         * cp-support.h: Fix common/ includes.
 693         * cp-support.c: Fix common/ includes.
 694         * corelow.c: Fix common/ includes.
 695         * completer.h: Fix common/ includes.
 696         * completer.c: Fix common/ includes.
 697         * compile/compile.c: Fix common/ includes.
 698         * compile/compile-loc2c.c: Fix common/ includes.
 699         * compile/compile-cplus-types.c: Fix common/ includes.
 700         * compile/compile-cplus-symbols.c: Fix common/ includes.
 701         * command.h: Fix common/ includes.
 702         * cli/cli-dump.c: Fix common/ includes.
 703         * cli/cli-cmds.c: Fix common/ includes.
 704         * charset.c: Fix common/ includes.
 705         * build-id.c: Fix common/ includes.
 706         * btrace.h: Fix common/ includes.
 707         * btrace.c: Fix common/ includes.
 708         * breakpoint.h: Fix common/ includes.
 709         * breakpoint.c: Fix common/ includes.
 710         * ax.h:
 711         (enum agent_op): Fix common/ includes.
 712         * ax-general.c (struct aop_map): Fix common/ includes.
 713         * ax-gdb.c: Fix common/ includes.
 714         * auxv.c: Fix common/ includes.
 715         * auto-load.c: Fix common/ includes.
 716         * arm-tdep.c: Fix common/ includes.
 717         * arch/riscv.c: Fix common/ includes.
 718         * arch/ppc-linux-common.c: Fix common/ includes.
 719         * arch/i386.c: Fix common/ includes.
 720         * arch/arm.c: Fix common/ includes.
 721         * arch/arm-linux.c: Fix common/ includes.
 722         * arch/arm-get-next-pcs.c: Fix common/ includes.
 723         * arch/amd64.c: Fix common/ includes.
 724         * arch/aarch64.c: Fix common/ includes.
 725         * arch/aarch64-insn.c: Fix common/ includes.
 726         * arch-utils.c: Fix common/ includes.
 727         * amd64-windows-tdep.c: Fix common/ includes.
 728         * amd64-tdep.c: Fix common/ includes.
 729         * amd64-sol2-tdep.c: Fix common/ includes.
 730         * amd64-obsd-tdep.c: Fix common/ includes.
 731         * amd64-nbsd-tdep.c: Fix common/ includes.
 732         * amd64-linux-tdep.c: Fix common/ includes.
 733         * amd64-linux-nat.c: Fix common/ includes.
 734         * amd64-fbsd-tdep.c: Fix common/ includes.
 735         * amd64-fbsd-nat.c: Fix common/ includes.
 736         * amd64-dicos-tdep.c: Fix common/ includes.
 737         * amd64-darwin-tdep.c: Fix common/ includes.
 738         * agent.c: Fix common/ includes.
 739         * ada-lang.h: Fix common/ includes.
 740         * ada-lang.c: Fix common/ includes.
 741         * aarch64-tdep.c: Fix common/ includes.
 742
 743 2019-01-25  Tom Tromey  <tom@tromey.com>
 744
 745         * common/create-version.sh: Use common/version.h.
 746
 747 2019-01-24  Pedro Alves  <palves@redhat.com>
 748
 749         * infrun.c (signal_stop, signal_print, signal_program)
 750         (signal_catch, signal_pass): Now arrays instead of pointers.
 751         (update_signals_program_target, do_target_resume)
 752         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 753         * linux-nat.c (linux_nat_target::pass_signals)
 754         (linux_nat_target::create_inferior, linux_nat_target::attach):
 755         Adjust.
 756         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 757         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 758         * procfs.c (procfs_target::pass_signals): Adjust.
 759         * record-full.c (record_full_target::resume): Adjust.
 760         * remote.c (remote_target::pass_signals)
 761         (remote_target::program_signals): Adjust.
 762         * target-debug.h (target_debug_print_signals): Now takes a
 763         gdb::array_view as parameter.  Adjust.
 764         * target.h (target_ops) <pass_signals, program_signals>: Replace
 765         pointer and length parameters with gdb::array_view.
 766         (target_pass_signals, target_program_signals): Likewise.
 767         * target-delegates.c: Regenerate.
 768
 769 2019-01-24  Pedro Alves  <palves@redhat.com>
 770
 771         * common/forward-scope-exit.h
 772         (forward_scope_exit::forward_scope_exit): Pass arguments to
 773         m_bind_function directly, instead of creating a std::bind and
 774         copying that.
 775
 776 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 777
 778         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 779         for static members.
 780         (pass_in_v_vfp_candidate): Likewise.
 781
 782 2019-01-23  Tom Tromey  <tom@tromey.com>
 783             Pedro Alves  <palves@redhat.com>
 784
 785         * regcache.c (class regcache_invalidator): Remove.
 786         (regcache::raw_write): Use make_scope_exit.
 787
 788 2019-01-23  Tom Tromey  <tom@tromey.com>
 789
 790         * ui-out.h (class ui_out_emit_type): Update comment.
 791
 792 2019-01-23  Tom Tromey  <tom@tromey.com>
 793
 794         * infrun.c (fetch_inferior_event): Update comment.
 795
 796 2019-01-23  Tom Tromey  <tom@tromey.com>
 797             Pedro Alves  <palves@redhat.com>
 798
 799         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 800         parameter.
 801         (fetch_inferior_event): Use SCOPE_EXIT.
 802
 803
 804 2019-01-23  Tom Tromey  <tom@tromey.com>
 805             Pedro Alves  <palves@redhat.com>
 806
 807         * infrun.c (disable_thread_events): Delete.
 808         (stop_all_threads): Use SCOPE_EXIT.
 809
 810 2019-01-23  Tom Tromey  <tom@tromey.com>
 811             Pedro Alves  <palves@redhat.com>
 812
 813         * symfile.c: Include forward-scope-exit.h.
 814         (clear_symtab_users_cleanup): Replace forward declaration with
 815         a FORWARD_SCOPE_EXIT.
 816         (syms_from_objfile_1): Use the forward_scope_exit and
 817         gdb::optional instead of cleanup_function.
 818         (reread_symbols): Use the forward_scope_exit instead of
 819         cleanup_function.
 820         (clear_symtab_users_cleanup): Remove function.
 821
 822 2019-01-23  Tom Tromey  <tom@tromey.com>
 823             Pedro Alves  <palves@redhat.com>
 824
 825         * linux-nat.c: Include scope-exit.h.
 826         (cleanup_target_stop): Remove.
 827         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 828         SCOPE_EXIT.
 829
 830 2019-01-23  Tom Tromey  <tom@tromey.com>
 831             Pedro Alves  <palves@redhat.com>
 832
 833         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 834         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 835
 836 2019-01-23  Tom Tromey  <tom@tromey.com>
 837             Andrew Burgess  <andrew.burgess@embecosm.com>
 838             Pedro Alves  <palves@redhat.com>
 839
 840         * infrun.c (fetch_inferior_event): Use scope_exit.
 841         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 842         * top.c (execute_command): Use scope_exit.
 843         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 844         * utils.c (do_bpstat_clear_actions_cleanup)
 845         (make_bpstat_clear_actions_cleanup): Remove.
 846
 847 2019-01-23  Tom Tromey  <tom@tromey.com>
 848             Pedro Alves  <palves@redhat.com>
 849
 850         * infrun.c: Include "common/scope-exit.h"
 851         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 852         (wait_for_inferior): Use SCOPE_EXIT.
 853         (fetch_inferior_event): Use scope_exit.
 854
 855 2019-01-23  Tom Tromey  <tom@tromey.com>
 856             Pedro Alves  <palves@redhat.com>
 857
 858         * breakpoint.c (create_breakpoint): Remove cleanup.
 859
 860 2019-01-23  Tom Tromey  <tom@tromey.com>
 861             Andrew Burgess  <andrew.burgess@embecosm.com>
 862             Pedro Alves  <palves@redhat.com>
 863
 864 2019-01-23  Pedro Alves  <palves@redhat.com>
 865
 866         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 867
 868 2019-01-23  Pedro Alves  <palves@redhat.com>
 869             Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * gdbthread.h: Include "common/forward-scope-exit.h".
 872         (scoped_finish_thread_state): Redefine custom class in terms of
 873         forward_scope_exit.
 874
 875 2019-01-23  Pedro Alves  <palves@redhat.com>
 876             Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * common/forward-scope-exit.h: New file.
 879
 880 2019-01-23  Pedro Alves  <palves@redhat.com>
 881             Andrew Burgess  <andrew.burgess@embecosm.com>
 882             Tom Tromey  <tom@tromey.com>
 883
 884         * common/scope-exit.h: New file.
 885
 886 2019-01-23  Pedro Alves  <palves@redhat.com>
 887
 888         * common/preprocessor.h (ESC): Rename to ...
 889         (ESC_PARENS): ... this.
 890         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 891         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 892
 893 2019-01-23  Tom Tromey  <tom@tromey.com>
 894
 895         * language.h (class scoped_switch_to_sym_language_if_auto):
 896         Initialize m_lang in both cases.
 897
 898 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 899
 900         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 901         with XCNEW.
 902
 903 2019-01-22  Tom Tromey  <tom@tromey.com>
 904
 905         * corelow.c: Do not include sys/file.h.
 906
 907 2019-01-22  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-wingeneral.h: Include gdb_curses.h.
 910
 911 2019-01-22  Tom Tromey  <tom@tromey.com>
 912
 913         * source-cache.h (class source_cache) <get_source_lines,
 914         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 915
 916 2019-01-22  Tom Tromey  <tom@tromey.com>
 917
 918         * remote-fileio.h (struct remote_target): Declare.
 919
 920 2019-01-22  Tom Tromey  <tom@tromey.com>
 921
 922         * python/py-arch.c: Do not include py-ref.h.
 923         * python/py-bpevent.c: Do not include py-ref.h.
 924         * python/py-cmd.c: Do not include py-ref.h.
 925         * python/py-continueevent.c: Do not include py-ref.h.
 926         * python/py-event.h: Do not include py-ref.h.
 927         * python/py-evtregistry.c: Do not include py-ref.h.
 928         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 929         * python/py-frame.c: Do not include py-ref.h.
 930         * python/py-framefilter.c: Do not include py-ref.h.
 931         * python/py-function.c: Do not include py-ref.h.
 932         * python/py-infevents.c: Do not include py-ref.h.
 933         * python/py-linetable.c: Do not include py-ref.h.
 934         * python/py-objfile.c: Do not include py-ref.h.
 935         * python/py-param.c: Do not include py-ref.h.
 936         * python/py-prettyprint.c: Do not include py-ref.h.
 937         * python/py-progspace.c: Do not include py-ref.h.
 938         * python/py-symbol.c: Do not include py-ref.h.
 939         * python/py-symtab.c: Do not include py-ref.h.
 940         * python/py-type.c: Do not include py-ref.h.
 941         * python/py-unwind.c: Do not include py-ref.h.
 942         * python/py-utils.c: Do not include py-ref.h.
 943         * python/py-value.c: Do not include py-ref.h.
 944         * python/py-varobj.c: Do not include py-ref.h.
 945         * python/py-xmethods.c: Do not include py-ref.h.
 946         * python/python.c: Do not include py-ref.h.
 947         * varobj.c: Do not include py-ref.h.
 948
 949 2019-01-22  Tom Tromey  <tom@tromey.com>
 950
 951         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 952         keyword for bcache.
 953
 954 2019-01-22  Tom Tromey  <tom@tromey.com>
 955
 956         * compile/compile-cplus-types.c: Remove a comment by #include.
 957
 958 2019-01-22  Tom Tromey  <tom@tromey.com>
 959
 960         * compile/gcc-c-plugin.h: Include compile-internal.h.
 961
 962 2019-01-22  Tom Tromey  <tom@tromey.com>
 963
 964         * stabsread.c (EXTERN): Do not define.
 965         (symnum, next_symbol_text_func, processing_gcc_compilation)
 966         (within_function, global_sym_chain, global_stabs)
 967         (previous_stab_code, this_object_header_files)
 968         (n_this_object_header_files)
 969         (n_allocated_this_object_header_files): Define.
 970         * stabsread.h (EXTERN): Never define.  Use "extern".
 971
 972 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 973
 974         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 975         history_value.
 976
 977 2019-01-21  Tom Tromey  <tom@tromey.com>
 978
 979         * ui-out.c: Fix includes.
 980         * tui/tui-source.c: Fix includes.
 981         * target.c: Fix includes.
 982         * remote.c: Fix includes.
 983         * regcache.c: Fix includes.
 984         * python/py-block.c: Fix includes.
 985         * printcmd.c: Fix includes.
 986         * or1k-tdep.c: Fix includes.
 987         * mi/mi-main.c: Fix includes.
 988         * m32r-tdep.c: Fix includes.
 989         * csky-tdep.c: Fix includes.
 990         * compile/compile-cplus-types.c: Fix includes.
 991         * cli/cli-interp.c: Fix includes.
 992
 993 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 994
 995         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 996         for padding.
 997
 998 2019-01-16  Tom Tromey  <tom@tromey.com>
 999
1000         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1001         earlier.
1002         (struct objfile) <msymbols_range>: Move from top level.
1003         <msymbols>: New method.
1004         (class objfile_msymbols): Remove.
1005         * symtab.c (default_collect_symbol_completion_matches_break_on):
1006         Update.
1007         * symmisc.c (dump_msymbols): Update.
1008         * stabsread.c (scan_file_globals): Update.
1009         * objc-lang.c (info_selectors_command, info_classes_command)
1010         (find_methods): Update.
1011         * minsyms.c (find_solib_trampoline_target): Update.
1012         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1013         * coffread.c (coff_symfile_read): Update.
1014         * ada-lang.c (ada_lookup_simple_minsym)
1015         (ada_collect_symbol_completion_matches): Update.
1016
1017 2019-01-16  Tom Tromey  <tom@tromey.com>
1018
1019         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1020         type.  Remove no-argument constructor.
1021         <iterator::operator++>: Simplify.
1022         <begin>: Update.
1023         <end>: Use minimal_symbol_count.
1024
1025 2019-01-16  Tom Tromey  <tom@tromey.com>
1026
1027         * objfiles.h (struct objfile) <psymtabs>: New method.
1028         (class objfile_psymtabs): Remove.
1029         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1030         typedef.
1031         <range>: New method.
1032         (require_partial_symbols): Change return type.
1033         * psymtab.c (require_partial_symbols)
1034         (psym_expand_symtabs_matching): Update.
1035         * mdebugread.c (parse_partial_symbols): Update.
1036         * dbxread.c (dbx_end_psymtab): Update.
1037
1038 2019-01-15  Tom Tromey  <tom@tromey.com>
1039
1040         * symtab.c (lookup_objfile_from_block)
1041         (lookup_symbol_in_objfile_symtabs)
1042         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1043         (find_line_symtab, info_sources_command)
1044         (default_collect_symbol_completion_matches_break_on)
1045         (make_source_files_completion_list): Update.
1046         * symmisc.c (print_objfile_statistics, dump_objfile)
1047         (maintenance_print_symbols, maintenance_info_symtabs)
1048         (maintenance_check_symtabs, maintenance_info_line_tables):
1049         Update.
1050         * source.c (select_source_symtab)
1051         (forget_cached_source_info_for_objfile): Update.
1052         * objfiles.h (class objfile_compunits): Remove.
1053         (struct objfile) <compunits_range>: New typedef.
1054         (compunits): New method.
1055         * objfiles.c (objfile_relocate1): Update.
1056         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1057         * maint.c (count_symtabs_and_blocks): Update.
1058         * linespec.c (iterate_over_all_matching_symtabs): Update.
1059         * cp-support.c (add_symbol_overload_list_qualified): Update.
1060         * coffread.c (coff_symtab_read): Update.
1061         * ada-lang.c (add_nonlocal_symbols)
1062         (ada_collect_symbol_completion_matches)
1063         (ada_add_global_exceptions): Update.
1064
1065 2019-01-15  Tom Tromey  <tom@tromey.com>
1066
1067         * progspace.h (program_space) <objfiles_safe_range>: New
1068         typedef.
1069         <objfiles_safe>: New method.
1070         * objfiles.h (class all_objfiles_safe): Remove.
1071         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1072         * jit.c (jit_inferior_exit_hook): Update.
1073
1074 2019-01-17  Tom Tromey  <tom@tromey.com>
1075
1076         * progspace.h (program_space) <objfiles_range>: New typedef.
1077         <objfiles>: New method.
1078         <objfiles_head>: Rename from objfiles.
1079         (object_files): Update.
1080         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1081         * guile/scm-pretty-print.c
1082         (ppscm_find_pretty_printer_from_objfiles): Update.
1083         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1084         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1085         Update.
1086         * python/py-progspace.c (pspy_get_objfiles): Update.
1087         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1088         Update.
1089         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1090         (objfpy_lookup_objfile_by_build_id): Update.
1091         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1092         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1093         Update.
1094         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1095         (expand_symtab_containing_pc, lookup_objfile_from_block)
1096         (lookup_static_symbol, basic_lookup_transparent_type)
1097         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1098         (find_line_symtab, info_sources_command)
1099         (default_collect_symbol_completion_matches_break_on)
1100         (make_source_files_completion_list, find_main_name): Update.
1101         * symmisc.c (print_symbol_bcache_statistics)
1102         (print_objfile_statistics, maintenance_print_symbols)
1103         (maintenance_print_msymbols, maintenance_print_objfiles)
1104         (maintenance_info_symtabs, maintenance_check_symtabs)
1105         (maintenance_expand_symtabs, maintenance_info_line_tables):
1106         Update.
1107         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1108         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1109         (map_overlay_command, unmap_overlay_command)
1110         (simple_overlay_update, expand_symtabs_matching)
1111         (map_symbol_filenames): Update.
1112         * symfile-debug.c (set_debug_symfile): Update.
1113         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1114         Update.
1115         * source.c (select_source_symtab, forget_cached_source_info):
1116         Update.
1117         * solib.c (solib_read_symbols): Update.
1118         * solib-spu.c (append_ocl_sos): Update.
1119         * psymtab.c (maintenance_print_psymbols)
1120         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1121         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1122         * printcmd.c (info_symbol_command): Update.
1123         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1124         Update.
1125         * objfiles.h (class all_objfiles): Remove.
1126         * objfiles.c (have_partial_symbols, have_full_symbols)
1127         (have_minimal_symbols, qsort_cmp, update_section_map)
1128         (shared_objfile_contains_address_p)
1129         (default_iterate_over_objfiles_in_search_order): Update.
1130         * objc-lang.c (info_selectors_command, info_classes_command)
1131         (find_methods): Update.
1132         * minsyms.c (find_solib_trampoline_target): Update.
1133         * maint.c (maintenance_info_sections)
1134         (maintenance_translate_address, count_symtabs_and_blocks):
1135         Update.
1136         * main.c (captured_main_1): Update.
1137         * linux-thread-db.c (try_thread_db_load_from_pdir)
1138         (has_libpthread): Update.
1139         * linespec.c (iterate_over_all_matching_symtabs)
1140         (search_minsyms_for_name): Update.
1141         * jit.c (jit_find_objf_with_entry_addr): Update.
1142         * hppa-tdep.c (find_unwind_entry)
1143         (hppa_lookup_stub_minimal_symbol): Update.
1144         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1145         Update.
1146         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1147         (elf_gnu_ifunc_resolve_by_got): Update.
1148         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1149         * dwarf-index-write.c (save_gdb_index_command): Update.
1150         * cp-support.c (add_symbol_overload_list_qualified): Update.
1151         * breakpoint.c (create_overlay_event_breakpoint)
1152         (create_longjmp_master_breakpoint)
1153         (create_std_terminate_master_breakpoint)
1154         (create_exception_master_breakpoint): Update.
1155         * blockframe.c (find_pc_partial_function): Update.
1156         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1157         (ada_collect_symbol_completion_matches)
1158         (ada_add_global_exceptions): Update.
1159
1160 2019-01-17  Tom Tromey  <tom@tromey.com>
1161
1162         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1163         declare VEC.
1164         (solib_target_parse_libraries): Change return type.
1165         (library_list_start_segment, library_list_start_section)
1166         (library_list_end_library, library_list_start_library); Update.
1167         (solib_target_free_library_list): Remove.
1168         (solib_target_parse_libraries): Remove cleanup.  Change return
1169         type.
1170         (solib_target_current_sos): Update.
1171
1172 2019-01-17  Tom Tromey  <tromey@bapiya>
1173
1174         * valprint.c: Replace "the the" with "the".
1175         * symtab.c: Replace "the the" with "the".
1176         * solib.c: Replace "the the" with "the".
1177         * solib-dsbt.c: Replace "the the" with "the".
1178         * linespec.c: Replace "the the" with "the".
1179         * dwarf2loc.h: Replace "the the" with "the".
1180         * amd64-windows-tdep.c: Replace "the the" with "the".
1181         * aarch64-tdep.c: Replace "the the" with "the".
1182
1183 2019-01-16  Keith Seitz  <keiths@redhat.com>
1184
1185         PR gdb/23773
1186         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1187         <builder>: Rename to ..
1188         <m_builder>: ... this and make private.
1189         (dwarf2_cu::get_builder): New method.  Change all users of
1190         `builder' to use this method.
1191         (dwarf2_start_symtab): Move to ...
1192         (dwarf2_cu::start_symtab): ... here.  Update all callers
1193         (setup_type_unit_groups): Move to ...
1194         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1195         callers.
1196         (dwarf2_cu::reset_builder): New method.
1197         (process_full_compunit, process_full_type_unit): Use
1198         dwarf2_cu::reset_builder.
1199         (follow_die_offset): Record the ancestor CU if it is different
1200         from the followed DIE's CU.
1201         (follow_die_sig_1): Likewise.
1202
1203 2019-01-15  Tom Tromey  <tom@tromey.com>
1204
1205         * remote.c (class remote_state) <buf>: Now a char_vector.
1206         <buf_size>: Remove.
1207         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1208         parameter.
1209         (remote_target::getpkt_or_notif_sane_1)
1210         (remote_target::getpkt_sane)
1211         (remote_target::getpkt_or_notif_sane): Likewise.
1212         (class remote_target) <putpkt>: New overload.
1213         (remote_target::read_frame): Change type of "buf_p".  Remove
1214         sizeof_p parameter.
1215         (packet_ok): New overload.
1216         (packet_check_result): New overload.
1217         Update all uses.
1218
1219 2019-01-14  Tom Tromey  <tom@tromey.com>
1220
1221         * remote-notif.c (handle_notification, remote_notif_ack)
1222         (remote_notif_parse): Make "buf" const.
1223         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1224         const.
1225         (remote_notif_parse, remote_notif_ack, handle_notification):
1226         Likewise.
1227         * remote.c (remote_notif_stop_parse): Make "buf" const.
1228         (remote_target::remote_parse_stop_reply): Make "buf" const.
1229         (remote_notif_stop_ack): Make "buf" const.
1230
1231 2019-01-14  Tom Tromey  <tom@tromey.com>
1232
1233         * remote.c (remote_console_output): Make parameter const.
1234
1235 2019-01-14  Tom Tromey  <tom@tromey.com>
1236
1237         * target-debug.h (target_debug_print_signals): Constify.
1238         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1239         * procfs.c (procfs_target::pass_signals): Update.
1240         * linux-nat.c (linux_nat_target::pass_signals): Update.
1241         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1242         * target-delegates.c: Rebuild.
1243         * remote.c (remote_target::program_signals): Update.
1244         (remote_target::pass_signals): Update.
1245         * target.c (target_pass_signals): Constify argument.
1246         (target_program_signals): Likewise.
1247         * target.h (struct target_ops) <pass_signals, program_signals>:
1248         Constify argument.
1249         (target_pass_signals, target_program_signals): Constify argument.
1250
1251 2019-01-14  Tom Tromey  <tom@tromey.com>
1252
1253         PR tui/28819:
1254         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1255
1256 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1257
1258         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1259         field.
1260         * rs6000-tdep.c: Include reggroups.h.
1261         (IS_V_ALIAS_PSEUDOREG): Define.
1262         (rs6000_register_name): Return names for the "vX" aliases.
1263         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1264         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1265         aliases.  Call default_register_reggroup_p for all other
1266         pseudo-registers.
1267         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1268         New functions.
1269         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1270         Handle "vX" aliases.
1271         (v_alias_pseudo_register_collect): New function.
1272         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1273         (rs6000_gdbarch_init): Initialize "vX" aliases as
1274         pseudo-registers.  Restore registration of
1275         rs6000_pseudo_register_reggroup_p with
1276         set_tdesc_pseudo_register_reggroup_p.
1277
1278 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1279
1280         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1281         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1282         set_gdbarch_num_pseudo_regs.
1283
1284 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1285
1286         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1287         Remove arg prefixname, add do_set and do_show.
1288         Add member functions set_list and show_list.
1289         * cli/cli-style.c (class cli_style_option): Update accordingly.
1290         (style_set_list): Move to file scope.
1291         (style_show_list): Likewise.
1292         (set_style): Call help_list.
1293         (show_style): Call cmd_show_list.
1294         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1295         Update to use the new macro.
1296
1297 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1298
1299         * ada-lang.c (_initialize_ada_language): Expand the help text
1300         for the "catch exception" command.
1301
1302 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1303
1304         * symtab.c (matching_obj_sections): Initialize obj,
1305         declare it closer to its usage.
1306
1307 2019-01-10  Tom Tromey  <tom@tromey.com>
1308
1309         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1310         (basic_inf_threads_range): Remove.
1311         (inf_threads_range, inf_non_exited_threads_range)
1312         (safe_inf_threads_range): Use next_adapter.
1313
1314 2019-01-10  Keith Seitz  <keiths@redhat.com>
1315
1316         PR gdb/23712
1317         PR symtab/23010
1318         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1319         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1320
1321 2019-01-10  Keith Seitz  <keiths@redhat.com>
1322
1323         PR gdb/23712
1324         PR symtab/23010
1325         * dictionary.c (pending_to_vector): Remove.
1326         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1327         Remove _1 suffix, replacing functions of the same name.  Update
1328         all callers.
1329         (dict_create_hashed, dict_create_hashed_expandable)
1330         (dict_create_linear, dict_create_linear_expandable, dict_free)
1331         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1332         Make functions static.
1333
1334 2019-01-10  Keith Seitz  <keiths@redhat.com>
1335
1336         PR gdb/23712
1337         PR symtab/23010
1338         * dictionary.h (struct dictionary): Replace declaration with
1339         multidictionary.
1340         (dict_create_hashed, dict_create_hashed_expandable)
1341         (dict_create_linear, dict_create_linear_expandable)
1342         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1343         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1344         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1345         taking multidictionary argument.
1346         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1347         * block.h (struct block) <dict>: Change to multidictionary
1348         and rename `multidict'.
1349         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1350         symmisc.c: Update all dictionary references to multidictionary.
1351
1352 2019-01-10  Keith Seitz  <keiths@redhat.com>
1353
1354         PR gdb/23712
1355         PR symtab/23010
1356         * dictionary.c: Include unordered_map.
1357         (pending_to_vector): New function.
1358         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1359         Rewrite the non-"_1" functions to take vector instead
1360         of linked list.
1361         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1362         "new" _1 versions of the same name.
1363         (multidictionary): Define.
1364         (std::hash<enum language): New definition.
1365         (collate_pending_symbols_by_language, mdict_create_hashed)
1366         (mdict_create_hashed_expandable, mdict_create_linear)
1367         (mdict_create_linear_expandable, mdict_free)
1368         (find_language_dictionary, create_new_language_dictionary)
1369         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1370         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1371         (mdict_size, mdict_empty): New functions.
1372         * dictionary.h (mdict_iterator): Define.
1373
1374 2019-01-10  Pedro Alves  <palves@redhat.com>
1375
1376         * breakpoint.c (read_uploaded_action)
1377         (create_tracepoint_from_upload): Adjust to use
1378         gdb::unique_xmalloc_ptr.
1379         * ctf.c (ctf_write_uploaded_tp):
1380         (SET_ARRAY_FIELD): Use emplace_back.
1381         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1382         * tracefile-tfile.c (tfile_write_uploaded_tp):
1383         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1384         gdb::unique_xmalloc_ptr.
1385         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1386         at_string, cond_string, cmd_strings>: Replace char pointers
1387         with gdb::unique_xmalloc_ptr.
1388
1389 2019-01-10  Pedro Alves  <palves@redhat.com>
1390
1391         * solib-target.c (library_list_start_library): Don't xstrdup name.
1392
1393 2019-01-10  Pedro Alves  <palves@redhat.com>
1394
1395         * mdebugread.c (parse_partial_symbols): Use
1396         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1397
1398 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1399
1400         * linux-fork.c (scoped_switch_fork_info)
1401         <~scoped_switch_fork_info>: Fix incorrect variable name.
1402
1403 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * linux-fork.c (scoped_switch_fork_info)
1406         <scoped_switch_fork_info>: Make explicit.
1407         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1408
1409 2019-01-10  Tom Tromey  <tom@tromey.com>
1410
1411         * objfiles.h (objfile::reset_psymtabs): Update.
1412         * objfiles.c (objfile::objfile): Update.
1413         * psymtab.h (psymtab_storage::obstack): Update.
1414         (psymtab_storage::m_obstack): Use gdb::optional.
1415         (class psymtab_storage): Update comment.  Remove objfile
1416         parameter.
1417         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1418
1419 2019-01-10  Tom Tromey  <tom@tromey.com>
1420
1421         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1422         <free_psymtabs>: Now private.
1423         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1424         (allocate_psymtab): Use new method.
1425
1426 2019-01-10  Tom Tromey  <tom@tromey.com>
1427
1428         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1429         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1430         * mdebugread.c (parse_partial_symbols): Use
1431         allocate_dependencies.
1432         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1433         allocate_dependencies.
1434         (process_psymtab_comp_unit_reader)
1435         (build_type_psymtab_dependencies): Likewise.
1436         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1437
1438 2019-01-10  Tom Tromey  <tom@tromey.com>
1439
1440         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1441         PSYMBOL_SET_LANGUAGE.
1442         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1443
1444 2019-01-10  Tom Tromey  <tom@tromey.com>
1445
1446         * psymtab.h (psymtab_storage::obstack): New method.
1447         <m_obstack>: Rename from obstack; now private.
1448         * psymtab.c (psymtab_storage): Update.
1449         * dwarf2read.c (create_addrmap_from_index)
1450         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1451         Update.
1452
1453 2019-01-10  Tom Tromey  <tom@tromey.com>
1454
1455         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1456         * objfiles.h (objfile::reset_psymtabs): New method.
1457
1458 2019-01-10  Tom Tromey  <tom@tromey.com>
1459
1460         * symmisc.c (print_symbol_bcache_statistics): Update.
1461         (print_objfile_statistics): Update.
1462         * symfile.c (reread_symbols): Update.
1463         * psymtab.h (class psymtab_storage): New.
1464         * psymtab.c (psymtab_storage): New constructor.
1465         (~psymtab_storage): New destructor.
1466         (require_partial_symbols): Update.
1467         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1468         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1469         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1470         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1471         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1472         (start_psymtab_common, end_psymtab_common)
1473         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1474         (allocate_psymtab): Update.
1475         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1476         Update.
1477         (dump_psymtab_addrmap, maintenance_print_psymbols)
1478         (maintenance_check_psymtabs): Update.
1479         (class objfile_psymtabs): Move to objfiles.h.
1480         * psympriv.h (discard_psymtab): Now inline.
1481         (psymtab_discarder::psymtab_discarder): Update.
1482         (psymtab_discarder::~psymtab_discarder): Update.
1483         (ALL_OBJFILE_PSYMTABS): Rewrite.
1484         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1485         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1486         Remove fields.
1487         <partial_symtabs>: New field.
1488         (class objfile_psymtabs): Move from psymtab.h.  Update.
1489         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1490         psymbol_cache.
1491         (objfile::~objfile): Don't destroy psymbol_cache.
1492         * mdebugread.c (parse_partial_symbols): Update.
1493         * dwarf2read.c (create_addrmap_from_index)
1494         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1495         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1496         (add_partial_subprogram, dwarf2_ranges_read): Update.
1497         * dwarf-index-write.c (write_address_map)
1498         (write_one_signatured_type, recursively_write_psymbols)
1499         (class debug_names, class debug_names, write_psymtabs_to_index):
1500         Update.
1501
1502 2019-01-10  Tom Tromey  <tom@tromey.com>
1503
1504         * symtab.h (SYMBOL_SET_NAMES): Update.
1505         (symbol_set_names): Update.
1506         (MSYMBOL_SET_NAMES): Update.
1507         * symtab.c (symbol_set_names): Change argument to be an
1508         objfile_per_bfd_storage.
1509         * psymtab.c (add_psymbol_to_bcache): Update.
1510         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1511
1512 2019-01-10  Tom Tromey  <tom@tromey.com>
1513
1514         * symtab.c (create_demangled_names_hash): Change argument to be an
1515         objfile_per_bfd_storage.
1516         (symbol_set_names): Update.
1517
1518 2019-01-10  Tom Tromey  <tom@tromey.com>
1519
1520         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1521         init_psymbol_list.
1522         * psymtab.c (init_psymbol_list): Do nothing if already called.
1523         * psympriv.h (init_psymbol_list): Add comment.
1524         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1525         init_psymbol_list.
1526         * dbxread.c (dbx_symfile_read): Unconditionally call
1527         init_psymbol_list.
1528
1529 2019-01-10  Tom Tromey  <tom@tromey.com>
1530
1531         * xcoffread.c (scan_xcoff_symtab): Update.
1532         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1533         "where".
1534         * mdebugread.c (parse_partial_symbols)
1535         (handle_psymbol_enumerators): Update.
1536         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1537         * dbxread.c (read_dbx_symtab): Update.
1538         * psympriv.h (psymbol_placement): New enum.
1539         (add_psymbol_to_list): Update.
1540
1541 2019-01-10  Tom Tromey  <tom@tromey.com>
1542
1543         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1544         static_psymbols parameters.
1545         (scan_xcoff_symtab): Update.
1546         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1547         static_psymbols parameters.
1548         * psympriv.h (start_psymtab_common): Update.
1549         * mdebugread.c (parse_partial_symbols): Update.
1550         * dwarf2read.c (create_partial_symtab): Update.
1551         * dbxread.c (read_dbx_symtab): Update.
1552         (start_psymtab): Remove global_psymbols and static_psymbols
1553         parameters.
1554
1555 2019-01-10  Tom Tromey  <tom@tromey.com>
1556
1557         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1558         * psymtab.c (allocate_psymtab): Add comment.
1559         * psympriv.h (allocate_psymtab): Add comment.
1560         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1561         initializations.
1562         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1563
1564 2019-01-10  Tom Tromey  <tom@tromey.com>
1565
1566         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1567         Don't declare.
1568         * mipsread.c: Include mdebugread.h.
1569         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1570         Declare.
1571         * elfread.c: Include mdebugread.h.
1572
1573 2019-01-09  Tom Tromey  <tom@tromey.com>
1574
1575         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1576         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1577         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1578         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1579         (psym_lookup_symbol, psym_find_last_source_symtab)
1580         (psym_forget_cached_source_info, psym_print_stats)
1581         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1582         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1583         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1584         (psym_find_compunit_symtab_by_address)
1585         (maintenance_print_psymbols, maintenance_info_psymtabs)
1586         (maintenance_check_psymtabs): Use ranged for.
1587         * psymtab.h (class objfile_psymtabs): New.
1588         (require_partial_symbols): Return objfile_psymtabs.
1589         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1590
1591 2019-01-09  Tom Tromey  <tom@tromey.com>
1592
1593         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1594         (find_pc_mapped_section, list_overlays_command)
1595         (map_overlay_command, unmap_overlay_command)
1596         (simple_overlay_update): Use all_objfiles.
1597         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1598         * printcmd.c (info_symbol_command): Use all_objfiles.
1599         * objfiles.h (ALL_OBJSECTIONS): Remove.
1600         * maint.c (maintenance_translate_address): Use all_objfiles.
1601         * gcore.c (gcore_create_callback): Use all_objfiles.
1602         (objfile_find_memory_regions): Likewise.
1603
1604 2019-01-09  Tom Tromey  <tom@tromey.com>
1605
1606         * symtab.c (find_line_symtab, info_sources_command)
1607         (make_source_files_completion_list): Use objfile_compunits.
1608         * source.c (select_source_symtab): Use objfile_compunits.
1609         * objfiles.h (struct objfile): Update comment.
1610         (ALL_OBJFILES): Remove.
1611         (ALL_FILETABS): Remove.
1612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1613         objfile_compunits.
1614
1615 2019-01-09  Tom Tromey  <tom@tromey.com>
1616
1617         * symmisc.c (print_objfile_statistics, dump_objfile)
1618         (maintenance_print_symbols): Use compunit_filetabs.
1619         * source.c (forget_cached_source_info_for_objfile): Use
1620         compunit_filetabs.
1621         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1622         (ALL_FILETABS): Use compunit_filetabs.
1623         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1624         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1625
1626 2019-01-09  Tom Tromey  <tom@tromey.com>
1627
1628         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1629         (compunit_filetabs): New.
1630         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1631         compunit_filetabs.
1632         (info_sources_command, make_source_files_completion_list): Remove
1633         declaration.
1634         * symmisc.c (print_objfile_statistics, dump_objfile)
1635         (maintenance_print_symbols): Remove declaration.
1636         (maintenance_info_symtabs): Use compunit_filetabs.
1637         (maintenance_info_line_tables): Likewise.
1638         * source.c (select_source_symtab): Change local variable name.
1639         (forget_cached_source_info_for_objfile): Remove declaration.
1640         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1641         * objfiles.c (objfile_relocate1): Remove declaration.
1642         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1643         declaration.
1644         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1645         * coffread.c (coff_symtab_read): Remove declaration.
1646         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1647         compunit_filetabs.
1648
1649 2019-01-09  Tom Tromey  <tom@tromey.com>
1650
1651         * symtab.c (lookup_objfile_from_block)
1652         (find_pc_sect_compunit_symtab, search_symbols)
1653         (default_collect_symbol_completion_matches_break_on): Use
1654         objfile_compunits.
1655         * objfiles.h (ALL_COMPUNITS): Remove.
1656         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1657         * cp-support.c (add_symbol_overload_list_qualified): Use
1658         objfile_compunits.
1659         * ada-lang.c (ada_collect_symbol_completion_matches)
1660         (ada_add_global_exceptions): Use objfile_compunits.
1661
1662 2019-01-09  Tom Tromey  <tom@tromey.com>
1663
1664         * source.c (select_source_symtab)
1665         (forget_cached_source_info_for_objfile): Remove declaration.
1666         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1667         declaration.
1668         * maint.c (count_symtabs_and_blocks): Remove declaration.
1669         * cp-support.c (add_symbol_overload_list_qualified): Remove
1670         declaration.
1671         * coffread.c (coff_symtab_read): Remove declaration.
1672         * symtab.c (lookup_symbol_in_objfile_symtabs)
1673         (basic_lookup_transparent_type_1): Use objfile_compunits.
1674         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1675         (info_sources_command, search_symbols)
1676         (default_collect_symbol_completion_matches_break_on)
1677         (make_source_files_completion_list): Remove declaration.
1678         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1679         (ada_collect_symbol_completion_matches)
1680         (ada_add_global_exceptions): Remove declaration.
1681         * linespec.c (iterate_over_all_matching_symtabs): Use
1682         objfile_compunits.
1683         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1684         (class objfile_compunits): New.
1685         (ALL_COMPUNITS): Use objfile_compunits.
1686         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1687         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1688         objfile_compunits.
1689         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1690
1691 2019-01-09  Tom Tromey  <tom@tromey.com>
1692
1693         * symtab.c (search_symbols)
1694         (default_collect_symbol_completion_matches_break_on): Use
1695         objfile_msymbols.
1696         * ada-lang.c (ada_lookup_simple_minsym)
1697         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1698         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1699         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1700         objfile_msymbols.
1701         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1702         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1703         * objc-lang.c (find_methods): Use objfile_msymbols.
1704         (info_selectors_command, info_classes_command): Likewise.
1705         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1706         * objfiles.h (class objfile_msymbols): New.
1707         (ALL_OBJFILE_MSYMBOLS): Remove.
1708         (ALL_MSYMBOLS): Remove.
1709
1710 2019-01-09  Tom Tromey  <tom@tromey.com>
1711
1712         * common/next-iterator.h (next_adapter): Add Iterator template
1713         parameter.
1714         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1715         (class all_objfiles_safe): New.
1716         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1717         * objfiles.c (put_objfile_before): Update comment.
1718         (add_separate_debug_objfile): Likewise.
1719         (free_all_objfiles): Use all_objfiles_safe.
1720         (objfile_purge_solibs): Likewise.
1721
1722 2019-01-09  Tom Tromey  <tom@tromey.com>
1723
1724         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1725         (expand_symtab_containing_pc, lookup_static_symbol)
1726         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1727         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1728         all_objfiles.
1729         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1730         * breakpoint.c (create_overlay_event_breakpoint)
1731         (create_longjmp_master_breakpoint)
1732         (create_std_terminate_master_breakpoint)
1733         (create_exception_master_breakpoint): Use all_objfiles.
1734         * linux-thread-db.c (try_thread_db_load_from_pdir)
1735         (has_libpthread): Use all_objfiles.
1736         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1737         * linespec.c (iterate_over_all_matching_symtabs)
1738         (search_minsyms_for_name): Use all_objfiles.
1739         * maint.c (maintenance_info_sections): Use all_objfiles.
1740         * main.c (captured_main_1): Use all_objfiles.
1741         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1742         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1743         * guile/scm-pretty-print.c
1744         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1745         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1746         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1747         (maintenance_print_msymbols): Use all_objfiles.
1748         * source.c (select_source_symtab): Use all_objfiles.
1749         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1750         * symfile.c (remove_symbol_file_command)
1751         (expand_symtabs_matching, map_symbol_filenames): Use
1752         all_objfiles.
1753         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1754         all_objfiles.
1755         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1756         * objc-lang.c (find_methods): Use all_objfiles.
1757         * objfiles.c (have_partial_symbols, have_full_symbols)
1758         (have_minimal_symbols, qsort_cmp)
1759         (default_iterate_over_objfiles_in_search_order): Use
1760         all_objfiles.
1761         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1762         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1763         (maintenance_check_psymtabs): Use all_objfiles.
1764         (ALL_PSYMTABS): Remove.
1765         * compile/compile-object-run.c (do_module_cleanup): Use
1766         all_objfiles.
1767         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1768         * cp-support.c (add_symbol_overload_list_qualified): Use
1769         all_objfiles.
1770         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1771         Use all_objfiles.
1772         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1773         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1774         all_objfiles.
1775         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1776         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1777         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1778         Uses all_objfiles.
1779         * solib.c (solib_read_symbols): Use all_objfiles
1780
1781 2019-01-09  Tom Tromey  <tom@tromey.com>
1782
1783         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1784         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1785         all_objfiles.
1786         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1787         * symmisc.c (print_symbol_bcache_statistics)
1788         (print_objfile_statistics, maintenance_print_objfiles)
1789         (maintenance_info_symtabs, maintenance_check_symtabs)
1790         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1791         all_objfiles.
1792         * source.c (forget_cached_source_info): Use all_objfiles.
1793         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1794         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1795         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1796         * objfiles.c (update_section_map): Use all_objfiles.
1797         (shared_objfile_contains_address_p): Likewise.
1798         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1799         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1800
1801 2019-01-09  Tom Tromey  <tom@tromey.com>
1802
1803         * common/next-iterator.h: New file.
1804         * objfiles.h (class all_objfiles): New.
1805         (struct objfile_iterator): New.
1806
1807 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1808
1809         * NEWS: Move the description of the changed "frame", "select-frame",
1810          and "info frame" commands to the Changed commands section.
1811
1812 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1813
1814         * gdbtypes.c (check_stub_method_group): Remove handling of old
1815         mangling schemes.
1816         * linespec.c (find_methods): Likewise.
1817         * stabsread.c (read_member_functions): Likewise.
1818         * valops.c (search_struct_method): Likewise.
1819         (value_struct_elt_for_reference): Likewise.
1820         * NEWS: Mention this change.
1821
1822 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1823
1824         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1825         print_source_lines.
1826         * source.c (print_source_lines_base): Update line number check.
1827         (print_source_lines): New function.
1828         (source_lines_range::source_lines_range): New function.
1829         * source.h (class source_lines_range): New class.
1830         (print_source_lines): New declaration.
1831
1832 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1833
1834         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1835
1836 2019-01-08  Tom Tromey  <tom@tromey.com>
1837             Simon Marchi  <simon.marchi@ericsson.com>
1838
1839         PR gdb/24060
1840         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1841         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1842         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1843         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1844         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1845         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1846
1847 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1848
1849         * source.c (select_source_symtab): Move header comment to
1850         declaration in source.h.
1851         (forget_cached_source_info_for_objfile): Likewise.
1852         (forget_cached_source_info): Likewise.
1853         (identify_source_line): Likewise.
1854         * source.h (identify_source_line): Move declaration from symtab.h
1855         and add comment from source.c
1856         (print_source_lines): Likewise.
1857         (forget_cached_source_info_for_objfile): Likewise.
1858         (forget_cached_source_info): Likewise.
1859         (select_source_symtab): Likewise.
1860         (enum print_source_lines_flag): Move definition from symtab.h.
1861         * symtab.h (identify_source_line): Move declaration to source.h.
1862         (print_source_lines): Likewise.
1863         (forget_cached_source_info_for_objfile): Likewise.
1864         (forget_cached_source_info): Likewise.
1865         (select_source_symtab): Likewise.
1866         (enum print_source_lines_flag): Move definition to source.h.
1867         * tui/tui-hooks.c: Add 'source.h' include.
1868
1869 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * source.c (print_source_lines_base): Handle requests to print
1872         reverse line number sequences, and guard against empty lines
1873         string.
1874
1875 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * source.c (print_source_lines_base): Fix skip of '\r' if next
1878         character is '\n'.
1879
1880 2019-01-06  Tom Tromey  <tom@tromey.com>
1881
1882         * c-exp.y (struct c_parse_state) <macro_original_text,
1883         expansion_obstack>: New member.
1884         (macro_original_text, expansion_obstack): Remove globals.
1885         (scan_macro_expansion, scanning_macro_expansion)
1886         (finished_macro_expansion): Update.
1887         (scan_macro_cleanup): Remove.
1888         (yylex, c_parse): Update.
1889
1890 2019-01-06  Tom Tromey  <tom@tromey.com>
1891
1892         * c-exp.y (struct c_parse_state) <strings>: New member.
1893         (operator_stoken): Update.
1894
1895 2019-01-06  Tom Tromey  <tom@tromey.com>
1896
1897         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1898         (union type_stack_elt) <typelist_val>: Now a pointer to
1899         std::vector.
1900         (type_stack_cleanup): Don't declare.
1901         (push_typelist): Update.
1902         * parse.c (pop_typelist): Return a std::vector.
1903         (push_typelist): Take a std::vector.
1904         (follow_types): Update.  Do not free args.
1905         (type_stack_cleanup): Remove.
1906         * c-exp.y (struct c_parse_state): New.
1907         (cpstate): New global.
1908         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1909         (nonempty_typelist): Update.
1910         (func_mod): Create a new vector.
1911         (c_parse): Create a c_parse_state.
1912         (check_parameter_typelist): Do not delete params.
1913         (function_method): Update.  Do not delete type_list.
1914
1915 2019-01-06  Tom Tromey  <tom@tromey.com>
1916
1917         PR gdb/28155:
1918         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1919         check_typedef.
1920         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1921         (print_return_value): Likewise.
1922
1923 2019-01-05  Tom Tromey  <tom@tromey.com>
1924
1925         * contrib/cleanup_check.py: Remove.
1926         * contrib/gcc-with-excheck: Remove.
1927         * contrib/exsummary.py: Remove.
1928         * contrib/excheck.py: Remove.
1929
1930 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1931
1932         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1933         NULL. Initialize tpprev to NULL instead of assigning it
1934         to NULL on the next statement.
1935         * windows-nat.c (windows_delete_thread): Remove check for
1936         main_thread_id before printing thread exit notifications.
1937         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1938         Remove thread ID check against main_thread_id.
1939         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1940         windows_delete_thread.
1941         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1942
1943 2019-01-04  Tom Tromey  <tom@tromey.com>
1944
1945         * compile/compile.c (_initialize_compile): Use upper case for
1946         metasyntactic variables.
1947         * symmisc.c (_initialize_symmisc): Use upper case for
1948         metasyntactic variables.
1949         * psymtab.c (_initialize_psymtab): Use upper case for
1950         metasyntactic variables.
1951         * demangle.c (demangle_command): Use upper case for metasyntactic
1952         variables.
1953         (_initialize_demangler): Likewise.
1954         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1955         variables.
1956
1957 2019-01-03  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1960
1961 2019-01-03  Tom Tromey  <tom@tromey.com>
1962
1963         * python/py-symtab.c (salpy_str): Update.
1964         (struct salpy_sal_object) <symtab>: Now a PyObject.
1965         (salpy_dealloc): Update.
1966         (del_objfile_sal): Use gdbpy_ref.
1967
1968 2019-01-03  Tom Tromey  <tom@tromey.com>
1969
1970         * python/py-type.c (convert_field): Use new_reference.  Return
1971         gdbpy_ref.
1972         (make_fielditem): Return gdbpy_ref.
1973         (typy_fields): Update.
1974         (typy_getitem): Update.
1975         (field_name): Return gdbpy_ref.  Use new_reference.
1976         (typy_iterator_iternext): Update.
1977
1978 2019-01-03  Tom Tromey  <tom@tromey.com>
1979
1980         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1981
1982 2019-01-03  Tom Tromey  <tom@tromey.com>
1983
1984         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1985         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1986         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1987         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1988         (pspy_set_type_printers): Likewise.
1989         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1990         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1991         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1992         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1993         (objfpy_set_type_printers): Likewise.
1994
1995 2019-01-03  Tom Tromey  <tom@tromey.com>
1996
1997         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1998         (gdbpy_print_stack): Use gdbpy_err_fetch.
1999         * python/python-internal.h (class gdbpy_err_fetch): New class.
2000         (class gdbpy_enter) <m_error_type, m_error_value,
2001         m_error_traceback>: Remove.
2002         <m_error>: New member.
2003         (gdbpy_exception_to_string): Don't declare.
2004         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2005         * python/py-value.c (convert_value_from_python): Use
2006         gdbpy_err_fetch.
2007         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2008         gdbpy_exception_to_string.
2009         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2010         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2011         gdbpy_err_fetch.
2012
2013 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         * linux-nat.c (delete_lwp_cleanup): Delete.
2016         (struct lwp_deleter): New struct.
2017         (lwp_info_up): New typedef.
2018         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2019         lwp_info_up.
2020
2021 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * linux-fork.c (class scoped_switch_fork_info): New class.
2024         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2025
2026 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2027
2028         * valops.c (find_overload_match): Remove use of null_cleanup, and
2029         calls to do_cleanups.
2030
2031 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         * compile/compile-cplus-types.c
2034         (compile_cplus_instance::decl_name): Handle changes to
2035         cp_func_name.
2036         * cp-support.c (cp_func_name): Update header comment, update
2037         return type.
2038         * cp-support.h (cp_func_name): Update return type in declaration.
2039         * valops.c (find_overload_match): Move temp_func local to top
2040         level of function and change its type.  Use temp_func to hold and
2041         delete temporary string obtained from cp_func_name.
2042
2043 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2046         gdb::char_vector, remove cleanup, and update uses of `msg`.
2047
2048 2019-01-03  Jim Wilson  <jimw@sifive.com>
2049
2050         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2051
2052 2019-01-02  Tom Tromey  <tom@tromey.com>
2053
2054         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2055         (tdesc_parse_xml): Remove cleanups.
2056         * target-descriptions.h (make_cleanup_free_target_description):
2057         Don't declare.
2058         (target_desc_deleter): New struct.
2059         (target_desc_up): New typedef.
2060         * target-descriptions.c (target_desc_deleter::operator()): Rename
2061         from free_target_description.
2062         (make_cleanup_free_target_description): Remove.
2063
2064 2019-01-02  Tom Tromey  <tom@tromey.com>
2065
2066         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2067         constructor, destructor.
2068         (linespec_parser): Remove typedef.
2069         (~linespec_parser): Rename from linespec_parser_delete.
2070         (linespec_lex_to_end, linespec_complete_label)
2071         (linespec_complete): Update.
2072         (decode_line_full): Remove cleanups.
2073         (decode_line_1): Update.
2074
2075 2019-01-02  Tom Tromey  <tom@tromey.com>
2076
2077         * python/python-internal.h (inferior_to_inferior_object): Change
2078         return type.
2079         * python/py-exitedevent.c (create_exited_event_object): Update.
2080         * python/py-inferior.c (inferior_to_inferior_object): Return
2081         gdbpy_ref.
2082         (python_new_inferior, python_inferior_deleted)
2083         (thread_to_thread_object, delete_thread_object)
2084         (build_inferior_list, gdbpy_selected_inferior): Update.
2085         * python/py-infthread.c (create_thread_object): Update.  Also fail
2086         if inferior_to_inferior_object fails.
2087
2088 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2089
2090         * inferior.h (class inferior) <displaced_step_state>: New field.
2091         * infrun.h (struct displaced_step_state): Move here from
2092         infrun.c.  Initialize fields, add constructor.
2093         <inf>: Remove field.
2094         <reset>: New method.
2095         * infrun.c (struct displaced_step_inferior_state): Move to
2096         infrun.h.
2097         (displaced_step_inferior_states): Remove.
2098         (get_displaced_stepping_state): Adust.
2099         (displaced_step_in_progress_any_inferior): Adjust.
2100         (displaced_step_in_progress_thread): Adjust.
2101         (displaced_step_in_progress): Adjust.
2102         (add_displaced_stepping_state): Remove.
2103         (get_displaced_step_closure_by_addr): Adjust.
2104         (remove_displaced_stepping_state): Remove.
2105         (infrun_inferior_exit): Call displaced_step_state.reset.
2106         (use_displaced_stepping): Don't check for NULL.
2107         (displaced_step_prepare_throw): Call
2108         get_displaced_stepping_state.
2109         (displaced_step_fixup): Don't check for NULL.
2110         (prepare_for_detach): Don't check for NULL.
2111
2112 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2113
2114         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2115          in case of call that did not complete.
2116
2117 2019-01-02  Andrey Utkin  <autkin@undo.io>
2118
2119         * symfile.c (find_separate_debug_file): Fix search of debug files for
2120         remote debuggee.
2121
2122 2019-01-02  Tom Tromey  <tom@tromey.com>
2123
2124         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2125         indentation.
2126         * python/py-frame.c (frapy_older): Remove cast.
2127         (frapy_newer): Likewise.
2128         * python/py-breakpoint.c (local_setattro): Remove cast.
2129         * python/py-arch.c (archpy_name): Remove local variable.
2130         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2131
2132 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2133
2134         * unittests/basic_string_view/element_access/char/empty.cc:
2135         Fix year range in copyright header.
2136
2137 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2140         Delete.
2141         <operator==>: Update with for removed field.
2142         <hash>: Likewise.
2143         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2144         <isa_features>: ...this.
2145         <abi_features>: New field.
2146         (riscv_isa_flen): Update comment.
2147         (riscv_abi_xlen): New declaration.
2148         (riscv_abi_flen): New declaration.
2149         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2150         isa_features.
2151         (riscv_abi_xlen): New function.
2152         (riscv_isa_flen): Update to get answer from isa_features.
2153         (riscv_abi_flen): New function.
2154         (riscv_has_fp_abi): Update to get answer from abi_features.
2155         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2156         xlen and flen.
2157         (riscv_call_info) <xlen, flen>: Update comment.
2158         (riscv_call_arg_struct): Remove invalid assertions
2159         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2160         is removed.
2161         (riscv_gdbarch_init): Gather isa features and abi features
2162         separately, ensure both match on the gdbarch when reusing an old
2163         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2164         a target with 64-bit float hardware.
2165
2166 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2167
2168         * source.c (search_command_helper): Stop reverse search
2169         when line 1 has been searched.
2170
2171 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2172
2173         * record-full.c (record_full_base_target::close): Rewrite
2174         record_full_core_buf_list free logic.
2175
2176 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2177
2178         * break-catch-syscall.c (print_one_catch_syscall): xfree
2179         the last text.
2180
2181 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2182
2183         * top.c (print_gdb_version): Update Copyright year in version
2184         message.
2185
2186 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2187
2188         Update copyright year range in all GDB files.
2189
2190 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2191
2192         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2193
2194 For older changes see ChangeLog-2018.
2195 \f
2196 Local Variables:
2197 mode: change-log
2198 left-margin: 8
2199 fill-column: 74
2200 version-control: never
2201 coding: utf-8
2202 End:
2203