1 2019-08-16 Tom Tromey <tom@tromey.com>
3 * tui/tui.c (tui_is_window_visible): Update.
4 * tui/tui-wingeneral.c (tui_make_window)
5 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
6 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
7 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
8 (tui_set_win_height_command, parse_scrolling_args): Update.
9 * tui/tui-source.c (tui_source_window::style_changed): Update.
10 * tui/tui-regs.c (tui_show_registers)
11 (tui_data_window::first_data_item_displayed)
12 (tui_data_window::delete_data_content_windows)
13 (tui_check_register_values, tui_reg_command): Update.
14 * tui/tui-disasm.c (tui_show_disassem): Update.
15 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
17 <is_visible>: Remove field.
18 * tui/tui-data.c (tui_next_win, tui_prev_win)
19 (tui_delete_invisible_windows): Update.
21 2019-08-16 Tom Tromey <tom@tromey.com>
23 * tui/tui-winsource.h (struct tui_source_window_base)
24 <m_has_locator>: Remove.
25 * tui/tui-layout.c (show_source_disasm_command, show_data)
26 (show_source_or_disasm_and_command): Update.
28 2019-08-16 Alan Hayward <alan.hayward@arm.com>
30 * NEWS (Other MI changes): New subsection.
31 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
32 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
33 * arch-utils.c (default_get_pc_address_flags): New function.
34 * arch-utils.h (default_get_pc_address_flags): New declaration.
35 * gdbarch.sh: Add get_pc_address_flags.
36 * gdbarch.c: Regenerate.
37 * gdbarch.h: Likewise.
38 * stack.c (print_pc): New function.
39 (print_frame_info) (print_frame): Call print_pc.
41 2019-08-16 Tom de Vries <tdevries@suse.de>
43 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
44 print_objfile_section_info.
46 2019-08-15 Tom Tromey <tom@tromey.com>
48 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
49 calling update_cmdwin_start_line.
50 * tui/tui-winsource.h (struct tui_source_window_base)
51 <do_make_visible_with_new_height, set_new_height>: Don't declare.
53 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
55 (tui_source_window_base::set_new_height): Remove.
56 (tui_source_window_base::rerender): Rename from
57 do_make_visible_with_new_height.
58 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
60 (tui_win_info::make_invisible_and_set_new_height)
61 (tui_win_info::make_visible_with_new_height): Remove.
62 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
64 * tui/tui-stack.c (tui_locator_window::rerender): New method.
65 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
66 do_make_visible_with_new_height>: Don't declare.
68 * tui/tui-regs.c (tui_data_window::rerender): Rename from
70 (tui_data_window::do_make_visible_with_new_height): Remove.
71 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
72 call tui_show_locator_content.
73 (tui_gen_win_info::resize): Call rerender.
74 (show_source_or_disasm_and_command): Don't call
75 tui_show_locator_content.
76 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
78 (struct tui_win_info) <rerender>: Declare.
79 <set_new_height, make_invisible_and_set_new_height,
80 make_visible_with_new_height>: Don't declare.
81 * tui/tui-data.c (tui_win_list::rerender): New method.
82 * tui/tui-command.h (struct tui_cmd_window)
83 <do_make_visible_with_new_height>: Don't declare.
85 (tui_cmd_window::do_make_visible_with_new_height): Remove.
87 2019-08-15 Tom Tromey <tromey@adacore.com>
89 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
90 * ada-lang.c (ada_enum_name): Likewise.
92 2019-08-15 Christian Biesinger <cbiesinger@google.com>
94 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
96 (GdbOutputErrorFile): Likewise.
97 (global scope): Adjust constructor calls to GdbOutput{,Error}File
99 (execute_unwinders): Rename to have a leading underscore.
100 (auto_load_packages): Likewise.
101 (global scope): Adjust call to auto_load_packages accordingly.
102 (GdbSetPythonDirectory): Likewise.
103 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
104 instead of execute_unwinders.
106 2019-08-15 Tom Tromey <tom@tromey.com>
108 * tui/tui-layout.c (show_layout, show_source_disasm_command)
109 (show_data): Don't change window visibility.
110 (tui_gen_win_info::resize): Remove special case for command
111 window. Use wresize, when available.
112 (show_source_or_disasm_and_command): Don't change window
114 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
115 <make_visible>: New method.
116 * tui/tui-command.c (tui_cmd_window::resize): New method.
118 2019-08-15 Tom Tromey <tom@tromey.com>
120 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
121 (struct tui_source_windows): New.
122 * tui/tui-winsource.c (tui_display_main): Update.
123 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
124 (new_height_ok, parse_scrolling_args): Update.
125 * tui/tui-layout.c (show_layout, show_data): Update.
126 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
127 (tui_add_to_source_windows): Don't declare.
128 * tui/tui-data.c (source_windows, tui_source_windows)
129 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
131 2019-08-15 Tom Tromey <tom@tromey.com>
133 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
135 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
136 * tui/tui-layout.c (show_source_disasm_command, show_data):
138 (tui_gen_win_info::resize): Rename.
139 (show_source_or_disasm_and_command): Update.
140 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
143 2019-08-15 Tom Tromey <tom@tromey.com>
145 * tui/tui-stack.c (tui_initialize_static_data): Remove.
146 * tui/tui-interp.c (tui_interp::init): Don't call
147 tui_initialize_static_data.
148 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
150 2019-08-15 Tom Tromey <tom@tromey.com>
152 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
153 examine tui_win_list.
155 2019-08-15 Tom Tromey <tom@tromey.com>
157 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
158 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
159 tui_clear_source_content.
160 (tui_clear_source_content): Remove.
161 (tui_source_window_base::do_erase_source_content): Hoist call to
163 * tui/tui-stack.c (tui_show_frame_info): Don't call
164 tui_clear_source_content.
166 2019-08-15 Tom Tromey <tom@tromey.com>
168 * tui/tui-winsource.h (struct tui_source_window_base)
169 <do_erase_source_content>: New method.
170 <erase_source_content>: New method.
171 (tui_erase_source_content): Don't declare.
172 * tui/tui-winsource.c (tui_clear_source_content): Update.
173 (tui_source_window_base::do_erase_source_content): Rename from
174 tui_erase_source_content.
175 (tui_source_window_base::show_source_content): Update.
176 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
177 * tui/tui-source.h (struct tui_source_window)
178 <erase_source_content>: New method.
179 * tui/tui-disasm.h (struct tui_disasm_window)
180 <erase_source_content>: New method.
182 2019-08-15 Tom Tromey <tom@tromey.com>
184 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
185 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
187 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
188 * tui/tui-source.c (tui_set_source_content): Update.
189 * tui/tui-disasm.c (tui_set_disassem_content): Update.
191 2019-08-15 Tom Tromey <tom@tromey.com>
193 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
194 * tui/tui-winsource.c (tui_line_is_displayed): Move to
196 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
198 * tui/tui-source.c (tui_source_window::line_is_displayed): New
200 (tui_source_window::maybe_update): Update.
202 2019-08-15 Tom Tromey <tom@tromey.com>
204 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
205 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
207 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
209 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
211 (tui_disasm_window::maybe_update): Update.
213 2019-08-15 Tom Tromey <tom@tromey.com>
215 * tui/tui-winsource.h (struct tui_source_window_base)
216 <maybe_update>: Declare.
217 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
219 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
221 * tui/tui-source.c (tui_source_window::maybe_update): New method.
222 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
224 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
226 2019-08-15 Tom Tromey <tom@tromey.com>
228 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
230 2019-08-15 Tom Tromey <tom@tromey.com>
232 * tui/tui-wingeneral.c: Include tui-stack.h.
233 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
234 (struct tui_locator_window): Move from tui-data.h.
235 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
236 (tui_initialize_static_data): Move from tui-data.c.
237 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
238 (struct tui_locator_window): Move to tui-stack.c.
239 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
240 (tui_initialize_static_data): Move to tui-stack.c.
242 2019-08-15 Tom Tromey <tom@tromey.com>
244 * tui/tui-layout.c (show_source_disasm_command)
245 (show_source_or_disasm_and_command): Use make_visible method, not
247 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
250 2019-08-15 Tom Tromey <tom@tromey.com>
252 * tui/tui-wingeneral.h (tui_make_window): Update.
253 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
255 (tui_gen_win_info::make_visible): Update.
256 * tui/tui-regs.c (tui_data_window::display_registers_from):
258 * tui/tui-layout.c (show_source_disasm_command)
259 (show_source_or_disasm_and_command): Update.
260 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
261 (enum tui_box): Remove.
262 (struct tui_win_info) <can_box>: New method.
263 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
266 2019-08-15 Tom de Vries <tdevries@suse.de>
268 * linux-nat-trad.c: Include gdbarch.h.
270 2019-08-14 Alan Hayward <alan.hayward@arm.com>
272 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
275 2019-08-14 Tom Tromey <tromey@adacore.com>
277 * darwin-nat.c: Include gdbarch.h.
278 * darwin-nat-info.c: Include gdbarch.h.
280 2019-08-13 Tom Tromey <tom@tromey.com>
282 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
284 * tui/tui-data.c (tui_initialize_static_data): Update.
286 2019-08-13 Tom Tromey <tom@tromey.com>
288 * tui/tui-winsource.h (struct tui_exec_info_window)
289 <~tui_exec_info_window, maybe_allocate_content, get_content,
291 (struct tui_source_window_base) <set_exec_info_content,
292 show_exec_info_content>: Don't declare.
293 * tui/tui-winsource.c
294 (tui_exec_info_window::maybe_allocate_content): Remove.
295 (tui_source_window_base::update_exec_info): Rename from
296 set_exec_info_content.
297 (tui_source_window_base::show_exec_info_content)
298 (tui_source_window_base::update_exec_info): Remove.
300 2019-08-13 Tom Tromey <tom@tromey.com>
302 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
304 * tui/tui-winsource.c (tui_update_source_window_as_is)
305 (tui_update_source_windows_with_addr, tui_erase_source_content):
307 (tui_clear_exec_info_content): Remove.
309 2019-08-13 Tom Tromey <tom@tromey.com>
311 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
313 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
314 call tui_erase_exec_info_content.
315 (tui_clear_exec_info_content): Rename from
316 tui_erase_exec_info_content.
317 (tui_clear_exec_info_content): Delete.
319 2019-08-13 Tom Tromey <tom@tromey.com>
321 * tui/tui-winsource.h (struct tui_source_window_base)
322 <show_exec_info_content>: Declare.
323 (tui_show_exec_info_content): Don't declare.
324 * tui/tui-winsource.c
325 (tui_source_window_base::show_exec_info_content): Rename from
326 tui_show_exec_info_content.
327 (tui_source_window_base::update_exec_info): Update.
329 2019-08-13 Tom Tromey <tom@tromey.com>
331 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
332 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
333 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
334 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
335 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
336 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
339 2019-08-13 Tom Tromey <tom@tromey.com>
341 * tui/tui-winsource.h (struct tui_source_window_base)
342 <update_exec_info>: Declare.
343 (tui_update_exec_info): Don't declare.
344 * tui/tui-winsource.c (tui_update_source_window_as_is)
345 (tui_source_window_base::refresh_all)
346 (tui_update_all_breakpoint_info): Update.
347 (tui_source_window_base::update_exec_info): Rename from
348 tui_update_exec_info.
349 * tui/tui-stack.c (tui_show_frame_info): Update.
351 2019-08-13 Tom Tromey <tom@tromey.com>
353 * tui/tui-winsource.h (struct tui_source_window_base)
354 <set_exec_info_content>: Declare.
355 (tui_set_exec_info_content): Don't declare.
356 * tui/tui-winsource.c
357 (tui_source_window_base::set_exec_info_content): Rename from
358 tui_set_exec_info_content.
359 (tui_update_exec_info): Update.
361 2019-08-13 Tom Tromey <tom@tromey.com>
363 * tui/tui-winsource.h (struct tui_source_window_base)
364 <show_source_content>: Declare.
365 (tui_show_source_content): Don't declare.
366 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
367 (tui_source_window_base::show_source_content): Rename from
368 tui_show_source_content.
369 (tui_source_window_base::refresh_all): Update.
370 * tui/tui-layout.c (show_source_disasm_command)
371 (show_source_or_disasm_and_command): Update.
373 2019-08-13 Tom Tromey <tom@tromey.com>
375 * tui/tui-winsource.c (tui_erase_source_content)
376 (tui_show_source_content, tui_source_window_base::refresh_all):
378 * tui/tui-wingeneral.h
379 (tui_check_and_display_highlight_if_needed): Don't declare.
380 * tui/tui-wingeneral.c
381 (tui_win_info::check_and_display_highlight_if_needed): Rename from
382 check_and_display_highlight_if_needed.
383 * tui/tui-win.c (tui_rehighlight_all)
384 (tui_win_info::make_visible_with_new_height): Update.
385 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
386 (tui_data_window::erase_data_content)
387 (tui_data_window::display_all_data): Update.
388 * tui/tui-data.h (struct tui_win_info)
389 <check_and_display_highlight_if_needed>: Declare.
391 2019-08-13 Tom Tromey <tom@tromey.com>
393 * tui/tui-win.c (tui_resize_all): Call
394 tui_delete_invisible_windows.
395 * tui/tui-layout.c (show_layout): Call
396 tui_delete_invisible_windows.
397 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
398 * tui/tui-data.c (tui_delete_invisible_windows): New function.
400 2019-08-13 Tom Tromey <tom@tromey.com>
402 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
403 tui_add_win_to_layout.
405 2019-08-13 Tom Tromey <tom@tromey.com>
407 * tui/tui-layout.h (tui_default_win_height): Don't declare.
408 * tui/tui-layout.c (tui_default_win_height): Now static.
410 2019-08-13 Tom Tromey <tom@tromey.com>
412 * tui/tui-layout.c (show_layout): Unify all layout cases into a
414 (show_source_disasm_command, show_source_or_disasm_and_command):
415 Don't check current layout.
417 2019-08-13 Tom Tromey <tom@tromey.com>
419 * tui/tui-wingeneral.c (make_all_visible): Remove.
420 (tui_make_all_invisible): Simplify.
421 * tui/tui-layout.c (tui_make_all_invisible): Move from
422 tui-wingeneral.c; simplify.
423 (show_layout): Hoist call to tui_make_all_invisible.
424 (show_data): Don't call tui_make_all_invisible.
426 2019-08-13 Tom Tromey <tom@tromey.com>
428 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
429 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
431 2019-08-13 Tom Tromey <tom@tromey.com>
433 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
435 (show_source_disasm_command, show_data)
436 (show_source_or_disasm_and_command): Don't use
437 tui_set_current_layout_to.
438 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
439 * tui/tui-data.c (current_layout, tui_current_layout): Move to
441 (tui_set_current_layout_to): Remove.
443 2019-08-13 Tom Tromey <tom@tromey.com>
445 * tui/tui-layout.c (tui_set_layout): Update.
446 * tui/tui-data.h (struct tui_layout_def): Remove.
447 (tui_layout_def): Don't declare.
448 * tui/tui-data.c (layout_def): Remove.
449 (tui_layout_def): Remove.
451 2019-08-13 Tom Tromey <tom@tromey.com>
453 * tui/tui-winsource.h (struct tui_source_window_base)
454 <clear_detail>: No longer "override".
455 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
456 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
457 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
458 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
460 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
462 2019-08-13 Tom Tromey <tromey@adacore.com>
464 * tracepoint.c: Don't include readline.h or history.h.
466 2019-08-12 Tom Tromey <tom@tromey.com>
468 * configure: Rebuild.
469 * configure.ac: Check for readline 7.
470 * NEWS: Mention readline 7 requirement.
473 2019-08-12 Tom Tromey <tom@tromey.com>
475 * mingw-hdep.c (gdb_select): Remove readline hack.
477 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
479 * blockframe.c (find_pc_partial_function): Set *block to nullptr
480 when the function fails.
482 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
484 * s390-tdep.c (s390_type_align): New function.
485 (s390_gdbarch_init): Set it as type_align gdbarch method.
487 2019-08-09 Tom de Vries <tdevries@suse.de>
490 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
491 pc_low with relocation offset.
493 2019-08-07 Tom Tromey <tromey@adacore.com>
495 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
496 (print_frame_args): Update.
497 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
499 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
500 * frame.h (struct frame_arg): Add initializers.
501 <error>: Now a unique_xmalloc_ptr.
503 2019-08-07 Alan Hayward <alan.hayward@arm.com>
505 * NEWS: Expand the Pointer Authentication entry.
506 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
507 (aarch64_frame_unmask_lr): ... to this.
508 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
509 Call aarch64_frame_unmask_lr.
510 * frame.c (struct frame_info): Add "masked" variable.
511 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
512 (fprint_frame): Check for masked pc.
513 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
515 * python/py-framefilter.c (py_print_frame): Check for masked pc.
516 * stack.c (print_frame): Check for masked pc.
518 2019-08-06 Tom Tromey <tom@tromey.com>
520 * stabsread.c (patch_block_stabs, read_one_struct_field)
521 (read_enum_type): Use obstack_strndup.
522 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
523 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
524 * dwarf2read.c (guess_full_die_structure_name)
525 (anonymous_struct_prefix): Use obstack_strndup.
526 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
527 * c-exp.y (yylex): Use obstack_strndup.
528 * ada-exp.y (write_object_renaming, write_ambiguous_var)
529 (write_var_or_type): Use obstack_strndup.
531 2019-08-06 Tom Tromey <tom@tromey.com>
533 * symfile.c (reread_symbols): Use obstack_strdup.
534 * stabsread.c (read_type): Use obstack_strdup.
535 * gdb_obstack.h (obstack_strdup): New overload.
536 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
537 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
538 (dwarf2_canonicalize_name): Use obstack_strdup.
539 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
540 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
543 2019-08-06 Tom Tromey <tom@tromey.com>
545 * gdb_obstack.h (obstack_strdup): Define.
546 * gdb_obstack.c (obstack_strdup): Don't define.
548 2019-08-06 Tom Tromey <tom@tromey.com>
550 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
552 * typeprint.c (typedef_hash_table::find_global_typedef): Use
554 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
555 * stabsread.c (common_block_start): Use obstack_strdup.
556 * objfiles.c (set_objfile_main_name, objfile): Use
558 * namespace.c (add_using_directive): Use obstack_strdup.
559 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
560 * jit.c (finalize_symtab): Use obstack_strdup.
561 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
562 (guess_partial_die_structure_name, partial_die_info::fixup)
563 (dwarf2_name): Use obstack_strdup.
564 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
566 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
567 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
569 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
571 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
573 * unittests/help-doc-selftests.c: New file.
574 * Makefile.in: Add the new file.
576 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
578 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
579 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
580 the full first line, except when FOR_VALUE_PREFIX. In this case,
581 the trailing '.' is not output, and the first character is uppercased.
582 (print_help_for_command): Update call to print_doc_line.
583 (print_doc_of_command): Likewise.
584 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
585 * cli/cli-option.c (append_indented_doc): Do not append newline.
586 (build_help_option): Append newline after first appended_indented_doc
587 only if a second call is done.
588 (build_help): Append 2 new lines before each option, except the first
590 * compile/compile.c (_initialize_compile): Add new lines after
591 %OPTIONS%, when not at the end of the help.
592 Change help doc or code
593 producing the help doc to respect the invariants.
594 * maint-test-options.c (_initialize_maint_test_options): Likewise.
595 Also removed the new line after 'Options:', as all other commands
596 do not put an empty line between 'Options:' and the first option.
597 * printcmd.c (_initialize_printcmd): Likewise.
598 * stack.c (_initialize_stack): Likewise.
599 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
600 incorrectly telling COMMAND is optional.
601 * ada-lang.c (_initialize_ada_language): Change help doc or code
602 producing the help doc to respect the invariants.
603 * ada-tasks.c (_initialize_ada_tasks): Likewise.
604 * breakpoint.c (_initialize_breakpoint): Likewise.
605 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
606 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
607 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
608 * cli/cli-style.c (cli_style_option::add_setshow_commands,
609 _initialize_cli_style): Likewise.
610 * corelow.c (core_target_info): Likewise.
611 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
612 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
613 * filesystem.c (_initialize_filesystem): Likewise.
614 * frame.c (_initialize_frame): Likewise.
615 * gnu-nat.c (add_task_commands): Likewise.
616 * infcall.c (_initialize_infcall): Likewise.
617 * infcmd.c (_initialize_infcmd): Likewise.
618 * interps.c (_initialize_interpreter): Likewise.
619 * language.c (_initialize_language): Likewise.
620 * linux-fork.c (_initialize_linux_fork): Likewise.
621 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
622 * maint.c (_initialize_maint_cmds): Likewise.
623 * memattr.c (_initialize_mem): Likewise.
624 * printcmd.c (_initialize_printcmd): Likewise.
625 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
627 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
628 * record-btrace.c (_initialize_record_btrace): Likewise.
629 * record-full.c (_initialize_record_full): Likewise.
630 * record.c (_initialize_record): Likewise.
631 * regcache-dump.c (_initialize_regcache_dump): Likewise.
632 * regcache.c (_initialize_regcache): Likewise.
633 * remote.c (add_packet_config_cmd, init_remote_threadtests,
634 _initialize_remote): Likewise.
635 * ser-tcp.c (_initialize_ser_tcp): Likewise.
636 * serial.c (_initialize_serial): Likewise.
637 * skip.c (_initialize_step_skip): Likewise.
638 * source.c (_initialize_source): Likewise.
639 * stack.c (_initialize_stack): Likewise.
640 * symfile.c (_initialize_symfile): Likewise.
641 * symtab.c (_initialize_symtab): Likewise.
642 * target-descriptions.c (_initialize_target_descriptions): Likewise.
643 * top.c (init_main): Likewise.
644 * tracefile-tfile.c (tfile_target_info): Likewise.
645 * tracepoint.c (_initialize_tracepoint): Likewise.
646 * tui/tui-win.c (_initialize_tui_win): Likewise.
647 * utils.c (add_internal_problem_command): Likewise.
648 * valprint.c (value_print_option_defs): Likewise.
650 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
653 * configure.ac: Drop enable-libmcheck support.
654 * configure, config.in: Rebuild.
655 * libmcheck.m4: Remove.
656 * acinclude.m4: Don't include it.
657 * Makefile.in: Don't distribute it.
658 * top.c (print_gdb_configuration): Don't mention it.
660 2019-08-06 Tom Tromey <tom@tromey.com>
662 * utils.c (set_output_style): Sometimes pass stream to
664 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
665 * record-btrace.c (btrace_insn_history): Update.
666 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
668 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
670 <m_uiout>: New field.
672 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
673 Remove "uiout" parameter.
674 (dump_insns): Update.
675 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
676 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
678 2019-08-06 Christian Biesinger <cbiesinger@google.com>
680 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
681 (error_in_psymtab_expansion): Likewise.
682 (lookup_symbol_via_quick_fns): Likewise.
683 (basic_lookup_transparent_type_quick): Likewise.
684 (basic_lookup_transparent_type_1): Likewise.
686 2019-08-06 Tom Tromey <tromey@adacore.com>
688 * source.c (last_source_error): Now bool.
689 (print_source_lines_base): Make "noprint" bool. Only open
690 source file when last_source_visited changes.
692 2019-08-06 Tom Tromey <tromey@adacore.com>
694 * annotate.c (annotate_source_line): Use g_source_cache.
695 * source-cache.c (source_cache::get_plain_source_lines): Change
696 parameters. Populate m_offset_cache.
697 (source_cache::ensure): New method.
698 (source_cache::get_line_charpos): New method.
699 (extract_lines): Move lower. Change parameters.
700 (source_cache::get_source_lines): Move lower.
701 * source-cache.h (class source_cache): Update comment.
702 <get_line_charpos>: New method.
703 <get_source_lines>: Update comment.
704 <clear>: Clear m_offset_cache.
705 <get_plain_source_lines>: Change parameters.
707 <m_offset_cache>: New member.
708 * source.c (forget_cached_source_info_for_objfile): Update.
709 (info_source_command): Use g_source_cache.
710 (find_source_lines, open_source_file_with_line_charpos): Remove.
711 (print_source_lines_base, search_command_helper): Use g_source_cache.
712 * source.h (open_source_file_with_line_charpos): Don't declare.
713 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
714 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
717 2019-08-06 Tom Tromey <tromey@adacore.com>
719 * source-cache.c (source_cache::get_plain_source_lines):
720 Remove "first_line" and "last_line" parameters.
721 (source_cache::get_source_lines): Cache plain text.
722 * source-cache.h (class source_cache)
723 <get_plain_source_lines>: Update.
725 2019-08-06 Tom Tromey <tromey@adacore.com>
727 * source-cache.c (extract_lines): No longer a method.
728 Changed type of parameter. Include final newline.
729 (selftests::extract_lines_test): New function.
730 (_initialize_source_cache): Likewise.
731 * source-cache.h (class source_cache)
732 <extract_lines>: Don't declare.
734 2019-08-06 Tom Tromey <tromey@adacore.com>
736 * breakpoint.c (init_breakpoint_sal): Update.
737 (breakpoint): Update.
738 * breakpoint.h (struct breakpoint) <filter>: Now a
741 2019-08-05 Christian Biesinger <cbiesinger@google.com>
743 * NEWS: Mention dictionary access on blocks.
744 * python/py-block.c (blpy_getitem): New function.
745 (block_object_as_mapping): New struct.
746 (block_object_type): Use new struct for tp_as_mapping field.
748 2019-08-05 Christian Biesinger <cbiesinger@google.com>
750 * objfiles.h (objfile): Add a comment describing partial symbols.
752 2019-08-05 Tom Tromey <tromey@adacore.com>
754 * compile/compile.c (_initialize_compile): Use _(), not N_().
755 * thread.c (_initialize_thread): Use _(), not N_().
756 * stack.c (_initialize_stack): Use _(), not N_().
757 * printcmd.c (_initialize_printcmd): Use _(), not N_().
759 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
761 * dwarf2read.c (struct dw2_symtab_iterator):
762 <want_specific_block>: Remove.
763 <block_index>: Change type to gdb::optional.
764 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
765 change type of BLOCK_INDEX parameter to gdb::optional.
766 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
767 (dw2_lookup_symbol): Don't pass argument for
769 (dw2_expand_symtabs_for_function): Don't pass argument for
770 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
771 (class dw2_debug_names_iterator)
772 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
773 parameter, change BLOCK_INDEX type to gdb::optional.
774 <m_want_specific_block>: Remove.
775 <m_block_index>: Change type to gdb::optional.
776 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
777 gdb::optional. Re-write in function of gdb::optional.
778 (dw2_debug_names_lookup_symbol): Don't pass argument for
780 (dw2_debug_names_expand_symtabs_for_function): Don't pass
781 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
784 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
786 * NEWS: Mention changes to "info sources" command.
788 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
790 * symtab.c (filename_partial_match_opts): New struct type.
791 (struct output_source_filename_data): New members
792 regexp, c_regexp, partial_match.
793 (output_source_filename): Use new members to decide to print file.
794 (info_sources_option_defs): New variable.
795 (make_info_sources_options_def_group, print_info_sources_header,
796 info_sources_command_completer):
798 (info_sources_command): Read new optional arguments.
799 (_initialize_symtab): Update info sources help.
801 2019-08-02 Alexandre Oliva <oliva@adacore.com>
803 * ada-lang.c (exception_support_info_v0): Renamed from...
804 (default_exception_support_info): ... this. Create new
806 (ada_has_this_exception_support): Look up catch_handlers_sym.
807 (ada_exception_support_info_sniffer): Try v0 after default.
809 2019-08-01 Tom Tromey <tromey@adacore.com>
811 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
814 2019-08-01 Christian Biesinger <cbiesinger@google.com>
816 * s12z-tdep.c: Fix include path for s12z-opc.h.
818 2019-08-01 Alan Hayward <alan.hayward@arm.com>
820 * NEWS: Require GNU make 3.82.
822 2019-07-16 Tom Tromey <tom@tromey.com>
824 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
827 2019-07-30 Tom Tromey <tromey@adacore.com>
829 * block.c (contained_in): Remove BLOCK_FUNCTION check.
831 2019-07-30 Kevin Buettner <kevinb@redhat.com>
833 * printcmd.c (print_address_symbolic): Print negative offsets.
834 (build_address_symbolic): Force signed arithmetic when computing
837 2019-07-30 Christian Biesinger <cbiesinger@google.com>
839 PR/24474: Add a function to lookup static variables.
840 * NEWS: Mention this new function.
841 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
842 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
843 * python/python.c (python_GdbMethods): Add new function.
845 2019-07-29 Christian Biesinger <cbiesinger@google.com>
847 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
848 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
849 (objfpy_lookup_static_symbol): New function.
850 (objfile_object_methods): Add new functions.
852 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
854 * NEWS: Mention 'set|show print frame-info'. Mention new
855 'presence' value for 'frame-arguments'. Mention new '-frame-info'
856 backtrace argument. Mention that python frame filtering code
857 is now consistent with what 'backtrace' command prints.
859 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
861 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
863 (print_frame_info_auto, print_frame_info_source_line,
864 print_frame_info_location, print_frame_info_source_and_location,
865 print_frame_info_location_and_address, print_frame_info_short_location):
867 (struct frame_print_options): New member print_frame_info.
868 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
869 * stack.h (get_user_print_what_frame_info): New declaration.
870 (frame_show_address): New declaration.
871 * stack.c (print_frame_arguments_choices): New value 'presence'.
872 (print_frame_info_auto, print_frame_info_source_line,
873 print_frame_info_location, print_frame_info_source_and_location,
874 print_frame_info_location_and_address, print_frame_info_short_location,
875 print_frame_info_choices, print_frame_info_print_what): New definitions.
876 (print_frame_args): Only print dots for args if print frame-arguments
878 (frame_print_option_defs): New element for "frame-info".
879 (get_user_print_what_frame_info): New function.
880 (frame_show_address): Make non static. Move comment to stack.h.
881 (print_frame_info_to_print_what): New function.
882 (print_frame_info): Update comment. Use fp_opts.print_frame_info
883 to decide what to print.
884 (backtrace_command_1): Handle the new print_frame_arguments_presence
886 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
887 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
888 (py_print_frame): In non-mi mode, use LOCATION as default for
889 print_what, similarly to frame information printed directly by
890 backtrace command. Handle frame-info user option in non MI mode.
892 2019-07-27 Kevin Buettner <kevinb@redhat.com>
894 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
895 Add case for debugging 32-bit target on 64-bit host. Revise
898 2019-07-27 Kevin Buettner <kevinb@redhat.com>
900 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
901 instead of find_function_entry_range_from_pc.
903 2019-07-27 Kevin Buettner <kevinb@redhat.com>
905 * stack.c (find_frame_funname): Remove code which preferred
906 minsym over symtab sym in "certain pathological cases".
908 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
909 parameter. Change type of "do_demangle" to bool.
910 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
911 Pass suitable "prefer_sym_over_minsym" flag to
912 build_address_symbolic(). Don't output "+" for negative offsets.
913 * printcmd.c (print_address_symbolic): Update invocation of
914 build_address_symbolic to include a "prefer_sym_over_minsym"
916 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
917 Restrict cases in which use of minimal symbol is preferred to that
918 of a found symbol. Update comments.
920 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
921 for entry pc when entry pc is out of range for that FDE.
923 2019-07-26 Brian Callahan <bcallah@openbsd.org>
926 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
929 2019-07-25 Christian Biesinger <cbiesinger@google.com>
931 * python/py-objfile.c (add_separate_debug_file): Fix comment about
932 this function's Python signature.
935 2019-07-24 Christian Biesinger <cbiesinger@google.com>
937 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
938 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
939 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
940 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
941 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
944 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
946 * h8300-tdep.c (h8300_register_name_common): New.
947 h8300_register_name): Use h8300_register_name_common.
948 (h8300s_register_name): Likewise.
949 (h8300sx_register_name): Likewise.
950 (h8300h_register_nam): New.
951 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
954 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
956 * arm-tdep.c (arm_skip_cmse_entry): New function.
957 (arm_is_sgstubs_section): New function.
958 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
960 2019-07-22 Tom Tromey <tom@tromey.com>
962 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
965 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
967 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
970 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
972 * symtab.c (search_symbols): Adjust msymbol matching type arrays
973 so that GDB doesn't match any msymbols when searching in the
975 (print_symbol_info): Print using typedef_print or type_print based
976 on the type of the symbol. Add updated FIXME comment moved from...
977 (_initialize_symtab): ... move and update FIXME comment to above.
979 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
981 * NEWS: Mention adding -q option to "info types".
982 * symtab.c (struct info_types_options): New struct.
983 (info_types_options_defs): New variable.
984 (make_info_types_options_def_group): New function.
985 (info_types_command): Use gdb::option framework to parse options.
986 (info_types_command_completer): New function.
987 (_initialize_symtab): Extend the help text on "info types" and
988 register command completer.
990 2019-07-21 Christian Biesinger <cbiesinger@google.com>
992 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
993 (lookup_symbol_in_objfile): Change int to block_enum and add a
994 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
996 2019-07-20 Christian Biesinger <cbiesinger@google.com>
998 * MAINTAINERS (Write After Approval): Add self.
1000 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1002 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1003 instruction to the dummy code region.
1005 2019-07-19 Tom Tromey <tromey@adacore.com>
1007 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1008 (ARGSUSED, PARAMS, __func__): Remove rules.
1010 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1012 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1013 * features/arm/arm-with-iwmmxt.c: Remove.
1014 * features/arm/arm-with-iwmmxt.xml: Remove.
1015 * features/arm/arm-with-m-fpa-layout.c: Remove.
1016 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1017 * features/arm/arm-with-m-vfp-d16.c: Remove.
1018 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1019 * features/arm/arm-with-m.c: Remove.
1020 * features/arm/arm-with-m.xml: Remove.
1021 * features/arm/arm-with-neon.c: Remove.
1022 * features/arm/arm-with-neon.xml: Remove.
1023 * features/arm/arm-with-vfpv2.c: Remove.
1024 * features/arm/arm-with-vfpv2.xml: Remove.
1025 * features/arm/arm-with-vfpv3.c: Remove.
1026 * features/arm/arm-with-vfpv3.xml: Remove.
1028 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1030 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1032 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1034 * arch/aarch32.c (aarch32_create_target_description): Create
1035 target descriptions using features.
1036 * arch/arm.c (arm_create_target_description)
1037 (arm_create_mprofile_target_description): Likewise.
1038 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1040 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1042 * Makefile.in: Add new files.
1043 * aarch32-tdep.c: New file.
1044 * aarch32-tdep.h: New file.
1045 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1046 Call aarch32_read_description.
1047 * arch/aarch32.c: New file.
1048 * arch/aarch32.h: New file.
1049 * arch/arm.c (arm_create_target_description)
1050 (arm_create_mprofile_target_description): New function.
1051 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1052 (arm_create_target_description)
1053 (arm_create_mprofile_target_description): New declaration.
1054 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1055 read_description functions.
1056 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1058 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1059 * arm-tdep.c (tdesc_arm_list): New variable.
1060 (arm_register_g_packet_guesses): Call create description functions.
1061 (arm_read_description) (arm_read_mprofile_description): New
1063 * arm-tdep.h (arm_read_description)
1064 (arm_read_mprofile_description): Add declaration.
1065 * configure.tgt: Add new files.
1067 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1069 * top.c (new_ui_command): Open specified terminal just once.
1071 2019-07-18 Tom Tromey <tromey@adacore.com>
1073 * symtab.c (main_name): Constify return type.
1074 * symfile.c (set_initial_language): Update.
1075 * symtab.h (main_name): Constify return type.
1077 2019-07-17 Tom Tromey <tom@tromey.com>
1079 * tui/tui-winsource.c (tui_update_source_window)
1080 (tui_update_source_window_as_is)
1081 (tui_update_source_windows_with_line): Remove return.
1082 * tui/tui-disasm.c (tui_show_disassem)
1083 (tui_show_disassem_and_update_source): Remove return.
1084 * tui/tui.c (tui_reset): Remove return.
1085 * tui/tui-wingeneral.c
1086 (tui_check_and_display_highlight_if_needed): Remove return.
1088 2019-07-17 Tom Tromey <tom@tromey.com>
1090 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1092 2019-07-17 Tom Tromey <tom@tromey.com>
1094 * tui/tui-winsource.h (struct tui_exec_info_window)
1095 (struct tui_source_window_base): Move from tui-data.h.
1096 * tui/tui-winsource.c: Move many method definitions from
1097 elsewhere. Remove "structuring" comments.
1098 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1099 (tui_source_window_base::refresh_window): Move to
1101 * tui/tui-win.c (tui_source_window_base::refresh_all)
1102 (tui_source_window_base::update_tab_width)
1103 (tui_source_window_base::set_new_height)
1104 (tui_source_window_base::do_make_visible_with_new_height): Move to
1106 * tui/tui-source.h: Update.
1107 * tui/tui-source.c (tui_source_window_base::reset): Move to
1109 * tui/tui-disasm.h: Update.
1110 * tui/tui-data.h (struct tui_exec_info_window): Move to
1112 (struct tui_source_window_base): Likewise.
1113 * tui/tui-data.c (tui_source_window_base::clear_detail)
1114 (tui_source_window_base, ~tui_source_window_base): Move to
1117 2019-07-17 Tom Tromey <tom@tromey.com>
1119 * tui/tui-win.c (tui_resize_all)
1120 (tui_source_window_base::update_tab_width)
1121 (tui_adjust_win_heights): Update.
1122 (tui_win_info::make_invisible_and_set_new_height): Rename from
1123 make_invisible_and_set_new_height.
1124 * tui/tui-data.h (struct tui_win_info)
1125 <make_invisible_and_set_new_height>: New method.
1127 2019-07-17 Tom Tromey <tom@tromey.com>
1129 * tui/tui.c: Update.
1130 * tui/tui-source.h (struct tui_source_window): Move from
1132 * tui/tui-layout.c: Update.
1133 * tui/tui-disasm.c: Update.
1134 * tui/tui-data.h (struct tui_source_window): Move to
1137 2019-07-17 Tom Tromey <tom@tromey.com>
1139 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1141 * tui/tui-data.h (struct tui_disasm_window): Move to
1144 2019-07-17 Tom Tromey <tom@tromey.com>
1146 * tui/tui-regs.h (struct tui_data_item_window): Move from
1148 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1149 * tui/tui-data.h (struct tui_data_item_window): Move to
1151 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1153 2019-07-17 Tom Tromey <tom@tromey.com>
1155 * tui/tui.c: Update.
1156 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1157 (tui_cmd_window::max_height): Move to tui-command.c.
1158 * tui/tui-layout.c: Update.
1159 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1160 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1162 * tui/tui-command.h (struct tui_cmd_window): Move from
1164 * tui/tui-command.c: Remove "structuring" comments.
1165 (tui_cmd_window::clear_detail)
1166 (tui_cmd_window::do_make_visible_with_new_height)
1167 (tui_cmd_window::max_height): Move from elsewhere.
1169 2019-07-17 Tom Tromey <tom@tromey.com>
1171 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1173 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1174 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1176 2019-07-17 Tom Tromey <tom@tromey.com>
1178 * tui/tui.c: Update.
1179 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1181 * tui/tui-windata.h: Remove file.
1182 * tui/tui-windata.c: Remove file.
1183 * tui/tui-win.c (tui_data_window::set_new_height)
1184 (tui_data_window::do_make_visible_with_new_height): Move to
1186 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1187 * tui/tui-regs.c: Remove "structuring" comments.
1188 (tui_data_window::first_data_item_displayed)
1189 (tui_data_window::delete_data_content_windows)
1190 (tui_data_window::erase_data_content)
1191 (tui_data_window::display_all_data)
1192 (tui_data_window::refresh_all)
1193 (tui_data_window::do_scroll_vertical)
1194 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1195 (tui_data_window::do_make_visible_with_new_height)
1196 (tui_data_window::refresh_window): Move from elsewhere.
1197 (_initialize_tui_regs): Move to end of file.
1198 * tui/tui-layout.c: Update.
1199 * tui/tui-hooks.c: Update.
1200 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1201 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1203 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1205 2019-07-17 Tom Tromey <tom@tromey.com>
1207 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1210 2019-07-17 Tom Tromey <tom@tromey.com>
1212 * tui/tui-win.c (tui_source_window_base::set_new_height)
1213 (tui_source_window_base::do_make_visible_with_new_height): Use
1214 m_has_locator field directly.
1215 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1217 (struct tui_source_window_base) <has_locator>: Likewise.
1219 2019-07-17 Tom Tromey <tom@tromey.com>
1221 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1223 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1225 * tui/tui-win.c (tui_source_window_base::set_new_height)
1226 (tui_source_window_base::set_new_height)
1227 (make_invisible_and_set_new_height)
1228 (tui_source_window_base::do_make_visible_with_new_height)
1229 (tui_source_window_base::do_make_visible_with_new_height):
1231 * tui/tui-layout.c (show_source_disasm_command, show_data)
1232 (show_source_or_disasm_and_command): Update.
1233 * tui/tui-layout.c (show_layout): Update.
1235 2019-07-17 Tom Tromey <tom@tromey.com>
1237 * tui/tui-layout.c (make_data_window): Remove.
1238 (show_data): Unify creation and re-initialization cases.
1240 2019-07-17 Tom Tromey <tom@tromey.com>
1242 * tui/tui-layout.c (make_source_window, make_disasm_window):
1244 (show_data): Unify creation and re-initialization cases.
1246 2019-07-17 Tom Tromey <tom@tromey.com>
1248 * tui/tui-layout.c (make_command_window): Remove.
1249 (show_source_disasm_command, show_source_or_disasm_and_command):
1250 Unify creation and re-initialization cases.
1252 2019-07-17 Tom Tromey <tom@tromey.com>
1254 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1255 creation and re-initialization cases.
1257 2019-07-17 Tom Tromey <tom@tromey.com>
1259 * tui/tui-regs.c (tui_get_register): Return void.
1261 2019-07-17 Tom Tromey <tom@tromey.com>
1263 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1266 2019-07-17 Tom Tromey <tom@tromey.com>
1268 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1271 2019-07-17 Tom Tromey <tom@tromey.com>
1273 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1274 * tui/tui-regs.c (tui_reg_layout): New function.
1275 (tui_show_registers, tui_reg_command): Use it.
1276 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1277 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1279 (tui_layout_command): Remove.
1281 2019-07-17 Tom Tromey <tom@tromey.com>
1283 * tui/tui-layout.h (tui/tui-layout): Return void.
1284 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1286 2019-07-17 Tom Tromey <tom@tromey.com>
1288 * tui/tui-layout.c (show_source_disasm_command, show_data):
1290 (reset_locator): Remove.
1291 (show_source_or_disasm_and_command): Update.
1293 2019-07-17 Tom Tromey <tom@tromey.com>
1295 * tui/tui-source.c (tui_source_window_base::reset): Remove
1297 * tui/tui-layout.c (make_command_window, make_source_window)
1298 (make_disasm_window, make_data_window)
1299 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1300 (reset_locator, show_source_or_disasm_and_command): Update.
1301 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1303 (struct tui_source_window_base) <reset>: Likewise.
1305 2019-07-17 Tom Tromey <tom@tromey.com>
1307 * tui/tui-layout.c (show_source_disasm_command): Use
1309 (reset_locator): New function.
1310 (init_and_make_win): Remove.
1311 (show_source_or_disasm_and_command): Use reset_locator.
1313 2019-07-17 Tom Tromey <tom@tromey.com>
1315 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1317 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1319 * tui/tui-source.c (tui_source_window_base::reset): New method.
1320 * tui/tui-layout.c (make_command_window): Don't call
1322 (make_source_window, make_disasm_window): Don't call
1323 make_source_or_disasm_window.
1324 (make_data_window): Don't call init_and_make_win. Change calling
1326 (show_source_disasm_command, show_data): Simplify.
1327 (make_source_or_disasm_window): Remove.
1328 (show_source_or_disasm_and_command): Simplify.
1329 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1330 (struct tui_source_window_base) <reset>: Likewise.
1331 <execution_info>: Remove initializer.
1332 * tui/tui-data.c (tui_source_window_base): Initialize
1335 2019-07-17 Tom Tromey <tom@tromey.com>
1337 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1340 2019-07-17 Tom Tromey <tom@tromey.com>
1342 * tui/tui.c (tui_rl_other_window): Update.
1343 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1344 superclass method first. Always iterate over regs_content.
1345 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1347 * tui/tui-win.c (tui_set_focus_command): Update.
1349 2019-07-17 Tom Tromey <tom@tromey.com>
1351 * tui/tui-win.c (tui_set_focus_command): Rename from
1352 tui_set_focus. Call tui_enable.
1353 (tui_set_focus_command): Remove.
1355 2019-07-17 Tom Tromey <tom@tromey.com>
1357 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1359 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1361 (tui_data_window::refresh_window): Call refresh_window on data
1362 items. Always call superclass refresh_window.
1363 (tui_win_info::refresh): Remove.
1364 (tui_source_window_base::refresh_window): Update.
1365 (tui_refresh_all): Update.
1366 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1368 (show_source_or_disasm_and_command): Likewise.
1369 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1370 (struct tui_source_window_base) <refresh>: Likewise.
1372 2019-07-17 Tom Tromey <tom@tromey.com>
1374 * tui/tui-winsource.c (tui_clear_source_content)
1375 (tui_show_source_content): Update.
1376 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1377 whether content is empty.
1378 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1381 2019-07-17 Tom Tromey <tom@tromey.com>
1383 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1385 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1386 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1388 2019-07-17 Tom Tromey <tom@tromey.com>
1390 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1391 (struct tui_data_item_window): Update.
1393 2019-07-17 Tom Tromey <tom@tromey.com>
1395 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1396 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1399 2019-07-17 Tom Tromey <tom@tromey.com>
1401 * tui/tui-winsource.h (tui_erase_source_content)
1402 (tui_clear_source_content): Remove "display_prompt" parameter.
1403 * tui/tui-winsource.c (tui_update_source_window_as_is)
1404 (tui_update_source_windows_with_addr): Update.
1405 (tui_clear_source_content): Remove "display_prompt" parameter.
1406 (tui_erase_source_content): Likewise. Simplify.
1407 (tui_show_source_content): Update.
1408 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1409 * tui/tui-stack.c (tui_show_frame_info): Update.
1410 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1413 2019-07-17 Tom Tromey <tom@tromey.com>
1415 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1416 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1418 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1421 2019-07-17 Tom Tromey <tom@tromey.com>
1423 * tui/tui-winsource.c (tui_clear_source_content)
1424 (tui_show_source_content, tui_show_exec_info_content)
1425 (tui_clear_exec_info_content): Update.
1426 * tui/tui-stack.c (tui_show_locator_content): Update.
1427 (tui_show_frame_info): Update.
1428 * tui/tui-source.h (tui_source_window): Don't declare.
1429 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1430 from tui_source_is_displayed.
1431 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1433 (struct tui_source_window_base) <content_in_use>: New field. Now
1435 (struct tui_source_window) <showing_source_p>: New method.
1436 (TUI_SRC_WIN): Change cast.
1437 * tui/tui-data.c (tui_initialize_static_data): Update.
1439 2019-07-17 Tom Tromey <tom@tromey.com>
1441 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1443 * tui/tui-source.c (tui_source_window::location_matches_p): New
1445 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1447 * tui/tui-data.h (struct tui_source_window_base)
1448 <location_matches_p>: New method.
1449 (struct tui_source_window, struct tui_disasm_window)
1450 <location_matches_p>: Likewise.
1452 2019-07-17 Tom Tromey <tom@tromey.com>
1454 * tui/tui-win.c (tui_set_win_height_command): Rename from
1456 (tui_set_win_height_command): Remove.
1458 2019-07-17 Tom Tromey <tom@tromey.com>
1460 * tui/tui-source.c (tui_source_window): New constructor. Add
1462 (~tui_source_window): New destructor.
1463 (tui_source_window::style_changed): New method.
1464 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1465 (tui_attach_detach_observers): Update.
1466 * tui/tui-data.h (struct tui_source_window): Make constructor not
1467 inline. Add destructor.
1468 (struct tui_source_window) <style_changed>: New method.
1469 <m_observable>: New member.
1471 2019-07-17 Tom Tromey <tom@tromey.com>
1473 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1474 * tui/tui-win.c (tui_resize_all): Fix typo.
1476 2019-07-17 Tom Tromey <tom@tromey.com>
1478 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1479 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1480 (tui_refresh_all): Remove "list" parameter. Use foreach.
1481 * tui/tui-win.c (window_name_completer): Use foreach.
1482 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1483 (update_tab_width): Likewise.
1484 * tui/tui-layout.c (show_layout): Update.
1485 * tui/tui-data.h (class tui_window_iterator): New.
1486 (struct all_tui_windows): New.
1487 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1489 2019-07-17 Tom Tromey <tom@tromey.com>
1491 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1492 parameter. Don't reference globals.
1493 (tui_reg_command): Update.
1495 2019-07-17 Tom Tromey <tom@tromey.com>
1497 * tui/tui-regs.c (tui_show_registers): Simplify.
1499 2019-07-17 Tom Tromey <tom@tromey.com>
1501 * tui/tui-regs.c (tui_show_registers): Update.
1502 (tui_show_register_group): Add win_info parameter.
1504 2019-07-17 Tom Tromey <tom@tromey.com>
1506 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1507 Rename from tui_display_reg_element_at_line.
1508 (tui_data_window::display_registers_from_line): Update.
1509 * tui/tui-data.h (struct tui_data_window)
1510 <display_reg_element_at_line>: New method.
1512 2019-07-17 Tom Tromey <tom@tromey.com>
1514 * tui/tui-regs.h (tui_display_registers_from)
1515 (tui_display_registers_from_line): Don't declare.
1516 * tui/tui-windata.c (tui_data_window::display_all_data)
1517 (tui_data_window::refresh_all)
1518 (tui_data_window::do_scroll_vertical): Update.
1519 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1520 from tui_display_registers_from.
1521 (tui_display_reg_element_at_line): Update.
1522 (tui_data_window::display_registers_from_line): Rename from
1523 tui_display_registers_from_line.
1524 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1525 display_registers_from_line>: New methods.
1527 2019-07-17 Tom Tromey <tom@tromey.com>
1529 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1530 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1531 from tui_erase_data_content.
1532 (tui_data_window::display_all_data)
1533 (tui_data_window::refresh_all)
1534 (tui_data_window::do_scroll_vertical): Update.
1535 * tui/tui-regs.c (tui_show_registers): Update.
1536 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1539 2019-07-17 Tom Tromey <tom@tromey.com>
1541 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1544 (tui_data_window::delete_data_content_windows): Rename from
1545 tui_delete_data_content_windows.
1546 (tui_data_window::display_all_data)
1547 (tui_data_window::do_scroll_vertical): Update.
1548 * tui/tui-data.h (struct tui_data_window)
1549 <delete_data_content_windows>: New method.
1551 2019-07-17 Tom Tromey <tom@tromey.com>
1553 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1554 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1556 2019-07-17 Tom Tromey <tom@tromey.com>
1558 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1559 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1560 from tui_display_all_data.
1562 (tui_data_window::do_make_visible_with_new_height): Update.
1563 * tui/tui-regs.c (tui_show_registers): Update.
1564 * tui/tui-layout.c (tui_set_layout): Update.
1565 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1568 2019-07-17 Tom Tromey <tom@tromey.com>
1570 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1571 * tui/tui-windata.c (tui_display_data_from): Remove.
1572 (tui_data_window::refresh_all): Update.
1574 2019-07-17 Tom Tromey <tom@tromey.com>
1576 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1577 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1578 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1579 tui_display_registers_from_line.
1580 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1581 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1582 "force_display" parameter.
1584 2019-07-17 Tom Tromey <tom@tromey.com>
1586 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1588 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1589 Rename from tui_first_reg_element_no_inline.
1590 (tui_display_reg_element_at_line)
1591 (tui_display_registers_from_line): Update.
1592 * tui/tui-data.h (struct tui_data_window)
1593 <first_reg_element_no_inline>: New method.
1595 2019-07-17 Tom Tromey <tom@tromey.com>
1597 * tui/tui-windata.c (tui_display_data_from)
1598 (tui_data_window::do_scroll_vertical): Update.
1599 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1600 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1601 Rename from tui_line_from_reg_element_no.
1602 (tui_display_registers_from_line): Update.
1603 * tui/tui-data.h (struct tui_data_window)
1604 <line_from_reg_element_no>: New method.
1606 2019-07-17 Tom Tromey <tom@tromey.com>
1608 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1609 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1610 tui_last_regs_line_no.
1611 (tui_display_reg_element_at_line)
1612 (tui_display_registers_from_line): Update.
1613 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1616 2019-07-17 Tom Tromey <tom@tromey.com>
1619 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1620 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1621 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1622 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1623 (tui_update_breakpoint_info): Likewise.
1624 * tui/tui-hooks.c (tui_event_create_breakpoint)
1625 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1628 2019-07-17 Tom Tromey <tom@tromey.com>
1630 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1632 2019-07-17 Tom Tromey <tom@tromey.com>
1634 * tui/tui-winsource.c (tui_update_source_window_as_is)
1635 (tui_update_source_windows_with_addr): Update.
1636 * tui/tui-source.h (tui_set_source_content)
1637 (tui_show_symtab_source): Add "win_info" parameter.
1638 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1640 (tui_show_symtab_source): Likewise.
1642 2019-07-17 Tom Tromey <tom@tromey.com>
1644 * tui/tui-wingeneral.c
1645 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1647 2019-07-17 Tom Tromey <tom@tromey.com>
1649 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1650 (struct tui_cmd_window) <can_scroll>: New method.
1651 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1654 2019-07-17 Tom Tromey <tromey@adacore.com>
1656 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1657 do_field_signed>: Rename. Change type of "value".
1658 * ui-out.c (ui_out::field_signed): Rename from field_int.
1659 Change type of "value".
1660 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1662 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1663 do_field_int. Change type of "value".
1664 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1665 do_field_int. Change type of "value".
1666 * tracepoint.c (trace_status_mi, tfind_1)
1667 (print_one_static_tracepoint_marker): Update.
1668 * thread.c (print_thread_info_1, print_selected_thread_frame):
1670 * stack.c (print_frame, print_frame_info): Update.
1671 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1673 * source.c (print_source_lines_base): Update.
1674 * skip.c (info_skip_command): Update.
1675 * record-btrace.c (btrace_ui_out_decode_error)
1676 (btrace_call_history_src_line): Update.
1677 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1679 * progspace.c (print_program_space): Update.
1680 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1681 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1682 do_field_int. Change type of "value".
1683 * mi/mi-out.c (mi_ui_out::do_table_begin)
1684 (mi_ui_out::do_table_header): Update.
1685 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1687 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1688 (mi_cmd_data_list_changed_registers, output_register)
1689 (mi_cmd_data_read_memory, mi_load_progress)
1690 (mi_cmd_trace_frame_collected): Update.
1691 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1693 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1694 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1695 (mi_cmd_var_list_children, varobj_update_one): Update.
1696 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1697 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1698 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1699 * inferior.c (print_inferior): Update.
1700 * gdb_bfd.c (print_one_bfd): Update.
1701 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1703 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1704 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1705 do_field_int. Change type of "value".
1706 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1707 do_field_int. Change type of "value".
1708 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1709 (print_one_breakpoint_location, print_it_catch_fork)
1710 (print_one_catch_fork, print_it_catch_vfork)
1711 (print_one_catch_vfork, print_it_catch_solib)
1712 (print_it_catch_exec, print_it_ranged_breakpoint)
1713 (print_mention_watchpoint, print_mention_masked_watchpoint)
1714 (bkpt_print_it, update_static_tracepoint): Update.
1715 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1716 * break-catch-syscall.c (print_it_catch_syscall): Update.
1717 * ada-tasks.c (print_ada_task_info): Update.
1718 * ada-lang.c (print_it_exception, print_mention_exception):
1721 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1723 PR breakpoints/24541
1724 * gdbarch.c: Regenerate.
1725 * gdbarch.h: Regenerate.
1726 * gdbarch.sh: Adjust return type and parameter types for
1727 'stap_adjust_register'.
1728 (i386_stap_adjust_register): Adjust signature and return new
1730 * stap-probe.c (stap_parse_register_operand): Adjust use of
1731 'gdbarch_stap_adjust_register'.
1733 2019-07-17 Tom Tromey <tromey@adacore.com>
1735 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1737 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1739 (struct s390_process_info): Add initializers.
1740 (s390_add_process): Use new.
1741 (s390_linux_nat_target::low_forget_process): Use delete.
1742 (s390_linux_nat_target::low_new_fork)
1743 (s390_linux_nat_target::stopped_by_watchpoint)
1744 (s390_linux_nat_target::low_prepare_to_resume)
1745 (s390_linux_nat_target::insert_watchpoint)
1746 (s390_linux_nat_target::insert_hw_breakpoint)
1747 (s390_linux_nat_target::remove_watchpoint)
1748 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1750 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1752 * aarch64-fbsd-nat.c: Include regcache.h.
1753 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1755 (aarch64_fbsd_nat_target::fetch_registers)
1756 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1758 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1760 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1762 * fbsd-nat.c: Include gdbarch.h.
1764 2019-07-15 Tom Tromey <tromey@adacore.com>
1766 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1768 2019-07-15 Tom Tromey <tromey@adacore.com>
1770 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1771 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1772 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1773 * cli-out.c (cli_ui_out::do_field_int): New method.
1774 * ui-out.c (ui_out::field_unsigned): New method.
1775 * symfile.c (generic_load): Use field_unsigned.
1776 (print_transfer_performance): Likewise.
1777 * record-btrace.c (ui_out_field_uint): Remove.
1778 (btrace_call_history_insn_range, btrace_call_history): Use
1780 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1782 * ui-out.h (class ui_out) <field_unsigned>: New method.
1783 <do_field_unsigned>: Likewise.
1785 2019-07-15 Tom Tromey <tromey@adacore.com>
1787 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1788 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1789 * target.c (flash_erase_command): Use field_string.
1790 * infrun.c (print_signal_received_reason): Use field_string.
1791 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1792 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1794 * ada-tasks.c (print_ada_task_info): Use field_string.
1796 2019-07-15 Tom Tromey <tromey@adacore.com>
1798 * target.c (flash_erase_command): Use field_core_addr.
1799 * symfile.c (generic_load): Use field_core_addr.
1800 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1801 Use field_core_addr.
1802 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1805 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1807 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1808 value if its desired type is smaller than a CORE_ADDR and signed.
1810 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1812 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1813 of changes to field names, and use new is_reference field to
1814 decide if a property is a reference or not.
1815 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1817 (struct dwarf2_property_baton): Update header comment, rename
1818 'referenced_type' to 'property_type' and update comments.
1819 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1820 default property type, store in property baton, update to take
1821 accound of renamed field.
1822 (read_func_scope): Update call to attr_to_dynamic_prop.
1823 (read_array_type): Likewise.
1824 (dwarf2_per_cu_addr_sized_int_type): New function.
1825 (read_subrange_index_type): Move type finding code to
1826 dwarf2_per_cu_addr_sized_int_type.
1827 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1828 (dwarf2_per_cu_addr_type): New function.
1829 (set_die_type): Update calls to attr_to_dynamic_prop.
1831 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1833 * dwarf2read.c (read_subrange_index_type): New function.
1834 (read_subrange_type): Move code into new function and call it.
1835 * gdbtypes.c (create_range_type): Add some asserts.
1837 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1839 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1840 update return statements.
1841 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1842 declaration, and update comment to match.
1843 * gdbtypes.c (resolve_dynamic_array): Update call to
1844 dwarf2_evaluate_property to match new return type.
1846 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1848 * valarith.c (value_subscripted_rvalue): Change lowerbound
1849 parameter type from int to LONGEST.
1850 * value.h (value_subscripted_rvalue): Likewise in declaration.
1852 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1854 * cli/cli-utils.c (info_print_command_completer): New function.
1855 * cli/cli-utils.h: Add 'completer.h' include, and forward
1856 declaration for 'struct cmd_list_element'.
1857 (info_print_command_completer): Declare.
1858 * stack.c (_initialize_stack): Add completer for 'info locals' and
1860 * symtab.c (_initialize_symtab): Add completer for 'info
1861 variables' and 'info functions'.
1862 * NEWS: Mention completion for additional info commands.
1864 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1866 * cli/cli-utils.c (extract_info_print_args): Delete.
1867 (extract_arg_maybe_quoted): Delete.
1868 (info_print_options_defs): New variable.
1869 (make_info_print_options_def_group): New function.
1870 (extract_info_print_options): Define new function.
1871 * cli/cli-utils.h (extract_info_print_args): Delete.
1872 (struct info_print_options): New structure.
1873 (extract_info_print_options): Declare new function.
1874 * stack.c (info_locals_command): Update to use new
1875 extract_info_print_options, also add a header comment.
1876 (info_args_command): Likewise.
1877 * symtab.c (info_variables_command): Likewise.
1878 (info_functions_command): Likewise.
1880 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1882 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1883 to extract string arguments.
1884 * common/common-utils.c (extract_string_maybe_quoted): New function.
1885 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1887 2019-07-11 Tom Tromey <tromey@adacore.com>
1889 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1890 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1891 * top.h (gdbinit): Don't declare.
1892 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1894 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1895 * top.c (gdb_init): Don't call init_cli_cmds.
1897 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1899 2019-07-11 Tom Tromey <tromey@adacore.com>
1901 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1902 after it has been moved.
1904 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1906 * valops.c (value_must_coerce_to_target): Change return type to
1908 * value.h (value_must_coerce_to_target): Likewise.
1910 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
1912 * breakpoint.c (is_hardware_watchpoint): Remove
1913 forward-declaration.
1914 (is_masked_watchpoint): Change return type to bool.
1915 (is_tracepoint): Likewise.
1916 (is_breakpoint): Likewise.
1917 (is_hardware_watchpoint): Likewise.
1918 (is_watchpoint): Likewise.
1919 (is_no_memory_software_watchpoint): Likewise.
1920 (is_catchpoint): Likewise.
1921 (breakpoint_1): Make FILTER parameter's return type bool.
1922 is_masked_watchpoint): Change return type to bool.
1923 (save_breakpoints): Make FILTER parameter's return type bool.
1924 * breakpoint.h (is_breakpoint): Change return type to bool.
1925 (is_watchpoint): Likewise.
1926 (is_catchpoint): Likewise.
1927 (is_tracepoint): Likewise.
1929 2019-07-10 Tom Tromey <tom@tromey.com>
1931 * defs.h: Don't include gdbarch.h.
1932 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1933 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1934 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1935 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1936 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1937 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1938 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1939 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1940 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1941 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1942 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1943 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1944 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1945 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1946 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1947 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1948 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1949 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1950 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1951 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1952 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1953 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1954 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1955 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1956 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1957 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1958 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1960 2019-07-10 Tom Tromey <tromey@adacore.com>
1962 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1963 * breakpoint.c (init_ada_exception_breakpoint): Register as
1965 (print_one_breakpoint_location, print_one_breakpoint): Use
1966 is_ada_exception_catchpoint.
1967 * ada-lang.c (class ada_catchpoint_location): Pass
1968 bp_loc_software_breakpoint to bp_location constructor.
1969 (is_ada_exception_catchpoint): New function.
1971 2019-07-10 Tom Tromey <tromey@adacore.com>
1973 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1975 (struct arm_exidx_entry): New method operator<.
1976 (struct arm_exidx_data) <section_maps>: Change type.
1977 (arm_exidx_data_free): Remove.
1978 (arm_exidx_data_key): Change type. Move lower.
1979 (arm_exidx_new_objfile): Update.
1980 (arm_compare_exidx_entries): Remove.
1981 (arm_find_exidx_entry, _initialize_arm_tdep)
1983 2019-07-10 Tom Tromey <tromey@adacore.com>
1985 * solib-spu.c (ocl_program_data_key): Change type.
1986 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1989 2019-07-10 Tom Tromey <tromey@adacore.com>
1991 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1992 (struct solib_aix_inferior_data) <library_list>: Change type.
1993 (solib_aix_inferior_data_handle): Change type.
1994 (get_solib_aix_inferior_data): Update.
1995 (solib_aix_free_library_list): Remove.
1996 (library_list_start_library): Update.
1997 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1999 (solib_aix_get_library_list)
2000 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2001 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2003 2019-07-10 Tom Tromey <tromey@adacore.com>
2005 * solib-dsbt.c (struct dsbt_info): Add initializers.
2006 (solib_dsbt_pspace_data): Change type.
2007 (dsbt_pspace_data_cleanup): Remove.
2008 (get_dsbt_info, _initialize_dsbt_solib): Update.
2010 2019-07-10 Tom Tromey <tromey@adacore.com>
2012 * spu-tdep.c (spu_overlay_data): Change type.
2013 (spu_get_overlay_table, spu_overlay_new_objfile)
2014 (_initialize_spu_tdep): Update.
2016 2019-07-10 Tom Tromey <tromey@adacore.com>
2018 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2020 (dbx_objfile_data_key): Change type and declare later.
2021 (DBX_SYMFILE_INFO): Rewrite.
2022 * dbxread.c (dbx_objfile_data_key): Change type.
2023 (dbx_symfile_init): Update.
2024 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2025 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2026 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2028 2019-07-10 Tom Tromey <tromey@adacore.com>
2030 * jit.c (jit_program_space_key): Change type. Move lower.
2031 (get_jit_program_space_data): Update.
2032 (jit_program_space_data_cleanup): Remove.
2033 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2035 (struct jit_program_space_data): Add initializers.
2037 2019-07-10 Tom Tromey <tromey@adacore.com>
2039 * solib-darwin.c (struct darwin_info): Add initializers.
2040 (solib_darwin_pspace_data): Change type.
2041 (darwin_pspace_data_cleanup): Remove.
2042 (get_darwin_info, _initialize_darwin_solib): Update.
2044 2019-07-10 Tom Tromey <tromey@adacore.com>
2046 * remote-sim.c (struct sim_inferior_data): Add initializers,
2047 constructor, and destructor.
2048 (sim_inferior_data_key): Change type. Move lower.
2049 (check_for_duplicate_sim_descriptor): Update.
2050 (get_sim_inferior_data): Use new. Update.
2051 (~sim_inferior_data_cleanup): Rename from
2052 sim_inferior_data_cleanup. Simplify.
2053 (gdbsim_close_inferior, simulator_command)
2054 (sim_command_completer, _initialize_remote_sim): Update.
2055 (next_pid, INITIAL_PID): Move earlier.
2057 2019-07-10 Tom Tromey <tromey@adacore.com>
2059 * python/python-internal.h (create_thread_object): Return
2061 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2062 * python/py-inferior.c (struct threadlist_entry): Add
2064 <thread_obj>: Now a gdbpy_ref.
2065 (thread_to_thread_object): Update.
2066 (add_thread_object): Use new.
2067 (delete_thread_object): Use delete.
2068 (infpy_threads): Update.
2069 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2072 2019-07-10 Tom Tromey <tromey@adacore.com>
2074 * valops.c (value_cast): Specialize error message for Ada.
2076 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2078 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2080 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2082 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2083 bpstat_should_step): Return bool, adjust comments.
2084 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2085 bpstat_should_step): Likewise.
2087 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2089 * features/Makefile: Use feature target descriptions for Arm.
2090 * features/arm/arm-core.c: Generate new file.
2091 * features/arm/arm-fpa.c: Likewise.
2092 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2093 * features/arm/arm-m-profile.c: Likewise.
2094 * features/arm/arm-vfpv2.c: Likewise.
2095 * features/arm/arm-vfpv3.c: Likewise.
2096 * features/arm/xscale-iwmmxt.c: Likewise.
2097 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2099 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2101 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2104 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2106 * features/aarch64-pauth.c: Regenerate.
2108 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2110 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2112 (bpstat_what): Use false instead of 0.
2114 2019-07-09 Pedro Alves <palves@redhat.com>
2116 * break-catch-throw.c (is_exception_catchpoint): New.
2117 * breakpoint.c (print_one_breakpoint_location): New parameter
2118 'raw_loc'. Handle it. Use
2119 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2120 looking at the breakpoint's type.
2121 (print_one_breakpoint): If handling "maint info breakpoints", also
2122 print locations of exception catchpoints.
2123 * breakpoint.h (is_exception_catchpoint): Declare.
2125 2019-07-09 Pedro Alves <palves@redhat.com>
2127 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2129 (allocate_location_exception_catchpoint): New.
2130 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2131 (initialize_throw_catchpoint_ops): Install
2132 allocate_location_exception_catchpoint as allocate_location
2134 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2135 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2137 (breakpoint_address_is_meaningful): Delete.
2138 (bl_address_is_meaningful): New.
2139 (breakpoint_locations_match): Adjust comment.
2140 (bp_location_from_bp_type): New, factored out of...
2141 (bp_location::bp_location(breakpoint *)): ... this.
2142 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2144 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2145 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2146 breakpoint_address_is_meaningful.
2147 (bp_locations_compare): Adjust comment.
2148 (update_global_location_list): Use bl_address_is_meaningful
2149 instead of breakpoint_address_is_meaningful.
2150 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2152 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2153 * python/py-breakpoint.c (bppy_get_location): No longer check
2154 whether location is null.
2156 2019-07-09 Pedro Alves <palves@redhat.com>
2159 * breakpoint.c (print_one_breakpoint_location): Remove
2160 single-location assert.
2162 2019-07-09 Tom Tromey <tom@tromey.com>
2164 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2165 * configure: Rebuild.
2166 * configure.ac: Change common to gdbsupport.
2167 * gdbsupport: Rename from common.
2168 * acinclude.m4: Change common to gdbsupport.
2169 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2170 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2172 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2173 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2174 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2175 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2176 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2177 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2178 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2179 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2180 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2181 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2182 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2183 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2184 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2185 coff-pe-read.c, command.h, compile/compile-c-support.c,
2186 compile/compile-c.h, compile/compile-cplus-symbols.c,
2187 compile/compile-cplus-types.c, compile/compile-cplus.h,
2188 compile/compile-loc2c.c, compile/compile.c, completer.c,
2189 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2190 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2191 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2192 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2193 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2194 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2195 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2196 features/aarch64-core.c, features/aarch64-fpu.c,
2197 features/aarch64-pauth.c, features/aarch64-sve.c,
2198 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2199 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2200 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2201 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2202 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2203 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2204 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2205 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2206 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2207 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2208 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2209 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2210 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2211 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2212 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2213 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2214 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2215 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2216 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2217 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2218 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2219 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2220 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2221 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2222 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2223 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2224 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2225 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2226 minsyms.c, mips-linux-tdep.c, namespace.h,
2227 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2228 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2229 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2230 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2231 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2232 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2233 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2234 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2235 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2236 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2237 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2238 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2239 procfs.c, producer.c, progspace.h, psymtab.h,
2240 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2241 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2242 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2243 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2244 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2245 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2246 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2247 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2248 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2249 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2250 target-memory.c, target.c, target.h, target/waitstatus.c,
2251 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2252 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2253 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2254 unittests/array-view-selftests.c,
2255 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2256 unittests/common-utils-selftests.c,
2257 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2258 unittests/format_pieces-selftests.c,
2259 unittests/function-view-selftests.c,
2260 unittests/lookup_name_info-selftests.c,
2261 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2262 unittests/mkdir-recursive-selftests.c,
2263 unittests/observable-selftests.c,
2264 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2265 unittests/parse-connection-spec-selftests.c,
2266 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2267 unittests/scoped_fd-selftests.c,
2268 unittests/scoped_mmap-selftests.c,
2269 unittests/scoped_restore-selftests.c,
2270 unittests/string_view-selftests.c, unittests/style-selftests.c,
2271 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2272 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2273 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2274 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2275 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2276 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2278 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2280 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2282 (decode_digits_ordinary): Set explicit_line field in sal.
2283 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2284 symtab_and_line that was set on an explicit line number in
2285 assembler code. Do always update the recorded symtab and line if
2286 we do skip the prologue.
2288 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2290 * breakpoint.c (set_breakpoint_location_function): Remove
2291 explicit_loc parameter.
2292 (momentary_breakpoint_from_master): Update call to
2293 set_breakpoint_location_function.
2294 (add_location_to_breakpoint): Likewise.
2296 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2298 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2299 required features based on default bfd type when no specific bfd
2302 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2304 * NEWS: Mention that GDB printf and eval commands can now print
2305 C-style and Ada-style convenience var strings without
2306 calling the inferior.
2307 * printcmd.c (printf_c_string): Locally print GDB internal var
2308 instead of transiting via the inferior.
2309 (printf_wide_c_string): Likewise.
2311 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2313 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2315 2019-07-04 Tom Tromey <tom@tromey.com>
2318 * tui/tui-winsource.c (tui_clear_source_content): Update.
2319 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2320 (tui_update_breakpoint_info): Update.
2321 (tui_set_exec_info_content): Update.
2322 * tui/tui-source.c (tui_set_source_content_nil): Update.
2323 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2325 * tui/tui-data.h (enum tui_bp_flag): New.
2326 (tui_bp_flags): New enum flags type.
2327 (struct tui_source_element) <break_mode>: Change type. Rename
2329 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2330 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2332 * tui/tui-winsource.h: Fix comment.
2334 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2336 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2337 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2338 (store_fpregs_to_thread)
2339 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2340 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2341 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2342 (IWMMXT_REGS_SIZE): Add define.
2343 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2344 (fetch_vfp_regs, store_vfp_regs)
2345 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2346 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2348 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2350 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2352 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2353 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2354 (ARM_INT_REGISTER_SIZE): ...to this.
2355 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2356 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2357 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2358 (arm_linux_collect_gregset, supply_nwfpe_register)
2359 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2361 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2362 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2363 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2364 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2365 (arm_return_in_memory, arm_store_return_value)
2366 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2367 (arm_record_ld_st_multiple): Likewise.
2368 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2369 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2371 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2373 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2374 AARCH64_DISPLACED_MODIFIED_INSNS.
2375 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2376 (aarch64_displaced_step_copy_insn): Likewise.
2377 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2378 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2379 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2380 ARM_DISPLACED_MODIFIED_INSNS.
2381 * arm-tdep.c (arm_gdbarch_init): Likewise.
2382 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2383 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2384 (struct arm_displaced_step_closure): Use
2385 ARM_DISPLACED_MODIFIED_INSNS.
2387 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2389 * features/Makefile: Remove unused xml files.
2390 * features/aarch64.xml: Remove.
2391 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2392 * features/i386/amd64-avx-avx512.xml: Remove.
2393 * features/i386/amd64-avx-linux.xml: Remove.
2394 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2395 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2396 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2397 * features/i386/amd64-avx-mpx.xml: Remove.
2398 * features/i386/amd64-avx.xml: Remove.
2399 * features/i386/amd64-linux.xml: Remove.
2400 * features/i386/amd64-mpx-linux.xml: Remove.
2401 * features/i386/amd64-mpx.xml: Remove.
2402 * features/i386/amd64.xml: Remove.
2403 * features/i386/i386-avx-avx512-linux.xml: Remove.
2404 * features/i386/i386-avx-avx512.xml: Remove.
2405 * features/i386/i386-avx-linux.xml: Remove.
2406 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2407 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2408 * features/i386/i386-avx-mpx-linux.xml: Remove.
2409 * features/i386/i386-avx-mpx.xml: Remove.
2410 * features/i386/i386-avx.xml: Remove.
2411 * features/i386/i386-linux.xml: Remove.
2412 * features/i386/i386-mmx-linux.xml: Remove.
2413 * features/i386/i386-mmx.xml: Remove.
2414 * features/i386/i386-mpx-linux.xml: Remove.
2415 * features/i386/i386-mpx.xml: Remove.
2416 * features/i386/i386.xml: Remove.
2417 * features/i386/x32-avx-avx512-linux.xml: Remove.
2418 * features/i386/x32-avx-linux.xml: Remove.
2419 * features/i386/x32-linux.xml: Remove.
2421 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2423 * regformats/aarch64.dat: Remove.
2424 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2425 * regformats/i386/amd64-avx-linux.dat: Remove.
2426 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2427 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2428 * regformats/i386/amd64-linux.dat: Remove.
2429 * regformats/i386/amd64-mpx-linux.dat: Remove.
2430 * regformats/i386/amd64.dat: Remove.
2431 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2432 * regformats/i386/i386-avx-linux.dat: Remove.
2433 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2434 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2435 * regformats/i386/i386-linux.dat: Remove.
2436 * regformats/i386/i386-mmx-linux.dat: Remove.
2437 * regformats/i386/i386-mpx-linux.dat: Remove.
2438 * regformats/i386/i386.dat: Remove.
2439 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2440 * regformats/i386/x32-avx-linux.dat: Remove.
2441 * regformats/i386/x32-linux.dat: Remove.
2443 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2445 * aarch64-tdep.c: Remove xml self tests.
2446 * amd64-linux-tdep.c: Likewise.
2447 * amd64-tdep.c: Likewise.
2448 * i386-linux-tdep.c: Likewise.
2449 * i386-tdep.c: Likewise.
2451 2019-07-03 Pedro Alves <palves@redhat.com>
2454 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2455 (pipe_cmd_option_defs): New.
2456 (make_pipe_cmd_options_def_group): New.
2457 (pipe_command): Use gdb::option::process_options.
2458 (pipe_command_completer): New function.
2459 (_initialize_cli_cmds): Install completer for "pipe" command.
2461 2019-07-03 Pedro Alves <palves@redhat.com>
2463 * cli/cli-option.c (union option_value) <string>: New field.
2464 (struct option_def_and_value): Add ctor, move ctor, dtor and
2465 use DISABLE_COPY_AND_ASSIGN.
2466 (option_def_and_value::clear_value): New.
2467 (parse_option, save_option_value_in_ctx, get_val_type_str)
2468 (add_setshow_cmds_for_options): Handle var_string.
2469 * cli-option.h (union option_def::var_address) <string>: New
2471 (struct string_option_def): New.
2472 * maint-test-options.c (struct test_options_opts): Add default
2473 ctor and use DISABLE_COPY_AND_ASSIGN.
2474 <string_opt>: New field.
2475 (test_options_opts::~test_options_opts): New.
2476 (test_options_opts::dump): Also dump "-string".
2477 (test_options_option_defs): Install "string.
2479 2019-07-03 Pedro Alves <palves@redhat.com>
2481 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2482 option_value with a null enumeration.
2483 (complete_options): Save the option values in the context.
2484 (save_option_value_in_ctx): New, factored out from ...
2485 (process_options): ... here.
2486 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2488 * maint-test-options.c (test_options_opts::dump): New, factored
2490 (maintenance_test_options_command_mode): ... here.
2491 (maintenance_test_options_command_completion_result): Delete.
2492 (maintenance_test_options_command_completion_text): Update
2494 (maintenance_show_test_options_completion_result): Change
2495 prototype. Just print
2496 maintenance_test_options_command_completion_text.
2497 (save_completion_result): New.
2498 (maintenance_test_options_completer_mode): Pass options context to
2499 complete_options, and then save a dump.
2500 (_initialize_maint_test_options): Use add_cmd to install "maint
2501 show test-options-completion-result".
2503 2019-07-03 Pedro Alves <palves@redhat.com>
2505 * NEWS (New commands): Mention "with" and "maint with".
2506 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2507 (with_command, with_command_completer): New.
2508 (pipe_command): Adjust to new repeat_previous
2510 (_initialize_cli_cmds): Install the "with" command and its "w"
2512 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2514 * cli/cli-setshow.c (parse_cli_var_uinteger)
2515 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2516 argument strings for all var_types.
2517 (get_setshow_command_value_string): New, factored out from ...
2518 (do_show_command): ... this.
2519 * cli/cli-setshow.h: Include <string>.
2520 (get_setshow_command_value_string): Declare.
2521 * command.h (repeat_previous): Now returns const char *. Adjust
2523 * maint.c: Include "cli/cli-cmds.h".
2524 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2525 (_initialize_maint_cmds): Register the "maintenance with" command.
2526 * top.c (repeat_previous): Move bits from pipe_command here:
2527 Return the saved command line, if any; error out if there's no
2528 command to relaunch.
2530 2019-07-03 Pedro Alves <palves@redhat.com>
2532 * NEWS (New commands): Mention "maint set/show test-settings"
2533 instead of "maint test-settings".
2534 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2535 (maintenance_test_settings_set_list): Rename to ...
2536 (maintenance_set_test_settings_list): ... this.
2537 (maintenance_test_settings_show_list): Rename to ...
2538 (maintenance_show_test_settings_list): ... this.
2539 (maintenance_test_settings_cmd): Delete.
2540 (maintenance_test_settings_set_cmd): ...
2541 (maintenance_set_test_settings_cmd): ... this.
2542 (maintenance_test_settings_show_cmd): ...
2543 (maintenance_show_test_settings_cmd): ... this.
2544 (maintenance_test_settings_show_value_cmd):
2545 (maintenance_show_test_settings_value_cmd): ... this.
2546 (_initialize_maint_test_settings): No longer install the "maint
2547 test-settings" prefix command. Rename "maint test-settings set"
2548 to "maint set test-settings", and "maint test-settings show" to
2549 "maint show test-settings". Adjust all subcommands.
2551 2019-07-03 Pedro Alves <palves@redhat.com>
2553 * maint-test-settings.c: Fix file's intro comment. Replace all
2554 references to "test-options" with references to "test-settings",
2557 2019-07-03 Pedro Alves <palves@redhat.com>
2559 * maint-test-settings.c (maintenance_test_settings_xxx)
2560 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2562 (maintenance_test_settings_enums): Use them.
2563 (maintenance_test_settings_enum): Default to
2564 maintenance_test_settings_xxx.
2565 (_initialize_maint_test_settings): Initialize
2566 MAINTENANCE_TEST_SETTINGS_FILENAME.
2568 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2570 * breakpoint.h (remove_breakpoints_inf): Change return type to
2571 void, move function documentation here.
2572 * breakpoint.c (remove_breakpoints_inf): Change return type to
2573 void, move function documentation to header.
2575 2019-07-02 Pedro Alves <palves@redhat.com>
2577 * NEWS (Completion improvements): Mention "info threads".
2578 * thread.c (struct info_threads_opts, info_threads_option_defs)
2579 (make_info_threads_options_def_group): New.
2580 (info_threads_command): Use gdb::option::process_options.
2581 (info_threads_command_completer): New.
2582 (_initialize_thread): Use gdb::option::build_help to build the
2583 help text for "info threads".
2585 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2587 * defs.h (generic_load): Move from here...
2588 * symfile.h (generic_load): ... to here. Rename name parameter
2590 * symfile.c (generic_load): Add comment.
2592 2019-07-01 Tom Tromey <tromey@adacore.com>
2595 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2596 declaration of without_params. Fix formatting.
2598 2019-07-01 Tom Tromey <tromey@adacore.com>
2600 * ada-exp.y (find_primitive_type): Update.
2601 * ada-lang.h (ada_lookup_symbol): Update.
2602 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2604 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2606 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2608 PR breakpoints/24541
2609 * gdbarch.c: Regenerate.
2610 * gdbarch.h: Regenerate.
2611 * gdbarch.sh: Add 'stap_adjust_register'.
2612 * i386-tdep.c: Include '<unordered_set>'.
2613 (i386_stap_adjust_register): New function.
2614 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2615 * stap-probe.c (stap_parse_register_operand): Call
2616 'gdbarch_stap_adjust_register'.
2618 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2621 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2622 * python/python.c (do_start_initialization): Use 'xmalloc'
2623 instead of 'PyMem_Malloc'.
2625 2019-06-28 Tom Tromey <tromey@adacore.com>
2627 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2630 2019-06-27 Tom Tromey <tromey@adacore.com>
2632 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2634 (arm_find_mapping_symbol, arm_record_special_symbol)
2635 (_initialize_arm_tdep): Update.
2636 (arm_objfile_data_free): Remove.
2638 2019-06-27 Tom Tromey <tromey@adacore.com>
2640 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2641 to cp_print_static_field.
2643 2019-06-26 Tom Tromey <tromey@adacore.com>
2645 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2646 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2649 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2651 * features/aarch64-core.c (create_feature_aarch64_core):
2653 * features/aarch64-core.xml: Add cpsr flags.
2655 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2657 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2658 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2660 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2662 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2664 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2666 (arm_record_special_symbol): Don't insert new symbol in sorted
2667 position, push it at the end.
2669 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2671 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2672 (arm_mapping_symbol_s): Remove.
2673 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2674 (arm_mapping_symbol_vec): New typedef.
2675 (struct arm_per_objfile): Add constructor.
2676 <section_maps>: Change type to
2677 std::unique_ptr<arm_mapping_symbol_vec[]>.
2678 (arm_compare_mapping_symbols): Remove.
2679 (arm_find_mapping_symbol): Adjust to section_maps type change.
2680 (arm_objfile_data_free): Call delete on arm_per_objfile.
2681 (arm_record_special_symbol): Adjust to section_maps type change.
2682 Allocate arm_per_objfile with new.
2684 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2686 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2687 with the command prefix.
2689 2019-06-25 Tom Tromey <tom@tromey.com>
2691 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2692 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2694 2019-06-25 Tom Tromey <tom@tromey.com>
2696 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2698 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2701 2019-06-25 Tom Tromey <tom@tromey.com>
2703 * tui/tui-winsource.c
2704 (tui_source_window_base::set_is_exec_point_at): Add check against
2707 2019-06-25 Tom Tromey <tom@tromey.com>
2709 * tui/tui-source.c (tui_set_source_content): Don't check before
2711 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2713 2019-06-25 Tom Tromey <tom@tromey.com>
2715 * tui/tui-winsource.h (tui_update_source_window_as_is)
2716 (tui_alloc_source_buffer, tui_line_is_displayed)
2717 (tui_addr_is_displayed): Change type of win_info.
2718 * tui/tui-winsource.c (tui_update_source_window_as_is)
2719 (tui_clear_source_content, tui_show_source_line)
2720 (tui_show_source_content, tui_source_window_base::refill)
2721 (tui_source_window_base::set_is_exec_point_at)
2722 (tui_source_window_base::set_is_exec_point_at)
2723 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2724 (tui_alloc_source_buffer, tui_line_is_displayed)
2725 (tui_addr_is_displayed): Change type of win_info. Update.
2726 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2727 (tui_source_window_base::do_make_visible_with_new_height):
2729 * tui/tui-source.c (tui_set_source_content)
2730 (tui_set_source_content_nil)
2731 (tui_source_window::do_scroll_vertical): Update.
2732 * tui/tui-layout.c (show_layout): Update.
2733 * tui/tui-disasm.c (tui_set_disassem_content)
2734 (tui_disasm_window::do_scroll_vertical): Update.
2735 * tui/tui-data.h (tui_win_content): Remove.
2736 (struct tui_gen_win_info) <content, content_size>: Remove.
2737 (struct tui_source_element): Add initializers and destructor.
2738 (union tui_which_element, struct tui_win_element): Remove.
2739 (struct tui_source_window_base) <content>: New field.
2740 (struct tui_data_window): Remove destructor.
2741 (tui_alloc_content, tui_free_win_content)
2742 (tui_free_all_source_wins_content): Don't declare.
2743 * tui/tui-data.c (tui_initialize_static_data): Update.
2744 (init_content_element, tui_alloc_content): Remove.
2745 (~tui_gen_win_info): Update.
2746 (~tui_data_window, tui_free_all_source_wins_content)
2747 (tui_free_win_content, free_content, free_content_elements):
2750 2019-06-25 Tom Tromey <tom@tromey.com>
2752 * tui/tui-winsource.h (tui_clear_source_content)
2753 (tui_erase_source_content, tui_show_source_content): Change type
2755 * tui/tui-winsource.c (tui_clear_source_content)
2756 (tui_erase_source_content, tui_show_source_content): Change type
2758 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2759 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2761 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2763 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2765 2019-06-25 Tom Tromey <tom@tromey.com>
2767 * tui/tui-winsource.c (tui_clear_source_content)
2768 (tui_source_window_base::set_is_exec_point_at): Update.
2769 * tui/tui-source.c (tui_set_source_content_nil): Update.
2770 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2772 * tui/tui-data.c (init_content_element): Update.
2774 2019-06-25 Tom Tromey <tom@tromey.com>
2776 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2777 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2778 * tui/tui-layout.c (init_and_make_win): Update.
2779 * tui/tui.h (enum tui_win_type): Update.
2780 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2781 tui_win_is_auxillary.
2782 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2783 tui_win_is_auxillary.
2785 2019-06-25 Tom Tromey <tom@tromey.com>
2787 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2788 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2789 (tui_delete_data_content_windows, tui_display_all_data)
2790 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2792 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2793 * tui/tui-regs.c (tui_last_regs_line_no)
2794 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2795 (tui_show_registers): Update.
2796 (tui_show_register_group): Return void. Update.
2797 (tui_display_registers_from, tui_display_reg_element_at_line)
2798 (tui_display_registers_from_line, tui_check_register_values):
2800 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2802 (struct tui_data_window) <regs_content>: Now a std::vector.
2803 <regs_content_count>: Remove.
2804 (tui_add_content_elements, tui_free_data_content): Don't declare.
2805 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2806 (init_content_element): Remove DATA_WIN case. Add assert.
2807 (tui_add_content_elements): Remove.
2808 (tui_data_window): Update.
2809 (tui_free_data_content): Remove.
2810 (free_content_elements): Remove DATA_WIN case.
2812 2019-06-25 Tom Tromey <tom@tromey.com>
2814 * tui/tui-data.c (tui_data_item_window): Update.
2815 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2816 * tui/tui-windata.c (tui_display_all_data)
2817 (tui_display_data_from_line): Update.
2818 (tui_check_data_values): Remove.
2819 * tui/tui-regs.c (tui_show_register_group)
2820 (tui_display_reg_element_at_line): Update.
2821 * tui/tui-hooks.c (tui_register_changed)
2822 (tui_refresh_frame_and_register_information): Call
2823 tui_check_register_values.
2824 * tui/tui-data.h (struct tui_data_window) <data_content,
2825 data_content_count, data_type>: Remove.
2826 (enum tui_data_type): Remove.
2828 * tui/tui-data.c (tui_data_window::clear_detail)
2829 (~tui_data_window): Update.
2831 2019-06-25 Tom Tromey <tom@tromey.com>
2833 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2835 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2836 Rename from tui_first_data_item_displayed. Update.
2837 (tui_data_window::refresh_all)
2838 (tui_data_window::do_scroll_vertical): Update.
2839 * tui/tui-data.h (struct tui_data_window)
2840 <first_data_item_displayed>: Declare new method.
2842 2019-06-25 Tom Tromey <tom@tromey.com>
2844 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2845 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2847 (tui_initialize_static_data): ...here.
2849 2019-06-25 Tom Tromey <tom@tromey.com>
2851 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2852 (tui_display_registers_from, tui_check_register_values): Update.
2853 (tui_display_register): Remove win_info parameter; update.
2854 (tui_get_register): Change type of parameters.
2855 * tui/tui-data.h (struct tui_data_element): Remove.
2856 (union tui_which_element) <data>: Remove.
2857 <data_window>: Change type.
2858 (struct tui_data_item_window): New.
2859 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2861 (~tui_data_item_window): New destructor.
2862 (free_content_elements): Remove DATA_ITEM_WIN case.
2864 2019-06-25 Tom Tromey <tom@tromey.com>
2866 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2869 2019-06-25 Tom Tromey <tom@tromey.com>
2871 * tui/tui-data.h (struct tui_command_element): Remove.
2872 (union tui_which_element) <command>: Remove.
2873 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2875 (free_content_elements): Remove CMD_WIN case.
2877 2019-06-25 Tom Tromey <tom@tromey.com>
2879 * tui/tui-layout.c (tui_set_layout): Update.
2880 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2881 * tui/tui-data.c (layout_def): Update.
2883 2019-06-25 Tom Tromey <tom@tromey.com>
2885 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2886 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2887 (tui_source_window_base::set_new_height): Update.
2888 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2890 (tui_set_locator_fullname, tui_set_locator_info)
2891 (tui_show_frame_info): Update.
2892 * tui/tui-source.c (tui_set_source_content)
2893 (tui_source_is_displayed): Update.
2894 * tui/tui-layout.c (show_source_disasm_command, show_data)
2895 (show_source_or_disasm_and_command): Update.
2896 * tui/tui-disasm.c (tui_set_disassem_content)
2897 (tui_get_begin_asm_address): Update.
2898 * tui/tui-data.h (struct tui_locator_element): Remove.
2899 (union tui_which_element) <locator>: Remove.
2900 (struct tui_locator_window): New.
2901 (tui_locator_win_info_ptr): Change return type.
2902 * tui/tui-data.c (_locator): Change type.
2903 (tui_locator_win_info_ptr): Change return type.
2904 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2905 (tui_alloc_content): Add assert.
2907 2019-06-25 Tom Tromey <tom@tromey.com>
2909 * tui/tui-winsource.c
2910 (tui_exec_info_window::maybe_allocate_content): New method.
2911 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2912 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2913 (make_source_or_disasm_window): Add cast.
2914 * tui/tui-data.h (union tui_which_element) <simple_string>:
2916 (struct tui_source_info): New.
2917 (struct tui_source_window_base) <execution_info>: Change type.
2918 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2919 case, and add assert.
2920 (tui_alloc_content): Add assert.
2922 2019-06-25 Tom Tromey <tom@tromey.com>
2924 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2925 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2926 * tui/tui-data.c (tui_alloc_win_info): Remove.
2928 2019-06-25 Tom Tromey <tom@tromey.com>
2930 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2931 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2934 2019-06-25 Tom Tromey <tom@tromey.com>
2936 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2937 make_visible_with_new_height method.
2938 (tui_win_info::make_visible_with_new_height): New method.
2939 (tui_source_window_base::do_make_visible_with_new_height)
2940 (tui_data_window::do_make_visible_with_new_height)
2941 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2942 (make_visible_with_new_height): Remove.
2943 (tui_resize_all, tui_adjust_win_heights): Use
2944 make_visible_with_new_height method.
2945 * tui/tui-data.h (struct tui_win_info)
2946 <do_make_visible_with_new_height, make_visible_with_new_height>:
2948 (struct tui_source_window_base, struct tui_data_window)
2949 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2952 2019-06-25 Tom Tromey <tom@tromey.com>
2954 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2956 (update_tab_width): Call update_tab_width method.
2957 * tui/tui-data.h (struct tui_win_info)
2958 (struct tui_source_window_base) <update_tab_width>: New methods.
2960 2019-06-25 Tom Tromey <tom@tromey.com>
2962 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2964 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2966 (tui_gen_win_info::make_visible): Update.
2967 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2969 * tui/tui-data.h (enum tui_box): New enum.
2970 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2972 2019-06-25 Tom Tromey <tom@tromey.com>
2974 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2975 init_and_make_win for EXEC_INFO_WIN.
2976 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2978 (struct tui_win_info) <~tui_win_info>: Inline.
2979 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2981 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2982 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2984 (tui_initialize_static_data): Update.
2985 (~tui_gen_win_info): Handle more cleanup here.
2986 (~tui_source_window_base): Delete "execution_info".
2987 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2989 2019-06-25 Tom Tromey <tom@tromey.com>
2991 * tui/tui-layout.c (make_command_window): Don't set
2993 (show_source_disasm_command): Call the reset method.
2994 (show_data): Don't set can_highlight. Call the reset method.
2995 (tui_gen_win_info::reset): Rename from init_gen_win_info
2996 (init_and_make_win): Simplify. Return tui_gen_win_info.
2997 (show_source_or_disasm_and_command): Call the reset method.
2998 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2999 (struct tui_cmd_window): Set can_highlight.
3001 2019-06-25 Tom Tromey <tom@tromey.com>
3003 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3005 (tui_make_visible, tui_make_invisible): Rewrite.
3006 (tui_win_info::make_visible): Remove.
3007 (tui_source_window_base::make_visible): Update.
3008 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3009 method. Moved from...
3010 (struct tui_win_info) <make_visible>: ...here.
3012 2019-06-25 Tom Tromey <tom@tromey.com>
3014 * tui/tui-winsource.c
3015 (tui_source_window_base::do_scroll_horizontal): Remove direction
3017 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3018 direction parameter.
3019 * tui/tui-win.c (tui_win_info::forward_scroll)
3020 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3021 (tui_win_info::right_scroll): Update.
3022 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3023 direction parameter.
3024 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3025 direction parameter.
3026 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3027 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3028 Remove direction parameter.
3029 (struct tui_source_window_base, struct tui_source_window)
3030 (struct tui_disasm_window, struct tui_data_window)
3031 (struct tui_cmd_window): Update.
3033 2019-06-25 Tom Tromey <tom@tromey.com>
3035 * tui/tui-winsource.h (tui_set_exec_info_content)
3036 (tui_show_exec_info_content, tui_erase_exec_info_content)
3037 (tui_clear_exec_info_content, tui_update_exec_info): Change
3038 argument to tui_source_window_base.
3039 * tui/tui-winsource.c (tui_set_exec_info_content)
3040 (tui_show_exec_info_content, tui_erase_exec_info_content)
3041 (tui_clear_exec_info_content, tui_update_exec_info): Change
3042 argument to tui_source_window_base.
3044 2019-06-25 Tom Tromey <tom@tromey.com>
3046 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3047 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3049 2019-06-25 Tom Tromey <tom@tromey.com>
3051 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3054 2019-06-25 Tom Tromey <tom@tromey.com>
3056 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3058 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3060 * tui/tui-source.c (tui_set_source_content): Update.
3061 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3063 2019-06-25 Tom Tromey <tom@tromey.com>
3065 * tui/tui-win.c (window_name_completer, tui_set_focus)
3066 (tui_all_windows_info): Use name method.
3067 * tui/tui-data.h (struct tui_gen_win_info)
3068 (struct tui_source_window, struct tui_disasm_window)
3069 (struct tui_data_window, struct tui_cmd_window) <name>: New
3071 (tui_win_name): Don't declare.
3072 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3073 (tui_win_name): Remove.
3075 2019-06-25 Tom Tromey <tom@tromey.com>
3077 * tui/tui-winsource.h (tui_update_source_window)
3078 (tui_update_source_window_as_is): Change parameter type.
3079 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3080 to be a tui_source_window_base.
3081 (tui_update_source_window_as_is): Likewise.
3082 * tui/tui-win.c (make_visible_with_new_height): Update.
3084 2019-06-25 Tom Tromey <tom@tromey.com>
3086 * tui/tui-winsource.c (tui_erase_source_content)
3087 (tui_show_source_content, tui_show_exec_info_content)
3088 (tui_erase_exec_info_content): Use refresh_window method.
3089 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3090 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3091 from tui_refresh_win.
3092 (tui_data_window::refresh_window): New method.
3093 (tui_win_info::refresh, tui_source_window_base::refresh)
3094 (tui_refresh_all): Use refresh_window method.
3095 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3097 * tui/tui-regs.c (tui_display_register): Call refresh_window
3099 * tui/tui-layout.c (show_source_disasm_command)
3100 (show_source_or_disasm_and_command): Call refresh_window method.
3101 * tui/tui-data.h (struct tui_gen_win_info)
3102 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3105 2019-06-25 Tom Tromey <tom@tromey.com>
3107 * tui/tui.c (tui_rl_other_window, tui_enable)
3108 (tui_is_window_visible, tui_get_command_dimension): Update.
3109 * tui/tui-winsource.c (tui_update_source_window_as_is)
3110 (tui_clear_source_content, tui_erase_source_content)
3111 (tui_show_source_line, tui_source_window_base::refill)
3112 (tui_source_window_base::do_scroll_horizontal)
3113 (tui_source_window_base::set_is_exec_point_at)
3114 (tui_update_breakpoint_info, tui_set_exec_info_content)
3115 (tui_alloc_source_buffer, tui_line_is_displayed)
3116 (tui_addr_is_displayed): Update.
3117 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3118 (tui_check_and_display_highlight_if_needed)
3119 (tui_win_info::make_visible, tui_win_info::refresh)
3120 (tui_refresh_all): Update.
3121 * tui/tui-windata.c (tui_first_data_item_displayed)
3122 (tui_delete_data_content_windows, tui_erase_data_content)
3123 (tui_display_all_data, tui_data_window::refresh_all)
3124 (tui_check_data_values): Update.
3125 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3126 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3127 (tui_win_info::backward_scroll, tui_refresh_all_win)
3128 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3129 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3130 (tui_source_window_base::set_new_height)
3131 (tui_data_window::set_new_height)
3132 (make_invisible_and_set_new_height)
3133 (make_visible_with_new_height, new_height_ok)
3134 (parse_scrolling_args): Update.
3135 * tui/tui-stack.c (tui_show_frame_info): Update.
3136 * tui/tui-source.c (tui_set_source_content)
3137 (tui_set_source_content_nil, tui_source_is_displayed)
3138 (tui_source_window::do_scroll_vertical): Update.
3139 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3140 (tui_display_registers_from, tui_display_reg_element_at_line)
3141 (tui_check_register_values, tui_reg_command): Update.
3142 * tui/tui-layout.c (tui_default_win_height)
3143 (show_source_disasm_command, show_data, init_and_make_win)
3144 (show_source_or_disasm_and_command): Update.
3145 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3146 (tui_redisplay_readline, tui_mld_flush)
3147 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3149 * tui/tui-disasm.c (tui_set_disassem_content)
3150 (tui_disasm_window::do_scroll_vertical): Update.
3151 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3153 (struct tui_win_info): Derive from tui_gen_win_info.
3154 <~tui_win_info>: Mark as override.
3155 <generic>: Remove member.
3156 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3157 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3158 (~tui_data_window, ~tui_win_info)
3159 (tui_free_all_source_wins_content): Update.
3160 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3162 2019-06-25 Tom Tromey <tom@tromey.com>
3164 * tui/tui-layout.c (init_and_make_win): Use new.
3165 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3166 destructor, initializers.
3167 (tui_alloc_generic_win_info): Don't declare.
3168 * tui/tui-data.c (_locator): Add argument to constructor.
3169 (source_win, disasm_win): New globals.
3170 (exec_info): Remove.
3171 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3173 (tui_alloc_generic_win_info): Remove.
3174 (init_content_element): Use new.
3175 (tui_win_info::tui_win_info): Update.
3176 (free_content_elements) <case DATA_WIN>: Use delete.
3178 2019-06-25 Tom Tromey <tom@tromey.com>
3180 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3181 * tui/tui-windata.c (tui_first_data_item_displayed)
3182 (tui_delete_data_content_windows): Update.
3183 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3184 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3185 (tui_display_registers_from, tui_check_register_values): Update.
3186 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3188 * tui/tui-data.c (init_content_element): Update. Allocate the new
3190 (tui_free_data_content): Update.
3191 (free_content_elements) <case DATA_WIN>: Free the window.
3193 2019-06-25 Tom Tromey <tom@tromey.com>
3195 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3197 * tui/tui-layout.c (make_command_window)
3198 (show_source_disasm_command, show_data, init_and_make_win)
3199 (show_source_or_disasm_and_command): Update.
3200 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3202 <can_highight, is_highlighted>: Now bool.
3203 (tui_set_win_highlight): Don't declare.
3204 * tui/tui-data.c (tui_set_win_highlight): Remove.
3206 2019-06-25 Tom Tromey <tom@tromey.com>
3208 * tui/tui-wingeneral.c (make_visible): Remove check of window
3211 2019-06-25 Tom Tromey <tom@tromey.com>
3213 * tui/tui-win.c (tui_win_info::max_height)
3214 (tui_cmd_window::max_height): New methods.
3215 (new_height_ok): Call max_height.
3216 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3217 <max_height>: New method.
3219 2019-06-25 Tom Tromey <tom@tromey.com>
3221 * tui/tui-win.c (tui_source_window_base::set_new_height)
3222 (tui_data_window::set_new_height): New methods.
3223 (make_invisible_and_set_new_height): Call set_new_height method.
3224 * tui/tui-data.h (struct tui_win_info)
3225 (struct tui_source_window_base, struct tui_data_window)
3226 <set_new_height>: New method.
3228 2019-06-25 Tom Tromey <tom@tromey.com>
3230 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3231 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3232 tui_refresh_data_win.
3233 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3235 (tui_refresh_all_win): Call the refresh_all method.
3236 (tui_set_focus): Likewise.
3237 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3238 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3241 2019-06-25 Tom Tromey <tom@tromey.com>
3243 * tui/tui-winsource.h (tui_refill_source_window)
3244 (tui_set_is_exec_point_at): Don't declare.
3245 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3246 (tui_source_window_base::refill): Rename from
3247 tui_refill_source_window.
3248 (tui_source_window_base::do_scroll_horizontal): Update.
3249 (tui_source_window_base::set_is_exec_point_at): Rename from
3250 tui_set_is_exec_point_at.
3251 (tui_update_all_breakpoint_info): Update.
3252 * tui/tui-stack.c (tui_show_frame_info): Update.
3253 * tui/tui-layout.c (show_data): Add cast.
3254 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3255 * tui/tui-data.h (struct tui_source_window_base) <refill,
3256 set_is_exec_point_at>: New methods.
3257 (tui_source_windows, tui_add_to_source_windows): Update types.
3258 (tui_add_to_source_windows): Remove redundant declaration.
3259 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3260 (tui_source_windows): Change return type.
3261 (tui_clear_source_windows_detail): Update.
3262 (tui_add_to_source_windows): Change type of parameter.
3263 (tui_free_all_source_wins_content): Update.
3265 2019-06-25 Tom Tromey <tom@tromey.com>
3267 * tui/tui-wingeneral.c (tui_win_info::refresh)
3268 (tui_source_window_base::refresh): New methods.
3269 (tui_refresh_all): Call the refresh method.
3270 * tui/tui-data.h (struct tui_win_info)
3271 (struct tui_source_window_base) <refresh>: New method.
3273 2019-06-25 Tom Tromey <tom@tromey.com>
3275 * tui/tui.h (tui_is_window_visible): Return bool.
3276 * tui/tui.c (tui_is_window_visible): Return bool.
3277 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3278 (tui_make_visible, tui_make_invisible)
3279 (tui_win_info::make_visible)
3280 (tui_source_window_base::make_visible, make_all_visible)
3281 (tui_make_all_visible, tui_make_all_invisible): Update.
3282 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3283 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3285 (struct tui_win_info, struct tui_source_window_base)
3286 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3287 * tui/tui-data.c (tui_init_generic_part): Update.
3289 2019-06-25 Tom Tromey <tom@tromey.com>
3291 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3292 (tui_source_window_base::make_visible): New methods.
3293 (make_all_visible): Make method call.
3294 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3295 (struct tui_source_window_base, struct tui_cmd_window): Override
3297 (tui_win_is_source_type): Don't declare.
3298 * tui/tui-data.c (tui_win_is_source_type): Remove.
3300 2019-06-25 Tom Tromey <tom@tromey.com>
3302 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3305 2019-06-25 Tom Tromey <tom@tromey.com>
3307 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3308 Inline constructor. Add initializers for members.
3309 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3310 constructors; now inline in class.
3312 2019-06-25 Tom Tromey <tom@tromey.com>
3314 * tui/tui-regs.c (tui_show_registers): Update.
3315 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3317 * tui/tui-data.c (tui_data_window::clear_detail)
3318 (tui_data_window): Update.
3320 2019-06-25 Tom Tromey <tom@tromey.com>
3322 * tui/tui-windata.c (tui_display_all_data)
3323 (tui_display_data_from_line, tui_display_data_from)
3324 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3326 * tui/tui-regs.c (tui_last_regs_line_no)
3327 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3328 (tui_show_registers, tui_show_register_group)
3329 (tui_display_registers_from, tui_display_reg_element_at_line)
3330 (tui_display_registers_from_line, tui_check_register_values)
3331 (tui_reg_next, tui_reg_prev): Update.
3332 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3333 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3335 (struct tui_win_info) <detail>: Remove. Add new fields from
3337 (TUI_DATA_WIN): Add cast.
3338 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3339 (~tui_data_window): Simplify.
3341 2019-06-25 Tom Tromey <tom@tromey.com>
3343 * tui/tui-layout.c (show_source_disasm_command)
3344 (show_source_or_disasm_and_command): Update.
3345 * tui/tui-io.c (update_cmdwin_start_line)
3346 (tui_redisplay_readline): Update.
3347 * tui/tui-data.h (struct tui_command_info): Remove.
3348 (struct tui_win_info) <detail>: Remove command_info member.
3349 (struct tui_data_window) <start_line>: New member, from
3351 (TUI_CMD_WIN): Add casts.
3353 2019-06-25 Tom Tromey <tom@tromey.com>
3355 * tui/tui-winsource.c (tui_update_source_window)
3356 (tui_refill_source_window)
3357 (tui_source_window_base::do_scroll_horizontal)
3358 (tui_update_breakpoint_info, tui_set_exec_info_content)
3359 (tui_show_exec_info_content, tui_erase_exec_info_content)
3360 (tui_clear_exec_info_content): Update.
3361 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3363 * tui/tui-win.c (make_invisible_and_set_new_height)
3364 (make_visible_with_new_height): Update.
3365 * tui/tui-source.c (tui_set_source_content)
3366 (tui_show_symtab_source): Update.
3367 * tui/tui-layout.c (extract_display_start_addr)
3368 (show_source_disasm_command, show_data)
3369 (make_source_or_disasm_window)
3370 (show_source_or_disasm_and_command): Update.
3371 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3372 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3374 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3375 to tui_source_window_base.
3376 (struct tui_win_info) <detail>: Remove source_info member.
3377 (struct tui_source_window_base) <has_locator>: Inline.
3378 Move contents from tui_source_info; rename has_locator member to
3380 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3381 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3383 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3385 (tui_free_all_source_wins_content): Cast to
3386 tui_source_window_base.
3388 2019-06-25 Tom Tromey <tom@tromey.com>
3390 * tui/tui-win.c (make_invisible_and_set_new_height)
3391 (make_visible_with_new_height): Call has_locator method.
3392 * tui/tui-layout.c (show_source_disasm_command, show_data)
3393 (show_source_or_disasm_and_command): Update for bool change.
3394 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3395 (tui_win_info) <has_locator>: New method.
3396 (struct tui_source_window_base) <has_locator>: New method.
3397 (tui_win_has_locator): Don't declare.
3398 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3399 from tui_win_has_locator.
3400 (tui_source_window_base): Use false, not FALSE.
3402 2019-06-25 Tom Tromey <tom@tromey.com>
3404 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3405 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3406 clear_detail method directly.
3407 (tui_clear_win_detail): Remove.
3409 2019-06-25 Tom Tromey <tom@tromey.com>
3411 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3412 "this", not TUI_DISASM_WIN.
3414 2019-06-25 Tom Tromey <tom@tromey.com>
3416 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3418 * tui/tui-winsource.c
3419 (tui_source_window_base::do_scroll_horizontal): Rename from
3420 tui_horizontal_source_scroll.
3421 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3422 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3423 from tui_vertical_data_scroll.
3424 * tui/tui-win.h (tui_scroll): Don't declare.
3425 * tui/tui-win.c (tui_win_info::forward_scroll)
3426 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3427 (tui_win_info::right_scroll): Rename and update.
3428 (tui_scroll_forward_command, tui_scroll_backward_command)
3429 (tui_scroll_left_command, tui_scroll_right_command): Update.
3430 (tui_scroll): Remove.
3431 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3432 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3433 from tui_vertical_source_scroll.
3434 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3435 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3436 from tui_vertical_disassem_scroll.
3437 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3438 do_scroll_horizontal>: New methods.
3439 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3441 (struct tui_source_window_base): Add do_scroll_horizontal.
3442 (struct tui_source_window, struct tui_disasm_window): Add
3444 (struct tui_data_window, struct tui_cmd_window): Add
3445 do_scroll_horizontal and do_scroll_vertical.
3446 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3448 2019-06-25 Tom Tromey <tom@tromey.com>
3450 * tui/tui-data.h (struct tui_source_window_base): New struct.
3451 (struct tui_source_window): Derive from tui_source_window_base.
3452 (struct tui_disasm_window): New struct.
3453 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3454 from tui_source_window::clear_detail.
3455 (tui_source_window_base): Rename from tui_source_window.
3456 (~tui_source_window_base): Rename from ~tui_source_window.
3457 (tui_alloc_win_info): Create a tui_disasm_window.
3459 2019-06-25 Tom Tromey <tom@tromey.com>
3461 * tui/tui-data.h (struct tui_source_window)
3462 (struct tui_data_window): Declare destructors.
3463 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3465 (tui_win_info): Simplify.
3467 2019-06-25 Tom Tromey <tom@tromey.com>
3469 * tui/tui-winsource.c (tui_display_main)
3470 (tui_update_source_windows_with_addr)
3471 (tui_update_all_breakpoint_info): Update.
3472 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3473 (new_height_ok, parse_scrolling_args): Update.
3474 * tui/tui-stack.c (tui_show_frame_info): Update.
3475 * tui/tui-data.h (struct tui_list): Remove.
3476 (tui_source_windows): Return a reference to a std::vector.
3477 * tui/tui-data.c (source_windows): Now a std::vector.
3478 (tui_source_windows): Change return type.
3479 (tui_clear_source_windows): Rewrite.
3480 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3481 (tui_free_all_source_wins_content): Rewrite.
3483 2019-06-25 Tom Tromey <tom@tromey.com>
3485 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3486 (struct tui_data_window, struct tui_cmd_window): Declare
3487 clear_detail method.
3488 * tui/tui-data.c (tui_source_window::clear_detail)
3489 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3491 (tui_clear_win_detail): Simplify.
3493 2019-06-25 Tom Tromey <tom@tromey.com>
3495 * tui/tui-layout.c (make_source_window, make_disasm_window)
3496 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3497 Return the new window.
3498 (show_source_disasm_command, show_data)
3499 (show_source_or_disasm_and_command): Update.
3501 2019-06-25 Tom Tromey <tom@tromey.com>
3503 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3504 parameter. Return the new window.
3505 (show_source_disasm_command): Update and remove NULL check.
3506 (show_source_or_disasm_and_command): Update.
3508 2019-06-25 Tom Tromey <tom@tromey.com>
3510 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3512 2019-06-25 Tom Tromey <tom@tromey.com>
3514 * tui/tui-data.h (struct tui_win_info): Make constructor
3515 protected. Make destructor virtual. Add initializers.
3516 (tui_source_window, tui_data_window, tui_cmd_window): New
3518 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3519 constructor. Add "type" parameter.
3520 (tui_source_window, tui_data_window, tui_cmd_window): New
3522 (tui_alloc_win_info): Instantiate the appropriate subclass.
3524 2019-06-25 Tom Tromey <tom@tromey.com>
3526 * tui/tui-win.c (tui_resize_all): Use delete.
3527 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3529 (tui_free_window): Don't declare.
3530 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3533 2019-06-25 Tom Tromey <tom@tromey.com>
3535 * tui/tui-data.h (struct tui_win_info): Add constructor.
3536 * tui/tui-data.c (tui_alloc_win_info): Use new.
3537 (tui_free_window): Use delete.
3539 2019-06-22 Tom Tromey <tom@tromey.com>
3541 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3543 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3545 2019-06-22 Tom Tromey <tom@tromey.com>
3547 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3549 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3551 2019-06-22 Tom de Vries <tdevries@suse.de>
3553 * dwarf2read.c (create_addrmap_from_aranges)
3554 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3557 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
3559 * dwarf2read.h (dwarf2_section_info_def): Remove.
3560 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3561 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3562 std::vector<dwarf2_section_info>.
3563 (struct dwo_file) <~dwo_file>: Remove.
3564 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3566 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3567 (dwarf2_read_debug_names): Likewise.
3568 (create_debug_types_hash_table): Change parameter type to
3569 array_view, adjust code accordingly.
3570 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3571 (partial_die_info::fixup): Likewise.
3572 (determine_prefix): Likewise.
3573 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3575 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3577 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3579 <~dwo_file>: Remove call to gdb_bfd_unref.
3580 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3581 gdb_bfd_ref_ptr::get.
3583 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3585 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3587 * dwarf2read.c (struct dwo_file): Initialize fields.
3589 (free_dwo_file): Remove, move content to ~dwo_file.
3590 (struct dwo_file_deleter): Remove.
3591 (dwo_file_up>: Remove custom deleter.
3592 (free_dwo_files): Remove.
3593 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3595 (process_skeletonless_type_units): Call unique_ptr::get.
3596 (allocate_dwo_file_hash_table): Add deleter to created hash
3597 table. Change return type to htab_up.
3598 (lookup_dwo_file_slot): Don't memset dwo_file, call
3600 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3601 (create_dwo_unit_in_dwp_v2): Likewise.
3602 (open_and_init_dwo_file): Likewise.
3603 (free_dwo_file_from_slot): Remove.
3605 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3607 * dwarf2read.h (struct dwarf2_section_info) <readin,
3608 is_virtual>: Change type to bool.
3609 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3612 2019-06-19 Tom Tromey <tom@tromey.com>
3614 * tui/tui-data.h (tui_init_content_element): Don't declare.
3616 2019-06-19 Tom Tromey <tom@tromey.com>
3618 * tui/tui-data.h (tui_init_win_info): Don't declare.
3620 2019-06-19 Tom de Vries <tdevries@suse.de>
3622 * dwarf2read.h (abstract_to_concrete): Change type to
3623 std::unordered_map<sect_offset, std::vector<sect_offset>,
3624 gdb::hash_enum<sect_offset>>.
3626 2019-06-19 Tom Tromey <tromey@adacore.com>
3628 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3629 EVAL_AVOID_SIDE_EFFECTS specially.
3631 2019-06-19 Tom Tromey <tromey@adacore.com>
3633 * source-cache.c (highlighter): New global.
3634 (source_cache::get_source_lines): Create a highlighter on demand.
3636 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3638 * defs.h (deprecated_interactive_hook): Delete declaration.
3639 * interps.c (clear_interpreter_hooks): Remove use of
3640 deprecated_interactive_hook.
3641 * top.c (deprecated_interactive_hook): Delete definition.
3642 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3644 2019-06-18 Tom de Vries <tdevries@suse.de>
3647 * dwarf2read.h (abstract_to_concrete): Change type from
3648 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3649 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3650 * dwarf2read.c (read_variable): Update.
3651 (dwarf2_fetch_die_loc_sect_off): Update.
3653 2019-06-17 Tom de Vries <tdevries@suse.de>
3656 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3657 accessing parent[parent_len - 1].
3659 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3662 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3663 call dtrace_process_dof with NULL dof.
3665 2019-06-16 Tom de Vries <tdevries@suse.de>
3668 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3670 2019-06-16 Tom Tromey <tom@tromey.com>
3672 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3673 (make_all_visible): Use address of member.
3675 2019-06-16 Tom Tromey <tom@tromey.com>
3677 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3678 (tui_free_window, free_content, free_content_elements): Remove
3680 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3682 * tui/tui-regs.c (tui_show_register_group)
3683 (tui_display_registers_from, tui_display_reg_element_at_line):
3684 Remove unnecessary cast.
3686 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3688 * linux-nat.c (normal_mask): Delete.
3689 (_initialize_linux_nat): Don't initialise normal_mask.
3691 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3694 * dwarf-index-write.h (write_psymtabs_to_index): Add
3695 dwz_basename parameter.
3696 * dwarf-index-write.c (write_gdbindex): Move file writing to
3697 write_gdbindex_1. Change return type void.
3698 (assert_file_size): Move up, remove filename parameter.
3699 (write_gdbindex_1): New function.
3700 (write_debug_names): Change return type to void, call
3702 (struct index_wip_file): New struct.
3703 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3704 file logic to index_wip_file. Write index for dwz file if
3706 (save_gdb_index_command): Pass basename of dwz file, if present.
3707 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3708 build-id of dwz file, if present.
3709 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3710 (dwarf2_get_dwz_file): Likewise.
3711 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3712 (dwarf2_get_dwz_file): Likewise.
3714 2019-06-16 Tom Tromey <tom@tromey.com>
3716 * coffread.c (process_coff_symbol): Use xstrdup.
3717 * value.c (create_internalvar): Use xstrdup.
3719 2019-06-16 Tom Tromey <tom@tromey.com>
3721 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3722 * breakpoint.c (stopin_command, stopat_command)
3723 (until_break_command, decode_location_default): Remove unnecessary
3725 * utils.c (subset_compare): Remove unnecessary cast.
3726 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3728 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3730 * infcmd.c (path_command): Remove unnecessary cast.
3731 * coffread.c (decode_type): Remove unnecessary cast.
3732 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3733 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3734 * tui/tui-stack.c (tui_show_locator_content)
3735 (tui_show_frame_info): Remove unnecessary cast.
3736 * tui/tui-win.c (tui_scroll_forward_command)
3737 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3738 (parse_scrolling_args): Remove unnecessary cast.
3739 * tui/tui-data.c (init_win_info, tui_del_window)
3740 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3741 (free_content_elements): Remove unnecessary cast.
3742 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3744 * tui/tui-source.c (tui_set_source_content)
3745 (tui_vertical_source_scroll): Remove unnecessary cast.
3746 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3748 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3749 * tui/tui-regs.c (tui_display_registers_from)
3750 (tui_display_register): Remove unnecessary cast.
3751 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3752 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3753 (make_visible): Remove unnecessary cast.
3754 * tui/tui-winsource.c (tui_erase_source_content)
3755 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3757 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3758 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3759 * stabsread.c (read_type, read_array_type, read_range_type):
3760 Remove unnecessary cast.
3761 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3762 (parse_symbol, parse_type, upgrade_type, parse_external)
3763 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3765 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3767 2019-06-16 Tom Tromey <tom@tromey.com>
3769 * tui/tui-data.c (tui_alloc_generic_win_info)
3770 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3773 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3774 Andrew Burgess <andrew.burgess@embecosm.com>
3776 * f-typeprint.c (f_print_type): Don't return early for not
3777 associated or not allocated types.
3778 (f_type_print_varspec_suffix): Add print_rank parameter and print
3779 ranks of array types in case they dangling.
3780 (f_type_print_base): Add print_rank parameter.
3782 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3784 * NEWS: Mention new MI commands.
3785 * break-catch-throw.c (enum exception_event_kind): Move to
3787 (print_mention_exception_catchpoint): Output text as a single
3789 (catch_exception_command_1): Rename to...
3790 (catch_exception_event): ...this, make non-static, update header
3791 command, and change some parameter types.
3792 (catch_catch_command): Update for changes to
3793 catch_exception_command_1.
3794 (catch_throw_command): Likewise.
3795 (catch_rethrow_command): Likewise.
3796 * breakpoint.c (enum exception_event_kind): Delete.
3797 * breakpoint.h (enum exception_event_kind): Moved here from
3798 break-catch-throw.c.
3799 (catch_exception_event): Declare.
3800 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3801 (mi_cmd_catch_throw): New function.
3802 (mi_cmd_catch_rethrow): New function.
3803 (mi_cmd_catch_catch): New function.
3804 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3805 'catch-catch' entries.
3806 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3807 (mi_cmd_catch_rethrow): Declare.
3808 (mi_cmd_catch_catch): Declare.
3810 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3812 * annotate.c (annotate_source_line): Change return type to void,
3813 update implementation to match.
3814 * annotate.h (annotate_source_line): Change return type to void,
3815 update header comment.
3816 * stack.c (print_frame_info): Don't change what frame information
3817 is printed based on whether annotations are on or not.
3819 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3821 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3822 (annotate_source): Make static.
3823 (annotate_source_line): Moved from source.c and renamed from
3824 identify_source_line. Update the return type.
3825 * annotate.h (annotate_source): Delete declaration.
3826 (annotate_source_line): Declaration moved from source.h, and
3827 renamed from identify_source_line. Return type updated.
3828 * source.c (identify_source_line): Moved to annotate.c and renamed
3829 to annotate_source_line.
3830 (info_line_command): Remove check of annotation_level.
3831 * source.h (identify_source_line): Move declaration to annotate.h
3832 and rename to annotate_source_line.
3833 * stack.c: Add 'annotate.h' include.
3834 (print_frame_info): Remove check of annotation_level before
3835 calling annotate_source_line.
3837 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3839 * source-cache.c (source_cache::get_plain_source_lines): Use
3840 open_source_file_with_line_charpos instead of just
3841 open_source_file, remove call to find_source_lines.
3842 (source_cache::get_source_lines): Likewise.
3843 * source.c (find_source_lines): Make static.
3844 (get_filename_and_charpos): Renamed into...
3845 (open_source_file_with_line_charpos): ..this along with changes to
3846 return a scoped_fd, and some other minor clean ups.
3847 (identify_source_line): Use open_source_file_with_line_charpos.
3848 (search_command_helper): Use open_source_file_with_line_charpos
3849 instead of just open_source_file, remove call to
3851 * source.h (open_source_file_with_line_charpos): Declare new
3853 (find_source_lines): Delete declaration.
3855 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3857 * source.c (get_filename_and_charpos): Remove fullname
3859 (identify_source_line): Update call to get_filename_and_charpos.
3861 2019-06-14 Tom Tromey <tromey@adacore.com>
3864 * ui-style.h (skip_ansi_escape): Update comment.
3865 * ui-file.h (class no_terminal_escape_file): New class.
3866 * ui-file.c (no_terminal_escape_file::write)
3867 (no_terminal_escape_file::puts): New methods.
3868 * cli/cli-logging.c (handle_redirections): Use
3869 no_terminal_escape_file.
3871 2019-06-14 Tom Tromey <tromey@adacore.com>
3873 * NEWS: Move convenience variable news above Python news.
3875 2019-06-14 Tom Tromey <tom@tromey.com>
3877 * gnulib: Move directory to top-level.
3878 * configure.ac: Don't configure gnulib.
3879 * configure: Rebuild.
3880 * common/common-defs.h: Use new path to gnulib.
3881 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3883 (INCGNU): Look in new gnulib location.
3884 (HFILES_NO_SRCDIR): Remove gnulib files.
3885 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3886 (generated_files): Remove GNULIB_H.
3887 ($(LIBGNU), all-lib): Remove targets.
3888 (distclean): Don't mention GNULIB_BUILDDIR.
3889 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3891 2019-06-14 Tom Tromey <tromey@adacore.com>
3893 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3894 Warn if symbol file does not provide any symbols.
3896 2019-06-14 Tom Tromey <tromey@adacore.com>
3898 * source.c (find_and_open_source): Respect basenames_may_differ.
3900 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3902 * annotate.c (annotate_breakpoints_invalid): Make use of
3903 scoped_restore_terminal_state.
3904 (annotate_frames_invalid): Likewise.
3906 2019-06-14 Tom Tromey <tromey@adacore.com>
3908 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3909 allow assignment to an internalvar.
3911 2019-06-14 Tom Tromey <tromey@adacore.com>
3913 * ada-lex.l: Allow "_" in attribute names.
3915 2019-06-14 Tom Tromey <tromey@adacore.com>
3918 * regcache.c (registers_changed): Don't call alloca.
3919 * top.c (execute_command): Don't call alloca.
3921 2019-06-13 Pedro Alves <palves@redhat.com>
3923 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3924 'expression'. When parsing an expression, error out if there's
3925 junk after "unlimited".
3926 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3927 (do_set_command): Adjust calls to is_unlimited_literal.
3929 2019-06-13 Pedro Alves <palves@redhat.com>
3931 * compile/compile.c (make_compile_options_def_group): Add braces
3932 around array_view initializer.
3933 * thread.c (make_thread_apply_all_options_def_group)
3934 (make_thread_apply_all_options_def_group): Likewise.
3936 2019-06-13 Pedro Alves <palves@redhat.com>
3938 * NEWS (New commands): Mention "maint test-options
3939 require-delimiter", "maint test-options unknown-is-error", "maint
3940 test-options unknown-is-operand" and "maint show
3941 test-options-completion-result".
3942 (New command options, command completion): New section.
3943 (Completion improvements): New section.
3944 Mention that you can abbreviate "unlimited".
3946 2019-06-13 Pedro Alves <palves@redhat.com>
3948 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3949 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3950 * unittests/cli-utils-selftests.c (test_parse_flags)
3951 (test_parse_flags_qcs): Delete.
3952 (test_cli_utils): Don't call deleted functions.
3954 2019-06-13 Pedro Alves <palves@redhat.com>
3956 * thread.c: Include "cli/cli-option.h".
3957 (tp_array_compar_ascending): Global.
3958 (tp_array_compar): Delete function.
3959 (tp_array_compar_ascending, tp_array_compar_descending): New
3961 (ascending_option_def, qcs_flag_option_def)
3962 (thr_qcs_flags_option_defs)
3963 (make_thread_apply_all_options_def_group)
3964 (make_thread_apply_options_def_group): New.
3965 (thread_apply_all_command): Use gdb::option::process_options.
3966 (thread_apply_command_completer)
3967 (thread_apply_all_command_completer): New.
3968 (thread_apply_command): Use gdb::option::process_options.
3969 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3970 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3971 to generate help text of "thread apply". Adjust "taas"'s help.
3972 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3973 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3975 2019-06-13 Pedro Alves <palves@redhat.com>
3977 * thread.c (thread_apply_command): Check for invalid TID with
3978 isdigit instead of !isalpha.
3980 2019-06-13 Pedro Alves <palves@redhat.com>
3982 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3983 (validate_flags_qcs): New.
3984 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3985 (validate_flags_qcs): Declare.
3986 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3987 (make_frame_apply_options_def_group): New.
3988 (frame_apply_command_count): Process options with
3989 gdb::option::process_options.
3990 (frame_apply_completer): New.
3991 (frame_apply_level_completer, frame_apply_all_completer)
3992 (frame_apply_completer): New.
3993 (_initialize_stack): Update help of "frame apply", "frame apply
3994 level", "frame apply all" and "faas" to mention supported options
3995 and install command completers.
3996 * stack.h (frame_apply_all_completer): Declare.
3997 * thread.c: Include "stack.h".
3998 (tfaas_command): Add "--".
3999 (_initialize_thread): Update help "tfaas" to mention supported
4000 options and install command completer.
4002 2019-06-13 Pedro Alves <palves@redhat.com>
4004 * completer.c (complete_nested_command_line): New.
4005 (gdb_completion_word_break_characters_throw): Add assertion.
4006 * completer.h (complete_nested_command_line): Declare.
4008 2019-06-13 Pedro Alves <palves@redhat.com>
4010 * stack.c (parse_backtrace_qualifiers): New.
4011 (backtrace_command): Use it.
4012 (backtrace_command_completer): Complete on qualifiers.
4014 2019-06-13 Pedro Alves <palves@redhat.com>
4016 * frame.c: Include "cli/cli-option.h.
4017 (user_set_backtrace_options): New.
4018 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4020 (get_prev_frame): Adjust.
4021 (boolean_option_def, uinteger_option_def)
4022 (set_backtrace_option_defs): New.
4023 (_initialize_frame): Adjust and use
4024 gdb::option::add_setshow_cmds_for_options to install "set
4025 backtrace past-main" and "set backtrace past-entry".
4026 * frame.h: Include "cli/cli-option.h".
4027 (struct frame_print_options): Forward declare.
4028 (print_frame_arguments_all, print_frame_arguments_scalars)
4029 (print_frame_arguments_none): Declare.
4030 (print_entry_values): Delete declaration.
4031 (struct frame_print_options, user_frame_print_options): New.
4032 (struct set_backtrace_options): New.
4033 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4034 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4035 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4036 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4037 (list_args_or_locals): Add frame_print_options parameter.
4038 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4039 * python/py-framefilter.c (enumerate_args): Pass down
4040 USER_FRAME_PRINT_OPTIONS.
4041 * stack.c: Include "cli/cli-option.h".
4042 (print_frame_arguments_all, print_frame_arguments_scalars)
4043 (print_frame_arguments_none): Declare.
4044 (print_raw_frame_arguments, print_entry_values): Delete.
4045 (user_frame_print_options): New.
4046 (boolean_option_def, enum_option_def, frame_print_option_defs):
4048 (struct backtrace_cmd_options): New.
4049 (bt_flag_option_def): New.
4050 (backtrace_command_option_defs): New.
4051 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4052 (print_frame_arg, read_frame_arg, print_frame_args)
4053 (print_frame_info, print_frame): Add frame_print_options parameter
4055 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4056 (backtrace_command_1): Add frame_print_options and
4057 backtrace_cmd_options parameters and use them.
4058 (make_backtrace_options_def_group): New.
4059 (backtrace_command): Process command options with
4060 gdb::option::process_options.
4061 (backtrace_command_completer): New.
4062 (_initialize_stack): Extend "backtrace"'s help to mention
4063 supported options. Install completer for "backtrace".
4064 Install some settings commands with add_setshow_cmds_for_options.
4066 2019-06-13 Pedro Alves <palves@redhat.com>
4068 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4069 and that "set/show print raw frame-arguments" are now deprecated.
4071 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4073 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4074 * stack.c (_initialize_stack): Install "set/show print
4075 raw-frame-arguments", and deprecate "set/show print raw
4077 * valprint.c (_initialize_valprint): Deprecate "set/show print
4080 2019-06-13 Pedro Alves <palves@redhat.com>
4082 * compile/compile.c (struct compile_options): New.
4083 (compile_flag_option_def, compile_command_option_defs)
4084 (make_compile_options_def_group): New.
4085 (compile_file_command): Handle options with
4086 gdb::option::process_options.
4087 (compile_file_command_completer): New function.
4088 (compile_code_command): Handle options with
4089 gdb::option::process_options.
4090 (compile_code_command_completer): New function.
4091 (_initialize_compiler): Install completers for "compile code" and
4092 "compile file". Mention available options in "compile code" and
4093 "compile code"'s help.
4094 * completer.c (advance_to_completion_word): New, factored out from
4096 (advance_to_expression_complete_word_point): ... this.
4097 (advance_to_filename_complete_word_point): New.
4098 * completer.h (advance_to_filename_complete_word_point): New
4101 2019-06-13 Pedro Alves <palves@redhat.com>
4103 * compile/compile.c: Include "cli/cli-option.h".
4104 (compile_print_value): Scope data pointer is now a
4105 value_print_options pointer; adjust.
4106 (compile_print_command): Process options. Scope data pointer is
4107 now a value_print_options pointer; adjust.
4108 (_initialize_compile): Update "compile print"'s help to include
4109 supported options. Install a completer for "compile print".
4110 * cp-valprint.c (show_vtblprint, show_objectprint)
4111 (show_static_field_print): Delete.
4112 (_initialize_cp_valprint): Don't install "set print
4113 static-members", "set print vtbl", "set print object" here.
4114 * printcmd.c: Include "cli/cli-option.h" and
4115 "common/gdb_optional.h".
4116 (print_command_parse_format): Rework to fill in a
4117 value_print_options instead of a format_data.
4118 (print_value): Change parameter type from format_data pointer to
4119 value_print_options reference. Adjust.
4120 (print_command_1): Process options. Adjust to pass down a
4121 value_print_options.
4122 (print_command_completer): New.
4123 (_initialize_printcmd): Install print_command_completer as
4124 handle_brkchars completer for the "print" command. Update
4125 "print"'s help to include supported options.
4126 * valprint.c: Include "cli/cli-option.h".
4127 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4128 here from cp-valprint.c.
4129 (boolean_option_def, uinteger_option_def)
4130 (value_print_option_defs, make_value_print_options_def_group):
4131 New. Use gdb::option::add_setshow_cmds_for_options to install
4132 "set print elements", "set print null-stop", "set print repeats",
4133 "set print pretty", "set print union", "set print array", "set
4134 print address", "set print symbol", "set print array-indexes".
4135 * valprint.h: Include <string> and "cli/cli-option.h".
4136 (make_value_print_options_def_group): Declare.
4137 (print_value): Change parameter type from format_data pointer to
4138 value_print_options reference.
4139 (print_command_completer): Declare.
4141 2019-06-13 Pedro Alves <palves@redhat.com>
4143 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4144 (COMMON_SFILES): Add maint-test-settings.c.
4145 * cli/cli-decode.c (boolean_enums): New global, factored out from
4147 (add_setshow_boolean_cmd): ... here.
4148 * cli/cli-decode.h (boolean_enums): Declare.
4149 * cli/cli-option.c: New file.
4150 * cli/cli-option.h: New file.
4151 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4152 factored out from ...
4153 (parse_cli_boolean_value(const char *)): ... this.
4154 (is_unlimited_literal): Change parameter type to pointer to
4155 pointer. Adjust and advance ARG pointer.
4156 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4157 (parse_cli_var_enum): New, factored out from ...
4158 (do_set_command): ... this. Adjust.
4159 * cli/cli-setshow.h (parse_cli_boolean_value)
4160 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4161 (parse_cli_var_enum): Declare.
4162 * cli/cli-utils.c: Include "cli/cli-option.h".
4163 (get_ulongest): New.
4164 * cli/cli-utils.h (get_ulongest): Declare.
4165 (check_for_argument): New overloads.
4166 * maint-test-options.c: New file.
4168 2019-06-13 Pedro Alves <palves@redhat.com>
4170 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4171 parse a range if "-" is at the end of the string.
4173 2019-06-13 Pedro Alves <palves@redhat.com>
4175 * cli/cli-setshow.c (parse_auto_binary_operation)
4176 (parse_cli_boolean_value): Don't allow "o".
4178 2019-06-13 Pedro Alves <palves@redhat.com>
4180 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4181 * NEWS: Mention maint test-settings KIND.
4182 * maint-test-settings.c: New file.
4184 2019-06-13 Pedro Alves <palves@redhat.com>
4186 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4188 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4191 2019-06-13 Pedro Alves <palves@redhat.com>
4193 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4196 2019-06-13 Pedro Alves <palves@redhat.com>
4198 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4200 2019-06-13 Pedro Alves <palves@redhat.com>
4202 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4203 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4205 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4206 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4208 (check_for_argument): Skip spaces after argument.
4210 2019-06-13 Pedro Alves <palves@redhat.com>
4212 * thread.c (thread_apply_command): Adjust TID parsing.
4213 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4214 detected before end of string.
4215 (tid_is_in_list): Error out if LIST is invalid.
4217 2019-06-13 Pedro Alves <palves@redhat.com>
4219 * completer.c (complete_line_internal_1): Rewind completion word
4221 (completion_tracker::advance_custom_word_point_by): Change
4222 parameter type to int.
4223 * completer.h (completion_tracker::advance_custom_word_point_by):
4226 2019-06-13 Pedro Alves <palves@redhat.com>
4228 * completer.c (advance_to_completion_word): Handle delimiters.
4230 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4232 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4234 2019-06-11 Tom Tromey <tom@tromey.com>
4236 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4237 (xmalloc_failed): Move to alloc.c.
4238 * alloc.c: New file.
4239 * Makefile.in (COMMON_SFILES): Add alloc.c.
4241 2019-06-11 Tom Tromey <tom@tromey.com>
4243 * nat/linux-waitpid.c: Don't include server.h.
4244 (linux_debug): Remove.
4245 (my_waitpid): Update.
4247 2019-06-11 Tom Tromey <tromey@adacore.com>
4249 * infcall.c (_initialize_infcall): Remove trailing newline from
4251 * user-regs.c (_initialize_user_regs): Remove trailing newline
4253 * typeprint.c (_initialize_typeprint): Remove trailing newline
4255 * reverse.c (_initialize_reverse): Remove trailing newlines from
4257 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4259 * language.c (add_set_language_command): Remove trailing newline
4261 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4263 * disasm.c (_initialize_disasm): Remove trailing newline from
4265 * top.c (init_main): Remove trailing newline from help.
4266 * interps.c (_initialize_interpreter): Remove trailing newline
4268 * btrace.c (_initialize_btrace): Remove trailing newlines from
4270 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4272 * python/python.c (_initialize_python): Remove trailing newline
4274 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4276 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4277 from help. Reformat some text.
4278 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4280 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4283 2019-06-11 Tom Tromey <tromey@adacore.com>
4285 * darwin-nat.c (darwin_decode_exception_message)
4286 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4288 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4290 * valops.c (value_slice): Check for not allocated or not
4293 2019-06-10 Tom de Vries <tdevries@suse.de>
4296 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4297 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4300 2019-06-10 Tom de Vries <tdevries@suse.de>
4303 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4304 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4306 2019-06-10 Tom de Vries <tdevries@suse.de>
4309 * symtab.c (struct demangled_name_entry): Add language field.
4310 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4311 static minimal symbol". Set and use language field.
4313 2019-06-10 Tom Tromey <tromey@adacore.com>
4315 * ada-lang.c (_initialize_ada_language): Update help text.
4317 2019-06-10 Tom Tromey <tromey@adacore.com>
4319 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4321 * guile/guile.c (handle_boot_error): Don't end warning with a
4323 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4324 warning with a newline.
4325 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4327 (s12z_frame_cache): Likewise.
4328 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4330 * solib-svr4.c (disable_probes_interface): Don't end warning with
4332 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4334 * python/python.c (do_finish_initialization): Don't end warning
4337 2019-06-10 Tom Tromey <tom@tromey.com>
4339 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4340 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4343 2019-06-10 Tom Tromey <tromey@adacore.com>
4345 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4347 (elf_new_init): Don't call stabsread_new_init.
4348 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4349 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4350 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4352 2019-06-10 Tom de Vries <tdevries@suse.de>
4356 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4358 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4360 * source.c (find_and_open_source): Also rewrite relative file
4363 2019-04-26 Amos Bird <amosbird@gmail.com>
4365 * annotate.c (annotate_thread_exited): Add "thread-exited"
4368 2019-06-06 Tom Tromey <tromey@adacore.com>
4370 * maint.h (class scoped_command_stats): Use
4371 DISABLE_COPY_AND_ASSIGN.
4372 <print_time>: New method.
4373 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4375 (scoped_command_stats::print_time): New method.
4377 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4379 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4380 instructions of lengths 6 or 8 bytes.
4382 2019-06-04 Pedro Alves <palves@redhat.com>
4384 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4386 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4387 * breakpoint.c (condition_completer): Likewise.
4388 * cli/cli-dump.c (scan_expression): Likewise.
4389 * common/filestuff.c (mkdir_recursive): Likewise.
4390 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4391 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4392 (gdb_abspath): Likewise.
4393 * compile/compile-cplus-types.c
4394 (compile_cplus_instance::decl_name): Likewise.
4395 * completer.c (complete_explicit_location):
4396 (signal_completer, reg_or_group_completer_1): Likewise.
4397 * cp-support.c (cp_remove_params_if_any): Likewise.
4398 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4399 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4400 * infcmd.c (strip_bg_char): Likewise.
4401 * linespec.c (copy_token_string): Likewise.
4402 * mi/mi-main.c (output_cores): Likewise.
4403 * psymtab.c (psymtab_search_name):
4404 * symfile.c (test_set_ext_lang_command): Likewise.
4405 * target.c (target_fileio_read_stralloc): Likewise.
4406 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4407 * value.c (complete_internalvar): Likewise.
4409 2019-06-04 Christian Biesinger <cbiesinger@google.com>
4411 Add objfile property to gdb.Type.
4412 * NEWS: Mention Python API addition.
4413 * python/py-type.c (typy_get_objfile): New method.
4415 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4417 * NEWS: Mention the new set|show style [title|highlight].
4418 Mention changes to "show style", "help" and "apropos".
4420 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4422 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4423 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4424 instead of print_help_for_command.
4425 (print_doc_of_command): New function.
4426 (help_list): Add 'apropos -v word' suggestion.
4427 (print_help_for_command): Style the command name using title style.
4428 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4429 (_initialize_cli_cmds): Describe -v in apropos_command help.
4431 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4433 * cli/cli-style.h (cli_style_option): Add name in constructor,
4434 add m_name class member, add constructor with intensity,
4435 add name class function.
4436 (cli_style_option::add_setshow_commands): Remove name argument.
4437 (highlight_style, title_style): New styles.
4438 * cli/cli-style.c (do_show): New function that shows a style
4439 characteristic styling the style name with itself.
4440 (set_style_name): New function.
4441 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4442 Update all callers according to the changes in cli/cli-style.h.
4443 * utils.h (fputs_highlighted): New function.
4444 * utils.c (fputs_highlighted): Likewise.
4446 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4448 * NEWS: Mention new pipe command and new convenience variables.
4450 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4452 * cli/cli-cmds.c (pipe_command): New function.
4453 (_initialize_cli_cmds): Call add_com for pipe_command.
4454 Define | as an alias for pipe.
4455 (exit_status_set_internal_vars): New function.
4456 (shell_escape): Call exit_status_set_internal_vars.
4457 cli/cli-decode.c (find_command_name_length): Recognize | as
4458 a single character command.
4460 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4462 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4463 top.c (execute_command_to_ui_file): New function, mostly a copy
4464 of execute_command_to_string.
4465 (execute_command_to_string): Implement by calling
4466 execute_command_to_ui_file.
4468 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4470 * top.h (saved_command_line): Remove declaration.
4471 * top.c (previous_saved_command_line, previous_repeat_arguments):
4473 (saved_command_line): Make static, define together with other
4475 (dont_repeat): Clear repeat_arguments.
4476 (repeat_previous, get_saved_command_line, save_command_line):
4478 (gdb_init): Initialize saved_command_line
4479 and previous_saved_command_line.
4480 * main.c (captured_main_1): Remove saved_command_line initialization.
4481 * event-top.c (handle_line_of_input): Update to use
4482 the new 'repeat' related functions instead of direct access to
4484 * command.h (repeat_previous, get_saved_command_line,
4485 save_command_line): New declarations.
4486 (dont_repeat): Add comment.
4488 2019-05-30 Tom Tromey <tromey@adacore.com>
4490 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4492 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4494 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4497 * completer.c (complete): Initialize variable word.
4499 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4501 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4502 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4503 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4504 'body' is NULL to the outter 'if', protecting the '!is_define'
4507 2019-05-29 Tom Tromey <tromey@adacore.com>
4509 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4510 (dwarf_unknown): New function.
4511 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4512 (dwarf_type_encoding_name): Use dwarf_unknown.
4514 2019-05-29 Tom Tromey <tromey@adacore.com>
4517 * cp-valprint.c (cp_print_value_fields): Call
4518 cp_print_static_field inside "try".
4520 2019-05-29 Tom Tromey <tromey@adacore.com>
4522 * inflow.c (struct terminal_info): Add default operator=.
4523 * configure: Rebuild.
4524 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4525 -Wdeprecated-copy-dtor, -Wredundant-move.
4527 2019-05-29 Tom Tromey <tromey@adacore.com>
4530 * infcmd.c (print_return_value_1): Handle finish_print
4532 (show_print_finish): New function.
4533 (_initialize_infcmd): Add "set/show print finish" commands.
4534 * valprint.c (user_print_options): Initialize new member.
4535 * valprint.h (struct value_print_options) <finish_print>: New
4538 2019-05-28 Tom Tromey <tromey@adacore.com>
4540 * ada-lang.c (ada_remove_Xbn_suffix)
4541 (find_old_style_renaming_symbol)
4542 (parse_old_style_renaming): Remove.
4543 (ada_find_renaming_symbol): Don't call
4544 find_old_style_renaming_symbol.
4545 (ada_is_renaming_symbol): Rename from
4546 ada_find_renaming_symbol. Remove "block" parameter. Return
4548 (ada_read_var_value): Update and simplify.
4549 * ada-exp.y (write_var_or_type): Remove old code.
4551 2019-05-28 Alan Hayward <alan.hayward@arm.com>
4553 * event-top.c: Remove include comment.
4554 * inflow.c (class scoped_ignore_sigttou): Move from here...
4555 * inflow.h (class scoped_ignore_sigttou): ...to here.
4556 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4557 * top.c: Remove include comment.
4559 2019-05-27 Tom Tromey <tom@tromey.com>
4563 2019-05-22 Tom Tromey <tromey@adacore.com>
4565 * target.c (target_follow_exec): Constify parameter.
4566 * target-delegates.c: Rebuild.
4567 * remote.c (remote_target::follow_exec): Constify parameter.
4568 * infrun.c (follow_exec): Constify parameter.
4569 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4570 (target_follow_exec): Likewise.
4572 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4574 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4575 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4577 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4579 * NEWS: Add debugredirect and testsuite sections.
4581 2019-05-22 Simon Cook <simon.cook@embecosm.com>
4583 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4584 target descriptions using exclusively floating point register name
4587 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4590 * f-lang.c (build_fortran_types): Handle the case where
4591 gdbarch_floatformat_for_type returns a nullptr.
4593 2019-05-21 Tom de Vries <tdevries@suse.de>
4596 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4598 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4601 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4603 * i386-tdep.c (i386_floatformat_for_type): Use
4604 floatformats_ia64_quad for the 16-byte floating point component
4605 within a fortran 32-byte complex number.
4607 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4609 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4610 delete default constructor.
4611 (find_partial_die): Update to return const struct.
4612 (partial_die_parent_scope): Move variable declaration into scope
4613 of its use and change its type to auto.
4614 (guess_partial_die_structure_name): Likewise.
4615 (partial_die_info::fixup): Likewise.
4617 2019-05-17 Tom Tromey <tromey@adacore.com>
4619 * source.c (find_and_open_source): Remove cast.
4621 2019-05-17 Tom Tromey <tromey@adacore.com>
4623 * annotate.c (annotate_source): Make "filename" const.
4624 * annotate.h (annotate_source): Use const.
4626 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4628 * disasm.c (set_disassembler_options): Send errors to stderr.
4630 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4632 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4633 (cli_interp_base::set_logging): Check debug_redirect.
4634 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4635 * cli/cli-logging.c (debug_redirect): Add static variable.
4636 (pop_output_files): Add default param.
4637 (handle_redirections): Print debug setting.
4638 (show_logging_command): Likewise.
4639 (_initialize_cli_logging): Add debugredirect command.
4640 * interps.c (current_interp_set_logging): Add debug_redirect
4642 * interps.h (set_logging): Add debug_redirect parameter.
4643 (current_interp_set_logging): Likewise.
4644 * mi/mi-common.h: Likewise.
4645 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4647 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4648 Tom Tromey <tromey@adacore.com>
4650 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4652 * cli/cli-interp.h (make_logging_output): Remove declaration.
4653 * cli/cli-logging.c (make_logging_output): Remove function.
4654 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4656 * ui-file.c (tee_file::tee_file): Remove bools.
4657 (tee_file::~tee_file): Remove deletes.
4658 * ui-file.h (tee_file): Remove bools.
4660 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4662 * mi/mi-cmds.h (mi_cmd_complete): New function.
4663 * mi/mi-main.c (mi_cmd_complete): Likewise.
4664 * mi/mi-cmds.c: Define new MI command -complete.
4665 * NEWS: Mention new -complete command.
4667 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4669 * completer.h (complete): New function.
4670 * completer.c (complete): Likewise.
4671 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4672 function defined in completer.h.
4674 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4676 * MAINTAINERS (Write After Approval): Add myself.
4678 2019-05-17 Tom de Vries <tdevries@suse.de>
4681 * dwarf2read.c (struct cu_partial_die_info): New struct.
4682 (find_partial_die): Return cu_partial_die_info.
4683 (partial_die_parent_scope, guess_partial_die_structure_name)
4684 (partial_die_info::fixup): Handle new return type of find_partial_die.
4686 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4688 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4689 "std::string", simplifying the algorithm.
4691 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4693 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4694 (stap_static_probe_ops::get_probes): Likewise.
4696 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4698 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4699 '-')" and "else if".
4700 (stap_parse_single_operand): Join checks for
4701 "gdbarch_stap_parse_special_token_p" and
4702 "gdbarch_stap_parse_special_token" in the same "if" statement.
4703 Invert check when verifying for operation on register
4706 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4708 * stap-probe.c (stap_get_opcode): Update comment.
4709 (stap_get_expected_argument_type): Likewise.
4710 (handle_stap_probe): Likewise.
4712 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4714 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4715 return type to 'bool'. Adjust comment. Use 'bool' when
4717 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4718 * stap-probe.c (stap_parse_argument_1): Likewise.
4719 (stap_is_operator): Likewise.
4720 (stap_is_generic_prefix): Likewise.
4721 (stap_is_register_prefix): Likewise.
4722 (stap_is_register_indirection_prefix): Likewise.
4723 (stap_is_integer_prefix): Likewise.
4724 (stap_generic_check_suffix): Likewise.
4725 (stap_check_integer_suffix): Likewise.
4726 (stap_check_register_suffix): Likewise.
4727 (stap_check_register_indirection_suffix): Likewise.
4728 (stap_parse_register_operand): Likewise.
4729 (stap_parse_single_operand): Likewise.
4730 (stap_parse_argument_1): Likewise.
4731 (stap_probe::get_argument_count): Likewise.
4732 (stap_is_operator): Likewise.
4734 2019-05-16 Tom Tromey <tromey@adacore.com>
4736 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4739 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
4741 * linux-thread-db.c (try_thread_db_load_1): Change return type
4743 (try_thread_db_load): Likewise.
4744 (try_thread_db_load_from_pdir_1): Likewise.
4745 (try_thread_db_load_from_pdir): Likewise.
4746 (try_thread_db_load_from_sdir): Likewise.
4747 (try_thread_db_load_from_dir): Likewise.
4748 (thread_db_load_search): Likewise.
4749 (has_libpthread): Likewise.
4750 (thread_db_load): Likewise.
4752 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4754 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4755 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4756 NULL, and complain/return if that's the case.
4758 2019-05-15 John Darrington <john@darrington.wattle.id.au>
4760 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4761 (advance, posn, abstract_read_memory): New functions.
4762 [struct mem_read_abstraction]: New struct.
4763 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4765 2019-05-14 Tom Tromey <tromey@adacore.com>
4767 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4768 value is not lval_memory.
4770 2019-05-14 Tom Tromey <tromey@adacore.com>
4772 * solib.c (info_sharedlibrary_command): Style the file name.
4774 2019-05-14 Alan Hayward <alan.hayward@arm.com>
4776 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4777 (aarch64_vnv_type): Likewise.
4778 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4779 * common/tdesc.c: Likewise.
4780 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4781 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4782 * features/aarch64-fpu.xml: Add ieee half view.
4783 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4784 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4785 * gdbtypes.h (struct builtin_type): Likewise.
4786 (struct objfile_type): Likewise.
4788 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
4790 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4792 * location.h (string_to_event_location): Likewise.
4794 2019-05-11 Joel Brobecker <brobecker@adacore.com>
4798 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4800 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4801 New variable declaration.
4802 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4804 (print_one_breakpoint): Use ui_out::test_flags and new global
4805 variable to compute use_fixed_output.
4806 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4808 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4809 (mi_multi_location_breakpoint_output_fixed): Remove.
4810 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4812 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4813 fix_multi_location_breakpoint_output flag if version >= 3.
4814 * ui-out.h (enum ui_out_flag)
4815 <fix_multi_location_breakpoint_output>: New enumerator.
4817 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4819 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4821 2019-05-10 Tom Tromey <tromey@adacore.com>
4823 * ada-lang.c (catch_ada_completer): New function.
4824 (_initialize_ada_language): Use it.
4826 2019-05-10 Tom Tromey <tromey@adacore.com>
4828 * thread.c (print_thread_info): Make "requested_threads" const.
4829 * gdbthread.h (print_thread_info): Make "requested_threads"
4831 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4832 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4834 2019-05-08 Tom Tromey <tom@tromey.com>
4836 * gdbtypes.c (objfile_type_data): Change type.
4837 (objfile_type, _initialize_gdbtypes): Update.
4839 2019-05-08 Tom Tromey <tom@tromey.com>
4841 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4842 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4843 (_initialize_dwarf2_frame): Update.
4845 2019-05-08 Tom Tromey <tom@tromey.com>
4847 * objc-lang.c (objc_objfile_data): Change type.
4848 (find_methods): Update.
4849 (_initialize_objc_lang): Remove.
4851 2019-05-08 Tom Tromey <tom@tromey.com>
4853 * stabsread.c (rs6000_builtin_type_data): Change type.
4854 (rs6000_builtin_type, _initialize_stabsread): Update.
4856 2019-05-08 Tom Tromey <tom@tromey.com>
4858 * mips-tdep.c (mips_pdr_data): Remove.
4859 (_initialize_mips_tdep): Update.
4861 2019-05-08 Tom Tromey <tom@tromey.com>
4863 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4864 (hppa_init_objfile_priv_data, read_unwind_info)
4865 (find_unwind_entry, _initialize_hppa_tdep): Update.
4867 2019-05-08 Tom Tromey <tom@tromey.com>
4869 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4870 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4872 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4874 2019-05-08 Tom Tromey <tom@tromey.com>
4876 * mdebugread.c (basic_type_data): Change type.
4877 (basic_type, _initialize_mdebugread): Update.
4879 2019-05-08 Tom Tromey <tom@tromey.com>
4881 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4883 2019-05-08 Tom Tromey <tom@tromey.com>
4885 * nto-tdep.c (nto_inferior_data_reg): Change type.
4886 (nto_inferior_data): Update.
4887 (nto_inferior_data_cleanup, nto_new_inferior_data)
4888 (_initialize_nto_tdep): Remove.
4889 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4891 2019-05-08 Tom Tromey <tom@tromey.com>
4893 * ada-lang.c (struct ada_inferior_data): Add initializers.
4894 (ada_inferior_data): Change type.
4895 (ada_inferior_data_cleanup): Remove.
4896 (get_ada_inferior_data, ada_inferior_exit)
4897 (struct ada_pspace_data): Add initializers, destructor.
4898 (ada_pspace_data_handle): Change type.
4899 (get_ada_pspace_data): Update.
4900 (ada_pspace_data_cleanup): Remove.
4902 2019-05-08 Tom Tromey <tom@tromey.com>
4904 * coffread.c (struct coff_symfile_info): Add initializers.
4905 (coff_objfile_data_key): Move lower. Change type.
4906 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4908 (coff_free_info): Remove.
4910 2019-05-08 Tom Tromey <tom@tromey.com>
4912 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4913 (fbsd_pspace_data_handle): Move lower. Change type.
4914 (get_fbsd_pspace_data): Update.
4915 (fbsd_pspace_data_cleanup): Remove.
4916 (_initialize_fbsd_tdep): Update.
4918 2019-05-08 Tom Tromey <tom@tromey.com>
4920 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4921 (get_ada_tasks_pspace_data): Update.
4922 (ada_tasks_pspace_data_cleanup): Remove.
4923 (_initialize_tasks): Update.
4924 (ada_tasks_inferior_data_handle): Change type.
4925 (get_ada_tasks_inferior_data): Update.
4926 (ada_tasks_inferior_data_cleanup): Remove.
4927 (struct ada_tasks_pspace_data): Add initializers.
4929 2019-05-08 Tom Tromey <tom@tromey.com>
4931 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4932 * symfile-debug.c (debug_sym_get_probes): Change type.
4933 * stap-probe.c (handle_stap_probe):
4934 (stap_static_probe_ops::get_probes): Change type.
4935 * probe.h (class static_probe_ops) <get_probes>: Change type.
4936 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4937 (parse_probes_in_pspace): Update.
4938 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4940 (any_static_probe_ops::get_probes): Change type.
4941 * elfread.c (elfread_data): New typedef.
4942 (probe_key): Change type.
4943 (elf_get_probes): Likewise. Update.
4944 (probe_key_free): Remove.
4945 (_initialize_elfread): Update.
4946 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4948 (dtrace_process_dof_probe, dtrace_process_dof)
4949 (dtrace_static_probe_ops::get_probe): Change type.
4951 2019-05-08 Tom Tromey <tom@tromey.com>
4953 * xcoffread.c (struct xcoff_symfile_info): Rename from
4954 coff_symfile_info. Add initializers.
4955 (xcoff_objfile_data_key): Move lower. Change type.
4956 (XCOFF_DATA): Rewrite.
4957 (xcoff_free_info): Remove.
4958 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4959 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4960 (xcoff_initial_scan): Update.
4962 2019-05-08 Tom Tromey <tom@tromey.com>
4964 * solib-svr4.c (struct svr4_info): Add initializers and
4966 <probes_table>: Now an htab_up.
4967 (solib_svr4_pspace_data): Change type.
4968 (free_probes_table): Simplify.
4969 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4970 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4971 (probes_table_remove_objfile_probes, register_solib_event_probe)
4972 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4973 (_initialize_svr4_solib): Update.
4975 2019-05-08 Tom Tromey <tom@tromey.com>
4977 * remote.c (remote_pspace_data): Change type.
4978 (remote_pspace_data_cleanup): Remove.
4979 (get_remote_exec_file, set_pspace_remote_exec_file)
4980 (_initialize_remote): Update.
4982 2019-05-08 Tom Tromey <tom@tromey.com>
4984 * breakpoint.c (breakpoint_objfile_key): Change type.
4985 (get_breakpoint_objfile_data): Update.
4986 (free_breakpoint_objfile_data): Remove.
4987 (_initialize_breakpoint): Update.
4989 2019-05-08 Tom Tromey <tom@tromey.com>
4991 * linux-tdep.c (struct linux_info): Add initializers.
4992 (linux_inferior_data): Move. Change type.
4993 (invalidate_linux_cache_inf): Update.
4994 (linux_inferior_data_cleanup): Remove.
4995 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4997 2019-05-08 Tom Tromey <tom@tromey.com>
4999 * auxv.c (auxv_inferior_data): Move. Change type.
5000 (auxv_inferior_data_cleanup): Remove.
5001 (invalidate_auxv_cache_inf): Rewrite.
5002 (get_auxv_inferior_data, _initialize_auxv): Update.
5004 2019-05-08 Tom Tromey <tom@tromey.com>
5006 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5007 (symfile_debug_objfile_data_key): Change type.
5008 (symfile_debug_installed, debug_qf_has_symbols)
5009 (debug_qf_find_last_source_symtab)
5010 (debug_qf_forget_cached_source_info)
5011 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5012 (debug_qf_print_stats, debug_qf_dump)
5013 (debug_qf_expand_symtabs_for_function)
5014 (debug_qf_expand_all_symtabs)
5015 (debug_qf_expand_symtabs_with_fullname)
5016 (debug_qf_map_matching_symbols)
5017 (debug_qf_expand_symtabs_matching)
5018 (debug_qf_find_pc_sect_compunit_symtab)
5019 (debug_qf_map_symbol_filenames)
5020 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5021 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5022 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5023 (debug_sym_read_linetable, debug_sym_relocate): Update.
5024 (symfile_debug_free_objfile): Remove.
5025 (install_symfile_debug_logging, _initialize_symfile_debug):
5028 2019-05-08 Tom Tromey <tom@tromey.com>
5030 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5031 allocate_on_obstack.
5032 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5033 (get_dwarf2_per_objfile): Update.
5034 (set_dwarf2_per_objfile): Remove.
5035 (dwarf2_has_info, dwarf2_get_section_info): Update.
5036 (dwarf2_free_objfile): Remove.
5037 (_initialize_dwarf2_read): Update.
5039 2019-05-08 Tom Tromey <tom@tromey.com>
5041 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5043 <unsupported_script_warning_printed,
5044 script_not_found_warning_printed>: Now bool.
5045 (auto_load_pspace_data): Change type.
5046 (~auto_load_pspace_info): Rename from
5047 auto_load_pspace_data_cleanup.
5048 (get_auto_load_pspace_data, init_loaded_scripts_info)
5049 (clear_section_scripts, maybe_print_unsupported_script_warning)
5050 (maybe_print_script_not_found_warning, _initialize_auto_load):
5053 2019-05-08 Tom Tromey <tom@tromey.com>
5055 * objfiles.c (objfile_pspace_info): Add destructor and
5057 (objfiles_pspace_data): Change type.
5058 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5059 (get_objfile_pspace_data): Update.
5060 (objfiles_bfd_data): Change type.
5061 (get_objfile_bfd_data): Update.
5062 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5064 2019-05-08 Tom Tromey <tom@tromey.com>
5066 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5068 (get_catch_syscall_inferior_data): Update.
5069 (catch_syscall_inferior_data_cleanup): Remove.
5070 (_initialize_break_catch_syscall): Update.
5072 2019-05-08 Tom Tromey <tom@tromey.com>
5074 * inflow.c (struct terminal_info): Add destructor and
5076 (inflow_inferior_data): Change type.
5077 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5078 (get_inflow_inferior_data, inflow_inferior_exit)
5079 (swap_terminal_info, _initialize_inflow): Update.
5081 2019-05-08 Tom Tromey <tom@tromey.com>
5083 * target-dcache.c (target_dcache_cleanup): Remove.
5084 (target_dcache_aspace_key): Change type.
5085 (target_dcache_init_p, target_dcache_invalidate)
5086 (target_dcache_get, target_dcache_get_or_init)
5087 (_initialize_target_dcache): Update.
5088 * dcache.h (struct dcache_deleter): New.
5090 2019-05-08 Tom Tromey <tom@tromey.com>
5092 * symtab.c (struct symbol_cache): Add destructor and
5094 (symbol_cache_key): Move. Change type.
5095 (make_symbol_cache, free_symbol_cache): Remove.
5096 (get_symbol_cache): Update.
5097 (symbol_cache_cleanup): Remove.
5098 (ALL_PSPACES, symbol_cache_flush)
5099 (maintenance_print_symbol_cache)
5100 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5103 2019-05-08 Tom Tromey <tom@tromey.com>
5105 * symtab.c (struct main_info): Add destructor and initializers.
5106 (main_progspace_key): Move. Change type.
5107 (get_main_info): Update.
5108 (main_info_cleanup): Remove.
5109 (_initialize_symtab): Update.
5111 2019-05-08 Tom Tromey <tom@tromey.com>
5113 * registry.h (DECLARE_REGISTRY): Define the _key class.
5115 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5117 * NEWS: Merge two 'New commands' sections.
5119 2019-05-08 Joel Brobecker <brobecker@adacore.com>
5121 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5122 parameter and use Ada language definition instead.
5123 (ada_val_print_ptr): Remove unused language parameter.
5124 (ada_val_print_num): Remove language parameter and use Ada language
5126 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5128 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5129 parameter and use Ada language definition instead.
5130 (ada_val_print_1): Update all ada_val_print_xxx calls.
5131 Remove language parameter.
5132 (ada_val_print): Update ada_val_print_1 call.
5134 2019-05-08 Tom Tromey <tromey@adacore.com>
5136 * remote.c (remote_hw_watchpoint_limit)
5137 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5140 2019-05-08 Tom Tromey <tromey@adacore.com>
5142 * maint.c (_initialize_maint_cmds): Move initialization code to
5144 (watchdog, show_watchdog): Move to remote.c.
5145 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5147 (_initialize_remote): Move initialization code from maint.c.
5148 * defs.h (watchdog): Don't declare.
5150 2019-05-08 Tom Tromey <tromey@adacore.com>
5152 * tui/tui-interp.c: Include main.h.
5153 * interps.c: Include main.h.
5154 * main.h (interpreter_p): Declare.
5155 * defs.h (interpreter_p): Don't declare.
5157 2019-05-08 Tom Tromey <tromey@adacore.com>
5159 * dwarf2loc.c: Include dwarf2read.h.
5160 * defs.h (read_unsigned_leb128): Don't declare.
5161 * dwarf2read.h (read_unsigned_leb128): Declare.
5163 2019-05-08 Tom Tromey <tromey@adacore.com>
5165 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5168 2019-05-08 Tom Tromey <tromey@adacore.com>
5170 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5171 when no wrap column is set.
5173 2019-05-08 Tom Tromey <tromey@adacore.com>
5175 * c-lang.c (c_get_string): Handle non-C-style arrays.
5177 2019-05-08 Tom Tromey <tromey@adacore.com>
5179 * typeprint.c (print_offset_data::update): Print the bit offset,
5180 not the number of bits remaining.
5182 2019-05-08 Tom Tromey <tromey@adacore.com>
5184 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5185 padding at end of comment.
5187 2019-05-08 Tom Tromey <tromey@adacore.com>
5189 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5192 2019-05-06 Tom Tromey <tom@tromey.com>
5194 * common/scoped_mmap.c: Include common-defs.h.
5195 * common/scoped_mmap.h: Don't include config.h.
5197 2019-05-04 Tom Tromey <tom@tromey.com>
5199 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5200 (struct aarch64_call_info): Add initializers.
5201 <si>: Now a std::vector.
5202 (pass_on_stack, aarch64_push_dummy_call): Update.
5204 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
5205 Tom Tromey <tom@tromey.com>
5207 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5208 (ppc_threads): Now a std::vector. Now static.
5209 (hwdebug_find_thread_points_by_tid)
5210 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5213 2019-05-04 Tom Tromey <tom@tromey.com>
5215 * arc-tdep.c (arc_tdesc_init): Return bool.
5217 2019-05-04 Tom Tromey <tom@tromey.com>
5219 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5220 Use gdb_assert_not_reached.
5222 2019-05-04 Tom Tromey <tom@tromey.com>
5224 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5227 2019-05-04 Tom Tromey <tom@tromey.com>
5229 * arc-tdep.c (arc_tdesc_init): Use bool.
5231 2019-05-04 Tom Tromey <tom@tromey.com>
5233 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5235 2019-05-04 Tom Tromey <tom@tromey.com>
5237 * cli/cli-cmds.c (valid_command_p): Return bool.
5239 2019-05-04 Tom Tromey <tom@tromey.com>
5241 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5242 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5244 2019-05-04 Raul Tambre <raul@tambre.ee>
5246 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5247 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5248 operator for comparison.
5250 2019-05-04 Tom Tromey <tom@tromey.com>
5252 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5253 (lookup_partial_symbol, print_partial_symbols)
5254 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5255 (psymbol_compare): Update.
5256 (add_psymbol_to_bcache): Clear the entire psymbol.
5257 (maintenance_check_psymtabs): Update.
5258 * psympriv.h (struct partial_symbol): Don't derive from
5259 general_symbol_info.
5260 <obj_section, unrelocated_address, address,
5261 set_unrelocated_address>: Update.
5262 <ginfo>: New member.
5263 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5264 (debug_names::write_psymbols): Update.
5266 2019-05-04 Tom de Vries <tdevries@suse.de>
5268 * contrib/cc-with-tweaks.sh: Support -n arg.
5270 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5272 * corelow.c (core_target::detach): Ensure frame cache and
5273 register caches are cleared.
5274 inferior.c (exit_inferior_1): Likewise.
5276 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5277 Tom Tromey <tom@tromey.com>
5279 * dictionary.c (collate_pending_symbols_by_language): Remove
5280 "struct" from foreach.
5281 * symtab.c (lookup_global_symbol_from_objfile)
5282 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5284 * ser-tcp.c (net_open): Remove "struct" from foreach.
5285 * objfiles.c (objfile_relocate, objfile_rebase)
5286 (objfile_has_symbols): Remove "struct" from foreach.
5287 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5289 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5291 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5292 "struct" from foreach.
5293 * ada-lang.c (create_excep_cond_exprs)
5294 (ada_exception_catchpoint_cond_string): Remove "struct" from
5297 2019-05-03 Tom Tromey <tromey@adacore.com>
5299 * ada-exp.y (convert_char_literal): Check suffix of each
5302 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5305 * ada-exp.y (yywrap): Don't define.
5306 * ada-lex.l (%option): Add noyywrap
5309 2019-05-03 Eli Zaretskii <eliz@gnu.org>
5311 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5312 _WIN32_WINNT to the XP level, unless already defined to a higher
5315 * unittests/parse-connection-spec-selftests.c:
5317 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5320 * symfile.c (find_separate_debug_file): Remove colon from the
5321 drive spec of DOS/Windows file names of the target, so that the
5322 file name produced from DEBUGDIR and the target's directory will
5323 be valid on DOS/Windows systems.
5325 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5327 * rust-lang.c (val_print_struct): Handle printing structures
5330 2019-05-02 Tom Tromey <tromey@adacore.com>
5332 * valarith.c (_initialize_valarith): Remove.
5334 2019-05-01 Tom Tromey <tromey@adacore.com>
5336 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5339 2019-05-01 Tom Tromey <tromey@adacore.com>
5341 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5342 for big-endian copies.
5344 2019-04-30 Ali Tamur <tamur@google.com>
5345 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5346 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5347 (read_3_bytes): New function.
5349 2019-04-30 Joel Brobecker <brobecker@adacore.com>
5351 * windows-nat.c (main_thread_id): Delete.
5352 (handle_output_debug_string): Replace main_thread_id by
5353 current_event.dwThreadId.
5354 (fake_create_process): Likewise.
5355 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5356 Do not set main_thread_id.
5357 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5358 current_event.dwThreadId.
5359 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5361 2019-04-30 Joel Brobecker <brobecker@adacore.com>
5363 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5364 Use current_event.dwThreadId instead of main_thread_id.
5366 2019-04-30 Tom Tromey <tromey@adacore.com>
5368 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5369 (create_excep_cond_exprs): Iterate over program spaces.
5370 (ada_exception_catchpoint_cond_string): Examine all minimal
5371 symbols for exception types.
5373 2019-04-30 Tom Tromey <tromey@adacore.com>
5376 * dwarf2read.c (process_structure_scope): Handle case where type
5377 has template parameters but no symbol was created.
5379 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5380 Chris January <chris.january@arm.com>
5382 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5384 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5386 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5388 * f-typeprint.c (f_print_type): Update rules for printing
5390 (f_type_print_varspec_suffix): Likewise.
5392 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5393 Chris January <chris.january@arm.com>
5395 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5398 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5400 * f-lang.c (build_fortran_types): Change name of void type to
5402 * f-typeprint.c (f_type_print_base): Print the name of the void
5403 type, rather than a fixed string.
5404 * f-valprint.c (f_decorations): Use lower case void string.
5406 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5407 Chris January <chris.january@arm.com>
5409 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5412 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5413 Chris January <chris.january@arm.com>
5414 David Lecomber <david.lecomber@arm.com>
5416 * f-exp.y (BINOP_INTRINSIC): New token.
5417 (exp): New parser rule handling BINOP_INTRINSIC.
5418 (f77_keywords): Add new builtin procedures.
5419 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5420 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5421 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5422 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5423 (print_unop_subexp_f): New function.
5424 (print_binop_subexp_f): New function.
5425 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5426 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5427 (dump_subexp_body_f): Likewise.
5428 (operator_check_f): Likewise.
5429 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5430 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5432 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5434 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5436 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5437 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5438 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5439 (operator_length_f): New fuction.
5440 (print_subexp_f): New function.
5441 (op_name_f): New function.
5442 (dump_subexp_body_f): New function.
5443 (operator_check_f): New function.
5444 (exp_descriptor_f): Replace standard expression handling functions
5446 * gdb/fortran-operator.def: New file.
5447 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5448 * gdb/std-operator.def: Remove UNOP_KIND.
5450 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5452 * std-operator.def: Remove unbalanced, stray double quote
5455 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5456 Chris January <chris.january@arm.com>
5457 Daniel Everett <daniel.everett@arm.com>
5458 Nick Forrington <nick.forrington@arm.com>
5459 Richard Bunt <richard.bunt@arm.com>
5461 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5462 of depth when printing anonymous structs or unions.
5463 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5464 Don't print either the top-level value, or the children if the
5465 max-depth is exceeded.
5466 (ppscm_print_children): When printing the key of a map, allow one
5467 extra level of depth.
5468 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5469 print either the top-level value, or the children if the max-depth
5471 (print_children): When printing the key of a map, allow one extra
5473 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5474 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5475 (user_print_options): Initialise max_depth field.
5476 (val_print_scalar_or_string_type_p): New function.
5477 (val_print): Check to see if the max depth has been reached.
5478 (val_print_check_max_depth): Define new function.
5479 (show_print_max_depth): New function.
5480 (_initialize_valprint): Add 'print max-depth' option.
5481 * valprint.h (struct value_print_options) <max_depth>: New field.
5482 (val_print_check_max_depth): Declare new function.
5483 * NEWS: Document new feature.
5485 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5487 * ada-lang.c (ada_language_defn): Initialise new field.
5488 * c-lang.c (c_is_string_type_p): New function.
5489 (c_language_defn): Initialise new field.
5490 (cplus_language_defn): Initialise new field.
5491 (asm_language_defn): Initialise new field.
5492 (minimal_language_defn): Initialise new field.
5493 * c-lang.h (c_is_string_type_p): Declare new function.
5494 * d-lang.c (d_language_defn): Initialise new field.
5495 * f-lang.c (f_is_string_type_p): New function.
5496 (f_language_defn): Initialise new field.
5497 * go-lang.c (go_is_string_type_p): New function.
5498 (go_language_defn): Initialise new field.
5499 * language.c (default_is_string_type_p): New function.
5500 (unknown_language_defn): Initialise new field.
5501 (auto_language_defn): Initialise new field.
5502 * language.h (struct language_defn) <la_is_string_type_p>: New
5504 (default_is_string_type_p): Declare new function.
5505 * m2-lang.c (m2_language_defn): Initialise new field.
5506 * objc-lang.c (objc_language_defn): Initialise new field.
5507 * opencl-lang.c (opencl_language_defn): Initialise new field.
5508 * p-lang.c (pascal_is_string_type_p): New function.
5509 (pascal_language_defn): Initialise new field.
5510 * rust-lang.c (rust_is_string_type_p): New function.
5511 (rust_language_defn): Initialise new field.
5513 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5515 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5517 * ada-lang.c (ada_language_defn): Initialise new field.
5518 * c-lang.c (c_language_defn): Likewise.
5519 (cplus_language_defn): Likewise.
5520 (asm_language_defn): Likewise.
5521 (minimal_language_defn): Likewise.
5522 * d-lang.c (d_language_defn): Likewise.
5523 * f-lang.c (f_language_defn): Likewise.
5524 * go-lang.c (go_language_defn): Likewise.
5525 * language.c (unknown_language_defn): Likewise.
5526 (auto_language_defn): Likewise.
5527 * m2-lang.c (m2_language_defn): Likewise.
5528 * objc-lang.c (objc_language_defn): Likewise.
5529 * opencl-lang.c (opencl_language_defn): Likewise.
5530 * p-lang.c (pascal_language_defn): Likewise.
5531 * rust-lang.c (rust_language_defn): Likewise.
5533 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5535 * ada-lang.c (ada_is_character_type): Change return type to bool.
5536 (ada_is_string_type): Likewise.
5537 * ada-lang.h (ada_is_character_type): Update declaration
5538 (ada_is_string_type): Likewise.
5540 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5542 Support style in 'frame|thread apply'
5544 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5545 * record.c (record_start, record_stop): Update callers of
5546 execute_command_to_string with false.
5547 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5548 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5550 (class string_file): New constructor with term_out parameter.
5551 Override methods term_out and can_emit_style_escape. New member
5553 (class stdio_file): Override can_emit_style_escape.
5554 (class tee_file): Override term_out and can_emit_style_escape.
5555 * utils.h (can_emit_style_escape): Remove.
5556 * utils.c (can_emit_style_escape): Likewise.
5557 Update all callers of can_emit_style_escape (SOMESTREAM) to
5558 SOMESTREAM->can_emit_style_escape.
5559 * source-cache.c (source_cache::get_source_lines): Likewise.
5560 * stack.c (frame_apply_command_count): Call execute_command_to_string
5561 passing the term_out characteristic of the current gdb_stdout.
5562 * thread.c (thr_try_catch_cmd): Likewise.
5563 * top.c (execute_command_to_string): pass term_out parameter
5564 to construct the string_file for the command output.
5565 * ui-file.c (term_cli_styling): New function (most code moved
5566 from utils.c can_emit_style_escape).
5567 (string_file::string_file, string_file::can_emit_style_escape,
5568 stdio_file::can_emit_style_escape, tee_file::term_out,
5569 tee_file::can_emit_style_escape): New functions.
5571 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5573 * NEWS: Mention the new set|show may-call-functions.
5574 * infcall.c (may_call_functions_p): New variable.
5575 (show_may_call_functions_p): New function.
5576 (call_function_by_hand_dummy): Throws an error if not
5578 (_initialize_infcall): Call add_setshow_boolean_cmd for
5581 2019-04-25 Keith Seitz <keiths@redhat.com>
5584 * cp-support.c (inspect_type): Don't attempt substitutions
5585 of symbol with the same name.
5587 2019-04-25 Tom Tromey <tromey@adacore.com>
5590 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5593 2019-04-25 Tom Tromey <tromey@adacore.com>
5595 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5597 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5598 (gdb_xml_parser::parse): Use std::move.
5599 * python/python-internal.h (gdbpy_convert_exception): Take a const
5601 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5603 * python/py-utils.c (gdbpy_convert_exception): Take a const
5605 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5607 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5609 * mi/mi-main.c (mi_print_exception): Take a const reference.
5610 * main.c (handle_command_errors): Take a const reference.
5611 * linespec.c (parse_linespec): Use std::move.
5612 * infcall.c (run_inferior_call): Use std::move.
5613 (call_function_by_hand_dummy): Use std::move.
5614 * exec.c (try_open_exec_file): Use std::move.
5615 * exceptions.h (exception_print, exception_fprintf)
5616 (exception_print_same): Update.
5617 * exceptions.c (print_exception, exception_print)
5618 (exception_fprintf, exception_print_same): Change parameters to
5620 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5621 * common/new-op.c: Use std::move.
5622 * common/common-exceptions.h (struct gdb_exception): Add move
5624 (struct gdb_exception_error, struct gdb_exception_quit, struct
5625 gdb_quit_bad_alloc): Change constructor to move constructor.
5626 (throw_exception): Change parameter to rvalue reference.
5627 * common/common-exceptions.c (throw_exception): Take rvalue
5629 * cli/cli-interp.c (safe_execute_command): Use std::move.
5630 * breakpoint.c (insert_bp_location, location_to_sals): Use
5633 2019-04-25 Tom Tromey <tromey@adacore.com>
5635 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5636 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5637 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5638 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5639 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5640 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5641 guile/scm-value.c: Use unpack.
5642 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5643 gdbscm_gdb_exception.
5644 (gdbscm_throw_gdb_exception): Likewise.
5645 (struct gdbscm_gdb_exception): New.
5646 (unpack): New function.
5647 (gdbscm_wrap): Use unpack.
5649 2019-04-25 Tom Tromey <tromey@adacore.com>
5651 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5652 (gdb_rl_callback_handler): Use std::move.
5653 * common/common-exceptions.h (struct gdb_exception): Add move
5654 assignment operator.
5655 (throw_exception_sjlj): Change "exception" to const reference.
5656 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5657 (throw_exception_sjlj): Change "exception" to const reference.
5659 2019-04-25 Tom Tromey <tromey@adacore.com>
5661 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5662 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5663 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5665 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5667 * mi/mi-interp.c (mi_interp::exec): Update.
5668 * linespec.c (parse_linespec): Update.
5669 * infcall.c (run_inferior_call): Update.
5670 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5671 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5672 (gdbscm_lookup_global_symbol): Update.
5673 * guile/scm-param.c (gdbscm_parameter_value): Update.
5674 * guile/scm-frame.c (gdbscm_frame_read_register)
5675 (gdbscm_frame_read_var): Update.
5676 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5677 * exec.c (try_open_exec_file): Update.
5678 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5679 (gdb_rl_callback_handler): Update.
5680 * common/common-exceptions.h (exception_none): Don't declare.
5681 * common/common-exceptions.c (exception_none): Don't define.
5682 (struct catcher) <exception>: Update.
5683 * cli/cli-interp.c (safe_execute_command): Update.
5684 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5686 2019-04-25 Ali Tamur <tamur@google.com>
5688 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5689 (read_attribute_value): Likewise.
5690 (dwarf2_read_addr_index): Update comment.
5691 (read_str_index): Add DW_FORM_strx.
5692 (dwarf2_string_attr): Likewise.
5693 (dwarf2_const_value_attr): Likewise.
5694 (dump_die_shallow): Likewise.
5695 (dwarf2_fetch_constant_bytes): Likewise.
5696 (skip_form_bytes): Likewise.
5697 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5699 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5703 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5704 OFFSET. Verify if current mapping contains an ELF header.
5705 (linux_find_memory_regions_full): Adjust call to
5708 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5709 Kang Li <kanglictf@gmail.com>
5713 * dwarf2-frame.c (read_initial_length): Be consistent about using
5714 unsigned representation of length.
5715 (decode_frame_entry_1): Likewise. Check for wraparound of
5716 end pointer as well as buffer overflow.
5718 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5720 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5723 2019-04-24 Tom Tromey <tromey@adacore.com>
5725 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5727 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5729 * s12z-tdep.c (s12z_unwind_pc): Delete.
5730 (s12z_unwind_sp): Delete.
5731 (s12z_gdbarch_init): Don't register deleted functions with
5734 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5736 * rl78-tdep.c (rl78_unwind_sp): Delete.
5737 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5739 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5741 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5742 (xstormy16_unwind_pc): Delete.
5743 (xstormy16_dummy_id): Delete.
5744 (xstormy16_gdbarch_init): Don't register deleted functions with
5747 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5749 * vax-tdep.c (vax_unwind_pc): Delete.
5750 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5752 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5754 * v850-tdep.c (v850_unwind_sp): Delete.
5755 (v850_unwind_pc): Delete.
5756 (v850_dummy_id): Delete.
5757 (v850_gdbarch_init): Don't register deleted functions with
5760 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5762 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5763 (tilegx_unwind_pc): Delete.
5764 (tilegx_unwind_dummy_id): Delete.
5765 (tilegx_gdbarch_init): Don't register deleted functions with
5768 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5770 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5771 (tic6x_dummy_id): Delete.
5772 (tic6x_gdbarch_init): Don't register deleted functions with
5775 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5777 * sparc-tdep.c (sparc_unwind_pc): Delete.
5778 (sparc32_gdbarch_init): Don't register deleted function with
5781 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5783 * sh-tdep.c (sh_unwind_sp): Delete.
5784 (sh_unwind_pc): Delete.
5785 (sh_dummy_id): Delete.
5786 (sh_gdbarch_init): Don't register deleted functions with
5789 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5791 * score-tdep.c (score_unwind_sp): Delete.
5792 (score_unwind_pc): Delete.
5793 (score_dummy_id): Delete.
5794 (score_gdbarch_init): Don't register deleted functions with
5797 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5799 * rx-tdep.c (rx_unwind_pc): Delete.
5800 (rx_unwind_sp): Delete.
5801 (rx_dummy_id): Delete.
5802 (rx_gdbarch_init): Don't register deleted functions with
5803 gdbarch. Update comment.
5805 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5807 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5808 (rs6000_dummy_id): Delete.
5809 (rs6000_gdbarch_init): Don't register deleted functions with
5812 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5814 * or1k-tdep.c (or1k_dummy_id): Delete.
5815 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5817 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5819 * nios2-tdep.c (nios2_dummy_id): Delete.
5820 (nios2_unwind_sp): Delete.
5821 (nios2_gdbarch_init): Don't register deleted functions with
5824 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5826 * nds32-tdep.c (nds32_dummy_id): Delete.
5827 (nds32_unwind_pc): Delete.
5828 (nds32_unwind_sp): Delete.
5829 (nds32_gdbarch_init): Don't register deleted functions with
5832 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5834 * msp430-tdep.c (msp430_unwind_pc): Delete.
5835 (msp430_unwind_sp): Delete.
5836 (msp430_dummy_id): Delete.
5837 (msp430_gdbarch_init): Don't register deleted functions with
5840 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5842 * moxie-tdep.c (moxie_unwind_sp): Delete.
5843 (moxie_unwind_pc): Delete.
5844 (moxie_dummy_id): Delete.
5845 (moxie_gdbarch_init): Don't register deleted functions with
5848 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5850 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5851 (mn10300_unwind_pc): Delete.
5852 (mn10300_unwind_sp): Delete.
5853 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5855 (mn10300_frame_unwind_init): Don't register deleted functions with
5858 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5860 * mep-tdep.c (mep_unwind_pc): Delete.
5861 (mep_unwind_sp): Delete.
5862 (mep_dummy_id): Delete.
5863 (mep_gdbarch_init): Don't register deleted functions with
5866 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5868 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5869 (m68hc11_unwind_sp): Delete.
5870 (m68hc11_gdbarch_init): Don't register deleted functions with
5873 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5875 * m32r-tdep.c (m32r_unwind_sp): Delete.
5876 (m32r_unwind_pc): Delete.
5877 (m32r_dummy_id): Delete.
5878 (m32r_gdbarch_init): Don't register deleted functions with
5881 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5883 * m32c-tdep.c (m32c_unwind_pc): Delete.
5884 (m32c_unwind_sp): Delete.
5885 (m32c_dummy_id): Delete.
5886 (m32c_gdbarch_init): Don't register deleted functions with
5889 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5891 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5892 (lm32_unwind_pc): Delete.
5893 (lm32_dummy_id): Delete.
5894 (lm32_gdbarch_init): Don't register deleted functions with
5897 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5899 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5900 (iq2000_unwind_pc): Delete.
5901 (iq2000_dummy_id): Delete.
5902 (iq2000_gdbarch_init): Don't register deleted functions with
5905 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5907 * nds32-tdep.c (nds32_type_align): Delete.
5908 (nds32_push_dummy_call): Use type_align instead.
5910 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5912 * arm-tdep.c (arm_type_align): Only handle vector override case.
5913 (arm_push_dummy_call): Use type_align.
5914 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5916 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5918 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5920 (pass_on_stack): Use type_align.
5921 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5924 2019-04-23 Tom Tromey <tromey@adacore.com>
5926 * dwarf2read.c (line_header::file_name_at): Remove unused
5929 2019-04-23 Tom de Vries <tdevries@suse.de>
5932 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5936 2019-03-27 Ali Tamur <tamur@google.com>
5938 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5939 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5940 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5941 (dwarf_expr_context::get_addr_index): Likewise
5942 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5943 (symbol_needs_eval_context::get_addr_index): Likewise
5944 (disassemble_dwarf_expression): Add DW_OP_addrx
5945 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5946 (read_cutu_die_from_dwo): Update comment
5947 (skip_one_die): Add DW_FORM_addrx
5948 (read_attribute_value): Likewise
5949 (var_decode_location): Add DW_OP_addrx
5950 (dwarf2_const_value_attr): Add DW_FORM_addrx
5951 (dump_die_shallow): Likewise
5952 (dwarf2_fetch_constant_bytes): Likewise
5953 (decode_locdesc): Add DW_OP_addrx
5954 (skip_form_bytes): Add DW_FORM_addrx
5956 2019-04-22 Ali Tamur <tamur@google.com>
5958 * MAINTAINERS (Write After Approval): Add self.
5960 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
5962 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5963 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5964 (open_symbol_file_object): Likewise.
5965 (svr4_default_sos): Add info parameter.
5966 (svr4_read_so_list): Likewise.
5967 (svr4_current_sos_direct): Adjust functions calls to pass down
5969 (svr4_current_sos_1): Add info parameter.
5970 (svr4_current_sos): Call get_svr4_info, pass info down to
5972 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5974 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5976 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5978 (probes_table_remove_objfile_probes): Likewise.
5979 (register_solib_event_probe): Add info parameter.
5980 (solist_update_incremental): Pass info parameter down to
5982 (disable_probes_interface): Add info parameter.
5983 (svr4_handle_solib_event): Pass current_program_space to
5984 get_svr4_info. Adjust disable_probes_interface cleanup.
5985 (svr4_create_probe_breakpoints): Add info parameter, pass it
5986 down to register_solib_event_probe.
5987 (svr4_create_solib_event_breakpoints): Add info parameter,
5988 pass it down to svr4_create_probe_breakpoints.
5989 (enable_break): Pass info down to
5990 svr4_create_solib_event_breakpoints.
5991 (svr4_solib_create_inferior_hook): Pass current_program_space to
5993 (svr4_clear_solib): Likewise.
5995 2019-04-22 Pedro Alves <palves@redhat.com>
5997 * solib-svr4.c (svr4_free_objfile_observer): New.
5998 (probe_and_action::objfile): New field.
5999 (probes_table_htab_remove_objfile_probes)
6000 (probes_table_remove_objfile_probes): New functions.
6001 (register_solib_event_probe): Add 'objfile' parameter. Store it
6002 in the new probe_and_action. Don't store the probe in 'lookup'.
6003 (svr4_create_probe_breakpoints): Pass objfile to
6004 register_solib_event_probe.
6005 (_initialize_svr4_solib): Register a free_objfile observer.
6007 2019-04-19 Tom Tromey <tom@tromey.com>
6009 * common/queue.h: Remove.
6011 2019-04-19 Tom Tromey <tom@tromey.com>
6013 * event-loop.c: Don't include "common/queue.h".
6015 2019-04-19 Tom Tromey <tom@tromey.com>
6017 * remote.c (remote_target): Use delete.
6018 * remote-notif.h: Include <list>, not "common/queue.h".
6019 (notif_client_p): Remove typedef.
6020 (remote_notif_state): Add constructor, destructor, initializer.
6021 <notif_queue>: Now a std::list.
6022 (remote_notif_state_xfree): Don't declare.
6023 * remote-notif.c (remote_notif_process, handle_notification)
6024 (remote_notif_state_allocate): Update.
6025 (~remote_notif_state): Rename from remote_notif_state_xfree.
6027 2019-04-19 Tom Tromey <tom@tromey.com>
6029 * symfile.c (reread_symbols): Update.
6030 * objfiles.c (objfile_register_static_link)
6031 (objfile_lookup_static_link): Update
6032 (~objfile) Don't delete static_links.
6033 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6035 2019-04-19 Tom Tromey <tom@tromey.com>
6037 * type-stack.h (struct type_stack) <insert>: Constify string.
6038 * type-stack.c (type_stack::insert): Constify string.
6039 * gdbtypes.h (lookup_template_type): Update.
6040 (address_space_name_to_int): Update.
6041 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6043 (lookup_template_type): Make name const.
6044 * c-exp.y: Update rules.
6045 (lex_one_token, classify_name, classify_inner_name)
6046 (c_print_token): Update.
6047 * p-exp.y: Update rules.
6049 * f-exp.y: Update rules.
6051 * d-exp.y: Update rules.
6052 (lex_one_token, classify_name, classify_inner_name): Update.
6053 * parse.c (write_dollar_variable, copy_name): Return std::string.
6054 * parser-defs.h (copy_name): Change return type.
6055 * m2-exp.y: Update rules.
6057 * go-exp.y (lex_one_token): Update.
6059 (classify_unsafe_function, classify_packaged_name)
6060 (classify_name, yylex): Update.
6062 2019-04-19 Sergei Trofimovich <siarheit@google.com>
6064 * configure.ac: add --enable-source-highlight switch.
6065 * configure: Regenerate.
6066 * top.c (print_gdb_version): plumb --enable-source-highlight
6067 status to "show configuration".
6069 2019-04-19 Tom Tromey <tromey@adacore.com>
6071 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6073 (empty_record, ada_template_to_fixed_record_type_1)
6074 (template_to_static_fixed_type)
6075 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6076 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6077 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6080 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6083 * source.c (print_source_lines_base): Advance "iter" when a
6084 control character is seen.
6086 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6088 * inferior.h (struct infcall_suspend_state_deleter):
6089 Catch exception in destructor to avoid crash.
6091 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6093 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6094 close to the add_com "shell".
6096 2019-04-18 Tom Tromey <tromey@adacore.com>
6098 * process-stratum-target.h (class process_stratum_target)
6099 <stratum>: Add "final".
6101 2019-04-17 Tom Tromey <tromey@adacore.com>
6103 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6104 against nullptr before use.
6106 2019-04-17 Alan Hayward <alan.hayward@arm.com>
6108 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6110 2019-04-17 Jim Wilson <jimw@sifive.com>
6111 Andrew Burgess <andrew.burgess@embecosm.com>
6113 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6114 code read might fail, assume 4-byte breakpoint in that case.
6116 2019-04-15 Leszek Swirski <leszeks@google.com>
6118 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6119 rather than a hand-rolled POD check when checking for forced MEMORY
6122 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6124 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6125 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6127 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6128 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6129 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6132 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6134 * aarch64-linux-nat.c
6135 (aarch64_linux_nat_target::thread_architecture): Add override.
6136 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6139 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6141 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6143 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6145 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6146 target types of size 96-bits, add some additional comments, and
6147 check that the builtin type we found was the correct size.
6149 2019-04-12 Eli Zaretskii <eliz@gnu.org>
6151 * utils.c (prompt_for_continue): Don't restore the styling at the
6152 end, as applied_style has the wrong value. This fixes styling in
6153 long lists of file names that are interrupted by the "Continue?"
6156 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6158 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6159 * c-lang.c (c_language_defn): Likewise.
6160 (cplus_language_defn): Likewise.
6161 (asm_language_defn): Likewise.
6162 (minimal_language_defn): Likewise.
6163 * d-lang.c (d_language_defn): Likewise.
6164 * f-lang.c (f_language_defn): Likewise.
6165 * go-lang.c (go_language_defn): Likewise.
6166 * language.c (unknown_language_defn): Likewise.
6167 (auto_language_defn): Likewise.
6168 * language.h (struct language_defn): Remove la_magic field.
6169 (LANG_MAGIC): Delete.
6170 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6171 * objc-lang.c (objc_language_defn): Likewise.
6172 * opencl-lang.c (opencl_language_defn): Likewise.
6173 * p-lang.c (pascal_language_defn): Likewise.
6174 * rust-lang.c (rust_language_defn): Likewise.
6176 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6178 * riscv-tdep.c (riscv_type_align): New function.
6179 (riscv_type_alignment): Delete.
6180 (riscv_arg_location): Use 'type_align'.
6181 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6183 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6185 * gdbtypes.c (type_align): A struct with no non-static fields also
6188 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6190 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6192 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6194 (riscv_struct_info::analyse): New implementation using new
6195 analyse_inner member function.
6196 (riscv_struct_info::field_offset): New member function.
6197 (riscv_struct_info::m_offsets): New member variable.
6198 (riscv_struct_info::analyse_inner): New private member function,
6199 takes the old implementation of riscv_struct_info::analyse but
6200 extended to track field offsets.
6201 (riscv_call_arg_struct): Update the struct folding special cases
6202 to handle cases where empty C++ structs, which are non-zero
6204 (riscv_arg_location): Initialise the length of each location, a
6205 non-zero length now indicates the location is in use.
6206 (riscv_push_dummy_call): Allow for the first location having a
6207 non-zero offset when setting up arguments.
6208 (riscv_return_value): Likewise, but for return values.
6210 2019-04-11 Tom Tromey <tromey@adacore.com>
6212 * utils.c (internal_vproblem): Make "msg" const.
6214 2019-04-11 Alan Hayward <alan.hayward@arm.com>
6216 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6217 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6218 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6219 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6221 2019-04-10 Kevin Buettner <kevinb@redhat.com>
6223 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6225 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6226 of amd64_collect_native_gregset.
6227 (amd64_linux_nat_target::store_registers): Likewise.
6229 2019-04-10 Tom Tromey <tom@tromey.com>
6231 * symtab.c (lookup_global_symbol_from_objfile)
6232 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6233 * objfiles.h (class separate_debug_iterator): New.
6234 (class separate_debug_range): New.
6235 (struct objfile) <separate_debug_objfiles>: New method.
6236 (objfile_separate_debug_iterate): Don't declare.
6237 * objfiles.c (separate_debug_iterator::operator++): Rename from
6238 objfile_separate_debug_iterate.
6239 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6241 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6244 2019-04-10 Tom Tromey <tom@tromey.com>
6246 * symfile.c (reread_symbols): Remove old comment.
6247 * objfiles.c (free_all_objfiles): Fix a typo.
6249 2019-04-10 Tom Tromey <tom@tromey.com>
6251 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6252 * minsyms.c (lookup_minimal_symbol): Use foreach.
6253 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6254 (lookup_minimal_symbol_solib_trampoline): Likewise.
6255 * symfile.c (reread_symbols): Use foreach.
6257 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
6258 Tom Tromey <tromey@adacore.com>
6261 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6262 (rust_lex_int_test): Change "value" to be LONGEST.
6263 (rust_lex_tests): Add test for long integer literal.
6265 2019-04-09 Tom Tromey <tromey@adacore.com>
6267 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6269 (extended_remote_target::attach): Update.
6270 (remote_target::remote_notice_new_inferior): Update.
6271 (remote_target::add_current_inferior_and_thread): Update.
6272 * inferior.c (exit_inferior_1): Use "false".
6273 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6275 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
6277 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6278 the "start" command.
6280 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6282 * python/py-inferior.c (infpy_thread_from_thread_handle):
6283 Adjust comments to reflect renaming of thread_from_thread_handle
6284 to thread_from_handle. Adjust keywords. Fix type error message.
6285 (inferior_object_methods): Add thread_from_handle. Retain
6286 thread_from_thread_handle, but mark it as deprecated.
6288 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6290 * gdbthread.h (find_thread_by_handle): Revise declaration.
6291 * thread.c (find_thread_by_handle): Likewise. Adjust
6293 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6294 support for buffer objects as handles.
6296 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6298 * python/py-infthread.c (thpy_thread_handle): New function.
6299 (thread_object_methods): Register thpy_thread_handle.
6301 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6303 * gdbthread.h (thread_to_thread_handle): Declare.
6304 * thread.c (gdbtypes.h): Include.
6305 (thread_to_thread_handle): New function.
6307 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6308 (target_thread_info_to_thread_handle): Declare.
6309 * target.c (target_thread_info_to_thread_handle): New function.
6310 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6311 * target-delegates.c: Regenerate.
6313 * linux-thread-db.c (class thread_db_target): Add method
6314 thread_info_to_thread_handle.
6315 (thread_db_target::thread_info_to_thread_handle): Define.
6316 * remote.c (class remote_target): Add new method
6317 thread_info_to_thread_handle.
6318 (remote_target::thread_info_to_thread_handle): Define.
6320 2019-04-08 Pedro Alves <palves@redhat.com>
6322 * common/common-exceptions.c (throw_exception): Don't create
6323 named object to throw; throw directly.
6324 (throw_it): Likewise. Don't initialize gdb_exception::message
6325 here, with new; pass FMT and AP to the ctor instead.
6326 * common/common-exceptions.h: Include <string>.
6327 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6328 const char *, va_list)): New ctor. Use std::make_shared.
6329 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6331 (gdb_exception_error::gdb_exception_error(enum errors, const char
6333 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6335 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6337 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6338 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6341 2019-04-08 Tom Tromey <tom@tromey.com>
6343 * valops.c (value_rtti_indirect_type): Replace throw_exception
6345 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6347 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6349 * target.c (target_translate_tls_address): Replace throw_exception
6351 * stack.c (frame_apply_command_count): Replace throw_exception
6353 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6355 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6357 * rs6000-tdep.c (rs6000_frame_cache)
6358 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6359 * remote.c: Replace throw_exception with throw.
6360 * record-full.c (record_full_message, record_full_wait_1)
6361 (record_full_restore): Replace throw_exception with throw.
6363 (get_thread_current_frame_id, record_btrace_start_replaying)
6364 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6365 (cmd_record_btrace_start): Replace throw_exception with throw.
6366 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6368 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6369 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6371 (find_linespec_symbols): Replace throw_exception with throw.
6372 * infrun.c (displaced_step_prepare, resume): Replace
6373 throw_exception with throw.
6374 * infcmd.c (post_create_inferior): Replace throw_exception with
6376 * inf-loop.c (inferior_event_handler): Replace throw_exception
6378 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6379 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6380 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6381 (get_prev_frame_always, get_frame_pc_if_available)
6382 (get_frame_address_in_block_if_available, get_frame_language):
6383 Replace throw_exception with throw.
6384 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6385 throw_exception with throw.
6386 * eval.c (fetch_subexp_value, evaluate_var_value)
6387 (evaluate_funcall, evaluate_subexp_standard): Replace
6388 throw_exception with throw.
6389 * dwarf2loc.c (call_site_find_chain)
6390 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6391 Replace throw_exception with throw.
6392 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6394 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6396 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6397 * completer.c (complete_line_internal): Replace throw_exception
6399 * compile/compile-object-run.c (compile_object_run): Replace
6400 throw_exception with throw.
6401 * cli/cli-script.c (process_next_line): Replace throw_exception
6403 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6404 (btrace_enable, btrace_maint_update_pt_packets): Replace
6405 throw_exception with throw.
6406 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6407 throw_exception with throw.
6408 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6409 throw_exception with throw.
6410 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6411 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6412 * aarch64-tdep.c (aarch64_make_prologue_cache)
6413 (aarch64_make_stub_cache): Replace throw_exception with throw.
6415 2019-04-08 Tom Tromey <tom@tromey.com>
6417 * common/common-exceptions.c (throw_exception): Rename from
6418 throw_exception_cxx. Remove old copy. Make argument const.
6419 (throw_it): Create and throw exception objects directly.
6420 * common/common-exceptions.h (throw_exception): Make argument
6422 (struct gdb_exception_error): Add constructor.
6423 (struct gdb_exception_quit): Add constructor.
6425 2019-04-08 Tom Tromey <tom@tromey.com>
6427 * common/common-exceptions.h (exception_rethrow): Don't declare.
6428 (TRY_SJLJ): Update comment.
6429 (TRY, CATCH, END_CATCH): Remove.
6430 * common/common-exceptions.c (exception_rethrow): Remove.
6432 2019-04-08 Tom Tromey <tom@tromey.com>
6434 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6436 (gdb_exception_error): Rename from
6437 gdb_exception_RETURN_MASK_ERROR.
6438 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6439 (gdb_quit_bad_alloc): Update.
6440 * aarch64-tdep.c: Update.
6441 * ada-lang.c: Update.
6442 * ada-typeprint.c: Update.
6443 * ada-valprint.c: Update.
6444 * amd64-tdep.c: Update.
6445 * arch-utils.c: Update.
6446 * break-catch-throw.c: Update.
6447 * breakpoint.c: Update.
6449 * c-varobj.c: Update.
6450 * cli/cli-cmds.c: Update.
6451 * cli/cli-interp.c: Update.
6452 * cli/cli-script.c: Update.
6453 * common/common-exceptions.c: Update.
6454 * common/new-op.c: Update.
6455 * common/selftest.c: Update.
6456 * compile/compile-c-symbols.c: Update.
6457 * compile/compile-cplus-symbols.c: Update.
6458 * compile/compile-object-load.c: Update.
6459 * compile/compile-object-run.c: Update.
6460 * completer.c: Update.
6461 * corelow.c: Update.
6463 * cp-support.c: Update.
6464 * cp-valprint.c: Update.
6465 * darwin-nat.c: Update.
6466 * disasm-selftests.c: Update.
6467 * dtrace-probe.c: Update.
6468 * dwarf-index-cache.c: Update.
6469 * dwarf-index-write.c: Update.
6470 * dwarf2-frame-tailcall.c: Update.
6471 * dwarf2-frame.c: Update.
6472 * dwarf2loc.c: Update.
6473 * dwarf2read.c: Update.
6475 * event-loop.c: Update.
6476 * event-top.c: Update.
6478 * f-valprint.c: Update.
6479 * fbsd-tdep.c: Update.
6480 * frame-unwind.c: Update.
6482 * gdbtypes.c: Update.
6483 * gnu-v3-abi.c: Update.
6484 * guile/guile-internal.h: Update.
6485 * guile/scm-block.c: Update.
6486 * guile/scm-breakpoint.c: Update.
6487 * guile/scm-cmd.c: Update.
6488 * guile/scm-disasm.c: Update.
6489 * guile/scm-frame.c: Update.
6490 * guile/scm-lazy-string.c: Update.
6491 * guile/scm-math.c: Update.
6492 * guile/scm-param.c: Update.
6493 * guile/scm-ports.c: Update.
6494 * guile/scm-pretty-print.c: Update.
6495 * guile/scm-symbol.c: Update.
6496 * guile/scm-symtab.c: Update.
6497 * guile/scm-type.c: Update.
6498 * guile/scm-value.c: Update.
6499 * i386-linux-tdep.c: Update.
6500 * i386-tdep.c: Update.
6501 * inf-loop.c: Update.
6502 * infcall.c: Update.
6506 * language.c: Update.
6507 * linespec.c: Update.
6508 * linux-fork.c: Update.
6509 * linux-nat.c: Update.
6510 * linux-tdep.c: Update.
6511 * linux-thread-db.c: Update.
6513 * mi/mi-cmd-break.c: Update.
6514 * mi/mi-cmd-stack.c: Update.
6515 * mi/mi-interp.c: Update.
6516 * mi/mi-main.c: Update.
6517 * objc-lang.c: Update.
6518 * p-valprint.c: Update.
6520 * ppc-linux-tdep.c: Update.
6521 * printcmd.c: Update.
6522 * python/py-arch.c: Update.
6523 * python/py-breakpoint.c: Update.
6524 * python/py-cmd.c: Update.
6525 * python/py-finishbreakpoint.c: Update.
6526 * python/py-frame.c: Update.
6527 * python/py-framefilter.c: Update.
6528 * python/py-gdb-readline.c: Update.
6529 * python/py-inferior.c: Update.
6530 * python/py-infthread.c: Update.
6531 * python/py-lazy-string.c: Update.
6532 * python/py-linetable.c: Update.
6533 * python/py-objfile.c: Update.
6534 * python/py-param.c: Update.
6535 * python/py-prettyprint.c: Update.
6536 * python/py-progspace.c: Update.
6537 * python/py-record-btrace.c: Update.
6538 * python/py-record.c: Update.
6539 * python/py-symbol.c: Update.
6540 * python/py-type.c: Update.
6541 * python/py-unwind.c: Update.
6542 * python/py-utils.c: Update.
6543 * python/py-value.c: Update.
6544 * python/python.c: Update.
6545 * record-btrace.c: Update.
6546 * record-full.c: Update.
6547 * remote-fileio.c: Update.
6549 * riscv-tdep.c: Update.
6550 * rs6000-aix-tdep.c: Update.
6551 * rs6000-tdep.c: Update.
6552 * rust-exp.y: Update.
6553 * rust-lang.c: Update.
6554 * s390-tdep.c: Update.
6555 * selftest-arch.c: Update.
6556 * solib-dsbt.c: Update.
6557 * solib-frv.c: Update.
6558 * solib-spu.c: Update.
6559 * solib-svr4.c: Update.
6561 * sparc64-linux-tdep.c: Update.
6563 * symfile-mem.c: Update.
6564 * symmisc.c: Update.
6568 * tracefile-tfile.c: Update.
6569 * tui/tui.c: Update.
6570 * typeprint.c: Update.
6571 * unittests/cli-utils-selftests.c: Update.
6572 * unittests/parse-connection-spec-selftests.c: Update.
6574 * valprint.c: Update.
6577 * windows-nat.c: Update.
6578 * x86-linux-nat.c: Update.
6579 * xml-support.c: Update.
6581 2019-04-08 Tom Tromey <tom@tromey.com>
6583 * xml-support.c: Use C++ exception handling.
6584 * x86-linux-nat.c: Use C++ exception handling.
6585 * windows-nat.c: Use C++ exception handling.
6586 * varobj.c: Use C++ exception handling.
6587 * value.c: Use C++ exception handling.
6588 * valprint.c: Use C++ exception handling.
6589 * valops.c: Use C++ exception handling.
6590 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6592 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6593 * typeprint.c: Use C++ exception handling.
6594 * tui/tui.c: Use C++ exception handling.
6595 * tracefile-tfile.c: Use C++ exception handling.
6596 * top.c: Use C++ exception handling.
6597 * thread.c: Use C++ exception handling.
6598 * target.c: Use C++ exception handling.
6599 * symmisc.c: Use C++ exception handling.
6600 * symfile-mem.c: Use C++ exception handling.
6601 * stack.c: Use C++ exception handling.
6602 * sparc64-linux-tdep.c: Use C++ exception handling.
6603 * solib.c: Use C++ exception handling.
6604 * solib-svr4.c: Use C++ exception handling.
6605 * solib-spu.c: Use C++ exception handling.
6606 * solib-frv.c: Use C++ exception handling.
6607 * solib-dsbt.c: Use C++ exception handling.
6608 * selftest-arch.c: Use C++ exception handling.
6609 * s390-tdep.c: Use C++ exception handling.
6610 * rust-lang.c: Use C++ exception handling.
6611 * rust-exp.y: Use C++ exception handling.
6612 * rs6000-tdep.c: Use C++ exception handling.
6613 * rs6000-aix-tdep.c: Use C++ exception handling.
6614 * riscv-tdep.c: Use C++ exception handling.
6615 * remote.c: Use C++ exception handling.
6616 * remote-fileio.c: Use C++ exception handling.
6617 * record-full.c: Use C++ exception handling.
6618 * record-btrace.c: Use C++ exception handling.
6619 * python/python.c: Use C++ exception handling.
6620 * python/py-value.c: Use C++ exception handling.
6621 * python/py-utils.c: Use C++ exception handling.
6622 * python/py-unwind.c: Use C++ exception handling.
6623 * python/py-type.c: Use C++ exception handling.
6624 * python/py-symbol.c: Use C++ exception handling.
6625 * python/py-record.c: Use C++ exception handling.
6626 * python/py-record-btrace.c: Use C++ exception handling.
6627 * python/py-progspace.c: Use C++ exception handling.
6628 * python/py-prettyprint.c: Use C++ exception handling.
6629 * python/py-param.c: Use C++ exception handling.
6630 * python/py-objfile.c: Use C++ exception handling.
6631 * python/py-linetable.c: Use C++ exception handling.
6632 * python/py-lazy-string.c: Use C++ exception handling.
6633 * python/py-infthread.c: Use C++ exception handling.
6634 * python/py-inferior.c: Use C++ exception handling.
6635 * python/py-gdb-readline.c: Use C++ exception handling.
6636 * python/py-framefilter.c: Use C++ exception handling.
6637 * python/py-frame.c: Use C++ exception handling.
6638 * python/py-finishbreakpoint.c: Use C++ exception handling.
6639 * python/py-cmd.c: Use C++ exception handling.
6640 * python/py-breakpoint.c: Use C++ exception handling.
6641 * python/py-arch.c: Use C++ exception handling.
6642 * printcmd.c: Use C++ exception handling.
6643 * ppc-linux-tdep.c: Use C++ exception handling.
6644 * parse.c: Use C++ exception handling.
6645 * p-valprint.c: Use C++ exception handling.
6646 * objc-lang.c: Use C++ exception handling.
6647 * mi/mi-main.c: Use C++ exception handling.
6648 * mi/mi-interp.c: Use C++ exception handling.
6649 * mi/mi-cmd-stack.c: Use C++ exception handling.
6650 * mi/mi-cmd-break.c: Use C++ exception handling.
6651 * main.c: Use C++ exception handling.
6652 * linux-thread-db.c: Use C++ exception handling.
6653 * linux-tdep.c: Use C++ exception handling.
6654 * linux-nat.c: Use C++ exception handling.
6655 * linux-fork.c: Use C++ exception handling.
6656 * linespec.c: Use C++ exception handling.
6657 * language.c: Use C++ exception handling.
6658 * jit.c: Use C++ exception handling.
6659 * infrun.c: Use C++ exception handling.
6660 * infcmd.c: Use C++ exception handling.
6661 * infcall.c: Use C++ exception handling.
6662 * inf-loop.c: Use C++ exception handling.
6663 * i386-tdep.c: Use C++ exception handling.
6664 * i386-linux-tdep.c: Use C++ exception handling.
6665 * guile/scm-value.c: Use C++ exception handling.
6666 * guile/scm-type.c: Use C++ exception handling.
6667 * guile/scm-symtab.c: Use C++ exception handling.
6668 * guile/scm-symbol.c: Use C++ exception handling.
6669 * guile/scm-pretty-print.c: Use C++ exception handling.
6670 * guile/scm-ports.c: Use C++ exception handling.
6671 * guile/scm-param.c: Use C++ exception handling.
6672 * guile/scm-math.c: Use C++ exception handling.
6673 * guile/scm-lazy-string.c: Use C++ exception handling.
6674 * guile/scm-frame.c: Use C++ exception handling.
6675 * guile/scm-disasm.c: Use C++ exception handling.
6676 * guile/scm-cmd.c: Use C++ exception handling.
6677 * guile/scm-breakpoint.c: Use C++ exception handling.
6678 * guile/scm-block.c: Use C++ exception handling.
6679 * guile/guile-internal.h: Use C++ exception handling.
6680 * gnu-v3-abi.c: Use C++ exception handling.
6681 * gdbtypes.c: Use C++ exception handling.
6682 * frame.c: Use C++ exception handling.
6683 * frame-unwind.c: Use C++ exception handling.
6684 * fbsd-tdep.c: Use C++ exception handling.
6685 * f-valprint.c: Use C++ exception handling.
6686 * exec.c: Use C++ exception handling.
6687 * event-top.c: Use C++ exception handling.
6688 * event-loop.c: Use C++ exception handling.
6689 * eval.c: Use C++ exception handling.
6690 * dwarf2read.c: Use C++ exception handling.
6691 * dwarf2loc.c: Use C++ exception handling.
6692 * dwarf2-frame.c: Use C++ exception handling.
6693 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6694 * dwarf-index-write.c: Use C++ exception handling.
6695 * dwarf-index-cache.c: Use C++ exception handling.
6696 * dtrace-probe.c: Use C++ exception handling.
6697 * disasm-selftests.c: Use C++ exception handling.
6698 * darwin-nat.c: Use C++ exception handling.
6699 * cp-valprint.c: Use C++ exception handling.
6700 * cp-support.c: Use C++ exception handling.
6701 * cp-abi.c: Use C++ exception handling.
6702 * corelow.c: Use C++ exception handling.
6703 * completer.c: Use C++ exception handling.
6704 * compile/compile-object-run.c: Use C++ exception handling.
6705 * compile/compile-object-load.c: Use C++ exception handling.
6706 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6707 * compile/compile-c-symbols.c: Use C++ exception handling.
6708 * common/selftest.c: Use C++ exception handling.
6709 * common/new-op.c: Use C++ exception handling.
6710 * cli/cli-script.c: Use C++ exception handling.
6711 * cli/cli-interp.c: Use C++ exception handling.
6712 * cli/cli-cmds.c: Use C++ exception handling.
6713 * c-varobj.c: Use C++ exception handling.
6714 * btrace.c: Use C++ exception handling.
6715 * breakpoint.c: Use C++ exception handling.
6716 * break-catch-throw.c: Use C++ exception handling.
6717 * arch-utils.c: Use C++ exception handling.
6718 * amd64-tdep.c: Use C++ exception handling.
6719 * ada-valprint.c: Use C++ exception handling.
6720 * ada-typeprint.c: Use C++ exception handling.
6721 * ada-lang.c: Use C++ exception handling.
6722 * aarch64-tdep.c: Use C++ exception handling.
6724 2019-04-08 Tom Tromey <tom@tromey.com>
6726 * xml-support.c (gdb_xml_parser::parse): Update.
6727 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6728 * value.c (show_convenience): Update.
6729 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6730 (test_parse_flags_qcs): Update.
6731 * thread.c (thr_try_catch_cmd): Update.
6732 * target.c (target_translate_tls_address): Update.
6733 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6734 (info_frame_command_core, frame_apply_command_count): Update.
6735 * rust-exp.y (rust_lex_exception_test): Update.
6736 * riscv-tdep.c (riscv_print_one_register_info): Update.
6737 * remote.c (remote_target::enable_btrace): Update.
6738 * record-btrace.c (record_btrace_enable_warn): Update.
6739 * python/py-utils.c (gdbpy_convert_exception): Update.
6740 * printcmd.c (do_one_display, print_variable_and_value): Update.
6741 * mi/mi-main.c (mi_print_exception): Update.
6742 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6743 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6744 * linux-nat.c (linux_nat_target::attach): Update.
6745 * linux-fork.c (class scoped_switch_fork_info): Update.
6746 * infrun.c (displaced_step_prepare): Update.
6747 * infcall.c (call_function_by_hand_dummy): Update.
6748 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6749 * gnu-v3-abi.c (print_one_vtable): Update.
6750 * frame.c (get_prev_frame_always): Update.
6751 * f-valprint.c (info_common_command_for_block): Update.
6752 * exec.c (try_open_exec_file): Update.
6753 * exceptions.c (print_exception, exception_print)
6754 (exception_fprintf, exception_print_same): Update.
6755 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6756 * dwarf-index-cache.c (index_cache::store)
6757 (index_cache::lookup_gdb_index): Update.
6758 * darwin-nat.c (maybe_cache_shell): Update.
6759 * cp-valprint.c (cp_print_value_fields): Update.
6760 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6761 (gcc_cplus_symbol_address): Update.
6762 * compile/compile-c-symbols.c (gcc_convert_symbol)
6763 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6764 * common/selftest.c: Update.
6765 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6767 (exception_try_scope_entry, exception_try_scope_exit): Don't
6769 (struct exception_try_scope): Remove.
6770 (TRY): Don't use exception_try_scope.
6771 (struct gdb_exception): Add constructor, operator=.
6773 (struct gdb_exception_RETURN_MASK_ALL)
6774 (struct gdb_exception_RETURN_MASK_ERROR)
6775 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6776 (struct gdb_quit_bad_alloc): Update.
6777 * common/common-exceptions.c (exception_none): Change
6779 (struct catcher) <state, exception>: Initialize inline.
6780 <prev>: Remove member.
6781 (current_catcher): Remove.
6782 (catchers): New global.
6783 (exceptions_state_mc_init): Simplify.
6784 (catcher_pop): Remove.
6785 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6786 (try_scope_depth, exception_try_scope_entry)
6787 (exception_try_scope_exit): Remove.
6788 (throw_exception_sjlj): Update.
6789 (exception_messages, exception_messages_size): Remove.
6790 (throw_it): Simplify.
6791 (gdb_exception_sliced_copy): Remove.
6792 (throw_exception_cxx): Update.
6793 * cli/cli-script.c (script_from_file): Update.
6794 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6796 * ada-valprint.c (ada_val_print): Update.
6797 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6798 (create_excep_cond_exprs): Update.
6800 2019-04-08 Tom Tromey <tom@tromey.com>
6802 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6803 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6804 (TRY, CATCH, END_CATCH): Remove some definitions.
6805 * common/common-exceptions.c: Don't use GDB_XCPT.
6806 (catcher_list_size): Remove.
6807 (throw_exception, throw_it): Simplify.
6809 2019-04-05 Tom Tromey <tom@tromey.com>
6811 Revert the header-sorting patch.
6812 * ft32-tdep.c: Revert.
6813 * frv-tdep.c: Revert.
6814 * frv-linux-tdep.c: Revert.
6816 * frame-unwind.c: Revert.
6817 * frame-base.c: Revert.
6818 * fork-child.c: Revert.
6819 * findvar.c: Revert.
6820 * findcmd.c: Revert.
6821 * filesystem.c: Revert.
6822 * filename-seen-cache.h: Revert.
6823 * filename-seen-cache.c: Revert.
6824 * fbsd-tdep.c: Revert.
6825 * fbsd-nat.h: Revert.
6826 * fbsd-nat.c: Revert.
6827 * f-valprint.c: Revert.
6828 * f-typeprint.c: Revert.
6830 * extension.h: Revert.
6831 * extension.c: Revert.
6832 * extension-priv.h: Revert.
6833 * expprint.c: Revert.
6836 * exceptions.c: Revert.
6837 * event-top.c: Revert.
6838 * event-loop.c: Revert.
6840 * elfread.c: Revert.
6841 * dwarf2read.h: Revert.
6842 * dwarf2read.c: Revert.
6843 * dwarf2loc.c: Revert.
6844 * dwarf2expr.h: Revert.
6845 * dwarf2expr.c: Revert.
6846 * dwarf2-frame.c: Revert.
6847 * dwarf2-frame-tailcall.c: Revert.
6848 * dwarf-index-write.h: Revert.
6849 * dwarf-index-write.c: Revert.
6850 * dwarf-index-common.c: Revert.
6851 * dwarf-index-cache.h: Revert.
6852 * dwarf-index-cache.c: Revert.
6853 * dummy-frame.c: Revert.
6854 * dtrace-probe.c: Revert.
6857 * disasm-selftests.c: Revert.
6858 * dictionary.c: Revert.
6859 * dicos-tdep.c: Revert.
6860 * demangle.c: Revert.
6863 * darwin-nat.h: Revert.
6864 * darwin-nat.c: Revert.
6865 * darwin-nat-info.c: Revert.
6866 * d-valprint.c: Revert.
6867 * d-namespace.c: Revert.
6870 * csky-tdep.c: Revert.
6871 * csky-linux-tdep.c: Revert.
6872 * cris-tdep.c: Revert.
6873 * cris-linux-tdep.c: Revert.
6874 * cp-valprint.c: Revert.
6875 * cp-support.c: Revert.
6876 * cp-namespace.c: Revert.
6878 * corelow.c: Revert.
6879 * corefile.c: Revert.
6880 * continuations.c: Revert.
6881 * completer.h: Revert.
6882 * completer.c: Revert.
6883 * complaints.c: Revert.
6884 * coffread.c: Revert.
6885 * coff-pe-read.c: Revert.
6886 * cli-out.h: Revert.
6887 * cli-out.c: Revert.
6888 * charset.c: Revert.
6889 * c-varobj.c: Revert.
6890 * c-valprint.c: Revert.
6891 * c-typeprint.c: Revert.
6893 * buildsym.c: Revert.
6894 * buildsym-legacy.c: Revert.
6895 * build-id.h: Revert.
6896 * build-id.c: Revert.
6898 * bsd-uthread.c: Revert.
6899 * breakpoint.h: Revert.
6900 * breakpoint.c: Revert.
6901 * break-catch-throw.c: Revert.
6902 * break-catch-syscall.c: Revert.
6903 * break-catch-sig.c: Revert.
6904 * blockframe.c: Revert.
6906 * bfin-tdep.c: Revert.
6907 * bfin-linux-tdep.c: Revert.
6908 * bfd-target.c: Revert.
6910 * ax-general.c: Revert.
6913 * avr-tdep.c: Revert.
6915 * auto-load.c: Revert.
6916 * arm-wince-tdep.c: Revert.
6917 * arm-tdep.c: Revert.
6918 * arm-symbian-tdep.c: Revert.
6919 * arm-pikeos-tdep.c: Revert.
6920 * arm-obsd-tdep.c: Revert.
6921 * arm-nbsd-tdep.c: Revert.
6922 * arm-nbsd-nat.c: Revert.
6923 * arm-linux-tdep.c: Revert.
6924 * arm-linux-nat.c: Revert.
6925 * arm-fbsd-tdep.c: Revert.
6926 * arm-fbsd-nat.c: Revert.
6927 * arm-bsd-tdep.c: Revert.
6928 * arch-utils.c: Revert.
6929 * arc-tdep.c: Revert.
6930 * arc-newlib-tdep.c: Revert.
6931 * annotate.h: Revert.
6932 * annotate.c: Revert.
6933 * amd64-windows-tdep.c: Revert.
6934 * amd64-windows-nat.c: Revert.
6935 * amd64-tdep.c: Revert.
6936 * amd64-sol2-tdep.c: Revert.
6937 * amd64-obsd-tdep.c: Revert.
6938 * amd64-obsd-nat.c: Revert.
6939 * amd64-nbsd-tdep.c: Revert.
6940 * amd64-nbsd-nat.c: Revert.
6941 * amd64-nat.c: Revert.
6942 * amd64-linux-tdep.c: Revert.
6943 * amd64-linux-nat.c: Revert.
6944 * amd64-fbsd-tdep.c: Revert.
6945 * amd64-fbsd-nat.c: Revert.
6946 * amd64-dicos-tdep.c: Revert.
6947 * amd64-darwin-tdep.c: Revert.
6948 * amd64-bsd-nat.c: Revert.
6949 * alpha-tdep.c: Revert.
6950 * alpha-obsd-tdep.c: Revert.
6951 * alpha-nbsd-tdep.c: Revert.
6952 * alpha-mdebug-tdep.c: Revert.
6953 * alpha-linux-tdep.c: Revert.
6954 * alpha-linux-nat.c: Revert.
6955 * alpha-bsd-tdep.c: Revert.
6956 * alpha-bsd-nat.c: Revert.
6957 * aix-thread.c: Revert.
6959 * addrmap.c: Revert.
6960 * ada-varobj.c: Revert.
6961 * ada-valprint.c: Revert.
6962 * ada-typeprint.c: Revert.
6963 * ada-tasks.c: Revert.
6964 * ada-lang.c: Revert.
6965 * aarch64-tdep.c: Revert.
6966 * aarch64-ravenscar-thread.c: Revert.
6967 * aarch64-newlib-tdep.c: Revert.
6968 * aarch64-linux-tdep.c: Revert.
6969 * aarch64-linux-nat.c: Revert.
6970 * aarch64-fbsd-tdep.c: Revert.
6971 * aarch64-fbsd-nat.c: Revert.
6972 * aarch32-linux-nat.c: Revert.
6974 2019-04-05 Tom Tromey <tom@tromey.com>
6976 * ft32-tdep.c: Sort headers.
6977 * frv-tdep.c: Sort headers.
6978 * frv-linux-tdep.c: Sort headers.
6979 * frame.c: Sort headers.
6980 * frame-unwind.c: Sort headers.
6981 * frame-base.c: Sort headers.
6982 * fork-child.c: Sort headers.
6983 * findvar.c: Sort headers.
6984 * findcmd.c: Sort headers.
6985 * filesystem.c: Sort headers.
6986 * filename-seen-cache.h: Sort headers.
6987 * filename-seen-cache.c: Sort headers.
6988 * fbsd-tdep.c: Sort headers.
6989 * fbsd-nat.h: Sort headers.
6990 * fbsd-nat.c: Sort headers.
6991 * f-valprint.c: Sort headers.
6992 * f-typeprint.c: Sort headers.
6993 * f-lang.c: Sort headers.
6994 * extension.h: Sort headers.
6995 * extension.c: Sort headers.
6996 * extension-priv.h: Sort headers.
6997 * expprint.c: Sort headers.
6998 * exec.h: Sort headers.
6999 * exec.c: Sort headers.
7000 * exceptions.c: Sort headers.
7001 * event-top.c: Sort headers.
7002 * event-loop.c: Sort headers.
7003 * eval.c: Sort headers.
7004 * elfread.c: Sort headers.
7005 * dwarf2read.h: Sort headers.
7006 * dwarf2read.c: Sort headers.
7007 * dwarf2loc.c: Sort headers.
7008 * dwarf2expr.h: Sort headers.
7009 * dwarf2expr.c: Sort headers.
7010 * dwarf2-frame.c: Sort headers.
7011 * dwarf2-frame-tailcall.c: Sort headers.
7012 * dwarf-index-write.h: Sort headers.
7013 * dwarf-index-write.c: Sort headers.
7014 * dwarf-index-common.c: Sort headers.
7015 * dwarf-index-cache.h: Sort headers.
7016 * dwarf-index-cache.c: Sort headers.
7017 * dummy-frame.c: Sort headers.
7018 * dtrace-probe.c: Sort headers.
7019 * disasm.h: Sort headers.
7020 * disasm.c: Sort headers.
7021 * disasm-selftests.c: Sort headers.
7022 * dictionary.c: Sort headers.
7023 * dicos-tdep.c: Sort headers.
7024 * demangle.c: Sort headers.
7025 * dcache.h: Sort headers.
7026 * dcache.c: Sort headers.
7027 * darwin-nat.h: Sort headers.
7028 * darwin-nat.c: Sort headers.
7029 * darwin-nat-info.c: Sort headers.
7030 * d-valprint.c: Sort headers.
7031 * d-namespace.c: Sort headers.
7032 * d-lang.c: Sort headers.
7033 * ctf.c: Sort headers.
7034 * csky-tdep.c: Sort headers.
7035 * csky-linux-tdep.c: Sort headers.
7036 * cris-tdep.c: Sort headers.
7037 * cris-linux-tdep.c: Sort headers.
7038 * cp-valprint.c: Sort headers.
7039 * cp-support.c: Sort headers.
7040 * cp-namespace.c: Sort headers.
7041 * cp-abi.c: Sort headers.
7042 * corelow.c: Sort headers.
7043 * corefile.c: Sort headers.
7044 * continuations.c: Sort headers.
7045 * completer.h: Sort headers.
7046 * completer.c: Sort headers.
7047 * complaints.c: Sort headers.
7048 * coffread.c: Sort headers.
7049 * coff-pe-read.c: Sort headers.
7050 * cli-out.h: Sort headers.
7051 * cli-out.c: Sort headers.
7052 * charset.c: Sort headers.
7053 * c-varobj.c: Sort headers.
7054 * c-valprint.c: Sort headers.
7055 * c-typeprint.c: Sort headers.
7056 * c-lang.c: Sort headers.
7057 * buildsym.c: Sort headers.
7058 * buildsym-legacy.c: Sort headers.
7059 * build-id.h: Sort headers.
7060 * build-id.c: Sort headers.
7061 * btrace.c: Sort headers.
7062 * bsd-uthread.c: Sort headers.
7063 * breakpoint.h: Sort headers.
7064 * breakpoint.c: Sort headers.
7065 * break-catch-throw.c: Sort headers.
7066 * break-catch-syscall.c: Sort headers.
7067 * break-catch-sig.c: Sort headers.
7068 * blockframe.c: Sort headers.
7069 * block.c: Sort headers.
7070 * bfin-tdep.c: Sort headers.
7071 * bfin-linux-tdep.c: Sort headers.
7072 * bfd-target.c: Sort headers.
7073 * bcache.c: Sort headers.
7074 * ax-general.c: Sort headers.
7075 * ax-gdb.h: Sort headers.
7076 * ax-gdb.c: Sort headers.
7077 * avr-tdep.c: Sort headers.
7078 * auxv.c: Sort headers.
7079 * auto-load.c: Sort headers.
7080 * arm-wince-tdep.c: Sort headers.
7081 * arm-tdep.c: Sort headers.
7082 * arm-symbian-tdep.c: Sort headers.
7083 * arm-pikeos-tdep.c: Sort headers.
7084 * arm-obsd-tdep.c: Sort headers.
7085 * arm-nbsd-tdep.c: Sort headers.
7086 * arm-nbsd-nat.c: Sort headers.
7087 * arm-linux-tdep.c: Sort headers.
7088 * arm-linux-nat.c: Sort headers.
7089 * arm-fbsd-tdep.c: Sort headers.
7090 * arm-fbsd-nat.c: Sort headers.
7091 * arm-bsd-tdep.c: Sort headers.
7092 * arch-utils.c: Sort headers.
7093 * arc-tdep.c: Sort headers.
7094 * arc-newlib-tdep.c: Sort headers.
7095 * annotate.h: Sort headers.
7096 * annotate.c: Sort headers.
7097 * amd64-windows-tdep.c: Sort headers.
7098 * amd64-windows-nat.c: Sort headers.
7099 * amd64-tdep.c: Sort headers.
7100 * amd64-sol2-tdep.c: Sort headers.
7101 * amd64-obsd-tdep.c: Sort headers.
7102 * amd64-obsd-nat.c: Sort headers.
7103 * amd64-nbsd-tdep.c: Sort headers.
7104 * amd64-nbsd-nat.c: Sort headers.
7105 * amd64-nat.c: Sort headers.
7106 * amd64-linux-tdep.c: Sort headers.
7107 * amd64-linux-nat.c: Sort headers.
7108 * amd64-fbsd-tdep.c: Sort headers.
7109 * amd64-fbsd-nat.c: Sort headers.
7110 * amd64-dicos-tdep.c: Sort headers.
7111 * amd64-darwin-tdep.c: Sort headers.
7112 * amd64-bsd-nat.c: Sort headers.
7113 * alpha-tdep.c: Sort headers.
7114 * alpha-obsd-tdep.c: Sort headers.
7115 * alpha-nbsd-tdep.c: Sort headers.
7116 * alpha-mdebug-tdep.c: Sort headers.
7117 * alpha-linux-tdep.c: Sort headers.
7118 * alpha-linux-nat.c: Sort headers.
7119 * alpha-bsd-tdep.c: Sort headers.
7120 * alpha-bsd-nat.c: Sort headers.
7121 * aix-thread.c: Sort headers.
7122 * agent.c: Sort headers.
7123 * addrmap.c: Sort headers.
7124 * ada-varobj.c: Sort headers.
7125 * ada-valprint.c: Sort headers.
7126 * ada-typeprint.c: Sort headers.
7127 * ada-tasks.c: Sort headers.
7128 * ada-lang.c: Sort headers.
7129 * aarch64-tdep.c: Sort headers.
7130 * aarch64-ravenscar-thread.c: Sort headers.
7131 * aarch64-newlib-tdep.c: Sort headers.
7132 * aarch64-linux-tdep.c: Sort headers.
7133 * aarch64-linux-nat.c: Sort headers.
7134 * aarch64-fbsd-tdep.c: Sort headers.
7135 * aarch64-fbsd-nat.c: Sort headers.
7136 * aarch32-linux-nat.c: Sort headers.
7138 2019-04-04 Tom Tromey <tom@tromey.com>
7140 * varobj.c (varobj_create): Update.
7141 * rust-exp.y (struct rust_parser) <update_innermost_block,
7142 lookup_symbol>: New methods.
7143 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7145 (rust_parser::rust_lookup_type)
7146 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7147 * printcmd.c (display_command, do_one_display): Update.
7148 * parser-defs.h (struct parser_state) <parser_state>: Add
7149 "tracker" parameter.
7150 (block_tracker): New member.
7151 (class innermost_block_tracker) <innermost_block_tracker>: Add
7153 <reset>: Remove method.
7154 (innermost_block): Don't declare.
7155 (null_post_parser): Update.
7156 * parse.c (innermost_block): Remove global.
7157 (write_dollar_variable): Update.
7158 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7159 Remove "tracker_types" parameter.
7160 (parse_expression): Add "tracker" parameter.
7161 (parse_expression_for_completion): Update.
7162 (null_post_parser): Add "tracker" parameter.
7163 * p-exp.y: Update rules.
7164 * m2-exp.y: Update rules.
7165 * language.h (struct language_defn) <la_post_parser>: Add
7166 "tracker" parameter.
7167 * go-exp.y: Update rules.
7168 * f-exp.y: Update rules.
7169 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7171 * d-exp.y: Update rules.
7172 * c-exp.y: Update rules.
7173 * breakpoint.c (set_breakpoint_condition): Create an
7174 innermost_block_tracker.
7175 (watch_command_1): Likewise.
7176 * ada-lang.c (resolve): Add "tracker" parameter.
7177 (resolve_subexp): Likewise.
7178 * ada-exp.y (write_var_from_sym): Update.
7180 2019-04-04 Tom Tromey <tom@tromey.com>
7182 * type-stack.h: New file.
7183 * type-stack.c: New file.
7184 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7186 (insert_into_type_stack, insert_type, push_type, push_type_int)
7187 (insert_type_address_space, pop_type, pop_type_int)
7188 (pop_typelist, pop_type_stack, append_type_stack)
7189 (push_type_stack, get_type_stack, push_typelist)
7190 (follow_type_instance_flags, follow_types): Don't declare.
7191 * parse.c (type_stack): Remove global.
7192 (parse_exp_in_context): Update.
7193 (insert_into_type_stack, insert_type, push_type, push_type_int)
7194 (insert_type_address_space, pop_type, pop_type_int)
7195 (pop_typelist, pop_type_stack, append_type_stack)
7196 (push_type_stack, get_type_stack, push_typelist)
7197 (follow_type_instance_flags, follow_types): Remove (moved to
7199 * f-exp.y (type_stack): New global.
7201 (push_kind_type, f_parse): Update.
7202 * d-exp.y (type_stack): New global.
7205 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7207 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7208 (HFILES_NO_SRCDIR): Add type-stack.h.
7210 2019-04-04 Tom Tromey <tom@tromey.com>
7212 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7213 (rust_parser::convert_ast_to_expression, rust_parse)
7214 (rust_lex_test_completion, rust_lex_tests): Update.
7215 * parser-defs.h (struct expr_completion_state): New.
7216 (struct parser_state) <parser_state>: Add completion parameter.
7217 <mark_struct_expression, mark_completion_tag>: New methods.
7218 <parse_completion, m_completion_state>: New members.
7219 (prefixify_expression, null_post_parser): Update.
7220 (mark_struct_expression, mark_completion_tag): Don't declare.
7221 * parse.c (parse_completion, expout_last_struct)
7222 (expout_tag_completion_type, expout_completion_name): Remove
7224 (parser_state::mark_struct_expression)
7225 (parser_state::mark_completion_tag): Now methods.
7226 (prefixify_expression): Add last_struct parameter.
7227 (prefixify_subexp): Likewise.
7228 (parse_exp_1): Update.
7229 (parse_exp_in_context): Add cstate parameter. Update.
7230 (parse_expression_for_completion): Create an
7231 expr_completion_state.
7232 (null_post_parser): Add "completion" parameter.
7233 * p-exp.y: Update rules.
7235 * language.h (struct language_defn) <la_post_parser>: Add
7236 "completing" parameter.
7237 * go-exp.y: Update rules.
7238 (lex_one_token): Update.
7239 * expression.h (parse_completion): Don't declare.
7240 * d-exp.y: Update rules.
7241 (lex_one_token): Update rules.
7242 * c-exp.y: Update rules.
7243 (lex_one_token): Update.
7244 * ada-lang.c (resolve): Add "parse_completion" parameter.
7245 (resolve_subexp): Likewise.
7246 (ada_resolve_function): Likewise.
7248 2019-04-04 Tom Tromey <tom@tromey.com>
7250 * parser-defs.h (struct parser_state) <start_arglist,
7251 end_arglist>: New methods.
7252 <arglist_len, m_funcall_chain>: New members.
7253 (arglist_len, start_arglist, end_arglist): Don't declare.
7254 * parse.c (arglist_len, funcall_chain): Remove global.
7255 (start_arglist, end_arglist): Remove functions.
7256 (parse_exp_in_context): Update.
7257 * p-exp.y: Update rules.
7258 * m2-exp.y: Update rules.
7259 * go-exp.y: Update rules.
7260 * f-exp.y: Update rules.
7261 * d-exp.y: Update rules.
7262 * c-exp.y: Update rules.
7264 2019-04-04 Tom Tromey <tom@tromey.com>
7266 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7267 lex_operator, push_back>: New methods.
7269 (rust_parser::lex_hex, lex_escape): Rename and update.
7270 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7271 (rust_parser::lex_operator): Rename and update.
7272 (rust_parser::lex_number, rustyylex, rustyyerror)
7273 (rust_lex_test_init, rust_lex_test_sequence)
7274 (rust_lex_test_push_back, rust_lex_tests): Update.
7275 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7277 <lexptr, prev_lexptr>: New members.
7278 (lexptr, prev_lexptr): Don't declare.
7279 * parse.c (lexptr, prev_lexptr): Remove globals.
7280 (parse_exp_in_context): Update.
7281 * p-exp.y (yylex, yyerror): Update.
7282 * m2-exp.y (parse_number, yylex, yyerror): Update.
7283 * go-exp.y (lex_one_token, yyerror): Update.
7284 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7285 * d-exp.y (lex_one_token, yyerror): Update.
7286 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7287 (lex_one_token, yyerror): Update.
7288 * ada-lex.l (YY_INPUT): Update.
7289 (rewind_to_char): Update.
7290 * ada-exp.y (yyerror): Update.
7292 2019-04-04 Tom Tromey <tom@tromey.com>
7294 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7295 * parser-defs.h (struct parser_state) <parser_state>: Add new
7297 <comma_terminates>: New member.
7298 (comma_terminates): Don't declare global.
7299 * parse.c (comma_terminates): Remove global.
7300 (parse_exp_in_context): Update.
7301 * p-exp.y (yylex): Update.
7302 * m2-exp.y (yylex): Update.
7303 * go-exp.y (lex_one_token): Update.
7304 * f-exp.y (yylex): Update.
7305 * d-exp.y (lex_one_token): Update.
7306 * c-exp.y (lex_one_token): Update.
7307 * ada-lex.l: Update.
7309 2019-04-04 Tom Tromey <tom@tromey.com>
7311 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7312 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7313 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7314 * parser-defs.h (paren_depth): Don't declare.
7315 * parse.c (paren_depth): Remove global.
7316 (parse_exp_in_context): Update.
7317 * p-exp.y (paren_depth): New global.
7318 (pascal_parse): Initialize it.
7319 * m2-exp.y (paren_depth): New global.
7320 (m2_parse): Initialize it.
7321 * go-exp.y (paren_depth): New global.
7322 (go_parse): Initialize it.
7323 * f-exp.y (paren_depth): New global.
7324 (f_parse): Initialize it.
7325 * d-exp.y (paren_depth): New global.
7326 (d_parse): Initialize it.
7327 * c-exp.y (paren_depth): New global.
7328 (c_parse): Initialize it.
7329 * ada-lex.l (paren_depth): New global.
7330 (lexer_init): Initialize it.
7332 2019-04-04 Tom Tromey <tom@tromey.com>
7334 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7335 (rust_parser::convert_ast_to_type)
7336 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7337 * parser-defs.h (struct parser_state) <parser_state>: Add
7338 parameters. Initialize new members.
7339 <expression_context_block, expression_context_pc>: New members.
7340 * parse.c (expression_context_block, expression_context_pc):
7342 (parse_exp_in_context): Update.
7343 * p-exp.y: Update all rules.
7345 * m2-exp.y: Update all rules.
7347 * go-exp.y (yylex): Update.
7348 * f-exp.y (yylex): Update.
7349 * d-exp.y: Update all rules.
7351 * c-exp.y: Update all rules.
7352 (lex_one_token, classify_name, yylex, c_parse): Update.
7353 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7355 2019-04-04 Tom Tromey <tom@tromey.com>
7357 * gdbarch.h, gdbarch.c: Rebuild.
7358 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7360 (struct stap_parse_info): Replace "parser_state" with
7362 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7363 (parser_state): New class.
7364 * parse.c (expr_builder): Rename.
7365 (expr_builder::release): Rename.
7366 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7367 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7368 (write_exp_elt_longcst, write_exp_elt_floatcst)
7369 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7370 (write_exp_string_vector, write_exp_bitstring)
7371 (write_exp_msymbol, mark_struct_expression)
7372 (write_dollar_variable)
7373 (insert_type_address_space, increase_expout_size): Replace
7374 "parser_state" with "expr_builder".
7375 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7376 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7377 "parser_state" with "expr_builder".
7379 2019-04-04 Tom Tromey <tom@tromey.com>
7381 * rust-exp.y: Replace "parse_language" with method call.
7383 (yylex): Replace "parse_language" with method call.
7385 (yylex): Replace "parse_language" with method call.
7386 * go-exp.y (classify_name): Replace "parse_language" with method
7388 * f-exp.y (yylex): Replace "parse_language" with method call.
7389 * d-exp.y (lex_one_token): Replace "parse_language" with method
7392 (lex_one_token, classify_name, yylex): Replace "parse_language"
7394 * ada-exp.y (find_primitive_type, type_char)
7395 (type_system_address): Replace "parse_language" with method call.
7397 2019-04-04 Tom Tromey <tom@tromey.com>
7399 * rust-exp.y: Replace "parse_gdbarch" with method call.
7400 * parse.c (write_dollar_variable, insert_type_address_space):
7401 Replace "parse_gdbarch" with method call.
7402 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7404 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7406 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7407 "parse_gdbarch" with method call.
7408 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7410 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7411 "parse_gdbarch" with method call.
7412 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7413 "parse_gdbarch" with method call.
7414 * c-exp.y (parse_type, parse_number, classify_name): Replace
7415 "parse_gdbarch" with method call.
7416 * ada-lex.l: Replace "parse_gdbarch" with method call.
7417 * ada-exp.y (parse_type, find_primitive_type, type_char)
7418 (type_system_address): Replace "parse_gdbarch" with method call.
7420 2019-04-04 Tom Tromey <tom@tromey.com>
7422 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7423 * stap-probe.c (stap_parse_argument): Update.
7424 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7425 initial_size parameter.
7426 * rust-exp.y (rust_lex_tests): Update.
7427 * parse.c (parser_state): Update.
7428 (parse_exp_in_context): Update.
7429 * parser-defs.h (struct parser_state) <parser_state>: Remove
7430 "initial_size" parameter.
7432 2019-04-04 Tom Tromey <tom@tromey.com>
7434 * parser-defs.h (increase_expout_size): Don't declare.
7435 * parse.c (increase_expout_size): Now static.
7437 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7439 * gnu-nat.c (gnu_nat_target::wait): Fix
7440 target_waitstatus_to_string call.
7442 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7444 * eval.c (evaluate_subexp_standard): Handle internal functions
7445 during Fortran function call handling.
7447 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7449 * NEWS: Mention new internal functions.
7450 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7451 (read_base_type): Use dwarf2_init_complex_target_type.
7452 * value.c (creal_internal_fn): New function.
7453 (cimag_internal_fn): New function.
7454 (_initialize_values): Register new internal functions.
7456 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7458 * infrun.c (stop_all_threads): If debug_infrun, always
7459 trace the wait status after wait_one, using
7460 target_waitstatus_to_string and target_pid_to_str.
7461 (handle_inferior_event): Replace various trace of
7462 wait status kind by a single trace.
7463 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7464 wait status kind image by target_waitstatus_to_string.
7465 * target/waitstatus.c (target_waitstatus_to_string): Fix
7468 2019-04-01 Tom Tromey <tromey@adacore.com>
7471 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7473 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7474 Pedro Alves <palves@redhat.com>
7476 * top.c (quit_force): Call 'finalize_values'.
7477 * value.c (finalize_values): New function.
7478 * value.h (finalize_values): Declare.
7480 2019-03-30 Eli Zaretskii <eliz@gnu.org>
7482 * NEWS: Announce $_gdb_major and $_gdb_minor.
7484 * top.c (init_gdb_version_vars): New function.
7485 (gdb_init): Call init_gdb_version_vars.
7487 2019-03-29 Tom Tromey <tromey@adacore.com>
7489 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7490 help text. Remove dead code.
7492 2019-03-29 Keith Seitz <keiths@redhat.com>
7494 From Siddhesh Poyarekar:
7495 * f-lang.h (f77_get_upperbound): Return LONGEST.
7496 (f77_get_lowerbound): Likewise.
7497 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7498 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7500 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7501 plongest to format print it.
7502 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7503 (f77_get_upperbound): Likewise.
7504 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7505 LOWER_BOUND to LONGEST.
7506 (f77_create_arrayprint_offset_tbl): Likewise.
7508 2019-03-29 Keith Seitz <keiths@redhat.com>
7510 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7511 %s/pulongest for TYPE_LENGTH instead of %d in format
7513 * ada-typerint.c (ada_print_type): Likewise.
7514 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7515 * compile/compile-c-support.c (generate_register_struct): Likewise.
7516 * gdbtypes.c (recursive_dump_type): Likewise.
7517 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7518 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7519 instead of %d in format strings.
7520 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7521 to std::min to ULONGEST.
7522 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7523 instead of %d in format strings.
7524 * tracepoint.c (info_scope_command): Likewise.
7525 * typeprint.c (print_offset_data::update)
7526 (print_offset_data::finish): Likewise.
7527 * xtensa-tdep.c (xtensa_store_return_value)
7528 (xtensa_push_dummy_call): Likewise.
7530 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7532 * windows-nat.c (display_selector): Fixed format specifications
7535 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7537 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7539 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7541 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7542 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7543 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7544 (nios2_linux_init_abi): Install it.
7546 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7548 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7550 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7552 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7554 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7555 Tom Tromey <tromey@adacore.com>
7557 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7559 2019-03-26 Joel Brobecker <brobecker@adacore.com>
7561 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7562 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7563 method to compute the bounds of range types. Also print "[evaluated]"
7564 if the bounds' values come from a dynamic evaluation.
7566 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7568 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7569 whitespace when pretty printing is on.
7571 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7573 * ppc-linux-nat.c: Add include.
7575 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7577 * NEWS: Mention AArch64 Pointer Authentication.
7579 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7581 * arm-linux-nat.c: Add include.
7583 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7585 * source-cache.c (source_cache::get_source_lines): Re-read
7586 fullname after calling open_source_file.
7588 2019-03-25 John Baldwin <jhb@FreeBSD.org>
7590 * NEWS: Mention TLS support for FreeBSD.
7592 2019-03-25 Tom Tromey <tromey@adacore.com>
7594 * minsyms.c (BUNCH_SIZE): Update comment.
7595 (~minimal_symbol_reader): Remove old comment.
7596 (compact_minimal_symbols): Update comment.
7597 (minimal_symbol_reader::install): Remove old comment. Update
7600 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7602 * s390-linux-nat.c: Add include.
7604 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7606 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7607 Call linux_get_hwcap.
7608 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7610 (aarch64_linux_get_hwcap): Remove function.
7611 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7613 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7615 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7616 * linux-tdep.c (linux_get_hwcap): Add function.
7617 (linux_get_hwcap2): Likewise.
7618 * linux-tdep.h (linux_get_hwcap): Add declaration.
7619 (linux_get_hwcap2): Likewise.
7620 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7621 (ppc_linux_get_hwcap2): Likewise.
7622 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7624 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7625 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7626 (ppc_linux_nat_target::read_description): Likewise.
7627 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7628 * s390-linux-nat.c: Likewise.
7629 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7631 2019-03-24 Tom Tromey <tom@tromey.com>
7633 * ada-lang.c (standard_lookup): Simplify initialization.
7634 (ada_lookup_symbol_nonlocal): Simplify return.
7635 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7636 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7637 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7638 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7640 * solib.c (solib_global_lookup): Simplify.
7641 * symtab.c (null_block_symbol): Remove.
7642 (symbol_cache_lookup): Simplify returns.
7643 (lookup_language_this): Simplify returns.
7644 (lookup_symbol_aux): Simplify return.
7645 (lookup_local_symbol): Simplify returns.
7646 (lookup_global_symbol_from_objfile): Simplify return.
7647 (lookup_symbol_in_objfile_symtabs)
7648 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7649 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7650 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7651 * cp-namespace.c (cp_lookup_bare_symbol)
7652 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7653 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7654 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7655 (cp_lookup_symbol_via_imports): Simplify initialization.
7656 (find_symbol_in_baseclass): Likewise.
7657 * symtab.h (null_block_symbol): Remove.
7658 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7659 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7660 (d_lookup_symbol_module): Likewise.
7661 (find_symbol_in_baseclass): Simplify initialization.
7663 2019-03-24 Tom Tromey <tom@tromey.com>
7665 * expression.h: Don't include symtab.h.
7666 (struct block): Forward declare.
7668 2019-03-24 Tom Tromey <tom@tromey.com>
7670 * c-exp.y (typebase): Remove casts.
7671 * gdbtypes.c (lookup_unsigned_typename, )
7672 (lookup_signed_typename): Remove cast.
7673 * eval.c (parse_to_comma_and_eval): Remove cast.
7674 * parse.c (write_dollar_variable): Remove cast.
7675 * block.h (struct block) <superblock>: Now const.
7676 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7677 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7678 (map_block): Make "block" const.
7679 * symfile.h (struct quick_symbol_functions)
7680 <map_matching_symbols>: Constify block argument to "callback".
7681 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7683 (find_pc_sect_compunit_symtab): Make "b" const.
7684 (find_symbol_at_address): Likewise.
7685 (search_symbols): Likewise.
7686 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7687 (dw2_debug_names_lookup_symbol): Likewise.
7688 (dw2_map_matching_symbols): Update.
7689 * p-valprint.c (pascal_val_print): Remove "block".
7690 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7691 (aux_add_nonlocal_symbols): Make "block" const.
7692 (resolve_subexp): Remove cast.
7693 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7695 (iterate_over_file_blocks): Likewise.
7696 * f-exp.y (%union) <bval>: Remove.
7697 * coffread.c (patch_opaque_types): Make "b" const.
7698 * spu-tdep.c (spu_catch_start): Make "block" const.
7699 * c-valprint.c (print_unpacked_pointer): Remove "block".
7700 * symmisc.c (dump_symtab_1): Make "b" const.
7701 (block_depth): Make "block" const.
7702 * d-exp.y (%union) <bval>: Remove.
7703 * cp-support.h (cp_lookup_rtti_type): Update.
7704 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7705 * psymtab.c (psym_lookup_symbol): Make "block" const.
7706 (maintenance_check_psymtabs): Make "b" const.
7707 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7708 (enumerate_locals, enumerate_args): Update.
7709 * python/py-symtab.c (stpy_global_block): Make "block" const.
7710 (stpy_static_block): Likewise.
7711 * inline-frame.c (block_starting_point_at): Make "new_block"
7713 * block.c (find_block_in_blockvector): Make return type const.
7714 (blockvector_for_pc_sect): Make "b" const.
7715 (find_block_in_blockvector): Make "b" const.
7717 2019-03-23 Tom Tromey <tom@tromey.com>
7719 * varobj.c (varobj_create): Update.
7720 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7721 * printcmd.c (display_command, do_one_display): Don't reset
7723 * parser-defs.h (enum innermost_block_tracker_type): Move to
7725 (innermost_block): Update comment.
7726 * parse.c (parse_exp_1): Add tracker_types parameter.
7727 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7728 tracker_types parameter. Reset innermost_block.
7729 (parse_exp_in_context): Remove.
7730 (parse_expression_for_completion): Update.
7731 * objfiles.c (~objfile): Don't reset expression_context_block or
7733 * expression.h (enum innermost_block_tracker_type): Move from
7735 (parse_exp_1): Add tracker_types parameter.
7736 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7737 reset innermost_block.
7739 2019-03-23 Tom Tromey <tom@tromey.com>
7741 * objfiles.h: Include bcache.h.
7743 2019-03-23 Tom Tromey <tom@tromey.com>
7745 * linespec.c (get_current_search_block): Use
7746 scoped_restore_current_language.
7747 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7749 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7750 Jiong Wang <jiong.wang@arm.com>
7752 * aarch64-linux-tdep.c
7753 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7755 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7757 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7758 Jiong Wang <jiong.wang@arm.com>
7760 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7762 (aarch64_analyze_prologue_test): Add PACIASP test.
7763 (aarch64_prologue_prev_register): Unmask PC value.
7765 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7766 Jiong Wang <jiong.wang@arm.com>
7768 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7769 (aarch64_dwarf2_prev_register): Unmask PC value.
7770 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7771 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7772 DW_CFA_AARCH64_negate_ra_state.
7773 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7775 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7776 Jiong Wang <jiong.wang@arm.com>
7778 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7780 (aarch64_pseudo_register_name): Likewise.
7781 (aarch64_pseudo_register_type): Likewise.
7782 (aarch64_pseudo_register_reggroup_p): Likewise.
7783 (aarch64_gdbarch_init): Add pauth registers.
7784 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7785 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7786 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7787 (struct gdbarch_tdep): Add regnum for ra_state.
7789 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7790 Jiong Wang <jiong.wang@arm.com>
7792 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7794 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7795 Jiong Wang <jiong.wang@arm.com>
7797 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7799 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7800 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7801 (aarch64_gdbarch_init): Add puth registers.
7802 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7803 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7804 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7806 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7807 Jiong Wang <jiong.wang@arm.com>
7809 * aarch64-linux-nat.c
7810 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7811 * aarch64-linux-tdep.c
7812 (aarch64_linux_core_read_description): Likewise.
7813 (aarch64_linux_get_hwcap): New function.
7814 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7815 (aarch64_linux_get_hwcap): New declaration.
7817 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7818 Jiong Wang <jiong.wang@arm.com>
7820 * aarch64-linux-nat.c
7821 (aarch64_linux_nat_target::read_description): Add pauth param.
7822 * aarch64-linux-tdep.c
7823 (aarch64_linux_core_read_description): Likewise.
7824 * aarch64-tdep.c (struct target_desc): Add in pauth.
7825 (aarch64_read_description): Add pauth param.
7826 (aarch64_gdbarch_init): Likewise.
7827 * aarch64-tdep.h (aarch64_read_description): Likewise.
7828 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7829 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7830 * features/Makefile: Add new files.
7831 * features/aarch64-pauth.c: New file.
7832 * features/aarch64-pauth.xml: New file.
7834 2019-03-20 Tom Tromey <tromey@adacore.com>
7836 * infrun.c (handle_inferior_event): Rename from
7837 handle_inferior_event_1. Create a scoped_value_mark.
7838 (handle_inferior_event): Remove.
7840 2019-03-19 Tom Tromey <tromey@adacore.com>
7842 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7843 * infrun.h (print_stop_event): Add "displays" parameter.
7844 * infrun.c (print_stop_event): Add "displays" parameter.
7846 2019-03-19 Pedro Alves <palves@redhat.com>
7848 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7849 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7850 to -1. Fix TABs vs spaces.
7851 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7852 * tui/tui-out.h (tui_ui_out) Add intro comments.
7853 <m_line, m_start_of_line>: In-class initialize, and add describing
7856 2019-03-18 Alan Hayward <alan.hayward@arm.com>
7858 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7860 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7862 2019-03-18 Pedro Alves <palves@redhat.com>
7863 Eli Zaretskii <eliz@gnu.org>
7865 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7866 m_line and m_start_of_line.
7868 2019-03-18 Eli Zaretskii <eliz@gnu.org>
7870 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7871 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7872 it returns a newline. This fixes a regression in TU mode, whereby
7873 the next line is output on the same screen line as the user input.
7875 2019-03-18 Tom Tromey <tromey@adacore.com>
7877 * minsyms.c (minimal_symbol_reader::install): Remove call to
7880 2019-03-18 Pedro Alves <palves@redhat.com>
7882 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7884 (apply_style): New, factored out from ...
7885 (apply_ansi_escape): ... this. Handle reverse video mode.
7886 (tui_set_reverse_mode): New function.
7887 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7888 * tui/tui-winsource.c (tui_show_source_line): Use
7889 tui_set_reverse_mode instead of setting A_STANDOUT.
7890 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7893 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
7895 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7898 2019-03-18 Tom Tromey <tromey@adacore.com>
7900 * ada-lang.c (empty_array): Add "high" parameter.
7901 (ada_evaluate_subexp): Update.
7903 2019-03-17 Sergei Trofimovich <siarheit@google.com>
7905 * unittests/string_view-selftests.c: Define
7906 _initialize_string_view_selftests unconditionally.
7908 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7911 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7913 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7916 * windows-nat.c (display_selector): Fix format specifiers.
7918 2019-03-17 Eli Zaretskii <eliz@gnu.org>
7920 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7921 tui_refill_source_window instead of tui_refresh_win, to update the
7922 current execution line. This fixes redisplay of the current line
7923 when stepping through the code with "next" or "step".
7925 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7927 * source-cache.c (source_cache::get_source_lines): Call
7928 find_source_lines to initialize s->nlines. This fixes vertical
7929 scrolling of TUI source window when the DOWN arrow is pressed.
7931 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7933 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7934 linux-thread-db.c (_initialize_thread_db): Likewise.
7936 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7938 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7939 wclrtoeol in tui_show_source_line". This reverts changes made in
7940 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7942 2019-03-15 Tom Tromey <tom@tromey.com>
7944 * symtab.h (struct minimal_symbol): Derive from
7945 general_symbol_info.
7946 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7947 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7948 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7949 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7950 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7951 (MSYMBOL_SEARCH_NAME): Update.
7952 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7953 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7954 * minsyms.c (minimal_symbol_reader::record_full): Update.
7956 2019-03-15 Tom Tromey <tom@tromey.com>
7958 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7960 2019-03-15 Tom Tromey <tom@tromey.com>
7962 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7964 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7966 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7967 (build_minimal_symbol_hash_tables)
7968 (minimal_symbol_reader::install): Update.
7970 2019-03-15 Tom Tromey <tom@tromey.com>
7972 * symtab.c (create_demangled_names_hash): Update.
7973 (symbol_set_names): Update.
7974 * objfiles.h (struct objfile_per_bfd_storage)
7975 <demangled_names_hash>: Now an htab_up.
7976 * objfiles.c (objfile_per_bfd_storage): Simplify.
7978 2019-03-15 Tom Tromey <tom@tromey.com>
7980 * objfiles.h (struct objfile_per_bfd_storage): Declare
7982 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7984 (get_objfile_bfd_data): Use new. Don't initialize
7986 (free_objfile_per_bfd_storage): Remove.
7987 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7989 2019-03-15 Tom Tromey <tom@tromey.com>
7991 * symfile.c (reread_symbols): Update.
7992 * objfiles.c (objfile::objfile): Update.
7993 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7994 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7996 (minimal_symbol_reader::install): Update.
7997 (terminate_minimal_symbol_table): Remove.
7998 * jit.c (jit_object_close_impl): Update.
8000 2019-03-15 Tom Tromey <tom@tromey.com>
8002 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8005 2019-03-15 Tom Tromey <tom@tromey.com>
8007 * objfiles.h (struct objfile_per_bfd_storage)
8008 <demangled_hash_languages>: Now a bitset.
8009 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8010 (lookup_minimal_symbol): Update.
8012 2019-03-15 Tom Tromey <tom@tromey.com>
8014 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8015 Don't return the symbol.
8016 * coffread.c (record_minimal_symbol): Use record_full.
8018 2019-03-14 Eli Zaretskii <eliz@gnu.org>
8020 The MS-Windows port of ncurses fails to switch to a color pair if
8021 one or both of the colors are the implicit default colors. This
8022 change records the default colors when TUI is initialized, and
8023 then specifies them explicitly when a color pair uses the default
8024 colors. This allows color styling in TUI mode on MS-Windows.
8026 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8028 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8029 colors in ncurses_norm_attr.
8030 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8031 "none", replace it with the default color recorded in
8034 2019-03-14 Tom Tromey <tromey@adacore.com>
8036 * source-cache.h (class source_cache) <get_source_lines>: Return
8038 * source-cache.c (source_cache::extract_lines): Handle case where
8039 first_pos==npos. Return std::string.
8040 (source_cache::get_source_lines): Update.
8042 2019-03-14 Tom Tromey <tromey@adacore.com>
8044 * NEWS: Add item for "style sources" commands.
8045 * source-cache.c (source_cache::get_source_lines): Check
8047 * cli/cli-style.c (source_styling): New global.
8048 (_initialize_cli_style): Add "style sources" commands.
8049 (show_style_sources): New function.
8050 * cli/cli-style.h (source_styling): Declare.
8052 2019-03-14 Pedro Alves <palves@redhat.com>
8053 Tom Tromey <tromey@adacore.com>
8055 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8056 * tui/tui-winsource.c (tui_refill_source_window): New function,
8058 (tui_horizontal_source_scroll): ... here. Move some logic.
8059 * cli/cli-style.c (set_style_enabled): Notify new observable.
8060 * tui/tui-hooks.c (tui_redisplay_source): New function.
8061 (tui_attach_detach_observers): Attach or detach
8062 tui_redisplay_source.
8063 * observable.h (source_styling_changed): New observable.
8064 * observable.c: Define source_styling_changed observable.
8066 2019-03-13 Tom Tromey <tromey@adacore.com>
8068 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8069 (i386_gnu_nat_target::store_registers): Update.
8070 * target-debug.h (target_debug_print_std_string): New macro.
8071 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8072 * windows-tdep.c (display_one_tib): Update.
8073 * tui/tui-stack.c (tui_make_status_line): Update.
8074 * top.c (print_inferior_quit_action): Update.
8075 * thread.c (thr_try_catch_cmd): Update.
8076 (add_thread_with_info): Update.
8077 (thread_target_id_str): Update.
8078 (thr_try_catch_cmd): Update.
8079 (thread_command): Update.
8080 (thread_find_command): Update.
8081 * record-btrace.c (record_btrace_target::info_record)
8082 (record_btrace_resume_thread, record_btrace_target::resume)
8083 (record_btrace_cancel_resume, record_btrace_step_thread)
8084 (record_btrace_target::wait, record_btrace_target::wait)
8085 (record_btrace_target::wait, record_btrace_target::stop): Update.
8086 * progspace.c (print_program_space): Update.
8087 * process-stratum-target.c
8088 (process_stratum_target::thread_address_space): Update.
8089 * linux-fork.c (linux_fork_mourn_inferior)
8090 (detach_checkpoint_command, info_checkpoints_command)
8091 (linux_fork_context): Update.
8092 (linux_fork_detach): Update.
8093 (class scoped_switch_fork_info): Update.
8094 (delete_checkpoint_command): Update.
8095 * infrun.c (follow_fork_inferior): Update.
8096 (follow_fork_inferior): Update.
8097 (proceed_after_vfork_done): Update.
8098 (handle_vfork_child_exec_or_exit): Update.
8099 (follow_exec): Update.
8100 (displaced_step_prepare_throw): Update.
8101 (displaced_step_restore): Update.
8102 (start_step_over): Update.
8104 (clear_proceed_status_thread): Update.
8106 (print_target_wait_results): Update.
8107 (do_target_wait): Update.
8108 (context_switch): Update.
8109 (stop_all_threads): Update.
8110 (restart_threads): Update.
8111 (finish_step_over): Update.
8112 (handle_signal_stop): Update.
8113 (switch_back_to_stepped_thread): Update.
8114 (keep_going_pass_signal): Update.
8115 (print_exited_reason): Update.
8116 (normal_stop): Update.
8117 * inferior.c (inferior_pid_to_str): Change return type.
8118 (print_selected_inferior): Update.
8119 (add_inferior): Update.
8120 (detach_inferior): Update.
8121 * dummy-frame.c (fprint_dummy_frames): Update.
8122 * dcache.c (dcache_info_1): Update.
8123 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8124 (btrace_fetch, btrace_clear): Update.
8125 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8126 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8128 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8129 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8130 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8131 * gdbarch.c, gdbarch.h: Rebuild.
8132 * gdbarch.sh (core_pid_to_str): Change return type.
8133 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8135 (windows_nat_target::pid_to_str): Change return type.
8136 (windows_delete_thread): Update.
8137 (windows_nat_target::attach): Update.
8138 (windows_nat_target::files_info): Update.
8139 * target-delegates.c: Rebuild.
8140 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8142 (sol_thread_target::pid_to_str): Change return type.
8143 * remote.c (class remote_target) <pid_to_str>: Change return
8145 (remote_target::pid_to_str): Change return type.
8146 (extended_remote_target::attach, remote_target::remote_stop_ns)
8147 (remote_target::remote_notif_remove_queued_reply)
8148 (remote_target::push_stop_reply, remote_target::disable_btrace):
8150 (extended_remote_target::attach): Update.
8151 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8153 (gdbsim_target::pid_to_str): Change return type.
8154 * ravenscar-thread.c (struct ravenscar_thread_target)
8155 <pid_to_str>: Change return type.
8156 (ravenscar_thread_target::pid_to_str): Change return type.
8157 * procfs.c (class procfs_target) <pid_to_str>: Change return
8159 (procfs_target::pid_to_str): Change return type.
8160 (procfs_target::attach): Update.
8161 (procfs_target::detach): Update.
8162 (procfs_target::fetch_registers): Update.
8163 (procfs_target::store_registers): Update.
8164 (procfs_target::wait): Update.
8165 (procfs_target::files_info): Update.
8166 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8167 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8169 (nto_procfs_target::pid_to_str): Change return type.
8170 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8171 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8173 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8175 (attach_proc_task_lwp_callback, get_detach_signal)
8176 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8177 (linux_nat_target::resume, wait_lwp, stop_callback)
8178 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8179 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8180 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8181 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8182 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8184 (inf_ptrace_target::attach): Update.
8185 (inf_ptrace_target::files_info): Update.
8186 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8188 (go32_nat_target::pid_to_str): Change return type.
8189 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8190 (gnu_nat_target::wait): Update.
8191 (gnu_nat_target::wait): Update.
8192 (gnu_nat_target::resume): Update.
8193 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8194 (fbsd_nat_target::wait): Update.
8195 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8197 (darwin_nat_target::attach): Update.
8198 * corelow.c (class core_target) <pid_to_str>: Change return type.
8199 (core_target::pid_to_str): Change return type.
8200 * target.c (normal_pid_to_str): Change return type.
8201 (default_pid_to_str): Likewise.
8202 (target_pid_to_str): Change return type.
8203 (target_translate_tls_address): Update.
8204 (target_announce_detach): Update.
8205 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8207 (bsd_uthread_target::pid_to_str): Change return type.
8208 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8210 (bsd_kvm_target::pid_to_str): Change return type.
8211 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8213 (aix_thread_target::pid_to_str): Change return type.
8214 * target.h (struct target_ops) <pid_to_str>: Change return type.
8215 (target_pid_to_str, normal_pid_to_str): Likewise.
8216 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8218 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8220 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8222 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8224 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8226 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8229 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8231 * NEWS: Mention that the new default MI version is 3. Mention
8232 changes to the output of commands and events that deal with
8233 multi-location breakpoints.
8234 * breakpoint.c: Include "mi/mi-out.h".
8235 (print_one_breakpoint): Change output syntax if using MI version
8237 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8239 (mi_multi_location_breakpoint_output_fixed): New.
8240 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8241 (mi_cmd_fix_multi_location_breakpoint_output): New.
8242 (mi_multi_location_breakpoint_output_fixed): New.
8243 * mi/mi-cmds.c (mi_cmds): Register command
8244 -fix-multi-location-breakpoint-output.
8245 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8248 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8250 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8251 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8252 instantiate mi_ui_out based on interpreter name.
8253 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8254 * mi/mi-main.c (mi_load_progress): Likewise.
8256 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8258 * NEWS: Combine separate "New targets" sections for 8.3.
8260 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8262 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8263 (ppcfbsd_init_abi): Install gdbarch
8264 "fetch_tls_load_module_address" and "get_thread_local_address"
8267 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8269 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8270 (riscv_fbsd_init_abi): Install gdbarch
8271 "fetch_tls_load_module_address" and "get_thread_local_address"
8274 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8276 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8277 (i386fbsd_init_abi): Install gdbarch
8278 "fetch_tls_load_module_address" and "get_thread_local_address"
8281 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8283 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8284 (amd64fbsd_init_abi): Install gdbarch
8285 "fetch_tls_load_module_address" and "get_thread_local_address"
8288 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8290 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8291 (struct fbsd_pspace_data): New type.
8292 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8293 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8294 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8295 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8296 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8298 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8300 * gdbtypes.c (lookup_struct_elt): New function.
8301 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8302 * gdbtypes.h (struct struct_elt): New type.
8303 (lookup_struct_elt): New prototype.
8305 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8307 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8308 remove disabled code block.
8310 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8312 * gdbarch.sh (get_thread_local_address): New method.
8313 * gdbarch.h, gdbarch.c: Regenerate.
8314 * target.c (target_translate_tls_address): Use
8315 gdbarch_get_thread_local_address if present instead of
8316 target::get_thread_local_address.
8318 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8320 * target.h (target::get_thread_local_address): Update comment.
8322 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8324 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8325 objfile->separate_debug_objfile_backlink if not NULL.
8327 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8329 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8330 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8331 (amd64bsd_store_inferior_registers): Likewise.
8332 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8333 Enable segment base registers.
8334 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8335 PT_GETFSBASE and PT_GETGSBASE.
8336 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8338 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8339 segment base registers.
8340 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8342 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8344 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8345 Update calls to i386_target_description to add 'segments'
8347 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8348 add segment base registers.
8349 * arch/i386.c (i386_create_target_description): Add 'segments'
8350 parameter to enable segment base registers.
8351 * arch/i386.h (i386_create_target_description): Likewise.
8352 * features/i386/32bit-segments.xml: New file.
8353 * features/i386/32bit-segments.c: Generate.
8354 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8355 call to i386_target_description to add 'segments' parameter.
8356 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8357 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8358 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8359 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8360 if feature is present.
8361 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8362 Add 'segments' parameter to call to i386_target_description.
8363 (i386_target_description): Add 'segments' parameter to enable
8364 segment base registers.
8365 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8366 to call to i386_target_description.
8367 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8368 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8369 Define I386_NUM_REGS.
8370 (i386_target_description): Add 'segments' parameter to enable
8371 segment base registers.
8373 2019-03-12 Eli Zaretskii <eliz@gnu.org>
8376 * source-cache.c: #undef open and close, to avoid unresolved
8377 externals during linking.
8379 2019-03-12 Tom Tromey <tromey@adacore.com>
8381 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8382 const. Add initializers.
8383 (_initialize_remote): Don't initialize ptid globals.
8385 2019-03-12 Pedro Alves <palves@redhat.com>
8387 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8389 2019-03-12 Pedro Alves <palves@redhat.com>
8391 * cp-name-parser.y (main): Remove unused 'len' variable.
8393 2019-03-12 Tom Tromey <tromey@adacore.com>
8395 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8396 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8398 2019-03-12 Tom Tromey <tromey@adacore.com>
8400 * linux-nat.c (iterate_over_lwps): Update.
8401 (stop_callback): Remove parameter.
8402 (stop_wait_callback, detach_callback, resume_set_callback)
8403 (select_singlestep_lwp_callback, set_ignore_sigint)
8404 (status_callback, resumed_callback, resume_clear_callback)
8405 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8407 (linux_nat_target::detach, linux_nat_target::resume)
8408 (linux_stop_and_wait_all_lwps, select_event_lwp)
8409 (linux_nat_filter_event, linux_nat_wait_1)
8410 (linux_nat_target::kill, linux_nat_target::stop)
8411 (linux_nat_target::stop): Update.
8412 (linux_nat_resume_callback): Change type.
8413 (resume_stopped_resumed_lwps, count_events_callback)
8414 (select_event_lwp_callback): Likewise.
8415 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8416 * arm-linux-nat.c (struct update_registers_data): Remove.
8417 (update_registers_callback): Change type.
8418 (arm_linux_insert_hw_breakpoint1): Update.
8419 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8421 (x86_linux_dr_set_addr): Update.
8422 (x86_linux_dr_set_control): Update.
8423 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8424 (iterate_over_lwps): Use gdb::function_view.
8425 * nat/aarch64-linux-hw-point.c (struct
8426 aarch64_dr_update_callback_param): Remove.
8427 (debug_reg_change_callback): Change type.
8428 (aarch64_notify_debug_reg_change): Update.
8429 * s390-linux-nat.c (s390_refresh_per_info): Update.
8431 2019-03-11 Tom Tromey <tromey@adacore.com>
8433 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8434 redundant assignment to "this_cu".
8436 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8438 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8440 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8442 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8444 (rank_one_type): ... this.
8446 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8448 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8450 (rank_one_type): ... this.
8452 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8454 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8456 (rank_one_type): ... this.
8458 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8460 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8462 (rank_one_type): ... this.
8464 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8466 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8468 (rank_one_type): ... this.
8470 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8472 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8474 (rank_one_type): ... this.
8476 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8478 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8480 (rank_one_type): ... this.
8482 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8484 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8486 (rank_one_type): ... this.
8488 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8490 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8492 (rank_one_type): ... this.
8494 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8496 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8498 (rank_one_type): ... this.
8500 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8502 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8504 (rank_one_type): ... this.
8506 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8508 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8510 (rank_one_type): ... this.
8512 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8514 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8515 inferior-events' shows the example events.
8517 2019-03-08 Eli Zaretskii <eliz@gnu.org>
8519 Support styling on native MS-Windows console
8522 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8523 on MS-Windows if $TERM is not defined.
8525 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8527 * posix-hdep.c (gdb_console_fputs):
8528 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8530 * ui-file.h (gdb_console_fputs): Add prototype.
8532 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8533 back to fputs only if the former returns zero.
8535 2019-03-07 Tom Tromey <tom@tromey.com>
8537 * symmisc.c (print_symbol_bcache_statistics): Update.
8538 (print_objfile_statistics): Update.
8539 * symfile.c (allocate_symtab): Update.
8540 * stabsread.c: Don't include bcache.h.
8541 * psymtab.h (struct psymbol_bcache): Don't declare.
8542 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8543 (psymbol_bcache_init, psymbol_bcache_free)
8544 (psymbol_bcache_get_bcache): Don't declare.
8545 * psymtab.c (struct psymbol_bcache): Remove.
8546 (psymtab_storage::psymtab_storage): Update.
8547 (psymtab_storage::~psymtab_storage): Update.
8548 (psymbol_bcache_init, psymbol_bcache_free)
8549 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8550 (add_psymbol_to_bcache): Update.
8551 (allocate_psymtab): Update.
8552 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8553 macro_cache>: No longer pointers.
8554 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8555 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8556 * macrotab.c (macro_bcache): Update.
8557 * macroexp.c: Don't include bcache.h.
8558 * gdbtypes.c (check_types_worklist): Update.
8559 (types_deeply_equal): Remove TRY/CATCH. Update.
8560 * elfread.c (elf_symtab_read): Update.
8561 * dwarf2read.c: Don't include bcache.h.
8562 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8563 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8564 (print_bcache_statistics, bcache_memory_used): Don't declare.
8565 (struct bcache): Move from bcache.c. Add constructor, destructor,
8566 methods. Rename all data members.
8567 * bcache.c (struct bcache): Move to bcache.h.
8568 (bcache::expand_hash_table): Rename from expand_hash_table.
8570 (bcache::insert): Rename from bcache_full.
8571 (bcache::compare): Rename from bcache_compare.
8572 (bcache_xmalloc): Remove.
8573 (bcache::~bcache): Rename from bcache_xfree.
8574 (bcache::print_statistics): Rename from print_bcache_statistics.
8575 (bcache::memory_used): Rename from bcache_memory_used.
8577 2019-03-07 Pedro Alves <palves@redhat.com>
8579 * infrun.c (normal_stop): Also check for
8580 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8582 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8584 * f-lang.c (value_from_host_double): Moved to...
8585 * value.c (value_from_host_double): ...here.
8586 * value.h (value_from_host_double): Declare.
8587 * guile/scm-math.c (vlscm_convert_typed_number): Use
8588 value_from_host_double.
8589 (vlscm_convert_number): Likewise.
8590 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8591 * python/py-value.c (convert_value_from_python): Likewise.
8593 2019-03-06 Tom Tromey <tom@tromey.com>
8595 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8597 2019-03-06 Tom Tromey <tom@tromey.com>
8599 * utils.h (free_current_contents): Don't declare.
8600 * utils.c (free_current_contents): Remove.
8602 2019-03-06 Tom Tromey <tom@tromey.com>
8604 * top.c (quit_force): Update.
8605 * main.c (captured_command_loop): Update.
8606 * common/new-op.c (operator new): Update.
8607 * common/common-exceptions.c (struct catcher)
8608 <save_cleanup_chain>: Remove member.
8609 (exceptions_state_mc_init): Update.
8610 (exception_try_scope_entry): Return nullptr.
8611 (exception_try_scope_exit, exception_rethrow)
8612 (throw_exception_sjlj, throw_exception_cxx): Update.
8613 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8614 (all_cleanups, do_cleanups, discard_cleanups)
8615 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8616 (restore_cleanups, restore_final_cleanups): Don't declare.
8617 (do_final_cleanups): Remove parameter.
8618 * common/cleanups.c (cleanup_chain, make_cleanup)
8619 (make_cleanup_dtor, all_cleanups, do_cleanups)
8620 (discard_my_cleanups, discard_cleanups)
8621 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8622 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8623 (null_cleanup): Remove.
8624 (do_final_cleanups): Remove parameter.
8626 2019-03-06 Tom Tromey <tom@tromey.com>
8628 * remote.c (remote_target::remote_parse_stop_reply): Use
8631 2019-03-06 Tom Tromey <tom@tromey.com>
8633 * stabsread.c (struct stabs_field_info): Rename from field_info.
8634 <list, fnlist>: Add initializers.
8635 <obstack>: New member.
8636 (read_member_functions, read_struct_fields, read_baseclasses):
8637 Allocate on obstack. Don't use cleanups.
8638 (read_one_struct_field, read_member_functions, read_struct_fields)
8639 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8640 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8641 (read_struct_type): Update.
8643 2019-03-06 Tom Tromey <tom@tromey.com>
8645 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8646 * common/filestuff.h (make_cleanup_close): Don't declare.
8647 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8650 2019-03-06 Tom Tromey <tom@tromey.com>
8652 * solib-aix.c: Use make_scope_exit.
8654 2019-03-06 Tom Tromey <tom@tromey.com>
8656 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8657 Use make_scope_exit.
8659 2019-03-06 Tom Tromey <tom@tromey.com>
8661 * solib-svr4.c (disable_probes_interface): Remove parameter.
8662 (svr4_handle_solib_event): Use make_scope_exit.
8664 2019-03-06 Tom Tromey <tom@tromey.com>
8666 * remote.c (struct stop_reply_deleter): Remove.
8667 (stop_reply_up): Update.
8668 (struct stop_reply): Derive from notif_event. Don't typedef.
8669 <regcache>: Now a std::vector.
8670 (stop_reply_xfree): Remove.
8671 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8672 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8673 (remote_target::discard_pending_stop_replies): Use delete.
8674 (remote_target::remote_parse_stop_reply): Update.
8675 (remote_target::process_stop_reply): Update.
8676 * remote-notif.h (struct notif_event): Add virtual destructor.
8677 Remove "dtr" member.
8678 (struct notif_client) <alloc_event>: Return a unique_ptr.
8679 (notif_event_xfree): Don't declare.
8680 (notif_event_up): New typedef.
8681 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8682 (notif_event_xfree, do_notif_event_xfree): Remove.
8683 (remote_notif_state_xfree): Update.
8685 2019-03-06 Tom Tromey <tom@tromey.com>
8687 * infrun.c (displaced_step_clear_cleanup): Now a
8688 forward_scope_exit type.
8689 (displaced_step_prepare_throw): Update.
8690 (displaced_step_fixup): Update.
8692 2019-03-06 Tom Tromey <tom@tromey.com>
8694 * inferior.h (class inferior): Update comment.
8695 * gdbthread.h (class thread_info): Update comment.
8697 2019-03-06 Joel Brobecker <brobecker@adacore.com>
8698 Tom Tromey <tom@tromey.com>
8700 * stabsread.h (struct stab_section_list): Remove.
8701 (coffstab_build_psymtabs): Update.
8702 * dbxread.c (symbuf_sections): Now a std::vector.
8703 (sect_idx): New global.
8704 (fill_symbuf): Update.
8705 (coffstab_build_psymtabs): Change type of stabsects parameter.
8707 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8709 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8710 (coff_locate_sections): Update.
8711 (coff_symfile_read): Remove cleanups. Update.
8712 (init_stringtab): Add storage parameter.
8713 (free_stringtab, free_stringtab_cleanup): Remove.
8714 (init_lineno): Add storage parameter.
8715 (free_linetab, free_linetab_cleanup): Remove.
8717 2019-03-06 Pedro Alves <palves@redhat.com>
8719 * linux-fork.c (fork_info::clobber_regs): Delete.
8720 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8721 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8723 (scoped_switch_fork_info::scoped_switch_fork_info)
8724 (checkpoint_command, linux_fork_context): Adjust
8725 fork_save_infrun_state calls.
8727 2019-03-06 Pedro Alves <palves@redhat.com>
8729 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8730 (inf_has_multiple_threads): Return 'bool' and rewrite using
8731 inferior_info::threads().
8733 2019-03-06 Pedro Alves <palves@redhat.com>
8735 * linux-fork.c: Include <list>.
8736 (fork_list): Now a std::list instance.
8737 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8738 (forks_exist_p, find_last_fork): Adjust.
8742 (free_fork): Delete, folded into fork_info::~fork_info().
8743 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8745 (init_fork_list): Delete.
8746 (linux_fork_killall, linux_fork_mourn_inferior)
8747 (linux_fork_detach, info_checkpoints_command): Adjust.
8748 (_initialize_linux_fork): No longer call init_fork_list.
8750 2019-03-06 Pedro Alves <palves@redhat.com>
8752 * linux-fork.c (new_fork): New, split out of ...
8753 (add_fork): ... this. Return void. Move "first fork" special
8754 case from here, to ...
8755 (checkpoint_command): ... here.
8756 * linux-linux.h (add_fork): Return void.
8758 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8760 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8762 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8763 Chris January <chris.january@arm.com>
8764 David Lecomber <david.lecomber@arm.com>
8766 * f-exp.y: New token, UNOP_INTRINSIC.
8767 (exp): New pattern using UNOP_INTRINSIC token.
8768 (f77_keywords): Add 'abs' keyword.
8769 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8770 (value_from_host_double): New function.
8771 (evaluate_subexp_f): Support UNOP_ABS.
8773 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8775 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8778 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8780 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8781 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8782 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8784 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8786 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8788 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8789 Chris January <chris.january@arm.com>
8791 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8792 * f-exp.y: Define 'KIND' token.
8793 (exp): New pattern for KIND expressions.
8794 (ptype): Handle types with a kind extension.
8795 (direct_abs_decl): Extend to spot kind extensions.
8796 (f77_keywords): Add 'kind' to the list.
8797 (push_kind_type): New function.
8798 (convert_to_kind_type): New function.
8799 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8800 * parse.c (operator_length_standard): Likewise.
8801 * parser-defs.h (enum type_pieces): Add tp_kind.
8802 * std-operator.def: Add UNOP_KIND.
8804 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8806 * f-exp.y (f_parse): Set yydebug.
8808 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8810 * f-lang.c (evaluate_subexp_f): New function.
8811 (exp_descriptor_f): New global.
8812 (f_language_defn): Use exp_descriptor_f instead of
8813 exp_descriptor_standard.
8815 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8817 * f-exp.y (struct token): Add comments.
8818 (dot_ops): Remove uppercase versions and the end marker.
8819 (f77_keywords): Likewise.
8820 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8821 entries in the dot_ops array are case insensitive, and use
8822 strncasecmp to compare strings. Also some whitespace cleanup in
8823 this area. Similar for the f77_keywords array, except entries in
8824 this list might be case sensitive.
8826 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8828 * f-exp.y (struct f77_boolean_val): Add comments.
8829 (boolean_values): Remove uppercase versions, and end marker.
8830 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8831 and use strncasecmp to achieve case insensitivity. Additionally,
8832 perform whitespace cleanup around this code.
8834 2019-03-06 Tom Tromey <tromey@adacore.com>
8836 * remote-sim.c (gdbsim_target_open): Use result of
8839 2019-03-06 Richard Bunt <richard.bunt@arm.com>
8840 Dirk Schubert <dirk.schubert@arm.com>
8841 Chris January <chris.january@arm.com>
8843 * eval.c (evaluate_subexp_standard): Call Fortran argument
8845 * f-lang.c (struct value): A value which can be passed into a
8846 Fortran function call.
8847 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8849 (struct type): Value ready for a Fortran function call.
8850 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8852 * f-lang.h (fortran_argument_convert): Declaration.
8853 (fortran_preserve_arg_pointer): Declaration.
8854 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8856 2019-03-05 Tom Tromey <tromey@adacore.com>
8858 * python/py-prettyprint.c (print_string_repr): Remove #if.
8859 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8861 2019-03-05 Tom Tromey <tromey@adacore.com>
8863 * target.c (the_dummy_target): Move later. Change type to
8865 (initialize_targets): Don't initialize the_dummy_target.
8867 2019-03-05 Tom Tromey <tromey@adacore.com>
8869 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8870 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8872 2019-03-05 Tom Tromey <tromey@adacore.com>
8874 * windows-nat.c (windows_nat_target::attach)
8875 (windows_nat_target::detach): Don't call gdb_flush.
8876 * valprint.c (generic_val_print, val_print, val_print_string):
8877 Don't call gdb_flush.
8878 * utils.c (defaulted_query): Don't call gdb_flush.
8879 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8880 * target.c (target_announce_detach): Don't call gdb_flush.
8881 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8882 * remote.c (extended_remote_target::attach): Don't call
8884 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8885 * printcmd.c (do_examine): Don't call gdb_flush.
8886 (info_display_command): Don't call gdb_flush.
8887 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8888 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8889 * memattr.c (info_mem_command): Don't call gdb_flush.
8890 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8891 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8892 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8893 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8894 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8895 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8896 (gnu_nat_target::detach): Don't call gdb_flush.
8897 * f-valprint.c (f_val_print): Don't call gdb_flush.
8898 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8899 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8900 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8902 * c-valprint.c (c_val_print): Don't call gdb_flush.
8903 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8905 2019-03-05 Tom Tromey <tromey@adacore.com>
8907 * varobj.c (update_dynamic_varobj_children): Update.
8908 (install_default_visualizer): Use reset, not release.
8909 * value.c (set_internalvar): Update.
8910 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8911 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8912 ATTRIBUTE_UNUSED_RESULT.
8914 2019-03-05 Tom Tromey <tromey@adacore.com>
8916 * remote.c (class scoped_remote_fd) <release>: Add
8917 ATTRIBUTE_UNUSED_RESULT.
8919 2019-03-05 Tom Tromey <tromey@adacore.com>
8921 * macroexp.c (struct macro_buffer) <release>: Add
8922 ATTRIBUTE_UNUSED_RESULT.
8924 2019-03-05 Tom Tromey <tromey@adacore.com>
8926 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8927 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8928 ATTRIBUTE_UNUSED_RESULT.
8930 2019-03-05 Tom Tromey <tromey@adacore.com>
8932 * common/scoped_fd.h (class scoped_fd) <release>: Add
8933 ATTRIBUTE_UNUSED_RESULT.
8935 2019-03-05 Tom Tromey <tromey@adacore.com>
8937 * parser-defs.h (struct parser_state) <release>: Add
8938 ATTRIBUTE_UNUSED_RESULT.
8940 2019-03-05 Tom Tromey <tromey@adacore.com>
8942 * utils.h (class gdb_argv) <release>: Add
8943 ATTRIBUTE_UNUSED_RESULT.
8944 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8946 2019-03-02 Eli Zaretskii <eliz@gnu.org>
8948 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8949 for-loop range, to avoid compiler warnings.
8951 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8952 avoid compiler warnings about unused variables.
8954 * NEWS: Mention end of support for native debugging on MS-Windows
8958 * common/netstuff.c:
8959 * gdbserver/gdbreplay.c
8960 * gdbserver/remote-utils.c:
8962 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8963 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8964 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8965 'getaddrinfo' and 'freeaddrinfo' were not available before
8966 Windows XP, and mingw.org's MinGW headers by default define
8967 _WIN32_WINNT to 0x500.
8969 2019-03-01 Gary Benson <gbenson@redhat.com>
8971 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8973 2019-02-28 Brian Vandenberg <phantall@gmail.com>
8974 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8977 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8978 set_sigint_trap, clear_sigint_trap.
8980 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8982 * target.c (target_detach): Clear the regcache and the
8985 2019-02-27 Pedro Alves <palves@redhat.com>
8987 * utils.c (set_screen_size): When we cap the height/width sizes,
8988 tweak the corresponding command variable to show "unlimited":
8990 2019-02-27 Saagar Jha <saagar@saagarjha.com>
8991 Pedro Alves <palves@redhat.com>
8993 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8994 before calling rl_set_screen_size.
8996 2019-02-27 Tom Tromey <tromey@adacore.com>
8998 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9000 * python/py-value.c: Remove Python 2.4 workaround.
9001 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9003 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9004 Python 2.4 workaround.
9005 * python/python-internal.h: Remove Python 2.4 comment.
9006 (Py_ssize_t): Don't define.
9007 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9008 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9009 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9010 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9011 * python/python.c (do_start_initialization): Remove Python 2.4
9013 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9014 (print_children): Remove Python 2.4 workaround.
9015 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9017 (CHARBUFFERPROC_NAME): Remove.
9018 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9019 Python 2.4 workaround.
9021 2019-02-27 Kevin Buettner <kevinb@redhat.com>
9023 * NEWS: Note minimum Python version.
9025 2019-02-27 Kevin Buettner <kevinb@redhat.com>
9027 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9028 code from these functions. Remove corresponding ifdefs. Use
9029 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9030 Remove gotos and target of gotos.
9031 (infpy_search_memory): Likewise.
9033 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9035 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9036 (hppa_gdbarch_init): Don't register deleted functions with
9039 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9041 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9042 (h8300_unwind_sp): Delete.
9043 (h8300_dummy_id): Delete.
9044 (h8300_gdbarch_init): Don't register deleted functions with
9047 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9049 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9050 (ft32_unwind_pc): Delete.
9051 (ft32_unwind_sp): Delete.
9052 (ft32_gdbarch_init): Don't register deleted functions with
9055 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9057 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9058 (frv_unwind_pc): Delete.
9059 (frv_unwind_sp): Delete.
9060 (frv_gdbarch_init): Don't register deleted functions with
9063 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9065 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9066 (riscv_unwind_pc): Delete.
9067 (riscv_unwind_sp): Delete.
9068 (riscv_gdbarch_init): Don't register deleted functions with
9071 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9073 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9074 (csky_unwind_pc): Delete.
9075 (csky_unwind_sp): Delete.
9076 (csky_gdbarch_init): Don't register deleted functions with
9079 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9081 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9082 (cris_unwind_pc): Delete.
9083 (cris_unwind_sp): Delete.
9084 (cris_gdbarch_init): Don't register deleted functions with
9087 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9089 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9090 (bfin_unwind_pc): Delete.
9091 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9093 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9095 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9096 (arm_unwind_pc): Delete.
9097 (arm_unwind_sp): Delete.
9098 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9100 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9102 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9103 (arc_unwind_pc): Delete.
9104 (arc_unwind_sp): Delete.
9105 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9107 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9109 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9110 (alpha_unwind_pc): Delete.
9111 (alpha_gdbarch_init): Don't register deleted functions with
9114 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9116 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9117 (aarch64_unwind_pc): Delete.
9118 (aarch64_unwind_sp): Delete.
9119 (aarch64_gdbarch_init): Don't register deleted functions with
9122 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9124 * gdbtypes.c (type_align): Don't consider static members when
9125 computing structure alignment.
9127 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9129 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9130 return 0 for other types.
9131 * arch-utils.c (default_type_align): Always return 0.
9132 * gdbarch.h: Regenerate.
9133 * gdbarch.sh (type_align): Extend comment.
9134 * gdbtypes.c (type_align): Add additional comments, always call
9135 gdbarch_type_align before applying the default rules.
9136 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9137 generic code will then apply a suitable default.
9138 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9139 types, return 0 for other types.
9141 2019-02-27 Joel Brobecker <brobecker@adacore.com>
9143 * NEWS: Create a new section for the next release branch.
9144 Rename the section of the current branch, now that it has
9147 2019-02-27 Joel Brobecker <brobecker@adacore.com>
9149 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9150 * version.in: Bump version to 8.3.50.DATE-git.
9152 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
9154 * aix-thread.c (ptid_cmp): Remove unused variable.
9155 (get_signaled_thread): Likewise.
9156 (store_regs_user_thread): Likewise.
9157 (store_regs_kernel_thread): Likewise.
9158 (fetch_regs_kernel_thread): Remove shadowed variable.
9160 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9162 * features/riscv/32bit-cpu.xml: Add register numbers.
9163 * features/riscv/32bit-fpu.c: Regenerate.
9164 * features/riscv/32bit-fpu.xml: Add register numbers.
9165 * features/riscv/64bit-cpu.xml: Add register numbers.
9166 * features/riscv/64bit-fpu.c: Regenerate.
9167 * features/riscv/64bit-fpu.xml: Add register numbers.
9169 2019-02-26 Kevin Buettner <kevinb@redhat.com>
9171 * NEWS: Mention two argument form of gdb.Value constructor.
9172 * python/py-value.c (convert_buffer_and_type_to_value): New
9174 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9175 Add support for handling an optional second argument. Call
9176 convert_buffer_and_type_to_value as appropriate.
9177 * python/python-internal.h (Py_buffer_deleter): New struct.
9178 (Py_buffer_up): New typedef.
9180 2019-02-25 John Baldwin <jhb@FreeBSD.org>
9182 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9183 instead of releasing ownership.
9185 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
9187 * dwarf2read.c (open_and_init_dwp_file): Call
9188 elf_numsections instead of bfd_count_sections to initialize
9189 dwp_file->num_sections.
9191 2019-02-25 Tom Tromey <tromey@adacore.com>
9193 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9195 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9197 * gcore.in: Add '--readnever' option when invoking GDB.
9199 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9201 * MAINTAINERS: Update my email address.
9203 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9205 * build-id.c (build_id_to_debug_bfd_1): New function.
9206 (build_id_to_debug_bfd): Look for separate debug file in
9209 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9211 * gdbarch.sh: Update the copyright year range that is placed into
9214 2019-02-22 Keith Seitz <keiths@redhat.com>
9217 * linespec.c (create_sals_line_offset): Search for the default
9218 symtab's filename instead of its fullname.
9220 2019-02-21 Alan Hayward <alan.hayward@arm.com>
9222 * NEWS: Update style defaults.
9224 2019-02-21 Alan Hayward <alan.hayward@arm.com>
9226 * main.c (captured_main_1): Disable styling in batch mode.
9228 2019-02-20 Tom Tromey <tom@tromey.com>
9230 * symtab.c (symtab_symbol_info): Fix typos.
9232 2019-02-20 Tom Tromey <tromey@adacore.com>
9234 * findcmd.c (_initialize_mem_search): Use upper case for
9235 metasyntactic variables.
9237 2019-02-20 Alan Hayward <alan.hayward@arm.com>
9239 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9240 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9242 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9244 * top.h (source_file_name): Change to std::string.
9245 * top.c (source_file_name): Likewise.
9246 (command_line_input): Adjust.
9247 * cli/cli-script.c (script_from_file): Adjust.
9249 2019-02-19 Tom Tromey <tromey@adacore.com>
9251 * ravenscar-thread.c
9252 (ravenscar_thread_target::update_thread_list): Don't call
9253 ada_build_task_list.
9254 * ada-lang.h (ada_build_task_list): Don't declare.
9255 * ada-tasks.c (struct ada_tasks_inferior_data)
9256 <task_list_valid_p>: Now bool.
9257 (read_known_tasks, ada_task_list_changed)
9258 (ada_tasks_invalidate_inferior_data): Update.
9259 (read_known_tasks_array): Return bool.
9260 (read_known_tasks_list): Likewise.
9261 (read_known_tasks): Return void.
9262 (ada_build_task_list): Now static.
9264 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9266 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9267 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9269 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9271 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9272 variant for ada_tasks_pspace_data_handle and
9273 ada_tasks_inferior_data_handle.
9274 (ada_tasks_pspace_data_cleanup): New function.
9275 (ada_tasks_inferior_data_cleanup): New function.
9277 2019-02-17 Tom Tromey <tom@tromey.com>
9279 * macrotab.h (macro_source_fullname): Return a std::string.
9280 * macrotab.c (macro_include, check_for_redefinition)
9281 (macro_undef, macro_lookup_definition, foreach_macro)
9282 (foreach_macro_in_scope): Update.
9283 (macro_source_fullname): Return a std::string.
9284 * macrocmd.c (show_pp_source_pos): Update.
9286 2019-02-17 Tom Tromey <tom@tromey.com>
9288 * macrocmd.c (show_pp_source_pos): Style the file names.
9290 2019-02-17 Tom Tromey <tom@tromey.com>
9293 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9295 2019-02-17 Tom Tromey <tom@tromey.com>
9297 * ada-lang.c (user_select_syms): Use filtered printing.
9298 * utils.c (wrap_style): New global.
9299 (desired_style): Remove.
9300 (emit_style_escape): Add stream parameter.
9301 (set_output_style, reset_terminal_style, prompt_for_continue):
9303 (flush_wrap_buffer): Only flush gdb_stdout.
9304 (wrap_here): Set wrap_style.
9305 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9306 treat escape sequences as a character. Change when wrap buffer is
9308 (fputs_styled): Do not set the output style when the default is
9310 * ui-style.h (struct ui_file_style) <is_default>: New method.
9311 * source.c (print_source_lines_base): Emit escape sequences in one
9314 2019-02-17 Joel Brobecker <brobecker@adacore.com>
9316 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9317 integers and enumeration types.
9319 2019-02-17 Joel Brobecker <brobecker@adacore.com>
9321 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9322 instead of lookup_symbol_in_language
9323 (do_exact_match): New function.
9324 (ada_get_symbol_name_matcher): Return do_exact_match when
9325 doing a verbatim match.
9327 2019-02-15 Tom Tromey <tromey@adacore.com>
9329 * ravenscar-thread.c (ravenscar_thread_target::resume)
9330 (ravenscar_thread_target::wait): Special case wildcard requests.
9332 2019-02-15 Tom Tromey <tromey@adacore.com>
9334 * ravenscar-thread.c (base_ptid): Remove.
9335 (struct ravenscar_thread_target) <close>: New method.
9336 <m_base_ptid>: New member.
9337 <update_inferior_ptid, active_task, task_is_currently_active,
9338 runtime_initialized>: Declare methods.
9339 <ravenscar_thread_target>: Add constructor.
9340 (ravenscar_thread_target::task_is_currently_active)
9341 (ravenscar_thread_target::update_inferior_ptid)
9342 (ravenscar_runtime_initialized): Rename. Now methods.
9343 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9344 (ravenscar_thread_target::update_thread_list): Update.
9345 (ravenscar_thread_target::active_task): Now method.
9346 (ravenscar_thread_target::store_registers)
9347 (ravenscar_thread_target::prepare_to_store)
9348 (ravenscar_thread_target::prepare_to_store)
9349 (ravenscar_thread_target::mourn_inferior): Update.
9350 (ravenscar_inferior_created): Use "new" to create target.
9351 (ravenscar_thread_target::get_ada_task_ptid): Update.
9352 (_initialize_ravenscar): Don't initialize base_ptid.
9353 (ravenscar_ops): Remove global.
9355 2019-02-15 Tom Tromey <tromey@adacore.com>
9357 * target.h (push_target): Declare new overload.
9358 * target.c (push_target): New overload, taking an rvalue reference.
9359 * remote.c (remote_target::open_1): Use push_target overload.
9360 * corelow.c (core_target_open): Use push_target overload.
9362 2019-02-15 Tom Tromey <tromey@adacore.com>
9364 * ravenscar-thread.c (is_ravenscar_task)
9365 (ravenscar_task_is_currently_active): Return bool.
9366 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9367 (_initialize_ravenscar): Remove "(void)".
9368 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9371 2019-02-15 Tom Tromey <tromey@adacore.com>
9373 * ravenscar-thread.c (ravenscar_runtime_initializer)
9374 (has_ravenscar_runtime, get_running_thread_id)
9375 (ravenscar_thread_target::resume): Fix indentation.
9377 2019-02-15 Tom Tromey <tromey@adacore.com>
9379 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9380 from ravenscar_arch_ops.
9381 (sparc_ravenscar_ops::fetch_registers)
9382 (sparc_ravenscar_ops::store_registers): Now methods.
9383 (sparc_ravenscar_prepare_to_store): Remove.
9384 (sparc_ravenscar_ops): Redefine.
9385 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9386 methods and destructor. Remove members.
9387 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9388 (ravenscar_thread_target::store_registers)
9389 (ravenscar_thread_target::prepare_to_store): Update.
9390 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9392 (struct ppc_ravenscar_powerpc_ops): Derive from
9394 (ppc_ravenscar_powerpc_ops::fetch_registers)
9395 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9396 (ppc_ravenscar_powerpc_ops): Redefine.
9397 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9398 (ppc_ravenscar_e500_ops::fetch_registers)
9399 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9400 (ppc_ravenscar_e500_ops): Redefine.
9401 * aarch64-ravenscar-thread.c
9402 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9403 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9404 (aarch64_ravenscar_fetch_registers)
9405 (aarch64_ravenscar_store_registers): Now methods.
9406 (aarch64_ravenscar_ops): Redefine.
9408 2019-02-15 Tom Tromey <tromey@adacore.com>
9410 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9411 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9412 (ravenscar_thread_target::stopped_by_watchpoint)
9413 (ravenscar_thread_target::stopped_data_address)
9414 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9416 2019-02-15 Tom Tromey <tromey@adacore.com>
9418 * ravenscar-thread.c: Fix some typos.
9420 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9421 Tom Tromey <tromey@adacore.com>
9423 * ada-lang.c (ada_exception_sal): Change addr_string to a
9425 (create_ada_exception_catchpoint): Update.
9427 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9428 Tom Tromey <tromey@adacore.com>
9430 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9431 (bp_location_ops): Remove.
9432 (base_breakpoint_allocate_location): Update.
9433 (free_bp_location): Update.
9434 * ada-lang.c (class ada_catchpoint_location)
9435 <ada_catchpoint_location>: Remove ops parameter.
9436 (ada_catchpoint_location_dtor): Remove.
9437 (ada_catchpoint_location_ops): Remove.
9438 (allocate_location_exception): Update.
9439 * breakpoint.h (struct bp_location_ops): Remove.
9440 (class bp_location) <bp_location>: Remove bp_location_ops
9442 <~bp_location>: Add destructor.
9445 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9446 Pedro Alves <palves@redhat.com>
9448 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9451 2019-02-14 David Michael <fedora.dm0@gmail.com>
9452 Samuel Thibault <samuel.thibault@gnu.org>
9453 Thomas Schwinge <thomas@codesourcery.com>
9455 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9456 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9458 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9460 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9461 (check_empty): Use "const char *".
9463 * gnu-nat.c (gnu_nat_target::detach): Instead of
9464 'detach_inferior (pid)' call
9465 'detach_inferior (find_inferior_pid (pid))'.
9467 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9468 'nat/fork-inferior.o'.
9469 * gnu-nat.c: #include "nat/fork-inferior.h".
9471 * gnu-nat.c (gnu_nat_target::detach): Instead of
9472 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9473 * gnu-nat.h: #include "inf-child.h".
9474 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9475 'i386_gnu_nat_target::fetch_registers'.
9476 (gnu_store_registers): Rename/move to
9477 'i386_gnu_nat_target::store_registers'.
9479 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9480 * gnu-nat.h (mach_thread_info): New function.
9481 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9483 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9485 2019-02-14 Frederic Konrad <konrad@adacore.com>
9487 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9489 2019-02-14 Joel Brobecker <brobecker@adacore.com>
9491 * windows-nat.c (windows_add_thread): Add new parameter
9492 "main_thread_p" with default value set to false. Update
9493 function documentation as well as all callers.
9494 (windows_delete_thread): Likewise.
9495 (fake_create_process): Update call to windows_add_thread.
9496 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9497 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9498 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9499 call to windows_delete_thread.
9501 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9503 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9505 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9507 * symfile.c (find_separate_debug_file): Use canonical path of
9508 sysroot with child_path instead of gdb_sysroot if it is valid.
9510 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9512 * symfile.c (find_separate_debug_file): Use child_path to
9513 determine if an object file is under a sysroot.
9515 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9517 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9518 unittests/child-path-selftests.c.
9519 * common/pathstuff.c (child_path): New function.
9520 * common/pathstuff.h (child_path): New prototype.
9521 * unittests/child-path-selftests.c: New file.
9523 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9525 * symfile.c (find_separate_debug_file): Look for separate debug
9526 files in debug directories under the sysroot.
9528 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9530 * symtab.h (struct minimal_symbol data_p): New const method.
9531 (struct minimal_symbol text_p): Likewise.
9532 * symtab.c (output_source_filename): Use file name style
9534 (print_symbol_info): Likewise.
9535 (print_msymbol_info): Use address style to print addresses.
9536 Use function name style to print executable text symbols.
9537 (expand_symtab_containing_pc): Use data_p.
9538 (find_pc_sect_compunit_symtab): Likewise.
9540 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9542 * breakpoint.c (describe_other_breakpoints): Use address style
9544 (say_where): Likewise.
9546 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9548 * ada-typeprint.c (print_func_type): Print function name
9549 style to print function name.
9550 * c-typeprint.c (c_print_type_1): Likewise.
9552 2019-02-11 Alan Hayward <alan.hayward@arm.com>
9554 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9557 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9559 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9562 2019-02-10 Joel Brobecker <brobecker@adacore.com>
9564 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9565 TYPE_CODE_REF types.
9567 2019-02-08 Jim Wilson <jimw@sifive.com>
9569 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9570 (riscv_linux_fregset): New.
9571 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9573 2019-02-07 Tom Tromey <tom@tromey.com>
9575 * thread.c (thread_cancel_execution_command): Update.
9576 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9578 (struct thread_fsm_ops): Remove.
9579 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9580 (thread_fsm_should_stop, thread_fsm_return_value)
9581 (thread_fsm_set_finished, thread_fsm_finished_p)
9582 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9584 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9585 * infrun.c (clear_proceed_status_thread)
9586 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9587 (print_stop_event): Update.
9588 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9590 (step_command_fsm_ops): Remove.
9591 (new_step_command_fsm): Remove.
9593 (step_command_fsm::should_stop): Rename from
9594 step_command_fsm_should_stop.
9595 (step_command_fsm::clean_up): Rename from
9596 step_command_fsm_clean_up.
9597 (step_command_fsm::do_async_reply_reason): Rename from
9598 step_command_fsm_async_reply_reason.
9599 (struct until_next_fsm): Inherit from thread_fsm. Add
9601 (until_next_fsm_ops): Remove.
9602 (new_until_next_fsm): Remove.
9603 (until_next_fsm::should_stop): Rename from
9604 until_next_fsm_should_stop.
9605 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9606 (until_next_fsm::do_async_reply_reason): Rename from
9607 until_next_fsm_async_reply_reason.
9608 (struct finish_command_fsm): Inherit from thread_fsm. Add
9609 constructor. Change type of breakpoint.
9610 (finish_command_fsm_ops): Remove.
9611 (new_finish_command_fsm): Remove.
9612 (finish_command_fsm::should_stop): Rename from
9613 finish_command_fsm_should_stop.
9614 (finish_command_fsm::clean_up): Rename from
9615 finish_command_fsm_clean_up.
9616 (finish_command_fsm::return_value): Rename from
9617 finish_command_fsm_return_value.
9618 (finish_command_fsm::do_async_reply_reason): Rename from
9619 finish_command_fsm_async_reply_reason.
9620 (finish_command): Update.
9621 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9623 (call_thread_fsm_ops): Remove.
9624 (call_thread_fsm::call_thread_fsm): Rename from
9625 new_call_thread_fsm.
9626 (call_thread_fsm::should_stop): Rename from
9627 call_thread_fsm_should_stop.
9628 (call_thread_fsm::should_notify_stop): Rename from
9629 call_thread_fsm_should_notify_stop.
9630 (run_inferior_call, call_function_by_hand_dummy): Update.
9631 * cli/cli-interp.c (should_print_stop_to_console): Update.
9632 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9633 Add constructor. Change type of location_breakpoint,
9635 (until_break_fsm_ops): Remove.
9636 (new_until_break_fsm): Remove.
9637 (until_break_fsm::should_stop): Rename from
9638 until_break_fsm_should_stop.
9639 (until_break_fsm::clean_up): Rename from
9640 until_break_fsm_clean_up.
9641 (until_break_fsm::do_async_reply_reason): Rename from
9642 until_break_fsm_async_reply_reason.
9643 (until_break_command): Update.
9644 * thread-fsm.c: Remove.
9645 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9647 2019-02-07 Tom Tromey <tom@tromey.com>
9649 * yy-remap.h: Add include guard.
9650 * xtensa-tdep.h: Add include guard.
9651 * xcoffread.h: Rename include guard.
9652 * varobj-iter.h: Add include guard.
9653 * tui/tui.h: Rename include guard.
9654 * tui/tui-winsource.h: Rename include guard.
9655 * tui/tui-wingeneral.h: Rename include guard.
9656 * tui/tui-windata.h: Rename include guard.
9657 * tui/tui-win.h: Rename include guard.
9658 * tui/tui-stack.h: Rename include guard.
9659 * tui/tui-source.h: Rename include guard.
9660 * tui/tui-regs.h: Rename include guard.
9661 * tui/tui-out.h: Rename include guard.
9662 * tui/tui-layout.h: Rename include guard.
9663 * tui/tui-io.h: Rename include guard.
9664 * tui/tui-hooks.h: Rename include guard.
9665 * tui/tui-file.h: Rename include guard.
9666 * tui/tui-disasm.h: Rename include guard.
9667 * tui/tui-data.h: Rename include guard.
9668 * tui/tui-command.h: Rename include guard.
9669 * tic6x-tdep.h: Add include guard.
9670 * target/waitstatus.h: Rename include guard.
9671 * target/wait.h: Rename include guard.
9672 * target/target.h: Rename include guard.
9673 * target/resume.h: Rename include guard.
9674 * target-float.h: Rename include guard.
9675 * stabsread.h: Add include guard.
9676 * rs6000-tdep.h: Add include guard.
9677 * riscv-fbsd-tdep.h: Add include guard.
9678 * regformats/regdef.h: Rename include guard.
9679 * record.h: Rename include guard.
9680 * python/python.h: Rename include guard.
9681 * python/python-internal.h: Rename include guard.
9682 * python/py-stopevent.h: Rename include guard.
9683 * python/py-ref.h: Rename include guard.
9684 * python/py-record.h: Rename include guard.
9685 * python/py-record-full.h: Rename include guard.
9686 * python/py-record-btrace.h: Rename include guard.
9687 * python/py-instruction.h: Rename include guard.
9688 * python/py-events.h: Rename include guard.
9689 * python/py-event.h: Rename include guard.
9690 * procfs.h: Add include guard.
9691 * proc-utils.h: Add include guard.
9692 * p-lang.h: Add include guard.
9693 * or1k-tdep.h: Rename include guard.
9694 * observable.h: Rename include guard.
9695 * nto-tdep.h: Rename include guard.
9696 * nat/x86-linux.h: Rename include guard.
9697 * nat/x86-linux-dregs.h: Rename include guard.
9698 * nat/x86-gcc-cpuid.h: Add include guard.
9699 * nat/x86-dregs.h: Rename include guard.
9700 * nat/x86-cpuid.h: Rename include guard.
9701 * nat/ppc-linux.h: Rename include guard.
9702 * nat/mips-linux-watch.h: Rename include guard.
9703 * nat/linux-waitpid.h: Rename include guard.
9704 * nat/linux-ptrace.h: Rename include guard.
9705 * nat/linux-procfs.h: Rename include guard.
9706 * nat/linux-osdata.h: Rename include guard.
9707 * nat/linux-nat.h: Rename include guard.
9708 * nat/linux-namespaces.h: Rename include guard.
9709 * nat/linux-btrace.h: Rename include guard.
9710 * nat/glibc_thread_db.h: Rename include guard.
9711 * nat/gdb_thread_db.h: Rename include guard.
9712 * nat/gdb_ptrace.h: Rename include guard.
9713 * nat/fork-inferior.h: Rename include guard.
9714 * nat/amd64-linux-siginfo.h: Rename include guard.
9715 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9716 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9717 * nat/aarch64-linux.h: Rename include guard.
9718 * nat/aarch64-linux-hw-point.h: Rename include guard.
9719 * mn10300-tdep.h: Add include guard.
9720 * mips-linux-tdep.h: Add include guard.
9721 * mi/mi-parse.h: Rename include guard.
9722 * mi/mi-out.h: Rename include guard.
9723 * mi/mi-main.h: Rename include guard.
9724 * mi/mi-interp.h: Rename include guard.
9725 * mi/mi-getopt.h: Rename include guard.
9726 * mi/mi-console.h: Rename include guard.
9727 * mi/mi-common.h: Rename include guard.
9728 * mi/mi-cmds.h: Rename include guard.
9729 * mi/mi-cmd-break.h: Rename include guard.
9730 * m2-lang.h: Add include guard.
9731 * location.h: Rename include guard.
9732 * linux-record.h: Rename include guard.
9733 * linux-nat.h: Add include guard.
9734 * linux-fork.h: Add include guard.
9735 * i386-darwin-tdep.h: Rename include guard.
9736 * hppa-linux-offsets.h: Add include guard.
9737 * guile/guile.h: Rename include guard.
9738 * guile/guile-internal.h: Rename include guard.
9739 * gnu-nat.h: Rename include guard.
9740 * gdb-stabs.h: Rename include guard.
9741 * frv-tdep.h: Add include guard.
9742 * f-lang.h: Add include guard.
9743 * event-loop.h: Add include guard.
9744 * darwin-nat.h: Rename include guard.
9745 * cp-abi.h: Rename include guard.
9746 * config/sparc/nm-sol2.h: Rename include guard.
9747 * config/nm-nto.h: Rename include guard.
9748 * config/nm-linux.h: Add include guard.
9749 * config/i386/nm-i386gnu.h: Rename include guard.
9750 * config/djgpp/nl_types.h: Rename include guard.
9751 * config/djgpp/langinfo.h: Rename include guard.
9752 * compile/gcc-cp-plugin.h: Add include guard.
9753 * compile/gcc-c-plugin.h: Add include guard.
9754 * compile/compile.h: Rename include guard.
9755 * compile/compile-object-run.h: Rename include guard.
9756 * compile/compile-object-load.h: Rename include guard.
9757 * compile/compile-internal.h: Rename include guard.
9758 * compile/compile-cplus.h: Rename include guard.
9759 * compile/compile-c.h: Rename include guard.
9760 * common/xml-utils.h: Rename include guard.
9761 * common/x86-xstate.h: Rename include guard.
9762 * common/version.h: Rename include guard.
9763 * common/vec.h: Rename include guard.
9764 * common/tdesc.h: Rename include guard.
9765 * common/selftest.h: Rename include guard.
9766 * common/scoped_restore.h: Rename include guard.
9767 * common/scoped_mmap.h: Rename include guard.
9768 * common/scoped_fd.h: Rename include guard.
9769 * common/safe-iterator.h: Rename include guard.
9770 * common/run-time-clock.h: Rename include guard.
9771 * common/refcounted-object.h: Rename include guard.
9772 * common/queue.h: Rename include guard.
9773 * common/ptid.h: Rename include guard.
9774 * common/print-utils.h: Rename include guard.
9775 * common/preprocessor.h: Rename include guard.
9776 * common/pathstuff.h: Rename include guard.
9777 * common/observable.h: Rename include guard.
9778 * common/netstuff.h: Rename include guard.
9779 * common/job-control.h: Rename include guard.
9780 * common/host-defs.h: Rename include guard.
9781 * common/gdb_wait.h: Rename include guard.
9782 * common/gdb_vecs.h: Rename include guard.
9783 * common/gdb_unlinker.h: Rename include guard.
9784 * common/gdb_unique_ptr.h: Rename include guard.
9785 * common/gdb_tilde_expand.h: Rename include guard.
9786 * common/gdb_sys_time.h: Rename include guard.
9787 * common/gdb_string_view.h: Rename include guard.
9788 * common/gdb_splay_tree.h: Rename include guard.
9789 * common/gdb_setjmp.h: Rename include guard.
9790 * common/gdb_ref_ptr.h: Rename include guard.
9791 * common/gdb_optional.h: Rename include guard.
9792 * common/gdb_locale.h: Rename include guard.
9793 * common/gdb_assert.h: Rename include guard.
9794 * common/filtered-iterator.h: Rename include guard.
9795 * common/filestuff.h: Rename include guard.
9796 * common/fileio.h: Rename include guard.
9797 * common/environ.h: Rename include guard.
9798 * common/common-utils.h: Rename include guard.
9799 * common/common-types.h: Rename include guard.
9800 * common/common-regcache.h: Rename include guard.
9801 * common/common-inferior.h: Rename include guard.
9802 * common/common-gdbthread.h: Rename include guard.
9803 * common/common-exceptions.h: Rename include guard.
9804 * common/common-defs.h: Rename include guard.
9805 * common/common-debug.h: Rename include guard.
9806 * common/cleanups.h: Rename include guard.
9807 * common/buffer.h: Rename include guard.
9808 * common/btrace-common.h: Rename include guard.
9809 * common/break-common.h: Rename include guard.
9810 * cli/cli-utils.h: Rename include guard.
9811 * cli/cli-style.h: Rename include guard.
9812 * cli/cli-setshow.h: Rename include guard.
9813 * cli/cli-script.h: Rename include guard.
9814 * cli/cli-interp.h: Rename include guard.
9815 * cli/cli-decode.h: Rename include guard.
9816 * cli/cli-cmds.h: Rename include guard.
9817 * charset-list.h: Add include guard.
9818 * buildsym-legacy.h: Rename include guard.
9819 * bfin-tdep.h: Add include guard.
9820 * ax.h: Rename include guard.
9821 * arm-linux-tdep.h: Add include guard.
9822 * arm-fbsd-tdep.h: Add include guard.
9823 * arch/xtensa.h: Rename include guard.
9824 * arch/tic6x.h: Add include guard.
9825 * arch/i386.h: Add include guard.
9826 * arch/arm.h: Rename include guard.
9827 * arch/arm-linux.h: Rename include guard.
9828 * arch/arm-get-next-pcs.h: Rename include guard.
9829 * arch/amd64.h: Add include guard.
9830 * arch/aarch64-insn.h: Rename include guard.
9831 * arch-utils.h: Rename include guard.
9832 * annotate.h: Add include guard.
9833 * amd64-darwin-tdep.h: Rename include guard.
9834 * aarch64-linux-tdep.h: Add include guard.
9835 * aarch64-fbsd-tdep.h: Add include guard.
9836 * aarch32-linux-nat.h: Add include guard.
9838 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9840 * macrotab.c (macro_define_internal): New function that
9841 factorizes macro_define_object_internal and macro_define_function
9843 (macro_define_object_internal): Use macro_define_internal.
9844 (macro_define_function): Likewise.
9846 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9848 * macrocmd.c (extract_identifier): Return
9849 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9852 2019-02-06 John Baldwin <jhb@FreeBSD.org>
9854 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9856 2019-02-05 Tom Tromey <tom@tromey.com>
9858 * target.c (target_stack::unpush): Move assertion earlier.
9860 2019-01-30 Tom Tromey <tom@tromey.com>
9863 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9864 (gdbpy_parse_and_eval): Likewise.
9865 * python/python-internal.h (gdbpy_allow_threads): New class.
9867 2019-01-28 John Baldwin <jhb@FreeBSD.org>
9869 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9870 (aarch64_fbsd_fpregmap): Move earlier.
9871 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9872 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9873 instead of individual calls to trad_frame_set_reg_addr.
9874 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9876 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9877 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9878 instead of individual calls to trad_frame_set_reg_addr.
9880 2019-01-28 Alan Hayward <alan.hayward@arm.com>
9882 * CONTRIBUTE: Replace contribution list with wiki link.
9884 2019-01-25 Tom Tromey <tom@tromey.com>
9886 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9888 2019-01-25 Tom Tromey <tom@tromey.com>
9890 * xtensa-linux-nat.c: Fix common/ includes.
9891 * xml-support.h: Fix common/ includes.
9892 * xml-support.c: Fix common/ includes.
9893 * x86-linux-nat.c: Fix common/ includes.
9894 * windows-nat.c: Fix common/ includes.
9895 * varobj.h: Fix common/ includes.
9896 * varobj.c: Fix common/ includes.
9897 * value.c: Fix common/ includes.
9898 * valops.c: Fix common/ includes.
9899 * utils.c: Fix common/ includes.
9900 * unittests/xml-utils-selftests.c: Fix common/ includes.
9901 * unittests/utils-selftests.c: Fix common/ includes.
9902 * unittests/unpack-selftests.c: Fix common/ includes.
9903 * unittests/tracepoint-selftests.c: Fix common/ includes.
9904 * unittests/style-selftests.c: Fix common/ includes.
9905 * unittests/string_view-selftests.c: Fix common/ includes.
9906 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9907 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9908 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9909 * unittests/rsp-low-selftests.c: Fix common/ includes.
9910 * unittests/parse-connection-spec-selftests.c: Fix common/
9912 * unittests/optional-selftests.c: Fix common/ includes.
9913 * unittests/offset-type-selftests.c: Fix common/ includes.
9914 * unittests/observable-selftests.c: Fix common/ includes.
9915 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9916 * unittests/memrange-selftests.c: Fix common/ includes.
9917 * unittests/memory-map-selftests.c: Fix common/ includes.
9918 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9919 * unittests/function-view-selftests.c: Fix common/ includes.
9920 * unittests/environ-selftests.c: Fix common/ includes.
9921 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9922 * unittests/common-utils-selftests.c: Fix common/ includes.
9923 * unittests/cli-utils-selftests.c: Fix common/ includes.
9924 * unittests/array-view-selftests.c: Fix common/ includes.
9925 * ui-file.c: Fix common/ includes.
9926 * tui/tui-io.c: Fix common/ includes.
9927 * tracepoint.h: Fix common/ includes.
9928 * tracepoint.c: Fix common/ includes.
9929 * tracefile-tfile.c: Fix common/ includes.
9930 * top.h: Fix common/ includes.
9931 * top.c: Fix common/ includes.
9932 * thread.c: Fix common/ includes.
9933 * target/waitstatus.h: Fix common/ includes.
9934 * target/waitstatus.c: Fix common/ includes.
9935 * target.h: Fix common/ includes.
9936 * target.c: Fix common/ includes.
9937 * target-memory.c: Fix common/ includes.
9938 * target-descriptions.c: Fix common/ includes.
9939 * symtab.h: Fix common/ includes.
9940 * symfile.c: Fix common/ includes.
9941 * stap-probe.c: Fix common/ includes.
9942 * spu-linux-nat.c: Fix common/ includes.
9943 * sparc-nat.c: Fix common/ includes.
9944 * source.c: Fix common/ includes.
9945 * solib.c: Fix common/ includes.
9946 * solib-target.c: Fix common/ includes.
9947 * ser-unix.c: Fix common/ includes.
9948 * ser-tcp.c: Fix common/ includes.
9949 * ser-pipe.c: Fix common/ includes.
9950 * ser-base.c: Fix common/ includes.
9951 * selftest-arch.c: Fix common/ includes.
9952 * s12z-tdep.c: Fix common/ includes.
9953 * rust-exp.y: Fix common/ includes.
9954 * rs6000-aix-tdep.c: Fix common/ includes.
9955 * riscv-tdep.c: Fix common/ includes.
9956 * remote.c: Fix common/ includes.
9957 * remote-notif.h: Fix common/ includes.
9958 * remote-fileio.h: Fix common/ includes.
9959 * remote-fileio.c: Fix common/ includes.
9960 * regcache.h: Fix common/ includes.
9961 * regcache.c: Fix common/ includes.
9962 * record-btrace.c: Fix common/ includes.
9963 * python/python.c: Fix common/ includes.
9964 * python/py-type.c: Fix common/ includes.
9965 * python/py-inferior.c: Fix common/ includes.
9966 * progspace.h: Fix common/ includes.
9967 * producer.c: Fix common/ includes.
9968 * procfs.c: Fix common/ includes.
9969 * proc-api.c: Fix common/ includes.
9970 * printcmd.c: Fix common/ includes.
9971 * ppc-linux-nat.c: Fix common/ includes.
9972 * parser-defs.h: Fix common/ includes.
9973 * osdata.c: Fix common/ includes.
9974 * obsd-nat.c: Fix common/ includes.
9975 * nat/x86-linux.c: Fix common/ includes.
9976 * nat/x86-linux-dregs.c: Fix common/ includes.
9977 * nat/x86-dregs.h: Fix common/ includes.
9978 * nat/x86-dregs.c: Fix common/ includes.
9979 * nat/ppc-linux.c: Fix common/ includes.
9980 * nat/mips-linux-watch.h: Fix common/ includes.
9981 * nat/mips-linux-watch.c: Fix common/ includes.
9982 * nat/linux-waitpid.c: Fix common/ includes.
9983 * nat/linux-ptrace.h: Fix common/ includes.
9984 * nat/linux-ptrace.c: Fix common/ includes.
9985 * nat/linux-procfs.c: Fix common/ includes.
9986 * nat/linux-personality.c: Fix common/ includes.
9987 * nat/linux-osdata.c: Fix common/ includes.
9988 * nat/linux-namespaces.c: Fix common/ includes.
9989 * nat/linux-btrace.h: Fix common/ includes.
9990 * nat/linux-btrace.c: Fix common/ includes.
9991 * nat/fork-inferior.c: Fix common/ includes.
9992 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9993 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9994 * nat/aarch64-linux.c: Fix common/ includes.
9995 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9996 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9997 * namespace.h: Fix common/ includes.
9998 * mips-linux-tdep.c: Fix common/ includes.
9999 * minsyms.c: Fix common/ includes.
10000 * mi/mi-parse.h: Fix common/ includes.
10001 * mi/mi-main.c: Fix common/ includes.
10002 * mi/mi-cmd-env.c: Fix common/ includes.
10003 * memrange.h: Fix common/ includes.
10004 * memattr.c: Fix common/ includes.
10005 * maint.h: Fix common/ includes.
10006 * maint.c: Fix common/ includes.
10007 * main.c: Fix common/ includes.
10008 * machoread.c: Fix common/ includes.
10009 * location.c: Fix common/ includes.
10010 * linux-thread-db.c: Fix common/ includes.
10011 * linux-nat.c: Fix common/ includes.
10012 * linux-fork.c: Fix common/ includes.
10013 * inline-frame.c: Fix common/ includes.
10014 * infrun.c: Fix common/ includes.
10015 * inflow.c: Fix common/ includes.
10016 * inferior.h: Fix common/ includes.
10017 * inferior.c: Fix common/ includes.
10018 * infcmd.c: Fix common/ includes.
10019 * inf-ptrace.c: Fix common/ includes.
10020 * inf-child.c: Fix common/ includes.
10021 * ia64-linux-nat.c: Fix common/ includes.
10022 * i387-tdep.c: Fix common/ includes.
10023 * i386-tdep.c: Fix common/ includes.
10024 * i386-linux-tdep.c: Fix common/ includes.
10025 * i386-linux-nat.c: Fix common/ includes.
10026 * i386-go32-tdep.c: Fix common/ includes.
10027 * i386-fbsd-tdep.c: Fix common/ includes.
10028 * i386-fbsd-nat.c: Fix common/ includes.
10029 * guile/scm-type.c: Fix common/ includes.
10030 * guile/guile.c: Fix common/ includes.
10031 * go32-nat.c: Fix common/ includes.
10032 * gnu-nat.c: Fix common/ includes.
10033 * gdbthread.h: Fix common/ includes.
10034 * gdbarch-selftests.c: Fix common/ includes.
10035 * gdb_usleep.c: Fix common/ includes.
10036 * gdb_select.h: Fix common/ includes.
10037 * gdb_bfd.c: Fix common/ includes.
10038 * gcore.c: Fix common/ includes.
10039 * fork-child.c: Fix common/ includes.
10040 * findvar.c: Fix common/ includes.
10041 * fbsd-nat.c: Fix common/ includes.
10042 * event-top.c: Fix common/ includes.
10043 * event-loop.c: Fix common/ includes.
10044 * dwarf2read.c: Fix common/ includes.
10045 * dwarf2loc.c: Fix common/ includes.
10046 * dwarf2-frame.c: Fix common/ includes.
10047 * dwarf-index-cache.c: Fix common/ includes.
10048 * dtrace-probe.c: Fix common/ includes.
10049 * disasm-selftests.c: Fix common/ includes.
10050 * defs.h: Fix common/ includes.
10051 * csky-tdep.c: Fix common/ includes.
10052 * cp-valprint.c: Fix common/ includes.
10053 * cp-support.h: Fix common/ includes.
10054 * cp-support.c: Fix common/ includes.
10055 * corelow.c: Fix common/ includes.
10056 * completer.h: Fix common/ includes.
10057 * completer.c: Fix common/ includes.
10058 * compile/compile.c: Fix common/ includes.
10059 * compile/compile-loc2c.c: Fix common/ includes.
10060 * compile/compile-cplus-types.c: Fix common/ includes.
10061 * compile/compile-cplus-symbols.c: Fix common/ includes.
10062 * command.h: Fix common/ includes.
10063 * cli/cli-dump.c: Fix common/ includes.
10064 * cli/cli-cmds.c: Fix common/ includes.
10065 * charset.c: Fix common/ includes.
10066 * build-id.c: Fix common/ includes.
10067 * btrace.h: Fix common/ includes.
10068 * btrace.c: Fix common/ includes.
10069 * breakpoint.h: Fix common/ includes.
10070 * breakpoint.c: Fix common/ includes.
10072 (enum agent_op): Fix common/ includes.
10073 * ax-general.c (struct aop_map): Fix common/ includes.
10074 * ax-gdb.c: Fix common/ includes.
10075 * auxv.c: Fix common/ includes.
10076 * auto-load.c: Fix common/ includes.
10077 * arm-tdep.c: Fix common/ includes.
10078 * arch/riscv.c: Fix common/ includes.
10079 * arch/ppc-linux-common.c: Fix common/ includes.
10080 * arch/i386.c: Fix common/ includes.
10081 * arch/arm.c: Fix common/ includes.
10082 * arch/arm-linux.c: Fix common/ includes.
10083 * arch/arm-get-next-pcs.c: Fix common/ includes.
10084 * arch/amd64.c: Fix common/ includes.
10085 * arch/aarch64.c: Fix common/ includes.
10086 * arch/aarch64-insn.c: Fix common/ includes.
10087 * arch-utils.c: Fix common/ includes.
10088 * amd64-windows-tdep.c: Fix common/ includes.
10089 * amd64-tdep.c: Fix common/ includes.
10090 * amd64-sol2-tdep.c: Fix common/ includes.
10091 * amd64-obsd-tdep.c: Fix common/ includes.
10092 * amd64-nbsd-tdep.c: Fix common/ includes.
10093 * amd64-linux-tdep.c: Fix common/ includes.
10094 * amd64-linux-nat.c: Fix common/ includes.
10095 * amd64-fbsd-tdep.c: Fix common/ includes.
10096 * amd64-fbsd-nat.c: Fix common/ includes.
10097 * amd64-dicos-tdep.c: Fix common/ includes.
10098 * amd64-darwin-tdep.c: Fix common/ includes.
10099 * agent.c: Fix common/ includes.
10100 * ada-lang.h: Fix common/ includes.
10101 * ada-lang.c: Fix common/ includes.
10102 * aarch64-tdep.c: Fix common/ includes.
10104 2019-01-25 Tom Tromey <tom@tromey.com>
10106 * common/create-version.sh: Use common/version.h.
10108 2019-01-24 Pedro Alves <palves@redhat.com>
10110 * infrun.c (signal_stop, signal_print, signal_program)
10111 (signal_catch, signal_pass): Now arrays instead of pointers.
10112 (update_signals_program_target, do_target_resume)
10113 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10114 * linux-nat.c (linux_nat_target::pass_signals)
10115 (linux_nat_target::create_inferior, linux_nat_target::attach):
10117 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10118 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10119 * procfs.c (procfs_target::pass_signals): Adjust.
10120 * record-full.c (record_full_target::resume): Adjust.
10121 * remote.c (remote_target::pass_signals)
10122 (remote_target::program_signals): Adjust.
10123 * target-debug.h (target_debug_print_signals): Now takes a
10124 gdb::array_view as parameter. Adjust.
10125 * target.h (target_ops) <pass_signals, program_signals>: Replace
10126 pointer and length parameters with gdb::array_view.
10127 (target_pass_signals, target_program_signals): Likewise.
10128 * target-delegates.c: Regenerate.
10130 2019-01-24 Pedro Alves <palves@redhat.com>
10132 * common/forward-scope-exit.h
10133 (forward_scope_exit::forward_scope_exit): Pass arguments to
10134 m_bind_function directly, instead of creating a std::bind and
10137 2019-01-24 Alan Hayward <alan.hayward@arm.com>
10139 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10140 for static members.
10141 (pass_in_v_vfp_candidate): Likewise.
10143 2019-01-23 Tom Tromey <tom@tromey.com>
10144 Pedro Alves <palves@redhat.com>
10146 * regcache.c (class regcache_invalidator): Remove.
10147 (regcache::raw_write): Use make_scope_exit.
10149 2019-01-23 Tom Tromey <tom@tromey.com>
10151 * ui-out.h (class ui_out_emit_type): Update comment.
10153 2019-01-23 Tom Tromey <tom@tromey.com>
10155 * infrun.c (fetch_inferior_event): Update comment.
10157 2019-01-23 Tom Tromey <tom@tromey.com>
10158 Pedro Alves <palves@redhat.com>
10160 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10162 (fetch_inferior_event): Use SCOPE_EXIT.
10165 2019-01-23 Tom Tromey <tom@tromey.com>
10166 Pedro Alves <palves@redhat.com>
10168 * infrun.c (disable_thread_events): Delete.
10169 (stop_all_threads): Use SCOPE_EXIT.
10171 2019-01-23 Tom Tromey <tom@tromey.com>
10172 Pedro Alves <palves@redhat.com>
10174 * symfile.c: Include forward-scope-exit.h.
10175 (clear_symtab_users_cleanup): Replace forward declaration with
10176 a FORWARD_SCOPE_EXIT.
10177 (syms_from_objfile_1): Use the forward_scope_exit and
10178 gdb::optional instead of cleanup_function.
10179 (reread_symbols): Use the forward_scope_exit instead of
10181 (clear_symtab_users_cleanup): Remove function.
10183 2019-01-23 Tom Tromey <tom@tromey.com>
10184 Pedro Alves <palves@redhat.com>
10186 * linux-nat.c: Include scope-exit.h.
10187 (cleanup_target_stop): Remove.
10188 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10191 2019-01-23 Tom Tromey <tom@tromey.com>
10192 Pedro Alves <palves@redhat.com>
10194 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10195 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10197 2019-01-23 Tom Tromey <tom@tromey.com>
10198 Andrew Burgess <andrew.burgess@embecosm.com>
10199 Pedro Alves <palves@redhat.com>
10201 * infrun.c (fetch_inferior_event): Use scope_exit.
10202 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10203 * top.c (execute_command): Use scope_exit.
10204 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10205 * utils.c (do_bpstat_clear_actions_cleanup)
10206 (make_bpstat_clear_actions_cleanup): Remove.
10208 2019-01-23 Tom Tromey <tom@tromey.com>
10209 Pedro Alves <palves@redhat.com>
10211 * infrun.c: Include "common/scope-exit.h"
10212 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10213 (wait_for_inferior): Use SCOPE_EXIT.
10214 (fetch_inferior_event): Use scope_exit.
10216 2019-01-23 Tom Tromey <tom@tromey.com>
10217 Pedro Alves <palves@redhat.com>
10219 * breakpoint.c (create_breakpoint): Remove cleanup.
10221 2019-01-23 Tom Tromey <tom@tromey.com>
10222 Andrew Burgess <andrew.burgess@embecosm.com>
10223 Pedro Alves <palves@redhat.com>
10225 2019-01-23 Pedro Alves <palves@redhat.com>
10227 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10229 2019-01-23 Pedro Alves <palves@redhat.com>
10230 Andrew Burgess <andrew.burgess@embecosm.com>
10232 * gdbthread.h: Include "common/forward-scope-exit.h".
10233 (scoped_finish_thread_state): Redefine custom class in terms of
10234 forward_scope_exit.
10236 2019-01-23 Pedro Alves <palves@redhat.com>
10237 Andrew Burgess <andrew.burgess@embecosm.com>
10239 * common/forward-scope-exit.h: New file.
10241 2019-01-23 Pedro Alves <palves@redhat.com>
10242 Andrew Burgess <andrew.burgess@embecosm.com>
10243 Tom Tromey <tom@tromey.com>
10245 * common/scope-exit.h: New file.
10247 2019-01-23 Pedro Alves <palves@redhat.com>
10249 * common/preprocessor.h (ESC): Rename to ...
10250 (ESC_PARENS): ... this.
10251 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10252 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10254 2019-01-23 Tom Tromey <tom@tromey.com>
10256 * language.h (class scoped_switch_to_sym_language_if_auto):
10257 Initialize m_lang in both cases.
10259 2019-01-23 Alan Hayward <alan.hayward@arm.com>
10261 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10264 2019-01-22 Tom Tromey <tom@tromey.com>
10266 * corelow.c: Do not include sys/file.h.
10268 2019-01-22 Tom Tromey <tom@tromey.com>
10270 * tui/tui-wingeneral.h: Include gdb_curses.h.
10272 2019-01-22 Tom Tromey <tom@tromey.com>
10274 * source-cache.h (class source_cache) <get_source_lines,
10275 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10277 2019-01-22 Tom Tromey <tom@tromey.com>
10279 * remote-fileio.h (struct remote_target): Declare.
10281 2019-01-22 Tom Tromey <tom@tromey.com>
10283 * python/py-arch.c: Do not include py-ref.h.
10284 * python/py-bpevent.c: Do not include py-ref.h.
10285 * python/py-cmd.c: Do not include py-ref.h.
10286 * python/py-continueevent.c: Do not include py-ref.h.
10287 * python/py-event.h: Do not include py-ref.h.
10288 * python/py-evtregistry.c: Do not include py-ref.h.
10289 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10290 * python/py-frame.c: Do not include py-ref.h.
10291 * python/py-framefilter.c: Do not include py-ref.h.
10292 * python/py-function.c: Do not include py-ref.h.
10293 * python/py-infevents.c: Do not include py-ref.h.
10294 * python/py-linetable.c: Do not include py-ref.h.
10295 * python/py-objfile.c: Do not include py-ref.h.
10296 * python/py-param.c: Do not include py-ref.h.
10297 * python/py-prettyprint.c: Do not include py-ref.h.
10298 * python/py-progspace.c: Do not include py-ref.h.
10299 * python/py-symbol.c: Do not include py-ref.h.
10300 * python/py-symtab.c: Do not include py-ref.h.
10301 * python/py-type.c: Do not include py-ref.h.
10302 * python/py-unwind.c: Do not include py-ref.h.
10303 * python/py-utils.c: Do not include py-ref.h.
10304 * python/py-value.c: Do not include py-ref.h.
10305 * python/py-varobj.c: Do not include py-ref.h.
10306 * python/py-xmethods.c: Do not include py-ref.h.
10307 * python/python.c: Do not include py-ref.h.
10308 * varobj.c: Do not include py-ref.h.
10310 2019-01-22 Tom Tromey <tom@tromey.com>
10312 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10313 keyword for bcache.
10315 2019-01-22 Tom Tromey <tom@tromey.com>
10317 * compile/compile-cplus-types.c: Remove a comment by #include.
10319 2019-01-22 Tom Tromey <tom@tromey.com>
10321 * compile/gcc-c-plugin.h: Include compile-internal.h.
10323 2019-01-22 Tom Tromey <tom@tromey.com>
10325 * stabsread.c (EXTERN): Do not define.
10326 (symnum, next_symbol_text_func, processing_gcc_compilation)
10327 (within_function, global_sym_chain, global_stabs)
10328 (previous_stab_code, this_object_header_files)
10329 (n_this_object_header_files)
10330 (n_allocated_this_object_header_files): Define.
10331 * stabsread.h (EXTERN): Never define. Use "extern".
10333 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10335 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10338 2019-01-21 Tom Tromey <tom@tromey.com>
10340 * ui-out.c: Fix includes.
10341 * tui/tui-source.c: Fix includes.
10342 * target.c: Fix includes.
10343 * remote.c: Fix includes.
10344 * regcache.c: Fix includes.
10345 * python/py-block.c: Fix includes.
10346 * printcmd.c: Fix includes.
10347 * or1k-tdep.c: Fix includes.
10348 * mi/mi-main.c: Fix includes.
10349 * m32r-tdep.c: Fix includes.
10350 * csky-tdep.c: Fix includes.
10351 * compile/compile-cplus-types.c: Fix includes.
10352 * cli/cli-interp.c: Fix includes.
10354 2019-01-21 Alan Hayward <alan.hayward@arm.com>
10356 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10359 2019-01-16 Tom Tromey <tom@tromey.com>
10361 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10363 (struct objfile) <msymbols_range>: Move from top level.
10364 <msymbols>: New method.
10365 (class objfile_msymbols): Remove.
10366 * symtab.c (default_collect_symbol_completion_matches_break_on):
10368 * symmisc.c (dump_msymbols): Update.
10369 * stabsread.c (scan_file_globals): Update.
10370 * objc-lang.c (info_selectors_command, info_classes_command)
10371 (find_methods): Update.
10372 * minsyms.c (find_solib_trampoline_target): Update.
10373 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10374 * coffread.c (coff_symfile_read): Update.
10375 * ada-lang.c (ada_lookup_simple_minsym)
10376 (ada_collect_symbol_completion_matches): Update.
10378 2019-01-16 Tom Tromey <tom@tromey.com>
10380 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10381 type. Remove no-argument constructor.
10382 <iterator::operator++>: Simplify.
10384 <end>: Use minimal_symbol_count.
10386 2019-01-16 Tom Tromey <tom@tromey.com>
10388 * objfiles.h (struct objfile) <psymtabs>: New method.
10389 (class objfile_psymtabs): Remove.
10390 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10392 <range>: New method.
10393 (require_partial_symbols): Change return type.
10394 * psymtab.c (require_partial_symbols)
10395 (psym_expand_symtabs_matching): Update.
10396 * mdebugread.c (parse_partial_symbols): Update.
10397 * dbxread.c (dbx_end_psymtab): Update.
10399 2019-01-15 Tom Tromey <tom@tromey.com>
10401 * symtab.c (lookup_objfile_from_block)
10402 (lookup_symbol_in_objfile_symtabs)
10403 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10404 (find_line_symtab, info_sources_command)
10405 (default_collect_symbol_completion_matches_break_on)
10406 (make_source_files_completion_list): Update.
10407 * symmisc.c (print_objfile_statistics, dump_objfile)
10408 (maintenance_print_symbols, maintenance_info_symtabs)
10409 (maintenance_check_symtabs, maintenance_info_line_tables):
10411 * source.c (select_source_symtab)
10412 (forget_cached_source_info_for_objfile): Update.
10413 * objfiles.h (class objfile_compunits): Remove.
10414 (struct objfile) <compunits_range>: New typedef.
10415 (compunits): New method.
10416 * objfiles.c (objfile_relocate1): Update.
10417 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10418 * maint.c (count_symtabs_and_blocks): Update.
10419 * linespec.c (iterate_over_all_matching_symtabs): Update.
10420 * cp-support.c (add_symbol_overload_list_qualified): Update.
10421 * coffread.c (coff_symtab_read): Update.
10422 * ada-lang.c (add_nonlocal_symbols)
10423 (ada_collect_symbol_completion_matches)
10424 (ada_add_global_exceptions): Update.
10426 2019-01-15 Tom Tromey <tom@tromey.com>
10428 * progspace.h (program_space) <objfiles_safe_range>: New
10430 <objfiles_safe>: New method.
10431 * objfiles.h (class all_objfiles_safe): Remove.
10432 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10433 * jit.c (jit_inferior_exit_hook): Update.
10435 2019-01-17 Tom Tromey <tom@tromey.com>
10437 * progspace.h (program_space) <objfiles_range>: New typedef.
10438 <objfiles>: New method.
10439 <objfiles_head>: Rename from objfiles.
10440 (object_files): Update.
10441 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10442 * guile/scm-pretty-print.c
10443 (ppscm_find_pretty_printer_from_objfiles): Update.
10444 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10445 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10447 * python/py-progspace.c (pspy_get_objfiles): Update.
10448 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10450 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10451 (objfpy_lookup_objfile_by_build_id): Update.
10452 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10453 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10455 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10456 (expand_symtab_containing_pc, lookup_objfile_from_block)
10457 (lookup_static_symbol, basic_lookup_transparent_type)
10458 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10459 (find_line_symtab, info_sources_command)
10460 (default_collect_symbol_completion_matches_break_on)
10461 (make_source_files_completion_list, find_main_name): Update.
10462 * symmisc.c (print_symbol_bcache_statistics)
10463 (print_objfile_statistics, maintenance_print_symbols)
10464 (maintenance_print_msymbols, maintenance_print_objfiles)
10465 (maintenance_info_symtabs, maintenance_check_symtabs)
10466 (maintenance_expand_symtabs, maintenance_info_line_tables):
10468 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10469 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10470 (map_overlay_command, unmap_overlay_command)
10471 (simple_overlay_update, expand_symtabs_matching)
10472 (map_symbol_filenames): Update.
10473 * symfile-debug.c (set_debug_symfile): Update.
10474 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10476 * source.c (select_source_symtab, forget_cached_source_info):
10478 * solib.c (solib_read_symbols): Update.
10479 * solib-spu.c (append_ocl_sos): Update.
10480 * psymtab.c (maintenance_print_psymbols)
10481 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10482 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10483 * printcmd.c (info_symbol_command): Update.
10484 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10486 * objfiles.h (class all_objfiles): Remove.
10487 * objfiles.c (have_partial_symbols, have_full_symbols)
10488 (have_minimal_symbols, qsort_cmp, update_section_map)
10489 (shared_objfile_contains_address_p)
10490 (default_iterate_over_objfiles_in_search_order): Update.
10491 * objc-lang.c (info_selectors_command, info_classes_command)
10492 (find_methods): Update.
10493 * minsyms.c (find_solib_trampoline_target): Update.
10494 * maint.c (maintenance_info_sections)
10495 (maintenance_translate_address, count_symtabs_and_blocks):
10497 * main.c (captured_main_1): Update.
10498 * linux-thread-db.c (try_thread_db_load_from_pdir)
10499 (has_libpthread): Update.
10500 * linespec.c (iterate_over_all_matching_symtabs)
10501 (search_minsyms_for_name): Update.
10502 * jit.c (jit_find_objf_with_entry_addr): Update.
10503 * hppa-tdep.c (find_unwind_entry)
10504 (hppa_lookup_stub_minimal_symbol): Update.
10505 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10507 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10508 (elf_gnu_ifunc_resolve_by_got): Update.
10509 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10510 * dwarf-index-write.c (save_gdb_index_command): Update.
10511 * cp-support.c (add_symbol_overload_list_qualified): Update.
10512 * breakpoint.c (create_overlay_event_breakpoint)
10513 (create_longjmp_master_breakpoint)
10514 (create_std_terminate_master_breakpoint)
10515 (create_exception_master_breakpoint): Update.
10516 * blockframe.c (find_pc_partial_function): Update.
10517 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10518 (ada_collect_symbol_completion_matches)
10519 (ada_add_global_exceptions): Update.
10521 2019-01-17 Tom Tromey <tom@tromey.com>
10523 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10525 (solib_target_parse_libraries): Change return type.
10526 (library_list_start_segment, library_list_start_section)
10527 (library_list_end_library, library_list_start_library); Update.
10528 (solib_target_free_library_list): Remove.
10529 (solib_target_parse_libraries): Remove cleanup. Change return
10531 (solib_target_current_sos): Update.
10533 2019-01-17 Tom Tromey <tromey@bapiya>
10535 * valprint.c: Replace "the the" with "the".
10536 * symtab.c: Replace "the the" with "the".
10537 * solib.c: Replace "the the" with "the".
10538 * solib-dsbt.c: Replace "the the" with "the".
10539 * linespec.c: Replace "the the" with "the".
10540 * dwarf2loc.h: Replace "the the" with "the".
10541 * amd64-windows-tdep.c: Replace "the the" with "the".
10542 * aarch64-tdep.c: Replace "the the" with "the".
10544 2019-01-16 Keith Seitz <keiths@redhat.com>
10547 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10548 <builder>: Rename to ..
10549 <m_builder>: ... this and make private.
10550 (dwarf2_cu::get_builder): New method. Change all users of
10551 `builder' to use this method.
10552 (dwarf2_start_symtab): Move to ...
10553 (dwarf2_cu::start_symtab): ... here. Update all callers
10554 (setup_type_unit_groups): Move to ...
10555 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10557 (dwarf2_cu::reset_builder): New method.
10558 (process_full_compunit, process_full_type_unit): Use
10559 dwarf2_cu::reset_builder.
10560 (follow_die_offset): Record the ancestor CU if it is different
10561 from the followed DIE's CU.
10562 (follow_die_sig_1): Likewise.
10564 2019-01-15 Tom Tromey <tom@tromey.com>
10566 * remote.c (class remote_state) <buf>: Now a char_vector.
10567 <buf_size>: Remove.
10568 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10570 (remote_target::getpkt_or_notif_sane_1)
10571 (remote_target::getpkt_sane)
10572 (remote_target::getpkt_or_notif_sane): Likewise.
10573 (class remote_target) <putpkt>: New overload.
10574 (remote_target::read_frame): Change type of "buf_p". Remove
10575 sizeof_p parameter.
10576 (packet_ok): New overload.
10577 (packet_check_result): New overload.
10580 2019-01-14 Tom Tromey <tom@tromey.com>
10582 * remote-notif.c (handle_notification, remote_notif_ack)
10583 (remote_notif_parse): Make "buf" const.
10584 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10586 (remote_notif_parse, remote_notif_ack, handle_notification):
10588 * remote.c (remote_notif_stop_parse): Make "buf" const.
10589 (remote_target::remote_parse_stop_reply): Make "buf" const.
10590 (remote_notif_stop_ack): Make "buf" const.
10592 2019-01-14 Tom Tromey <tom@tromey.com>
10594 * remote.c (remote_console_output): Make parameter const.
10596 2019-01-14 Tom Tromey <tom@tromey.com>
10598 * target-debug.h (target_debug_print_signals): Constify.
10599 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10600 * procfs.c (procfs_target::pass_signals): Update.
10601 * linux-nat.c (linux_nat_target::pass_signals): Update.
10602 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10603 * target-delegates.c: Rebuild.
10604 * remote.c (remote_target::program_signals): Update.
10605 (remote_target::pass_signals): Update.
10606 * target.c (target_pass_signals): Constify argument.
10607 (target_program_signals): Likewise.
10608 * target.h (struct target_ops) <pass_signals, program_signals>:
10610 (target_pass_signals, target_program_signals): Constify argument.
10612 2019-01-14 Tom Tromey <tom@tromey.com>
10615 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10617 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10619 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10621 * rs6000-tdep.c: Include reggroups.h.
10622 (IS_V_ALIAS_PSEUDOREG): Define.
10623 (rs6000_register_name): Return names for the "vX" aliases.
10624 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10625 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10626 aliases. Call default_register_reggroup_p for all other
10628 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10630 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10631 Handle "vX" aliases.
10632 (v_alias_pseudo_register_collect): New function.
10633 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10634 (rs6000_gdbarch_init): Initialize "vX" aliases as
10635 pseudo-registers. Restore registration of
10636 rs6000_pseudo_register_reggroup_p with
10637 set_tdesc_pseudo_register_reggroup_p.
10639 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10641 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10642 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10643 set_gdbarch_num_pseudo_regs.
10645 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10647 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10648 Remove arg prefixname, add do_set and do_show.
10649 Add member functions set_list and show_list.
10650 * cli/cli-style.c (class cli_style_option): Update accordingly.
10651 (style_set_list): Move to file scope.
10652 (style_show_list): Likewise.
10653 (set_style): Call help_list.
10654 (show_style): Call cmd_show_list.
10655 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10656 Update to use the new macro.
10658 2019-10-12 Joel Brobecker <brobecker@adacore.com>
10660 * ada-lang.c (_initialize_ada_language): Expand the help text
10661 for the "catch exception" command.
10663 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10665 * symtab.c (matching_obj_sections): Initialize obj,
10666 declare it closer to its usage.
10668 2019-01-10 Tom Tromey <tom@tromey.com>
10670 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10671 (basic_inf_threads_range): Remove.
10672 (inf_threads_range, inf_non_exited_threads_range)
10673 (safe_inf_threads_range): Use next_adapter.
10675 2019-01-10 Keith Seitz <keiths@redhat.com>
10679 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10680 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10682 2019-01-10 Keith Seitz <keiths@redhat.com>
10686 * dictionary.c (pending_to_vector): Remove.
10687 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10688 Remove _1 suffix, replacing functions of the same name. Update
10690 (dict_create_hashed, dict_create_hashed_expandable)
10691 (dict_create_linear, dict_create_linear_expandable, dict_free)
10692 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10693 Make functions static.
10695 2019-01-10 Keith Seitz <keiths@redhat.com>
10699 * dictionary.h (struct dictionary): Replace declaration with
10701 (dict_create_hashed, dict_create_hashed_expandable)
10702 (dict_create_linear, dict_create_linear_expandable)
10703 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10704 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10705 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10706 taking multidictionary argument.
10707 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10708 * block.h (struct block) <dict>: Change to multidictionary
10709 and rename `multidict'.
10710 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10711 symmisc.c: Update all dictionary references to multidictionary.
10713 2019-01-10 Keith Seitz <keiths@redhat.com>
10717 * dictionary.c: Include unordered_map.
10718 (pending_to_vector): New function.
10719 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10720 Rewrite the non-"_1" functions to take vector instead
10722 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10723 "new" _1 versions of the same name.
10724 (multidictionary): Define.
10725 (std::hash<enum language): New definition.
10726 (collate_pending_symbols_by_language, mdict_create_hashed)
10727 (mdict_create_hashed_expandable, mdict_create_linear)
10728 (mdict_create_linear_expandable, mdict_free)
10729 (find_language_dictionary, create_new_language_dictionary)
10730 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10731 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10732 (mdict_size, mdict_empty): New functions.
10733 * dictionary.h (mdict_iterator): Define.
10735 2019-01-10 Pedro Alves <palves@redhat.com>
10737 * breakpoint.c (read_uploaded_action)
10738 (create_tracepoint_from_upload): Adjust to use
10739 gdb::unique_xmalloc_ptr.
10740 * ctf.c (ctf_write_uploaded_tp):
10741 (SET_ARRAY_FIELD): Use emplace_back.
10742 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10743 * tracefile-tfile.c (tfile_write_uploaded_tp):
10744 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10745 gdb::unique_xmalloc_ptr.
10746 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10747 at_string, cond_string, cmd_strings>: Replace char pointers
10748 with gdb::unique_xmalloc_ptr.
10750 2019-01-10 Pedro Alves <palves@redhat.com>
10752 * solib-target.c (library_list_start_library): Don't xstrdup name.
10754 2019-01-10 Pedro Alves <palves@redhat.com>
10756 * mdebugread.c (parse_partial_symbols): Use
10757 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10759 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10761 * linux-fork.c (scoped_switch_fork_info)
10762 <~scoped_switch_fork_info>: Fix incorrect variable name.
10764 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10766 * linux-fork.c (scoped_switch_fork_info)
10767 <scoped_switch_fork_info>: Make explicit.
10768 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10770 2019-01-10 Tom Tromey <tom@tromey.com>
10772 * objfiles.h (objfile::reset_psymtabs): Update.
10773 * objfiles.c (objfile::objfile): Update.
10774 * psymtab.h (psymtab_storage::obstack): Update.
10775 (psymtab_storage::m_obstack): Use gdb::optional.
10776 (class psymtab_storage): Update comment. Remove objfile
10778 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10780 2019-01-10 Tom Tromey <tom@tromey.com>
10782 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10783 <free_psymtabs>: Now private.
10784 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10785 (allocate_psymtab): Use new method.
10787 2019-01-10 Tom Tromey <tom@tromey.com>
10789 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10790 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10791 * mdebugread.c (parse_partial_symbols): Use
10792 allocate_dependencies.
10793 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10794 allocate_dependencies.
10795 (process_psymtab_comp_unit_reader)
10796 (build_type_psymtab_dependencies): Likewise.
10797 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10799 2019-01-10 Tom Tromey <tom@tromey.com>
10801 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10802 PSYMBOL_SET_LANGUAGE.
10803 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10805 2019-01-10 Tom Tromey <tom@tromey.com>
10807 * psymtab.h (psymtab_storage::obstack): New method.
10808 <m_obstack>: Rename from obstack; now private.
10809 * psymtab.c (psymtab_storage): Update.
10810 * dwarf2read.c (create_addrmap_from_index)
10811 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10814 2019-01-10 Tom Tromey <tom@tromey.com>
10816 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10817 * objfiles.h (objfile::reset_psymtabs): New method.
10819 2019-01-10 Tom Tromey <tom@tromey.com>
10821 * symmisc.c (print_symbol_bcache_statistics): Update.
10822 (print_objfile_statistics): Update.
10823 * symfile.c (reread_symbols): Update.
10824 * psymtab.h (class psymtab_storage): New.
10825 * psymtab.c (psymtab_storage): New constructor.
10826 (~psymtab_storage): New destructor.
10827 (require_partial_symbols): Update.
10828 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10829 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10830 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10831 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10832 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10833 (start_psymtab_common, end_psymtab_common)
10834 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10835 (allocate_psymtab): Update.
10836 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10838 (dump_psymtab_addrmap, maintenance_print_psymbols)
10839 (maintenance_check_psymtabs): Update.
10840 (class objfile_psymtabs): Move to objfiles.h.
10841 * psympriv.h (discard_psymtab): Now inline.
10842 (psymtab_discarder::psymtab_discarder): Update.
10843 (psymtab_discarder::~psymtab_discarder): Update.
10844 (ALL_OBJFILE_PSYMTABS): Rewrite.
10845 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10846 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10848 <partial_symtabs>: New field.
10849 (class objfile_psymtabs): Move from psymtab.h. Update.
10850 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10852 (objfile::~objfile): Don't destroy psymbol_cache.
10853 * mdebugread.c (parse_partial_symbols): Update.
10854 * dwarf2read.c (create_addrmap_from_index)
10855 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10856 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10857 (add_partial_subprogram, dwarf2_ranges_read): Update.
10858 * dwarf-index-write.c (write_address_map)
10859 (write_one_signatured_type, recursively_write_psymbols)
10860 (class debug_names, class debug_names, write_psymtabs_to_index):
10863 2019-01-10 Tom Tromey <tom@tromey.com>
10865 * symtab.h (SYMBOL_SET_NAMES): Update.
10866 (symbol_set_names): Update.
10867 (MSYMBOL_SET_NAMES): Update.
10868 * symtab.c (symbol_set_names): Change argument to be an
10869 objfile_per_bfd_storage.
10870 * psymtab.c (add_psymbol_to_bcache): Update.
10871 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10873 2019-01-10 Tom Tromey <tom@tromey.com>
10875 * symtab.c (create_demangled_names_hash): Change argument to be an
10876 objfile_per_bfd_storage.
10877 (symbol_set_names): Update.
10879 2019-01-10 Tom Tromey <tom@tromey.com>
10881 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10883 * psymtab.c (init_psymbol_list): Do nothing if already called.
10884 * psympriv.h (init_psymbol_list): Add comment.
10885 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10887 * dbxread.c (dbx_symfile_read): Unconditionally call
10890 2019-01-10 Tom Tromey <tom@tromey.com>
10892 * xcoffread.c (scan_xcoff_symtab): Update.
10893 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10895 * mdebugread.c (parse_partial_symbols)
10896 (handle_psymbol_enumerators): Update.
10897 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10898 * dbxread.c (read_dbx_symtab): Update.
10899 * psympriv.h (psymbol_placement): New enum.
10900 (add_psymbol_to_list): Update.
10902 2019-01-10 Tom Tromey <tom@tromey.com>
10904 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10905 static_psymbols parameters.
10906 (scan_xcoff_symtab): Update.
10907 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10908 static_psymbols parameters.
10909 * psympriv.h (start_psymtab_common): Update.
10910 * mdebugread.c (parse_partial_symbols): Update.
10911 * dwarf2read.c (create_partial_symtab): Update.
10912 * dbxread.c (read_dbx_symtab): Update.
10913 (start_psymtab): Remove global_psymbols and static_psymbols
10916 2019-01-10 Tom Tromey <tom@tromey.com>
10918 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10919 * psymtab.c (allocate_psymtab): Add comment.
10920 * psympriv.h (allocate_psymtab): Add comment.
10921 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10923 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10925 2019-01-10 Tom Tromey <tom@tromey.com>
10927 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10929 * mipsread.c: Include mdebugread.h.
10930 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10932 * elfread.c: Include mdebugread.h.
10934 2019-01-09 Tom Tromey <tom@tromey.com>
10936 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10937 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10938 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10939 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10940 (psym_lookup_symbol, psym_find_last_source_symtab)
10941 (psym_forget_cached_source_info, psym_print_stats)
10942 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10943 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10944 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10945 (psym_find_compunit_symtab_by_address)
10946 (maintenance_print_psymbols, maintenance_info_psymtabs)
10947 (maintenance_check_psymtabs): Use ranged for.
10948 * psymtab.h (class objfile_psymtabs): New.
10949 (require_partial_symbols): Return objfile_psymtabs.
10950 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10952 2019-01-09 Tom Tromey <tom@tromey.com>
10954 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10955 (find_pc_mapped_section, list_overlays_command)
10956 (map_overlay_command, unmap_overlay_command)
10957 (simple_overlay_update): Use all_objfiles.
10958 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10959 * printcmd.c (info_symbol_command): Use all_objfiles.
10960 * objfiles.h (ALL_OBJSECTIONS): Remove.
10961 * maint.c (maintenance_translate_address): Use all_objfiles.
10962 * gcore.c (gcore_create_callback): Use all_objfiles.
10963 (objfile_find_memory_regions): Likewise.
10965 2019-01-09 Tom Tromey <tom@tromey.com>
10967 * symtab.c (find_line_symtab, info_sources_command)
10968 (make_source_files_completion_list): Use objfile_compunits.
10969 * source.c (select_source_symtab): Use objfile_compunits.
10970 * objfiles.h (struct objfile): Update comment.
10971 (ALL_OBJFILES): Remove.
10972 (ALL_FILETABS): Remove.
10973 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10976 2019-01-09 Tom Tromey <tom@tromey.com>
10978 * symmisc.c (print_objfile_statistics, dump_objfile)
10979 (maintenance_print_symbols): Use compunit_filetabs.
10980 * source.c (forget_cached_source_info_for_objfile): Use
10982 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10983 (ALL_FILETABS): Use compunit_filetabs.
10984 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10985 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10987 2019-01-09 Tom Tromey <tom@tromey.com>
10989 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10990 (compunit_filetabs): New.
10991 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10993 (info_sources_command, make_source_files_completion_list): Remove
10995 * symmisc.c (print_objfile_statistics, dump_objfile)
10996 (maintenance_print_symbols): Remove declaration.
10997 (maintenance_info_symtabs): Use compunit_filetabs.
10998 (maintenance_info_line_tables): Likewise.
10999 * source.c (select_source_symtab): Change local variable name.
11000 (forget_cached_source_info_for_objfile): Remove declaration.
11001 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11002 * objfiles.c (objfile_relocate1): Remove declaration.
11003 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11005 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11006 * coffread.c (coff_symtab_read): Remove declaration.
11007 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11010 2019-01-09 Tom Tromey <tom@tromey.com>
11012 * symtab.c (lookup_objfile_from_block)
11013 (find_pc_sect_compunit_symtab, search_symbols)
11014 (default_collect_symbol_completion_matches_break_on): Use
11016 * objfiles.h (ALL_COMPUNITS): Remove.
11017 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11018 * cp-support.c (add_symbol_overload_list_qualified): Use
11020 * ada-lang.c (ada_collect_symbol_completion_matches)
11021 (ada_add_global_exceptions): Use objfile_compunits.
11023 2019-01-09 Tom Tromey <tom@tromey.com>
11025 * source.c (select_source_symtab)
11026 (forget_cached_source_info_for_objfile): Remove declaration.
11027 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11029 * maint.c (count_symtabs_and_blocks): Remove declaration.
11030 * cp-support.c (add_symbol_overload_list_qualified): Remove
11032 * coffread.c (coff_symtab_read): Remove declaration.
11033 * symtab.c (lookup_symbol_in_objfile_symtabs)
11034 (basic_lookup_transparent_type_1): Use objfile_compunits.
11035 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11036 (info_sources_command, search_symbols)
11037 (default_collect_symbol_completion_matches_break_on)
11038 (make_source_files_completion_list): Remove declaration.
11039 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11040 (ada_collect_symbol_completion_matches)
11041 (ada_add_global_exceptions): Remove declaration.
11042 * linespec.c (iterate_over_all_matching_symtabs): Use
11044 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11045 (class objfile_compunits): New.
11046 (ALL_COMPUNITS): Use objfile_compunits.
11047 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11048 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11050 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11052 2019-01-09 Tom Tromey <tom@tromey.com>
11054 * symtab.c (search_symbols)
11055 (default_collect_symbol_completion_matches_break_on): Use
11057 * ada-lang.c (ada_lookup_simple_minsym)
11058 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11059 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11060 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11062 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11063 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11064 * objc-lang.c (find_methods): Use objfile_msymbols.
11065 (info_selectors_command, info_classes_command): Likewise.
11066 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11067 * objfiles.h (class objfile_msymbols): New.
11068 (ALL_OBJFILE_MSYMBOLS): Remove.
11069 (ALL_MSYMBOLS): Remove.
11071 2019-01-09 Tom Tromey <tom@tromey.com>
11073 * common/next-iterator.h (next_adapter): Add Iterator template
11075 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11076 (class all_objfiles_safe): New.
11077 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11078 * objfiles.c (put_objfile_before): Update comment.
11079 (add_separate_debug_objfile): Likewise.
11080 (free_all_objfiles): Use all_objfiles_safe.
11081 (objfile_purge_solibs): Likewise.
11083 2019-01-09 Tom Tromey <tom@tromey.com>
11085 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11086 (expand_symtab_containing_pc, lookup_static_symbol)
11087 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11088 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11090 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11091 * breakpoint.c (create_overlay_event_breakpoint)
11092 (create_longjmp_master_breakpoint)
11093 (create_std_terminate_master_breakpoint)
11094 (create_exception_master_breakpoint): Use all_objfiles.
11095 * linux-thread-db.c (try_thread_db_load_from_pdir)
11096 (has_libpthread): Use all_objfiles.
11097 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11098 * linespec.c (iterate_over_all_matching_symtabs)
11099 (search_minsyms_for_name): Use all_objfiles.
11100 * maint.c (maintenance_info_sections): Use all_objfiles.
11101 * main.c (captured_main_1): Use all_objfiles.
11102 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11103 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11104 * guile/scm-pretty-print.c
11105 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11106 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11107 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11108 (maintenance_print_msymbols): Use all_objfiles.
11109 * source.c (select_source_symtab): Use all_objfiles.
11110 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11111 * symfile.c (remove_symbol_file_command)
11112 (expand_symtabs_matching, map_symbol_filenames): Use
11114 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11116 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11117 * objc-lang.c (find_methods): Use all_objfiles.
11118 * objfiles.c (have_partial_symbols, have_full_symbols)
11119 (have_minimal_symbols, qsort_cmp)
11120 (default_iterate_over_objfiles_in_search_order): Use
11122 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11123 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11124 (maintenance_check_psymtabs): Use all_objfiles.
11125 (ALL_PSYMTABS): Remove.
11126 * compile/compile-object-run.c (do_module_cleanup): Use
11128 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11129 * cp-support.c (add_symbol_overload_list_qualified): Use
11131 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11133 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11134 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11136 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11137 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11138 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11140 * solib.c (solib_read_symbols): Use all_objfiles
11142 2019-01-09 Tom Tromey <tom@tromey.com>
11144 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11145 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11147 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11148 * symmisc.c (print_symbol_bcache_statistics)
11149 (print_objfile_statistics, maintenance_print_objfiles)
11150 (maintenance_info_symtabs, maintenance_check_symtabs)
11151 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11153 * source.c (forget_cached_source_info): Use all_objfiles.
11154 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11155 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11156 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11157 * objfiles.c (update_section_map): Use all_objfiles.
11158 (shared_objfile_contains_address_p): Likewise.
11159 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11160 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11162 2019-01-09 Tom Tromey <tom@tromey.com>
11164 * common/next-iterator.h: New file.
11165 * objfiles.h (class all_objfiles): New.
11166 (struct objfile_iterator): New.
11168 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11170 * NEWS: Move the description of the changed "frame", "select-frame",
11171 and "info frame" commands to the Changed commands section.
11173 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11175 * gdbtypes.c (check_stub_method_group): Remove handling of old
11177 * linespec.c (find_methods): Likewise.
11178 * stabsread.c (read_member_functions): Likewise.
11179 * valops.c (search_struct_method): Likewise.
11180 (value_struct_elt_for_reference): Likewise.
11181 * NEWS: Mention this change.
11183 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11185 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11186 print_source_lines.
11187 * source.c (print_source_lines_base): Update line number check.
11188 (print_source_lines): New function.
11189 (source_lines_range::source_lines_range): New function.
11190 * source.h (class source_lines_range): New class.
11191 (print_source_lines): New declaration.
11193 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11195 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11197 2019-01-08 Tom Tromey <tom@tromey.com>
11198 Simon Marchi <simon.marchi@ericsson.com>
11201 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11202 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11203 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11204 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11205 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11206 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11208 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11210 * source.c (select_source_symtab): Move header comment to
11211 declaration in source.h.
11212 (forget_cached_source_info_for_objfile): Likewise.
11213 (forget_cached_source_info): Likewise.
11214 (identify_source_line): Likewise.
11215 * source.h (identify_source_line): Move declaration from symtab.h
11216 and add comment from source.c
11217 (print_source_lines): Likewise.
11218 (forget_cached_source_info_for_objfile): Likewise.
11219 (forget_cached_source_info): Likewise.
11220 (select_source_symtab): Likewise.
11221 (enum print_source_lines_flag): Move definition from symtab.h.
11222 * symtab.h (identify_source_line): Move declaration to source.h.
11223 (print_source_lines): Likewise.
11224 (forget_cached_source_info_for_objfile): Likewise.
11225 (forget_cached_source_info): Likewise.
11226 (select_source_symtab): Likewise.
11227 (enum print_source_lines_flag): Move definition to source.h.
11228 * tui/tui-hooks.c: Add 'source.h' include.
11230 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11232 * source.c (print_source_lines_base): Handle requests to print
11233 reverse line number sequences, and guard against empty lines
11236 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11238 * source.c (print_source_lines_base): Fix skip of '\r' if next
11241 2019-01-06 Tom Tromey <tom@tromey.com>
11243 * c-exp.y (struct c_parse_state) <macro_original_text,
11244 expansion_obstack>: New member.
11245 (macro_original_text, expansion_obstack): Remove globals.
11246 (scan_macro_expansion, scanning_macro_expansion)
11247 (finished_macro_expansion): Update.
11248 (scan_macro_cleanup): Remove.
11249 (yylex, c_parse): Update.
11251 2019-01-06 Tom Tromey <tom@tromey.com>
11253 * c-exp.y (struct c_parse_state) <strings>: New member.
11254 (operator_stoken): Update.
11256 2019-01-06 Tom Tromey <tom@tromey.com>
11258 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11259 (union type_stack_elt) <typelist_val>: Now a pointer to
11261 (type_stack_cleanup): Don't declare.
11262 (push_typelist): Update.
11263 * parse.c (pop_typelist): Return a std::vector.
11264 (push_typelist): Take a std::vector.
11265 (follow_types): Update. Do not free args.
11266 (type_stack_cleanup): Remove.
11267 * c-exp.y (struct c_parse_state): New.
11268 (cpstate): New global.
11269 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11270 (nonempty_typelist): Update.
11271 (func_mod): Create a new vector.
11272 (c_parse): Create a c_parse_state.
11273 (check_parameter_typelist): Do not delete params.
11274 (function_method): Update. Do not delete type_list.
11276 2019-01-06 Tom Tromey <tom@tromey.com>
11279 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11281 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11282 (print_return_value): Likewise.
11284 2019-01-05 Tom Tromey <tom@tromey.com>
11286 * contrib/cleanup_check.py: Remove.
11287 * contrib/gcc-with-excheck: Remove.
11288 * contrib/exsummary.py: Remove.
11289 * contrib/excheck.py: Remove.
11291 2019-01-05 Joel Brobecker <brobecker@adacore.com>
11293 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11294 NULL. Initialize tpprev to NULL instead of assigning it
11295 to NULL on the next statement.
11296 * windows-nat.c (windows_delete_thread): Remove check for
11297 main_thread_id before printing thread exit notifications.
11298 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11299 Remove thread ID check against main_thread_id.
11300 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11301 windows_delete_thread.
11302 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11304 2019-01-04 Tom Tromey <tom@tromey.com>
11306 * compile/compile.c (_initialize_compile): Use upper case for
11307 metasyntactic variables.
11308 * symmisc.c (_initialize_symmisc): Use upper case for
11309 metasyntactic variables.
11310 * psymtab.c (_initialize_psymtab): Use upper case for
11311 metasyntactic variables.
11312 * demangle.c (demangle_command): Use upper case for metasyntactic
11314 (_initialize_demangler): Likewise.
11315 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11318 2019-01-03 Tom Tromey <tom@tromey.com>
11320 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11322 2019-01-03 Tom Tromey <tom@tromey.com>
11324 * python/py-symtab.c (salpy_str): Update.
11325 (struct salpy_sal_object) <symtab>: Now a PyObject.
11326 (salpy_dealloc): Update.
11327 (del_objfile_sal): Use gdbpy_ref.
11329 2019-01-03 Tom Tromey <tom@tromey.com>
11331 * python/py-type.c (convert_field): Use new_reference. Return
11333 (make_fielditem): Return gdbpy_ref.
11334 (typy_fields): Update.
11335 (typy_getitem): Update.
11336 (field_name): Return gdbpy_ref. Use new_reference.
11337 (typy_iterator_iternext): Update.
11339 2019-01-03 Tom Tromey <tom@tromey.com>
11341 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11343 2019-01-03 Tom Tromey <tom@tromey.com>
11345 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11346 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11347 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11348 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11349 (pspy_set_type_printers): Likewise.
11350 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11351 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11352 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11353 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11354 (objfpy_set_type_printers): Likewise.
11356 2019-01-03 Tom Tromey <tom@tromey.com>
11358 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11359 (gdbpy_print_stack): Use gdbpy_err_fetch.
11360 * python/python-internal.h (class gdbpy_err_fetch): New class.
11361 (class gdbpy_enter) <m_error_type, m_error_value,
11362 m_error_traceback>: Remove.
11363 <m_error>: New member.
11364 (gdbpy_exception_to_string): Don't declare.
11365 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11366 * python/py-value.c (convert_value_from_python): Use
11368 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11369 gdbpy_exception_to_string.
11370 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11371 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11374 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11376 * linux-nat.c (delete_lwp_cleanup): Delete.
11377 (struct lwp_deleter): New struct.
11378 (lwp_info_up): New typedef.
11379 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11382 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11384 * linux-fork.c (class scoped_switch_fork_info): New class.
11385 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11387 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11389 * valops.c (find_overload_match): Remove use of null_cleanup, and
11390 calls to do_cleanups.
11392 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11394 * compile/compile-cplus-types.c
11395 (compile_cplus_instance::decl_name): Handle changes to
11397 * cp-support.c (cp_func_name): Update header comment, update
11399 * cp-support.h (cp_func_name): Update return type in declaration.
11400 * valops.c (find_overload_match): Move temp_func local to top
11401 level of function and change its type. Use temp_func to hold and
11402 delete temporary string obtained from cp_func_name.
11404 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11406 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11407 gdb::char_vector, remove cleanup, and update uses of `msg`.
11409 2019-01-03 Jim Wilson <jimw@sifive.com>
11411 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11413 2019-01-02 Tom Tromey <tom@tromey.com>
11415 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11416 (tdesc_parse_xml): Remove cleanups.
11417 * target-descriptions.h (make_cleanup_free_target_description):
11419 (target_desc_deleter): New struct.
11420 (target_desc_up): New typedef.
11421 * target-descriptions.c (target_desc_deleter::operator()): Rename
11422 from free_target_description.
11423 (make_cleanup_free_target_description): Remove.
11425 2019-01-02 Tom Tromey <tom@tromey.com>
11427 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11428 constructor, destructor.
11429 (linespec_parser): Remove typedef.
11430 (~linespec_parser): Rename from linespec_parser_delete.
11431 (linespec_lex_to_end, linespec_complete_label)
11432 (linespec_complete): Update.
11433 (decode_line_full): Remove cleanups.
11434 (decode_line_1): Update.
11436 2019-01-02 Tom Tromey <tom@tromey.com>
11438 * python/python-internal.h (inferior_to_inferior_object): Change
11440 * python/py-exitedevent.c (create_exited_event_object): Update.
11441 * python/py-inferior.c (inferior_to_inferior_object): Return
11443 (python_new_inferior, python_inferior_deleted)
11444 (thread_to_thread_object, delete_thread_object)
11445 (build_inferior_list, gdbpy_selected_inferior): Update.
11446 * python/py-infthread.c (create_thread_object): Update. Also fail
11447 if inferior_to_inferior_object fails.
11449 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11451 * inferior.h (class inferior) <displaced_step_state>: New field.
11452 * infrun.h (struct displaced_step_state): Move here from
11453 infrun.c. Initialize fields, add constructor.
11454 <inf>: Remove field.
11455 <reset>: New method.
11456 * infrun.c (struct displaced_step_inferior_state): Move to
11458 (displaced_step_inferior_states): Remove.
11459 (get_displaced_stepping_state): Adust.
11460 (displaced_step_in_progress_any_inferior): Adjust.
11461 (displaced_step_in_progress_thread): Adjust.
11462 (displaced_step_in_progress): Adjust.
11463 (add_displaced_stepping_state): Remove.
11464 (get_displaced_step_closure_by_addr): Adjust.
11465 (remove_displaced_stepping_state): Remove.
11466 (infrun_inferior_exit): Call displaced_step_state.reset.
11467 (use_displaced_stepping): Don't check for NULL.
11468 (displaced_step_prepare_throw): Call
11469 get_displaced_stepping_state.
11470 (displaced_step_fixup): Don't check for NULL.
11471 (prepare_for_detach): Don't check for NULL.
11473 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11475 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11476 in case of call that did not complete.
11478 2019-01-02 Andrey Utkin <autkin@undo.io>
11480 * symfile.c (find_separate_debug_file): Fix search of debug files for
11483 2019-01-02 Tom Tromey <tom@tromey.com>
11485 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11487 * python/py-frame.c (frapy_older): Remove cast.
11488 (frapy_newer): Likewise.
11489 * python/py-breakpoint.c (local_setattro): Remove cast.
11490 * python/py-arch.c (archpy_name): Remove local variable.
11491 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11493 2019-01-02 Joel Brobecker <brobecker@adacore.com>
11495 * unittests/basic_string_view/element_access/char/empty.cc:
11496 Fix year range in copyright header.
11498 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11500 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11502 <operator==>: Update with for removed field.
11504 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11505 <isa_features>: ...this.
11506 <abi_features>: New field.
11507 (riscv_isa_flen): Update comment.
11508 (riscv_abi_xlen): New declaration.
11509 (riscv_abi_flen): New declaration.
11510 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11512 (riscv_abi_xlen): New function.
11513 (riscv_isa_flen): Update to get answer from isa_features.
11514 (riscv_abi_flen): New function.
11515 (riscv_has_fp_abi): Update to get answer from abi_features.
11516 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11518 (riscv_call_info) <xlen, flen>: Update comment.
11519 (riscv_call_arg_struct): Remove invalid assertions
11520 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11522 (riscv_gdbarch_init): Gather isa features and abi features
11523 separately, ensure both match on the gdbarch when reusing an old
11524 gdbarch. Relax an error check to allow 32-bit abi float to run on
11525 a target with 64-bit float hardware.
11527 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11529 * source.c (search_command_helper): Stop reverse search
11530 when line 1 has been searched.
11532 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11534 * record-full.c (record_full_base_target::close): Rewrite
11535 record_full_core_buf_list free logic.
11537 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11539 * break-catch-syscall.c (print_one_catch_syscall): xfree
11542 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11544 * top.c (print_gdb_version): Update Copyright year in version
11547 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11549 Update copyright year range in all GDB files.
11551 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
11553 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11555 For older changes see ChangeLog-2018.
11561 version-control: never