gdb/ChangeLog

   1 2018-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * common/common-defs.h (_FORTIFY_SOURCE): Define.
   4
   5 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * aarch64-linux-tdep.c (aarch64_linux_supply_sve_regset): New function.
   8         (aarch64_linux_collect_sve_regset): Likewise.
   9         (aarch64_linux_iterate_over_regset_sections): Check for SVE.
  10         * regcache.h (regcache_map_entry_size): New function.
  11
  12 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
  13
  14         * aarch64-linux-tdep.c (SVE_HEADER_SIZE_LENGTH): Add define.
  15         (SVE_HEADER_MAX_SIZE_LENGTH): Likewise.
  16         (SVE_HEADER_VL_LENGTH): Likewise.
  17         (SVE_HEADER_MAX_VL_LENGTH): Likewise.
  18         (SVE_HEADER_FLAGS_LENGTH): Likewise.
  19         (SVE_HEADER_RESERVED_LENGTH): Likewise.
  20         (SVE_HEADER_SIZE_OFFSET): Likewise.
  21         (SVE_HEADER_MAX_SIZE_OFFSET): Likewise.
  22         (SVE_HEADER_VL_OFFSET): Likewise.
  23         (SVE_HEADER_MAX_VL_OFFSET): Likewise.
  24         (SVE_HEADER_FLAGS_OFFSET): Likewise.
  25         (SVE_HEADER_RESERVED_OFFSET): Likewise.
  26         (SVE_HEADER_SIZE): Likewise.
  27         (aarch64_linux_core_read_vq): Add function.
  28         (aarch64_linux_core_read_description): Check for SVE section.
  29
  30 2018-08-13  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * aarch64-fbsd-tdep.c
  33         (aarch64_fbsd_iterate_over_regset_sections): Add supply_size and
  34         collect_size.
  35         * aarch64-linux-tdep.c
  36         (aarch64_linux_iterate_over_regset_sections): Likewise.
  37         * alpha-linux-tdep.c
  38         (alpha_linux_iterate_over_regset_sections):
  39         * alpha-nbsd-tdep.c
  40         (alphanbsd_iterate_over_regset_sections): Likewise.
  41         * amd64-fbsd-tdep.c
  42         (amd64fbsd_iterate_over_regset_sections): Likewise.
  43         * amd64-linux-tdep.c
  44         (amd64_linux_iterate_over_regset_sections): Likewise.
  45         * arm-bsd-tdep.c
  46         (armbsd_iterate_over_regset_sections): Likewise.
  47         * arm-fbsd-tdep.c
  48         (arm_fbsd_iterate_over_regset_sections): Likewise.
  49         * arm-linux-tdep.c
  50         (arm_linux_iterate_over_regset_sections): Likewise.
  51         * corelow.c (get_core_registers_cb): Likewise.
  52         (core_target::fetch_registers): Likewise.
  53         * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise.
  54         * frv-linux-tdep.c (frv_linux_iterate_over_regset_sections): Likewise.
  55         * gdbarch.h (void): Regenerate.
  56         * gdbarch.sh: Add supply_size and collect_size.
  57         * hppa-linux-tdep.c (hppa_linux_iterate_over_regset_sections): Likewise.
  58         * hppa-nbsd-tdep.c (hppanbsd_iterate_over_regset_sections): Likewise.
  59         * hppa-obsd-tdep.c (hppaobsd_iterate_over_regset_sections): Likewise.
  60         * i386-fbsd-tdep.c (i386fbsd_iterate_over_regset_sections): Likewise.
  61         * i386-linux-tdep.c (i386_linux_iterate_over_regset_sections): Likewise.
  62         * i386-tdep.c (i386_iterate_over_regset_sections): Likewise.
  63         * ia64-linux-tdep.c (ia64_linux_iterate_over_regset_sections): Likewise.
  64         * linux-tdep.c (linux_collect_regset_section_cb): Likewise.
  65         * m32r-linux-tdep.c (m32r_linux_iterate_over_regset_sections): Likewise.
  66         * m68k-bsd-tdep.c (m68kbsd_iterate_over_regset_sections): Likewise.
  67         * m68k-linux-tdep.c (m68k_linux_iterate_over_regset_sections): Likewise.
  68         * mips-fbsd-tdep.c (mips_fbsd_iterate_over_regset_sections): Likewise.
  69         * mips-linux-tdep.c (mips_linux_iterate_over_regset_sections): Likewise.
  70         * mips-nbsd-tdep.c (mipsnbsd_iterate_over_regset_sections): Likewise.
  71         * mips64-obsd-tdep.c (mips64obsd_iterate_over_regset_sections): Likewise.
  72         * mn10300-linux-tdep.c (am33_iterate_over_regset_sections): Likewise.
  73         * nios2-linux-tdep.c (nios2_iterate_over_regset_sections): Likewise.
  74         * ppc-fbsd-tdep.c (ppcfbsd_iterate_over_regset_sections): Likewise.
  75         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections): Likewise.
  76         * ppc-nbsd-tdep.c (ppcnbsd_iterate_over_regset_sections): Likewise.
  77         * ppc-obsd-tdep.c (ppcobsd_iterate_over_regset_sections): Likewise.
  78         * riscv-linux-tdep.c (riscv_linux_iterate_over_regset_sections): Likewise.
  79         * rs6000-aix-tdep.c (rs6000_aix_iterate_over_regset_sections): Likewise.
  80         * s390-linux-tdep.c (s390_iterate_over_regset_sections): Likewise.
  81         * score-tdep.c (score7_linux_iterate_over_regset_sections): Likewise.
  82         * sh-tdep.c (sh_iterate_over_regset_sections): Likewise.
  83         * sparc-tdep.c (sparc_iterate_over_regset_sections): Likewise.
  84         * tilegx-linux-tdep.c (tilegx_iterate_over_regset_sections): Likewise.
  85         * vax-tdep.c (vax_iterate_over_regset_sections): Likewise.
  86         * xtensa-tdep.c (xtensa_iterate_over_regset_sections): Likewise.
  87
  88 2018-08-10  Simon Marchi  <simon.marchi@ericsson.com>
  89
  90         * nat/linux-osdata.c (commandline_from_pid): Replace xstrprintf
  91         with string_printf.
  92
  93 2018-08-10  Keith Seitz  <keiths@redhat.com>
  94
  95         * compile/compile-c-support.c (add_code_header, add_code_footer):
  96         Move into policy class.
  97         (c_push_user_expression, pop_user_expression_nop)
  98         (c_add_code_header, c_add_code_footer, c_add_input): New policy class.
  99         (compile_program): New host class.
 100         (c_compile_program): New typedef.
 101         (c_compute_porgram): Use c_compile_program.
 102
 103 2018-08-10  Keith Seitz  <keiths@redhat.com>
 104
 105         * compile/compile-internal.h (compile_instance::~compile_instance):
 106         Remove calls to htab_delete.
 107         <m_type_map, m_symbol_err_map>: Switch type to htab_up.
 108         * compile.c (compile_instance::compile_instance): Initialize
 109         htab unique pointers.
 110         (compile_instance::get_cached_type, compile_instance::insert_type)
 111         (compile_instance::error_symbol_once): Update for unique_ptr.
 112
 113 2018-08-10  Keith Seitz  <keiths@redhat.com>
 114
 115         * compile/compile-c-symbols.c (struct symbol_error)
 116         (hash_symbol_error, eq_symbol_error, del_symbol_error)
 117         (compile_instance::insert_symbol_error)
 118         (compile_instance::error_symbol_once): Move to ...
 119         * compile/compile.c: ... here.
 120
 121 2018-08-10  Keith Seitz  <keiths@redhat.com>
 122
 123         * compile/compile-c-support.c (c_get_compile_context): Use `new'
 124         instead of `new_compile_instance'.
 125         * compile/compile-c-symbols.c (compile_instance::insert_symbol_error):
 126         Update description.
 127         If the symbol error map is not initialized, create it.
 128         (generate_c_for_for_one_symbol): Do not check/initialize
 129         the symbol error map.
 130         * compile/compile-c-types.c (compile_c_instance): Make a class.
 131         Update all callers.
 132         (compile_instance::compile_instance): Initialize the type cache.
 133         (get_cached_type): New function.
 134         (insert_type): Update description.
 135         (compile_c_instance::m_default_cflags): Define.
 136         (convert_type): Update description.  Use get_cached_type.
 137         (delete_instance): Moved to destructor.
 138         (new_compile_instance): Moved to constructor.
 139         * compile/compile-c.h (compile_c_instance): Make class inheriting
 140         from compile_instance.
 141         <base>: Remove field.
 142         <type_map, symbol_err_map>: Move to base class.
 143         <c_plugin>: Rename to `m_plugin' and remove pointer type.
 144         * compile/compile-internal.h (compile_instance): Make class.
 145         <type_map_t, symbol_err_map_t>: Define.
 146         <fe>: Rename to `m_gcc_fe'.
 147         <scope, block, gcc_target_options>: Add `m_' prefix.
 148         <m_type_map, m_symbol_err_map>: New fields, moved from
 149         compile_c_instance.
 150         <destroy>: Remove.
 151         (convert_type, new_compile_instance): Remove.
 152         * compile/compile.c (cleanup_compile_instance): Remove.
 153         (compile_to_object): Use unique_ptr to eliminate cleanups.
 154         (compile_instance::set_print_callback, compile_instance::version)
 155         (compile_instance::set_verbose)
 156         (compile_instance::set_driver_filename)
 157         (compile_instance::set_triplet_regexp)
 158         (compile_instance::set_arguments)
 159         (compile_instance::set_source_file)
 160         (compile_instance::compile): Define.
 161
 162 2018-08-10  Keith Seitz  <keiths@redhat.com>
 163
 164         * Makefile.in (HFILES_NO_SRCDIR): Add compile/gcc-c-plugin.h.
 165         * compile/compile-c-types.c: Define GCC_METHODN macros and include
 166         gcc-c-fe.def to define C plugin.
 167         (delete_instance): Delete `c_plugin'.
 168         (new_compile_instance): Initialize `c_plugin'.
 169         * compile/compile-c.h: Include gcc_c_plugin.h.
 170         (struct compile_c_instance) <c_plugin>: New member.
 171         * gcc-c-plugin.h: New file.
 172         Update all callers with API change.
 173
 174 2018-08-10  Keith Seitz  <keiths@redhat.com>
 175
 176         * Makefile.in (SUBDIR_GCC_COMPILE_SRCS): Move header files ...
 177         (HFILES_NO_SRCDIR): ... to here.
 178         Add compile-internal.h and compile-c.h.
 179         * compile/compile-c-support.c: Include compile-c.h.
 180         * compile/compile-c-symbols.c: Include compile-c.h.
 181         (generate_c_for_variable_locations): Update comment.
 182         * compile/compile-c-types.c: Include compile-c.h.
 183         * compile/compile-c.h: New file -- moved C language declarations
 184         from other files here.
 185         * compile/compile-internal.h: Do not include hashtab.h or
 186         common/enum-flags.h.
 187         (gcc_qualifiers_flags, struct compile_c_instance, C_CTX)
 188         (gcc_convert_symbol, gcc_symbol_address)
 189         (generate_c_for_variable_locations, c_get_mode_for_size)
 190         (c_get_range_decl_name): Definitions moved to compile-c.h.
 191         * compile/compile-loc2c.c: Include compile-c.h.
 192
 193 2018-08-10  Keith Seitz  <keiths@redhat.com>
 194
 195         * compile/compile-c-symbols.c (symbol_substitution_name): Rename to ...
 196         (c_symbol_substitution_name): ... this.
 197         Update all callers.
 198
 199 2018-08-10  Keith Seitz  <keiths@redhat.com>
 200
 201         * compile/compile-c-support.c (c_compute_program): Use
 202         unique_xmalloc_ptr to eliminate cleanup.
 203         * compile/compile-c-symbols.c (generate_c_for_variable_locations):
 204         Return a unique_xmalloc_ptr and eliminate cleanup.
 205         * compile/compile-internal.h (generate_c_for_variable_locations):
 206         Return unique_xmalloc_ptr and update description.
 207
 208 2018-08-10  Alan Hayward  <alan.hayward@arm.com>
 209
 210         * corelow.c (core_target::get_core_register_section): Rename
 211         min_size to section_min_size.
 212
 213 2018-08-09  Jim Wilson  <jimw@sifive.com>
 214
 215         * Makefile.in (ALL_TARGET_OBS): Add riscv-linux-tdep.c.
 216         (ALLDEPFILES): Add riscv-linux-nat.c, and riscv-linux-tdep.c.
 217         * NEWS: Mention new GNU/Linux RISC-V target.
 218         * configure.host: Add riscv*-*-linux*.
 219         * configure.nat: Add riscv*.
 220         * configure.tgt: Add riscv*-*-linux*.
 221         * riscv-linux-nat.c: New file.
 222         * riscv-linux-tdep.c: New file.
 223
 224 2018-08-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 225
 226         * infrun.c (resume): Make static, add forward declaration.
 227         (proceed): Update header comment.
 228         * infrun.h (resume): Delete declaration.
 229
 230 2018-08-09  Tom Tromey  <tom@tromey.com>
 231
 232         * riscv-tdep.h: Minor formatting fixes.
 233
 234 2018-08-09  Simon Marchi  <simon.marchi@ericsson.com>
 235
 236         * common/scoped_mmap.c (mmap_file): Silence ARI warning.
 237         * dwarf-index-cache.c (create_dir_and_check): Likewise.
 238         (test_mkdir_recursive): Likewise.
 239         * dwarf-index-write.c (write_psymtabs_to_index): Likewise.
 240
 241 2018-08-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 242
 243         * valarith.c (value_subscripted_rvalue): If an array is not in
 244         memory, and we don't know the upper bound, then we can't know that
 245         the requested element exists or not.
 246
 247 2018-08-08  Simon Marchi  <simon.marchi@ericsson.com>
 248
 249         * target.c (str_comma_list_concat_elem): Fix typo in comment.
 250         (target_options_to_string): Add comment.
 251
 252 2018-08-08  Tom Tromey  <tom@tromey.com>
 253
 254         * unittests/scoped_mmap-selftests.c: Check result of "write".
 255
 256 2018-08-08  Jim Wilson  <jimw@sifive.com>
 257
 258         * riscv-tdep.c (enum opcode): Add jump, branch, lr, and sc opcodes.
 259         (decode_register_index_short): New.
 260         (decode_j_type_insn, decode_cj_type_insn): New.
 261         (decode_b_type_insn, decode_cb_type_insn): New.
 262         (riscv_insn::decode): Add support for jumps, branches, lr, and sc.  New
 263         local xlen.  Check xlen when decoding ambiguous compressed insns.  In
 264         compressed decode, use is_c_lui_insn instead of is_lui_insn, and
 265         is_c_sw_insn instead of is_sw_insn.
 266         (riscv_next_pc, riscv_next_pc_atomic_sequence): New.
 267         (riscv_software_single_step): New.
 268         * riscv-tdep.h (riscv_software_single_step): Declare.
 269
 270         * riscv-tdep.c (riscv_isa_xlen): Drop static.
 271         * riscv-tdep.h (riscv_isa_xlen): Add extern declaration.
 272
 273 2018-08-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         PR gdb/18050:
 276         * target.c (dispose_inferior): Don't dispose of inferiors that are
 277         already killed.
 278
 279 2018-08-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>
 280
 281         * remote.c (remote_target::download_tracepoint): Change char* to
 282         const char*.
 283
 284 2018-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
 285
 286         * target.h (target_options_to_string): Return an std::string.
 287         * target.c (str_comma_list_concat_elem): Return void, use
 288         std::string.
 289         (do_option): Likewise.
 290         (target_options_to_string): Return an std::string.
 291         * linux-nat.c (linux_nat_target::wait): Adjust.
 292         * target-debug.h (target_debug_print_options): Adjust.
 293
 294 2018-08-07  Tom Tromey  <tom@tromey.com>
 295
 296         * Makefile.in (CPPFLAGS): New variable.
 297         (INTERNAL_CPPFLAGS): Use it.
 298
 299 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 300
 301         * NEWS: Mention the index cache.
 302
 303 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 304
 305         * common/pathstuff.h (get_standard_cache_dir): New.
 306         * common/pathstuff.c (get_standard_cache_dir): New.
 307         * build-id.h (build_id_to_string): New.
 308         * dwarf-index-common.h (INDEX4_SUFFIX, INDEX5_SUFFIX,
 309         DEBUG_STR_SUFFIX): Move to here.
 310         * dwarf-index-write.c (INDEX4_SUFFIX, INDEX5_SUFFIX,
 311         DEBUG_STR_SUFFIX): Move from there.
 312         (write_psymtabs_to_index): Make non-static, add basename
 313         parameter.  Write to temporary files, rename when done.
 314         (save_gdb_index_command): Adjust call to
 315         write_psymtabs_to_index.
 316         * dwarf2read.h (dwarf2_per_objfile) <index_cache_res>: New
 317         field.
 318         * dwarf2read.c (dwz_file) <index_cache_res>: New field.
 319         (get_gdb_index_contents_from_cache): New.
 320         (get_gdb_index_contents_from_cache_dwz): New.
 321         (dwarf2_initialize_objfile): Read index from cache.
 322         (dwarf2_build_psymtabs): Save to index.
 323         * dwarf-index-cache.h: New file.
 324         * dwarf-index-cache.c: New file.
 325         * dwarf-index-write.h: New file.
 326
 327 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 328
 329         * gnulib/aclocal.m4: Re-generate.
 330         * gnulib/config.in: Re-generate.
 331         * gnulib/configure: Re-generate.
 332         * gnulib/import/Makefile.am: Re-generate.
 333         * gnulib/import/Makefile.in: Re-generate.
 334         * gnulib/import/m4/gnulib-cache.m4: Re-generate.
 335         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
 336         * gnulib/import/m4/mkdir.m4: New file.
 337         * gnulib/import/mkdir.c: New file.
 338         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkdir
 339         module.
 340
 341 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 342
 343         * Makefile.in (COMMON_SFILES): Add common/scoped_mmap.c.
 344         * common/scoped_mmap.c: New file.
 345         * common/scoped_mmap.h (destroy): New method.
 346         (~scoped_mmap, reset): Use destroy.
 347         (scoped_mmap): New move constructor.
 348         (mmap_file): New declaration.
 349         * unittests/scoped_mmap-selftests.c (test_normal,
 350         test_invalid_filename, run_tests): New functions.
 351         (_initialize_scoped_mmap_selftests): Register selftest.
 352
 353 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 354
 355         * dwarf2read.c (read_gdb_index_from_section): Rename to...
 356         (read_gdb_index_from_buffer): ... this.  Remove section
 357         parameter, add buffer parameter.
 358         (get_gdb_index_contents_ftype,
 359         get_gdb_index_contents_dwz_ftype): New typedefs.
 360         (dwarf2_read_gdb_index): Add callback parameters to get the
 361         index contents.
 362         (get_gdb_index_contents_from_section): New.
 363         (dwarf2_initialize_objfile): Update call to
 364         dwarf2_read_gdb_index.
 365
 366 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 367
 368         * common/filestuff.h (gdb_fopen_cloexec): New overload.
 369         (gdb_open_cloexec): Likewise.
 370         * nat/linux-osdata.c (command_from_pid): Use string_printf.
 371         (commandline_from_pid): Likewise.
 372         (linux_xfer_osdata_threads): Likewise.
 373         (linux_xfer_osdata_fds): Likewise.
 374         * ada-lang.c (is_package_name): Likewise.
 375         * auxv.c (procfs_xfer_auxv): Likewise.
 376         * breakpoint.c (print_one_breakpoint_location): Use
 377         uiout::field_fmt.
 378         (print_one_catch_solib): Use string_printf.
 379         * coff-pe-read.c (add_pe_exported_sym): Likewise.
 380         (add_pe_forwarded_sym): Likewise.
 381         * dwarf2read.c (create_type_unit_group): Likewise.
 382         (build_error_marker_type): Likewise.
 383         * infcall.c (get_function_name): Likewise.
 384         * valprint.c (print_converted_chars_to_obstack): Likewise.
 385         * xtensa-tdep.c (xtensa_register_type): Likewise.
 386
 387 2018-08-06  Simon Marchi  <simon.marchi@ericsson.com>
 388
 389         * remote.c (remote_target::download_tracepoint): Fix format
 390         string errors.
 391
 392 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 393
 394         * tracefile.c: Include common/byte-vector.h.
 395         (trace_save): Change type of buf to gdb::byte_vector.  Initialize
 396         with trace_regblock_size if needed.  Update uses of buf.
 397
 398 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 399
 400         * tracepoint.h (collection_list) <m_regs_mask>: Change type to
 401         std::vector<unsigned char>.
 402         * tracepoint.c (collection_list::collection_list): Remove
 403         m_regs_mask initializer from initializer list.  Resize
 404         m_regs_mask using the largest remote register number.
 405         (collection_list::add_remote_register): Remove size check on
 406         m_regs_mask.  Use at to access element.
 407         (collection_list::stringify): Change type of temp_buf to
 408         gdb::char_vector.  Update uses of temp_buf.  Resize if needed to
 409         stringify the register mask.  Use pack_hex_byte for the register
 410         mask.
 411
 412 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 413
 414         * tracepoint.h (class collection_list) <add_register>: Remove.
 415         <add_remote_register, add_ax_registers, add_local_register>:
 416         Declare.
 417         <add_memrange>: Add scope parameter.
 418         * tracepoint.c (encode_actions_1): Likewise.
 419         (collection_list::add_register): Rename to ...
 420         (collection_list::add_remote_register): ... this.  Update
 421         comment.
 422         (collection_list::add_ax_registers, add_local_register): New
 423         methods.
 424         (collection_list::add_memrange): Add scope parameter.  Call
 425         add_local_register instead of add_register.
 426         (finalize_tracepoint_aexpr): New function.
 427         (collection_list::collect_symbol): Update calls to add_memrange.
 428         Call add_local_register instead of add_register.  Call
 429         add_ax_registers.  Call finalize_tracepoint_aexpr.
 430         (encode_actions_1): Get remote regnos for $reg action.  Call
 431         add_remote_register, add_ax_registers, and add_local_register.
 432         Update call to add_memrange.  Call finalize_tracepoint_aexpr.
 433         (validate_actionline): Call finalize_tracepoint_aexpr.
 434
 435 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 436
 437         * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
 438         Replace array buf with gdb::char_vector buf, of size
 439         get_remote_packet_size ().  Replace references to buf and
 440         BUF_SIZE to buf.data () and buf.size ().  Replace strcpy, strcat
 441         and xsnprintf with snprintf.  Raise errors if the buffer is too
 442         small.
 443
 444 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 445
 446         * remote.c (remote_target::download_tracepoint): Fix the has_more
 447         predicate in the QTDP action list iteration.
 448
 449 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 450
 451         * remote.c (remote_target::download_tracepoint): Fix indentation
 452         in for block.
 453
 454 2018-08-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 455
 456         * proc-api.c (_initialize_proc_api): Remove c, unused.
 457         * procfs.c (procfs_init_inferior): Remove signals, unused.
 458         (procfs_target::make_corefile_notes): Remove old_chain, fpregs,
 459         unused.
 460
 461 2018-08-06  Sergey Korolev  <s.korolev@ndmsystems.com>
 462             Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * linux-nat.c (linux_nat_target::follow_fork): Avoid using
 465         'W_STOPCODE (0)' as this could be ambiguous.
 466
 467 2018-08-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 468
 469         * ser-tcp.c (net_open): Fix thinko when deciding whether to
 470         disable TCP's Nagle algorithm (use "ai_protocol" instead of
 471         "ai_socktype").
 472
 473 2018-08-02  Tom Tromey  <tom@tromey.com>
 474
 475         PR symtab/16842.
 476         * dwarf2read.c (read_func_scope): Set symtab on template parameter
 477         symbols.
 478         (process_structure_scope): Likewise.
 479
 480 2018-08-02  Xavier Roirand  <roirand@adacore.com>
 481
 482         PR gdb/22629:
 483         * darwin-nat.c (darwin_kill_inferior): Fix handling of
 484         kill inferior.
 485
 486 2018-08-02  Tom Tromey  <tom@tromey.com>
 487
 488         * darwin-nat.c (find_inferior_task_it, darwin_find_thread)
 489         (darwin_suspend_inferior, darwin_resume_inferior)
 490         (darwin_decode_notify_message, darwin_resume_inferior_threads)
 491         (darwin_check_new_threads): Check result of get_darwin_inferior.
 492
 493 2018-07-31  Joel Brobecker  <brobecker@adacore.com>
 494
 495         GDB 8.1.1 released.
 496
 497 2018-07-31  Jan Vrany  <jan.vrany@fit.cvut.cz>
 498
 499         * varobj.c (varobj_get_path_expr_parent): Report an error if
 500         parent is a dynamic varobj.
 501
 502 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
 503
 504         * gnulib/aclocal.m4: Re-generate.
 505         * gnulib/config.in: Re-generate.
 506         * gnulib/configure: Re-generate.
 507         * gnulib/import/Makefile.in: Re-generate.
 508         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
 509         * gnulib/import/m4/onceonly.m4: Re-generate.
 510
 511 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
 512
 513         * target-descriptions.c (struct xml_test_tdesc): New.
 514         (xml_tdesc): Change type to std::vector<xml_test_tdesc>.
 515         (record_xml_tdesc): Update.
 516         (maintenance_check_xml_descriptions): Update.
 517         * target-descriptions.h (record_xml_tdesc): Update comment.
 518
 519 2018-07-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * eval.c (evaluate_subexp_for_sizeof): Check for array type before
 522         checking array bounds are defined.
 523
 524 2018-07-30  Tom Tromey  <tom@tromey.com>
 525
 526         * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
 527         irreflexivity violation.
 528
 529 2018-07-30  Tom Tromey  <tom@tromey.com>
 530
 531         * cli/cli-decode.c (lookup_cmd): Remove lint code.
 532         * value.c (unpack_long): Remove lint code.
 533         * valops.c (value_ind): Remove lint code.
 534         * valarith.c (value_x_binop, value_x_unop, value_equal)
 535         (value_pos): Remove lint code.
 536
 537 2018-07-28  Tom de Vries  <tdevries@suse.de>
 538
 539         * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type
 540         with undefined upper bound as <optimized out>.
 541
 542 2018-07-27  Sergio Durigan Junior  <sergiodj@redhat.com>
 543
 544         * gcore.in: Rename variable "name" to "prefix".  Expand
 545         "usage" text.
 546
 547 2018-07-14  Jon Turney  <jon.turney@dronecode.org.uk>
 548
 549         * windows-nat.c (windows_nat_target::create_inferior): Update to
 550         call close() in global namespace.
 551
 552 2018-07-26  Tom Tromey  <tom@tromey.com>
 553
 554         * dwarf-index-write.c (add_address_entry): Don't add objfile
 555         offsets.
 556         * dbxread.c (find_stab_function): Rename from
 557         find_stab_function_addr.  Return a bound_minimal_symbol.
 558         (read_dbx_symtab): Use raw_text_low, raw_text_high.
 559         Don't add objfile offsets.
 560         (end_psymtab): Use raw_text_low, raw_text_high,
 561         MSYMBOL_VALUE_RAW_ADDRESS.
 562         (read_ofile_symtab): Update.
 563         (process_one_symbol): Update.
 564         * dwarf2read.c (create_addrmap_from_index): Don't add objfile
 565         offsets.
 566         (dw2_relocate): Remove.
 567         (dw2_find_pc_sect_symtab): Bias PC by the text offset before
 568         searching addrmap.
 569         (dwarf2_gdb_index_functions, dwarf2_debug_names_functions):
 570         Update.
 571         (process_psymtab_comp_unit_reader, add_partial_symbol)
 572         (add_partial_subprogram, dwarf2_ranges_read): Update.
 573         (load_partial_dies): Update.
 574         (add_address_entry): Don't add objfile offsets.
 575         (dwarf2_build_include_psymtabs): Update.
 576         (create_addrmap_from_aranges): Don't add objfile offsets.
 577         (dw2_find_pc_sect_compunit_symtab): Update.
 578         * mdebugread.c (parse_symbol): Don't add objfile offsets.
 579         (parse_lines): Remove 'pst' parameter, replace with 'textlow'.
 580         Update.
 581         (parse_partial_symbols): Don't add objfile offsets.  Use
 582         raw_text_low, raw_text_high.  Update.
 583         (handle_psymbol_enumerators, psymtab_to_symtab_1): Update.
 584         * objfiles.c (objfile_relocate1): Don't relocate psymtabs_addrmap
 585         or call 'relocate' quick function.  Clear psymbol_map.
 586         * psympriv.h (struct partial_symbol) <address>: Add section
 587         offset.
 588         <set_unrelocated_address>: Rename from set_address.
 589         <raw_text_low, raw_text_high>: New methods.
 590         <text_low, text_high>: Add objfile parameter.
 591         (add_psymbol_to_bcache): Add 'section' parameter.  Call
 592         set_unrelocated_address.
 593         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 594         (find_pc_psymbol): Update.
 595         (fixup_psymbol_section, relocate_psymtabs): Remove.
 596         (dump_psymtab, psym_functions): Update.
 597         (add_psymbol_to_bcache, add_psymbol_to_list): Add 'section'
 598         parameter.
 599         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 600         (start_psymtab_common): Update.
 601         * symfile-debug.c (debug_qf_relocate): Remove.
 602         (debug_sym_quick_functions): Update.
 603         * symfile.h (struct quick_symbol_functions) <relocate>: Remove.
 604         * xcoffread.c (scan_xcoff_symtab): Don't add objfile offsets.
 605         Update.
 606
 607 2018-07-26  Tom Tromey  <tromey@redhat.com>
 608
 609         * dbxread.c (end_psymtab): Use text_high_valid and
 610         text_low_valid.
 611         * mdebugread.c (parse_partial_symbols): Use text_low_valid.
 612         (psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
 613         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
 614         Update comment.
 615         <text_low_valid, text_high_valid>: New fields.
 616         <set_text_low, set_text_high>: Update.
 617         * xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
 618
 619 2018-07-26  Tom Tromey  <tom@tromey.com>
 620
 621         * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
 622         Update.
 623         * dwarf2read.c (dwarf2_create_include_psymtab): Don't initialize
 624         textlow and texthigh fields.
 625         (process_psymtab_comp_unit_reader, dwarf2_build_include_psymtabs):
 626         Update.
 627         * mdebugread.c (parse_lines, parse_partial_symbols)
 628         (psymtab_to_symtab_1): Update.
 629         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
 630         Rename fields.  Update comment.  Now private.
 631         <text_low, text_high, set_text_low, set_text_high>: New methods.
 632         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 633         (find_pc_sect_psymbol, relocate_psymtabs, dump_psymtab)
 634         (start_psymtab_common, maintenance_info_psymtabs)
 635         (maintenance_check_psymtabs): Update.
 636         * xcoffread.c (xcoff_end_psymtab): Don't initialize textlow and
 637         texthigh fields.
 638         (scan_xcoff_symtab): Update.
 639
 640 2018-07-26  Tom Tromey  <tromey@redhat.com>
 641
 642         * psympriv.h (struct partial_symbol) <unrelocated_address,
 643         address, set_address>: New methods.
 644         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol)
 645         (fixup_psymbol_section, relocate_psymtabs): Update.
 646         (print_partial_symbols): Add 'objfile' parameter.  Update.
 647         (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map):
 648         Update.
 649
 650 2018-07-26  Tom Tromey  <tom@tromey.com>
 651
 652         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 653         (debug_names::write_psymbols): Update.
 654         * psympriv.h (struct partial_symbol): Derive from
 655         general_symbol_info.
 656         <obj_section>: New method.
 657         (PSYMBOL_DOMAIN, PSYMBOL_CLASS): Remove.n
 658         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 659         (find_pc_sect_psymbol, fixup_psymbol_section)
 660         (match_partial_symbol, lookup_partial_symbol, relocate_psymtabs)
 661         (print_partial_symbols, recursively_search_psymtabs)
 662         (compare_psymbols, psymbol_hash, psymbol_compare)
 663         (add_psymbol_to_bcache, maintenance_check_psymtabs)
 664         (psymbol_name_matches, psym_fill_psymbol_map): Update.
 665
 666 2018-07-26  Tom Tromey  <tromey@redhat.com>
 667
 668         * dbxread.c (end_psymtab): Remove dead code.
 669
 670 2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
 673         DWARF unwinders are disabled.
 674         * dwarf2-frame.c: Add dwarf2read.h include.
 675         (dwarf2_frame_sniffer): Exit early if DWARF unwinders are
 676         disabled.
 677         (dwarf2_frame_unwinders_enabled_p): Define.
 678         (show_dwarf_unwinders_enabled_p): New function.
 679         (_initialize_dwarf2_frame): Register switch to control DWARF
 680         unwinder use.
 681         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
 682         * dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
 683         (show_dwarf_cmdlist): Remove static keyword.
 684         * dwarf2read.h (set_dwarf_cmdlist): Declare.
 685         (show_dwarf_cmdlist): Declare.
 686         * NEWS: Document new feature.
 687
 688 2018-07-26  Tom de Vries  <tdevries@suse.de>
 689
 690         PR breakpoints/23366
 691         * infcmd.c (info_program_command): Handle ptid == minus_one_ptid.
 692
 693 2018-07-26  Tom de Vries  <tdevries@suse.de>
 694
 695         * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
 696         DW_AT_count can't be translated to a dynamic prop.
 697
 698 2018-07-25  Tom de Vries  <tdevries@suse.de>
 699
 700         * dwarf2loc.c (dwarf2_locexpr_baton_eval): Wrap ctx.eval call in
 701         try/catch.
 702
 703 2018-07-25  Jan Vrany  <jan.vrany@fit.cvut.cz>
 704
 705         * breakpoint.c (enable_disable_bp_num_loc): Notify observers.
 706
 707 2018-07-25  Joel Brobecker  <brobecker@adacore.com>
 708
 709         * MAINTAINERS (Global Maintainers): Add Tom Tromey.
 710
 711 2018-07-24  Keith Seitz  <keiths@redhat.comt
 712
 713         PR symtab/23010
 714         * dwarf2read.c (dw2_add_symbol_to_list): New function.
 715         (fixup_go_packaging, new_symbol): Use dw2_add_symbol_to_list
 716         instead of add_symbol_to_list.
 717         (read_file_scope): Call prepare_one_comp_unit before reading
 718         any other DIEs.
 719
 720 2018-07-24  Simon Marchi  <simon.marchi@ericsson.com>
 721
 722         * common/scoped_mmap.h (class scoped_mmap): Fix indentation.
 723
 724 2018-07-24  Tom Tromey  <tom@tromey.com>
 725
 726         * utils.c (malloc, realloc, free): Don't declare.
 727         * configure, config.in: Rebuild.
 728         * configure.ac: Don't check for declarations of free, malloc, or
 729         realloc.
 730
 731 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 732
 733         * aarch64-linux-nat.c
 734         (aarch64_linux_nat_target::stopped_data_address): Remove unused
 735         variable.
 736         * arm-linux-nat.c (fetch_regs): Likewise.
 737         (store_regs): Likewise.
 738         (fetch_vfp_regs): Likewise.
 739         (store_vfp_regs): Likewise.
 740         (arm_linux_nat_target::insert_hw_breakpoint): Likewise.
 741         (arm_linux_nat_target::remove_hw_breakpoint): Likewise.
 742         (arm_linux_nat_target::insert_watchpoint): Likewise.
 743         (arm_linux_nat_target::remove_watchpoint): Likewise.
 744         * mips-linux-nat.c (mips_linux_nat_target::insert_watchpoint):
 745         Likewise.
 746         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs):
 747         Likewise.
 748         * ppc-linux-nat.c (fetch_register): Likewise.
 749         (fetch_all_gp_regs): Likewise.
 750         (fetch_ppc_registers): Likewise.
 751         (store_all_gp_regs): Likewise.
 752         (store_ppc_registers): Likewise.
 753         (hwdebug_insert_point): Likewise.
 754         (can_use_watchpoint_cond_accel): Likewise.
 755         * remote-sim.c (gdb_os_write_stdout): Likewise.
 756
 757 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 758             Tom Tromey  <tom@tromey.com>
 759
 760         * warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
 761         test for it.
 762         * configure: Rebuild.
 763
 764 2018-07-22  Tom Tromey  <tom@tromey.com>
 765
 766         * regformats/regdat.sh: Define xmltarget_${name} inside
 767         #ifndef IN_PROCESS_AGENT.
 768
 769 2018-07-22  Tom Tromey  <tom@tromey.com>
 770
 771         * value.c (value_fetch_lazy_bitfield): Remove unused variable.
 772
 773 2018-07-22  Tom Tromey  <tom@tromey.com>
 774
 775         * symfile.c (reread_symbols): Notify iter, not objfile.
 776
 777 2018-07-22  Tom Tromey  <tom@tromey.com>
 778
 779         * ravenscar-thread.c (ravenscar_thread_target::store_registers):
 780         Use arch_ops.
 781         (ravenscar_thread_target::prepare_to_store): Likewise.
 782
 783 2018-07-22  Tom Tromey  <tom@tromey.com>
 784
 785         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
 786         unused variable.  Call value_fetch_lazy when needed.
 787         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 788         Remove unused variable.  Call value_fetch_lazy when needed.
 789
 790 2018-07-22  Tom Tromey  <tom@tromey.com>
 791
 792         * m32c-tdep.c (mark_dma): Return void.
 793         (make_regs): Remove unused declarations.
 794
 795 2018-07-22  Tom Tromey  <tom@tromey.com>
 796
 797         * guile/scm-cmd.c (gdbscm_dont_repeat): Call
 798         cmdscm_get_valid_command_smob_arg_unsafe for effect.
 799         * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
 800         bkscm_get_valid_block_smob_arg_unsafe for effect.
 801
 802 2018-07-22  Tom Tromey  <tom@tromey.com>
 803
 804         * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
 805         value_type.
 806
 807 2018-07-22  Tom Tromey  <tom@tromey.com>
 808
 809         * windows-nat.c (saved_context): Conditionally define.
 810         * remote.c (remote_target::remote_btrace_maybe_reopen):
 811         Conditionally declare "warned".
 812         * inflow.c (sigquit_ours): Conditionally define.
 813         (new_tty): Move "tty" declaration inside #if.
 814         * guile/guile.c (guile_datadir): Conditionally define.
 815         * charset.c (set_be_le_names): Move some declarations inside #if.
 816         * btrace.c (parse_xml_btrace): Move "errcode" declaration inside
 817         #if.
 818         (parse_xml_btrace_conf): Likewise.
 819
 820 2018-07-22  Tom Tromey  <tom@tromey.com>
 821
 822         * spu-tdep.c (spu_get_overlay_table): Remove unused variable.
 823
 824 2018-07-22  Tom Tromey  <tom@tromey.com>
 825
 826         * guile/scm-value.c (gdbscm_value_call): Remove unused variables.
 827         * guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
 828         (vlscm_convert_typed_value_from_scheme): Remove unused variable.
 829         * buildsym-legacy.c (get_macro_table): Remove unused variable.
 830         * stack.c (frame_apply_level_command): Remove unused variable.
 831         * tic6x-tdep.c (tic6x_push_dummy_call): Remove unused variable.
 832         * sparc64-tdep.c (adi_examine_command): Remove unused variable.
 833         * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Remove
 834         unused variable.
 835         * nios2-tdep.c (nios2_push_dummy_call): Remove unused variable.
 836         * mep-tdep.c (mep_push_dummy_call): Remove unused variable.
 837         * ada-lang.c (ada_lookup_symbol_list_worker): Remove unused
 838         variable.
 839         * amd64-tdep.c (amd64_supply_xsave): Remove unused variable.
 840         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Remove unused
 841         variable.
 842         * breakpoint.c (check_no_tracepoint_commands, update_watchpoint):
 843         Remove unused variable.
 844         * cli/cli-script.c (recurse_read_control_structure): Remove unused
 845         variable.
 846         * common/tdesc.c (print_xml_feature::visit): Remove unused
 847         variable.
 848         * compile/compile-object-load.c (store_regs): Remove unused
 849         variables.
 850         * complaints.c (clear_complaints): Remove unused variable.
 851         * corelow.c (core_target_open): Remove unused variable.
 852         * fbsd-tdep.c (fbsd_core_info_proc_status): Remove unused
 853         variable.
 854         * guile/scm-frame.c (gdbscm_frame_read_var): Remove unused
 855         variable.
 856         * guile/scm-symtab.c (stscm_print_sal_smob): Remove unused
 857         variable.
 858         * guile/scm-type.c (gdbscm_field_baseclass_p): Remove unused
 859         variable.
 860         * guile/scm-utils.c (gdbscm_parse_function_args): Remove unused
 861         variable.
 862         * hppa-tdep.c (hppa_stub_frame_unwind_cache): Remove unused
 863         variable.
 864         * ia64-tdep.c (examine_prologue): Remove unused variable.
 865         * infcall.c (run_inferior_call): Remove unused variable.
 866         * inferior.c (exit_inferior): Remove unused variable.
 867         * infrun.c (infrun_thread_ptid_changed): Remove unused variable.
 868         * linespec.c (decode_line_2): Remove unused variable.
 869         * linux-nat.c (super_close): Remove.
 870         * linux-tdep.c (linux_info_proc): Remove unused variable.
 871         * mi/mi-main.c (mi_execute_command): Remove unused variable.
 872         * microblaze-linux-tdep.c (microblaze_linux_sigtramp_cache):
 873         Remove unused variable.
 874         * parse.c (find_minsym_type_and_address): Remove unused variable.
 875         * printcmd.c (info_symbol_command, printf_floating): Remove unused
 876         variable.
 877         * python/py-breakpoint.c (bppy_set_commands): Remove unused
 878         variable.
 879         * python/py-unwind.c (unwind_infopy_dealloc): Remove unused
 880         variables.
 881         * record-btrace.c (record_btrace_target::store_registers): Remove
 882         unused variable.
 883         (cmd_show_record_btrace_cpu): Remove unused variable.
 884         * riscv-tdep.c (riscv_register_reggroup_p)
 885         (riscv_push_dummy_call, riscv_return_value): Remove unused
 886         variable.
 887         * rust-exp.y (literal): Remove unused variable.
 888         * rust-lang.c (rust_evaluate_subexp) <OP_RUST_ARARAY>: Remove
 889         unused variable.
 890         <STRUCTOP_ANONYMOUS>: Likewise.
 891         * s390-linux-tdep.c (s390_linux_init_abi_31)
 892         (s390_linux_init_abi_64): Remove unused variable.
 893         * ser-ming2.c (ser_windows_read_prim, pipe_select_thread)
 894         (file_select_thread, net_windows_open, _initialize_ser_windows):
 895         Remove unused variables.
 896         * symtab.c (find_pc_sect_line): Remove unused variable.
 897         * target-memory.c (compute_garbled_blocks): Remove unused
 898         variable.
 899         (target_write_memory_blocks): Remove unused variable.
 900         * target.c (target_stack::unpush): Remove unused variables.
 901         * tracepoint.c (start_tracing, all_tracepoint_actions)
 902         (merge_uploaded_trace_state_variables)
 903         (print_one_static_tracepoint_marker): Remove unused variable.
 904         * unittests/basic_string_view/element_access/char/1.cc (test01):
 905         Remove unused variable.
 906         * windows-nat.c (windows_continue, windows_add_all_dlls)
 907         (do_initial_windows_stuff, windows_nat_target::create_inferior):
 908         Remove unused variables.
 909
 910 2018-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
 911
 912         * arm-tdep.c (arm_gdbarch_init): Declare attr_arch and
 913         attr_profile in HAVE_ELF.
 914         * rs6000-tdep.c (bfd_uses_spe_extensions): Declare vector_abi in
 915         HAVE_ELF.
 916
 917 2018-07-20  Simon Marchi  <simon.marchi@polymtl.ca>
 918
 919         * frame.c (frame_register_unwind): Change parameter name.
 920         (frame_unwind_register): Likewise.
 921         (frame_unwind_register_value): Likewise.
 922         (frame_unwind_register_signed): Likewise.
 923         (frame_unwind_register_unsigned): Likewise.
 924         * frame.h (frame_register_unwind): Likewise.
 925         (frame_unwind_register): Likewise.
 926         (frame_unwind_register_value): Likewise.
 927         (frame_unwind_register_signed): Likewise.
 928         (frame_unwind_register_unsigned): Likewise.
 929         (frame_unwind_arch): Likewise.
 930
 931 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
 932
 933         * MAINTAINERS: Update my e-mail address, downgrade to MIPS I-IV
 934         ISA maintenance.
 935
 936 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
 937
 938         * mips-linux-nat.c (mips_linux_nat_target::read_description):
 939         Call `get_ptrace_pid' rather than extracting the ptrace PID by
 940         hand.
 941
 942 2018-07-20  Keith Seitz  <keiths@redhat.com>
 943
 944         * buildsym.h (struct buildsym_compunit) <m_objfile, m_subfiles,
 945         m_main_subfile, m_comp_dir, m_producer, m_debugformat,
 946         m_compunit_symtab, m_language>: Add "m_" prefix.
 947         Update all uses.
 948         * buildsym.c: Update all uses.
 949
 950 2018-07-20  Tom Tromey  <tom@tromey.com>
 951
 952         * buildsym-legacy.h (record_line): Don't use record_line_ftype.
 953         * buildsym.h (record_line_ftype): Remove typedef.
 954
 955 2018-07-20  Tom Tromey  <tom@tromey.com>
 956
 957         * buildsym-legacy.h (augment_type_symtab): Don't declare.
 958         (end_expandable_symtab): Likewise.
 959         (end_symtab_get_static_block): Likewise.
 960         (end_symtab_from_static_block): Likewise.
 961         * buildsym-legacy.c (augment_type_symtab): Remove.
 962         (end_expandable_symtab): Remove.
 963         (end_symtab_get_static_block): Remove.
 964         (end_symtab_from_static_block): Remove.
 965
 966 2018-07-20  Tom Tromey  <tom@tromey.com>
 967
 968         * dwarf2read.c: Include buildsym.h.
 969         (struct dwarf2_cu) <builder>: New method.
 970         (fixup_go_packaging): Update.
 971         (process_full_comp_unit, process_full_type_unit): Update.  Don't
 972         use scoped_free_pendings.
 973         (using_directives): Add "cu" parameter, remove "language".
 974         (read_import_statement, setup_type_unit_groups, )
 975         (read_func_scope, read_lexical_block_scope)
 976         (dwarf2_record_block_ranges, read_namespace): Update.
 977         (lnp_state_machine::lnp_state_machine): Add cu parameter.
 978         (lnp_state_machine::handle_end_sequence): Update.
 979         (class lnp_state_machine) <m_cu>: New member.
 980         <m_record_line_callback>: Remove.
 981         <m_currently_recording_lines>: New member.
 982         (lnp_state_machine::handle_set_file): Update.
 983         (noop_record_line): Remove.
 984         (dwarf_record_line_p): Add cu parameter.
 985         (dwarf_record_line_1, dwarf_finish_line): Likewise.
 986         (lnp_state_machine::record_line)
 987         (lnp_state_machine::lnp_state_machine)
 988         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 989         (dwarf_decode_lines): Update.
 990         (dwarf2_start_subfile): Add cu parameter.
 991         (dwarf2_start_symtab, new_symbol): Update.
 992         (macro_start_file, dwarf_decode_macro_bytes): Add cu parameter.
 993         Remove dwarf2_per_objfile parameter.
 994         (dwarf_decode_macros): Update.
 995
 996 2018-07-20  Tom Tromey  <tom@tromey.com>
 997
 998         * stabsread.c (define_symbol): Update.
 999         * buildsym-legacy.h (get_buildsym_compunit): Declare.
1000         * dwarf2read.c (new_symbol): Update.
1001         * cp-support.h (cp_scan_for_anonymous_namespaces): Update.
1002         * cp-namespace.c: Include buildsym.h.
1003         (cp_scan_for_anonymous_namespaces): Add "compunit" parameter.
1004         * buildsym-legacy.c (get_buildsym_compunit): New function.
1005
1006 2018-07-20  Tom Tromey  <tom@tromey.com>
1007
1008         * xcoffread.c: Include buildsym-legacy.h.
1009         * windows-nat.c: Include buildsym-legacy.h.
1010         * stabsread.c: Include buildsym-legacy.h.
1011         * mdebugread.c: Include buildsym-legacy.h.
1012         * buildsym-legacy.h: New file.
1013         * buildsym-legacy.c: New file, from buildsym.c.
1014         * go32-nat.c: Include buildsym-legacy.h.
1015         * dwarf2read.c: Include buildsym-legacy.h.
1016         * dbxread.c: Include buildsym-legacy.h.
1017         * cp-namespace.c: Include buildsym-legacy.h.
1018         * coffread.c: Include buildsym-legacy.h.
1019         * buildsym.h: Move some contents to buildsym-legacy.h.
1020         * buildsym.c: Include buildsym-legacy.h.  Move many functions to
1021         buildsym-legacy.c.
1022         * Makefile.in (HFILES_NO_SRCDIR): Add buildsym-legacy.h.
1023
1024 2018-07-20  Tom Tromey  <tom@tromey.com>
1025
1026         * buildsym.h (struct buildsym_compunit): Move from buildsym.c.
1027         * buildsym.c (struct buildsym_compunit): Move to buildsym.h.
1028         (buildsym_compunit::buildsym_compunit)
1029         (buildsym_compunit::~buildsym_compunit)
1030         (buildsym_compunit::get_macro_table): Define.
1031
1032 2018-07-20  Tom Tromey  <tom@tromey.com>
1033
1034         * buildsym.c (reset_symtab_globals): Remove.
1035         (buildsym_compunit::end_symtab_from_static_block): Update.
1036         (buildsym_compunit::augment_type_symtab): Update.
1037         (end_symtab_from_static_block): Call free_buildsym_compunit.
1038         (augment_type_symtab, end_symtab, end_expandable_symtab):
1039         Likewise.
1040
1041 2018-07-20  Tom Tromey  <tom@tromey.com>
1042
1043         * arch-utils.c: Do not include buildsym.h.
1044         * mipsread.c: Do not include buildsym.h.
1045         * machoread.c: Do not include buildsym.h.
1046         * elfread.c: Do not include buildsym.h.
1047
1048 2018-07-20  Tom Tromey  <tom@tromey.com>
1049
1050         * buildsym.c (buildsym_compunit::buildsym_compunit): Do more
1051         initialization.
1052         (buildsym_compunit): Add new constructor.
1053         (struct buildsym_compunit) <get_last_source_file, finish_block,
1054         record_block_range, start_subfile, patch_subfile_names,
1055         push_subfile, pop_subfile, record_line, get_compunit_symtab,
1056         set_last_source_start_addr, get_last_source_start_addr,
1057         get_local_using_directives, set_local_using_directives,
1058         get_global_using_directives, outermost_context_p,
1059         get_current_context_stack, get_context_stack_depth,
1060         get_current_subfile, get_local_symbols, get_file_symbols,
1061         get_global_symbols, record_debugformat, record_producer,
1062         push_context, pop_context, end_symtab_get_static_block,
1063         end_symtab_from_static_block, end_symtab, end_expandable_symtab>:
1064         New public methods.
1065         <record_pending_block, finish_block_internal, make_blockvector,
1066         watch_main_source_file_lossage, end_symtab_with_blockvector>: New
1067         private methods.
1068         Update all users.
1069
1070 2018-05-22  Tom Tromey  <tom@tromey.com>
1071
1072         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
1073         parameter.
1074         (finish_block_internal): Update.
1075
1076 2018-07-20  Tom Tromey  <tom@tromey.com>
1077
1078         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
1079         parameter.
1080         (finish_block_internal): Update.
1081
1082 2018-07-20  Tom Tromey  <tom@tromey.com>
1083
1084         * buildsym.h (EXTERN): Don't define or undef.
1085         * buildsym.c (EXTERN): Don't define.
1086
1087 2018-07-20  Tom Tromey  <tom@tromey.com>
1088
1089         * buildsym.c: Remove TODO comment.
1090
1091 2018-07-20  Tom Tromey  <tom@tromey.com>
1092
1093         * coffread.c (coff_symtab_read): Update.
1094         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1095         (xcoff_new_init): Update.
1096         * mipsread.c (mipscoff_new_init): Update.
1097         * mdebugread.c (mdebug_build_psymtabs): Update.
1098         * elfread.c (elf_new_init): Update.
1099         * dwarf2read.c (process_full_comp_unit, process_full_type_unit):
1100         Update.
1101         * dbxread.c (dbx_new_init, dbx_psymtab_to_symtab_1)
1102         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1103         (stabsect_build_psymtabs): Update.
1104         * buildsym.h (buildsym_init): Don't declare.
1105         * buildsym.c: Update comment.
1106         (prepare_for_building): Remove.
1107         (start_symtab, restart_symtab): Update.
1108         (reset_symtab_globals): Update comment.
1109         (buildsym_init): Remove.
1110
1111 2018-07-20  Tom Tromey  <tom@tromey.com>
1112
1113         * xcoffread.c (read_xcoff_symtab, process_xcoff_symbol): Update.
1114         * stabsread.c (patch_block_stabs, define_symbol, read_type)
1115         (read_enum_type, common_block_start, common_block_end)
1116         (cleanup_undefined_types_1, finish_global_stabs): Update.
1117         * mdebugread.c (psymtab_to_symtab_1): Update.
1118         * dwarf2read.c (fixup_go_packaging, read_func_scope)
1119         (read_lexical_block_scope, new_symbol): Update.
1120         * dbxread.c (process_one_symbol): Update.
1121         * coffread.c (coff_symtab_read, process_coff_symbol)
1122         (coff_read_enum_type): Update.
1123         * buildsym.h (file_symbols, global_symbols, local_symbols): Don't
1124         declare.
1125         (get_local_symbols, get_file_symbols, get_global_symbols): New
1126         functions.
1127         * buildsym.c (~buildsym_compunit): Clean up m_file_symbols and
1128         m_global_symbols.
1129         <m_file_symbols, m_local_symbols, m_global_symbols>: New members.
1130         (~scoped_free_pendings): Update.
1131         (finish_block, prepare_for_building, reset_symtab_globals)
1132         (end_symtab_get_static_block, end_symtab_with_blockvector)
1133         (augment_type_symtab, push_context): Update.
1134         (get_local_symbols, get_file_symbols, get_global_symbols): New
1135         functions.
1136         (buildsym_init): Update.
1137
1138 2018-07-20  Tom Tromey  <tom@tromey.com>
1139
1140         * dwarf2read.c (process_full_comp_unit): Do not set list_in_scope.
1141         (process_full_type_unit): Likewise.
1142         (dwarf2_start_symtab): Set list_in_scope.
1143
1144 2018-07-20  Tom Tromey  <tom@tromey.com>
1145
1146         * dwarf2read.c (process_psymtab_comp_unit_reader)
1147         (build_type_psymtabs_reader): Do not set list_in_scope.
1148
1149 2018-07-20  Tom Tromey  <tom@tromey.com>
1150
1151         * buildsym.c (free_pendings): Remove.
1152         (add_symbol_to_list, scoped_free_pendings)
1153         (finish_block_internal, buildsym_init): Update.
1154
1155 2018-07-20  Tom Tromey  <tom@tromey.com>
1156
1157         * xcoffread.c (read_xcoff_symtab): Update.
1158         * dwarf2read.c (read_func_scope, read_lexical_block_scope):
1159         Update.
1160         * dbxread.c (process_one_symbol): Update.
1161         * coffread.c (coff_symtab_read): Update.
1162         * buildsym.h (finish_block): Update.
1163         * buildsym.c (finish_block): Remove "listhead" argument.
1164         (end_symtab_get_static_block): Update.
1165
1166 2018-07-20  Tom Tromey  <tom@tromey.com>
1167
1168         * buildsym.h (class scoped_free_pendings): Remove constructor.
1169         * buildsym.c (struct buildsym_compunit) <free_pending_blocks>: New
1170         method.
1171         <m_pending_block_obstack, m_pending_blocks>: New members.
1172         (pending_block_obstack, pending_blocks): Remove.
1173         (scoped_free_pendings::scoped_free_pendings): Default.
1174         (~scoped_free_pendings): Update.
1175         (free_pending_blocks): Remove.
1176         (finish_block_internal, record_pending_block, make_blockvector)
1177         (end_symtab_get_static_block, augment_type_symtab, push_context)
1178         (buildsym_init): Update.
1179
1180 2018-07-20  Tom Tromey  <tom@tromey.com>
1181
1182         * buildsym.c (struct buildsym_compunit) <m_pending_addrmap,
1183         m_pending_addrmap_obstack, m_pending_addrmap_interesting>: New
1184         members.
1185         (pending_addrmap, pending_addrmap_obstack)
1186         (pending_addrmap_interesting): Remove.
1187         (scoped_free_pendings, record_block_range, make_blockvector)
1188         (prepare_for_building, reset_symtab_globals, buildsym_init):
1189         Update.
1190
1191 2018-07-20  Tom Tromey  <tom@tromey.com>
1192
1193         * xcoffread.c (process_linenos): Update.
1194         * stabsread.c (define_symbol, read_type, read_enum_type): Update.
1195         * mdebugread.c (psymtab_to_symtab_1): Update.
1196         * dwarf2read.c (setup_type_unit_groups)
1197         (lnp_state_machine::handle_set_file, dwarf_record_line_p)
1198         (lnp_state_machine::record_line, dwarf_decode_lines): Update.
1199         * dbxread.c (process_one_symbol): Update.
1200         * coffread.c (coff_symtab_read, enter_linenos)
1201         (process_coff_symbol): Update.
1202         * buildsym.h (current_subfile): Don't declare.
1203         (get_current_subfile): Declare.
1204         * buildsym.c (struct buildsym_compunit) <m_current_subfile>: New
1205         member.
1206         (start_subfile, free_buildsym_compunit, push_subfile)
1207         (prepare_for_building, start_symtab): Update.
1208         (get_current_subfile): New function.
1209
1210 2018-07-20  Tom Tromey  <tom@tromey.com>
1211
1212         * coffread.c (coff_symtab_read): Update.
1213         * xcoffread.c (read_xcoff_symtab): Update.
1214         * dwarf2read.c (new_symbol): Update.
1215         (read_func_scope, read_lexical_block_scope): Update.
1216         * dbxread.c (process_one_symbol): Update.
1217         * buildsym.h (context_stack, context_stack_depth): Don't declare.
1218         (outermost_context_p): Remove macro.
1219         (outermost_context_p, get_current_context_stack)
1220         (get_context_stack_depth): Declare.
1221         (pop_context): Return struct context_stack.
1222         * buildsym.c (struct buildsym_compunit) <m_context_stack: New
1223         member.
1224         (context_stack_size): Remove.
1225         (INITIAL_CONTEXT_STACK_SIZE): Remove.
1226         (prepare_for_building, end_symtab_get_static_block)
1227         (augment_type_symtab, push_context): Update.
1228         (pop_context): Return struct context_stack.
1229         (outermost_context_p, get_current_context_stack)
1230         (get_context_stack_depth): New functions.
1231         (buildsym_init): Update.
1232
1233 2018-07-20  Tom Tromey  <tom@tromey.com>
1234
1235         * rust-exp.y: Now a pure parser.  Update all rules.
1236         (%union): Move earlier.
1237         (current_parser, work_obstack): Remove globals.
1238         (rust_parser, ~rust_parser): Update.
1239         (class rust_parser) <copy_name, concat3, crate_name, super_name,
1240         lex_character, lex_number, lex_string, lex_identifier,
1241         rust_lookup_type, convert_params_to_types, convert_ast_to_type,
1242         convert_name, convert_params_to_expression,
1243         convert_ast_to_expression, ast_basic_type, ast_operation,
1244         ast_compound_assignment, rust_op, ast_literal, ast_dliteral,
1245         ast_structop, ast_structop_anonymous, ast_unary, ast_cast,
1246         ast_call_ish, ast_path, ast_string, ast_struct, ast_range,
1247         ast_array_type, ast_slice_type, ast_reference_type,
1248         ast_pointer_type, ast_function_type, ast_tuple_type>: New methods.
1249         (rust_parse): Update.
1250         (rustyyerror, rustyylex): Add parser parameter.
1251         (rust_lex_test_one, rust_lex_int_test, rust_lex_exception_test)
1252         (rust_lex_stringish_test, rust_lex_test_sequence)
1253         (rust_lex_test_trailing_dot, rust_lex_test_completion)
1254         (rust_lex_test_push_back, rust_lex_tests): Update.
1255
1256 2018-07-19  Pedro Alves  <palves@redhat.com>
1257
1258         * guile/guile-internal.h (gdbscm_scm_to_c_string): Now returns a
1259         gdb::unique_xmalloc_ptr.
1260         * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x):
1261         Adjust to use dbscm_wrap and gdb::unique_xmalloc_ptr.
1262         * guile/scm-exception.c (gdbscm_exception_message_to_string): Use
1263         copy-initialization.
1264         * guile/scm-pretty-print.c (ppscm_print_children): Use
1265         gdb::unique_xmalloc_ptr instead of cleanups.
1266         (gdbscm_apply_val_pretty_printer): Remove cleanups.
1267         * guile/scm-string.c (gdbscm_scm_to_c_string): Now returns a
1268         gdb::unique_xmalloc_ptr.
1269         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
1270         Adjust to use gdb::unique_xmalloc_ptr.
1271         * guile/scm-utils.c (extract_arg): Adjust.
1272         * guile/scm-value.c (gdbscm_value_field): Adjust to use
1273         gdb::unique_xmalloc_ptr instead of a cleanup.
1274
1275 2018-07-19  Tom Tromey  <tom@tromey.com>
1276
1277         * utils.c (do_value_free_to_mark)
1278         (make_cleanup_value_free_to_mark): Remove.
1279         * utils.h (make_cleanup_value_free_to_mark): Remove.
1280
1281 2018-07-19  Pedro Alves  <palves@redhat.com>
1282
1283         * guile/guile-internal.h (gdbscm_wrap): Really make 'args' a
1284         forwarding reference.
1285
1286 2018-07-18  Pedro Alves  <palves@redhat.com>
1287
1288         * guile/guile.c (gdbscm_execute_gdb_command): Adjust to use
1289         gdbscm_wrap.  Use gdb::unique_xmalloc_ptr<char> instead of a
1290         cleanup.
1291
1292 2018-07-18  Pedro Alves  <palves@redhat.com>
1293
1294         * guile/guile-internal.h: Add comment about mixing GDB and Scheme
1295         exceptions.
1296         (GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS): Delete.
1297         (gdbscm_wrap): New.
1298         * guile/scm-frame.c (gdbscm_frame_read_register): Use xfree
1299         directly instead of a cleanup.
1300         * guile/scm-math.c (vlscm_unop_gdbthrow): New, factored out from ...
1301         (vlscm_unop): ... this.  Reimplement using gdbscm_wrap.
1302         (vlscm_binop_gdbthrow): New, factored out from ...
1303         (vlscm_binop): ... this.  Reimplement using gdbscm_wrap.
1304         (vlscm_rich_compare): Use gdbscm_wrap.
1305         * guile/scm-symbol.c (gdbscm_lookup_symbol): Use xfree directly
1306         instead of a cleanup.
1307         (gdbscm_lookup_global_symbol): Use xfree directly instead of a
1308         cleanup.
1309         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
1310         Use xfree directly instead of a cleanup.
1311         * guile/scm-value.c (gdbscm_make_value, gdbscm_make_lazy_value):
1312         Adjust to use gdbscm_wrap and scoped_value_mark.
1313         (gdbscm_value_optimized_out_p): Adjust to use gdbscm_wrap.
1314         (gdbscm_value_address, gdbscm_value_dereference)
1315         (gdbscm_value_referenced_value): Adjust to use gdbscm_wrap and
1316         scoped_value_mark.
1317         (gdbscm_value_dynamic_type): Use scoped_value_mark.
1318         (vlscm_do_cast, gdbscm_value_field): Adjust to use gdbscm_wrap and
1319         scoped_value_mark.
1320         (gdbscm_value_subscript, gdbscm_value_call): Adjust to use
1321         gdbscm_wrap and scoped_value_mark.
1322         (gdbscm_value_to_string): Use xfree directly instead of a
1323         cleanup.  Move 'buffer' unique_ptr to TRY scope.
1324         (gdbscm_value_to_lazy_string): Use xfree directly instead of a
1325         cleanup.  Move 'buffer' unique_ptr to TRY scope.  Use
1326         scoped_value_mark.
1327         (gdbscm_value_fetch_lazy_x): Use gdbscm_wrap.
1328         (gdbscm_parse_and_eval): Adjust to use gdbscm_wrap and
1329         scoped_value_mark.
1330         (gdbscm_history_ref, gdbscm_history_append_x): Adjust to use
1331         gdbscm_wrap.
1332
1333 2018-07-18  Tom de Vries  <tdevries@suse.de>
1334
1335         * findvar.c (default_read_var_value): Also resolve dynamic type for
1336         LOC_OPTIMIZED_OUT vars.
1337
1338 2018-07-18  Maciej W. Rozycki  <macro@mips.com>
1339
1340         * mips-tdep.c (micromips_next_pc): Add SYSCALL instruction
1341         decoding.
1342
1343 2018-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * guile/scm-param.c (pascm_set_func, pascm_show_func)
1346         (compute_enum_list, pascm_set_param_value_x)
1347         (gdbscm_parameter_value): Update.
1348         * guile/guile-internal.h (gdbscm_scm_to_string): Update.
1349         (gdbscm_scm_to_host_string): Update.
1350         * guile/scm-math.c (vlscm_convert_typed_value_from_scheme):
1351         Update.
1352         * guile/scm-cmd.c (cmdscm_add_completion): Update.
1353         * guile/scm-pretty-print.c (ppscm_print_string_repr): Update.
1354         * guile/scm-string.c (gdbscm_scm_to_string): Return
1355         unique_xmalloc_ptr.
1356         (gdbscm_scm_to_host_string): Likewise.
1357
1358 2018-07-17  Tom Tromey  <tom@tromey.com>
1359
1360         * guile/guile.c (gdbscm_eval_from_control_command): Update.
1361         * guile/guile-internal.h (gdbscm_safe_eval_string): Update.
1362         * guile/scm-objfile.c (gdbscm_execute_objfile_script): Update.
1363         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Return
1364         unique_xmalloc_ptr.
1365
1366 2018-07-17  Tom Tromey  <tom@tromey.com>
1367
1368         * guile/scm-param.c (pascm_signal_setshow_error): Update.
1369         * guile/guile-internal.h (gdbscm_exception_message_to_string):
1370         Update.
1371         * guile/scm-cmd.c (cmdscm_function): Update.
1372         * guile/scm-pretty-print.c
1373         (ppscm_print_exception_unless_memory_error): Update.
1374         * guile/scm-exception.c (gdbscm_exception_message_to_string):
1375         Return unique_xmalloc_ptr.
1376
1377 2018-07-17  Tom Tromey  <tom@tromey.com>
1378
1379         * guile/scm-pretty-print.c (ppscm_make_pp_type_error_exception):
1380         Use string_printf.
1381
1382 2018-07-17  Jim Wilson  <jimw@sifive.com>
1383
1384         * riscv-tdep.c (riscv_has_feature): Delete comment that refers to
1385         set_gdbarch_decr_pc_after_break.  Call riscv_read_misa_reg always.
1386         (riscv_gdbarch_init): Delete local has_compressed_isa.  Delete now
1387         unecessary braces after EF_RISCV_RVC test.  Delete call to
1388         set_gdbarch_decr_pc_after_break.
1389
1390         * riscv-tdep.h (DECLARE_CSR): Use RISCV_FIRST_CSR_REGNUM instead of
1391         RISCV_LAST_FP_REGNUM + 1.
1392         (RSICV_CSR_LEGACY_MISA_REGNUM): Add RISCV_FIRST_CSR_REGNUM.
1393
1394 2018-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * configure.ac: Remove --disable-gdbcli.
1397         * configure: Rebuild.
1398         * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS)
1399         (SUBDIR_CLI_CFLAGS): Remove.
1400         (SFILES): Use SUBDIR_CLI_SRCS.
1401         (COMMON_OBS): Use SUBDIR_CLI_OBS.
1402
1403 2018-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         PR gdb/18624:
1406         * coffread.c (coff_symtab_read): Use scoped_free_pendings.
1407
1408 2018-07-16  Jim Wilson  <jimw@sifive.com>
1409
1410         * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
1411
1412 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1413
1414         * ia64-libunwind-tdep.c (libunwind_frame_cache): Remove unused
1415         variable.
1416         (libunwind_frame_sniffer): Likewise.
1417         (libunwind_frame_prev_register): Likewise.
1418         (libunwind_sigtramp_frame_sniffer): Likewise.
1419         * ia64-tdep.c (ia64_access_reg): Likewise.
1420         (ia64_access_rse_reg): Likewise.
1421         (ia64_libunwind_sigtramp_frame_this_id): Likewise.
1422         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Likewise.
1423
1424 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1425
1426         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Add cast.
1427
1428 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1429
1430         * remote-sim.c (gdbsim_target::close,
1431         gdbsim_target::mourn_inferior): Remove unused variables.
1432
1433 2018-07-16  Simon Marchi  <simon.marchi@polymtl.ca>
1434
1435         * ia64-tdep.c (ktab_buf): New global.
1436         (getunwind_table): Return a gdb::optional<gdb::byte_vector>.
1437         (get_kernel_table): Adjust.
1438
1439 2018-07-16  Tom Tromey  <tom@tromey.com>
1440
1441         * xcoffread.c (read_xcoff_symtab): Use outermost_context_p.
1442         * dwarf2read.c (using_directives, new_symbol): Use
1443         outermost_context_p.
1444         * dbxread.c (process_one_symbol): Use outermost_context_p.
1445         * coffread.c (coff_symtab_read): Use outermost_context_p.
1446
1447 2018-07-16  Tom Tromey  <tom@tromey.com>
1448
1449         * dwarf2read.c (using_directives, read_func_scope)
1450         (read_lexical_block_scope): Update.
1451         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1452         * buildsym.h (local_using_directives, global_using_directives):
1453         Don't declare.
1454         (get_local_using_directives, set_local_using_directives)
1455         (get_global_using_directives): Declare.
1456         * buildsym.c (struct buildsym_compunit) <m_local_using_directives,
1457         m_global_using_directives>: New members.
1458         (finish_block_internal, prepare_for_building)
1459         (reset_symtab_globals, end_symtab_get_static_block)
1460         (push_context): Update.
1461         (get_local_using_directives, set_local_using_directives)
1462         (get_global_using_directives): New functions.
1463         (buildsym_init): Update.
1464
1465 2018-07-16  Tom Tromey  <tom@tromey.com>
1466
1467         * xcoffread.c (xcoff_initial_scan): Don't call
1468         free_pending_blocks.
1469         * dbxread.c (dbx_symfile_read): Don't call free_pending_blocks.
1470         * buildsym.h (class scoped_free_pendings): Add constructor.
1471         (free_pending_blocks): Don't declare.
1472         * buildsym.c (scoped_free_pendings::scoped_free_pendings): New.
1473         (free_pending_blocks): Now static.
1474
1475 2018-07-16  Tom Tromey  <tom@tromey.com>
1476
1477         * buildsym.h (push_subfile, pop_subfile): Update declarations.
1478         * buildsym.c (struct buildsym_compunit) <m_subfile_stack>: New
1479         member.
1480         (struct subfile_stack): Remove.
1481         (subfile_stack): Remove.
1482         (push_subfile, pop_subfile, buildsym_init): Update.
1483
1484 2018-07-16  Tom Tromey  <tom@tromey.com>
1485
1486         * buildsym.c (push_subfile): Use gdb_assert.
1487         (pop_subfile): Use gdb_assert.
1488
1489 2018-07-16  Tom Tromey  <tom@tromey.com>
1490
1491         * buildsym.h (merge_symbol_lists): Remove.
1492         * buildsym.c (merge_symbol_lists): Remove.
1493
1494 2018-07-16  Tom Tromey  <tom@tromey.com>
1495
1496         * stabsread.c (scan_file_globals): Update comment.
1497         * stabsread.h (scan_file_globals): Move from buildsym.h.
1498         * buildsym.h (scan_file_globals): Move to stabsread.h.
1499
1500 2018-07-16  Tom Tromey  <tom@tromey.com>
1501
1502         * xcoffread.c (xcoff_new_init): Update.
1503         * mipsread.c (mipscoff_new_init): Update.
1504         * mdebugread.c (mdebug_build_psymtabs): Update.
1505         * elfread.c (elf_new_init): Update.
1506         * dbxread.c (dbx_new_init, coffstab_build_psymtabs)
1507         (elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
1508         * buildsym.h (buildsym_new_init): Don't declare.
1509         * buildsym.c (buildsym_new_init): Remove.
1510
1511 2018-07-16  Tom Tromey  <tom@tromey.com>
1512
1513         * stabsread.h (within_function): Move from buildsym.h.
1514         * stabsread.c (start_stabs): Clear within_function.
1515         * coffread.c (coff_start_symtab): Clear within_function.
1516         * buildsym.h (within_function): Move to stabsread.h.
1517         * buildsym.c (prepare_for_building): Update.
1518
1519 2018-07-16  Tom Tromey  <tom@tromey.com>
1520
1521         * stabsread.h (processing_gcc_compilation): Move from buildsym.h.
1522         * dwarf2read.c (dwarf2_start_symtab): Don't set
1523         processing_gcc_compilation.
1524         * buildsym.h (processing_gcc_compilation): Move to stabsread.h.
1525
1526 2018-07-16  Tom Tromey  <tom@tromey.com>
1527
1528         * stabsread.h (HASHSIZE, hashname, symnum, next_symbol_text)
1529         (next_symbol_text_func): Move from buildsym.h.
1530         * stabsread.c (hashname): Move from buildsym.c.
1531         * buildsym.h (HASHSIZE, symnum, next_symbol_text)
1532         (next_symbol_text_func, hashname): Move to stabsread.h.
1533         * buildsym.c: Don't include bcache.h
1534         (hashname): Move to stasbread.c.
1535
1536 2018-07-16  Tom Tromey  <tom@tromey.com>
1537
1538         * buildsym.h (context_stack_size): Don't declare.
1539         * buildsym.c (context_stack_size): New global.
1540
1541 2018-07-16  Tom Tromey  <tom@tromey.com>
1542
1543         * dbxread.c (processing_acc_compilation): New global.
1544         * buildsym.h (processing_acc_compilation): Don't declare.
1545
1546 2018-07-16  Tom Tromey  <tom@tromey.com>
1547
1548         * xcoffread.c (aix_process_linenos, complete_symtab): Update.
1549         * dbxread.c (read_ofile_symtab): Update.
1550         * coffread.c (coff_start_symtab, coff_end_symtab): Update.
1551         * buildsym.h (last_source_start_addr): Remove.
1552         (set_last_source_start_addr, get_last_source_start_addr):
1553         Declare.
1554         * buildsym.c (buildsym_compunit::buildsym_compunit): Add last_addr
1555         parameter.
1556         (struct buildsym_compunit) <m_last_source_start_addr>: New
1557         member.
1558         (prepare_for_building): Remove start_addr parameter.
1559         (start_symtab, restart_symtab, end_symtab_get_static_block)
1560         (end_symtab_with_blockvector): Update.
1561         (set_last_source_start_addr, get_last_source_start_addr): New
1562         functions.
1563
1564 2018-07-16  Tom Tromey  <tom@tromey.com>
1565
1566         * buildsym.c (struct buildsym_compunit) <m_have_line_numbers>: New
1567         member.
1568         (have_line_numbers): Remove.
1569         (record_line, prepare_for_building, end_symtab_get_static_block)
1570         (augment_type_symtab): Update.
1571
1572 2018-07-16  Tom Tromey  <tom@tromey.com>
1573
1574         * buildsym.c (~buildsym_compunit): Free the macro table.
1575         (struct buildsym_compunit) <get_macro_table, release_macros>: New
1576         methods.
1577         <m_pending_macros>: New member.
1578         (pending_macros): Remove.
1579         (~scoped_free_pendings, get_macro_table, prepare_for_building)
1580         (reset_symtab_globals, end_symtab_get_static_block)
1581         (end_symtab_with_blockvector, augment_type_symtab)
1582         (buildsym_init): Update.
1583
1584 2018-07-16  Tom Tromey  <tom@tromey.com>
1585
1586         * buildsym.c (buildsym_compunit::buildsym_compunit): Add name
1587         parameter.
1588         (buildsym_compunit::set_last_source_file): New method.
1589         <m_last_source_file>: New member.
1590         (prepare_for_building): Remove "name" parameter.
1591         (start_symtab, restart_symtab, reset_symtab_globals): Update.
1592         (last_source_file): Remove.
1593         (set_last_source_file, get_last_source_file): Update.
1594
1595 2018-07-16  Tom Tromey  <tom@tromey.com>
1596
1597         * buildsym.c (prepare_for_building): Add assert.
1598
1599 2018-07-16  Tom Tromey  <tom@tromey.com>
1600
1601         * buildsym.c (~buildsym_compunit): Update.
1602         (struct buildsym_compunit) <comp_unit>: Now a unique_xmalloc_ptr.
1603         (start_subfile, patch_subfile_names)
1604         (end_symtab_with_blockvector): Update.
1605
1606 2018-07-16  Tom Tromey  <tom@tromey.com>
1607
1608         * buildsym.c (struct buildsym_compunit): Add constructor,
1609         destructor, initializers.
1610         (start_buildsym_compunit): Remove.
1611         (free_buildsym_compunit): Use "delete".
1612         (start_symtab, restart_symtab): Use "new".
1613
1614 2018-07-13  Simon Marchi  <simon.marchi@polymtl.ca>
1615
1616         * symfile.c (set_objfile_default_section_offset): Remove struct
1617         keyword.
1618
1619 2018-07-14  Stafford Horne  <shorne@gmail.com>
1620
1621         * (Responsible Maintainers): Add myself as or1k maintainer.
1622
1623 2018-07-13  Tom Tromey  <tom@tromey.com>
1624
1625         * symfile.c (set_objfile_default_section_offset): Use extra braces
1626         around initializer.
1627
1628 2018-07-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1629
1630         * s390-tdep.c (s390_displaced_step_fixup): Adjust PC for a
1631         non-branching basr.
1632
1633 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1634
1635         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1636         unittests/cli-utils-selftests.c
1637         * unittests/cli-utils-selftests.c: New file.
1638
1639 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1640
1641         * NEWS: Mention new commands. Mention change to 'thread apply'.
1642
1643 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1644
1645         * thread.c (thr_try_catch_cmd): New function.
1646         (thread_apply_all_command): Handle qcs flags.
1647         (thread_apply_command): Handle qcs flags.
1648         (taas_command): New function.
1649         (tfaas_command): New function.
1650         (_initialize_thread): Update to setup the new commands 'taas
1651         and 'tfaas'. Change doc string for 'thread apply'.
1652
1653 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1654
1655         * stack.c: (trailing_outermost_frame): New function, mostly
1656         extracted from backtrace_command_1.
1657         (leading_innermost_frame): New function.
1658         (backtrace_command_1): Update to call trailing_outermost_frame.
1659         (frame_apply_command_count): New function.
1660         (frame_apply_level_command): New function.
1661         (frame_apply_all_command): New function.
1662         (frame_apply_command): New function.
1663         (faas_command): New function.
1664         (frame_cmd_list): New variable.
1665         (_initialize_stack): Update to setup the new commands 'frame apply'
1666         and 'faas'.
1667
1668 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1669
1670         * cli-utils.c (number_or_range_parser::get_number): Only handle
1671         numbers or convenience var as numbers.
1672         (parse_flags): New function.
1673         (parse_flags_qcs): New function.
1674         (number_or_range_parser::finished): Ensure parsing end is detected
1675         before end of string.
1676         * cli-utils.h (parse_flags): New function.
1677         (parse_flags_qcs): New function.
1678         (number_or_range_parser): Remove m_finished bool.
1679         (number_or_range_parser::skip_range): Set m_in_range to false.
1680
1681 2018-07-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1682
1683         * ser-tcp.c (try_connect): Declare 'ioarg' as 'u_long' if building
1684         on Windows.
1685
1686 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
1687             Jan Kratochvil  <jan.kratochvil@redhat.com>
1688             Paul Fertser  <fercerpav@gmail.com>
1689             Tsutomu Seki  <sekiriki@gmail.com>
1690             Pedro Alves  <palves@redhat.com>
1691
1692         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1693         'unittests/parse-connection-spec-selftests.c'.
1694         (COMMON_SFILES): Add 'common/netstuff.c'.
1695         (HFILES_NO_SRCDIR): Add 'common/netstuff.h'.
1696         * NEWS (Changes since GDB 8.2): Mention IPv6 support.
1697         * common/netstuff.c: New file.
1698         * common/netstuff.h: New file.
1699         * ser-tcp.c: Include 'netstuff.h' and 'wspiapi.h'.
1700         (wait_for_connect): Update comment.  New parameter
1701         'gdb::optional<int> sock' instead of 'struct serial *scb'.
1702         Use 'sock' directly instead of 'scb->fd'.
1703         (try_connect): New function, with code from 'net_open'.
1704         (net_open): Rewrite main loop to deal with multiple
1705         sockets/addresses.  Handle IPv6-style hostnames; implement
1706         support for IPv6 connections.
1707         * unittests/parse-connection-spec-selftests.c: New file.
1708
1709 2018-07-11  Pedro Alves  <palves@redhat.com>
1710
1711         PR gdb/23377
1712         * remote.c (remote_target::remote_detach_pid): Call
1713         set_current_process.
1714
1715 2018-07-11  Pedro Alves  <palves@redhat.com>
1716
1717         * h8300-tdep.c (h8300_gdbarch_init): Remove
1718         set_gdbarch_ecoff_reg_to_regnum calls.
1719
1720 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
1721
1722         PR c++/23373
1723         * c-typeprint.c (c_type_print_base_struct_union): Don't print
1724         offsets/sizes for static members of a class/struct.
1725
1726 2018-07-11  Alan Hayward  <alan.hayward@arm.com>
1727
1728         * target-descriptions.c (tdesc_register_bitsize): Rename.
1729         * target-descriptions.h (tdesc_register_bitsize): Likewise.
1730         * rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
1731         * aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
1732
1733 2018-07-10  Tom Tromey  <tom@tromey.com>
1734
1735         * breakpoint.c (moribund_locations): Now static and a
1736         std::vector.
1737         (breakpoint_init_inferior, moribund_breakpoint_here_p)
1738         (build_bpstat_chain, update_global_location_list)
1739         (breakpoint_retire_moribund): Update.
1740         * breakpoint.h (bp_location_p): Remove typedef.  Don't declare
1741         VEC.
1742
1743 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * riscv-tdep.c (riscv_is_fp_regno_p): New function.
1746         (riscv_register_reggroup_p): Use new function, remove unneeded
1747         parenthesis.
1748         (riscv_push_dummy_call): Extend assert to compare against xlen or
1749         flen based on register type.
1750
1751 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1752
1753         * riscv-tdep.c (riscv_print_arg_location): Use TYPE_SAFE_NAME.
1754
1755 2018-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * remote.c (show_hardware_watchpoint_limit): New function.
1758         (show_hardware_watchpoint_length_limit): New function.
1759         (show_hardware_breakpoint_limit): New function.
1760         (_initialize_remote): Use add_setshow_zuinteger_unlimited_cmd
1761         where appropriate, update help text.
1762
1763 2018-07-09  Tom Tromey  <tom@tromey.com>
1764
1765         * Makefile.in (CDEPS): Don't mention XM_CDEPS.
1766         (CLIBS): Don't mention NAT_CLIBS.
1767
1768 2018-07-09  Tom Tromey  <tom@tromey.com>
1769
1770         * Makefile.in (ADD_FILES, ADD_DEPS): Remove.
1771         (LIBGDB_OBS, clean mostlyclean): Update.
1772         (gdb$(EXEEXT), insight$(EXEEXT)): Update.
1773
1774 2018-07-09  Tom Tromey  <tom@tromey.com>
1775
1776         * Makefile.in (%.c: %.y): Use ECHO_YACC.
1777         (%.c: %.l): Use ECHO_LEX.  Just fail if flex not available.
1778         * silent-rules.mk (ECHO_YACC, ECHO_LEX): New variables.
1779
1780 2018-07-09  Tom Tromey  <tom@tromey.com>
1781
1782         * Makefile.in (ALLDEPFILES): Remove exec.c.
1783         (COMMON_OBS): Remove exec.o.
1784         (COMMON_SFILES): Add exec.c.
1785
1786 2018-07-09  Tom Tromey  <tom@tromey.com>
1787
1788         * Makefile.in (LINT, LINTFLAGS, LINTFILES, lint): Remove.
1789
1790 2018-07-09  Tom Tromey  <tom@tromey.com>
1791
1792         * Makefile.in (clean mostlyclean): Remove stamp-version.
1793         (version.c): Depend on stamp-version.
1794         (stamp-version): New rule, from version.c rule.
1795
1796 2018-07-09  Tom Tromey  <tom@tromey.com>
1797
1798         * Makefile.in (init.c): Depend on stamp-init.
1799         (stamp-init): New rule, from init.c rule.
1800         (clean mostlyclean): Remove stamp-init.
1801
1802 2018-07-09  Tom Tromey  <tom@tromey.com>
1803
1804         * Makefile.in (INIT_FILES): Remove CONFIG_SRCS,
1805         SUBDIR_GCC_COMPILE_SRCS.
1806
1807 2018-07-09  Tom Tromey  <tom@tromey.com>
1808
1809         * Makefile.in (init.c): Remove some unused sed rules.
1810
1811 2018-07-09  Tom Tromey  <tom@tromey.com>
1812
1813         * Makefile.in (TSOBS): Remove.
1814         (INIT_FILES): Update.
1815         (LIBGDB_OBS): Update.
1816         (COMMON_SFILES): Add inflow.c.
1817         (SFILES): Remove inflow.c.
1818
1819 2018-07-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
1820
1821         * contrib/gdb-add-index.sh ($dwarf5): New, use it.
1822
1823 2018-07-07  Simon Marchi  <simon.marchi@polymtl.ca>
1824
1825         * ia64-libunwind-tdep.c (get_reg_name, get_fpreg_name,
1826         get_saveloc_name, is_signal_frame_name, step_name,
1827         init_remote_name, create_addr_space_name,
1828         destroy_addr_space_name, search_unwind_table_name,
1829         find_dyn_list_name): Constify.
1830
1831 2018-07-05  Simon Marchi  <simon.marchi@polymtl.ca>
1832
1833         * darwin-nat.c (darwin_pthread_kill): New function.
1834         (darwin_resume_thread): Use darwin_pthread_kill.
1835
1836 2018-07-05  Tom de Vries  <tdevries@suse.de>
1837
1838         * macroexp.c (macro_buffer) <operator=>: New member function.
1839
1840 2018-07-04  Tom Tromey  <tom@tromey.com>
1841
1842         * darwin-nat.c (darwin_attach_pid): Use exit_inferior.
1843
1844 2018-07-04  Simon Marchi  <simon.marchi@polymtl.ca>
1845
1846         * common/common-defs.h (HAVE_USEFUL_SBRK): Define.
1847         * main.c: Use HAVE_USEFUL_SBRK instead of HAVE_SBRK.
1848         * maint.c: Likewise.
1849         * top.c: Likewise.
1850
1851 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
1852
1853         * NEWS: Create a new section for the next release branch.
1854         Rename the section of the current branch, now that it has
1855         been cut.
1856
1857 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
1858
1859         GDB 8.2 branch created (1b919490e8ba30bf1d6941df0ed112b0e557017e):
1860         * version.in: Bump version to 8.2.50.DATE-git.
1861
1862 2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
1863             Pedro Alves  <palves@redhat.com>
1864
1865         * linux-nat.c (linux_init_ptrace): Rename to ...
1866         (linux_init_ptrace_procfs): ... this.  Call
1867         linux_proc_init_warnings.
1868         (linux_nat_target::post_attach)
1869         (linux_nat_target::post_startup_inferior): Adjust.
1870         * nat/linux-procfs.c (linux_proc_init_warnings): Define function.
1871         * nat/linux-procfs.h (linux_proc_init_warnings): Declare function.
1872
1873 2018-07-04  Tom de Vries  <tdevries@suse.de>
1874
1875         * dwarf2read.c (error_check_comp_unit_head): Move dwarf version
1876         check ...
1877         (read_comp_unit_head): ... here.
1878
1879 2018-07-03  Tom Tromey  <tom@tromey.com>
1880
1881         * tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
1882         (stop_tracing, tstatus_command)
1883         (find_matching_tracepoint_location, merge_uploaded_tracepoints)
1884         (print_one_static_tracepoint_marker): Update.
1885         * breakpoint.c (static_tracepoints_here, all_tracepoints): Return
1886         std::vector.
1887         * breakpoint.h (breakpoint_p): Remove typedef.  Don't declare
1888         VEC.
1889         (all_tracepoints, static_tracepoints_here): Return std::vector.
1890
1891 2018-07-03  Tom Tromey  <tom@tromey.com>
1892
1893         * common/ptid.c (ptid_equal): Remove.
1894         * common/ptid.h (ptid_equal): Don't declare.
1895         * ada-tasks.c: Update.
1896         * breakpoint.c: Update.
1897         * common/agent.c: Update.
1898         * corelow.c: Update.
1899         * darwin-nat-info.c: Update.
1900         * darwin-nat.c: Update.
1901         * dcache.c: Update.
1902         * dtrace-probe.c: Update.
1903         * dummy-frame.c: Update.
1904         * fbsd-nat.c: Update.
1905         * frame.c: Update.
1906         * gdbthread.h: Update.
1907         * gnu-nat.c: Update.
1908         * go32-nat.c: Update.
1909         * inf-loop.c: Update.
1910         * inf-ptrace.c: Update.
1911         * infcall.c: Update.
1912         * infcmd.c: Update.
1913         * inflow.c: Update.
1914         * infrun.c: Update.
1915         * linux-fork.c: Update.
1916         * linux-nat.c: Update.
1917         * linux-thread-db.c: Update.
1918         * mi/mi-cmd-var.c: Update.
1919         * mi/mi-interp.c: Update.
1920         * mi/mi-main.c: Update.
1921         * nto-procfs.c: Update.
1922         * ppc-linux-tdep.c: Update.
1923         * procfs.c: Update.
1924         * python/py-inferior.c: Update.
1925         * python/py-record-btrace.c: Update.
1926         * python/py-record.c: Update.
1927         * ravenscar-thread.c: Update.
1928         * regcache.c: Update.
1929         * remote-sim.c: Update.
1930         * remote.c: Update.
1931         * sol-thread.c: Update.
1932         * solib.c: Update.
1933         * target.c: Update.
1934         * tui/tui-stack.c: Update.
1935         * varobj.c: Update.
1936         * windows-nat.c: Update.
1937         * windows-tdep.c: Update.
1938
1939 2018-07-03  Tom Tromey  <tom@tromey.com>
1940
1941         * common/ptid.c (ptid_match): Remove.
1942         * common/ptid.h (ptid_match): Don't declare.
1943         * fbsd-nat.c: Update.
1944         * infcmd.c: Update.
1945         * infrun.c: Update.
1946         * linux-nat.c: Update.
1947         * record-btrace.c: Update.
1948         * regcache.c: Update.
1949         * remote.c: Update.
1950
1951 2018-07-03  Tom Tromey  <tom@tromey.com>
1952
1953         * common/ptid.c (ptid_tid_p): Remove.
1954         * common/ptid.h (ptid_tid_p): Don't declare.
1955         * sol-thread.c: Update.
1956
1957 2018-07-03  Tom Tromey  <tom@tromey.com>
1958
1959         * common/ptid.c (ptid_lwp_p): Remove.
1960         * common/ptid.h (ptid_lwp_p): Don't declare.
1961         * fbsd-nat.c: Update.
1962         * linux-nat.c: Update.
1963         * nat/linux-procfs.c: Update.
1964         * nat/x86-linux-dregs.c: Update.
1965         * sol-thread.c: Update.
1966
1967 2018-07-03  Tom Tromey  <tom@tromey.com>
1968
1969         * common/ptid.c (ptid_is_pid): Remove.
1970         * common/ptid.h (ptid_is_pid): Don't declare.
1971         * infrun.c: Update.
1972         * linux-nat.c: Update.
1973         * mi/mi-interp.c: Update.
1974         * remote.c: Update.
1975         * thread.c: Update.
1976
1977 2018-07-03  Tom Tromey  <tom@tromey.com>
1978
1979         * common/ptid.c (ptid_get_tid): Remove.
1980         * common/ptid.h (ptid_get_tid): Don't declare.
1981         * ada-tasks.c: Update.
1982         * aix-thread.c: Update.
1983         * bsd-uthread.c: Update.
1984         * darwin-nat.c: Update.
1985         * fbsd-nat.c: Update.
1986         * i386-darwin-nat.c: Update.
1987         * infrun.c: Update.
1988         * linux-tdep.c: Update.
1989         * nto-procfs.c: Update.
1990         * ppc-ravenscar-thread.c: Update.
1991         * python/py-infthread.c: Update.
1992         * ravenscar-thread.c: Update.
1993         * sol-thread.c: Update.
1994         * sparc-ravenscar-thread.c: Update.
1995         * windows-nat.c: Update.
1996
1997 2018-07-03  Tom Tromey  <tom@tromey.com>
1998
1999         * common/ptid.c (ptid_get_lwp): Remove.
2000         * common/ptid.h (ptid_get_lwp): Don't declare.
2001         * aarch64-linux-nat.c: Update.
2002         * ada-tasks.c: Update.
2003         * aix-thread.c: Update.
2004         * amd64-linux-nat.c: Update.
2005         * arm-linux-nat.c: Update.
2006         * corelow.c: Update.
2007         * fbsd-nat.c: Update.
2008         * fbsd-tdep.c: Update.
2009         * gnu-nat.c: Update.
2010         * i386-cygwin-tdep.c: Update.
2011         * i386-gnu-nat.c: Update.
2012         * i386-linux-nat.c: Update.
2013         * ia64-linux-nat.c: Update.
2014         * inf-ptrace.c: Update.
2015         * infrun.c: Update.
2016         * linux-fork.c: Update.
2017         * linux-nat.c: Update.
2018         * linux-tdep.c: Update.
2019         * linux-thread-db.c: Update.
2020         * mips-linux-nat.c: Update.
2021         * nat/aarch64-linux-hw-point.c: Update.
2022         * nat/aarch64-linux.c: Update.
2023         * nat/linux-btrace.c: Update.
2024         * nat/linux-osdata.c: Update.
2025         * nat/linux-procfs.c: Update.
2026         * nat/x86-linux-dregs.c: Update.
2027         * obsd-nat.c: Update.
2028         * ppc-fbsd-nat.c: Update.
2029         * ppc-linux-nat.c: Update.
2030         * procfs.c: Update.
2031         * python/py-infthread.c: Update.
2032         * ravenscar-thread.c: Update.
2033         * remote.c: Update.
2034         * s390-linux-nat.c: Update.
2035         * sol-thread.c: Update.
2036         * sol2-tdep.c: Update.
2037         * spu-linux-nat.c: Update.
2038         * x86-linux-nat.c: Update.
2039         * xtensa-linux-nat.c: Update.
2040
2041 2018-07-03  Tom Tromey  <tom@tromey.com>
2042
2043         * common/ptid.c (ptid_get_pid): Remove.
2044         * common/ptid.h (ptid_get_pid): Don't declare.
2045         * aarch64-linux-nat.c: Update.
2046         * ada-lang.c: Update.
2047         * aix-thread.c: Update.
2048         * alpha-bsd-nat.c: Update.
2049         * amd64-fbsd-nat.c: Update.
2050         * amd64-linux-nat.c: Update.
2051         * arm-linux-nat.c: Update.
2052         * arm-nbsd-nat.c: Update.
2053         * auxv.c: Update.
2054         * break-catch-syscall.c: Update.
2055         * breakpoint.c: Update.
2056         * bsd-uthread.c: Update.
2057         * corelow.c: Update.
2058         * ctf.c: Update.
2059         * darwin-nat.c: Update.
2060         * fbsd-nat.c: Update.
2061         * fbsd-tdep.c: Update.
2062         * gcore.c: Update.
2063         * gnu-nat.c: Update.
2064         * hppa-nbsd-nat.c: Update.
2065         * hppa-obsd-nat.c: Update.
2066         * i386-fbsd-nat.c: Update.
2067         * ia64-linux-nat.c: Update.
2068         * inf-ptrace.c: Update.
2069         * infcmd.c: Update.
2070         * inferior.c: Update.
2071         * inferior.h: Update.
2072         * inflow.c: Update.
2073         * infrun.c: Update.
2074         * linux-fork.c: Update.
2075         * linux-nat.c: Update.
2076         * linux-tdep.c: Update.
2077         * linux-thread-db.c: Update.
2078         * m68k-bsd-nat.c: Update.
2079         * mi/mi-interp.c: Update.
2080         * mi/mi-main.c: Update.
2081         * mips-linux-nat.c: Update.
2082         * mips-nbsd-nat.c: Update.
2083         * mips64-obsd-nat.c: Update.
2084         * nat/aarch64-linux-hw-point.c: Update.
2085         * nat/aarch64-linux.c: Update.
2086         * nat/linux-btrace.c: Update.
2087         * nat/linux-osdata.c: Update.
2088         * nat/linux-procfs.c: Update.
2089         * nat/x86-linux-dregs.c: Update.
2090         * nto-procfs.c: Update.
2091         * obsd-nat.c: Update.
2092         * ppc-linux-nat.c: Update.
2093         * ppc-nbsd-nat.c: Update.
2094         * ppc-obsd-nat.c: Update.
2095         * proc-service.c: Update.
2096         * procfs.c: Update.
2097         * python/py-inferior.c: Update.
2098         * python/py-infthread.c: Update.
2099         * ravenscar-thread.c: Update.
2100         * record.c: Update.
2101         * remote-sim.c: Update.
2102         * remote.c: Update.
2103         * rs6000-nat.c: Update.
2104         * s390-linux-nat.c: Update.
2105         * sh-nbsd-nat.c: Update.
2106         * sol-thread.c: Update.
2107         * sparc-nat.c: Update.
2108         * sparc64-tdep.c: Update.
2109         * spu-linux-nat.c: Update.
2110         * spu-tdep.c: Update.
2111         * target-debug.h: Update.
2112         * target.c: Update.
2113         * thread.c: Update.
2114         * tid-parse.c: Update.
2115         * tracefile-tfile.c: Update.
2116         * vax-bsd-nat.c: Update.
2117         * windows-nat.c: Update.
2118         * x86-linux-nat.c: Update.
2119         * x86-nat.c: Update.
2120
2121 2018-07-03  Tom Tromey  <tom@tromey.com>
2122
2123         * common/ptid.c (pid_to_ptid): Remove.
2124         * common/ptid.h (pid_to_ptid): Don't declare.
2125         * aix-thread.c: Update.
2126         * arm-linux-nat.c: Update.
2127         * common/ptid.c: Update.
2128         * common/ptid.h: Update.
2129         * corelow.c: Update.
2130         * ctf.c: Update.
2131         * darwin-nat.c: Update.
2132         * fbsd-nat.c: Update.
2133         * fork-child.c: Update.
2134         * gnu-nat.c: Update.
2135         * go32-nat.c: Update.
2136         * inf-ptrace.c: Update.
2137         * infcmd.c: Update.
2138         * inferior.c: Update.
2139         * infrun.c: Update.
2140         * linux-fork.c: Update.
2141         * linux-nat.c: Update.
2142         * nat/aarch64-linux-hw-point.c: Update.
2143         * nat/fork-inferior.c: Update.
2144         * nat/x86-linux-dregs.c: Update.
2145         * nto-procfs.c: Update.
2146         * obsd-nat.c: Update.
2147         * procfs.c: Update.
2148         * progspace.c: Update.
2149         * remote.c: Update.
2150         * rs6000-nat.c: Update.
2151         * s390-linux-nat.c: Update.
2152         * sol-thread.c: Update.
2153         * spu-linux-nat.c: Update.
2154         * target.c: Update.
2155         * top.c: Update.
2156         * tracefile-tfile.c: Update.
2157         * windows-nat.c: Update.
2158
2159 2018-07-03  Tom Tromey  <tom@tromey.com>
2160
2161         * common/ptid.h (ptid_build): Don't declare.
2162         * common/ptid.c (ptid_build): Remove.
2163         * aix-thread.c: Update.
2164         * bsd-kvm.c: Update.
2165         * bsd-uthread.c: Update.
2166         * common/agent.c: Update.
2167         * common/ptid.c: Update.
2168         * common/ptid.h: Update.
2169         * corelow.c: Update.
2170         * darwin-nat.c: Update.
2171         * fbsd-nat.c: Update.
2172         * gnu-nat.c: Update.
2173         * linux-fork.c: Update.
2174         * linux-nat.c: Update.
2175         * linux-thread-db.c: Update.
2176         * nat/linux-osdata.c: Update.
2177         * nat/linux-procfs.c: Update.
2178         * nto-procfs.c: Update.
2179         * obsd-nat.c: Update.
2180         * proc-service.c: Update.
2181         * procfs.c: Update.
2182         * ravenscar-thread.c: Update.
2183         * remote-sim.c: Update.
2184         * remote.c: Update.
2185         * sol-thread.c: Update.
2186         * target.c: Update.
2187         * windows-nat.c: Update.
2188
2189 2018-07-03  Tom Tromey  <tom@tromey.com>
2190
2191         * infrun.c (follow_exec): Use exit_inferior_silent.
2192         * inferior.c (exit_inferior_num_silent): Remove.
2193         * inferior.h (exit_inferior_num_silent): Don't declare.
2194
2195 2018-07-03  Tom Tromey  <tom@tromey.com>
2196
2197         PR cli/23340:
2198         * darwin-nat.c (darwin_attach_pid): Reset inferior and
2199         inferior_ptid on error.
2200
2201 2018-07-02  Maciej W. Rozycki  <macro@mips.com>
2202             Simon Marchi  <simon.marchi@polymtl.ca>
2203
2204         PR tdep/8282
2205         * disasm.h (gdb_disassembler): Add
2206         `m_disassembler_options_holder'. member
2207         * disasm.c (get_all_disassembler_options): New function.
2208         (gdb_disassembler::gdb_disassembler): Use it.
2209         (gdb_buffered_insn_length_init_dis): Likewise.
2210         (gdb_buffered_insn_length): Adjust accordingly.
2211         (set_disassembler_options): Handle options with arguments.
2212         (show_disassembler_options_sfunc): Likewise.  Add a leading new
2213         line if showing options with descriptions.
2214         (disassembler_options_completer): Adapt to using the
2215         `disasm_options_and_args_t' structure.
2216         * mips-tdep.c (mips_disassembler_options): New variable.
2217         (mips_disassembler_options_o32): Likewise.
2218         (mips_disassembler_options_n32): Likewise.
2219         (mips_disassembler_options_n64): Likewise.
2220         (gdb_print_insn_mips): Don't set `disassembler_options'.
2221         (gdb_print_insn_mips_n32, gdb_print_insn_mips_n64): Remove
2222         functions.
2223         (mips_gdbarch_init): Always set `gdbarch_print_insn' to
2224         `gdb_print_insn_mips'.  Set `gdbarch_disassembler_options',
2225         `gdbarch_disassembler_options_implicit' and
2226         `gdbarch_valid_disassembler_options'.
2227         * arm-tdep.c (_initialize_arm_tdep): Adapt to using the
2228         `disasm_options_and_args_t' structure.
2229         * gdbarch.sh (disassembler_options_implicit): New `gdbarch'
2230         method.
2231         (valid_disassembler_options): Switch from `disasm_options_t' to
2232         the `disasm_options_and_args_t' structure.
2233         * NEWS: Document `set disassembler-options' support for the MIPS
2234         target.
2235         * gdbarch.h: Regenerate.
2236         * gdbarch.c: Regenerate.
2237
2238 2018-07-02  Sebastian Huber  <sebastian.huber@embedded-brains.de>
2239
2240         * riscv-tdep.c (riscv_register_aliases): Swap "fp" and "s0" entries.
2241
2242 2018-06-29  Joel Brobecker  <brobecker@adacore.com>
2243
2244         * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
2245         parameter in call to amd64_target_description.
2246         * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
2247         * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
2248         (amd64fbsd_init_abi): Likewise.
2249         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
2250         * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
2251         * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
2252         * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
2253
2254 2018-06-29  Pedro Alves  <palves@redhat.com>
2255
2256         * gdb/amd64-tdep.h (amd64_create_target_description): Add
2257         "segments" parameter.
2258         * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
2259         (_initialize_amd64_tdep): Update call to
2260         amd64_create_target_description.
2261         (amd64_target_description): Add "segments" parameter.  Adjust
2262         the implementation to use it.
2263         * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
2264         call to amd64_create_target_description.
2265         * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
2266         * gdb/arch/amd64.h (amd64_create_target_description): Add
2267         "segments" register.
2268         * gdb/arch/amd64.c (amd64_create_target_description): Add
2269         "segments" parameter.  Call create_feature_i386_64bit_segments
2270         only if SEGMENTS is true.
2271         * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
2272         call to amd64_create_target_description.
2273
2274 2018-06-29  Pedro Alves  <palves@redhat.com>
2275
2276         * thread.c (thread_target_id_str): New, factored out from ...
2277         (print_thread_info_1): ... here.  Use it to compute the max
2278         "Target Id" column width.
2279
2280 2018-06-29  Pedro Alves  <palves@redhat.com>
2281
2282         * remote.c (remote_target::extra_thread_info): Delete
2283         'display_buf' and 'n' locals.  from the cache, regardless of
2284         packet mechanims is in use.  Use cache for qThreadExtra and qP
2285         methods too.
2286
2287 2018-06-29  Pedro Alves  <palves@redhat.com>
2288
2289         * blockframe.c (find_pc_sect_containing_function): New function.
2290         * breakpoint.c (print_breakpoint_location): Don't call
2291         find_pc_sect_function.
2292         * linespec.c (create_sals_line_offset): Record the location's
2293         symbol in the sal.
2294         * linespec.c (convert_address_location_to_sals): Fill in sal's
2295         symbol with find_pc_sect_containing_function.
2296         * symtab.c (find_function_start_sal): Rename to ...
2297         (find_function_start_sal_1): ... this.
2298         (find_function_start_sal): Reimplement as wrapper around
2299         find_function_start_sal_1, and use
2300         find_pc_sect_containing_function to fill in the sal's symbol.
2301         (find_function_start_sal(symbol*, bool)): Adjust.
2302         * symtab.h (find_pc_function, find_pc_sect_function): Adjust
2303         comments.
2304         (find_pc_sect_containing_function): Declare.
2305
2306 2018-06-29  Pedro Alves  <palves@redhat.com>
2307
2308         * inline-frame.c (stopped_by_user_bp_inline_frame): Return
2309         true if the the location has no symbol.
2310
2311 2018-06-28  Tom Tromey  <tom@tromey.com>
2312
2313         * NEWS: Mention --enable-codesign.
2314         * silent-rules.mk (ECHO_SIGN): New variable.
2315         * configure.ac: Add --enable-codesign.
2316         * configure: Rebuild.
2317         * Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
2318         (gdb$(EXEEXT)): Optionally invoke codesign.
2319
2320 2018-06-28  Pedro Alves  <palves@redhat.com>
2321
2322         * gdbthread.h (struct thread_suspend_state) <stop_pc>: Extend
2323         comments.
2324         (switch_to_thread_no_regs): Adjust comment.
2325         * infcmd.c (stop_pc): Delete.
2326         (post_create_inferior, info_program_command): Replace references
2327         to stop_pc with references to thread_info->suspend.stop_pc.
2328         * inferior.h (stop_pc): Delete declaration.
2329         * infrun.c (proceed, handle_syscall_event, fill_in_stop_func)
2330         (handle_inferior_event_1, handle_signal_stop)
2331         (process_event_stop_test, keep_going_stepped_thread)
2332         (handle_step_into_function, handle_step_into_function_backward)
2333         (print_stop_location): Replace references to stop_pc with
2334         references to thread_info->suspend.stop_pc.
2335         (struct infcall_suspend_state) <stop_pc>: Delete field.
2336         (save_infcall_suspend_state, restore_infcall_suspend_state):
2337         Remove references to inf_stat->stop_pc.
2338         * linux-fork.c (fork_load_infrun_state): Likewise.
2339         * record-btrace.c (record_btrace_set_replay): Likewise.
2340         * record-full.c (record_full_goto_entry): Likewise.
2341         * remote.c (print_one_stopped_thread): Likewise.
2342         * target.c (target_resume): Extend comment.
2343         * thread.c (set_executing_thread): New.
2344         (set_executing): Use it.
2345         (switch_to_thread_no_regs, switch_to_no_thread, switch_to_thread):
2346         Remove references to stop_pc.
2347
2348 2018-06-28  Pedro Alves  <palves@redhat.com>
2349
2350         * infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>:
2351         Moving fetching stop_pc until after ecs->event_thread is refreshed.
2352
2353 2018-06-28  Tom Tromey  <tom@tromey.com>
2354
2355         * coffread.c (coff_symfile_finish): Update.
2356         * xcoffread.c (xcoff_symfile_finish): Update.
2357         * elfread.c (elf_symfile_finish): Update.
2358         * symfile.h (dwarf2_free_objfile): Don't declare.
2359         * dwarf2read.c (_initialize_dwarf2_read): Use
2360         register_objfile_data_with_cleanup.
2361         (dwarf2_free_objfile): Now static.  Change signature.
2362
2363 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2364
2365         * symfile.c (add_symbol_file_command, _initialize_symfile): Add
2366         option "-o" to add-symbol-file-load to add an offset to each
2367         section's load address.
2368         * symfile.c (set_objfile_default_section_offset): New function.
2369
2370 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2371
2372         * symfile.c (add_symbol_file_command): Make sure that sections
2373         with the same name are sorted in the same order.
2374
2375 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2376
2377         * symfile.c (add_symbol_file_command, _initialize_symfile): Do not
2378         require the second argument.  If omitted, load sections at the
2379         addresses specified in the file.
2380
2381 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2382
2383         * symfile.c (symbol_file_command, symbol_file_add_main_1)
2384         (_initialize_symfile): Add option "-o" to symbol-file to add an
2385         offset to each section of the symbol file.
2386
2387 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2388
2389         * MAINTAINERS (Write After Approval): Add Petr Tesarik.
2390
2391 2018-06-27  Tom Tromey  <tom@tromey.com>
2392
2393         * stack.c (_initialize_stack): Update "func" help text.
2394
2395 2018-06-27  Tom Tromey  <tom@tromey.com>
2396
2397         * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
2398         std::vector.
2399         (unwind_infopy_str, pyuw_create_unwind_info)
2400         (unwind_infopy_add_saved_register, pyuw_sniffer)
2401         (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
2402         Update.
2403         (struct saved_reg): Add constructor.
2404         <value>: Now a gdbpy_ref<>.
2405
2406 2018-06-27  Tom Tromey  <tom@tromey.com>
2407
2408         * machoread.c (macho_symfile_read): Define "symbol_table" earlier.
2409
2410 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2411
2412         * gdb-gdb.py.in: Format using autopep8.
2413
2414 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2415
2416         * gdb-gdb.py.in (CoreAddrPrettyPrinter): New class.
2417         (type_lookup_function): Recognize CORE_ADDR values.
2418
2419 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2420
2421         * gdb-gdb.py.in (StructMainTypePrettyPrinter) <to_string>: Don't
2422         print tag_name.
2423
2424 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2425
2426         * gdb-gdb.py.in (TypeFlag) <__cmp__>: Remove.
2427         <__lt__>: Add.
2428
2429 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2430
2431         * gdb-gdb.py: Move to...
2432         * gdb-gdb.py.in: ... here.
2433         * configure.ac (AC_CONFIG_FILES): Add gdb-gdb.py.
2434         * Makefile.in (all): Add gdb-gdb.gdb and gdb-gdb.py as
2435         dependencies.
2436         (distclean): Remove gdb-gdb.py when cleaning.
2437         (gdb-gdb.py, gdb-gdb.gdb): New rules.
2438         * configure: Re-generate.
2439
2440 2018-06-27  Pedro Alves  <palves@redhat.com>
2441
2442         * proc-service.c (get_ps_regcache): New.
2443         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs)
2444         (ps_lsetfpregs): Use it.
2445
2446 2018-06-27  Omair Javaid  <omair.javaid@linaro.org>
2447
2448         PR gdb/21695
2449         * dwarf2read.c (lnp_state_machine::check_line_address): Update declaration.
2450         (dwarf_decode_lines_1): Adjust.
2451
2452 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2453
2454         * fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
2455         override.
2456         <info_proc>: Likewise.
2457
2458 2018-06-26  Joel Brobecker  <brobecker@adacore.com>
2459
2460         * windows-nat.c (do_windows_fetch_inferior_registers): Rename
2461         to windows_fetch_one_register, and only handle the case of
2462         fetching one register.  Move the code that reloads the context
2463         and iterates over all registers if R is negative to...
2464         (windows_nat_target::fetch_registers): ... here.
2465         (do_windows_store_inferior_registers): Rename to
2466         windows_store_one_register, and only handle the case of storing
2467         one register.  Move the code that handles the case where r is
2468         negative to...
2469         (windows_nat_target::store_registers) ... here.
2470
2471 2018-06-26  Tom Tromey  <tom@tromey.com>
2472
2473         PR rust/22574:
2474         * typeprint.c (whatis_exp): Allow ptype/o for Rust.
2475         * rust-lang.c (rust_print_struct_def): Add podata parameter.
2476         Update.
2477         (rust_internal_print_type): Add podata parameter.
2478         (rust_print_type): Update.
2479
2480 2018-06-26  Tom Tromey  <tom@tromey.com>
2481
2482         * typeprint.h (struct print_offset_data) <update, finish,
2483         maybe_print_hole>: New methods.
2484         <indentation>: New constant.
2485         * typeprint.c (print_offset_data::indentation): Define.
2486         (print_offset_data::maybe_print_hole, print_offset_data::update)
2487         (print_offset_data::finish): Move from c-typeprint.c and rename.
2488         * c-typeprint.c (OFFSET_SPC_LEN): Remove.
2489         (print_spaces_filtered_with_print_options): Update.
2490         (c_print_type_union_field_offset, maybe_print_hole)
2491         (c_print_type_struct_field_offset): Move to typeprint.c and
2492         rename.
2493         (c_type_print_base_struct_union): Update.
2494
2495 2018-06-25  Pedro Alves  <palves@redhat.com>
2496
2497         * gdbthread.h (thread_info_ref, delete_thread)
2498         (delete_thread_silent, first_thread_of_inferior)
2499         (any_thread_of_inferior, switch_to_thread)
2500         (enable_thread_stack_temporaries)
2501         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2502         (get_last_thread_stack_temporary)
2503         (value_in_thread_stack_temporaries, can_access_registers_thread):
2504         Spell out "struct thread_info" instead of just "thread_info".
2505         * inferior.h (notice_new_inferior): Likewise.
2506
2507 2018-06-25  Pedro Alves  <palves@redhat.com>
2508
2509         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
2510         pass thread_info pointer to delete_thread.
2511         (windows_nat_target::detach): Pass inferior pointer to
2512         detach_inferior.
2513         * aix-thread.c (sync_threadlists): Pass thread_info pointer to
2514         delete_thread.
2515         * bsd-kvm.c (bsd_kvm_target::close): Use discard_all_inferiors.
2516         * darwin-nat.c (darwin_check_new_threads): Use find_thread_ptid
2517         and pass a thread_info pointer to delete_thread.
2518         * fbsd-nat.c (fbsd_nat_target::wait): Use find_thread_ptid and
2519         pass thread_info pointer to delete_thread.
2520         * go32-nat.c (go32_nat_target::mourn_inferior): Remove
2521         delete_thread_silent call.
2522         * procfs.c (procfs_target::detach): Pass inferior pointer to
2523         detach_inferior.
2524         (procfs_target::wait): Pass thread_info pointer to delete_thread.
2525         * remote-sim.c (gdbsim_target::mourn_inferior): Remove
2526         delete_thread_silent call.
2527         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
2528         pass thread_info pointer to delete_thread.
2529         (windows_nat_target::detach): Pass inferior pointer to
2530         delete_inferior.
2531
2532 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
2533
2534         * regcache.c (readable_regcache::read_part): Fix asserts.
2535         (reg_buffer::raw_collect_part): New function.
2536         (regcache::write_part): Fix asserts.
2537         (reg_buffer::raw_supply_part): New function.
2538         (regcache::transfer_regset_register): New helper function.
2539         (regcache::transfer_regset): Call new functions.
2540         (regcache_supply_regset): Use gdb_byte*.
2541         (regcache::supply_regset): Likewise.
2542         (regcache_collect_regset): Likewise.
2543         (regcache::collect_regset): Likewise.
2544         * regcache.h (reg_buffer::raw_collect_part): New declaration.
2545         (reg_buffer::raw_supply_part): Likewise.
2546         (regcache::transfer_regset_register): Likewise.
2547         (regcache::transfer_regset): Use gdb_byte*.
2548
2549 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
2550
2551         * nat/aarch64-sve-linux-ptrace.h (HAS_SVE_STATE): Use &.
2552
2553 2018-06-21  Pedro Alves  <palves@redhat.com>
2554
2555         * ada-lang.h (ada_get_task_number): Take a thread_info pointer
2556         instead of a ptid_t.  All callers adjusted.
2557         * ada-tasks.c (ada_get_task_number): Likewise.  All callers
2558         adjusted.
2559         (print_ada_task_info, display_current_task_id, task_command_1):
2560         Adjust.
2561         * breakpoint.c (watchpoint_in_thread_scope): Adjust to use
2562         inferior_thread.
2563         (breakpoint_kind): Adjust.
2564         (remove_breakpoints_pid): Rename to ...
2565         (remove_breakpoints_inf): ... this.  Adjust to take an inferior
2566         pointer.  All callers adjusted.
2567         (bpstat_clear_actions): Use inferior_thread.
2568         (get_bpstat_thread): New.
2569         (bpstat_do_actions): Use it.
2570         (bpstat_check_breakpoint_conditions, bpstat_stop_status): Adjust
2571         to take a thread_info pointer.  All callers adjusted.
2572         (set_longjmp_breakpoint_for_call_dummy, set_momentary_breakpoint)
2573         (breakpoint_re_set_thread): Use inferior_thread.
2574         * breakpoint.h (struct inferior): Forward declare.
2575         (bpstat_stop_status): Update.
2576         (remove_breakpoints_pid): Delete.
2577         (remove_breakpoints_inf): New.
2578         * bsd-uthread.c (bsd_uthread_target::wait)
2579         (bsd_uthread_target::update_thread_list): Use find_thread_ptid.
2580         * btrace.c (btrace_add_pc, btrace_enable, btrace_fetch)
2581         (maint_btrace_packet_history_cmd)
2582         (maint_btrace_clear_packet_history_cmd): Adjust.
2583         (maint_btrace_clear_cmd, maint_info_btrace_cmd): Adjust to use
2584         inferior_thread.
2585         * cli/cli-interp.c: Include "inferior.h".
2586         * common/refcounted-object.h (struct
2587         refcounted_object_ref_policy): New.
2588         * compile/compile-object-load.c: Include gdbthread.h.
2589         (store_regs): Use inferior_thread.
2590         * corelow.c (core_target::close): Use current_inferior.
2591         (core_target_open): Adjust to use first_thread_of_inferior and use
2592         the current inferior.
2593         * ctf.c (ctf_target::close): Adjust to use current_inferior.
2594         * dummy-frame.c (dummy_frame_id) <ptid>: Delete, replaced by ...
2595         <thread>: ... this new field.  All references adjusted.
2596         (dummy_frame_pop, dummy_frame_discard, register_dummy_frame_dtor):
2597         Take a thread_info pointer instead of a ptid_t.
2598         * dummy-frame.h (dummy_frame_push, dummy_frame_pop)
2599         (dummy_frame_discard, register_dummy_frame_dtor): Take a
2600         thread_info pointer instead of a ptid_t.
2601         * elfread.c: Include "inferior.h".
2602         (elf_gnu_ifunc_resolver_stop, elf_gnu_ifunc_resolver_return_stop):
2603         Use inferior_thread.
2604         * eval.c (evaluate_subexp): Likewise.
2605         * frame.c (frame_pop, has_stack_frames, find_frame_sal): Use
2606         inferior_thread.
2607         * gdb_proc_service.h (struct thread_info): Forward declare.
2608         (struct ps_prochandle) <ptid>: Delete, replaced by ...
2609         <thread>: ... this new field.  All references adjusted.
2610         * gdbarch.h, gdbarch.c: Regenerate.
2611         * gdbarch.sh (get_syscall_number): Replace 'ptid' parameter with a
2612         'thread' parameter.  All implementations and callers adjusted.
2613         * gdbthread.h (thread_info) <set_running>: New method.
2614         (delete_thread, delete_thread_silent): Take a thread_info pointer
2615         instead of a ptid.
2616         (global_thread_id_to_ptid, ptid_to_global_thread_id): Delete.
2617         (first_thread_of_process): Delete, replaced by ...
2618         (first_thread_of_inferior): ... this new function.  All callers
2619         adjusted.
2620         (any_live_thread_of_process): Delete, replaced by ...
2621         (any_live_thread_of_inferior): ... this new function.  All callers
2622         adjusted.
2623         (switch_to_thread, switch_to_no_thread): Declare.
2624         (is_executing): Delete.
2625         (enable_thread_stack_temporaries): Update comment.
2626         <enable_thread_stack_temporaries>: Take a thread_info pointer
2627         instead of a ptid_t.  Incref the thread.
2628         <~enable_thread_stack_temporaries>: Decref the thread.
2629         <m_ptid>: Delete
2630         <m_thr>: New.
2631         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2632         (get_last_thread_stack_temporary)
2633         (value_in_thread_stack_temporaries, can_access_registers_thread):
2634         Take a thread_info pointer instead of a ptid_t.  All callers
2635         adjusted.
2636         * infcall.c (get_call_return_value): Use inferior_thread.
2637         (run_inferior_call): Work with thread pointers instead of ptid_t.
2638         (call_function_by_hand_dummy): Work with thread pointers instead
2639         of ptid_t.  Use thread_info_ref.
2640         * infcmd.c (proceed_thread_callback): Access thread's state
2641         directly.
2642         (ensure_valid_thread, ensure_not_running): Use inferior_thread,
2643         access thread's state directly.
2644         (continue_command): Use inferior_thread.
2645         (info_program_command): Use find_thread_ptid and access thread
2646         state directly.
2647         (proceed_after_attach_callback): Use thread state directly.
2648         (notice_new_inferior): Take a thread_info pointer instead of a
2649         ptid_t.  All callers adjusted.
2650         (exit_inferior): Take an inferior pointer instead of a pid.  All
2651         callers adjusted.
2652         (exit_inferior_silent): New.
2653         (detach_inferior): Delete.
2654         (valid_gdb_inferior_id, pid_to_gdb_inferior_id)
2655         (gdb_inferior_id_to_pid, in_inferior_list): Delete.
2656         (detach_inferior_command, kill_inferior_command): Use
2657         find_inferior_id instead of valid_gdb_inferior_id and
2658         gdb_inferior_id_to_pid.
2659         (inferior_command): Use inferior and thread pointers.
2660         * inferior.h (struct thread_info): Forward declare.
2661         (notice_new_inferior): Take a thread_info pointer instead of a
2662         ptid_t.  All callers adjusted.
2663         (detach_inferior): Delete declaration.
2664         (exit_inferior, exit_inferior_silent): Take an inferior pointer
2665         instead of a pid.  All callers adjusted.
2666         (gdb_inferior_id_to_pid, pid_to_gdb_inferior_id, in_inferior_list)
2667         (valid_gdb_inferior_id): Delete.
2668         * infrun.c (follow_fork_inferior, proceed_after_vfork_done)
2669         (handle_vfork_child_exec_or_exit, follow_exec): Adjust.
2670         (struct displaced_step_inferior_state) <pid>: Delete, replaced by
2671         ...
2672         <inf>: ... this new field.
2673         <step_ptid>: Delete, replaced by ...
2674         <step_thread>: ... this new field.
2675         (get_displaced_stepping_state): Take an inferior pointer instead
2676         of a pid.  All callers adjusted.
2677         (displaced_step_in_progress_any_inferior): Adjust.
2678         (displaced_step_in_progress_thread): Take a thread pointer instead
2679         of a ptid_t.  All callers adjusted.
2680         (displaced_step_in_progress, add_displaced_stepping_state): Take
2681         an inferior pointer instead of a pid.  All callers adjusted.
2682         (get_displaced_step_closure_by_addr): Adjust.
2683         (remove_displaced_stepping_state): Take an inferior pointer
2684         instead of a pid.  All callers adjusted.
2685         (displaced_step_prepare_throw, displaced_step_prepare)
2686         (displaced_step_fixup): Take a thread pointer instead of a ptid_t.
2687         All callers adjusted.
2688         (start_step_over): Adjust.
2689         (infrun_thread_ptid_changed): Remove bit updating ptids in the
2690         displaced step queue.
2691         (do_target_resume): Adjust.
2692         (fetch_inferior_event): Use inferior_thread.
2693         (context_switch, get_inferior_stop_soon): Take an
2694         execution_control_state pointer instead of a ptid_t.  All callers
2695         adjusted.
2696         (switch_to_thread_cleanup): Delete.
2697         (stop_all_threads): Use scoped_restore_current_thread.
2698         * inline-frame.c: Include "gdbthread.h".
2699         (inline_state) <inline_state>: Take a thread pointer instead of a
2700         ptid_t.  All callers adjusted.
2701         <ptid>: Delete, replaced by ...
2702         <thread>: ... this new field.
2703         (find_inline_frame_state): Take a thread pointer instead of a
2704         ptid_t.  All callers adjusted.
2705         (skip_inline_frames, step_into_inline_frame)
2706         (inline_skipped_frames, inline_skipped_symbol): Take a thread
2707         pointer instead of a ptid_t.  All callers adjusted.
2708         * inline-frame.h (skip_inline_frames, step_into_inline_frame)
2709         (inline_skipped_frames, inline_skipped_symbol): Likewise.
2710         * linux-fork.c (delete_checkpoint_command): Adjust to use thread
2711         pointers directly.
2712         * linux-nat.c (get_detach_signal): Likewise.
2713         * linux-thread-db.c (thread_from_lwp): New 'stopped' parameter.
2714         (thread_db_notice_clone): Adjust.
2715         (thread_db_find_new_threads_silently)
2716         (thread_db_find_new_threads_2, thread_db_find_new_threads_1): Take
2717         a thread pointer instead of a ptid_t.  All callers adjusted.
2718         * mi/mi-cmd-var.c: Include "inferior.h".
2719         (mi_cmd_var_update_iter): Update to use thread pointers.
2720         * mi/mi-interp.c (mi_new_thread): Update to use the thread's
2721         inferior directly.
2722         (mi_output_running_pid, mi_inferior_count): Delete, bits factored
2723         out to ...
2724         (mi_output_running): ... this new function.
2725         (mi_on_resume_1): Adjust to use it.
2726         (mi_user_selected_context_changed): Adjust to use inferior_thread.
2727         * mi/mi-main.c (proceed_thread): Adjust to use thread pointers
2728         directly.
2729         (interrupt_thread_callback): : Adjust to use thread and inferior
2730         pointers.
2731         * proc-service.c: Include "gdbthread.h".
2732         (ps_pglobal_lookup): Adjust to use the thread's inferior directly.
2733         * progspace-and-thread.c: Include "inferior.h".
2734         * progspace.c: Include "inferior.h".
2735         * python/py-exitedevent.c (create_exited_event_object): Adjust to
2736         hold a reference to an inferior_object.
2737         * python/py-finishbreakpoint.c (bpfinishpy_init): Adjust to use
2738         inferior_thread.
2739         * python/py-inferior.c (struct inferior_object): Give the type a
2740         tag name instead of a typedef.
2741         (python_on_normal_stop): No need to check if the current thread is
2742         listed.
2743         (inferior_to_inferior_object): Change return type to
2744         inferior_object.  All callers adjusted.
2745         (find_thread_object): Delete, bits factored out to ...
2746         (thread_to_thread_object): ... this new function.
2747         * python/py-infthread.c (create_thread_object): Use
2748         inferior_to_inferior_object.
2749         (thpy_is_stopped): Use thread pointer directly.
2750         (gdbpy_selected_thread): Use inferior_thread.
2751         * python/py-record-btrace.c (btpy_list_object) <ptid>: Delete
2752         field, replaced with ...
2753         <thread>: ... this new field.  All users adjusted.
2754         (btpy_insn_or_gap_new): Drop const.
2755         (btpy_list_new): Take a thread pointer instead of a ptid_t.  All
2756         callers adjusted.
2757         * python/py-record.c: Include "gdbthread.h".
2758         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
2759         a ptid_t.  All callers adjusted.
2760         (gdbpy_current_recording): Use inferior_thread.
2761         * python/py-record.h (recpy_record_object) <ptid>: Delete
2762         field, replaced with ...
2763         <thread>: ... this new field.  All users adjusted.
2764         (recpy_element_object) <ptid>: Delete
2765         field, replaced with ...
2766         <thread>: ... this new field.  All users adjusted.
2767         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
2768         a ptid_t.  All callers adjusted.
2769         * python/py-threadevent.c: Include "gdbthread.h".
2770         (get_event_thread): Use thread_to_thread_object.
2771         * python/python-internal.h (struct inferior_object): Forward
2772         declare.
2773         (find_thread_object, find_inferior_object): Delete declarations.
2774         (thread_to_thread_object, inferior_to_inferior_object): New
2775         declarations.
2776         * record-btrace.c: Include "inferior.h".
2777         (require_btrace_thread): Use inferior_thread.
2778         (record_btrace_frame_sniffer)
2779         (record_btrace_tailcall_frame_sniffer): Use inferior_thread.
2780         (get_thread_current_frame): Use scoped_restore_current_thread and
2781         switch_to_thread.
2782         (get_thread_current_frame): Use thread pointer directly.
2783         (record_btrace_replay_at_breakpoint): Use thread's inferior
2784         pointer directly.
2785         * record-full.c: Include "inferior.h".
2786         * regcache.c: Include "gdbthread.h".
2787         (get_thread_arch_regcache): Use the inferior's address space
2788         directly.
2789         (get_thread_regcache, registers_changed_thread): New.
2790         * regcache.h (get_thread_regcache(thread_info *thread)): New
2791         overload.
2792         (registers_changed_thread): New.
2793         (remote_target) <remote_detach_1>: Swap order of parameters.
2794         (remote_add_thread): <remote_add_thread>: Return the new thread.
2795         (get_remote_thread_info(ptid_t)): New overload.
2796         (remote_target::remote_notice_new_inferior): Use thread pointers
2797         directly.
2798         (remote_target::process_initial_stop_replies): Use
2799         thread_info::set_running.
2800         (remote_target::remote_detach_1, remote_target::detach)
2801         (extended_remote_target::detach): Adjust.
2802         * stack.c (frame_show_address): Use inferior_thread.
2803         * target-debug.h (target_debug_print_thread_info_pp): New.
2804         * target-delegates.c: Regenerate.
2805         * target.c (default_thread_address_space): Delete.
2806         (memory_xfer_partial_1): Use current_inferior.
2807         (target_detach): Use current_inferior.
2808         (target_thread_address_space): Delete.
2809         (generic_mourn_inferior): Use current_inferior.
2810         * target.h (struct target_ops) <thread_address_space>: Delete.
2811         (target_thread_address_space): Delete.
2812         * thread.c (init_thread_list): Use ALL_THREADS_SAFE.  Use thread
2813         pointers directly.
2814         (delete_thread_1, delete_thread, delete_thread_silent): Take a
2815         thread pointer instead of a ptid_t.  Adjust all callers.
2816         (ptid_to_global_thread_id, global_thread_id_to_ptid): Delete.
2817         (first_thread_of_process): Delete, replaced by ...
2818         (first_thread_of_inferior): ... this new function.  All callers
2819         adjusted.
2820         (any_thread_of_process): Rename to ...
2821         (any_thread_of_inferior): ... this, and take an inferior pointer.
2822         (any_live_thread_of_process): Rename to ...
2823         (any_live_thread_of_inferior): ... this, and take an inferior
2824         pointer.
2825         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2826         (value_in_thread_stack_temporaries)
2827         (get_last_thread_stack_temporary): Take a thread pointer instead
2828         of a ptid_t.  Adjust all callers.
2829         (thread_info::set_running): New.
2830         (validate_registers_access): Use inferior_thread.
2831         (can_access_registers_ptid): Rename to ...
2832         (can_access_registers_thread): ... this, and take a thread
2833         pointer.
2834         (print_thread_info_1): Adjust to compare thread pointers instead
2835         of ptids.
2836         (switch_to_no_thread, switch_to_thread): Make extern.
2837         (scoped_restore_current_thread::~scoped_restore_current_thread):
2838         Use m_thread pointer directly.
2839         (scoped_restore_current_thread::scoped_restore_current_thread):
2840         Use inferior_thread.
2841         (thread_command): Use thread pointer directly.
2842         (thread_num_make_value_helper): Use inferior_thread.
2843         * top.c (execute_command): Use inferior_thread.
2844         * tui/tui-interp.c: Include "inferior.h".
2845         * varobj.c (varobj_create): Use inferior_thread.
2846         (value_of_root_1): Use find_thread_global_id instead of
2847         global_thread_id_to_ptid.
2848
2849 2018-06-21  Alan Hayward  <alan.hayward@arm.com>
2850
2851         * regcache.c (readable_regcache::read_part): Avoid memcpy when
2852         possible.
2853         (regcache::write_part): Likewise.
2854         (readable_regcache::cooked_read_part): Update comment.
2855         (readable_regcache::cooked_write_part): Likewise.
2856         * regcache.h: (readable_regcache::read_part): Likewise.
2857         (regcache::write_part): Likewise.
2858
2859 2018-06-21  Richard Bunt  <richard.bunt@arm.com>
2860             Dirk Schubert  <dirk.schubert@arm.com>
2861
2862         * aarch64-linux-nat.c (post_attach): New.
2863         (aarch64_linux_nat_target::post_attach): Override post_attach to
2864         record the number of hardware debug registers.
2865
2866 2018-06-20  Tom Tromey  <tom@tromey.com>
2867
2868         * python/py-param.c (add_setshow_generic): Make parameters const.
2869         (parmpy_init): Update.
2870
2871 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
2872
2873         * regcache.h (regcache_cooked_read_ftype): Rename to...
2874         (register_read_ftype): ...this, change type to function_view.
2875         (class reg_buffer) <save>: Remove src parameter.
2876         (readonly_detached_regcache) <readonly_detached_regcache>: Make
2877         parameter non-const in first overload.  Remove src parameter in
2878         second overload.
2879         * regcache.c (do_cooked_read): Remove.
2880         (readonly_detached_regcache::readonly_detached_regcache): Make
2881         parameter non-const, adjust call to other constructor.
2882         (reg_buffer::save): Remove src parameter.
2883         * frame.c (do_frame_register_read): Remove.
2884         (frame_save_as_regcache): Use lambda function.
2885         * ppc-linux-tdep.c (ppu2spu_unwind_register): Change type of src
2886         parameter to ppu2spu_data *.
2887         (ppu2spu_sniffer): Use lambda function.
2888
2889 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
2890
2891         * record-full.c (record_full_target::insert_breakpoint): Remove
2892         "struct" keyword, add const.
2893
2894 2018-06-19  Simon Marchi  <simon.marchi@ericsson.com>
2895
2896         * common/common-defs.h (PACKAGE_NAME, PACKAGE_VERSION,
2897         PACKAGE_STRING, PACKAGE_TARNAME): Undefine.
2898         * configure.ac: Remove AC_PREREQ, add missing quoting.
2899         * gnulib/configure.ac: Modernize usage of
2900         AC_INIT/AM_INIT_AUTOMAKE.  Remove AC_PREREQ.
2901         * gnulib/update-gnulib.sh (AUTOCONF_VERSION): Bump to 2.69.
2902         (AUTOMAKE_VERSION): Bump to 1.15.1.
2903         * configure: Re-generate.
2904         * config.in: Re-generate.
2905         * aclocal.m4: Re-generate.
2906         * gnulib/aclocal.m4: Re-generate.
2907         * gnulib/config.in: Re-generate.
2908         * gnulib/configure: Re-generate.
2909         * gnulib/import/Makefile.in: Re-generate.
2910
2911 2018-06-19  Pedro Alves  <palves@redhat.com>
2912
2913         * minsyms.c (msym_prefer_to_msym_type): New, factored out from ...
2914         (lookup_minimal_symbol_by_pc_section): ... here with
2915         gdb_assert_not_reached added.
2916
2917 2018-06-19  Pedro Alves  <palves@redhat.com>
2918
2919         * inline-frame.c (stopped_by_user_bp_inline_frame): Replace PC
2920         parameter with a block parameter.  Compare location's block symbol
2921         with the frame's block instead of addresses.
2922         (skip_inline_frames): Pass the current block instead of the
2923         frame's address.  Break out as soon as we determine the frame
2924         should not be skipped.
2925
2926 2018-06-18  Tom Tromey  <tom@tromey.com>
2927
2928         * solib-aix.c (solib_aix_get_section_offsets): Return
2929         unique_xmalloc_ptr.
2930         (solib_aix_solib_create_inferior_hook): Update.
2931
2932 2018-06-18  Tom Tromey  <tom@tromey.com>
2933
2934         * solib-darwin.c (darwin_current_sos): Use unique_xmalloc_ptr.
2935
2936 2018-06-18  Tom Tromey  <tom@tromey.com>
2937
2938         * solib-frv.c (frv_relocate_main_executable): Use
2939         unique_xmalloc_ptr.
2940         * solib-dsbt.c (dsbt_relocate_main_executable): Use
2941         unique_xmalloc_ptr.
2942
2943 2018-06-18  Tom Tromey  <tom@tromey.com>
2944
2945         * objfiles.h (inhibit_section_map_updates): Update.
2946         (resume_section_map_updates, resume_section_map_updates_cleanup):
2947         Remove.
2948         * solib-svr4.c (svr4_handle_solib_event): Update.
2949         * objfiles.c (inhibit_section_map_updates): Return
2950         scoped_restore_tmpl<int>.
2951         (resume_section_map_updates, resume_section_map_updates_cleanup):
2952         Remove.
2953
2954 2018-06-18  Tom Tromey  <tom@tromey.com>
2955
2956         * valprint.h (read_string): Update.
2957         * valprint.c (read_string): Change type of "buffer".
2958         (val_print_string): Update.
2959         * python/py-value.c (valpy_string): Update.
2960         * language.h (struct language_defn) <la_get_string>: Change
2961         type of "buffer".
2962         (default_get_string, c_get_string): Update.
2963         * language.c (default_get_string): Change type of "buffer".
2964         * guile/scm-value.c (gdbscm_value_to_string): Update.
2965         * c-lang.c (c_get_string): Change type of "buffer".
2966
2967 2018-06-18  Tom Tromey  <tom@tromey.com>
2968
2969         * ser-mingw.c (struct pipe_state_destroyer): New.
2970         (pipe_state_up): New typedef.
2971         (cleanup_pipe_state): Remove.
2972         (pipe_windows_open): Use pipe_state_up.  Don't release argv.
2973
2974 2018-06-18  Tom Tromey  <tom@tromey.com>
2975
2976         * rust-lang.h (rust_yyerror): Don't declare.
2977         * rust-lang.c (rust_language_defn): Update.
2978         * rust-exp.y (yyerror): Now static.
2979         * parse.c (parse_exp_in_context_1): Update.
2980         * p-lang.h (p_yyerror): Don't declare.
2981         * p-lang.c (p_language_defn): Update.
2982         * p-exp.y (yyerror): Now static.
2983         * opencl-lang.c (opencl_language_defn): Update.
2984         * objc-lang.c (objc_language_defn): Update.
2985         * m2-lang.h (m2_yyerror): Don't declare.
2986         * m2-lang.c (m2_language_defn): Update.
2987         * m2-exp.y (yyerror): Now static.
2988         * language.h (struct language_defn) <la_error>: Remove.
2989         * language.c (unk_lang_error): Remove.
2990         (unknown_language_defn, auto_language_defn): Remove.
2991         * go-lang.h (go_yyerror): Don't declare.
2992         * go-lang.c (go_language_defn): Update.
2993         * go-exp.y (yyerror): Now static.
2994         * f-lang.h (f_yyerror): Don't declare.
2995         * f-lang.c (f_language_defn): Update.
2996         * f-exp.y (yyerror): Now static.
2997         * d-lang.h (d_yyerror): Don't declare.
2998         * d-lang.c (d_language_defn): Update.
2999         * d-exp.y (yyerror): Now static.
3000         * c-lang.h (c_yyerror): Don't declare.
3001         * c-lang.c (c_language_defn, cplus_language_defn)
3002         (asm_language_defn, minimal_language_defn): Update.
3003         * c-exp.y (yyerror): Now static.
3004         * ada-lang.h (ada_yyerror): Don't declare.
3005         * ada-lang.c (ada_language_defn): Update.
3006         * ada-exp.y (yyerror): Now static.
3007
3008 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
3009
3010         * aarch64-linux-nat.c (fetch_sveregs_from_thread): New function.
3011         (store_sveregs_to_thread): Likewise.
3012         (aarch64_linux_fetch_inferior_registers): Check for SVE.
3013         (aarch64_linux_store_inferior_registers): Likewise.
3014         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs): New
3015         function.
3016         (aarch64_sve_regs_copy_to_regcache): Likewise.
3017         (aarch64_sve_regs_copy_from_regcache): Likewise.
3018         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_sveregs): New
3019         declaration.
3020         (aarch64_sve_regs_copy_to_regcache): Likewise.
3021         (aarch64_sve_regs_copy_from_regcache): Likewise.
3022         (sve_context): Structure from Linux headers.
3023         (SVE_SIG_ZREGS_SIZE): Define from Linux headers.
3024         (SVE_SIG_ZREG_SIZE): Likewise.
3025         (SVE_SIG_PREG_SIZE): Likewise.
3026         (SVE_SIG_FFR_SIZE): Likewise.
3027         (SVE_SIG_REGS_OFFSET): Likewise.
3028         (SVE_SIG_ZREGS_OFFSET): Likewise.
3029         (SVE_SIG_ZREG_OFFSET): Likewise.
3030         (SVE_SIG_ZREGS_SIZE): Likewise.
3031         (SVE_SIG_PREGS_OFFSET): Likewise.
3032         (SVE_SIG_PREG_OFFSET): Likewise.
3033         (SVE_SIG_PREGS_SIZE): Likewise.
3034         (SVE_SIG_FFR_OFFSET): Likewise.
3035         (SVE_SIG_REGS_SIZE): Likewise.
3036         (SVE_SIG_CONTEXT_SIZE): Likewise.
3037         (SVE_PT_REGS_MASK): Likewise.
3038         (SVE_PT_REGS_FPSIMD): Likewise.
3039         (SVE_PT_REGS_SVE): Likewise.
3040         (SVE_PT_VL_INHERIT): Likewise.
3041         (SVE_PT_VL_ONEXEC): Likewise.
3042         (SVE_PT_REGS_OFFSET): Likewise.
3043         (SVE_PT_FPSIMD_OFFSET): Likewise.
3044         (SVE_PT_FPSIMD_SIZE): Likewise.
3045         (SVE_PT_SVE_ZREG_SIZE): Likewise.
3046         (SVE_PT_SVE_PREG_SIZE): Likewise.
3047         (SVE_PT_SVE_FFR_SIZE): Likewise.
3048         (SVE_PT_SVE_FPSR_SIZE): Likewise.
3049         (SVE_PT_SVE_FPCR_SIZE): Likewise.
3050         (__SVE_SIG_TO_PT): Likewise.
3051         (SVE_PT_SVE_OFFSET): Likewise.
3052         (SVE_PT_SVE_ZREGS_OFFSET): Likewise.
3053         (SVE_PT_SVE_ZREG_OFFSET): Likewise.
3054         (SVE_PT_SVE_ZREGS_SIZE): Likewise.
3055         (SVE_PT_SVE_PREGS_OFFSET): Likewise.
3056         (SVE_PT_SVE_PREG_OFFSET): Likewise.
3057         (SVE_PT_SVE_PREGS_SIZE): Likewise.
3058         (SVE_PT_SVE_FFR_OFFSET): Likewise.
3059         (SVE_PT_SVE_FPSR_OFFSET): Likewise.
3060         (SVE_PT_SVE_FPCR_OFFSET): Likewise.
3061         (SVE_PT_SVE_SIZE): Likewise.
3062         (SVE_PT_SIZE): Likewise.
3063         (HAS_SVE_STATE): New define.
3064
3065 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
3066
3067         * nat/aarch64-sve-linux-sigcontext.h: New file.
3068         * nat/aarch64-sve-linux-ptrace.h (SVE_VQ_BYTES): Move to
3069         new files.
3070         (SVE_VQ_MIN): Likewise.
3071         (SVE_VQ_MAX): Likewise.
3072         (SVE_VL_MIN): Likewise.
3073         (SVE_VL_MAX): Likewise.
3074         (SVE_NUM_ZREGS): Likewise.
3075         (SVE_NUM_PREGS): Likewise.
3076         (sve_vl_valid): Likewise.
3077         (struct user_sve_header): Likewise.
3078
3079 2018-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3080             Richard Bunt <Richard.Bunt@arm.com>
3081
3082         * linux-nat.c (stop_wait_callback): Don't discard SIGSTOP if it
3083         was requested by GDB.
3084
3085 2018-06-15  Tom de Vries  <tdevries@suse.de>
3086
3087         * MAINTAINERS (Write After Approval): Add Tom de Vries.
3088
3089 2018-06-14  Simon Marchi  <simon.marchi@polymtl.ca>
3090
3091         * gnulib/update-gnulib.sh: Print expected versions of
3092         autoconf/aclocal.
3093
3094 2018-06-14  Simon Marchi  <simon.marchi@ericsson.com>
3095
3096         * arch-utils.c (default_type_align): Use type_length_units.
3097         * gdbtypes.c (type_align): Use type_length_units.
3098
3099 2018-06-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3100
3101         * cli/cli-script.c (_initialize_cli_script): Fix online documentation
3102         of 'define' command.
3103
3104 2018-06-14  Tom de Vries  <tdevries@suse.de>
3105
3106         PR cli/22573
3107         * infcmd.c (print_return_value_1): Use get_user_print_options instead of
3108         get_no_prettyformat_print_options.
3109
3110 2018-06-13  Simon Marchi  <simon.marchi@ericsson.com>
3111
3112         * sparc-nat.h: Include target.h.
3113         * sparc64-linux-nat.c (class sparc64_linux_nat_target)
3114         <fetch_registers>: Remove this argument in function call.
3115         <store_registers>: Remove this argument in function call, remove
3116         extra semicolon.
3117         <low_forget_process>: Call sparc64_forget_process instead of
3118         sparc_forget_process.
3119
3120 2018-06-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3121
3122         * procfs.c (_initialize_procfs): Use add_inf_child_target.
3123         (procfs_target::make_corefile_notes): Adjust to new
3124         target_read_alloc return type.
3125
3126 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3127             Stephen Roberts  <stephen.roberts@arm.com>
3128
3129         PR gdb/22882
3130         * infrun.c (fetch_inferior_event): If GDB is not proceeding then
3131         run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
3132         Move should_notify_stop local into more inner scope.
3133
3134 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3135             Stephen Roberts  <stephen.roberts@arm.com>
3136
3137         PR gdb/22882
3138         * infrun.c (resume_1): Add call to mark_async_event_handler.
3139
3140 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * infrun.c (do_target_wait): Change old version of $pc printed.
3143
3144 2018-06-11  Simon Marchi  <simon.marchi@ericsson.com>
3145
3146         * dwarf2read.c (read_index_from_section): Rename to...
3147         (read_gdb_index_from_section): ... this, update all callers.
3148         (dwarf2_read_index): Rename to...
3149         (dwarf2_read_gdb_index): ... this, update all callers.
3150
3151 2018-06-11  John David Anglin  <danglin@gcc.gnu.org>
3152
3153         * gdb/hppa-linux-nat.c
3154         (hppa_linux_nat_target::fetch_inferior_registers): Rename to
3155         hppa_linux_nat_target::fetch_registers.
3156
3157 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
3158
3159         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Add mappings.
3160         * aarch64-tdep.h (AARCH64_DWARF_SVE_VG): Add define.
3161         (AARCH64_DWARF_SVE_FFR): Likewise.
3162         (AARCH64_DWARF_SVE_P0): Likewise.
3163         (AARCH64_DWARF_SVE_Z0): Likewise.
3164
3165 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
3166
3167         * common/common-regcache.h (raw_compare): New function.
3168         * regcache.c (regcache::raw_compare): Likewise.
3169         * regcache.h (regcache::raw_compare): New declaration.
3170
3171 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
3172
3173         * common/common-regcache.h (reg_buffer_common): New structure.
3174         * regcache.c (reg_buffer::invalidate): Move from detached_regcache.
3175         (reg_buffer::raw_supply): Likewise.
3176         (reg_buffer::raw_supply_integer): Likewise.
3177         (reg_buffer::raw_supply_zeroed): Likewise.
3178         (reg_buffer::raw_collect): Likewise.
3179         (reg_buffer::raw_collect_integer): Likewise.
3180         * regcache.h (reg_buffer::invalidate): Move from detached_regcache.
3181         (reg_buffer::raw_supply): Likewise.
3182         (reg_buffer::raw_supply_integer): Likewise.
3183         (reg_buffer::raw_supply_zeroed): Likewise.
3184         (reg_buffer::raw_collect): Likewise.
3185         (reg_buffer::raw_collect_integer): Likewise.
3186
3187 2018-06-10  Tom Tromey  <tom@tromey.com>
3188
3189         * remote.c (stop_reply_p): Remove typedef.  Don't declare queue.
3190         (class remote_state) <stop_reply_queue>: Now std::vector.
3191         (remote_state::~remote_state)
3192         (remote_target::stop_reply_queue_length): Update.
3193         (struct queue_iter_param, remove_child_of_pending_fork)
3194         (struct check_pending_event_prevents_wildcard_vcont_callback_data)
3195         (check_pending_event_prevents_wildcard_vcont_callback)
3196         (remove_stop_reply_for_inferior)
3197         (remove_stop_reply_of_remote_state)
3198         (remote_notif_remove_once_on_match)
3199         (stop_reply_match_ptid_and_ws)
3200         (remote_kill_child_of_pending_fork): Remove.
3201         (remote_target::remove_new_fork_children)
3202         (remote_target::check_pending_events_prevent_wildcard_vcont)
3203         (remote_target::discard_pending_stop_replies)
3204         (remote_target::discard_pending_stop_replies_in_queue)
3205         (remote_target::remote_notif_remove_queued_reply)
3206         (remote_target::queued_stop_reply)
3207         (remote_target::push_stop_reply, remote_target::peek_stop_reply)
3208         (remote_target::wait, remote_target::kill_new_fork_children)
3209         (remote_target::async): Update.
3210
3211 2018-06-10  Tom Tromey  <tom@tromey.com>
3212
3213         * record-full.c (record_full_arch_list_cleanups): Remove.
3214         (record_full_message): Use try/catch.
3215         (record_full_wait_cleanups): Remove.
3216         (record_full_wait_1): Use try/catch.
3217         (record_full_restore): Likewise.
3218
3219 2018-06-10  Tom Tromey  <tom@tromey.com>
3220
3221         * record-full.c (record_full_breakpoint_p): Remove typedef.  Don't
3222         declare VEC.  Add constructor.
3223         <in_target_beneath>: Now bool.
3224         (record_full_breakpoints): Now a std::vector, static.
3225         (record_full_sync_record_breakpoints)
3226         (record_full_init_record_breakpoints)
3227         (record_full_target::insert_breakpoint)
3228         (record_full_target::remove_breakpoint): Update.  Don't use XNEW.
3229
3230 2018-06-10  Simon Marchi  <simon.marchi@polymtl.ca>
3231
3232         * dwarf2read.c (process_cu_includes): Remove struct keyword.
3233         * serial.c (serial_interface_lookup): Remove struct keyword.
3234
3235 2018-06-10  Tom Tromey  <tom@tromey.com>
3236
3237         * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
3238         method.
3239         * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
3240         a method.
3241         * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
3242         method.
3243         * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
3244         "beneath" as a method.
3245         * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
3246         Use "beneath" as a method.
3247
3248 2018-06-10  Tom Tromey  <tom@tromey.com>
3249
3250         * tracefile.c (struct trace_file_writer_deleter): New.
3251         <operator()>: Rename from trace_file_writer_xfree.
3252         (trace_file_writer_up): New typedef.
3253         (tsave_command, trace_save_tfile, trace_save_ctf): Update.
3254
3255 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
3256
3257         * regcache.h (reg_buffer) <~reg_buffer>: Use default destructor.
3258         <m_registers, m_register_status>: Change type to
3259         std::unique_ptr.
3260         * regcache.c (reg_buffer::reg_buffer): Use new instead of
3261         XCNEWVEC.
3262
3263 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
3264
3265         * common/common-regcache.h (enum register_status): Add
3266         underlying type "signed char".
3267         * regcache.h (reg_buffer) <m_register_status>: Change type to
3268         register_status *.
3269         * regcache.c (reg_buffer::reg_buffer): Alocate arrays of
3270         register_status instead of signed char.
3271         (reg_buffer::save): Use REG_UNKNOWN instead of 0.
3272         (reg_buffer::get_register_status): Remove cast.
3273         (readable_regcache::raw_read): Remove cast.
3274         (readable_regcache::cooked_read): Remove cast.
3275
3276 2018-06-09  Tom Tromey  <tom@tromey.com>
3277
3278         * source.c (reverse_search_command, forward_search_command): Use
3279         scoped_fd.
3280
3281 2018-06-09  Tom Tromey  <tom@tromey.com>
3282
3283         * serial.c (serial_ops_p): Remove typedef.  Don't declare VEC.
3284         (serial_ops_list): Now static, std::vector.
3285         (serial_interface_lookup, serial_add_interface): Update.
3286
3287 2018-06-09  Tom Tromey  <tom@tromey.com>
3288
3289         * dwarf2read.c (process_cu_includes): Update.
3290         (process_full_comp_unit): Update.
3291         * dwarf2read.h (struct dwarf2_per_objfile) <just_read_cus>: Now a
3292         std::vector.
3293
3294 2018-06-08  Paul Koning  <paul_koning@dell.com>
3295
3296         PR gdb/23252
3297
3298         * python/python.c (do_start_initialization):
3299         Avoid call to internal Python API.
3300         (init__gdb_module): New function.
3301
3302 2018-06-08  Gary Benson <gbenson@redhat.com>
3303
3304         * linux-thread-db.c (valprint.h): New include.
3305         (struct check_thread_db_info): New structure.
3306         (check_thread_db_on_load, tdb_testinfo): New static globals.
3307         (check_thread_db, check_thread_db_callback): New functions.
3308         (try_thread_db_load_1): Run integrity checks if requested.
3309         (maintenance_check_libthread_db): New function.
3310         (_initialize_thread_db): Register "maint check libthread-db"
3311         and "maint set/show check-libthread-db".
3312         * NEWS: Mention the above new commands.
3313
3314 2018-06-08  Tom Tromey  <tom@tromey.com>
3315
3316         * windows-nat.c (windows_nat_target::xfer_partial): "beneath" is
3317         now a method.
3318
3319 2018-06-08  Tom Tromey  <tom@tromey.com>
3320
3321         * btrace.c (parse_xml_raw): Use gdb::unique_xmalloc_ptr.
3322
3323 2018-06-08  Tom Tromey  <tom@tromey.com>
3324
3325         * common/btrace-common.h (struct btrace_data): Add constructor,
3326         destructor, move assignment operator.
3327         <empty, clear, fini>: New methods.
3328         <format>: Initialize.
3329         (btrace_data_init, btrace_data_fini, btrace_data_clear)
3330         (btrace_data_empty): Don't declare.
3331         * common/btrace-common.c (btrace_data_init): Remove.
3332         (btrace_data::fini): Rename from btrace_data_fini.
3333         (btrace_data::empty): Rename from btrace_data_empty.
3334         (btrace_data::clear): Rename from btrace_data_clear.  Return
3335         bool.
3336         * btrace.h (make_cleanup_btrace_data): Don't declare.
3337         * btrace.c (btrace_add_pc, btrace_stitch_trace, btrace_clear)
3338         (parse_xml_btrace): Update.
3339         (do_btrace_data_cleanup, make_cleanup_btrace_data): Remove.
3340         (maint_btrace_clear_packet_history_cmd): Update.
3341
3342 2018-06-07  Pedro Alves  <palves@redhat.com>
3343
3344         * target.h (target_ops) <beneath>: Now a method.  All references
3345         updated.
3346         (class target_stack): New.
3347         * target.c (g_target_stack): New.
3348         (g_current_top_target): Delete.
3349         (current_top_target): Get the top target out of g_target_stack.
3350         (target_stack::push, target_stack::unpush): New.
3351         (push_target, unpush_target): Reimplement.
3352         (target_is_pushed): Reimplement in terms of g_target_stack.
3353         (target_ops::beneath, target_stack::find_beneath): New.
3354
3355 2018-06-07  Pedro Alves  <palves@redhat.com>
3356
3357         * target.h (find_target_beneath): Delete declaration.
3358         * target.c (find_target_beneath): Delete definition.
3359         * aix-thread.c: All callers of find_target_beneath adjusted to
3360         call target_ops::beneath instead.
3361         * bsd-uthread.c: Likewise.
3362         * linux-thread-db.c: Likewise.
3363         * ravenscar-thread.c: Likewise.
3364         * sol-thread.c: Likewise.
3365         * spu-multiarch.c: Likewise.
3366
3367 2018-06-07  Pedro Alves  <palves@redhat.com>
3368
3369         * target.h (target_ops) <beneath>: Now a method.  All references
3370         updated.
3371         (target_ops) <m_beneath>: New.
3372         * target.c (target_ops::beneath): New.
3373         * corelow.c: Adjust all references to target_ops::beneath.
3374         * linux-thread-db.c: Likewise.
3375         * make-target-delegates: Likewise.
3376         * record-btrace.c: Likewise.
3377         * record-full.c: Likewise.
3378         * remote.c: Likewise.
3379         * target.c: Likewise.
3380         * target-delegates.c: Regenerate.
3381
3382 2018-06-07  Pedro Alves  <palves@redhat.com>
3383
3384         * target.h (target_stack): Delete.
3385         (current_top_target): Declare function.
3386         * target.c (target_stack): Delete.
3387         (g_current_top_target): New.
3388         (current_top_target): New function.
3389         * auxv.c: Use current_top_target instead of target_stack
3390         throughout.
3391         * avr-tdep.c: Likewise.
3392         * breakpoint.c: Likewise.
3393         * corefile.c: Likewise.
3394         * elfread.c: Likewise.
3395         * eval.c: Likewise.
3396         * exceptions.c: Likewise.
3397         * frame.c: Likewise.
3398         * gdbarch-selftests.c: Likewise.
3399         * gnu-v3-abi.c: Likewise.
3400         * ia64-tdep.c: Likewise.
3401         * ia64-vms-tdep.c: Likewise.
3402         * infcall.c: Likewise.
3403         * infcmd.c: Likewise.
3404         * infrun.c: Likewise.
3405         * linespec.c: Likewise.
3406         * linux-tdep.c: Likewise.
3407         * minsyms.c: Likewise.
3408         * ppc-linux-nat.c: Likewise.
3409         * ppc-linux-tdep.c: Likewise.
3410         * procfs.c: Likewise.
3411         * regcache.c: Likewise.
3412         * remote.c: Likewise.
3413         * rs6000-tdep.c: Likewise.
3414         * s390-linux-nat.c: Likewise.
3415         * s390-tdep.c: Likewise.
3416         * solib-aix.c: Likewise.
3417         * solib-darwin.c: Likewise.
3418         * solib-dsbt.c: Likewise.
3419         * solib-spu.c: Likewise.
3420         * solib-svr4.c: Likewise.
3421         * solib-target.c: Likewise.
3422         * sparc-tdep.c: Likewise.
3423         * sparc64-tdep.c: Likewise.
3424         * spu-tdep.c: Likewise.
3425         * symfile.c: Likewise.
3426         * symtab.c: Likewise.
3427         * target-descriptions.c: Likewise.
3428         * target-memory.c: Likewise.
3429         * target.c: Likewise.
3430         * target.h: Likewise.
3431         * tracefile-tfile.c: Likewise.
3432         * tracepoint.c: Likewise.
3433         * valops.c: Likewise.
3434         * valprint.c: Likewise.
3435         * value.c: Likewise.
3436         * windows-tdep.c: Likewise.
3437         * mi/mi-main.c: Likewise.
3438
3439 2018-06-07  Tom Tromey  <tom@tromey.com>
3440
3441         * valprint.h (build_address_symbolic): Declare.
3442         * printcmd.c (print_address_symbolic): Update.
3443         (build_address_symbolic): Change "name" and "filename" to
3444         std::string.
3445         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3446         Update.
3447         * defs.h (build_address_symbolic): Remove declaration.
3448
3449 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
3450
3451         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
3452         (aarch64_vnv_type): Add function.
3453         (aarch64_pseudo_register_name): Add V regs for SVE.
3454         (aarch64_pseudo_register_type): Likewise.
3455         (aarch64_pseudo_register_reggroup_p): Likewise.
3456         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
3457         (aarch64_pseudo_read_value): Add V regs for SVE.
3458         (aarch64_pseudo_write_2): Use V0 offset for SVE
3459         (aarch64_pseudo_write): Add V regs for SVE.
3460         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
3461
3462 2018-06-06  Sergio Durigan Junior  <sergiodj@redhat.com>
3463
3464         * arch/aarch64.h (sve_vq_from_vl): Guard with #ifndef.
3465         (sve_vl_from_vq): Likewise.
3466
3467 2018-06-05  Tom Tromey  <tom@tromey.com>
3468
3469         * cli/cli-cmds.c (show_version): Update.
3470         * top.c (print_gdb_version): Add "interactive" parameter.
3471         Update.
3472         * main.c (captured_main_1): Update.
3473         * top.h (print_gdb_version): Add "interactive" parameter and a
3474         comment.
3475
3476 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
3477
3478         * common/enum-flags.h: Add trailing semicolon to example in
3479         comment.
3480
3481 2018-06-05  Tom Tromey  <tom@tromey.com>
3482
3483         PR cli/12326:
3484         * NEWS: Add entry about pager.
3485         * utils.c (pagination_disabled_for_command): New global.
3486         (prompt_for_continue): Allow "c" response to prompt.
3487         (reinitialize_more_filter): Clear
3488         pagination_disabled_for_command.
3489         (fputs_maybe_filtered): Check pagination_disabled_for_command.
3490
3491 2018-06-04  Tom Tromey  <tom@tromey.com>
3492
3493         * ada-lang.h (ada_lookup_symbol_list): Update.
3494         * ada-lang.c (resolve_subexp): Update.
3495         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
3496         parameter.
3497         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
3498         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
3499         results parameter to std::vector.
3500         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
3501         Update.
3502         * ada-exp.y (block_lookup): Update.
3503         (select_possible_type_sym): Change type of syms.  Remove nsyms
3504         parameter.
3505         (write_var_or_type, write_name_assoc): Update.
3506
3507 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
3508
3509         * windows-nat.c (windows_nat_target::xfer_partial): Return
3510         TARGET_XFER_E_IO if we need to delegate to the target beneath
3511         but BENEATH is NULL.
3512
3513 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
3514
3515         * Makefile.in (config.status): Add configure.nat as a
3516         dependency.
3517
3518 2018-06-04  Tom Tromey  <tom@tromey.com>
3519
3520         * cp-name-parser.y (cpname_state): Add method declarations.
3521         (HANDLE_QUAL): Update.
3522         (cpname_state::d_grab, cpname_state::fill_comp)
3523         (cpname_state::make_operator, cpname_state::make_dtor)
3524         (cpname_state::make_builtin_type, cpname_state::make_name)
3525         (cpname_state::d_qualify, cpname_state::d_int_type)
3526         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
3527         (%union): Move earlier.
3528
3529 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3530
3531         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
3532
3533 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3534
3535         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
3536         (aarch64_pseudo_write_1): Likewise.
3537         (aarch64_pseudo_read_value): Use helper.
3538         (aarch64_pseudo_write): Likewise.
3539
3540 2018-06-04  Pedro Alves  <palves@redhat.com>
3541
3542         * darwin-nat.c (darwin_ops): Delete.
3543         (darwin_attach_pid): Use get_native_target.
3544
3545 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3546
3547         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
3548         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
3549
3550 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3551
3552         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
3553         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
3554         (aarch64_gdbarch_init): Check for SVE.
3555         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
3556
3557 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3558
3559         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
3560         * aarch64-tdep.h (aarch64_read_description): Likewise.
3561         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3562         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3563         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
3564         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
3565         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
3566
3567 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
3568
3569         * value.c (value_fetch_lazy_bitfield): New.
3570         (value_fetch_lazy_memory): New.
3571         (value_fetch_lazy_register): New.
3572         (value_fetch_lazy): Factor out to smaller functions.
3573
3574 2018-06-01  Tom Tromey  <tom@tromey.com>
3575
3576         * cp-name-parser.y (backslashable, represented): Now const.
3577
3578 2018-06-01  Tom Tromey  <tom@tromey.com>
3579
3580         * cp-name-parser.y: Include parser-defs.h.
3581         (parser_fprintf): Remove declaration.
3582
3583 2018-06-01  Tom Tromey  <tom@tromey.com>
3584
3585         * cp-name-parser.y: Use %pure-parser, %lex-param, and
3586         %parse-param.
3587         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
3588         (global_result): Remove globals.
3589         (struct cpname_state): New.
3590         (yyparse): Don't declare.
3591         (yylex, yyerror): Move declarations after %union.
3592         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
3593         (make_name): Add state parameter.
3594         Update all callers.
3595         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
3596         parameter.
3597         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
3598         Update.
3599         (yylex): Add lvalp, state parameters.
3600         (yyerror): Add state parameter.
3601         (cp_demangled_name_to_comp): Update.
3602
3603 2018-06-01  Tom Tromey  <tom@tromey.com>
3604
3605         * cp-name-parser.y (parser_fprintf): Declare.
3606         (GDB_YY_REMAP_PREFIX): Define.
3607         Include yy-remap.h.  Don't redefine yy* identifiers.
3608
3609 2018-06-01  Tom Tromey  <tom@tromey.com>
3610
3611         * python/py-type.c (typy_legacy_template_argument): Update.
3612         * cp-support.h (cp_demangled_name_to_comp): Update.
3613         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
3614         parameter to be a "std::string *".
3615         (main): Update.
3616
3617 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
3618
3619         * ada-lex.l: Include "diagnostics.h" instead of
3620         "common/diagnostics.h".
3621         * unittests/environ-selftests.c: Likewise.
3622         * common/diagnostics.h: Moved to ../include.
3623
3624 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
3625
3626         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
3627         to language_mode_manual while calling breakpoint_re_set_one.
3628
3629 2018-06-01  Tom Tromey  <tom@tromey.com>
3630
3631         * valops.c (value_cast_structs, destructor_name_p): Update.
3632         * symtab.c (gdb_mangle_name): Update.
3633         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
3634         Update.
3635         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
3636         (pascal_object_print_value_fields, pascal_object_print_value):
3637         Update.
3638         * p-typeprint.c (pascal_type_print_derivation_info): Update.
3639         * linespec.c (find_methods): Update.
3640         * gdbtypes.h (type_name_no_tag): Remove.
3641         (type_name_or_error): Rename from type_name_no_tag_or_error.
3642         * gdbtypes.c (type_name_no_tag): Remove.
3643         (type_name_or_error): Rename from type_name_no_tag_or_error.
3644         (lookup_struct_elt_type, check_typedef): Update.
3645         * expprint.c (print_subexp_standard): Update.
3646         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
3647         * d-namespace.c (d_lookup_nested_symbol): Update.
3648         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
3649         (cp_print_class_member): Update.
3650         * cp-namespace.c (cp_lookup_nested_symbol): Update.
3651         * completer.c (add_struct_fields): Update.
3652         * c-typeprint.c (cp_type_print_derivation_info)
3653         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
3654         Update.
3655         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
3656         (ada_prefer_type, ada_is_exception_sym): Update.
3657
3658 2018-06-01  Tom Tromey  <tom@tromey.com>
3659
3660         * valops.c (enum_constant_from_type, value_namespace_elt)
3661         (value_maybe_namespace_elt): Update.
3662         * valarith.c (find_size_for_pointer_math): Update.
3663         * target-descriptions.c (make_gdb_type): Update.
3664         * symmisc.c (print_symbol): Update.
3665         * stabsread.c (define_symbol, read_type)
3666         (complain_about_struct_wipeout, add_undefined_type)
3667         (cleanup_undefined_types_1): Update.
3668         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
3669         (rust_range_type_p, val_print_struct, rust_print_struct_def)
3670         (rust_internal_print_type, rust_composite_type)
3671         (rust_evaluate_funcall, rust_evaluate_subexp)
3672         (rust_inclusive_range_type_p): Update.
3673         * python/py-type.c (typy_get_tag): Update.
3674         * p-typeprint.c (pascal_type_print_base): Update.
3675         * mdebugread.c (parse_symbol, parse_type): Update.
3676         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
3677         Update.
3678         * guile/scm-type.c (gdbscm_type_tag): Update.
3679         * go-lang.c (sixg_string_p): Update.
3680         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
3681         Update.
3682         * gdbtypes.h (struct main_type) <tag_name>: Remove.
3683         (TYPE_TAG_NAME): Remove.
3684         * gdbtypes.c (type_name_no_tag): Simplify.
3685         (check_typedef, check_types_equal, recursive_dump_type)
3686         (copy_type_recursive, arch_composite_type): Update.
3687         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
3688         in summary mode when needed.
3689         * eval.c (evaluate_funcall): Update.
3690         * dwarf2read.c (fixup_go_packaging, read_structure_type)
3691         (process_structure_scope, read_enumeration_type)
3692         (read_namespace_type, read_module_type, determine_prefix): Update.
3693         * cp-support.c (inspect_type): Update.
3694         * coffread.c (process_coff_symbol, decode_base_type): Update.
3695         * c-varobj.c (c_is_path_expr_parent): Update.
3696         * c-typeprint.c (c_type_print_base_struct_union): Update.
3697         (c_type_print_base_1): Update.  Print struct/class/union/enum in
3698         summary when using C language.
3699         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
3700         (gen_maybe_namespace_elt): Update.
3701         * ada-lang.c (ada_type_name): Simplify.
3702         (empty_record, ada_template_to_fixed_record_type_1)
3703         (template_to_static_fixed_type)
3704         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
3705
3706 2018-06-01  Tom Tromey  <tom@tromey.com>
3707
3708         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
3709         c_print_type.
3710         * c-typeprint.c (c_print_type_1): Add "language" parameter.
3711         (c_print_type): Update.
3712         (c_print_type): New overload.
3713         (c_type_print_varspec_prefix, c_type_print_args)
3714         (c_type_print_varspec_suffix, c_print_type_no_offsets)
3715         (c_type_print_base_struct_union, c_type_print_base_1)
3716         (cp_type_print_method_args): Add "language" parameter.
3717         (c_type_print_base): Update.
3718         * c-lang.h (c_print_type): Add new overload.
3719
3720 2018-06-01  Tom Tromey  <tom@tromey.com>
3721
3722         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
3723         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
3724
3725 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * aarch64-tdep.c (aarch64_sve_register_names): New const
3728         var.
3729         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
3730         (AARCH64_SVE_Z_REGS_NUM): New define.
3731         (AARCH64_SVE_P_REGS_NUM): Likewise.
3732         (AARCH64_SVE_NUM_REGS): Likewise.
3733
3734 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
3735
3736         * nat/linux-ptrace.h [__alpha__]
3737         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
3738         definitions.
3739
3740 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
3741
3742         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
3743         the endianness selected.
3744         * NEWS: Document `set endian auto' mode operation update.
3745
3746 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
3747
3748         * Makefile.in: Add new header.
3749         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
3750         (sve_vl_from_vg): Likewise.
3751         (sve_vq_from_vl): Likewise.
3752         (sve_vl_from_vq): Likewise.
3753         (sve_vq_from_vg): Likewise.
3754         (sve_vg_from_vq): Likewise.
3755         * configure.nat: Add new c file.
3756         * nat/aarch64-sve-linux-ptrace.c: New file.
3757         * nat/aarch64-sve-linux-ptrace.h: New file.
3758
3759 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
3760
3761         * aarch64-linux-nat.c (aarch64_linux_read_description):
3762         Add parmeter zero.
3763         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3764         Likewise.
3765         * aarch64-tdep.c (tdesc_aarch64_list): Add.
3766         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
3767         (aarch64_gdbarch_init): Add parmeter zero.
3768         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
3769         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
3770         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
3771         parmeter.
3772         * doc/gdb.texinfo: Describe SVE feature
3773         * features/aarch64-sve.c: New file.
3774
3775 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
3776
3777         PR gdb/23210
3778         * gdbarch.sh (significant_addr_bit): Default to zero when
3779         not set by target architecture.
3780         * gdbarch.c: Re-generated.
3781         * utils.c (address_significant): Update.
3782
3783 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
3784
3785         * stack.c (func_command): Remove trailing newline in call to error.
3786
3787 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3788
3789         * regcache.h (regcache_raw_collect): Remove, update callers to
3790         use regcache::raw_collect.
3791         * regcache.c (regcache_raw_collect): Remove.
3792
3793 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3794
3795         * regcache.h (regcache_raw_supply): Remove, update callers to
3796         use detached_regcache::raw_supply.
3797         * regcache.c (regcache_raw_supply): Remove.
3798
3799 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3800
3801         * regcache.h (regcache_cooked_write_part): Remove, update
3802         callers to use regcache::cooked_write_part.
3803         * regcache.c (regcache_cooked_write_part): Remove.
3804
3805 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3806
3807         * regcache.h (regcache_cooked_read_part): Remove, update callers
3808         to use readable_regcache::cooked_read_part.
3809         * regcache.c (regcache_cooked_read_part): Remove.
3810
3811 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3812
3813         * regcache.h (regcache_cooked_read_value): Remove, update
3814         callers to use readable_regcache::cooked_read_value.
3815         * regcache.c (regcache_cooked_read_value): Remove.
3816
3817 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3818
3819         * regcache.h (regcache_cooked_write): Remove, update callers to
3820         use regcache::cooked_write.
3821         * regcache.c (regcache_cooked_write): Remove.
3822
3823 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3824
3825         * regcache.h (regcache_invalidate): Remove, update callers to
3826         use detached_regcache::invalidate instead.
3827         * regcache.c (regcache_invalidate): Remove.
3828
3829 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3830
3831         * regcache.h (regcache_raw_write_part): Remove, update callers
3832         to use regcache::raw_write_part instead.
3833         * regcache.c (regcache_raw_write_part): Remove.
3834
3835 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3836
3837         * regcache.h (regcache_raw_read_part): Remove, update callers to
3838         use readable_regcache::raw_read_part instead.
3839         * regcache.c (regcache_raw_read_part): Remove.
3840
3841 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3842
3843         * regcache.h (regcache_cooked_read): Remove, update callers to
3844         use readable_regcache::cooked_read instead.
3845         * regcache.c (regcache_cooked_read): Remove.
3846
3847 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3848
3849         * regcache.h (regcache_raw_write): Remove, update callers to use
3850         regcache::raw_write instead.
3851         * regcache.c (regcache_raw_write): Remove.
3852
3853 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3854
3855         * regcache.h (regcache_raw_read): Remove, update callers to use
3856         readable_regcache::raw_read instead.
3857         * regcache.c (regcache_raw_read): Remove.
3858
3859 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3860
3861         * regcache.h (regcache_raw_update): Remove, update callers to
3862         use readable_regcache::raw_update instead.
3863         * regcache.c (regcache_raw_update): Remove.
3864
3865 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3866
3867         * regcache.h (regcache_register_status): Remove, update callers
3868         to use reg_buffer::get_register_status directly instead.
3869         * regcache.c (regcache_register_status): Remove.
3870
3871 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3872
3873         * regcache.h (regcache_get_ptid): Remove, update all callers to
3874         call regcache::ptid instead.
3875         * regcache.c (regcache_get_ptid): Remove.
3876
3877 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3878
3879         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
3880
3881 2018-05-30  Pedro Alves  <palves@redhat.com>
3882
3883         * common/common-exceptions.h (exception_rethrow): Use
3884         ATTRIBUTE_NORETURN.
3885
3886 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
3887
3888         * breakpoint.c (print_solib_event, check_status_catch_solib):
3889         Remove struct keyword in range-based for loops.
3890         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
3891         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
3892         Likewise.
3893         * linespec.c (find_superclass_methods, search_minsyms_for_name):
3894         Likewise.
3895         * symfile.c (addr_info_make_relative): Likewise.
3896         * thread.c (value_in_thread_stack_temporaries): Likewise.
3897
3898 2018-06-12  Weimin Pan  <weimin.pan@oracle.com>
3899
3900         PR gdb/16841
3901         * valops.c (value_struct_elt_for_reference): Call check_typedef on
3902         aggregate type to get its real type before accessing it.
3903
3904 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
3905
3906         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
3907         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
3908         * coff-pe-read.c (add_pe_forwarded_sym): Replace
3909         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
3910         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
3911         * jit.c (jit_breakpoint_re_set_internal): Likewise.
3912         * printcmd.c (info_address_command): Likewise.
3913
3914 2018-05-29  Tom Tromey  <tom@tromey.com>
3915
3916         * windows-nat.c (handle_exception): Update fall-through comment.
3917
3918 2018-05-29  Tom Tromey  <tom@tromey.com>
3919
3920         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
3921         (struct program_space) <added_solibs>: Now a std::vector.
3922         * breakpoint.c (print_solib_event): Update.
3923         (check_status_catch_solib): Update.
3924         * progspace.c (clear_program_space_solib_cache): Update.
3925         * solib.c (update_solib_list): Update.
3926
3927 2018-05-29  Tom Tromey  <tom@tromey.com>
3928
3929         * python/py-type.c (typy_richcompare): Update.
3930         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
3931         * gdbtypes.h (types_deeply_equal): Return bool.
3932         (types_equal): Likewise.
3933         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
3934         declare VEC.
3935         (check_types_equal): Change worklist to std::vector.  Return
3936         bool.
3937         (struct type_equality_entry): Add constructor.
3938         (compare_maybe_null_strings): Return bool.
3939         (check_types_worklist): Return bool.  Change worklist to
3940         std::vector.
3941         (types_deeply_equal): Use std::vector.
3942         (types_equal): Return bool.
3943         (compare_maybe_null_strings): Simplify.
3944
3945 2018-05-29  Tom Tromey  <tom@tromey.com>
3946
3947         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
3948
3949 2018-05-29  Tom Tromey  <tom@tromey.com>
3950
3951         * objc-lang.h: Don't include cp-support.h.
3952         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
3953         declare VEC.
3954
3955 2018-05-27  Tom Tromey  <tom@tromey.com>
3956
3957         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
3958
3959 2018-05-25  Tom Tromey  <tom@tromey.com>
3960
3961         * value.c (value::location): Initialize.
3962
3963 2018-05-25  Tom Tromey  <tom@tromey.com>
3964
3965         * dbxread.c (init_bincl_list): Remove.
3966         (bincl_list): Now a std::vector.
3967         (bincls_allocated, next_bincl): Remove.
3968         (free_bincl_list, do_free_bincl_list_cleanup)
3969         (make_cleanup_free_bincl_list): Remove.
3970         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
3971         unique_xmalloc_ptr.
3972         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
3973         (struct header_file_location): Add constructor.
3974         (add_bincl_to_list): Remove.
3975
3976 2018-05-25  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui.c (tui_enable): Update.
3979         * mi/mi-interp.c (mi_interp::init): Update.
3980         * interps.h (class interp) <name>: New method.
3981         <m_name>: Rename from name.
3982         (~scoped_restore_interp): Update.
3983         * interps.c (interp::interp): Update.
3984         (interp_add, interp_set, interp_lookup_existing)
3985         (current_interp_named_p): Update.
3986
3987 2018-05-25  Tom Tromey  <tom@tromey.com>
3988
3989         * interps.c (interp_name): Remove.
3990         * mi/mi-interp.c (mi_interp::init): Update.
3991         * interps.h (interp_name): Remove.
3992         (~scoped_restore_interp): Update.
3993         * tui/tui.c (tui_enable): Update.
3994
3995 2018-05-25  Tom Tromey  <tom@tromey.com>
3996
3997         * utils.c (fputs_maybe_filtered): Update.
3998         * linespec.c (decode_line_full): Update.
3999         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
4000         (mi_print_breakpoint_for_event, mi_solib_loaded)
4001         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
4002         (mi_user_selected_context_changed): Update.
4003         * mi/mi-main.c (mi_execute_command): Update.
4004         * cli/cli-script.c (execute_control_command): Update.
4005         * python/python.c (execute_gdb_command): Update.
4006         * solib.c (info_sharedlibrary_command): Update.
4007         * interps.c (interp_ui_out): Remove.
4008         * interps.h (interp_ui_out): Remove.
4009
4010 2018-05-25  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
4013         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
4014         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
4015
4016 2018-05-25  Tom Tromey  <tom@tromey.com>
4017
4018         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
4019         * interps.c (interp_exec): Use scoped_restore.
4020
4021 2018-05-25  Tom Tromey  <tom@tromey.com>
4022
4023         * remote.c (remote_target::remote_file_get): Use
4024         gdb::byte_vector.
4025         (remote_target::remote_file_put): Likewise.
4026
4027 2018-05-25  Tom Tromey  <tom@tromey.com>
4028
4029         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
4030         a std::string.
4031         (get_pe_section_index, add_pe_exported_sym): Update.
4032         (read_pe_exported_syms): Use gdb::def_vector.
4033
4034 2018-05-25  Tom Tromey  <tom@tromey.com>
4035
4036         * frame.c (remove_prev_frame): Remove.
4037         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
4038
4039 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
4040
4041         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
4042         Remove prototypes.
4043         * mips-linux-nat.c (supply_fpregset): Always call
4044         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
4045         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
4046         `mips_fill_fpregset'.
4047         * mips-linux-tdep.c (mips_supply_fpregset)
4048         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
4049         (mips_fill_fpregset_wrapper): Remove functions.
4050         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
4051         (mips_linux_fpregset): Remove variable.
4052         (mips_linux_iterate_over_regset_sections): Use
4053         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
4054         (mips_linux_o32_sigframe_init): Remove comment.
4055
4056 2018-05-25  Pedro Alves  <palves@redhat.com>
4057
4058         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
4059         (struct readahead_cache, struct packet_reg, struct
4060         remote_arch_state, class remote_state): Move higher up in the
4061         file.
4062         (remote_target::m_remote_state): Now an object instead of a pointer.
4063         (remote_target::get_remote_state): Adjust.
4064
4065 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * stack.c (select_and_print_frame): Delete.
4068         (struct function_bounds): Move struct within function.
4069         (func_command): Most content moved into new function
4070         find_frame_for_function, use new function, print result, add
4071         function comment.
4072         (find_frame_for_function): New function, now returns a result.
4073
4074 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4075
4076         * stack.c (iterate_over_block_arg_vars): Fix comment.
4077         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
4078
4079 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4080
4081         PR gdb/23203
4082         * frame.c
4083         (scoped_restore_selected_frame::scoped_restore_selected_frame):
4084         Define.
4085         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
4086         Define.
4087         * frame.h (class scoped_restore_selected_frame): New class.
4088         * stack.c (print_frame_local_vars): Remove catching and rethrowing
4089         of any exception, use scoped_restore_selected_frame to restore the
4090         frame instead.
4091
4092 2018-05-24  Pedro Alves  <palves@redhat.com>
4093
4094         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
4095         override.
4096
4097 2018-05-23  Tom Tromey  <tom@tromey.com>
4098
4099         * complaints.c (struct complaints): Remove.
4100         (symfile_complaint_book): Remove.
4101         (series): New global.
4102         (complaint_internal): Update.
4103         (clear_complaints): Update.
4104
4105 2018-05-23  Tom Tromey  <tom@tromey.com>
4106
4107         * complaints.c (counters): New global.
4108         (struct complain): Remove.
4109         (struct complaints) <root>: Remove.
4110         (complaint_sentinel): Remove.
4111         (symfile_complaint_book): Update.
4112         (find_complaint) Remove.
4113         (complaint_internal, clear_complaints): Update.
4114
4115 2018-05-23  Tom Tromey  <tom@tromey.com>
4116
4117         * complaints.c (struct complain) <file, line>: Remove.
4118         (find_complaint): Remove file, line parameters.
4119         (complaint_internal): Update.
4120
4121 2018-05-23  Tom Tromey  <tom@tromey.com>
4122
4123         * complaints.c (vcomplaint): Remove.
4124         (complaint_internal) Merge in contents of vcomplaint.
4125
4126 2018-05-23  Tom Tromey  <tom@tromey.com>
4127
4128         * complaints.c (struct complaints) <explanation>: Remove.
4129         (symfile_explanations): Remove.
4130         (symfile_complaint_book): Update.
4131         (vcomplaint): Update.
4132         (struct explanation): Remove.
4133
4134 2018-05-23  Tom Tromey  <tom@tromey.com>
4135
4136         * complaints.c (symfile_complaints): Remove.
4137         (complaint_internal): Remove "complaints" parameter.
4138         (clear_complaints, vcomplaint): Remove "c" parameter.
4139         (get_complaints): Remove.
4140         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
4141         (dwarf2_debug_line_missing_file_complaint)
4142         (dwarf2_debug_line_missing_end_sequence_complaint)
4143         (dwarf2_complex_location_expr_complaint)
4144         (dwarf2_const_value_length_mismatch_complaint)
4145         (dwarf2_section_buffer_overflow_complaint)
4146         (dwarf2_macro_malformed_definition_complaint)
4147         (dwarf2_invalid_attrib_class_complaint)
4148         (create_addrmap_from_index, dw2_symtab_iter_next)
4149         (dw2_expand_marked_cus)
4150         (dw2_debug_names_iterator::find_vec_in_debug_names)
4151         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
4152         (create_debug_type_hash_table, init_cutu_and_read_dies)
4153         (partial_die_parent_scope, add_partial_enumeration)
4154         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
4155         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
4156         (read_import_statement, read_file_scope, create_dwo_cu_reader)
4157         (create_cus_hash_table, create_dwp_hash_table)
4158         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
4159         (dwarf2_rnglists_process, dwarf2_ranges_process)
4160         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
4161         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
4162         (handle_struct_member_die, process_structure_scope)
4163         (read_array_type, read_common_block, read_module_type)
4164         (read_tag_pointer_type, read_typedef, read_base_type)
4165         (read_subrange_type, load_partial_dies, partial_die_info::read)
4166         (partial_die_info::read, partial_die_info::read)
4167         (partial_die_info::read, read_checked_initial_length_and_offset)
4168         (dwarf2_string_attr, read_formatted_entries)
4169         (dwarf_decode_line_header)
4170         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
4171         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
4172         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
4173         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
4174         (get_signatured_type, get_DW_AT_signature_type)
4175         (decode_locdesc, file_file_name, consume_improper_spaces)
4176         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
4177         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4178         (dwarf2_symbol_mark_computed, set_die_type)
4179         (read_attribute_value): Update.
4180         * stap-probe.c (handle_stap_probe, get_stap_base_address):
4181         Update.
4182         * dbxread.c (unknown_symtype_complaint)
4183         (lbrac_mismatch_complaint, repeated_header_complaint)
4184         (set_namestring, function_outside_compilation_unit_complaint)
4185         (read_dbx_symtab, process_one_symbol): Update.
4186         * gdbtypes.c (stub_noname_complaint): Update.
4187         * windows-nat.c (handle_unload_dll): Update.
4188         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
4189         (decode_base_type): Update.
4190         * xcoffread.c (bf_notfound_complaint, ef_complaint)
4191         (eb_complaint, record_include_begin, record_include_end)
4192         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
4193         (process_xcoff_symbol, read_symbol)
4194         (function_outside_compilation_unit_complaint)
4195         (scan_xcoff_symtab): Update.
4196         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
4197         * buildsym.c (finish_block_internal, make_blockvector)
4198         (end_symtab_get_static_block, augment_type_symtab): Update.
4199         * dtrace-probe.c (dtrace_process_dof)
4200         (dtrace_static_probe_ops::get_probes): Update.
4201         * complaints.h (struct complaint): Don't declare.
4202         (symfile_complaints): Remove.
4203         (complaint_internal): Remove "complaints" parameter.
4204         (complaint): Likewise.
4205         (clear_complaints): Likewise.
4206         * symfile.c (syms_from_objfile_1, finish_new_objfile)
4207         (reread_symbols): Update.
4208         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
4209         (dwarf2_frame_cache, decode_frame_entry): Update.
4210         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
4211         * objc-lang.c (lookup_objc_class, lookup_child_selector)
4212         (info_selectors_command): Update.
4213         * macrotab.c (macro_include, check_for_redefinition)
4214         (macro_undef): Update.
4215         * objfiles.c (filter_overlapping_sections): Update.
4216         * stabsread.c (invalid_cpp_abbrev_complaint)
4217         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
4218         (define_symbol, error_type, read_type, rs6000_builtin_type)
4219         (stabs_method_name_from_physname, read_member_functions)
4220         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
4221         (attach_fields_to_type, complain_about_struct_wipeout)
4222         (read_range_type, read_args, common_block_start)
4223         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
4224         Update.
4225         * mdebugread.c (index_complaint, unknown_ext_complaint)
4226         (basic_type_complaint, bad_tag_guess_complaint)
4227         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
4228         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
4229         (parse_procedure, parse_lines)
4230         (function_outside_compilation_unit_complaint)
4231         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
4232         (bad_tag_guess_complaint, reg_value_complaint): Update.
4233         * cp-support.c (demangled_name_complaint): Update.
4234         * macroscope.c (sal_macro_scope): Update.
4235         * dwarf-index-write.c (class debug_names): Update.
4236
4237 2018-05-23  Tom Tromey  <tom@tromey.com>
4238
4239         * complaints.c (clear_complaints): Remove "noisy" parameter.
4240         * complaints.h (clear_complaints): Update.
4241         * symfile.c (syms_from_objfile_1, finish_new_objfile)
4242         (reread_symbols): Update.
4243
4244 2018-05-23  Tom Tromey  <tom@tromey.com>
4245
4246         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
4247         SUBSEQUENT_MESSAGE.
4248         (vcomplaint, clear_complaints): Update.
4249         (symfile_explanations): Remove some messages.
4250
4251 2018-05-23  Tom Tromey  <tom@tromey.com>
4252
4253         * complaints.c (internal_complaint): Remove.
4254         * complaints.h (internal_complaint): Remove.
4255
4256 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
4257
4258         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
4259
4260 2018-05-22  Pedro Alves  <palves@redhat.com>
4261
4262         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
4263         (remote_fileio_badfd, remote_fileio_return_errno)
4264         (remote_fileio_return_success, remote_fileio_func_open)
4265         (remote_fileio_func_open, remote_fileio_func_close)
4266         (remote_fileio_func_read, remote_fileio_func_write)
4267         (remote_fileio_func_lseek, remote_fileio_func_rename)
4268         (remote_fileio_func_unlink, remote_fileio_func_stat)
4269         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
4270         (remote_fileio_func_isatty, remote_fileio_func_system): Add
4271         remote_target parameter.
4272         (remote_fio_func_map) <func>: Add remote_target parameter.
4273         (do_remote_fileio_request, remote_fileio_request):
4274         * remote-fileio.h (remote_fileio_request):
4275         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
4276         remote_target parameter.
4277         (remote_notif_process, handle_notification): Adjust to pass down
4278         the remote.
4279         (remote_notif_state_allocate): Add remote_target parameter.  Save
4280         it.
4281         * remote-notif.h (struct remote_target): Forward declare.
4282         (struct notif_client) <parse, ack, can_get_pending_events>: Add
4283         remote_target parameter.
4284         (struct remote_notif_state) <remote>: New field.
4285         (remote_notif_ack, remote_notif_parse): Add remote_target
4286         parameter.
4287         (remote_notif_state_allocate, remote_notif_state_allocate): Add
4288         remote_target parameter.
4289         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
4290         (threads_listing_context, rmt_thread_action, protocol_feature)
4291         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
4292         (packet_result, struct threads_listing_context, remote_state):
4293         Move definitions and declarations higher up.
4294         (remote_target) <~remote_target>: Declare.
4295         (remote_download_command_source, remote_file_put, remote_file_get)
4296         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
4297         (remote_hostio_pread_vFile, remote_hostio_send_command)
4298         (remote_hostio_set_filesystem, remote_hostio_open)
4299         (remote_hostio_close, remote_hostio_unlink, remote_state)
4300         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
4301         (get_memory_write_packet_size, get_memory_read_packet_size)
4302         (append_pending_thread_resumptions, remote_detach_1)
4303         (append_resumption, remote_resume_with_vcont)
4304         (add_current_inferior_and_thread, wait_ns, wait_as)
4305         (process_stop_reply, remote_notice_new_inferior)
4306         (process_initial_stop_replies, remote_add_thread)
4307         (btrace_sync_conf, remote_btrace_maybe_reopen)
4308         (remove_new_fork_children, kill_new_fork_children)
4309         (discard_pending_stop_replies, stop_reply_queue_length)
4310         (check_pending_events_prevent_wildcard_vcont)
4311         (discard_pending_stop_replies_in_queue, stop_reply)
4312         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
4313         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
4314         (remote_interrupt_as, remote_interrupt_ns)
4315         (remote_get_noisy_reply, remote_query_attached)
4316         (remote_add_inferior, remote_current_thread, get_current_thread)
4317         (set_thread, set_general_thread, set_continue_thread)
4318         (set_general_process, write_ptid)
4319         (remote_unpack_thread_info_response, remote_get_threadinfo)
4320         (parse_threadlist_response, remote_get_threadlist)
4321         (remote_threadlist_iterator, remote_get_threads_with_ql)
4322         (remote_get_threads_with_qxfer)
4323         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
4324         (get_offsets, remote_check_symbols, remote_supported_packet)
4325         (remote_query_supported, remote_packet_size)
4326         (remote_serial_quit_handler, remote_detach_pid)
4327         (remote_vcont_probe, remote_resume_with_hc)
4328         (send_interrupt_sequence, interrupt_query)
4329         (remote_notif_get_pending_events, fetch_register_using_p)
4330         (send_g_packet, process_g_packet, fetch_registers_using_g)
4331         (store_register_using_P, store_registers_using_G)
4332         (set_remote_traceframe, check_binary_download)
4333         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
4334         (remote_xfer_live_readonly_partial, remote_read_bytes)
4335         (remote_send_printf, remote_flash_write, readchar)
4336         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
4337         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
4338         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
4339         (extended_remote_disable_randomization, extended_remote_run)
4340         (send_environment_packet, extended_remote_environment_support)
4341         (extended_remote_set_inferior_cwd, remote_write_qxfer)
4342         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
4343         (packet_command): Now methods of ...
4344         (remote_target): ... this class.
4345         (m_remote_state) <remote_target>: New field.
4346         (struct remote_state) <stop_reply_queue,
4347         remote_async_inferior_event_token, wait_forever_enabled_p>: New
4348         fields.
4349         (remote_state::remote_state): Allocate stop_reply_queue.
4350         (remote_state): Delete global.
4351         (get_remote_state_raw): Delete.
4352         (remote_target::get_remote_state): Allocate m_remote_state on
4353         demand.
4354         (get_current_remote_target): New.
4355         (remote_ops, extended_remote_ops): Delete.
4356         (wait_forever_enabled_p, remote_async_inferior_event_token):
4357         Delete, moved to struct remote_state.
4358         (remote_target::close): Delete self.  Destruction bits split to
4359         ...
4360         (remote_target::~remote_target): ... this.
4361         (show_memory_packet_size): Adjust to use
4362         get_current_remote_target.
4363         (struct protocol_feature) <func>: Add remote_target parameter.
4364         All callers adjusted.
4365         (curr_quit_handler_target): New.
4366         (remote_serial_quit_handler): Reimplement.
4367         (remote_target::open_1): Adjust to use get_current_remote_target.
4368         Heap-allocate remote_target/extended_remote_target instances.
4369         (vcont_builder::vcont_builder): Add remote_target parameter, and
4370         save it in m_remote.  All callers adjusted.
4371         (vcont_builder::m_remote): New field.
4372         (vcont_builder::restart, vcont_builder::flush)
4373         (vcont_builder::push_action): Use it.
4374         (remote_target::commit_resume): Use it.
4375         (struct queue_iter_param) <remote>: New field.
4376         (remote_target::remove_new_fork_children): Fill in 'remote' field.
4377         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
4378         (check_pending_event_prevents_wildcard_vcont_callback)
4379         (remote_target::check_pending_events_prevent_wildcard_vcont)
4380         (remote_target::discard_pending_stop_replies)
4381         (remote_target::discard_pending_stop_replies_in_queue)
4382         (remote_target::remote_notif_remove_queued_reply): Fill in
4383         'remote' field.
4384         (remote_notif_get_pending_events): New.
4385         (remote_target::readchar, remote_target::remote_serial_write):
4386         Save/restore curr_quit_handler_target.
4387         (putpkt): New.
4388         (kill_new_fork_children): Fill in 'remote' field.
4389         (packet_command): Use get_current_remote_target, defer to
4390         remote_target method of same name.
4391         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
4392         parameter, and save it in m_remote.  All callers adjusted.
4393         (scoped_remote_fd::release): Use m_remote.
4394         (scoped_remote_fd::m_remote): New field.
4395         (remote_file_put, remote_file_get, remote_file_delete): Use
4396         get_current_remote_target, defer to remote_target method of same
4397         name.
4398         (remote_btrace_reset): Add remote_state paremeter.  Update all
4399         callers.
4400         (remote_async_inferior_event_handler). Pass down 'data'.
4401         (remote_new_objfile): Use get_current_remote_target.
4402         (remote_target::vcont_r_supported): New.
4403         (set_range_stepping): Use get_current_remote_target and
4404         remote_target::vcont_r_supported.
4405         (_initialize_remote): Don't allocate 'remote_state' and
4406         'stop_reply_queue' globals.
4407         * remote.h (struct remote_target): Forward declare.
4408         (getpkt, putpkt, remote_notif_get_pending_events): Add
4409         'remote_target' parameter.
4410
4411 2018-05-22  Pedro Alves  <palves@redhat.com>
4412
4413         * remote.c (vcont_builder): Now a class.  Make all data members
4414         private.
4415         (vcont_builder) <vcont_builder, restart, flush, push_action>:
4416         Declare methods.
4417         (vcont_builder_restart): Rename to ...
4418         (vcont_builder::restart): ... this.
4419         (vcont_builder_flush): Rename to ...
4420         (vcont_builder::flush): ... this.
4421         (vcont_builder_push_action): Rename to ...
4422         (vcont_builder::push_action): ... this.
4423         (remote_target::commit_resume): Adjust.
4424
4425 2018-05-22  Pedro Alves  <palves@redhat.com>
4426
4427         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
4428         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
4429         (get_fixed_memory_packet_size): New.
4430         (get_memory_packet_size): Use it.
4431         (set_memory_packet_size): Don't override the config size with
4432         DEFAULT_MAX_MEMORY_PACKET_SIZE.
4433         (show_memory_packet_size): Use get_fixed_memory_packet_size.
4434         Don't refer to get_memory_packet_size if not connected to a remote
4435         target.  Show "(default)" if configured size is 0.
4436
4437 2018-05-22  Pedro Alves  <palves@redhat.com>
4438
4439         * remote.c (remote_target::mourn_inferior): Move
4440         discard_pending_stop_replies call here from ...
4441         (_initialize_remote): ... here.
4442
4443 2018-05-22  Pedro Alves  <palves@redhat.com>
4444
4445         * remote.c (compare_section_command): Remove set_general_process
4446         call.
4447
4448 2018-05-22  Pedro Alves  <palves@redhat.com>
4449
4450         * remote.c (struct packet_reg, struct remote_arch_state):
4451         Move higher up in the file.
4452         (remote_state) <m_arch_states>: Store remote_arch_state values
4453         instead of remote_arch_state pointers.
4454         (remote_state::get_remote_arch_state): Adjust.
4455
4456 2018-05-22  Pedro Alves  <palves@redhat.com>
4457
4458         * remote.c: Include <unordered_map>.
4459         (remote_state): Now a class.
4460         (remote_state) <get_remote_arch_state>: Declare method.
4461         <get_remote_arch_state>: New field.
4462         (remote_arch_state) <remote_arch_state>: Declare ctor.
4463         <regs>: Now a unique_ptr.
4464         (remote_gdbarch_data_handle): Delete.
4465         (get_remote_arch_state): Delete.
4466         (remote_state::get_remote_arch_state): New.
4467         (get_remote_state): Adjust to call remote_state's
4468         get_remote_arch_state method.
4469         (init_remote_state): Delete, bits factored out to ...
4470         (remote_arch_state::remote_arch_state): ... this new method.
4471         (get_remote_packet_size, get_memory_packet_size)
4472         (process_g_packet, remote_target::fetch_registers)
4473         (remote_target::prepare_to_store, store_registers_using_G)
4474         (remote_target::store_registers, remote_target::get_trace_status):
4475         Adjust to call remote_state's method.
4476         (_initialize_remote): Remove reference to
4477         remote_gdbarch_data_handle.
4478
4479 2018-05-22  Pedro Alves  <palves@redhat.com>
4480
4481         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
4482         pread>: New method declarations.
4483         (remote_target::open_1): Adjust.
4484         (readahead_cache_invalidate): Rename to ...
4485         (readahead_cache::invalidate): ... this, and adjust to be a class
4486         method.
4487         (readahead_cache_invalidate_fd): Rename to ...
4488         (readahead_cache::invalidate_fd): ... this, and adjust to be a
4489         class method.
4490         (remote_hostio_pwrite): Adjust.
4491         (remote_hostio_pread_from_cache): Rename to ...
4492         (readahead_cache::pread): ... this, and adjust to be a class
4493         method.
4494         (remote_hostio_close): Adjust.
4495
4496 2018-05-22  Pedro Alves  <palves@redhat.com>
4497
4498         * remote.c (remote_hostio_close_cleanup): Delete.
4499         (class scoped_remote_fd): New.
4500         (remote_file_put, remote_file_get): Use it.
4501
4502 2018-05-22  Pedro Alves  <palves@redhat.com>
4503
4504         (struct vCont_action_support): Use bool and initialize all fields.
4505         (struct readahead_cache): Initialize all fields.
4506         (remote_state): Use bool and initialize all fields.
4507         (remote_state::remote_state, remote_state::~remote_state): New.
4508         (new_remote_state): Delete.
4509         (_initialize_remote): Use new to allocate remote_state.
4510
4511 2018-05-22  Pedro Alves  <palves@redhat.com>
4512             張俊芝  <zjz@zjz.name>
4513
4514         PR gdb/22973
4515         * c-exp.y: Include "c-support.h".
4516         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
4517         of tolower.  Use c_ident_is_alpha to scan names.
4518         * c-lang.c: Include "c-support.h".
4519         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
4520         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
4521         * c-support.h: New file, with bits factored out from ...
4522         * cp-name-parser.y: ... this file.
4523         Include "c-support.h".
4524         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
4525         c-support.h and renamed.
4526         (symbol_end, yylex): Adjust.
4527
4528 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4529
4530         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
4531         parameter type to CORE_ADDR.
4532         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
4533         parameter type in declaration to CORE_ADDR.
4534         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
4535         target_auxv_search to get AT_HWCAP and use the result to get the
4536         target description.
4537         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
4538         to CORE_ADDR. Remove the cast of the return value to unsigned
4539         long. Fix error predicate of target_auxv_search.
4540         (ppc_linux_nat_target::read_description): Change the type of the
4541         hwcap variable to CORE_ADDR.
4542
4543 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4544
4545         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
4546         if the size of fpscr is larger than 32 bits.
4547
4548 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4549
4550         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
4551         (ppc32_linux_vsxregmap): New global.
4552         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
4553         regcache_supply_regset, and regcache_collect_regset.
4554         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
4555         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
4556         (fetch_vsx_register, store_vsx_register): Remove.
4557         (fetch_vsx_registers): Add regno parameter. Get regset using
4558         ppc_linux_vsxregset. Use regset to supply registers.
4559         (store_vsx_registers): Add regno parameter. Get regset using
4560         ppc_linux_vsxregset. Use regset to collect registers.
4561         (fetch_register): Call fetch_vsx_registers instead of
4562         fetch_vsx_register.
4563         (store_register): Call store_vsx_registers instead of
4564         store_vsx_register.
4565         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
4566         new regno parameter.
4567         (store_ppc_registers): Call store_vsx_registers with -1 for the
4568         new regno parameter.
4569         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
4570         (ppc_collect_vsxregset): Remove.
4571
4572 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4573
4574         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
4575         offset fields.
4576         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
4577         for vector register offset fields.
4578         (ppc64_fbsd_reg_offsets): Likewise.
4579         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
4580         to vector register offset fields.
4581         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
4582         to vector register offset fields.
4583         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
4584         vector register offset fields.
4585         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
4586         initializers for vector register offset fields.
4587         (rs6000_aix64_reg_offsets): Likewise.
4588         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
4589         (ppc_supply_vrregset): Remove.
4590         (ppc_collect_vrregset): Remove.
4591         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
4592         (ppc_linux_vrregset) : New function.
4593         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
4594         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
4595         (ppc32_linux_vrregset): Remove.
4596         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
4597         and use result instead of ppc32_linux_vrregset.
4598         (ppc32_linux_reg_offsets): Remove initializers for vector register
4599         offset fields.
4600         (ppc64_linux_reg_offsets): Likewise.
4601         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
4602         * ppc-linux-nat.c: Include regset.h.
4603         (gdb_vrregset_t): Adjust comment to account for little-endian
4604         mode.
4605         (supply_vrregset, fill_vrregset): Remove.
4606         (fetch_altivec_register, store_altivec_register): Remove.
4607         (fetch_altivec_registers): Add regno parameter. Get regset using
4608         ppc_linux_vrregset. Use regset to supply registers.
4609         (store_altivec_registers): Add regno parameter. Get regset using
4610         ppc_linux_vrregset. Use regset to collect registers.
4611         (fetch_register): Call fetch_altivec_registers instead of
4612         fetch_altivec_register.
4613         (store_register): Call store_altivec_registers instead of
4614         store_altivec_register.
4615         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
4616         the new regno parameter.
4617         (store_ppc_registers): Call store_altivec_registers with -1 for
4618         the new regno parameter.
4619
4620 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4621
4622         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
4623         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
4624         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
4625         (gdb_vrregset_t): Change array type size to
4626         PPC_LINUX_SIZEOF_VRREGSET.
4627         (gdb_vsxregset_t): Change array type size to
4628         PPC_LINUX_SIZEOF_VSXREGSET.
4629         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
4630         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
4631         PPC_LINUX_SIZEOF_VSXREGSET.
4632
4633 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4634
4635         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
4636         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
4637         nat/ppc-linux.c.
4638         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
4639         ppc_linux_target_wordsize with tid.
4640         (ppc_linux_nat_target::read_description): Call ppc_linux_target
4641         wordsize with tid.
4642         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
4643         (ppc64_64bit_inferior_p): Add static and inline specifiers.
4644         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
4645         tid parameter. Remove static specifier.
4646         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
4647         (ppc_linux_target_wordsize): New declaration.
4648
4649 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4650
4651         * arch/ppc-linux-common.c: New file.
4652         * arch/ppc-linux-common.h: New file.
4653         * arch/ppc-linux-tdesc.h: New file.
4654         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
4655         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
4656         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
4657         arch/ppc-linux-tdesc.h.
4658         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
4659         arch/ppc-linux-tdesc.h.
4660         (ppc_linux_nat_target::read_description): Remove target
4661         description matching code. Fill a ppc_linux_features struct and
4662         call ppc_linux_match_description with it. Move comment about ISA
4663         2.05 to ppc-linux-common.c.
4664         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
4665         arch/ppc-linux-tdesc.h.
4666         (ppc_linux_core_read_description): Remove target description
4667         matching code. Fill a ppc_linux_features struct and call
4668         ppc_linux_match_description with it.
4669         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
4670         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
4671         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
4672         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
4673         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
4674         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
4675         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
4676         (tdesc_powerpc_e500l): Remove.
4677
4678 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
4679
4680         * ada-lang.c (catch_assert_command): Pass empty string instead
4681         of NULL for excep_string argument.
4682
4683 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
4684
4685         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
4686         the width of the requested register exceeds the width of the
4687         `ptrace' data type.
4688
4689 2018-05-21  Tom Tromey  <tom@tromey.com>
4690
4691         * printcmd.c (output_command): Remove.
4692         (output_command_const): Rename to output_command.
4693         * valprint.h (output_command): Rename from output_command_const.
4694         * tracepoint.c (trace_dump_actions): Call output_command.
4695
4696 2018-05-21  Tom Tromey  <tom@tromey.com>
4697
4698         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
4699         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
4700         * ada-lang.h (create_ada_exception_catchpoint): Update.
4701         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
4702         std::string.
4703         (create_excep_cond_exprs, ~ada_catchpoint)
4704         (should_stop_exception, print_one_exception)
4705         (print_mention_exception, print_recreate_exception): Update.
4706         (ada_get_next_arg): Remove.
4707         (catch_ada_exception_command_split): Use std::string.  Change type
4708         of "excep_string", "cond_string".
4709         (catch_ada_exception_command): Update.
4710         (create_ada_exception_catchpoint): Change type of excep_string.
4711         (ada_exception_sal): Remove excep_string parameter.
4712         (~ada_catchpoint): Remove.
4713
4714 2018-05-21  Tom Tromey  <tom@tromey.com>
4715
4716         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
4717         cleanup.
4718
4719 2018-05-21  Tom Tromey  <tom@tromey.com>
4720
4721         * ada-lang.c (ada_exception_message_1, ada_exception_message):
4722         Return unique_xmalloc_ptr.
4723         (print_it_exception): Update.
4724
4725 2018-05-21  Tom Tromey  <tom@tromey.com>
4726
4727         * tracepoint.c (trace_dump_actions): Use std::string.
4728
4729 2018-05-21  Tom Tromey  <tom@tromey.com>
4730
4731         * symfile.c (reread_symbols): Use std::string for original_name.
4732
4733 2018-05-21  Tom Tromey  <tom@tromey.com>
4734
4735         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
4736         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
4737         constructor.
4738
4739 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
4740
4741         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
4742         instance to...
4743         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
4744         * objfiles.c (get_objfile_bfd_data): Allocate
4745         objfile_per_bfd_storage with obstack_new when allocating on
4746         obstack.
4747
4748 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
4749
4750         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
4751         OBSTACK_ZALLOC.
4752         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
4753         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
4754         * mdebugread.c (mdebug_build_psymtabs): Likewise.
4755         (add_pending): Likewise.
4756         (parse_symbol): Likewise.
4757         (parse_partial_symbols): Likewise.
4758         (psymtab_to_symtab_1): Likewise.
4759         (new_psymtab): Likewise.
4760         (elfmdebug_build_psymtabs): Likewise.
4761         * minsyms.c (terminate_minimal_symbol_table): Likewise.
4762         * objfiles.c (get_objfile_bfd_data): Likewise.
4763         (objfile_register_static_link): Likewise.
4764         * psymtab.c (allocate_psymtab): Likewise.
4765         * stabsread.c (read_member_functions): Likewise.
4766         * xcoffread.c (xcoff_end_psymtab): Likewise.
4767
4768 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
4769
4770         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
4771         compiler supports std::is_trivially_constructible.
4772         * common/poison.h: Include obstack.h.
4773         (IsMallocable): Define to is_trivially_constructible if the
4774         compiler supports it, define to true_type otherwise.
4775         (xobnew): New.
4776         (XOBNEW): Redefine.
4777         (xobnewvec): New.
4778         (XOBNEWVEC): Redefine.
4779         * gdb_obstack.h (obstack_zalloc): New.
4780         (OBSTACK_ZALLOC): Redefine.
4781         (obstack_calloc): New.
4782         (OBSTACK_CALLOC): Redefine.
4783         (obstack_new): New.
4784         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
4785         (gdbarch_obstack): New declaration in gdbarch.h, definition in
4786         gdbarch.c.
4787         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
4788         obstack_calloc/obstack_zalloc.
4789         (gdbarch_obstack_zalloc): Remove.
4790         * target-descriptions.c (tdesc_data_init): Use obstack_new.
4791
4792 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4793
4794         * stack.c (backtrace_command_1): Remove useless variable int i.
4795
4796 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4797
4798         * stack.c (print_frame_info): Fix comment.
4799
4800 2018-05-18  Tom Tromey  <tom@tromey.com>
4801
4802         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
4803         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
4804         (~dwarf2_per_objfile): Update
4805         (dwarf2_get_dwz_file): Use new.
4806         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
4807         unique_ptr.
4808
4809 2018-05-18  Tom Tromey  <tom@tromey.com>
4810
4811         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
4812         unique_ptr.
4813         * dwarf2read.c (struct dwp_file): Add constructor and
4814         initializers.
4815         (open_and_init_dwp_file): Return a unique_ptr.
4816         (dwarf2_per_objfile, create_dwp_hash_table)
4817         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
4818         (lookup_dwo_unit_in_dwp): Update.
4819         (open_and_init_dwp_file, get_dwp_file): Update.
4820
4821 2018-05-18  Tom Tromey  <tom@tromey.com>
4822
4823         * dwarf2read.c (dwarf2_per_objfile): Update.
4824         (struct mapped_index): Add initializers.
4825         (dwarf2_read_index): Use new.
4826         (dw2_symtab_iter_init): Update.
4827         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
4828         unique_ptr.
4829
4830 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
4831
4832         * dwarf2read.c (mapped_index) <total_size>: Remove.
4833
4834 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
4835
4836         * unittests/format_pieces-selftests.c (test_format_specifier):
4837         Add ARI comments.
4838
4839 2018-05-18  Tom Tromey  <tom@tromey.com>
4840
4841         * c-typeprint.c (maybe_print_hole): New function.
4842         (c_print_type_struct_field_offset): Update.
4843         (c_type_print_base_struct_union): Call maybe_print_hole.
4844
4845 2018-05-17  Keith Seitz  <keiths@redhat.com>
4846
4847         * breakpoint.c (build_bpstat_chain): New function, moved from
4848         bpstat_stop_status.
4849         (bpstat_stop_status): Add optional parameter, `stop_chain'.
4850         If no stop chain is passed, call build_bpstat_chain to build it.
4851         * breakpoint.h (build_bpstat_chain): Declare.
4852         (bpstat_stop_status): Move documentation here from breakpoint.c.
4853         * infrun.c (handle_signal_stop): Before eliding inlined frames,
4854         build the stop chain and pass it to skip_inline_frames.
4855         Pass this stop chain to bpstat_stop_status.
4856         * inline-frame.c: Include breakpoint.h.
4857         (stopped_by_user_bp_inline_frame): New function.
4858         (skip_inline_frames): Add parameter `stop_chain'.
4859         Move documention to inline-frame.h.
4860         If non-NULL, use stopped_by_user_bp_inline_frame to determine
4861         whether the frame should be elided.
4862         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
4863         Add moved documentation and update for new parameter.
4864
4865 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
4866
4867         PR cli/14975
4868         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4869         unittests/format_pieces-selftests.c.
4870         * common/format.h (format_piece) <operator==>: New.
4871         (format_pieces) <operator[]>: Remove.
4872         * common/format.c (format_pieces::format_pieces): Handle \e.
4873         * unittests/format_pieces-selftests.c: New.
4874
4875 2018-05-17  Tom Tromey  <tom@tromey.com>
4876
4877         PR symtab/23010:
4878         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
4879         (dw2_instantiate_symtab): Add skip_partial parameter.
4880         (dw2_find_last_source_symtab, dw2_map_expand_apply)
4881         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
4882         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
4883         (dw2_expand_symtabs_matching_one)
4884         (dw2_find_pc_sect_compunit_symtab)
4885         (dw2_debug_names_lookup_symbol)
4886         (dw2_debug_names_expand_symtabs_for_function): Update.
4887         (init_cutu_and_read_dies): Add skip_partial parameter.
4888         (process_psymtab_comp_unit, build_type_psymtabs_1)
4889         (process_skeletonless_type_unit, load_partial_comp_unit)
4890         (psymtab_to_symtab_1): Update.
4891         (load_full_comp_unit): Add skip_partial parameter.
4892         (process_imported_unit_die, dwarf2_read_addr_index)
4893         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
4894         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
4895         (read_signatured_type): Update.
4896
4897 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
4898
4899         * value.c (release_value): Remove unused variable.
4900         (record_latest_value): Likewise.
4901         (access_value_history): Likewise.
4902         (preserve_values): Likewise.
4903
4904 2018-05-17  Tom Tromey  <tom@tromey.com>
4905
4906         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
4907         Initialize.
4908
4909 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
4910
4911         PR gdb/22286
4912         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
4913         Also handle registers whose width is not a multiple of
4914         PTRACE_TYPE_RET.
4915         (linux_nat_trad_target::store_register): Likewise.
4916
4917 2018-05-16  Tom Tromey  <tom@tromey.com>
4918
4919         * gdbcore.h (core_bfd): Redefine.
4920         * corelow.c (core_target::close): Update.
4921         (core_target_open): Update.
4922         * progspace.h (struct program_space) <cbfd>: Now a
4923         gdb_bfd_ref_ptr.
4924
4925 2018-05-16  Tom Tromey  <tom@tromey.com>
4926
4927         PR cli/19551:
4928         * symfile-add-flags.h (enum symfile_add_flags)
4929         <SYMFILE_NOT_FILENAME>: New constant.
4930         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
4931         objfile name from BFD.
4932         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
4933         * minidebug.c (find_separate_debug_file_in_section): Put
4934         ".gnu_debugdata" into BFD's file name.
4935
4936 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
4937
4938         * regcache.c (regcache_read_ftype, regcache_write_ftype):
4939         Remove.
4940
4941 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
4942
4943         PR binutils/21446
4944         * aarch64-tdep.c (aarch64_analyze_prologue,
4945         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
4946         Indicate not interested in errors.
4947
4948 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
4949
4950         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
4951         Supply the MIPS_ZERO_REGNUM register.
4952
4953 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
4954
4955         * mips-tdep.c (mask_address_var): Make variable static.
4956
4957 2018-05-14  Tom Tromey  <tom@tromey.com>
4958
4959         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
4960
4961 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
4964         FXSAVE_ADDR for the mxcsr register.
4965
4966 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
4967
4968         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
4969
4970 2018-05-11  Pedro Alves  <palves@redhat.com>
4971
4972         * corelow.c (core_target) <core_target>: No longer inline.
4973         Initialize m_core_gdbarch, m_core_vec and build the section table
4974         here.
4975         <~core_target>: New.
4976         <core_gdbarch, get_core_register_section>: New methods.
4977         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
4978         factored out from ...
4979         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
4980         (core_ops): Delete.
4981         (sniff_core_bfd): Add gdbarch parameter.
4982         (core_close): Delete, merged into ...
4983         (core_target::close): ... here.  Delete self.
4984         (core_close_cleanup): Delete.
4985         (core_target_open): Allocate a core_target on the heap.  Use a
4986         unique_ptr instead of a cleanup.  Bits moved into the core_target
4987         ctor.  Adjust to use core_target methods instead of globals.
4988         (get_core_register_section): Rename to ...
4989         (core_target::get_core_register_section): ... this and adjust.
4990         (struct get_core_registers_cb_data): New.
4991         (get_core_registers_cb): Use it.  Use bool.
4992         (core_target::fetch_registers, core_target::files_info)
4993         (core_target::xfer_partial, core_target::read_description)
4994         (core_target::pid_to, core_target::thread_name): Adjust to
4995         reference class fields instead of globals.
4996         * target.h (struct target_ops_deleter, target_ops_up): New.
4997
4998 2018-05-11  Pedro Alves  <palves@redhat.com>
4999
5000         * corefile.c (core_file_command): Move to corelow.c.
5001         * corelow.c (the_core_target): Delete.
5002         (core_file_command): Moved from corefile.c.  Check exec_bfd
5003         instead of the_core_target.  Use target_detach instead of calling
5004         into the_core_target directly.
5005         (maybe_say_no_core_file_now): New.
5006         (core_target::detach): Use it.
5007         (_initialize_corelow): Remove references to the_core_target.
5008         * gdbcore.h (the_core_target): Delete.
5009
5010 2018-05-11  Tom Tromey  <tromey@redhat.com>
5011             Pedro Alves  <palves@redhat.com>
5012
5013         * corefile.c (core_bfd): Remove.
5014         * gdbcore.h (core_bfd): Now a macro.
5015         * progspace.h (struct program_space) <cbfd>: New field.
5016
5017 2018-05-11  Tom Tromey  <tom@tromey.com>
5018
5019         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
5020         gdb::def_vector.
5021
5022 2018-05-10  Tom Tromey  <tom@tromey.com>
5023
5024         * configure: Rebuild.
5025         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
5026
5027 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
5028
5029         PR server/23158:
5030         * regformats/regdat.sh: Adjust script, following the addition
5031         of the new expedite_regs parameter to init_target_desc.
5032
5033 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
5034
5035         PR gdb/23127
5036         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
5037         set_gdbarch_significant_addr_bit.
5038         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
5039         set_gdbarch_significant_addr_bit.
5040         * utils.c (address_significant): Update to sign extend addr.
5041
5042 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
5043
5044         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
5045         (xtensa_linux_init_abi): Limit tdep->num_regs by
5046         tdep->num_nopriv_regs.
5047         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
5048         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
5049         not initialized.
5050
5051 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
5052
5053         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
5054
5055 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
5058         (I387_MXCSR_INIT_VAL): New constant.
5059         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
5060         buffer if it was supplied by the inferior.
5061         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
5062         (i387_xsave_get_clear_bv): New function.
5063         (i387_supply_xsave): Only read x87 control registers from the
5064         xsave buffer if the feature is enabled, and the state will have
5065         been written, otherwise, provide a suitable default.
5066         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
5067         including x87 control registers.  Update control registers if they
5068         have changed from the default value, and mark features as enabled
5069         as required.
5070         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
5071
5072 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
5073
5074         * spu-tdep.c (info_spu_event_command): Fix output formatting.
5075
5076 2018-05-07  Tom Tromey  <tom@tromey.com>
5077
5078         * configure: Rebuild.
5079         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
5080
5081 2018-05-07  Tom Tromey  <tom@tromey.com>
5082
5083         PR tdep/20362:
5084         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
5085         bit.  Use correct value for VDIV.
5086
5087 2018-05-04  Tom Tromey  <tom@tromey.com>
5088
5089         * configure: Rebuild.
5090         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
5091
5092 2018-05-04  Tom Tromey  <tom@tromey.com>
5093
5094         * linux-record.c (record_linux_system_call) <case
5095         RECORD_SYS_RECVFROM>: Add "break".
5096
5097 2018-05-04  Tom Tromey  <tom@tromey.com>
5098
5099         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
5100         Add missing "break".
5101         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
5102         Add missing "break".
5103
5104 2018-05-04  Tom Tromey  <tom@tromey.com>
5105
5106         * rs6000-tdep.c (ppc_process_record_op4)
5107         (ppc_process_record_op63): Add fall-through comment.
5108
5109 2018-05-04  Tom Tromey  <tom@tromey.com>
5110
5111         * i386-tdep.c (i386_process_record): Add fall-through comment.
5112
5113 2018-05-04  Tom Tromey  <tom@tromey.com>
5114
5115         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
5116         comment.
5117
5118 2018-05-04  Tom Tromey  <tom@tromey.com>
5119
5120         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
5121         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
5122         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
5123         comment.
5124         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
5125         comment.
5126         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
5127         comment.
5128
5129 2018-05-04  Tom Tromey  <tom@tromey.com>
5130
5131         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
5132
5133 2018-05-04  Tom Tromey  <tom@tromey.com>
5134
5135         * s390-tdep.c (s390_process_record): Fix fall-through comments.
5136         * xcoffread.c (scan_xcoff_symtab): Move comment later.
5137         * symfile.c (section_is_mapped): Fix fall-through comment.
5138         * stabsread.c (define_symbol, read_member_functions): Fix
5139         fall-through comment.
5140         * s390-linux-tdep.c (s390_process_record): Fix fall-through
5141         comment.
5142         * remote.c (remote_wait_as): Fix fall-through comment.
5143         * p-exp.y (yylex): Fix fall-through comment.
5144         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
5145         comment.
5146         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
5147         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
5148         * jv-exp.y (yylex): Fix fall-through comment.
5149         * go-exp.y (lex_one_token): Fix fall-through comment.
5150         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
5151         fall-through comment.
5152         * f-exp.y (yylex): Fix fall-through comment.
5153         * dwarf2read.c (process_die): Fix fall-through comments.
5154         * dbxread.c (process_one_symbol): Fix fall-through comment.
5155         * d-exp.y (lex_one_token): Fix fall-through comment.
5156         * cp-name-parser.y (yylex): Fix fall-through comment.
5157         * coffread.c (coff_symtab_read): Fix fall-through comment.
5158         * c-exp.y (lex_one_token): Fix fall-through comment.
5159         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
5160         comment.
5161         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
5162         comment.
5163
5164 2018-05-04  Tom Tromey  <tom@tromey.com>
5165
5166         PR python/22730:
5167         * NEWS: Mention gdb.execute change.
5168         * gdbcmd.h (execute_control_command): Don't declare.
5169         * python/python.c (execute_gdb_command): Use read_command_lines_1,
5170         execute_control_commands, execute_control_commands_to_string.
5171         * cli/cli-script.h (execute_control_commands)
5172         (execute_control_commands_to_string): Declare.
5173         (execute_control_command): Add from_tty parameter.
5174         * cli/cli-script.c (execute_control_commands)
5175         (execute_control_commands_to_string): New functions.
5176         (execute_user_command): Use execute_control_commands.
5177         (execute_control_command_1): Add "from_tty" parameter.  Update.
5178         (execute_control_command): Likewise.
5179
5180 2018-05-04  Tom Tromey  <tom@tromey.com>
5181
5182         PR python/22731:
5183         * NEWS: Mention that breakpoint commands are writable.
5184         * python/py-breakpoint.c (bppy_set_commands): New function.
5185         (breakpoint_object_getset) <"commands">: Use it.
5186
5187 2018-05-04  Tom Tromey  <tom@tromey.com>
5188
5189         * tracepoint.c (actions_command): Update.
5190         * mi/mi-cmd-break.c (mi_command_line_array)
5191         (mi_command_line_array_cnt, mi_command_line_array_ptr)
5192         (mi_read_next_line): Remove.
5193         (mi_cmd_break_commands): Update.
5194         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
5195         function_view.
5196         * cli/cli-script.c (get_command_line): Update.
5197         (process_next_line): Use function_view.  Constify.
5198         (recurse_read_control_structure, read_command_lines)
5199         (read_command_lines_1): Change argument types to function_view.
5200         (do_define_command, document_command): Update.
5201         * breakpoint.h (check_tracepoint_command): Don't declare.
5202         * breakpoint.c (check_tracepoint_command): Remove.
5203         (commands_command_1, create_tracepoint_from_upload): Update.
5204
5205 2018-05-04  Tom Tromey  <tom@tromey.com>
5206
5207         PR gdb/11750:
5208         * cli/cli-script.h (enum command_control_type) <define_control>:
5209         New constant.
5210         * cli/cli-script.c (multi_line_command_p): Handle define_control.
5211         (build_command_line, execute_control_command_1)
5212         (process_next_line): Likewise.
5213         (do_define_command): New function, extracted from define_command.
5214         (define_command): Use it.
5215
5216 2018-05-04  Tom Tromey  <tom@tromey.com>
5217
5218         * tracepoint.c (actions_command): Update.
5219         * cli/cli-script.h (read_command_lines): Update.
5220         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
5221         (MAX_TMPBUF): Remove define.
5222         (define_command): Use string_printf.
5223         (document_command): Likewise.
5224         * breakpoint.c (commands_command_1): Update.
5225
5226 2018-05-04  Tom Tromey  <tom@tromey.com>
5227
5228         * top.c (execute_command): Update.
5229         * cli/cli-script.h (print_command_lines): Now varargs.
5230         * cli/cli-script.c (print_command_lines): Now varargs.
5231         (execute_control_command_1) <case while_control, case if_control>:
5232         Update.
5233
5234 2018-05-04  Tom Tromey  <tom@tromey.com>
5235
5236         * tracepoint.c (all_tracepoint_actions): Rename from
5237         all_tracepoint_actions_and_cleanup.  Change return type.
5238         (actions_command, encode_actions_1, encode_actions)
5239         (trace_dump_actions, tdump_command): Update.
5240         * remote.c (remote_download_command_source): Update.
5241         * python/python.c (gdbpy_eval_from_control_command)
5242         (python_command, python_interactive_command): Update.
5243         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
5244         * guile/guile.c (guile_command)
5245         (gdbscm_eval_from_control_command, guile_command): Update.
5246         * compile/compile.c (compile_code_command)
5247         (compile_print_command, compile_to_object): Update.
5248         * cli/cli-script.h (struct command_lines_deleter): New.
5249         (counted_command_line): New typedef.
5250         (struct command_line): Add constructor, destructor.
5251         <body_list>: Remove.
5252         <body_list_0, body_list_1>: New members.
5253         (command_line_up): Remove typedef.
5254         (read_command_lines, read_command_lines_1, get_command_line):
5255         Update.
5256         (copy_command_lines): Don't declare.
5257         * cli/cli-script.c (build_command_line): Use "new".
5258         (get_command_line): Return counted_command_line.
5259         (print_command_lines, execute_user_command)
5260         (execute_control_command_1, while_command, if_command): Update.
5261         (realloc_body_list): Remove.
5262         (process_next_line, recurse_read_control_structure): Update.
5263         (read_command_lines, read_command_lines_1): Return counted_command_line.
5264         (free_command_lines): Use "delete".
5265         (copy_command_lines): Remove.
5266         (define_command, document_command, show_user_1): Update.
5267         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
5268         a counted_command_line.
5269         * breakpoint.h (counted_command_line): Remove typedef.
5270         (breakpoint_set_commands): Update.
5271         * breakpoint.c (check_no_tracepoint_commands)
5272         (validate_commands_for_breakpoint): Update.
5273         (breakpoint_set_commands): Change commands to be a
5274         counted_command_line.
5275         (commands_command_1, update_dprintf_command_list)
5276         (create_tracepoint_from_upload): Update.
5277
5278 2018-05-04  Tom Tromey  <tom@tromey.com>
5279
5280         * cli/cli-decode.h (cmd_list_element): New constructor.
5281         (~cmd_list_element): New destructor.
5282         (struct cmd_list_element): Add initializers.
5283         * cli/cli-decode.c (do_add_cmd): Use "new".
5284         (delete_cmd): Use "delete".
5285
5286 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
5287             Pedro Alves <palves@redhat.com>
5288
5289         PR breakpoints/19806 and support for PR external/20207.
5290         * NEWS: Mention Aarch64 watchpoint improvements.
5291         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
5292         watchpoints and PR external/20207 watchpoints.
5293         * nat/aarch64-linux-hw-point.c
5294         (kernel_supports_any_contiguous_range): New.
5295         (aarch64_watchpoint_offset): New.
5296         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
5297         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
5298         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
5299         (aarch64_align_watchpoint): New parameters aligned_offset_p and
5300         next_addr_orig_p.  Support PR external/20207 watchpoints.
5301         (aarch64_downgrade_regs): New.
5302         (aarch64_dr_state_insert_one_point): New parameters offset and
5303         addr_orig.
5304         (aarch64_dr_state_remove_one_point): Likewise.
5305         (aarch64_handle_breakpoint): Update caller.
5306         (aarch64_handle_aligned_watchpoint): Likewise.
5307         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
5308         aligned_offset.
5309         (aarch64_linux_set_debug_regs): Remove const from state.  Call
5310         aarch64_downgrade_regs.
5311         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
5312         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
5313         (DR_CONTROL_MASK): ... this.
5314         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
5315         (unsigned int aarch64_watchpoint_offset): New prototype.
5316         (aarch64_linux_set_debug_regs): Remove const from state.
5317         * utils.c (align_up, align_down): Move to ...
5318         * common/common-utils.c (align_up, align_down): ... here.
5319         * utils.h (align_up, align_down): Move to ...
5320         * common/common-utils.h (align_up, align_down): ... here.
5321
5322 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
5323
5324         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
5325         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
5326         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
5327         Re-implement to match the ABI as summarized in GCC's
5328         gcc/config/sparc/sparc.c.  All callers updated.
5329         (sparc32_store_arguments): Remove assertion.
5330
5331 2018-05-04  Tom Tromey  <tom@tromey.com>
5332
5333         * printcmd.c: Don't include tui.h.
5334         (decode_format): Use skip_spaces.
5335
5336 2018-05-04  Tom Tromey  <tom@tromey.com>
5337
5338         PR gdb/22619:
5339         * printcmd.c (last_count): New global.
5340         (x_command): Use saved count when repeating.
5341
5342 2018-05-04  Tom Tromey  <tom@tromey.com>
5343
5344         * nto-procfs.c (do_closedir_cleanup): Remove.
5345         (procfs_pidlist): Use gdb_dir_up.
5346         * procfs.c (do_closedir_cleanup): Remove.
5347         (proc_update_threads): Use gdb_dir_up.
5348         * common/filestuff.h (struct gdb_dir_deleter): New.
5349         (gdb_dir_up): New typedef.
5350
5351 2018-05-04  Tom Tromey  <tom@tromey.com>
5352
5353         * ada-lang.c (print_mention_exception): Use std::string.
5354
5355 2018-05-04  Tom Tromey  <tom@tromey.com>
5356
5357         * ada-lang.c (create_excep_cond_exprs): Update.
5358         (ada_exception_catchpoint_cond_string): Use std::string.
5359
5360 2018-05-04  Tom Tromey  <tom@tromey.com>
5361
5362         * ada-lang.c (xget_renaming_scope): Return std::string.
5363         (old_renaming_is_invisible): Update.
5364
5365 2018-05-04  Tom Tromey  <tom@tromey.com>
5366
5367         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
5368         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
5369
5370 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
5371
5372         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
5373
5374 2018-05-04  Tom Tromey  <tom@tromey.com>
5375
5376         * remote.c (remote_query_supported_append): Change type.
5377         (remote_check_symbols): Update.
5378
5379 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
5380
5381         PR gdb/11420
5382         * configure.ac: Prepend libpython.
5383         * python/python-config.py: Likewise.
5384         * configure: Regenerate.
5385
5386 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
5387
5388         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
5389
5390 2018-05-03  Pedro Alves  <palves@redhat.com>
5391
5392         * s390-linux-nat.c
5393         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
5394         override.  Write 'true' instead of '1'.
5395         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
5396         declaration.
5397
5398 2018-05-02  Pedro Alves  <palves@redhat.com>
5399
5400         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
5401         add_inf_child_target.
5402         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
5403         add_inf_child_target.
5404         * aix-thread.c (aix_thread_target_info): New.
5405         (aix_thread_target) <shortname, longname, doc>: Delete.
5406         <info>: New.
5407         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
5408         add_inf_child_target.
5409         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
5410         add_inf_child_target.
5411         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
5412         add_inf_child_target.
5413         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
5414         add_inf_child_target.
5415         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
5416         add_inf_child_target.
5417         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
5418         add_inf_child_target.
5419         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
5420         add_inf_child_target.
5421         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
5422         add_inf_child_target.
5423         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
5424         add_inf_child_target.
5425         * bfd-target.c (target_bfd_target_info): New.
5426         (target_bfd) <shortname, longname, doc>: Delete.
5427         <info>: New.
5428         * bsd-kvm.c (bsd_kvm_target_info): New.
5429         (bsd_kvm_target) <shortname, longname, doc>: Delete.
5430         <info>: New.
5431         (bsd_kvm_target::open): Rename to ...
5432         (bsd_kvm_target_open): ... this.  Adjust.
5433         * bsd-uthread.c (bsd_uthread_target_info): New.
5434         (bsd_uthread_target) <shortname, longname, doc>: Delete.
5435         <info>: New.
5436         * corefile.c (core_file_command): Adjust.
5437         * corelow.c (core_target_info): New.
5438         (core_target) <shortname, longname, doc>: Delete.
5439         <info>: New.
5440         (core_target::open): Rename to ...
5441         (core_target_open): ... this.  Adjust.
5442         * ctf.c (ctf_target_info): New.
5443         (ctf_target) <shortname, longname, doc>: Delete.
5444         <info>: New.
5445         (ctf_target::open): Rename to ...
5446         (ctf_target_open): ... this.
5447         (_initialize_ctf): Adjust.
5448         * exec.c (exec_target_info): New.
5449         (exec_target) <shortname, longname, doc>: Delete.
5450         <info>: New.
5451         (exec_target::open): Rename to ...
5452         (exec_target_open): ... this.
5453         * gdbcore.h (core_target_open): Declare.
5454         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
5455         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
5456         add_inf_child_target.
5457         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
5458         add_inf_child_target.
5459         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
5460         add_inf_child_target.
5461         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
5462         add_inf_child_target.
5463         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
5464         add_inf_child_target.
5465         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
5466         add_inf_child_target.
5467         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
5468         add_inf_child_target.
5469         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
5470         add_inf_child_target.
5471         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
5472         add_inf_child_target.
5473         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
5474         add_inf_child_target.
5475         * inf-child.c (inf_child_target_info): New.
5476         (inf_child_target::info): New.
5477         (inf_child_open_target): Remove 'target' parameter.  Use
5478         get_native_target instead.
5479         (inf_child_target::open): Delete.
5480         (add_inf_child_target): New.
5481         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
5482         Delete.
5483         <info>: New.
5484         (add_inf_child_target): Declare.
5485         (inf_child_open_target): Declare.
5486         * linux-thread-db.c (thread_db_target_info): New.
5487         (thread_db_target) <shortname, longname, doc>: Delete.
5488         <info>: New.
5489         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
5490         add_inf_child_target.
5491         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
5492         add_inf_child_target.
5493         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
5494         add_inf_child_target.
5495         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
5496         add_inf_child_target.
5497         * make-target-delegates (print_class): Adjust.
5498         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
5499         add_inf_child_target.
5500         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
5501         add_inf_child_target.
5502         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
5503         add_inf_child_target.
5504         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
5505         add_inf_child_target.
5506         * nto-procfs.c (nto_native_target_info): New.
5507         (nto_procfs_target_native) <shortname, longname, doc>:
5508         Delete.
5509         <info>: New.
5510         (nto_procfs_target_info): New.
5511         (nto_procfs_target_procfs) <shortname, longname, doc>:
5512         Delete.
5513         <info>: New.
5514         (init_procfs_targets): Adjust.
5515         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
5516         add_inf_child_target.
5517         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
5518         add_inf_child_target.
5519         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
5520         add_inf_child_target.
5521         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
5522         add_inf_child_target.
5523         * ravenscar-thread.c (ravenscar_target_info): New.
5524         (ravenscar_thread_target) <shortname, longname, doc>:
5525         Delete.
5526         <info>: New.
5527         * record-btrace.c (record_btrace_target_info):
5528         (record_btrace_target) <shortname, longname, doc>: Delete.
5529         <info>: New.
5530         (record_btrace_target::open): Rename to ...
5531         (record_btrace_target_open): ... this.  Adjust.
5532         * record-full.c (record_longname, record_doc): New.
5533         (record_full_base_target) <shortname, longname, doc>: Delete.
5534         <info>: New.
5535         (record_full_target_info): New.
5536         (record_full_target): <shortname>: Delete.
5537         <info>: New.
5538         (record_full_core_open_1, record_full_open_1): Update comments.
5539         (record_full_base_target::open): Rename to ...
5540         (record_full_open): ... this.
5541         (cmd_record_full_restore): Update.
5542         (_initialize_record_full): Update.
5543         * remote-sim.c (remote_sim_target_info): New.
5544         (gdbsim_target) <shortname, longname, doc>: Delete.
5545         <info>: New.
5546         (gdbsim_target::open): Rename to ...
5547         (gdbsim_target_open): ... this.
5548         (_initialize_remote_sim): Adjust.
5549         * remote.c (remote_doc): New.
5550         (remote_target_info): New.
5551         (remote_target) <shortname, longname, doc>: Delete.
5552         <info>: New.
5553         (extended_remote_target_info): New.
5554         (extended_remote_target) <shortname, longname, doc>: Delete.
5555         <info>: New.
5556         (remote_target::open_1): Make static.  Adjust.
5557         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
5558         * s390-linux-nat.c (_initialize_s390_nat): Use
5559         add_inf_child_target.
5560         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
5561         add_inf_child_target.
5562         * sol-thread.c (thread_db_target_info): New.
5563         (sol_thread_target) <shortname, longname, doc>: Delete.
5564         <info>: New.
5565         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
5566         add_inf_child_target.
5567         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
5568         add_inf_child_target.
5569         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
5570         add_inf_child_target.
5571         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
5572         add_inf_child_target.
5573         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
5574         add_inf_child_target.
5575         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
5576         add_inf_child_target.
5577         * spu-linux-nat.c (_initialize_spu_nat): Use
5578         add_inf_child_target.
5579         * spu-multiarch.c (spu_multiarch_target_info): New.
5580         (spu_multiarch_target) <shortname, longname, doc>: Delete.
5581         <info>: New.
5582         * target-delegates.c: Regenerate.
5583         * target.c: Include <unordered_map>.
5584         (target_ops_p): Delete.
5585         (DEF_VEC_P(target_ops_p)): Delete.
5586         (target_factories): New.
5587         (test_target_info): New.
5588         (test_target_ops::info): New.
5589         (open_target): Adjust to use target_factories.
5590         (add_target_with_completer): Rename to ...
5591         (add_target): ... this.  Change prototype.  Register target_info
5592         and open callback in target_factories.  Register target_info in
5593         command context instead of target_ops.
5594         (add_target): Delete old implementation.
5595         (add_deprecated_target_alias): Change prototype.  Adjust.
5596         (the_native_target): New.
5597         (set_native_target, get_native_target): New.
5598         (find_default_run_target): Use the_native_target.
5599         (find_attach_target, find_run_target): Simplify.
5600         (target_ops::open): Delete.
5601         (dummy_target_info): New.
5602         (dummy_target::shortname, dummy_target::longname)
5603         (dummy_target::doc): Delete.
5604         (dummy_target::info): New.
5605         (debug_target::shortname, debug_target::longname)
5606         (debug_target::doc): Delete.
5607         (debug_target::info): New.
5608         * target.h (struct target_info): New.
5609         (target_ops::~target_ops): Add comment.
5610         (target_ops::info): New.
5611         (target_ops::shortname, target_ops::longname, target_ops::doc): No
5612         longer virtual.  Implement in terms of target_info.
5613         (set_native_target, get_native_target): Declare.
5614         (target_open_ftype): New.
5615         (add_target, add_target_with_completer)
5616         (add_deprecated_target_alias): Change prototype.
5617         (test_target) <shortname, longname, doc>: Delete.
5618         <info>: New.
5619         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
5620         add_inf_child_target.
5621         * tracefile-tfile.c (tfile_target_info): New.
5622         (tfile_target) <shortname, longname, doc>: Delete.
5623         <info>: New.
5624         (tfile_target::open): Rename to ...
5625         (tfile_target_open): ... this.
5626         (_initialize_tracefile_tfile): Adjust.
5627         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
5628         add_inf_child_target.
5629         * windows-nat.c (_initialize_windows_nat): Use
5630         add_inf_child_target.
5631         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
5632         add_inf_child_target.
5633
5634 2018-05-02  Pedro Alves  <palves@redhat.com>
5635
5636         * linux-nat.h (linux_nat_target) <low_new_thread,
5637         low_delete_thread, low_new_fork, low_forget_process,
5638         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
5639         New virtual methods.
5640         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
5641         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
5642         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
5643         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
5644         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
5645         Delete.
5646         * linux-fork.c (delete_fork): Adjust to call low method.
5647         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
5648         (linux_nat_new_fork, linux_nat_forget_process_hook)
5649         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
5650         (linux_nat_status_is_event):
5651         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
5652         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
5653         to call low method.
5654         (sigtrap_is_event): Rename to ...
5655         (linux_nat_target::low_status_is_event): ... this.
5656         (linux_nat_set_status_is_event): Delete.
5657         (save_stop_reason, linux_nat_wait_1)
5658         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
5659         low methods.
5660         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
5661         (linux_nat_set_new_fork, linux_nat_set_forget_process)
5662         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
5663         (linux_nat_set_prepare_to_resume): Delete.
5664         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
5665         low virtual methods.
5666         * amd64-linux-nat.c: Likewise.
5667         * arm-linux-nat.c: Likewise.
5668         * i386-linux-nat.c: Likewise.
5669         * ia64-linux-nat.c: Likewise.
5670         * mips-linux-nat.c: Likewise.
5671         * ppc-linux-nat.c: Likewise.
5672         * s390-linux-nat.c: Likewise.
5673         * sparc64-linux-nat.c: Likewise.
5674         * x86-linux-nat.c: Likewise.
5675         * x86-linux-nat.h: Include "nat/x86-linux.h".
5676         (x86_linux_nat_target) <low_new_fork, low_forget_process,
5677         low_prepare_to_resume, low_new_thread, low_delete_thread>:
5678         Override methods.
5679
5680 2018-05-02  Pedro Alves  <palves@redhat.com>
5681
5682         * target.h (target_ops)
5683         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
5684         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
5685         stopped_by_watchpoint, have_continuable_watchpoint,
5686         stopped_data_address, watchpoint_addr_within_range,
5687         can_accel_watchpoint_condition, can_run, thread_alive,
5688         has_all_memory, has_memory, has_stack, has_registers,
5689         has_execution, can_async_p, is_async_p, supports_non_stop,
5690         always_non_stop_p, can_execute_reverse, supports_multi_process,
5691         supports_enable_disable_tracepoint,
5692         supports_disable_randomization, supports_string_tracing,
5693         supports_evaluation_of_breakpoint_conditions,
5694         can_run_breakpoint_commands, filesystem_is_local,
5695         can_download_tracepoint, get_trace_state_variable_value,
5696         set_trace_notes, get_tib_address, use_agent, can_use_agent,
5697         record_is_replaying, record_will_replay,
5698         augmented_libraries_svr4_read>: Adjust to return bool.
5699         * aarch64-linux-nat.c: All implementations adjusted.
5700         * aix-thread.c: All implementations adjusted.
5701         * arm-linux-nat.c: All implementations adjusted.
5702         * breakpoint.c: All implementations adjusted.
5703         * bsd-kvm.c: All implementations adjusted.
5704         * bsd-uthread.c: All implementations adjusted.
5705         * corelow.c: All implementations adjusted.
5706         * ctf.c: All implementations adjusted.
5707         * darwin-nat.c: All implementations adjusted.
5708         * darwin-nat.h: All implementations adjusted.
5709         * exec.c: All implementations adjusted.
5710         * fbsd-nat.c: All implementations adjusted.
5711         * fbsd-nat.h: All implementations adjusted.
5712         * gnu-nat.c: All implementations adjusted.
5713         * gnu-nat.h: All implementations adjusted.
5714         * go32-nat.c: All implementations adjusted.
5715         * ia64-linux-nat.c: All implementations adjusted.
5716         * inf-child.c: All implementations adjusted.
5717         * inf-child.h: All implementations adjusted.
5718         * inf-ptrace.c: All implementations adjusted.
5719         * inf-ptrace.h: All implementations adjusted.
5720         * linux-nat.c: All implementations adjusted.
5721         * linux-nat.h: All implementations adjusted.
5722         * mips-linux-nat.c: All implementations adjusted.
5723         * nto-procfs.c: All implementations adjusted.
5724         * ppc-linux-nat.c: All implementations adjusted.
5725         * procfs.c: All implementations adjusted.
5726         * ravenscar-thread.c: All implementations adjusted.
5727         * record-btrace.c: All implementations adjusted.
5728         * record-full.c: All implementations adjusted.
5729         * remote-sim.c: All implementations adjusted.
5730         * remote.c: All implementations adjusted.
5731         * s390-linux-nat.c: All implementations adjusted.
5732         * sol-thread.c: All implementations adjusted.
5733         * spu-multiarch.c: All implementations adjusted.
5734         * target-delegates.c: All implementations adjusted.
5735         * target.c: All implementations adjusted.
5736         * target.h: All implementations adjusted.
5737         * tracefile-tfile.c: All implementations adjusted.
5738         * tracefile.c: All implementations adjusted.
5739         * tracefile.h: All implementations adjusted.
5740         * windows-nat.c: All implementations adjusted.
5741         * x86-linux-nat.h: All implementations adjusted.
5742         * x86-nat.h: All implementations adjusted.
5743
5744 2018-05-02  Pedro Alves  <palves@redhat.com>
5745
5746         * make-target-delegates (scan_target_h): Don't trim lines here.
5747         Replace sequences of tabs and/or whitespace with a single
5748         whitespace.
5749         (top level, parsing methods): Trim each line before processing it
5750         here.
5751
5752 2018-05-02  Pedro Alves  <palves@redhat.com>
5753             John Baldwin  <jhb@freebsd.org>
5754
5755         * target.h (enum strata) <debug_stratum>: New.
5756         (struct target_ops) <all delegation methods>: Replace by C++
5757         virtual methods, and drop "to_" prefix.  All references updated
5758         throughout.
5759         <to_shortname, to_longname, to_doc, to_data,
5760         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
5761         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
5762         virtual methods.  All references updated throughout.
5763         <can_attach, supports_terminal_ours, can_create_inferior,
5764         get_thread_control_capabilities, attach_no_wait>: New
5765         virtual methods.
5766         <insert_breakpoint, remove_breakpoint>: Now
5767         TARGET_DEFAULT_NORETURN methods.
5768         <info_proc>: Now returns bool.
5769         <to_magic>: Delete.
5770         (OPS_MAGIC): Delete.
5771         (current_target): Delete.  All references replaced by references
5772         to ...
5773         (target_stack): ... this.  New.
5774         (target_shortname, target_longname): Adjust.
5775         (target_can_run): Now a function declaration.
5776         (default_child_has_all_memory, default_child_has_memory)
5777         (default_child_has_stack, default_child_has_registers)
5778         (default_child_has_execution): Remove target_ops parameter.
5779         (complete_target_initialization): Delete.
5780         (memory_breakpoint_target): New template class.
5781         (test_target_ops): Refactor as a C++ class with virtual methods.
5782         * make-target-delegates (NAME_PART): Tighten.
5783         (POINTER_PART, CP_SYMBOL): New.
5784         (SIMPLE_RETURN_PART): Reimplement.
5785         (VEC_RETURN_PART): Expect less.
5786         (RETURN_PART, VIRTUAL_PART): New.
5787         (METHOD): Adjust to C++ virtual methods.
5788         (scan_target_h): Remove reference to C99.
5789         (dname): Output "target_ops::" prefix.
5790         (write_function_header): Adjust to output a C++ class method.
5791         (write_declaration): New.
5792         (write_delegator): Adjust to output a C++ class method.
5793         (tdname): Output "dummy_target::" prefix.
5794         (write_tdefault, write_debugmethod): Adjust to output a C++ class
5795         method.
5796         (tdefault_names, debug_names): Delete.
5797         (return_types, tdefaults, styles, argtypes_array): New.
5798         (top level): All methods are delegators.
5799         (print_class): New.
5800         (top level): Print dummy_target and debug_target classes.
5801         * target-delegates.c: Regenerate.
5802         * target-debug.h (target_debug_print_enum_info_proc_what)
5803         (target_debug_print_thread_control_capabilities)
5804         (target_debug_print_thread_info_p): New.
5805         * target.c (dummy_target): Delete.
5806         (the_dummy_target, the_debug_target): New.
5807         (target_stack): Now extern.
5808         (set_targetdebug): Push/unpush debug target.
5809         (default_child_has_all_memory, default_child_has_memory)
5810         (default_child_has_stack, default_child_has_registers)
5811         (default_child_has_execution): Remove target_ops parameter.
5812         (complete_target_initialization): Delete.
5813         (add_target_with_completer): No longer call
5814         complete_target_initialization.
5815         (target_supports_terminal_ours): Use regular delegation.
5816         (update_current_target): Delete.
5817         (push_target): No longer check magic number.  Don't call
5818         update_current_target.
5819         (unpush_target): Don't call update_current_target.
5820         (target_is_pushed): No longer check magic number.
5821         (target_require_runnable): Skip for all stratums over
5822         process_stratum.
5823         (target_ops::info_proc): New.
5824         (target_info_proc): Use find_target_at and
5825         find_default_run_target.
5826         (target_supports_disable_randomization): Use regular delegation.
5827         (target_get_osdata): Use find_target_at.
5828         (target_ops::open, target_ops::close, target_ops::can_attach)
5829         (target_ops::attach, target_ops::can_create_inferior)
5830         (target_ops::create_inferior, target_ops::can_run)
5831         (target_can_run): New.
5832         (default_fileio_target): Use regular delegation.
5833         (target_ops::fileio_open, target_ops::fileio_pwrite)
5834         (target_ops::fileio_pread, target_ops::fileio_fstat)
5835         (target_ops::fileio_close, target_ops::fileio_unlink)
5836         (target_ops::fileio_readlink): New.
5837         (target_fileio_open_1, target_fileio_unlink)
5838         (target_fileio_readlink): Always call the target method.  Handle
5839         FILEIO_ENOSYS.
5840         (return_zero, return_zero_has_execution): Delete.
5841         (init_dummy_target): Delete.
5842         (dummy_target::dummy_target, dummy_target::shortname)
5843         (dummy_target::longname, dummy_target::doc)
5844         (debug_target::debug_target, debug_target::shortname)
5845         (debug_target::longname, debug_target::doc): New.
5846         (target_supports_delete_record): Use regular delegation.
5847         (setup_target_debug): Delete.
5848         (maintenance_print_target_stack): Skip debug_stratum.
5849         (initialize_targets): Instantiate the_dummy_target and
5850         the_debug_target.
5851         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
5852         use target_stack.
5853         (target_auxv_search, fprint_target_auxv): Adjust.
5854         (info_auxv_command): Adjust to use target_stack.
5855         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
5856         * exceptions.c (print_flush): Handle a NULL target_stack.
5857         * regcache.c (target_ops_no_register): Refactor as class with
5858         virtual methods.
5859
5860         * exec.c (exec_target): New class.
5861         (exec_ops): Now an exec_target.
5862         (exec_open, exec_close_1, exec_get_section_table)
5863         (exec_xfer_partial, exec_files_info, exec_has_memory)
5864         (exec_make_note_section): Refactor as exec_target methods.
5865         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
5866         Delete.
5867         (exec_target::find_memory_regions): New.
5868         (_initialize_exec): Don't call init_exec_ops.
5869         * gdbcore.h (exec_file_clear): Delete.
5870
5871         * corefile.c (core_target): Delete.
5872         (core_file_command): Adjust.
5873         * corelow.c (core_target): New class.
5874         (the_core_target): New.
5875         (core_close): Remove target_ops parameter.
5876         (core_close_cleanup): Adjust.
5877         (core_target::close): New.
5878         (core_open, core_detach, get_core_registers, core_files_info)
5879         (core_xfer_partial, core_thread_alive, core_read_description)
5880         (core_pid_to_str, core_thread_name, core_has_memory)
5881         (core_has_stack, core_has_registers, core_info_proc): Rework as
5882         core_target methods.
5883         (ignore, core_remove_breakpoint, init_core_ops): Delete.
5884         (_initialize_corelow): Initialize the_core_target.
5885         * gdbcore.h (core_target): Delete.
5886         (the_core_target): New.
5887
5888         * ctf.c: (ctf_target): New class.
5889         (ctf_ops): Now a ctf_target.
5890         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
5891         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
5892         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
5893         methods.
5894         (init_ctf_ops): Delete.
5895         (_initialize_ctf): Don't call it.
5896         * tracefile-tfile.c (tfile_target): New class.
5897         (tfile_ops): Now a tfile_target.
5898         (tfile_open, tfile_close, tfile_files_info)
5899         (tfile_get_tracepoint_status, tfile_trace_find)
5900         (tfile_fetch_registers, tfile_xfer_partial)
5901         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
5902         Refactor as tfile_target methods.
5903         (tfile_xfer_partial_features): Remove target_ops parameter.
5904         (init_tfile_ops): Delete.
5905         (_initialize_tracefile_tfile): Don't call it.
5906         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
5907         (tracefile_has_stack, tracefile_has_registers)
5908         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
5909         tracefile_target methods.
5910         (init_tracefile_ops): Delete.
5911         (tracefile_target::tracefile_target): New.
5912         * tracefile.h: Include "target.h".
5913         (tracefile_target): New class.
5914         (init_tracefile_ops): Delete.
5915
5916         * spu-multiarch.c (spu_multiarch_target): New class.
5917         (spu_ops): Now a spu_multiarch_target.
5918         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
5919         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
5920         (spu_search_memory, spu_mourn_inferior): Refactor as
5921         spu_multiarch_target methods.
5922         (init_spu_ops): Delete.
5923         (_initialize_spu_multiarch): Remove references to init_spu_ops,
5924         complete_target_initialization.
5925
5926         * ravenscar-thread.c (ravenscar_thread_target): New class.
5927         (ravenscar_ops): Now a ravenscar_thread_target.
5928         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
5929         (ravenscar_thread_alive, ravenscar_pid_to_str)
5930         (ravenscar_fetch_registers, ravenscar_store_registers)
5931         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
5932         (ravenscar_stopped_by_hw_breakpoint)
5933         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
5934         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
5935         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
5936         methods.
5937         (init_ravenscar_thread_ops): Delete.
5938         (_initialize_ravenscar): Remove references to
5939         init_ravenscar_thread_ops and complete_target_initialization.
5940
5941         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
5942         (bsd_uthread_target): New class.
5943         (bsd_uthread_ops): Now a bsd_uthread_target.
5944         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
5945         (bsd_uthread_close, bsd_uthread_mourn_inferior)
5946         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
5947         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
5948         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
5949         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
5950         (bsd_uthread_target): Delete function.
5951         (_initialize_bsd_uthread): Remove reference to
5952         complete_target_initialization.
5953
5954         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
5955         (target_bfd): ... this new class.
5956         (target_bfd_xfer_partial, target_bfd_get_section_table)
5957         (target_bfd_close): Refactor as target_bfd methods.
5958         (target_bfd::~target_bfd): New.
5959         (target_bfd_reopen): Adjust.
5960         (target_bfd::close): New.
5961
5962         * record-btrace.c (record_btrace_target): New class.
5963         (record_btrace_ops): Now a record_btrace_target.
5964         (record_btrace_open, record_btrace_stop_recording)
5965         (record_btrace_disconnect, record_btrace_close)
5966         (record_btrace_async, record_btrace_info)
5967         (record_btrace_insn_history, record_btrace_insn_history_range)
5968         (record_btrace_insn_history_from, record_btrace_call_history)
5969         (record_btrace_call_history_range)
5970         (record_btrace_call_history_from, record_btrace_record_method)
5971         (record_btrace_is_replaying, record_btrace_will_replay)
5972         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
5973         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
5974         (record_btrace_store_registers, record_btrace_prepare_to_store)
5975         (record_btrace_to_get_unwinder)
5976         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
5977         (record_btrace_commit_resume, record_btrace_wait)
5978         (record_btrace_stop, record_btrace_can_execute_reverse)
5979         (record_btrace_stopped_by_sw_breakpoint)
5980         (record_btrace_supports_stopped_by_sw_breakpoint)
5981         (record_btrace_stopped_by_hw_breakpoint)
5982         (record_btrace_supports_stopped_by_hw_breakpoint)
5983         (record_btrace_update_thread_list, record_btrace_thread_alive)
5984         (record_btrace_goto_begin, record_btrace_goto_end)
5985         (record_btrace_goto, record_btrace_stop_replaying_all)
5986         (record_btrace_execution_direction)
5987         (record_btrace_prepare_to_generate_core)
5988         (record_btrace_done_generating_core): Refactor as
5989         record_btrace_target methods.
5990         (init_record_btrace_ops): Delete.
5991         (_initialize_record_btrace): Remove reference to
5992         init_record_btrace_ops.
5993         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
5994         the execution_direction global.
5995         (record_full_base_target, record_full_target)
5996         (record_full_core_target): New classes.
5997         (record_full_ops): Now a record_full_target.
5998         (record_full_core_ops): Now a record_full_core_target.
5999         (record_full_target::detach, record_full_target::disconnect)
6000         (record_full_core_target::disconnect)
6001         (record_full_target::mourn_inferior, record_full_target::kill):
6002         New.
6003         (record_full_open, record_full_close, record_full_async): Refactor
6004         as methods of the record_full_base_target class.
6005         (record_full_resume, record_full_commit_resume): Refactor
6006         as methods of the record_full_target class.
6007         (record_full_wait, record_full_stopped_by_watchpoint)
6008         (record_full_stopped_data_address)
6009         (record_full_stopped_by_sw_breakpoint)
6010         (record_full_supports_stopped_by_sw_breakpoint)
6011         (record_full_stopped_by_hw_breakpoint)
6012         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
6013         methods of the record_full_base_target class.
6014         (record_full_store_registers, record_full_xfer_partial)
6015         (record_full_insert_breakpoint, record_full_remove_breakpoint):
6016         Refactor as methods of the record_full_target class.
6017         (record_full_can_execute_reverse, record_full_get_bookmark)
6018         (record_full_goto_bookmark, record_full_execution_direction)
6019         (record_full_record_method, record_full_info, record_full_delete)
6020         (record_full_is_replaying, record_full_will_replay)
6021         (record_full_goto_begin, record_full_goto_end, record_full_goto)
6022         (record_full_stop_replaying): Refactor as methods of the
6023         record_full_base_target class.
6024         (record_full_core_resume, record_full_core_kill)
6025         (record_full_core_fetch_registers)
6026         (record_full_core_prepare_to_store)
6027         (record_full_core_store_registers, record_full_core_xfer_partial)
6028         (record_full_core_insert_breakpoint)
6029         (record_full_core_remove_breakpoint)
6030         (record_full_core_has_execution): Refactor
6031         as methods of the record_full_core_target class.
6032         (record_full_base_target::supports_delete_record): New.
6033         (init_record_full_ops): Delete.
6034         (init_record_full_core_ops): Delete.
6035         (record_full_save): Refactor as method of the
6036         record_full_base_target class.
6037         (_initialize_record_full): Remove references to
6038         init_record_full_ops and init_record_full_core_ops.
6039
6040         * remote.c (remote_target, extended_remote_target): New classes.
6041         (remote_ops): Now a remote_target.
6042         (extended_remote_ops): Now an extended_remote_target.
6043         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
6044         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
6045         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
6046         (remote_pass_signals, remote_set_syscall_catchpoint)
6047         (remote_program_signals, )
6048         (remote_thread_always_alive): Remove target_ops parameter.
6049         (remote_thread_alive, remote_thread_name)
6050         (remote_update_thread_list, remote_threads_extra_info)
6051         (remote_static_tracepoint_marker_at)
6052         (remote_static_tracepoint_markers_by_strid)
6053         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
6054         (remote_open): Refactor as methods of remote_target.
6055         (extended_remote_open, extended_remote_detach)
6056         (extended_remote_attach, extended_remote_post_attach):
6057         (extended_remote_supports_disable_randomization)
6058         (extended_remote_create_inferior): : Refactor as method of
6059         extended_remote_target.
6060         (remote_set_permissions, remote_open_1, remote_detach)
6061         (remote_follow_fork, remote_follow_exec, remote_disconnect)
6062         (remote_resume, remote_commit_resume, remote_stop)
6063         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
6064         (remote_terminal_ours, remote_wait, remote_fetch_registers)
6065         (remote_prepare_to_store, remote_store_registers)
6066         (remote_flash_erase, remote_flash_done, remote_files_info)
6067         (remote_kill, remote_mourn, remote_insert_breakpoint)
6068         (remote_remove_breakpoint, remote_insert_watchpoint)
6069         (remote_watchpoint_addr_within_range)
6070         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
6071         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
6072         (remote_supports_stopped_by_sw_breakpoint)
6073         (remote_stopped_by_hw_breakpoint)
6074         (remote_supports_stopped_by_hw_breakpoint)
6075         (remote_stopped_by_watchpoint, remote_stopped_data_address)
6076         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
6077         (remote_verify_memory): Refactor as methods of remote_target.
6078         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
6079         parameter.
6080         (remote_xfer_partial, remote_get_memory_xfer_limit)
6081         (remote_search_memory, remote_rcmd, remote_memory_map)
6082         (remote_pid_to_str, remote_get_thread_local_address)
6083         (remote_get_tib_address, remote_read_description): Refactor as
6084         methods of remote_target.
6085         (remote_target::fileio_open, remote_target::fileio_pwrite)
6086         (remote_target::fileio_pread, remote_target::fileio_close): New.
6087         (remote_hostio_readlink, remote_hostio_fstat)
6088         (remote_filesystem_is_local, remote_can_execute_reverse)
6089         (remote_supports_non_stop, remote_supports_disable_randomization)
6090         (remote_supports_multi_process, remote_supports_cond_breakpoints)
6091         (remote_supports_enable_disable_tracepoint)
6092         (remote_supports_string_tracing)
6093         (remote_can_run_breakpoint_commands, remote_trace_init)
6094         (remote_download_tracepoint, remote_can_download_tracepoint)
6095         (remote_download_trace_state_variable, remote_enable_tracepoint)
6096         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
6097         (remote_trace_start, remote_get_trace_status)
6098         (remote_get_tracepoint_status, remote_trace_stop)
6099         (remote_trace_find, remote_get_trace_state_variable_value)
6100         (remote_save_trace_data, remote_get_raw_trace_data)
6101         (remote_set_disconnected_tracing, remote_core_of_thread)
6102         (remote_set_circular_trace_buffer, remote_traceframe_info)
6103         (remote_get_min_fast_tracepoint_insn_len)
6104         (remote_set_trace_buffer_size, remote_set_trace_notes)
6105         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
6106         (remote_disable_btrace, remote_teardown_btrace)
6107         (remote_read_btrace, remote_btrace_conf)
6108         (remote_augmented_libraries_svr4_read, remote_load)
6109         (remote_pid_to_exec_file, remote_can_do_single_step)
6110         (remote_execution_direction, remote_thread_handle_to_thread_info):
6111         Refactor as methods of remote_target.
6112         (init_remote_ops, init_extended_remote_ops): Delete.
6113         (remote_can_async_p, remote_is_async_p, remote_async)
6114         (remote_thread_events, remote_upload_tracepoints)
6115         (remote_upload_trace_state_variables): Refactor as methods of
6116         remote_target.
6117         (_initialize_remote): Remove references to init_remote_ops and
6118         init_extended_remote_ops.
6119
6120         * remote-sim.c (gdbsim_target): New class.
6121         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
6122         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
6123         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
6124         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
6125         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
6126         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
6127         Refactor as methods of gdbsim_target.
6128         (gdbsim_ops): Now a gdbsim_target.
6129         (init_gdbsim_ops): Delete.
6130         (gdbsim_cntrl_c): Adjust.
6131         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
6132
6133         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
6134         (the_amd64_linux_nat_target): New.
6135         (amd64_linux_fetch_inferior_registers)
6136         (amd64_linux_store_inferior_registers): Refactor as methods of
6137         amd64_linux_nat_target.
6138         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
6139         * i386-linux-nat.c: Don't include "linux-nat.h".
6140         (i386_linux_nat_target): New class.
6141         (the_i386_linux_nat_target): New.
6142         (i386_linux_fetch_inferior_registers)
6143         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
6144         as methods of i386_linux_nat_target.
6145         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
6146         * inf-child.c (inf_child_ops): Delete.
6147         (inf_child_fetch_inferior_registers)
6148         (inf_child_store_inferior_registers): Delete.
6149         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
6150         methods of inf_child_target.
6151         (inf_child_target::supports_terminal_ours)
6152         (inf_child_target::terminal_init)
6153         (inf_child_target::terminal_inferior)
6154         (inf_child_target::terminal_ours_for_output)
6155         (inf_child_target::terminal_ours, inf_child_target::interrupt)
6156         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
6157         New.
6158         (inf_child_open, inf_child_disconnect, inf_child_close)
6159         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
6160         (inf_child_post_startup_inferior, inf_child_can_run)
6161         (inf_child_pid_to_exec_file): Refactor as methods of
6162         inf_child_target.
6163         (inf_child_follow_fork): Delete.
6164         (inf_child_target::can_create_inferior)
6165         (inf_child_target::can_attach): New.
6166         (inf_child_target::has_all_memory, inf_child_target::has_memory)
6167         (inf_child_target::has_stack, inf_child_target::has_registers)
6168         (inf_child_target::has_execution): New.
6169         (inf_child_fileio_open, inf_child_fileio_pwrite)
6170         (inf_child_fileio_pread, inf_child_fileio_fstat)
6171         (inf_child_fileio_close, inf_child_fileio_unlink)
6172         (inf_child_fileio_readlink, inf_child_use_agent)
6173         (inf_child_can_use_agent): Refactor as methods of
6174         inf_child_target.
6175         (return_zero, inf_child_target): Delete.
6176         (inf_child_target::inf_child_target): New.
6177         * inf-child.h: Include "target.h".
6178         (inf_child_target): Delete function prototype.
6179         (inf_child_target): New class.
6180         (inf_child_open_target, inf_child_mourn_inferior)
6181         (inf_child_maybe_unpush_target): Delete.
6182         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
6183         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
6184         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
6185         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
6186         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
6187         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
6188         (inf_ptrace_wait, inf_ptrace_xfer_partial)
6189         (inf_ptrace_thread_alive, inf_ptrace_files_info)
6190         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
6191         methods of inf_ptrace_target.
6192         (inf_ptrace_target): Delete function.
6193         * inf-ptrace.h: Include "inf-child.h".
6194         (inf_ptrace_target): Delete function declaration.
6195         (inf_ptrace_target): New class.
6196         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
6197         * linux-nat.c (linux_target): New.
6198         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
6199         (linux_nat_target::~linux_nat_target): New.
6200         (linux_child_post_attach, linux_child_post_startup_inferior)
6201         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
6202         (linux_child_remove_fork_catchpoint)
6203         (linux_child_insert_vfork_catchpoint)
6204         (linux_child_remove_vfork_catchpoint)
6205         (linux_child_insert_exec_catchpoint)
6206         (linux_child_remove_exec_catchpoint)
6207         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
6208         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
6209         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
6210         (linux_nat_stopped_data_address)
6211         (linux_nat_stopped_by_sw_breakpoint)
6212         (linux_nat_supports_stopped_by_sw_breakpoint)
6213         (linux_nat_stopped_by_hw_breakpoint)
6214         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
6215         (linux_nat_kill, linux_nat_mourn_inferior)
6216         (linux_nat_xfer_partial, linux_nat_thread_alive)
6217         (linux_nat_update_thread_list, linux_nat_pid_to_str)
6218         (linux_nat_thread_name, linux_child_pid_to_exec_file)
6219         (linux_child_static_tracepoint_markers_by_strid)
6220         (linux_nat_is_async_p, linux_nat_can_async_p)
6221         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
6222         (linux_nat_supports_multi_process)
6223         (linux_nat_supports_disable_randomization, linux_nat_async)
6224         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
6225         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
6226         (linux_nat_fileio_open, linux_nat_fileio_readlink)
6227         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
6228         methods of linux_nat_target.
6229         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
6230         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
6231         parameter.
6232         (check_stopped_by_watchpoint): Adjust.
6233         (linux_xfer_partial): Delete.
6234         (linux_target_install_ops, linux_target, linux_nat_add_target):
6235         Delete.
6236         (linux_nat_target::linux_nat_target): New.
6237         * linux-nat.h: Include "inf-ptrace.h".
6238         (linux_nat_target): New.
6239         (linux_target, linux_target_install_ops, linux_nat_add_target):
6240         Delete function declarations.
6241         (linux_target): Declare global.
6242         * linux-thread-db.c (thread_db_target): New.
6243         (thread_db_target::thread_db_target): New.
6244         (thread_db_ops): Delete.
6245         (the_thread_db_target): New.
6246         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
6247         (thread_db_update_thread_list, thread_db_pid_to_str)
6248         (thread_db_extra_thread_info)
6249         (thread_db_thread_handle_to_thread_info)
6250         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
6251         (thread_db_resume): Refactor as methods of thread_db_target.
6252         (init_thread_db_ops): Delete.
6253         (_initialize_thread_db): Remove reference to init_thread_db_ops.
6254         * x86-linux-nat.c: Don't include "linux-nat.h".
6255         (super_post_startup_inferior): Delete.
6256         (x86_linux_nat_target::~x86_linux_nat_target): New.
6257         (x86_linux_child_post_startup_inferior)
6258         (x86_linux_read_description, x86_linux_enable_btrace)
6259         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
6260         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
6261         methods of x86_linux_nat_target.
6262         (x86_linux_create_target): Delete.  Bits folded ...
6263         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
6264         pointer.
6265         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
6266         (x86_linux_nat_target): New class.
6267         (x86_linux_create_target): Delete.
6268         (x86_linux_add_target): Now takes a linux_nat_target pointer.
6269         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
6270         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
6271         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
6272         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
6273         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
6274         make extern.
6275         (x86_use_watchpoints): Delete.
6276         * x86-nat.h: Include "breakpoint.h" and "target.h".
6277         (x86_use_watchpoints): Delete.
6278         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
6279         (x86_stopped_by_watchpoint, x86_stopped_data_address)
6280         (x86_insert_watchpoint, x86_remove_watchpoint)
6281         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
6282         (x86_stopped_by_hw_breakpoint): New declarations.
6283         (x86_nat_target): New template class.
6284
6285         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
6286         (the_ppc_linux_nat_target): New.
6287         (ppc_linux_fetch_inferior_registers)
6288         (ppc_linux_can_use_hw_breakpoint)
6289         (ppc_linux_region_ok_for_hw_watchpoint)
6290         (ppc_linux_ranged_break_num_registers)
6291         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
6292         (ppc_linux_insert_mask_watchpoint)
6293         (ppc_linux_remove_mask_watchpoint)
6294         (ppc_linux_can_accel_watchpoint_condition)
6295         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
6296         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
6297         (ppc_linux_watchpoint_addr_within_range)
6298         (ppc_linux_masked_watch_num_registers)
6299         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
6300         (ppc_linux_read_description): Refactor as methods of
6301         ppc_linux_nat_target.
6302         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
6303
6304         * procfs.c (procfs_xfer_partial): Delete forward declaration.
6305         (procfs_target): New class.
6306         (the_procfs_target): New.
6307         (procfs_target): Delete function.
6308         (procfs_auxv_parse, procfs_attach, procfs_detach)
6309         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
6310         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
6311         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
6312         (procfs_create_inferior, procfs_update_thread_list)
6313         (procfs_thread_alive, procfs_pid_to_str)
6314         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
6315         (procfs_stopped_data_address, procfs_insert_watchpoint)
6316         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
6317         (proc_find_memory_regions, procfs_info_proc)
6318         (procfs_make_note_section): Refactor as methods of procfs_target.
6319         (_initialize_procfs): Adjust.
6320         * sol-thread.c (sol_thread_target): New class.
6321         (sol_thread_ops): Now a sol_thread_target.
6322         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
6323         (sol_thread_fetch_registers, sol_thread_store_registers)
6324         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
6325         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
6326         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
6327         (init_sol_thread_ops): Delete.
6328         (_initialize_sol_thread): Adjust.  Remove references to
6329         init_sol_thread_ops and complete_target_initialization.
6330
6331         * windows-nat.c (windows_nat_target): New class.
6332         (windows_fetch_inferior_registers)
6333         (windows_store_inferior_registers, windows_resume, windows_wait)
6334         (windows_attach, windows_detach, windows_pid_to_exec_file)
6335         (windows_files_info, windows_create_inferior)
6336         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
6337         (windows_close, windows_pid_to_str, windows_xfer_partial)
6338         (windows_get_tib_address, windows_get_ada_task_ptid)
6339         (windows_thread_name, windows_thread_alive): Refactor as
6340         windows_nat_target methods.
6341         (do_initial_windows_stuff): Adjust.
6342         (windows_target): Delete function.
6343         (_initialize_windows_nat): Adjust.
6344
6345         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
6346         (darwin_mourn_inferior, darwin_kill_inferior)
6347         (darwin_create_inferior, darwin_attach, darwin_detach)
6348         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
6349         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
6350         (darwin_supports_multi_process): Refactor as darwin_nat_target
6351         methods.
6352         (darwin_resume_to, darwin_files_info): Delete.
6353         (_initialize_darwin_inferior): Rename to ...
6354         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
6355         * darwin-nat.h: Include "inf-child.h".
6356         (darwin_nat_target): New class.
6357         (darwin_complete_target): Delete.
6358         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
6359         (darwin_target): New.
6360         (i386_darwin_fetch_inferior_registers)
6361         (i386_darwin_store_inferior_registers): Refactor as methods of
6362         darwin_nat_target.
6363         (darwin_complete_target): Delete, with ...
6364         (_initialize_i386_darwin_nat): ... bits factored out here.
6365
6366         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
6367         (the_alpha_linux_nat_target): New.
6368         (alpha_linux_register_u_offset): Refactor as
6369         alpha_linux_nat_target method.
6370         (_initialize_alpha_linux_nat): Adjust.
6371         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
6372         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
6373         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
6374         methods of linux_nat_trad_target.
6375         (linux_trad_target): Delete.
6376         * linux-nat-trad.h (linux_trad_target): Delete function.
6377         (linux_nat_trad_target): New class.
6378         * mips-linux-nat.c (mips_linux_nat_target): New class.
6379         (super_fetch_registers, super_store_registers, super_close):
6380         Delete.
6381         (the_mips_linux_nat_target): New.
6382         (mips64_linux_regsets_fetch_registers)
6383         (mips64_linux_regsets_store_registers)
6384         (mips64_linux_fetch_registers, mips64_linux_store_registers)
6385         (mips_linux_register_u_offset, mips_linux_read_description)
6386         (mips_linux_can_use_hw_breakpoint)
6387         (mips_linux_stopped_by_watchpoint)
6388         (mips_linux_stopped_data_address)
6389         (mips_linux_region_ok_for_hw_watchpoint)
6390         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
6391         (mips_linux_close): Refactor as methods of mips_linux_nat.
6392         (_initialize_mips_linux_nat): Adjust to C++ification.
6393
6394         * aix-thread.c (aix_thread_target): New class.
6395         (aix_thread_ops): Now an aix_thread_target.
6396         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
6397         (aix_thread_fetch_registers, aix_thread_store_registers)
6398         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
6399         (aix_thread_thread_alive, aix_thread_pid_to_str)
6400         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
6401         Refactor as methods of aix_thread_target.
6402         (init_aix_thread_ops): Delete.
6403         (_initialize_aix_thread): Remove references to init_aix_thread_ops
6404         and complete_target_initialization.
6405         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
6406         (rs6000_nat_target): New class.
6407         (the_rs6000_nat_target): New.
6408         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
6409         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
6410         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
6411         (super_create_inferior): Delete.
6412         (_initialize_rs6000_nat): Adjust to C++ification.
6413
6414         * arm-linux-nat.c (arm_linux_nat_target): New class.
6415         (the_arm_linux_nat_target): New.
6416         (arm_linux_fetch_inferior_registers)
6417         (arm_linux_store_inferior_registers, arm_linux_read_description)
6418         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
6419         (arm_linux_remove_hw_breakpoint)
6420         (arm_linux_region_ok_for_hw_watchpoint)
6421         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
6422         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
6423         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
6424         arm_linux_nat_target.
6425         (_initialize_arm_linux_nat): Adjust to C++ification.
6426
6427         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
6428         (the_aarch64_linux_nat_target): New.
6429         (aarch64_linux_fetch_inferior_registers)
6430         (aarch64_linux_store_inferior_registers)
6431         (aarch64_linux_child_post_startup_inferior)
6432         (aarch64_linux_read_description)
6433         (aarch64_linux_can_use_hw_breakpoint)
6434         (aarch64_linux_insert_hw_breakpoint)
6435         (aarch64_linux_remove_hw_breakpoint)
6436         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
6437         (aarch64_linux_region_ok_for_hw_watchpoint)
6438         (aarch64_linux_stopped_data_address)
6439         (aarch64_linux_stopped_by_watchpoint)
6440         (aarch64_linux_watchpoint_addr_within_range)
6441         (aarch64_linux_can_do_single_step): Refactor as methods of
6442         aarch64_linux_nat_target.
6443         (super_post_startup_inferior): Delete.
6444         (_initialize_aarch64_linux_nat): Adjust to C++ification.
6445
6446         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
6447         (the_hppa_linux_nat_target): New.
6448         (hppa_linux_fetch_inferior_registers)
6449         (hppa_linux_store_inferior_registers): Refactor as methods of
6450         hppa_linux_nat_target.
6451         (_initialize_hppa_linux_nat): Adjust to C++ification.
6452
6453         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
6454         (the_ia64_linux_nat_target): New.
6455         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
6456         (ia64_linux_stopped_data_address)
6457         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
6458         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
6459         ia64_linux_nat_target methods.
6460         (super_xfer_partial): Delete.
6461         (_initialize_ia64_linux_nat): Adjust to C++ification.
6462
6463         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
6464         (the_m32r_linux_nat_target): New.
6465         (m32r_linux_fetch_inferior_registers)
6466         (m32r_linux_store_inferior_registers): Refactor as
6467         m32r_linux_nat_target methods.
6468         (_initialize_m32r_linux_nat): Adjust to C++ification.
6469
6470         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
6471         (the_m68k_linux_nat_target): New.
6472         (m68k_linux_fetch_inferior_registers)
6473         (m68k_linux_store_inferior_registers): Refactor as
6474         m68k_linux_nat_target methods.
6475         (_initialize_m68k_linux_nat): Adjust to C++ification.
6476
6477         * s390-linux-nat.c (s390_linux_nat_target): New class.
6478         (the_s390_linux_nat_target): New.
6479         (s390_linux_fetch_inferior_registers)
6480         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
6481         (s390_insert_watchpoint, s390_remove_watchpoint)
6482         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
6483         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
6484         (s390_auxv_parse, s390_read_description): Refactor as methods of
6485         s390_linux_nat_target.
6486         (_initialize_s390_nat): Adjust to C++ification.
6487
6488         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
6489         (the_sparc_linux_nat_target): New.
6490         (_initialize_sparc_linux_nat): Adjust to C++ification.
6491         * sparc-nat.c (sparc_fetch_inferior_registers)
6492         (sparc_store_inferior_registers): Remove target_ops parameter.
6493         * sparc-nat.h (sparc_fetch_inferior_registers)
6494         (sparc_store_inferior_registers): Remove target_ops parameter.
6495         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
6496         (the_sparc64_linux_nat_target): New.
6497         (_initialize_sparc64_linux_nat): Adjust to C++ification.
6498
6499         * spu-linux-nat.c (spu_linux_nat_target): New class.
6500         (the_spu_linux_nat_target): New.
6501         (spu_child_post_startup_inferior, spu_child_post_attach)
6502         (spu_child_wait, spu_fetch_inferior_registers)
6503         (spu_store_inferior_registers, spu_xfer_partial)
6504         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
6505         methods.
6506         (_initialize_spu_nat): Adjust to C++ification.
6507
6508         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
6509         (the_tilegx_linux_nat_target): New.
6510         (fetch_inferior_registers, store_inferior_registers):
6511         Refactor as methods.
6512         (_initialize_tile_linux_nat): Adjust to C++ification.
6513
6514         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
6515         (the_xtensa_linux_nat_target): New.
6516         (xtensa_linux_fetch_inferior_registers)
6517         (xtensa_linux_store_inferior_registers): Refactor as
6518         xtensa_linux_nat_target methods.
6519         (_initialize_xtensa_linux_nat): Adjust to C++ification.
6520
6521         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
6522         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
6523         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
6524         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
6525         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
6526         (fbsd_stopped_by_sw_breakpoint)
6527         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
6528         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
6529         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
6530         (fbsd_post_startup_inferior, fbsd_post_attach)
6531         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
6532         (fbsd_set_syscall_catchpoint)
6533         (super_xfer_partial, super_resume, super_wait)
6534         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
6535         (fbsd_handle_debug_trap): Remove target_ops parameter.
6536         (fbsd_nat_add_target): Delete.
6537         * fbsd-nat.h: Include "inf-ptrace.h".
6538         (fbsd_nat_add_target): Delete.
6539         (USE_SIGTRAP_SIGINFO): Define.
6540         (fbsd_nat_target): New class.
6541
6542         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
6543         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
6544         (amd64bsd_target): Delete.
6545         * amd64-bsd-nat.h: New file.
6546         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
6547         "x86-bsd-nat.h".
6548         (amd64_fbsd_nat_target): New class.
6549         (the_amd64_fbsd_nat_target): New.
6550         (amd64fbsd_read_description): Refactor as method of
6551         amd64_fbsd_nat_target.
6552         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
6553         (_initialize_amd64fbsd_nat): Adjust to C++ification.
6554         * amd64-nat.h (amd64bsd_target): Delete function declaration.
6555         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
6556         (i386bsd_store_inferior_registers): Remove target_ops parameter.
6557         (i386bsd_target): Delete.
6558         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
6559         (i386bsd_fetch_inferior_registers)
6560         (i386bsd_store_inferior_registers): Declare.
6561         (i386_bsd_nat_target): New class.
6562         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
6563         (the_i386_fbsd_nat_target): New.
6564         (i386fbsd_resume, i386fbsd_read_description): Refactor as
6565         i386_fbsd_nat_target methods.
6566         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
6567         (_initialize_i386fbsd_nat): Adjust to C++ification.
6568         * x86-bsd-nat.c (super_mourn_inferior): Delete.
6569         (x86bsd_mourn_inferior, x86bsd_target): Delete.
6570         (_initialize_x86_bsd_nat): Adjust to C++ification.
6571         * x86-bsd-nat.h: Include "x86-nat.h".
6572         (x86bsd_target): Delete declaration.
6573         (x86bsd_nat_target): New class.
6574
6575         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
6576         (the_aarch64_fbsd_nat_target): New.
6577         (aarch64_fbsd_fetch_inferior_registers)
6578         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
6579         aarch64_fbsd_nat_target.
6580         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
6581         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
6582         (the_alpha_bsd_nat_target): New.
6583         (alphabsd_fetch_inferior_registers)
6584         (alphabsd_store_inferior_registers): Refactor as
6585         alpha_bsd_nat_target methods.
6586         (_initialize_alphabsd_nat): Refactor as methods of
6587         alpha_bsd_nat_target.
6588         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
6589         (the_amd64_nbsd_nat_target): New.
6590         (_initialize_amd64nbsd_nat): Adjust to C++ification.
6591         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
6592         (the_amd64_obsd_nat_target): New.
6593         (_initialize_amd64obsd_nat): Adjust to C++ification.
6594         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
6595         (the_arm_fbsd_nat_target): New.
6596         (arm_fbsd_fetch_inferior_registers)
6597         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
6598         (_initialize_arm_fbsd_nat): Refactor as methods of
6599         arm_fbsd_nat_target.
6600         (_initialize_arm_fbsd_nat): Adjust to C++ification.
6601         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
6602         (the_arm_netbsd_nat_target): New.
6603         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
6604         arm_netbsd_nat_target.
6605         (_initialize_arm_netbsd_nat): Adjust to C++ification.
6606         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
6607         (the_hppa_nbsd_nat_target): New.
6608         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
6609         hppa_nbsd_nat_target methods.
6610         (_initialize_hppanbsd_nat): Adjust to C++ification.
6611         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
6612         (the_hppa_obsd_nat_target): New.
6613         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
6614         methods of hppa_obsd_nat_target.
6615         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
6616         add_target.
6617         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
6618         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
6619         add_target.
6620         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
6621         (_initialize_i386obsd_nat): Use add_target.
6622         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
6623         (the_m68k_bsd_nat_target): New.
6624         (m68kbsd_fetch_inferior_registers)
6625         (m68kbsd_store_inferior_registers): Refactor as methods of
6626         m68k_bsd_nat_target.
6627         (_initialize_m68kbsd_nat): Adjust to C++ification.
6628         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
6629         (the_mips_fbsd_nat_target): New.
6630         (mips_fbsd_fetch_inferior_registers)
6631         (mips_fbsd_store_inferior_registers): Refactor as methods of
6632         mips_fbsd_nat_target.
6633         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
6634         add_target.
6635         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
6636         (the_mips_nbsd_nat_target): New.
6637         (mipsnbsd_fetch_inferior_registers)
6638         (mipsnbsd_store_inferior_registers): Refactor as methods of
6639         mips_nbsd_nat_target.
6640         (_initialize_mipsnbsd_nat): Adjust to C++ification.
6641         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
6642         (the_mips64_obsd_nat_target): New.
6643         (mips64obsd_fetch_inferior_registers)
6644         (mips64obsd_store_inferior_registers): Refactor as methods of
6645         mips64_obsd_nat_target.
6646         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
6647         add_target.
6648         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
6649         nbsd_nat_target.
6650         * nbsd-nat.h: Include "inf-ptrace.h".
6651         (nbsd_nat_target): New class.
6652         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
6653         (obsd_wait): Refactor as methods of obsd_nat_target.
6654         (obsd_add_target): Delete.
6655         * obsd-nat.h: Include "inf-ptrace.h".
6656         (obsd_nat_target): New class.
6657         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
6658         (the_ppc_fbsd_nat_target): New.
6659         (ppcfbsd_fetch_inferior_registers)
6660         (ppcfbsd_store_inferior_registers): Refactor as methods of
6661         ppc_fbsd_nat_target.
6662         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
6663         add_target.
6664         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
6665         (the_ppc_nbsd_nat_target): New.
6666         (ppcnbsd_fetch_inferior_registers)
6667         (ppcnbsd_store_inferior_registers): Refactor as methods of
6668         ppc_nbsd_nat_target.
6669         (_initialize_ppcnbsd_nat): Adjust to C++ification.
6670         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
6671         (the_ppc_obsd_nat_target): New.
6672         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
6673         methods of ppc_obsd_nat_target.
6674         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
6675         add_target.
6676         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
6677         (the_sh_nbsd_nat_target): New.
6678         (shnbsd_fetch_inferior_registers)
6679         (shnbsd_store_inferior_registers): Refactor as methods of
6680         sh_nbsd_nat_target.
6681         (_initialize_shnbsd_nat): Adjust to C++ification.
6682         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
6683         (inf_ptrace_xfer_partial): Delete.
6684         (sparc_xfer_partial, sparc_target): Delete.
6685         * sparc-nat.h (sparc_fetch_inferior_registers)
6686         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
6687         (sparc_target): Delete function declaration.
6688         (sparc_target): New template class.
6689         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
6690         (_initialize_sparcnbsd_nat): Adjust to C++ification.
6691         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
6692         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
6693         add_target.
6694         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
6695         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
6696         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
6697         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
6698         add_target.
6699         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
6700         (the_vax_bsd_nat_target): New.
6701         (vaxbsd_fetch_inferior_registers)
6702         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
6703         methods.
6704         (_initialize_vaxbsd_nat): Adjust to C++ification.
6705
6706         * bsd-kvm.c (bsd_kvm_target): New class.
6707         (bsd_kvm_ops): Now a bsd_kvm_target.
6708         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
6709         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
6710         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
6711         bsd_kvm_target.
6712         (bsd_kvm_return_one): Delete.
6713         (bsd_kvm_add_target): Adjust to C++ification.
6714
6715         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
6716         (nto_procfs_target_procfs): New classes.
6717         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
6718         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
6719         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
6720         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
6721         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
6722         (procfs_remove_hw_breakpoint, procfs_resume)
6723         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
6724         (procfs_kill_inferior, procfs_store_registers)
6725         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
6726         as methods of nto_procfs_target.
6727         (nto_procfs_ops): Now an nto_procfs_target_procfs.
6728         (nto_native_ops): Delete.
6729         (procfs_open, procfs_native_open): Delete.
6730         (nto_native_ops): Now an nto_procfs_target_native.
6731         (init_procfs_targets): Adjust to C++ification.
6732         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
6733         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
6734         Refactor as methods of nto_procfs_target.
6735
6736         * go32-nat.c (go32_nat_target): New class.
6737         (the_go32_nat_target): New.
6738         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
6739         (go32_store_registers, go32_xfer_partial, go32_files_info)
6740         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
6741         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
6742         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
6743         (go32_pid_to_str): Refactor as methods of go32_nat_target.
6744         (go32_target): Delete.
6745         (_initialize_go32_nat): Adjust to C++ification.
6746
6747         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
6748         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
6749         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
6750         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
6751         gnu_nat_target.
6752         (gnu_target): Delete.
6753         * gnu-nat.h (gnu_target): Delete.
6754         (gnu_nat_target): New class.
6755         * i386-gnu-nat.c (gnu_base_target): New.
6756         (i386_gnu_nat_target): New class.
6757         (the_i386_gnu_nat_target): New.
6758         (_initialize_i386gnu_nat): Adjust to C++ification.
6759
6760 2018-05-02  Pedro Alves  <palves@redhat.com>
6761
6762         * bfd-target.c (target_bfd_xclose): Rename to ...
6763         (target_bfd_close): ... this.
6764         (target_bfd_reopen): Adjust.
6765         * target.c (target_close): Remove references to to_xclose.
6766         * target.h (target_ops::to_xclose): Delete.
6767         (target_ops::to_close): Update comments.
6768
6769 2018-05-02  Pedro Alves  <palves@redhat.com>
6770
6771         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
6772         "linux-nat.h".
6773         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
6774         * inf-ptrace.c (inf_ptrace_register_u_offset)
6775         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
6776         (inf_ptrace_store_register, inf_ptrace_store_registers)
6777         (inf_ptrace_trad_target): Move to ...
6778         * linux-nat-trad.c: ... this new file.
6779         * linux-nat-trad.h: New file.
6780         * linux-nat.c (linux_target_install_ops): Make extern.
6781         (linux_trad_target): Delete.
6782         * linux-nat.h (linux_trad_target): Delete declaration.
6783         (linux_target_install_ops): Declare.
6784         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
6785         "linux-nat.h".
6786
6787 2018-05-02  Pedro Alves  <palves@redhat.com>
6788
6789         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
6790         procfs_target/add_target here.
6791         * procfs.c (procfs_target): Make static.
6792         (_initialize_procfs): Call add_target here.
6793         * procfs.h (struct target_ops): Remove forward declaration.
6794         (procfs_target): Remove declaration.
6795         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
6796
6797 2018-05-02  Pedro Alves  <palves@redhat.com>
6798
6799         * procfs.c (procfs_stopped_by_watchpoint)
6800         (procfs_insert_watchpoint, procfs_remove_watchpoint)
6801         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
6802         Forward declare.
6803         (procfs_use_watchpoints): Delete, move contents...
6804         (procfs_target): ... here.
6805         * procfs.h (procfs_use_watchpoints): Delete declaration.
6806         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
6807         procfs_use_watchpoints.
6808         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
6809         procfs_use_watchpoints.
6810
6811 2018-05-02  Tom Tromey  <tom@tromey.com>
6812
6813         PR python/20084:
6814         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
6815         and var_zuinteger_unlimited.
6816         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
6817         and PARAM_ZUINTEGER_UNLIMITED.
6818         (set_parameter_value): Handle var_zuinteger and
6819         var_zuinteger_unlimited.
6820         (add_setshow_generic): Likewise.
6821         (parmpy_init): Likewise.
6822
6823 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
6824
6825         PR rust/23124
6826         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
6827         pointer is not null before dereferencing it.
6828
6829 2018-04-30  Tom Tromey  <tom@tromey.com>
6830
6831         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
6832         is_mi_like_p.
6833
6834 2018-04-30  Tom Tromey  <tom@tromey.com>
6835
6836         * breakpoint.c (mention): Remove use of is_mi_like_p.
6837         (print_mention_ranged_breakpoint): Likewise.
6838         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
6839         of is_mi_like_p.
6840
6841 2018-04-30  Tom Tromey  <tom@tromey.com>
6842
6843         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
6844
6845 2018-04-30  Tom Tromey  <tom@tromey.com>
6846
6847         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
6848         (info_spu_event_command): Remove some uses of is_mi_like_p.
6849
6850 2018-04-30  Tom Tromey  <tom@tromey.com>
6851
6852         * python/py-framefilter.c (py_print_single_arg)
6853         (enumerate_locals, py_print_args, py_print_frame): Remove some
6854         uses of is_mi_like_p.
6855
6856 2018-04-30  Tom Tromey  <tom@tromey.com>
6857
6858         * ui-out.c: Update.
6859         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
6860         * ui-out.h (ui_out::is_mi_like_p): Now const.
6861         (ui_out::do_is_mi_like_p): Now const.
6862         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
6863
6864 2018-04-30  Tom Tromey  <tom@tromey.com>
6865
6866         * varobj.c (varobj_set_visualizer): Use new_reference.
6867         * python/python.c (gdbpy_decode_line): Use new_reference.
6868         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
6869         new_reference.
6870
6871 2018-04-30  Tom Tromey  <tom@tromey.com>
6872
6873         * varobj.c (install_new_value): Use new_reference.
6874         * value.h (value_incref): Return void.  Swap intro comment with
6875         value_decref.
6876         * value.c (set_value_parent): Use new_reference.
6877         (value_incref): Return void.  Update intro comment.
6878         (release_value): Use new_reference.
6879         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
6880
6881 2018-04-30  Tom Tromey  <tom@tromey.com>
6882
6883         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
6884         * gdb_bfd.h (new_bfd_ref): Remove.
6885         (gdb_bfd_open): Update comment.
6886         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
6887         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
6888         (gdb_bfd_fdopenr): Use new_reference.
6889         * exec.c (exec_file_attach): Use new_reference.
6890
6891 2018-04-30  Tom Tromey  <tom@tromey.com>
6892
6893         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
6894         method.
6895
6896 2018-04-30  Tom Tromey  <tom@tromey.com>
6897
6898         * jit.c (jit_read_code_entry): Use type_align.
6899         * i386-tdep.c (i386_gdbarch_init): Don't call
6900         set_gdbarch_long_long_align_bit.
6901         * gdbarch.sh: Remove long_long_align_bit.
6902         * gdbarch.c, gdbarch.h: Rebuild.
6903         * arc-tdep.c (arc_type_align): New function.
6904         (arc_gdbarch_init): Use arc_type_align.  Don't call
6905         set_gdbarch_long_long_align_bit.
6906
6907 2018-04-30  Tom Tromey  <tom@tromey.com>
6908
6909         * rust-lang.c (rust_type_alignment): Remove.
6910         (rust_composite_type): Use type_align.
6911
6912 2018-04-30  Tom Tromey  <tom@tromey.com>
6913
6914         * NEWS: Mention Type.align.
6915         * python/py-type.c (typy_get_alignof): New function.
6916         (type_object_getset): Add "alignof".
6917
6918 2018-04-30  Tom Tromey  <tom@tromey.com>
6919
6920         PR exp/17095:
6921         * NEWS: Update.
6922         * std-operator.def (UNOP_ALIGNOF): New operator.
6923         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
6924         New.
6925         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
6926         * c-lang.c (c_op_print_tab): Add alignof.
6927         * c-exp.y (ALIGNOF): New token.
6928         (exp): Add "ALIGNOF" production.
6929         (ident_tokens): Add _Alignof and alignof.
6930
6931 2018-04-30  Tom Tromey  <tom@tromey.com>
6932
6933         * i386-tdep.c (i386_type_align): New function.
6934         (i386_gdbarch_init): Update.
6935         * gdbarch.sh (type_align): New method.
6936         * gdbarch.c, gdbarch.h: Rebuild.
6937         * arch-utils.h (default_type_align): Declare.
6938         * arch-utils.c (default_type_align): New function.
6939         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
6940         (struct type) <align_log2>: New field.
6941         <instance_flags>: Now a bitfield.
6942         (TYPE_RAW_ALIGN): New macro.
6943         (type_align, type_raw_align, set_type_align): Declare.
6944         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
6945         functions.
6946         * dwarf2read.c (quirk_rust_enum): Set type alignment.
6947         (get_alignment, maybe_set_alignment): New functions.
6948         (read_structure_type, read_enumeration_type, read_array_type)
6949         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
6950         (read_subrange_type, read_base_type): Set type alignment.
6951
6952 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
6953
6954         * dwarf2read.c (read_index_from_section): Use bool.
6955
6956 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
6957
6958         PR gdb/22950
6959         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
6960         with #ifdef.
6961
6962 2018-04-29  John Reiser  <jreiser@BitWagon.com>
6963
6964         PR build/22873
6965         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
6966         last step, and do it atomically.
6967
6968 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
6969
6970         * compile/compile-c-types.c (convert_int, convert_float):
6971         Update for C FE v1.
6972
6973 2018-04-27  Tom Tromey  <tom@tromey.com>
6974
6975         PR rust/22545:
6976         * rust-lang.c (rust_inclusive_range_type_p): New function.
6977         (rust_range): Handle inclusive ranges.
6978         (rust_compute_range): Likewise.
6979         * rust-exp.y (struct rust_op) <inclusive>: New field.
6980         (DOTDOTEQ): New constant.
6981         (range_expr): Add "..=" productions.
6982         (operator_tokens): Add "..=" token.
6983         (ast_range): Add "inclusive" parameter.
6984         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
6985         ranges.
6986         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
6987         bounds values.
6988         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
6989         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
6990         Update comments.
6991         * expprint.c (print_subexp_standard): Handle new bounds values.
6992         (dump_subexp_body_standard): Likewise.
6993
6994 2018-04-27  Tom Tromey  <tom@tromey.com>
6995
6996         * configure: Rebuild.
6997         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
6998         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
6999         "OVERRIDE".
7000         (class symbol_needs_eval_context): Likewise.
7001         * dwarf2read.c (mock_mapped_index::symbol_name_count)
7002         (mock_mapped_index::symbol_name_at): Use "override".  Remove
7003         "virtual".
7004         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
7005         "override".
7006         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
7007         * aarch64-tdep.c (instruction_reader::read): Use "override".
7008         (instruction_reader_test::read): Likewise.
7009         * arm-tdep.c (instruction_reader::read): Use "override".
7010         (instruction_reader_thumb::read): Likewise.
7011
7012 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
7013
7014         PR remote/9665
7015         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
7016         instead of remote_send.
7017         (remote_send): Remove.
7018
7019 2018-04-26  Pedro Alves  <palves@redhat.com>
7020
7021         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
7022         find_function_start_sal instead of find_pc_line.
7023
7024 2018-04-26  Pedro Alves  <palves@redhat.com>
7025
7026         * breakpoint.c (set_breakpoint_location_function): Handle
7027         mst_data_gnu_ifunc.
7028         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
7029         * elfread.c (elf_symtab_read): Give data symbols with
7030         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
7031         (elf_rel_plt_read): Update comment.
7032         * linespec.c (convert_linespec_to_sals): Handle
7033         mst_data_gnu_ifunc.
7034         (minsym_found): Handle mst_data_gnu_ifunc.
7035         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
7036         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
7037         * parse.c (find_minsym_type_and_address): Handle
7038         mst_data_gnu_ifunc.
7039         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
7040         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
7041         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
7042         comment.
7043         <mst_data_gnu_ifunc>: New enumerator.
7044
7045 2018-04-26  Pedro Alves  <palves@redhat.com>
7046
7047         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
7048         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
7049         'want_trampoline' parameter by a lookup_msym_prefer parameter.
7050         Handle it.
7051         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
7052         (lookup_minimal_symbol_by_pc): Adjust.
7053         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
7054         (lookup_solib_trampoline_symbol_by_pc): Adjust.
7055         * minsyms.h (lookup_msym_prefer): New enum.
7056         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
7057         parameter by a lookup_msym_prefer parameter.
7058
7059 2018-04-26  Pedro Alves  <palves@redhat.com>
7060
7061         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
7062         ends in "@plt" instead of looking at the symbol's section.
7063
7064 2018-04-26  Pedro Alves  <palves@redhat.com>
7065
7066         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
7067         all references.
7068         (find_pc_partial_function_gnu_ifunc): Rename to ...
7069         (find_pc_partial_function): ... this, and remove references to
7070         'is_gnu_ifunc_p'.
7071         (find_pc_partial_function): Delete old implementation.
7072         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
7073
7074 2018-04-26  Pedro Alves  <palves@redhat.com>
7075
7076         * linespec.c (struct bound_minimal_symbol_search_key): New.
7077         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
7078         skip first line if we found a GNU ifunc minimal symbol by name.
7079         (compare_msymbols): Change parameters to work with a destructured
7080         lhs minsym.
7081         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
7082         functions.
7083
7084 2018-04-26  Pedro Alves  <palves@redhat.com>
7085
7086         * breakpoint.c (set_breakpoint_location_function): Don't resolve
7087         ifunc targets here.  Instead, if we have an ifunc minsym, use its
7088         address/name.
7089         (add_location_to_breakpoint): Store the minsym and the objfile in
7090         the breakpoint location.
7091         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
7092         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
7093         Record the minsym in the sal.
7094         * symtab.h (symtab_and_line) <msymbol>: New field.
7095
7096 2018-04-26  Pedro Alves  <palves@redhat.com>
7097
7098         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
7099         unless we actually resolved the ifunc.
7100
7101 2018-04-26  Pedro Alves  <palves@redhat.com>
7102
7103         * c-exp.y (variable production): Prefer ifunc minsyms over
7104         regular function symbols.
7105         * symtab.c (find_gnu_ifunc): New function.
7106         * minsyms.h (lookup_msym_prefer): New enum.
7107         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
7108         parameter by a lookup_msym_prefer parameter.
7109         * symtab.h (find_gnu_ifunc): New declaration.
7110
7111 2018-04-26  Pedro Alves  <palves@redhat.com>
7112
7113         * blockframe.c (find_gnu_ifunc_target_type): New function.
7114         (find_function_type): New.
7115         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
7116         return a value with a memory address.
7117         (eval_call): For calls to GNU ifunc functions, try to find the
7118         type of the target function from the type that the resolver
7119         returns.
7120         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
7121         symbols.
7122         * infcall.c (find_function_return_type): Delete.
7123         (find_function_addr): Add 'function_type' parameter.  For calls to
7124         GNU ifunc functions, try to find the type of the target function
7125         from the type that the resolver returns, and return it via
7126         FUNCTION_TYPE.
7127         (call_function_by_hand_dummy): Adjust to use the function type
7128         returned by find_function_addr.
7129         (find_function_addr): Add 'function_type' parameter and move
7130         description here.
7131         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
7132         declarations.
7133
7134 2018-04-26  Pedro Alves  <palves@redhat.com>
7135
7136         * c-exp.y (variable production): Skip finding an alias for ifunc
7137         symbols.
7138
7139 2018-04-26  Pedro Alves  <palves@redhat.com>
7140
7141         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
7142
7143 2018-04-25  Pedro Alves  <palves@redhat.com>
7144
7145         * infcmd.c (kill_command): Print the pid as string, not the whole
7146         thread's ptid.  Add comment.  s/has been killed/killed/ in output
7147         message.
7148         * remote.c (remote_detach_1): Print the pid as string, not the
7149         whole thread's ptid.
7150
7151 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
7152             Sergio Durigan Junior  <sergiodj@redhat.com>
7153             Pedro Alves  <palves@redhat.com>
7154
7155         * infcmd.c (kill_command): Print message when inferior has
7156         been killed.
7157         * inferior.c (print_inferior_events): Remove 'static'.  Set as
7158         '1'.
7159         (add_inferior): Improve message printed when
7160         'print_inferior_events' is on.
7161         (exit_inferior): Remove message printed when
7162         'print_inferior_events' is on.
7163         (detach_inferior): Improve message printed when
7164         'print_inferior_events' is on.
7165         (initialize_inferiors): Use 'add_inferior_silent' to set
7166         'current_inferior_'.
7167         * inferior.h (print_inferior_events): Declare here as
7168         'extern'.
7169         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
7170         '[Detaching...]' messages when 'print_inferior_events' is on.
7171         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
7172         as prefix/suffix for messages.  Remove periods.  Fix erroneous
7173         'Detaching after fork from child...', replace it by '... from
7174         parent...'.
7175         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
7176         prefix/suffix when printing 'Detaching...' messages.  Print
7177         them when 'print_inferior_events' is on.
7178         * remote.c (remote_detach_1): Print message when detaching
7179         from inferior and '!is_fork_parent'.
7180
7181 2018-04-24  Tom Tromey  <tom@tromey.com>
7182
7183         * cli-out.h: Reindent.
7184
7185 2018-04-24  Tom Tromey  <tom@tromey.com>
7186
7187         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
7188         (cli_ui_out::do_field_string): Use fputs_filtered.
7189         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
7190
7191 2018-04-23  Tom Tromey  <tom@tromey.com>
7192
7193         * guile/scm-frame.c (gdbscm_frame_read_var): Use
7194         gdb::unique_xmalloc_ptr.
7195
7196 2018-04-23  Tom Tromey  <tom@tromey.com>
7197
7198         * configure: Rebuild.
7199
7200 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
7201
7202         PR gdb/23095
7203         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
7204         prepare_for_testing.  Set normal_bp to r_debug_state if target
7205         is bsd.
7206
7207 2018-04-21  Pedro Alves  <palves@redhat.com>
7208             Rajendra SY  <rajendra.sy@gmail.com>
7209
7210         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
7211         * remote.c (extended_remote_attach): In all-stop mode, mark the
7212         thread as executing.
7213
7214 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7215
7216         * thread.c (thread_apply_all_command): Fix comment.
7217         (thread_command): Fix comment.
7218
7219 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
7220
7221         * common/tdesc.h (tdesc_create_feature): Remove xml filename
7222         parameter.
7223         * features/aarch64-core.c (create_feature_aarch64_core):
7224         Regenerate.
7225         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
7226         Likewise.
7227         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
7228         Likewise.
7229         * features/i386/32bit-avx512.c
7230         (create_feature_i386_32bit_avx512): Likewise.
7231         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
7232         Likewise.
7233         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
7234         Likewise.
7235         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
7236         Likewise.
7237         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
7238         Likewise.
7239         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
7240         Likewise.
7241         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
7242         Likewise.
7243         * features/i386/64bit-avx512.c
7244         (create_feature_i386_64bit_avx512): Likewise.
7245         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
7246         Likewise.
7247         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
7248         Likewise.
7249         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
7250         Likewise.
7251         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
7252         Likewise.
7253         * features/i386/64bit-segments.c
7254         (create_feature_i386_64bit_segments): Likewise.
7255         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
7256         Likewise.
7257         * features/i386/x32-core.c
7258         (create_feature_i386_x32_core): Likewise.
7259         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
7260         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
7261         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
7262         * target-descriptions.c: In generated code, don't pass xml
7263         filename.
7264
7265 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7266
7267         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
7268         (print_xml_feature::visit_post): Likewise.
7269         (print_xml_feature::visit): Likewise.
7270         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
7271         (print_xml_feature): Add new class.
7272         * regformats/regdat.sh: Null xmltarget on feature targets.
7273         * target-descriptions.c (struct target_desc): Add xmltarget.
7274         (maintenance_check_tdesc_xml_convert): Add unittest function.
7275         (tdesc_get_features_xml): Add function to get xml.
7276         (maintenance_check_xml_descriptions): Test xml generation.
7277         * xml-tdesc.c (string_read_description_xml): Add function.
7278         * xml-tdesc.h (string_read_description_xml): Add declaration.
7279
7280 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7281
7282         * features/Makefile: Add feature marker to targets with new style
7283         target descriptions.
7284         * regformats/aarch64.dat: Regenerate.
7285         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
7286         * regformats/i386/amd64-avx-linux.dat: Likewise.
7287         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
7288         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
7289         * regformats/i386/amd64-linux.dat: Likewise.
7290         * regformats/i386/amd64-mpx-linux.dat: Likewise.
7291         * regformats/i386/amd64.dat: Likewise.
7292         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
7293         * regformats/i386/i386-avx-linux.dat: Likewise.
7294         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
7295         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
7296         * regformats/i386/i386-linux.dat: Likewise.
7297         * regformats/i386/i386-mmx-linux.dat: Likewise.
7298         * regformats/i386/i386-mpx-linux.dat: Likewise.
7299         * regformats/i386/i386.dat: Likewise.
7300         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
7301         * regformats/i386/x32-avx-linux.dat: Likewise.
7302         * regformats/i386/x32-linux.dat: Likewise.
7303         * regformats/tic6x-c62x-linux.dat: Likewise.
7304         * regformats/tic6x-c64x-linux.dat: Likewise.
7305         * regformats/tic6x-c64xp-linux.dat: Likewise.
7306         * regformats/regdat.sh: Parse feature marker.
7307
7308 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7309
7310         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
7311         (tdesc_osabi_name): Likewise.
7312         * target-descriptions.c (tdesc_architecture_name): Add new
7313         function.
7314         (tdesc_osabi_name): Likewise.
7315
7316 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7317
7318         * common/tdesc.c (tdesc_predefined_type): Move to here.
7319         (tdesc_named_type): Likewise.
7320         (tdesc_create_vector): Likewise.
7321         (tdesc_create_struct): Likewise.
7322         (tdesc_set_struct_size): Likewise.
7323         (tdesc_create_union): Likewise.
7324         (tdesc_create_flags): Likewise.
7325         (tdesc_create_enum): Likewise.
7326         (tdesc_add_field): Likewise.
7327         (tdesc_add_typed_bitfield): Likewise.
7328         (tdesc_add_bitfield): Likewise.
7329         (tdesc_add_flag): Likewise.
7330         (tdesc_add_enum_value): Likewise.
7331         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
7332         (struct tdesc_type_vector): Likewise.
7333         (struct tdesc_type_field): Likewise.
7334         (struct tdesc_type_with_fields): Likewise.
7335         (tdesc_create_enum): Add declaration.
7336         (tdesc_add_typed_bitfield): Likewise.
7337         (tdesc_add_enum_value): Likewise.
7338         * target-descriptions.c (tdesc_type_field): Move from here.
7339         (tdesc_type_builtin): Likewise.
7340         (tdesc_type_vector): Likewise.
7341         (tdesc_type_with_fields): Likewise.
7342         (tdesc_predefined_types): Likewise.
7343         (tdesc_named_type): Likewise.
7344         (tdesc_create_vector): Likewise.
7345         (tdesc_create_struct): Likewise.
7346         (tdesc_set_struct_size): Likewise.
7347         (tdesc_create_union): Likewise.
7348         (tdesc_create_flags): Likewise.
7349         (tdesc_create_enum): Likewise.
7350         (tdesc_add_field): Likewise.
7351         (tdesc_add_typed_bitfield): Likewise.
7352         (tdesc_add_bitfield): Likewise.
7353         (tdesc_add_flag): Likewise.
7354         (tdesc_add_enum_value): Likewise.
7355         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
7356         (tdesc_add_typed_bitfield): Likewise.
7357         (tdesc_add_enum_value): Likewise.
7358
7359 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7360
7361         * common/tdesc.c (tdesc_feature::accept): Move to here.
7362         (tdesc_feature::operator==): Likewise.
7363         (tdesc_create_reg): Likewise.
7364         * common/tdesc.h (tdesc_type_kind): Likewise.
7365         (struct tdesc_type): Likewise.
7366         (struct tdesc_feature): Likewise.
7367         * regformats/regdat.sh: Create a feature.
7368         * target-descriptions.c (tdesc_type_kind): Move from here.
7369         (tdesc_type): Likewise.
7370         (tdesc_type_up): Likewise.
7371         (tdesc_feature): Likewise.
7372         (tdesc_create_reg): Likewise.
7373
7374 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7375
7376         * Makefile.in: Add arch/tdesc.c
7377         * common/tdesc.c: New file.
7378         * common/tdesc.h (tdesc_element_visitor): Move to here.
7379         (tdesc_element): Likewise.
7380         (tdesc_reg): Likewise.
7381         (tdesc_reg_up): Likewise.
7382         * regformats/regdef.h (reg): Add offset to constructors.
7383         * target-descriptions.c (tdesc_element_visitor): Move from here.
7384         (tdesc_element): Likewise.
7385         (tdesc_reg): Likewise.
7386         (tdesc_reg_up): Likewise.
7387
7388 2018-04-17  Tom Tromey  <tom@tromey.com>
7389
7390         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
7391         discriminant field.
7392
7393 2018-04-17  Tom Tromey  <tom@tromey.com>
7394
7395         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
7396
7397 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7398
7399         * symtab.c (print_symbol_info): Skip printing filename and line
7400         number when `last' is NULL.
7401         (symtab_symbol_info): Use empty string instead of NULL for first
7402         invocation of print_symbol_info.
7403         (rbreak_command): Pass NULL to `last' parameter of
7404         print_symbol_info.
7405
7406 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
7407
7408         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
7409         instead of nullptr.
7410
7411 2018-04-16  Pedro Alves  <palves@redhat.com>
7412
7413         * MAINTAINERS (sh): Remove.
7414         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
7415         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
7416         (ALLDEPFILES): Remove sh64-tdep.c.
7417         * NEWS: Mentions that support for SH-5/SH64 is removed.
7418         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
7419         (sh*-*-openbsd*): Ditto.
7420         (sh64-*-elf*): Remove.
7421         (sh*): Remove.
7422         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
7423         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
7424         * sh-tdep.c: No longer include "sh64-tdep.h".
7425         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
7426         * sh64-tdep.c, sh64-tdep.h: Remove files.
7427
7428 2018-04-16  Pedro Alves  <palves@redhat.com>
7429
7430         * MAINTAINERS: Remove m88k.
7431         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
7432         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
7433         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
7434         * NEWS: Mention that support for m88k was removed.
7435         * configure.host (m88*-*-*): Remove support.
7436         * configure.nat (m88k-*-*): Remove support.
7437         * configure.tgt (m88*-*-openbsd*): Remove.
7438         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
7439
7440 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
7441
7442         * configure.tgt (x86_tobjs): New variable.
7443         (amd64_tobjs, i386_tobjs): Use it.
7444
7445 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7446
7447         * symtab.c (print_symbol_info): Precede the symbol definition by
7448         the line number when available.
7449         * NEWS: Advertise this enhancement.
7450
7451 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7452
7453         * NEWS (New options): announce set/show record btrace cpu.
7454         * btrace.c: Include record-btrace.h.
7455         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
7456         the vendor is unknown.
7457         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
7458         Maybe overwrite the btrace configuration's cpu.
7459         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
7460         (btrace_fetch): Add cpu parameter.  Update callers.
7461         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
7462         Maybe overwrite the btrace configuration's cpu.  Skip enabling
7463         errata workarounds if the vendor is unknown.
7464         * python/py-record-btrace.c: Include record-btrace.h.
7465         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
7466         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
7467         * record-btrace.c (record_btrace_cpu_state_kind): New.
7468         (record_btrace_cpu): New.
7469         (set_record_btrace_cpu_cmdlist): New.
7470         (record_btrace_get_cpu): New.
7471         (require_btrace_thread, record_btrace_info)
7472         (record_btrace_resume_thread): Call record_btrace_get_cpu.
7473         (cmd_set_record_btrace_cpu_none): New.
7474         (cmd_set_record_btrace_cpu_auto): New.
7475         (cmd_set_record_btrace_cpu): New.
7476         (cmd_show_record_btrace_cpu): New.
7477         (_initialize_record_btrace): Initialize set/show record btrace cpu
7478         commands.
7479         * record-btrace.h (record_btrace_get_cpu): New.
7480
7481 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7482
7483         * record.c (set_record_command): Fix typo in message.
7484
7485 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7486
7487         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
7488
7489 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7490
7491         * infrun.c (process_event_stop_test): Call
7492         gdbarch_in_indirect_branch_thunk.
7493         * gdbarch.sh (in_indirect_branch_thunk): New.
7494         * gdbarch.c: Regenerated.
7495         * gdbarch.h: Regenerated.
7496         * x86-tdep.h: New.
7497         * x86-tdep.c: New.
7498         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
7499         (HFILES_NO_SRCDIR): Add x86-tdep.h.
7500         (ALLDEPFILES): Add x86-tdep.c.
7501         * arch-utils.h (default_in_indirect_branch_thunk): New.
7502         * arch-utils.c (default_in_indirect_branch_thunk): New.
7503         * i386-tdep: Include x86-tdep.h.
7504         (i386_in_indirect_branch_thunk): New.
7505         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
7506         function.
7507         * amd64-tdep: Include x86-tdep.h.
7508         (amd64_in_indirect_branch_thunk): New.
7509         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
7510
7511 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
7512
7513         PR gdb/23053
7514         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
7515         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
7516         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
7517         regression.
7518
7519 2018-04-12  Tom Tromey  <tom@tromey.com>
7520
7521         * rust-lang.c (rust_print_struct_def): Remove univariant code.
7522         (rust_evaluate_subexp): Likewise.
7523
7524 2018-04-12  Pedro Alves  <palves@redhat.com>
7525
7526         * procfs.c (procfs_detach): Make forward declaration's prototype
7527         match definition's protototype.
7528         (proc_get_LDT_entry): Remove stale do_cleanups call.
7529
7530 2018-04-12  Pedro Alves  <palves@redhat.com>
7531
7532         * target.h (target_ops::to_has_exited): Delete.
7533         (target_has_exited): Delete.
7534         * target-delegates.c: Regenerate.
7535
7536 2018-04-11  Pedro Alves  <palves@redhat.com>
7537
7538         * target.c (fileio_fh_t::t): Add comment.
7539         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
7540         (target_fileio_close): Handle a NULL target.
7541         (invalidate_fileio_fh): New.
7542         (target_close): Call it.
7543         * remote.c (remote_hostio_send_command): No longer check whether
7544         remote_desc is open.
7545
7546 2018-04-11  Pedro Alves  <palves@redhat.com>
7547
7548         * target.c (fileio_fh_t): Make it a named struct instead of a
7549         typedef.
7550         (fileio_fh_t::is_closed): New method.
7551         (DEF_VEC_O (fileio_fh_t)): Remove.
7552         (fileio_fhandles): Now a std::vector.
7553         (is_closed_fileio_fh): Delete.
7554         (acquire_fileio_fd): Adjust.  Rename parameters.
7555         (release_fileio_fd): Adjust.
7556         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
7557         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
7558         (target_fileio_close): Adjust.
7559
7560 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
7561
7562         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
7563         index.
7564
7565 2018-04-10  Pedro Alves  <palves@redhat.com>
7566
7567         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
7568         (scoped_finish_thread_state): New class.
7569         * infcmd.c (run_command_1): Use it instead of finish_thread_state
7570         cleanup.
7571         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
7572         (fetch_inferior_event, normal_stop): Likewise.
7573         * thread.c (finish_thread_state_cleanup): Delete.
7574
7575 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7576             Pedro Alves  <palves@redhat.com>
7577
7578         * value.c: Include "selftest.h" and "common/array-view.h".
7579         (struct range) <operator ==>: New.
7580         (test_ranges_contain): New.
7581         (check_ranges_vector): New.
7582         (test_insert_into_bit_range_vector): New.
7583         (_initialize_values): Register selftests.
7584         * common/array-view.h (operator==, operator!=): New.
7585
7586 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7587
7588         * common/gdb_vecs.h (unordered_remove): Add overload that takes
7589         an iterator.
7590         * inline-frame.c: Include <algorithm>.
7591         (struct inline_state): Add constructor.
7592         (inline_state_s): Remove.
7593         (DEF_VEC_O(inline_state_s)): Remove.
7594         (inline_states): Change type to std::vector.
7595         (find_inline_frame_state): Adjust to std::vector.
7596         (allocate_inline_frame_state): Remove.
7597         (clear_inline_frame_state): Adjust to std::vector.
7598         (skip_inline_frames): Adjust to std::vector.
7599
7600 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7601
7602         * tracepoint.h (struct trace_state_variable): Add constructor.
7603         <name>: Change type to std::string.
7604         * tracepoint.c (tsv_s): Remove.
7605         (DEF_VEC_O(tsv_s)): Remove.
7606         (tvariables): Change to std::vector.
7607         (create_trace_state_variable): Adjust to std::vector.
7608         (find_trace_state_variable): Likewise.
7609         (find_trace_state_variable_by_number): Likewise.
7610         (delete_trace_state_variable): Likewise.
7611         (trace_variable_command): Adjust to std::string.
7612         (delete_trace_variable_command): Likewise.
7613         (tvariables_info_1): Adjust to std::vector.
7614         (save_trace_state_variables): Likewise.
7615         (start_tracing): Likewise.
7616         (merge_uploaded_trace_state_variables): Adjust to std::vector
7617         and std::string.
7618         * target.h (struct target_ops)
7619         <to_download_trace_state_variable>: Pass reference to
7620         trace_state_variable.
7621         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
7622         * target-delegates.c: Re-generate.
7623         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
7624         (mi_tsv_deleted): Likewise.
7625         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
7626         * remote.c (remote_download_trace_state_variable): Change
7627         pointer to reference and adjust.
7628         * make-target-delegates (parse_argtypes): Handle references.
7629         (write_function_header): Likewise.
7630         (munge_type): Likewise.
7631
7632 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7633
7634         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7635         string_view-selftests.c.
7636         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
7637         testsuite.
7638         * unittests/basic_string_view/cons/char/1.cc: Likewise.
7639         * unittests/basic_string_view/cons/char/2.cc: Likewise.
7640         * unittests/basic_string_view/cons/char/3.cc: Likewise.
7641         * unittests/basic_string_view/element_access/char/1.cc:
7642         Likewise.
7643         * unittests/basic_string_view/element_access/char/empty.cc:
7644         Likewise.
7645         * unittests/basic_string_view/element_access/char/front_back.cc:
7646         Likewise.
7647         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
7648         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
7649         Likewise.
7650         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
7651         Likewise.
7652         * unittests/basic_string_view/modifiers/swap/char/1.cc:
7653         Likewise.
7654         * unittests/basic_string_view/operations/compare/char/1.cc:
7655         Likewise.
7656         * unittests/basic_string_view/operations/compare/char/13650.cc:
7657         Likewise.
7658         * unittests/basic_string_view/operations/copy/char/1.cc:
7659         Likewise.
7660         * unittests/basic_string_view/operations/data/char/1.cc:
7661         Likewise.
7662         * unittests/basic_string_view/operations/find/char/1.cc:
7663         Likewise.
7664         * unittests/basic_string_view/operations/find/char/2.cc:
7665         Likewise.
7666         * unittests/basic_string_view/operations/find/char/3.cc:
7667         Likewise.
7668         * unittests/basic_string_view/operations/find/char/4.cc:
7669         Likewise.
7670         * unittests/basic_string_view/operations/rfind/char/1.cc:
7671         Likewise.
7672         * unittests/basic_string_view/operations/rfind/char/2.cc:
7673         Likewise.
7674         * unittests/basic_string_view/operations/rfind/char/3.cc:
7675         Likewise.
7676         * unittests/basic_string_view/operations/substr/char/1.cc:
7677         Likewise.
7678         * unittests/basic_string_view/operators/char/2.cc: Likewise.
7679         * unittests/string_view-selftests.c: New file.
7680
7681 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7682
7683         * unittests/basic_string_view/capacity/1.cc: New file.
7684         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
7685         * unittests/basic_string_view/cons/char/1.cc: New file.
7686         * unittests/basic_string_view/cons/char/2.cc: New file.
7687         * unittests/basic_string_view/cons/char/3.cc: New file.
7688         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
7689         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
7690         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
7691         * unittests/basic_string_view/element_access/char/1.cc: New file.
7692         * unittests/basic_string_view/element_access/char/2.cc: New file.
7693         * unittests/basic_string_view/element_access/char/empty.cc: New file.
7694         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
7695         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
7696         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
7697         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
7698         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
7699         * unittests/basic_string_view/include.cc: New file.
7700         * unittests/basic_string_view/inserters/char/1.cc: New file.
7701         * unittests/basic_string_view/inserters/char/2.cc: New file.
7702         * unittests/basic_string_view/inserters/char/3.cc: New file.
7703         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
7704         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
7705         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
7706         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
7707         * unittests/basic_string_view/literals/types.cc: New file.
7708         * unittests/basic_string_view/literals/values.cc: New file.
7709         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
7710         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
7711         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
7712         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
7713         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
7714         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
7715         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
7716         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
7717         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
7718         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
7719         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
7720         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
7721         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
7722         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
7723         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
7724         * unittests/basic_string_view/operations/data/char/1.cc: New file.
7725         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
7726         * unittests/basic_string_view/operations/find/char/1.cc: New file.
7727         * unittests/basic_string_view/operations/find/char/2.cc: New file.
7728         * unittests/basic_string_view/operations/find/char/3.cc: New file.
7729         * unittests/basic_string_view/operations/find/char/4.cc: New file.
7730         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
7731         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
7732         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
7733         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
7734         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
7735         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
7736         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
7737         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
7738         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
7739         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
7740         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
7741         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
7742         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
7743         * unittests/basic_string_view/operators/char/2.cc: New file.
7744         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
7745         * unittests/basic_string_view/range_access/char/1.cc: New file.
7746         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
7747         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
7748         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
7749         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
7750         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
7751         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
7752         * unittests/basic_string_view/requirements/typedefs.cc: New file.
7753         * unittests/basic_string_view/typedefs.cc: New file.
7754         * unittests/basic_string_view/types/1.cc: New file.
7755
7756 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7757
7758         * common/gdb_string_view.h: Remove libstdc++ implementation
7759         details, adjust to gdb reality.
7760         * common/gdb_string_view.tcc: Likewise.
7761         * cli/cli-script.c (struct string_view): Remove.
7762         (user_args) <m_args>: Change element type to gdb::string_view.
7763         (user_args::insert_args): Adjust.
7764
7765 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7766
7767         * common/gdb_string_view.h: New file.
7768         * common/gdb_string_view.tcc: New file.
7769
7770 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7771
7772         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
7773         * configure: Re-generate.
7774
7775 2018-04-09  Pedro Alves  <palves@redhat.com>
7776
7777         * gdbarch.sh: Include "observable.h" instead of "observer.h".
7778         (set_target_gdbarch): Call
7779         gdb::observers::architecture_changed.notify instead of
7780         observer_notify_architecture_changed.
7781
7782 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7783
7784         * tracepoint.c (struct current_traceframe_cleanup): Remove.
7785         (do_restore_current_traceframe_cleanup): Remove.
7786         (restore_current_traceframe_cleanup_dtor): Remove.
7787         (make_cleanup_restore_current_traceframe): Remove.
7788         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
7789         New.
7790         * tracepoint.h (struct scoped_restore_current_traceframe): New.
7791         * infrun.c (fetch_inferior_event): Use
7792         scoped_restore_current_traceframe.
7793
7794 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7795
7796         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
7797         Remove.
7798         <n_allocated_type_units>: Remove.
7799         <all_type_units>: Change to std::vector.
7800         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
7801         to std::vector change.
7802         (dwarf2_per_objfile::get_cutu): Likewise.
7803         (dwarf2_per_objfile::get_tu): Likewise.
7804         (create_signatured_type_table_from_index): Likewise.
7805         (create_signatured_type_table_from_debug_names): Likewise.
7806         (dw2_symtab_iter_next): Likewise.
7807         (dw2_print_stats): Likewise.
7808         (dw2_expand_all_symtabs): Likewise.
7809         (dw2_expand_marked_cus): Likewise.
7810         (dw2_debug_names_iterator::next): Likewise.
7811         (dwarf2_initialize_objfile): Likewise.
7812         (add_signatured_type_cu_to_table): Likewise.
7813         (create_all_type_units): Likewise.
7814         (add_type_unit): Likewise.
7815         (struct tu_abbrev_offset): Add constructor.
7816         (build_type_psymtabs_1): Adjust to std::vector change.
7817         (print_tu_stats): Likewise.
7818         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
7819         (write_debug_names): Likewise.
7820
7821 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7822
7823         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
7824         Make an std::vector.
7825         <n_comp_units>: Remove.
7826         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
7827         to std::vector change.
7828         (dwarf2_per_objfile::get_cutu): Likewise.
7829         (dwarf2_per_objfile::get_cu): Likewise.
7830         (create_cus_from_index): Likewise.
7831         (create_addrmap_from_index): Likewise.
7832         (create_addrmap_from_aranges): Likewise.
7833         (dwarf2_read_index): Likewise.
7834         (dw2_find_last_source_symtab): Likewise.
7835         (dw2_map_symtabs_matching_filename): Likewise.
7836         (dw2_symtab_iter_next): Likewise.
7837         (dw2_print_stats): Likewise.
7838         (dw2_expand_all_symtabs): Likewise.
7839         (dw2_expand_symtabs_with_fullname): Likewise.
7840         (dw2_expand_marked_cus): Likewise.
7841         (dw2_map_symbol_filenames): Likewise.
7842         (create_cus_from_debug_names): Likewise.
7843         (dwarf2_read_debug_names): Likewise.
7844         (dw2_debug_names_iterator::next): Likewise.
7845         (dwarf2_initialize_objfile): Likewise.
7846         (set_partial_user): Likewise.
7847         (dwarf2_build_psymtabs_hard): Likewise.
7848         (read_comp_units_from_section): Remove arguments, adjust to
7849         std::vector change.
7850         (create_all_comp_units): Adjust to std::vector and
7851         read_comp_units_from_section changes.
7852         (dwarf2_find_containing_comp_unit): Adjust to std::vector
7853         change.
7854         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
7855         (psyms_seen_size): Likewise.
7856         (write_gdbindex): Likewise.
7857         (write_debug_names): Likewise.
7858
7859 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7860
7861         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
7862         with dwarf2_per_objfile.
7863         (create_cus_from_index): Likewise.
7864         (create_signatured_type_table_from_index): Likewise.
7865         (dwarf2_read_index): Likewise.
7866         (dwarf2_initialize_objfile): Likewise.
7867         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
7868         per_cu rather than get_dwarf2_per_objfile.
7869
7870 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7871
7872         * dwarf2read.h (struct signatured_type): Forward declare.
7873         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
7874         New methods.
7875         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
7876         (dw2_get_cutu): ...this.
7877         (dwarf2_per_objfile::get_cu): Rename from...
7878         (dw2_get_cu): ...this.
7879         (dwarf2_per_objfile::get_tu): New.
7880         (create_addrmap_from_index): Adjust.
7881         (create_addrmap_from_aranges): Adjust.
7882         (dw2_find_last_source_symtab): Adjust.
7883         (dw2_map_symtabs_matching_filename): Adjust.
7884         (dw2_symtab_iter_next): Adjust.
7885         (dw2_print_stats): Adjust.
7886         (dw2_expand_all_symtabs): Adjust.
7887         (dw2_expand_symtabs_with_fullname): Adjust.
7888         (dw2_expand_marked_cus): Adjust.
7889         (dw_expand_symtabs_matching_file_matcher): Adjust.
7890         (dw2_map_symbol_filenames): Adjust.
7891         (dw2_debug_names_iterator::next): Adjust.
7892         (dwarf2_initialize_objfile): Adjust.
7893         (set_partial_user): Adjust.
7894         (dwarf2_build_psymtabs_hard): Adjust.
7895
7896 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7897
7898         * dwarf2read.c (create_signatured_type_table_from_debug_names):
7899         Remove unused variables.
7900         (dw2_map_symtabs_matching_filename): Likewise.
7901         (dwarf2_record_block_ranges): Likewise.
7902         (dwarf2_read_addr_index): Likewise.
7903         (follow_die_offset): Likewise.
7904
7905 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7906
7907         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
7908         to symbol_file_add_main.
7909
7910 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7911
7912         PR mi/22299
7913         * mi/mi-console.c (do_fputc_async_safe): New.
7914         (mi_console_file::write_async_safe): New.
7915         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
7916         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
7917         New.
7918         * ui-file.c (ui_file::putstrn): Adjust call to
7919         fputstrn_unfiltered.
7920         * utils.c (printchar): Replace do_fputs and do_fprintf
7921         parameters by do_fputc.
7922         (fputstr_filtered): Adjust call to printchar.
7923         (fputstr_unfiltered): Likewise.
7924         (fputstrn_filtered): Likewise.
7925         (fputstrn_unfiltered): Add do_fputc parameter, pass to
7926         printchar.
7927         * utils.h (do_fputc_ftype): New typedef.
7928         (fputstrn_unfiltered): Add do_fputc parameter.
7929
7930 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7931
7932         * regformats/i386/i386-avx.dat: Remove.
7933
7934 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7935
7936         PR gdb/22979
7937         * amd64-tdep.c (amd64_none_init_abi): New function.
7938         (amd64_x32_none_init_abi): New function.
7939         (_initialize_amd64_tdep): Register handlers for x86-64 and
7940         x64_32 with GDB_OSABI_NONE.
7941         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
7942         GDB_OSABI_NONE osabi.
7943
7944 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7945
7946         PR gdb/22980
7947         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
7948         GDB_OSABI_NONE.
7949         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
7950         * osabi.c (gdb_osabi_names): Add "unknown" entry.
7951
7952 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7953
7954         * common/byte-vector.h (char_vector): New type.
7955         * target.h (target_read_alloc): Return
7956         gdb::optional<byte_vector>.
7957         (target_read_stralloc): Return gdb::optional<char_vector>.
7958         (target_get_osdata): Return gdb::optional<char_vector>.
7959         * target.c (target_read_alloc_1): Templatize.  Replacement
7960         manual memory management with vector.
7961         (target_read_alloc): Change return type, adjust.
7962         (target_read_stralloc): Change return type, adjust.
7963         (target_get_osdata): Change return type, adjust.
7964         * auxv.c (struct auxv_info) <length>: Remove.
7965         <data>: Change type to gdb::optional<byte_vector>.
7966         (auxv_inferior_data_cleanup): Free auxv_info with delete.
7967         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
7968         (target_auxv_search): Adjust.
7969         (fprint_target_auxv): Adjust.
7970         * avr-tdep.c (avr_io_reg_read_command): Adjust.
7971         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
7972         (linux_make_corefile_notes): Adjust.
7973         * osdata.c (get_osdata): Adjust.
7974         * remote.c (remote_get_threads_with_qxfer): Adjust.
7975         (remote_memory_map): Adjust.
7976         (remote_traceframe_info): Adjust.
7977         (btrace_read_config): Adjust.
7978         (remote_read_btrace): Adjust.
7979         (remote_pid_to_exec_file): Adjust.
7980         * solib-aix.c (solib_aix_get_library_list): Adjust.
7981         * solib-dsbt.c (decode_loadmap): Don't free buf.
7982         (dsbt_get_initial_loadmaps): Adjust.
7983         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
7984         * solib-target.c (solib_target_current_sos): Adjust.
7985         * tracepoint.c (sdata_make_value): Adjust.
7986         * xml-support.c (xinclude_start_include): Adjust.
7987         (xml_fetch_content_from_file): Adjust.
7988         * xml-support.h (xml_fetch_another): Change return type.
7989         (xml_fetch_content_from_file): Change return type.
7990         * xml-syscall.c (xml_init_syscalls_info): Adjust.
7991         * xml-tdesc.c (file_read_description_xml): Adjust.
7992         (fetch_available_features_from_target): Change return type.
7993         (target_fetch_description_xml): Adjust.
7994         (target_read_description_xml): Adjust.
7995
7996 2018-04-06  Tom Tromey  <tom@tromey.com>
7997
7998         * value.c (~value): Update.
7999         (struct value) <contents>: Now unique_xmalloc_ptr.
8000         (value_contents_bits_eq, allocate_value_contents)
8001         (value_contents_raw, value_contents_all_raw)
8002         (value_contents_for_printing, value_contents_for_printing_const)
8003         (set_value_enclosing_type): Update.
8004
8005 2018-04-06  Tom Tromey  <tom@tromey.com>
8006
8007         * value.c (range_s): Remove typedef, VEC.
8008         (struct range): Add operator<.
8009         (range_lessthan): Remove.
8010         (ranges_contain): Change type.
8011         (~value): Update.
8012         (struct value) <unavailable, optimized_out>: Now std::vector.
8013         (value_entirely_available)
8014         (value_entirely_covered_by_range_vector)
8015         (value_entirely_unavailable, value_entirely_optimized_out):
8016         Update.
8017         (insert_into_bit_range_vector): Change argument type.
8018         (find_first_range_overlap): Likewise.
8019         (struct ranges_and_idx, value_contents_bits_eq)
8020         (require_not_optimized_out, require_available): Update.
8021         (ranges_copy_adjusted): Change argument types.
8022         (value_optimized_out, value_copy, value_fetch_lazy): Update.
8023
8024 2018-04-06  Tom Tromey  <tom@tromey.com>
8025
8026         * value.c (~value): Update.
8027         (struct value) <parent>: Now a value_ref_ptr.
8028         (value_parent, set_value_parent, value_address, value_copy):
8029         Update.
8030
8031 2018-04-06  Tom Tromey  <tom@tromey.com>
8032
8033         * value.c (struct value): Add constructor, destructor, and member
8034         initializers.
8035         (allocate_value_lazy, value_decref): Update.
8036
8037 2018-04-06  Tom Tromey  <tom@tromey.com>
8038
8039         * value.c (struct value) <released, next>: Remove.
8040         (all_values): Now a std::vector.
8041         (allocate_value_lazy): Update.
8042         (value_next): Remove.
8043         (value_mark, value_free_to_mark, release_value)
8044         (value_release_to_mark): Update.
8045
8046 2018-04-06  Tom Tromey  <tom@tromey.com>
8047
8048         * value.h (fetch_subexp_value, value_release_to_mark): Update.
8049         (free_value_chain): Remove.
8050         * value.c (free_value_chain): Remove.
8051         (value_release_to_mark): Return a std::vector.
8052         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
8053         std::vector.
8054         (check_condition): Update.
8055         * eval.c (fetch_subexp_value): Change "val_chain" to a
8056         std::vector.
8057         * breakpoint.c (update_watchpoint): Update.
8058         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
8059
8060 2018-04-06  Tom Tromey  <tom@tromey.com>
8061
8062         * value.h (free_all_values): Remove.
8063         * value.c (free_all_values): Remove.
8064
8065 2018-04-06  Tom Tromey  <tom@tromey.com>
8066
8067         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
8068         (value_history_chain, value_history_count): Remove.
8069         (value_history): New global.
8070         (record_latest_value, access_value_history, show_values)
8071         (preserve_values): Update.
8072
8073 2018-04-06  Tom Tromey  <tom@tromey.com>
8074
8075         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
8076         * varobj.c (varobj_set_display_format, varobj_set_value)
8077         (install_default_visualizer, construct_visualizer)
8078         (install_new_value, ~varobj, varobj_get_value_type)
8079         (my_value_of_variable, varobj_editable_p): Update.
8080         * c-varobj.c (c_describe_child, c_value_of_variable)
8081         (cplus_number_of_children, cplus_describe_child): Update.
8082         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
8083         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
8084         (ada_value_of_variable, ada_value_is_changeable_p): Update.
8085
8086 2018-04-06  Tom Tromey  <tom@tromey.com>
8087
8088         * printcmd.c (last_examine_address): Change type to
8089         value_ref_ptr.
8090         (do_examine, x_command): Update.
8091
8092 2018-04-06  Tom Tromey  <tom@tromey.com>
8093
8094         * value.c (release_value): Update.
8095         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
8096         (struct bpstats) <val>: Now a value_ref_ptr.
8097         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
8098         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
8099         (~watchpoint, print_it_watchpoint, watch_command_1)
8100         (invalidate_bp_value_on_memory_change): Update.
8101
8102 2018-04-06  Tom Tromey  <tom@tromey.com>
8103
8104         * varobj.c (varobj_clear_saved_item)
8105         (update_dynamic_varobj_children, install_new_value, ~varobj):
8106         Update.
8107         * value.h (value_incref): Move declaration earlier.
8108         (value_decref): Rename from value_free.
8109         (struct value_ref_policy): New.
8110         (value_ref_ptr): New typedef.
8111         (struct value_deleter): Remove.
8112         (gdb_value_up): Remove typedef.
8113         (release_value): Change return type.
8114         (release_value_or_incref): Remove.
8115         * value.c (set_value_parent): Update.
8116         (value_incref): Change return type.
8117         (value_decref): Rename from value_free.
8118         (value_free_to_mark, free_all_values, free_value_chain): Update.
8119         (release_value): Return value_ref_ptr.
8120         (release_value_or_incref): Remove.
8121         (record_latest_value, set_internalvar, clear_internalvar):
8122         Update.
8123         * stack.c (info_frame_command): Don't call value_free.
8124         * python/py-value.c (valpy_dealloc, valpy_new)
8125         (value_to_value_object): Update.
8126         * printcmd.c (do_examine): Update.
8127         * opencl-lang.c (lval_func_free_closure): Update.
8128         * mi/mi-main.c (register_changed_p): Don't call value_free.
8129         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
8130         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
8131         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
8132         value_free.
8133         * guile/scm-value.c (vlscm_free_value_smob)
8134         (vlscm_scm_from_value): Update.
8135         * frame.c (frame_register_unwind, frame_unwind_register_signed)
8136         (frame_unwind_register_unsigned, get_frame_register_bytes)
8137         (put_frame_register_bytes): Don't call value_free.
8138         * findvar.c (address_from_register): Don't call value_free.
8139         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
8140         * dwarf2loc.c (entry_data_value_free_closure)
8141         (value_of_dwarf_reg_entry, free_pieced_value_closure)
8142         (dwarf2_evaluate_loc_desc_full): Update.
8143         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
8144         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
8145         (~watchpoint, watch_command_1)
8146         (invalidate_bp_value_on_memory_change): Update.
8147         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
8148
8149 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
8150
8151         PR gdb/23022
8152         * warning.m4: Add -Wno-error=deprecated-register.
8153         * configure: Re-generate.
8154
8155 2018-04-05  Tom Tromey  <tom@tromey.com>
8156
8157         * linespec.h: Remove include of "vec.h".
8158
8159 2018-04-05  Tom Tromey  <tom@tromey.com>
8160
8161         * linespec.c (typep): Remove typedef.
8162         (find_methods, find_superclass_methods): Take a std::vector.
8163         (find_method): Use std::vector.
8164
8165 2018-04-05  Tom Tromey  <tom@tromey.com>
8166
8167         * utils.c (compare_strings): Remove.
8168         * utils.h (compare_strings): Remove.
8169         * objc-lang.h (find_imps): Update.
8170         * objc-lang.c (find_methods): Take a std::vector.
8171         (uniquify_strings, find_imps): Likewise.
8172         * linespec.c (find_methods): Take a std::vector.
8173         (decode_objc): Use std::vector.
8174         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
8175         a std::vector.
8176         (find_method, find_function_symbols): Use std::vector.
8177
8178 2018-04-05  Tom Tromey  <tom@tromey.com>
8179
8180         * completer.c (completion_tracker::completion_tracker): Remove
8181         cast.
8182         (completion_tracker::discard_completions): Likewise.
8183         * breakpoint.c (ambiguous_names_p): Remove cast.
8184         * ada-lang.c (_initialize_ada_language): Remove cast.
8185         * utils.h (streq): Update.
8186         (streq_hash): Add new declaration.
8187         * utils.c (streq): Return bool.
8188         (streq_hash): New function.
8189
8190 2018-04-05  Tom Tromey  <tom@tromey.com>
8191
8192         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
8193         Remove a string copy.
8194
8195 2018-04-05  Tom Tromey  <tom@tromey.com>
8196
8197         * linespec.c (filter_results): Use std::vector.
8198         (decode_line_2, decode_line_full): Update.
8199
8200 2018-04-05  Tom Tromey  <tom@tromey.com>
8201
8202         * linespec.c (canonical_to_fullform): Return std::string.
8203         (filter_results): Update.
8204         (struct decode_line_2_item): Add constructor.
8205         <fullform, displayform>: Now std::string.
8206         (decode_line_2_compare_items): Now a std::sort comparator.
8207         (decode_line_2): Update.
8208
8209 2018-04-05  Tom Tromey  <tom@tromey.com>
8210
8211         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
8212         (unexpected_linespec_error): Update.
8213         (linespec_parse_basic, parse_linespec): Update.
8214
8215 2018-04-05  Tom Tromey  <tom@tromey.com>
8216
8217         * linespec.c (linespec_parse_basic): Reindent.
8218
8219 2018-04-05  Tom Tromey  <tom@tromey.com>
8220
8221         * minsyms.h (iterate_over_minimal_symbols): Update.
8222         * minsyms.c (iterate_over_minimal_symbols): Take a
8223         gdb::function_view.
8224         * linespec.c (struct collect_minsyms): Remove.
8225         (compare_msyms): Now a std::sort comparator.
8226         (add_minsym): Add parameters.
8227         (search_minsyms_for_name): Update.  Use std::vector.
8228
8229 2018-04-03  Tom Tromey  <tom@tromey.com>
8230
8231         * mipsread.c (read_alphacoff_dynamic_symtab): Use
8232         gdb::byte_vector.
8233
8234 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
8235
8236         * MAINTAINERS (Write After Approval): Add Weimin Pan.
8237
8238 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
8239
8240         PR gdb/16959
8241         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
8242         printing static type.
8243
8244 2018-04-01  Tom Tromey  <tom@tromey.com>
8245
8246         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
8247         (rs6000_xfer_shared_libraries): Update.
8248
8249 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
8250
8251         * common/gdb_vecs.h (char_ptr): Remove.
8252         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
8253
8254 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
8255
8256         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
8257         with std::vector.
8258         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
8259
8260 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
8261
8262         * tracepoint.h (struct uploaded_tp): Initialize fields.
8263         <actions, step_actions, cmd_strings>: Change type to
8264         std::vector<char *>.
8265         * tracepoint.c (get_uploaded_tp): Allocate with new.
8266         (free_uploaded_tps): Free with delete.
8267         (parse_tracepoint_definition): Adjust to std::vector change.
8268         * breakpoint.c (read_uploaded_action): Likewise.
8269         (create_tracepoint_from_upload): Likewise.
8270         * ctf.c (ctf_write_uploaded_tp): Likewise.
8271         (SET_ARRAY_FIELD): Likewise.
8272         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
8273
8274 2018-03-30  Tom Tromey  <tom@tromey.com>
8275
8276         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
8277         std::unique_ptr.
8278         (svr4_keep_data_in_core): Update.
8279         (svr4_read_so_list): Update.
8280
8281 2018-03-30  Tom Tromey  <tom@tromey.com>
8282
8283         * windows-nat.c (handle_output_debug_string, handle_exception):
8284         Update.
8285         * target.h (target_read_string): Update.
8286         * target.c (target_read_string): Change "string" to
8287         unique_xmalloc_ptr.
8288         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
8289         Update.
8290         * solib-frv.c (frv_current_sos): Update.
8291         * solib-dsbt.c (dsbt_current_sos): Update.
8292         * solib-darwin.c (darwin_current_sos): Update.
8293         * linux-thread-db.c (inferior_has_bug): Update.
8294         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
8295         Update.  Remove alloca.
8296         * ada-lang.c (ada_main_name): Update.
8297
8298 2018-03-30  Tom Tromey  <tom@tromey.com>
8299
8300         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
8301         (struct dwo_file_deleter): New.
8302         (dwo_file_up): New typedef.
8303         (open_and_init_dwo_file): Use dwo_file_up.
8304         (free_dwo_file_cleanup): Remove.
8305
8306 2018-03-30  Tom Tromey  <tom@tromey.com>
8307
8308         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
8309         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
8310
8311 2018-03-30  Tom Tromey  <tom@tromey.com>
8312
8313         * dwarf2read.c (class free_cached_comp_units): New class.
8314         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
8315         (free_cached_comp_units): Remove function.
8316
8317 2018-03-30  Tom Tromey  <tom@tromey.com>
8318
8319         * utils.h (make_cleanup_unpush_target): Remove.
8320         * inf-ptrace.c (struct target_unpusher): New.
8321         (target_unpush_up) New typedef.
8322         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
8323         target_unpush_up.
8324         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
8325
8326 2018-03-27  Tom Tromey  <tom@tromey.com>
8327
8328         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
8329
8330 2018-03-27  Pedro Alves  <palves@redhat.com>
8331             Tom Tromey  <tom@tromey.com>
8332
8333         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
8334         destructor.  Now a class.
8335         (gdb_readline_wrapper_cleanup): Remove function.
8336         (gdb_readline_wrapper): Remove cleanups.
8337
8338 2018-03-27  Tom Tromey  <tom@tromey.com>
8339
8340         * typeprint.h (struct type_print_options) <local_typedefs,
8341         global_typedefs>: Remove "struct" keyword.
8342         (class typedef_hash_table): New class.
8343         (recursively_update_typedef_hash, add_template_parameters)
8344         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
8345         (find_typedef_in_hash): Don't declare.
8346         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
8347         (typedef_hash_table::recursively_update): Rename from
8348         recursively_update_typedef_hash.  Now a member.
8349         (typedef_hash_table::add_template_parameters): Rename from
8350         add_template_parameters.  Now a member.
8351         (typedef_hash_table::typedef_hash_table): Now a constructor;
8352         rename from create_typedef_hash.
8353         (typedef_hash_table::~typedef_hash_table): Now a destructor;
8354         rename from free_typedef_hash.
8355         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
8356         (do_free_global_table): Remove.
8357         (typedef_hash_table::typedef_hash_table): New constructor; renamed
8358         from copy_type_recursive.
8359         (create_global_typedef_table): Remove.
8360         (typedef_hash_table::find_global_typedef): Now a member of
8361         typedef_hash_table.
8362         (typedef_hash_table::find_typedef): Rename from
8363         find_typedef_in_hash; now a member.
8364         (whatis_exp): Update.
8365         * extension.h (struct ext_lang_type_printers): Add constructor and
8366         destructor.
8367         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
8368         declare.
8369         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
8370         Now a constructor; rename from start_ext_lang_type_printers.
8371         (ext_lang_type_printers): Now a destructor; rename from
8372         free_ext_lang_type_printers.
8373         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
8374         Update.
8375         (c_type_print_base_struct_union): Update.  Remove cleanups.
8376
8377 2018-03-27  Tom Tromey  <tom@tromey.com>
8378
8379         * dwarf-index-write.c: Include <cmath>.
8380
8381 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
8382
8383         * NEWS: Add entry describing new "set|show varsize-limit" command.
8384         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
8385         command.
8386         * printcmd.c (_initialize_printcmd): Add "set var" alias of
8387         "set variable".
8388
8389 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
8390
8391         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
8392         dwarf-index-write.c
8393         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
8394         * dwarf-index-common.c: New file.
8395         * dwarf-index-common.h: New file.
8396         * dwarf-index-write.c: New file.
8397         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
8398         (struct dwarf2_section_info): Move from here.
8399         (dwarf2_section_info_def): Likewise.
8400         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
8401         (offset_type): Likewise.
8402         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
8403         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
8404         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
8405         (byte_swap): Likewise.
8406         (MAYBE_SWAP): Likewise.
8407         (dwarf2_per_cu_ptr): Likewise.
8408         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
8409         (struct tu_stats): Likewise.
8410         (struct dwarf2_per_objfile): Likewise.
8411         (struct dwarf2_per_cu_data): Likewise.
8412         (struct signatured_type): Likewise.
8413         (sig_type_ptr): Likewise.
8414         (DEF_VEC_P (sig_type_ptr)): Likewise.
8415         (INDEX4_SUFFIX): Likewise.
8416         (INDEX5_SUFFIX): Likewise.
8417         (DEBUG_STR_SUFFIX): Likewise.
8418         (dwarf2_read_section): Make non-static.
8419         (mapped_index_string_hash): Move from here.
8420         (dwarf5_djb_hash): Likewise.
8421         (file_write): Likewise.
8422         (class data_buf): Likewise.
8423         (struct symtab_index_entry): Likewise.
8424         (struct mapped_symtab): Likewise.
8425         (find_slot): Likewise.
8426         (hash_expand): Likewise.
8427         (add_index_entry): Likewise.
8428         (uniquify_cu_indices): Likewise.
8429         (class c_str_view): Likewise.
8430         (class c_str_view_hasher): Likewise.
8431         (class vector_hasher): Likewise.
8432         (write_hash_table): Likewise.
8433         (psym_index_map): Likewise.
8434         (struct addrmap_index_data): Likewise.
8435         (add_address_entry): Likewise.
8436         (add_address_entry_worker): Likewise.
8437         (write_address_map): Likewise.
8438         (symbol_kind): Likewise.
8439         (write_psymbols): Likewise.
8440         (struct signatured_type_index_data): Likewise.
8441         (write_one_signatured_type): Likewise.
8442         (recursively_count_psymbols): Likewise.
8443         (recursively_write_psymbols): Likewise.
8444         (class debug_names): Likewise.
8445         (check_dwarf64_offsets): Likewise.
8446         (psyms_seen_size): Likewise.
8447         (write_gdbindex): Likewise.
8448         (write_debug_names): Likewise.
8449         (assert_file_size): Likewise.
8450         (write_psymtabs_to_index): Likewise.
8451         (save_gdb_index_command): Likewise.
8452         (_initialize_dwarf2_read): Don't register the "save gdb-index"
8453         command.
8454         * dwarf2read.h: New file.
8455
8456 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
8457
8458         PR gdb/22670
8459         * dwarf2read.c (dwarf2_physname): Do not return the demangled
8460         symbol name if the CU's language stores symbol names in linkage
8461         format.
8462         * language.h (struct language_defn)
8463         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
8464         all instances of this struct.
8465
8466 2018-03-26  Tom Tromey  <tom@tromey.com>
8467
8468         * stack.c (backtrace_command_1): Remove verbose code.
8469
8470 2018-03-26  Tom Tromey  <tom@tromey.com>
8471
8472         * python/py-framefilter.c (py_print_type): Don't catch
8473         exceptions.  Return void.
8474         (py_print_value): Likewise.
8475         (py_print_single_arg): Likewise.
8476         (enumerate_args): Don't catch exceptions.
8477         (py_print_args): Likewise.
8478         (py_print_frame): Likewise.
8479         (gdbpy_apply_frame_filter): Catch exceptions here.
8480
8481 2018-03-26  Tom Tromey  <tom@tromey.com>
8482
8483         * stack.c (_initialize_stack): Remove trailing newlines from help
8484         text.  Add "Usage" line to "backtrace" help.
8485
8486 2018-03-26  Tom Tromey  <tom@tromey.com>
8487
8488         PR python/16486:
8489         * python/py-framefilter.c (py_print_args): Call wrap_hint.
8490
8491 2018-03-26  Tom Tromey  <tom@tromey.com>
8492
8493         * python/py-framefilter.c (py_print_single_arg): Return
8494         EXT_LANG_BT_ERROR from catch.
8495
8496 2018-03-26  Tom Tromey  <tom@tromey.com>
8497
8498         PR backtrace/15584:
8499         * stack.c (backtrace_command_1): Move some code into no-filters
8500         "if".
8501
8502 2018-03-26  Tom Tromey  <tom@tromey.com>
8503
8504         * python/py-framefilter.c (throw_quit_or_print_exception): New
8505         function.
8506         (gdbpy_apply_frame_filter): Use it.
8507
8508 2018-03-26  Tom Tromey  <tom@tromey.com>
8509
8510         PR cli/17716:
8511         * python/py-framefilter.c (py_print_type, py_print_value)
8512         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
8513         RETURN_MASK_ERROR.
8514
8515 2018-03-26  Tom Tromey  <tom@tromey.com>
8516
8517         * python/py-framefilter.c (enumerate_args): Use
8518         gdb::unique_xmalloc_ptr.
8519
8520 2018-03-26  Tom Tromey  <tom@tromey.com>
8521
8522         * python/py-framefilter.c (py_print_frame): Return
8523         EXT_LANG_BT_OK.
8524         (gdbpy_apply_frame_filter): Update comment.
8525         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
8526         Remove.
8527         <EXT_LANG_BT_NO_FILTERS>: Change value.
8528
8529 2018-03-26  Tom Tromey  <tom@tromey.com>
8530
8531         PR backtrace/15582:
8532         * stack.c (backtrace_command): Parse "hide" argument.
8533         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
8534         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
8535         constant.
8536
8537 2018-03-26  Tom Tromey  <tom@tromey.com>
8538
8539         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
8540         add "flags".
8541         (backtrace_command): Remove "fulltrace", add "flags".
8542
8543 2018-03-26  Tom Tromey  <tom@tromey.com>
8544
8545         * stack.c (backtrace_command): Rewrite command line parsing.
8546
8547 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
8548
8549         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
8550
8551 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
8552
8553         * filename-seen-cache.h: Add include guard.
8554
8555 2018-03-26  Keith Seitz  <keiths@redhat.com>
8556
8557         * symfile.c (place_section): Remove "struct" from section_addr_info
8558         in comment.
8559         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
8560         "struct" keyword from section_addr_info.
8561
8562 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
8563
8564         * regformats/regdef.h (reg): Add constructors.
8565
8566 2018-03-25  Pedro Alves  <palves@redhat.com>
8567
8568         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
8569         if then/else bodies in var_func_name extraction.
8570
8571 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
8572
8573         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
8574         lookup_minimal_symbol() to find symbol entry.
8575         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
8576
8577 2018-03-23  Keith Seitz  <keiths@redhat.com>
8578
8579         PR c++/22968
8580         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
8581         nested type definitions for C++, too.
8582
8583 2018-03-23  Tom Tromey  <tom@tromey.com>
8584
8585         * machoread.c (struct oso_el): Add a constructor.  Don't define as
8586         a typedef.
8587         (macho_register_oso): Remove.
8588         (macho_symtab_read): Take a std::vector.
8589         (oso_el_compare_name): Now a std::sort comparator.
8590         (macho_symfile_read_all_oso): Take a std::vector.
8591         (macho_symfile_read): Use std::vector.  Remove cleanups.
8592
8593 2018-03-22  Tom Tromey  <tom@tromey.com>
8594
8595         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
8596         (record_full_goto_bookmark): Use std::string.
8597
8598 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8599
8600         PR tdep/18295
8601         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
8602         a single mask.
8603
8604 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8605
8606         * rs6000-tdep.c (store_insn_p): New function.
8607         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
8608         and cr_reg to their unshifted values. Use store_insn_p to
8609         match LR saves using either R1 or fdata->alloca_reg. Use
8610         store_insn_p to match CR saves. Set alloca_reg_offset
8611         when alloca_reg and framep are set. Remove lr_reg shift
8612         when assigning to fdata->lr_register.
8613
8614 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
8615
8616         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
8617         command line args instead of emitting a warning.
8618
8619 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
8620
8621         * tracepoint.h (struct static_tracepoint_marker): Initialize
8622         fields, define default constructor, move constructor and move
8623         assignment, disable the rest.
8624         <str_id, extra>: Make std::string.
8625         (release_static_tracepoint_marker): Remove.
8626         (free_current_marker): Remove.
8627         * tracepoint.c (free_current_marker): Remove.
8628         (parse_static_tracepoint_marker_definition): Adjust to
8629         std::string, use new hex2str overload.
8630         (release_static_tracepoint_marker): Remove.
8631         (print_one_static_tracepoint_marker): Get marker by reference
8632         and adjust to std::string.
8633         (info_static_tracepoint_markers_command): Adjust to std::vector
8634         changes
8635         * target.h (static_tracepoint_marker_p): Remove typedef.
8636         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
8637         (struct target_ops) <to_static_tracepoint_marker_at>: Return
8638         bool.
8639         <to_static_tracepoint_markers_by_strid>: Return std::vector.
8640         * target-debug.h
8641         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
8642         (target_debug_print_std_vector_static_tracepoint_marker): New.
8643         (target_debug_print_struct_static_tracepoint_marker_p): Rename
8644         to...
8645         (target_debug_print_static_tracepoint_marker_p): ... this.
8646         * target-delegates.c: Re-generate.
8647         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
8648         Make std::string.
8649         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
8650         (decode_static_tracepoint_spec): Adjust to std::vector.
8651         (tracepoint_print_one_detail): Adjust to std::string.
8652         (strace_marker_decode_location): Adjust to std::string.
8653         (update_static_tracepoint): Adjust to std::string, remove call
8654         to release_static_tracepoint_marker.
8655         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
8656         Adjust to std::vector.
8657         * remote.c (remote_static_tracepoint_marker_at): Return bool.
8658         (remote_static_tracepoint_markers_by_strid): Adjust to
8659         std::vector.
8660         * common/rsp-low.h (hex2str): New overload with explicit count
8661         of bytes.
8662         * common/rsp-low.c (hex2str): New overload with explicit count
8663         of bytes.
8664         * unittests/rsp-low-selftests.c (test_hex2str): New function.
8665         (_initialize_rsp_low_selftests): Add test_hex2str test.
8666         * unittests/tracepoint-selftests.c
8667         (test_parse_static_tracepoint_marker_definition): Adjust to
8668         std::string.
8669
8670 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
8671
8672         * tracepoint.c (parse_static_tracepoint_marker_definition):
8673         Consider case where the definition is followed by more
8674         definitions.
8675         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8676         tracepoint-selftests.c.
8677         * unittests/tracepoint-selftests.c: New.
8678
8679 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8680
8681         * MAINTAINERS (Write After Approval): Add Pedro Franco de
8682         Carvalho.
8683
8684 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
8685
8686         * symtab.c (find_pc_sect_line): fixed indentation.
8687
8688 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
8689
8690         * symtab.c (find_pc_sect_line): now uses binary search.
8691
8692 2018-03-19  Tom Tromey  <tom@tromey.com>
8693
8694         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
8695         "IDENT" production.
8696
8697 2018-03-19  Pedro Alves  <palves@redhat.com>
8698             Tom Tromey  <tom@tromey.com>
8699
8700         * unittests/observable-selftests.c: New file.
8701         * common/observable.h: New file.
8702         * observable.h: New file.
8703         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
8704         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
8705         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
8706         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
8707         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
8708         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
8709         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
8710         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
8711         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
8712         python/py-breakpoint.c, python/py-finishbreakpoint.c,
8713         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
8714         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
8715         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
8716         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
8717         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
8718         tui/tui-interp.c, valops.c: Update all users.
8719         * tui/tui-hooks.c (tui_bp_created_observer)
8720         (tui_bp_deleted_observer, tui_bp_modified_observer)
8721         (tui_inferior_exit_observer, tui_before_prompt_observer)
8722         (tui_normal_stop_observer, tui_register_changed_observer):
8723         Remove.
8724         (tui_observers_token): New global.
8725         (attach_or_detach, tui_attach_detach_observers): New functions.
8726         (tui_install_hooks, tui_remove_hooks): Use
8727         tui_attach_detach_observers.
8728         * record-btrace.c (record_btrace_thread_observer): Remove.
8729         (record_btrace_thread_observer_token): New global.
8730         * observer.sh: Remove.
8731         * observer.c: Rename to observable.c.
8732         * observable.c (namespace gdb_observers): Define new objects.
8733         (observer_debug): Move into gdb_observers namespace.
8734         (struct observer, struct observer_list, xalloc_observer_list_node)
8735         (xfree_observer_list_node, generic_observer_attach)
8736         (generic_observer_detach, generic_observer_notify): Remove.
8737         (_initialize_observer): Update.
8738         Don't include observer.inc.
8739         * Makefile.in (generated_files): Remove observer.h, observer.inc.
8740         (clean mostlyclean): Likewise.
8741         (observer.h, observer.inc): Remove targets.
8742         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
8743         (COMMON_SFILES): Use observable.c, not observer.c.
8744         * .gitignore: Remove observer.h.
8745
8746 2018-03-18  Tom Tromey  <tom@tromey.com>
8747
8748         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
8749         gdb::def_vector.
8750         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
8751
8752 2018-03-17  Tom Tromey  <tom@tromey.com>
8753
8754         * auto-load.c (auto_load_objfile_script_1): Use std::string.
8755
8756 2018-03-17  Tom Tromey  <tom@tromey.com>
8757
8758         * target.c (class scoped_target_fd): New.
8759         (target_fileio_close_cleanup): Remove.
8760         (target_fileio_read_alloc_1): Use scoped_target_fd.
8761
8762 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
8763
8764         * silent-rules.mk: New.
8765         * Makefile.in: Include silent-rules.mk
8766         (srcdir, VPATH, top_srcdir): Move up.
8767         (COMPILE): Add ECHO_CXX.
8768         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
8769         (init.c): Add ECHO_INIT_C.
8770         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
8771         (version.c): Add ECHO_GEN.
8772         (printcmd.o): Add ECHO_CXX.
8773         (target-float.o): Add ECHO_CXX.
8774         (ada-exp.o): Add ECHO_CXX.
8775         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
8776         (insight$(EXEEXT)): Add ECHO_CXXLD.
8777         * gnulib/configure.ac: Add AM_SILENT_RULES.
8778         * gnulib/aclocal.m4: Re-generate.
8779         * gnulib/configure: Re-generate.
8780         * gnulib/import/Makefile.in: Re-generate.
8781
8782 2018-03-16  Tom Tromey  <tom@tromey.com>
8783
8784         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
8785         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
8786         * utils.c (do_free_section_addr_info)
8787         (make_cleanup_free_section_addr_info): Remove.
8788         * symfile.h (struct other_sections): Add constructor.
8789         (struct section_addr_info): Remove.
8790         (section_addr_info): New typedef.
8791         (struct sym_fns) <sym_offsets>: Change type of parameter.
8792         (build_section_addr_info_from_objfile)
8793         (relative_addr_info_to_section_offsets, addr_info_make_relative)
8794         (default_symfile_offsets, symbol_file_add)
8795         (symbol_file_add_from_bfd)
8796         (build_section_addr_info_from_section_table): Update.
8797         (alloc_section_addr_info, free_section_addr_info): Don't declare.
8798         * symfile.c (alloc_section_addr_info): Remove.
8799         (build_section_addr_info_from_section_table): Change return type.
8800         Update.
8801         (build_section_addr_info_from_bfd)
8802         (build_section_addr_info_from_objfile): Likewise.
8803         (free_section_addr_info): Remove.
8804         (relative_addr_info_to_section_offsets): Change type of "addrs".
8805         (addrs_section_compar): Now a std::sort comparator.
8806         (addrs_section_sort): Change return type.
8807         (addr_info_make_relative): Change type of "addrs".  Update.
8808         (default_symfile_offsets, syms_from_objfile_1)
8809         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
8810         (symbol_file_add_separate): Update.
8811         (symbol_file_add): Change type of "addrs".  Update.
8812         (add_symbol_file_command): Update.  Remove cleanups.
8813         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
8814         cleanups.
8815         * symfile-debug.c (debug_sym_offsets): Change type of "info".
8816         * solib.c (solib_read_symbols): Update.
8817         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
8818         * machoread.c (macho_symfile_offsets): Update.
8819         * jit.c (jit_bfd_try_read_symtab): Update.
8820
8821 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
8822
8823         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8824         unittests/utils-selftests.c.
8825         * unittests/utils-selftests.c: New file.
8826
8827 2018-03-14  Tom Tromey  <tom@tromey.com>
8828
8829         PR cli/14977:
8830         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
8831         for NULL.
8832
8833 2018-03-14  Tom Tromey  <tom@tromey.com>
8834
8835         PR cli/19918:
8836         * printcmd.c (printf_pointer): Allow "-" in format.
8837
8838 2018-03-14  Tom Tromey  <tom@tromey.com>
8839
8840         * printcmd.c (_initialize_printcmd): Add usage to printf.
8841
8842 2018-03-14  Yao Qi  <qiyao@sourceware.org>
8843
8844         * MAINTAINERS: Update my email address.
8845
8846 2018-03-13  Tom Tromey  <tom@tromey.com>
8847
8848         * machoread.c (macho_check_dsym): Change filenamep to a
8849         std::string*.
8850         (macho_symfile_read): Update.
8851         * symfile.c (load_command): Use std::string.
8852
8853 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8854
8855         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
8856         to error message string.
8857         (riscv_register_name): Use xsnprintf instead of sprintf.
8858         (riscv_insn::fetch_instruction): Use gdb_assert instead of
8859         internal_error.
8860         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
8861         error.
8862         (riscv_push_dummy_call): Likewise.
8863
8864 2018-03-12  Tom Tromey  <tom@tromey.com>
8865
8866         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
8867         Use gdb::byte_vector.
8868         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
8869
8870 2018-03-12  Yao Qi  <yao.qi@linaro.org>
8871
8872         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
8873         parameter type to readable_regcache.
8874         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
8875         the declaration.
8876
8877 2018-03-11  Tom Tromey  <tom@tromey.com>
8878
8879         * dwarf2read.c (struct nextfield): Add initializers.
8880         (struct nextfnfield): Remove.
8881         (struct fnfieldlist): Add initializers.  Remove "length" and
8882         "head", use std::vector.
8883         (struct decl_field_list): Remove.
8884         (struct field_info): Add initializers.
8885         <fields, baseclasses>: Now std::vector.
8886         <nbaseclasses, nfnfields, typedef_field_list_count,
8887         nested_types_list_count>: Remove.
8888         (dwarf2_add_field, dwarf2_add_type_defn)
8889         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
8890         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
8891         (process_structure_scope): Update.
8892
8893 2018-03-11  Tom Tromey  <tom@tromey.com>
8894
8895         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
8896         for use by std::sort.
8897         (build_type_psymtabs_1): Use std::vector.
8898
8899 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
8900
8901         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
8902         and LIBMPFR in the printed configuration.
8903
8904 2018-03-08  Tom Tromey  <tom@tromey.com>
8905
8906         * source.c (get_filename_and_charpos): Use scoped_fd.
8907         * nto-procfs.c (procfs_open_1): Use scoped_fd.
8908         (procfs_pidlist): Likewise.
8909         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
8910         (iterate_over_mappings): Likewise.
8911
8912 2018-03-08  Tom Tromey  <tom@tromey.com>
8913
8914         * infcall.c (struct call_return_meta_info)
8915         <stack_temporaries_enabled>: Remove.
8916         (get_call_return_value, call_function_by_hand_dummy): Update.
8917         * thread.c (disable_thread_stack_temporaries): Remove.
8918         (enable_thread_stack_temporaries): Remove.
8919         (thread_stack_temporaries_enabled_p): Return bool.
8920         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
8921         (get_last_thread_stack_temporary): Update.
8922         * eval.c (evaluate_subexp): Update.
8923         * gdbthread.h (class enable_thread_stack_temporaries): Now a
8924         class, not a function.
8925         (value_ptr, value_vec): Remove typedefs.
8926         (class thread_info) <stack_temporaries_enabled>: Now bool.
8927         <stack_temporaries>: Now a std::vector.
8928         (thread_stack_temporaries_enabled_p)
8929         (value_in_thread_stack_temporaries): Return bool.
8930
8931 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
8932
8933         * remote.c (putpkt_binary): Fix omitted bytes reporting.
8934         (getpkt_or_notif_sane_1): Likewise.
8935
8936 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8937
8938         * build-id.c (build_id_to_debug_bfd): Use std::string.
8939
8940 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8941
8942         * build-id.c (find_separate_debug_file_by_buildid): Return
8943         std::string.
8944         * build-id.h (find_separate_debug_file_by_buildid): Return
8945         std::string.
8946         * coffread.c (coff_symfile_read): Adjust to std::string.
8947         * elfread.c (elf_symfile_read): Adjust to std::string.
8948         * symfile.c (separate_debug_file_exists): Change parameter to
8949         std::string.
8950         (find_separate_debug_file): Return std::string.
8951         (find_separate_debug_file_by_debuglink): Return std::string.
8952         * symfile.h (find_separate_debug_file_by_debuglink): Return
8953         std::string.
8954
8955 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8956
8957         * common/xml-utils.c (xml_escape_text): Move code to...
8958         (xml_escape_text_append): ... this new function.
8959         * common/xml-utils.h (xml_escape_text_append): New declaration.
8960         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
8961         New function.
8962         (_initialize_xml_utils): register test_xml_escape_text_append as
8963         a selftest.
8964
8965 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
8966
8967         * defs.h: Remove MAX_REGISTER_SIZE.
8968         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
8969         asserts.
8970         * python/py-unwind.c (pyuw_sniffer): Likewise.
8971
8972 2018-03-07  Tom Tromey  <tom@tromey.com>
8973
8974         * linux-tdep.c (linux_info_proc): Update.
8975         * target.h (struct target_ops) <to_fileio_readlink>: Return
8976         optional<string>.
8977         (target_fileio_readlink): Return optional<string>.
8978         * remote.c (remote_hostio_readlink): Return optional<string>.
8979         * inf-child.c (inf_child_fileio_readlink): Return
8980         optional<string>.
8981         * target.c (target_fileio_readlink): Return optional<string>.
8982
8983 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8984
8985         * regcache.c (cooked_read_test): Add riscv to the list of
8986         architectures that have a save_reggroup.
8987
8988 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
8989
8990         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
8991         value is not a dynamic class object.
8992
8993 2018-03-06  Tom Tromey  <tom@tromey.com>
8994
8995         * rust-exp.y: Formatting fixes.
8996
8997 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * riscv-tdep.c (riscv_register_name): Remove target description
9000         support.
9001         (riscv_gdbarch_init): Remove target description check.
9002
9003 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9004
9005         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
9006         comment.
9007         * riscv-tdep.h: Likewise.
9008
9009 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9010
9011         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
9012         (riscv_pseudo_register_write): Delete.
9013         (riscv_gdbarch_init): Remove all use of pseudo registers.
9014
9015 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
9016
9017         * record-btrace.c (btrace_print_lines): Replace cleanup
9018         parameter with RAII equivalents.
9019         (btrace_insn_history): Replace cleanup with RAII equivalents.
9020         * ui-out.h (make_cleanup_ui_out_list_begin_end,
9021         make_cleanup_ui_out_tuple_begin_end): Remove.
9022         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
9023         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
9024         make_cleanup_ui_out_list_begin_end): Remove.
9025
9026 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
9027
9028         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
9029         parameter types to std::vector.  Use bool.
9030         (record_btrace_wait): Replace VEC(tp_t) with
9031         std::vector<thread_info *>.
9032         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
9033
9034 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
9035
9036         * record-btrace.c (record_btrace_disable_callback): Remove.
9037         (struct scoped_btrace_disable): New.
9038         (record_btrace_open): Use scoped_btrace_disable.
9039
9040 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9041
9042         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
9043         reading values from registers.
9044
9045 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9046
9047         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
9048         where appropriate.
9049
9050 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9051
9052         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
9053         change parameter type.  Use GDB's print functions, and use
9054         core_addr_to_string where appropriate.
9055         (riscv_push_dummy_call): Use core_addr_to_string where
9056         appropriate, update call to riscv_print_arg_location, and reindent
9057         a few lines.
9058         (riscv_return_value): Update call to riscv_print_arg_location.
9059
9060 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9061             Tim Newsome <tim@sifive.com>
9062             Albert Ou <a0u@eecs.berkeley.edu>
9063             Darius Rad <darius@bluespec.com>
9064
9065         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
9066         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
9067         (ALLDEPFILES): Add riscv-tdep.c
9068         * configure.tgt: Add riscv support.
9069         * riscv-tdep.c: New file.
9070         * riscv-tdep.h: New file.
9071         * NEWS: Mention new target.
9072         * MAINTAINERS: Add entry for riscv.
9073
9074 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9075
9076         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
9077         fields within aggregates.
9078
9079 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
9080
9081         * record-btrace.c (btrace_print_lines): Change type of flags to
9082         gdb_disassembly_flags.
9083
9084 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
9085
9086         * fbsd-nat.c: Include "inf-ptrace.h".
9087         (USE_SIGTRAP_SIGINFO): Conditionally define.
9088         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
9089         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
9090         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
9091         function.
9092         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
9093         Likewise.
9094         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
9095         Likewise.
9096         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
9097         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
9098         "supports_stopped_by_hw_breakpoint" target methods.
9099
9100 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
9101
9102         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
9103         * fbsd-nat.c (debug_fbsd_nat): New variable.
9104         (show_fbsd_nat_debug): New function.
9105         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
9106         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
9107
9108 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
9109
9110         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
9111         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
9112         prototype.
9113         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
9114         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
9115         method.
9116
9117 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
9118
9119         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
9120         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
9121
9122 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
9123
9124         * charset.c (struct charset_vector): New.
9125         (charsets): Change type to charset_vector.
9126         (find_charset_names): Adjust.
9127         (add_one): Adjust.
9128         (_initialize_charset): Adjust.
9129
9130 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
9131
9132         * progspace.h (struct program_space) <deleted_solibs>: Change
9133         type to std::vector<std::string>.
9134         * progspace.c (clear_program_space_solib_cache): Adjust.
9135         * breakpoint.c (print_solib_event): Adjust.
9136         (check_status_catch_solib): Adjust.
9137         * solib.c (update_solib_list): Adjust.
9138         * ui-out.h (class ui_out) <field_string>: New overload.
9139         * ui-out.c (ui_out::field_string): New overload.
9140
9141 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
9142
9143         * progspace.h (struct program_space): Add constructor and
9144         destructor, initialize fields.
9145         (add_program_space): Remove.
9146         * progspace.c (add_program_space): Rename to...
9147         (program_space::program_space): ... this.
9148         (release_program_space): Rename to...
9149         (program_space::~program_space): ... this.
9150         (delete_program_space): Use delete to delete program_space.
9151         (initialize_progspace): Use new to allocate program_space.
9152         * inferior.c (add_inferior_with_spaces): Likewise.
9153         (clone_inferior_command): Likewise.
9154         * infrun.c (follow_fork_inferior): Likewise.
9155         (handle_vfork_child_exec_or_exit): Likewise.
9156
9157 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
9158
9159         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
9160         (delim_string_to_char_ptr_vec): Return std::vector of
9161         gdb::unique_xmalloc_ptr.
9162         (dirnames_to_char_ptr_vec_append): Take std::vector of
9163         gdb::unique_xmalloc_ptr.
9164         (dirnames_to_char_ptr_vec): Return std::vector of
9165         gdb::unique_xmalloc_ptr.
9166         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
9167         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
9168         (delim_string_to_char_ptr_vec): Return an std::vector of
9169         gdb::unique_xmalloc_ptr, adjust the code.
9170         (dirnames_to_char_ptr_vec_append): Take an std::vector of
9171         gdb::unique_xmalloc_ptr, adjust the code.
9172         (dirnames_to_char_ptr_vec): Return an std::vector of
9173         gdb::unique_xmalloc_ptr, adjust the code.
9174         * auto-load.c (auto_load_safe_path_vec): Change type to
9175         std::vector of gdb::unique_xmalloc_ptr.
9176         (auto_load_expand_dir_vars): Return an std::vector of
9177         gdb::unique_xmalloc_ptr, adjust the code.
9178         (auto_load_safe_path_vec_update): Adjust.
9179         (filename_is_in_auto_load_safe_path_vec): Adjust.
9180         (auto_load_objfile_script_1): Adjust.
9181         * build-id.c (build_id_to_debug_bfd): Adjust.
9182         * linux-thread-db.c (thread_db_load_search): Adjust.
9183         * source.c (add_path): Adjust.
9184         (openp): Adjust.
9185         * symfile.c (find_separate_debug_file): Adjust.
9186         * utils.c (do_free_char_ptr_vec): Remove.
9187         (make_cleanup_free_char_ptr_vec): Remove.
9188
9189 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9190
9191         PR gdb/22907
9192         * common/pathstuff.c: Conditionally include "<windows.h>".
9193
9194 2018-03-01  Georg Sauthoff  <mail@georg.so>
9195
9196         PR gdb/22888
9197         * gcore.in: Quote variables and switch interpreter to bash.
9198
9199 2018-03-01  Tom Tromey  <tom@tromey.com>
9200
9201         * dwarf2read.c (alloc_discriminant_info): Fix default_index
9202         assertion.  Add assertion for discriminant_index.
9203         (quirk_rust_enum): Use correct base type name in univariant case.
9204
9205 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
9206
9207         * record.c (get_call_history_modifiers): Return a
9208         record_print_flags.
9209         (cmd_record_call_history): Adjust.
9210         * record-btrace.c (record_btrace_call_history): Adjust.
9211         (record_btrace_call_history_range): Adjust.
9212         (record_btrace_call_history_from): Adjust.
9213         * target-debug.h (target_debug_print_record_print_flags): New.
9214         * target-delegates.c: Re-generate.
9215         * target.c (target_call_history): Change flags type.
9216         (target_call_history_from): Likewise.
9217         (target_call_history_range): Likewise.
9218         * target.h (struct target_ops) <target_call_history>: Likewise.
9219         (target_call_history_from): Likewise.
9220         (target_call_history_range): Likewise.
9221
9222 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
9223             Simon Marchi  <simon.marchi@polymtl.ca>
9224
9225         * common/common-utils.c: Include "sys/stat.h".
9226         (is_regular_file): Move here from "source.c"; change return
9227         type to "bool".
9228         * common/common-utils.h (is_regular_file): New prototype.
9229         * common/pathstuff.c (contains_dir_separator): New function.
9230         * common/pathstuff.h (contains_dir_separator): New prototype.
9231         * source.c: Don't include "sys/stat.h".
9232         (is_regular_file): Move to "common/common-utils.c".
9233
9234 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
9235
9236         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
9237         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
9238         * auto-load.c: Include "common/pathstuff.h".
9239         * common/common-def.h (current_directory): Move here.
9240         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
9241         function.
9242         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
9243         prototype.
9244         * common/pathstuff.c: New file.
9245         * common/pathstuff.h: New file.
9246         * compile/compile.c: Include "common/pathstuff.h".
9247         * defs.h (current_directory): Move to "common/common-defs.h".
9248         * dwarf2read.c: Include "common/pathstuff.h".
9249         * exec.c: Likewise.
9250         * guile/scm-safe-call.c: Likewise.
9251         * linux-thread-db.c: Likewise.
9252         * main.c: Likewise.
9253         * nto-tdep.c: Likewise.
9254         * objfiles.c: Likewise.
9255         * source.c: Likewise.
9256         * symtab.c: Likewise.
9257         * utils.c: Include "common/pathstuff.h".
9258         (gdb_realpath): Move to "common/pathstuff.c".
9259         (gdb_realpath_keepfile): Likewise.
9260         (gdb_abspath): Likewise.
9261         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
9262         (gdb_realpath_keepfile): Likewise.
9263         (gdb_abspath): Likewise.
9264
9265 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
9266
9267         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
9268         wildcard process pid for super_resume for kernels with a
9269         specific bug.
9270
9271 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
9272
9273         * compile/compile.c (get_args): Add additional comments
9274         explaining function.
9275
9276 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
9277             Tom Tromey  <tom@tromey.com>
9278
9279         * target.h (memory_write_request_s): Remove typedef.  Don't define
9280         VEC.
9281         (target_write_memory_blocks): Change argument to std::vector.
9282         (struct memory_write_request): Add constructor.
9283         * target-memory.c (compare_block_starting_address): Return bool.
9284         Change argument types.
9285         (claim_memory): Change arguments to use std::vector.
9286         (split_regular_and_flash_blocks, blocks_to_erase)
9287         (compute_garbled_blocks): Likewise.
9288         (cleanup_request_data, cleanup_write_requests_vector): Remove.
9289         (target_write_memory_blocks): Change argument to std::vector.
9290         * symfile.c (struct load_section_data): Add constructor and
9291         destructor.  Use std::vector for "requests".
9292         (struct load_progress_data): Add initializers.
9293         (load_section_callback): Update.  Use "new".
9294         (clear_memory_write_data): Remove.
9295         (generic_load): Update.
9296
9297 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
9298
9299         * arch/aarch64.h: Use common/tdesc.h.
9300
9301 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
9302
9303         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
9304         architecture with a 64-bit ABI.
9305
9306 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
9307
9308         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
9309         ahead of target description loading.
9310
9311 2018-02-26  Tom Tromey  <tom@tromey.com>
9312
9313         * stack.c (backtrace_command_1): Update.
9314         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
9315         of "flags".
9316         * python/py-framefilter.c (py_print_frame)
9317         (gdbpy_apply_frame_filter): Change type of "flags".
9318         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
9319         of "flags".
9320         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
9321         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
9322         * extension.h (enum frame_filter_flag): Rename from
9323         frame_filter_flags.
9324         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
9325         (apply_ext_lang_frame_filter): Change type of "flags".
9326         * extension.c (apply_ext_lang_frame_filter): Change type of
9327         "flags".
9328         * extension-priv.h (struct extension_language_ops)
9329         <apply_frame_filter>: Change type of "flags".
9330
9331 2018-02-26  Tom Tromey  <tom@tromey.com>
9332
9333         PR python/16497:
9334         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
9335         off-by-one in py_end computation.
9336         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
9337         PRINT_MORE_FRAMES.
9338         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
9339         constant.
9340
9341 2018-02-26  Tom Tromey  <tom@tromey.com>
9342
9343         * dwarf2read.c (struct variant_field): New.
9344         (struct nextfield) <variant>: New field.
9345         (dwarf2_add_field): Handle DW_TAG_variant_part.
9346         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
9347         discriminated union.
9348         (read_structure_type): Handle DW_TAG_variant_part.
9349         (handle_struct_member_die): New function, extracted from
9350         process_structure_scope.  Handle DW_TAG_variant.
9351         (process_structure_scope): Handle discriminated unions.  Call
9352         handle_struct_member_die.
9353
9354 2018-02-26  Tom Tromey  <tom@tromey.com>
9355
9356         * rust-lang.h (rust_last_path_segment): Declare.
9357         * rust-lang.c (rust_last_path_segment): Now public.  Change
9358         contract.
9359         (struct disr_info): Remove.
9360         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
9361         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
9362         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
9363         (rust_enum_p, rust_enum_variant): New function.
9364         (rust_underscore_fields): Remove "offset" parameter.
9365         (rust_print_enum): New function.
9366         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
9367         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
9368         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
9369         enums.
9370         (rust_internal_print_type): New function, from rust_print_type.
9371         Remove enum code.
9372         (rust_print_type): Call rust_internal_print_type.
9373         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
9374         Update enum handling.
9375         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
9376         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
9377         (rust_union_quirks): New functions.
9378         (process_full_comp_unit, process_full_type_unit): Call
9379         rust_union_quirks.
9380         (process_structure_scope): Update rust_unions if necessary.
9381
9382 2018-02-26  Tom Tromey  <tom@tromey.com>
9383
9384         * value.h (value_union_variant): Declare.
9385         * valops.c (value_union_variant): New function.
9386         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
9387         (struct discriminant_info): New.
9388         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
9389         enumerator.
9390         (struct main_type) <flag_discriminated_union>: New field.
9391
9392 2018-02-26  Tom Tromey  <tom@tromey.com>
9393
9394         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9395         unittests/unpack-selftests.c.
9396         * unittests/unpack-selftests.c: New file.
9397         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
9398
9399 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9400
9401         * dwarf2read.c (struct partial_die_info) <read>: New method.
9402         (read_partial_die): Remove the declaration.
9403         (load_partial_dies): Update.
9404         (partial_die_info::partial_die_info):
9405         (read_partial_die): Change it to partial_die_info::read.
9406
9407 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9408
9409         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
9410         (fixup_partial_die): Remove declaration.
9411         (scan_partial_symbols): Update.
9412         (partial_die_parent_scope): Likewise.
9413         (partial_die_full_name): Likewise.
9414         (fixup_partial_die): Change it to partial_die_info::fixup.
9415
9416 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9417
9418         * dwarf2read.c (read_partial_die): Update the declaration.
9419         (load_partial_dies): Caller update.
9420         (read_partial_die): Remove one argument abbrev_len.
9421
9422 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9423
9424         * dwarf2read.c (struct partial_die_info): Add ctor, delete
9425         assignment operator.
9426         (load_partial_dies): Use ctor and copy ctor.
9427         (read_partial_die): Update.
9428         (dwarf2_cu::find_partial_die): Use ctor.
9429
9430 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9431
9432         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
9433         (find_partial_die_in_comp_unit): Change it to
9434         dwarf2_cu::find_partial_die.
9435         (find_partial_die): Update.
9436
9437 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9438
9439         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
9440         is NULL.
9441
9442 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9443
9444         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
9445
9446 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
9447
9448         * arch/amd64.h: Use common/tdesc.h.
9449         * arch/i386.c: Likewise.
9450         * arch/i386.h: Likewise.
9451         * arch/tic6x.c: Likewise.
9452         * arch/tdesc.h: Move file from here...
9453         * common/tdesc.h: ...to here.
9454         * features/aarch64-core.c: Regenerate.
9455         * features/aarch64-fpu.c: Regenerate.
9456         * features/i386/32bit-avx.c: Regenerate.
9457         * features/i386/32bit-avx512.c: Regenerate.
9458         * features/i386/32bit-core.c: Regenerate.
9459         * features/i386/32bit-linux.c: Regenerate.
9460         * features/i386/32bit-mpx.c: Regenerate.
9461         * features/i386/32bit-pkeys.c: Regenerate.
9462         * features/i386/32bit-sse.c: Regenerate.
9463         * features/i386/64bit-avx.c: Regenerate.
9464         * features/i386/64bit-avx512.c: Regenerate.
9465         * features/i386/64bit-core.c: Regenerate.
9466         * features/i386/64bit-linux.c: Regenerate.
9467         * features/i386/64bit-mpx.c: Regenerate.
9468         * features/i386/64bit-pkeys.c: Regenerate.
9469         * features/i386/64bit-segments.c: Regenerate.
9470         * features/i386/64bit-sse.c: Regenerate.
9471         * features/i386/x32-core.c: Regenerate.
9472         * features/tic6x-c6xp.c: Regenerate.
9473         * features/tic6x-core.c: Regenerate.
9474         * features/tic6x-gp.c: Regenerate.
9475         * target-descriptions.c: Use common/tdesc.h.
9476         * target-descriptions.h: Likewise.
9477
9478 2018-02-24  Tom Tromey  <tom@tromey.com>
9479
9480         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
9481         (try_thread_db_load_from_dir, thread_db_load_search): Use
9482         std::string.
9483         (info_auto_load_libthread_db_compare): Return bool.  Change
9484         argument types.
9485         (info_auto_load_libthread_db): Use std::vector, std::string.
9486         Remove cleanups.
9487
9488 2018-02-24  Tom Tromey  <tom@tromey.com>
9489
9490         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
9491         std::string.
9492         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
9493         std::string*.
9494         * gdbarch.c: Rebuild.
9495         * gdbarch.h: Rebuild.
9496         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
9497         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
9498         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
9499         std::string*.
9500
9501 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
9502
9503         * gdbtypes.h (sect_offset): Change type to uint64_t.
9504         (sect_offset_str): New function.
9505         * dwarf2read.c (create_addrmap_from_aranges): Use
9506         sect_offset_str.
9507         (error_check_comp_unit_head): Likewise.
9508         (create_debug_type_hash_table): Likewise.
9509         (read_cutu_die_from_dwo): Likewise.
9510         (init_cutu_and_read_dies): Likewise.
9511         (init_cutu_and_read_dies_no_follow): Likewise.
9512         (process_psymtab_comp_unit_reader): Likewise.
9513         (partial_die_parent_scope): Likewise.
9514         (peek_die_abbrev): Likewise.
9515         (process_queue): Likewise.
9516         (dwarf2_physname): Likewise.
9517         (read_namespace_alias): Likewise.
9518         (read_import_statement): Likewise.
9519         (create_dwo_cu_reader): Likewise.
9520         (create_cus_hash_table): Likewise.
9521         (lookup_dwo_cutu): Likewise.
9522         (inherit_abstract_dies): Likewise.
9523         (read_func_scope): Likewise.
9524         (read_call_site_scope): Likewise.
9525         (dwarf2_add_member_fn): Likewise.
9526         (read_common_block): Likewise.
9527         (read_module_type): Likewise.
9528         (read_typedef): Likewise.
9529         (read_subrange_type): Likewise.
9530         (load_partial_dies): Likewise.
9531         (read_partial_die): Likewise.
9532         (find_partial_die): Likewise.
9533         (read_str_index): Likewise.
9534         (dwarf2_string_attr): Likewise.
9535         (build_error_marker_type): Likewise.
9536         (lookup_die_type): Likewise.
9537         (dump_die_shallow): Likewise.
9538         (follow_die_ref): Likewise.
9539         (dwarf2_fetch_die_loc_sect_off): Likewise.
9540         (dwarf2_fetch_constant_bytes): Likewise.
9541         (follow_die_sig): Likewise.
9542         (get_signatured_type): Likewise.
9543         (get_DW_AT_signature_type): Likewise.
9544         (dwarf2_find_containing_comp_unit): Likewise.
9545         (set_die_type): Likewise.
9546
9547 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
9548
9549         * arch/aarch64.c: Include "common-defs.h".
9550         * arch/amd64.c: Likewise.
9551         * arch/i386.c: Likewise.
9552
9553 2018-02-21  Tom Tromey  <tom@tromey.com>
9554
9555         * value.h: (extract_field_op): Update.
9556         * eval.c (extract_field_op): Return a const char *.
9557         * expression.h (parse_expression_for_completion): Update.
9558         * completer.c (complete_expression): Update.
9559         (add_struct_fields): Make fieldname const.
9560         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
9561         (mark_completion_tag, parse_exp_in_context_1): Update.
9562         (parse_expression_for_completion): Change "name" to
9563         unique_xmalloc_ptr*.
9564
9565 2018-02-21  Tom Tromey  <tom@tromey.com>
9566
9567         * infcall.c (call_function_by_hand_dummy): Use std::vector.
9568
9569 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9570
9571         * avr-tdep.c (avr_read_pc): Change parameter type to
9572         readable_regcache.
9573         * gdbarch.sh (read_pc): Likewise.
9574         * gdbarch.c: Re-generated.
9575         * gdbarch.h: Re-generated.
9576         * hppa-tdep.c (hppa_read_pc): Change parameter type to
9577         readable_regcache.
9578         * ia64-tdep.c (ia64_read_pc): Likewise.
9579         * mips-tdep.c (mips_read_pc): Likewise.
9580         * spu-tdep.c (spu_read_pc): Likewise.
9581
9582 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9583
9584         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
9585         * regcache-dump.c: New file.
9586         * regcache.c: Move register_dump to regcache-dump.c.
9587         (maintenance_print_registers): Likewise.
9588         (maintenance_print_raw_registers): Likewise.
9589         (maintenance_print_cooked_registers): Likewise.
9590         (maintenance_print_register_groups): Likewise.
9591         (maintenance_print_remote_registers): Likewise.
9592         (_initialize_regcache): Likewise.
9593         * regcache.h (register_dump): Moved from regcache.c.
9594
9595 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9596
9597         * regcache.c (regcache::regcache): Update.
9598         (regcache::invalidate): Move it to detached_regcache::invalidate.
9599         (get_thread_arch_aspace_regcache): Update.
9600         (regcache::raw_update): Update.
9601         (regcache::cooked_read): Remove some code.
9602         (regcache::cooked_read_value): Likewise.
9603         (regcache::raw_write): Remove assert on m_readonly_p.
9604         (regcache::raw_supply_integer): Move it to
9605         detached_regcache::raw_supply_integer.
9606         (regcache::raw_supply_zeroed): Likewise.
9607         * regcache.h (detached_regcache) <raw_supply_integer>: New
9608         declaration.
9609         <raw_supply_zeroed, invalidate>: Likewise.
9610         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
9611         <invalidate>: Likewise.
9612         <m_readonly_p>: Removed.
9613
9614 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9615
9616         * infcmd.c (get_return_value): Let stop_regs point to
9617         get_current_regcache.
9618         * regcache.c (regcache::regcache): Remove.
9619         (register_dump_reg_buffer): New class.
9620         (regcache_print): Adjust.
9621         * regcache.h (regcache): Remove constructors.
9622
9623 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9624
9625         * regcache.c (class register_dump): New class.
9626         (register_dump_regcache, register_dump_none): New class.
9627         (register_dump_remote, register_dump_groups): New class.
9628         (regcache_print): Update.
9629         * regcache.h (regcache_dump_what): Move it to regcache.c.
9630         (regcache) <dump>: Remove.
9631
9632 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9633
9634         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
9635          reg_buffer_rw *.
9636         (jit_unwind_reg_set_impl): Call raw_supply.
9637         (jit_frame_sniffer): Use reg_buffer_rw.
9638         * record-full.c (record_full_core_regbuf): Change its type.
9639         (record_full_core_open_1): Use reg_buffer_rw.
9640         (record_full_close): Likewise.
9641         (record_full_core_fetch_registers): Use regcache->raw_supply.
9642         (record_full_core_store_registers): Likewise.
9643         * regcache.c (regcache::get_register_status): Move it to
9644         reg_buffer.
9645         (regcache_raw_set_cached_value): Remove.
9646         (regcache::raw_set_cached_value): Remove.
9647         (regcache::raw_write): Call raw_supply.
9648         (regcache::raw_supply): Move it to reg_buffer_rw.
9649         * regcache.h (regcache_raw_set_cached_value): Remove.
9650         (reg_buffer_rw): New class.
9651
9652 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9653
9654         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
9655         readonly_detached_regcache.
9656         (dummy_frame_prev_register): Use regcache->cooked_read.
9657         * frame.c (frame_save_as_regcache): Change return type.
9658         (frame_pop): Update.
9659         * frame.h (frame_save_as_regcache): Update declaration.
9660         * inferior.h (get_infcall_suspend_state_regcache): Update
9661         declaration.
9662         * infrun.c (infcall_suspend_state) <registers>: use
9663         readonly_detached_regcache.
9664         (save_infcall_suspend_state): Don't use regcache_dup.
9665         (get_infcall_suspend_state_regcache): Change return type.
9666         * linux-fork.c (struct fork_info) <savedregs>: Change to
9667         readonly_detached_regcache.
9668         <pc>: New field.
9669         (fork_save_infrun_state): Don't use regcache_dup.
9670         (info_checkpoints_command): Adjust.
9671         * mi/mi-main.c (register_changed_p): Update declaration.
9672         (mi_cmd_data_list_changed_registers): Use
9673         readonly_detached_regcache.
9674         (register_changed_p): Change parameter type to
9675         readonly_detached_regcache.
9676         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
9677         readonly_detached_regcache.
9678         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
9679         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
9680         New.
9681         (regcache::save): Move it to reg_buffer.
9682         (regcache::restore): Change parameter type.
9683         (regcache_dup): Remove.
9684         * regcache.h (reg_buffer) <save>: New method.
9685         (readonly_detached_regcache): New class.
9686         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
9687         readonly_detached_regcache.
9688         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
9689
9690 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9691
9692         * frame.c (frame_save_as_regcache): Use regcache method save.
9693         (frame_pop): Use regcache method restore.
9694         * infrun.c (restore_infcall_suspend_state): Likewise.
9695         * linux-fork.c (fork_load_infrun_state): Likewise.
9696         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
9697         save.
9698         * regcache.c (regcache_save): Remove.
9699         (regcache::restore): More asserts.
9700         (regcache_cpy): Remove.
9701         * regcache.h (regcache_save): Remove the declaration.
9702         (regcache::restore): Move from private to public.
9703         Remove the friend declaration of regcache_cpy.
9704         (regcache_cpy): Remove declaration.
9705
9706 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9707
9708         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
9709         parameter type to 'readable_regcache *'.
9710         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
9711         * arm-tdep.c (arm_neon_quad_read): Likewise.
9712         (arm_pseudo_read): Likewise.
9713         * avr-tdep.c (avr_pseudo_register_read): Likewise.
9714         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
9715         * frv-tdep.c (frv_pseudo_register_read): Likewise.
9716         * gdbarch.c: Re-generated.
9717         * gdbarch.h: Re-generated.
9718         * gdbarch.sh (pseudo_register_read): Change parameter type to
9719         'readable_regcache *'.
9720         (pseudo_register_read_value): Likewise.
9721         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
9722         (h8300_pseudo_register_read): Likewise.
9723         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
9724         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
9725         (i386_pseudo_register_read_into_value): Likewise.
9726         (i386_pseudo_register_read_value): Likewise.
9727         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
9728         declaration.
9729         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
9730         * m32c-tdep.c (m32c_raw_read): Likewise.
9731         (m32c_read_flg): Likewise.
9732         (m32c_banked_register): Likewise.
9733         (m32c_banked_read): Likewise.
9734         (m32c_sb_read): Likewise.
9735         (m32c_part_read): Likewise.
9736         (m32c_cat_read): Likewise.
9737         (m32c_r3r2r1r0_read): Likewise.
9738         (m32c_pseudo_register_read): Likewise.
9739         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
9740         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
9741         (mep_pseudo_cr64_read): Likewise.
9742         (mep_pseudo_register_read): Likewise.
9743         * mips-tdep.c (mips_pseudo_register_read): Likewise.
9744         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
9745         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
9746         * regcache.c (regcache::raw_read): Move it to readable_regcache.
9747         (regcache::cooked_read): Likewise.
9748         (regcache::cooked_read_value): Likewise.
9749         (regcache_cooked_read_signed):
9750         (regcache::cooked_read): Likewise.
9751         * regcache.h (readable_regcache): New class.
9752         (regcache): Inherit readable_regcache.  Move some methods to
9753         readable_regcache.
9754         * rl78-tdep.c (rl78_pseudo_register_read): Change
9755         parameter type to 'readable_regcache *'.
9756         * rs6000-tdep.c (do_regcache_raw_read): Remove.
9757         (e500_pseudo_register_read): Change parameter type to
9758         'readable_regcache *'.
9759         (dfp_pseudo_register_read): Likewise.
9760         (vsx_pseudo_register_read): Likewise.
9761         (efpr_pseudo_register_read): Likewise.
9762         * s390-tdep.c (s390_pseudo_register_read): Likewise.
9763         * sh-tdep.c (sh_pseudo_register_read): Likewise.
9764         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
9765         (sh64_pseudo_register_read): Likewise.
9766         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
9767         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
9768         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
9769         (spu_pseudo_register_read): Likewise.
9770         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
9771         (xtensa_pseudo_register_read): Likewise.
9772
9773 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9774
9775         * regcache.c (regcache::regcache): Call reg_buffer ctor.
9776         (regcache::arch): Move it to reg_buffer::arch.
9777         (regcache::register_buffer): Likewise.
9778         (regcache::assert_regnum): Likewise.
9779         (regcache::num_raw_registers): Likewise.
9780         * regcache.h (reg_buffer): New class.
9781         (regcache): Inherit reg_buffer.
9782
9783 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
9784
9785         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
9786         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
9787
9788 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
9789
9790         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
9791
9792 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
9793
9794         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
9795         (SFILES): Remove common/*.c files.
9796         (COMMON_OBS): Remove some *.o files built from common/*.c files.
9797         * common/common.host: Add common reference.
9798         * configure.ac: Likewise.
9799         * configure: Regenerate.
9800
9801 2018-02-16  Yao Qi  <yao.qi@linaro.org>
9802
9803         * block.c (block_namespace_info): Inherit allocate_on_obstack.
9804         (block_initialize_namespace): Use new.
9805         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
9806         (dwarf2_free_objfile): Use delete.
9807         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
9808         (copy_type_recursive): Use new.
9809         * gdb_obstack.h (allocate_on_obstack): New.
9810
9811 2018-02-15  Yao Qi  <yao.qi@linaro.org>
9812
9813         PR gdb/22849
9814         * inferior.c (exit_inferior_1): Reset inf->control.
9815
9816 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
9817
9818         * ada-lang.c (ada_to_fixed_value_create): Delete advance
9819         declaration.
9820
9821 2018-02-14  Pedro Alves  <palves@redhat.com>
9822
9823         * frame-unwind.c (frame_unwind_try_unwinder): Always call
9824         frame_cleanup_after_sniffer on exception.
9825
9826 2018-02-14  Tom Tromey  <tom@tromey.com>
9827
9828         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
9829         const.
9830         (solib_bfd_open): Make pathname const.
9831         * solib.c (solib_bfd_open): Make pathname const.
9832         * solib-spu.c (spu_bfd_fopen): Make name const.
9833         (spu_bfd_open): Make pathname const.
9834         * solib-darwin.c (darwin_bfd_open): Make pathname const.
9835         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
9836
9837 2018-02-14  Tom Tromey  <tom@tromey.com>
9838
9839         * symfile.c (symfile_bfd_open): Update.
9840         * source.h (openp, source_full_path_of, find_and_open_source):
9841         Change argument type to unique_xmalloc_ptr.
9842         * source.c (openp): Take a unique_xmalloc_ptr.
9843         (source_full_path_of, find_and_open_source): Likewise.
9844         (open_source_file, symtab_to_fullname): Update.
9845         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
9846         unique_xmalloc_ptr.
9847         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
9848         (exec_file_find): Update.
9849         * psymtab.c (psymtab_to_fullname): Update.
9850         * nto-tdep.h (nto_find_and_open_solib): Update.
9851         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
9852         unique_xmalloc_ptr.
9853         * exec.c (exec_file_attach): Update.
9854         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
9855         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
9856
9857 2018-02-14  Tom Tromey  <tom@tromey.com>
9858
9859         * solib.c: Include source.h.
9860         * nto-tdep.c: Include source.h.
9861         * mi/mi-cmd-env.c: Include source.h.
9862         * infcmd.c: Include source.h.
9863         * exec.c: Include source.h.
9864         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
9865         (add_path, directory_switch, source_path, init_source_path): Move
9866         declarations...
9867         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
9868         (add_path, directory_switch, source_path, init_source_path):
9869         ...here.
9870
9871 2018-02-14  Tom Tromey  <tom@tromey.com>
9872
9873         * solist.h (exec_file_find, solib_find): Return
9874         unique_xmalloc_ptr.
9875         (solib_bfd_fopen): Take a const char *.
9876         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
9877         (exec_file_find, solib_find): Likewise.
9878         (solib_bfd_fopen): Do not take ownership of "pathname".
9879         (solib_bfd_open): Use unique_xmalloc_ptr.
9880         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
9881         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
9882         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
9883         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
9884
9885 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
9886
9887         * ada-lang.c (name_match_type_from_name): Remove reference to
9888         ada_name_for_lookup in function's documentation.
9889         * ada-lang.h (ada_name_for_lookup): Delete declaration.
9890
9891 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
9892
9893         * defs.h (enum openp_flags): New enum.
9894         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
9895         Move to enum openp_flags.
9896         (openp_flags): New enum flags.
9897         (openp): Change parameter type to openp_flags.
9898         * source.c (openp): Change parameter type to openp_flags.
9899         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
9900         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
9901
9902 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
9903
9904         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
9905         per-command.
9906
9907 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9908
9909         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
9910         into...
9911         (class dwarf2_queue_guard): ...the destructor of this new class.
9912         (dw2_do_instantiate_symtab): Create instance of the new class
9913         dwarf2_queue_guard, remove cleanup.
9914
9915 2018-02-09  Tom Tromey  <tom@tromey.com>
9916
9917         * source.c (find_source_lines): Don't reference past the end of
9918         the vector.
9919
9920 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9921
9922         * remote.c (remote_btrace_maybe_reopen): Change error message.
9923         * btrace.c (btrace_enable): Likewise.
9924         (parse_xml_btrace): Likewise.
9925         (parse_xml_btrace_conf): Likewise.
9926
9927 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9928
9929         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
9930         (linux_enable_pt, linux_enable_bts): Call
9931         diagnose_perf_event_open_fail.
9932
9933 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9934
9935         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
9936         Remove parameter and change return type.  Update callers.  Move it.
9937         (linux_enable_bts, linux_enable_pt): Improve error message.
9938         (linux_enable_pt): Remove zero buffer size check.
9939         (linux_enable_btrace): Improve error messages.  Remove NULL return
9940         check.
9941
9942 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9943
9944         * btrace.c (btrace_enable): Remove target_supports_btrace call.
9945         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
9946         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
9947         (linux_supports_pt, linux_supports_btrace): Remove.
9948         (linux_enable_bts): Call cpu_supports_bts.
9949         * nat/linux-btrace.h (linux_supports_btrace): Remove.
9950         * remote.c (remote_supports_btrace): Remove.
9951         (init_remote_ops): Remove remote_supports_btrace.
9952         * target-delegates.c: Regenerated.
9953         * target.c (target_supports_btrace): Remove.
9954         * target.h (target_ops) <to_supports_btrace>: Remove
9955         (target_supports_btrace): Remove.
9956         * x86-linux-nat.c (x86_linux_create_target): Remove
9957         linux_supports_btrace.
9958
9959 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9960
9961         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
9962         btrace failed.
9963         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
9964         exception and use message in own exception.
9965
9966 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9967
9968         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
9969         (perf_event_pt_event_type): Use gdb_file_up.
9970         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
9971         scoped_fd, and scoped_mmap.
9972
9973 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9974
9975         * common/scoped_mmap.h: New.
9976         * unittests/scoped_mmap-selftest.c: New.
9977         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9978         unittests/scoped_mmap-selftest.c.
9979
9980 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9981
9982         * common/scoped_fd.h: New.
9983         * unittests/scoped_fd-selftest.c: New.
9984         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9985         unittests/scoped_fd-selftest.c.
9986
9987 2018-02-09  Tom Tromey  <tom@tromey.com>
9988
9989         * auto-load.c (auto_load_section_scripts): Use
9990         gdb::unique_xmalloc_ptr.
9991
9992 2018-02-09  Tom Tromey  <tom@tromey.com>
9993
9994         * auto-load.c (execute_script_contents): Use std::string.
9995
9996 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
9997
9998         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
9999         Python function, rather than a new command.
10000
10001 2018-02-08  Tom Tromey  <tom@tromey.com>
10002
10003         * solib.c (solib_find_1): Use std::string.
10004         (solib_bfd_fopen): Use unique_xmalloc_ptr.
10005
10006 2018-02-08  Tom Tromey  <tom@tromey.com>
10007
10008         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
10009
10010 2018-02-08  Tom Tromey  <tom@tromey.com>
10011
10012         * source.c (find_source_lines): Use gdb::def_vector.
10013
10014 2018-02-08  Tom Tromey  <tom@tromey.com>
10015
10016         * macrocmd.c (struct temporary_macro_definition): New.
10017         (macro_define_command): Use temporary_macro_definition.  Remove
10018         cleanups.
10019         (free_macro_definition_ptr): Remove.
10020
10021 2018-02-08  Tom Tromey  <tom@tromey.com>
10022
10023         * macroexp.c (maybe_expand): Use std::string.
10024
10025 2018-02-08  Tom Tromey  <tom@tromey.com>
10026
10027         * macroexp.c (struct macro_buffer): Add initializers for some
10028         members.
10029         (init_buffer, init_shared_buffer, free_buffer)
10030         (free_buffer_return_text): Remove.
10031         (macro_buffer): New constructors.
10032         (~macro_buffer): New destructor.
10033         (macro_buffer::set_shared): New method.
10034         (macro_buffer::resize_buffer, macro_buffer::appendc)
10035         (macro_buffer::appendmem): Now methods, not free functions.
10036         (set_token, append_tokens_without_splicing, stringify)
10037         (macro_stringify): Update.
10038         (gather_arguments): Change return type.  Remove argc_p argument,
10039         add args_ptr argument.  Use std::vector.
10040         (substitute_args): Remove argc argument.  Accept std::vector.
10041         (expand): Update.  Use std::vector.
10042         (scan, macro_expand, macro_expand_next): Update.
10043
10044 2018-02-08  Tom Tromey  <tom@tromey.com>
10045
10046         * symtab.c (default_collect_symbol_completion_matches_break_on):
10047         Use unique_xmalloc_ptr.
10048         * macroscope.h: (sal_macro_scope, user_macro_scope)
10049         (default_macro_scope): Return unique_xmalloc_ptr.
10050         * macroscope.c (sal_macro_scope, user_macro_scope)
10051         (default_macro_scope): Return unique_xmalloc_ptr.
10052         * macroexp.h (macro_expand, macro_expand_once): Return
10053         unique_xmalloc_ptr.
10054         * macroexp.c (macro_expand, macro_expand_once): Return
10055         unique_xmalloc_ptr.
10056         * macrocmd.c (macro_expand_command, macro_expand_once_command)
10057         (info_macro_command, info_macros_command): Use
10058         unique_xmalloc_ptr.
10059         * compile/compile-c-support.c (write_macro_definitions): Use
10060         unique_xmalloc_ptr.
10061         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
10062
10063 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
10064
10065         * value.c (value_static_field): Assign field type instead of
10066         containing type when returning an optimized out value.
10067
10068 2018-02-06  Yao Qi  <yao.qi@linaro.org>
10069
10070         * ft32-tdep.c (ft32_read_pc): Remove.
10071         (ft32_write_pc): Remove.
10072         (ft32_gdbarch_init): Update.
10073         * m32r-tdep.c (m32r_read_pc): Remove.
10074         (m32r_gdbarch_init): Update.
10075         * mep-tdep.c (mep_read_pc): Remove.
10076         (mep_gdbarch_init): Update.
10077         * microblaze-tdep.c (microblaze_write_pc): Remove.
10078         (microblaze_gdbarch_init): Update.
10079         * mn10300-tdep.c (mn10300_read_pc): Remove.
10080         (mn10300_write_pc): Remove.
10081         (mn10300_gdbarch_init): Update.
10082         * moxie-tdep.c (moxie_read_pc): Remove.
10083         (moxie_write_pc): Remove.
10084         (moxie_gdbarch_init): Update.
10085
10086 2018-02-06  Yao Qi  <yao.qi@linaro.org>
10087
10088         * expprint.c (print_subexp_standard): Handle
10089         OP_F77_UNDETERMINED_ARGLIST.
10090         (dump_subexp_body_standard): Likewise.
10091
10092 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
10093
10094         * target-descriptions.c (tdesc_element_visitor) Add empty
10095         implementations.
10096         (tdesc_type): Move make_gdb_type from here.
10097         (tdesc_type_builtin): Likewise.
10098         (tdesc_type_vector): Likewise.
10099         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
10100         (make_gdb_type_struct): Move from tdesc_type_with_fields.
10101         (make_gdb_type_union): Likewise.
10102         (make_gdb_type_flags): Likewise.
10103         (make_gdb_type_enum): Likewise.
10104         (make_gdb_type): New function.
10105         (tdesc_register_type): Use static make_gdb_type.
10106
10107 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
10108
10109         * infcmd.c (default_print_one_register_info): Align natural-format
10110         column values consistently one under another.
10111         (pad_to_column): New function.
10112
10113 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
10114
10115         * dwarf2read.c (dwarf2_physname): Move commment.
10116
10117 2018-02-01  Leszek Swirski  <leszeks@google.com>
10118
10119         * varobj.c (varobj_formatted_print_options): Allow recursive
10120         pretty printing if pretty printing is enabled.
10121
10122 2018-02-01  Leszek Swirski  <leszeks@google.com>
10123
10124         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
10125         names after a structop as a filename.
10126
10127 2018-02-01  Yao Qi  <yao.qi@linaro.org>
10128
10129         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
10130         (arm_record_coproc_data_proc): Likewise.
10131
10132 2018-02-01  Yao Qi  <yao.qi@linaro.org>
10133
10134         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
10135
10136 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
10137
10138         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
10139         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
10140
10141 2018-01-31  Pedro Alves  <palves@redhat.com>
10142
10143         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
10144         * inflow.c (child_terminal_save_inferior): Wrap reference to
10145         tcgetpgrp in HAVE_TERMIOS_H.
10146         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
10147         _WIN32.
10148         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
10149         always iterate over all inferiors.
10150         (gdbsim_cntrl_c): Adjust.
10151         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
10152
10153 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
10154
10155         * gdbtypes.c (lookup_array_range_type): Make sure the array's
10156         index type is objfile-owned if the element type is as well.
10157
10158 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
10159
10160         GDB 8.1 released.
10161
10162 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10163
10164         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
10165         "features/s390x-linux64.c".
10166         (_initialize_s390_linux_tdep): Remove initialization of tdescs
10167         s390_linux32 and s390x_linux64.
10168         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
10169         default tdesc.
10170         * s390-tdep.c: Include "features/s390-linux32.c" and
10171         "features/s390x-linux64.c".
10172         (s390_tdesc_valid): Add check for tdesc_has_registers.
10173         (s390_gdbarch_init): Make sure there is always a valid tdesc.
10174         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
10175         tdesc_s390x_linux64.
10176         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
10177         tdesc_s390x_linux64 to...
10178         * s390-tdep.h: ...here.
10179
10180 2018-01-30  Pedro Alves  <palves@redhat.com>
10181
10182         PR gdb/13211
10183         * config.in, configure: Regenerate.
10184         * configure.ac: Check for getpgid.
10185         * go32-nat.c (go32_pass_ctrlc): New.
10186         (go32_target): Install it.
10187         * inf-child.c (inf_child_target): Install
10188         child_terminal_save_inferior, child_pass_ctrlc and
10189         child_interrupt.
10190         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
10191         (inf_ptrace_target): No longer install it.
10192         * infcmd.c (interrupt_target_1): Adjust.
10193         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
10194         (child_interrupt): Declare.
10195         (inferior::terminal_state): New.
10196         * inflow.c (struct terminal_info): Update comments.
10197         (inferior_process_group): Delete.
10198         (terminal_is_ours): Delete.
10199         (gdb_tty_state): New.
10200         (child_terminal_init): Adjust.
10201         (is_gdb_terminal, sharing_input_terminal_1)
10202         (sharing_input_terminal): New functions.
10203         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
10204         Set the process's actual process group in the foreground if
10205         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
10206         mark terminal as the inferior's if not sharing GDB's terminal.
10207         Don't check attach_flag.
10208         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
10209         pass down a target_terminal_state.
10210         (child_terminal_save_inferior): New, factored out from ...
10211         (child_terminal_ours_1): ... this.  Handle
10212         target_terminal_state::is_ours_for_output.
10213         (child_interrupt, child_pass_ctrlc): New.
10214         (inflow_inferior_exit): Clear the inferior's terminal_state.
10215         (copy_terminal_info): Copy the inferior's terminal state.
10216         (_initialize_inflow): Remove reference to terminal_is_ours.
10217         * inflow.h (inferior_process_group): Delete.
10218         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
10219         * procfs.c (procfs_target): Don't install procfs_interrupt.
10220         (procfs_interrupt): Delete.
10221         * remote.c (remote_serial_quit_handler): Adjust.
10222         (remote_interrupt): Remove ptid parameter.  Adjust.
10223         * target-delegates.c: Regenerate.
10224         * target.c: Include "terminal.h".
10225         (target_terminal::terminal_state): Rename to ...
10226         (target_terminal::m_terminal_state): ... this.
10227         (target_terminal::init): Adjust.
10228         (target_terminal::inferior): Adjust to per-inferior
10229         terminal_state.
10230         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
10231         (target_terminal::ours, target_terminal::ours_for_output): Use
10232         target_terminal_is_ours_kind.
10233         (target_interrupt): Remove ptid parameter.  Adjust.
10234         (default_target_pass_ctrlc): Adjust.
10235         * target.h (target_ops::to_terminal_save_inferior): New field.
10236         (target_ops::to_interrupt): Remove ptid_t parameter.
10237         (target_interrupt): Remove ptid_t parameter.  Update comment.
10238         (target_pass_ctrlc): Update comment.
10239         * target/target.h (target_terminal_state): New scoped enum,
10240         factored out of ...
10241         (target_terminal::terminal_state): ... here.
10242         (target_terminal::inferior): Update comments.
10243         (target_terminal::restore_inferior): New.
10244         (target_terminal::is_inferior, target_terminal::is_ours)
10245         (target_terminal::is_ours_for_output): Adjust.
10246         (target_terminal::scoped_restore_terminal_state): Adjust to
10247         rename, and call restore_inferior() instead of inferior().
10248         (target_terminal::scoped_restore_terminal_state::m_state): Change
10249         type.
10250         (target_terminal::terminal_state): Rename to ...
10251         (target_terminal::m_terminal_state): ... this and change type.
10252
10253 2018-01-30  Pedro Alves  <palves@redhat.com>
10254
10255         * linux-nat.c (wait_for_signal): New function.
10256         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
10257         directly.
10258         (async_terminal_is_ours)
10259         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
10260         (linux_nat_add_target): Don't override
10261         to_terminal_inferior/to_terminal_ours.
10262
10263 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10264
10265         * remote.c (remote_follow_fork): Don't call "detach_inferior".
10266
10267 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
10268
10269         * dwarf2read.c (free_dwo_files): Add forward-declaration.
10270         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
10271         dwarf2_per_objfile_free here.
10272         (dwarf2_per_objfile_free): Remove.
10273         (_initialize_dwarf2_read): Don't register
10274         dwarf2_per_objfile_free as a registry cleanup.
10275
10276 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
10277
10278         Avoid compilation errors in MinGW native builds
10279
10280         The error is triggered by including python-internal.h, and the
10281         error message is:
10282
10283              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
10284                       from build-gnulib/import/math.h:27,
10285                       from d:/usr/Python26/include/pyport.h:235,
10286                       from d:/usr/Python26/include/Python.h:58,
10287                       from python/python-internal.h:94,
10288                       from python/py-arch.c:24:
10289              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
10290         using ::hypot;
10291                 ^~~~~
10292
10293         This happens because Python headers define 'hypot' to expand t
10294         '_hypot' in the Windows builds.
10295         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
10296         'hypoth'.  This avoids a compilation error.
10297
10298 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
10299
10300         * MAINTAINERS (Write After Approval): Fix ordering.
10301
10302 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
10303
10304         * MAINTAINERS (Write After Approval): Add Alan Hayward.
10305
10306 2018-01-26  Alan Modra  <amodra@gmail.com>
10307
10308         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
10309         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
10310         Remove nop.  Make const.  Comment.
10311         (powerpc32_plt_stub_so_2): New.
10312         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
10313         Correct count.  Update uses.
10314         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
10315         Move common code reading PLT entry word.  Correct
10316         powerpc32_plt_stub PLT address calculation.
10317         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
10318         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
10319         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
10320         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
10321         (ppc64_standard_linkage8): Likewise.
10322         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
10323         Correct insns description.
10324         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
10325
10326 2018-01-24  Pedro Alves  <palves@redhat.com>
10327
10328         GCC PR libstdc++/83906
10329         * gdbtypes.c (operator==(const dynamic_prop &,
10330         const dynamic_prop &)): New.
10331         (operator==(const range_bounds &, const range_bounds &)): New.
10332         (check_types_equal): Use them instead of memcmp.
10333         * gdbtypes.h (operator==(const dynamic_prop &,
10334         const dynamic_prop &)): Declare.
10335         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
10336         (operator==(const range_bounds &, const range_bounds &)): Declare.
10337         (operator!=(const range_bounds &, const range_bounds &)): Declare.
10338
10339 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10340
10341         * s390-linux-tdep.c (s390_record_address_mask)
10342         (s390_record_calc_disp_common, s390_record_calc_disp)
10343         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
10344         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
10345         (s390_process_record): Move to s390-tdep.c.
10346         (s390_linux_init_abi_any): Adjust.
10347         * s390-tdep.c (s390_record_address_mask)
10348         (s390_record_calc_disp_common, s390_record_calc_disp)
10349         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
10350         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
10351         (s390_process_record): Moved from s390-linux-tdep.c
10352         (s390_gdbarch_init): Adjust.
10353
10354 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10355
10356         * s390-linux-nat.c (s390-tdep.h): New include.
10357         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
10358         (HFILES_NO_SRCDIR): Add s390-tdep.h.
10359         (ALLDEPFILES): Add s390-tdep.c.
10360         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
10361         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
10362         * s390-tdep.h: ...this.  New file.
10363         * s390-linux-tdep.c (s390-tdep.h): New include.
10364         (_initialize_s390_tdep): Rename to...
10365         (_initialize_s390_linux_tdep): ...this and adjust.
10366         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
10367         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
10368         s390-tdep.h.
10369         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
10370         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
10371         (s390_is_partial_instruction, s390_software_single_step)
10372         (is_non_branch_ril, s390_displaced_step_copy_insn)
10373         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
10374         (s390_prologue_data, s390_addr, s390_store, s390_load)
10375         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
10376         (s390_register_call_saved, s390_guess_tracepoint_registers)
10377         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
10378         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
10379         (s390_pseudo_register_name, s390_pseudo_register_type)
10380         (s390_pseudo_register_read, s390_pseudo_register_write)
10381         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
10382         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
10383         (s390_addr_bits_remove, s390_address_class_type_flags)
10384         (s390_address_class_type_flags_to_name)
10385         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
10386         (s390_function_arg_float, s390_function_arg_vector)
10387         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
10388         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
10389         (s390_frame_align, s390_register_return_value, s390_return_value)
10390         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
10391         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
10392         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
10393         (s390_trad_frame_prev_register, s390_unwind_cache)
10394         (s390_prologue_frame_unwind_cache)
10395         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
10396         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
10397         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
10398         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
10399         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
10400         (s390_frame_base_address, s390_local_base_address)
10401         (s390_frame_base, s390_gcc_target_options)
10402         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
10403         (s390_validate_reg_range, s390_tdesc_valid)
10404         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
10405         * s390-tdep.c: ...this.  New file.
10406
10407 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10408
10409         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
10410         (s390_process_record, s390_gdbarch_tdep_alloc)
10411         (s390_linux_init_abi_any): Use/set new hook.
10412
10413 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10414
10415         * s390-linux-tdep.c (osabi.h): New include.
10416         (s390_linux_init_abi_31, s390_linux_init_abi_64)
10417         (s390_linux_init_abi_any): New functions.
10418         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
10419
10420 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10421
10422         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
10423         tdesc_has_registers check
10424
10425 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10426
10427         * s390-linux-tdep.c (s390_tdesc_valid): New function.
10428         (s390_validate_reg_range): New macro.
10429         (s390_gdbarch_init): Adjust.
10430
10431 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10432
10433         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
10434         (s390_gdbarch_tdep_alloc): Adjust.
10435         (s390_gdbarch_init): Adjust.
10436
10437 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10438
10439         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
10440         <have_tdb>: Change type to bool.
10441         (s390_gdbarch_tdep_alloc): Adjust.
10442         (s390_gdbarch_init): Adjust.
10443
10444 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10445
10446         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
10447         (gdbarch_tdep) <have_upper, have_vx>: New fields.
10448         (s390_gdbarch_tdep_alloc): New function.
10449         (s390_gdbarch_init): Allocate tdep at start and use its fields
10450         instead of separate variables.
10451
10452 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10453
10454         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
10455         when looking for cached gdbarch and add comment for remaining.
10456
10457 2018-01-22  Pedro Alves  <palves@redhat.com>
10458             Sergio Durigan Junior  <sergiodj@redhat.com>
10459
10460         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
10461         case.
10462
10463 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
10464
10465         * MAINTAINERS: Update my company e-mail address.
10466
10467 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10468
10469         * regcache.c (cooked_write_test): New function.
10470         (_initialize_regcache): Register the test.
10471
10472 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10473
10474         * ia64-tdep.c (ia64_pseudo_register_read): Call
10475         regcache->cooked_read instead of regcache_cooked_read_unsigned.
10476         * m32c-tdep.c (m32c_cat_read): Likewise.
10477         (m32c_r3r2r1r0_read): Likewise.
10478         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
10479         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
10480
10481 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10482
10483         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
10484         method raw_read instead of regcache_raw_read.
10485         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
10486         * arm-tdep.c (arm_neon_quad_read): Likewise.
10487         * avr-tdep.c (avr_pseudo_register_read): Likewise.
10488         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
10489         * frv-tdep.c (frv_pseudo_register_read): Likewise.
10490         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
10491         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
10492         (i386_pseudo_register_read_into_value): Likewise.
10493         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
10494         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
10495         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
10496         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
10497         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
10498         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
10499         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
10500         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
10501         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
10502
10503 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10504
10505         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
10506         * configure.tgt: Remove target mt.
10507         * mt-tdep.c: Remove.
10508         * regcache.c (cooked_read_test): Remove the check for mt.
10509
10510 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10511
10512         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
10513         instead of gdbarch_pseudo_register_read_value.
10514
10515 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
10516
10517         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
10518         language is Ada.
10519
10520 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
10521
10522         * linespec.c (create_sals_line_offset): Remove code that preserved
10523         the symtab_and_line's line number.
10524
10525 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10526
10527         * varobj.c (varobj_create): Don't set valid_block when creating a
10528         floating varobj.
10529
10530 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10531
10532         * varobj.c (varobj_create): Remove out of date comment.
10533
10534 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10535
10536         PR mi/20395
10537         * ada-exp.y (write_var_from_sym): Pass extra parameter when
10538         updating innermost block.
10539         * parse.c (innermost_block_tracker::update): Take extra type
10540         parameter, and check types match before updating innermost block.
10541         (write_dollar_variable): Update innermost block for registers.
10542         * parser-defs.h (enum innermost_block_tracker_type): New enum.
10543         (innermost_block_tracker::innermost_block_tracker): Initialise
10544         m_types member.
10545         (innermost_block_tracker::reset): Take type parameter.
10546         (innermost_block_tracker::update): Take type parameter, and pass
10547         type through as needed.
10548         (innermost_block_tracker::m_types): New member.
10549         * varobj.c (varobj_create): Pass type when reseting innermost
10550         block.
10551
10552 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10553
10554         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
10555         * ada-lang.c (resolve_subexp): Likewise.
10556         * breakpoint.c (set_breakpoint_condition) Likewise.
10557         (watch_command_1) Likewise.
10558         * c-exp.y (variable): Likewise.
10559         * d-exp.y (PrimaryExpression): Likewise.
10560         * f-exp.y (variable): Likewise.
10561         * go-exp.y (variable): Likewise.
10562         * m2-exp.y (variable): Likewise.
10563         * objfiles.c (objfile::~objfile): Likewise.
10564         * p-exp.y (variable): Likewise.
10565         * parse.c (innermost_block): Change type.
10566         * parser-defs.h (class innermost_block_tracker): New.
10567         (innermost_block): Change to innermost_block_tracker.
10568         * printcmd.c (display_command): Switch to innermost_block API.
10569         (do_one_display): Likewise.
10570         * rust-exp.y (do_one_display): Likewise.
10571         * symfile.c (clear_symtab_users): Likewise.
10572         * varobj.c (varobj_create): Switch to innermost_block API, replace
10573         use of innermost_block with block stored on varobj object.
10574
10575 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10576
10577         * expression.h (innermost_block): Remove declaration.
10578         * varobj.c: Add 'parser-defs.h' include.
10579
10580 2018-01-19  Tom Tromey  <tom@tromey.com>
10581
10582         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
10583         symbols in the static and global blocks.
10584
10585 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
10586
10587         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
10588         gdb_ptrace.h, and move including gdb_wait.h ...
10589         * nat/linux-ptrace.h: ... to here.
10590
10591 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10592
10593         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
10594         inf_ptrace_detach_success.
10595         (inf_ptrace_detach_success): Add inferior parameter, use it
10596         instead of inferior_ptid, pass it to detach_inferior.
10597         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
10598         parameter.
10599         * inferior.c (detach_inferior): Add overload that takes an
10600         inferior object.
10601         * inferior.h (detach_inferior): Likewise.
10602         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
10603         use inferior_ptid, adjust call to inf_ptrace_detach_success.
10604         * linux-thread-db.c (thread_db_detach): Use inf parameter.
10605
10606 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10607
10608         * target.h (struct target_ops) <to_detach>: Add inferior
10609         parameter.
10610         (target_detach): Likewise.
10611         * target.c (dispose_inferior): Pass inferior down.
10612         (target_detach): Pass inferior down.  Assert that it is equal to
10613         the current inferior.
10614         * aix-thread.c (aix_thread_detach): Pass inferior down.
10615         * corefile.c (core_file_command): Pass current_inferior() down.
10616         * corelow.c (core_detach): Add inferior parameter.
10617         * darwin-nat.c (darwin_detach): Likewise.
10618         * gnu-nat.c (gnu_detach): Likewise.
10619         * inf-ptrace.c (inf_ptrace_detach): Likewise.
10620         * infcmd.c (detach_command): Pass current_inferior() down to
10621         target_detach.
10622         * infrun.c (follow_fork_inferior): Pass parent_inf to
10623         target_detach.
10624         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
10625         target_detach.
10626         * linux-nat.c (linux_nat_detach): Add inferior parameter.
10627         * linux-thread-db.c (thread_db_detach): Likewise.
10628         * nto-procfs.c (procfs_detach): Likewise.
10629         * procfs.c (procfs_detach): Likewise.
10630         * record.c (record_detach): Likewise.
10631         * record.h (struct inferior): Forward-declare.
10632         (record_detach): Add inferior parameter.
10633         * remote-sim.c (gdbsim_detach): Likewise.
10634         * remote.c (remote_detach_1): Likewise.
10635         (remote_detach): Likewise.
10636         (extended_remote_detach): Likewise.
10637         * sol-thread.c (sol_thread_detach): Likewise.
10638         * target-debug.h (target_debug_print_inferior_p): New macro.
10639         * target-delegates.c: Re-generate.
10640         * top.c (kill_or_detach): Pass inferior down to target_detach.
10641         * windows-nat.c (windows_detach): Add inferior parameter.
10642
10643 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10644
10645         * target.h (struct target_ops) <to_detach>: Remove args
10646         parameter.
10647         (target_detach): Likewise.
10648         * target.c (dispose_inferior): Adjust.
10649         (target_detach): Remove args parameter, adjust.
10650         * aix-thread.c (aix_thread_detach): Adjust.
10651         * corefile.c (core_file_command): Adjust.
10652         * corelow.c (core_detach): Adjust.
10653         * darwin-nat.c (darwin_detach): Adjust.
10654         * gnu-nat.c (gnu_detach): Adjust.
10655         * inf-ptrace.c (inf_ptrace_detach): Adjust.
10656         * infcmd.c (detach_command): Adjust
10657         * infrun.c (follow_fork_inferior): Adjust.
10658         (handle_vfork_child_exec_or_exit): Adjust.
10659         * linux-fork.c (linux_fork_detach): Remove args parameter.
10660         * linux-fork.h (linux_fork_detach): Likewise.
10661         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
10662         * linux-thread-db.c (thread_db_detach): Likewise.
10663         * nto-procfs.c (procfs_detach): Likewise.
10664         * procfs.c (procfs_detach): Likewise.
10665         (do_detach): Remove signo parameter.
10666         * record.c (record_detach): Remove args parameter.
10667         * record.h (record_detach): Likewise.
10668         * remote-sim.c (gdbsim_detach): Likewise.
10669         * remote.c (remote_detach_1): Likewise.
10670         (remote_detach): Likewise.
10671         (extended_remote_detach): Likewise.
10672         * sol-thread.c (sol_thread_detach): Likewise.
10673         * target-delegates.c: Re-generate.
10674         * top.c (struct qt_args) <args>: Remove field.
10675         (kill_or_detach): Don't pass args.
10676         (quit_force): Don't set args.
10677         * windows-nat.c (windows_detach): Remove args parameter.
10678
10679 2018-01-19  Yao Qi  <yao.qi@linaro.org>
10680
10681         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
10682         (arm_linux_init_abi): Install it.
10683
10684 2018-01-19  Yao Qi  <yao.qi@linaro.org>
10685
10686         * osabi.c (gdb_osabi_names): Extend the regexp for
10687         arm-linux-gnueabihf.
10688
10689 2018-01-18  Yao Qi  <yao.qi@linaro.org>
10690
10691         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
10692         m_abbrevs.
10693         (abbrev_table::add_abbrev): Update.
10694         (abbrev_table::lookup_abbrev): Update.
10695
10696 2018-01-18  Yao Qi  <yao.qi@linaro.org>
10697
10698         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
10699
10700 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
10701
10702         * compile/compile.c (compile_to_object): Convert "triplet_rx"
10703         to "std::string".
10704
10705 2018-01-17  Tom Tromey  <tom@tromey.com>
10706
10707         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
10708
10709 2018-01-17  Tom Tromey  <tom@tromey.com>
10710
10711         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
10712         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
10713         (create_array_type_with_stride): Update.
10714         * dwarf2read.c (set_die_type): Update.
10715
10716 2018-01-17  Tom Tromey  <tom@tromey.com>
10717
10718         * dwarf2read.c (delayed_method_info): Remove typedef.
10719         (dwarf2_cu::method_info): Now a std::vector.
10720         (add_to_method_list): Update.
10721         (free_delayed_list): Remove.
10722         (compute_delayed_physnames): Update.
10723         (process_full_comp_unit, process_full_type_unit): Clear the method
10724         list.  Remove cleanups.
10725         (psymtab_include_file_name): Add name_holder parameter.  Use
10726         unique_xmalloc_ptr.
10727         (dwarf_decode_lines): Update.
10728
10729 2018-01-17  Tom Tromey  <tom@tromey.com>
10730             Simon Marchi  <simon.marchi@ericsson.com>
10731
10732         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
10733         (dwarf2_per_objfile::free_cached_comp_units)
10734         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
10735         (init_cutu_and_read_dies_no_follow): Update.
10736         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
10737         (dwarf2_cu::~dwarf2_cu): New.
10738         (free_heap_comp_unit, free_stack_comp_unit): Remove.
10739         (age_cached_comp_units, free_one_cached_comp_unit): Update.
10740
10741 2018-01-17  Tom Tromey  <tom@tromey.com>
10742             Simon Marchi  <simon.marchi@ericsson.com>
10743
10744         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
10745         (struct die_reader_specs) <abbrev_table>: New member.
10746         (struct abbrev_table): Add constructor.
10747         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
10748         <abbrev_obstack>: Now an auto_obstack.
10749         (abbrev_table_up): New typedef.
10750         (init_cu_die_reader): Add abbrev_table parameter.
10751         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
10752         Add result_dwo_abbrev_table.
10753         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
10754         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
10755         Update.
10756         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
10757         parameter.
10758         (skip_children): Update.
10759         (abbrev_table::alloc_abbrev): Rename from
10760         abbrev_table_alloc_abbrev.
10761         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
10762         (abbrev_table::lookup_abbrev): Rename from
10763         abbrev_table_lookup_abbrev.
10764         (abbrev_table_read_table): Return abbrev_table_up.
10765         (abbrev_table_free, abbrev_table_free_cleanup)
10766         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
10767         (load_partial_dies): Update.
10768
10769 2018-01-17  Tom Tromey  <tom@tromey.com>
10770
10771         * dwarf2read.c (dwarf2_compute_name): Update comment.
10772         (read_func_scope, read_variable): Update.
10773         (new_symbol): Remove.
10774         (new_symbol_full): Rename to new_symbol.
10775
10776 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
10777
10778         PR gdb/16577
10779         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
10780         a warning instead of throwing an error, set section size to 0 and return
10781         NULL.
10782         * gdb_bfd.h (gdb_bfd_map_section): Update description.
10783
10784 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
10785
10786         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
10787         std::string.
10788         (linux_ptrace_attach_fail_reason_string): Likewise.
10789         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
10790         Likewise.
10791         (linux_ptrace_attach_fail_reason_string): Likewise.
10792         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
10793
10794 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
10795
10796         * linux-nat.c (linux_nat_attach): Remove xstrdup.
10797
10798 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
10799
10800         PR gdb/21559
10801         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
10802         checking for fs_base/gs_base fields in struct user_regs_struct.
10803         * configure: Regenerate.
10804
10805 2018-01-17  Yao Qi  <yao.qi@linaro.org>
10806
10807         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
10808         function.
10809         (aarch64_linux_init_abi): Install it to gdbarch hook
10810         gcc_target_options.
10811
10812 2018-01-15  Pedro Alves  <palves@redhat.com>
10813
10814         * common/signals-state-save-restore.c
10815         (save_original_signals_state): Fix typos.
10816
10817 2017-01-12  Tom Tromey  <tom@tromey.com>
10818             Sergio Durigan Junior  <sergiodj@redhat.com>
10819
10820         * Makefile.in (install-only): Install gdb-add-index.
10821
10822 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
10823
10824         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
10825
10826 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10827
10828         * infrun.c (keep_going_pass_signal): Clear step-over info when
10829         insert_breakpoints fails.
10830
10831 2018-01-11  Pedro Alves  <palves@redhat.com>
10832
10833         PR gdb/22583
10834         * infrun.c (resume): Rename to ...
10835         (resume_1): ... this.
10836         (resume): Reimplement as wrapper around resume_1.
10837
10838 2018-01-11  Pedro Alves  <palves@redhat.com>
10839
10840         PR remote/22597
10841         * remote.c (remote_parse_stop_reply): Default to the last-set
10842         general thread instead of to 'magic_null_ptid'.
10843
10844 2018-01-10  Pedro Alves  <palves@redhat.com>
10845
10846         * language.h (language_get_symbol_name_matcher): Rename ...
10847         (get_symbol_name_matcher): ... this.
10848         * language.c (language_get_symbol_name_matcher): Ditto.
10849         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
10850         callers adjusted.
10851
10852 2018-01-10  Pedro Alves  <palves@redhat.com>
10853
10854         PR gdb/22670
10855         * dwarf2read.c
10856         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
10857         Adjust to use language_get_symbol_name_matcher instead of
10858         language_defn::la_get_symbol_name_matcher.
10859         * language.c (language_get_symbol_name_matcher): If in Ada mode
10860         and the lookup name is a verbatim match, return Ada's matcher.
10861         * language.h (language_get_symbol_name_matcher): Adjust comment.
10862         (ada_lookup_name_info::verbatim_p):: New method.
10863
10864 2018-01-10  Pedro Alves  <palves@redhat.com>
10865
10866         PR gdb/22670
10867         * ada-lang.c (ada_collect_symbol_completion_matches): If the
10868         minsym's language is language_auto or language_cplus, pass down
10869         language_ada instead.
10870         * symtab.c (compare_symbol_name): Don't frob symbol language here.
10871
10872 2018-01-10  Pedro Alves  <palves@redhat.com>
10873
10874         PR gdb/22670
10875         * minsyms.c (linkage_name_str): New function.
10876         (iterate_over_minimal_symbols): Use it.
10877
10878 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10879
10880         * NEWS: Document that 'info proc' now works on FreeBSD.
10881
10882 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10883
10884         * configure.ac: Check for kinfo_getfile in libutil.
10885         * configure: Regenerate.
10886         * config.in: Regenerate.
10887         * fbsd-nat.c: Include "fbsd-tdep.h".
10888         (fbsd_fetch_cmdline): New.
10889         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
10890         rather than calling error.
10891         (fbsd_info_proc): New.
10892         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
10893         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
10894         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
10895
10896 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10897
10898         * fbsd-nat.c (struct free_deleter): Remove.
10899         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
10900
10901 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10902
10903         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
10904         NULL for an empty pathname.
10905
10906 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10907
10908         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
10909         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
10910         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
10911         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
10912         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
10913         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
10914         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
10915         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
10916         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
10917         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
10918         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
10919         (fbsd_core_fetch_timeval, fbsd_print_sigset)
10920         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
10921         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
10922         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
10923
10924 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
10925
10926         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
10927         (gnu_xfer_auxv): New function.
10928         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
10929         TARGET_OBJECT_AUXV.
10930
10931 2018-01-08  Yao Qi  <yao.qi@linaro.org>
10932             Simon Marchi  <simon.marchi@ericsson.com>
10933
10934         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
10935         common/selftest.c.
10936         (COMMON_OBS): Remove selftest.o.
10937         * configure.ac: Append selftest-arch.c and common/selftest.c to
10938         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
10939         * configure: Re-generated.
10940         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
10941         GDB_SELF_TEST.
10942         (maintenance_info_selftests): Likewise.
10943
10944 2018-01-08  Xavier Roirand  <roirand@adacore.com>
10945
10946         * ada-valprint.c (val_print_packed_array_elements): Use
10947         proper number of elements when printing an array indexed
10948         by an enumeration type.
10949
10950 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
10951
10952         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
10953         (dw2_get_file_names_reader): Adjust.
10954         (lookup_dwo_signatured_type): Adjust.
10955         (lookup_dwp_signatured_type): Adjust.
10956         (lookup_signatured_type): Adjust.
10957         (create_type_unit_group): Adjust.
10958         (get_type_unit_group): Adjust.
10959         (process_psymtab_comp_unit_reader): Adjust.
10960         (build_type_psymtabs_reader): Adjust.
10961         (scan_partial_symbols): Adjust.
10962         (add_partial_symbol): Adjust.
10963         (add_partial_subprogram): Adjust.
10964         (peek_die_abbrev): Adjust.
10965         (fixup_go_packaging): Adjust.
10966         (process_imported_unit_die): Adjust.
10967         (dwarf2_compute_name): Adjust.
10968         (dwarf2_physname): Adjust.
10969         (read_import_statement): Adjust.
10970         (handle_DW_AT_stmt_list): Adjust.
10971         (read_file_scope): Adjust.
10972         (read_func_scope): Adjust.
10973         (read_lexical_block_scope): Adjust.
10974         (read_call_site_scope): Adjust.
10975         (read_variable): Adjust.
10976         (dwarf2_rnglists_process): Adjust.
10977         (dwarf2_ranges_process): Adjust.
10978         (dwarf2_ranges_read): Adjust.
10979         (dwarf2_get_pc_bounds): Adjust.
10980         (dwarf2_record_block_ranges): Adjust.
10981         (dwarf2_add_field): Adjust.
10982         (dwarf2_add_member_fn): Adjust.
10983         (read_structure_type): Adjust.
10984         (process_structure_scope): Adjust.
10985         (read_enumeration_type): Adjust.
10986         (read_array_type): Adjust.
10987         (mark_common_block_symbol_computed): Adjust.
10988         (read_common_block): Adjust.
10989         (read_namespace_type): Adjust.
10990         (read_namespace): Adjust.
10991         (read_module_type): Adjust.
10992         (read_tag_pointer_type): Adjust.
10993         (read_tag_ptr_to_member_type): Adjust.
10994         (read_tag_string_type): Adjust.
10995         (read_subroutine_type): Adjust.
10996         (read_typedef): Adjust.
10997         (read_base_type): Adjust.
10998         (attr_to_dynamic_prop): Adjust.
10999         (read_subrange_type): Adjust.
11000         (read_unspecified_type): Adjust.
11001         (dwarf2_read_abbrevs): Adjust.
11002         (load_partial_dies): Adjust.
11003         (read_partial_die): Adjust.
11004         (find_partial_die): Adjust.
11005         (guess_partial_die_structure_name): Adjust.
11006         (fixup_partial_die): Adjust.
11007         (read_attribute_value): Adjust.
11008         (read_addr_index): Adjust.
11009         (read_addr_index_from_leb128): Adjust.
11010         (read_str_index): Adjust.
11011         (dwarf2_string_attr): Adjust.
11012         (get_debug_line_section): Adjust.
11013         (dwarf_decode_line_header): Adjust.
11014         (lnp_state_machine::check_line_address): Adjust.
11015         (dwarf_decode_lines_1): Adjust.
11016         (dwarf_decode_lines): Adjust.
11017         (dwarf2_start_symtab): Adjust.
11018         (var_decode_location): Adjust.
11019         (new_symbol_full): Adjust.
11020         (dwarf2_const_value_data): Adjust.
11021         (dwarf2_const_value_attr): Adjust.
11022         (dwarf2_const_value): Adjust.
11023         (die_type): Adjust.
11024         (die_containing_type): Adjust.
11025         (build_error_marker_type): Adjust.
11026         (lookup_die_type): Adjust.
11027         (guess_full_die_structure_name): Adjust.
11028         (anonymous_struct_prefix): Adjust.
11029         (determine_prefix): Adjust.
11030         (dwarf2_name): Adjust.
11031         (follow_die_ref_or_sig): Adjust.
11032         (follow_die_offset): Adjust.
11033         (follow_die_ref): Adjust.
11034         (follow_die_sig_1): Adjust.
11035         (follow_die_sig): Adjust.
11036         (get_signatured_type): Adjust.
11037         (get_DW_AT_signature_type): Adjust.
11038         (decode_locdesc): Adjust.
11039         (dwarf_decode_macros): Adjust.
11040         (cu_debug_loc_section): Adjust.
11041         (fill_in_loclist_baton): Adjust.
11042         (dwarf2_symbol_mark_computed): Adjust.
11043         (init_one_comp_unit): Don't assign
11044         dwarf2_cu::dwarf2_per_objfile.
11045         (set_die_type): Adjust.
11046
11047 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
11048
11049         * dwarf2read.c (struct mapped_debug_names): Add constructor.
11050         <dwarf2_per_objfile>: New field.
11051         (dwarf2_per_objfile): Remove global.
11052         (get_dwarf2_per_objfile): New function.
11053         (set_dwarf2_per_objfile): New function.
11054         (dwarf2_build_psymtabs_hard): Change objfile parameter to
11055         dwarf2_per_objfile.
11056         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
11057         (read_abbrev_offset): Likewise.
11058         (read_indirect_string): Likewise.
11059         (read_indirect_line_string): Likewise.
11060         (read_indirect_string_at_offset): Likewise.
11061         (read_indirect_string_from_dwz): Likewise.
11062         (dwarf2_find_containing_comp_unit): Change objfile parameter to
11063         dwarf2_per_objfile.
11064         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
11065         (create_all_comp_units): Change objfile parameter to
11066         dwarf2_per_objfile.
11067         (create_all_type_units): Likewise.
11068         (process_queue): Add dwarf2_per_objfile parameter.
11069         (read_and_check_comp_unit_head): Likewise.
11070         (lookup_dwo_unit_in_dwp): Likewise.
11071         (get_dwp_file): Likewise.
11072         (process_cu_includes): Likewise.
11073         (struct free_dwo_file_cleanup_data): New struct.
11074         (dwarf2_has_info): Use get_dwarf2_per_objfile and
11075         set_dwarf2_per_objfile.
11076         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
11077         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
11078         context, adjust calls.
11079         (dw2_instantiate_symtab): Likewise.
11080         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
11081         (dw2_get_cu): Likewise.
11082         (create_cu_from_index_list): Change objfile parameter to
11083         dwarf2_per_objfile.
11084         (create_cus_from_index_list): Get dwarf2_per_objfile from
11085         context, adjust calls.
11086         (create_cus_from_index): Likewise.
11087         (create_signatured_type_table_from_index): Change objfile
11088         parameter to dwarf2_per_objfile.
11089         (create_signatured_type_table_from_debug_names): Change objfile
11090         parameter to dwarf2_per_objfile.
11091         (create_addrmap_from_index): Likewise.
11092         (create_addrmap_from_aranges): Likewise.
11093         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
11094         (dw2_setup): Remove.
11095         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
11096         context.
11097         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
11098         get_dwarf2_per_objfile.
11099         (dw2_forget_cached_source_info): Likewise.
11100         (dw2_map_symtabs_matching_filename): Likewise.
11101         (struct dw2_symtab_iterator) <index>: Remove.
11102         <dwarf2_per_objfile>: New field.
11103         (dw2_symtab_iter_init): Replace index parameter with
11104         dwarf2_per_objfile.
11105         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
11106         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
11107         (dw2_print_stats): Likewise.
11108         (dw2_dump): Likewise.
11109         (dw2_expand_symtabs_for_function): Likewise.
11110         (dw2_expand_all_symtabs): Likewise.
11111         (dw2_expand_symtabs_with_fullname): Likewise.
11112         (dw2_expand_marked_cus): Replace index and objfile parameters
11113         with dwarf2_per_objfile.
11114         (dw_expand_symtabs_matching_file_matcher): Add
11115         dwarf2_per_objfile parameter and adjust calls.
11116         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
11117         adjust calls.
11118         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
11119         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
11120         adjust calls.
11121         (create_cus_from_debug_names_list): Replace objfile parameter
11122         with dwarf2_per_objfile and adjust calls.
11123         (create_cus_from_debug_names): Likewise.
11124         (dwarf2_read_debug_names): Likewise.
11125         (mapped_debug_names::namei_to_name): Adjust call.
11126         (dw2_debug_names_iterator::next): Likewise.
11127         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
11128         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
11129         (dw2_debug_names_dump): Likewise.
11130         (dw2_debug_names_expand_symtabs_for_function): Likewise.
11131         (dw2_debug_names_expand_symtabs_matching): Likewise.
11132         (dwarf2_initialize_objfile): Likewise.
11133         (dwarf2_build_psymtabs): Likewise.
11134         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
11135         this_cu.
11136         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
11137         (read_and_check_comp_unit_head): Likewise.
11138         (read_abbrev_offset): Likewise.
11139         (create_debug_type_hash_table): Likewise.
11140         (create_debug_types_hash_table): Likewise.
11141         (create_all_type_units): Replace objfile parameter with
11142         dwarf2_per_objfile.
11143         (add_type_unit): Add dwarf2_per_objfile parameter.
11144         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
11145         with dwarf2_per_objfile.
11146         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
11147         (lookup_dwp_signatured_type): Likewise.
11148         (lookup_signatured_type): Likewise.
11149         (read_cutu_die_from_dwo): Likewise.
11150         (init_tu_and_read_dwo_dies): Likewise.
11151         (init_cutu_and_read_dies): Likewise.
11152         (init_cutu_and_read_dies_no_follow): Likewise.
11153         (allocate_type_unit_groups_table): Add objfile parameter.
11154         (create_type_unit_group): Use dwarf2_per_objfile from cu.
11155         (get_type_unit_group): Likewise.
11156         (process_psymtab_comp_unit): Update call.
11157         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
11158         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
11159         (print_tu_stats): Likewise.
11160         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
11161         in void* parameter.
11162         (build_type_psymtabs): Change objfile parameter to
11163         dwarf2_per_objfile.
11164         (process_skeletonless_type_unit): Use dwarf2_per_objfile
11165         passed in void* parameter.
11166         (process_skeletonless_type_units): Change objfile parameter to
11167         dwarf2_per_objfile.
11168         (set_partial_user): Likewise.
11169         (dwarf2_build_psymtabs_hard): Likewise.
11170         (read_comp_units_from_section): Likewise.
11171         (create_all_comp_units): Likewise.
11172         (scan_partial_symbols): Update calls.
11173         (add_partial_symbol): Likewise.
11174         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
11175         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
11176         (process_queue): Add dwarf2_per_objfile parameter.
11177         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
11178         (compute_compunit_symtab_includes): Likewise.
11179         (process_cu_includes): Add dwarf2_per_objfile parameter.
11180         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
11181         (process_full_type_unit): Likewise.
11182         (process_imported_unit_die): Update call.
11183         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
11184         (read_file_scope): Likewise.
11185         (allocate_dwo_file_hash_table): Add objfile parameter.
11186         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
11187         (create_cus_hash_table): Likewise.
11188         (create_dwp_hash_table): Likewise.
11189         (create_dwo_unit_in_dwp_v1): Likewise.
11190         (create_dwp_v2_section): Likewise.
11191         (create_dwo_unit_in_dwp_v2): Likewise.
11192         (lookup_dwo_unit_in_dwp): Likewise.
11193         (try_open_dwop_file): Likewise.
11194         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
11195         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
11196         cleanup to include a reference to dwarf2_per_objfile.
11197         (open_dwp_file): Add dwarf2_per_objfile parameter.
11198         (open_and_init_dwp_file): Likewise.
11199         (get_dwp_file): Likewise.
11200         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
11201         (queue_and_load_all_dwo_tus): Update call.
11202         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
11203         data.
11204         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
11205         (dwarf2_ranges_process): Likewise.
11206         (dwarf2_get_pc_bounds): Likewise.
11207         (mark_common_block_symbol_computed): Likewise.
11208         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
11209         (dwarf2_read_abbrevs): Update call.
11210         (read_partial_die): Use dwarf2_per_objfile from cu.
11211         (find_partial_die): Likewise.
11212         (fixup_partial_die): Likewise.
11213         (read_attribute_value): Likewise.
11214         (read_indirect_string_at_offset_from): Add objfile parameter.
11215         (read_indirect_string_at_offset): Add dwarf2_per_objfile
11216         parameter.
11217         (read_indirect_string_from_dwz): Add objfile parameter.
11218         (read_indirect_string): Add objfile parameter.
11219         (read_addr_index_1): Add dwarf2_per_objfile parameter.
11220         (read_addr_index): Use dwarf2_per_objfile from cu.
11221         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
11222         call dw2_setup.
11223         (read_str_index): Use dwarf2_per_objfile from cu.
11224         (get_debug_line_section): Likewise.
11225         (read_formatted_entries): Add dwarf2_per_objfile parameter.
11226         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
11227         (new_symbol_full): Use dwarf2_per_objfile from cu.
11228         (build_error_marker_type): Likewise.
11229         (lookup_die_type): Likewise.
11230         (determine_prefix): Likewise.
11231         (follow_die_offset): Likewise.
11232         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
11233         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
11234         (dwarf2_fetch_die_type_sect_off): Likewise.
11235         (dwarf2_get_die_type): Likewise.
11236         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
11237         (get_signatured_type): Likewise.
11238         (get_DW_AT_signature_type): Likewise.
11239         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
11240         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
11241         (cu_debug_loc_section): Likewise.
11242         (fill_in_loclist_baton): Likewise.
11243         (dwarf2_symbol_mark_computed): Likewise.
11244         (dwarf2_find_containing_comp_unit): Change objfile parameter to
11245         dwarf2_per_objfile.
11246         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
11247         parameter.
11248         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
11249         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
11250         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
11251         (set_die_type): Use dwarf2_free_objfile from cu.
11252         (get_die_type_at_offset): Likewise.
11253         (dwarf2_per_objfile_free): Don't assign global variable.
11254         (debug_names) <constructor>: Add dwarf2_per_objfile
11255         parameter, update m_debugstrlookup construction.
11256         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
11257         parameter.
11258         <m_dwarf2_per_objfile>: New field.
11259         <lookup>: Use m_dwarf2_per_objfile.
11260         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
11261         (psyms_seen_size): Likewise.
11262         (write_gdbindex): Replace objfile parameter with
11263         dwarf2_per_objfile.
11264         (write_debug_names): Likewise.
11265         (write_psymtabs_to_index): Likewise.
11266         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
11267         calls.
11268
11269 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
11270
11271         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
11272         <dwarf2_per_objfile>: New field.
11273         (struct dwarf2_per_cu_data) <objfile>: Remove.
11274         <dwarf2_per_objfile>: New field.
11275         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
11276         of objfile.
11277         (create_signatured_type_table_from_index): Likewise.
11278         (create_debug_type_hash_table): Likewise.
11279         (fill_in_sig_entry_from_dwo_entry): Likewise.
11280         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
11281         (create_type_unit_group): Assign dwarf2_per_objfile instead of
11282         objfile.
11283         (create_partial_symtab): Access objfile through
11284         dwarf2_per_objfile.
11285         (process_psymtab_comp_unit_reader): Likewise.
11286         (read_comp_units_from_section): Likewise.
11287         (scan_partial_symbols): Likewise.
11288         (add_partial_symbol): Likewise.
11289         (add_partial_subprogram): Likewise.
11290         (peek_die_abbrev): Likewise.
11291         (fixup_go_packaging): Likewise.
11292         (process_full_comp_unit): Likewise.
11293         (process_full_type_unit): Likewise.
11294         (process_imported_unit_die): Likewise.
11295         (dwarf2_compute_name): Likewise.
11296         (dwarf2_physname): Likewise.
11297         (read_import_statement): Likewise.
11298         (create_cus_hash_table): Assign dwarf2_physname instead of
11299         objfile.
11300         (read_func_scope): Access objfile through dwarf2_per_objfile.
11301         (read_lexical_block_scope): Likewise.
11302         (read_call_site_scope): Likewise.
11303         (read_variable): Likewise.
11304         (dwarf2_rnglists_process): Likewise.
11305         (dwarf2_ranges_process): Likewise.
11306         (dwarf2_ranges_read): Likewise.
11307         (dwarf2_record_block_ranges): Likewise.
11308         (dwarf2_add_field): Likewise.
11309         (dwarf2_add_member_fn): Likewise.
11310         (read_structure_type): Likewise.
11311         (process_structure_scope): Likewise.
11312         (read_enumeration_type): Likewise.
11313         (read_array_type): Likewise.
11314         (read_common_block): Likewise.
11315         (read_namespace_type): Likewise.
11316         (read_namespace): Likewise.
11317         (read_module_type): Likewise.
11318         (read_tag_pointer_type): Likewise.
11319         (read_tag_ptr_to_member_type): Likewise.
11320         (read_tag_string_type): Likewise.
11321         (read_subroutine_type): Likewise.
11322         (read_typedef): Likewise.
11323         (read_base_type): Likewise.
11324         (attr_to_dynamic_prop): Likewise.
11325         (read_subrange_type): Likewise.
11326         (read_unspecified_type): Likewise.
11327         (load_partial_dies): Likewise.
11328         (read_partial_die): Likewise.
11329         (find_partial_die): Likewise.
11330         (guess_partial_die_structure_name): Likewise.
11331         (fixup_partial_die): Likewise.
11332         (read_attribute_value): Likewise.
11333         (read_addr_index_from_leb128): Likewise.
11334         (dwarf2_read_addr_index): Likewise.
11335         (dwarf2_string_attr): Likewise.
11336         (lnp_state_machine::check_line_address): Likewise.
11337         (dwarf_decode_lines_1): Likewise.
11338         (dwarf_decode_lines): Likewise.
11339         (dwarf2_start_symtab): Likewise.
11340         (var_decode_location): Likewise.
11341         (new_symbol_full): Likewise.
11342         (dwarf2_const_value_data): Likewise.
11343         (dwarf2_const_value_attr): Likewise.
11344         (dwarf2_const_value): Likewise.
11345         (die_type): Likewise.
11346         (die_containing_type): Likewise.
11347         (lookup_die_type): Likewise.
11348         (guess_full_die_structure_name): Likewise.
11349         (anonymous_struct_prefix): Likewise.
11350         (dwarf2_name): Likewise.
11351         (follow_die_ref_or_sig): Likewise.
11352         (follow_die_offset): Likewise.
11353         (follow_die_ref): Likewise.
11354         (dwarf2_fetch_die_loc_sect_off): Likewise.
11355         (dwarf2_fetch_constant_bytes): Likewise.
11356         (dwarf2_fetch_die_type_sect_off): Likewise.
11357         (dwarf2_get_die_type): Likewise.
11358         (follow_die_sig): Likewise.
11359         (decode_locdesc): Likewise.
11360         (dwarf2_per_cu_objfile): Likewise.
11361         (dwarf2_per_cu_text_offset): Likewise.
11362         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
11363         objfile.
11364         (set_die_type): Access objfile through
11365         dwarf2_per_objfile.
11366
11367 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
11368
11369         * valprint.c (converted_character_d): Remove typedef.
11370         (DEF_VEC_O (converted_character_d)): Remove.
11371         (count_next_character): Use std::vector.
11372         (print_converted_chars_to_obstack): Likewise.
11373         (generic_printstr): Likewise.
11374
11375 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11376
11377         * xml-support.h (struct gdb_xml_value): Add constructor.
11378         <value>: Change type to unique_xmalloc_ptr.
11379         (gdb_xml_value_s): Remove typedef.
11380         (DEF_VEC_O (gdb_xml_value_s)): Remove.
11381         (gdb_xml_element_start_handler): Change parameter type to
11382         std::vector.
11383         (xml_find_attribute): Likewise.
11384         * xml-support.c (xml_find_attribute): Change parameter type to
11385         std::vector and adjust.
11386         (gdb_xml_values_cleanup): Remove.
11387         (gdb_xml_parser::start_element): Adjust to std::vector.
11388         (xinclude_start_include): Change paraeter type to std::vector
11389         and adjust.
11390         * btrace.c (check_xml_btrace_version): Likewise.
11391         (parse_xml_btrace_block): Likewise.
11392         (parse_xml_btrace_pt_config_cpu): Likewise.
11393         (parse_xml_btrace_pt): Likewise.
11394         (parse_xml_btrace_conf_bts): Likewise.
11395         (parse_xml_btrace_conf_pt): Likewise.
11396         * memory-map.c (memory_map_start_memory): Likewise.
11397         (memory_map_start_property): Likewise.
11398         * osdata.c (osdata_start_osdata): Likewise.
11399         (osdata_start_item): Likewise.
11400         (osdata_start_column): Likewise.
11401         * remote.c (start_thread): Likewise.
11402         * solib-aix.c (library_list_start_library): Likewise.
11403         (library_list_start_list): Likewise.
11404         * solib-svr4.c (library_list_start_library): Likewise.
11405         (svr4_library_list_start_list): Likewise.
11406         * solib-target.c (library_list_start_segment): Likewise.
11407         (library_list_start_section): Likewise.
11408         (library_list_start_library): Likewise.
11409         (library_list_start_list): Likewise.
11410         * tracepoint.c (traceframe_info_start_memory): Likewise.
11411         (traceframe_info_start_tvar): Likewise.
11412         * xml-syscall.c (syscall_start_syscall): Likewise.
11413         * xml-tdesc.c (tdesc_start_target): Likewise.
11414         (tdesc_start_feature): Likewise.
11415         (tdesc_start_reg): Likewise.
11416         (tdesc_start_union): Likewise.
11417         (tdesc_start_struct): Likewise.
11418         (tdesc_start_flags): Likewise.
11419         (tdesc_start_enum): Likewise.
11420         (tdesc_start_field): Likewise.
11421         (tdesc_start_enum_value): Likewise.
11422         (tdesc_start_vector): Likewise.
11423
11424 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11425
11426         * extension.h (struct xmethod_worker) <clone>: Remove.
11427         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
11428         Remove.
11429         (python_xmethod_worker::clone): Remove.
11430         * valops.c (find_overload_match): Use std::move instead of
11431         clone.
11432
11433 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11434
11435         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
11436         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
11437         <free_xmethod_worker_data>: Remove.
11438         <get_matching_xmethod_workers>: Chance VEC to std::vector.
11439         <get_xmethod_arg_types>: Remove.
11440         <get_xmethod_result_type>: Remove.
11441         <invoke_xmethod>: Remove.
11442         * extension.c (new_xmethod_worker): Remove.
11443         (clone_xmethod_worker): Remove.
11444         (get_matching_xmethod_workers): Return void, pass std::vector by
11445         pointer.
11446         (get_xmethod_arg_types): Rename to...
11447         (xmethod_worker::get_arg_types): ... this, and adjust.
11448         (get_xmethod_result_type): Rename to...
11449         (xmethod_worker::get_result_type): ... this, and adjust.
11450         (invoke_xmethod): Remove.
11451         (free_xmethod_worker): Remove.
11452         (free_xmethod_worker_vec): Remove.
11453         * extension.h (enum ext_lang_rc): Move here from
11454         extension-priv.h.
11455         (struct xmethod_worker): Add constructor and destructor.
11456         <data>: Remove.
11457         <value>: Remove.
11458         <invoke, clone, do_get_result_type, do_get_arg_types>: New
11459         virtual pure methods.
11460         <get_arg_types, get_result_type>: New methods.
11461         (xmethod_worker_ptr): Remove typedef.
11462         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
11463         (xmethod_worker_vec): Remove typedef.
11464         (xmethod_worker_up): New typedef.
11465         (invoke_xmethod): Remove.
11466         (clone_xmethod_worker): Remove.
11467         (free_xmethod_worker): Remove.
11468         (free_xmethod_worker_vec): Remove.
11469         (get_xmethod_arg_types): Remove.
11470         (get_xmethod_result_type): Remove.
11471         * valops.c (find_method_list): Use std::vector, don't use
11472         intermediate vector.
11473         (value_find_oload_method_list): Use std::vector.
11474         (find_overload_match): Use std::vector.
11475         (find_oload_champ): Use std::vector.
11476         * value.c (value_free): Use operator delete.
11477         (value_of_xmethod): Rename to...
11478         (value_from_xmethod): ... this.  Don't assign
11479         xmethod_worker::value, take rvalue-reference.
11480         (result_type_of_xmethod): Adjust.
11481         (call_xmethod): Adjust.
11482         * value.h: Include extension.h.
11483         (struct xmethod_worker): Don't forward-declare.
11484         (value_of_xmethod): Rename to...
11485         (value_from_xmethod): ... this, take rvalue-reference.
11486         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
11487         (struct python_xmethod_worker): ... this, add constructor and
11488         destructor.
11489         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
11490         (gdbpy_free_xmethod_worker_data): Rename to...
11491         (python_xmethod_worker::~python_xmethod_worker): ... this and
11492         adjust.
11493         (gdbpy_clone_xmethod_worker_data): Rename to...
11494         (python_xmethod_worker::clone): ... this and adjust.
11495         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
11496         temporary vector.
11497         (gdbpy_get_xmethod_arg_types): Rename to...
11498         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
11499         (gdbpy_get_xmethod_result_type): Rename to...
11500         (python_xmethod_worker::do_get_result_type): ... this and
11501         adjust.
11502         (gdbpy_invoke_xmethod): Rename to...
11503         (python_xmethod_worker::invoke): ... this and adjust.
11504         (new_python_xmethod_worker): Rename to...
11505         (python_xmethod_worker::python_xmethod_worker): ... this and
11506         adjust.
11507         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
11508         Remove.
11509         (gdbpy_free_xmethod_worker_data): Remove.
11510         (gdbpy_get_matching_xmethod_workers): Use std::vector.
11511         (gdbpy_get_xmethod_arg_types): Remove.
11512         (gdbpy_get_xmethod_result_type): Remove.
11513         (gdbpy_invoke_xmethod): Remove.
11514         * python/python.c (python_extension_ops): Remove obsolete
11515         callbacks.
11516
11517 2018-01-05  Pedro Alves  <palves@redhat.com>
11518
11519         PR gdb/18653
11520         * common/signals-state-save-restore.c
11521         (save_original_signals_state): New parameter 'quiet'.  Warn if we
11522         find a custom handler preinstalled, instead of internal erroring.
11523         But only warn if !quiet.
11524         * common/signals-state-save-restore.h
11525         (save_original_signals_state): New parameter 'quiet'.
11526         * main.c (captured_main_1): Move save_original_signals_state call
11527         after option handling, and pass QUIET.
11528
11529 2018-01-05  Pedro Alves  <palves@redhat.com>
11530
11531         * spu-tdep.c (spu_catch_start): Pass
11532         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
11533
11534 2018-01-05  Pedro Alves  <palves@redhat.com>
11535
11536         PR gdb/22670
11537         * ada-lang.c (literal_symbol_name_matcher): New function.
11538         (ada_get_symbol_name_matcher): Use it for
11539         symbol_name_match_type::SEARCH_NAME.
11540         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
11541         it down instead of assuming symbol_name_match_type::FULL.
11542         * block.h (block_lookup_symbol): New parameter 'match_type'.
11543         * c-valprint.c (print_unpacked_pointer): Use
11544         lookup_symbol_search_name instead of lookup_symbol.
11545         * compile/compile-object-load.c (get_out_value_type): Pass down
11546         symbol_name_match_type::SEARCH_NAME.
11547         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
11548         symbol_name_match_type::FULL.
11549         * cp-support.c (cp_get_symbol_name_matcher): Handle
11550         symbol_name_match_type::SEARCH_NAME.
11551         * infrun.c (insert_exception_resume_breakpoint): Use
11552         lookup_symbol_search_name.
11553         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
11554         * psymtab.c (maintenance_check_psymtabs): Use
11555         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
11556         * stack.c (print_frame_args): Use lookup_symbol_search_name and
11557         SYMBOL_SEARCH_NAME.
11558         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
11559         if symbol_name_match_type::SEARCH_NAME.
11560         (lookup_symbol_in_language): Pass down
11561         symbol_name_match_type::FULL.
11562         (lookup_symbol_search_name): New.
11563         (lookup_language_this): Pass down
11564         symbol_name_match_type::SEARCH_NAME.
11565         (lookup_symbol_aux, lookup_local_symbol): New parameter
11566         'match_type'.  Pass it down.
11567         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
11568         (lookup_symbol_search_name): New declaration.
11569         (lookup_symbol_in_block): New 'match_type' parameter.
11570
11571 2018-01-05  Pedro Alves  <palves@redhat.com>
11572
11573         PR gdb/22670
11574         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
11575         ada_lookup_symbol.
11576         (ada_lookup_symbol): Reimplement in terms of
11577         ada_lookup_symbol_list, bits factored out from
11578         ada_lookup_encoded_symbol.
11579
11580 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11581
11582         * ada-exp.y (write_object_renaming): When subscripting an array
11583         using a symbol as the index, pass the block in call to
11584         ada_lookup_encoded_symbol when looking that symbol up.
11585
11586 2018-01-05  Jerome Guitton  <guitton@adacore.com>
11587
11588         * ada-lang.c (ada_array_length): Use ada_index_type instead of
11589         TYPE_INDEX_TYPE.
11590
11591 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11592
11593         * ada-lang.c (ada_to_fixed_value_create): Add handling of
11594         the case where VALUE_LVAL (val0) is not lval_memory.
11595
11596 2018-01-05  Xavier Roirand  <roirand@adacore.com>
11597
11598         * ada-valprint.c (print_optional_low_bound): Handle
11599         character-indexed array printing like boolean-indexed array
11600         printing.
11601
11602 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11603
11604         * NEWS: Create a new section for the next release branch.
11605         Rename the section of the current branch, now that it has
11606         been cut.
11607
11608 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11609
11610         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
11611         * version.in: Bump version to 8.1.50.DATE-git.
11612
11613 2018-01-03  Xavier Roirand  <roirand@adacore.com>
11614
11615         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
11616         Add field.
11617         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
11618         Add field.
11619         (default_exception_support_info) <catch_handlers_sym>: Add field.
11620         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
11621         (ada_exception_name_addr_1): Add "catch handlers" handling.
11622         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
11623         Update all callers.
11624         (create_excep_cond_exprs) <ex>: Add parameter.
11625         (re_set_exception): Update create_excep_cond_exprs call.
11626         (print_it_exception, print_one_exception, print_mention_exception)
11627         (print_recreate_exception): Add "catch handler" handling.
11628         (allocate_location_catch_handlers, re_set_catch_handlers)
11629         (check_status_catch_handlers, print_it_catch_handlers)
11630         (print_one_catch_handlers, print_mention_catch_handlers)
11631         (print_recreate_catch_handlers): New function.
11632         (catch_handlers_breakpoint_ops): New variable.
11633         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
11634         Add parameter.  Add "catch handler" handling.
11635         (ada_exception_sym_name, ada_exception_breakpoint_ops):
11636         Add "catch handler" handling.
11637         (ada_exception_catchpoint_cond_string): Add "catch handler"
11638         handling.
11639         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
11640         call.
11641         (catch_ada_handlers_command): New function.
11642         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
11643         operations structure.
11644         (_initialize_ada_language): Add "catch handlers" command entry.
11645         * NEWS: Document "catch handlers" feature.
11646
11647 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11648
11649         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
11650         account when creating the array type of the slice.
11651         (ada_value_slice): Likewise.
11652
11653 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11654
11655         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
11656         New enum value.
11657         (create_array_type_with_stride): Add byte_stride_prop parameter.
11658         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
11659         New parameter.  Update all callers in this file.
11660         (array_type_has_dynamic_stride): New function.
11661         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
11662         of arrays with dynamic byte strides.
11663         * dwarf2read.c (read_array_type): Add support for dynamic
11664         DW_AT_byte_stride attributes.
11665
11666 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11667
11668         * dwarf2read.c (read_unspecified_type): Treat
11669         DW_TAG_enumeration_type DIEs from Ada units as stubs.
11670
11671 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11672
11673         Update copyright year range in all GDB files.
11674
11675 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11676
11677         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
11678         and gdb/testsuite/gdb.base/step-line.c.
11679
11680 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11681
11682         * copyright.py (main): Dump the contents of
11683         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
11684         even if BY_HAND is empty.
11685
11686 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11687
11688         * top.c (print_gdb_version): Update Copyright year in version
11689         message.
11690
11691 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11692
11693         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
11694
11695 For older changes see ChangeLog-2017.
11696 \f
11697 Local Variables:
11698 mode: change-log
11699 left-margin: 8
11700 fill-column: 74
11701 version-control: never
11702 coding: utf-8
11703 End: