gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_display_data_from): Don't declare.
   4         * tui/tui-windata.c (tui_display_data_from): Remove.
   5         (tui_data_window::refresh_all): Update.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  10         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  11         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  12         tui_display_registers_from_line.
  13         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  14         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  15         "force_display" parameter.
  16
  17 2019-07-17  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  20         declare.
  21         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  22         Rename from tui_first_reg_element_no_inline.
  23         (tui_display_reg_element_at_line)
  24         (tui_display_registers_from_line): Update.
  25         * tui/tui-data.h (struct tui_data_window)
  26         <first_reg_element_no_inline>: New method.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-windata.c (tui_display_data_from)
  31         (tui_data_window::do_scroll_vertical): Update.
  32         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  33         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  34         Rename from tui_line_from_reg_element_no.
  35         (tui_display_registers_from_line): Update.
  36         * tui/tui-data.h (struct tui_data_window)
  37         <line_from_reg_element_no>: New method.
  38
  39 2019-07-17  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  42         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  43         tui_last_regs_line_no.
  44         (tui_display_reg_element_at_line)
  45         (tui_display_registers_from_line): Update.
  46         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  47         method.
  48
  49 2019-07-17  Tom Tromey  <tom@tromey.com>
  50
  51         PR tui/24722:
  52         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  53         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  54         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  55         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  56         (tui_update_breakpoint_info): Likewise.
  57         * tui/tui-hooks.c (tui_event_create_breakpoint)
  58         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
  59         Update.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-winsource.c (tui_update_source_window_as_is)
  68         (tui_update_source_windows_with_addr): Update.
  69         * tui/tui-source.h (tui_set_source_content)
  70         (tui_show_symtab_source): Add "win_info" parameter.
  71         * tui/tui-source.c (tui_set_source_content): Add "win_info"
  72         parameter.
  73         (tui_show_symtab_source): Likewise.
  74
  75 2019-07-17  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-wingeneral.c
  78         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  79
  80 2019-07-17  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
  83         (struct tui_cmd_window) <can_scroll>: New method.
  84         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  85         method.
  86
  87 2019-07-17  Tom Tromey  <tromey@adacore.com>
  88
  89         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  90         do_field_signed>: Rename.  Change type of "value".
  91         * ui-out.c (ui_out::field_signed): Rename from field_int.
  92         Change type of "value".
  93         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  94         type of "value".
  95         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  96         do_field_int.  Change type of "value".
  97         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  98         do_field_int.  Change type of "value".
  99         * tracepoint.c (trace_status_mi, tfind_1)
 100         (print_one_static_tracepoint_marker): Update.
 101         * thread.c (print_thread_info_1, print_selected_thread_frame):
 102         Update.
 103         * stack.c (print_frame, print_frame_info): Update.
 104         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 105         Update.
 106         * source.c (print_source_lines_base): Update.
 107         * skip.c (info_skip_command): Update.
 108         * record-btrace.c (btrace_ui_out_decode_error)
 109         (btrace_call_history_src_line): Update.
 110         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 111         Update.
 112         * progspace.c (print_program_space): Update.
 113         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 114         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 115         do_field_int.  Change type of "value".
 116         * mi/mi-out.c (mi_ui_out::do_table_begin)
 117         (mi_ui_out::do_table_header): Update.
 118         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 119         type of "value".
 120         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 121         (mi_cmd_data_list_changed_registers, output_register)
 122         (mi_cmd_data_read_memory, mi_load_progress)
 123         (mi_cmd_trace_frame_collected): Update.
 124         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 125         Update.
 126         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 127         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 128         (mi_cmd_var_list_children, varobj_update_one): Update.
 129         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 130         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 132         * inferior.c (print_inferior): Update.
 133         * gdb_bfd.c (print_one_bfd): Update.
 134         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 135         Update.
 136         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 137         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 138         do_field_int.  Change type of "value".
 139         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 140         do_field_int.  Change type of "value".
 141         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 142         (print_one_breakpoint_location, print_it_catch_fork)
 143         (print_one_catch_fork, print_it_catch_vfork)
 144         (print_one_catch_vfork, print_it_catch_solib)
 145         (print_it_catch_exec, print_it_ranged_breakpoint)
 146         (print_mention_watchpoint, print_mention_masked_watchpoint)
 147         (bkpt_print_it, update_static_tracepoint): Update.
 148         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 149         * break-catch-syscall.c (print_it_catch_syscall): Update.
 150         * ada-tasks.c (print_ada_task_info): Update.
 151         * ada-lang.c (print_it_exception, print_mention_exception):
 152         Update.
 153
 154 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         PR breakpoints/24541
 157         * gdbarch.c: Regenerate.
 158         * gdbarch.h: Regenerate.
 159         * gdbarch.sh: Adjust return type and parameter types for
 160         'stap_adjust_register'.
 161         (i386_stap_adjust_register): Adjust signature and return new
 162         register name.
 163         * stap-probe.c (stap_parse_register_operand): Adjust use of
 164         'gdbarch_stap_adjust_register'.
 165
 166 2019-07-17  Tom Tromey  <tromey@adacore.com>
 167
 168         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 169         declare VEC.
 170         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 171         std::vector.
 172         (struct s390_process_info): Add initializers.
 173         (s390_add_process): Use new.
 174         (s390_linux_nat_target::low_forget_process): Use delete.
 175         (s390_linux_nat_target::low_new_fork)
 176         (s390_linux_nat_target::stopped_by_watchpoint)
 177         (s390_linux_nat_target::low_prepare_to_resume)
 178         (s390_linux_nat_target::insert_watchpoint)
 179         (s390_linux_nat_target::insert_hw_breakpoint)
 180         (s390_linux_nat_target::remove_watchpoint)
 181         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 182
 183 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 184
 185         * aarch64-fbsd-nat.c: Include regcache.h.
 186         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 187         argument.
 188         (aarch64_fbsd_nat_target::fetch_registers)
 189         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 190         variable.
 191         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 192
 193 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 194
 195         * fbsd-nat.c: Include gdbarch.h.
 196
 197 2019-07-15  Tom Tromey  <tromey@adacore.com>
 198
 199         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 200
 201 2019-07-15  Tom Tromey  <tromey@adacore.com>
 202
 203         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 204         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 205         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 206         * cli-out.c (cli_ui_out::do_field_int): New method.
 207         * ui-out.c (ui_out::field_unsigned): New method.
 208         * symfile.c (generic_load): Use field_unsigned.
 209         (print_transfer_performance): Likewise.
 210         * record-btrace.c (ui_out_field_uint): Remove.
 211         (btrace_call_history_insn_range, btrace_call_history): Use
 212         field_unsigned.
 213         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 214         field_unsigned.
 215         * ui-out.h (class ui_out) <field_unsigned>: New method.
 216         <do_field_unsigned>: Likewise.
 217
 218 2019-07-15  Tom Tromey  <tromey@adacore.com>
 219
 220         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 221         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 222         * target.c (flash_erase_command): Use field_string.
 223         * infrun.c (print_signal_received_reason): Use field_string.
 224         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 225         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 226         field_string.
 227         * ada-tasks.c (print_ada_task_info): Use field_string.
 228
 229 2019-07-15  Tom Tromey  <tromey@adacore.com>
 230
 231         * target.c (flash_erase_command): Use field_core_addr.
 232         * symfile.c (generic_load): Use field_core_addr.
 233         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 234         Use field_core_addr.
 235         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 236         field_core_addr.
 237
 238 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 241         value if its desired type is smaller than a CORE_ADDR and signed.
 242
 243 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 244
 245         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 246         of changes to field names, and use new is_reference field to
 247         decide if a property is a reference or not.
 248         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 249         field.
 250         (struct dwarf2_property_baton): Update header comment, rename
 251         'referenced_type' to 'property_type' and update comments.
 252         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 253         default property type, store in property baton, update to take
 254         accound of renamed field.
 255         (read_func_scope): Update call to attr_to_dynamic_prop.
 256         (read_array_type): Likewise.
 257         (dwarf2_per_cu_addr_sized_int_type): New function.
 258         (read_subrange_index_type): Move type finding code to
 259         dwarf2_per_cu_addr_sized_int_type.
 260         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 261         (dwarf2_per_cu_addr_type): New function.
 262         (set_die_type): Update calls to attr_to_dynamic_prop.
 263
 264 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * dwarf2read.c (read_subrange_index_type): New function.
 267         (read_subrange_type): Move code into new function and call it.
 268         * gdbtypes.c (create_range_type): Add some asserts.
 269
 270 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 273         update return statements.
 274         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 275         declaration, and update comment to match.
 276         * gdbtypes.c (resolve_dynamic_array): Update call to
 277         dwarf2_evaluate_property to match new return type.
 278
 279 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * valarith.c (value_subscripted_rvalue): Change lowerbound
 282         parameter type from int to LONGEST.
 283         * value.h (value_subscripted_rvalue): Likewise in declaration.
 284
 285 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * cli/cli-utils.c (info_print_command_completer): New function.
 288         * cli/cli-utils.h: Add 'completer.h' include, and forward
 289         declaration for 'struct cmd_list_element'.
 290         (info_print_command_completer): Declare.
 291         * stack.c (_initialize_stack): Add completer for 'info locals' and
 292         'info args'.
 293         * symtab.c (_initialize_symtab): Add completer for 'info
 294         variables' and 'info functions'.
 295         * NEWS: Mention completion for additional info commands.
 296
 297 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 298
 299         * cli/cli-utils.c (extract_info_print_args): Delete.
 300         (extract_arg_maybe_quoted): Delete.
 301         (info_print_options_defs): New variable.
 302         (make_info_print_options_def_group): New function.
 303         (extract_info_print_options): Define new function.
 304         * cli/cli-utils.h (extract_info_print_args): Delete.
 305         (struct info_print_options): New structure.
 306         (extract_info_print_options): Declare new function.
 307         * stack.c (info_locals_command): Update to use new
 308         extract_info_print_options, also add a header comment.
 309         (info_args_command): Likewise.
 310         * symtab.c (info_variables_command): Likewise.
 311         (info_functions_command): Likewise.
 312
 313 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 314
 315         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 316         to extract string arguments.
 317         * common/common-utils.c (extract_string_maybe_quoted): New function.
 318         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 319
 320 2019-07-11  Tom Tromey  <tromey@adacore.com>
 321
 322         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 323         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 324         * top.h (gdbinit): Don't declare.
 325         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 326         into...
 327         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 328         * top.c (gdb_init): Don't call init_cli_cmds.
 329         (gdbinit): Remove.
 330         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 331
 332 2019-07-11  Tom Tromey  <tromey@adacore.com>
 333
 334         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 335         after it has been moved.
 336
 337 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 338
 339         * valops.c (value_must_coerce_to_target): Change return type to
 340         bool.
 341         * value.h (value_must_coerce_to_target): Likewise.
 342
 343 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 344
 345         * breakpoint.c (is_hardware_watchpoint): Remove
 346         forward-declaration.
 347         (is_masked_watchpoint): Change return type to bool.
 348         (is_tracepoint): Likewise.
 349         (is_breakpoint): Likewise.
 350         (is_hardware_watchpoint): Likewise.
 351         (is_watchpoint): Likewise.
 352         (is_no_memory_software_watchpoint): Likewise.
 353         (is_catchpoint): Likewise.
 354         (breakpoint_1): Make FILTER parameter's return type bool.
 355         is_masked_watchpoint): Change return type to bool.
 356         (save_breakpoints): Make FILTER parameter's return type bool.
 357         * breakpoint.h (is_breakpoint): Change return type to bool.
 358         (is_watchpoint): Likewise.
 359         (is_catchpoint): Likewise.
 360         (is_tracepoint): Likewise.
 361
 362 2019-07-10  Tom Tromey  <tom@tromey.com>
 363
 364         * defs.h: Don't include gdbarch.h.
 365         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 366         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 367         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 368         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 369         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 370         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 371         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 372         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 373         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 374         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 375         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 376         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 377         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 378         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 379         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 380         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 381         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 382         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 383         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 384         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 385         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 386         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 387         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 388         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 389         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 390         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 391         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 392
 393 2019-07-10  Tom Tromey  <tromey@adacore.com>
 394
 395         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 396         * breakpoint.c (init_ada_exception_breakpoint): Register as
 397         bp_catchpoint.
 398         (print_one_breakpoint_location, print_one_breakpoint): Use
 399         is_ada_exception_catchpoint.
 400         * ada-lang.c (class ada_catchpoint_location): Pass
 401         bp_loc_software_breakpoint to bp_location constructor.
 402         (is_ada_exception_catchpoint): New function.
 403
 404 2019-07-10  Tom Tromey  <tromey@adacore.com>
 405
 406         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 407         VEC.
 408         (struct arm_exidx_entry): New method operator<.
 409         (struct arm_exidx_data) <section_maps>: Change type.
 410         (arm_exidx_data_free): Remove.
 411         (arm_exidx_data_key): Change type.  Move lower.
 412         (arm_exidx_new_objfile): Update.
 413         (arm_compare_exidx_entries): Remove.
 414         (arm_find_exidx_entry, _initialize_arm_tdep)
 415
 416 2019-07-10  Tom Tromey  <tromey@adacore.com>
 417
 418         * solib-spu.c (ocl_program_data_key): Change type.
 419         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 420         Update.
 421
 422 2019-07-10  Tom Tromey  <tromey@adacore.com>
 423
 424         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 425         (struct solib_aix_inferior_data) <library_list>: Change type.
 426         (solib_aix_inferior_data_handle): Change type.
 427         (get_solib_aix_inferior_data): Update.
 428         (solib_aix_free_library_list): Remove.
 429         (library_list_start_library): Update.
 430         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 431         return type.
 432         (solib_aix_get_library_list)
 433         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 434         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 435
 436 2019-07-10  Tom Tromey  <tromey@adacore.com>
 437
 438         * solib-dsbt.c (struct dsbt_info): Add initializers.
 439         (solib_dsbt_pspace_data): Change type.
 440         (dsbt_pspace_data_cleanup): Remove.
 441         (get_dsbt_info, _initialize_dsbt_solib): Update.
 442
 443 2019-07-10  Tom Tromey  <tromey@adacore.com>
 444
 445         * spu-tdep.c (spu_overlay_data): Change type.
 446         (spu_get_overlay_table, spu_overlay_new_objfile)
 447         (_initialize_spu_tdep): Update.
 448
 449 2019-07-10  Tom Tromey  <tromey@adacore.com>
 450
 451         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 452         destructor.
 453         (dbx_objfile_data_key): Change type and declare later.
 454         (DBX_SYMFILE_INFO): Rewrite.
 455         * dbxread.c (dbx_objfile_data_key): Change type.
 456         (dbx_symfile_init): Update.
 457         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 458         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 459         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 460
 461 2019-07-10  Tom Tromey  <tromey@adacore.com>
 462
 463         * jit.c (jit_program_space_key): Change type.  Move lower.
 464         (get_jit_program_space_data): Update.
 465         (jit_program_space_data_cleanup): Remove.
 466         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 467         Update.
 468         (struct jit_program_space_data): Add initializers.
 469
 470 2019-07-10  Tom Tromey  <tromey@adacore.com>
 471
 472         * solib-darwin.c (struct darwin_info): Add initializers.
 473         (solib_darwin_pspace_data): Change type.
 474         (darwin_pspace_data_cleanup): Remove.
 475         (get_darwin_info, _initialize_darwin_solib): Update.
 476
 477 2019-07-10  Tom Tromey  <tromey@adacore.com>
 478
 479         * remote-sim.c (struct sim_inferior_data): Add initializers,
 480         constructor, and destructor.
 481         (sim_inferior_data_key): Change type.  Move lower.
 482         (check_for_duplicate_sim_descriptor): Update.
 483         (get_sim_inferior_data): Use new.  Update.
 484         (~sim_inferior_data_cleanup): Rename from
 485         sim_inferior_data_cleanup.  Simplify.
 486         (gdbsim_close_inferior, simulator_command)
 487         (sim_command_completer, _initialize_remote_sim): Update.
 488         (next_pid, INITIAL_PID): Move earlier.
 489
 490 2019-07-10  Tom Tromey  <tromey@adacore.com>
 491
 492         * python/python-internal.h (create_thread_object): Return
 493         gdbpy_ref.
 494         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 495         * python/py-inferior.c (struct threadlist_entry): Add
 496         constructor.
 497         <thread_obj>: Now a gdbpy_ref.
 498         (thread_to_thread_object): Update.
 499         (add_thread_object): Use new.
 500         (delete_thread_object): Use delete.
 501         (infpy_threads): Update.
 502         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 503         GIL.
 504
 505 2019-07-10  Tom Tromey  <tromey@adacore.com>
 506
 507         * valops.c (value_cast): Specialize error message for Ada.
 508
 509 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 510
 511         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 512
 513 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 514
 515         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 516         bpstat_should_step): Return bool, adjust comments.
 517         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 518         bpstat_should_step): Likewise.
 519
 520 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 521
 522         * features/Makefile: Use feature target descriptions for Arm.
 523         * features/arm/arm-core.c: Generate new file.
 524         * features/arm/arm-fpa.c: Likewise.
 525         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 526         * features/arm/arm-m-profile.c: Likewise.
 527         * features/arm/arm-vfpv2.c: Likewise.
 528         * features/arm/arm-vfpv3.c: Likewise.
 529         * features/arm/xscale-iwmmxt.c: Likewise.
 530         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 531
 532 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 533
 534         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 535         ptrace earlier.
 536
 537 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 538
 539         * features/aarch64-pauth.c: Regenerate.
 540
 541 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 542
 543         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 544         bool.
 545         (bpstat_what): Use false instead of 0.
 546
 547 2019-07-09  Pedro Alves  <palves@redhat.com>
 548
 549         * break-catch-throw.c (is_exception_catchpoint): New.
 550         * breakpoint.c (print_one_breakpoint_location): New parameter
 551         'raw_loc'.  Handle it.  Use
 552         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 553         looking at the breakpoint's type.
 554         (print_one_breakpoint): If handling "maint info breakpoints", also
 555         print locations of exception catchpoints.
 556         * breakpoint.h (is_exception_catchpoint): Declare.
 557
 558 2019-07-09  Pedro Alves  <palves@redhat.com>
 559
 560         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 561         "addr" field.
 562         (allocate_location_exception_catchpoint): New.
 563         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 564         (initialize_throw_catchpoint_ops): Install
 565         allocate_location_exception_catchpoint as allocate_location
 566         method.
 567         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 568         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 569         bp_loc_other.
 570         (breakpoint_address_is_meaningful): Delete.
 571         (bl_address_is_meaningful): New.
 572         (breakpoint_locations_match): Adjust comment.
 573         (bp_location_from_bp_type): New, factored out of...
 574         (bp_location::bp_location(breakpoint *)): ... this.
 575         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 576         factored out of...
 577         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 578         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 579         breakpoint_address_is_meaningful.
 580         (bp_locations_compare): Adjust comment.
 581         (update_global_location_list): Use bl_address_is_meaningful
 582         instead of breakpoint_address_is_meaningful.
 583         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 584         explicit.
 585         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 586         * python/py-breakpoint.c (bppy_get_location): No longer check
 587         whether location is null.
 588
 589 2019-07-09  Pedro Alves  <palves@redhat.com>
 590
 591         PR c++/15468
 592         * breakpoint.c (print_one_breakpoint_location): Remove
 593         single-location assert.
 594
 595 2019-07-09  Tom Tromey  <tom@tromey.com>
 596
 597         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 598         * configure: Rebuild.
 599         * configure.ac: Change common to gdbsupport.
 600         * gdbsupport: Rename from common.
 601         * acinclude.m4: Change common to gdbsupport.
 602         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 603         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 604         gdbsupport.
 605         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 606         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 607         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 608         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 609         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 610         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 611         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 612         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 613         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 614         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 615         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 616         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 617         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 618         coff-pe-read.c, command.h, compile/compile-c-support.c,
 619         compile/compile-c.h, compile/compile-cplus-symbols.c,
 620         compile/compile-cplus-types.c, compile/compile-cplus.h,
 621         compile/compile-loc2c.c, compile/compile.c, completer.c,
 622         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 623         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 624         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 625         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 626         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 627         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 628         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 629         features/aarch64-core.c, features/aarch64-fpu.c,
 630         features/aarch64-pauth.c, features/aarch64-sve.c,
 631         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 632         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 633         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 634         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 635         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 636         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 637         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 638         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 639         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 640         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 641         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 642         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 643         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 644         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 645         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 646         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 647         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 648         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 649         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 650         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 651         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 652         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 653         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 654         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 655         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 656         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 657         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 658         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 659         minsyms.c, mips-linux-tdep.c, namespace.h,
 660         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 661         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 662         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 663         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 664         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 665         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 666         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 667         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 668         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 669         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 670         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 671         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 672         procfs.c, producer.c, progspace.h, psymtab.h,
 673         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 674         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 675         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 676         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 677         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 678         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 679         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 680         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 681         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 682         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 683         target-memory.c, target.c, target.h, target/waitstatus.c,
 684         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 685         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 686         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 687         unittests/array-view-selftests.c,
 688         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 689         unittests/common-utils-selftests.c,
 690         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 691         unittests/format_pieces-selftests.c,
 692         unittests/function-view-selftests.c,
 693         unittests/lookup_name_info-selftests.c,
 694         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 695         unittests/mkdir-recursive-selftests.c,
 696         unittests/observable-selftests.c,
 697         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 698         unittests/parse-connection-spec-selftests.c,
 699         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 700         unittests/scoped_fd-selftests.c,
 701         unittests/scoped_mmap-selftests.c,
 702         unittests/scoped_restore-selftests.c,
 703         unittests/string_view-selftests.c, unittests/style-selftests.c,
 704         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 705         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 706         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 707         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 708         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 709         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 710
 711 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 714         bool value.
 715         (decode_digits_ordinary): Set explicit_line field in sal.
 716         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 717         symtab_and_line that was set on an explicit line number in
 718         assembler code.  Do always update the recorded symtab and line if
 719         we do skip the prologue.
 720
 721 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * breakpoint.c (set_breakpoint_location_function): Remove
 724         explicit_loc parameter.
 725         (momentary_breakpoint_from_master): Update call to
 726         set_breakpoint_location_function.
 727         (add_location_to_breakpoint): Likewise.
 728
 729 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 732         required features based on default bfd type when no specific bfd
 733         is present.
 734
 735 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 736
 737         * NEWS: Mention that GDB printf and eval commands can now print
 738         C-style and Ada-style convenience var strings without
 739         calling the inferior.
 740         * printcmd.c (printf_c_string): Locally print GDB internal var
 741         instead of transiting via the inferior.
 742         (printf_wide_c_string): Likewise.
 743
 744 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 745
 746         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 747
 748 2019-07-04  Tom Tromey  <tom@tromey.com>
 749
 750         PR tui/24724:
 751         * tui/tui-winsource.c (tui_clear_source_content): Update.
 752         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 753         (tui_update_breakpoint_info): Update.
 754         (tui_set_exec_info_content): Update.
 755         * tui/tui-source.c (tui_set_source_content_nil): Update.
 756         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 757         has_break.
 758         * tui/tui-data.h (enum tui_bp_flag): New.
 759         (tui_bp_flags): New enum flags type.
 760         (struct tui_source_element) <break_mode>: Change type.  Rename
 761         from has_break.
 762         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 763         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 764         constants.
 765         * tui/tui-winsource.h: Fix comment.
 766
 767 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 768
 769         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 770         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 771         (store_fpregs_to_thread)
 772         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 773         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 774         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 775         (IWMMXT_REGS_SIZE): Add define.
 776         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 777         (fetch_vfp_regs, store_vfp_regs)
 778         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 779         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 780
 781 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 782
 783         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 784         defines.
 785         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 786         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 787         (ARM_INT_REGISTER_SIZE): ...to this.
 788         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 789         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 790         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 791         (arm_linux_collect_gregset, supply_nwfpe_register)
 792         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 793         defines.
 794         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 795         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 796         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 797         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 798         (arm_return_in_memory, arm_store_return_value)
 799         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 800         (arm_record_ld_st_multiple): Likewise.
 801         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 802         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 803
 804 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 805
 806         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 807         AARCH64_DISPLACED_MODIFIED_INSNS.
 808         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 809         (aarch64_displaced_step_copy_insn): Likewise.
 810         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 811         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 812         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 813         ARM_DISPLACED_MODIFIED_INSNS.
 814         * arm-tdep.c (arm_gdbarch_init): Likewise.
 815         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 816         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 817         (struct arm_displaced_step_closure): Use
 818         ARM_DISPLACED_MODIFIED_INSNS.
 819
 820 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 821
 822         * features/Makefile: Remove unused xml files.
 823         * features/aarch64.xml: Remove.
 824         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 825         * features/i386/amd64-avx-avx512.xml: Remove.
 826         * features/i386/amd64-avx-linux.xml: Remove.
 827         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 828         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 829         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 830         * features/i386/amd64-avx-mpx.xml: Remove.
 831         * features/i386/amd64-avx.xml: Remove.
 832         * features/i386/amd64-linux.xml: Remove.
 833         * features/i386/amd64-mpx-linux.xml: Remove.
 834         * features/i386/amd64-mpx.xml: Remove.
 835         * features/i386/amd64.xml: Remove.
 836         * features/i386/i386-avx-avx512-linux.xml: Remove.
 837         * features/i386/i386-avx-avx512.xml: Remove.
 838         * features/i386/i386-avx-linux.xml: Remove.
 839         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 840         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 841         * features/i386/i386-avx-mpx-linux.xml: Remove.
 842         * features/i386/i386-avx-mpx.xml: Remove.
 843         * features/i386/i386-avx.xml: Remove.
 844         * features/i386/i386-linux.xml: Remove.
 845         * features/i386/i386-mmx-linux.xml: Remove.
 846         * features/i386/i386-mmx.xml: Remove.
 847         * features/i386/i386-mpx-linux.xml: Remove.
 848         * features/i386/i386-mpx.xml: Remove.
 849         * features/i386/i386.xml: Remove.
 850         * features/i386/x32-avx-avx512-linux.xml: Remove.
 851         * features/i386/x32-avx-linux.xml: Remove.
 852         * features/i386/x32-linux.xml: Remove.
 853
 854 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * regformats/aarch64.dat: Remove.
 857         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 858         * regformats/i386/amd64-avx-linux.dat: Remove.
 859         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 860         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 861         * regformats/i386/amd64-linux.dat: Remove.
 862         * regformats/i386/amd64-mpx-linux.dat: Remove.
 863         * regformats/i386/amd64.dat: Remove.
 864         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 865         * regformats/i386/i386-avx-linux.dat: Remove.
 866         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 867         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 868         * regformats/i386/i386-linux.dat: Remove.
 869         * regformats/i386/i386-mmx-linux.dat: Remove.
 870         * regformats/i386/i386-mpx-linux.dat: Remove.
 871         * regformats/i386/i386.dat: Remove.
 872         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 873         * regformats/i386/x32-avx-linux.dat: Remove.
 874         * regformats/i386/x32-linux.dat: Remove.
 875
 876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 877
 878         * aarch64-tdep.c: Remove xml self tests.
 879         * amd64-linux-tdep.c: Likewise.
 880         * amd64-tdep.c: Likewise.
 881         * i386-linux-tdep.c: Likewise.
 882         * i386-tdep.c: Likewise.
 883
 884 2019-07-03  Pedro Alves  <palves@redhat.com>
 885
 886         PR cli/24732
 887         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 888         (pipe_cmd_option_defs): New.
 889         (make_pipe_cmd_options_def_group): New.
 890         (pipe_command): Use gdb::option::process_options.
 891         (pipe_command_completer): New function.
 892         (_initialize_cli_cmds): Install completer for "pipe" command.
 893
 894 2019-07-03  Pedro Alves  <palves@redhat.com>
 895
 896         * cli/cli-option.c (union option_value) <string>: New field.
 897         (struct option_def_and_value): Add ctor, move ctor, dtor and
 898         use DISABLE_COPY_AND_ASSIGN.
 899         (option_def_and_value::clear_value): New.
 900         (parse_option, save_option_value_in_ctx, get_val_type_str)
 901         (add_setshow_cmds_for_options): Handle var_string.
 902         * cli-option.h (union option_def::var_address) <string>: New
 903         field.
 904         (struct string_option_def): New.
 905         * maint-test-options.c (struct test_options_opts): Add default
 906         ctor and use DISABLE_COPY_AND_ASSIGN.
 907         <string_opt>: New field.
 908         (test_options_opts::~test_options_opts): New.
 909         (test_options_opts::dump): Also dump "-string".
 910         (test_options_option_defs): Install "string.
 911
 912 2019-07-03  Pedro Alves  <palves@redhat.com>
 913
 914         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 915         option_value with a null enumeration.
 916         (complete_options): Save the option values in the context.
 917         (save_option_value_in_ctx): New, factored out from ...
 918         (process_options): ... here.
 919         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 920         of the function.
 921         * maint-test-options.c (test_options_opts::dump): New, factored
 922         out from ...
 923         (maintenance_test_options_command_mode): ... here.
 924         (maintenance_test_options_command_completion_result): Delete.
 925         (maintenance_test_options_command_completion_text): Update
 926         comment.
 927         (maintenance_show_test_options_completion_result): Change
 928         prototype.  Just print
 929         maintenance_test_options_command_completion_text.
 930         (save_completion_result): New.
 931         (maintenance_test_options_completer_mode): Pass options context to
 932         complete_options, and then save a dump.
 933         (_initialize_maint_test_options): Use add_cmd to install "maint
 934         show test-options-completion-result".
 935
 936 2019-07-03  Pedro Alves  <palves@redhat.com>
 937
 938         * NEWS (New commands): Mention "with" and "maint with".
 939         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 940         (with_command, with_command_completer): New.
 941         (pipe_command): Adjust to new repeat_previous
 942         interface.
 943         (_initialize_cli_cmds): Install the "with" command and its "w"
 944         alias.
 945         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 946         declarations.
 947         * cli/cli-setshow.c (parse_cli_var_uinteger)
 948         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 949         argument strings for all var_types.
 950         (get_setshow_command_value_string): New, factored out from ...
 951         (do_show_command): ... this.
 952         * cli/cli-setshow.h: Include <string>.
 953         (get_setshow_command_value_string): Declare.
 954         * command.h (repeat_previous): Now returns const char *.  Adjust
 955         comment.
 956         * maint.c: Include "cli/cli-cmds.h".
 957         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 958         (_initialize_maint_cmds): Register the "maintenance with" command.
 959         * top.c (repeat_previous): Move bits from pipe_command here:
 960         Return the saved command line, if any; error out if there's no
 961         command to relaunch.
 962
 963 2019-07-03  Pedro Alves  <palves@redhat.com>
 964
 965         * NEWS (New commands): Mention "maint set/show test-settings"
 966         instead of "maint test-settings".
 967         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 968         (maintenance_test_settings_set_list): Rename to ...
 969         (maintenance_set_test_settings_list): ... this.
 970         (maintenance_test_settings_show_list): Rename to  ...
 971         (maintenance_show_test_settings_list): ... this.
 972         (maintenance_test_settings_cmd): Delete.
 973         (maintenance_test_settings_set_cmd): ...
 974         (maintenance_set_test_settings_cmd): ... this.
 975         (maintenance_test_settings_show_cmd): ...
 976         (maintenance_show_test_settings_cmd): ... this.
 977         (maintenance_test_settings_show_value_cmd):
 978         (maintenance_show_test_settings_value_cmd): ... this.
 979         (_initialize_maint_test_settings): No longer install the "maint
 980         test-settings" prefix command.  Rename "maint test-settings set"
 981         to "maint set test-settings", and "maint test-settings show" to
 982         "maint show test-settings".  Adjust all subcommands.
 983
 984 2019-07-03  Pedro Alves  <palves@redhat.com>
 985
 986         * maint-test-settings.c: Fix file's intro comment.  Replace all
 987         references to "test-options" with references to "test-settings",
 988         in comments.
 989
 990 2019-07-03  Pedro Alves  <palves@redhat.com>
 991
 992         * maint-test-settings.c (maintenance_test_settings_xxx)
 993         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 994         New.
 995         (maintenance_test_settings_enums): Use them.
 996         (maintenance_test_settings_enum): Default to
 997         maintenance_test_settings_xxx.
 998         (_initialize_maint_test_settings): Initialize
 999         MAINTENANCE_TEST_SETTINGS_FILENAME.
1000
1001 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1002
1003         * breakpoint.h (remove_breakpoints_inf): Change return type to
1004         void, move function documentation here.
1005         * breakpoint.c (remove_breakpoints_inf): Change return type to
1006         void, move function documentation to header.
1007
1008 2019-07-02  Pedro Alves  <palves@redhat.com>
1009
1010         * NEWS (Completion improvements): Mention "info threads".
1011         * thread.c (struct info_threads_opts, info_threads_option_defs)
1012         (make_info_threads_options_def_group): New.
1013         (info_threads_command): Use gdb::option::process_options.
1014         (info_threads_command_completer): New.
1015         (_initialize_thread): Use gdb::option::build_help to build the
1016         help text for "info threads".
1017
1018 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1019
1020         * defs.h (generic_load): Move from here...
1021         * symfile.h (generic_load): ... to here.  Rename name parameter
1022         to args.
1023         * symfile.c (generic_load): Add comment.
1024
1025 2019-07-01  Tom Tromey  <tromey@adacore.com>
1026
1027         * dwarf2read.c
1028         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1029         declaration of without_params.  Fix formatting.
1030
1031 2019-07-01  Tom Tromey  <tromey@adacore.com>
1032
1033         * ada-exp.y (find_primitive_type): Update.
1034         * ada-lang.h (ada_lookup_symbol): Update.
1035         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1036         parameter.
1037         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1038
1039 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1040
1041         PR breakpoints/24541
1042         * gdbarch.c: Regenerate.
1043         * gdbarch.h: Regenerate.
1044         * gdbarch.sh: Add 'stap_adjust_register'.
1045         * i386-tdep.c: Include '<unordered_set>'.
1046         (i386_stap_adjust_register): New function.
1047         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1048         * stap-probe.c (stap_parse_register_operand): Call
1049         'gdbarch_stap_adjust_register'.
1050
1051 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1052
1053         PR python/24742
1054         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1055         * python/python.c (do_start_initialization): Use 'xmalloc'
1056         instead of 'PyMem_Malloc'.
1057
1058 2019-06-28  Tom Tromey  <tromey@adacore.com>
1059
1060         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1061         for Ada.
1062
1063 2019-06-27  Tom Tromey  <tromey@adacore.com>
1064
1065         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1066         objfile_key.
1067         (arm_find_mapping_symbol, arm_record_special_symbol)
1068         (_initialize_arm_tdep): Update.
1069         (arm_objfile_data_free): Remove.
1070
1071 2019-06-27  Tom Tromey  <tromey@adacore.com>
1072
1073         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1074         to cp_print_static_field.
1075
1076 2019-06-26  Tom Tromey  <tromey@adacore.com>
1077
1078         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1079         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1080         declare.
1081
1082 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1083
1084         * features/aarch64-core.c (create_feature_aarch64_core):
1085         Regenerate.
1086         * features/aarch64-core.xml: Add cpsr flags.
1087
1088 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1089
1090         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1091         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1092
1093 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1094
1095         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1096         field.
1097         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1098         use.
1099         (arm_record_special_symbol): Don't insert new symbol in sorted
1100         position, push it at the end.
1101
1102 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1103
1104         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1105         (arm_mapping_symbol_s): Remove.
1106         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1107         (arm_mapping_symbol_vec): New typedef.
1108         (struct arm_per_objfile): Add constructor.
1109         <section_maps>: Change type to
1110         std::unique_ptr<arm_mapping_symbol_vec[]>.
1111         (arm_compare_mapping_symbols): Remove.
1112         (arm_find_mapping_symbol): Adjust to section_maps type change.
1113         (arm_objfile_data_free): Call delete on arm_per_objfile.
1114         (arm_record_special_symbol): Adjust to section_maps type change.
1115         Allocate arm_per_objfile with new.
1116
1117 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1118
1119         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1120         with the command prefix.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1125         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1126
1127 2019-06-25  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1130         type.
1131         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1132         protected.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-winsource.c
1137         (tui_source_window_base::set_is_exec_point_at): Add check against
1138         LOA_ADDRESS.
1139
1140 2019-06-25  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-source.c (tui_set_source_content): Don't check before
1143         xfree.
1144         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1145
1146 2019-06-25  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-winsource.h (tui_update_source_window_as_is)
1149         (tui_alloc_source_buffer, tui_line_is_displayed)
1150         (tui_addr_is_displayed): Change type of win_info.
1151         * tui/tui-winsource.c (tui_update_source_window_as_is)
1152         (tui_clear_source_content, tui_show_source_line)
1153         (tui_show_source_content, tui_source_window_base::refill)
1154         (tui_source_window_base::set_is_exec_point_at)
1155         (tui_source_window_base::set_is_exec_point_at)
1156         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1157         (tui_alloc_source_buffer, tui_line_is_displayed)
1158         (tui_addr_is_displayed): Change type of win_info.  Update.
1159         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1160         (tui_source_window_base::do_make_visible_with_new_height):
1161         Update.
1162         * tui/tui-source.c (tui_set_source_content)
1163         (tui_set_source_content_nil)
1164         (tui_source_window::do_scroll_vertical): Update.
1165         * tui/tui-layout.c (show_layout): Update.
1166         * tui/tui-disasm.c (tui_set_disassem_content)
1167         (tui_disasm_window::do_scroll_vertical): Update.
1168         * tui/tui-data.h (tui_win_content): Remove.
1169         (struct tui_gen_win_info) <content, content_size>: Remove.
1170         (struct tui_source_element): Add initializers and destructor.
1171         (union tui_which_element, struct tui_win_element): Remove.
1172         (struct tui_source_window_base) <content>: New field.
1173         (struct tui_data_window): Remove destructor.
1174         (tui_alloc_content, tui_free_win_content)
1175         (tui_free_all_source_wins_content): Don't declare.
1176         * tui/tui-data.c (tui_initialize_static_data): Update.
1177         (init_content_element, tui_alloc_content): Remove.
1178         (~tui_gen_win_info): Update.
1179         (~tui_data_window, tui_free_all_source_wins_content)
1180         (tui_free_win_content, free_content, free_content_elements):
1181         Remove.
1182
1183 2019-06-25  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-winsource.h (tui_clear_source_content)
1186         (tui_erase_source_content, tui_show_source_content): Change type
1187         of win_info.
1188         * tui/tui-winsource.c (tui_clear_source_content)
1189         (tui_erase_source_content, tui_show_source_content): Change type
1190         of win_info.
1191         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1192         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1193         win_info.
1194         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1195         win_info.
1196         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-winsource.c (tui_clear_source_content)
1201         (tui_source_window_base::set_is_exec_point_at): Update.
1202         * tui/tui-source.c (tui_set_source_content_nil): Update.
1203         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1204         a bool.
1205         * tui/tui-data.c (init_content_element): Update.
1206
1207 2019-06-25  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1210         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1211         * tui/tui-layout.c (init_and_make_win): Update.
1212         * tui/tui.h (enum tui_win_type): Update.
1213         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1214         tui_win_is_auxillary.
1215         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1216         tui_win_is_auxillary.
1217
1218 2019-06-25  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1221         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1222         (tui_delete_data_content_windows, tui_display_all_data)
1223         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1224         Update.
1225         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1226         * tui/tui-regs.c (tui_last_regs_line_no)
1227         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1228         (tui_show_registers): Update.
1229         (tui_show_register_group): Return void.  Update.
1230         (tui_display_registers_from, tui_display_reg_element_at_line)
1231         (tui_display_registers_from_line, tui_check_register_values):
1232         Update.
1233         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1234         member.
1235         (struct tui_data_window) <regs_content>: Now a std::vector.
1236         <regs_content_count>: Remove.
1237         (tui_add_content_elements, tui_free_data_content): Don't declare.
1238         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1239         (init_content_element): Remove DATA_WIN case.  Add assert.
1240         (tui_add_content_elements): Remove.
1241         (tui_data_window): Update.
1242         (tui_free_data_content): Remove.
1243         (free_content_elements): Remove DATA_WIN case.
1244
1245 2019-06-25  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-data.c (tui_data_item_window): Update.
1248         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1249         * tui/tui-windata.c (tui_display_all_data)
1250         (tui_display_data_from_line): Update.
1251         (tui_check_data_values): Remove.
1252         * tui/tui-regs.c (tui_show_register_group)
1253         (tui_display_reg_element_at_line): Update.
1254         * tui/tui-hooks.c (tui_register_changed)
1255         (tui_refresh_frame_and_register_information): Call
1256         tui_check_register_values.
1257         * tui/tui-data.h (struct tui_data_window) <data_content,
1258         data_content_count, data_type>: Remove.
1259         (enum tui_data_type): Remove.
1260
1261         * tui/tui-data.c (tui_data_window::clear_detail)
1262         (~tui_data_window): Update.
1263
1264 2019-06-25  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1267         declare.
1268         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1269         Rename from tui_first_data_item_displayed.  Update.
1270         (tui_data_window::refresh_all)
1271         (tui_data_window::do_scroll_vertical): Update.
1272         * tui/tui-data.h (struct tui_data_window)
1273         <first_data_item_displayed>: Declare new method.
1274
1275 2019-06-25  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1278         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1279         contents...
1280         (tui_initialize_static_data): ...here.
1281
1282 2019-06-25  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1285         (tui_display_registers_from, tui_check_register_values): Update.
1286         (tui_display_register): Remove win_info parameter; update.
1287         (tui_get_register): Change type of parameters.
1288         * tui/tui-data.h (struct tui_data_element): Remove.
1289         (union tui_which_element) <data>: Remove.
1290         <data_window>: Change type.
1291         (struct tui_data_item_window): New.
1292         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1293         case.  Add assert.
1294         (~tui_data_item_window): New destructor.
1295         (free_content_elements): Remove DATA_ITEM_WIN case.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1300         Remove.
1301
1302 2019-06-25  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-data.h (struct tui_command_element): Remove.
1305         (union tui_which_element) <command>: Remove.
1306         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1307         assert.
1308         (free_content_elements): Remove CMD_WIN case.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-layout.c (tui_set_layout): Update.
1313         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1314         * tui/tui-data.c (layout_def): Update.
1315
1316 2019-06-25  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1319         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1320         (tui_source_window_base::set_new_height): Update.
1321         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1322         Update.
1323         (tui_set_locator_fullname, tui_set_locator_info)
1324         (tui_show_frame_info): Update.
1325         * tui/tui-source.c (tui_set_source_content)
1326         (tui_source_is_displayed): Update.
1327         * tui/tui-layout.c (show_source_disasm_command, show_data)
1328         (show_source_or_disasm_and_command): Update.
1329         * tui/tui-disasm.c (tui_set_disassem_content)
1330         (tui_get_begin_asm_address): Update.
1331         * tui/tui-data.h (struct tui_locator_element): Remove.
1332         (union tui_which_element) <locator>: Remove.
1333         (struct tui_locator_window): New.
1334         (tui_locator_win_info_ptr): Change return type.
1335         * tui/tui-data.c (_locator): Change type.
1336         (tui_locator_win_info_ptr): Change return type.
1337         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1338         (tui_alloc_content): Add assert.
1339
1340 2019-06-25  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-winsource.c
1343         (tui_exec_info_window::maybe_allocate_content): New method.
1344         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1345         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1346         (make_source_or_disasm_window): Add cast.
1347         * tui/tui-data.h (union tui_which_element) <simple_string>:
1348         Remove.
1349         (struct tui_source_info): New.
1350         (struct tui_source_window_base) <execution_info>: Change type.
1351         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1352         case, and add assert.
1353         (tui_alloc_content): Add assert.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1358         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1359         * tui/tui-data.c (tui_alloc_win_info): Remove.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1364         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1365         can_highlight.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1370         make_visible_with_new_height method.
1371         (tui_win_info::make_visible_with_new_height): New method.
1372         (tui_source_window_base::do_make_visible_with_new_height)
1373         (tui_data_window::do_make_visible_with_new_height)
1374         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1375         (make_visible_with_new_height): Remove.
1376         (tui_resize_all, tui_adjust_win_heights): Use
1377         make_visible_with_new_height method.
1378         * tui/tui-data.h (struct tui_win_info)
1379         <do_make_visible_with_new_height, make_visible_with_new_height>:
1380         New methods.
1381         (struct tui_source_window_base, struct tui_data_window)
1382         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1383         methods.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1388         method.
1389         (update_tab_width): Call update_tab_width method.
1390         * tui/tui-data.h (struct tui_win_info)
1391         (struct tui_source_window_base) <update_tab_width>: New methods.
1392
1393 2019-06-25  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1396         parameter.
1397         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1398         parameter.
1399         (tui_gen_win_info::make_visible): Update.
1400         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1401         parameter.
1402         * tui/tui-data.h (enum tui_box): New enum.
1403         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1408         init_and_make_win for EXEC_INFO_WIN.
1409         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1410         longer inline.
1411         (struct tui_win_info) <~tui_win_info>: Inline.
1412         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1413         Don't declare.
1414         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1415         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1416         Remove.
1417         (tui_initialize_static_data): Update.
1418         (~tui_gen_win_info): Handle more cleanup here.
1419         (~tui_source_window_base): Delete "execution_info".
1420         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-layout.c (make_command_window): Don't set
1425         can_highlight.
1426         (show_source_disasm_command): Call the reset method.
1427         (show_data): Don't set can_highlight.  Call the reset method.
1428         (tui_gen_win_info::reset): Rename from init_gen_win_info
1429         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1430         (show_source_or_disasm_and_command): Call the reset method.
1431         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1432         (struct tui_cmd_window): Set can_highlight.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1437         from make_visible.
1438         (tui_make_visible, tui_make_invisible): Rewrite.
1439         (tui_win_info::make_visible): Remove.
1440         (tui_source_window_base::make_visible): Update.
1441         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1442         method.  Moved from...
1443         (struct tui_win_info) <make_visible>: ...here.
1444
1445 2019-06-25  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-winsource.c
1448         (tui_source_window_base::do_scroll_horizontal): Remove direction
1449         parameter.
1450         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1451         direction parameter.
1452         * tui/tui-win.c (tui_win_info::forward_scroll)
1453         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1454         (tui_win_info::right_scroll): Update.
1455         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1456         direction parameter.
1457         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1458         direction parameter.
1459         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1460         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1461         Remove direction parameter.
1462         (struct tui_source_window_base, struct tui_source_window)
1463         (struct tui_disasm_window, struct tui_data_window)
1464         (struct tui_cmd_window): Update.
1465
1466 2019-06-25  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-winsource.h (tui_set_exec_info_content)
1469         (tui_show_exec_info_content, tui_erase_exec_info_content)
1470         (tui_clear_exec_info_content, tui_update_exec_info): Change
1471         argument to tui_source_window_base.
1472         * tui/tui-winsource.c (tui_set_exec_info_content)
1473         (tui_show_exec_info_content, tui_erase_exec_info_content)
1474         (tui_clear_exec_info_content, tui_update_exec_info): Change
1475         argument to tui_source_window_base.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1480         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1481
1482 2019-06-25  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1485         check.
1486
1487 2019-06-25  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1490         type to void.
1491         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1492         type to void.
1493         * tui/tui-source.c (tui_set_source_content): Update.
1494         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1495
1496 2019-06-25  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-win.c (window_name_completer, tui_set_focus)
1499         (tui_all_windows_info): Use name method.
1500         * tui/tui-data.h (struct tui_gen_win_info)
1501         (struct tui_source_window, struct tui_disasm_window)
1502         (struct tui_data_window, struct tui_cmd_window) <name>: New
1503         method.
1504         (tui_win_name): Don't declare.
1505         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1506         (tui_win_name): Remove.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-winsource.h (tui_update_source_window)
1511         (tui_update_source_window_as_is): Change parameter type.
1512         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1513         to be a tui_source_window_base.
1514         (tui_update_source_window_as_is): Likewise.
1515         * tui/tui-win.c (make_visible_with_new_height): Update.
1516
1517 2019-06-25  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-winsource.c (tui_erase_source_content)
1520         (tui_show_source_content, tui_show_exec_info_content)
1521         (tui_erase_exec_info_content): Use refresh_window method.
1522         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1523         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1524         from tui_refresh_win.
1525         (tui_data_window::refresh_window): New method.
1526         (tui_win_info::refresh, tui_source_window_base::refresh)
1527         (tui_refresh_all): Use refresh_window method.
1528         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1529         method.
1530         * tui/tui-regs.c (tui_display_register): Call refresh_window
1531         method.
1532         * tui/tui-layout.c (show_source_disasm_command)
1533         (show_source_or_disasm_and_command): Call refresh_window method.
1534         * tui/tui-data.h (struct tui_gen_win_info)
1535         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1536         New method.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui.c (tui_rl_other_window, tui_enable)
1541         (tui_is_window_visible, tui_get_command_dimension): Update.
1542         * tui/tui-winsource.c (tui_update_source_window_as_is)
1543         (tui_clear_source_content, tui_erase_source_content)
1544         (tui_show_source_line, tui_source_window_base::refill)
1545         (tui_source_window_base::do_scroll_horizontal)
1546         (tui_source_window_base::set_is_exec_point_at)
1547         (tui_update_breakpoint_info, tui_set_exec_info_content)
1548         (tui_alloc_source_buffer, tui_line_is_displayed)
1549         (tui_addr_is_displayed): Update.
1550         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1551         (tui_check_and_display_highlight_if_needed)
1552         (tui_win_info::make_visible, tui_win_info::refresh)
1553         (tui_refresh_all): Update.
1554         * tui/tui-windata.c (tui_first_data_item_displayed)
1555         (tui_delete_data_content_windows, tui_erase_data_content)
1556         (tui_display_all_data, tui_data_window::refresh_all)
1557         (tui_check_data_values): Update.
1558         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1559         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1560         (tui_win_info::backward_scroll, tui_refresh_all_win)
1561         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1562         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1563         (tui_source_window_base::set_new_height)
1564         (tui_data_window::set_new_height)
1565         (make_invisible_and_set_new_height)
1566         (make_visible_with_new_height, new_height_ok)
1567         (parse_scrolling_args): Update.
1568         * tui/tui-stack.c (tui_show_frame_info): Update.
1569         * tui/tui-source.c (tui_set_source_content)
1570         (tui_set_source_content_nil, tui_source_is_displayed)
1571         (tui_source_window::do_scroll_vertical): Update.
1572         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1573         (tui_display_registers_from, tui_display_reg_element_at_line)
1574         (tui_check_register_values, tui_reg_command): Update.
1575         * tui/tui-layout.c (tui_default_win_height)
1576         (show_source_disasm_command, show_data, init_and_make_win)
1577         (show_source_or_disasm_and_command): Update.
1578         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1579         (tui_redisplay_readline, tui_mld_flush)
1580         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1581         (tui_getc): Update.
1582         * tui/tui-disasm.c (tui_set_disassem_content)
1583         (tui_disasm_window::do_scroll_vertical): Update.
1584         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1585         Now virtual.
1586         (struct tui_win_info): Derive from tui_gen_win_info.
1587         <~tui_win_info>: Mark as override.
1588         <generic>: Remove member.
1589         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1590         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1591         (~tui_data_window, ~tui_win_info)
1592         (tui_free_all_source_wins_content): Update.
1593         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-layout.c (init_and_make_win): Use new.
1598         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1599         destructor, initializers.
1600         (tui_alloc_generic_win_info): Don't declare.
1601         * tui/tui-data.c (_locator): Add argument to constructor.
1602         (source_win, disasm_win): New globals.
1603         (exec_info): Remove.
1604         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1605         Update.
1606         (tui_alloc_generic_win_info): Remove.
1607         (init_content_element): Use new.
1608         (tui_win_info::tui_win_info): Update.
1609         (free_content_elements) <case DATA_WIN>: Use delete.
1610
1611 2019-06-25  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1614         * tui/tui-windata.c (tui_first_data_item_displayed)
1615         (tui_delete_data_content_windows): Update.
1616         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1617         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1618         (tui_display_registers_from, tui_check_register_values): Update.
1619         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1620         pointer.
1621         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1622         window.
1623         (tui_free_data_content): Update.
1624         (free_content_elements) <case DATA_WIN>: Free the window.
1625
1626 2019-06-25  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1629         Update.
1630         * tui/tui-layout.c (make_command_window)
1631         (show_source_disasm_command, show_data, init_and_make_win)
1632         (show_source_or_disasm_and_command): Update.
1633         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1634         method.
1635         <can_highight, is_highlighted>: Now bool.
1636         (tui_set_win_highlight): Don't declare.
1637         * tui/tui-data.c (tui_set_win_highlight): Remove.
1638
1639 2019-06-25  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-wingeneral.c (make_visible): Remove check of window
1642         type.
1643
1644 2019-06-25  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-win.c (tui_win_info::max_height)
1647         (tui_cmd_window::max_height): New methods.
1648         (new_height_ok): Call max_height.
1649         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1650         <max_height>: New method.
1651
1652 2019-06-25  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-win.c (tui_source_window_base::set_new_height)
1655         (tui_data_window::set_new_height): New methods.
1656         (make_invisible_and_set_new_height): Call set_new_height method.
1657         * tui/tui-data.h (struct tui_win_info)
1658         (struct tui_source_window_base, struct tui_data_window)
1659         <set_new_height>: New method.
1660
1661 2019-06-25  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1664         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1665         tui_refresh_data_win.
1666         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1667         method.
1668         (tui_refresh_all_win): Call the refresh_all method.
1669         (tui_set_focus): Likewise.
1670         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1671         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1672         Likewise.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-winsource.h (tui_refill_source_window)
1677         (tui_set_is_exec_point_at): Don't declare.
1678         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1679         (tui_source_window_base::refill): Rename from
1680         tui_refill_source_window.
1681         (tui_source_window_base::do_scroll_horizontal): Update.
1682         (tui_source_window_base::set_is_exec_point_at): Rename from
1683         tui_set_is_exec_point_at.
1684         (tui_update_all_breakpoint_info): Update.
1685         * tui/tui-stack.c (tui_show_frame_info): Update.
1686         * tui/tui-layout.c (show_data): Add cast.
1687         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1688         * tui/tui-data.h (struct tui_source_window_base) <refill,
1689         set_is_exec_point_at>: New methods.
1690         (tui_source_windows, tui_add_to_source_windows): Update types.
1691         (tui_add_to_source_windows): Remove redundant declaration.
1692         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1693         (tui_source_windows): Change return type.
1694         (tui_clear_source_windows_detail): Update.
1695         (tui_add_to_source_windows): Change type of parameter.
1696         (tui_free_all_source_wins_content): Update.
1697
1698 2019-06-25  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-wingeneral.c (tui_win_info::refresh)
1701         (tui_source_window_base::refresh): New methods.
1702         (tui_refresh_all): Call the refresh method.
1703         * tui/tui-data.h (struct tui_win_info)
1704         (struct tui_source_window_base) <refresh>: New method.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui.h (tui_is_window_visible): Return bool.
1709         * tui/tui.c (tui_is_window_visible): Return bool.
1710         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1711         (tui_make_visible, tui_make_invisible)
1712         (tui_win_info::make_visible)
1713         (tui_source_window_base::make_visible, make_all_visible)
1714         (tui_make_all_visible, tui_make_all_invisible): Update.
1715         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1716         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1717         bool.
1718         (struct tui_win_info, struct tui_source_window_base)
1719         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1720         * tui/tui-data.c (tui_init_generic_part): Update.
1721
1722 2019-06-25  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1725         (tui_source_window_base::make_visible): New methods.
1726         (make_all_visible): Make method call.
1727         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1728         (struct tui_source_window_base, struct tui_cmd_window): Override
1729         make_visible.
1730         (tui_win_is_source_type): Don't declare.
1731         * tui/tui-data.c (tui_win_is_source_type): Remove.
1732
1733 2019-06-25  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1736         NULL check.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1741         Inline constructor.  Add initializers for members.
1742         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1743         constructors; now inline in class.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-regs.c (tui_show_registers): Update.
1748         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1749         bool.
1750         * tui/tui-data.c (tui_data_window::clear_detail)
1751         (tui_data_window): Update.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-windata.c (tui_display_all_data)
1756         (tui_display_data_from_line, tui_display_data_from)
1757         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1758         Update.
1759         * tui/tui-regs.c (tui_last_regs_line_no)
1760         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1761         (tui_show_registers, tui_show_register_group)
1762         (tui_display_registers_from, tui_display_reg_element_at_line)
1763         (tui_display_registers_from_line, tui_check_register_values)
1764         (tui_reg_next, tui_reg_prev): Update.
1765         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1766         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1767         tui_data_window.
1768         (struct tui_win_info) <detail>: Remove.  Add new fields from
1769         tui_data_info.
1770         (TUI_DATA_WIN): Add cast.
1771         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1772         (~tui_data_window): Simplify.
1773
1774 2019-06-25  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-layout.c (show_source_disasm_command)
1777         (show_source_or_disasm_and_command): Update.
1778         * tui/tui-io.c (update_cmdwin_start_line)
1779         (tui_redisplay_readline): Update.
1780         * tui/tui-data.h (struct tui_command_info): Remove.
1781         (struct tui_win_info) <detail>: Remove command_info member.
1782         (struct tui_data_window) <start_line>: New member, from
1783         tui_command_info.
1784         (TUI_CMD_WIN): Add casts.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-winsource.c (tui_update_source_window)
1789         (tui_refill_source_window)
1790         (tui_source_window_base::do_scroll_horizontal)
1791         (tui_update_breakpoint_info, tui_set_exec_info_content)
1792         (tui_show_exec_info_content, tui_erase_exec_info_content)
1793         (tui_clear_exec_info_content): Update.
1794         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1795         Update.
1796         * tui/tui-win.c (make_invisible_and_set_new_height)
1797         (make_visible_with_new_height): Update.
1798         * tui/tui-source.c (tui_set_source_content)
1799         (tui_show_symtab_source): Update.
1800         * tui/tui-layout.c (extract_display_start_addr)
1801         (show_source_disasm_command, show_data)
1802         (make_source_or_disasm_window)
1803         (show_source_or_disasm_and_command): Update.
1804         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1805         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1806         "gdbarch".
1807         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1808         to tui_source_window_base.
1809         (struct tui_win_info) <detail>: Remove source_info member.
1810         (struct tui_source_window_base) <has_locator>: Inline.
1811         Move contents from tui_source_info; rename has_locator member to
1812         m_has_locator.
1813         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1814         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1815         header file.
1816         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1817         Simplify.
1818         (tui_free_all_source_wins_content): Cast to
1819         tui_source_window_base.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-win.c (make_invisible_and_set_new_height)
1824         (make_visible_with_new_height): Call has_locator method.
1825         * tui/tui-layout.c (show_source_disasm_command, show_data)
1826         (show_source_or_disasm_and_command): Update for bool change.
1827         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1828         (tui_win_info) <has_locator>: New method.
1829         (struct tui_source_window_base) <has_locator>: New method.
1830         (tui_win_has_locator): Don't declare.
1831         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1832         from tui_win_has_locator.
1833         (tui_source_window_base): Use false, not FALSE.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1838         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1839         clear_detail method directly.
1840         (tui_clear_win_detail): Remove.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1845         "this", not TUI_DISASM_WIN.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1850         declare.
1851         * tui/tui-winsource.c
1852         (tui_source_window_base::do_scroll_horizontal): Rename from
1853         tui_horizontal_source_scroll.
1854         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1855         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1856         from tui_vertical_data_scroll.
1857         * tui/tui-win.h (tui_scroll): Don't declare.
1858         * tui/tui-win.c (tui_win_info::forward_scroll)
1859         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1860         (tui_win_info::right_scroll): Rename and update.
1861         (tui_scroll_forward_command, tui_scroll_backward_command)
1862         (tui_scroll_left_command, tui_scroll_right_command): Update.
1863         (tui_scroll): Remove.
1864         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1865         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1866         from tui_vertical_source_scroll.
1867         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1868         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1869         from tui_vertical_disassem_scroll.
1870         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1871         do_scroll_horizontal>: New methods.
1872         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1873         Likewise.
1874         (struct tui_source_window_base): Add do_scroll_horizontal.
1875         (struct tui_source_window, struct tui_disasm_window): Add
1876         do_scroll_vertical.
1877         (struct tui_data_window, struct tui_cmd_window): Add
1878         do_scroll_horizontal and do_scroll_vertical.
1879         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-data.h (struct tui_source_window_base): New struct.
1884         (struct tui_source_window): Derive from tui_source_window_base.
1885         (struct tui_disasm_window): New struct.
1886         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1887         from tui_source_window::clear_detail.
1888         (tui_source_window_base): Rename from tui_source_window.
1889         (~tui_source_window_base): Rename from ~tui_source_window.
1890         (tui_alloc_win_info): Create a tui_disasm_window.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-data.h (struct tui_source_window)
1895         (struct tui_data_window): Declare destructors.
1896         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1897         destructors.
1898         (tui_win_info): Simplify.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-winsource.c (tui_display_main)
1903         (tui_update_source_windows_with_addr)
1904         (tui_update_all_breakpoint_info): Update.
1905         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1906         (new_height_ok, parse_scrolling_args): Update.
1907         * tui/tui-stack.c (tui_show_frame_info): Update.
1908         * tui/tui-data.h (struct tui_list): Remove.
1909         (tui_source_windows): Return a reference to a std::vector.
1910         * tui/tui-data.c (source_windows): Now a std::vector.
1911         (tui_source_windows): Change return type.
1912         (tui_clear_source_windows): Rewrite.
1913         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1914         (tui_free_all_source_wins_content): Rewrite.
1915
1916 2019-06-25  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1919         (struct tui_data_window, struct tui_cmd_window): Declare
1920         clear_detail method.
1921         * tui/tui-data.c (tui_source_window::clear_detail)
1922         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1923         methods.
1924         (tui_clear_win_detail): Simplify.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-layout.c (make_source_window, make_disasm_window)
1929         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1930         Return the new window.
1931         (show_source_disasm_command, show_data)
1932         (show_source_or_disasm_and_command): Update.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1937         parameter.  Return the new window.
1938         (show_source_disasm_command): Update and remove NULL check.
1939         (show_source_or_disasm_and_command): Update.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-data.h (struct tui_win_info): Make constructor
1948         protected.  Make destructor virtual.  Add initializers.
1949         (tui_source_window, tui_data_window, tui_cmd_window): New
1950         classes.
1951         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1952         constructor.  Add "type" parameter.
1953         (tui_source_window, tui_data_window, tui_cmd_window): New
1954         constructors.
1955         (tui_alloc_win_info): Instantiate the appropriate subclass.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-win.c (tui_resize_all): Use delete.
1960         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1961         destructor.
1962         (tui_free_window): Don't declare.
1963         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1964         Update.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-data.h (struct tui_win_info): Add constructor.
1969         * tui/tui-data.c (tui_alloc_win_info): Use new.
1970         (tui_free_window): Use delete.
1971
1972 2019-06-22  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1975         declare.
1976         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1977
1978 2019-06-22  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1981         declare.
1982         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1983
1984 2019-06-22  Tom de Vries  <tdevries@suse.de>
1985
1986         * dwarf2read.c (create_addrmap_from_aranges)
1987         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1988         instead of '%zu'.
1989
1990 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1991
1992         * dwarf2read.h (dwarf2_section_info_def): Remove.
1993         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1994         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1995         std::vector<dwarf2_section_info>.
1996         (struct dwo_file) <~dwo_file>: Remove.
1997         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1998         types field.
1999         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2000         (dwarf2_read_debug_names): Likewise.
2001         (create_debug_types_hash_table): Change parameter type to
2002         array_view, adjust code accordingly.
2003         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2004         (partial_die_info::fixup): Likewise.
2005         (determine_prefix): Likewise.
2006         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2007
2008 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2009
2010         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2011         gdb_bfd_ref_ptr.
2012         <~dwo_file>: Remove call to gdb_bfd_unref.
2013         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2014         gdb_bfd_ref_ptr::get.
2015
2016 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2017
2018         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2019         type to htab_up.
2020         * dwarf2read.c (struct dwo_file): Initialize fields.
2021         <~dwo_file>: New.
2022         (free_dwo_file): Remove, move content to ~dwo_file.
2023         (struct dwo_file_deleter): Remove.
2024         (dwo_file_up>: Remove custom deleter.
2025         (free_dwo_files): Remove.
2026         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2027         dwo_files.
2028         (process_skeletonless_type_units): Call unique_ptr::get.
2029         (allocate_dwo_file_hash_table): Add deleter to created hash
2030         table.  Change return type to htab_up.
2031         (lookup_dwo_file_slot): Don't memset dwo_file, call
2032         unique_ptr::get.
2033         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2034         (create_dwo_unit_in_dwp_v2): Likewise.
2035         (open_and_init_dwo_file): Likewise.
2036         (free_dwo_file_from_slot): Remove.
2037
2038 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2039
2040         * dwarf2read.h (struct dwarf2_section_info) <readin,
2041         is_virtual>: Change type to bool.
2042         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2043         true instead of 1.
2044
2045 2019-06-19  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-data.h (tui_init_content_element): Don't declare.
2048
2049 2019-06-19  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-data.h (tui_init_win_info): Don't declare.
2052
2053 2019-06-19  Tom de Vries  <tdevries@suse.de>
2054
2055         * dwarf2read.h (abstract_to_concrete): Change type to
2056         std::unordered_map<sect_offset, std::vector<sect_offset>,
2057         gdb::hash_enum<sect_offset>>.
2058
2059 2019-06-19  Tom Tromey  <tromey@adacore.com>
2060
2061         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2062         EVAL_AVOID_SIDE_EFFECTS specially.
2063
2064 2019-06-19  Tom Tromey  <tromey@adacore.com>
2065
2066         * source-cache.c (highlighter): New global.
2067         (source_cache::get_source_lines): Create a highlighter on demand.
2068
2069 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * defs.h (deprecated_interactive_hook): Delete declaration.
2072         * interps.c (clear_interpreter_hooks): Remove use of
2073         deprecated_interactive_hook.
2074         * top.c (deprecated_interactive_hook): Delete definition.
2075         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2076
2077 2019-06-18  Tom de Vries  <tdevries@suse.de>
2078
2079         PR gdb/24515
2080         * dwarf2read.h (abstract_to_concrete): Change type from
2081         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2082         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2083         * dwarf2read.c (read_variable): Update.
2084         (dwarf2_fetch_die_loc_sect_off): Update.
2085
2086 2019-06-17  Tom de Vries  <tdevries@suse.de>
2087
2088         PR gdb/24617
2089         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2090         accessing parent[parent_len - 1].
2091
2092 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2093
2094         PR gdb/24364
2095         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2096         call dtrace_process_dof with NULL dof.
2097
2098 2019-06-16  Tom de Vries  <tdevries@suse.de>
2099
2100         PR gdb/24445
2101         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2102
2103 2019-06-16  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2106         (make_all_visible): Use address of member.
2107
2108 2019-06-16  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2111         (tui_free_window, free_content, free_content_elements): Remove
2112         unnecessary cast.
2113         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2114         cast.
2115         * tui/tui-regs.c (tui_show_register_group)
2116         (tui_display_registers_from, tui_display_reg_element_at_line):
2117         Remove unnecessary cast.
2118
2119 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2120
2121         * linux-nat.c (normal_mask): Delete.
2122         (_initialize_linux_nat): Don't initialise normal_mask.
2123
2124 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2125
2126         PR gdb/24445
2127         * dwarf-index-write.h (write_psymtabs_to_index): Add
2128         dwz_basename parameter.
2129         * dwarf-index-write.c (write_gdbindex): Move file writing to
2130         write_gdbindex_1.  Change return type void.
2131         (assert_file_size): Move up, remove filename parameter.
2132         (write_gdbindex_1): New function.
2133         (write_debug_names): Change return type to void, call
2134         assert_file_size.
2135         (struct index_wip_file): New struct.
2136         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2137         file logic to index_wip_file.  Write index for dwz file if
2138         needed.
2139         (save_gdb_index_command): Pass basename of dwz file, if present.
2140         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2141         build-id of dwz file, if present.
2142         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2143         (dwarf2_get_dwz_file): Likewise.
2144         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2145         (dwarf2_get_dwz_file): Likewise.
2146
2147 2019-06-16  Tom Tromey  <tom@tromey.com>
2148
2149         * coffread.c (process_coff_symbol): Use xstrdup.
2150         * value.c (create_internalvar): Use xstrdup.
2151
2152 2019-06-16  Tom Tromey  <tom@tromey.com>
2153
2154         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2155         * breakpoint.c (stopin_command, stopat_command)
2156         (until_break_command, decode_location_default): Remove unnecessary
2157         cast.
2158         * utils.c (subset_compare): Remove unnecessary cast.
2159         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2160         cast.
2161         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2162         cast.
2163         * infcmd.c (path_command): Remove unnecessary cast.
2164         * coffread.c (decode_type): Remove unnecessary cast.
2165         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2166         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2167         * tui/tui-stack.c (tui_show_locator_content)
2168         (tui_show_frame_info): Remove unnecessary cast.
2169         * tui/tui-win.c (tui_scroll_forward_command)
2170         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2171         (parse_scrolling_args): Remove unnecessary cast.
2172         * tui/tui-data.c (init_win_info, tui_del_window)
2173         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2174         (free_content_elements): Remove unnecessary cast.
2175         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2176         unnecessary cast.
2177         * tui/tui-source.c (tui_set_source_content)
2178         (tui_vertical_source_scroll): Remove unnecessary cast.
2179         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2180         cast.
2181         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2182         * tui/tui-regs.c (tui_display_registers_from)
2183         (tui_display_register): Remove unnecessary cast.
2184         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2185         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2186         (make_visible): Remove unnecessary cast.
2187         * tui/tui-winsource.c (tui_erase_source_content)
2188         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2189         unnecessary cast.
2190         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2191         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2192         * stabsread.c (read_type, read_array_type, read_range_type):
2193         Remove unnecessary cast.
2194         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2195         (parse_symbol, parse_type, upgrade_type, parse_external)
2196         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2197         unnecessary cast.
2198         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2199
2200 2019-06-16  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-data.c (tui_alloc_generic_win_info)
2203         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2204         checks.
2205
2206 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2207             Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * f-typeprint.c (f_print_type): Don't return early for not
2210         associated or not allocated types.
2211         (f_type_print_varspec_suffix): Add print_rank parameter and print
2212         ranks of array types in case they dangling.
2213         (f_type_print_base): Add print_rank parameter.
2214
2215 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * NEWS: Mention new MI commands.
2218         * break-catch-throw.c (enum exception_event_kind): Move to
2219         breakpoint.h.
2220         (print_mention_exception_catchpoint): Output text as a single
2221         message.
2222         (catch_exception_command_1): Rename to...
2223         (catch_exception_event): ...this, make non-static, update header
2224         command, and change some parameter types.
2225         (catch_catch_command): Update for changes to
2226         catch_exception_command_1.
2227         (catch_throw_command): Likewise.
2228         (catch_rethrow_command): Likewise.
2229         * breakpoint.c (enum exception_event_kind): Delete.
2230         * breakpoint.h (enum exception_event_kind): Moved here from
2231         break-catch-throw.c.
2232         (catch_exception_event): Declare.
2233         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2234         (mi_cmd_catch_throw): New function.
2235         (mi_cmd_catch_rethrow): New function.
2236         (mi_cmd_catch_catch): New function.
2237         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2238         'catch-catch' entries.
2239         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2240         (mi_cmd_catch_rethrow): Declare.
2241         (mi_cmd_catch_catch): Declare.
2242
2243 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * annotate.c (annotate_source_line): Change return type to void,
2246         update implementation to match.
2247         * annotate.h (annotate_source_line): Change return type to void,
2248         update header comment.
2249         * stack.c (print_frame_info): Don't change what frame information
2250         is printed based on whether annotations are on or not.
2251
2252 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2255         (annotate_source): Make static.
2256         (annotate_source_line): Moved from source.c and renamed from
2257         identify_source_line.  Update the return type.
2258         * annotate.h (annotate_source): Delete declaration.
2259         (annotate_source_line): Declaration moved from source.h, and
2260         renamed from identify_source_line.  Return type updated.
2261         * source.c (identify_source_line): Moved to annotate.c and renamed
2262         to annotate_source_line.
2263         (info_line_command): Remove check of annotation_level.
2264         * source.h (identify_source_line): Move declaration to annotate.h
2265         and rename to annotate_source_line.
2266         * stack.c: Add 'annotate.h' include.
2267         (print_frame_info): Remove check of annotation_level before
2268         calling annotate_source_line.
2269
2270 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * source-cache.c (source_cache::get_plain_source_lines): Use
2273         open_source_file_with_line_charpos instead of just
2274         open_source_file, remove call to find_source_lines.
2275         (source_cache::get_source_lines): Likewise.
2276         * source.c (find_source_lines): Make static.
2277         (get_filename_and_charpos): Renamed into...
2278         (open_source_file_with_line_charpos): ..this along with changes to
2279         return a scoped_fd, and some other minor clean ups.
2280         (identify_source_line): Use open_source_file_with_line_charpos.
2281         (search_command_helper): Use open_source_file_with_line_charpos
2282         instead of just open_source_file, remove call to
2283         find_source_lines.
2284         * source.h (open_source_file_with_line_charpos): Declare new
2285         function.
2286         (find_source_lines): Delete declaration.
2287
2288 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * source.c (get_filename_and_charpos): Remove fullname
2291         parameter.
2292         (identify_source_line): Update call to get_filename_and_charpos.
2293
2294 2019-06-14  Tom Tromey  <tromey@adacore.com>
2295
2296         PR gdb/24502:
2297         * ui-style.h (skip_ansi_escape): Update comment.
2298         * ui-file.h (class no_terminal_escape_file): New class.
2299         * ui-file.c (no_terminal_escape_file::write)
2300         (no_terminal_escape_file::puts): New methods.
2301         * cli/cli-logging.c (handle_redirections): Use
2302         no_terminal_escape_file.
2303
2304 2019-06-14  Tom Tromey  <tromey@adacore.com>
2305
2306         * NEWS: Move convenience variable news above Python news.
2307
2308 2019-06-14  Tom Tromey  <tom@tromey.com>
2309
2310         * gnulib: Move directory to top-level.
2311         * configure.ac: Don't configure gnulib.
2312         * configure: Rebuild.
2313         * common/common-defs.h: Use new path to gnulib.
2314         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2315         (GNULIB_H): Remove.
2316         (INCGNU): Look in new gnulib location.
2317         (HFILES_NO_SRCDIR): Remove gnulib files.
2318         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2319         (generated_files): Remove GNULIB_H.
2320         ($(LIBGNU), all-lib): Remove targets.
2321         (distclean): Don't mention GNULIB_BUILDDIR.
2322         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2323
2324 2019-06-14  Tom Tromey  <tromey@adacore.com>
2325
2326         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2327         Warn if symbol file does not provide any symbols.
2328
2329 2019-06-14  Tom Tromey  <tromey@adacore.com>
2330
2331         * source.c (find_and_open_source): Respect basenames_may_differ.
2332
2333 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2334
2335         * annotate.c (annotate_breakpoints_invalid): Make use of
2336         scoped_restore_terminal_state.
2337         (annotate_frames_invalid): Likewise.
2338
2339 2019-06-14  Tom Tromey  <tromey@adacore.com>
2340
2341         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2342         allow assignment to an internalvar.
2343
2344 2019-06-14  Tom Tromey  <tromey@adacore.com>
2345
2346         * ada-lex.l: Allow "_" in attribute names.
2347
2348 2019-06-14  Tom Tromey  <tromey@adacore.com>
2349
2350         PR gdb/24653:
2351         * regcache.c (registers_changed): Don't call alloca.
2352         * top.c (execute_command): Don't call alloca.
2353
2354 2019-06-13  Pedro Alves  <palves@redhat.com>
2355
2356         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2357         'expression'.  When parsing an expression, error out if there's
2358         junk after "unlimited".
2359         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2360         (do_set_command): Adjust calls to is_unlimited_literal.
2361
2362 2019-06-13  Pedro Alves  <palves@redhat.com>
2363
2364         * compile/compile.c (make_compile_options_def_group): Add braces
2365         around array_view initializer.
2366         * thread.c (make_thread_apply_all_options_def_group)
2367         (make_thread_apply_all_options_def_group): Likewise.
2368
2369 2019-06-13  Pedro Alves  <palves@redhat.com>
2370
2371         * NEWS (New commands): Mention "maint test-options
2372         require-delimiter", "maint test-options unknown-is-error", "maint
2373         test-options unknown-is-operand" and "maint show
2374         test-options-completion-result".
2375         (New command options, command completion): New section.
2376         (Completion improvements): New section.
2377         Mention that you can abbreviate "unlimited".
2378
2379 2019-06-13  Pedro Alves  <palves@redhat.com>
2380
2381         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2382         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2383         * unittests/cli-utils-selftests.c (test_parse_flags)
2384         (test_parse_flags_qcs): Delete.
2385         (test_cli_utils): Don't call deleted functions.
2386
2387 2019-06-13  Pedro Alves  <palves@redhat.com>
2388
2389         * thread.c: Include "cli/cli-option.h".
2390         (tp_array_compar_ascending): Global.
2391         (tp_array_compar): Delete function.
2392         (tp_array_compar_ascending, tp_array_compar_descending): New
2393         functions.
2394         (ascending_option_def, qcs_flag_option_def)
2395         (thr_qcs_flags_option_defs)
2396         (make_thread_apply_all_options_def_group)
2397         (make_thread_apply_options_def_group): New.
2398         (thread_apply_all_command): Use gdb::option::process_options.
2399         (thread_apply_command_completer)
2400         (thread_apply_all_command_completer): New.
2401         (thread_apply_command): Use gdb::option::process_options.
2402         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2403         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2404         to generate help text of "thread apply".  Adjust "taas"'s help.
2405         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2406         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2407
2408 2019-06-13  Pedro Alves  <palves@redhat.com>
2409
2410         * thread.c (thread_apply_command): Check for invalid TID with
2411         isdigit instead of !isalpha.
2412
2413 2019-06-13  Pedro Alves  <palves@redhat.com>
2414
2415         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2416         (validate_flags_qcs): New.
2417         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2418         (validate_flags_qcs): Declare.
2419         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2420         (make_frame_apply_options_def_group): New.
2421         (frame_apply_command_count): Process options with
2422         gdb::option::process_options.
2423         (frame_apply_completer): New.
2424         (frame_apply_level_completer, frame_apply_all_completer)
2425         (frame_apply_completer): New.
2426         (_initialize_stack): Update help of "frame apply", "frame apply
2427         level", "frame apply all" and "faas" to mention supported options
2428         and install command completers.
2429         * stack.h (frame_apply_all_completer): Declare.
2430         * thread.c: Include "stack.h".
2431         (tfaas_command): Add "--".
2432         (_initialize_thread): Update help "tfaas" to mention supported
2433         options and install command completer.
2434
2435 2019-06-13  Pedro Alves  <palves@redhat.com>
2436
2437         * completer.c (complete_nested_command_line): New.
2438         (gdb_completion_word_break_characters_throw): Add assertion.
2439         * completer.h (complete_nested_command_line): Declare.
2440
2441 2019-06-13  Pedro Alves  <palves@redhat.com>
2442
2443         * stack.c (parse_backtrace_qualifiers): New.
2444         (backtrace_command): Use it.
2445         (backtrace_command_completer): Complete on qualifiers.
2446
2447 2019-06-13  Pedro Alves  <palves@redhat.com>
2448
2449         * frame.c: Include "cli/cli-option.h.
2450         (user_set_backtrace_options): New.
2451         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2452         Delete.
2453         (get_prev_frame): Adjust.
2454         (boolean_option_def, uinteger_option_def)
2455         (set_backtrace_option_defs): New.
2456         (_initialize_frame): Adjust and use
2457         gdb::option::add_setshow_cmds_for_options to install "set
2458         backtrace past-main" and "set backtrace past-entry".
2459         * frame.h: Include "cli/cli-option.h".
2460         (struct frame_print_options): Forward declare.
2461         (print_frame_arguments_all, print_frame_arguments_scalars)
2462         (print_frame_arguments_none): Declare.
2463         (print_entry_values): Delete declaration.
2464         (struct frame_print_options, user_frame_print_options): New.
2465         (struct set_backtrace_options): New.
2466         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2467         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2468         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2469         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2470         (list_args_or_locals): Add frame_print_options parameter.
2471         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2472         * python/py-framefilter.c (enumerate_args): Pass down
2473         USER_FRAME_PRINT_OPTIONS.
2474         * stack.c: Include "cli/cli-option.h".
2475         (print_frame_arguments_all, print_frame_arguments_scalars)
2476         (print_frame_arguments_none): Declare.
2477         (print_raw_frame_arguments, print_entry_values): Delete.
2478         (user_frame_print_options): New.
2479         (boolean_option_def, enum_option_def, frame_print_option_defs):
2480         New.
2481         (struct backtrace_cmd_options): New.
2482         (bt_flag_option_def): New.
2483         (backtrace_command_option_defs): New.
2484         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2485         (print_frame_arg, read_frame_arg, print_frame_args)
2486         (print_frame_info, print_frame): Add frame_print_options parameter
2487         and use it.
2488         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2489         (backtrace_command_1): Add frame_print_options and
2490         backtrace_cmd_options parameters and use them.
2491         (make_backtrace_options_def_group): New.
2492         (backtrace_command): Process command options with
2493         gdb::option::process_options.
2494         (backtrace_command_completer): New.
2495         (_initialize_stack): Extend "backtrace"'s help to mention
2496         supported options.  Install completer for "backtrace".
2497         Install some settings commands with add_setshow_cmds_for_options.
2498
2499 2019-06-13  Pedro Alves  <palves@redhat.com>
2500
2501         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2502         and that "set/show print raw frame-arguments" are now deprecated.
2503
2504         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2505         command.
2506         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2507         * stack.c (_initialize_stack): Install "set/show print
2508         raw-frame-arguments", and deprecate "set/show print raw
2509         frame-arguments".
2510         * valprint.c (_initialize_valprint): Deprecate "set/show print
2511         raw".
2512
2513 2019-06-13  Pedro Alves  <palves@redhat.com>
2514
2515         * compile/compile.c (struct compile_options): New.
2516         (compile_flag_option_def, compile_command_option_defs)
2517         (make_compile_options_def_group): New.
2518         (compile_file_command): Handle options with
2519         gdb::option::process_options.
2520         (compile_file_command_completer): New function.
2521         (compile_code_command): Handle options with
2522         gdb::option::process_options.
2523         (compile_code_command_completer): New function.
2524         (_initialize_compiler): Install completers for "compile code" and
2525         "compile file".  Mention available options in "compile code" and
2526         "compile code"'s help.
2527         * completer.c (advance_to_completion_word): New, factored out from
2528         ...
2529         (advance_to_expression_complete_word_point): ... this.
2530         (advance_to_filename_complete_word_point): New.
2531         * completer.h (advance_to_filename_complete_word_point): New
2532         declaration.
2533
2534 2019-06-13  Pedro Alves  <palves@redhat.com>
2535
2536         * compile/compile.c: Include "cli/cli-option.h".
2537         (compile_print_value): Scope data pointer is now a
2538         value_print_options pointer; adjust.
2539         (compile_print_command): Process options.  Scope data pointer is
2540         now a value_print_options pointer; adjust.
2541         (_initialize_compile): Update "compile print"'s help to include
2542         supported options.  Install a completer for "compile print".
2543         * cp-valprint.c (show_vtblprint, show_objectprint)
2544         (show_static_field_print): Delete.
2545         (_initialize_cp_valprint): Don't install "set print
2546         static-members", "set print vtbl", "set print object" here.
2547         * printcmd.c: Include "cli/cli-option.h" and
2548         "common/gdb_optional.h".
2549         (print_command_parse_format): Rework to fill in a
2550         value_print_options instead of a format_data.
2551         (print_value): Change parameter type from format_data pointer to
2552         value_print_options reference.  Adjust.
2553         (print_command_1): Process options.  Adjust to pass down a
2554         value_print_options.
2555         (print_command_completer): New.
2556         (_initialize_printcmd): Install print_command_completer as
2557         handle_brkchars completer for the "print" command.  Update
2558         "print"'s help to include supported options.
2559         * valprint.c: Include "cli/cli-option.h".
2560         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2561         here from cp-valprint.c.
2562         (boolean_option_def, uinteger_option_def)
2563         (value_print_option_defs, make_value_print_options_def_group):
2564         New.  Use gdb::option::add_setshow_cmds_for_options to install
2565         "set print elements", "set print null-stop", "set print repeats",
2566         "set print pretty", "set print union", "set print array", "set
2567         print address", "set print symbol", "set print array-indexes".
2568         * valprint.h: Include <string> and "cli/cli-option.h".
2569         (make_value_print_options_def_group): Declare.
2570         (print_value): Change parameter type from format_data pointer to
2571         value_print_options reference.
2572         (print_command_completer): Declare.
2573
2574 2019-06-13  Pedro Alves  <palves@redhat.com>
2575
2576         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2577         (COMMON_SFILES): Add maint-test-settings.c.
2578         * cli/cli-decode.c (boolean_enums): New global, factored out from
2579         ...
2580         (add_setshow_boolean_cmd): ... here.
2581         * cli/cli-decode.h (boolean_enums): Declare.
2582         * cli/cli-option.c: New file.
2583         * cli/cli-option.h: New file.
2584         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2585         factored out from ...
2586         (parse_cli_boolean_value(const char *)): ... this.
2587         (is_unlimited_literal): Change parameter type to pointer to
2588         pointer.  Adjust and advance ARG pointer.
2589         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2590         (parse_cli_var_enum): New, factored out from ...
2591         (do_set_command): ... this.  Adjust.
2592         * cli/cli-setshow.h (parse_cli_boolean_value)
2593         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2594         (parse_cli_var_enum): Declare.
2595         * cli/cli-utils.c: Include "cli/cli-option.h".
2596         (get_ulongest): New.
2597         * cli/cli-utils.h (get_ulongest): Declare.
2598         (check_for_argument): New overloads.
2599         * maint-test-options.c: New file.
2600
2601 2019-06-13  Pedro Alves  <palves@redhat.com>
2602
2603         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2604         parse a range if "-" is at the end of the string.
2605
2606 2019-06-13  Pedro Alves  <palves@redhat.com>
2607
2608         * cli/cli-setshow.c (parse_auto_binary_operation)
2609         (parse_cli_boolean_value): Don't allow "o".
2610
2611 2019-06-13  Pedro Alves  <palves@redhat.com>
2612
2613         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2614         * NEWS: Mention maint test-settings KIND.
2615         * maint-test-settings.c: New file.
2616
2617 2019-06-13  Pedro Alves  <palves@redhat.com>
2618
2619         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2620         completer.
2621         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2622         "set" completers.
2623
2624 2019-06-13  Pedro Alves  <palves@redhat.com>
2625
2626         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2627         after item.
2628
2629 2019-06-13  Pedro Alves  <palves@redhat.com>
2630
2631         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2632
2633 2019-06-13  Pedro Alves <palves@redhat.com>
2634
2635         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2636         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2637         call.
2638         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2639         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2640         calls.
2641         (check_for_argument): Skip spaces after argument.
2642
2643 2019-06-13  Pedro Alves  <palves@redhat.com>
2644
2645         * thread.c (thread_apply_command): Adjust TID parsing.
2646         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2647         detected before end of string.
2648         (tid_is_in_list): Error out if LIST is invalid.
2649
2650 2019-06-13  Pedro Alves  <palves@redhat.com>
2651
2652         * completer.c (complete_line_internal_1): Rewind completion word
2653         point.
2654         (completion_tracker::advance_custom_word_point_by): Change
2655         parameter type to int.
2656         * completer.h (completion_tracker::advance_custom_word_point_by):
2657         Likewise.
2658
2659 2019-06-13  Pedro Alves  <palves@redhat.com>
2660
2661         * completer.c (advance_to_completion_word): Handle delimiters.
2662
2663 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2664
2665         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2666
2667 2019-06-11  Tom Tromey  <tom@tromey.com>
2668
2669         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2670         (xmalloc_failed): Move to alloc.c.
2671         * alloc.c: New file.
2672         * Makefile.in (COMMON_SFILES): Add alloc.c.
2673
2674 2019-06-11  Tom Tromey  <tom@tromey.com>
2675
2676         * nat/linux-waitpid.c: Don't include server.h.
2677         (linux_debug): Remove.
2678         (my_waitpid): Update.
2679
2680 2019-06-11  Tom Tromey  <tromey@adacore.com>
2681
2682         * infcall.c (_initialize_infcall): Remove trailing newline from
2683         help.
2684         * user-regs.c (_initialize_user_regs): Remove trailing newline
2685         from help.
2686         * typeprint.c (_initialize_typeprint): Remove trailing newline
2687         from help.
2688         * reverse.c (_initialize_reverse): Remove trailing newlines from
2689         help.
2690         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2691         from help.
2692         * language.c (add_set_language_command): Remove trailing newline
2693         from help.
2694         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2695         help.
2696         * disasm.c (_initialize_disasm): Remove trailing newline from
2697         help.
2698         * top.c (init_main): Remove trailing newline from help.
2699         * interps.c (_initialize_interpreter): Remove trailing newline
2700         from help.
2701         * btrace.c (_initialize_btrace): Remove trailing newlines from
2702         help.
2703         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2704         from help.
2705         * python/python.c (_initialize_python): Remove trailing newline
2706         from help.
2707         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2708         help.
2709         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2710         from help.  Reformat some text.
2711         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2712         from help.
2713         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2714         newline from help.
2715
2716 2019-06-11  Tom Tromey  <tromey@adacore.com>
2717
2718         * darwin-nat.c (darwin_decode_exception_message)
2719         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2720
2721 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * valops.c (value_slice): Check for not allocated or not
2724         associated values.
2725
2726 2019-06-10  Tom de Vries  <tdevries@suse.de>
2727
2728         PR gdb/24618
2729         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2730         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2731         invalid.
2732
2733 2019-06-10  Tom de Vries  <tdevries@suse.de>
2734
2735         PR gdb/24611
2736         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2737         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2738
2739 2019-06-10  Tom de Vries  <tdevries@suse.de>
2740
2741         PR symtab/24545
2742         * symtab.c (struct demangled_name_entry): Add language field.
2743         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2744         static minimal symbol".  Set and use language field.
2745
2746 2019-06-10  Tom Tromey  <tromey@adacore.com>
2747
2748         * ada-lang.c (_initialize_ada_language): Update help text.
2749
2750 2019-06-10  Tom Tromey  <tromey@adacore.com>
2751
2752         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2753         with a newline.
2754         * guile/guile.c (handle_boot_error): Don't end warning with a
2755         newline.
2756         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2757         warning with a newline.
2758         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2759         newline.
2760         (s12z_frame_cache): Likewise.
2761         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2762         a newline.
2763         * solib-svr4.c (disable_probes_interface): Don't end warning with
2764         a newline.
2765         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2766         newline.
2767         * python/python.c (do_finish_initialization): Don't end warning
2768         with a newline.
2769
2770 2019-06-10  Tom Tromey  <tom@tromey.com>
2771
2772         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2773         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2774         gdbpy_enter.
2775
2776 2019-06-10  Tom Tromey  <tromey@adacore.com>
2777
2778         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2779         data.
2780         (elf_new_init): Don't call stabsread_new_init.
2781         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2782         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2783         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2784
2785 2019-06-10  Tom de Vries  <tdevries@suse.de>
2786
2787         PR symtab/16264
2788         PR symtab/24517
2789         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2790
2791 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2792
2793         * source.c (find_and_open_source): Also rewrite relative file
2794         names.
2795
2796 2019-04-26  Amos Bird  <amosbird@gmail.com>
2797
2798         * annotate.c (annotate_thread_exited): Add "thread-exited"
2799         annotation.
2800
2801 2019-06-06  Tom Tromey  <tromey@adacore.com>
2802
2803         * maint.h (class scoped_command_stats): Use
2804         DISABLE_COPY_AND_ASSIGN.
2805         <print_time>: New method.
2806         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2807         print_time.
2808         (scoped_command_stats::print_time): New method.
2809
2810 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2813         instructions of lengths 6 or 8 bytes.
2814
2815 2019-06-04  Pedro Alves  <palves@redhat.com>
2816
2817         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2818
2819         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2820         * breakpoint.c (condition_completer): Likewise.
2821         * cli/cli-dump.c (scan_expression): Likewise.
2822         * common/filestuff.c (mkdir_recursive): Likewise.
2823         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2824         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2825         (gdb_abspath): Likewise.
2826         * compile/compile-cplus-types.c
2827         (compile_cplus_instance::decl_name): Likewise.
2828         * completer.c (complete_explicit_location):
2829         (signal_completer, reg_or_group_completer_1): Likewise.
2830         * cp-support.c (cp_remove_params_if_any): Likewise.
2831         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2832         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2833         * infcmd.c (strip_bg_char): Likewise.
2834         * linespec.c (copy_token_string): Likewise.
2835         * mi/mi-main.c (output_cores): Likewise.
2836         * psymtab.c (psymtab_search_name):
2837         * symfile.c (test_set_ext_lang_command): Likewise.
2838         * target.c (target_fileio_read_stralloc): Likewise.
2839         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2840         * value.c (complete_internalvar): Likewise.
2841
2842 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2843
2844         Add objfile property to gdb.Type.
2845         * NEWS: Mention Python API addition.
2846         * python/py-type.c (typy_get_objfile): New method.
2847
2848 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2849
2850         * NEWS: Mention the new set|show style [title|highlight].
2851         Mention changes to "show style", "help" and "apropos".
2852
2853 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2854
2855         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2856         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2857         instead of print_help_for_command.
2858         (print_doc_of_command): New function.
2859         (help_list): Add 'apropos -v word' suggestion.
2860         (print_help_for_command): Style the command name using title style.
2861         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2862         (_initialize_cli_cmds): Describe -v in apropos_command help.
2863
2864 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2865
2866         * cli/cli-style.h (cli_style_option): Add name in constructor,
2867         add m_name class member, add constructor with intensity,
2868         add name class function.
2869         (cli_style_option::add_setshow_commands): Remove name argument.
2870         (highlight_style, title_style): New styles.
2871         * cli/cli-style.c (do_show): New function that shows a style
2872         characteristic styling the style name with itself.
2873         (set_style_name): New function.
2874         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2875         Update all callers according to the changes in cli/cli-style.h.
2876         * utils.h (fputs_highlighted): New function.
2877         * utils.c (fputs_highlighted): Likewise.
2878
2879 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2880
2881         * NEWS: Mention new pipe command and new convenience variables.
2882
2883 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2884
2885         * cli/cli-cmds.c (pipe_command): New function.
2886         (_initialize_cli_cmds): Call add_com for pipe_command.
2887         Define | as an alias for pipe.
2888         (exit_status_set_internal_vars): New function.
2889         (shell_escape): Call exit_status_set_internal_vars.
2890         cli/cli-decode.c (find_command_name_length): Recognize | as
2891         a single character command.
2892
2893 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2894
2895         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2896         top.c (execute_command_to_ui_file): New function, mostly a copy
2897         of execute_command_to_string.
2898         (execute_command_to_string): Implement by calling
2899         execute_command_to_ui_file.
2900
2901 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2902
2903         * top.h (saved_command_line): Remove declaration.
2904         * top.c (previous_saved_command_line, previous_repeat_arguments):
2905         New variables.
2906         (saved_command_line): Make static, define together with other
2907         'repeat variables'.
2908         (dont_repeat): Clear repeat_arguments.
2909         (repeat_previous, get_saved_command_line, save_command_line):
2910         New functions.
2911         (gdb_init): Initialize saved_command_line
2912         and previous_saved_command_line.
2913         * main.c (captured_main_1): Remove saved_command_line initialization.
2914         * event-top.c (handle_line_of_input): Update to use
2915         the new 'repeat' related functions instead of direct access to
2916         saved_command_line.
2917         * command.h (repeat_previous, get_saved_command_line,
2918         save_command_line): New declarations.
2919         (dont_repeat): Add comment.
2920
2921 2019-05-30  Tom Tromey  <tromey@adacore.com>
2922
2923         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2924         Fix comment.
2925         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2926
2927 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2928
2929         PR cli/24587
2930         * completer.c (complete): Initialize variable word.
2931
2932 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2933
2934         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2935         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2936         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2937         'body' is NULL to the outter 'if', protecting the '!is_define'
2938         situation as well.
2939
2940 2019-05-29  Tom Tromey  <tromey@adacore.com>
2941
2942         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2943         (dwarf_unknown): New function.
2944         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2945         (dwarf_type_encoding_name): Use dwarf_unknown.
2946
2947 2019-05-29  Tom Tromey  <tromey@adacore.com>
2948
2949         PR c++/20020:
2950         * cp-valprint.c (cp_print_value_fields): Call
2951         cp_print_static_field inside "try".
2952
2953 2019-05-29  Tom Tromey  <tromey@adacore.com>
2954
2955         * inflow.c (struct terminal_info): Add default operator=.
2956         * configure: Rebuild.
2957         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2958         -Wdeprecated-copy-dtor, -Wredundant-move.
2959
2960 2019-05-29  Tom Tromey  <tromey@adacore.com>
2961
2962         * NEWS: Add entry.
2963         * infcmd.c (print_return_value_1): Handle finish_print
2964         option.
2965         (show_print_finish): New function.
2966         (_initialize_infcmd): Add "set/show print finish" commands.
2967         * valprint.c (user_print_options): Initialize new member.
2968         * valprint.h (struct value_print_options) <finish_print>: New
2969         member.
2970
2971 2019-05-28  Tom Tromey  <tromey@adacore.com>
2972
2973         * ada-lang.c (ada_remove_Xbn_suffix)
2974         (find_old_style_renaming_symbol)
2975         (parse_old_style_renaming): Remove.
2976         (ada_find_renaming_symbol): Don't call
2977         find_old_style_renaming_symbol.
2978         (ada_is_renaming_symbol): Rename from
2979         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2980         bool.  Now static.
2981         (ada_read_var_value): Update and simplify.
2982         * ada-exp.y (write_var_or_type): Remove old code.
2983
2984 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2985
2986         * event-top.c: Remove include comment.
2987         * inflow.c (class scoped_ignore_sigttou): Move from here...
2988         * inflow.h (class scoped_ignore_sigttou): ...to here.
2989         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2990         * top.c:  Remove include comment.
2991
2992 2019-05-27  Tom Tromey  <tom@tromey.com>
2993
2994         * NEWS: Fix typo.
2995
2996 2019-05-22  Tom Tromey  <tromey@adacore.com>
2997
2998         * target.c (target_follow_exec): Constify parameter.
2999         * target-delegates.c: Rebuild.
3000         * remote.c (remote_target::follow_exec): Constify parameter.
3001         * infrun.c (follow_exec): Constify parameter.
3002         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3003         (target_follow_exec): Likewise.
3004
3005 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3006
3007         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3008         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3009
3010 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3011
3012         * NEWS: Add debugredirect and testsuite sections.
3013
3014 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3015
3016         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3017         target descriptions using exclusively floating point register name
3018         aliases.
3019
3020 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3021
3022         PR gdb/18644:
3023         * f-lang.c (build_fortran_types): Handle the case where
3024         gdbarch_floatformat_for_type returns a nullptr.
3025
3026 2019-05-21  Tom de Vries  <tdevries@suse.de>
3027
3028         PR cli/24587
3029         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3030
3031 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3032
3033         PR gdb/18644:
3034         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3035         16-byte floats.
3036         * i386-tdep.c (i386_floatformat_for_type): Use
3037         floatformats_ia64_quad for the 16-byte floating point component
3038         within a fortran 32-byte complex number.
3039
3040 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3043         delete default constructor.
3044         (find_partial_die): Update to return const struct.
3045         (partial_die_parent_scope): Move variable declaration into scope
3046         of its use and change its type to auto.
3047         (guess_partial_die_structure_name): Likewise.
3048         (partial_die_info::fixup): Likewise.
3049
3050 2019-05-17  Tom Tromey  <tromey@adacore.com>
3051
3052         * source.c (find_and_open_source): Remove cast.
3053
3054 2019-05-17  Tom Tromey  <tromey@adacore.com>
3055
3056         * annotate.c (annotate_source): Make "filename" const.
3057         * annotate.h (annotate_source): Use const.
3058
3059 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3060
3061         * disasm.c (set_disassembler_options): Send errors to stderr.
3062
3063 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3064
3065         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3066         (cli_interp_base::set_logging): Check debug_redirect.
3067         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3068         * cli/cli-logging.c (debug_redirect): Add static variable.
3069         (pop_output_files): Add default param.
3070         (handle_redirections): Print debug setting.
3071         (show_logging_command): Likewise.
3072         (_initialize_cli_logging): Add debugredirect command.
3073         * interps.c (current_interp_set_logging): Add debug_redirect
3074         parameter.
3075         * interps.h (set_logging): Add debug_redirect parameter.
3076         (current_interp_set_logging): Likewise.
3077         * mi/mi-common.h: Likewise.
3078         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3079
3080 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3081             Tom Tromey  <tromey@adacore.com>
3082
3083         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3084         directly.
3085         * cli/cli-interp.h (make_logging_output): Remove declaration.
3086         * cli/cli-logging.c (make_logging_output): Remove function.
3087         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3088         directly.
3089         * ui-file.c (tee_file::tee_file): Remove bools.
3090         (tee_file::~tee_file): Remove deletes.
3091         * ui-file.h (tee_file): Remove bools.
3092
3093 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3094
3095         * mi/mi-cmds.h (mi_cmd_complete): New function.
3096         * mi/mi-main.c (mi_cmd_complete): Likewise.
3097         * mi/mi-cmds.c: Define new MI command -complete.
3098         * NEWS: Mention new -complete command.
3099
3100 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3101
3102         * completer.h (complete): New function.
3103         * completer.c (complete): Likewise.
3104         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3105         function defined in completer.h.
3106
3107 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3108
3109         * MAINTAINERS (Write After Approval): Add myself.
3110
3111 2019-05-17  Tom de Vries  <tdevries@suse.de>
3112
3113         PR gdb/24094
3114         * dwarf2read.c (struct cu_partial_die_info): New struct.
3115         (find_partial_die): Return cu_partial_die_info.
3116         (partial_die_parent_scope, guess_partial_die_structure_name)
3117         (partial_die_info::fixup): Handle new return type of find_partial_die.
3118
3119 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3120
3121         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3122         "std::string", simplifying the algorithm.
3123
3124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3125
3126         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3127         (stap_static_probe_ops::get_probes): Likewise.
3128
3129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3130
3131         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3132         '-')" and "else if".
3133         (stap_parse_single_operand): Join checks for
3134         "gdbarch_stap_parse_special_token_p" and
3135         "gdbarch_stap_parse_special_token" in the same "if" statement.
3136         Invert check when verifying for operation on register
3137         displacement.
3138
3139 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3140
3141         * stap-probe.c (stap_get_opcode): Update comment.
3142         (stap_get_expected_argument_type): Likewise.
3143         (handle_stap_probe): Likewise.
3144
3145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3146
3147         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3148         return type to 'bool'.  Adjust comment.  Use 'bool' when
3149         appropriate.
3150         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3151         * stap-probe.c (stap_parse_argument_1): Likewise.
3152         (stap_is_operator): Likewise.
3153         (stap_is_generic_prefix): Likewise.
3154         (stap_is_register_prefix): Likewise.
3155         (stap_is_register_indirection_prefix): Likewise.
3156         (stap_is_integer_prefix): Likewise.
3157         (stap_generic_check_suffix): Likewise.
3158         (stap_check_integer_suffix): Likewise.
3159         (stap_check_register_suffix): Likewise.
3160         (stap_check_register_indirection_suffix): Likewise.
3161         (stap_parse_register_operand): Likewise.
3162         (stap_parse_single_operand): Likewise.
3163         (stap_parse_argument_1): Likewise.
3164         (stap_probe::get_argument_count): Likewise.
3165         (stap_is_operator): Likewise.
3166
3167 2019-05-16  Tom Tromey  <tromey@adacore.com>
3168
3169         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3170         keyword to foreach.
3171
3172 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3173
3174         * linux-thread-db.c (try_thread_db_load_1): Change return type
3175         to bool.
3176         (try_thread_db_load): Likewise.
3177         (try_thread_db_load_from_pdir_1): Likewise.
3178         (try_thread_db_load_from_pdir): Likewise.
3179         (try_thread_db_load_from_sdir): Likewise.
3180         (try_thread_db_load_from_dir): Likewise.
3181         (thread_db_load_search): Likewise.
3182         (has_libpthread): Likewise.
3183         (thread_db_load): Likewise.
3184
3185 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3186
3187         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3188         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3189         NULL, and complain/return if that's the case.
3190
3191 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3192
3193         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3194         (advance, posn, abstract_read_memory): New functions.
3195         [struct mem_read_abstraction]: New struct.
3196         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3197
3198 2019-05-14  Tom Tromey  <tromey@adacore.com>
3199
3200         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3201         value is not lval_memory.
3202
3203 2019-05-14  Tom Tromey  <tromey@adacore.com>
3204
3205         * solib.c (info_sharedlibrary_command): Style the file name.
3206
3207 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3208
3209         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3210         (aarch64_vnv_type): Likewise.
3211         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3212         * common/tdesc.c: Likewise.
3213         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3214         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3215         * features/aarch64-fpu.xml: Add ieee half view.
3216         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3217         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3218         * gdbtypes.h (struct builtin_type): Likewise.
3219         (struct objfile_type): Likewise.
3220
3221 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3222
3223         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3224         typo.
3225         * location.h (string_to_event_location): Likewise.
3226
3227 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3228
3229         GDB 8.3 released.
3230
3231 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3232
3233         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3234         New variable declaration.
3235         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3236         New variable.
3237         (print_one_breakpoint): Use ui_out::test_flags and new global
3238         variable to compute use_fixed_output.
3239         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3240         Remove.
3241         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3242         (mi_multi_location_breakpoint_output_fixed): Remove.
3243         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3244         new variable.
3245         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3246         fix_multi_location_breakpoint_output flag if version >= 3.
3247         * ui-out.h (enum ui_out_flag)
3248         <fix_multi_location_breakpoint_output>: New enumerator.
3249
3250 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3251
3252         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3253
3254 2019-05-10  Tom Tromey  <tromey@adacore.com>
3255
3256         * ada-lang.c (catch_ada_completer): New function.
3257         (_initialize_ada_language): Use it.
3258
3259 2019-05-10  Tom Tromey  <tromey@adacore.com>
3260
3261         * thread.c (print_thread_info): Make "requested_threads" const.
3262         * gdbthread.h (print_thread_info): Make "requested_threads"
3263         const.
3264         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3265         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3266
3267 2019-05-08  Tom Tromey  <tom@tromey.com>
3268
3269         * gdbtypes.c (objfile_type_data): Change type.
3270         (objfile_type, _initialize_gdbtypes): Update.
3271
3272 2019-05-08  Tom Tromey  <tom@tromey.com>
3273
3274         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3275         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3276         (_initialize_dwarf2_frame): Update.
3277
3278 2019-05-08  Tom Tromey  <tom@tromey.com>
3279
3280         * objc-lang.c (objc_objfile_data): Change type.
3281         (find_methods): Update.
3282         (_initialize_objc_lang): Remove.
3283
3284 2019-05-08  Tom Tromey  <tom@tromey.com>
3285
3286         * stabsread.c (rs6000_builtin_type_data): Change type.
3287         (rs6000_builtin_type, _initialize_stabsread): Update.
3288
3289 2019-05-08  Tom Tromey  <tom@tromey.com>
3290
3291         * mips-tdep.c (mips_pdr_data): Remove.
3292         (_initialize_mips_tdep): Update.
3293
3294 2019-05-08  Tom Tromey  <tom@tromey.com>
3295
3296         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3297         (hppa_init_objfile_priv_data, read_unwind_info)
3298         (find_unwind_entry, _initialize_hppa_tdep): Update.
3299
3300 2019-05-08  Tom Tromey  <tom@tromey.com>
3301
3302         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3303         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3304         on obstack.
3305         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3306
3307 2019-05-08  Tom Tromey  <tom@tromey.com>
3308
3309         * mdebugread.c (basic_type_data): Change type.
3310         (basic_type, _initialize_mdebugread): Update.
3311
3312 2019-05-08  Tom Tromey  <tom@tromey.com>
3313
3314         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3315
3316 2019-05-08  Tom Tromey  <tom@tromey.com>
3317
3318         * nto-tdep.c (nto_inferior_data_reg): Change type.
3319         (nto_inferior_data): Update.
3320         (nto_inferior_data_cleanup, nto_new_inferior_data)
3321         (_initialize_nto_tdep): Remove.
3322         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3323
3324 2019-05-08  Tom Tromey  <tom@tromey.com>
3325
3326         * ada-lang.c (struct ada_inferior_data): Add initializers.
3327         (ada_inferior_data): Change type.
3328         (ada_inferior_data_cleanup): Remove.
3329         (get_ada_inferior_data, ada_inferior_exit)
3330         (struct ada_pspace_data): Add initializers, destructor.
3331         (ada_pspace_data_handle): Change type.
3332         (get_ada_pspace_data): Update.
3333         (ada_pspace_data_cleanup): Remove.
3334
3335 2019-05-08  Tom Tromey  <tom@tromey.com>
3336
3337         * coffread.c (struct coff_symfile_info): Add initializers.
3338         (coff_objfile_data_key): Move lower.  Change type.
3339         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3340         Update.
3341         (coff_free_info): Remove.
3342
3343 2019-05-08  Tom Tromey  <tom@tromey.com>
3344
3345         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3346         (fbsd_pspace_data_handle): Move lower.  Change type.
3347         (get_fbsd_pspace_data): Update.
3348         (fbsd_pspace_data_cleanup): Remove.
3349         (_initialize_fbsd_tdep): Update.
3350
3351 2019-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3354         (get_ada_tasks_pspace_data): Update.
3355         (ada_tasks_pspace_data_cleanup): Remove.
3356         (_initialize_tasks): Update.
3357         (ada_tasks_inferior_data_handle): Change type.
3358         (get_ada_tasks_inferior_data): Update.
3359         (ada_tasks_inferior_data_cleanup): Remove.
3360         (struct ada_tasks_pspace_data): Add initializers.
3361
3362 2019-05-08  Tom Tromey  <tom@tromey.com>
3363
3364         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3365         * symfile-debug.c (debug_sym_get_probes): Change type.
3366         * stap-probe.c (handle_stap_probe):
3367         (stap_static_probe_ops::get_probes): Change type.
3368         * probe.h (class static_probe_ops) <get_probes>: Change type.
3369         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3370         (parse_probes_in_pspace): Update.
3371         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3372         Update.
3373         (any_static_probe_ops::get_probes): Change type.
3374         * elfread.c (elfread_data): New typedef.
3375         (probe_key): Change type.
3376         (elf_get_probes): Likewise.  Update.
3377         (probe_key_free): Remove.
3378         (_initialize_elfread): Update.
3379         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3380         Change type.
3381         (dtrace_process_dof_probe, dtrace_process_dof)
3382         (dtrace_static_probe_ops::get_probe): Change type.
3383
3384 2019-05-08  Tom Tromey  <tom@tromey.com>
3385
3386         * xcoffread.c (struct xcoff_symfile_info): Rename from
3387         coff_symfile_info.  Add initializers.
3388         (xcoff_objfile_data_key): Move lower.  Change type.
3389         (XCOFF_DATA): Rewrite.
3390         (xcoff_free_info): Remove.
3391         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3392         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3393         (xcoff_initial_scan): Update.
3394
3395 2019-05-08  Tom Tromey  <tom@tromey.com>
3396
3397         * solib-svr4.c (struct svr4_info): Add initializers and
3398         destructor.
3399         <probes_table>: Now an htab_up.
3400         (solib_svr4_pspace_data): Change type.
3401         (free_probes_table): Simplify.
3402         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3403         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3404         (probes_table_remove_objfile_probes, register_solib_event_probe)
3405         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3406         (_initialize_svr4_solib): Update.
3407
3408 2019-05-08  Tom Tromey  <tom@tromey.com>
3409
3410         * remote.c (remote_pspace_data): Change type.
3411         (remote_pspace_data_cleanup): Remove.
3412         (get_remote_exec_file, set_pspace_remote_exec_file)
3413         (_initialize_remote): Update.
3414
3415 2019-05-08  Tom Tromey  <tom@tromey.com>
3416
3417         * breakpoint.c (breakpoint_objfile_key): Change type.
3418         (get_breakpoint_objfile_data): Update.
3419         (free_breakpoint_objfile_data): Remove.
3420         (_initialize_breakpoint): Update.
3421
3422 2019-05-08  Tom Tromey  <tom@tromey.com>
3423
3424         * linux-tdep.c (struct linux_info): Add initializers.
3425         (linux_inferior_data): Move.  Change type.
3426         (invalidate_linux_cache_inf): Update.
3427         (linux_inferior_data_cleanup): Remove.
3428         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3429
3430 2019-05-08  Tom Tromey  <tom@tromey.com>
3431
3432         * auxv.c (auxv_inferior_data): Move.  Change type.
3433         (auxv_inferior_data_cleanup): Remove.
3434         (invalidate_auxv_cache_inf): Rewrite.
3435         (get_auxv_inferior_data, _initialize_auxv): Update.
3436
3437 2019-05-08  Tom Tromey  <tom@tromey.com>
3438
3439         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3440         (symfile_debug_objfile_data_key): Change type.
3441         (symfile_debug_installed, debug_qf_has_symbols)
3442         (debug_qf_find_last_source_symtab)
3443         (debug_qf_forget_cached_source_info)
3444         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3445         (debug_qf_print_stats, debug_qf_dump)
3446         (debug_qf_expand_symtabs_for_function)
3447         (debug_qf_expand_all_symtabs)
3448         (debug_qf_expand_symtabs_with_fullname)
3449         (debug_qf_map_matching_symbols)
3450         (debug_qf_expand_symtabs_matching)
3451         (debug_qf_find_pc_sect_compunit_symtab)
3452         (debug_qf_map_symbol_filenames)
3453         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3454         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3455         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3456         (debug_sym_read_linetable, debug_sym_relocate): Update.
3457         (symfile_debug_free_objfile): Remove.
3458         (install_symfile_debug_logging, _initialize_symfile_debug):
3459         Update.
3460
3461 2019-05-08  Tom Tromey  <tom@tromey.com>
3462
3463         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3464         allocate_on_obstack.
3465         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3466         (get_dwarf2_per_objfile): Update.
3467         (set_dwarf2_per_objfile): Remove.
3468         (dwarf2_has_info, dwarf2_get_section_info): Update.
3469         (dwarf2_free_objfile): Remove.
3470         (_initialize_dwarf2_read): Update.
3471
3472 2019-05-08  Tom Tromey  <tom@tromey.com>
3473
3474         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3475         initializers.
3476         <unsupported_script_warning_printed,
3477         script_not_found_warning_printed>: Now bool.
3478         (auto_load_pspace_data): Change type.
3479         (~auto_load_pspace_info): Rename from
3480         auto_load_pspace_data_cleanup.
3481         (get_auto_load_pspace_data, init_loaded_scripts_info)
3482         (clear_section_scripts, maybe_print_unsupported_script_warning)
3483         (maybe_print_script_not_found_warning, _initialize_auto_load):
3484         Update.
3485
3486 2019-05-08  Tom Tromey  <tom@tromey.com>
3487
3488         * objfiles.c (objfile_pspace_info): Add destructor and
3489         initializers.
3490         (objfiles_pspace_data): Change type.
3491         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3492         (get_objfile_pspace_data): Update.
3493         (objfiles_bfd_data): Change type.
3494         (get_objfile_bfd_data): Update.
3495         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3496
3497 2019-05-08  Tom Tromey  <tom@tromey.com>
3498
3499         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3500         Change type.
3501         (get_catch_syscall_inferior_data): Update.
3502         (catch_syscall_inferior_data_cleanup): Remove.
3503         (_initialize_break_catch_syscall): Update.
3504
3505 2019-05-08  Tom Tromey  <tom@tromey.com>
3506
3507         * inflow.c (struct terminal_info): Add destructor and
3508         initializers.
3509         (inflow_inferior_data): Change type.
3510         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3511         (get_inflow_inferior_data, inflow_inferior_exit)
3512         (swap_terminal_info, _initialize_inflow): Update.
3513
3514 2019-05-08  Tom Tromey  <tom@tromey.com>
3515
3516         * target-dcache.c (target_dcache_cleanup): Remove.
3517         (target_dcache_aspace_key): Change type.
3518         (target_dcache_init_p, target_dcache_invalidate)
3519         (target_dcache_get, target_dcache_get_or_init)
3520         (_initialize_target_dcache): Update.
3521         * dcache.h (struct dcache_deleter): New.
3522
3523 2019-05-08  Tom Tromey  <tom@tromey.com>
3524
3525         * symtab.c (struct symbol_cache): Add destructor and
3526         initializers.
3527         (symbol_cache_key): Move.  Change type.
3528         (make_symbol_cache, free_symbol_cache): Remove.
3529         (get_symbol_cache): Update.
3530         (symbol_cache_cleanup): Remove.
3531         (ALL_PSPACES, symbol_cache_flush)
3532         (maintenance_print_symbol_cache)
3533         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3534         Update.
3535
3536 2019-05-08  Tom Tromey  <tom@tromey.com>
3537
3538         * symtab.c (struct main_info): Add destructor and initializers.
3539         (main_progspace_key): Move.  Change type.
3540         (get_main_info): Update.
3541         (main_info_cleanup): Remove.
3542         (_initialize_symtab): Update.
3543
3544 2019-05-08  Tom Tromey  <tom@tromey.com>
3545
3546         * registry.h (DECLARE_REGISTRY): Define the _key class.
3547
3548 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3549
3550         * NEWS: Merge two 'New commands' sections.
3551
3552 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3553
3554         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3555         parameter and use Ada language definition instead.
3556         (ada_val_print_ptr): Remove unused language parameter.
3557         (ada_val_print_num): Remove language parameter and use Ada language
3558         definition instead.
3559         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3560         parameter.
3561         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3562         parameter and use Ada language definition instead.
3563         (ada_val_print_1): Update all ada_val_print_xxx calls.
3564         Remove language parameter.
3565         (ada_val_print): Update ada_val_print_1 call.
3566
3567 2019-05-08  Tom Tromey  <tromey@adacore.com>
3568
3569         * remote.c (remote_hw_watchpoint_limit)
3570         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3571         Now static.
3572
3573 2019-05-08  Tom Tromey  <tromey@adacore.com>
3574
3575         * maint.c (_initialize_maint_cmds): Move initialization code to
3576         remote.c.
3577         (watchdog, show_watchdog): Move to remote.c.
3578         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3579         "watchdog" static.
3580         (_initialize_remote): Move initialization code from maint.c.
3581         * defs.h (watchdog): Don't declare.
3582
3583 2019-05-08  Tom Tromey  <tromey@adacore.com>
3584
3585         * tui/tui-interp.c: Include main.h.
3586         * interps.c: Include main.h.
3587         * main.h (interpreter_p): Declare.
3588         * defs.h (interpreter_p): Don't declare.
3589
3590 2019-05-08  Tom Tromey  <tromey@adacore.com>
3591
3592         * dwarf2loc.c: Include dwarf2read.h.
3593         * defs.h (read_unsigned_leb128): Don't declare.
3594         * dwarf2read.h (read_unsigned_leb128): Declare.
3595
3596 2019-05-08  Tom Tromey  <tromey@adacore.com>
3597
3598         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3599         method.
3600
3601 2019-05-08  Tom Tromey  <tromey@adacore.com>
3602
3603         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3604         when no wrap column is set.
3605
3606 2019-05-08  Tom Tromey  <tromey@adacore.com>
3607
3608         * c-lang.c (c_get_string): Handle non-C-style arrays.
3609
3610 2019-05-08  Tom Tromey  <tromey@adacore.com>
3611
3612         * typeprint.c (print_offset_data::update): Print the bit offset,
3613         not the number of bits remaining.
3614
3615 2019-05-08  Tom Tromey  <tromey@adacore.com>
3616
3617         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3618         padding at end of comment.
3619
3620 2019-05-08  Tom Tromey  <tromey@adacore.com>
3621
3622         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3623         Compare main types.
3624
3625 2019-05-06  Tom Tromey  <tom@tromey.com>
3626
3627         * common/scoped_mmap.c: Include common-defs.h.
3628         * common/scoped_mmap.h: Don't include config.h.
3629
3630 2019-05-04  Tom Tromey  <tom@tromey.com>
3631
3632         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3633         (struct aarch64_call_info): Add initializers.
3634         <si>: Now a std::vector.
3635         (pass_on_stack, aarch64_push_dummy_call): Update.
3636
3637 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3638             Tom Tromey  <tom@tromey.com>
3639
3640         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3641         (ppc_threads): Now a std::vector.  Now static.
3642         (hwdebug_find_thread_points_by_tid)
3643         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3644         Update.
3645
3646 2019-05-04  Tom Tromey  <tom@tromey.com>
3647
3648         * arc-tdep.c (arc_tdesc_init): Return bool.
3649
3650 2019-05-04  Tom Tromey  <tom@tromey.com>
3651
3652         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3653         Use gdb_assert_not_reached.
3654
3655 2019-05-04  Tom Tromey  <tom@tromey.com>
3656
3657         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3658         "false".
3659
3660 2019-05-04  Tom Tromey  <tom@tromey.com>
3661
3662         * arc-tdep.c (arc_tdesc_init): Use bool.
3663
3664 2019-05-04  Tom Tromey  <tom@tromey.com>
3665
3666         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3667
3668 2019-05-04  Tom Tromey  <tom@tromey.com>
3669
3670         * cli/cli-cmds.c (valid_command_p): Return bool.
3671
3672 2019-05-04  Tom Tromey  <tom@tromey.com>
3673
3674         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3675         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3676
3677 2019-05-04  Raul Tambre  <raul@tambre.ee>
3678
3679         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3680         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3681         operator for comparison.
3682
3683 2019-05-04  Tom Tromey  <tom@tromey.com>
3684
3685         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3686         (lookup_partial_symbol, print_partial_symbols)
3687         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3688         (psymbol_compare): Update.
3689         (add_psymbol_to_bcache): Clear the entire psymbol.
3690         (maintenance_check_psymtabs): Update.
3691         * psympriv.h (struct partial_symbol): Don't derive from
3692         general_symbol_info.
3693         <obj_section, unrelocated_address, address,
3694         set_unrelocated_address>: Update.
3695         <ginfo>: New member.
3696         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3697         (debug_names::write_psymbols): Update.
3698
3699 2019-05-04  Tom de Vries  <tdevries@suse.de>
3700
3701         * contrib/cc-with-tweaks.sh: Support -n arg.
3702
3703 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3704
3705         * corelow.c (core_target::detach): Ensure frame cache and
3706         register caches are cleared.
3707         inferior.c (exit_inferior_1): Likewise.
3708
3709 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3710             Tom Tromey  <tom@tromey.com>
3711
3712         * dictionary.c (collate_pending_symbols_by_language): Remove
3713         "struct" from foreach.
3714         * symtab.c (lookup_global_symbol_from_objfile)
3715         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3716         foreach.
3717         * ser-tcp.c (net_open): Remove "struct" from foreach.
3718         * objfiles.c (objfile_relocate, objfile_rebase)
3719         (objfile_has_symbols): Remove "struct" from foreach.
3720         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3721         from foreach.
3722         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3723         foreach.
3724         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3725         "struct" from foreach.
3726         * ada-lang.c (create_excep_cond_exprs)
3727         (ada_exception_catchpoint_cond_string): Remove "struct" from
3728         foreach.
3729
3730 2019-05-03  Tom Tromey  <tromey@adacore.com>
3731
3732         * ada-exp.y (convert_char_literal): Check suffix of each
3733         enumerator.
3734
3735 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3736
3737         PR ada/21406:
3738         * ada-exp.y (yywrap): Don't define.
3739         * ada-lex.l (%option): Add noyywrap
3740         (yywrap): Remove.
3741
3742 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3743
3744         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3745         _WIN32_WINNT to the XP level, unless already defined to a higher
3746         level.
3747
3748         * unittests/parse-connection-spec-selftests.c:
3749         * ser-tcp.c:
3750         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3751         override.
3752
3753         * symfile.c (find_separate_debug_file): Remove colon from the
3754         drive spec of DOS/Windows file names of the target, so that the
3755         file name produced from DEBUGDIR and the target's directory will
3756         be valid on DOS/Windows systems.
3757
3758 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * rust-lang.c (val_print_struct): Handle printing structures
3761         containing strings.
3762
3763 2019-05-02  Tom Tromey  <tromey@adacore.com>
3764
3765         * valarith.c (_initialize_valarith): Remove.
3766
3767 2019-05-01  Tom Tromey  <tromey@adacore.com>
3768
3769         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3770         bitfields.
3771
3772 2019-05-01  Tom Tromey  <tromey@adacore.com>
3773
3774         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3775         for big-endian copies.
3776
3777 2019-04-30  Ali Tamur  <tamur@google.com>
3778         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3779         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3780         (read_3_bytes): New function.
3781
3782 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3783
3784         * windows-nat.c (main_thread_id): Delete.
3785         (handle_output_debug_string): Replace main_thread_id by
3786         current_event.dwThreadId.
3787         (fake_create_process): Likewise.
3788         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3789         Do not set main_thread_id.
3790         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3791         current_event.dwThreadId.
3792         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3793
3794 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3795
3796         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3797         Use current_event.dwThreadId instead of main_thread_id.
3798
3799 2019-04-30  Tom Tromey  <tromey@adacore.com>
3800
3801         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3802         (create_excep_cond_exprs): Iterate over program spaces.
3803         (ada_exception_catchpoint_cond_string): Examine all minimal
3804         symbols for exception types.
3805
3806 2019-04-30  Tom Tromey  <tromey@adacore.com>
3807
3808         PR c++/24470:
3809         * dwarf2read.c (process_structure_scope): Handle case where type
3810         has template parameters but no symbol was created.
3811
3812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3813             Chris January  <chris.january@arm.com>
3814
3815         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3816         qualifier.
3817         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3818
3819 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * f-typeprint.c (f_print_type): Update rules for printing
3822         whitespace.
3823         (f_type_print_varspec_suffix): Likewise.
3824
3825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3826             Chris January  <chris.january@arm.com>
3827
3828         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3829         function arguments.
3830
3831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * f-lang.c (build_fortran_types): Change name of void type to
3834         lower case.
3835         * f-typeprint.c (f_type_print_base): Print the name of the void
3836         type, rather than a fixed string.
3837         * f-valprint.c (f_decorations): Use lower case void string.
3838
3839 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3840             Chris January  <chris.january@arm.com>
3841
3842         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3843         types for Fortran.
3844
3845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3846             Chris January  <chris.january@arm.com>
3847             David Lecomber  <david.lecomber@arm.com>
3848
3849         * f-exp.y (BINOP_INTRINSIC): New token.
3850         (exp): New parser rule handling BINOP_INTRINSIC.
3851         (f77_keywords): Add new builtin procedures.
3852         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3853         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3854         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3855         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3856         (print_unop_subexp_f): New function.
3857         (print_binop_subexp_f): New function.
3858         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3859         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3860         (dump_subexp_body_f): Likewise.
3861         (operator_check_f): Likewise.
3862         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3863         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3864
3865 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3868         UNOP_KIND.
3869         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3870         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3871         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3872         (operator_length_f): New fuction.
3873         (print_subexp_f): New function.
3874         (op_name_f): New function.
3875         (dump_subexp_body_f): New function.
3876         (operator_check_f): New function.
3877         (exp_descriptor_f): Replace standard expression handling functions
3878         with new functions.
3879         * gdb/fortran-operator.def: New file.
3880         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3881         * gdb/std-operator.def: Remove UNOP_KIND.
3882
3883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * std-operator.def: Remove unbalanced, stray double quote
3886         character.
3887
3888 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3889             Chris January  <chris.january@arm.com>
3890             Daniel Everett  <daniel.everett@arm.com>
3891             Nick Forrington  <nick.forrington@arm.com>
3892             Richard Bunt  <richard.bunt@arm.com>
3893
3894         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3895         of depth when printing anonymous structs or unions.
3896         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3897         Don't print either the top-level value, or the children if the
3898         max-depth is exceeded.
3899         (ppscm_print_children): When printing the key of a map, allow one
3900         extra level of depth.
3901         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3902         print either the top-level value, or the children if the max-depth
3903         is exceeded.
3904         (print_children): When printing the key of a map, allow one extra
3905         level of depth.
3906         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3907         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3908         (user_print_options): Initialise max_depth field.
3909         (val_print_scalar_or_string_type_p): New function.
3910         (val_print): Check to see if the max depth has been reached.
3911         (val_print_check_max_depth): Define new function.
3912         (show_print_max_depth): New function.
3913         (_initialize_valprint): Add 'print max-depth' option.
3914         * valprint.h (struct value_print_options) <max_depth>: New field.
3915         (val_print_check_max_depth): Declare new function.
3916         * NEWS: Document new feature.
3917
3918 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * ada-lang.c (ada_language_defn): Initialise new field.
3921         * c-lang.c (c_is_string_type_p): New function.
3922         (c_language_defn): Initialise new field.
3923         (cplus_language_defn): Initialise new field.
3924         (asm_language_defn): Initialise new field.
3925         (minimal_language_defn): Initialise new field.
3926         * c-lang.h (c_is_string_type_p): Declare new function.
3927         * d-lang.c (d_language_defn): Initialise new field.
3928         * f-lang.c (f_is_string_type_p): New function.
3929         (f_language_defn): Initialise new field.
3930         * go-lang.c (go_is_string_type_p): New function.
3931         (go_language_defn): Initialise new field.
3932         * language.c (default_is_string_type_p): New function.
3933         (unknown_language_defn): Initialise new field.
3934         (auto_language_defn): Initialise new field.
3935         * language.h (struct language_defn) <la_is_string_type_p>: New
3936         member variable.
3937         (default_is_string_type_p): Declare new function.
3938         * m2-lang.c (m2_language_defn): Initialise new field.
3939         * objc-lang.c (objc_language_defn): Initialise new field.
3940         * opencl-lang.c (opencl_language_defn): Initialise new field.
3941         * p-lang.c (pascal_is_string_type_p): New function.
3942         (pascal_language_defn): Initialise new field.
3943         * rust-lang.c (rust_is_string_type_p): New function.
3944         (rust_language_defn): Initialise new field.
3945
3946 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3949         New field.
3950         * ada-lang.c (ada_language_defn): Initialise new field.
3951         * c-lang.c (c_language_defn): Likewise.
3952         (cplus_language_defn): Likewise.
3953         (asm_language_defn): Likewise.
3954         (minimal_language_defn): Likewise.
3955         * d-lang.c (d_language_defn): Likewise.
3956         * f-lang.c (f_language_defn): Likewise.
3957         * go-lang.c (go_language_defn): Likewise.
3958         * language.c (unknown_language_defn): Likewise.
3959         (auto_language_defn): Likewise.
3960         * m2-lang.c (m2_language_defn): Likewise.
3961         * objc-lang.c (objc_language_defn): Likewise.
3962         * opencl-lang.c (opencl_language_defn): Likewise.
3963         * p-lang.c (pascal_language_defn): Likewise.
3964         * rust-lang.c (rust_language_defn): Likewise.
3965
3966 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * ada-lang.c (ada_is_character_type): Change return type to bool.
3969         (ada_is_string_type): Likewise.
3970         * ada-lang.h (ada_is_character_type): Update declaration
3971         (ada_is_string_type): Likewise.
3972
3973 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3974
3975         Support style in 'frame|thread apply'
3976
3977         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3978         * record.c (record_start, record_stop): Update callers of
3979         execute_command_to_string with false.
3980         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3981         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3982         methods.
3983         (class string_file): New constructor with term_out parameter.
3984         Override methods term_out and can_emit_style_escape.  New member
3985         term_out.
3986         (class stdio_file): Override can_emit_style_escape.
3987         (class tee_file): Override term_out and can_emit_style_escape.
3988         * utils.h (can_emit_style_escape): Remove.
3989         * utils.c (can_emit_style_escape): Likewise.
3990         Update all callers of can_emit_style_escape (SOMESTREAM) to
3991         SOMESTREAM->can_emit_style_escape.
3992         * source-cache.c (source_cache::get_source_lines): Likewise.
3993         * stack.c (frame_apply_command_count): Call execute_command_to_string
3994         passing the term_out characteristic of the current gdb_stdout.
3995         * thread.c (thr_try_catch_cmd): Likewise.
3996         * top.c (execute_command_to_string): pass term_out parameter
3997         to construct the string_file for the command output.
3998         * ui-file.c (term_cli_styling): New function (most code moved
3999         from utils.c can_emit_style_escape).
4000         (string_file::string_file, string_file::can_emit_style_escape,
4001         stdio_file::can_emit_style_escape, tee_file::term_out,
4002         tee_file::can_emit_style_escape): New functions.
4003
4004 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4005
4006         * NEWS: Mention the new set|show may-call-functions.
4007         * infcall.c (may_call_functions_p): New variable.
4008         (show_may_call_functions_p): New function.
4009         (call_function_by_hand_dummy): Throws an error if not
4010         may-call-functions.
4011         (_initialize_infcall): Call add_setshow_boolean_cmd for
4012         may-call-functions.
4013
4014 2019-04-25  Keith Seitz  <keiths@redhat.com>
4015
4016         PR c++/24367
4017         * cp-support.c (inspect_type): Don't attempt substitutions
4018         of symbol with the same name.
4019
4020 2019-04-25  Tom Tromey  <tromey@adacore.com>
4021
4022         PR gdb/24475:
4023         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4024         static.
4025
4026 2019-04-25  Tom Tromey  <tromey@adacore.com>
4027
4028         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4029         rvalue reference.
4030         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4031         (gdb_xml_parser::parse): Use std::move.
4032         * python/python-internal.h (gdbpy_convert_exception): Take a const
4033         reference.
4034         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4035         std::move.
4036         * python/py-utils.c (gdbpy_convert_exception): Take a const
4037         reference.
4038         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4039         Use std::move.
4040         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4041         Use std::move.
4042         * mi/mi-main.c (mi_print_exception): Take a const reference.
4043         * main.c (handle_command_errors): Take a const reference.
4044         * linespec.c (parse_linespec): Use std::move.
4045         * infcall.c (run_inferior_call): Use std::move.
4046         (call_function_by_hand_dummy): Use std::move.
4047         * exec.c (try_open_exec_file): Use std::move.
4048         * exceptions.h (exception_print, exception_fprintf)
4049         (exception_print_same): Update.
4050         * exceptions.c (print_exception, exception_print)
4051         (exception_fprintf, exception_print_same): Change parameters to
4052         const reference.
4053         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4054         * common/new-op.c: Use std::move.
4055         * common/common-exceptions.h (struct gdb_exception): Add move
4056         constructor.
4057         (struct gdb_exception_error, struct gdb_exception_quit, struct
4058         gdb_quit_bad_alloc): Change constructor to move constructor.
4059         (throw_exception): Change parameter to rvalue reference.
4060         * common/common-exceptions.c (throw_exception): Take rvalue
4061         reference.
4062         * cli/cli-interp.c (safe_execute_command): Use std::move.
4063         * breakpoint.c (insert_bp_location, location_to_sals): Use
4064         std::move.
4065
4066 2019-04-25  Tom Tromey  <tromey@adacore.com>
4067
4068         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4069         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4070         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4071         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4072         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4073         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4074         guile/scm-value.c: Use unpack.
4075         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4076         gdbscm_gdb_exception.
4077         (gdbscm_throw_gdb_exception): Likewise.
4078         (struct gdbscm_gdb_exception): New.
4079         (unpack): New function.
4080         (gdbscm_wrap): Use unpack.
4081
4082 2019-04-25  Tom Tromey  <tromey@adacore.com>
4083
4084         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4085         (gdb_rl_callback_handler): Use std::move.
4086         * common/common-exceptions.h (struct gdb_exception): Add move
4087         assignment operator.
4088         (throw_exception_sjlj): Change "exception" to const reference.
4089         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4090         (throw_exception_sjlj): Change "exception" to const reference.
4091
4092 2019-04-25  Tom Tromey  <tromey@adacore.com>
4093
4094         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4095         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4096         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4097         Update.
4098         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4099         Update.
4100         * mi/mi-interp.c (mi_interp::exec): Update.
4101         * linespec.c (parse_linespec): Update.
4102         * infcall.c (run_inferior_call): Update.
4103         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4104         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4105         (gdbscm_lookup_global_symbol): Update.
4106         * guile/scm-param.c (gdbscm_parameter_value): Update.
4107         * guile/scm-frame.c (gdbscm_frame_read_register)
4108         (gdbscm_frame_read_var): Update.
4109         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4110         * exec.c (try_open_exec_file): Update.
4111         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4112         (gdb_rl_callback_handler): Update.
4113         * common/common-exceptions.h (exception_none): Don't declare.
4114         * common/common-exceptions.c (exception_none): Don't define.
4115         (struct catcher) <exception>: Update.
4116         * cli/cli-interp.c (safe_execute_command): Update.
4117         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4118
4119 2019-04-25  Ali Tamur  <tamur@google.com>
4120
4121         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4122         (read_attribute_value): Likewise.
4123         (dwarf2_read_addr_index): Update comment.
4124         (read_str_index): Add DW_FORM_strx.
4125         (dwarf2_string_attr): Likewise.
4126         (dwarf2_const_value_attr): Likewise.
4127         (dump_die_shallow): Likewise.
4128         (dwarf2_fetch_constant_bytes): Likewise.
4129         (skip_form_bytes): Likewise.
4130         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4131
4132 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4133
4134         PR corefiles/11608
4135         PR corefiles/18187
4136         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4137         OFFSET.  Verify if current mapping contains an ELF header.
4138         (linux_find_memory_regions_full): Adjust call to
4139         dump_mapping_p.
4140
4141 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4142             Kang Li <kanglictf@gmail.com>
4143
4144         PR gdb/21600
4145
4146         * dwarf2-frame.c (read_initial_length): Be consistent about using
4147         unsigned representation of length.
4148         (decode_frame_entry_1): Likewise.  Check for wraparound of
4149         end pointer as well as buffer overflow.
4150
4151 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4152
4153         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4154         "vq".
4155
4156 2019-04-24  Tom Tromey  <tromey@adacore.com>
4157
4158         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4159
4160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4161
4162         * s12z-tdep.c (s12z_unwind_pc): Delete.
4163         (s12z_unwind_sp): Delete.
4164         (s12z_gdbarch_init): Don't register deleted functions with
4165         gdbarch.
4166
4167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * rl78-tdep.c (rl78_unwind_sp): Delete.
4170         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4171
4172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4175         (xstormy16_unwind_pc): Delete.
4176         (xstormy16_dummy_id): Delete.
4177         (xstormy16_gdbarch_init): Don't register deleted functions with
4178         gdbarch.
4179
4180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4181
4182         * vax-tdep.c (vax_unwind_pc): Delete.
4183         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4184
4185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * v850-tdep.c (v850_unwind_sp): Delete.
4188         (v850_unwind_pc): Delete.
4189         (v850_dummy_id): Delete.
4190         (v850_gdbarch_init): Don't register deleted functions with
4191         gdbarch.
4192
4193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4196         (tilegx_unwind_pc): Delete.
4197         (tilegx_unwind_dummy_id): Delete.
4198         (tilegx_gdbarch_init): Don't register deleted functions with
4199         gdbarch.
4200
4201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4204         (tic6x_dummy_id): Delete.
4205         (tic6x_gdbarch_init): Don't register deleted functions with
4206         gdbarch.
4207
4208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * sparc-tdep.c (sparc_unwind_pc): Delete.
4211         (sparc32_gdbarch_init): Don't register deleted function with
4212         gdbarch.
4213
4214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * sh-tdep.c (sh_unwind_sp): Delete.
4217         (sh_unwind_pc): Delete.
4218         (sh_dummy_id): Delete.
4219         (sh_gdbarch_init): Don't register deleted functions with
4220         gdbarch.
4221
4222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * score-tdep.c (score_unwind_sp): Delete.
4225         (score_unwind_pc): Delete.
4226         (score_dummy_id): Delete.
4227         (score_gdbarch_init): Don't register deleted functions with
4228         gdbarch.
4229
4230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * rx-tdep.c (rx_unwind_pc): Delete.
4233         (rx_unwind_sp): Delete.
4234         (rx_dummy_id): Delete.
4235         (rx_gdbarch_init): Don't register deleted functions with
4236         gdbarch.  Update comment.
4237
4238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4241         (rs6000_dummy_id): Delete.
4242         (rs6000_gdbarch_init): Don't register deleted functions with
4243         gdbarch.
4244
4245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * or1k-tdep.c (or1k_dummy_id): Delete.
4248         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4249
4250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * nios2-tdep.c (nios2_dummy_id): Delete.
4253         (nios2_unwind_sp): Delete.
4254         (nios2_gdbarch_init): Don't register deleted functions with
4255         gdbarch.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * nds32-tdep.c (nds32_dummy_id): Delete.
4260         (nds32_unwind_pc): Delete.
4261         (nds32_unwind_sp): Delete.
4262         (nds32_gdbarch_init): Don't register deleted functions with
4263         gdbarch.
4264
4265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * msp430-tdep.c (msp430_unwind_pc): Delete.
4268         (msp430_unwind_sp): Delete.
4269         (msp430_dummy_id): Delete.
4270         (msp430_gdbarch_init): Don't register deleted functions with
4271         gdbarch.
4272
4273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4274
4275         * moxie-tdep.c (moxie_unwind_sp): Delete.
4276         (moxie_unwind_pc): Delete.
4277         (moxie_dummy_id): Delete.
4278         (moxie_gdbarch_init): Don't register deleted functions with
4279         gdbarch.
4280
4281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4284         (mn10300_unwind_pc): Delete.
4285         (mn10300_unwind_sp): Delete.
4286         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4287         mn10300_unwind_sp.
4288         (mn10300_frame_unwind_init): Don't register deleted functions with
4289         gdbarch.
4290
4291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * mep-tdep.c (mep_unwind_pc): Delete.
4294         (mep_unwind_sp): Delete.
4295         (mep_dummy_id): Delete.
4296         (mep_gdbarch_init): Don't register deleted functions with
4297         gdbarch.
4298
4299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4300
4301         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4302         (m68hc11_unwind_sp): Delete.
4303         (m68hc11_gdbarch_init): Don't register deleted functions with
4304         gdbarch.
4305
4306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * m32r-tdep.c (m32r_unwind_sp): Delete.
4309         (m32r_unwind_pc): Delete.
4310         (m32r_dummy_id): Delete.
4311         (m32r_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * m32c-tdep.c (m32c_unwind_pc): Delete.
4317         (m32c_unwind_sp): Delete.
4318         (m32c_dummy_id): Delete.
4319         (m32c_gdbarch_init): Don't register deleted functions with
4320         gdbarch.
4321
4322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4325         (lm32_unwind_pc): Delete.
4326         (lm32_dummy_id): Delete.
4327         (lm32_gdbarch_init): Don't register deleted functions with
4328         gdbarch.
4329
4330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4333         (iq2000_unwind_pc): Delete.
4334         (iq2000_dummy_id): Delete.
4335         (iq2000_gdbarch_init): Don't register deleted functions with
4336         gdbarch.
4337
4338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * nds32-tdep.c (nds32_type_align): Delete.
4341         (nds32_push_dummy_call): Use type_align instead.
4342
4343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * arm-tdep.c (arm_type_align): Only handle vector override case.
4346         (arm_push_dummy_call): Use type_align.
4347         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4348
4349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4352         case.
4353         (pass_on_stack): Use type_align.
4354         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4355         function.
4356
4357 2019-04-23  Tom Tromey  <tromey@adacore.com>
4358
4359         * dwarf2read.c (line_header::file_name_at): Remove unused
4360         overload.
4361
4362 2019-04-23  Tom de Vries  <tdevries@suse.de>
4363
4364         PR gdb/24438
4365         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4366         invocation.
4367
4368
4369 2019-03-27  Ali Tamur  <tamur@google.com>
4370
4371         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4372         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4373         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4374         (dwarf_expr_context::get_addr_index): Likewise
4375         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4376         (symbol_needs_eval_context::get_addr_index): Likewise
4377         (disassemble_dwarf_expression): Add DW_OP_addrx
4378         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4379         (read_cutu_die_from_dwo): Update comment
4380         (skip_one_die): Add DW_FORM_addrx
4381         (read_attribute_value): Likewise
4382         (var_decode_location): Add DW_OP_addrx
4383         (dwarf2_const_value_attr): Add DW_FORM_addrx
4384         (dump_die_shallow): Likewise
4385         (dwarf2_fetch_constant_bytes): Likewise
4386         (decode_locdesc): Add DW_OP_addrx
4387         (skip_form_bytes): Add DW_FORM_addrx
4388
4389 2019-04-22  Ali Tamur  <tamur@google.com>
4390
4391         * MAINTAINERS (Write After Approval): Add self.
4392
4393 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4394
4395         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4396         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4397         (open_symbol_file_object): Likewise.
4398         (svr4_default_sos): Add info parameter.
4399         (svr4_read_so_list): Likewise.
4400         (svr4_current_sos_direct): Adjust functions calls to pass down
4401         info.
4402         (svr4_current_sos_1): Add info parameter.
4403         (svr4_current_sos): Call get_svr4_info, pass info down to
4404         svr4_current_sos_1.
4405         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4406         get_svr4_info.
4407         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4408         get_svr4_info.
4409         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4410         to get_svr4_info.
4411         (probes_table_remove_objfile_probes): Likewise.
4412         (register_solib_event_probe): Add info parameter.
4413         (solist_update_incremental): Pass info parameter down to
4414         svr4_read_so_list.
4415         (disable_probes_interface): Add info parameter.
4416         (svr4_handle_solib_event): Pass current_program_space to
4417         get_svr4_info.  Adjust disable_probes_interface cleanup.
4418         (svr4_create_probe_breakpoints): Add info parameter, pass it
4419         down to register_solib_event_probe.
4420         (svr4_create_solib_event_breakpoints): Add info parameter,
4421         pass it down to svr4_create_probe_breakpoints.
4422         (enable_break): Pass info down to
4423         svr4_create_solib_event_breakpoints.
4424         (svr4_solib_create_inferior_hook): Pass current_program_space to
4425         get_svr4_info.
4426         (svr4_clear_solib): Likewise.
4427
4428 2019-04-22  Pedro Alves  <palves@redhat.com>
4429
4430         * solib-svr4.c (svr4_free_objfile_observer): New.
4431         (probe_and_action::objfile): New field.
4432         (probes_table_htab_remove_objfile_probes)
4433         (probes_table_remove_objfile_probes): New functions.
4434         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4435         in the new probe_and_action.  Don't store the probe in 'lookup'.
4436         (svr4_create_probe_breakpoints): Pass objfile to
4437         register_solib_event_probe.
4438         (_initialize_svr4_solib): Register a free_objfile observer.
4439
4440 2019-04-19  Tom Tromey  <tom@tromey.com>
4441
4442         * common/queue.h: Remove.
4443
4444 2019-04-19  Tom Tromey  <tom@tromey.com>
4445
4446         * event-loop.c: Don't include "common/queue.h".
4447
4448 2019-04-19  Tom Tromey  <tom@tromey.com>
4449
4450         * remote.c (remote_target): Use delete.
4451         * remote-notif.h: Include <list>, not "common/queue.h".
4452         (notif_client_p): Remove typedef.
4453         (remote_notif_state): Add constructor, destructor, initializer.
4454         <notif_queue>: Now a std::list.
4455         (remote_notif_state_xfree): Don't declare.
4456         * remote-notif.c (remote_notif_process, handle_notification)
4457         (remote_notif_state_allocate): Update.
4458         (~remote_notif_state): Rename from remote_notif_state_xfree.
4459
4460 2019-04-19  Tom Tromey  <tom@tromey.com>
4461
4462         * symfile.c (reread_symbols): Update.
4463         * objfiles.c (objfile_register_static_link)
4464         (objfile_lookup_static_link): Update
4465         (~objfile) Don't delete static_links.
4466         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4467
4468 2019-04-19  Tom Tromey  <tom@tromey.com>
4469
4470         * type-stack.h (struct type_stack) <insert>: Constify string.
4471         * type-stack.c (type_stack::insert): Constify string.
4472         * gdbtypes.h (lookup_template_type): Update.
4473         (address_space_name_to_int): Update.
4474         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4475         const.
4476         (lookup_template_type): Make name const.
4477         * c-exp.y: Update rules.
4478         (lex_one_token, classify_name, classify_inner_name)
4479         (c_print_token): Update.
4480         * p-exp.y: Update rules.
4481         (yylex): Update.
4482         * f-exp.y: Update rules.
4483         (yylex): Update.
4484         * d-exp.y: Update rules.
4485         (lex_one_token, classify_name, classify_inner_name): Update.
4486         * parse.c (write_dollar_variable, copy_name): Return std::string.
4487         * parser-defs.h (copy_name): Change return type.
4488         * m2-exp.y: Update rules.
4489         (yylex): Update.
4490         * go-exp.y (lex_one_token): Update.
4491         Update rules.
4492         (classify_unsafe_function, classify_packaged_name)
4493         (classify_name, yylex): Update.
4494
4495 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4496
4497         * configure.ac: add --enable-source-highlight switch.
4498         * configure: Regenerate.
4499         * top.c (print_gdb_version): plumb --enable-source-highlight
4500         status to "show configuration".
4501
4502 2019-04-19  Tom Tromey  <tromey@adacore.com>
4503
4504         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4505         Check ADA_TYPE_P.
4506         (empty_record, ada_template_to_fixed_record_type_1)
4507         (template_to_static_fixed_type)
4508         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4509         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4510         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4511         macros.
4512
4513 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4514
4515         PR symtab/24423:
4516         * source.c (print_source_lines_base): Advance "iter" when a
4517         control character is seen.
4518
4519 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520
4521         * inferior.h (struct infcall_suspend_state_deleter):
4522         Catch exception in destructor to avoid crash.
4523
4524 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4525
4526         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4527         close to the add_com "shell".
4528
4529 2019-04-18  Tom Tromey  <tromey@adacore.com>
4530
4531         * process-stratum-target.h (class process_stratum_target)
4532         <stratum>: Add "final".
4533
4534 2019-04-17  Tom Tromey  <tromey@adacore.com>
4535
4536         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4537         against nullptr before use.
4538
4539 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4540
4541         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4542
4543 2019-04-17  Jim Wilson  <jimw@sifive.com>
4544             Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4547         code read might fail, assume 4-byte breakpoint in that case.
4548
4549 2019-04-15  Leszek Swirski  <leszeks@google.com>
4550
4551         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4552         rather than a hand-rolled POD check when checking for forced MEMORY
4553         classification.
4554
4555 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4556
4557         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4558         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4559         function.
4560         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4561         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4562         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4563         declaration.
4564
4565 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4566
4567         * aarch64-linux-nat.c
4568         (aarch64_linux_nat_target::thread_architecture): Add override.
4569         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4570         each VQ.
4571
4572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4573
4574         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4575
4576 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4577
4578         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4579         target types of size 96-bits, add some additional comments, and
4580         check that the builtin type we found was the correct size.
4581
4582 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4583
4584         * utils.c (prompt_for_continue): Don't restore the styling at the
4585         end, as applied_style has the wrong value.  This fixes styling in
4586         long lists of file names that are interrupted by the "Continue?"
4587         prompt.
4588
4589 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4592         * c-lang.c (c_language_defn): Likewise.
4593         (cplus_language_defn): Likewise.
4594         (asm_language_defn): Likewise.
4595         (minimal_language_defn): Likewise.
4596         * d-lang.c (d_language_defn): Likewise.
4597         * f-lang.c (f_language_defn): Likewise.
4598         * go-lang.c (go_language_defn): Likewise.
4599         * language.c (unknown_language_defn): Likewise.
4600         (auto_language_defn): Likewise.
4601         * language.h (struct language_defn): Remove la_magic field.
4602         (LANG_MAGIC): Delete.
4603         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4604         * objc-lang.c (objc_language_defn): Likewise.
4605         * opencl-lang.c (opencl_language_defn): Likewise.
4606         * p-lang.c (pascal_language_defn): Likewise.
4607         * rust-lang.c (rust_language_defn): Likewise.
4608
4609 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * riscv-tdep.c (riscv_type_align): New function.
4612         (riscv_type_alignment): Delete.
4613         (riscv_arg_location): Use 'type_align'.
4614         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4615
4616 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * gdbtypes.c (type_align): A struct with no non-static fields also
4619         has alignment of 1.
4620
4621 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4624         component to 0.
4625         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4626         member.
4627         (riscv_struct_info::analyse): New implementation using new
4628         analyse_inner member function.
4629         (riscv_struct_info::field_offset): New member function.
4630         (riscv_struct_info::m_offsets): New member variable.
4631         (riscv_struct_info::analyse_inner): New private member function,
4632         takes the old implementation of riscv_struct_info::analyse but
4633         extended to track field offsets.
4634         (riscv_call_arg_struct): Update the struct folding special cases
4635         to handle cases where empty C++ structs, which are non-zero
4636         length, are found.
4637         (riscv_arg_location): Initialise the length of each location, a
4638         non-zero length now indicates the location is in use.
4639         (riscv_push_dummy_call): Allow for the first location having a
4640         non-zero offset when setting up arguments.
4641         (riscv_return_value): Likewise, but for return values.
4642
4643 2019-04-11  Tom Tromey  <tromey@adacore.com>
4644
4645         * utils.c (internal_vproblem): Make "msg" const.
4646
4647 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4648
4649         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4650         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4651         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4652         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4653
4654 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4655
4656         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4657         function.
4658         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4659         of amd64_collect_native_gregset.
4660         (amd64_linux_nat_target::store_registers): Likewise.
4661
4662 2019-04-10  Tom Tromey  <tom@tromey.com>
4663
4664         * symtab.c (lookup_global_symbol_from_objfile)
4665         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4666         * objfiles.h (class separate_debug_iterator): New.
4667         (class separate_debug_range): New.
4668         (struct objfile) <separate_debug_objfiles>: New method.
4669         (objfile_separate_debug_iterate): Don't declare.
4670         * objfiles.c (separate_debug_iterator::operator++): Rename from
4671         objfile_separate_debug_iterate.
4672         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4673         iterator.
4674         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4675         iterator.
4676
4677 2019-04-10  Tom Tromey  <tom@tromey.com>
4678
4679         * symfile.c (reread_symbols): Remove old comment.
4680         * objfiles.c (free_all_objfiles): Fix a typo.
4681
4682 2019-04-10  Tom Tromey  <tom@tromey.com>
4683
4684         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4685         * minsyms.c (lookup_minimal_symbol): Use foreach.
4686         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4687         (lookup_minimal_symbol_solib_trampoline): Likewise.
4688         * symfile.c (reread_symbols): Use foreach.
4689
4690 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4691             Tom Tromey  <tromey@adacore.com>
4692
4693         PR rust/24414:
4694         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4695         (rust_lex_int_test): Change "value" to be LONGEST.
4696         (rust_lex_tests): Add test for long integer literal.
4697
4698 2019-04-09  Tom Tromey  <tromey@adacore.com>
4699
4700         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4701         to bool.
4702         (extended_remote_target::attach): Update.
4703         (remote_target::remote_notice_new_inferior): Update.
4704         (remote_target::add_current_inferior_and_thread): Update.
4705         * inferior.c (exit_inferior_1): Use "false".
4706         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4707
4708 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4709
4710         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4711         the "start" command.
4712
4713 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4714
4715         * python/py-inferior.c (infpy_thread_from_thread_handle):
4716         Adjust comments to reflect renaming of thread_from_thread_handle
4717         to thread_from_handle.  Adjust keywords.  Fix type error message.
4718         (inferior_object_methods): Add thread_from_handle.  Retain
4719         thread_from_thread_handle, but mark it as deprecated.
4720
4721 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4722
4723         * gdbthread.h (find_thread_by_handle): Revise declaration.
4724         * thread.c (find_thread_by_handle): Likewise.  Adjust
4725         implementation too.
4726         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4727         support for buffer objects as handles.
4728
4729 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4730
4731         * python/py-infthread.c (thpy_thread_handle): New function.
4732         (thread_object_methods): Register thpy_thread_handle.
4733
4734 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4735
4736         * gdbthread.h (thread_to_thread_handle): Declare.
4737         * thread.c (gdbtypes.h): Include.
4738         (thread_to_thread_handle): New function.
4739
4740         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4741         (target_thread_info_to_thread_handle): Declare.
4742         * target.c (target_thread_info_to_thread_handle): New function.
4743         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4744         * target-delegates.c: Regenerate.
4745
4746         * linux-thread-db.c (class thread_db_target): Add method
4747         thread_info_to_thread_handle.
4748         (thread_db_target::thread_info_to_thread_handle): Define.
4749         * remote.c (class remote_target): Add new method
4750         thread_info_to_thread_handle.
4751         (remote_target::thread_info_to_thread_handle): Define.
4752
4753 2019-04-08  Pedro Alves  <palves@redhat.com>
4754
4755         * common/common-exceptions.c (throw_exception): Don't create
4756         named object to throw; throw directly.
4757         (throw_it): Likewise.  Don't initialize gdb_exception::message
4758         here, with new; pass FMT and AP to the ctor instead.
4759         * common/common-exceptions.h: Include <string>.
4760         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4761         const char *, va_list)): New ctor.  Use std::make_shared.
4762         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4763         errors)): Delete.
4764         (gdb_exception_error::gdb_exception_error(enum errors, const char
4765         *, va_list)): New.
4766         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4767         Add assertion.
4768         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4769         errors)): Delete.
4770         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4771         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4772         Add assertion.
4773
4774 2019-04-08  Tom Tromey  <tom@tromey.com>
4775
4776         * valops.c (value_rtti_indirect_type): Replace throw_exception
4777         with throw.
4778         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4779         with throw.
4780         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4781         throw.
4782         * target.c (target_translate_tls_address): Replace throw_exception
4783         with throw.
4784         * stack.c (frame_apply_command_count): Replace throw_exception
4785         with throw.
4786         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4787         throw.
4788         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4789         with throw.
4790         * rs6000-tdep.c (rs6000_frame_cache)
4791         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4792         * remote.c: Replace throw_exception with throw.
4793         * record-full.c (record_full_message, record_full_wait_1)
4794         (record_full_restore): Replace throw_exception with throw.
4795         * record-btrace.c:
4796         (get_thread_current_frame_id, record_btrace_start_replaying)
4797         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4798         (cmd_record_btrace_start): Replace throw_exception with throw.
4799         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4800         throw.
4801         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4802         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4803         * linespec.c:
4804         (find_linespec_symbols): Replace throw_exception with throw.
4805         * infrun.c (displaced_step_prepare, resume): Replace
4806         throw_exception with throw.
4807         * infcmd.c (post_create_inferior): Replace throw_exception with
4808         throw.
4809         * inf-loop.c (inferior_event_handler): Replace throw_exception
4810         with throw.
4811         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4812         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4813         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4814         (get_prev_frame_always, get_frame_pc_if_available)
4815         (get_frame_address_in_block_if_available, get_frame_language):
4816         Replace throw_exception with throw.
4817         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4818         throw_exception with throw.
4819         * eval.c (fetch_subexp_value, evaluate_var_value)
4820         (evaluate_funcall, evaluate_subexp_standard): Replace
4821         throw_exception with throw.
4822         * dwarf2loc.c (call_site_find_chain)
4823         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4824         Replace throw_exception with throw.
4825         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4826         with throw.
4827         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4828         throw.
4829         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4830         * completer.c (complete_line_internal): Replace throw_exception
4831         with throw.
4832         * compile/compile-object-run.c (compile_object_run): Replace
4833         throw_exception with throw.
4834         * cli/cli-script.c (process_next_line): Replace throw_exception
4835         with throw.
4836         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4837         (btrace_enable, btrace_maint_update_pt_packets): Replace
4838         throw_exception with throw.
4839         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4840         throw_exception with throw.
4841         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4842         throw_exception with throw.
4843         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4844         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4845         * aarch64-tdep.c (aarch64_make_prologue_cache)
4846         (aarch64_make_stub_cache): Replace throw_exception with throw.
4847
4848 2019-04-08  Tom Tromey  <tom@tromey.com>
4849
4850         * common/common-exceptions.c (throw_exception): Rename from
4851         throw_exception_cxx.  Remove old copy.  Make argument const.
4852         (throw_it): Create and throw exception objects directly.
4853         * common/common-exceptions.h (throw_exception): Make argument
4854         const.
4855         (struct gdb_exception_error): Add constructor.
4856         (struct gdb_exception_quit): Add constructor.
4857
4858 2019-04-08  Tom Tromey  <tom@tromey.com>
4859
4860         * common/common-exceptions.h (exception_rethrow): Don't declare.
4861         (TRY_SJLJ): Update comment.
4862         (TRY, CATCH, END_CATCH): Remove.
4863         * common/common-exceptions.c (exception_rethrow): Remove.
4864
4865 2019-04-08  Tom Tromey  <tom@tromey.com>
4866
4867         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4868         Remove.
4869         (gdb_exception_error): Rename from
4870         gdb_exception_RETURN_MASK_ERROR.
4871         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4872         (gdb_quit_bad_alloc): Update.
4873         * aarch64-tdep.c: Update.
4874         * ada-lang.c: Update.
4875         * ada-typeprint.c: Update.
4876         * ada-valprint.c: Update.
4877         * amd64-tdep.c: Update.
4878         * arch-utils.c: Update.
4879         * break-catch-throw.c: Update.
4880         * breakpoint.c: Update.
4881         * btrace.c: Update.
4882         * c-varobj.c: Update.
4883         * cli/cli-cmds.c: Update.
4884         * cli/cli-interp.c: Update.
4885         * cli/cli-script.c: Update.
4886         * common/common-exceptions.c: Update.
4887         * common/new-op.c: Update.
4888         * common/selftest.c: Update.
4889         * compile/compile-c-symbols.c: Update.
4890         * compile/compile-cplus-symbols.c: Update.
4891         * compile/compile-object-load.c: Update.
4892         * compile/compile-object-run.c: Update.
4893         * completer.c: Update.
4894         * corelow.c: Update.
4895         * cp-abi.c: Update.
4896         * cp-support.c: Update.
4897         * cp-valprint.c: Update.
4898         * darwin-nat.c: Update.
4899         * disasm-selftests.c: Update.
4900         * dtrace-probe.c: Update.
4901         * dwarf-index-cache.c: Update.
4902         * dwarf-index-write.c: Update.
4903         * dwarf2-frame-tailcall.c: Update.
4904         * dwarf2-frame.c: Update.
4905         * dwarf2loc.c: Update.
4906         * dwarf2read.c: Update.
4907         * eval.c: Update.
4908         * event-loop.c: Update.
4909         * event-top.c: Update.
4910         * exec.c: Update.
4911         * f-valprint.c: Update.
4912         * fbsd-tdep.c: Update.
4913         * frame-unwind.c: Update.
4914         * frame.c: Update.
4915         * gdbtypes.c: Update.
4916         * gnu-v3-abi.c: Update.
4917         * guile/guile-internal.h: Update.
4918         * guile/scm-block.c: Update.
4919         * guile/scm-breakpoint.c: Update.
4920         * guile/scm-cmd.c: Update.
4921         * guile/scm-disasm.c: Update.
4922         * guile/scm-frame.c: Update.
4923         * guile/scm-lazy-string.c: Update.
4924         * guile/scm-math.c: Update.
4925         * guile/scm-param.c: Update.
4926         * guile/scm-ports.c: Update.
4927         * guile/scm-pretty-print.c: Update.
4928         * guile/scm-symbol.c: Update.
4929         * guile/scm-symtab.c: Update.
4930         * guile/scm-type.c: Update.
4931         * guile/scm-value.c: Update.
4932         * i386-linux-tdep.c: Update.
4933         * i386-tdep.c: Update.
4934         * inf-loop.c: Update.
4935         * infcall.c: Update.
4936         * infcmd.c: Update.
4937         * infrun.c: Update.
4938         * jit.c: Update.
4939         * language.c: Update.
4940         * linespec.c: Update.
4941         * linux-fork.c: Update.
4942         * linux-nat.c: Update.
4943         * linux-tdep.c: Update.
4944         * linux-thread-db.c: Update.
4945         * main.c: Update.
4946         * mi/mi-cmd-break.c: Update.
4947         * mi/mi-cmd-stack.c: Update.
4948         * mi/mi-interp.c: Update.
4949         * mi/mi-main.c: Update.
4950         * objc-lang.c: Update.
4951         * p-valprint.c: Update.
4952         * parse.c: Update.
4953         * ppc-linux-tdep.c: Update.
4954         * printcmd.c: Update.
4955         * python/py-arch.c: Update.
4956         * python/py-breakpoint.c: Update.
4957         * python/py-cmd.c: Update.
4958         * python/py-finishbreakpoint.c: Update.
4959         * python/py-frame.c: Update.
4960         * python/py-framefilter.c: Update.
4961         * python/py-gdb-readline.c: Update.
4962         * python/py-inferior.c: Update.
4963         * python/py-infthread.c: Update.
4964         * python/py-lazy-string.c: Update.
4965         * python/py-linetable.c: Update.
4966         * python/py-objfile.c: Update.
4967         * python/py-param.c: Update.
4968         * python/py-prettyprint.c: Update.
4969         * python/py-progspace.c: Update.
4970         * python/py-record-btrace.c: Update.
4971         * python/py-record.c: Update.
4972         * python/py-symbol.c: Update.
4973         * python/py-type.c: Update.
4974         * python/py-unwind.c: Update.
4975         * python/py-utils.c: Update.
4976         * python/py-value.c: Update.
4977         * python/python.c: Update.
4978         * record-btrace.c: Update.
4979         * record-full.c: Update.
4980         * remote-fileio.c: Update.
4981         * remote.c: Update.
4982         * riscv-tdep.c: Update.
4983         * rs6000-aix-tdep.c: Update.
4984         * rs6000-tdep.c: Update.
4985         * rust-exp.y: Update.
4986         * rust-lang.c: Update.
4987         * s390-tdep.c: Update.
4988         * selftest-arch.c: Update.
4989         * solib-dsbt.c: Update.
4990         * solib-frv.c: Update.
4991         * solib-spu.c: Update.
4992         * solib-svr4.c: Update.
4993         * solib.c: Update.
4994         * sparc64-linux-tdep.c: Update.
4995         * stack.c: Update.
4996         * symfile-mem.c: Update.
4997         * symmisc.c: Update.
4998         * target.c: Update.
4999         * thread.c: Update.
5000         * top.c: Update.
5001         * tracefile-tfile.c: Update.
5002         * tui/tui.c: Update.
5003         * typeprint.c: Update.
5004         * unittests/cli-utils-selftests.c: Update.
5005         * unittests/parse-connection-spec-selftests.c: Update.
5006         * valops.c: Update.
5007         * valprint.c: Update.
5008         * value.c: Update.
5009         * varobj.c: Update.
5010         * windows-nat.c: Update.
5011         * x86-linux-nat.c: Update.
5012         * xml-support.c: Update.
5013
5014 2019-04-08  Tom Tromey  <tom@tromey.com>
5015
5016         * xml-support.c: Use C++ exception handling.
5017         * x86-linux-nat.c: Use C++ exception handling.
5018         * windows-nat.c: Use C++ exception handling.
5019         * varobj.c: Use C++ exception handling.
5020         * value.c: Use C++ exception handling.
5021         * valprint.c: Use C++ exception handling.
5022         * valops.c: Use C++ exception handling.
5023         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5024         handling.
5025         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5026         * typeprint.c: Use C++ exception handling.
5027         * tui/tui.c: Use C++ exception handling.
5028         * tracefile-tfile.c: Use C++ exception handling.
5029         * top.c: Use C++ exception handling.
5030         * thread.c: Use C++ exception handling.
5031         * target.c: Use C++ exception handling.
5032         * symmisc.c: Use C++ exception handling.
5033         * symfile-mem.c: Use C++ exception handling.
5034         * stack.c: Use C++ exception handling.
5035         * sparc64-linux-tdep.c: Use C++ exception handling.
5036         * solib.c: Use C++ exception handling.
5037         * solib-svr4.c: Use C++ exception handling.
5038         * solib-spu.c: Use C++ exception handling.
5039         * solib-frv.c: Use C++ exception handling.
5040         * solib-dsbt.c: Use C++ exception handling.
5041         * selftest-arch.c: Use C++ exception handling.
5042         * s390-tdep.c: Use C++ exception handling.
5043         * rust-lang.c: Use C++ exception handling.
5044         * rust-exp.y: Use C++ exception handling.
5045         * rs6000-tdep.c: Use C++ exception handling.
5046         * rs6000-aix-tdep.c: Use C++ exception handling.
5047         * riscv-tdep.c: Use C++ exception handling.
5048         * remote.c: Use C++ exception handling.
5049         * remote-fileio.c: Use C++ exception handling.
5050         * record-full.c: Use C++ exception handling.
5051         * record-btrace.c: Use C++ exception handling.
5052         * python/python.c: Use C++ exception handling.
5053         * python/py-value.c: Use C++ exception handling.
5054         * python/py-utils.c: Use C++ exception handling.
5055         * python/py-unwind.c: Use C++ exception handling.
5056         * python/py-type.c: Use C++ exception handling.
5057         * python/py-symbol.c: Use C++ exception handling.
5058         * python/py-record.c: Use C++ exception handling.
5059         * python/py-record-btrace.c: Use C++ exception handling.
5060         * python/py-progspace.c: Use C++ exception handling.
5061         * python/py-prettyprint.c: Use C++ exception handling.
5062         * python/py-param.c: Use C++ exception handling.
5063         * python/py-objfile.c: Use C++ exception handling.
5064         * python/py-linetable.c: Use C++ exception handling.
5065         * python/py-lazy-string.c: Use C++ exception handling.
5066         * python/py-infthread.c: Use C++ exception handling.
5067         * python/py-inferior.c: Use C++ exception handling.
5068         * python/py-gdb-readline.c: Use C++ exception handling.
5069         * python/py-framefilter.c: Use C++ exception handling.
5070         * python/py-frame.c: Use C++ exception handling.
5071         * python/py-finishbreakpoint.c: Use C++ exception handling.
5072         * python/py-cmd.c: Use C++ exception handling.
5073         * python/py-breakpoint.c: Use C++ exception handling.
5074         * python/py-arch.c: Use C++ exception handling.
5075         * printcmd.c: Use C++ exception handling.
5076         * ppc-linux-tdep.c: Use C++ exception handling.
5077         * parse.c: Use C++ exception handling.
5078         * p-valprint.c: Use C++ exception handling.
5079         * objc-lang.c: Use C++ exception handling.
5080         * mi/mi-main.c: Use C++ exception handling.
5081         * mi/mi-interp.c: Use C++ exception handling.
5082         * mi/mi-cmd-stack.c: Use C++ exception handling.
5083         * mi/mi-cmd-break.c: Use C++ exception handling.
5084         * main.c: Use C++ exception handling.
5085         * linux-thread-db.c: Use C++ exception handling.
5086         * linux-tdep.c: Use C++ exception handling.
5087         * linux-nat.c: Use C++ exception handling.
5088         * linux-fork.c: Use C++ exception handling.
5089         * linespec.c: Use C++ exception handling.
5090         * language.c: Use C++ exception handling.
5091         * jit.c: Use C++ exception handling.
5092         * infrun.c: Use C++ exception handling.
5093         * infcmd.c: Use C++ exception handling.
5094         * infcall.c: Use C++ exception handling.
5095         * inf-loop.c: Use C++ exception handling.
5096         * i386-tdep.c: Use C++ exception handling.
5097         * i386-linux-tdep.c: Use C++ exception handling.
5098         * guile/scm-value.c: Use C++ exception handling.
5099         * guile/scm-type.c: Use C++ exception handling.
5100         * guile/scm-symtab.c: Use C++ exception handling.
5101         * guile/scm-symbol.c: Use C++ exception handling.
5102         * guile/scm-pretty-print.c: Use C++ exception handling.
5103         * guile/scm-ports.c: Use C++ exception handling.
5104         * guile/scm-param.c: Use C++ exception handling.
5105         * guile/scm-math.c: Use C++ exception handling.
5106         * guile/scm-lazy-string.c: Use C++ exception handling.
5107         * guile/scm-frame.c: Use C++ exception handling.
5108         * guile/scm-disasm.c: Use C++ exception handling.
5109         * guile/scm-cmd.c: Use C++ exception handling.
5110         * guile/scm-breakpoint.c: Use C++ exception handling.
5111         * guile/scm-block.c: Use C++ exception handling.
5112         * guile/guile-internal.h: Use C++ exception handling.
5113         * gnu-v3-abi.c: Use C++ exception handling.
5114         * gdbtypes.c: Use C++ exception handling.
5115         * frame.c: Use C++ exception handling.
5116         * frame-unwind.c: Use C++ exception handling.
5117         * fbsd-tdep.c: Use C++ exception handling.
5118         * f-valprint.c: Use C++ exception handling.
5119         * exec.c: Use C++ exception handling.
5120         * event-top.c: Use C++ exception handling.
5121         * event-loop.c: Use C++ exception handling.
5122         * eval.c: Use C++ exception handling.
5123         * dwarf2read.c: Use C++ exception handling.
5124         * dwarf2loc.c: Use C++ exception handling.
5125         * dwarf2-frame.c: Use C++ exception handling.
5126         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5127         * dwarf-index-write.c: Use C++ exception handling.
5128         * dwarf-index-cache.c: Use C++ exception handling.
5129         * dtrace-probe.c: Use C++ exception handling.
5130         * disasm-selftests.c: Use C++ exception handling.
5131         * darwin-nat.c: Use C++ exception handling.
5132         * cp-valprint.c: Use C++ exception handling.
5133         * cp-support.c: Use C++ exception handling.
5134         * cp-abi.c: Use C++ exception handling.
5135         * corelow.c: Use C++ exception handling.
5136         * completer.c: Use C++ exception handling.
5137         * compile/compile-object-run.c: Use C++ exception handling.
5138         * compile/compile-object-load.c: Use C++ exception handling.
5139         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5140         * compile/compile-c-symbols.c: Use C++ exception handling.
5141         * common/selftest.c: Use C++ exception handling.
5142         * common/new-op.c: Use C++ exception handling.
5143         * cli/cli-script.c: Use C++ exception handling.
5144         * cli/cli-interp.c: Use C++ exception handling.
5145         * cli/cli-cmds.c: Use C++ exception handling.
5146         * c-varobj.c: Use C++ exception handling.
5147         * btrace.c: Use C++ exception handling.
5148         * breakpoint.c: Use C++ exception handling.
5149         * break-catch-throw.c: Use C++ exception handling.
5150         * arch-utils.c: Use C++ exception handling.
5151         * amd64-tdep.c: Use C++ exception handling.
5152         * ada-valprint.c: Use C++ exception handling.
5153         * ada-typeprint.c: Use C++ exception handling.
5154         * ada-lang.c: Use C++ exception handling.
5155         * aarch64-tdep.c: Use C++ exception handling.
5156
5157 2019-04-08  Tom Tromey  <tom@tromey.com>
5158
5159         * xml-support.c (gdb_xml_parser::parse): Update.
5160         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5161         * value.c (show_convenience): Update.
5162         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5163         (test_parse_flags_qcs): Update.
5164         * thread.c (thr_try_catch_cmd): Update.
5165         * target.c (target_translate_tls_address): Update.
5166         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5167         (info_frame_command_core, frame_apply_command_count): Update.
5168         * rust-exp.y (rust_lex_exception_test): Update.
5169         * riscv-tdep.c (riscv_print_one_register_info): Update.
5170         * remote.c (remote_target::enable_btrace): Update.
5171         * record-btrace.c (record_btrace_enable_warn): Update.
5172         * python/py-utils.c (gdbpy_convert_exception): Update.
5173         * printcmd.c (do_one_display, print_variable_and_value): Update.
5174         * mi/mi-main.c (mi_print_exception): Update.
5175         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5176         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5177         * linux-nat.c (linux_nat_target::attach): Update.
5178         * linux-fork.c (class scoped_switch_fork_info): Update.
5179         * infrun.c (displaced_step_prepare): Update.
5180         * infcall.c (call_function_by_hand_dummy): Update.
5181         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5182         * gnu-v3-abi.c (print_one_vtable): Update.
5183         * frame.c (get_prev_frame_always): Update.
5184         * f-valprint.c (info_common_command_for_block): Update.
5185         * exec.c (try_open_exec_file): Update.
5186         * exceptions.c (print_exception, exception_print)
5187         (exception_fprintf, exception_print_same): Update.
5188         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5189         * dwarf-index-cache.c (index_cache::store)
5190         (index_cache::lookup_gdb_index): Update.
5191         * darwin-nat.c (maybe_cache_shell): Update.
5192         * cp-valprint.c (cp_print_value_fields): Update.
5193         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5194         (gcc_cplus_symbol_address): Update.
5195         * compile/compile-c-symbols.c (gcc_convert_symbol)
5196         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5197         * common/selftest.c: Update.
5198         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5199         a std::string.
5200         (exception_try_scope_entry, exception_try_scope_exit): Don't
5201         declare.
5202         (struct exception_try_scope): Remove.
5203         (TRY): Don't use exception_try_scope.
5204         (struct gdb_exception): Add constructor, operator=.
5205         <what>: New method.
5206         (struct gdb_exception_RETURN_MASK_ALL)
5207         (struct gdb_exception_RETURN_MASK_ERROR)
5208         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5209         (struct gdb_quit_bad_alloc): Update.
5210         * common/common-exceptions.c (exception_none): Change
5211         initializer.
5212         (struct catcher) <state, exception>: Initialize inline.
5213         <prev>: Remove member.
5214         (current_catcher): Remove.
5215         (catchers): New global.
5216         (exceptions_state_mc_init): Simplify.
5217         (catcher_pop): Remove.
5218         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5219         (try_scope_depth, exception_try_scope_entry)
5220         (exception_try_scope_exit): Remove.
5221         (throw_exception_sjlj): Update.
5222         (exception_messages, exception_messages_size): Remove.
5223         (throw_it): Simplify.
5224         (gdb_exception_sliced_copy): Remove.
5225         (throw_exception_cxx): Update.
5226         * cli/cli-script.c (script_from_file): Update.
5227         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5228         Update.
5229         * ada-valprint.c (ada_val_print): Update.
5230         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5231         (create_excep_cond_exprs): Update.
5232
5233 2019-04-08  Tom Tromey  <tom@tromey.com>
5234
5235         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5236         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5237         (TRY, CATCH, END_CATCH): Remove some definitions.
5238         * common/common-exceptions.c: Don't use GDB_XCPT.
5239         (catcher_list_size): Remove.
5240         (throw_exception, throw_it): Simplify.
5241
5242 2019-04-05  Tom Tromey  <tom@tromey.com>
5243
5244         Revert the header-sorting patch.
5245         * ft32-tdep.c: Revert.
5246         * frv-tdep.c: Revert.
5247         * frv-linux-tdep.c: Revert.
5248         * frame.c: Revert.
5249         * frame-unwind.c: Revert.
5250         * frame-base.c: Revert.
5251         * fork-child.c: Revert.
5252         * findvar.c: Revert.
5253         * findcmd.c: Revert.
5254         * filesystem.c: Revert.
5255         * filename-seen-cache.h: Revert.
5256         * filename-seen-cache.c: Revert.
5257         * fbsd-tdep.c: Revert.
5258         * fbsd-nat.h: Revert.
5259         * fbsd-nat.c: Revert.
5260         * f-valprint.c: Revert.
5261         * f-typeprint.c: Revert.
5262         * f-lang.c: Revert.
5263         * extension.h: Revert.
5264         * extension.c: Revert.
5265         * extension-priv.h: Revert.
5266         * expprint.c: Revert.
5267         * exec.h: Revert.
5268         * exec.c: Revert.
5269         * exceptions.c: Revert.
5270         * event-top.c: Revert.
5271         * event-loop.c: Revert.
5272         * eval.c: Revert.
5273         * elfread.c: Revert.
5274         * dwarf2read.h: Revert.
5275         * dwarf2read.c: Revert.
5276         * dwarf2loc.c: Revert.
5277         * dwarf2expr.h: Revert.
5278         * dwarf2expr.c: Revert.
5279         * dwarf2-frame.c: Revert.
5280         * dwarf2-frame-tailcall.c: Revert.
5281         * dwarf-index-write.h: Revert.
5282         * dwarf-index-write.c: Revert.
5283         * dwarf-index-common.c: Revert.
5284         * dwarf-index-cache.h: Revert.
5285         * dwarf-index-cache.c: Revert.
5286         * dummy-frame.c: Revert.
5287         * dtrace-probe.c: Revert.
5288         * disasm.h: Revert.
5289         * disasm.c: Revert.
5290         * disasm-selftests.c: Revert.
5291         * dictionary.c: Revert.
5292         * dicos-tdep.c: Revert.
5293         * demangle.c: Revert.
5294         * dcache.h: Revert.
5295         * dcache.c: Revert.
5296         * darwin-nat.h: Revert.
5297         * darwin-nat.c: Revert.
5298         * darwin-nat-info.c: Revert.
5299         * d-valprint.c: Revert.
5300         * d-namespace.c: Revert.
5301         * d-lang.c: Revert.
5302         * ctf.c: Revert.
5303         * csky-tdep.c: Revert.
5304         * csky-linux-tdep.c: Revert.
5305         * cris-tdep.c: Revert.
5306         * cris-linux-tdep.c: Revert.
5307         * cp-valprint.c: Revert.
5308         * cp-support.c: Revert.
5309         * cp-namespace.c: Revert.
5310         * cp-abi.c: Revert.
5311         * corelow.c: Revert.
5312         * corefile.c: Revert.
5313         * continuations.c: Revert.
5314         * completer.h: Revert.
5315         * completer.c: Revert.
5316         * complaints.c: Revert.
5317         * coffread.c: Revert.
5318         * coff-pe-read.c: Revert.
5319         * cli-out.h: Revert.
5320         * cli-out.c: Revert.
5321         * charset.c: Revert.
5322         * c-varobj.c: Revert.
5323         * c-valprint.c: Revert.
5324         * c-typeprint.c: Revert.
5325         * c-lang.c: Revert.
5326         * buildsym.c: Revert.
5327         * buildsym-legacy.c: Revert.
5328         * build-id.h: Revert.
5329         * build-id.c: Revert.
5330         * btrace.c: Revert.
5331         * bsd-uthread.c: Revert.
5332         * breakpoint.h: Revert.
5333         * breakpoint.c: Revert.
5334         * break-catch-throw.c: Revert.
5335         * break-catch-syscall.c: Revert.
5336         * break-catch-sig.c: Revert.
5337         * blockframe.c: Revert.
5338         * block.c: Revert.
5339         * bfin-tdep.c: Revert.
5340         * bfin-linux-tdep.c: Revert.
5341         * bfd-target.c: Revert.
5342         * bcache.c: Revert.
5343         * ax-general.c: Revert.
5344         * ax-gdb.h: Revert.
5345         * ax-gdb.c: Revert.
5346         * avr-tdep.c: Revert.
5347         * auxv.c: Revert.
5348         * auto-load.c: Revert.
5349         * arm-wince-tdep.c: Revert.
5350         * arm-tdep.c: Revert.
5351         * arm-symbian-tdep.c: Revert.
5352         * arm-pikeos-tdep.c: Revert.
5353         * arm-obsd-tdep.c: Revert.
5354         * arm-nbsd-tdep.c: Revert.
5355         * arm-nbsd-nat.c: Revert.
5356         * arm-linux-tdep.c: Revert.
5357         * arm-linux-nat.c: Revert.
5358         * arm-fbsd-tdep.c: Revert.
5359         * arm-fbsd-nat.c: Revert.
5360         * arm-bsd-tdep.c: Revert.
5361         * arch-utils.c: Revert.
5362         * arc-tdep.c: Revert.
5363         * arc-newlib-tdep.c: Revert.
5364         * annotate.h: Revert.
5365         * annotate.c: Revert.
5366         * amd64-windows-tdep.c: Revert.
5367         * amd64-windows-nat.c: Revert.
5368         * amd64-tdep.c: Revert.
5369         * amd64-sol2-tdep.c: Revert.
5370         * amd64-obsd-tdep.c: Revert.
5371         * amd64-obsd-nat.c: Revert.
5372         * amd64-nbsd-tdep.c: Revert.
5373         * amd64-nbsd-nat.c: Revert.
5374         * amd64-nat.c: Revert.
5375         * amd64-linux-tdep.c: Revert.
5376         * amd64-linux-nat.c: Revert.
5377         * amd64-fbsd-tdep.c: Revert.
5378         * amd64-fbsd-nat.c: Revert.
5379         * amd64-dicos-tdep.c: Revert.
5380         * amd64-darwin-tdep.c: Revert.
5381         * amd64-bsd-nat.c: Revert.
5382         * alpha-tdep.c: Revert.
5383         * alpha-obsd-tdep.c: Revert.
5384         * alpha-nbsd-tdep.c: Revert.
5385         * alpha-mdebug-tdep.c: Revert.
5386         * alpha-linux-tdep.c: Revert.
5387         * alpha-linux-nat.c: Revert.
5388         * alpha-bsd-tdep.c: Revert.
5389         * alpha-bsd-nat.c: Revert.
5390         * aix-thread.c: Revert.
5391         * agent.c: Revert.
5392         * addrmap.c: Revert.
5393         * ada-varobj.c: Revert.
5394         * ada-valprint.c: Revert.
5395         * ada-typeprint.c: Revert.
5396         * ada-tasks.c: Revert.
5397         * ada-lang.c: Revert.
5398         * aarch64-tdep.c: Revert.
5399         * aarch64-ravenscar-thread.c: Revert.
5400         * aarch64-newlib-tdep.c: Revert.
5401         * aarch64-linux-tdep.c: Revert.
5402         * aarch64-linux-nat.c: Revert.
5403         * aarch64-fbsd-tdep.c: Revert.
5404         * aarch64-fbsd-nat.c: Revert.
5405         * aarch32-linux-nat.c: Revert.
5406
5407 2019-04-05  Tom Tromey  <tom@tromey.com>
5408
5409         * ft32-tdep.c: Sort headers.
5410         * frv-tdep.c: Sort headers.
5411         * frv-linux-tdep.c: Sort headers.
5412         * frame.c: Sort headers.
5413         * frame-unwind.c: Sort headers.
5414         * frame-base.c: Sort headers.
5415         * fork-child.c: Sort headers.
5416         * findvar.c: Sort headers.
5417         * findcmd.c: Sort headers.
5418         * filesystem.c: Sort headers.
5419         * filename-seen-cache.h: Sort headers.
5420         * filename-seen-cache.c: Sort headers.
5421         * fbsd-tdep.c: Sort headers.
5422         * fbsd-nat.h: Sort headers.
5423         * fbsd-nat.c: Sort headers.
5424         * f-valprint.c: Sort headers.
5425         * f-typeprint.c: Sort headers.
5426         * f-lang.c: Sort headers.
5427         * extension.h: Sort headers.
5428         * extension.c: Sort headers.
5429         * extension-priv.h: Sort headers.
5430         * expprint.c: Sort headers.
5431         * exec.h: Sort headers.
5432         * exec.c: Sort headers.
5433         * exceptions.c: Sort headers.
5434         * event-top.c: Sort headers.
5435         * event-loop.c: Sort headers.
5436         * eval.c: Sort headers.
5437         * elfread.c: Sort headers.
5438         * dwarf2read.h: Sort headers.
5439         * dwarf2read.c: Sort headers.
5440         * dwarf2loc.c: Sort headers.
5441         * dwarf2expr.h: Sort headers.
5442         * dwarf2expr.c: Sort headers.
5443         * dwarf2-frame.c: Sort headers.
5444         * dwarf2-frame-tailcall.c: Sort headers.
5445         * dwarf-index-write.h: Sort headers.
5446         * dwarf-index-write.c: Sort headers.
5447         * dwarf-index-common.c: Sort headers.
5448         * dwarf-index-cache.h: Sort headers.
5449         * dwarf-index-cache.c: Sort headers.
5450         * dummy-frame.c: Sort headers.
5451         * dtrace-probe.c: Sort headers.
5452         * disasm.h: Sort headers.
5453         * disasm.c: Sort headers.
5454         * disasm-selftests.c: Sort headers.
5455         * dictionary.c: Sort headers.
5456         * dicos-tdep.c: Sort headers.
5457         * demangle.c: Sort headers.
5458         * dcache.h: Sort headers.
5459         * dcache.c: Sort headers.
5460         * darwin-nat.h: Sort headers.
5461         * darwin-nat.c: Sort headers.
5462         * darwin-nat-info.c: Sort headers.
5463         * d-valprint.c: Sort headers.
5464         * d-namespace.c: Sort headers.
5465         * d-lang.c: Sort headers.
5466         * ctf.c: Sort headers.
5467         * csky-tdep.c: Sort headers.
5468         * csky-linux-tdep.c: Sort headers.
5469         * cris-tdep.c: Sort headers.
5470         * cris-linux-tdep.c: Sort headers.
5471         * cp-valprint.c: Sort headers.
5472         * cp-support.c: Sort headers.
5473         * cp-namespace.c: Sort headers.
5474         * cp-abi.c: Sort headers.
5475         * corelow.c: Sort headers.
5476         * corefile.c: Sort headers.
5477         * continuations.c: Sort headers.
5478         * completer.h: Sort headers.
5479         * completer.c: Sort headers.
5480         * complaints.c: Sort headers.
5481         * coffread.c: Sort headers.
5482         * coff-pe-read.c: Sort headers.
5483         * cli-out.h: Sort headers.
5484         * cli-out.c: Sort headers.
5485         * charset.c: Sort headers.
5486         * c-varobj.c: Sort headers.
5487         * c-valprint.c: Sort headers.
5488         * c-typeprint.c: Sort headers.
5489         * c-lang.c: Sort headers.
5490         * buildsym.c: Sort headers.
5491         * buildsym-legacy.c: Sort headers.
5492         * build-id.h: Sort headers.
5493         * build-id.c: Sort headers.
5494         * btrace.c: Sort headers.
5495         * bsd-uthread.c: Sort headers.
5496         * breakpoint.h: Sort headers.
5497         * breakpoint.c: Sort headers.
5498         * break-catch-throw.c: Sort headers.
5499         * break-catch-syscall.c: Sort headers.
5500         * break-catch-sig.c: Sort headers.
5501         * blockframe.c: Sort headers.
5502         * block.c: Sort headers.
5503         * bfin-tdep.c: Sort headers.
5504         * bfin-linux-tdep.c: Sort headers.
5505         * bfd-target.c: Sort headers.
5506         * bcache.c: Sort headers.
5507         * ax-general.c: Sort headers.
5508         * ax-gdb.h: Sort headers.
5509         * ax-gdb.c: Sort headers.
5510         * avr-tdep.c: Sort headers.
5511         * auxv.c: Sort headers.
5512         * auto-load.c: Sort headers.
5513         * arm-wince-tdep.c: Sort headers.
5514         * arm-tdep.c: Sort headers.
5515         * arm-symbian-tdep.c: Sort headers.
5516         * arm-pikeos-tdep.c: Sort headers.
5517         * arm-obsd-tdep.c: Sort headers.
5518         * arm-nbsd-tdep.c: Sort headers.
5519         * arm-nbsd-nat.c: Sort headers.
5520         * arm-linux-tdep.c: Sort headers.
5521         * arm-linux-nat.c: Sort headers.
5522         * arm-fbsd-tdep.c: Sort headers.
5523         * arm-fbsd-nat.c: Sort headers.
5524         * arm-bsd-tdep.c: Sort headers.
5525         * arch-utils.c: Sort headers.
5526         * arc-tdep.c: Sort headers.
5527         * arc-newlib-tdep.c: Sort headers.
5528         * annotate.h: Sort headers.
5529         * annotate.c: Sort headers.
5530         * amd64-windows-tdep.c: Sort headers.
5531         * amd64-windows-nat.c: Sort headers.
5532         * amd64-tdep.c: Sort headers.
5533         * amd64-sol2-tdep.c: Sort headers.
5534         * amd64-obsd-tdep.c: Sort headers.
5535         * amd64-obsd-nat.c: Sort headers.
5536         * amd64-nbsd-tdep.c: Sort headers.
5537         * amd64-nbsd-nat.c: Sort headers.
5538         * amd64-nat.c: Sort headers.
5539         * amd64-linux-tdep.c: Sort headers.
5540         * amd64-linux-nat.c: Sort headers.
5541         * amd64-fbsd-tdep.c: Sort headers.
5542         * amd64-fbsd-nat.c: Sort headers.
5543         * amd64-dicos-tdep.c: Sort headers.
5544         * amd64-darwin-tdep.c: Sort headers.
5545         * amd64-bsd-nat.c: Sort headers.
5546         * alpha-tdep.c: Sort headers.
5547         * alpha-obsd-tdep.c: Sort headers.
5548         * alpha-nbsd-tdep.c: Sort headers.
5549         * alpha-mdebug-tdep.c: Sort headers.
5550         * alpha-linux-tdep.c: Sort headers.
5551         * alpha-linux-nat.c: Sort headers.
5552         * alpha-bsd-tdep.c: Sort headers.
5553         * alpha-bsd-nat.c: Sort headers.
5554         * aix-thread.c: Sort headers.
5555         * agent.c: Sort headers.
5556         * addrmap.c: Sort headers.
5557         * ada-varobj.c: Sort headers.
5558         * ada-valprint.c: Sort headers.
5559         * ada-typeprint.c: Sort headers.
5560         * ada-tasks.c: Sort headers.
5561         * ada-lang.c: Sort headers.
5562         * aarch64-tdep.c: Sort headers.
5563         * aarch64-ravenscar-thread.c: Sort headers.
5564         * aarch64-newlib-tdep.c: Sort headers.
5565         * aarch64-linux-tdep.c: Sort headers.
5566         * aarch64-linux-nat.c: Sort headers.
5567         * aarch64-fbsd-tdep.c: Sort headers.
5568         * aarch64-fbsd-nat.c: Sort headers.
5569         * aarch32-linux-nat.c: Sort headers.
5570
5571 2019-04-04  Tom Tromey  <tom@tromey.com>
5572
5573         * varobj.c (varobj_create): Update.
5574         * rust-exp.y (struct rust_parser) <update_innermost_block,
5575         lookup_symbol>: New methods.
5576         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5577         Rename.
5578         (rust_parser::rust_lookup_type)
5579         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5580         * printcmd.c (display_command, do_one_display): Update.
5581         * parser-defs.h (struct parser_state) <parser_state>: Add
5582         "tracker" parameter.
5583         (block_tracker): New member.
5584         (class innermost_block_tracker) <innermost_block_tracker>: Add
5585         "types" parameter.
5586         <reset>: Remove method.
5587         (innermost_block): Don't declare.
5588         (null_post_parser): Update.
5589         * parse.c (innermost_block): Remove global.
5590         (write_dollar_variable): Update.
5591         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5592         Remove "tracker_types" parameter.
5593         (parse_expression): Add "tracker" parameter.
5594         (parse_expression_for_completion): Update.
5595         (null_post_parser): Add "tracker" parameter.
5596         * p-exp.y: Update rules.
5597         * m2-exp.y: Update rules.
5598         * language.h (struct language_defn) <la_post_parser>: Add
5599         "tracker" parameter.
5600         * go-exp.y: Update rules.
5601         * f-exp.y: Update rules.
5602         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5603         parameter.
5604         * d-exp.y: Update rules.
5605         * c-exp.y: Update rules.
5606         * breakpoint.c (set_breakpoint_condition): Create an
5607         innermost_block_tracker.
5608         (watch_command_1): Likewise.
5609         * ada-lang.c (resolve): Add "tracker" parameter.
5610         (resolve_subexp): Likewise.
5611         * ada-exp.y (write_var_from_sym): Update.
5612
5613 2019-04-04  Tom Tromey  <tom@tromey.com>
5614
5615         * type-stack.h: New file.
5616         * type-stack.c: New file.
5617         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5618         type-stack.h.
5619         (insert_into_type_stack, insert_type, push_type, push_type_int)
5620         (insert_type_address_space, pop_type, pop_type_int)
5621         (pop_typelist, pop_type_stack, append_type_stack)
5622         (push_type_stack, get_type_stack, push_typelist)
5623         (follow_type_instance_flags, follow_types): Don't declare.
5624         * parse.c (type_stack): Remove global.
5625         (parse_exp_in_context): Update.
5626         (insert_into_type_stack, insert_type, push_type, push_type_int)
5627         (insert_type_address_space, pop_type, pop_type_int)
5628         (pop_typelist, pop_type_stack, append_type_stack)
5629         (push_type_stack, get_type_stack, push_typelist)
5630         (follow_type_instance_flags, follow_types): Remove (moved to
5631         type-stack.c).
5632         * f-exp.y (type_stack): New global.
5633         Update rules.
5634         (push_kind_type, f_parse): Update.
5635         * d-exp.y (type_stack): New global.
5636         Update rules.
5637         (d_parse): Update.
5638         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5639         Update rules.
5640         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5641         (HFILES_NO_SRCDIR): Add type-stack.h.
5642
5643 2019-04-04  Tom Tromey  <tom@tromey.com>
5644
5645         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5646         (rust_parser::convert_ast_to_expression, rust_parse)
5647         (rust_lex_test_completion, rust_lex_tests): Update.
5648         * parser-defs.h (struct expr_completion_state): New.
5649         (struct parser_state) <parser_state>: Add completion parameter.
5650         <mark_struct_expression, mark_completion_tag>: New methods.
5651         <parse_completion, m_completion_state>: New members.
5652         (prefixify_expression, null_post_parser): Update.
5653         (mark_struct_expression, mark_completion_tag): Don't declare.
5654         * parse.c (parse_completion, expout_last_struct)
5655         (expout_tag_completion_type, expout_completion_name): Remove
5656         globals.
5657         (parser_state::mark_struct_expression)
5658         (parser_state::mark_completion_tag): Now methods.
5659         (prefixify_expression): Add last_struct parameter.
5660         (prefixify_subexp): Likewise.
5661         (parse_exp_1): Update.
5662         (parse_exp_in_context): Add cstate parameter.  Update.
5663         (parse_expression_for_completion): Create an
5664         expr_completion_state.
5665         (null_post_parser): Add "completion" parameter.
5666         * p-exp.y: Update rules.
5667         (yylex): Update.
5668         * language.h (struct language_defn) <la_post_parser>: Add
5669         "completing" parameter.
5670         * go-exp.y: Update rules.
5671         (lex_one_token): Update.
5672         * expression.h (parse_completion): Don't declare.
5673         * d-exp.y: Update rules.
5674         (lex_one_token): Update rules.
5675         * c-exp.y: Update rules.
5676         (lex_one_token): Update.
5677         * ada-lang.c (resolve): Add "parse_completion" parameter.
5678         (resolve_subexp): Likewise.
5679         (ada_resolve_function): Likewise.
5680
5681 2019-04-04  Tom Tromey  <tom@tromey.com>
5682
5683         * parser-defs.h (struct parser_state) <start_arglist,
5684         end_arglist>: New methods.
5685         <arglist_len, m_funcall_chain>: New members.
5686         (arglist_len, start_arglist, end_arglist): Don't declare.
5687         * parse.c (arglist_len, funcall_chain): Remove global.
5688         (start_arglist, end_arglist): Remove functions.
5689         (parse_exp_in_context): Update.
5690         * p-exp.y: Update rules.
5691         * m2-exp.y: Update rules.
5692         * go-exp.y: Update rules.
5693         * f-exp.y: Update rules.
5694         * d-exp.y: Update rules.
5695         * c-exp.y: Update rules.
5696
5697 2019-04-04  Tom Tromey  <tom@tromey.com>
5698
5699         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5700         lex_operator, push_back>: New methods.
5701         Update all rules.
5702         (rust_parser::lex_hex, lex_escape): Rename and update.
5703         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5704         (rust_parser::lex_operator): Rename and update.
5705         (rust_parser::lex_number, rustyylex, rustyyerror)
5706         (rust_lex_test_init, rust_lex_test_sequence)
5707         (rust_lex_test_push_back, rust_lex_tests): Update.
5708         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5709         parameter.
5710         <lexptr, prev_lexptr>: New members.
5711         (lexptr, prev_lexptr): Don't declare.
5712         * parse.c (lexptr, prev_lexptr): Remove globals.
5713         (parse_exp_in_context): Update.
5714         * p-exp.y (yylex, yyerror): Update.
5715         * m2-exp.y (parse_number, yylex, yyerror): Update.
5716         * go-exp.y (lex_one_token, yyerror): Update.
5717         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5718         * d-exp.y (lex_one_token, yyerror): Update.
5719         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5720         (lex_one_token, yyerror): Update.
5721         * ada-lex.l (YY_INPUT): Update.
5722         (rewind_to_char): Update.
5723         * ada-exp.y (yyerror): Update.
5724
5725 2019-04-04  Tom Tromey  <tom@tromey.com>
5726
5727         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5728         * parser-defs.h (struct parser_state) <parser_state>: Add new
5729         parameter.
5730         <comma_terminates>: New member.
5731         (comma_terminates): Don't declare global.
5732         * parse.c (comma_terminates): Remove global.
5733         (parse_exp_in_context): Update.
5734         * p-exp.y (yylex): Update.
5735         * m2-exp.y (yylex): Update.
5736         * go-exp.y (lex_one_token): Update.
5737         * f-exp.y (yylex): Update.
5738         * d-exp.y (lex_one_token): Update.
5739         * c-exp.y (lex_one_token): Update.
5740         * ada-lex.l: Update.
5741
5742 2019-04-04  Tom Tromey  <tom@tromey.com>
5743
5744         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5745         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5746         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5747         * parser-defs.h (paren_depth): Don't declare.
5748         * parse.c (paren_depth): Remove global.
5749         (parse_exp_in_context): Update.
5750         * p-exp.y (paren_depth): New global.
5751         (pascal_parse): Initialize it.
5752         * m2-exp.y (paren_depth): New global.
5753         (m2_parse): Initialize it.
5754         * go-exp.y (paren_depth): New global.
5755         (go_parse): Initialize it.
5756         * f-exp.y (paren_depth): New global.
5757         (f_parse): Initialize it.
5758         * d-exp.y (paren_depth): New global.
5759         (d_parse): Initialize it.
5760         * c-exp.y (paren_depth): New global.
5761         (c_parse): Initialize it.
5762         * ada-lex.l (paren_depth): New global.
5763         (lexer_init): Initialize it.
5764
5765 2019-04-04  Tom Tromey  <tom@tromey.com>
5766
5767         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5768         (rust_parser::convert_ast_to_type)
5769         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5770         * parser-defs.h (struct parser_state) <parser_state>: Add
5771         parameters.  Initialize new members.
5772         <expression_context_block, expression_context_pc>: New members.
5773         * parse.c (expression_context_block, expression_context_pc):
5774         Remove globals.
5775         (parse_exp_in_context): Update.
5776         * p-exp.y: Update all rules.
5777         (yylex): Update.
5778         * m2-exp.y: Update all rules.
5779         (yylex): Update.
5780         * go-exp.y (yylex): Update.
5781         * f-exp.y (yylex): Update.
5782         * d-exp.y: Update all rules.
5783         (yylex): Update.
5784         * c-exp.y: Update all rules.
5785         (lex_one_token, classify_name, yylex, c_parse): Update.
5786         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5787
5788 2019-04-04  Tom Tromey  <tom@tromey.com>
5789
5790         * gdbarch.h, gdbarch.c: Rebuild.
5791         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5792         * stap-probe.h:
5793         (struct stap_parse_info): Replace "parser_state" with
5794         "expr_builder".
5795         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5796         (parser_state): New class.
5797         * parse.c (expr_builder): Rename.
5798         (expr_builder::release): Rename.
5799         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5800         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5801         (write_exp_elt_longcst, write_exp_elt_floatcst)
5802         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5803         (write_exp_string_vector, write_exp_bitstring)
5804         (write_exp_msymbol, mark_struct_expression)
5805         (write_dollar_variable)
5806         (insert_type_address_space, increase_expout_size): Replace
5807         "parser_state" with "expr_builder".
5808         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5809         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5810         "parser_state" with "expr_builder".
5811
5812 2019-04-04  Tom Tromey  <tom@tromey.com>
5813
5814         * rust-exp.y: Replace "parse_language" with method call.
5815         * p-exp.y:
5816         (yylex): Replace "parse_language" with method call.
5817         * m2-exp.y:
5818         (yylex): Replace "parse_language" with method call.
5819         * go-exp.y (classify_name): Replace "parse_language" with method
5820         call.
5821         * f-exp.y (yylex): Replace "parse_language" with method call.
5822         * d-exp.y (lex_one_token): Replace "parse_language" with method
5823         call.
5824         * c-exp.y:
5825         (lex_one_token, classify_name, yylex): Replace "parse_language"
5826         with method call.
5827         * ada-exp.y (find_primitive_type, type_char)
5828         (type_system_address): Replace "parse_language" with method call.
5829
5830 2019-04-04  Tom Tromey  <tom@tromey.com>
5831
5832         * rust-exp.y: Replace "parse_gdbarch" with method call.
5833         * parse.c (write_dollar_variable, insert_type_address_space):
5834         Replace "parse_gdbarch" with method call.
5835         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5836         call.
5837         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5838         call.
5839         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5840         "parse_gdbarch" with method call.
5841         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5842         with method call.
5843         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5844         "parse_gdbarch" with method call.
5845         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5846         "parse_gdbarch" with method call.
5847         * c-exp.y (parse_type, parse_number, classify_name): Replace
5848         "parse_gdbarch" with method call.
5849         * ada-lex.l: Replace "parse_gdbarch" with method call.
5850         * ada-exp.y (parse_type, find_primitive_type, type_char)
5851         (type_system_address): Replace "parse_gdbarch" with method call.
5852
5853 2019-04-04  Tom Tromey  <tom@tromey.com>
5854
5855         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5856         * stap-probe.c (stap_parse_argument): Update.
5857         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5858         initial_size parameter.
5859         * rust-exp.y (rust_lex_tests): Update.
5860         * parse.c (parser_state): Update.
5861         (parse_exp_in_context): Update.
5862         * parser-defs.h (struct parser_state) <parser_state>: Remove
5863         "initial_size" parameter.
5864
5865 2019-04-04  Tom Tromey  <tom@tromey.com>
5866
5867         * parser-defs.h (increase_expout_size): Don't declare.
5868         * parse.c (increase_expout_size): Now static.
5869
5870 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5871
5872         * gnu-nat.c (gnu_nat_target::wait): Fix
5873         target_waitstatus_to_string call.
5874
5875 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * eval.c (evaluate_subexp_standard): Handle internal functions
5878         during Fortran function call handling.
5879
5880 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * NEWS: Mention new internal functions.
5883         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5884         (read_base_type): Use dwarf2_init_complex_target_type.
5885         * value.c (creal_internal_fn): New function.
5886         (cimag_internal_fn): New function.
5887         (_initialize_values): Register new internal functions.
5888
5889 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5890
5891         * infrun.c (stop_all_threads): If debug_infrun, always
5892         trace the wait status after wait_one, using
5893         target_waitstatus_to_string and target_pid_to_str.
5894         (handle_inferior_event): Replace various trace of
5895         wait status kind by a single trace.
5896         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5897         wait status kind image by target_waitstatus_to_string.
5898         * target/waitstatus.c (target_waitstatus_to_string): Fix
5899         obsolete comment.
5900
5901 2019-04-01  Tom Tromey  <tromey@adacore.com>
5902
5903         PR symtab/23331:
5904         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5905
5906 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5907             Pedro Alves  <palves@redhat.com>
5908
5909         * top.c (quit_force): Call 'finalize_values'.
5910         * value.c (finalize_values): New function.
5911         * value.h (finalize_values): Declare.
5912
5913 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5914
5915         * NEWS: Announce $_gdb_major and $_gdb_minor.
5916
5917         * top.c (init_gdb_version_vars): New function.
5918         (gdb_init): Call init_gdb_version_vars.
5919
5920 2019-03-29  Tom Tromey  <tromey@adacore.com>
5921
5922         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5923         help text.  Remove dead code.
5924
5925 2019-03-29  Keith Seitz  <keiths@redhat.com>
5926
5927         From Siddhesh Poyarekar:
5928         * f-lang.h (f77_get_upperbound): Return LONGEST.
5929         (f77_get_lowerbound): Likewise.
5930         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5931         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5932         print them.
5933         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5934         plongest to format print it.
5935         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5936         (f77_get_upperbound): Likewise.
5937         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5938         LOWER_BOUND to LONGEST.
5939         (f77_create_arrayprint_offset_tbl): Likewise.
5940
5941 2019-03-29  Keith Seitz  <keiths@redhat.com>
5942
5943         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5944         %s/pulongest for TYPE_LENGTH instead of %d in format
5945         strings.
5946         * ada-typerint.c (ada_print_type): Likewise.
5947         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5948         * compile/compile-c-support.c (generate_register_struct): Likewise.
5949         * gdbtypes.c (recursive_dump_type): Likewise.
5950         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5951         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5952         instead of %d in format strings.
5953         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5954         to std::min to ULONGEST.
5955         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5956         instead of %d in format strings.
5957         * tracepoint.c (info_scope_command): Likewise.
5958         * typeprint.c (print_offset_data::update)
5959         (print_offset_data::finish): Likewise.
5960         * xtensa-tdep.c (xtensa_store_return_value)
5961         (xtensa_push_dummy_call): Likewise.
5962
5963 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5964
5965         * windows-nat.c (display_selector): Fixed format specifications
5966         for 64-bit Cygwin.
5967
5968 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5969
5970         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5971
5972 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5973
5974         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5975         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5976         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5977         (nios2_linux_init_abi): Install it.
5978
5979 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5980
5981         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5982
5983 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5984
5985         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5986
5987 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5988             Tom Tromey  <tromey@adacore.com>
5989
5990         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5991
5992 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5993
5994         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5995         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5996         method to compute the bounds of range types. Also print "[evaluated]"
5997         if the bounds' values come from a dynamic evaluation.
5998
5999 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6000
6001         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6002         whitespace when pretty printing is on.
6003
6004 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6005
6006         * ppc-linux-nat.c: Add include.
6007
6008 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6009
6010         * NEWS: Mention AArch64 Pointer Authentication.
6011
6012 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6013
6014         * arm-linux-nat.c: Add include.
6015
6016 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6017
6018         * source-cache.c (source_cache::get_source_lines): Re-read
6019         fullname after calling open_source_file.
6020
6021 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6022
6023         * NEWS: Mention TLS support for FreeBSD.
6024
6025 2019-03-25  Tom Tromey  <tromey@adacore.com>
6026
6027         * minsyms.c (BUNCH_SIZE): Update comment.
6028         (~minimal_symbol_reader): Remove old comment.
6029         (compact_minimal_symbols): Update comment.
6030         (minimal_symbol_reader::install): Remove old comment.  Update
6031         other comments.
6032
6033 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6034
6035         * s390-linux-nat.c: Add include.
6036
6037 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6038
6039         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6040         Call linux_get_hwcap.
6041         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6042         Likewise.
6043         (aarch64_linux_get_hwcap): Remove function.
6044         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6045         declaration.
6046         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6047         linux_get_hwcap.
6048         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6049         * linux-tdep.c (linux_get_hwcap): Add function.
6050         (linux_get_hwcap2): Likewise.
6051         * linux-tdep.h (linux_get_hwcap): Add declaration.
6052         (linux_get_hwcap2): Likewise.
6053         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6054         (ppc_linux_get_hwcap2): Likewise.
6055         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6056         linux_get_hwcap.
6057         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6058         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6059         (ppc_linux_nat_target::read_description): Likewise.
6060         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6061         * s390-linux-nat.c: Likewise.
6062         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6063
6064 2019-03-24  Tom Tromey  <tom@tromey.com>
6065
6066         * ada-lang.c (standard_lookup): Simplify initialization.
6067         (ada_lookup_symbol_nonlocal): Simplify return.
6068         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6069         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6070         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6071         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6072         initialization.
6073         * solib.c (solib_global_lookup): Simplify.
6074         * symtab.c (null_block_symbol): Remove.
6075         (symbol_cache_lookup): Simplify returns.
6076         (lookup_language_this): Simplify returns.
6077         (lookup_symbol_aux): Simplify return.
6078         (lookup_local_symbol): Simplify returns.
6079         (lookup_global_symbol_from_objfile): Simplify return.
6080         (lookup_symbol_in_objfile_symtabs)
6081         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6082         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6083         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6084         * cp-namespace.c (cp_lookup_bare_symbol)
6085         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6086         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6087         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6088         (cp_lookup_symbol_via_imports): Simplify initialization.
6089         (find_symbol_in_baseclass): Likewise.
6090         * symtab.h (null_block_symbol): Remove.
6091         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6092         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6093         (d_lookup_symbol_module): Likewise.
6094         (find_symbol_in_baseclass): Simplify initialization.
6095
6096 2019-03-24  Tom Tromey  <tom@tromey.com>
6097
6098         * expression.h: Don't include symtab.h.
6099         (struct block): Forward declare.
6100
6101 2019-03-24  Tom Tromey  <tom@tromey.com>
6102
6103         * c-exp.y (typebase): Remove casts.
6104         * gdbtypes.c (lookup_unsigned_typename, )
6105         (lookup_signed_typename): Remove cast.
6106         * eval.c (parse_to_comma_and_eval): Remove cast.
6107         * parse.c (write_dollar_variable): Remove cast.
6108         * block.h (struct block) <superblock>: Now const.
6109         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6110         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6111         (map_block): Make "block" const.
6112         * symfile.h (struct quick_symbol_functions)
6113         <map_matching_symbols>: Constify block argument to "callback".
6114         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6115         const.
6116         (find_pc_sect_compunit_symtab): Make "b" const.
6117         (find_symbol_at_address): Likewise.
6118         (search_symbols): Likewise.
6119         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6120         (dw2_debug_names_lookup_symbol): Likewise.
6121         (dw2_map_matching_symbols): Update.
6122         * p-valprint.c (pascal_val_print): Remove "block".
6123         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6124         (aux_add_nonlocal_symbols): Make "block" const.
6125         (resolve_subexp): Remove cast.
6126         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6127         const.
6128         (iterate_over_file_blocks): Likewise.
6129         * f-exp.y (%union) <bval>: Remove.
6130         * coffread.c (patch_opaque_types): Make "b" const.
6131         * spu-tdep.c (spu_catch_start): Make "block" const.
6132         * c-valprint.c (print_unpacked_pointer): Remove "block".
6133         * symmisc.c (dump_symtab_1): Make "b" const.
6134         (block_depth): Make "block" const.
6135         * d-exp.y (%union) <bval>: Remove.
6136         * cp-support.h (cp_lookup_rtti_type): Update.
6137         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6138         * psymtab.c (psym_lookup_symbol): Make "block" const.
6139         (maintenance_check_psymtabs): Make "b" const.
6140         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6141         (enumerate_locals, enumerate_args): Update.
6142         * python/py-symtab.c (stpy_global_block): Make "block" const.
6143         (stpy_static_block): Likewise.
6144         * inline-frame.c (block_starting_point_at): Make "new_block"
6145         const.
6146         * block.c (find_block_in_blockvector): Make return type const.
6147         (blockvector_for_pc_sect): Make "b" const.
6148         (find_block_in_blockvector): Make "b" const.
6149
6150 2019-03-23  Tom Tromey  <tom@tromey.com>
6151
6152         * varobj.c (varobj_create): Update.
6153         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6154         * printcmd.c (display_command, do_one_display): Don't reset
6155         innermost_block.
6156         * parser-defs.h (enum innermost_block_tracker_type): Move to
6157         expression.h.
6158         (innermost_block): Update comment.
6159         * parse.c (parse_exp_1): Add tracker_types parameter.
6160         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6161         tracker_types parameter.  Reset innermost_block.
6162         (parse_exp_in_context): Remove.
6163         (parse_expression_for_completion): Update.
6164         * objfiles.c (~objfile): Don't reset expression_context_block or
6165         innermost_block.
6166         * expression.h (enum innermost_block_tracker_type): Move from
6167         parser-defs.h.
6168         (parse_exp_1): Add tracker_types parameter.
6169         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6170         reset innermost_block.
6171
6172 2019-03-23  Tom Tromey  <tom@tromey.com>
6173
6174         * objfiles.h: Include bcache.h.
6175
6176 2019-03-23  Tom Tromey  <tom@tromey.com>
6177
6178         * linespec.c (get_current_search_block): Use
6179         scoped_restore_current_language.
6180         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6181
6182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6183             Jiong Wang  <jiong.wang@arm.com>
6184
6185         * aarch64-linux-tdep.c
6186         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6187         section.
6188         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6189
6190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6191             Jiong Wang  <jiong.wang@arm.com>
6192
6193         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6194         instructions.
6195         (aarch64_analyze_prologue_test): Add PACIASP test.
6196         (aarch64_prologue_prev_register): Unmask PC value.
6197
6198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6199             Jiong Wang  <jiong.wang@arm.com>
6200
6201         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6202         (aarch64_dwarf2_prev_register): Unmask PC value.
6203         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6204         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6205         DW_CFA_AARCH64_negate_ra_state.
6206         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6207
6208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6209             Jiong Wang  <jiong.wang@arm.com>
6210
6211         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6212         registers.
6213         (aarch64_pseudo_register_name): Likewise.
6214         (aarch64_pseudo_register_type): Likewise.
6215         (aarch64_pseudo_register_reggroup_p): Likewise.
6216         (aarch64_gdbarch_init): Add pauth registers.
6217         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6218         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6219         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6220         (struct gdbarch_tdep): Add regnum for ra_state.
6221
6222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6223             Jiong Wang  <jiong.wang@arm.com>
6224
6225         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6226
6227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6228             Jiong Wang  <jiong.wang@arm.com>
6229
6230         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6231         function.
6232         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6233         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6234         (aarch64_gdbarch_init): Add puth registers.
6235         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6236         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6237         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6238
6239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6240             Jiong Wang  <jiong.wang@arm.com>
6241
6242         * aarch64-linux-nat.c
6243         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6244         * aarch64-linux-tdep.c
6245         (aarch64_linux_core_read_description): Likewise.
6246         (aarch64_linux_get_hwcap): New function.
6247         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6248         (aarch64_linux_get_hwcap): New declaration.
6249
6250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6251             Jiong Wang  <jiong.wang@arm.com>
6252
6253         * aarch64-linux-nat.c
6254         (aarch64_linux_nat_target::read_description): Add pauth param.
6255         * aarch64-linux-tdep.c
6256         (aarch64_linux_core_read_description): Likewise.
6257         * aarch64-tdep.c (struct target_desc): Add in pauth.
6258         (aarch64_read_description): Add pauth param.
6259         (aarch64_gdbarch_init): Likewise.
6260         * aarch64-tdep.h (aarch64_read_description): Likewise.
6261         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6262         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6263         * features/Makefile: Add new files.
6264         * features/aarch64-pauth.c: New file.
6265         * features/aarch64-pauth.xml: New file.
6266
6267 2019-03-20  Tom Tromey  <tromey@adacore.com>
6268
6269         * infrun.c (handle_inferior_event): Rename from
6270         handle_inferior_event_1.  Create a scoped_value_mark.
6271         (handle_inferior_event): Remove.
6272
6273 2019-03-19  Tom Tromey  <tromey@adacore.com>
6274
6275         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6276         * infrun.h (print_stop_event): Add "displays" parameter.
6277         * infrun.c (print_stop_event): Add "displays" parameter.
6278
6279 2019-03-19  Pedro Alves  <palves@redhat.com>
6280
6281         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6282         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6283         to -1.  Fix TABs vs spaces.
6284         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6285         * tui/tui-out.h (tui_ui_out) Add intro comments.
6286         <m_line, m_start_of_line>: In-class initialize, and add describing
6287         comment.
6288
6289 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6290
6291         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6292         variable names.
6293         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6294
6295 2019-03-18  Pedro Alves  <palves@redhat.com>
6296             Eli Zaretskii <eliz@gnu.org>
6297
6298         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6299         m_line and m_start_of_line.
6300
6301 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6302
6303         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6304         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6305         it returns a newline.  This fixes a regression in TU mode, whereby
6306         the next line is output on the same screen line as the user input.
6307
6308 2019-03-18  Tom Tromey  <tromey@adacore.com>
6309
6310         * minsyms.c (minimal_symbol_reader::install): Remove call to
6311         obstack_blank.
6312
6313 2019-03-18  Pedro Alves  <palves@redhat.com>
6314
6315         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6316         New globals.
6317         (apply_style): New, factored out from ...
6318         (apply_ansi_escape): ... this.  Handle reverse video mode.
6319         (tui_set_reverse_mode): New function.
6320         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6321         * tui/tui-winsource.c (tui_show_source_line): Use
6322         tui_set_reverse_mode instead of setting A_STANDOUT.
6323         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6324         New setter methods.
6325
6326 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6327
6328         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6329         Handle tabs.
6330
6331 2019-03-18  Tom Tromey  <tromey@adacore.com>
6332
6333         * ada-lang.c (empty_array): Add "high" parameter.
6334         (ada_evaluate_subexp): Update.
6335
6336 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6337
6338         * unittests/string_view-selftests.c: Define
6339         _initialize_string_view_selftests unconditionally.
6340
6341 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6342
6343         PR gdb/24350
6344         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6345
6346 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6347
6348         PR gdb/24351
6349         * windows-nat.c (display_selector): Fix format specifiers.
6350
6351 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6352
6353         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6354         tui_refill_source_window instead of tui_refresh_win, to update the
6355         current execution line.  This fixes redisplay of the current line
6356         when stepping through the code with "next" or "step".
6357
6358 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6359
6360         * source-cache.c (source_cache::get_source_lines): Call
6361         find_source_lines to initialize s->nlines.  This fixes vertical
6362         scrolling of TUI source window when the DOWN arrow is pressed.
6363
6364 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6365
6366         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6367         linux-thread-db.c (_initialize_thread_db): Likewise.
6368
6369 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6370
6371         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6372         wclrtoeol in tui_show_source_line".  This reverts changes made in
6373         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6374
6375 2019-03-15  Tom Tromey  <tom@tromey.com>
6376
6377         * symtab.h (struct minimal_symbol): Derive from
6378         general_symbol_info.
6379         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6380         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6381         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6382         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6383         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6384         (MSYMBOL_SEARCH_NAME): Update.
6385         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6386         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6387         * minsyms.c (minimal_symbol_reader::record_full): Update.
6388
6389 2019-03-15  Tom Tromey  <tom@tromey.com>
6390
6391         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6392
6393 2019-03-15  Tom Tromey  <tom@tromey.com>
6394
6395         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6396         unique_xmalloc_ptr.
6397         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6398         Update.
6399         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6400         (build_minimal_symbol_hash_tables)
6401         (minimal_symbol_reader::install): Update.
6402
6403 2019-03-15  Tom Tromey  <tom@tromey.com>
6404
6405         * symtab.c (create_demangled_names_hash): Update.
6406         (symbol_set_names): Update.
6407         * objfiles.h (struct objfile_per_bfd_storage)
6408         <demangled_names_hash>: Now an htab_up.
6409         * objfiles.c (objfile_per_bfd_storage): Simplify.
6410
6411 2019-03-15  Tom Tromey  <tom@tromey.com>
6412
6413         * objfiles.h (struct objfile_per_bfd_storage): Declare
6414         destructor.
6415         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6416         New.
6417         (get_objfile_bfd_data): Use new.  Don't initialize
6418         language_of_main.
6419         (free_objfile_per_bfd_storage): Remove.
6420         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6421
6422 2019-03-15  Tom Tromey  <tom@tromey.com>
6423
6424         * symfile.c (reread_symbols): Update.
6425         * objfiles.c (objfile::objfile): Update.
6426         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6427         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6428         comment.
6429         (minimal_symbol_reader::install): Update.
6430         (terminate_minimal_symbol_table): Remove.
6431         * jit.c (jit_object_close_impl): Update.
6432
6433 2019-03-15  Tom Tromey  <tom@tromey.com>
6434
6435         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6436         initializations.
6437
6438 2019-03-15  Tom Tromey  <tom@tromey.com>
6439
6440         * objfiles.h (struct objfile_per_bfd_storage)
6441         <demangled_hash_languages>: Now a bitset.
6442         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6443         (lookup_minimal_symbol): Update.
6444
6445 2019-03-15  Tom Tromey  <tom@tromey.com>
6446
6447         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6448         Don't return the symbol.
6449         * coffread.c (record_minimal_symbol): Use record_full.
6450
6451 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6452
6453         The MS-Windows port of ncurses fails to switch to a color pair if
6454         one or both of the colors are the implicit default colors.  This
6455         change records the default colors when TUI is initialized, and
6456         then specifies them explicitly when a color pair uses the default
6457         colors.  This allows color styling in TUI mode on MS-Windows.
6458
6459         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6460         ncurses_norm_attr.
6461         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6462         colors in ncurses_norm_attr.
6463         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6464         "none", replace it with the default color recorded in
6465         ncurses_norm_attr.
6466
6467 2019-03-14  Tom Tromey  <tromey@adacore.com>
6468
6469         * source-cache.h (class source_cache) <get_source_lines>: Return
6470         std::string.
6471         * source-cache.c (source_cache::extract_lines): Handle case where
6472         first_pos==npos.  Return std::string.
6473         (source_cache::get_source_lines): Update.
6474
6475 2019-03-14  Tom Tromey  <tromey@adacore.com>
6476
6477         * NEWS: Add item for "style sources" commands.
6478         * source-cache.c (source_cache::get_source_lines): Check
6479         source_styling.
6480         * cli/cli-style.c (source_styling): New global.
6481         (_initialize_cli_style): Add "style sources" commands.
6482         (show_style_sources): New function.
6483         * cli/cli-style.h (source_styling): Declare.
6484
6485 2019-03-14  Pedro Alves  <palves@redhat.com>
6486             Tom Tromey  <tromey@adacore.com>
6487
6488         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6489         * tui/tui-winsource.c (tui_refill_source_window): New function,
6490         from...
6491         (tui_horizontal_source_scroll): ... here.  Move some logic.
6492         * cli/cli-style.c (set_style_enabled): Notify new observable.
6493         * tui/tui-hooks.c (tui_redisplay_source): New function.
6494         (tui_attach_detach_observers): Attach or detach
6495         tui_redisplay_source.
6496         * observable.h (source_styling_changed): New observable.
6497         * observable.c: Define source_styling_changed observable.
6498
6499 2019-03-13  Tom Tromey  <tromey@adacore.com>
6500
6501         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6502         (i386_gnu_nat_target::store_registers): Update.
6503         * target-debug.h (target_debug_print_std_string): New macro.
6504         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6505         * windows-tdep.c (display_one_tib): Update.
6506         * tui/tui-stack.c (tui_make_status_line): Update.
6507         * top.c (print_inferior_quit_action): Update.
6508         * thread.c (thr_try_catch_cmd): Update.
6509         (add_thread_with_info): Update.
6510         (thread_target_id_str): Update.
6511         (thr_try_catch_cmd): Update.
6512         (thread_command): Update.
6513         (thread_find_command): Update.
6514         * record-btrace.c (record_btrace_target::info_record)
6515         (record_btrace_resume_thread, record_btrace_target::resume)
6516         (record_btrace_cancel_resume, record_btrace_step_thread)
6517         (record_btrace_target::wait, record_btrace_target::wait)
6518         (record_btrace_target::wait, record_btrace_target::stop): Update.
6519         * progspace.c (print_program_space): Update.
6520         * process-stratum-target.c
6521         (process_stratum_target::thread_address_space): Update.
6522         * linux-fork.c (linux_fork_mourn_inferior)
6523         (detach_checkpoint_command, info_checkpoints_command)
6524         (linux_fork_context): Update.
6525         (linux_fork_detach): Update.
6526         (class scoped_switch_fork_info): Update.
6527         (delete_checkpoint_command): Update.
6528         * infrun.c (follow_fork_inferior): Update.
6529         (follow_fork_inferior): Update.
6530         (proceed_after_vfork_done): Update.
6531         (handle_vfork_child_exec_or_exit): Update.
6532         (follow_exec): Update.
6533         (displaced_step_prepare_throw): Update.
6534         (displaced_step_restore): Update.
6535         (start_step_over): Update.
6536         (resume_1): Update.
6537         (clear_proceed_status_thread): Update.
6538         (proceed): Update.
6539         (print_target_wait_results): Update.
6540         (do_target_wait): Update.
6541         (context_switch): Update.
6542         (stop_all_threads): Update.
6543         (restart_threads): Update.
6544         (finish_step_over): Update.
6545         (handle_signal_stop): Update.
6546         (switch_back_to_stepped_thread): Update.
6547         (keep_going_pass_signal): Update.
6548         (print_exited_reason): Update.
6549         (normal_stop): Update.
6550         * inferior.c (inferior_pid_to_str): Change return type.
6551         (print_selected_inferior): Update.
6552         (add_inferior): Update.
6553         (detach_inferior): Update.
6554         * dummy-frame.c (fprint_dummy_frames): Update.
6555         * dcache.c (dcache_info_1): Update.
6556         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6557         (btrace_fetch, btrace_clear): Update.
6558         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6559         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6560         type.
6561         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6562         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6563         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6564         * gdbarch.c, gdbarch.h: Rebuild.
6565         * gdbarch.sh (core_pid_to_str): Change return type.
6566         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6567         return type.
6568         (windows_nat_target::pid_to_str): Change return type.
6569         (windows_delete_thread): Update.
6570         (windows_nat_target::attach): Update.
6571         (windows_nat_target::files_info): Update.
6572         * target-delegates.c: Rebuild.
6573         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6574         return type.
6575         (sol_thread_target::pid_to_str): Change return type.
6576         * remote.c (class remote_target) <pid_to_str>: Change return
6577         type.
6578         (remote_target::pid_to_str): Change return type.
6579         (extended_remote_target::attach, remote_target::remote_stop_ns)
6580         (remote_target::remote_notif_remove_queued_reply)
6581         (remote_target::push_stop_reply, remote_target::disable_btrace):
6582         Update.
6583         (extended_remote_target::attach): Update.
6584         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6585         type.
6586         (gdbsim_target::pid_to_str): Change return type.
6587         * ravenscar-thread.c (struct ravenscar_thread_target)
6588         <pid_to_str>: Change return type.
6589         (ravenscar_thread_target::pid_to_str): Change return type.
6590         * procfs.c (class procfs_target) <pid_to_str>: Change return
6591         type.
6592         (procfs_target::pid_to_str): Change return type.
6593         (procfs_target::attach): Update.
6594         (procfs_target::detach): Update.
6595         (procfs_target::fetch_registers): Update.
6596         (procfs_target::store_registers): Update.
6597         (procfs_target::wait): Update.
6598         (procfs_target::files_info): Update.
6599         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6600         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6601         return type.
6602         (nto_procfs_target::pid_to_str): Change return type.
6603         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6604         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6605         return type.
6606         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6607         (exit_lwp): Update.
6608         (attach_proc_task_lwp_callback, get_detach_signal)
6609         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6610         (linux_nat_target::resume, wait_lwp, stop_callback)
6611         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6612         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6613         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6614         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6615         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6616         type.
6617         (inf_ptrace_target::attach): Update.
6618         (inf_ptrace_target::files_info): Update.
6619         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6620         type.
6621         (go32_nat_target::pid_to_str): Change return type.
6622         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6623         (gnu_nat_target::wait): Update.
6624         (gnu_nat_target::wait): Update.
6625         (gnu_nat_target::resume): Update.
6626         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6627         (fbsd_nat_target::wait): Update.
6628         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6629         type.
6630         (darwin_nat_target::attach): Update.
6631         * corelow.c (class core_target) <pid_to_str>: Change return type.
6632         (core_target::pid_to_str): Change return type.
6633         * target.c (normal_pid_to_str): Change return type.
6634         (default_pid_to_str): Likewise.
6635         (target_pid_to_str): Change return type.
6636         (target_translate_tls_address): Update.
6637         (target_announce_detach): Update.
6638         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6639         return type.
6640         (bsd_uthread_target::pid_to_str): Change return type.
6641         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6642         type.
6643         (bsd_kvm_target::pid_to_str): Change return type.
6644         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6645         return type.
6646         (aix_thread_target::pid_to_str): Change return type.
6647         * target.h (struct target_ops) <pid_to_str>: Change return type.
6648         (target_pid_to_str, normal_pid_to_str): Likewise.
6649         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6650         type.
6651         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6652         type.
6653         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6654         return type.
6655         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6656         type.
6657         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6658         type.
6659         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6660         return type.
6661
6662 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6663
6664         * NEWS: Mention that the new default MI version is 3.  Mention
6665         changes to the output of commands and events that deal with
6666         multi-location breakpoints.
6667         * breakpoint.c: Include "mi/mi-out.h".
6668         (print_one_breakpoint): Change output syntax if using MI version
6669         >= 3.
6670         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6671         New.
6672         (mi_multi_location_breakpoint_output_fixed): New.
6673         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6674         (mi_cmd_fix_multi_location_breakpoint_output): New.
6675         (mi_multi_location_breakpoint_output_fixed): New.
6676         * mi/mi-cmds.c (mi_cmds): Register command
6677         -fix-multi-location-breakpoint-output.
6678         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6679         interpreter "mi".
6680
6681 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6682
6683         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6684         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6685         instantiate mi_ui_out based on interpreter name.
6686         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6687         * mi/mi-main.c (mi_load_progress): Likewise.
6688
6689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6690
6691         * NEWS: Combine separate "New targets" sections for 8.3.
6692
6693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6694
6695         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6696         (ppcfbsd_init_abi): Install gdbarch
6697         "fetch_tls_load_module_address" and "get_thread_local_address"
6698         methods.
6699
6700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6701
6702         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6703         (riscv_fbsd_init_abi): Install gdbarch
6704         "fetch_tls_load_module_address" and "get_thread_local_address"
6705         methods.
6706
6707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6708
6709         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6710         (i386fbsd_init_abi): Install gdbarch
6711         "fetch_tls_load_module_address" and "get_thread_local_address"
6712         methods.
6713
6714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6715
6716         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6717         (amd64fbsd_init_abi): Install gdbarch
6718         "fetch_tls_load_module_address" and "get_thread_local_address"
6719         methods.
6720
6721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6722
6723         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6724         (struct fbsd_pspace_data): New type.
6725         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6726         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6727         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6728         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6729         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6730
6731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6732
6733         * gdbtypes.c (lookup_struct_elt): New function.
6734         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6735         * gdbtypes.h (struct struct_elt): New type.
6736         (lookup_struct_elt): New prototype.
6737
6738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6739
6740         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6741         remove disabled code block.
6742
6743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6744
6745         * gdbarch.sh (get_thread_local_address): New method.
6746         * gdbarch.h, gdbarch.c: Regenerate.
6747         * target.c (target_translate_tls_address): Use
6748         gdbarch_get_thread_local_address if present instead of
6749         target::get_thread_local_address.
6750
6751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6752
6753         * target.h (target::get_thread_local_address): Update comment.
6754
6755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6756
6757         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6758         objfile->separate_debug_objfile_backlink if not NULL.
6759
6760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6761
6762         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6763         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6764         (amd64bsd_store_inferior_registers): Likewise.
6765         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6766         Enable segment base registers.
6767         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6768         PT_GETFSBASE and PT_GETGSBASE.
6769         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6770         PT_SETGSBASE.
6771         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6772         segment base registers.
6773         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6774
6775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6776
6777         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6778         Update calls to i386_target_description to add 'segments'
6779         parameter.
6780         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6781         add segment base registers.
6782         * arch/i386.c (i386_create_target_description): Add 'segments'
6783         parameter to enable segment base registers.
6784         * arch/i386.h (i386_create_target_description): Likewise.
6785         * features/i386/32bit-segments.xml: New file.
6786         * features/i386/32bit-segments.c: Generate.
6787         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6788         call to i386_target_description to add 'segments' parameter.
6789         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6790         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6791         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6792         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6793         if feature is present.
6794         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6795         Add 'segments' parameter to call to i386_target_description.
6796         (i386_target_description): Add 'segments' parameter to enable
6797         segment base registers.
6798         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6799         to call to i386_target_description.
6800         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6801         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6802         Define I386_NUM_REGS.
6803         (i386_target_description): Add 'segments' parameter to enable
6804         segment base registers.
6805
6806 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6807
6808         PR/24325
6809         * source-cache.c: #undef open and close, to avoid unresolved
6810         externals during linking.
6811
6812 2019-03-12  Tom Tromey  <tromey@adacore.com>
6813
6814         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6815         const.  Add initializers.
6816         (_initialize_remote): Don't initialize ptid globals.
6817
6818 2019-03-12  Pedro Alves  <palves@redhat.com>
6819
6820         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6821
6822 2019-03-12  Pedro Alves  <palves@redhat.com>
6823
6824         * cp-name-parser.y (main): Remove unused 'len' variable.
6825
6826 2019-03-12  Tom Tromey  <tromey@adacore.com>
6827
6828         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6829         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6830
6831 2019-03-12  Tom Tromey  <tromey@adacore.com>
6832
6833         * linux-nat.c (iterate_over_lwps): Update.
6834         (stop_callback): Remove parameter.
6835         (stop_wait_callback, detach_callback, resume_set_callback)
6836         (select_singlestep_lwp_callback, set_ignore_sigint)
6837         (status_callback, resumed_callback, resume_clear_callback)
6838         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6839         data parameter.
6840         (linux_nat_target::detach, linux_nat_target::resume)
6841         (linux_stop_and_wait_all_lwps, select_event_lwp)
6842         (linux_nat_filter_event, linux_nat_wait_1)
6843         (linux_nat_target::kill, linux_nat_target::stop)
6844         (linux_nat_target::stop): Update.
6845         (linux_nat_resume_callback): Change type.
6846         (resume_stopped_resumed_lwps, count_events_callback)
6847         (select_event_lwp_callback): Likewise.
6848         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6849         * arm-linux-nat.c (struct update_registers_data): Remove.
6850         (update_registers_callback): Change type.
6851         (arm_linux_insert_hw_breakpoint1): Update.
6852         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6853         parameter.
6854         (x86_linux_dr_set_addr): Update.
6855         (x86_linux_dr_set_control): Update.
6856         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6857         (iterate_over_lwps): Use gdb::function_view.
6858         * nat/aarch64-linux-hw-point.c (struct
6859         aarch64_dr_update_callback_param): Remove.
6860         (debug_reg_change_callback): Change type.
6861         (aarch64_notify_debug_reg_change): Update.
6862         * s390-linux-nat.c (s390_refresh_per_info): Update.
6863
6864 2019-03-11  Tom Tromey  <tromey@adacore.com>
6865
6866         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6867         redundant assignment to "this_cu".
6868
6869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6870
6871         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6872
6873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6874
6875         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6876         from...
6877         (rank_one_type): ... this.
6878
6879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6880
6881         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6882         from...
6883         (rank_one_type): ... this.
6884
6885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6886
6887         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6888         from...
6889         (rank_one_type): ... this.
6890
6891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6892
6893         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6894         from...
6895         (rank_one_type): ... this.
6896
6897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6898
6899         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6900         from...
6901         (rank_one_type): ... this.
6902
6903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6904
6905         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6906         from...
6907         (rank_one_type): ... this.
6908
6909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6910
6911         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6912         from...
6913         (rank_one_type): ... this.
6914
6915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6916
6917         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6918         from...
6919         (rank_one_type): ... this.
6920
6921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6922
6923         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6924         from...
6925         (rank_one_type): ... this.
6926
6927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6928
6929         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6930         from...
6931         (rank_one_type): ... this.
6932
6933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6934
6935         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6936         from...
6937         (rank_one_type): ... this.
6938
6939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6940
6941         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6942         from...
6943         (rank_one_type): ... this.
6944
6945 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6946
6947         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6948         inferior-events' shows the example events.
6949
6950 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6951
6952         Support styling on native MS-Windows console
6953
6954         PR/24315
6955         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6956         on MS-Windows if $TERM is not defined.
6957
6958         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6959
6960         * posix-hdep.c (gdb_console_fputs):
6961         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6962         functions.
6963         * ui-file.h (gdb_console_fputs): Add prototype.
6964
6965         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6966         back to fputs only if the former returns zero.
6967
6968 2019-03-07  Tom Tromey  <tom@tromey.com>
6969
6970         * symmisc.c (print_symbol_bcache_statistics): Update.
6971         (print_objfile_statistics): Update.
6972         * symfile.c (allocate_symtab): Update.
6973         * stabsread.c: Don't include bcache.h.
6974         * psymtab.h (struct psymbol_bcache): Don't declare.
6975         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6976         (psymbol_bcache_init, psymbol_bcache_free)
6977         (psymbol_bcache_get_bcache): Don't declare.
6978         * psymtab.c (struct psymbol_bcache): Remove.
6979         (psymtab_storage::psymtab_storage): Update.
6980         (psymtab_storage::~psymtab_storage): Update.
6981         (psymbol_bcache_init, psymbol_bcache_free)
6982         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6983         (add_psymbol_to_bcache): Update.
6984         (allocate_psymtab): Update.
6985         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6986         macro_cache>: No longer pointers.
6987         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6988         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6989         * macrotab.c (macro_bcache): Update.
6990         * macroexp.c: Don't include bcache.h.
6991         * gdbtypes.c (check_types_worklist): Update.
6992         (types_deeply_equal): Remove TRY/CATCH.  Update.
6993         * elfread.c (elf_symtab_read): Update.
6994         * dwarf2read.c: Don't include bcache.h.
6995         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6996         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6997         (print_bcache_statistics, bcache_memory_used): Don't declare.
6998         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6999         methods.  Rename all data members.
7000         * bcache.c (struct bcache): Move to bcache.h.
7001         (bcache::expand_hash_table): Rename from expand_hash_table.
7002         (bcache): Remove.
7003         (bcache::insert): Rename from bcache_full.
7004         (bcache::compare): Rename from bcache_compare.
7005         (bcache_xmalloc): Remove.
7006         (bcache::~bcache): Rename from bcache_xfree.
7007         (bcache::print_statistics): Rename from print_bcache_statistics.
7008         (bcache::memory_used): Rename from bcache_memory_used.
7009
7010 2019-03-07  Pedro Alves  <palves@redhat.com>
7011
7012         * infrun.c (normal_stop): Also check for
7013         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7014
7015 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * f-lang.c (value_from_host_double): Moved to...
7018         * value.c (value_from_host_double): ...here.
7019         * value.h (value_from_host_double): Declare.
7020         * guile/scm-math.c (vlscm_convert_typed_number): Use
7021         value_from_host_double.
7022         (vlscm_convert_number): Likewise.
7023         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7024         * python/py-value.c (convert_value_from_python): Likewise.
7025
7026 2019-03-06  Tom Tromey  <tom@tromey.com>
7027
7028         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7029
7030 2019-03-06  Tom Tromey  <tom@tromey.com>
7031
7032         * utils.h (free_current_contents): Don't declare.
7033         * utils.c (free_current_contents): Remove.
7034
7035 2019-03-06  Tom Tromey  <tom@tromey.com>
7036
7037         * top.c (quit_force): Update.
7038         * main.c (captured_command_loop): Update.
7039         * common/new-op.c (operator new): Update.
7040         * common/common-exceptions.c (struct catcher)
7041         <save_cleanup_chain>: Remove member.
7042         (exceptions_state_mc_init): Update.
7043         (exception_try_scope_entry): Return nullptr.
7044         (exception_try_scope_exit, exception_rethrow)
7045         (throw_exception_sjlj, throw_exception_cxx): Update.
7046         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7047         (all_cleanups, do_cleanups, discard_cleanups)
7048         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7049         (restore_cleanups, restore_final_cleanups): Don't declare.
7050         (do_final_cleanups): Remove parameter.
7051         * common/cleanups.c (cleanup_chain, make_cleanup)
7052         (make_cleanup_dtor, all_cleanups, do_cleanups)
7053         (discard_my_cleanups, discard_cleanups)
7054         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7055         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7056         (null_cleanup): Remove.
7057         (do_final_cleanups): Remove parameter.
7058
7059 2019-03-06  Tom Tromey  <tom@tromey.com>
7060
7061         * remote.c (remote_target::remote_parse_stop_reply): Use
7062         unique_xmalloc_ptr.
7063
7064 2019-03-06  Tom Tromey  <tom@tromey.com>
7065
7066         * stabsread.c (struct stabs_field_info): Rename from field_info.
7067         <list, fnlist>: Add initializers.
7068         <obstack>: New member.
7069         (read_member_functions, read_struct_fields, read_baseclasses):
7070         Allocate on obstack.  Don't use cleanups.
7071         (read_one_struct_field, read_member_functions, read_struct_fields)
7072         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7073         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7074         (read_struct_type): Update.
7075
7076 2019-03-06  Tom Tromey  <tom@tromey.com>
7077
7078         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7079         * common/filestuff.h (make_cleanup_close): Don't declare.
7080         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7081         Remove.
7082
7083 2019-03-06  Tom Tromey  <tom@tromey.com>
7084
7085         * solib-aix.c: Use make_scope_exit.
7086
7087 2019-03-06  Tom Tromey  <tom@tromey.com>
7088
7089         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7090         Use make_scope_exit.
7091
7092 2019-03-06  Tom Tromey  <tom@tromey.com>
7093
7094         * solib-svr4.c (disable_probes_interface): Remove parameter.
7095         (svr4_handle_solib_event): Use make_scope_exit.
7096
7097 2019-03-06  Tom Tromey  <tom@tromey.com>
7098
7099         * remote.c (struct stop_reply_deleter): Remove.
7100         (stop_reply_up): Update.
7101         (struct stop_reply): Derive from notif_event.  Don't typedef.
7102         <regcache>: Now a std::vector.
7103         (stop_reply_xfree): Remove.
7104         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7105         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7106         (remote_target::discard_pending_stop_replies): Use delete.
7107         (remote_target::remote_parse_stop_reply): Update.
7108         (remote_target::process_stop_reply): Update.
7109         * remote-notif.h (struct notif_event): Add virtual destructor.
7110         Remove "dtr" member.
7111         (struct notif_client) <alloc_event>: Return a unique_ptr.
7112         (notif_event_xfree): Don't declare.
7113         (notif_event_up): New typedef.
7114         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7115         (notif_event_xfree, do_notif_event_xfree): Remove.
7116         (remote_notif_state_xfree): Update.
7117
7118 2019-03-06  Tom Tromey  <tom@tromey.com>
7119
7120         * infrun.c (displaced_step_clear_cleanup): Now a
7121         forward_scope_exit type.
7122         (displaced_step_prepare_throw): Update.
7123         (displaced_step_fixup): Update.
7124
7125 2019-03-06  Tom Tromey  <tom@tromey.com>
7126
7127         * inferior.h (class inferior): Update comment.
7128         * gdbthread.h (class thread_info): Update comment.
7129
7130 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7131             Tom Tromey  <tom@tromey.com>
7132
7133         * stabsread.h (struct stab_section_list): Remove.
7134         (coffstab_build_psymtabs): Update.
7135         * dbxread.c (symbuf_sections): Now a std::vector.
7136         (sect_idx): New global.
7137         (fill_symbuf): Update.
7138         (coffstab_build_psymtabs): Change type of stabsects parameter.
7139         Update.
7140         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7141         std::vector.
7142         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7143         (coff_locate_sections): Update.
7144         (coff_symfile_read): Remove cleanups.  Update.
7145         (init_stringtab): Add storage parameter.
7146         (free_stringtab, free_stringtab_cleanup): Remove.
7147         (init_lineno): Add storage parameter.
7148         (free_linetab, free_linetab_cleanup): Remove.
7149
7150 2019-03-06  Pedro Alves  <palves@redhat.com>
7151
7152         * linux-fork.c (fork_info::clobber_regs): Delete.
7153         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7154         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7155         comment.  Adjust.
7156         (scoped_switch_fork_info::scoped_switch_fork_info)
7157         (checkpoint_command, linux_fork_context): Adjust
7158         fork_save_infrun_state calls.
7159
7160 2019-03-06  Pedro Alves  <palves@redhat.com>
7161
7162         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7163         (inf_has_multiple_threads): Return 'bool' and rewrite using
7164         inferior_info::threads().
7165
7166 2019-03-06  Pedro Alves  <palves@redhat.com>
7167
7168         * linux-fork.c: Include <list>.
7169         (fork_list): Now a std::list instance.
7170         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7171         (forks_exist_p, find_last_fork): Adjust.
7172         (new_fork): Delete.
7173         (one_fork_p): New.
7174         (add_fork): Adjust.
7175         (free_fork): Delete, folded into fork_info::~fork_info().
7176         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7177         Adjust.
7178         (init_fork_list): Delete.
7179         (linux_fork_killall, linux_fork_mourn_inferior)
7180         (linux_fork_detach, info_checkpoints_command): Adjust.
7181         (_initialize_linux_fork): No longer call init_fork_list.
7182
7183 2019-03-06  Pedro Alves  <palves@redhat.com>
7184
7185         * linux-fork.c (new_fork): New, split out of ...
7186         (add_fork): ... this.  Return void.  Move "first fork" special
7187         case from here, to ...
7188         (checkpoint_command): ... here.
7189         * linux-linux.h (add_fork): Return void.
7190
7191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7192
7193         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7194
7195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7196             Chris January  <chris.january@arm.com>
7197             David Lecomber  <david.lecomber@arm.com>
7198
7199         * f-exp.y: New token, UNOP_INTRINSIC.
7200         (exp): New pattern using UNOP_INTRINSIC token.
7201         (f77_keywords): Add 'abs' keyword.
7202         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7203         (value_from_host_double): New function.
7204         (evaluate_subexp_f): Support UNOP_ABS.
7205
7206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7207
7208         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7209         types.
7210
7211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7212
7213         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7214         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7215         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7216
7217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7218
7219         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7220
7221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7222             Chris January  <chris.january@arm.com>
7223
7224         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7225         * f-exp.y: Define 'KIND' token.
7226         (exp): New pattern for KIND expressions.
7227         (ptype): Handle types with a kind extension.
7228         (direct_abs_decl): Extend to spot kind extensions.
7229         (f77_keywords): Add 'kind' to the list.
7230         (push_kind_type): New function.
7231         (convert_to_kind_type): New function.
7232         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7233         * parse.c (operator_length_standard): Likewise.
7234         * parser-defs.h (enum type_pieces): Add tp_kind.
7235         * std-operator.def: Add UNOP_KIND.
7236
7237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * f-exp.y (f_parse): Set yydebug.
7240
7241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7242
7243         * f-lang.c (evaluate_subexp_f): New function.
7244         (exp_descriptor_f): New global.
7245         (f_language_defn): Use exp_descriptor_f instead of
7246         exp_descriptor_standard.
7247
7248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * f-exp.y (struct token): Add comments.
7251         (dot_ops): Remove uppercase versions and the end marker.
7252         (f77_keywords): Likewise.
7253         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7254         entries in the dot_ops array are case insensitive, and use
7255         strncasecmp to compare strings.  Also some whitespace cleanup in
7256         this area.  Similar for the f77_keywords array, except entries in
7257         this list might be case sensitive.
7258
7259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * f-exp.y (struct f77_boolean_val): Add comments.
7262         (boolean_values): Remove uppercase versions, and end marker.
7263         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7264         and use strncasecmp to achieve case insensitivity.  Additionally,
7265         perform whitespace cleanup around this code.
7266
7267 2019-03-06  Tom Tromey  <tromey@adacore.com>
7268
7269         * remote-sim.c (gdbsim_target_open): Use result of
7270         gdb_argv::release.
7271
7272 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7273         Dirk Schubert  <dirk.schubert@arm.com>
7274         Chris January  <chris.january@arm.com>
7275
7276         * eval.c (evaluate_subexp_standard): Call Fortran argument
7277         wrapping logic.
7278         * f-lang.c (struct value): A value which can be passed into a
7279         Fortran function call.
7280         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7281         where appropriate.
7282         (struct type): Value ready for a Fortran function call.
7283         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7284         is needed.
7285         * f-lang.h (fortran_argument_convert): Declaration.
7286         (fortran_preserve_arg_pointer): Declaration.
7287         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7288
7289 2019-03-05  Tom Tromey  <tromey@adacore.com>
7290
7291         * python/py-prettyprint.c (print_string_repr): Remove #if.
7292         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7293
7294 2019-03-05  Tom Tromey  <tromey@adacore.com>
7295
7296         * target.c (the_dummy_target): Move later.  Change type to
7297         "dummy_target".
7298         (initialize_targets): Don't initialize the_dummy_target.
7299
7300 2019-03-05  Tom Tromey  <tromey@adacore.com>
7301
7302         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7303         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7304
7305 2019-03-05  Tom Tromey  <tromey@adacore.com>
7306
7307         * windows-nat.c (windows_nat_target::attach)
7308         (windows_nat_target::detach): Don't call gdb_flush.
7309         * valprint.c (generic_val_print, val_print, val_print_string):
7310         Don't call gdb_flush.
7311         * utils.c (defaulted_query): Don't call gdb_flush.
7312         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7313         * target.c (target_announce_detach): Don't call gdb_flush.
7314         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7315         * remote.c (extended_remote_target::attach): Don't call
7316         gdb_flush.
7317         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7318         * printcmd.c (do_examine): Don't call gdb_flush.
7319         (info_display_command): Don't call gdb_flush.
7320         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7321         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7322         * memattr.c (info_mem_command): Don't call gdb_flush.
7323         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7324         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7325         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7326         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7327         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7328         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7329         (gnu_nat_target::detach): Don't call gdb_flush.
7330         * f-valprint.c (f_val_print): Don't call gdb_flush.
7331         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7332         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7333         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7334         gdb_flush.
7335         * c-valprint.c (c_val_print): Don't call gdb_flush.
7336         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7337
7338 2019-03-05  Tom Tromey  <tromey@adacore.com>
7339
7340         * varobj.c (update_dynamic_varobj_children): Update.
7341         (install_default_visualizer): Use reset, not release.
7342         * value.c (set_internalvar): Update.
7343         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7344         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7345         ATTRIBUTE_UNUSED_RESULT.
7346
7347 2019-03-05  Tom Tromey  <tromey@adacore.com>
7348
7349         * remote.c (class scoped_remote_fd) <release>: Add
7350         ATTRIBUTE_UNUSED_RESULT.
7351
7352 2019-03-05  Tom Tromey  <tromey@adacore.com>
7353
7354         * macroexp.c (struct macro_buffer) <release>: Add
7355         ATTRIBUTE_UNUSED_RESULT.
7356
7357 2019-03-05  Tom Tromey  <tromey@adacore.com>
7358
7359         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7360         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7361         ATTRIBUTE_UNUSED_RESULT.
7362
7363 2019-03-05  Tom Tromey  <tromey@adacore.com>
7364
7365         * common/scoped_fd.h (class scoped_fd) <release>: Add
7366         ATTRIBUTE_UNUSED_RESULT.
7367
7368 2019-03-05  Tom Tromey  <tromey@adacore.com>
7369
7370         * parser-defs.h (struct parser_state) <release>: Add
7371         ATTRIBUTE_UNUSED_RESULT.
7372
7373 2019-03-05  Tom Tromey  <tromey@adacore.com>
7374
7375         * utils.h (class gdb_argv) <release>: Add
7376         ATTRIBUTE_UNUSED_RESULT.
7377         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7378
7379 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7380
7381         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7382         for-loop range, to avoid compiler warnings.
7383
7384         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7385         avoid compiler warnings about unused variables.
7386
7387         * NEWS: Mention end of support for native debugging on MS-Windows
7388         before XP.
7389
7390         PR gdb/24292
7391         * common/netstuff.c:
7392         * gdbserver/gdbreplay.c
7393         * gdbserver/remote-utils.c:
7394         * ser-tcp.c:
7395         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7396         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7397         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7398         'getaddrinfo' and 'freeaddrinfo' were not available before
7399         Windows XP, and mingw.org's MinGW headers by default define
7400         _WIN32_WINNT to 0x500.
7401
7402 2019-03-01  Gary Benson <gbenson@redhat.com>
7403
7404         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7405
7406 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7407             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7408
7409         PR gdb/8527
7410         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7411         set_sigint_trap, clear_sigint_trap.
7412
7413 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7414
7415         * target.c (target_detach): Clear the regcache and the
7416         frame cache.
7417
7418 2019-02-27  Pedro Alves  <palves@redhat.com>
7419
7420         * utils.c (set_screen_size): When we cap the height/width sizes,
7421         tweak the corresponding command variable to show "unlimited":
7422
7423 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7424             Pedro Alves  <palves@redhat.com>
7425
7426         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7427         before calling rl_set_screen_size.
7428
7429 2019-02-27  Tom Tromey  <tromey@adacore.com>
7430
7431         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7432         define.
7433         * python/py-value.c: Remove Python 2.4 workaround.
7434         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7435         workaround.
7436         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7437         Python 2.4 workaround.
7438         * python/python-internal.h: Remove Python 2.4 comment.
7439         (Py_ssize_t): Don't define.
7440         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7441         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7442         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7443         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7444         * python/python.c (do_start_initialization): Remove Python 2.4
7445         workaround.
7446         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7447         (print_children): Remove Python 2.4 workaround.
7448         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7449         workaround.
7450         (CHARBUFFERPROC_NAME): Remove.
7451         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7452         Python 2.4 workaround.
7453
7454 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7455
7456         * NEWS: Note minimum Python version.
7457
7458 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7459
7460         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7461         code from these functions.  Remove corresponding ifdefs.  Use
7462         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7463         Remove gotos and target of gotos.
7464         (infpy_search_memory): Likewise.
7465
7466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7469         (hppa_gdbarch_init): Don't register deleted functions with
7470         gdbarch.
7471
7472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7473
7474         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7475         (h8300_unwind_sp): Delete.
7476         (h8300_dummy_id): Delete.
7477         (h8300_gdbarch_init): Don't register deleted functions with
7478         gdbarch.
7479
7480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7483         (ft32_unwind_pc): Delete.
7484         (ft32_unwind_sp): Delete.
7485         (ft32_gdbarch_init): Don't register deleted functions with
7486         gdbarch.
7487
7488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7489
7490         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7491         (frv_unwind_pc): Delete.
7492         (frv_unwind_sp): Delete.
7493         (frv_gdbarch_init): Don't register deleted functions with
7494         gdbarch.
7495
7496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7497
7498         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7499         (riscv_unwind_pc): Delete.
7500         (riscv_unwind_sp): Delete.
7501         (riscv_gdbarch_init): Don't register deleted functions with
7502         gdbarch.
7503
7504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7505
7506         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7507         (csky_unwind_pc): Delete.
7508         (csky_unwind_sp): Delete.
7509         (csky_gdbarch_init): Don't register deleted functions with
7510         gdbarch.
7511
7512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7513
7514         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7515         (cris_unwind_pc): Delete.
7516         (cris_unwind_sp): Delete.
7517         (cris_gdbarch_init): Don't register deleted functions with
7518         gdbarch.
7519
7520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7521
7522         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7523         (bfin_unwind_pc): Delete.
7524         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7525
7526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7527
7528         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7529         (arm_unwind_pc): Delete.
7530         (arm_unwind_sp): Delete.
7531         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7532
7533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7536         (arc_unwind_pc): Delete.
7537         (arc_unwind_sp): Delete.
7538         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7539
7540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7541
7542         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7543         (alpha_unwind_pc): Delete.
7544         (alpha_gdbarch_init): Don't register deleted functions with
7545         gdbarch.
7546
7547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7548
7549         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7550         (aarch64_unwind_pc): Delete.
7551         (aarch64_unwind_sp): Delete.
7552         (aarch64_gdbarch_init): Don't register deleted functions with
7553         gdbarch.
7554
7555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7556
7557         * gdbtypes.c (type_align): Don't consider static members when
7558         computing structure alignment.
7559
7560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7561
7562         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7563         return 0 for other types.
7564         * arch-utils.c (default_type_align): Always return 0.
7565         * gdbarch.h: Regenerate.
7566         * gdbarch.sh (type_align): Extend comment.
7567         * gdbtypes.c (type_align): Add additional comments, always call
7568         gdbarch_type_align before applying the default rules.
7569         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7570         generic code will then apply a suitable default.
7571         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7572         types, return 0 for other types.
7573
7574 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7575
7576         * NEWS: Create a new section for the next release branch.
7577         Rename the section of the current branch, now that it has
7578         been cut.
7579
7580 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7581
7582         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7583         * version.in: Bump version to 8.3.50.DATE-git.
7584
7585 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7586
7587         * aix-thread.c (ptid_cmp): Remove unused variable.
7588         (get_signaled_thread): Likewise.
7589         (store_regs_user_thread): Likewise.
7590         (store_regs_kernel_thread): Likewise.
7591         (fetch_regs_kernel_thread): Remove shadowed variable.
7592
7593 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * features/riscv/32bit-cpu.xml: Add register numbers.
7596         * features/riscv/32bit-fpu.c: Regenerate.
7597         * features/riscv/32bit-fpu.xml: Add register numbers.
7598         * features/riscv/64bit-cpu.xml: Add register numbers.
7599         * features/riscv/64bit-fpu.c: Regenerate.
7600         * features/riscv/64bit-fpu.xml: Add register numbers.
7601
7602 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7603
7604         * NEWS: Mention two argument form of gdb.Value constructor.
7605         * python/py-value.c (convert_buffer_and_type_to_value): New
7606         function.
7607         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7608         Add support for handling an optional second argument.  Call
7609         convert_buffer_and_type_to_value as appropriate.
7610         * python/python-internal.h (Py_buffer_deleter): New struct.
7611         (Py_buffer_up): New typedef.
7612
7613 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7614
7615         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7616         instead of releasing ownership.
7617
7618 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7619
7620         * dwarf2read.c (open_and_init_dwp_file): Call
7621         elf_numsections instead of bfd_count_sections to initialize
7622         dwp_file->num_sections.
7623
7624 2019-02-25  Tom Tromey  <tromey@adacore.com>
7625
7626         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7627
7628 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7629
7630         * gcore.in: Add '--readnever' option when invoking GDB.
7631
7632 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7633
7634         * MAINTAINERS: Update my email address.
7635
7636 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7637
7638         * build-id.c (build_id_to_debug_bfd_1): New function.
7639         (build_id_to_debug_bfd): Look for separate debug file in
7640         sysroot.
7641
7642 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * gdbarch.sh: Update the copyright year range that is placed into
7645         generated files.
7646
7647 2019-02-22  Keith Seitz  <keiths@redhat.com>
7648
7649         PR symtab/23853
7650         * linespec.c (create_sals_line_offset): Search for the default
7651         symtab's filename instead of its fullname.
7652
7653 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7654
7655         * NEWS: Update style defaults.
7656
7657 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7658
7659         * main.c (captured_main_1): Disable styling in batch mode.
7660
7661 2019-02-20  Tom Tromey  <tom@tromey.com>
7662
7663         * symtab.c (symtab_symbol_info): Fix typos.
7664
7665 2019-02-20  Tom Tromey  <tromey@adacore.com>
7666
7667         * findcmd.c (_initialize_mem_search): Use upper case for
7668         metasyntactic variables.
7669
7670 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7671
7672         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7673         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7674
7675 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7676
7677         * top.h (source_file_name): Change to std::string.
7678         * top.c (source_file_name): Likewise.
7679         (command_line_input): Adjust.
7680         * cli/cli-script.c (script_from_file): Adjust.
7681
7682 2019-02-19  Tom Tromey  <tromey@adacore.com>
7683
7684         * ravenscar-thread.c
7685         (ravenscar_thread_target::update_thread_list): Don't call
7686         ada_build_task_list.
7687         * ada-lang.h (ada_build_task_list): Don't declare.
7688         * ada-tasks.c (struct ada_tasks_inferior_data)
7689         <task_list_valid_p>: Now bool.
7690         (read_known_tasks, ada_task_list_changed)
7691         (ada_tasks_invalidate_inferior_data): Update.
7692         (read_known_tasks_array): Return bool.
7693         (read_known_tasks_list): Likewise.
7694         (read_known_tasks): Return void.
7695         (ada_build_task_list): Now static.
7696
7697 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7700         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7701
7702 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7703
7704         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7705         variant for ada_tasks_pspace_data_handle and
7706         ada_tasks_inferior_data_handle.
7707         (ada_tasks_pspace_data_cleanup): New function.
7708         (ada_tasks_inferior_data_cleanup): New function.
7709
7710 2019-02-17  Tom Tromey  <tom@tromey.com>
7711
7712         * macrotab.h (macro_source_fullname): Return a std::string.
7713         * macrotab.c (macro_include, check_for_redefinition)
7714         (macro_undef, macro_lookup_definition, foreach_macro)
7715         (foreach_macro_in_scope): Update.
7716         (macro_source_fullname): Return a std::string.
7717         * macrocmd.c (show_pp_source_pos): Update.
7718
7719 2019-02-17  Tom Tromey  <tom@tromey.com>
7720
7721         * macrocmd.c (show_pp_source_pos): Style the file names.
7722
7723 2019-02-17  Tom Tromey  <tom@tromey.com>
7724
7725         PR tui/24197:
7726         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7727
7728 2019-02-17  Tom Tromey  <tom@tromey.com>
7729
7730         * ada-lang.c (user_select_syms): Use filtered printing.
7731         * utils.c (wrap_style): New global.
7732         (desired_style): Remove.
7733         (emit_style_escape): Add stream parameter.
7734         (set_output_style, reset_terminal_style, prompt_for_continue):
7735         Update.
7736         (flush_wrap_buffer): Only flush gdb_stdout.
7737         (wrap_here): Set wrap_style.
7738         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7739         treat escape sequences as a character.  Change when wrap buffer is
7740         flushed.
7741         (fputs_styled): Do not set the output style when the default is
7742         requested.
7743         * ui-style.h (struct ui_file_style) <is_default>: New method.
7744         * source.c (print_source_lines_base): Emit escape sequences in one
7745         piece.
7746
7747 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7748
7749         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7750         integers and enumeration types.
7751
7752 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7753
7754         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7755         instead of lookup_symbol_in_language
7756         (do_exact_match): New function.
7757         (ada_get_symbol_name_matcher): Return do_exact_match when
7758         doing a verbatim match.
7759
7760 2019-02-15  Tom Tromey  <tromey@adacore.com>
7761
7762         * ravenscar-thread.c (ravenscar_thread_target::resume)
7763         (ravenscar_thread_target::wait): Special case wildcard requests.
7764
7765 2019-02-15  Tom Tromey  <tromey@adacore.com>
7766
7767         * ravenscar-thread.c (base_ptid): Remove.
7768         (struct ravenscar_thread_target) <close>: New method.
7769         <m_base_ptid>: New member.
7770         <update_inferior_ptid, active_task, task_is_currently_active,
7771         runtime_initialized>: Declare methods.
7772         <ravenscar_thread_target>: Add constructor.
7773         (ravenscar_thread_target::task_is_currently_active)
7774         (ravenscar_thread_target::update_inferior_ptid)
7775         (ravenscar_runtime_initialized): Rename.  Now methods.
7776         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7777         (ravenscar_thread_target::update_thread_list): Update.
7778         (ravenscar_thread_target::active_task): Now method.
7779         (ravenscar_thread_target::store_registers)
7780         (ravenscar_thread_target::prepare_to_store)
7781         (ravenscar_thread_target::prepare_to_store)
7782         (ravenscar_thread_target::mourn_inferior): Update.
7783         (ravenscar_inferior_created): Use "new" to create target.
7784         (ravenscar_thread_target::get_ada_task_ptid): Update.
7785         (_initialize_ravenscar): Don't initialize base_ptid.
7786         (ravenscar_ops): Remove global.
7787
7788 2019-02-15  Tom Tromey  <tromey@adacore.com>
7789
7790         * target.h (push_target): Declare new overload.
7791         * target.c (push_target): New overload, taking an rvalue reference.
7792         * remote.c (remote_target::open_1): Use push_target overload.
7793         * corelow.c (core_target_open): Use push_target overload.
7794
7795 2019-02-15  Tom Tromey  <tromey@adacore.com>
7796
7797         * ravenscar-thread.c (is_ravenscar_task)
7798         (ravenscar_task_is_currently_active): Return bool.
7799         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7800         (_initialize_ravenscar): Remove "(void)".
7801         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7802         Return bool.
7803
7804 2019-02-15  Tom Tromey  <tromey@adacore.com>
7805
7806         * ravenscar-thread.c (ravenscar_runtime_initializer)
7807         (has_ravenscar_runtime, get_running_thread_id)
7808         (ravenscar_thread_target::resume): Fix indentation.
7809
7810 2019-02-15  Tom Tromey  <tromey@adacore.com>
7811
7812         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7813         from ravenscar_arch_ops.
7814         (sparc_ravenscar_ops::fetch_registers)
7815         (sparc_ravenscar_ops::store_registers): Now methods.
7816         (sparc_ravenscar_prepare_to_store): Remove.
7817         (sparc_ravenscar_ops): Redefine.
7818         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7819         methods and destructor.  Remove members.
7820         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7821         (ravenscar_thread_target::store_registers)
7822         (ravenscar_thread_target::prepare_to_store): Update.
7823         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7824         Remove.
7825         (struct ppc_ravenscar_powerpc_ops): Derive from
7826         ravenscar_arch_ops.
7827         (ppc_ravenscar_powerpc_ops::fetch_registers)
7828         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7829         (ppc_ravenscar_powerpc_ops): Redefine.
7830         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7831         (ppc_ravenscar_e500_ops::fetch_registers)
7832         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7833         (ppc_ravenscar_e500_ops): Redefine.
7834         * aarch64-ravenscar-thread.c
7835         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7836         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7837         (aarch64_ravenscar_fetch_registers)
7838         (aarch64_ravenscar_store_registers): Now methods.
7839         (aarch64_ravenscar_ops): Redefine.
7840
7841 2019-02-15  Tom Tromey  <tromey@adacore.com>
7842
7843         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7844         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7845         (ravenscar_thread_target::stopped_by_watchpoint)
7846         (ravenscar_thread_target::stopped_data_address)
7847         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7848
7849 2019-02-15  Tom Tromey  <tromey@adacore.com>
7850
7851         * ravenscar-thread.c: Fix some typos.
7852
7853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7854             Tom Tromey  <tromey@adacore.com>
7855
7856         * ada-lang.c (ada_exception_sal): Change addr_string to a
7857         std::string.
7858         (create_ada_exception_catchpoint): Update.
7859
7860 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7861             Tom Tromey  <tromey@adacore.com>
7862
7863         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7864         (bp_location_ops): Remove.
7865         (base_breakpoint_allocate_location): Update.
7866         (free_bp_location): Update.
7867         * ada-lang.c (class ada_catchpoint_location)
7868         <ada_catchpoint_location>: Remove ops parameter.
7869         (ada_catchpoint_location_dtor): Remove.
7870         (ada_catchpoint_location_ops): Remove.
7871         (allocate_location_exception): Update.
7872         * breakpoint.h (struct bp_location_ops): Remove.
7873         (class bp_location) <bp_location>: Remove bp_location_ops
7874         parameter.
7875         <~bp_location>: Add destructor.
7876         <ops>: Remove.
7877
7878 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7879             Pedro Alves  <palves@redhat.com>
7880
7881         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7882         'PATH_MAX'.
7883
7884 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7885             Samuel Thibault  <samuel.thibault@gnu.org>
7886             Thomas Schwinge  <thomas@codesourcery.com>
7887
7888         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7889         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7890
7891 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7892
7893         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7894         (check_empty): Use "const char *".
7895
7896         * gnu-nat.c (gnu_nat_target::detach): Instead of
7897         'detach_inferior (pid)' call
7898         'detach_inferior (find_inferior_pid (pid))'.
7899
7900         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7901         'nat/fork-inferior.o'.
7902         * gnu-nat.c: #include "nat/fork-inferior.h".
7903
7904         * gnu-nat.c (gnu_nat_target::detach): Instead of
7905         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7906         * gnu-nat.h: #include "inf-child.h".
7907         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7908         'i386_gnu_nat_target::fetch_registers'.
7909         (gnu_store_registers): Rename/move to
7910         'i386_gnu_nat_target::store_registers'.
7911
7912         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7913         * gnu-nat.h (mach_thread_info): New function.
7914         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7915
7916         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7917
7918 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7919
7920         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7921
7922 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7923
7924         * windows-nat.c (windows_add_thread): Add new parameter
7925         "main_thread_p" with default value set to false.  Update
7926         function documentation as well as all callers.
7927         (windows_delete_thread): Likewise.
7928         (fake_create_process): Update call to windows_add_thread.
7929         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7930         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7931         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7932         call to windows_delete_thread.
7933
7934 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7935
7936         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7937
7938 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7939
7940         * symfile.c (find_separate_debug_file): Use canonical path of
7941         sysroot with child_path instead of gdb_sysroot if it is valid.
7942
7943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7944
7945         * symfile.c (find_separate_debug_file): Use child_path to
7946         determine if an object file is under a sysroot.
7947
7948 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7949
7950         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7951         unittests/child-path-selftests.c.
7952         * common/pathstuff.c (child_path): New function.
7953         * common/pathstuff.h (child_path): New prototype.
7954         * unittests/child-path-selftests.c: New file.
7955
7956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7957
7958         * symfile.c (find_separate_debug_file): Look for separate debug
7959         files in debug directories under the sysroot.
7960
7961 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7962
7963         * symtab.h (struct minimal_symbol data_p): New const method.
7964         (struct minimal_symbol text_p): Likewise.
7965         * symtab.c (output_source_filename): Use file name style
7966         to print file name.
7967         (print_symbol_info): Likewise.
7968         (print_msymbol_info): Use address style to print addresses.
7969         Use function name style to print executable text symbols.
7970         (expand_symtab_containing_pc): Use data_p.
7971         (find_pc_sect_compunit_symtab): Likewise.
7972
7973 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7974
7975         * breakpoint.c (describe_other_breakpoints): Use address style
7976         to print addresses.
7977         (say_where): Likewise.
7978
7979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7980
7981         * ada-typeprint.c (print_func_type): Print function name
7982         style to print function name.
7983         * c-typeprint.c (c_print_type_1): Likewise.
7984
7985 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7986
7987         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7988         for execve.
7989
7990 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7991
7992         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7993         type_stack.
7994
7995 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7996
7997         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7998         TYPE_CODE_REF types.
7999
8000 2019-02-08  Jim Wilson  <jimw@sifive.com>
8001
8002         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8003         (riscv_linux_fregset): New.
8004         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8005
8006 2019-02-07  Tom Tromey  <tom@tromey.com>
8007
8008         * thread.c (thread_cancel_execution_command): Update.
8009         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8010         methods.
8011         (struct thread_fsm_ops): Remove.
8012         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8013         (thread_fsm_should_stop, thread_fsm_return_value)
8014         (thread_fsm_set_finished, thread_fsm_finished_p)
8015         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8016         Don't declare.
8017         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8018         * infrun.c (clear_proceed_status_thread)
8019         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8020         (print_stop_event): Update.
8021         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8022         Add constructor.
8023         (step_command_fsm_ops): Remove.
8024         (new_step_command_fsm): Remove.
8025         (step_1): Update.
8026         (step_command_fsm::should_stop): Rename from
8027         step_command_fsm_should_stop.
8028         (step_command_fsm::clean_up): Rename from
8029         step_command_fsm_clean_up.
8030         (step_command_fsm::do_async_reply_reason): Rename from
8031         step_command_fsm_async_reply_reason.
8032         (struct until_next_fsm): Inherit from thread_fsm.  Add
8033         constructor.
8034         (until_next_fsm_ops): Remove.
8035         (new_until_next_fsm): Remove.
8036         (until_next_fsm::should_stop): Rename from
8037         until_next_fsm_should_stop.
8038         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8039         (until_next_fsm::do_async_reply_reason): Rename from
8040         until_next_fsm_async_reply_reason.
8041         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8042         constructor.  Change type of breakpoint.
8043         (finish_command_fsm_ops): Remove.
8044         (new_finish_command_fsm): Remove.
8045         (finish_command_fsm::should_stop): Rename from
8046         finish_command_fsm_should_stop.
8047         (finish_command_fsm::clean_up): Rename from
8048         finish_command_fsm_clean_up.
8049         (finish_command_fsm::return_value): Rename from
8050         finish_command_fsm_return_value.
8051         (finish_command_fsm::do_async_reply_reason): Rename from
8052         finish_command_fsm_async_reply_reason.
8053         (finish_command): Update.
8054         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8055         Add constructor.
8056         (call_thread_fsm_ops): Remove.
8057         (call_thread_fsm::call_thread_fsm): Rename from
8058         new_call_thread_fsm.
8059         (call_thread_fsm::should_stop): Rename from
8060         call_thread_fsm_should_stop.
8061         (call_thread_fsm::should_notify_stop): Rename from
8062         call_thread_fsm_should_notify_stop.
8063         (run_inferior_call, call_function_by_hand_dummy): Update.
8064         * cli/cli-interp.c (should_print_stop_to_console): Update.
8065         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8066         Add constructor.  Change type of location_breakpoint,
8067         caller_breakpoint.
8068         (until_break_fsm_ops): Remove.
8069         (new_until_break_fsm): Remove.
8070         (until_break_fsm::should_stop): Rename from
8071         until_break_fsm_should_stop.
8072         (until_break_fsm::clean_up): Rename from
8073         until_break_fsm_clean_up.
8074         (until_break_fsm::do_async_reply_reason): Rename from
8075         until_break_fsm_async_reply_reason.
8076         (until_break_command): Update.
8077         * thread-fsm.c: Remove.
8078         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8079
8080 2019-02-07  Tom Tromey  <tom@tromey.com>
8081
8082         * yy-remap.h: Add include guard.
8083         * xtensa-tdep.h: Add include guard.
8084         * xcoffread.h: Rename include guard.
8085         * varobj-iter.h: Add include guard.
8086         * tui/tui.h: Rename include guard.
8087         * tui/tui-winsource.h: Rename include guard.
8088         * tui/tui-wingeneral.h: Rename include guard.
8089         * tui/tui-windata.h: Rename include guard.
8090         * tui/tui-win.h: Rename include guard.
8091         * tui/tui-stack.h: Rename include guard.
8092         * tui/tui-source.h: Rename include guard.
8093         * tui/tui-regs.h: Rename include guard.
8094         * tui/tui-out.h: Rename include guard.
8095         * tui/tui-layout.h: Rename include guard.
8096         * tui/tui-io.h: Rename include guard.
8097         * tui/tui-hooks.h: Rename include guard.
8098         * tui/tui-file.h: Rename include guard.
8099         * tui/tui-disasm.h: Rename include guard.
8100         * tui/tui-data.h: Rename include guard.
8101         * tui/tui-command.h: Rename include guard.
8102         * tic6x-tdep.h: Add include guard.
8103         * target/waitstatus.h: Rename include guard.
8104         * target/wait.h: Rename include guard.
8105         * target/target.h: Rename include guard.
8106         * target/resume.h: Rename include guard.
8107         * target-float.h: Rename include guard.
8108         * stabsread.h: Add include guard.
8109         * rs6000-tdep.h: Add include guard.
8110         * riscv-fbsd-tdep.h: Add include guard.
8111         * regformats/regdef.h: Rename include guard.
8112         * record.h: Rename include guard.
8113         * python/python.h: Rename include guard.
8114         * python/python-internal.h: Rename include guard.
8115         * python/py-stopevent.h: Rename include guard.
8116         * python/py-ref.h: Rename include guard.
8117         * python/py-record.h: Rename include guard.
8118         * python/py-record-full.h: Rename include guard.
8119         * python/py-record-btrace.h: Rename include guard.
8120         * python/py-instruction.h: Rename include guard.
8121         * python/py-events.h: Rename include guard.
8122         * python/py-event.h: Rename include guard.
8123         * procfs.h: Add include guard.
8124         * proc-utils.h: Add include guard.
8125         * p-lang.h: Add include guard.
8126         * or1k-tdep.h: Rename include guard.
8127         * observable.h: Rename include guard.
8128         * nto-tdep.h: Rename include guard.
8129         * nat/x86-linux.h: Rename include guard.
8130         * nat/x86-linux-dregs.h: Rename include guard.
8131         * nat/x86-gcc-cpuid.h: Add include guard.
8132         * nat/x86-dregs.h: Rename include guard.
8133         * nat/x86-cpuid.h: Rename include guard.
8134         * nat/ppc-linux.h: Rename include guard.
8135         * nat/mips-linux-watch.h: Rename include guard.
8136         * nat/linux-waitpid.h: Rename include guard.
8137         * nat/linux-ptrace.h: Rename include guard.
8138         * nat/linux-procfs.h: Rename include guard.
8139         * nat/linux-osdata.h: Rename include guard.
8140         * nat/linux-nat.h: Rename include guard.
8141         * nat/linux-namespaces.h: Rename include guard.
8142         * nat/linux-btrace.h: Rename include guard.
8143         * nat/glibc_thread_db.h: Rename include guard.
8144         * nat/gdb_thread_db.h: Rename include guard.
8145         * nat/gdb_ptrace.h: Rename include guard.
8146         * nat/fork-inferior.h: Rename include guard.
8147         * nat/amd64-linux-siginfo.h: Rename include guard.
8148         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8149         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8150         * nat/aarch64-linux.h: Rename include guard.
8151         * nat/aarch64-linux-hw-point.h: Rename include guard.
8152         * mn10300-tdep.h: Add include guard.
8153         * mips-linux-tdep.h: Add include guard.
8154         * mi/mi-parse.h: Rename include guard.
8155         * mi/mi-out.h: Rename include guard.
8156         * mi/mi-main.h: Rename include guard.
8157         * mi/mi-interp.h: Rename include guard.
8158         * mi/mi-getopt.h: Rename include guard.
8159         * mi/mi-console.h: Rename include guard.
8160         * mi/mi-common.h: Rename include guard.
8161         * mi/mi-cmds.h: Rename include guard.
8162         * mi/mi-cmd-break.h: Rename include guard.
8163         * m2-lang.h: Add include guard.
8164         * location.h: Rename include guard.
8165         * linux-record.h: Rename include guard.
8166         * linux-nat.h: Add include guard.
8167         * linux-fork.h: Add include guard.
8168         * i386-darwin-tdep.h: Rename include guard.
8169         * hppa-linux-offsets.h: Add include guard.
8170         * guile/guile.h: Rename include guard.
8171         * guile/guile-internal.h: Rename include guard.
8172         * gnu-nat.h: Rename include guard.
8173         * gdb-stabs.h: Rename include guard.
8174         * frv-tdep.h: Add include guard.
8175         * f-lang.h: Add include guard.
8176         * event-loop.h: Add include guard.
8177         * darwin-nat.h: Rename include guard.
8178         * cp-abi.h: Rename include guard.
8179         * config/sparc/nm-sol2.h: Rename include guard.
8180         * config/nm-nto.h: Rename include guard.
8181         * config/nm-linux.h: Add include guard.
8182         * config/i386/nm-i386gnu.h: Rename include guard.
8183         * config/djgpp/nl_types.h: Rename include guard.
8184         * config/djgpp/langinfo.h: Rename include guard.
8185         * compile/gcc-cp-plugin.h: Add include guard.
8186         * compile/gcc-c-plugin.h: Add include guard.
8187         * compile/compile.h: Rename include guard.
8188         * compile/compile-object-run.h: Rename include guard.
8189         * compile/compile-object-load.h: Rename include guard.
8190         * compile/compile-internal.h: Rename include guard.
8191         * compile/compile-cplus.h: Rename include guard.
8192         * compile/compile-c.h: Rename include guard.
8193         * common/xml-utils.h: Rename include guard.
8194         * common/x86-xstate.h: Rename include guard.
8195         * common/version.h: Rename include guard.
8196         * common/vec.h: Rename include guard.
8197         * common/tdesc.h: Rename include guard.
8198         * common/selftest.h: Rename include guard.
8199         * common/scoped_restore.h: Rename include guard.
8200         * common/scoped_mmap.h: Rename include guard.
8201         * common/scoped_fd.h: Rename include guard.
8202         * common/safe-iterator.h: Rename include guard.
8203         * common/run-time-clock.h: Rename include guard.
8204         * common/refcounted-object.h: Rename include guard.
8205         * common/queue.h: Rename include guard.
8206         * common/ptid.h: Rename include guard.
8207         * common/print-utils.h: Rename include guard.
8208         * common/preprocessor.h: Rename include guard.
8209         * common/pathstuff.h: Rename include guard.
8210         * common/observable.h: Rename include guard.
8211         * common/netstuff.h: Rename include guard.
8212         * common/job-control.h: Rename include guard.
8213         * common/host-defs.h: Rename include guard.
8214         * common/gdb_wait.h: Rename include guard.
8215         * common/gdb_vecs.h: Rename include guard.
8216         * common/gdb_unlinker.h: Rename include guard.
8217         * common/gdb_unique_ptr.h: Rename include guard.
8218         * common/gdb_tilde_expand.h: Rename include guard.
8219         * common/gdb_sys_time.h: Rename include guard.
8220         * common/gdb_string_view.h: Rename include guard.
8221         * common/gdb_splay_tree.h: Rename include guard.
8222         * common/gdb_setjmp.h: Rename include guard.
8223         * common/gdb_ref_ptr.h: Rename include guard.
8224         * common/gdb_optional.h: Rename include guard.
8225         * common/gdb_locale.h: Rename include guard.
8226         * common/gdb_assert.h: Rename include guard.
8227         * common/filtered-iterator.h: Rename include guard.
8228         * common/filestuff.h: Rename include guard.
8229         * common/fileio.h: Rename include guard.
8230         * common/environ.h: Rename include guard.
8231         * common/common-utils.h: Rename include guard.
8232         * common/common-types.h: Rename include guard.
8233         * common/common-regcache.h: Rename include guard.
8234         * common/common-inferior.h: Rename include guard.
8235         * common/common-gdbthread.h: Rename include guard.
8236         * common/common-exceptions.h: Rename include guard.
8237         * common/common-defs.h: Rename include guard.
8238         * common/common-debug.h: Rename include guard.
8239         * common/cleanups.h: Rename include guard.
8240         * common/buffer.h: Rename include guard.
8241         * common/btrace-common.h: Rename include guard.
8242         * common/break-common.h: Rename include guard.
8243         * cli/cli-utils.h: Rename include guard.
8244         * cli/cli-style.h: Rename include guard.
8245         * cli/cli-setshow.h: Rename include guard.
8246         * cli/cli-script.h: Rename include guard.
8247         * cli/cli-interp.h: Rename include guard.
8248         * cli/cli-decode.h: Rename include guard.
8249         * cli/cli-cmds.h: Rename include guard.
8250         * charset-list.h: Add include guard.
8251         * buildsym-legacy.h: Rename include guard.
8252         * bfin-tdep.h: Add include guard.
8253         * ax.h: Rename include guard.
8254         * arm-linux-tdep.h: Add include guard.
8255         * arm-fbsd-tdep.h: Add include guard.
8256         * arch/xtensa.h: Rename include guard.
8257         * arch/tic6x.h: Add include guard.
8258         * arch/i386.h: Add include guard.
8259         * arch/arm.h: Rename include guard.
8260         * arch/arm-linux.h: Rename include guard.
8261         * arch/arm-get-next-pcs.h: Rename include guard.
8262         * arch/amd64.h: Add include guard.
8263         * arch/aarch64-insn.h: Rename include guard.
8264         * arch-utils.h: Rename include guard.
8265         * annotate.h: Add include guard.
8266         * amd64-darwin-tdep.h: Rename include guard.
8267         * aarch64-linux-tdep.h: Add include guard.
8268         * aarch64-fbsd-tdep.h: Add include guard.
8269         * aarch32-linux-nat.h: Add include guard.
8270
8271 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8272
8273         * macrotab.c (macro_define_internal): New function that
8274         factorizes macro_define_object_internal and macro_define_function
8275         code.
8276         (macro_define_object_internal): Use macro_define_internal.
8277         (macro_define_function): Likewise.
8278
8279 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8280
8281         * macrocmd.c (extract_identifier): Return
8282         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8283         callers.
8284
8285 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8286
8287         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8288
8289 2019-02-05  Tom Tromey  <tom@tromey.com>
8290
8291         * target.c (target_stack::unpush): Move assertion earlier.
8292
8293 2019-01-30  Tom Tromey  <tom@tromey.com>
8294
8295         PR python/23615:
8296         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8297         (gdbpy_parse_and_eval): Likewise.
8298         * python/python-internal.h (gdbpy_allow_threads): New class.
8299
8300 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8301
8302         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8303         (aarch64_fbsd_fpregmap): Move earlier.
8304         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8305         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8306         instead of individual calls to trad_frame_set_reg_addr.
8307         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8308         earlier.
8309         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8310         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8311         instead of individual calls to trad_frame_set_reg_addr.
8312
8313 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8314
8315         * CONTRIBUTE: Replace contribution list with wiki link.
8316
8317 2019-01-25  Tom Tromey  <tom@tromey.com>
8318
8319         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8320
8321 2019-01-25  Tom Tromey  <tom@tromey.com>
8322
8323         * xtensa-linux-nat.c: Fix common/ includes.
8324         * xml-support.h: Fix common/ includes.
8325         * xml-support.c: Fix common/ includes.
8326         * x86-linux-nat.c: Fix common/ includes.
8327         * windows-nat.c: Fix common/ includes.
8328         * varobj.h: Fix common/ includes.
8329         * varobj.c: Fix common/ includes.
8330         * value.c: Fix common/ includes.
8331         * valops.c: Fix common/ includes.
8332         * utils.c: Fix common/ includes.
8333         * unittests/xml-utils-selftests.c: Fix common/ includes.
8334         * unittests/utils-selftests.c: Fix common/ includes.
8335         * unittests/unpack-selftests.c: Fix common/ includes.
8336         * unittests/tracepoint-selftests.c: Fix common/ includes.
8337         * unittests/style-selftests.c: Fix common/ includes.
8338         * unittests/string_view-selftests.c: Fix common/ includes.
8339         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8340         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8341         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8342         * unittests/rsp-low-selftests.c: Fix common/ includes.
8343         * unittests/parse-connection-spec-selftests.c: Fix common/
8344         includes.
8345         * unittests/optional-selftests.c: Fix common/ includes.
8346         * unittests/offset-type-selftests.c: Fix common/ includes.
8347         * unittests/observable-selftests.c: Fix common/ includes.
8348         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8349         * unittests/memrange-selftests.c: Fix common/ includes.
8350         * unittests/memory-map-selftests.c: Fix common/ includes.
8351         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8352         * unittests/function-view-selftests.c: Fix common/ includes.
8353         * unittests/environ-selftests.c: Fix common/ includes.
8354         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8355         * unittests/common-utils-selftests.c: Fix common/ includes.
8356         * unittests/cli-utils-selftests.c: Fix common/ includes.
8357         * unittests/array-view-selftests.c: Fix common/ includes.
8358         * ui-file.c: Fix common/ includes.
8359         * tui/tui-io.c: Fix common/ includes.
8360         * tracepoint.h: Fix common/ includes.
8361         * tracepoint.c: Fix common/ includes.
8362         * tracefile-tfile.c: Fix common/ includes.
8363         * top.h: Fix common/ includes.
8364         * top.c: Fix common/ includes.
8365         * thread.c: Fix common/ includes.
8366         * target/waitstatus.h: Fix common/ includes.
8367         * target/waitstatus.c: Fix common/ includes.
8368         * target.h: Fix common/ includes.
8369         * target.c: Fix common/ includes.
8370         * target-memory.c: Fix common/ includes.
8371         * target-descriptions.c: Fix common/ includes.
8372         * symtab.h: Fix common/ includes.
8373         * symfile.c: Fix common/ includes.
8374         * stap-probe.c: Fix common/ includes.
8375         * spu-linux-nat.c: Fix common/ includes.
8376         * sparc-nat.c: Fix common/ includes.
8377         * source.c: Fix common/ includes.
8378         * solib.c: Fix common/ includes.
8379         * solib-target.c: Fix common/ includes.
8380         * ser-unix.c: Fix common/ includes.
8381         * ser-tcp.c: Fix common/ includes.
8382         * ser-pipe.c: Fix common/ includes.
8383         * ser-base.c: Fix common/ includes.
8384         * selftest-arch.c: Fix common/ includes.
8385         * s12z-tdep.c: Fix common/ includes.
8386         * rust-exp.y: Fix common/ includes.
8387         * rs6000-aix-tdep.c: Fix common/ includes.
8388         * riscv-tdep.c: Fix common/ includes.
8389         * remote.c: Fix common/ includes.
8390         * remote-notif.h: Fix common/ includes.
8391         * remote-fileio.h: Fix common/ includes.
8392         * remote-fileio.c: Fix common/ includes.
8393         * regcache.h: Fix common/ includes.
8394         * regcache.c: Fix common/ includes.
8395         * record-btrace.c: Fix common/ includes.
8396         * python/python.c: Fix common/ includes.
8397         * python/py-type.c: Fix common/ includes.
8398         * python/py-inferior.c: Fix common/ includes.
8399         * progspace.h: Fix common/ includes.
8400         * producer.c: Fix common/ includes.
8401         * procfs.c: Fix common/ includes.
8402         * proc-api.c: Fix common/ includes.
8403         * printcmd.c: Fix common/ includes.
8404         * ppc-linux-nat.c: Fix common/ includes.
8405         * parser-defs.h: Fix common/ includes.
8406         * osdata.c: Fix common/ includes.
8407         * obsd-nat.c: Fix common/ includes.
8408         * nat/x86-linux.c: Fix common/ includes.
8409         * nat/x86-linux-dregs.c: Fix common/ includes.
8410         * nat/x86-dregs.h: Fix common/ includes.
8411         * nat/x86-dregs.c: Fix common/ includes.
8412         * nat/ppc-linux.c: Fix common/ includes.
8413         * nat/mips-linux-watch.h: Fix common/ includes.
8414         * nat/mips-linux-watch.c: Fix common/ includes.
8415         * nat/linux-waitpid.c: Fix common/ includes.
8416         * nat/linux-ptrace.h: Fix common/ includes.
8417         * nat/linux-ptrace.c: Fix common/ includes.
8418         * nat/linux-procfs.c: Fix common/ includes.
8419         * nat/linux-personality.c: Fix common/ includes.
8420         * nat/linux-osdata.c: Fix common/ includes.
8421         * nat/linux-namespaces.c: Fix common/ includes.
8422         * nat/linux-btrace.h: Fix common/ includes.
8423         * nat/linux-btrace.c: Fix common/ includes.
8424         * nat/fork-inferior.c: Fix common/ includes.
8425         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8426         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8427         * nat/aarch64-linux.c: Fix common/ includes.
8428         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8429         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8430         * namespace.h: Fix common/ includes.
8431         * mips-linux-tdep.c: Fix common/ includes.
8432         * minsyms.c: Fix common/ includes.
8433         * mi/mi-parse.h: Fix common/ includes.
8434         * mi/mi-main.c: Fix common/ includes.
8435         * mi/mi-cmd-env.c: Fix common/ includes.
8436         * memrange.h: Fix common/ includes.
8437         * memattr.c: Fix common/ includes.
8438         * maint.h: Fix common/ includes.
8439         * maint.c: Fix common/ includes.
8440         * main.c: Fix common/ includes.
8441         * machoread.c: Fix common/ includes.
8442         * location.c: Fix common/ includes.
8443         * linux-thread-db.c: Fix common/ includes.
8444         * linux-nat.c: Fix common/ includes.
8445         * linux-fork.c: Fix common/ includes.
8446         * inline-frame.c: Fix common/ includes.
8447         * infrun.c: Fix common/ includes.
8448         * inflow.c: Fix common/ includes.
8449         * inferior.h: Fix common/ includes.
8450         * inferior.c: Fix common/ includes.
8451         * infcmd.c: Fix common/ includes.
8452         * inf-ptrace.c: Fix common/ includes.
8453         * inf-child.c: Fix common/ includes.
8454         * ia64-linux-nat.c: Fix common/ includes.
8455         * i387-tdep.c: Fix common/ includes.
8456         * i386-tdep.c: Fix common/ includes.
8457         * i386-linux-tdep.c: Fix common/ includes.
8458         * i386-linux-nat.c: Fix common/ includes.
8459         * i386-go32-tdep.c: Fix common/ includes.
8460         * i386-fbsd-tdep.c: Fix common/ includes.
8461         * i386-fbsd-nat.c: Fix common/ includes.
8462         * guile/scm-type.c: Fix common/ includes.
8463         * guile/guile.c: Fix common/ includes.
8464         * go32-nat.c: Fix common/ includes.
8465         * gnu-nat.c: Fix common/ includes.
8466         * gdbthread.h: Fix common/ includes.
8467         * gdbarch-selftests.c: Fix common/ includes.
8468         * gdb_usleep.c: Fix common/ includes.
8469         * gdb_select.h: Fix common/ includes.
8470         * gdb_bfd.c: Fix common/ includes.
8471         * gcore.c: Fix common/ includes.
8472         * fork-child.c: Fix common/ includes.
8473         * findvar.c: Fix common/ includes.
8474         * fbsd-nat.c: Fix common/ includes.
8475         * event-top.c: Fix common/ includes.
8476         * event-loop.c: Fix common/ includes.
8477         * dwarf2read.c: Fix common/ includes.
8478         * dwarf2loc.c: Fix common/ includes.
8479         * dwarf2-frame.c: Fix common/ includes.
8480         * dwarf-index-cache.c: Fix common/ includes.
8481         * dtrace-probe.c: Fix common/ includes.
8482         * disasm-selftests.c: Fix common/ includes.
8483         * defs.h: Fix common/ includes.
8484         * csky-tdep.c: Fix common/ includes.
8485         * cp-valprint.c: Fix common/ includes.
8486         * cp-support.h: Fix common/ includes.
8487         * cp-support.c: Fix common/ includes.
8488         * corelow.c: Fix common/ includes.
8489         * completer.h: Fix common/ includes.
8490         * completer.c: Fix common/ includes.
8491         * compile/compile.c: Fix common/ includes.
8492         * compile/compile-loc2c.c: Fix common/ includes.
8493         * compile/compile-cplus-types.c: Fix common/ includes.
8494         * compile/compile-cplus-symbols.c: Fix common/ includes.
8495         * command.h: Fix common/ includes.
8496         * cli/cli-dump.c: Fix common/ includes.
8497         * cli/cli-cmds.c: Fix common/ includes.
8498         * charset.c: Fix common/ includes.
8499         * build-id.c: Fix common/ includes.
8500         * btrace.h: Fix common/ includes.
8501         * btrace.c: Fix common/ includes.
8502         * breakpoint.h: Fix common/ includes.
8503         * breakpoint.c: Fix common/ includes.
8504         * ax.h:
8505         (enum agent_op): Fix common/ includes.
8506         * ax-general.c (struct aop_map): Fix common/ includes.
8507         * ax-gdb.c: Fix common/ includes.
8508         * auxv.c: Fix common/ includes.
8509         * auto-load.c: Fix common/ includes.
8510         * arm-tdep.c: Fix common/ includes.
8511         * arch/riscv.c: Fix common/ includes.
8512         * arch/ppc-linux-common.c: Fix common/ includes.
8513         * arch/i386.c: Fix common/ includes.
8514         * arch/arm.c: Fix common/ includes.
8515         * arch/arm-linux.c: Fix common/ includes.
8516         * arch/arm-get-next-pcs.c: Fix common/ includes.
8517         * arch/amd64.c: Fix common/ includes.
8518         * arch/aarch64.c: Fix common/ includes.
8519         * arch/aarch64-insn.c: Fix common/ includes.
8520         * arch-utils.c: Fix common/ includes.
8521         * amd64-windows-tdep.c: Fix common/ includes.
8522         * amd64-tdep.c: Fix common/ includes.
8523         * amd64-sol2-tdep.c: Fix common/ includes.
8524         * amd64-obsd-tdep.c: Fix common/ includes.
8525         * amd64-nbsd-tdep.c: Fix common/ includes.
8526         * amd64-linux-tdep.c: Fix common/ includes.
8527         * amd64-linux-nat.c: Fix common/ includes.
8528         * amd64-fbsd-tdep.c: Fix common/ includes.
8529         * amd64-fbsd-nat.c: Fix common/ includes.
8530         * amd64-dicos-tdep.c: Fix common/ includes.
8531         * amd64-darwin-tdep.c: Fix common/ includes.
8532         * agent.c: Fix common/ includes.
8533         * ada-lang.h: Fix common/ includes.
8534         * ada-lang.c: Fix common/ includes.
8535         * aarch64-tdep.c: Fix common/ includes.
8536
8537 2019-01-25  Tom Tromey  <tom@tromey.com>
8538
8539         * common/create-version.sh: Use common/version.h.
8540
8541 2019-01-24  Pedro Alves  <palves@redhat.com>
8542
8543         * infrun.c (signal_stop, signal_print, signal_program)
8544         (signal_catch, signal_pass): Now arrays instead of pointers.
8545         (update_signals_program_target, do_target_resume)
8546         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8547         * linux-nat.c (linux_nat_target::pass_signals)
8548         (linux_nat_target::create_inferior, linux_nat_target::attach):
8549         Adjust.
8550         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8551         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8552         * procfs.c (procfs_target::pass_signals): Adjust.
8553         * record-full.c (record_full_target::resume): Adjust.
8554         * remote.c (remote_target::pass_signals)
8555         (remote_target::program_signals): Adjust.
8556         * target-debug.h (target_debug_print_signals): Now takes a
8557         gdb::array_view as parameter.  Adjust.
8558         * target.h (target_ops) <pass_signals, program_signals>: Replace
8559         pointer and length parameters with gdb::array_view.
8560         (target_pass_signals, target_program_signals): Likewise.
8561         * target-delegates.c: Regenerate.
8562
8563 2019-01-24  Pedro Alves  <palves@redhat.com>
8564
8565         * common/forward-scope-exit.h
8566         (forward_scope_exit::forward_scope_exit): Pass arguments to
8567         m_bind_function directly, instead of creating a std::bind and
8568         copying that.
8569
8570 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8571
8572         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8573         for static members.
8574         (pass_in_v_vfp_candidate): Likewise.
8575
8576 2019-01-23  Tom Tromey  <tom@tromey.com>
8577             Pedro Alves  <palves@redhat.com>
8578
8579         * regcache.c (class regcache_invalidator): Remove.
8580         (regcache::raw_write): Use make_scope_exit.
8581
8582 2019-01-23  Tom Tromey  <tom@tromey.com>
8583
8584         * ui-out.h (class ui_out_emit_type): Update comment.
8585
8586 2019-01-23  Tom Tromey  <tom@tromey.com>
8587
8588         * infrun.c (fetch_inferior_event): Update comment.
8589
8590 2019-01-23  Tom Tromey  <tom@tromey.com>
8591             Pedro Alves  <palves@redhat.com>
8592
8593         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8594         parameter.
8595         (fetch_inferior_event): Use SCOPE_EXIT.
8596
8597
8598 2019-01-23  Tom Tromey  <tom@tromey.com>
8599             Pedro Alves  <palves@redhat.com>
8600
8601         * infrun.c (disable_thread_events): Delete.
8602         (stop_all_threads): Use SCOPE_EXIT.
8603
8604 2019-01-23  Tom Tromey  <tom@tromey.com>
8605             Pedro Alves  <palves@redhat.com>
8606
8607         * symfile.c: Include forward-scope-exit.h.
8608         (clear_symtab_users_cleanup): Replace forward declaration with
8609         a FORWARD_SCOPE_EXIT.
8610         (syms_from_objfile_1): Use the forward_scope_exit and
8611         gdb::optional instead of cleanup_function.
8612         (reread_symbols): Use the forward_scope_exit instead of
8613         cleanup_function.
8614         (clear_symtab_users_cleanup): Remove function.
8615
8616 2019-01-23  Tom Tromey  <tom@tromey.com>
8617             Pedro Alves  <palves@redhat.com>
8618
8619         * linux-nat.c: Include scope-exit.h.
8620         (cleanup_target_stop): Remove.
8621         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8622         SCOPE_EXIT.
8623
8624 2019-01-23  Tom Tromey  <tom@tromey.com>
8625             Pedro Alves  <palves@redhat.com>
8626
8627         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8628         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8629
8630 2019-01-23  Tom Tromey  <tom@tromey.com>
8631             Andrew Burgess  <andrew.burgess@embecosm.com>
8632             Pedro Alves  <palves@redhat.com>
8633
8634         * infrun.c (fetch_inferior_event): Use scope_exit.
8635         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8636         * top.c (execute_command): Use scope_exit.
8637         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8638         * utils.c (do_bpstat_clear_actions_cleanup)
8639         (make_bpstat_clear_actions_cleanup): Remove.
8640
8641 2019-01-23  Tom Tromey  <tom@tromey.com>
8642             Pedro Alves  <palves@redhat.com>
8643
8644         * infrun.c: Include "common/scope-exit.h"
8645         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8646         (wait_for_inferior): Use SCOPE_EXIT.
8647         (fetch_inferior_event): Use scope_exit.
8648
8649 2019-01-23  Tom Tromey  <tom@tromey.com>
8650             Pedro Alves  <palves@redhat.com>
8651
8652         * breakpoint.c (create_breakpoint): Remove cleanup.
8653
8654 2019-01-23  Tom Tromey  <tom@tromey.com>
8655             Andrew Burgess  <andrew.burgess@embecosm.com>
8656             Pedro Alves  <palves@redhat.com>
8657
8658 2019-01-23  Pedro Alves  <palves@redhat.com>
8659
8660         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8661
8662 2019-01-23  Pedro Alves  <palves@redhat.com>
8663             Andrew Burgess  <andrew.burgess@embecosm.com>
8664
8665         * gdbthread.h: Include "common/forward-scope-exit.h".
8666         (scoped_finish_thread_state): Redefine custom class in terms of
8667         forward_scope_exit.
8668
8669 2019-01-23  Pedro Alves  <palves@redhat.com>
8670             Andrew Burgess  <andrew.burgess@embecosm.com>
8671
8672         * common/forward-scope-exit.h: New file.
8673
8674 2019-01-23  Pedro Alves  <palves@redhat.com>
8675             Andrew Burgess  <andrew.burgess@embecosm.com>
8676             Tom Tromey  <tom@tromey.com>
8677
8678         * common/scope-exit.h: New file.
8679
8680 2019-01-23  Pedro Alves  <palves@redhat.com>
8681
8682         * common/preprocessor.h (ESC): Rename to ...
8683         (ESC_PARENS): ... this.
8684         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8685         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8686
8687 2019-01-23  Tom Tromey  <tom@tromey.com>
8688
8689         * language.h (class scoped_switch_to_sym_language_if_auto):
8690         Initialize m_lang in both cases.
8691
8692 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8693
8694         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8695         with XCNEW.
8696
8697 2019-01-22  Tom Tromey  <tom@tromey.com>
8698
8699         * corelow.c: Do not include sys/file.h.
8700
8701 2019-01-22  Tom Tromey  <tom@tromey.com>
8702
8703         * tui/tui-wingeneral.h: Include gdb_curses.h.
8704
8705 2019-01-22  Tom Tromey  <tom@tromey.com>
8706
8707         * source-cache.h (class source_cache) <get_source_lines,
8708         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8709
8710 2019-01-22  Tom Tromey  <tom@tromey.com>
8711
8712         * remote-fileio.h (struct remote_target): Declare.
8713
8714 2019-01-22  Tom Tromey  <tom@tromey.com>
8715
8716         * python/py-arch.c: Do not include py-ref.h.
8717         * python/py-bpevent.c: Do not include py-ref.h.
8718         * python/py-cmd.c: Do not include py-ref.h.
8719         * python/py-continueevent.c: Do not include py-ref.h.
8720         * python/py-event.h: Do not include py-ref.h.
8721         * python/py-evtregistry.c: Do not include py-ref.h.
8722         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8723         * python/py-frame.c: Do not include py-ref.h.
8724         * python/py-framefilter.c: Do not include py-ref.h.
8725         * python/py-function.c: Do not include py-ref.h.
8726         * python/py-infevents.c: Do not include py-ref.h.
8727         * python/py-linetable.c: Do not include py-ref.h.
8728         * python/py-objfile.c: Do not include py-ref.h.
8729         * python/py-param.c: Do not include py-ref.h.
8730         * python/py-prettyprint.c: Do not include py-ref.h.
8731         * python/py-progspace.c: Do not include py-ref.h.
8732         * python/py-symbol.c: Do not include py-ref.h.
8733         * python/py-symtab.c: Do not include py-ref.h.
8734         * python/py-type.c: Do not include py-ref.h.
8735         * python/py-unwind.c: Do not include py-ref.h.
8736         * python/py-utils.c: Do not include py-ref.h.
8737         * python/py-value.c: Do not include py-ref.h.
8738         * python/py-varobj.c: Do not include py-ref.h.
8739         * python/py-xmethods.c: Do not include py-ref.h.
8740         * python/python.c: Do not include py-ref.h.
8741         * varobj.c: Do not include py-ref.h.
8742
8743 2019-01-22  Tom Tromey  <tom@tromey.com>
8744
8745         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8746         keyword for bcache.
8747
8748 2019-01-22  Tom Tromey  <tom@tromey.com>
8749
8750         * compile/compile-cplus-types.c: Remove a comment by #include.
8751
8752 2019-01-22  Tom Tromey  <tom@tromey.com>
8753
8754         * compile/gcc-c-plugin.h: Include compile-internal.h.
8755
8756 2019-01-22  Tom Tromey  <tom@tromey.com>
8757
8758         * stabsread.c (EXTERN): Do not define.
8759         (symnum, next_symbol_text_func, processing_gcc_compilation)
8760         (within_function, global_sym_chain, global_stabs)
8761         (previous_stab_code, this_object_header_files)
8762         (n_this_object_header_files)
8763         (n_allocated_this_object_header_files): Define.
8764         * stabsread.h (EXTERN): Never define.  Use "extern".
8765
8766 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8767
8768         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8769         history_value.
8770
8771 2019-01-21  Tom Tromey  <tom@tromey.com>
8772
8773         * ui-out.c: Fix includes.
8774         * tui/tui-source.c: Fix includes.
8775         * target.c: Fix includes.
8776         * remote.c: Fix includes.
8777         * regcache.c: Fix includes.
8778         * python/py-block.c: Fix includes.
8779         * printcmd.c: Fix includes.
8780         * or1k-tdep.c: Fix includes.
8781         * mi/mi-main.c: Fix includes.
8782         * m32r-tdep.c: Fix includes.
8783         * csky-tdep.c: Fix includes.
8784         * compile/compile-cplus-types.c: Fix includes.
8785         * cli/cli-interp.c: Fix includes.
8786
8787 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8788
8789         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8790         for padding.
8791
8792 2019-01-16  Tom Tromey  <tom@tromey.com>
8793
8794         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8795         earlier.
8796         (struct objfile) <msymbols_range>: Move from top level.
8797         <msymbols>: New method.
8798         (class objfile_msymbols): Remove.
8799         * symtab.c (default_collect_symbol_completion_matches_break_on):
8800         Update.
8801         * symmisc.c (dump_msymbols): Update.
8802         * stabsread.c (scan_file_globals): Update.
8803         * objc-lang.c (info_selectors_command, info_classes_command)
8804         (find_methods): Update.
8805         * minsyms.c (find_solib_trampoline_target): Update.
8806         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8807         * coffread.c (coff_symfile_read): Update.
8808         * ada-lang.c (ada_lookup_simple_minsym)
8809         (ada_collect_symbol_completion_matches): Update.
8810
8811 2019-01-16  Tom Tromey  <tom@tromey.com>
8812
8813         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8814         type.  Remove no-argument constructor.
8815         <iterator::operator++>: Simplify.
8816         <begin>: Update.
8817         <end>: Use minimal_symbol_count.
8818
8819 2019-01-16  Tom Tromey  <tom@tromey.com>
8820
8821         * objfiles.h (struct objfile) <psymtabs>: New method.
8822         (class objfile_psymtabs): Remove.
8823         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8824         typedef.
8825         <range>: New method.
8826         (require_partial_symbols): Change return type.
8827         * psymtab.c (require_partial_symbols)
8828         (psym_expand_symtabs_matching): Update.
8829         * mdebugread.c (parse_partial_symbols): Update.
8830         * dbxread.c (dbx_end_psymtab): Update.
8831
8832 2019-01-15  Tom Tromey  <tom@tromey.com>
8833
8834         * symtab.c (lookup_objfile_from_block)
8835         (lookup_symbol_in_objfile_symtabs)
8836         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8837         (find_line_symtab, info_sources_command)
8838         (default_collect_symbol_completion_matches_break_on)
8839         (make_source_files_completion_list): Update.
8840         * symmisc.c (print_objfile_statistics, dump_objfile)
8841         (maintenance_print_symbols, maintenance_info_symtabs)
8842         (maintenance_check_symtabs, maintenance_info_line_tables):
8843         Update.
8844         * source.c (select_source_symtab)
8845         (forget_cached_source_info_for_objfile): Update.
8846         * objfiles.h (class objfile_compunits): Remove.
8847         (struct objfile) <compunits_range>: New typedef.
8848         (compunits): New method.
8849         * objfiles.c (objfile_relocate1): Update.
8850         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8851         * maint.c (count_symtabs_and_blocks): Update.
8852         * linespec.c (iterate_over_all_matching_symtabs): Update.
8853         * cp-support.c (add_symbol_overload_list_qualified): Update.
8854         * coffread.c (coff_symtab_read): Update.
8855         * ada-lang.c (add_nonlocal_symbols)
8856         (ada_collect_symbol_completion_matches)
8857         (ada_add_global_exceptions): Update.
8858
8859 2019-01-15  Tom Tromey  <tom@tromey.com>
8860
8861         * progspace.h (program_space) <objfiles_safe_range>: New
8862         typedef.
8863         <objfiles_safe>: New method.
8864         * objfiles.h (class all_objfiles_safe): Remove.
8865         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8866         * jit.c (jit_inferior_exit_hook): Update.
8867
8868 2019-01-17  Tom Tromey  <tom@tromey.com>
8869
8870         * progspace.h (program_space) <objfiles_range>: New typedef.
8871         <objfiles>: New method.
8872         <objfiles_head>: Rename from objfiles.
8873         (object_files): Update.
8874         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8875         * guile/scm-pretty-print.c
8876         (ppscm_find_pretty_printer_from_objfiles): Update.
8877         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8878         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8879         Update.
8880         * python/py-progspace.c (pspy_get_objfiles): Update.
8881         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8882         Update.
8883         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8884         (objfpy_lookup_objfile_by_build_id): Update.
8885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8886         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8887         Update.
8888         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8889         (expand_symtab_containing_pc, lookup_objfile_from_block)
8890         (lookup_static_symbol, basic_lookup_transparent_type)
8891         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8892         (find_line_symtab, info_sources_command)
8893         (default_collect_symbol_completion_matches_break_on)
8894         (make_source_files_completion_list, find_main_name): Update.
8895         * symmisc.c (print_symbol_bcache_statistics)
8896         (print_objfile_statistics, maintenance_print_symbols)
8897         (maintenance_print_msymbols, maintenance_print_objfiles)
8898         (maintenance_info_symtabs, maintenance_check_symtabs)
8899         (maintenance_expand_symtabs, maintenance_info_line_tables):
8900         Update.
8901         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8902         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8903         (map_overlay_command, unmap_overlay_command)
8904         (simple_overlay_update, expand_symtabs_matching)
8905         (map_symbol_filenames): Update.
8906         * symfile-debug.c (set_debug_symfile): Update.
8907         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8908         Update.
8909         * source.c (select_source_symtab, forget_cached_source_info):
8910         Update.
8911         * solib.c (solib_read_symbols): Update.
8912         * solib-spu.c (append_ocl_sos): Update.
8913         * psymtab.c (maintenance_print_psymbols)
8914         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8915         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8916         * printcmd.c (info_symbol_command): Update.
8917         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8918         Update.
8919         * objfiles.h (class all_objfiles): Remove.
8920         * objfiles.c (have_partial_symbols, have_full_symbols)
8921         (have_minimal_symbols, qsort_cmp, update_section_map)
8922         (shared_objfile_contains_address_p)
8923         (default_iterate_over_objfiles_in_search_order): Update.
8924         * objc-lang.c (info_selectors_command, info_classes_command)
8925         (find_methods): Update.
8926         * minsyms.c (find_solib_trampoline_target): Update.
8927         * maint.c (maintenance_info_sections)
8928         (maintenance_translate_address, count_symtabs_and_blocks):
8929         Update.
8930         * main.c (captured_main_1): Update.
8931         * linux-thread-db.c (try_thread_db_load_from_pdir)
8932         (has_libpthread): Update.
8933         * linespec.c (iterate_over_all_matching_symtabs)
8934         (search_minsyms_for_name): Update.
8935         * jit.c (jit_find_objf_with_entry_addr): Update.
8936         * hppa-tdep.c (find_unwind_entry)
8937         (hppa_lookup_stub_minimal_symbol): Update.
8938         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8939         Update.
8940         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8941         (elf_gnu_ifunc_resolve_by_got): Update.
8942         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8943         * dwarf-index-write.c (save_gdb_index_command): Update.
8944         * cp-support.c (add_symbol_overload_list_qualified): Update.
8945         * breakpoint.c (create_overlay_event_breakpoint)
8946         (create_longjmp_master_breakpoint)
8947         (create_std_terminate_master_breakpoint)
8948         (create_exception_master_breakpoint): Update.
8949         * blockframe.c (find_pc_partial_function): Update.
8950         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8951         (ada_collect_symbol_completion_matches)
8952         (ada_add_global_exceptions): Update.
8953
8954 2019-01-17  Tom Tromey  <tom@tromey.com>
8955
8956         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8957         declare VEC.
8958         (solib_target_parse_libraries): Change return type.
8959         (library_list_start_segment, library_list_start_section)
8960         (library_list_end_library, library_list_start_library); Update.
8961         (solib_target_free_library_list): Remove.
8962         (solib_target_parse_libraries): Remove cleanup.  Change return
8963         type.
8964         (solib_target_current_sos): Update.
8965
8966 2019-01-17  Tom Tromey  <tromey@bapiya>
8967
8968         * valprint.c: Replace "the the" with "the".
8969         * symtab.c: Replace "the the" with "the".
8970         * solib.c: Replace "the the" with "the".
8971         * solib-dsbt.c: Replace "the the" with "the".
8972         * linespec.c: Replace "the the" with "the".
8973         * dwarf2loc.h: Replace "the the" with "the".
8974         * amd64-windows-tdep.c: Replace "the the" with "the".
8975         * aarch64-tdep.c: Replace "the the" with "the".
8976
8977 2019-01-16  Keith Seitz  <keiths@redhat.com>
8978
8979         PR gdb/23773
8980         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8981         <builder>: Rename to ..
8982         <m_builder>: ... this and make private.
8983         (dwarf2_cu::get_builder): New method.  Change all users of
8984         `builder' to use this method.
8985         (dwarf2_start_symtab): Move to ...
8986         (dwarf2_cu::start_symtab): ... here.  Update all callers
8987         (setup_type_unit_groups): Move to ...
8988         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8989         callers.
8990         (dwarf2_cu::reset_builder): New method.
8991         (process_full_compunit, process_full_type_unit): Use
8992         dwarf2_cu::reset_builder.
8993         (follow_die_offset): Record the ancestor CU if it is different
8994         from the followed DIE's CU.
8995         (follow_die_sig_1): Likewise.
8996
8997 2019-01-15  Tom Tromey  <tom@tromey.com>
8998
8999         * remote.c (class remote_state) <buf>: Now a char_vector.
9000         <buf_size>: Remove.
9001         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9002         parameter.
9003         (remote_target::getpkt_or_notif_sane_1)
9004         (remote_target::getpkt_sane)
9005         (remote_target::getpkt_or_notif_sane): Likewise.
9006         (class remote_target) <putpkt>: New overload.
9007         (remote_target::read_frame): Change type of "buf_p".  Remove
9008         sizeof_p parameter.
9009         (packet_ok): New overload.
9010         (packet_check_result): New overload.
9011         Update all uses.
9012
9013 2019-01-14  Tom Tromey  <tom@tromey.com>
9014
9015         * remote-notif.c (handle_notification, remote_notif_ack)
9016         (remote_notif_parse): Make "buf" const.
9017         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9018         const.
9019         (remote_notif_parse, remote_notif_ack, handle_notification):
9020         Likewise.
9021         * remote.c (remote_notif_stop_parse): Make "buf" const.
9022         (remote_target::remote_parse_stop_reply): Make "buf" const.
9023         (remote_notif_stop_ack): Make "buf" const.
9024
9025 2019-01-14  Tom Tromey  <tom@tromey.com>
9026
9027         * remote.c (remote_console_output): Make parameter const.
9028
9029 2019-01-14  Tom Tromey  <tom@tromey.com>
9030
9031         * target-debug.h (target_debug_print_signals): Constify.
9032         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9033         * procfs.c (procfs_target::pass_signals): Update.
9034         * linux-nat.c (linux_nat_target::pass_signals): Update.
9035         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9036         * target-delegates.c: Rebuild.
9037         * remote.c (remote_target::program_signals): Update.
9038         (remote_target::pass_signals): Update.
9039         * target.c (target_pass_signals): Constify argument.
9040         (target_program_signals): Likewise.
9041         * target.h (struct target_ops) <pass_signals, program_signals>:
9042         Constify argument.
9043         (target_pass_signals, target_program_signals): Constify argument.
9044
9045 2019-01-14  Tom Tromey  <tom@tromey.com>
9046
9047         PR tui/28819:
9048         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9049
9050 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9051
9052         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9053         field.
9054         * rs6000-tdep.c: Include reggroups.h.
9055         (IS_V_ALIAS_PSEUDOREG): Define.
9056         (rs6000_register_name): Return names for the "vX" aliases.
9057         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9058         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9059         aliases.  Call default_register_reggroup_p for all other
9060         pseudo-registers.
9061         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9062         New functions.
9063         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9064         Handle "vX" aliases.
9065         (v_alias_pseudo_register_collect): New function.
9066         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9067         (rs6000_gdbarch_init): Initialize "vX" aliases as
9068         pseudo-registers.  Restore registration of
9069         rs6000_pseudo_register_reggroup_p with
9070         set_tdesc_pseudo_register_reggroup_p.
9071
9072 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9073
9074         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9075         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9076         set_gdbarch_num_pseudo_regs.
9077
9078 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9079
9080         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9081         Remove arg prefixname, add do_set and do_show.
9082         Add member functions set_list and show_list.
9083         * cli/cli-style.c (class cli_style_option): Update accordingly.
9084         (style_set_list): Move to file scope.
9085         (style_show_list): Likewise.
9086         (set_style): Call help_list.
9087         (show_style): Call cmd_show_list.
9088         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9089         Update to use the new macro.
9090
9091 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9092
9093         * ada-lang.c (_initialize_ada_language): Expand the help text
9094         for the "catch exception" command.
9095
9096 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9097
9098         * symtab.c (matching_obj_sections): Initialize obj,
9099         declare it closer to its usage.
9100
9101 2019-01-10  Tom Tromey  <tom@tromey.com>
9102
9103         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9104         (basic_inf_threads_range): Remove.
9105         (inf_threads_range, inf_non_exited_threads_range)
9106         (safe_inf_threads_range): Use next_adapter.
9107
9108 2019-01-10  Keith Seitz  <keiths@redhat.com>
9109
9110         PR gdb/23712
9111         PR symtab/23010
9112         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9113         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9114
9115 2019-01-10  Keith Seitz  <keiths@redhat.com>
9116
9117         PR gdb/23712
9118         PR symtab/23010
9119         * dictionary.c (pending_to_vector): Remove.
9120         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9121         Remove _1 suffix, replacing functions of the same name.  Update
9122         all callers.
9123         (dict_create_hashed, dict_create_hashed_expandable)
9124         (dict_create_linear, dict_create_linear_expandable, dict_free)
9125         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9126         Make functions static.
9127
9128 2019-01-10  Keith Seitz  <keiths@redhat.com>
9129
9130         PR gdb/23712
9131         PR symtab/23010
9132         * dictionary.h (struct dictionary): Replace declaration with
9133         multidictionary.
9134         (dict_create_hashed, dict_create_hashed_expandable)
9135         (dict_create_linear, dict_create_linear_expandable)
9136         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9137         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9138         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9139         taking multidictionary argument.
9140         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9141         * block.h (struct block) <dict>: Change to multidictionary
9142         and rename `multidict'.
9143         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9144         symmisc.c: Update all dictionary references to multidictionary.
9145
9146 2019-01-10  Keith Seitz  <keiths@redhat.com>
9147
9148         PR gdb/23712
9149         PR symtab/23010
9150         * dictionary.c: Include unordered_map.
9151         (pending_to_vector): New function.
9152         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9153         Rewrite the non-"_1" functions to take vector instead
9154         of linked list.
9155         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9156         "new" _1 versions of the same name.
9157         (multidictionary): Define.
9158         (std::hash<enum language): New definition.
9159         (collate_pending_symbols_by_language, mdict_create_hashed)
9160         (mdict_create_hashed_expandable, mdict_create_linear)
9161         (mdict_create_linear_expandable, mdict_free)
9162         (find_language_dictionary, create_new_language_dictionary)
9163         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9164         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9165         (mdict_size, mdict_empty): New functions.
9166         * dictionary.h (mdict_iterator): Define.
9167
9168 2019-01-10  Pedro Alves  <palves@redhat.com>
9169
9170         * breakpoint.c (read_uploaded_action)
9171         (create_tracepoint_from_upload): Adjust to use
9172         gdb::unique_xmalloc_ptr.
9173         * ctf.c (ctf_write_uploaded_tp):
9174         (SET_ARRAY_FIELD): Use emplace_back.
9175         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9176         * tracefile-tfile.c (tfile_write_uploaded_tp):
9177         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9178         gdb::unique_xmalloc_ptr.
9179         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9180         at_string, cond_string, cmd_strings>: Replace char pointers
9181         with gdb::unique_xmalloc_ptr.
9182
9183 2019-01-10  Pedro Alves  <palves@redhat.com>
9184
9185         * solib-target.c (library_list_start_library): Don't xstrdup name.
9186
9187 2019-01-10  Pedro Alves  <palves@redhat.com>
9188
9189         * mdebugread.c (parse_partial_symbols): Use
9190         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9191
9192 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9193
9194         * linux-fork.c (scoped_switch_fork_info)
9195         <~scoped_switch_fork_info>: Fix incorrect variable name.
9196
9197 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9198
9199         * linux-fork.c (scoped_switch_fork_info)
9200         <scoped_switch_fork_info>: Make explicit.
9201         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9202
9203 2019-01-10  Tom Tromey  <tom@tromey.com>
9204
9205         * objfiles.h (objfile::reset_psymtabs): Update.
9206         * objfiles.c (objfile::objfile): Update.
9207         * psymtab.h (psymtab_storage::obstack): Update.
9208         (psymtab_storage::m_obstack): Use gdb::optional.
9209         (class psymtab_storage): Update comment.  Remove objfile
9210         parameter.
9211         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9212
9213 2019-01-10  Tom Tromey  <tom@tromey.com>
9214
9215         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9216         <free_psymtabs>: Now private.
9217         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9218         (allocate_psymtab): Use new method.
9219
9220 2019-01-10  Tom Tromey  <tom@tromey.com>
9221
9222         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9223         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9224         * mdebugread.c (parse_partial_symbols): Use
9225         allocate_dependencies.
9226         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9227         allocate_dependencies.
9228         (process_psymtab_comp_unit_reader)
9229         (build_type_psymtab_dependencies): Likewise.
9230         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9231
9232 2019-01-10  Tom Tromey  <tom@tromey.com>
9233
9234         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9235         PSYMBOL_SET_LANGUAGE.
9236         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9237
9238 2019-01-10  Tom Tromey  <tom@tromey.com>
9239
9240         * psymtab.h (psymtab_storage::obstack): New method.
9241         <m_obstack>: Rename from obstack; now private.
9242         * psymtab.c (psymtab_storage): Update.
9243         * dwarf2read.c (create_addrmap_from_index)
9244         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9245         Update.
9246
9247 2019-01-10  Tom Tromey  <tom@tromey.com>
9248
9249         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9250         * objfiles.h (objfile::reset_psymtabs): New method.
9251
9252 2019-01-10  Tom Tromey  <tom@tromey.com>
9253
9254         * symmisc.c (print_symbol_bcache_statistics): Update.
9255         (print_objfile_statistics): Update.
9256         * symfile.c (reread_symbols): Update.
9257         * psymtab.h (class psymtab_storage): New.
9258         * psymtab.c (psymtab_storage): New constructor.
9259         (~psymtab_storage): New destructor.
9260         (require_partial_symbols): Update.
9261         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9262         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9263         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9264         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9265         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9266         (start_psymtab_common, end_psymtab_common)
9267         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9268         (allocate_psymtab): Update.
9269         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9270         Update.
9271         (dump_psymtab_addrmap, maintenance_print_psymbols)
9272         (maintenance_check_psymtabs): Update.
9273         (class objfile_psymtabs): Move to objfiles.h.
9274         * psympriv.h (discard_psymtab): Now inline.
9275         (psymtab_discarder::psymtab_discarder): Update.
9276         (psymtab_discarder::~psymtab_discarder): Update.
9277         (ALL_OBJFILE_PSYMTABS): Rewrite.
9278         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9279         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9280         Remove fields.
9281         <partial_symtabs>: New field.
9282         (class objfile_psymtabs): Move from psymtab.h.  Update.
9283         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9284         psymbol_cache.
9285         (objfile::~objfile): Don't destroy psymbol_cache.
9286         * mdebugread.c (parse_partial_symbols): Update.
9287         * dwarf2read.c (create_addrmap_from_index)
9288         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9289         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9290         (add_partial_subprogram, dwarf2_ranges_read): Update.
9291         * dwarf-index-write.c (write_address_map)
9292         (write_one_signatured_type, recursively_write_psymbols)
9293         (class debug_names, class debug_names, write_psymtabs_to_index):
9294         Update.
9295
9296 2019-01-10  Tom Tromey  <tom@tromey.com>
9297
9298         * symtab.h (SYMBOL_SET_NAMES): Update.
9299         (symbol_set_names): Update.
9300         (MSYMBOL_SET_NAMES): Update.
9301         * symtab.c (symbol_set_names): Change argument to be an
9302         objfile_per_bfd_storage.
9303         * psymtab.c (add_psymbol_to_bcache): Update.
9304         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9305
9306 2019-01-10  Tom Tromey  <tom@tromey.com>
9307
9308         * symtab.c (create_demangled_names_hash): Change argument to be an
9309         objfile_per_bfd_storage.
9310         (symbol_set_names): Update.
9311
9312 2019-01-10  Tom Tromey  <tom@tromey.com>
9313
9314         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9315         init_psymbol_list.
9316         * psymtab.c (init_psymbol_list): Do nothing if already called.
9317         * psympriv.h (init_psymbol_list): Add comment.
9318         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9319         init_psymbol_list.
9320         * dbxread.c (dbx_symfile_read): Unconditionally call
9321         init_psymbol_list.
9322
9323 2019-01-10  Tom Tromey  <tom@tromey.com>
9324
9325         * xcoffread.c (scan_xcoff_symtab): Update.
9326         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9327         "where".
9328         * mdebugread.c (parse_partial_symbols)
9329         (handle_psymbol_enumerators): Update.
9330         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9331         * dbxread.c (read_dbx_symtab): Update.
9332         * psympriv.h (psymbol_placement): New enum.
9333         (add_psymbol_to_list): Update.
9334
9335 2019-01-10  Tom Tromey  <tom@tromey.com>
9336
9337         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9338         static_psymbols parameters.
9339         (scan_xcoff_symtab): Update.
9340         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9341         static_psymbols parameters.
9342         * psympriv.h (start_psymtab_common): Update.
9343         * mdebugread.c (parse_partial_symbols): Update.
9344         * dwarf2read.c (create_partial_symtab): Update.
9345         * dbxread.c (read_dbx_symtab): Update.
9346         (start_psymtab): Remove global_psymbols and static_psymbols
9347         parameters.
9348
9349 2019-01-10  Tom Tromey  <tom@tromey.com>
9350
9351         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9352         * psymtab.c (allocate_psymtab): Add comment.
9353         * psympriv.h (allocate_psymtab): Add comment.
9354         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9355         initializations.
9356         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9357
9358 2019-01-10  Tom Tromey  <tom@tromey.com>
9359
9360         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9361         Don't declare.
9362         * mipsread.c: Include mdebugread.h.
9363         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9364         Declare.
9365         * elfread.c: Include mdebugread.h.
9366
9367 2019-01-09  Tom Tromey  <tom@tromey.com>
9368
9369         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9370         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9371         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9372         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9373         (psym_lookup_symbol, psym_find_last_source_symtab)
9374         (psym_forget_cached_source_info, psym_print_stats)
9375         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9376         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9377         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9378         (psym_find_compunit_symtab_by_address)
9379         (maintenance_print_psymbols, maintenance_info_psymtabs)
9380         (maintenance_check_psymtabs): Use ranged for.
9381         * psymtab.h (class objfile_psymtabs): New.
9382         (require_partial_symbols): Return objfile_psymtabs.
9383         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9384
9385 2019-01-09  Tom Tromey  <tom@tromey.com>
9386
9387         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9388         (find_pc_mapped_section, list_overlays_command)
9389         (map_overlay_command, unmap_overlay_command)
9390         (simple_overlay_update): Use all_objfiles.
9391         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9392         * printcmd.c (info_symbol_command): Use all_objfiles.
9393         * objfiles.h (ALL_OBJSECTIONS): Remove.
9394         * maint.c (maintenance_translate_address): Use all_objfiles.
9395         * gcore.c (gcore_create_callback): Use all_objfiles.
9396         (objfile_find_memory_regions): Likewise.
9397
9398 2019-01-09  Tom Tromey  <tom@tromey.com>
9399
9400         * symtab.c (find_line_symtab, info_sources_command)
9401         (make_source_files_completion_list): Use objfile_compunits.
9402         * source.c (select_source_symtab): Use objfile_compunits.
9403         * objfiles.h (struct objfile): Update comment.
9404         (ALL_OBJFILES): Remove.
9405         (ALL_FILETABS): Remove.
9406         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9407         objfile_compunits.
9408
9409 2019-01-09  Tom Tromey  <tom@tromey.com>
9410
9411         * symmisc.c (print_objfile_statistics, dump_objfile)
9412         (maintenance_print_symbols): Use compunit_filetabs.
9413         * source.c (forget_cached_source_info_for_objfile): Use
9414         compunit_filetabs.
9415         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9416         (ALL_FILETABS): Use compunit_filetabs.
9417         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9418         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9419
9420 2019-01-09  Tom Tromey  <tom@tromey.com>
9421
9422         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9423         (compunit_filetabs): New.
9424         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9425         compunit_filetabs.
9426         (info_sources_command, make_source_files_completion_list): Remove
9427         declaration.
9428         * symmisc.c (print_objfile_statistics, dump_objfile)
9429         (maintenance_print_symbols): Remove declaration.
9430         (maintenance_info_symtabs): Use compunit_filetabs.
9431         (maintenance_info_line_tables): Likewise.
9432         * source.c (select_source_symtab): Change local variable name.
9433         (forget_cached_source_info_for_objfile): Remove declaration.
9434         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9435         * objfiles.c (objfile_relocate1): Remove declaration.
9436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9437         declaration.
9438         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9439         * coffread.c (coff_symtab_read): Remove declaration.
9440         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9441         compunit_filetabs.
9442
9443 2019-01-09  Tom Tromey  <tom@tromey.com>
9444
9445         * symtab.c (lookup_objfile_from_block)
9446         (find_pc_sect_compunit_symtab, search_symbols)
9447         (default_collect_symbol_completion_matches_break_on): Use
9448         objfile_compunits.
9449         * objfiles.h (ALL_COMPUNITS): Remove.
9450         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9451         * cp-support.c (add_symbol_overload_list_qualified): Use
9452         objfile_compunits.
9453         * ada-lang.c (ada_collect_symbol_completion_matches)
9454         (ada_add_global_exceptions): Use objfile_compunits.
9455
9456 2019-01-09  Tom Tromey  <tom@tromey.com>
9457
9458         * source.c (select_source_symtab)
9459         (forget_cached_source_info_for_objfile): Remove declaration.
9460         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9461         declaration.
9462         * maint.c (count_symtabs_and_blocks): Remove declaration.
9463         * cp-support.c (add_symbol_overload_list_qualified): Remove
9464         declaration.
9465         * coffread.c (coff_symtab_read): Remove declaration.
9466         * symtab.c (lookup_symbol_in_objfile_symtabs)
9467         (basic_lookup_transparent_type_1): Use objfile_compunits.
9468         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9469         (info_sources_command, search_symbols)
9470         (default_collect_symbol_completion_matches_break_on)
9471         (make_source_files_completion_list): Remove declaration.
9472         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9473         (ada_collect_symbol_completion_matches)
9474         (ada_add_global_exceptions): Remove declaration.
9475         * linespec.c (iterate_over_all_matching_symtabs): Use
9476         objfile_compunits.
9477         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9478         (class objfile_compunits): New.
9479         (ALL_COMPUNITS): Use objfile_compunits.
9480         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9481         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9482         objfile_compunits.
9483         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9484
9485 2019-01-09  Tom Tromey  <tom@tromey.com>
9486
9487         * symtab.c (search_symbols)
9488         (default_collect_symbol_completion_matches_break_on): Use
9489         objfile_msymbols.
9490         * ada-lang.c (ada_lookup_simple_minsym)
9491         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9492         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9493         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9494         objfile_msymbols.
9495         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9496         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9497         * objc-lang.c (find_methods): Use objfile_msymbols.
9498         (info_selectors_command, info_classes_command): Likewise.
9499         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9500         * objfiles.h (class objfile_msymbols): New.
9501         (ALL_OBJFILE_MSYMBOLS): Remove.
9502         (ALL_MSYMBOLS): Remove.
9503
9504 2019-01-09  Tom Tromey  <tom@tromey.com>
9505
9506         * common/next-iterator.h (next_adapter): Add Iterator template
9507         parameter.
9508         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9509         (class all_objfiles_safe): New.
9510         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9511         * objfiles.c (put_objfile_before): Update comment.
9512         (add_separate_debug_objfile): Likewise.
9513         (free_all_objfiles): Use all_objfiles_safe.
9514         (objfile_purge_solibs): Likewise.
9515
9516 2019-01-09  Tom Tromey  <tom@tromey.com>
9517
9518         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9519         (expand_symtab_containing_pc, lookup_static_symbol)
9520         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9521         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9522         all_objfiles.
9523         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9524         * breakpoint.c (create_overlay_event_breakpoint)
9525         (create_longjmp_master_breakpoint)
9526         (create_std_terminate_master_breakpoint)
9527         (create_exception_master_breakpoint): Use all_objfiles.
9528         * linux-thread-db.c (try_thread_db_load_from_pdir)
9529         (has_libpthread): Use all_objfiles.
9530         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9531         * linespec.c (iterate_over_all_matching_symtabs)
9532         (search_minsyms_for_name): Use all_objfiles.
9533         * maint.c (maintenance_info_sections): Use all_objfiles.
9534         * main.c (captured_main_1): Use all_objfiles.
9535         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9536         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9537         * guile/scm-pretty-print.c
9538         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9539         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9540         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9541         (maintenance_print_msymbols): Use all_objfiles.
9542         * source.c (select_source_symtab): Use all_objfiles.
9543         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9544         * symfile.c (remove_symbol_file_command)
9545         (expand_symtabs_matching, map_symbol_filenames): Use
9546         all_objfiles.
9547         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9548         all_objfiles.
9549         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9550         * objc-lang.c (find_methods): Use all_objfiles.
9551         * objfiles.c (have_partial_symbols, have_full_symbols)
9552         (have_minimal_symbols, qsort_cmp)
9553         (default_iterate_over_objfiles_in_search_order): Use
9554         all_objfiles.
9555         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9556         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9557         (maintenance_check_psymtabs): Use all_objfiles.
9558         (ALL_PSYMTABS): Remove.
9559         * compile/compile-object-run.c (do_module_cleanup): Use
9560         all_objfiles.
9561         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9562         * cp-support.c (add_symbol_overload_list_qualified): Use
9563         all_objfiles.
9564         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9565         Use all_objfiles.
9566         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9567         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9568         all_objfiles.
9569         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9570         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9571         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9572         Uses all_objfiles.
9573         * solib.c (solib_read_symbols): Use all_objfiles
9574
9575 2019-01-09  Tom Tromey  <tom@tromey.com>
9576
9577         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9578         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9579         all_objfiles.
9580         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9581         * symmisc.c (print_symbol_bcache_statistics)
9582         (print_objfile_statistics, maintenance_print_objfiles)
9583         (maintenance_info_symtabs, maintenance_check_symtabs)
9584         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9585         all_objfiles.
9586         * source.c (forget_cached_source_info): Use all_objfiles.
9587         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9588         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9589         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9590         * objfiles.c (update_section_map): Use all_objfiles.
9591         (shared_objfile_contains_address_p): Likewise.
9592         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9593         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9594
9595 2019-01-09  Tom Tromey  <tom@tromey.com>
9596
9597         * common/next-iterator.h: New file.
9598         * objfiles.h (class all_objfiles): New.
9599         (struct objfile_iterator): New.
9600
9601 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9602
9603         * NEWS: Move the description of the changed "frame", "select-frame",
9604          and "info frame" commands to the Changed commands section.
9605
9606 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9607
9608         * gdbtypes.c (check_stub_method_group): Remove handling of old
9609         mangling schemes.
9610         * linespec.c (find_methods): Likewise.
9611         * stabsread.c (read_member_functions): Likewise.
9612         * valops.c (search_struct_method): Likewise.
9613         (value_struct_elt_for_reference): Likewise.
9614         * NEWS: Mention this change.
9615
9616 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9617
9618         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9619         print_source_lines.
9620         * source.c (print_source_lines_base): Update line number check.
9621         (print_source_lines): New function.
9622         (source_lines_range::source_lines_range): New function.
9623         * source.h (class source_lines_range): New class.
9624         (print_source_lines): New declaration.
9625
9626 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9627
9628         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9629
9630 2019-01-08  Tom Tromey  <tom@tromey.com>
9631             Simon Marchi  <simon.marchi@ericsson.com>
9632
9633         PR gdb/24060
9634         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9635         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9636         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9637         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9638         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9639         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9640
9641 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9642
9643         * source.c (select_source_symtab): Move header comment to
9644         declaration in source.h.
9645         (forget_cached_source_info_for_objfile): Likewise.
9646         (forget_cached_source_info): Likewise.
9647         (identify_source_line): Likewise.
9648         * source.h (identify_source_line): Move declaration from symtab.h
9649         and add comment from source.c
9650         (print_source_lines): Likewise.
9651         (forget_cached_source_info_for_objfile): Likewise.
9652         (forget_cached_source_info): Likewise.
9653         (select_source_symtab): Likewise.
9654         (enum print_source_lines_flag): Move definition from symtab.h.
9655         * symtab.h (identify_source_line): Move declaration to source.h.
9656         (print_source_lines): Likewise.
9657         (forget_cached_source_info_for_objfile): Likewise.
9658         (forget_cached_source_info): Likewise.
9659         (select_source_symtab): Likewise.
9660         (enum print_source_lines_flag): Move definition to source.h.
9661         * tui/tui-hooks.c: Add 'source.h' include.
9662
9663 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9664
9665         * source.c (print_source_lines_base): Handle requests to print
9666         reverse line number sequences, and guard against empty lines
9667         string.
9668
9669 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9670
9671         * source.c (print_source_lines_base): Fix skip of '\r' if next
9672         character is '\n'.
9673
9674 2019-01-06  Tom Tromey  <tom@tromey.com>
9675
9676         * c-exp.y (struct c_parse_state) <macro_original_text,
9677         expansion_obstack>: New member.
9678         (macro_original_text, expansion_obstack): Remove globals.
9679         (scan_macro_expansion, scanning_macro_expansion)
9680         (finished_macro_expansion): Update.
9681         (scan_macro_cleanup): Remove.
9682         (yylex, c_parse): Update.
9683
9684 2019-01-06  Tom Tromey  <tom@tromey.com>
9685
9686         * c-exp.y (struct c_parse_state) <strings>: New member.
9687         (operator_stoken): Update.
9688
9689 2019-01-06  Tom Tromey  <tom@tromey.com>
9690
9691         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9692         (union type_stack_elt) <typelist_val>: Now a pointer to
9693         std::vector.
9694         (type_stack_cleanup): Don't declare.
9695         (push_typelist): Update.
9696         * parse.c (pop_typelist): Return a std::vector.
9697         (push_typelist): Take a std::vector.
9698         (follow_types): Update.  Do not free args.
9699         (type_stack_cleanup): Remove.
9700         * c-exp.y (struct c_parse_state): New.
9701         (cpstate): New global.
9702         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9703         (nonempty_typelist): Update.
9704         (func_mod): Create a new vector.
9705         (c_parse): Create a c_parse_state.
9706         (check_parameter_typelist): Do not delete params.
9707         (function_method): Update.  Do not delete type_list.
9708
9709 2019-01-06  Tom Tromey  <tom@tromey.com>
9710
9711         PR gdb/28155:
9712         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9713         check_typedef.
9714         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9715         (print_return_value): Likewise.
9716
9717 2019-01-05  Tom Tromey  <tom@tromey.com>
9718
9719         * contrib/cleanup_check.py: Remove.
9720         * contrib/gcc-with-excheck: Remove.
9721         * contrib/exsummary.py: Remove.
9722         * contrib/excheck.py: Remove.
9723
9724 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9725
9726         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9727         NULL. Initialize tpprev to NULL instead of assigning it
9728         to NULL on the next statement.
9729         * windows-nat.c (windows_delete_thread): Remove check for
9730         main_thread_id before printing thread exit notifications.
9731         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9732         Remove thread ID check against main_thread_id.
9733         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9734         windows_delete_thread.
9735         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9736
9737 2019-01-04  Tom Tromey  <tom@tromey.com>
9738
9739         * compile/compile.c (_initialize_compile): Use upper case for
9740         metasyntactic variables.
9741         * symmisc.c (_initialize_symmisc): Use upper case for
9742         metasyntactic variables.
9743         * psymtab.c (_initialize_psymtab): Use upper case for
9744         metasyntactic variables.
9745         * demangle.c (demangle_command): Use upper case for metasyntactic
9746         variables.
9747         (_initialize_demangler): Likewise.
9748         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9749         variables.
9750
9751 2019-01-03  Tom Tromey  <tom@tromey.com>
9752
9753         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9754
9755 2019-01-03  Tom Tromey  <tom@tromey.com>
9756
9757         * python/py-symtab.c (salpy_str): Update.
9758         (struct salpy_sal_object) <symtab>: Now a PyObject.
9759         (salpy_dealloc): Update.
9760         (del_objfile_sal): Use gdbpy_ref.
9761
9762 2019-01-03  Tom Tromey  <tom@tromey.com>
9763
9764         * python/py-type.c (convert_field): Use new_reference.  Return
9765         gdbpy_ref.
9766         (make_fielditem): Return gdbpy_ref.
9767         (typy_fields): Update.
9768         (typy_getitem): Update.
9769         (field_name): Return gdbpy_ref.  Use new_reference.
9770         (typy_iterator_iternext): Update.
9771
9772 2019-01-03  Tom Tromey  <tom@tromey.com>
9773
9774         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9775
9776 2019-01-03  Tom Tromey  <tom@tromey.com>
9777
9778         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9779         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9780         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9781         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9782         (pspy_set_type_printers): Likewise.
9783         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9784         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9785         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9786         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9787         (objfpy_set_type_printers): Likewise.
9788
9789 2019-01-03  Tom Tromey  <tom@tromey.com>
9790
9791         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9792         (gdbpy_print_stack): Use gdbpy_err_fetch.
9793         * python/python-internal.h (class gdbpy_err_fetch): New class.
9794         (class gdbpy_enter) <m_error_type, m_error_value,
9795         m_error_traceback>: Remove.
9796         <m_error>: New member.
9797         (gdbpy_exception_to_string): Don't declare.
9798         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9799         * python/py-value.c (convert_value_from_python): Use
9800         gdbpy_err_fetch.
9801         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9802         gdbpy_exception_to_string.
9803         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9804         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9805         gdbpy_err_fetch.
9806
9807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9808
9809         * linux-nat.c (delete_lwp_cleanup): Delete.
9810         (struct lwp_deleter): New struct.
9811         (lwp_info_up): New typedef.
9812         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9813         lwp_info_up.
9814
9815 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9816
9817         * linux-fork.c (class scoped_switch_fork_info): New class.
9818         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9819
9820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9821
9822         * valops.c (find_overload_match): Remove use of null_cleanup, and
9823         calls to do_cleanups.
9824
9825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9826
9827         * compile/compile-cplus-types.c
9828         (compile_cplus_instance::decl_name): Handle changes to
9829         cp_func_name.
9830         * cp-support.c (cp_func_name): Update header comment, update
9831         return type.
9832         * cp-support.h (cp_func_name): Update return type in declaration.
9833         * valops.c (find_overload_match): Move temp_func local to top
9834         level of function and change its type.  Use temp_func to hold and
9835         delete temporary string obtained from cp_func_name.
9836
9837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9840         gdb::char_vector, remove cleanup, and update uses of `msg`.
9841
9842 2019-01-03  Jim Wilson  <jimw@sifive.com>
9843
9844         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9845
9846 2019-01-02  Tom Tromey  <tom@tromey.com>
9847
9848         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9849         (tdesc_parse_xml): Remove cleanups.
9850         * target-descriptions.h (make_cleanup_free_target_description):
9851         Don't declare.
9852         (target_desc_deleter): New struct.
9853         (target_desc_up): New typedef.
9854         * target-descriptions.c (target_desc_deleter::operator()): Rename
9855         from free_target_description.
9856         (make_cleanup_free_target_description): Remove.
9857
9858 2019-01-02  Tom Tromey  <tom@tromey.com>
9859
9860         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9861         constructor, destructor.
9862         (linespec_parser): Remove typedef.
9863         (~linespec_parser): Rename from linespec_parser_delete.
9864         (linespec_lex_to_end, linespec_complete_label)
9865         (linespec_complete): Update.
9866         (decode_line_full): Remove cleanups.
9867         (decode_line_1): Update.
9868
9869 2019-01-02  Tom Tromey  <tom@tromey.com>
9870
9871         * python/python-internal.h (inferior_to_inferior_object): Change
9872         return type.
9873         * python/py-exitedevent.c (create_exited_event_object): Update.
9874         * python/py-inferior.c (inferior_to_inferior_object): Return
9875         gdbpy_ref.
9876         (python_new_inferior, python_inferior_deleted)
9877         (thread_to_thread_object, delete_thread_object)
9878         (build_inferior_list, gdbpy_selected_inferior): Update.
9879         * python/py-infthread.c (create_thread_object): Update.  Also fail
9880         if inferior_to_inferior_object fails.
9881
9882 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9883
9884         * inferior.h (class inferior) <displaced_step_state>: New field.
9885         * infrun.h (struct displaced_step_state): Move here from
9886         infrun.c.  Initialize fields, add constructor.
9887         <inf>: Remove field.
9888         <reset>: New method.
9889         * infrun.c (struct displaced_step_inferior_state): Move to
9890         infrun.h.
9891         (displaced_step_inferior_states): Remove.
9892         (get_displaced_stepping_state): Adust.
9893         (displaced_step_in_progress_any_inferior): Adjust.
9894         (displaced_step_in_progress_thread): Adjust.
9895         (displaced_step_in_progress): Adjust.
9896         (add_displaced_stepping_state): Remove.
9897         (get_displaced_step_closure_by_addr): Adjust.
9898         (remove_displaced_stepping_state): Remove.
9899         (infrun_inferior_exit): Call displaced_step_state.reset.
9900         (use_displaced_stepping): Don't check for NULL.
9901         (displaced_step_prepare_throw): Call
9902         get_displaced_stepping_state.
9903         (displaced_step_fixup): Don't check for NULL.
9904         (prepare_for_detach): Don't check for NULL.
9905
9906 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9907
9908         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9909          in case of call that did not complete.
9910
9911 2019-01-02  Andrey Utkin  <autkin@undo.io>
9912
9913         * symfile.c (find_separate_debug_file): Fix search of debug files for
9914         remote debuggee.
9915
9916 2019-01-02  Tom Tromey  <tom@tromey.com>
9917
9918         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9919         indentation.
9920         * python/py-frame.c (frapy_older): Remove cast.
9921         (frapy_newer): Likewise.
9922         * python/py-breakpoint.c (local_setattro): Remove cast.
9923         * python/py-arch.c (archpy_name): Remove local variable.
9924         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9925
9926 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9927
9928         * unittests/basic_string_view/element_access/char/empty.cc:
9929         Fix year range in copyright header.
9930
9931 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9932
9933         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9934         Delete.
9935         <operator==>: Update with for removed field.
9936         <hash>: Likewise.
9937         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9938         <isa_features>: ...this.
9939         <abi_features>: New field.
9940         (riscv_isa_flen): Update comment.
9941         (riscv_abi_xlen): New declaration.
9942         (riscv_abi_flen): New declaration.
9943         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9944         isa_features.
9945         (riscv_abi_xlen): New function.
9946         (riscv_isa_flen): Update to get answer from isa_features.
9947         (riscv_abi_flen): New function.
9948         (riscv_has_fp_abi): Update to get answer from abi_features.
9949         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9950         xlen and flen.
9951         (riscv_call_info) <xlen, flen>: Update comment.
9952         (riscv_call_arg_struct): Remove invalid assertions
9953         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9954         is removed.
9955         (riscv_gdbarch_init): Gather isa features and abi features
9956         separately, ensure both match on the gdbarch when reusing an old
9957         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9958         a target with 64-bit float hardware.
9959
9960 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9961
9962         * source.c (search_command_helper): Stop reverse search
9963         when line 1 has been searched.
9964
9965 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9966
9967         * record-full.c (record_full_base_target::close): Rewrite
9968         record_full_core_buf_list free logic.
9969
9970 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9971
9972         * break-catch-syscall.c (print_one_catch_syscall): xfree
9973         the last text.
9974
9975 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9976
9977         * top.c (print_gdb_version): Update Copyright year in version
9978         message.
9979
9980 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9981
9982         Update copyright year range in all GDB files.
9983
9984 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9985
9986         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9987
9988 For older changes see ChangeLog-2018.
9989 \f
9990 Local Variables:
9991 mode: change-log
9992 left-margin: 8
9993 fill-column: 74
9994 version-control: never
9995 coding: utf-8
9996 End:
9997