gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
   4         refresh_window.
   5         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
   6         touchwin.
   7         (tui_data_window::refresh_window): Call refresh_window on data
   8         items.  Always call superclass refresh_window.
   9         (tui_win_info::refresh): Remove.
  10         (tui_source_window_base::refresh_window): Update.
  11         (tui_refresh_all): Update.
  12         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  13         refresh_window.
  14         (show_source_or_disasm_and_command): Likewise.
  15         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  16         (struct tui_source_window_base) <refresh>: Likewise.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-winsource.c (tui_clear_source_content)
  21         (tui_show_source_content): Update.
  22         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  23         whether content is empty.
  24         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  25         Remove.
  26
  27 2019-07-17  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  30         window's contents.
  31         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  32         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  33
  34 2019-07-17  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  37         (struct tui_data_item_window): Update.
  38
  39 2019-07-17  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  42         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  43         defines.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-winsource.h (tui_erase_source_content)
  48         (tui_clear_source_content): Remove "display_prompt" parameter.
  49         * tui/tui-winsource.c (tui_update_source_window_as_is)
  50         (tui_update_source_windows_with_addr): Update.
  51         (tui_clear_source_content): Remove "display_prompt" parameter.
  52         (tui_erase_source_content): Likewise.  Simplify.
  53         (tui_show_source_content): Update.
  54         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  55         * tui/tui-stack.c (tui_show_frame_info): Update.
  56         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  57         Remove defines.
  58
  59 2019-07-17  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  62         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  63         parameter.
  64         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  65         parameter.
  66
  67 2019-07-17  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-winsource.c (tui_clear_source_content)
  70         (tui_show_source_content, tui_show_exec_info_content)
  71         (tui_clear_exec_info_content): Update.
  72         * tui/tui-stack.c (tui_show_locator_content): Update.
  73         (tui_show_frame_info): Update.
  74         * tui/tui-source.h (tui_source_window): Don't declare.
  75         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  76         from tui_source_is_displayed.
  77         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  78         Remove field.
  79         (struct tui_source_window_base) <content_in_use>: New field.  Now
  80         bool.
  81         (struct tui_source_window) <showing_source_p>: New method.
  82         (TUI_SRC_WIN): Change cast.
  83         * tui/tui-data.c (tui_initialize_static_data): Update.
  84
  85 2019-07-17  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  88         location_matches_p.
  89         * tui/tui-source.c (tui_source_window::location_matches_p): New
  90         method.
  91         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  92         method.
  93         * tui/tui-data.h (struct tui_source_window_base)
  94         <location_matches_p>: New method.
  95         (struct tui_source_window, struct tui_disasm_window)
  96         <location_matches_p>: Likewise.
  97
  98 2019-07-17  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-win.c (tui_set_win_height_command): Rename from
 101         tui_set_win_height.
 102         (tui_set_win_height_command): Remove.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-source.c (tui_source_window): New constructor.  Add
 107         observer.
 108         (~tui_source_window): New destructor.
 109         (tui_source_window::style_changed): New method.
 110         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 111         (tui_attach_detach_observers): Update.
 112         * tui/tui-data.h (struct tui_source_window): Make constructor not
 113         inline.  Add destructor.
 114         (struct tui_source_window) <style_changed>: New method.
 115         <m_observable>: New member.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 120         * tui/tui-win.c (tui_resize_all): Fix typo.
 121
 122 2019-07-17  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 125         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 126         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 127         * tui/tui-win.c (window_name_completer): Use foreach.
 128         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 129         (update_tab_width): Likewise.
 130         * tui/tui-layout.c (show_layout): Update.
 131         * tui/tui-data.h (class tui_window_iterator): New.
 132         (struct all_tui_windows): New.
 133         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 138         parameter.  Don't reference globals.
 139         (tui_reg_command): Update.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-regs.c (tui_show_registers): Simplify.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-regs.c (tui_show_registers): Update.
 148         (tui_show_register_group): Add win_info parameter.
 149
 150 2019-07-17  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 153         Rename from tui_display_reg_element_at_line.
 154         (tui_data_window::display_registers_from_line): Update.
 155         * tui/tui-data.h (struct tui_data_window)
 156         <display_reg_element_at_line>: New method.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-regs.h (tui_display_registers_from)
 161         (tui_display_registers_from_line): Don't declare.
 162         * tui/tui-windata.c (tui_data_window::display_all_data)
 163         (tui_data_window::refresh_all)
 164         (tui_data_window::do_scroll_vertical): Update.
 165         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 166         from tui_display_registers_from.
 167         (tui_display_reg_element_at_line): Update.
 168         (tui_data_window::display_registers_from_line): Rename from
 169         tui_display_registers_from_line.
 170         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 171         display_registers_from_line>: New methods.
 172
 173 2019-07-17  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 176         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 177         from tui_erase_data_content.
 178         (tui_data_window::display_all_data)
 179         (tui_data_window::refresh_all)
 180         (tui_data_window::do_scroll_vertical): Update.
 181         * tui/tui-regs.c (tui_show_registers): Update.
 182         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 183         New method.
 184
 185 2019-07-17  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 188         declare.
 189         * tui/tui-windata.c
 190         (tui_data_window::delete_data_content_windows): Rename from
 191         tui_delete_data_content_windows.
 192         (tui_data_window::display_all_data)
 193         (tui_data_window::do_scroll_vertical): Update.
 194         * tui/tui-data.h (struct tui_data_window)
 195         <delete_data_content_windows>: New method.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 200         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 201
 202 2019-07-17  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 205         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 206         from tui_display_all_data.
 207         * tui/tui-win.c
 208         (tui_data_window::do_make_visible_with_new_height): Update.
 209         * tui/tui-regs.c (tui_show_registers): Update.
 210         * tui/tui-layout.c (tui_set_layout): Update.
 211         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 212         method.
 213
 214 2019-07-17  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 217         * tui/tui-windata.c (tui_display_data_from): Remove.
 218         (tui_data_window::refresh_all): Update.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 223         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 224         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 225         tui_display_registers_from_line.
 226         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 227         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 228         "force_display" parameter.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 233         declare.
 234         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 235         Rename from tui_first_reg_element_no_inline.
 236         (tui_display_reg_element_at_line)
 237         (tui_display_registers_from_line): Update.
 238         * tui/tui-data.h (struct tui_data_window)
 239         <first_reg_element_no_inline>: New method.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-windata.c (tui_display_data_from)
 244         (tui_data_window::do_scroll_vertical): Update.
 245         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 246         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 247         Rename from tui_line_from_reg_element_no.
 248         (tui_display_registers_from_line): Update.
 249         * tui/tui-data.h (struct tui_data_window)
 250         <line_from_reg_element_no>: New method.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 255         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 256         tui_last_regs_line_no.
 257         (tui_display_reg_element_at_line)
 258         (tui_display_registers_from_line): Update.
 259         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 260         method.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         PR tui/24722:
 265         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 266         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 267         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 268         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 269         (tui_update_breakpoint_info): Likewise.
 270         * tui/tui-hooks.c (tui_event_create_breakpoint)
 271         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 272         Update.
 273
 274 2019-07-17  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 277
 278 2019-07-17  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-winsource.c (tui_update_source_window_as_is)
 281         (tui_update_source_windows_with_addr): Update.
 282         * tui/tui-source.h (tui_set_source_content)
 283         (tui_show_symtab_source): Add "win_info" parameter.
 284         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 285         parameter.
 286         (tui_show_symtab_source): Likewise.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-wingeneral.c
 291         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 296         (struct tui_cmd_window) <can_scroll>: New method.
 297         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 298         method.
 299
 300 2019-07-17  Tom Tromey  <tromey@adacore.com>
 301
 302         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 303         do_field_signed>: Rename.  Change type of "value".
 304         * ui-out.c (ui_out::field_signed): Rename from field_int.
 305         Change type of "value".
 306         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 307         type of "value".
 308         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 309         do_field_int.  Change type of "value".
 310         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 311         do_field_int.  Change type of "value".
 312         * tracepoint.c (trace_status_mi, tfind_1)
 313         (print_one_static_tracepoint_marker): Update.
 314         * thread.c (print_thread_info_1, print_selected_thread_frame):
 315         Update.
 316         * stack.c (print_frame, print_frame_info): Update.
 317         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 318         Update.
 319         * source.c (print_source_lines_base): Update.
 320         * skip.c (info_skip_command): Update.
 321         * record-btrace.c (btrace_ui_out_decode_error)
 322         (btrace_call_history_src_line): Update.
 323         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 324         Update.
 325         * progspace.c (print_program_space): Update.
 326         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 327         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 328         do_field_int.  Change type of "value".
 329         * mi/mi-out.c (mi_ui_out::do_table_begin)
 330         (mi_ui_out::do_table_header): Update.
 331         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 332         type of "value".
 333         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 334         (mi_cmd_data_list_changed_registers, output_register)
 335         (mi_cmd_data_read_memory, mi_load_progress)
 336         (mi_cmd_trace_frame_collected): Update.
 337         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 338         Update.
 339         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 340         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 341         (mi_cmd_var_list_children, varobj_update_one): Update.
 342         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 343         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 345         * inferior.c (print_inferior): Update.
 346         * gdb_bfd.c (print_one_bfd): Update.
 347         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 348         Update.
 349         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 350         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 351         do_field_int.  Change type of "value".
 352         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 353         do_field_int.  Change type of "value".
 354         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 355         (print_one_breakpoint_location, print_it_catch_fork)
 356         (print_one_catch_fork, print_it_catch_vfork)
 357         (print_one_catch_vfork, print_it_catch_solib)
 358         (print_it_catch_exec, print_it_ranged_breakpoint)
 359         (print_mention_watchpoint, print_mention_masked_watchpoint)
 360         (bkpt_print_it, update_static_tracepoint): Update.
 361         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 362         * break-catch-syscall.c (print_it_catch_syscall): Update.
 363         * ada-tasks.c (print_ada_task_info): Update.
 364         * ada-lang.c (print_it_exception, print_mention_exception):
 365         Update.
 366
 367 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         PR breakpoints/24541
 370         * gdbarch.c: Regenerate.
 371         * gdbarch.h: Regenerate.
 372         * gdbarch.sh: Adjust return type and parameter types for
 373         'stap_adjust_register'.
 374         (i386_stap_adjust_register): Adjust signature and return new
 375         register name.
 376         * stap-probe.c (stap_parse_register_operand): Adjust use of
 377         'gdbarch_stap_adjust_register'.
 378
 379 2019-07-17  Tom Tromey  <tromey@adacore.com>
 380
 381         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 382         declare VEC.
 383         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 384         std::vector.
 385         (struct s390_process_info): Add initializers.
 386         (s390_add_process): Use new.
 387         (s390_linux_nat_target::low_forget_process): Use delete.
 388         (s390_linux_nat_target::low_new_fork)
 389         (s390_linux_nat_target::stopped_by_watchpoint)
 390         (s390_linux_nat_target::low_prepare_to_resume)
 391         (s390_linux_nat_target::insert_watchpoint)
 392         (s390_linux_nat_target::insert_hw_breakpoint)
 393         (s390_linux_nat_target::remove_watchpoint)
 394         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 395
 396 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 397
 398         * aarch64-fbsd-nat.c: Include regcache.h.
 399         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 400         argument.
 401         (aarch64_fbsd_nat_target::fetch_registers)
 402         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 403         variable.
 404         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 405
 406 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 407
 408         * fbsd-nat.c: Include gdbarch.h.
 409
 410 2019-07-15  Tom Tromey  <tromey@adacore.com>
 411
 412         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 413
 414 2019-07-15  Tom Tromey  <tromey@adacore.com>
 415
 416         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 417         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 418         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 419         * cli-out.c (cli_ui_out::do_field_int): New method.
 420         * ui-out.c (ui_out::field_unsigned): New method.
 421         * symfile.c (generic_load): Use field_unsigned.
 422         (print_transfer_performance): Likewise.
 423         * record-btrace.c (ui_out_field_uint): Remove.
 424         (btrace_call_history_insn_range, btrace_call_history): Use
 425         field_unsigned.
 426         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 427         field_unsigned.
 428         * ui-out.h (class ui_out) <field_unsigned>: New method.
 429         <do_field_unsigned>: Likewise.
 430
 431 2019-07-15  Tom Tromey  <tromey@adacore.com>
 432
 433         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 434         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 435         * target.c (flash_erase_command): Use field_string.
 436         * infrun.c (print_signal_received_reason): Use field_string.
 437         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 438         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 439         field_string.
 440         * ada-tasks.c (print_ada_task_info): Use field_string.
 441
 442 2019-07-15  Tom Tromey  <tromey@adacore.com>
 443
 444         * target.c (flash_erase_command): Use field_core_addr.
 445         * symfile.c (generic_load): Use field_core_addr.
 446         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 447         Use field_core_addr.
 448         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 449         field_core_addr.
 450
 451 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 454         value if its desired type is smaller than a CORE_ADDR and signed.
 455
 456 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 457
 458         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 459         of changes to field names, and use new is_reference field to
 460         decide if a property is a reference or not.
 461         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 462         field.
 463         (struct dwarf2_property_baton): Update header comment, rename
 464         'referenced_type' to 'property_type' and update comments.
 465         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 466         default property type, store in property baton, update to take
 467         accound of renamed field.
 468         (read_func_scope): Update call to attr_to_dynamic_prop.
 469         (read_array_type): Likewise.
 470         (dwarf2_per_cu_addr_sized_int_type): New function.
 471         (read_subrange_index_type): Move type finding code to
 472         dwarf2_per_cu_addr_sized_int_type.
 473         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 474         (dwarf2_per_cu_addr_type): New function.
 475         (set_die_type): Update calls to attr_to_dynamic_prop.
 476
 477 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 478
 479         * dwarf2read.c (read_subrange_index_type): New function.
 480         (read_subrange_type): Move code into new function and call it.
 481         * gdbtypes.c (create_range_type): Add some asserts.
 482
 483 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 486         update return statements.
 487         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 488         declaration, and update comment to match.
 489         * gdbtypes.c (resolve_dynamic_array): Update call to
 490         dwarf2_evaluate_property to match new return type.
 491
 492 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * valarith.c (value_subscripted_rvalue): Change lowerbound
 495         parameter type from int to LONGEST.
 496         * value.h (value_subscripted_rvalue): Likewise in declaration.
 497
 498 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * cli/cli-utils.c (info_print_command_completer): New function.
 501         * cli/cli-utils.h: Add 'completer.h' include, and forward
 502         declaration for 'struct cmd_list_element'.
 503         (info_print_command_completer): Declare.
 504         * stack.c (_initialize_stack): Add completer for 'info locals' and
 505         'info args'.
 506         * symtab.c (_initialize_symtab): Add completer for 'info
 507         variables' and 'info functions'.
 508         * NEWS: Mention completion for additional info commands.
 509
 510 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 511
 512         * cli/cli-utils.c (extract_info_print_args): Delete.
 513         (extract_arg_maybe_quoted): Delete.
 514         (info_print_options_defs): New variable.
 515         (make_info_print_options_def_group): New function.
 516         (extract_info_print_options): Define new function.
 517         * cli/cli-utils.h (extract_info_print_args): Delete.
 518         (struct info_print_options): New structure.
 519         (extract_info_print_options): Declare new function.
 520         * stack.c (info_locals_command): Update to use new
 521         extract_info_print_options, also add a header comment.
 522         (info_args_command): Likewise.
 523         * symtab.c (info_variables_command): Likewise.
 524         (info_functions_command): Likewise.
 525
 526 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 529         to extract string arguments.
 530         * common/common-utils.c (extract_string_maybe_quoted): New function.
 531         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 532
 533 2019-07-11  Tom Tromey  <tromey@adacore.com>
 534
 535         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 536         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 537         * top.h (gdbinit): Don't declare.
 538         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 539         into...
 540         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 541         * top.c (gdb_init): Don't call init_cli_cmds.
 542         (gdbinit): Remove.
 543         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 544
 545 2019-07-11  Tom Tromey  <tromey@adacore.com>
 546
 547         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 548         after it has been moved.
 549
 550 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 551
 552         * valops.c (value_must_coerce_to_target): Change return type to
 553         bool.
 554         * value.h (value_must_coerce_to_target): Likewise.
 555
 556 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 557
 558         * breakpoint.c (is_hardware_watchpoint): Remove
 559         forward-declaration.
 560         (is_masked_watchpoint): Change return type to bool.
 561         (is_tracepoint): Likewise.
 562         (is_breakpoint): Likewise.
 563         (is_hardware_watchpoint): Likewise.
 564         (is_watchpoint): Likewise.
 565         (is_no_memory_software_watchpoint): Likewise.
 566         (is_catchpoint): Likewise.
 567         (breakpoint_1): Make FILTER parameter's return type bool.
 568         is_masked_watchpoint): Change return type to bool.
 569         (save_breakpoints): Make FILTER parameter's return type bool.
 570         * breakpoint.h (is_breakpoint): Change return type to bool.
 571         (is_watchpoint): Likewise.
 572         (is_catchpoint): Likewise.
 573         (is_tracepoint): Likewise.
 574
 575 2019-07-10  Tom Tromey  <tom@tromey.com>
 576
 577         * defs.h: Don't include gdbarch.h.
 578         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 579         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 580         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 581         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 582         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 583         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 584         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 585         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 586         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 587         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 588         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 589         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 590         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 591         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 592         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 593         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 594         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 595         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 596         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 597         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 598         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 599         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 600         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 601         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 602         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 603         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 604         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 605
 606 2019-07-10  Tom Tromey  <tromey@adacore.com>
 607
 608         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 609         * breakpoint.c (init_ada_exception_breakpoint): Register as
 610         bp_catchpoint.
 611         (print_one_breakpoint_location, print_one_breakpoint): Use
 612         is_ada_exception_catchpoint.
 613         * ada-lang.c (class ada_catchpoint_location): Pass
 614         bp_loc_software_breakpoint to bp_location constructor.
 615         (is_ada_exception_catchpoint): New function.
 616
 617 2019-07-10  Tom Tromey  <tromey@adacore.com>
 618
 619         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 620         VEC.
 621         (struct arm_exidx_entry): New method operator<.
 622         (struct arm_exidx_data) <section_maps>: Change type.
 623         (arm_exidx_data_free): Remove.
 624         (arm_exidx_data_key): Change type.  Move lower.
 625         (arm_exidx_new_objfile): Update.
 626         (arm_compare_exidx_entries): Remove.
 627         (arm_find_exidx_entry, _initialize_arm_tdep)
 628
 629 2019-07-10  Tom Tromey  <tromey@adacore.com>
 630
 631         * solib-spu.c (ocl_program_data_key): Change type.
 632         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 633         Update.
 634
 635 2019-07-10  Tom Tromey  <tromey@adacore.com>
 636
 637         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 638         (struct solib_aix_inferior_data) <library_list>: Change type.
 639         (solib_aix_inferior_data_handle): Change type.
 640         (get_solib_aix_inferior_data): Update.
 641         (solib_aix_free_library_list): Remove.
 642         (library_list_start_library): Update.
 643         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 644         return type.
 645         (solib_aix_get_library_list)
 646         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 647         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 648
 649 2019-07-10  Tom Tromey  <tromey@adacore.com>
 650
 651         * solib-dsbt.c (struct dsbt_info): Add initializers.
 652         (solib_dsbt_pspace_data): Change type.
 653         (dsbt_pspace_data_cleanup): Remove.
 654         (get_dsbt_info, _initialize_dsbt_solib): Update.
 655
 656 2019-07-10  Tom Tromey  <tromey@adacore.com>
 657
 658         * spu-tdep.c (spu_overlay_data): Change type.
 659         (spu_get_overlay_table, spu_overlay_new_objfile)
 660         (_initialize_spu_tdep): Update.
 661
 662 2019-07-10  Tom Tromey  <tromey@adacore.com>
 663
 664         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 665         destructor.
 666         (dbx_objfile_data_key): Change type and declare later.
 667         (DBX_SYMFILE_INFO): Rewrite.
 668         * dbxread.c (dbx_objfile_data_key): Change type.
 669         (dbx_symfile_init): Update.
 670         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 671         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 672         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 673
 674 2019-07-10  Tom Tromey  <tromey@adacore.com>
 675
 676         * jit.c (jit_program_space_key): Change type.  Move lower.
 677         (get_jit_program_space_data): Update.
 678         (jit_program_space_data_cleanup): Remove.
 679         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 680         Update.
 681         (struct jit_program_space_data): Add initializers.
 682
 683 2019-07-10  Tom Tromey  <tromey@adacore.com>
 684
 685         * solib-darwin.c (struct darwin_info): Add initializers.
 686         (solib_darwin_pspace_data): Change type.
 687         (darwin_pspace_data_cleanup): Remove.
 688         (get_darwin_info, _initialize_darwin_solib): Update.
 689
 690 2019-07-10  Tom Tromey  <tromey@adacore.com>
 691
 692         * remote-sim.c (struct sim_inferior_data): Add initializers,
 693         constructor, and destructor.
 694         (sim_inferior_data_key): Change type.  Move lower.
 695         (check_for_duplicate_sim_descriptor): Update.
 696         (get_sim_inferior_data): Use new.  Update.
 697         (~sim_inferior_data_cleanup): Rename from
 698         sim_inferior_data_cleanup.  Simplify.
 699         (gdbsim_close_inferior, simulator_command)
 700         (sim_command_completer, _initialize_remote_sim): Update.
 701         (next_pid, INITIAL_PID): Move earlier.
 702
 703 2019-07-10  Tom Tromey  <tromey@adacore.com>
 704
 705         * python/python-internal.h (create_thread_object): Return
 706         gdbpy_ref.
 707         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 708         * python/py-inferior.c (struct threadlist_entry): Add
 709         constructor.
 710         <thread_obj>: Now a gdbpy_ref.
 711         (thread_to_thread_object): Update.
 712         (add_thread_object): Use new.
 713         (delete_thread_object): Use delete.
 714         (infpy_threads): Update.
 715         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 716         GIL.
 717
 718 2019-07-10  Tom Tromey  <tromey@adacore.com>
 719
 720         * valops.c (value_cast): Specialize error message for Ada.
 721
 722 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 723
 724         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 725
 726 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 727
 728         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 729         bpstat_should_step): Return bool, adjust comments.
 730         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 731         bpstat_should_step): Likewise.
 732
 733 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 734
 735         * features/Makefile: Use feature target descriptions for Arm.
 736         * features/arm/arm-core.c: Generate new file.
 737         * features/arm/arm-fpa.c: Likewise.
 738         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 739         * features/arm/arm-m-profile.c: Likewise.
 740         * features/arm/arm-vfpv2.c: Likewise.
 741         * features/arm/arm-vfpv3.c: Likewise.
 742         * features/arm/xscale-iwmmxt.c: Likewise.
 743         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 744
 745 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 746
 747         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 748         ptrace earlier.
 749
 750 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 751
 752         * features/aarch64-pauth.c: Regenerate.
 753
 754 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 755
 756         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 757         bool.
 758         (bpstat_what): Use false instead of 0.
 759
 760 2019-07-09  Pedro Alves  <palves@redhat.com>
 761
 762         * break-catch-throw.c (is_exception_catchpoint): New.
 763         * breakpoint.c (print_one_breakpoint_location): New parameter
 764         'raw_loc'.  Handle it.  Use
 765         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 766         looking at the breakpoint's type.
 767         (print_one_breakpoint): If handling "maint info breakpoints", also
 768         print locations of exception catchpoints.
 769         * breakpoint.h (is_exception_catchpoint): Declare.
 770
 771 2019-07-09  Pedro Alves  <palves@redhat.com>
 772
 773         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 774         "addr" field.
 775         (allocate_location_exception_catchpoint): New.
 776         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 777         (initialize_throw_catchpoint_ops): Install
 778         allocate_location_exception_catchpoint as allocate_location
 779         method.
 780         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 781         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 782         bp_loc_other.
 783         (breakpoint_address_is_meaningful): Delete.
 784         (bl_address_is_meaningful): New.
 785         (breakpoint_locations_match): Adjust comment.
 786         (bp_location_from_bp_type): New, factored out of...
 787         (bp_location::bp_location(breakpoint *)): ... this.
 788         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 789         factored out of...
 790         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 791         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 792         breakpoint_address_is_meaningful.
 793         (bp_locations_compare): Adjust comment.
 794         (update_global_location_list): Use bl_address_is_meaningful
 795         instead of breakpoint_address_is_meaningful.
 796         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 797         explicit.
 798         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 799         * python/py-breakpoint.c (bppy_get_location): No longer check
 800         whether location is null.
 801
 802 2019-07-09  Pedro Alves  <palves@redhat.com>
 803
 804         PR c++/15468
 805         * breakpoint.c (print_one_breakpoint_location): Remove
 806         single-location assert.
 807
 808 2019-07-09  Tom Tromey  <tom@tromey.com>
 809
 810         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 811         * configure: Rebuild.
 812         * configure.ac: Change common to gdbsupport.
 813         * gdbsupport: Rename from common.
 814         * acinclude.m4: Change common to gdbsupport.
 815         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 816         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 817         gdbsupport.
 818         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 819         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 820         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 821         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 822         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 823         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 824         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 825         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 826         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 827         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 828         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 829         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 830         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 831         coff-pe-read.c, command.h, compile/compile-c-support.c,
 832         compile/compile-c.h, compile/compile-cplus-symbols.c,
 833         compile/compile-cplus-types.c, compile/compile-cplus.h,
 834         compile/compile-loc2c.c, compile/compile.c, completer.c,
 835         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 836         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 837         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 838         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 839         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 840         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 841         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 842         features/aarch64-core.c, features/aarch64-fpu.c,
 843         features/aarch64-pauth.c, features/aarch64-sve.c,
 844         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 845         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 846         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 847         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 848         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 849         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 850         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 851         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 852         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 853         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 854         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 855         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 856         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 857         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 858         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 859         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 860         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 861         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 862         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 863         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 864         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 865         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 866         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 867         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 868         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 869         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 870         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 871         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 872         minsyms.c, mips-linux-tdep.c, namespace.h,
 873         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 874         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 875         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 876         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 877         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 878         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 879         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 880         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 881         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 882         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 883         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 884         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 885         procfs.c, producer.c, progspace.h, psymtab.h,
 886         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 887         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 888         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 889         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 890         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 891         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 892         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 893         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 894         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 895         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 896         target-memory.c, target.c, target.h, target/waitstatus.c,
 897         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 898         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 899         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 900         unittests/array-view-selftests.c,
 901         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 902         unittests/common-utils-selftests.c,
 903         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 904         unittests/format_pieces-selftests.c,
 905         unittests/function-view-selftests.c,
 906         unittests/lookup_name_info-selftests.c,
 907         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 908         unittests/mkdir-recursive-selftests.c,
 909         unittests/observable-selftests.c,
 910         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 911         unittests/parse-connection-spec-selftests.c,
 912         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 913         unittests/scoped_fd-selftests.c,
 914         unittests/scoped_mmap-selftests.c,
 915         unittests/scoped_restore-selftests.c,
 916         unittests/string_view-selftests.c, unittests/style-selftests.c,
 917         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 918         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 919         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 920         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 921         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 922         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 923
 924 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 927         bool value.
 928         (decode_digits_ordinary): Set explicit_line field in sal.
 929         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 930         symtab_and_line that was set on an explicit line number in
 931         assembler code.  Do always update the recorded symtab and line if
 932         we do skip the prologue.
 933
 934 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * breakpoint.c (set_breakpoint_location_function): Remove
 937         explicit_loc parameter.
 938         (momentary_breakpoint_from_master): Update call to
 939         set_breakpoint_location_function.
 940         (add_location_to_breakpoint): Likewise.
 941
 942 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 945         required features based on default bfd type when no specific bfd
 946         is present.
 947
 948 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 949
 950         * NEWS: Mention that GDB printf and eval commands can now print
 951         C-style and Ada-style convenience var strings without
 952         calling the inferior.
 953         * printcmd.c (printf_c_string): Locally print GDB internal var
 954         instead of transiting via the inferior.
 955         (printf_wide_c_string): Likewise.
 956
 957 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 958
 959         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 960
 961 2019-07-04  Tom Tromey  <tom@tromey.com>
 962
 963         PR tui/24724:
 964         * tui/tui-winsource.c (tui_clear_source_content): Update.
 965         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 966         (tui_update_breakpoint_info): Update.
 967         (tui_set_exec_info_content): Update.
 968         * tui/tui-source.c (tui_set_source_content_nil): Update.
 969         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 970         has_break.
 971         * tui/tui-data.h (enum tui_bp_flag): New.
 972         (tui_bp_flags): New enum flags type.
 973         (struct tui_source_element) <break_mode>: Change type.  Rename
 974         from has_break.
 975         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 976         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 977         constants.
 978         * tui/tui-winsource.h: Fix comment.
 979
 980 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 981
 982         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 983         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 984         (store_fpregs_to_thread)
 985         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 986         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 987         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 988         (IWMMXT_REGS_SIZE): Add define.
 989         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 990         (fetch_vfp_regs, store_vfp_regs)
 991         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 992         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 993
 994 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 995
 996         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 997         defines.
 998         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 999         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1000         (ARM_INT_REGISTER_SIZE): ...to this.
1001         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1002         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1003         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1004         (arm_linux_collect_gregset, supply_nwfpe_register)
1005         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1006         defines.
1007         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1008         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1009         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1010         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1011         (arm_return_in_memory, arm_store_return_value)
1012         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1013         (arm_record_ld_st_multiple): Likewise.
1014         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1015         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1016
1017 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1018
1019         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1020         AARCH64_DISPLACED_MODIFIED_INSNS.
1021         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1022         (aarch64_displaced_step_copy_insn): Likewise.
1023         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1024         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1025         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1026         ARM_DISPLACED_MODIFIED_INSNS.
1027         * arm-tdep.c (arm_gdbarch_init): Likewise.
1028         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1029         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1030         (struct arm_displaced_step_closure): Use
1031         ARM_DISPLACED_MODIFIED_INSNS.
1032
1033 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1034
1035         * features/Makefile: Remove unused xml files.
1036         * features/aarch64.xml: Remove.
1037         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1038         * features/i386/amd64-avx-avx512.xml: Remove.
1039         * features/i386/amd64-avx-linux.xml: Remove.
1040         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1041         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1042         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1043         * features/i386/amd64-avx-mpx.xml: Remove.
1044         * features/i386/amd64-avx.xml: Remove.
1045         * features/i386/amd64-linux.xml: Remove.
1046         * features/i386/amd64-mpx-linux.xml: Remove.
1047         * features/i386/amd64-mpx.xml: Remove.
1048         * features/i386/amd64.xml: Remove.
1049         * features/i386/i386-avx-avx512-linux.xml: Remove.
1050         * features/i386/i386-avx-avx512.xml: Remove.
1051         * features/i386/i386-avx-linux.xml: Remove.
1052         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1053         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1054         * features/i386/i386-avx-mpx-linux.xml: Remove.
1055         * features/i386/i386-avx-mpx.xml: Remove.
1056         * features/i386/i386-avx.xml: Remove.
1057         * features/i386/i386-linux.xml: Remove.
1058         * features/i386/i386-mmx-linux.xml: Remove.
1059         * features/i386/i386-mmx.xml: Remove.
1060         * features/i386/i386-mpx-linux.xml: Remove.
1061         * features/i386/i386-mpx.xml: Remove.
1062         * features/i386/i386.xml: Remove.
1063         * features/i386/x32-avx-avx512-linux.xml: Remove.
1064         * features/i386/x32-avx-linux.xml: Remove.
1065         * features/i386/x32-linux.xml: Remove.
1066
1067 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1068
1069         * regformats/aarch64.dat: Remove.
1070         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1071         * regformats/i386/amd64-avx-linux.dat: Remove.
1072         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1073         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1074         * regformats/i386/amd64-linux.dat: Remove.
1075         * regformats/i386/amd64-mpx-linux.dat: Remove.
1076         * regformats/i386/amd64.dat: Remove.
1077         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1078         * regformats/i386/i386-avx-linux.dat: Remove.
1079         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1080         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1081         * regformats/i386/i386-linux.dat: Remove.
1082         * regformats/i386/i386-mmx-linux.dat: Remove.
1083         * regformats/i386/i386-mpx-linux.dat: Remove.
1084         * regformats/i386/i386.dat: Remove.
1085         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1086         * regformats/i386/x32-avx-linux.dat: Remove.
1087         * regformats/i386/x32-linux.dat: Remove.
1088
1089 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1090
1091         * aarch64-tdep.c: Remove xml self tests.
1092         * amd64-linux-tdep.c: Likewise.
1093         * amd64-tdep.c: Likewise.
1094         * i386-linux-tdep.c: Likewise.
1095         * i386-tdep.c: Likewise.
1096
1097 2019-07-03  Pedro Alves  <palves@redhat.com>
1098
1099         PR cli/24732
1100         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1101         (pipe_cmd_option_defs): New.
1102         (make_pipe_cmd_options_def_group): New.
1103         (pipe_command): Use gdb::option::process_options.
1104         (pipe_command_completer): New function.
1105         (_initialize_cli_cmds): Install completer for "pipe" command.
1106
1107 2019-07-03  Pedro Alves  <palves@redhat.com>
1108
1109         * cli/cli-option.c (union option_value) <string>: New field.
1110         (struct option_def_and_value): Add ctor, move ctor, dtor and
1111         use DISABLE_COPY_AND_ASSIGN.
1112         (option_def_and_value::clear_value): New.
1113         (parse_option, save_option_value_in_ctx, get_val_type_str)
1114         (add_setshow_cmds_for_options): Handle var_string.
1115         * cli-option.h (union option_def::var_address) <string>: New
1116         field.
1117         (struct string_option_def): New.
1118         * maint-test-options.c (struct test_options_opts): Add default
1119         ctor and use DISABLE_COPY_AND_ASSIGN.
1120         <string_opt>: New field.
1121         (test_options_opts::~test_options_opts): New.
1122         (test_options_opts::dump): Also dump "-string".
1123         (test_options_option_defs): Install "string.
1124
1125 2019-07-03  Pedro Alves  <palves@redhat.com>
1126
1127         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1128         option_value with a null enumeration.
1129         (complete_options): Save the option values in the context.
1130         (save_option_value_in_ctx): New, factored out from ...
1131         (process_options): ... here.
1132         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1133         of the function.
1134         * maint-test-options.c (test_options_opts::dump): New, factored
1135         out from ...
1136         (maintenance_test_options_command_mode): ... here.
1137         (maintenance_test_options_command_completion_result): Delete.
1138         (maintenance_test_options_command_completion_text): Update
1139         comment.
1140         (maintenance_show_test_options_completion_result): Change
1141         prototype.  Just print
1142         maintenance_test_options_command_completion_text.
1143         (save_completion_result): New.
1144         (maintenance_test_options_completer_mode): Pass options context to
1145         complete_options, and then save a dump.
1146         (_initialize_maint_test_options): Use add_cmd to install "maint
1147         show test-options-completion-result".
1148
1149 2019-07-03  Pedro Alves  <palves@redhat.com>
1150
1151         * NEWS (New commands): Mention "with" and "maint with".
1152         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1153         (with_command, with_command_completer): New.
1154         (pipe_command): Adjust to new repeat_previous
1155         interface.
1156         (_initialize_cli_cmds): Install the "with" command and its "w"
1157         alias.
1158         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1159         declarations.
1160         * cli/cli-setshow.c (parse_cli_var_uinteger)
1161         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1162         argument strings for all var_types.
1163         (get_setshow_command_value_string): New, factored out from ...
1164         (do_show_command): ... this.
1165         * cli/cli-setshow.h: Include <string>.
1166         (get_setshow_command_value_string): Declare.
1167         * command.h (repeat_previous): Now returns const char *.  Adjust
1168         comment.
1169         * maint.c: Include "cli/cli-cmds.h".
1170         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1171         (_initialize_maint_cmds): Register the "maintenance with" command.
1172         * top.c (repeat_previous): Move bits from pipe_command here:
1173         Return the saved command line, if any; error out if there's no
1174         command to relaunch.
1175
1176 2019-07-03  Pedro Alves  <palves@redhat.com>
1177
1178         * NEWS (New commands): Mention "maint set/show test-settings"
1179         instead of "maint test-settings".
1180         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1181         (maintenance_test_settings_set_list): Rename to ...
1182         (maintenance_set_test_settings_list): ... this.
1183         (maintenance_test_settings_show_list): Rename to  ...
1184         (maintenance_show_test_settings_list): ... this.
1185         (maintenance_test_settings_cmd): Delete.
1186         (maintenance_test_settings_set_cmd): ...
1187         (maintenance_set_test_settings_cmd): ... this.
1188         (maintenance_test_settings_show_cmd): ...
1189         (maintenance_show_test_settings_cmd): ... this.
1190         (maintenance_test_settings_show_value_cmd):
1191         (maintenance_show_test_settings_value_cmd): ... this.
1192         (_initialize_maint_test_settings): No longer install the "maint
1193         test-settings" prefix command.  Rename "maint test-settings set"
1194         to "maint set test-settings", and "maint test-settings show" to
1195         "maint show test-settings".  Adjust all subcommands.
1196
1197 2019-07-03  Pedro Alves  <palves@redhat.com>
1198
1199         * maint-test-settings.c: Fix file's intro comment.  Replace all
1200         references to "test-options" with references to "test-settings",
1201         in comments.
1202
1203 2019-07-03  Pedro Alves  <palves@redhat.com>
1204
1205         * maint-test-settings.c (maintenance_test_settings_xxx)
1206         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1207         New.
1208         (maintenance_test_settings_enums): Use them.
1209         (maintenance_test_settings_enum): Default to
1210         maintenance_test_settings_xxx.
1211         (_initialize_maint_test_settings): Initialize
1212         MAINTENANCE_TEST_SETTINGS_FILENAME.
1213
1214 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1215
1216         * breakpoint.h (remove_breakpoints_inf): Change return type to
1217         void, move function documentation here.
1218         * breakpoint.c (remove_breakpoints_inf): Change return type to
1219         void, move function documentation to header.
1220
1221 2019-07-02  Pedro Alves  <palves@redhat.com>
1222
1223         * NEWS (Completion improvements): Mention "info threads".
1224         * thread.c (struct info_threads_opts, info_threads_option_defs)
1225         (make_info_threads_options_def_group): New.
1226         (info_threads_command): Use gdb::option::process_options.
1227         (info_threads_command_completer): New.
1228         (_initialize_thread): Use gdb::option::build_help to build the
1229         help text for "info threads".
1230
1231 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1232
1233         * defs.h (generic_load): Move from here...
1234         * symfile.h (generic_load): ... to here.  Rename name parameter
1235         to args.
1236         * symfile.c (generic_load): Add comment.
1237
1238 2019-07-01  Tom Tromey  <tromey@adacore.com>
1239
1240         * dwarf2read.c
1241         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1242         declaration of without_params.  Fix formatting.
1243
1244 2019-07-01  Tom Tromey  <tromey@adacore.com>
1245
1246         * ada-exp.y (find_primitive_type): Update.
1247         * ada-lang.h (ada_lookup_symbol): Update.
1248         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1249         parameter.
1250         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1251
1252 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1253
1254         PR breakpoints/24541
1255         * gdbarch.c: Regenerate.
1256         * gdbarch.h: Regenerate.
1257         * gdbarch.sh: Add 'stap_adjust_register'.
1258         * i386-tdep.c: Include '<unordered_set>'.
1259         (i386_stap_adjust_register): New function.
1260         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1261         * stap-probe.c (stap_parse_register_operand): Call
1262         'gdbarch_stap_adjust_register'.
1263
1264 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1265
1266         PR python/24742
1267         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1268         * python/python.c (do_start_initialization): Use 'xmalloc'
1269         instead of 'PyMem_Malloc'.
1270
1271 2019-06-28  Tom Tromey  <tromey@adacore.com>
1272
1273         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1274         for Ada.
1275
1276 2019-06-27  Tom Tromey  <tromey@adacore.com>
1277
1278         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1279         objfile_key.
1280         (arm_find_mapping_symbol, arm_record_special_symbol)
1281         (_initialize_arm_tdep): Update.
1282         (arm_objfile_data_free): Remove.
1283
1284 2019-06-27  Tom Tromey  <tromey@adacore.com>
1285
1286         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1287         to cp_print_static_field.
1288
1289 2019-06-26  Tom Tromey  <tromey@adacore.com>
1290
1291         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1292         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1293         declare.
1294
1295 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1296
1297         * features/aarch64-core.c (create_feature_aarch64_core):
1298         Regenerate.
1299         * features/aarch64-core.xml: Add cpsr flags.
1300
1301 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1302
1303         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1304         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1305
1306 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1307
1308         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1309         field.
1310         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1311         use.
1312         (arm_record_special_symbol): Don't insert new symbol in sorted
1313         position, push it at the end.
1314
1315 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1316
1317         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1318         (arm_mapping_symbol_s): Remove.
1319         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1320         (arm_mapping_symbol_vec): New typedef.
1321         (struct arm_per_objfile): Add constructor.
1322         <section_maps>: Change type to
1323         std::unique_ptr<arm_mapping_symbol_vec[]>.
1324         (arm_compare_mapping_symbols): Remove.
1325         (arm_find_mapping_symbol): Adjust to section_maps type change.
1326         (arm_objfile_data_free): Call delete on arm_per_objfile.
1327         (arm_record_special_symbol): Adjust to section_maps type change.
1328         Allocate arm_per_objfile with new.
1329
1330 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1331
1332         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1333         with the command prefix.
1334
1335 2019-06-25  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1338         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1339
1340 2019-06-25  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1343         type.
1344         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1345         protected.
1346
1347 2019-06-25  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-winsource.c
1350         (tui_source_window_base::set_is_exec_point_at): Add check against
1351         LOA_ADDRESS.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-source.c (tui_set_source_content): Don't check before
1356         xfree.
1357         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1358
1359 2019-06-25  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-winsource.h (tui_update_source_window_as_is)
1362         (tui_alloc_source_buffer, tui_line_is_displayed)
1363         (tui_addr_is_displayed): Change type of win_info.
1364         * tui/tui-winsource.c (tui_update_source_window_as_is)
1365         (tui_clear_source_content, tui_show_source_line)
1366         (tui_show_source_content, tui_source_window_base::refill)
1367         (tui_source_window_base::set_is_exec_point_at)
1368         (tui_source_window_base::set_is_exec_point_at)
1369         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1370         (tui_alloc_source_buffer, tui_line_is_displayed)
1371         (tui_addr_is_displayed): Change type of win_info.  Update.
1372         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1373         (tui_source_window_base::do_make_visible_with_new_height):
1374         Update.
1375         * tui/tui-source.c (tui_set_source_content)
1376         (tui_set_source_content_nil)
1377         (tui_source_window::do_scroll_vertical): Update.
1378         * tui/tui-layout.c (show_layout): Update.
1379         * tui/tui-disasm.c (tui_set_disassem_content)
1380         (tui_disasm_window::do_scroll_vertical): Update.
1381         * tui/tui-data.h (tui_win_content): Remove.
1382         (struct tui_gen_win_info) <content, content_size>: Remove.
1383         (struct tui_source_element): Add initializers and destructor.
1384         (union tui_which_element, struct tui_win_element): Remove.
1385         (struct tui_source_window_base) <content>: New field.
1386         (struct tui_data_window): Remove destructor.
1387         (tui_alloc_content, tui_free_win_content)
1388         (tui_free_all_source_wins_content): Don't declare.
1389         * tui/tui-data.c (tui_initialize_static_data): Update.
1390         (init_content_element, tui_alloc_content): Remove.
1391         (~tui_gen_win_info): Update.
1392         (~tui_data_window, tui_free_all_source_wins_content)
1393         (tui_free_win_content, free_content, free_content_elements):
1394         Remove.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-winsource.h (tui_clear_source_content)
1399         (tui_erase_source_content, tui_show_source_content): Change type
1400         of win_info.
1401         * tui/tui-winsource.c (tui_clear_source_content)
1402         (tui_erase_source_content, tui_show_source_content): Change type
1403         of win_info.
1404         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1405         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1406         win_info.
1407         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1408         win_info.
1409         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-winsource.c (tui_clear_source_content)
1414         (tui_source_window_base::set_is_exec_point_at): Update.
1415         * tui/tui-source.c (tui_set_source_content_nil): Update.
1416         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1417         a bool.
1418         * tui/tui-data.c (init_content_element): Update.
1419
1420 2019-06-25  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1423         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1424         * tui/tui-layout.c (init_and_make_win): Update.
1425         * tui/tui.h (enum tui_win_type): Update.
1426         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1427         tui_win_is_auxillary.
1428         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1429         tui_win_is_auxillary.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1434         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1435         (tui_delete_data_content_windows, tui_display_all_data)
1436         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1437         Update.
1438         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1439         * tui/tui-regs.c (tui_last_regs_line_no)
1440         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1441         (tui_show_registers): Update.
1442         (tui_show_register_group): Return void.  Update.
1443         (tui_display_registers_from, tui_display_reg_element_at_line)
1444         (tui_display_registers_from_line, tui_check_register_values):
1445         Update.
1446         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1447         member.
1448         (struct tui_data_window) <regs_content>: Now a std::vector.
1449         <regs_content_count>: Remove.
1450         (tui_add_content_elements, tui_free_data_content): Don't declare.
1451         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1452         (init_content_element): Remove DATA_WIN case.  Add assert.
1453         (tui_add_content_elements): Remove.
1454         (tui_data_window): Update.
1455         (tui_free_data_content): Remove.
1456         (free_content_elements): Remove DATA_WIN case.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-data.c (tui_data_item_window): Update.
1461         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1462         * tui/tui-windata.c (tui_display_all_data)
1463         (tui_display_data_from_line): Update.
1464         (tui_check_data_values): Remove.
1465         * tui/tui-regs.c (tui_show_register_group)
1466         (tui_display_reg_element_at_line): Update.
1467         * tui/tui-hooks.c (tui_register_changed)
1468         (tui_refresh_frame_and_register_information): Call
1469         tui_check_register_values.
1470         * tui/tui-data.h (struct tui_data_window) <data_content,
1471         data_content_count, data_type>: Remove.
1472         (enum tui_data_type): Remove.
1473
1474         * tui/tui-data.c (tui_data_window::clear_detail)
1475         (~tui_data_window): Update.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1480         declare.
1481         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1482         Rename from tui_first_data_item_displayed.  Update.
1483         (tui_data_window::refresh_all)
1484         (tui_data_window::do_scroll_vertical): Update.
1485         * tui/tui-data.h (struct tui_data_window)
1486         <first_data_item_displayed>: Declare new method.
1487
1488 2019-06-25  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1491         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1492         contents...
1493         (tui_initialize_static_data): ...here.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1498         (tui_display_registers_from, tui_check_register_values): Update.
1499         (tui_display_register): Remove win_info parameter; update.
1500         (tui_get_register): Change type of parameters.
1501         * tui/tui-data.h (struct tui_data_element): Remove.
1502         (union tui_which_element) <data>: Remove.
1503         <data_window>: Change type.
1504         (struct tui_data_item_window): New.
1505         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1506         case.  Add assert.
1507         (~tui_data_item_window): New destructor.
1508         (free_content_elements): Remove DATA_ITEM_WIN case.
1509
1510 2019-06-25  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1513         Remove.
1514
1515 2019-06-25  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-data.h (struct tui_command_element): Remove.
1518         (union tui_which_element) <command>: Remove.
1519         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1520         assert.
1521         (free_content_elements): Remove CMD_WIN case.
1522
1523 2019-06-25  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-layout.c (tui_set_layout): Update.
1526         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1527         * tui/tui-data.c (layout_def): Update.
1528
1529 2019-06-25  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1532         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1533         (tui_source_window_base::set_new_height): Update.
1534         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1535         Update.
1536         (tui_set_locator_fullname, tui_set_locator_info)
1537         (tui_show_frame_info): Update.
1538         * tui/tui-source.c (tui_set_source_content)
1539         (tui_source_is_displayed): Update.
1540         * tui/tui-layout.c (show_source_disasm_command, show_data)
1541         (show_source_or_disasm_and_command): Update.
1542         * tui/tui-disasm.c (tui_set_disassem_content)
1543         (tui_get_begin_asm_address): Update.
1544         * tui/tui-data.h (struct tui_locator_element): Remove.
1545         (union tui_which_element) <locator>: Remove.
1546         (struct tui_locator_window): New.
1547         (tui_locator_win_info_ptr): Change return type.
1548         * tui/tui-data.c (_locator): Change type.
1549         (tui_locator_win_info_ptr): Change return type.
1550         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1551         (tui_alloc_content): Add assert.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-winsource.c
1556         (tui_exec_info_window::maybe_allocate_content): New method.
1557         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1558         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1559         (make_source_or_disasm_window): Add cast.
1560         * tui/tui-data.h (union tui_which_element) <simple_string>:
1561         Remove.
1562         (struct tui_source_info): New.
1563         (struct tui_source_window_base) <execution_info>: Change type.
1564         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1565         case, and add assert.
1566         (tui_alloc_content): Add assert.
1567
1568 2019-06-25  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1571         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1572         * tui/tui-data.c (tui_alloc_win_info): Remove.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1577         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1578         can_highlight.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1583         make_visible_with_new_height method.
1584         (tui_win_info::make_visible_with_new_height): New method.
1585         (tui_source_window_base::do_make_visible_with_new_height)
1586         (tui_data_window::do_make_visible_with_new_height)
1587         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1588         (make_visible_with_new_height): Remove.
1589         (tui_resize_all, tui_adjust_win_heights): Use
1590         make_visible_with_new_height method.
1591         * tui/tui-data.h (struct tui_win_info)
1592         <do_make_visible_with_new_height, make_visible_with_new_height>:
1593         New methods.
1594         (struct tui_source_window_base, struct tui_data_window)
1595         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1596         methods.
1597
1598 2019-06-25  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1601         method.
1602         (update_tab_width): Call update_tab_width method.
1603         * tui/tui-data.h (struct tui_win_info)
1604         (struct tui_source_window_base) <update_tab_width>: New methods.
1605
1606 2019-06-25  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1609         parameter.
1610         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1611         parameter.
1612         (tui_gen_win_info::make_visible): Update.
1613         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1614         parameter.
1615         * tui/tui-data.h (enum tui_box): New enum.
1616         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1621         init_and_make_win for EXEC_INFO_WIN.
1622         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1623         longer inline.
1624         (struct tui_win_info) <~tui_win_info>: Inline.
1625         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1626         Don't declare.
1627         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1628         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1629         Remove.
1630         (tui_initialize_static_data): Update.
1631         (~tui_gen_win_info): Handle more cleanup here.
1632         (~tui_source_window_base): Delete "execution_info".
1633         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-layout.c (make_command_window): Don't set
1638         can_highlight.
1639         (show_source_disasm_command): Call the reset method.
1640         (show_data): Don't set can_highlight.  Call the reset method.
1641         (tui_gen_win_info::reset): Rename from init_gen_win_info
1642         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1643         (show_source_or_disasm_and_command): Call the reset method.
1644         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1645         (struct tui_cmd_window): Set can_highlight.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1650         from make_visible.
1651         (tui_make_visible, tui_make_invisible): Rewrite.
1652         (tui_win_info::make_visible): Remove.
1653         (tui_source_window_base::make_visible): Update.
1654         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1655         method.  Moved from...
1656         (struct tui_win_info) <make_visible>: ...here.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-winsource.c
1661         (tui_source_window_base::do_scroll_horizontal): Remove direction
1662         parameter.
1663         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1664         direction parameter.
1665         * tui/tui-win.c (tui_win_info::forward_scroll)
1666         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1667         (tui_win_info::right_scroll): Update.
1668         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1669         direction parameter.
1670         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1671         direction parameter.
1672         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1673         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1674         Remove direction parameter.
1675         (struct tui_source_window_base, struct tui_source_window)
1676         (struct tui_disasm_window, struct tui_data_window)
1677         (struct tui_cmd_window): Update.
1678
1679 2019-06-25  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-winsource.h (tui_set_exec_info_content)
1682         (tui_show_exec_info_content, tui_erase_exec_info_content)
1683         (tui_clear_exec_info_content, tui_update_exec_info): Change
1684         argument to tui_source_window_base.
1685         * tui/tui-winsource.c (tui_set_exec_info_content)
1686         (tui_show_exec_info_content, tui_erase_exec_info_content)
1687         (tui_clear_exec_info_content, tui_update_exec_info): Change
1688         argument to tui_source_window_base.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1693         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1698         check.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1703         type to void.
1704         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1705         type to void.
1706         * tui/tui-source.c (tui_set_source_content): Update.
1707         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-win.c (window_name_completer, tui_set_focus)
1712         (tui_all_windows_info): Use name method.
1713         * tui/tui-data.h (struct tui_gen_win_info)
1714         (struct tui_source_window, struct tui_disasm_window)
1715         (struct tui_data_window, struct tui_cmd_window) <name>: New
1716         method.
1717         (tui_win_name): Don't declare.
1718         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1719         (tui_win_name): Remove.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-winsource.h (tui_update_source_window)
1724         (tui_update_source_window_as_is): Change parameter type.
1725         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1726         to be a tui_source_window_base.
1727         (tui_update_source_window_as_is): Likewise.
1728         * tui/tui-win.c (make_visible_with_new_height): Update.
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-winsource.c (tui_erase_source_content)
1733         (tui_show_source_content, tui_show_exec_info_content)
1734         (tui_erase_exec_info_content): Use refresh_window method.
1735         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1736         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1737         from tui_refresh_win.
1738         (tui_data_window::refresh_window): New method.
1739         (tui_win_info::refresh, tui_source_window_base::refresh)
1740         (tui_refresh_all): Use refresh_window method.
1741         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1742         method.
1743         * tui/tui-regs.c (tui_display_register): Call refresh_window
1744         method.
1745         * tui/tui-layout.c (show_source_disasm_command)
1746         (show_source_or_disasm_and_command): Call refresh_window method.
1747         * tui/tui-data.h (struct tui_gen_win_info)
1748         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1749         New method.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui.c (tui_rl_other_window, tui_enable)
1754         (tui_is_window_visible, tui_get_command_dimension): Update.
1755         * tui/tui-winsource.c (tui_update_source_window_as_is)
1756         (tui_clear_source_content, tui_erase_source_content)
1757         (tui_show_source_line, tui_source_window_base::refill)
1758         (tui_source_window_base::do_scroll_horizontal)
1759         (tui_source_window_base::set_is_exec_point_at)
1760         (tui_update_breakpoint_info, tui_set_exec_info_content)
1761         (tui_alloc_source_buffer, tui_line_is_displayed)
1762         (tui_addr_is_displayed): Update.
1763         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1764         (tui_check_and_display_highlight_if_needed)
1765         (tui_win_info::make_visible, tui_win_info::refresh)
1766         (tui_refresh_all): Update.
1767         * tui/tui-windata.c (tui_first_data_item_displayed)
1768         (tui_delete_data_content_windows, tui_erase_data_content)
1769         (tui_display_all_data, tui_data_window::refresh_all)
1770         (tui_check_data_values): Update.
1771         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1772         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1773         (tui_win_info::backward_scroll, tui_refresh_all_win)
1774         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1775         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1776         (tui_source_window_base::set_new_height)
1777         (tui_data_window::set_new_height)
1778         (make_invisible_and_set_new_height)
1779         (make_visible_with_new_height, new_height_ok)
1780         (parse_scrolling_args): Update.
1781         * tui/tui-stack.c (tui_show_frame_info): Update.
1782         * tui/tui-source.c (tui_set_source_content)
1783         (tui_set_source_content_nil, tui_source_is_displayed)
1784         (tui_source_window::do_scroll_vertical): Update.
1785         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1786         (tui_display_registers_from, tui_display_reg_element_at_line)
1787         (tui_check_register_values, tui_reg_command): Update.
1788         * tui/tui-layout.c (tui_default_win_height)
1789         (show_source_disasm_command, show_data, init_and_make_win)
1790         (show_source_or_disasm_and_command): Update.
1791         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1792         (tui_redisplay_readline, tui_mld_flush)
1793         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1794         (tui_getc): Update.
1795         * tui/tui-disasm.c (tui_set_disassem_content)
1796         (tui_disasm_window::do_scroll_vertical): Update.
1797         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1798         Now virtual.
1799         (struct tui_win_info): Derive from tui_gen_win_info.
1800         <~tui_win_info>: Mark as override.
1801         <generic>: Remove member.
1802         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1803         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1804         (~tui_data_window, ~tui_win_info)
1805         (tui_free_all_source_wins_content): Update.
1806         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1807
1808 2019-06-25  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-layout.c (init_and_make_win): Use new.
1811         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1812         destructor, initializers.
1813         (tui_alloc_generic_win_info): Don't declare.
1814         * tui/tui-data.c (_locator): Add argument to constructor.
1815         (source_win, disasm_win): New globals.
1816         (exec_info): Remove.
1817         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1818         Update.
1819         (tui_alloc_generic_win_info): Remove.
1820         (init_content_element): Use new.
1821         (tui_win_info::tui_win_info): Update.
1822         (free_content_elements) <case DATA_WIN>: Use delete.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1827         * tui/tui-windata.c (tui_first_data_item_displayed)
1828         (tui_delete_data_content_windows): Update.
1829         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1830         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1831         (tui_display_registers_from, tui_check_register_values): Update.
1832         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1833         pointer.
1834         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1835         window.
1836         (tui_free_data_content): Update.
1837         (free_content_elements) <case DATA_WIN>: Free the window.
1838
1839 2019-06-25  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1842         Update.
1843         * tui/tui-layout.c (make_command_window)
1844         (show_source_disasm_command, show_data, init_and_make_win)
1845         (show_source_or_disasm_and_command): Update.
1846         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1847         method.
1848         <can_highight, is_highlighted>: Now bool.
1849         (tui_set_win_highlight): Don't declare.
1850         * tui/tui-data.c (tui_set_win_highlight): Remove.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-wingeneral.c (make_visible): Remove check of window
1855         type.
1856
1857 2019-06-25  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-win.c (tui_win_info::max_height)
1860         (tui_cmd_window::max_height): New methods.
1861         (new_height_ok): Call max_height.
1862         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1863         <max_height>: New method.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-win.c (tui_source_window_base::set_new_height)
1868         (tui_data_window::set_new_height): New methods.
1869         (make_invisible_and_set_new_height): Call set_new_height method.
1870         * tui/tui-data.h (struct tui_win_info)
1871         (struct tui_source_window_base, struct tui_data_window)
1872         <set_new_height>: New method.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1877         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1878         tui_refresh_data_win.
1879         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1880         method.
1881         (tui_refresh_all_win): Call the refresh_all method.
1882         (tui_set_focus): Likewise.
1883         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1884         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1885         Likewise.
1886
1887 2019-06-25  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-winsource.h (tui_refill_source_window)
1890         (tui_set_is_exec_point_at): Don't declare.
1891         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1892         (tui_source_window_base::refill): Rename from
1893         tui_refill_source_window.
1894         (tui_source_window_base::do_scroll_horizontal): Update.
1895         (tui_source_window_base::set_is_exec_point_at): Rename from
1896         tui_set_is_exec_point_at.
1897         (tui_update_all_breakpoint_info): Update.
1898         * tui/tui-stack.c (tui_show_frame_info): Update.
1899         * tui/tui-layout.c (show_data): Add cast.
1900         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1901         * tui/tui-data.h (struct tui_source_window_base) <refill,
1902         set_is_exec_point_at>: New methods.
1903         (tui_source_windows, tui_add_to_source_windows): Update types.
1904         (tui_add_to_source_windows): Remove redundant declaration.
1905         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1906         (tui_source_windows): Change return type.
1907         (tui_clear_source_windows_detail): Update.
1908         (tui_add_to_source_windows): Change type of parameter.
1909         (tui_free_all_source_wins_content): Update.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-wingeneral.c (tui_win_info::refresh)
1914         (tui_source_window_base::refresh): New methods.
1915         (tui_refresh_all): Call the refresh method.
1916         * tui/tui-data.h (struct tui_win_info)
1917         (struct tui_source_window_base) <refresh>: New method.
1918
1919 2019-06-25  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui.h (tui_is_window_visible): Return bool.
1922         * tui/tui.c (tui_is_window_visible): Return bool.
1923         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1924         (tui_make_visible, tui_make_invisible)
1925         (tui_win_info::make_visible)
1926         (tui_source_window_base::make_visible, make_all_visible)
1927         (tui_make_all_visible, tui_make_all_invisible): Update.
1928         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1929         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1930         bool.
1931         (struct tui_win_info, struct tui_source_window_base)
1932         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1933         * tui/tui-data.c (tui_init_generic_part): Update.
1934
1935 2019-06-25  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1938         (tui_source_window_base::make_visible): New methods.
1939         (make_all_visible): Make method call.
1940         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1941         (struct tui_source_window_base, struct tui_cmd_window): Override
1942         make_visible.
1943         (tui_win_is_source_type): Don't declare.
1944         * tui/tui-data.c (tui_win_is_source_type): Remove.
1945
1946 2019-06-25  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1949         NULL check.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1954         Inline constructor.  Add initializers for members.
1955         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1956         constructors; now inline in class.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-regs.c (tui_show_registers): Update.
1961         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1962         bool.
1963         * tui/tui-data.c (tui_data_window::clear_detail)
1964         (tui_data_window): Update.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-windata.c (tui_display_all_data)
1969         (tui_display_data_from_line, tui_display_data_from)
1970         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1971         Update.
1972         * tui/tui-regs.c (tui_last_regs_line_no)
1973         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1974         (tui_show_registers, tui_show_register_group)
1975         (tui_display_registers_from, tui_display_reg_element_at_line)
1976         (tui_display_registers_from_line, tui_check_register_values)
1977         (tui_reg_next, tui_reg_prev): Update.
1978         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1979         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1980         tui_data_window.
1981         (struct tui_win_info) <detail>: Remove.  Add new fields from
1982         tui_data_info.
1983         (TUI_DATA_WIN): Add cast.
1984         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1985         (~tui_data_window): Simplify.
1986
1987 2019-06-25  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-layout.c (show_source_disasm_command)
1990         (show_source_or_disasm_and_command): Update.
1991         * tui/tui-io.c (update_cmdwin_start_line)
1992         (tui_redisplay_readline): Update.
1993         * tui/tui-data.h (struct tui_command_info): Remove.
1994         (struct tui_win_info) <detail>: Remove command_info member.
1995         (struct tui_data_window) <start_line>: New member, from
1996         tui_command_info.
1997         (TUI_CMD_WIN): Add casts.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-winsource.c (tui_update_source_window)
2002         (tui_refill_source_window)
2003         (tui_source_window_base::do_scroll_horizontal)
2004         (tui_update_breakpoint_info, tui_set_exec_info_content)
2005         (tui_show_exec_info_content, tui_erase_exec_info_content)
2006         (tui_clear_exec_info_content): Update.
2007         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2008         Update.
2009         * tui/tui-win.c (make_invisible_and_set_new_height)
2010         (make_visible_with_new_height): Update.
2011         * tui/tui-source.c (tui_set_source_content)
2012         (tui_show_symtab_source): Update.
2013         * tui/tui-layout.c (extract_display_start_addr)
2014         (show_source_disasm_command, show_data)
2015         (make_source_or_disasm_window)
2016         (show_source_or_disasm_and_command): Update.
2017         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2018         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2019         "gdbarch".
2020         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2021         to tui_source_window_base.
2022         (struct tui_win_info) <detail>: Remove source_info member.
2023         (struct tui_source_window_base) <has_locator>: Inline.
2024         Move contents from tui_source_info; rename has_locator member to
2025         m_has_locator.
2026         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2027         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2028         header file.
2029         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2030         Simplify.
2031         (tui_free_all_source_wins_content): Cast to
2032         tui_source_window_base.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-win.c (make_invisible_and_set_new_height)
2037         (make_visible_with_new_height): Call has_locator method.
2038         * tui/tui-layout.c (show_source_disasm_command, show_data)
2039         (show_source_or_disasm_and_command): Update for bool change.
2040         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2041         (tui_win_info) <has_locator>: New method.
2042         (struct tui_source_window_base) <has_locator>: New method.
2043         (tui_win_has_locator): Don't declare.
2044         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2045         from tui_win_has_locator.
2046         (tui_source_window_base): Use false, not FALSE.
2047
2048 2019-06-25  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2051         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2052         clear_detail method directly.
2053         (tui_clear_win_detail): Remove.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2058         "this", not TUI_DISASM_WIN.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2063         declare.
2064         * tui/tui-winsource.c
2065         (tui_source_window_base::do_scroll_horizontal): Rename from
2066         tui_horizontal_source_scroll.
2067         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2068         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2069         from tui_vertical_data_scroll.
2070         * tui/tui-win.h (tui_scroll): Don't declare.
2071         * tui/tui-win.c (tui_win_info::forward_scroll)
2072         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2073         (tui_win_info::right_scroll): Rename and update.
2074         (tui_scroll_forward_command, tui_scroll_backward_command)
2075         (tui_scroll_left_command, tui_scroll_right_command): Update.
2076         (tui_scroll): Remove.
2077         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2078         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2079         from tui_vertical_source_scroll.
2080         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2081         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2082         from tui_vertical_disassem_scroll.
2083         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2084         do_scroll_horizontal>: New methods.
2085         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2086         Likewise.
2087         (struct tui_source_window_base): Add do_scroll_horizontal.
2088         (struct tui_source_window, struct tui_disasm_window): Add
2089         do_scroll_vertical.
2090         (struct tui_data_window, struct tui_cmd_window): Add
2091         do_scroll_horizontal and do_scroll_vertical.
2092         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2093
2094 2019-06-25  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-data.h (struct tui_source_window_base): New struct.
2097         (struct tui_source_window): Derive from tui_source_window_base.
2098         (struct tui_disasm_window): New struct.
2099         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2100         from tui_source_window::clear_detail.
2101         (tui_source_window_base): Rename from tui_source_window.
2102         (~tui_source_window_base): Rename from ~tui_source_window.
2103         (tui_alloc_win_info): Create a tui_disasm_window.
2104
2105 2019-06-25  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-data.h (struct tui_source_window)
2108         (struct tui_data_window): Declare destructors.
2109         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2110         destructors.
2111         (tui_win_info): Simplify.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-winsource.c (tui_display_main)
2116         (tui_update_source_windows_with_addr)
2117         (tui_update_all_breakpoint_info): Update.
2118         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2119         (new_height_ok, parse_scrolling_args): Update.
2120         * tui/tui-stack.c (tui_show_frame_info): Update.
2121         * tui/tui-data.h (struct tui_list): Remove.
2122         (tui_source_windows): Return a reference to a std::vector.
2123         * tui/tui-data.c (source_windows): Now a std::vector.
2124         (tui_source_windows): Change return type.
2125         (tui_clear_source_windows): Rewrite.
2126         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2127         (tui_free_all_source_wins_content): Rewrite.
2128
2129 2019-06-25  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2132         (struct tui_data_window, struct tui_cmd_window): Declare
2133         clear_detail method.
2134         * tui/tui-data.c (tui_source_window::clear_detail)
2135         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2136         methods.
2137         (tui_clear_win_detail): Simplify.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-layout.c (make_source_window, make_disasm_window)
2142         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2143         Return the new window.
2144         (show_source_disasm_command, show_data)
2145         (show_source_or_disasm_and_command): Update.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2150         parameter.  Return the new window.
2151         (show_source_disasm_command): Update and remove NULL check.
2152         (show_source_or_disasm_and_command): Update.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-data.h (struct tui_win_info): Make constructor
2161         protected.  Make destructor virtual.  Add initializers.
2162         (tui_source_window, tui_data_window, tui_cmd_window): New
2163         classes.
2164         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2165         constructor.  Add "type" parameter.
2166         (tui_source_window, tui_data_window, tui_cmd_window): New
2167         constructors.
2168         (tui_alloc_win_info): Instantiate the appropriate subclass.
2169
2170 2019-06-25  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-win.c (tui_resize_all): Use delete.
2173         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2174         destructor.
2175         (tui_free_window): Don't declare.
2176         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2177         Update.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-data.h (struct tui_win_info): Add constructor.
2182         * tui/tui-data.c (tui_alloc_win_info): Use new.
2183         (tui_free_window): Use delete.
2184
2185 2019-06-22  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2188         declare.
2189         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2190
2191 2019-06-22  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2194         declare.
2195         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2196
2197 2019-06-22  Tom de Vries  <tdevries@suse.de>
2198
2199         * dwarf2read.c (create_addrmap_from_aranges)
2200         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2201         instead of '%zu'.
2202
2203 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2204
2205         * dwarf2read.h (dwarf2_section_info_def): Remove.
2206         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2207         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2208         std::vector<dwarf2_section_info>.
2209         (struct dwo_file) <~dwo_file>: Remove.
2210         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2211         types field.
2212         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2213         (dwarf2_read_debug_names): Likewise.
2214         (create_debug_types_hash_table): Change parameter type to
2215         array_view, adjust code accordingly.
2216         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2217         (partial_die_info::fixup): Likewise.
2218         (determine_prefix): Likewise.
2219         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2220
2221 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2222
2223         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2224         gdb_bfd_ref_ptr.
2225         <~dwo_file>: Remove call to gdb_bfd_unref.
2226         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2227         gdb_bfd_ref_ptr::get.
2228
2229 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2230
2231         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2232         type to htab_up.
2233         * dwarf2read.c (struct dwo_file): Initialize fields.
2234         <~dwo_file>: New.
2235         (free_dwo_file): Remove, move content to ~dwo_file.
2236         (struct dwo_file_deleter): Remove.
2237         (dwo_file_up>: Remove custom deleter.
2238         (free_dwo_files): Remove.
2239         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2240         dwo_files.
2241         (process_skeletonless_type_units): Call unique_ptr::get.
2242         (allocate_dwo_file_hash_table): Add deleter to created hash
2243         table.  Change return type to htab_up.
2244         (lookup_dwo_file_slot): Don't memset dwo_file, call
2245         unique_ptr::get.
2246         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2247         (create_dwo_unit_in_dwp_v2): Likewise.
2248         (open_and_init_dwo_file): Likewise.
2249         (free_dwo_file_from_slot): Remove.
2250
2251 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2252
2253         * dwarf2read.h (struct dwarf2_section_info) <readin,
2254         is_virtual>: Change type to bool.
2255         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2256         true instead of 1.
2257
2258 2019-06-19  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-data.h (tui_init_content_element): Don't declare.
2261
2262 2019-06-19  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-data.h (tui_init_win_info): Don't declare.
2265
2266 2019-06-19  Tom de Vries  <tdevries@suse.de>
2267
2268         * dwarf2read.h (abstract_to_concrete): Change type to
2269         std::unordered_map<sect_offset, std::vector<sect_offset>,
2270         gdb::hash_enum<sect_offset>>.
2271
2272 2019-06-19  Tom Tromey  <tromey@adacore.com>
2273
2274         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2275         EVAL_AVOID_SIDE_EFFECTS specially.
2276
2277 2019-06-19  Tom Tromey  <tromey@adacore.com>
2278
2279         * source-cache.c (highlighter): New global.
2280         (source_cache::get_source_lines): Create a highlighter on demand.
2281
2282 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * defs.h (deprecated_interactive_hook): Delete declaration.
2285         * interps.c (clear_interpreter_hooks): Remove use of
2286         deprecated_interactive_hook.
2287         * top.c (deprecated_interactive_hook): Delete definition.
2288         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2289
2290 2019-06-18  Tom de Vries  <tdevries@suse.de>
2291
2292         PR gdb/24515
2293         * dwarf2read.h (abstract_to_concrete): Change type from
2294         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2295         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2296         * dwarf2read.c (read_variable): Update.
2297         (dwarf2_fetch_die_loc_sect_off): Update.
2298
2299 2019-06-17  Tom de Vries  <tdevries@suse.de>
2300
2301         PR gdb/24617
2302         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2303         accessing parent[parent_len - 1].
2304
2305 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2306
2307         PR gdb/24364
2308         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2309         call dtrace_process_dof with NULL dof.
2310
2311 2019-06-16  Tom de Vries  <tdevries@suse.de>
2312
2313         PR gdb/24445
2314         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2315
2316 2019-06-16  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2319         (make_all_visible): Use address of member.
2320
2321 2019-06-16  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2324         (tui_free_window, free_content, free_content_elements): Remove
2325         unnecessary cast.
2326         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2327         cast.
2328         * tui/tui-regs.c (tui_show_register_group)
2329         (tui_display_registers_from, tui_display_reg_element_at_line):
2330         Remove unnecessary cast.
2331
2332 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * linux-nat.c (normal_mask): Delete.
2335         (_initialize_linux_nat): Don't initialise normal_mask.
2336
2337 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2338
2339         PR gdb/24445
2340         * dwarf-index-write.h (write_psymtabs_to_index): Add
2341         dwz_basename parameter.
2342         * dwarf-index-write.c (write_gdbindex): Move file writing to
2343         write_gdbindex_1.  Change return type void.
2344         (assert_file_size): Move up, remove filename parameter.
2345         (write_gdbindex_1): New function.
2346         (write_debug_names): Change return type to void, call
2347         assert_file_size.
2348         (struct index_wip_file): New struct.
2349         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2350         file logic to index_wip_file.  Write index for dwz file if
2351         needed.
2352         (save_gdb_index_command): Pass basename of dwz file, if present.
2353         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2354         build-id of dwz file, if present.
2355         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2356         (dwarf2_get_dwz_file): Likewise.
2357         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2358         (dwarf2_get_dwz_file): Likewise.
2359
2360 2019-06-16  Tom Tromey  <tom@tromey.com>
2361
2362         * coffread.c (process_coff_symbol): Use xstrdup.
2363         * value.c (create_internalvar): Use xstrdup.
2364
2365 2019-06-16  Tom Tromey  <tom@tromey.com>
2366
2367         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2368         * breakpoint.c (stopin_command, stopat_command)
2369         (until_break_command, decode_location_default): Remove unnecessary
2370         cast.
2371         * utils.c (subset_compare): Remove unnecessary cast.
2372         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2373         cast.
2374         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2375         cast.
2376         * infcmd.c (path_command): Remove unnecessary cast.
2377         * coffread.c (decode_type): Remove unnecessary cast.
2378         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2379         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2380         * tui/tui-stack.c (tui_show_locator_content)
2381         (tui_show_frame_info): Remove unnecessary cast.
2382         * tui/tui-win.c (tui_scroll_forward_command)
2383         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2384         (parse_scrolling_args): Remove unnecessary cast.
2385         * tui/tui-data.c (init_win_info, tui_del_window)
2386         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2387         (free_content_elements): Remove unnecessary cast.
2388         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2389         unnecessary cast.
2390         * tui/tui-source.c (tui_set_source_content)
2391         (tui_vertical_source_scroll): Remove unnecessary cast.
2392         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2393         cast.
2394         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2395         * tui/tui-regs.c (tui_display_registers_from)
2396         (tui_display_register): Remove unnecessary cast.
2397         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2398         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2399         (make_visible): Remove unnecessary cast.
2400         * tui/tui-winsource.c (tui_erase_source_content)
2401         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2402         unnecessary cast.
2403         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2404         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2405         * stabsread.c (read_type, read_array_type, read_range_type):
2406         Remove unnecessary cast.
2407         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2408         (parse_symbol, parse_type, upgrade_type, parse_external)
2409         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2410         unnecessary cast.
2411         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2412
2413 2019-06-16  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-data.c (tui_alloc_generic_win_info)
2416         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2417         checks.
2418
2419 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2420             Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * f-typeprint.c (f_print_type): Don't return early for not
2423         associated or not allocated types.
2424         (f_type_print_varspec_suffix): Add print_rank parameter and print
2425         ranks of array types in case they dangling.
2426         (f_type_print_base): Add print_rank parameter.
2427
2428 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * NEWS: Mention new MI commands.
2431         * break-catch-throw.c (enum exception_event_kind): Move to
2432         breakpoint.h.
2433         (print_mention_exception_catchpoint): Output text as a single
2434         message.
2435         (catch_exception_command_1): Rename to...
2436         (catch_exception_event): ...this, make non-static, update header
2437         command, and change some parameter types.
2438         (catch_catch_command): Update for changes to
2439         catch_exception_command_1.
2440         (catch_throw_command): Likewise.
2441         (catch_rethrow_command): Likewise.
2442         * breakpoint.c (enum exception_event_kind): Delete.
2443         * breakpoint.h (enum exception_event_kind): Moved here from
2444         break-catch-throw.c.
2445         (catch_exception_event): Declare.
2446         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2447         (mi_cmd_catch_throw): New function.
2448         (mi_cmd_catch_rethrow): New function.
2449         (mi_cmd_catch_catch): New function.
2450         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2451         'catch-catch' entries.
2452         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2453         (mi_cmd_catch_rethrow): Declare.
2454         (mi_cmd_catch_catch): Declare.
2455
2456 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * annotate.c (annotate_source_line): Change return type to void,
2459         update implementation to match.
2460         * annotate.h (annotate_source_line): Change return type to void,
2461         update header comment.
2462         * stack.c (print_frame_info): Don't change what frame information
2463         is printed based on whether annotations are on or not.
2464
2465 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2468         (annotate_source): Make static.
2469         (annotate_source_line): Moved from source.c and renamed from
2470         identify_source_line.  Update the return type.
2471         * annotate.h (annotate_source): Delete declaration.
2472         (annotate_source_line): Declaration moved from source.h, and
2473         renamed from identify_source_line.  Return type updated.
2474         * source.c (identify_source_line): Moved to annotate.c and renamed
2475         to annotate_source_line.
2476         (info_line_command): Remove check of annotation_level.
2477         * source.h (identify_source_line): Move declaration to annotate.h
2478         and rename to annotate_source_line.
2479         * stack.c: Add 'annotate.h' include.
2480         (print_frame_info): Remove check of annotation_level before
2481         calling annotate_source_line.
2482
2483 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2484
2485         * source-cache.c (source_cache::get_plain_source_lines): Use
2486         open_source_file_with_line_charpos instead of just
2487         open_source_file, remove call to find_source_lines.
2488         (source_cache::get_source_lines): Likewise.
2489         * source.c (find_source_lines): Make static.
2490         (get_filename_and_charpos): Renamed into...
2491         (open_source_file_with_line_charpos): ..this along with changes to
2492         return a scoped_fd, and some other minor clean ups.
2493         (identify_source_line): Use open_source_file_with_line_charpos.
2494         (search_command_helper): Use open_source_file_with_line_charpos
2495         instead of just open_source_file, remove call to
2496         find_source_lines.
2497         * source.h (open_source_file_with_line_charpos): Declare new
2498         function.
2499         (find_source_lines): Delete declaration.
2500
2501 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * source.c (get_filename_and_charpos): Remove fullname
2504         parameter.
2505         (identify_source_line): Update call to get_filename_and_charpos.
2506
2507 2019-06-14  Tom Tromey  <tromey@adacore.com>
2508
2509         PR gdb/24502:
2510         * ui-style.h (skip_ansi_escape): Update comment.
2511         * ui-file.h (class no_terminal_escape_file): New class.
2512         * ui-file.c (no_terminal_escape_file::write)
2513         (no_terminal_escape_file::puts): New methods.
2514         * cli/cli-logging.c (handle_redirections): Use
2515         no_terminal_escape_file.
2516
2517 2019-06-14  Tom Tromey  <tromey@adacore.com>
2518
2519         * NEWS: Move convenience variable news above Python news.
2520
2521 2019-06-14  Tom Tromey  <tom@tromey.com>
2522
2523         * gnulib: Move directory to top-level.
2524         * configure.ac: Don't configure gnulib.
2525         * configure: Rebuild.
2526         * common/common-defs.h: Use new path to gnulib.
2527         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2528         (GNULIB_H): Remove.
2529         (INCGNU): Look in new gnulib location.
2530         (HFILES_NO_SRCDIR): Remove gnulib files.
2531         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2532         (generated_files): Remove GNULIB_H.
2533         ($(LIBGNU), all-lib): Remove targets.
2534         (distclean): Don't mention GNULIB_BUILDDIR.
2535         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2536
2537 2019-06-14  Tom Tromey  <tromey@adacore.com>
2538
2539         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2540         Warn if symbol file does not provide any symbols.
2541
2542 2019-06-14  Tom Tromey  <tromey@adacore.com>
2543
2544         * source.c (find_and_open_source): Respect basenames_may_differ.
2545
2546 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * annotate.c (annotate_breakpoints_invalid): Make use of
2549         scoped_restore_terminal_state.
2550         (annotate_frames_invalid): Likewise.
2551
2552 2019-06-14  Tom Tromey  <tromey@adacore.com>
2553
2554         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2555         allow assignment to an internalvar.
2556
2557 2019-06-14  Tom Tromey  <tromey@adacore.com>
2558
2559         * ada-lex.l: Allow "_" in attribute names.
2560
2561 2019-06-14  Tom Tromey  <tromey@adacore.com>
2562
2563         PR gdb/24653:
2564         * regcache.c (registers_changed): Don't call alloca.
2565         * top.c (execute_command): Don't call alloca.
2566
2567 2019-06-13  Pedro Alves  <palves@redhat.com>
2568
2569         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2570         'expression'.  When parsing an expression, error out if there's
2571         junk after "unlimited".
2572         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2573         (do_set_command): Adjust calls to is_unlimited_literal.
2574
2575 2019-06-13  Pedro Alves  <palves@redhat.com>
2576
2577         * compile/compile.c (make_compile_options_def_group): Add braces
2578         around array_view initializer.
2579         * thread.c (make_thread_apply_all_options_def_group)
2580         (make_thread_apply_all_options_def_group): Likewise.
2581
2582 2019-06-13  Pedro Alves  <palves@redhat.com>
2583
2584         * NEWS (New commands): Mention "maint test-options
2585         require-delimiter", "maint test-options unknown-is-error", "maint
2586         test-options unknown-is-operand" and "maint show
2587         test-options-completion-result".
2588         (New command options, command completion): New section.
2589         (Completion improvements): New section.
2590         Mention that you can abbreviate "unlimited".
2591
2592 2019-06-13  Pedro Alves  <palves@redhat.com>
2593
2594         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2595         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2596         * unittests/cli-utils-selftests.c (test_parse_flags)
2597         (test_parse_flags_qcs): Delete.
2598         (test_cli_utils): Don't call deleted functions.
2599
2600 2019-06-13  Pedro Alves  <palves@redhat.com>
2601
2602         * thread.c: Include "cli/cli-option.h".
2603         (tp_array_compar_ascending): Global.
2604         (tp_array_compar): Delete function.
2605         (tp_array_compar_ascending, tp_array_compar_descending): New
2606         functions.
2607         (ascending_option_def, qcs_flag_option_def)
2608         (thr_qcs_flags_option_defs)
2609         (make_thread_apply_all_options_def_group)
2610         (make_thread_apply_options_def_group): New.
2611         (thread_apply_all_command): Use gdb::option::process_options.
2612         (thread_apply_command_completer)
2613         (thread_apply_all_command_completer): New.
2614         (thread_apply_command): Use gdb::option::process_options.
2615         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2616         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2617         to generate help text of "thread apply".  Adjust "taas"'s help.
2618         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2619         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2620
2621 2019-06-13  Pedro Alves  <palves@redhat.com>
2622
2623         * thread.c (thread_apply_command): Check for invalid TID with
2624         isdigit instead of !isalpha.
2625
2626 2019-06-13  Pedro Alves  <palves@redhat.com>
2627
2628         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2629         (validate_flags_qcs): New.
2630         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2631         (validate_flags_qcs): Declare.
2632         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2633         (make_frame_apply_options_def_group): New.
2634         (frame_apply_command_count): Process options with
2635         gdb::option::process_options.
2636         (frame_apply_completer): New.
2637         (frame_apply_level_completer, frame_apply_all_completer)
2638         (frame_apply_completer): New.
2639         (_initialize_stack): Update help of "frame apply", "frame apply
2640         level", "frame apply all" and "faas" to mention supported options
2641         and install command completers.
2642         * stack.h (frame_apply_all_completer): Declare.
2643         * thread.c: Include "stack.h".
2644         (tfaas_command): Add "--".
2645         (_initialize_thread): Update help "tfaas" to mention supported
2646         options and install command completer.
2647
2648 2019-06-13  Pedro Alves  <palves@redhat.com>
2649
2650         * completer.c (complete_nested_command_line): New.
2651         (gdb_completion_word_break_characters_throw): Add assertion.
2652         * completer.h (complete_nested_command_line): Declare.
2653
2654 2019-06-13  Pedro Alves  <palves@redhat.com>
2655
2656         * stack.c (parse_backtrace_qualifiers): New.
2657         (backtrace_command): Use it.
2658         (backtrace_command_completer): Complete on qualifiers.
2659
2660 2019-06-13  Pedro Alves  <palves@redhat.com>
2661
2662         * frame.c: Include "cli/cli-option.h.
2663         (user_set_backtrace_options): New.
2664         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2665         Delete.
2666         (get_prev_frame): Adjust.
2667         (boolean_option_def, uinteger_option_def)
2668         (set_backtrace_option_defs): New.
2669         (_initialize_frame): Adjust and use
2670         gdb::option::add_setshow_cmds_for_options to install "set
2671         backtrace past-main" and "set backtrace past-entry".
2672         * frame.h: Include "cli/cli-option.h".
2673         (struct frame_print_options): Forward declare.
2674         (print_frame_arguments_all, print_frame_arguments_scalars)
2675         (print_frame_arguments_none): Declare.
2676         (print_entry_values): Delete declaration.
2677         (struct frame_print_options, user_frame_print_options): New.
2678         (struct set_backtrace_options): New.
2679         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2680         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2681         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2682         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2683         (list_args_or_locals): Add frame_print_options parameter.
2684         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2685         * python/py-framefilter.c (enumerate_args): Pass down
2686         USER_FRAME_PRINT_OPTIONS.
2687         * stack.c: Include "cli/cli-option.h".
2688         (print_frame_arguments_all, print_frame_arguments_scalars)
2689         (print_frame_arguments_none): Declare.
2690         (print_raw_frame_arguments, print_entry_values): Delete.
2691         (user_frame_print_options): New.
2692         (boolean_option_def, enum_option_def, frame_print_option_defs):
2693         New.
2694         (struct backtrace_cmd_options): New.
2695         (bt_flag_option_def): New.
2696         (backtrace_command_option_defs): New.
2697         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2698         (print_frame_arg, read_frame_arg, print_frame_args)
2699         (print_frame_info, print_frame): Add frame_print_options parameter
2700         and use it.
2701         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2702         (backtrace_command_1): Add frame_print_options and
2703         backtrace_cmd_options parameters and use them.
2704         (make_backtrace_options_def_group): New.
2705         (backtrace_command): Process command options with
2706         gdb::option::process_options.
2707         (backtrace_command_completer): New.
2708         (_initialize_stack): Extend "backtrace"'s help to mention
2709         supported options.  Install completer for "backtrace".
2710         Install some settings commands with add_setshow_cmds_for_options.
2711
2712 2019-06-13  Pedro Alves  <palves@redhat.com>
2713
2714         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2715         and that "set/show print raw frame-arguments" are now deprecated.
2716
2717         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2718         command.
2719         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2720         * stack.c (_initialize_stack): Install "set/show print
2721         raw-frame-arguments", and deprecate "set/show print raw
2722         frame-arguments".
2723         * valprint.c (_initialize_valprint): Deprecate "set/show print
2724         raw".
2725
2726 2019-06-13  Pedro Alves  <palves@redhat.com>
2727
2728         * compile/compile.c (struct compile_options): New.
2729         (compile_flag_option_def, compile_command_option_defs)
2730         (make_compile_options_def_group): New.
2731         (compile_file_command): Handle options with
2732         gdb::option::process_options.
2733         (compile_file_command_completer): New function.
2734         (compile_code_command): Handle options with
2735         gdb::option::process_options.
2736         (compile_code_command_completer): New function.
2737         (_initialize_compiler): Install completers for "compile code" and
2738         "compile file".  Mention available options in "compile code" and
2739         "compile code"'s help.
2740         * completer.c (advance_to_completion_word): New, factored out from
2741         ...
2742         (advance_to_expression_complete_word_point): ... this.
2743         (advance_to_filename_complete_word_point): New.
2744         * completer.h (advance_to_filename_complete_word_point): New
2745         declaration.
2746
2747 2019-06-13  Pedro Alves  <palves@redhat.com>
2748
2749         * compile/compile.c: Include "cli/cli-option.h".
2750         (compile_print_value): Scope data pointer is now a
2751         value_print_options pointer; adjust.
2752         (compile_print_command): Process options.  Scope data pointer is
2753         now a value_print_options pointer; adjust.
2754         (_initialize_compile): Update "compile print"'s help to include
2755         supported options.  Install a completer for "compile print".
2756         * cp-valprint.c (show_vtblprint, show_objectprint)
2757         (show_static_field_print): Delete.
2758         (_initialize_cp_valprint): Don't install "set print
2759         static-members", "set print vtbl", "set print object" here.
2760         * printcmd.c: Include "cli/cli-option.h" and
2761         "common/gdb_optional.h".
2762         (print_command_parse_format): Rework to fill in a
2763         value_print_options instead of a format_data.
2764         (print_value): Change parameter type from format_data pointer to
2765         value_print_options reference.  Adjust.
2766         (print_command_1): Process options.  Adjust to pass down a
2767         value_print_options.
2768         (print_command_completer): New.
2769         (_initialize_printcmd): Install print_command_completer as
2770         handle_brkchars completer for the "print" command.  Update
2771         "print"'s help to include supported options.
2772         * valprint.c: Include "cli/cli-option.h".
2773         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2774         here from cp-valprint.c.
2775         (boolean_option_def, uinteger_option_def)
2776         (value_print_option_defs, make_value_print_options_def_group):
2777         New.  Use gdb::option::add_setshow_cmds_for_options to install
2778         "set print elements", "set print null-stop", "set print repeats",
2779         "set print pretty", "set print union", "set print array", "set
2780         print address", "set print symbol", "set print array-indexes".
2781         * valprint.h: Include <string> and "cli/cli-option.h".
2782         (make_value_print_options_def_group): Declare.
2783         (print_value): Change parameter type from format_data pointer to
2784         value_print_options reference.
2785         (print_command_completer): Declare.
2786
2787 2019-06-13  Pedro Alves  <palves@redhat.com>
2788
2789         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2790         (COMMON_SFILES): Add maint-test-settings.c.
2791         * cli/cli-decode.c (boolean_enums): New global, factored out from
2792         ...
2793         (add_setshow_boolean_cmd): ... here.
2794         * cli/cli-decode.h (boolean_enums): Declare.
2795         * cli/cli-option.c: New file.
2796         * cli/cli-option.h: New file.
2797         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2798         factored out from ...
2799         (parse_cli_boolean_value(const char *)): ... this.
2800         (is_unlimited_literal): Change parameter type to pointer to
2801         pointer.  Adjust and advance ARG pointer.
2802         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2803         (parse_cli_var_enum): New, factored out from ...
2804         (do_set_command): ... this.  Adjust.
2805         * cli/cli-setshow.h (parse_cli_boolean_value)
2806         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2807         (parse_cli_var_enum): Declare.
2808         * cli/cli-utils.c: Include "cli/cli-option.h".
2809         (get_ulongest): New.
2810         * cli/cli-utils.h (get_ulongest): Declare.
2811         (check_for_argument): New overloads.
2812         * maint-test-options.c: New file.
2813
2814 2019-06-13  Pedro Alves  <palves@redhat.com>
2815
2816         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2817         parse a range if "-" is at the end of the string.
2818
2819 2019-06-13  Pedro Alves  <palves@redhat.com>
2820
2821         * cli/cli-setshow.c (parse_auto_binary_operation)
2822         (parse_cli_boolean_value): Don't allow "o".
2823
2824 2019-06-13  Pedro Alves  <palves@redhat.com>
2825
2826         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2827         * NEWS: Mention maint test-settings KIND.
2828         * maint-test-settings.c: New file.
2829
2830 2019-06-13  Pedro Alves  <palves@redhat.com>
2831
2832         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2833         completer.
2834         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2835         "set" completers.
2836
2837 2019-06-13  Pedro Alves  <palves@redhat.com>
2838
2839         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2840         after item.
2841
2842 2019-06-13  Pedro Alves  <palves@redhat.com>
2843
2844         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2845
2846 2019-06-13  Pedro Alves <palves@redhat.com>
2847
2848         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2849         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2850         call.
2851         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2852         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2853         calls.
2854         (check_for_argument): Skip spaces after argument.
2855
2856 2019-06-13  Pedro Alves  <palves@redhat.com>
2857
2858         * thread.c (thread_apply_command): Adjust TID parsing.
2859         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2860         detected before end of string.
2861         (tid_is_in_list): Error out if LIST is invalid.
2862
2863 2019-06-13  Pedro Alves  <palves@redhat.com>
2864
2865         * completer.c (complete_line_internal_1): Rewind completion word
2866         point.
2867         (completion_tracker::advance_custom_word_point_by): Change
2868         parameter type to int.
2869         * completer.h (completion_tracker::advance_custom_word_point_by):
2870         Likewise.
2871
2872 2019-06-13  Pedro Alves  <palves@redhat.com>
2873
2874         * completer.c (advance_to_completion_word): Handle delimiters.
2875
2876 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2877
2878         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2879
2880 2019-06-11  Tom Tromey  <tom@tromey.com>
2881
2882         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2883         (xmalloc_failed): Move to alloc.c.
2884         * alloc.c: New file.
2885         * Makefile.in (COMMON_SFILES): Add alloc.c.
2886
2887 2019-06-11  Tom Tromey  <tom@tromey.com>
2888
2889         * nat/linux-waitpid.c: Don't include server.h.
2890         (linux_debug): Remove.
2891         (my_waitpid): Update.
2892
2893 2019-06-11  Tom Tromey  <tromey@adacore.com>
2894
2895         * infcall.c (_initialize_infcall): Remove trailing newline from
2896         help.
2897         * user-regs.c (_initialize_user_regs): Remove trailing newline
2898         from help.
2899         * typeprint.c (_initialize_typeprint): Remove trailing newline
2900         from help.
2901         * reverse.c (_initialize_reverse): Remove trailing newlines from
2902         help.
2903         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2904         from help.
2905         * language.c (add_set_language_command): Remove trailing newline
2906         from help.
2907         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2908         help.
2909         * disasm.c (_initialize_disasm): Remove trailing newline from
2910         help.
2911         * top.c (init_main): Remove trailing newline from help.
2912         * interps.c (_initialize_interpreter): Remove trailing newline
2913         from help.
2914         * btrace.c (_initialize_btrace): Remove trailing newlines from
2915         help.
2916         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2917         from help.
2918         * python/python.c (_initialize_python): Remove trailing newline
2919         from help.
2920         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2921         help.
2922         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2923         from help.  Reformat some text.
2924         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2925         from help.
2926         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2927         newline from help.
2928
2929 2019-06-11  Tom Tromey  <tromey@adacore.com>
2930
2931         * darwin-nat.c (darwin_decode_exception_message)
2932         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2933
2934 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * valops.c (value_slice): Check for not allocated or not
2937         associated values.
2938
2939 2019-06-10  Tom de Vries  <tdevries@suse.de>
2940
2941         PR gdb/24618
2942         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2943         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2944         invalid.
2945
2946 2019-06-10  Tom de Vries  <tdevries@suse.de>
2947
2948         PR gdb/24611
2949         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2950         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2951
2952 2019-06-10  Tom de Vries  <tdevries@suse.de>
2953
2954         PR symtab/24545
2955         * symtab.c (struct demangled_name_entry): Add language field.
2956         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2957         static minimal symbol".  Set and use language field.
2958
2959 2019-06-10  Tom Tromey  <tromey@adacore.com>
2960
2961         * ada-lang.c (_initialize_ada_language): Update help text.
2962
2963 2019-06-10  Tom Tromey  <tromey@adacore.com>
2964
2965         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2966         with a newline.
2967         * guile/guile.c (handle_boot_error): Don't end warning with a
2968         newline.
2969         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2970         warning with a newline.
2971         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2972         newline.
2973         (s12z_frame_cache): Likewise.
2974         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2975         a newline.
2976         * solib-svr4.c (disable_probes_interface): Don't end warning with
2977         a newline.
2978         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2979         newline.
2980         * python/python.c (do_finish_initialization): Don't end warning
2981         with a newline.
2982
2983 2019-06-10  Tom Tromey  <tom@tromey.com>
2984
2985         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2986         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2987         gdbpy_enter.
2988
2989 2019-06-10  Tom Tromey  <tromey@adacore.com>
2990
2991         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2992         data.
2993         (elf_new_init): Don't call stabsread_new_init.
2994         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2995         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2996         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2997
2998 2019-06-10  Tom de Vries  <tdevries@suse.de>
2999
3000         PR symtab/16264
3001         PR symtab/24517
3002         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3003
3004 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3005
3006         * source.c (find_and_open_source): Also rewrite relative file
3007         names.
3008
3009 2019-04-26  Amos Bird  <amosbird@gmail.com>
3010
3011         * annotate.c (annotate_thread_exited): Add "thread-exited"
3012         annotation.
3013
3014 2019-06-06  Tom Tromey  <tromey@adacore.com>
3015
3016         * maint.h (class scoped_command_stats): Use
3017         DISABLE_COPY_AND_ASSIGN.
3018         <print_time>: New method.
3019         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3020         print_time.
3021         (scoped_command_stats::print_time): New method.
3022
3023 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3026         instructions of lengths 6 or 8 bytes.
3027
3028 2019-06-04  Pedro Alves  <palves@redhat.com>
3029
3030         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3031
3032         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3033         * breakpoint.c (condition_completer): Likewise.
3034         * cli/cli-dump.c (scan_expression): Likewise.
3035         * common/filestuff.c (mkdir_recursive): Likewise.
3036         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3037         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3038         (gdb_abspath): Likewise.
3039         * compile/compile-cplus-types.c
3040         (compile_cplus_instance::decl_name): Likewise.
3041         * completer.c (complete_explicit_location):
3042         (signal_completer, reg_or_group_completer_1): Likewise.
3043         * cp-support.c (cp_remove_params_if_any): Likewise.
3044         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3045         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3046         * infcmd.c (strip_bg_char): Likewise.
3047         * linespec.c (copy_token_string): Likewise.
3048         * mi/mi-main.c (output_cores): Likewise.
3049         * psymtab.c (psymtab_search_name):
3050         * symfile.c (test_set_ext_lang_command): Likewise.
3051         * target.c (target_fileio_read_stralloc): Likewise.
3052         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3053         * value.c (complete_internalvar): Likewise.
3054
3055 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3056
3057         Add objfile property to gdb.Type.
3058         * NEWS: Mention Python API addition.
3059         * python/py-type.c (typy_get_objfile): New method.
3060
3061 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3062
3063         * NEWS: Mention the new set|show style [title|highlight].
3064         Mention changes to "show style", "help" and "apropos".
3065
3066 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3067
3068         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3069         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3070         instead of print_help_for_command.
3071         (print_doc_of_command): New function.
3072         (help_list): Add 'apropos -v word' suggestion.
3073         (print_help_for_command): Style the command name using title style.
3074         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3075         (_initialize_cli_cmds): Describe -v in apropos_command help.
3076
3077 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3078
3079         * cli/cli-style.h (cli_style_option): Add name in constructor,
3080         add m_name class member, add constructor with intensity,
3081         add name class function.
3082         (cli_style_option::add_setshow_commands): Remove name argument.
3083         (highlight_style, title_style): New styles.
3084         * cli/cli-style.c (do_show): New function that shows a style
3085         characteristic styling the style name with itself.
3086         (set_style_name): New function.
3087         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3088         Update all callers according to the changes in cli/cli-style.h.
3089         * utils.h (fputs_highlighted): New function.
3090         * utils.c (fputs_highlighted): Likewise.
3091
3092 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3093
3094         * NEWS: Mention new pipe command and new convenience variables.
3095
3096 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3097
3098         * cli/cli-cmds.c (pipe_command): New function.
3099         (_initialize_cli_cmds): Call add_com for pipe_command.
3100         Define | as an alias for pipe.
3101         (exit_status_set_internal_vars): New function.
3102         (shell_escape): Call exit_status_set_internal_vars.
3103         cli/cli-decode.c (find_command_name_length): Recognize | as
3104         a single character command.
3105
3106 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3107
3108         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3109         top.c (execute_command_to_ui_file): New function, mostly a copy
3110         of execute_command_to_string.
3111         (execute_command_to_string): Implement by calling
3112         execute_command_to_ui_file.
3113
3114 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3115
3116         * top.h (saved_command_line): Remove declaration.
3117         * top.c (previous_saved_command_line, previous_repeat_arguments):
3118         New variables.
3119         (saved_command_line): Make static, define together with other
3120         'repeat variables'.
3121         (dont_repeat): Clear repeat_arguments.
3122         (repeat_previous, get_saved_command_line, save_command_line):
3123         New functions.
3124         (gdb_init): Initialize saved_command_line
3125         and previous_saved_command_line.
3126         * main.c (captured_main_1): Remove saved_command_line initialization.
3127         * event-top.c (handle_line_of_input): Update to use
3128         the new 'repeat' related functions instead of direct access to
3129         saved_command_line.
3130         * command.h (repeat_previous, get_saved_command_line,
3131         save_command_line): New declarations.
3132         (dont_repeat): Add comment.
3133
3134 2019-05-30  Tom Tromey  <tromey@adacore.com>
3135
3136         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3137         Fix comment.
3138         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3139
3140 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3141
3142         PR cli/24587
3143         * completer.c (complete): Initialize variable word.
3144
3145 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3146
3147         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3148         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3149         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3150         'body' is NULL to the outter 'if', protecting the '!is_define'
3151         situation as well.
3152
3153 2019-05-29  Tom Tromey  <tromey@adacore.com>
3154
3155         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3156         (dwarf_unknown): New function.
3157         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3158         (dwarf_type_encoding_name): Use dwarf_unknown.
3159
3160 2019-05-29  Tom Tromey  <tromey@adacore.com>
3161
3162         PR c++/20020:
3163         * cp-valprint.c (cp_print_value_fields): Call
3164         cp_print_static_field inside "try".
3165
3166 2019-05-29  Tom Tromey  <tromey@adacore.com>
3167
3168         * inflow.c (struct terminal_info): Add default operator=.
3169         * configure: Rebuild.
3170         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3171         -Wdeprecated-copy-dtor, -Wredundant-move.
3172
3173 2019-05-29  Tom Tromey  <tromey@adacore.com>
3174
3175         * NEWS: Add entry.
3176         * infcmd.c (print_return_value_1): Handle finish_print
3177         option.
3178         (show_print_finish): New function.
3179         (_initialize_infcmd): Add "set/show print finish" commands.
3180         * valprint.c (user_print_options): Initialize new member.
3181         * valprint.h (struct value_print_options) <finish_print>: New
3182         member.
3183
3184 2019-05-28  Tom Tromey  <tromey@adacore.com>
3185
3186         * ada-lang.c (ada_remove_Xbn_suffix)
3187         (find_old_style_renaming_symbol)
3188         (parse_old_style_renaming): Remove.
3189         (ada_find_renaming_symbol): Don't call
3190         find_old_style_renaming_symbol.
3191         (ada_is_renaming_symbol): Rename from
3192         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3193         bool.  Now static.
3194         (ada_read_var_value): Update and simplify.
3195         * ada-exp.y (write_var_or_type): Remove old code.
3196
3197 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3198
3199         * event-top.c: Remove include comment.
3200         * inflow.c (class scoped_ignore_sigttou): Move from here...
3201         * inflow.h (class scoped_ignore_sigttou): ...to here.
3202         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3203         * top.c:  Remove include comment.
3204
3205 2019-05-27  Tom Tromey  <tom@tromey.com>
3206
3207         * NEWS: Fix typo.
3208
3209 2019-05-22  Tom Tromey  <tromey@adacore.com>
3210
3211         * target.c (target_follow_exec): Constify parameter.
3212         * target-delegates.c: Rebuild.
3213         * remote.c (remote_target::follow_exec): Constify parameter.
3214         * infrun.c (follow_exec): Constify parameter.
3215         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3216         (target_follow_exec): Likewise.
3217
3218 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3219
3220         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3221         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3222
3223 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3224
3225         * NEWS: Add debugredirect and testsuite sections.
3226
3227 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3228
3229         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3230         target descriptions using exclusively floating point register name
3231         aliases.
3232
3233 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         PR gdb/18644:
3236         * f-lang.c (build_fortran_types): Handle the case where
3237         gdbarch_floatformat_for_type returns a nullptr.
3238
3239 2019-05-21  Tom de Vries  <tdevries@suse.de>
3240
3241         PR cli/24587
3242         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3243
3244 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3245
3246         PR gdb/18644:
3247         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3248         16-byte floats.
3249         * i386-tdep.c (i386_floatformat_for_type): Use
3250         floatformats_ia64_quad for the 16-byte floating point component
3251         within a fortran 32-byte complex number.
3252
3253 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3256         delete default constructor.
3257         (find_partial_die): Update to return const struct.
3258         (partial_die_parent_scope): Move variable declaration into scope
3259         of its use and change its type to auto.
3260         (guess_partial_die_structure_name): Likewise.
3261         (partial_die_info::fixup): Likewise.
3262
3263 2019-05-17  Tom Tromey  <tromey@adacore.com>
3264
3265         * source.c (find_and_open_source): Remove cast.
3266
3267 2019-05-17  Tom Tromey  <tromey@adacore.com>
3268
3269         * annotate.c (annotate_source): Make "filename" const.
3270         * annotate.h (annotate_source): Use const.
3271
3272 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3273
3274         * disasm.c (set_disassembler_options): Send errors to stderr.
3275
3276 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3277
3278         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3279         (cli_interp_base::set_logging): Check debug_redirect.
3280         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3281         * cli/cli-logging.c (debug_redirect): Add static variable.
3282         (pop_output_files): Add default param.
3283         (handle_redirections): Print debug setting.
3284         (show_logging_command): Likewise.
3285         (_initialize_cli_logging): Add debugredirect command.
3286         * interps.c (current_interp_set_logging): Add debug_redirect
3287         parameter.
3288         * interps.h (set_logging): Add debug_redirect parameter.
3289         (current_interp_set_logging): Likewise.
3290         * mi/mi-common.h: Likewise.
3291         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3292
3293 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3294             Tom Tromey  <tromey@adacore.com>
3295
3296         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3297         directly.
3298         * cli/cli-interp.h (make_logging_output): Remove declaration.
3299         * cli/cli-logging.c (make_logging_output): Remove function.
3300         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3301         directly.
3302         * ui-file.c (tee_file::tee_file): Remove bools.
3303         (tee_file::~tee_file): Remove deletes.
3304         * ui-file.h (tee_file): Remove bools.
3305
3306 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3307
3308         * mi/mi-cmds.h (mi_cmd_complete): New function.
3309         * mi/mi-main.c (mi_cmd_complete): Likewise.
3310         * mi/mi-cmds.c: Define new MI command -complete.
3311         * NEWS: Mention new -complete command.
3312
3313 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3314
3315         * completer.h (complete): New function.
3316         * completer.c (complete): Likewise.
3317         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3318         function defined in completer.h.
3319
3320 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3321
3322         * MAINTAINERS (Write After Approval): Add myself.
3323
3324 2019-05-17  Tom de Vries  <tdevries@suse.de>
3325
3326         PR gdb/24094
3327         * dwarf2read.c (struct cu_partial_die_info): New struct.
3328         (find_partial_die): Return cu_partial_die_info.
3329         (partial_die_parent_scope, guess_partial_die_structure_name)
3330         (partial_die_info::fixup): Handle new return type of find_partial_die.
3331
3332 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3333
3334         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3335         "std::string", simplifying the algorithm.
3336
3337 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3338
3339         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3340         (stap_static_probe_ops::get_probes): Likewise.
3341
3342 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3343
3344         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3345         '-')" and "else if".
3346         (stap_parse_single_operand): Join checks for
3347         "gdbarch_stap_parse_special_token_p" and
3348         "gdbarch_stap_parse_special_token" in the same "if" statement.
3349         Invert check when verifying for operation on register
3350         displacement.
3351
3352 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3353
3354         * stap-probe.c (stap_get_opcode): Update comment.
3355         (stap_get_expected_argument_type): Likewise.
3356         (handle_stap_probe): Likewise.
3357
3358 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3359
3360         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3361         return type to 'bool'.  Adjust comment.  Use 'bool' when
3362         appropriate.
3363         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3364         * stap-probe.c (stap_parse_argument_1): Likewise.
3365         (stap_is_operator): Likewise.
3366         (stap_is_generic_prefix): Likewise.
3367         (stap_is_register_prefix): Likewise.
3368         (stap_is_register_indirection_prefix): Likewise.
3369         (stap_is_integer_prefix): Likewise.
3370         (stap_generic_check_suffix): Likewise.
3371         (stap_check_integer_suffix): Likewise.
3372         (stap_check_register_suffix): Likewise.
3373         (stap_check_register_indirection_suffix): Likewise.
3374         (stap_parse_register_operand): Likewise.
3375         (stap_parse_single_operand): Likewise.
3376         (stap_parse_argument_1): Likewise.
3377         (stap_probe::get_argument_count): Likewise.
3378         (stap_is_operator): Likewise.
3379
3380 2019-05-16  Tom Tromey  <tromey@adacore.com>
3381
3382         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3383         keyword to foreach.
3384
3385 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3386
3387         * linux-thread-db.c (try_thread_db_load_1): Change return type
3388         to bool.
3389         (try_thread_db_load): Likewise.
3390         (try_thread_db_load_from_pdir_1): Likewise.
3391         (try_thread_db_load_from_pdir): Likewise.
3392         (try_thread_db_load_from_sdir): Likewise.
3393         (try_thread_db_load_from_dir): Likewise.
3394         (thread_db_load_search): Likewise.
3395         (has_libpthread): Likewise.
3396         (thread_db_load): Likewise.
3397
3398 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3399
3400         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3401         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3402         NULL, and complain/return if that's the case.
3403
3404 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3405
3406         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3407         (advance, posn, abstract_read_memory): New functions.
3408         [struct mem_read_abstraction]: New struct.
3409         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3410
3411 2019-05-14  Tom Tromey  <tromey@adacore.com>
3412
3413         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3414         value is not lval_memory.
3415
3416 2019-05-14  Tom Tromey  <tromey@adacore.com>
3417
3418         * solib.c (info_sharedlibrary_command): Style the file name.
3419
3420 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3421
3422         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3423         (aarch64_vnv_type): Likewise.
3424         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3425         * common/tdesc.c: Likewise.
3426         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3427         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3428         * features/aarch64-fpu.xml: Add ieee half view.
3429         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3430         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3431         * gdbtypes.h (struct builtin_type): Likewise.
3432         (struct objfile_type): Likewise.
3433
3434 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3435
3436         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3437         typo.
3438         * location.h (string_to_event_location): Likewise.
3439
3440 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3441
3442         GDB 8.3 released.
3443
3444 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3445
3446         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3447         New variable declaration.
3448         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3449         New variable.
3450         (print_one_breakpoint): Use ui_out::test_flags and new global
3451         variable to compute use_fixed_output.
3452         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3453         Remove.
3454         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3455         (mi_multi_location_breakpoint_output_fixed): Remove.
3456         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3457         new variable.
3458         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3459         fix_multi_location_breakpoint_output flag if version >= 3.
3460         * ui-out.h (enum ui_out_flag)
3461         <fix_multi_location_breakpoint_output>: New enumerator.
3462
3463 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3464
3465         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3466
3467 2019-05-10  Tom Tromey  <tromey@adacore.com>
3468
3469         * ada-lang.c (catch_ada_completer): New function.
3470         (_initialize_ada_language): Use it.
3471
3472 2019-05-10  Tom Tromey  <tromey@adacore.com>
3473
3474         * thread.c (print_thread_info): Make "requested_threads" const.
3475         * gdbthread.h (print_thread_info): Make "requested_threads"
3476         const.
3477         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3478         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3479
3480 2019-05-08  Tom Tromey  <tom@tromey.com>
3481
3482         * gdbtypes.c (objfile_type_data): Change type.
3483         (objfile_type, _initialize_gdbtypes): Update.
3484
3485 2019-05-08  Tom Tromey  <tom@tromey.com>
3486
3487         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3488         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3489         (_initialize_dwarf2_frame): Update.
3490
3491 2019-05-08  Tom Tromey  <tom@tromey.com>
3492
3493         * objc-lang.c (objc_objfile_data): Change type.
3494         (find_methods): Update.
3495         (_initialize_objc_lang): Remove.
3496
3497 2019-05-08  Tom Tromey  <tom@tromey.com>
3498
3499         * stabsread.c (rs6000_builtin_type_data): Change type.
3500         (rs6000_builtin_type, _initialize_stabsread): Update.
3501
3502 2019-05-08  Tom Tromey  <tom@tromey.com>
3503
3504         * mips-tdep.c (mips_pdr_data): Remove.
3505         (_initialize_mips_tdep): Update.
3506
3507 2019-05-08  Tom Tromey  <tom@tromey.com>
3508
3509         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3510         (hppa_init_objfile_priv_data, read_unwind_info)
3511         (find_unwind_entry, _initialize_hppa_tdep): Update.
3512
3513 2019-05-08  Tom Tromey  <tom@tromey.com>
3514
3515         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3516         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3517         on obstack.
3518         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3519
3520 2019-05-08  Tom Tromey  <tom@tromey.com>
3521
3522         * mdebugread.c (basic_type_data): Change type.
3523         (basic_type, _initialize_mdebugread): Update.
3524
3525 2019-05-08  Tom Tromey  <tom@tromey.com>
3526
3527         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3528
3529 2019-05-08  Tom Tromey  <tom@tromey.com>
3530
3531         * nto-tdep.c (nto_inferior_data_reg): Change type.
3532         (nto_inferior_data): Update.
3533         (nto_inferior_data_cleanup, nto_new_inferior_data)
3534         (_initialize_nto_tdep): Remove.
3535         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3536
3537 2019-05-08  Tom Tromey  <tom@tromey.com>
3538
3539         * ada-lang.c (struct ada_inferior_data): Add initializers.
3540         (ada_inferior_data): Change type.
3541         (ada_inferior_data_cleanup): Remove.
3542         (get_ada_inferior_data, ada_inferior_exit)
3543         (struct ada_pspace_data): Add initializers, destructor.
3544         (ada_pspace_data_handle): Change type.
3545         (get_ada_pspace_data): Update.
3546         (ada_pspace_data_cleanup): Remove.
3547
3548 2019-05-08  Tom Tromey  <tom@tromey.com>
3549
3550         * coffread.c (struct coff_symfile_info): Add initializers.
3551         (coff_objfile_data_key): Move lower.  Change type.
3552         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3553         Update.
3554         (coff_free_info): Remove.
3555
3556 2019-05-08  Tom Tromey  <tom@tromey.com>
3557
3558         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3559         (fbsd_pspace_data_handle): Move lower.  Change type.
3560         (get_fbsd_pspace_data): Update.
3561         (fbsd_pspace_data_cleanup): Remove.
3562         (_initialize_fbsd_tdep): Update.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3567         (get_ada_tasks_pspace_data): Update.
3568         (ada_tasks_pspace_data_cleanup): Remove.
3569         (_initialize_tasks): Update.
3570         (ada_tasks_inferior_data_handle): Change type.
3571         (get_ada_tasks_inferior_data): Update.
3572         (ada_tasks_inferior_data_cleanup): Remove.
3573         (struct ada_tasks_pspace_data): Add initializers.
3574
3575 2019-05-08  Tom Tromey  <tom@tromey.com>
3576
3577         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3578         * symfile-debug.c (debug_sym_get_probes): Change type.
3579         * stap-probe.c (handle_stap_probe):
3580         (stap_static_probe_ops::get_probes): Change type.
3581         * probe.h (class static_probe_ops) <get_probes>: Change type.
3582         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3583         (parse_probes_in_pspace): Update.
3584         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3585         Update.
3586         (any_static_probe_ops::get_probes): Change type.
3587         * elfread.c (elfread_data): New typedef.
3588         (probe_key): Change type.
3589         (elf_get_probes): Likewise.  Update.
3590         (probe_key_free): Remove.
3591         (_initialize_elfread): Update.
3592         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3593         Change type.
3594         (dtrace_process_dof_probe, dtrace_process_dof)
3595         (dtrace_static_probe_ops::get_probe): Change type.
3596
3597 2019-05-08  Tom Tromey  <tom@tromey.com>
3598
3599         * xcoffread.c (struct xcoff_symfile_info): Rename from
3600         coff_symfile_info.  Add initializers.
3601         (xcoff_objfile_data_key): Move lower.  Change type.
3602         (XCOFF_DATA): Rewrite.
3603         (xcoff_free_info): Remove.
3604         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3605         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3606         (xcoff_initial_scan): Update.
3607
3608 2019-05-08  Tom Tromey  <tom@tromey.com>
3609
3610         * solib-svr4.c (struct svr4_info): Add initializers and
3611         destructor.
3612         <probes_table>: Now an htab_up.
3613         (solib_svr4_pspace_data): Change type.
3614         (free_probes_table): Simplify.
3615         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3616         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3617         (probes_table_remove_objfile_probes, register_solib_event_probe)
3618         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3619         (_initialize_svr4_solib): Update.
3620
3621 2019-05-08  Tom Tromey  <tom@tromey.com>
3622
3623         * remote.c (remote_pspace_data): Change type.
3624         (remote_pspace_data_cleanup): Remove.
3625         (get_remote_exec_file, set_pspace_remote_exec_file)
3626         (_initialize_remote): Update.
3627
3628 2019-05-08  Tom Tromey  <tom@tromey.com>
3629
3630         * breakpoint.c (breakpoint_objfile_key): Change type.
3631         (get_breakpoint_objfile_data): Update.
3632         (free_breakpoint_objfile_data): Remove.
3633         (_initialize_breakpoint): Update.
3634
3635 2019-05-08  Tom Tromey  <tom@tromey.com>
3636
3637         * linux-tdep.c (struct linux_info): Add initializers.
3638         (linux_inferior_data): Move.  Change type.
3639         (invalidate_linux_cache_inf): Update.
3640         (linux_inferior_data_cleanup): Remove.
3641         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3642
3643 2019-05-08  Tom Tromey  <tom@tromey.com>
3644
3645         * auxv.c (auxv_inferior_data): Move.  Change type.
3646         (auxv_inferior_data_cleanup): Remove.
3647         (invalidate_auxv_cache_inf): Rewrite.
3648         (get_auxv_inferior_data, _initialize_auxv): Update.
3649
3650 2019-05-08  Tom Tromey  <tom@tromey.com>
3651
3652         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3653         (symfile_debug_objfile_data_key): Change type.
3654         (symfile_debug_installed, debug_qf_has_symbols)
3655         (debug_qf_find_last_source_symtab)
3656         (debug_qf_forget_cached_source_info)
3657         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3658         (debug_qf_print_stats, debug_qf_dump)
3659         (debug_qf_expand_symtabs_for_function)
3660         (debug_qf_expand_all_symtabs)
3661         (debug_qf_expand_symtabs_with_fullname)
3662         (debug_qf_map_matching_symbols)
3663         (debug_qf_expand_symtabs_matching)
3664         (debug_qf_find_pc_sect_compunit_symtab)
3665         (debug_qf_map_symbol_filenames)
3666         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3667         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3668         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3669         (debug_sym_read_linetable, debug_sym_relocate): Update.
3670         (symfile_debug_free_objfile): Remove.
3671         (install_symfile_debug_logging, _initialize_symfile_debug):
3672         Update.
3673
3674 2019-05-08  Tom Tromey  <tom@tromey.com>
3675
3676         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3677         allocate_on_obstack.
3678         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3679         (get_dwarf2_per_objfile): Update.
3680         (set_dwarf2_per_objfile): Remove.
3681         (dwarf2_has_info, dwarf2_get_section_info): Update.
3682         (dwarf2_free_objfile): Remove.
3683         (_initialize_dwarf2_read): Update.
3684
3685 2019-05-08  Tom Tromey  <tom@tromey.com>
3686
3687         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3688         initializers.
3689         <unsupported_script_warning_printed,
3690         script_not_found_warning_printed>: Now bool.
3691         (auto_load_pspace_data): Change type.
3692         (~auto_load_pspace_info): Rename from
3693         auto_load_pspace_data_cleanup.
3694         (get_auto_load_pspace_data, init_loaded_scripts_info)
3695         (clear_section_scripts, maybe_print_unsupported_script_warning)
3696         (maybe_print_script_not_found_warning, _initialize_auto_load):
3697         Update.
3698
3699 2019-05-08  Tom Tromey  <tom@tromey.com>
3700
3701         * objfiles.c (objfile_pspace_info): Add destructor and
3702         initializers.
3703         (objfiles_pspace_data): Change type.
3704         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3705         (get_objfile_pspace_data): Update.
3706         (objfiles_bfd_data): Change type.
3707         (get_objfile_bfd_data): Update.
3708         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3709
3710 2019-05-08  Tom Tromey  <tom@tromey.com>
3711
3712         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3713         Change type.
3714         (get_catch_syscall_inferior_data): Update.
3715         (catch_syscall_inferior_data_cleanup): Remove.
3716         (_initialize_break_catch_syscall): Update.
3717
3718 2019-05-08  Tom Tromey  <tom@tromey.com>
3719
3720         * inflow.c (struct terminal_info): Add destructor and
3721         initializers.
3722         (inflow_inferior_data): Change type.
3723         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3724         (get_inflow_inferior_data, inflow_inferior_exit)
3725         (swap_terminal_info, _initialize_inflow): Update.
3726
3727 2019-05-08  Tom Tromey  <tom@tromey.com>
3728
3729         * target-dcache.c (target_dcache_cleanup): Remove.
3730         (target_dcache_aspace_key): Change type.
3731         (target_dcache_init_p, target_dcache_invalidate)
3732         (target_dcache_get, target_dcache_get_or_init)
3733         (_initialize_target_dcache): Update.
3734         * dcache.h (struct dcache_deleter): New.
3735
3736 2019-05-08  Tom Tromey  <tom@tromey.com>
3737
3738         * symtab.c (struct symbol_cache): Add destructor and
3739         initializers.
3740         (symbol_cache_key): Move.  Change type.
3741         (make_symbol_cache, free_symbol_cache): Remove.
3742         (get_symbol_cache): Update.
3743         (symbol_cache_cleanup): Remove.
3744         (ALL_PSPACES, symbol_cache_flush)
3745         (maintenance_print_symbol_cache)
3746         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3747         Update.
3748
3749 2019-05-08  Tom Tromey  <tom@tromey.com>
3750
3751         * symtab.c (struct main_info): Add destructor and initializers.
3752         (main_progspace_key): Move.  Change type.
3753         (get_main_info): Update.
3754         (main_info_cleanup): Remove.
3755         (_initialize_symtab): Update.
3756
3757 2019-05-08  Tom Tromey  <tom@tromey.com>
3758
3759         * registry.h (DECLARE_REGISTRY): Define the _key class.
3760
3761 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         * NEWS: Merge two 'New commands' sections.
3764
3765 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3766
3767         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3768         parameter and use Ada language definition instead.
3769         (ada_val_print_ptr): Remove unused language parameter.
3770         (ada_val_print_num): Remove language parameter and use Ada language
3771         definition instead.
3772         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3773         parameter.
3774         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3775         parameter and use Ada language definition instead.
3776         (ada_val_print_1): Update all ada_val_print_xxx calls.
3777         Remove language parameter.
3778         (ada_val_print): Update ada_val_print_1 call.
3779
3780 2019-05-08  Tom Tromey  <tromey@adacore.com>
3781
3782         * remote.c (remote_hw_watchpoint_limit)
3783         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3784         Now static.
3785
3786 2019-05-08  Tom Tromey  <tromey@adacore.com>
3787
3788         * maint.c (_initialize_maint_cmds): Move initialization code to
3789         remote.c.
3790         (watchdog, show_watchdog): Move to remote.c.
3791         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3792         "watchdog" static.
3793         (_initialize_remote): Move initialization code from maint.c.
3794         * defs.h (watchdog): Don't declare.
3795
3796 2019-05-08  Tom Tromey  <tromey@adacore.com>
3797
3798         * tui/tui-interp.c: Include main.h.
3799         * interps.c: Include main.h.
3800         * main.h (interpreter_p): Declare.
3801         * defs.h (interpreter_p): Don't declare.
3802
3803 2019-05-08  Tom Tromey  <tromey@adacore.com>
3804
3805         * dwarf2loc.c: Include dwarf2read.h.
3806         * defs.h (read_unsigned_leb128): Don't declare.
3807         * dwarf2read.h (read_unsigned_leb128): Declare.
3808
3809 2019-05-08  Tom Tromey  <tromey@adacore.com>
3810
3811         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3812         method.
3813
3814 2019-05-08  Tom Tromey  <tromey@adacore.com>
3815
3816         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3817         when no wrap column is set.
3818
3819 2019-05-08  Tom Tromey  <tromey@adacore.com>
3820
3821         * c-lang.c (c_get_string): Handle non-C-style arrays.
3822
3823 2019-05-08  Tom Tromey  <tromey@adacore.com>
3824
3825         * typeprint.c (print_offset_data::update): Print the bit offset,
3826         not the number of bits remaining.
3827
3828 2019-05-08  Tom Tromey  <tromey@adacore.com>
3829
3830         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3831         padding at end of comment.
3832
3833 2019-05-08  Tom Tromey  <tromey@adacore.com>
3834
3835         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3836         Compare main types.
3837
3838 2019-05-06  Tom Tromey  <tom@tromey.com>
3839
3840         * common/scoped_mmap.c: Include common-defs.h.
3841         * common/scoped_mmap.h: Don't include config.h.
3842
3843 2019-05-04  Tom Tromey  <tom@tromey.com>
3844
3845         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3846         (struct aarch64_call_info): Add initializers.
3847         <si>: Now a std::vector.
3848         (pass_on_stack, aarch64_push_dummy_call): Update.
3849
3850 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3851             Tom Tromey  <tom@tromey.com>
3852
3853         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3854         (ppc_threads): Now a std::vector.  Now static.
3855         (hwdebug_find_thread_points_by_tid)
3856         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3857         Update.
3858
3859 2019-05-04  Tom Tromey  <tom@tromey.com>
3860
3861         * arc-tdep.c (arc_tdesc_init): Return bool.
3862
3863 2019-05-04  Tom Tromey  <tom@tromey.com>
3864
3865         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3866         Use gdb_assert_not_reached.
3867
3868 2019-05-04  Tom Tromey  <tom@tromey.com>
3869
3870         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3871         "false".
3872
3873 2019-05-04  Tom Tromey  <tom@tromey.com>
3874
3875         * arc-tdep.c (arc_tdesc_init): Use bool.
3876
3877 2019-05-04  Tom Tromey  <tom@tromey.com>
3878
3879         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3880
3881 2019-05-04  Tom Tromey  <tom@tromey.com>
3882
3883         * cli/cli-cmds.c (valid_command_p): Return bool.
3884
3885 2019-05-04  Tom Tromey  <tom@tromey.com>
3886
3887         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3888         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3889
3890 2019-05-04  Raul Tambre  <raul@tambre.ee>
3891
3892         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3893         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3894         operator for comparison.
3895
3896 2019-05-04  Tom Tromey  <tom@tromey.com>
3897
3898         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3899         (lookup_partial_symbol, print_partial_symbols)
3900         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3901         (psymbol_compare): Update.
3902         (add_psymbol_to_bcache): Clear the entire psymbol.
3903         (maintenance_check_psymtabs): Update.
3904         * psympriv.h (struct partial_symbol): Don't derive from
3905         general_symbol_info.
3906         <obj_section, unrelocated_address, address,
3907         set_unrelocated_address>: Update.
3908         <ginfo>: New member.
3909         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3910         (debug_names::write_psymbols): Update.
3911
3912 2019-05-04  Tom de Vries  <tdevries@suse.de>
3913
3914         * contrib/cc-with-tweaks.sh: Support -n arg.
3915
3916 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3917
3918         * corelow.c (core_target::detach): Ensure frame cache and
3919         register caches are cleared.
3920         inferior.c (exit_inferior_1): Likewise.
3921
3922 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3923             Tom Tromey  <tom@tromey.com>
3924
3925         * dictionary.c (collate_pending_symbols_by_language): Remove
3926         "struct" from foreach.
3927         * symtab.c (lookup_global_symbol_from_objfile)
3928         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3929         foreach.
3930         * ser-tcp.c (net_open): Remove "struct" from foreach.
3931         * objfiles.c (objfile_relocate, objfile_rebase)
3932         (objfile_has_symbols): Remove "struct" from foreach.
3933         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3934         from foreach.
3935         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3936         foreach.
3937         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3938         "struct" from foreach.
3939         * ada-lang.c (create_excep_cond_exprs)
3940         (ada_exception_catchpoint_cond_string): Remove "struct" from
3941         foreach.
3942
3943 2019-05-03  Tom Tromey  <tromey@adacore.com>
3944
3945         * ada-exp.y (convert_char_literal): Check suffix of each
3946         enumerator.
3947
3948 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3949
3950         PR ada/21406:
3951         * ada-exp.y (yywrap): Don't define.
3952         * ada-lex.l (%option): Add noyywrap
3953         (yywrap): Remove.
3954
3955 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3956
3957         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3958         _WIN32_WINNT to the XP level, unless already defined to a higher
3959         level.
3960
3961         * unittests/parse-connection-spec-selftests.c:
3962         * ser-tcp.c:
3963         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3964         override.
3965
3966         * symfile.c (find_separate_debug_file): Remove colon from the
3967         drive spec of DOS/Windows file names of the target, so that the
3968         file name produced from DEBUGDIR and the target's directory will
3969         be valid on DOS/Windows systems.
3970
3971 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3972
3973         * rust-lang.c (val_print_struct): Handle printing structures
3974         containing strings.
3975
3976 2019-05-02  Tom Tromey  <tromey@adacore.com>
3977
3978         * valarith.c (_initialize_valarith): Remove.
3979
3980 2019-05-01  Tom Tromey  <tromey@adacore.com>
3981
3982         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3983         bitfields.
3984
3985 2019-05-01  Tom Tromey  <tromey@adacore.com>
3986
3987         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3988         for big-endian copies.
3989
3990 2019-04-30  Ali Tamur  <tamur@google.com>
3991         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3992         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3993         (read_3_bytes): New function.
3994
3995 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3996
3997         * windows-nat.c (main_thread_id): Delete.
3998         (handle_output_debug_string): Replace main_thread_id by
3999         current_event.dwThreadId.
4000         (fake_create_process): Likewise.
4001         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4002         Do not set main_thread_id.
4003         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4004         current_event.dwThreadId.
4005         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4006
4007 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4008
4009         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4010         Use current_event.dwThreadId instead of main_thread_id.
4011
4012 2019-04-30  Tom Tromey  <tromey@adacore.com>
4013
4014         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4015         (create_excep_cond_exprs): Iterate over program spaces.
4016         (ada_exception_catchpoint_cond_string): Examine all minimal
4017         symbols for exception types.
4018
4019 2019-04-30  Tom Tromey  <tromey@adacore.com>
4020
4021         PR c++/24470:
4022         * dwarf2read.c (process_structure_scope): Handle case where type
4023         has template parameters but no symbol was created.
4024
4025 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4026             Chris January  <chris.january@arm.com>
4027
4028         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4029         qualifier.
4030         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4031
4032 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * f-typeprint.c (f_print_type): Update rules for printing
4035         whitespace.
4036         (f_type_print_varspec_suffix): Likewise.
4037
4038 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4039             Chris January  <chris.january@arm.com>
4040
4041         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4042         function arguments.
4043
4044 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4045
4046         * f-lang.c (build_fortran_types): Change name of void type to
4047         lower case.
4048         * f-typeprint.c (f_type_print_base): Print the name of the void
4049         type, rather than a fixed string.
4050         * f-valprint.c (f_decorations): Use lower case void string.
4051
4052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4053             Chris January  <chris.january@arm.com>
4054
4055         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4056         types for Fortran.
4057
4058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4059             Chris January  <chris.january@arm.com>
4060             David Lecomber  <david.lecomber@arm.com>
4061
4062         * f-exp.y (BINOP_INTRINSIC): New token.
4063         (exp): New parser rule handling BINOP_INTRINSIC.
4064         (f77_keywords): Add new builtin procedures.
4065         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4066         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4067         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4068         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4069         (print_unop_subexp_f): New function.
4070         (print_binop_subexp_f): New function.
4071         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4072         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4073         (dump_subexp_body_f): Likewise.
4074         (operator_check_f): Likewise.
4075         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4076         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4077
4078 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4079
4080         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4081         UNOP_KIND.
4082         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4083         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4084         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4085         (operator_length_f): New fuction.
4086         (print_subexp_f): New function.
4087         (op_name_f): New function.
4088         (dump_subexp_body_f): New function.
4089         (operator_check_f): New function.
4090         (exp_descriptor_f): Replace standard expression handling functions
4091         with new functions.
4092         * gdb/fortran-operator.def: New file.
4093         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4094         * gdb/std-operator.def: Remove UNOP_KIND.
4095
4096 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * std-operator.def: Remove unbalanced, stray double quote
4099         character.
4100
4101 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4102             Chris January  <chris.january@arm.com>
4103             Daniel Everett  <daniel.everett@arm.com>
4104             Nick Forrington  <nick.forrington@arm.com>
4105             Richard Bunt  <richard.bunt@arm.com>
4106
4107         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4108         of depth when printing anonymous structs or unions.
4109         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4110         Don't print either the top-level value, or the children if the
4111         max-depth is exceeded.
4112         (ppscm_print_children): When printing the key of a map, allow one
4113         extra level of depth.
4114         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4115         print either the top-level value, or the children if the max-depth
4116         is exceeded.
4117         (print_children): When printing the key of a map, allow one extra
4118         level of depth.
4119         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4120         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4121         (user_print_options): Initialise max_depth field.
4122         (val_print_scalar_or_string_type_p): New function.
4123         (val_print): Check to see if the max depth has been reached.
4124         (val_print_check_max_depth): Define new function.
4125         (show_print_max_depth): New function.
4126         (_initialize_valprint): Add 'print max-depth' option.
4127         * valprint.h (struct value_print_options) <max_depth>: New field.
4128         (val_print_check_max_depth): Declare new function.
4129         * NEWS: Document new feature.
4130
4131 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4132
4133         * ada-lang.c (ada_language_defn): Initialise new field.
4134         * c-lang.c (c_is_string_type_p): New function.
4135         (c_language_defn): Initialise new field.
4136         (cplus_language_defn): Initialise new field.
4137         (asm_language_defn): Initialise new field.
4138         (minimal_language_defn): Initialise new field.
4139         * c-lang.h (c_is_string_type_p): Declare new function.
4140         * d-lang.c (d_language_defn): Initialise new field.
4141         * f-lang.c (f_is_string_type_p): New function.
4142         (f_language_defn): Initialise new field.
4143         * go-lang.c (go_is_string_type_p): New function.
4144         (go_language_defn): Initialise new field.
4145         * language.c (default_is_string_type_p): New function.
4146         (unknown_language_defn): Initialise new field.
4147         (auto_language_defn): Initialise new field.
4148         * language.h (struct language_defn) <la_is_string_type_p>: New
4149         member variable.
4150         (default_is_string_type_p): Declare new function.
4151         * m2-lang.c (m2_language_defn): Initialise new field.
4152         * objc-lang.c (objc_language_defn): Initialise new field.
4153         * opencl-lang.c (opencl_language_defn): Initialise new field.
4154         * p-lang.c (pascal_is_string_type_p): New function.
4155         (pascal_language_defn): Initialise new field.
4156         * rust-lang.c (rust_is_string_type_p): New function.
4157         (rust_language_defn): Initialise new field.
4158
4159 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4160
4161         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4162         New field.
4163         * ada-lang.c (ada_language_defn): Initialise new field.
4164         * c-lang.c (c_language_defn): Likewise.
4165         (cplus_language_defn): Likewise.
4166         (asm_language_defn): Likewise.
4167         (minimal_language_defn): Likewise.
4168         * d-lang.c (d_language_defn): Likewise.
4169         * f-lang.c (f_language_defn): Likewise.
4170         * go-lang.c (go_language_defn): Likewise.
4171         * language.c (unknown_language_defn): Likewise.
4172         (auto_language_defn): Likewise.
4173         * m2-lang.c (m2_language_defn): Likewise.
4174         * objc-lang.c (objc_language_defn): Likewise.
4175         * opencl-lang.c (opencl_language_defn): Likewise.
4176         * p-lang.c (pascal_language_defn): Likewise.
4177         * rust-lang.c (rust_language_defn): Likewise.
4178
4179 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * ada-lang.c (ada_is_character_type): Change return type to bool.
4182         (ada_is_string_type): Likewise.
4183         * ada-lang.h (ada_is_character_type): Update declaration
4184         (ada_is_string_type): Likewise.
4185
4186 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4187
4188         Support style in 'frame|thread apply'
4189
4190         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4191         * record.c (record_start, record_stop): Update callers of
4192         execute_command_to_string with false.
4193         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4194         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4195         methods.
4196         (class string_file): New constructor with term_out parameter.
4197         Override methods term_out and can_emit_style_escape.  New member
4198         term_out.
4199         (class stdio_file): Override can_emit_style_escape.
4200         (class tee_file): Override term_out and can_emit_style_escape.
4201         * utils.h (can_emit_style_escape): Remove.
4202         * utils.c (can_emit_style_escape): Likewise.
4203         Update all callers of can_emit_style_escape (SOMESTREAM) to
4204         SOMESTREAM->can_emit_style_escape.
4205         * source-cache.c (source_cache::get_source_lines): Likewise.
4206         * stack.c (frame_apply_command_count): Call execute_command_to_string
4207         passing the term_out characteristic of the current gdb_stdout.
4208         * thread.c (thr_try_catch_cmd): Likewise.
4209         * top.c (execute_command_to_string): pass term_out parameter
4210         to construct the string_file for the command output.
4211         * ui-file.c (term_cli_styling): New function (most code moved
4212         from utils.c can_emit_style_escape).
4213         (string_file::string_file, string_file::can_emit_style_escape,
4214         stdio_file::can_emit_style_escape, tee_file::term_out,
4215         tee_file::can_emit_style_escape): New functions.
4216
4217 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4218
4219         * NEWS: Mention the new set|show may-call-functions.
4220         * infcall.c (may_call_functions_p): New variable.
4221         (show_may_call_functions_p): New function.
4222         (call_function_by_hand_dummy): Throws an error if not
4223         may-call-functions.
4224         (_initialize_infcall): Call add_setshow_boolean_cmd for
4225         may-call-functions.
4226
4227 2019-04-25  Keith Seitz  <keiths@redhat.com>
4228
4229         PR c++/24367
4230         * cp-support.c (inspect_type): Don't attempt substitutions
4231         of symbol with the same name.
4232
4233 2019-04-25  Tom Tromey  <tromey@adacore.com>
4234
4235         PR gdb/24475:
4236         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4237         static.
4238
4239 2019-04-25  Tom Tromey  <tromey@adacore.com>
4240
4241         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4242         rvalue reference.
4243         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4244         (gdb_xml_parser::parse): Use std::move.
4245         * python/python-internal.h (gdbpy_convert_exception): Take a const
4246         reference.
4247         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4248         std::move.
4249         * python/py-utils.c (gdbpy_convert_exception): Take a const
4250         reference.
4251         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4252         Use std::move.
4253         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4254         Use std::move.
4255         * mi/mi-main.c (mi_print_exception): Take a const reference.
4256         * main.c (handle_command_errors): Take a const reference.
4257         * linespec.c (parse_linespec): Use std::move.
4258         * infcall.c (run_inferior_call): Use std::move.
4259         (call_function_by_hand_dummy): Use std::move.
4260         * exec.c (try_open_exec_file): Use std::move.
4261         * exceptions.h (exception_print, exception_fprintf)
4262         (exception_print_same): Update.
4263         * exceptions.c (print_exception, exception_print)
4264         (exception_fprintf, exception_print_same): Change parameters to
4265         const reference.
4266         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4267         * common/new-op.c: Use std::move.
4268         * common/common-exceptions.h (struct gdb_exception): Add move
4269         constructor.
4270         (struct gdb_exception_error, struct gdb_exception_quit, struct
4271         gdb_quit_bad_alloc): Change constructor to move constructor.
4272         (throw_exception): Change parameter to rvalue reference.
4273         * common/common-exceptions.c (throw_exception): Take rvalue
4274         reference.
4275         * cli/cli-interp.c (safe_execute_command): Use std::move.
4276         * breakpoint.c (insert_bp_location, location_to_sals): Use
4277         std::move.
4278
4279 2019-04-25  Tom Tromey  <tromey@adacore.com>
4280
4281         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4282         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4283         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4284         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4285         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4286         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4287         guile/scm-value.c: Use unpack.
4288         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4289         gdbscm_gdb_exception.
4290         (gdbscm_throw_gdb_exception): Likewise.
4291         (struct gdbscm_gdb_exception): New.
4292         (unpack): New function.
4293         (gdbscm_wrap): Use unpack.
4294
4295 2019-04-25  Tom Tromey  <tromey@adacore.com>
4296
4297         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4298         (gdb_rl_callback_handler): Use std::move.
4299         * common/common-exceptions.h (struct gdb_exception): Add move
4300         assignment operator.
4301         (throw_exception_sjlj): Change "exception" to const reference.
4302         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4303         (throw_exception_sjlj): Change "exception" to const reference.
4304
4305 2019-04-25  Tom Tromey  <tromey@adacore.com>
4306
4307         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4308         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4309         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4310         Update.
4311         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4312         Update.
4313         * mi/mi-interp.c (mi_interp::exec): Update.
4314         * linespec.c (parse_linespec): Update.
4315         * infcall.c (run_inferior_call): Update.
4316         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4317         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4318         (gdbscm_lookup_global_symbol): Update.
4319         * guile/scm-param.c (gdbscm_parameter_value): Update.
4320         * guile/scm-frame.c (gdbscm_frame_read_register)
4321         (gdbscm_frame_read_var): Update.
4322         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4323         * exec.c (try_open_exec_file): Update.
4324         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4325         (gdb_rl_callback_handler): Update.
4326         * common/common-exceptions.h (exception_none): Don't declare.
4327         * common/common-exceptions.c (exception_none): Don't define.
4328         (struct catcher) <exception>: Update.
4329         * cli/cli-interp.c (safe_execute_command): Update.
4330         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4331
4332 2019-04-25  Ali Tamur  <tamur@google.com>
4333
4334         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4335         (read_attribute_value): Likewise.
4336         (dwarf2_read_addr_index): Update comment.
4337         (read_str_index): Add DW_FORM_strx.
4338         (dwarf2_string_attr): Likewise.
4339         (dwarf2_const_value_attr): Likewise.
4340         (dump_die_shallow): Likewise.
4341         (dwarf2_fetch_constant_bytes): Likewise.
4342         (skip_form_bytes): Likewise.
4343         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4344
4345 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4346
4347         PR corefiles/11608
4348         PR corefiles/18187
4349         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4350         OFFSET.  Verify if current mapping contains an ELF header.
4351         (linux_find_memory_regions_full): Adjust call to
4352         dump_mapping_p.
4353
4354 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4355             Kang Li <kanglictf@gmail.com>
4356
4357         PR gdb/21600
4358
4359         * dwarf2-frame.c (read_initial_length): Be consistent about using
4360         unsigned representation of length.
4361         (decode_frame_entry_1): Likewise.  Check for wraparound of
4362         end pointer as well as buffer overflow.
4363
4364 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4365
4366         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4367         "vq".
4368
4369 2019-04-24  Tom Tromey  <tromey@adacore.com>
4370
4371         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4372
4373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * s12z-tdep.c (s12z_unwind_pc): Delete.
4376         (s12z_unwind_sp): Delete.
4377         (s12z_gdbarch_init): Don't register deleted functions with
4378         gdbarch.
4379
4380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4381
4382         * rl78-tdep.c (rl78_unwind_sp): Delete.
4383         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4384
4385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4386
4387         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4388         (xstormy16_unwind_pc): Delete.
4389         (xstormy16_dummy_id): Delete.
4390         (xstormy16_gdbarch_init): Don't register deleted functions with
4391         gdbarch.
4392
4393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * vax-tdep.c (vax_unwind_pc): Delete.
4396         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4397
4398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4399
4400         * v850-tdep.c (v850_unwind_sp): Delete.
4401         (v850_unwind_pc): Delete.
4402         (v850_dummy_id): Delete.
4403         (v850_gdbarch_init): Don't register deleted functions with
4404         gdbarch.
4405
4406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4407
4408         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4409         (tilegx_unwind_pc): Delete.
4410         (tilegx_unwind_dummy_id): Delete.
4411         (tilegx_gdbarch_init): Don't register deleted functions with
4412         gdbarch.
4413
4414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4415
4416         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4417         (tic6x_dummy_id): Delete.
4418         (tic6x_gdbarch_init): Don't register deleted functions with
4419         gdbarch.
4420
4421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4422
4423         * sparc-tdep.c (sparc_unwind_pc): Delete.
4424         (sparc32_gdbarch_init): Don't register deleted function with
4425         gdbarch.
4426
4427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * sh-tdep.c (sh_unwind_sp): Delete.
4430         (sh_unwind_pc): Delete.
4431         (sh_dummy_id): Delete.
4432         (sh_gdbarch_init): Don't register deleted functions with
4433         gdbarch.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * score-tdep.c (score_unwind_sp): Delete.
4438         (score_unwind_pc): Delete.
4439         (score_dummy_id): Delete.
4440         (score_gdbarch_init): Don't register deleted functions with
4441         gdbarch.
4442
4443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * rx-tdep.c (rx_unwind_pc): Delete.
4446         (rx_unwind_sp): Delete.
4447         (rx_dummy_id): Delete.
4448         (rx_gdbarch_init): Don't register deleted functions with
4449         gdbarch.  Update comment.
4450
4451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4454         (rs6000_dummy_id): Delete.
4455         (rs6000_gdbarch_init): Don't register deleted functions with
4456         gdbarch.
4457
4458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4459
4460         * or1k-tdep.c (or1k_dummy_id): Delete.
4461         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4462
4463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * nios2-tdep.c (nios2_dummy_id): Delete.
4466         (nios2_unwind_sp): Delete.
4467         (nios2_gdbarch_init): Don't register deleted functions with
4468         gdbarch.
4469
4470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4471
4472         * nds32-tdep.c (nds32_dummy_id): Delete.
4473         (nds32_unwind_pc): Delete.
4474         (nds32_unwind_sp): Delete.
4475         (nds32_gdbarch_init): Don't register deleted functions with
4476         gdbarch.
4477
4478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * msp430-tdep.c (msp430_unwind_pc): Delete.
4481         (msp430_unwind_sp): Delete.
4482         (msp430_dummy_id): Delete.
4483         (msp430_gdbarch_init): Don't register deleted functions with
4484         gdbarch.
4485
4486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * moxie-tdep.c (moxie_unwind_sp): Delete.
4489         (moxie_unwind_pc): Delete.
4490         (moxie_dummy_id): Delete.
4491         (moxie_gdbarch_init): Don't register deleted functions with
4492         gdbarch.
4493
4494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4497         (mn10300_unwind_pc): Delete.
4498         (mn10300_unwind_sp): Delete.
4499         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4500         mn10300_unwind_sp.
4501         (mn10300_frame_unwind_init): Don't register deleted functions with
4502         gdbarch.
4503
4504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4505
4506         * mep-tdep.c (mep_unwind_pc): Delete.
4507         (mep_unwind_sp): Delete.
4508         (mep_dummy_id): Delete.
4509         (mep_gdbarch_init): Don't register deleted functions with
4510         gdbarch.
4511
4512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4515         (m68hc11_unwind_sp): Delete.
4516         (m68hc11_gdbarch_init): Don't register deleted functions with
4517         gdbarch.
4518
4519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * m32r-tdep.c (m32r_unwind_sp): Delete.
4522         (m32r_unwind_pc): Delete.
4523         (m32r_dummy_id): Delete.
4524         (m32r_gdbarch_init): Don't register deleted functions with
4525         gdbarch.
4526
4527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4528
4529         * m32c-tdep.c (m32c_unwind_pc): Delete.
4530         (m32c_unwind_sp): Delete.
4531         (m32c_dummy_id): Delete.
4532         (m32c_gdbarch_init): Don't register deleted functions with
4533         gdbarch.
4534
4535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4538         (lm32_unwind_pc): Delete.
4539         (lm32_dummy_id): Delete.
4540         (lm32_gdbarch_init): Don't register deleted functions with
4541         gdbarch.
4542
4543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4546         (iq2000_unwind_pc): Delete.
4547         (iq2000_dummy_id): Delete.
4548         (iq2000_gdbarch_init): Don't register deleted functions with
4549         gdbarch.
4550
4551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * nds32-tdep.c (nds32_type_align): Delete.
4554         (nds32_push_dummy_call): Use type_align instead.
4555
4556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * arm-tdep.c (arm_type_align): Only handle vector override case.
4559         (arm_push_dummy_call): Use type_align.
4560         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4561
4562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4565         case.
4566         (pass_on_stack): Use type_align.
4567         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4568         function.
4569
4570 2019-04-23  Tom Tromey  <tromey@adacore.com>
4571
4572         * dwarf2read.c (line_header::file_name_at): Remove unused
4573         overload.
4574
4575 2019-04-23  Tom de Vries  <tdevries@suse.de>
4576
4577         PR gdb/24438
4578         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4579         invocation.
4580
4581
4582 2019-03-27  Ali Tamur  <tamur@google.com>
4583
4584         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4585         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4586         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4587         (dwarf_expr_context::get_addr_index): Likewise
4588         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4589         (symbol_needs_eval_context::get_addr_index): Likewise
4590         (disassemble_dwarf_expression): Add DW_OP_addrx
4591         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4592         (read_cutu_die_from_dwo): Update comment
4593         (skip_one_die): Add DW_FORM_addrx
4594         (read_attribute_value): Likewise
4595         (var_decode_location): Add DW_OP_addrx
4596         (dwarf2_const_value_attr): Add DW_FORM_addrx
4597         (dump_die_shallow): Likewise
4598         (dwarf2_fetch_constant_bytes): Likewise
4599         (decode_locdesc): Add DW_OP_addrx
4600         (skip_form_bytes): Add DW_FORM_addrx
4601
4602 2019-04-22  Ali Tamur  <tamur@google.com>
4603
4604         * MAINTAINERS (Write After Approval): Add self.
4605
4606 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4607
4608         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4609         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4610         (open_symbol_file_object): Likewise.
4611         (svr4_default_sos): Add info parameter.
4612         (svr4_read_so_list): Likewise.
4613         (svr4_current_sos_direct): Adjust functions calls to pass down
4614         info.
4615         (svr4_current_sos_1): Add info parameter.
4616         (svr4_current_sos): Call get_svr4_info, pass info down to
4617         svr4_current_sos_1.
4618         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4619         get_svr4_info.
4620         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4621         get_svr4_info.
4622         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4623         to get_svr4_info.
4624         (probes_table_remove_objfile_probes): Likewise.
4625         (register_solib_event_probe): Add info parameter.
4626         (solist_update_incremental): Pass info parameter down to
4627         svr4_read_so_list.
4628         (disable_probes_interface): Add info parameter.
4629         (svr4_handle_solib_event): Pass current_program_space to
4630         get_svr4_info.  Adjust disable_probes_interface cleanup.
4631         (svr4_create_probe_breakpoints): Add info parameter, pass it
4632         down to register_solib_event_probe.
4633         (svr4_create_solib_event_breakpoints): Add info parameter,
4634         pass it down to svr4_create_probe_breakpoints.
4635         (enable_break): Pass info down to
4636         svr4_create_solib_event_breakpoints.
4637         (svr4_solib_create_inferior_hook): Pass current_program_space to
4638         get_svr4_info.
4639         (svr4_clear_solib): Likewise.
4640
4641 2019-04-22  Pedro Alves  <palves@redhat.com>
4642
4643         * solib-svr4.c (svr4_free_objfile_observer): New.
4644         (probe_and_action::objfile): New field.
4645         (probes_table_htab_remove_objfile_probes)
4646         (probes_table_remove_objfile_probes): New functions.
4647         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4648         in the new probe_and_action.  Don't store the probe in 'lookup'.
4649         (svr4_create_probe_breakpoints): Pass objfile to
4650         register_solib_event_probe.
4651         (_initialize_svr4_solib): Register a free_objfile observer.
4652
4653 2019-04-19  Tom Tromey  <tom@tromey.com>
4654
4655         * common/queue.h: Remove.
4656
4657 2019-04-19  Tom Tromey  <tom@tromey.com>
4658
4659         * event-loop.c: Don't include "common/queue.h".
4660
4661 2019-04-19  Tom Tromey  <tom@tromey.com>
4662
4663         * remote.c (remote_target): Use delete.
4664         * remote-notif.h: Include <list>, not "common/queue.h".
4665         (notif_client_p): Remove typedef.
4666         (remote_notif_state): Add constructor, destructor, initializer.
4667         <notif_queue>: Now a std::list.
4668         (remote_notif_state_xfree): Don't declare.
4669         * remote-notif.c (remote_notif_process, handle_notification)
4670         (remote_notif_state_allocate): Update.
4671         (~remote_notif_state): Rename from remote_notif_state_xfree.
4672
4673 2019-04-19  Tom Tromey  <tom@tromey.com>
4674
4675         * symfile.c (reread_symbols): Update.
4676         * objfiles.c (objfile_register_static_link)
4677         (objfile_lookup_static_link): Update
4678         (~objfile) Don't delete static_links.
4679         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4680
4681 2019-04-19  Tom Tromey  <tom@tromey.com>
4682
4683         * type-stack.h (struct type_stack) <insert>: Constify string.
4684         * type-stack.c (type_stack::insert): Constify string.
4685         * gdbtypes.h (lookup_template_type): Update.
4686         (address_space_name_to_int): Update.
4687         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4688         const.
4689         (lookup_template_type): Make name const.
4690         * c-exp.y: Update rules.
4691         (lex_one_token, classify_name, classify_inner_name)
4692         (c_print_token): Update.
4693         * p-exp.y: Update rules.
4694         (yylex): Update.
4695         * f-exp.y: Update rules.
4696         (yylex): Update.
4697         * d-exp.y: Update rules.
4698         (lex_one_token, classify_name, classify_inner_name): Update.
4699         * parse.c (write_dollar_variable, copy_name): Return std::string.
4700         * parser-defs.h (copy_name): Change return type.
4701         * m2-exp.y: Update rules.
4702         (yylex): Update.
4703         * go-exp.y (lex_one_token): Update.
4704         Update rules.
4705         (classify_unsafe_function, classify_packaged_name)
4706         (classify_name, yylex): Update.
4707
4708 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4709
4710         * configure.ac: add --enable-source-highlight switch.
4711         * configure: Regenerate.
4712         * top.c (print_gdb_version): plumb --enable-source-highlight
4713         status to "show configuration".
4714
4715 2019-04-19  Tom Tromey  <tromey@adacore.com>
4716
4717         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4718         Check ADA_TYPE_P.
4719         (empty_record, ada_template_to_fixed_record_type_1)
4720         (template_to_static_fixed_type)
4721         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4722         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4723         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4724         macros.
4725
4726 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4727
4728         PR symtab/24423:
4729         * source.c (print_source_lines_base): Advance "iter" when a
4730         control character is seen.
4731
4732 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4733
4734         * inferior.h (struct infcall_suspend_state_deleter):
4735         Catch exception in destructor to avoid crash.
4736
4737 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4738
4739         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4740         close to the add_com "shell".
4741
4742 2019-04-18  Tom Tromey  <tromey@adacore.com>
4743
4744         * process-stratum-target.h (class process_stratum_target)
4745         <stratum>: Add "final".
4746
4747 2019-04-17  Tom Tromey  <tromey@adacore.com>
4748
4749         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4750         against nullptr before use.
4751
4752 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4753
4754         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4755
4756 2019-04-17  Jim Wilson  <jimw@sifive.com>
4757             Andrew Burgess  <andrew.burgess@embecosm.com>
4758
4759         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4760         code read might fail, assume 4-byte breakpoint in that case.
4761
4762 2019-04-15  Leszek Swirski  <leszeks@google.com>
4763
4764         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4765         rather than a hand-rolled POD check when checking for forced MEMORY
4766         classification.
4767
4768 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4769
4770         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4771         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4772         function.
4773         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4774         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4775         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4776         declaration.
4777
4778 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4779
4780         * aarch64-linux-nat.c
4781         (aarch64_linux_nat_target::thread_architecture): Add override.
4782         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4783         each VQ.
4784
4785 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4786
4787         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4788
4789 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4792         target types of size 96-bits, add some additional comments, and
4793         check that the builtin type we found was the correct size.
4794
4795 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4796
4797         * utils.c (prompt_for_continue): Don't restore the styling at the
4798         end, as applied_style has the wrong value.  This fixes styling in
4799         long lists of file names that are interrupted by the "Continue?"
4800         prompt.
4801
4802 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4805         * c-lang.c (c_language_defn): Likewise.
4806         (cplus_language_defn): Likewise.
4807         (asm_language_defn): Likewise.
4808         (minimal_language_defn): Likewise.
4809         * d-lang.c (d_language_defn): Likewise.
4810         * f-lang.c (f_language_defn): Likewise.
4811         * go-lang.c (go_language_defn): Likewise.
4812         * language.c (unknown_language_defn): Likewise.
4813         (auto_language_defn): Likewise.
4814         * language.h (struct language_defn): Remove la_magic field.
4815         (LANG_MAGIC): Delete.
4816         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4817         * objc-lang.c (objc_language_defn): Likewise.
4818         * opencl-lang.c (opencl_language_defn): Likewise.
4819         * p-lang.c (pascal_language_defn): Likewise.
4820         * rust-lang.c (rust_language_defn): Likewise.
4821
4822 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * riscv-tdep.c (riscv_type_align): New function.
4825         (riscv_type_alignment): Delete.
4826         (riscv_arg_location): Use 'type_align'.
4827         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4828
4829 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * gdbtypes.c (type_align): A struct with no non-static fields also
4832         has alignment of 1.
4833
4834 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4837         component to 0.
4838         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4839         member.
4840         (riscv_struct_info::analyse): New implementation using new
4841         analyse_inner member function.
4842         (riscv_struct_info::field_offset): New member function.
4843         (riscv_struct_info::m_offsets): New member variable.
4844         (riscv_struct_info::analyse_inner): New private member function,
4845         takes the old implementation of riscv_struct_info::analyse but
4846         extended to track field offsets.
4847         (riscv_call_arg_struct): Update the struct folding special cases
4848         to handle cases where empty C++ structs, which are non-zero
4849         length, are found.
4850         (riscv_arg_location): Initialise the length of each location, a
4851         non-zero length now indicates the location is in use.
4852         (riscv_push_dummy_call): Allow for the first location having a
4853         non-zero offset when setting up arguments.
4854         (riscv_return_value): Likewise, but for return values.
4855
4856 2019-04-11  Tom Tromey  <tromey@adacore.com>
4857
4858         * utils.c (internal_vproblem): Make "msg" const.
4859
4860 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4861
4862         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4863         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4864         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4865         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4866
4867 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4868
4869         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4870         function.
4871         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4872         of amd64_collect_native_gregset.
4873         (amd64_linux_nat_target::store_registers): Likewise.
4874
4875 2019-04-10  Tom Tromey  <tom@tromey.com>
4876
4877         * symtab.c (lookup_global_symbol_from_objfile)
4878         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4879         * objfiles.h (class separate_debug_iterator): New.
4880         (class separate_debug_range): New.
4881         (struct objfile) <separate_debug_objfiles>: New method.
4882         (objfile_separate_debug_iterate): Don't declare.
4883         * objfiles.c (separate_debug_iterator::operator++): Rename from
4884         objfile_separate_debug_iterate.
4885         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4886         iterator.
4887         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4888         iterator.
4889
4890 2019-04-10  Tom Tromey  <tom@tromey.com>
4891
4892         * symfile.c (reread_symbols): Remove old comment.
4893         * objfiles.c (free_all_objfiles): Fix a typo.
4894
4895 2019-04-10  Tom Tromey  <tom@tromey.com>
4896
4897         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4898         * minsyms.c (lookup_minimal_symbol): Use foreach.
4899         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4900         (lookup_minimal_symbol_solib_trampoline): Likewise.
4901         * symfile.c (reread_symbols): Use foreach.
4902
4903 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4904             Tom Tromey  <tromey@adacore.com>
4905
4906         PR rust/24414:
4907         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4908         (rust_lex_int_test): Change "value" to be LONGEST.
4909         (rust_lex_tests): Add test for long integer literal.
4910
4911 2019-04-09  Tom Tromey  <tromey@adacore.com>
4912
4913         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4914         to bool.
4915         (extended_remote_target::attach): Update.
4916         (remote_target::remote_notice_new_inferior): Update.
4917         (remote_target::add_current_inferior_and_thread): Update.
4918         * inferior.c (exit_inferior_1): Use "false".
4919         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4920
4921 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4922
4923         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4924         the "start" command.
4925
4926 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4927
4928         * python/py-inferior.c (infpy_thread_from_thread_handle):
4929         Adjust comments to reflect renaming of thread_from_thread_handle
4930         to thread_from_handle.  Adjust keywords.  Fix type error message.
4931         (inferior_object_methods): Add thread_from_handle.  Retain
4932         thread_from_thread_handle, but mark it as deprecated.
4933
4934 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4935
4936         * gdbthread.h (find_thread_by_handle): Revise declaration.
4937         * thread.c (find_thread_by_handle): Likewise.  Adjust
4938         implementation too.
4939         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4940         support for buffer objects as handles.
4941
4942 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4943
4944         * python/py-infthread.c (thpy_thread_handle): New function.
4945         (thread_object_methods): Register thpy_thread_handle.
4946
4947 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4948
4949         * gdbthread.h (thread_to_thread_handle): Declare.
4950         * thread.c (gdbtypes.h): Include.
4951         (thread_to_thread_handle): New function.
4952
4953         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4954         (target_thread_info_to_thread_handle): Declare.
4955         * target.c (target_thread_info_to_thread_handle): New function.
4956         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4957         * target-delegates.c: Regenerate.
4958
4959         * linux-thread-db.c (class thread_db_target): Add method
4960         thread_info_to_thread_handle.
4961         (thread_db_target::thread_info_to_thread_handle): Define.
4962         * remote.c (class remote_target): Add new method
4963         thread_info_to_thread_handle.
4964         (remote_target::thread_info_to_thread_handle): Define.
4965
4966 2019-04-08  Pedro Alves  <palves@redhat.com>
4967
4968         * common/common-exceptions.c (throw_exception): Don't create
4969         named object to throw; throw directly.
4970         (throw_it): Likewise.  Don't initialize gdb_exception::message
4971         here, with new; pass FMT and AP to the ctor instead.
4972         * common/common-exceptions.h: Include <string>.
4973         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4974         const char *, va_list)): New ctor.  Use std::make_shared.
4975         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4976         errors)): Delete.
4977         (gdb_exception_error::gdb_exception_error(enum errors, const char
4978         *, va_list)): New.
4979         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4980         Add assertion.
4981         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4982         errors)): Delete.
4983         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4984         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4985         Add assertion.
4986
4987 2019-04-08  Tom Tromey  <tom@tromey.com>
4988
4989         * valops.c (value_rtti_indirect_type): Replace throw_exception
4990         with throw.
4991         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4992         with throw.
4993         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4994         throw.
4995         * target.c (target_translate_tls_address): Replace throw_exception
4996         with throw.
4997         * stack.c (frame_apply_command_count): Replace throw_exception
4998         with throw.
4999         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5000         throw.
5001         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5002         with throw.
5003         * rs6000-tdep.c (rs6000_frame_cache)
5004         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5005         * remote.c: Replace throw_exception with throw.
5006         * record-full.c (record_full_message, record_full_wait_1)
5007         (record_full_restore): Replace throw_exception with throw.
5008         * record-btrace.c:
5009         (get_thread_current_frame_id, record_btrace_start_replaying)
5010         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5011         (cmd_record_btrace_start): Replace throw_exception with throw.
5012         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5013         throw.
5014         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5015         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5016         * linespec.c:
5017         (find_linespec_symbols): Replace throw_exception with throw.
5018         * infrun.c (displaced_step_prepare, resume): Replace
5019         throw_exception with throw.
5020         * infcmd.c (post_create_inferior): Replace throw_exception with
5021         throw.
5022         * inf-loop.c (inferior_event_handler): Replace throw_exception
5023         with throw.
5024         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5025         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5026         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5027         (get_prev_frame_always, get_frame_pc_if_available)
5028         (get_frame_address_in_block_if_available, get_frame_language):
5029         Replace throw_exception with throw.
5030         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5031         throw_exception with throw.
5032         * eval.c (fetch_subexp_value, evaluate_var_value)
5033         (evaluate_funcall, evaluate_subexp_standard): Replace
5034         throw_exception with throw.
5035         * dwarf2loc.c (call_site_find_chain)
5036         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5037         Replace throw_exception with throw.
5038         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5039         with throw.
5040         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5041         throw.
5042         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5043         * completer.c (complete_line_internal): Replace throw_exception
5044         with throw.
5045         * compile/compile-object-run.c (compile_object_run): Replace
5046         throw_exception with throw.
5047         * cli/cli-script.c (process_next_line): Replace throw_exception
5048         with throw.
5049         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5050         (btrace_enable, btrace_maint_update_pt_packets): Replace
5051         throw_exception with throw.
5052         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5053         throw_exception with throw.
5054         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5055         throw_exception with throw.
5056         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5057         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5058         * aarch64-tdep.c (aarch64_make_prologue_cache)
5059         (aarch64_make_stub_cache): Replace throw_exception with throw.
5060
5061 2019-04-08  Tom Tromey  <tom@tromey.com>
5062
5063         * common/common-exceptions.c (throw_exception): Rename from
5064         throw_exception_cxx.  Remove old copy.  Make argument const.
5065         (throw_it): Create and throw exception objects directly.
5066         * common/common-exceptions.h (throw_exception): Make argument
5067         const.
5068         (struct gdb_exception_error): Add constructor.
5069         (struct gdb_exception_quit): Add constructor.
5070
5071 2019-04-08  Tom Tromey  <tom@tromey.com>
5072
5073         * common/common-exceptions.h (exception_rethrow): Don't declare.
5074         (TRY_SJLJ): Update comment.
5075         (TRY, CATCH, END_CATCH): Remove.
5076         * common/common-exceptions.c (exception_rethrow): Remove.
5077
5078 2019-04-08  Tom Tromey  <tom@tromey.com>
5079
5080         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5081         Remove.
5082         (gdb_exception_error): Rename from
5083         gdb_exception_RETURN_MASK_ERROR.
5084         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5085         (gdb_quit_bad_alloc): Update.
5086         * aarch64-tdep.c: Update.
5087         * ada-lang.c: Update.
5088         * ada-typeprint.c: Update.
5089         * ada-valprint.c: Update.
5090         * amd64-tdep.c: Update.
5091         * arch-utils.c: Update.
5092         * break-catch-throw.c: Update.
5093         * breakpoint.c: Update.
5094         * btrace.c: Update.
5095         * c-varobj.c: Update.
5096         * cli/cli-cmds.c: Update.
5097         * cli/cli-interp.c: Update.
5098         * cli/cli-script.c: Update.
5099         * common/common-exceptions.c: Update.
5100         * common/new-op.c: Update.
5101         * common/selftest.c: Update.
5102         * compile/compile-c-symbols.c: Update.
5103         * compile/compile-cplus-symbols.c: Update.
5104         * compile/compile-object-load.c: Update.
5105         * compile/compile-object-run.c: Update.
5106         * completer.c: Update.
5107         * corelow.c: Update.
5108         * cp-abi.c: Update.
5109         * cp-support.c: Update.
5110         * cp-valprint.c: Update.
5111         * darwin-nat.c: Update.
5112         * disasm-selftests.c: Update.
5113         * dtrace-probe.c: Update.
5114         * dwarf-index-cache.c: Update.
5115         * dwarf-index-write.c: Update.
5116         * dwarf2-frame-tailcall.c: Update.
5117         * dwarf2-frame.c: Update.
5118         * dwarf2loc.c: Update.
5119         * dwarf2read.c: Update.
5120         * eval.c: Update.
5121         * event-loop.c: Update.
5122         * event-top.c: Update.
5123         * exec.c: Update.
5124         * f-valprint.c: Update.
5125         * fbsd-tdep.c: Update.
5126         * frame-unwind.c: Update.
5127         * frame.c: Update.
5128         * gdbtypes.c: Update.
5129         * gnu-v3-abi.c: Update.
5130         * guile/guile-internal.h: Update.
5131         * guile/scm-block.c: Update.
5132         * guile/scm-breakpoint.c: Update.
5133         * guile/scm-cmd.c: Update.
5134         * guile/scm-disasm.c: Update.
5135         * guile/scm-frame.c: Update.
5136         * guile/scm-lazy-string.c: Update.
5137         * guile/scm-math.c: Update.
5138         * guile/scm-param.c: Update.
5139         * guile/scm-ports.c: Update.
5140         * guile/scm-pretty-print.c: Update.
5141         * guile/scm-symbol.c: Update.
5142         * guile/scm-symtab.c: Update.
5143         * guile/scm-type.c: Update.
5144         * guile/scm-value.c: Update.
5145         * i386-linux-tdep.c: Update.
5146         * i386-tdep.c: Update.
5147         * inf-loop.c: Update.
5148         * infcall.c: Update.
5149         * infcmd.c: Update.
5150         * infrun.c: Update.
5151         * jit.c: Update.
5152         * language.c: Update.
5153         * linespec.c: Update.
5154         * linux-fork.c: Update.
5155         * linux-nat.c: Update.
5156         * linux-tdep.c: Update.
5157         * linux-thread-db.c: Update.
5158         * main.c: Update.
5159         * mi/mi-cmd-break.c: Update.
5160         * mi/mi-cmd-stack.c: Update.
5161         * mi/mi-interp.c: Update.
5162         * mi/mi-main.c: Update.
5163         * objc-lang.c: Update.
5164         * p-valprint.c: Update.
5165         * parse.c: Update.
5166         * ppc-linux-tdep.c: Update.
5167         * printcmd.c: Update.
5168         * python/py-arch.c: Update.
5169         * python/py-breakpoint.c: Update.
5170         * python/py-cmd.c: Update.
5171         * python/py-finishbreakpoint.c: Update.
5172         * python/py-frame.c: Update.
5173         * python/py-framefilter.c: Update.
5174         * python/py-gdb-readline.c: Update.
5175         * python/py-inferior.c: Update.
5176         * python/py-infthread.c: Update.
5177         * python/py-lazy-string.c: Update.
5178         * python/py-linetable.c: Update.
5179         * python/py-objfile.c: Update.
5180         * python/py-param.c: Update.
5181         * python/py-prettyprint.c: Update.
5182         * python/py-progspace.c: Update.
5183         * python/py-record-btrace.c: Update.
5184         * python/py-record.c: Update.
5185         * python/py-symbol.c: Update.
5186         * python/py-type.c: Update.
5187         * python/py-unwind.c: Update.
5188         * python/py-utils.c: Update.
5189         * python/py-value.c: Update.
5190         * python/python.c: Update.
5191         * record-btrace.c: Update.
5192         * record-full.c: Update.
5193         * remote-fileio.c: Update.
5194         * remote.c: Update.
5195         * riscv-tdep.c: Update.
5196         * rs6000-aix-tdep.c: Update.
5197         * rs6000-tdep.c: Update.
5198         * rust-exp.y: Update.
5199         * rust-lang.c: Update.
5200         * s390-tdep.c: Update.
5201         * selftest-arch.c: Update.
5202         * solib-dsbt.c: Update.
5203         * solib-frv.c: Update.
5204         * solib-spu.c: Update.
5205         * solib-svr4.c: Update.
5206         * solib.c: Update.
5207         * sparc64-linux-tdep.c: Update.
5208         * stack.c: Update.
5209         * symfile-mem.c: Update.
5210         * symmisc.c: Update.
5211         * target.c: Update.
5212         * thread.c: Update.
5213         * top.c: Update.
5214         * tracefile-tfile.c: Update.
5215         * tui/tui.c: Update.
5216         * typeprint.c: Update.
5217         * unittests/cli-utils-selftests.c: Update.
5218         * unittests/parse-connection-spec-selftests.c: Update.
5219         * valops.c: Update.
5220         * valprint.c: Update.
5221         * value.c: Update.
5222         * varobj.c: Update.
5223         * windows-nat.c: Update.
5224         * x86-linux-nat.c: Update.
5225         * xml-support.c: Update.
5226
5227 2019-04-08  Tom Tromey  <tom@tromey.com>
5228
5229         * xml-support.c: Use C++ exception handling.
5230         * x86-linux-nat.c: Use C++ exception handling.
5231         * windows-nat.c: Use C++ exception handling.
5232         * varobj.c: Use C++ exception handling.
5233         * value.c: Use C++ exception handling.
5234         * valprint.c: Use C++ exception handling.
5235         * valops.c: Use C++ exception handling.
5236         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5237         handling.
5238         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5239         * typeprint.c: Use C++ exception handling.
5240         * tui/tui.c: Use C++ exception handling.
5241         * tracefile-tfile.c: Use C++ exception handling.
5242         * top.c: Use C++ exception handling.
5243         * thread.c: Use C++ exception handling.
5244         * target.c: Use C++ exception handling.
5245         * symmisc.c: Use C++ exception handling.
5246         * symfile-mem.c: Use C++ exception handling.
5247         * stack.c: Use C++ exception handling.
5248         * sparc64-linux-tdep.c: Use C++ exception handling.
5249         * solib.c: Use C++ exception handling.
5250         * solib-svr4.c: Use C++ exception handling.
5251         * solib-spu.c: Use C++ exception handling.
5252         * solib-frv.c: Use C++ exception handling.
5253         * solib-dsbt.c: Use C++ exception handling.
5254         * selftest-arch.c: Use C++ exception handling.
5255         * s390-tdep.c: Use C++ exception handling.
5256         * rust-lang.c: Use C++ exception handling.
5257         * rust-exp.y: Use C++ exception handling.
5258         * rs6000-tdep.c: Use C++ exception handling.
5259         * rs6000-aix-tdep.c: Use C++ exception handling.
5260         * riscv-tdep.c: Use C++ exception handling.
5261         * remote.c: Use C++ exception handling.
5262         * remote-fileio.c: Use C++ exception handling.
5263         * record-full.c: Use C++ exception handling.
5264         * record-btrace.c: Use C++ exception handling.
5265         * python/python.c: Use C++ exception handling.
5266         * python/py-value.c: Use C++ exception handling.
5267         * python/py-utils.c: Use C++ exception handling.
5268         * python/py-unwind.c: Use C++ exception handling.
5269         * python/py-type.c: Use C++ exception handling.
5270         * python/py-symbol.c: Use C++ exception handling.
5271         * python/py-record.c: Use C++ exception handling.
5272         * python/py-record-btrace.c: Use C++ exception handling.
5273         * python/py-progspace.c: Use C++ exception handling.
5274         * python/py-prettyprint.c: Use C++ exception handling.
5275         * python/py-param.c: Use C++ exception handling.
5276         * python/py-objfile.c: Use C++ exception handling.
5277         * python/py-linetable.c: Use C++ exception handling.
5278         * python/py-lazy-string.c: Use C++ exception handling.
5279         * python/py-infthread.c: Use C++ exception handling.
5280         * python/py-inferior.c: Use C++ exception handling.
5281         * python/py-gdb-readline.c: Use C++ exception handling.
5282         * python/py-framefilter.c: Use C++ exception handling.
5283         * python/py-frame.c: Use C++ exception handling.
5284         * python/py-finishbreakpoint.c: Use C++ exception handling.
5285         * python/py-cmd.c: Use C++ exception handling.
5286         * python/py-breakpoint.c: Use C++ exception handling.
5287         * python/py-arch.c: Use C++ exception handling.
5288         * printcmd.c: Use C++ exception handling.
5289         * ppc-linux-tdep.c: Use C++ exception handling.
5290         * parse.c: Use C++ exception handling.
5291         * p-valprint.c: Use C++ exception handling.
5292         * objc-lang.c: Use C++ exception handling.
5293         * mi/mi-main.c: Use C++ exception handling.
5294         * mi/mi-interp.c: Use C++ exception handling.
5295         * mi/mi-cmd-stack.c: Use C++ exception handling.
5296         * mi/mi-cmd-break.c: Use C++ exception handling.
5297         * main.c: Use C++ exception handling.
5298         * linux-thread-db.c: Use C++ exception handling.
5299         * linux-tdep.c: Use C++ exception handling.
5300         * linux-nat.c: Use C++ exception handling.
5301         * linux-fork.c: Use C++ exception handling.
5302         * linespec.c: Use C++ exception handling.
5303         * language.c: Use C++ exception handling.
5304         * jit.c: Use C++ exception handling.
5305         * infrun.c: Use C++ exception handling.
5306         * infcmd.c: Use C++ exception handling.
5307         * infcall.c: Use C++ exception handling.
5308         * inf-loop.c: Use C++ exception handling.
5309         * i386-tdep.c: Use C++ exception handling.
5310         * i386-linux-tdep.c: Use C++ exception handling.
5311         * guile/scm-value.c: Use C++ exception handling.
5312         * guile/scm-type.c: Use C++ exception handling.
5313         * guile/scm-symtab.c: Use C++ exception handling.
5314         * guile/scm-symbol.c: Use C++ exception handling.
5315         * guile/scm-pretty-print.c: Use C++ exception handling.
5316         * guile/scm-ports.c: Use C++ exception handling.
5317         * guile/scm-param.c: Use C++ exception handling.
5318         * guile/scm-math.c: Use C++ exception handling.
5319         * guile/scm-lazy-string.c: Use C++ exception handling.
5320         * guile/scm-frame.c: Use C++ exception handling.
5321         * guile/scm-disasm.c: Use C++ exception handling.
5322         * guile/scm-cmd.c: Use C++ exception handling.
5323         * guile/scm-breakpoint.c: Use C++ exception handling.
5324         * guile/scm-block.c: Use C++ exception handling.
5325         * guile/guile-internal.h: Use C++ exception handling.
5326         * gnu-v3-abi.c: Use C++ exception handling.
5327         * gdbtypes.c: Use C++ exception handling.
5328         * frame.c: Use C++ exception handling.
5329         * frame-unwind.c: Use C++ exception handling.
5330         * fbsd-tdep.c: Use C++ exception handling.
5331         * f-valprint.c: Use C++ exception handling.
5332         * exec.c: Use C++ exception handling.
5333         * event-top.c: Use C++ exception handling.
5334         * event-loop.c: Use C++ exception handling.
5335         * eval.c: Use C++ exception handling.
5336         * dwarf2read.c: Use C++ exception handling.
5337         * dwarf2loc.c: Use C++ exception handling.
5338         * dwarf2-frame.c: Use C++ exception handling.
5339         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5340         * dwarf-index-write.c: Use C++ exception handling.
5341         * dwarf-index-cache.c: Use C++ exception handling.
5342         * dtrace-probe.c: Use C++ exception handling.
5343         * disasm-selftests.c: Use C++ exception handling.
5344         * darwin-nat.c: Use C++ exception handling.
5345         * cp-valprint.c: Use C++ exception handling.
5346         * cp-support.c: Use C++ exception handling.
5347         * cp-abi.c: Use C++ exception handling.
5348         * corelow.c: Use C++ exception handling.
5349         * completer.c: Use C++ exception handling.
5350         * compile/compile-object-run.c: Use C++ exception handling.
5351         * compile/compile-object-load.c: Use C++ exception handling.
5352         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5353         * compile/compile-c-symbols.c: Use C++ exception handling.
5354         * common/selftest.c: Use C++ exception handling.
5355         * common/new-op.c: Use C++ exception handling.
5356         * cli/cli-script.c: Use C++ exception handling.
5357         * cli/cli-interp.c: Use C++ exception handling.
5358         * cli/cli-cmds.c: Use C++ exception handling.
5359         * c-varobj.c: Use C++ exception handling.
5360         * btrace.c: Use C++ exception handling.
5361         * breakpoint.c: Use C++ exception handling.
5362         * break-catch-throw.c: Use C++ exception handling.
5363         * arch-utils.c: Use C++ exception handling.
5364         * amd64-tdep.c: Use C++ exception handling.
5365         * ada-valprint.c: Use C++ exception handling.
5366         * ada-typeprint.c: Use C++ exception handling.
5367         * ada-lang.c: Use C++ exception handling.
5368         * aarch64-tdep.c: Use C++ exception handling.
5369
5370 2019-04-08  Tom Tromey  <tom@tromey.com>
5371
5372         * xml-support.c (gdb_xml_parser::parse): Update.
5373         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5374         * value.c (show_convenience): Update.
5375         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5376         (test_parse_flags_qcs): Update.
5377         * thread.c (thr_try_catch_cmd): Update.
5378         * target.c (target_translate_tls_address): Update.
5379         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5380         (info_frame_command_core, frame_apply_command_count): Update.
5381         * rust-exp.y (rust_lex_exception_test): Update.
5382         * riscv-tdep.c (riscv_print_one_register_info): Update.
5383         * remote.c (remote_target::enable_btrace): Update.
5384         * record-btrace.c (record_btrace_enable_warn): Update.
5385         * python/py-utils.c (gdbpy_convert_exception): Update.
5386         * printcmd.c (do_one_display, print_variable_and_value): Update.
5387         * mi/mi-main.c (mi_print_exception): Update.
5388         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5389         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5390         * linux-nat.c (linux_nat_target::attach): Update.
5391         * linux-fork.c (class scoped_switch_fork_info): Update.
5392         * infrun.c (displaced_step_prepare): Update.
5393         * infcall.c (call_function_by_hand_dummy): Update.
5394         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5395         * gnu-v3-abi.c (print_one_vtable): Update.
5396         * frame.c (get_prev_frame_always): Update.
5397         * f-valprint.c (info_common_command_for_block): Update.
5398         * exec.c (try_open_exec_file): Update.
5399         * exceptions.c (print_exception, exception_print)
5400         (exception_fprintf, exception_print_same): Update.
5401         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5402         * dwarf-index-cache.c (index_cache::store)
5403         (index_cache::lookup_gdb_index): Update.
5404         * darwin-nat.c (maybe_cache_shell): Update.
5405         * cp-valprint.c (cp_print_value_fields): Update.
5406         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5407         (gcc_cplus_symbol_address): Update.
5408         * compile/compile-c-symbols.c (gcc_convert_symbol)
5409         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5410         * common/selftest.c: Update.
5411         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5412         a std::string.
5413         (exception_try_scope_entry, exception_try_scope_exit): Don't
5414         declare.
5415         (struct exception_try_scope): Remove.
5416         (TRY): Don't use exception_try_scope.
5417         (struct gdb_exception): Add constructor, operator=.
5418         <what>: New method.
5419         (struct gdb_exception_RETURN_MASK_ALL)
5420         (struct gdb_exception_RETURN_MASK_ERROR)
5421         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5422         (struct gdb_quit_bad_alloc): Update.
5423         * common/common-exceptions.c (exception_none): Change
5424         initializer.
5425         (struct catcher) <state, exception>: Initialize inline.
5426         <prev>: Remove member.
5427         (current_catcher): Remove.
5428         (catchers): New global.
5429         (exceptions_state_mc_init): Simplify.
5430         (catcher_pop): Remove.
5431         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5432         (try_scope_depth, exception_try_scope_entry)
5433         (exception_try_scope_exit): Remove.
5434         (throw_exception_sjlj): Update.
5435         (exception_messages, exception_messages_size): Remove.
5436         (throw_it): Simplify.
5437         (gdb_exception_sliced_copy): Remove.
5438         (throw_exception_cxx): Update.
5439         * cli/cli-script.c (script_from_file): Update.
5440         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5441         Update.
5442         * ada-valprint.c (ada_val_print): Update.
5443         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5444         (create_excep_cond_exprs): Update.
5445
5446 2019-04-08  Tom Tromey  <tom@tromey.com>
5447
5448         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5449         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5450         (TRY, CATCH, END_CATCH): Remove some definitions.
5451         * common/common-exceptions.c: Don't use GDB_XCPT.
5452         (catcher_list_size): Remove.
5453         (throw_exception, throw_it): Simplify.
5454
5455 2019-04-05  Tom Tromey  <tom@tromey.com>
5456
5457         Revert the header-sorting patch.
5458         * ft32-tdep.c: Revert.
5459         * frv-tdep.c: Revert.
5460         * frv-linux-tdep.c: Revert.
5461         * frame.c: Revert.
5462         * frame-unwind.c: Revert.
5463         * frame-base.c: Revert.
5464         * fork-child.c: Revert.
5465         * findvar.c: Revert.
5466         * findcmd.c: Revert.
5467         * filesystem.c: Revert.
5468         * filename-seen-cache.h: Revert.
5469         * filename-seen-cache.c: Revert.
5470         * fbsd-tdep.c: Revert.
5471         * fbsd-nat.h: Revert.
5472         * fbsd-nat.c: Revert.
5473         * f-valprint.c: Revert.
5474         * f-typeprint.c: Revert.
5475         * f-lang.c: Revert.
5476         * extension.h: Revert.
5477         * extension.c: Revert.
5478         * extension-priv.h: Revert.
5479         * expprint.c: Revert.
5480         * exec.h: Revert.
5481         * exec.c: Revert.
5482         * exceptions.c: Revert.
5483         * event-top.c: Revert.
5484         * event-loop.c: Revert.
5485         * eval.c: Revert.
5486         * elfread.c: Revert.
5487         * dwarf2read.h: Revert.
5488         * dwarf2read.c: Revert.
5489         * dwarf2loc.c: Revert.
5490         * dwarf2expr.h: Revert.
5491         * dwarf2expr.c: Revert.
5492         * dwarf2-frame.c: Revert.
5493         * dwarf2-frame-tailcall.c: Revert.
5494         * dwarf-index-write.h: Revert.
5495         * dwarf-index-write.c: Revert.
5496         * dwarf-index-common.c: Revert.
5497         * dwarf-index-cache.h: Revert.
5498         * dwarf-index-cache.c: Revert.
5499         * dummy-frame.c: Revert.
5500         * dtrace-probe.c: Revert.
5501         * disasm.h: Revert.
5502         * disasm.c: Revert.
5503         * disasm-selftests.c: Revert.
5504         * dictionary.c: Revert.
5505         * dicos-tdep.c: Revert.
5506         * demangle.c: Revert.
5507         * dcache.h: Revert.
5508         * dcache.c: Revert.
5509         * darwin-nat.h: Revert.
5510         * darwin-nat.c: Revert.
5511         * darwin-nat-info.c: Revert.
5512         * d-valprint.c: Revert.
5513         * d-namespace.c: Revert.
5514         * d-lang.c: Revert.
5515         * ctf.c: Revert.
5516         * csky-tdep.c: Revert.
5517         * csky-linux-tdep.c: Revert.
5518         * cris-tdep.c: Revert.
5519         * cris-linux-tdep.c: Revert.
5520         * cp-valprint.c: Revert.
5521         * cp-support.c: Revert.
5522         * cp-namespace.c: Revert.
5523         * cp-abi.c: Revert.
5524         * corelow.c: Revert.
5525         * corefile.c: Revert.
5526         * continuations.c: Revert.
5527         * completer.h: Revert.
5528         * completer.c: Revert.
5529         * complaints.c: Revert.
5530         * coffread.c: Revert.
5531         * coff-pe-read.c: Revert.
5532         * cli-out.h: Revert.
5533         * cli-out.c: Revert.
5534         * charset.c: Revert.
5535         * c-varobj.c: Revert.
5536         * c-valprint.c: Revert.
5537         * c-typeprint.c: Revert.
5538         * c-lang.c: Revert.
5539         * buildsym.c: Revert.
5540         * buildsym-legacy.c: Revert.
5541         * build-id.h: Revert.
5542         * build-id.c: Revert.
5543         * btrace.c: Revert.
5544         * bsd-uthread.c: Revert.
5545         * breakpoint.h: Revert.
5546         * breakpoint.c: Revert.
5547         * break-catch-throw.c: Revert.
5548         * break-catch-syscall.c: Revert.
5549         * break-catch-sig.c: Revert.
5550         * blockframe.c: Revert.
5551         * block.c: Revert.
5552         * bfin-tdep.c: Revert.
5553         * bfin-linux-tdep.c: Revert.
5554         * bfd-target.c: Revert.
5555         * bcache.c: Revert.
5556         * ax-general.c: Revert.
5557         * ax-gdb.h: Revert.
5558         * ax-gdb.c: Revert.
5559         * avr-tdep.c: Revert.
5560         * auxv.c: Revert.
5561         * auto-load.c: Revert.
5562         * arm-wince-tdep.c: Revert.
5563         * arm-tdep.c: Revert.
5564         * arm-symbian-tdep.c: Revert.
5565         * arm-pikeos-tdep.c: Revert.
5566         * arm-obsd-tdep.c: Revert.
5567         * arm-nbsd-tdep.c: Revert.
5568         * arm-nbsd-nat.c: Revert.
5569         * arm-linux-tdep.c: Revert.
5570         * arm-linux-nat.c: Revert.
5571         * arm-fbsd-tdep.c: Revert.
5572         * arm-fbsd-nat.c: Revert.
5573         * arm-bsd-tdep.c: Revert.
5574         * arch-utils.c: Revert.
5575         * arc-tdep.c: Revert.
5576         * arc-newlib-tdep.c: Revert.
5577         * annotate.h: Revert.
5578         * annotate.c: Revert.
5579         * amd64-windows-tdep.c: Revert.
5580         * amd64-windows-nat.c: Revert.
5581         * amd64-tdep.c: Revert.
5582         * amd64-sol2-tdep.c: Revert.
5583         * amd64-obsd-tdep.c: Revert.
5584         * amd64-obsd-nat.c: Revert.
5585         * amd64-nbsd-tdep.c: Revert.
5586         * amd64-nbsd-nat.c: Revert.
5587         * amd64-nat.c: Revert.
5588         * amd64-linux-tdep.c: Revert.
5589         * amd64-linux-nat.c: Revert.
5590         * amd64-fbsd-tdep.c: Revert.
5591         * amd64-fbsd-nat.c: Revert.
5592         * amd64-dicos-tdep.c: Revert.
5593         * amd64-darwin-tdep.c: Revert.
5594         * amd64-bsd-nat.c: Revert.
5595         * alpha-tdep.c: Revert.
5596         * alpha-obsd-tdep.c: Revert.
5597         * alpha-nbsd-tdep.c: Revert.
5598         * alpha-mdebug-tdep.c: Revert.
5599         * alpha-linux-tdep.c: Revert.
5600         * alpha-linux-nat.c: Revert.
5601         * alpha-bsd-tdep.c: Revert.
5602         * alpha-bsd-nat.c: Revert.
5603         * aix-thread.c: Revert.
5604         * agent.c: Revert.
5605         * addrmap.c: Revert.
5606         * ada-varobj.c: Revert.
5607         * ada-valprint.c: Revert.
5608         * ada-typeprint.c: Revert.
5609         * ada-tasks.c: Revert.
5610         * ada-lang.c: Revert.
5611         * aarch64-tdep.c: Revert.
5612         * aarch64-ravenscar-thread.c: Revert.
5613         * aarch64-newlib-tdep.c: Revert.
5614         * aarch64-linux-tdep.c: Revert.
5615         * aarch64-linux-nat.c: Revert.
5616         * aarch64-fbsd-tdep.c: Revert.
5617         * aarch64-fbsd-nat.c: Revert.
5618         * aarch32-linux-nat.c: Revert.
5619
5620 2019-04-05  Tom Tromey  <tom@tromey.com>
5621
5622         * ft32-tdep.c: Sort headers.
5623         * frv-tdep.c: Sort headers.
5624         * frv-linux-tdep.c: Sort headers.
5625         * frame.c: Sort headers.
5626         * frame-unwind.c: Sort headers.
5627         * frame-base.c: Sort headers.
5628         * fork-child.c: Sort headers.
5629         * findvar.c: Sort headers.
5630         * findcmd.c: Sort headers.
5631         * filesystem.c: Sort headers.
5632         * filename-seen-cache.h: Sort headers.
5633         * filename-seen-cache.c: Sort headers.
5634         * fbsd-tdep.c: Sort headers.
5635         * fbsd-nat.h: Sort headers.
5636         * fbsd-nat.c: Sort headers.
5637         * f-valprint.c: Sort headers.
5638         * f-typeprint.c: Sort headers.
5639         * f-lang.c: Sort headers.
5640         * extension.h: Sort headers.
5641         * extension.c: Sort headers.
5642         * extension-priv.h: Sort headers.
5643         * expprint.c: Sort headers.
5644         * exec.h: Sort headers.
5645         * exec.c: Sort headers.
5646         * exceptions.c: Sort headers.
5647         * event-top.c: Sort headers.
5648         * event-loop.c: Sort headers.
5649         * eval.c: Sort headers.
5650         * elfread.c: Sort headers.
5651         * dwarf2read.h: Sort headers.
5652         * dwarf2read.c: Sort headers.
5653         * dwarf2loc.c: Sort headers.
5654         * dwarf2expr.h: Sort headers.
5655         * dwarf2expr.c: Sort headers.
5656         * dwarf2-frame.c: Sort headers.
5657         * dwarf2-frame-tailcall.c: Sort headers.
5658         * dwarf-index-write.h: Sort headers.
5659         * dwarf-index-write.c: Sort headers.
5660         * dwarf-index-common.c: Sort headers.
5661         * dwarf-index-cache.h: Sort headers.
5662         * dwarf-index-cache.c: Sort headers.
5663         * dummy-frame.c: Sort headers.
5664         * dtrace-probe.c: Sort headers.
5665         * disasm.h: Sort headers.
5666         * disasm.c: Sort headers.
5667         * disasm-selftests.c: Sort headers.
5668         * dictionary.c: Sort headers.
5669         * dicos-tdep.c: Sort headers.
5670         * demangle.c: Sort headers.
5671         * dcache.h: Sort headers.
5672         * dcache.c: Sort headers.
5673         * darwin-nat.h: Sort headers.
5674         * darwin-nat.c: Sort headers.
5675         * darwin-nat-info.c: Sort headers.
5676         * d-valprint.c: Sort headers.
5677         * d-namespace.c: Sort headers.
5678         * d-lang.c: Sort headers.
5679         * ctf.c: Sort headers.
5680         * csky-tdep.c: Sort headers.
5681         * csky-linux-tdep.c: Sort headers.
5682         * cris-tdep.c: Sort headers.
5683         * cris-linux-tdep.c: Sort headers.
5684         * cp-valprint.c: Sort headers.
5685         * cp-support.c: Sort headers.
5686         * cp-namespace.c: Sort headers.
5687         * cp-abi.c: Sort headers.
5688         * corelow.c: Sort headers.
5689         * corefile.c: Sort headers.
5690         * continuations.c: Sort headers.
5691         * completer.h: Sort headers.
5692         * completer.c: Sort headers.
5693         * complaints.c: Sort headers.
5694         * coffread.c: Sort headers.
5695         * coff-pe-read.c: Sort headers.
5696         * cli-out.h: Sort headers.
5697         * cli-out.c: Sort headers.
5698         * charset.c: Sort headers.
5699         * c-varobj.c: Sort headers.
5700         * c-valprint.c: Sort headers.
5701         * c-typeprint.c: Sort headers.
5702         * c-lang.c: Sort headers.
5703         * buildsym.c: Sort headers.
5704         * buildsym-legacy.c: Sort headers.
5705         * build-id.h: Sort headers.
5706         * build-id.c: Sort headers.
5707         * btrace.c: Sort headers.
5708         * bsd-uthread.c: Sort headers.
5709         * breakpoint.h: Sort headers.
5710         * breakpoint.c: Sort headers.
5711         * break-catch-throw.c: Sort headers.
5712         * break-catch-syscall.c: Sort headers.
5713         * break-catch-sig.c: Sort headers.
5714         * blockframe.c: Sort headers.
5715         * block.c: Sort headers.
5716         * bfin-tdep.c: Sort headers.
5717         * bfin-linux-tdep.c: Sort headers.
5718         * bfd-target.c: Sort headers.
5719         * bcache.c: Sort headers.
5720         * ax-general.c: Sort headers.
5721         * ax-gdb.h: Sort headers.
5722         * ax-gdb.c: Sort headers.
5723         * avr-tdep.c: Sort headers.
5724         * auxv.c: Sort headers.
5725         * auto-load.c: Sort headers.
5726         * arm-wince-tdep.c: Sort headers.
5727         * arm-tdep.c: Sort headers.
5728         * arm-symbian-tdep.c: Sort headers.
5729         * arm-pikeos-tdep.c: Sort headers.
5730         * arm-obsd-tdep.c: Sort headers.
5731         * arm-nbsd-tdep.c: Sort headers.
5732         * arm-nbsd-nat.c: Sort headers.
5733         * arm-linux-tdep.c: Sort headers.
5734         * arm-linux-nat.c: Sort headers.
5735         * arm-fbsd-tdep.c: Sort headers.
5736         * arm-fbsd-nat.c: Sort headers.
5737         * arm-bsd-tdep.c: Sort headers.
5738         * arch-utils.c: Sort headers.
5739         * arc-tdep.c: Sort headers.
5740         * arc-newlib-tdep.c: Sort headers.
5741         * annotate.h: Sort headers.
5742         * annotate.c: Sort headers.
5743         * amd64-windows-tdep.c: Sort headers.
5744         * amd64-windows-nat.c: Sort headers.
5745         * amd64-tdep.c: Sort headers.
5746         * amd64-sol2-tdep.c: Sort headers.
5747         * amd64-obsd-tdep.c: Sort headers.
5748         * amd64-obsd-nat.c: Sort headers.
5749         * amd64-nbsd-tdep.c: Sort headers.
5750         * amd64-nbsd-nat.c: Sort headers.
5751         * amd64-nat.c: Sort headers.
5752         * amd64-linux-tdep.c: Sort headers.
5753         * amd64-linux-nat.c: Sort headers.
5754         * amd64-fbsd-tdep.c: Sort headers.
5755         * amd64-fbsd-nat.c: Sort headers.
5756         * amd64-dicos-tdep.c: Sort headers.
5757         * amd64-darwin-tdep.c: Sort headers.
5758         * amd64-bsd-nat.c: Sort headers.
5759         * alpha-tdep.c: Sort headers.
5760         * alpha-obsd-tdep.c: Sort headers.
5761         * alpha-nbsd-tdep.c: Sort headers.
5762         * alpha-mdebug-tdep.c: Sort headers.
5763         * alpha-linux-tdep.c: Sort headers.
5764         * alpha-linux-nat.c: Sort headers.
5765         * alpha-bsd-tdep.c: Sort headers.
5766         * alpha-bsd-nat.c: Sort headers.
5767         * aix-thread.c: Sort headers.
5768         * agent.c: Sort headers.
5769         * addrmap.c: Sort headers.
5770         * ada-varobj.c: Sort headers.
5771         * ada-valprint.c: Sort headers.
5772         * ada-typeprint.c: Sort headers.
5773         * ada-tasks.c: Sort headers.
5774         * ada-lang.c: Sort headers.
5775         * aarch64-tdep.c: Sort headers.
5776         * aarch64-ravenscar-thread.c: Sort headers.
5777         * aarch64-newlib-tdep.c: Sort headers.
5778         * aarch64-linux-tdep.c: Sort headers.
5779         * aarch64-linux-nat.c: Sort headers.
5780         * aarch64-fbsd-tdep.c: Sort headers.
5781         * aarch64-fbsd-nat.c: Sort headers.
5782         * aarch32-linux-nat.c: Sort headers.
5783
5784 2019-04-04  Tom Tromey  <tom@tromey.com>
5785
5786         * varobj.c (varobj_create): Update.
5787         * rust-exp.y (struct rust_parser) <update_innermost_block,
5788         lookup_symbol>: New methods.
5789         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5790         Rename.
5791         (rust_parser::rust_lookup_type)
5792         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5793         * printcmd.c (display_command, do_one_display): Update.
5794         * parser-defs.h (struct parser_state) <parser_state>: Add
5795         "tracker" parameter.
5796         (block_tracker): New member.
5797         (class innermost_block_tracker) <innermost_block_tracker>: Add
5798         "types" parameter.
5799         <reset>: Remove method.
5800         (innermost_block): Don't declare.
5801         (null_post_parser): Update.
5802         * parse.c (innermost_block): Remove global.
5803         (write_dollar_variable): Update.
5804         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5805         Remove "tracker_types" parameter.
5806         (parse_expression): Add "tracker" parameter.
5807         (parse_expression_for_completion): Update.
5808         (null_post_parser): Add "tracker" parameter.
5809         * p-exp.y: Update rules.
5810         * m2-exp.y: Update rules.
5811         * language.h (struct language_defn) <la_post_parser>: Add
5812         "tracker" parameter.
5813         * go-exp.y: Update rules.
5814         * f-exp.y: Update rules.
5815         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5816         parameter.
5817         * d-exp.y: Update rules.
5818         * c-exp.y: Update rules.
5819         * breakpoint.c (set_breakpoint_condition): Create an
5820         innermost_block_tracker.
5821         (watch_command_1): Likewise.
5822         * ada-lang.c (resolve): Add "tracker" parameter.
5823         (resolve_subexp): Likewise.
5824         * ada-exp.y (write_var_from_sym): Update.
5825
5826 2019-04-04  Tom Tromey  <tom@tromey.com>
5827
5828         * type-stack.h: New file.
5829         * type-stack.c: New file.
5830         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5831         type-stack.h.
5832         (insert_into_type_stack, insert_type, push_type, push_type_int)
5833         (insert_type_address_space, pop_type, pop_type_int)
5834         (pop_typelist, pop_type_stack, append_type_stack)
5835         (push_type_stack, get_type_stack, push_typelist)
5836         (follow_type_instance_flags, follow_types): Don't declare.
5837         * parse.c (type_stack): Remove global.
5838         (parse_exp_in_context): Update.
5839         (insert_into_type_stack, insert_type, push_type, push_type_int)
5840         (insert_type_address_space, pop_type, pop_type_int)
5841         (pop_typelist, pop_type_stack, append_type_stack)
5842         (push_type_stack, get_type_stack, push_typelist)
5843         (follow_type_instance_flags, follow_types): Remove (moved to
5844         type-stack.c).
5845         * f-exp.y (type_stack): New global.
5846         Update rules.
5847         (push_kind_type, f_parse): Update.
5848         * d-exp.y (type_stack): New global.
5849         Update rules.
5850         (d_parse): Update.
5851         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5852         Update rules.
5853         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5854         (HFILES_NO_SRCDIR): Add type-stack.h.
5855
5856 2019-04-04  Tom Tromey  <tom@tromey.com>
5857
5858         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5859         (rust_parser::convert_ast_to_expression, rust_parse)
5860         (rust_lex_test_completion, rust_lex_tests): Update.
5861         * parser-defs.h (struct expr_completion_state): New.
5862         (struct parser_state) <parser_state>: Add completion parameter.
5863         <mark_struct_expression, mark_completion_tag>: New methods.
5864         <parse_completion, m_completion_state>: New members.
5865         (prefixify_expression, null_post_parser): Update.
5866         (mark_struct_expression, mark_completion_tag): Don't declare.
5867         * parse.c (parse_completion, expout_last_struct)
5868         (expout_tag_completion_type, expout_completion_name): Remove
5869         globals.
5870         (parser_state::mark_struct_expression)
5871         (parser_state::mark_completion_tag): Now methods.
5872         (prefixify_expression): Add last_struct parameter.
5873         (prefixify_subexp): Likewise.
5874         (parse_exp_1): Update.
5875         (parse_exp_in_context): Add cstate parameter.  Update.
5876         (parse_expression_for_completion): Create an
5877         expr_completion_state.
5878         (null_post_parser): Add "completion" parameter.
5879         * p-exp.y: Update rules.
5880         (yylex): Update.
5881         * language.h (struct language_defn) <la_post_parser>: Add
5882         "completing" parameter.
5883         * go-exp.y: Update rules.
5884         (lex_one_token): Update.
5885         * expression.h (parse_completion): Don't declare.
5886         * d-exp.y: Update rules.
5887         (lex_one_token): Update rules.
5888         * c-exp.y: Update rules.
5889         (lex_one_token): Update.
5890         * ada-lang.c (resolve): Add "parse_completion" parameter.
5891         (resolve_subexp): Likewise.
5892         (ada_resolve_function): Likewise.
5893
5894 2019-04-04  Tom Tromey  <tom@tromey.com>
5895
5896         * parser-defs.h (struct parser_state) <start_arglist,
5897         end_arglist>: New methods.
5898         <arglist_len, m_funcall_chain>: New members.
5899         (arglist_len, start_arglist, end_arglist): Don't declare.
5900         * parse.c (arglist_len, funcall_chain): Remove global.
5901         (start_arglist, end_arglist): Remove functions.
5902         (parse_exp_in_context): Update.
5903         * p-exp.y: Update rules.
5904         * m2-exp.y: Update rules.
5905         * go-exp.y: Update rules.
5906         * f-exp.y: Update rules.
5907         * d-exp.y: Update rules.
5908         * c-exp.y: Update rules.
5909
5910 2019-04-04  Tom Tromey  <tom@tromey.com>
5911
5912         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5913         lex_operator, push_back>: New methods.
5914         Update all rules.
5915         (rust_parser::lex_hex, lex_escape): Rename and update.
5916         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5917         (rust_parser::lex_operator): Rename and update.
5918         (rust_parser::lex_number, rustyylex, rustyyerror)
5919         (rust_lex_test_init, rust_lex_test_sequence)
5920         (rust_lex_test_push_back, rust_lex_tests): Update.
5921         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5922         parameter.
5923         <lexptr, prev_lexptr>: New members.
5924         (lexptr, prev_lexptr): Don't declare.
5925         * parse.c (lexptr, prev_lexptr): Remove globals.
5926         (parse_exp_in_context): Update.
5927         * p-exp.y (yylex, yyerror): Update.
5928         * m2-exp.y (parse_number, yylex, yyerror): Update.
5929         * go-exp.y (lex_one_token, yyerror): Update.
5930         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5931         * d-exp.y (lex_one_token, yyerror): Update.
5932         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5933         (lex_one_token, yyerror): Update.
5934         * ada-lex.l (YY_INPUT): Update.
5935         (rewind_to_char): Update.
5936         * ada-exp.y (yyerror): Update.
5937
5938 2019-04-04  Tom Tromey  <tom@tromey.com>
5939
5940         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5941         * parser-defs.h (struct parser_state) <parser_state>: Add new
5942         parameter.
5943         <comma_terminates>: New member.
5944         (comma_terminates): Don't declare global.
5945         * parse.c (comma_terminates): Remove global.
5946         (parse_exp_in_context): Update.
5947         * p-exp.y (yylex): Update.
5948         * m2-exp.y (yylex): Update.
5949         * go-exp.y (lex_one_token): Update.
5950         * f-exp.y (yylex): Update.
5951         * d-exp.y (lex_one_token): Update.
5952         * c-exp.y (lex_one_token): Update.
5953         * ada-lex.l: Update.
5954
5955 2019-04-04  Tom Tromey  <tom@tromey.com>
5956
5957         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5958         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5959         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5960         * parser-defs.h (paren_depth): Don't declare.
5961         * parse.c (paren_depth): Remove global.
5962         (parse_exp_in_context): Update.
5963         * p-exp.y (paren_depth): New global.
5964         (pascal_parse): Initialize it.
5965         * m2-exp.y (paren_depth): New global.
5966         (m2_parse): Initialize it.
5967         * go-exp.y (paren_depth): New global.
5968         (go_parse): Initialize it.
5969         * f-exp.y (paren_depth): New global.
5970         (f_parse): Initialize it.
5971         * d-exp.y (paren_depth): New global.
5972         (d_parse): Initialize it.
5973         * c-exp.y (paren_depth): New global.
5974         (c_parse): Initialize it.
5975         * ada-lex.l (paren_depth): New global.
5976         (lexer_init): Initialize it.
5977
5978 2019-04-04  Tom Tromey  <tom@tromey.com>
5979
5980         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5981         (rust_parser::convert_ast_to_type)
5982         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5983         * parser-defs.h (struct parser_state) <parser_state>: Add
5984         parameters.  Initialize new members.
5985         <expression_context_block, expression_context_pc>: New members.
5986         * parse.c (expression_context_block, expression_context_pc):
5987         Remove globals.
5988         (parse_exp_in_context): Update.
5989         * p-exp.y: Update all rules.
5990         (yylex): Update.
5991         * m2-exp.y: Update all rules.
5992         (yylex): Update.
5993         * go-exp.y (yylex): Update.
5994         * f-exp.y (yylex): Update.
5995         * d-exp.y: Update all rules.
5996         (yylex): Update.
5997         * c-exp.y: Update all rules.
5998         (lex_one_token, classify_name, yylex, c_parse): Update.
5999         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6000
6001 2019-04-04  Tom Tromey  <tom@tromey.com>
6002
6003         * gdbarch.h, gdbarch.c: Rebuild.
6004         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6005         * stap-probe.h:
6006         (struct stap_parse_info): Replace "parser_state" with
6007         "expr_builder".
6008         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6009         (parser_state): New class.
6010         * parse.c (expr_builder): Rename.
6011         (expr_builder::release): Rename.
6012         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6013         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6014         (write_exp_elt_longcst, write_exp_elt_floatcst)
6015         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6016         (write_exp_string_vector, write_exp_bitstring)
6017         (write_exp_msymbol, mark_struct_expression)
6018         (write_dollar_variable)
6019         (insert_type_address_space, increase_expout_size): Replace
6020         "parser_state" with "expr_builder".
6021         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6022         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6023         "parser_state" with "expr_builder".
6024
6025 2019-04-04  Tom Tromey  <tom@tromey.com>
6026
6027         * rust-exp.y: Replace "parse_language" with method call.
6028         * p-exp.y:
6029         (yylex): Replace "parse_language" with method call.
6030         * m2-exp.y:
6031         (yylex): Replace "parse_language" with method call.
6032         * go-exp.y (classify_name): Replace "parse_language" with method
6033         call.
6034         * f-exp.y (yylex): Replace "parse_language" with method call.
6035         * d-exp.y (lex_one_token): Replace "parse_language" with method
6036         call.
6037         * c-exp.y:
6038         (lex_one_token, classify_name, yylex): Replace "parse_language"
6039         with method call.
6040         * ada-exp.y (find_primitive_type, type_char)
6041         (type_system_address): Replace "parse_language" with method call.
6042
6043 2019-04-04  Tom Tromey  <tom@tromey.com>
6044
6045         * rust-exp.y: Replace "parse_gdbarch" with method call.
6046         * parse.c (write_dollar_variable, insert_type_address_space):
6047         Replace "parse_gdbarch" with method call.
6048         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6049         call.
6050         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6051         call.
6052         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6053         "parse_gdbarch" with method call.
6054         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6055         with method call.
6056         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6057         "parse_gdbarch" with method call.
6058         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6059         "parse_gdbarch" with method call.
6060         * c-exp.y (parse_type, parse_number, classify_name): Replace
6061         "parse_gdbarch" with method call.
6062         * ada-lex.l: Replace "parse_gdbarch" with method call.
6063         * ada-exp.y (parse_type, find_primitive_type, type_char)
6064         (type_system_address): Replace "parse_gdbarch" with method call.
6065
6066 2019-04-04  Tom Tromey  <tom@tromey.com>
6067
6068         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6069         * stap-probe.c (stap_parse_argument): Update.
6070         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6071         initial_size parameter.
6072         * rust-exp.y (rust_lex_tests): Update.
6073         * parse.c (parser_state): Update.
6074         (parse_exp_in_context): Update.
6075         * parser-defs.h (struct parser_state) <parser_state>: Remove
6076         "initial_size" parameter.
6077
6078 2019-04-04  Tom Tromey  <tom@tromey.com>
6079
6080         * parser-defs.h (increase_expout_size): Don't declare.
6081         * parse.c (increase_expout_size): Now static.
6082
6083 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6084
6085         * gnu-nat.c (gnu_nat_target::wait): Fix
6086         target_waitstatus_to_string call.
6087
6088 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6089
6090         * eval.c (evaluate_subexp_standard): Handle internal functions
6091         during Fortran function call handling.
6092
6093 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6094
6095         * NEWS: Mention new internal functions.
6096         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6097         (read_base_type): Use dwarf2_init_complex_target_type.
6098         * value.c (creal_internal_fn): New function.
6099         (cimag_internal_fn): New function.
6100         (_initialize_values): Register new internal functions.
6101
6102 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6103
6104         * infrun.c (stop_all_threads): If debug_infrun, always
6105         trace the wait status after wait_one, using
6106         target_waitstatus_to_string and target_pid_to_str.
6107         (handle_inferior_event): Replace various trace of
6108         wait status kind by a single trace.
6109         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6110         wait status kind image by target_waitstatus_to_string.
6111         * target/waitstatus.c (target_waitstatus_to_string): Fix
6112         obsolete comment.
6113
6114 2019-04-01  Tom Tromey  <tromey@adacore.com>
6115
6116         PR symtab/23331:
6117         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6118
6119 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6120             Pedro Alves  <palves@redhat.com>
6121
6122         * top.c (quit_force): Call 'finalize_values'.
6123         * value.c (finalize_values): New function.
6124         * value.h (finalize_values): Declare.
6125
6126 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6127
6128         * NEWS: Announce $_gdb_major and $_gdb_minor.
6129
6130         * top.c (init_gdb_version_vars): New function.
6131         (gdb_init): Call init_gdb_version_vars.
6132
6133 2019-03-29  Tom Tromey  <tromey@adacore.com>
6134
6135         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6136         help text.  Remove dead code.
6137
6138 2019-03-29  Keith Seitz  <keiths@redhat.com>
6139
6140         From Siddhesh Poyarekar:
6141         * f-lang.h (f77_get_upperbound): Return LONGEST.
6142         (f77_get_lowerbound): Likewise.
6143         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6144         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6145         print them.
6146         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6147         plongest to format print it.
6148         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6149         (f77_get_upperbound): Likewise.
6150         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6151         LOWER_BOUND to LONGEST.
6152         (f77_create_arrayprint_offset_tbl): Likewise.
6153
6154 2019-03-29  Keith Seitz  <keiths@redhat.com>
6155
6156         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6157         %s/pulongest for TYPE_LENGTH instead of %d in format
6158         strings.
6159         * ada-typerint.c (ada_print_type): Likewise.
6160         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6161         * compile/compile-c-support.c (generate_register_struct): Likewise.
6162         * gdbtypes.c (recursive_dump_type): Likewise.
6163         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6164         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6165         instead of %d in format strings.
6166         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6167         to std::min to ULONGEST.
6168         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6169         instead of %d in format strings.
6170         * tracepoint.c (info_scope_command): Likewise.
6171         * typeprint.c (print_offset_data::update)
6172         (print_offset_data::finish): Likewise.
6173         * xtensa-tdep.c (xtensa_store_return_value)
6174         (xtensa_push_dummy_call): Likewise.
6175
6176 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6177
6178         * windows-nat.c (display_selector): Fixed format specifications
6179         for 64-bit Cygwin.
6180
6181 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6182
6183         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6184
6185 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6186
6187         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6188         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6189         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6190         (nios2_linux_init_abi): Install it.
6191
6192 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6193
6194         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6195
6196 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6197
6198         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6199
6200 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6201             Tom Tromey  <tromey@adacore.com>
6202
6203         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6204
6205 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6206
6207         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6208         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6209         method to compute the bounds of range types. Also print "[evaluated]"
6210         if the bounds' values come from a dynamic evaluation.
6211
6212 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6215         whitespace when pretty printing is on.
6216
6217 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6218
6219         * ppc-linux-nat.c: Add include.
6220
6221 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6222
6223         * NEWS: Mention AArch64 Pointer Authentication.
6224
6225 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6226
6227         * arm-linux-nat.c: Add include.
6228
6229 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6230
6231         * source-cache.c (source_cache::get_source_lines): Re-read
6232         fullname after calling open_source_file.
6233
6234 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6235
6236         * NEWS: Mention TLS support for FreeBSD.
6237
6238 2019-03-25  Tom Tromey  <tromey@adacore.com>
6239
6240         * minsyms.c (BUNCH_SIZE): Update comment.
6241         (~minimal_symbol_reader): Remove old comment.
6242         (compact_minimal_symbols): Update comment.
6243         (minimal_symbol_reader::install): Remove old comment.  Update
6244         other comments.
6245
6246 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6247
6248         * s390-linux-nat.c: Add include.
6249
6250 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6251
6252         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6253         Call linux_get_hwcap.
6254         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6255         Likewise.
6256         (aarch64_linux_get_hwcap): Remove function.
6257         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6258         declaration.
6259         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6260         linux_get_hwcap.
6261         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6262         * linux-tdep.c (linux_get_hwcap): Add function.
6263         (linux_get_hwcap2): Likewise.
6264         * linux-tdep.h (linux_get_hwcap): Add declaration.
6265         (linux_get_hwcap2): Likewise.
6266         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6267         (ppc_linux_get_hwcap2): Likewise.
6268         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6269         linux_get_hwcap.
6270         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6271         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6272         (ppc_linux_nat_target::read_description): Likewise.
6273         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6274         * s390-linux-nat.c: Likewise.
6275         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6276
6277 2019-03-24  Tom Tromey  <tom@tromey.com>
6278
6279         * ada-lang.c (standard_lookup): Simplify initialization.
6280         (ada_lookup_symbol_nonlocal): Simplify return.
6281         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6282         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6283         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6284         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6285         initialization.
6286         * solib.c (solib_global_lookup): Simplify.
6287         * symtab.c (null_block_symbol): Remove.
6288         (symbol_cache_lookup): Simplify returns.
6289         (lookup_language_this): Simplify returns.
6290         (lookup_symbol_aux): Simplify return.
6291         (lookup_local_symbol): Simplify returns.
6292         (lookup_global_symbol_from_objfile): Simplify return.
6293         (lookup_symbol_in_objfile_symtabs)
6294         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6295         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6296         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6297         * cp-namespace.c (cp_lookup_bare_symbol)
6298         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6299         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6300         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6301         (cp_lookup_symbol_via_imports): Simplify initialization.
6302         (find_symbol_in_baseclass): Likewise.
6303         * symtab.h (null_block_symbol): Remove.
6304         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6305         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6306         (d_lookup_symbol_module): Likewise.
6307         (find_symbol_in_baseclass): Simplify initialization.
6308
6309 2019-03-24  Tom Tromey  <tom@tromey.com>
6310
6311         * expression.h: Don't include symtab.h.
6312         (struct block): Forward declare.
6313
6314 2019-03-24  Tom Tromey  <tom@tromey.com>
6315
6316         * c-exp.y (typebase): Remove casts.
6317         * gdbtypes.c (lookup_unsigned_typename, )
6318         (lookup_signed_typename): Remove cast.
6319         * eval.c (parse_to_comma_and_eval): Remove cast.
6320         * parse.c (write_dollar_variable): Remove cast.
6321         * block.h (struct block) <superblock>: Now const.
6322         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6323         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6324         (map_block): Make "block" const.
6325         * symfile.h (struct quick_symbol_functions)
6326         <map_matching_symbols>: Constify block argument to "callback".
6327         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6328         const.
6329         (find_pc_sect_compunit_symtab): Make "b" const.
6330         (find_symbol_at_address): Likewise.
6331         (search_symbols): Likewise.
6332         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6333         (dw2_debug_names_lookup_symbol): Likewise.
6334         (dw2_map_matching_symbols): Update.
6335         * p-valprint.c (pascal_val_print): Remove "block".
6336         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6337         (aux_add_nonlocal_symbols): Make "block" const.
6338         (resolve_subexp): Remove cast.
6339         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6340         const.
6341         (iterate_over_file_blocks): Likewise.
6342         * f-exp.y (%union) <bval>: Remove.
6343         * coffread.c (patch_opaque_types): Make "b" const.
6344         * spu-tdep.c (spu_catch_start): Make "block" const.
6345         * c-valprint.c (print_unpacked_pointer): Remove "block".
6346         * symmisc.c (dump_symtab_1): Make "b" const.
6347         (block_depth): Make "block" const.
6348         * d-exp.y (%union) <bval>: Remove.
6349         * cp-support.h (cp_lookup_rtti_type): Update.
6350         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6351         * psymtab.c (psym_lookup_symbol): Make "block" const.
6352         (maintenance_check_psymtabs): Make "b" const.
6353         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6354         (enumerate_locals, enumerate_args): Update.
6355         * python/py-symtab.c (stpy_global_block): Make "block" const.
6356         (stpy_static_block): Likewise.
6357         * inline-frame.c (block_starting_point_at): Make "new_block"
6358         const.
6359         * block.c (find_block_in_blockvector): Make return type const.
6360         (blockvector_for_pc_sect): Make "b" const.
6361         (find_block_in_blockvector): Make "b" const.
6362
6363 2019-03-23  Tom Tromey  <tom@tromey.com>
6364
6365         * varobj.c (varobj_create): Update.
6366         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6367         * printcmd.c (display_command, do_one_display): Don't reset
6368         innermost_block.
6369         * parser-defs.h (enum innermost_block_tracker_type): Move to
6370         expression.h.
6371         (innermost_block): Update comment.
6372         * parse.c (parse_exp_1): Add tracker_types parameter.
6373         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6374         tracker_types parameter.  Reset innermost_block.
6375         (parse_exp_in_context): Remove.
6376         (parse_expression_for_completion): Update.
6377         * objfiles.c (~objfile): Don't reset expression_context_block or
6378         innermost_block.
6379         * expression.h (enum innermost_block_tracker_type): Move from
6380         parser-defs.h.
6381         (parse_exp_1): Add tracker_types parameter.
6382         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6383         reset innermost_block.
6384
6385 2019-03-23  Tom Tromey  <tom@tromey.com>
6386
6387         * objfiles.h: Include bcache.h.
6388
6389 2019-03-23  Tom Tromey  <tom@tromey.com>
6390
6391         * linespec.c (get_current_search_block): Use
6392         scoped_restore_current_language.
6393         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6394
6395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6396             Jiong Wang  <jiong.wang@arm.com>
6397
6398         * aarch64-linux-tdep.c
6399         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6400         section.
6401         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6402
6403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6404             Jiong Wang  <jiong.wang@arm.com>
6405
6406         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6407         instructions.
6408         (aarch64_analyze_prologue_test): Add PACIASP test.
6409         (aarch64_prologue_prev_register): Unmask PC value.
6410
6411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6412             Jiong Wang  <jiong.wang@arm.com>
6413
6414         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6415         (aarch64_dwarf2_prev_register): Unmask PC value.
6416         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6417         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6418         DW_CFA_AARCH64_negate_ra_state.
6419         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6420
6421 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6422             Jiong Wang  <jiong.wang@arm.com>
6423
6424         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6425         registers.
6426         (aarch64_pseudo_register_name): Likewise.
6427         (aarch64_pseudo_register_type): Likewise.
6428         (aarch64_pseudo_register_reggroup_p): Likewise.
6429         (aarch64_gdbarch_init): Add pauth registers.
6430         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6431         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6432         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6433         (struct gdbarch_tdep): Add regnum for ra_state.
6434
6435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6436             Jiong Wang  <jiong.wang@arm.com>
6437
6438         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6439
6440 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6441             Jiong Wang  <jiong.wang@arm.com>
6442
6443         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6444         function.
6445         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6446         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6447         (aarch64_gdbarch_init): Add puth registers.
6448         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6449         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6450         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6451
6452 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6453             Jiong Wang  <jiong.wang@arm.com>
6454
6455         * aarch64-linux-nat.c
6456         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6457         * aarch64-linux-tdep.c
6458         (aarch64_linux_core_read_description): Likewise.
6459         (aarch64_linux_get_hwcap): New function.
6460         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6461         (aarch64_linux_get_hwcap): New declaration.
6462
6463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6464             Jiong Wang  <jiong.wang@arm.com>
6465
6466         * aarch64-linux-nat.c
6467         (aarch64_linux_nat_target::read_description): Add pauth param.
6468         * aarch64-linux-tdep.c
6469         (aarch64_linux_core_read_description): Likewise.
6470         * aarch64-tdep.c (struct target_desc): Add in pauth.
6471         (aarch64_read_description): Add pauth param.
6472         (aarch64_gdbarch_init): Likewise.
6473         * aarch64-tdep.h (aarch64_read_description): Likewise.
6474         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6475         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6476         * features/Makefile: Add new files.
6477         * features/aarch64-pauth.c: New file.
6478         * features/aarch64-pauth.xml: New file.
6479
6480 2019-03-20  Tom Tromey  <tromey@adacore.com>
6481
6482         * infrun.c (handle_inferior_event): Rename from
6483         handle_inferior_event_1.  Create a scoped_value_mark.
6484         (handle_inferior_event): Remove.
6485
6486 2019-03-19  Tom Tromey  <tromey@adacore.com>
6487
6488         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6489         * infrun.h (print_stop_event): Add "displays" parameter.
6490         * infrun.c (print_stop_event): Add "displays" parameter.
6491
6492 2019-03-19  Pedro Alves  <palves@redhat.com>
6493
6494         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6495         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6496         to -1.  Fix TABs vs spaces.
6497         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6498         * tui/tui-out.h (tui_ui_out) Add intro comments.
6499         <m_line, m_start_of_line>: In-class initialize, and add describing
6500         comment.
6501
6502 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6503
6504         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6505         variable names.
6506         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6507
6508 2019-03-18  Pedro Alves  <palves@redhat.com>
6509             Eli Zaretskii <eliz@gnu.org>
6510
6511         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6512         m_line and m_start_of_line.
6513
6514 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6515
6516         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6517         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6518         it returns a newline.  This fixes a regression in TU mode, whereby
6519         the next line is output on the same screen line as the user input.
6520
6521 2019-03-18  Tom Tromey  <tromey@adacore.com>
6522
6523         * minsyms.c (minimal_symbol_reader::install): Remove call to
6524         obstack_blank.
6525
6526 2019-03-18  Pedro Alves  <palves@redhat.com>
6527
6528         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6529         New globals.
6530         (apply_style): New, factored out from ...
6531         (apply_ansi_escape): ... this.  Handle reverse video mode.
6532         (tui_set_reverse_mode): New function.
6533         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6534         * tui/tui-winsource.c (tui_show_source_line): Use
6535         tui_set_reverse_mode instead of setting A_STANDOUT.
6536         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6537         New setter methods.
6538
6539 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6540
6541         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6542         Handle tabs.
6543
6544 2019-03-18  Tom Tromey  <tromey@adacore.com>
6545
6546         * ada-lang.c (empty_array): Add "high" parameter.
6547         (ada_evaluate_subexp): Update.
6548
6549 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6550
6551         * unittests/string_view-selftests.c: Define
6552         _initialize_string_view_selftests unconditionally.
6553
6554 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6555
6556         PR gdb/24350
6557         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6558
6559 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6560
6561         PR gdb/24351
6562         * windows-nat.c (display_selector): Fix format specifiers.
6563
6564 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6565
6566         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6567         tui_refill_source_window instead of tui_refresh_win, to update the
6568         current execution line.  This fixes redisplay of the current line
6569         when stepping through the code with "next" or "step".
6570
6571 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6572
6573         * source-cache.c (source_cache::get_source_lines): Call
6574         find_source_lines to initialize s->nlines.  This fixes vertical
6575         scrolling of TUI source window when the DOWN arrow is pressed.
6576
6577 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6578
6579         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6580         linux-thread-db.c (_initialize_thread_db): Likewise.
6581
6582 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6583
6584         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6585         wclrtoeol in tui_show_source_line".  This reverts changes made in
6586         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6587
6588 2019-03-15  Tom Tromey  <tom@tromey.com>
6589
6590         * symtab.h (struct minimal_symbol): Derive from
6591         general_symbol_info.
6592         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6593         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6594         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6595         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6596         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6597         (MSYMBOL_SEARCH_NAME): Update.
6598         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6599         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6600         * minsyms.c (minimal_symbol_reader::record_full): Update.
6601
6602 2019-03-15  Tom Tromey  <tom@tromey.com>
6603
6604         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6605
6606 2019-03-15  Tom Tromey  <tom@tromey.com>
6607
6608         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6609         unique_xmalloc_ptr.
6610         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6611         Update.
6612         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6613         (build_minimal_symbol_hash_tables)
6614         (minimal_symbol_reader::install): Update.
6615
6616 2019-03-15  Tom Tromey  <tom@tromey.com>
6617
6618         * symtab.c (create_demangled_names_hash): Update.
6619         (symbol_set_names): Update.
6620         * objfiles.h (struct objfile_per_bfd_storage)
6621         <demangled_names_hash>: Now an htab_up.
6622         * objfiles.c (objfile_per_bfd_storage): Simplify.
6623
6624 2019-03-15  Tom Tromey  <tom@tromey.com>
6625
6626         * objfiles.h (struct objfile_per_bfd_storage): Declare
6627         destructor.
6628         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6629         New.
6630         (get_objfile_bfd_data): Use new.  Don't initialize
6631         language_of_main.
6632         (free_objfile_per_bfd_storage): Remove.
6633         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6634
6635 2019-03-15  Tom Tromey  <tom@tromey.com>
6636
6637         * symfile.c (reread_symbols): Update.
6638         * objfiles.c (objfile::objfile): Update.
6639         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6640         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6641         comment.
6642         (minimal_symbol_reader::install): Update.
6643         (terminate_minimal_symbol_table): Remove.
6644         * jit.c (jit_object_close_impl): Update.
6645
6646 2019-03-15  Tom Tromey  <tom@tromey.com>
6647
6648         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6649         initializations.
6650
6651 2019-03-15  Tom Tromey  <tom@tromey.com>
6652
6653         * objfiles.h (struct objfile_per_bfd_storage)
6654         <demangled_hash_languages>: Now a bitset.
6655         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6656         (lookup_minimal_symbol): Update.
6657
6658 2019-03-15  Tom Tromey  <tom@tromey.com>
6659
6660         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6661         Don't return the symbol.
6662         * coffread.c (record_minimal_symbol): Use record_full.
6663
6664 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6665
6666         The MS-Windows port of ncurses fails to switch to a color pair if
6667         one or both of the colors are the implicit default colors.  This
6668         change records the default colors when TUI is initialized, and
6669         then specifies them explicitly when a color pair uses the default
6670         colors.  This allows color styling in TUI mode on MS-Windows.
6671
6672         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6673         ncurses_norm_attr.
6674         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6675         colors in ncurses_norm_attr.
6676         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6677         "none", replace it with the default color recorded in
6678         ncurses_norm_attr.
6679
6680 2019-03-14  Tom Tromey  <tromey@adacore.com>
6681
6682         * source-cache.h (class source_cache) <get_source_lines>: Return
6683         std::string.
6684         * source-cache.c (source_cache::extract_lines): Handle case where
6685         first_pos==npos.  Return std::string.
6686         (source_cache::get_source_lines): Update.
6687
6688 2019-03-14  Tom Tromey  <tromey@adacore.com>
6689
6690         * NEWS: Add item for "style sources" commands.
6691         * source-cache.c (source_cache::get_source_lines): Check
6692         source_styling.
6693         * cli/cli-style.c (source_styling): New global.
6694         (_initialize_cli_style): Add "style sources" commands.
6695         (show_style_sources): New function.
6696         * cli/cli-style.h (source_styling): Declare.
6697
6698 2019-03-14  Pedro Alves  <palves@redhat.com>
6699             Tom Tromey  <tromey@adacore.com>
6700
6701         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6702         * tui/tui-winsource.c (tui_refill_source_window): New function,
6703         from...
6704         (tui_horizontal_source_scroll): ... here.  Move some logic.
6705         * cli/cli-style.c (set_style_enabled): Notify new observable.
6706         * tui/tui-hooks.c (tui_redisplay_source): New function.
6707         (tui_attach_detach_observers): Attach or detach
6708         tui_redisplay_source.
6709         * observable.h (source_styling_changed): New observable.
6710         * observable.c: Define source_styling_changed observable.
6711
6712 2019-03-13  Tom Tromey  <tromey@adacore.com>
6713
6714         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6715         (i386_gnu_nat_target::store_registers): Update.
6716         * target-debug.h (target_debug_print_std_string): New macro.
6717         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6718         * windows-tdep.c (display_one_tib): Update.
6719         * tui/tui-stack.c (tui_make_status_line): Update.
6720         * top.c (print_inferior_quit_action): Update.
6721         * thread.c (thr_try_catch_cmd): Update.
6722         (add_thread_with_info): Update.
6723         (thread_target_id_str): Update.
6724         (thr_try_catch_cmd): Update.
6725         (thread_command): Update.
6726         (thread_find_command): Update.
6727         * record-btrace.c (record_btrace_target::info_record)
6728         (record_btrace_resume_thread, record_btrace_target::resume)
6729         (record_btrace_cancel_resume, record_btrace_step_thread)
6730         (record_btrace_target::wait, record_btrace_target::wait)
6731         (record_btrace_target::wait, record_btrace_target::stop): Update.
6732         * progspace.c (print_program_space): Update.
6733         * process-stratum-target.c
6734         (process_stratum_target::thread_address_space): Update.
6735         * linux-fork.c (linux_fork_mourn_inferior)
6736         (detach_checkpoint_command, info_checkpoints_command)
6737         (linux_fork_context): Update.
6738         (linux_fork_detach): Update.
6739         (class scoped_switch_fork_info): Update.
6740         (delete_checkpoint_command): Update.
6741         * infrun.c (follow_fork_inferior): Update.
6742         (follow_fork_inferior): Update.
6743         (proceed_after_vfork_done): Update.
6744         (handle_vfork_child_exec_or_exit): Update.
6745         (follow_exec): Update.
6746         (displaced_step_prepare_throw): Update.
6747         (displaced_step_restore): Update.
6748         (start_step_over): Update.
6749         (resume_1): Update.
6750         (clear_proceed_status_thread): Update.
6751         (proceed): Update.
6752         (print_target_wait_results): Update.
6753         (do_target_wait): Update.
6754         (context_switch): Update.
6755         (stop_all_threads): Update.
6756         (restart_threads): Update.
6757         (finish_step_over): Update.
6758         (handle_signal_stop): Update.
6759         (switch_back_to_stepped_thread): Update.
6760         (keep_going_pass_signal): Update.
6761         (print_exited_reason): Update.
6762         (normal_stop): Update.
6763         * inferior.c (inferior_pid_to_str): Change return type.
6764         (print_selected_inferior): Update.
6765         (add_inferior): Update.
6766         (detach_inferior): Update.
6767         * dummy-frame.c (fprint_dummy_frames): Update.
6768         * dcache.c (dcache_info_1): Update.
6769         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6770         (btrace_fetch, btrace_clear): Update.
6771         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6772         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6773         type.
6774         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6775         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6776         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6777         * gdbarch.c, gdbarch.h: Rebuild.
6778         * gdbarch.sh (core_pid_to_str): Change return type.
6779         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6780         return type.
6781         (windows_nat_target::pid_to_str): Change return type.
6782         (windows_delete_thread): Update.
6783         (windows_nat_target::attach): Update.
6784         (windows_nat_target::files_info): Update.
6785         * target-delegates.c: Rebuild.
6786         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6787         return type.
6788         (sol_thread_target::pid_to_str): Change return type.
6789         * remote.c (class remote_target) <pid_to_str>: Change return
6790         type.
6791         (remote_target::pid_to_str): Change return type.
6792         (extended_remote_target::attach, remote_target::remote_stop_ns)
6793         (remote_target::remote_notif_remove_queued_reply)
6794         (remote_target::push_stop_reply, remote_target::disable_btrace):
6795         Update.
6796         (extended_remote_target::attach): Update.
6797         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6798         type.
6799         (gdbsim_target::pid_to_str): Change return type.
6800         * ravenscar-thread.c (struct ravenscar_thread_target)
6801         <pid_to_str>: Change return type.
6802         (ravenscar_thread_target::pid_to_str): Change return type.
6803         * procfs.c (class procfs_target) <pid_to_str>: Change return
6804         type.
6805         (procfs_target::pid_to_str): Change return type.
6806         (procfs_target::attach): Update.
6807         (procfs_target::detach): Update.
6808         (procfs_target::fetch_registers): Update.
6809         (procfs_target::store_registers): Update.
6810         (procfs_target::wait): Update.
6811         (procfs_target::files_info): Update.
6812         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6813         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6814         return type.
6815         (nto_procfs_target::pid_to_str): Change return type.
6816         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6817         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6818         return type.
6819         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6820         (exit_lwp): Update.
6821         (attach_proc_task_lwp_callback, get_detach_signal)
6822         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6823         (linux_nat_target::resume, wait_lwp, stop_callback)
6824         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6825         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6826         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6827         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6828         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6829         type.
6830         (inf_ptrace_target::attach): Update.
6831         (inf_ptrace_target::files_info): Update.
6832         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6833         type.
6834         (go32_nat_target::pid_to_str): Change return type.
6835         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6836         (gnu_nat_target::wait): Update.
6837         (gnu_nat_target::wait): Update.
6838         (gnu_nat_target::resume): Update.
6839         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6840         (fbsd_nat_target::wait): Update.
6841         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6842         type.
6843         (darwin_nat_target::attach): Update.
6844         * corelow.c (class core_target) <pid_to_str>: Change return type.
6845         (core_target::pid_to_str): Change return type.
6846         * target.c (normal_pid_to_str): Change return type.
6847         (default_pid_to_str): Likewise.
6848         (target_pid_to_str): Change return type.
6849         (target_translate_tls_address): Update.
6850         (target_announce_detach): Update.
6851         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6852         return type.
6853         (bsd_uthread_target::pid_to_str): Change return type.
6854         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6855         type.
6856         (bsd_kvm_target::pid_to_str): Change return type.
6857         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6858         return type.
6859         (aix_thread_target::pid_to_str): Change return type.
6860         * target.h (struct target_ops) <pid_to_str>: Change return type.
6861         (target_pid_to_str, normal_pid_to_str): Likewise.
6862         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6863         type.
6864         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6865         type.
6866         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6867         return type.
6868         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6869         type.
6870         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6871         type.
6872         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6873         return type.
6874
6875 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6876
6877         * NEWS: Mention that the new default MI version is 3.  Mention
6878         changes to the output of commands and events that deal with
6879         multi-location breakpoints.
6880         * breakpoint.c: Include "mi/mi-out.h".
6881         (print_one_breakpoint): Change output syntax if using MI version
6882         >= 3.
6883         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6884         New.
6885         (mi_multi_location_breakpoint_output_fixed): New.
6886         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6887         (mi_cmd_fix_multi_location_breakpoint_output): New.
6888         (mi_multi_location_breakpoint_output_fixed): New.
6889         * mi/mi-cmds.c (mi_cmds): Register command
6890         -fix-multi-location-breakpoint-output.
6891         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6892         interpreter "mi".
6893
6894 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6895
6896         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6897         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6898         instantiate mi_ui_out based on interpreter name.
6899         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6900         * mi/mi-main.c (mi_load_progress): Likewise.
6901
6902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6903
6904         * NEWS: Combine separate "New targets" sections for 8.3.
6905
6906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6907
6908         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6909         (ppcfbsd_init_abi): Install gdbarch
6910         "fetch_tls_load_module_address" and "get_thread_local_address"
6911         methods.
6912
6913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6914
6915         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6916         (riscv_fbsd_init_abi): Install gdbarch
6917         "fetch_tls_load_module_address" and "get_thread_local_address"
6918         methods.
6919
6920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6921
6922         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6923         (i386fbsd_init_abi): Install gdbarch
6924         "fetch_tls_load_module_address" and "get_thread_local_address"
6925         methods.
6926
6927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6928
6929         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6930         (amd64fbsd_init_abi): Install gdbarch
6931         "fetch_tls_load_module_address" and "get_thread_local_address"
6932         methods.
6933
6934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6935
6936         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6937         (struct fbsd_pspace_data): New type.
6938         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6939         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6940         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6941         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6942         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6943
6944 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6945
6946         * gdbtypes.c (lookup_struct_elt): New function.
6947         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6948         * gdbtypes.h (struct struct_elt): New type.
6949         (lookup_struct_elt): New prototype.
6950
6951 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6952
6953         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6954         remove disabled code block.
6955
6956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6957
6958         * gdbarch.sh (get_thread_local_address): New method.
6959         * gdbarch.h, gdbarch.c: Regenerate.
6960         * target.c (target_translate_tls_address): Use
6961         gdbarch_get_thread_local_address if present instead of
6962         target::get_thread_local_address.
6963
6964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6965
6966         * target.h (target::get_thread_local_address): Update comment.
6967
6968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6969
6970         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6971         objfile->separate_debug_objfile_backlink if not NULL.
6972
6973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6974
6975         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6976         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6977         (amd64bsd_store_inferior_registers): Likewise.
6978         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6979         Enable segment base registers.
6980         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6981         PT_GETFSBASE and PT_GETGSBASE.
6982         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6983         PT_SETGSBASE.
6984         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6985         segment base registers.
6986         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6987
6988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6989
6990         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6991         Update calls to i386_target_description to add 'segments'
6992         parameter.
6993         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6994         add segment base registers.
6995         * arch/i386.c (i386_create_target_description): Add 'segments'
6996         parameter to enable segment base registers.
6997         * arch/i386.h (i386_create_target_description): Likewise.
6998         * features/i386/32bit-segments.xml: New file.
6999         * features/i386/32bit-segments.c: Generate.
7000         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7001         call to i386_target_description to add 'segments' parameter.
7002         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7003         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7004         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7005         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7006         if feature is present.
7007         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7008         Add 'segments' parameter to call to i386_target_description.
7009         (i386_target_description): Add 'segments' parameter to enable
7010         segment base registers.
7011         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7012         to call to i386_target_description.
7013         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7014         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7015         Define I386_NUM_REGS.
7016         (i386_target_description): Add 'segments' parameter to enable
7017         segment base registers.
7018
7019 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7020
7021         PR/24325
7022         * source-cache.c: #undef open and close, to avoid unresolved
7023         externals during linking.
7024
7025 2019-03-12  Tom Tromey  <tromey@adacore.com>
7026
7027         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7028         const.  Add initializers.
7029         (_initialize_remote): Don't initialize ptid globals.
7030
7031 2019-03-12  Pedro Alves  <palves@redhat.com>
7032
7033         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7034
7035 2019-03-12  Pedro Alves  <palves@redhat.com>
7036
7037         * cp-name-parser.y (main): Remove unused 'len' variable.
7038
7039 2019-03-12  Tom Tromey  <tromey@adacore.com>
7040
7041         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7042         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7043
7044 2019-03-12  Tom Tromey  <tromey@adacore.com>
7045
7046         * linux-nat.c (iterate_over_lwps): Update.
7047         (stop_callback): Remove parameter.
7048         (stop_wait_callback, detach_callback, resume_set_callback)
7049         (select_singlestep_lwp_callback, set_ignore_sigint)
7050         (status_callback, resumed_callback, resume_clear_callback)
7051         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7052         data parameter.
7053         (linux_nat_target::detach, linux_nat_target::resume)
7054         (linux_stop_and_wait_all_lwps, select_event_lwp)
7055         (linux_nat_filter_event, linux_nat_wait_1)
7056         (linux_nat_target::kill, linux_nat_target::stop)
7057         (linux_nat_target::stop): Update.
7058         (linux_nat_resume_callback): Change type.
7059         (resume_stopped_resumed_lwps, count_events_callback)
7060         (select_event_lwp_callback): Likewise.
7061         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7062         * arm-linux-nat.c (struct update_registers_data): Remove.
7063         (update_registers_callback): Change type.
7064         (arm_linux_insert_hw_breakpoint1): Update.
7065         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7066         parameter.
7067         (x86_linux_dr_set_addr): Update.
7068         (x86_linux_dr_set_control): Update.
7069         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7070         (iterate_over_lwps): Use gdb::function_view.
7071         * nat/aarch64-linux-hw-point.c (struct
7072         aarch64_dr_update_callback_param): Remove.
7073         (debug_reg_change_callback): Change type.
7074         (aarch64_notify_debug_reg_change): Update.
7075         * s390-linux-nat.c (s390_refresh_per_info): Update.
7076
7077 2019-03-11  Tom Tromey  <tromey@adacore.com>
7078
7079         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7080         redundant assignment to "this_cu".
7081
7082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7083
7084         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7085
7086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7087
7088         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7089         from...
7090         (rank_one_type): ... this.
7091
7092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7093
7094         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7095         from...
7096         (rank_one_type): ... this.
7097
7098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7099
7100         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7101         from...
7102         (rank_one_type): ... this.
7103
7104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7105
7106         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7107         from...
7108         (rank_one_type): ... this.
7109
7110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7111
7112         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7113         from...
7114         (rank_one_type): ... this.
7115
7116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7117
7118         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7119         from...
7120         (rank_one_type): ... this.
7121
7122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7123
7124         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7125         from...
7126         (rank_one_type): ... this.
7127
7128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7129
7130         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7131         from...
7132         (rank_one_type): ... this.
7133
7134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7135
7136         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7137         from...
7138         (rank_one_type): ... this.
7139
7140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7141
7142         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7143         from...
7144         (rank_one_type): ... this.
7145
7146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7147
7148         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7149         from...
7150         (rank_one_type): ... this.
7151
7152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7153
7154         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7155         from...
7156         (rank_one_type): ... this.
7157
7158 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7159
7160         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7161         inferior-events' shows the example events.
7162
7163 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7164
7165         Support styling on native MS-Windows console
7166
7167         PR/24315
7168         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7169         on MS-Windows if $TERM is not defined.
7170
7171         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7172
7173         * posix-hdep.c (gdb_console_fputs):
7174         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7175         functions.
7176         * ui-file.h (gdb_console_fputs): Add prototype.
7177
7178         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7179         back to fputs only if the former returns zero.
7180
7181 2019-03-07  Tom Tromey  <tom@tromey.com>
7182
7183         * symmisc.c (print_symbol_bcache_statistics): Update.
7184         (print_objfile_statistics): Update.
7185         * symfile.c (allocate_symtab): Update.
7186         * stabsread.c: Don't include bcache.h.
7187         * psymtab.h (struct psymbol_bcache): Don't declare.
7188         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7189         (psymbol_bcache_init, psymbol_bcache_free)
7190         (psymbol_bcache_get_bcache): Don't declare.
7191         * psymtab.c (struct psymbol_bcache): Remove.
7192         (psymtab_storage::psymtab_storage): Update.
7193         (psymtab_storage::~psymtab_storage): Update.
7194         (psymbol_bcache_init, psymbol_bcache_free)
7195         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7196         (add_psymbol_to_bcache): Update.
7197         (allocate_psymtab): Update.
7198         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7199         macro_cache>: No longer pointers.
7200         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7201         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7202         * macrotab.c (macro_bcache): Update.
7203         * macroexp.c: Don't include bcache.h.
7204         * gdbtypes.c (check_types_worklist): Update.
7205         (types_deeply_equal): Remove TRY/CATCH.  Update.
7206         * elfread.c (elf_symtab_read): Update.
7207         * dwarf2read.c: Don't include bcache.h.
7208         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7209         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7210         (print_bcache_statistics, bcache_memory_used): Don't declare.
7211         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7212         methods.  Rename all data members.
7213         * bcache.c (struct bcache): Move to bcache.h.
7214         (bcache::expand_hash_table): Rename from expand_hash_table.
7215         (bcache): Remove.
7216         (bcache::insert): Rename from bcache_full.
7217         (bcache::compare): Rename from bcache_compare.
7218         (bcache_xmalloc): Remove.
7219         (bcache::~bcache): Rename from bcache_xfree.
7220         (bcache::print_statistics): Rename from print_bcache_statistics.
7221         (bcache::memory_used): Rename from bcache_memory_used.
7222
7223 2019-03-07  Pedro Alves  <palves@redhat.com>
7224
7225         * infrun.c (normal_stop): Also check for
7226         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7227
7228 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * f-lang.c (value_from_host_double): Moved to...
7231         * value.c (value_from_host_double): ...here.
7232         * value.h (value_from_host_double): Declare.
7233         * guile/scm-math.c (vlscm_convert_typed_number): Use
7234         value_from_host_double.
7235         (vlscm_convert_number): Likewise.
7236         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7237         * python/py-value.c (convert_value_from_python): Likewise.
7238
7239 2019-03-06  Tom Tromey  <tom@tromey.com>
7240
7241         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7242
7243 2019-03-06  Tom Tromey  <tom@tromey.com>
7244
7245         * utils.h (free_current_contents): Don't declare.
7246         * utils.c (free_current_contents): Remove.
7247
7248 2019-03-06  Tom Tromey  <tom@tromey.com>
7249
7250         * top.c (quit_force): Update.
7251         * main.c (captured_command_loop): Update.
7252         * common/new-op.c (operator new): Update.
7253         * common/common-exceptions.c (struct catcher)
7254         <save_cleanup_chain>: Remove member.
7255         (exceptions_state_mc_init): Update.
7256         (exception_try_scope_entry): Return nullptr.
7257         (exception_try_scope_exit, exception_rethrow)
7258         (throw_exception_sjlj, throw_exception_cxx): Update.
7259         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7260         (all_cleanups, do_cleanups, discard_cleanups)
7261         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7262         (restore_cleanups, restore_final_cleanups): Don't declare.
7263         (do_final_cleanups): Remove parameter.
7264         * common/cleanups.c (cleanup_chain, make_cleanup)
7265         (make_cleanup_dtor, all_cleanups, do_cleanups)
7266         (discard_my_cleanups, discard_cleanups)
7267         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7268         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7269         (null_cleanup): Remove.
7270         (do_final_cleanups): Remove parameter.
7271
7272 2019-03-06  Tom Tromey  <tom@tromey.com>
7273
7274         * remote.c (remote_target::remote_parse_stop_reply): Use
7275         unique_xmalloc_ptr.
7276
7277 2019-03-06  Tom Tromey  <tom@tromey.com>
7278
7279         * stabsread.c (struct stabs_field_info): Rename from field_info.
7280         <list, fnlist>: Add initializers.
7281         <obstack>: New member.
7282         (read_member_functions, read_struct_fields, read_baseclasses):
7283         Allocate on obstack.  Don't use cleanups.
7284         (read_one_struct_field, read_member_functions, read_struct_fields)
7285         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7286         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7287         (read_struct_type): Update.
7288
7289 2019-03-06  Tom Tromey  <tom@tromey.com>
7290
7291         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7292         * common/filestuff.h (make_cleanup_close): Don't declare.
7293         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7294         Remove.
7295
7296 2019-03-06  Tom Tromey  <tom@tromey.com>
7297
7298         * solib-aix.c: Use make_scope_exit.
7299
7300 2019-03-06  Tom Tromey  <tom@tromey.com>
7301
7302         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7303         Use make_scope_exit.
7304
7305 2019-03-06  Tom Tromey  <tom@tromey.com>
7306
7307         * solib-svr4.c (disable_probes_interface): Remove parameter.
7308         (svr4_handle_solib_event): Use make_scope_exit.
7309
7310 2019-03-06  Tom Tromey  <tom@tromey.com>
7311
7312         * remote.c (struct stop_reply_deleter): Remove.
7313         (stop_reply_up): Update.
7314         (struct stop_reply): Derive from notif_event.  Don't typedef.
7315         <regcache>: Now a std::vector.
7316         (stop_reply_xfree): Remove.
7317         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7318         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7319         (remote_target::discard_pending_stop_replies): Use delete.
7320         (remote_target::remote_parse_stop_reply): Update.
7321         (remote_target::process_stop_reply): Update.
7322         * remote-notif.h (struct notif_event): Add virtual destructor.
7323         Remove "dtr" member.
7324         (struct notif_client) <alloc_event>: Return a unique_ptr.
7325         (notif_event_xfree): Don't declare.
7326         (notif_event_up): New typedef.
7327         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7328         (notif_event_xfree, do_notif_event_xfree): Remove.
7329         (remote_notif_state_xfree): Update.
7330
7331 2019-03-06  Tom Tromey  <tom@tromey.com>
7332
7333         * infrun.c (displaced_step_clear_cleanup): Now a
7334         forward_scope_exit type.
7335         (displaced_step_prepare_throw): Update.
7336         (displaced_step_fixup): Update.
7337
7338 2019-03-06  Tom Tromey  <tom@tromey.com>
7339
7340         * inferior.h (class inferior): Update comment.
7341         * gdbthread.h (class thread_info): Update comment.
7342
7343 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7344             Tom Tromey  <tom@tromey.com>
7345
7346         * stabsread.h (struct stab_section_list): Remove.
7347         (coffstab_build_psymtabs): Update.
7348         * dbxread.c (symbuf_sections): Now a std::vector.
7349         (sect_idx): New global.
7350         (fill_symbuf): Update.
7351         (coffstab_build_psymtabs): Change type of stabsects parameter.
7352         Update.
7353         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7354         std::vector.
7355         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7356         (coff_locate_sections): Update.
7357         (coff_symfile_read): Remove cleanups.  Update.
7358         (init_stringtab): Add storage parameter.
7359         (free_stringtab, free_stringtab_cleanup): Remove.
7360         (init_lineno): Add storage parameter.
7361         (free_linetab, free_linetab_cleanup): Remove.
7362
7363 2019-03-06  Pedro Alves  <palves@redhat.com>
7364
7365         * linux-fork.c (fork_info::clobber_regs): Delete.
7366         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7367         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7368         comment.  Adjust.
7369         (scoped_switch_fork_info::scoped_switch_fork_info)
7370         (checkpoint_command, linux_fork_context): Adjust
7371         fork_save_infrun_state calls.
7372
7373 2019-03-06  Pedro Alves  <palves@redhat.com>
7374
7375         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7376         (inf_has_multiple_threads): Return 'bool' and rewrite using
7377         inferior_info::threads().
7378
7379 2019-03-06  Pedro Alves  <palves@redhat.com>
7380
7381         * linux-fork.c: Include <list>.
7382         (fork_list): Now a std::list instance.
7383         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7384         (forks_exist_p, find_last_fork): Adjust.
7385         (new_fork): Delete.
7386         (one_fork_p): New.
7387         (add_fork): Adjust.
7388         (free_fork): Delete, folded into fork_info::~fork_info().
7389         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7390         Adjust.
7391         (init_fork_list): Delete.
7392         (linux_fork_killall, linux_fork_mourn_inferior)
7393         (linux_fork_detach, info_checkpoints_command): Adjust.
7394         (_initialize_linux_fork): No longer call init_fork_list.
7395
7396 2019-03-06  Pedro Alves  <palves@redhat.com>
7397
7398         * linux-fork.c (new_fork): New, split out of ...
7399         (add_fork): ... this.  Return void.  Move "first fork" special
7400         case from here, to ...
7401         (checkpoint_command): ... here.
7402         * linux-linux.h (add_fork): Return void.
7403
7404 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7405
7406         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7407
7408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7409             Chris January  <chris.january@arm.com>
7410             David Lecomber  <david.lecomber@arm.com>
7411
7412         * f-exp.y: New token, UNOP_INTRINSIC.
7413         (exp): New pattern using UNOP_INTRINSIC token.
7414         (f77_keywords): Add 'abs' keyword.
7415         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7416         (value_from_host_double): New function.
7417         (evaluate_subexp_f): Support UNOP_ABS.
7418
7419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7422         types.
7423
7424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7427         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7428         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7429
7430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7433
7434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7435             Chris January  <chris.january@arm.com>
7436
7437         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7438         * f-exp.y: Define 'KIND' token.
7439         (exp): New pattern for KIND expressions.
7440         (ptype): Handle types with a kind extension.
7441         (direct_abs_decl): Extend to spot kind extensions.
7442         (f77_keywords): Add 'kind' to the list.
7443         (push_kind_type): New function.
7444         (convert_to_kind_type): New function.
7445         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7446         * parse.c (operator_length_standard): Likewise.
7447         * parser-defs.h (enum type_pieces): Add tp_kind.
7448         * std-operator.def: Add UNOP_KIND.
7449
7450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7451
7452         * f-exp.y (f_parse): Set yydebug.
7453
7454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * f-lang.c (evaluate_subexp_f): New function.
7457         (exp_descriptor_f): New global.
7458         (f_language_defn): Use exp_descriptor_f instead of
7459         exp_descriptor_standard.
7460
7461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7462
7463         * f-exp.y (struct token): Add comments.
7464         (dot_ops): Remove uppercase versions and the end marker.
7465         (f77_keywords): Likewise.
7466         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7467         entries in the dot_ops array are case insensitive, and use
7468         strncasecmp to compare strings.  Also some whitespace cleanup in
7469         this area.  Similar for the f77_keywords array, except entries in
7470         this list might be case sensitive.
7471
7472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7473
7474         * f-exp.y (struct f77_boolean_val): Add comments.
7475         (boolean_values): Remove uppercase versions, and end marker.
7476         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7477         and use strncasecmp to achieve case insensitivity.  Additionally,
7478         perform whitespace cleanup around this code.
7479
7480 2019-03-06  Tom Tromey  <tromey@adacore.com>
7481
7482         * remote-sim.c (gdbsim_target_open): Use result of
7483         gdb_argv::release.
7484
7485 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7486         Dirk Schubert  <dirk.schubert@arm.com>
7487         Chris January  <chris.january@arm.com>
7488
7489         * eval.c (evaluate_subexp_standard): Call Fortran argument
7490         wrapping logic.
7491         * f-lang.c (struct value): A value which can be passed into a
7492         Fortran function call.
7493         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7494         where appropriate.
7495         (struct type): Value ready for a Fortran function call.
7496         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7497         is needed.
7498         * f-lang.h (fortran_argument_convert): Declaration.
7499         (fortran_preserve_arg_pointer): Declaration.
7500         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7501
7502 2019-03-05  Tom Tromey  <tromey@adacore.com>
7503
7504         * python/py-prettyprint.c (print_string_repr): Remove #if.
7505         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7506
7507 2019-03-05  Tom Tromey  <tromey@adacore.com>
7508
7509         * target.c (the_dummy_target): Move later.  Change type to
7510         "dummy_target".
7511         (initialize_targets): Don't initialize the_dummy_target.
7512
7513 2019-03-05  Tom Tromey  <tromey@adacore.com>
7514
7515         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7516         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7517
7518 2019-03-05  Tom Tromey  <tromey@adacore.com>
7519
7520         * windows-nat.c (windows_nat_target::attach)
7521         (windows_nat_target::detach): Don't call gdb_flush.
7522         * valprint.c (generic_val_print, val_print, val_print_string):
7523         Don't call gdb_flush.
7524         * utils.c (defaulted_query): Don't call gdb_flush.
7525         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7526         * target.c (target_announce_detach): Don't call gdb_flush.
7527         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7528         * remote.c (extended_remote_target::attach): Don't call
7529         gdb_flush.
7530         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7531         * printcmd.c (do_examine): Don't call gdb_flush.
7532         (info_display_command): Don't call gdb_flush.
7533         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7534         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7535         * memattr.c (info_mem_command): Don't call gdb_flush.
7536         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7537         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7538         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7539         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7540         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7541         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7542         (gnu_nat_target::detach): Don't call gdb_flush.
7543         * f-valprint.c (f_val_print): Don't call gdb_flush.
7544         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7545         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7546         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7547         gdb_flush.
7548         * c-valprint.c (c_val_print): Don't call gdb_flush.
7549         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7550
7551 2019-03-05  Tom Tromey  <tromey@adacore.com>
7552
7553         * varobj.c (update_dynamic_varobj_children): Update.
7554         (install_default_visualizer): Use reset, not release.
7555         * value.c (set_internalvar): Update.
7556         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7557         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7558         ATTRIBUTE_UNUSED_RESULT.
7559
7560 2019-03-05  Tom Tromey  <tromey@adacore.com>
7561
7562         * remote.c (class scoped_remote_fd) <release>: Add
7563         ATTRIBUTE_UNUSED_RESULT.
7564
7565 2019-03-05  Tom Tromey  <tromey@adacore.com>
7566
7567         * macroexp.c (struct macro_buffer) <release>: Add
7568         ATTRIBUTE_UNUSED_RESULT.
7569
7570 2019-03-05  Tom Tromey  <tromey@adacore.com>
7571
7572         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7573         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7574         ATTRIBUTE_UNUSED_RESULT.
7575
7576 2019-03-05  Tom Tromey  <tromey@adacore.com>
7577
7578         * common/scoped_fd.h (class scoped_fd) <release>: Add
7579         ATTRIBUTE_UNUSED_RESULT.
7580
7581 2019-03-05  Tom Tromey  <tromey@adacore.com>
7582
7583         * parser-defs.h (struct parser_state) <release>: Add
7584         ATTRIBUTE_UNUSED_RESULT.
7585
7586 2019-03-05  Tom Tromey  <tromey@adacore.com>
7587
7588         * utils.h (class gdb_argv) <release>: Add
7589         ATTRIBUTE_UNUSED_RESULT.
7590         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7591
7592 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7593
7594         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7595         for-loop range, to avoid compiler warnings.
7596
7597         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7598         avoid compiler warnings about unused variables.
7599
7600         * NEWS: Mention end of support for native debugging on MS-Windows
7601         before XP.
7602
7603         PR gdb/24292
7604         * common/netstuff.c:
7605         * gdbserver/gdbreplay.c
7606         * gdbserver/remote-utils.c:
7607         * ser-tcp.c:
7608         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7609         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7610         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7611         'getaddrinfo' and 'freeaddrinfo' were not available before
7612         Windows XP, and mingw.org's MinGW headers by default define
7613         _WIN32_WINNT to 0x500.
7614
7615 2019-03-01  Gary Benson <gbenson@redhat.com>
7616
7617         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7618
7619 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7620             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7621
7622         PR gdb/8527
7623         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7624         set_sigint_trap, clear_sigint_trap.
7625
7626 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7627
7628         * target.c (target_detach): Clear the regcache and the
7629         frame cache.
7630
7631 2019-02-27  Pedro Alves  <palves@redhat.com>
7632
7633         * utils.c (set_screen_size): When we cap the height/width sizes,
7634         tweak the corresponding command variable to show "unlimited":
7635
7636 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7637             Pedro Alves  <palves@redhat.com>
7638
7639         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7640         before calling rl_set_screen_size.
7641
7642 2019-02-27  Tom Tromey  <tromey@adacore.com>
7643
7644         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7645         define.
7646         * python/py-value.c: Remove Python 2.4 workaround.
7647         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7648         workaround.
7649         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7650         Python 2.4 workaround.
7651         * python/python-internal.h: Remove Python 2.4 comment.
7652         (Py_ssize_t): Don't define.
7653         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7654         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7655         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7656         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7657         * python/python.c (do_start_initialization): Remove Python 2.4
7658         workaround.
7659         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7660         (print_children): Remove Python 2.4 workaround.
7661         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7662         workaround.
7663         (CHARBUFFERPROC_NAME): Remove.
7664         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7665         Python 2.4 workaround.
7666
7667 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7668
7669         * NEWS: Note minimum Python version.
7670
7671 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7672
7673         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7674         code from these functions.  Remove corresponding ifdefs.  Use
7675         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7676         Remove gotos and target of gotos.
7677         (infpy_search_memory): Likewise.
7678
7679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7682         (hppa_gdbarch_init): Don't register deleted functions with
7683         gdbarch.
7684
7685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7688         (h8300_unwind_sp): Delete.
7689         (h8300_dummy_id): Delete.
7690         (h8300_gdbarch_init): Don't register deleted functions with
7691         gdbarch.
7692
7693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7694
7695         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7696         (ft32_unwind_pc): Delete.
7697         (ft32_unwind_sp): Delete.
7698         (ft32_gdbarch_init): Don't register deleted functions with
7699         gdbarch.
7700
7701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7702
7703         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7704         (frv_unwind_pc): Delete.
7705         (frv_unwind_sp): Delete.
7706         (frv_gdbarch_init): Don't register deleted functions with
7707         gdbarch.
7708
7709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7712         (riscv_unwind_pc): Delete.
7713         (riscv_unwind_sp): Delete.
7714         (riscv_gdbarch_init): Don't register deleted functions with
7715         gdbarch.
7716
7717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7720         (csky_unwind_pc): Delete.
7721         (csky_unwind_sp): Delete.
7722         (csky_gdbarch_init): Don't register deleted functions with
7723         gdbarch.
7724
7725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7726
7727         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7728         (cris_unwind_pc): Delete.
7729         (cris_unwind_sp): Delete.
7730         (cris_gdbarch_init): Don't register deleted functions with
7731         gdbarch.
7732
7733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7734
7735         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7736         (bfin_unwind_pc): Delete.
7737         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7738
7739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7742         (arm_unwind_pc): Delete.
7743         (arm_unwind_sp): Delete.
7744         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7745
7746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7747
7748         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7749         (arc_unwind_pc): Delete.
7750         (arc_unwind_sp): Delete.
7751         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7752
7753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7756         (alpha_unwind_pc): Delete.
7757         (alpha_gdbarch_init): Don't register deleted functions with
7758         gdbarch.
7759
7760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7761
7762         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7763         (aarch64_unwind_pc): Delete.
7764         (aarch64_unwind_sp): Delete.
7765         (aarch64_gdbarch_init): Don't register deleted functions with
7766         gdbarch.
7767
7768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * gdbtypes.c (type_align): Don't consider static members when
7771         computing structure alignment.
7772
7773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7776         return 0 for other types.
7777         * arch-utils.c (default_type_align): Always return 0.
7778         * gdbarch.h: Regenerate.
7779         * gdbarch.sh (type_align): Extend comment.
7780         * gdbtypes.c (type_align): Add additional comments, always call
7781         gdbarch_type_align before applying the default rules.
7782         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7783         generic code will then apply a suitable default.
7784         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7785         types, return 0 for other types.
7786
7787 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7788
7789         * NEWS: Create a new section for the next release branch.
7790         Rename the section of the current branch, now that it has
7791         been cut.
7792
7793 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7794
7795         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7796         * version.in: Bump version to 8.3.50.DATE-git.
7797
7798 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7799
7800         * aix-thread.c (ptid_cmp): Remove unused variable.
7801         (get_signaled_thread): Likewise.
7802         (store_regs_user_thread): Likewise.
7803         (store_regs_kernel_thread): Likewise.
7804         (fetch_regs_kernel_thread): Remove shadowed variable.
7805
7806 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7807
7808         * features/riscv/32bit-cpu.xml: Add register numbers.
7809         * features/riscv/32bit-fpu.c: Regenerate.
7810         * features/riscv/32bit-fpu.xml: Add register numbers.
7811         * features/riscv/64bit-cpu.xml: Add register numbers.
7812         * features/riscv/64bit-fpu.c: Regenerate.
7813         * features/riscv/64bit-fpu.xml: Add register numbers.
7814
7815 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7816
7817         * NEWS: Mention two argument form of gdb.Value constructor.
7818         * python/py-value.c (convert_buffer_and_type_to_value): New
7819         function.
7820         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7821         Add support for handling an optional second argument.  Call
7822         convert_buffer_and_type_to_value as appropriate.
7823         * python/python-internal.h (Py_buffer_deleter): New struct.
7824         (Py_buffer_up): New typedef.
7825
7826 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7827
7828         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7829         instead of releasing ownership.
7830
7831 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7832
7833         * dwarf2read.c (open_and_init_dwp_file): Call
7834         elf_numsections instead of bfd_count_sections to initialize
7835         dwp_file->num_sections.
7836
7837 2019-02-25  Tom Tromey  <tromey@adacore.com>
7838
7839         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7840
7841 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7842
7843         * gcore.in: Add '--readnever' option when invoking GDB.
7844
7845 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7846
7847         * MAINTAINERS: Update my email address.
7848
7849 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7850
7851         * build-id.c (build_id_to_debug_bfd_1): New function.
7852         (build_id_to_debug_bfd): Look for separate debug file in
7853         sysroot.
7854
7855 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7856
7857         * gdbarch.sh: Update the copyright year range that is placed into
7858         generated files.
7859
7860 2019-02-22  Keith Seitz  <keiths@redhat.com>
7861
7862         PR symtab/23853
7863         * linespec.c (create_sals_line_offset): Search for the default
7864         symtab's filename instead of its fullname.
7865
7866 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7867
7868         * NEWS: Update style defaults.
7869
7870 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7871
7872         * main.c (captured_main_1): Disable styling in batch mode.
7873
7874 2019-02-20  Tom Tromey  <tom@tromey.com>
7875
7876         * symtab.c (symtab_symbol_info): Fix typos.
7877
7878 2019-02-20  Tom Tromey  <tromey@adacore.com>
7879
7880         * findcmd.c (_initialize_mem_search): Use upper case for
7881         metasyntactic variables.
7882
7883 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7884
7885         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7886         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7887
7888 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7889
7890         * top.h (source_file_name): Change to std::string.
7891         * top.c (source_file_name): Likewise.
7892         (command_line_input): Adjust.
7893         * cli/cli-script.c (script_from_file): Adjust.
7894
7895 2019-02-19  Tom Tromey  <tromey@adacore.com>
7896
7897         * ravenscar-thread.c
7898         (ravenscar_thread_target::update_thread_list): Don't call
7899         ada_build_task_list.
7900         * ada-lang.h (ada_build_task_list): Don't declare.
7901         * ada-tasks.c (struct ada_tasks_inferior_data)
7902         <task_list_valid_p>: Now bool.
7903         (read_known_tasks, ada_task_list_changed)
7904         (ada_tasks_invalidate_inferior_data): Update.
7905         (read_known_tasks_array): Return bool.
7906         (read_known_tasks_list): Likewise.
7907         (read_known_tasks): Return void.
7908         (ada_build_task_list): Now static.
7909
7910 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7911
7912         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7913         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7914
7915 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7916
7917         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7918         variant for ada_tasks_pspace_data_handle and
7919         ada_tasks_inferior_data_handle.
7920         (ada_tasks_pspace_data_cleanup): New function.
7921         (ada_tasks_inferior_data_cleanup): New function.
7922
7923 2019-02-17  Tom Tromey  <tom@tromey.com>
7924
7925         * macrotab.h (macro_source_fullname): Return a std::string.
7926         * macrotab.c (macro_include, check_for_redefinition)
7927         (macro_undef, macro_lookup_definition, foreach_macro)
7928         (foreach_macro_in_scope): Update.
7929         (macro_source_fullname): Return a std::string.
7930         * macrocmd.c (show_pp_source_pos): Update.
7931
7932 2019-02-17  Tom Tromey  <tom@tromey.com>
7933
7934         * macrocmd.c (show_pp_source_pos): Style the file names.
7935
7936 2019-02-17  Tom Tromey  <tom@tromey.com>
7937
7938         PR tui/24197:
7939         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7940
7941 2019-02-17  Tom Tromey  <tom@tromey.com>
7942
7943         * ada-lang.c (user_select_syms): Use filtered printing.
7944         * utils.c (wrap_style): New global.
7945         (desired_style): Remove.
7946         (emit_style_escape): Add stream parameter.
7947         (set_output_style, reset_terminal_style, prompt_for_continue):
7948         Update.
7949         (flush_wrap_buffer): Only flush gdb_stdout.
7950         (wrap_here): Set wrap_style.
7951         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7952         treat escape sequences as a character.  Change when wrap buffer is
7953         flushed.
7954         (fputs_styled): Do not set the output style when the default is
7955         requested.
7956         * ui-style.h (struct ui_file_style) <is_default>: New method.
7957         * source.c (print_source_lines_base): Emit escape sequences in one
7958         piece.
7959
7960 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7961
7962         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7963         integers and enumeration types.
7964
7965 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7966
7967         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7968         instead of lookup_symbol_in_language
7969         (do_exact_match): New function.
7970         (ada_get_symbol_name_matcher): Return do_exact_match when
7971         doing a verbatim match.
7972
7973 2019-02-15  Tom Tromey  <tromey@adacore.com>
7974
7975         * ravenscar-thread.c (ravenscar_thread_target::resume)
7976         (ravenscar_thread_target::wait): Special case wildcard requests.
7977
7978 2019-02-15  Tom Tromey  <tromey@adacore.com>
7979
7980         * ravenscar-thread.c (base_ptid): Remove.
7981         (struct ravenscar_thread_target) <close>: New method.
7982         <m_base_ptid>: New member.
7983         <update_inferior_ptid, active_task, task_is_currently_active,
7984         runtime_initialized>: Declare methods.
7985         <ravenscar_thread_target>: Add constructor.
7986         (ravenscar_thread_target::task_is_currently_active)
7987         (ravenscar_thread_target::update_inferior_ptid)
7988         (ravenscar_runtime_initialized): Rename.  Now methods.
7989         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7990         (ravenscar_thread_target::update_thread_list): Update.
7991         (ravenscar_thread_target::active_task): Now method.
7992         (ravenscar_thread_target::store_registers)
7993         (ravenscar_thread_target::prepare_to_store)
7994         (ravenscar_thread_target::prepare_to_store)
7995         (ravenscar_thread_target::mourn_inferior): Update.
7996         (ravenscar_inferior_created): Use "new" to create target.
7997         (ravenscar_thread_target::get_ada_task_ptid): Update.
7998         (_initialize_ravenscar): Don't initialize base_ptid.
7999         (ravenscar_ops): Remove global.
8000
8001 2019-02-15  Tom Tromey  <tromey@adacore.com>
8002
8003         * target.h (push_target): Declare new overload.
8004         * target.c (push_target): New overload, taking an rvalue reference.
8005         * remote.c (remote_target::open_1): Use push_target overload.
8006         * corelow.c (core_target_open): Use push_target overload.
8007
8008 2019-02-15  Tom Tromey  <tromey@adacore.com>
8009
8010         * ravenscar-thread.c (is_ravenscar_task)
8011         (ravenscar_task_is_currently_active): Return bool.
8012         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8013         (_initialize_ravenscar): Remove "(void)".
8014         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8015         Return bool.
8016
8017 2019-02-15  Tom Tromey  <tromey@adacore.com>
8018
8019         * ravenscar-thread.c (ravenscar_runtime_initializer)
8020         (has_ravenscar_runtime, get_running_thread_id)
8021         (ravenscar_thread_target::resume): Fix indentation.
8022
8023 2019-02-15  Tom Tromey  <tromey@adacore.com>
8024
8025         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8026         from ravenscar_arch_ops.
8027         (sparc_ravenscar_ops::fetch_registers)
8028         (sparc_ravenscar_ops::store_registers): Now methods.
8029         (sparc_ravenscar_prepare_to_store): Remove.
8030         (sparc_ravenscar_ops): Redefine.
8031         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8032         methods and destructor.  Remove members.
8033         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8034         (ravenscar_thread_target::store_registers)
8035         (ravenscar_thread_target::prepare_to_store): Update.
8036         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8037         Remove.
8038         (struct ppc_ravenscar_powerpc_ops): Derive from
8039         ravenscar_arch_ops.
8040         (ppc_ravenscar_powerpc_ops::fetch_registers)
8041         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8042         (ppc_ravenscar_powerpc_ops): Redefine.
8043         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8044         (ppc_ravenscar_e500_ops::fetch_registers)
8045         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8046         (ppc_ravenscar_e500_ops): Redefine.
8047         * aarch64-ravenscar-thread.c
8048         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8049         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8050         (aarch64_ravenscar_fetch_registers)
8051         (aarch64_ravenscar_store_registers): Now methods.
8052         (aarch64_ravenscar_ops): Redefine.
8053
8054 2019-02-15  Tom Tromey  <tromey@adacore.com>
8055
8056         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8057         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8058         (ravenscar_thread_target::stopped_by_watchpoint)
8059         (ravenscar_thread_target::stopped_data_address)
8060         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8061
8062 2019-02-15  Tom Tromey  <tromey@adacore.com>
8063
8064         * ravenscar-thread.c: Fix some typos.
8065
8066 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8067             Tom Tromey  <tromey@adacore.com>
8068
8069         * ada-lang.c (ada_exception_sal): Change addr_string to a
8070         std::string.
8071         (create_ada_exception_catchpoint): Update.
8072
8073 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8074             Tom Tromey  <tromey@adacore.com>
8075
8076         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8077         (bp_location_ops): Remove.
8078         (base_breakpoint_allocate_location): Update.
8079         (free_bp_location): Update.
8080         * ada-lang.c (class ada_catchpoint_location)
8081         <ada_catchpoint_location>: Remove ops parameter.
8082         (ada_catchpoint_location_dtor): Remove.
8083         (ada_catchpoint_location_ops): Remove.
8084         (allocate_location_exception): Update.
8085         * breakpoint.h (struct bp_location_ops): Remove.
8086         (class bp_location) <bp_location>: Remove bp_location_ops
8087         parameter.
8088         <~bp_location>: Add destructor.
8089         <ops>: Remove.
8090
8091 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8092             Pedro Alves  <palves@redhat.com>
8093
8094         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8095         'PATH_MAX'.
8096
8097 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8098             Samuel Thibault  <samuel.thibault@gnu.org>
8099             Thomas Schwinge  <thomas@codesourcery.com>
8100
8101         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8102         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8103
8104 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8105
8106         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8107         (check_empty): Use "const char *".
8108
8109         * gnu-nat.c (gnu_nat_target::detach): Instead of
8110         'detach_inferior (pid)' call
8111         'detach_inferior (find_inferior_pid (pid))'.
8112
8113         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8114         'nat/fork-inferior.o'.
8115         * gnu-nat.c: #include "nat/fork-inferior.h".
8116
8117         * gnu-nat.c (gnu_nat_target::detach): Instead of
8118         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8119         * gnu-nat.h: #include "inf-child.h".
8120         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8121         'i386_gnu_nat_target::fetch_registers'.
8122         (gnu_store_registers): Rename/move to
8123         'i386_gnu_nat_target::store_registers'.
8124
8125         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8126         * gnu-nat.h (mach_thread_info): New function.
8127         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8128
8129         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8130
8131 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8132
8133         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8134
8135 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8136
8137         * windows-nat.c (windows_add_thread): Add new parameter
8138         "main_thread_p" with default value set to false.  Update
8139         function documentation as well as all callers.
8140         (windows_delete_thread): Likewise.
8141         (fake_create_process): Update call to windows_add_thread.
8142         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8143         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8144         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8145         call to windows_delete_thread.
8146
8147 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8148
8149         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8150
8151 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8152
8153         * symfile.c (find_separate_debug_file): Use canonical path of
8154         sysroot with child_path instead of gdb_sysroot if it is valid.
8155
8156 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8157
8158         * symfile.c (find_separate_debug_file): Use child_path to
8159         determine if an object file is under a sysroot.
8160
8161 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8162
8163         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8164         unittests/child-path-selftests.c.
8165         * common/pathstuff.c (child_path): New function.
8166         * common/pathstuff.h (child_path): New prototype.
8167         * unittests/child-path-selftests.c: New file.
8168
8169 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8170
8171         * symfile.c (find_separate_debug_file): Look for separate debug
8172         files in debug directories under the sysroot.
8173
8174 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8175
8176         * symtab.h (struct minimal_symbol data_p): New const method.
8177         (struct minimal_symbol text_p): Likewise.
8178         * symtab.c (output_source_filename): Use file name style
8179         to print file name.
8180         (print_symbol_info): Likewise.
8181         (print_msymbol_info): Use address style to print addresses.
8182         Use function name style to print executable text symbols.
8183         (expand_symtab_containing_pc): Use data_p.
8184         (find_pc_sect_compunit_symtab): Likewise.
8185
8186 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8187
8188         * breakpoint.c (describe_other_breakpoints): Use address style
8189         to print addresses.
8190         (say_where): Likewise.
8191
8192 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8193
8194         * ada-typeprint.c (print_func_type): Print function name
8195         style to print function name.
8196         * c-typeprint.c (c_print_type_1): Likewise.
8197
8198 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8199
8200         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8201         for execve.
8202
8203 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8204
8205         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8206         type_stack.
8207
8208 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8209
8210         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8211         TYPE_CODE_REF types.
8212
8213 2019-02-08  Jim Wilson  <jimw@sifive.com>
8214
8215         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8216         (riscv_linux_fregset): New.
8217         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8218
8219 2019-02-07  Tom Tromey  <tom@tromey.com>
8220
8221         * thread.c (thread_cancel_execution_command): Update.
8222         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8223         methods.
8224         (struct thread_fsm_ops): Remove.
8225         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8226         (thread_fsm_should_stop, thread_fsm_return_value)
8227         (thread_fsm_set_finished, thread_fsm_finished_p)
8228         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8229         Don't declare.
8230         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8231         * infrun.c (clear_proceed_status_thread)
8232         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8233         (print_stop_event): Update.
8234         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8235         Add constructor.
8236         (step_command_fsm_ops): Remove.
8237         (new_step_command_fsm): Remove.
8238         (step_1): Update.
8239         (step_command_fsm::should_stop): Rename from
8240         step_command_fsm_should_stop.
8241         (step_command_fsm::clean_up): Rename from
8242         step_command_fsm_clean_up.
8243         (step_command_fsm::do_async_reply_reason): Rename from
8244         step_command_fsm_async_reply_reason.
8245         (struct until_next_fsm): Inherit from thread_fsm.  Add
8246         constructor.
8247         (until_next_fsm_ops): Remove.
8248         (new_until_next_fsm): Remove.
8249         (until_next_fsm::should_stop): Rename from
8250         until_next_fsm_should_stop.
8251         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8252         (until_next_fsm::do_async_reply_reason): Rename from
8253         until_next_fsm_async_reply_reason.
8254         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8255         constructor.  Change type of breakpoint.
8256         (finish_command_fsm_ops): Remove.
8257         (new_finish_command_fsm): Remove.
8258         (finish_command_fsm::should_stop): Rename from
8259         finish_command_fsm_should_stop.
8260         (finish_command_fsm::clean_up): Rename from
8261         finish_command_fsm_clean_up.
8262         (finish_command_fsm::return_value): Rename from
8263         finish_command_fsm_return_value.
8264         (finish_command_fsm::do_async_reply_reason): Rename from
8265         finish_command_fsm_async_reply_reason.
8266         (finish_command): Update.
8267         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8268         Add constructor.
8269         (call_thread_fsm_ops): Remove.
8270         (call_thread_fsm::call_thread_fsm): Rename from
8271         new_call_thread_fsm.
8272         (call_thread_fsm::should_stop): Rename from
8273         call_thread_fsm_should_stop.
8274         (call_thread_fsm::should_notify_stop): Rename from
8275         call_thread_fsm_should_notify_stop.
8276         (run_inferior_call, call_function_by_hand_dummy): Update.
8277         * cli/cli-interp.c (should_print_stop_to_console): Update.
8278         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8279         Add constructor.  Change type of location_breakpoint,
8280         caller_breakpoint.
8281         (until_break_fsm_ops): Remove.
8282         (new_until_break_fsm): Remove.
8283         (until_break_fsm::should_stop): Rename from
8284         until_break_fsm_should_stop.
8285         (until_break_fsm::clean_up): Rename from
8286         until_break_fsm_clean_up.
8287         (until_break_fsm::do_async_reply_reason): Rename from
8288         until_break_fsm_async_reply_reason.
8289         (until_break_command): Update.
8290         * thread-fsm.c: Remove.
8291         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8292
8293 2019-02-07  Tom Tromey  <tom@tromey.com>
8294
8295         * yy-remap.h: Add include guard.
8296         * xtensa-tdep.h: Add include guard.
8297         * xcoffread.h: Rename include guard.
8298         * varobj-iter.h: Add include guard.
8299         * tui/tui.h: Rename include guard.
8300         * tui/tui-winsource.h: Rename include guard.
8301         * tui/tui-wingeneral.h: Rename include guard.
8302         * tui/tui-windata.h: Rename include guard.
8303         * tui/tui-win.h: Rename include guard.
8304         * tui/tui-stack.h: Rename include guard.
8305         * tui/tui-source.h: Rename include guard.
8306         * tui/tui-regs.h: Rename include guard.
8307         * tui/tui-out.h: Rename include guard.
8308         * tui/tui-layout.h: Rename include guard.
8309         * tui/tui-io.h: Rename include guard.
8310         * tui/tui-hooks.h: Rename include guard.
8311         * tui/tui-file.h: Rename include guard.
8312         * tui/tui-disasm.h: Rename include guard.
8313         * tui/tui-data.h: Rename include guard.
8314         * tui/tui-command.h: Rename include guard.
8315         * tic6x-tdep.h: Add include guard.
8316         * target/waitstatus.h: Rename include guard.
8317         * target/wait.h: Rename include guard.
8318         * target/target.h: Rename include guard.
8319         * target/resume.h: Rename include guard.
8320         * target-float.h: Rename include guard.
8321         * stabsread.h: Add include guard.
8322         * rs6000-tdep.h: Add include guard.
8323         * riscv-fbsd-tdep.h: Add include guard.
8324         * regformats/regdef.h: Rename include guard.
8325         * record.h: Rename include guard.
8326         * python/python.h: Rename include guard.
8327         * python/python-internal.h: Rename include guard.
8328         * python/py-stopevent.h: Rename include guard.
8329         * python/py-ref.h: Rename include guard.
8330         * python/py-record.h: Rename include guard.
8331         * python/py-record-full.h: Rename include guard.
8332         * python/py-record-btrace.h: Rename include guard.
8333         * python/py-instruction.h: Rename include guard.
8334         * python/py-events.h: Rename include guard.
8335         * python/py-event.h: Rename include guard.
8336         * procfs.h: Add include guard.
8337         * proc-utils.h: Add include guard.
8338         * p-lang.h: Add include guard.
8339         * or1k-tdep.h: Rename include guard.
8340         * observable.h: Rename include guard.
8341         * nto-tdep.h: Rename include guard.
8342         * nat/x86-linux.h: Rename include guard.
8343         * nat/x86-linux-dregs.h: Rename include guard.
8344         * nat/x86-gcc-cpuid.h: Add include guard.
8345         * nat/x86-dregs.h: Rename include guard.
8346         * nat/x86-cpuid.h: Rename include guard.
8347         * nat/ppc-linux.h: Rename include guard.
8348         * nat/mips-linux-watch.h: Rename include guard.
8349         * nat/linux-waitpid.h: Rename include guard.
8350         * nat/linux-ptrace.h: Rename include guard.
8351         * nat/linux-procfs.h: Rename include guard.
8352         * nat/linux-osdata.h: Rename include guard.
8353         * nat/linux-nat.h: Rename include guard.
8354         * nat/linux-namespaces.h: Rename include guard.
8355         * nat/linux-btrace.h: Rename include guard.
8356         * nat/glibc_thread_db.h: Rename include guard.
8357         * nat/gdb_thread_db.h: Rename include guard.
8358         * nat/gdb_ptrace.h: Rename include guard.
8359         * nat/fork-inferior.h: Rename include guard.
8360         * nat/amd64-linux-siginfo.h: Rename include guard.
8361         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8362         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8363         * nat/aarch64-linux.h: Rename include guard.
8364         * nat/aarch64-linux-hw-point.h: Rename include guard.
8365         * mn10300-tdep.h: Add include guard.
8366         * mips-linux-tdep.h: Add include guard.
8367         * mi/mi-parse.h: Rename include guard.
8368         * mi/mi-out.h: Rename include guard.
8369         * mi/mi-main.h: Rename include guard.
8370         * mi/mi-interp.h: Rename include guard.
8371         * mi/mi-getopt.h: Rename include guard.
8372         * mi/mi-console.h: Rename include guard.
8373         * mi/mi-common.h: Rename include guard.
8374         * mi/mi-cmds.h: Rename include guard.
8375         * mi/mi-cmd-break.h: Rename include guard.
8376         * m2-lang.h: Add include guard.
8377         * location.h: Rename include guard.
8378         * linux-record.h: Rename include guard.
8379         * linux-nat.h: Add include guard.
8380         * linux-fork.h: Add include guard.
8381         * i386-darwin-tdep.h: Rename include guard.
8382         * hppa-linux-offsets.h: Add include guard.
8383         * guile/guile.h: Rename include guard.
8384         * guile/guile-internal.h: Rename include guard.
8385         * gnu-nat.h: Rename include guard.
8386         * gdb-stabs.h: Rename include guard.
8387         * frv-tdep.h: Add include guard.
8388         * f-lang.h: Add include guard.
8389         * event-loop.h: Add include guard.
8390         * darwin-nat.h: Rename include guard.
8391         * cp-abi.h: Rename include guard.
8392         * config/sparc/nm-sol2.h: Rename include guard.
8393         * config/nm-nto.h: Rename include guard.
8394         * config/nm-linux.h: Add include guard.
8395         * config/i386/nm-i386gnu.h: Rename include guard.
8396         * config/djgpp/nl_types.h: Rename include guard.
8397         * config/djgpp/langinfo.h: Rename include guard.
8398         * compile/gcc-cp-plugin.h: Add include guard.
8399         * compile/gcc-c-plugin.h: Add include guard.
8400         * compile/compile.h: Rename include guard.
8401         * compile/compile-object-run.h: Rename include guard.
8402         * compile/compile-object-load.h: Rename include guard.
8403         * compile/compile-internal.h: Rename include guard.
8404         * compile/compile-cplus.h: Rename include guard.
8405         * compile/compile-c.h: Rename include guard.
8406         * common/xml-utils.h: Rename include guard.
8407         * common/x86-xstate.h: Rename include guard.
8408         * common/version.h: Rename include guard.
8409         * common/vec.h: Rename include guard.
8410         * common/tdesc.h: Rename include guard.
8411         * common/selftest.h: Rename include guard.
8412         * common/scoped_restore.h: Rename include guard.
8413         * common/scoped_mmap.h: Rename include guard.
8414         * common/scoped_fd.h: Rename include guard.
8415         * common/safe-iterator.h: Rename include guard.
8416         * common/run-time-clock.h: Rename include guard.
8417         * common/refcounted-object.h: Rename include guard.
8418         * common/queue.h: Rename include guard.
8419         * common/ptid.h: Rename include guard.
8420         * common/print-utils.h: Rename include guard.
8421         * common/preprocessor.h: Rename include guard.
8422         * common/pathstuff.h: Rename include guard.
8423         * common/observable.h: Rename include guard.
8424         * common/netstuff.h: Rename include guard.
8425         * common/job-control.h: Rename include guard.
8426         * common/host-defs.h: Rename include guard.
8427         * common/gdb_wait.h: Rename include guard.
8428         * common/gdb_vecs.h: Rename include guard.
8429         * common/gdb_unlinker.h: Rename include guard.
8430         * common/gdb_unique_ptr.h: Rename include guard.
8431         * common/gdb_tilde_expand.h: Rename include guard.
8432         * common/gdb_sys_time.h: Rename include guard.
8433         * common/gdb_string_view.h: Rename include guard.
8434         * common/gdb_splay_tree.h: Rename include guard.
8435         * common/gdb_setjmp.h: Rename include guard.
8436         * common/gdb_ref_ptr.h: Rename include guard.
8437         * common/gdb_optional.h: Rename include guard.
8438         * common/gdb_locale.h: Rename include guard.
8439         * common/gdb_assert.h: Rename include guard.
8440         * common/filtered-iterator.h: Rename include guard.
8441         * common/filestuff.h: Rename include guard.
8442         * common/fileio.h: Rename include guard.
8443         * common/environ.h: Rename include guard.
8444         * common/common-utils.h: Rename include guard.
8445         * common/common-types.h: Rename include guard.
8446         * common/common-regcache.h: Rename include guard.
8447         * common/common-inferior.h: Rename include guard.
8448         * common/common-gdbthread.h: Rename include guard.
8449         * common/common-exceptions.h: Rename include guard.
8450         * common/common-defs.h: Rename include guard.
8451         * common/common-debug.h: Rename include guard.
8452         * common/cleanups.h: Rename include guard.
8453         * common/buffer.h: Rename include guard.
8454         * common/btrace-common.h: Rename include guard.
8455         * common/break-common.h: Rename include guard.
8456         * cli/cli-utils.h: Rename include guard.
8457         * cli/cli-style.h: Rename include guard.
8458         * cli/cli-setshow.h: Rename include guard.
8459         * cli/cli-script.h: Rename include guard.
8460         * cli/cli-interp.h: Rename include guard.
8461         * cli/cli-decode.h: Rename include guard.
8462         * cli/cli-cmds.h: Rename include guard.
8463         * charset-list.h: Add include guard.
8464         * buildsym-legacy.h: Rename include guard.
8465         * bfin-tdep.h: Add include guard.
8466         * ax.h: Rename include guard.
8467         * arm-linux-tdep.h: Add include guard.
8468         * arm-fbsd-tdep.h: Add include guard.
8469         * arch/xtensa.h: Rename include guard.
8470         * arch/tic6x.h: Add include guard.
8471         * arch/i386.h: Add include guard.
8472         * arch/arm.h: Rename include guard.
8473         * arch/arm-linux.h: Rename include guard.
8474         * arch/arm-get-next-pcs.h: Rename include guard.
8475         * arch/amd64.h: Add include guard.
8476         * arch/aarch64-insn.h: Rename include guard.
8477         * arch-utils.h: Rename include guard.
8478         * annotate.h: Add include guard.
8479         * amd64-darwin-tdep.h: Rename include guard.
8480         * aarch64-linux-tdep.h: Add include guard.
8481         * aarch64-fbsd-tdep.h: Add include guard.
8482         * aarch32-linux-nat.h: Add include guard.
8483
8484 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8485
8486         * macrotab.c (macro_define_internal): New function that
8487         factorizes macro_define_object_internal and macro_define_function
8488         code.
8489         (macro_define_object_internal): Use macro_define_internal.
8490         (macro_define_function): Likewise.
8491
8492 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8493
8494         * macrocmd.c (extract_identifier): Return
8495         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8496         callers.
8497
8498 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8499
8500         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8501
8502 2019-02-05  Tom Tromey  <tom@tromey.com>
8503
8504         * target.c (target_stack::unpush): Move assertion earlier.
8505
8506 2019-01-30  Tom Tromey  <tom@tromey.com>
8507
8508         PR python/23615:
8509         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8510         (gdbpy_parse_and_eval): Likewise.
8511         * python/python-internal.h (gdbpy_allow_threads): New class.
8512
8513 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8514
8515         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8516         (aarch64_fbsd_fpregmap): Move earlier.
8517         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8518         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8519         instead of individual calls to trad_frame_set_reg_addr.
8520         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8521         earlier.
8522         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8523         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8524         instead of individual calls to trad_frame_set_reg_addr.
8525
8526 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8527
8528         * CONTRIBUTE: Replace contribution list with wiki link.
8529
8530 2019-01-25  Tom Tromey  <tom@tromey.com>
8531
8532         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8533
8534 2019-01-25  Tom Tromey  <tom@tromey.com>
8535
8536         * xtensa-linux-nat.c: Fix common/ includes.
8537         * xml-support.h: Fix common/ includes.
8538         * xml-support.c: Fix common/ includes.
8539         * x86-linux-nat.c: Fix common/ includes.
8540         * windows-nat.c: Fix common/ includes.
8541         * varobj.h: Fix common/ includes.
8542         * varobj.c: Fix common/ includes.
8543         * value.c: Fix common/ includes.
8544         * valops.c: Fix common/ includes.
8545         * utils.c: Fix common/ includes.
8546         * unittests/xml-utils-selftests.c: Fix common/ includes.
8547         * unittests/utils-selftests.c: Fix common/ includes.
8548         * unittests/unpack-selftests.c: Fix common/ includes.
8549         * unittests/tracepoint-selftests.c: Fix common/ includes.
8550         * unittests/style-selftests.c: Fix common/ includes.
8551         * unittests/string_view-selftests.c: Fix common/ includes.
8552         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8553         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8554         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8555         * unittests/rsp-low-selftests.c: Fix common/ includes.
8556         * unittests/parse-connection-spec-selftests.c: Fix common/
8557         includes.
8558         * unittests/optional-selftests.c: Fix common/ includes.
8559         * unittests/offset-type-selftests.c: Fix common/ includes.
8560         * unittests/observable-selftests.c: Fix common/ includes.
8561         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8562         * unittests/memrange-selftests.c: Fix common/ includes.
8563         * unittests/memory-map-selftests.c: Fix common/ includes.
8564         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8565         * unittests/function-view-selftests.c: Fix common/ includes.
8566         * unittests/environ-selftests.c: Fix common/ includes.
8567         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8568         * unittests/common-utils-selftests.c: Fix common/ includes.
8569         * unittests/cli-utils-selftests.c: Fix common/ includes.
8570         * unittests/array-view-selftests.c: Fix common/ includes.
8571         * ui-file.c: Fix common/ includes.
8572         * tui/tui-io.c: Fix common/ includes.
8573         * tracepoint.h: Fix common/ includes.
8574         * tracepoint.c: Fix common/ includes.
8575         * tracefile-tfile.c: Fix common/ includes.
8576         * top.h: Fix common/ includes.
8577         * top.c: Fix common/ includes.
8578         * thread.c: Fix common/ includes.
8579         * target/waitstatus.h: Fix common/ includes.
8580         * target/waitstatus.c: Fix common/ includes.
8581         * target.h: Fix common/ includes.
8582         * target.c: Fix common/ includes.
8583         * target-memory.c: Fix common/ includes.
8584         * target-descriptions.c: Fix common/ includes.
8585         * symtab.h: Fix common/ includes.
8586         * symfile.c: Fix common/ includes.
8587         * stap-probe.c: Fix common/ includes.
8588         * spu-linux-nat.c: Fix common/ includes.
8589         * sparc-nat.c: Fix common/ includes.
8590         * source.c: Fix common/ includes.
8591         * solib.c: Fix common/ includes.
8592         * solib-target.c: Fix common/ includes.
8593         * ser-unix.c: Fix common/ includes.
8594         * ser-tcp.c: Fix common/ includes.
8595         * ser-pipe.c: Fix common/ includes.
8596         * ser-base.c: Fix common/ includes.
8597         * selftest-arch.c: Fix common/ includes.
8598         * s12z-tdep.c: Fix common/ includes.
8599         * rust-exp.y: Fix common/ includes.
8600         * rs6000-aix-tdep.c: Fix common/ includes.
8601         * riscv-tdep.c: Fix common/ includes.
8602         * remote.c: Fix common/ includes.
8603         * remote-notif.h: Fix common/ includes.
8604         * remote-fileio.h: Fix common/ includes.
8605         * remote-fileio.c: Fix common/ includes.
8606         * regcache.h: Fix common/ includes.
8607         * regcache.c: Fix common/ includes.
8608         * record-btrace.c: Fix common/ includes.
8609         * python/python.c: Fix common/ includes.
8610         * python/py-type.c: Fix common/ includes.
8611         * python/py-inferior.c: Fix common/ includes.
8612         * progspace.h: Fix common/ includes.
8613         * producer.c: Fix common/ includes.
8614         * procfs.c: Fix common/ includes.
8615         * proc-api.c: Fix common/ includes.
8616         * printcmd.c: Fix common/ includes.
8617         * ppc-linux-nat.c: Fix common/ includes.
8618         * parser-defs.h: Fix common/ includes.
8619         * osdata.c: Fix common/ includes.
8620         * obsd-nat.c: Fix common/ includes.
8621         * nat/x86-linux.c: Fix common/ includes.
8622         * nat/x86-linux-dregs.c: Fix common/ includes.
8623         * nat/x86-dregs.h: Fix common/ includes.
8624         * nat/x86-dregs.c: Fix common/ includes.
8625         * nat/ppc-linux.c: Fix common/ includes.
8626         * nat/mips-linux-watch.h: Fix common/ includes.
8627         * nat/mips-linux-watch.c: Fix common/ includes.
8628         * nat/linux-waitpid.c: Fix common/ includes.
8629         * nat/linux-ptrace.h: Fix common/ includes.
8630         * nat/linux-ptrace.c: Fix common/ includes.
8631         * nat/linux-procfs.c: Fix common/ includes.
8632         * nat/linux-personality.c: Fix common/ includes.
8633         * nat/linux-osdata.c: Fix common/ includes.
8634         * nat/linux-namespaces.c: Fix common/ includes.
8635         * nat/linux-btrace.h: Fix common/ includes.
8636         * nat/linux-btrace.c: Fix common/ includes.
8637         * nat/fork-inferior.c: Fix common/ includes.
8638         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8639         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8640         * nat/aarch64-linux.c: Fix common/ includes.
8641         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8642         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8643         * namespace.h: Fix common/ includes.
8644         * mips-linux-tdep.c: Fix common/ includes.
8645         * minsyms.c: Fix common/ includes.
8646         * mi/mi-parse.h: Fix common/ includes.
8647         * mi/mi-main.c: Fix common/ includes.
8648         * mi/mi-cmd-env.c: Fix common/ includes.
8649         * memrange.h: Fix common/ includes.
8650         * memattr.c: Fix common/ includes.
8651         * maint.h: Fix common/ includes.
8652         * maint.c: Fix common/ includes.
8653         * main.c: Fix common/ includes.
8654         * machoread.c: Fix common/ includes.
8655         * location.c: Fix common/ includes.
8656         * linux-thread-db.c: Fix common/ includes.
8657         * linux-nat.c: Fix common/ includes.
8658         * linux-fork.c: Fix common/ includes.
8659         * inline-frame.c: Fix common/ includes.
8660         * infrun.c: Fix common/ includes.
8661         * inflow.c: Fix common/ includes.
8662         * inferior.h: Fix common/ includes.
8663         * inferior.c: Fix common/ includes.
8664         * infcmd.c: Fix common/ includes.
8665         * inf-ptrace.c: Fix common/ includes.
8666         * inf-child.c: Fix common/ includes.
8667         * ia64-linux-nat.c: Fix common/ includes.
8668         * i387-tdep.c: Fix common/ includes.
8669         * i386-tdep.c: Fix common/ includes.
8670         * i386-linux-tdep.c: Fix common/ includes.
8671         * i386-linux-nat.c: Fix common/ includes.
8672         * i386-go32-tdep.c: Fix common/ includes.
8673         * i386-fbsd-tdep.c: Fix common/ includes.
8674         * i386-fbsd-nat.c: Fix common/ includes.
8675         * guile/scm-type.c: Fix common/ includes.
8676         * guile/guile.c: Fix common/ includes.
8677         * go32-nat.c: Fix common/ includes.
8678         * gnu-nat.c: Fix common/ includes.
8679         * gdbthread.h: Fix common/ includes.
8680         * gdbarch-selftests.c: Fix common/ includes.
8681         * gdb_usleep.c: Fix common/ includes.
8682         * gdb_select.h: Fix common/ includes.
8683         * gdb_bfd.c: Fix common/ includes.
8684         * gcore.c: Fix common/ includes.
8685         * fork-child.c: Fix common/ includes.
8686         * findvar.c: Fix common/ includes.
8687         * fbsd-nat.c: Fix common/ includes.
8688         * event-top.c: Fix common/ includes.
8689         * event-loop.c: Fix common/ includes.
8690         * dwarf2read.c: Fix common/ includes.
8691         * dwarf2loc.c: Fix common/ includes.
8692         * dwarf2-frame.c: Fix common/ includes.
8693         * dwarf-index-cache.c: Fix common/ includes.
8694         * dtrace-probe.c: Fix common/ includes.
8695         * disasm-selftests.c: Fix common/ includes.
8696         * defs.h: Fix common/ includes.
8697         * csky-tdep.c: Fix common/ includes.
8698         * cp-valprint.c: Fix common/ includes.
8699         * cp-support.h: Fix common/ includes.
8700         * cp-support.c: Fix common/ includes.
8701         * corelow.c: Fix common/ includes.
8702         * completer.h: Fix common/ includes.
8703         * completer.c: Fix common/ includes.
8704         * compile/compile.c: Fix common/ includes.
8705         * compile/compile-loc2c.c: Fix common/ includes.
8706         * compile/compile-cplus-types.c: Fix common/ includes.
8707         * compile/compile-cplus-symbols.c: Fix common/ includes.
8708         * command.h: Fix common/ includes.
8709         * cli/cli-dump.c: Fix common/ includes.
8710         * cli/cli-cmds.c: Fix common/ includes.
8711         * charset.c: Fix common/ includes.
8712         * build-id.c: Fix common/ includes.
8713         * btrace.h: Fix common/ includes.
8714         * btrace.c: Fix common/ includes.
8715         * breakpoint.h: Fix common/ includes.
8716         * breakpoint.c: Fix common/ includes.
8717         * ax.h:
8718         (enum agent_op): Fix common/ includes.
8719         * ax-general.c (struct aop_map): Fix common/ includes.
8720         * ax-gdb.c: Fix common/ includes.
8721         * auxv.c: Fix common/ includes.
8722         * auto-load.c: Fix common/ includes.
8723         * arm-tdep.c: Fix common/ includes.
8724         * arch/riscv.c: Fix common/ includes.
8725         * arch/ppc-linux-common.c: Fix common/ includes.
8726         * arch/i386.c: Fix common/ includes.
8727         * arch/arm.c: Fix common/ includes.
8728         * arch/arm-linux.c: Fix common/ includes.
8729         * arch/arm-get-next-pcs.c: Fix common/ includes.
8730         * arch/amd64.c: Fix common/ includes.
8731         * arch/aarch64.c: Fix common/ includes.
8732         * arch/aarch64-insn.c: Fix common/ includes.
8733         * arch-utils.c: Fix common/ includes.
8734         * amd64-windows-tdep.c: Fix common/ includes.
8735         * amd64-tdep.c: Fix common/ includes.
8736         * amd64-sol2-tdep.c: Fix common/ includes.
8737         * amd64-obsd-tdep.c: Fix common/ includes.
8738         * amd64-nbsd-tdep.c: Fix common/ includes.
8739         * amd64-linux-tdep.c: Fix common/ includes.
8740         * amd64-linux-nat.c: Fix common/ includes.
8741         * amd64-fbsd-tdep.c: Fix common/ includes.
8742         * amd64-fbsd-nat.c: Fix common/ includes.
8743         * amd64-dicos-tdep.c: Fix common/ includes.
8744         * amd64-darwin-tdep.c: Fix common/ includes.
8745         * agent.c: Fix common/ includes.
8746         * ada-lang.h: Fix common/ includes.
8747         * ada-lang.c: Fix common/ includes.
8748         * aarch64-tdep.c: Fix common/ includes.
8749
8750 2019-01-25  Tom Tromey  <tom@tromey.com>
8751
8752         * common/create-version.sh: Use common/version.h.
8753
8754 2019-01-24  Pedro Alves  <palves@redhat.com>
8755
8756         * infrun.c (signal_stop, signal_print, signal_program)
8757         (signal_catch, signal_pass): Now arrays instead of pointers.
8758         (update_signals_program_target, do_target_resume)
8759         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8760         * linux-nat.c (linux_nat_target::pass_signals)
8761         (linux_nat_target::create_inferior, linux_nat_target::attach):
8762         Adjust.
8763         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8764         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8765         * procfs.c (procfs_target::pass_signals): Adjust.
8766         * record-full.c (record_full_target::resume): Adjust.
8767         * remote.c (remote_target::pass_signals)
8768         (remote_target::program_signals): Adjust.
8769         * target-debug.h (target_debug_print_signals): Now takes a
8770         gdb::array_view as parameter.  Adjust.
8771         * target.h (target_ops) <pass_signals, program_signals>: Replace
8772         pointer and length parameters with gdb::array_view.
8773         (target_pass_signals, target_program_signals): Likewise.
8774         * target-delegates.c: Regenerate.
8775
8776 2019-01-24  Pedro Alves  <palves@redhat.com>
8777
8778         * common/forward-scope-exit.h
8779         (forward_scope_exit::forward_scope_exit): Pass arguments to
8780         m_bind_function directly, instead of creating a std::bind and
8781         copying that.
8782
8783 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8784
8785         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8786         for static members.
8787         (pass_in_v_vfp_candidate): Likewise.
8788
8789 2019-01-23  Tom Tromey  <tom@tromey.com>
8790             Pedro Alves  <palves@redhat.com>
8791
8792         * regcache.c (class regcache_invalidator): Remove.
8793         (regcache::raw_write): Use make_scope_exit.
8794
8795 2019-01-23  Tom Tromey  <tom@tromey.com>
8796
8797         * ui-out.h (class ui_out_emit_type): Update comment.
8798
8799 2019-01-23  Tom Tromey  <tom@tromey.com>
8800
8801         * infrun.c (fetch_inferior_event): Update comment.
8802
8803 2019-01-23  Tom Tromey  <tom@tromey.com>
8804             Pedro Alves  <palves@redhat.com>
8805
8806         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8807         parameter.
8808         (fetch_inferior_event): Use SCOPE_EXIT.
8809
8810
8811 2019-01-23  Tom Tromey  <tom@tromey.com>
8812             Pedro Alves  <palves@redhat.com>
8813
8814         * infrun.c (disable_thread_events): Delete.
8815         (stop_all_threads): Use SCOPE_EXIT.
8816
8817 2019-01-23  Tom Tromey  <tom@tromey.com>
8818             Pedro Alves  <palves@redhat.com>
8819
8820         * symfile.c: Include forward-scope-exit.h.
8821         (clear_symtab_users_cleanup): Replace forward declaration with
8822         a FORWARD_SCOPE_EXIT.
8823         (syms_from_objfile_1): Use the forward_scope_exit and
8824         gdb::optional instead of cleanup_function.
8825         (reread_symbols): Use the forward_scope_exit instead of
8826         cleanup_function.
8827         (clear_symtab_users_cleanup): Remove function.
8828
8829 2019-01-23  Tom Tromey  <tom@tromey.com>
8830             Pedro Alves  <palves@redhat.com>
8831
8832         * linux-nat.c: Include scope-exit.h.
8833         (cleanup_target_stop): Remove.
8834         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8835         SCOPE_EXIT.
8836
8837 2019-01-23  Tom Tromey  <tom@tromey.com>
8838             Pedro Alves  <palves@redhat.com>
8839
8840         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8841         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8842
8843 2019-01-23  Tom Tromey  <tom@tromey.com>
8844             Andrew Burgess  <andrew.burgess@embecosm.com>
8845             Pedro Alves  <palves@redhat.com>
8846
8847         * infrun.c (fetch_inferior_event): Use scope_exit.
8848         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8849         * top.c (execute_command): Use scope_exit.
8850         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8851         * utils.c (do_bpstat_clear_actions_cleanup)
8852         (make_bpstat_clear_actions_cleanup): Remove.
8853
8854 2019-01-23  Tom Tromey  <tom@tromey.com>
8855             Pedro Alves  <palves@redhat.com>
8856
8857         * infrun.c: Include "common/scope-exit.h"
8858         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8859         (wait_for_inferior): Use SCOPE_EXIT.
8860         (fetch_inferior_event): Use scope_exit.
8861
8862 2019-01-23  Tom Tromey  <tom@tromey.com>
8863             Pedro Alves  <palves@redhat.com>
8864
8865         * breakpoint.c (create_breakpoint): Remove cleanup.
8866
8867 2019-01-23  Tom Tromey  <tom@tromey.com>
8868             Andrew Burgess  <andrew.burgess@embecosm.com>
8869             Pedro Alves  <palves@redhat.com>
8870
8871 2019-01-23  Pedro Alves  <palves@redhat.com>
8872
8873         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8874
8875 2019-01-23  Pedro Alves  <palves@redhat.com>
8876             Andrew Burgess  <andrew.burgess@embecosm.com>
8877
8878         * gdbthread.h: Include "common/forward-scope-exit.h".
8879         (scoped_finish_thread_state): Redefine custom class in terms of
8880         forward_scope_exit.
8881
8882 2019-01-23  Pedro Alves  <palves@redhat.com>
8883             Andrew Burgess  <andrew.burgess@embecosm.com>
8884
8885         * common/forward-scope-exit.h: New file.
8886
8887 2019-01-23  Pedro Alves  <palves@redhat.com>
8888             Andrew Burgess  <andrew.burgess@embecosm.com>
8889             Tom Tromey  <tom@tromey.com>
8890
8891         * common/scope-exit.h: New file.
8892
8893 2019-01-23  Pedro Alves  <palves@redhat.com>
8894
8895         * common/preprocessor.h (ESC): Rename to ...
8896         (ESC_PARENS): ... this.
8897         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8898         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8899
8900 2019-01-23  Tom Tromey  <tom@tromey.com>
8901
8902         * language.h (class scoped_switch_to_sym_language_if_auto):
8903         Initialize m_lang in both cases.
8904
8905 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8906
8907         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8908         with XCNEW.
8909
8910 2019-01-22  Tom Tromey  <tom@tromey.com>
8911
8912         * corelow.c: Do not include sys/file.h.
8913
8914 2019-01-22  Tom Tromey  <tom@tromey.com>
8915
8916         * tui/tui-wingeneral.h: Include gdb_curses.h.
8917
8918 2019-01-22  Tom Tromey  <tom@tromey.com>
8919
8920         * source-cache.h (class source_cache) <get_source_lines,
8921         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8922
8923 2019-01-22  Tom Tromey  <tom@tromey.com>
8924
8925         * remote-fileio.h (struct remote_target): Declare.
8926
8927 2019-01-22  Tom Tromey  <tom@tromey.com>
8928
8929         * python/py-arch.c: Do not include py-ref.h.
8930         * python/py-bpevent.c: Do not include py-ref.h.
8931         * python/py-cmd.c: Do not include py-ref.h.
8932         * python/py-continueevent.c: Do not include py-ref.h.
8933         * python/py-event.h: Do not include py-ref.h.
8934         * python/py-evtregistry.c: Do not include py-ref.h.
8935         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8936         * python/py-frame.c: Do not include py-ref.h.
8937         * python/py-framefilter.c: Do not include py-ref.h.
8938         * python/py-function.c: Do not include py-ref.h.
8939         * python/py-infevents.c: Do not include py-ref.h.
8940         * python/py-linetable.c: Do not include py-ref.h.
8941         * python/py-objfile.c: Do not include py-ref.h.
8942         * python/py-param.c: Do not include py-ref.h.
8943         * python/py-prettyprint.c: Do not include py-ref.h.
8944         * python/py-progspace.c: Do not include py-ref.h.
8945         * python/py-symbol.c: Do not include py-ref.h.
8946         * python/py-symtab.c: Do not include py-ref.h.
8947         * python/py-type.c: Do not include py-ref.h.
8948         * python/py-unwind.c: Do not include py-ref.h.
8949         * python/py-utils.c: Do not include py-ref.h.
8950         * python/py-value.c: Do not include py-ref.h.
8951         * python/py-varobj.c: Do not include py-ref.h.
8952         * python/py-xmethods.c: Do not include py-ref.h.
8953         * python/python.c: Do not include py-ref.h.
8954         * varobj.c: Do not include py-ref.h.
8955
8956 2019-01-22  Tom Tromey  <tom@tromey.com>
8957
8958         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8959         keyword for bcache.
8960
8961 2019-01-22  Tom Tromey  <tom@tromey.com>
8962
8963         * compile/compile-cplus-types.c: Remove a comment by #include.
8964
8965 2019-01-22  Tom Tromey  <tom@tromey.com>
8966
8967         * compile/gcc-c-plugin.h: Include compile-internal.h.
8968
8969 2019-01-22  Tom Tromey  <tom@tromey.com>
8970
8971         * stabsread.c (EXTERN): Do not define.
8972         (symnum, next_symbol_text_func, processing_gcc_compilation)
8973         (within_function, global_sym_chain, global_stabs)
8974         (previous_stab_code, this_object_header_files)
8975         (n_this_object_header_files)
8976         (n_allocated_this_object_header_files): Define.
8977         * stabsread.h (EXTERN): Never define.  Use "extern".
8978
8979 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8980
8981         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8982         history_value.
8983
8984 2019-01-21  Tom Tromey  <tom@tromey.com>
8985
8986         * ui-out.c: Fix includes.
8987         * tui/tui-source.c: Fix includes.
8988         * target.c: Fix includes.
8989         * remote.c: Fix includes.
8990         * regcache.c: Fix includes.
8991         * python/py-block.c: Fix includes.
8992         * printcmd.c: Fix includes.
8993         * or1k-tdep.c: Fix includes.
8994         * mi/mi-main.c: Fix includes.
8995         * m32r-tdep.c: Fix includes.
8996         * csky-tdep.c: Fix includes.
8997         * compile/compile-cplus-types.c: Fix includes.
8998         * cli/cli-interp.c: Fix includes.
8999
9000 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9001
9002         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9003         for padding.
9004
9005 2019-01-16  Tom Tromey  <tom@tromey.com>
9006
9007         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9008         earlier.
9009         (struct objfile) <msymbols_range>: Move from top level.
9010         <msymbols>: New method.
9011         (class objfile_msymbols): Remove.
9012         * symtab.c (default_collect_symbol_completion_matches_break_on):
9013         Update.
9014         * symmisc.c (dump_msymbols): Update.
9015         * stabsread.c (scan_file_globals): Update.
9016         * objc-lang.c (info_selectors_command, info_classes_command)
9017         (find_methods): Update.
9018         * minsyms.c (find_solib_trampoline_target): Update.
9019         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9020         * coffread.c (coff_symfile_read): Update.
9021         * ada-lang.c (ada_lookup_simple_minsym)
9022         (ada_collect_symbol_completion_matches): Update.
9023
9024 2019-01-16  Tom Tromey  <tom@tromey.com>
9025
9026         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9027         type.  Remove no-argument constructor.
9028         <iterator::operator++>: Simplify.
9029         <begin>: Update.
9030         <end>: Use minimal_symbol_count.
9031
9032 2019-01-16  Tom Tromey  <tom@tromey.com>
9033
9034         * objfiles.h (struct objfile) <psymtabs>: New method.
9035         (class objfile_psymtabs): Remove.
9036         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9037         typedef.
9038         <range>: New method.
9039         (require_partial_symbols): Change return type.
9040         * psymtab.c (require_partial_symbols)
9041         (psym_expand_symtabs_matching): Update.
9042         * mdebugread.c (parse_partial_symbols): Update.
9043         * dbxread.c (dbx_end_psymtab): Update.
9044
9045 2019-01-15  Tom Tromey  <tom@tromey.com>
9046
9047         * symtab.c (lookup_objfile_from_block)
9048         (lookup_symbol_in_objfile_symtabs)
9049         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9050         (find_line_symtab, info_sources_command)
9051         (default_collect_symbol_completion_matches_break_on)
9052         (make_source_files_completion_list): Update.
9053         * symmisc.c (print_objfile_statistics, dump_objfile)
9054         (maintenance_print_symbols, maintenance_info_symtabs)
9055         (maintenance_check_symtabs, maintenance_info_line_tables):
9056         Update.
9057         * source.c (select_source_symtab)
9058         (forget_cached_source_info_for_objfile): Update.
9059         * objfiles.h (class objfile_compunits): Remove.
9060         (struct objfile) <compunits_range>: New typedef.
9061         (compunits): New method.
9062         * objfiles.c (objfile_relocate1): Update.
9063         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9064         * maint.c (count_symtabs_and_blocks): Update.
9065         * linespec.c (iterate_over_all_matching_symtabs): Update.
9066         * cp-support.c (add_symbol_overload_list_qualified): Update.
9067         * coffread.c (coff_symtab_read): Update.
9068         * ada-lang.c (add_nonlocal_symbols)
9069         (ada_collect_symbol_completion_matches)
9070         (ada_add_global_exceptions): Update.
9071
9072 2019-01-15  Tom Tromey  <tom@tromey.com>
9073
9074         * progspace.h (program_space) <objfiles_safe_range>: New
9075         typedef.
9076         <objfiles_safe>: New method.
9077         * objfiles.h (class all_objfiles_safe): Remove.
9078         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9079         * jit.c (jit_inferior_exit_hook): Update.
9080
9081 2019-01-17  Tom Tromey  <tom@tromey.com>
9082
9083         * progspace.h (program_space) <objfiles_range>: New typedef.
9084         <objfiles>: New method.
9085         <objfiles_head>: Rename from objfiles.
9086         (object_files): Update.
9087         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9088         * guile/scm-pretty-print.c
9089         (ppscm_find_pretty_printer_from_objfiles): Update.
9090         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9091         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9092         Update.
9093         * python/py-progspace.c (pspy_get_objfiles): Update.
9094         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9095         Update.
9096         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9097         (objfpy_lookup_objfile_by_build_id): Update.
9098         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9099         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9100         Update.
9101         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9102         (expand_symtab_containing_pc, lookup_objfile_from_block)
9103         (lookup_static_symbol, basic_lookup_transparent_type)
9104         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9105         (find_line_symtab, info_sources_command)
9106         (default_collect_symbol_completion_matches_break_on)
9107         (make_source_files_completion_list, find_main_name): Update.
9108         * symmisc.c (print_symbol_bcache_statistics)
9109         (print_objfile_statistics, maintenance_print_symbols)
9110         (maintenance_print_msymbols, maintenance_print_objfiles)
9111         (maintenance_info_symtabs, maintenance_check_symtabs)
9112         (maintenance_expand_symtabs, maintenance_info_line_tables):
9113         Update.
9114         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9115         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9116         (map_overlay_command, unmap_overlay_command)
9117         (simple_overlay_update, expand_symtabs_matching)
9118         (map_symbol_filenames): Update.
9119         * symfile-debug.c (set_debug_symfile): Update.
9120         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9121         Update.
9122         * source.c (select_source_symtab, forget_cached_source_info):
9123         Update.
9124         * solib.c (solib_read_symbols): Update.
9125         * solib-spu.c (append_ocl_sos): Update.
9126         * psymtab.c (maintenance_print_psymbols)
9127         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9128         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9129         * printcmd.c (info_symbol_command): Update.
9130         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9131         Update.
9132         * objfiles.h (class all_objfiles): Remove.
9133         * objfiles.c (have_partial_symbols, have_full_symbols)
9134         (have_minimal_symbols, qsort_cmp, update_section_map)
9135         (shared_objfile_contains_address_p)
9136         (default_iterate_over_objfiles_in_search_order): Update.
9137         * objc-lang.c (info_selectors_command, info_classes_command)
9138         (find_methods): Update.
9139         * minsyms.c (find_solib_trampoline_target): Update.
9140         * maint.c (maintenance_info_sections)
9141         (maintenance_translate_address, count_symtabs_and_blocks):
9142         Update.
9143         * main.c (captured_main_1): Update.
9144         * linux-thread-db.c (try_thread_db_load_from_pdir)
9145         (has_libpthread): Update.
9146         * linespec.c (iterate_over_all_matching_symtabs)
9147         (search_minsyms_for_name): Update.
9148         * jit.c (jit_find_objf_with_entry_addr): Update.
9149         * hppa-tdep.c (find_unwind_entry)
9150         (hppa_lookup_stub_minimal_symbol): Update.
9151         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9152         Update.
9153         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9154         (elf_gnu_ifunc_resolve_by_got): Update.
9155         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9156         * dwarf-index-write.c (save_gdb_index_command): Update.
9157         * cp-support.c (add_symbol_overload_list_qualified): Update.
9158         * breakpoint.c (create_overlay_event_breakpoint)
9159         (create_longjmp_master_breakpoint)
9160         (create_std_terminate_master_breakpoint)
9161         (create_exception_master_breakpoint): Update.
9162         * blockframe.c (find_pc_partial_function): Update.
9163         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9164         (ada_collect_symbol_completion_matches)
9165         (ada_add_global_exceptions): Update.
9166
9167 2019-01-17  Tom Tromey  <tom@tromey.com>
9168
9169         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9170         declare VEC.
9171         (solib_target_parse_libraries): Change return type.
9172         (library_list_start_segment, library_list_start_section)
9173         (library_list_end_library, library_list_start_library); Update.
9174         (solib_target_free_library_list): Remove.
9175         (solib_target_parse_libraries): Remove cleanup.  Change return
9176         type.
9177         (solib_target_current_sos): Update.
9178
9179 2019-01-17  Tom Tromey  <tromey@bapiya>
9180
9181         * valprint.c: Replace "the the" with "the".
9182         * symtab.c: Replace "the the" with "the".
9183         * solib.c: Replace "the the" with "the".
9184         * solib-dsbt.c: Replace "the the" with "the".
9185         * linespec.c: Replace "the the" with "the".
9186         * dwarf2loc.h: Replace "the the" with "the".
9187         * amd64-windows-tdep.c: Replace "the the" with "the".
9188         * aarch64-tdep.c: Replace "the the" with "the".
9189
9190 2019-01-16  Keith Seitz  <keiths@redhat.com>
9191
9192         PR gdb/23773
9193         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9194         <builder>: Rename to ..
9195         <m_builder>: ... this and make private.
9196         (dwarf2_cu::get_builder): New method.  Change all users of
9197         `builder' to use this method.
9198         (dwarf2_start_symtab): Move to ...
9199         (dwarf2_cu::start_symtab): ... here.  Update all callers
9200         (setup_type_unit_groups): Move to ...
9201         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9202         callers.
9203         (dwarf2_cu::reset_builder): New method.
9204         (process_full_compunit, process_full_type_unit): Use
9205         dwarf2_cu::reset_builder.
9206         (follow_die_offset): Record the ancestor CU if it is different
9207         from the followed DIE's CU.
9208         (follow_die_sig_1): Likewise.
9209
9210 2019-01-15  Tom Tromey  <tom@tromey.com>
9211
9212         * remote.c (class remote_state) <buf>: Now a char_vector.
9213         <buf_size>: Remove.
9214         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9215         parameter.
9216         (remote_target::getpkt_or_notif_sane_1)
9217         (remote_target::getpkt_sane)
9218         (remote_target::getpkt_or_notif_sane): Likewise.
9219         (class remote_target) <putpkt>: New overload.
9220         (remote_target::read_frame): Change type of "buf_p".  Remove
9221         sizeof_p parameter.
9222         (packet_ok): New overload.
9223         (packet_check_result): New overload.
9224         Update all uses.
9225
9226 2019-01-14  Tom Tromey  <tom@tromey.com>
9227
9228         * remote-notif.c (handle_notification, remote_notif_ack)
9229         (remote_notif_parse): Make "buf" const.
9230         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9231         const.
9232         (remote_notif_parse, remote_notif_ack, handle_notification):
9233         Likewise.
9234         * remote.c (remote_notif_stop_parse): Make "buf" const.
9235         (remote_target::remote_parse_stop_reply): Make "buf" const.
9236         (remote_notif_stop_ack): Make "buf" const.
9237
9238 2019-01-14  Tom Tromey  <tom@tromey.com>
9239
9240         * remote.c (remote_console_output): Make parameter const.
9241
9242 2019-01-14  Tom Tromey  <tom@tromey.com>
9243
9244         * target-debug.h (target_debug_print_signals): Constify.
9245         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9246         * procfs.c (procfs_target::pass_signals): Update.
9247         * linux-nat.c (linux_nat_target::pass_signals): Update.
9248         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9249         * target-delegates.c: Rebuild.
9250         * remote.c (remote_target::program_signals): Update.
9251         (remote_target::pass_signals): Update.
9252         * target.c (target_pass_signals): Constify argument.
9253         (target_program_signals): Likewise.
9254         * target.h (struct target_ops) <pass_signals, program_signals>:
9255         Constify argument.
9256         (target_pass_signals, target_program_signals): Constify argument.
9257
9258 2019-01-14  Tom Tromey  <tom@tromey.com>
9259
9260         PR tui/28819:
9261         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9262
9263 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9264
9265         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9266         field.
9267         * rs6000-tdep.c: Include reggroups.h.
9268         (IS_V_ALIAS_PSEUDOREG): Define.
9269         (rs6000_register_name): Return names for the "vX" aliases.
9270         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9271         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9272         aliases.  Call default_register_reggroup_p for all other
9273         pseudo-registers.
9274         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9275         New functions.
9276         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9277         Handle "vX" aliases.
9278         (v_alias_pseudo_register_collect): New function.
9279         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9280         (rs6000_gdbarch_init): Initialize "vX" aliases as
9281         pseudo-registers.  Restore registration of
9282         rs6000_pseudo_register_reggroup_p with
9283         set_tdesc_pseudo_register_reggroup_p.
9284
9285 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9286
9287         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9288         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9289         set_gdbarch_num_pseudo_regs.
9290
9291 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9292
9293         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9294         Remove arg prefixname, add do_set and do_show.
9295         Add member functions set_list and show_list.
9296         * cli/cli-style.c (class cli_style_option): Update accordingly.
9297         (style_set_list): Move to file scope.
9298         (style_show_list): Likewise.
9299         (set_style): Call help_list.
9300         (show_style): Call cmd_show_list.
9301         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9302         Update to use the new macro.
9303
9304 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9305
9306         * ada-lang.c (_initialize_ada_language): Expand the help text
9307         for the "catch exception" command.
9308
9309 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9310
9311         * symtab.c (matching_obj_sections): Initialize obj,
9312         declare it closer to its usage.
9313
9314 2019-01-10  Tom Tromey  <tom@tromey.com>
9315
9316         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9317         (basic_inf_threads_range): Remove.
9318         (inf_threads_range, inf_non_exited_threads_range)
9319         (safe_inf_threads_range): Use next_adapter.
9320
9321 2019-01-10  Keith Seitz  <keiths@redhat.com>
9322
9323         PR gdb/23712
9324         PR symtab/23010
9325         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9326         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9327
9328 2019-01-10  Keith Seitz  <keiths@redhat.com>
9329
9330         PR gdb/23712
9331         PR symtab/23010
9332         * dictionary.c (pending_to_vector): Remove.
9333         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9334         Remove _1 suffix, replacing functions of the same name.  Update
9335         all callers.
9336         (dict_create_hashed, dict_create_hashed_expandable)
9337         (dict_create_linear, dict_create_linear_expandable, dict_free)
9338         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9339         Make functions static.
9340
9341 2019-01-10  Keith Seitz  <keiths@redhat.com>
9342
9343         PR gdb/23712
9344         PR symtab/23010
9345         * dictionary.h (struct dictionary): Replace declaration with
9346         multidictionary.
9347         (dict_create_hashed, dict_create_hashed_expandable)
9348         (dict_create_linear, dict_create_linear_expandable)
9349         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9350         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9351         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9352         taking multidictionary argument.
9353         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9354         * block.h (struct block) <dict>: Change to multidictionary
9355         and rename `multidict'.
9356         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9357         symmisc.c: Update all dictionary references to multidictionary.
9358
9359 2019-01-10  Keith Seitz  <keiths@redhat.com>
9360
9361         PR gdb/23712
9362         PR symtab/23010
9363         * dictionary.c: Include unordered_map.
9364         (pending_to_vector): New function.
9365         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9366         Rewrite the non-"_1" functions to take vector instead
9367         of linked list.
9368         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9369         "new" _1 versions of the same name.
9370         (multidictionary): Define.
9371         (std::hash<enum language): New definition.
9372         (collate_pending_symbols_by_language, mdict_create_hashed)
9373         (mdict_create_hashed_expandable, mdict_create_linear)
9374         (mdict_create_linear_expandable, mdict_free)
9375         (find_language_dictionary, create_new_language_dictionary)
9376         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9377         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9378         (mdict_size, mdict_empty): New functions.
9379         * dictionary.h (mdict_iterator): Define.
9380
9381 2019-01-10  Pedro Alves  <palves@redhat.com>
9382
9383         * breakpoint.c (read_uploaded_action)
9384         (create_tracepoint_from_upload): Adjust to use
9385         gdb::unique_xmalloc_ptr.
9386         * ctf.c (ctf_write_uploaded_tp):
9387         (SET_ARRAY_FIELD): Use emplace_back.
9388         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9389         * tracefile-tfile.c (tfile_write_uploaded_tp):
9390         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9391         gdb::unique_xmalloc_ptr.
9392         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9393         at_string, cond_string, cmd_strings>: Replace char pointers
9394         with gdb::unique_xmalloc_ptr.
9395
9396 2019-01-10  Pedro Alves  <palves@redhat.com>
9397
9398         * solib-target.c (library_list_start_library): Don't xstrdup name.
9399
9400 2019-01-10  Pedro Alves  <palves@redhat.com>
9401
9402         * mdebugread.c (parse_partial_symbols): Use
9403         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9404
9405 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9406
9407         * linux-fork.c (scoped_switch_fork_info)
9408         <~scoped_switch_fork_info>: Fix incorrect variable name.
9409
9410 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9411
9412         * linux-fork.c (scoped_switch_fork_info)
9413         <scoped_switch_fork_info>: Make explicit.
9414         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9415
9416 2019-01-10  Tom Tromey  <tom@tromey.com>
9417
9418         * objfiles.h (objfile::reset_psymtabs): Update.
9419         * objfiles.c (objfile::objfile): Update.
9420         * psymtab.h (psymtab_storage::obstack): Update.
9421         (psymtab_storage::m_obstack): Use gdb::optional.
9422         (class psymtab_storage): Update comment.  Remove objfile
9423         parameter.
9424         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9425
9426 2019-01-10  Tom Tromey  <tom@tromey.com>
9427
9428         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9429         <free_psymtabs>: Now private.
9430         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9431         (allocate_psymtab): Use new method.
9432
9433 2019-01-10  Tom Tromey  <tom@tromey.com>
9434
9435         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9436         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9437         * mdebugread.c (parse_partial_symbols): Use
9438         allocate_dependencies.
9439         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9440         allocate_dependencies.
9441         (process_psymtab_comp_unit_reader)
9442         (build_type_psymtab_dependencies): Likewise.
9443         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9444
9445 2019-01-10  Tom Tromey  <tom@tromey.com>
9446
9447         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9448         PSYMBOL_SET_LANGUAGE.
9449         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9450
9451 2019-01-10  Tom Tromey  <tom@tromey.com>
9452
9453         * psymtab.h (psymtab_storage::obstack): New method.
9454         <m_obstack>: Rename from obstack; now private.
9455         * psymtab.c (psymtab_storage): Update.
9456         * dwarf2read.c (create_addrmap_from_index)
9457         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9458         Update.
9459
9460 2019-01-10  Tom Tromey  <tom@tromey.com>
9461
9462         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9463         * objfiles.h (objfile::reset_psymtabs): New method.
9464
9465 2019-01-10  Tom Tromey  <tom@tromey.com>
9466
9467         * symmisc.c (print_symbol_bcache_statistics): Update.
9468         (print_objfile_statistics): Update.
9469         * symfile.c (reread_symbols): Update.
9470         * psymtab.h (class psymtab_storage): New.
9471         * psymtab.c (psymtab_storage): New constructor.
9472         (~psymtab_storage): New destructor.
9473         (require_partial_symbols): Update.
9474         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9475         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9476         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9477         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9478         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9479         (start_psymtab_common, end_psymtab_common)
9480         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9481         (allocate_psymtab): Update.
9482         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9483         Update.
9484         (dump_psymtab_addrmap, maintenance_print_psymbols)
9485         (maintenance_check_psymtabs): Update.
9486         (class objfile_psymtabs): Move to objfiles.h.
9487         * psympriv.h (discard_psymtab): Now inline.
9488         (psymtab_discarder::psymtab_discarder): Update.
9489         (psymtab_discarder::~psymtab_discarder): Update.
9490         (ALL_OBJFILE_PSYMTABS): Rewrite.
9491         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9492         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9493         Remove fields.
9494         <partial_symtabs>: New field.
9495         (class objfile_psymtabs): Move from psymtab.h.  Update.
9496         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9497         psymbol_cache.
9498         (objfile::~objfile): Don't destroy psymbol_cache.
9499         * mdebugread.c (parse_partial_symbols): Update.
9500         * dwarf2read.c (create_addrmap_from_index)
9501         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9502         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9503         (add_partial_subprogram, dwarf2_ranges_read): Update.
9504         * dwarf-index-write.c (write_address_map)
9505         (write_one_signatured_type, recursively_write_psymbols)
9506         (class debug_names, class debug_names, write_psymtabs_to_index):
9507         Update.
9508
9509 2019-01-10  Tom Tromey  <tom@tromey.com>
9510
9511         * symtab.h (SYMBOL_SET_NAMES): Update.
9512         (symbol_set_names): Update.
9513         (MSYMBOL_SET_NAMES): Update.
9514         * symtab.c (symbol_set_names): Change argument to be an
9515         objfile_per_bfd_storage.
9516         * psymtab.c (add_psymbol_to_bcache): Update.
9517         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9518
9519 2019-01-10  Tom Tromey  <tom@tromey.com>
9520
9521         * symtab.c (create_demangled_names_hash): Change argument to be an
9522         objfile_per_bfd_storage.
9523         (symbol_set_names): Update.
9524
9525 2019-01-10  Tom Tromey  <tom@tromey.com>
9526
9527         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9528         init_psymbol_list.
9529         * psymtab.c (init_psymbol_list): Do nothing if already called.
9530         * psympriv.h (init_psymbol_list): Add comment.
9531         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9532         init_psymbol_list.
9533         * dbxread.c (dbx_symfile_read): Unconditionally call
9534         init_psymbol_list.
9535
9536 2019-01-10  Tom Tromey  <tom@tromey.com>
9537
9538         * xcoffread.c (scan_xcoff_symtab): Update.
9539         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9540         "where".
9541         * mdebugread.c (parse_partial_symbols)
9542         (handle_psymbol_enumerators): Update.
9543         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9544         * dbxread.c (read_dbx_symtab): Update.
9545         * psympriv.h (psymbol_placement): New enum.
9546         (add_psymbol_to_list): Update.
9547
9548 2019-01-10  Tom Tromey  <tom@tromey.com>
9549
9550         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9551         static_psymbols parameters.
9552         (scan_xcoff_symtab): Update.
9553         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9554         static_psymbols parameters.
9555         * psympriv.h (start_psymtab_common): Update.
9556         * mdebugread.c (parse_partial_symbols): Update.
9557         * dwarf2read.c (create_partial_symtab): Update.
9558         * dbxread.c (read_dbx_symtab): Update.
9559         (start_psymtab): Remove global_psymbols and static_psymbols
9560         parameters.
9561
9562 2019-01-10  Tom Tromey  <tom@tromey.com>
9563
9564         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9565         * psymtab.c (allocate_psymtab): Add comment.
9566         * psympriv.h (allocate_psymtab): Add comment.
9567         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9568         initializations.
9569         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9570
9571 2019-01-10  Tom Tromey  <tom@tromey.com>
9572
9573         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9574         Don't declare.
9575         * mipsread.c: Include mdebugread.h.
9576         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9577         Declare.
9578         * elfread.c: Include mdebugread.h.
9579
9580 2019-01-09  Tom Tromey  <tom@tromey.com>
9581
9582         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9583         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9584         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9585         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9586         (psym_lookup_symbol, psym_find_last_source_symtab)
9587         (psym_forget_cached_source_info, psym_print_stats)
9588         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9589         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9590         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9591         (psym_find_compunit_symtab_by_address)
9592         (maintenance_print_psymbols, maintenance_info_psymtabs)
9593         (maintenance_check_psymtabs): Use ranged for.
9594         * psymtab.h (class objfile_psymtabs): New.
9595         (require_partial_symbols): Return objfile_psymtabs.
9596         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9597
9598 2019-01-09  Tom Tromey  <tom@tromey.com>
9599
9600         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9601         (find_pc_mapped_section, list_overlays_command)
9602         (map_overlay_command, unmap_overlay_command)
9603         (simple_overlay_update): Use all_objfiles.
9604         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9605         * printcmd.c (info_symbol_command): Use all_objfiles.
9606         * objfiles.h (ALL_OBJSECTIONS): Remove.
9607         * maint.c (maintenance_translate_address): Use all_objfiles.
9608         * gcore.c (gcore_create_callback): Use all_objfiles.
9609         (objfile_find_memory_regions): Likewise.
9610
9611 2019-01-09  Tom Tromey  <tom@tromey.com>
9612
9613         * symtab.c (find_line_symtab, info_sources_command)
9614         (make_source_files_completion_list): Use objfile_compunits.
9615         * source.c (select_source_symtab): Use objfile_compunits.
9616         * objfiles.h (struct objfile): Update comment.
9617         (ALL_OBJFILES): Remove.
9618         (ALL_FILETABS): Remove.
9619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9620         objfile_compunits.
9621
9622 2019-01-09  Tom Tromey  <tom@tromey.com>
9623
9624         * symmisc.c (print_objfile_statistics, dump_objfile)
9625         (maintenance_print_symbols): Use compunit_filetabs.
9626         * source.c (forget_cached_source_info_for_objfile): Use
9627         compunit_filetabs.
9628         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9629         (ALL_FILETABS): Use compunit_filetabs.
9630         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9631         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9632
9633 2019-01-09  Tom Tromey  <tom@tromey.com>
9634
9635         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9636         (compunit_filetabs): New.
9637         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9638         compunit_filetabs.
9639         (info_sources_command, make_source_files_completion_list): Remove
9640         declaration.
9641         * symmisc.c (print_objfile_statistics, dump_objfile)
9642         (maintenance_print_symbols): Remove declaration.
9643         (maintenance_info_symtabs): Use compunit_filetabs.
9644         (maintenance_info_line_tables): Likewise.
9645         * source.c (select_source_symtab): Change local variable name.
9646         (forget_cached_source_info_for_objfile): Remove declaration.
9647         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9648         * objfiles.c (objfile_relocate1): Remove declaration.
9649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9650         declaration.
9651         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9652         * coffread.c (coff_symtab_read): Remove declaration.
9653         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9654         compunit_filetabs.
9655
9656 2019-01-09  Tom Tromey  <tom@tromey.com>
9657
9658         * symtab.c (lookup_objfile_from_block)
9659         (find_pc_sect_compunit_symtab, search_symbols)
9660         (default_collect_symbol_completion_matches_break_on): Use
9661         objfile_compunits.
9662         * objfiles.h (ALL_COMPUNITS): Remove.
9663         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9664         * cp-support.c (add_symbol_overload_list_qualified): Use
9665         objfile_compunits.
9666         * ada-lang.c (ada_collect_symbol_completion_matches)
9667         (ada_add_global_exceptions): Use objfile_compunits.
9668
9669 2019-01-09  Tom Tromey  <tom@tromey.com>
9670
9671         * source.c (select_source_symtab)
9672         (forget_cached_source_info_for_objfile): Remove declaration.
9673         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9674         declaration.
9675         * maint.c (count_symtabs_and_blocks): Remove declaration.
9676         * cp-support.c (add_symbol_overload_list_qualified): Remove
9677         declaration.
9678         * coffread.c (coff_symtab_read): Remove declaration.
9679         * symtab.c (lookup_symbol_in_objfile_symtabs)
9680         (basic_lookup_transparent_type_1): Use objfile_compunits.
9681         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9682         (info_sources_command, search_symbols)
9683         (default_collect_symbol_completion_matches_break_on)
9684         (make_source_files_completion_list): Remove declaration.
9685         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9686         (ada_collect_symbol_completion_matches)
9687         (ada_add_global_exceptions): Remove declaration.
9688         * linespec.c (iterate_over_all_matching_symtabs): Use
9689         objfile_compunits.
9690         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9691         (class objfile_compunits): New.
9692         (ALL_COMPUNITS): Use objfile_compunits.
9693         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9694         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9695         objfile_compunits.
9696         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9697
9698 2019-01-09  Tom Tromey  <tom@tromey.com>
9699
9700         * symtab.c (search_symbols)
9701         (default_collect_symbol_completion_matches_break_on): Use
9702         objfile_msymbols.
9703         * ada-lang.c (ada_lookup_simple_minsym)
9704         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9705         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9706         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9707         objfile_msymbols.
9708         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9709         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9710         * objc-lang.c (find_methods): Use objfile_msymbols.
9711         (info_selectors_command, info_classes_command): Likewise.
9712         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9713         * objfiles.h (class objfile_msymbols): New.
9714         (ALL_OBJFILE_MSYMBOLS): Remove.
9715         (ALL_MSYMBOLS): Remove.
9716
9717 2019-01-09  Tom Tromey  <tom@tromey.com>
9718
9719         * common/next-iterator.h (next_adapter): Add Iterator template
9720         parameter.
9721         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9722         (class all_objfiles_safe): New.
9723         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9724         * objfiles.c (put_objfile_before): Update comment.
9725         (add_separate_debug_objfile): Likewise.
9726         (free_all_objfiles): Use all_objfiles_safe.
9727         (objfile_purge_solibs): Likewise.
9728
9729 2019-01-09  Tom Tromey  <tom@tromey.com>
9730
9731         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9732         (expand_symtab_containing_pc, lookup_static_symbol)
9733         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9734         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9735         all_objfiles.
9736         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9737         * breakpoint.c (create_overlay_event_breakpoint)
9738         (create_longjmp_master_breakpoint)
9739         (create_std_terminate_master_breakpoint)
9740         (create_exception_master_breakpoint): Use all_objfiles.
9741         * linux-thread-db.c (try_thread_db_load_from_pdir)
9742         (has_libpthread): Use all_objfiles.
9743         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9744         * linespec.c (iterate_over_all_matching_symtabs)
9745         (search_minsyms_for_name): Use all_objfiles.
9746         * maint.c (maintenance_info_sections): Use all_objfiles.
9747         * main.c (captured_main_1): Use all_objfiles.
9748         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9749         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9750         * guile/scm-pretty-print.c
9751         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9752         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9753         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9754         (maintenance_print_msymbols): Use all_objfiles.
9755         * source.c (select_source_symtab): Use all_objfiles.
9756         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9757         * symfile.c (remove_symbol_file_command)
9758         (expand_symtabs_matching, map_symbol_filenames): Use
9759         all_objfiles.
9760         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9761         all_objfiles.
9762         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9763         * objc-lang.c (find_methods): Use all_objfiles.
9764         * objfiles.c (have_partial_symbols, have_full_symbols)
9765         (have_minimal_symbols, qsort_cmp)
9766         (default_iterate_over_objfiles_in_search_order): Use
9767         all_objfiles.
9768         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9769         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9770         (maintenance_check_psymtabs): Use all_objfiles.
9771         (ALL_PSYMTABS): Remove.
9772         * compile/compile-object-run.c (do_module_cleanup): Use
9773         all_objfiles.
9774         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9775         * cp-support.c (add_symbol_overload_list_qualified): Use
9776         all_objfiles.
9777         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9778         Use all_objfiles.
9779         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9780         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9781         all_objfiles.
9782         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9783         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9784         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9785         Uses all_objfiles.
9786         * solib.c (solib_read_symbols): Use all_objfiles
9787
9788 2019-01-09  Tom Tromey  <tom@tromey.com>
9789
9790         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9791         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9792         all_objfiles.
9793         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9794         * symmisc.c (print_symbol_bcache_statistics)
9795         (print_objfile_statistics, maintenance_print_objfiles)
9796         (maintenance_info_symtabs, maintenance_check_symtabs)
9797         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9798         all_objfiles.
9799         * source.c (forget_cached_source_info): Use all_objfiles.
9800         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9801         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9802         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9803         * objfiles.c (update_section_map): Use all_objfiles.
9804         (shared_objfile_contains_address_p): Likewise.
9805         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9806         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9807
9808 2019-01-09  Tom Tromey  <tom@tromey.com>
9809
9810         * common/next-iterator.h: New file.
9811         * objfiles.h (class all_objfiles): New.
9812         (struct objfile_iterator): New.
9813
9814 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9815
9816         * NEWS: Move the description of the changed "frame", "select-frame",
9817          and "info frame" commands to the Changed commands section.
9818
9819 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9820
9821         * gdbtypes.c (check_stub_method_group): Remove handling of old
9822         mangling schemes.
9823         * linespec.c (find_methods): Likewise.
9824         * stabsread.c (read_member_functions): Likewise.
9825         * valops.c (search_struct_method): Likewise.
9826         (value_struct_elt_for_reference): Likewise.
9827         * NEWS: Mention this change.
9828
9829 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9830
9831         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9832         print_source_lines.
9833         * source.c (print_source_lines_base): Update line number check.
9834         (print_source_lines): New function.
9835         (source_lines_range::source_lines_range): New function.
9836         * source.h (class source_lines_range): New class.
9837         (print_source_lines): New declaration.
9838
9839 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9840
9841         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9842
9843 2019-01-08  Tom Tromey  <tom@tromey.com>
9844             Simon Marchi  <simon.marchi@ericsson.com>
9845
9846         PR gdb/24060
9847         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9848         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9849         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9850         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9851         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9852         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9853
9854 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9855
9856         * source.c (select_source_symtab): Move header comment to
9857         declaration in source.h.
9858         (forget_cached_source_info_for_objfile): Likewise.
9859         (forget_cached_source_info): Likewise.
9860         (identify_source_line): Likewise.
9861         * source.h (identify_source_line): Move declaration from symtab.h
9862         and add comment from source.c
9863         (print_source_lines): Likewise.
9864         (forget_cached_source_info_for_objfile): Likewise.
9865         (forget_cached_source_info): Likewise.
9866         (select_source_symtab): Likewise.
9867         (enum print_source_lines_flag): Move definition from symtab.h.
9868         * symtab.h (identify_source_line): Move declaration to source.h.
9869         (print_source_lines): Likewise.
9870         (forget_cached_source_info_for_objfile): Likewise.
9871         (forget_cached_source_info): Likewise.
9872         (select_source_symtab): Likewise.
9873         (enum print_source_lines_flag): Move definition to source.h.
9874         * tui/tui-hooks.c: Add 'source.h' include.
9875
9876 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9877
9878         * source.c (print_source_lines_base): Handle requests to print
9879         reverse line number sequences, and guard against empty lines
9880         string.
9881
9882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9883
9884         * source.c (print_source_lines_base): Fix skip of '\r' if next
9885         character is '\n'.
9886
9887 2019-01-06  Tom Tromey  <tom@tromey.com>
9888
9889         * c-exp.y (struct c_parse_state) <macro_original_text,
9890         expansion_obstack>: New member.
9891         (macro_original_text, expansion_obstack): Remove globals.
9892         (scan_macro_expansion, scanning_macro_expansion)
9893         (finished_macro_expansion): Update.
9894         (scan_macro_cleanup): Remove.
9895         (yylex, c_parse): Update.
9896
9897 2019-01-06  Tom Tromey  <tom@tromey.com>
9898
9899         * c-exp.y (struct c_parse_state) <strings>: New member.
9900         (operator_stoken): Update.
9901
9902 2019-01-06  Tom Tromey  <tom@tromey.com>
9903
9904         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9905         (union type_stack_elt) <typelist_val>: Now a pointer to
9906         std::vector.
9907         (type_stack_cleanup): Don't declare.
9908         (push_typelist): Update.
9909         * parse.c (pop_typelist): Return a std::vector.
9910         (push_typelist): Take a std::vector.
9911         (follow_types): Update.  Do not free args.
9912         (type_stack_cleanup): Remove.
9913         * c-exp.y (struct c_parse_state): New.
9914         (cpstate): New global.
9915         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9916         (nonempty_typelist): Update.
9917         (func_mod): Create a new vector.
9918         (c_parse): Create a c_parse_state.
9919         (check_parameter_typelist): Do not delete params.
9920         (function_method): Update.  Do not delete type_list.
9921
9922 2019-01-06  Tom Tromey  <tom@tromey.com>
9923
9924         PR gdb/28155:
9925         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9926         check_typedef.
9927         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9928         (print_return_value): Likewise.
9929
9930 2019-01-05  Tom Tromey  <tom@tromey.com>
9931
9932         * contrib/cleanup_check.py: Remove.
9933         * contrib/gcc-with-excheck: Remove.
9934         * contrib/exsummary.py: Remove.
9935         * contrib/excheck.py: Remove.
9936
9937 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9938
9939         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9940         NULL. Initialize tpprev to NULL instead of assigning it
9941         to NULL on the next statement.
9942         * windows-nat.c (windows_delete_thread): Remove check for
9943         main_thread_id before printing thread exit notifications.
9944         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9945         Remove thread ID check against main_thread_id.
9946         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9947         windows_delete_thread.
9948         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9949
9950 2019-01-04  Tom Tromey  <tom@tromey.com>
9951
9952         * compile/compile.c (_initialize_compile): Use upper case for
9953         metasyntactic variables.
9954         * symmisc.c (_initialize_symmisc): Use upper case for
9955         metasyntactic variables.
9956         * psymtab.c (_initialize_psymtab): Use upper case for
9957         metasyntactic variables.
9958         * demangle.c (demangle_command): Use upper case for metasyntactic
9959         variables.
9960         (_initialize_demangler): Likewise.
9961         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9962         variables.
9963
9964 2019-01-03  Tom Tromey  <tom@tromey.com>
9965
9966         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9967
9968 2019-01-03  Tom Tromey  <tom@tromey.com>
9969
9970         * python/py-symtab.c (salpy_str): Update.
9971         (struct salpy_sal_object) <symtab>: Now a PyObject.
9972         (salpy_dealloc): Update.
9973         (del_objfile_sal): Use gdbpy_ref.
9974
9975 2019-01-03  Tom Tromey  <tom@tromey.com>
9976
9977         * python/py-type.c (convert_field): Use new_reference.  Return
9978         gdbpy_ref.
9979         (make_fielditem): Return gdbpy_ref.
9980         (typy_fields): Update.
9981         (typy_getitem): Update.
9982         (field_name): Return gdbpy_ref.  Use new_reference.
9983         (typy_iterator_iternext): Update.
9984
9985 2019-01-03  Tom Tromey  <tom@tromey.com>
9986
9987         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9988
9989 2019-01-03  Tom Tromey  <tom@tromey.com>
9990
9991         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9992         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9993         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9994         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9995         (pspy_set_type_printers): Likewise.
9996         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9997         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9998         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9999         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10000         (objfpy_set_type_printers): Likewise.
10001
10002 2019-01-03  Tom Tromey  <tom@tromey.com>
10003
10004         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10005         (gdbpy_print_stack): Use gdbpy_err_fetch.
10006         * python/python-internal.h (class gdbpy_err_fetch): New class.
10007         (class gdbpy_enter) <m_error_type, m_error_value,
10008         m_error_traceback>: Remove.
10009         <m_error>: New member.
10010         (gdbpy_exception_to_string): Don't declare.
10011         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10012         * python/py-value.c (convert_value_from_python): Use
10013         gdbpy_err_fetch.
10014         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10015         gdbpy_exception_to_string.
10016         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10017         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10018         gdbpy_err_fetch.
10019
10020 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10021
10022         * linux-nat.c (delete_lwp_cleanup): Delete.
10023         (struct lwp_deleter): New struct.
10024         (lwp_info_up): New typedef.
10025         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10026         lwp_info_up.
10027
10028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10029
10030         * linux-fork.c (class scoped_switch_fork_info): New class.
10031         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10032
10033 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10034
10035         * valops.c (find_overload_match): Remove use of null_cleanup, and
10036         calls to do_cleanups.
10037
10038 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10039
10040         * compile/compile-cplus-types.c
10041         (compile_cplus_instance::decl_name): Handle changes to
10042         cp_func_name.
10043         * cp-support.c (cp_func_name): Update header comment, update
10044         return type.
10045         * cp-support.h (cp_func_name): Update return type in declaration.
10046         * valops.c (find_overload_match): Move temp_func local to top
10047         level of function and change its type.  Use temp_func to hold and
10048         delete temporary string obtained from cp_func_name.
10049
10050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10051
10052         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10053         gdb::char_vector, remove cleanup, and update uses of `msg`.
10054
10055 2019-01-03  Jim Wilson  <jimw@sifive.com>
10056
10057         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10058
10059 2019-01-02  Tom Tromey  <tom@tromey.com>
10060
10061         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10062         (tdesc_parse_xml): Remove cleanups.
10063         * target-descriptions.h (make_cleanup_free_target_description):
10064         Don't declare.
10065         (target_desc_deleter): New struct.
10066         (target_desc_up): New typedef.
10067         * target-descriptions.c (target_desc_deleter::operator()): Rename
10068         from free_target_description.
10069         (make_cleanup_free_target_description): Remove.
10070
10071 2019-01-02  Tom Tromey  <tom@tromey.com>
10072
10073         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10074         constructor, destructor.
10075         (linespec_parser): Remove typedef.
10076         (~linespec_parser): Rename from linespec_parser_delete.
10077         (linespec_lex_to_end, linespec_complete_label)
10078         (linespec_complete): Update.
10079         (decode_line_full): Remove cleanups.
10080         (decode_line_1): Update.
10081
10082 2019-01-02  Tom Tromey  <tom@tromey.com>
10083
10084         * python/python-internal.h (inferior_to_inferior_object): Change
10085         return type.
10086         * python/py-exitedevent.c (create_exited_event_object): Update.
10087         * python/py-inferior.c (inferior_to_inferior_object): Return
10088         gdbpy_ref.
10089         (python_new_inferior, python_inferior_deleted)
10090         (thread_to_thread_object, delete_thread_object)
10091         (build_inferior_list, gdbpy_selected_inferior): Update.
10092         * python/py-infthread.c (create_thread_object): Update.  Also fail
10093         if inferior_to_inferior_object fails.
10094
10095 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10096
10097         * inferior.h (class inferior) <displaced_step_state>: New field.
10098         * infrun.h (struct displaced_step_state): Move here from
10099         infrun.c.  Initialize fields, add constructor.
10100         <inf>: Remove field.
10101         <reset>: New method.
10102         * infrun.c (struct displaced_step_inferior_state): Move to
10103         infrun.h.
10104         (displaced_step_inferior_states): Remove.
10105         (get_displaced_stepping_state): Adust.
10106         (displaced_step_in_progress_any_inferior): Adjust.
10107         (displaced_step_in_progress_thread): Adjust.
10108         (displaced_step_in_progress): Adjust.
10109         (add_displaced_stepping_state): Remove.
10110         (get_displaced_step_closure_by_addr): Adjust.
10111         (remove_displaced_stepping_state): Remove.
10112         (infrun_inferior_exit): Call displaced_step_state.reset.
10113         (use_displaced_stepping): Don't check for NULL.
10114         (displaced_step_prepare_throw): Call
10115         get_displaced_stepping_state.
10116         (displaced_step_fixup): Don't check for NULL.
10117         (prepare_for_detach): Don't check for NULL.
10118
10119 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10120
10121         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10122          in case of call that did not complete.
10123
10124 2019-01-02  Andrey Utkin  <autkin@undo.io>
10125
10126         * symfile.c (find_separate_debug_file): Fix search of debug files for
10127         remote debuggee.
10128
10129 2019-01-02  Tom Tromey  <tom@tromey.com>
10130
10131         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10132         indentation.
10133         * python/py-frame.c (frapy_older): Remove cast.
10134         (frapy_newer): Likewise.
10135         * python/py-breakpoint.c (local_setattro): Remove cast.
10136         * python/py-arch.c (archpy_name): Remove local variable.
10137         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10138
10139 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10140
10141         * unittests/basic_string_view/element_access/char/empty.cc:
10142         Fix year range in copyright header.
10143
10144 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10145
10146         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10147         Delete.
10148         <operator==>: Update with for removed field.
10149         <hash>: Likewise.
10150         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10151         <isa_features>: ...this.
10152         <abi_features>: New field.
10153         (riscv_isa_flen): Update comment.
10154         (riscv_abi_xlen): New declaration.
10155         (riscv_abi_flen): New declaration.
10156         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10157         isa_features.
10158         (riscv_abi_xlen): New function.
10159         (riscv_isa_flen): Update to get answer from isa_features.
10160         (riscv_abi_flen): New function.
10161         (riscv_has_fp_abi): Update to get answer from abi_features.
10162         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10163         xlen and flen.
10164         (riscv_call_info) <xlen, flen>: Update comment.
10165         (riscv_call_arg_struct): Remove invalid assertions
10166         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10167         is removed.
10168         (riscv_gdbarch_init): Gather isa features and abi features
10169         separately, ensure both match on the gdbarch when reusing an old
10170         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10171         a target with 64-bit float hardware.
10172
10173 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10174
10175         * source.c (search_command_helper): Stop reverse search
10176         when line 1 has been searched.
10177
10178 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10179
10180         * record-full.c (record_full_base_target::close): Rewrite
10181         record_full_core_buf_list free logic.
10182
10183 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10184
10185         * break-catch-syscall.c (print_one_catch_syscall): xfree
10186         the last text.
10187
10188 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10189
10190         * top.c (print_gdb_version): Update Copyright year in version
10191         message.
10192
10193 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10194
10195         Update copyright year range in all GDB files.
10196
10197 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10198
10199         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10200
10201 For older changes see ChangeLog-2018.
10202 \f
10203 Local Variables:
10204 mode: change-log
10205 left-margin: 8
10206 fill-column: 74
10207 version-control: never
10208 coding: utf-8
10209 End:
10210