gdb/ChangeLog

   1 2019-09-18  Alan Modra  <amodra@gmail.com>
   2
   3         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
   4         to bfd_asymbol_section.
   5
   6 2019-09-18  Alan Modra  <amodra@gmail.com>
   7
   8         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
   9         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
  10         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
  11
  12 2019-09-18  Alan Modra  <amodra@gmail.com>
  13
  14         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
  15         * spu-linux-nat.c (spu_bfd_open): Likewise.
  16
  17 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
  20         to bool to match definition in dwarf2read.c.
  21
  22 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
  25         (print_signatures): Likewise.
  26         (trust_pad_over_xvs): Likewise.
  27         * arch/aarch64-insn.c (aarch64_debug): Likewise.
  28         * arch/aarch64-insn.h (aarch64_debug): Likewise.
  29         * arm-linux-nat.c (arm_apcs_32): Likewise.
  30         * arm-linux-tdep.c (arm_apcs_32): Likewise.
  31         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
  32         * arm-tdep.c (arm_debug): Likewise.
  33         (arm_apcs_32): Likewise.
  34         * auto-load.c (debug_auto_load): Likewise.
  35         (auto_load_gdb_scripts): Likewise.
  36         (global_auto_load): Likewise.
  37         (auto_load_local_gdbinit): Likewise.
  38         (auto_load_local_gdbinit_loaded): Likewise.
  39         * auto-load.h (global_auto_load): Likewise.
  40         (auto_load_local_gdbinit): Likewise.
  41         (auto_load_local_gdbinit_loaded): Likewise.
  42         * breakpoint.c (disconnected_dprintf): Likewise.
  43         (breakpoint_proceeded): Likewise.
  44         (automatic_hardware_breakpoints): Likewise.
  45         (always_inserted_mode): Likewise.
  46         (target_exact_watchpoints): Likewise.
  47         (_initialize_breakpoint): Update.
  48         * breakpoint.h (target_exact_watchpoints): Change to bool.
  49         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
  50         * cli/cli-cmds.c (trace_commands): Likewise.
  51         * cli/cli-cmds.h (trace_commands): Likewise.
  52         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
  53         to bool*.
  54         * cli/cli-logging.c (logging_overwrite): Change to bool.
  55         (logging_redirect): Likewise.
  56         (debug_redirect): Likewise.
  57         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
  58         (struct boolean_option_def) <get_var_address_cb_>: Change return type
  59         to bool.
  60         <boolean_option_def>: Update.
  61         (struct flag_option_def): Change default type of Context to bool
  62         from int.
  63         <flag_option_def>: Change return type of var_address_cb_ to bool*.
  64         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
  65         (get_setshow_command_value_string): Likewise.
  66         * cli/cli-style.c (cli_styling): Change to bool.
  67         (source_styling): Likewise.
  68         * cli/cli-style.h (source_styling): Likewise.
  69         (cli_styling): Likewise.
  70         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
  71         to bool.
  72         * command.h (var_types): Update comment.
  73         (add_setshow_boolean_cmd): Change int* var argument to bool*.
  74         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
  75         bool.
  76         (debug_compile_cplus_scopes): Likewise.
  77         * compile/compile-internal.h (compile_debug): Likewise.
  78         * compile/compile.c (compile_debug): Likewise.
  79         (struct compile_options) <raw>: Likewise.
  80         * cp-support.c (catch_demangler_crashes): Likewise.
  81         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
  82         (usr_cmd_cris_dwarf2_cfi): Likewise.
  83         * csky-tdep.c (csky_debug): Likewise.
  84         * darwin-nat.c (enable_mach_exceptions): Likewise.
  85         * dcache.c (dcache_enabled_p): Likewise.
  86         * defs.h (info_verbose): Likewise.
  87         * demangle.c (demangle): Likewise.
  88         (asm_demangle): Likewise.
  89         * dwarf-index-cache.c (debug_index_cache): Likewise.
  90         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
  91         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
  92         * dwarf2read.c (check_physname): Likewise.
  93         (use_deprecated_index_sections): Likewise.
  94         (dwarf_always_disassemble): Likewise.
  95         * eval.c (overload_resolution): Likewise.
  96         * event-top.c (set_editing_cmd_var): Likewise.
  97         (exec_done_display_p): Likewise.
  98         * event-top.h (set_editing_cmd_var): Likewise.
  99         (exec_done_display_p): Likewise.
 100         * exec.c (write_files): Likewise.
 101         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 102         (debug_fbsd_nat): Likewise.
 103         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 104         Likewise.
 105         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 106         <backtrace_past_entry> Likewise.
 107         * gdb-demangle.h (demangle): Likewise.
 108         (asm_demangle): Likewise.
 109         * gdb_bfd.c (bfd_sharing): Likewise.
 110         * gdbcore.h (write_files): Likewise.
 111         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 112         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 113         * gdbthread.h (print_thread_events): Likewise.
 114         * gdbtypes.c (opaque_type_resolution): Likewise.
 115         (strict_type_checking): Likewise.
 116         * gnu-nat.c (gnu_debug_flag): Likewise.
 117         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 118         * guile/scm-param.c (pascm_variable): Add boolval.
 119         (add_setshow_generic): Update.
 120         (pascm_param_value): Update.
 121         (pascm_set_param_value_x): Update.
 122         * hppa-tdep.c (hppa_debug): Change to bool..
 123         * infcall.c (may_call_functions_p): Likewise.
 124         (coerce_float_to_double_p): Likewise.
 125         (unwind_on_signal_p): Likewise.
 126         (unwind_on_terminating_exception_p): Likewise.
 127         * infcmd.c (startup_with_shell): Likewise.
 128         * inferior.c (print_inferior_events): Likewise.
 129         * inferior.h (startup_with_shell): Likewise.
 130         (print_inferior_events): Likewise.
 131         * infrun.c (step_stop_if_no_debug): Likewise.
 132         (detach_fork): Likewise.
 133         (debug_displaced): Likewise.
 134         (disable_randomization): Likewise.
 135         (non_stop): Likewise.
 136         (non_stop_1): Likewise.
 137         (observer_mode): Likewise.
 138         (observer_mode_1): Likewise.
 139         (set_observer_mode): Update.
 140         (sched_multi): Change to bool.
 141         * infrun.h (debug_displaced): Likewise.
 142         (sched_multi): Likewise.
 143         (step_stop_if_no_debug): Likewise.
 144         (non_stop): Likewise.
 145         (disable_randomization): Likewise.
 146         * linux-tdep.c (use_coredump_filter): Likewise.
 147         (dump_excluded_mappings): Likewise.
 148         * linux-thread-db.c (auto_load_thread_db): Likewise.
 149         (check_thread_db_on_load): Likewise.
 150         * main.c (captured_main_1): Update.
 151         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 152         xx2_opt, boolean_opt>: Change to bool.
 153         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 154         * maint.c (maintenance_profile_p): Likewise.
 155         (per_command_time): Likewise.
 156         (per_command_space): Likewise.
 157         (per_command_symtab): Likewise.
 158         * memattr.c (inaccessible_by_default): Likewise.
 159         * mi/mi-main.c (mi_async): Likewise.
 160         (mi_async_1): Likewise.
 161         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 162         * nat/fork-inferior.h (startup_with_shell): Likewise.
 163         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 164         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 165         * nios2-tdep.c (nios2_debug): Likewise.
 166         * or1k-tdep.c (or1k_debug): Likewise.
 167         * parse.c (parser_debug): Likewise.
 168         * parser-defs.h (parser_debug): Likewise.
 169         * printcmd.c (print_symbol_filename): Likewise.
 170         * proc-api.c (procfs_trace): Likewise.
 171         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 172         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 173         (set_parameter_value): Update.
 174         (add_setshow_generic): Update.
 175         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 176         to bool*.
 177         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 178         int*.
 179         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 180         * record-btrace.c (record_btrace_target::store_registers): Update.
 181         * record-full.c (record_full_memory_query): Change to bool.
 182         (record_full_stop_at_limit): Likewise.
 183         * record-full.h (record_full_memory_query): Likewise.
 184         * remote-notif.c (notif_debug): Likewise.
 185         * remote-notif.h (notif_debug): Likewise.
 186         * remote.c (use_range_stepping): Likewise.
 187         (interrupt_on_connect): Likewise.
 188         (remote_break): Likewise.
 189         * ser-tcp.c (tcp_auto_retry): Likewise.
 190         * ser-unix.c (serial_hwflow): Likewise.
 191         * skip.c (debug_skip): Likewise.
 192         * solib-aix.c (solib_aix_debug): Likewise.
 193         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 194         (spu_auto_flush_cache_p): Likewise.
 195         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 196         Likewise.
 197         (struct info_print_options) <quiet>: Likewise.
 198         * symfile-debug.c (debug_symfile): Likewise.
 199         * symfile.c (auto_solib_add): Likewise.
 200         (separate_debug_file_debug): Likewise.
 201         * symfile.h (auto_solib_add): Likewise.
 202         (separate_debug_file_debug): Likewise.
 203         * symtab.c (basenames_may_differ): Likewise.
 204         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 205         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 206         (struct info_types_options) <quiet>: Likewise.
 207         * symtab.h (demangle): Likewise.
 208         (basenames_may_differ): Likewise.
 209         * target-dcache.c (stack_cache_enabled_1): Likewise.
 210         (code_cache_enabled_1): Likewise.
 211         * target.c (trust_readonly): Likewise.
 212         (may_write_registers): Likewise.
 213         (may_write_memory): Likewise.
 214         (may_insert_breakpoints): Likewise.
 215         (may_insert_tracepoints): Likewise.
 216         (may_insert_fast_tracepoints): Likewise.
 217         (may_stop): Likewise.
 218         (auto_connect_native_target): Likewise.
 219         (target_stop_and_wait): Update.
 220         (target_async_permitted): Change to bool.
 221         (target_async_permitted_1): Likewise.
 222         (may_write_registers_1): Likewise.
 223         (may_write_memory_1): Likewise.
 224         (may_insert_breakpoints_1): Likewise.
 225         (may_insert_tracepoints_1): Likewise.
 226         (may_insert_fast_tracepoints_1): Likewise.
 227         (may_stop_1): Likewise.
 228         * target.h (target_async_permitted): Likewise.
 229         (may_write_registers): Likewise.
 230         (may_write_memory): Likewise.
 231         (may_insert_breakpoints): Likewise.
 232         (may_insert_tracepoints): Likewise.
 233         (may_insert_fast_tracepoints): Likewise.
 234         (may_stop): Likewise.
 235         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 236         (make_thread_apply_all_options_def_group): Change argument from int*
 237         to bool*.
 238         (thread_apply_all_command): Update.
 239         (print_thread_events): Change to bool.
 240         * top.c (confirm): Likewise.
 241         (command_editing_p): Likewise.
 242         (history_expansion_p): Likewise.
 243         (write_history_p): Likewise.
 244         (info_verbose): Likewise.
 245         * top.h (confirm): Likewise.
 246         (history_expansion_p): Likewise.
 247         * tracepoint.c (disconnected_tracing): Likewise.
 248         (circular_trace_buffer): Likewise.
 249         * typeprint.c (print_methods): Likewise.
 250         (print_typedefs): Likewise.
 251         * utils.c (debug_timestamp): Likewise.
 252         (sevenbit_strings): Likewise.
 253         (pagination_enabled): Likewise.
 254         * utils.h (sevenbit_strings): Likewise.
 255         (pagination_enabled): Likewise.
 256         * valops.c (overload_resolution): Likewise.
 257         * valprint.h (struct value_print_options) <prettyformat_arrays,
 258         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 259         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 260         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 261         Likewise.
 262         * windows-nat.c (new_console): Likewise.
 263         (cygwin_exceptions): Likewise.
 264         (new_group): Likewise.
 265         (debug_exec): Likewise.
 266         (debug_events): Likewise.
 267         (debug_memory): Likewise.
 268         (debug_exceptions): Likewise.
 269         (useshell): Likewise.
 270         * windows-tdep.c (maint_display_all_tib): Likewise.
 271         * xml-support.c (debug_xml): Likewise.
 272
 273 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 274
 275         * source.c (prepare_path_for_appending): New function.
 276         (openp): Make use of new function.
 277         (find_and_open_source): Search for the compilation directory and
 278         source file as a relative path beneath the directory search path.
 279
 280 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * source-cache.c (source_cache::get_line_charpos): Catch
 283         exceptions and return false, this matches the behaviour documented
 284         in the header file.
 285
 286 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 287
 288         * ada-tasks.c (info_task): Remove quoting of the task's name.
 289
 290 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 291
 292         * symfile.c (auto_solib_add): Replace comment with a reference
 293         to the header file.
 294
 295 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 296
 297         * NEWS: Mention that gdb can now be compiled with Python 3
 298         on Windows.
 299
 300 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * maint.c (maint_print_section_data::maint_print_section_data):
 303         Force use of 'float log10 (float)' by casting the argument to
 304         float.
 305
 306 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * maint.c: Add 'cmath' include.
 309         (struct maint_print_section_data): New structure.
 310         (print_section_index): New function.
 311         (print_bfd_section_info): Add header comment, small whitespace
 312         cleanup, and update to call new print_section_index function.
 313         (print_objfile_section_info): Likewise.
 314         (maint_obj_section_from_bfd_section): New function.
 315         (print_bfd_section_info_maybe_relocated): New function.
 316         (maintenance_info_sections): Add header comment, always use
 317         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 318
 319 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 320
 321         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 322         inner scope, add check that the objfile has psymtabs before
 323         checking psymtabs_addrmap.
 324         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 325
 326 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 327
 328         * NEWS: Announce that Ada task names are now shown at more places,
 329         and between quotes (except in info task output).
 330         * gdb/ada-tasks.c (task_to_str): New function.
 331         (display_current_task_id): Call task_to_str.
 332         (task_command_1): Likewise.
 333         (print_ada_task_info): In non-mi mode, Properly align headers and data
 334         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 335
 336 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 337
 338         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 339         prstatus.pr_lwp.pr_info instead of making it up.
 340
 341 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 342
 343         * auto-load.c (auto_load_expand_dir_vars): Update.
 344         * defs.h (gdb_datadir): Change to std::string.
 345         (python_libdir): Likewise.
 346         (relocate_gdb_directory): Change return type to std::string.
 347         * guile/guile.c (gdbscm_data_directory): Update.
 348         (initialize_scheme_side): Update.
 349         * jit.c (jit_reader_dir): Change to std::string.
 350         (jit_reader_load_command): Update.
 351         * main.c (gdb_datadir): Change to std::string.
 352         (python_libdir): Likewise.
 353         (set_gdb_data_directory): Update.
 354         (relocate_path): Change to return std::string.
 355         (relocate_gdb_directory): Change to return std::string.
 356         (relocate_gdbinit_path_maybe_in_datadir): Update.
 357         (captured_main_1): Update.
 358         * python/python.c (do_start_initialization): Update.
 359         * top.c (show_gdb_datadir): Update.
 360         * xml-syscall.c (xml_init_syscalls_info): Update.
 361         (init_syscalls_info): Update.
 362
 363 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 364
 365         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 366         out of get_init_files.
 367         (get_init_files): Update.
 368
 369 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * main.c (get_init_files): Change to use std::string.
 372         (captured_main_1): Update.
 373         (print_gdb_help): Update.
 374
 375 2019-09-11  Ali Tamur  <tamur@google.com>
 376
 377         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 378         implementation.
 379
 380 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 381
 382         * dbxread.c (read_dbx_symtab): Update.
 383         * dwarf2read.c (load_partial_dies): Update.
 384         * mdebugread.c (parse_partial_symbols): Update.
 385         (handle_psymbol_enumerators): Update.
 386         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 387         * psymtab.c (add_psymbol_to_bcache): Likewise.
 388         (add_psymbol_to_list): Likewise.
 389         * symtab.c (symbol_set_names): Likewise.
 390         * symtab.h (symbol_set_names): Likewise.
 391         * xcoffread.c (scan_xcoff_symtab): Update.
 392
 393 2019-09-11  Tom Tromey  <tom@tromey.com>
 394
 395         * symfile-mem.c (symbol_file_add_from_memory): Use
 396         bfd_set_filename.
 397         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 398         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 399
 400 2019-09-10  Tom Tromey  <tromey@adacore.com>
 401
 402         * dwarf-index-write.c (write_psymbols): Extend error message.
 403         (debug_names::insert): Add Ada code.
 404         (debug_names::write_psymbols): Remove Ada check.
 405         (debug_names) <m_string_obstack>: New member.
 406         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 407         (gdb_index_symbol_name_matcher::matches): Remove.
 408         (mapped_index_base::find_name_components_bounds): Add "lang"
 409         parameter.
 410         (mapped_index_base::build_name_components): Also split names
 411         according to Ada syntax.
 412         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 413         type of "match_callback".
 414         (check_match, check_find_bounds_finds)
 415         (dw2_expand_symtabs_matching): Update.
 416         (dw2_debug_names_iterator): Add new constructor.
 417         (dw2_debug_names_map_matching_symbols): New function.
 418         (dw2_debug_names_expand_symtabs_matching): Update.
 419         (dwarf2_debug_names_functions): Use
 420         dw2_debug_names_map_matching_symbols.
 421
 422 2019-09-10  Tom Tromey  <tromey@adacore.com>
 423
 424         * dwarf2read.c (dw2_get_file_names_reader): Add the
 425         CU's file name to the results.
 426
 427 2019-09-10  Tom Tromey  <tromey@adacore.com>
 428
 429         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 430         map_matching_symbols.  Update.
 431         * dwarf2read.c (dw2_map_matching_symbols): Update.
 432         * psymtab.c (match_partial_symbol): Change type; update.
 433         (psym_map_matching_symbols): Likewise.
 434         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 435         type; update.
 436         * symfile.h (struct quick_symbol_functions)
 437         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 438         Remove "match".
 439
 440 2019-09-10  Tom Tromey  <tromey@adacore.com>
 441
 442         * psymtab.c (map_block): Remove.
 443         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 444         * symtab.c (iterate_over_symbols_terminated): New function.
 445         * symtab.c (iterate_over_symbols_terminated): Declare.
 446
 447 2019-09-10  Tom Tromey  <tromey@adacore.com>
 448
 449         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 450         * language.h (struct language_defn) <la_iterate_over_symbols>:
 451         Return bool.
 452         * symtab.c (iterate_over_symbols): Return bool.
 453         * symtab.h (iterate_over_symbols): Return bool.
 454
 455 2019-09-10  Tom Tromey  <tromey@adacore.com>
 456
 457         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 458         (add_nonlocal_symbols): Update.
 459         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 460         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 461         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 462         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 463         Change type of "callback".  Remove "data".
 464
 465
 466 2019-09-09  Ali Tamur  <tamur@google.com>
 467
 468         * dwarf2read.c (comp_unit_head): Update comment.
 469         (dwarf2_dwo_name): New function declaration.
 470         (dwarf_unit_type_name): New function declaration.
 471         (read_comp_unit_head): Add support for new compilation units,
 472         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 473         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 474         (currently named as "signature") in their header. Also clarify error
 475         messages.
 476         (lookup_dwo_id): New function. Returns the dwo id of the given
 477         compile unit.
 478         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 479         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 480         functions.
 481         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 482         (dwarf2_dwo_name): Get the dwo name if present.
 483         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 484         purposes.
 485
 486 2019-09-09  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 489
 490 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 491
 492         * python/python.c (do_start_initialization): Make progname_copy static,
 493         to avoid a leak report.
 494
 495 2019-09-08  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 498
 499 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 500
 501         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 502         Change type to gdb::optional<block_enum>.
 503         (dw2_symtab_iter_init): Change block_index parameter type
 504         to gdb::optional<block_enum>.
 505         (dw2_lookup_symbol): Change block_index parameter
 506         type to block_enum.c
 507         (dw2_debug_names_lookup_symbol): Likewise.
 508         * psymtab.c (psym_lookup_symbol): Likewise.
 509         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 510         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 511         Likewise.
 512
 513 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 514
 515         * defs.h (relocate_gdb_directory): Change int to bool in
 516         signature and rename flag to relocatable.
 517         * main.c (relocate_path): Likewise.
 518         (relocate_gdb_directory): Likewise.
 519
 520 2019-09-06  Alan Modra  <amodra@gmail.com>
 521
 522         * coffread.c (coff_symfile_read): Constify filename variable.
 523         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 524         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 525         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 526         * solib.c (reload_shared_libraries_1): Likewise.
 527         * symfile.c (reread_symbols): Likewise.
 528         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 529         * solib-darwin.c (darwin_bfd_open): Likewise.
 530         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 531
 532 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 535         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 536
 537 2019-09-03  Tom Tromey  <tromey@adacore.com>
 538
 539         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 540         types.
 541         (has_negatives): Unbias a range type bound.
 542         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 543         * gdbtypes.c (operator==): Handle new field.
 544         (create_range_type): Add "bias" parameter.
 545         (create_static_range_type, resolve_dynamic_range): Update.
 546         * gdbtypes.h (struct range_bounds) <bias>: New member.
 547         (create_range_type): Add bias parameter.
 548         * printcmd.c (print_scalar_formatted): Unbias range types.
 549         * value.c (unpack_long): Unbias range types.
 550         (pack_long): Bias range types.
 551
 552 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 553
 554         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 555         probe arguments.
 556
 557 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 558
 559         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 560         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 561         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 562         (compile_probe_arg): Likewise.
 563         * probe.h (get_argument_count): Likewise.
 564         * solib-svr4.c (solib_event_probe_action): Likewise.
 565         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 566
 567 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 568
 569         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 570         code to here...
 571         (svr4_create_solib_event_breakpoints): ...from here.
 572
 573 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 574
 575         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 576         suffix from warning message.
 577
 578 2019-08-30  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-winsource.h (struct tui_source_window_base)
 581         <refresh_all>: Don't declare.
 582         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 583         Remove.
 584         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 585         tui_show_locator_content.
 586         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 587         declare.
 588         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 589         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 590         declare.
 591
 592 2019-08-30  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 595
 596 2019-08-30  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 599         Remove unnecessary forward declarations.
 600
 601 2019-08-30  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 604         rerender.
 605         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 606         tui_show_locator_content.
 607
 608 2019-08-30  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 611         (tui_locator_window::rerender): Rewrite using body of previous
 612         tui_show_locator_content.
 613
 614 2019-08-30  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 617         set_locator_fullname>: New methods.
 618         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 619         Rename from tui_set_locator_fullname.
 620         (tui_locator_window::set_locator_info): Rename from
 621         tui_set_locator_info.  Return bool.
 622         (tui_update_locator_fullname, tui_show_frame_info): Update.
 623
 624 2019-08-30  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 627
 628 2019-08-30  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 631         call touchwin.
 632
 633 2019-08-30  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-wingeneral.c (box_win): Assume win_info and
 636         win_info->handle cannot be NULL.
 637
 638 2019-08-30  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 641         refresh_window>: Declare.
 642         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 643         resize.
 644         (tui_data_item_window::rerender): Rename from
 645         tui_display_register.
 646         (tui_data_item_window::refresh_window): New method.
 647         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 648         no-op.
 649
 650 2019-08-30  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 653         regs_column_count, current_group>: Move later.  Now private.
 654         <get_current_group>: New method.
 655         * tui/tui-regs.c (tui_reg_command): Update.
 656         * tui/tui-layout.c (tui_set_layout): Update.
 657
 658 2019-08-30  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 661         (tui_data_window::rerender): Don't call
 662         check_and_display_highlight_if_needed.
 663         (tui_data_window::refresh_all): Remove call to
 664         erase_data_content.
 665
 666 2019-08-30  Tom Tromey  <tom@tromey.com>
 667
 668         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 669         (tui_data_window::display_registers_from)
 670         (tui_data_window::display_reg_element_at_line)
 671         (tui_data_window::display_registers_from_line): Remove checks of
 672         "empty".
 673
 674 2019-08-30  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 677         Don't declare.
 678         * tui/tui-regs.c (tui_data_window::show_registers): Call
 679         rerender.
 680         (tui_data_window::rerender): Rename from display_all_data.
 681         (tui_data_window::rerender): Remove old implementation.
 682
 683 2019-08-30  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 686         text.
 687         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 688
 689 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 690             Sergio Durigan Junior  <sergiodj@redhat.com>
 691
 692         PR win32/24284
 693         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 694
 695 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 698         when searching for types.
 699
 700 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * f-lang.c (f_language_defn): Use f_print_typedef.
 703         * f-lang.h (f_print_typedef): Declare.
 704         * f-typeprint.c (f_print_typedef): Define.
 705
 706 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 707
 708         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 709
 710 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * cli/cli-utils.c (info_print_options_defs): Delete.
 713         (make_info_print_options_def_group): Delete.
 714         (extract_info_print_options): Delete.
 715         (info_print_command_completer): Delete.
 716         (info_print_args_help): Add extra parameter, and optionally
 717         include text about -n flag.
 718         * cli/cli-utils.h (struct info_print_options): Delete.
 719         (extract_info_print_options): Delete declaration.
 720         (info_print_command_completer): Delete declaration.
 721         (info_print_args_help): Add extra parameter, extend header
 722         comment.
 723         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 724         search_symbols.
 725         * stack.c (struct info_print_options): New type.
 726         (info_print_options_defs): New file scoped variable.
 727         (make_info_print_options_def_group): New static function.
 728         (info_print_command_completer): New static function.
 729         (info_locals_command): Update to use new local functions.
 730         (info_args_command): Likewise.
 731         (_initialize_stack): Add extra parameter to calls to
 732         info_print_args_help.
 733         * symtab.c (search_symbols): Add extra parameter, use this to
 734         possibly excluse non-debug symbols.
 735         (symtab_symbol_info): Add extra parameter, which is passed on to
 736         search_symbols.
 737         (struct info_print_options): New type.
 738         (info_print_options_defs): New file scoped variable.
 739         (make_info_print_options_def_group): New static function.
 740         (info_print_command_completer): New static function.
 741         (info_variables_command): Update to use local functions, and pass
 742         extra parameter through to symtab_symbol_info.
 743         (info_functions_command): Likewise.
 744         (info_types_command): Pass additional argument through to
 745         symtab_symbol_info.
 746         (rbreak_command): Pass extra argument to search_symbols.
 747         (_initialize_symtab): Add extra arguments for calls to
 748         info_print_args_help, and update help text for 'info variables',
 749         'whereis', and 'info functions' commands.
 750         * symtab.h (search_symbols): Add extra argument to declaration.
 751         * NEWS: Mention new flags.
 752
 753 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 754
 755         * symtab.c (lookup_static_symbol): Call the new function (and move
 756         it down to be next to lookup_global_symbol).
 757         (struct global_sym_lookup_data): Add block_enum member and rename to...
 758         (struct global_or_static_sym_lookup_data): ...this.
 759         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 760         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 761         (lookup_symbol_global_or_static_iterator_cb): ...this.
 762         (lookup_global_or_static_symbol): New function.
 763         (lookup_global_symbol): Call new function.
 764
 765 2019-08-26  Tom de Vries  <tdevries@suse.de>
 766
 767         PR c++/24852
 768         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 769         when pc_probe.prob == NULL.
 770
 771 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 772
 773         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 774         variable symbol_linkage to symbol_linkage_.
 775
 776 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 777
 778         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 779         represent whether the symbol is static, dynamic, or we don't
 780         know.
 781
 782 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 783
 784         * gdb/rx-tdep.c (rx_register_names): New.
 785         (rx_register_name): Delete.
 786         (rx_psw_type): Delete.
 787         (rx_fpsw_type): Delete.
 788         (rx_register_type): Delete.
 789         (rx_gdbarch_init): Convert target-descriptions.
 790         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 791         * gdb/features/Makefile: Add rx.xml.
 792         * gdb/features/rx.xml: New.
 793         * gdb/features/rx.c: Generated.
 794         * gdb/NEWS: Mention target description support.
 795
 796 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 797
 798         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 799         *slot_ptr.
 800
 801 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 802
 803         * configure.ac: Don't check for 'dlfcn.h' (moved to
 804         gdbsupport/common.m4).
 805         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 806         'gdbsupport/'.
 807         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 808         * compile/compile-c-support.c: Include
 809         'gdbsupport/gdb-dlfcn.h'.
 810         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 811         * gdb-dlfcn.c: Move to...
 812         * gdbsupport/gdb-dlfcn.c: ... here.
 813         * gdb-dlfcn.h: Move to...
 814         * gdbsupport/gdb-dlfcn.h: ... here.
 815
 816 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 817
 818         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 819         the offset field signed.
 820
 821 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 822
 823         * python/lib/gdb/__init__.py (_execute_file): New function.
 824         * python/python.c (python_run_simple_file): Call gdb._execute_file
 825         on Windows.
 826
 827 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 830         all uses as this was never set to anything but a zero value.
 831
 832 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 833
 834         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 835
 836 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 837
 838         * tui/tui-data.h (tui_gen_win_info): Add an =default
 839         move constructor, required by some GCC versions.
 840
 841 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 842
 843         * go32-nat.c (go32_sysinfo): Add hygon_p.
 844
 845 2019-08-20  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 848         line_from_reg_element_no, first_reg_element_no_inline,
 849         display_all_data, delete_data_content_windows,
 850         erase_data_content>: Now private.
 851
 852 2019-08-20  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 855         (tui_unhighlight_win, tui_highlight_win)
 856         (tui_win_info::make_window): Update.
 857         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 858
 859 2019-08-20  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 862         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 863         (MAX_PID_WIDTH): Move to tui-stack.c.
 864         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 865         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 866         (MAX_PID_WIDTH): Move from tui-data.h.
 867
 868 2019-08-20  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 871         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 872         (box_win): Update.
 873         (tui_gen_win_info::make_window): Rename from tui_make_window.
 874         (tui_win_info::make_window): New method.
 875         (tui_gen_win_info::make_visible): Update.
 876         * tui/tui-source.c (tui_source_window::set_contents): Update.
 877         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 878         (tui_data_window::display_registers_from): Update.
 879         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 880         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 881         Declare.
 882         <can_box>: Remove.
 883         <title>: Remove.
 884         (struct tui_win_info) <make_window>: Declare.
 885         <can_box>: Now virtual.
 886         <title>: New member.
 887         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 888         * tui/tui-command.c (tui_cmd_window::resize): Update.
 889
 890 2019-08-20  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 893         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 894         (tui_data_window::check_register_values): Update.
 895
 896 2019-08-20  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-regs.h (struct tui_data_window): Use
 899         DISABLE_COPY_AND_ASSIGN.
 900         <regs_content>: Change type, removing unique_ptr.
 901         <tui_data_window>: Add move constructor.
 902         * tui/tui-regs.c (tui_data_window::show_registers)
 903         (tui_data_window::show_register_group)
 904         (tui_data_window::display_registers_from)
 905         (tui_data_window::display_registers_from)
 906         (tui_data_window::first_data_item_displayed)
 907         (tui_data_window::delete_data_content_windows)
 908         (tui_data_window::rerender, tui_data_window::refresh_window)
 909         (tui_data_window::check_register_values): Update.
 910
 911 2019-08-20  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 914         show_register_group>: Declare.
 915         (tui_show_register_group): Don't declare.
 916         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 917         tui_show_registers.
 918         (tui_data_window::show_register_group): Rename from
 919         tui_show_register_group.
 920         (tui_data_window::check_register_values, tui_reg_command):
 921         Update.
 922         * tui/tui-layout.c (tui_set_layout): Update.
 923
 924 2019-08-20  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 927         Declare.
 928         (tui_check_register_values): Don't declare.
 929         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 930         from tui_check_register_values.
 931         * tui/tui-hooks.c (tui_register_changed): Update.
 932
 933 2019-08-20  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-regs.c (tui_reg_layout): Move later.
 936         (tui_show_registers): Don't enable TUI mode or change layout.
 937
 938 2019-08-20  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-regs.h (struct tui_data_item_window)
 941         <~tui_data_item_window>: Remove.
 942         <content>: Now a unique_xmalloc_ptr.
 943         * tui/tui-regs.c (tui_register_format): Return a
 944         unique_xmalloc_ptr.
 945         (tui_get_register): Update.
 946         (~tui_data_item_window): Remove.
 947         (tui_data_window::display_registers_from, tui_display_register):
 948         Update.
 949         * tui/tui-io.h (tui_expand_tabs): Update.
 950         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 951         Remove "col" parameter.
 952
 953 2019-08-20  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 956         field.
 957         * tui/tui-regs.c (~tui_data_item_window): Update.
 958
 959 2019-08-20  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 962         earlier.
 963
 964 2019-08-20  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 967
 968 2019-08-20  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-source.h (struct tui_source_window): Update.
 971         * tui/tui-regs.c (tui_show_registers): Update.
 972         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 973         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 974         (NO_REGS_STRING): Remove defines.
 975
 976 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 977
 978         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 979         unnecessary thread walk if remote doesn't support the packet.
 980
 981 2019-08-19  Tom Tromey  <tromey@adacore.com>
 982
 983         * python/py-value.c (value_has_field): Fix indentation.
 984
 985 2019-08-19  Tom Tromey  <tromey@adacore.com>
 986
 987         * printcmd.c (do_one_display, info_display_command): Update.
 988         * block.h (contained_in): Return bool.  Add allow_nested
 989         parameter.
 990         * block.c (contained_in): Return bool.  Add allow_nested
 991         parameter.
 992
 993 2019-08-19  Tom Tromey  <tom@tromey.com>
 994
 995         * configure: Rebuild.
 996         * configure.ac: Disallow the combination of -static-libstdc++ and
 997         source highlight.
 998         * source-cache.c (get_language_name): Handle rust.
 999         (source_cache::get_source_lines): Ignore highlighting exceptions.
1000
1001 2019-08-16  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1004         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1005         (struct tui_source_window_base) <make_visible, refresh_window,
1006         resize>: Remove methods.
1007         <execution_info>: Remove field.
1008         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1009         (tui_show_source_line, tui_source_window_base)
1010         (~tui_source_window_base): Update.
1011         (tui_source_window_base::resize)
1012         (tui_source_window_base::make_visible)
1013         (tui_source_window_base::refresh_window): Remove.
1014         (tui_source_window_base::update_exec_info): Update.
1015         * tui/tui-source.c (tui_source_window::set_contents): Update.
1016         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1017
1018 2019-08-16  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1021         deprecated_query_hook.
1022
1023 2019-08-16  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1026         (tui_update_source_windows_with_line): Update.
1027         * tui/tui-source.h (struct tui_source_window)
1028         <show_symtab_source>: Declare.
1029         (tui_show_symtab_source): Don't declare.
1030         * tui/tui-source.c (tui_show_symtab_source): Rename from
1031         tui_show_symtab_source.
1032
1033 2019-08-16  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-winsource.h (struct tui_source_window_base)
1036         <set_contents>: Declare.
1037         * tui/tui-winsource.c
1038         (tui_source_window_base::update_source_window_as_is): Update.
1039         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1040         Declare.
1041         (tui_set_source_content): Don't declare.
1042         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1043         tui_set_source_content.
1044         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1045         Declare.
1046         (tui_set_disassem_content): Don't declare.
1047         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1048         tui_set_disassem_content.
1049
1050 2019-08-16  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-winsource.h (struct tui_source_window_base)
1053         <update_breakpoint_info>: Declare.
1054         (tui_update_breakpoint_info): Don't declare.
1055         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1056         (tui_update_all_breakpoint_info): Update.
1057         (tui_source_window_base::update_breakpoint_info): Rename from
1058         tui_update_breakpoint_info.
1059         (tui_source_window_base::update_exec_info): Update.
1060
1061 2019-08-16  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-winsource.h (struct tui_source_window_base)
1064         <update_source_window>: Declare.
1065         (tui_update_source_window): Don't declare.
1066         * tui/tui-winsource.c
1067         (tui_source_window_base::update_source_window): Rename from
1068         tui_update_source_window.
1069         (tui_source_window_base::rerender): Update.
1070         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1071         * tui/tui-disasm.c (tui_show_disassem)
1072         (tui_show_disassem_and_update_source)
1073         (tui_disasm_window::maybe_update): Update.
1074
1075 2019-08-16  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-winsource.h (struct tui_source_window_base)
1078         <update_source_window_as_is>: Declare.
1079         (tui_update_source_window_as_is): Don't declare.
1080         * tui/tui-winsource.c (tui_update_source_window): Update
1081         (tui_source_window_base::update_source_window_as_is): Rename from
1082         tui_update_source_window_as_is.
1083         (tui_source_window_base::refill): Update.
1084         * tui/tui-source.c (tui_show_symtab_source): Update.
1085         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1086         Update.
1087
1088 2019-08-16  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-winsource.h (tui_update_source_window)
1091         (tui_update_source_window_as_is): Remove "noerror" parameter.
1092         * tui/tui-winsource.c (tui_update_source_window)
1093         (tui_update_source_window_as_is): Remove "noerror" parameter.
1094         (tui_update_source_windows_with_addr)
1095         (tui_update_source_windows_with_line)
1096         (tui_source_window_base::rerender)
1097         (tui_source_window_base::refill): Update.
1098         * tui/tui-source.h (tui_set_source_content)
1099         (tui_show_symtab_source): Remove "noerror" parameter.
1100         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1101         parameter.
1102         (tui_show_symtab_source): Likewise.
1103         (tui_source_window::maybe_update): Update.
1104         * tui/tui-disasm.c (tui_show_disassem)
1105         (tui_show_disassem_and_update_source)
1106         (tui_disasm_window::do_scroll_vertical)
1107         (tui_disasm_window::maybe_update): Update.
1108
1109 2019-08-16  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui.c (tui_is_window_visible): Update.
1112         * tui/tui-wingeneral.c (tui_make_window)
1113         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1114         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1115         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1116         (tui_set_win_height_command, parse_scrolling_args): Update.
1117         * tui/tui-source.c (tui_source_window::style_changed): Update.
1118         * tui/tui-regs.c (tui_show_registers)
1119         (tui_data_window::first_data_item_displayed)
1120         (tui_data_window::delete_data_content_windows)
1121         (tui_check_register_values, tui_reg_command): Update.
1122         * tui/tui-disasm.c (tui_show_disassem): Update.
1123         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1124         method.
1125         <is_visible>: Remove field.
1126         * tui/tui-data.c (tui_next_win, tui_prev_win)
1127         (tui_delete_invisible_windows): Update.
1128
1129 2019-08-16  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui-winsource.h (struct tui_source_window_base)
1132         <m_has_locator>: Remove.
1133         * tui/tui-layout.c (show_source_disasm_command, show_data)
1134         (show_source_or_disasm_and_command): Update.
1135
1136 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * NEWS (Other MI changes): New subsection.
1139         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1140         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1141         * arch-utils.c (default_get_pc_address_flags): New function.
1142         * arch-utils.h (default_get_pc_address_flags): New declaration.
1143         * gdbarch.sh: Add get_pc_address_flags.
1144         * gdbarch.c: Regenerate.
1145         * gdbarch.h: Likewise.
1146         * stack.c (print_pc): New function.
1147         (print_frame_info) (print_frame): Call print_pc.
1148
1149 2019-08-16  Tom de Vries  <tdevries@suse.de>
1150
1151         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1152         print_objfile_section_info.
1153
1154 2019-08-15  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1157         calling update_cmdwin_start_line.
1158         * tui/tui-winsource.h (struct tui_source_window_base)
1159         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1160         <rerender>: Declare.
1161         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1162         Call rerender.
1163         (tui_source_window_base::set_new_height): Remove.
1164         (tui_source_window_base::rerender): Rename from
1165         do_make_visible_with_new_height.
1166         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1167         resize method.
1168         (tui_win_info::make_invisible_and_set_new_height)
1169         (tui_win_info::make_visible_with_new_height): Remove.
1170         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1171         Declare.
1172         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1173         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1174         do_make_visible_with_new_height>: Don't declare.
1175         <rerender>: Declare.
1176         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1177         set_new_height.
1178         (tui_data_window::do_make_visible_with_new_height): Remove.
1179         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1180         call tui_show_locator_content.
1181         (tui_gen_win_info::resize): Call rerender.
1182         (show_source_or_disasm_and_command): Don't call
1183         tui_show_locator_content.
1184         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1185         method.
1186         (struct tui_win_info) <rerender>: Declare.
1187         <set_new_height, make_invisible_and_set_new_height,
1188         make_visible_with_new_height>: Don't declare.
1189         * tui/tui-data.c (tui_win_list::rerender): New method.
1190         * tui/tui-command.h (struct tui_cmd_window)
1191         <do_make_visible_with_new_height>: Don't declare.
1192         * tui/tui-command.c
1193         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1194
1195 2019-08-15  Tom Tromey  <tromey@adacore.com>
1196
1197         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1198         * ada-lang.c (ada_enum_name): Likewise.
1199
1200 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1201
1202         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1203         leading underscore.
1204         (GdbOutputErrorFile): Likewise.
1205         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1206         accordingly.
1207         (execute_unwinders): Rename to have a leading underscore.
1208         (auto_load_packages): Likewise.
1209         (global scope): Adjust call to auto_load_packages accordingly.
1210         (GdbSetPythonDirectory): Likewise.
1211         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1212         instead of execute_unwinders.
1213
1214 2019-08-15  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1217         (show_data): Don't change window visibility.
1218         (tui_gen_win_info::resize): Remove special case for command
1219         window.  Use wresize, when available.
1220         (show_source_or_disasm_and_command): Don't change window
1221         visibility.
1222         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1223         <make_visible>: New method.
1224         * tui/tui-command.c (tui_cmd_window::resize): New method.
1225
1226 2019-08-15  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1229         (struct tui_source_windows): New.
1230         * tui/tui-winsource.c (tui_display_main): Update.
1231         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1232         (new_height_ok, parse_scrolling_args): Update.
1233         * tui/tui-layout.c (show_layout, show_data): Update.
1234         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1235         (tui_add_to_source_windows): Don't declare.
1236         * tui/tui-data.c (source_windows, tui_source_windows)
1237         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1238
1239 2019-08-15  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1242         Rename from reset.
1243         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1244         * tui/tui-layout.c (show_source_disasm_command, show_data):
1245         Update.
1246         (tui_gen_win_info::resize): Rename.
1247         (show_source_or_disasm_and_command): Update.
1248         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1249         reset.
1250
1251 2019-08-15  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1254         * tui/tui-interp.c (tui_interp::init): Don't call
1255         tui_initialize_static_data.
1256         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1257
1258 2019-08-15  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1261         examine tui_win_list.
1262
1263 2019-08-15  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1266         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1267         tui_clear_source_content.
1268         (tui_clear_source_content): Remove.
1269         (tui_source_window_base::do_erase_source_content): Hoist call to
1270         content.clear().
1271         * tui/tui-stack.c (tui_show_frame_info): Don't call
1272         tui_clear_source_content.
1273
1274 2019-08-15  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-winsource.h (struct tui_source_window_base)
1277         <do_erase_source_content>: New method.
1278         <erase_source_content>: New method.
1279         (tui_erase_source_content): Don't declare.
1280         * tui/tui-winsource.c (tui_clear_source_content): Update.
1281         (tui_source_window_base::do_erase_source_content): Rename from
1282         tui_erase_source_content.
1283         (tui_source_window_base::show_source_content): Update.
1284         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1285         * tui/tui-source.h (struct tui_source_window)
1286         <erase_source_content>: New method.
1287         * tui/tui-disasm.h (struct tui_disasm_window)
1288         <erase_source_content>: New method.
1289
1290 2019-08-15  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1293         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1294         constructor.
1295         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1296         * tui/tui-source.c (tui_set_source_content): Update.
1297         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1298
1299 2019-08-15  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1302         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1303         tui-source.c.
1304         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1305         Declare.
1306         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1307         method.
1308         (tui_source_window::maybe_update): Update.
1309
1310 2019-08-15  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1313         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1314         tui-disasm.c.
1315         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1316         Declare.
1317         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1318         method.
1319         (tui_disasm_window::maybe_update): Update.
1320
1321 2019-08-15  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-winsource.h (struct tui_source_window_base)
1324         <maybe_update>: Declare.
1325         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1326         method.
1327         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1328         Declare.
1329         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1330         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1331         Declare.
1332         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1333
1334 2019-08-15  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1337
1338 2019-08-15  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-wingeneral.c: Include tui-stack.h.
1341         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1342         (struct tui_locator_window): Move from tui-data.h.
1343         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1344         (tui_initialize_static_data): Move from tui-data.c.
1345         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1346         (struct tui_locator_window): Move to tui-stack.c.
1347         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1348         (tui_initialize_static_data): Move to tui-stack.c.
1349
1350 2019-08-15  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-layout.c (show_source_disasm_command)
1353         (show_source_or_disasm_and_command): Use make_visible method, not
1354         tui_make_window.
1355         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1356         Remove.
1357
1358 2019-08-15  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-wingeneral.h (tui_make_window): Update.
1361         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1362         parameter.
1363         (tui_gen_win_info::make_visible): Update.
1364         * tui/tui-regs.c (tui_data_window::display_registers_from):
1365         Update.
1366         * tui/tui-layout.c (show_source_disasm_command)
1367         (show_source_or_disasm_and_command): Update.
1368         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1369         (enum tui_box): Remove.
1370         (struct tui_win_info) <can_box>: New method.
1371         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1372         method.
1373
1374 2019-08-15  Tom de Vries  <tdevries@suse.de>
1375
1376         * linux-nat-trad.c: Include gdbarch.h.
1377
1378 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1379
1380         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1381         register sizes.
1382
1383 2019-08-14  Tom Tromey  <tromey@adacore.com>
1384
1385         * darwin-nat.c: Include gdbarch.h.
1386         * darwin-nat-info.c: Include gdbarch.h.
1387
1388 2019-08-13  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1391         Remove.
1392         * tui/tui-data.c (tui_initialize_static_data): Update.
1393
1394 2019-08-13  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-winsource.h (struct tui_exec_info_window)
1397         <~tui_exec_info_window, maybe_allocate_content, get_content,
1398         m_content>: Remove.
1399         (struct tui_source_window_base) <set_exec_info_content,
1400         show_exec_info_content>: Don't declare.
1401         * tui/tui-winsource.c
1402         (tui_exec_info_window::maybe_allocate_content): Remove.
1403         (tui_source_window_base::update_exec_info): Rename from
1404         set_exec_info_content.
1405         (tui_source_window_base::show_exec_info_content)
1406         (tui_source_window_base::update_exec_info): Remove.
1407
1408 2019-08-13  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1411         declare.
1412         * tui/tui-winsource.c (tui_update_source_window_as_is)
1413         (tui_update_source_windows_with_addr, tui_erase_source_content):
1414         Update.
1415         (tui_clear_exec_info_content): Remove.
1416
1417 2019-08-13  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1420         declare.
1421         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1422         call tui_erase_exec_info_content.
1423         (tui_clear_exec_info_content): Rename from
1424         tui_erase_exec_info_content.
1425         (tui_clear_exec_info_content): Delete.
1426
1427 2019-08-13  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-winsource.h (struct tui_source_window_base)
1430         <show_exec_info_content>: Declare.
1431         (tui_show_exec_info_content): Don't declare.
1432         * tui/tui-winsource.c
1433         (tui_source_window_base::show_exec_info_content): Rename from
1434         tui_show_exec_info_content.
1435         (tui_source_window_base::update_exec_info): Update.
1436
1437 2019-08-13  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1440         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1441         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1442         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1443         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1444         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1445         ... here.
1446
1447 2019-08-13  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-winsource.h (struct tui_source_window_base)
1450         <update_exec_info>: Declare.
1451         (tui_update_exec_info): Don't declare.
1452         * tui/tui-winsource.c (tui_update_source_window_as_is)
1453         (tui_source_window_base::refresh_all)
1454         (tui_update_all_breakpoint_info): Update.
1455         (tui_source_window_base::update_exec_info): Rename from
1456         tui_update_exec_info.
1457         * tui/tui-stack.c (tui_show_frame_info): Update.
1458
1459 2019-08-13  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-winsource.h (struct tui_source_window_base)
1462         <set_exec_info_content>: Declare.
1463         (tui_set_exec_info_content): Don't declare.
1464         * tui/tui-winsource.c
1465         (tui_source_window_base::set_exec_info_content): Rename from
1466         tui_set_exec_info_content.
1467         (tui_update_exec_info): Update.
1468
1469 2019-08-13  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.h (struct tui_source_window_base)
1472         <show_source_content>: Declare.
1473         (tui_show_source_content): Don't declare.
1474         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1475         (tui_source_window_base::show_source_content): Rename from
1476         tui_show_source_content.
1477         (tui_source_window_base::refresh_all): Update.
1478         * tui/tui-layout.c (show_source_disasm_command)
1479         (show_source_or_disasm_and_command): Update.
1480
1481 2019-08-13  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-winsource.c (tui_erase_source_content)
1484         (tui_show_source_content, tui_source_window_base::refresh_all):
1485         Update.
1486         * tui/tui-wingeneral.h
1487         (tui_check_and_display_highlight_if_needed): Don't declare.
1488         * tui/tui-wingeneral.c
1489         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1490         check_and_display_highlight_if_needed.
1491         * tui/tui-win.c (tui_rehighlight_all)
1492         (tui_win_info::make_visible_with_new_height): Update.
1493         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1494         (tui_data_window::erase_data_content)
1495         (tui_data_window::display_all_data): Update.
1496         * tui/tui-data.h (struct tui_win_info)
1497         <check_and_display_highlight_if_needed>: Declare.
1498
1499 2019-08-13  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-win.c (tui_resize_all): Call
1502         tui_delete_invisible_windows.
1503         * tui/tui-layout.c (show_layout): Call
1504         tui_delete_invisible_windows.
1505         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1506         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1507
1508 2019-08-13  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1511         tui_add_win_to_layout.
1512
1513 2019-08-13  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1516         * tui/tui-layout.c (tui_default_win_height): Now static.
1517
1518 2019-08-13  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1521         single switch.
1522         (show_source_disasm_command, show_source_or_disasm_and_command):
1523         Don't check current layout.
1524
1525 2019-08-13  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-wingeneral.c (make_all_visible): Remove.
1528         (tui_make_all_invisible): Simplify.
1529         * tui/tui-layout.c (tui_make_all_invisible): Move from
1530         tui-wingeneral.c; simplify.
1531         (show_layout): Hoist call to tui_make_all_invisible.
1532         (show_data): Don't call tui_make_all_invisible.
1533
1534 2019-08-13  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1537         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1538
1539 2019-08-13  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1542         tui-data.c.
1543         (show_source_disasm_command, show_data)
1544         (show_source_or_disasm_and_command): Don't use
1545         tui_set_current_layout_to.
1546         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1547         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1548         tui-layout.c.
1549         (tui_set_current_layout_to): Remove.
1550
1551 2019-08-13  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-layout.c (tui_set_layout): Update.
1554         * tui/tui-data.h (struct tui_layout_def): Remove.
1555         (tui_layout_def): Don't declare.
1556         * tui/tui-data.c (layout_def): Remove.
1557         (tui_layout_def): Remove.
1558
1559 2019-08-13  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-winsource.h (struct tui_source_window_base)
1562         <clear_detail>: No longer "override".
1563         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1564         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1565         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1566         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1567         Remove.
1568         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1569
1570 2019-08-13  Tom Tromey  <tromey@adacore.com>
1571
1572         * tracepoint.c: Don't include readline.h or history.h.
1573
1574 2019-08-12  Tom Tromey  <tom@tromey.com>
1575
1576         * configure: Rebuild.
1577         * configure.ac: Check for readline 7.
1578         * NEWS: Mention readline 7 requirement.
1579         * README: Update.
1580
1581 2019-08-12  Tom Tromey  <tom@tromey.com>
1582
1583         * mingw-hdep.c (gdb_select): Remove readline hack.
1584
1585 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1586
1587         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1588         when the function fails.
1589
1590 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1591
1592         * s390-tdep.c (s390_type_align): New function.
1593         (s390_gdbarch_init): Set it as type_align gdbarch method.
1594
1595 2019-08-09  Tom de Vries  <tdevries@suse.de>
1596
1597         PR gdb/24591
1598         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1599         pc_low with relocation offset.
1600
1601 2019-08-07  Tom Tromey  <tromey@adacore.com>
1602
1603         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1604         (print_frame_args): Update.
1605         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1606         Update.
1607         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1608         * frame.h (struct frame_arg): Add initializers.
1609         <error>: Now a unique_xmalloc_ptr.
1610
1611 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1612
1613         * NEWS: Expand the Pointer Authentication entry.
1614         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1615         (aarch64_frame_unmask_lr): ... to this.
1616         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1617         Call aarch64_frame_unmask_lr.
1618         * frame.c (struct frame_info): Add "masked" variable.
1619         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1620         (fprint_frame): Check for masked pc.
1621         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1622         declarations.
1623         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1624         * stack.c (print_frame): Check for masked pc.
1625
1626 2019-08-06  Tom Tromey  <tom@tromey.com>
1627
1628         * stabsread.c (patch_block_stabs, read_one_struct_field)
1629         (read_enum_type): Use obstack_strndup.
1630         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1631         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1632         * dwarf2read.c (guess_full_die_structure_name)
1633         (anonymous_struct_prefix): Use obstack_strndup.
1634         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1635         * c-exp.y (yylex): Use obstack_strndup.
1636         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1637         (write_var_or_type): Use obstack_strndup.
1638
1639 2019-08-06  Tom Tromey  <tom@tromey.com>
1640
1641         * symfile.c (reread_symbols): Use obstack_strdup.
1642         * stabsread.c (read_type): Use obstack_strdup.
1643         * gdb_obstack.h (obstack_strdup): New overload.
1644         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1645         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1646         (dwarf2_canonicalize_name): Use obstack_strdup.
1647         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1648         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1649         Use obstack_strdup.
1650
1651 2019-08-06  Tom Tromey  <tom@tromey.com>
1652
1653         * gdb_obstack.h (obstack_strdup): Define.
1654         * gdb_obstack.c (obstack_strdup): Don't define.
1655
1656 2019-08-06  Tom Tromey  <tom@tromey.com>
1657
1658         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1659         obstack_strdup.
1660         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1661         obstack_strdup.
1662         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1663         * stabsread.c (common_block_start): Use obstack_strdup.
1664         * objfiles.c (set_objfile_main_name, objfile): Use
1665         obstack_strdup.
1666         * namespace.c (add_using_directive): Use obstack_strdup.
1667         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1668         * jit.c (finalize_symtab): Use obstack_strdup.
1669         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1670         (guess_partial_die_structure_name, partial_die_info::fixup)
1671         (dwarf2_name): Use obstack_strdup.
1672         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1673         obstack_strdup.
1674         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1675         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1676         obstack_strdup.
1677         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1678
1679 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1680
1681         * unittests/help-doc-selftests.c: New file.
1682         * Makefile.in: Add the new file.
1683
1684 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1685
1686         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1687         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1688         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1689         the trailing '.' is not output, and the first character is uppercased.
1690         (print_help_for_command): Update call to print_doc_line.
1691         (print_doc_of_command): Likewise.
1692         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1693         * cli/cli-option.c (append_indented_doc): Do not append newline.
1694         (build_help_option): Append newline after first appended_indented_doc
1695         only if a second call is done.
1696         (build_help): Append 2 new lines before each option, except the first
1697         one.
1698         * compile/compile.c (_initialize_compile): Add new lines after
1699         %OPTIONS%, when not at the end of the help.
1700         Change help doc or code
1701         producing the help doc to respect the invariants.
1702         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1703         Also removed the new line after 'Options:', as all other commands
1704         do not put an empty line between 'Options:' and the first option.
1705         * printcmd.c (_initialize_printcmd): Likewise.
1706         * stack.c (_initialize_stack): Likewise.
1707         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1708         incorrectly telling COMMAND is optional.
1709         * ada-lang.c (_initialize_ada_language): Change help doc or code
1710         producing the help doc to respect the invariants.
1711         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1712         * breakpoint.c (_initialize_breakpoint): Likewise.
1713         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1714         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1715         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1716         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1717         _initialize_cli_style): Likewise.
1718         * corelow.c (core_target_info): Likewise.
1719         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1720         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1721         * filesystem.c (_initialize_filesystem): Likewise.
1722         * frame.c (_initialize_frame): Likewise.
1723         * gnu-nat.c (add_task_commands): Likewise.
1724         * infcall.c (_initialize_infcall): Likewise.
1725         * infcmd.c (_initialize_infcmd): Likewise.
1726         * interps.c (_initialize_interpreter): Likewise.
1727         * language.c (_initialize_language): Likewise.
1728         * linux-fork.c (_initialize_linux_fork): Likewise.
1729         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1730         * maint.c (_initialize_maint_cmds): Likewise.
1731         * memattr.c (_initialize_mem): Likewise.
1732         * printcmd.c (_initialize_printcmd): Likewise.
1733         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1734         _RegEx): Likewise.
1735         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1736         * record-btrace.c (_initialize_record_btrace): Likewise.
1737         * record-full.c (_initialize_record_full): Likewise.
1738         * record.c (_initialize_record): Likewise.
1739         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1740         * regcache.c (_initialize_regcache): Likewise.
1741         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1742         _initialize_remote): Likewise.
1743         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1744         * serial.c (_initialize_serial): Likewise.
1745         * skip.c (_initialize_step_skip): Likewise.
1746         * source.c (_initialize_source): Likewise.
1747         * stack.c (_initialize_stack): Likewise.
1748         * symfile.c (_initialize_symfile): Likewise.
1749         * symtab.c (_initialize_symtab): Likewise.
1750         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1751         * top.c (init_main): Likewise.
1752         * tracefile-tfile.c (tfile_target_info): Likewise.
1753         * tracepoint.c (_initialize_tracepoint): Likewise.
1754         * tui/tui-win.c (_initialize_tui_win): Likewise.
1755         * utils.c (add_internal_problem_command): Likewise.
1756         * valprint.c (value_print_option_defs): Likewise.
1757
1758 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1759
1760         PR build/24886
1761         * configure.ac: Drop enable-libmcheck support.
1762         * configure, config.in: Rebuild.
1763         * libmcheck.m4: Remove.
1764         * acinclude.m4: Don't include it.
1765         * Makefile.in: Don't distribute it.
1766         * top.c (print_gdb_configuration): Don't mention it.
1767
1768 2019-08-06  Tom Tromey  <tom@tromey.com>
1769
1770         * utils.c (set_output_style): Sometimes pass stream to
1771         emit_style_escape.
1772         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1773         * record-btrace.c (btrace_insn_history): Update.
1774         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1775         method.
1776         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1777         Update initializers.
1778         <m_uiout>: New field.
1779         <m_di>: Move lower.
1780         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1781         Remove "uiout" parameter.
1782         (dump_insns): Update.
1783         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1784         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1785
1786 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1787
1788         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1789         (error_in_psymtab_expansion): Likewise.
1790         (lookup_symbol_via_quick_fns): Likewise.
1791         (basic_lookup_transparent_type_quick): Likewise.
1792         (basic_lookup_transparent_type_1): Likewise.
1793
1794 2019-08-06  Tom Tromey  <tromey@adacore.com>
1795
1796         * source.c (last_source_error): Now bool.
1797         (print_source_lines_base): Make "noprint" bool.  Only open
1798         source file when last_source_visited changes.
1799
1800 2019-08-06  Tom Tromey  <tromey@adacore.com>
1801
1802         * annotate.c (annotate_source_line): Use g_source_cache.
1803         * source-cache.c (source_cache::get_plain_source_lines): Change
1804         parameters.  Populate m_offset_cache.
1805         (source_cache::ensure): New method.
1806         (source_cache::get_line_charpos): New method.
1807         (extract_lines): Move lower.  Change parameters.
1808         (source_cache::get_source_lines): Move lower.
1809         * source-cache.h (class source_cache): Update comment.
1810         <get_line_charpos>: New method.
1811         <get_source_lines>: Update comment.
1812         <clear>: Clear m_offset_cache.
1813         <get_plain_source_lines>: Change parameters.
1814         <ensure>: New method
1815         <m_offset_cache>: New member.
1816         * source.c (forget_cached_source_info_for_objfile): Update.
1817         (info_source_command): Use g_source_cache.
1818         (find_source_lines, open_source_file_with_line_charpos): Remove.
1819         (print_source_lines_base, search_command_helper): Use g_source_cache.
1820         * source.h (open_source_file_with_line_charpos): Don't declare.
1821         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1822         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1823         Use g_source_cache.
1824
1825 2019-08-06  Tom Tromey  <tromey@adacore.com>
1826
1827         * source-cache.c (source_cache::get_plain_source_lines):
1828         Remove "first_line" and "last_line" parameters.
1829         (source_cache::get_source_lines): Cache plain text.
1830         * source-cache.h (class source_cache)
1831         <get_plain_source_lines>: Update.
1832
1833 2019-08-06  Tom Tromey  <tromey@adacore.com>
1834
1835         * source-cache.c (extract_lines): No longer a method.
1836         Changed type of parameter.  Include final newline.
1837         (selftests::extract_lines_test): New function.
1838         (_initialize_source_cache): Likewise.
1839         * source-cache.h (class source_cache)
1840         <extract_lines>: Don't declare.
1841
1842 2019-08-06  Tom Tromey  <tromey@adacore.com>
1843
1844         * breakpoint.c (init_breakpoint_sal): Update.
1845         (breakpoint): Update.
1846         * breakpoint.h (struct breakpoint) <filter>: Now a
1847         unique_xmalloc_ptr.
1848
1849 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1850
1851         * NEWS: Mention dictionary access on blocks.
1852         * python/py-block.c (blpy_getitem): New function.
1853         (block_object_as_mapping): New struct.
1854         (block_object_type): Use new struct for tp_as_mapping field.
1855
1856 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1857
1858         * objfiles.h (objfile): Add a comment describing partial symbols.
1859
1860 2019-08-05  Tom Tromey  <tromey@adacore.com>
1861
1862         * compile/compile.c (_initialize_compile): Use _(), not N_().
1863         * thread.c (_initialize_thread): Use _(), not N_().
1864         * stack.c (_initialize_stack): Use _(), not N_().
1865         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1866
1867 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1868
1869         * dwarf2read.c (struct dw2_symtab_iterator):
1870         <want_specific_block>: Remove.
1871         <block_index>: Change type to gdb::optional.
1872         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1873         change type of BLOCK_INDEX parameter to gdb::optional.
1874         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1875         (dw2_lookup_symbol): Don't pass argument for
1876         WANT_SPECIFIC_BLOCK.
1877         (dw2_expand_symtabs_for_function): Don't pass argument for
1878         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1879         (class dw2_debug_names_iterator)
1880         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1881         parameter, change BLOCK_INDEX type to gdb::optional.
1882         <m_want_specific_block>: Remove.
1883         <m_block_index>: Change type to gdb::optional.
1884         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1885         gdb::optional.  Re-write in function of gdb::optional.
1886         (dw2_debug_names_lookup_symbol): Don't pass argument for
1887         WANT_SPECIFIC_BLOCK.
1888         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1889         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1890         BLOCK_INDEX.
1891
1892 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1893
1894         * NEWS: Mention changes to "info sources" command.
1895
1896 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1897
1898         * symtab.c (filename_partial_match_opts): New struct type.
1899         (struct output_source_filename_data): New members
1900         regexp, c_regexp, partial_match.
1901         (output_source_filename): Use new members to decide to print file.
1902         (info_sources_option_defs): New variable.
1903         (make_info_sources_options_def_group, print_info_sources_header,
1904         info_sources_command_completer):
1905         New functions.
1906         (info_sources_command): Read new optional arguments.
1907         (_initialize_symtab): Update info sources help.
1908
1909 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1910
1911         * ada-lang.c (exception_support_info_v0): Renamed from...
1912         (default_exception_support_info): ... this.  Create new
1913         definition for v1.
1914         (ada_has_this_exception_support): Look up catch_handlers_sym.
1915         (ada_exception_support_info_sniffer): Try v0 after default.
1916
1917 2019-08-01  Tom Tromey  <tromey@adacore.com>
1918
1919         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1920         gdbarch.h.
1921
1922 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1923
1924         * s12z-tdep.c: Fix include path for s12z-opc.h.
1925
1926 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1927
1928         * NEWS: Require GNU make 3.82.
1929
1930 2019-07-16  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1933         declare.
1934
1935 2019-07-30  Tom Tromey  <tromey@adacore.com>
1936
1937         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1938
1939 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1940
1941         * printcmd.c (print_address_symbolic): Print negative offsets.
1942         (build_address_symbolic): Force signed arithmetic when computing
1943         offset.
1944
1945 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1946
1947         PR/24474: Add a function to lookup static variables.
1948         * NEWS: Mention this new function.
1949         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1950         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1951         * python/python.c (python_GdbMethods): Add new function.
1952
1953 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1954
1955         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1956         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1957         (objfpy_lookup_static_symbol): New function.
1958         (objfile_object_methods): Add new functions.
1959
1960 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1961
1962         * NEWS: Mention 'set|show print frame-info'.  Mention new
1963         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1964         backtrace argument.  Mention that python frame filtering code
1965         is now consistent with what 'backtrace' command prints.
1966
1967 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1968
1969         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1970         comments.
1971         (print_frame_info_auto, print_frame_info_source_line,
1972         print_frame_info_location, print_frame_info_source_and_location,
1973         print_frame_info_location_and_address, print_frame_info_short_location):
1974         New declarations.
1975         (struct frame_print_options): New member print_frame_info.
1976         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1977         * stack.h (get_user_print_what_frame_info): New declaration.
1978         (frame_show_address): New declaration.
1979         * stack.c (print_frame_arguments_choices): New value 'presence'.
1980         (print_frame_info_auto, print_frame_info_source_line,
1981         print_frame_info_location, print_frame_info_source_and_location,
1982         print_frame_info_location_and_address, print_frame_info_short_location,
1983         print_frame_info_choices, print_frame_info_print_what): New definitions.
1984         (print_frame_args): Only print dots for args if print frame-arguments
1985         is 'presence'.
1986         (frame_print_option_defs): New element for "frame-info".
1987         (get_user_print_what_frame_info): New function.
1988         (frame_show_address): Make non static.  Move comment to stack.h.
1989         (print_frame_info_to_print_what): New function.
1990         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1991         to decide what to print.
1992         (backtrace_command_1): Handle the new print_frame_arguments_presence
1993         value.
1994         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1995         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1996         (py_print_frame): In non-mi mode, use LOCATION as default for
1997         print_what, similarly to frame information printed directly by
1998         backtrace command. Handle frame-info user option in non MI mode.
1999
2000 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2001
2002         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2003         Add case for debugging 32-bit target on 64-bit host.  Revise
2004         comment.
2005
2006 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2007
2008         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2009         instead of find_function_entry_range_from_pc.
2010
2011 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2012
2013         * stack.c (find_frame_funname): Remove code which preferred
2014         minsym over symtab sym in "certain pathological cases".
2015
2016         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2017         parameter.  Change type of "do_demangle" to bool.
2018         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2019         Pass suitable "prefer_sym_over_minsym" flag to
2020         build_address_symbolic().  Don't output "+" for negative offsets.
2021         * printcmd.c (print_address_symbolic): Update invocation of
2022         build_address_symbolic to include a "prefer_sym_over_minsym"
2023         flag.
2024         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2025         Restrict cases in which use of minimal symbol is preferred to that
2026         of a found symbol.  Update comments.
2027
2028         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2029         for entry pc when entry pc is out of range for that FDE.
2030
2031 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2032
2033         PR gdb/24839:
2034         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2035         type.
2036
2037 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2038
2039         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2040         this function's Python signature.
2041
2042
2043 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2044
2045         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2046         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2047         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2048         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2049         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2050
2051
2052 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2053
2054         * h8300-tdep.c (h8300_register_name_common): New.
2055         h8300_register_name): Use h8300_register_name_common.
2056         (h8300s_register_name): Likewise.
2057         (h8300sx_register_name): Likewise.
2058         (h8300h_register_nam): New.
2059         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2060
2061
2062 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2063
2064         * arm-tdep.c (arm_skip_cmse_entry): New function.
2065         (arm_is_sgstubs_section): New function.
2066         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2067
2068 2019-07-22  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2071         Don't self-assign.
2072
2073 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2074
2075         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2076         type_print.
2077
2078 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2081         so that GDB doesn't match any msymbols when searching in the
2082         TYPES_DOMAIN.
2083         (print_symbol_info): Print using typedef_print or type_print based
2084         on the type of the symbol.  Add updated FIXME comment moved from...
2085         (_initialize_symtab): ... move and update FIXME comment to above.
2086
2087 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * NEWS: Mention adding -q option to "info types".
2090         * symtab.c (struct info_types_options): New struct.
2091         (info_types_options_defs): New variable.
2092         (make_info_types_options_def_group): New function.
2093         (info_types_command): Use gdb::option framework to parse options.
2094         (info_types_command_completer): New function.
2095         (_initialize_symtab): Extend the help text on "info types" and
2096         register command completer.
2097
2098 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2099
2100         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2101         (lookup_symbol_in_objfile): Change int to block_enum and add a
2102         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2103
2104 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2105
2106         * MAINTAINERS (Write After Approval): Add self.
2107
2108 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2109
2110         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2111         instruction to the dummy code region.
2112
2113 2019-07-19  Tom Tromey  <tromey@adacore.com>
2114
2115         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2116         (ARGSUSED, PARAMS, __func__): Remove rules.
2117
2118 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2119
2120         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2121         * features/arm/arm-with-iwmmxt.c: Remove.
2122         * features/arm/arm-with-iwmmxt.xml: Remove.
2123         * features/arm/arm-with-m-fpa-layout.c: Remove.
2124         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2125         * features/arm/arm-with-m-vfp-d16.c: Remove.
2126         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2127         * features/arm/arm-with-m.c: Remove.
2128         * features/arm/arm-with-m.xml: Remove.
2129         * features/arm/arm-with-neon.c: Remove.
2130         * features/arm/arm-with-neon.xml: Remove.
2131         * features/arm/arm-with-vfpv2.c: Remove.
2132         * features/arm/arm-with-vfpv2.xml: Remove.
2133         * features/arm/arm-with-vfpv3.c: Remove.
2134         * features/arm/arm-with-vfpv3.xml: Remove.
2135
2136 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2137
2138         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2139
2140 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2141
2142         * arch/aarch32.c (aarch32_create_target_description): Create
2143         target descriptions using features.
2144         * arch/arm.c (arm_create_target_description)
2145         (arm_create_mprofile_target_description): Likewise.
2146         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2147
2148 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2149
2150         * Makefile.in: Add new files.
2151         * aarch32-tdep.c: New file.
2152         * aarch32-tdep.h: New file.
2153         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2154         Call aarch32_read_description.
2155         * arch/aarch32.c: New file.
2156         * arch/aarch32.h: New file.
2157         * arch/arm.c (arm_create_target_description)
2158         (arm_create_mprofile_target_description): New function.
2159         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2160         (arm_create_target_description)
2161         (arm_create_mprofile_target_description): New declaration.
2162         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2163         read_description functions.
2164         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2165         Likewise.
2166         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2167         * arm-tdep.c (tdesc_arm_list): New variable.
2168         (arm_register_g_packet_guesses): Call create description functions.
2169         (arm_read_description) (arm_read_mprofile_description): New
2170         function.
2171         * arm-tdep.h (arm_read_description)
2172         (arm_read_mprofile_description): Add declaration.
2173         * configure.tgt: Add new files.
2174
2175 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2176
2177         * top.c (new_ui_command): Open specified terminal just once.
2178
2179 2019-07-18  Tom Tromey  <tromey@adacore.com>
2180
2181         * symtab.c (main_name): Constify return type.
2182         * symfile.c (set_initial_language): Update.
2183         * symtab.h (main_name): Constify return type.
2184
2185 2019-07-17  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-winsource.c (tui_update_source_window)
2188         (tui_update_source_window_as_is)
2189         (tui_update_source_windows_with_line): Remove return.
2190         * tui/tui-disasm.c (tui_show_disassem)
2191         (tui_show_disassem_and_update_source): Remove return.
2192         * tui/tui.c (tui_reset): Remove return.
2193         * tui/tui-wingeneral.c
2194         (tui_check_and_display_highlight_if_needed): Remove return.
2195
2196 2019-07-17  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2199
2200 2019-07-17  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-winsource.h (struct tui_exec_info_window)
2203         (struct tui_source_window_base): Move from tui-data.h.
2204         * tui/tui-winsource.c: Move many method definitions from
2205         elsewhere.  Remove "structuring" comments.
2206         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2207         (tui_source_window_base::refresh_window): Move to
2208         tui-winsource.c.
2209         * tui/tui-win.c (tui_source_window_base::refresh_all)
2210         (tui_source_window_base::update_tab_width)
2211         (tui_source_window_base::set_new_height)
2212         (tui_source_window_base::do_make_visible_with_new_height): Move to
2213         tui-winsource.c.
2214         * tui/tui-source.h: Update.
2215         * tui/tui-source.c (tui_source_window_base::reset): Move to
2216         tui-winsource.c.
2217         * tui/tui-disasm.h: Update.
2218         * tui/tui-data.h (struct tui_exec_info_window): Move to
2219         tui-winsource.h.
2220         (struct tui_source_window_base): Likewise.
2221         * tui/tui-data.c (tui_source_window_base::clear_detail)
2222         (tui_source_window_base, ~tui_source_window_base): Move to
2223         tui-winsource.c.
2224
2225 2019-07-17  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-win.c (tui_resize_all)
2228         (tui_source_window_base::update_tab_width)
2229         (tui_adjust_win_heights): Update.
2230         (tui_win_info::make_invisible_and_set_new_height): Rename from
2231         make_invisible_and_set_new_height.
2232         * tui/tui-data.h (struct tui_win_info)
2233         <make_invisible_and_set_new_height>: New method.
2234
2235 2019-07-17  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui.c: Update.
2238         * tui/tui-source.h (struct tui_source_window): Move from
2239         tui-data.h.
2240         * tui/tui-layout.c: Update.
2241         * tui/tui-disasm.c: Update.
2242         * tui/tui-data.h (struct tui_source_window): Move to
2243         tui-source.h.
2244
2245 2019-07-17  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2248         tui-data.h.
2249         * tui/tui-data.h (struct tui_disasm_window): Move to
2250         tui-disasm.h.
2251
2252 2019-07-17  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-regs.h (struct tui_data_item_window): Move from
2255         tui-data.h.
2256         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2257         * tui/tui-data.h (struct tui_data_item_window): Move to
2258         tui-regs.h.
2259         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2260
2261 2019-07-17  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui.c: Update.
2264         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2265         (tui_cmd_window::max_height): Move to tui-command.c.
2266         * tui/tui-layout.c: Update.
2267         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2268         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2269         tui-command.c.
2270         * tui/tui-command.h (struct tui_cmd_window): Move from
2271         tui-data.h.
2272         * tui/tui-command.c: Remove "structuring" comments.
2273         (tui_cmd_window::clear_detail)
2274         (tui_cmd_window::do_make_visible_with_new_height)
2275         (tui_cmd_window::max_height): Move from elsewhere.
2276
2277 2019-07-17  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2280         Now static.
2281         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2282         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2283
2284 2019-07-17  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui.c: Update.
2287         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2288         tui-regs.c.
2289         * tui/tui-windata.h: Remove file.
2290         * tui/tui-windata.c: Remove file.
2291         * tui/tui-win.c (tui_data_window::set_new_height)
2292         (tui_data_window::do_make_visible_with_new_height): Move to
2293         tui-regs.c.
2294         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2295         * tui/tui-regs.c: Remove "structuring" comments.
2296         (tui_data_window::first_data_item_displayed)
2297         (tui_data_window::delete_data_content_windows)
2298         (tui_data_window::erase_data_content)
2299         (tui_data_window::display_all_data)
2300         (tui_data_window::refresh_all)
2301         (tui_data_window::do_scroll_vertical)
2302         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2303         (tui_data_window::do_make_visible_with_new_height)
2304         (tui_data_window::refresh_window): Move from elsewhere.
2305         (_initialize_tui_regs): Move to end of file.
2306         * tui/tui-layout.c: Update.
2307         * tui/tui-hooks.c: Update.
2308         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2309         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2310         tui-regs.c.
2311         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2312
2313 2019-07-17  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2316         seen.
2317
2318 2019-07-17  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-win.c (tui_source_window_base::set_new_height)
2321         (tui_source_window_base::do_make_visible_with_new_height): Use
2322         m_has_locator field directly.
2323         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2324         method.
2325         (struct tui_source_window_base) <has_locator>: Likewise.
2326
2327 2019-07-17  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2330         Don't declare.
2331         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2332         Remove.
2333         * tui/tui-win.c (tui_source_window_base::set_new_height)
2334         (tui_source_window_base::set_new_height)
2335         (make_invisible_and_set_new_height)
2336         (tui_source_window_base::do_make_visible_with_new_height)
2337         (tui_source_window_base::do_make_visible_with_new_height):
2338         Update.
2339         * tui/tui-layout.c (show_source_disasm_command, show_data)
2340         (show_source_or_disasm_and_command): Update.
2341         * tui/tui-layout.c (show_layout): Update.
2342
2343 2019-07-17  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-layout.c (make_data_window): Remove.
2346         (show_data): Unify creation and re-initialization cases.
2347
2348 2019-07-17  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-layout.c (make_source_window, make_disasm_window):
2351         Remove.
2352         (show_data): Unify creation and re-initialization cases.
2353
2354 2019-07-17  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-layout.c (make_command_window): Remove.
2357         (show_source_disasm_command, show_source_or_disasm_and_command):
2358         Unify creation and re-initialization cases.
2359
2360 2019-07-17  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2363         creation and re-initialization cases.
2364
2365 2019-07-17  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-regs.c (tui_get_register): Return void.
2368
2369 2019-07-17  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2372         Simplify.
2373
2374 2019-07-17  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2377         resetting.
2378
2379 2019-07-17  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2382         * tui/tui-regs.c (tui_reg_layout): New function.
2383         (tui_show_registers, tui_reg_command): Use it.
2384         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2385         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2386         parameters.
2387         (tui_layout_command): Remove.
2388
2389 2019-07-17  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-layout.h (tui/tui-layout): Return void.
2392         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2393
2394 2019-07-17  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-layout.c (show_source_disasm_command, show_data):
2397         Update.
2398         (reset_locator): Remove.
2399         (show_source_or_disasm_and_command): Update.
2400
2401 2019-07-17  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-source.c (tui_source_window_base::reset): Remove
2404         win_type parameter.
2405         * tui/tui-layout.c (make_command_window, make_source_window)
2406         (make_disasm_window, make_data_window)
2407         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2408         (reset_locator, show_source_or_disasm_and_command): Update.
2409         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2410         win_type parameter.
2411         (struct tui_source_window_base) <reset>: Likewise.
2412
2413 2019-07-17  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-layout.c (show_source_disasm_command): Use
2416         reset_locator.
2417         (reset_locator): New function.
2418         (init_and_make_win): Remove.
2419         (show_source_or_disasm_and_command): Use reset_locator.
2420
2421 2019-07-17  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2424         condition.
2425         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2426         Remove condition.
2427         * tui/tui-source.c (tui_source_window_base::reset): New method.
2428         * tui/tui-layout.c (make_command_window): Don't call
2429         init_and_make_win.
2430         (make_source_window, make_disasm_window): Don't call
2431         make_source_or_disasm_window.
2432         (make_data_window): Don't call init_and_make_win.  Change calling
2433         convention.
2434         (show_source_disasm_command, show_data): Simplify.
2435         (make_source_or_disasm_window): Remove.
2436         (show_source_or_disasm_and_command): Simplify.
2437         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2438         (struct tui_source_window_base) <reset>: Likewise.
2439         <execution_info>: Remove initializer.
2440         * tui/tui-data.c (tui_source_window_base): Initialize
2441         execution_info.
2442
2443 2019-07-17  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2446         variable.
2447
2448 2019-07-17  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui.c (tui_rl_other_window): Update.
2451         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2452         superclass method first.  Always iterate over regs_content.
2453         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2454         method.
2455         * tui/tui-win.c (tui_set_focus_command): Update.
2456
2457 2019-07-17  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-win.c (tui_set_focus_command): Rename from
2460         tui_set_focus.  Call tui_enable.
2461         (tui_set_focus_command): Remove.
2462
2463 2019-07-17  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2466         refresh_window.
2467         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2468         touchwin.
2469         (tui_data_window::refresh_window): Call refresh_window on data
2470         items.  Always call superclass refresh_window.
2471         (tui_win_info::refresh): Remove.
2472         (tui_source_window_base::refresh_window): Update.
2473         (tui_refresh_all): Update.
2474         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2475         refresh_window.
2476         (show_source_or_disasm_and_command): Likewise.
2477         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2478         (struct tui_source_window_base) <refresh>: Likewise.
2479
2480 2019-07-17  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-winsource.c (tui_clear_source_content)
2483         (tui_show_source_content): Update.
2484         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2485         whether content is empty.
2486         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2487         Remove.
2488
2489 2019-07-17  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2492         window's contents.
2493         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2494         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2495
2496 2019-07-17  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2499         (struct tui_data_item_window): Update.
2500
2501 2019-07-17  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2504         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2505         defines.
2506
2507 2019-07-17  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-winsource.h (tui_erase_source_content)
2510         (tui_clear_source_content): Remove "display_prompt" parameter.
2511         * tui/tui-winsource.c (tui_update_source_window_as_is)
2512         (tui_update_source_windows_with_addr): Update.
2513         (tui_clear_source_content): Remove "display_prompt" parameter.
2514         (tui_erase_source_content): Likewise.  Simplify.
2515         (tui_show_source_content): Update.
2516         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2517         * tui/tui-stack.c (tui_show_frame_info): Update.
2518         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2519         Remove defines.
2520
2521 2019-07-17  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2524         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2525         parameter.
2526         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2527         parameter.
2528
2529 2019-07-17  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-winsource.c (tui_clear_source_content)
2532         (tui_show_source_content, tui_show_exec_info_content)
2533         (tui_clear_exec_info_content): Update.
2534         * tui/tui-stack.c (tui_show_locator_content): Update.
2535         (tui_show_frame_info): Update.
2536         * tui/tui-source.h (tui_source_window): Don't declare.
2537         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2538         from tui_source_is_displayed.
2539         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2540         Remove field.
2541         (struct tui_source_window_base) <content_in_use>: New field.  Now
2542         bool.
2543         (struct tui_source_window) <showing_source_p>: New method.
2544         (TUI_SRC_WIN): Change cast.
2545         * tui/tui-data.c (tui_initialize_static_data): Update.
2546
2547 2019-07-17  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2550         location_matches_p.
2551         * tui/tui-source.c (tui_source_window::location_matches_p): New
2552         method.
2553         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2554         method.
2555         * tui/tui-data.h (struct tui_source_window_base)
2556         <location_matches_p>: New method.
2557         (struct tui_source_window, struct tui_disasm_window)
2558         <location_matches_p>: Likewise.
2559
2560 2019-07-17  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-win.c (tui_set_win_height_command): Rename from
2563         tui_set_win_height.
2564         (tui_set_win_height_command): Remove.
2565
2566 2019-07-17  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-source.c (tui_source_window): New constructor.  Add
2569         observer.
2570         (~tui_source_window): New destructor.
2571         (tui_source_window::style_changed): New method.
2572         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2573         (tui_attach_detach_observers): Update.
2574         * tui/tui-data.h (struct tui_source_window): Make constructor not
2575         inline.  Add destructor.
2576         (struct tui_source_window) <style_changed>: New method.
2577         <m_observable>: New member.
2578
2579 2019-07-17  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2582         * tui/tui-win.c (tui_resize_all): Fix typo.
2583
2584 2019-07-17  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2587         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2588         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2589         * tui/tui-win.c (window_name_completer): Use foreach.
2590         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2591         (update_tab_width): Likewise.
2592         * tui/tui-layout.c (show_layout): Update.
2593         * tui/tui-data.h (class tui_window_iterator): New.
2594         (struct all_tui_windows): New.
2595         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2596
2597 2019-07-17  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2600         parameter.  Don't reference globals.
2601         (tui_reg_command): Update.
2602
2603 2019-07-17  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-regs.c (tui_show_registers): Simplify.
2606
2607 2019-07-17  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-regs.c (tui_show_registers): Update.
2610         (tui_show_register_group): Add win_info parameter.
2611
2612 2019-07-17  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2615         Rename from tui_display_reg_element_at_line.
2616         (tui_data_window::display_registers_from_line): Update.
2617         * tui/tui-data.h (struct tui_data_window)
2618         <display_reg_element_at_line>: New method.
2619
2620 2019-07-17  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-regs.h (tui_display_registers_from)
2623         (tui_display_registers_from_line): Don't declare.
2624         * tui/tui-windata.c (tui_data_window::display_all_data)
2625         (tui_data_window::refresh_all)
2626         (tui_data_window::do_scroll_vertical): Update.
2627         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2628         from tui_display_registers_from.
2629         (tui_display_reg_element_at_line): Update.
2630         (tui_data_window::display_registers_from_line): Rename from
2631         tui_display_registers_from_line.
2632         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2633         display_registers_from_line>: New methods.
2634
2635 2019-07-17  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2638         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2639         from tui_erase_data_content.
2640         (tui_data_window::display_all_data)
2641         (tui_data_window::refresh_all)
2642         (tui_data_window::do_scroll_vertical): Update.
2643         * tui/tui-regs.c (tui_show_registers): Update.
2644         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2645         New method.
2646
2647 2019-07-17  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2650         declare.
2651         * tui/tui-windata.c
2652         (tui_data_window::delete_data_content_windows): Rename from
2653         tui_delete_data_content_windows.
2654         (tui_data_window::display_all_data)
2655         (tui_data_window::do_scroll_vertical): Update.
2656         * tui/tui-data.h (struct tui_data_window)
2657         <delete_data_content_windows>: New method.
2658
2659 2019-07-17  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2662         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2663
2664 2019-07-17  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2667         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2668         from tui_display_all_data.
2669         * tui/tui-win.c
2670         (tui_data_window::do_make_visible_with_new_height): Update.
2671         * tui/tui-regs.c (tui_show_registers): Update.
2672         * tui/tui-layout.c (tui_set_layout): Update.
2673         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2674         method.
2675
2676 2019-07-17  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2679         * tui/tui-windata.c (tui_display_data_from): Remove.
2680         (tui_data_window::refresh_all): Update.
2681
2682 2019-07-17  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2685         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2686         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2687         tui_display_registers_from_line.
2688         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2689         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2690         "force_display" parameter.
2691
2692 2019-07-17  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2695         declare.
2696         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2697         Rename from tui_first_reg_element_no_inline.
2698         (tui_display_reg_element_at_line)
2699         (tui_display_registers_from_line): Update.
2700         * tui/tui-data.h (struct tui_data_window)
2701         <first_reg_element_no_inline>: New method.
2702
2703 2019-07-17  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-windata.c (tui_display_data_from)
2706         (tui_data_window::do_scroll_vertical): Update.
2707         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2708         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2709         Rename from tui_line_from_reg_element_no.
2710         (tui_display_registers_from_line): Update.
2711         * tui/tui-data.h (struct tui_data_window)
2712         <line_from_reg_element_no>: New method.
2713
2714 2019-07-17  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2717         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2718         tui_last_regs_line_no.
2719         (tui_display_reg_element_at_line)
2720         (tui_display_registers_from_line): Update.
2721         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2722         method.
2723
2724 2019-07-17  Tom Tromey  <tom@tromey.com>
2725
2726         PR tui/24722:
2727         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2728         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2729         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2730         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2731         (tui_update_breakpoint_info): Likewise.
2732         * tui/tui-hooks.c (tui_event_create_breakpoint)
2733         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2734         Update.
2735
2736 2019-07-17  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2739
2740 2019-07-17  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-winsource.c (tui_update_source_window_as_is)
2743         (tui_update_source_windows_with_addr): Update.
2744         * tui/tui-source.h (tui_set_source_content)
2745         (tui_show_symtab_source): Add "win_info" parameter.
2746         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2747         parameter.
2748         (tui_show_symtab_source): Likewise.
2749
2750 2019-07-17  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-wingeneral.c
2753         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2754
2755 2019-07-17  Tom Tromey  <tom@tromey.com>
2756
2757         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2758         (struct tui_cmd_window) <can_scroll>: New method.
2759         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2760         method.
2761
2762 2019-07-17  Tom Tromey  <tromey@adacore.com>
2763
2764         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2765         do_field_signed>: Rename.  Change type of "value".
2766         * ui-out.c (ui_out::field_signed): Rename from field_int.
2767         Change type of "value".
2768         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2769         type of "value".
2770         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2771         do_field_int.  Change type of "value".
2772         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2773         do_field_int.  Change type of "value".
2774         * tracepoint.c (trace_status_mi, tfind_1)
2775         (print_one_static_tracepoint_marker): Update.
2776         * thread.c (print_thread_info_1, print_selected_thread_frame):
2777         Update.
2778         * stack.c (print_frame, print_frame_info): Update.
2779         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2780         Update.
2781         * source.c (print_source_lines_base): Update.
2782         * skip.c (info_skip_command): Update.
2783         * record-btrace.c (btrace_ui_out_decode_error)
2784         (btrace_call_history_src_line): Update.
2785         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2786         Update.
2787         * progspace.c (print_program_space): Update.
2788         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2789         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2790         do_field_int.  Change type of "value".
2791         * mi/mi-out.c (mi_ui_out::do_table_begin)
2792         (mi_ui_out::do_table_header): Update.
2793         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2794         type of "value".
2795         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2796         (mi_cmd_data_list_changed_registers, output_register)
2797         (mi_cmd_data_read_memory, mi_load_progress)
2798         (mi_cmd_trace_frame_collected): Update.
2799         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2800         Update.
2801         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2802         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2803         (mi_cmd_var_list_children, varobj_update_one): Update.
2804         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2805         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2807         * inferior.c (print_inferior): Update.
2808         * gdb_bfd.c (print_one_bfd): Update.
2809         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2810         Update.
2811         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2812         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2813         do_field_int.  Change type of "value".
2814         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2815         do_field_int.  Change type of "value".
2816         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2817         (print_one_breakpoint_location, print_it_catch_fork)
2818         (print_one_catch_fork, print_it_catch_vfork)
2819         (print_one_catch_vfork, print_it_catch_solib)
2820         (print_it_catch_exec, print_it_ranged_breakpoint)
2821         (print_mention_watchpoint, print_mention_masked_watchpoint)
2822         (bkpt_print_it, update_static_tracepoint): Update.
2823         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2824         * break-catch-syscall.c (print_it_catch_syscall): Update.
2825         * ada-tasks.c (print_ada_task_info): Update.
2826         * ada-lang.c (print_it_exception, print_mention_exception):
2827         Update.
2828
2829 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         PR breakpoints/24541
2832         * gdbarch.c: Regenerate.
2833         * gdbarch.h: Regenerate.
2834         * gdbarch.sh: Adjust return type and parameter types for
2835         'stap_adjust_register'.
2836         (i386_stap_adjust_register): Adjust signature and return new
2837         register name.
2838         * stap-probe.c (stap_parse_register_operand): Adjust use of
2839         'gdbarch_stap_adjust_register'.
2840
2841 2019-07-17  Tom Tromey  <tromey@adacore.com>
2842
2843         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2844         declare VEC.
2845         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2846         std::vector.
2847         (struct s390_process_info): Add initializers.
2848         (s390_add_process): Use new.
2849         (s390_linux_nat_target::low_forget_process): Use delete.
2850         (s390_linux_nat_target::low_new_fork)
2851         (s390_linux_nat_target::stopped_by_watchpoint)
2852         (s390_linux_nat_target::low_prepare_to_resume)
2853         (s390_linux_nat_target::insert_watchpoint)
2854         (s390_linux_nat_target::insert_hw_breakpoint)
2855         (s390_linux_nat_target::remove_watchpoint)
2856         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2857
2858 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2859
2860         * aarch64-fbsd-nat.c: Include regcache.h.
2861         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2862         argument.
2863         (aarch64_fbsd_nat_target::fetch_registers)
2864         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2865         variable.
2866         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2867
2868 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2869
2870         * fbsd-nat.c: Include gdbarch.h.
2871
2872 2019-07-15  Tom Tromey  <tromey@adacore.com>
2873
2874         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2875
2876 2019-07-15  Tom Tromey  <tromey@adacore.com>
2877
2878         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2879         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2880         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2881         * cli-out.c (cli_ui_out::do_field_int): New method.
2882         * ui-out.c (ui_out::field_unsigned): New method.
2883         * symfile.c (generic_load): Use field_unsigned.
2884         (print_transfer_performance): Likewise.
2885         * record-btrace.c (ui_out_field_uint): Remove.
2886         (btrace_call_history_insn_range, btrace_call_history): Use
2887         field_unsigned.
2888         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2889         field_unsigned.
2890         * ui-out.h (class ui_out) <field_unsigned>: New method.
2891         <do_field_unsigned>: Likewise.
2892
2893 2019-07-15  Tom Tromey  <tromey@adacore.com>
2894
2895         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2896         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2897         * target.c (flash_erase_command): Use field_string.
2898         * infrun.c (print_signal_received_reason): Use field_string.
2899         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2900         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2901         field_string.
2902         * ada-tasks.c (print_ada_task_info): Use field_string.
2903
2904 2019-07-15  Tom Tromey  <tromey@adacore.com>
2905
2906         * target.c (flash_erase_command): Use field_core_addr.
2907         * symfile.c (generic_load): Use field_core_addr.
2908         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2909         Use field_core_addr.
2910         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2911         field_core_addr.
2912
2913 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2916         value if its desired type is smaller than a CORE_ADDR and signed.
2917
2918 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2921         of changes to field names, and use new is_reference field to
2922         decide if a property is a reference or not.
2923         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2924         field.
2925         (struct dwarf2_property_baton): Update header comment, rename
2926         'referenced_type' to 'property_type' and update comments.
2927         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2928         default property type, store in property baton, update to take
2929         accound of renamed field.
2930         (read_func_scope): Update call to attr_to_dynamic_prop.
2931         (read_array_type): Likewise.
2932         (dwarf2_per_cu_addr_sized_int_type): New function.
2933         (read_subrange_index_type): Move type finding code to
2934         dwarf2_per_cu_addr_sized_int_type.
2935         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2936         (dwarf2_per_cu_addr_type): New function.
2937         (set_die_type): Update calls to attr_to_dynamic_prop.
2938
2939 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * dwarf2read.c (read_subrange_index_type): New function.
2942         (read_subrange_type): Move code into new function and call it.
2943         * gdbtypes.c (create_range_type): Add some asserts.
2944
2945 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2948         update return statements.
2949         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2950         declaration, and update comment to match.
2951         * gdbtypes.c (resolve_dynamic_array): Update call to
2952         dwarf2_evaluate_property to match new return type.
2953
2954 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * valarith.c (value_subscripted_rvalue): Change lowerbound
2957         parameter type from int to LONGEST.
2958         * value.h (value_subscripted_rvalue): Likewise in declaration.
2959
2960 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * cli/cli-utils.c (info_print_command_completer): New function.
2963         * cli/cli-utils.h: Add 'completer.h' include, and forward
2964         declaration for 'struct cmd_list_element'.
2965         (info_print_command_completer): Declare.
2966         * stack.c (_initialize_stack): Add completer for 'info locals' and
2967         'info args'.
2968         * symtab.c (_initialize_symtab): Add completer for 'info
2969         variables' and 'info functions'.
2970         * NEWS: Mention completion for additional info commands.
2971
2972 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2973
2974         * cli/cli-utils.c (extract_info_print_args): Delete.
2975         (extract_arg_maybe_quoted): Delete.
2976         (info_print_options_defs): New variable.
2977         (make_info_print_options_def_group): New function.
2978         (extract_info_print_options): Define new function.
2979         * cli/cli-utils.h (extract_info_print_args): Delete.
2980         (struct info_print_options): New structure.
2981         (extract_info_print_options): Declare new function.
2982         * stack.c (info_locals_command): Update to use new
2983         extract_info_print_options, also add a header comment.
2984         (info_args_command): Likewise.
2985         * symtab.c (info_variables_command): Likewise.
2986         (info_functions_command): Likewise.
2987
2988 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2989
2990         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2991         to extract string arguments.
2992         * common/common-utils.c (extract_string_maybe_quoted): New function.
2993         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2994
2995 2019-07-11  Tom Tromey  <tromey@adacore.com>
2996
2997         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2998         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2999         * top.h (gdbinit): Don't declare.
3000         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3001         into...
3002         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3003         * top.c (gdb_init): Don't call init_cli_cmds.
3004         (gdbinit): Remove.
3005         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3006
3007 2019-07-11  Tom Tromey  <tromey@adacore.com>
3008
3009         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3010         after it has been moved.
3011
3012 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3013
3014         * valops.c (value_must_coerce_to_target): Change return type to
3015         bool.
3016         * value.h (value_must_coerce_to_target): Likewise.
3017
3018 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3019
3020         * breakpoint.c (is_hardware_watchpoint): Remove
3021         forward-declaration.
3022         (is_masked_watchpoint): Change return type to bool.
3023         (is_tracepoint): Likewise.
3024         (is_breakpoint): Likewise.
3025         (is_hardware_watchpoint): Likewise.
3026         (is_watchpoint): Likewise.
3027         (is_no_memory_software_watchpoint): Likewise.
3028         (is_catchpoint): Likewise.
3029         (breakpoint_1): Make FILTER parameter's return type bool.
3030         is_masked_watchpoint): Change return type to bool.
3031         (save_breakpoints): Make FILTER parameter's return type bool.
3032         * breakpoint.h (is_breakpoint): Change return type to bool.
3033         (is_watchpoint): Likewise.
3034         (is_catchpoint): Likewise.
3035         (is_tracepoint): Likewise.
3036
3037 2019-07-10  Tom Tromey  <tom@tromey.com>
3038
3039         * defs.h: Don't include gdbarch.h.
3040         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3041         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3042         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3043         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3044         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3045         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3046         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3047         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3048         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3049         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3050         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3051         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3052         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3053         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3054         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3055         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3056         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3057         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3058         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3059         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3060         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3061         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3062         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3063         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3064         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3065         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3066         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3067
3068 2019-07-10  Tom Tromey  <tromey@adacore.com>
3069
3070         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3071         * breakpoint.c (init_ada_exception_breakpoint): Register as
3072         bp_catchpoint.
3073         (print_one_breakpoint_location, print_one_breakpoint): Use
3074         is_ada_exception_catchpoint.
3075         * ada-lang.c (class ada_catchpoint_location): Pass
3076         bp_loc_software_breakpoint to bp_location constructor.
3077         (is_ada_exception_catchpoint): New function.
3078
3079 2019-07-10  Tom Tromey  <tromey@adacore.com>
3080
3081         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3082         VEC.
3083         (struct arm_exidx_entry): New method operator<.
3084         (struct arm_exidx_data) <section_maps>: Change type.
3085         (arm_exidx_data_free): Remove.
3086         (arm_exidx_data_key): Change type.  Move lower.
3087         (arm_exidx_new_objfile): Update.
3088         (arm_compare_exidx_entries): Remove.
3089         (arm_find_exidx_entry, _initialize_arm_tdep)
3090
3091 2019-07-10  Tom Tromey  <tromey@adacore.com>
3092
3093         * solib-spu.c (ocl_program_data_key): Change type.
3094         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3095         Update.
3096
3097 2019-07-10  Tom Tromey  <tromey@adacore.com>
3098
3099         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3100         (struct solib_aix_inferior_data) <library_list>: Change type.
3101         (solib_aix_inferior_data_handle): Change type.
3102         (get_solib_aix_inferior_data): Update.
3103         (solib_aix_free_library_list): Remove.
3104         (library_list_start_library): Update.
3105         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3106         return type.
3107         (solib_aix_get_library_list)
3108         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3109         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3110
3111 2019-07-10  Tom Tromey  <tromey@adacore.com>
3112
3113         * solib-dsbt.c (struct dsbt_info): Add initializers.
3114         (solib_dsbt_pspace_data): Change type.
3115         (dsbt_pspace_data_cleanup): Remove.
3116         (get_dsbt_info, _initialize_dsbt_solib): Update.
3117
3118 2019-07-10  Tom Tromey  <tromey@adacore.com>
3119
3120         * spu-tdep.c (spu_overlay_data): Change type.
3121         (spu_get_overlay_table, spu_overlay_new_objfile)
3122         (_initialize_spu_tdep): Update.
3123
3124 2019-07-10  Tom Tromey  <tromey@adacore.com>
3125
3126         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3127         destructor.
3128         (dbx_objfile_data_key): Change type and declare later.
3129         (DBX_SYMFILE_INFO): Rewrite.
3130         * dbxread.c (dbx_objfile_data_key): Change type.
3131         (dbx_symfile_init): Update.
3132         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3133         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3134         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3135
3136 2019-07-10  Tom Tromey  <tromey@adacore.com>
3137
3138         * jit.c (jit_program_space_key): Change type.  Move lower.
3139         (get_jit_program_space_data): Update.
3140         (jit_program_space_data_cleanup): Remove.
3141         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3142         Update.
3143         (struct jit_program_space_data): Add initializers.
3144
3145 2019-07-10  Tom Tromey  <tromey@adacore.com>
3146
3147         * solib-darwin.c (struct darwin_info): Add initializers.
3148         (solib_darwin_pspace_data): Change type.
3149         (darwin_pspace_data_cleanup): Remove.
3150         (get_darwin_info, _initialize_darwin_solib): Update.
3151
3152 2019-07-10  Tom Tromey  <tromey@adacore.com>
3153
3154         * remote-sim.c (struct sim_inferior_data): Add initializers,
3155         constructor, and destructor.
3156         (sim_inferior_data_key): Change type.  Move lower.
3157         (check_for_duplicate_sim_descriptor): Update.
3158         (get_sim_inferior_data): Use new.  Update.
3159         (~sim_inferior_data_cleanup): Rename from
3160         sim_inferior_data_cleanup.  Simplify.
3161         (gdbsim_close_inferior, simulator_command)
3162         (sim_command_completer, _initialize_remote_sim): Update.
3163         (next_pid, INITIAL_PID): Move earlier.
3164
3165 2019-07-10  Tom Tromey  <tromey@adacore.com>
3166
3167         * python/python-internal.h (create_thread_object): Return
3168         gdbpy_ref.
3169         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3170         * python/py-inferior.c (struct threadlist_entry): Add
3171         constructor.
3172         <thread_obj>: Now a gdbpy_ref.
3173         (thread_to_thread_object): Update.
3174         (add_thread_object): Use new.
3175         (delete_thread_object): Use delete.
3176         (infpy_threads): Update.
3177         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3178         GIL.
3179
3180 2019-07-10  Tom Tromey  <tromey@adacore.com>
3181
3182         * valops.c (value_cast): Specialize error message for Ada.
3183
3184 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3185
3186         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3187
3188 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3189
3190         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3191         bpstat_should_step): Return bool, adjust comments.
3192         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3193         bpstat_should_step): Likewise.
3194
3195 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3196
3197         * features/Makefile: Use feature target descriptions for Arm.
3198         * features/arm/arm-core.c: Generate new file.
3199         * features/arm/arm-fpa.c: Likewise.
3200         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3201         * features/arm/arm-m-profile.c: Likewise.
3202         * features/arm/arm-vfpv2.c: Likewise.
3203         * features/arm/arm-vfpv3.c: Likewise.
3204         * features/arm/xscale-iwmmxt.c: Likewise.
3205         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3206
3207 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3208
3209         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3210         ptrace earlier.
3211
3212 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3213
3214         * features/aarch64-pauth.c: Regenerate.
3215
3216 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3217
3218         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3219         bool.
3220         (bpstat_what): Use false instead of 0.
3221
3222 2019-07-09  Pedro Alves  <palves@redhat.com>
3223
3224         * break-catch-throw.c (is_exception_catchpoint): New.
3225         * breakpoint.c (print_one_breakpoint_location): New parameter
3226         'raw_loc'.  Handle it.  Use
3227         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3228         looking at the breakpoint's type.
3229         (print_one_breakpoint): If handling "maint info breakpoints", also
3230         print locations of exception catchpoints.
3231         * breakpoint.h (is_exception_catchpoint): Declare.
3232
3233 2019-07-09  Pedro Alves  <palves@redhat.com>
3234
3235         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3236         "addr" field.
3237         (allocate_location_exception_catchpoint): New.
3238         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3239         (initialize_throw_catchpoint_ops): Install
3240         allocate_location_exception_catchpoint as allocate_location
3241         method.
3242         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3243         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3244         bp_loc_other.
3245         (breakpoint_address_is_meaningful): Delete.
3246         (bl_address_is_meaningful): New.
3247         (breakpoint_locations_match): Adjust comment.
3248         (bp_location_from_bp_type): New, factored out of...
3249         (bp_location::bp_location(breakpoint *)): ... this.
3250         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3251         factored out of...
3252         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3253         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3254         breakpoint_address_is_meaningful.
3255         (bp_locations_compare): Adjust comment.
3256         (update_global_location_list): Use bl_address_is_meaningful
3257         instead of breakpoint_address_is_meaningful.
3258         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3259         explicit.
3260         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3261         * python/py-breakpoint.c (bppy_get_location): No longer check
3262         whether location is null.
3263
3264 2019-07-09  Pedro Alves  <palves@redhat.com>
3265
3266         PR c++/15468
3267         * breakpoint.c (print_one_breakpoint_location): Remove
3268         single-location assert.
3269
3270 2019-07-09  Tom Tromey  <tom@tromey.com>
3271
3272         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3273         * configure: Rebuild.
3274         * configure.ac: Change common to gdbsupport.
3275         * gdbsupport: Rename from common.
3276         * acinclude.m4: Change common to gdbsupport.
3277         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3278         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3279         gdbsupport.
3280         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3281         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3282         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3283         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3284         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3285         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3286         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3287         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3288         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3289         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3290         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3291         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3292         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3293         coff-pe-read.c, command.h, compile/compile-c-support.c,
3294         compile/compile-c.h, compile/compile-cplus-symbols.c,
3295         compile/compile-cplus-types.c, compile/compile-cplus.h,
3296         compile/compile-loc2c.c, compile/compile.c, completer.c,
3297         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3298         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3299         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3300         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3301         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3302         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3303         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3304         features/aarch64-core.c, features/aarch64-fpu.c,
3305         features/aarch64-pauth.c, features/aarch64-sve.c,
3306         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3307         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3308         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3309         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3310         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3311         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3312         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3313         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3314         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3315         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3316         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3317         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3318         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3319         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3320         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3321         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3322         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3323         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3324         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3325         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3326         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3327         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3328         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3329         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3330         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3331         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3332         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3333         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3334         minsyms.c, mips-linux-tdep.c, namespace.h,
3335         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3336         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3337         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3338         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3339         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3340         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3341         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3342         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3343         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3344         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3345         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3346         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3347         procfs.c, producer.c, progspace.h, psymtab.h,
3348         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3349         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3350         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3351         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3352         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3353         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3354         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3355         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3356         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3357         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3358         target-memory.c, target.c, target.h, target/waitstatus.c,
3359         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3360         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3361         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3362         unittests/array-view-selftests.c,
3363         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3364         unittests/common-utils-selftests.c,
3365         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3366         unittests/format_pieces-selftests.c,
3367         unittests/function-view-selftests.c,
3368         unittests/lookup_name_info-selftests.c,
3369         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3370         unittests/mkdir-recursive-selftests.c,
3371         unittests/observable-selftests.c,
3372         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3373         unittests/parse-connection-spec-selftests.c,
3374         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3375         unittests/scoped_fd-selftests.c,
3376         unittests/scoped_mmap-selftests.c,
3377         unittests/scoped_restore-selftests.c,
3378         unittests/string_view-selftests.c, unittests/style-selftests.c,
3379         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3380         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3381         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3382         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3383         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3384         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3385
3386 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3387
3388         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3389         bool value.
3390         (decode_digits_ordinary): Set explicit_line field in sal.
3391         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3392         symtab_and_line that was set on an explicit line number in
3393         assembler code.  Do always update the recorded symtab and line if
3394         we do skip the prologue.
3395
3396 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * breakpoint.c (set_breakpoint_location_function): Remove
3399         explicit_loc parameter.
3400         (momentary_breakpoint_from_master): Update call to
3401         set_breakpoint_location_function.
3402         (add_location_to_breakpoint): Likewise.
3403
3404 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3405
3406         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3407         required features based on default bfd type when no specific bfd
3408         is present.
3409
3410 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3411
3412         * NEWS: Mention that GDB printf and eval commands can now print
3413         C-style and Ada-style convenience var strings without
3414         calling the inferior.
3415         * printcmd.c (printf_c_string): Locally print GDB internal var
3416         instead of transiting via the inferior.
3417         (printf_wide_c_string): Likewise.
3418
3419 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3420
3421         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3422
3423 2019-07-04  Tom Tromey  <tom@tromey.com>
3424
3425         PR tui/24724:
3426         * tui/tui-winsource.c (tui_clear_source_content): Update.
3427         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3428         (tui_update_breakpoint_info): Update.
3429         (tui_set_exec_info_content): Update.
3430         * tui/tui-source.c (tui_set_source_content_nil): Update.
3431         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3432         has_break.
3433         * tui/tui-data.h (enum tui_bp_flag): New.
3434         (tui_bp_flags): New enum flags type.
3435         (struct tui_source_element) <break_mode>: Change type.  Rename
3436         from has_break.
3437         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3438         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3439         constants.
3440         * tui/tui-winsource.h: Fix comment.
3441
3442 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3443
3444         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3445         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3446         (store_fpregs_to_thread)
3447         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3448         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3449         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3450         (IWMMXT_REGS_SIZE): Add define.
3451         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3452         (fetch_vfp_regs, store_vfp_regs)
3453         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3454         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3455
3456 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3457
3458         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3459         defines.
3460         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3461         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3462         (ARM_INT_REGISTER_SIZE): ...to this.
3463         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3464         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3465         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3466         (arm_linux_collect_gregset, supply_nwfpe_register)
3467         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3468         defines.
3469         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3470         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3471         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3472         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3473         (arm_return_in_memory, arm_store_return_value)
3474         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3475         (arm_record_ld_st_multiple): Likewise.
3476         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3477         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3478
3479 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3480
3481         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3482         AARCH64_DISPLACED_MODIFIED_INSNS.
3483         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3484         (aarch64_displaced_step_copy_insn): Likewise.
3485         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3486         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3487         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3488         ARM_DISPLACED_MODIFIED_INSNS.
3489         * arm-tdep.c (arm_gdbarch_init): Likewise.
3490         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3491         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3492         (struct arm_displaced_step_closure): Use
3493         ARM_DISPLACED_MODIFIED_INSNS.
3494
3495 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3496
3497         * features/Makefile: Remove unused xml files.
3498         * features/aarch64.xml: Remove.
3499         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3500         * features/i386/amd64-avx-avx512.xml: Remove.
3501         * features/i386/amd64-avx-linux.xml: Remove.
3502         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3503         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3504         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3505         * features/i386/amd64-avx-mpx.xml: Remove.
3506         * features/i386/amd64-avx.xml: Remove.
3507         * features/i386/amd64-linux.xml: Remove.
3508         * features/i386/amd64-mpx-linux.xml: Remove.
3509         * features/i386/amd64-mpx.xml: Remove.
3510         * features/i386/amd64.xml: Remove.
3511         * features/i386/i386-avx-avx512-linux.xml: Remove.
3512         * features/i386/i386-avx-avx512.xml: Remove.
3513         * features/i386/i386-avx-linux.xml: Remove.
3514         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3515         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3516         * features/i386/i386-avx-mpx-linux.xml: Remove.
3517         * features/i386/i386-avx-mpx.xml: Remove.
3518         * features/i386/i386-avx.xml: Remove.
3519         * features/i386/i386-linux.xml: Remove.
3520         * features/i386/i386-mmx-linux.xml: Remove.
3521         * features/i386/i386-mmx.xml: Remove.
3522         * features/i386/i386-mpx-linux.xml: Remove.
3523         * features/i386/i386-mpx.xml: Remove.
3524         * features/i386/i386.xml: Remove.
3525         * features/i386/x32-avx-avx512-linux.xml: Remove.
3526         * features/i386/x32-avx-linux.xml: Remove.
3527         * features/i386/x32-linux.xml: Remove.
3528
3529 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3530
3531         * regformats/aarch64.dat: Remove.
3532         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3533         * regformats/i386/amd64-avx-linux.dat: Remove.
3534         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3535         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3536         * regformats/i386/amd64-linux.dat: Remove.
3537         * regformats/i386/amd64-mpx-linux.dat: Remove.
3538         * regformats/i386/amd64.dat: Remove.
3539         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3540         * regformats/i386/i386-avx-linux.dat: Remove.
3541         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3542         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3543         * regformats/i386/i386-linux.dat: Remove.
3544         * regformats/i386/i386-mmx-linux.dat: Remove.
3545         * regformats/i386/i386-mpx-linux.dat: Remove.
3546         * regformats/i386/i386.dat: Remove.
3547         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3548         * regformats/i386/x32-avx-linux.dat: Remove.
3549         * regformats/i386/x32-linux.dat: Remove.
3550
3551 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3552
3553         * aarch64-tdep.c: Remove xml self tests.
3554         * amd64-linux-tdep.c: Likewise.
3555         * amd64-tdep.c: Likewise.
3556         * i386-linux-tdep.c: Likewise.
3557         * i386-tdep.c: Likewise.
3558
3559 2019-07-03  Pedro Alves  <palves@redhat.com>
3560
3561         PR cli/24732
3562         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3563         (pipe_cmd_option_defs): New.
3564         (make_pipe_cmd_options_def_group): New.
3565         (pipe_command): Use gdb::option::process_options.
3566         (pipe_command_completer): New function.
3567         (_initialize_cli_cmds): Install completer for "pipe" command.
3568
3569 2019-07-03  Pedro Alves  <palves@redhat.com>
3570
3571         * cli/cli-option.c (union option_value) <string>: New field.
3572         (struct option_def_and_value): Add ctor, move ctor, dtor and
3573         use DISABLE_COPY_AND_ASSIGN.
3574         (option_def_and_value::clear_value): New.
3575         (parse_option, save_option_value_in_ctx, get_val_type_str)
3576         (add_setshow_cmds_for_options): Handle var_string.
3577         * cli-option.h (union option_def::var_address) <string>: New
3578         field.
3579         (struct string_option_def): New.
3580         * maint-test-options.c (struct test_options_opts): Add default
3581         ctor and use DISABLE_COPY_AND_ASSIGN.
3582         <string_opt>: New field.
3583         (test_options_opts::~test_options_opts): New.
3584         (test_options_opts::dump): Also dump "-string".
3585         (test_options_option_defs): Install "string.
3586
3587 2019-07-03  Pedro Alves  <palves@redhat.com>
3588
3589         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3590         option_value with a null enumeration.
3591         (complete_options): Save the option values in the context.
3592         (save_option_value_in_ctx): New, factored out from ...
3593         (process_options): ... here.
3594         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3595         of the function.
3596         * maint-test-options.c (test_options_opts::dump): New, factored
3597         out from ...
3598         (maintenance_test_options_command_mode): ... here.
3599         (maintenance_test_options_command_completion_result): Delete.
3600         (maintenance_test_options_command_completion_text): Update
3601         comment.
3602         (maintenance_show_test_options_completion_result): Change
3603         prototype.  Just print
3604         maintenance_test_options_command_completion_text.
3605         (save_completion_result): New.
3606         (maintenance_test_options_completer_mode): Pass options context to
3607         complete_options, and then save a dump.
3608         (_initialize_maint_test_options): Use add_cmd to install "maint
3609         show test-options-completion-result".
3610
3611 2019-07-03  Pedro Alves  <palves@redhat.com>
3612
3613         * NEWS (New commands): Mention "with" and "maint with".
3614         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3615         (with_command, with_command_completer): New.
3616         (pipe_command): Adjust to new repeat_previous
3617         interface.
3618         (_initialize_cli_cmds): Install the "with" command and its "w"
3619         alias.
3620         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3621         declarations.
3622         * cli/cli-setshow.c (parse_cli_var_uinteger)
3623         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3624         argument strings for all var_types.
3625         (get_setshow_command_value_string): New, factored out from ...
3626         (do_show_command): ... this.
3627         * cli/cli-setshow.h: Include <string>.
3628         (get_setshow_command_value_string): Declare.
3629         * command.h (repeat_previous): Now returns const char *.  Adjust
3630         comment.
3631         * maint.c: Include "cli/cli-cmds.h".
3632         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3633         (_initialize_maint_cmds): Register the "maintenance with" command.
3634         * top.c (repeat_previous): Move bits from pipe_command here:
3635         Return the saved command line, if any; error out if there's no
3636         command to relaunch.
3637
3638 2019-07-03  Pedro Alves  <palves@redhat.com>
3639
3640         * NEWS (New commands): Mention "maint set/show test-settings"
3641         instead of "maint test-settings".
3642         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3643         (maintenance_test_settings_set_list): Rename to ...
3644         (maintenance_set_test_settings_list): ... this.
3645         (maintenance_test_settings_show_list): Rename to  ...
3646         (maintenance_show_test_settings_list): ... this.
3647         (maintenance_test_settings_cmd): Delete.
3648         (maintenance_test_settings_set_cmd): ...
3649         (maintenance_set_test_settings_cmd): ... this.
3650         (maintenance_test_settings_show_cmd): ...
3651         (maintenance_show_test_settings_cmd): ... this.
3652         (maintenance_test_settings_show_value_cmd):
3653         (maintenance_show_test_settings_value_cmd): ... this.
3654         (_initialize_maint_test_settings): No longer install the "maint
3655         test-settings" prefix command.  Rename "maint test-settings set"
3656         to "maint set test-settings", and "maint test-settings show" to
3657         "maint show test-settings".  Adjust all subcommands.
3658
3659 2019-07-03  Pedro Alves  <palves@redhat.com>
3660
3661         * maint-test-settings.c: Fix file's intro comment.  Replace all
3662         references to "test-options" with references to "test-settings",
3663         in comments.
3664
3665 2019-07-03  Pedro Alves  <palves@redhat.com>
3666
3667         * maint-test-settings.c (maintenance_test_settings_xxx)
3668         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3669         New.
3670         (maintenance_test_settings_enums): Use them.
3671         (maintenance_test_settings_enum): Default to
3672         maintenance_test_settings_xxx.
3673         (_initialize_maint_test_settings): Initialize
3674         MAINTENANCE_TEST_SETTINGS_FILENAME.
3675
3676 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3677
3678         * breakpoint.h (remove_breakpoints_inf): Change return type to
3679         void, move function documentation here.
3680         * breakpoint.c (remove_breakpoints_inf): Change return type to
3681         void, move function documentation to header.
3682
3683 2019-07-02  Pedro Alves  <palves@redhat.com>
3684
3685         * NEWS (Completion improvements): Mention "info threads".
3686         * thread.c (struct info_threads_opts, info_threads_option_defs)
3687         (make_info_threads_options_def_group): New.
3688         (info_threads_command): Use gdb::option::process_options.
3689         (info_threads_command_completer): New.
3690         (_initialize_thread): Use gdb::option::build_help to build the
3691         help text for "info threads".
3692
3693 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3694
3695         * defs.h (generic_load): Move from here...
3696         * symfile.h (generic_load): ... to here.  Rename name parameter
3697         to args.
3698         * symfile.c (generic_load): Add comment.
3699
3700 2019-07-01  Tom Tromey  <tromey@adacore.com>
3701
3702         * dwarf2read.c
3703         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3704         declaration of without_params.  Fix formatting.
3705
3706 2019-07-01  Tom Tromey  <tromey@adacore.com>
3707
3708         * ada-exp.y (find_primitive_type): Update.
3709         * ada-lang.h (ada_lookup_symbol): Update.
3710         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3711         parameter.
3712         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3713
3714 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3715
3716         PR breakpoints/24541
3717         * gdbarch.c: Regenerate.
3718         * gdbarch.h: Regenerate.
3719         * gdbarch.sh: Add 'stap_adjust_register'.
3720         * i386-tdep.c: Include '<unordered_set>'.
3721         (i386_stap_adjust_register): New function.
3722         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3723         * stap-probe.c (stap_parse_register_operand): Call
3724         'gdbarch_stap_adjust_register'.
3725
3726 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3727
3728         PR python/24742
3729         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3730         * python/python.c (do_start_initialization): Use 'xmalloc'
3731         instead of 'PyMem_Malloc'.
3732
3733 2019-06-28  Tom Tromey  <tromey@adacore.com>
3734
3735         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3736         for Ada.
3737
3738 2019-06-27  Tom Tromey  <tromey@adacore.com>
3739
3740         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3741         objfile_key.
3742         (arm_find_mapping_symbol, arm_record_special_symbol)
3743         (_initialize_arm_tdep): Update.
3744         (arm_objfile_data_free): Remove.
3745
3746 2019-06-27  Tom Tromey  <tromey@adacore.com>
3747
3748         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3749         to cp_print_static_field.
3750
3751 2019-06-26  Tom Tromey  <tromey@adacore.com>
3752
3753         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3754         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3755         declare.
3756
3757 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3758
3759         * features/aarch64-core.c (create_feature_aarch64_core):
3760         Regenerate.
3761         * features/aarch64-core.xml: Add cpsr flags.
3762
3763 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3764
3765         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3766         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3767
3768 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3769
3770         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3771         field.
3772         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3773         use.
3774         (arm_record_special_symbol): Don't insert new symbol in sorted
3775         position, push it at the end.
3776
3777 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3778
3779         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3780         (arm_mapping_symbol_s): Remove.
3781         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3782         (arm_mapping_symbol_vec): New typedef.
3783         (struct arm_per_objfile): Add constructor.
3784         <section_maps>: Change type to
3785         std::unique_ptr<arm_mapping_symbol_vec[]>.
3786         (arm_compare_mapping_symbols): Remove.
3787         (arm_find_mapping_symbol): Adjust to section_maps type change.
3788         (arm_objfile_data_free): Call delete on arm_per_objfile.
3789         (arm_record_special_symbol): Adjust to section_maps type change.
3790         Allocate arm_per_objfile with new.
3791
3792 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3793
3794         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3795         with the command prefix.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3800         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3801
3802 2019-06-25  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3805         type.
3806         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3807         protected.
3808
3809 2019-06-25  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui-winsource.c
3812         (tui_source_window_base::set_is_exec_point_at): Add check against
3813         LOA_ADDRESS.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-source.c (tui_set_source_content): Don't check before
3818         xfree.
3819         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3820
3821 2019-06-25  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-winsource.h (tui_update_source_window_as_is)
3824         (tui_alloc_source_buffer, tui_line_is_displayed)
3825         (tui_addr_is_displayed): Change type of win_info.
3826         * tui/tui-winsource.c (tui_update_source_window_as_is)
3827         (tui_clear_source_content, tui_show_source_line)
3828         (tui_show_source_content, tui_source_window_base::refill)
3829         (tui_source_window_base::set_is_exec_point_at)
3830         (tui_source_window_base::set_is_exec_point_at)
3831         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3832         (tui_alloc_source_buffer, tui_line_is_displayed)
3833         (tui_addr_is_displayed): Change type of win_info.  Update.
3834         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3835         (tui_source_window_base::do_make_visible_with_new_height):
3836         Update.
3837         * tui/tui-source.c (tui_set_source_content)
3838         (tui_set_source_content_nil)
3839         (tui_source_window::do_scroll_vertical): Update.
3840         * tui/tui-layout.c (show_layout): Update.
3841         * tui/tui-disasm.c (tui_set_disassem_content)
3842         (tui_disasm_window::do_scroll_vertical): Update.
3843         * tui/tui-data.h (tui_win_content): Remove.
3844         (struct tui_gen_win_info) <content, content_size>: Remove.
3845         (struct tui_source_element): Add initializers and destructor.
3846         (union tui_which_element, struct tui_win_element): Remove.
3847         (struct tui_source_window_base) <content>: New field.
3848         (struct tui_data_window): Remove destructor.
3849         (tui_alloc_content, tui_free_win_content)
3850         (tui_free_all_source_wins_content): Don't declare.
3851         * tui/tui-data.c (tui_initialize_static_data): Update.
3852         (init_content_element, tui_alloc_content): Remove.
3853         (~tui_gen_win_info): Update.
3854         (~tui_data_window, tui_free_all_source_wins_content)
3855         (tui_free_win_content, free_content, free_content_elements):
3856         Remove.
3857
3858 2019-06-25  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-winsource.h (tui_clear_source_content)
3861         (tui_erase_source_content, tui_show_source_content): Change type
3862         of win_info.
3863         * tui/tui-winsource.c (tui_clear_source_content)
3864         (tui_erase_source_content, tui_show_source_content): Change type
3865         of win_info.
3866         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3867         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3868         win_info.
3869         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3870         win_info.
3871         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-winsource.c (tui_clear_source_content)
3876         (tui_source_window_base::set_is_exec_point_at): Update.
3877         * tui/tui-source.c (tui_set_source_content_nil): Update.
3878         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3879         a bool.
3880         * tui/tui-data.c (init_content_element): Update.
3881
3882 2019-06-25  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3885         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3886         * tui/tui-layout.c (init_and_make_win): Update.
3887         * tui/tui.h (enum tui_win_type): Update.
3888         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3889         tui_win_is_auxillary.
3890         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3891         tui_win_is_auxillary.
3892
3893 2019-06-25  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3896         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3897         (tui_delete_data_content_windows, tui_display_all_data)
3898         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3899         Update.
3900         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3901         * tui/tui-regs.c (tui_last_regs_line_no)
3902         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3903         (tui_show_registers): Update.
3904         (tui_show_register_group): Return void.  Update.
3905         (tui_display_registers_from, tui_display_reg_element_at_line)
3906         (tui_display_registers_from_line, tui_check_register_values):
3907         Update.
3908         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3909         member.
3910         (struct tui_data_window) <regs_content>: Now a std::vector.
3911         <regs_content_count>: Remove.
3912         (tui_add_content_elements, tui_free_data_content): Don't declare.
3913         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3914         (init_content_element): Remove DATA_WIN case.  Add assert.
3915         (tui_add_content_elements): Remove.
3916         (tui_data_window): Update.
3917         (tui_free_data_content): Remove.
3918         (free_content_elements): Remove DATA_WIN case.
3919
3920 2019-06-25  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-data.c (tui_data_item_window): Update.
3923         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3924         * tui/tui-windata.c (tui_display_all_data)
3925         (tui_display_data_from_line): Update.
3926         (tui_check_data_values): Remove.
3927         * tui/tui-regs.c (tui_show_register_group)
3928         (tui_display_reg_element_at_line): Update.
3929         * tui/tui-hooks.c (tui_register_changed)
3930         (tui_refresh_frame_and_register_information): Call
3931         tui_check_register_values.
3932         * tui/tui-data.h (struct tui_data_window) <data_content,
3933         data_content_count, data_type>: Remove.
3934         (enum tui_data_type): Remove.
3935
3936         * tui/tui-data.c (tui_data_window::clear_detail)
3937         (~tui_data_window): Update.
3938
3939 2019-06-25  Tom Tromey  <tom@tromey.com>
3940
3941         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3942         declare.
3943         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3944         Rename from tui_first_data_item_displayed.  Update.
3945         (tui_data_window::refresh_all)
3946         (tui_data_window::do_scroll_vertical): Update.
3947         * tui/tui-data.h (struct tui_data_window)
3948         <first_data_item_displayed>: Declare new method.
3949
3950 2019-06-25  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3953         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3954         contents...
3955         (tui_initialize_static_data): ...here.
3956
3957 2019-06-25  Tom Tromey  <tom@tromey.com>
3958
3959         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3960         (tui_display_registers_from, tui_check_register_values): Update.
3961         (tui_display_register): Remove win_info parameter; update.
3962         (tui_get_register): Change type of parameters.
3963         * tui/tui-data.h (struct tui_data_element): Remove.
3964         (union tui_which_element) <data>: Remove.
3965         <data_window>: Change type.
3966         (struct tui_data_item_window): New.
3967         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3968         case.  Add assert.
3969         (~tui_data_item_window): New destructor.
3970         (free_content_elements): Remove DATA_ITEM_WIN case.
3971
3972 2019-06-25  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3975         Remove.
3976
3977 2019-06-25  Tom Tromey  <tom@tromey.com>
3978
3979         * tui/tui-data.h (struct tui_command_element): Remove.
3980         (union tui_which_element) <command>: Remove.
3981         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3982         assert.
3983         (free_content_elements): Remove CMD_WIN case.
3984
3985 2019-06-25  Tom Tromey  <tom@tromey.com>
3986
3987         * tui/tui-layout.c (tui_set_layout): Update.
3988         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3989         * tui/tui-data.c (layout_def): Update.
3990
3991 2019-06-25  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3994         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3995         (tui_source_window_base::set_new_height): Update.
3996         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3997         Update.
3998         (tui_set_locator_fullname, tui_set_locator_info)
3999         (tui_show_frame_info): Update.
4000         * tui/tui-source.c (tui_set_source_content)
4001         (tui_source_is_displayed): Update.
4002         * tui/tui-layout.c (show_source_disasm_command, show_data)
4003         (show_source_or_disasm_and_command): Update.
4004         * tui/tui-disasm.c (tui_set_disassem_content)
4005         (tui_get_begin_asm_address): Update.
4006         * tui/tui-data.h (struct tui_locator_element): Remove.
4007         (union tui_which_element) <locator>: Remove.
4008         (struct tui_locator_window): New.
4009         (tui_locator_win_info_ptr): Change return type.
4010         * tui/tui-data.c (_locator): Change type.
4011         (tui_locator_win_info_ptr): Change return type.
4012         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4013         (tui_alloc_content): Add assert.
4014
4015 2019-06-25  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-winsource.c
4018         (tui_exec_info_window::maybe_allocate_content): New method.
4019         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4020         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4021         (make_source_or_disasm_window): Add cast.
4022         * tui/tui-data.h (union tui_which_element) <simple_string>:
4023         Remove.
4024         (struct tui_source_info): New.
4025         (struct tui_source_window_base) <execution_info>: Change type.
4026         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4027         case, and add assert.
4028         (tui_alloc_content): Add assert.
4029
4030 2019-06-25  Tom Tromey  <tom@tromey.com>
4031
4032         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4033         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4034         * tui/tui-data.c (tui_alloc_win_info): Remove.
4035
4036 2019-06-25  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4039         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4040         can_highlight.
4041
4042 2019-06-25  Tom Tromey  <tom@tromey.com>
4043
4044         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4045         make_visible_with_new_height method.
4046         (tui_win_info::make_visible_with_new_height): New method.
4047         (tui_source_window_base::do_make_visible_with_new_height)
4048         (tui_data_window::do_make_visible_with_new_height)
4049         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4050         (make_visible_with_new_height): Remove.
4051         (tui_resize_all, tui_adjust_win_heights): Use
4052         make_visible_with_new_height method.
4053         * tui/tui-data.h (struct tui_win_info)
4054         <do_make_visible_with_new_height, make_visible_with_new_height>:
4055         New methods.
4056         (struct tui_source_window_base, struct tui_data_window)
4057         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4058         methods.
4059
4060 2019-06-25  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4063         method.
4064         (update_tab_width): Call update_tab_width method.
4065         * tui/tui-data.h (struct tui_win_info)
4066         (struct tui_source_window_base) <update_tab_width>: New methods.
4067
4068 2019-06-25  Tom Tromey  <tom@tromey.com>
4069
4070         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4071         parameter.
4072         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4073         parameter.
4074         (tui_gen_win_info::make_visible): Update.
4075         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4076         parameter.
4077         * tui/tui-data.h (enum tui_box): New enum.
4078         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4079
4080 2019-06-25  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4083         init_and_make_win for EXEC_INFO_WIN.
4084         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4085         longer inline.
4086         (struct tui_win_info) <~tui_win_info>: Inline.
4087         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4088         Don't declare.
4089         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4090         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4091         Remove.
4092         (tui_initialize_static_data): Update.
4093         (~tui_gen_win_info): Handle more cleanup here.
4094         (~tui_source_window_base): Delete "execution_info".
4095         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4096
4097 2019-06-25  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-layout.c (make_command_window): Don't set
4100         can_highlight.
4101         (show_source_disasm_command): Call the reset method.
4102         (show_data): Don't set can_highlight.  Call the reset method.
4103         (tui_gen_win_info::reset): Rename from init_gen_win_info
4104         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4105         (show_source_or_disasm_and_command): Call the reset method.
4106         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4107         (struct tui_cmd_window): Set can_highlight.
4108
4109 2019-06-25  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4112         from make_visible.
4113         (tui_make_visible, tui_make_invisible): Rewrite.
4114         (tui_win_info::make_visible): Remove.
4115         (tui_source_window_base::make_visible): Update.
4116         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4117         method.  Moved from...
4118         (struct tui_win_info) <make_visible>: ...here.
4119
4120 2019-06-25  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-winsource.c
4123         (tui_source_window_base::do_scroll_horizontal): Remove direction
4124         parameter.
4125         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4126         direction parameter.
4127         * tui/tui-win.c (tui_win_info::forward_scroll)
4128         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4129         (tui_win_info::right_scroll): Update.
4130         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4131         direction parameter.
4132         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4133         direction parameter.
4134         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4135         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4136         Remove direction parameter.
4137         (struct tui_source_window_base, struct tui_source_window)
4138         (struct tui_disasm_window, struct tui_data_window)
4139         (struct tui_cmd_window): Update.
4140
4141 2019-06-25  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-winsource.h (tui_set_exec_info_content)
4144         (tui_show_exec_info_content, tui_erase_exec_info_content)
4145         (tui_clear_exec_info_content, tui_update_exec_info): Change
4146         argument to tui_source_window_base.
4147         * tui/tui-winsource.c (tui_set_exec_info_content)
4148         (tui_show_exec_info_content, tui_erase_exec_info_content)
4149         (tui_clear_exec_info_content, tui_update_exec_info): Change
4150         argument to tui_source_window_base.
4151
4152 2019-06-25  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4155         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4156
4157 2019-06-25  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4160         check.
4161
4162 2019-06-25  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4165         type to void.
4166         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4167         type to void.
4168         * tui/tui-source.c (tui_set_source_content): Update.
4169         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4170
4171 2019-06-25  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-win.c (window_name_completer, tui_set_focus)
4174         (tui_all_windows_info): Use name method.
4175         * tui/tui-data.h (struct tui_gen_win_info)
4176         (struct tui_source_window, struct tui_disasm_window)
4177         (struct tui_data_window, struct tui_cmd_window) <name>: New
4178         method.
4179         (tui_win_name): Don't declare.
4180         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4181         (tui_win_name): Remove.
4182
4183 2019-06-25  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-winsource.h (tui_update_source_window)
4186         (tui_update_source_window_as_is): Change parameter type.
4187         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4188         to be a tui_source_window_base.
4189         (tui_update_source_window_as_is): Likewise.
4190         * tui/tui-win.c (make_visible_with_new_height): Update.
4191
4192 2019-06-25  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-winsource.c (tui_erase_source_content)
4195         (tui_show_source_content, tui_show_exec_info_content)
4196         (tui_erase_exec_info_content): Use refresh_window method.
4197         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4198         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4199         from tui_refresh_win.
4200         (tui_data_window::refresh_window): New method.
4201         (tui_win_info::refresh, tui_source_window_base::refresh)
4202         (tui_refresh_all): Use refresh_window method.
4203         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4204         method.
4205         * tui/tui-regs.c (tui_display_register): Call refresh_window
4206         method.
4207         * tui/tui-layout.c (show_source_disasm_command)
4208         (show_source_or_disasm_and_command): Call refresh_window method.
4209         * tui/tui-data.h (struct tui_gen_win_info)
4210         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4211         New method.
4212
4213 2019-06-25  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui.c (tui_rl_other_window, tui_enable)
4216         (tui_is_window_visible, tui_get_command_dimension): Update.
4217         * tui/tui-winsource.c (tui_update_source_window_as_is)
4218         (tui_clear_source_content, tui_erase_source_content)
4219         (tui_show_source_line, tui_source_window_base::refill)
4220         (tui_source_window_base::do_scroll_horizontal)
4221         (tui_source_window_base::set_is_exec_point_at)
4222         (tui_update_breakpoint_info, tui_set_exec_info_content)
4223         (tui_alloc_source_buffer, tui_line_is_displayed)
4224         (tui_addr_is_displayed): Update.
4225         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4226         (tui_check_and_display_highlight_if_needed)
4227         (tui_win_info::make_visible, tui_win_info::refresh)
4228         (tui_refresh_all): Update.
4229         * tui/tui-windata.c (tui_first_data_item_displayed)
4230         (tui_delete_data_content_windows, tui_erase_data_content)
4231         (tui_display_all_data, tui_data_window::refresh_all)
4232         (tui_check_data_values): Update.
4233         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4234         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4235         (tui_win_info::backward_scroll, tui_refresh_all_win)
4236         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4237         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4238         (tui_source_window_base::set_new_height)
4239         (tui_data_window::set_new_height)
4240         (make_invisible_and_set_new_height)
4241         (make_visible_with_new_height, new_height_ok)
4242         (parse_scrolling_args): Update.
4243         * tui/tui-stack.c (tui_show_frame_info): Update.
4244         * tui/tui-source.c (tui_set_source_content)
4245         (tui_set_source_content_nil, tui_source_is_displayed)
4246         (tui_source_window::do_scroll_vertical): Update.
4247         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4248         (tui_display_registers_from, tui_display_reg_element_at_line)
4249         (tui_check_register_values, tui_reg_command): Update.
4250         * tui/tui-layout.c (tui_default_win_height)
4251         (show_source_disasm_command, show_data, init_and_make_win)
4252         (show_source_or_disasm_and_command): Update.
4253         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4254         (tui_redisplay_readline, tui_mld_flush)
4255         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4256         (tui_getc): Update.
4257         * tui/tui-disasm.c (tui_set_disassem_content)
4258         (tui_disasm_window::do_scroll_vertical): Update.
4259         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4260         Now virtual.
4261         (struct tui_win_info): Derive from tui_gen_win_info.
4262         <~tui_win_info>: Mark as override.
4263         <generic>: Remove member.
4264         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4265         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4266         (~tui_data_window, ~tui_win_info)
4267         (tui_free_all_source_wins_content): Update.
4268         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4269
4270 2019-06-25  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-layout.c (init_and_make_win): Use new.
4273         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4274         destructor, initializers.
4275         (tui_alloc_generic_win_info): Don't declare.
4276         * tui/tui-data.c (_locator): Add argument to constructor.
4277         (source_win, disasm_win): New globals.
4278         (exec_info): Remove.
4279         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4280         Update.
4281         (tui_alloc_generic_win_info): Remove.
4282         (init_content_element): Use new.
4283         (tui_win_info::tui_win_info): Update.
4284         (free_content_elements) <case DATA_WIN>: Use delete.
4285
4286 2019-06-25  Tom Tromey  <tom@tromey.com>
4287
4288         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4289         * tui/tui-windata.c (tui_first_data_item_displayed)
4290         (tui_delete_data_content_windows): Update.
4291         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4292         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4293         (tui_display_registers_from, tui_check_register_values): Update.
4294         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4295         pointer.
4296         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4297         window.
4298         (tui_free_data_content): Update.
4299         (free_content_elements) <case DATA_WIN>: Free the window.
4300
4301 2019-06-25  Tom Tromey  <tom@tromey.com>
4302
4303         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4304         Update.
4305         * tui/tui-layout.c (make_command_window)
4306         (show_source_disasm_command, show_data, init_and_make_win)
4307         (show_source_or_disasm_and_command): Update.
4308         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4309         method.
4310         <can_highight, is_highlighted>: Now bool.
4311         (tui_set_win_highlight): Don't declare.
4312         * tui/tui-data.c (tui_set_win_highlight): Remove.
4313
4314 2019-06-25  Tom Tromey  <tom@tromey.com>
4315
4316         * tui/tui-wingeneral.c (make_visible): Remove check of window
4317         type.
4318
4319 2019-06-25  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-win.c (tui_win_info::max_height)
4322         (tui_cmd_window::max_height): New methods.
4323         (new_height_ok): Call max_height.
4324         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4325         <max_height>: New method.
4326
4327 2019-06-25  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-win.c (tui_source_window_base::set_new_height)
4330         (tui_data_window::set_new_height): New methods.
4331         (make_invisible_and_set_new_height): Call set_new_height method.
4332         * tui/tui-data.h (struct tui_win_info)
4333         (struct tui_source_window_base, struct tui_data_window)
4334         <set_new_height>: New method.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4339         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4340         tui_refresh_data_win.
4341         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4342         method.
4343         (tui_refresh_all_win): Call the refresh_all method.
4344         (tui_set_focus): Likewise.
4345         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4346         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4347         Likewise.
4348
4349 2019-06-25  Tom Tromey  <tom@tromey.com>
4350
4351         * tui/tui-winsource.h (tui_refill_source_window)
4352         (tui_set_is_exec_point_at): Don't declare.
4353         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4354         (tui_source_window_base::refill): Rename from
4355         tui_refill_source_window.
4356         (tui_source_window_base::do_scroll_horizontal): Update.
4357         (tui_source_window_base::set_is_exec_point_at): Rename from
4358         tui_set_is_exec_point_at.
4359         (tui_update_all_breakpoint_info): Update.
4360         * tui/tui-stack.c (tui_show_frame_info): Update.
4361         * tui/tui-layout.c (show_data): Add cast.
4362         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4363         * tui/tui-data.h (struct tui_source_window_base) <refill,
4364         set_is_exec_point_at>: New methods.
4365         (tui_source_windows, tui_add_to_source_windows): Update types.
4366         (tui_add_to_source_windows): Remove redundant declaration.
4367         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4368         (tui_source_windows): Change return type.
4369         (tui_clear_source_windows_detail): Update.
4370         (tui_add_to_source_windows): Change type of parameter.
4371         (tui_free_all_source_wins_content): Update.
4372
4373 2019-06-25  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-wingeneral.c (tui_win_info::refresh)
4376         (tui_source_window_base::refresh): New methods.
4377         (tui_refresh_all): Call the refresh method.
4378         * tui/tui-data.h (struct tui_win_info)
4379         (struct tui_source_window_base) <refresh>: New method.
4380
4381 2019-06-25  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui.h (tui_is_window_visible): Return bool.
4384         * tui/tui.c (tui_is_window_visible): Return bool.
4385         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4386         (tui_make_visible, tui_make_invisible)
4387         (tui_win_info::make_visible)
4388         (tui_source_window_base::make_visible, make_all_visible)
4389         (tui_make_all_visible, tui_make_all_invisible): Update.
4390         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4391         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4392         bool.
4393         (struct tui_win_info, struct tui_source_window_base)
4394         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4395         * tui/tui-data.c (tui_init_generic_part): Update.
4396
4397 2019-06-25  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4400         (tui_source_window_base::make_visible): New methods.
4401         (make_all_visible): Make method call.
4402         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4403         (struct tui_source_window_base, struct tui_cmd_window): Override
4404         make_visible.
4405         (tui_win_is_source_type): Don't declare.
4406         * tui/tui-data.c (tui_win_is_source_type): Remove.
4407
4408 2019-06-25  Tom Tromey  <tom@tromey.com>
4409
4410         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4411         NULL check.
4412
4413 2019-06-25  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4416         Inline constructor.  Add initializers for members.
4417         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4418         constructors; now inline in class.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-regs.c (tui_show_registers): Update.
4423         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4424         bool.
4425         * tui/tui-data.c (tui_data_window::clear_detail)
4426         (tui_data_window): Update.
4427
4428 2019-06-25  Tom Tromey  <tom@tromey.com>
4429
4430         * tui/tui-windata.c (tui_display_all_data)
4431         (tui_display_data_from_line, tui_display_data_from)
4432         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4433         Update.
4434         * tui/tui-regs.c (tui_last_regs_line_no)
4435         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4436         (tui_show_registers, tui_show_register_group)
4437         (tui_display_registers_from, tui_display_reg_element_at_line)
4438         (tui_display_registers_from_line, tui_check_register_values)
4439         (tui_reg_next, tui_reg_prev): Update.
4440         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4441         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4442         tui_data_window.
4443         (struct tui_win_info) <detail>: Remove.  Add new fields from
4444         tui_data_info.
4445         (TUI_DATA_WIN): Add cast.
4446         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4447         (~tui_data_window): Simplify.
4448
4449 2019-06-25  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui-layout.c (show_source_disasm_command)
4452         (show_source_or_disasm_and_command): Update.
4453         * tui/tui-io.c (update_cmdwin_start_line)
4454         (tui_redisplay_readline): Update.
4455         * tui/tui-data.h (struct tui_command_info): Remove.
4456         (struct tui_win_info) <detail>: Remove command_info member.
4457         (struct tui_data_window) <start_line>: New member, from
4458         tui_command_info.
4459         (TUI_CMD_WIN): Add casts.
4460
4461 2019-06-25  Tom Tromey  <tom@tromey.com>
4462
4463         * tui/tui-winsource.c (tui_update_source_window)
4464         (tui_refill_source_window)
4465         (tui_source_window_base::do_scroll_horizontal)
4466         (tui_update_breakpoint_info, tui_set_exec_info_content)
4467         (tui_show_exec_info_content, tui_erase_exec_info_content)
4468         (tui_clear_exec_info_content): Update.
4469         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4470         Update.
4471         * tui/tui-win.c (make_invisible_and_set_new_height)
4472         (make_visible_with_new_height): Update.
4473         * tui/tui-source.c (tui_set_source_content)
4474         (tui_show_symtab_source): Update.
4475         * tui/tui-layout.c (extract_display_start_addr)
4476         (show_source_disasm_command, show_data)
4477         (make_source_or_disasm_window)
4478         (show_source_or_disasm_and_command): Update.
4479         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4480         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4481         "gdbarch".
4482         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4483         to tui_source_window_base.
4484         (struct tui_win_info) <detail>: Remove source_info member.
4485         (struct tui_source_window_base) <has_locator>: Inline.
4486         Move contents from tui_source_info; rename has_locator member to
4487         m_has_locator.
4488         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4489         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4490         header file.
4491         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4492         Simplify.
4493         (tui_free_all_source_wins_content): Cast to
4494         tui_source_window_base.
4495
4496 2019-06-25  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-win.c (make_invisible_and_set_new_height)
4499         (make_visible_with_new_height): Call has_locator method.
4500         * tui/tui-layout.c (show_source_disasm_command, show_data)
4501         (show_source_or_disasm_and_command): Update for bool change.
4502         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4503         (tui_win_info) <has_locator>: New method.
4504         (struct tui_source_window_base) <has_locator>: New method.
4505         (tui_win_has_locator): Don't declare.
4506         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4507         from tui_win_has_locator.
4508         (tui_source_window_base): Use false, not FALSE.
4509
4510 2019-06-25  Tom Tromey  <tom@tromey.com>
4511
4512         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4513         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4514         clear_detail method directly.
4515         (tui_clear_win_detail): Remove.
4516
4517 2019-06-25  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4520         "this", not TUI_DISASM_WIN.
4521
4522 2019-06-25  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4525         declare.
4526         * tui/tui-winsource.c
4527         (tui_source_window_base::do_scroll_horizontal): Rename from
4528         tui_horizontal_source_scroll.
4529         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4530         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4531         from tui_vertical_data_scroll.
4532         * tui/tui-win.h (tui_scroll): Don't declare.
4533         * tui/tui-win.c (tui_win_info::forward_scroll)
4534         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4535         (tui_win_info::right_scroll): Rename and update.
4536         (tui_scroll_forward_command, tui_scroll_backward_command)
4537         (tui_scroll_left_command, tui_scroll_right_command): Update.
4538         (tui_scroll): Remove.
4539         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4540         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4541         from tui_vertical_source_scroll.
4542         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4543         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4544         from tui_vertical_disassem_scroll.
4545         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4546         do_scroll_horizontal>: New methods.
4547         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4548         Likewise.
4549         (struct tui_source_window_base): Add do_scroll_horizontal.
4550         (struct tui_source_window, struct tui_disasm_window): Add
4551         do_scroll_vertical.
4552         (struct tui_data_window, struct tui_cmd_window): Add
4553         do_scroll_horizontal and do_scroll_vertical.
4554         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4555
4556 2019-06-25  Tom Tromey  <tom@tromey.com>
4557
4558         * tui/tui-data.h (struct tui_source_window_base): New struct.
4559         (struct tui_source_window): Derive from tui_source_window_base.
4560         (struct tui_disasm_window): New struct.
4561         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4562         from tui_source_window::clear_detail.
4563         (tui_source_window_base): Rename from tui_source_window.
4564         (~tui_source_window_base): Rename from ~tui_source_window.
4565         (tui_alloc_win_info): Create a tui_disasm_window.
4566
4567 2019-06-25  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-data.h (struct tui_source_window)
4570         (struct tui_data_window): Declare destructors.
4571         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4572         destructors.
4573         (tui_win_info): Simplify.
4574
4575 2019-06-25  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-winsource.c (tui_display_main)
4578         (tui_update_source_windows_with_addr)
4579         (tui_update_all_breakpoint_info): Update.
4580         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4581         (new_height_ok, parse_scrolling_args): Update.
4582         * tui/tui-stack.c (tui_show_frame_info): Update.
4583         * tui/tui-data.h (struct tui_list): Remove.
4584         (tui_source_windows): Return a reference to a std::vector.
4585         * tui/tui-data.c (source_windows): Now a std::vector.
4586         (tui_source_windows): Change return type.
4587         (tui_clear_source_windows): Rewrite.
4588         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4589         (tui_free_all_source_wins_content): Rewrite.
4590
4591 2019-06-25  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4594         (struct tui_data_window, struct tui_cmd_window): Declare
4595         clear_detail method.
4596         * tui/tui-data.c (tui_source_window::clear_detail)
4597         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4598         methods.
4599         (tui_clear_win_detail): Simplify.
4600
4601 2019-06-25  Tom Tromey  <tom@tromey.com>
4602
4603         * tui/tui-layout.c (make_source_window, make_disasm_window)
4604         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4605         Return the new window.
4606         (show_source_disasm_command, show_data)
4607         (show_source_or_disasm_and_command): Update.
4608
4609 2019-06-25  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4612         parameter.  Return the new window.
4613         (show_source_disasm_command): Update and remove NULL check.
4614         (show_source_or_disasm_and_command): Update.
4615
4616 2019-06-25  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4619
4620 2019-06-25  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-data.h (struct tui_win_info): Make constructor
4623         protected.  Make destructor virtual.  Add initializers.
4624         (tui_source_window, tui_data_window, tui_cmd_window): New
4625         classes.
4626         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4627         constructor.  Add "type" parameter.
4628         (tui_source_window, tui_data_window, tui_cmd_window): New
4629         constructors.
4630         (tui_alloc_win_info): Instantiate the appropriate subclass.
4631
4632 2019-06-25  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-win.c (tui_resize_all): Use delete.
4635         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4636         destructor.
4637         (tui_free_window): Don't declare.
4638         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4639         Update.
4640
4641 2019-06-25  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-data.h (struct tui_win_info): Add constructor.
4644         * tui/tui-data.c (tui_alloc_win_info): Use new.
4645         (tui_free_window): Use delete.
4646
4647 2019-06-22  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4650         declare.
4651         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4652
4653 2019-06-22  Tom Tromey  <tom@tromey.com>
4654
4655         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4656         declare.
4657         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4658
4659 2019-06-22  Tom de Vries  <tdevries@suse.de>
4660
4661         * dwarf2read.c (create_addrmap_from_aranges)
4662         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4663         instead of '%zu'.
4664
4665 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4666
4667         * dwarf2read.h (dwarf2_section_info_def): Remove.
4668         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4669         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4670         std::vector<dwarf2_section_info>.
4671         (struct dwo_file) <~dwo_file>: Remove.
4672         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4673         types field.
4674         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4675         (dwarf2_read_debug_names): Likewise.
4676         (create_debug_types_hash_table): Change parameter type to
4677         array_view, adjust code accordingly.
4678         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4679         (partial_die_info::fixup): Likewise.
4680         (determine_prefix): Likewise.
4681         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4682
4683 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4684
4685         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4686         gdb_bfd_ref_ptr.
4687         <~dwo_file>: Remove call to gdb_bfd_unref.
4688         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4689         gdb_bfd_ref_ptr::get.
4690
4691 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4692
4693         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4694         type to htab_up.
4695         * dwarf2read.c (struct dwo_file): Initialize fields.
4696         <~dwo_file>: New.
4697         (free_dwo_file): Remove, move content to ~dwo_file.
4698         (struct dwo_file_deleter): Remove.
4699         (dwo_file_up>: Remove custom deleter.
4700         (free_dwo_files): Remove.
4701         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4702         dwo_files.
4703         (process_skeletonless_type_units): Call unique_ptr::get.
4704         (allocate_dwo_file_hash_table): Add deleter to created hash
4705         table.  Change return type to htab_up.
4706         (lookup_dwo_file_slot): Don't memset dwo_file, call
4707         unique_ptr::get.
4708         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4709         (create_dwo_unit_in_dwp_v2): Likewise.
4710         (open_and_init_dwo_file): Likewise.
4711         (free_dwo_file_from_slot): Remove.
4712
4713 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4714
4715         * dwarf2read.h (struct dwarf2_section_info) <readin,
4716         is_virtual>: Change type to bool.
4717         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4718         true instead of 1.
4719
4720 2019-06-19  Tom Tromey  <tom@tromey.com>
4721
4722         * tui/tui-data.h (tui_init_content_element): Don't declare.
4723
4724 2019-06-19  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-data.h (tui_init_win_info): Don't declare.
4727
4728 2019-06-19  Tom de Vries  <tdevries@suse.de>
4729
4730         * dwarf2read.h (abstract_to_concrete): Change type to
4731         std::unordered_map<sect_offset, std::vector<sect_offset>,
4732         gdb::hash_enum<sect_offset>>.
4733
4734 2019-06-19  Tom Tromey  <tromey@adacore.com>
4735
4736         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4737         EVAL_AVOID_SIDE_EFFECTS specially.
4738
4739 2019-06-19  Tom Tromey  <tromey@adacore.com>
4740
4741         * source-cache.c (highlighter): New global.
4742         (source_cache::get_source_lines): Create a highlighter on demand.
4743
4744 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4745
4746         * defs.h (deprecated_interactive_hook): Delete declaration.
4747         * interps.c (clear_interpreter_hooks): Remove use of
4748         deprecated_interactive_hook.
4749         * top.c (deprecated_interactive_hook): Delete definition.
4750         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4751
4752 2019-06-18  Tom de Vries  <tdevries@suse.de>
4753
4754         PR gdb/24515
4755         * dwarf2read.h (abstract_to_concrete): Change type from
4756         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4757         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4758         * dwarf2read.c (read_variable): Update.
4759         (dwarf2_fetch_die_loc_sect_off): Update.
4760
4761 2019-06-17  Tom de Vries  <tdevries@suse.de>
4762
4763         PR gdb/24617
4764         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4765         accessing parent[parent_len - 1].
4766
4767 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4768
4769         PR gdb/24364
4770         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4771         call dtrace_process_dof with NULL dof.
4772
4773 2019-06-16  Tom de Vries  <tdevries@suse.de>
4774
4775         PR gdb/24445
4776         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4777
4778 2019-06-16  Tom Tromey  <tom@tromey.com>
4779
4780         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4781         (make_all_visible): Use address of member.
4782
4783 2019-06-16  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4786         (tui_free_window, free_content, free_content_elements): Remove
4787         unnecessary cast.
4788         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4789         cast.
4790         * tui/tui-regs.c (tui_show_register_group)
4791         (tui_display_registers_from, tui_display_reg_element_at_line):
4792         Remove unnecessary cast.
4793
4794 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * linux-nat.c (normal_mask): Delete.
4797         (_initialize_linux_nat): Don't initialise normal_mask.
4798
4799 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4800
4801         PR gdb/24445
4802         * dwarf-index-write.h (write_psymtabs_to_index): Add
4803         dwz_basename parameter.
4804         * dwarf-index-write.c (write_gdbindex): Move file writing to
4805         write_gdbindex_1.  Change return type void.
4806         (assert_file_size): Move up, remove filename parameter.
4807         (write_gdbindex_1): New function.
4808         (write_debug_names): Change return type to void, call
4809         assert_file_size.
4810         (struct index_wip_file): New struct.
4811         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4812         file logic to index_wip_file.  Write index for dwz file if
4813         needed.
4814         (save_gdb_index_command): Pass basename of dwz file, if present.
4815         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4816         build-id of dwz file, if present.
4817         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4818         (dwarf2_get_dwz_file): Likewise.
4819         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4820         (dwarf2_get_dwz_file): Likewise.
4821
4822 2019-06-16  Tom Tromey  <tom@tromey.com>
4823
4824         * coffread.c (process_coff_symbol): Use xstrdup.
4825         * value.c (create_internalvar): Use xstrdup.
4826
4827 2019-06-16  Tom Tromey  <tom@tromey.com>
4828
4829         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4830         * breakpoint.c (stopin_command, stopat_command)
4831         (until_break_command, decode_location_default): Remove unnecessary
4832         cast.
4833         * utils.c (subset_compare): Remove unnecessary cast.
4834         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4835         cast.
4836         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4837         cast.
4838         * infcmd.c (path_command): Remove unnecessary cast.
4839         * coffread.c (decode_type): Remove unnecessary cast.
4840         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4841         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4842         * tui/tui-stack.c (tui_show_locator_content)
4843         (tui_show_frame_info): Remove unnecessary cast.
4844         * tui/tui-win.c (tui_scroll_forward_command)
4845         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4846         (parse_scrolling_args): Remove unnecessary cast.
4847         * tui/tui-data.c (init_win_info, tui_del_window)
4848         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4849         (free_content_elements): Remove unnecessary cast.
4850         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4851         unnecessary cast.
4852         * tui/tui-source.c (tui_set_source_content)
4853         (tui_vertical_source_scroll): Remove unnecessary cast.
4854         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4855         cast.
4856         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4857         * tui/tui-regs.c (tui_display_registers_from)
4858         (tui_display_register): Remove unnecessary cast.
4859         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4860         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4861         (make_visible): Remove unnecessary cast.
4862         * tui/tui-winsource.c (tui_erase_source_content)
4863         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4864         unnecessary cast.
4865         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4866         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4867         * stabsread.c (read_type, read_array_type, read_range_type):
4868         Remove unnecessary cast.
4869         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4870         (parse_symbol, parse_type, upgrade_type, parse_external)
4871         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4872         unnecessary cast.
4873         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4874
4875 2019-06-16  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-data.c (tui_alloc_generic_win_info)
4878         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4879         checks.
4880
4881 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4882             Andrew Burgess  <andrew.burgess@embecosm.com>
4883
4884         * f-typeprint.c (f_print_type): Don't return early for not
4885         associated or not allocated types.
4886         (f_type_print_varspec_suffix): Add print_rank parameter and print
4887         ranks of array types in case they dangling.
4888         (f_type_print_base): Add print_rank parameter.
4889
4890 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * NEWS: Mention new MI commands.
4893         * break-catch-throw.c (enum exception_event_kind): Move to
4894         breakpoint.h.
4895         (print_mention_exception_catchpoint): Output text as a single
4896         message.
4897         (catch_exception_command_1): Rename to...
4898         (catch_exception_event): ...this, make non-static, update header
4899         command, and change some parameter types.
4900         (catch_catch_command): Update for changes to
4901         catch_exception_command_1.
4902         (catch_throw_command): Likewise.
4903         (catch_rethrow_command): Likewise.
4904         * breakpoint.c (enum exception_event_kind): Delete.
4905         * breakpoint.h (enum exception_event_kind): Moved here from
4906         break-catch-throw.c.
4907         (catch_exception_event): Declare.
4908         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4909         (mi_cmd_catch_throw): New function.
4910         (mi_cmd_catch_rethrow): New function.
4911         (mi_cmd_catch_catch): New function.
4912         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4913         'catch-catch' entries.
4914         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4915         (mi_cmd_catch_rethrow): Declare.
4916         (mi_cmd_catch_catch): Declare.
4917
4918 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * annotate.c (annotate_source_line): Change return type to void,
4921         update implementation to match.
4922         * annotate.h (annotate_source_line): Change return type to void,
4923         update header comment.
4924         * stack.c (print_frame_info): Don't change what frame information
4925         is printed based on whether annotations are on or not.
4926
4927 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4930         (annotate_source): Make static.
4931         (annotate_source_line): Moved from source.c and renamed from
4932         identify_source_line.  Update the return type.
4933         * annotate.h (annotate_source): Delete declaration.
4934         (annotate_source_line): Declaration moved from source.h, and
4935         renamed from identify_source_line.  Return type updated.
4936         * source.c (identify_source_line): Moved to annotate.c and renamed
4937         to annotate_source_line.
4938         (info_line_command): Remove check of annotation_level.
4939         * source.h (identify_source_line): Move declaration to annotate.h
4940         and rename to annotate_source_line.
4941         * stack.c: Add 'annotate.h' include.
4942         (print_frame_info): Remove check of annotation_level before
4943         calling annotate_source_line.
4944
4945 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * source-cache.c (source_cache::get_plain_source_lines): Use
4948         open_source_file_with_line_charpos instead of just
4949         open_source_file, remove call to find_source_lines.
4950         (source_cache::get_source_lines): Likewise.
4951         * source.c (find_source_lines): Make static.
4952         (get_filename_and_charpos): Renamed into...
4953         (open_source_file_with_line_charpos): ..this along with changes to
4954         return a scoped_fd, and some other minor clean ups.
4955         (identify_source_line): Use open_source_file_with_line_charpos.
4956         (search_command_helper): Use open_source_file_with_line_charpos
4957         instead of just open_source_file, remove call to
4958         find_source_lines.
4959         * source.h (open_source_file_with_line_charpos): Declare new
4960         function.
4961         (find_source_lines): Delete declaration.
4962
4963 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * source.c (get_filename_and_charpos): Remove fullname
4966         parameter.
4967         (identify_source_line): Update call to get_filename_and_charpos.
4968
4969 2019-06-14  Tom Tromey  <tromey@adacore.com>
4970
4971         PR gdb/24502:
4972         * ui-style.h (skip_ansi_escape): Update comment.
4973         * ui-file.h (class no_terminal_escape_file): New class.
4974         * ui-file.c (no_terminal_escape_file::write)
4975         (no_terminal_escape_file::puts): New methods.
4976         * cli/cli-logging.c (handle_redirections): Use
4977         no_terminal_escape_file.
4978
4979 2019-06-14  Tom Tromey  <tromey@adacore.com>
4980
4981         * NEWS: Move convenience variable news above Python news.
4982
4983 2019-06-14  Tom Tromey  <tom@tromey.com>
4984
4985         * gnulib: Move directory to top-level.
4986         * configure.ac: Don't configure gnulib.
4987         * configure: Rebuild.
4988         * common/common-defs.h: Use new path to gnulib.
4989         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4990         (GNULIB_H): Remove.
4991         (INCGNU): Look in new gnulib location.
4992         (HFILES_NO_SRCDIR): Remove gnulib files.
4993         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4994         (generated_files): Remove GNULIB_H.
4995         ($(LIBGNU), all-lib): Remove targets.
4996         (distclean): Don't mention GNULIB_BUILDDIR.
4997         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4998
4999 2019-06-14  Tom Tromey  <tromey@adacore.com>
5000
5001         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5002         Warn if symbol file does not provide any symbols.
5003
5004 2019-06-14  Tom Tromey  <tromey@adacore.com>
5005
5006         * source.c (find_and_open_source): Respect basenames_may_differ.
5007
5008 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * annotate.c (annotate_breakpoints_invalid): Make use of
5011         scoped_restore_terminal_state.
5012         (annotate_frames_invalid): Likewise.
5013
5014 2019-06-14  Tom Tromey  <tromey@adacore.com>
5015
5016         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5017         allow assignment to an internalvar.
5018
5019 2019-06-14  Tom Tromey  <tromey@adacore.com>
5020
5021         * ada-lex.l: Allow "_" in attribute names.
5022
5023 2019-06-14  Tom Tromey  <tromey@adacore.com>
5024
5025         PR gdb/24653:
5026         * regcache.c (registers_changed): Don't call alloca.
5027         * top.c (execute_command): Don't call alloca.
5028
5029 2019-06-13  Pedro Alves  <palves@redhat.com>
5030
5031         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5032         'expression'.  When parsing an expression, error out if there's
5033         junk after "unlimited".
5034         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5035         (do_set_command): Adjust calls to is_unlimited_literal.
5036
5037 2019-06-13  Pedro Alves  <palves@redhat.com>
5038
5039         * compile/compile.c (make_compile_options_def_group): Add braces
5040         around array_view initializer.
5041         * thread.c (make_thread_apply_all_options_def_group)
5042         (make_thread_apply_all_options_def_group): Likewise.
5043
5044 2019-06-13  Pedro Alves  <palves@redhat.com>
5045
5046         * NEWS (New commands): Mention "maint test-options
5047         require-delimiter", "maint test-options unknown-is-error", "maint
5048         test-options unknown-is-operand" and "maint show
5049         test-options-completion-result".
5050         (New command options, command completion): New section.
5051         (Completion improvements): New section.
5052         Mention that you can abbreviate "unlimited".
5053
5054 2019-06-13  Pedro Alves  <palves@redhat.com>
5055
5056         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5057         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5058         * unittests/cli-utils-selftests.c (test_parse_flags)
5059         (test_parse_flags_qcs): Delete.
5060         (test_cli_utils): Don't call deleted functions.
5061
5062 2019-06-13  Pedro Alves  <palves@redhat.com>
5063
5064         * thread.c: Include "cli/cli-option.h".
5065         (tp_array_compar_ascending): Global.
5066         (tp_array_compar): Delete function.
5067         (tp_array_compar_ascending, tp_array_compar_descending): New
5068         functions.
5069         (ascending_option_def, qcs_flag_option_def)
5070         (thr_qcs_flags_option_defs)
5071         (make_thread_apply_all_options_def_group)
5072         (make_thread_apply_options_def_group): New.
5073         (thread_apply_all_command): Use gdb::option::process_options.
5074         (thread_apply_command_completer)
5075         (thread_apply_all_command_completer): New.
5076         (thread_apply_command): Use gdb::option::process_options.
5077         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5078         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5079         to generate help text of "thread apply".  Adjust "taas"'s help.
5080         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5081         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5082
5083 2019-06-13  Pedro Alves  <palves@redhat.com>
5084
5085         * thread.c (thread_apply_command): Check for invalid TID with
5086         isdigit instead of !isalpha.
5087
5088 2019-06-13  Pedro Alves  <palves@redhat.com>
5089
5090         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5091         (validate_flags_qcs): New.
5092         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5093         (validate_flags_qcs): Declare.
5094         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5095         (make_frame_apply_options_def_group): New.
5096         (frame_apply_command_count): Process options with
5097         gdb::option::process_options.
5098         (frame_apply_completer): New.
5099         (frame_apply_level_completer, frame_apply_all_completer)
5100         (frame_apply_completer): New.
5101         (_initialize_stack): Update help of "frame apply", "frame apply
5102         level", "frame apply all" and "faas" to mention supported options
5103         and install command completers.
5104         * stack.h (frame_apply_all_completer): Declare.
5105         * thread.c: Include "stack.h".
5106         (tfaas_command): Add "--".
5107         (_initialize_thread): Update help "tfaas" to mention supported
5108         options and install command completer.
5109
5110 2019-06-13  Pedro Alves  <palves@redhat.com>
5111
5112         * completer.c (complete_nested_command_line): New.
5113         (gdb_completion_word_break_characters_throw): Add assertion.
5114         * completer.h (complete_nested_command_line): Declare.
5115
5116 2019-06-13  Pedro Alves  <palves@redhat.com>
5117
5118         * stack.c (parse_backtrace_qualifiers): New.
5119         (backtrace_command): Use it.
5120         (backtrace_command_completer): Complete on qualifiers.
5121
5122 2019-06-13  Pedro Alves  <palves@redhat.com>
5123
5124         * frame.c: Include "cli/cli-option.h.
5125         (user_set_backtrace_options): New.
5126         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5127         Delete.
5128         (get_prev_frame): Adjust.
5129         (boolean_option_def, uinteger_option_def)
5130         (set_backtrace_option_defs): New.
5131         (_initialize_frame): Adjust and use
5132         gdb::option::add_setshow_cmds_for_options to install "set
5133         backtrace past-main" and "set backtrace past-entry".
5134         * frame.h: Include "cli/cli-option.h".
5135         (struct frame_print_options): Forward declare.
5136         (print_frame_arguments_all, print_frame_arguments_scalars)
5137         (print_frame_arguments_none): Declare.
5138         (print_entry_values): Delete declaration.
5139         (struct frame_print_options, user_frame_print_options): New.
5140         (struct set_backtrace_options): New.
5141         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5142         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5143         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5144         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5145         (list_args_or_locals): Add frame_print_options parameter.
5146         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5147         * python/py-framefilter.c (enumerate_args): Pass down
5148         USER_FRAME_PRINT_OPTIONS.
5149         * stack.c: Include "cli/cli-option.h".
5150         (print_frame_arguments_all, print_frame_arguments_scalars)
5151         (print_frame_arguments_none): Declare.
5152         (print_raw_frame_arguments, print_entry_values): Delete.
5153         (user_frame_print_options): New.
5154         (boolean_option_def, enum_option_def, frame_print_option_defs):
5155         New.
5156         (struct backtrace_cmd_options): New.
5157         (bt_flag_option_def): New.
5158         (backtrace_command_option_defs): New.
5159         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5160         (print_frame_arg, read_frame_arg, print_frame_args)
5161         (print_frame_info, print_frame): Add frame_print_options parameter
5162         and use it.
5163         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5164         (backtrace_command_1): Add frame_print_options and
5165         backtrace_cmd_options parameters and use them.
5166         (make_backtrace_options_def_group): New.
5167         (backtrace_command): Process command options with
5168         gdb::option::process_options.
5169         (backtrace_command_completer): New.
5170         (_initialize_stack): Extend "backtrace"'s help to mention
5171         supported options.  Install completer for "backtrace".
5172         Install some settings commands with add_setshow_cmds_for_options.
5173
5174 2019-06-13  Pedro Alves  <palves@redhat.com>
5175
5176         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5177         and that "set/show print raw frame-arguments" are now deprecated.
5178
5179         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5180         command.
5181         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5182         * stack.c (_initialize_stack): Install "set/show print
5183         raw-frame-arguments", and deprecate "set/show print raw
5184         frame-arguments".
5185         * valprint.c (_initialize_valprint): Deprecate "set/show print
5186         raw".
5187
5188 2019-06-13  Pedro Alves  <palves@redhat.com>
5189
5190         * compile/compile.c (struct compile_options): New.
5191         (compile_flag_option_def, compile_command_option_defs)
5192         (make_compile_options_def_group): New.
5193         (compile_file_command): Handle options with
5194         gdb::option::process_options.
5195         (compile_file_command_completer): New function.
5196         (compile_code_command): Handle options with
5197         gdb::option::process_options.
5198         (compile_code_command_completer): New function.
5199         (_initialize_compiler): Install completers for "compile code" and
5200         "compile file".  Mention available options in "compile code" and
5201         "compile code"'s help.
5202         * completer.c (advance_to_completion_word): New, factored out from
5203         ...
5204         (advance_to_expression_complete_word_point): ... this.
5205         (advance_to_filename_complete_word_point): New.
5206         * completer.h (advance_to_filename_complete_word_point): New
5207         declaration.
5208
5209 2019-06-13  Pedro Alves  <palves@redhat.com>
5210
5211         * compile/compile.c: Include "cli/cli-option.h".
5212         (compile_print_value): Scope data pointer is now a
5213         value_print_options pointer; adjust.
5214         (compile_print_command): Process options.  Scope data pointer is
5215         now a value_print_options pointer; adjust.
5216         (_initialize_compile): Update "compile print"'s help to include
5217         supported options.  Install a completer for "compile print".
5218         * cp-valprint.c (show_vtblprint, show_objectprint)
5219         (show_static_field_print): Delete.
5220         (_initialize_cp_valprint): Don't install "set print
5221         static-members", "set print vtbl", "set print object" here.
5222         * printcmd.c: Include "cli/cli-option.h" and
5223         "common/gdb_optional.h".
5224         (print_command_parse_format): Rework to fill in a
5225         value_print_options instead of a format_data.
5226         (print_value): Change parameter type from format_data pointer to
5227         value_print_options reference.  Adjust.
5228         (print_command_1): Process options.  Adjust to pass down a
5229         value_print_options.
5230         (print_command_completer): New.
5231         (_initialize_printcmd): Install print_command_completer as
5232         handle_brkchars completer for the "print" command.  Update
5233         "print"'s help to include supported options.
5234         * valprint.c: Include "cli/cli-option.h".
5235         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5236         here from cp-valprint.c.
5237         (boolean_option_def, uinteger_option_def)
5238         (value_print_option_defs, make_value_print_options_def_group):
5239         New.  Use gdb::option::add_setshow_cmds_for_options to install
5240         "set print elements", "set print null-stop", "set print repeats",
5241         "set print pretty", "set print union", "set print array", "set
5242         print address", "set print symbol", "set print array-indexes".
5243         * valprint.h: Include <string> and "cli/cli-option.h".
5244         (make_value_print_options_def_group): Declare.
5245         (print_value): Change parameter type from format_data pointer to
5246         value_print_options reference.
5247         (print_command_completer): Declare.
5248
5249 2019-06-13  Pedro Alves  <palves@redhat.com>
5250
5251         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5252         (COMMON_SFILES): Add maint-test-settings.c.
5253         * cli/cli-decode.c (boolean_enums): New global, factored out from
5254         ...
5255         (add_setshow_boolean_cmd): ... here.
5256         * cli/cli-decode.h (boolean_enums): Declare.
5257         * cli/cli-option.c: New file.
5258         * cli/cli-option.h: New file.
5259         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5260         factored out from ...
5261         (parse_cli_boolean_value(const char *)): ... this.
5262         (is_unlimited_literal): Change parameter type to pointer to
5263         pointer.  Adjust and advance ARG pointer.
5264         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5265         (parse_cli_var_enum): New, factored out from ...
5266         (do_set_command): ... this.  Adjust.
5267         * cli/cli-setshow.h (parse_cli_boolean_value)
5268         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5269         (parse_cli_var_enum): Declare.
5270         * cli/cli-utils.c: Include "cli/cli-option.h".
5271         (get_ulongest): New.
5272         * cli/cli-utils.h (get_ulongest): Declare.
5273         (check_for_argument): New overloads.
5274         * maint-test-options.c: New file.
5275
5276 2019-06-13  Pedro Alves  <palves@redhat.com>
5277
5278         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5279         parse a range if "-" is at the end of the string.
5280
5281 2019-06-13  Pedro Alves  <palves@redhat.com>
5282
5283         * cli/cli-setshow.c (parse_auto_binary_operation)
5284         (parse_cli_boolean_value): Don't allow "o".
5285
5286 2019-06-13  Pedro Alves  <palves@redhat.com>
5287
5288         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5289         * NEWS: Mention maint test-settings KIND.
5290         * maint-test-settings.c: New file.
5291
5292 2019-06-13  Pedro Alves  <palves@redhat.com>
5293
5294         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5295         completer.
5296         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5297         "set" completers.
5298
5299 2019-06-13  Pedro Alves  <palves@redhat.com>
5300
5301         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5302         after item.
5303
5304 2019-06-13  Pedro Alves  <palves@redhat.com>
5305
5306         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5307
5308 2019-06-13  Pedro Alves <palves@redhat.com>
5309
5310         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5311         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5312         call.
5313         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5314         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5315         calls.
5316         (check_for_argument): Skip spaces after argument.
5317
5318 2019-06-13  Pedro Alves  <palves@redhat.com>
5319
5320         * thread.c (thread_apply_command): Adjust TID parsing.
5321         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5322         detected before end of string.
5323         (tid_is_in_list): Error out if LIST is invalid.
5324
5325 2019-06-13  Pedro Alves  <palves@redhat.com>
5326
5327         * completer.c (complete_line_internal_1): Rewind completion word
5328         point.
5329         (completion_tracker::advance_custom_word_point_by): Change
5330         parameter type to int.
5331         * completer.h (completion_tracker::advance_custom_word_point_by):
5332         Likewise.
5333
5334 2019-06-13  Pedro Alves  <palves@redhat.com>
5335
5336         * completer.c (advance_to_completion_word): Handle delimiters.
5337
5338 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5339
5340         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5341
5342 2019-06-11  Tom Tromey  <tom@tromey.com>
5343
5344         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5345         (xmalloc_failed): Move to alloc.c.
5346         * alloc.c: New file.
5347         * Makefile.in (COMMON_SFILES): Add alloc.c.
5348
5349 2019-06-11  Tom Tromey  <tom@tromey.com>
5350
5351         * nat/linux-waitpid.c: Don't include server.h.
5352         (linux_debug): Remove.
5353         (my_waitpid): Update.
5354
5355 2019-06-11  Tom Tromey  <tromey@adacore.com>
5356
5357         * infcall.c (_initialize_infcall): Remove trailing newline from
5358         help.
5359         * user-regs.c (_initialize_user_regs): Remove trailing newline
5360         from help.
5361         * typeprint.c (_initialize_typeprint): Remove trailing newline
5362         from help.
5363         * reverse.c (_initialize_reverse): Remove trailing newlines from
5364         help.
5365         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5366         from help.
5367         * language.c (add_set_language_command): Remove trailing newline
5368         from help.
5369         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5370         help.
5371         * disasm.c (_initialize_disasm): Remove trailing newline from
5372         help.
5373         * top.c (init_main): Remove trailing newline from help.
5374         * interps.c (_initialize_interpreter): Remove trailing newline
5375         from help.
5376         * btrace.c (_initialize_btrace): Remove trailing newlines from
5377         help.
5378         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5379         from help.
5380         * python/python.c (_initialize_python): Remove trailing newline
5381         from help.
5382         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5383         help.
5384         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5385         from help.  Reformat some text.
5386         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5387         from help.
5388         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5389         newline from help.
5390
5391 2019-06-11  Tom Tromey  <tromey@adacore.com>
5392
5393         * darwin-nat.c (darwin_decode_exception_message)
5394         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5395
5396 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * valops.c (value_slice): Check for not allocated or not
5399         associated values.
5400
5401 2019-06-10  Tom de Vries  <tdevries@suse.de>
5402
5403         PR gdb/24618
5404         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5405         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5406         invalid.
5407
5408 2019-06-10  Tom de Vries  <tdevries@suse.de>
5409
5410         PR gdb/24611
5411         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5412         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5413
5414 2019-06-10  Tom de Vries  <tdevries@suse.de>
5415
5416         PR symtab/24545
5417         * symtab.c (struct demangled_name_entry): Add language field.
5418         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5419         static minimal symbol".  Set and use language field.
5420
5421 2019-06-10  Tom Tromey  <tromey@adacore.com>
5422
5423         * ada-lang.c (_initialize_ada_language): Update help text.
5424
5425 2019-06-10  Tom Tromey  <tromey@adacore.com>
5426
5427         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5428         with a newline.
5429         * guile/guile.c (handle_boot_error): Don't end warning with a
5430         newline.
5431         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5432         warning with a newline.
5433         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5434         newline.
5435         (s12z_frame_cache): Likewise.
5436         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5437         a newline.
5438         * solib-svr4.c (disable_probes_interface): Don't end warning with
5439         a newline.
5440         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5441         newline.
5442         * python/python.c (do_finish_initialization): Don't end warning
5443         with a newline.
5444
5445 2019-06-10  Tom Tromey  <tom@tromey.com>
5446
5447         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5448         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5449         gdbpy_enter.
5450
5451 2019-06-10  Tom Tromey  <tromey@adacore.com>
5452
5453         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5454         data.
5455         (elf_new_init): Don't call stabsread_new_init.
5456         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5457         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5458         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5459
5460 2019-06-10  Tom de Vries  <tdevries@suse.de>
5461
5462         PR symtab/16264
5463         PR symtab/24517
5464         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5465
5466 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5467
5468         * source.c (find_and_open_source): Also rewrite relative file
5469         names.
5470
5471 2019-04-26  Amos Bird  <amosbird@gmail.com>
5472
5473         * annotate.c (annotate_thread_exited): Add "thread-exited"
5474         annotation.
5475
5476 2019-06-06  Tom Tromey  <tromey@adacore.com>
5477
5478         * maint.h (class scoped_command_stats): Use
5479         DISABLE_COPY_AND_ASSIGN.
5480         <print_time>: New method.
5481         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5482         print_time.
5483         (scoped_command_stats::print_time): New method.
5484
5485 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5486
5487         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5488         instructions of lengths 6 or 8 bytes.
5489
5490 2019-06-04  Pedro Alves  <palves@redhat.com>
5491
5492         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5493
5494         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5495         * breakpoint.c (condition_completer): Likewise.
5496         * cli/cli-dump.c (scan_expression): Likewise.
5497         * common/filestuff.c (mkdir_recursive): Likewise.
5498         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5499         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5500         (gdb_abspath): Likewise.
5501         * compile/compile-cplus-types.c
5502         (compile_cplus_instance::decl_name): Likewise.
5503         * completer.c (complete_explicit_location):
5504         (signal_completer, reg_or_group_completer_1): Likewise.
5505         * cp-support.c (cp_remove_params_if_any): Likewise.
5506         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5507         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5508         * infcmd.c (strip_bg_char): Likewise.
5509         * linespec.c (copy_token_string): Likewise.
5510         * mi/mi-main.c (output_cores): Likewise.
5511         * psymtab.c (psymtab_search_name):
5512         * symfile.c (test_set_ext_lang_command): Likewise.
5513         * target.c (target_fileio_read_stralloc): Likewise.
5514         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5515         * value.c (complete_internalvar): Likewise.
5516
5517 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5518
5519         Add objfile property to gdb.Type.
5520         * NEWS: Mention Python API addition.
5521         * python/py-type.c (typy_get_objfile): New method.
5522
5523 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5524
5525         * NEWS: Mention the new set|show style [title|highlight].
5526         Mention changes to "show style", "help" and "apropos".
5527
5528 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5529
5530         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5531         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5532         instead of print_help_for_command.
5533         (print_doc_of_command): New function.
5534         (help_list): Add 'apropos -v word' suggestion.
5535         (print_help_for_command): Style the command name using title style.
5536         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5537         (_initialize_cli_cmds): Describe -v in apropos_command help.
5538
5539 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5540
5541         * cli/cli-style.h (cli_style_option): Add name in constructor,
5542         add m_name class member, add constructor with intensity,
5543         add name class function.
5544         (cli_style_option::add_setshow_commands): Remove name argument.
5545         (highlight_style, title_style): New styles.
5546         * cli/cli-style.c (do_show): New function that shows a style
5547         characteristic styling the style name with itself.
5548         (set_style_name): New function.
5549         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5550         Update all callers according to the changes in cli/cli-style.h.
5551         * utils.h (fputs_highlighted): New function.
5552         * utils.c (fputs_highlighted): Likewise.
5553
5554 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5555
5556         * NEWS: Mention new pipe command and new convenience variables.
5557
5558 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5559
5560         * cli/cli-cmds.c (pipe_command): New function.
5561         (_initialize_cli_cmds): Call add_com for pipe_command.
5562         Define | as an alias for pipe.
5563         (exit_status_set_internal_vars): New function.
5564         (shell_escape): Call exit_status_set_internal_vars.
5565         cli/cli-decode.c (find_command_name_length): Recognize | as
5566         a single character command.
5567
5568 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5569
5570         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5571         top.c (execute_command_to_ui_file): New function, mostly a copy
5572         of execute_command_to_string.
5573         (execute_command_to_string): Implement by calling
5574         execute_command_to_ui_file.
5575
5576 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5577
5578         * top.h (saved_command_line): Remove declaration.
5579         * top.c (previous_saved_command_line, previous_repeat_arguments):
5580         New variables.
5581         (saved_command_line): Make static, define together with other
5582         'repeat variables'.
5583         (dont_repeat): Clear repeat_arguments.
5584         (repeat_previous, get_saved_command_line, save_command_line):
5585         New functions.
5586         (gdb_init): Initialize saved_command_line
5587         and previous_saved_command_line.
5588         * main.c (captured_main_1): Remove saved_command_line initialization.
5589         * event-top.c (handle_line_of_input): Update to use
5590         the new 'repeat' related functions instead of direct access to
5591         saved_command_line.
5592         * command.h (repeat_previous, get_saved_command_line,
5593         save_command_line): New declarations.
5594         (dont_repeat): Add comment.
5595
5596 2019-05-30  Tom Tromey  <tromey@adacore.com>
5597
5598         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5599         Fix comment.
5600         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5601
5602 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5603
5604         PR cli/24587
5605         * completer.c (complete): Initialize variable word.
5606
5607 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5608
5609         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5610         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5611         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5612         'body' is NULL to the outter 'if', protecting the '!is_define'
5613         situation as well.
5614
5615 2019-05-29  Tom Tromey  <tromey@adacore.com>
5616
5617         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5618         (dwarf_unknown): New function.
5619         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5620         (dwarf_type_encoding_name): Use dwarf_unknown.
5621
5622 2019-05-29  Tom Tromey  <tromey@adacore.com>
5623
5624         PR c++/20020:
5625         * cp-valprint.c (cp_print_value_fields): Call
5626         cp_print_static_field inside "try".
5627
5628 2019-05-29  Tom Tromey  <tromey@adacore.com>
5629
5630         * inflow.c (struct terminal_info): Add default operator=.
5631         * configure: Rebuild.
5632         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5633         -Wdeprecated-copy-dtor, -Wredundant-move.
5634
5635 2019-05-29  Tom Tromey  <tromey@adacore.com>
5636
5637         * NEWS: Add entry.
5638         * infcmd.c (print_return_value_1): Handle finish_print
5639         option.
5640         (show_print_finish): New function.
5641         (_initialize_infcmd): Add "set/show print finish" commands.
5642         * valprint.c (user_print_options): Initialize new member.
5643         * valprint.h (struct value_print_options) <finish_print>: New
5644         member.
5645
5646 2019-05-28  Tom Tromey  <tromey@adacore.com>
5647
5648         * ada-lang.c (ada_remove_Xbn_suffix)
5649         (find_old_style_renaming_symbol)
5650         (parse_old_style_renaming): Remove.
5651         (ada_find_renaming_symbol): Don't call
5652         find_old_style_renaming_symbol.
5653         (ada_is_renaming_symbol): Rename from
5654         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5655         bool.  Now static.
5656         (ada_read_var_value): Update and simplify.
5657         * ada-exp.y (write_var_or_type): Remove old code.
5658
5659 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5660
5661         * event-top.c: Remove include comment.
5662         * inflow.c (class scoped_ignore_sigttou): Move from here...
5663         * inflow.h (class scoped_ignore_sigttou): ...to here.
5664         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5665         * top.c:  Remove include comment.
5666
5667 2019-05-27  Tom Tromey  <tom@tromey.com>
5668
5669         * NEWS: Fix typo.
5670
5671 2019-05-22  Tom Tromey  <tromey@adacore.com>
5672
5673         * target.c (target_follow_exec): Constify parameter.
5674         * target-delegates.c: Rebuild.
5675         * remote.c (remote_target::follow_exec): Constify parameter.
5676         * infrun.c (follow_exec): Constify parameter.
5677         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5678         (target_follow_exec): Likewise.
5679
5680 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5681
5682         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5683         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5684
5685 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5686
5687         * NEWS: Add debugredirect and testsuite sections.
5688
5689 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5690
5691         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5692         target descriptions using exclusively floating point register name
5693         aliases.
5694
5695 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         PR gdb/18644:
5698         * f-lang.c (build_fortran_types): Handle the case where
5699         gdbarch_floatformat_for_type returns a nullptr.
5700
5701 2019-05-21  Tom de Vries  <tdevries@suse.de>
5702
5703         PR cli/24587
5704         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5705
5706 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         PR gdb/18644:
5709         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5710         16-byte floats.
5711         * i386-tdep.c (i386_floatformat_for_type): Use
5712         floatformats_ia64_quad for the 16-byte floating point component
5713         within a fortran 32-byte complex number.
5714
5715 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5718         delete default constructor.
5719         (find_partial_die): Update to return const struct.
5720         (partial_die_parent_scope): Move variable declaration into scope
5721         of its use and change its type to auto.
5722         (guess_partial_die_structure_name): Likewise.
5723         (partial_die_info::fixup): Likewise.
5724
5725 2019-05-17  Tom Tromey  <tromey@adacore.com>
5726
5727         * source.c (find_and_open_source): Remove cast.
5728
5729 2019-05-17  Tom Tromey  <tromey@adacore.com>
5730
5731         * annotate.c (annotate_source): Make "filename" const.
5732         * annotate.h (annotate_source): Use const.
5733
5734 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5735
5736         * disasm.c (set_disassembler_options): Send errors to stderr.
5737
5738 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5739
5740         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5741         (cli_interp_base::set_logging): Check debug_redirect.
5742         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5743         * cli/cli-logging.c (debug_redirect): Add static variable.
5744         (pop_output_files): Add default param.
5745         (handle_redirections): Print debug setting.
5746         (show_logging_command): Likewise.
5747         (_initialize_cli_logging): Add debugredirect command.
5748         * interps.c (current_interp_set_logging): Add debug_redirect
5749         parameter.
5750         * interps.h (set_logging): Add debug_redirect parameter.
5751         (current_interp_set_logging): Likewise.
5752         * mi/mi-common.h: Likewise.
5753         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5754
5755 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5756             Tom Tromey  <tromey@adacore.com>
5757
5758         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5759         directly.
5760         * cli/cli-interp.h (make_logging_output): Remove declaration.
5761         * cli/cli-logging.c (make_logging_output): Remove function.
5762         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5763         directly.
5764         * ui-file.c (tee_file::tee_file): Remove bools.
5765         (tee_file::~tee_file): Remove deletes.
5766         * ui-file.h (tee_file): Remove bools.
5767
5768 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5769
5770         * mi/mi-cmds.h (mi_cmd_complete): New function.
5771         * mi/mi-main.c (mi_cmd_complete): Likewise.
5772         * mi/mi-cmds.c: Define new MI command -complete.
5773         * NEWS: Mention new -complete command.
5774
5775 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5776
5777         * completer.h (complete): New function.
5778         * completer.c (complete): Likewise.
5779         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5780         function defined in completer.h.
5781
5782 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5783
5784         * MAINTAINERS (Write After Approval): Add myself.
5785
5786 2019-05-17  Tom de Vries  <tdevries@suse.de>
5787
5788         PR gdb/24094
5789         * dwarf2read.c (struct cu_partial_die_info): New struct.
5790         (find_partial_die): Return cu_partial_die_info.
5791         (partial_die_parent_scope, guess_partial_die_structure_name)
5792         (partial_die_info::fixup): Handle new return type of find_partial_die.
5793
5794 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5795
5796         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5797         "std::string", simplifying the algorithm.
5798
5799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5800
5801         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5802         (stap_static_probe_ops::get_probes): Likewise.
5803
5804 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5805
5806         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5807         '-')" and "else if".
5808         (stap_parse_single_operand): Join checks for
5809         "gdbarch_stap_parse_special_token_p" and
5810         "gdbarch_stap_parse_special_token" in the same "if" statement.
5811         Invert check when verifying for operation on register
5812         displacement.
5813
5814 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5815
5816         * stap-probe.c (stap_get_opcode): Update comment.
5817         (stap_get_expected_argument_type): Likewise.
5818         (handle_stap_probe): Likewise.
5819
5820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5821
5822         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5823         return type to 'bool'.  Adjust comment.  Use 'bool' when
5824         appropriate.
5825         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5826         * stap-probe.c (stap_parse_argument_1): Likewise.
5827         (stap_is_operator): Likewise.
5828         (stap_is_generic_prefix): Likewise.
5829         (stap_is_register_prefix): Likewise.
5830         (stap_is_register_indirection_prefix): Likewise.
5831         (stap_is_integer_prefix): Likewise.
5832         (stap_generic_check_suffix): Likewise.
5833         (stap_check_integer_suffix): Likewise.
5834         (stap_check_register_suffix): Likewise.
5835         (stap_check_register_indirection_suffix): Likewise.
5836         (stap_parse_register_operand): Likewise.
5837         (stap_parse_single_operand): Likewise.
5838         (stap_parse_argument_1): Likewise.
5839         (stap_probe::get_argument_count): Likewise.
5840         (stap_is_operator): Likewise.
5841
5842 2019-05-16  Tom Tromey  <tromey@adacore.com>
5843
5844         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5845         keyword to foreach.
5846
5847 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5848
5849         * linux-thread-db.c (try_thread_db_load_1): Change return type
5850         to bool.
5851         (try_thread_db_load): Likewise.
5852         (try_thread_db_load_from_pdir_1): Likewise.
5853         (try_thread_db_load_from_pdir): Likewise.
5854         (try_thread_db_load_from_sdir): Likewise.
5855         (try_thread_db_load_from_dir): Likewise.
5856         (thread_db_load_search): Likewise.
5857         (has_libpthread): Likewise.
5858         (thread_db_load): Likewise.
5859
5860 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5861
5862         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5863         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5864         NULL, and complain/return if that's the case.
5865
5866 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5867
5868         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5869         (advance, posn, abstract_read_memory): New functions.
5870         [struct mem_read_abstraction]: New struct.
5871         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5872
5873 2019-05-14  Tom Tromey  <tromey@adacore.com>
5874
5875         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5876         value is not lval_memory.
5877
5878 2019-05-14  Tom Tromey  <tromey@adacore.com>
5879
5880         * solib.c (info_sharedlibrary_command): Style the file name.
5881
5882 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5883
5884         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5885         (aarch64_vnv_type): Likewise.
5886         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5887         * common/tdesc.c: Likewise.
5888         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5889         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5890         * features/aarch64-fpu.xml: Add ieee half view.
5891         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5892         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5893         * gdbtypes.h (struct builtin_type): Likewise.
5894         (struct objfile_type): Likewise.
5895
5896 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5897
5898         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5899         typo.
5900         * location.h (string_to_event_location): Likewise.
5901
5902 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5903
5904         GDB 8.3 released.
5905
5906 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5907
5908         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5909         New variable declaration.
5910         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5911         New variable.
5912         (print_one_breakpoint): Use ui_out::test_flags and new global
5913         variable to compute use_fixed_output.
5914         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5915         Remove.
5916         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5917         (mi_multi_location_breakpoint_output_fixed): Remove.
5918         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5919         new variable.
5920         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5921         fix_multi_location_breakpoint_output flag if version >= 3.
5922         * ui-out.h (enum ui_out_flag)
5923         <fix_multi_location_breakpoint_output>: New enumerator.
5924
5925 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5926
5927         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5928
5929 2019-05-10  Tom Tromey  <tromey@adacore.com>
5930
5931         * ada-lang.c (catch_ada_completer): New function.
5932         (_initialize_ada_language): Use it.
5933
5934 2019-05-10  Tom Tromey  <tromey@adacore.com>
5935
5936         * thread.c (print_thread_info): Make "requested_threads" const.
5937         * gdbthread.h (print_thread_info): Make "requested_threads"
5938         const.
5939         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5940         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5941
5942 2019-05-08  Tom Tromey  <tom@tromey.com>
5943
5944         * gdbtypes.c (objfile_type_data): Change type.
5945         (objfile_type, _initialize_gdbtypes): Update.
5946
5947 2019-05-08  Tom Tromey  <tom@tromey.com>
5948
5949         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5950         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5951         (_initialize_dwarf2_frame): Update.
5952
5953 2019-05-08  Tom Tromey  <tom@tromey.com>
5954
5955         * objc-lang.c (objc_objfile_data): Change type.
5956         (find_methods): Update.
5957         (_initialize_objc_lang): Remove.
5958
5959 2019-05-08  Tom Tromey  <tom@tromey.com>
5960
5961         * stabsread.c (rs6000_builtin_type_data): Change type.
5962         (rs6000_builtin_type, _initialize_stabsread): Update.
5963
5964 2019-05-08  Tom Tromey  <tom@tromey.com>
5965
5966         * mips-tdep.c (mips_pdr_data): Remove.
5967         (_initialize_mips_tdep): Update.
5968
5969 2019-05-08  Tom Tromey  <tom@tromey.com>
5970
5971         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5972         (hppa_init_objfile_priv_data, read_unwind_info)
5973         (find_unwind_entry, _initialize_hppa_tdep): Update.
5974
5975 2019-05-08  Tom Tromey  <tom@tromey.com>
5976
5977         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5978         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5979         on obstack.
5980         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5981
5982 2019-05-08  Tom Tromey  <tom@tromey.com>
5983
5984         * mdebugread.c (basic_type_data): Change type.
5985         (basic_type, _initialize_mdebugread): Update.
5986
5987 2019-05-08  Tom Tromey  <tom@tromey.com>
5988
5989         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5990
5991 2019-05-08  Tom Tromey  <tom@tromey.com>
5992
5993         * nto-tdep.c (nto_inferior_data_reg): Change type.
5994         (nto_inferior_data): Update.
5995         (nto_inferior_data_cleanup, nto_new_inferior_data)
5996         (_initialize_nto_tdep): Remove.
5997         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5998
5999 2019-05-08  Tom Tromey  <tom@tromey.com>
6000
6001         * ada-lang.c (struct ada_inferior_data): Add initializers.
6002         (ada_inferior_data): Change type.
6003         (ada_inferior_data_cleanup): Remove.
6004         (get_ada_inferior_data, ada_inferior_exit)
6005         (struct ada_pspace_data): Add initializers, destructor.
6006         (ada_pspace_data_handle): Change type.
6007         (get_ada_pspace_data): Update.
6008         (ada_pspace_data_cleanup): Remove.
6009
6010 2019-05-08  Tom Tromey  <tom@tromey.com>
6011
6012         * coffread.c (struct coff_symfile_info): Add initializers.
6013         (coff_objfile_data_key): Move lower.  Change type.
6014         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6015         Update.
6016         (coff_free_info): Remove.
6017
6018 2019-05-08  Tom Tromey  <tom@tromey.com>
6019
6020         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6021         (fbsd_pspace_data_handle): Move lower.  Change type.
6022         (get_fbsd_pspace_data): Update.
6023         (fbsd_pspace_data_cleanup): Remove.
6024         (_initialize_fbsd_tdep): Update.
6025
6026 2019-05-08  Tom Tromey  <tom@tromey.com>
6027
6028         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6029         (get_ada_tasks_pspace_data): Update.
6030         (ada_tasks_pspace_data_cleanup): Remove.
6031         (_initialize_tasks): Update.
6032         (ada_tasks_inferior_data_handle): Change type.
6033         (get_ada_tasks_inferior_data): Update.
6034         (ada_tasks_inferior_data_cleanup): Remove.
6035         (struct ada_tasks_pspace_data): Add initializers.
6036
6037 2019-05-08  Tom Tromey  <tom@tromey.com>
6038
6039         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6040         * symfile-debug.c (debug_sym_get_probes): Change type.
6041         * stap-probe.c (handle_stap_probe):
6042         (stap_static_probe_ops::get_probes): Change type.
6043         * probe.h (class static_probe_ops) <get_probes>: Change type.
6044         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6045         (parse_probes_in_pspace): Update.
6046         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6047         Update.
6048         (any_static_probe_ops::get_probes): Change type.
6049         * elfread.c (elfread_data): New typedef.
6050         (probe_key): Change type.
6051         (elf_get_probes): Likewise.  Update.
6052         (probe_key_free): Remove.
6053         (_initialize_elfread): Update.
6054         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6055         Change type.
6056         (dtrace_process_dof_probe, dtrace_process_dof)
6057         (dtrace_static_probe_ops::get_probe): Change type.
6058
6059 2019-05-08  Tom Tromey  <tom@tromey.com>
6060
6061         * xcoffread.c (struct xcoff_symfile_info): Rename from
6062         coff_symfile_info.  Add initializers.
6063         (xcoff_objfile_data_key): Move lower.  Change type.
6064         (XCOFF_DATA): Rewrite.
6065         (xcoff_free_info): Remove.
6066         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6067         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6068         (xcoff_initial_scan): Update.
6069
6070 2019-05-08  Tom Tromey  <tom@tromey.com>
6071
6072         * solib-svr4.c (struct svr4_info): Add initializers and
6073         destructor.
6074         <probes_table>: Now an htab_up.
6075         (solib_svr4_pspace_data): Change type.
6076         (free_probes_table): Simplify.
6077         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6078         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6079         (probes_table_remove_objfile_probes, register_solib_event_probe)
6080         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6081         (_initialize_svr4_solib): Update.
6082
6083 2019-05-08  Tom Tromey  <tom@tromey.com>
6084
6085         * remote.c (remote_pspace_data): Change type.
6086         (remote_pspace_data_cleanup): Remove.
6087         (get_remote_exec_file, set_pspace_remote_exec_file)
6088         (_initialize_remote): Update.
6089
6090 2019-05-08  Tom Tromey  <tom@tromey.com>
6091
6092         * breakpoint.c (breakpoint_objfile_key): Change type.
6093         (get_breakpoint_objfile_data): Update.
6094         (free_breakpoint_objfile_data): Remove.
6095         (_initialize_breakpoint): Update.
6096
6097 2019-05-08  Tom Tromey  <tom@tromey.com>
6098
6099         * linux-tdep.c (struct linux_info): Add initializers.
6100         (linux_inferior_data): Move.  Change type.
6101         (invalidate_linux_cache_inf): Update.
6102         (linux_inferior_data_cleanup): Remove.
6103         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6104
6105 2019-05-08  Tom Tromey  <tom@tromey.com>
6106
6107         * auxv.c (auxv_inferior_data): Move.  Change type.
6108         (auxv_inferior_data_cleanup): Remove.
6109         (invalidate_auxv_cache_inf): Rewrite.
6110         (get_auxv_inferior_data, _initialize_auxv): Update.
6111
6112 2019-05-08  Tom Tromey  <tom@tromey.com>
6113
6114         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6115         (symfile_debug_objfile_data_key): Change type.
6116         (symfile_debug_installed, debug_qf_has_symbols)
6117         (debug_qf_find_last_source_symtab)
6118         (debug_qf_forget_cached_source_info)
6119         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6120         (debug_qf_print_stats, debug_qf_dump)
6121         (debug_qf_expand_symtabs_for_function)
6122         (debug_qf_expand_all_symtabs)
6123         (debug_qf_expand_symtabs_with_fullname)
6124         (debug_qf_map_matching_symbols)
6125         (debug_qf_expand_symtabs_matching)
6126         (debug_qf_find_pc_sect_compunit_symtab)
6127         (debug_qf_map_symbol_filenames)
6128         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6129         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6130         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6131         (debug_sym_read_linetable, debug_sym_relocate): Update.
6132         (symfile_debug_free_objfile): Remove.
6133         (install_symfile_debug_logging, _initialize_symfile_debug):
6134         Update.
6135
6136 2019-05-08  Tom Tromey  <tom@tromey.com>
6137
6138         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6139         allocate_on_obstack.
6140         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6141         (get_dwarf2_per_objfile): Update.
6142         (set_dwarf2_per_objfile): Remove.
6143         (dwarf2_has_info, dwarf2_get_section_info): Update.
6144         (dwarf2_free_objfile): Remove.
6145         (_initialize_dwarf2_read): Update.
6146
6147 2019-05-08  Tom Tromey  <tom@tromey.com>
6148
6149         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6150         initializers.
6151         <unsupported_script_warning_printed,
6152         script_not_found_warning_printed>: Now bool.
6153         (auto_load_pspace_data): Change type.
6154         (~auto_load_pspace_info): Rename from
6155         auto_load_pspace_data_cleanup.
6156         (get_auto_load_pspace_data, init_loaded_scripts_info)
6157         (clear_section_scripts, maybe_print_unsupported_script_warning)
6158         (maybe_print_script_not_found_warning, _initialize_auto_load):
6159         Update.
6160
6161 2019-05-08  Tom Tromey  <tom@tromey.com>
6162
6163         * objfiles.c (objfile_pspace_info): Add destructor and
6164         initializers.
6165         (objfiles_pspace_data): Change type.
6166         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6167         (get_objfile_pspace_data): Update.
6168         (objfiles_bfd_data): Change type.
6169         (get_objfile_bfd_data): Update.
6170         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6171
6172 2019-05-08  Tom Tromey  <tom@tromey.com>
6173
6174         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6175         Change type.
6176         (get_catch_syscall_inferior_data): Update.
6177         (catch_syscall_inferior_data_cleanup): Remove.
6178         (_initialize_break_catch_syscall): Update.
6179
6180 2019-05-08  Tom Tromey  <tom@tromey.com>
6181
6182         * inflow.c (struct terminal_info): Add destructor and
6183         initializers.
6184         (inflow_inferior_data): Change type.
6185         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6186         (get_inflow_inferior_data, inflow_inferior_exit)
6187         (swap_terminal_info, _initialize_inflow): Update.
6188
6189 2019-05-08  Tom Tromey  <tom@tromey.com>
6190
6191         * target-dcache.c (target_dcache_cleanup): Remove.
6192         (target_dcache_aspace_key): Change type.
6193         (target_dcache_init_p, target_dcache_invalidate)
6194         (target_dcache_get, target_dcache_get_or_init)
6195         (_initialize_target_dcache): Update.
6196         * dcache.h (struct dcache_deleter): New.
6197
6198 2019-05-08  Tom Tromey  <tom@tromey.com>
6199
6200         * symtab.c (struct symbol_cache): Add destructor and
6201         initializers.
6202         (symbol_cache_key): Move.  Change type.
6203         (make_symbol_cache, free_symbol_cache): Remove.
6204         (get_symbol_cache): Update.
6205         (symbol_cache_cleanup): Remove.
6206         (ALL_PSPACES, symbol_cache_flush)
6207         (maintenance_print_symbol_cache)
6208         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6209         Update.
6210
6211 2019-05-08  Tom Tromey  <tom@tromey.com>
6212
6213         * symtab.c (struct main_info): Add destructor and initializers.
6214         (main_progspace_key): Move.  Change type.
6215         (get_main_info): Update.
6216         (main_info_cleanup): Remove.
6217         (_initialize_symtab): Update.
6218
6219 2019-05-08  Tom Tromey  <tom@tromey.com>
6220
6221         * registry.h (DECLARE_REGISTRY): Define the _key class.
6222
6223 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * NEWS: Merge two 'New commands' sections.
6226
6227 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6228
6229         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6230         parameter and use Ada language definition instead.
6231         (ada_val_print_ptr): Remove unused language parameter.
6232         (ada_val_print_num): Remove language parameter and use Ada language
6233         definition instead.
6234         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6235         parameter.
6236         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6237         parameter and use Ada language definition instead.
6238         (ada_val_print_1): Update all ada_val_print_xxx calls.
6239         Remove language parameter.
6240         (ada_val_print): Update ada_val_print_1 call.
6241
6242 2019-05-08  Tom Tromey  <tromey@adacore.com>
6243
6244         * remote.c (remote_hw_watchpoint_limit)
6245         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6246         Now static.
6247
6248 2019-05-08  Tom Tromey  <tromey@adacore.com>
6249
6250         * maint.c (_initialize_maint_cmds): Move initialization code to
6251         remote.c.
6252         (watchdog, show_watchdog): Move to remote.c.
6253         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6254         "watchdog" static.
6255         (_initialize_remote): Move initialization code from maint.c.
6256         * defs.h (watchdog): Don't declare.
6257
6258 2019-05-08  Tom Tromey  <tromey@adacore.com>
6259
6260         * tui/tui-interp.c: Include main.h.
6261         * interps.c: Include main.h.
6262         * main.h (interpreter_p): Declare.
6263         * defs.h (interpreter_p): Don't declare.
6264
6265 2019-05-08  Tom Tromey  <tromey@adacore.com>
6266
6267         * dwarf2loc.c: Include dwarf2read.h.
6268         * defs.h (read_unsigned_leb128): Don't declare.
6269         * dwarf2read.h (read_unsigned_leb128): Declare.
6270
6271 2019-05-08  Tom Tromey  <tromey@adacore.com>
6272
6273         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6274         method.
6275
6276 2019-05-08  Tom Tromey  <tromey@adacore.com>
6277
6278         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6279         when no wrap column is set.
6280
6281 2019-05-08  Tom Tromey  <tromey@adacore.com>
6282
6283         * c-lang.c (c_get_string): Handle non-C-style arrays.
6284
6285 2019-05-08  Tom Tromey  <tromey@adacore.com>
6286
6287         * typeprint.c (print_offset_data::update): Print the bit offset,
6288         not the number of bits remaining.
6289
6290 2019-05-08  Tom Tromey  <tromey@adacore.com>
6291
6292         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6293         padding at end of comment.
6294
6295 2019-05-08  Tom Tromey  <tromey@adacore.com>
6296
6297         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6298         Compare main types.
6299
6300 2019-05-06  Tom Tromey  <tom@tromey.com>
6301
6302         * common/scoped_mmap.c: Include common-defs.h.
6303         * common/scoped_mmap.h: Don't include config.h.
6304
6305 2019-05-04  Tom Tromey  <tom@tromey.com>
6306
6307         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6308         (struct aarch64_call_info): Add initializers.
6309         <si>: Now a std::vector.
6310         (pass_on_stack, aarch64_push_dummy_call): Update.
6311
6312 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6313             Tom Tromey  <tom@tromey.com>
6314
6315         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6316         (ppc_threads): Now a std::vector.  Now static.
6317         (hwdebug_find_thread_points_by_tid)
6318         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6319         Update.
6320
6321 2019-05-04  Tom Tromey  <tom@tromey.com>
6322
6323         * arc-tdep.c (arc_tdesc_init): Return bool.
6324
6325 2019-05-04  Tom Tromey  <tom@tromey.com>
6326
6327         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6328         Use gdb_assert_not_reached.
6329
6330 2019-05-04  Tom Tromey  <tom@tromey.com>
6331
6332         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6333         "false".
6334
6335 2019-05-04  Tom Tromey  <tom@tromey.com>
6336
6337         * arc-tdep.c (arc_tdesc_init): Use bool.
6338
6339 2019-05-04  Tom Tromey  <tom@tromey.com>
6340
6341         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6342
6343 2019-05-04  Tom Tromey  <tom@tromey.com>
6344
6345         * cli/cli-cmds.c (valid_command_p): Return bool.
6346
6347 2019-05-04  Tom Tromey  <tom@tromey.com>
6348
6349         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6350         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6351
6352 2019-05-04  Raul Tambre  <raul@tambre.ee>
6353
6354         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6355         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6356         operator for comparison.
6357
6358 2019-05-04  Tom Tromey  <tom@tromey.com>
6359
6360         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6361         (lookup_partial_symbol, print_partial_symbols)
6362         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6363         (psymbol_compare): Update.
6364         (add_psymbol_to_bcache): Clear the entire psymbol.
6365         (maintenance_check_psymtabs): Update.
6366         * psympriv.h (struct partial_symbol): Don't derive from
6367         general_symbol_info.
6368         <obj_section, unrelocated_address, address,
6369         set_unrelocated_address>: Update.
6370         <ginfo>: New member.
6371         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6372         (debug_names::write_psymbols): Update.
6373
6374 2019-05-04  Tom de Vries  <tdevries@suse.de>
6375
6376         * contrib/cc-with-tweaks.sh: Support -n arg.
6377
6378 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6379
6380         * corelow.c (core_target::detach): Ensure frame cache and
6381         register caches are cleared.
6382         inferior.c (exit_inferior_1): Likewise.
6383
6384 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6385             Tom Tromey  <tom@tromey.com>
6386
6387         * dictionary.c (collate_pending_symbols_by_language): Remove
6388         "struct" from foreach.
6389         * symtab.c (lookup_global_symbol_from_objfile)
6390         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6391         foreach.
6392         * ser-tcp.c (net_open): Remove "struct" from foreach.
6393         * objfiles.c (objfile_relocate, objfile_rebase)
6394         (objfile_has_symbols): Remove "struct" from foreach.
6395         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6396         from foreach.
6397         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6398         foreach.
6399         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6400         "struct" from foreach.
6401         * ada-lang.c (create_excep_cond_exprs)
6402         (ada_exception_catchpoint_cond_string): Remove "struct" from
6403         foreach.
6404
6405 2019-05-03  Tom Tromey  <tromey@adacore.com>
6406
6407         * ada-exp.y (convert_char_literal): Check suffix of each
6408         enumerator.
6409
6410 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6411
6412         PR ada/21406:
6413         * ada-exp.y (yywrap): Don't define.
6414         * ada-lex.l (%option): Add noyywrap
6415         (yywrap): Remove.
6416
6417 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6418
6419         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6420         _WIN32_WINNT to the XP level, unless already defined to a higher
6421         level.
6422
6423         * unittests/parse-connection-spec-selftests.c:
6424         * ser-tcp.c:
6425         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6426         override.
6427
6428         * symfile.c (find_separate_debug_file): Remove colon from the
6429         drive spec of DOS/Windows file names of the target, so that the
6430         file name produced from DEBUGDIR and the target's directory will
6431         be valid on DOS/Windows systems.
6432
6433 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * rust-lang.c (val_print_struct): Handle printing structures
6436         containing strings.
6437
6438 2019-05-02  Tom Tromey  <tromey@adacore.com>
6439
6440         * valarith.c (_initialize_valarith): Remove.
6441
6442 2019-05-01  Tom Tromey  <tromey@adacore.com>
6443
6444         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6445         bitfields.
6446
6447 2019-05-01  Tom Tromey  <tromey@adacore.com>
6448
6449         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6450         for big-endian copies.
6451
6452 2019-04-30  Ali Tamur  <tamur@google.com>
6453         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6454         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6455         (read_3_bytes): New function.
6456
6457 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6458
6459         * windows-nat.c (main_thread_id): Delete.
6460         (handle_output_debug_string): Replace main_thread_id by
6461         current_event.dwThreadId.
6462         (fake_create_process): Likewise.
6463         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6464         Do not set main_thread_id.
6465         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6466         current_event.dwThreadId.
6467         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6468
6469 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6470
6471         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6472         Use current_event.dwThreadId instead of main_thread_id.
6473
6474 2019-04-30  Tom Tromey  <tromey@adacore.com>
6475
6476         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6477         (create_excep_cond_exprs): Iterate over program spaces.
6478         (ada_exception_catchpoint_cond_string): Examine all minimal
6479         symbols for exception types.
6480
6481 2019-04-30  Tom Tromey  <tromey@adacore.com>
6482
6483         PR c++/24470:
6484         * dwarf2read.c (process_structure_scope): Handle case where type
6485         has template parameters but no symbol was created.
6486
6487 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6488             Chris January  <chris.january@arm.com>
6489
6490         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6491         qualifier.
6492         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6493
6494 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * f-typeprint.c (f_print_type): Update rules for printing
6497         whitespace.
6498         (f_type_print_varspec_suffix): Likewise.
6499
6500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6501             Chris January  <chris.january@arm.com>
6502
6503         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6504         function arguments.
6505
6506 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6507
6508         * f-lang.c (build_fortran_types): Change name of void type to
6509         lower case.
6510         * f-typeprint.c (f_type_print_base): Print the name of the void
6511         type, rather than a fixed string.
6512         * f-valprint.c (f_decorations): Use lower case void string.
6513
6514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6515             Chris January  <chris.january@arm.com>
6516
6517         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6518         types for Fortran.
6519
6520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6521             Chris January  <chris.january@arm.com>
6522             David Lecomber  <david.lecomber@arm.com>
6523
6524         * f-exp.y (BINOP_INTRINSIC): New token.
6525         (exp): New parser rule handling BINOP_INTRINSIC.
6526         (f77_keywords): Add new builtin procedures.
6527         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6528         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6529         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6530         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6531         (print_unop_subexp_f): New function.
6532         (print_binop_subexp_f): New function.
6533         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6534         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6535         (dump_subexp_body_f): Likewise.
6536         (operator_check_f): Likewise.
6537         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6538         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6539
6540 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6543         UNOP_KIND.
6544         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6545         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6546         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6547         (operator_length_f): New fuction.
6548         (print_subexp_f): New function.
6549         (op_name_f): New function.
6550         (dump_subexp_body_f): New function.
6551         (operator_check_f): New function.
6552         (exp_descriptor_f): Replace standard expression handling functions
6553         with new functions.
6554         * gdb/fortran-operator.def: New file.
6555         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6556         * gdb/std-operator.def: Remove UNOP_KIND.
6557
6558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6559
6560         * std-operator.def: Remove unbalanced, stray double quote
6561         character.
6562
6563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6564             Chris January  <chris.january@arm.com>
6565             Daniel Everett  <daniel.everett@arm.com>
6566             Nick Forrington  <nick.forrington@arm.com>
6567             Richard Bunt  <richard.bunt@arm.com>
6568
6569         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6570         of depth when printing anonymous structs or unions.
6571         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6572         Don't print either the top-level value, or the children if the
6573         max-depth is exceeded.
6574         (ppscm_print_children): When printing the key of a map, allow one
6575         extra level of depth.
6576         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6577         print either the top-level value, or the children if the max-depth
6578         is exceeded.
6579         (print_children): When printing the key of a map, allow one extra
6580         level of depth.
6581         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6582         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6583         (user_print_options): Initialise max_depth field.
6584         (val_print_scalar_or_string_type_p): New function.
6585         (val_print): Check to see if the max depth has been reached.
6586         (val_print_check_max_depth): Define new function.
6587         (show_print_max_depth): New function.
6588         (_initialize_valprint): Add 'print max-depth' option.
6589         * valprint.h (struct value_print_options) <max_depth>: New field.
6590         (val_print_check_max_depth): Declare new function.
6591         * NEWS: Document new feature.
6592
6593 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6594
6595         * ada-lang.c (ada_language_defn): Initialise new field.
6596         * c-lang.c (c_is_string_type_p): New function.
6597         (c_language_defn): Initialise new field.
6598         (cplus_language_defn): Initialise new field.
6599         (asm_language_defn): Initialise new field.
6600         (minimal_language_defn): Initialise new field.
6601         * c-lang.h (c_is_string_type_p): Declare new function.
6602         * d-lang.c (d_language_defn): Initialise new field.
6603         * f-lang.c (f_is_string_type_p): New function.
6604         (f_language_defn): Initialise new field.
6605         * go-lang.c (go_is_string_type_p): New function.
6606         (go_language_defn): Initialise new field.
6607         * language.c (default_is_string_type_p): New function.
6608         (unknown_language_defn): Initialise new field.
6609         (auto_language_defn): Initialise new field.
6610         * language.h (struct language_defn) <la_is_string_type_p>: New
6611         member variable.
6612         (default_is_string_type_p): Declare new function.
6613         * m2-lang.c (m2_language_defn): Initialise new field.
6614         * objc-lang.c (objc_language_defn): Initialise new field.
6615         * opencl-lang.c (opencl_language_defn): Initialise new field.
6616         * p-lang.c (pascal_is_string_type_p): New function.
6617         (pascal_language_defn): Initialise new field.
6618         * rust-lang.c (rust_is_string_type_p): New function.
6619         (rust_language_defn): Initialise new field.
6620
6621 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6624         New field.
6625         * ada-lang.c (ada_language_defn): Initialise new field.
6626         * c-lang.c (c_language_defn): Likewise.
6627         (cplus_language_defn): Likewise.
6628         (asm_language_defn): Likewise.
6629         (minimal_language_defn): Likewise.
6630         * d-lang.c (d_language_defn): Likewise.
6631         * f-lang.c (f_language_defn): Likewise.
6632         * go-lang.c (go_language_defn): Likewise.
6633         * language.c (unknown_language_defn): Likewise.
6634         (auto_language_defn): Likewise.
6635         * m2-lang.c (m2_language_defn): Likewise.
6636         * objc-lang.c (objc_language_defn): Likewise.
6637         * opencl-lang.c (opencl_language_defn): Likewise.
6638         * p-lang.c (pascal_language_defn): Likewise.
6639         * rust-lang.c (rust_language_defn): Likewise.
6640
6641 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * ada-lang.c (ada_is_character_type): Change return type to bool.
6644         (ada_is_string_type): Likewise.
6645         * ada-lang.h (ada_is_character_type): Update declaration
6646         (ada_is_string_type): Likewise.
6647
6648 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6649
6650         Support style in 'frame|thread apply'
6651
6652         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6653         * record.c (record_start, record_stop): Update callers of
6654         execute_command_to_string with false.
6655         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6656         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6657         methods.
6658         (class string_file): New constructor with term_out parameter.
6659         Override methods term_out and can_emit_style_escape.  New member
6660         term_out.
6661         (class stdio_file): Override can_emit_style_escape.
6662         (class tee_file): Override term_out and can_emit_style_escape.
6663         * utils.h (can_emit_style_escape): Remove.
6664         * utils.c (can_emit_style_escape): Likewise.
6665         Update all callers of can_emit_style_escape (SOMESTREAM) to
6666         SOMESTREAM->can_emit_style_escape.
6667         * source-cache.c (source_cache::get_source_lines): Likewise.
6668         * stack.c (frame_apply_command_count): Call execute_command_to_string
6669         passing the term_out characteristic of the current gdb_stdout.
6670         * thread.c (thr_try_catch_cmd): Likewise.
6671         * top.c (execute_command_to_string): pass term_out parameter
6672         to construct the string_file for the command output.
6673         * ui-file.c (term_cli_styling): New function (most code moved
6674         from utils.c can_emit_style_escape).
6675         (string_file::string_file, string_file::can_emit_style_escape,
6676         stdio_file::can_emit_style_escape, tee_file::term_out,
6677         tee_file::can_emit_style_escape): New functions.
6678
6679 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6680
6681         * NEWS: Mention the new set|show may-call-functions.
6682         * infcall.c (may_call_functions_p): New variable.
6683         (show_may_call_functions_p): New function.
6684         (call_function_by_hand_dummy): Throws an error if not
6685         may-call-functions.
6686         (_initialize_infcall): Call add_setshow_boolean_cmd for
6687         may-call-functions.
6688
6689 2019-04-25  Keith Seitz  <keiths@redhat.com>
6690
6691         PR c++/24367
6692         * cp-support.c (inspect_type): Don't attempt substitutions
6693         of symbol with the same name.
6694
6695 2019-04-25  Tom Tromey  <tromey@adacore.com>
6696
6697         PR gdb/24475:
6698         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6699         static.
6700
6701 2019-04-25  Tom Tromey  <tromey@adacore.com>
6702
6703         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6704         rvalue reference.
6705         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6706         (gdb_xml_parser::parse): Use std::move.
6707         * python/python-internal.h (gdbpy_convert_exception): Take a const
6708         reference.
6709         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6710         std::move.
6711         * python/py-utils.c (gdbpy_convert_exception): Take a const
6712         reference.
6713         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6714         Use std::move.
6715         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6716         Use std::move.
6717         * mi/mi-main.c (mi_print_exception): Take a const reference.
6718         * main.c (handle_command_errors): Take a const reference.
6719         * linespec.c (parse_linespec): Use std::move.
6720         * infcall.c (run_inferior_call): Use std::move.
6721         (call_function_by_hand_dummy): Use std::move.
6722         * exec.c (try_open_exec_file): Use std::move.
6723         * exceptions.h (exception_print, exception_fprintf)
6724         (exception_print_same): Update.
6725         * exceptions.c (print_exception, exception_print)
6726         (exception_fprintf, exception_print_same): Change parameters to
6727         const reference.
6728         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6729         * common/new-op.c: Use std::move.
6730         * common/common-exceptions.h (struct gdb_exception): Add move
6731         constructor.
6732         (struct gdb_exception_error, struct gdb_exception_quit, struct
6733         gdb_quit_bad_alloc): Change constructor to move constructor.
6734         (throw_exception): Change parameter to rvalue reference.
6735         * common/common-exceptions.c (throw_exception): Take rvalue
6736         reference.
6737         * cli/cli-interp.c (safe_execute_command): Use std::move.
6738         * breakpoint.c (insert_bp_location, location_to_sals): Use
6739         std::move.
6740
6741 2019-04-25  Tom Tromey  <tromey@adacore.com>
6742
6743         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6744         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6745         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6746         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6747         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6748         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6749         guile/scm-value.c: Use unpack.
6750         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6751         gdbscm_gdb_exception.
6752         (gdbscm_throw_gdb_exception): Likewise.
6753         (struct gdbscm_gdb_exception): New.
6754         (unpack): New function.
6755         (gdbscm_wrap): Use unpack.
6756
6757 2019-04-25  Tom Tromey  <tromey@adacore.com>
6758
6759         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6760         (gdb_rl_callback_handler): Use std::move.
6761         * common/common-exceptions.h (struct gdb_exception): Add move
6762         assignment operator.
6763         (throw_exception_sjlj): Change "exception" to const reference.
6764         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6765         (throw_exception_sjlj): Change "exception" to const reference.
6766
6767 2019-04-25  Tom Tromey  <tromey@adacore.com>
6768
6769         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6770         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6771         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6772         Update.
6773         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6774         Update.
6775         * mi/mi-interp.c (mi_interp::exec): Update.
6776         * linespec.c (parse_linespec): Update.
6777         * infcall.c (run_inferior_call): Update.
6778         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6779         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6780         (gdbscm_lookup_global_symbol): Update.
6781         * guile/scm-param.c (gdbscm_parameter_value): Update.
6782         * guile/scm-frame.c (gdbscm_frame_read_register)
6783         (gdbscm_frame_read_var): Update.
6784         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6785         * exec.c (try_open_exec_file): Update.
6786         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6787         (gdb_rl_callback_handler): Update.
6788         * common/common-exceptions.h (exception_none): Don't declare.
6789         * common/common-exceptions.c (exception_none): Don't define.
6790         (struct catcher) <exception>: Update.
6791         * cli/cli-interp.c (safe_execute_command): Update.
6792         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6793
6794 2019-04-25  Ali Tamur  <tamur@google.com>
6795
6796         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6797         (read_attribute_value): Likewise.
6798         (dwarf2_read_addr_index): Update comment.
6799         (read_str_index): Add DW_FORM_strx.
6800         (dwarf2_string_attr): Likewise.
6801         (dwarf2_const_value_attr): Likewise.
6802         (dump_die_shallow): Likewise.
6803         (dwarf2_fetch_constant_bytes): Likewise.
6804         (skip_form_bytes): Likewise.
6805         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6806
6807 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6808
6809         PR corefiles/11608
6810         PR corefiles/18187
6811         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6812         OFFSET.  Verify if current mapping contains an ELF header.
6813         (linux_find_memory_regions_full): Adjust call to
6814         dump_mapping_p.
6815
6816 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6817             Kang Li <kanglictf@gmail.com>
6818
6819         PR gdb/21600
6820
6821         * dwarf2-frame.c (read_initial_length): Be consistent about using
6822         unsigned representation of length.
6823         (decode_frame_entry_1): Likewise.  Check for wraparound of
6824         end pointer as well as buffer overflow.
6825
6826 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6827
6828         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6829         "vq".
6830
6831 2019-04-24  Tom Tromey  <tromey@adacore.com>
6832
6833         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6834
6835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6836
6837         * s12z-tdep.c (s12z_unwind_pc): Delete.
6838         (s12z_unwind_sp): Delete.
6839         (s12z_gdbarch_init): Don't register deleted functions with
6840         gdbarch.
6841
6842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * rl78-tdep.c (rl78_unwind_sp): Delete.
6845         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6846
6847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6848
6849         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6850         (xstormy16_unwind_pc): Delete.
6851         (xstormy16_dummy_id): Delete.
6852         (xstormy16_gdbarch_init): Don't register deleted functions with
6853         gdbarch.
6854
6855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6856
6857         * vax-tdep.c (vax_unwind_pc): Delete.
6858         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6859
6860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6861
6862         * v850-tdep.c (v850_unwind_sp): Delete.
6863         (v850_unwind_pc): Delete.
6864         (v850_dummy_id): Delete.
6865         (v850_gdbarch_init): Don't register deleted functions with
6866         gdbarch.
6867
6868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6869
6870         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6871         (tilegx_unwind_pc): Delete.
6872         (tilegx_unwind_dummy_id): Delete.
6873         (tilegx_gdbarch_init): Don't register deleted functions with
6874         gdbarch.
6875
6876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6877
6878         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6879         (tic6x_dummy_id): Delete.
6880         (tic6x_gdbarch_init): Don't register deleted functions with
6881         gdbarch.
6882
6883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6884
6885         * sparc-tdep.c (sparc_unwind_pc): Delete.
6886         (sparc32_gdbarch_init): Don't register deleted function with
6887         gdbarch.
6888
6889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * sh-tdep.c (sh_unwind_sp): Delete.
6892         (sh_unwind_pc): Delete.
6893         (sh_dummy_id): Delete.
6894         (sh_gdbarch_init): Don't register deleted functions with
6895         gdbarch.
6896
6897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6898
6899         * score-tdep.c (score_unwind_sp): Delete.
6900         (score_unwind_pc): Delete.
6901         (score_dummy_id): Delete.
6902         (score_gdbarch_init): Don't register deleted functions with
6903         gdbarch.
6904
6905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6906
6907         * rx-tdep.c (rx_unwind_pc): Delete.
6908         (rx_unwind_sp): Delete.
6909         (rx_dummy_id): Delete.
6910         (rx_gdbarch_init): Don't register deleted functions with
6911         gdbarch.  Update comment.
6912
6913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6914
6915         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6916         (rs6000_dummy_id): Delete.
6917         (rs6000_gdbarch_init): Don't register deleted functions with
6918         gdbarch.
6919
6920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6921
6922         * or1k-tdep.c (or1k_dummy_id): Delete.
6923         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6924
6925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * nios2-tdep.c (nios2_dummy_id): Delete.
6928         (nios2_unwind_sp): Delete.
6929         (nios2_gdbarch_init): Don't register deleted functions with
6930         gdbarch.
6931
6932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6933
6934         * nds32-tdep.c (nds32_dummy_id): Delete.
6935         (nds32_unwind_pc): Delete.
6936         (nds32_unwind_sp): Delete.
6937         (nds32_gdbarch_init): Don't register deleted functions with
6938         gdbarch.
6939
6940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * msp430-tdep.c (msp430_unwind_pc): Delete.
6943         (msp430_unwind_sp): Delete.
6944         (msp430_dummy_id): Delete.
6945         (msp430_gdbarch_init): Don't register deleted functions with
6946         gdbarch.
6947
6948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6949
6950         * moxie-tdep.c (moxie_unwind_sp): Delete.
6951         (moxie_unwind_pc): Delete.
6952         (moxie_dummy_id): Delete.
6953         (moxie_gdbarch_init): Don't register deleted functions with
6954         gdbarch.
6955
6956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6957
6958         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6959         (mn10300_unwind_pc): Delete.
6960         (mn10300_unwind_sp): Delete.
6961         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6962         mn10300_unwind_sp.
6963         (mn10300_frame_unwind_init): Don't register deleted functions with
6964         gdbarch.
6965
6966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * mep-tdep.c (mep_unwind_pc): Delete.
6969         (mep_unwind_sp): Delete.
6970         (mep_dummy_id): Delete.
6971         (mep_gdbarch_init): Don't register deleted functions with
6972         gdbarch.
6973
6974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6975
6976         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6977         (m68hc11_unwind_sp): Delete.
6978         (m68hc11_gdbarch_init): Don't register deleted functions with
6979         gdbarch.
6980
6981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6982
6983         * m32r-tdep.c (m32r_unwind_sp): Delete.
6984         (m32r_unwind_pc): Delete.
6985         (m32r_dummy_id): Delete.
6986         (m32r_gdbarch_init): Don't register deleted functions with
6987         gdbarch.
6988
6989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6990
6991         * m32c-tdep.c (m32c_unwind_pc): Delete.
6992         (m32c_unwind_sp): Delete.
6993         (m32c_dummy_id): Delete.
6994         (m32c_gdbarch_init): Don't register deleted functions with
6995         gdbarch.
6996
6997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7000         (lm32_unwind_pc): Delete.
7001         (lm32_dummy_id): Delete.
7002         (lm32_gdbarch_init): Don't register deleted functions with
7003         gdbarch.
7004
7005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7006
7007         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7008         (iq2000_unwind_pc): Delete.
7009         (iq2000_dummy_id): Delete.
7010         (iq2000_gdbarch_init): Don't register deleted functions with
7011         gdbarch.
7012
7013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7014
7015         * nds32-tdep.c (nds32_type_align): Delete.
7016         (nds32_push_dummy_call): Use type_align instead.
7017
7018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7019
7020         * arm-tdep.c (arm_type_align): Only handle vector override case.
7021         (arm_push_dummy_call): Use type_align.
7022         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7023
7024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7027         case.
7028         (pass_on_stack): Use type_align.
7029         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7030         function.
7031
7032 2019-04-23  Tom Tromey  <tromey@adacore.com>
7033
7034         * dwarf2read.c (line_header::file_name_at): Remove unused
7035         overload.
7036
7037 2019-04-23  Tom de Vries  <tdevries@suse.de>
7038
7039         PR gdb/24438
7040         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7041         invocation.
7042
7043
7044 2019-03-27  Ali Tamur  <tamur@google.com>
7045
7046         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7047         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7048         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7049         (dwarf_expr_context::get_addr_index): Likewise
7050         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7051         (symbol_needs_eval_context::get_addr_index): Likewise
7052         (disassemble_dwarf_expression): Add DW_OP_addrx
7053         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7054         (read_cutu_die_from_dwo): Update comment
7055         (skip_one_die): Add DW_FORM_addrx
7056         (read_attribute_value): Likewise
7057         (var_decode_location): Add DW_OP_addrx
7058         (dwarf2_const_value_attr): Add DW_FORM_addrx
7059         (dump_die_shallow): Likewise
7060         (dwarf2_fetch_constant_bytes): Likewise
7061         (decode_locdesc): Add DW_OP_addrx
7062         (skip_form_bytes): Add DW_FORM_addrx
7063
7064 2019-04-22  Ali Tamur  <tamur@google.com>
7065
7066         * MAINTAINERS (Write After Approval): Add self.
7067
7068 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7069
7070         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7071         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7072         (open_symbol_file_object): Likewise.
7073         (svr4_default_sos): Add info parameter.
7074         (svr4_read_so_list): Likewise.
7075         (svr4_current_sos_direct): Adjust functions calls to pass down
7076         info.
7077         (svr4_current_sos_1): Add info parameter.
7078         (svr4_current_sos): Call get_svr4_info, pass info down to
7079         svr4_current_sos_1.
7080         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7081         get_svr4_info.
7082         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7083         get_svr4_info.
7084         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7085         to get_svr4_info.
7086         (probes_table_remove_objfile_probes): Likewise.
7087         (register_solib_event_probe): Add info parameter.
7088         (solist_update_incremental): Pass info parameter down to
7089         svr4_read_so_list.
7090         (disable_probes_interface): Add info parameter.
7091         (svr4_handle_solib_event): Pass current_program_space to
7092         get_svr4_info.  Adjust disable_probes_interface cleanup.
7093         (svr4_create_probe_breakpoints): Add info parameter, pass it
7094         down to register_solib_event_probe.
7095         (svr4_create_solib_event_breakpoints): Add info parameter,
7096         pass it down to svr4_create_probe_breakpoints.
7097         (enable_break): Pass info down to
7098         svr4_create_solib_event_breakpoints.
7099         (svr4_solib_create_inferior_hook): Pass current_program_space to
7100         get_svr4_info.
7101         (svr4_clear_solib): Likewise.
7102
7103 2019-04-22  Pedro Alves  <palves@redhat.com>
7104
7105         * solib-svr4.c (svr4_free_objfile_observer): New.
7106         (probe_and_action::objfile): New field.
7107         (probes_table_htab_remove_objfile_probes)
7108         (probes_table_remove_objfile_probes): New functions.
7109         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7110         in the new probe_and_action.  Don't store the probe in 'lookup'.
7111         (svr4_create_probe_breakpoints): Pass objfile to
7112         register_solib_event_probe.
7113         (_initialize_svr4_solib): Register a free_objfile observer.
7114
7115 2019-04-19  Tom Tromey  <tom@tromey.com>
7116
7117         * common/queue.h: Remove.
7118
7119 2019-04-19  Tom Tromey  <tom@tromey.com>
7120
7121         * event-loop.c: Don't include "common/queue.h".
7122
7123 2019-04-19  Tom Tromey  <tom@tromey.com>
7124
7125         * remote.c (remote_target): Use delete.
7126         * remote-notif.h: Include <list>, not "common/queue.h".
7127         (notif_client_p): Remove typedef.
7128         (remote_notif_state): Add constructor, destructor, initializer.
7129         <notif_queue>: Now a std::list.
7130         (remote_notif_state_xfree): Don't declare.
7131         * remote-notif.c (remote_notif_process, handle_notification)
7132         (remote_notif_state_allocate): Update.
7133         (~remote_notif_state): Rename from remote_notif_state_xfree.
7134
7135 2019-04-19  Tom Tromey  <tom@tromey.com>
7136
7137         * symfile.c (reread_symbols): Update.
7138         * objfiles.c (objfile_register_static_link)
7139         (objfile_lookup_static_link): Update
7140         (~objfile) Don't delete static_links.
7141         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7142
7143 2019-04-19  Tom Tromey  <tom@tromey.com>
7144
7145         * type-stack.h (struct type_stack) <insert>: Constify string.
7146         * type-stack.c (type_stack::insert): Constify string.
7147         * gdbtypes.h (lookup_template_type): Update.
7148         (address_space_name_to_int): Update.
7149         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7150         const.
7151         (lookup_template_type): Make name const.
7152         * c-exp.y: Update rules.
7153         (lex_one_token, classify_name, classify_inner_name)
7154         (c_print_token): Update.
7155         * p-exp.y: Update rules.
7156         (yylex): Update.
7157         * f-exp.y: Update rules.
7158         (yylex): Update.
7159         * d-exp.y: Update rules.
7160         (lex_one_token, classify_name, classify_inner_name): Update.
7161         * parse.c (write_dollar_variable, copy_name): Return std::string.
7162         * parser-defs.h (copy_name): Change return type.
7163         * m2-exp.y: Update rules.
7164         (yylex): Update.
7165         * go-exp.y (lex_one_token): Update.
7166         Update rules.
7167         (classify_unsafe_function, classify_packaged_name)
7168         (classify_name, yylex): Update.
7169
7170 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7171
7172         * configure.ac: add --enable-source-highlight switch.
7173         * configure: Regenerate.
7174         * top.c (print_gdb_version): plumb --enable-source-highlight
7175         status to "show configuration".
7176
7177 2019-04-19  Tom Tromey  <tromey@adacore.com>
7178
7179         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7180         Check ADA_TYPE_P.
7181         (empty_record, ada_template_to_fixed_record_type_1)
7182         (template_to_static_fixed_type)
7183         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7184         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7185         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7186         macros.
7187
7188 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7189
7190         PR symtab/24423:
7191         * source.c (print_source_lines_base): Advance "iter" when a
7192         control character is seen.
7193
7194 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7195
7196         * inferior.h (struct infcall_suspend_state_deleter):
7197         Catch exception in destructor to avoid crash.
7198
7199 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7200
7201         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7202         close to the add_com "shell".
7203
7204 2019-04-18  Tom Tromey  <tromey@adacore.com>
7205
7206         * process-stratum-target.h (class process_stratum_target)
7207         <stratum>: Add "final".
7208
7209 2019-04-17  Tom Tromey  <tromey@adacore.com>
7210
7211         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7212         against nullptr before use.
7213
7214 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7215
7216         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7217
7218 2019-04-17  Jim Wilson  <jimw@sifive.com>
7219             Andrew Burgess  <andrew.burgess@embecosm.com>
7220
7221         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7222         code read might fail, assume 4-byte breakpoint in that case.
7223
7224 2019-04-15  Leszek Swirski  <leszeks@google.com>
7225
7226         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7227         rather than a hand-rolled POD check when checking for forced MEMORY
7228         classification.
7229
7230 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7231
7232         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7233         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7234         function.
7235         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7236         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7237         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7238         declaration.
7239
7240 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7241
7242         * aarch64-linux-nat.c
7243         (aarch64_linux_nat_target::thread_architecture): Add override.
7244         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7245         each VQ.
7246
7247 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7248
7249         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7250
7251 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7254         target types of size 96-bits, add some additional comments, and
7255         check that the builtin type we found was the correct size.
7256
7257 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7258
7259         * utils.c (prompt_for_continue): Don't restore the styling at the
7260         end, as applied_style has the wrong value.  This fixes styling in
7261         long lists of file names that are interrupted by the "Continue?"
7262         prompt.
7263
7264 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7265
7266         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7267         * c-lang.c (c_language_defn): Likewise.
7268         (cplus_language_defn): Likewise.
7269         (asm_language_defn): Likewise.
7270         (minimal_language_defn): Likewise.
7271         * d-lang.c (d_language_defn): Likewise.
7272         * f-lang.c (f_language_defn): Likewise.
7273         * go-lang.c (go_language_defn): Likewise.
7274         * language.c (unknown_language_defn): Likewise.
7275         (auto_language_defn): Likewise.
7276         * language.h (struct language_defn): Remove la_magic field.
7277         (LANG_MAGIC): Delete.
7278         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7279         * objc-lang.c (objc_language_defn): Likewise.
7280         * opencl-lang.c (opencl_language_defn): Likewise.
7281         * p-lang.c (pascal_language_defn): Likewise.
7282         * rust-lang.c (rust_language_defn): Likewise.
7283
7284 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * riscv-tdep.c (riscv_type_align): New function.
7287         (riscv_type_alignment): Delete.
7288         (riscv_arg_location): Use 'type_align'.
7289         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7290
7291 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * gdbtypes.c (type_align): A struct with no non-static fields also
7294         has alignment of 1.
7295
7296 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7297
7298         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7299         component to 0.
7300         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7301         member.
7302         (riscv_struct_info::analyse): New implementation using new
7303         analyse_inner member function.
7304         (riscv_struct_info::field_offset): New member function.
7305         (riscv_struct_info::m_offsets): New member variable.
7306         (riscv_struct_info::analyse_inner): New private member function,
7307         takes the old implementation of riscv_struct_info::analyse but
7308         extended to track field offsets.
7309         (riscv_call_arg_struct): Update the struct folding special cases
7310         to handle cases where empty C++ structs, which are non-zero
7311         length, are found.
7312         (riscv_arg_location): Initialise the length of each location, a
7313         non-zero length now indicates the location is in use.
7314         (riscv_push_dummy_call): Allow for the first location having a
7315         non-zero offset when setting up arguments.
7316         (riscv_return_value): Likewise, but for return values.
7317
7318 2019-04-11  Tom Tromey  <tromey@adacore.com>
7319
7320         * utils.c (internal_vproblem): Make "msg" const.
7321
7322 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7323
7324         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7325         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7326         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7327         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7328
7329 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7330
7331         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7332         function.
7333         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7334         of amd64_collect_native_gregset.
7335         (amd64_linux_nat_target::store_registers): Likewise.
7336
7337 2019-04-10  Tom Tromey  <tom@tromey.com>
7338
7339         * symtab.c (lookup_global_symbol_from_objfile)
7340         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7341         * objfiles.h (class separate_debug_iterator): New.
7342         (class separate_debug_range): New.
7343         (struct objfile) <separate_debug_objfiles>: New method.
7344         (objfile_separate_debug_iterate): Don't declare.
7345         * objfiles.c (separate_debug_iterator::operator++): Rename from
7346         objfile_separate_debug_iterate.
7347         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7348         iterator.
7349         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7350         iterator.
7351
7352 2019-04-10  Tom Tromey  <tom@tromey.com>
7353
7354         * symfile.c (reread_symbols): Remove old comment.
7355         * objfiles.c (free_all_objfiles): Fix a typo.
7356
7357 2019-04-10  Tom Tromey  <tom@tromey.com>
7358
7359         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7360         * minsyms.c (lookup_minimal_symbol): Use foreach.
7361         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7362         (lookup_minimal_symbol_solib_trampoline): Likewise.
7363         * symfile.c (reread_symbols): Use foreach.
7364
7365 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7366             Tom Tromey  <tromey@adacore.com>
7367
7368         PR rust/24414:
7369         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7370         (rust_lex_int_test): Change "value" to be LONGEST.
7371         (rust_lex_tests): Add test for long integer literal.
7372
7373 2019-04-09  Tom Tromey  <tromey@adacore.com>
7374
7375         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7376         to bool.
7377         (extended_remote_target::attach): Update.
7378         (remote_target::remote_notice_new_inferior): Update.
7379         (remote_target::add_current_inferior_and_thread): Update.
7380         * inferior.c (exit_inferior_1): Use "false".
7381         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7382
7383 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7384
7385         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7386         the "start" command.
7387
7388 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7389
7390         * python/py-inferior.c (infpy_thread_from_thread_handle):
7391         Adjust comments to reflect renaming of thread_from_thread_handle
7392         to thread_from_handle.  Adjust keywords.  Fix type error message.
7393         (inferior_object_methods): Add thread_from_handle.  Retain
7394         thread_from_thread_handle, but mark it as deprecated.
7395
7396 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7397
7398         * gdbthread.h (find_thread_by_handle): Revise declaration.
7399         * thread.c (find_thread_by_handle): Likewise.  Adjust
7400         implementation too.
7401         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7402         support for buffer objects as handles.
7403
7404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7405
7406         * python/py-infthread.c (thpy_thread_handle): New function.
7407         (thread_object_methods): Register thpy_thread_handle.
7408
7409 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7410
7411         * gdbthread.h (thread_to_thread_handle): Declare.
7412         * thread.c (gdbtypes.h): Include.
7413         (thread_to_thread_handle): New function.
7414
7415         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7416         (target_thread_info_to_thread_handle): Declare.
7417         * target.c (target_thread_info_to_thread_handle): New function.
7418         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7419         * target-delegates.c: Regenerate.
7420
7421         * linux-thread-db.c (class thread_db_target): Add method
7422         thread_info_to_thread_handle.
7423         (thread_db_target::thread_info_to_thread_handle): Define.
7424         * remote.c (class remote_target): Add new method
7425         thread_info_to_thread_handle.
7426         (remote_target::thread_info_to_thread_handle): Define.
7427
7428 2019-04-08  Pedro Alves  <palves@redhat.com>
7429
7430         * common/common-exceptions.c (throw_exception): Don't create
7431         named object to throw; throw directly.
7432         (throw_it): Likewise.  Don't initialize gdb_exception::message
7433         here, with new; pass FMT and AP to the ctor instead.
7434         * common/common-exceptions.h: Include <string>.
7435         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7436         const char *, va_list)): New ctor.  Use std::make_shared.
7437         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7438         errors)): Delete.
7439         (gdb_exception_error::gdb_exception_error(enum errors, const char
7440         *, va_list)): New.
7441         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7442         Add assertion.
7443         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7444         errors)): Delete.
7445         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7446         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7447         Add assertion.
7448
7449 2019-04-08  Tom Tromey  <tom@tromey.com>
7450
7451         * valops.c (value_rtti_indirect_type): Replace throw_exception
7452         with throw.
7453         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7454         with throw.
7455         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7456         throw.
7457         * target.c (target_translate_tls_address): Replace throw_exception
7458         with throw.
7459         * stack.c (frame_apply_command_count): Replace throw_exception
7460         with throw.
7461         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7462         throw.
7463         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7464         with throw.
7465         * rs6000-tdep.c (rs6000_frame_cache)
7466         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7467         * remote.c: Replace throw_exception with throw.
7468         * record-full.c (record_full_message, record_full_wait_1)
7469         (record_full_restore): Replace throw_exception with throw.
7470         * record-btrace.c:
7471         (get_thread_current_frame_id, record_btrace_start_replaying)
7472         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7473         (cmd_record_btrace_start): Replace throw_exception with throw.
7474         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7475         throw.
7476         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7477         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7478         * linespec.c:
7479         (find_linespec_symbols): Replace throw_exception with throw.
7480         * infrun.c (displaced_step_prepare, resume): Replace
7481         throw_exception with throw.
7482         * infcmd.c (post_create_inferior): Replace throw_exception with
7483         throw.
7484         * inf-loop.c (inferior_event_handler): Replace throw_exception
7485         with throw.
7486         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7487         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7488         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7489         (get_prev_frame_always, get_frame_pc_if_available)
7490         (get_frame_address_in_block_if_available, get_frame_language):
7491         Replace throw_exception with throw.
7492         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7493         throw_exception with throw.
7494         * eval.c (fetch_subexp_value, evaluate_var_value)
7495         (evaluate_funcall, evaluate_subexp_standard): Replace
7496         throw_exception with throw.
7497         * dwarf2loc.c (call_site_find_chain)
7498         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7499         Replace throw_exception with throw.
7500         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7501         with throw.
7502         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7503         throw.
7504         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7505         * completer.c (complete_line_internal): Replace throw_exception
7506         with throw.
7507         * compile/compile-object-run.c (compile_object_run): Replace
7508         throw_exception with throw.
7509         * cli/cli-script.c (process_next_line): Replace throw_exception
7510         with throw.
7511         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7512         (btrace_enable, btrace_maint_update_pt_packets): Replace
7513         throw_exception with throw.
7514         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7515         throw_exception with throw.
7516         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7517         throw_exception with throw.
7518         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7519         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7520         * aarch64-tdep.c (aarch64_make_prologue_cache)
7521         (aarch64_make_stub_cache): Replace throw_exception with throw.
7522
7523 2019-04-08  Tom Tromey  <tom@tromey.com>
7524
7525         * common/common-exceptions.c (throw_exception): Rename from
7526         throw_exception_cxx.  Remove old copy.  Make argument const.
7527         (throw_it): Create and throw exception objects directly.
7528         * common/common-exceptions.h (throw_exception): Make argument
7529         const.
7530         (struct gdb_exception_error): Add constructor.
7531         (struct gdb_exception_quit): Add constructor.
7532
7533 2019-04-08  Tom Tromey  <tom@tromey.com>
7534
7535         * common/common-exceptions.h (exception_rethrow): Don't declare.
7536         (TRY_SJLJ): Update comment.
7537         (TRY, CATCH, END_CATCH): Remove.
7538         * common/common-exceptions.c (exception_rethrow): Remove.
7539
7540 2019-04-08  Tom Tromey  <tom@tromey.com>
7541
7542         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7543         Remove.
7544         (gdb_exception_error): Rename from
7545         gdb_exception_RETURN_MASK_ERROR.
7546         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7547         (gdb_quit_bad_alloc): Update.
7548         * aarch64-tdep.c: Update.
7549         * ada-lang.c: Update.
7550         * ada-typeprint.c: Update.
7551         * ada-valprint.c: Update.
7552         * amd64-tdep.c: Update.
7553         * arch-utils.c: Update.
7554         * break-catch-throw.c: Update.
7555         * breakpoint.c: Update.
7556         * btrace.c: Update.
7557         * c-varobj.c: Update.
7558         * cli/cli-cmds.c: Update.
7559         * cli/cli-interp.c: Update.
7560         * cli/cli-script.c: Update.
7561         * common/common-exceptions.c: Update.
7562         * common/new-op.c: Update.
7563         * common/selftest.c: Update.
7564         * compile/compile-c-symbols.c: Update.
7565         * compile/compile-cplus-symbols.c: Update.
7566         * compile/compile-object-load.c: Update.
7567         * compile/compile-object-run.c: Update.
7568         * completer.c: Update.
7569         * corelow.c: Update.
7570         * cp-abi.c: Update.
7571         * cp-support.c: Update.
7572         * cp-valprint.c: Update.
7573         * darwin-nat.c: Update.
7574         * disasm-selftests.c: Update.
7575         * dtrace-probe.c: Update.
7576         * dwarf-index-cache.c: Update.
7577         * dwarf-index-write.c: Update.
7578         * dwarf2-frame-tailcall.c: Update.
7579         * dwarf2-frame.c: Update.
7580         * dwarf2loc.c: Update.
7581         * dwarf2read.c: Update.
7582         * eval.c: Update.
7583         * event-loop.c: Update.
7584         * event-top.c: Update.
7585         * exec.c: Update.
7586         * f-valprint.c: Update.
7587         * fbsd-tdep.c: Update.
7588         * frame-unwind.c: Update.
7589         * frame.c: Update.
7590         * gdbtypes.c: Update.
7591         * gnu-v3-abi.c: Update.
7592         * guile/guile-internal.h: Update.
7593         * guile/scm-block.c: Update.
7594         * guile/scm-breakpoint.c: Update.
7595         * guile/scm-cmd.c: Update.
7596         * guile/scm-disasm.c: Update.
7597         * guile/scm-frame.c: Update.
7598         * guile/scm-lazy-string.c: Update.
7599         * guile/scm-math.c: Update.
7600         * guile/scm-param.c: Update.
7601         * guile/scm-ports.c: Update.
7602         * guile/scm-pretty-print.c: Update.
7603         * guile/scm-symbol.c: Update.
7604         * guile/scm-symtab.c: Update.
7605         * guile/scm-type.c: Update.
7606         * guile/scm-value.c: Update.
7607         * i386-linux-tdep.c: Update.
7608         * i386-tdep.c: Update.
7609         * inf-loop.c: Update.
7610         * infcall.c: Update.
7611         * infcmd.c: Update.
7612         * infrun.c: Update.
7613         * jit.c: Update.
7614         * language.c: Update.
7615         * linespec.c: Update.
7616         * linux-fork.c: Update.
7617         * linux-nat.c: Update.
7618         * linux-tdep.c: Update.
7619         * linux-thread-db.c: Update.
7620         * main.c: Update.
7621         * mi/mi-cmd-break.c: Update.
7622         * mi/mi-cmd-stack.c: Update.
7623         * mi/mi-interp.c: Update.
7624         * mi/mi-main.c: Update.
7625         * objc-lang.c: Update.
7626         * p-valprint.c: Update.
7627         * parse.c: Update.
7628         * ppc-linux-tdep.c: Update.
7629         * printcmd.c: Update.
7630         * python/py-arch.c: Update.
7631         * python/py-breakpoint.c: Update.
7632         * python/py-cmd.c: Update.
7633         * python/py-finishbreakpoint.c: Update.
7634         * python/py-frame.c: Update.
7635         * python/py-framefilter.c: Update.
7636         * python/py-gdb-readline.c: Update.
7637         * python/py-inferior.c: Update.
7638         * python/py-infthread.c: Update.
7639         * python/py-lazy-string.c: Update.
7640         * python/py-linetable.c: Update.
7641         * python/py-objfile.c: Update.
7642         * python/py-param.c: Update.
7643         * python/py-prettyprint.c: Update.
7644         * python/py-progspace.c: Update.
7645         * python/py-record-btrace.c: Update.
7646         * python/py-record.c: Update.
7647         * python/py-symbol.c: Update.
7648         * python/py-type.c: Update.
7649         * python/py-unwind.c: Update.
7650         * python/py-utils.c: Update.
7651         * python/py-value.c: Update.
7652         * python/python.c: Update.
7653         * record-btrace.c: Update.
7654         * record-full.c: Update.
7655         * remote-fileio.c: Update.
7656         * remote.c: Update.
7657         * riscv-tdep.c: Update.
7658         * rs6000-aix-tdep.c: Update.
7659         * rs6000-tdep.c: Update.
7660         * rust-exp.y: Update.
7661         * rust-lang.c: Update.
7662         * s390-tdep.c: Update.
7663         * selftest-arch.c: Update.
7664         * solib-dsbt.c: Update.
7665         * solib-frv.c: Update.
7666         * solib-spu.c: Update.
7667         * solib-svr4.c: Update.
7668         * solib.c: Update.
7669         * sparc64-linux-tdep.c: Update.
7670         * stack.c: Update.
7671         * symfile-mem.c: Update.
7672         * symmisc.c: Update.
7673         * target.c: Update.
7674         * thread.c: Update.
7675         * top.c: Update.
7676         * tracefile-tfile.c: Update.
7677         * tui/tui.c: Update.
7678         * typeprint.c: Update.
7679         * unittests/cli-utils-selftests.c: Update.
7680         * unittests/parse-connection-spec-selftests.c: Update.
7681         * valops.c: Update.
7682         * valprint.c: Update.
7683         * value.c: Update.
7684         * varobj.c: Update.
7685         * windows-nat.c: Update.
7686         * x86-linux-nat.c: Update.
7687         * xml-support.c: Update.
7688
7689 2019-04-08  Tom Tromey  <tom@tromey.com>
7690
7691         * xml-support.c: Use C++ exception handling.
7692         * x86-linux-nat.c: Use C++ exception handling.
7693         * windows-nat.c: Use C++ exception handling.
7694         * varobj.c: Use C++ exception handling.
7695         * value.c: Use C++ exception handling.
7696         * valprint.c: Use C++ exception handling.
7697         * valops.c: Use C++ exception handling.
7698         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7699         handling.
7700         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7701         * typeprint.c: Use C++ exception handling.
7702         * tui/tui.c: Use C++ exception handling.
7703         * tracefile-tfile.c: Use C++ exception handling.
7704         * top.c: Use C++ exception handling.
7705         * thread.c: Use C++ exception handling.
7706         * target.c: Use C++ exception handling.
7707         * symmisc.c: Use C++ exception handling.
7708         * symfile-mem.c: Use C++ exception handling.
7709         * stack.c: Use C++ exception handling.
7710         * sparc64-linux-tdep.c: Use C++ exception handling.
7711         * solib.c: Use C++ exception handling.
7712         * solib-svr4.c: Use C++ exception handling.
7713         * solib-spu.c: Use C++ exception handling.
7714         * solib-frv.c: Use C++ exception handling.
7715         * solib-dsbt.c: Use C++ exception handling.
7716         * selftest-arch.c: Use C++ exception handling.
7717         * s390-tdep.c: Use C++ exception handling.
7718         * rust-lang.c: Use C++ exception handling.
7719         * rust-exp.y: Use C++ exception handling.
7720         * rs6000-tdep.c: Use C++ exception handling.
7721         * rs6000-aix-tdep.c: Use C++ exception handling.
7722         * riscv-tdep.c: Use C++ exception handling.
7723         * remote.c: Use C++ exception handling.
7724         * remote-fileio.c: Use C++ exception handling.
7725         * record-full.c: Use C++ exception handling.
7726         * record-btrace.c: Use C++ exception handling.
7727         * python/python.c: Use C++ exception handling.
7728         * python/py-value.c: Use C++ exception handling.
7729         * python/py-utils.c: Use C++ exception handling.
7730         * python/py-unwind.c: Use C++ exception handling.
7731         * python/py-type.c: Use C++ exception handling.
7732         * python/py-symbol.c: Use C++ exception handling.
7733         * python/py-record.c: Use C++ exception handling.
7734         * python/py-record-btrace.c: Use C++ exception handling.
7735         * python/py-progspace.c: Use C++ exception handling.
7736         * python/py-prettyprint.c: Use C++ exception handling.
7737         * python/py-param.c: Use C++ exception handling.
7738         * python/py-objfile.c: Use C++ exception handling.
7739         * python/py-linetable.c: Use C++ exception handling.
7740         * python/py-lazy-string.c: Use C++ exception handling.
7741         * python/py-infthread.c: Use C++ exception handling.
7742         * python/py-inferior.c: Use C++ exception handling.
7743         * python/py-gdb-readline.c: Use C++ exception handling.
7744         * python/py-framefilter.c: Use C++ exception handling.
7745         * python/py-frame.c: Use C++ exception handling.
7746         * python/py-finishbreakpoint.c: Use C++ exception handling.
7747         * python/py-cmd.c: Use C++ exception handling.
7748         * python/py-breakpoint.c: Use C++ exception handling.
7749         * python/py-arch.c: Use C++ exception handling.
7750         * printcmd.c: Use C++ exception handling.
7751         * ppc-linux-tdep.c: Use C++ exception handling.
7752         * parse.c: Use C++ exception handling.
7753         * p-valprint.c: Use C++ exception handling.
7754         * objc-lang.c: Use C++ exception handling.
7755         * mi/mi-main.c: Use C++ exception handling.
7756         * mi/mi-interp.c: Use C++ exception handling.
7757         * mi/mi-cmd-stack.c: Use C++ exception handling.
7758         * mi/mi-cmd-break.c: Use C++ exception handling.
7759         * main.c: Use C++ exception handling.
7760         * linux-thread-db.c: Use C++ exception handling.
7761         * linux-tdep.c: Use C++ exception handling.
7762         * linux-nat.c: Use C++ exception handling.
7763         * linux-fork.c: Use C++ exception handling.
7764         * linespec.c: Use C++ exception handling.
7765         * language.c: Use C++ exception handling.
7766         * jit.c: Use C++ exception handling.
7767         * infrun.c: Use C++ exception handling.
7768         * infcmd.c: Use C++ exception handling.
7769         * infcall.c: Use C++ exception handling.
7770         * inf-loop.c: Use C++ exception handling.
7771         * i386-tdep.c: Use C++ exception handling.
7772         * i386-linux-tdep.c: Use C++ exception handling.
7773         * guile/scm-value.c: Use C++ exception handling.
7774         * guile/scm-type.c: Use C++ exception handling.
7775         * guile/scm-symtab.c: Use C++ exception handling.
7776         * guile/scm-symbol.c: Use C++ exception handling.
7777         * guile/scm-pretty-print.c: Use C++ exception handling.
7778         * guile/scm-ports.c: Use C++ exception handling.
7779         * guile/scm-param.c: Use C++ exception handling.
7780         * guile/scm-math.c: Use C++ exception handling.
7781         * guile/scm-lazy-string.c: Use C++ exception handling.
7782         * guile/scm-frame.c: Use C++ exception handling.
7783         * guile/scm-disasm.c: Use C++ exception handling.
7784         * guile/scm-cmd.c: Use C++ exception handling.
7785         * guile/scm-breakpoint.c: Use C++ exception handling.
7786         * guile/scm-block.c: Use C++ exception handling.
7787         * guile/guile-internal.h: Use C++ exception handling.
7788         * gnu-v3-abi.c: Use C++ exception handling.
7789         * gdbtypes.c: Use C++ exception handling.
7790         * frame.c: Use C++ exception handling.
7791         * frame-unwind.c: Use C++ exception handling.
7792         * fbsd-tdep.c: Use C++ exception handling.
7793         * f-valprint.c: Use C++ exception handling.
7794         * exec.c: Use C++ exception handling.
7795         * event-top.c: Use C++ exception handling.
7796         * event-loop.c: Use C++ exception handling.
7797         * eval.c: Use C++ exception handling.
7798         * dwarf2read.c: Use C++ exception handling.
7799         * dwarf2loc.c: Use C++ exception handling.
7800         * dwarf2-frame.c: Use C++ exception handling.
7801         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7802         * dwarf-index-write.c: Use C++ exception handling.
7803         * dwarf-index-cache.c: Use C++ exception handling.
7804         * dtrace-probe.c: Use C++ exception handling.
7805         * disasm-selftests.c: Use C++ exception handling.
7806         * darwin-nat.c: Use C++ exception handling.
7807         * cp-valprint.c: Use C++ exception handling.
7808         * cp-support.c: Use C++ exception handling.
7809         * cp-abi.c: Use C++ exception handling.
7810         * corelow.c: Use C++ exception handling.
7811         * completer.c: Use C++ exception handling.
7812         * compile/compile-object-run.c: Use C++ exception handling.
7813         * compile/compile-object-load.c: Use C++ exception handling.
7814         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7815         * compile/compile-c-symbols.c: Use C++ exception handling.
7816         * common/selftest.c: Use C++ exception handling.
7817         * common/new-op.c: Use C++ exception handling.
7818         * cli/cli-script.c: Use C++ exception handling.
7819         * cli/cli-interp.c: Use C++ exception handling.
7820         * cli/cli-cmds.c: Use C++ exception handling.
7821         * c-varobj.c: Use C++ exception handling.
7822         * btrace.c: Use C++ exception handling.
7823         * breakpoint.c: Use C++ exception handling.
7824         * break-catch-throw.c: Use C++ exception handling.
7825         * arch-utils.c: Use C++ exception handling.
7826         * amd64-tdep.c: Use C++ exception handling.
7827         * ada-valprint.c: Use C++ exception handling.
7828         * ada-typeprint.c: Use C++ exception handling.
7829         * ada-lang.c: Use C++ exception handling.
7830         * aarch64-tdep.c: Use C++ exception handling.
7831
7832 2019-04-08  Tom Tromey  <tom@tromey.com>
7833
7834         * xml-support.c (gdb_xml_parser::parse): Update.
7835         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7836         * value.c (show_convenience): Update.
7837         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7838         (test_parse_flags_qcs): Update.
7839         * thread.c (thr_try_catch_cmd): Update.
7840         * target.c (target_translate_tls_address): Update.
7841         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7842         (info_frame_command_core, frame_apply_command_count): Update.
7843         * rust-exp.y (rust_lex_exception_test): Update.
7844         * riscv-tdep.c (riscv_print_one_register_info): Update.
7845         * remote.c (remote_target::enable_btrace): Update.
7846         * record-btrace.c (record_btrace_enable_warn): Update.
7847         * python/py-utils.c (gdbpy_convert_exception): Update.
7848         * printcmd.c (do_one_display, print_variable_and_value): Update.
7849         * mi/mi-main.c (mi_print_exception): Update.
7850         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7851         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7852         * linux-nat.c (linux_nat_target::attach): Update.
7853         * linux-fork.c (class scoped_switch_fork_info): Update.
7854         * infrun.c (displaced_step_prepare): Update.
7855         * infcall.c (call_function_by_hand_dummy): Update.
7856         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7857         * gnu-v3-abi.c (print_one_vtable): Update.
7858         * frame.c (get_prev_frame_always): Update.
7859         * f-valprint.c (info_common_command_for_block): Update.
7860         * exec.c (try_open_exec_file): Update.
7861         * exceptions.c (print_exception, exception_print)
7862         (exception_fprintf, exception_print_same): Update.
7863         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7864         * dwarf-index-cache.c (index_cache::store)
7865         (index_cache::lookup_gdb_index): Update.
7866         * darwin-nat.c (maybe_cache_shell): Update.
7867         * cp-valprint.c (cp_print_value_fields): Update.
7868         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7869         (gcc_cplus_symbol_address): Update.
7870         * compile/compile-c-symbols.c (gcc_convert_symbol)
7871         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7872         * common/selftest.c: Update.
7873         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7874         a std::string.
7875         (exception_try_scope_entry, exception_try_scope_exit): Don't
7876         declare.
7877         (struct exception_try_scope): Remove.
7878         (TRY): Don't use exception_try_scope.
7879         (struct gdb_exception): Add constructor, operator=.
7880         <what>: New method.
7881         (struct gdb_exception_RETURN_MASK_ALL)
7882         (struct gdb_exception_RETURN_MASK_ERROR)
7883         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7884         (struct gdb_quit_bad_alloc): Update.
7885         * common/common-exceptions.c (exception_none): Change
7886         initializer.
7887         (struct catcher) <state, exception>: Initialize inline.
7888         <prev>: Remove member.
7889         (current_catcher): Remove.
7890         (catchers): New global.
7891         (exceptions_state_mc_init): Simplify.
7892         (catcher_pop): Remove.
7893         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7894         (try_scope_depth, exception_try_scope_entry)
7895         (exception_try_scope_exit): Remove.
7896         (throw_exception_sjlj): Update.
7897         (exception_messages, exception_messages_size): Remove.
7898         (throw_it): Simplify.
7899         (gdb_exception_sliced_copy): Remove.
7900         (throw_exception_cxx): Update.
7901         * cli/cli-script.c (script_from_file): Update.
7902         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7903         Update.
7904         * ada-valprint.c (ada_val_print): Update.
7905         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7906         (create_excep_cond_exprs): Update.
7907
7908 2019-04-08  Tom Tromey  <tom@tromey.com>
7909
7910         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7911         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7912         (TRY, CATCH, END_CATCH): Remove some definitions.
7913         * common/common-exceptions.c: Don't use GDB_XCPT.
7914         (catcher_list_size): Remove.
7915         (throw_exception, throw_it): Simplify.
7916
7917 2019-04-05  Tom Tromey  <tom@tromey.com>
7918
7919         Revert the header-sorting patch.
7920         * ft32-tdep.c: Revert.
7921         * frv-tdep.c: Revert.
7922         * frv-linux-tdep.c: Revert.
7923         * frame.c: Revert.
7924         * frame-unwind.c: Revert.
7925         * frame-base.c: Revert.
7926         * fork-child.c: Revert.
7927         * findvar.c: Revert.
7928         * findcmd.c: Revert.
7929         * filesystem.c: Revert.
7930         * filename-seen-cache.h: Revert.
7931         * filename-seen-cache.c: Revert.
7932         * fbsd-tdep.c: Revert.
7933         * fbsd-nat.h: Revert.
7934         * fbsd-nat.c: Revert.
7935         * f-valprint.c: Revert.
7936         * f-typeprint.c: Revert.
7937         * f-lang.c: Revert.
7938         * extension.h: Revert.
7939         * extension.c: Revert.
7940         * extension-priv.h: Revert.
7941         * expprint.c: Revert.
7942         * exec.h: Revert.
7943         * exec.c: Revert.
7944         * exceptions.c: Revert.
7945         * event-top.c: Revert.
7946         * event-loop.c: Revert.
7947         * eval.c: Revert.
7948         * elfread.c: Revert.
7949         * dwarf2read.h: Revert.
7950         * dwarf2read.c: Revert.
7951         * dwarf2loc.c: Revert.
7952         * dwarf2expr.h: Revert.
7953         * dwarf2expr.c: Revert.
7954         * dwarf2-frame.c: Revert.
7955         * dwarf2-frame-tailcall.c: Revert.
7956         * dwarf-index-write.h: Revert.
7957         * dwarf-index-write.c: Revert.
7958         * dwarf-index-common.c: Revert.
7959         * dwarf-index-cache.h: Revert.
7960         * dwarf-index-cache.c: Revert.
7961         * dummy-frame.c: Revert.
7962         * dtrace-probe.c: Revert.
7963         * disasm.h: Revert.
7964         * disasm.c: Revert.
7965         * disasm-selftests.c: Revert.
7966         * dictionary.c: Revert.
7967         * dicos-tdep.c: Revert.
7968         * demangle.c: Revert.
7969         * dcache.h: Revert.
7970         * dcache.c: Revert.
7971         * darwin-nat.h: Revert.
7972         * darwin-nat.c: Revert.
7973         * darwin-nat-info.c: Revert.
7974         * d-valprint.c: Revert.
7975         * d-namespace.c: Revert.
7976         * d-lang.c: Revert.
7977         * ctf.c: Revert.
7978         * csky-tdep.c: Revert.
7979         * csky-linux-tdep.c: Revert.
7980         * cris-tdep.c: Revert.
7981         * cris-linux-tdep.c: Revert.
7982         * cp-valprint.c: Revert.
7983         * cp-support.c: Revert.
7984         * cp-namespace.c: Revert.
7985         * cp-abi.c: Revert.
7986         * corelow.c: Revert.
7987         * corefile.c: Revert.
7988         * continuations.c: Revert.
7989         * completer.h: Revert.
7990         * completer.c: Revert.
7991         * complaints.c: Revert.
7992         * coffread.c: Revert.
7993         * coff-pe-read.c: Revert.
7994         * cli-out.h: Revert.
7995         * cli-out.c: Revert.
7996         * charset.c: Revert.
7997         * c-varobj.c: Revert.
7998         * c-valprint.c: Revert.
7999         * c-typeprint.c: Revert.
8000         * c-lang.c: Revert.
8001         * buildsym.c: Revert.
8002         * buildsym-legacy.c: Revert.
8003         * build-id.h: Revert.
8004         * build-id.c: Revert.
8005         * btrace.c: Revert.
8006         * bsd-uthread.c: Revert.
8007         * breakpoint.h: Revert.
8008         * breakpoint.c: Revert.
8009         * break-catch-throw.c: Revert.
8010         * break-catch-syscall.c: Revert.
8011         * break-catch-sig.c: Revert.
8012         * blockframe.c: Revert.
8013         * block.c: Revert.
8014         * bfin-tdep.c: Revert.
8015         * bfin-linux-tdep.c: Revert.
8016         * bfd-target.c: Revert.
8017         * bcache.c: Revert.
8018         * ax-general.c: Revert.
8019         * ax-gdb.h: Revert.
8020         * ax-gdb.c: Revert.
8021         * avr-tdep.c: Revert.
8022         * auxv.c: Revert.
8023         * auto-load.c: Revert.
8024         * arm-wince-tdep.c: Revert.
8025         * arm-tdep.c: Revert.
8026         * arm-symbian-tdep.c: Revert.
8027         * arm-pikeos-tdep.c: Revert.
8028         * arm-obsd-tdep.c: Revert.
8029         * arm-nbsd-tdep.c: Revert.
8030         * arm-nbsd-nat.c: Revert.
8031         * arm-linux-tdep.c: Revert.
8032         * arm-linux-nat.c: Revert.
8033         * arm-fbsd-tdep.c: Revert.
8034         * arm-fbsd-nat.c: Revert.
8035         * arm-bsd-tdep.c: Revert.
8036         * arch-utils.c: Revert.
8037         * arc-tdep.c: Revert.
8038         * arc-newlib-tdep.c: Revert.
8039         * annotate.h: Revert.
8040         * annotate.c: Revert.
8041         * amd64-windows-tdep.c: Revert.
8042         * amd64-windows-nat.c: Revert.
8043         * amd64-tdep.c: Revert.
8044         * amd64-sol2-tdep.c: Revert.
8045         * amd64-obsd-tdep.c: Revert.
8046         * amd64-obsd-nat.c: Revert.
8047         * amd64-nbsd-tdep.c: Revert.
8048         * amd64-nbsd-nat.c: Revert.
8049         * amd64-nat.c: Revert.
8050         * amd64-linux-tdep.c: Revert.
8051         * amd64-linux-nat.c: Revert.
8052         * amd64-fbsd-tdep.c: Revert.
8053         * amd64-fbsd-nat.c: Revert.
8054         * amd64-dicos-tdep.c: Revert.
8055         * amd64-darwin-tdep.c: Revert.
8056         * amd64-bsd-nat.c: Revert.
8057         * alpha-tdep.c: Revert.
8058         * alpha-obsd-tdep.c: Revert.
8059         * alpha-nbsd-tdep.c: Revert.
8060         * alpha-mdebug-tdep.c: Revert.
8061         * alpha-linux-tdep.c: Revert.
8062         * alpha-linux-nat.c: Revert.
8063         * alpha-bsd-tdep.c: Revert.
8064         * alpha-bsd-nat.c: Revert.
8065         * aix-thread.c: Revert.
8066         * agent.c: Revert.
8067         * addrmap.c: Revert.
8068         * ada-varobj.c: Revert.
8069         * ada-valprint.c: Revert.
8070         * ada-typeprint.c: Revert.
8071         * ada-tasks.c: Revert.
8072         * ada-lang.c: Revert.
8073         * aarch64-tdep.c: Revert.
8074         * aarch64-ravenscar-thread.c: Revert.
8075         * aarch64-newlib-tdep.c: Revert.
8076         * aarch64-linux-tdep.c: Revert.
8077         * aarch64-linux-nat.c: Revert.
8078         * aarch64-fbsd-tdep.c: Revert.
8079         * aarch64-fbsd-nat.c: Revert.
8080         * aarch32-linux-nat.c: Revert.
8081
8082 2019-04-05  Tom Tromey  <tom@tromey.com>
8083
8084         * ft32-tdep.c: Sort headers.
8085         * frv-tdep.c: Sort headers.
8086         * frv-linux-tdep.c: Sort headers.
8087         * frame.c: Sort headers.
8088         * frame-unwind.c: Sort headers.
8089         * frame-base.c: Sort headers.
8090         * fork-child.c: Sort headers.
8091         * findvar.c: Sort headers.
8092         * findcmd.c: Sort headers.
8093         * filesystem.c: Sort headers.
8094         * filename-seen-cache.h: Sort headers.
8095         * filename-seen-cache.c: Sort headers.
8096         * fbsd-tdep.c: Sort headers.
8097         * fbsd-nat.h: Sort headers.
8098         * fbsd-nat.c: Sort headers.
8099         * f-valprint.c: Sort headers.
8100         * f-typeprint.c: Sort headers.
8101         * f-lang.c: Sort headers.
8102         * extension.h: Sort headers.
8103         * extension.c: Sort headers.
8104         * extension-priv.h: Sort headers.
8105         * expprint.c: Sort headers.
8106         * exec.h: Sort headers.
8107         * exec.c: Sort headers.
8108         * exceptions.c: Sort headers.
8109         * event-top.c: Sort headers.
8110         * event-loop.c: Sort headers.
8111         * eval.c: Sort headers.
8112         * elfread.c: Sort headers.
8113         * dwarf2read.h: Sort headers.
8114         * dwarf2read.c: Sort headers.
8115         * dwarf2loc.c: Sort headers.
8116         * dwarf2expr.h: Sort headers.
8117         * dwarf2expr.c: Sort headers.
8118         * dwarf2-frame.c: Sort headers.
8119         * dwarf2-frame-tailcall.c: Sort headers.
8120         * dwarf-index-write.h: Sort headers.
8121         * dwarf-index-write.c: Sort headers.
8122         * dwarf-index-common.c: Sort headers.
8123         * dwarf-index-cache.h: Sort headers.
8124         * dwarf-index-cache.c: Sort headers.
8125         * dummy-frame.c: Sort headers.
8126         * dtrace-probe.c: Sort headers.
8127         * disasm.h: Sort headers.
8128         * disasm.c: Sort headers.
8129         * disasm-selftests.c: Sort headers.
8130         * dictionary.c: Sort headers.
8131         * dicos-tdep.c: Sort headers.
8132         * demangle.c: Sort headers.
8133         * dcache.h: Sort headers.
8134         * dcache.c: Sort headers.
8135         * darwin-nat.h: Sort headers.
8136         * darwin-nat.c: Sort headers.
8137         * darwin-nat-info.c: Sort headers.
8138         * d-valprint.c: Sort headers.
8139         * d-namespace.c: Sort headers.
8140         * d-lang.c: Sort headers.
8141         * ctf.c: Sort headers.
8142         * csky-tdep.c: Sort headers.
8143         * csky-linux-tdep.c: Sort headers.
8144         * cris-tdep.c: Sort headers.
8145         * cris-linux-tdep.c: Sort headers.
8146         * cp-valprint.c: Sort headers.
8147         * cp-support.c: Sort headers.
8148         * cp-namespace.c: Sort headers.
8149         * cp-abi.c: Sort headers.
8150         * corelow.c: Sort headers.
8151         * corefile.c: Sort headers.
8152         * continuations.c: Sort headers.
8153         * completer.h: Sort headers.
8154         * completer.c: Sort headers.
8155         * complaints.c: Sort headers.
8156         * coffread.c: Sort headers.
8157         * coff-pe-read.c: Sort headers.
8158         * cli-out.h: Sort headers.
8159         * cli-out.c: Sort headers.
8160         * charset.c: Sort headers.
8161         * c-varobj.c: Sort headers.
8162         * c-valprint.c: Sort headers.
8163         * c-typeprint.c: Sort headers.
8164         * c-lang.c: Sort headers.
8165         * buildsym.c: Sort headers.
8166         * buildsym-legacy.c: Sort headers.
8167         * build-id.h: Sort headers.
8168         * build-id.c: Sort headers.
8169         * btrace.c: Sort headers.
8170         * bsd-uthread.c: Sort headers.
8171         * breakpoint.h: Sort headers.
8172         * breakpoint.c: Sort headers.
8173         * break-catch-throw.c: Sort headers.
8174         * break-catch-syscall.c: Sort headers.
8175         * break-catch-sig.c: Sort headers.
8176         * blockframe.c: Sort headers.
8177         * block.c: Sort headers.
8178         * bfin-tdep.c: Sort headers.
8179         * bfin-linux-tdep.c: Sort headers.
8180         * bfd-target.c: Sort headers.
8181         * bcache.c: Sort headers.
8182         * ax-general.c: Sort headers.
8183         * ax-gdb.h: Sort headers.
8184         * ax-gdb.c: Sort headers.
8185         * avr-tdep.c: Sort headers.
8186         * auxv.c: Sort headers.
8187         * auto-load.c: Sort headers.
8188         * arm-wince-tdep.c: Sort headers.
8189         * arm-tdep.c: Sort headers.
8190         * arm-symbian-tdep.c: Sort headers.
8191         * arm-pikeos-tdep.c: Sort headers.
8192         * arm-obsd-tdep.c: Sort headers.
8193         * arm-nbsd-tdep.c: Sort headers.
8194         * arm-nbsd-nat.c: Sort headers.
8195         * arm-linux-tdep.c: Sort headers.
8196         * arm-linux-nat.c: Sort headers.
8197         * arm-fbsd-tdep.c: Sort headers.
8198         * arm-fbsd-nat.c: Sort headers.
8199         * arm-bsd-tdep.c: Sort headers.
8200         * arch-utils.c: Sort headers.
8201         * arc-tdep.c: Sort headers.
8202         * arc-newlib-tdep.c: Sort headers.
8203         * annotate.h: Sort headers.
8204         * annotate.c: Sort headers.
8205         * amd64-windows-tdep.c: Sort headers.
8206         * amd64-windows-nat.c: Sort headers.
8207         * amd64-tdep.c: Sort headers.
8208         * amd64-sol2-tdep.c: Sort headers.
8209         * amd64-obsd-tdep.c: Sort headers.
8210         * amd64-obsd-nat.c: Sort headers.
8211         * amd64-nbsd-tdep.c: Sort headers.
8212         * amd64-nbsd-nat.c: Sort headers.
8213         * amd64-nat.c: Sort headers.
8214         * amd64-linux-tdep.c: Sort headers.
8215         * amd64-linux-nat.c: Sort headers.
8216         * amd64-fbsd-tdep.c: Sort headers.
8217         * amd64-fbsd-nat.c: Sort headers.
8218         * amd64-dicos-tdep.c: Sort headers.
8219         * amd64-darwin-tdep.c: Sort headers.
8220         * amd64-bsd-nat.c: Sort headers.
8221         * alpha-tdep.c: Sort headers.
8222         * alpha-obsd-tdep.c: Sort headers.
8223         * alpha-nbsd-tdep.c: Sort headers.
8224         * alpha-mdebug-tdep.c: Sort headers.
8225         * alpha-linux-tdep.c: Sort headers.
8226         * alpha-linux-nat.c: Sort headers.
8227         * alpha-bsd-tdep.c: Sort headers.
8228         * alpha-bsd-nat.c: Sort headers.
8229         * aix-thread.c: Sort headers.
8230         * agent.c: Sort headers.
8231         * addrmap.c: Sort headers.
8232         * ada-varobj.c: Sort headers.
8233         * ada-valprint.c: Sort headers.
8234         * ada-typeprint.c: Sort headers.
8235         * ada-tasks.c: Sort headers.
8236         * ada-lang.c: Sort headers.
8237         * aarch64-tdep.c: Sort headers.
8238         * aarch64-ravenscar-thread.c: Sort headers.
8239         * aarch64-newlib-tdep.c: Sort headers.
8240         * aarch64-linux-tdep.c: Sort headers.
8241         * aarch64-linux-nat.c: Sort headers.
8242         * aarch64-fbsd-tdep.c: Sort headers.
8243         * aarch64-fbsd-nat.c: Sort headers.
8244         * aarch32-linux-nat.c: Sort headers.
8245
8246 2019-04-04  Tom Tromey  <tom@tromey.com>
8247
8248         * varobj.c (varobj_create): Update.
8249         * rust-exp.y (struct rust_parser) <update_innermost_block,
8250         lookup_symbol>: New methods.
8251         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8252         Rename.
8253         (rust_parser::rust_lookup_type)
8254         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8255         * printcmd.c (display_command, do_one_display): Update.
8256         * parser-defs.h (struct parser_state) <parser_state>: Add
8257         "tracker" parameter.
8258         (block_tracker): New member.
8259         (class innermost_block_tracker) <innermost_block_tracker>: Add
8260         "types" parameter.
8261         <reset>: Remove method.
8262         (innermost_block): Don't declare.
8263         (null_post_parser): Update.
8264         * parse.c (innermost_block): Remove global.
8265         (write_dollar_variable): Update.
8266         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8267         Remove "tracker_types" parameter.
8268         (parse_expression): Add "tracker" parameter.
8269         (parse_expression_for_completion): Update.
8270         (null_post_parser): Add "tracker" parameter.
8271         * p-exp.y: Update rules.
8272         * m2-exp.y: Update rules.
8273         * language.h (struct language_defn) <la_post_parser>: Add
8274         "tracker" parameter.
8275         * go-exp.y: Update rules.
8276         * f-exp.y: Update rules.
8277         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8278         parameter.
8279         * d-exp.y: Update rules.
8280         * c-exp.y: Update rules.
8281         * breakpoint.c (set_breakpoint_condition): Create an
8282         innermost_block_tracker.
8283         (watch_command_1): Likewise.
8284         * ada-lang.c (resolve): Add "tracker" parameter.
8285         (resolve_subexp): Likewise.
8286         * ada-exp.y (write_var_from_sym): Update.
8287
8288 2019-04-04  Tom Tromey  <tom@tromey.com>
8289
8290         * type-stack.h: New file.
8291         * type-stack.c: New file.
8292         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8293         type-stack.h.
8294         (insert_into_type_stack, insert_type, push_type, push_type_int)
8295         (insert_type_address_space, pop_type, pop_type_int)
8296         (pop_typelist, pop_type_stack, append_type_stack)
8297         (push_type_stack, get_type_stack, push_typelist)
8298         (follow_type_instance_flags, follow_types): Don't declare.
8299         * parse.c (type_stack): Remove global.
8300         (parse_exp_in_context): Update.
8301         (insert_into_type_stack, insert_type, push_type, push_type_int)
8302         (insert_type_address_space, pop_type, pop_type_int)
8303         (pop_typelist, pop_type_stack, append_type_stack)
8304         (push_type_stack, get_type_stack, push_typelist)
8305         (follow_type_instance_flags, follow_types): Remove (moved to
8306         type-stack.c).
8307         * f-exp.y (type_stack): New global.
8308         Update rules.
8309         (push_kind_type, f_parse): Update.
8310         * d-exp.y (type_stack): New global.
8311         Update rules.
8312         (d_parse): Update.
8313         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8314         Update rules.
8315         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8316         (HFILES_NO_SRCDIR): Add type-stack.h.
8317
8318 2019-04-04  Tom Tromey  <tom@tromey.com>
8319
8320         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8321         (rust_parser::convert_ast_to_expression, rust_parse)
8322         (rust_lex_test_completion, rust_lex_tests): Update.
8323         * parser-defs.h (struct expr_completion_state): New.
8324         (struct parser_state) <parser_state>: Add completion parameter.
8325         <mark_struct_expression, mark_completion_tag>: New methods.
8326         <parse_completion, m_completion_state>: New members.
8327         (prefixify_expression, null_post_parser): Update.
8328         (mark_struct_expression, mark_completion_tag): Don't declare.
8329         * parse.c (parse_completion, expout_last_struct)
8330         (expout_tag_completion_type, expout_completion_name): Remove
8331         globals.
8332         (parser_state::mark_struct_expression)
8333         (parser_state::mark_completion_tag): Now methods.
8334         (prefixify_expression): Add last_struct parameter.
8335         (prefixify_subexp): Likewise.
8336         (parse_exp_1): Update.
8337         (parse_exp_in_context): Add cstate parameter.  Update.
8338         (parse_expression_for_completion): Create an
8339         expr_completion_state.
8340         (null_post_parser): Add "completion" parameter.
8341         * p-exp.y: Update rules.
8342         (yylex): Update.
8343         * language.h (struct language_defn) <la_post_parser>: Add
8344         "completing" parameter.
8345         * go-exp.y: Update rules.
8346         (lex_one_token): Update.
8347         * expression.h (parse_completion): Don't declare.
8348         * d-exp.y: Update rules.
8349         (lex_one_token): Update rules.
8350         * c-exp.y: Update rules.
8351         (lex_one_token): Update.
8352         * ada-lang.c (resolve): Add "parse_completion" parameter.
8353         (resolve_subexp): Likewise.
8354         (ada_resolve_function): Likewise.
8355
8356 2019-04-04  Tom Tromey  <tom@tromey.com>
8357
8358         * parser-defs.h (struct parser_state) <start_arglist,
8359         end_arglist>: New methods.
8360         <arglist_len, m_funcall_chain>: New members.
8361         (arglist_len, start_arglist, end_arglist): Don't declare.
8362         * parse.c (arglist_len, funcall_chain): Remove global.
8363         (start_arglist, end_arglist): Remove functions.
8364         (parse_exp_in_context): Update.
8365         * p-exp.y: Update rules.
8366         * m2-exp.y: Update rules.
8367         * go-exp.y: Update rules.
8368         * f-exp.y: Update rules.
8369         * d-exp.y: Update rules.
8370         * c-exp.y: Update rules.
8371
8372 2019-04-04  Tom Tromey  <tom@tromey.com>
8373
8374         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8375         lex_operator, push_back>: New methods.
8376         Update all rules.
8377         (rust_parser::lex_hex, lex_escape): Rename and update.
8378         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8379         (rust_parser::lex_operator): Rename and update.
8380         (rust_parser::lex_number, rustyylex, rustyyerror)
8381         (rust_lex_test_init, rust_lex_test_sequence)
8382         (rust_lex_test_push_back, rust_lex_tests): Update.
8383         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8384         parameter.
8385         <lexptr, prev_lexptr>: New members.
8386         (lexptr, prev_lexptr): Don't declare.
8387         * parse.c (lexptr, prev_lexptr): Remove globals.
8388         (parse_exp_in_context): Update.
8389         * p-exp.y (yylex, yyerror): Update.
8390         * m2-exp.y (parse_number, yylex, yyerror): Update.
8391         * go-exp.y (lex_one_token, yyerror): Update.
8392         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8393         * d-exp.y (lex_one_token, yyerror): Update.
8394         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8395         (lex_one_token, yyerror): Update.
8396         * ada-lex.l (YY_INPUT): Update.
8397         (rewind_to_char): Update.
8398         * ada-exp.y (yyerror): Update.
8399
8400 2019-04-04  Tom Tromey  <tom@tromey.com>
8401
8402         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8403         * parser-defs.h (struct parser_state) <parser_state>: Add new
8404         parameter.
8405         <comma_terminates>: New member.
8406         (comma_terminates): Don't declare global.
8407         * parse.c (comma_terminates): Remove global.
8408         (parse_exp_in_context): Update.
8409         * p-exp.y (yylex): Update.
8410         * m2-exp.y (yylex): Update.
8411         * go-exp.y (lex_one_token): Update.
8412         * f-exp.y (yylex): Update.
8413         * d-exp.y (lex_one_token): Update.
8414         * c-exp.y (lex_one_token): Update.
8415         * ada-lex.l: Update.
8416
8417 2019-04-04  Tom Tromey  <tom@tromey.com>
8418
8419         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8420         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8421         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8422         * parser-defs.h (paren_depth): Don't declare.
8423         * parse.c (paren_depth): Remove global.
8424         (parse_exp_in_context): Update.
8425         * p-exp.y (paren_depth): New global.
8426         (pascal_parse): Initialize it.
8427         * m2-exp.y (paren_depth): New global.
8428         (m2_parse): Initialize it.
8429         * go-exp.y (paren_depth): New global.
8430         (go_parse): Initialize it.
8431         * f-exp.y (paren_depth): New global.
8432         (f_parse): Initialize it.
8433         * d-exp.y (paren_depth): New global.
8434         (d_parse): Initialize it.
8435         * c-exp.y (paren_depth): New global.
8436         (c_parse): Initialize it.
8437         * ada-lex.l (paren_depth): New global.
8438         (lexer_init): Initialize it.
8439
8440 2019-04-04  Tom Tromey  <tom@tromey.com>
8441
8442         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8443         (rust_parser::convert_ast_to_type)
8444         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8445         * parser-defs.h (struct parser_state) <parser_state>: Add
8446         parameters.  Initialize new members.
8447         <expression_context_block, expression_context_pc>: New members.
8448         * parse.c (expression_context_block, expression_context_pc):
8449         Remove globals.
8450         (parse_exp_in_context): Update.
8451         * p-exp.y: Update all rules.
8452         (yylex): Update.
8453         * m2-exp.y: Update all rules.
8454         (yylex): Update.
8455         * go-exp.y (yylex): Update.
8456         * f-exp.y (yylex): Update.
8457         * d-exp.y: Update all rules.
8458         (yylex): Update.
8459         * c-exp.y: Update all rules.
8460         (lex_one_token, classify_name, yylex, c_parse): Update.
8461         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8462
8463 2019-04-04  Tom Tromey  <tom@tromey.com>
8464
8465         * gdbarch.h, gdbarch.c: Rebuild.
8466         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8467         * stap-probe.h:
8468         (struct stap_parse_info): Replace "parser_state" with
8469         "expr_builder".
8470         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8471         (parser_state): New class.
8472         * parse.c (expr_builder): Rename.
8473         (expr_builder::release): Rename.
8474         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8475         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8476         (write_exp_elt_longcst, write_exp_elt_floatcst)
8477         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8478         (write_exp_string_vector, write_exp_bitstring)
8479         (write_exp_msymbol, mark_struct_expression)
8480         (write_dollar_variable)
8481         (insert_type_address_space, increase_expout_size): Replace
8482         "parser_state" with "expr_builder".
8483         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8484         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8485         "parser_state" with "expr_builder".
8486
8487 2019-04-04  Tom Tromey  <tom@tromey.com>
8488
8489         * rust-exp.y: Replace "parse_language" with method call.
8490         * p-exp.y:
8491         (yylex): Replace "parse_language" with method call.
8492         * m2-exp.y:
8493         (yylex): Replace "parse_language" with method call.
8494         * go-exp.y (classify_name): Replace "parse_language" with method
8495         call.
8496         * f-exp.y (yylex): Replace "parse_language" with method call.
8497         * d-exp.y (lex_one_token): Replace "parse_language" with method
8498         call.
8499         * c-exp.y:
8500         (lex_one_token, classify_name, yylex): Replace "parse_language"
8501         with method call.
8502         * ada-exp.y (find_primitive_type, type_char)
8503         (type_system_address): Replace "parse_language" with method call.
8504
8505 2019-04-04  Tom Tromey  <tom@tromey.com>
8506
8507         * rust-exp.y: Replace "parse_gdbarch" with method call.
8508         * parse.c (write_dollar_variable, insert_type_address_space):
8509         Replace "parse_gdbarch" with method call.
8510         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8511         call.
8512         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8513         call.
8514         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8515         "parse_gdbarch" with method call.
8516         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8517         with method call.
8518         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8519         "parse_gdbarch" with method call.
8520         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8521         "parse_gdbarch" with method call.
8522         * c-exp.y (parse_type, parse_number, classify_name): Replace
8523         "parse_gdbarch" with method call.
8524         * ada-lex.l: Replace "parse_gdbarch" with method call.
8525         * ada-exp.y (parse_type, find_primitive_type, type_char)
8526         (type_system_address): Replace "parse_gdbarch" with method call.
8527
8528 2019-04-04  Tom Tromey  <tom@tromey.com>
8529
8530         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8531         * stap-probe.c (stap_parse_argument): Update.
8532         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8533         initial_size parameter.
8534         * rust-exp.y (rust_lex_tests): Update.
8535         * parse.c (parser_state): Update.
8536         (parse_exp_in_context): Update.
8537         * parser-defs.h (struct parser_state) <parser_state>: Remove
8538         "initial_size" parameter.
8539
8540 2019-04-04  Tom Tromey  <tom@tromey.com>
8541
8542         * parser-defs.h (increase_expout_size): Don't declare.
8543         * parse.c (increase_expout_size): Now static.
8544
8545 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8546
8547         * gnu-nat.c (gnu_nat_target::wait): Fix
8548         target_waitstatus_to_string call.
8549
8550 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8551
8552         * eval.c (evaluate_subexp_standard): Handle internal functions
8553         during Fortran function call handling.
8554
8555 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * NEWS: Mention new internal functions.
8558         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8559         (read_base_type): Use dwarf2_init_complex_target_type.
8560         * value.c (creal_internal_fn): New function.
8561         (cimag_internal_fn): New function.
8562         (_initialize_values): Register new internal functions.
8563
8564 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8565
8566         * infrun.c (stop_all_threads): If debug_infrun, always
8567         trace the wait status after wait_one, using
8568         target_waitstatus_to_string and target_pid_to_str.
8569         (handle_inferior_event): Replace various trace of
8570         wait status kind by a single trace.
8571         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8572         wait status kind image by target_waitstatus_to_string.
8573         * target/waitstatus.c (target_waitstatus_to_string): Fix
8574         obsolete comment.
8575
8576 2019-04-01  Tom Tromey  <tromey@adacore.com>
8577
8578         PR symtab/23331:
8579         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8580
8581 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8582             Pedro Alves  <palves@redhat.com>
8583
8584         * top.c (quit_force): Call 'finalize_values'.
8585         * value.c (finalize_values): New function.
8586         * value.h (finalize_values): Declare.
8587
8588 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8589
8590         * NEWS: Announce $_gdb_major and $_gdb_minor.
8591
8592         * top.c (init_gdb_version_vars): New function.
8593         (gdb_init): Call init_gdb_version_vars.
8594
8595 2019-03-29  Tom Tromey  <tromey@adacore.com>
8596
8597         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8598         help text.  Remove dead code.
8599
8600 2019-03-29  Keith Seitz  <keiths@redhat.com>
8601
8602         From Siddhesh Poyarekar:
8603         * f-lang.h (f77_get_upperbound): Return LONGEST.
8604         (f77_get_lowerbound): Likewise.
8605         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8606         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8607         print them.
8608         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8609         plongest to format print it.
8610         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8611         (f77_get_upperbound): Likewise.
8612         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8613         LOWER_BOUND to LONGEST.
8614         (f77_create_arrayprint_offset_tbl): Likewise.
8615
8616 2019-03-29  Keith Seitz  <keiths@redhat.com>
8617
8618         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8619         %s/pulongest for TYPE_LENGTH instead of %d in format
8620         strings.
8621         * ada-typerint.c (ada_print_type): Likewise.
8622         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8623         * compile/compile-c-support.c (generate_register_struct): Likewise.
8624         * gdbtypes.c (recursive_dump_type): Likewise.
8625         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8626         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8627         instead of %d in format strings.
8628         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8629         to std::min to ULONGEST.
8630         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8631         instead of %d in format strings.
8632         * tracepoint.c (info_scope_command): Likewise.
8633         * typeprint.c (print_offset_data::update)
8634         (print_offset_data::finish): Likewise.
8635         * xtensa-tdep.c (xtensa_store_return_value)
8636         (xtensa_push_dummy_call): Likewise.
8637
8638 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8639
8640         * windows-nat.c (display_selector): Fixed format specifications
8641         for 64-bit Cygwin.
8642
8643 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8644
8645         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8646
8647 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8648
8649         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8650         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8651         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8652         (nios2_linux_init_abi): Install it.
8653
8654 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8655
8656         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8657
8658 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8659
8660         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8661
8662 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8663             Tom Tromey  <tromey@adacore.com>
8664
8665         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8666
8667 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8668
8669         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8670         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8671         method to compute the bounds of range types. Also print "[evaluated]"
8672         if the bounds' values come from a dynamic evaluation.
8673
8674 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8675
8676         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8677         whitespace when pretty printing is on.
8678
8679 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8680
8681         * ppc-linux-nat.c: Add include.
8682
8683 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8684
8685         * NEWS: Mention AArch64 Pointer Authentication.
8686
8687 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8688
8689         * arm-linux-nat.c: Add include.
8690
8691 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8692
8693         * source-cache.c (source_cache::get_source_lines): Re-read
8694         fullname after calling open_source_file.
8695
8696 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8697
8698         * NEWS: Mention TLS support for FreeBSD.
8699
8700 2019-03-25  Tom Tromey  <tromey@adacore.com>
8701
8702         * minsyms.c (BUNCH_SIZE): Update comment.
8703         (~minimal_symbol_reader): Remove old comment.
8704         (compact_minimal_symbols): Update comment.
8705         (minimal_symbol_reader::install): Remove old comment.  Update
8706         other comments.
8707
8708 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8709
8710         * s390-linux-nat.c: Add include.
8711
8712 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8713
8714         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8715         Call linux_get_hwcap.
8716         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8717         Likewise.
8718         (aarch64_linux_get_hwcap): Remove function.
8719         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8720         declaration.
8721         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8722         linux_get_hwcap.
8723         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8724         * linux-tdep.c (linux_get_hwcap): Add function.
8725         (linux_get_hwcap2): Likewise.
8726         * linux-tdep.h (linux_get_hwcap): Add declaration.
8727         (linux_get_hwcap2): Likewise.
8728         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8729         (ppc_linux_get_hwcap2): Likewise.
8730         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8731         linux_get_hwcap.
8732         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8733         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8734         (ppc_linux_nat_target::read_description): Likewise.
8735         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8736         * s390-linux-nat.c: Likewise.
8737         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8738
8739 2019-03-24  Tom Tromey  <tom@tromey.com>
8740
8741         * ada-lang.c (standard_lookup): Simplify initialization.
8742         (ada_lookup_symbol_nonlocal): Simplify return.
8743         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8744         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8745         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8746         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8747         initialization.
8748         * solib.c (solib_global_lookup): Simplify.
8749         * symtab.c (null_block_symbol): Remove.
8750         (symbol_cache_lookup): Simplify returns.
8751         (lookup_language_this): Simplify returns.
8752         (lookup_symbol_aux): Simplify return.
8753         (lookup_local_symbol): Simplify returns.
8754         (lookup_global_symbol_from_objfile): Simplify return.
8755         (lookup_symbol_in_objfile_symtabs)
8756         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8757         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8758         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8759         * cp-namespace.c (cp_lookup_bare_symbol)
8760         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8761         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8762         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8763         (cp_lookup_symbol_via_imports): Simplify initialization.
8764         (find_symbol_in_baseclass): Likewise.
8765         * symtab.h (null_block_symbol): Remove.
8766         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8767         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8768         (d_lookup_symbol_module): Likewise.
8769         (find_symbol_in_baseclass): Simplify initialization.
8770
8771 2019-03-24  Tom Tromey  <tom@tromey.com>
8772
8773         * expression.h: Don't include symtab.h.
8774         (struct block): Forward declare.
8775
8776 2019-03-24  Tom Tromey  <tom@tromey.com>
8777
8778         * c-exp.y (typebase): Remove casts.
8779         * gdbtypes.c (lookup_unsigned_typename, )
8780         (lookup_signed_typename): Remove cast.
8781         * eval.c (parse_to_comma_and_eval): Remove cast.
8782         * parse.c (write_dollar_variable): Remove cast.
8783         * block.h (struct block) <superblock>: Now const.
8784         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8785         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8786         (map_block): Make "block" const.
8787         * symfile.h (struct quick_symbol_functions)
8788         <map_matching_symbols>: Constify block argument to "callback".
8789         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8790         const.
8791         (find_pc_sect_compunit_symtab): Make "b" const.
8792         (find_symbol_at_address): Likewise.
8793         (search_symbols): Likewise.
8794         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8795         (dw2_debug_names_lookup_symbol): Likewise.
8796         (dw2_map_matching_symbols): Update.
8797         * p-valprint.c (pascal_val_print): Remove "block".
8798         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8799         (aux_add_nonlocal_symbols): Make "block" const.
8800         (resolve_subexp): Remove cast.
8801         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8802         const.
8803         (iterate_over_file_blocks): Likewise.
8804         * f-exp.y (%union) <bval>: Remove.
8805         * coffread.c (patch_opaque_types): Make "b" const.
8806         * spu-tdep.c (spu_catch_start): Make "block" const.
8807         * c-valprint.c (print_unpacked_pointer): Remove "block".
8808         * symmisc.c (dump_symtab_1): Make "b" const.
8809         (block_depth): Make "block" const.
8810         * d-exp.y (%union) <bval>: Remove.
8811         * cp-support.h (cp_lookup_rtti_type): Update.
8812         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8813         * psymtab.c (psym_lookup_symbol): Make "block" const.
8814         (maintenance_check_psymtabs): Make "b" const.
8815         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8816         (enumerate_locals, enumerate_args): Update.
8817         * python/py-symtab.c (stpy_global_block): Make "block" const.
8818         (stpy_static_block): Likewise.
8819         * inline-frame.c (block_starting_point_at): Make "new_block"
8820         const.
8821         * block.c (find_block_in_blockvector): Make return type const.
8822         (blockvector_for_pc_sect): Make "b" const.
8823         (find_block_in_blockvector): Make "b" const.
8824
8825 2019-03-23  Tom Tromey  <tom@tromey.com>
8826
8827         * varobj.c (varobj_create): Update.
8828         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8829         * printcmd.c (display_command, do_one_display): Don't reset
8830         innermost_block.
8831         * parser-defs.h (enum innermost_block_tracker_type): Move to
8832         expression.h.
8833         (innermost_block): Update comment.
8834         * parse.c (parse_exp_1): Add tracker_types parameter.
8835         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8836         tracker_types parameter.  Reset innermost_block.
8837         (parse_exp_in_context): Remove.
8838         (parse_expression_for_completion): Update.
8839         * objfiles.c (~objfile): Don't reset expression_context_block or
8840         innermost_block.
8841         * expression.h (enum innermost_block_tracker_type): Move from
8842         parser-defs.h.
8843         (parse_exp_1): Add tracker_types parameter.
8844         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8845         reset innermost_block.
8846
8847 2019-03-23  Tom Tromey  <tom@tromey.com>
8848
8849         * objfiles.h: Include bcache.h.
8850
8851 2019-03-23  Tom Tromey  <tom@tromey.com>
8852
8853         * linespec.c (get_current_search_block): Use
8854         scoped_restore_current_language.
8855         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8856
8857 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8858             Jiong Wang  <jiong.wang@arm.com>
8859
8860         * aarch64-linux-tdep.c
8861         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8862         section.
8863         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8864
8865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8866             Jiong Wang  <jiong.wang@arm.com>
8867
8868         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8869         instructions.
8870         (aarch64_analyze_prologue_test): Add PACIASP test.
8871         (aarch64_prologue_prev_register): Unmask PC value.
8872
8873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8874             Jiong Wang  <jiong.wang@arm.com>
8875
8876         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8877         (aarch64_dwarf2_prev_register): Unmask PC value.
8878         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8879         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8880         DW_CFA_AARCH64_negate_ra_state.
8881         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8882
8883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8884             Jiong Wang  <jiong.wang@arm.com>
8885
8886         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8887         registers.
8888         (aarch64_pseudo_register_name): Likewise.
8889         (aarch64_pseudo_register_type): Likewise.
8890         (aarch64_pseudo_register_reggroup_p): Likewise.
8891         (aarch64_gdbarch_init): Add pauth registers.
8892         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8893         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8894         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8895         (struct gdbarch_tdep): Add regnum for ra_state.
8896
8897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8898             Jiong Wang  <jiong.wang@arm.com>
8899
8900         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8901
8902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8903             Jiong Wang  <jiong.wang@arm.com>
8904
8905         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8906         function.
8907         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8908         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8909         (aarch64_gdbarch_init): Add puth registers.
8910         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8911         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8912         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8913
8914 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8915             Jiong Wang  <jiong.wang@arm.com>
8916
8917         * aarch64-linux-nat.c
8918         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8919         * aarch64-linux-tdep.c
8920         (aarch64_linux_core_read_description): Likewise.
8921         (aarch64_linux_get_hwcap): New function.
8922         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8923         (aarch64_linux_get_hwcap): New declaration.
8924
8925 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8926             Jiong Wang  <jiong.wang@arm.com>
8927
8928         * aarch64-linux-nat.c
8929         (aarch64_linux_nat_target::read_description): Add pauth param.
8930         * aarch64-linux-tdep.c
8931         (aarch64_linux_core_read_description): Likewise.
8932         * aarch64-tdep.c (struct target_desc): Add in pauth.
8933         (aarch64_read_description): Add pauth param.
8934         (aarch64_gdbarch_init): Likewise.
8935         * aarch64-tdep.h (aarch64_read_description): Likewise.
8936         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8937         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8938         * features/Makefile: Add new files.
8939         * features/aarch64-pauth.c: New file.
8940         * features/aarch64-pauth.xml: New file.
8941
8942 2019-03-20  Tom Tromey  <tromey@adacore.com>
8943
8944         * infrun.c (handle_inferior_event): Rename from
8945         handle_inferior_event_1.  Create a scoped_value_mark.
8946         (handle_inferior_event): Remove.
8947
8948 2019-03-19  Tom Tromey  <tromey@adacore.com>
8949
8950         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8951         * infrun.h (print_stop_event): Add "displays" parameter.
8952         * infrun.c (print_stop_event): Add "displays" parameter.
8953
8954 2019-03-19  Pedro Alves  <palves@redhat.com>
8955
8956         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8957         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8958         to -1.  Fix TABs vs spaces.
8959         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8960         * tui/tui-out.h (tui_ui_out) Add intro comments.
8961         <m_line, m_start_of_line>: In-class initialize, and add describing
8962         comment.
8963
8964 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8965
8966         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8967         variable names.
8968         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8969
8970 2019-03-18  Pedro Alves  <palves@redhat.com>
8971             Eli Zaretskii <eliz@gnu.org>
8972
8973         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8974         m_line and m_start_of_line.
8975
8976 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8977
8978         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8979         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8980         it returns a newline.  This fixes a regression in TU mode, whereby
8981         the next line is output on the same screen line as the user input.
8982
8983 2019-03-18  Tom Tromey  <tromey@adacore.com>
8984
8985         * minsyms.c (minimal_symbol_reader::install): Remove call to
8986         obstack_blank.
8987
8988 2019-03-18  Pedro Alves  <palves@redhat.com>
8989
8990         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8991         New globals.
8992         (apply_style): New, factored out from ...
8993         (apply_ansi_escape): ... this.  Handle reverse video mode.
8994         (tui_set_reverse_mode): New function.
8995         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8996         * tui/tui-winsource.c (tui_show_source_line): Use
8997         tui_set_reverse_mode instead of setting A_STANDOUT.
8998         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8999         New setter methods.
9000
9001 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9002
9003         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9004         Handle tabs.
9005
9006 2019-03-18  Tom Tromey  <tromey@adacore.com>
9007
9008         * ada-lang.c (empty_array): Add "high" parameter.
9009         (ada_evaluate_subexp): Update.
9010
9011 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9012
9013         * unittests/string_view-selftests.c: Define
9014         _initialize_string_view_selftests unconditionally.
9015
9016 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9017
9018         PR gdb/24350
9019         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9020
9021 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9022
9023         PR gdb/24351
9024         * windows-nat.c (display_selector): Fix format specifiers.
9025
9026 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9027
9028         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9029         tui_refill_source_window instead of tui_refresh_win, to update the
9030         current execution line.  This fixes redisplay of the current line
9031         when stepping through the code with "next" or "step".
9032
9033 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9034
9035         * source-cache.c (source_cache::get_source_lines): Call
9036         find_source_lines to initialize s->nlines.  This fixes vertical
9037         scrolling of TUI source window when the DOWN arrow is pressed.
9038
9039 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9040
9041         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9042         linux-thread-db.c (_initialize_thread_db): Likewise.
9043
9044 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9045
9046         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9047         wclrtoeol in tui_show_source_line".  This reverts changes made in
9048         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9049
9050 2019-03-15  Tom Tromey  <tom@tromey.com>
9051
9052         * symtab.h (struct minimal_symbol): Derive from
9053         general_symbol_info.
9054         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9055         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9056         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9057         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9058         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9059         (MSYMBOL_SEARCH_NAME): Update.
9060         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9061         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9062         * minsyms.c (minimal_symbol_reader::record_full): Update.
9063
9064 2019-03-15  Tom Tromey  <tom@tromey.com>
9065
9066         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9067
9068 2019-03-15  Tom Tromey  <tom@tromey.com>
9069
9070         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9071         unique_xmalloc_ptr.
9072         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9073         Update.
9074         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9075         (build_minimal_symbol_hash_tables)
9076         (minimal_symbol_reader::install): Update.
9077
9078 2019-03-15  Tom Tromey  <tom@tromey.com>
9079
9080         * symtab.c (create_demangled_names_hash): Update.
9081         (symbol_set_names): Update.
9082         * objfiles.h (struct objfile_per_bfd_storage)
9083         <demangled_names_hash>: Now an htab_up.
9084         * objfiles.c (objfile_per_bfd_storage): Simplify.
9085
9086 2019-03-15  Tom Tromey  <tom@tromey.com>
9087
9088         * objfiles.h (struct objfile_per_bfd_storage): Declare
9089         destructor.
9090         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9091         New.
9092         (get_objfile_bfd_data): Use new.  Don't initialize
9093         language_of_main.
9094         (free_objfile_per_bfd_storage): Remove.
9095         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9096
9097 2019-03-15  Tom Tromey  <tom@tromey.com>
9098
9099         * symfile.c (reread_symbols): Update.
9100         * objfiles.c (objfile::objfile): Update.
9101         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9102         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9103         comment.
9104         (minimal_symbol_reader::install): Update.
9105         (terminate_minimal_symbol_table): Remove.
9106         * jit.c (jit_object_close_impl): Update.
9107
9108 2019-03-15  Tom Tromey  <tom@tromey.com>
9109
9110         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9111         initializations.
9112
9113 2019-03-15  Tom Tromey  <tom@tromey.com>
9114
9115         * objfiles.h (struct objfile_per_bfd_storage)
9116         <demangled_hash_languages>: Now a bitset.
9117         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9118         (lookup_minimal_symbol): Update.
9119
9120 2019-03-15  Tom Tromey  <tom@tromey.com>
9121
9122         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9123         Don't return the symbol.
9124         * coffread.c (record_minimal_symbol): Use record_full.
9125
9126 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9127
9128         The MS-Windows port of ncurses fails to switch to a color pair if
9129         one or both of the colors are the implicit default colors.  This
9130         change records the default colors when TUI is initialized, and
9131         then specifies them explicitly when a color pair uses the default
9132         colors.  This allows color styling in TUI mode on MS-Windows.
9133
9134         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9135         ncurses_norm_attr.
9136         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9137         colors in ncurses_norm_attr.
9138         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9139         "none", replace it with the default color recorded in
9140         ncurses_norm_attr.
9141
9142 2019-03-14  Tom Tromey  <tromey@adacore.com>
9143
9144         * source-cache.h (class source_cache) <get_source_lines>: Return
9145         std::string.
9146         * source-cache.c (source_cache::extract_lines): Handle case where
9147         first_pos==npos.  Return std::string.
9148         (source_cache::get_source_lines): Update.
9149
9150 2019-03-14  Tom Tromey  <tromey@adacore.com>
9151
9152         * NEWS: Add item for "style sources" commands.
9153         * source-cache.c (source_cache::get_source_lines): Check
9154         source_styling.
9155         * cli/cli-style.c (source_styling): New global.
9156         (_initialize_cli_style): Add "style sources" commands.
9157         (show_style_sources): New function.
9158         * cli/cli-style.h (source_styling): Declare.
9159
9160 2019-03-14  Pedro Alves  <palves@redhat.com>
9161             Tom Tromey  <tromey@adacore.com>
9162
9163         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9164         * tui/tui-winsource.c (tui_refill_source_window): New function,
9165         from...
9166         (tui_horizontal_source_scroll): ... here.  Move some logic.
9167         * cli/cli-style.c (set_style_enabled): Notify new observable.
9168         * tui/tui-hooks.c (tui_redisplay_source): New function.
9169         (tui_attach_detach_observers): Attach or detach
9170         tui_redisplay_source.
9171         * observable.h (source_styling_changed): New observable.
9172         * observable.c: Define source_styling_changed observable.
9173
9174 2019-03-13  Tom Tromey  <tromey@adacore.com>
9175
9176         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9177         (i386_gnu_nat_target::store_registers): Update.
9178         * target-debug.h (target_debug_print_std_string): New macro.
9179         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9180         * windows-tdep.c (display_one_tib): Update.
9181         * tui/tui-stack.c (tui_make_status_line): Update.
9182         * top.c (print_inferior_quit_action): Update.
9183         * thread.c (thr_try_catch_cmd): Update.
9184         (add_thread_with_info): Update.
9185         (thread_target_id_str): Update.
9186         (thr_try_catch_cmd): Update.
9187         (thread_command): Update.
9188         (thread_find_command): Update.
9189         * record-btrace.c (record_btrace_target::info_record)
9190         (record_btrace_resume_thread, record_btrace_target::resume)
9191         (record_btrace_cancel_resume, record_btrace_step_thread)
9192         (record_btrace_target::wait, record_btrace_target::wait)
9193         (record_btrace_target::wait, record_btrace_target::stop): Update.
9194         * progspace.c (print_program_space): Update.
9195         * process-stratum-target.c
9196         (process_stratum_target::thread_address_space): Update.
9197         * linux-fork.c (linux_fork_mourn_inferior)
9198         (detach_checkpoint_command, info_checkpoints_command)
9199         (linux_fork_context): Update.
9200         (linux_fork_detach): Update.
9201         (class scoped_switch_fork_info): Update.
9202         (delete_checkpoint_command): Update.
9203         * infrun.c (follow_fork_inferior): Update.
9204         (follow_fork_inferior): Update.
9205         (proceed_after_vfork_done): Update.
9206         (handle_vfork_child_exec_or_exit): Update.
9207         (follow_exec): Update.
9208         (displaced_step_prepare_throw): Update.
9209         (displaced_step_restore): Update.
9210         (start_step_over): Update.
9211         (resume_1): Update.
9212         (clear_proceed_status_thread): Update.
9213         (proceed): Update.
9214         (print_target_wait_results): Update.
9215         (do_target_wait): Update.
9216         (context_switch): Update.
9217         (stop_all_threads): Update.
9218         (restart_threads): Update.
9219         (finish_step_over): Update.
9220         (handle_signal_stop): Update.
9221         (switch_back_to_stepped_thread): Update.
9222         (keep_going_pass_signal): Update.
9223         (print_exited_reason): Update.
9224         (normal_stop): Update.
9225         * inferior.c (inferior_pid_to_str): Change return type.
9226         (print_selected_inferior): Update.
9227         (add_inferior): Update.
9228         (detach_inferior): Update.
9229         * dummy-frame.c (fprint_dummy_frames): Update.
9230         * dcache.c (dcache_info_1): Update.
9231         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9232         (btrace_fetch, btrace_clear): Update.
9233         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9234         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9235         type.
9236         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9237         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9238         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9239         * gdbarch.c, gdbarch.h: Rebuild.
9240         * gdbarch.sh (core_pid_to_str): Change return type.
9241         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9242         return type.
9243         (windows_nat_target::pid_to_str): Change return type.
9244         (windows_delete_thread): Update.
9245         (windows_nat_target::attach): Update.
9246         (windows_nat_target::files_info): Update.
9247         * target-delegates.c: Rebuild.
9248         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9249         return type.
9250         (sol_thread_target::pid_to_str): Change return type.
9251         * remote.c (class remote_target) <pid_to_str>: Change return
9252         type.
9253         (remote_target::pid_to_str): Change return type.
9254         (extended_remote_target::attach, remote_target::remote_stop_ns)
9255         (remote_target::remote_notif_remove_queued_reply)
9256         (remote_target::push_stop_reply, remote_target::disable_btrace):
9257         Update.
9258         (extended_remote_target::attach): Update.
9259         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9260         type.
9261         (gdbsim_target::pid_to_str): Change return type.
9262         * ravenscar-thread.c (struct ravenscar_thread_target)
9263         <pid_to_str>: Change return type.
9264         (ravenscar_thread_target::pid_to_str): Change return type.
9265         * procfs.c (class procfs_target) <pid_to_str>: Change return
9266         type.
9267         (procfs_target::pid_to_str): Change return type.
9268         (procfs_target::attach): Update.
9269         (procfs_target::detach): Update.
9270         (procfs_target::fetch_registers): Update.
9271         (procfs_target::store_registers): Update.
9272         (procfs_target::wait): Update.
9273         (procfs_target::files_info): Update.
9274         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9275         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9276         return type.
9277         (nto_procfs_target::pid_to_str): Change return type.
9278         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9279         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9280         return type.
9281         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9282         (exit_lwp): Update.
9283         (attach_proc_task_lwp_callback, get_detach_signal)
9284         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9285         (linux_nat_target::resume, wait_lwp, stop_callback)
9286         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9287         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9288         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9289         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9290         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9291         type.
9292         (inf_ptrace_target::attach): Update.
9293         (inf_ptrace_target::files_info): Update.
9294         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9295         type.
9296         (go32_nat_target::pid_to_str): Change return type.
9297         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9298         (gnu_nat_target::wait): Update.
9299         (gnu_nat_target::wait): Update.
9300         (gnu_nat_target::resume): Update.
9301         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9302         (fbsd_nat_target::wait): Update.
9303         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9304         type.
9305         (darwin_nat_target::attach): Update.
9306         * corelow.c (class core_target) <pid_to_str>: Change return type.
9307         (core_target::pid_to_str): Change return type.
9308         * target.c (normal_pid_to_str): Change return type.
9309         (default_pid_to_str): Likewise.
9310         (target_pid_to_str): Change return type.
9311         (target_translate_tls_address): Update.
9312         (target_announce_detach): Update.
9313         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9314         return type.
9315         (bsd_uthread_target::pid_to_str): Change return type.
9316         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9317         type.
9318         (bsd_kvm_target::pid_to_str): Change return type.
9319         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9320         return type.
9321         (aix_thread_target::pid_to_str): Change return type.
9322         * target.h (struct target_ops) <pid_to_str>: Change return type.
9323         (target_pid_to_str, normal_pid_to_str): Likewise.
9324         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9325         type.
9326         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9327         type.
9328         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9329         return type.
9330         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9331         type.
9332         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9333         type.
9334         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9335         return type.
9336
9337 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9338
9339         * NEWS: Mention that the new default MI version is 3.  Mention
9340         changes to the output of commands and events that deal with
9341         multi-location breakpoints.
9342         * breakpoint.c: Include "mi/mi-out.h".
9343         (print_one_breakpoint): Change output syntax if using MI version
9344         >= 3.
9345         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9346         New.
9347         (mi_multi_location_breakpoint_output_fixed): New.
9348         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9349         (mi_cmd_fix_multi_location_breakpoint_output): New.
9350         (mi_multi_location_breakpoint_output_fixed): New.
9351         * mi/mi-cmds.c (mi_cmds): Register command
9352         -fix-multi-location-breakpoint-output.
9353         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9354         interpreter "mi".
9355
9356 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9357
9358         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9359         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9360         instantiate mi_ui_out based on interpreter name.
9361         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9362         * mi/mi-main.c (mi_load_progress): Likewise.
9363
9364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9365
9366         * NEWS: Combine separate "New targets" sections for 8.3.
9367
9368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9369
9370         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9371         (ppcfbsd_init_abi): Install gdbarch
9372         "fetch_tls_load_module_address" and "get_thread_local_address"
9373         methods.
9374
9375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9376
9377         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9378         (riscv_fbsd_init_abi): Install gdbarch
9379         "fetch_tls_load_module_address" and "get_thread_local_address"
9380         methods.
9381
9382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9383
9384         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9385         (i386fbsd_init_abi): Install gdbarch
9386         "fetch_tls_load_module_address" and "get_thread_local_address"
9387         methods.
9388
9389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9390
9391         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9392         (amd64fbsd_init_abi): Install gdbarch
9393         "fetch_tls_load_module_address" and "get_thread_local_address"
9394         methods.
9395
9396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9397
9398         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9399         (struct fbsd_pspace_data): New type.
9400         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9401         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9402         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9403         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9404         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9405
9406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9407
9408         * gdbtypes.c (lookup_struct_elt): New function.
9409         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9410         * gdbtypes.h (struct struct_elt): New type.
9411         (lookup_struct_elt): New prototype.
9412
9413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9414
9415         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9416         remove disabled code block.
9417
9418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9419
9420         * gdbarch.sh (get_thread_local_address): New method.
9421         * gdbarch.h, gdbarch.c: Regenerate.
9422         * target.c (target_translate_tls_address): Use
9423         gdbarch_get_thread_local_address if present instead of
9424         target::get_thread_local_address.
9425
9426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9427
9428         * target.h (target::get_thread_local_address): Update comment.
9429
9430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9431
9432         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9433         objfile->separate_debug_objfile_backlink if not NULL.
9434
9435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9436
9437         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9438         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9439         (amd64bsd_store_inferior_registers): Likewise.
9440         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9441         Enable segment base registers.
9442         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9443         PT_GETFSBASE and PT_GETGSBASE.
9444         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9445         PT_SETGSBASE.
9446         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9447         segment base registers.
9448         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9449
9450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9451
9452         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9453         Update calls to i386_target_description to add 'segments'
9454         parameter.
9455         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9456         add segment base registers.
9457         * arch/i386.c (i386_create_target_description): Add 'segments'
9458         parameter to enable segment base registers.
9459         * arch/i386.h (i386_create_target_description): Likewise.
9460         * features/i386/32bit-segments.xml: New file.
9461         * features/i386/32bit-segments.c: Generate.
9462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9463         call to i386_target_description to add 'segments' parameter.
9464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9465         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9466         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9467         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9468         if feature is present.
9469         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9470         Add 'segments' parameter to call to i386_target_description.
9471         (i386_target_description): Add 'segments' parameter to enable
9472         segment base registers.
9473         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9474         to call to i386_target_description.
9475         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9476         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9477         Define I386_NUM_REGS.
9478         (i386_target_description): Add 'segments' parameter to enable
9479         segment base registers.
9480
9481 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9482
9483         PR/24325
9484         * source-cache.c: #undef open and close, to avoid unresolved
9485         externals during linking.
9486
9487 2019-03-12  Tom Tromey  <tromey@adacore.com>
9488
9489         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9490         const.  Add initializers.
9491         (_initialize_remote): Don't initialize ptid globals.
9492
9493 2019-03-12  Pedro Alves  <palves@redhat.com>
9494
9495         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9496
9497 2019-03-12  Pedro Alves  <palves@redhat.com>
9498
9499         * cp-name-parser.y (main): Remove unused 'len' variable.
9500
9501 2019-03-12  Tom Tromey  <tromey@adacore.com>
9502
9503         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9504         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9505
9506 2019-03-12  Tom Tromey  <tromey@adacore.com>
9507
9508         * linux-nat.c (iterate_over_lwps): Update.
9509         (stop_callback): Remove parameter.
9510         (stop_wait_callback, detach_callback, resume_set_callback)
9511         (select_singlestep_lwp_callback, set_ignore_sigint)
9512         (status_callback, resumed_callback, resume_clear_callback)
9513         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9514         data parameter.
9515         (linux_nat_target::detach, linux_nat_target::resume)
9516         (linux_stop_and_wait_all_lwps, select_event_lwp)
9517         (linux_nat_filter_event, linux_nat_wait_1)
9518         (linux_nat_target::kill, linux_nat_target::stop)
9519         (linux_nat_target::stop): Update.
9520         (linux_nat_resume_callback): Change type.
9521         (resume_stopped_resumed_lwps, count_events_callback)
9522         (select_event_lwp_callback): Likewise.
9523         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9524         * arm-linux-nat.c (struct update_registers_data): Remove.
9525         (update_registers_callback): Change type.
9526         (arm_linux_insert_hw_breakpoint1): Update.
9527         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9528         parameter.
9529         (x86_linux_dr_set_addr): Update.
9530         (x86_linux_dr_set_control): Update.
9531         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9532         (iterate_over_lwps): Use gdb::function_view.
9533         * nat/aarch64-linux-hw-point.c (struct
9534         aarch64_dr_update_callback_param): Remove.
9535         (debug_reg_change_callback): Change type.
9536         (aarch64_notify_debug_reg_change): Update.
9537         * s390-linux-nat.c (s390_refresh_per_info): Update.
9538
9539 2019-03-11  Tom Tromey  <tromey@adacore.com>
9540
9541         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9542         redundant assignment to "this_cu".
9543
9544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9545
9546         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9547
9548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9549
9550         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9551         from...
9552         (rank_one_type): ... this.
9553
9554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9555
9556         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9557         from...
9558         (rank_one_type): ... this.
9559
9560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9561
9562         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9563         from...
9564         (rank_one_type): ... this.
9565
9566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9567
9568         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9569         from...
9570         (rank_one_type): ... this.
9571
9572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9573
9574         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9575         from...
9576         (rank_one_type): ... this.
9577
9578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9579
9580         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9581         from...
9582         (rank_one_type): ... this.
9583
9584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9585
9586         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9587         from...
9588         (rank_one_type): ... this.
9589
9590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9591
9592         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9593         from...
9594         (rank_one_type): ... this.
9595
9596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9597
9598         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9599         from...
9600         (rank_one_type): ... this.
9601
9602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9603
9604         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9605         from...
9606         (rank_one_type): ... this.
9607
9608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9609
9610         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9611         from...
9612         (rank_one_type): ... this.
9613
9614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9615
9616         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9617         from...
9618         (rank_one_type): ... this.
9619
9620 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9621
9622         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9623         inferior-events' shows the example events.
9624
9625 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9626
9627         Support styling on native MS-Windows console
9628
9629         PR/24315
9630         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9631         on MS-Windows if $TERM is not defined.
9632
9633         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9634
9635         * posix-hdep.c (gdb_console_fputs):
9636         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9637         functions.
9638         * ui-file.h (gdb_console_fputs): Add prototype.
9639
9640         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9641         back to fputs only if the former returns zero.
9642
9643 2019-03-07  Tom Tromey  <tom@tromey.com>
9644
9645         * symmisc.c (print_symbol_bcache_statistics): Update.
9646         (print_objfile_statistics): Update.
9647         * symfile.c (allocate_symtab): Update.
9648         * stabsread.c: Don't include bcache.h.
9649         * psymtab.h (struct psymbol_bcache): Don't declare.
9650         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9651         (psymbol_bcache_init, psymbol_bcache_free)
9652         (psymbol_bcache_get_bcache): Don't declare.
9653         * psymtab.c (struct psymbol_bcache): Remove.
9654         (psymtab_storage::psymtab_storage): Update.
9655         (psymtab_storage::~psymtab_storage): Update.
9656         (psymbol_bcache_init, psymbol_bcache_free)
9657         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9658         (add_psymbol_to_bcache): Update.
9659         (allocate_psymtab): Update.
9660         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9661         macro_cache>: No longer pointers.
9662         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9663         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9664         * macrotab.c (macro_bcache): Update.
9665         * macroexp.c: Don't include bcache.h.
9666         * gdbtypes.c (check_types_worklist): Update.
9667         (types_deeply_equal): Remove TRY/CATCH.  Update.
9668         * elfread.c (elf_symtab_read): Update.
9669         * dwarf2read.c: Don't include bcache.h.
9670         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9671         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9672         (print_bcache_statistics, bcache_memory_used): Don't declare.
9673         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9674         methods.  Rename all data members.
9675         * bcache.c (struct bcache): Move to bcache.h.
9676         (bcache::expand_hash_table): Rename from expand_hash_table.
9677         (bcache): Remove.
9678         (bcache::insert): Rename from bcache_full.
9679         (bcache::compare): Rename from bcache_compare.
9680         (bcache_xmalloc): Remove.
9681         (bcache::~bcache): Rename from bcache_xfree.
9682         (bcache::print_statistics): Rename from print_bcache_statistics.
9683         (bcache::memory_used): Rename from bcache_memory_used.
9684
9685 2019-03-07  Pedro Alves  <palves@redhat.com>
9686
9687         * infrun.c (normal_stop): Also check for
9688         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9689
9690 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * f-lang.c (value_from_host_double): Moved to...
9693         * value.c (value_from_host_double): ...here.
9694         * value.h (value_from_host_double): Declare.
9695         * guile/scm-math.c (vlscm_convert_typed_number): Use
9696         value_from_host_double.
9697         (vlscm_convert_number): Likewise.
9698         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9699         * python/py-value.c (convert_value_from_python): Likewise.
9700
9701 2019-03-06  Tom Tromey  <tom@tromey.com>
9702
9703         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9704
9705 2019-03-06  Tom Tromey  <tom@tromey.com>
9706
9707         * utils.h (free_current_contents): Don't declare.
9708         * utils.c (free_current_contents): Remove.
9709
9710 2019-03-06  Tom Tromey  <tom@tromey.com>
9711
9712         * top.c (quit_force): Update.
9713         * main.c (captured_command_loop): Update.
9714         * common/new-op.c (operator new): Update.
9715         * common/common-exceptions.c (struct catcher)
9716         <save_cleanup_chain>: Remove member.
9717         (exceptions_state_mc_init): Update.
9718         (exception_try_scope_entry): Return nullptr.
9719         (exception_try_scope_exit, exception_rethrow)
9720         (throw_exception_sjlj, throw_exception_cxx): Update.
9721         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9722         (all_cleanups, do_cleanups, discard_cleanups)
9723         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9724         (restore_cleanups, restore_final_cleanups): Don't declare.
9725         (do_final_cleanups): Remove parameter.
9726         * common/cleanups.c (cleanup_chain, make_cleanup)
9727         (make_cleanup_dtor, all_cleanups, do_cleanups)
9728         (discard_my_cleanups, discard_cleanups)
9729         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9730         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9731         (null_cleanup): Remove.
9732         (do_final_cleanups): Remove parameter.
9733
9734 2019-03-06  Tom Tromey  <tom@tromey.com>
9735
9736         * remote.c (remote_target::remote_parse_stop_reply): Use
9737         unique_xmalloc_ptr.
9738
9739 2019-03-06  Tom Tromey  <tom@tromey.com>
9740
9741         * stabsread.c (struct stabs_field_info): Rename from field_info.
9742         <list, fnlist>: Add initializers.
9743         <obstack>: New member.
9744         (read_member_functions, read_struct_fields, read_baseclasses):
9745         Allocate on obstack.  Don't use cleanups.
9746         (read_one_struct_field, read_member_functions, read_struct_fields)
9747         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9748         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9749         (read_struct_type): Update.
9750
9751 2019-03-06  Tom Tromey  <tom@tromey.com>
9752
9753         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9754         * common/filestuff.h (make_cleanup_close): Don't declare.
9755         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9756         Remove.
9757
9758 2019-03-06  Tom Tromey  <tom@tromey.com>
9759
9760         * solib-aix.c: Use make_scope_exit.
9761
9762 2019-03-06  Tom Tromey  <tom@tromey.com>
9763
9764         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9765         Use make_scope_exit.
9766
9767 2019-03-06  Tom Tromey  <tom@tromey.com>
9768
9769         * solib-svr4.c (disable_probes_interface): Remove parameter.
9770         (svr4_handle_solib_event): Use make_scope_exit.
9771
9772 2019-03-06  Tom Tromey  <tom@tromey.com>
9773
9774         * remote.c (struct stop_reply_deleter): Remove.
9775         (stop_reply_up): Update.
9776         (struct stop_reply): Derive from notif_event.  Don't typedef.
9777         <regcache>: Now a std::vector.
9778         (stop_reply_xfree): Remove.
9779         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9780         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9781         (remote_target::discard_pending_stop_replies): Use delete.
9782         (remote_target::remote_parse_stop_reply): Update.
9783         (remote_target::process_stop_reply): Update.
9784         * remote-notif.h (struct notif_event): Add virtual destructor.
9785         Remove "dtr" member.
9786         (struct notif_client) <alloc_event>: Return a unique_ptr.
9787         (notif_event_xfree): Don't declare.
9788         (notif_event_up): New typedef.
9789         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9790         (notif_event_xfree, do_notif_event_xfree): Remove.
9791         (remote_notif_state_xfree): Update.
9792
9793 2019-03-06  Tom Tromey  <tom@tromey.com>
9794
9795         * infrun.c (displaced_step_clear_cleanup): Now a
9796         forward_scope_exit type.
9797         (displaced_step_prepare_throw): Update.
9798         (displaced_step_fixup): Update.
9799
9800 2019-03-06  Tom Tromey  <tom@tromey.com>
9801
9802         * inferior.h (class inferior): Update comment.
9803         * gdbthread.h (class thread_info): Update comment.
9804
9805 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9806             Tom Tromey  <tom@tromey.com>
9807
9808         * stabsread.h (struct stab_section_list): Remove.
9809         (coffstab_build_psymtabs): Update.
9810         * dbxread.c (symbuf_sections): Now a std::vector.
9811         (sect_idx): New global.
9812         (fill_symbuf): Update.
9813         (coffstab_build_psymtabs): Change type of stabsects parameter.
9814         Update.
9815         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9816         std::vector.
9817         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9818         (coff_locate_sections): Update.
9819         (coff_symfile_read): Remove cleanups.  Update.
9820         (init_stringtab): Add storage parameter.
9821         (free_stringtab, free_stringtab_cleanup): Remove.
9822         (init_lineno): Add storage parameter.
9823         (free_linetab, free_linetab_cleanup): Remove.
9824
9825 2019-03-06  Pedro Alves  <palves@redhat.com>
9826
9827         * linux-fork.c (fork_info::clobber_regs): Delete.
9828         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9829         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9830         comment.  Adjust.
9831         (scoped_switch_fork_info::scoped_switch_fork_info)
9832         (checkpoint_command, linux_fork_context): Adjust
9833         fork_save_infrun_state calls.
9834
9835 2019-03-06  Pedro Alves  <palves@redhat.com>
9836
9837         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9838         (inf_has_multiple_threads): Return 'bool' and rewrite using
9839         inferior_info::threads().
9840
9841 2019-03-06  Pedro Alves  <palves@redhat.com>
9842
9843         * linux-fork.c: Include <list>.
9844         (fork_list): Now a std::list instance.
9845         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9846         (forks_exist_p, find_last_fork): Adjust.
9847         (new_fork): Delete.
9848         (one_fork_p): New.
9849         (add_fork): Adjust.
9850         (free_fork): Delete, folded into fork_info::~fork_info().
9851         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9852         Adjust.
9853         (init_fork_list): Delete.
9854         (linux_fork_killall, linux_fork_mourn_inferior)
9855         (linux_fork_detach, info_checkpoints_command): Adjust.
9856         (_initialize_linux_fork): No longer call init_fork_list.
9857
9858 2019-03-06  Pedro Alves  <palves@redhat.com>
9859
9860         * linux-fork.c (new_fork): New, split out of ...
9861         (add_fork): ... this.  Return void.  Move "first fork" special
9862         case from here, to ...
9863         (checkpoint_command): ... here.
9864         * linux-linux.h (add_fork): Return void.
9865
9866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9867
9868         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9869
9870 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9871             Chris January  <chris.january@arm.com>
9872             David Lecomber  <david.lecomber@arm.com>
9873
9874         * f-exp.y: New token, UNOP_INTRINSIC.
9875         (exp): New pattern using UNOP_INTRINSIC token.
9876         (f77_keywords): Add 'abs' keyword.
9877         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9878         (value_from_host_double): New function.
9879         (evaluate_subexp_f): Support UNOP_ABS.
9880
9881 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9882
9883         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9884         types.
9885
9886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9887
9888         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9889         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9890         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9891
9892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9893
9894         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9895
9896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9897             Chris January  <chris.january@arm.com>
9898
9899         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9900         * f-exp.y: Define 'KIND' token.
9901         (exp): New pattern for KIND expressions.
9902         (ptype): Handle types with a kind extension.
9903         (direct_abs_decl): Extend to spot kind extensions.
9904         (f77_keywords): Add 'kind' to the list.
9905         (push_kind_type): New function.
9906         (convert_to_kind_type): New function.
9907         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9908         * parse.c (operator_length_standard): Likewise.
9909         * parser-defs.h (enum type_pieces): Add tp_kind.
9910         * std-operator.def: Add UNOP_KIND.
9911
9912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9913
9914         * f-exp.y (f_parse): Set yydebug.
9915
9916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9917
9918         * f-lang.c (evaluate_subexp_f): New function.
9919         (exp_descriptor_f): New global.
9920         (f_language_defn): Use exp_descriptor_f instead of
9921         exp_descriptor_standard.
9922
9923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9924
9925         * f-exp.y (struct token): Add comments.
9926         (dot_ops): Remove uppercase versions and the end marker.
9927         (f77_keywords): Likewise.
9928         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9929         entries in the dot_ops array are case insensitive, and use
9930         strncasecmp to compare strings.  Also some whitespace cleanup in
9931         this area.  Similar for the f77_keywords array, except entries in
9932         this list might be case sensitive.
9933
9934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9935
9936         * f-exp.y (struct f77_boolean_val): Add comments.
9937         (boolean_values): Remove uppercase versions, and end marker.
9938         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9939         and use strncasecmp to achieve case insensitivity.  Additionally,
9940         perform whitespace cleanup around this code.
9941
9942 2019-03-06  Tom Tromey  <tromey@adacore.com>
9943
9944         * remote-sim.c (gdbsim_target_open): Use result of
9945         gdb_argv::release.
9946
9947 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9948         Dirk Schubert  <dirk.schubert@arm.com>
9949         Chris January  <chris.january@arm.com>
9950
9951         * eval.c (evaluate_subexp_standard): Call Fortran argument
9952         wrapping logic.
9953         * f-lang.c (struct value): A value which can be passed into a
9954         Fortran function call.
9955         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9956         where appropriate.
9957         (struct type): Value ready for a Fortran function call.
9958         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9959         is needed.
9960         * f-lang.h (fortran_argument_convert): Declaration.
9961         (fortran_preserve_arg_pointer): Declaration.
9962         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9963
9964 2019-03-05  Tom Tromey  <tromey@adacore.com>
9965
9966         * python/py-prettyprint.c (print_string_repr): Remove #if.
9967         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9968
9969 2019-03-05  Tom Tromey  <tromey@adacore.com>
9970
9971         * target.c (the_dummy_target): Move later.  Change type to
9972         "dummy_target".
9973         (initialize_targets): Don't initialize the_dummy_target.
9974
9975 2019-03-05  Tom Tromey  <tromey@adacore.com>
9976
9977         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9978         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9979
9980 2019-03-05  Tom Tromey  <tromey@adacore.com>
9981
9982         * windows-nat.c (windows_nat_target::attach)
9983         (windows_nat_target::detach): Don't call gdb_flush.
9984         * valprint.c (generic_val_print, val_print, val_print_string):
9985         Don't call gdb_flush.
9986         * utils.c (defaulted_query): Don't call gdb_flush.
9987         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9988         * target.c (target_announce_detach): Don't call gdb_flush.
9989         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9990         * remote.c (extended_remote_target::attach): Don't call
9991         gdb_flush.
9992         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9993         * printcmd.c (do_examine): Don't call gdb_flush.
9994         (info_display_command): Don't call gdb_flush.
9995         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9996         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9997         * memattr.c (info_mem_command): Don't call gdb_flush.
9998         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9999         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10000         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10001         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10002         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10003         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10004         (gnu_nat_target::detach): Don't call gdb_flush.
10005         * f-valprint.c (f_val_print): Don't call gdb_flush.
10006         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10007         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10008         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10009         gdb_flush.
10010         * c-valprint.c (c_val_print): Don't call gdb_flush.
10011         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10012
10013 2019-03-05  Tom Tromey  <tromey@adacore.com>
10014
10015         * varobj.c (update_dynamic_varobj_children): Update.
10016         (install_default_visualizer): Use reset, not release.
10017         * value.c (set_internalvar): Update.
10018         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10019         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10020         ATTRIBUTE_UNUSED_RESULT.
10021
10022 2019-03-05  Tom Tromey  <tromey@adacore.com>
10023
10024         * remote.c (class scoped_remote_fd) <release>: Add
10025         ATTRIBUTE_UNUSED_RESULT.
10026
10027 2019-03-05  Tom Tromey  <tromey@adacore.com>
10028
10029         * macroexp.c (struct macro_buffer) <release>: Add
10030         ATTRIBUTE_UNUSED_RESULT.
10031
10032 2019-03-05  Tom Tromey  <tromey@adacore.com>
10033
10034         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10035         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10036         ATTRIBUTE_UNUSED_RESULT.
10037
10038 2019-03-05  Tom Tromey  <tromey@adacore.com>
10039
10040         * common/scoped_fd.h (class scoped_fd) <release>: Add
10041         ATTRIBUTE_UNUSED_RESULT.
10042
10043 2019-03-05  Tom Tromey  <tromey@adacore.com>
10044
10045         * parser-defs.h (struct parser_state) <release>: Add
10046         ATTRIBUTE_UNUSED_RESULT.
10047
10048 2019-03-05  Tom Tromey  <tromey@adacore.com>
10049
10050         * utils.h (class gdb_argv) <release>: Add
10051         ATTRIBUTE_UNUSED_RESULT.
10052         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10053
10054 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10055
10056         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10057         for-loop range, to avoid compiler warnings.
10058
10059         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10060         avoid compiler warnings about unused variables.
10061
10062         * NEWS: Mention end of support for native debugging on MS-Windows
10063         before XP.
10064
10065         PR gdb/24292
10066         * common/netstuff.c:
10067         * gdbserver/gdbreplay.c
10068         * gdbserver/remote-utils.c:
10069         * ser-tcp.c:
10070         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10071         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10072         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10073         'getaddrinfo' and 'freeaddrinfo' were not available before
10074         Windows XP, and mingw.org's MinGW headers by default define
10075         _WIN32_WINNT to 0x500.
10076
10077 2019-03-01  Gary Benson <gbenson@redhat.com>
10078
10079         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10080
10081 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10082             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10083
10084         PR gdb/8527
10085         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10086         set_sigint_trap, clear_sigint_trap.
10087
10088 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10089
10090         * target.c (target_detach): Clear the regcache and the
10091         frame cache.
10092
10093 2019-02-27  Pedro Alves  <palves@redhat.com>
10094
10095         * utils.c (set_screen_size): When we cap the height/width sizes,
10096         tweak the corresponding command variable to show "unlimited":
10097
10098 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10099             Pedro Alves  <palves@redhat.com>
10100
10101         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10102         before calling rl_set_screen_size.
10103
10104 2019-02-27  Tom Tromey  <tromey@adacore.com>
10105
10106         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10107         define.
10108         * python/py-value.c: Remove Python 2.4 workaround.
10109         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10110         workaround.
10111         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10112         Python 2.4 workaround.
10113         * python/python-internal.h: Remove Python 2.4 comment.
10114         (Py_ssize_t): Don't define.
10115         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10116         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10117         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10118         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10119         * python/python.c (do_start_initialization): Remove Python 2.4
10120         workaround.
10121         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10122         (print_children): Remove Python 2.4 workaround.
10123         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10124         workaround.
10125         (CHARBUFFERPROC_NAME): Remove.
10126         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10127         Python 2.4 workaround.
10128
10129 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10130
10131         * NEWS: Note minimum Python version.
10132
10133 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10134
10135         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10136         code from these functions.  Remove corresponding ifdefs.  Use
10137         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10138         Remove gotos and target of gotos.
10139         (infpy_search_memory): Likewise.
10140
10141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10142
10143         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10144         (hppa_gdbarch_init): Don't register deleted functions with
10145         gdbarch.
10146
10147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10148
10149         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10150         (h8300_unwind_sp): Delete.
10151         (h8300_dummy_id): Delete.
10152         (h8300_gdbarch_init): Don't register deleted functions with
10153         gdbarch.
10154
10155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10156
10157         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10158         (ft32_unwind_pc): Delete.
10159         (ft32_unwind_sp): Delete.
10160         (ft32_gdbarch_init): Don't register deleted functions with
10161         gdbarch.
10162
10163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10164
10165         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10166         (frv_unwind_pc): Delete.
10167         (frv_unwind_sp): Delete.
10168         (frv_gdbarch_init): Don't register deleted functions with
10169         gdbarch.
10170
10171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10172
10173         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10174         (riscv_unwind_pc): Delete.
10175         (riscv_unwind_sp): Delete.
10176         (riscv_gdbarch_init): Don't register deleted functions with
10177         gdbarch.
10178
10179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10180
10181         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10182         (csky_unwind_pc): Delete.
10183         (csky_unwind_sp): Delete.
10184         (csky_gdbarch_init): Don't register deleted functions with
10185         gdbarch.
10186
10187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10188
10189         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10190         (cris_unwind_pc): Delete.
10191         (cris_unwind_sp): Delete.
10192         (cris_gdbarch_init): Don't register deleted functions with
10193         gdbarch.
10194
10195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10196
10197         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10198         (bfin_unwind_pc): Delete.
10199         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10200
10201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10202
10203         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10204         (arm_unwind_pc): Delete.
10205         (arm_unwind_sp): Delete.
10206         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10207
10208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10209
10210         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10211         (arc_unwind_pc): Delete.
10212         (arc_unwind_sp): Delete.
10213         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10214
10215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10216
10217         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10218         (alpha_unwind_pc): Delete.
10219         (alpha_gdbarch_init): Don't register deleted functions with
10220         gdbarch.
10221
10222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10223
10224         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10225         (aarch64_unwind_pc): Delete.
10226         (aarch64_unwind_sp): Delete.
10227         (aarch64_gdbarch_init): Don't register deleted functions with
10228         gdbarch.
10229
10230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * gdbtypes.c (type_align): Don't consider static members when
10233         computing structure alignment.
10234
10235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10236
10237         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10238         return 0 for other types.
10239         * arch-utils.c (default_type_align): Always return 0.
10240         * gdbarch.h: Regenerate.
10241         * gdbarch.sh (type_align): Extend comment.
10242         * gdbtypes.c (type_align): Add additional comments, always call
10243         gdbarch_type_align before applying the default rules.
10244         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10245         generic code will then apply a suitable default.
10246         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10247         types, return 0 for other types.
10248
10249 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10250
10251         * NEWS: Create a new section for the next release branch.
10252         Rename the section of the current branch, now that it has
10253         been cut.
10254
10255 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10256
10257         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10258         * version.in: Bump version to 8.3.50.DATE-git.
10259
10260 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10261
10262         * aix-thread.c (ptid_cmp): Remove unused variable.
10263         (get_signaled_thread): Likewise.
10264         (store_regs_user_thread): Likewise.
10265         (store_regs_kernel_thread): Likewise.
10266         (fetch_regs_kernel_thread): Remove shadowed variable.
10267
10268 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10269
10270         * features/riscv/32bit-cpu.xml: Add register numbers.
10271         * features/riscv/32bit-fpu.c: Regenerate.
10272         * features/riscv/32bit-fpu.xml: Add register numbers.
10273         * features/riscv/64bit-cpu.xml: Add register numbers.
10274         * features/riscv/64bit-fpu.c: Regenerate.
10275         * features/riscv/64bit-fpu.xml: Add register numbers.
10276
10277 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10278
10279         * NEWS: Mention two argument form of gdb.Value constructor.
10280         * python/py-value.c (convert_buffer_and_type_to_value): New
10281         function.
10282         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10283         Add support for handling an optional second argument.  Call
10284         convert_buffer_and_type_to_value as appropriate.
10285         * python/python-internal.h (Py_buffer_deleter): New struct.
10286         (Py_buffer_up): New typedef.
10287
10288 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10289
10290         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10291         instead of releasing ownership.
10292
10293 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10294
10295         * dwarf2read.c (open_and_init_dwp_file): Call
10296         elf_numsections instead of bfd_count_sections to initialize
10297         dwp_file->num_sections.
10298
10299 2019-02-25  Tom Tromey  <tromey@adacore.com>
10300
10301         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10302
10303 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10304
10305         * gcore.in: Add '--readnever' option when invoking GDB.
10306
10307 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10308
10309         * MAINTAINERS: Update my email address.
10310
10311 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10312
10313         * build-id.c (build_id_to_debug_bfd_1): New function.
10314         (build_id_to_debug_bfd): Look for separate debug file in
10315         sysroot.
10316
10317 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10318
10319         * gdbarch.sh: Update the copyright year range that is placed into
10320         generated files.
10321
10322 2019-02-22  Keith Seitz  <keiths@redhat.com>
10323
10324         PR symtab/23853
10325         * linespec.c (create_sals_line_offset): Search for the default
10326         symtab's filename instead of its fullname.
10327
10328 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10329
10330         * NEWS: Update style defaults.
10331
10332 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10333
10334         * main.c (captured_main_1): Disable styling in batch mode.
10335
10336 2019-02-20  Tom Tromey  <tom@tromey.com>
10337
10338         * symtab.c (symtab_symbol_info): Fix typos.
10339
10340 2019-02-20  Tom Tromey  <tromey@adacore.com>
10341
10342         * findcmd.c (_initialize_mem_search): Use upper case for
10343         metasyntactic variables.
10344
10345 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10346
10347         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10348         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10349
10350 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10351
10352         * top.h (source_file_name): Change to std::string.
10353         * top.c (source_file_name): Likewise.
10354         (command_line_input): Adjust.
10355         * cli/cli-script.c (script_from_file): Adjust.
10356
10357 2019-02-19  Tom Tromey  <tromey@adacore.com>
10358
10359         * ravenscar-thread.c
10360         (ravenscar_thread_target::update_thread_list): Don't call
10361         ada_build_task_list.
10362         * ada-lang.h (ada_build_task_list): Don't declare.
10363         * ada-tasks.c (struct ada_tasks_inferior_data)
10364         <task_list_valid_p>: Now bool.
10365         (read_known_tasks, ada_task_list_changed)
10366         (ada_tasks_invalidate_inferior_data): Update.
10367         (read_known_tasks_array): Return bool.
10368         (read_known_tasks_list): Likewise.
10369         (read_known_tasks): Return void.
10370         (ada_build_task_list): Now static.
10371
10372 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10373
10374         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10375         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10376
10377 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10378
10379         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10380         variant for ada_tasks_pspace_data_handle and
10381         ada_tasks_inferior_data_handle.
10382         (ada_tasks_pspace_data_cleanup): New function.
10383         (ada_tasks_inferior_data_cleanup): New function.
10384
10385 2019-02-17  Tom Tromey  <tom@tromey.com>
10386
10387         * macrotab.h (macro_source_fullname): Return a std::string.
10388         * macrotab.c (macro_include, check_for_redefinition)
10389         (macro_undef, macro_lookup_definition, foreach_macro)
10390         (foreach_macro_in_scope): Update.
10391         (macro_source_fullname): Return a std::string.
10392         * macrocmd.c (show_pp_source_pos): Update.
10393
10394 2019-02-17  Tom Tromey  <tom@tromey.com>
10395
10396         * macrocmd.c (show_pp_source_pos): Style the file names.
10397
10398 2019-02-17  Tom Tromey  <tom@tromey.com>
10399
10400         PR tui/24197:
10401         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10402
10403 2019-02-17  Tom Tromey  <tom@tromey.com>
10404
10405         * ada-lang.c (user_select_syms): Use filtered printing.
10406         * utils.c (wrap_style): New global.
10407         (desired_style): Remove.
10408         (emit_style_escape): Add stream parameter.
10409         (set_output_style, reset_terminal_style, prompt_for_continue):
10410         Update.
10411         (flush_wrap_buffer): Only flush gdb_stdout.
10412         (wrap_here): Set wrap_style.
10413         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10414         treat escape sequences as a character.  Change when wrap buffer is
10415         flushed.
10416         (fputs_styled): Do not set the output style when the default is
10417         requested.
10418         * ui-style.h (struct ui_file_style) <is_default>: New method.
10419         * source.c (print_source_lines_base): Emit escape sequences in one
10420         piece.
10421
10422 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10423
10424         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10425         integers and enumeration types.
10426
10427 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10428
10429         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10430         instead of lookup_symbol_in_language
10431         (do_exact_match): New function.
10432         (ada_get_symbol_name_matcher): Return do_exact_match when
10433         doing a verbatim match.
10434
10435 2019-02-15  Tom Tromey  <tromey@adacore.com>
10436
10437         * ravenscar-thread.c (ravenscar_thread_target::resume)
10438         (ravenscar_thread_target::wait): Special case wildcard requests.
10439
10440 2019-02-15  Tom Tromey  <tromey@adacore.com>
10441
10442         * ravenscar-thread.c (base_ptid): Remove.
10443         (struct ravenscar_thread_target) <close>: New method.
10444         <m_base_ptid>: New member.
10445         <update_inferior_ptid, active_task, task_is_currently_active,
10446         runtime_initialized>: Declare methods.
10447         <ravenscar_thread_target>: Add constructor.
10448         (ravenscar_thread_target::task_is_currently_active)
10449         (ravenscar_thread_target::update_inferior_ptid)
10450         (ravenscar_runtime_initialized): Rename.  Now methods.
10451         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10452         (ravenscar_thread_target::update_thread_list): Update.
10453         (ravenscar_thread_target::active_task): Now method.
10454         (ravenscar_thread_target::store_registers)
10455         (ravenscar_thread_target::prepare_to_store)
10456         (ravenscar_thread_target::prepare_to_store)
10457         (ravenscar_thread_target::mourn_inferior): Update.
10458         (ravenscar_inferior_created): Use "new" to create target.
10459         (ravenscar_thread_target::get_ada_task_ptid): Update.
10460         (_initialize_ravenscar): Don't initialize base_ptid.
10461         (ravenscar_ops): Remove global.
10462
10463 2019-02-15  Tom Tromey  <tromey@adacore.com>
10464
10465         * target.h (push_target): Declare new overload.
10466         * target.c (push_target): New overload, taking an rvalue reference.
10467         * remote.c (remote_target::open_1): Use push_target overload.
10468         * corelow.c (core_target_open): Use push_target overload.
10469
10470 2019-02-15  Tom Tromey  <tromey@adacore.com>
10471
10472         * ravenscar-thread.c (is_ravenscar_task)
10473         (ravenscar_task_is_currently_active): Return bool.
10474         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10475         (_initialize_ravenscar): Remove "(void)".
10476         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10477         Return bool.
10478
10479 2019-02-15  Tom Tromey  <tromey@adacore.com>
10480
10481         * ravenscar-thread.c (ravenscar_runtime_initializer)
10482         (has_ravenscar_runtime, get_running_thread_id)
10483         (ravenscar_thread_target::resume): Fix indentation.
10484
10485 2019-02-15  Tom Tromey  <tromey@adacore.com>
10486
10487         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10488         from ravenscar_arch_ops.
10489         (sparc_ravenscar_ops::fetch_registers)
10490         (sparc_ravenscar_ops::store_registers): Now methods.
10491         (sparc_ravenscar_prepare_to_store): Remove.
10492         (sparc_ravenscar_ops): Redefine.
10493         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10494         methods and destructor.  Remove members.
10495         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10496         (ravenscar_thread_target::store_registers)
10497         (ravenscar_thread_target::prepare_to_store): Update.
10498         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10499         Remove.
10500         (struct ppc_ravenscar_powerpc_ops): Derive from
10501         ravenscar_arch_ops.
10502         (ppc_ravenscar_powerpc_ops::fetch_registers)
10503         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10504         (ppc_ravenscar_powerpc_ops): Redefine.
10505         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10506         (ppc_ravenscar_e500_ops::fetch_registers)
10507         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10508         (ppc_ravenscar_e500_ops): Redefine.
10509         * aarch64-ravenscar-thread.c
10510         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10511         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10512         (aarch64_ravenscar_fetch_registers)
10513         (aarch64_ravenscar_store_registers): Now methods.
10514         (aarch64_ravenscar_ops): Redefine.
10515
10516 2019-02-15  Tom Tromey  <tromey@adacore.com>
10517
10518         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10519         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10520         (ravenscar_thread_target::stopped_by_watchpoint)
10521         (ravenscar_thread_target::stopped_data_address)
10522         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10523
10524 2019-02-15  Tom Tromey  <tromey@adacore.com>
10525
10526         * ravenscar-thread.c: Fix some typos.
10527
10528 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10529             Tom Tromey  <tromey@adacore.com>
10530
10531         * ada-lang.c (ada_exception_sal): Change addr_string to a
10532         std::string.
10533         (create_ada_exception_catchpoint): Update.
10534
10535 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10536             Tom Tromey  <tromey@adacore.com>
10537
10538         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10539         (bp_location_ops): Remove.
10540         (base_breakpoint_allocate_location): Update.
10541         (free_bp_location): Update.
10542         * ada-lang.c (class ada_catchpoint_location)
10543         <ada_catchpoint_location>: Remove ops parameter.
10544         (ada_catchpoint_location_dtor): Remove.
10545         (ada_catchpoint_location_ops): Remove.
10546         (allocate_location_exception): Update.
10547         * breakpoint.h (struct bp_location_ops): Remove.
10548         (class bp_location) <bp_location>: Remove bp_location_ops
10549         parameter.
10550         <~bp_location>: Add destructor.
10551         <ops>: Remove.
10552
10553 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10554             Pedro Alves  <palves@redhat.com>
10555
10556         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10557         'PATH_MAX'.
10558
10559 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10560             Samuel Thibault  <samuel.thibault@gnu.org>
10561             Thomas Schwinge  <thomas@codesourcery.com>
10562
10563         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10564         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10565
10566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10567
10568         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10569         (check_empty): Use "const char *".
10570
10571         * gnu-nat.c (gnu_nat_target::detach): Instead of
10572         'detach_inferior (pid)' call
10573         'detach_inferior (find_inferior_pid (pid))'.
10574
10575         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10576         'nat/fork-inferior.o'.
10577         * gnu-nat.c: #include "nat/fork-inferior.h".
10578
10579         * gnu-nat.c (gnu_nat_target::detach): Instead of
10580         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10581         * gnu-nat.h: #include "inf-child.h".
10582         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10583         'i386_gnu_nat_target::fetch_registers'.
10584         (gnu_store_registers): Rename/move to
10585         'i386_gnu_nat_target::store_registers'.
10586
10587         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10588         * gnu-nat.h (mach_thread_info): New function.
10589         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10590
10591         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10592
10593 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10594
10595         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10596
10597 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10598
10599         * windows-nat.c (windows_add_thread): Add new parameter
10600         "main_thread_p" with default value set to false.  Update
10601         function documentation as well as all callers.
10602         (windows_delete_thread): Likewise.
10603         (fake_create_process): Update call to windows_add_thread.
10604         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10605         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10606         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10607         call to windows_delete_thread.
10608
10609 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10610
10611         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10612
10613 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10614
10615         * symfile.c (find_separate_debug_file): Use canonical path of
10616         sysroot with child_path instead of gdb_sysroot if it is valid.
10617
10618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10619
10620         * symfile.c (find_separate_debug_file): Use child_path to
10621         determine if an object file is under a sysroot.
10622
10623 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10624
10625         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10626         unittests/child-path-selftests.c.
10627         * common/pathstuff.c (child_path): New function.
10628         * common/pathstuff.h (child_path): New prototype.
10629         * unittests/child-path-selftests.c: New file.
10630
10631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10632
10633         * symfile.c (find_separate_debug_file): Look for separate debug
10634         files in debug directories under the sysroot.
10635
10636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10637
10638         * symtab.h (struct minimal_symbol data_p): New const method.
10639         (struct minimal_symbol text_p): Likewise.
10640         * symtab.c (output_source_filename): Use file name style
10641         to print file name.
10642         (print_symbol_info): Likewise.
10643         (print_msymbol_info): Use address style to print addresses.
10644         Use function name style to print executable text symbols.
10645         (expand_symtab_containing_pc): Use data_p.
10646         (find_pc_sect_compunit_symtab): Likewise.
10647
10648 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10649
10650         * breakpoint.c (describe_other_breakpoints): Use address style
10651         to print addresses.
10652         (say_where): Likewise.
10653
10654 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10655
10656         * ada-typeprint.c (print_func_type): Print function name
10657         style to print function name.
10658         * c-typeprint.c (c_print_type_1): Likewise.
10659
10660 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10661
10662         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10663         for execve.
10664
10665 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10666
10667         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10668         type_stack.
10669
10670 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10671
10672         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10673         TYPE_CODE_REF types.
10674
10675 2019-02-08  Jim Wilson  <jimw@sifive.com>
10676
10677         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10678         (riscv_linux_fregset): New.
10679         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10680
10681 2019-02-07  Tom Tromey  <tom@tromey.com>
10682
10683         * thread.c (thread_cancel_execution_command): Update.
10684         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10685         methods.
10686         (struct thread_fsm_ops): Remove.
10687         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10688         (thread_fsm_should_stop, thread_fsm_return_value)
10689         (thread_fsm_set_finished, thread_fsm_finished_p)
10690         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10691         Don't declare.
10692         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10693         * infrun.c (clear_proceed_status_thread)
10694         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10695         (print_stop_event): Update.
10696         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10697         Add constructor.
10698         (step_command_fsm_ops): Remove.
10699         (new_step_command_fsm): Remove.
10700         (step_1): Update.
10701         (step_command_fsm::should_stop): Rename from
10702         step_command_fsm_should_stop.
10703         (step_command_fsm::clean_up): Rename from
10704         step_command_fsm_clean_up.
10705         (step_command_fsm::do_async_reply_reason): Rename from
10706         step_command_fsm_async_reply_reason.
10707         (struct until_next_fsm): Inherit from thread_fsm.  Add
10708         constructor.
10709         (until_next_fsm_ops): Remove.
10710         (new_until_next_fsm): Remove.
10711         (until_next_fsm::should_stop): Rename from
10712         until_next_fsm_should_stop.
10713         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10714         (until_next_fsm::do_async_reply_reason): Rename from
10715         until_next_fsm_async_reply_reason.
10716         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10717         constructor.  Change type of breakpoint.
10718         (finish_command_fsm_ops): Remove.
10719         (new_finish_command_fsm): Remove.
10720         (finish_command_fsm::should_stop): Rename from
10721         finish_command_fsm_should_stop.
10722         (finish_command_fsm::clean_up): Rename from
10723         finish_command_fsm_clean_up.
10724         (finish_command_fsm::return_value): Rename from
10725         finish_command_fsm_return_value.
10726         (finish_command_fsm::do_async_reply_reason): Rename from
10727         finish_command_fsm_async_reply_reason.
10728         (finish_command): Update.
10729         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10730         Add constructor.
10731         (call_thread_fsm_ops): Remove.
10732         (call_thread_fsm::call_thread_fsm): Rename from
10733         new_call_thread_fsm.
10734         (call_thread_fsm::should_stop): Rename from
10735         call_thread_fsm_should_stop.
10736         (call_thread_fsm::should_notify_stop): Rename from
10737         call_thread_fsm_should_notify_stop.
10738         (run_inferior_call, call_function_by_hand_dummy): Update.
10739         * cli/cli-interp.c (should_print_stop_to_console): Update.
10740         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10741         Add constructor.  Change type of location_breakpoint,
10742         caller_breakpoint.
10743         (until_break_fsm_ops): Remove.
10744         (new_until_break_fsm): Remove.
10745         (until_break_fsm::should_stop): Rename from
10746         until_break_fsm_should_stop.
10747         (until_break_fsm::clean_up): Rename from
10748         until_break_fsm_clean_up.
10749         (until_break_fsm::do_async_reply_reason): Rename from
10750         until_break_fsm_async_reply_reason.
10751         (until_break_command): Update.
10752         * thread-fsm.c: Remove.
10753         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10754
10755 2019-02-07  Tom Tromey  <tom@tromey.com>
10756
10757         * yy-remap.h: Add include guard.
10758         * xtensa-tdep.h: Add include guard.
10759         * xcoffread.h: Rename include guard.
10760         * varobj-iter.h: Add include guard.
10761         * tui/tui.h: Rename include guard.
10762         * tui/tui-winsource.h: Rename include guard.
10763         * tui/tui-wingeneral.h: Rename include guard.
10764         * tui/tui-windata.h: Rename include guard.
10765         * tui/tui-win.h: Rename include guard.
10766         * tui/tui-stack.h: Rename include guard.
10767         * tui/tui-source.h: Rename include guard.
10768         * tui/tui-regs.h: Rename include guard.
10769         * tui/tui-out.h: Rename include guard.
10770         * tui/tui-layout.h: Rename include guard.
10771         * tui/tui-io.h: Rename include guard.
10772         * tui/tui-hooks.h: Rename include guard.
10773         * tui/tui-file.h: Rename include guard.
10774         * tui/tui-disasm.h: Rename include guard.
10775         * tui/tui-data.h: Rename include guard.
10776         * tui/tui-command.h: Rename include guard.
10777         * tic6x-tdep.h: Add include guard.
10778         * target/waitstatus.h: Rename include guard.
10779         * target/wait.h: Rename include guard.
10780         * target/target.h: Rename include guard.
10781         * target/resume.h: Rename include guard.
10782         * target-float.h: Rename include guard.
10783         * stabsread.h: Add include guard.
10784         * rs6000-tdep.h: Add include guard.
10785         * riscv-fbsd-tdep.h: Add include guard.
10786         * regformats/regdef.h: Rename include guard.
10787         * record.h: Rename include guard.
10788         * python/python.h: Rename include guard.
10789         * python/python-internal.h: Rename include guard.
10790         * python/py-stopevent.h: Rename include guard.
10791         * python/py-ref.h: Rename include guard.
10792         * python/py-record.h: Rename include guard.
10793         * python/py-record-full.h: Rename include guard.
10794         * python/py-record-btrace.h: Rename include guard.
10795         * python/py-instruction.h: Rename include guard.
10796         * python/py-events.h: Rename include guard.
10797         * python/py-event.h: Rename include guard.
10798         * procfs.h: Add include guard.
10799         * proc-utils.h: Add include guard.
10800         * p-lang.h: Add include guard.
10801         * or1k-tdep.h: Rename include guard.
10802         * observable.h: Rename include guard.
10803         * nto-tdep.h: Rename include guard.
10804         * nat/x86-linux.h: Rename include guard.
10805         * nat/x86-linux-dregs.h: Rename include guard.
10806         * nat/x86-gcc-cpuid.h: Add include guard.
10807         * nat/x86-dregs.h: Rename include guard.
10808         * nat/x86-cpuid.h: Rename include guard.
10809         * nat/ppc-linux.h: Rename include guard.
10810         * nat/mips-linux-watch.h: Rename include guard.
10811         * nat/linux-waitpid.h: Rename include guard.
10812         * nat/linux-ptrace.h: Rename include guard.
10813         * nat/linux-procfs.h: Rename include guard.
10814         * nat/linux-osdata.h: Rename include guard.
10815         * nat/linux-nat.h: Rename include guard.
10816         * nat/linux-namespaces.h: Rename include guard.
10817         * nat/linux-btrace.h: Rename include guard.
10818         * nat/glibc_thread_db.h: Rename include guard.
10819         * nat/gdb_thread_db.h: Rename include guard.
10820         * nat/gdb_ptrace.h: Rename include guard.
10821         * nat/fork-inferior.h: Rename include guard.
10822         * nat/amd64-linux-siginfo.h: Rename include guard.
10823         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10824         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10825         * nat/aarch64-linux.h: Rename include guard.
10826         * nat/aarch64-linux-hw-point.h: Rename include guard.
10827         * mn10300-tdep.h: Add include guard.
10828         * mips-linux-tdep.h: Add include guard.
10829         * mi/mi-parse.h: Rename include guard.
10830         * mi/mi-out.h: Rename include guard.
10831         * mi/mi-main.h: Rename include guard.
10832         * mi/mi-interp.h: Rename include guard.
10833         * mi/mi-getopt.h: Rename include guard.
10834         * mi/mi-console.h: Rename include guard.
10835         * mi/mi-common.h: Rename include guard.
10836         * mi/mi-cmds.h: Rename include guard.
10837         * mi/mi-cmd-break.h: Rename include guard.
10838         * m2-lang.h: Add include guard.
10839         * location.h: Rename include guard.
10840         * linux-record.h: Rename include guard.
10841         * linux-nat.h: Add include guard.
10842         * linux-fork.h: Add include guard.
10843         * i386-darwin-tdep.h: Rename include guard.
10844         * hppa-linux-offsets.h: Add include guard.
10845         * guile/guile.h: Rename include guard.
10846         * guile/guile-internal.h: Rename include guard.
10847         * gnu-nat.h: Rename include guard.
10848         * gdb-stabs.h: Rename include guard.
10849         * frv-tdep.h: Add include guard.
10850         * f-lang.h: Add include guard.
10851         * event-loop.h: Add include guard.
10852         * darwin-nat.h: Rename include guard.
10853         * cp-abi.h: Rename include guard.
10854         * config/sparc/nm-sol2.h: Rename include guard.
10855         * config/nm-nto.h: Rename include guard.
10856         * config/nm-linux.h: Add include guard.
10857         * config/i386/nm-i386gnu.h: Rename include guard.
10858         * config/djgpp/nl_types.h: Rename include guard.
10859         * config/djgpp/langinfo.h: Rename include guard.
10860         * compile/gcc-cp-plugin.h: Add include guard.
10861         * compile/gcc-c-plugin.h: Add include guard.
10862         * compile/compile.h: Rename include guard.
10863         * compile/compile-object-run.h: Rename include guard.
10864         * compile/compile-object-load.h: Rename include guard.
10865         * compile/compile-internal.h: Rename include guard.
10866         * compile/compile-cplus.h: Rename include guard.
10867         * compile/compile-c.h: Rename include guard.
10868         * common/xml-utils.h: Rename include guard.
10869         * common/x86-xstate.h: Rename include guard.
10870         * common/version.h: Rename include guard.
10871         * common/vec.h: Rename include guard.
10872         * common/tdesc.h: Rename include guard.
10873         * common/selftest.h: Rename include guard.
10874         * common/scoped_restore.h: Rename include guard.
10875         * common/scoped_mmap.h: Rename include guard.
10876         * common/scoped_fd.h: Rename include guard.
10877         * common/safe-iterator.h: Rename include guard.
10878         * common/run-time-clock.h: Rename include guard.
10879         * common/refcounted-object.h: Rename include guard.
10880         * common/queue.h: Rename include guard.
10881         * common/ptid.h: Rename include guard.
10882         * common/print-utils.h: Rename include guard.
10883         * common/preprocessor.h: Rename include guard.
10884         * common/pathstuff.h: Rename include guard.
10885         * common/observable.h: Rename include guard.
10886         * common/netstuff.h: Rename include guard.
10887         * common/job-control.h: Rename include guard.
10888         * common/host-defs.h: Rename include guard.
10889         * common/gdb_wait.h: Rename include guard.
10890         * common/gdb_vecs.h: Rename include guard.
10891         * common/gdb_unlinker.h: Rename include guard.
10892         * common/gdb_unique_ptr.h: Rename include guard.
10893         * common/gdb_tilde_expand.h: Rename include guard.
10894         * common/gdb_sys_time.h: Rename include guard.
10895         * common/gdb_string_view.h: Rename include guard.
10896         * common/gdb_splay_tree.h: Rename include guard.
10897         * common/gdb_setjmp.h: Rename include guard.
10898         * common/gdb_ref_ptr.h: Rename include guard.
10899         * common/gdb_optional.h: Rename include guard.
10900         * common/gdb_locale.h: Rename include guard.
10901         * common/gdb_assert.h: Rename include guard.
10902         * common/filtered-iterator.h: Rename include guard.
10903         * common/filestuff.h: Rename include guard.
10904         * common/fileio.h: Rename include guard.
10905         * common/environ.h: Rename include guard.
10906         * common/common-utils.h: Rename include guard.
10907         * common/common-types.h: Rename include guard.
10908         * common/common-regcache.h: Rename include guard.
10909         * common/common-inferior.h: Rename include guard.
10910         * common/common-gdbthread.h: Rename include guard.
10911         * common/common-exceptions.h: Rename include guard.
10912         * common/common-defs.h: Rename include guard.
10913         * common/common-debug.h: Rename include guard.
10914         * common/cleanups.h: Rename include guard.
10915         * common/buffer.h: Rename include guard.
10916         * common/btrace-common.h: Rename include guard.
10917         * common/break-common.h: Rename include guard.
10918         * cli/cli-utils.h: Rename include guard.
10919         * cli/cli-style.h: Rename include guard.
10920         * cli/cli-setshow.h: Rename include guard.
10921         * cli/cli-script.h: Rename include guard.
10922         * cli/cli-interp.h: Rename include guard.
10923         * cli/cli-decode.h: Rename include guard.
10924         * cli/cli-cmds.h: Rename include guard.
10925         * charset-list.h: Add include guard.
10926         * buildsym-legacy.h: Rename include guard.
10927         * bfin-tdep.h: Add include guard.
10928         * ax.h: Rename include guard.
10929         * arm-linux-tdep.h: Add include guard.
10930         * arm-fbsd-tdep.h: Add include guard.
10931         * arch/xtensa.h: Rename include guard.
10932         * arch/tic6x.h: Add include guard.
10933         * arch/i386.h: Add include guard.
10934         * arch/arm.h: Rename include guard.
10935         * arch/arm-linux.h: Rename include guard.
10936         * arch/arm-get-next-pcs.h: Rename include guard.
10937         * arch/amd64.h: Add include guard.
10938         * arch/aarch64-insn.h: Rename include guard.
10939         * arch-utils.h: Rename include guard.
10940         * annotate.h: Add include guard.
10941         * amd64-darwin-tdep.h: Rename include guard.
10942         * aarch64-linux-tdep.h: Add include guard.
10943         * aarch64-fbsd-tdep.h: Add include guard.
10944         * aarch32-linux-nat.h: Add include guard.
10945
10946 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10947
10948         * macrotab.c (macro_define_internal): New function that
10949         factorizes macro_define_object_internal and macro_define_function
10950         code.
10951         (macro_define_object_internal): Use macro_define_internal.
10952         (macro_define_function): Likewise.
10953
10954 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10955
10956         * macrocmd.c (extract_identifier): Return
10957         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10958         callers.
10959
10960 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10961
10962         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10963
10964 2019-02-05  Tom Tromey  <tom@tromey.com>
10965
10966         * target.c (target_stack::unpush): Move assertion earlier.
10967
10968 2019-01-30  Tom Tromey  <tom@tromey.com>
10969
10970         PR python/23615:
10971         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10972         (gdbpy_parse_and_eval): Likewise.
10973         * python/python-internal.h (gdbpy_allow_threads): New class.
10974
10975 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10976
10977         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10978         (aarch64_fbsd_fpregmap): Move earlier.
10979         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10980         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10981         instead of individual calls to trad_frame_set_reg_addr.
10982         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10983         earlier.
10984         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10985         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10986         instead of individual calls to trad_frame_set_reg_addr.
10987
10988 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10989
10990         * CONTRIBUTE: Replace contribution list with wiki link.
10991
10992 2019-01-25  Tom Tromey  <tom@tromey.com>
10993
10994         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10995
10996 2019-01-25  Tom Tromey  <tom@tromey.com>
10997
10998         * xtensa-linux-nat.c: Fix common/ includes.
10999         * xml-support.h: Fix common/ includes.
11000         * xml-support.c: Fix common/ includes.
11001         * x86-linux-nat.c: Fix common/ includes.
11002         * windows-nat.c: Fix common/ includes.
11003         * varobj.h: Fix common/ includes.
11004         * varobj.c: Fix common/ includes.
11005         * value.c: Fix common/ includes.
11006         * valops.c: Fix common/ includes.
11007         * utils.c: Fix common/ includes.
11008         * unittests/xml-utils-selftests.c: Fix common/ includes.
11009         * unittests/utils-selftests.c: Fix common/ includes.
11010         * unittests/unpack-selftests.c: Fix common/ includes.
11011         * unittests/tracepoint-selftests.c: Fix common/ includes.
11012         * unittests/style-selftests.c: Fix common/ includes.
11013         * unittests/string_view-selftests.c: Fix common/ includes.
11014         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11015         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11016         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11017         * unittests/rsp-low-selftests.c: Fix common/ includes.
11018         * unittests/parse-connection-spec-selftests.c: Fix common/
11019         includes.
11020         * unittests/optional-selftests.c: Fix common/ includes.
11021         * unittests/offset-type-selftests.c: Fix common/ includes.
11022         * unittests/observable-selftests.c: Fix common/ includes.
11023         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11024         * unittests/memrange-selftests.c: Fix common/ includes.
11025         * unittests/memory-map-selftests.c: Fix common/ includes.
11026         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11027         * unittests/function-view-selftests.c: Fix common/ includes.
11028         * unittests/environ-selftests.c: Fix common/ includes.
11029         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11030         * unittests/common-utils-selftests.c: Fix common/ includes.
11031         * unittests/cli-utils-selftests.c: Fix common/ includes.
11032         * unittests/array-view-selftests.c: Fix common/ includes.
11033         * ui-file.c: Fix common/ includes.
11034         * tui/tui-io.c: Fix common/ includes.
11035         * tracepoint.h: Fix common/ includes.
11036         * tracepoint.c: Fix common/ includes.
11037         * tracefile-tfile.c: Fix common/ includes.
11038         * top.h: Fix common/ includes.
11039         * top.c: Fix common/ includes.
11040         * thread.c: Fix common/ includes.
11041         * target/waitstatus.h: Fix common/ includes.
11042         * target/waitstatus.c: Fix common/ includes.
11043         * target.h: Fix common/ includes.
11044         * target.c: Fix common/ includes.
11045         * target-memory.c: Fix common/ includes.
11046         * target-descriptions.c: Fix common/ includes.
11047         * symtab.h: Fix common/ includes.
11048         * symfile.c: Fix common/ includes.
11049         * stap-probe.c: Fix common/ includes.
11050         * spu-linux-nat.c: Fix common/ includes.
11051         * sparc-nat.c: Fix common/ includes.
11052         * source.c: Fix common/ includes.
11053         * solib.c: Fix common/ includes.
11054         * solib-target.c: Fix common/ includes.
11055         * ser-unix.c: Fix common/ includes.
11056         * ser-tcp.c: Fix common/ includes.
11057         * ser-pipe.c: Fix common/ includes.
11058         * ser-base.c: Fix common/ includes.
11059         * selftest-arch.c: Fix common/ includes.
11060         * s12z-tdep.c: Fix common/ includes.
11061         * rust-exp.y: Fix common/ includes.
11062         * rs6000-aix-tdep.c: Fix common/ includes.
11063         * riscv-tdep.c: Fix common/ includes.
11064         * remote.c: Fix common/ includes.
11065         * remote-notif.h: Fix common/ includes.
11066         * remote-fileio.h: Fix common/ includes.
11067         * remote-fileio.c: Fix common/ includes.
11068         * regcache.h: Fix common/ includes.
11069         * regcache.c: Fix common/ includes.
11070         * record-btrace.c: Fix common/ includes.
11071         * python/python.c: Fix common/ includes.
11072         * python/py-type.c: Fix common/ includes.
11073         * python/py-inferior.c: Fix common/ includes.
11074         * progspace.h: Fix common/ includes.
11075         * producer.c: Fix common/ includes.
11076         * procfs.c: Fix common/ includes.
11077         * proc-api.c: Fix common/ includes.
11078         * printcmd.c: Fix common/ includes.
11079         * ppc-linux-nat.c: Fix common/ includes.
11080         * parser-defs.h: Fix common/ includes.
11081         * osdata.c: Fix common/ includes.
11082         * obsd-nat.c: Fix common/ includes.
11083         * nat/x86-linux.c: Fix common/ includes.
11084         * nat/x86-linux-dregs.c: Fix common/ includes.
11085         * nat/x86-dregs.h: Fix common/ includes.
11086         * nat/x86-dregs.c: Fix common/ includes.
11087         * nat/ppc-linux.c: Fix common/ includes.
11088         * nat/mips-linux-watch.h: Fix common/ includes.
11089         * nat/mips-linux-watch.c: Fix common/ includes.
11090         * nat/linux-waitpid.c: Fix common/ includes.
11091         * nat/linux-ptrace.h: Fix common/ includes.
11092         * nat/linux-ptrace.c: Fix common/ includes.
11093         * nat/linux-procfs.c: Fix common/ includes.
11094         * nat/linux-personality.c: Fix common/ includes.
11095         * nat/linux-osdata.c: Fix common/ includes.
11096         * nat/linux-namespaces.c: Fix common/ includes.
11097         * nat/linux-btrace.h: Fix common/ includes.
11098         * nat/linux-btrace.c: Fix common/ includes.
11099         * nat/fork-inferior.c: Fix common/ includes.
11100         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11101         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11102         * nat/aarch64-linux.c: Fix common/ includes.
11103         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11104         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11105         * namespace.h: Fix common/ includes.
11106         * mips-linux-tdep.c: Fix common/ includes.
11107         * minsyms.c: Fix common/ includes.
11108         * mi/mi-parse.h: Fix common/ includes.
11109         * mi/mi-main.c: Fix common/ includes.
11110         * mi/mi-cmd-env.c: Fix common/ includes.
11111         * memrange.h: Fix common/ includes.
11112         * memattr.c: Fix common/ includes.
11113         * maint.h: Fix common/ includes.
11114         * maint.c: Fix common/ includes.
11115         * main.c: Fix common/ includes.
11116         * machoread.c: Fix common/ includes.
11117         * location.c: Fix common/ includes.
11118         * linux-thread-db.c: Fix common/ includes.
11119         * linux-nat.c: Fix common/ includes.
11120         * linux-fork.c: Fix common/ includes.
11121         * inline-frame.c: Fix common/ includes.
11122         * infrun.c: Fix common/ includes.
11123         * inflow.c: Fix common/ includes.
11124         * inferior.h: Fix common/ includes.
11125         * inferior.c: Fix common/ includes.
11126         * infcmd.c: Fix common/ includes.
11127         * inf-ptrace.c: Fix common/ includes.
11128         * inf-child.c: Fix common/ includes.
11129         * ia64-linux-nat.c: Fix common/ includes.
11130         * i387-tdep.c: Fix common/ includes.
11131         * i386-tdep.c: Fix common/ includes.
11132         * i386-linux-tdep.c: Fix common/ includes.
11133         * i386-linux-nat.c: Fix common/ includes.
11134         * i386-go32-tdep.c: Fix common/ includes.
11135         * i386-fbsd-tdep.c: Fix common/ includes.
11136         * i386-fbsd-nat.c: Fix common/ includes.
11137         * guile/scm-type.c: Fix common/ includes.
11138         * guile/guile.c: Fix common/ includes.
11139         * go32-nat.c: Fix common/ includes.
11140         * gnu-nat.c: Fix common/ includes.
11141         * gdbthread.h: Fix common/ includes.
11142         * gdbarch-selftests.c: Fix common/ includes.
11143         * gdb_usleep.c: Fix common/ includes.
11144         * gdb_select.h: Fix common/ includes.
11145         * gdb_bfd.c: Fix common/ includes.
11146         * gcore.c: Fix common/ includes.
11147         * fork-child.c: Fix common/ includes.
11148         * findvar.c: Fix common/ includes.
11149         * fbsd-nat.c: Fix common/ includes.
11150         * event-top.c: Fix common/ includes.
11151         * event-loop.c: Fix common/ includes.
11152         * dwarf2read.c: Fix common/ includes.
11153         * dwarf2loc.c: Fix common/ includes.
11154         * dwarf2-frame.c: Fix common/ includes.
11155         * dwarf-index-cache.c: Fix common/ includes.
11156         * dtrace-probe.c: Fix common/ includes.
11157         * disasm-selftests.c: Fix common/ includes.
11158         * defs.h: Fix common/ includes.
11159         * csky-tdep.c: Fix common/ includes.
11160         * cp-valprint.c: Fix common/ includes.
11161         * cp-support.h: Fix common/ includes.
11162         * cp-support.c: Fix common/ includes.
11163         * corelow.c: Fix common/ includes.
11164         * completer.h: Fix common/ includes.
11165         * completer.c: Fix common/ includes.
11166         * compile/compile.c: Fix common/ includes.
11167         * compile/compile-loc2c.c: Fix common/ includes.
11168         * compile/compile-cplus-types.c: Fix common/ includes.
11169         * compile/compile-cplus-symbols.c: Fix common/ includes.
11170         * command.h: Fix common/ includes.
11171         * cli/cli-dump.c: Fix common/ includes.
11172         * cli/cli-cmds.c: Fix common/ includes.
11173         * charset.c: Fix common/ includes.
11174         * build-id.c: Fix common/ includes.
11175         * btrace.h: Fix common/ includes.
11176         * btrace.c: Fix common/ includes.
11177         * breakpoint.h: Fix common/ includes.
11178         * breakpoint.c: Fix common/ includes.
11179         * ax.h:
11180         (enum agent_op): Fix common/ includes.
11181         * ax-general.c (struct aop_map): Fix common/ includes.
11182         * ax-gdb.c: Fix common/ includes.
11183         * auxv.c: Fix common/ includes.
11184         * auto-load.c: Fix common/ includes.
11185         * arm-tdep.c: Fix common/ includes.
11186         * arch/riscv.c: Fix common/ includes.
11187         * arch/ppc-linux-common.c: Fix common/ includes.
11188         * arch/i386.c: Fix common/ includes.
11189         * arch/arm.c: Fix common/ includes.
11190         * arch/arm-linux.c: Fix common/ includes.
11191         * arch/arm-get-next-pcs.c: Fix common/ includes.
11192         * arch/amd64.c: Fix common/ includes.
11193         * arch/aarch64.c: Fix common/ includes.
11194         * arch/aarch64-insn.c: Fix common/ includes.
11195         * arch-utils.c: Fix common/ includes.
11196         * amd64-windows-tdep.c: Fix common/ includes.
11197         * amd64-tdep.c: Fix common/ includes.
11198         * amd64-sol2-tdep.c: Fix common/ includes.
11199         * amd64-obsd-tdep.c: Fix common/ includes.
11200         * amd64-nbsd-tdep.c: Fix common/ includes.
11201         * amd64-linux-tdep.c: Fix common/ includes.
11202         * amd64-linux-nat.c: Fix common/ includes.
11203         * amd64-fbsd-tdep.c: Fix common/ includes.
11204         * amd64-fbsd-nat.c: Fix common/ includes.
11205         * amd64-dicos-tdep.c: Fix common/ includes.
11206         * amd64-darwin-tdep.c: Fix common/ includes.
11207         * agent.c: Fix common/ includes.
11208         * ada-lang.h: Fix common/ includes.
11209         * ada-lang.c: Fix common/ includes.
11210         * aarch64-tdep.c: Fix common/ includes.
11211
11212 2019-01-25  Tom Tromey  <tom@tromey.com>
11213
11214         * common/create-version.sh: Use common/version.h.
11215
11216 2019-01-24  Pedro Alves  <palves@redhat.com>
11217
11218         * infrun.c (signal_stop, signal_print, signal_program)
11219         (signal_catch, signal_pass): Now arrays instead of pointers.
11220         (update_signals_program_target, do_target_resume)
11221         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11222         * linux-nat.c (linux_nat_target::pass_signals)
11223         (linux_nat_target::create_inferior, linux_nat_target::attach):
11224         Adjust.
11225         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11226         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11227         * procfs.c (procfs_target::pass_signals): Adjust.
11228         * record-full.c (record_full_target::resume): Adjust.
11229         * remote.c (remote_target::pass_signals)
11230         (remote_target::program_signals): Adjust.
11231         * target-debug.h (target_debug_print_signals): Now takes a
11232         gdb::array_view as parameter.  Adjust.
11233         * target.h (target_ops) <pass_signals, program_signals>: Replace
11234         pointer and length parameters with gdb::array_view.
11235         (target_pass_signals, target_program_signals): Likewise.
11236         * target-delegates.c: Regenerate.
11237
11238 2019-01-24  Pedro Alves  <palves@redhat.com>
11239
11240         * common/forward-scope-exit.h
11241         (forward_scope_exit::forward_scope_exit): Pass arguments to
11242         m_bind_function directly, instead of creating a std::bind and
11243         copying that.
11244
11245 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11246
11247         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11248         for static members.
11249         (pass_in_v_vfp_candidate): Likewise.
11250
11251 2019-01-23  Tom Tromey  <tom@tromey.com>
11252             Pedro Alves  <palves@redhat.com>
11253
11254         * regcache.c (class regcache_invalidator): Remove.
11255         (regcache::raw_write): Use make_scope_exit.
11256
11257 2019-01-23  Tom Tromey  <tom@tromey.com>
11258
11259         * ui-out.h (class ui_out_emit_type): Update comment.
11260
11261 2019-01-23  Tom Tromey  <tom@tromey.com>
11262
11263         * infrun.c (fetch_inferior_event): Update comment.
11264
11265 2019-01-23  Tom Tromey  <tom@tromey.com>
11266             Pedro Alves  <palves@redhat.com>
11267
11268         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11269         parameter.
11270         (fetch_inferior_event): Use SCOPE_EXIT.
11271
11272
11273 2019-01-23  Tom Tromey  <tom@tromey.com>
11274             Pedro Alves  <palves@redhat.com>
11275
11276         * infrun.c (disable_thread_events): Delete.
11277         (stop_all_threads): Use SCOPE_EXIT.
11278
11279 2019-01-23  Tom Tromey  <tom@tromey.com>
11280             Pedro Alves  <palves@redhat.com>
11281
11282         * symfile.c: Include forward-scope-exit.h.
11283         (clear_symtab_users_cleanup): Replace forward declaration with
11284         a FORWARD_SCOPE_EXIT.
11285         (syms_from_objfile_1): Use the forward_scope_exit and
11286         gdb::optional instead of cleanup_function.
11287         (reread_symbols): Use the forward_scope_exit instead of
11288         cleanup_function.
11289         (clear_symtab_users_cleanup): Remove function.
11290
11291 2019-01-23  Tom Tromey  <tom@tromey.com>
11292             Pedro Alves  <palves@redhat.com>
11293
11294         * linux-nat.c: Include scope-exit.h.
11295         (cleanup_target_stop): Remove.
11296         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11297         SCOPE_EXIT.
11298
11299 2019-01-23  Tom Tromey  <tom@tromey.com>
11300             Pedro Alves  <palves@redhat.com>
11301
11302         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11303         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11304
11305 2019-01-23  Tom Tromey  <tom@tromey.com>
11306             Andrew Burgess  <andrew.burgess@embecosm.com>
11307             Pedro Alves  <palves@redhat.com>
11308
11309         * infrun.c (fetch_inferior_event): Use scope_exit.
11310         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11311         * top.c (execute_command): Use scope_exit.
11312         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11313         * utils.c (do_bpstat_clear_actions_cleanup)
11314         (make_bpstat_clear_actions_cleanup): Remove.
11315
11316 2019-01-23  Tom Tromey  <tom@tromey.com>
11317             Pedro Alves  <palves@redhat.com>
11318
11319         * infrun.c: Include "common/scope-exit.h"
11320         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11321         (wait_for_inferior): Use SCOPE_EXIT.
11322         (fetch_inferior_event): Use scope_exit.
11323
11324 2019-01-23  Tom Tromey  <tom@tromey.com>
11325             Pedro Alves  <palves@redhat.com>
11326
11327         * breakpoint.c (create_breakpoint): Remove cleanup.
11328
11329 2019-01-23  Tom Tromey  <tom@tromey.com>
11330             Andrew Burgess  <andrew.burgess@embecosm.com>
11331             Pedro Alves  <palves@redhat.com>
11332
11333 2019-01-23  Pedro Alves  <palves@redhat.com>
11334
11335         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11336
11337 2019-01-23  Pedro Alves  <palves@redhat.com>
11338             Andrew Burgess  <andrew.burgess@embecosm.com>
11339
11340         * gdbthread.h: Include "common/forward-scope-exit.h".
11341         (scoped_finish_thread_state): Redefine custom class in terms of
11342         forward_scope_exit.
11343
11344 2019-01-23  Pedro Alves  <palves@redhat.com>
11345             Andrew Burgess  <andrew.burgess@embecosm.com>
11346
11347         * common/forward-scope-exit.h: New file.
11348
11349 2019-01-23  Pedro Alves  <palves@redhat.com>
11350             Andrew Burgess  <andrew.burgess@embecosm.com>
11351             Tom Tromey  <tom@tromey.com>
11352
11353         * common/scope-exit.h: New file.
11354
11355 2019-01-23  Pedro Alves  <palves@redhat.com>
11356
11357         * common/preprocessor.h (ESC): Rename to ...
11358         (ESC_PARENS): ... this.
11359         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11360         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11361
11362 2019-01-23  Tom Tromey  <tom@tromey.com>
11363
11364         * language.h (class scoped_switch_to_sym_language_if_auto):
11365         Initialize m_lang in both cases.
11366
11367 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11368
11369         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11370         with XCNEW.
11371
11372 2019-01-22  Tom Tromey  <tom@tromey.com>
11373
11374         * corelow.c: Do not include sys/file.h.
11375
11376 2019-01-22  Tom Tromey  <tom@tromey.com>
11377
11378         * tui/tui-wingeneral.h: Include gdb_curses.h.
11379
11380 2019-01-22  Tom Tromey  <tom@tromey.com>
11381
11382         * source-cache.h (class source_cache) <get_source_lines,
11383         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11384
11385 2019-01-22  Tom Tromey  <tom@tromey.com>
11386
11387         * remote-fileio.h (struct remote_target): Declare.
11388
11389 2019-01-22  Tom Tromey  <tom@tromey.com>
11390
11391         * python/py-arch.c: Do not include py-ref.h.
11392         * python/py-bpevent.c: Do not include py-ref.h.
11393         * python/py-cmd.c: Do not include py-ref.h.
11394         * python/py-continueevent.c: Do not include py-ref.h.
11395         * python/py-event.h: Do not include py-ref.h.
11396         * python/py-evtregistry.c: Do not include py-ref.h.
11397         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11398         * python/py-frame.c: Do not include py-ref.h.
11399         * python/py-framefilter.c: Do not include py-ref.h.
11400         * python/py-function.c: Do not include py-ref.h.
11401         * python/py-infevents.c: Do not include py-ref.h.
11402         * python/py-linetable.c: Do not include py-ref.h.
11403         * python/py-objfile.c: Do not include py-ref.h.
11404         * python/py-param.c: Do not include py-ref.h.
11405         * python/py-prettyprint.c: Do not include py-ref.h.
11406         * python/py-progspace.c: Do not include py-ref.h.
11407         * python/py-symbol.c: Do not include py-ref.h.
11408         * python/py-symtab.c: Do not include py-ref.h.
11409         * python/py-type.c: Do not include py-ref.h.
11410         * python/py-unwind.c: Do not include py-ref.h.
11411         * python/py-utils.c: Do not include py-ref.h.
11412         * python/py-value.c: Do not include py-ref.h.
11413         * python/py-varobj.c: Do not include py-ref.h.
11414         * python/py-xmethods.c: Do not include py-ref.h.
11415         * python/python.c: Do not include py-ref.h.
11416         * varobj.c: Do not include py-ref.h.
11417
11418 2019-01-22  Tom Tromey  <tom@tromey.com>
11419
11420         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11421         keyword for bcache.
11422
11423 2019-01-22  Tom Tromey  <tom@tromey.com>
11424
11425         * compile/compile-cplus-types.c: Remove a comment by #include.
11426
11427 2019-01-22  Tom Tromey  <tom@tromey.com>
11428
11429         * compile/gcc-c-plugin.h: Include compile-internal.h.
11430
11431 2019-01-22  Tom Tromey  <tom@tromey.com>
11432
11433         * stabsread.c (EXTERN): Do not define.
11434         (symnum, next_symbol_text_func, processing_gcc_compilation)
11435         (within_function, global_sym_chain, global_stabs)
11436         (previous_stab_code, this_object_header_files)
11437         (n_this_object_header_files)
11438         (n_allocated_this_object_header_files): Define.
11439         * stabsread.h (EXTERN): Never define.  Use "extern".
11440
11441 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11442
11443         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11444         history_value.
11445
11446 2019-01-21  Tom Tromey  <tom@tromey.com>
11447
11448         * ui-out.c: Fix includes.
11449         * tui/tui-source.c: Fix includes.
11450         * target.c: Fix includes.
11451         * remote.c: Fix includes.
11452         * regcache.c: Fix includes.
11453         * python/py-block.c: Fix includes.
11454         * printcmd.c: Fix includes.
11455         * or1k-tdep.c: Fix includes.
11456         * mi/mi-main.c: Fix includes.
11457         * m32r-tdep.c: Fix includes.
11458         * csky-tdep.c: Fix includes.
11459         * compile/compile-cplus-types.c: Fix includes.
11460         * cli/cli-interp.c: Fix includes.
11461
11462 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11463
11464         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11465         for padding.
11466
11467 2019-01-16  Tom Tromey  <tom@tromey.com>
11468
11469         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11470         earlier.
11471         (struct objfile) <msymbols_range>: Move from top level.
11472         <msymbols>: New method.
11473         (class objfile_msymbols): Remove.
11474         * symtab.c (default_collect_symbol_completion_matches_break_on):
11475         Update.
11476         * symmisc.c (dump_msymbols): Update.
11477         * stabsread.c (scan_file_globals): Update.
11478         * objc-lang.c (info_selectors_command, info_classes_command)
11479         (find_methods): Update.
11480         * minsyms.c (find_solib_trampoline_target): Update.
11481         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11482         * coffread.c (coff_symfile_read): Update.
11483         * ada-lang.c (ada_lookup_simple_minsym)
11484         (ada_collect_symbol_completion_matches): Update.
11485
11486 2019-01-16  Tom Tromey  <tom@tromey.com>
11487
11488         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11489         type.  Remove no-argument constructor.
11490         <iterator::operator++>: Simplify.
11491         <begin>: Update.
11492         <end>: Use minimal_symbol_count.
11493
11494 2019-01-16  Tom Tromey  <tom@tromey.com>
11495
11496         * objfiles.h (struct objfile) <psymtabs>: New method.
11497         (class objfile_psymtabs): Remove.
11498         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11499         typedef.
11500         <range>: New method.
11501         (require_partial_symbols): Change return type.
11502         * psymtab.c (require_partial_symbols)
11503         (psym_expand_symtabs_matching): Update.
11504         * mdebugread.c (parse_partial_symbols): Update.
11505         * dbxread.c (dbx_end_psymtab): Update.
11506
11507 2019-01-15  Tom Tromey  <tom@tromey.com>
11508
11509         * symtab.c (lookup_objfile_from_block)
11510         (lookup_symbol_in_objfile_symtabs)
11511         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11512         (find_line_symtab, info_sources_command)
11513         (default_collect_symbol_completion_matches_break_on)
11514         (make_source_files_completion_list): Update.
11515         * symmisc.c (print_objfile_statistics, dump_objfile)
11516         (maintenance_print_symbols, maintenance_info_symtabs)
11517         (maintenance_check_symtabs, maintenance_info_line_tables):
11518         Update.
11519         * source.c (select_source_symtab)
11520         (forget_cached_source_info_for_objfile): Update.
11521         * objfiles.h (class objfile_compunits): Remove.
11522         (struct objfile) <compunits_range>: New typedef.
11523         (compunits): New method.
11524         * objfiles.c (objfile_relocate1): Update.
11525         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11526         * maint.c (count_symtabs_and_blocks): Update.
11527         * linespec.c (iterate_over_all_matching_symtabs): Update.
11528         * cp-support.c (add_symbol_overload_list_qualified): Update.
11529         * coffread.c (coff_symtab_read): Update.
11530         * ada-lang.c (add_nonlocal_symbols)
11531         (ada_collect_symbol_completion_matches)
11532         (ada_add_global_exceptions): Update.
11533
11534 2019-01-15  Tom Tromey  <tom@tromey.com>
11535
11536         * progspace.h (program_space) <objfiles_safe_range>: New
11537         typedef.
11538         <objfiles_safe>: New method.
11539         * objfiles.h (class all_objfiles_safe): Remove.
11540         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11541         * jit.c (jit_inferior_exit_hook): Update.
11542
11543 2019-01-17  Tom Tromey  <tom@tromey.com>
11544
11545         * progspace.h (program_space) <objfiles_range>: New typedef.
11546         <objfiles>: New method.
11547         <objfiles_head>: Rename from objfiles.
11548         (object_files): Update.
11549         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11550         * guile/scm-pretty-print.c
11551         (ppscm_find_pretty_printer_from_objfiles): Update.
11552         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11553         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11554         Update.
11555         * python/py-progspace.c (pspy_get_objfiles): Update.
11556         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11557         Update.
11558         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11559         (objfpy_lookup_objfile_by_build_id): Update.
11560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11562         Update.
11563         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11564         (expand_symtab_containing_pc, lookup_objfile_from_block)
11565         (lookup_static_symbol, basic_lookup_transparent_type)
11566         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11567         (find_line_symtab, info_sources_command)
11568         (default_collect_symbol_completion_matches_break_on)
11569         (make_source_files_completion_list, find_main_name): Update.
11570         * symmisc.c (print_symbol_bcache_statistics)
11571         (print_objfile_statistics, maintenance_print_symbols)
11572         (maintenance_print_msymbols, maintenance_print_objfiles)
11573         (maintenance_info_symtabs, maintenance_check_symtabs)
11574         (maintenance_expand_symtabs, maintenance_info_line_tables):
11575         Update.
11576         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11577         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11578         (map_overlay_command, unmap_overlay_command)
11579         (simple_overlay_update, expand_symtabs_matching)
11580         (map_symbol_filenames): Update.
11581         * symfile-debug.c (set_debug_symfile): Update.
11582         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11583         Update.
11584         * source.c (select_source_symtab, forget_cached_source_info):
11585         Update.
11586         * solib.c (solib_read_symbols): Update.
11587         * solib-spu.c (append_ocl_sos): Update.
11588         * psymtab.c (maintenance_print_psymbols)
11589         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11590         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11591         * printcmd.c (info_symbol_command): Update.
11592         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11593         Update.
11594         * objfiles.h (class all_objfiles): Remove.
11595         * objfiles.c (have_partial_symbols, have_full_symbols)
11596         (have_minimal_symbols, qsort_cmp, update_section_map)
11597         (shared_objfile_contains_address_p)
11598         (default_iterate_over_objfiles_in_search_order): Update.
11599         * objc-lang.c (info_selectors_command, info_classes_command)
11600         (find_methods): Update.
11601         * minsyms.c (find_solib_trampoline_target): Update.
11602         * maint.c (maintenance_info_sections)
11603         (maintenance_translate_address, count_symtabs_and_blocks):
11604         Update.
11605         * main.c (captured_main_1): Update.
11606         * linux-thread-db.c (try_thread_db_load_from_pdir)
11607         (has_libpthread): Update.
11608         * linespec.c (iterate_over_all_matching_symtabs)
11609         (search_minsyms_for_name): Update.
11610         * jit.c (jit_find_objf_with_entry_addr): Update.
11611         * hppa-tdep.c (find_unwind_entry)
11612         (hppa_lookup_stub_minimal_symbol): Update.
11613         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11614         Update.
11615         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11616         (elf_gnu_ifunc_resolve_by_got): Update.
11617         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11618         * dwarf-index-write.c (save_gdb_index_command): Update.
11619         * cp-support.c (add_symbol_overload_list_qualified): Update.
11620         * breakpoint.c (create_overlay_event_breakpoint)
11621         (create_longjmp_master_breakpoint)
11622         (create_std_terminate_master_breakpoint)
11623         (create_exception_master_breakpoint): Update.
11624         * blockframe.c (find_pc_partial_function): Update.
11625         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11626         (ada_collect_symbol_completion_matches)
11627         (ada_add_global_exceptions): Update.
11628
11629 2019-01-17  Tom Tromey  <tom@tromey.com>
11630
11631         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11632         declare VEC.
11633         (solib_target_parse_libraries): Change return type.
11634         (library_list_start_segment, library_list_start_section)
11635         (library_list_end_library, library_list_start_library); Update.
11636         (solib_target_free_library_list): Remove.
11637         (solib_target_parse_libraries): Remove cleanup.  Change return
11638         type.
11639         (solib_target_current_sos): Update.
11640
11641 2019-01-17  Tom Tromey  <tromey@bapiya>
11642
11643         * valprint.c: Replace "the the" with "the".
11644         * symtab.c: Replace "the the" with "the".
11645         * solib.c: Replace "the the" with "the".
11646         * solib-dsbt.c: Replace "the the" with "the".
11647         * linespec.c: Replace "the the" with "the".
11648         * dwarf2loc.h: Replace "the the" with "the".
11649         * amd64-windows-tdep.c: Replace "the the" with "the".
11650         * aarch64-tdep.c: Replace "the the" with "the".
11651
11652 2019-01-16  Keith Seitz  <keiths@redhat.com>
11653
11654         PR gdb/23773
11655         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11656         <builder>: Rename to ..
11657         <m_builder>: ... this and make private.
11658         (dwarf2_cu::get_builder): New method.  Change all users of
11659         `builder' to use this method.
11660         (dwarf2_start_symtab): Move to ...
11661         (dwarf2_cu::start_symtab): ... here.  Update all callers
11662         (setup_type_unit_groups): Move to ...
11663         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11664         callers.
11665         (dwarf2_cu::reset_builder): New method.
11666         (process_full_compunit, process_full_type_unit): Use
11667         dwarf2_cu::reset_builder.
11668         (follow_die_offset): Record the ancestor CU if it is different
11669         from the followed DIE's CU.
11670         (follow_die_sig_1): Likewise.
11671
11672 2019-01-15  Tom Tromey  <tom@tromey.com>
11673
11674         * remote.c (class remote_state) <buf>: Now a char_vector.
11675         <buf_size>: Remove.
11676         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11677         parameter.
11678         (remote_target::getpkt_or_notif_sane_1)
11679         (remote_target::getpkt_sane)
11680         (remote_target::getpkt_or_notif_sane): Likewise.
11681         (class remote_target) <putpkt>: New overload.
11682         (remote_target::read_frame): Change type of "buf_p".  Remove
11683         sizeof_p parameter.
11684         (packet_ok): New overload.
11685         (packet_check_result): New overload.
11686         Update all uses.
11687
11688 2019-01-14  Tom Tromey  <tom@tromey.com>
11689
11690         * remote-notif.c (handle_notification, remote_notif_ack)
11691         (remote_notif_parse): Make "buf" const.
11692         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11693         const.
11694         (remote_notif_parse, remote_notif_ack, handle_notification):
11695         Likewise.
11696         * remote.c (remote_notif_stop_parse): Make "buf" const.
11697         (remote_target::remote_parse_stop_reply): Make "buf" const.
11698         (remote_notif_stop_ack): Make "buf" const.
11699
11700 2019-01-14  Tom Tromey  <tom@tromey.com>
11701
11702         * remote.c (remote_console_output): Make parameter const.
11703
11704 2019-01-14  Tom Tromey  <tom@tromey.com>
11705
11706         * target-debug.h (target_debug_print_signals): Constify.
11707         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11708         * procfs.c (procfs_target::pass_signals): Update.
11709         * linux-nat.c (linux_nat_target::pass_signals): Update.
11710         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11711         * target-delegates.c: Rebuild.
11712         * remote.c (remote_target::program_signals): Update.
11713         (remote_target::pass_signals): Update.
11714         * target.c (target_pass_signals): Constify argument.
11715         (target_program_signals): Likewise.
11716         * target.h (struct target_ops) <pass_signals, program_signals>:
11717         Constify argument.
11718         (target_pass_signals, target_program_signals): Constify argument.
11719
11720 2019-01-14  Tom Tromey  <tom@tromey.com>
11721
11722         PR tui/28819:
11723         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11724
11725 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11726
11727         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11728         field.
11729         * rs6000-tdep.c: Include reggroups.h.
11730         (IS_V_ALIAS_PSEUDOREG): Define.
11731         (rs6000_register_name): Return names for the "vX" aliases.
11732         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11733         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11734         aliases.  Call default_register_reggroup_p for all other
11735         pseudo-registers.
11736         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11737         New functions.
11738         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11739         Handle "vX" aliases.
11740         (v_alias_pseudo_register_collect): New function.
11741         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11742         (rs6000_gdbarch_init): Initialize "vX" aliases as
11743         pseudo-registers.  Restore registration of
11744         rs6000_pseudo_register_reggroup_p with
11745         set_tdesc_pseudo_register_reggroup_p.
11746
11747 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11748
11749         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11750         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11751         set_gdbarch_num_pseudo_regs.
11752
11753 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11754
11755         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11756         Remove arg prefixname, add do_set and do_show.
11757         Add member functions set_list and show_list.
11758         * cli/cli-style.c (class cli_style_option): Update accordingly.
11759         (style_set_list): Move to file scope.
11760         (style_show_list): Likewise.
11761         (set_style): Call help_list.
11762         (show_style): Call cmd_show_list.
11763         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11764         Update to use the new macro.
11765
11766 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11767
11768         * ada-lang.c (_initialize_ada_language): Expand the help text
11769         for the "catch exception" command.
11770
11771 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11772
11773         * symtab.c (matching_obj_sections): Initialize obj,
11774         declare it closer to its usage.
11775
11776 2019-01-10  Tom Tromey  <tom@tromey.com>
11777
11778         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11779         (basic_inf_threads_range): Remove.
11780         (inf_threads_range, inf_non_exited_threads_range)
11781         (safe_inf_threads_range): Use next_adapter.
11782
11783 2019-01-10  Keith Seitz  <keiths@redhat.com>
11784
11785         PR gdb/23712
11786         PR symtab/23010
11787         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11788         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11789
11790 2019-01-10  Keith Seitz  <keiths@redhat.com>
11791
11792         PR gdb/23712
11793         PR symtab/23010
11794         * dictionary.c (pending_to_vector): Remove.
11795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11796         Remove _1 suffix, replacing functions of the same name.  Update
11797         all callers.
11798         (dict_create_hashed, dict_create_hashed_expandable)
11799         (dict_create_linear, dict_create_linear_expandable, dict_free)
11800         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11801         Make functions static.
11802
11803 2019-01-10  Keith Seitz  <keiths@redhat.com>
11804
11805         PR gdb/23712
11806         PR symtab/23010
11807         * dictionary.h (struct dictionary): Replace declaration with
11808         multidictionary.
11809         (dict_create_hashed, dict_create_hashed_expandable)
11810         (dict_create_linear, dict_create_linear_expandable)
11811         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11812         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11813         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11814         taking multidictionary argument.
11815         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11816         * block.h (struct block) <dict>: Change to multidictionary
11817         and rename `multidict'.
11818         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11819         symmisc.c: Update all dictionary references to multidictionary.
11820
11821 2019-01-10  Keith Seitz  <keiths@redhat.com>
11822
11823         PR gdb/23712
11824         PR symtab/23010
11825         * dictionary.c: Include unordered_map.
11826         (pending_to_vector): New function.
11827         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11828         Rewrite the non-"_1" functions to take vector instead
11829         of linked list.
11830         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11831         "new" _1 versions of the same name.
11832         (multidictionary): Define.
11833         (std::hash<enum language): New definition.
11834         (collate_pending_symbols_by_language, mdict_create_hashed)
11835         (mdict_create_hashed_expandable, mdict_create_linear)
11836         (mdict_create_linear_expandable, mdict_free)
11837         (find_language_dictionary, create_new_language_dictionary)
11838         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11839         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11840         (mdict_size, mdict_empty): New functions.
11841         * dictionary.h (mdict_iterator): Define.
11842
11843 2019-01-10  Pedro Alves  <palves@redhat.com>
11844
11845         * breakpoint.c (read_uploaded_action)
11846         (create_tracepoint_from_upload): Adjust to use
11847         gdb::unique_xmalloc_ptr.
11848         * ctf.c (ctf_write_uploaded_tp):
11849         (SET_ARRAY_FIELD): Use emplace_back.
11850         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11851         * tracefile-tfile.c (tfile_write_uploaded_tp):
11852         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11853         gdb::unique_xmalloc_ptr.
11854         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11855         at_string, cond_string, cmd_strings>: Replace char pointers
11856         with gdb::unique_xmalloc_ptr.
11857
11858 2019-01-10  Pedro Alves  <palves@redhat.com>
11859
11860         * solib-target.c (library_list_start_library): Don't xstrdup name.
11861
11862 2019-01-10  Pedro Alves  <palves@redhat.com>
11863
11864         * mdebugread.c (parse_partial_symbols): Use
11865         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11866
11867 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11868
11869         * linux-fork.c (scoped_switch_fork_info)
11870         <~scoped_switch_fork_info>: Fix incorrect variable name.
11871
11872 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11873
11874         * linux-fork.c (scoped_switch_fork_info)
11875         <scoped_switch_fork_info>: Make explicit.
11876         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11877
11878 2019-01-10  Tom Tromey  <tom@tromey.com>
11879
11880         * objfiles.h (objfile::reset_psymtabs): Update.
11881         * objfiles.c (objfile::objfile): Update.
11882         * psymtab.h (psymtab_storage::obstack): Update.
11883         (psymtab_storage::m_obstack): Use gdb::optional.
11884         (class psymtab_storage): Update comment.  Remove objfile
11885         parameter.
11886         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11887
11888 2019-01-10  Tom Tromey  <tom@tromey.com>
11889
11890         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11891         <free_psymtabs>: Now private.
11892         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11893         (allocate_psymtab): Use new method.
11894
11895 2019-01-10  Tom Tromey  <tom@tromey.com>
11896
11897         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11898         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11899         * mdebugread.c (parse_partial_symbols): Use
11900         allocate_dependencies.
11901         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11902         allocate_dependencies.
11903         (process_psymtab_comp_unit_reader)
11904         (build_type_psymtab_dependencies): Likewise.
11905         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11906
11907 2019-01-10  Tom Tromey  <tom@tromey.com>
11908
11909         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11910         PSYMBOL_SET_LANGUAGE.
11911         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11912
11913 2019-01-10  Tom Tromey  <tom@tromey.com>
11914
11915         * psymtab.h (psymtab_storage::obstack): New method.
11916         <m_obstack>: Rename from obstack; now private.
11917         * psymtab.c (psymtab_storage): Update.
11918         * dwarf2read.c (create_addrmap_from_index)
11919         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11920         Update.
11921
11922 2019-01-10  Tom Tromey  <tom@tromey.com>
11923
11924         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11925         * objfiles.h (objfile::reset_psymtabs): New method.
11926
11927 2019-01-10  Tom Tromey  <tom@tromey.com>
11928
11929         * symmisc.c (print_symbol_bcache_statistics): Update.
11930         (print_objfile_statistics): Update.
11931         * symfile.c (reread_symbols): Update.
11932         * psymtab.h (class psymtab_storage): New.
11933         * psymtab.c (psymtab_storage): New constructor.
11934         (~psymtab_storage): New destructor.
11935         (require_partial_symbols): Update.
11936         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11937         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11938         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11939         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11940         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11941         (start_psymtab_common, end_psymtab_common)
11942         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11943         (allocate_psymtab): Update.
11944         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11945         Update.
11946         (dump_psymtab_addrmap, maintenance_print_psymbols)
11947         (maintenance_check_psymtabs): Update.
11948         (class objfile_psymtabs): Move to objfiles.h.
11949         * psympriv.h (discard_psymtab): Now inline.
11950         (psymtab_discarder::psymtab_discarder): Update.
11951         (psymtab_discarder::~psymtab_discarder): Update.
11952         (ALL_OBJFILE_PSYMTABS): Rewrite.
11953         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11954         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11955         Remove fields.
11956         <partial_symtabs>: New field.
11957         (class objfile_psymtabs): Move from psymtab.h.  Update.
11958         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11959         psymbol_cache.
11960         (objfile::~objfile): Don't destroy psymbol_cache.
11961         * mdebugread.c (parse_partial_symbols): Update.
11962         * dwarf2read.c (create_addrmap_from_index)
11963         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11964         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11965         (add_partial_subprogram, dwarf2_ranges_read): Update.
11966         * dwarf-index-write.c (write_address_map)
11967         (write_one_signatured_type, recursively_write_psymbols)
11968         (class debug_names, class debug_names, write_psymtabs_to_index):
11969         Update.
11970
11971 2019-01-10  Tom Tromey  <tom@tromey.com>
11972
11973         * symtab.h (SYMBOL_SET_NAMES): Update.
11974         (symbol_set_names): Update.
11975         (MSYMBOL_SET_NAMES): Update.
11976         * symtab.c (symbol_set_names): Change argument to be an
11977         objfile_per_bfd_storage.
11978         * psymtab.c (add_psymbol_to_bcache): Update.
11979         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11980
11981 2019-01-10  Tom Tromey  <tom@tromey.com>
11982
11983         * symtab.c (create_demangled_names_hash): Change argument to be an
11984         objfile_per_bfd_storage.
11985         (symbol_set_names): Update.
11986
11987 2019-01-10  Tom Tromey  <tom@tromey.com>
11988
11989         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11990         init_psymbol_list.
11991         * psymtab.c (init_psymbol_list): Do nothing if already called.
11992         * psympriv.h (init_psymbol_list): Add comment.
11993         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11994         init_psymbol_list.
11995         * dbxread.c (dbx_symfile_read): Unconditionally call
11996         init_psymbol_list.
11997
11998 2019-01-10  Tom Tromey  <tom@tromey.com>
11999
12000         * xcoffread.c (scan_xcoff_symtab): Update.
12001         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12002         "where".
12003         * mdebugread.c (parse_partial_symbols)
12004         (handle_psymbol_enumerators): Update.
12005         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12006         * dbxread.c (read_dbx_symtab): Update.
12007         * psympriv.h (psymbol_placement): New enum.
12008         (add_psymbol_to_list): Update.
12009
12010 2019-01-10  Tom Tromey  <tom@tromey.com>
12011
12012         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12013         static_psymbols parameters.
12014         (scan_xcoff_symtab): Update.
12015         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12016         static_psymbols parameters.
12017         * psympriv.h (start_psymtab_common): Update.
12018         * mdebugread.c (parse_partial_symbols): Update.
12019         * dwarf2read.c (create_partial_symtab): Update.
12020         * dbxread.c (read_dbx_symtab): Update.
12021         (start_psymtab): Remove global_psymbols and static_psymbols
12022         parameters.
12023
12024 2019-01-10  Tom Tromey  <tom@tromey.com>
12025
12026         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12027         * psymtab.c (allocate_psymtab): Add comment.
12028         * psympriv.h (allocate_psymtab): Add comment.
12029         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12030         initializations.
12031         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12032
12033 2019-01-10  Tom Tromey  <tom@tromey.com>
12034
12035         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12036         Don't declare.
12037         * mipsread.c: Include mdebugread.h.
12038         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12039         Declare.
12040         * elfread.c: Include mdebugread.h.
12041
12042 2019-01-09  Tom Tromey  <tom@tromey.com>
12043
12044         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12045         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12046         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12047         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12048         (psym_lookup_symbol, psym_find_last_source_symtab)
12049         (psym_forget_cached_source_info, psym_print_stats)
12050         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12051         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12052         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12053         (psym_find_compunit_symtab_by_address)
12054         (maintenance_print_psymbols, maintenance_info_psymtabs)
12055         (maintenance_check_psymtabs): Use ranged for.
12056         * psymtab.h (class objfile_psymtabs): New.
12057         (require_partial_symbols): Return objfile_psymtabs.
12058         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12059
12060 2019-01-09  Tom Tromey  <tom@tromey.com>
12061
12062         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12063         (find_pc_mapped_section, list_overlays_command)
12064         (map_overlay_command, unmap_overlay_command)
12065         (simple_overlay_update): Use all_objfiles.
12066         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12067         * printcmd.c (info_symbol_command): Use all_objfiles.
12068         * objfiles.h (ALL_OBJSECTIONS): Remove.
12069         * maint.c (maintenance_translate_address): Use all_objfiles.
12070         * gcore.c (gcore_create_callback): Use all_objfiles.
12071         (objfile_find_memory_regions): Likewise.
12072
12073 2019-01-09  Tom Tromey  <tom@tromey.com>
12074
12075         * symtab.c (find_line_symtab, info_sources_command)
12076         (make_source_files_completion_list): Use objfile_compunits.
12077         * source.c (select_source_symtab): Use objfile_compunits.
12078         * objfiles.h (struct objfile): Update comment.
12079         (ALL_OBJFILES): Remove.
12080         (ALL_FILETABS): Remove.
12081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12082         objfile_compunits.
12083
12084 2019-01-09  Tom Tromey  <tom@tromey.com>
12085
12086         * symmisc.c (print_objfile_statistics, dump_objfile)
12087         (maintenance_print_symbols): Use compunit_filetabs.
12088         * source.c (forget_cached_source_info_for_objfile): Use
12089         compunit_filetabs.
12090         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12091         (ALL_FILETABS): Use compunit_filetabs.
12092         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12093         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12094
12095 2019-01-09  Tom Tromey  <tom@tromey.com>
12096
12097         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12098         (compunit_filetabs): New.
12099         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12100         compunit_filetabs.
12101         (info_sources_command, make_source_files_completion_list): Remove
12102         declaration.
12103         * symmisc.c (print_objfile_statistics, dump_objfile)
12104         (maintenance_print_symbols): Remove declaration.
12105         (maintenance_info_symtabs): Use compunit_filetabs.
12106         (maintenance_info_line_tables): Likewise.
12107         * source.c (select_source_symtab): Change local variable name.
12108         (forget_cached_source_info_for_objfile): Remove declaration.
12109         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12110         * objfiles.c (objfile_relocate1): Remove declaration.
12111         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12112         declaration.
12113         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12114         * coffread.c (coff_symtab_read): Remove declaration.
12115         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12116         compunit_filetabs.
12117
12118 2019-01-09  Tom Tromey  <tom@tromey.com>
12119
12120         * symtab.c (lookup_objfile_from_block)
12121         (find_pc_sect_compunit_symtab, search_symbols)
12122         (default_collect_symbol_completion_matches_break_on): Use
12123         objfile_compunits.
12124         * objfiles.h (ALL_COMPUNITS): Remove.
12125         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12126         * cp-support.c (add_symbol_overload_list_qualified): Use
12127         objfile_compunits.
12128         * ada-lang.c (ada_collect_symbol_completion_matches)
12129         (ada_add_global_exceptions): Use objfile_compunits.
12130
12131 2019-01-09  Tom Tromey  <tom@tromey.com>
12132
12133         * source.c (select_source_symtab)
12134         (forget_cached_source_info_for_objfile): Remove declaration.
12135         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12136         declaration.
12137         * maint.c (count_symtabs_and_blocks): Remove declaration.
12138         * cp-support.c (add_symbol_overload_list_qualified): Remove
12139         declaration.
12140         * coffread.c (coff_symtab_read): Remove declaration.
12141         * symtab.c (lookup_symbol_in_objfile_symtabs)
12142         (basic_lookup_transparent_type_1): Use objfile_compunits.
12143         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12144         (info_sources_command, search_symbols)
12145         (default_collect_symbol_completion_matches_break_on)
12146         (make_source_files_completion_list): Remove declaration.
12147         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12148         (ada_collect_symbol_completion_matches)
12149         (ada_add_global_exceptions): Remove declaration.
12150         * linespec.c (iterate_over_all_matching_symtabs): Use
12151         objfile_compunits.
12152         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12153         (class objfile_compunits): New.
12154         (ALL_COMPUNITS): Use objfile_compunits.
12155         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12156         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12157         objfile_compunits.
12158         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12159
12160 2019-01-09  Tom Tromey  <tom@tromey.com>
12161
12162         * symtab.c (search_symbols)
12163         (default_collect_symbol_completion_matches_break_on): Use
12164         objfile_msymbols.
12165         * ada-lang.c (ada_lookup_simple_minsym)
12166         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12167         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12168         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12169         objfile_msymbols.
12170         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12171         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12172         * objc-lang.c (find_methods): Use objfile_msymbols.
12173         (info_selectors_command, info_classes_command): Likewise.
12174         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12175         * objfiles.h (class objfile_msymbols): New.
12176         (ALL_OBJFILE_MSYMBOLS): Remove.
12177         (ALL_MSYMBOLS): Remove.
12178
12179 2019-01-09  Tom Tromey  <tom@tromey.com>
12180
12181         * common/next-iterator.h (next_adapter): Add Iterator template
12182         parameter.
12183         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12184         (class all_objfiles_safe): New.
12185         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12186         * objfiles.c (put_objfile_before): Update comment.
12187         (add_separate_debug_objfile): Likewise.
12188         (free_all_objfiles): Use all_objfiles_safe.
12189         (objfile_purge_solibs): Likewise.
12190
12191 2019-01-09  Tom Tromey  <tom@tromey.com>
12192
12193         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12194         (expand_symtab_containing_pc, lookup_static_symbol)
12195         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12196         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12197         all_objfiles.
12198         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12199         * breakpoint.c (create_overlay_event_breakpoint)
12200         (create_longjmp_master_breakpoint)
12201         (create_std_terminate_master_breakpoint)
12202         (create_exception_master_breakpoint): Use all_objfiles.
12203         * linux-thread-db.c (try_thread_db_load_from_pdir)
12204         (has_libpthread): Use all_objfiles.
12205         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12206         * linespec.c (iterate_over_all_matching_symtabs)
12207         (search_minsyms_for_name): Use all_objfiles.
12208         * maint.c (maintenance_info_sections): Use all_objfiles.
12209         * main.c (captured_main_1): Use all_objfiles.
12210         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12211         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12212         * guile/scm-pretty-print.c
12213         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12214         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12215         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12216         (maintenance_print_msymbols): Use all_objfiles.
12217         * source.c (select_source_symtab): Use all_objfiles.
12218         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12219         * symfile.c (remove_symbol_file_command)
12220         (expand_symtabs_matching, map_symbol_filenames): Use
12221         all_objfiles.
12222         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12223         all_objfiles.
12224         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12225         * objc-lang.c (find_methods): Use all_objfiles.
12226         * objfiles.c (have_partial_symbols, have_full_symbols)
12227         (have_minimal_symbols, qsort_cmp)
12228         (default_iterate_over_objfiles_in_search_order): Use
12229         all_objfiles.
12230         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12231         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12232         (maintenance_check_psymtabs): Use all_objfiles.
12233         (ALL_PSYMTABS): Remove.
12234         * compile/compile-object-run.c (do_module_cleanup): Use
12235         all_objfiles.
12236         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12237         * cp-support.c (add_symbol_overload_list_qualified): Use
12238         all_objfiles.
12239         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12240         Use all_objfiles.
12241         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12242         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12243         all_objfiles.
12244         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12245         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12246         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12247         Uses all_objfiles.
12248         * solib.c (solib_read_symbols): Use all_objfiles
12249
12250 2019-01-09  Tom Tromey  <tom@tromey.com>
12251
12252         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12253         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12254         all_objfiles.
12255         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12256         * symmisc.c (print_symbol_bcache_statistics)
12257         (print_objfile_statistics, maintenance_print_objfiles)
12258         (maintenance_info_symtabs, maintenance_check_symtabs)
12259         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12260         all_objfiles.
12261         * source.c (forget_cached_source_info): Use all_objfiles.
12262         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12263         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12264         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12265         * objfiles.c (update_section_map): Use all_objfiles.
12266         (shared_objfile_contains_address_p): Likewise.
12267         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12268         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12269
12270 2019-01-09  Tom Tromey  <tom@tromey.com>
12271
12272         * common/next-iterator.h: New file.
12273         * objfiles.h (class all_objfiles): New.
12274         (struct objfile_iterator): New.
12275
12276 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12277
12278         * NEWS: Move the description of the changed "frame", "select-frame",
12279          and "info frame" commands to the Changed commands section.
12280
12281 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12282
12283         * gdbtypes.c (check_stub_method_group): Remove handling of old
12284         mangling schemes.
12285         * linespec.c (find_methods): Likewise.
12286         * stabsread.c (read_member_functions): Likewise.
12287         * valops.c (search_struct_method): Likewise.
12288         (value_struct_elt_for_reference): Likewise.
12289         * NEWS: Mention this change.
12290
12291 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12292
12293         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12294         print_source_lines.
12295         * source.c (print_source_lines_base): Update line number check.
12296         (print_source_lines): New function.
12297         (source_lines_range::source_lines_range): New function.
12298         * source.h (class source_lines_range): New class.
12299         (print_source_lines): New declaration.
12300
12301 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12302
12303         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12304
12305 2019-01-08  Tom Tromey  <tom@tromey.com>
12306             Simon Marchi  <simon.marchi@ericsson.com>
12307
12308         PR gdb/24060
12309         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12310         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12311         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12312         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12313         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12314         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12315
12316 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12317
12318         * source.c (select_source_symtab): Move header comment to
12319         declaration in source.h.
12320         (forget_cached_source_info_for_objfile): Likewise.
12321         (forget_cached_source_info): Likewise.
12322         (identify_source_line): Likewise.
12323         * source.h (identify_source_line): Move declaration from symtab.h
12324         and add comment from source.c
12325         (print_source_lines): Likewise.
12326         (forget_cached_source_info_for_objfile): Likewise.
12327         (forget_cached_source_info): Likewise.
12328         (select_source_symtab): Likewise.
12329         (enum print_source_lines_flag): Move definition from symtab.h.
12330         * symtab.h (identify_source_line): Move declaration to source.h.
12331         (print_source_lines): Likewise.
12332         (forget_cached_source_info_for_objfile): Likewise.
12333         (forget_cached_source_info): Likewise.
12334         (select_source_symtab): Likewise.
12335         (enum print_source_lines_flag): Move definition to source.h.
12336         * tui/tui-hooks.c: Add 'source.h' include.
12337
12338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12339
12340         * source.c (print_source_lines_base): Handle requests to print
12341         reverse line number sequences, and guard against empty lines
12342         string.
12343
12344 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12345
12346         * source.c (print_source_lines_base): Fix skip of '\r' if next
12347         character is '\n'.
12348
12349 2019-01-06  Tom Tromey  <tom@tromey.com>
12350
12351         * c-exp.y (struct c_parse_state) <macro_original_text,
12352         expansion_obstack>: New member.
12353         (macro_original_text, expansion_obstack): Remove globals.
12354         (scan_macro_expansion, scanning_macro_expansion)
12355         (finished_macro_expansion): Update.
12356         (scan_macro_cleanup): Remove.
12357         (yylex, c_parse): Update.
12358
12359 2019-01-06  Tom Tromey  <tom@tromey.com>
12360
12361         * c-exp.y (struct c_parse_state) <strings>: New member.
12362         (operator_stoken): Update.
12363
12364 2019-01-06  Tom Tromey  <tom@tromey.com>
12365
12366         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12367         (union type_stack_elt) <typelist_val>: Now a pointer to
12368         std::vector.
12369         (type_stack_cleanup): Don't declare.
12370         (push_typelist): Update.
12371         * parse.c (pop_typelist): Return a std::vector.
12372         (push_typelist): Take a std::vector.
12373         (follow_types): Update.  Do not free args.
12374         (type_stack_cleanup): Remove.
12375         * c-exp.y (struct c_parse_state): New.
12376         (cpstate): New global.
12377         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12378         (nonempty_typelist): Update.
12379         (func_mod): Create a new vector.
12380         (c_parse): Create a c_parse_state.
12381         (check_parameter_typelist): Do not delete params.
12382         (function_method): Update.  Do not delete type_list.
12383
12384 2019-01-06  Tom Tromey  <tom@tromey.com>
12385
12386         PR gdb/28155:
12387         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12388         check_typedef.
12389         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12390         (print_return_value): Likewise.
12391
12392 2019-01-05  Tom Tromey  <tom@tromey.com>
12393
12394         * contrib/cleanup_check.py: Remove.
12395         * contrib/gcc-with-excheck: Remove.
12396         * contrib/exsummary.py: Remove.
12397         * contrib/excheck.py: Remove.
12398
12399 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12400
12401         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12402         NULL. Initialize tpprev to NULL instead of assigning it
12403         to NULL on the next statement.
12404         * windows-nat.c (windows_delete_thread): Remove check for
12405         main_thread_id before printing thread exit notifications.
12406         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12407         Remove thread ID check against main_thread_id.
12408         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12409         windows_delete_thread.
12410         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12411
12412 2019-01-04  Tom Tromey  <tom@tromey.com>
12413
12414         * compile/compile.c (_initialize_compile): Use upper case for
12415         metasyntactic variables.
12416         * symmisc.c (_initialize_symmisc): Use upper case for
12417         metasyntactic variables.
12418         * psymtab.c (_initialize_psymtab): Use upper case for
12419         metasyntactic variables.
12420         * demangle.c (demangle_command): Use upper case for metasyntactic
12421         variables.
12422         (_initialize_demangler): Likewise.
12423         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12424         variables.
12425
12426 2019-01-03  Tom Tromey  <tom@tromey.com>
12427
12428         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12429
12430 2019-01-03  Tom Tromey  <tom@tromey.com>
12431
12432         * python/py-symtab.c (salpy_str): Update.
12433         (struct salpy_sal_object) <symtab>: Now a PyObject.
12434         (salpy_dealloc): Update.
12435         (del_objfile_sal): Use gdbpy_ref.
12436
12437 2019-01-03  Tom Tromey  <tom@tromey.com>
12438
12439         * python/py-type.c (convert_field): Use new_reference.  Return
12440         gdbpy_ref.
12441         (make_fielditem): Return gdbpy_ref.
12442         (typy_fields): Update.
12443         (typy_getitem): Update.
12444         (field_name): Return gdbpy_ref.  Use new_reference.
12445         (typy_iterator_iternext): Update.
12446
12447 2019-01-03  Tom Tromey  <tom@tromey.com>
12448
12449         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12450
12451 2019-01-03  Tom Tromey  <tom@tromey.com>
12452
12453         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12454         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12455         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12456         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12457         (pspy_set_type_printers): Likewise.
12458         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12459         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12460         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12461         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12462         (objfpy_set_type_printers): Likewise.
12463
12464 2019-01-03  Tom Tromey  <tom@tromey.com>
12465
12466         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12467         (gdbpy_print_stack): Use gdbpy_err_fetch.
12468         * python/python-internal.h (class gdbpy_err_fetch): New class.
12469         (class gdbpy_enter) <m_error_type, m_error_value,
12470         m_error_traceback>: Remove.
12471         <m_error>: New member.
12472         (gdbpy_exception_to_string): Don't declare.
12473         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12474         * python/py-value.c (convert_value_from_python): Use
12475         gdbpy_err_fetch.
12476         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12477         gdbpy_exception_to_string.
12478         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12479         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12480         gdbpy_err_fetch.
12481
12482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12483
12484         * linux-nat.c (delete_lwp_cleanup): Delete.
12485         (struct lwp_deleter): New struct.
12486         (lwp_info_up): New typedef.
12487         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12488         lwp_info_up.
12489
12490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * linux-fork.c (class scoped_switch_fork_info): New class.
12493         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12494
12495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12496
12497         * valops.c (find_overload_match): Remove use of null_cleanup, and
12498         calls to do_cleanups.
12499
12500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12501
12502         * compile/compile-cplus-types.c
12503         (compile_cplus_instance::decl_name): Handle changes to
12504         cp_func_name.
12505         * cp-support.c (cp_func_name): Update header comment, update
12506         return type.
12507         * cp-support.h (cp_func_name): Update return type in declaration.
12508         * valops.c (find_overload_match): Move temp_func local to top
12509         level of function and change its type.  Use temp_func to hold and
12510         delete temporary string obtained from cp_func_name.
12511
12512 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12513
12514         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12515         gdb::char_vector, remove cleanup, and update uses of `msg`.
12516
12517 2019-01-03  Jim Wilson  <jimw@sifive.com>
12518
12519         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12520
12521 2019-01-02  Tom Tromey  <tom@tromey.com>
12522
12523         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12524         (tdesc_parse_xml): Remove cleanups.
12525         * target-descriptions.h (make_cleanup_free_target_description):
12526         Don't declare.
12527         (target_desc_deleter): New struct.
12528         (target_desc_up): New typedef.
12529         * target-descriptions.c (target_desc_deleter::operator()): Rename
12530         from free_target_description.
12531         (make_cleanup_free_target_description): Remove.
12532
12533 2019-01-02  Tom Tromey  <tom@tromey.com>
12534
12535         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12536         constructor, destructor.
12537         (linespec_parser): Remove typedef.
12538         (~linespec_parser): Rename from linespec_parser_delete.
12539         (linespec_lex_to_end, linespec_complete_label)
12540         (linespec_complete): Update.
12541         (decode_line_full): Remove cleanups.
12542         (decode_line_1): Update.
12543
12544 2019-01-02  Tom Tromey  <tom@tromey.com>
12545
12546         * python/python-internal.h (inferior_to_inferior_object): Change
12547         return type.
12548         * python/py-exitedevent.c (create_exited_event_object): Update.
12549         * python/py-inferior.c (inferior_to_inferior_object): Return
12550         gdbpy_ref.
12551         (python_new_inferior, python_inferior_deleted)
12552         (thread_to_thread_object, delete_thread_object)
12553         (build_inferior_list, gdbpy_selected_inferior): Update.
12554         * python/py-infthread.c (create_thread_object): Update.  Also fail
12555         if inferior_to_inferior_object fails.
12556
12557 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12558
12559         * inferior.h (class inferior) <displaced_step_state>: New field.
12560         * infrun.h (struct displaced_step_state): Move here from
12561         infrun.c.  Initialize fields, add constructor.
12562         <inf>: Remove field.
12563         <reset>: New method.
12564         * infrun.c (struct displaced_step_inferior_state): Move to
12565         infrun.h.
12566         (displaced_step_inferior_states): Remove.
12567         (get_displaced_stepping_state): Adust.
12568         (displaced_step_in_progress_any_inferior): Adjust.
12569         (displaced_step_in_progress_thread): Adjust.
12570         (displaced_step_in_progress): Adjust.
12571         (add_displaced_stepping_state): Remove.
12572         (get_displaced_step_closure_by_addr): Adjust.
12573         (remove_displaced_stepping_state): Remove.
12574         (infrun_inferior_exit): Call displaced_step_state.reset.
12575         (use_displaced_stepping): Don't check for NULL.
12576         (displaced_step_prepare_throw): Call
12577         get_displaced_stepping_state.
12578         (displaced_step_fixup): Don't check for NULL.
12579         (prepare_for_detach): Don't check for NULL.
12580
12581 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12582
12583         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12584          in case of call that did not complete.
12585
12586 2019-01-02  Andrey Utkin  <autkin@undo.io>
12587
12588         * symfile.c (find_separate_debug_file): Fix search of debug files for
12589         remote debuggee.
12590
12591 2019-01-02  Tom Tromey  <tom@tromey.com>
12592
12593         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12594         indentation.
12595         * python/py-frame.c (frapy_older): Remove cast.
12596         (frapy_newer): Likewise.
12597         * python/py-breakpoint.c (local_setattro): Remove cast.
12598         * python/py-arch.c (archpy_name): Remove local variable.
12599         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12600
12601 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12602
12603         * unittests/basic_string_view/element_access/char/empty.cc:
12604         Fix year range in copyright header.
12605
12606 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12607
12608         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12609         Delete.
12610         <operator==>: Update with for removed field.
12611         <hash>: Likewise.
12612         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12613         <isa_features>: ...this.
12614         <abi_features>: New field.
12615         (riscv_isa_flen): Update comment.
12616         (riscv_abi_xlen): New declaration.
12617         (riscv_abi_flen): New declaration.
12618         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12619         isa_features.
12620         (riscv_abi_xlen): New function.
12621         (riscv_isa_flen): Update to get answer from isa_features.
12622         (riscv_abi_flen): New function.
12623         (riscv_has_fp_abi): Update to get answer from abi_features.
12624         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12625         xlen and flen.
12626         (riscv_call_info) <xlen, flen>: Update comment.
12627         (riscv_call_arg_struct): Remove invalid assertions
12628         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12629         is removed.
12630         (riscv_gdbarch_init): Gather isa features and abi features
12631         separately, ensure both match on the gdbarch when reusing an old
12632         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12633         a target with 64-bit float hardware.
12634
12635 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12636
12637         * source.c (search_command_helper): Stop reverse search
12638         when line 1 has been searched.
12639
12640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12641
12642         * record-full.c (record_full_base_target::close): Rewrite
12643         record_full_core_buf_list free logic.
12644
12645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12646
12647         * break-catch-syscall.c (print_one_catch_syscall): xfree
12648         the last text.
12649
12650 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12651
12652         * top.c (print_gdb_version): Update Copyright year in version
12653         message.
12654
12655 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12656
12657         Update copyright year range in all GDB files.
12658
12659 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12660
12661         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12662
12663 For older changes see ChangeLog-2018.
12664 \f
12665 Local Variables:
12666 mode: change-log
12667 left-margin: 8
12668 fill-column: 74
12669 version-control: never
12670 coding: utf-8
12671 End:
12672