gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_source_window)
   4         (struct tui_data_window): Declare destructors.
   5         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
   6         destructors.
   7         (tui_win_info): Simplify.
   8
   9 2019-06-25  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-winsource.c (tui_display_main)
  12         (tui_update_source_windows_with_addr)
  13         (tui_update_all_breakpoint_info): Update.
  14         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  15         (new_height_ok, parse_scrolling_args): Update.
  16         * tui/tui-stack.c (tui_show_frame_info): Update.
  17         * tui/tui-data.h (struct tui_list): Remove.
  18         (tui_source_windows): Return a reference to a std::vector.
  19         * tui/tui-data.c (source_windows): Now a std::vector.
  20         (tui_source_windows): Change return type.
  21         (tui_clear_source_windows): Rewrite.
  22         (tui_clear_source_windows_detail, tui_add_to_source_windows)
  23         (tui_free_all_source_wins_content): Rewrite.
  24
  25 2019-06-25  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
  28         (struct tui_data_window, struct tui_cmd_window): Declare
  29         clear_detail method.
  30         * tui/tui-data.c (tui_source_window::clear_detail)
  31         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
  32         methods.
  33         (tui_clear_win_detail): Simplify.
  34
  35 2019-06-25  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-layout.c (make_source_window, make_disasm_window)
  38         (make_source_or_disasm_window): Remove win_info_ptr parameter.
  39         Return the new window.
  40         (show_source_disasm_command, show_data)
  41         (show_source_or_disasm_and_command): Update.
  42
  43 2019-06-25  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
  46         parameter.  Return the new window.
  47         (show_source_disasm_command): Update and remove NULL check.
  48         (show_source_or_disasm_and_command): Update.
  49
  50 2019-06-25  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
  53
  54 2019-06-25  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-data.h (struct tui_win_info): Make constructor
  57         protected.  Make destructor virtual.  Add initializers.
  58         (tui_source_window, tui_data_window, tui_cmd_window): New
  59         classes.
  60         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
  61         constructor.  Add "type" parameter.
  62         (tui_source_window, tui_data_window, tui_cmd_window): New
  63         constructors.
  64         (tui_alloc_win_info): Instantiate the appropriate subclass.
  65
  66 2019-06-25  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-win.c (tui_resize_all): Use delete.
  69         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
  70         destructor.
  71         (tui_free_window): Don't declare.
  72         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
  73         Update.
  74
  75 2019-06-25  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-data.h (struct tui_win_info): Add constructor.
  78         * tui/tui-data.c (tui_alloc_win_info): Use new.
  79         (tui_free_window): Use delete.
  80
  81 2019-06-22  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  84         declare.
  85         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  86
  87 2019-06-22  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  90         declare.
  91         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  92
  93 2019-06-22  Tom de Vries  <tdevries@suse.de>
  94
  95         * dwarf2read.c (create_addrmap_from_aranges)
  96         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  97         instead of '%zu'.
  98
  99 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 100
 101         * dwarf2read.h (dwarf2_section_info_def): Remove.
 102         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 103         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 104         std::vector<dwarf2_section_info>.
 105         (struct dwo_file) <~dwo_file>: Remove.
 106         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 107         types field.
 108         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 109         (dwarf2_read_debug_names): Likewise.
 110         (create_debug_types_hash_table): Change parameter type to
 111         array_view, adjust code accordingly.
 112         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 113         (partial_die_info::fixup): Likewise.
 114         (determine_prefix): Likewise.
 115         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 116
 117 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 118
 119         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 120         gdb_bfd_ref_ptr.
 121         <~dwo_file>: Remove call to gdb_bfd_unref.
 122         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 123         gdb_bfd_ref_ptr::get.
 124
 125 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 126
 127         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 128         type to htab_up.
 129         * dwarf2read.c (struct dwo_file): Initialize fields.
 130         <~dwo_file>: New.
 131         (free_dwo_file): Remove, move content to ~dwo_file.
 132         (struct dwo_file_deleter): Remove.
 133         (dwo_file_up>: Remove custom deleter.
 134         (free_dwo_files): Remove.
 135         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 136         dwo_files.
 137         (process_skeletonless_type_units): Call unique_ptr::get.
 138         (allocate_dwo_file_hash_table): Add deleter to created hash
 139         table.  Change return type to htab_up.
 140         (lookup_dwo_file_slot): Don't memset dwo_file, call
 141         unique_ptr::get.
 142         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 143         (create_dwo_unit_in_dwp_v2): Likewise.
 144         (open_and_init_dwo_file): Likewise.
 145         (free_dwo_file_from_slot): Remove.
 146
 147 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 148
 149         * dwarf2read.h (struct dwarf2_section_info) <readin,
 150         is_virtual>: Change type to bool.
 151         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 152         true instead of 1.
 153
 154 2019-06-19  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-data.h (tui_init_content_element): Don't declare.
 157
 158 2019-06-19  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-data.h (tui_init_win_info): Don't declare.
 161
 162 2019-06-19  Tom de Vries  <tdevries@suse.de>
 163
 164         * dwarf2read.h (abstract_to_concrete): Change type to
 165         std::unordered_map<sect_offset, std::vector<sect_offset>,
 166         gdb::hash_enum<sect_offset>>.
 167
 168 2019-06-19  Tom Tromey  <tromey@adacore.com>
 169
 170         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 171         EVAL_AVOID_SIDE_EFFECTS specially.
 172
 173 2019-06-19  Tom Tromey  <tromey@adacore.com>
 174
 175         * source-cache.c (highlighter): New global.
 176         (source_cache::get_source_lines): Create a highlighter on demand.
 177
 178 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * defs.h (deprecated_interactive_hook): Delete declaration.
 181         * interps.c (clear_interpreter_hooks): Remove use of
 182         deprecated_interactive_hook.
 183         * top.c (deprecated_interactive_hook): Delete definition.
 184         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 185
 186 2019-06-18  Tom de Vries  <tdevries@suse.de>
 187
 188         PR gdb/24515
 189         * dwarf2read.h (abstract_to_concrete): Change type from
 190         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 191         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 192         * dwarf2read.c (read_variable): Update.
 193         (dwarf2_fetch_die_loc_sect_off): Update.
 194
 195 2019-06-17  Tom de Vries  <tdevries@suse.de>
 196
 197         PR gdb/24617
 198         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 199         accessing parent[parent_len - 1].
 200
 201 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 202
 203         PR gdb/24364
 204         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 205         call dtrace_process_dof with NULL dof.
 206
 207 2019-06-16  Tom de Vries  <tdevries@suse.de>
 208
 209         PR gdb/24445
 210         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 211
 212 2019-06-16  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 215         (make_all_visible): Use address of member.
 216
 217 2019-06-16  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 220         (tui_free_window, free_content, free_content_elements): Remove
 221         unnecessary cast.
 222         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 223         cast.
 224         * tui/tui-regs.c (tui_show_register_group)
 225         (tui_display_registers_from, tui_display_reg_element_at_line):
 226         Remove unnecessary cast.
 227
 228 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 229
 230         * linux-nat.c (normal_mask): Delete.
 231         (_initialize_linux_nat): Don't initialise normal_mask.
 232
 233 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 234
 235         PR gdb/24445
 236         * dwarf-index-write.h (write_psymtabs_to_index): Add
 237         dwz_basename parameter.
 238         * dwarf-index-write.c (write_gdbindex): Move file writing to
 239         write_gdbindex_1.  Change return type void.
 240         (assert_file_size): Move up, remove filename parameter.
 241         (write_gdbindex_1): New function.
 242         (write_debug_names): Change return type to void, call
 243         assert_file_size.
 244         (struct index_wip_file): New struct.
 245         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 246         file logic to index_wip_file.  Write index for dwz file if
 247         needed.
 248         (save_gdb_index_command): Pass basename of dwz file, if present.
 249         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 250         build-id of dwz file, if present.
 251         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 252         (dwarf2_get_dwz_file): Likewise.
 253         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 254         (dwarf2_get_dwz_file): Likewise.
 255
 256 2019-06-16  Tom Tromey  <tom@tromey.com>
 257
 258         * coffread.c (process_coff_symbol): Use xstrdup.
 259         * value.c (create_internalvar): Use xstrdup.
 260
 261 2019-06-16  Tom Tromey  <tom@tromey.com>
 262
 263         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 264         * breakpoint.c (stopin_command, stopat_command)
 265         (until_break_command, decode_location_default): Remove unnecessary
 266         cast.
 267         * utils.c (subset_compare): Remove unnecessary cast.
 268         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 269         cast.
 270         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 271         cast.
 272         * infcmd.c (path_command): Remove unnecessary cast.
 273         * coffread.c (decode_type): Remove unnecessary cast.
 274         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 275         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 276         * tui/tui-stack.c (tui_show_locator_content)
 277         (tui_show_frame_info): Remove unnecessary cast.
 278         * tui/tui-win.c (tui_scroll_forward_command)
 279         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 280         (parse_scrolling_args): Remove unnecessary cast.
 281         * tui/tui-data.c (init_win_info, tui_del_window)
 282         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 283         (free_content_elements): Remove unnecessary cast.
 284         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 285         unnecessary cast.
 286         * tui/tui-source.c (tui_set_source_content)
 287         (tui_vertical_source_scroll): Remove unnecessary cast.
 288         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 289         cast.
 290         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 291         * tui/tui-regs.c (tui_display_registers_from)
 292         (tui_display_register): Remove unnecessary cast.
 293         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 294         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 295         (make_visible): Remove unnecessary cast.
 296         * tui/tui-winsource.c (tui_erase_source_content)
 297         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 298         unnecessary cast.
 299         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 300         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 301         * stabsread.c (read_type, read_array_type, read_range_type):
 302         Remove unnecessary cast.
 303         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 304         (parse_symbol, parse_type, upgrade_type, parse_external)
 305         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 306         unnecessary cast.
 307         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 308
 309 2019-06-16  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-data.c (tui_alloc_generic_win_info)
 312         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 313         checks.
 314
 315 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 316             Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * f-typeprint.c (f_print_type): Don't return early for not
 319         associated or not allocated types.
 320         (f_type_print_varspec_suffix): Add print_rank parameter and print
 321         ranks of array types in case they dangling.
 322         (f_type_print_base): Add print_rank parameter.
 323
 324 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 325
 326         * NEWS: Mention new MI commands.
 327         * break-catch-throw.c (enum exception_event_kind): Move to
 328         breakpoint.h.
 329         (print_mention_exception_catchpoint): Output text as a single
 330         message.
 331         (catch_exception_command_1): Rename to...
 332         (catch_exception_event): ...this, make non-static, update header
 333         command, and change some parameter types.
 334         (catch_catch_command): Update for changes to
 335         catch_exception_command_1.
 336         (catch_throw_command): Likewise.
 337         (catch_rethrow_command): Likewise.
 338         * breakpoint.c (enum exception_event_kind): Delete.
 339         * breakpoint.h (enum exception_event_kind): Moved here from
 340         break-catch-throw.c.
 341         (catch_exception_event): Declare.
 342         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 343         (mi_cmd_catch_throw): New function.
 344         (mi_cmd_catch_rethrow): New function.
 345         (mi_cmd_catch_catch): New function.
 346         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 347         'catch-catch' entries.
 348         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 349         (mi_cmd_catch_rethrow): Declare.
 350         (mi_cmd_catch_catch): Declare.
 351
 352 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 353
 354         * annotate.c (annotate_source_line): Change return type to void,
 355         update implementation to match.
 356         * annotate.h (annotate_source_line): Change return type to void,
 357         update header comment.
 358         * stack.c (print_frame_info): Don't change what frame information
 359         is printed based on whether annotations are on or not.
 360
 361 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 364         (annotate_source): Make static.
 365         (annotate_source_line): Moved from source.c and renamed from
 366         identify_source_line.  Update the return type.
 367         * annotate.h (annotate_source): Delete declaration.
 368         (annotate_source_line): Declaration moved from source.h, and
 369         renamed from identify_source_line.  Return type updated.
 370         * source.c (identify_source_line): Moved to annotate.c and renamed
 371         to annotate_source_line.
 372         (info_line_command): Remove check of annotation_level.
 373         * source.h (identify_source_line): Move declaration to annotate.h
 374         and rename to annotate_source_line.
 375         * stack.c: Add 'annotate.h' include.
 376         (print_frame_info): Remove check of annotation_level before
 377         calling annotate_source_line.
 378
 379 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * source-cache.c (source_cache::get_plain_source_lines): Use
 382         open_source_file_with_line_charpos instead of just
 383         open_source_file, remove call to find_source_lines.
 384         (source_cache::get_source_lines): Likewise.
 385         * source.c (find_source_lines): Make static.
 386         (get_filename_and_charpos): Renamed into...
 387         (open_source_file_with_line_charpos): ..this along with changes to
 388         return a scoped_fd, and some other minor clean ups.
 389         (identify_source_line): Use open_source_file_with_line_charpos.
 390         (search_command_helper): Use open_source_file_with_line_charpos
 391         instead of just open_source_file, remove call to
 392         find_source_lines.
 393         * source.h (open_source_file_with_line_charpos): Declare new
 394         function.
 395         (find_source_lines): Delete declaration.
 396
 397 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 398
 399         * source.c (get_filename_and_charpos): Remove fullname
 400         parameter.
 401         (identify_source_line): Update call to get_filename_and_charpos.
 402
 403 2019-06-14  Tom Tromey  <tromey@adacore.com>
 404
 405         PR gdb/24502:
 406         * ui-style.h (skip_ansi_escape): Update comment.
 407         * ui-file.h (class no_terminal_escape_file): New class.
 408         * ui-file.c (no_terminal_escape_file::write)
 409         (no_terminal_escape_file::puts): New methods.
 410         * cli/cli-logging.c (handle_redirections): Use
 411         no_terminal_escape_file.
 412
 413 2019-06-14  Tom Tromey  <tromey@adacore.com>
 414
 415         * NEWS: Move convenience variable news above Python news.
 416
 417 2019-06-14  Tom Tromey  <tom@tromey.com>
 418
 419         * gnulib: Move directory to top-level.
 420         * configure.ac: Don't configure gnulib.
 421         * configure: Rebuild.
 422         * common/common-defs.h: Use new path to gnulib.
 423         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 424         (GNULIB_H): Remove.
 425         (INCGNU): Look in new gnulib location.
 426         (HFILES_NO_SRCDIR): Remove gnulib files.
 427         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 428         (generated_files): Remove GNULIB_H.
 429         ($(LIBGNU), all-lib): Remove targets.
 430         (distclean): Don't mention GNULIB_BUILDDIR.
 431         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 432
 433 2019-06-14  Tom Tromey  <tromey@adacore.com>
 434
 435         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 436         Warn if symbol file does not provide any symbols.
 437
 438 2019-06-14  Tom Tromey  <tromey@adacore.com>
 439
 440         * source.c (find_and_open_source): Respect basenames_may_differ.
 441
 442 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * annotate.c (annotate_breakpoints_invalid): Make use of
 445         scoped_restore_terminal_state.
 446         (annotate_frames_invalid): Likewise.
 447
 448 2019-06-14  Tom Tromey  <tromey@adacore.com>
 449
 450         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 451         allow assignment to an internalvar.
 452
 453 2019-06-14  Tom Tromey  <tromey@adacore.com>
 454
 455         * ada-lex.l: Allow "_" in attribute names.
 456
 457 2019-06-14  Tom Tromey  <tromey@adacore.com>
 458
 459         PR gdb/24653:
 460         * regcache.c (registers_changed): Don't call alloca.
 461         * top.c (execute_command): Don't call alloca.
 462
 463 2019-06-13  Pedro Alves  <palves@redhat.com>
 464
 465         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 466         'expression'.  When parsing an expression, error out if there's
 467         junk after "unlimited".
 468         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 469         (do_set_command): Adjust calls to is_unlimited_literal.
 470
 471 2019-06-13  Pedro Alves  <palves@redhat.com>
 472
 473         * compile/compile.c (make_compile_options_def_group): Add braces
 474         around array_view initializer.
 475         * thread.c (make_thread_apply_all_options_def_group)
 476         (make_thread_apply_all_options_def_group): Likewise.
 477
 478 2019-06-13  Pedro Alves  <palves@redhat.com>
 479
 480         * NEWS (New commands): Mention "maint test-options
 481         require-delimiter", "maint test-options unknown-is-error", "maint
 482         test-options unknown-is-operand" and "maint show
 483         test-options-completion-result".
 484         (New command options, command completion): New section.
 485         (Completion improvements): New section.
 486         Mention that you can abbreviate "unlimited".
 487
 488 2019-06-13  Pedro Alves  <palves@redhat.com>
 489
 490         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 491         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 492         * unittests/cli-utils-selftests.c (test_parse_flags)
 493         (test_parse_flags_qcs): Delete.
 494         (test_cli_utils): Don't call deleted functions.
 495
 496 2019-06-13  Pedro Alves  <palves@redhat.com>
 497
 498         * thread.c: Include "cli/cli-option.h".
 499         (tp_array_compar_ascending): Global.
 500         (tp_array_compar): Delete function.
 501         (tp_array_compar_ascending, tp_array_compar_descending): New
 502         functions.
 503         (ascending_option_def, qcs_flag_option_def)
 504         (thr_qcs_flags_option_defs)
 505         (make_thread_apply_all_options_def_group)
 506         (make_thread_apply_options_def_group): New.
 507         (thread_apply_all_command): Use gdb::option::process_options.
 508         (thread_apply_command_completer)
 509         (thread_apply_all_command_completer): New.
 510         (thread_apply_command): Use gdb::option::process_options.
 511         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 512         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 513         to generate help text of "thread apply".  Adjust "taas"'s help.
 514         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 515         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 516
 517 2019-06-13  Pedro Alves  <palves@redhat.com>
 518
 519         * thread.c (thread_apply_command): Check for invalid TID with
 520         isdigit instead of !isalpha.
 521
 522 2019-06-13  Pedro Alves  <palves@redhat.com>
 523
 524         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 525         (validate_flags_qcs): New.
 526         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 527         (validate_flags_qcs): Declare.
 528         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 529         (make_frame_apply_options_def_group): New.
 530         (frame_apply_command_count): Process options with
 531         gdb::option::process_options.
 532         (frame_apply_completer): New.
 533         (frame_apply_level_completer, frame_apply_all_completer)
 534         (frame_apply_completer): New.
 535         (_initialize_stack): Update help of "frame apply", "frame apply
 536         level", "frame apply all" and "faas" to mention supported options
 537         and install command completers.
 538         * stack.h (frame_apply_all_completer): Declare.
 539         * thread.c: Include "stack.h".
 540         (tfaas_command): Add "--".
 541         (_initialize_thread): Update help "tfaas" to mention supported
 542         options and install command completer.
 543
 544 2019-06-13  Pedro Alves  <palves@redhat.com>
 545
 546         * completer.c (complete_nested_command_line): New.
 547         (gdb_completion_word_break_characters_throw): Add assertion.
 548         * completer.h (complete_nested_command_line): Declare.
 549
 550 2019-06-13  Pedro Alves  <palves@redhat.com>
 551
 552         * stack.c (parse_backtrace_qualifiers): New.
 553         (backtrace_command): Use it.
 554         (backtrace_command_completer): Complete on qualifiers.
 555
 556 2019-06-13  Pedro Alves  <palves@redhat.com>
 557
 558         * frame.c: Include "cli/cli-option.h.
 559         (user_set_backtrace_options): New.
 560         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 561         Delete.
 562         (get_prev_frame): Adjust.
 563         (boolean_option_def, uinteger_option_def)
 564         (set_backtrace_option_defs): New.
 565         (_initialize_frame): Adjust and use
 566         gdb::option::add_setshow_cmds_for_options to install "set
 567         backtrace past-main" and "set backtrace past-entry".
 568         * frame.h: Include "cli/cli-option.h".
 569         (struct frame_print_options): Forward declare.
 570         (print_frame_arguments_all, print_frame_arguments_scalars)
 571         (print_frame_arguments_none): Declare.
 572         (print_entry_values): Delete declaration.
 573         (struct frame_print_options, user_frame_print_options): New.
 574         (struct set_backtrace_options): New.
 575         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 576         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 577         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 578         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 579         (list_args_or_locals): Add frame_print_options parameter.
 580         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 581         * python/py-framefilter.c (enumerate_args): Pass down
 582         USER_FRAME_PRINT_OPTIONS.
 583         * stack.c: Include "cli/cli-option.h".
 584         (print_frame_arguments_all, print_frame_arguments_scalars)
 585         (print_frame_arguments_none): Declare.
 586         (print_raw_frame_arguments, print_entry_values): Delete.
 587         (user_frame_print_options): New.
 588         (boolean_option_def, enum_option_def, frame_print_option_defs):
 589         New.
 590         (struct backtrace_cmd_options): New.
 591         (bt_flag_option_def): New.
 592         (backtrace_command_option_defs): New.
 593         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 594         (print_frame_arg, read_frame_arg, print_frame_args)
 595         (print_frame_info, print_frame): Add frame_print_options parameter
 596         and use it.
 597         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 598         (backtrace_command_1): Add frame_print_options and
 599         backtrace_cmd_options parameters and use them.
 600         (make_backtrace_options_def_group): New.
 601         (backtrace_command): Process command options with
 602         gdb::option::process_options.
 603         (backtrace_command_completer): New.
 604         (_initialize_stack): Extend "backtrace"'s help to mention
 605         supported options.  Install completer for "backtrace".
 606         Install some settings commands with add_setshow_cmds_for_options.
 607
 608 2019-06-13  Pedro Alves  <palves@redhat.com>
 609
 610         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 611         and that "set/show print raw frame-arguments" are now deprecated.
 612
 613         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 614         command.
 615         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 616         * stack.c (_initialize_stack): Install "set/show print
 617         raw-frame-arguments", and deprecate "set/show print raw
 618         frame-arguments".
 619         * valprint.c (_initialize_valprint): Deprecate "set/show print
 620         raw".
 621
 622 2019-06-13  Pedro Alves  <palves@redhat.com>
 623
 624         * compile/compile.c (struct compile_options): New.
 625         (compile_flag_option_def, compile_command_option_defs)
 626         (make_compile_options_def_group): New.
 627         (compile_file_command): Handle options with
 628         gdb::option::process_options.
 629         (compile_file_command_completer): New function.
 630         (compile_code_command): Handle options with
 631         gdb::option::process_options.
 632         (compile_code_command_completer): New function.
 633         (_initialize_compiler): Install completers for "compile code" and
 634         "compile file".  Mention available options in "compile code" and
 635         "compile code"'s help.
 636         * completer.c (advance_to_completion_word): New, factored out from
 637         ...
 638         (advance_to_expression_complete_word_point): ... this.
 639         (advance_to_filename_complete_word_point): New.
 640         * completer.h (advance_to_filename_complete_word_point): New
 641         declaration.
 642
 643 2019-06-13  Pedro Alves  <palves@redhat.com>
 644
 645         * compile/compile.c: Include "cli/cli-option.h".
 646         (compile_print_value): Scope data pointer is now a
 647         value_print_options pointer; adjust.
 648         (compile_print_command): Process options.  Scope data pointer is
 649         now a value_print_options pointer; adjust.
 650         (_initialize_compile): Update "compile print"'s help to include
 651         supported options.  Install a completer for "compile print".
 652         * cp-valprint.c (show_vtblprint, show_objectprint)
 653         (show_static_field_print): Delete.
 654         (_initialize_cp_valprint): Don't install "set print
 655         static-members", "set print vtbl", "set print object" here.
 656         * printcmd.c: Include "cli/cli-option.h" and
 657         "common/gdb_optional.h".
 658         (print_command_parse_format): Rework to fill in a
 659         value_print_options instead of a format_data.
 660         (print_value): Change parameter type from format_data pointer to
 661         value_print_options reference.  Adjust.
 662         (print_command_1): Process options.  Adjust to pass down a
 663         value_print_options.
 664         (print_command_completer): New.
 665         (_initialize_printcmd): Install print_command_completer as
 666         handle_brkchars completer for the "print" command.  Update
 667         "print"'s help to include supported options.
 668         * valprint.c: Include "cli/cli-option.h".
 669         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 670         here from cp-valprint.c.
 671         (boolean_option_def, uinteger_option_def)
 672         (value_print_option_defs, make_value_print_options_def_group):
 673         New.  Use gdb::option::add_setshow_cmds_for_options to install
 674         "set print elements", "set print null-stop", "set print repeats",
 675         "set print pretty", "set print union", "set print array", "set
 676         print address", "set print symbol", "set print array-indexes".
 677         * valprint.h: Include <string> and "cli/cli-option.h".
 678         (make_value_print_options_def_group): Declare.
 679         (print_value): Change parameter type from format_data pointer to
 680         value_print_options reference.
 681         (print_command_completer): Declare.
 682
 683 2019-06-13  Pedro Alves  <palves@redhat.com>
 684
 685         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 686         (COMMON_SFILES): Add maint-test-settings.c.
 687         * cli/cli-decode.c (boolean_enums): New global, factored out from
 688         ...
 689         (add_setshow_boolean_cmd): ... here.
 690         * cli/cli-decode.h (boolean_enums): Declare.
 691         * cli/cli-option.c: New file.
 692         * cli/cli-option.h: New file.
 693         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 694         factored out from ...
 695         (parse_cli_boolean_value(const char *)): ... this.
 696         (is_unlimited_literal): Change parameter type to pointer to
 697         pointer.  Adjust and advance ARG pointer.
 698         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 699         (parse_cli_var_enum): New, factored out from ...
 700         (do_set_command): ... this.  Adjust.
 701         * cli/cli-setshow.h (parse_cli_boolean_value)
 702         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 703         (parse_cli_var_enum): Declare.
 704         * cli/cli-utils.c: Include "cli/cli-option.h".
 705         (get_ulongest): New.
 706         * cli/cli-utils.h (get_ulongest): Declare.
 707         (check_for_argument): New overloads.
 708         * maint-test-options.c: New file.
 709
 710 2019-06-13  Pedro Alves  <palves@redhat.com>
 711
 712         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 713         parse a range if "-" is at the end of the string.
 714
 715 2019-06-13  Pedro Alves  <palves@redhat.com>
 716
 717         * cli/cli-setshow.c (parse_auto_binary_operation)
 718         (parse_cli_boolean_value): Don't allow "o".
 719
 720 2019-06-13  Pedro Alves  <palves@redhat.com>
 721
 722         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 723         * NEWS: Mention maint test-settings KIND.
 724         * maint-test-settings.c: New file.
 725
 726 2019-06-13  Pedro Alves  <palves@redhat.com>
 727
 728         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 729         completer.
 730         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 731         "set" completers.
 732
 733 2019-06-13  Pedro Alves  <palves@redhat.com>
 734
 735         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 736         after item.
 737
 738 2019-06-13  Pedro Alves  <palves@redhat.com>
 739
 740         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 741
 742 2019-06-13  Pedro Alves <palves@redhat.com>
 743
 744         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 745         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 746         call.
 747         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 748         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 749         calls.
 750         (check_for_argument): Skip spaces after argument.
 751
 752 2019-06-13  Pedro Alves  <palves@redhat.com>
 753
 754         * thread.c (thread_apply_command): Adjust TID parsing.
 755         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 756         detected before end of string.
 757         (tid_is_in_list): Error out if LIST is invalid.
 758
 759 2019-06-13  Pedro Alves  <palves@redhat.com>
 760
 761         * completer.c (complete_line_internal_1): Rewind completion word
 762         point.
 763         (completion_tracker::advance_custom_word_point_by): Change
 764         parameter type to int.
 765         * completer.h (completion_tracker::advance_custom_word_point_by):
 766         Likewise.
 767
 768 2019-06-13  Pedro Alves  <palves@redhat.com>
 769
 770         * completer.c (advance_to_completion_word): Handle delimiters.
 771
 772 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 773
 774         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 775
 776 2019-06-11  Tom Tromey  <tom@tromey.com>
 777
 778         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 779         (xmalloc_failed): Move to alloc.c.
 780         * alloc.c: New file.
 781         * Makefile.in (COMMON_SFILES): Add alloc.c.
 782
 783 2019-06-11  Tom Tromey  <tom@tromey.com>
 784
 785         * nat/linux-waitpid.c: Don't include server.h.
 786         (linux_debug): Remove.
 787         (my_waitpid): Update.
 788
 789 2019-06-11  Tom Tromey  <tromey@adacore.com>
 790
 791         * infcall.c (_initialize_infcall): Remove trailing newline from
 792         help.
 793         * user-regs.c (_initialize_user_regs): Remove trailing newline
 794         from help.
 795         * typeprint.c (_initialize_typeprint): Remove trailing newline
 796         from help.
 797         * reverse.c (_initialize_reverse): Remove trailing newlines from
 798         help.
 799         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 800         from help.
 801         * language.c (add_set_language_command): Remove trailing newline
 802         from help.
 803         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 804         help.
 805         * disasm.c (_initialize_disasm): Remove trailing newline from
 806         help.
 807         * top.c (init_main): Remove trailing newline from help.
 808         * interps.c (_initialize_interpreter): Remove trailing newline
 809         from help.
 810         * btrace.c (_initialize_btrace): Remove trailing newlines from
 811         help.
 812         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 813         from help.
 814         * python/python.c (_initialize_python): Remove trailing newline
 815         from help.
 816         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 817         help.
 818         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 819         from help.  Reformat some text.
 820         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 821         from help.
 822         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 823         newline from help.
 824
 825 2019-06-11  Tom Tromey  <tromey@adacore.com>
 826
 827         * darwin-nat.c (darwin_decode_exception_message)
 828         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 829
 830 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * valops.c (value_slice): Check for not allocated or not
 833         associated values.
 834
 835 2019-06-10  Tom de Vries  <tdevries@suse.de>
 836
 837         PR gdb/24618
 838         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 839         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 840         invalid.
 841
 842 2019-06-10  Tom de Vries  <tdevries@suse.de>
 843
 844         PR gdb/24611
 845         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 846         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 847
 848 2019-06-10  Tom de Vries  <tdevries@suse.de>
 849
 850         PR symtab/24545
 851         * symtab.c (struct demangled_name_entry): Add language field.
 852         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 853         static minimal symbol".  Set and use language field.
 854
 855 2019-06-10  Tom Tromey  <tromey@adacore.com>
 856
 857         * ada-lang.c (_initialize_ada_language): Update help text.
 858
 859 2019-06-10  Tom Tromey  <tromey@adacore.com>
 860
 861         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 862         with a newline.
 863         * guile/guile.c (handle_boot_error): Don't end warning with a
 864         newline.
 865         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 866         warning with a newline.
 867         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 868         newline.
 869         (s12z_frame_cache): Likewise.
 870         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 871         a newline.
 872         * solib-svr4.c (disable_probes_interface): Don't end warning with
 873         a newline.
 874         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 875         newline.
 876         * python/python.c (do_finish_initialization): Don't end warning
 877         with a newline.
 878
 879 2019-06-10  Tom Tromey  <tom@tromey.com>
 880
 881         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 882         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 883         gdbpy_enter.
 884
 885 2019-06-10  Tom Tromey  <tromey@adacore.com>
 886
 887         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 888         data.
 889         (elf_new_init): Don't call stabsread_new_init.
 890         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 891         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 892         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 893
 894 2019-06-10  Tom de Vries  <tdevries@suse.de>
 895
 896         PR symtab/16264
 897         PR symtab/24517
 898         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 899
 900 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 901
 902         * source.c (find_and_open_source): Also rewrite relative file
 903         names.
 904
 905 2019-04-26  Amos Bird  <amosbird@gmail.com>
 906
 907         * annotate.c (annotate_thread_exited): Add "thread-exited"
 908         annotation.
 909
 910 2019-06-06  Tom Tromey  <tromey@adacore.com>
 911
 912         * maint.h (class scoped_command_stats): Use
 913         DISABLE_COPY_AND_ASSIGN.
 914         <print_time>: New method.
 915         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 916         print_time.
 917         (scoped_command_stats::print_time): New method.
 918
 919 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 920
 921         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 922         instructions of lengths 6 or 8 bytes.
 923
 924 2019-06-04  Pedro Alves  <palves@redhat.com>
 925
 926         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 927
 928         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 929         * breakpoint.c (condition_completer): Likewise.
 930         * cli/cli-dump.c (scan_expression): Likewise.
 931         * common/filestuff.c (mkdir_recursive): Likewise.
 932         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 933         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 934         (gdb_abspath): Likewise.
 935         * compile/compile-cplus-types.c
 936         (compile_cplus_instance::decl_name): Likewise.
 937         * completer.c (complete_explicit_location):
 938         (signal_completer, reg_or_group_completer_1): Likewise.
 939         * cp-support.c (cp_remove_params_if_any): Likewise.
 940         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 941         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 942         * infcmd.c (strip_bg_char): Likewise.
 943         * linespec.c (copy_token_string): Likewise.
 944         * mi/mi-main.c (output_cores): Likewise.
 945         * psymtab.c (psymtab_search_name):
 946         * symfile.c (test_set_ext_lang_command): Likewise.
 947         * target.c (target_fileio_read_stralloc): Likewise.
 948         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 949         * value.c (complete_internalvar): Likewise.
 950
 951 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 952
 953         Add objfile property to gdb.Type.
 954         * NEWS: Mention Python API addition.
 955         * python/py-type.c (typy_get_objfile): New method.
 956
 957 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 958
 959         * NEWS: Mention the new set|show style [title|highlight].
 960         Mention changes to "show style", "help" and "apropos".
 961
 962 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 963
 964         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 965         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 966         instead of print_help_for_command.
 967         (print_doc_of_command): New function.
 968         (help_list): Add 'apropos -v word' suggestion.
 969         (print_help_for_command): Style the command name using title style.
 970         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 971         (_initialize_cli_cmds): Describe -v in apropos_command help.
 972
 973 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 974
 975         * cli/cli-style.h (cli_style_option): Add name in constructor,
 976         add m_name class member, add constructor with intensity,
 977         add name class function.
 978         (cli_style_option::add_setshow_commands): Remove name argument.
 979         (highlight_style, title_style): New styles.
 980         * cli/cli-style.c (do_show): New function that shows a style
 981         characteristic styling the style name with itself.
 982         (set_style_name): New function.
 983         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 984         Update all callers according to the changes in cli/cli-style.h.
 985         * utils.h (fputs_highlighted): New function.
 986         * utils.c (fputs_highlighted): Likewise.
 987
 988 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 989
 990         * NEWS: Mention new pipe command and new convenience variables.
 991
 992 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 993
 994         * cli/cli-cmds.c (pipe_command): New function.
 995         (_initialize_cli_cmds): Call add_com for pipe_command.
 996         Define | as an alias for pipe.
 997         (exit_status_set_internal_vars): New function.
 998         (shell_escape): Call exit_status_set_internal_vars.
 999         cli/cli-decode.c (find_command_name_length): Recognize | as
1000         a single character command.
1001
1002 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1003
1004         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1005         top.c (execute_command_to_ui_file): New function, mostly a copy
1006         of execute_command_to_string.
1007         (execute_command_to_string): Implement by calling
1008         execute_command_to_ui_file.
1009
1010 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1011
1012         * top.h (saved_command_line): Remove declaration.
1013         * top.c (previous_saved_command_line, previous_repeat_arguments):
1014         New variables.
1015         (saved_command_line): Make static, define together with other
1016         'repeat variables'.
1017         (dont_repeat): Clear repeat_arguments.
1018         (repeat_previous, get_saved_command_line, save_command_line):
1019         New functions.
1020         (gdb_init): Initialize saved_command_line
1021         and previous_saved_command_line.
1022         * main.c (captured_main_1): Remove saved_command_line initialization.
1023         * event-top.c (handle_line_of_input): Update to use
1024         the new 'repeat' related functions instead of direct access to
1025         saved_command_line.
1026         * command.h (repeat_previous, get_saved_command_line,
1027         save_command_line): New declarations.
1028         (dont_repeat): Add comment.
1029
1030 2019-05-30  Tom Tromey  <tromey@adacore.com>
1031
1032         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1033         Fix comment.
1034         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1035
1036 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1037
1038         PR cli/24587
1039         * completer.c (complete): Initialize variable word.
1040
1041 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1042
1043         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1044         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1045         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1046         'body' is NULL to the outter 'if', protecting the '!is_define'
1047         situation as well.
1048
1049 2019-05-29  Tom Tromey  <tromey@adacore.com>
1050
1051         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1052         (dwarf_unknown): New function.
1053         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1054         (dwarf_type_encoding_name): Use dwarf_unknown.
1055
1056 2019-05-29  Tom Tromey  <tromey@adacore.com>
1057
1058         PR c++/20020:
1059         * cp-valprint.c (cp_print_value_fields): Call
1060         cp_print_static_field inside "try".
1061
1062 2019-05-29  Tom Tromey  <tromey@adacore.com>
1063
1064         * inflow.c (struct terminal_info): Add default operator=.
1065         * configure: Rebuild.
1066         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1067         -Wdeprecated-copy-dtor, -Wredundant-move.
1068
1069 2019-05-29  Tom Tromey  <tromey@adacore.com>
1070
1071         * NEWS: Add entry.
1072         * infcmd.c (print_return_value_1): Handle finish_print
1073         option.
1074         (show_print_finish): New function.
1075         (_initialize_infcmd): Add "set/show print finish" commands.
1076         * valprint.c (user_print_options): Initialize new member.
1077         * valprint.h (struct value_print_options) <finish_print>: New
1078         member.
1079
1080 2019-05-28  Tom Tromey  <tromey@adacore.com>
1081
1082         * ada-lang.c (ada_remove_Xbn_suffix)
1083         (find_old_style_renaming_symbol)
1084         (parse_old_style_renaming): Remove.
1085         (ada_find_renaming_symbol): Don't call
1086         find_old_style_renaming_symbol.
1087         (ada_is_renaming_symbol): Rename from
1088         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1089         bool.  Now static.
1090         (ada_read_var_value): Update and simplify.
1091         * ada-exp.y (write_var_or_type): Remove old code.
1092
1093 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1094
1095         * event-top.c: Remove include comment.
1096         * inflow.c (class scoped_ignore_sigttou): Move from here...
1097         * inflow.h (class scoped_ignore_sigttou): ...to here.
1098         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1099         * top.c:  Remove include comment.
1100
1101 2019-05-27  Tom Tromey  <tom@tromey.com>
1102
1103         * NEWS: Fix typo.
1104
1105 2019-05-22  Tom Tromey  <tromey@adacore.com>
1106
1107         * target.c (target_follow_exec): Constify parameter.
1108         * target-delegates.c: Rebuild.
1109         * remote.c (remote_target::follow_exec): Constify parameter.
1110         * infrun.c (follow_exec): Constify parameter.
1111         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1112         (target_follow_exec): Likewise.
1113
1114 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1115
1116         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1117         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1118
1119 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1120
1121         * NEWS: Add debugredirect and testsuite sections.
1122
1123 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1124
1125         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1126         target descriptions using exclusively floating point register name
1127         aliases.
1128
1129 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         PR gdb/18644:
1132         * f-lang.c (build_fortran_types): Handle the case where
1133         gdbarch_floatformat_for_type returns a nullptr.
1134
1135 2019-05-21  Tom de Vries  <tdevries@suse.de>
1136
1137         PR cli/24587
1138         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1139
1140 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         PR gdb/18644:
1143         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1144         16-byte floats.
1145         * i386-tdep.c (i386_floatformat_for_type): Use
1146         floatformats_ia64_quad for the 16-byte floating point component
1147         within a fortran 32-byte complex number.
1148
1149 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1152         delete default constructor.
1153         (find_partial_die): Update to return const struct.
1154         (partial_die_parent_scope): Move variable declaration into scope
1155         of its use and change its type to auto.
1156         (guess_partial_die_structure_name): Likewise.
1157         (partial_die_info::fixup): Likewise.
1158
1159 2019-05-17  Tom Tromey  <tromey@adacore.com>
1160
1161         * source.c (find_and_open_source): Remove cast.
1162
1163 2019-05-17  Tom Tromey  <tromey@adacore.com>
1164
1165         * annotate.c (annotate_source): Make "filename" const.
1166         * annotate.h (annotate_source): Use const.
1167
1168 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1169
1170         * disasm.c (set_disassembler_options): Send errors to stderr.
1171
1172 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1173
1174         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1175         (cli_interp_base::set_logging): Check debug_redirect.
1176         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1177         * cli/cli-logging.c (debug_redirect): Add static variable.
1178         (pop_output_files): Add default param.
1179         (handle_redirections): Print debug setting.
1180         (show_logging_command): Likewise.
1181         (_initialize_cli_logging): Add debugredirect command.
1182         * interps.c (current_interp_set_logging): Add debug_redirect
1183         parameter.
1184         * interps.h (set_logging): Add debug_redirect parameter.
1185         (current_interp_set_logging): Likewise.
1186         * mi/mi-common.h: Likewise.
1187         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1188
1189 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1190             Tom Tromey  <tromey@adacore.com>
1191
1192         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1193         directly.
1194         * cli/cli-interp.h (make_logging_output): Remove declaration.
1195         * cli/cli-logging.c (make_logging_output): Remove function.
1196         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1197         directly.
1198         * ui-file.c (tee_file::tee_file): Remove bools.
1199         (tee_file::~tee_file): Remove deletes.
1200         * ui-file.h (tee_file): Remove bools.
1201
1202 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1203
1204         * mi/mi-cmds.h (mi_cmd_complete): New function.
1205         * mi/mi-main.c (mi_cmd_complete): Likewise.
1206         * mi/mi-cmds.c: Define new MI command -complete.
1207         * NEWS: Mention new -complete command.
1208
1209 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1210
1211         * completer.h (complete): New function.
1212         * completer.c (complete): Likewise.
1213         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1214         function defined in completer.h.
1215
1216 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1217
1218         * MAINTAINERS (Write After Approval): Add myself.
1219
1220 2019-05-17  Tom de Vries  <tdevries@suse.de>
1221
1222         PR gdb/24094
1223         * dwarf2read.c (struct cu_partial_die_info): New struct.
1224         (find_partial_die): Return cu_partial_die_info.
1225         (partial_die_parent_scope, guess_partial_die_structure_name)
1226         (partial_die_info::fixup): Handle new return type of find_partial_die.
1227
1228 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1229
1230         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1231         "std::string", simplifying the algorithm.
1232
1233 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1234
1235         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1236         (stap_static_probe_ops::get_probes): Likewise.
1237
1238 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1239
1240         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1241         '-')" and "else if".
1242         (stap_parse_single_operand): Join checks for
1243         "gdbarch_stap_parse_special_token_p" and
1244         "gdbarch_stap_parse_special_token" in the same "if" statement.
1245         Invert check when verifying for operation on register
1246         displacement.
1247
1248 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1249
1250         * stap-probe.c (stap_get_opcode): Update comment.
1251         (stap_get_expected_argument_type): Likewise.
1252         (handle_stap_probe): Likewise.
1253
1254 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1255
1256         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1257         return type to 'bool'.  Adjust comment.  Use 'bool' when
1258         appropriate.
1259         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1260         * stap-probe.c (stap_parse_argument_1): Likewise.
1261         (stap_is_operator): Likewise.
1262         (stap_is_generic_prefix): Likewise.
1263         (stap_is_register_prefix): Likewise.
1264         (stap_is_register_indirection_prefix): Likewise.
1265         (stap_is_integer_prefix): Likewise.
1266         (stap_generic_check_suffix): Likewise.
1267         (stap_check_integer_suffix): Likewise.
1268         (stap_check_register_suffix): Likewise.
1269         (stap_check_register_indirection_suffix): Likewise.
1270         (stap_parse_register_operand): Likewise.
1271         (stap_parse_single_operand): Likewise.
1272         (stap_parse_argument_1): Likewise.
1273         (stap_probe::get_argument_count): Likewise.
1274         (stap_is_operator): Likewise.
1275
1276 2019-05-16  Tom Tromey  <tromey@adacore.com>
1277
1278         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1279         keyword to foreach.
1280
1281 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1282
1283         * linux-thread-db.c (try_thread_db_load_1): Change return type
1284         to bool.
1285         (try_thread_db_load): Likewise.
1286         (try_thread_db_load_from_pdir_1): Likewise.
1287         (try_thread_db_load_from_pdir): Likewise.
1288         (try_thread_db_load_from_sdir): Likewise.
1289         (try_thread_db_load_from_dir): Likewise.
1290         (thread_db_load_search): Likewise.
1291         (has_libpthread): Likewise.
1292         (thread_db_load): Likewise.
1293
1294 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1295
1296         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1297         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1298         NULL, and complain/return if that's the case.
1299
1300 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1301
1302         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1303         (advance, posn, abstract_read_memory): New functions.
1304         [struct mem_read_abstraction]: New struct.
1305         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1306
1307 2019-05-14  Tom Tromey  <tromey@adacore.com>
1308
1309         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1310         value is not lval_memory.
1311
1312 2019-05-14  Tom Tromey  <tromey@adacore.com>
1313
1314         * solib.c (info_sharedlibrary_command): Style the file name.
1315
1316 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1317
1318         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1319         (aarch64_vnv_type): Likewise.
1320         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1321         * common/tdesc.c: Likewise.
1322         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1323         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1324         * features/aarch64-fpu.xml: Add ieee half view.
1325         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1326         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1327         * gdbtypes.h (struct builtin_type): Likewise.
1328         (struct objfile_type): Likewise.
1329
1330 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1331
1332         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1333         typo.
1334         * location.h (string_to_event_location): Likewise.
1335
1336 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1337
1338         GDB 8.3 released.
1339
1340 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1341
1342         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1343         New variable declaration.
1344         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1345         New variable.
1346         (print_one_breakpoint): Use ui_out::test_flags and new global
1347         variable to compute use_fixed_output.
1348         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1349         Remove.
1350         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1351         (mi_multi_location_breakpoint_output_fixed): Remove.
1352         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1353         new variable.
1354         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1355         fix_multi_location_breakpoint_output flag if version >= 3.
1356         * ui-out.h (enum ui_out_flag)
1357         <fix_multi_location_breakpoint_output>: New enumerator.
1358
1359 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1360
1361         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1362
1363 2019-05-10  Tom Tromey  <tromey@adacore.com>
1364
1365         * ada-lang.c (catch_ada_completer): New function.
1366         (_initialize_ada_language): Use it.
1367
1368 2019-05-10  Tom Tromey  <tromey@adacore.com>
1369
1370         * thread.c (print_thread_info): Make "requested_threads" const.
1371         * gdbthread.h (print_thread_info): Make "requested_threads"
1372         const.
1373         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1374         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1375
1376 2019-05-08  Tom Tromey  <tom@tromey.com>
1377
1378         * gdbtypes.c (objfile_type_data): Change type.
1379         (objfile_type, _initialize_gdbtypes): Update.
1380
1381 2019-05-08  Tom Tromey  <tom@tromey.com>
1382
1383         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1384         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1385         (_initialize_dwarf2_frame): Update.
1386
1387 2019-05-08  Tom Tromey  <tom@tromey.com>
1388
1389         * objc-lang.c (objc_objfile_data): Change type.
1390         (find_methods): Update.
1391         (_initialize_objc_lang): Remove.
1392
1393 2019-05-08  Tom Tromey  <tom@tromey.com>
1394
1395         * stabsread.c (rs6000_builtin_type_data): Change type.
1396         (rs6000_builtin_type, _initialize_stabsread): Update.
1397
1398 2019-05-08  Tom Tromey  <tom@tromey.com>
1399
1400         * mips-tdep.c (mips_pdr_data): Remove.
1401         (_initialize_mips_tdep): Update.
1402
1403 2019-05-08  Tom Tromey  <tom@tromey.com>
1404
1405         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1406         (hppa_init_objfile_priv_data, read_unwind_info)
1407         (find_unwind_entry, _initialize_hppa_tdep): Update.
1408
1409 2019-05-08  Tom Tromey  <tom@tromey.com>
1410
1411         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1412         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1413         on obstack.
1414         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1415
1416 2019-05-08  Tom Tromey  <tom@tromey.com>
1417
1418         * mdebugread.c (basic_type_data): Change type.
1419         (basic_type, _initialize_mdebugread): Update.
1420
1421 2019-05-08  Tom Tromey  <tom@tromey.com>
1422
1423         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1424
1425 2019-05-08  Tom Tromey  <tom@tromey.com>
1426
1427         * nto-tdep.c (nto_inferior_data_reg): Change type.
1428         (nto_inferior_data): Update.
1429         (nto_inferior_data_cleanup, nto_new_inferior_data)
1430         (_initialize_nto_tdep): Remove.
1431         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1432
1433 2019-05-08  Tom Tromey  <tom@tromey.com>
1434
1435         * ada-lang.c (struct ada_inferior_data): Add initializers.
1436         (ada_inferior_data): Change type.
1437         (ada_inferior_data_cleanup): Remove.
1438         (get_ada_inferior_data, ada_inferior_exit)
1439         (struct ada_pspace_data): Add initializers, destructor.
1440         (ada_pspace_data_handle): Change type.
1441         (get_ada_pspace_data): Update.
1442         (ada_pspace_data_cleanup): Remove.
1443
1444 2019-05-08  Tom Tromey  <tom@tromey.com>
1445
1446         * coffread.c (struct coff_symfile_info): Add initializers.
1447         (coff_objfile_data_key): Move lower.  Change type.
1448         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1449         Update.
1450         (coff_free_info): Remove.
1451
1452 2019-05-08  Tom Tromey  <tom@tromey.com>
1453
1454         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1455         (fbsd_pspace_data_handle): Move lower.  Change type.
1456         (get_fbsd_pspace_data): Update.
1457         (fbsd_pspace_data_cleanup): Remove.
1458         (_initialize_fbsd_tdep): Update.
1459
1460 2019-05-08  Tom Tromey  <tom@tromey.com>
1461
1462         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1463         (get_ada_tasks_pspace_data): Update.
1464         (ada_tasks_pspace_data_cleanup): Remove.
1465         (_initialize_tasks): Update.
1466         (ada_tasks_inferior_data_handle): Change type.
1467         (get_ada_tasks_inferior_data): Update.
1468         (ada_tasks_inferior_data_cleanup): Remove.
1469         (struct ada_tasks_pspace_data): Add initializers.
1470
1471 2019-05-08  Tom Tromey  <tom@tromey.com>
1472
1473         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1474         * symfile-debug.c (debug_sym_get_probes): Change type.
1475         * stap-probe.c (handle_stap_probe):
1476         (stap_static_probe_ops::get_probes): Change type.
1477         * probe.h (class static_probe_ops) <get_probes>: Change type.
1478         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1479         (parse_probes_in_pspace): Update.
1480         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1481         Update.
1482         (any_static_probe_ops::get_probes): Change type.
1483         * elfread.c (elfread_data): New typedef.
1484         (probe_key): Change type.
1485         (elf_get_probes): Likewise.  Update.
1486         (probe_key_free): Remove.
1487         (_initialize_elfread): Update.
1488         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1489         Change type.
1490         (dtrace_process_dof_probe, dtrace_process_dof)
1491         (dtrace_static_probe_ops::get_probe): Change type.
1492
1493 2019-05-08  Tom Tromey  <tom@tromey.com>
1494
1495         * xcoffread.c (struct xcoff_symfile_info): Rename from
1496         coff_symfile_info.  Add initializers.
1497         (xcoff_objfile_data_key): Move lower.  Change type.
1498         (XCOFF_DATA): Rewrite.
1499         (xcoff_free_info): Remove.
1500         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1501         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1502         (xcoff_initial_scan): Update.
1503
1504 2019-05-08  Tom Tromey  <tom@tromey.com>
1505
1506         * solib-svr4.c (struct svr4_info): Add initializers and
1507         destructor.
1508         <probes_table>: Now an htab_up.
1509         (solib_svr4_pspace_data): Change type.
1510         (free_probes_table): Simplify.
1511         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1512         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1513         (probes_table_remove_objfile_probes, register_solib_event_probe)
1514         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1515         (_initialize_svr4_solib): Update.
1516
1517 2019-05-08  Tom Tromey  <tom@tromey.com>
1518
1519         * remote.c (remote_pspace_data): Change type.
1520         (remote_pspace_data_cleanup): Remove.
1521         (get_remote_exec_file, set_pspace_remote_exec_file)
1522         (_initialize_remote): Update.
1523
1524 2019-05-08  Tom Tromey  <tom@tromey.com>
1525
1526         * breakpoint.c (breakpoint_objfile_key): Change type.
1527         (get_breakpoint_objfile_data): Update.
1528         (free_breakpoint_objfile_data): Remove.
1529         (_initialize_breakpoint): Update.
1530
1531 2019-05-08  Tom Tromey  <tom@tromey.com>
1532
1533         * linux-tdep.c (struct linux_info): Add initializers.
1534         (linux_inferior_data): Move.  Change type.
1535         (invalidate_linux_cache_inf): Update.
1536         (linux_inferior_data_cleanup): Remove.
1537         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1538
1539 2019-05-08  Tom Tromey  <tom@tromey.com>
1540
1541         * auxv.c (auxv_inferior_data): Move.  Change type.
1542         (auxv_inferior_data_cleanup): Remove.
1543         (invalidate_auxv_cache_inf): Rewrite.
1544         (get_auxv_inferior_data, _initialize_auxv): Update.
1545
1546 2019-05-08  Tom Tromey  <tom@tromey.com>
1547
1548         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1549         (symfile_debug_objfile_data_key): Change type.
1550         (symfile_debug_installed, debug_qf_has_symbols)
1551         (debug_qf_find_last_source_symtab)
1552         (debug_qf_forget_cached_source_info)
1553         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1554         (debug_qf_print_stats, debug_qf_dump)
1555         (debug_qf_expand_symtabs_for_function)
1556         (debug_qf_expand_all_symtabs)
1557         (debug_qf_expand_symtabs_with_fullname)
1558         (debug_qf_map_matching_symbols)
1559         (debug_qf_expand_symtabs_matching)
1560         (debug_qf_find_pc_sect_compunit_symtab)
1561         (debug_qf_map_symbol_filenames)
1562         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1563         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1564         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1565         (debug_sym_read_linetable, debug_sym_relocate): Update.
1566         (symfile_debug_free_objfile): Remove.
1567         (install_symfile_debug_logging, _initialize_symfile_debug):
1568         Update.
1569
1570 2019-05-08  Tom Tromey  <tom@tromey.com>
1571
1572         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1573         allocate_on_obstack.
1574         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1575         (get_dwarf2_per_objfile): Update.
1576         (set_dwarf2_per_objfile): Remove.
1577         (dwarf2_has_info, dwarf2_get_section_info): Update.
1578         (dwarf2_free_objfile): Remove.
1579         (_initialize_dwarf2_read): Update.
1580
1581 2019-05-08  Tom Tromey  <tom@tromey.com>
1582
1583         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1584         initializers.
1585         <unsupported_script_warning_printed,
1586         script_not_found_warning_printed>: Now bool.
1587         (auto_load_pspace_data): Change type.
1588         (~auto_load_pspace_info): Rename from
1589         auto_load_pspace_data_cleanup.
1590         (get_auto_load_pspace_data, init_loaded_scripts_info)
1591         (clear_section_scripts, maybe_print_unsupported_script_warning)
1592         (maybe_print_script_not_found_warning, _initialize_auto_load):
1593         Update.
1594
1595 2019-05-08  Tom Tromey  <tom@tromey.com>
1596
1597         * objfiles.c (objfile_pspace_info): Add destructor and
1598         initializers.
1599         (objfiles_pspace_data): Change type.
1600         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1601         (get_objfile_pspace_data): Update.
1602         (objfiles_bfd_data): Change type.
1603         (get_objfile_bfd_data): Update.
1604         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1605
1606 2019-05-08  Tom Tromey  <tom@tromey.com>
1607
1608         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1609         Change type.
1610         (get_catch_syscall_inferior_data): Update.
1611         (catch_syscall_inferior_data_cleanup): Remove.
1612         (_initialize_break_catch_syscall): Update.
1613
1614 2019-05-08  Tom Tromey  <tom@tromey.com>
1615
1616         * inflow.c (struct terminal_info): Add destructor and
1617         initializers.
1618         (inflow_inferior_data): Change type.
1619         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1620         (get_inflow_inferior_data, inflow_inferior_exit)
1621         (swap_terminal_info, _initialize_inflow): Update.
1622
1623 2019-05-08  Tom Tromey  <tom@tromey.com>
1624
1625         * target-dcache.c (target_dcache_cleanup): Remove.
1626         (target_dcache_aspace_key): Change type.
1627         (target_dcache_init_p, target_dcache_invalidate)
1628         (target_dcache_get, target_dcache_get_or_init)
1629         (_initialize_target_dcache): Update.
1630         * dcache.h (struct dcache_deleter): New.
1631
1632 2019-05-08  Tom Tromey  <tom@tromey.com>
1633
1634         * symtab.c (struct symbol_cache): Add destructor and
1635         initializers.
1636         (symbol_cache_key): Move.  Change type.
1637         (make_symbol_cache, free_symbol_cache): Remove.
1638         (get_symbol_cache): Update.
1639         (symbol_cache_cleanup): Remove.
1640         (ALL_PSPACES, symbol_cache_flush)
1641         (maintenance_print_symbol_cache)
1642         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1643         Update.
1644
1645 2019-05-08  Tom Tromey  <tom@tromey.com>
1646
1647         * symtab.c (struct main_info): Add destructor and initializers.
1648         (main_progspace_key): Move.  Change type.
1649         (get_main_info): Update.
1650         (main_info_cleanup): Remove.
1651         (_initialize_symtab): Update.
1652
1653 2019-05-08  Tom Tromey  <tom@tromey.com>
1654
1655         * registry.h (DECLARE_REGISTRY): Define the _key class.
1656
1657 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * NEWS: Merge two 'New commands' sections.
1660
1661 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1662
1663         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1664         parameter and use Ada language definition instead.
1665         (ada_val_print_ptr): Remove unused language parameter.
1666         (ada_val_print_num): Remove language parameter and use Ada language
1667         definition instead.
1668         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1669         parameter.
1670         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1671         parameter and use Ada language definition instead.
1672         (ada_val_print_1): Update all ada_val_print_xxx calls.
1673         Remove language parameter.
1674         (ada_val_print): Update ada_val_print_1 call.
1675
1676 2019-05-08  Tom Tromey  <tromey@adacore.com>
1677
1678         * remote.c (remote_hw_watchpoint_limit)
1679         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1680         Now static.
1681
1682 2019-05-08  Tom Tromey  <tromey@adacore.com>
1683
1684         * maint.c (_initialize_maint_cmds): Move initialization code to
1685         remote.c.
1686         (watchdog, show_watchdog): Move to remote.c.
1687         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1688         "watchdog" static.
1689         (_initialize_remote): Move initialization code from maint.c.
1690         * defs.h (watchdog): Don't declare.
1691
1692 2019-05-08  Tom Tromey  <tromey@adacore.com>
1693
1694         * tui/tui-interp.c: Include main.h.
1695         * interps.c: Include main.h.
1696         * main.h (interpreter_p): Declare.
1697         * defs.h (interpreter_p): Don't declare.
1698
1699 2019-05-08  Tom Tromey  <tromey@adacore.com>
1700
1701         * dwarf2loc.c: Include dwarf2read.h.
1702         * defs.h (read_unsigned_leb128): Don't declare.
1703         * dwarf2read.h (read_unsigned_leb128): Declare.
1704
1705 2019-05-08  Tom Tromey  <tromey@adacore.com>
1706
1707         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1708         method.
1709
1710 2019-05-08  Tom Tromey  <tromey@adacore.com>
1711
1712         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1713         when no wrap column is set.
1714
1715 2019-05-08  Tom Tromey  <tromey@adacore.com>
1716
1717         * c-lang.c (c_get_string): Handle non-C-style arrays.
1718
1719 2019-05-08  Tom Tromey  <tromey@adacore.com>
1720
1721         * typeprint.c (print_offset_data::update): Print the bit offset,
1722         not the number of bits remaining.
1723
1724 2019-05-08  Tom Tromey  <tromey@adacore.com>
1725
1726         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1727         padding at end of comment.
1728
1729 2019-05-08  Tom Tromey  <tromey@adacore.com>
1730
1731         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1732         Compare main types.
1733
1734 2019-05-06  Tom Tromey  <tom@tromey.com>
1735
1736         * common/scoped_mmap.c: Include common-defs.h.
1737         * common/scoped_mmap.h: Don't include config.h.
1738
1739 2019-05-04  Tom Tromey  <tom@tromey.com>
1740
1741         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1742         (struct aarch64_call_info): Add initializers.
1743         <si>: Now a std::vector.
1744         (pass_on_stack, aarch64_push_dummy_call): Update.
1745
1746 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1747             Tom Tromey  <tom@tromey.com>
1748
1749         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1750         (ppc_threads): Now a std::vector.  Now static.
1751         (hwdebug_find_thread_points_by_tid)
1752         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1753         Update.
1754
1755 2019-05-04  Tom Tromey  <tom@tromey.com>
1756
1757         * arc-tdep.c (arc_tdesc_init): Return bool.
1758
1759 2019-05-04  Tom Tromey  <tom@tromey.com>
1760
1761         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1762         Use gdb_assert_not_reached.
1763
1764 2019-05-04  Tom Tromey  <tom@tromey.com>
1765
1766         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1767         "false".
1768
1769 2019-05-04  Tom Tromey  <tom@tromey.com>
1770
1771         * arc-tdep.c (arc_tdesc_init): Use bool.
1772
1773 2019-05-04  Tom Tromey  <tom@tromey.com>
1774
1775         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1776
1777 2019-05-04  Tom Tromey  <tom@tromey.com>
1778
1779         * cli/cli-cmds.c (valid_command_p): Return bool.
1780
1781 2019-05-04  Tom Tromey  <tom@tromey.com>
1782
1783         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1784         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1785
1786 2019-05-04  Raul Tambre  <raul@tambre.ee>
1787
1788         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1789         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1790         operator for comparison.
1791
1792 2019-05-04  Tom Tromey  <tom@tromey.com>
1793
1794         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1795         (lookup_partial_symbol, print_partial_symbols)
1796         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1797         (psymbol_compare): Update.
1798         (add_psymbol_to_bcache): Clear the entire psymbol.
1799         (maintenance_check_psymtabs): Update.
1800         * psympriv.h (struct partial_symbol): Don't derive from
1801         general_symbol_info.
1802         <obj_section, unrelocated_address, address,
1803         set_unrelocated_address>: Update.
1804         <ginfo>: New member.
1805         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1806         (debug_names::write_psymbols): Update.
1807
1808 2019-05-04  Tom de Vries  <tdevries@suse.de>
1809
1810         * contrib/cc-with-tweaks.sh: Support -n arg.
1811
1812 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1813
1814         * corelow.c (core_target::detach): Ensure frame cache and
1815         register caches are cleared.
1816         inferior.c (exit_inferior_1): Likewise.
1817
1818 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1819             Tom Tromey  <tom@tromey.com>
1820
1821         * dictionary.c (collate_pending_symbols_by_language): Remove
1822         "struct" from foreach.
1823         * symtab.c (lookup_global_symbol_from_objfile)
1824         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1825         foreach.
1826         * ser-tcp.c (net_open): Remove "struct" from foreach.
1827         * objfiles.c (objfile_relocate, objfile_rebase)
1828         (objfile_has_symbols): Remove "struct" from foreach.
1829         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1830         from foreach.
1831         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1832         foreach.
1833         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1834         "struct" from foreach.
1835         * ada-lang.c (create_excep_cond_exprs)
1836         (ada_exception_catchpoint_cond_string): Remove "struct" from
1837         foreach.
1838
1839 2019-05-03  Tom Tromey  <tromey@adacore.com>
1840
1841         * ada-exp.y (convert_char_literal): Check suffix of each
1842         enumerator.
1843
1844 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1845
1846         PR ada/21406:
1847         * ada-exp.y (yywrap): Don't define.
1848         * ada-lex.l (%option): Add noyywrap
1849         (yywrap): Remove.
1850
1851 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1852
1853         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1854         _WIN32_WINNT to the XP level, unless already defined to a higher
1855         level.
1856
1857         * unittests/parse-connection-spec-selftests.c:
1858         * ser-tcp.c:
1859         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1860         override.
1861
1862         * symfile.c (find_separate_debug_file): Remove colon from the
1863         drive spec of DOS/Windows file names of the target, so that the
1864         file name produced from DEBUGDIR and the target's directory will
1865         be valid on DOS/Windows systems.
1866
1867 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1868
1869         * rust-lang.c (val_print_struct): Handle printing structures
1870         containing strings.
1871
1872 2019-05-02  Tom Tromey  <tromey@adacore.com>
1873
1874         * valarith.c (_initialize_valarith): Remove.
1875
1876 2019-05-01  Tom Tromey  <tromey@adacore.com>
1877
1878         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1879         bitfields.
1880
1881 2019-05-01  Tom Tromey  <tromey@adacore.com>
1882
1883         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1884         for big-endian copies.
1885
1886 2019-04-30  Ali Tamur  <tamur@google.com>
1887         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1888         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1889         (read_3_bytes): New function.
1890
1891 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1892
1893         * windows-nat.c (main_thread_id): Delete.
1894         (handle_output_debug_string): Replace main_thread_id by
1895         current_event.dwThreadId.
1896         (fake_create_process): Likewise.
1897         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1898         Do not set main_thread_id.
1899         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1900         current_event.dwThreadId.
1901         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1902
1903 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1904
1905         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1906         Use current_event.dwThreadId instead of main_thread_id.
1907
1908 2019-04-30  Tom Tromey  <tromey@adacore.com>
1909
1910         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1911         (create_excep_cond_exprs): Iterate over program spaces.
1912         (ada_exception_catchpoint_cond_string): Examine all minimal
1913         symbols for exception types.
1914
1915 2019-04-30  Tom Tromey  <tromey@adacore.com>
1916
1917         PR c++/24470:
1918         * dwarf2read.c (process_structure_scope): Handle case where type
1919         has template parameters but no symbol was created.
1920
1921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1922             Chris January  <chris.january@arm.com>
1923
1924         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1925         qualifier.
1926         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1927
1928 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * f-typeprint.c (f_print_type): Update rules for printing
1931         whitespace.
1932         (f_type_print_varspec_suffix): Likewise.
1933
1934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1935             Chris January  <chris.january@arm.com>
1936
1937         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1938         function arguments.
1939
1940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * f-lang.c (build_fortran_types): Change name of void type to
1943         lower case.
1944         * f-typeprint.c (f_type_print_base): Print the name of the void
1945         type, rather than a fixed string.
1946         * f-valprint.c (f_decorations): Use lower case void string.
1947
1948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1949             Chris January  <chris.january@arm.com>
1950
1951         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1952         types for Fortran.
1953
1954 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1955             Chris January  <chris.january@arm.com>
1956             David Lecomber  <david.lecomber@arm.com>
1957
1958         * f-exp.y (BINOP_INTRINSIC): New token.
1959         (exp): New parser rule handling BINOP_INTRINSIC.
1960         (f77_keywords): Add new builtin procedures.
1961         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1962         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1963         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1964         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1965         (print_unop_subexp_f): New function.
1966         (print_binop_subexp_f): New function.
1967         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1968         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1969         (dump_subexp_body_f): Likewise.
1970         (operator_check_f): Likewise.
1971         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1972         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1973
1974 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1977         UNOP_KIND.
1978         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1979         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1980         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1981         (operator_length_f): New fuction.
1982         (print_subexp_f): New function.
1983         (op_name_f): New function.
1984         (dump_subexp_body_f): New function.
1985         (operator_check_f): New function.
1986         (exp_descriptor_f): Replace standard expression handling functions
1987         with new functions.
1988         * gdb/fortran-operator.def: New file.
1989         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1990         * gdb/std-operator.def: Remove UNOP_KIND.
1991
1992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1993
1994         * std-operator.def: Remove unbalanced, stray double quote
1995         character.
1996
1997 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1998             Chris January  <chris.january@arm.com>
1999             Daniel Everett  <daniel.everett@arm.com>
2000             Nick Forrington  <nick.forrington@arm.com>
2001             Richard Bunt  <richard.bunt@arm.com>
2002
2003         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2004         of depth when printing anonymous structs or unions.
2005         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2006         Don't print either the top-level value, or the children if the
2007         max-depth is exceeded.
2008         (ppscm_print_children): When printing the key of a map, allow one
2009         extra level of depth.
2010         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2011         print either the top-level value, or the children if the max-depth
2012         is exceeded.
2013         (print_children): When printing the key of a map, allow one extra
2014         level of depth.
2015         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2016         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2017         (user_print_options): Initialise max_depth field.
2018         (val_print_scalar_or_string_type_p): New function.
2019         (val_print): Check to see if the max depth has been reached.
2020         (val_print_check_max_depth): Define new function.
2021         (show_print_max_depth): New function.
2022         (_initialize_valprint): Add 'print max-depth' option.
2023         * valprint.h (struct value_print_options) <max_depth>: New field.
2024         (val_print_check_max_depth): Declare new function.
2025         * NEWS: Document new feature.
2026
2027 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2028
2029         * ada-lang.c (ada_language_defn): Initialise new field.
2030         * c-lang.c (c_is_string_type_p): New function.
2031         (c_language_defn): Initialise new field.
2032         (cplus_language_defn): Initialise new field.
2033         (asm_language_defn): Initialise new field.
2034         (minimal_language_defn): Initialise new field.
2035         * c-lang.h (c_is_string_type_p): Declare new function.
2036         * d-lang.c (d_language_defn): Initialise new field.
2037         * f-lang.c (f_is_string_type_p): New function.
2038         (f_language_defn): Initialise new field.
2039         * go-lang.c (go_is_string_type_p): New function.
2040         (go_language_defn): Initialise new field.
2041         * language.c (default_is_string_type_p): New function.
2042         (unknown_language_defn): Initialise new field.
2043         (auto_language_defn): Initialise new field.
2044         * language.h (struct language_defn) <la_is_string_type_p>: New
2045         member variable.
2046         (default_is_string_type_p): Declare new function.
2047         * m2-lang.c (m2_language_defn): Initialise new field.
2048         * objc-lang.c (objc_language_defn): Initialise new field.
2049         * opencl-lang.c (opencl_language_defn): Initialise new field.
2050         * p-lang.c (pascal_is_string_type_p): New function.
2051         (pascal_language_defn): Initialise new field.
2052         * rust-lang.c (rust_is_string_type_p): New function.
2053         (rust_language_defn): Initialise new field.
2054
2055 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2056
2057         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2058         New field.
2059         * ada-lang.c (ada_language_defn): Initialise new field.
2060         * c-lang.c (c_language_defn): Likewise.
2061         (cplus_language_defn): Likewise.
2062         (asm_language_defn): Likewise.
2063         (minimal_language_defn): Likewise.
2064         * d-lang.c (d_language_defn): Likewise.
2065         * f-lang.c (f_language_defn): Likewise.
2066         * go-lang.c (go_language_defn): Likewise.
2067         * language.c (unknown_language_defn): Likewise.
2068         (auto_language_defn): Likewise.
2069         * m2-lang.c (m2_language_defn): Likewise.
2070         * objc-lang.c (objc_language_defn): Likewise.
2071         * opencl-lang.c (opencl_language_defn): Likewise.
2072         * p-lang.c (pascal_language_defn): Likewise.
2073         * rust-lang.c (rust_language_defn): Likewise.
2074
2075 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2076
2077         * ada-lang.c (ada_is_character_type): Change return type to bool.
2078         (ada_is_string_type): Likewise.
2079         * ada-lang.h (ada_is_character_type): Update declaration
2080         (ada_is_string_type): Likewise.
2081
2082 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         Support style in 'frame|thread apply'
2085
2086         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2087         * record.c (record_start, record_stop): Update callers of
2088         execute_command_to_string with false.
2089         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2090         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2091         methods.
2092         (class string_file): New constructor with term_out parameter.
2093         Override methods term_out and can_emit_style_escape.  New member
2094         term_out.
2095         (class stdio_file): Override can_emit_style_escape.
2096         (class tee_file): Override term_out and can_emit_style_escape.
2097         * utils.h (can_emit_style_escape): Remove.
2098         * utils.c (can_emit_style_escape): Likewise.
2099         Update all callers of can_emit_style_escape (SOMESTREAM) to
2100         SOMESTREAM->can_emit_style_escape.
2101         * source-cache.c (source_cache::get_source_lines): Likewise.
2102         * stack.c (frame_apply_command_count): Call execute_command_to_string
2103         passing the term_out characteristic of the current gdb_stdout.
2104         * thread.c (thr_try_catch_cmd): Likewise.
2105         * top.c (execute_command_to_string): pass term_out parameter
2106         to construct the string_file for the command output.
2107         * ui-file.c (term_cli_styling): New function (most code moved
2108         from utils.c can_emit_style_escape).
2109         (string_file::string_file, string_file::can_emit_style_escape,
2110         stdio_file::can_emit_style_escape, tee_file::term_out,
2111         tee_file::can_emit_style_escape): New functions.
2112
2113 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2114
2115         * NEWS: Mention the new set|show may-call-functions.
2116         * infcall.c (may_call_functions_p): New variable.
2117         (show_may_call_functions_p): New function.
2118         (call_function_by_hand_dummy): Throws an error if not
2119         may-call-functions.
2120         (_initialize_infcall): Call add_setshow_boolean_cmd for
2121         may-call-functions.
2122
2123 2019-04-25  Keith Seitz  <keiths@redhat.com>
2124
2125         PR c++/24367
2126         * cp-support.c (inspect_type): Don't attempt substitutions
2127         of symbol with the same name.
2128
2129 2019-04-25  Tom Tromey  <tromey@adacore.com>
2130
2131         PR gdb/24475:
2132         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2133         static.
2134
2135 2019-04-25  Tom Tromey  <tromey@adacore.com>
2136
2137         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2138         rvalue reference.
2139         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2140         (gdb_xml_parser::parse): Use std::move.
2141         * python/python-internal.h (gdbpy_convert_exception): Take a const
2142         reference.
2143         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2144         std::move.
2145         * python/py-utils.c (gdbpy_convert_exception): Take a const
2146         reference.
2147         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2148         Use std::move.
2149         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2150         Use std::move.
2151         * mi/mi-main.c (mi_print_exception): Take a const reference.
2152         * main.c (handle_command_errors): Take a const reference.
2153         * linespec.c (parse_linespec): Use std::move.
2154         * infcall.c (run_inferior_call): Use std::move.
2155         (call_function_by_hand_dummy): Use std::move.
2156         * exec.c (try_open_exec_file): Use std::move.
2157         * exceptions.h (exception_print, exception_fprintf)
2158         (exception_print_same): Update.
2159         * exceptions.c (print_exception, exception_print)
2160         (exception_fprintf, exception_print_same): Change parameters to
2161         const reference.
2162         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2163         * common/new-op.c: Use std::move.
2164         * common/common-exceptions.h (struct gdb_exception): Add move
2165         constructor.
2166         (struct gdb_exception_error, struct gdb_exception_quit, struct
2167         gdb_quit_bad_alloc): Change constructor to move constructor.
2168         (throw_exception): Change parameter to rvalue reference.
2169         * common/common-exceptions.c (throw_exception): Take rvalue
2170         reference.
2171         * cli/cli-interp.c (safe_execute_command): Use std::move.
2172         * breakpoint.c (insert_bp_location, location_to_sals): Use
2173         std::move.
2174
2175 2019-04-25  Tom Tromey  <tromey@adacore.com>
2176
2177         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2178         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2179         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2180         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2181         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2182         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2183         guile/scm-value.c: Use unpack.
2184         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2185         gdbscm_gdb_exception.
2186         (gdbscm_throw_gdb_exception): Likewise.
2187         (struct gdbscm_gdb_exception): New.
2188         (unpack): New function.
2189         (gdbscm_wrap): Use unpack.
2190
2191 2019-04-25  Tom Tromey  <tromey@adacore.com>
2192
2193         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2194         (gdb_rl_callback_handler): Use std::move.
2195         * common/common-exceptions.h (struct gdb_exception): Add move
2196         assignment operator.
2197         (throw_exception_sjlj): Change "exception" to const reference.
2198         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2199         (throw_exception_sjlj): Change "exception" to const reference.
2200
2201 2019-04-25  Tom Tromey  <tromey@adacore.com>
2202
2203         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2204         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2205         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2206         Update.
2207         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2208         Update.
2209         * mi/mi-interp.c (mi_interp::exec): Update.
2210         * linespec.c (parse_linespec): Update.
2211         * infcall.c (run_inferior_call): Update.
2212         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2213         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2214         (gdbscm_lookup_global_symbol): Update.
2215         * guile/scm-param.c (gdbscm_parameter_value): Update.
2216         * guile/scm-frame.c (gdbscm_frame_read_register)
2217         (gdbscm_frame_read_var): Update.
2218         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2219         * exec.c (try_open_exec_file): Update.
2220         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2221         (gdb_rl_callback_handler): Update.
2222         * common/common-exceptions.h (exception_none): Don't declare.
2223         * common/common-exceptions.c (exception_none): Don't define.
2224         (struct catcher) <exception>: Update.
2225         * cli/cli-interp.c (safe_execute_command): Update.
2226         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2227
2228 2019-04-25  Ali Tamur  <tamur@google.com>
2229
2230         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2231         (read_attribute_value): Likewise.
2232         (dwarf2_read_addr_index): Update comment.
2233         (read_str_index): Add DW_FORM_strx.
2234         (dwarf2_string_attr): Likewise.
2235         (dwarf2_const_value_attr): Likewise.
2236         (dump_die_shallow): Likewise.
2237         (dwarf2_fetch_constant_bytes): Likewise.
2238         (skip_form_bytes): Likewise.
2239         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2240
2241 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2242
2243         PR corefiles/11608
2244         PR corefiles/18187
2245         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2246         OFFSET.  Verify if current mapping contains an ELF header.
2247         (linux_find_memory_regions_full): Adjust call to
2248         dump_mapping_p.
2249
2250 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2251             Kang Li <kanglictf@gmail.com>
2252
2253         PR gdb/21600
2254
2255         * dwarf2-frame.c (read_initial_length): Be consistent about using
2256         unsigned representation of length.
2257         (decode_frame_entry_1): Likewise.  Check for wraparound of
2258         end pointer as well as buffer overflow.
2259
2260 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2261
2262         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2263         "vq".
2264
2265 2019-04-24  Tom Tromey  <tromey@adacore.com>
2266
2267         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2268
2269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * s12z-tdep.c (s12z_unwind_pc): Delete.
2272         (s12z_unwind_sp): Delete.
2273         (s12z_gdbarch_init): Don't register deleted functions with
2274         gdbarch.
2275
2276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * rl78-tdep.c (rl78_unwind_sp): Delete.
2279         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2280
2281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2284         (xstormy16_unwind_pc): Delete.
2285         (xstormy16_dummy_id): Delete.
2286         (xstormy16_gdbarch_init): Don't register deleted functions with
2287         gdbarch.
2288
2289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2290
2291         * vax-tdep.c (vax_unwind_pc): Delete.
2292         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2293
2294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * v850-tdep.c (v850_unwind_sp): Delete.
2297         (v850_unwind_pc): Delete.
2298         (v850_dummy_id): Delete.
2299         (v850_gdbarch_init): Don't register deleted functions with
2300         gdbarch.
2301
2302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2305         (tilegx_unwind_pc): Delete.
2306         (tilegx_unwind_dummy_id): Delete.
2307         (tilegx_gdbarch_init): Don't register deleted functions with
2308         gdbarch.
2309
2310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2311
2312         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2313         (tic6x_dummy_id): Delete.
2314         (tic6x_gdbarch_init): Don't register deleted functions with
2315         gdbarch.
2316
2317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * sparc-tdep.c (sparc_unwind_pc): Delete.
2320         (sparc32_gdbarch_init): Don't register deleted function with
2321         gdbarch.
2322
2323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * sh-tdep.c (sh_unwind_sp): Delete.
2326         (sh_unwind_pc): Delete.
2327         (sh_dummy_id): Delete.
2328         (sh_gdbarch_init): Don't register deleted functions with
2329         gdbarch.
2330
2331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * score-tdep.c (score_unwind_sp): Delete.
2334         (score_unwind_pc): Delete.
2335         (score_dummy_id): Delete.
2336         (score_gdbarch_init): Don't register deleted functions with
2337         gdbarch.
2338
2339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * rx-tdep.c (rx_unwind_pc): Delete.
2342         (rx_unwind_sp): Delete.
2343         (rx_dummy_id): Delete.
2344         (rx_gdbarch_init): Don't register deleted functions with
2345         gdbarch.  Update comment.
2346
2347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2350         (rs6000_dummy_id): Delete.
2351         (rs6000_gdbarch_init): Don't register deleted functions with
2352         gdbarch.
2353
2354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * or1k-tdep.c (or1k_dummy_id): Delete.
2357         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2358
2359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * nios2-tdep.c (nios2_dummy_id): Delete.
2362         (nios2_unwind_sp): Delete.
2363         (nios2_gdbarch_init): Don't register deleted functions with
2364         gdbarch.
2365
2366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * nds32-tdep.c (nds32_dummy_id): Delete.
2369         (nds32_unwind_pc): Delete.
2370         (nds32_unwind_sp): Delete.
2371         (nds32_gdbarch_init): Don't register deleted functions with
2372         gdbarch.
2373
2374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * msp430-tdep.c (msp430_unwind_pc): Delete.
2377         (msp430_unwind_sp): Delete.
2378         (msp430_dummy_id): Delete.
2379         (msp430_gdbarch_init): Don't register deleted functions with
2380         gdbarch.
2381
2382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * moxie-tdep.c (moxie_unwind_sp): Delete.
2385         (moxie_unwind_pc): Delete.
2386         (moxie_dummy_id): Delete.
2387         (moxie_gdbarch_init): Don't register deleted functions with
2388         gdbarch.
2389
2390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2393         (mn10300_unwind_pc): Delete.
2394         (mn10300_unwind_sp): Delete.
2395         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2396         mn10300_unwind_sp.
2397         (mn10300_frame_unwind_init): Don't register deleted functions with
2398         gdbarch.
2399
2400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * mep-tdep.c (mep_unwind_pc): Delete.
2403         (mep_unwind_sp): Delete.
2404         (mep_dummy_id): Delete.
2405         (mep_gdbarch_init): Don't register deleted functions with
2406         gdbarch.
2407
2408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2411         (m68hc11_unwind_sp): Delete.
2412         (m68hc11_gdbarch_init): Don't register deleted functions with
2413         gdbarch.
2414
2415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * m32r-tdep.c (m32r_unwind_sp): Delete.
2418         (m32r_unwind_pc): Delete.
2419         (m32r_dummy_id): Delete.
2420         (m32r_gdbarch_init): Don't register deleted functions with
2421         gdbarch.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * m32c-tdep.c (m32c_unwind_pc): Delete.
2426         (m32c_unwind_sp): Delete.
2427         (m32c_dummy_id): Delete.
2428         (m32c_gdbarch_init): Don't register deleted functions with
2429         gdbarch.
2430
2431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2434         (lm32_unwind_pc): Delete.
2435         (lm32_dummy_id): Delete.
2436         (lm32_gdbarch_init): Don't register deleted functions with
2437         gdbarch.
2438
2439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2442         (iq2000_unwind_pc): Delete.
2443         (iq2000_dummy_id): Delete.
2444         (iq2000_gdbarch_init): Don't register deleted functions with
2445         gdbarch.
2446
2447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * nds32-tdep.c (nds32_type_align): Delete.
2450         (nds32_push_dummy_call): Use type_align instead.
2451
2452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * arm-tdep.c (arm_type_align): Only handle vector override case.
2455         (arm_push_dummy_call): Use type_align.
2456         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2457
2458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2461         case.
2462         (pass_on_stack): Use type_align.
2463         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2464         function.
2465
2466 2019-04-23  Tom Tromey  <tromey@adacore.com>
2467
2468         * dwarf2read.c (line_header::file_name_at): Remove unused
2469         overload.
2470
2471 2019-04-23  Tom de Vries  <tdevries@suse.de>
2472
2473         PR gdb/24438
2474         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2475         invocation.
2476
2477
2478 2019-03-27  Ali Tamur  <tamur@google.com>
2479
2480         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2481         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2482         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2483         (dwarf_expr_context::get_addr_index): Likewise
2484         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2485         (symbol_needs_eval_context::get_addr_index): Likewise
2486         (disassemble_dwarf_expression): Add DW_OP_addrx
2487         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2488         (read_cutu_die_from_dwo): Update comment
2489         (skip_one_die): Add DW_FORM_addrx
2490         (read_attribute_value): Likewise
2491         (var_decode_location): Add DW_OP_addrx
2492         (dwarf2_const_value_attr): Add DW_FORM_addrx
2493         (dump_die_shallow): Likewise
2494         (dwarf2_fetch_constant_bytes): Likewise
2495         (decode_locdesc): Add DW_OP_addrx
2496         (skip_form_bytes): Add DW_FORM_addrx
2497
2498 2019-04-22  Ali Tamur  <tamur@google.com>
2499
2500         * MAINTAINERS (Write After Approval): Add self.
2501
2502 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2503
2504         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2505         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2506         (open_symbol_file_object): Likewise.
2507         (svr4_default_sos): Add info parameter.
2508         (svr4_read_so_list): Likewise.
2509         (svr4_current_sos_direct): Adjust functions calls to pass down
2510         info.
2511         (svr4_current_sos_1): Add info parameter.
2512         (svr4_current_sos): Call get_svr4_info, pass info down to
2513         svr4_current_sos_1.
2514         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2515         get_svr4_info.
2516         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2517         get_svr4_info.
2518         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2519         to get_svr4_info.
2520         (probes_table_remove_objfile_probes): Likewise.
2521         (register_solib_event_probe): Add info parameter.
2522         (solist_update_incremental): Pass info parameter down to
2523         svr4_read_so_list.
2524         (disable_probes_interface): Add info parameter.
2525         (svr4_handle_solib_event): Pass current_program_space to
2526         get_svr4_info.  Adjust disable_probes_interface cleanup.
2527         (svr4_create_probe_breakpoints): Add info parameter, pass it
2528         down to register_solib_event_probe.
2529         (svr4_create_solib_event_breakpoints): Add info parameter,
2530         pass it down to svr4_create_probe_breakpoints.
2531         (enable_break): Pass info down to
2532         svr4_create_solib_event_breakpoints.
2533         (svr4_solib_create_inferior_hook): Pass current_program_space to
2534         get_svr4_info.
2535         (svr4_clear_solib): Likewise.
2536
2537 2019-04-22  Pedro Alves  <palves@redhat.com>
2538
2539         * solib-svr4.c (svr4_free_objfile_observer): New.
2540         (probe_and_action::objfile): New field.
2541         (probes_table_htab_remove_objfile_probes)
2542         (probes_table_remove_objfile_probes): New functions.
2543         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2544         in the new probe_and_action.  Don't store the probe in 'lookup'.
2545         (svr4_create_probe_breakpoints): Pass objfile to
2546         register_solib_event_probe.
2547         (_initialize_svr4_solib): Register a free_objfile observer.
2548
2549 2019-04-19  Tom Tromey  <tom@tromey.com>
2550
2551         * common/queue.h: Remove.
2552
2553 2019-04-19  Tom Tromey  <tom@tromey.com>
2554
2555         * event-loop.c: Don't include "common/queue.h".
2556
2557 2019-04-19  Tom Tromey  <tom@tromey.com>
2558
2559         * remote.c (remote_target): Use delete.
2560         * remote-notif.h: Include <list>, not "common/queue.h".
2561         (notif_client_p): Remove typedef.
2562         (remote_notif_state): Add constructor, destructor, initializer.
2563         <notif_queue>: Now a std::list.
2564         (remote_notif_state_xfree): Don't declare.
2565         * remote-notif.c (remote_notif_process, handle_notification)
2566         (remote_notif_state_allocate): Update.
2567         (~remote_notif_state): Rename from remote_notif_state_xfree.
2568
2569 2019-04-19  Tom Tromey  <tom@tromey.com>
2570
2571         * symfile.c (reread_symbols): Update.
2572         * objfiles.c (objfile_register_static_link)
2573         (objfile_lookup_static_link): Update
2574         (~objfile) Don't delete static_links.
2575         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2576
2577 2019-04-19  Tom Tromey  <tom@tromey.com>
2578
2579         * type-stack.h (struct type_stack) <insert>: Constify string.
2580         * type-stack.c (type_stack::insert): Constify string.
2581         * gdbtypes.h (lookup_template_type): Update.
2582         (address_space_name_to_int): Update.
2583         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2584         const.
2585         (lookup_template_type): Make name const.
2586         * c-exp.y: Update rules.
2587         (lex_one_token, classify_name, classify_inner_name)
2588         (c_print_token): Update.
2589         * p-exp.y: Update rules.
2590         (yylex): Update.
2591         * f-exp.y: Update rules.
2592         (yylex): Update.
2593         * d-exp.y: Update rules.
2594         (lex_one_token, classify_name, classify_inner_name): Update.
2595         * parse.c (write_dollar_variable, copy_name): Return std::string.
2596         * parser-defs.h (copy_name): Change return type.
2597         * m2-exp.y: Update rules.
2598         (yylex): Update.
2599         * go-exp.y (lex_one_token): Update.
2600         Update rules.
2601         (classify_unsafe_function, classify_packaged_name)
2602         (classify_name, yylex): Update.
2603
2604 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2605
2606         * configure.ac: add --enable-source-highlight switch.
2607         * configure: Regenerate.
2608         * top.c (print_gdb_version): plumb --enable-source-highlight
2609         status to "show configuration".
2610
2611 2019-04-19  Tom Tromey  <tromey@adacore.com>
2612
2613         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2614         Check ADA_TYPE_P.
2615         (empty_record, ada_template_to_fixed_record_type_1)
2616         (template_to_static_fixed_type)
2617         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2618         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2619         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2620         macros.
2621
2622 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2623
2624         PR symtab/24423:
2625         * source.c (print_source_lines_base): Advance "iter" when a
2626         control character is seen.
2627
2628 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2629
2630         * inferior.h (struct infcall_suspend_state_deleter):
2631         Catch exception in destructor to avoid crash.
2632
2633 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2634
2635         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2636         close to the add_com "shell".
2637
2638 2019-04-18  Tom Tromey  <tromey@adacore.com>
2639
2640         * process-stratum-target.h (class process_stratum_target)
2641         <stratum>: Add "final".
2642
2643 2019-04-17  Tom Tromey  <tromey@adacore.com>
2644
2645         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2646         against nullptr before use.
2647
2648 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2649
2650         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2651
2652 2019-04-17  Jim Wilson  <jimw@sifive.com>
2653             Andrew Burgess  <andrew.burgess@embecosm.com>
2654
2655         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2656         code read might fail, assume 4-byte breakpoint in that case.
2657
2658 2019-04-15  Leszek Swirski  <leszeks@google.com>
2659
2660         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2661         rather than a hand-rolled POD check when checking for forced MEMORY
2662         classification.
2663
2664 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2665
2666         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2667         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2668         function.
2669         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2670         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2671         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2672         declaration.
2673
2674 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2675
2676         * aarch64-linux-nat.c
2677         (aarch64_linux_nat_target::thread_architecture): Add override.
2678         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2679         each VQ.
2680
2681 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2682
2683         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2684
2685 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2686
2687         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2688         target types of size 96-bits, add some additional comments, and
2689         check that the builtin type we found was the correct size.
2690
2691 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2692
2693         * utils.c (prompt_for_continue): Don't restore the styling at the
2694         end, as applied_style has the wrong value.  This fixes styling in
2695         long lists of file names that are interrupted by the "Continue?"
2696         prompt.
2697
2698 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2701         * c-lang.c (c_language_defn): Likewise.
2702         (cplus_language_defn): Likewise.
2703         (asm_language_defn): Likewise.
2704         (minimal_language_defn): Likewise.
2705         * d-lang.c (d_language_defn): Likewise.
2706         * f-lang.c (f_language_defn): Likewise.
2707         * go-lang.c (go_language_defn): Likewise.
2708         * language.c (unknown_language_defn): Likewise.
2709         (auto_language_defn): Likewise.
2710         * language.h (struct language_defn): Remove la_magic field.
2711         (LANG_MAGIC): Delete.
2712         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2713         * objc-lang.c (objc_language_defn): Likewise.
2714         * opencl-lang.c (opencl_language_defn): Likewise.
2715         * p-lang.c (pascal_language_defn): Likewise.
2716         * rust-lang.c (rust_language_defn): Likewise.
2717
2718 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * riscv-tdep.c (riscv_type_align): New function.
2721         (riscv_type_alignment): Delete.
2722         (riscv_arg_location): Use 'type_align'.
2723         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2724
2725 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2726
2727         * gdbtypes.c (type_align): A struct with no non-static fields also
2728         has alignment of 1.
2729
2730 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2731
2732         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2733         component to 0.
2734         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2735         member.
2736         (riscv_struct_info::analyse): New implementation using new
2737         analyse_inner member function.
2738         (riscv_struct_info::field_offset): New member function.
2739         (riscv_struct_info::m_offsets): New member variable.
2740         (riscv_struct_info::analyse_inner): New private member function,
2741         takes the old implementation of riscv_struct_info::analyse but
2742         extended to track field offsets.
2743         (riscv_call_arg_struct): Update the struct folding special cases
2744         to handle cases where empty C++ structs, which are non-zero
2745         length, are found.
2746         (riscv_arg_location): Initialise the length of each location, a
2747         non-zero length now indicates the location is in use.
2748         (riscv_push_dummy_call): Allow for the first location having a
2749         non-zero offset when setting up arguments.
2750         (riscv_return_value): Likewise, but for return values.
2751
2752 2019-04-11  Tom Tromey  <tromey@adacore.com>
2753
2754         * utils.c (internal_vproblem): Make "msg" const.
2755
2756 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2757
2758         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2759         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2760         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2761         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2762
2763 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2764
2765         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2766         function.
2767         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2768         of amd64_collect_native_gregset.
2769         (amd64_linux_nat_target::store_registers): Likewise.
2770
2771 2019-04-10  Tom Tromey  <tom@tromey.com>
2772
2773         * symtab.c (lookup_global_symbol_from_objfile)
2774         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2775         * objfiles.h (class separate_debug_iterator): New.
2776         (class separate_debug_range): New.
2777         (struct objfile) <separate_debug_objfiles>: New method.
2778         (objfile_separate_debug_iterate): Don't declare.
2779         * objfiles.c (separate_debug_iterator::operator++): Rename from
2780         objfile_separate_debug_iterate.
2781         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2782         iterator.
2783         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2784         iterator.
2785
2786 2019-04-10  Tom Tromey  <tom@tromey.com>
2787
2788         * symfile.c (reread_symbols): Remove old comment.
2789         * objfiles.c (free_all_objfiles): Fix a typo.
2790
2791 2019-04-10  Tom Tromey  <tom@tromey.com>
2792
2793         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2794         * minsyms.c (lookup_minimal_symbol): Use foreach.
2795         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2796         (lookup_minimal_symbol_solib_trampoline): Likewise.
2797         * symfile.c (reread_symbols): Use foreach.
2798
2799 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2800             Tom Tromey  <tromey@adacore.com>
2801
2802         PR rust/24414:
2803         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2804         (rust_lex_int_test): Change "value" to be LONGEST.
2805         (rust_lex_tests): Add test for long integer literal.
2806
2807 2019-04-09  Tom Tromey  <tromey@adacore.com>
2808
2809         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2810         to bool.
2811         (extended_remote_target::attach): Update.
2812         (remote_target::remote_notice_new_inferior): Update.
2813         (remote_target::add_current_inferior_and_thread): Update.
2814         * inferior.c (exit_inferior_1): Use "false".
2815         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2816
2817 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2818
2819         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2820         the "start" command.
2821
2822 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2823
2824         * python/py-inferior.c (infpy_thread_from_thread_handle):
2825         Adjust comments to reflect renaming of thread_from_thread_handle
2826         to thread_from_handle.  Adjust keywords.  Fix type error message.
2827         (inferior_object_methods): Add thread_from_handle.  Retain
2828         thread_from_thread_handle, but mark it as deprecated.
2829
2830 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2831
2832         * gdbthread.h (find_thread_by_handle): Revise declaration.
2833         * thread.c (find_thread_by_handle): Likewise.  Adjust
2834         implementation too.
2835         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2836         support for buffer objects as handles.
2837
2838 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2839
2840         * python/py-infthread.c (thpy_thread_handle): New function.
2841         (thread_object_methods): Register thpy_thread_handle.
2842
2843 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2844
2845         * gdbthread.h (thread_to_thread_handle): Declare.
2846         * thread.c (gdbtypes.h): Include.
2847         (thread_to_thread_handle): New function.
2848
2849         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2850         (target_thread_info_to_thread_handle): Declare.
2851         * target.c (target_thread_info_to_thread_handle): New function.
2852         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2853         * target-delegates.c: Regenerate.
2854
2855         * linux-thread-db.c (class thread_db_target): Add method
2856         thread_info_to_thread_handle.
2857         (thread_db_target::thread_info_to_thread_handle): Define.
2858         * remote.c (class remote_target): Add new method
2859         thread_info_to_thread_handle.
2860         (remote_target::thread_info_to_thread_handle): Define.
2861
2862 2019-04-08  Pedro Alves  <palves@redhat.com>
2863
2864         * common/common-exceptions.c (throw_exception): Don't create
2865         named object to throw; throw directly.
2866         (throw_it): Likewise.  Don't initialize gdb_exception::message
2867         here, with new; pass FMT and AP to the ctor instead.
2868         * common/common-exceptions.h: Include <string>.
2869         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2870         const char *, va_list)): New ctor.  Use std::make_shared.
2871         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2872         errors)): Delete.
2873         (gdb_exception_error::gdb_exception_error(enum errors, const char
2874         *, va_list)): New.
2875         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2876         Add assertion.
2877         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2878         errors)): Delete.
2879         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2880         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2881         Add assertion.
2882
2883 2019-04-08  Tom Tromey  <tom@tromey.com>
2884
2885         * valops.c (value_rtti_indirect_type): Replace throw_exception
2886         with throw.
2887         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2888         with throw.
2889         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2890         throw.
2891         * target.c (target_translate_tls_address): Replace throw_exception
2892         with throw.
2893         * stack.c (frame_apply_command_count): Replace throw_exception
2894         with throw.
2895         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2896         throw.
2897         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2898         with throw.
2899         * rs6000-tdep.c (rs6000_frame_cache)
2900         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2901         * remote.c: Replace throw_exception with throw.
2902         * record-full.c (record_full_message, record_full_wait_1)
2903         (record_full_restore): Replace throw_exception with throw.
2904         * record-btrace.c:
2905         (get_thread_current_frame_id, record_btrace_start_replaying)
2906         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2907         (cmd_record_btrace_start): Replace throw_exception with throw.
2908         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2909         throw.
2910         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2911         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2912         * linespec.c:
2913         (find_linespec_symbols): Replace throw_exception with throw.
2914         * infrun.c (displaced_step_prepare, resume): Replace
2915         throw_exception with throw.
2916         * infcmd.c (post_create_inferior): Replace throw_exception with
2917         throw.
2918         * inf-loop.c (inferior_event_handler): Replace throw_exception
2919         with throw.
2920         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2921         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2922         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2923         (get_prev_frame_always, get_frame_pc_if_available)
2924         (get_frame_address_in_block_if_available, get_frame_language):
2925         Replace throw_exception with throw.
2926         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2927         throw_exception with throw.
2928         * eval.c (fetch_subexp_value, evaluate_var_value)
2929         (evaluate_funcall, evaluate_subexp_standard): Replace
2930         throw_exception with throw.
2931         * dwarf2loc.c (call_site_find_chain)
2932         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2933         Replace throw_exception with throw.
2934         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2935         with throw.
2936         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2937         throw.
2938         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2939         * completer.c (complete_line_internal): Replace throw_exception
2940         with throw.
2941         * compile/compile-object-run.c (compile_object_run): Replace
2942         throw_exception with throw.
2943         * cli/cli-script.c (process_next_line): Replace throw_exception
2944         with throw.
2945         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2946         (btrace_enable, btrace_maint_update_pt_packets): Replace
2947         throw_exception with throw.
2948         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2949         throw_exception with throw.
2950         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2951         throw_exception with throw.
2952         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2953         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2954         * aarch64-tdep.c (aarch64_make_prologue_cache)
2955         (aarch64_make_stub_cache): Replace throw_exception with throw.
2956
2957 2019-04-08  Tom Tromey  <tom@tromey.com>
2958
2959         * common/common-exceptions.c (throw_exception): Rename from
2960         throw_exception_cxx.  Remove old copy.  Make argument const.
2961         (throw_it): Create and throw exception objects directly.
2962         * common/common-exceptions.h (throw_exception): Make argument
2963         const.
2964         (struct gdb_exception_error): Add constructor.
2965         (struct gdb_exception_quit): Add constructor.
2966
2967 2019-04-08  Tom Tromey  <tom@tromey.com>
2968
2969         * common/common-exceptions.h (exception_rethrow): Don't declare.
2970         (TRY_SJLJ): Update comment.
2971         (TRY, CATCH, END_CATCH): Remove.
2972         * common/common-exceptions.c (exception_rethrow): Remove.
2973
2974 2019-04-08  Tom Tromey  <tom@tromey.com>
2975
2976         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2977         Remove.
2978         (gdb_exception_error): Rename from
2979         gdb_exception_RETURN_MASK_ERROR.
2980         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2981         (gdb_quit_bad_alloc): Update.
2982         * aarch64-tdep.c: Update.
2983         * ada-lang.c: Update.
2984         * ada-typeprint.c: Update.
2985         * ada-valprint.c: Update.
2986         * amd64-tdep.c: Update.
2987         * arch-utils.c: Update.
2988         * break-catch-throw.c: Update.
2989         * breakpoint.c: Update.
2990         * btrace.c: Update.
2991         * c-varobj.c: Update.
2992         * cli/cli-cmds.c: Update.
2993         * cli/cli-interp.c: Update.
2994         * cli/cli-script.c: Update.
2995         * common/common-exceptions.c: Update.
2996         * common/new-op.c: Update.
2997         * common/selftest.c: Update.
2998         * compile/compile-c-symbols.c: Update.
2999         * compile/compile-cplus-symbols.c: Update.
3000         * compile/compile-object-load.c: Update.
3001         * compile/compile-object-run.c: Update.
3002         * completer.c: Update.
3003         * corelow.c: Update.
3004         * cp-abi.c: Update.
3005         * cp-support.c: Update.
3006         * cp-valprint.c: Update.
3007         * darwin-nat.c: Update.
3008         * disasm-selftests.c: Update.
3009         * dtrace-probe.c: Update.
3010         * dwarf-index-cache.c: Update.
3011         * dwarf-index-write.c: Update.
3012         * dwarf2-frame-tailcall.c: Update.
3013         * dwarf2-frame.c: Update.
3014         * dwarf2loc.c: Update.
3015         * dwarf2read.c: Update.
3016         * eval.c: Update.
3017         * event-loop.c: Update.
3018         * event-top.c: Update.
3019         * exec.c: Update.
3020         * f-valprint.c: Update.
3021         * fbsd-tdep.c: Update.
3022         * frame-unwind.c: Update.
3023         * frame.c: Update.
3024         * gdbtypes.c: Update.
3025         * gnu-v3-abi.c: Update.
3026         * guile/guile-internal.h: Update.
3027         * guile/scm-block.c: Update.
3028         * guile/scm-breakpoint.c: Update.
3029         * guile/scm-cmd.c: Update.
3030         * guile/scm-disasm.c: Update.
3031         * guile/scm-frame.c: Update.
3032         * guile/scm-lazy-string.c: Update.
3033         * guile/scm-math.c: Update.
3034         * guile/scm-param.c: Update.
3035         * guile/scm-ports.c: Update.
3036         * guile/scm-pretty-print.c: Update.
3037         * guile/scm-symbol.c: Update.
3038         * guile/scm-symtab.c: Update.
3039         * guile/scm-type.c: Update.
3040         * guile/scm-value.c: Update.
3041         * i386-linux-tdep.c: Update.
3042         * i386-tdep.c: Update.
3043         * inf-loop.c: Update.
3044         * infcall.c: Update.
3045         * infcmd.c: Update.
3046         * infrun.c: Update.
3047         * jit.c: Update.
3048         * language.c: Update.
3049         * linespec.c: Update.
3050         * linux-fork.c: Update.
3051         * linux-nat.c: Update.
3052         * linux-tdep.c: Update.
3053         * linux-thread-db.c: Update.
3054         * main.c: Update.
3055         * mi/mi-cmd-break.c: Update.
3056         * mi/mi-cmd-stack.c: Update.
3057         * mi/mi-interp.c: Update.
3058         * mi/mi-main.c: Update.
3059         * objc-lang.c: Update.
3060         * p-valprint.c: Update.
3061         * parse.c: Update.
3062         * ppc-linux-tdep.c: Update.
3063         * printcmd.c: Update.
3064         * python/py-arch.c: Update.
3065         * python/py-breakpoint.c: Update.
3066         * python/py-cmd.c: Update.
3067         * python/py-finishbreakpoint.c: Update.
3068         * python/py-frame.c: Update.
3069         * python/py-framefilter.c: Update.
3070         * python/py-gdb-readline.c: Update.
3071         * python/py-inferior.c: Update.
3072         * python/py-infthread.c: Update.
3073         * python/py-lazy-string.c: Update.
3074         * python/py-linetable.c: Update.
3075         * python/py-objfile.c: Update.
3076         * python/py-param.c: Update.
3077         * python/py-prettyprint.c: Update.
3078         * python/py-progspace.c: Update.
3079         * python/py-record-btrace.c: Update.
3080         * python/py-record.c: Update.
3081         * python/py-symbol.c: Update.
3082         * python/py-type.c: Update.
3083         * python/py-unwind.c: Update.
3084         * python/py-utils.c: Update.
3085         * python/py-value.c: Update.
3086         * python/python.c: Update.
3087         * record-btrace.c: Update.
3088         * record-full.c: Update.
3089         * remote-fileio.c: Update.
3090         * remote.c: Update.
3091         * riscv-tdep.c: Update.
3092         * rs6000-aix-tdep.c: Update.
3093         * rs6000-tdep.c: Update.
3094         * rust-exp.y: Update.
3095         * rust-lang.c: Update.
3096         * s390-tdep.c: Update.
3097         * selftest-arch.c: Update.
3098         * solib-dsbt.c: Update.
3099         * solib-frv.c: Update.
3100         * solib-spu.c: Update.
3101         * solib-svr4.c: Update.
3102         * solib.c: Update.
3103         * sparc64-linux-tdep.c: Update.
3104         * stack.c: Update.
3105         * symfile-mem.c: Update.
3106         * symmisc.c: Update.
3107         * target.c: Update.
3108         * thread.c: Update.
3109         * top.c: Update.
3110         * tracefile-tfile.c: Update.
3111         * tui/tui.c: Update.
3112         * typeprint.c: Update.
3113         * unittests/cli-utils-selftests.c: Update.
3114         * unittests/parse-connection-spec-selftests.c: Update.
3115         * valops.c: Update.
3116         * valprint.c: Update.
3117         * value.c: Update.
3118         * varobj.c: Update.
3119         * windows-nat.c: Update.
3120         * x86-linux-nat.c: Update.
3121         * xml-support.c: Update.
3122
3123 2019-04-08  Tom Tromey  <tom@tromey.com>
3124
3125         * xml-support.c: Use C++ exception handling.
3126         * x86-linux-nat.c: Use C++ exception handling.
3127         * windows-nat.c: Use C++ exception handling.
3128         * varobj.c: Use C++ exception handling.
3129         * value.c: Use C++ exception handling.
3130         * valprint.c: Use C++ exception handling.
3131         * valops.c: Use C++ exception handling.
3132         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3133         handling.
3134         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3135         * typeprint.c: Use C++ exception handling.
3136         * tui/tui.c: Use C++ exception handling.
3137         * tracefile-tfile.c: Use C++ exception handling.
3138         * top.c: Use C++ exception handling.
3139         * thread.c: Use C++ exception handling.
3140         * target.c: Use C++ exception handling.
3141         * symmisc.c: Use C++ exception handling.
3142         * symfile-mem.c: Use C++ exception handling.
3143         * stack.c: Use C++ exception handling.
3144         * sparc64-linux-tdep.c: Use C++ exception handling.
3145         * solib.c: Use C++ exception handling.
3146         * solib-svr4.c: Use C++ exception handling.
3147         * solib-spu.c: Use C++ exception handling.
3148         * solib-frv.c: Use C++ exception handling.
3149         * solib-dsbt.c: Use C++ exception handling.
3150         * selftest-arch.c: Use C++ exception handling.
3151         * s390-tdep.c: Use C++ exception handling.
3152         * rust-lang.c: Use C++ exception handling.
3153         * rust-exp.y: Use C++ exception handling.
3154         * rs6000-tdep.c: Use C++ exception handling.
3155         * rs6000-aix-tdep.c: Use C++ exception handling.
3156         * riscv-tdep.c: Use C++ exception handling.
3157         * remote.c: Use C++ exception handling.
3158         * remote-fileio.c: Use C++ exception handling.
3159         * record-full.c: Use C++ exception handling.
3160         * record-btrace.c: Use C++ exception handling.
3161         * python/python.c: Use C++ exception handling.
3162         * python/py-value.c: Use C++ exception handling.
3163         * python/py-utils.c: Use C++ exception handling.
3164         * python/py-unwind.c: Use C++ exception handling.
3165         * python/py-type.c: Use C++ exception handling.
3166         * python/py-symbol.c: Use C++ exception handling.
3167         * python/py-record.c: Use C++ exception handling.
3168         * python/py-record-btrace.c: Use C++ exception handling.
3169         * python/py-progspace.c: Use C++ exception handling.
3170         * python/py-prettyprint.c: Use C++ exception handling.
3171         * python/py-param.c: Use C++ exception handling.
3172         * python/py-objfile.c: Use C++ exception handling.
3173         * python/py-linetable.c: Use C++ exception handling.
3174         * python/py-lazy-string.c: Use C++ exception handling.
3175         * python/py-infthread.c: Use C++ exception handling.
3176         * python/py-inferior.c: Use C++ exception handling.
3177         * python/py-gdb-readline.c: Use C++ exception handling.
3178         * python/py-framefilter.c: Use C++ exception handling.
3179         * python/py-frame.c: Use C++ exception handling.
3180         * python/py-finishbreakpoint.c: Use C++ exception handling.
3181         * python/py-cmd.c: Use C++ exception handling.
3182         * python/py-breakpoint.c: Use C++ exception handling.
3183         * python/py-arch.c: Use C++ exception handling.
3184         * printcmd.c: Use C++ exception handling.
3185         * ppc-linux-tdep.c: Use C++ exception handling.
3186         * parse.c: Use C++ exception handling.
3187         * p-valprint.c: Use C++ exception handling.
3188         * objc-lang.c: Use C++ exception handling.
3189         * mi/mi-main.c: Use C++ exception handling.
3190         * mi/mi-interp.c: Use C++ exception handling.
3191         * mi/mi-cmd-stack.c: Use C++ exception handling.
3192         * mi/mi-cmd-break.c: Use C++ exception handling.
3193         * main.c: Use C++ exception handling.
3194         * linux-thread-db.c: Use C++ exception handling.
3195         * linux-tdep.c: Use C++ exception handling.
3196         * linux-nat.c: Use C++ exception handling.
3197         * linux-fork.c: Use C++ exception handling.
3198         * linespec.c: Use C++ exception handling.
3199         * language.c: Use C++ exception handling.
3200         * jit.c: Use C++ exception handling.
3201         * infrun.c: Use C++ exception handling.
3202         * infcmd.c: Use C++ exception handling.
3203         * infcall.c: Use C++ exception handling.
3204         * inf-loop.c: Use C++ exception handling.
3205         * i386-tdep.c: Use C++ exception handling.
3206         * i386-linux-tdep.c: Use C++ exception handling.
3207         * guile/scm-value.c: Use C++ exception handling.
3208         * guile/scm-type.c: Use C++ exception handling.
3209         * guile/scm-symtab.c: Use C++ exception handling.
3210         * guile/scm-symbol.c: Use C++ exception handling.
3211         * guile/scm-pretty-print.c: Use C++ exception handling.
3212         * guile/scm-ports.c: Use C++ exception handling.
3213         * guile/scm-param.c: Use C++ exception handling.
3214         * guile/scm-math.c: Use C++ exception handling.
3215         * guile/scm-lazy-string.c: Use C++ exception handling.
3216         * guile/scm-frame.c: Use C++ exception handling.
3217         * guile/scm-disasm.c: Use C++ exception handling.
3218         * guile/scm-cmd.c: Use C++ exception handling.
3219         * guile/scm-breakpoint.c: Use C++ exception handling.
3220         * guile/scm-block.c: Use C++ exception handling.
3221         * guile/guile-internal.h: Use C++ exception handling.
3222         * gnu-v3-abi.c: Use C++ exception handling.
3223         * gdbtypes.c: Use C++ exception handling.
3224         * frame.c: Use C++ exception handling.
3225         * frame-unwind.c: Use C++ exception handling.
3226         * fbsd-tdep.c: Use C++ exception handling.
3227         * f-valprint.c: Use C++ exception handling.
3228         * exec.c: Use C++ exception handling.
3229         * event-top.c: Use C++ exception handling.
3230         * event-loop.c: Use C++ exception handling.
3231         * eval.c: Use C++ exception handling.
3232         * dwarf2read.c: Use C++ exception handling.
3233         * dwarf2loc.c: Use C++ exception handling.
3234         * dwarf2-frame.c: Use C++ exception handling.
3235         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3236         * dwarf-index-write.c: Use C++ exception handling.
3237         * dwarf-index-cache.c: Use C++ exception handling.
3238         * dtrace-probe.c: Use C++ exception handling.
3239         * disasm-selftests.c: Use C++ exception handling.
3240         * darwin-nat.c: Use C++ exception handling.
3241         * cp-valprint.c: Use C++ exception handling.
3242         * cp-support.c: Use C++ exception handling.
3243         * cp-abi.c: Use C++ exception handling.
3244         * corelow.c: Use C++ exception handling.
3245         * completer.c: Use C++ exception handling.
3246         * compile/compile-object-run.c: Use C++ exception handling.
3247         * compile/compile-object-load.c: Use C++ exception handling.
3248         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3249         * compile/compile-c-symbols.c: Use C++ exception handling.
3250         * common/selftest.c: Use C++ exception handling.
3251         * common/new-op.c: Use C++ exception handling.
3252         * cli/cli-script.c: Use C++ exception handling.
3253         * cli/cli-interp.c: Use C++ exception handling.
3254         * cli/cli-cmds.c: Use C++ exception handling.
3255         * c-varobj.c: Use C++ exception handling.
3256         * btrace.c: Use C++ exception handling.
3257         * breakpoint.c: Use C++ exception handling.
3258         * break-catch-throw.c: Use C++ exception handling.
3259         * arch-utils.c: Use C++ exception handling.
3260         * amd64-tdep.c: Use C++ exception handling.
3261         * ada-valprint.c: Use C++ exception handling.
3262         * ada-typeprint.c: Use C++ exception handling.
3263         * ada-lang.c: Use C++ exception handling.
3264         * aarch64-tdep.c: Use C++ exception handling.
3265
3266 2019-04-08  Tom Tromey  <tom@tromey.com>
3267
3268         * xml-support.c (gdb_xml_parser::parse): Update.
3269         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3270         * value.c (show_convenience): Update.
3271         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3272         (test_parse_flags_qcs): Update.
3273         * thread.c (thr_try_catch_cmd): Update.
3274         * target.c (target_translate_tls_address): Update.
3275         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3276         (info_frame_command_core, frame_apply_command_count): Update.
3277         * rust-exp.y (rust_lex_exception_test): Update.
3278         * riscv-tdep.c (riscv_print_one_register_info): Update.
3279         * remote.c (remote_target::enable_btrace): Update.
3280         * record-btrace.c (record_btrace_enable_warn): Update.
3281         * python/py-utils.c (gdbpy_convert_exception): Update.
3282         * printcmd.c (do_one_display, print_variable_and_value): Update.
3283         * mi/mi-main.c (mi_print_exception): Update.
3284         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3285         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3286         * linux-nat.c (linux_nat_target::attach): Update.
3287         * linux-fork.c (class scoped_switch_fork_info): Update.
3288         * infrun.c (displaced_step_prepare): Update.
3289         * infcall.c (call_function_by_hand_dummy): Update.
3290         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3291         * gnu-v3-abi.c (print_one_vtable): Update.
3292         * frame.c (get_prev_frame_always): Update.
3293         * f-valprint.c (info_common_command_for_block): Update.
3294         * exec.c (try_open_exec_file): Update.
3295         * exceptions.c (print_exception, exception_print)
3296         (exception_fprintf, exception_print_same): Update.
3297         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3298         * dwarf-index-cache.c (index_cache::store)
3299         (index_cache::lookup_gdb_index): Update.
3300         * darwin-nat.c (maybe_cache_shell): Update.
3301         * cp-valprint.c (cp_print_value_fields): Update.
3302         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3303         (gcc_cplus_symbol_address): Update.
3304         * compile/compile-c-symbols.c (gcc_convert_symbol)
3305         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3306         * common/selftest.c: Update.
3307         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3308         a std::string.
3309         (exception_try_scope_entry, exception_try_scope_exit): Don't
3310         declare.
3311         (struct exception_try_scope): Remove.
3312         (TRY): Don't use exception_try_scope.
3313         (struct gdb_exception): Add constructor, operator=.
3314         <what>: New method.
3315         (struct gdb_exception_RETURN_MASK_ALL)
3316         (struct gdb_exception_RETURN_MASK_ERROR)
3317         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3318         (struct gdb_quit_bad_alloc): Update.
3319         * common/common-exceptions.c (exception_none): Change
3320         initializer.
3321         (struct catcher) <state, exception>: Initialize inline.
3322         <prev>: Remove member.
3323         (current_catcher): Remove.
3324         (catchers): New global.
3325         (exceptions_state_mc_init): Simplify.
3326         (catcher_pop): Remove.
3327         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3328         (try_scope_depth, exception_try_scope_entry)
3329         (exception_try_scope_exit): Remove.
3330         (throw_exception_sjlj): Update.
3331         (exception_messages, exception_messages_size): Remove.
3332         (throw_it): Simplify.
3333         (gdb_exception_sliced_copy): Remove.
3334         (throw_exception_cxx): Update.
3335         * cli/cli-script.c (script_from_file): Update.
3336         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3337         Update.
3338         * ada-valprint.c (ada_val_print): Update.
3339         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3340         (create_excep_cond_exprs): Update.
3341
3342 2019-04-08  Tom Tromey  <tom@tromey.com>
3343
3344         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3345         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3346         (TRY, CATCH, END_CATCH): Remove some definitions.
3347         * common/common-exceptions.c: Don't use GDB_XCPT.
3348         (catcher_list_size): Remove.
3349         (throw_exception, throw_it): Simplify.
3350
3351 2019-04-05  Tom Tromey  <tom@tromey.com>
3352
3353         Revert the header-sorting patch.
3354         * ft32-tdep.c: Revert.
3355         * frv-tdep.c: Revert.
3356         * frv-linux-tdep.c: Revert.
3357         * frame.c: Revert.
3358         * frame-unwind.c: Revert.
3359         * frame-base.c: Revert.
3360         * fork-child.c: Revert.
3361         * findvar.c: Revert.
3362         * findcmd.c: Revert.
3363         * filesystem.c: Revert.
3364         * filename-seen-cache.h: Revert.
3365         * filename-seen-cache.c: Revert.
3366         * fbsd-tdep.c: Revert.
3367         * fbsd-nat.h: Revert.
3368         * fbsd-nat.c: Revert.
3369         * f-valprint.c: Revert.
3370         * f-typeprint.c: Revert.
3371         * f-lang.c: Revert.
3372         * extension.h: Revert.
3373         * extension.c: Revert.
3374         * extension-priv.h: Revert.
3375         * expprint.c: Revert.
3376         * exec.h: Revert.
3377         * exec.c: Revert.
3378         * exceptions.c: Revert.
3379         * event-top.c: Revert.
3380         * event-loop.c: Revert.
3381         * eval.c: Revert.
3382         * elfread.c: Revert.
3383         * dwarf2read.h: Revert.
3384         * dwarf2read.c: Revert.
3385         * dwarf2loc.c: Revert.
3386         * dwarf2expr.h: Revert.
3387         * dwarf2expr.c: Revert.
3388         * dwarf2-frame.c: Revert.
3389         * dwarf2-frame-tailcall.c: Revert.
3390         * dwarf-index-write.h: Revert.
3391         * dwarf-index-write.c: Revert.
3392         * dwarf-index-common.c: Revert.
3393         * dwarf-index-cache.h: Revert.
3394         * dwarf-index-cache.c: Revert.
3395         * dummy-frame.c: Revert.
3396         * dtrace-probe.c: Revert.
3397         * disasm.h: Revert.
3398         * disasm.c: Revert.
3399         * disasm-selftests.c: Revert.
3400         * dictionary.c: Revert.
3401         * dicos-tdep.c: Revert.
3402         * demangle.c: Revert.
3403         * dcache.h: Revert.
3404         * dcache.c: Revert.
3405         * darwin-nat.h: Revert.
3406         * darwin-nat.c: Revert.
3407         * darwin-nat-info.c: Revert.
3408         * d-valprint.c: Revert.
3409         * d-namespace.c: Revert.
3410         * d-lang.c: Revert.
3411         * ctf.c: Revert.
3412         * csky-tdep.c: Revert.
3413         * csky-linux-tdep.c: Revert.
3414         * cris-tdep.c: Revert.
3415         * cris-linux-tdep.c: Revert.
3416         * cp-valprint.c: Revert.
3417         * cp-support.c: Revert.
3418         * cp-namespace.c: Revert.
3419         * cp-abi.c: Revert.
3420         * corelow.c: Revert.
3421         * corefile.c: Revert.
3422         * continuations.c: Revert.
3423         * completer.h: Revert.
3424         * completer.c: Revert.
3425         * complaints.c: Revert.
3426         * coffread.c: Revert.
3427         * coff-pe-read.c: Revert.
3428         * cli-out.h: Revert.
3429         * cli-out.c: Revert.
3430         * charset.c: Revert.
3431         * c-varobj.c: Revert.
3432         * c-valprint.c: Revert.
3433         * c-typeprint.c: Revert.
3434         * c-lang.c: Revert.
3435         * buildsym.c: Revert.
3436         * buildsym-legacy.c: Revert.
3437         * build-id.h: Revert.
3438         * build-id.c: Revert.
3439         * btrace.c: Revert.
3440         * bsd-uthread.c: Revert.
3441         * breakpoint.h: Revert.
3442         * breakpoint.c: Revert.
3443         * break-catch-throw.c: Revert.
3444         * break-catch-syscall.c: Revert.
3445         * break-catch-sig.c: Revert.
3446         * blockframe.c: Revert.
3447         * block.c: Revert.
3448         * bfin-tdep.c: Revert.
3449         * bfin-linux-tdep.c: Revert.
3450         * bfd-target.c: Revert.
3451         * bcache.c: Revert.
3452         * ax-general.c: Revert.
3453         * ax-gdb.h: Revert.
3454         * ax-gdb.c: Revert.
3455         * avr-tdep.c: Revert.
3456         * auxv.c: Revert.
3457         * auto-load.c: Revert.
3458         * arm-wince-tdep.c: Revert.
3459         * arm-tdep.c: Revert.
3460         * arm-symbian-tdep.c: Revert.
3461         * arm-pikeos-tdep.c: Revert.
3462         * arm-obsd-tdep.c: Revert.
3463         * arm-nbsd-tdep.c: Revert.
3464         * arm-nbsd-nat.c: Revert.
3465         * arm-linux-tdep.c: Revert.
3466         * arm-linux-nat.c: Revert.
3467         * arm-fbsd-tdep.c: Revert.
3468         * arm-fbsd-nat.c: Revert.
3469         * arm-bsd-tdep.c: Revert.
3470         * arch-utils.c: Revert.
3471         * arc-tdep.c: Revert.
3472         * arc-newlib-tdep.c: Revert.
3473         * annotate.h: Revert.
3474         * annotate.c: Revert.
3475         * amd64-windows-tdep.c: Revert.
3476         * amd64-windows-nat.c: Revert.
3477         * amd64-tdep.c: Revert.
3478         * amd64-sol2-tdep.c: Revert.
3479         * amd64-obsd-tdep.c: Revert.
3480         * amd64-obsd-nat.c: Revert.
3481         * amd64-nbsd-tdep.c: Revert.
3482         * amd64-nbsd-nat.c: Revert.
3483         * amd64-nat.c: Revert.
3484         * amd64-linux-tdep.c: Revert.
3485         * amd64-linux-nat.c: Revert.
3486         * amd64-fbsd-tdep.c: Revert.
3487         * amd64-fbsd-nat.c: Revert.
3488         * amd64-dicos-tdep.c: Revert.
3489         * amd64-darwin-tdep.c: Revert.
3490         * amd64-bsd-nat.c: Revert.
3491         * alpha-tdep.c: Revert.
3492         * alpha-obsd-tdep.c: Revert.
3493         * alpha-nbsd-tdep.c: Revert.
3494         * alpha-mdebug-tdep.c: Revert.
3495         * alpha-linux-tdep.c: Revert.
3496         * alpha-linux-nat.c: Revert.
3497         * alpha-bsd-tdep.c: Revert.
3498         * alpha-bsd-nat.c: Revert.
3499         * aix-thread.c: Revert.
3500         * agent.c: Revert.
3501         * addrmap.c: Revert.
3502         * ada-varobj.c: Revert.
3503         * ada-valprint.c: Revert.
3504         * ada-typeprint.c: Revert.
3505         * ada-tasks.c: Revert.
3506         * ada-lang.c: Revert.
3507         * aarch64-tdep.c: Revert.
3508         * aarch64-ravenscar-thread.c: Revert.
3509         * aarch64-newlib-tdep.c: Revert.
3510         * aarch64-linux-tdep.c: Revert.
3511         * aarch64-linux-nat.c: Revert.
3512         * aarch64-fbsd-tdep.c: Revert.
3513         * aarch64-fbsd-nat.c: Revert.
3514         * aarch32-linux-nat.c: Revert.
3515
3516 2019-04-05  Tom Tromey  <tom@tromey.com>
3517
3518         * ft32-tdep.c: Sort headers.
3519         * frv-tdep.c: Sort headers.
3520         * frv-linux-tdep.c: Sort headers.
3521         * frame.c: Sort headers.
3522         * frame-unwind.c: Sort headers.
3523         * frame-base.c: Sort headers.
3524         * fork-child.c: Sort headers.
3525         * findvar.c: Sort headers.
3526         * findcmd.c: Sort headers.
3527         * filesystem.c: Sort headers.
3528         * filename-seen-cache.h: Sort headers.
3529         * filename-seen-cache.c: Sort headers.
3530         * fbsd-tdep.c: Sort headers.
3531         * fbsd-nat.h: Sort headers.
3532         * fbsd-nat.c: Sort headers.
3533         * f-valprint.c: Sort headers.
3534         * f-typeprint.c: Sort headers.
3535         * f-lang.c: Sort headers.
3536         * extension.h: Sort headers.
3537         * extension.c: Sort headers.
3538         * extension-priv.h: Sort headers.
3539         * expprint.c: Sort headers.
3540         * exec.h: Sort headers.
3541         * exec.c: Sort headers.
3542         * exceptions.c: Sort headers.
3543         * event-top.c: Sort headers.
3544         * event-loop.c: Sort headers.
3545         * eval.c: Sort headers.
3546         * elfread.c: Sort headers.
3547         * dwarf2read.h: Sort headers.
3548         * dwarf2read.c: Sort headers.
3549         * dwarf2loc.c: Sort headers.
3550         * dwarf2expr.h: Sort headers.
3551         * dwarf2expr.c: Sort headers.
3552         * dwarf2-frame.c: Sort headers.
3553         * dwarf2-frame-tailcall.c: Sort headers.
3554         * dwarf-index-write.h: Sort headers.
3555         * dwarf-index-write.c: Sort headers.
3556         * dwarf-index-common.c: Sort headers.
3557         * dwarf-index-cache.h: Sort headers.
3558         * dwarf-index-cache.c: Sort headers.
3559         * dummy-frame.c: Sort headers.
3560         * dtrace-probe.c: Sort headers.
3561         * disasm.h: Sort headers.
3562         * disasm.c: Sort headers.
3563         * disasm-selftests.c: Sort headers.
3564         * dictionary.c: Sort headers.
3565         * dicos-tdep.c: Sort headers.
3566         * demangle.c: Sort headers.
3567         * dcache.h: Sort headers.
3568         * dcache.c: Sort headers.
3569         * darwin-nat.h: Sort headers.
3570         * darwin-nat.c: Sort headers.
3571         * darwin-nat-info.c: Sort headers.
3572         * d-valprint.c: Sort headers.
3573         * d-namespace.c: Sort headers.
3574         * d-lang.c: Sort headers.
3575         * ctf.c: Sort headers.
3576         * csky-tdep.c: Sort headers.
3577         * csky-linux-tdep.c: Sort headers.
3578         * cris-tdep.c: Sort headers.
3579         * cris-linux-tdep.c: Sort headers.
3580         * cp-valprint.c: Sort headers.
3581         * cp-support.c: Sort headers.
3582         * cp-namespace.c: Sort headers.
3583         * cp-abi.c: Sort headers.
3584         * corelow.c: Sort headers.
3585         * corefile.c: Sort headers.
3586         * continuations.c: Sort headers.
3587         * completer.h: Sort headers.
3588         * completer.c: Sort headers.
3589         * complaints.c: Sort headers.
3590         * coffread.c: Sort headers.
3591         * coff-pe-read.c: Sort headers.
3592         * cli-out.h: Sort headers.
3593         * cli-out.c: Sort headers.
3594         * charset.c: Sort headers.
3595         * c-varobj.c: Sort headers.
3596         * c-valprint.c: Sort headers.
3597         * c-typeprint.c: Sort headers.
3598         * c-lang.c: Sort headers.
3599         * buildsym.c: Sort headers.
3600         * buildsym-legacy.c: Sort headers.
3601         * build-id.h: Sort headers.
3602         * build-id.c: Sort headers.
3603         * btrace.c: Sort headers.
3604         * bsd-uthread.c: Sort headers.
3605         * breakpoint.h: Sort headers.
3606         * breakpoint.c: Sort headers.
3607         * break-catch-throw.c: Sort headers.
3608         * break-catch-syscall.c: Sort headers.
3609         * break-catch-sig.c: Sort headers.
3610         * blockframe.c: Sort headers.
3611         * block.c: Sort headers.
3612         * bfin-tdep.c: Sort headers.
3613         * bfin-linux-tdep.c: Sort headers.
3614         * bfd-target.c: Sort headers.
3615         * bcache.c: Sort headers.
3616         * ax-general.c: Sort headers.
3617         * ax-gdb.h: Sort headers.
3618         * ax-gdb.c: Sort headers.
3619         * avr-tdep.c: Sort headers.
3620         * auxv.c: Sort headers.
3621         * auto-load.c: Sort headers.
3622         * arm-wince-tdep.c: Sort headers.
3623         * arm-tdep.c: Sort headers.
3624         * arm-symbian-tdep.c: Sort headers.
3625         * arm-pikeos-tdep.c: Sort headers.
3626         * arm-obsd-tdep.c: Sort headers.
3627         * arm-nbsd-tdep.c: Sort headers.
3628         * arm-nbsd-nat.c: Sort headers.
3629         * arm-linux-tdep.c: Sort headers.
3630         * arm-linux-nat.c: Sort headers.
3631         * arm-fbsd-tdep.c: Sort headers.
3632         * arm-fbsd-nat.c: Sort headers.
3633         * arm-bsd-tdep.c: Sort headers.
3634         * arch-utils.c: Sort headers.
3635         * arc-tdep.c: Sort headers.
3636         * arc-newlib-tdep.c: Sort headers.
3637         * annotate.h: Sort headers.
3638         * annotate.c: Sort headers.
3639         * amd64-windows-tdep.c: Sort headers.
3640         * amd64-windows-nat.c: Sort headers.
3641         * amd64-tdep.c: Sort headers.
3642         * amd64-sol2-tdep.c: Sort headers.
3643         * amd64-obsd-tdep.c: Sort headers.
3644         * amd64-obsd-nat.c: Sort headers.
3645         * amd64-nbsd-tdep.c: Sort headers.
3646         * amd64-nbsd-nat.c: Sort headers.
3647         * amd64-nat.c: Sort headers.
3648         * amd64-linux-tdep.c: Sort headers.
3649         * amd64-linux-nat.c: Sort headers.
3650         * amd64-fbsd-tdep.c: Sort headers.
3651         * amd64-fbsd-nat.c: Sort headers.
3652         * amd64-dicos-tdep.c: Sort headers.
3653         * amd64-darwin-tdep.c: Sort headers.
3654         * amd64-bsd-nat.c: Sort headers.
3655         * alpha-tdep.c: Sort headers.
3656         * alpha-obsd-tdep.c: Sort headers.
3657         * alpha-nbsd-tdep.c: Sort headers.
3658         * alpha-mdebug-tdep.c: Sort headers.
3659         * alpha-linux-tdep.c: Sort headers.
3660         * alpha-linux-nat.c: Sort headers.
3661         * alpha-bsd-tdep.c: Sort headers.
3662         * alpha-bsd-nat.c: Sort headers.
3663         * aix-thread.c: Sort headers.
3664         * agent.c: Sort headers.
3665         * addrmap.c: Sort headers.
3666         * ada-varobj.c: Sort headers.
3667         * ada-valprint.c: Sort headers.
3668         * ada-typeprint.c: Sort headers.
3669         * ada-tasks.c: Sort headers.
3670         * ada-lang.c: Sort headers.
3671         * aarch64-tdep.c: Sort headers.
3672         * aarch64-ravenscar-thread.c: Sort headers.
3673         * aarch64-newlib-tdep.c: Sort headers.
3674         * aarch64-linux-tdep.c: Sort headers.
3675         * aarch64-linux-nat.c: Sort headers.
3676         * aarch64-fbsd-tdep.c: Sort headers.
3677         * aarch64-fbsd-nat.c: Sort headers.
3678         * aarch32-linux-nat.c: Sort headers.
3679
3680 2019-04-04  Tom Tromey  <tom@tromey.com>
3681
3682         * varobj.c (varobj_create): Update.
3683         * rust-exp.y (struct rust_parser) <update_innermost_block,
3684         lookup_symbol>: New methods.
3685         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3686         Rename.
3687         (rust_parser::rust_lookup_type)
3688         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3689         * printcmd.c (display_command, do_one_display): Update.
3690         * parser-defs.h (struct parser_state) <parser_state>: Add
3691         "tracker" parameter.
3692         (block_tracker): New member.
3693         (class innermost_block_tracker) <innermost_block_tracker>: Add
3694         "types" parameter.
3695         <reset>: Remove method.
3696         (innermost_block): Don't declare.
3697         (null_post_parser): Update.
3698         * parse.c (innermost_block): Remove global.
3699         (write_dollar_variable): Update.
3700         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3701         Remove "tracker_types" parameter.
3702         (parse_expression): Add "tracker" parameter.
3703         (parse_expression_for_completion): Update.
3704         (null_post_parser): Add "tracker" parameter.
3705         * p-exp.y: Update rules.
3706         * m2-exp.y: Update rules.
3707         * language.h (struct language_defn) <la_post_parser>: Add
3708         "tracker" parameter.
3709         * go-exp.y: Update rules.
3710         * f-exp.y: Update rules.
3711         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3712         parameter.
3713         * d-exp.y: Update rules.
3714         * c-exp.y: Update rules.
3715         * breakpoint.c (set_breakpoint_condition): Create an
3716         innermost_block_tracker.
3717         (watch_command_1): Likewise.
3718         * ada-lang.c (resolve): Add "tracker" parameter.
3719         (resolve_subexp): Likewise.
3720         * ada-exp.y (write_var_from_sym): Update.
3721
3722 2019-04-04  Tom Tromey  <tom@tromey.com>
3723
3724         * type-stack.h: New file.
3725         * type-stack.c: New file.
3726         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3727         type-stack.h.
3728         (insert_into_type_stack, insert_type, push_type, push_type_int)
3729         (insert_type_address_space, pop_type, pop_type_int)
3730         (pop_typelist, pop_type_stack, append_type_stack)
3731         (push_type_stack, get_type_stack, push_typelist)
3732         (follow_type_instance_flags, follow_types): Don't declare.
3733         * parse.c (type_stack): Remove global.
3734         (parse_exp_in_context): Update.
3735         (insert_into_type_stack, insert_type, push_type, push_type_int)
3736         (insert_type_address_space, pop_type, pop_type_int)
3737         (pop_typelist, pop_type_stack, append_type_stack)
3738         (push_type_stack, get_type_stack, push_typelist)
3739         (follow_type_instance_flags, follow_types): Remove (moved to
3740         type-stack.c).
3741         * f-exp.y (type_stack): New global.
3742         Update rules.
3743         (push_kind_type, f_parse): Update.
3744         * d-exp.y (type_stack): New global.
3745         Update rules.
3746         (d_parse): Update.
3747         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3748         Update rules.
3749         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3750         (HFILES_NO_SRCDIR): Add type-stack.h.
3751
3752 2019-04-04  Tom Tromey  <tom@tromey.com>
3753
3754         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3755         (rust_parser::convert_ast_to_expression, rust_parse)
3756         (rust_lex_test_completion, rust_lex_tests): Update.
3757         * parser-defs.h (struct expr_completion_state): New.
3758         (struct parser_state) <parser_state>: Add completion parameter.
3759         <mark_struct_expression, mark_completion_tag>: New methods.
3760         <parse_completion, m_completion_state>: New members.
3761         (prefixify_expression, null_post_parser): Update.
3762         (mark_struct_expression, mark_completion_tag): Don't declare.
3763         * parse.c (parse_completion, expout_last_struct)
3764         (expout_tag_completion_type, expout_completion_name): Remove
3765         globals.
3766         (parser_state::mark_struct_expression)
3767         (parser_state::mark_completion_tag): Now methods.
3768         (prefixify_expression): Add last_struct parameter.
3769         (prefixify_subexp): Likewise.
3770         (parse_exp_1): Update.
3771         (parse_exp_in_context): Add cstate parameter.  Update.
3772         (parse_expression_for_completion): Create an
3773         expr_completion_state.
3774         (null_post_parser): Add "completion" parameter.
3775         * p-exp.y: Update rules.
3776         (yylex): Update.
3777         * language.h (struct language_defn) <la_post_parser>: Add
3778         "completing" parameter.
3779         * go-exp.y: Update rules.
3780         (lex_one_token): Update.
3781         * expression.h (parse_completion): Don't declare.
3782         * d-exp.y: Update rules.
3783         (lex_one_token): Update rules.
3784         * c-exp.y: Update rules.
3785         (lex_one_token): Update.
3786         * ada-lang.c (resolve): Add "parse_completion" parameter.
3787         (resolve_subexp): Likewise.
3788         (ada_resolve_function): Likewise.
3789
3790 2019-04-04  Tom Tromey  <tom@tromey.com>
3791
3792         * parser-defs.h (struct parser_state) <start_arglist,
3793         end_arglist>: New methods.
3794         <arglist_len, m_funcall_chain>: New members.
3795         (arglist_len, start_arglist, end_arglist): Don't declare.
3796         * parse.c (arglist_len, funcall_chain): Remove global.
3797         (start_arglist, end_arglist): Remove functions.
3798         (parse_exp_in_context): Update.
3799         * p-exp.y: Update rules.
3800         * m2-exp.y: Update rules.
3801         * go-exp.y: Update rules.
3802         * f-exp.y: Update rules.
3803         * d-exp.y: Update rules.
3804         * c-exp.y: Update rules.
3805
3806 2019-04-04  Tom Tromey  <tom@tromey.com>
3807
3808         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3809         lex_operator, push_back>: New methods.
3810         Update all rules.
3811         (rust_parser::lex_hex, lex_escape): Rename and update.
3812         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3813         (rust_parser::lex_operator): Rename and update.
3814         (rust_parser::lex_number, rustyylex, rustyyerror)
3815         (rust_lex_test_init, rust_lex_test_sequence)
3816         (rust_lex_test_push_back, rust_lex_tests): Update.
3817         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3818         parameter.
3819         <lexptr, prev_lexptr>: New members.
3820         (lexptr, prev_lexptr): Don't declare.
3821         * parse.c (lexptr, prev_lexptr): Remove globals.
3822         (parse_exp_in_context): Update.
3823         * p-exp.y (yylex, yyerror): Update.
3824         * m2-exp.y (parse_number, yylex, yyerror): Update.
3825         * go-exp.y (lex_one_token, yyerror): Update.
3826         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3827         * d-exp.y (lex_one_token, yyerror): Update.
3828         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3829         (lex_one_token, yyerror): Update.
3830         * ada-lex.l (YY_INPUT): Update.
3831         (rewind_to_char): Update.
3832         * ada-exp.y (yyerror): Update.
3833
3834 2019-04-04  Tom Tromey  <tom@tromey.com>
3835
3836         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3837         * parser-defs.h (struct parser_state) <parser_state>: Add new
3838         parameter.
3839         <comma_terminates>: New member.
3840         (comma_terminates): Don't declare global.
3841         * parse.c (comma_terminates): Remove global.
3842         (parse_exp_in_context): Update.
3843         * p-exp.y (yylex): Update.
3844         * m2-exp.y (yylex): Update.
3845         * go-exp.y (lex_one_token): Update.
3846         * f-exp.y (yylex): Update.
3847         * d-exp.y (lex_one_token): Update.
3848         * c-exp.y (lex_one_token): Update.
3849         * ada-lex.l: Update.
3850
3851 2019-04-04  Tom Tromey  <tom@tromey.com>
3852
3853         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3854         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3855         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3856         * parser-defs.h (paren_depth): Don't declare.
3857         * parse.c (paren_depth): Remove global.
3858         (parse_exp_in_context): Update.
3859         * p-exp.y (paren_depth): New global.
3860         (pascal_parse): Initialize it.
3861         * m2-exp.y (paren_depth): New global.
3862         (m2_parse): Initialize it.
3863         * go-exp.y (paren_depth): New global.
3864         (go_parse): Initialize it.
3865         * f-exp.y (paren_depth): New global.
3866         (f_parse): Initialize it.
3867         * d-exp.y (paren_depth): New global.
3868         (d_parse): Initialize it.
3869         * c-exp.y (paren_depth): New global.
3870         (c_parse): Initialize it.
3871         * ada-lex.l (paren_depth): New global.
3872         (lexer_init): Initialize it.
3873
3874 2019-04-04  Tom Tromey  <tom@tromey.com>
3875
3876         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3877         (rust_parser::convert_ast_to_type)
3878         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3879         * parser-defs.h (struct parser_state) <parser_state>: Add
3880         parameters.  Initialize new members.
3881         <expression_context_block, expression_context_pc>: New members.
3882         * parse.c (expression_context_block, expression_context_pc):
3883         Remove globals.
3884         (parse_exp_in_context): Update.
3885         * p-exp.y: Update all rules.
3886         (yylex): Update.
3887         * m2-exp.y: Update all rules.
3888         (yylex): Update.
3889         * go-exp.y (yylex): Update.
3890         * f-exp.y (yylex): Update.
3891         * d-exp.y: Update all rules.
3892         (yylex): Update.
3893         * c-exp.y: Update all rules.
3894         (lex_one_token, classify_name, yylex, c_parse): Update.
3895         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3896
3897 2019-04-04  Tom Tromey  <tom@tromey.com>
3898
3899         * gdbarch.h, gdbarch.c: Rebuild.
3900         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3901         * stap-probe.h:
3902         (struct stap_parse_info): Replace "parser_state" with
3903         "expr_builder".
3904         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3905         (parser_state): New class.
3906         * parse.c (expr_builder): Rename.
3907         (expr_builder::release): Rename.
3908         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3909         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3910         (write_exp_elt_longcst, write_exp_elt_floatcst)
3911         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3912         (write_exp_string_vector, write_exp_bitstring)
3913         (write_exp_msymbol, mark_struct_expression)
3914         (write_dollar_variable)
3915         (insert_type_address_space, increase_expout_size): Replace
3916         "parser_state" with "expr_builder".
3917         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3918         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3919         "parser_state" with "expr_builder".
3920
3921 2019-04-04  Tom Tromey  <tom@tromey.com>
3922
3923         * rust-exp.y: Replace "parse_language" with method call.
3924         * p-exp.y:
3925         (yylex): Replace "parse_language" with method call.
3926         * m2-exp.y:
3927         (yylex): Replace "parse_language" with method call.
3928         * go-exp.y (classify_name): Replace "parse_language" with method
3929         call.
3930         * f-exp.y (yylex): Replace "parse_language" with method call.
3931         * d-exp.y (lex_one_token): Replace "parse_language" with method
3932         call.
3933         * c-exp.y:
3934         (lex_one_token, classify_name, yylex): Replace "parse_language"
3935         with method call.
3936         * ada-exp.y (find_primitive_type, type_char)
3937         (type_system_address): Replace "parse_language" with method call.
3938
3939 2019-04-04  Tom Tromey  <tom@tromey.com>
3940
3941         * rust-exp.y: Replace "parse_gdbarch" with method call.
3942         * parse.c (write_dollar_variable, insert_type_address_space):
3943         Replace "parse_gdbarch" with method call.
3944         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3945         call.
3946         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3947         call.
3948         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3949         "parse_gdbarch" with method call.
3950         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3951         with method call.
3952         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3953         "parse_gdbarch" with method call.
3954         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3955         "parse_gdbarch" with method call.
3956         * c-exp.y (parse_type, parse_number, classify_name): Replace
3957         "parse_gdbarch" with method call.
3958         * ada-lex.l: Replace "parse_gdbarch" with method call.
3959         * ada-exp.y (parse_type, find_primitive_type, type_char)
3960         (type_system_address): Replace "parse_gdbarch" with method call.
3961
3962 2019-04-04  Tom Tromey  <tom@tromey.com>
3963
3964         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3965         * stap-probe.c (stap_parse_argument): Update.
3966         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3967         initial_size parameter.
3968         * rust-exp.y (rust_lex_tests): Update.
3969         * parse.c (parser_state): Update.
3970         (parse_exp_in_context): Update.
3971         * parser-defs.h (struct parser_state) <parser_state>: Remove
3972         "initial_size" parameter.
3973
3974 2019-04-04  Tom Tromey  <tom@tromey.com>
3975
3976         * parser-defs.h (increase_expout_size): Don't declare.
3977         * parse.c (increase_expout_size): Now static.
3978
3979 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3980
3981         * gnu-nat.c (gnu_nat_target::wait): Fix
3982         target_waitstatus_to_string call.
3983
3984 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3985
3986         * eval.c (evaluate_subexp_standard): Handle internal functions
3987         during Fortran function call handling.
3988
3989 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * NEWS: Mention new internal functions.
3992         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3993         (read_base_type): Use dwarf2_init_complex_target_type.
3994         * value.c (creal_internal_fn): New function.
3995         (cimag_internal_fn): New function.
3996         (_initialize_values): Register new internal functions.
3997
3998 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3999
4000         * infrun.c (stop_all_threads): If debug_infrun, always
4001         trace the wait status after wait_one, using
4002         target_waitstatus_to_string and target_pid_to_str.
4003         (handle_inferior_event): Replace various trace of
4004         wait status kind by a single trace.
4005         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4006         wait status kind image by target_waitstatus_to_string.
4007         * target/waitstatus.c (target_waitstatus_to_string): Fix
4008         obsolete comment.
4009
4010 2019-04-01  Tom Tromey  <tromey@adacore.com>
4011
4012         PR symtab/23331:
4013         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4014
4015 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4016             Pedro Alves  <palves@redhat.com>
4017
4018         * top.c (quit_force): Call 'finalize_values'.
4019         * value.c (finalize_values): New function.
4020         * value.h (finalize_values): Declare.
4021
4022 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4023
4024         * NEWS: Announce $_gdb_major and $_gdb_minor.
4025
4026         * top.c (init_gdb_version_vars): New function.
4027         (gdb_init): Call init_gdb_version_vars.
4028
4029 2019-03-29  Tom Tromey  <tromey@adacore.com>
4030
4031         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4032         help text.  Remove dead code.
4033
4034 2019-03-29  Keith Seitz  <keiths@redhat.com>
4035
4036         From Siddhesh Poyarekar:
4037         * f-lang.h (f77_get_upperbound): Return LONGEST.
4038         (f77_get_lowerbound): Likewise.
4039         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4040         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4041         print them.
4042         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4043         plongest to format print it.
4044         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4045         (f77_get_upperbound): Likewise.
4046         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4047         LOWER_BOUND to LONGEST.
4048         (f77_create_arrayprint_offset_tbl): Likewise.
4049
4050 2019-03-29  Keith Seitz  <keiths@redhat.com>
4051
4052         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4053         %s/pulongest for TYPE_LENGTH instead of %d in format
4054         strings.
4055         * ada-typerint.c (ada_print_type): Likewise.
4056         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4057         * compile/compile-c-support.c (generate_register_struct): Likewise.
4058         * gdbtypes.c (recursive_dump_type): Likewise.
4059         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4060         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4061         instead of %d in format strings.
4062         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4063         to std::min to ULONGEST.
4064         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4065         instead of %d in format strings.
4066         * tracepoint.c (info_scope_command): Likewise.
4067         * typeprint.c (print_offset_data::update)
4068         (print_offset_data::finish): Likewise.
4069         * xtensa-tdep.c (xtensa_store_return_value)
4070         (xtensa_push_dummy_call): Likewise.
4071
4072 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4073
4074         * windows-nat.c (display_selector): Fixed format specifications
4075         for 64-bit Cygwin.
4076
4077 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4080
4081 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4082
4083         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4084         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4085         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4086         (nios2_linux_init_abi): Install it.
4087
4088 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4089
4090         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4091
4092 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4093
4094         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4095
4096 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097             Tom Tromey  <tromey@adacore.com>
4098
4099         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4100
4101 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4102
4103         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4104         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4105         method to compute the bounds of range types. Also print "[evaluated]"
4106         if the bounds' values come from a dynamic evaluation.
4107
4108 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4109
4110         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4111         whitespace when pretty printing is on.
4112
4113 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4114
4115         * ppc-linux-nat.c: Add include.
4116
4117 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4118
4119         * NEWS: Mention AArch64 Pointer Authentication.
4120
4121 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4122
4123         * arm-linux-nat.c: Add include.
4124
4125 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4126
4127         * source-cache.c (source_cache::get_source_lines): Re-read
4128         fullname after calling open_source_file.
4129
4130 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4131
4132         * NEWS: Mention TLS support for FreeBSD.
4133
4134 2019-03-25  Tom Tromey  <tromey@adacore.com>
4135
4136         * minsyms.c (BUNCH_SIZE): Update comment.
4137         (~minimal_symbol_reader): Remove old comment.
4138         (compact_minimal_symbols): Update comment.
4139         (minimal_symbol_reader::install): Remove old comment.  Update
4140         other comments.
4141
4142 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4143
4144         * s390-linux-nat.c: Add include.
4145
4146 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4147
4148         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4149         Call linux_get_hwcap.
4150         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4151         Likewise.
4152         (aarch64_linux_get_hwcap): Remove function.
4153         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4154         declaration.
4155         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4156         linux_get_hwcap.
4157         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4158         * linux-tdep.c (linux_get_hwcap): Add function.
4159         (linux_get_hwcap2): Likewise.
4160         * linux-tdep.h (linux_get_hwcap): Add declaration.
4161         (linux_get_hwcap2): Likewise.
4162         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4163         (ppc_linux_get_hwcap2): Likewise.
4164         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4165         linux_get_hwcap.
4166         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4167         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4168         (ppc_linux_nat_target::read_description): Likewise.
4169         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4170         * s390-linux-nat.c: Likewise.
4171         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4172
4173 2019-03-24  Tom Tromey  <tom@tromey.com>
4174
4175         * ada-lang.c (standard_lookup): Simplify initialization.
4176         (ada_lookup_symbol_nonlocal): Simplify return.
4177         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4178         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4179         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4180         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4181         initialization.
4182         * solib.c (solib_global_lookup): Simplify.
4183         * symtab.c (null_block_symbol): Remove.
4184         (symbol_cache_lookup): Simplify returns.
4185         (lookup_language_this): Simplify returns.
4186         (lookup_symbol_aux): Simplify return.
4187         (lookup_local_symbol): Simplify returns.
4188         (lookup_global_symbol_from_objfile): Simplify return.
4189         (lookup_symbol_in_objfile_symtabs)
4190         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4191         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4192         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4193         * cp-namespace.c (cp_lookup_bare_symbol)
4194         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4195         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4196         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4197         (cp_lookup_symbol_via_imports): Simplify initialization.
4198         (find_symbol_in_baseclass): Likewise.
4199         * symtab.h (null_block_symbol): Remove.
4200         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4201         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4202         (d_lookup_symbol_module): Likewise.
4203         (find_symbol_in_baseclass): Simplify initialization.
4204
4205 2019-03-24  Tom Tromey  <tom@tromey.com>
4206
4207         * expression.h: Don't include symtab.h.
4208         (struct block): Forward declare.
4209
4210 2019-03-24  Tom Tromey  <tom@tromey.com>
4211
4212         * c-exp.y (typebase): Remove casts.
4213         * gdbtypes.c (lookup_unsigned_typename, )
4214         (lookup_signed_typename): Remove cast.
4215         * eval.c (parse_to_comma_and_eval): Remove cast.
4216         * parse.c (write_dollar_variable): Remove cast.
4217         * block.h (struct block) <superblock>: Now const.
4218         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4219         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4220         (map_block): Make "block" const.
4221         * symfile.h (struct quick_symbol_functions)
4222         <map_matching_symbols>: Constify block argument to "callback".
4223         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4224         const.
4225         (find_pc_sect_compunit_symtab): Make "b" const.
4226         (find_symbol_at_address): Likewise.
4227         (search_symbols): Likewise.
4228         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4229         (dw2_debug_names_lookup_symbol): Likewise.
4230         (dw2_map_matching_symbols): Update.
4231         * p-valprint.c (pascal_val_print): Remove "block".
4232         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4233         (aux_add_nonlocal_symbols): Make "block" const.
4234         (resolve_subexp): Remove cast.
4235         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4236         const.
4237         (iterate_over_file_blocks): Likewise.
4238         * f-exp.y (%union) <bval>: Remove.
4239         * coffread.c (patch_opaque_types): Make "b" const.
4240         * spu-tdep.c (spu_catch_start): Make "block" const.
4241         * c-valprint.c (print_unpacked_pointer): Remove "block".
4242         * symmisc.c (dump_symtab_1): Make "b" const.
4243         (block_depth): Make "block" const.
4244         * d-exp.y (%union) <bval>: Remove.
4245         * cp-support.h (cp_lookup_rtti_type): Update.
4246         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4247         * psymtab.c (psym_lookup_symbol): Make "block" const.
4248         (maintenance_check_psymtabs): Make "b" const.
4249         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4250         (enumerate_locals, enumerate_args): Update.
4251         * python/py-symtab.c (stpy_global_block): Make "block" const.
4252         (stpy_static_block): Likewise.
4253         * inline-frame.c (block_starting_point_at): Make "new_block"
4254         const.
4255         * block.c (find_block_in_blockvector): Make return type const.
4256         (blockvector_for_pc_sect): Make "b" const.
4257         (find_block_in_blockvector): Make "b" const.
4258
4259 2019-03-23  Tom Tromey  <tom@tromey.com>
4260
4261         * varobj.c (varobj_create): Update.
4262         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4263         * printcmd.c (display_command, do_one_display): Don't reset
4264         innermost_block.
4265         * parser-defs.h (enum innermost_block_tracker_type): Move to
4266         expression.h.
4267         (innermost_block): Update comment.
4268         * parse.c (parse_exp_1): Add tracker_types parameter.
4269         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4270         tracker_types parameter.  Reset innermost_block.
4271         (parse_exp_in_context): Remove.
4272         (parse_expression_for_completion): Update.
4273         * objfiles.c (~objfile): Don't reset expression_context_block or
4274         innermost_block.
4275         * expression.h (enum innermost_block_tracker_type): Move from
4276         parser-defs.h.
4277         (parse_exp_1): Add tracker_types parameter.
4278         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4279         reset innermost_block.
4280
4281 2019-03-23  Tom Tromey  <tom@tromey.com>
4282
4283         * objfiles.h: Include bcache.h.
4284
4285 2019-03-23  Tom Tromey  <tom@tromey.com>
4286
4287         * linespec.c (get_current_search_block): Use
4288         scoped_restore_current_language.
4289         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4290
4291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4292             Jiong Wang  <jiong.wang@arm.com>
4293
4294         * aarch64-linux-tdep.c
4295         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4296         section.
4297         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4298
4299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4300             Jiong Wang  <jiong.wang@arm.com>
4301
4302         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4303         instructions.
4304         (aarch64_analyze_prologue_test): Add PACIASP test.
4305         (aarch64_prologue_prev_register): Unmask PC value.
4306
4307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4308             Jiong Wang  <jiong.wang@arm.com>
4309
4310         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4311         (aarch64_dwarf2_prev_register): Unmask PC value.
4312         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4313         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4314         DW_CFA_AARCH64_negate_ra_state.
4315         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4316
4317 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4318             Jiong Wang  <jiong.wang@arm.com>
4319
4320         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4321         registers.
4322         (aarch64_pseudo_register_name): Likewise.
4323         (aarch64_pseudo_register_type): Likewise.
4324         (aarch64_pseudo_register_reggroup_p): Likewise.
4325         (aarch64_gdbarch_init): Add pauth registers.
4326         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4327         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4328         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4329         (struct gdbarch_tdep): Add regnum for ra_state.
4330
4331 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4332             Jiong Wang  <jiong.wang@arm.com>
4333
4334         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4335
4336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4337             Jiong Wang  <jiong.wang@arm.com>
4338
4339         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4340         function.
4341         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4342         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4343         (aarch64_gdbarch_init): Add puth registers.
4344         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4345         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4346         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4347
4348 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4349             Jiong Wang  <jiong.wang@arm.com>
4350
4351         * aarch64-linux-nat.c
4352         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4353         * aarch64-linux-tdep.c
4354         (aarch64_linux_core_read_description): Likewise.
4355         (aarch64_linux_get_hwcap): New function.
4356         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4357         (aarch64_linux_get_hwcap): New declaration.
4358
4359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4360             Jiong Wang  <jiong.wang@arm.com>
4361
4362         * aarch64-linux-nat.c
4363         (aarch64_linux_nat_target::read_description): Add pauth param.
4364         * aarch64-linux-tdep.c
4365         (aarch64_linux_core_read_description): Likewise.
4366         * aarch64-tdep.c (struct target_desc): Add in pauth.
4367         (aarch64_read_description): Add pauth param.
4368         (aarch64_gdbarch_init): Likewise.
4369         * aarch64-tdep.h (aarch64_read_description): Likewise.
4370         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4371         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4372         * features/Makefile: Add new files.
4373         * features/aarch64-pauth.c: New file.
4374         * features/aarch64-pauth.xml: New file.
4375
4376 2019-03-20  Tom Tromey  <tromey@adacore.com>
4377
4378         * infrun.c (handle_inferior_event): Rename from
4379         handle_inferior_event_1.  Create a scoped_value_mark.
4380         (handle_inferior_event): Remove.
4381
4382 2019-03-19  Tom Tromey  <tromey@adacore.com>
4383
4384         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4385         * infrun.h (print_stop_event): Add "displays" parameter.
4386         * infrun.c (print_stop_event): Add "displays" parameter.
4387
4388 2019-03-19  Pedro Alves  <palves@redhat.com>
4389
4390         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4391         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4392         to -1.  Fix TABs vs spaces.
4393         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4394         * tui/tui-out.h (tui_ui_out) Add intro comments.
4395         <m_line, m_start_of_line>: In-class initialize, and add describing
4396         comment.
4397
4398 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4399
4400         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4401         variable names.
4402         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4403
4404 2019-03-18  Pedro Alves  <palves@redhat.com>
4405             Eli Zaretskii <eliz@gnu.org>
4406
4407         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4408         m_line and m_start_of_line.
4409
4410 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4411
4412         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4413         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4414         it returns a newline.  This fixes a regression in TU mode, whereby
4415         the next line is output on the same screen line as the user input.
4416
4417 2019-03-18  Tom Tromey  <tromey@adacore.com>
4418
4419         * minsyms.c (minimal_symbol_reader::install): Remove call to
4420         obstack_blank.
4421
4422 2019-03-18  Pedro Alves  <palves@redhat.com>
4423
4424         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4425         New globals.
4426         (apply_style): New, factored out from ...
4427         (apply_ansi_escape): ... this.  Handle reverse video mode.
4428         (tui_set_reverse_mode): New function.
4429         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4430         * tui/tui-winsource.c (tui_show_source_line): Use
4431         tui_set_reverse_mode instead of setting A_STANDOUT.
4432         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4433         New setter methods.
4434
4435 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4436
4437         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4438         Handle tabs.
4439
4440 2019-03-18  Tom Tromey  <tromey@adacore.com>
4441
4442         * ada-lang.c (empty_array): Add "high" parameter.
4443         (ada_evaluate_subexp): Update.
4444
4445 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4446
4447         * unittests/string_view-selftests.c: Define
4448         _initialize_string_view_selftests unconditionally.
4449
4450 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4451
4452         PR gdb/24350
4453         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4454
4455 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4456
4457         PR gdb/24351
4458         * windows-nat.c (display_selector): Fix format specifiers.
4459
4460 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4461
4462         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4463         tui_refill_source_window instead of tui_refresh_win, to update the
4464         current execution line.  This fixes redisplay of the current line
4465         when stepping through the code with "next" or "step".
4466
4467 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4468
4469         * source-cache.c (source_cache::get_source_lines): Call
4470         find_source_lines to initialize s->nlines.  This fixes vertical
4471         scrolling of TUI source window when the DOWN arrow is pressed.
4472
4473 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4474
4475         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4476         linux-thread-db.c (_initialize_thread_db): Likewise.
4477
4478 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4479
4480         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4481         wclrtoeol in tui_show_source_line".  This reverts changes made in
4482         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4483
4484 2019-03-15  Tom Tromey  <tom@tromey.com>
4485
4486         * symtab.h (struct minimal_symbol): Derive from
4487         general_symbol_info.
4488         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4489         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4490         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4491         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4492         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4493         (MSYMBOL_SEARCH_NAME): Update.
4494         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4495         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4496         * minsyms.c (minimal_symbol_reader::record_full): Update.
4497
4498 2019-03-15  Tom Tromey  <tom@tromey.com>
4499
4500         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4501
4502 2019-03-15  Tom Tromey  <tom@tromey.com>
4503
4504         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4505         unique_xmalloc_ptr.
4506         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4507         Update.
4508         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4509         (build_minimal_symbol_hash_tables)
4510         (minimal_symbol_reader::install): Update.
4511
4512 2019-03-15  Tom Tromey  <tom@tromey.com>
4513
4514         * symtab.c (create_demangled_names_hash): Update.
4515         (symbol_set_names): Update.
4516         * objfiles.h (struct objfile_per_bfd_storage)
4517         <demangled_names_hash>: Now an htab_up.
4518         * objfiles.c (objfile_per_bfd_storage): Simplify.
4519
4520 2019-03-15  Tom Tromey  <tom@tromey.com>
4521
4522         * objfiles.h (struct objfile_per_bfd_storage): Declare
4523         destructor.
4524         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4525         New.
4526         (get_objfile_bfd_data): Use new.  Don't initialize
4527         language_of_main.
4528         (free_objfile_per_bfd_storage): Remove.
4529         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4530
4531 2019-03-15  Tom Tromey  <tom@tromey.com>
4532
4533         * symfile.c (reread_symbols): Update.
4534         * objfiles.c (objfile::objfile): Update.
4535         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4536         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4537         comment.
4538         (minimal_symbol_reader::install): Update.
4539         (terminate_minimal_symbol_table): Remove.
4540         * jit.c (jit_object_close_impl): Update.
4541
4542 2019-03-15  Tom Tromey  <tom@tromey.com>
4543
4544         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4545         initializations.
4546
4547 2019-03-15  Tom Tromey  <tom@tromey.com>
4548
4549         * objfiles.h (struct objfile_per_bfd_storage)
4550         <demangled_hash_languages>: Now a bitset.
4551         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4552         (lookup_minimal_symbol): Update.
4553
4554 2019-03-15  Tom Tromey  <tom@tromey.com>
4555
4556         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4557         Don't return the symbol.
4558         * coffread.c (record_minimal_symbol): Use record_full.
4559
4560 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4561
4562         The MS-Windows port of ncurses fails to switch to a color pair if
4563         one or both of the colors are the implicit default colors.  This
4564         change records the default colors when TUI is initialized, and
4565         then specifies them explicitly when a color pair uses the default
4566         colors.  This allows color styling in TUI mode on MS-Windows.
4567
4568         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4569         ncurses_norm_attr.
4570         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4571         colors in ncurses_norm_attr.
4572         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4573         "none", replace it with the default color recorded in
4574         ncurses_norm_attr.
4575
4576 2019-03-14  Tom Tromey  <tromey@adacore.com>
4577
4578         * source-cache.h (class source_cache) <get_source_lines>: Return
4579         std::string.
4580         * source-cache.c (source_cache::extract_lines): Handle case where
4581         first_pos==npos.  Return std::string.
4582         (source_cache::get_source_lines): Update.
4583
4584 2019-03-14  Tom Tromey  <tromey@adacore.com>
4585
4586         * NEWS: Add item for "style sources" commands.
4587         * source-cache.c (source_cache::get_source_lines): Check
4588         source_styling.
4589         * cli/cli-style.c (source_styling): New global.
4590         (_initialize_cli_style): Add "style sources" commands.
4591         (show_style_sources): New function.
4592         * cli/cli-style.h (source_styling): Declare.
4593
4594 2019-03-14  Pedro Alves  <palves@redhat.com>
4595             Tom Tromey  <tromey@adacore.com>
4596
4597         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4598         * tui/tui-winsource.c (tui_refill_source_window): New function,
4599         from...
4600         (tui_horizontal_source_scroll): ... here.  Move some logic.
4601         * cli/cli-style.c (set_style_enabled): Notify new observable.
4602         * tui/tui-hooks.c (tui_redisplay_source): New function.
4603         (tui_attach_detach_observers): Attach or detach
4604         tui_redisplay_source.
4605         * observable.h (source_styling_changed): New observable.
4606         * observable.c: Define source_styling_changed observable.
4607
4608 2019-03-13  Tom Tromey  <tromey@adacore.com>
4609
4610         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4611         (i386_gnu_nat_target::store_registers): Update.
4612         * target-debug.h (target_debug_print_std_string): New macro.
4613         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4614         * windows-tdep.c (display_one_tib): Update.
4615         * tui/tui-stack.c (tui_make_status_line): Update.
4616         * top.c (print_inferior_quit_action): Update.
4617         * thread.c (thr_try_catch_cmd): Update.
4618         (add_thread_with_info): Update.
4619         (thread_target_id_str): Update.
4620         (thr_try_catch_cmd): Update.
4621         (thread_command): Update.
4622         (thread_find_command): Update.
4623         * record-btrace.c (record_btrace_target::info_record)
4624         (record_btrace_resume_thread, record_btrace_target::resume)
4625         (record_btrace_cancel_resume, record_btrace_step_thread)
4626         (record_btrace_target::wait, record_btrace_target::wait)
4627         (record_btrace_target::wait, record_btrace_target::stop): Update.
4628         * progspace.c (print_program_space): Update.
4629         * process-stratum-target.c
4630         (process_stratum_target::thread_address_space): Update.
4631         * linux-fork.c (linux_fork_mourn_inferior)
4632         (detach_checkpoint_command, info_checkpoints_command)
4633         (linux_fork_context): Update.
4634         (linux_fork_detach): Update.
4635         (class scoped_switch_fork_info): Update.
4636         (delete_checkpoint_command): Update.
4637         * infrun.c (follow_fork_inferior): Update.
4638         (follow_fork_inferior): Update.
4639         (proceed_after_vfork_done): Update.
4640         (handle_vfork_child_exec_or_exit): Update.
4641         (follow_exec): Update.
4642         (displaced_step_prepare_throw): Update.
4643         (displaced_step_restore): Update.
4644         (start_step_over): Update.
4645         (resume_1): Update.
4646         (clear_proceed_status_thread): Update.
4647         (proceed): Update.
4648         (print_target_wait_results): Update.
4649         (do_target_wait): Update.
4650         (context_switch): Update.
4651         (stop_all_threads): Update.
4652         (restart_threads): Update.
4653         (finish_step_over): Update.
4654         (handle_signal_stop): Update.
4655         (switch_back_to_stepped_thread): Update.
4656         (keep_going_pass_signal): Update.
4657         (print_exited_reason): Update.
4658         (normal_stop): Update.
4659         * inferior.c (inferior_pid_to_str): Change return type.
4660         (print_selected_inferior): Update.
4661         (add_inferior): Update.
4662         (detach_inferior): Update.
4663         * dummy-frame.c (fprint_dummy_frames): Update.
4664         * dcache.c (dcache_info_1): Update.
4665         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4666         (btrace_fetch, btrace_clear): Update.
4667         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4668         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4669         type.
4670         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4671         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4672         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4673         * gdbarch.c, gdbarch.h: Rebuild.
4674         * gdbarch.sh (core_pid_to_str): Change return type.
4675         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4676         return type.
4677         (windows_nat_target::pid_to_str): Change return type.
4678         (windows_delete_thread): Update.
4679         (windows_nat_target::attach): Update.
4680         (windows_nat_target::files_info): Update.
4681         * target-delegates.c: Rebuild.
4682         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4683         return type.
4684         (sol_thread_target::pid_to_str): Change return type.
4685         * remote.c (class remote_target) <pid_to_str>: Change return
4686         type.
4687         (remote_target::pid_to_str): Change return type.
4688         (extended_remote_target::attach, remote_target::remote_stop_ns)
4689         (remote_target::remote_notif_remove_queued_reply)
4690         (remote_target::push_stop_reply, remote_target::disable_btrace):
4691         Update.
4692         (extended_remote_target::attach): Update.
4693         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4694         type.
4695         (gdbsim_target::pid_to_str): Change return type.
4696         * ravenscar-thread.c (struct ravenscar_thread_target)
4697         <pid_to_str>: Change return type.
4698         (ravenscar_thread_target::pid_to_str): Change return type.
4699         * procfs.c (class procfs_target) <pid_to_str>: Change return
4700         type.
4701         (procfs_target::pid_to_str): Change return type.
4702         (procfs_target::attach): Update.
4703         (procfs_target::detach): Update.
4704         (procfs_target::fetch_registers): Update.
4705         (procfs_target::store_registers): Update.
4706         (procfs_target::wait): Update.
4707         (procfs_target::files_info): Update.
4708         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4709         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4710         return type.
4711         (nto_procfs_target::pid_to_str): Change return type.
4712         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4713         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4714         return type.
4715         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4716         (exit_lwp): Update.
4717         (attach_proc_task_lwp_callback, get_detach_signal)
4718         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4719         (linux_nat_target::resume, wait_lwp, stop_callback)
4720         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4721         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4722         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4723         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4724         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4725         type.
4726         (inf_ptrace_target::attach): Update.
4727         (inf_ptrace_target::files_info): Update.
4728         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4729         type.
4730         (go32_nat_target::pid_to_str): Change return type.
4731         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4732         (gnu_nat_target::wait): Update.
4733         (gnu_nat_target::wait): Update.
4734         (gnu_nat_target::resume): Update.
4735         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4736         (fbsd_nat_target::wait): Update.
4737         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4738         type.
4739         (darwin_nat_target::attach): Update.
4740         * corelow.c (class core_target) <pid_to_str>: Change return type.
4741         (core_target::pid_to_str): Change return type.
4742         * target.c (normal_pid_to_str): Change return type.
4743         (default_pid_to_str): Likewise.
4744         (target_pid_to_str): Change return type.
4745         (target_translate_tls_address): Update.
4746         (target_announce_detach): Update.
4747         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4748         return type.
4749         (bsd_uthread_target::pid_to_str): Change return type.
4750         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4751         type.
4752         (bsd_kvm_target::pid_to_str): Change return type.
4753         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4754         return type.
4755         (aix_thread_target::pid_to_str): Change return type.
4756         * target.h (struct target_ops) <pid_to_str>: Change return type.
4757         (target_pid_to_str, normal_pid_to_str): Likewise.
4758         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4759         type.
4760         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4761         type.
4762         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4763         return type.
4764         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4765         type.
4766         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4767         type.
4768         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4769         return type.
4770
4771 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4772
4773         * NEWS: Mention that the new default MI version is 3.  Mention
4774         changes to the output of commands and events that deal with
4775         multi-location breakpoints.
4776         * breakpoint.c: Include "mi/mi-out.h".
4777         (print_one_breakpoint): Change output syntax if using MI version
4778         >= 3.
4779         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4780         New.
4781         (mi_multi_location_breakpoint_output_fixed): New.
4782         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4783         (mi_cmd_fix_multi_location_breakpoint_output): New.
4784         (mi_multi_location_breakpoint_output_fixed): New.
4785         * mi/mi-cmds.c (mi_cmds): Register command
4786         -fix-multi-location-breakpoint-output.
4787         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4788         interpreter "mi".
4789
4790 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4791
4792         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4793         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4794         instantiate mi_ui_out based on interpreter name.
4795         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4796         * mi/mi-main.c (mi_load_progress): Likewise.
4797
4798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4799
4800         * NEWS: Combine separate "New targets" sections for 8.3.
4801
4802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4803
4804         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4805         (ppcfbsd_init_abi): Install gdbarch
4806         "fetch_tls_load_module_address" and "get_thread_local_address"
4807         methods.
4808
4809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4810
4811         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4812         (riscv_fbsd_init_abi): Install gdbarch
4813         "fetch_tls_load_module_address" and "get_thread_local_address"
4814         methods.
4815
4816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4817
4818         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4819         (i386fbsd_init_abi): Install gdbarch
4820         "fetch_tls_load_module_address" and "get_thread_local_address"
4821         methods.
4822
4823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4824
4825         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4826         (amd64fbsd_init_abi): Install gdbarch
4827         "fetch_tls_load_module_address" and "get_thread_local_address"
4828         methods.
4829
4830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4831
4832         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4833         (struct fbsd_pspace_data): New type.
4834         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4835         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4836         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4837         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4838         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4839
4840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4841
4842         * gdbtypes.c (lookup_struct_elt): New function.
4843         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4844         * gdbtypes.h (struct struct_elt): New type.
4845         (lookup_struct_elt): New prototype.
4846
4847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4848
4849         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4850         remove disabled code block.
4851
4852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4853
4854         * gdbarch.sh (get_thread_local_address): New method.
4855         * gdbarch.h, gdbarch.c: Regenerate.
4856         * target.c (target_translate_tls_address): Use
4857         gdbarch_get_thread_local_address if present instead of
4858         target::get_thread_local_address.
4859
4860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4861
4862         * target.h (target::get_thread_local_address): Update comment.
4863
4864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4865
4866         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4867         objfile->separate_debug_objfile_backlink if not NULL.
4868
4869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4870
4871         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4872         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4873         (amd64bsd_store_inferior_registers): Likewise.
4874         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4875         Enable segment base registers.
4876         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4877         PT_GETFSBASE and PT_GETGSBASE.
4878         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4879         PT_SETGSBASE.
4880         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4881         segment base registers.
4882         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4883
4884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4885
4886         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4887         Update calls to i386_target_description to add 'segments'
4888         parameter.
4889         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4890         add segment base registers.
4891         * arch/i386.c (i386_create_target_description): Add 'segments'
4892         parameter to enable segment base registers.
4893         * arch/i386.h (i386_create_target_description): Likewise.
4894         * features/i386/32bit-segments.xml: New file.
4895         * features/i386/32bit-segments.c: Generate.
4896         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4897         call to i386_target_description to add 'segments' parameter.
4898         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4899         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4900         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4901         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4902         if feature is present.
4903         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4904         Add 'segments' parameter to call to i386_target_description.
4905         (i386_target_description): Add 'segments' parameter to enable
4906         segment base registers.
4907         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4908         to call to i386_target_description.
4909         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4910         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4911         Define I386_NUM_REGS.
4912         (i386_target_description): Add 'segments' parameter to enable
4913         segment base registers.
4914
4915 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4916
4917         PR/24325
4918         * source-cache.c: #undef open and close, to avoid unresolved
4919         externals during linking.
4920
4921 2019-03-12  Tom Tromey  <tromey@adacore.com>
4922
4923         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4924         const.  Add initializers.
4925         (_initialize_remote): Don't initialize ptid globals.
4926
4927 2019-03-12  Pedro Alves  <palves@redhat.com>
4928
4929         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4930
4931 2019-03-12  Pedro Alves  <palves@redhat.com>
4932
4933         * cp-name-parser.y (main): Remove unused 'len' variable.
4934
4935 2019-03-12  Tom Tromey  <tromey@adacore.com>
4936
4937         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4938         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4939
4940 2019-03-12  Tom Tromey  <tromey@adacore.com>
4941
4942         * linux-nat.c (iterate_over_lwps): Update.
4943         (stop_callback): Remove parameter.
4944         (stop_wait_callback, detach_callback, resume_set_callback)
4945         (select_singlestep_lwp_callback, set_ignore_sigint)
4946         (status_callback, resumed_callback, resume_clear_callback)
4947         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4948         data parameter.
4949         (linux_nat_target::detach, linux_nat_target::resume)
4950         (linux_stop_and_wait_all_lwps, select_event_lwp)
4951         (linux_nat_filter_event, linux_nat_wait_1)
4952         (linux_nat_target::kill, linux_nat_target::stop)
4953         (linux_nat_target::stop): Update.
4954         (linux_nat_resume_callback): Change type.
4955         (resume_stopped_resumed_lwps, count_events_callback)
4956         (select_event_lwp_callback): Likewise.
4957         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4958         * arm-linux-nat.c (struct update_registers_data): Remove.
4959         (update_registers_callback): Change type.
4960         (arm_linux_insert_hw_breakpoint1): Update.
4961         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4962         parameter.
4963         (x86_linux_dr_set_addr): Update.
4964         (x86_linux_dr_set_control): Update.
4965         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4966         (iterate_over_lwps): Use gdb::function_view.
4967         * nat/aarch64-linux-hw-point.c (struct
4968         aarch64_dr_update_callback_param): Remove.
4969         (debug_reg_change_callback): Change type.
4970         (aarch64_notify_debug_reg_change): Update.
4971         * s390-linux-nat.c (s390_refresh_per_info): Update.
4972
4973 2019-03-11  Tom Tromey  <tromey@adacore.com>
4974
4975         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4976         redundant assignment to "this_cu".
4977
4978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4979
4980         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4981
4982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4983
4984         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4985         from...
4986         (rank_one_type): ... this.
4987
4988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4989
4990         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4991         from...
4992         (rank_one_type): ... this.
4993
4994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4995
4996         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4997         from...
4998         (rank_one_type): ... this.
4999
5000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5001
5002         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5003         from...
5004         (rank_one_type): ... this.
5005
5006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5007
5008         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5009         from...
5010         (rank_one_type): ... this.
5011
5012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5013
5014         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5015         from...
5016         (rank_one_type): ... this.
5017
5018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5019
5020         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5021         from...
5022         (rank_one_type): ... this.
5023
5024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5025
5026         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5027         from...
5028         (rank_one_type): ... this.
5029
5030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5031
5032         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5033         from...
5034         (rank_one_type): ... this.
5035
5036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5037
5038         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5039         from...
5040         (rank_one_type): ... this.
5041
5042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5043
5044         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5045         from...
5046         (rank_one_type): ... this.
5047
5048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5049
5050         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5051         from...
5052         (rank_one_type): ... this.
5053
5054 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5055
5056         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5057         inferior-events' shows the example events.
5058
5059 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5060
5061         Support styling on native MS-Windows console
5062
5063         PR/24315
5064         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5065         on MS-Windows if $TERM is not defined.
5066
5067         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5068
5069         * posix-hdep.c (gdb_console_fputs):
5070         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5071         functions.
5072         * ui-file.h (gdb_console_fputs): Add prototype.
5073
5074         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5075         back to fputs only if the former returns zero.
5076
5077 2019-03-07  Tom Tromey  <tom@tromey.com>
5078
5079         * symmisc.c (print_symbol_bcache_statistics): Update.
5080         (print_objfile_statistics): Update.
5081         * symfile.c (allocate_symtab): Update.
5082         * stabsread.c: Don't include bcache.h.
5083         * psymtab.h (struct psymbol_bcache): Don't declare.
5084         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5085         (psymbol_bcache_init, psymbol_bcache_free)
5086         (psymbol_bcache_get_bcache): Don't declare.
5087         * psymtab.c (struct psymbol_bcache): Remove.
5088         (psymtab_storage::psymtab_storage): Update.
5089         (psymtab_storage::~psymtab_storage): Update.
5090         (psymbol_bcache_init, psymbol_bcache_free)
5091         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5092         (add_psymbol_to_bcache): Update.
5093         (allocate_psymtab): Update.
5094         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5095         macro_cache>: No longer pointers.
5096         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5097         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5098         * macrotab.c (macro_bcache): Update.
5099         * macroexp.c: Don't include bcache.h.
5100         * gdbtypes.c (check_types_worklist): Update.
5101         (types_deeply_equal): Remove TRY/CATCH.  Update.
5102         * elfread.c (elf_symtab_read): Update.
5103         * dwarf2read.c: Don't include bcache.h.
5104         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5105         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5106         (print_bcache_statistics, bcache_memory_used): Don't declare.
5107         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5108         methods.  Rename all data members.
5109         * bcache.c (struct bcache): Move to bcache.h.
5110         (bcache::expand_hash_table): Rename from expand_hash_table.
5111         (bcache): Remove.
5112         (bcache::insert): Rename from bcache_full.
5113         (bcache::compare): Rename from bcache_compare.
5114         (bcache_xmalloc): Remove.
5115         (bcache::~bcache): Rename from bcache_xfree.
5116         (bcache::print_statistics): Rename from print_bcache_statistics.
5117         (bcache::memory_used): Rename from bcache_memory_used.
5118
5119 2019-03-07  Pedro Alves  <palves@redhat.com>
5120
5121         * infrun.c (normal_stop): Also check for
5122         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5123
5124 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * f-lang.c (value_from_host_double): Moved to...
5127         * value.c (value_from_host_double): ...here.
5128         * value.h (value_from_host_double): Declare.
5129         * guile/scm-math.c (vlscm_convert_typed_number): Use
5130         value_from_host_double.
5131         (vlscm_convert_number): Likewise.
5132         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5133         * python/py-value.c (convert_value_from_python): Likewise.
5134
5135 2019-03-06  Tom Tromey  <tom@tromey.com>
5136
5137         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5138
5139 2019-03-06  Tom Tromey  <tom@tromey.com>
5140
5141         * utils.h (free_current_contents): Don't declare.
5142         * utils.c (free_current_contents): Remove.
5143
5144 2019-03-06  Tom Tromey  <tom@tromey.com>
5145
5146         * top.c (quit_force): Update.
5147         * main.c (captured_command_loop): Update.
5148         * common/new-op.c (operator new): Update.
5149         * common/common-exceptions.c (struct catcher)
5150         <save_cleanup_chain>: Remove member.
5151         (exceptions_state_mc_init): Update.
5152         (exception_try_scope_entry): Return nullptr.
5153         (exception_try_scope_exit, exception_rethrow)
5154         (throw_exception_sjlj, throw_exception_cxx): Update.
5155         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5156         (all_cleanups, do_cleanups, discard_cleanups)
5157         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5158         (restore_cleanups, restore_final_cleanups): Don't declare.
5159         (do_final_cleanups): Remove parameter.
5160         * common/cleanups.c (cleanup_chain, make_cleanup)
5161         (make_cleanup_dtor, all_cleanups, do_cleanups)
5162         (discard_my_cleanups, discard_cleanups)
5163         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5164         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5165         (null_cleanup): Remove.
5166         (do_final_cleanups): Remove parameter.
5167
5168 2019-03-06  Tom Tromey  <tom@tromey.com>
5169
5170         * remote.c (remote_target::remote_parse_stop_reply): Use
5171         unique_xmalloc_ptr.
5172
5173 2019-03-06  Tom Tromey  <tom@tromey.com>
5174
5175         * stabsread.c (struct stabs_field_info): Rename from field_info.
5176         <list, fnlist>: Add initializers.
5177         <obstack>: New member.
5178         (read_member_functions, read_struct_fields, read_baseclasses):
5179         Allocate on obstack.  Don't use cleanups.
5180         (read_one_struct_field, read_member_functions, read_struct_fields)
5181         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5182         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5183         (read_struct_type): Update.
5184
5185 2019-03-06  Tom Tromey  <tom@tromey.com>
5186
5187         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5188         * common/filestuff.h (make_cleanup_close): Don't declare.
5189         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5190         Remove.
5191
5192 2019-03-06  Tom Tromey  <tom@tromey.com>
5193
5194         * solib-aix.c: Use make_scope_exit.
5195
5196 2019-03-06  Tom Tromey  <tom@tromey.com>
5197
5198         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5199         Use make_scope_exit.
5200
5201 2019-03-06  Tom Tromey  <tom@tromey.com>
5202
5203         * solib-svr4.c (disable_probes_interface): Remove parameter.
5204         (svr4_handle_solib_event): Use make_scope_exit.
5205
5206 2019-03-06  Tom Tromey  <tom@tromey.com>
5207
5208         * remote.c (struct stop_reply_deleter): Remove.
5209         (stop_reply_up): Update.
5210         (struct stop_reply): Derive from notif_event.  Don't typedef.
5211         <regcache>: Now a std::vector.
5212         (stop_reply_xfree): Remove.
5213         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5214         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5215         (remote_target::discard_pending_stop_replies): Use delete.
5216         (remote_target::remote_parse_stop_reply): Update.
5217         (remote_target::process_stop_reply): Update.
5218         * remote-notif.h (struct notif_event): Add virtual destructor.
5219         Remove "dtr" member.
5220         (struct notif_client) <alloc_event>: Return a unique_ptr.
5221         (notif_event_xfree): Don't declare.
5222         (notif_event_up): New typedef.
5223         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5224         (notif_event_xfree, do_notif_event_xfree): Remove.
5225         (remote_notif_state_xfree): Update.
5226
5227 2019-03-06  Tom Tromey  <tom@tromey.com>
5228
5229         * infrun.c (displaced_step_clear_cleanup): Now a
5230         forward_scope_exit type.
5231         (displaced_step_prepare_throw): Update.
5232         (displaced_step_fixup): Update.
5233
5234 2019-03-06  Tom Tromey  <tom@tromey.com>
5235
5236         * inferior.h (class inferior): Update comment.
5237         * gdbthread.h (class thread_info): Update comment.
5238
5239 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5240             Tom Tromey  <tom@tromey.com>
5241
5242         * stabsread.h (struct stab_section_list): Remove.
5243         (coffstab_build_psymtabs): Update.
5244         * dbxread.c (symbuf_sections): Now a std::vector.
5245         (sect_idx): New global.
5246         (fill_symbuf): Update.
5247         (coffstab_build_psymtabs): Change type of stabsects parameter.
5248         Update.
5249         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5250         std::vector.
5251         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5252         (coff_locate_sections): Update.
5253         (coff_symfile_read): Remove cleanups.  Update.
5254         (init_stringtab): Add storage parameter.
5255         (free_stringtab, free_stringtab_cleanup): Remove.
5256         (init_lineno): Add storage parameter.
5257         (free_linetab, free_linetab_cleanup): Remove.
5258
5259 2019-03-06  Pedro Alves  <palves@redhat.com>
5260
5261         * linux-fork.c (fork_info::clobber_regs): Delete.
5262         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5263         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5264         comment.  Adjust.
5265         (scoped_switch_fork_info::scoped_switch_fork_info)
5266         (checkpoint_command, linux_fork_context): Adjust
5267         fork_save_infrun_state calls.
5268
5269 2019-03-06  Pedro Alves  <palves@redhat.com>
5270
5271         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5272         (inf_has_multiple_threads): Return 'bool' and rewrite using
5273         inferior_info::threads().
5274
5275 2019-03-06  Pedro Alves  <palves@redhat.com>
5276
5277         * linux-fork.c: Include <list>.
5278         (fork_list): Now a std::list instance.
5279         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5280         (forks_exist_p, find_last_fork): Adjust.
5281         (new_fork): Delete.
5282         (one_fork_p): New.
5283         (add_fork): Adjust.
5284         (free_fork): Delete, folded into fork_info::~fork_info().
5285         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5286         Adjust.
5287         (init_fork_list): Delete.
5288         (linux_fork_killall, linux_fork_mourn_inferior)
5289         (linux_fork_detach, info_checkpoints_command): Adjust.
5290         (_initialize_linux_fork): No longer call init_fork_list.
5291
5292 2019-03-06  Pedro Alves  <palves@redhat.com>
5293
5294         * linux-fork.c (new_fork): New, split out of ...
5295         (add_fork): ... this.  Return void.  Move "first fork" special
5296         case from here, to ...
5297         (checkpoint_command): ... here.
5298         * linux-linux.h (add_fork): Return void.
5299
5300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5303
5304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5305             Chris January  <chris.january@arm.com>
5306             David Lecomber  <david.lecomber@arm.com>
5307
5308         * f-exp.y: New token, UNOP_INTRINSIC.
5309         (exp): New pattern using UNOP_INTRINSIC token.
5310         (f77_keywords): Add 'abs' keyword.
5311         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5312         (value_from_host_double): New function.
5313         (evaluate_subexp_f): Support UNOP_ABS.
5314
5315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5316
5317         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5318         types.
5319
5320 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5321
5322         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5323         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5324         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5325
5326 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5329
5330 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5331             Chris January  <chris.january@arm.com>
5332
5333         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5334         * f-exp.y: Define 'KIND' token.
5335         (exp): New pattern for KIND expressions.
5336         (ptype): Handle types with a kind extension.
5337         (direct_abs_decl): Extend to spot kind extensions.
5338         (f77_keywords): Add 'kind' to the list.
5339         (push_kind_type): New function.
5340         (convert_to_kind_type): New function.
5341         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5342         * parse.c (operator_length_standard): Likewise.
5343         * parser-defs.h (enum type_pieces): Add tp_kind.
5344         * std-operator.def: Add UNOP_KIND.
5345
5346 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * f-exp.y (f_parse): Set yydebug.
5349
5350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5351
5352         * f-lang.c (evaluate_subexp_f): New function.
5353         (exp_descriptor_f): New global.
5354         (f_language_defn): Use exp_descriptor_f instead of
5355         exp_descriptor_standard.
5356
5357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5358
5359         * f-exp.y (struct token): Add comments.
5360         (dot_ops): Remove uppercase versions and the end marker.
5361         (f77_keywords): Likewise.
5362         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5363         entries in the dot_ops array are case insensitive, and use
5364         strncasecmp to compare strings.  Also some whitespace cleanup in
5365         this area.  Similar for the f77_keywords array, except entries in
5366         this list might be case sensitive.
5367
5368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * f-exp.y (struct f77_boolean_val): Add comments.
5371         (boolean_values): Remove uppercase versions, and end marker.
5372         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5373         and use strncasecmp to achieve case insensitivity.  Additionally,
5374         perform whitespace cleanup around this code.
5375
5376 2019-03-06  Tom Tromey  <tromey@adacore.com>
5377
5378         * remote-sim.c (gdbsim_target_open): Use result of
5379         gdb_argv::release.
5380
5381 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5382         Dirk Schubert  <dirk.schubert@arm.com>
5383         Chris January  <chris.january@arm.com>
5384
5385         * eval.c (evaluate_subexp_standard): Call Fortran argument
5386         wrapping logic.
5387         * f-lang.c (struct value): A value which can be passed into a
5388         Fortran function call.
5389         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5390         where appropriate.
5391         (struct type): Value ready for a Fortran function call.
5392         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5393         is needed.
5394         * f-lang.h (fortran_argument_convert): Declaration.
5395         (fortran_preserve_arg_pointer): Declaration.
5396         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5397
5398 2019-03-05  Tom Tromey  <tromey@adacore.com>
5399
5400         * python/py-prettyprint.c (print_string_repr): Remove #if.
5401         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5402
5403 2019-03-05  Tom Tromey  <tromey@adacore.com>
5404
5405         * target.c (the_dummy_target): Move later.  Change type to
5406         "dummy_target".
5407         (initialize_targets): Don't initialize the_dummy_target.
5408
5409 2019-03-05  Tom Tromey  <tromey@adacore.com>
5410
5411         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5412         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5413
5414 2019-03-05  Tom Tromey  <tromey@adacore.com>
5415
5416         * windows-nat.c (windows_nat_target::attach)
5417         (windows_nat_target::detach): Don't call gdb_flush.
5418         * valprint.c (generic_val_print, val_print, val_print_string):
5419         Don't call gdb_flush.
5420         * utils.c (defaulted_query): Don't call gdb_flush.
5421         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5422         * target.c (target_announce_detach): Don't call gdb_flush.
5423         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5424         * remote.c (extended_remote_target::attach): Don't call
5425         gdb_flush.
5426         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5427         * printcmd.c (do_examine): Don't call gdb_flush.
5428         (info_display_command): Don't call gdb_flush.
5429         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5430         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5431         * memattr.c (info_mem_command): Don't call gdb_flush.
5432         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5433         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5434         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5435         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5436         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5437         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5438         (gnu_nat_target::detach): Don't call gdb_flush.
5439         * f-valprint.c (f_val_print): Don't call gdb_flush.
5440         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5441         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5442         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5443         gdb_flush.
5444         * c-valprint.c (c_val_print): Don't call gdb_flush.
5445         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5446
5447 2019-03-05  Tom Tromey  <tromey@adacore.com>
5448
5449         * varobj.c (update_dynamic_varobj_children): Update.
5450         (install_default_visualizer): Use reset, not release.
5451         * value.c (set_internalvar): Update.
5452         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5453         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5454         ATTRIBUTE_UNUSED_RESULT.
5455
5456 2019-03-05  Tom Tromey  <tromey@adacore.com>
5457
5458         * remote.c (class scoped_remote_fd) <release>: Add
5459         ATTRIBUTE_UNUSED_RESULT.
5460
5461 2019-03-05  Tom Tromey  <tromey@adacore.com>
5462
5463         * macroexp.c (struct macro_buffer) <release>: Add
5464         ATTRIBUTE_UNUSED_RESULT.
5465
5466 2019-03-05  Tom Tromey  <tromey@adacore.com>
5467
5468         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5469         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5470         ATTRIBUTE_UNUSED_RESULT.
5471
5472 2019-03-05  Tom Tromey  <tromey@adacore.com>
5473
5474         * common/scoped_fd.h (class scoped_fd) <release>: Add
5475         ATTRIBUTE_UNUSED_RESULT.
5476
5477 2019-03-05  Tom Tromey  <tromey@adacore.com>
5478
5479         * parser-defs.h (struct parser_state) <release>: Add
5480         ATTRIBUTE_UNUSED_RESULT.
5481
5482 2019-03-05  Tom Tromey  <tromey@adacore.com>
5483
5484         * utils.h (class gdb_argv) <release>: Add
5485         ATTRIBUTE_UNUSED_RESULT.
5486         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5487
5488 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5489
5490         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5491         for-loop range, to avoid compiler warnings.
5492
5493         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5494         avoid compiler warnings about unused variables.
5495
5496         * NEWS: Mention end of support for native debugging on MS-Windows
5497         before XP.
5498
5499         PR gdb/24292
5500         * common/netstuff.c:
5501         * gdbserver/gdbreplay.c
5502         * gdbserver/remote-utils.c:
5503         * ser-tcp.c:
5504         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5505         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5506         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5507         'getaddrinfo' and 'freeaddrinfo' were not available before
5508         Windows XP, and mingw.org's MinGW headers by default define
5509         _WIN32_WINNT to 0x500.
5510
5511 2019-03-01  Gary Benson <gbenson@redhat.com>
5512
5513         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5514
5515 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5516             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5517
5518         PR gdb/8527
5519         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5520         set_sigint_trap, clear_sigint_trap.
5521
5522 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5523
5524         * target.c (target_detach): Clear the regcache and the
5525         frame cache.
5526
5527 2019-02-27  Pedro Alves  <palves@redhat.com>
5528
5529         * utils.c (set_screen_size): When we cap the height/width sizes,
5530         tweak the corresponding command variable to show "unlimited":
5531
5532 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5533             Pedro Alves  <palves@redhat.com>
5534
5535         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5536         before calling rl_set_screen_size.
5537
5538 2019-02-27  Tom Tromey  <tromey@adacore.com>
5539
5540         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5541         define.
5542         * python/py-value.c: Remove Python 2.4 workaround.
5543         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5544         workaround.
5545         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5546         Python 2.4 workaround.
5547         * python/python-internal.h: Remove Python 2.4 comment.
5548         (Py_ssize_t): Don't define.
5549         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5550         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5551         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5552         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5553         * python/python.c (do_start_initialization): Remove Python 2.4
5554         workaround.
5555         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5556         (print_children): Remove Python 2.4 workaround.
5557         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5558         workaround.
5559         (CHARBUFFERPROC_NAME): Remove.
5560         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5561         Python 2.4 workaround.
5562
5563 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5564
5565         * NEWS: Note minimum Python version.
5566
5567 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5568
5569         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5570         code from these functions.  Remove corresponding ifdefs.  Use
5571         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5572         Remove gotos and target of gotos.
5573         (infpy_search_memory): Likewise.
5574
5575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5578         (hppa_gdbarch_init): Don't register deleted functions with
5579         gdbarch.
5580
5581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5584         (h8300_unwind_sp): Delete.
5585         (h8300_dummy_id): Delete.
5586         (h8300_gdbarch_init): Don't register deleted functions with
5587         gdbarch.
5588
5589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5592         (ft32_unwind_pc): Delete.
5593         (ft32_unwind_sp): Delete.
5594         (ft32_gdbarch_init): Don't register deleted functions with
5595         gdbarch.
5596
5597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5600         (frv_unwind_pc): Delete.
5601         (frv_unwind_sp): Delete.
5602         (frv_gdbarch_init): Don't register deleted functions with
5603         gdbarch.
5604
5605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5608         (riscv_unwind_pc): Delete.
5609         (riscv_unwind_sp): Delete.
5610         (riscv_gdbarch_init): Don't register deleted functions with
5611         gdbarch.
5612
5613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5616         (csky_unwind_pc): Delete.
5617         (csky_unwind_sp): Delete.
5618         (csky_gdbarch_init): Don't register deleted functions with
5619         gdbarch.
5620
5621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5624         (cris_unwind_pc): Delete.
5625         (cris_unwind_sp): Delete.
5626         (cris_gdbarch_init): Don't register deleted functions with
5627         gdbarch.
5628
5629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5630
5631         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5632         (bfin_unwind_pc): Delete.
5633         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5634
5635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5636
5637         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5638         (arm_unwind_pc): Delete.
5639         (arm_unwind_sp): Delete.
5640         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5641
5642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5643
5644         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5645         (arc_unwind_pc): Delete.
5646         (arc_unwind_sp): Delete.
5647         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5648
5649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5650
5651         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5652         (alpha_unwind_pc): Delete.
5653         (alpha_gdbarch_init): Don't register deleted functions with
5654         gdbarch.
5655
5656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5659         (aarch64_unwind_pc): Delete.
5660         (aarch64_unwind_sp): Delete.
5661         (aarch64_gdbarch_init): Don't register deleted functions with
5662         gdbarch.
5663
5664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5665
5666         * gdbtypes.c (type_align): Don't consider static members when
5667         computing structure alignment.
5668
5669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5670
5671         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5672         return 0 for other types.
5673         * arch-utils.c (default_type_align): Always return 0.
5674         * gdbarch.h: Regenerate.
5675         * gdbarch.sh (type_align): Extend comment.
5676         * gdbtypes.c (type_align): Add additional comments, always call
5677         gdbarch_type_align before applying the default rules.
5678         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5679         generic code will then apply a suitable default.
5680         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5681         types, return 0 for other types.
5682
5683 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5684
5685         * NEWS: Create a new section for the next release branch.
5686         Rename the section of the current branch, now that it has
5687         been cut.
5688
5689 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5690
5691         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5692         * version.in: Bump version to 8.3.50.DATE-git.
5693
5694 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5695
5696         * aix-thread.c (ptid_cmp): Remove unused variable.
5697         (get_signaled_thread): Likewise.
5698         (store_regs_user_thread): Likewise.
5699         (store_regs_kernel_thread): Likewise.
5700         (fetch_regs_kernel_thread): Remove shadowed variable.
5701
5702 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5703
5704         * features/riscv/32bit-cpu.xml: Add register numbers.
5705         * features/riscv/32bit-fpu.c: Regenerate.
5706         * features/riscv/32bit-fpu.xml: Add register numbers.
5707         * features/riscv/64bit-cpu.xml: Add register numbers.
5708         * features/riscv/64bit-fpu.c: Regenerate.
5709         * features/riscv/64bit-fpu.xml: Add register numbers.
5710
5711 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5712
5713         * NEWS: Mention two argument form of gdb.Value constructor.
5714         * python/py-value.c (convert_buffer_and_type_to_value): New
5715         function.
5716         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5717         Add support for handling an optional second argument.  Call
5718         convert_buffer_and_type_to_value as appropriate.
5719         * python/python-internal.h (Py_buffer_deleter): New struct.
5720         (Py_buffer_up): New typedef.
5721
5722 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5723
5724         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5725         instead of releasing ownership.
5726
5727 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5728
5729         * dwarf2read.c (open_and_init_dwp_file): Call
5730         elf_numsections instead of bfd_count_sections to initialize
5731         dwp_file->num_sections.
5732
5733 2019-02-25  Tom Tromey  <tromey@adacore.com>
5734
5735         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5736
5737 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5738
5739         * gcore.in: Add '--readnever' option when invoking GDB.
5740
5741 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5742
5743         * MAINTAINERS: Update my email address.
5744
5745 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5746
5747         * build-id.c (build_id_to_debug_bfd_1): New function.
5748         (build_id_to_debug_bfd): Look for separate debug file in
5749         sysroot.
5750
5751 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5752
5753         * gdbarch.sh: Update the copyright year range that is placed into
5754         generated files.
5755
5756 2019-02-22  Keith Seitz  <keiths@redhat.com>
5757
5758         PR symtab/23853
5759         * linespec.c (create_sals_line_offset): Search for the default
5760         symtab's filename instead of its fullname.
5761
5762 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5763
5764         * NEWS: Update style defaults.
5765
5766 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5767
5768         * main.c (captured_main_1): Disable styling in batch mode.
5769
5770 2019-02-20  Tom Tromey  <tom@tromey.com>
5771
5772         * symtab.c (symtab_symbol_info): Fix typos.
5773
5774 2019-02-20  Tom Tromey  <tromey@adacore.com>
5775
5776         * findcmd.c (_initialize_mem_search): Use upper case for
5777         metasyntactic variables.
5778
5779 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5780
5781         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5782         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5783
5784 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5785
5786         * top.h (source_file_name): Change to std::string.
5787         * top.c (source_file_name): Likewise.
5788         (command_line_input): Adjust.
5789         * cli/cli-script.c (script_from_file): Adjust.
5790
5791 2019-02-19  Tom Tromey  <tromey@adacore.com>
5792
5793         * ravenscar-thread.c
5794         (ravenscar_thread_target::update_thread_list): Don't call
5795         ada_build_task_list.
5796         * ada-lang.h (ada_build_task_list): Don't declare.
5797         * ada-tasks.c (struct ada_tasks_inferior_data)
5798         <task_list_valid_p>: Now bool.
5799         (read_known_tasks, ada_task_list_changed)
5800         (ada_tasks_invalidate_inferior_data): Update.
5801         (read_known_tasks_array): Return bool.
5802         (read_known_tasks_list): Likewise.
5803         (read_known_tasks): Return void.
5804         (ada_build_task_list): Now static.
5805
5806 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5809         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5810
5811 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5812
5813         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5814         variant for ada_tasks_pspace_data_handle and
5815         ada_tasks_inferior_data_handle.
5816         (ada_tasks_pspace_data_cleanup): New function.
5817         (ada_tasks_inferior_data_cleanup): New function.
5818
5819 2019-02-17  Tom Tromey  <tom@tromey.com>
5820
5821         * macrotab.h (macro_source_fullname): Return a std::string.
5822         * macrotab.c (macro_include, check_for_redefinition)
5823         (macro_undef, macro_lookup_definition, foreach_macro)
5824         (foreach_macro_in_scope): Update.
5825         (macro_source_fullname): Return a std::string.
5826         * macrocmd.c (show_pp_source_pos): Update.
5827
5828 2019-02-17  Tom Tromey  <tom@tromey.com>
5829
5830         * macrocmd.c (show_pp_source_pos): Style the file names.
5831
5832 2019-02-17  Tom Tromey  <tom@tromey.com>
5833
5834         PR tui/24197:
5835         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5836
5837 2019-02-17  Tom Tromey  <tom@tromey.com>
5838
5839         * ada-lang.c (user_select_syms): Use filtered printing.
5840         * utils.c (wrap_style): New global.
5841         (desired_style): Remove.
5842         (emit_style_escape): Add stream parameter.
5843         (set_output_style, reset_terminal_style, prompt_for_continue):
5844         Update.
5845         (flush_wrap_buffer): Only flush gdb_stdout.
5846         (wrap_here): Set wrap_style.
5847         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5848         treat escape sequences as a character.  Change when wrap buffer is
5849         flushed.
5850         (fputs_styled): Do not set the output style when the default is
5851         requested.
5852         * ui-style.h (struct ui_file_style) <is_default>: New method.
5853         * source.c (print_source_lines_base): Emit escape sequences in one
5854         piece.
5855
5856 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5857
5858         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5859         integers and enumeration types.
5860
5861 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5862
5863         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5864         instead of lookup_symbol_in_language
5865         (do_exact_match): New function.
5866         (ada_get_symbol_name_matcher): Return do_exact_match when
5867         doing a verbatim match.
5868
5869 2019-02-15  Tom Tromey  <tromey@adacore.com>
5870
5871         * ravenscar-thread.c (ravenscar_thread_target::resume)
5872         (ravenscar_thread_target::wait): Special case wildcard requests.
5873
5874 2019-02-15  Tom Tromey  <tromey@adacore.com>
5875
5876         * ravenscar-thread.c (base_ptid): Remove.
5877         (struct ravenscar_thread_target) <close>: New method.
5878         <m_base_ptid>: New member.
5879         <update_inferior_ptid, active_task, task_is_currently_active,
5880         runtime_initialized>: Declare methods.
5881         <ravenscar_thread_target>: Add constructor.
5882         (ravenscar_thread_target::task_is_currently_active)
5883         (ravenscar_thread_target::update_inferior_ptid)
5884         (ravenscar_runtime_initialized): Rename.  Now methods.
5885         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5886         (ravenscar_thread_target::update_thread_list): Update.
5887         (ravenscar_thread_target::active_task): Now method.
5888         (ravenscar_thread_target::store_registers)
5889         (ravenscar_thread_target::prepare_to_store)
5890         (ravenscar_thread_target::prepare_to_store)
5891         (ravenscar_thread_target::mourn_inferior): Update.
5892         (ravenscar_inferior_created): Use "new" to create target.
5893         (ravenscar_thread_target::get_ada_task_ptid): Update.
5894         (_initialize_ravenscar): Don't initialize base_ptid.
5895         (ravenscar_ops): Remove global.
5896
5897 2019-02-15  Tom Tromey  <tromey@adacore.com>
5898
5899         * target.h (push_target): Declare new overload.
5900         * target.c (push_target): New overload, taking an rvalue reference.
5901         * remote.c (remote_target::open_1): Use push_target overload.
5902         * corelow.c (core_target_open): Use push_target overload.
5903
5904 2019-02-15  Tom Tromey  <tromey@adacore.com>
5905
5906         * ravenscar-thread.c (is_ravenscar_task)
5907         (ravenscar_task_is_currently_active): Return bool.
5908         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5909         (_initialize_ravenscar): Remove "(void)".
5910         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5911         Return bool.
5912
5913 2019-02-15  Tom Tromey  <tromey@adacore.com>
5914
5915         * ravenscar-thread.c (ravenscar_runtime_initializer)
5916         (has_ravenscar_runtime, get_running_thread_id)
5917         (ravenscar_thread_target::resume): Fix indentation.
5918
5919 2019-02-15  Tom Tromey  <tromey@adacore.com>
5920
5921         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5922         from ravenscar_arch_ops.
5923         (sparc_ravenscar_ops::fetch_registers)
5924         (sparc_ravenscar_ops::store_registers): Now methods.
5925         (sparc_ravenscar_prepare_to_store): Remove.
5926         (sparc_ravenscar_ops): Redefine.
5927         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5928         methods and destructor.  Remove members.
5929         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5930         (ravenscar_thread_target::store_registers)
5931         (ravenscar_thread_target::prepare_to_store): Update.
5932         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5933         Remove.
5934         (struct ppc_ravenscar_powerpc_ops): Derive from
5935         ravenscar_arch_ops.
5936         (ppc_ravenscar_powerpc_ops::fetch_registers)
5937         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5938         (ppc_ravenscar_powerpc_ops): Redefine.
5939         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5940         (ppc_ravenscar_e500_ops::fetch_registers)
5941         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5942         (ppc_ravenscar_e500_ops): Redefine.
5943         * aarch64-ravenscar-thread.c
5944         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5945         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5946         (aarch64_ravenscar_fetch_registers)
5947         (aarch64_ravenscar_store_registers): Now methods.
5948         (aarch64_ravenscar_ops): Redefine.
5949
5950 2019-02-15  Tom Tromey  <tromey@adacore.com>
5951
5952         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5953         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5954         (ravenscar_thread_target::stopped_by_watchpoint)
5955         (ravenscar_thread_target::stopped_data_address)
5956         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5957
5958 2019-02-15  Tom Tromey  <tromey@adacore.com>
5959
5960         * ravenscar-thread.c: Fix some typos.
5961
5962 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5963             Tom Tromey  <tromey@adacore.com>
5964
5965         * ada-lang.c (ada_exception_sal): Change addr_string to a
5966         std::string.
5967         (create_ada_exception_catchpoint): Update.
5968
5969 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5970             Tom Tromey  <tromey@adacore.com>
5971
5972         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5973         (bp_location_ops): Remove.
5974         (base_breakpoint_allocate_location): Update.
5975         (free_bp_location): Update.
5976         * ada-lang.c (class ada_catchpoint_location)
5977         <ada_catchpoint_location>: Remove ops parameter.
5978         (ada_catchpoint_location_dtor): Remove.
5979         (ada_catchpoint_location_ops): Remove.
5980         (allocate_location_exception): Update.
5981         * breakpoint.h (struct bp_location_ops): Remove.
5982         (class bp_location) <bp_location>: Remove bp_location_ops
5983         parameter.
5984         <~bp_location>: Add destructor.
5985         <ops>: Remove.
5986
5987 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5988             Pedro Alves  <palves@redhat.com>
5989
5990         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5991         'PATH_MAX'.
5992
5993 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5994             Samuel Thibault  <samuel.thibault@gnu.org>
5995             Thomas Schwinge  <thomas@codesourcery.com>
5996
5997         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5998         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5999
6000 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6001
6002         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6003         (check_empty): Use "const char *".
6004
6005         * gnu-nat.c (gnu_nat_target::detach): Instead of
6006         'detach_inferior (pid)' call
6007         'detach_inferior (find_inferior_pid (pid))'.
6008
6009         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6010         'nat/fork-inferior.o'.
6011         * gnu-nat.c: #include "nat/fork-inferior.h".
6012
6013         * gnu-nat.c (gnu_nat_target::detach): Instead of
6014         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6015         * gnu-nat.h: #include "inf-child.h".
6016         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6017         'i386_gnu_nat_target::fetch_registers'.
6018         (gnu_store_registers): Rename/move to
6019         'i386_gnu_nat_target::store_registers'.
6020
6021         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6022         * gnu-nat.h (mach_thread_info): New function.
6023         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6024
6025         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6026
6027 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6028
6029         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6030
6031 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6032
6033         * windows-nat.c (windows_add_thread): Add new parameter
6034         "main_thread_p" with default value set to false.  Update
6035         function documentation as well as all callers.
6036         (windows_delete_thread): Likewise.
6037         (fake_create_process): Update call to windows_add_thread.
6038         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6039         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6040         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6041         call to windows_delete_thread.
6042
6043 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6044
6045         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6046
6047 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6048
6049         * symfile.c (find_separate_debug_file): Use canonical path of
6050         sysroot with child_path instead of gdb_sysroot if it is valid.
6051
6052 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6053
6054         * symfile.c (find_separate_debug_file): Use child_path to
6055         determine if an object file is under a sysroot.
6056
6057 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6058
6059         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6060         unittests/child-path-selftests.c.
6061         * common/pathstuff.c (child_path): New function.
6062         * common/pathstuff.h (child_path): New prototype.
6063         * unittests/child-path-selftests.c: New file.
6064
6065 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6066
6067         * symfile.c (find_separate_debug_file): Look for separate debug
6068         files in debug directories under the sysroot.
6069
6070 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6071
6072         * symtab.h (struct minimal_symbol data_p): New const method.
6073         (struct minimal_symbol text_p): Likewise.
6074         * symtab.c (output_source_filename): Use file name style
6075         to print file name.
6076         (print_symbol_info): Likewise.
6077         (print_msymbol_info): Use address style to print addresses.
6078         Use function name style to print executable text symbols.
6079         (expand_symtab_containing_pc): Use data_p.
6080         (find_pc_sect_compunit_symtab): Likewise.
6081
6082 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6083
6084         * breakpoint.c (describe_other_breakpoints): Use address style
6085         to print addresses.
6086         (say_where): Likewise.
6087
6088 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6089
6090         * ada-typeprint.c (print_func_type): Print function name
6091         style to print function name.
6092         * c-typeprint.c (c_print_type_1): Likewise.
6093
6094 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6095
6096         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6097         for execve.
6098
6099 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6100
6101         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6102         type_stack.
6103
6104 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6105
6106         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6107         TYPE_CODE_REF types.
6108
6109 2019-02-08  Jim Wilson  <jimw@sifive.com>
6110
6111         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6112         (riscv_linux_fregset): New.
6113         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6114
6115 2019-02-07  Tom Tromey  <tom@tromey.com>
6116
6117         * thread.c (thread_cancel_execution_command): Update.
6118         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6119         methods.
6120         (struct thread_fsm_ops): Remove.
6121         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6122         (thread_fsm_should_stop, thread_fsm_return_value)
6123         (thread_fsm_set_finished, thread_fsm_finished_p)
6124         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6125         Don't declare.
6126         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6127         * infrun.c (clear_proceed_status_thread)
6128         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6129         (print_stop_event): Update.
6130         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6131         Add constructor.
6132         (step_command_fsm_ops): Remove.
6133         (new_step_command_fsm): Remove.
6134         (step_1): Update.
6135         (step_command_fsm::should_stop): Rename from
6136         step_command_fsm_should_stop.
6137         (step_command_fsm::clean_up): Rename from
6138         step_command_fsm_clean_up.
6139         (step_command_fsm::do_async_reply_reason): Rename from
6140         step_command_fsm_async_reply_reason.
6141         (struct until_next_fsm): Inherit from thread_fsm.  Add
6142         constructor.
6143         (until_next_fsm_ops): Remove.
6144         (new_until_next_fsm): Remove.
6145         (until_next_fsm::should_stop): Rename from
6146         until_next_fsm_should_stop.
6147         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6148         (until_next_fsm::do_async_reply_reason): Rename from
6149         until_next_fsm_async_reply_reason.
6150         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6151         constructor.  Change type of breakpoint.
6152         (finish_command_fsm_ops): Remove.
6153         (new_finish_command_fsm): Remove.
6154         (finish_command_fsm::should_stop): Rename from
6155         finish_command_fsm_should_stop.
6156         (finish_command_fsm::clean_up): Rename from
6157         finish_command_fsm_clean_up.
6158         (finish_command_fsm::return_value): Rename from
6159         finish_command_fsm_return_value.
6160         (finish_command_fsm::do_async_reply_reason): Rename from
6161         finish_command_fsm_async_reply_reason.
6162         (finish_command): Update.
6163         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6164         Add constructor.
6165         (call_thread_fsm_ops): Remove.
6166         (call_thread_fsm::call_thread_fsm): Rename from
6167         new_call_thread_fsm.
6168         (call_thread_fsm::should_stop): Rename from
6169         call_thread_fsm_should_stop.
6170         (call_thread_fsm::should_notify_stop): Rename from
6171         call_thread_fsm_should_notify_stop.
6172         (run_inferior_call, call_function_by_hand_dummy): Update.
6173         * cli/cli-interp.c (should_print_stop_to_console): Update.
6174         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6175         Add constructor.  Change type of location_breakpoint,
6176         caller_breakpoint.
6177         (until_break_fsm_ops): Remove.
6178         (new_until_break_fsm): Remove.
6179         (until_break_fsm::should_stop): Rename from
6180         until_break_fsm_should_stop.
6181         (until_break_fsm::clean_up): Rename from
6182         until_break_fsm_clean_up.
6183         (until_break_fsm::do_async_reply_reason): Rename from
6184         until_break_fsm_async_reply_reason.
6185         (until_break_command): Update.
6186         * thread-fsm.c: Remove.
6187         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6188
6189 2019-02-07  Tom Tromey  <tom@tromey.com>
6190
6191         * yy-remap.h: Add include guard.
6192         * xtensa-tdep.h: Add include guard.
6193         * xcoffread.h: Rename include guard.
6194         * varobj-iter.h: Add include guard.
6195         * tui/tui.h: Rename include guard.
6196         * tui/tui-winsource.h: Rename include guard.
6197         * tui/tui-wingeneral.h: Rename include guard.
6198         * tui/tui-windata.h: Rename include guard.
6199         * tui/tui-win.h: Rename include guard.
6200         * tui/tui-stack.h: Rename include guard.
6201         * tui/tui-source.h: Rename include guard.
6202         * tui/tui-regs.h: Rename include guard.
6203         * tui/tui-out.h: Rename include guard.
6204         * tui/tui-layout.h: Rename include guard.
6205         * tui/tui-io.h: Rename include guard.
6206         * tui/tui-hooks.h: Rename include guard.
6207         * tui/tui-file.h: Rename include guard.
6208         * tui/tui-disasm.h: Rename include guard.
6209         * tui/tui-data.h: Rename include guard.
6210         * tui/tui-command.h: Rename include guard.
6211         * tic6x-tdep.h: Add include guard.
6212         * target/waitstatus.h: Rename include guard.
6213         * target/wait.h: Rename include guard.
6214         * target/target.h: Rename include guard.
6215         * target/resume.h: Rename include guard.
6216         * target-float.h: Rename include guard.
6217         * stabsread.h: Add include guard.
6218         * rs6000-tdep.h: Add include guard.
6219         * riscv-fbsd-tdep.h: Add include guard.
6220         * regformats/regdef.h: Rename include guard.
6221         * record.h: Rename include guard.
6222         * python/python.h: Rename include guard.
6223         * python/python-internal.h: Rename include guard.
6224         * python/py-stopevent.h: Rename include guard.
6225         * python/py-ref.h: Rename include guard.
6226         * python/py-record.h: Rename include guard.
6227         * python/py-record-full.h: Rename include guard.
6228         * python/py-record-btrace.h: Rename include guard.
6229         * python/py-instruction.h: Rename include guard.
6230         * python/py-events.h: Rename include guard.
6231         * python/py-event.h: Rename include guard.
6232         * procfs.h: Add include guard.
6233         * proc-utils.h: Add include guard.
6234         * p-lang.h: Add include guard.
6235         * or1k-tdep.h: Rename include guard.
6236         * observable.h: Rename include guard.
6237         * nto-tdep.h: Rename include guard.
6238         * nat/x86-linux.h: Rename include guard.
6239         * nat/x86-linux-dregs.h: Rename include guard.
6240         * nat/x86-gcc-cpuid.h: Add include guard.
6241         * nat/x86-dregs.h: Rename include guard.
6242         * nat/x86-cpuid.h: Rename include guard.
6243         * nat/ppc-linux.h: Rename include guard.
6244         * nat/mips-linux-watch.h: Rename include guard.
6245         * nat/linux-waitpid.h: Rename include guard.
6246         * nat/linux-ptrace.h: Rename include guard.
6247         * nat/linux-procfs.h: Rename include guard.
6248         * nat/linux-osdata.h: Rename include guard.
6249         * nat/linux-nat.h: Rename include guard.
6250         * nat/linux-namespaces.h: Rename include guard.
6251         * nat/linux-btrace.h: Rename include guard.
6252         * nat/glibc_thread_db.h: Rename include guard.
6253         * nat/gdb_thread_db.h: Rename include guard.
6254         * nat/gdb_ptrace.h: Rename include guard.
6255         * nat/fork-inferior.h: Rename include guard.
6256         * nat/amd64-linux-siginfo.h: Rename include guard.
6257         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6258         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6259         * nat/aarch64-linux.h: Rename include guard.
6260         * nat/aarch64-linux-hw-point.h: Rename include guard.
6261         * mn10300-tdep.h: Add include guard.
6262         * mips-linux-tdep.h: Add include guard.
6263         * mi/mi-parse.h: Rename include guard.
6264         * mi/mi-out.h: Rename include guard.
6265         * mi/mi-main.h: Rename include guard.
6266         * mi/mi-interp.h: Rename include guard.
6267         * mi/mi-getopt.h: Rename include guard.
6268         * mi/mi-console.h: Rename include guard.
6269         * mi/mi-common.h: Rename include guard.
6270         * mi/mi-cmds.h: Rename include guard.
6271         * mi/mi-cmd-break.h: Rename include guard.
6272         * m2-lang.h: Add include guard.
6273         * location.h: Rename include guard.
6274         * linux-record.h: Rename include guard.
6275         * linux-nat.h: Add include guard.
6276         * linux-fork.h: Add include guard.
6277         * i386-darwin-tdep.h: Rename include guard.
6278         * hppa-linux-offsets.h: Add include guard.
6279         * guile/guile.h: Rename include guard.
6280         * guile/guile-internal.h: Rename include guard.
6281         * gnu-nat.h: Rename include guard.
6282         * gdb-stabs.h: Rename include guard.
6283         * frv-tdep.h: Add include guard.
6284         * f-lang.h: Add include guard.
6285         * event-loop.h: Add include guard.
6286         * darwin-nat.h: Rename include guard.
6287         * cp-abi.h: Rename include guard.
6288         * config/sparc/nm-sol2.h: Rename include guard.
6289         * config/nm-nto.h: Rename include guard.
6290         * config/nm-linux.h: Add include guard.
6291         * config/i386/nm-i386gnu.h: Rename include guard.
6292         * config/djgpp/nl_types.h: Rename include guard.
6293         * config/djgpp/langinfo.h: Rename include guard.
6294         * compile/gcc-cp-plugin.h: Add include guard.
6295         * compile/gcc-c-plugin.h: Add include guard.
6296         * compile/compile.h: Rename include guard.
6297         * compile/compile-object-run.h: Rename include guard.
6298         * compile/compile-object-load.h: Rename include guard.
6299         * compile/compile-internal.h: Rename include guard.
6300         * compile/compile-cplus.h: Rename include guard.
6301         * compile/compile-c.h: Rename include guard.
6302         * common/xml-utils.h: Rename include guard.
6303         * common/x86-xstate.h: Rename include guard.
6304         * common/version.h: Rename include guard.
6305         * common/vec.h: Rename include guard.
6306         * common/tdesc.h: Rename include guard.
6307         * common/selftest.h: Rename include guard.
6308         * common/scoped_restore.h: Rename include guard.
6309         * common/scoped_mmap.h: Rename include guard.
6310         * common/scoped_fd.h: Rename include guard.
6311         * common/safe-iterator.h: Rename include guard.
6312         * common/run-time-clock.h: Rename include guard.
6313         * common/refcounted-object.h: Rename include guard.
6314         * common/queue.h: Rename include guard.
6315         * common/ptid.h: Rename include guard.
6316         * common/print-utils.h: Rename include guard.
6317         * common/preprocessor.h: Rename include guard.
6318         * common/pathstuff.h: Rename include guard.
6319         * common/observable.h: Rename include guard.
6320         * common/netstuff.h: Rename include guard.
6321         * common/job-control.h: Rename include guard.
6322         * common/host-defs.h: Rename include guard.
6323         * common/gdb_wait.h: Rename include guard.
6324         * common/gdb_vecs.h: Rename include guard.
6325         * common/gdb_unlinker.h: Rename include guard.
6326         * common/gdb_unique_ptr.h: Rename include guard.
6327         * common/gdb_tilde_expand.h: Rename include guard.
6328         * common/gdb_sys_time.h: Rename include guard.
6329         * common/gdb_string_view.h: Rename include guard.
6330         * common/gdb_splay_tree.h: Rename include guard.
6331         * common/gdb_setjmp.h: Rename include guard.
6332         * common/gdb_ref_ptr.h: Rename include guard.
6333         * common/gdb_optional.h: Rename include guard.
6334         * common/gdb_locale.h: Rename include guard.
6335         * common/gdb_assert.h: Rename include guard.
6336         * common/filtered-iterator.h: Rename include guard.
6337         * common/filestuff.h: Rename include guard.
6338         * common/fileio.h: Rename include guard.
6339         * common/environ.h: Rename include guard.
6340         * common/common-utils.h: Rename include guard.
6341         * common/common-types.h: Rename include guard.
6342         * common/common-regcache.h: Rename include guard.
6343         * common/common-inferior.h: Rename include guard.
6344         * common/common-gdbthread.h: Rename include guard.
6345         * common/common-exceptions.h: Rename include guard.
6346         * common/common-defs.h: Rename include guard.
6347         * common/common-debug.h: Rename include guard.
6348         * common/cleanups.h: Rename include guard.
6349         * common/buffer.h: Rename include guard.
6350         * common/btrace-common.h: Rename include guard.
6351         * common/break-common.h: Rename include guard.
6352         * cli/cli-utils.h: Rename include guard.
6353         * cli/cli-style.h: Rename include guard.
6354         * cli/cli-setshow.h: Rename include guard.
6355         * cli/cli-script.h: Rename include guard.
6356         * cli/cli-interp.h: Rename include guard.
6357         * cli/cli-decode.h: Rename include guard.
6358         * cli/cli-cmds.h: Rename include guard.
6359         * charset-list.h: Add include guard.
6360         * buildsym-legacy.h: Rename include guard.
6361         * bfin-tdep.h: Add include guard.
6362         * ax.h: Rename include guard.
6363         * arm-linux-tdep.h: Add include guard.
6364         * arm-fbsd-tdep.h: Add include guard.
6365         * arch/xtensa.h: Rename include guard.
6366         * arch/tic6x.h: Add include guard.
6367         * arch/i386.h: Add include guard.
6368         * arch/arm.h: Rename include guard.
6369         * arch/arm-linux.h: Rename include guard.
6370         * arch/arm-get-next-pcs.h: Rename include guard.
6371         * arch/amd64.h: Add include guard.
6372         * arch/aarch64-insn.h: Rename include guard.
6373         * arch-utils.h: Rename include guard.
6374         * annotate.h: Add include guard.
6375         * amd64-darwin-tdep.h: Rename include guard.
6376         * aarch64-linux-tdep.h: Add include guard.
6377         * aarch64-fbsd-tdep.h: Add include guard.
6378         * aarch32-linux-nat.h: Add include guard.
6379
6380 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6381
6382         * macrotab.c (macro_define_internal): New function that
6383         factorizes macro_define_object_internal and macro_define_function
6384         code.
6385         (macro_define_object_internal): Use macro_define_internal.
6386         (macro_define_function): Likewise.
6387
6388 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6389
6390         * macrocmd.c (extract_identifier): Return
6391         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6392         callers.
6393
6394 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6395
6396         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6397
6398 2019-02-05  Tom Tromey  <tom@tromey.com>
6399
6400         * target.c (target_stack::unpush): Move assertion earlier.
6401
6402 2019-01-30  Tom Tromey  <tom@tromey.com>
6403
6404         PR python/23615:
6405         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6406         (gdbpy_parse_and_eval): Likewise.
6407         * python/python-internal.h (gdbpy_allow_threads): New class.
6408
6409 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6410
6411         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6412         (aarch64_fbsd_fpregmap): Move earlier.
6413         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6414         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6415         instead of individual calls to trad_frame_set_reg_addr.
6416         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6417         earlier.
6418         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6419         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6420         instead of individual calls to trad_frame_set_reg_addr.
6421
6422 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6423
6424         * CONTRIBUTE: Replace contribution list with wiki link.
6425
6426 2019-01-25  Tom Tromey  <tom@tromey.com>
6427
6428         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6429
6430 2019-01-25  Tom Tromey  <tom@tromey.com>
6431
6432         * xtensa-linux-nat.c: Fix common/ includes.
6433         * xml-support.h: Fix common/ includes.
6434         * xml-support.c: Fix common/ includes.
6435         * x86-linux-nat.c: Fix common/ includes.
6436         * windows-nat.c: Fix common/ includes.
6437         * varobj.h: Fix common/ includes.
6438         * varobj.c: Fix common/ includes.
6439         * value.c: Fix common/ includes.
6440         * valops.c: Fix common/ includes.
6441         * utils.c: Fix common/ includes.
6442         * unittests/xml-utils-selftests.c: Fix common/ includes.
6443         * unittests/utils-selftests.c: Fix common/ includes.
6444         * unittests/unpack-selftests.c: Fix common/ includes.
6445         * unittests/tracepoint-selftests.c: Fix common/ includes.
6446         * unittests/style-selftests.c: Fix common/ includes.
6447         * unittests/string_view-selftests.c: Fix common/ includes.
6448         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6449         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6450         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6451         * unittests/rsp-low-selftests.c: Fix common/ includes.
6452         * unittests/parse-connection-spec-selftests.c: Fix common/
6453         includes.
6454         * unittests/optional-selftests.c: Fix common/ includes.
6455         * unittests/offset-type-selftests.c: Fix common/ includes.
6456         * unittests/observable-selftests.c: Fix common/ includes.
6457         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6458         * unittests/memrange-selftests.c: Fix common/ includes.
6459         * unittests/memory-map-selftests.c: Fix common/ includes.
6460         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6461         * unittests/function-view-selftests.c: Fix common/ includes.
6462         * unittests/environ-selftests.c: Fix common/ includes.
6463         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6464         * unittests/common-utils-selftests.c: Fix common/ includes.
6465         * unittests/cli-utils-selftests.c: Fix common/ includes.
6466         * unittests/array-view-selftests.c: Fix common/ includes.
6467         * ui-file.c: Fix common/ includes.
6468         * tui/tui-io.c: Fix common/ includes.
6469         * tracepoint.h: Fix common/ includes.
6470         * tracepoint.c: Fix common/ includes.
6471         * tracefile-tfile.c: Fix common/ includes.
6472         * top.h: Fix common/ includes.
6473         * top.c: Fix common/ includes.
6474         * thread.c: Fix common/ includes.
6475         * target/waitstatus.h: Fix common/ includes.
6476         * target/waitstatus.c: Fix common/ includes.
6477         * target.h: Fix common/ includes.
6478         * target.c: Fix common/ includes.
6479         * target-memory.c: Fix common/ includes.
6480         * target-descriptions.c: Fix common/ includes.
6481         * symtab.h: Fix common/ includes.
6482         * symfile.c: Fix common/ includes.
6483         * stap-probe.c: Fix common/ includes.
6484         * spu-linux-nat.c: Fix common/ includes.
6485         * sparc-nat.c: Fix common/ includes.
6486         * source.c: Fix common/ includes.
6487         * solib.c: Fix common/ includes.
6488         * solib-target.c: Fix common/ includes.
6489         * ser-unix.c: Fix common/ includes.
6490         * ser-tcp.c: Fix common/ includes.
6491         * ser-pipe.c: Fix common/ includes.
6492         * ser-base.c: Fix common/ includes.
6493         * selftest-arch.c: Fix common/ includes.
6494         * s12z-tdep.c: Fix common/ includes.
6495         * rust-exp.y: Fix common/ includes.
6496         * rs6000-aix-tdep.c: Fix common/ includes.
6497         * riscv-tdep.c: Fix common/ includes.
6498         * remote.c: Fix common/ includes.
6499         * remote-notif.h: Fix common/ includes.
6500         * remote-fileio.h: Fix common/ includes.
6501         * remote-fileio.c: Fix common/ includes.
6502         * regcache.h: Fix common/ includes.
6503         * regcache.c: Fix common/ includes.
6504         * record-btrace.c: Fix common/ includes.
6505         * python/python.c: Fix common/ includes.
6506         * python/py-type.c: Fix common/ includes.
6507         * python/py-inferior.c: Fix common/ includes.
6508         * progspace.h: Fix common/ includes.
6509         * producer.c: Fix common/ includes.
6510         * procfs.c: Fix common/ includes.
6511         * proc-api.c: Fix common/ includes.
6512         * printcmd.c: Fix common/ includes.
6513         * ppc-linux-nat.c: Fix common/ includes.
6514         * parser-defs.h: Fix common/ includes.
6515         * osdata.c: Fix common/ includes.
6516         * obsd-nat.c: Fix common/ includes.
6517         * nat/x86-linux.c: Fix common/ includes.
6518         * nat/x86-linux-dregs.c: Fix common/ includes.
6519         * nat/x86-dregs.h: Fix common/ includes.
6520         * nat/x86-dregs.c: Fix common/ includes.
6521         * nat/ppc-linux.c: Fix common/ includes.
6522         * nat/mips-linux-watch.h: Fix common/ includes.
6523         * nat/mips-linux-watch.c: Fix common/ includes.
6524         * nat/linux-waitpid.c: Fix common/ includes.
6525         * nat/linux-ptrace.h: Fix common/ includes.
6526         * nat/linux-ptrace.c: Fix common/ includes.
6527         * nat/linux-procfs.c: Fix common/ includes.
6528         * nat/linux-personality.c: Fix common/ includes.
6529         * nat/linux-osdata.c: Fix common/ includes.
6530         * nat/linux-namespaces.c: Fix common/ includes.
6531         * nat/linux-btrace.h: Fix common/ includes.
6532         * nat/linux-btrace.c: Fix common/ includes.
6533         * nat/fork-inferior.c: Fix common/ includes.
6534         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6535         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6536         * nat/aarch64-linux.c: Fix common/ includes.
6537         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6538         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6539         * namespace.h: Fix common/ includes.
6540         * mips-linux-tdep.c: Fix common/ includes.
6541         * minsyms.c: Fix common/ includes.
6542         * mi/mi-parse.h: Fix common/ includes.
6543         * mi/mi-main.c: Fix common/ includes.
6544         * mi/mi-cmd-env.c: Fix common/ includes.
6545         * memrange.h: Fix common/ includes.
6546         * memattr.c: Fix common/ includes.
6547         * maint.h: Fix common/ includes.
6548         * maint.c: Fix common/ includes.
6549         * main.c: Fix common/ includes.
6550         * machoread.c: Fix common/ includes.
6551         * location.c: Fix common/ includes.
6552         * linux-thread-db.c: Fix common/ includes.
6553         * linux-nat.c: Fix common/ includes.
6554         * linux-fork.c: Fix common/ includes.
6555         * inline-frame.c: Fix common/ includes.
6556         * infrun.c: Fix common/ includes.
6557         * inflow.c: Fix common/ includes.
6558         * inferior.h: Fix common/ includes.
6559         * inferior.c: Fix common/ includes.
6560         * infcmd.c: Fix common/ includes.
6561         * inf-ptrace.c: Fix common/ includes.
6562         * inf-child.c: Fix common/ includes.
6563         * ia64-linux-nat.c: Fix common/ includes.
6564         * i387-tdep.c: Fix common/ includes.
6565         * i386-tdep.c: Fix common/ includes.
6566         * i386-linux-tdep.c: Fix common/ includes.
6567         * i386-linux-nat.c: Fix common/ includes.
6568         * i386-go32-tdep.c: Fix common/ includes.
6569         * i386-fbsd-tdep.c: Fix common/ includes.
6570         * i386-fbsd-nat.c: Fix common/ includes.
6571         * guile/scm-type.c: Fix common/ includes.
6572         * guile/guile.c: Fix common/ includes.
6573         * go32-nat.c: Fix common/ includes.
6574         * gnu-nat.c: Fix common/ includes.
6575         * gdbthread.h: Fix common/ includes.
6576         * gdbarch-selftests.c: Fix common/ includes.
6577         * gdb_usleep.c: Fix common/ includes.
6578         * gdb_select.h: Fix common/ includes.
6579         * gdb_bfd.c: Fix common/ includes.
6580         * gcore.c: Fix common/ includes.
6581         * fork-child.c: Fix common/ includes.
6582         * findvar.c: Fix common/ includes.
6583         * fbsd-nat.c: Fix common/ includes.
6584         * event-top.c: Fix common/ includes.
6585         * event-loop.c: Fix common/ includes.
6586         * dwarf2read.c: Fix common/ includes.
6587         * dwarf2loc.c: Fix common/ includes.
6588         * dwarf2-frame.c: Fix common/ includes.
6589         * dwarf-index-cache.c: Fix common/ includes.
6590         * dtrace-probe.c: Fix common/ includes.
6591         * disasm-selftests.c: Fix common/ includes.
6592         * defs.h: Fix common/ includes.
6593         * csky-tdep.c: Fix common/ includes.
6594         * cp-valprint.c: Fix common/ includes.
6595         * cp-support.h: Fix common/ includes.
6596         * cp-support.c: Fix common/ includes.
6597         * corelow.c: Fix common/ includes.
6598         * completer.h: Fix common/ includes.
6599         * completer.c: Fix common/ includes.
6600         * compile/compile.c: Fix common/ includes.
6601         * compile/compile-loc2c.c: Fix common/ includes.
6602         * compile/compile-cplus-types.c: Fix common/ includes.
6603         * compile/compile-cplus-symbols.c: Fix common/ includes.
6604         * command.h: Fix common/ includes.
6605         * cli/cli-dump.c: Fix common/ includes.
6606         * cli/cli-cmds.c: Fix common/ includes.
6607         * charset.c: Fix common/ includes.
6608         * build-id.c: Fix common/ includes.
6609         * btrace.h: Fix common/ includes.
6610         * btrace.c: Fix common/ includes.
6611         * breakpoint.h: Fix common/ includes.
6612         * breakpoint.c: Fix common/ includes.
6613         * ax.h:
6614         (enum agent_op): Fix common/ includes.
6615         * ax-general.c (struct aop_map): Fix common/ includes.
6616         * ax-gdb.c: Fix common/ includes.
6617         * auxv.c: Fix common/ includes.
6618         * auto-load.c: Fix common/ includes.
6619         * arm-tdep.c: Fix common/ includes.
6620         * arch/riscv.c: Fix common/ includes.
6621         * arch/ppc-linux-common.c: Fix common/ includes.
6622         * arch/i386.c: Fix common/ includes.
6623         * arch/arm.c: Fix common/ includes.
6624         * arch/arm-linux.c: Fix common/ includes.
6625         * arch/arm-get-next-pcs.c: Fix common/ includes.
6626         * arch/amd64.c: Fix common/ includes.
6627         * arch/aarch64.c: Fix common/ includes.
6628         * arch/aarch64-insn.c: Fix common/ includes.
6629         * arch-utils.c: Fix common/ includes.
6630         * amd64-windows-tdep.c: Fix common/ includes.
6631         * amd64-tdep.c: Fix common/ includes.
6632         * amd64-sol2-tdep.c: Fix common/ includes.
6633         * amd64-obsd-tdep.c: Fix common/ includes.
6634         * amd64-nbsd-tdep.c: Fix common/ includes.
6635         * amd64-linux-tdep.c: Fix common/ includes.
6636         * amd64-linux-nat.c: Fix common/ includes.
6637         * amd64-fbsd-tdep.c: Fix common/ includes.
6638         * amd64-fbsd-nat.c: Fix common/ includes.
6639         * amd64-dicos-tdep.c: Fix common/ includes.
6640         * amd64-darwin-tdep.c: Fix common/ includes.
6641         * agent.c: Fix common/ includes.
6642         * ada-lang.h: Fix common/ includes.
6643         * ada-lang.c: Fix common/ includes.
6644         * aarch64-tdep.c: Fix common/ includes.
6645
6646 2019-01-25  Tom Tromey  <tom@tromey.com>
6647
6648         * common/create-version.sh: Use common/version.h.
6649
6650 2019-01-24  Pedro Alves  <palves@redhat.com>
6651
6652         * infrun.c (signal_stop, signal_print, signal_program)
6653         (signal_catch, signal_pass): Now arrays instead of pointers.
6654         (update_signals_program_target, do_target_resume)
6655         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6656         * linux-nat.c (linux_nat_target::pass_signals)
6657         (linux_nat_target::create_inferior, linux_nat_target::attach):
6658         Adjust.
6659         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6660         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6661         * procfs.c (procfs_target::pass_signals): Adjust.
6662         * record-full.c (record_full_target::resume): Adjust.
6663         * remote.c (remote_target::pass_signals)
6664         (remote_target::program_signals): Adjust.
6665         * target-debug.h (target_debug_print_signals): Now takes a
6666         gdb::array_view as parameter.  Adjust.
6667         * target.h (target_ops) <pass_signals, program_signals>: Replace
6668         pointer and length parameters with gdb::array_view.
6669         (target_pass_signals, target_program_signals): Likewise.
6670         * target-delegates.c: Regenerate.
6671
6672 2019-01-24  Pedro Alves  <palves@redhat.com>
6673
6674         * common/forward-scope-exit.h
6675         (forward_scope_exit::forward_scope_exit): Pass arguments to
6676         m_bind_function directly, instead of creating a std::bind and
6677         copying that.
6678
6679 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6680
6681         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6682         for static members.
6683         (pass_in_v_vfp_candidate): Likewise.
6684
6685 2019-01-23  Tom Tromey  <tom@tromey.com>
6686             Pedro Alves  <palves@redhat.com>
6687
6688         * regcache.c (class regcache_invalidator): Remove.
6689         (regcache::raw_write): Use make_scope_exit.
6690
6691 2019-01-23  Tom Tromey  <tom@tromey.com>
6692
6693         * ui-out.h (class ui_out_emit_type): Update comment.
6694
6695 2019-01-23  Tom Tromey  <tom@tromey.com>
6696
6697         * infrun.c (fetch_inferior_event): Update comment.
6698
6699 2019-01-23  Tom Tromey  <tom@tromey.com>
6700             Pedro Alves  <palves@redhat.com>
6701
6702         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6703         parameter.
6704         (fetch_inferior_event): Use SCOPE_EXIT.
6705
6706
6707 2019-01-23  Tom Tromey  <tom@tromey.com>
6708             Pedro Alves  <palves@redhat.com>
6709
6710         * infrun.c (disable_thread_events): Delete.
6711         (stop_all_threads): Use SCOPE_EXIT.
6712
6713 2019-01-23  Tom Tromey  <tom@tromey.com>
6714             Pedro Alves  <palves@redhat.com>
6715
6716         * symfile.c: Include forward-scope-exit.h.
6717         (clear_symtab_users_cleanup): Replace forward declaration with
6718         a FORWARD_SCOPE_EXIT.
6719         (syms_from_objfile_1): Use the forward_scope_exit and
6720         gdb::optional instead of cleanup_function.
6721         (reread_symbols): Use the forward_scope_exit instead of
6722         cleanup_function.
6723         (clear_symtab_users_cleanup): Remove function.
6724
6725 2019-01-23  Tom Tromey  <tom@tromey.com>
6726             Pedro Alves  <palves@redhat.com>
6727
6728         * linux-nat.c: Include scope-exit.h.
6729         (cleanup_target_stop): Remove.
6730         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6731         SCOPE_EXIT.
6732
6733 2019-01-23  Tom Tromey  <tom@tromey.com>
6734             Pedro Alves  <palves@redhat.com>
6735
6736         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6737         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6738
6739 2019-01-23  Tom Tromey  <tom@tromey.com>
6740             Andrew Burgess  <andrew.burgess@embecosm.com>
6741             Pedro Alves  <palves@redhat.com>
6742
6743         * infrun.c (fetch_inferior_event): Use scope_exit.
6744         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6745         * top.c (execute_command): Use scope_exit.
6746         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6747         * utils.c (do_bpstat_clear_actions_cleanup)
6748         (make_bpstat_clear_actions_cleanup): Remove.
6749
6750 2019-01-23  Tom Tromey  <tom@tromey.com>
6751             Pedro Alves  <palves@redhat.com>
6752
6753         * infrun.c: Include "common/scope-exit.h"
6754         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6755         (wait_for_inferior): Use SCOPE_EXIT.
6756         (fetch_inferior_event): Use scope_exit.
6757
6758 2019-01-23  Tom Tromey  <tom@tromey.com>
6759             Pedro Alves  <palves@redhat.com>
6760
6761         * breakpoint.c (create_breakpoint): Remove cleanup.
6762
6763 2019-01-23  Tom Tromey  <tom@tromey.com>
6764             Andrew Burgess  <andrew.burgess@embecosm.com>
6765             Pedro Alves  <palves@redhat.com>
6766
6767 2019-01-23  Pedro Alves  <palves@redhat.com>
6768
6769         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6770
6771 2019-01-23  Pedro Alves  <palves@redhat.com>
6772             Andrew Burgess  <andrew.burgess@embecosm.com>
6773
6774         * gdbthread.h: Include "common/forward-scope-exit.h".
6775         (scoped_finish_thread_state): Redefine custom class in terms of
6776         forward_scope_exit.
6777
6778 2019-01-23  Pedro Alves  <palves@redhat.com>
6779             Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * common/forward-scope-exit.h: New file.
6782
6783 2019-01-23  Pedro Alves  <palves@redhat.com>
6784             Andrew Burgess  <andrew.burgess@embecosm.com>
6785             Tom Tromey  <tom@tromey.com>
6786
6787         * common/scope-exit.h: New file.
6788
6789 2019-01-23  Pedro Alves  <palves@redhat.com>
6790
6791         * common/preprocessor.h (ESC): Rename to ...
6792         (ESC_PARENS): ... this.
6793         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6794         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6795
6796 2019-01-23  Tom Tromey  <tom@tromey.com>
6797
6798         * language.h (class scoped_switch_to_sym_language_if_auto):
6799         Initialize m_lang in both cases.
6800
6801 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6802
6803         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6804         with XCNEW.
6805
6806 2019-01-22  Tom Tromey  <tom@tromey.com>
6807
6808         * corelow.c: Do not include sys/file.h.
6809
6810 2019-01-22  Tom Tromey  <tom@tromey.com>
6811
6812         * tui/tui-wingeneral.h: Include gdb_curses.h.
6813
6814 2019-01-22  Tom Tromey  <tom@tromey.com>
6815
6816         * source-cache.h (class source_cache) <get_source_lines,
6817         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6818
6819 2019-01-22  Tom Tromey  <tom@tromey.com>
6820
6821         * remote-fileio.h (struct remote_target): Declare.
6822
6823 2019-01-22  Tom Tromey  <tom@tromey.com>
6824
6825         * python/py-arch.c: Do not include py-ref.h.
6826         * python/py-bpevent.c: Do not include py-ref.h.
6827         * python/py-cmd.c: Do not include py-ref.h.
6828         * python/py-continueevent.c: Do not include py-ref.h.
6829         * python/py-event.h: Do not include py-ref.h.
6830         * python/py-evtregistry.c: Do not include py-ref.h.
6831         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6832         * python/py-frame.c: Do not include py-ref.h.
6833         * python/py-framefilter.c: Do not include py-ref.h.
6834         * python/py-function.c: Do not include py-ref.h.
6835         * python/py-infevents.c: Do not include py-ref.h.
6836         * python/py-linetable.c: Do not include py-ref.h.
6837         * python/py-objfile.c: Do not include py-ref.h.
6838         * python/py-param.c: Do not include py-ref.h.
6839         * python/py-prettyprint.c: Do not include py-ref.h.
6840         * python/py-progspace.c: Do not include py-ref.h.
6841         * python/py-symbol.c: Do not include py-ref.h.
6842         * python/py-symtab.c: Do not include py-ref.h.
6843         * python/py-type.c: Do not include py-ref.h.
6844         * python/py-unwind.c: Do not include py-ref.h.
6845         * python/py-utils.c: Do not include py-ref.h.
6846         * python/py-value.c: Do not include py-ref.h.
6847         * python/py-varobj.c: Do not include py-ref.h.
6848         * python/py-xmethods.c: Do not include py-ref.h.
6849         * python/python.c: Do not include py-ref.h.
6850         * varobj.c: Do not include py-ref.h.
6851
6852 2019-01-22  Tom Tromey  <tom@tromey.com>
6853
6854         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6855         keyword for bcache.
6856
6857 2019-01-22  Tom Tromey  <tom@tromey.com>
6858
6859         * compile/compile-cplus-types.c: Remove a comment by #include.
6860
6861 2019-01-22  Tom Tromey  <tom@tromey.com>
6862
6863         * compile/gcc-c-plugin.h: Include compile-internal.h.
6864
6865 2019-01-22  Tom Tromey  <tom@tromey.com>
6866
6867         * stabsread.c (EXTERN): Do not define.
6868         (symnum, next_symbol_text_func, processing_gcc_compilation)
6869         (within_function, global_sym_chain, global_stabs)
6870         (previous_stab_code, this_object_header_files)
6871         (n_this_object_header_files)
6872         (n_allocated_this_object_header_files): Define.
6873         * stabsread.h (EXTERN): Never define.  Use "extern".
6874
6875 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6876
6877         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6878         history_value.
6879
6880 2019-01-21  Tom Tromey  <tom@tromey.com>
6881
6882         * ui-out.c: Fix includes.
6883         * tui/tui-source.c: Fix includes.
6884         * target.c: Fix includes.
6885         * remote.c: Fix includes.
6886         * regcache.c: Fix includes.
6887         * python/py-block.c: Fix includes.
6888         * printcmd.c: Fix includes.
6889         * or1k-tdep.c: Fix includes.
6890         * mi/mi-main.c: Fix includes.
6891         * m32r-tdep.c: Fix includes.
6892         * csky-tdep.c: Fix includes.
6893         * compile/compile-cplus-types.c: Fix includes.
6894         * cli/cli-interp.c: Fix includes.
6895
6896 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6897
6898         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6899         for padding.
6900
6901 2019-01-16  Tom Tromey  <tom@tromey.com>
6902
6903         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6904         earlier.
6905         (struct objfile) <msymbols_range>: Move from top level.
6906         <msymbols>: New method.
6907         (class objfile_msymbols): Remove.
6908         * symtab.c (default_collect_symbol_completion_matches_break_on):
6909         Update.
6910         * symmisc.c (dump_msymbols): Update.
6911         * stabsread.c (scan_file_globals): Update.
6912         * objc-lang.c (info_selectors_command, info_classes_command)
6913         (find_methods): Update.
6914         * minsyms.c (find_solib_trampoline_target): Update.
6915         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6916         * coffread.c (coff_symfile_read): Update.
6917         * ada-lang.c (ada_lookup_simple_minsym)
6918         (ada_collect_symbol_completion_matches): Update.
6919
6920 2019-01-16  Tom Tromey  <tom@tromey.com>
6921
6922         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6923         type.  Remove no-argument constructor.
6924         <iterator::operator++>: Simplify.
6925         <begin>: Update.
6926         <end>: Use minimal_symbol_count.
6927
6928 2019-01-16  Tom Tromey  <tom@tromey.com>
6929
6930         * objfiles.h (struct objfile) <psymtabs>: New method.
6931         (class objfile_psymtabs): Remove.
6932         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6933         typedef.
6934         <range>: New method.
6935         (require_partial_symbols): Change return type.
6936         * psymtab.c (require_partial_symbols)
6937         (psym_expand_symtabs_matching): Update.
6938         * mdebugread.c (parse_partial_symbols): Update.
6939         * dbxread.c (dbx_end_psymtab): Update.
6940
6941 2019-01-15  Tom Tromey  <tom@tromey.com>
6942
6943         * symtab.c (lookup_objfile_from_block)
6944         (lookup_symbol_in_objfile_symtabs)
6945         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6946         (find_line_symtab, info_sources_command)
6947         (default_collect_symbol_completion_matches_break_on)
6948         (make_source_files_completion_list): Update.
6949         * symmisc.c (print_objfile_statistics, dump_objfile)
6950         (maintenance_print_symbols, maintenance_info_symtabs)
6951         (maintenance_check_symtabs, maintenance_info_line_tables):
6952         Update.
6953         * source.c (select_source_symtab)
6954         (forget_cached_source_info_for_objfile): Update.
6955         * objfiles.h (class objfile_compunits): Remove.
6956         (struct objfile) <compunits_range>: New typedef.
6957         (compunits): New method.
6958         * objfiles.c (objfile_relocate1): Update.
6959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6960         * maint.c (count_symtabs_and_blocks): Update.
6961         * linespec.c (iterate_over_all_matching_symtabs): Update.
6962         * cp-support.c (add_symbol_overload_list_qualified): Update.
6963         * coffread.c (coff_symtab_read): Update.
6964         * ada-lang.c (add_nonlocal_symbols)
6965         (ada_collect_symbol_completion_matches)
6966         (ada_add_global_exceptions): Update.
6967
6968 2019-01-15  Tom Tromey  <tom@tromey.com>
6969
6970         * progspace.h (program_space) <objfiles_safe_range>: New
6971         typedef.
6972         <objfiles_safe>: New method.
6973         * objfiles.h (class all_objfiles_safe): Remove.
6974         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6975         * jit.c (jit_inferior_exit_hook): Update.
6976
6977 2019-01-17  Tom Tromey  <tom@tromey.com>
6978
6979         * progspace.h (program_space) <objfiles_range>: New typedef.
6980         <objfiles>: New method.
6981         <objfiles_head>: Rename from objfiles.
6982         (object_files): Update.
6983         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6984         * guile/scm-pretty-print.c
6985         (ppscm_find_pretty_printer_from_objfiles): Update.
6986         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6987         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6988         Update.
6989         * python/py-progspace.c (pspy_get_objfiles): Update.
6990         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6991         Update.
6992         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6993         (objfpy_lookup_objfile_by_build_id): Update.
6994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6995         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6996         Update.
6997         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6998         (expand_symtab_containing_pc, lookup_objfile_from_block)
6999         (lookup_static_symbol, basic_lookup_transparent_type)
7000         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7001         (find_line_symtab, info_sources_command)
7002         (default_collect_symbol_completion_matches_break_on)
7003         (make_source_files_completion_list, find_main_name): Update.
7004         * symmisc.c (print_symbol_bcache_statistics)
7005         (print_objfile_statistics, maintenance_print_symbols)
7006         (maintenance_print_msymbols, maintenance_print_objfiles)
7007         (maintenance_info_symtabs, maintenance_check_symtabs)
7008         (maintenance_expand_symtabs, maintenance_info_line_tables):
7009         Update.
7010         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7011         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7012         (map_overlay_command, unmap_overlay_command)
7013         (simple_overlay_update, expand_symtabs_matching)
7014         (map_symbol_filenames): Update.
7015         * symfile-debug.c (set_debug_symfile): Update.
7016         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7017         Update.
7018         * source.c (select_source_symtab, forget_cached_source_info):
7019         Update.
7020         * solib.c (solib_read_symbols): Update.
7021         * solib-spu.c (append_ocl_sos): Update.
7022         * psymtab.c (maintenance_print_psymbols)
7023         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7024         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7025         * printcmd.c (info_symbol_command): Update.
7026         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7027         Update.
7028         * objfiles.h (class all_objfiles): Remove.
7029         * objfiles.c (have_partial_symbols, have_full_symbols)
7030         (have_minimal_symbols, qsort_cmp, update_section_map)
7031         (shared_objfile_contains_address_p)
7032         (default_iterate_over_objfiles_in_search_order): Update.
7033         * objc-lang.c (info_selectors_command, info_classes_command)
7034         (find_methods): Update.
7035         * minsyms.c (find_solib_trampoline_target): Update.
7036         * maint.c (maintenance_info_sections)
7037         (maintenance_translate_address, count_symtabs_and_blocks):
7038         Update.
7039         * main.c (captured_main_1): Update.
7040         * linux-thread-db.c (try_thread_db_load_from_pdir)
7041         (has_libpthread): Update.
7042         * linespec.c (iterate_over_all_matching_symtabs)
7043         (search_minsyms_for_name): Update.
7044         * jit.c (jit_find_objf_with_entry_addr): Update.
7045         * hppa-tdep.c (find_unwind_entry)
7046         (hppa_lookup_stub_minimal_symbol): Update.
7047         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7048         Update.
7049         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7050         (elf_gnu_ifunc_resolve_by_got): Update.
7051         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7052         * dwarf-index-write.c (save_gdb_index_command): Update.
7053         * cp-support.c (add_symbol_overload_list_qualified): Update.
7054         * breakpoint.c (create_overlay_event_breakpoint)
7055         (create_longjmp_master_breakpoint)
7056         (create_std_terminate_master_breakpoint)
7057         (create_exception_master_breakpoint): Update.
7058         * blockframe.c (find_pc_partial_function): Update.
7059         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7060         (ada_collect_symbol_completion_matches)
7061         (ada_add_global_exceptions): Update.
7062
7063 2019-01-17  Tom Tromey  <tom@tromey.com>
7064
7065         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7066         declare VEC.
7067         (solib_target_parse_libraries): Change return type.
7068         (library_list_start_segment, library_list_start_section)
7069         (library_list_end_library, library_list_start_library); Update.
7070         (solib_target_free_library_list): Remove.
7071         (solib_target_parse_libraries): Remove cleanup.  Change return
7072         type.
7073         (solib_target_current_sos): Update.
7074
7075 2019-01-17  Tom Tromey  <tromey@bapiya>
7076
7077         * valprint.c: Replace "the the" with "the".
7078         * symtab.c: Replace "the the" with "the".
7079         * solib.c: Replace "the the" with "the".
7080         * solib-dsbt.c: Replace "the the" with "the".
7081         * linespec.c: Replace "the the" with "the".
7082         * dwarf2loc.h: Replace "the the" with "the".
7083         * amd64-windows-tdep.c: Replace "the the" with "the".
7084         * aarch64-tdep.c: Replace "the the" with "the".
7085
7086 2019-01-16  Keith Seitz  <keiths@redhat.com>
7087
7088         PR gdb/23773
7089         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7090         <builder>: Rename to ..
7091         <m_builder>: ... this and make private.
7092         (dwarf2_cu::get_builder): New method.  Change all users of
7093         `builder' to use this method.
7094         (dwarf2_start_symtab): Move to ...
7095         (dwarf2_cu::start_symtab): ... here.  Update all callers
7096         (setup_type_unit_groups): Move to ...
7097         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7098         callers.
7099         (dwarf2_cu::reset_builder): New method.
7100         (process_full_compunit, process_full_type_unit): Use
7101         dwarf2_cu::reset_builder.
7102         (follow_die_offset): Record the ancestor CU if it is different
7103         from the followed DIE's CU.
7104         (follow_die_sig_1): Likewise.
7105
7106 2019-01-15  Tom Tromey  <tom@tromey.com>
7107
7108         * remote.c (class remote_state) <buf>: Now a char_vector.
7109         <buf_size>: Remove.
7110         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7111         parameter.
7112         (remote_target::getpkt_or_notif_sane_1)
7113         (remote_target::getpkt_sane)
7114         (remote_target::getpkt_or_notif_sane): Likewise.
7115         (class remote_target) <putpkt>: New overload.
7116         (remote_target::read_frame): Change type of "buf_p".  Remove
7117         sizeof_p parameter.
7118         (packet_ok): New overload.
7119         (packet_check_result): New overload.
7120         Update all uses.
7121
7122 2019-01-14  Tom Tromey  <tom@tromey.com>
7123
7124         * remote-notif.c (handle_notification, remote_notif_ack)
7125         (remote_notif_parse): Make "buf" const.
7126         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7127         const.
7128         (remote_notif_parse, remote_notif_ack, handle_notification):
7129         Likewise.
7130         * remote.c (remote_notif_stop_parse): Make "buf" const.
7131         (remote_target::remote_parse_stop_reply): Make "buf" const.
7132         (remote_notif_stop_ack): Make "buf" const.
7133
7134 2019-01-14  Tom Tromey  <tom@tromey.com>
7135
7136         * remote.c (remote_console_output): Make parameter const.
7137
7138 2019-01-14  Tom Tromey  <tom@tromey.com>
7139
7140         * target-debug.h (target_debug_print_signals): Constify.
7141         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7142         * procfs.c (procfs_target::pass_signals): Update.
7143         * linux-nat.c (linux_nat_target::pass_signals): Update.
7144         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7145         * target-delegates.c: Rebuild.
7146         * remote.c (remote_target::program_signals): Update.
7147         (remote_target::pass_signals): Update.
7148         * target.c (target_pass_signals): Constify argument.
7149         (target_program_signals): Likewise.
7150         * target.h (struct target_ops) <pass_signals, program_signals>:
7151         Constify argument.
7152         (target_pass_signals, target_program_signals): Constify argument.
7153
7154 2019-01-14  Tom Tromey  <tom@tromey.com>
7155
7156         PR tui/28819:
7157         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7158
7159 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7160
7161         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7162         field.
7163         * rs6000-tdep.c: Include reggroups.h.
7164         (IS_V_ALIAS_PSEUDOREG): Define.
7165         (rs6000_register_name): Return names for the "vX" aliases.
7166         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7167         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7168         aliases.  Call default_register_reggroup_p for all other
7169         pseudo-registers.
7170         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7171         New functions.
7172         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7173         Handle "vX" aliases.
7174         (v_alias_pseudo_register_collect): New function.
7175         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7176         (rs6000_gdbarch_init): Initialize "vX" aliases as
7177         pseudo-registers.  Restore registration of
7178         rs6000_pseudo_register_reggroup_p with
7179         set_tdesc_pseudo_register_reggroup_p.
7180
7181 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7182
7183         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7184         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7185         set_gdbarch_num_pseudo_regs.
7186
7187 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7188
7189         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7190         Remove arg prefixname, add do_set and do_show.
7191         Add member functions set_list and show_list.
7192         * cli/cli-style.c (class cli_style_option): Update accordingly.
7193         (style_set_list): Move to file scope.
7194         (style_show_list): Likewise.
7195         (set_style): Call help_list.
7196         (show_style): Call cmd_show_list.
7197         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7198         Update to use the new macro.
7199
7200 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7201
7202         * ada-lang.c (_initialize_ada_language): Expand the help text
7203         for the "catch exception" command.
7204
7205 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7206
7207         * symtab.c (matching_obj_sections): Initialize obj,
7208         declare it closer to its usage.
7209
7210 2019-01-10  Tom Tromey  <tom@tromey.com>
7211
7212         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7213         (basic_inf_threads_range): Remove.
7214         (inf_threads_range, inf_non_exited_threads_range)
7215         (safe_inf_threads_range): Use next_adapter.
7216
7217 2019-01-10  Keith Seitz  <keiths@redhat.com>
7218
7219         PR gdb/23712
7220         PR symtab/23010
7221         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7222         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7223
7224 2019-01-10  Keith Seitz  <keiths@redhat.com>
7225
7226         PR gdb/23712
7227         PR symtab/23010
7228         * dictionary.c (pending_to_vector): Remove.
7229         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7230         Remove _1 suffix, replacing functions of the same name.  Update
7231         all callers.
7232         (dict_create_hashed, dict_create_hashed_expandable)
7233         (dict_create_linear, dict_create_linear_expandable, dict_free)
7234         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7235         Make functions static.
7236
7237 2019-01-10  Keith Seitz  <keiths@redhat.com>
7238
7239         PR gdb/23712
7240         PR symtab/23010
7241         * dictionary.h (struct dictionary): Replace declaration with
7242         multidictionary.
7243         (dict_create_hashed, dict_create_hashed_expandable)
7244         (dict_create_linear, dict_create_linear_expandable)
7245         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7246         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7247         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7248         taking multidictionary argument.
7249         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7250         * block.h (struct block) <dict>: Change to multidictionary
7251         and rename `multidict'.
7252         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7253         symmisc.c: Update all dictionary references to multidictionary.
7254
7255 2019-01-10  Keith Seitz  <keiths@redhat.com>
7256
7257         PR gdb/23712
7258         PR symtab/23010
7259         * dictionary.c: Include unordered_map.
7260         (pending_to_vector): New function.
7261         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7262         Rewrite the non-"_1" functions to take vector instead
7263         of linked list.
7264         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7265         "new" _1 versions of the same name.
7266         (multidictionary): Define.
7267         (std::hash<enum language): New definition.
7268         (collate_pending_symbols_by_language, mdict_create_hashed)
7269         (mdict_create_hashed_expandable, mdict_create_linear)
7270         (mdict_create_linear_expandable, mdict_free)
7271         (find_language_dictionary, create_new_language_dictionary)
7272         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7273         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7274         (mdict_size, mdict_empty): New functions.
7275         * dictionary.h (mdict_iterator): Define.
7276
7277 2019-01-10  Pedro Alves  <palves@redhat.com>
7278
7279         * breakpoint.c (read_uploaded_action)
7280         (create_tracepoint_from_upload): Adjust to use
7281         gdb::unique_xmalloc_ptr.
7282         * ctf.c (ctf_write_uploaded_tp):
7283         (SET_ARRAY_FIELD): Use emplace_back.
7284         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7285         * tracefile-tfile.c (tfile_write_uploaded_tp):
7286         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7287         gdb::unique_xmalloc_ptr.
7288         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7289         at_string, cond_string, cmd_strings>: Replace char pointers
7290         with gdb::unique_xmalloc_ptr.
7291
7292 2019-01-10  Pedro Alves  <palves@redhat.com>
7293
7294         * solib-target.c (library_list_start_library): Don't xstrdup name.
7295
7296 2019-01-10  Pedro Alves  <palves@redhat.com>
7297
7298         * mdebugread.c (parse_partial_symbols): Use
7299         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7300
7301 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7302
7303         * linux-fork.c (scoped_switch_fork_info)
7304         <~scoped_switch_fork_info>: Fix incorrect variable name.
7305
7306 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7307
7308         * linux-fork.c (scoped_switch_fork_info)
7309         <scoped_switch_fork_info>: Make explicit.
7310         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7311
7312 2019-01-10  Tom Tromey  <tom@tromey.com>
7313
7314         * objfiles.h (objfile::reset_psymtabs): Update.
7315         * objfiles.c (objfile::objfile): Update.
7316         * psymtab.h (psymtab_storage::obstack): Update.
7317         (psymtab_storage::m_obstack): Use gdb::optional.
7318         (class psymtab_storage): Update comment.  Remove objfile
7319         parameter.
7320         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7321
7322 2019-01-10  Tom Tromey  <tom@tromey.com>
7323
7324         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7325         <free_psymtabs>: Now private.
7326         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7327         (allocate_psymtab): Use new method.
7328
7329 2019-01-10  Tom Tromey  <tom@tromey.com>
7330
7331         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7332         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7333         * mdebugread.c (parse_partial_symbols): Use
7334         allocate_dependencies.
7335         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7336         allocate_dependencies.
7337         (process_psymtab_comp_unit_reader)
7338         (build_type_psymtab_dependencies): Likewise.
7339         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7340
7341 2019-01-10  Tom Tromey  <tom@tromey.com>
7342
7343         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7344         PSYMBOL_SET_LANGUAGE.
7345         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7346
7347 2019-01-10  Tom Tromey  <tom@tromey.com>
7348
7349         * psymtab.h (psymtab_storage::obstack): New method.
7350         <m_obstack>: Rename from obstack; now private.
7351         * psymtab.c (psymtab_storage): Update.
7352         * dwarf2read.c (create_addrmap_from_index)
7353         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7354         Update.
7355
7356 2019-01-10  Tom Tromey  <tom@tromey.com>
7357
7358         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7359         * objfiles.h (objfile::reset_psymtabs): New method.
7360
7361 2019-01-10  Tom Tromey  <tom@tromey.com>
7362
7363         * symmisc.c (print_symbol_bcache_statistics): Update.
7364         (print_objfile_statistics): Update.
7365         * symfile.c (reread_symbols): Update.
7366         * psymtab.h (class psymtab_storage): New.
7367         * psymtab.c (psymtab_storage): New constructor.
7368         (~psymtab_storage): New destructor.
7369         (require_partial_symbols): Update.
7370         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7371         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7372         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7373         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7374         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7375         (start_psymtab_common, end_psymtab_common)
7376         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7377         (allocate_psymtab): Update.
7378         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7379         Update.
7380         (dump_psymtab_addrmap, maintenance_print_psymbols)
7381         (maintenance_check_psymtabs): Update.
7382         (class objfile_psymtabs): Move to objfiles.h.
7383         * psympriv.h (discard_psymtab): Now inline.
7384         (psymtab_discarder::psymtab_discarder): Update.
7385         (psymtab_discarder::~psymtab_discarder): Update.
7386         (ALL_OBJFILE_PSYMTABS): Rewrite.
7387         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7388         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7389         Remove fields.
7390         <partial_symtabs>: New field.
7391         (class objfile_psymtabs): Move from psymtab.h.  Update.
7392         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7393         psymbol_cache.
7394         (objfile::~objfile): Don't destroy psymbol_cache.
7395         * mdebugread.c (parse_partial_symbols): Update.
7396         * dwarf2read.c (create_addrmap_from_index)
7397         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7398         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7399         (add_partial_subprogram, dwarf2_ranges_read): Update.
7400         * dwarf-index-write.c (write_address_map)
7401         (write_one_signatured_type, recursively_write_psymbols)
7402         (class debug_names, class debug_names, write_psymtabs_to_index):
7403         Update.
7404
7405 2019-01-10  Tom Tromey  <tom@tromey.com>
7406
7407         * symtab.h (SYMBOL_SET_NAMES): Update.
7408         (symbol_set_names): Update.
7409         (MSYMBOL_SET_NAMES): Update.
7410         * symtab.c (symbol_set_names): Change argument to be an
7411         objfile_per_bfd_storage.
7412         * psymtab.c (add_psymbol_to_bcache): Update.
7413         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7414
7415 2019-01-10  Tom Tromey  <tom@tromey.com>
7416
7417         * symtab.c (create_demangled_names_hash): Change argument to be an
7418         objfile_per_bfd_storage.
7419         (symbol_set_names): Update.
7420
7421 2019-01-10  Tom Tromey  <tom@tromey.com>
7422
7423         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7424         init_psymbol_list.
7425         * psymtab.c (init_psymbol_list): Do nothing if already called.
7426         * psympriv.h (init_psymbol_list): Add comment.
7427         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7428         init_psymbol_list.
7429         * dbxread.c (dbx_symfile_read): Unconditionally call
7430         init_psymbol_list.
7431
7432 2019-01-10  Tom Tromey  <tom@tromey.com>
7433
7434         * xcoffread.c (scan_xcoff_symtab): Update.
7435         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7436         "where".
7437         * mdebugread.c (parse_partial_symbols)
7438         (handle_psymbol_enumerators): Update.
7439         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7440         * dbxread.c (read_dbx_symtab): Update.
7441         * psympriv.h (psymbol_placement): New enum.
7442         (add_psymbol_to_list): Update.
7443
7444 2019-01-10  Tom Tromey  <tom@tromey.com>
7445
7446         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7447         static_psymbols parameters.
7448         (scan_xcoff_symtab): Update.
7449         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7450         static_psymbols parameters.
7451         * psympriv.h (start_psymtab_common): Update.
7452         * mdebugread.c (parse_partial_symbols): Update.
7453         * dwarf2read.c (create_partial_symtab): Update.
7454         * dbxread.c (read_dbx_symtab): Update.
7455         (start_psymtab): Remove global_psymbols and static_psymbols
7456         parameters.
7457
7458 2019-01-10  Tom Tromey  <tom@tromey.com>
7459
7460         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7461         * psymtab.c (allocate_psymtab): Add comment.
7462         * psympriv.h (allocate_psymtab): Add comment.
7463         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7464         initializations.
7465         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7466
7467 2019-01-10  Tom Tromey  <tom@tromey.com>
7468
7469         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7470         Don't declare.
7471         * mipsread.c: Include mdebugread.h.
7472         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7473         Declare.
7474         * elfread.c: Include mdebugread.h.
7475
7476 2019-01-09  Tom Tromey  <tom@tromey.com>
7477
7478         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7479         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7480         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7481         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7482         (psym_lookup_symbol, psym_find_last_source_symtab)
7483         (psym_forget_cached_source_info, psym_print_stats)
7484         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7485         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7486         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7487         (psym_find_compunit_symtab_by_address)
7488         (maintenance_print_psymbols, maintenance_info_psymtabs)
7489         (maintenance_check_psymtabs): Use ranged for.
7490         * psymtab.h (class objfile_psymtabs): New.
7491         (require_partial_symbols): Return objfile_psymtabs.
7492         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7493
7494 2019-01-09  Tom Tromey  <tom@tromey.com>
7495
7496         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7497         (find_pc_mapped_section, list_overlays_command)
7498         (map_overlay_command, unmap_overlay_command)
7499         (simple_overlay_update): Use all_objfiles.
7500         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7501         * printcmd.c (info_symbol_command): Use all_objfiles.
7502         * objfiles.h (ALL_OBJSECTIONS): Remove.
7503         * maint.c (maintenance_translate_address): Use all_objfiles.
7504         * gcore.c (gcore_create_callback): Use all_objfiles.
7505         (objfile_find_memory_regions): Likewise.
7506
7507 2019-01-09  Tom Tromey  <tom@tromey.com>
7508
7509         * symtab.c (find_line_symtab, info_sources_command)
7510         (make_source_files_completion_list): Use objfile_compunits.
7511         * source.c (select_source_symtab): Use objfile_compunits.
7512         * objfiles.h (struct objfile): Update comment.
7513         (ALL_OBJFILES): Remove.
7514         (ALL_FILETABS): Remove.
7515         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7516         objfile_compunits.
7517
7518 2019-01-09  Tom Tromey  <tom@tromey.com>
7519
7520         * symmisc.c (print_objfile_statistics, dump_objfile)
7521         (maintenance_print_symbols): Use compunit_filetabs.
7522         * source.c (forget_cached_source_info_for_objfile): Use
7523         compunit_filetabs.
7524         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7525         (ALL_FILETABS): Use compunit_filetabs.
7526         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7527         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7528
7529 2019-01-09  Tom Tromey  <tom@tromey.com>
7530
7531         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7532         (compunit_filetabs): New.
7533         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7534         compunit_filetabs.
7535         (info_sources_command, make_source_files_completion_list): Remove
7536         declaration.
7537         * symmisc.c (print_objfile_statistics, dump_objfile)
7538         (maintenance_print_symbols): Remove declaration.
7539         (maintenance_info_symtabs): Use compunit_filetabs.
7540         (maintenance_info_line_tables): Likewise.
7541         * source.c (select_source_symtab): Change local variable name.
7542         (forget_cached_source_info_for_objfile): Remove declaration.
7543         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7544         * objfiles.c (objfile_relocate1): Remove declaration.
7545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7546         declaration.
7547         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7548         * coffread.c (coff_symtab_read): Remove declaration.
7549         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7550         compunit_filetabs.
7551
7552 2019-01-09  Tom Tromey  <tom@tromey.com>
7553
7554         * symtab.c (lookup_objfile_from_block)
7555         (find_pc_sect_compunit_symtab, search_symbols)
7556         (default_collect_symbol_completion_matches_break_on): Use
7557         objfile_compunits.
7558         * objfiles.h (ALL_COMPUNITS): Remove.
7559         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7560         * cp-support.c (add_symbol_overload_list_qualified): Use
7561         objfile_compunits.
7562         * ada-lang.c (ada_collect_symbol_completion_matches)
7563         (ada_add_global_exceptions): Use objfile_compunits.
7564
7565 2019-01-09  Tom Tromey  <tom@tromey.com>
7566
7567         * source.c (select_source_symtab)
7568         (forget_cached_source_info_for_objfile): Remove declaration.
7569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7570         declaration.
7571         * maint.c (count_symtabs_and_blocks): Remove declaration.
7572         * cp-support.c (add_symbol_overload_list_qualified): Remove
7573         declaration.
7574         * coffread.c (coff_symtab_read): Remove declaration.
7575         * symtab.c (lookup_symbol_in_objfile_symtabs)
7576         (basic_lookup_transparent_type_1): Use objfile_compunits.
7577         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7578         (info_sources_command, search_symbols)
7579         (default_collect_symbol_completion_matches_break_on)
7580         (make_source_files_completion_list): Remove declaration.
7581         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7582         (ada_collect_symbol_completion_matches)
7583         (ada_add_global_exceptions): Remove declaration.
7584         * linespec.c (iterate_over_all_matching_symtabs): Use
7585         objfile_compunits.
7586         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7587         (class objfile_compunits): New.
7588         (ALL_COMPUNITS): Use objfile_compunits.
7589         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7590         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7591         objfile_compunits.
7592         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7593
7594 2019-01-09  Tom Tromey  <tom@tromey.com>
7595
7596         * symtab.c (search_symbols)
7597         (default_collect_symbol_completion_matches_break_on): Use
7598         objfile_msymbols.
7599         * ada-lang.c (ada_lookup_simple_minsym)
7600         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7601         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7602         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7603         objfile_msymbols.
7604         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7605         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7606         * objc-lang.c (find_methods): Use objfile_msymbols.
7607         (info_selectors_command, info_classes_command): Likewise.
7608         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7609         * objfiles.h (class objfile_msymbols): New.
7610         (ALL_OBJFILE_MSYMBOLS): Remove.
7611         (ALL_MSYMBOLS): Remove.
7612
7613 2019-01-09  Tom Tromey  <tom@tromey.com>
7614
7615         * common/next-iterator.h (next_adapter): Add Iterator template
7616         parameter.
7617         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7618         (class all_objfiles_safe): New.
7619         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7620         * objfiles.c (put_objfile_before): Update comment.
7621         (add_separate_debug_objfile): Likewise.
7622         (free_all_objfiles): Use all_objfiles_safe.
7623         (objfile_purge_solibs): Likewise.
7624
7625 2019-01-09  Tom Tromey  <tom@tromey.com>
7626
7627         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7628         (expand_symtab_containing_pc, lookup_static_symbol)
7629         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7630         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7631         all_objfiles.
7632         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7633         * breakpoint.c (create_overlay_event_breakpoint)
7634         (create_longjmp_master_breakpoint)
7635         (create_std_terminate_master_breakpoint)
7636         (create_exception_master_breakpoint): Use all_objfiles.
7637         * linux-thread-db.c (try_thread_db_load_from_pdir)
7638         (has_libpthread): Use all_objfiles.
7639         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7640         * linespec.c (iterate_over_all_matching_symtabs)
7641         (search_minsyms_for_name): Use all_objfiles.
7642         * maint.c (maintenance_info_sections): Use all_objfiles.
7643         * main.c (captured_main_1): Use all_objfiles.
7644         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7645         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7646         * guile/scm-pretty-print.c
7647         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7648         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7649         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7650         (maintenance_print_msymbols): Use all_objfiles.
7651         * source.c (select_source_symtab): Use all_objfiles.
7652         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7653         * symfile.c (remove_symbol_file_command)
7654         (expand_symtabs_matching, map_symbol_filenames): Use
7655         all_objfiles.
7656         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7657         all_objfiles.
7658         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7659         * objc-lang.c (find_methods): Use all_objfiles.
7660         * objfiles.c (have_partial_symbols, have_full_symbols)
7661         (have_minimal_symbols, qsort_cmp)
7662         (default_iterate_over_objfiles_in_search_order): Use
7663         all_objfiles.
7664         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7665         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7666         (maintenance_check_psymtabs): Use all_objfiles.
7667         (ALL_PSYMTABS): Remove.
7668         * compile/compile-object-run.c (do_module_cleanup): Use
7669         all_objfiles.
7670         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7671         * cp-support.c (add_symbol_overload_list_qualified): Use
7672         all_objfiles.
7673         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7674         Use all_objfiles.
7675         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7676         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7677         all_objfiles.
7678         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7679         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7680         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7681         Uses all_objfiles.
7682         * solib.c (solib_read_symbols): Use all_objfiles
7683
7684 2019-01-09  Tom Tromey  <tom@tromey.com>
7685
7686         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7687         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7688         all_objfiles.
7689         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7690         * symmisc.c (print_symbol_bcache_statistics)
7691         (print_objfile_statistics, maintenance_print_objfiles)
7692         (maintenance_info_symtabs, maintenance_check_symtabs)
7693         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7694         all_objfiles.
7695         * source.c (forget_cached_source_info): Use all_objfiles.
7696         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7697         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7698         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7699         * objfiles.c (update_section_map): Use all_objfiles.
7700         (shared_objfile_contains_address_p): Likewise.
7701         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7702         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7703
7704 2019-01-09  Tom Tromey  <tom@tromey.com>
7705
7706         * common/next-iterator.h: New file.
7707         * objfiles.h (class all_objfiles): New.
7708         (struct objfile_iterator): New.
7709
7710 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7711
7712         * NEWS: Move the description of the changed "frame", "select-frame",
7713          and "info frame" commands to the Changed commands section.
7714
7715 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7716
7717         * gdbtypes.c (check_stub_method_group): Remove handling of old
7718         mangling schemes.
7719         * linespec.c (find_methods): Likewise.
7720         * stabsread.c (read_member_functions): Likewise.
7721         * valops.c (search_struct_method): Likewise.
7722         (value_struct_elt_for_reference): Likewise.
7723         * NEWS: Mention this change.
7724
7725 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7726
7727         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7728         print_source_lines.
7729         * source.c (print_source_lines_base): Update line number check.
7730         (print_source_lines): New function.
7731         (source_lines_range::source_lines_range): New function.
7732         * source.h (class source_lines_range): New class.
7733         (print_source_lines): New declaration.
7734
7735 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7736
7737         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7738
7739 2019-01-08  Tom Tromey  <tom@tromey.com>
7740             Simon Marchi  <simon.marchi@ericsson.com>
7741
7742         PR gdb/24060
7743         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7744         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7745         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7746         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7747         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7748         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7749
7750 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * source.c (select_source_symtab): Move header comment to
7753         declaration in source.h.
7754         (forget_cached_source_info_for_objfile): Likewise.
7755         (forget_cached_source_info): Likewise.
7756         (identify_source_line): Likewise.
7757         * source.h (identify_source_line): Move declaration from symtab.h
7758         and add comment from source.c
7759         (print_source_lines): Likewise.
7760         (forget_cached_source_info_for_objfile): Likewise.
7761         (forget_cached_source_info): Likewise.
7762         (select_source_symtab): Likewise.
7763         (enum print_source_lines_flag): Move definition from symtab.h.
7764         * symtab.h (identify_source_line): Move declaration to source.h.
7765         (print_source_lines): Likewise.
7766         (forget_cached_source_info_for_objfile): Likewise.
7767         (forget_cached_source_info): Likewise.
7768         (select_source_symtab): Likewise.
7769         (enum print_source_lines_flag): Move definition to source.h.
7770         * tui/tui-hooks.c: Add 'source.h' include.
7771
7772 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7773
7774         * source.c (print_source_lines_base): Handle requests to print
7775         reverse line number sequences, and guard against empty lines
7776         string.
7777
7778 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7779
7780         * source.c (print_source_lines_base): Fix skip of '\r' if next
7781         character is '\n'.
7782
7783 2019-01-06  Tom Tromey  <tom@tromey.com>
7784
7785         * c-exp.y (struct c_parse_state) <macro_original_text,
7786         expansion_obstack>: New member.
7787         (macro_original_text, expansion_obstack): Remove globals.
7788         (scan_macro_expansion, scanning_macro_expansion)
7789         (finished_macro_expansion): Update.
7790         (scan_macro_cleanup): Remove.
7791         (yylex, c_parse): Update.
7792
7793 2019-01-06  Tom Tromey  <tom@tromey.com>
7794
7795         * c-exp.y (struct c_parse_state) <strings>: New member.
7796         (operator_stoken): Update.
7797
7798 2019-01-06  Tom Tromey  <tom@tromey.com>
7799
7800         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7801         (union type_stack_elt) <typelist_val>: Now a pointer to
7802         std::vector.
7803         (type_stack_cleanup): Don't declare.
7804         (push_typelist): Update.
7805         * parse.c (pop_typelist): Return a std::vector.
7806         (push_typelist): Take a std::vector.
7807         (follow_types): Update.  Do not free args.
7808         (type_stack_cleanup): Remove.
7809         * c-exp.y (struct c_parse_state): New.
7810         (cpstate): New global.
7811         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7812         (nonempty_typelist): Update.
7813         (func_mod): Create a new vector.
7814         (c_parse): Create a c_parse_state.
7815         (check_parameter_typelist): Do not delete params.
7816         (function_method): Update.  Do not delete type_list.
7817
7818 2019-01-06  Tom Tromey  <tom@tromey.com>
7819
7820         PR gdb/28155:
7821         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7822         check_typedef.
7823         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7824         (print_return_value): Likewise.
7825
7826 2019-01-05  Tom Tromey  <tom@tromey.com>
7827
7828         * contrib/cleanup_check.py: Remove.
7829         * contrib/gcc-with-excheck: Remove.
7830         * contrib/exsummary.py: Remove.
7831         * contrib/excheck.py: Remove.
7832
7833 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7834
7835         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7836         NULL. Initialize tpprev to NULL instead of assigning it
7837         to NULL on the next statement.
7838         * windows-nat.c (windows_delete_thread): Remove check for
7839         main_thread_id before printing thread exit notifications.
7840         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7841         Remove thread ID check against main_thread_id.
7842         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7843         windows_delete_thread.
7844         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7845
7846 2019-01-04  Tom Tromey  <tom@tromey.com>
7847
7848         * compile/compile.c (_initialize_compile): Use upper case for
7849         metasyntactic variables.
7850         * symmisc.c (_initialize_symmisc): Use upper case for
7851         metasyntactic variables.
7852         * psymtab.c (_initialize_psymtab): Use upper case for
7853         metasyntactic variables.
7854         * demangle.c (demangle_command): Use upper case for metasyntactic
7855         variables.
7856         (_initialize_demangler): Likewise.
7857         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7858         variables.
7859
7860 2019-01-03  Tom Tromey  <tom@tromey.com>
7861
7862         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7863
7864 2019-01-03  Tom Tromey  <tom@tromey.com>
7865
7866         * python/py-symtab.c (salpy_str): Update.
7867         (struct salpy_sal_object) <symtab>: Now a PyObject.
7868         (salpy_dealloc): Update.
7869         (del_objfile_sal): Use gdbpy_ref.
7870
7871 2019-01-03  Tom Tromey  <tom@tromey.com>
7872
7873         * python/py-type.c (convert_field): Use new_reference.  Return
7874         gdbpy_ref.
7875         (make_fielditem): Return gdbpy_ref.
7876         (typy_fields): Update.
7877         (typy_getitem): Update.
7878         (field_name): Return gdbpy_ref.  Use new_reference.
7879         (typy_iterator_iternext): Update.
7880
7881 2019-01-03  Tom Tromey  <tom@tromey.com>
7882
7883         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7884
7885 2019-01-03  Tom Tromey  <tom@tromey.com>
7886
7887         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7888         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7889         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7890         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7891         (pspy_set_type_printers): Likewise.
7892         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7893         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7894         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7895         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7896         (objfpy_set_type_printers): Likewise.
7897
7898 2019-01-03  Tom Tromey  <tom@tromey.com>
7899
7900         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7901         (gdbpy_print_stack): Use gdbpy_err_fetch.
7902         * python/python-internal.h (class gdbpy_err_fetch): New class.
7903         (class gdbpy_enter) <m_error_type, m_error_value,
7904         m_error_traceback>: Remove.
7905         <m_error>: New member.
7906         (gdbpy_exception_to_string): Don't declare.
7907         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7908         * python/py-value.c (convert_value_from_python): Use
7909         gdbpy_err_fetch.
7910         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7911         gdbpy_exception_to_string.
7912         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7913         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7914         gdbpy_err_fetch.
7915
7916 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7917
7918         * linux-nat.c (delete_lwp_cleanup): Delete.
7919         (struct lwp_deleter): New struct.
7920         (lwp_info_up): New typedef.
7921         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7922         lwp_info_up.
7923
7924 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7925
7926         * linux-fork.c (class scoped_switch_fork_info): New class.
7927         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7928
7929 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * valops.c (find_overload_match): Remove use of null_cleanup, and
7932         calls to do_cleanups.
7933
7934 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7935
7936         * compile/compile-cplus-types.c
7937         (compile_cplus_instance::decl_name): Handle changes to
7938         cp_func_name.
7939         * cp-support.c (cp_func_name): Update header comment, update
7940         return type.
7941         * cp-support.h (cp_func_name): Update return type in declaration.
7942         * valops.c (find_overload_match): Move temp_func local to top
7943         level of function and change its type.  Use temp_func to hold and
7944         delete temporary string obtained from cp_func_name.
7945
7946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7947
7948         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7949         gdb::char_vector, remove cleanup, and update uses of `msg`.
7950
7951 2019-01-03  Jim Wilson  <jimw@sifive.com>
7952
7953         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7954
7955 2019-01-02  Tom Tromey  <tom@tromey.com>
7956
7957         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7958         (tdesc_parse_xml): Remove cleanups.
7959         * target-descriptions.h (make_cleanup_free_target_description):
7960         Don't declare.
7961         (target_desc_deleter): New struct.
7962         (target_desc_up): New typedef.
7963         * target-descriptions.c (target_desc_deleter::operator()): Rename
7964         from free_target_description.
7965         (make_cleanup_free_target_description): Remove.
7966
7967 2019-01-02  Tom Tromey  <tom@tromey.com>
7968
7969         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7970         constructor, destructor.
7971         (linespec_parser): Remove typedef.
7972         (~linespec_parser): Rename from linespec_parser_delete.
7973         (linespec_lex_to_end, linespec_complete_label)
7974         (linespec_complete): Update.
7975         (decode_line_full): Remove cleanups.
7976         (decode_line_1): Update.
7977
7978 2019-01-02  Tom Tromey  <tom@tromey.com>
7979
7980         * python/python-internal.h (inferior_to_inferior_object): Change
7981         return type.
7982         * python/py-exitedevent.c (create_exited_event_object): Update.
7983         * python/py-inferior.c (inferior_to_inferior_object): Return
7984         gdbpy_ref.
7985         (python_new_inferior, python_inferior_deleted)
7986         (thread_to_thread_object, delete_thread_object)
7987         (build_inferior_list, gdbpy_selected_inferior): Update.
7988         * python/py-infthread.c (create_thread_object): Update.  Also fail
7989         if inferior_to_inferior_object fails.
7990
7991 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7992
7993         * inferior.h (class inferior) <displaced_step_state>: New field.
7994         * infrun.h (struct displaced_step_state): Move here from
7995         infrun.c.  Initialize fields, add constructor.
7996         <inf>: Remove field.
7997         <reset>: New method.
7998         * infrun.c (struct displaced_step_inferior_state): Move to
7999         infrun.h.
8000         (displaced_step_inferior_states): Remove.
8001         (get_displaced_stepping_state): Adust.
8002         (displaced_step_in_progress_any_inferior): Adjust.
8003         (displaced_step_in_progress_thread): Adjust.
8004         (displaced_step_in_progress): Adjust.
8005         (add_displaced_stepping_state): Remove.
8006         (get_displaced_step_closure_by_addr): Adjust.
8007         (remove_displaced_stepping_state): Remove.
8008         (infrun_inferior_exit): Call displaced_step_state.reset.
8009         (use_displaced_stepping): Don't check for NULL.
8010         (displaced_step_prepare_throw): Call
8011         get_displaced_stepping_state.
8012         (displaced_step_fixup): Don't check for NULL.
8013         (prepare_for_detach): Don't check for NULL.
8014
8015 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8016
8017         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8018          in case of call that did not complete.
8019
8020 2019-01-02  Andrey Utkin  <autkin@undo.io>
8021
8022         * symfile.c (find_separate_debug_file): Fix search of debug files for
8023         remote debuggee.
8024
8025 2019-01-02  Tom Tromey  <tom@tromey.com>
8026
8027         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8028         indentation.
8029         * python/py-frame.c (frapy_older): Remove cast.
8030         (frapy_newer): Likewise.
8031         * python/py-breakpoint.c (local_setattro): Remove cast.
8032         * python/py-arch.c (archpy_name): Remove local variable.
8033         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8034
8035 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8036
8037         * unittests/basic_string_view/element_access/char/empty.cc:
8038         Fix year range in copyright header.
8039
8040 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8043         Delete.
8044         <operator==>: Update with for removed field.
8045         <hash>: Likewise.
8046         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8047         <isa_features>: ...this.
8048         <abi_features>: New field.
8049         (riscv_isa_flen): Update comment.
8050         (riscv_abi_xlen): New declaration.
8051         (riscv_abi_flen): New declaration.
8052         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8053         isa_features.
8054         (riscv_abi_xlen): New function.
8055         (riscv_isa_flen): Update to get answer from isa_features.
8056         (riscv_abi_flen): New function.
8057         (riscv_has_fp_abi): Update to get answer from abi_features.
8058         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8059         xlen and flen.
8060         (riscv_call_info) <xlen, flen>: Update comment.
8061         (riscv_call_arg_struct): Remove invalid assertions
8062         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8063         is removed.
8064         (riscv_gdbarch_init): Gather isa features and abi features
8065         separately, ensure both match on the gdbarch when reusing an old
8066         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8067         a target with 64-bit float hardware.
8068
8069 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8070
8071         * source.c (search_command_helper): Stop reverse search
8072         when line 1 has been searched.
8073
8074 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8075
8076         * record-full.c (record_full_base_target::close): Rewrite
8077         record_full_core_buf_list free logic.
8078
8079 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8080
8081         * break-catch-syscall.c (print_one_catch_syscall): xfree
8082         the last text.
8083
8084 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8085
8086         * top.c (print_gdb_version): Update Copyright year in version
8087         message.
8088
8089 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8090
8091         Update copyright year range in all GDB files.
8092
8093 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8094
8095         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8096
8097 For older changes see ChangeLog-2018.
8098 \f
8099 Local Variables:
8100 mode: change-log
8101 left-margin: 8
8102 fill-column: 74
8103 version-control: never
8104 coding: utf-8
8105 End:
8106