gdb/ChangeLog

   1 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
   4         <per_objfile>: New member.
   5         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
   6         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
   7         call to dwarf2_cu.
   8         (cutu_reader::cutu_reader): Update.
   9         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
  10
  11 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
  12
  13         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
  14         struct dwarf2_per_objfile.
  15         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
  16         dwarf2_per_bfd.
  17         * dwarf2/read.c (set_die_type): Update.
  18         (get_die_type_at_offset): Update.
  19
  20 2020-05-27  Tom Tromey  <tom@tromey.com>
  21             Simon Marchi  <simon.marchi@efficios.com>
  22
  23         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
  24         method.
  25         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
  26         get_symtab, set_symtab>: New methods.
  27         <m_symtabs>: New field.
  28         (struct dwarf2_psymtab): Derive from partial_symtab.
  29         <readin_p, get_compunit_symtab>: Declare methods.
  30         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
  31         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
  32         New methods.
  33         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
  34         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
  35         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
  36         (dw2_symtab_iter_next, dw2_print_stats)
  37         (dw2_expand_symtabs_with_fullname)
  38         (dw2_expand_symtabs_matching_one)
  39         (dw_expand_symtabs_matching_file_matcher)
  40         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
  41         (dw2_debug_names_iterator::next)
  42         (dw2_debug_names_map_matching_symbols)
  43         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
  44         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
  45         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
  46         New methods.
  47         (get_compunit_symtab, process_full_comp_unit)
  48         (process_full_type_unit): Update.
  49         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
  50
  51 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
  52
  53         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
  54         then introduce a new dwarf2_per_objfile type.
  55         <read_line_string>: Move to the new dwarf2_per_objfile type.
  56         <objfile>: Likewise.
  57         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
  58         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
  59         dwarf2_per_objfile->per_bfd.
  60         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
  61         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
  62         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
  63         (dwarf2_per_bfd::free_cached_comp_units): ... this.
  64         (dwarf2_has_info): Allocate dwarf2_per_bfd.
  65         (dwarf2_per_objfile::locate_sections): Rename to...
  66         (dwarf2_per_bfd::locate_sections): ... this.
  67         (dwarf2_per_objfile::get_cutu): Rename to...
  68         (dwarf2_per_bfd::get_cutu): ... this.
  69         (dwarf2_per_objfile::get_cu): Rename to...
  70         (dwarf2_per_bfd::get_cu): ... this.
  71         (dwarf2_per_objfile::get_tu): Rename to...
  72         (dwarf2_per_bfd::get_tu): ... this.
  73         (dwarf2_per_objfile::allocate_per_cu): Rename to...
  74         (dwarf2_per_bfd::allocate_per_cu): ... this.
  75         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
  76         (dwarf2_per_bfd::allocate_signatured_type): ... this.
  77         (get_gdb_index_contents_ftype): Change parameter from
  78         dwarf2_per_objfile to dwarf2_per_bfd.
  79         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
  80         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
  81
  82 2020-05-27  Tom Tromey  <tom@tromey.com>
  83             Simon Marchi  <simon.marchi@efficios.com>
  84
  85         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
  86         (allocate_piece_closure): Set "per_objfile" member.
  87         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
  88         (locexpr_describe_location, loclist_describe_location): Use new
  89         member.
  90         * dwarf2/read.c (read_call_site_scope)
  91         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
  92         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
  93         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
  94         handle_data_member_location): Set per_objfile member.
  95         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
  96         member.
  97         (struct dwarf2_loclist_baton) <per_objfile>: New member.
  98
  99 2020-05-27  Tom Tromey  <tom@tromey.com>
 100
 101         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
 102         allocate_signatured_type>: Declare new methods.
 103         <m_num_psymtabs>: New member.
 104         (struct dwarf2_per_cu_data) <index>: New member.
 105         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
 106         (dwarf2_per_objfile::allocate_signatured_type): New methods.
 107         (create_cu_from_index_list): Use allocate_per_cu.
 108         (create_signatured_type_table_from_index)
 109         (create_signatured_type_table_from_debug_names)
 110         (create_debug_type_hash_table, add_type_unit)
 111         (read_comp_units_from_section): Use allocate_signatured_type.
 112
 113 2020-05-27  Tom Tromey  <tom@tromey.com>
 114
 115         * psymtab.c (partial_map_expand_apply)
 116         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
 117         (psym_lookup_global_symbol_language)
 118         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
 119         (psym_print_stats, psym_expand_symtabs_for_function)
 120         (psym_map_symbol_filenames, psym_map_matching_symbols)
 121         (psym_expand_symtabs_matching)
 122         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
 123         (maintenance_check_psymtabs): Update.
 124         * psympriv.h (struct partial_symtab) <readin_p,
 125         get_compunit_symtab>: Add objfile parameter.
 126         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
 127         Likewise.
 128         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
 129         get_compunit_symtab>: Likewise.
 130         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
 131
 132 2020-05-27  Tom Tromey  <tom@tromey.com>
 133
 134         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
 135         member.
 136         * dwarf2/read.c (delete_file_name_entry): Fix comment.
 137         (create_cu_from_index_list)
 138         (create_signatured_type_table_from_index)
 139         (create_signatured_type_table_from_debug_names)
 140         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
 141         (dwarf2_create_include_psymtab)
 142         (create_debug_type_hash_table, add_type_unit)
 143         (create_type_unit_group, read_comp_units_from_section)
 144         (dwarf2_compute_name, create_cus_hash_table)
 145         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
 146         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
 147         obstack.
 148         (dw2_get_real_path): Likewise.  Change argument to
 149         dwarf2_per_objfile.
 150
 151 2020-05-27  Luis Machado  <luis.machado@linaro.org>
 152
 153         PR tdep/26000
 154         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
 155         for ldrd (immediate).
 156
 157 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 158
 159         * command.h: Add comment giving the name of class_tui.
 160         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
 161         create the fake command for the help for class_tui.
 162
 163 2020-05-26  Tom Tromey  <tromey@adacore.com>
 164
 165         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
 166         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
 167         (val_atr): New function.
 168         (value_val_atr): Use it.
 169         * ada-valprint.c (print_optional_low_bound): Change low bound
 170         handling for enums.
 171         (val_print_packed_array_elements): Don't call discrete_position.
 172         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
 173         discrete_position for enum types.
 174         * language.c (default_print_array_index): Change type.
 175         * language.h (struct language_defn) <la_print_array_index>: Add
 176         index_type parameter, change type of index_value.
 177         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
 178         (default_print_array_index): Update.
 179         * valprint.c (maybe_print_array_index): Don't call
 180         value_from_longest.  Update.
 181         (value_print_array_elements): Don't call discrete_position.
 182
 183 2020-05-26  Tom Tromey  <tromey@adacore.com>
 184
 185         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
 186         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
 187
 188 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
 189
 190         PR gdb/13519
 191         * avr-tdep.c (avr_integer_to_address): Return data or code
 192         address accordingly to the second 'type' argument of the
 193         function.
 194
 195 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
 196
 197         * infcmd.c, inferior.h: (construct_inferior_arguments):
 198         Moved function from here to gdbsupport/common-inferior.{h,cc}
 199
 200 2020-05-23  Tom Tromey  <tom@tromey.com>
 201
 202         Revert commit eca1f90c:
 203         * NEWS: Remove entry for completion styling.
 204         * completer.c (_rl_completion_prefix_display_length): Move
 205         declaration later.
 206         (gdb_fnprint): Revert.
 207         (gdb_display_match_list_1): Likewise.
 208         * cli/cli-style.c (completion_prefix_style)
 209         (completion_difference_style, completion_suffix_style): Remove.
 210         (_initialize_cli_style): Revert.
 211         * cli/cli-style.h (completion_prefix_style)
 212         (completion_difference_style, completion_suffix_style): Don't
 213         declare.
 214
 215 2020-05-24  Pedro Alves  <palves@redhat.com>
 216
 217         * symtab.c (completion_list_add_name): Return boolean indication
 218         of whether the symbol matched.
 219         (completion_list_add_symbol): Don't try to remove C++ aliases if
 220         the symbol didn't match in the first place.
 221         * symtab.h (completion_list_add_name): Return bool.
 222
 223 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
 224
 225         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
 226         type::field.
 227
 228 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
 229
 230         GDB 9.2 released.
 231
 232 2020-05-23  Tom Tromey  <tom@tromey.com>
 233
 234         * NEWS: Add entry for completion styling.
 235         * completer.c (_rl_completion_prefix_display_length): Move
 236         declaration earlier.
 237         (gdb_fnprint): Use completion_style.
 238         (gdb_display_match_list_1): Likewise.
 239         * cli/cli-style.c (completion_prefix_style)
 240         (completion_difference_style, completion_suffix_style): New
 241         globals.
 242         (_initialize_cli_style): Register new globals.
 243         * cli/cli-style.h (completion_prefix_style)
 244         (completion_difference_style, completion_suffix_style): Declare.
 245
 246 2020-05-23  Pedro Alves  <palves@redhat.com>
 247
 248         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
 249         (parse_escape): Use ISDIGIT instead of isdigit.
 250         (puts_debug): Use gdb_isprint instead of isprint.
 251         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
 252         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
 253         ISSPACE instead of isspace.
 254         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
 255         instead of isspace.
 256         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
 257         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
 258         instead of isxdigit and ISDIGIT instead of isdigit.
 259
 260 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
 261
 262         * gdbtypes.h (struct type) <field>: New method.
 263         (TYPE_FIELDS): Remove, replace all uses with either type::fields
 264         or type::field.
 265
 266 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
 267
 268         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
 269         (TYPE_FIELDS): Use type::fields.  Change all call sites that
 270         modify the propery to use type::set_fields instead.
 271
 272 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
 275         type::num_fields instead.
 276
 277 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
 278
 279         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
 280         methods.
 281         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
 282         that modify the number of fields to use type::set_num_fields
 283         instead.
 284
 285 2020-05-22  Tom Tromey  <tromey@adacore.com>
 286
 287         * compile/compile-object-load.h (munmap_list_free): Don't
 288         declare.
 289
 290 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 291
 292         * annotate.c (annotate_source_line): Update return type, add call
 293         to update current symtab and line.
 294         * annotate.h (annotate_source_line): Update return type, and
 295         extend header comment.
 296         * source.c (info_line_command): Check annotation_level before
 297         calling annotate_source_line.
 298         * stack.c (print_frame_info): If calling annotate_source_line
 299         returns true, then don't print any other source line information.
 300
 301 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
 302
 303         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
 304
 305 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
 306
 307         * coffread.c (patch_type): Remove NULL check before xfree.
 308         * corefile.c (set_gnutarget): Likewise.
 309         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
 310         * exec.c (build_section_table): Likewise.
 311         * remote.c (remote_target::pass_signals): Likewise.
 312         * utils.c (n_spaces): Likewise.
 313         * cli/cli-script.c (document_command): Likewise.
 314         * i386-windows-tdep.c (core_process_module_section): Likewise.
 315         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
 316
 317 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
 318
 319         * symfile.c (reread_symbols): Clear objfile's section_offsets
 320         vector and section indices, re-compute them by calling
 321         sym_offsets.
 322
 323 2020-05-20  Tom Tromey  <tromey@adacore.com>
 324
 325         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
 326         (desc_one_bound, desc_index_type): Compute field name.
 327
 328 2020-05-20  Tom de Vries  <tdevries@suse.de>
 329
 330         PR symtab/25833
 331         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
 332
 333 2020-05-20  Alan Modra  <amodra@gmail.com>
 334
 335         PR 25993
 336         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
 337         bfd_set_filename.
 338         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
 339         passed to bfd_set_filename.
 340         * symfile-mem.c (add_vsyscall_page): Likewise for string
 341         passed to symbol_file_add_from_memory.
 342         (symbol_file_add_from_memory): Make name param a const char* and
 343         don't strdup.
 344
 345 2020-05-20  Alan Modra  <amodra@gmail.com>
 346
 347         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
 348         rather than accessing bfd->filename directly.
 349         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
 350         and use bfd_section_name.
 351         * dwarf2/frame.c (decode_frame_entry): Likewise.
 352         * exec.c (exec_set_section_address): Likewise.
 353         * solib-aix.c (solib_aix_bfd_open): Likewise.
 354         * stap-probe.c (get_stap_base_address): Likewise.
 355         * symfile.c (reread_symbols): Likewise.
 356
 357 2020-05-19  Tom Tromey  <tromey@adacore.com>
 358
 359         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
 360
 361 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
 362
 363         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
 364
 365 2020-05-19  Pedro Alves  <palves@redhat.com>
 366
 367         * NEWS (set exec-file-mismatch): Adjust entry.
 368         * exec.c: Include "build-id.h".
 369         (validate_exec_file): Try to match build IDs instead of filenames.
 370         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
 371         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
 372         and pass down 'warn_if_slow'.
 373         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
 374         gdb_bfd_open_closure to pass it down.
 375         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
 376
 377 2020-05-19  Pedro Alves  <palves@redhat.com>
 378
 379         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
 380         * target.c (target_fileio_open_1): Rename to target_fileio_open
 381         and make extern.  Use bool.
 382         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
 383         (target_fileio_read_alloc_1): Adjust.
 384         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
 385         (target_fileio_open_warn_if_slow): Delete declaration.
 386
 387 2020-05-19  Pedro Alves  <palves@redhat.com>
 388
 389         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
 390         Adjust all callers.
 391
 392 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
 393
 394         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
 395         whether disp is negative.
 396
 397 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
 398
 399         * symfile.h (struct symfile_segment_data)
 400         <~symfile_segment_data>: Remove.
 401         <segment_info>: Change to std::vector.
 402         * symfile.c (default_symfile_segments): Update.
 403         * elfread.c (elf_symfile_segments): Update.
 404
 405 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
 406
 407         * symfile.h (struct symfile_segment_data) <struct segment>: New.
 408         <segments>: New.
 409         <segment_bases, segment_sizes>: Remove.
 410         * symfile.c (default_symfile_segments): Update.
 411         * elfread.c (elf_symfile_segments): Update.
 412         * remote.c (remote_target::get_offsets): Update.
 413         * solib-target.c (solib_target_relocate_section_addresses):
 414         Update.
 415
 416 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
 417
 418         * symfile.h (struct symfile_segment_data): Initialize fields.
 419         <~symfile_segment_data>: Add.
 420         (symfile_segment_data_up): New.
 421         (struct sym_fns) <sym_segments>: Return a
 422         symfile_segment_data_up.
 423         (default_symfile_segments): Return a symfile_segment_data_up.
 424         (free_symfile_segment_data): Remove.
 425         (get_symfile_segment_data): Return a symfile_segment_data_up.
 426         * symfile.c (default_symfile_segments): Likewise.
 427         (get_symfile_segment_data): Likewise.
 428         (free_symfile_segment_data): Remove.
 429         (symfile_find_segment_sections): Update.
 430         * elfread.c (elf_symfile_segments): Return a
 431         symfile_segment_data_up.
 432         * remote.c (remote_target::get_offsets): Update.
 433         * solib-target.c (solib_target_relocate_section_addresses):
 434         Update.
 435         * symfile-debug.c (debug_sym_segments): Return a
 436         symfile_segment_data_up.
 437
 438 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 439
 440         PR build/25981
 441         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
 442         Hardcode register numbers.
 443
 444         PR build/25981
 445         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
 446         procfs_find_LDT_entry): Remove.
 447         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
 448         procfs_find_LDT_entry): Remove.
 449         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
 450         Remove.
 451
 452 2020-05-17  Pedro Alves  <palves@redhat.com>
 453             Andrew Burgess  <andrew.burgess@embecosm.com>
 454             Keno Fischer  <keno@juliacomputing.com>
 455
 456         PR gdb/25741
 457         * breakpoint.c (build_target_condition_list): Update comments.
 458         (build_target_command_list): Update comments and skip matching
 459         locations.
 460         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
 461         a separate function.  Simplify "set breakpoint auto-hw off"
 462         handling.
 463         (insert_breakpoints): Update comment.
 464         (tracepoint_locations_match): New parameter.  For breakpoints,
 465         compare location types too, if the caller wants to.
 466         (handle_automatic_hardware_breakpoints): New functions.
 467         (bp_location_is_less_than): Also sort by location type and
 468         hardware breakpoint length.
 469         (update_global_location_list): Handle "set breakpoint auto-hw on"
 470         here.
 471         (update_breakpoint_locations): Ask breakpoint_locations_match to
 472         ignore location types.
 473
 474 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
 475
 476         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
 477         type::name instead.
 478
 479 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
 480
 481         * gdbtypes.h (struct type) <name, set_name>: New methods.
 482         (TYPE_CODE): Use type::name.  Change all call sites used to set
 483         the name to use type::set_name instead.
 484
 485 2020-05-16  Tom Tromey  <tom@tromey.com>
 486
 487         * top.c (quit_force): Update.
 488         * infrun.c (handle_no_resumed): Update.
 489         * top.h (all_uis): New function.
 490         (ALL_UIS): Remove.
 491
 492 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
 493
 494         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
 495
 496 2020-05-16  Pedro Alves  <palves@redhat.com>
 497
 498         * ia64-linux-nat.c
 499         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
 500         Declare method.
 501         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
 502
 503 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
 504
 505         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
 506         (sparc64_adi_info): Likewise.
 507
 508 2020-05-15  Tom Tromey  <tom@tromey.com>
 509
 510         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
 511         block_objfile.
 512         (lookup_objfile_from_block): Remove.
 513         (lookup_symbol_in_block, lookup_symbol_in_static_block)
 514         (lookup_global_symbol): Use block_objfile.
 515         * symtab.h (lookup_objfile_from_block): Don't declare.
 516         * printcmd.c (clear_dangling_display_expressions): Use
 517         block_objfile.
 518         * parse.c (operator_check_standard): Use block_objfile.
 519
 520 2020-05-15  Tom Tromey  <tom@tromey.com>
 521
 522         * language.c (language_alloc_type_symbol): Set
 523         SYMBOL_SECTION.
 524         * symtab.c (initialize_objfile_symbol): Remove.
 525         (allocate_symbol): Remove.
 526         (allocate_template_symbol): Remove.
 527         * dwarf2/read.c (fixup_go_packaging): Use "new".
 528         (new_symbol): Use "new".
 529         (read_variable): Don't call initialize_objfile_symbol.  Use
 530         "new".
 531         (read_func_scope): Use "new".
 532         * xcoffread.c (process_xcoff_symbol): Don't call
 533         initialize_objfile_symbol.
 534         (SYMBOL_DUP): Remove.
 535         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
 536         "new".
 537         * symtab.h (allocate_symbol, initialize_objfile_symbol)
 538         (allocate_template_symbol): Don't declare.
 539         (struct symbol): Add copy constructor.  Change defaults.
 540         * jit.c (finalize_symtab): Use "new".
 541         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
 542         Use "new".
 543         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
 544         (common_block_end): Use "new".
 545         * mdebugread.c (parse_symbol): Use "new".
 546         (new_symbol): Likewise.
 547
 548 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 549
 550         * NEWS: Mention changes to help and apropos.
 551
 552 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 553
 554         * command.h (enum command_class): Improve comments, document
 555         that class_alias is for user-defined aliases, give the class
 556         name for each class, remove unused class_xdb.
 557         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
 558         * breakpoint.c (_initialize_breakpoint): Replace class_alias
 559         by a precise class.
 560         * infcmd.c (_initialize_infcmd): Likewise.
 561         * reverse.c (_initialize_reverse): Likewise.
 562         * stack.c (_initialize_stack): Likewise.
 563         * symfile.c (_initialize_symfile): Likewise.
 564         * tracepoint.c (_initialize_tracepoint): Likewise.
 565
 566 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 567
 568         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
 569         when their aliased command is traversed.
 570         (help_cmd): Add fput_command_names_styled call to
 571         output command name and aliases when command has an alias.
 572
 573 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 574
 575         * cli/cli-decode.h (help_cmd_list): Remove declaration.
 576         * cli/cli-decode.c (help_cmd_list): Declare as static,
 577         remove prefix argument, use bool for recurse arg, rework to show the aliases of
 578         a command together with the command.
 579         (fput_command_name_styled, fput_command_names_styled): New functions.
 580         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
 581         fput_command_name_styled.
 582         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
 583         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
 584
 585 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 586
 587         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
 588         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
 589         * command.h (cmd_show_list): Likewise.
 590         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
 591         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
 592
 593 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 594
 595         * unittests/command-def-selftests.c (traverse_command_structure):
 596         Verify all commands of a list have the same prefix command and
 597         that only the top cmdlist commands have a null prefix.
 598
 599 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 600
 601         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
 602         as prefix, not one of its aliases.
 603         (set_cmd_prefix): Remove.
 604         (do_add_cmd): Centralize the setting of the prefix of a command, when
 605         command is defined after its full chain of prefix commands.
 606         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
 607         (add_setshow_cmd_full): Likewise.
 608         (update_prefix_field_of_prefixed_commands): New function.
 609         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
 610         update_prefix_field_of_prefixed_commands.
 611         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
 612         addresses of remote_set_cmdlist and remote_show_cmdlist given
 613         as argument, not the address of an argument.
 614         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
 615         * gdb/remote.c (_initialize_remote): Likewise.
 616
 617 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 618
 619         * cli/cli-cmds.c (alias_command): Check for an existing alias
 620         using lookup_cmd_composition, as valid_command_p is too strict
 621         and forbids aliases that are the prefix of an existing alias
 622         or command.
 623         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
 624         command is properly recognised as a valid command.
 625
 626 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 627
 628         * unittests/help-doc-selftests.c: Rename to
 629         unittests/command-def-selftests.c
 630         * unittests/command-def-selftests.c (help_doc_tests): Update some
 631         comments.
 632         (command_structure_tests, traverse_command_structure): New namespace
 633         and function.
 634         (command_structure_invariants_tests): New function.
 635         (_initialize_command_def_selftests) Renamed from
 636         _initialize_help_doc_selftests, register command_structure_invariants
 637         selftest.
 638
 639 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 640
 641         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
 642         an alias of 'show'.
 643
 644 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
 645
 646         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
 647         ada_is_fixed_point_type.  Update all callers.
 648         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
 649         all callers.
 650         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
 651         Update all callers.
 652         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
 653         print_fixed_point_type.  Update all callers.
 654         * ada-valprint.c (ada_value_print_num): Replace call to
 655         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
 656
 657 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
 658
 659         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
 660         processors.
 661         (cpu_supports_bts): Add CV_AMD case.
 662
 663 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
 664             Simon Marchi  <simon.marchi@efficios.com>
 665
 666         * infrun.c (stop_all_threads): Collect multiple wait events at
 667         each pass.
 668
 669 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
 670
 671         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
 672         type::code instead.
 673
 674 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
 675
 676         * gdbtypes.h (struct type) <code, set_code>: New methods.
 677         (TYPE_CODE): Use type::code.  Change all call sites used to set
 678         the code to use type::set_code instead.
 679
 680 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 681             Tom de Vries  <tdevries@suse.de>
 682             Pedro Alves  <palves@redhat.com>
 683
 684         PR threads/25478
 685         * infrun.c (stop_all_threads): Do NOT ignore
 686         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
 687         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
 688         received.
 689         (handle_no_resumed): Remove code handling a live inferior with no
 690         threads.
 691         * remote.c (has_single_non_exited_thread): New.
 692         (remote_target::update_thread_list): Do not delete a thread if is
 693         the last thread of the process.
 694         * thread.c (thread_select): Call delete_exited_threads instead of
 695         prune_threads.
 696
 697 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 698
 699         * infrun.c (stop_all_threads): Enable/disable thread events of all
 700         targets.  Move a debug message denoting the end of the function
 701         into the SCOPED_EXIT block.
 702
 703 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 704
 705         * process-stratum-target.h: Include <set>.
 706         (all_non_exited_process_targets, switch_to_target_no_thread): New
 707         function declarations.
 708         * process-stratum-target.c (all_non_exited_process_targets)
 709         (switch_to_target_no_thread): New function implementations.
 710
 711 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 712
 713         * infrun.c (handle_inferior_event): Extract out a piece of code
 714         into...
 715         (mark_non_executing_threads): ...this new function.
 716
 717 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 718
 719         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
 720         use.
 721
 722 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 723
 724         * regcache.c (regcache_read_pc_protected): New function
 725         implementation that returns 0 if the PC cannot read via
 726         'regcache_read_pc'.
 727         * infrun.c (proceed): Call 'regcache_read_pc_protected'
 728         instead of 'regcache_read_pc'.
 729         (keep_going_pass_signal): Ditto.
 730
 731 2020-05-13  Tom Tromey  <tromey@adacore.com>
 732
 733         * ada-lang.c (align_value): Remove.
 734         (ada_template_to_fixed_record_type_1): Use align_up.
 735
 736 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 737
 738         * async-event.c: Update the copyright year.
 739         * async-event.h: Update the copyright year.
 740
 741 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
 742
 743         * objfiles.h (is_addr_in_objfile,
 744         shared_objfile_contains_address_p): Return bool.
 745         * objfile.c (is_addr_in_objfile,
 746         shared_objfile_contains_address_p): Return bool.
 747
 748 2020-05-11  Tom Tromey  <tromey@adacore.com>
 749
 750         * cli/cli-cmds.c (info_command): Restore.
 751         (_initialize_cli_cmds): Use add_prefix_command for "info".
 752         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
 753
 754 2020-05-11  Tom Tromey  <tromey@adacore.com>
 755
 756         * ada-lang.c (ada_value_primitive_field): Now public.
 757         * ada-lang.h (ada_value_primitive_field): Declare.
 758         * ada-valprint.c (print_field_values): Use
 759         ada_value_primitive_field for wrapper fields.
 760
 761 2020-05-11  Tom de Vries  <tdevries@suse.de>
 762
 763         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
 764         MODULE_DOMAIN.
 765
 766 2020-05-11  Tom de Vries  <tdevries@suse.de>
 767
 768         PR symtab/25941
 769         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
 770         with length 0, if not gdb-produced.
 771         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
 772
 773 2020-05-09  Tom de Vries  <tdevries@suse.de>
 774
 775         PR gdb/25955
 776         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
 777         calculation.
 778
 779 2020-05-09  Tom Tromey  <tom@tromey.com>
 780
 781         * top.c (server_command): Now bool.
 782         * top.h (server_command): Now bool.
 783
 784 2020-05-08  Tom Tromey  <tromey@adacore.com>
 785
 786         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
 787         already being processed.
 788
 789 2020-05-08  Tom Tromey  <tom@tromey.com>
 790
 791         * printcmd.c (struct display) <next>: Remove.
 792         <display>: New constructor.
 793         <exp_string>: Now a std::string.
 794         <enabled_p>: Now a bool.
 795         (display_number): Move definition earlier.
 796         (displays): Rename from display_chain.  Now a std::vector.
 797         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
 798         (display_command): Update.
 799         (do_one_display, disable_display)
 800         (enable_disable_display_command, do_enable_disable_display):
 801         Update.
 802         (free_display): Remove.
 803         (clear_displays): Rewrite.
 804         (delete_display): Update.
 805         (map_display_numbers): Use function_view.  Remove "data"
 806         parameter.  Update.
 807         (do_delete_display): Remove.
 808         (undisplay_command): Update.
 809         (do_one_display, do_displays, disable_display)
 810         (info_display_command): Update.
 811         (do_enable_disable_display): Remove.
 812         (enable_disable_display_command)
 813         (clear_dangling_display_expressions): Update.
 814
 815 2020-05-08  Tom Tromey  <tom@tromey.com>
 816
 817         * symtab.c (set_symbol_cache_size)
 818         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
 819         (maintenance_print_symbol_cache_statistics): Update.
 820         * symmisc.c (print_symbol_bcache_statistics)
 821         (print_objfile_statistics, maintenance_print_objfiles)
 822         (maintenance_info_symtabs, maintenance_check_symtabs)
 823         (maintenance_expand_symtabs, maintenance_info_line_tables):
 824         Update.
 825         * symfile-debug.c (set_debug_symfile): Update.
 826         * source.c (forget_cached_source_info): Update.
 827         * python/python.c (gdbpy_progspaces): Update.
 828         * psymtab.c (maintenance_info_psymtabs): Update.
 829         * probe.c (parse_probes): Update.
 830         * linespec.c (iterate_over_all_matching_symtabs)
 831         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
 832         * guile/scm-progspace.c (gdbscm_progspaces): Update.
 833         * exec.c (exec_target::close): Update.
 834         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
 835         * breakpoint.c (print_one_breakpoint_location)
 836         (create_longjmp_master_breakpoint)
 837         (create_std_terminate_master_breakpoint): Update.
 838         * progspace.c (program_spaces): Now a std::vector.
 839         (maybe_new_address_space): Update.
 840         (add_program_space): Remove.
 841         (program_space::program_space): Update.
 842         (remove_program_space): Update.
 843         (number_of_program_spaces): Remove.
 844         (print_program_space, update_address_spaces): Update.
 845         * progspace.h (program_spaces): Change type.
 846         (ALL_PSPACES): Remove.
 847         (number_of_program_spaces): Don't declare.
 848         (struct program_space) <next>: Remove.
 849
 850 2020-05-08  Tom Tromey  <tom@tromey.com>
 851
 852         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
 853         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
 854         (enable_break): Update.
 855         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
 856         (frv_fdpic_find_canonical_descriptor): Update.
 857         (frv_fetch_objfile_link_map): Update.
 858         * progspace.c (program_space::free_all_objfiles): Update.
 859         (program_space::solibs): New method.
 860         * progspace.h (struct program_space) <solibs>: New method.
 861         * solist.h (master_so_list): Don't declare.
 862         (ALL_SO_LIBS): Remove.
 863         * solib.h (so_list_head): Remove.
 864         (update_solib_list): Update comment.
 865         * solib.c (master_so_list): Remove.
 866         (solib_used, update_solib_list, solib_add)
 867         (info_sharedlibrary_command, clear_solib)
 868         (reload_shared_libraries_1, remove_user_added_objfile): Update.
 869
 870 2020-05-08  Tom Tromey  <tom@tromey.com>
 871
 872         * extension.c (extension_languages): Now a std::array.
 873         (ALL_EXTENSION_LANGUAGES): Remove.
 874         (get_ext_lang_defn, get_ext_lang_of_file)
 875         (eval_ext_lang_from_control_command): Update.
 876         (finish_ext_lang_initialization)
 877         (auto_load_ext_lang_scripts_for_objfile)
 878         (ext_lang_type_printers::ext_lang_type_printers)
 879         (apply_ext_lang_type_printers)
 880         (ext_lang_type_printers::~ext_lang_type_printers)
 881         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
 882         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
 883         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
 884         (get_matching_xmethod_workers, ext_lang_colorize)
 885         (ext_lang_before_prompt): Update.
 886         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
 887
 888 2020-05-08  Tom Tromey  <tom@tromey.com>
 889
 890         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
 891         overload.
 892         <swap_string, m_string>: Remove.
 893         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
 894         Update.
 895         * stabsread.c (define_symbol, read_type): Update.
 896         * linespec.c (find_linespec_symbols): Update.
 897         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
 898         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
 899         * dbxread.c (read_dbx_symtab): Update.
 900         * cp-support.h (cp_canonicalize_string_full)
 901         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
 902         Return unique_xmalloc_ptr.
 903         * cp-support.c (inspect_type): Update.
 904         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
 905         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
 906         Likewise.
 907         * c-typeprint.c (print_name_maybe_canonical): Update.
 908         * break-catch-throw.c (check_status_exception_catchpoint):
 909         Update.
 910
 911 2020-05-08  Tom de Vries  <tdevries@suse.de>
 912
 913         * infrun.c (follow_fork): Copy current_line and current_symtab to
 914         child thread.
 915
 916 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 917
 918         * async-event.c (struct async_signal_handler, struct
 919         async_event_handler): Reformat, remove typedef.
 920
 921 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 922
 923         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
 924         access thistype->main_type->dyn_prop_list directly.
 925
 926 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 927
 928         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
 929         (remove_dyn_prop): Remove.  Update all users to use
 930         type::remove_dyn_prop.
 931         * gdbtypes.c (remove_dyn_prop): Rename to...
 932         (type::remove_dyn_prop): ... this.
 933
 934 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
 935
 936         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
 937         (add_dyn_prop): Remove.  Update all users to use
 938         type::add_dyn_prop.
 939         * gdbtypes.c (add_dyn_prop): Rename to...
 940         (type::add_dyn_prop): ... this.
 941
 942 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 943
 944         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
 945         (get_dyn_prop): Remove.  Update all users to use
 946         type::dyn_prop.
 947         * gdbtypes.c (get_dyn_prop): Rename to...
 948         (type::dyn_prop): ... this.
 949
 950 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 951
 952         * gdbtypes.h (struct main_type) <flag_static>: Remove.
 953
 954 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 955
 956         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
 957         instruction, skip it if it's there.
 958
 959 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
 960
 961         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
 962
 963 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
 964
 965         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
 966         * gdbtypes.c (recursive_dump_type): Remove use of
 967         TYPE_INCOMPLETE.
 968
 969 2020-05-03  Tom Tromey  <tom@tromey.com>
 970
 971         * breakpoint.c (catch_command, tcatch_command): Remove.
 972         (_initialize_breakpoint): Use add_basic_prefix_cmd,
 973         add_show_prefix_cmd.
 974         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
 975         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
 976         Remove.
 977         (add_internal_problem_command): Use add_basic_prefix_cmd,
 978         add_show_prefix_cmd.
 979         * mips-tdep.c (set_mipsfpu_command): Remove.
 980         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
 981         * dwarf2/index-cache.c (set_index_cache_command): Remove.
 982         (_initialize_index_cache): Use add_basic_prefix_cmd.
 983         * memattr.c (dummy_cmd): Remove.
 984         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
 985         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
 986         (_initialize_tui_win): Use add_basic_prefix_cmd,
 987         add_show_prefix_cmd.
 988         * cli/cli-logging.c (set_logging_command): Remove.
 989         (_initialize_cli_logging): Use add_basic_prefix_cmd,
 990         add_show_prefix_cmd.
 991         (show_logging_command): Remove.
 992         * target.c (target_command): Remove.
 993         (add_target): Use add_basic_prefix_cmd.
 994
 995 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
 996
 997         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
 998
 999 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1000
1001         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
1002         info_command.
1003
1004 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
1005
1006         * nbsd-nat.c (nbsd_enable_proc_events)
1007         (nbsd_nat_target::post_startup_inferior): Add.
1008         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
1009         (nbsd_nat_target::update_thread_list): Rewrite.
1010         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
1011         "PTRACE_LWP_CREATE".
1012         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
1013
1014 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1015
1016         * stack.c (_initialize_stack): Remove duplicated creation
1017         of "frame" command and "f" alias.
1018
1019 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
1020
1021         PR gdb/18706
1022         * gdbtypes.c (check_typedef): Calculate size of array of
1023         stubbed type.
1024
1025 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
1026
1027         PR gdb/15559
1028         * i386-tdep.c (i386_push_dummy_call): Call
1029         i386_thiscall_push_dummy_call.
1030         (i386_thiscall_push_dummy_call): New function.
1031         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
1032         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
1033         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
1034
1035 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1036
1037         * gdbarch.sh (do_read): Add shellcheck disable directive for
1038         warning SC2162.
1039
1040 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1041
1042         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
1043         "referenced but not assigned" warning.
1044
1045 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1046
1047         * gdbarch.sh: Remove code that sets fallbackdefault.
1048
1049 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1050
1051         * gdbarch.sh: Use shell operators && and || instead of
1052         -a and -o.
1053
1054 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1055
1056         * gdbarch.sh: Use $(...) instead of `...`.
1057
1058 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1059
1060         * gdbarch.sh: Use double quotes around variables.
1061
1062 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
1063
1064         * gdbarch.sh: Use %s with printf, instead of variables in the
1065         format string.
1066
1067 2020-04-29  Tom Tromey  <tromey@adacore.com>
1068
1069         PR ada/25875:
1070         * dwarf2/read.c (update_enumeration_type_from_children): Compute
1071         type fields here.
1072         (read_enumeration_type): Call
1073         update_enumeration_type_from_children later.  Update comments.
1074         (process_enumeration_scope): Don't create type fields.
1075
1076 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
1077
1078         * nbsd-tdep.c: Include "xml-syscall.h".
1079         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
1080
1081 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
1082
1083         * nbsd-nat.c: Include "sys/wait.h".
1084         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
1085         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
1086         (nbsd_nat_target::remove_exec_catchpoint)
1087         (nbsd_nat_target::set_syscall_catchpoint): Add.
1088         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
1089         (nbsd_nat_target::insert_exec_catchpoint)
1090         (nbsd_nat_target::remove_exec_catchpoint)
1091         (nbsd_nat_target::set_syscall_catchpoint): Add.
1092         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
1093         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
1094         `nbsd_get_syscall_number'.
1095
1096 2020-04-29  Tom Tromey  <tom@tromey.com>
1097
1098         * stack.c (print_block_frame_labels): Remove.
1099
1100 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
1101
1102         PR gdb/17320
1103         * ada-valprint.c (val_print_packed_array_elements): Move array
1104         end bracket to new line.
1105         (ada_val_print_string): Remove extra spaces before first array
1106         element.
1107         * c-valprint.c (c_value_print_array): Likewise.
1108         * m2-valprint.c (m2_print_array_contents): Likewise.
1109         (m2_value_print_inner): Likewise.
1110         * p-valprint.c (pascal_value_print_inner): Likewise.
1111         * valprint.c (generic_val_print_array): Likewise.
1112         (value_print_array_elements): Move first array element and array
1113         end bracket to new line.
1114
1115 2020-04-29  Tom de Vries  <tdevries@suse.de>
1116
1117         PR symtab/25889
1118         * linespec.c (find_method): Fix ix calculation.
1119
1120 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
1121
1122         * syscalls/update-netbsd.sh: New file.
1123         * syscalls/netbsd.xml: Regenerate.
1124         * data-directory/Makefile.in: Register `netbsd.xml' in
1125         `SYSCALLS_FILES'.
1126
1127 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
1128
1129         * syscalls/update-freebsd.sh: Add double quotes.
1130
1131 2020-04-28  Tom Tromey  <tom@tromey.com>
1132
1133         * NEWS: Update.
1134         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
1135         (cmdpy_init): Allow class_tui.
1136
1137 2020-04-28 Mark Williams <mark@myosotissp.com>
1138
1139         PR gdb/24480
1140         * dwarf2read.c: Add missing assingments to list_in_scope when
1141         start_symtab was already called.
1142
1143 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
1144
1145         PR gdb/25881
1146         * dwarf2/read.c (offset_map_type): Use
1147         gdb:hash_enum<sect_offset> as hash function.
1148
1149 2020-04-28  Tom de Vries  <tdevries@suse.de>
1150
1151         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
1152         with DW_AT_signature.
1153
1154 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
1155
1156         * configure.ac: Remove check for fs_base/gs_base in
1157         user_regs_struct.
1158         * configure: Re-generate.
1159         * config.in: Re-generate.
1160         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
1161         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
1162         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
1163
1164 2020-04-27  Luis Machado  <luis.machado@linaro.org>
1165
1166         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
1167         problematic inline frame unwinding situation.
1168         * frame.c (frame_id_computed_p): New function.
1169         * frame.h (frame_id_computed_p): New prototype.
1170
1171 2020-04-26  Tom Tromey  <tom@tromey.com>
1172
1173         * command.h (enum command_class) <class_pseudo>: Remove.
1174
1175 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1176
1177         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
1178         and whitespace.
1179
1180 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
1181
1182        * inf-ptrace.c (inf_ptrace_target::wait): Remove
1183        `PT_GET_PROCESS_STATE' block.
1184
1185 2020-04-24  Tom Tromey  <tom@tromey.com>
1186
1187         * symtab.h (symbol_get_demangled_name): Don't declare.
1188         * symtab.c (symbol_get_demangled_name): Remove.
1189         (general_symbol_info::natural_name)
1190         (general_symbol_info::demangled_name): Update.
1191
1192 2020-04-24  Tom Tromey  <tom@tromey.com>
1193
1194         PR rust/25025:
1195         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
1196
1197 2020-04-24  Tom Tromey  <tom@tromey.com>
1198
1199         PR symtab/12707:
1200         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
1201         exists.
1202         (new_symbol): Likewise.
1203         * compile/compile-object-load.c (get_out_value_type): Use
1204         symbol_matches_search_name.
1205
1206 2020-04-24  Tom Tromey  <tom@tromey.com>
1207
1208         * dwarf2/read.c (add_partial_symbol): Do not call
1209         compute_and_set_names.
1210
1211 2020-04-24  Tom Tromey  <tom@tromey.com>
1212
1213         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
1214         overload.
1215
1216 2020-04-24  Tom Tromey  <tom@tromey.com>
1217
1218         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
1219         (add_psymbol_to_list): New overload.  Make old overload call new
1220         one.
1221         * psympriv.h (add_psymbol_to_list): New overload.
1222
1223 2020-04-24  Tom Tromey  <tom@tromey.com>
1224
1225         * dwarf2/read.c (partial_die_info::read) <case
1226         DW_AT_linkage_name>: Use value_as_string.
1227         (dwarf2_string_attr): Use value_as_string.
1228         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
1229         method.
1230         * dwarf2/attribute.c (attribute::value_as_string): New method.
1231
1232 2020-04-24  Tom Tromey  <tom@tromey.com>
1233
1234         * symtab.c (general_symbol_info::natural_name)
1235         (general_symbol_info::demangled_name): Check for language_rust.
1236
1237 2020-04-24  Tom Tromey  <tom@tromey.com>
1238
1239         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
1240         (dwarf2_physname): ... from here.
1241         (partial_die_info::read): Add Rust "{" hack.
1242
1243 2020-04-24  Tom Tromey  <tom@tromey.com>
1244
1245         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
1246         method.
1247         (symbol_set_demangled_name): Don't declare.
1248         * symtab.c (general_symbol_info::set_demangled_name): Rename from
1249         symbol_set_demangled_name.
1250         (general_symbol_info::set_language)
1251         (general_symbol_info::compute_and_set_names): Update.
1252         * minsyms.c (minimal_symbol_reader::install): Update.
1253         * dwarf2/read.c (new_symbol): Update.
1254
1255 2020-04-24  Tom Tromey  <tromey@adacore.com>
1256
1257         PR python/23662:
1258         * python/py-type.c (convert_field): Handle
1259         FIELD_LOC_KIND_DWARF_BLOCK.
1260         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
1261         (typy_get_dynamic): Nw function.
1262         (type_object_getset): Add "dynamic".
1263         * NEWS: Add entry.
1264
1265 2020-04-24  Tom Tromey  <tromey@adacore.com>
1266
1267         * ada-typeprint.c (print_choices, print_variant_part)
1268         (print_record_field_types_dynamic): New functions.
1269         (print_record_field_types): Use print_record_field_types_dynamic.
1270
1271 2020-04-24  Tom Tromey  <tromey@adacore.com>
1272
1273         * dwarf2/read.c (handle_data_member_location): New overload.
1274         (dwarf2_add_field): Use it.
1275         (decode_locdesc): Add "computed" parameter.  Update comment.
1276         * gdbtypes.c (is_dynamic_type_internal): Also look for
1277         FIELD_LOC_KIND_DWARF_BLOCK.
1278         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
1279         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
1280         virtual base classes.
1281         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
1282         FIELD_LOC_KIND_DWARF_BLOCK.
1283
1284 2020-04-24  Tom Tromey  <tromey@adacore.com>
1285
1286         * dwarf2/read.c (read_structure_type): Handle dynamic length.
1287         * gdbtypes.c (is_dynamic_type_internal): Check
1288         TYPE_HAS_DYNAMIC_LENGTH.
1289         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
1290         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
1291         New macros.
1292         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
1293         constant.
1294
1295 2020-04-24  Tom Tromey  <tromey@adacore.com>
1296
1297         * dwarf2/read.c (struct variant_field): Rewrite.
1298         (struct variant_part_builder): New.
1299         (struct nextfield): Remove "variant" field.  Add "offset".
1300         (struct field_info): Add "current_variant_part" and
1301         "variant_parts".
1302         (alloc_discriminant_info): Remove.
1303         (alloc_rust_variant): New function.
1304         (quirk_rust_enum): Update.
1305         (dwarf2_add_field): Set "offset" member.  Don't handle
1306         DW_TAG_variant_part.
1307         (offset_map_type): New typedef.
1308         (convert_variant_range, create_one_variant)
1309         (create_one_variant_part, create_variant_parts)
1310         (add_variant_property): New functions.
1311         (dwarf2_attach_fields_to_type): Call add_variant_property.
1312         (read_structure_type): Don't handle DW_TAG_variant_part.
1313         (handle_variant_part, handle_variant): New functions.
1314         (handle_struct_member_die): Use them.
1315         (process_structure_scope): Don't handle variant parts.
1316         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
1317         (struct discriminant_info): Remove.
1318         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
1319         (struct main_type) <flag_discriminated_union>: Remove.
1320         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
1321         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
1322         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
1323         Update.
1324         * valops.c (value_union_variant): Remove.
1325         * value.h (value_union_variant): Don't declare.
1326
1327 2020-04-24  Tom Tromey  <tromey@adacore.com>
1328
1329         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
1330         (ada_value_primitive_packed_val): Update.
1331         * ada-valprint.c (ada_value_print_1): Update.
1332         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
1333         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
1334         just an address.  Use evaluate_for_locexpr_baton.
1335         (dwarf2_evaluate_property): Update.
1336         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
1337         array_view.
1338         * findvar.c (default_read_var_value): Update.
1339         * gdbtypes.c (compute_variant_fields_inner)
1340         (resolve_dynamic_type_internal): Update.
1341         (resolve_dynamic_type): Change type of valaddr parameter.
1342         * gdbtypes.h (resolve_dynamic_type): Update.
1343         * valarith.c (value_subscripted_rvalue): Update.
1344         * value.c (value_from_contents_and_address): Update.
1345
1346 2020-04-24  Tom Tromey  <tromey@adacore.com>
1347
1348         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
1349         "push_initial_value" parameter.
1350         (dwarf2_evaluate_property): Likewise.
1351         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
1352
1353 2020-04-24  Tom Tromey  <tromey@adacore.com>
1354
1355         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
1356         (variant::matches, compute_variant_fields_recurse)
1357         (compute_variant_fields_inner, compute_variant_fields): New
1358         functions.
1359         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
1360         Use resolved_type after type is made.
1361         (operator==): Add new cases.
1362         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
1363         (struct discriminant_range, struct variant, struct variant_part):
1364         New.
1365         (union dynamic_prop_data) <variant_parts, original_type>: New
1366         members.
1367         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
1368         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
1369         constants.
1370         * value.c (unpack_bits_as_long): Now public.
1371         * value.h (unpack_bits_as_long): Declare.
1372
1373 2020-04-24  Tom Tromey  <tromey@adacore.com>
1374
1375         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
1376         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
1377
1378 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
1379
1380         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
1381
1382 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
1383
1384         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
1385         (remove_fork_catchpoint, post_startup_inferior)
1386         (post_attach): Move...
1387         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
1388         (remove_fork_catchpoint, post_startup_inferior)
1389         (post_attach): ...here.
1390         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
1391         (remove_fork_catchpoint, post_startup_inferior)
1392         (post_attach): Move...
1393         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
1394         (remove_fork_catchpoint, post_startup_inferior)
1395         (post_attach): ...here.
1396
1397 2020-04-24  Tom Tromey  <tromey@adacore.com>
1398
1399         * nat/windows-nat.h (struct windows_thread_info)
1400         <pc_adjusted>: New member.
1401         * windows-nat.c (windows_fetch_one_register): Check
1402         pc_adjusted.
1403         (windows_nat_target::get_windows_debug_event)
1404         (windows_nat_target::wait): Set pc_adjusted.
1405
1406 2020-04-24  Tom de Vries  <tdevries@suse.de>
1407
1408         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
1409         Run gdb-add-index inside temp dir.
1410
1411 2020-04-23  Tom Tromey  <tromey@adacore.com>
1412
1413         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
1414         in loop.
1415
1416 2020-04-23  Luis Machado  <luis.machado@linaro.org>
1417
1418         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
1419         get_frame_register instead of gdbarch_unwind_pc.
1420
1421 2020-04-23  Tom de Vries  <tdevries@suse.de>
1422
1423         * symtab.c (lookup_global_symbol): Prefer def over decl.
1424
1425 2020-04-23  Tom de Vries  <tdevries@suse.de>
1426
1427         PR symtab/25807
1428         * block.c (best_symbol, better_symbol): Promote to external.
1429         * block.h (best_symbol, better_symbol): Declare.
1430         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
1431         decl.
1432
1433 2020-04-23  Tom Tromey  <tromey@adacore.com>
1434
1435         PR ada/25837:
1436         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
1437         "const char *", not a "const std::string &".
1438         <name_and_matcher::operator==>: Update.
1439         * unittests/lookup_name_info-selftests.c: Change type of
1440         "result".
1441
1442 2020-04-23  Tom Tromey  <tom@tromey.com>
1443
1444         * inferior.h (iterate_over_inferiors): Don't declare.
1445         * inferior.c (iterate_over_inferiors): Remove.
1446         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
1447         Remove.
1448         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
1449         use iterate_over_inferiors.
1450         (darwin_resume_inferior_it)
1451         (struct resume_inferior_threads_param)
1452         (darwin_resume_inferior_threads_it): Remove.
1453         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
1454
1455 2020-04-23  Tom de Vries  <tdevries@suse.de>
1456
1457         * blockframe.c (find_pc_partial_function): Use
1458         find_pc_sect_compunit_symtab rather than
1459         objfile->sf->qf->find_pc_sect_compunit_symtab.
1460
1461 2020-04-22  Tom de Vries  <tdevries@suse.de>
1462
1463         PR symtab/25764
1464         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
1465         in psymtabs.
1466
1467 2020-04-22  Tom de Vries  <tdevries@suse.de>
1468
1469         PR symtab/25801
1470         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
1471         symtabs.
1472
1473 2020-04-22  Tom de Vries  <tdevries@suse.de>
1474
1475         PR symtab/25700
1476         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
1477         CU if already created.
1478
1479 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1480
1481         * infrun.c (displaced_step_fixup): Switch to the event_thread
1482         before calling displaced_step_restore, not after.
1483
1484 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
1485
1486         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
1487         its inferior is not recorded by us.
1488         (record_btrace_target_open): Replace call to
1489         all_non_exited_threads () with call to current_inferior
1490         ()->non_exited_threads ().
1491         (record_btrace_target::stop_recording): Likewise.
1492         (record_btrace_target::close): Likewise.
1493         (record_btrace_target::wait): Likewise.
1494         (record_btrace_target::record_stop_replaying): Likewise.
1495
1496 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
1497
1498         * btrace.c (btrace_enable): Throw an error on double enables and
1499         when enabling recording fails.
1500         (btrace_disable): Throw an error if the thread is not recorded.
1501
1502 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
1503
1504         * record-btrace.c (record_btrace_target::fetch_registers): Forward
1505         request if we do not have a thread_info.
1506
1507 2020-04-21  Tom de Vries  <tdevries@suse.de>
1508
1509         PR gdb/25471
1510         * thread.c
1511         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
1512         exception in get_frame_id.
1513
1514 2020-04-20  Tom Tromey  <tromey@adacore.com>
1515
1516         * python/python.c (struct gdbpy_event): Mark move constructor as
1517         noexcept.
1518         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
1519         constructor as noexcept.
1520         * completer.h (struct completion_result): Mark move constructor as
1521         noexcept.
1522         * completer.c (completion_result::completion_result): Use
1523         initialization style.  Don't call reset_match_list.
1524
1525 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
1526
1527         * MAINTAINERS (Write After Approval): Add myself.
1528
1529 2020-04-18  Tom Tromey  <tom@tromey.com>
1530
1531         * windows-tdep.c (init_w32_command_list)
1532         (w32_prefix_command_valid): Restore.
1533         (_initialize_windows_tdep): Call init_w32_command_list.
1534
1535 2020-04-18  Tom Tromey  <tom@tromey.com>
1536
1537         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
1538         * value.c (value_fn_field): Update.
1539         * valops.c (find_function_in_inferior)
1540         (value_allocate_space_in_inferior): Update.
1541         * tui/tui-winsource.c (tui_update_source_windows_with_line):
1542         Update.
1543         * tui/tui-source.c (tui_source_window::set_contents): Update.
1544         * symtab.c (lookup_global_or_static_symbol)
1545         (find_function_start_sal_1, skip_prologue_sal)
1546         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
1547         * symmisc.c (dump_msymbols, dump_symtab_1)
1548         (maintenance_print_one_line_table): Update.
1549         * symfile.c (init_entry_point_info, section_is_mapped)
1550         (list_overlays_command, simple_read_overlay_table)
1551         (simple_overlay_update_1): Update.
1552         * stap-probe.c (handle_stap_probe): Update.
1553         * stabsread.c (dbx_init_float_type, define_symbol)
1554         (read_one_struct_field, read_enum_type, read_range_type): Update.
1555         * source.c (info_line_command): Update.
1556         * python/python.c (gdbpy_source_objfile_script)
1557         (gdbpy_execute_objfile_script): Update.
1558         * python/py-type.c (save_objfile_types): Update.
1559         * python/py-objfile.c (py_free_objfile): Update.
1560         * python/py-inferior.c (python_new_objfile): Update.
1561         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
1562         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
1563         (maintenance_check_psymtabs): Update.
1564         * printcmd.c (info_address_command): Update.
1565         * objfiles.h (struct objfile) <arch>: New method, from
1566         get_objfile_arch.
1567         (get_objfile_arch): Don't declare.
1568         * objfiles.c (get_objfile_arch): Remove.
1569         (filter_overlapping_sections): Update.
1570         * minsyms.c (msymbol_is_function): Update.
1571         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
1572         (output_nondebug_symbol): Update.
1573         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
1574         (mdebug_expand_psymtab): Update.
1575         * machoread.c (macho_add_oso_symfile): Update.
1576         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
1577         Update.
1578         * linux-fork.c (checkpoint_command): Update.
1579         * linespec.c (convert_linespec_to_sals): Update.
1580         * jit.c (finalize_symtab): Update.
1581         * infrun.c (insert_exception_resume_from_probe): Update.
1582         * ia64-tdep.c (ia64_find_unwind_table): Update.
1583         * hppa-tdep.c (internalize_unwinds): Update.
1584         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
1585         Update.
1586         * gcore.c (call_target_sbrk): Update.
1587         * elfread.c (record_minimal_symbol, elf_symtab_read)
1588         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
1589         (elf_gnu_ifunc_resolve_by_got): Update.
1590         * dwarf2/read.c (create_addrmap_from_index)
1591         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1592         (read_debug_names_from_section)
1593         (process_psymtab_comp_unit_reader, add_partial_symbol)
1594         (add_partial_subprogram, process_full_comp_unit)
1595         (read_file_scope, read_func_scope, read_lexical_block_scope)
1596         (read_call_site_scope, dwarf2_ranges_read)
1597         (dwarf2_record_block_ranges, dwarf2_add_field)
1598         (mark_common_block_symbol_computed, read_tag_pointer_type)
1599         (read_tag_string_type, dwarf2_init_float_type)
1600         (dwarf2_init_complex_target_type, read_base_type)
1601         (partial_die_info::read, partial_die_info::read)
1602         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
1603         (dwarf2_fetch_die_loc_sect_off): Update.
1604         * dwarf2/loc.c (dwarf2_find_location_expression)
1605         (class dwarf_evaluate_loc_desc, rw_pieced_value)
1606         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
1607         (dwarf2_loc_desc_get_symbol_read_needs)
1608         (locexpr_describe_location_piece, locexpr_describe_location_1)
1609         (loclist_describe_location): Update.
1610         * dwarf2/index-write.c (write_debug_names): Update.
1611         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
1612         * dtrace-probe.c (dtrace_process_dof): Update.
1613         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
1614         (process_one_symbol): Update.
1615         * ctfread.c (ctf_init_float_type, read_base_type): Update.
1616         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
1617         (coff_read_enum_type): Update.
1618         * cli/cli-cmds.c (edit_command, list_command): Update.
1619         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
1620         * breakpoint.c (create_overlay_event_breakpoint)
1621         (create_longjmp_master_breakpoint)
1622         (create_std_terminate_master_breakpoint)
1623         (create_exception_master_breakpoint, get_sal_arch): Update.
1624         * block.c (block_gdbarch): Update.
1625         * annotate.c (annotate_source_line): Update.
1626
1627 2020-04-17  Tom Tromey  <tromey@adacore.com>
1628
1629         * auto-load.c (show_auto_load_cmd): Remove.
1630         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
1631         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
1632         (maintenance_print_arc_command): Remove.
1633         * tui/tui-win.c (tui_command): Remove.
1634         (tui_get_cmd_list): Use add_basic_prefix_cmd.
1635         * tui/tui-layout.c (tui_layout_command): Remove.
1636         (_initialize_tui_layout): Use add_basic_prefix_cmd.
1637         * python/python.c (user_set_python, user_show_python): Remove.
1638         (_initialize_python): Use add_basic_prefix_cmd,
1639         add_show_prefix_cmd.
1640         * guile/guile.c (set_guile_command, show_guile_command): Remove.
1641         (install_gdb_commands): Use add_basic_prefix_cmd,
1642         add_show_prefix_cmd.
1643         (info_guile_command): Remove.
1644         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
1645         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
1646         add_show_prefix_cmd.
1647         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1648         Remove do_set and do_show parameters.
1649         * cli/cli-style.c (set_style, show_style): Remove.
1650         (_initialize_cli_style): Use add_basic_prefix_cmd,
1651         add_show_prefix_cmd.
1652         (cli_style_option::add_setshow_commands): Remove do_set and
1653         do_show parameters.
1654         (cli_style_option::add_setshow_commands): Use
1655         add_basic_prefix_cmd, add_show_prefix_cmd.
1656         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
1657         (set_style_name): Remove.
1658         * cli/cli-dump.c (dump_command, append_command): Remove.
1659         (srec_dump_command, ihex_dump_command, verilog_dump_command)
1660         (tekhex_dump_command, binary_dump_command)
1661         (binary_append_command): Remove.
1662         (_initialize_cli_dump): Use add_basic_prefix_cmd.
1663         * windows-tdep.c (w32_prefix_command_valid): Remove global.
1664         (init_w32_command_list): Remove; move into ...
1665         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
1666         * valprint.c (set_print, show_print, set_print_raw)
1667         (show_print_raw): Remove.
1668         (_initialize_valprint): Use add_basic_prefix_cmd,
1669         add_show_prefix_cmd.
1670         * typeprint.c (set_print_type, show_print_type): Remove.
1671         (_initialize_typeprint): Use add_basic_prefix_cmd,
1672         add_show_prefix_cmd.
1673         * record.c (set_record_command, show_record_command): Remove.
1674         (_initialize_record): Use add_basic_prefix_cmd,
1675         add_show_prefix_cmd.
1676         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
1677         add_show_prefix_cmd.
1678         (info_command, show_command, set_debug, show_debug): Remove.
1679         * top.h (set_history, show_history): Don't declare.
1680         * top.c (set_history, show_history): Remove.
1681         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
1682         (unset_tdesc_cmd): Remove.
1683         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
1684         add_show_prefix_cmd.
1685         * symtab.c (info_module_command): Remove.
1686         (_initialize_symtab): Use add_basic_prefix_cmd.
1687         * symfile.c (overlay_command): Remove.
1688         (_initialize_symfile): Use add_basic_prefix_cmd.
1689         * sparc64-tdep.c (info_adi_command): Remove.
1690         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
1691         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
1692         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
1693         add_show_prefix_cmd.
1694         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
1695         (_initialize_serial): Use add_basic_prefix_cmd,
1696         add_show_prefix_cmd.
1697         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
1698         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
1699         add_show_prefix_cmd.
1700         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
1701         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
1702         add_show_prefix_cmd.
1703         * riscv-tdep.c (show_riscv_command, set_riscv_command)
1704         (show_debug_riscv_command, set_debug_riscv_command): Remove.
1705         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
1706         add_show_prefix_cmd.
1707         * remote.c (remote_command, set_remote_cmd): Remove.
1708         (_initialize_remote): Use add_basic_prefix_cmd.
1709         * record-full.c (set_record_full_command)
1710         (show_record_full_command): Remove.
1711         (_initialize_record_full): Use add_basic_prefix_cmd,
1712         add_show_prefix_cmd.
1713         * record-btrace.c (cmd_set_record_btrace)
1714         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
1715         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
1716         (cmd_show_record_btrace_pt): Remove.
1717         (_initialize_record_btrace): Use add_basic_prefix_cmd,
1718         add_show_prefix_cmd.
1719         * ravenscar-thread.c (set_ravenscar_command)
1720         (show_ravenscar_command): Remove.
1721         (_initialize_ravenscar): Use add_basic_prefix_cmd,
1722         add_show_prefix_cmd.
1723         * mips-tdep.c (show_mips_command, set_mips_command)
1724         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
1725         add_show_prefix_cmd.
1726         * maint.c (maintenance_command, maintenance_info_command)
1727         (maintenance_check_command, maintenance_print_command)
1728         (maintenance_set_cmd, maintenance_show_cmd): Remove.
1729         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
1730         add_show_prefix_cmd.
1731         (show_per_command_cmd): Remove.
1732         * maint-test-settings.c (maintenance_set_test_settings_cmd):
1733         Remove.
1734         (maintenance_show_test_settings_cmd): Remove.
1735         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
1736         add_show_prefix_cmd.
1737         * maint-test-options.c (maintenance_test_options_command):
1738         Remove.
1739         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
1740         * macrocmd.c (macro_command): Remove
1741         (_initialize_macrocmd): Use add_basic_prefix_cmd.
1742         * language.c (set_check, show_check): Remove.
1743         (_initialize_language): Use add_basic_prefix_cmd,
1744         add_show_prefix_cmd.
1745         * infcmd.c (unset_command): Remove.
1746         (_initialize_infcmd): Use add_basic_prefix_cmd.
1747         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
1748         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
1749         add_show_prefix_cmd.
1750         * go32-nat.c (go32_info_dos_command): Remove.
1751         (_initialize_go32_nat): Use add_basic_prefix_cmd.
1752         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
1753         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
1754         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
1755         (_initialize_frame): Use add_basic_prefix_cmd,
1756         add_show_prefix_cmd.
1757         * dcache.c (set_dcache_command, show_dcache_command): Remove.
1758         (_initialize_dcache): Use add_basic_prefix_cmd,
1759         add_show_prefix_cmd.
1760         * cp-support.c (maint_cplus_command): Remove.
1761         (_initialize_cp_support): Use add_basic_prefix_cmd.
1762         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
1763         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
1764         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
1765         add_basic_prefix_cmd, add_show_prefix_cmd.
1766         * breakpoint.c (save_command): Remove.
1767         (_initialize_breakpoint): Use add_basic_prefix_cmd.
1768         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
1769         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
1770         add_show_prefix_cmd.
1771         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
1772         (set_ada_command, show_ada_command): Remove.
1773         (_initialize_ada_language): Use add_basic_prefix_cmd,
1774         add_show_prefix_cmd.
1775         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
1776
1777 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
1778
1779         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
1780         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
1781
1782 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1783
1784         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
1785         warning messages.
1786
1787 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1788
1789         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
1790         import table is not at beginning of .idata section.
1791
1792 2020-04-16  Pedro Alves  <palves@redhat.com>
1793
1794         * inferior.c (delete_inferior): Use delete operator directly
1795         instead of delete_program_space.
1796         * progspace.c (add_program_space): New, factored out from
1797         program_space::program_space.
1798         (remove_program_space): New, factored out from
1799         delete_program_space.
1800         (program_space::program_space): Remove intro comment.  Rewrite.
1801         (program_space::~program_space): Remove intro comment.  Call
1802         remove_program_space.
1803         (delete_program_space): Delete.
1804         * progspace.h (program_space::program_space): Make explicit.  Move
1805         intro comment here, adjusted.
1806         (program_space::~program_space): Move intro comment here,
1807         adjusted.
1808         (delete_program_space): Remove.
1809
1810 2020-04-16  Tom Tromey  <tromey@adacore.com>
1811
1812         * windows-nat.c (windows_nat::handle_access_violation): New
1813         function.
1814         * nat/windows-nat.h (handle_access_violation): Declare.
1815         * nat/windows-nat.c (handle_exception): Move Cygwin code to
1816         windows-nat.c.  Call handle_access_violation.
1817
1818 2020-04-16  Tom de Vries  <tdevries@suse.de>
1819
1820         PR symtab/25791
1821         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
1822         CUs without psymtab.
1823
1824 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
1825
1826         * python/python.c (do_start_initialization): Don't call
1827         PyEval_InitThreads for Python 3.9 and beyond.
1828
1829 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
1830
1831         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
1832         thread functions.
1833         (obsd_nat_target::wait): Likewise.
1834
1835 2020-04-15  Tom Tromey  <tromey@adacore.com>
1836
1837         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
1838         (DEBUG_EXCEPT): Use debug_printf.
1839
1840 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * completer.c (class completion_tracker::completion_hash_entry)
1843         <hash_name>: New member function.
1844         (completion_tracker::discard_completions): New callback to hash a
1845         completion_hash_entry, pass this to htab_create_alloc.
1846
1847 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
1848
1849         * windows-nat.c (windows_make_so): Warn rather than stopping with
1850         an error if realpath() fails.
1851
1852 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
1853
1854         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
1855         (nbsd_nat_target::info_proc): Add do_status.
1856
1857 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
1858             Tom de Vries  <tdevries@suse.de>
1859
1860         PR symtab/25718
1861         * psympriv.h (struct partial_symtab::read_symtab)
1862         (struct partial_symtab::expand_psymtab)
1863         (struct partial_symtab::read_dependencies): Update comments.
1864         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
1865         read_symtab for includer.
1866         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
1867         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
1868         (struct dwarf2_include_psymtab::m_readin): Remove.
1869         (struct dwarf2_include_psymtab::includer): New member function.
1870         (dwarf2_psymtab::expand_psymtab): Assert !readin.
1871
1872 2020-04-14  Tom de Vries  <tdevries@suse.de>
1873
1874         PR symtab/25720
1875         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
1876         with NULL symbol_matcher and lookup_name.
1877         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
1878         and lookup_name.
1879         * dwarf2/read.c (dw2_expand_symtabs_matching)
1880         (dw2_debug_names_expand_symtabs_matching): Same.
1881         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
1882         Make lookup_name a pointer.  Update comment.
1883         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
1884         lookup_name being a pointer.
1885         * symfile.c (expand_symtabs_matching): Same.
1886         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
1887         * linespec.c (iterate_over_all_matching_symtabs): Same.
1888
1889 2020-04-13  Tom Tromey  <tom@tromey.com>
1890
1891         * run-on-main-thread.c: Update include.
1892         * unittests/main-thread-selftests.c: Update include.
1893         * tui/tui-win.c: Update include.
1894         * tui/tui-io.c: Update include.
1895         * tui/tui-interp.c: Update include.
1896         * tui/tui-hooks.c: Update include.
1897         * top.h: Update include.
1898         * top.c: Update include.
1899         * ser-base.c: Update include.
1900         * remote.c: Update include.
1901         * remote-notif.c: Update include.
1902         * remote-fileio.c: Update include.
1903         * record-full.c: Update include.
1904         * record-btrace.c: Update include.
1905         * python/python.c: Update include.
1906         * posix-hdep.c: Update include.
1907         * mingw-hdep.c: Update include.
1908         * mi/mi-main.c: Update include.
1909         * mi/mi-interp.c: Update include.
1910         * main.c: Update include.
1911         * linux-nat.c: Update include.
1912         * interps.c: Update include.
1913         * infrun.c: Update include.
1914         * inf-loop.c: Update include.
1915         * event-top.c: Update include.
1916         * event-loop.c: Move to ../gdbsupport/.
1917         * event-loop.h: Move to ../gdbsupport/.
1918         * async-event.h: Update include.
1919         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1920
1921 2020-04-13  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-win.c: Include async-event.h.
1924         * remote.c: Include async-event.h.
1925         * remote-notif.c: Include async-event.h.
1926         * record-full.c: Include async-event.h.
1927         * record-btrace.c: Include async-event.h.
1928         * infrun.c: Include async-event.h.
1929         * event-top.c: Include async-event.h.
1930         * event-loop.h: Move some declarations to async-event.h.
1931         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1932         code to async-event.c.
1933         * async-event.h: New file.
1934         * async-event.c: New file.
1935         * Makefile.in (COMMON_SFILES): Add async-event.c.
1936         (HFILES_NO_SRCDIR): Add async-event.h.
1937
1938 2020-04-13  Tom Tromey  <tom@tromey.com>
1939
1940         * utils.c (flush_streams): New function.
1941         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1942
1943 2020-04-13  Tom Tromey  <tom@tromey.com>
1944
1945         * event-loop.c (handle_file_event): Use warning, not
1946         printf_unfiltered.
1947
1948 2020-04-13  Tom Tromey  <tom@tromey.com>
1949
1950         * event-loop.c: Include <chrono>.
1951
1952 2020-04-13  Tom Tromey  <tom@tromey.com>
1953
1954         * gdb_select.h: Move to ../gdbsupport/.
1955         * event-loop.c: Update include path.
1956         * top.c: Update include path.
1957         * ser-base.c: Update include path.
1958         * ui-file.c: Update include path.
1959         * ser-tcp.c: Update include path.
1960         * guile/scm-ports.c: Update include path.
1961         * posix-hdep.c: Update include path.
1962         * ser-unix.c: Update include path.
1963         * gdb_usleep.c: Update include path.
1964         * mingw-hdep.c: Update include path.
1965         * inflow.c: Update include path.
1966         * infrun.c: Update include path.
1967         * event-top.c: Update include path.
1968
1969 2020-04-13  Tom Tromey  <tom@tromey.com>
1970
1971         * configure: Rebuild.
1972         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1973
1974 2020-04-13  Tom Tromey  <tom@tromey.com>
1975
1976         * event-loop.h (start_event_loop): Don't declare.
1977         * event-loop.c (start_event_loop): Move...
1978         * main.c (start_event_loop): ...here.  Now static.
1979
1980 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1981
1982         * MAINTAINERS: Update my email address.
1983
1984 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1985
1986         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1987         IP_ALL.
1988
1989 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1990
1991         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1992         (nbsd_nat_target::info_proc): Add do_cmdline.
1993
1994 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1995
1996         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1997         (nbsd_nat_target::info_proc): Add do_cwd.
1998
1999 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
2000
2001         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
2002
2003 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
2004
2005         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
2006         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
2007         (nbsd_nat_target::info_proc): New functions.
2008         * nbsd-nat.c (kinfo_get_vmmap): New function.
2009         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
2010         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
2011         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
2012         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
2013         functions.
2014         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
2015         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
2016         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
2017         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
2018         (KINFO_VME_FLAG_GROWS_DOWN): New.
2019
2020 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
2021
2022         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
2023         bit shift.
2024
2025 2020-04-10  Tom Tromey  <tromey@adacore.com>
2026
2027         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
2028
2029 2020-04-10  Tom Tromey  <tromey@adacore.com>
2030
2031         * symtab.c (get_symbol_address, get_msymbol_address): Skip
2032         separate debug files.
2033
2034 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
2035
2036         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
2037         Move to...
2038         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
2039         ... here.
2040         * windows-nat.c (windows_nat_target::get_windows_debug_event):
2041         Check for STATUS_WX86_BREAKPOINT.
2042         (windows_nat_target::wait): Same.
2043
2044 2020-04-10  Tom de Vries  <tdevries@suse.de>
2045
2046         PR cli/25808
2047         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
2048
2049 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2050
2051         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
2052         (Write After Approval): Remove Tom de Vries.
2053
2054 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2055
2056         revert partially:
2057         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2058
2059         * buildsym.c (record_line): Fix undefined behavior and preserve
2060         lines at eof.
2061
2062 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
2063
2064         * auxv.h (svr4_auxv_parse): New.
2065         * auxv.c (default_auxv_parse): Split into default_auxv_parse
2066         and generic_auxv_parse.
2067         (svr4_auxv_parse): Add.
2068         * obsd-tdep.c: Include "auxv.h".
2069         (obsd_auxv_parse): Remove.
2070         (obsd_init_abi): Remove comment.
2071         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
2072         from `obsd_auxv_parse' to `svr4_auxv_parse'.
2073         * nbsd-tdep.c: Include "auxv.h".
2074         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
2075
2076 2020-04-08  Tom Tromey  <tromey@adacore.com>
2077
2078         * nat/windows-nat.h (last_wait_event): Don't declare.
2079         (wait_for_debug_event): Update comment.
2080         * nat/windows-nat.c (last_wait_event): Now static.
2081
2082 2020-04-08  Tom Tromey  <tromey@adacore.com>
2083
2084         * windows-nat.c (wait_for_debug_event): Move to
2085         nat/windows-nat.c.
2086         * nat/windows-nat.h (wait_for_debug_event): Declare.
2087         * nat/windows-nat.c (wait_for_debug_event): Move from
2088         windows-nat.c.  No longer static.
2089
2090 2020-04-08  Tom Tromey  <tromey@adacore.com>
2091
2092         * windows-nat.c (get_windows_debug_event): Use
2093         fetch_pending_stop.
2094         * nat/windows-nat.h (fetch_pending_stop): Declare.
2095         * nat/windows-nat.c (fetch_pending_stop): New function.
2096
2097 2020-04-08  Tom Tromey  <tromey@adacore.com>
2098
2099         * windows-nat.c (windows_continue): Use matching_pending_stop and
2100         continue_last_debug_event.
2101         * nat/windows-nat.h (matching_pending_stop)
2102         (continue_last_debug_event): Declare.
2103         * nat/windows-nat.c (DEBUG_EVENTS): New define.
2104         (matching_pending_stop, continue_last_debug_event): New
2105         functions.
2106
2107 2020-04-08  Tom Tromey  <tromey@adacore.com>
2108
2109         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
2110         (handle_exception_result): Move to nat/windows-nat.h.
2111         (DEBUG_EXCEPTION_SIMPLE): Remove.
2112         (windows_nat::handle_ms_vc_exception): New function.
2113         (handle_exception): Move to nat/windows-nat.c.
2114         (get_windows_debug_event): Update.
2115         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
2116         nat/windows-nat.c.
2117         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
2118         (handle_exception_result): Move from windows-nat.c.
2119         (handle_exception): Declare.
2120         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
2121         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
2122         windows-nat.c.
2123
2124 2020-04-08  Tom Tromey  <tromey@adacore.com>
2125
2126         * windows-nat.c (exception_count, event_count): Remove.
2127         (handle_exception, get_windows_debug_event)
2128         (do_initial_windows_stuff): Update.
2129
2130 2020-04-08  Tom Tromey  <tromey@adacore.com>
2131
2132         * windows-nat.c (windows_nat::handle_load_dll)
2133         (windows_nat::handle_unload_dll): Rename.  No longer static.
2134         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
2135         Declare.
2136
2137 2020-04-08  Tom Tromey  <tromey@adacore.com>
2138
2139         * complaints.h (stop_whining): Declare at top-level.
2140         (complaint): Don't declare stop_whining.
2141
2142 2020-04-08  Tom Tromey  <tromey@adacore.com>
2143
2144         * windows-nat.c (windows_nat::handle_output_debug_string):
2145         Rename.  No longer static.
2146         * nat/windows-nat.h (handle_output_debug_string): Declare.
2147
2148 2020-04-08  Tom Tromey  <tromey@adacore.com>
2149
2150         * windows-nat.c (current_process_handle, current_process_id)
2151         (main_thread_id, last_sig, current_event, last_wait_event)
2152         (current_windows_thread, desired_stop_thread_id, pending_stops)
2153         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
2154         (display_selectors, fake_create_process)
2155         (get_windows_debug_event): Update.
2156         * nat/windows-nat.h (current_process_handle, current_process_id)
2157         (main_thread_id, last_sig, current_event, last_wait_event)
2158         (current_windows_thread, desired_stop_thread_id, pending_stops)
2159         (struct pending_stop, siginfo_er): Move from windows-nat.c.
2160         * nat/windows-nat.c (current_process_handle, current_process_id)
2161         (main_thread_id, last_sig, current_event, last_wait_event)
2162         (current_windows_thread, desired_stop_thread_id, pending_stops)
2163         (siginfo_er): New globals.  Move from windows-nat.c.
2164
2165 2020-04-08  Tom Tromey  <tromey@adacore.com>
2166
2167         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
2168         (handle_load_dll): Update.
2169         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
2170
2171 2020-04-08  Tom Tromey  <tromey@adacore.com>
2172
2173         * windows-nat.c (enum thread_disposition_type): Move to
2174         nat/windows-nat.h.
2175         (windows_nat::thread_rec): Rename from thread_rec.  No longer
2176         static.
2177         (windows_add_thread, windows_nat_target::fetch_registers)
2178         (windows_nat_target::store_registers, handle_exception)
2179         (windows_nat_target::resume, get_windows_debug_event)
2180         (windows_nat_target::get_tib_address)
2181         (windows_nat_target::thread_name)
2182         (windows_nat_target::thread_alive): Update.
2183         * nat/windows-nat.h (enum thread_disposition_type): Move from
2184         windows-nat.c.
2185         (thread_rec): Declare.
2186
2187 2020-04-08  Tom Tromey  <tromey@adacore.com>
2188
2189         * windows-nat.c: Add "using namespace".
2190         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
2191         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
2192
2193 2020-04-08  Tom Tromey  <tromey@adacore.com>
2194
2195         * nat/windows-nat.h (struct windows_thread_info): Declare
2196         destructor.
2197         * nat/windows-nat.c (~windows_thread_info): New.
2198
2199 2020-04-08  Tom Tromey  <tromey@adacore.com>
2200
2201         PR gdb/22992
2202         * windows-nat.c (current_event): Update comment.
2203         (last_wait_event, desired_stop_thread_id): New globals.
2204         (struct pending_stop): New.
2205         (pending_stops): New global.
2206         (windows_nat_target) <stopped_by_sw_breakpoint>
2207         <supports_stopped_by_sw_breakpoint>: New methods.
2208         (windows_fetch_one_register): Add assertions.  Adjust PC.
2209         (windows_continue): Handle pending stops.  Suspend other threads
2210         when stepping.  Use last_wait_event
2211         (wait_for_debug_event): New function.
2212         (get_windows_debug_event): Use wait_for_debug_event.  Handle
2213         pending stops.  Queue spurious stops.
2214         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
2215         (windows_nat_target::kill): Use wait_for_debug_event.
2216         * nat/windows-nat.h (struct windows_thread_info)
2217         <stopped_at_software_breakpoint>: New field.
2218         * nat/windows-nat.c (windows_thread_info::resume): Clear
2219         stopped_at_software_breakpoint.
2220
2221 2020-04-08  Tom Tromey  <tromey@adacore.com>
2222
2223         * windows-nat.c (enum thread_disposition_type): New.
2224         (thread_rec): Replace "get_context" parameter with "disposition";
2225         change type.
2226         (windows_add_thread, windows_nat_target::fetch_registers)
2227         (windows_nat_target::store_registers, handle_exception)
2228         (windows_nat_target::resume, get_windows_debug_event)
2229         (windows_nat_target::get_tib_address)
2230         (windows_nat_target::thread_name)
2231         (windows_nat_target::thread_alive): Update.
2232
2233 2020-04-08  Tom Tromey  <tromey@adacore.com>
2234
2235         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
2236         (windows_continue): Use windows_continue::resume.
2237         * nat/windows-nat.h (struct windows_thread_info) <suspend,
2238         resume>: Declare new methods.
2239         * nat/windows-nat.c: New file.
2240         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
2241
2242 2020-04-08  Tom Tromey  <tromey@adacore.com>
2243
2244         * windows-nat.c (windows_add_thread, windows_delete_thread)
2245         (windows_nat_target::fetch_registers)
2246         (windows_nat_target::store_registers, fake_create_process)
2247         (windows_nat_target::resume, windows_nat_target::resume)
2248         (get_windows_debug_event, windows_nat_target::wait)
2249         (windows_nat_target::pid_to_str)
2250         (windows_nat_target::get_tib_address)
2251         (windows_nat_target::get_ada_task_ptid)
2252         (windows_nat_target::thread_name)
2253         (windows_nat_target::thread_alive): Use lwp, not tid.
2254
2255 2020-04-08  Tom Tromey  <tromey@adacore.com>
2256
2257         * windows-nat.c (handle_exception)
2258         (windows_nat_target::thread_name): Update.
2259         * nat/windows-nat.h (windows_thread_info): Remove destructor.
2260         <name>: Now unique_xmalloc_ptr.
2261
2262 2020-04-08  Tom Tromey  <tromey@adacore.com>
2263
2264         * windows-nat.c (thread_rec)
2265         (windows_nat_target::fetch_registers): Update.
2266         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
2267         Update comment.
2268         <debug_registers_changed, reload_context>: Now bool.
2269
2270 2020-04-08  Tom Tromey  <tromey@adacore.com>
2271
2272         * windows-nat.c (windows_add_thread): Use new.
2273         (windows_init_thread_list, windows_delete_thread): Use delete.
2274         (get_windows_debug_event): Update.
2275         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
2276         destructor, and initializers.
2277
2278 2020-04-08  Tom Tromey  <tromey@adacore.com>
2279
2280         * windows-nat.c (struct windows_thread_info): Remove.
2281         * nat/windows-nat.h: New file.
2282
2283 2020-04-08  Tom Tromey  <tromey@adacore.com>
2284
2285         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
2286         (thread_rec, windows_add_thread, windows_delete_thread)
2287         (windows_continue): Update.
2288
2289 2020-04-08  Tom Tromey  <tromey@adacore.com>
2290
2291         * windows-nat.c (struct windows_thread_info): Remove typedef.
2292         (thread_head): Remove.
2293         (thread_list): New global.
2294         (thread_rec, windows_add_thread, windows_init_thread_list)
2295         (windows_delete_thread, windows_continue): Update.
2296
2297 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
2298
2299         * windows-tdep.h (windows_init_abi): Add comment.
2300         (cygwin_init_abi): New declaration.
2301         * windows-tdep.c: Split signal enumeration in two, one for
2302         Windows and one for Cygwin.
2303         (windows_gdb_signal_to_target): Only deal with signal of the
2304         Windows OS ABI.
2305         (cygwin_gdb_signal_to_target): New function.
2306         (windows_init_abi): Rename to windows_init_abi_common, don't set
2307         gdb_signal_to_target gdbarch method.  Add new new function with
2308         this name.
2309         (cygwin_init_abi): New function.
2310         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
2311         comment.  Don't call windows_init_abi.
2312         (amd64_windows_init_abi): Add comment, call windows_init_abi.
2313         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
2314         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
2315         i386_windows_init_abi_common, don't call windows_init_abi.  Add
2316         a new function of this name.
2317         (i386_cygwin_init_abi): New function.
2318         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
2319         OS ABI Cygwin.
2320
2321 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
2322
2323         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
2324         parameter.c.
2325         (dwarf2_read_gdb_index): Update.
2326
2327 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
2328
2329         * nbsd-tdep.c: Include "objfiles.h".
2330         (nbsd_skip_solib_resolver): New.
2331         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
2332
2333 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
2334
2335         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
2336         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
2337         with DW_LLE_base_addressx are being emitted in DWARFv5.
2338         Add the newly added kind DW_LOC_OFFSET_PAIR also.
2339         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
2340         unsigned integer.
2341
2342 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
2343
2344         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
2345         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
2346         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
2347         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
2348         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
2349         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
2350         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
2351
2352
2353 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
2354
2355         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
2356         (read_loclist_index): New function definition.
2357         (lookup_loclist_base): New function definition.
2358         (read_loclist_header): New function definition.
2359         (dwarf2_cu): Add loclist_base and loclist_header field.
2360         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
2361         (read_full_die_1): Read the value of DW_AT_loclists_base.
2362         (read_attribute_reprocess): Handle DW_FORM_loclistx.
2363         (read_attribute_value): Handle DW_FORM_loclistx.
2364         (skip_one_die): Handle DW_FORM_loclistx.
2365         (loclist_header): New structure declaration.
2366         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
2367
2368 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
2369
2370         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
2371         constructor.  Remove `addr` parameter from other constructor and
2372         add `per_cu` parameter.
2373         * dwarf2/read.c (create_partial_symtab): Update.
2374
2375 2020-04-07  Tom de Vries  <tdevries@suse.de>
2376
2377         PR symtab/25796
2378         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
2379         (partial_die_info::fixup): Inherit has_const_value.
2380
2381 2020-04-07  Tom de Vries  <tdevries@suse.de>
2382
2383         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
2384         symbols without address.
2385
2386 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
2387
2388         * nbsd-nat.h (struct thread_info): Add forward declaration.
2389         (nbsd_nat_target::thread_alive): Add.
2390         (nbsd_nat_target::thread_name): Likewise.
2391         (nbsd_nat_target::update_thread_list): Likewise.
2392         (update_thread_list::post_attach): Likewise.
2393         (post_attach::pid_to_str): Likewise.
2394         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
2395         (nbsd_thread_lister): Add.
2396         (nbsd_nat_target::thread_alive): Likewise.
2397         (nbsd_nat_target::thread_name): Likewise.
2398         (nbsd_add_threads): Likewise.
2399         (update_thread_list::post_attach): Likewise.
2400         (nbsd_nat_target::update_thread_list): Likewise.
2401         (post_attach::pid_to_str): Likewise.
2402
2403 2020-04-06  Tom Tromey  <tromey@adacore.com>
2404
2405         * ada-valprint.c (print_variant_part): Extract the variant field.
2406         (print_field_values): Use the field as the outer value when
2407         recursing.
2408
2409 2020-04-06  Tom Tromey  <tromey@adacore.com>
2410
2411         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
2412         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
2413         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
2414         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
2415         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
2416
2417 2020-04-06  Tom Tromey  <tromey@adacore.com>
2418
2419         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
2420         TYPE_CODE_ERROR.
2421
2422 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
2423
2424         * nbsd-tdep.c: Include "gdbarch.h".
2425         Define enum with NetBSD signal numbers.
2426         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
2427         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
2428         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
2429         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
2430         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
2431         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
2432         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
2433         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
2434         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
2435         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
2436         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
2437         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
2438
2439 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
2440
2441         PR gdb/25325
2442         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
2443
2444 2020-04-03  Tom Tromey  <tromey@adacore.com>
2445
2446         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
2447         Read constant block.
2448
2449 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
2450
2451         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
2452         (gdb_bfd_get_full_section_contents): New declaration.
2453         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
2454         * windows-tdep.c (is_linked_with_cygwin_dll): Use
2455         gdb_bfd_get_full_section_contents.
2456
2457 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
2458
2459         * exec.c (build_section_table): Replace internal_error with
2460         gdb_assert.
2461         (section_table_xfer_memory_partial): Likewise.
2462         * mdebugread.c (parse_partial_symbols): Likewise.
2463         * psymtab.c (lookup_partial_symbol): Likewise.
2464         * utils.c (wrap_here): Likewise.
2465
2466 2020-04-02  Tom Tromey  <tromey@adacore.com>
2467
2468         * f-lang.c (build_fortran_types): Use arch_type to initialize
2469         builtin_complex_s32 in the TYPE_CODE_ERROR case.
2470
2471 2020-04-02  Tom Tromey  <tromey@adacore.com>
2472
2473         * dwarf2/read.c (partial_die_info::read): Do not create a vector
2474         of attributes.
2475
2476 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2477             Bernd Edlinger <bernd.edlinger@hotmail.de>
2478             Tom Tromey  <tromey@adacore.com>
2479
2480         * buildsym.c (buildsym_compunit::record_line): Remove
2481         deduplication code.
2482
2483 2020-04-02  Tom de Vries  <tdevries@suse.de>
2484
2485         PR ada/24671
2486         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
2487
2488 2020-04-02  Tom de Vries  <tdevries@suse.de>
2489
2490         * dwarf2/read.c (dwarf2_gdb_index_functions,
2491         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
2492         NULL.
2493         * psymtab.c (psym_lookup_global_symbol_language): New function.
2494         (psym_functions): Init psym_lookup_global_symbol_language with
2495         psym_lookup_global_symbol_language.
2496         * symfile-debug.c (debug_sym_quick_functions): Init
2497         lookup_global_symbol_language with NULL.
2498         * symfile.c (set_initial_language): Remove fixme comment.
2499         * symfile.h (struct quick_symbol_functions): Add
2500         lookup_global_symbol_language.
2501         * symtab.c (find_quick_global_symbol_language): New function.
2502         (find_main_name): Use find_quick_global_symbol_language.
2503
2504 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
2505
2506         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
2507
2508 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2509
2510         * buildsym.c (record_line): Fix undefined behavior and preserve
2511         lines at eof.
2512
2513 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2514
2515         * buildsym.c (record_line): Fix the resizing condition.
2516
2517 2020-04-01  Tom Tromey  <tom@tromey.com>
2518
2519         * value.h (value_literal_complex): Add comment.
2520         * valops.c (value_literal_complex): Refer to value.h.
2521
2522 2020-04-01  Tom Tromey  <tom@tromey.com>
2523
2524         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
2525         (scalar_type): New rule, from typebase.
2526         (typebase): Use scalar_type.  Recognize complex types.
2527         (field_name): Handle FLOAT_KEYWORD.
2528         (ident_tokens): Add _Complex and __complex__.
2529
2530 2020-04-01  Tom Tromey  <tom@tromey.com>
2531
2532         PR exp/25299:
2533         * valarith.c (promotion_type, complex_binop): New functions.
2534         (scalar_binop): Handle complex numbers.  Use promotion_type.
2535         (value_pos, value_neg, value_complement): Handle complex numbers.
2536
2537 2020-04-01  Tom Tromey  <tom@tromey.com>
2538
2539         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
2540         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
2541         (parse_number): Handle complex numbers.
2542
2543 2020-04-01  Tom Tromey  <tom@tromey.com>
2544
2545         * c-valprint.c (c_decorations): Change complex suffix to "i".
2546
2547 2020-04-01  Tom Tromey  <tom@tromey.com>
2548
2549         * valprint.c (generic_value_print_complex): Use accessors.
2550         * value.h (value_real_part, value_imaginary_part): Declare.
2551         * valops.c (value_real_part, value_imaginary_part): New
2552         functions.
2553         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
2554
2555 2020-04-01  Tom Tromey  <tom@tromey.com>
2556
2557         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
2558         (read_range_type): Update.
2559         * mdebugread.c (basic_type): Update.
2560         * go-lang.c (build_go_types): Use init_complex_type.
2561         * gdbtypes.h (struct main_type) <complex_type>: New member.
2562         (init_complex_type): Update.
2563         (arch_complex_type): Don't declare.
2564         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
2565         Make name if none given.  Use alloc_type_copy.  Look for cached
2566         complex type.
2567         (arch_complex_type): Remove.
2568         (gdbtypes_post_init): Use init_complex_type.
2569         * f-lang.c (build_fortran_types): Use init_complex_type.
2570         * dwarf2/read.c (read_base_type): Update.
2571         * d-lang.c (build_d_types): Use init_complex_type.
2572         * ctfread.c (read_base_type): Update.
2573
2574 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2575
2576         * infrun.c (stop_all_threads): Update assertion, plus when
2577         stopping threads, take into account that we might be trying
2578         to stop an all-stop target.
2579         (stop_waiting): Call 'stop_all_threads' if there exists a
2580         non-stop target.
2581
2582 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2583
2584         * target.h (exists_non_stop_target): New function declaration.
2585         * target.c (exists_non_stop_target): New function.
2586
2587 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
2588
2589         PR gdb/24789
2590         * eval.c (is_integral_or_integral_reference): New function.
2591         (evaluate_subexp_standard): Allow integer references in
2592         pointer arithmetic.
2593
2594 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2595
2596         * remote.c (remote_target::remote_parse_stop_reply): Remove the
2597         check for no ptid in the stop reply when the target is non-stop.
2598
2599 2020-04-01  Tom Tromey  <tromey@adacore.com>
2600
2601         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
2602         "name" parameter to rvalue reference.  Initialize m_name_holder.
2603         <lookup_name_info>: New overloads.
2604         <name>: Return gdb::string_view.
2605         <c_str>: New method.
2606         <make_ignore_params>: Update.
2607         <search_name_hash>: Update.
2608         <language_lookup_name>: Return const char *.
2609         <m_name>: Change type.
2610         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
2611         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
2612         (lookup_name_info::match_any): Update.
2613         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
2614         Update.
2615         * minsyms.c (linkage_name_str): Update.
2616         * language.c (default_symbol_name_matcher): Update.
2617         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
2618         Update.
2619         * ada-lang.c (ada_fold_name): Change parameter to string_view.
2620         (ada_lookup_name_info::ada_lookup_name_info): Update.
2621         (literal_symbol_name_matcher): Update.
2622
2623 2020-04-01  Tom Tromey  <tromey@adacore.com>
2624
2625         * psymtab.c (psymtab_search_name): Remove function.
2626         (psym_lookup_symbol): Create search name and lookup name here.
2627         (lookup_partial_symbol): Remove "name" parameter; add
2628         lookup_name.
2629         (psym_expand_symtabs_for_function): Update.
2630
2631 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
2632
2633         PR tui/25597:
2634         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
2635
2636 2020-03-31  Tom Tromey  <tromey@adacore.com>
2637
2638         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
2639         memcpy.
2640
2641 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
2642
2643         * features/riscv/32bit-csr.xml: Regenerated.
2644         * features/riscv/64bit-csr.xml: Regenerated.
2645
2646 2020-03-30  Tom Tromey  <tromey@adacore.com>
2647
2648         * ada-valprint.c (print_variant_part): Update.
2649         * ada-lang.h (ada_which_variant_applies): Update.
2650         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
2651         outer_valaddr parameters; replace with "outer" value parameter.
2652         (to_fixed_variant_branch_type): Update.
2653
2654 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2655
2656         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
2657         <list>.  Remove inclusion of observable.h.
2658         (PPC_DEBUG_CURRENT_VERSION): Move up define.
2659         (struct arch_lwp_info): New struct.
2660         (class ppc_linux_dreg_interface): New class.
2661         (struct ppc_linux_process_info): New struct.
2662         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
2663         <low_new_clone, low_forget_process, low_prepare_to_resume>
2664         <copy_thread_dreg_state, mark_thread_stale>
2665         <mark_debug_registers_changed, register_hw_breakpoint>
2666         <clear_hw_breakpoint, register_wp, clear_wp>
2667         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
2668         <num_memory_accesses, get_trigger_type>
2669         <create_watchpoint_request, hwdebug_point_cmp>
2670         <init_arch_lwp_info, get_arch_lwp_info>
2671         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
2672         methods.
2673         <struct ptid_hash>: New inner struct.
2674         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
2675         members.
2676         (saved_dabr_value, hwdebug_info, max_slots_number)
2677         (struct hw_break_tuple, struct thread_points, ppc_threads)
2678         (have_ptrace_hwdebug_interface)
2679         (hwdebug_find_thread_points_by_tid)
2680         (hwdebug_insert_point, hwdebug_remove_point): Remove.
2681         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
2682         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
2683         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
2684         use m_dreg_interface.
2685         (hwdebug_point_cmp): Change to...
2686         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
2687         reference arguments instead of pointers.
2688         (ppc_linux_nat_target::ranged_break_num_registers): Use
2689         m_dreg_interface.
2690         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
2691         m_dreg_interface.  Call register_hw_breakpoint.
2692         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
2693         m_dreg_interface.  Call clear_hw_breakpoint.
2694         (get_trigger_type): Change to...
2695         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
2696         comment.
2697         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
2698         use m_dreg_interface.  Call register_hw_breakpoint.
2699         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
2700         use m_dreg_interface.  Call clear_hw_breakpoint.
2701         (can_use_watchpoint_cond_accel): Change to...
2702         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
2703         method.  Update comment, use m_dreg_interface and
2704         m_process_info.
2705         (calculate_dvc): Change to...
2706         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
2707         m_dreg_interface.
2708         (num_memory_accesses): Change to...
2709         (ppc_linux_nat_target::num_memory_accesses): ...this method.
2710         (check_condition): Change to...
2711         (ppc_linux_nat_target::check_condition): ...this method.
2712         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
2713         comment, use m_dreg_interface.
2714         (create_watchpoint_request): Change to...
2715         (ppc_linux_nat_target::create_watchpoint_request): ...this
2716         method.  Use m_dreg_interface.
2717         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
2718         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
2719         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
2720         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
2721         (ppc_linux_nat_target::low_forget_process)
2722         (ppc_linux_nat_target::low_new_fork)
2723         (ppc_linux_nat_target::low_new_clone)
2724         (ppc_linux_nat_target::low_delete_thread)
2725         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
2726         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
2727         only call mark_thread_stale.
2728         (ppc_linux_thread_exit): Remove.
2729         (ppc_linux_nat_target::stopped_data_address): Change to...
2730         (ppc_linux_nat_target::low_stopped_data_address): This. Add
2731         comment, use m_dreg_interface and m_thread_hw_breakpoints.
2732         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
2733         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
2734         comment.  Call low_stopped_data_address.
2735         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
2736         m_dreg_interface.
2737         (ppc_linux_nat_target::masked_watch_num_registers): Use
2738         m_dreg_interface.
2739         (ppc_linux_nat_target::copy_thread_dreg_state)
2740         (ppc_linux_nat_target::mark_thread_stale)
2741         (ppc_linux_nat_target::mark_debug_registers_changed)
2742         (ppc_linux_nat_target::register_hw_breakpoint)
2743         (ppc_linux_nat_target::clear_hw_breakpoint)
2744         (ppc_linux_nat_target::register_wp)
2745         (ppc_linux_nat_target::clear_wp)
2746         (ppc_linux_nat_target::init_arch_lwp_info)
2747         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
2748         (_initialize_ppc_linux_nat): Remove observer callback.
2749
2750 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2751
2752         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
2753         (ppc_linux_nat_target::auxv_parse)
2754         (ppc_linux_nat_target::read_description)
2755         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
2756         Move up.
2757
2758 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2759
2760         * linux-nat.h (low_new_clone): New method.
2761         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
2762
2763 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2764
2765         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
2766         (dbx_expand_psymtab): ... this.
2767         (start_psymtab): Update.
2768         * mdebugread.c (psymtab_to_symtab_1): Rename to...
2769         (mdebug_expand_psymtab): ... this.
2770         (parse_partial_symbols): Update.
2771         (new_psymtab): Update.
2772         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
2773         (xcoff_expand_psymtab): ... this.
2774         (xcoff_start_psymtab): Update.
2775
2776 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2777
2778         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
2779         <expand_dependencies>: ... this.
2780         * psymtab.c (partial_symtab::read_dependencies): Rename to...
2781         (partial_symtab::expand_dependencies): ... this.
2782         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
2783         Update.
2784         (dwarf2_psymtab::expand_psymtab): Update.
2785         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2786         * mdebugread.c (psymtab_to_symtab_1): Update.
2787         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2788
2789 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2790
2791         * psympriv.h (discard_psymtab): Remove.
2792         * dbxread.c (dbx_end_psymtab): Update.
2793         * xcoffread.c (xcoff_end_psymtab): Update.
2794
2795 2020-03-28  Tom Tromey  <tom@tromey.com>
2796
2797         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
2798         comment.
2799
2800 2020-03-28  Tom Tromey  <tom@tromey.com>
2801
2802         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
2803
2804 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
2805
2806         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2807
2808 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
2809
2810         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
2811
2812 2020-03-26  Tom Tromey  <tom@tromey.com>
2813
2814         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
2815         (mark_common_block_symbol_computed, read_tag_string_type)
2816         (attr_to_dynamic_prop, read_subrange_type): Update.
2817         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
2818         to be methods on struct attribute.
2819         (skip_one_die, process_imported_unit_die, read_namespace_alias)
2820         (read_call_site_scope, partial_die_info::read)
2821         (partial_die_info::read, lookup_die_type, follow_die_ref):
2822         Update.
2823         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
2824         from dwarf2_get_ref_die_offset.
2825         (attribute::constant_value): New method, from
2826         dwarf2_get_attr_constant_value.
2827         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
2828         Declare method.
2829         <constant_value>: New method.
2830
2831 2020-03-26  Tom Tromey  <tom@tromey.com>
2832
2833         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
2834         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
2835         (dwarf_type_encoding_name): Move to stringify.c.
2836         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
2837         * dwarf2/stringify.c: New file.
2838         * dwarf2/stringify.h: New file.
2839
2840 2020-03-26  Tom Tromey  <tom@tromey.com>
2841
2842         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
2843         Rewrite.
2844
2845 2020-03-26  Tom Tromey  <tom@tromey.com>
2846
2847         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
2848         methods.
2849         * dwarf2/read.c (lookup_addr_base): Move to die.h.
2850         (lookup_ranges_base): Likewise.
2851         (read_cutu_die_from_dwo, read_full_die_1): Update.
2852
2853 2020-03-26  Tom Tromey  <tom@tromey.com>
2854
2855         * dwarf2/read.c (read_import_statement, read_file_scope)
2856         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
2857         (read_lexical_block_scope, read_call_site_scope)
2858         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
2859         (handle_struct_member_die, process_structure_scope)
2860         (update_enumeration_type_from_children)
2861         (process_enumeration_scope, read_array_type, read_common_block)
2862         (read_namespace, read_module, read_subroutine_type): Update.
2863         (sibling_die): Remove.
2864
2865 2020-03-26  Tom Tromey  <tom@tromey.com>
2866
2867         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
2868         (build_type_psymtabs_reader, read_structure_type)
2869         (read_enumeration_type, read_full_die_1): Update.
2870         (dwarf2_attr_no_follow): Move to die.h.
2871         * dwarf2/die.h (struct die_info) <attr>: New method.
2872
2873 2020-03-26  Tom Tromey  <tom@tromey.com>
2874
2875         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
2876         <base_address>: Now an optional.
2877         (dwarf2_find_base_address, dwarf2_rnglists_process)
2878         (dwarf2_ranges_process, fill_in_loclist_baton)
2879         (dwarf2_symbol_mark_computed): Update.
2880
2881 2020-03-26  Tom Tromey  <tom@tromey.com>
2882
2883         * dwarf2/read.c (struct die_info): Move to die.h.
2884         * dwarf2/die.h: New file.
2885
2886 2020-03-26  Tom Tromey  <tom@tromey.com>
2887
2888         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
2889         * dwarf2/read.c
2890         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2891         Move to line-header.c.
2892         (read_checked_initial_length_and_offset, read_formatted_entries):
2893         Likewise.
2894         (dwarf_decode_line_header): Split into two.
2895         * dwarf2/line-header.c
2896         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2897         Move from read.c.
2898         (read_checked_initial_length_and_offset, read_formatted_entries):
2899         Likewise.
2900         (dwarf_decode_line_header): New function, split from read.c.
2901
2902 2020-03-26  Tom Tromey  <tom@tromey.com>
2903
2904         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
2905         Declare method.
2906         * dwarf2/read.c (read_attribute_value): Update.
2907         (dwarf2_per_objfile::read_line_string): Rename from
2908         read_indirect_line_string.
2909         (read_formatted_entries): Update.
2910
2911 2020-03-26  Tom Tromey  <tom@tromey.com>
2912
2913         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
2914         variable.
2915
2916 2020-03-26  Tom Tromey  <tom@tromey.com>
2917
2918         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
2919         const.
2920         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2921         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2922         parameter const.
2923
2924 2020-03-26  Tom Tromey  <tom@tromey.com>
2925
2926         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2927         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2928         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2929         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2930
2931 2020-03-26  Tom Tromey  <tom@tromey.com>
2932
2933         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2934         file_names_size, file_full_name, file_file_name>: Use const.
2935         <file_name_at, file_names>: Add const overload.
2936         * dwarf2/line-header.c (line_header::file_file_name)
2937         (line_header::file_full_name): Update.
2938
2939 2020-03-26  Tom Tromey  <tom@tromey.com>
2940
2941         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2942         (macro_start_file, consume_improper_spaces)
2943         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2944         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2945         (dwarf_decode_macros): Move to macro.c.
2946         * dwarf2/macro.c: New file.
2947         * dwarf2/macro.h: New file.
2948         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2949
2950 2020-03-26  Tom Tromey  <tom@tromey.com>
2951
2952         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2953         method.
2954         * dwarf2/section.c: New method.  From
2955         read_indirect_string_at_offset_from.
2956         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2957         (read_indirect_string_at_offset_from): Move to section.c.
2958         (read_indirect_string_at_offset): Rewrite.
2959         (read_indirect_line_string_at_offset): Remove.
2960         (read_indirect_string, read_indirect_line_string)
2961         (dwarf_decode_macro_bytes): Update.
2962
2963 2020-03-26  Tom Tromey  <tom@tromey.com>
2964
2965         * dwarf2/section.h (struct dwarf2_section_info)
2966         <overload_complaint>: Declare.
2967         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2968         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2969         Rename from dwarf2_section_buffer_overflow_complaint.
2970         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2971         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2972
2973 2020-03-26  Tom Tromey  <tom@tromey.com>
2974
2975         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2976         Declare.
2977         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2978         Move from read.c.
2979         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2980         to section.c.
2981
2982 2020-03-26  Tom Tromey  <tom@tromey.com>
2983
2984         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2985
2986 2020-03-26  Tom Tromey  <tom@tromey.com>
2987
2988         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2989         "builder".
2990         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2991         parameter.
2992         (dwarf_decode_macros): Update.
2993
2994 2020-03-26  Tom Tromey  <tom@tromey.com>
2995
2996         * dwarf2/read.c (read_attribute_value): Update.
2997         (read_indirect_string_from_dwz): Move to dwz.c; change into
2998         method.
2999         (dwarf_decode_macro_bytes): Update.
3000         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
3001         * dwarf2/dwz.c: New file.
3002         * Makefile.in (COMMON_SFILES): Add dwz.c.
3003
3004 2020-03-26  Tom Tromey  <tom@tromey.com>
3005
3006         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
3007         * dwarf2/read.c: Add include.
3008         * dwarf2/index-write.c: Add include.
3009         * dwarf2/index-cache.c: Add include.
3010         * dwarf2/dwz.h: New file.
3011
3012 2020-03-25  Tom Tromey  <tom@tromey.com>
3013
3014         * compile/compile-object-load.c (get_out_value_type): Mention
3015         correct symbol name in error message.
3016
3017 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
3018
3019         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
3020
3021 2020-03-25  Tom de Vries  <tdevries@suse.de>
3022
3023         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
3024         * symmisc.c (dump_symtab_1): Print user and includes fields.
3025         (maintenance_info_symtabs): Same.
3026
3027 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         PR gdb/25534
3030         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
3031         (riscv_regcache_cooked_write): New function.
3032         (riscv_push_dummy_call): Use new function.
3033         (riscv_return_value): Likewise.
3034
3035 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
3036
3037         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
3038         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
3039         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
3040         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
3041         * infrun.c (follow_fork): Likewise.
3042         (follow_fork_inferior): Likewise.
3043         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
3044         * linux-nat.h (class linux_nat_target): Likewise.
3045         * remote.c (class remote_target) <follow_fork>: Likewise.
3046         (remote_target::follow_fork): Likewise.
3047         * target-delegates.c: Re-generate.
3048         * target.c (default_follow_fork): Likewise.
3049         (target_follow_fork): Likewise.
3050         * target.h (struct target_ops) <follow_fork>: Likewise.
3051         (target_follow_fork): Likewise.
3052
3053 2020-03-24  Tom de Vries  <tdevries@suse.de>
3054
3055         * psymtab.c (maintenance_info_psymtabs): Print user field.
3056
3057 2020-03-20  Tom Tromey  <tromey@adacore.com>
3058
3059         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
3060         const.
3061         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
3062         const.
3063
3064 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
3065
3066         * ptrace.m4: Don't check for ptrace declaration.
3067         * config.in: Re-generate.
3068         * configure: Re-generate.
3069         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
3070         not defined.
3071
3072 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
3073
3074         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
3075         `PTRACE_TYPE_RET'.
3076         * i386-bsd-nat.c (gdb_ptrace): Likewise.
3077         * sparc-nat.c (gdb_ptrace): Likewise.
3078         * x86-bsd-nat.c (gdb_ptrace): Likewise.
3079
3080 2020-03-20  Tom Tromey  <tromey@adacore.com>
3081
3082         * c-exp.y (lex_one_token): Fix assert.
3083
3084 2020-03-20  Tom Tromey  <tromey@adacore.com>
3085
3086         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
3087         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
3088         strncpy call.
3089
3090 2020-03-20  Tom Tromey  <tromey@adacore.com>
3091
3092         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
3093
3094 2020-03-20  Tom Tromey  <tromey@adacore.com>
3095
3096         * ada-valprint.c (print_variant_part): Remove parameters; switch
3097         to value-based API.
3098         (print_field_values): Likewise.
3099         (ada_val_print_struct_union): Likewise.
3100         (ada_value_print_1): Update.
3101
3102 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
3103
3104         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
3105         nbsd_nat_target instead of inf_ptrace_target.
3106         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
3107         nbsd_nat_target.
3108
3109 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
3110
3111         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
3112         it to the ptrace call.
3113         * (store_registers): Likewise.
3114
3115 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
3116
3117         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
3118         it to the ptrace call.
3119         * (store_registers): Likewise.
3120
3121 2020-03-19  Luis Machado  <luis.machado@linaro.org>
3122
3123         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
3124         valid, fetch vg value from ptrace.
3125
3126 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
3127         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
3128         * inf-ptrace.c: Likewise.
3129         * (gdb_ptrace): Add.
3130         * (inf_ptrace_target::resume): Update.
3131         * (inf_ptrace_target::xfer_partial): Likewise.
3132         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
3133         * (inf_ptrace_peek_poke): Update.
3134
3135 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
3136
3137         * x86-bsd-nat.c (gdb_ptrace): New.
3138         * (x86bsd_dr_set): Add new argument `ptid'.
3139         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
3140         x86bsd_dr_set_addr): Update.
3141
3142 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * remote.c (remote_target::process_stop_reply): Handle events for
3145         all threads differently.
3146
3147 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3148
3149         * completer.c (completion_tracker::remove_completion): Define new
3150         function.
3151         * completer.h (completion_tracker::remove_completion): Declare new
3152         function.
3153         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
3154         when adding a C++ function symbol.
3155
3156 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * completer.c (completion_tracker::completion_hash_entry): Define
3159         new class.
3160         (advance_to_filename_complete_word_point): Call
3161         recompute_lowest_common_denominator.
3162         (completion_tracker::completion_tracker): Call discard_completions
3163         to setup the hash table.
3164         (completion_tracker::discard_completions): Allow for being called
3165         from the constructor, pass new equal function, and element deleter
3166         when constructing the hash table.  Initialise new class member
3167         variables.
3168         (completion_tracker::maybe_add_completion): Remove use of
3169         m_entries_vec, and store more information into m_entries_hash.
3170         (completion_tracker::recompute_lcd_visitor): New function, most
3171         content taken from...
3172         (completion_tracker::recompute_lowest_common_denominator):
3173         ...here, this now just visits each item in the hash calling the
3174         above visitor.
3175         (completion_tracker::build_completion_result): Remove use of
3176         m_entries_vec, call recompute_lowest_common_denominator.
3177         * completer.h (completion_tracker::have_completions): Remove use
3178         of m_entries_vec.
3179         (completion_tracker::completion_hash_entry): Declare new class.
3180         (completion_tracker::recompute_lowest_common_denominator): Change
3181         function signature.
3182         (completion_tracker::recompute_lcd_visitor): Declare new function.
3183         (completion_tracker::m_entries_vec): Delete.
3184         (completion_tracker::m_entries_hash): Initialize to NULL.
3185         (completion_tracker::m_lowest_common_denominator_valid): New
3186         member variable.
3187         (completion_tracker::m_lowest_common_denominator_max_length): New
3188         member variable.
3189
3190 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3191
3192         * regformats/regdef.h: Put reg in gdb namespace.
3193
3194 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3195
3196         * i386-bsd-nat.c (gdb_ptrace): New.
3197         * (i386bsd_fetch_inferior_registers,
3198         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
3199         * (i386bsd_fetch_inferior_registers,
3200         i386bsd_store_inferior_registers) Use gdb_ptrace.
3201
3202 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3203
3204         * amd64-bsd-nat.c (gdb_ptrace): New.
3205         * (amd64bsd_fetch_inferior_registers,
3206         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
3207         * (amd64bsd_fetch_inferior_registers,
3208         amd64bsd_store_inferior_registers) Use gdb_ptrace.
3209
3210 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3211
3212         * user-regs.c (user_reg::read): Rename to...
3213         (user_reg::xread): ...this.
3214         * (append_user_reg): Rename argument `read' to `xread'.
3215         * (user_reg_add_builtin): Likewise.
3216         * (user_reg_add): Likewise.
3217         * (value_of_user_reg): Likewise.
3218
3219 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3220
3221         * sparc-nat.c (gdb_ptrace): New.
3222         * sparc-nat.c (sparc_fetch_inferior_registers)
3223         (sparc_store_inferior_registers) Remove obsolete comment.
3224         * sparc-nat.c (sparc_fetch_inferior_registers)
3225         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
3226         * sparc-nat.c (sparc_fetch_inferior_registers)
3227         (sparc_store_inferior_registers) Use gdb_ptrace.
3228
3229 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3230
3231         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
3232         it to the ptrace call.
3233         * sh-nbsd-nat.c (store_registers): Likewise.
3234
3235 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3236
3237         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
3238         nbsd_nat_target instead of inf_ptrace_target.
3239         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
3240         nbsd_nat_target.
3241
3242 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3243
3244         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
3245
3246 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
3247
3248         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
3249         <sys/sysctl.h>.
3250         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
3251
3252 2020-03-17  Tom de Vries  <tdevries@suse.de>
3253
3254         PR gdb/23710
3255         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
3256         fields.
3257         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
3258         fields.
3259         (process_imported_unit_die): Skip import of c++ CUs.
3260
3261 2020-03-16  Tom Tromey  <tom@tromey.com>
3262
3263         * p-valprint.c (pascal_object_print_value): Initialize
3264         base_value.
3265
3266 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
3267             Shahab Vahedi  <shahab@synopsys.com>
3268
3269         * Makefile.in: Add arch/arc.o
3270         * configure.tgt: Likewise.
3271         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
3272         (_initialize_arc_tdep): Don't initialize old target descriptions.
3273         (arc_read_description): New function to cache target descriptions.
3274         * arc-tdep.h (arc_read_description): Add proto type.
3275         * arch/arc.c: New file.
3276         * arch/arc.h: Likewise.
3277         * features/Makefile: Replace old target descriptions with new.
3278         * features/arc-arcompact.c: Remove.
3279         * features/arc-arcompact.xml: Likewise.
3280         * features/arc-v2.c: Likewise
3281         * features/arc-v2.xml: Likewise
3282         * features/arc/aux-arcompact.xml: New file.
3283         * features/arc/aux-v2.xml: Likewise.
3284         * features/arc/core-arcompact.xml: Likewise.
3285         * features/arc/core-v2.xml: Likewise.
3286         * features/arc/aux-arcompact.c: Generate.
3287         * features/arc/aux-v2.c: Likewise.
3288         * features/arc/core-arcompact.c: Likewise.
3289         * features/arc/core-v2.c: Likewise.
3290         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
3291
3292 2020-03-16  Tom Tromey  <tromey@adacore.com>
3293
3294         PR gdb/25663:
3295         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
3296         putting value into bcache.
3297
3298 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3299
3300         PR gdb/21500
3301         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
3302         to...
3303         (amd64_windows_init_abi_common): ... this.  Don't set size of
3304         long type.
3305         (amd64_windows_init_abi): New function.
3306         (amd64_cygwin_init_abi): New function.
3307         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
3308         the Cygwin OS ABI.
3309         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
3310         comment.
3311
3312 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3313
3314         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
3315         * windows-tdep.c (CYGWIN_DLL_NAME): New.
3316         (pe_import_directory_entry): New struct type.
3317         (is_linked_with_cygwin_dll): New function.
3318         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
3319         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
3320         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
3321
3322 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3323
3324         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
3325         i386_cygwin_core_osabi_sniffer.
3326
3327 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3328
3329         * i386-cygwin-tdep.c: Rename to...
3330         * i386-windows-tdep.c: ... this.
3331         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
3332         i386-windows-tdep.c.
3333         * configure.tgt: Likewise.
3334
3335 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3336
3337         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
3338         * osabi.c (gdb_osabi_names): Add "Windows".
3339         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
3340         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
3341         (i386_cygwin_core_osabi_sniffer): New function, extracted from
3342         i386_cygwin_osabi_sniffer.
3343         (_initialize_i386_cygwin_tdep): Register OS ABI
3344         GDB_OSABI_WINDOWS for i386.
3345         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
3346         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
3347         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
3348         for x86-64.
3349         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
3350         when the target matches '*-*-mingw*'.
3351
3352 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3353
3354         * defs.h (enum gdb_osabi): Move to...
3355         * osabi.h (enum gdb_osabi): ... here.
3356         * gdbarch.sh: Include osabi.h in gdbarch.h.
3357         * gdbarch.h: Re-generate.
3358
3359 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
3360
3361         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
3362         function.
3363         (_initialize_amd64_windows_tdep): Register osabi sniffer.
3364
3365 2020-03-14  Tom Tromey  <tom@tromey.com>
3366
3367         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
3368         for C++.
3369         (c_type_print_modifier): Likewise.  Add "language" parameter.
3370         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
3371         (c_type_print_base_1): Update.
3372         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
3373         constants.
3374         * type-stack.c (type_stack::insert): Handle tp_atomic and
3375         tp_restrict.
3376         (type_stack::follow_type_instance_flags): Likewise.
3377         (type_stack::follow_types): Likewise.  Merge type-following code.
3378         * c-exp.y (RESTRICT, ATOMIC): New tokens.
3379         (space_identifier, cv_with_space_id)
3380         (const_or_volatile_or_space_identifier_noopt)
3381         (const_or_volatile_or_space_identifier): Remove.
3382         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
3383         rules.
3384         (ptr_operator, typebase): Update.
3385         (enum token_flag) <FLAG_C>: New constant.
3386         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
3387         "_Atomic".
3388         (lex_one_token): Handle FLAG_C.
3389
3390 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3391
3392         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
3393         it to the ptrace call.
3394         * m68k-bsd-nat.c (store_registers): Likewise.
3395
3396 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3397
3398         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
3399         gdb_byte *.
3400         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
3401         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
3402         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
3403
3404 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3405
3406         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
3407         nbsd_nat_target instead of inf_ptrace_target.
3408         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
3409         nbsd_nat_target.
3410
3411 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3412
3413         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
3414         register_t.
3415
3416 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3417
3418         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
3419         it to the ptrace call.
3420         * alpha-bsd-nat.c (store_registers): Likewise.
3421
3422 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3423
3424         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
3425         includes.
3426         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
3427         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
3428         fill_fpregset): Likewise.
3429
3430 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3431
3432         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
3433         nbsd_nat_target instead of inf_ptrace_target.
3434         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
3435         nbsd_nat_target.
3436
3437 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3438
3439         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
3440         register_t.
3441
3442 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3443
3444         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
3445         it to the ptrace call.
3446         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
3447         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
3448         * arm-nbsd-nat.c (store_register): Likewise.
3449         * arm-nbsd-nat.c (store_regs): Likewise.
3450         * arm-nbsd-nat.c (store_fp_register): Likewise.
3451         * arm-nbsd-nat.c (store_fp_regs): Likewise.
3452
3453 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3454
3455         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
3456         nbsd_nat_target instead of inf_ptrace_target.
3457         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
3458         nbsd_nat_target.
3459
3460 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3461
3462         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
3463         it to the ptrace call.
3464         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
3465
3466 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3467
3468         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
3469         it to the ptrace call.
3470         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
3471
3472 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3473
3474         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
3475         gdb_byte *.
3476         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
3477
3478 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3479
3480         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
3481         instead of inf_ptrace_target.
3482         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
3483         nbsd_nat_target.
3484
3485 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3486
3487         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3488         register_t.
3489
3490 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3491
3492         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3493         register_t.
3494
3495 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
3496
3497         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
3498         register_t.
3499
3500 2020-03-13  Tom Tromey  <tom@tromey.com>
3501
3502         * value.h (val_print): Don't declare.
3503         * valprint.h (val_print_array_elements)
3504         (val_print_scalar_formatted, generic_val_print): Don't declare.
3505         * valprint.c (generic_val_print_array): Take a struct value.
3506         (generic_val_print_ptr, generic_val_print_memberptr)
3507         (generic_val_print_bool, generic_val_print_int)
3508         (generic_val_print_char, generic_val_print_complex)
3509         (generic_val_print): Remove.
3510         (generic_value_print): Update.
3511         (do_val_print): Remove unused parameters.  Don't call
3512         la_val_print.
3513         (val_print): Remove.
3514         (common_val_print): Update.  Don't call value_check_printable.
3515         (val_print_scalar_formatted, val_print_array_elements): Remove.
3516         * rust-lang.c (rust_val_print): Remove.
3517         (rust_language_defn): Update.
3518         * p-valprint.c (pascal_val_print): Remove.
3519         (pascal_value_print_inner): Update.
3520         (pascal_object_print_val_fields, pascal_object_print_val):
3521         Remove.
3522         (pascal_object_print_static_field): Update.
3523         * p-lang.h (pascal_val_print): Don't declare.
3524         * p-lang.c (pascal_language_defn): Update.
3525         * opencl-lang.c (opencl_language_defn): Update.
3526         * objc-lang.c (objc_language_defn): Update.
3527         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
3528         * m2-lang.h (m2_val_print): Don't declare.
3529         * m2-lang.c (m2_language_defn): Update.
3530         * language.h (struct language_defn) <la_val_print>: Remove.
3531         * language.c (unk_lang_value_print_inner): Rename.  Change
3532         argument types.
3533         (unknown_language_defn, auto_language_defn): Update.
3534         * go-valprint.c (go_val_print): Remove.
3535         * go-lang.h (go_val_print): Don't declare.
3536         * go-lang.c (go_language_defn): Update.
3537         * f-valprint.c (f_val_print): Remove.
3538         * f-lang.h (f_value_print): Don't declare.
3539         * f-lang.c (f_language_defn): Update.
3540         * d-valprint.c (d_val_print): Remove.
3541         * d-lang.h (d_value_print): Don't declare.
3542         * d-lang.c (d_language_defn): Update.
3543         * cp-valprint.c (cp_print_value_fields)
3544         (cp_print_value_fields_rtti, cp_print_value): Remove.
3545         (cp_print_static_field): Update.
3546         * c-valprint.c (c_val_print_array, c_val_print_ptr)
3547         (c_val_print_struct, c_val_print_union, c_val_print_int)
3548         (c_val_print_memberptr, c_val_print): Remove.
3549         * c-lang.h (c_val_print_array, cp_print_value_fields)
3550         (cp_print_value_fields_rtti): Don't declare.
3551         * c-lang.c (c_language_defn, cplus_language_defn)
3552         (asm_language_defn, minimal_language_defn): Update.
3553         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
3554         (ada_val_print_enum): Take a struct value.
3555         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
3556         (ada_val_print): Remove.
3557         (ada_value_print_1): Update.
3558         (printable_val_type): Remove.
3559         * ada-lang.h (ada_val_print): Don't declare.
3560         * ada-lang.c (ada_language_defn): Update.
3561
3562 2020-03-13  Tom Tromey  <tom@tromey.com>
3563
3564         * valprint.c (do_val_print): Update.
3565         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
3566         a struct value.
3567         (value_to_value_object_no_release): Declare.
3568         * python/py-value.c (value_to_value_object_no_release): New
3569         function.
3570         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
3571         struct value.
3572         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
3573         function.
3574         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
3575         a struct value.
3576         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
3577         Declare.
3578         (gdbscm_apply_val_pretty_printer): Take a struct value.
3579         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
3580         value.
3581         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
3582         value.
3583         * extension-priv.h (struct extension_language_ops)
3584         <apply_val_pretty_printer>: Take a struct value.
3585         * cp-valprint.c (cp_print_value): Create a struct value.
3586         (cp_print_value): Update.
3587
3588 2020-03-13  Tom Tromey  <tom@tromey.com>
3589
3590         * ada-valprint.c (print_field_values): Call common_val_print.
3591
3592 2020-03-13  Tom Tromey  <tom@tromey.com>
3593
3594         * ada-valprint.c (val_print_packed_array_elements): Remove
3595         bitoffset and val parameters.  Call common_val_print.
3596         (ada_val_print_string): Remove offset, address, and original_value
3597         parameters.
3598         (ada_val_print_array): Update.
3599         (ada_value_print_array): New function.
3600         (ada_value_print_1): Call it.
3601
3602 2020-03-13  Tom Tromey  <tom@tromey.com>
3603
3604         * ada-valprint.c (ada_value_print): Use common_val_print.
3605
3606 2020-03-13  Tom Tromey  <tom@tromey.com>
3607
3608         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
3609
3610 2020-03-13  Tom Tromey  <tom@tromey.com>
3611
3612         * ada-valprint.c (ada_value_print_num): New function.
3613         (ada_value_print_1): Use it.
3614
3615 2020-03-13  Tom Tromey  <tom@tromey.com>
3616
3617         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
3618
3619 2020-03-13  Tom Tromey  <tom@tromey.com>
3620
3621         * ada-valprint.c (ada_value_print_ptr): New function.
3622         (ada_value_print_1): Use it.
3623
3624 2020-03-13  Tom Tromey  <tom@tromey.com>
3625
3626         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
3627         call common_val_print.
3628         (ada_val_print_1): Update.
3629         (ada_value_print_1): New function.
3630         (ada_value_print_inner): Rewrite.
3631
3632 2020-03-13  Tom Tromey  <tom@tromey.com>
3633
3634         * cp-valprint.c (cp_print_value_fields): Update.
3635         (cp_print_value): New function.
3636
3637 2020-03-13  Tom Tromey  <tom@tromey.com>
3638
3639         * m2-valprint.c (m2_value_print_inner): Use
3640         cp_print_value_fields.
3641         * cp-valprint.c (cp_print_value_fields): New function.
3642         * c-valprint.c (c_value_print_struct): New function.
3643         (c_value_print_inner): Use c_value_print_struct.
3644         * c-lang.h (cp_print_value_fields): Declare.
3645
3646 2020-03-13  Tom Tromey  <tom@tromey.com>
3647
3648         * c-valprint.c (c_value_print_array): New function.
3649         (c_value_print_inner): Use it.
3650
3651 2020-03-13  Tom Tromey  <tom@tromey.com>
3652
3653         * c-valprint.c (c_value_print_memberptr): New function.
3654         (c_value_print_inner): Use it.
3655
3656 2020-03-13  Tom Tromey  <tom@tromey.com>
3657
3658         * c-valprint.c (c_value_print_int): New function.
3659         (c_value_print_inner): Use it.
3660
3661 2020-03-13  Tom Tromey  <tom@tromey.com>
3662
3663         * c-valprint.c (c_value_print_ptr): New function.
3664         (c_value_print_inner): Use it.
3665
3666 2020-03-13  Tom Tromey  <tom@tromey.com>
3667
3668         * c-valprint.c (c_value_print_inner): Rewrite.
3669
3670 2020-03-13  Tom Tromey  <tom@tromey.com>
3671
3672         * valprint.c (generic_value_print_complex): New function.
3673         (generic_value_print): Use it.
3674
3675 2020-03-13  Tom Tromey  <tom@tromey.com>
3676
3677         * valprint.c (generic_val_print_float): Don't call
3678         val_print_scalar_formatted.
3679         (generic_val_print, generic_value_print): Update.
3680
3681 2020-03-13  Tom Tromey  <tom@tromey.com>
3682
3683         * valprint.c (generic_value_print_char): New function
3684         (generic_value_print): Use it.
3685
3686 2020-03-13  Tom Tromey  <tom@tromey.com>
3687
3688         * valprint.c (generic_value_print_int): New function.
3689         (generic_value_print): Use it.
3690
3691 2020-03-13  Tom Tromey  <tom@tromey.com>
3692
3693         * valprint.c (generic_value_print_bool): New function.
3694         (generic_value_print): Use it.
3695
3696 2020-03-13  Tom Tromey  <tom@tromey.com>
3697
3698         * valprint.c (generic_val_print_func): Simplify.
3699         (generic_val_print, generic_value_print): Update.
3700
3701 2020-03-13  Tom Tromey  <tom@tromey.com>
3702
3703         * valprint.c (generic_val_print_flags): Remove.
3704         (generic_val_print, generic_value_print): Update.
3705         (val_print_type_code_flags): Add original_value parameter.
3706
3707 2020-03-13  Tom Tromey  <tom@tromey.com>
3708
3709         * valprint.c (generic_val_print): Update.
3710         (generic_value_print): Update.
3711         * valprint.c (generic_val_print_enum): Don't call
3712         val_print_scalar_formatted.
3713
3714 2020-03-13  Tom Tromey  <tom@tromey.com>
3715
3716         * valprint.c (generic_value_print): Call generic_value_print_ptr.
3717         * valprint.c (generic_value_print_ptr): New function.
3718
3719 2020-03-13  Tom Tromey  <tom@tromey.com>
3720
3721         * valprint.c (generic_value_print): Rewrite.
3722
3723 2020-03-13  Tom Tromey  <tom@tromey.com>
3724
3725         * p-valprint.c (pascal_object_print_value_fields)
3726         (pascal_object_print_value): New functions.
3727
3728 2020-03-13  Tom Tromey  <tom@tromey.com>
3729
3730         * p-valprint.c (pascal_value_print_inner): Rewrite.
3731
3732 2020-03-13  Tom Tromey  <tom@tromey.com>
3733
3734         * f-valprint.c (f_value_print_innner): Rewrite.
3735
3736 2020-03-13  Tom Tromey  <tom@tromey.com>
3737
3738         * m2-valprint.c (m2_print_unbounded_array): New overload.
3739         (m2_print_unbounded_array): Update.
3740         (m2_print_array_contents): Take a struct value.
3741         (m2_value_print_inner): Rewrite.
3742
3743 2020-03-13  Tom Tromey  <tom@tromey.com>
3744
3745         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
3746         (d_value_print_inner): New function.
3747         * d-lang.h (d_value_print_inner): Declare.
3748         * d-lang.c (d_language_defn): Use d_value_print_inner.
3749
3750 2020-03-13  Tom Tromey  <tom@tromey.com>
3751
3752         * go-valprint.c (go_value_print_inner): New function.
3753         * go-lang.h (go_value_print_inner): Declare.
3754         * go-lang.c (go_language_defn): Use go_value_print_inner.
3755
3756 2020-03-13  Tom Tromey  <tom@tromey.com>
3757
3758         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
3759         API.
3760         (rust_val_print): Rewrite.
3761         (rust_value_print_inner): New function, from rust_val_print.
3762         (rust_language_defn): Use rust_value_print_inner.
3763
3764 2020-03-13  Tom Tromey  <tom@tromey.com>
3765
3766         * ada-valprint.c (ada_value_print_inner): New function.
3767         * ada-lang.h (ada_value_print_inner): Declare.
3768         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
3769
3770 2020-03-13  Tom Tromey  <tom@tromey.com>
3771
3772         * f-valprint.c (f_value_print_innner): New function.
3773         * f-lang.h (f_value_print_innner): Declare.
3774         * f-lang.c (f_language_defn): Use f_value_print_innner.
3775
3776 2020-03-13  Tom Tromey  <tom@tromey.com>
3777
3778         * p-valprint.c (pascal_value_print_inner): New function.
3779         * p-lang.h (pascal_value_print_inner): Declare.
3780         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
3781
3782 2020-03-13  Tom Tromey  <tom@tromey.com>
3783
3784         * m2-valprint.c (m2_value_print_inner): New function.
3785         * m2-lang.h (m2_value_print_inner): Declare.
3786         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
3787
3788 2020-03-13  Tom Tromey  <tom@tromey.com>
3789
3790         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
3791         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
3792         * c-valprint.c (c_value_print_inner): New function.
3793         * c-lang.h (c_value_print_inner): Declare.
3794         * c-lang.c (c_language_defn, cplus_language_defn)
3795         (asm_language_defn, minimal_language_defn): Use
3796         c_value_print_inner.
3797
3798 2020-03-13  Tom Tromey  <tom@tromey.com>
3799
3800         * p-valprint.c (pascal_object_print_value_fields): Now static.
3801         * p-lang.h (pascal_object_print_value_fields): Don't declare.
3802
3803 2020-03-13  Tom Tromey  <tom@tromey.com>
3804
3805         * c-valprint.c (c_val_print_array): Simplify.
3806
3807 2020-03-13  Tom Tromey  <tom@tromey.com>
3808
3809         * valprint.c (value_print_array_elements): New function.
3810         * valprint.h (value_print_array_elements): Declare.
3811
3812 2020-03-13  Tom Tromey  <tom@tromey.com>
3813
3814         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
3815         * mips-tdep.c (mips_print_register): Use
3816         value_print_scalar_formatted.
3817
3818 2020-03-13  Tom Tromey  <tom@tromey.com>
3819
3820         * valprint.h (value_print_scalar_formatted): Declare.
3821         * valprint.c (value_print_scalar_formatted): New function.
3822
3823 2020-03-13  Tom Tromey  <tom@tromey.com>
3824
3825         * valprint.h (generic_value_print): Declare.
3826         * valprint.c (generic_value_print): New function.
3827
3828 2020-03-13  Tom Tromey  <tom@tromey.com>
3829
3830         * valprint.c (do_val_print): Call la_value_print_inner, if
3831         available.
3832         * rust-lang.c (rust_language_defn): Update.
3833         * p-lang.c (pascal_language_defn): Update.
3834         * opencl-lang.c (opencl_language_defn): Update.
3835         * objc-lang.c (objc_language_defn): Update.
3836         * m2-lang.c (m2_language_defn): Update.
3837         * language.h (struct language_defn) <la_value_print_inner>: New
3838         member.
3839         * language.c (unknown_language_defn, auto_language_defn): Update.
3840         * go-lang.c (go_language_defn): Update.
3841         * f-lang.c (f_language_defn): Update.
3842         * d-lang.c (d_language_defn): Update.
3843         * c-lang.c (c_language_defn, cplus_language_defn)
3844         (asm_language_defn, minimal_language_defn): Update.
3845         * ada-lang.c (ada_language_defn): Update.
3846
3847 2020-03-13  Tom Tromey  <tom@tromey.com>
3848
3849         * c-valprint.c (c_value_print): Use common_val_print.
3850
3851 2020-03-13  Tom Tromey  <tom@tromey.com>
3852
3853         * cp-valprint.c (cp_print_static_field): Use common_val_print.
3854
3855 2020-03-13  Tom Tromey  <tom@tromey.com>
3856
3857         * f-valprint.c (f77_print_array_1, f_val_print): Use
3858         common_val_print.
3859
3860 2020-03-13  Tom Tromey  <tom@tromey.com>
3861
3862         * riscv-tdep.c (riscv_print_one_register_info): Use
3863         common_val_print.
3864
3865 2020-03-13  Tom Tromey  <tom@tromey.com>
3866
3867         * mi/mi-main.c (output_register): Use common_val_print.
3868
3869 2020-03-13  Tom Tromey  <tom@tromey.com>
3870
3871         * infcmd.c (default_print_one_register_info): Use
3872         common_val_print.
3873
3874 2020-03-13  Tom Tromey  <tom@tromey.com>
3875
3876         * valprint.h (common_val_print_checked): Declare.
3877         * valprint.c (common_val_print_checked): New function.
3878         * stack.c (print_frame_arg): Use common_val_print_checked.
3879
3880 2020-03-13  Tom Tromey  <tom@tromey.com>
3881
3882         * valprint.c (do_val_print): New function, from val_print.
3883         (val_print): Use do_val_print.
3884         (common_val_print): Use do_val_print.
3885
3886 2020-03-13  Tom Tromey  <tom@tromey.com>
3887
3888         * valprint.c (value_print): Use scoped_value_mark.
3889
3890 2020-03-13  Tom de Vries  <tdevries@suse.de>
3891
3892         PR symtab/25646
3893         * psymtab.c (partial_symtab::partial_symtab): Don't set
3894         globals_offset and statics_offset.  Push element onto
3895         current_global_psymbols and current_static_psymbols stacks.
3896         (concat): New function.
3897         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
3898         element from current_global_psymbols and current_static_psymbols
3899         stacks.  Concat popped elements to global_psymbols and
3900         static_symbols.
3901         (add_psymbol_to_list): Use current_global_psymbols and
3902         current_static_psymbols stacks.
3903         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
3904         current_static_psymbols fields.
3905
3906 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3907
3908         * corelow.c (sniff_core_bfd): Remove.
3909         (class core_target) <m_core_vec>: Remove.
3910         (core_target::core_target): Update.
3911         (core_file_fns): Remove.
3912         (deprecated_add_core_fns): Remove.
3913         (default_core_sniffer): Remove.
3914         (sniff_core_bfd): Remove.
3915         (default_check_format): Remove.
3916         (gdb_check_format): Remove.
3917         (core_target_open): Update.
3918         (core_target::get_core_register_section): Update.
3919         (get_core_registers_cb): Update.
3920         (core_target::fetch_registers): Update.
3921         * gdbcore.h (struct core_fns): Remove.
3922         (deprecated_add_core_fns): Remove.
3923         (default_core_sniffer): Remove.
3924         (default_check_format): Remove.
3925
3926 2020-03-12  Tom Tromey  <tom@tromey.com>
3927
3928         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3929         CORE_ADDR.
3930         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3931
3932 2020-03-12  Tom Tromey  <tom@tromey.com>
3933
3934         * remote.c (remote_target::download_tracepoint)
3935         (remote_target::enable_tracepoint)
3936         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3937         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3938         sprintf_vma.
3939
3940 2020-03-12  Tom Tromey  <tom@tromey.com>
3941
3942         * symfile-mem.c: Update CORE_ADDR size assert.
3943
3944 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3945
3946         * selftest.m4: Move to gdbsupport/.
3947         * acinclude.m4: Update path to selftest.m4.
3948
3949 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3950
3951         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3952         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3953         gdbarch-selfselftests.c and selftest-arch.c.
3954         (SUBDIR_UNITTESTS_OBS): Rename to...
3955         (SELFTESTS_OBS): ... this.
3956         (COMMON_SFILES): Remove disasm-selftests.c and
3957         gdbarch-selftests.c.
3958         * configure.ac: Don't add selftest-arch.{c,o} to
3959         CONFIG_{SRCS,OBS}.
3960         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3961         preprocessor conditions.
3962
3963 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3964
3965         * configure.ac: Don't source bfd/development.sh.
3966         * selftest.m4: Modify comment.
3967         * configure: Re-generate.
3968
3969 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3970
3971         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3972         not "true" or "false".
3973         * configure: Re-generate.
3974
3975 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3976
3977         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3978         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3979         renamed to arm_nbsd_supply_gregset.
3980         (fetch_register): Update to call arm_nbsd_supply_gregset.
3981         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3982         (arm_netbsd_nat_target::fetch_registers): Update.
3983         (fetch_elfcore_registers): Removed.
3984         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3985         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3986         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3987         not require NetBSD system headers.
3988         (arm_nbsd_regset): New struct.
3989         (arm_nbsd_iterate_over_regset_sections): New function.
3990         (arm_netbsd_init_abi_common): Updated to call
3991         set_gdbarch_iterate_over_regset_sections.
3992         * arm-nbsd-tdep.h: New file.
3993
3994 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3995
3996         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3997         recursion.
3998
3999 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
4000
4001         * configure: Re-generate.
4002
4003 2020-03-11  Tom Tromey  <tromey@adacore.com>
4004
4005         * ada-typeprint.c (print_choices): Fix comment.
4006
4007 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
4010         previous item in the list, when the list has no items.
4011
4012 2020-03-11  Tom de Vries  <tdevries@suse.de>
4013
4014         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
4015         PROP_LOCLIST handling code.
4016
4017 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * buildsym-legacy.c (record_line): Pass extra parameter to
4020         record_line.
4021         * buildsym.c (buildsym_compunit::record_line): Take an extra
4022         parameter, reduce duplication in the line table, and record the
4023         is_stmt flag in the line table.
4024         * buildsym.h (buildsym_compunit::record_line): Add extra
4025         parameter.
4026         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
4027         non-statement lines.
4028         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
4029         this to the symtab builder.
4030         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
4031         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
4032         through to dwarf_record_line_1.
4033         * infrun.c (process_event_stop_test): When stepping, don't stop at
4034         a non-statement instruction, and only refresh the step info when
4035         we land in the middle of a line's range.  Also add an extra
4036         comment.
4037         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
4038         field.
4039         * record-btrace.c (btrace_find_line_range): Only record lines
4040         marked as is-statement.
4041         * stack.c (frame_show_address): Show the frame address if we are
4042         in a non-statement sal.
4043         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
4044         (maintenance_print_one_line_table): Print a header for the is_stmt
4045         column, and include is_stmt information in the output.
4046         * symtab.c (find_pc_sect_line): Find lines marked as statements in
4047         preference to non-statements.
4048         (find_pcs_for_symtab_line): Prefer is-statement entries.
4049         (find_line_common): Likewise.
4050         * symtab.h (struct linetable_entry): Add is_stmt field.
4051         (struct symtab_and_line): Likewise.
4052         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
4053         arranging the line table.
4054
4055 2020-03-07  Tom de Vries  <tdevries@suse.de>
4056
4057         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
4058         DIE.
4059
4060 2020-03-07  Tom Tromey  <tom@tromey.com>
4061
4062         * valops.c (value_literal_complex): Remove obsolete comment.
4063         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
4064         comment.
4065
4066 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4067
4068         * infrun.h: Forward-declare thread_info.
4069         (set_step_info): Add thread_info parameter, add doc.
4070         * infrun.c (set_step_info): Add thread_info parameter, move doc
4071         to header.
4072         * infrun.c (process_event_stop_test): Pass thread to
4073         set_step_info call.
4074         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
4075         set_step_info.
4076         (prepare_one_step): Add thread_info parameter, pass it to
4077         set_step_frame and prepare_one_step (recursive) call.
4078         (step_1): Pass thread to prepare_one_step call.
4079         (step_command_fsm::should_stop): Pass thread to
4080         prepare_one_step.
4081         (until_next_fsm): Pass thread to set_step_frame call.
4082         (finish_command): Pass thread to set_step_info call.
4083
4084 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
4085
4086         * windows-tdep.c (windows_solib_create_inferior_hook):
4087         Check if inferior is running.
4088
4089 2020-03-06  Tom de Vries  <tdevries@suse.de>
4090
4091         * NEWS: Fix "the the".
4092         * ctfread.c: Same.
4093
4094 2020-03-06  Tom de Vries  <tdevries@suse.de>
4095
4096         * psymtab.c (psymtab_to_symtab): Don't print "done.".
4097
4098 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * .dir-locals.el: Add a comment referencing the other copies of
4101         this file.
4102
4103 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
4104
4105         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
4106         psargs.
4107
4108 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4109
4110         * .gitattributes: New file.
4111
4112 2020-03-04  Tom Tromey  <tom@tromey.com>
4113
4114         * symmisc.c (print_symbol_bcache_statistics)
4115         (print_objfile_statistics): Update.
4116         * symfile.c (allocate_symtab): Use intern.
4117         * psymtab.c (partial_symtab::partial_symtab): Use intern.
4118         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4119         macro_cache>: Remove.
4120         <string_cache>: New member.
4121         (struct objfile) <intern>: New methods.
4122         * elfread.c (elf_symtab_read): Use intern.
4123         * dwarf2/read.c (fixup_go_packaging): Intern package name.
4124         (dwarf2_compute_name, dwarf2_physname)
4125         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
4126         names.
4127         (guess_partial_die_structure_name): Update.
4128         (partial_die_info::fixup): Intern name.
4129         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
4130         name.
4131         (dwarf2_name): Intern name.  Update.
4132         * buildsym.c (buildsym_compunit::get_macro_table): Use
4133         string_cache.
4134
4135 2020-03-04  Tom Tromey  <tom@tromey.com>
4136
4137         * jit.c (bfd_open_from_target_memory): Make "target" const.
4138         * corefile.c (gnutarget): Now const.
4139         * gdbcore.h (gnutarget): Now const.
4140
4141 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
4142
4143         * NEWS: Mention support for WOW64 processes.
4144         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
4145         (amd64_windows_segment_register_p): Remove static.
4146         (_initialize_amd64_windows_nat): Update.
4147         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
4148         * i386-windows-nat.c (context_offset): Update.
4149         (i386_mappings): Rename and remove static.
4150         (i386_windows_segment_register_p): Remove static.
4151         (_initialize_i386_windows_nat): Update.
4152         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
4153         (STATUS_WX86_SINGLE_STEP): New macro.
4154         (EnumProcessModulesEx): New macro.
4155         (Wow64SuspendThread): New macro.
4156         (Wow64GetThreadContext): New macro.
4157         (Wow64SetThreadContext): New macro.
4158         (Wow64GetThreadSelectorEntry): New macro.
4159         (windows_set_context_register_offsets): Add static.
4160         (windows_set_segment_register_p): Likewise.
4161         (windows_add_thread): Adapt for WOW64 processes.
4162         (windows_fetch_one_register): Likewise.
4163         (windows_nat_target::fetch_registers): Likewise.
4164         (windows_store_one_register): Likewise.
4165         (display_selector): Likewise.
4166         (display_selectors): Likewise.
4167         (handle_exception): Likewise.
4168         (windows_continue): Likewise.
4169         (windows_nat_target::resume): Likewise.
4170         (windows_add_all_dlls): Likewise.
4171         (do_initial_windows_stuff): Likewise.
4172         (windows_nat_target::attach): Likewise.
4173         (windows_get_exec_module_filename): Likewise.
4174         (windows_nat_target::create_inferior): Likewise.
4175         (windows_xfer_siginfo): Likewise.
4176         (_initialize_loadable): Initialize Wow64SuspendThread,
4177         Wow64GetThreadContext, Wow64SetThreadContext,
4178         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
4179         * windows-nat.h (windows_set_context_register_offsets):
4180         Remove declaration.
4181         (windows_set_segment_register_p): Likewise.
4182         (i386_windows_segment_register_p): Add declaration.
4183         (amd64_windows_segment_register_p): Likewise.
4184
4185 2020-03-04  Luis Machado  <luis.machado@linaro.org>
4186
4187         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
4188         in "info registers" for AArch64/ARM.
4189
4190         The change caused "info registers" to not print GPR's.
4191
4192         gdb/ChangeLog:
4193
4194         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4195
4196         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4197         when reg->group is empty and reggroup is not.
4198
4199 2020-03-03  Tom Tromey  <tromey@adacore.com>
4200
4201         * dwarf2/frame.c (struct dwarf2_frame_cache)
4202         <checked_tailcall_bottom, entry_cfa_sp_offset,
4203         entry_cfa_sp_offset_p>: Remove members.
4204         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
4205         (dwarf2_frame_prev_register): Don't call
4206         dwarf2_tailcall_sniffer_first.
4207         (dwarf2_append_unwinders): Don't append tailcall unwinder.
4208         * frame-unwind.c (add_unwinder): New fuction.
4209         (frame_unwind_init): Use it.  Add tailcall unwinder.
4210
4211 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4212             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4213
4214         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
4215         value should be printed as true.
4216
4217 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
4218
4219         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
4220         (windows_init_abi): Set and use windows_so_ops.
4221
4222 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
4223
4224         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
4225         when verifying if dealing with a convenience variable.
4226
4227 2020-03-03  Luis Machado  <luis.machado@linaro.org>
4228
4229         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
4230
4231 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4232
4233         * infrun.c (gdbarch_supports_displaced_stepping): New.
4234         (use_displaced_stepping): Break up conditions in smaller pieces.
4235         Use gdbarch_supports_displaced_stepping.
4236         (displaced_step_prepare_throw): Use
4237         gdbarch_supports_displaced_stepping.
4238
4239 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * NEWS: Mention new behaviour of the history filename.
4242         * top.c (write_history_p): Add comment.
4243         (show_write_history_p): Add header comment, give a different
4244         message when history writing is on, but the history filename is
4245         empty.
4246         (history_filename): Add comment.
4247         (history_filename_empty): New function.
4248         (show_history_filename): Add header comment, give a different
4249         message when the filename is empty.
4250         (init_history): Compare history_filename against nullptr, and only
4251         read history if the filename is not empty.
4252         (set_history_filename): Add header comment, and only make
4253         non-empty filenames absolute.
4254         (init_main): Make the filename argument to 'set history filename'
4255         optional.
4256
4257 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
4258
4259         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
4260         (arm_supply_vfpregset): ...this, and update to use VFP registers.
4261         (fetch_fp_register): Update.
4262         (fetch_fp_regs): Update.
4263         (store_fp_register): Update.
4264         (store_fp_regs): Update.
4265         (arm_netbsd_nat_target::read_description): New function.
4266         (fetch_elfcore_registers): Update.
4267
4268 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
4271         general_thread if the stop reply is missing a thread-id.
4272         (remote_target::process_stop_reply): Use the first non-exited
4273         thread if the target didn't pass a thread-id.
4274         * infrun.c (do_target_wait): Move call to
4275         switch_to_inferior_no_thread to ....
4276         (do_target_wait_1): ... here.
4277
4278 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
4279
4280         * debuginfod-support.c: Include defs.h first.
4281
4282 2020-02-28  Tom de Vries  <tdevries@suse.de>
4283
4284         * symfile.c (set_initial_language): Use default language for lookup.
4285
4286 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
4287
4288         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
4289         reader variable, pass `this` to read_cutu_die_from_dwo.
4290
4291 2020-02-27  Aaron Merey  <amerey@redhat.com>
4292
4293         * source.c (open_source_file): Check for nullptr when computing
4294         srcpath.
4295
4296 2020-02-27  Tom Tromey  <tromey@adacore.com>
4297
4298         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
4299         member.
4300         (dwarf2_add_field): Don't update nfields.
4301         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
4302
4303 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4304
4305         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
4306         abs.
4307
4308 2020-02-26  Tom Tromey  <tom@tromey.com>
4309
4310         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
4311         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
4312         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
4313         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
4314         per_cu_data.
4315
4316 2020-02-26  Tom Tromey  <tom@tromey.com>
4317
4318         * dwarf2/index-write.c (psym_index_map): Change type.
4319         (add_address_entry_worker, write_one_signatured_type)
4320         (recursively_count_psymbols, recursively_write_psymbols)
4321         (class debug_names, psyms_seen_size, write_gdbindex)
4322         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
4323
4324 2020-02-26  Aaron Merey  <amerey@redhat.com>
4325
4326         * Makefile.in: Handle optional debuginfod support.
4327         * NEWS: Update.
4328         * README: Add --with-debuginfod summary.
4329         * config.in: Regenerate.
4330         * configure: Regenerate.
4331         * configure.ac: Handle optional debuginfod support.
4332         * debuginfod-support.c: debuginfod helper functions.
4333         * debuginfod-support.h: Ditto.
4334         * doc/gdb.texinfo: Add --with-debuginfod to configure options
4335         summary.
4336         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
4337         when a dwz file cannot be found.
4338         * elfread.c (elf_symfile_read): Query debuginfod servers when a
4339         debuginfo file cannot be found.
4340         * source.c (open_source_file): Query debuginfod servers when a
4341         source file cannot be found.
4342         * top.c (print_gdb_configuration): Include
4343         --{with,without}-debuginfod in the output.
4344
4345 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
4346
4347         * thread.c (thr_try_catch_cmd): Print thread name.
4348
4349 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
4350
4351         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
4352         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4353         dwarf2_fetch_die_type_sect_off): Move to...
4354         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
4355         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4356         dwarf2_fetch_die_type_sect_off): ... here.
4357         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
4358         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4359         dwarf2_fetch_die_type_sect_off): Move doc to header file.
4360
4361 2020-02-26  Tom de Vries  <tdevries@suse.de>
4362
4363         PR gdb/25603
4364         * symfile.c (set_initial_language): Exit-early if
4365         language_mode == language_mode_manual.
4366
4367 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
4368
4369         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
4370         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
4371         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
4372
4373 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * gdbtypes.c (create_array_type_with_stride): Handle negative
4376         array strides.
4377         * valarith.c (value_subscripted_rvalue): Likewise.
4378
4379 2020-02-25  Luis Machado  <luis.machado@linaro.org>
4380
4381         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
4382
4383 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
4384
4385         * loc.h (dwarf2_get_die_type): Move to...
4386         * read.h (dwarf2_get_die_type): ... here.
4387         * read.c (dwarf2_get_die_type): Move doc to header.
4388
4389 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
4390
4391         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
4392         'gnulib/Makefile.in' to the list.
4393
4394 2020-02-24  Tom Tromey  <tom@tromey.com>
4395
4396         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
4397         Remove.
4398         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
4399         XOBNEWVEC.
4400
4401 2020-02-24  Tom Tromey  <tom@tromey.com>
4402
4403         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
4404         New method.
4405         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
4406         (dw2_do_instantiate_symtab, dw2_get_file_names)
4407         (build_type_psymtab_dependencies, load_full_type_unit): Update.
4408
4409 2020-02-24  Tom Tromey  <tom@tromey.com>
4410
4411         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
4412         make_scoped_restore.
4413         (dwarf2_psymtab::read_symtab): Don't clear
4414         reading_partial_symbols.
4415
4416 2020-02-24  Tom de Vries  <tdevries@suse.de>
4417
4418         PR gdb/25592
4419         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
4420
4421 2020-02-24  Tom de Vries  <tdevries@suse.de>
4422
4423         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
4424         commands layout next/prev/regs.
4425
4426 2020-02-22  Tom Tromey  <tom@tromey.com>
4427
4428         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
4429         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
4430
4431 2020-02-22  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
4434
4435 2020-02-22  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-win.c (_initialize_tui_win): Add usage text.
4438         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
4439         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
4440         * tui/tui.c (_initialize_tui): Add usage text.
4441
4442 2020-02-22  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-win.c (tui_set_focus_command)
4445         (tui_set_win_height_command): Use error_no_arg.
4446         (_initialize_tui_win): Update help text.
4447         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
4448
4449 2020-02-22  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
4452         * tui/tui-disasm.h (struct tui_disasm_window)
4453         <display_start_addr>: Declare.
4454         * tui/tui-source.h (struct tui_source_window)
4455         <display_start_addr>: Declare.
4456         * tui/tui-winsource.h (struct tui_source_window_base)
4457         <show_source_line, display_start_addr>: New methods.
4458         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
4459         Rename and move to protected section.
4460         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
4461         (tui_source_window_base::do_erase_source_content): Update.
4462         (tui_source_window_base::show_source_line): Now a method.
4463         (tui_source_window_base::show_source_content)
4464         (tui_source_window_base::tui_source_window_base)
4465         (tui_source_window_base::rerender)
4466         (tui_source_window_base::refill)
4467         (tui_source_window_base::do_scroll_horizontal)
4468         (tui_source_window_base::set_is_exec_point_at)
4469         (tui_source_window_base::update_breakpoint_info)
4470         (tui_source_window_base::update_exec_info): Update.
4471         * tui/tui-source.c (tui_source_window::set_contents)
4472         (tui_source_window::showing_source_p)
4473         (tui_source_window::do_scroll_vertical)
4474         (tui_source_window::location_matches_p)
4475         (tui_source_window::line_is_displayed): Update.
4476         (tui_source_window::display_start_addr): New method.
4477         * tui/tui-disasm.c (tui_disasm_window::set_contents)
4478         (tui_disasm_window::do_scroll_vertical)
4479         (tui_disasm_window::location_matches_p): Update.
4480         (tui_disasm_window::display_start_addr): New method.
4481
4482 2020-02-22  Tom Tromey  <tom@tromey.com>
4483
4484         * NEWS: Add entry for gdb.register_window_type.
4485         * tui/tui-layout.h (window_factory): New typedef.
4486         (tui_register_window): Declare.
4487         * tui/tui-layout.c (saved_tui_windows): New global.
4488         (tui_apply_current_layout): Use it.
4489         (tui_register_window): New function.
4490         * python/python.c (do_start_initialization): Call
4491         gdbpy_initialize_tui.
4492         (python_GdbMethods): Add "register_window_type" function.
4493         * python/python-internal.h (gdbpy_register_tui_window)
4494         (gdbpy_initialize_tui): Declare.
4495         * python/py-tui.c: New file.
4496         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
4497
4498 2020-02-22  Tom Tromey  <tom@tromey.com>
4499
4500         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
4501
4502 2020-02-22  Tom Tromey  <tom@tromey.com>
4503
4504         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
4505         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
4506         * tui/tui-data.c (tui_set_win_with_focus): Remove.
4507         (tui_set_win_focus_to): Move from tui-win.c.
4508
4509 2020-02-22  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-layout.c (make_standard_window, get_locator_window): New
4512         functions.
4513         (known_window_types): New global.
4514         (tui_get_window_by_name): Reimplement.
4515         (initialize_known_windows): New function.
4516         (validate_window_name): Rewrite.
4517         (_initialize_tui_layout): Call initialize_known_windows.
4518
4519 2020-02-22  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
4522         Remove constants.
4523         * tui/tui-winsource.h (struct tui_source_window_base)
4524         <tui_source_window_base>: Remove parameter.
4525         * tui/tui-winsource.c
4526         (tui_source_window_base::tui_source_window_base): Remove
4527         parameter.
4528         (tui_source_window_base::refill): Update.
4529         * tui/tui-stack.h (struct tui_locator_window)
4530         <tui_locator_window>: Update.
4531         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
4532         Default the constructor.
4533         * tui/tui-regs.h (struct tui_data_item_window)
4534         <tui_data_item_window>: Default the constructor.
4535         (struct tui_data_window) <tui_data_window>: Likewise.
4536         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
4537         Default the constructor.
4538         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
4539         Default the constructor.
4540         <type>: Remove.
4541         (struct tui_win_info) <tui_win_info>: Default the constructor.
4542         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
4543         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
4544         Default the constructor.
4545
4546 2020-02-22  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
4549         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
4550         * tui/tui-win.c (tui_resize_all): Don't call
4551         tui_delete_invisible_windows.
4552         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
4553         done.
4554         (tui_set_layout): Update.
4555         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
4556         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
4557         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
4558
4559 2020-02-22  Tom Tromey  <tom@tromey.com>
4560
4561         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
4562         correctly.
4563
4564 2020-02-22  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
4567
4568 2020-02-22  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui-winsource.h (struct tui_source_window_iterator)
4571         <inner_iterator>: New etytypedef.
4572         <tui_source_window_iterator>: Take "end" parameter.
4573         <tui_source_window_iterator>: Take iterator.
4574         <operator*, advance>: Update.
4575         <m_iter>: Change type.
4576         <m_end>: New field.
4577         (struct tui_source_windows) <begin, end>: Update.
4578         * tui/tui-layout.c (tui_windows): New global.
4579         (tui_apply_current_layout): Clear tui_windows.
4580         (tui_layout_window::apply): Update tui_windows.
4581         * tui/tui-data.h (tui_windows): Declare.
4582         (all_tui_windows): Now inline function.
4583         (class tui_window_iterator, struct all_tui_windows): Remove.
4584
4585 2020-02-22  Tom Tromey  <tom@tromey.com>
4586
4587         PR tui/17850:
4588         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
4589         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
4590         "height" argument.
4591         (class tui_layout_window) <get_sizes>: Likewise.
4592         (class tui_layout_split) <tui_layout_split>: Add "vertical"
4593         argument.
4594         <get_sizes>: Add "height" argument.
4595         <m_vertical>: New field.
4596         * tui/tui-layout.c (tui_layout_split::clone): Update.
4597         (tui_layout_split::get_sizes): Add "height" argument.
4598         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
4599         (tui_new_layout_command): Parse "-horizontal".
4600         (_initialize_tui_layout): Update help string.
4601         (tui_layout_split::specification): Add "-horizontal" when needed.
4602         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
4603         argument.
4604         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
4605         New methods.
4606
4607 2020-02-22  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-layout.h (enum tui_adjust_result): New.
4610         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
4611         (class tui_layout_window) <adjust_size>: Return
4612         tui_adjust_result.  Rewrite.
4613         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
4614         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
4615
4616 2020-02-22  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
4619         parameter and return types.
4620         (class tui_layout_base) <specification>: Add "depth".
4621         (class tui_layout_window) <specification>: Add "depth".
4622         (class tui_layout_split) <specification>: Add "depth".
4623         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
4624         and return types.
4625         (tui_new_layout_command): Parse sub-layouts.
4626         (_initialize_tui_layout): Update help string.
4627         (tui_layout_window::specification): Add "depth".
4628         (add_layout_command): Update.
4629
4630 2020-02-22  Tom Tromey  <tom@tromey.com>
4631
4632         * NEWS: Add "tui new-layout" item.
4633         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
4634         Add new-layout command to help text.
4635         (validate_window_name): New function.
4636         (tui_new_layout_command): New function.
4637         (_initialize_tui_layout): Register "new-layout".
4638         (tui_layout_window::specification): New method.
4639         (tui_layout_window::specification): New method.
4640         * tui/tui-layout.h (class tui_layout_base) <specification>: New
4641         method.
4642         (class tui_layout_window) <specification>: New method.
4643         (class tui_layout_split) <specification>: New method.
4644
4645 2020-02-22  Tom Tromey  <tom@tromey.com>
4646
4647         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
4648         * tui/tui-win.c (window_name_completer): Update comment.
4649         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
4650         Declare method.
4651         (class tui_layout_window) <replace_window>: Likewise.
4652         (class tui_layout_split) <replace_window>: Likewise.
4653         (tui_set_layout): Don't declare.
4654         (tui_set_initial_layout): Declare function.
4655         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
4656         (asm_regs_layout): New globals.
4657         (tui_current_layout, show_layout): Remove.
4658         (tui_set_layout, tui_add_win_to_layout): Rewrite.
4659         (find_layout, tui_apply_layout): New function.
4660         (layout_completer): Remove.
4661         (tui_next_layout): Reimplement.
4662         (tui_next_layout_command): New function.
4663         (tui_set_initial_layout, tui_prev_layout_command): New functions.
4664         (tui_regs_layout): Reimplement.
4665         (tui_regs_layout_command): New function.
4666         (extract_display_start_addr): Rewrite.
4667         (next_layout, prev_layout): Remove.
4668         (tui_layout_window::replace_window): New method.
4669         (tui_layout_split::replace_window): New method.
4670         (destroy_layout): New function.
4671         (layout_list): New global.
4672         (add_layout_command): New function.
4673         (initialize_layouts): Update.
4674         (tui_layout_command): New function.
4675         (_initialize_tui_layout): Install "layout" commands.
4676         * tui/tui-data.h (enum tui_layout_type): Remove.
4677         (tui_current_layout): Don't declare.
4678
4679 2020-02-22  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-regs.c (tui_reg_layout): Remove.
4682         (tui_reg_command): Use tui_regs_layout.
4683         * tui/tui-layout.h (tui_reg_command): Declare.
4684         * tui/tui-layout.c (tui_reg_command): New function.
4685
4686 2020-02-22  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui.c (tui_rl_delete_other_windows): Call
4689         tui_remove_some_windows.
4690         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
4691         Declare method.
4692         (class tui_layout_window) <remove_windows>: New method.
4693         (class tui_layout_split) <remove_windows>: Declare.
4694         (tui_remove_some_windows): Declare.
4695         * tui/tui-layout.c (tui_remove_some_windows): New function.
4696         (tui_layout_split::remove_windows): New method.
4697
4698 2020-02-22  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
4701         * tui/tui-layout.h (tui_next_layout): Declare.
4702         * tui/tui-layout.c (tui_next_layout): New function.
4703
4704 2020-02-22  Tom Tromey  <tom@tromey.com>
4705
4706         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
4707         correct coordinates.
4708
4709 2020-02-22  Tom Tromey  <tom@tromey.com>
4710
4711         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
4712         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
4713         DATA_WIN case.
4714
4715 2020-02-22  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
4718         TUI_DISASM_WIN, not tui_win_list.
4719
4720 2020-02-22  Tom Tromey  <tom@tromey.com>
4721
4722         * valprint.c (generic_val_print_enum_1)
4723         (val_print_type_code_flags): Style member names.
4724         * rust-lang.c (val_print_struct, rust_print_enum)
4725         (rust_print_struct_def, rust_internal_print_type): Style member
4726         names.
4727         * p-valprint.c (pascal_object_print_value_fields): Style member
4728         names.  Only call fprintf_symbol_filtered for static members.
4729         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
4730         * f-valprint.c (f_val_print): Style member names.
4731         * f-typeprint.c (f_type_print_base): Style member names.
4732         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
4733         call fprintf_symbol_filtered for static members.
4734         (cp_print_class_member): Style member names.
4735         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
4736         member names.
4737         * ada-valprint.c (ada_print_scalar): Style enum names.
4738         (ada_val_print_enum): Likewise.
4739         * ada-typeprint.c (print_enum_type): Style enum names.
4740
4741 2020-02-21  Tom Tromey  <tom@tromey.com>
4742
4743         * psympriv.h (struct partial_symtab): Update comment.
4744
4745 2020-02-21  Tom Tromey  <tromey@adacore.com>
4746
4747         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
4748         type is CORE_ADDR.
4749
4750 2020-02-21  Tom de Vries  <tdevries@suse.de>
4751
4752         PR gdb/25534
4753         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
4754         if dependencies[i]->user != NULL.
4755
4756 2020-02-21  Ali Tamur  <tamur@google.com>
4757
4758         * dwarf2/read.c (dwarf2_name): Add null check.
4759
4760 2020-02-20  Tom Tromey  <tom@tromey.com>
4761
4762         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
4763         ">=", in binary search.
4764         (dwarf2_find_containing_comp_unit): New overload.
4765         (run_test): New self-test.
4766         (_initialize_dwarf2_read): Register new test.
4767
4768 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
4769
4770         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
4771         * riscv-tdep.h: Likewise.
4772         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
4773         rv32-only CSR.
4774         * features/riscv/64bit-csr.xml: Regenerated.
4775
4776 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
4777             Tom Tromey  <tom@tromey.com>
4778
4779         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
4780         of 'fputc_unfiltered'.
4781         (putchar_unfiltered): Call 'fputc_unfiltered'.
4782         (fputc_unfiltered): Call 'fputs_unfiltered'.
4783
4784 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
4785
4786         * config.in: Regenerate.
4787         * configure: Regenerate.
4788         * configure.ac: Add --with-python-libdir option.
4789         * main.c: Use WITH_PYTHON_LIBDIR.
4790
4791 2020-02-19  Tom Tromey  <tom@tromey.com>
4792
4793         * symtab.c (general_symbol_info::compute_and_set_names): Use
4794         obstack_strndup.  Simplify call to symbol_set_demangled_name.
4795
4796 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
4797
4798         * dwarf2/read.c (allocate_signatured_type_table,
4799         allocate_dwo_unit_table, allocate_type_unit_groups_table,
4800         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
4801         Remove objfile parameter, update all callers.
4802
4803 2020-02-19  Doug Evans  <dje@google.com>
4804
4805         PR rust/25535
4806         * rust-lang.c (rust_print_enum): Apply embedded_offset to
4807         rust_enum_variant calculation.
4808
4809 2020-02-19  Tom Tromey  <tromey@adacore.com>
4810
4811         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
4812
4813 2020-02-19  Tom Tromey  <tromey@adacore.com>
4814
4815         * ada-lang.c (cache_symbol): Use obstack_strdup.
4816
4817 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * configure: Regenerate.
4820
4821 2020-02-19  Tom Tromey  <tromey@adacore.com>
4822
4823         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
4824         NULL check.
4825
4826 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
4827
4828         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
4829
4830 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
4833         if GDBSERVER is not defined.
4834         (riscv_tdesc_cache): Likewise, also store const target_desc.
4835         (STATIC_IN_GDB): Define.
4836         (riscv_create_target_description): Update declaration with
4837         STATIC_IN_GDB.
4838         (riscv_lookup_target_description): New function, only define if
4839         GDBSERVER is not defined.
4840         * arch/riscv.h (riscv_create_target_description): Declare only
4841         when GDBSERVER is defined.
4842         (riscv_lookup_target_description): New declaration when GDBSERVER
4843         is not defined.
4844         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
4845         (riscv_linux_read_features): ...this, and return
4846         riscv_gdbarch_features instead of target_desc.
4847         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
4848         (riscv_linux_read_description): Rename to...
4849         (riscv_linux_read_features): ...this.
4850         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4851         Update to use riscv_gdbarch_features and
4852         riscv_lookup_target_description.
4853         * riscv-tdep.c (riscv_find_default_target_description): Use
4854         riscv_lookup_target_description instead of
4855         riscv_create_target_description.
4856
4857 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4858
4859         * valprint.c (generic_val_print_enum_1): When printing a flag
4860         enum with value 0 and there is no enumerator with value 0, print
4861         just "0" instead of "(unknown: 0x0)".
4862
4863 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4864
4865         * valprint.c (generic_val_print_enum_1): Print unknown part of
4866         flag enum in hex.
4867
4868 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4869
4870         * dwarf2/read.c (update_enumeration_type_from_children): Allow
4871         flag enums to contain duplicate enumerators.
4872         * valprint.c (generic_val_print_enum_1): Update comment.
4873
4874 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4875
4876         * dwarf2/read.c: Include "count-one-bits.h".
4877         (update_enumeration_type_from_children): If an enumerator has
4878         multiple bits set, don't treat the enumeration as a "flag enum".
4879         * valprint.c (generic_val_print_enum_1): Assert that enumerators
4880         of flag enums have 0 or 1 bit set.
4881
4882 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4883
4884         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
4885         conversion.
4886         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4887         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4888         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4889         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4890         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4891
4892 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4893
4894         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
4895
4896 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4897
4898         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
4899         displaced_step_closure_up.
4900         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4901         (struct displaced_step_closure_up):
4902         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4903         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4904         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
4905         Likewise.
4906         * gdbarch.sh (displaced_step_copy_insn): Likewise.
4907         * gdbarch.c, gdbarch.h: Re-generate.
4908         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
4909         displaced_step_closure_up.
4910         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4911         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4912         * infrun.h (displaced_step_closure_up): New type alias.
4913         (struct displaced_step_inferior_state) <step_closure>: Change
4914         type to displaced_step_closure_up.
4915         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
4916         displaced_step_closure_up.
4917         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4918
4919 2020-02-14  Tom Tromey  <tom@tromey.com>
4920
4921         * minidebug.c (gnu_debug_key): New global.
4922         (find_separate_debug_file_in_section): Use it.
4923
4924 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4925
4926         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4927         std::unique_ptr.
4928         * gdbarch.c: Re-generate.
4929         * gdbarch.h: Re-generate.
4930         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4931         change.
4932         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4933         type to std::unique_ptr.
4934         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4935         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4936         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4937         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4938         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4939         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4940         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4941         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4942         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4943
4944 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4947         std::unique_ptr.
4948         (displaced_step_clear): Rename to...
4949         (displaced_step_reset): ... this.  Just call displaced->reset ().
4950         (displaced_step_clear_cleanup): Rename to...
4951         (displaced_step_reset_cleanup): ... this.
4952         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4953         (displaced_step_fixup): Likewise.
4954         (resume_1): Likewise.
4955         (handle_inferior_event): Restore child's memory before calling
4956         displaced_step_fixup on the parent.
4957         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4958         to std::unique_ptr.
4959         <step_closure>: Change type to std::unique_ptr.
4960
4961 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4962
4963         * arm-tdep.c: Include count-one-bits.h.
4964         (cleanup_block_store_pc): Use count_one_bits.
4965         (cleanup_block_load_pc): Use count_one_bits.
4966         (arm_copy_block_xfer): Use count_one_bits.
4967         (thumb2_copy_block_xfer): Use count_one_bits.
4968         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4969         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4970         (thumb_get_next_pcs_raw): Use count_one_bits.
4971         (arm_get_next_pcs_raw): Use count_one_bits_l.
4972         * arch/arm.c (bitcount): Remove.
4973         * arch/arm.h (bitcount): Remove.
4974
4975 2020-02-14  Tom Tromey  <tromey@adacore.com>
4976
4977         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4978         Update.
4979         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4980         * dwarf2/loc.c (call_site_find_chain_1): Return
4981         unique_xmalloc_ptr.
4982         (call_site_find_chain): Likewise.
4983
4984 2020-02-14  Richard Biener  <rguenther@suse.de>
4985
4986         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4987         on expression with division operators.
4988
4989 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4990
4991         * MAINTAINERS (Write After Approval): Adding myself.
4992
4993 2020-02-12  Tom Tromey  <tom@tromey.com>
4994
4995         * event-loop.c (event_data, gdb_event, event_handler_func):
4996         Remove.
4997
4998 2020-02-12  Tom Tromey  <tom@tromey.com>
4999
5000         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
5001         (dwarf2_frame_objfile_data): Add comment.
5002         (find_comp_unit, set_comp_unit): New functions.
5003         (dwarf2_frame_find_fde): Use find_comp_unit.
5004         (dwarf2_build_frame_info): Use set_comp_unit.
5005
5006 2020-02-12  Tom Tromey  <tom@tromey.com>
5007
5008         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
5009         (comp_unit): Don't initialize objfile.
5010         (execute_cfa_program): Add text_offset parameter.
5011         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
5012         (dwarf2_frame_cache): Update.
5013         (dwarf2_build_frame_info): Don't set "objfile" member.
5014
5015 2020-02-12  Tom Tromey  <tom@tromey.com>
5016
5017         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
5018         (decode_frame_entry): Likewise.
5019         (dwarf2_build_frame_info): Update.
5020
5021 2020-02-12  Tom Tromey  <tom@tromey.com>
5022
5023         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
5024         (decode_frame_entry_1): Use the comp_unit obstack.
5025
5026 2020-02-12  Tom Tromey  <tom@tromey.com>
5027
5028         * dwarf2/frame.c (struct comp_unit): Add initializers and
5029         constructor.
5030         (dwarf2_frame_objfile_data): Store a comp_unit.
5031         (dwarf2_frame_find_fde): Update.
5032         (dwarf2_build_frame_info): Use "new".
5033
5034 2020-02-12  Tom Tromey  <tom@tromey.com>
5035
5036         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
5037         (dwarf2_fde_table): Typedef for std::vector.
5038         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
5039         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
5040         (decode_frame_entry): Update.
5041         (dwarf2_build_frame_info): Use "new".
5042
5043 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
5044
5045         * arm-tdep.c (arm_gdbarch_init): Update.
5046         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
5047         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
5048         have_neon, is_m>: Change to bool.
5049
5050 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
5051
5052         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
5053
5054 2020-02-12  Tom Tromey  <tom@tromey.com>
5055
5056         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
5057
5058 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
5059
5060         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
5061         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
5062
5063 2020-02-11  Tom Tromey  <tom@tromey.com>
5064
5065         * psymtab.h: Update comment.
5066
5067 2020-02-11  Tom Tromey  <tom@tromey.com>
5068
5069         * gdb_obstack.h (struct auto_obstack): Use
5070         DISABLE_COPY_AND_ASSIGN.
5071
5072 2020-02-11  Tom Tromey  <tom@tromey.com>
5073
5074         * dwarf2/frame.h (struct objfile): Don't forward declare.
5075
5076 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
5077
5078         * cris-tdep.c (cris_supply_gregset): Change signature to match
5079         what struct regset expects.
5080         (cris_regset): New struct.
5081         (fetch_core_registers): Remove.
5082         (cris_iterate_over_regset_sections): New function.
5083         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
5084         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
5085
5086 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
5087
5088         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
5089         registers.
5090
5091 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
5092
5093         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
5094
5095 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
5096
5097         * configure: Re-generate.
5098
5099 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
5100
5101         * configure: Re-generate.
5102
5103 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
5104
5105         * acinclude: Update warning.m4 path.
5106         * warning.m4: Move to gdbsupport.
5107
5108 2020-02-11  Tom Tromey  <tromey@adacore.com>
5109
5110         * remote.c (remote_console_output): Update.
5111         * printcmd.c (printf_command): Update.
5112         * event-loop.c (gdb_wait_for_event): Update.
5113         * linux-nat.c (sigchld_handler): Update.
5114         * remote-sim.c (gdb_os_write_stdout): Update.
5115         (gdb_os_flush_stdout): Update.
5116         (gdb_os_flush_stderr): Update.
5117         (gdb_os_write_stderr): Update.
5118         * exceptions.c (print_exception): Update.
5119         * remote-fileio.c (remote_fileio_func_read): Update.
5120         (remote_fileio_func_write): Update.
5121         * tui/tui.c (tui_enable): Update.
5122         * tui/tui-interp.c (tui_interp::init): Update.
5123         * utils.c (init_page_info): Update.
5124         (putchar_unfiltered, fputc_unfiltered): Update.
5125         (gdb_flush): Update.
5126         (emit_style_escape): Update.
5127         (flush_wrap_buffer, fputs_maybe_filtered): Update.
5128         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
5129         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
5130         (stderr_file::write): Update.
5131         (stderr_file::puts): Update.
5132         * ui-file.h (ui_file_isatty, ui_file_write)
5133         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
5134         (ui_file_puts): Don't declare.
5135
5136 2020-02-10  Tom de Vries  <tdevries@suse.de>
5137
5138         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
5139         sentinel to char *.
5140
5141 2020-02-09  Tom de Vries  <tdevries@suse.de>
5142
5143         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
5144         filename if it matches "<artificial>".
5145
5146 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
5147
5148         * windows-tdep.c (struct enum_value_name): New struct.
5149         (create_enum): New function.
5150         (windows_get_siginfo_type): Create and use enum types.
5151
5152 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
5153
5154         * NEWS: Mention $_siginfo support for Windows.
5155         * windows-nat.c (handle_exception): Set siginfo_er.
5156         (windows_nat_target::mourn_inferior): Reset siginfo_er.
5157         (windows_xfer_siginfo): New function.
5158         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
5159         * windows-tdep.c (struct windows_gdbarch_data): New struct.
5160         (init_windows_gdbarch_data): New function.
5161         (get_windows_gdbarch_data): New function.
5162         (windows_get_siginfo_type): New function.
5163         (windows_init_abi): Register windows_get_siginfo_type.
5164         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
5165
5166 2020-02-08  Tom Tromey  <tom@tromey.com>
5167
5168         * dwarf2/read.c (class cutu_reader) <cutu_reader,
5169         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
5170         <keep>: Declare method.
5171         <m_keep>: Remove member.
5172         <~cutu_reader>: Remove.
5173         (cutu_reader::init_tu_and_read_dwo_dies): Update.
5174         (cutu_reader::cutu_reader): Update.
5175         (cutu_reader::keep): Rename from ~cutu_reader.
5176         (process_psymtab_comp_unit, build_type_psymtabs_1)
5177         (process_skeletonless_type_unit, load_partial_comp_unit)
5178         (load_full_comp_unit, dwarf2_read_addr_index)
5179         (read_signatured_type): Update.
5180
5181 2020-02-08  Tom Tromey  <tom@tromey.com>
5182
5183         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
5184         "want_partial_unit" parameter.
5185         (process_psymtab_comp_unit): Change want_partial_unit to bool.
5186         Inline check for DW_TAG_partial_unit.
5187         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
5188
5189 2020-02-08  Tom Tromey  <tom@tromey.com>
5190
5191         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
5192         read.c.
5193         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
5194         read.c.
5195
5196 2020-02-08  Tom Tromey  <tom@tromey.com>
5197
5198         * dwarf2/read.c (read_address): Move to comp-unit.c.
5199         (dwarf2_rnglists_process, dwarf2_ranges_process)
5200         (read_attribute_value, dwarf_decode_lines_1)
5201         (var_decode_location, decode_locdesc): Update.
5202         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
5203         read.c.  Remove "cu" parameter.
5204         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
5205         method.
5206
5207 2020-02-08  Tom Tromey  <tom@tromey.com>
5208
5209         * dwarf2/read.c (read_attribute_value, read_indirect_string)
5210         (read_indirect_line_string): Update.
5211         * dwarf2/comp-unit.c (read_offset): Remove.
5212         (read_comp_unit_head): Update.
5213         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
5214         method.
5215         (read_offset): Don't declare.
5216
5217 2020-02-08  Tom Tromey  <tom@tromey.com>
5218
5219         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
5220         * dwarf2/read.c (struct comp_unit_head): Move to
5221         dwarf2/comp-unit.h.
5222         (enum class rcuh_kind): Move to comp-unit.h.
5223         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
5224         (read_comp_unit_head, error_check_comp_unit_head)
5225         (read_and_check_comp_unit_head): Move to comp-unit.c.
5226         (read_offset, dwarf_unit_type_name): Likewise.
5227         (create_debug_type_hash_table, read_cutu_die_from_dwo)
5228         (cutu_reader::cutu_reader, read_call_site_scope)
5229         (find_partial_die, follow_die_offset): Update.
5230         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
5231
5232 2020-02-08  Tom Tromey  <tom@tromey.com>
5233
5234         * dwarf2/read.c (read_offset_1): Move to leb.c.
5235         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
5236         (dwarf_decode_macro_bytes): Update.
5237         * dwarf2/leb.c (read_offset): Rename; move from read.c.
5238         * dwarf2/leb.h (read_offset): Declare.
5239
5240 2020-02-08  Tom Tromey  <tom@tromey.com>
5241
5242         * dwarf2/read.c (dwarf2_section_size): Remove.
5243         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
5244         Update.
5245         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
5246
5247 2020-02-08  Tom Tromey  <tom@tromey.com>
5248
5249         * dwarf2/read.c (read_initial_length): Move to leb.c.
5250         * dwarf2/leb.h (read_initial_length): Declare.
5251         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
5252         handle_nonstd parameter.
5253         * dwarf2/frame.c (read_initial_length): Remove.
5254         (decode_frame_entry_1): Update.
5255
5256 2020-02-08  Tom Tromey  <tom@tromey.com>
5257
5258         * dwarf2/loc.c (dwarf2_find_location_expression)
5259         (dwarf_evaluate_loc_desc::get_tls_address)
5260         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
5261         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
5262         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
5263         (dwarf2_compile_property_to_c)
5264         (dwarf2_loc_desc_get_symbol_read_needs)
5265         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
5266         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
5267         (loclist_describe_location, loclist_tracepoint_var_ref)
5268         (loclist_generate_c_location): Update.
5269         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
5270         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
5271         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
5272         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
5273         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
5274         (dwarf2_per_cu_data::addr_size)
5275         (dwarf2_per_cu_data::ref_addr_size)
5276         (dwarf2_per_cu_data::text_offset)
5277         (dwarf2_per_cu_data::addr_type): Now methods.
5278         (per_cu_header_read_in): Make per_cu "const".
5279         (dwarf2_version): Remove.
5280         (dwarf2_per_cu_data::int_type): Now a method.
5281         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
5282         (set_die_type, read_array_type, read_subrange_index_type)
5283         (read_tag_string_type, read_subrange_type): Update.
5284         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
5285         offset_size, ref_addr_size, text_offset, addr_type, version,
5286         objfile, int_type, addr_sized_int_type>: Declare methods.
5287
5288 2020-02-08  Tom Tromey  <tom@tromey.com>
5289
5290         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
5291         Move earlier.
5292
5293 2020-02-08  Tom Tromey  <tom@tromey.com>
5294
5295         * dwarf2/read.h (dwarf_line_debug): Declare.
5296         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
5297         * dwarf2/read.c: Move line_header code to new files.
5298         (dwarf_line_debug): No longer static.
5299         * dwarf2/line-header.c: New file.
5300         * dwarf2/line-header.h: New file.
5301
5302 2020-02-08  Tom Tromey  <tom@tromey.com>
5303
5304         * dwarf2/read.c (struct line_header) <file_full_name,
5305         file_file_name>: Return unique_xmalloc_ptr.
5306         (line_header::file_file_name): Update.
5307         (line_header::file_full_name): Update.
5308         (dw2_get_file_names_reader): Update.
5309         (macro_start_file): Update.
5310
5311 2020-02-08  Tom Tromey  <tom@tromey.com>
5312
5313         * dwarf2/read.c (struct line_header) <file_full_name,
5314         file_file_name>: Declare methods.
5315         (dw2_get_file_names_reader): Update.
5316         (file_file_name): Now a method.
5317         (file_full_name): Likewise.
5318         (macro_start_file): Update.
5319
5320 2020-02-08  Tom Tromey  <tom@tromey.com>
5321
5322         * dwarf2/read.c (dwarf_always_disassemble)
5323         (show_dwarf_always_disassemble): Move to loc.c.
5324         (_initialize_dwarf2_read): Move "always-disassemble" registration
5325         to loc.c.
5326         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
5327         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
5328         static.
5329         (show_dwarf_always_disassemble): Move from read.c.
5330         (_initialize_dwarf2loc): Move always-disassemble from read.c.
5331
5332 2020-02-08  Tom Tromey  <tom@tromey.com>
5333
5334         * dwarf2/read.c (~dwarf2_per_objfile): Update.
5335         (create_quick_file_names_table): Return htab_up.
5336         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
5337         Update.
5338         * dwarf2/read.h (struct dwarf2_per_objfile)
5339         <quick_file_names_table>: Now htab_up.
5340
5341 2020-02-08  Tom Tromey  <tom@tromey.com>
5342
5343         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
5344
5345 2020-02-08  Tom Tromey  <tom@tromey.com>
5346
5347         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
5348         Rewrite.
5349         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
5350         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
5351         (abbrev_table::abbrev_table): No longer inline.
5352         (ABBREV_HASH_SIZE): Remove.
5353         (abbrev_table::m_abbrevs): Now an htab_up.
5354
5355 2020-02-08  Tom Tromey  <tom@tromey.com>
5356
5357         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
5358         (cutu_reader): Update.
5359         (build_type_psymtabs_1): Update.
5360         * dwarf2/abbrev.c (abbrev_table::read): Rename.
5361         (abbrev_table::alloc_abbrev): Update.
5362         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
5363         (abbrev_table::read): New static method, renamed from
5364         abbrev_table_read_table.
5365         (abbrev_table::alloc_abbrev)
5366         (abbrev_table::add_abbrev): Now private.
5367         (abbrev_table::abbrev_table): Now private.
5368         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
5369
5370 2020-02-08  Tom Tromey  <tom@tromey.com>
5371
5372         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
5373         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
5374         htab_up.
5375
5376 2020-02-08  Tom Tromey  <tom@tromey.com>
5377
5378         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
5379         htab_up.
5380         (lookup_dwo_unit_in_dwp): Update.
5381         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
5382         on obstack.
5383
5384 2020-02-08  Tom Tromey  <tom@tromey.com>
5385
5386         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
5387         obstack.
5388
5389 2020-02-08  Tom Tromey  <tom@tromey.com>
5390
5391         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
5392         line_header_hash.
5393         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
5394         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
5395         Change type to htab_up.
5396
5397 2020-02-08  Tom Tromey  <tom@tromey.com>
5398
5399         * dwarf2/read.c (allocate_type_unit_groups_table): Return
5400         htab_up.  Don't allocate on obstack.
5401         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
5402         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
5403         Change type to htab_up.
5404
5405 2020-02-08  Tom Tromey  <tom@tromey.com>
5406
5407         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
5408         Change type to htab_up.
5409         * dwarf2/read.c (create_signatured_type_table_from_index)
5410         (create_signatured_type_table_from_debug_names)
5411         (create_all_type_units, add_type_unit)
5412         (lookup_dwo_signatured_type, lookup_signatured_type)
5413         (process_skeletonless_type_unit): Update.
5414         (create_debug_type_hash_table, create_debug_types_hash_table):
5415         Change type of types_htab.
5416         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
5417         htab_up.  Don't allocate on obstack.
5418         (create_cus_hash_table): Change type of cus_htab parameter.
5419         (struct dwo_file) <cus, tus>: Now htab_up.
5420         (lookup_dwo_signatured_type, lookup_dwo_cutu)
5421         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
5422         (queue_and_load_all_dwo_tus): Update.
5423         * dwarf2/index-write.c (write_gdbindex): Update.
5424         (write_debug_names): Update.
5425
5426 2020-02-08  Tom Tromey  <tom@tromey.com>
5427
5428         * dwarf2/read.h (struct dwarf2_queue_item): Move from
5429         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
5430         destructor.
5431         (struct dwarf2_per_objfile) <queue>: New member.
5432         * dwarf2/read.c (struct dwarf2_queue_item): Move to
5433         dwarf2/read.h.
5434         (dwarf2_queue, dwarf2_queue_tail): Remove.
5435         (class dwarf2_queue_guard): Add parameter to constructor.  Use
5436         DISABLE_COPY_AND_ASSIGN.
5437         <m_per_objfile>: New member.
5438         <~dwarf2_queue_guard>: Rewrite.
5439         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
5440         Update.
5441         (~dwarf2_queue_item): New.
5442
5443 2020-02-08  Tom Tromey  <tom@tromey.com>
5444
5445         * dwarf2/read.c (struct die_info) <has_children>: New member.
5446         (dw2_get_file_names_reader): Remove has_children.
5447         (dw2_get_file_names): Update.
5448         (read_cutu_die_from_dwo): Remove has_children.
5449         (cutu_reader::init_tu_and_read_dwo_dies)
5450         (cutu_reader::cutu_reader): Update.
5451         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
5452         Remove has_children.
5453         (build_type_psymtabs_1, process_skeletonless_type_unit)
5454         (load_partial_comp_unit, load_full_comp_unit): Update.
5455         (create_dwo_cu_reader): Remove has_children.
5456         (create_cus_hash_table, read_die_and_children): Update.
5457         (read_full_die_1,read_full_die): Remove has_children.
5458         (read_signatured_type): Update.
5459         (class cutu_reader) <has_children>: Remove.
5460
5461 2020-02-08  Tom Tromey  <tom@tromey.com>
5462
5463         * dwarf2/expr.c: Rename from dwarf2expr.c.
5464         * dwarf2/expr.h: Rename from dwarf2expr.h.
5465         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
5466         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
5467         * dwarf2/frame.c: Rename from dwarf2-frame.c.
5468         * dwarf2/frame.h: Rename from dwarf2-frame.h.
5469         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
5470         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
5471         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
5472         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
5473         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
5474         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
5475         * dwarf2/loc.c: Rename from dwarf2loc.c.
5476         * dwarf2/loc.h: Rename from dwarf2loc.h.
5477         * dwarf2/read.c: Rename from dwarf2read.c.
5478         * dwarf2/read.h: Rename from dwarf2read.h.
5479         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
5480         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
5481         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
5482         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
5483         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
5484         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
5485         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
5486         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
5487         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
5488         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
5489         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
5490         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
5491         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
5492         Update.
5493         * Makefile.in (COMMON_SFILES): Update.
5494         (HFILES_NO_SRCDIR): Update.
5495
5496 2020-02-08  Tom Tromey  <tom@tromey.com>
5497
5498         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
5499         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
5500
5501 2020-02-08  Tom Tromey  <tom@tromey.com>
5502
5503         * dwarf2read.h (struct die_info): Don't declare.
5504
5505 2020-02-08  Tom Tromey  <tom@tromey.com>
5506
5507         * dwarf2read.h (die_info_ptr): Remove typedef.
5508
5509 2020-02-08  Tom Tromey  <tom@tromey.com>
5510
5511         * dwarf2read.c (read_call_site_scope)
5512         (handle_data_member_location, dwarf2_add_member_fn)
5513         (mark_common_block_symbol_computed, read_common_block)
5514         (attr_to_dynamic_prop, partial_die_info::read)
5515         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
5516         (dwarf2_symbol_mark_computed, set_die_type): Update.
5517         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
5518         method.
5519         (attr_form_is_block): Don't declare.
5520         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
5521
5522 2020-02-08  Tom Tromey  <tom@tromey.com>
5523
5524         * dwarf2read.c (dwarf2_find_base_address, )
5525         (read_call_site_scope, rust_containing_type)
5526         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
5527         (handle_data_member_location, dwarf2_add_member_fn)
5528         (get_alignment, read_structure_type, process_structure_scope)
5529         (mark_common_block_symbol_computed, read_common_block)
5530         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
5531         (partial_die_info::read, read_attribute_value, new_symbol)
5532         (lookup_die_type, dwarf2_get_ref_die_offset)
5533         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
5534         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
5535         (dwarf2_symbol_mark_computed): Update.
5536         * dwarf2/attribute.h (struct attribute) <value_as_address,
5537         form_is_section_offset, form_is_constant, form_is_ref>: Declare
5538         methods.
5539         (value_as_address, attr_form_is_section_offset)
5540         (attr_form_is_constant, attr_form_is_ref): Don't declare.
5541         * dwarf2/attribute.c (attribute::value_as_address)
5542         (attribute::form_is_section_offset, attribute::form_is_constant)
5543         (attribute::form_is_ref): Now methods.
5544
5545 2020-02-08  Tom Tromey  <tom@tromey.com>
5546
5547         * dwarf2read.c (struct attribute, DW_STRING)
5548         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
5549         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
5550         (attr_form_is_block, attr_form_is_section_offset)
5551         (attr_form_is_constant, attr_form_is_ref): Move.
5552         * dwarf2/attribute.h: New file.
5553         * dwarf2/attribute.c: New file, from dwarf2read.c.
5554         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
5555
5556 2020-02-08  Tom Tromey  <tom@tromey.com>
5557
5558         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
5559         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
5560         Move.
5561         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
5562         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
5563         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
5564         abbrev.c.
5565         * dwarf2/abbrev.h: New file.
5566         * dwarf2/abbrev.c: New file, from dwarf2read.c.
5567         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
5568
5569 2020-02-08  Tom Tromey  <tom@tromey.com>
5570
5571         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
5572         (dwarf2_section_size, dwarf2_get_section_info)
5573         (create_signatured_type_table_from_debug_names)
5574         (create_addrmap_from_aranges, read_debug_names_from_section)
5575         (get_gdb_index_contents_from_section, read_comp_unit_head)
5576         (error_check_comp_unit_head, read_abbrev_offset)
5577         (create_debug_type_hash_table, init_cu_die_reader)
5578         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
5579         (read_comp_units_from_section, create_cus_hash_table)
5580         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
5581         (create_dwp_v2_section, dwarf2_rnglists_process)
5582         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
5583         (abbrev_table_read_table, read_indirect_string_at_offset_from)
5584         (read_indirect_string_from_dwz, read_addr_index_1)
5585         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
5586         (dwarf_decode_macro_bytes, dwarf_decode_macros)
5587         (fill_in_loclist_baton): Update.
5588         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
5589         get_containing_section, get_bfd_owner, get_bfd_section,
5590         get_file_name, get_id, get_flags, empty, read>: Declare methods.
5591         (dwarf2_read_section, get_section_name, get_section_file_name)
5592         (get_containing_section, get_section_bfd_owner)
5593         (get_section_bfd_section, get_section_name, get_section_file_name)
5594         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
5595         declare.
5596         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
5597         (dwarf2_section_info::get_bfd_owner)
5598         (dwarf2_section_info::get_bfd_section)
5599         (dwarf2_section_info::get_name)
5600         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
5601         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
5602         (dwarf2_section_info::read): Now methods.
5603         * dwarf-index-write.c (class debug_names): Update.
5604
5605 2020-02-08  Tom Tromey  <tom@tromey.com>
5606
5607         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
5608         Move to dwarf2/section.h.
5609         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
5610         (get_section_bfd_section, get_section_name)
5611         (get_section_file_name, get_section_id, get_section_flags)
5612         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
5613         dwarf2/section.c.
5614         * dwarf2/section.h: New file.
5615         * dwarf2/section.c: New file, from dwarf2read.c.
5616         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
5617
5618 2020-02-08  Tom Tromey  <tom@tromey.com>
5619
5620         * dwarf2read.h (read_unsigned_leb128): Don't declare.
5621         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
5622         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
5623         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
5624         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
5625         * dwarf2/leb.h: New file, from dwarf2read.c.
5626         * dwarf2/leb.c: New file, from dwarf2read.c.
5627         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
5628         Remove.
5629         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
5630         (COMMON_SFILES): Add dwarf2/leb.c.
5631
5632 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
5633
5634         GDB 9.1 released.
5635
5636 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5637
5638         PR gdb/25190:
5639         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
5640         * gdb/remote.c (remote_console_output): Update.
5641         * gdb/ui-file.c (fputs_unfiltered): Rename to...
5642         (ui_file_puts): ...this.
5643         * gdb/ui-file.h (ui_file_puts): Add declaration.
5644         * gdb/utils.c (emit_style_escape): Update.
5645         (flush_wrap_buffer): Update.
5646         (fputs_maybe_filtered): Update.
5647         (fputs_unfiltered): Add function.
5648
5649 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5650
5651         * gdb/event-loop.c (gdb_wait_for_event): Update.
5652         * gdb/printcmd.c (printf_command): Update.
5653         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
5654         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
5655         (gdb_os_flush_stderr): Update.
5656         * gdb/remote.c (remote_console_output): Update.
5657         * gdb/ui-file.c (gdb_flush): Rename to...
5658         (ui_file_flush): ...this.
5659         (stderr_file::write): Update.
5660         (stderr_file::puts): Update.
5661         * gdb/ui-file.h (gdb_flush): Rename to...
5662         (ui_file_flush): ...this.
5663         * gdb/utils.c (gdb_flush): Add function.
5664         * gdb/utils.h (gdb_flush): Add declaration.
5665
5666 2020-02-07  Tom Tromey  <tromey@adacore.com>
5667
5668         PR breakpoints/24915:
5669         * source.c (find_and_open_source): Do not check basenames_may_differ.
5670
5671 2020-02-07  Tom Tromey  <tom@tromey.com>
5672
5673         * README: Update gdbserver documentation.
5674         * gdbserver: Move to top level.
5675         * configure.tgt (build_gdbserver): Remove.
5676         * configure.ac: Remove --enable-gdbserver.
5677         * configure: Rebuild.
5678         * Makefile.in (distclean): Don't mention gdbserver.
5679
5680 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5681
5682         * source-cache.c (source_cache::ensure): Surround
5683         get_plain_source_lines with a try/catch.
5684         (source_cache::get_line_charpos): Get rid of try/catch
5685         and only check for the return value of "ensure".
5686         * tui/tui-source.c (tui_source_window::set_contents):
5687         Simplify "nlines" calculation.
5688
5689 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5690
5691         * MAINTAINERS (Write After Approval): Add myself.
5692
5693 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5694
5695         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
5696         function call.
5697
5698 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5699
5700         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
5701
5702 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
5703
5704         * nat/riscv-linux-tdesc.h: New file.
5705         * nat/riscv-linux-tdesc.c: New file, taking code from...
5706         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
5707         ... here.
5708         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
5709         NATDEPFILES.
5710
5711 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
5714         we don't set the fake simulator ptid to the null_ptid.
5715
5716 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
5717
5718         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
5719         * gdbthread.h (class thread_info) <resumed>: Likewise.
5720         * infrun.c (resume_1): Likewise.
5721         (proceed): Likewise.
5722         (infrun_thread_stop_requested): Likewise.
5723         (stop_all_threads): Likewise.
5724         (handle_inferior_event): Likewise.
5725         (restart_threads): Likewise.
5726         (finish_step_over): Likewise.
5727         (keep_going_stepped_thread): Likewise.
5728         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
5729         (linux_handle_extended_wait): Likewise.
5730         * record-btrace.c (get_thread_current_frame_id): Likewise.
5731         * record-full.c (record_full_wait_1): Likewise.
5732         * remote.c (remote_target::process_initial_stop_replies): Likewise.
5733         * target.c (target_resume): Likewise.
5734         * thread.c (set_running_thread): Likewise.
5735
5736 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
5737
5738         * f-valprint.c (f77_print_array_1): Changed datatype of index
5739         variable to LONGEST from int to enable it to contain bound
5740         values correctly.
5741
5742 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
5743
5744         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
5745         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
5746         offsets according to FLEN determined.
5747         (riscv_linux_nat_target::read_description): Determine FLEN
5748         dynamically.
5749         (riscv_linux_nat_target::fetch_registers): Size regset buffer
5750         according to FLEN determined.
5751         (riscv_linux_nat_target::store_registers): Likewise.
5752
5753 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
5754
5755         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
5756         when reg->group is empty and reggroup is not.
5757
5758 2020-01-31  Tom Tromey  <tromey@adacore.com>
5759
5760         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
5761         Call beneath target's mourn_inferior after unpushing.
5762
5763 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         PR tui/9765
5766         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
5767         have enough lines to fill the screen, still return the lowest
5768         address we found.
5769
5770 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5771
5772         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
5773         '-', '<', and '>' commands.
5774
5775 2020-01-29  Pedro Alves  <palves@redhat.com>
5776             Sergio Durigan Junior  <sergiodj@redhat.com>
5777
5778         * infcmd.c (construct_inferior_arguments): Assert that
5779         'argc' is greater than 0.
5780
5781 2020-01-29  Luis Machado  <luis.machado@linaro.org>
5782
5783         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
5784         (BRK_INSN_MASK): Define to 0xd4200000.
5785         (aarch64_program_breakpoint_here_p): New function.
5786         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
5787         * arch-utils.c (default_program_breakpoint_here_p): Moved from
5788         breakpoint.c.
5789         * arch-utils.h (default_program_breakpoint_here_p): Moved from
5790         breakpoint.h
5791         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
5792         call gdbarch_program_breakpoint_here_p.
5793         (program_breakpoint_here): Moved to arch-utils.c, renamed to
5794         default_program_breakpoint_here_p, changed return type to bool and
5795         simplified.
5796         * breakpoint.h (program_breakpoint_here): Moved prototype to
5797         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
5798         return type to bool.
5799         * gdbarch.c: Regenerate.
5800         * gdbarch.h: Regenerate.
5801         * gdbarch.sh (program_breakpoint_here_p): New method.
5802         * infrun.c (handle_signal_stop): Call
5803         gdbarch_program_breakpoint_here_p.
5804
5805 2020-01-26  Tom Tromey  <tom@tromey.com>
5806
5807         * ctfread.c (struct ctf_fp_info): Reindent.
5808         (_initialize_ctfread): Remove.
5809
5810 2020-01-26  Tom Tromey  <tom@tromey.com>
5811
5812         * psymtab.c (partial_map_expand_apply)
5813         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
5814         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
5815         (psym_print_stats, psym_expand_symtabs_for_function)
5816         (psym_map_symbol_filenames, psym_map_matching_symbols)
5817         (psym_expand_symtabs_matching)
5818         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
5819         (maintenance_check_psymtabs): Use new methods.
5820         * psympriv.h (struct partial_symtab) <readin_p,
5821         get_compunit_symtab>: New methods.
5822         <readin, compunit_symtab>: Remove members.
5823         (struct standard_psymtab): New.
5824         (struct legacy_psymtab): Derive from standard_psymtab.
5825         * dwarf2read.h (struct dwarf2_psymtab): Derive from
5826         standard_psymtab.
5827         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
5828
5829 2020-01-26  Tom Tromey  <tom@tromey.com>
5830
5831         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
5832         read_dependencies.  Add assert.
5833         * psymtab.c (partial_symtab::read_dependencies): New method.
5834         * psympriv.h (struct partial_symtab) <read_dependencies>: New
5835         method.
5836         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
5837         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
5838         read_dependencies.
5839         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
5840         Add assert.
5841
5842 2020-01-26  Tom Tromey  <tom@tromey.com>
5843
5844         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
5845         Call expand_psymtab.
5846         (xcoff_read_symtab): Call expand_psymtab.
5847         (xcoff_start_psymtab, xcoff_end_psymtab): Set
5848         legacy_expand_psymtab.
5849         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
5850         method.
5851         (struct legacy_psymtab) <expand_psymtab>: Implement.
5852         <legacy_expand_psymtab>: New member.
5853         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
5854         (parse_partial_symbols): Set legacy_expand_psymtab.
5855         (psymtab_to_symtab_1): Change argument order.  Call
5856         expand_psymtab.
5857         (new_psymtab): Set legacy_expand_psymtab.
5858         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
5859         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
5860         expand_psymtab.
5861         (dwarf2_psymtab::expand_psymtab): Rename from
5862         psymtab_to_symtab_1.  Call expand_psymtab.
5863         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
5864         (dbx_end_psymtab): Likewise.
5865         (dbx_psymtab_to_symtab_1): Change argument order. Call
5866         expand_psymtab.
5867         (dbx_read_symtab): Call expand_psymtab.
5868         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
5869         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
5870         (ctf_psymtab::read_symtab): Call expand_psymtab.
5871
5872 2020-01-26  Tom Tromey  <tom@tromey.com>
5873
5874         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
5875         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
5876         messages.
5877         * mdebugread.c (mdebug_read_symtab): Remove prints.
5878         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
5879         assert.
5880         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
5881
5882 2020-01-26  Tom Tromey  <tom@tromey.com>
5883
5884         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
5885         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
5886         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
5887         legacy_symtab.
5888         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
5889         * psymtab.c (psymtab_to_symtab): Call method.
5890         (dump_psymtab): Update.
5891         * psympriv.h (struct partial_symtab): Add virtual destructor.
5892         <read_symtab>: New method.
5893         (struct legacy_symtab): New.
5894         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
5895         (struct pst_map) <pst>: Now a legacy_psymtab.
5896         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
5897         (new_psymtab): Use legacy_psymtab.
5898         * dwarf2read.h (struct dwarf2_psymtab): New.
5899         (struct dwarf2_per_cu_data) <psymtab>: Use it.
5900         * dwarf2read.c (dwarf2_create_include_psymtab)
5901         (dwarf2_build_include_psymtabs, create_type_unit_group)
5902         (create_partial_symtab, process_psymtab_comp_unit_reader)
5903         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
5904         (set_partial_user): Use dwarf2_psymtab.
5905         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
5906         (psymtab_to_symtab_1, process_full_comp_unit)
5907         (process_full_type_unit, dwarf2_ranges_read)
5908         (dwarf2_get_pc_bounds, psymtab_include_file_name)
5909         (dwarf_decode_lines): Use dwarf2_psymtab.
5910         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
5911         (add_address_entry_worker, write_one_signatured_type)
5912         (recursively_count_psymbols, recursively_write_psymbols)
5913         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
5914         (write_debug_names): Likewise.
5915         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
5916         <pst>: Now a legacy_psymtab.
5917         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
5918         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
5919         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5920         * ctfread.c (struct ctf_psymtab): New.
5921         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5922         ctf_psymtab.
5923         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5924         (create_partial_symtab): Return a ctf_psymtab.
5925         (scan_partial_symbols): Update.
5926
5927 2020-01-26  Tom Tromey  <tom@tromey.com>
5928
5929         * xcoffread.c (xcoff_start_psymtab): Use new.
5930         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5931         renamed from start_psymtab_common.
5932         * psympriv.h (struct partial_symtab): Add new constructor.
5933         (start_psymtab_common): Don't declare.
5934         * mdebugread.c (parse_partial_symbols): Use new.
5935         * dwarf2read.c (create_partial_symtab): Use new.
5936         * dbxread.c (start_psymtab): Use new.
5937         * ctfread.c (create_partial_symtab): Use new.
5938
5939 2020-01-26  Tom Tromey  <tom@tromey.com>
5940
5941         * xcoffread.c (xcoff_end_psymtab): Use new.
5942         * psymtab.c (start_psymtab_common): Use new.
5943         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5944         Update.
5945         * psympriv.h (struct partial_symtab): Add parameters to
5946         constructor.  Don't inline.
5947         (allocate_psymtab): Don't declare.
5948         * mdebugread.c (new_psymtab): Use new.
5949         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5950         * dbxread.c (dbx_end_psymtab): Use new.
5951
5952 2020-01-26  Tom Tromey  <tom@tromey.com>
5953
5954         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5955         allocate_psymtab.  Update documentation.
5956         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5957         allocate_psymtab.  Do not use new.
5958         (allocate_psymtab): Use new.  Update.
5959
5960 2020-01-26  Tom Tromey  <tom@tromey.com>
5961
5962         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5963         * psymtab.c (psym_print_stats): Update.
5964         * psympriv.h (struct partial_symtab) <readin,
5965         psymtabs_addrmap_supported, anonymous>: Now bool.
5966         * mdebugread.c (psymtab_to_symtab_1): Update.
5967         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5968         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5969         (process_full_comp_unit, process_full_type_unit): Update.
5970         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5971         * ctfread.c (psymtab_to_symtab): Update.
5972
5973 2020-01-26  Tom Tromey  <tom@tromey.com>
5974
5975         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5976         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5977         * psymtab.c (psymtab_storage): Delete psymtabs.
5978         (psymtab_storage::allocate_psymtab): Use new.
5979         (psymtab_storage::discard_psymtab): Use delete.
5980         * psympriv.h (struct partial_symtab): Add constructor and
5981         initializers.
5982
5983 2020-01-26  Tom Tromey  <tom@tromey.com>
5984
5985         * machoread.c: Do not include psympriv.h.
5986
5987 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5988
5989         * NEWS: Mention the new option and the set/show commands.
5990
5991 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5992
5993         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5994         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5995         (validate_exec_file): New variables, enums, functions.
5996         (exec_file_locate_attach, print_section_info): Style the filenames.
5997         (_initialize_exec): Install show_exec_file_mismatch_command and
5998          set_exec_file_mismatch_command.
5999         * gdbcore.h (validate_exec_file): Declare.
6000         * infcmd.c (attach_command): Call validate_exec_file.
6001         * remote.c ( remote_target::remote_add_inferior): Likewise.
6002
6003 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6004
6005         * frame.c (find_frame_sal): Move call to get_next_frame into more
6006         inner scope.
6007         * inline-frame.c (inilne_state) <inline_state>: Update argument
6008         types.
6009         (inilne_state) <skipped_symbol>: Rename to...
6010         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
6011         (skip_inline_frames): Build vector of skipped symbols and use this
6012         to reate the inline_state.
6013         (inline_skipped_symbol): Add a comment and some assertions, fetch
6014         skipped symbol from the list.
6015
6016 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * buildsym.c (lte_is_less_than): Delete.
6019         (buildsym_compunit::end_symtab_with_blockvector): Create local
6020         lambda function to sort line table entries, and use
6021         std::stable_sort instead of std::sort.
6022         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
6023         markers when looking for a previous line.
6024
6025 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * dwarf2read.c (lnp_state_machine::record_line): Include
6028         end_sequence parameter in debug print out.  Record the line if we
6029         are at an end_sequence marker even if it's not the start of a
6030         statement.
6031         * symmisc.c (maintenance_print_one_line_table): Print end of
6032         sequence markers with 'END' not '0'.
6033
6034 2020-01-24  Pedro Alves  <palves@redhat.com>
6035
6036         PR gdb/25410
6037         * thread.c (scoped_restore_current_thread::restore): Use
6038         switch_to_inferior_no_thread.
6039         * exec.c: Include "progspace-and-thread.h".
6040         (add_target_sections, remove_target_sections):
6041         scoped_restore_current_pspace_and_thread instead of
6042         scoped_restore_current_thread.
6043         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
6044         and aspace to the inferior before calling clone_program_space.
6045         Remove stale comment.
6046
6047 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
6048
6049         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
6050         (arm_netbsd_nat_target::fetch_registers): ...this.
6051         (arm_nbsd_nat_target::store_registers): Rename to...
6052         (arm_netbsd_nat_target::store_registers): ...this.
6053
6054 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
6055
6056         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6057         register_t.
6058
6059 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
6060
6061         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
6062         Update comment.
6063         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
6064         Likewise.
6065         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
6066         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
6067         the correct replacement (iterate_over_regset_sections).
6068         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
6069         Update comment.
6070
6071 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
6072
6073         PR gdb/23718
6074         * gdb/python/python.c (execute_gdb_command): Call
6075         async_enable_stdin in catch block.
6076
6077 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6078
6079         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
6080         SWITCH_THRU_ALL_UIS.
6081
6082 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
6083
6084         PR tui/9765
6085         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
6086         comment, add extra parameter, and update to store previous symbol
6087         when appropriate.
6088         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
6089         add extra parameter.
6090         * tui/tui-disasm.c (tui_disassemble): Update header comment,
6091         remove unneeded parameter, add try/catch around gdb_print_insn,
6092         rewrite to add items to asm_lines vector.
6093         (tui_find_backward_disassembly_start_address): New function.
6094         (tui_find_disassembly_address): Updated throughout.
6095         (tui_disasm_window::set_contents): Update for changes to
6096         tui_disassemble.
6097         (tui_disasm_window::do_scroll_vertical): No need to adjust the
6098         number of lines to scroll.
6099
6100 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
6101
6102         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
6103         (SECT_OFF_DATA): Likewise.
6104         (SECT_OFF_RODATA): Likewise.
6105         (SECT_OFF_TEXT): Likewise.
6106         (SECT_OFF_BSS): Likewise.
6107         (struct objfile) <text_section_offset, data_section_offset>: New
6108         methods.
6109         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
6110         objfile::text_section_offset.
6111         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
6112         * coffread.c (coff_symtab_read): Likewise.
6113         (enter_linenos): Likewise.
6114         (process_coff_symbol): Likewise.
6115         * ctfread.c (get_objfile_text_range): Likewise.
6116         * dtrace-probe.c (dtrace_probe::get_relocated_address):
6117         Use objfile::data_section_offset.
6118         * dwarf2-frame.c (execute_cfa_program): Use
6119         objfile::text_section_offset.
6120         (dwarf2_frame_find_fde): Likewise.
6121         * dwarf2read.c (create_addrmap_from_index): Likewise.
6122         (create_addrmap_from_aranges): Likewise.
6123         (dw2_find_pc_sect_compunit_symtab): Likewise.
6124         (process_psymtab_comp_unit_reader): Likewise.
6125         (add_partial_symbol): Likewise.
6126         (add_partial_subprogram): Likewise.
6127         (process_full_comp_unit): Likewise.
6128         (read_file_scope): Likewise.
6129         (read_func_scope): Likewise.
6130         (read_lexical_block_scope): Likewise.
6131         (read_call_site_scope): Likewise.
6132         (dwarf2_rnglists_process): Likewise.
6133         (dwarf2_ranges_process): Likewise.
6134         (dwarf2_ranges_read): Likewise.
6135         (dwarf_decode_lines_1): Likewise.
6136         (new_symbol): Likewise.
6137         (dwarf2_fetch_die_loc_sect_off): Likewise.
6138         (dwarf2_per_cu_text_offset): Likewise.
6139         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
6140         * hppa-tdep.c (read_unwind_info): Likewise.
6141         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
6142         * psympriv.h (struct partial_symtab): Likewise.
6143         * psymtab.c (find_pc_sect_psymtab): Likewise.
6144         * solib-svr4.c (enable_break): Likewise.
6145         * stap-probe.c (relocate_address): Use
6146         objfile::data_section_offset.
6147         * xcoffread.c (enter_line_range): Use
6148         objfile::text_section_offset.
6149         (read_xcoff_symtab): Likewise.
6150
6151 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
6152
6153         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
6154         declaration to narrower scopes.
6155
6156 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
6157
6158         * darwin-nat.h (struct darwin_exception_msg, enum
6159         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
6160         Move up.
6161         (class darwin_nat_target) <wait_1, check_new_threads,
6162         decode_exception_message, decode_message, stop_inferior,
6163         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
6164         * darwin-nat.c (darwin_check_new_threads): Rename to...
6165         (darwin_nat_target::check_new_threads): ... this.
6166         (darwin_suspend_inferior_it): Remove.
6167         (darwin_decode_exception_message): Rename to...
6168         (darwin_nat_target::decode_exception_message): ... this.
6169         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
6170         (darwin_decode_message): Rename to...
6171         (darwin_nat_target::decode_message): ... this.
6172         (cancel_breakpoint): Rename to...
6173         (darwin_nat_target::cancel_breakpoint): ... this.
6174         (darwin_wait): Rename to...
6175         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
6176         instead of iterate_over_inferiors.
6177         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
6178         (darwin_stop_inferior): Rename to...
6179         (darwin_nat_target::stop_inferior): ... this.
6180         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
6181         (darwin_init_thread_list): Rename to...
6182         (darwin_nat_target::init_thread_list): ... this.
6183         (darwin_ptrace_him): Rename to...
6184         (darwin_nat_target::ptrace_him): ... this.
6185         (darwin_nat_target::create_inferior): Pass lambda function to
6186         fork_inferior.
6187         (darwin_nat_target::detach): Call stop_inferior instead of
6188         darwin_stop_inferior.
6189         * fork-inferior.h (fork_inferior): Change init_trace_fun
6190         parameter to gdb::function_view.
6191         * fork-inferior.c (fork_inferior): Likewise.
6192
6193 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
6194
6195         * i386-cygwin-tdep.c (core_process_module_section): Update.
6196         * windows-nat.c (struct lm_info_windows): Add text_offset.
6197         (windows_xfer_shared_libraries): Update.
6198         * windows-tdep.c (windows_xfer_shared_library):
6199         Add text_offset_cached argument.
6200         * windows-tdep.h (windows_xfer_shared_library): Update.
6201
6202 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
6203
6204         * gdbarch.sh: Add declaration for _initialize_gdbarch.
6205
6206 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
6207
6208         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
6209         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
6210         replace with range-based for.
6211         (gdbsim_interrupt_inferior): Remove.
6212         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
6213         with a range-based for.  Inline code from
6214         gdbsim_interrupt_inferior.
6215
6216 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
6217
6218         * infrun.c (proceed): Fix indentation.
6219
6220 2020-01-21  Tom Tromey  <tromey@adacore.com>
6221
6222         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
6223         * python/python.c (python_extension_ops): Update.
6224         (gdbpy_colorize): New function.
6225         * python/lib/gdb/__init__.py (colorize): New function.
6226         * extension.h (ext_lang_colorize): Declare.
6227         * extension.c (ext_lang_colorize): New function.
6228         * extension-priv.h (struct extension_language_ops) <colorize>: New
6229         member.
6230         * cli/cli-style.c (_initialize_cli_style): Update help text.
6231
6232 2020-01-21  Luis Machado  <luis.machado@linaro.org>
6233
6234         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
6235         <cond>: Change type to bool.
6236         (aarch64_displaced_step_b_cond): Update cond to use bool type.
6237         (aarch64_displaced_step_cb): Likewise.
6238         (aarch64_displaced_step_tb): Likewise.
6239
6240 2020-01-21  Luis Machado  <luis.machado@linaro.org>
6241
6242         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
6243         output.
6244
6245 2020-01-21  Luis Machado  <luis.machado@linaro.org>
6246
6247         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
6248         <pc_adjust>: Adjust the documentation.
6249         (aarch64_displaced_step_fixup): Check if PC really moved before
6250         adjusting it.
6251
6252 2020-01-19  Tom Tromey  <tom@tromey.com>
6253
6254         * disasm.c (~gdb_disassembler): New destructor.
6255         (gdb_buffered_insn_length): Call disassemble_free_target.
6256         * disasm.h (class gdb_disassembler): Declare destructor.  Use
6257         DISABLE_COPY_AND_ASSIGN.
6258
6259 2020-01-19  Tom Tromey  <tom@tromey.com>
6260
6261         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
6262         (die_reader_func_ftype): Remove.
6263         (cutu_reader): New class.
6264         (dw2_get_file_names_reader): Remove "data" parameter.
6265         (dw2_get_file_names): Use cutu_reader.
6266         (create_debug_type_hash_table): Update.
6267         (read_cutu_die_from_dwo): Update comment.
6268         (lookup_dwo_unit): Add dwo_name parameter.
6269         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
6270         die_reader_func_ftype and data parameters.
6271         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
6272         Remove die_reader_func_ftype and data parameters.
6273         (~cutu_reader): New; from init_cutu_and_read_dies.
6274         (cutu_reader::cutu_reader): Rename from
6275         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
6276         and data parameters.
6277         (init_cutu_and_read_dies_simple): Remove.
6278         (struct process_psymtab_comp_unit_data): Remove.
6279         (process_psymtab_comp_unit_reader): Remove data parameter; add
6280         want_partial_unit and pretend_language parameters.
6281         (process_psymtab_comp_unit): Use cutu_reader.
6282         (build_type_psymtabs_reader): Remove data parameter.
6283         (build_type_psymtabs_1): Use cutu_reader.
6284         (process_skeletonless_type_unit): Likewise.
6285         (load_partial_comp_unit_reader): Remove.
6286         (load_partial_comp_unit): Use cutu_reader.
6287         (load_full_comp_unit_reader): Remove.
6288         (load_full_comp_unit): Use cutu_reader.
6289         (struct create_dwo_cu_data): Remove.
6290         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
6291         dwo_unit parameters.
6292         (create_cus_hash_table): Use cutu_reader.
6293         (struct dwarf2_read_addr_index_data): Remove.
6294         (dwarf2_read_addr_index_reader): Remove.
6295         (dwarf2_read_addr_index): Use cutu_reader.
6296         (read_signatured_type_reader): Remove.
6297         (read_signatured_type): Use cutu_reader.
6298
6299 2020-01-19  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
6302         * tui/tui-wingeneral.h (class tui_suppress_output): New.
6303         (tui_wrefresh): Declare.
6304         * tui/tui-wingeneral.c (suppress_output): New global.
6305         (tui_suppress_output, ~tui_suppress_output): New constructor and
6306         destructor.
6307         (tui_wrefresh): New function.
6308         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
6309         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
6310         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
6311         method.
6312         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
6313         tui_wrefresh.
6314         (tui_data_window::no_refresh): New method.
6315         (tui_data_item_window::refresh_window): Call tui_wrefresh.
6316         (tui_reg_command): Use tui_suppress_output
6317         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
6318         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
6319         method.
6320         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
6321
6322 2020-01-19  Tom Tromey  <tom@tromey.com>
6323
6324         * tui/tui-winsource.c (tui_update_source_windows_with_line):
6325         Handle case where symtab is null.
6326
6327 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
6328
6329         * linux-fork.c (one_fork_p): Simplify.
6330
6331 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
6332
6333         * top.c (struct qt_args): Remove.
6334         (kill_or_detach): Change return type to void, replace `void *`
6335         parameter with a proper one.
6336         (print_inferior_quit_action):  Likewise.
6337         (quit_confirm): Use range-based for loop to iterate over inferiors.
6338         (quit_force): Likewise.
6339
6340 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
6341
6342         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
6343         `void *` parameter with proper parameters.
6344         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
6345         (print_one_inferior): Change return type to void, replace `void *`
6346         parameter with proper parameters.
6347         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
6348         inferiors.
6349         (get_other_inferior): Remove.
6350         (mi_cmd_remove_inferior): Use range-based loop to iterate over
6351         inferiors.
6352
6353 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
6354
6355         * mi/mi-interp.c (report_initial_inferior): Remove.
6356         (mi_interp::init): Use range-based for to iterate over inferiors.
6357
6358 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
6359
6360         * python/py-inferior.c (build_inferior_list): Remove.
6361         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
6362
6363 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
6364
6365         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
6366         (btrace_stitch_trace): Likewise.
6367         * charset.c (intermediate_encoding): Likewise (vaild).
6368         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
6369         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
6370         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
6371
6372 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
6373
6374         * windows-tdep.c (windows_get_tlb_type):
6375         Add rtl_user_process_parameters type.
6376
6377 2020-01-16  Pedro Alves  <palves@redhat.com>
6378             Norbert Lange  <nolange79@gmail.com>
6379
6380         PR build/24805
6381         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
6382         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
6383         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
6384         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
6385         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
6386         (ps_plog): Redeclare exported functions with default visibility.
6387
6388 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
6389
6390         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
6391         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
6392
6393 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
6394
6395         * infcmd.c (post_create_inferior): Use get_thread_regcache
6396         instead of get_current_regcache.
6397
6398 2020-01-14  Tom Tromey  <tom@tromey.com>
6399
6400         PR symtab/12535:
6401         * python/python.c (gdbpy_decode_line): Treat empty string the same
6402         as no argument.
6403
6404 2020-01-14  Tom Tromey  <tom@tromey.com>
6405
6406         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
6407
6408 2020-01-14  Tom Tromey  <tom@tromey.com>
6409
6410         * nat/linux-btrace.c: Don't include <config.h>.
6411         * nat/linux-ptrace.c: Don't include <config.h>.
6412         * nat/x86-linux-dregs.c: Don't include <config.h>.
6413
6414 2020-01-14  Tom Tromey  <tom@tromey.com>
6415
6416         * configure: Rebuild.
6417         * configure.ac: Move many checks to ../gdbsupport/common.m4.
6418
6419 2020-01-14  Tom Tromey  <tom@tromey.com>
6420
6421         * nat/x86-linux-dregs.c: Include configh.h.
6422         * nat/linux-ptrace.c: Include configh.h.
6423         * nat/linux-btrace.c: Include configh.h.
6424         * defs.h: Include config.h, bfd.h.
6425         * configure.ac: Don't source common.host.
6426         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
6427         * configure: Rebuild.
6428         * acinclude.m4: Update path.
6429         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
6430         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
6431         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
6432         (CLIBS): Add LIBSUPPORT.
6433         (CDEPS): Likewise.
6434         (COMMON_SFILES): Remove gdbsupport files.
6435         (HFILES_NO_SRCDIR): Likewise.
6436         (stamp-version): Update path to create-version.sh.
6437         (ALLDEPFILES): Remove gdbsupport files.
6438
6439 2020-01-14  Tom Tromey  <tom@tromey.com>
6440
6441         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
6442         USE_WIN32API when needed.
6443         * configure.ac (USE_WIN32API): Don't define.
6444         (WIN32LIBS): Use WIN32APILIBS.
6445         * configure: Rebuild.
6446
6447 2020-01-14  Tom Tromey  <tom@tromey.com>
6448
6449         * configure: Rebuild.
6450         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
6451
6452 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6453
6454         * skip.c (skip_function_command): Make skip w/o arguments use the
6455         name of the inlined function if pc is inside any inlined function.
6456
6457 2020-01-14  Luis Machado  <luis.machado@linaro.org>
6458
6459         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
6460         * infrun.c (resume_1): Likewise.
6461         (handle_inferior_event): Remove stale comment.
6462         * linux-nat.c (linux_nat_target::resume): Update comments.
6463         (save_stop_reason): Likewise.
6464         (linux_nat_filter_event): Likewise.
6465         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
6466
6467 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * elfread.c (record_minimal_symbol): Set section index to 0 for
6470         non-allocatable sections.
6471
6472
6473 2020-01-13  Ali Tamur <tamur@google.com>
6474
6475         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
6476         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
6477         to gdb::optional.  Update comments.
6478         (dwo_file): Update comments.
6479         (read_attribute): Update API to take an additional out parameter,
6480         need_reprocess.  This is used to mark attributes that need other
6481         attributes (e.g. str_offsets_base) for correct computation which may not
6482         have been read yet.
6483         (read_attribute_reprocess): New function declaration.
6484         (read_addr_index): Likewise.
6485         (read_dwo_str_index): Likewise.
6486         (read_stub_str_index): Likewise.
6487         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
6488         (lookup_addr_base): New function definition.
6489         (lookup_ranges_base): Likewise.
6490         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
6491         lookup_ranges_base.
6492         (init_cutu_and_read_dies): Update comments.
6493         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
6494         unit.  This is used to inherit parent's str_offsets_base and addr_base.
6495         Update comments.
6496         (init_cutu_and_read_dies_simple): Reflect API changes.
6497         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
6498         (create_cus_hash_table): Change API to take parent compile unit.
6499         Reflect API changes.
6500         (open_and_init_dwo_file): Reflect API changes.
6501         (dwarf2_get_pc_bounds): Update comments.
6502         (dwarf2_record_block_ranges): Likewise.
6503         (read_full_die_1): Change implementation to reprocess attributes that
6504         need str_offsets_base and addr_base.
6505         (partial_die_info::read): Likewise.
6506         (read_attribute_reprocess): New function definition.
6507         (read_attribute_value): Change API to take an additional out parameter,
6508         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
6509         when a non-dwo compile unit has index based attributes.
6510         (read_attribute): Reflect API changes.
6511         (read_addr_index_1): Reflect API changes.  Update comments.
6512         (dwarf2_read_addr_index_data): Reflect API changes.
6513         (dwarf2_read_addr_index): Likewise.
6514         (read_str_index): Change API and implementation.  This becomes a helper
6515         to be used by the new string index related methods.  Update error
6516         message and comments.
6517         (read_dwo_str_index): New function definition.
6518         (read_stub_str_index): Likewise.
6519         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
6520         * symfile.h (dwarf2_debug_sections): Likewise.
6521         * xcoffread.c (dwarf2_debug_sections): Likewise.
6522
6523 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6524
6525         * gdbcore.h (struct core_fns) <core_read_registers>: Change
6526         core_reg_sect type to gdb_byte *.
6527         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
6528         * cris-tdep.c (fetch_core_registers): Likewise.
6529         * corelow.c (core_target::get_core_register_section): Change
6530         type of `contents` to gdb::byte_vector.
6531
6532 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6533
6534         * tui/tui-wingeneral.c (box_win): Position the title in the center
6535         of the border.
6536
6537 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6538
6539         * corelow.c (core_target::get_core_register_section): Use
6540           std::vector instead of alloca.
6541
6542 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6543
6544         * warning.m4: Add -Wmissing-declarations to build_warnings.
6545         * configure: Re-generate.
6546
6547 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6548
6549         * python/python.c (init__gdb_module): Add declaration.
6550
6551 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6552
6553         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
6554         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
6555         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
6556         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
6557         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
6558         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
6559         * ada-exp.y (_initialize_ada_exp): Add declaration.
6560         * ada-lang.c (_initialize_ada_language): Add declaration.
6561         * ada-tasks.c (_initialize_tasks): Add declaration.
6562         * agent.c (_initialize_agent): Add declaration.
6563         * aix-thread.c (_initialize_aix_thread): Add declaration.
6564         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
6565         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
6566         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
6567         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
6568         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
6569         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
6570         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
6571         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
6572         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
6573         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
6574         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
6575         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
6576         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
6577         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
6578         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
6579         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
6580         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
6581         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
6582         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
6583         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
6584         * annotate.c (_initialize_annotate): Add declaration.
6585         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
6586         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
6587         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
6588         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
6589         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
6590         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
6591         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
6592         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
6593         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
6594         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
6595         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
6596         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
6597         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
6598         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
6599         * auto-load.c (_initialize_auto_load): Add declaration.
6600         * auxv.c (_initialize_auxv): Add declaration.
6601         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
6602         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
6603         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
6604         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
6605         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
6606         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
6607         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
6608         * breakpoint.c (_initialize_breakpoint): Add declaration.
6609         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
6610         * btrace.c (_initialize_btrace): Add declaration.
6611         * charset.c (_initialize_charset): Add declaration.
6612         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
6613         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
6614         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
6615         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
6616         * cli/cli-script.c (_initialize_cli_script): Add declaration.
6617         * cli/cli-style.c (_initialize_cli_style): Add declaration.
6618         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
6619         * coffread.c (_initialize_coffread): Add declaration.
6620         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
6621         * compile/compile.c (_initialize_compile): Add declaration.
6622         * complaints.c (_initialize_complaints): Add declaration.
6623         * completer.c (_initialize_completer): Add declaration.
6624         * copying.c (_initialize_copying): Add declaration.
6625         * corefile.c (_initialize_core): Add declaration.
6626         * corelow.c (_initialize_corelow): Add declaration.
6627         * cp-abi.c (_initialize_cp_abi): Add declaration.
6628         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
6629         * cp-support.c (_initialize_cp_support): Add declaration.
6630         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
6631         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
6632         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
6633         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
6634         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
6635         * ctfread.c (_initialize_ctfread): Add declaration.
6636         * d-lang.c (_initialize_d_language): Add declaration.
6637         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
6638         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
6639         * dbxread.c (_initialize_dbxread): Add declaration.
6640         * dcache.c (_initialize_dcache): Add declaration.
6641         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
6642         * disasm.c (_initialize_disasm): Add declaration.
6643         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
6644         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
6645         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
6646         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
6647         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
6648         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
6649         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
6650         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
6651         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
6652         * elfread.c (_initialize_elfread): Add declaration.
6653         * exec.c (_initialize_exec): Add declaration.
6654         * extension.c (_initialize_extension): Add declaration.
6655         * f-lang.c (_initialize_f_language): Add declaration.
6656         * f-valprint.c (_initialize_f_valprint): Add declaration.
6657         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
6658         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
6659         * filesystem.c (_initialize_filesystem): Add declaration.
6660         * findcmd.c (_initialize_mem_search): Add declaration.
6661         * findvar.c (_initialize_findvar): Add declaration.
6662         * fork-child.c (_initialize_fork_child): Add declaration.
6663         * frame-base.c (_initialize_frame_base): Add declaration.
6664         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
6665         * frame.c (_initialize_frame): Add declaration.
6666         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
6667         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
6668         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
6669         * gcore.c (_initialize_gcore): Add declaration.
6670         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
6671         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
6672         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
6673         * gdbarch.c (_initialize_gdbarch): Add declaration.
6674         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
6675         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
6676         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
6677         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
6678         * go-lang.c (_initialize_go_language): Add declaration.
6679         * go32-nat.c (_initialize_go32_nat): Add declaration.
6680         * guile/guile.c (_initialize_guile): Add declaration.
6681         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
6682         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
6683         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
6684         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
6685         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
6686         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
6687         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
6688         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
6689         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
6690         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
6691         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
6692         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
6693         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
6694         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
6695         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
6696         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
6697         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
6698         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
6699         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
6700         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
6701         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
6702         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
6703         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
6704         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
6705         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
6706         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
6707         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
6708         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
6709         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
6710         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
6711         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
6712         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
6713         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
6714         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
6715         * infcall.c (_initialize_infcall): Add declaration.
6716         * infcmd.c (_initialize_infcmd): Add declaration.
6717         * inflow.c (_initialize_inflow): Add declaration.
6718         * infrun.c (_initialize_infrun): Add declaration.
6719         * interps.c (_initialize_interpreter): Add declaration.
6720         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
6721         * jit.c (_initialize_jit): Add declaration.
6722         * language.c (_initialize_language): Add declaration.
6723         * linux-fork.c (_initialize_linux_fork): Add declaration.
6724         * linux-nat.c (_initialize_linux_nat): Add declaration.
6725         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
6726         * linux-thread-db.c (_initialize_thread_db): Add declaration.
6727         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
6728         * m2-lang.c (_initialize_m2_language): Add declaration.
6729         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
6730         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
6731         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
6732         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
6733         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
6734         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
6735         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
6736         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
6737         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
6738         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
6739         * machoread.c (_initialize_machoread): Add declaration.
6740         * macrocmd.c (_initialize_macrocmd): Add declaration.
6741         * macroscope.c (_initialize_macroscope): Add declaration.
6742         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
6743         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
6744         * maint.c (_initialize_maint_cmds): Add declaration.
6745         * mdebugread.c (_initialize_mdebugread): Add declaration.
6746         * memattr.c (_initialize_mem): Add declaration.
6747         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
6748         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
6749         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
6750         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
6751         * mi/mi-main.c (_initialize_mi_main): Add declaration.
6752         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
6753         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
6754         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
6755         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
6756         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
6757         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
6758         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
6759         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
6760         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
6761         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
6762         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
6763         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
6764         * mipsread.c (_initialize_mipsread): Add declaration.
6765         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
6766         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
6767         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
6768         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
6769         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
6770         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
6771         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
6772         * nto-procfs.c (_initialize_procfs): Add declaration.
6773         * objc-lang.c (_initialize_objc_language): Add declaration.
6774         * observable.c (_initialize_observer): Add declaration.
6775         * opencl-lang.c (_initialize_opencl_language): Add declaration.
6776         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
6777         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
6778         * osabi.c (_initialize_gdb_osabi): Add declaration.
6779         * osdata.c (_initialize_osdata): Add declaration.
6780         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
6781         * parse.c (_initialize_parse): Add declaration.
6782         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
6783         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
6784         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
6785         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
6786         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
6787         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
6788         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
6789         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
6790         * printcmd.c (_initialize_printcmd): Add declaration.
6791         * probe.c (_initialize_probe): Add declaration.
6792         * proc-api.c (_initialize_proc_api): Add declaration.
6793         * proc-events.c (_initialize_proc_events): Add declaration.
6794         * proc-service.c (_initialize_proc_service): Add declaration.
6795         * procfs.c (_initialize_procfs): Add declaration.
6796         * producer.c (_initialize_producer): Add declaration.
6797         * psymtab.c (_initialize_psymtab): Add declaration.
6798         * python/python.c (_initialize_python): Add declaration.
6799         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
6800         * record-btrace.c (_initialize_record_btrace): Add declaration.
6801         * record-full.c (_initialize_record_full): Add declaration.
6802         * record.c (_initialize_record): Add declaration.
6803         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
6804         * regcache.c (_initialize_regcache): Add declaration.
6805         * reggroups.c (_initialize_reggroup): Add declaration.
6806         * remote-notif.c (_initialize_notif): Add declaration.
6807         * remote-sim.c (_initialize_remote_sim): Add declaration.
6808         * remote.c (_initialize_remote): Add declaration.
6809         * reverse.c (_initialize_reverse): Add declaration.
6810         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
6811         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
6812         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
6813         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
6814         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
6815         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
6816         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
6817         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
6818         Add declaration.
6819         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
6820         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
6821         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
6822         * rust-exp.y (_initialize_rust_exp): Add declaration.
6823         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
6824         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
6825         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
6826         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
6827         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
6828         * score-tdep.c (_initialize_score_tdep): Add declaration.
6829         * ser-go32.c (_initialize_ser_dos): Add declaration.
6830         * ser-mingw.c (_initialize_ser_windows): Add declaration.
6831         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
6832         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
6833         * ser-uds.c (_initialize_ser_socket): Add declaration.
6834         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
6835         * serial.c (_initialize_serial): Add declaration.
6836         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
6837         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
6838         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
6839         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
6840         * skip.c (_initialize_step_skip): Add declaration.
6841         * sol-thread.c (_initialize_sol_thread): Add declaration.
6842         * solib-aix.c (_initialize_solib_aix): Add declaration.
6843         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
6844         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
6845         * solib-frv.c (_initialize_frv_solib): Add declaration.
6846         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
6847         * solib-target.c (_initialize_solib_target): Add declaration.
6848         * solib.c (_initialize_solib): Add declaration.
6849         * source-cache.c (_initialize_source_cache): Add declaration.
6850         * source.c (_initialize_source): Add declaration.
6851         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
6852         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
6853         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
6854         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
6855         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
6856         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
6857         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
6858         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
6859         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
6860         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
6861         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
6862         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
6863         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
6864         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
6865         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
6866         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
6867         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
6868         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
6869         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
6870         * stabsread.c (_initialize_stabsread): Add declaration.
6871         * stack.c (_initialize_stack): Add declaration.
6872         * stap-probe.c (_initialize_stap_probe): Add declaration.
6873         * std-regs.c (_initialize_frame_reg): Add declaration.
6874         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
6875         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
6876         * symfile.c (_initialize_symfile): Add declaration.
6877         * symmisc.c (_initialize_symmisc): Add declaration.
6878         * symtab.c (_initialize_symtab): Add declaration.
6879         * target.c (_initialize_target): Add declaration.
6880         * target-connection.c (_initialize_target_connection): Add
6881         declaration.
6882         * target-dcache.c (_initialize_target_dcache): Add declaration.
6883         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
6884         * thread.c (_initialize_thread): Add declaration.
6885         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
6886         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
6887         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
6888         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
6889         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
6890         * tracectf.c (_initialize_ctf): Add declaration.
6891         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
6892         * tracefile.c (_initialize_tracefile): Add declaration.
6893         * tracepoint.c (_initialize_tracepoint): Add declaration.
6894         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
6895         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
6896         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
6897         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
6898         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
6899         * tui/tui-win.c (_initialize_tui_win): Add declaration.
6900         * tui/tui.c (_initialize_tui): Add declaration.
6901         * typeprint.c (_initialize_typeprint): Add declaration.
6902         * ui-style.c (_initialize_ui_style): Add declaration.
6903         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
6904         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
6905         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
6906         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
6907         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
6908         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
6909         * unittests/filtered_iterator-selftests.c
6910         (_initialize_filtered_iterator_selftests): Add declaration.
6911         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
6912         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
6913         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
6914         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
6915         * unittests/main-thread-selftests.c
6916         (_initialize_main_thread_selftests): Add declaration.
6917         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
6918         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
6919         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6920         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6921         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6922         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6923         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6924         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6925         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6926         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6927         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6928         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6929         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6930         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6931         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6932         declaration.
6933         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6934         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6935         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6936         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6937         * user-regs.c (_initialize_user_regs): Add declaration.
6938         * utils.c (_initialize_utils): Add declaration.
6939         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6940         * valops.c (_initialize_valops): Add declaration.
6941         * valprint.c (_initialize_valprint): Add declaration.
6942         * value.c (_initialize_values): Add declaration.
6943         * varobj.c (_initialize_varobj): Add declaration.
6944         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6945         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6946         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6947         * windows-nat.c (_initialize_windows_nat): Add declaration.
6948         (_initialize_check_for_gdb_ini): Add declaration.
6949         (_initialize_loadable): Add declaration.
6950         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6951         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6952         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6953         * xcoffread.c (_initialize_xcoffread): Add declaration.
6954         * xml-support.c (_initialize_xml_support): Add declaration.
6955         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6956         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6957         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6958         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6959
6960 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6961
6962         * regformats/regdat.sh: Generate declaration for init function.
6963
6964 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6965
6966         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6967         up.
6968         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6969         close_one_inferior>: New methods.
6970         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6971         pass down target to find_inferior_pid.
6972         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6973         Pass down target to find_inferior_ptid.
6974         (gdbsim_target::create_inferior): Pass down target to
6975         add_thread_silent.
6976         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6977         target down to find_inferior_ptid and switch_to_thread.
6978         (gdbsim_target::close): Update to call close_one_inferior.
6979         (struct resume_data): Remove.
6980         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6981         directly, rather than through a void pointer.
6982         (gdbsim_target::resume): Update to call resume_one_inferior.
6983
6984 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6985
6986         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6987
6988 2020-01-12  Pedro Alves  <palves@redhat.com>
6989
6990         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6991         directly for the current inferior instead of
6992         discard_all_inferiors.
6993         (discard_all_inferiors): Delete.
6994
6995 2020-01-11  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6998         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6999         deprecated_safe_get_selected_frame.
7000
7001 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7002
7003         * inferior.c (print_inferior): Switch inferior before printing it.
7004
7005 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
7006             Pedro Alves  <palves@redhat.com>
7007
7008         * progspace-and-thread.c (switch_to_program_space_and_thread):
7009         Assert there's an inferior for PSPACE.  Use
7010         switch_to_inferior_no_thread to switch the inferior too.
7011         * progspace.c (program_space::~program_space): Call
7012         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
7013         (program_space::free_all_objfiles): Don't call clear_symtab_users
7014         here.
7015         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
7016
7017 2020-01-10  Pedro Alves  <palves@redhat.com>
7018
7019         * NEWS: Mention multi-target debugging, "info connections", and
7020         "add-inferior -no-connection".
7021
7022 2020-01-10  Pedro Alves  <palves@redhat.com>
7023
7024         * infrun.c: Include "target-connection.h".
7025         (check_multi_target_resumption): New.
7026         (proceed): Call it.
7027         * target-connection.c (make_target_connection_string): Make
7028         extern.
7029         * target-connection.h (make_target_connection_string): Declare.
7030
7031 2020-01-10  Pedro Alves  <palves@redhat.com>
7032
7033         * Makefile.in (COMMON_SFILES): Add target-connection.c.
7034         * inferior.c (uiout_field_connection): New function.
7035         (print_inferior): Add new "connection-id" column.
7036         (add_inferior_command): Show connection number/string of added
7037         inferior.
7038         * process-stratum-target.h
7039         (process_stratum_target::connection_string): New virtual method.
7040         (process_stratum_target::connection_number): New field.
7041         * remote.c (remote_target::connection_string): New override.
7042         * target-connection.c: New file.
7043         * target-connection.h: New file.
7044         * target.c (decref_target): Remove process_stratum targets from
7045         the connection list.
7046         (target_stack::push): Add process_stratum targets to the
7047         connection list.
7048
7049 2020-01-10  Pedro Alves  <palves@redhat.com>
7050
7051         Revert:
7052         2016-04-12  Pedro Alves  <palves@redhat.com>
7053         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
7054         Remove references to name.
7055         * serial.h (struct serial) <name>: Delete.
7056
7057 2020-01-10  Pedro Alves  <palves@redhat.com>
7058
7059         * gdbarch-selftests.c (register_to_value_test): Remove "target
7060         already pushed" check.
7061
7062 2020-01-10  Pedro Alves  <palves@redhat.com>
7063             John Baldwin  <jhb@FreeBSD.org>
7064
7065         * aarch64-linux-nat.c
7066         (aarch64_linux_nat_target::thread_architecture): Adjust.
7067         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
7068         (task_command_1): Likewise.
7069         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
7070         (aix_thread_target::wait, aix_thread_target::fetch_registers)
7071         (aix_thread_target::store_registers)
7072         (aix_thread_target::thread_alive): Adjust.
7073         * amd64-fbsd-tdep.c: Include "inferior.h".
7074         (amd64fbsd_get_thread_local_address): Pass down target.
7075         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
7076         thread's gdbarch instead of target_gdbarch.
7077         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
7078         get_last_target_status.
7079         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
7080         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
7081         inferiors.
7082         (update_inserted_breakpoint_locations): Skip if inferiors with no
7083         execution.
7084         (update_global_location_list): When handling moribund locations,
7085         find representative inferior for location's pspace, and use thread
7086         count of its process_stratum target.
7087         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
7088         * bsd-uthread.c (bsd_uthread_target::wait): Use
7089         as_process_stratum_target and adjust thread_change_ptid and
7090         add_thread calls.
7091         (bsd_uthread_target::update_thread_list): Use
7092         as_process_stratum_target and adjust find_thread_ptid,
7093         thread_change_ptid and add_thread calls.
7094         * btrace.c (maint_btrace_packet_history_cmd): Adjust
7095         find_thread_ptid call.
7096         * corelow.c (add_to_thread_list): Adjust add_thread call.
7097         (core_target_open): Adjust add_thread_silent and thread_count
7098         calls.
7099         (core_target::pid_to_str): Adjust find_inferior_ptid call.
7100         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
7101         * event-top.c (async_disconnect): Pop targets from all inferiors.
7102         * exec.c (add_target_sections): Push exec target on all inferiors
7103         sharing the program space.
7104         (remove_target_sections): Remove the exec target from all
7105         inferiors sharing the program space.
7106         (exec_on_vfork): New.
7107         * exec.h (exec_on_vfork): Declare.
7108         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
7109         Pass it down.
7110         (fbsd_nat_target::update_thread_list): Adjust.
7111         (fbsd_nat_target::resume): Adjust.
7112         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
7113         down.
7114         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
7115         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
7116         get_thread_arch_regcache call.
7117         * fork-child.c (gdb_startup_inferior): Pass target down to
7118         startup_inferior and set_executing.
7119         * gdbthread.h (struct process_stratum_target): Forward declare.
7120         (add_thread, add_thread_silent, add_thread_with_info)
7121         (in_thread_list): Add process_stratum_target parameter.
7122         (find_thread_ptid(inferior*, ptid_t)): New overload.
7123         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
7124         parameter.
7125         (all_threads()): Delete overload.
7126         (all_threads, all_non_exited_threads): Add process_stratum_target
7127         parameter.
7128         (all_threads_safe): Use brace initialization.
7129         (thread_count): Add process_stratum_target parameter.
7130         (set_resumed, set_running, set_stop_requested, set_executing)
7131         (threads_are_executing, finish_thread_state): Add
7132         process_stratum_target parameter.
7133         (switch_to_thread): Use is_current_thread.
7134         * i386-fbsd-tdep.c: Include "inferior.h".
7135         (i386fbsd_get_thread_local_address): Pass down target.
7136         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
7137         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
7138         have_inferiors check.
7139         * inf-ptrace.c (inf_ptrace_target::create_inferior)
7140         (inf_ptrace_target::attach): Adjust.
7141         * infcall.c (run_inferior_call): Adjust.
7142         * infcmd.c (run_command_1): Pass target to
7143         scoped_finish_thread_state.
7144         (proceed_thread_callback): Skip inferiors with no execution.
7145         (continue_command): Rename 'all_threads' local to avoid hiding
7146         'all_threads' function.  Adjust get_last_target_status call.
7147         (prepare_one_step): Adjust set_running call.
7148         (signal_command): Use user_visible_resume_target.  Compare thread
7149         pointers instead of inferior_ptid.
7150         (info_program_command): Adjust to pass down target.
7151         (attach_command): Mark target's 'thread_executing' flag.
7152         (stop_current_target_threads_ns): New, factored out from ...
7153         (interrupt_target_1): ... this.  Switch inferior before making
7154         target calls.
7155         * inferior-iter.h
7156         (struct all_inferiors_iterator, struct all_inferiors_range)
7157         (struct all_inferiors_safe_range)
7158         (struct all_non_exited_inferiors_range): Filter on
7159         process_stratum_target too.  Remove explicit.
7160         * inferior.c (inferior::inferior): Push dummy target on target
7161         stack.
7162         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
7163         Add process_stratum_target parameter, and pass it down.
7164         (have_live_inferiors): Adjust.
7165         (switch_to_inferior_and_push_target): New.
7166         (add_inferior_command, clone_inferior_command): Handle
7167         "-no-connection" parameter.  Use
7168         switch_to_inferior_and_push_target.
7169         (_initialize_inferior): Mention "-no-connection" option in
7170         the help of "add-inferior" and "clone-inferior" commands.
7171         * inferior.h: Include "process-stratum-target.h".
7172         (interrupt_target_1): Use bool.
7173         (struct inferior) <push_target, unpush_target, target_is_pushed,
7174         find_target_beneath, top_target, process_target, target_at,
7175         m_stack>: New.
7176         (discard_all_inferiors): Delete.
7177         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
7178         (all_inferiors, all_non_exited_inferiors): Add
7179         process_stratum_target parameter.
7180         * infrun.c: Include "gdb_select.h" and <unordered_map>.
7181         (target_last_proc_target): New global.
7182         (follow_fork_inferior): Push target on new inferior.  Pass target
7183         to add_thread_silent.  Call exec_on_vfork.  Handle target's
7184         reference count.
7185         (follow_fork): Adjust get_last_target_status call.  Also consider
7186         target.
7187         (follow_exec): Push target on new inferior.
7188         (struct execution_control_state) <target>: New field.
7189         (user_visible_resume_target): New.
7190         (do_target_resume): Call target_async.
7191         (resume_1): Set target's threads_executing flag.  Consider resume
7192         target.
7193         (commit_resume_all_targets): New.
7194         (proceed): Also consider resume target.  Skip threads of inferiors
7195         with no execution.  Commit resumtion in all targets.
7196         (start_remote): Pass current inferior to wait_for_inferior.
7197         (infrun_thread_stop_requested): Consider target as well.  Pass
7198         thread_info pointer to clear_inline_frame_state instead of ptid.
7199         (infrun_thread_thread_exit): Consider target as well.
7200         (random_pending_event_thread): New inferior parameter.  Use it.
7201         (do_target_wait): Rename to ...
7202         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
7203         down.
7204         (threads_are_resumed_pending_p, do_target_wait): New.
7205         (prepare_for_detach): Adjust calls.
7206         (wait_for_inferior): New inferior parameter.  Handle it.  Use
7207         do_target_wait_1 instead of do_target_wait.
7208         (fetch_inferior_event): Adjust.  Switch to representative
7209         inferior.  Pass target down.
7210         (set_last_target_status): Add process_stratum_target parameter.
7211         Save target in global.
7212         (get_last_target_status): Add process_stratum_target parameter and
7213         handle it.
7214         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
7215         (context_switch): Check inferior_ptid == null_ptid before calling
7216         inferior_thread().
7217         (get_inferior_stop_soon): Pass down target.
7218         (wait_one): Rename to ...
7219         (poll_one_curr_target): ... this.
7220         (struct wait_one_event): New.
7221         (wait_one): New.
7222         (stop_all_threads): Adjust.
7223         (handle_no_resumed, handle_inferior_event): Adjust to consider the
7224         event's target.
7225         (switch_back_to_stepped_thread): Also consider target.
7226         (print_stop_event): Update.
7227         (normal_stop): Update.  Also consider the resume target.
7228         * infrun.h (wait_for_inferior): Remove declaration.
7229         (user_visible_resume_target): New declaration.
7230         (get_last_target_status, set_last_target_status): New
7231         process_stratum_target parameter.
7232         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
7233         process_stratum_target parameter, and use it.
7234         (clear_inline_frame_state (thread_info*)): New.
7235         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
7236         process_stratum_target parameter.
7237         (clear_inline_frame_state (thread_info*)): Declare.
7238         * linux-fork.c (delete_checkpoint_command): Pass target down to
7239         find_thread_ptid.
7240         (checkpoint_command): Adjust.
7241         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
7242         instead of just tweaking inferior_ptid.
7243         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
7244         (exit_lwp): Pass target down to find_thread_ptid.
7245         (attach_proc_task_lwp_callback): Pass target down to
7246         add_thread/set_running/set_executing.
7247         (linux_nat_target::attach): Pass target down to
7248         thread_change_ptid.
7249         (get_detach_signal): Pass target down to find_thread_ptid.
7250         Consider last target status's target.
7251         (linux_resume_one_lwp_throw, resume_lwp)
7252         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
7253         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
7254         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
7255         (linux_nat_target::async_wait_fd): New.
7256         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
7257         target down.
7258         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
7259         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
7260         * linux-thread-db.c (struct thread_db_info::process_target): New
7261         field.
7262         (add_thread_db_info): Save target.
7263         (get_thread_db_info): New process_stratum_target parameter.  Also
7264         match target.
7265         (delete_thread_db_info): New process_stratum_target parameter.
7266         Also match target.
7267         (thread_from_lwp): Adjust to pass down target.
7268         (thread_db_notice_clone): Pass down target.
7269         (check_thread_db_callback): Pass down target.
7270         (try_thread_db_load_1): Always push the thread_db target.
7271         (try_thread_db_load, record_thread): Pass target down.
7272         (thread_db_target::detach): Pass target down.  Always unpush the
7273         thread_db target.
7274         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
7275         target down.  Always unpush the thread_db target.
7276         (find_new_threads_callback, thread_db_find_new_threads_2)
7277         (thread_db_target::update_thread_list): Pass target down.
7278         (thread_db_target::pid_to_str): Pass current inferior down.
7279         (thread_db_target::get_thread_local_address): Pass target down.
7280         (thread_db_target::resume, maintenance_check_libthread_db): Pass
7281         target down.
7282         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
7283         * procfs.c (procfs_target::procfs_init_inferior): Declare.
7284         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
7285         (procfs_init_inferior): Rename to ...
7286         (procfs_target::procfs_init_inferior): ... this and adjust.
7287         (procfs_target::create_inferior, procfs_notice_thread)
7288         (procfs_do_thread_registers): Adjust.
7289         * ppc-fbsd-tdep.c: Include "inferior.h".
7290         (ppcfbsd_get_thread_local_address): Pass down target.
7291         * proc-service.c (ps_xfer_memory): Switch current inferior and
7292         program space as well.
7293         (get_ps_regcache): Pass target down.
7294         * process-stratum-target.c
7295         (process_stratum_target::thread_address_space)
7296         (process_stratum_target::thread_architecture): Pass target down.
7297         * process-stratum-target.h
7298         (process_stratum_target::threads_executing): New field.
7299         (as_process_stratum_target): New.
7300         * ravenscar-thread.c
7301         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
7302         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
7303         down.
7304         * record-btrace.c (record_btrace_target::info_record): Adjust.
7305         (record_btrace_target::record_method)
7306         (record_btrace_target::record_is_replaying)
7307         (record_btrace_target::fetch_registers)
7308         (get_thread_current_frame_id, record_btrace_target::resume)
7309         (record_btrace_target::wait, record_btrace_target::stop): Pass
7310         target down.
7311         * record-full.c (record_full_wait_1): Switch to event thread.
7312         Pass target down.
7313         * regcache.c (regcache::regcache)
7314         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
7315         process_stratum_target parameter and handle it.
7316         (current_thread_target): New global.
7317         (get_thread_regcache): Add process_stratum_target parameter and
7318         handle it.  Switch inferior before calling target method.
7319         (get_thread_regcache): Pass target down.
7320         (get_thread_regcache_for_ptid): Pass target down.
7321         (registers_changed_ptid): Add process_stratum_target parameter and
7322         handle it.
7323         (registers_changed_thread, registers_changed): Pass target down.
7324         (test_get_thread_arch_aspace_regcache): New.
7325         (current_regcache_test): Define a couple local test_target_ops
7326         instances and use them for testing.
7327         (readwrite_regcache): Pass process_stratum_target parameter.
7328         (cooked_read_test, cooked_write_test): Pass mock_target down.
7329         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
7330         (get_thread_arch_aspace_regcache): Add process_stratum_target
7331         parameter.
7332         (regcache::target): New method.
7333         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
7334         (regcache::registers_changed_ptid): Add process_stratum_target
7335         parameter.
7336         (regcache::m_target): New field.
7337         (registers_changed_ptid): Add process_stratum_target parameter.
7338         * remote.c (remote_state::supports_vCont_probed): New field.
7339         (remote_target::async_wait_fd): New method.
7340         (remote_unpush_and_throw): Add remote_target parameter.
7341         (get_current_remote_target): Adjust.
7342         (remote_target::remote_add_inferior): Push target.
7343         (remote_target::remote_add_thread)
7344         (remote_target::remote_notice_new_inferior)
7345         (get_remote_thread_info): Pass target down.
7346         (remote_target::update_thread_list): Skip threads of inferiors
7347         bound to other targets.  (remote_target::close): Don't discard
7348         inferiors.  (remote_target::add_current_inferior_and_thread)
7349         (remote_target::process_initial_stop_replies)
7350         (remote_target::start_remote)
7351         (remote_target::remote_serial_quit_handler): Pass down target.
7352         (remote_target::remote_unpush_target): New remote_target
7353         parameter.  Unpush the target from all inferiors.
7354         (remote_target::remote_unpush_and_throw): New remote_target
7355         parameter.  Pass it down.
7356         (remote_target::open_1): Check whether the current inferior has
7357         execution instead of checking whether any inferior is live.  Pass
7358         target down.
7359         (remote_target::remote_detach_1): Pass down target.  Use
7360         remote_unpush_target.
7361         (extended_remote_target::attach): Pass down target.
7362         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
7363         (remote_target::append_resumption): Pass down target.
7364         (remote_target::append_pending_thread_resumptions)
7365         (remote_target::remote_resume_with_hc, remote_target::resume)
7366         (remote_target::commit_resume): Pass down target.
7367         (remote_target::remote_stop_ns): Check supports_vCont_probed.
7368         (remote_target::interrupt_query)
7369         (remote_target::remove_new_fork_children)
7370         (remote_target::check_pending_events_prevent_wildcard_vcont)
7371         (remote_target::remote_parse_stop_reply)
7372         (remote_target::process_stop_reply): Pass down target.
7373         (first_remote_resumed_thread): New remote_target parameter.  Pass
7374         it down.
7375         (remote_target::wait_as): Pass down target.
7376         (unpush_and_perror): New remote_target parameter.  Pass it down.
7377         (remote_target::readchar, remote_target::remote_serial_write)
7378         (remote_target::getpkt_or_notif_sane_1)
7379         (remote_target::kill_new_fork_children, remote_target::kill): Pass
7380         down target.
7381         (remote_target::mourn_inferior): Pass down target.  Use
7382         remote_unpush_target.
7383         (remote_target::core_of_thread)
7384         (remote_target::remote_btrace_maybe_reopen): Pass down target.
7385         (remote_target::pid_to_exec_file)
7386         (remote_target::thread_handle_to_thread_info): Pass down target.
7387         (remote_target::async_wait_fd): New.
7388         * riscv-fbsd-tdep.c: Include "inferior.h".
7389         (riscv_fbsd_get_thread_local_address): Pass down target.
7390         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
7391         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
7392         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
7393         Adjust.
7394         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
7395         * solib-svr4.c (enable_break): Pass down target.
7396         * spu-multiarch.c (parse_spufs_run): Pass down target.
7397         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
7398         * target-delegates.c: Regenerate.
7399         * target.c (g_target_stack): Delete.
7400         (current_top_target): Return the current inferior's top target.
7401         (target_has_execution_1): Refer to the passed-in inferior's top
7402         target.
7403         (target_supports_terminal_ours): Check whether the initial
7404         inferior was already created.
7405         (decref_target): New.
7406         (target_stack::push): Incref/decref the target.
7407         (push_target, push_target, unpush_target): Adjust.
7408         (target_stack::unpush): Defref target.
7409         (target_is_pushed): Return bool.  Adjust to refer to the current
7410         inferior's target stack.
7411         (dispose_inferior): Delete, and inline parts ...
7412         (target_preopen): ... here.  Only dispose of the current inferior.
7413         (target_detach): Hold strong target reference while detaching.
7414         Pass target down.
7415         (target_thread_name): Add assertion.
7416         (target_resume): Pass down target.
7417         (target_ops::beneath, find_target_at): Adjust to refer to the
7418         current inferior's target stack.
7419         (get_dummy_target): New.
7420         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
7421         has a thread running.
7422         (initialize_targets): Rename to ...
7423         (_initialize_target): ... this.
7424         * target.h: Include "gdbsupport/refcounted-object.h".
7425         (struct target_ops): Inherit refcounted_object.
7426         (target_ops::shortname, target_ops::longname): Make const.
7427         (target_ops::async_wait_fd): New method.
7428         (decref_target): Declare.
7429         (struct target_ops_ref_policy): New.
7430         (target_ops_ref): New typedef.
7431         (get_dummy_target): Declare function.
7432         (target_is_pushed): Return bool.
7433         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
7434         (all_matching_threads_iterator::all_matching_threads_iterator):
7435         Handle filter target.
7436         * thread-iter.h (struct all_matching_threads_iterator, struct
7437         all_matching_threads_range, class all_non_exited_threads_range):
7438         Filter by target too.  Remove explicit.
7439         * thread.c (threads_executing): Delete.
7440         (inferior_thread): Pass down current inferior.
7441         (clear_thread_inferior_resources): Pass down thread pointer
7442         instead of ptid_t.
7443         (add_thread_silent, add_thread_with_info, add_thread): Add
7444         process_stratum_target parameter.  Use it for thread and inferior
7445         searches.
7446         (is_current_thread): New.
7447         (thread_info::deletable): Use it.
7448         (find_thread_ptid, thread_count, in_thread_list)
7449         (thread_change_ptid, set_resumed, set_running): New
7450         process_stratum_target parameter.  Pass it down.
7451         (set_executing): New process_stratum_target parameter.  Pass it
7452         down.  Adjust reference to 'threads_executing'.
7453         (threads_are_executing): New process_stratum_target parameter.
7454         Adjust reference to 'threads_executing'.
7455         (set_stop_requested, finish_thread_state): New
7456         process_stratum_target parameter.  Pass it down.
7457         (switch_to_thread): Also match inferior.
7458         (switch_to_thread): New process_stratum_target parameter.  Pass it
7459         down.
7460         (update_threads_executing): Reimplement.
7461         * top.c (quit_force): Pop targets from all inferior.
7462         (gdb_init): Don't call initialize_targets.
7463         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
7464         Declare.
7465         (windows_add_thread, windows_delete_thread): Adjust.
7466         (get_windows_debug_event): Rename to ...
7467         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
7468         * tracefile-tfile.c (tfile_target_open): Pass down target.
7469         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
7470         Forward declare.
7471         (switch_to_thread): Add process_stratum_target parameter.
7472         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
7473         parameter.  Use it.
7474         (mi_on_resume): Pass target down.
7475         * nat/fork-inferior.c (startup_inferior): Add
7476         process_stratum_target parameter.  Pass it down.
7477         * nat/fork-inferior.h (startup_inferior): Add
7478         process_stratum_target parameter.
7479         * python/py-threadevent.c (py_get_event_thread): Pass target down.
7480
7481 2020-01-10  Pedro Alves  <palves@redhat.com>
7482
7483         * remote.c (remote_target::start_remote): Don't set inferior_ptid
7484         directly.  Instead find the first thread in the thread list and
7485         use switch_to_thread.
7486
7487 2020-01-10  Pedro Alves  <palves@redhat.com>
7488
7489         * remote.c (remote_target::remote_add_inferior): Don't bind a
7490         process to the current inferior if the current inferior is already
7491         bound to a process.
7492
7493 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7494             Pedro Alves  <palves@redhat.com>
7495
7496         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
7497         If no process is specified, return null_ptid instead of
7498         inferior_ptid.
7499         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
7500         TARGET_WAITKIND_SIGNALLED with no pid.
7501
7502 2020-01-10  Pedro Alves  <palves@redhat.com>
7503
7504         * remote.c (first_remote_resumed_thread): New.
7505         (remote_target::wait_as): Use it as default event_ptid instead of
7506         inferior_ptid.
7507
7508 2020-01-10  Pedro Alves  <palves@redhat.com>
7509
7510         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
7511
7512 2020-01-10  Pedro Alves  <palves@redhat.com>
7513
7514         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
7515         not -1.
7516
7517 2020-01-10  Pedro Alves  <palves@redhat.com>
7518
7519         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
7520         ptid to get_last_target_status.
7521         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
7522         ptid to get_last_target_status.
7523         * infcmd.c (continue_command): Don't pass a target_waitstatus to
7524         get_last_target_status.
7525         (info_program_command): Don't pass a target_waitstatus to
7526         get_last_target_status.
7527         * infrun.c (init_wait_for_inferior): Use
7528         nullify_last_target_wait_ptid.
7529         (get_last_target_status): Handle nullptr arguments.
7530         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
7531         (print_stop_event): Don't pass a ptid to get_last_target_status.
7532         (normal_stop): Don't pass a ptid to get_last_target_status.
7533         * infrun.h (get_last_target_status, set_last_target_status): Move
7534         comments here and update.
7535         (nullify_last_target_wait_ptid): Declare.
7536         * linux-fork.c (fork_load_infrun_state): Remove local extern
7537         declaration of nullify_last_target_wait_ptid.
7538         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
7539         to get_last_target_status.
7540
7541 2020-01-10  Pedro Alves  <palves@redhat.com>
7542
7543         * gdbthread.h (scoped_restore_current_thread)
7544         <dont_restore, restore, m_dont_restore>: Declare.
7545         * thread.c (thread_alive): Add assertion.  Return bool.
7546         (switch_to_thread_if_alive): New.
7547         (prune_threads): Switch inferior/thread.
7548         (print_thread_info_1): Switch thread before calling target methods.
7549         (scoped_restore_current_thread::restore): New, factored out from
7550         ...
7551         (scoped_restore_current_thread::~scoped_restore_current_thread):
7552         ... this.
7553         (scoped_restore_current_thread::scoped_restore_current_thread):
7554         Add assertion.
7555         (thread_apply_all_command, thread_select): Use
7556         switch_to_thread_if_alive.
7557         * infrun.c (proceed, restart_threads, handle_signal_stop)
7558         (switch_back_to_stepped_thread): Switch current thread before
7559         calling target methods.
7560
7561 2020-01-10  Pedro Alves <palves@redhat.com>
7562
7563         * inferior.c (switch_to_inferior_no_thread): New function,
7564         factored out from ...
7565         (inferior_command): ... here.
7566         * inferior.h (switch_to_inferior_no_thread): Declare.
7567         * mi/mi-main.c (run_one_inferior): Use
7568         switch_to_inferior_no_thread.
7569
7570 2020-01-10  Pedro Alves  <palves@redhat.com>
7571
7572         * infcmd.c (kill_command): Remove dead code.
7573
7574 2020-01-10  Pedro Alves  <palves@redhat.com>
7575
7576         * remote.c (remote_target::mourn_inferior): No longer check
7577         whether the target is running.
7578
7579 2020-01-10  Pedro Alves  <palves@redhat.com>
7580
7581         * corelow.c (core_target::has_execution): Change parameter type to
7582         inferior pointer.
7583         * inferior.c (number_of_live_inferiors): Use
7584         inferior::has_execution instead of target_has_execution_1.
7585         * inferior.h (inferior::has_execution): New.
7586         * linux-thread-db.c (thread_db_target::update_thread_list): Use
7587         inferior::has_execution instead of target_has_execution_1.
7588         * process-stratum-target.c
7589         (process_stratum_target::has_execution): Change parameter type to
7590         inferior pointer.  Check the inferior's PID instead of
7591         inferior_ptid.
7592         * process-stratum-target.h
7593         (process_stratum_target::has_execution): Change parameter type to
7594         inferior pointer.
7595         * record-full.c (record_full_core_target::has_execution): Change
7596         parameter type to inferior pointer.
7597         * target.c (target_has_execution_1): Change parameter type to
7598         inferior pointer.
7599         (target_has_execution_current): Adjust.
7600         * target.h (target_ops::has_execution): Change parameter type to
7601         inferior pointer.
7602         (target_has_execution_1): Change parameter type to inferior
7603         pointer.  Change return type to bool.
7604         * tracefile.h (tracefile_target::has_execution): Change parameter
7605         type to inferior pointer.
7606
7607 2020-01-10  Pedro Alves  <palves@redhat.com>
7608
7609         * exceptions.c (print_flush): Remove current_top_target() check.
7610
7611 2020-01-10  Pedro Alves  <palves@redhat.com>
7612
7613         * remote.c (show_remote_exec_file): Show the current inferior's
7614         exec-file instead of the command variable's value.
7615
7616 2020-01-10  Pedro Alves  <palves@redhat.com>
7617
7618         * record-full.c (record_full_resume_ptid): New global.
7619         (record_full_target::resume): Set it.
7620         (record_full_wait_1): Use record_full_resume_ptid instead of
7621         inferior_ptid.
7622
7623 2020-01-10  Pedro Alves  <palves@redhat.com>
7624
7625         * gdbthread.h (scoped_restore_current_thread)
7626         <dont_restore, restore, m_dont_restore>: Declare.
7627         * thread.c (thread_alive): Add assertion.  Return bool.
7628         (switch_to_thread_if_alive): New.
7629         (prune_threads): Switch inferior/thread.
7630         (print_thread_info_1): Switch thread before calling target methods.
7631         (scoped_restore_current_thread::restore): New, factored out from
7632         ...
7633         (scoped_restore_current_thread::~scoped_restore_current_thread):
7634         ... this.
7635         (scoped_restore_current_thread::scoped_restore_current_thread):
7636         Add assertion.
7637         (thread_apply_all_command, thread_select): Use
7638         switch_to_thread_if_alive.
7639
7640 2020-01-10  George Barrett  <bob@bob131.so>
7641
7642         * stap-probe.c (stap_modify_semaphore): Don't check for null
7643         semaphores.
7644         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
7645         for null semaphores.
7646
7647 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
7650         all source windows, and maintain horizontal scroll status while
7651         doing so.
7652
7653 2020-01-09  Tom Tromey  <tom@tromey.com>
7654
7655         PR tui/18932:
7656         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
7657         update_source_window, not print_source_lines.
7658
7659 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7660
7661         * tui/tui.c (tui_enable): Register tui hooks after calling
7662         tui_display_main.
7663
7664 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7665
7666         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
7667
7668 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
7669
7670         * thread.c (print_thread_info_1): Fix indentation.
7671
7672 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7673
7674         * symtab.c (general_symbol_info::compute_and_set_names): Move the
7675         unique_xmalloc_ptr outside the if to always free the demangled name.
7676
7677 2020-01-08  Tom Tromey  <tromey@adacore.com>
7678
7679         * xcoffread.c (enter_line_range, read_xcoff_symtab)
7680         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
7681         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
7682         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
7683         Remove.
7684         (section_offsets): New typedef.
7685         * symtab.c (fixup_section, get_msymbol_address): Update.
7686         * symmisc.c (dump_msymbols): Update.
7687         * symfile.h (relative_addr_info_to_section_offsets)
7688         (symfile_map_offsets_to_segments): Update.
7689         * symfile.c (build_section_addr_info_from_objfile)
7690         (init_objfile_sect_indices): Update.
7691         (struct place_section_arg): Change type of "offsets".
7692         (place_section): Update.
7693         (relative_addr_info_to_section_offsets): Change type of
7694         "section_offsets".  Remove "num_sections" parameter.
7695         (default_symfile_offsets, syms_from_objfile_1)
7696         (set_objfile_default_section_offset): Update.
7697         (reread_symbols): No need to preserve section offsets by hand.
7698         (symfile_map_offsets_to_segments): Change type of "offsets".
7699         * stap-probe.c (relocate_address): Update.
7700         * stabsread.h (process_one_symbol): Update.
7701         * solib-target.c (struct lm_info_target) <offsets>: Change type.
7702         (solib_target_relocate_section_addresses): Update.
7703         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
7704         Update.
7705         * solib-frv.c (frv_relocate_main_executable): Update.
7706         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
7707         * solib-aix.c (solib_aix_get_section_offsets): Change return
7708         type.
7709         (solib_aix_solib_create_inferior_hook): Update.
7710         * remote.c (remote_target::get_offsets): Update.
7711         * psymtab.c (find_pc_sect_psymtab): Update.
7712         * psympriv.h (struct partial_symbol) <address, text_low,
7713         text_high>: Update.
7714         * objfiles.h (obj_section_offset): Update.
7715         (struct objfile) <section_offsets>: Change type.
7716         <num_sections>: Remove.
7717         (objfile_relocate): Update.
7718         * objfiles.c (entry_point_address_query): Update
7719         (relocate_one_symbol): Change type of "section_offsets".
7720         (objfile_relocate1, objfile_relocate1): Change type of
7721         "new_offsets".
7722         (objfile_rebase1): Update.
7723         * mipsread.c (mipscoff_symfile_read): Update.
7724         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
7725         parameter.
7726         * mdebugread.c (parse_symbol): Change type of "section_offsets".
7727         (parse_external, psymtab_to_symtab_1): Update.
7728         * machoread.c (macho_symfile_offsets): Update.
7729         * ia64-tdep.c (ia64_find_unwind_table): Update.
7730         * hppa-tdep.c (read_unwind_info): Update.
7731         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
7732         * dwarf2read.c (create_addrmap_from_index)
7733         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7734         (process_psymtab_comp_unit_reader, add_partial_symbol)
7735         (add_partial_subprogram, process_full_comp_unit)
7736         (read_file_scope, read_func_scope, read_lexical_block_scope)
7737         (read_call_site_scope, dwarf2_rnglists_process)
7738         (dwarf2_ranges_process, dwarf2_ranges_read)
7739         (dwarf_decode_lines_1, var_decode_location, new_symbol)
7740         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
7741         Update.
7742         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
7743         Update.
7744         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
7745         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
7746         (process_one_symbol): Change type of "section_offsets".
7747         * ctfread.c (get_objfile_text_range): Update.
7748         * coffread.c (coff_symtab_read, enter_linenos)
7749         (process_coff_symbol): Update.
7750         * coff-pe-read.c (add_pe_forwarded_sym): Update.
7751         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
7752
7753 2020-01-08  Tom Tromey  <tromey@adacore.com>
7754
7755         * dwarf2read.c (parse_macro_definition): Use std::string.
7756         (parse_macro_definition): Likewise.
7757
7758 2020-01-08  Tom Tromey  <tromey@adacore.com>
7759
7760         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
7761         (ATTR_ALLOC_CHUNK): Remove.
7762
7763 2020-01-08  Tom Tromey  <tromey@adacore.com>
7764
7765         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
7766
7767 2020-01-08  Tom Tromey  <tromey@adacore.com>
7768
7769         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
7770         (dwarf2_compute_name, open_dwo_file): Likewise.
7771         (process_enumeration_scope): Use std::vector.
7772         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
7773         (partial_die_info::fixup, dwarf2_start_subfile)
7774         (guess_full_die_structure_name, dwarf2_name): Likewise.
7775         (determine_prefix): Update.
7776         (guess_full_die_structure_name): Make return type const.
7777         (partial_die_full_name): Return unique_xmalloc_ptr.
7778         (DW_FIELD_ALLOC_CHUNK): Remove.
7779
7780 2020-01-07  Tom Tromey  <tromey@adacore.com>
7781
7782         PR build/24937:
7783         * stap-probe.c (class stap_static_probe_ops): Add constructor.
7784
7785 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7786
7787         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
7788
7789 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * stack.c (print_frame_info): Move disassemble_next_line code
7792         inside source_print block.
7793
7794 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7795
7796         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
7797         gdb/signals.h, as we are now using native signal symbols.
7798
7799 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7800
7801         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
7802         overflow by an early check of content vs threshold.
7803         * tui/tui-source.c (tui_source_window::line_is_displayed):
7804         Likewise.
7805
7806 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7807
7808         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
7809
7810 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7811
7812         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
7813         export table if no section contains it's RVA.
7814
7815 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7816
7817         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
7818
7819 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
7820
7821         * source.c (print_source_lines_base): Set last_line_listed.
7822
7823 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7824
7825         * tui/tui-disasm.c: Remove trailing spaces.
7826
7827 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7828             Pedro Alves  <palves@redhat.com>
7829
7830         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
7831         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
7832         (windows_gdb_signal_to_target): New function, uses the above
7833         enumeration to convert GDB internal signal codes to equivalent
7834         Windows codes.
7835         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
7836         * windows-nat.c: Include "gdb_wait.h".
7837         (get_windows_debug_event): Extract the fatal exception from the
7838         exit status and convert to the equivalent Posix signal number.
7839         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
7840         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
7841         * gdbsupport/gdb_wait.c: New file, implements
7842         windows_status_to_termsig.
7843         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
7844         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
7845
7846 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
7849         show_layout.
7850
7851 2020-01-05  Luis Machado  <luis.machado@linaro.org>
7852
7853         * aarch64-linux-nat.c
7854         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
7855         and bfd_mach_aarch64.
7856
7857 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7858
7859         * ui-file.c (stdio_file::can_emit_style_escape)
7860         (tee_file::can_emit_style_escape): Ensure style is used also on
7861         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
7862         to gdb_stdout.
7863         * main.c (set_gdb_data_directory): Use file style to output the
7864         warning that the given pathname is not a directory.
7865         * top.c (show_history_filename, gdb_safe_append_history)
7866         (show_gdb_datadir): Use file style.
7867
7868 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7869
7870         * solib-target.c (struct lm_info_target):
7871         Change offsets to be a unique_xmalloc_ptr.
7872         (solib_target_relocate_section_addresses): Update.
7873
7874 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7875
7876         * windows-nat.c (windows_clear_solib): Free so_list linked list.
7877
7878 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7879
7880         * MAINTAINERS (Write After Approval): Add myself.
7881
7882 2020-01-02  Luis Machado  <luis.machado@linaro.org>
7883
7884         * proc-service.c (get_ps_regcache): Remove reference to obsolete
7885         Cell BE architecture.
7886         * target.h (struct target_ops) <thread_architecture>: Likewise.
7887
7888 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7889
7890         * Makefile.in: Use INSTALL_PROGRAM_ENV.
7891
7892 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7893
7894         * MAINTAINERS (Write After Approval): Add myself.
7895
7896 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7897
7898         * gdbarch.sh: Update copyright year range of generated files.
7899
7900 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7901
7902         Update copyright year range in all GDB files.
7903
7904 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7905
7906         * copyright.py: Convert to Python 3.
7907
7908 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7909
7910         * copyright.py: Adapt after move of gnulib directory from gdb
7911         directory to toplevel directory.
7912
7913 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7914
7915         * copyright.py (main): Exit if run from the wrong directory.
7916
7917 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7918
7919         * top.c (print_gdb_version): Change copyright year to 2020.
7920
7921 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7922
7923         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7924
7925 For older changes see ChangeLog-2019.
7926 \f
7927 Local Variables:
7928 mode: change-log
7929 left-margin: 8
7930 fill-column: 74
7931 version-control: never
7932 coding: utf-8
7933 End: