gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c
   4         (tui_source_window_base::set_is_exec_point_at): Add check against
   5         LOA_ADDRESS.
   6
   7 2019-06-25  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-source.c (tui_set_source_content): Don't check before
  10         xfree.
  11         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.h (tui_update_source_window_as_is)
  16         (tui_alloc_source_buffer, tui_line_is_displayed)
  17         (tui_addr_is_displayed): Change type of win_info.
  18         * tui/tui-winsource.c (tui_update_source_window_as_is)
  19         (tui_clear_source_content, tui_show_source_line)
  20         (tui_show_source_content, tui_source_window_base::refill)
  21         (tui_source_window_base::set_is_exec_point_at)
  22         (tui_source_window_base::set_is_exec_point_at)
  23         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  24         (tui_alloc_source_buffer, tui_line_is_displayed)
  25         (tui_addr_is_displayed): Change type of win_info.  Update.
  26         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  27         (tui_source_window_base::do_make_visible_with_new_height):
  28         Update.
  29         * tui/tui-source.c (tui_set_source_content)
  30         (tui_set_source_content_nil)
  31         (tui_source_window::do_scroll_vertical): Update.
  32         * tui/tui-layout.c (show_layout): Update.
  33         * tui/tui-disasm.c (tui_set_disassem_content)
  34         (tui_disasm_window::do_scroll_vertical): Update.
  35         * tui/tui-data.h (tui_win_content): Remove.
  36         (struct tui_gen_win_info) <content, content_size>: Remove.
  37         (struct tui_source_element): Add initializers and destructor.
  38         (union tui_which_element, struct tui_win_element): Remove.
  39         (struct tui_source_window_base) <content>: New field.
  40         (struct tui_data_window): Remove destructor.
  41         (tui_alloc_content, tui_free_win_content)
  42         (tui_free_all_source_wins_content): Don't declare.
  43         * tui/tui-data.c (tui_initialize_static_data): Update.
  44         (init_content_element, tui_alloc_content): Remove.
  45         (~tui_gen_win_info): Update.
  46         (~tui_data_window, tui_free_all_source_wins_content)
  47         (tui_free_win_content, free_content, free_content_elements):
  48         Remove.
  49
  50 2019-06-25  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-winsource.h (tui_clear_source_content)
  53         (tui_erase_source_content, tui_show_source_content): Change type
  54         of win_info.
  55         * tui/tui-winsource.c (tui_clear_source_content)
  56         (tui_erase_source_content, tui_show_source_content): Change type
  57         of win_info.
  58         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  59         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  60         win_info.
  61         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  62         win_info.
  63         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  64
  65 2019-06-25  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-winsource.c (tui_clear_source_content)
  68         (tui_source_window_base::set_is_exec_point_at): Update.
  69         * tui/tui-source.c (tui_set_source_content_nil): Update.
  70         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
  71         a bool.
  72         * tui/tui-data.c (init_content_element): Update.
  73
  74 2019-06-25  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
  77         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
  78         * tui/tui-layout.c (init_and_make_win): Update.
  79         * tui/tui.h (enum tui_win_type): Update.
  80         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
  81         tui_win_is_auxillary.
  82         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
  83         tui_win_is_auxillary.
  84
  85 2019-06-25  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
  88         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
  89         (tui_delete_data_content_windows, tui_display_all_data)
  90         (tui_data_window::do_scroll_vertical, tui_display_data_from):
  91         Update.
  92         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
  93         * tui/tui-regs.c (tui_last_regs_line_no)
  94         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  95         (tui_show_registers): Update.
  96         (tui_show_register_group): Return void.  Update.
  97         (tui_display_registers_from, tui_display_reg_element_at_line)
  98         (tui_display_registers_from_line, tui_check_register_values):
  99         Update.
 100         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 101         member.
 102         (struct tui_data_window) <regs_content>: Now a std::vector.
 103         <regs_content_count>: Remove.
 104         (tui_add_content_elements, tui_free_data_content): Don't declare.
 105         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 106         (init_content_element): Remove DATA_WIN case.  Add assert.
 107         (tui_add_content_elements): Remove.
 108         (tui_data_window): Update.
 109         (tui_free_data_content): Remove.
 110         (free_content_elements): Remove DATA_WIN case.
 111
 112 2019-06-25  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-data.c (tui_data_item_window): Update.
 115         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 116         * tui/tui-windata.c (tui_display_all_data)
 117         (tui_display_data_from_line): Update.
 118         (tui_check_data_values): Remove.
 119         * tui/tui-regs.c (tui_show_register_group)
 120         (tui_display_reg_element_at_line): Update.
 121         * tui/tui-hooks.c (tui_register_changed)
 122         (tui_refresh_frame_and_register_information): Call
 123         tui_check_register_values.
 124         * tui/tui-data.h (struct tui_data_window) <data_content,
 125         data_content_count, data_type>: Remove.
 126         (enum tui_data_type): Remove.
 127
 128         * tui/tui-data.c (tui_data_window::clear_detail)
 129         (~tui_data_window): Update.
 130
 131 2019-06-25  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 134         declare.
 135         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 136         Rename from tui_first_data_item_displayed.  Update.
 137         (tui_data_window::refresh_all)
 138         (tui_data_window::do_scroll_vertical): Update.
 139         * tui/tui-data.h (struct tui_data_window)
 140         <first_data_item_displayed>: Declare new method.
 141
 142 2019-06-25  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 145         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 146         contents...
 147         (tui_initialize_static_data): ...here.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 152         (tui_display_registers_from, tui_check_register_values): Update.
 153         (tui_display_register): Remove win_info parameter; update.
 154         (tui_get_register): Change type of parameters.
 155         * tui/tui-data.h (struct tui_data_element): Remove.
 156         (union tui_which_element) <data>: Remove.
 157         <data_window>: Change type.
 158         (struct tui_data_item_window): New.
 159         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 160         case.  Add assert.
 161         (~tui_data_item_window): New destructor.
 162         (free_content_elements): Remove DATA_ITEM_WIN case.
 163
 164 2019-06-25  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 167         Remove.
 168
 169 2019-06-25  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-data.h (struct tui_command_element): Remove.
 172         (union tui_which_element) <command>: Remove.
 173         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 174         assert.
 175         (free_content_elements): Remove CMD_WIN case.
 176
 177 2019-06-25  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-layout.c (tui_set_layout): Update.
 180         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 181         * tui/tui-data.c (layout_def): Update.
 182
 183 2019-06-25  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 186         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 187         (tui_source_window_base::set_new_height): Update.
 188         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 189         Update.
 190         (tui_set_locator_fullname, tui_set_locator_info)
 191         (tui_show_frame_info): Update.
 192         * tui/tui-source.c (tui_set_source_content)
 193         (tui_source_is_displayed): Update.
 194         * tui/tui-layout.c (show_source_disasm_command, show_data)
 195         (show_source_or_disasm_and_command): Update.
 196         * tui/tui-disasm.c (tui_set_disassem_content)
 197         (tui_get_begin_asm_address): Update.
 198         * tui/tui-data.h (struct tui_locator_element): Remove.
 199         (union tui_which_element) <locator>: Remove.
 200         (struct tui_locator_window): New.
 201         (tui_locator_win_info_ptr): Change return type.
 202         * tui/tui-data.c (_locator): Change type.
 203         (tui_locator_win_info_ptr): Change return type.
 204         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 205         (tui_alloc_content): Add assert.
 206
 207 2019-06-25  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-winsource.c
 210         (tui_exec_info_window::maybe_allocate_content): New method.
 211         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 212         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 213         (make_source_or_disasm_window): Add cast.
 214         * tui/tui-data.h (union tui_which_element) <simple_string>:
 215         Remove.
 216         (struct tui_source_info): New.
 217         (struct tui_source_window_base) <execution_info>: Change type.
 218         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 219         case, and add assert.
 220         (tui_alloc_content): Add assert.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 225         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 226         * tui/tui-data.c (tui_alloc_win_info): Remove.
 227
 228 2019-06-25  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 231         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 232         can_highlight.
 233
 234 2019-06-25  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 237         make_visible_with_new_height method.
 238         (tui_win_info::make_visible_with_new_height): New method.
 239         (tui_source_window_base::do_make_visible_with_new_height)
 240         (tui_data_window::do_make_visible_with_new_height)
 241         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 242         (make_visible_with_new_height): Remove.
 243         (tui_resize_all, tui_adjust_win_heights): Use
 244         make_visible_with_new_height method.
 245         * tui/tui-data.h (struct tui_win_info)
 246         <do_make_visible_with_new_height, make_visible_with_new_height>:
 247         New methods.
 248         (struct tui_source_window_base, struct tui_data_window)
 249         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 250         methods.
 251
 252 2019-06-25  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 255         method.
 256         (update_tab_width): Call update_tab_width method.
 257         * tui/tui-data.h (struct tui_win_info)
 258         (struct tui_source_window_base) <update_tab_width>: New methods.
 259
 260 2019-06-25  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 263         parameter.
 264         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 265         parameter.
 266         (tui_gen_win_info::make_visible): Update.
 267         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 268         parameter.
 269         * tui/tui-data.h (enum tui_box): New enum.
 270         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 275         init_and_make_win for EXEC_INFO_WIN.
 276         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 277         longer inline.
 278         (struct tui_win_info) <~tui_win_info>: Inline.
 279         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 280         Don't declare.
 281         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 282         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 283         Remove.
 284         (tui_initialize_static_data): Update.
 285         (~tui_gen_win_info): Handle more cleanup here.
 286         (~tui_source_window_base): Delete "execution_info".
 287         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 288
 289 2019-06-25  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-layout.c (make_command_window): Don't set
 292         can_highlight.
 293         (show_source_disasm_command): Call the reset method.
 294         (show_data): Don't set can_highlight.  Call the reset method.
 295         (tui_gen_win_info::reset): Rename from init_gen_win_info
 296         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 297         (show_source_or_disasm_and_command): Call the reset method.
 298         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 299         (struct tui_cmd_window): Set can_highlight.
 300
 301 2019-06-25  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 304         from make_visible.
 305         (tui_make_visible, tui_make_invisible): Rewrite.
 306         (tui_win_info::make_visible): Remove.
 307         (tui_source_window_base::make_visible): Update.
 308         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 309         method.  Moved from...
 310         (struct tui_win_info) <make_visible>: ...here.
 311
 312 2019-06-25  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-winsource.c
 315         (tui_source_window_base::do_scroll_horizontal): Remove direction
 316         parameter.
 317         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 318         direction parameter.
 319         * tui/tui-win.c (tui_win_info::forward_scroll)
 320         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 321         (tui_win_info::right_scroll): Update.
 322         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 323         direction parameter.
 324         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 325         direction parameter.
 326         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 327         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 328         Remove direction parameter.
 329         (struct tui_source_window_base, struct tui_source_window)
 330         (struct tui_disasm_window, struct tui_data_window)
 331         (struct tui_cmd_window): Update.
 332
 333 2019-06-25  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-winsource.h (tui_set_exec_info_content)
 336         (tui_show_exec_info_content, tui_erase_exec_info_content)
 337         (tui_clear_exec_info_content, tui_update_exec_info): Change
 338         argument to tui_source_window_base.
 339         * tui/tui-winsource.c (tui_set_exec_info_content)
 340         (tui_show_exec_info_content, tui_erase_exec_info_content)
 341         (tui_clear_exec_info_content, tui_update_exec_info): Change
 342         argument to tui_source_window_base.
 343
 344 2019-06-25  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 347         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 348
 349 2019-06-25  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 352         check.
 353
 354 2019-06-25  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 357         type to void.
 358         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 359         type to void.
 360         * tui/tui-source.c (tui_set_source_content): Update.
 361         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 362
 363 2019-06-25  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-win.c (window_name_completer, tui_set_focus)
 366         (tui_all_windows_info): Use name method.
 367         * tui/tui-data.h (struct tui_gen_win_info)
 368         (struct tui_source_window, struct tui_disasm_window)
 369         (struct tui_data_window, struct tui_cmd_window) <name>: New
 370         method.
 371         (tui_win_name): Don't declare.
 372         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 373         (tui_win_name): Remove.
 374
 375 2019-06-25  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-winsource.h (tui_update_source_window)
 378         (tui_update_source_window_as_is): Change parameter type.
 379         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 380         to be a tui_source_window_base.
 381         (tui_update_source_window_as_is): Likewise.
 382         * tui/tui-win.c (make_visible_with_new_height): Update.
 383
 384 2019-06-25  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-winsource.c (tui_erase_source_content)
 387         (tui_show_source_content, tui_show_exec_info_content)
 388         (tui_erase_exec_info_content): Use refresh_window method.
 389         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 390         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 391         from tui_refresh_win.
 392         (tui_data_window::refresh_window): New method.
 393         (tui_win_info::refresh, tui_source_window_base::refresh)
 394         (tui_refresh_all): Use refresh_window method.
 395         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 396         method.
 397         * tui/tui-regs.c (tui_display_register): Call refresh_window
 398         method.
 399         * tui/tui-layout.c (show_source_disasm_command)
 400         (show_source_or_disasm_and_command): Call refresh_window method.
 401         * tui/tui-data.h (struct tui_gen_win_info)
 402         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 403         New method.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui.c (tui_rl_other_window, tui_enable)
 408         (tui_is_window_visible, tui_get_command_dimension): Update.
 409         * tui/tui-winsource.c (tui_update_source_window_as_is)
 410         (tui_clear_source_content, tui_erase_source_content)
 411         (tui_show_source_line, tui_source_window_base::refill)
 412         (tui_source_window_base::do_scroll_horizontal)
 413         (tui_source_window_base::set_is_exec_point_at)
 414         (tui_update_breakpoint_info, tui_set_exec_info_content)
 415         (tui_alloc_source_buffer, tui_line_is_displayed)
 416         (tui_addr_is_displayed): Update.
 417         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 418         (tui_check_and_display_highlight_if_needed)
 419         (tui_win_info::make_visible, tui_win_info::refresh)
 420         (tui_refresh_all): Update.
 421         * tui/tui-windata.c (tui_first_data_item_displayed)
 422         (tui_delete_data_content_windows, tui_erase_data_content)
 423         (tui_display_all_data, tui_data_window::refresh_all)
 424         (tui_check_data_values): Update.
 425         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 426         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 427         (tui_win_info::backward_scroll, tui_refresh_all_win)
 428         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 429         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 430         (tui_source_window_base::set_new_height)
 431         (tui_data_window::set_new_height)
 432         (make_invisible_and_set_new_height)
 433         (make_visible_with_new_height, new_height_ok)
 434         (parse_scrolling_args): Update.
 435         * tui/tui-stack.c (tui_show_frame_info): Update.
 436         * tui/tui-source.c (tui_set_source_content)
 437         (tui_set_source_content_nil, tui_source_is_displayed)
 438         (tui_source_window::do_scroll_vertical): Update.
 439         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 440         (tui_display_registers_from, tui_display_reg_element_at_line)
 441         (tui_check_register_values, tui_reg_command): Update.
 442         * tui/tui-layout.c (tui_default_win_height)
 443         (show_source_disasm_command, show_data, init_and_make_win)
 444         (show_source_or_disasm_and_command): Update.
 445         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 446         (tui_redisplay_readline, tui_mld_flush)
 447         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 448         (tui_getc): Update.
 449         * tui/tui-disasm.c (tui_set_disassem_content)
 450         (tui_disasm_window::do_scroll_vertical): Update.
 451         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 452         Now virtual.
 453         (struct tui_win_info): Derive from tui_gen_win_info.
 454         <~tui_win_info>: Mark as override.
 455         <generic>: Remove member.
 456         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 457         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 458         (~tui_data_window, ~tui_win_info)
 459         (tui_free_all_source_wins_content): Update.
 460         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 461
 462 2019-06-25  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-layout.c (init_and_make_win): Use new.
 465         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 466         destructor, initializers.
 467         (tui_alloc_generic_win_info): Don't declare.
 468         * tui/tui-data.c (_locator): Add argument to constructor.
 469         (source_win, disasm_win): New globals.
 470         (exec_info): Remove.
 471         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 472         Update.
 473         (tui_alloc_generic_win_info): Remove.
 474         (init_content_element): Use new.
 475         (tui_win_info::tui_win_info): Update.
 476         (free_content_elements) <case DATA_WIN>: Use delete.
 477
 478 2019-06-25  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 481         * tui/tui-windata.c (tui_first_data_item_displayed)
 482         (tui_delete_data_content_windows): Update.
 483         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 484         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 485         (tui_display_registers_from, tui_check_register_values): Update.
 486         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 487         pointer.
 488         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 489         window.
 490         (tui_free_data_content): Update.
 491         (free_content_elements) <case DATA_WIN>: Free the window.
 492
 493 2019-06-25  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 496         Update.
 497         * tui/tui-layout.c (make_command_window)
 498         (show_source_disasm_command, show_data, init_and_make_win)
 499         (show_source_or_disasm_and_command): Update.
 500         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 501         method.
 502         <can_highight, is_highlighted>: Now bool.
 503         (tui_set_win_highlight): Don't declare.
 504         * tui/tui-data.c (tui_set_win_highlight): Remove.
 505
 506 2019-06-25  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-wingeneral.c (make_visible): Remove check of window
 509         type.
 510
 511 2019-06-25  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-win.c (tui_win_info::max_height)
 514         (tui_cmd_window::max_height): New methods.
 515         (new_height_ok): Call max_height.
 516         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 517         <max_height>: New method.
 518
 519 2019-06-25  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-win.c (tui_source_window_base::set_new_height)
 522         (tui_data_window::set_new_height): New methods.
 523         (make_invisible_and_set_new_height): Call set_new_height method.
 524         * tui/tui-data.h (struct tui_win_info)
 525         (struct tui_source_window_base, struct tui_data_window)
 526         <set_new_height>: New method.
 527
 528 2019-06-25  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 531         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 532         tui_refresh_data_win.
 533         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 534         method.
 535         (tui_refresh_all_win): Call the refresh_all method.
 536         (tui_set_focus): Likewise.
 537         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 538         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 539         Likewise.
 540
 541 2019-06-25  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-winsource.h (tui_refill_source_window)
 544         (tui_set_is_exec_point_at): Don't declare.
 545         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 546         (tui_source_window_base::refill): Rename from
 547         tui_refill_source_window.
 548         (tui_source_window_base::do_scroll_horizontal): Update.
 549         (tui_source_window_base::set_is_exec_point_at): Rename from
 550         tui_set_is_exec_point_at.
 551         (tui_update_all_breakpoint_info): Update.
 552         * tui/tui-stack.c (tui_show_frame_info): Update.
 553         * tui/tui-layout.c (show_data): Add cast.
 554         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 555         * tui/tui-data.h (struct tui_source_window_base) <refill,
 556         set_is_exec_point_at>: New methods.
 557         (tui_source_windows, tui_add_to_source_windows): Update types.
 558         (tui_add_to_source_windows): Remove redundant declaration.
 559         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 560         (tui_source_windows): Change return type.
 561         (tui_clear_source_windows_detail): Update.
 562         (tui_add_to_source_windows): Change type of parameter.
 563         (tui_free_all_source_wins_content): Update.
 564
 565 2019-06-25  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-wingeneral.c (tui_win_info::refresh)
 568         (tui_source_window_base::refresh): New methods.
 569         (tui_refresh_all): Call the refresh method.
 570         * tui/tui-data.h (struct tui_win_info)
 571         (struct tui_source_window_base) <refresh>: New method.
 572
 573 2019-06-25  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui.h (tui_is_window_visible): Return bool.
 576         * tui/tui.c (tui_is_window_visible): Return bool.
 577         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 578         (tui_make_visible, tui_make_invisible)
 579         (tui_win_info::make_visible)
 580         (tui_source_window_base::make_visible, make_all_visible)
 581         (tui_make_all_visible, tui_make_all_invisible): Update.
 582         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 583         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 584         bool.
 585         (struct tui_win_info, struct tui_source_window_base)
 586         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 587         * tui/tui-data.c (tui_init_generic_part): Update.
 588
 589 2019-06-25  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 592         (tui_source_window_base::make_visible): New methods.
 593         (make_all_visible): Make method call.
 594         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 595         (struct tui_source_window_base, struct tui_cmd_window): Override
 596         make_visible.
 597         (tui_win_is_source_type): Don't declare.
 598         * tui/tui-data.c (tui_win_is_source_type): Remove.
 599
 600 2019-06-25  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 603         NULL check.
 604
 605 2019-06-25  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 608         Inline constructor.  Add initializers for members.
 609         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 610         constructors; now inline in class.
 611
 612 2019-06-25  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-regs.c (tui_show_registers): Update.
 615         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 616         bool.
 617         * tui/tui-data.c (tui_data_window::clear_detail)
 618         (tui_data_window): Update.
 619
 620 2019-06-25  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-windata.c (tui_display_all_data)
 623         (tui_display_data_from_line, tui_display_data_from)
 624         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 625         Update.
 626         * tui/tui-regs.c (tui_last_regs_line_no)
 627         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 628         (tui_show_registers, tui_show_register_group)
 629         (tui_display_registers_from, tui_display_reg_element_at_line)
 630         (tui_display_registers_from_line, tui_check_register_values)
 631         (tui_reg_next, tui_reg_prev): Update.
 632         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 633         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 634         tui_data_window.
 635         (struct tui_win_info) <detail>: Remove.  Add new fields from
 636         tui_data_info.
 637         (TUI_DATA_WIN): Add cast.
 638         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 639         (~tui_data_window): Simplify.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-layout.c (show_source_disasm_command)
 644         (show_source_or_disasm_and_command): Update.
 645         * tui/tui-io.c (update_cmdwin_start_line)
 646         (tui_redisplay_readline): Update.
 647         * tui/tui-data.h (struct tui_command_info): Remove.
 648         (struct tui_win_info) <detail>: Remove command_info member.
 649         (struct tui_data_window) <start_line>: New member, from
 650         tui_command_info.
 651         (TUI_CMD_WIN): Add casts.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-winsource.c (tui_update_source_window)
 656         (tui_refill_source_window)
 657         (tui_source_window_base::do_scroll_horizontal)
 658         (tui_update_breakpoint_info, tui_set_exec_info_content)
 659         (tui_show_exec_info_content, tui_erase_exec_info_content)
 660         (tui_clear_exec_info_content): Update.
 661         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 662         Update.
 663         * tui/tui-win.c (make_invisible_and_set_new_height)
 664         (make_visible_with_new_height): Update.
 665         * tui/tui-source.c (tui_set_source_content)
 666         (tui_show_symtab_source): Update.
 667         * tui/tui-layout.c (extract_display_start_addr)
 668         (show_source_disasm_command, show_data)
 669         (make_source_or_disasm_window)
 670         (show_source_or_disasm_and_command): Update.
 671         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 672         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 673         "gdbarch".
 674         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 675         to tui_source_window_base.
 676         (struct tui_win_info) <detail>: Remove source_info member.
 677         (struct tui_source_window_base) <has_locator>: Inline.
 678         Move contents from tui_source_info; rename has_locator member to
 679         m_has_locator.
 680         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 681         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 682         header file.
 683         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 684         Simplify.
 685         (tui_free_all_source_wins_content): Cast to
 686         tui_source_window_base.
 687
 688 2019-06-25  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-win.c (make_invisible_and_set_new_height)
 691         (make_visible_with_new_height): Call has_locator method.
 692         * tui/tui-layout.c (show_source_disasm_command, show_data)
 693         (show_source_or_disasm_and_command): Update for bool change.
 694         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 695         (tui_win_info) <has_locator>: New method.
 696         (struct tui_source_window_base) <has_locator>: New method.
 697         (tui_win_has_locator): Don't declare.
 698         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 699         from tui_win_has_locator.
 700         (tui_source_window_base): Use false, not FALSE.
 701
 702 2019-06-25  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 705         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 706         clear_detail method directly.
 707         (tui_clear_win_detail): Remove.
 708
 709 2019-06-25  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 712         "this", not TUI_DISASM_WIN.
 713
 714 2019-06-25  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 717         declare.
 718         * tui/tui-winsource.c
 719         (tui_source_window_base::do_scroll_horizontal): Rename from
 720         tui_horizontal_source_scroll.
 721         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 722         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 723         from tui_vertical_data_scroll.
 724         * tui/tui-win.h (tui_scroll): Don't declare.
 725         * tui/tui-win.c (tui_win_info::forward_scroll)
 726         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 727         (tui_win_info::right_scroll): Rename and update.
 728         (tui_scroll_forward_command, tui_scroll_backward_command)
 729         (tui_scroll_left_command, tui_scroll_right_command): Update.
 730         (tui_scroll): Remove.
 731         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 732         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 733         from tui_vertical_source_scroll.
 734         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 735         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 736         from tui_vertical_disassem_scroll.
 737         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 738         do_scroll_horizontal>: New methods.
 739         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 740         Likewise.
 741         (struct tui_source_window_base): Add do_scroll_horizontal.
 742         (struct tui_source_window, struct tui_disasm_window): Add
 743         do_scroll_vertical.
 744         (struct tui_data_window, struct tui_cmd_window): Add
 745         do_scroll_horizontal and do_scroll_vertical.
 746         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 747
 748 2019-06-25  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-data.h (struct tui_source_window_base): New struct.
 751         (struct tui_source_window): Derive from tui_source_window_base.
 752         (struct tui_disasm_window): New struct.
 753         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 754         from tui_source_window::clear_detail.
 755         (tui_source_window_base): Rename from tui_source_window.
 756         (~tui_source_window_base): Rename from ~tui_source_window.
 757         (tui_alloc_win_info): Create a tui_disasm_window.
 758
 759 2019-06-25  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-data.h (struct tui_source_window)
 762         (struct tui_data_window): Declare destructors.
 763         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 764         destructors.
 765         (tui_win_info): Simplify.
 766
 767 2019-06-25  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-winsource.c (tui_display_main)
 770         (tui_update_source_windows_with_addr)
 771         (tui_update_all_breakpoint_info): Update.
 772         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 773         (new_height_ok, parse_scrolling_args): Update.
 774         * tui/tui-stack.c (tui_show_frame_info): Update.
 775         * tui/tui-data.h (struct tui_list): Remove.
 776         (tui_source_windows): Return a reference to a std::vector.
 777         * tui/tui-data.c (source_windows): Now a std::vector.
 778         (tui_source_windows): Change return type.
 779         (tui_clear_source_windows): Rewrite.
 780         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 781         (tui_free_all_source_wins_content): Rewrite.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 786         (struct tui_data_window, struct tui_cmd_window): Declare
 787         clear_detail method.
 788         * tui/tui-data.c (tui_source_window::clear_detail)
 789         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 790         methods.
 791         (tui_clear_win_detail): Simplify.
 792
 793 2019-06-25  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-layout.c (make_source_window, make_disasm_window)
 796         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 797         Return the new window.
 798         (show_source_disasm_command, show_data)
 799         (show_source_or_disasm_and_command): Update.
 800
 801 2019-06-25  Tom Tromey  <tom@tromey.com>
 802
 803         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 804         parameter.  Return the new window.
 805         (show_source_disasm_command): Update and remove NULL check.
 806         (show_source_or_disasm_and_command): Update.
 807
 808 2019-06-25  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 811
 812 2019-06-25  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-data.h (struct tui_win_info): Make constructor
 815         protected.  Make destructor virtual.  Add initializers.
 816         (tui_source_window, tui_data_window, tui_cmd_window): New
 817         classes.
 818         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 819         constructor.  Add "type" parameter.
 820         (tui_source_window, tui_data_window, tui_cmd_window): New
 821         constructors.
 822         (tui_alloc_win_info): Instantiate the appropriate subclass.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-win.c (tui_resize_all): Use delete.
 827         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 828         destructor.
 829         (tui_free_window): Don't declare.
 830         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 831         Update.
 832
 833 2019-06-25  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-data.h (struct tui_win_info): Add constructor.
 836         * tui/tui-data.c (tui_alloc_win_info): Use new.
 837         (tui_free_window): Use delete.
 838
 839 2019-06-22  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 842         declare.
 843         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 844
 845 2019-06-22  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 848         declare.
 849         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 850
 851 2019-06-22  Tom de Vries  <tdevries@suse.de>
 852
 853         * dwarf2read.c (create_addrmap_from_aranges)
 854         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 855         instead of '%zu'.
 856
 857 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 858
 859         * dwarf2read.h (dwarf2_section_info_def): Remove.
 860         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 861         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 862         std::vector<dwarf2_section_info>.
 863         (struct dwo_file) <~dwo_file>: Remove.
 864         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 865         types field.
 866         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 867         (dwarf2_read_debug_names): Likewise.
 868         (create_debug_types_hash_table): Change parameter type to
 869         array_view, adjust code accordingly.
 870         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 871         (partial_die_info::fixup): Likewise.
 872         (determine_prefix): Likewise.
 873         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 874
 875 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 876
 877         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 878         gdb_bfd_ref_ptr.
 879         <~dwo_file>: Remove call to gdb_bfd_unref.
 880         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 881         gdb_bfd_ref_ptr::get.
 882
 883 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 884
 885         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 886         type to htab_up.
 887         * dwarf2read.c (struct dwo_file): Initialize fields.
 888         <~dwo_file>: New.
 889         (free_dwo_file): Remove, move content to ~dwo_file.
 890         (struct dwo_file_deleter): Remove.
 891         (dwo_file_up>: Remove custom deleter.
 892         (free_dwo_files): Remove.
 893         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 894         dwo_files.
 895         (process_skeletonless_type_units): Call unique_ptr::get.
 896         (allocate_dwo_file_hash_table): Add deleter to created hash
 897         table.  Change return type to htab_up.
 898         (lookup_dwo_file_slot): Don't memset dwo_file, call
 899         unique_ptr::get.
 900         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 901         (create_dwo_unit_in_dwp_v2): Likewise.
 902         (open_and_init_dwo_file): Likewise.
 903         (free_dwo_file_from_slot): Remove.
 904
 905 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 906
 907         * dwarf2read.h (struct dwarf2_section_info) <readin,
 908         is_virtual>: Change type to bool.
 909         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 910         true instead of 1.
 911
 912 2019-06-19  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-data.h (tui_init_content_element): Don't declare.
 915
 916 2019-06-19  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-data.h (tui_init_win_info): Don't declare.
 919
 920 2019-06-19  Tom de Vries  <tdevries@suse.de>
 921
 922         * dwarf2read.h (abstract_to_concrete): Change type to
 923         std::unordered_map<sect_offset, std::vector<sect_offset>,
 924         gdb::hash_enum<sect_offset>>.
 925
 926 2019-06-19  Tom Tromey  <tromey@adacore.com>
 927
 928         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 929         EVAL_AVOID_SIDE_EFFECTS specially.
 930
 931 2019-06-19  Tom Tromey  <tromey@adacore.com>
 932
 933         * source-cache.c (highlighter): New global.
 934         (source_cache::get_source_lines): Create a highlighter on demand.
 935
 936 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * defs.h (deprecated_interactive_hook): Delete declaration.
 939         * interps.c (clear_interpreter_hooks): Remove use of
 940         deprecated_interactive_hook.
 941         * top.c (deprecated_interactive_hook): Delete definition.
 942         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 943
 944 2019-06-18  Tom de Vries  <tdevries@suse.de>
 945
 946         PR gdb/24515
 947         * dwarf2read.h (abstract_to_concrete): Change type from
 948         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 949         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 950         * dwarf2read.c (read_variable): Update.
 951         (dwarf2_fetch_die_loc_sect_off): Update.
 952
 953 2019-06-17  Tom de Vries  <tdevries@suse.de>
 954
 955         PR gdb/24617
 956         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 957         accessing parent[parent_len - 1].
 958
 959 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 960
 961         PR gdb/24364
 962         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 963         call dtrace_process_dof with NULL dof.
 964
 965 2019-06-16  Tom de Vries  <tdevries@suse.de>
 966
 967         PR gdb/24445
 968         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 969
 970 2019-06-16  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 973         (make_all_visible): Use address of member.
 974
 975 2019-06-16  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 978         (tui_free_window, free_content, free_content_elements): Remove
 979         unnecessary cast.
 980         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 981         cast.
 982         * tui/tui-regs.c (tui_show_register_group)
 983         (tui_display_registers_from, tui_display_reg_element_at_line):
 984         Remove unnecessary cast.
 985
 986 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 987
 988         * linux-nat.c (normal_mask): Delete.
 989         (_initialize_linux_nat): Don't initialise normal_mask.
 990
 991 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 992
 993         PR gdb/24445
 994         * dwarf-index-write.h (write_psymtabs_to_index): Add
 995         dwz_basename parameter.
 996         * dwarf-index-write.c (write_gdbindex): Move file writing to
 997         write_gdbindex_1.  Change return type void.
 998         (assert_file_size): Move up, remove filename parameter.
 999         (write_gdbindex_1): New function.
1000         (write_debug_names): Change return type to void, call
1001         assert_file_size.
1002         (struct index_wip_file): New struct.
1003         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1004         file logic to index_wip_file.  Write index for dwz file if
1005         needed.
1006         (save_gdb_index_command): Pass basename of dwz file, if present.
1007         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1008         build-id of dwz file, if present.
1009         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1010         (dwarf2_get_dwz_file): Likewise.
1011         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1012         (dwarf2_get_dwz_file): Likewise.
1013
1014 2019-06-16  Tom Tromey  <tom@tromey.com>
1015
1016         * coffread.c (process_coff_symbol): Use xstrdup.
1017         * value.c (create_internalvar): Use xstrdup.
1018
1019 2019-06-16  Tom Tromey  <tom@tromey.com>
1020
1021         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1022         * breakpoint.c (stopin_command, stopat_command)
1023         (until_break_command, decode_location_default): Remove unnecessary
1024         cast.
1025         * utils.c (subset_compare): Remove unnecessary cast.
1026         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1027         cast.
1028         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1029         cast.
1030         * infcmd.c (path_command): Remove unnecessary cast.
1031         * coffread.c (decode_type): Remove unnecessary cast.
1032         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1033         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1034         * tui/tui-stack.c (tui_show_locator_content)
1035         (tui_show_frame_info): Remove unnecessary cast.
1036         * tui/tui-win.c (tui_scroll_forward_command)
1037         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1038         (parse_scrolling_args): Remove unnecessary cast.
1039         * tui/tui-data.c (init_win_info, tui_del_window)
1040         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1041         (free_content_elements): Remove unnecessary cast.
1042         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1043         unnecessary cast.
1044         * tui/tui-source.c (tui_set_source_content)
1045         (tui_vertical_source_scroll): Remove unnecessary cast.
1046         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1047         cast.
1048         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1049         * tui/tui-regs.c (tui_display_registers_from)
1050         (tui_display_register): Remove unnecessary cast.
1051         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1052         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1053         (make_visible): Remove unnecessary cast.
1054         * tui/tui-winsource.c (tui_erase_source_content)
1055         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1056         unnecessary cast.
1057         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1058         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1059         * stabsread.c (read_type, read_array_type, read_range_type):
1060         Remove unnecessary cast.
1061         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1062         (parse_symbol, parse_type, upgrade_type, parse_external)
1063         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1064         unnecessary cast.
1065         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1066
1067 2019-06-16  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-data.c (tui_alloc_generic_win_info)
1070         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1071         checks.
1072
1073 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1074             Andrew Burgess  <andrew.burgess@embecosm.com>
1075
1076         * f-typeprint.c (f_print_type): Don't return early for not
1077         associated or not allocated types.
1078         (f_type_print_varspec_suffix): Add print_rank parameter and print
1079         ranks of array types in case they dangling.
1080         (f_type_print_base): Add print_rank parameter.
1081
1082 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * NEWS: Mention new MI commands.
1085         * break-catch-throw.c (enum exception_event_kind): Move to
1086         breakpoint.h.
1087         (print_mention_exception_catchpoint): Output text as a single
1088         message.
1089         (catch_exception_command_1): Rename to...
1090         (catch_exception_event): ...this, make non-static, update header
1091         command, and change some parameter types.
1092         (catch_catch_command): Update for changes to
1093         catch_exception_command_1.
1094         (catch_throw_command): Likewise.
1095         (catch_rethrow_command): Likewise.
1096         * breakpoint.c (enum exception_event_kind): Delete.
1097         * breakpoint.h (enum exception_event_kind): Moved here from
1098         break-catch-throw.c.
1099         (catch_exception_event): Declare.
1100         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1101         (mi_cmd_catch_throw): New function.
1102         (mi_cmd_catch_rethrow): New function.
1103         (mi_cmd_catch_catch): New function.
1104         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1105         'catch-catch' entries.
1106         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1107         (mi_cmd_catch_rethrow): Declare.
1108         (mi_cmd_catch_catch): Declare.
1109
1110 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * annotate.c (annotate_source_line): Change return type to void,
1113         update implementation to match.
1114         * annotate.h (annotate_source_line): Change return type to void,
1115         update header comment.
1116         * stack.c (print_frame_info): Don't change what frame information
1117         is printed based on whether annotations are on or not.
1118
1119 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1122         (annotate_source): Make static.
1123         (annotate_source_line): Moved from source.c and renamed from
1124         identify_source_line.  Update the return type.
1125         * annotate.h (annotate_source): Delete declaration.
1126         (annotate_source_line): Declaration moved from source.h, and
1127         renamed from identify_source_line.  Return type updated.
1128         * source.c (identify_source_line): Moved to annotate.c and renamed
1129         to annotate_source_line.
1130         (info_line_command): Remove check of annotation_level.
1131         * source.h (identify_source_line): Move declaration to annotate.h
1132         and rename to annotate_source_line.
1133         * stack.c: Add 'annotate.h' include.
1134         (print_frame_info): Remove check of annotation_level before
1135         calling annotate_source_line.
1136
1137 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * source-cache.c (source_cache::get_plain_source_lines): Use
1140         open_source_file_with_line_charpos instead of just
1141         open_source_file, remove call to find_source_lines.
1142         (source_cache::get_source_lines): Likewise.
1143         * source.c (find_source_lines): Make static.
1144         (get_filename_and_charpos): Renamed into...
1145         (open_source_file_with_line_charpos): ..this along with changes to
1146         return a scoped_fd, and some other minor clean ups.
1147         (identify_source_line): Use open_source_file_with_line_charpos.
1148         (search_command_helper): Use open_source_file_with_line_charpos
1149         instead of just open_source_file, remove call to
1150         find_source_lines.
1151         * source.h (open_source_file_with_line_charpos): Declare new
1152         function.
1153         (find_source_lines): Delete declaration.
1154
1155 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * source.c (get_filename_and_charpos): Remove fullname
1158         parameter.
1159         (identify_source_line): Update call to get_filename_and_charpos.
1160
1161 2019-06-14  Tom Tromey  <tromey@adacore.com>
1162
1163         PR gdb/24502:
1164         * ui-style.h (skip_ansi_escape): Update comment.
1165         * ui-file.h (class no_terminal_escape_file): New class.
1166         * ui-file.c (no_terminal_escape_file::write)
1167         (no_terminal_escape_file::puts): New methods.
1168         * cli/cli-logging.c (handle_redirections): Use
1169         no_terminal_escape_file.
1170
1171 2019-06-14  Tom Tromey  <tromey@adacore.com>
1172
1173         * NEWS: Move convenience variable news above Python news.
1174
1175 2019-06-14  Tom Tromey  <tom@tromey.com>
1176
1177         * gnulib: Move directory to top-level.
1178         * configure.ac: Don't configure gnulib.
1179         * configure: Rebuild.
1180         * common/common-defs.h: Use new path to gnulib.
1181         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1182         (GNULIB_H): Remove.
1183         (INCGNU): Look in new gnulib location.
1184         (HFILES_NO_SRCDIR): Remove gnulib files.
1185         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1186         (generated_files): Remove GNULIB_H.
1187         ($(LIBGNU), all-lib): Remove targets.
1188         (distclean): Don't mention GNULIB_BUILDDIR.
1189         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1190
1191 2019-06-14  Tom Tromey  <tromey@adacore.com>
1192
1193         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1194         Warn if symbol file does not provide any symbols.
1195
1196 2019-06-14  Tom Tromey  <tromey@adacore.com>
1197
1198         * source.c (find_and_open_source): Respect basenames_may_differ.
1199
1200 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * annotate.c (annotate_breakpoints_invalid): Make use of
1203         scoped_restore_terminal_state.
1204         (annotate_frames_invalid): Likewise.
1205
1206 2019-06-14  Tom Tromey  <tromey@adacore.com>
1207
1208         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1209         allow assignment to an internalvar.
1210
1211 2019-06-14  Tom Tromey  <tromey@adacore.com>
1212
1213         * ada-lex.l: Allow "_" in attribute names.
1214
1215 2019-06-14  Tom Tromey  <tromey@adacore.com>
1216
1217         PR gdb/24653:
1218         * regcache.c (registers_changed): Don't call alloca.
1219         * top.c (execute_command): Don't call alloca.
1220
1221 2019-06-13  Pedro Alves  <palves@redhat.com>
1222
1223         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1224         'expression'.  When parsing an expression, error out if there's
1225         junk after "unlimited".
1226         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1227         (do_set_command): Adjust calls to is_unlimited_literal.
1228
1229 2019-06-13  Pedro Alves  <palves@redhat.com>
1230
1231         * compile/compile.c (make_compile_options_def_group): Add braces
1232         around array_view initializer.
1233         * thread.c (make_thread_apply_all_options_def_group)
1234         (make_thread_apply_all_options_def_group): Likewise.
1235
1236 2019-06-13  Pedro Alves  <palves@redhat.com>
1237
1238         * NEWS (New commands): Mention "maint test-options
1239         require-delimiter", "maint test-options unknown-is-error", "maint
1240         test-options unknown-is-operand" and "maint show
1241         test-options-completion-result".
1242         (New command options, command completion): New section.
1243         (Completion improvements): New section.
1244         Mention that you can abbreviate "unlimited".
1245
1246 2019-06-13  Pedro Alves  <palves@redhat.com>
1247
1248         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1249         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1250         * unittests/cli-utils-selftests.c (test_parse_flags)
1251         (test_parse_flags_qcs): Delete.
1252         (test_cli_utils): Don't call deleted functions.
1253
1254 2019-06-13  Pedro Alves  <palves@redhat.com>
1255
1256         * thread.c: Include "cli/cli-option.h".
1257         (tp_array_compar_ascending): Global.
1258         (tp_array_compar): Delete function.
1259         (tp_array_compar_ascending, tp_array_compar_descending): New
1260         functions.
1261         (ascending_option_def, qcs_flag_option_def)
1262         (thr_qcs_flags_option_defs)
1263         (make_thread_apply_all_options_def_group)
1264         (make_thread_apply_options_def_group): New.
1265         (thread_apply_all_command): Use gdb::option::process_options.
1266         (thread_apply_command_completer)
1267         (thread_apply_all_command_completer): New.
1268         (thread_apply_command): Use gdb::option::process_options.
1269         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1270         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1271         to generate help text of "thread apply".  Adjust "taas"'s help.
1272         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1273         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1274
1275 2019-06-13  Pedro Alves  <palves@redhat.com>
1276
1277         * thread.c (thread_apply_command): Check for invalid TID with
1278         isdigit instead of !isalpha.
1279
1280 2019-06-13  Pedro Alves  <palves@redhat.com>
1281
1282         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1283         (validate_flags_qcs): New.
1284         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1285         (validate_flags_qcs): Declare.
1286         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1287         (make_frame_apply_options_def_group): New.
1288         (frame_apply_command_count): Process options with
1289         gdb::option::process_options.
1290         (frame_apply_completer): New.
1291         (frame_apply_level_completer, frame_apply_all_completer)
1292         (frame_apply_completer): New.
1293         (_initialize_stack): Update help of "frame apply", "frame apply
1294         level", "frame apply all" and "faas" to mention supported options
1295         and install command completers.
1296         * stack.h (frame_apply_all_completer): Declare.
1297         * thread.c: Include "stack.h".
1298         (tfaas_command): Add "--".
1299         (_initialize_thread): Update help "tfaas" to mention supported
1300         options and install command completer.
1301
1302 2019-06-13  Pedro Alves  <palves@redhat.com>
1303
1304         * completer.c (complete_nested_command_line): New.
1305         (gdb_completion_word_break_characters_throw): Add assertion.
1306         * completer.h (complete_nested_command_line): Declare.
1307
1308 2019-06-13  Pedro Alves  <palves@redhat.com>
1309
1310         * stack.c (parse_backtrace_qualifiers): New.
1311         (backtrace_command): Use it.
1312         (backtrace_command_completer): Complete on qualifiers.
1313
1314 2019-06-13  Pedro Alves  <palves@redhat.com>
1315
1316         * frame.c: Include "cli/cli-option.h.
1317         (user_set_backtrace_options): New.
1318         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1319         Delete.
1320         (get_prev_frame): Adjust.
1321         (boolean_option_def, uinteger_option_def)
1322         (set_backtrace_option_defs): New.
1323         (_initialize_frame): Adjust and use
1324         gdb::option::add_setshow_cmds_for_options to install "set
1325         backtrace past-main" and "set backtrace past-entry".
1326         * frame.h: Include "cli/cli-option.h".
1327         (struct frame_print_options): Forward declare.
1328         (print_frame_arguments_all, print_frame_arguments_scalars)
1329         (print_frame_arguments_none): Declare.
1330         (print_entry_values): Delete declaration.
1331         (struct frame_print_options, user_frame_print_options): New.
1332         (struct set_backtrace_options): New.
1333         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1334         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1335         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1336         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1337         (list_args_or_locals): Add frame_print_options parameter.
1338         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1339         * python/py-framefilter.c (enumerate_args): Pass down
1340         USER_FRAME_PRINT_OPTIONS.
1341         * stack.c: Include "cli/cli-option.h".
1342         (print_frame_arguments_all, print_frame_arguments_scalars)
1343         (print_frame_arguments_none): Declare.
1344         (print_raw_frame_arguments, print_entry_values): Delete.
1345         (user_frame_print_options): New.
1346         (boolean_option_def, enum_option_def, frame_print_option_defs):
1347         New.
1348         (struct backtrace_cmd_options): New.
1349         (bt_flag_option_def): New.
1350         (backtrace_command_option_defs): New.
1351         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1352         (print_frame_arg, read_frame_arg, print_frame_args)
1353         (print_frame_info, print_frame): Add frame_print_options parameter
1354         and use it.
1355         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1356         (backtrace_command_1): Add frame_print_options and
1357         backtrace_cmd_options parameters and use them.
1358         (make_backtrace_options_def_group): New.
1359         (backtrace_command): Process command options with
1360         gdb::option::process_options.
1361         (backtrace_command_completer): New.
1362         (_initialize_stack): Extend "backtrace"'s help to mention
1363         supported options.  Install completer for "backtrace".
1364         Install some settings commands with add_setshow_cmds_for_options.
1365
1366 2019-06-13  Pedro Alves  <palves@redhat.com>
1367
1368         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1369         and that "set/show print raw frame-arguments" are now deprecated.
1370
1371         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1372         command.
1373         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1374         * stack.c (_initialize_stack): Install "set/show print
1375         raw-frame-arguments", and deprecate "set/show print raw
1376         frame-arguments".
1377         * valprint.c (_initialize_valprint): Deprecate "set/show print
1378         raw".
1379
1380 2019-06-13  Pedro Alves  <palves@redhat.com>
1381
1382         * compile/compile.c (struct compile_options): New.
1383         (compile_flag_option_def, compile_command_option_defs)
1384         (make_compile_options_def_group): New.
1385         (compile_file_command): Handle options with
1386         gdb::option::process_options.
1387         (compile_file_command_completer): New function.
1388         (compile_code_command): Handle options with
1389         gdb::option::process_options.
1390         (compile_code_command_completer): New function.
1391         (_initialize_compiler): Install completers for "compile code" and
1392         "compile file".  Mention available options in "compile code" and
1393         "compile code"'s help.
1394         * completer.c (advance_to_completion_word): New, factored out from
1395         ...
1396         (advance_to_expression_complete_word_point): ... this.
1397         (advance_to_filename_complete_word_point): New.
1398         * completer.h (advance_to_filename_complete_word_point): New
1399         declaration.
1400
1401 2019-06-13  Pedro Alves  <palves@redhat.com>
1402
1403         * compile/compile.c: Include "cli/cli-option.h".
1404         (compile_print_value): Scope data pointer is now a
1405         value_print_options pointer; adjust.
1406         (compile_print_command): Process options.  Scope data pointer is
1407         now a value_print_options pointer; adjust.
1408         (_initialize_compile): Update "compile print"'s help to include
1409         supported options.  Install a completer for "compile print".
1410         * cp-valprint.c (show_vtblprint, show_objectprint)
1411         (show_static_field_print): Delete.
1412         (_initialize_cp_valprint): Don't install "set print
1413         static-members", "set print vtbl", "set print object" here.
1414         * printcmd.c: Include "cli/cli-option.h" and
1415         "common/gdb_optional.h".
1416         (print_command_parse_format): Rework to fill in a
1417         value_print_options instead of a format_data.
1418         (print_value): Change parameter type from format_data pointer to
1419         value_print_options reference.  Adjust.
1420         (print_command_1): Process options.  Adjust to pass down a
1421         value_print_options.
1422         (print_command_completer): New.
1423         (_initialize_printcmd): Install print_command_completer as
1424         handle_brkchars completer for the "print" command.  Update
1425         "print"'s help to include supported options.
1426         * valprint.c: Include "cli/cli-option.h".
1427         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1428         here from cp-valprint.c.
1429         (boolean_option_def, uinteger_option_def)
1430         (value_print_option_defs, make_value_print_options_def_group):
1431         New.  Use gdb::option::add_setshow_cmds_for_options to install
1432         "set print elements", "set print null-stop", "set print repeats",
1433         "set print pretty", "set print union", "set print array", "set
1434         print address", "set print symbol", "set print array-indexes".
1435         * valprint.h: Include <string> and "cli/cli-option.h".
1436         (make_value_print_options_def_group): Declare.
1437         (print_value): Change parameter type from format_data pointer to
1438         value_print_options reference.
1439         (print_command_completer): Declare.
1440
1441 2019-06-13  Pedro Alves  <palves@redhat.com>
1442
1443         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1444         (COMMON_SFILES): Add maint-test-settings.c.
1445         * cli/cli-decode.c (boolean_enums): New global, factored out from
1446         ...
1447         (add_setshow_boolean_cmd): ... here.
1448         * cli/cli-decode.h (boolean_enums): Declare.
1449         * cli/cli-option.c: New file.
1450         * cli/cli-option.h: New file.
1451         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1452         factored out from ...
1453         (parse_cli_boolean_value(const char *)): ... this.
1454         (is_unlimited_literal): Change parameter type to pointer to
1455         pointer.  Adjust and advance ARG pointer.
1456         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1457         (parse_cli_var_enum): New, factored out from ...
1458         (do_set_command): ... this.  Adjust.
1459         * cli/cli-setshow.h (parse_cli_boolean_value)
1460         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1461         (parse_cli_var_enum): Declare.
1462         * cli/cli-utils.c: Include "cli/cli-option.h".
1463         (get_ulongest): New.
1464         * cli/cli-utils.h (get_ulongest): Declare.
1465         (check_for_argument): New overloads.
1466         * maint-test-options.c: New file.
1467
1468 2019-06-13  Pedro Alves  <palves@redhat.com>
1469
1470         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1471         parse a range if "-" is at the end of the string.
1472
1473 2019-06-13  Pedro Alves  <palves@redhat.com>
1474
1475         * cli/cli-setshow.c (parse_auto_binary_operation)
1476         (parse_cli_boolean_value): Don't allow "o".
1477
1478 2019-06-13  Pedro Alves  <palves@redhat.com>
1479
1480         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1481         * NEWS: Mention maint test-settings KIND.
1482         * maint-test-settings.c: New file.
1483
1484 2019-06-13  Pedro Alves  <palves@redhat.com>
1485
1486         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1487         completer.
1488         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1489         "set" completers.
1490
1491 2019-06-13  Pedro Alves  <palves@redhat.com>
1492
1493         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1494         after item.
1495
1496 2019-06-13  Pedro Alves  <palves@redhat.com>
1497
1498         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1499
1500 2019-06-13  Pedro Alves <palves@redhat.com>
1501
1502         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1503         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1504         call.
1505         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1506         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1507         calls.
1508         (check_for_argument): Skip spaces after argument.
1509
1510 2019-06-13  Pedro Alves  <palves@redhat.com>
1511
1512         * thread.c (thread_apply_command): Adjust TID parsing.
1513         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1514         detected before end of string.
1515         (tid_is_in_list): Error out if LIST is invalid.
1516
1517 2019-06-13  Pedro Alves  <palves@redhat.com>
1518
1519         * completer.c (complete_line_internal_1): Rewind completion word
1520         point.
1521         (completion_tracker::advance_custom_word_point_by): Change
1522         parameter type to int.
1523         * completer.h (completion_tracker::advance_custom_word_point_by):
1524         Likewise.
1525
1526 2019-06-13  Pedro Alves  <palves@redhat.com>
1527
1528         * completer.c (advance_to_completion_word): Handle delimiters.
1529
1530 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1531
1532         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1533
1534 2019-06-11  Tom Tromey  <tom@tromey.com>
1535
1536         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1537         (xmalloc_failed): Move to alloc.c.
1538         * alloc.c: New file.
1539         * Makefile.in (COMMON_SFILES): Add alloc.c.
1540
1541 2019-06-11  Tom Tromey  <tom@tromey.com>
1542
1543         * nat/linux-waitpid.c: Don't include server.h.
1544         (linux_debug): Remove.
1545         (my_waitpid): Update.
1546
1547 2019-06-11  Tom Tromey  <tromey@adacore.com>
1548
1549         * infcall.c (_initialize_infcall): Remove trailing newline from
1550         help.
1551         * user-regs.c (_initialize_user_regs): Remove trailing newline
1552         from help.
1553         * typeprint.c (_initialize_typeprint): Remove trailing newline
1554         from help.
1555         * reverse.c (_initialize_reverse): Remove trailing newlines from
1556         help.
1557         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1558         from help.
1559         * language.c (add_set_language_command): Remove trailing newline
1560         from help.
1561         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1562         help.
1563         * disasm.c (_initialize_disasm): Remove trailing newline from
1564         help.
1565         * top.c (init_main): Remove trailing newline from help.
1566         * interps.c (_initialize_interpreter): Remove trailing newline
1567         from help.
1568         * btrace.c (_initialize_btrace): Remove trailing newlines from
1569         help.
1570         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1571         from help.
1572         * python/python.c (_initialize_python): Remove trailing newline
1573         from help.
1574         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1575         help.
1576         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1577         from help.  Reformat some text.
1578         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1579         from help.
1580         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1581         newline from help.
1582
1583 2019-06-11  Tom Tromey  <tromey@adacore.com>
1584
1585         * darwin-nat.c (darwin_decode_exception_message)
1586         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1587
1588 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * valops.c (value_slice): Check for not allocated or not
1591         associated values.
1592
1593 2019-06-10  Tom de Vries  <tdevries@suse.de>
1594
1595         PR gdb/24618
1596         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1597         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1598         invalid.
1599
1600 2019-06-10  Tom de Vries  <tdevries@suse.de>
1601
1602         PR gdb/24611
1603         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1604         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1605
1606 2019-06-10  Tom de Vries  <tdevries@suse.de>
1607
1608         PR symtab/24545
1609         * symtab.c (struct demangled_name_entry): Add language field.
1610         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1611         static minimal symbol".  Set and use language field.
1612
1613 2019-06-10  Tom Tromey  <tromey@adacore.com>
1614
1615         * ada-lang.c (_initialize_ada_language): Update help text.
1616
1617 2019-06-10  Tom Tromey  <tromey@adacore.com>
1618
1619         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1620         with a newline.
1621         * guile/guile.c (handle_boot_error): Don't end warning with a
1622         newline.
1623         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1624         warning with a newline.
1625         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1626         newline.
1627         (s12z_frame_cache): Likewise.
1628         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1629         a newline.
1630         * solib-svr4.c (disable_probes_interface): Don't end warning with
1631         a newline.
1632         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1633         newline.
1634         * python/python.c (do_finish_initialization): Don't end warning
1635         with a newline.
1636
1637 2019-06-10  Tom Tromey  <tom@tromey.com>
1638
1639         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1640         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1641         gdbpy_enter.
1642
1643 2019-06-10  Tom Tromey  <tromey@adacore.com>
1644
1645         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1646         data.
1647         (elf_new_init): Don't call stabsread_new_init.
1648         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1649         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1650         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1651
1652 2019-06-10  Tom de Vries  <tdevries@suse.de>
1653
1654         PR symtab/16264
1655         PR symtab/24517
1656         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1657
1658 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1659
1660         * source.c (find_and_open_source): Also rewrite relative file
1661         names.
1662
1663 2019-04-26  Amos Bird  <amosbird@gmail.com>
1664
1665         * annotate.c (annotate_thread_exited): Add "thread-exited"
1666         annotation.
1667
1668 2019-06-06  Tom Tromey  <tromey@adacore.com>
1669
1670         * maint.h (class scoped_command_stats): Use
1671         DISABLE_COPY_AND_ASSIGN.
1672         <print_time>: New method.
1673         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1674         print_time.
1675         (scoped_command_stats::print_time): New method.
1676
1677 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1680         instructions of lengths 6 or 8 bytes.
1681
1682 2019-06-04  Pedro Alves  <palves@redhat.com>
1683
1684         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1685
1686         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1687         * breakpoint.c (condition_completer): Likewise.
1688         * cli/cli-dump.c (scan_expression): Likewise.
1689         * common/filestuff.c (mkdir_recursive): Likewise.
1690         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1691         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1692         (gdb_abspath): Likewise.
1693         * compile/compile-cplus-types.c
1694         (compile_cplus_instance::decl_name): Likewise.
1695         * completer.c (complete_explicit_location):
1696         (signal_completer, reg_or_group_completer_1): Likewise.
1697         * cp-support.c (cp_remove_params_if_any): Likewise.
1698         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1699         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1700         * infcmd.c (strip_bg_char): Likewise.
1701         * linespec.c (copy_token_string): Likewise.
1702         * mi/mi-main.c (output_cores): Likewise.
1703         * psymtab.c (psymtab_search_name):
1704         * symfile.c (test_set_ext_lang_command): Likewise.
1705         * target.c (target_fileio_read_stralloc): Likewise.
1706         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1707         * value.c (complete_internalvar): Likewise.
1708
1709 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1710
1711         Add objfile property to gdb.Type.
1712         * NEWS: Mention Python API addition.
1713         * python/py-type.c (typy_get_objfile): New method.
1714
1715 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1716
1717         * NEWS: Mention the new set|show style [title|highlight].
1718         Mention changes to "show style", "help" and "apropos".
1719
1720 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1721
1722         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1723         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1724         instead of print_help_for_command.
1725         (print_doc_of_command): New function.
1726         (help_list): Add 'apropos -v word' suggestion.
1727         (print_help_for_command): Style the command name using title style.
1728         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1729         (_initialize_cli_cmds): Describe -v in apropos_command help.
1730
1731 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1732
1733         * cli/cli-style.h (cli_style_option): Add name in constructor,
1734         add m_name class member, add constructor with intensity,
1735         add name class function.
1736         (cli_style_option::add_setshow_commands): Remove name argument.
1737         (highlight_style, title_style): New styles.
1738         * cli/cli-style.c (do_show): New function that shows a style
1739         characteristic styling the style name with itself.
1740         (set_style_name): New function.
1741         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1742         Update all callers according to the changes in cli/cli-style.h.
1743         * utils.h (fputs_highlighted): New function.
1744         * utils.c (fputs_highlighted): Likewise.
1745
1746 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1747
1748         * NEWS: Mention new pipe command and new convenience variables.
1749
1750 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1751
1752         * cli/cli-cmds.c (pipe_command): New function.
1753         (_initialize_cli_cmds): Call add_com for pipe_command.
1754         Define | as an alias for pipe.
1755         (exit_status_set_internal_vars): New function.
1756         (shell_escape): Call exit_status_set_internal_vars.
1757         cli/cli-decode.c (find_command_name_length): Recognize | as
1758         a single character command.
1759
1760 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1761
1762         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1763         top.c (execute_command_to_ui_file): New function, mostly a copy
1764         of execute_command_to_string.
1765         (execute_command_to_string): Implement by calling
1766         execute_command_to_ui_file.
1767
1768 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1769
1770         * top.h (saved_command_line): Remove declaration.
1771         * top.c (previous_saved_command_line, previous_repeat_arguments):
1772         New variables.
1773         (saved_command_line): Make static, define together with other
1774         'repeat variables'.
1775         (dont_repeat): Clear repeat_arguments.
1776         (repeat_previous, get_saved_command_line, save_command_line):
1777         New functions.
1778         (gdb_init): Initialize saved_command_line
1779         and previous_saved_command_line.
1780         * main.c (captured_main_1): Remove saved_command_line initialization.
1781         * event-top.c (handle_line_of_input): Update to use
1782         the new 'repeat' related functions instead of direct access to
1783         saved_command_line.
1784         * command.h (repeat_previous, get_saved_command_line,
1785         save_command_line): New declarations.
1786         (dont_repeat): Add comment.
1787
1788 2019-05-30  Tom Tromey  <tromey@adacore.com>
1789
1790         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1791         Fix comment.
1792         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1793
1794 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1795
1796         PR cli/24587
1797         * completer.c (complete): Initialize variable word.
1798
1799 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1800
1801         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1802         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1803         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1804         'body' is NULL to the outter 'if', protecting the '!is_define'
1805         situation as well.
1806
1807 2019-05-29  Tom Tromey  <tromey@adacore.com>
1808
1809         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1810         (dwarf_unknown): New function.
1811         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1812         (dwarf_type_encoding_name): Use dwarf_unknown.
1813
1814 2019-05-29  Tom Tromey  <tromey@adacore.com>
1815
1816         PR c++/20020:
1817         * cp-valprint.c (cp_print_value_fields): Call
1818         cp_print_static_field inside "try".
1819
1820 2019-05-29  Tom Tromey  <tromey@adacore.com>
1821
1822         * inflow.c (struct terminal_info): Add default operator=.
1823         * configure: Rebuild.
1824         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1825         -Wdeprecated-copy-dtor, -Wredundant-move.
1826
1827 2019-05-29  Tom Tromey  <tromey@adacore.com>
1828
1829         * NEWS: Add entry.
1830         * infcmd.c (print_return_value_1): Handle finish_print
1831         option.
1832         (show_print_finish): New function.
1833         (_initialize_infcmd): Add "set/show print finish" commands.
1834         * valprint.c (user_print_options): Initialize new member.
1835         * valprint.h (struct value_print_options) <finish_print>: New
1836         member.
1837
1838 2019-05-28  Tom Tromey  <tromey@adacore.com>
1839
1840         * ada-lang.c (ada_remove_Xbn_suffix)
1841         (find_old_style_renaming_symbol)
1842         (parse_old_style_renaming): Remove.
1843         (ada_find_renaming_symbol): Don't call
1844         find_old_style_renaming_symbol.
1845         (ada_is_renaming_symbol): Rename from
1846         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1847         bool.  Now static.
1848         (ada_read_var_value): Update and simplify.
1849         * ada-exp.y (write_var_or_type): Remove old code.
1850
1851 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1852
1853         * event-top.c: Remove include comment.
1854         * inflow.c (class scoped_ignore_sigttou): Move from here...
1855         * inflow.h (class scoped_ignore_sigttou): ...to here.
1856         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1857         * top.c:  Remove include comment.
1858
1859 2019-05-27  Tom Tromey  <tom@tromey.com>
1860
1861         * NEWS: Fix typo.
1862
1863 2019-05-22  Tom Tromey  <tromey@adacore.com>
1864
1865         * target.c (target_follow_exec): Constify parameter.
1866         * target-delegates.c: Rebuild.
1867         * remote.c (remote_target::follow_exec): Constify parameter.
1868         * infrun.c (follow_exec): Constify parameter.
1869         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1870         (target_follow_exec): Likewise.
1871
1872 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1873
1874         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1875         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1876
1877 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1878
1879         * NEWS: Add debugredirect and testsuite sections.
1880
1881 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1882
1883         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1884         target descriptions using exclusively floating point register name
1885         aliases.
1886
1887 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         PR gdb/18644:
1890         * f-lang.c (build_fortran_types): Handle the case where
1891         gdbarch_floatformat_for_type returns a nullptr.
1892
1893 2019-05-21  Tom de Vries  <tdevries@suse.de>
1894
1895         PR cli/24587
1896         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1897
1898 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         PR gdb/18644:
1901         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1902         16-byte floats.
1903         * i386-tdep.c (i386_floatformat_for_type): Use
1904         floatformats_ia64_quad for the 16-byte floating point component
1905         within a fortran 32-byte complex number.
1906
1907 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1910         delete default constructor.
1911         (find_partial_die): Update to return const struct.
1912         (partial_die_parent_scope): Move variable declaration into scope
1913         of its use and change its type to auto.
1914         (guess_partial_die_structure_name): Likewise.
1915         (partial_die_info::fixup): Likewise.
1916
1917 2019-05-17  Tom Tromey  <tromey@adacore.com>
1918
1919         * source.c (find_and_open_source): Remove cast.
1920
1921 2019-05-17  Tom Tromey  <tromey@adacore.com>
1922
1923         * annotate.c (annotate_source): Make "filename" const.
1924         * annotate.h (annotate_source): Use const.
1925
1926 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1927
1928         * disasm.c (set_disassembler_options): Send errors to stderr.
1929
1930 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1931
1932         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1933         (cli_interp_base::set_logging): Check debug_redirect.
1934         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1935         * cli/cli-logging.c (debug_redirect): Add static variable.
1936         (pop_output_files): Add default param.
1937         (handle_redirections): Print debug setting.
1938         (show_logging_command): Likewise.
1939         (_initialize_cli_logging): Add debugredirect command.
1940         * interps.c (current_interp_set_logging): Add debug_redirect
1941         parameter.
1942         * interps.h (set_logging): Add debug_redirect parameter.
1943         (current_interp_set_logging): Likewise.
1944         * mi/mi-common.h: Likewise.
1945         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1946
1947 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1948             Tom Tromey  <tromey@adacore.com>
1949
1950         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1951         directly.
1952         * cli/cli-interp.h (make_logging_output): Remove declaration.
1953         * cli/cli-logging.c (make_logging_output): Remove function.
1954         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1955         directly.
1956         * ui-file.c (tee_file::tee_file): Remove bools.
1957         (tee_file::~tee_file): Remove deletes.
1958         * ui-file.h (tee_file): Remove bools.
1959
1960 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1961
1962         * mi/mi-cmds.h (mi_cmd_complete): New function.
1963         * mi/mi-main.c (mi_cmd_complete): Likewise.
1964         * mi/mi-cmds.c: Define new MI command -complete.
1965         * NEWS: Mention new -complete command.
1966
1967 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1968
1969         * completer.h (complete): New function.
1970         * completer.c (complete): Likewise.
1971         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1972         function defined in completer.h.
1973
1974 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1975
1976         * MAINTAINERS (Write After Approval): Add myself.
1977
1978 2019-05-17  Tom de Vries  <tdevries@suse.de>
1979
1980         PR gdb/24094
1981         * dwarf2read.c (struct cu_partial_die_info): New struct.
1982         (find_partial_die): Return cu_partial_die_info.
1983         (partial_die_parent_scope, guess_partial_die_structure_name)
1984         (partial_die_info::fixup): Handle new return type of find_partial_die.
1985
1986 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1987
1988         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1989         "std::string", simplifying the algorithm.
1990
1991 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1992
1993         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1994         (stap_static_probe_ops::get_probes): Likewise.
1995
1996 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1997
1998         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1999         '-')" and "else if".
2000         (stap_parse_single_operand): Join checks for
2001         "gdbarch_stap_parse_special_token_p" and
2002         "gdbarch_stap_parse_special_token" in the same "if" statement.
2003         Invert check when verifying for operation on register
2004         displacement.
2005
2006 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2007
2008         * stap-probe.c (stap_get_opcode): Update comment.
2009         (stap_get_expected_argument_type): Likewise.
2010         (handle_stap_probe): Likewise.
2011
2012 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2013
2014         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2015         return type to 'bool'.  Adjust comment.  Use 'bool' when
2016         appropriate.
2017         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2018         * stap-probe.c (stap_parse_argument_1): Likewise.
2019         (stap_is_operator): Likewise.
2020         (stap_is_generic_prefix): Likewise.
2021         (stap_is_register_prefix): Likewise.
2022         (stap_is_register_indirection_prefix): Likewise.
2023         (stap_is_integer_prefix): Likewise.
2024         (stap_generic_check_suffix): Likewise.
2025         (stap_check_integer_suffix): Likewise.
2026         (stap_check_register_suffix): Likewise.
2027         (stap_check_register_indirection_suffix): Likewise.
2028         (stap_parse_register_operand): Likewise.
2029         (stap_parse_single_operand): Likewise.
2030         (stap_parse_argument_1): Likewise.
2031         (stap_probe::get_argument_count): Likewise.
2032         (stap_is_operator): Likewise.
2033
2034 2019-05-16  Tom Tromey  <tromey@adacore.com>
2035
2036         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2037         keyword to foreach.
2038
2039 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2040
2041         * linux-thread-db.c (try_thread_db_load_1): Change return type
2042         to bool.
2043         (try_thread_db_load): Likewise.
2044         (try_thread_db_load_from_pdir_1): Likewise.
2045         (try_thread_db_load_from_pdir): Likewise.
2046         (try_thread_db_load_from_sdir): Likewise.
2047         (try_thread_db_load_from_dir): Likewise.
2048         (thread_db_load_search): Likewise.
2049         (has_libpthread): Likewise.
2050         (thread_db_load): Likewise.
2051
2052 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2053
2054         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2055         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2056         NULL, and complain/return if that's the case.
2057
2058 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2059
2060         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2061         (advance, posn, abstract_read_memory): New functions.
2062         [struct mem_read_abstraction]: New struct.
2063         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2064
2065 2019-05-14  Tom Tromey  <tromey@adacore.com>
2066
2067         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2068         value is not lval_memory.
2069
2070 2019-05-14  Tom Tromey  <tromey@adacore.com>
2071
2072         * solib.c (info_sharedlibrary_command): Style the file name.
2073
2074 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2075
2076         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2077         (aarch64_vnv_type): Likewise.
2078         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2079         * common/tdesc.c: Likewise.
2080         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2081         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2082         * features/aarch64-fpu.xml: Add ieee half view.
2083         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2084         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2085         * gdbtypes.h (struct builtin_type): Likewise.
2086         (struct objfile_type): Likewise.
2087
2088 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2089
2090         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2091         typo.
2092         * location.h (string_to_event_location): Likewise.
2093
2094 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2095
2096         GDB 8.3 released.
2097
2098 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2099
2100         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2101         New variable declaration.
2102         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2103         New variable.
2104         (print_one_breakpoint): Use ui_out::test_flags and new global
2105         variable to compute use_fixed_output.
2106         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2107         Remove.
2108         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2109         (mi_multi_location_breakpoint_output_fixed): Remove.
2110         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2111         new variable.
2112         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2113         fix_multi_location_breakpoint_output flag if version >= 3.
2114         * ui-out.h (enum ui_out_flag)
2115         <fix_multi_location_breakpoint_output>: New enumerator.
2116
2117 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2118
2119         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2120
2121 2019-05-10  Tom Tromey  <tromey@adacore.com>
2122
2123         * ada-lang.c (catch_ada_completer): New function.
2124         (_initialize_ada_language): Use it.
2125
2126 2019-05-10  Tom Tromey  <tromey@adacore.com>
2127
2128         * thread.c (print_thread_info): Make "requested_threads" const.
2129         * gdbthread.h (print_thread_info): Make "requested_threads"
2130         const.
2131         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2132         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2133
2134 2019-05-08  Tom Tromey  <tom@tromey.com>
2135
2136         * gdbtypes.c (objfile_type_data): Change type.
2137         (objfile_type, _initialize_gdbtypes): Update.
2138
2139 2019-05-08  Tom Tromey  <tom@tromey.com>
2140
2141         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2142         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2143         (_initialize_dwarf2_frame): Update.
2144
2145 2019-05-08  Tom Tromey  <tom@tromey.com>
2146
2147         * objc-lang.c (objc_objfile_data): Change type.
2148         (find_methods): Update.
2149         (_initialize_objc_lang): Remove.
2150
2151 2019-05-08  Tom Tromey  <tom@tromey.com>
2152
2153         * stabsread.c (rs6000_builtin_type_data): Change type.
2154         (rs6000_builtin_type, _initialize_stabsread): Update.
2155
2156 2019-05-08  Tom Tromey  <tom@tromey.com>
2157
2158         * mips-tdep.c (mips_pdr_data): Remove.
2159         (_initialize_mips_tdep): Update.
2160
2161 2019-05-08  Tom Tromey  <tom@tromey.com>
2162
2163         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2164         (hppa_init_objfile_priv_data, read_unwind_info)
2165         (find_unwind_entry, _initialize_hppa_tdep): Update.
2166
2167 2019-05-08  Tom Tromey  <tom@tromey.com>
2168
2169         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2170         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2171         on obstack.
2172         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2173
2174 2019-05-08  Tom Tromey  <tom@tromey.com>
2175
2176         * mdebugread.c (basic_type_data): Change type.
2177         (basic_type, _initialize_mdebugread): Update.
2178
2179 2019-05-08  Tom Tromey  <tom@tromey.com>
2180
2181         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2182
2183 2019-05-08  Tom Tromey  <tom@tromey.com>
2184
2185         * nto-tdep.c (nto_inferior_data_reg): Change type.
2186         (nto_inferior_data): Update.
2187         (nto_inferior_data_cleanup, nto_new_inferior_data)
2188         (_initialize_nto_tdep): Remove.
2189         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2190
2191 2019-05-08  Tom Tromey  <tom@tromey.com>
2192
2193         * ada-lang.c (struct ada_inferior_data): Add initializers.
2194         (ada_inferior_data): Change type.
2195         (ada_inferior_data_cleanup): Remove.
2196         (get_ada_inferior_data, ada_inferior_exit)
2197         (struct ada_pspace_data): Add initializers, destructor.
2198         (ada_pspace_data_handle): Change type.
2199         (get_ada_pspace_data): Update.
2200         (ada_pspace_data_cleanup): Remove.
2201
2202 2019-05-08  Tom Tromey  <tom@tromey.com>
2203
2204         * coffread.c (struct coff_symfile_info): Add initializers.
2205         (coff_objfile_data_key): Move lower.  Change type.
2206         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2207         Update.
2208         (coff_free_info): Remove.
2209
2210 2019-05-08  Tom Tromey  <tom@tromey.com>
2211
2212         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2213         (fbsd_pspace_data_handle): Move lower.  Change type.
2214         (get_fbsd_pspace_data): Update.
2215         (fbsd_pspace_data_cleanup): Remove.
2216         (_initialize_fbsd_tdep): Update.
2217
2218 2019-05-08  Tom Tromey  <tom@tromey.com>
2219
2220         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2221         (get_ada_tasks_pspace_data): Update.
2222         (ada_tasks_pspace_data_cleanup): Remove.
2223         (_initialize_tasks): Update.
2224         (ada_tasks_inferior_data_handle): Change type.
2225         (get_ada_tasks_inferior_data): Update.
2226         (ada_tasks_inferior_data_cleanup): Remove.
2227         (struct ada_tasks_pspace_data): Add initializers.
2228
2229 2019-05-08  Tom Tromey  <tom@tromey.com>
2230
2231         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2232         * symfile-debug.c (debug_sym_get_probes): Change type.
2233         * stap-probe.c (handle_stap_probe):
2234         (stap_static_probe_ops::get_probes): Change type.
2235         * probe.h (class static_probe_ops) <get_probes>: Change type.
2236         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2237         (parse_probes_in_pspace): Update.
2238         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2239         Update.
2240         (any_static_probe_ops::get_probes): Change type.
2241         * elfread.c (elfread_data): New typedef.
2242         (probe_key): Change type.
2243         (elf_get_probes): Likewise.  Update.
2244         (probe_key_free): Remove.
2245         (_initialize_elfread): Update.
2246         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2247         Change type.
2248         (dtrace_process_dof_probe, dtrace_process_dof)
2249         (dtrace_static_probe_ops::get_probe): Change type.
2250
2251 2019-05-08  Tom Tromey  <tom@tromey.com>
2252
2253         * xcoffread.c (struct xcoff_symfile_info): Rename from
2254         coff_symfile_info.  Add initializers.
2255         (xcoff_objfile_data_key): Move lower.  Change type.
2256         (XCOFF_DATA): Rewrite.
2257         (xcoff_free_info): Remove.
2258         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2259         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2260         (xcoff_initial_scan): Update.
2261
2262 2019-05-08  Tom Tromey  <tom@tromey.com>
2263
2264         * solib-svr4.c (struct svr4_info): Add initializers and
2265         destructor.
2266         <probes_table>: Now an htab_up.
2267         (solib_svr4_pspace_data): Change type.
2268         (free_probes_table): Simplify.
2269         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2270         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2271         (probes_table_remove_objfile_probes, register_solib_event_probe)
2272         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2273         (_initialize_svr4_solib): Update.
2274
2275 2019-05-08  Tom Tromey  <tom@tromey.com>
2276
2277         * remote.c (remote_pspace_data): Change type.
2278         (remote_pspace_data_cleanup): Remove.
2279         (get_remote_exec_file, set_pspace_remote_exec_file)
2280         (_initialize_remote): Update.
2281
2282 2019-05-08  Tom Tromey  <tom@tromey.com>
2283
2284         * breakpoint.c (breakpoint_objfile_key): Change type.
2285         (get_breakpoint_objfile_data): Update.
2286         (free_breakpoint_objfile_data): Remove.
2287         (_initialize_breakpoint): Update.
2288
2289 2019-05-08  Tom Tromey  <tom@tromey.com>
2290
2291         * linux-tdep.c (struct linux_info): Add initializers.
2292         (linux_inferior_data): Move.  Change type.
2293         (invalidate_linux_cache_inf): Update.
2294         (linux_inferior_data_cleanup): Remove.
2295         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2296
2297 2019-05-08  Tom Tromey  <tom@tromey.com>
2298
2299         * auxv.c (auxv_inferior_data): Move.  Change type.
2300         (auxv_inferior_data_cleanup): Remove.
2301         (invalidate_auxv_cache_inf): Rewrite.
2302         (get_auxv_inferior_data, _initialize_auxv): Update.
2303
2304 2019-05-08  Tom Tromey  <tom@tromey.com>
2305
2306         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2307         (symfile_debug_objfile_data_key): Change type.
2308         (symfile_debug_installed, debug_qf_has_symbols)
2309         (debug_qf_find_last_source_symtab)
2310         (debug_qf_forget_cached_source_info)
2311         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2312         (debug_qf_print_stats, debug_qf_dump)
2313         (debug_qf_expand_symtabs_for_function)
2314         (debug_qf_expand_all_symtabs)
2315         (debug_qf_expand_symtabs_with_fullname)
2316         (debug_qf_map_matching_symbols)
2317         (debug_qf_expand_symtabs_matching)
2318         (debug_qf_find_pc_sect_compunit_symtab)
2319         (debug_qf_map_symbol_filenames)
2320         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2321         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2322         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2323         (debug_sym_read_linetable, debug_sym_relocate): Update.
2324         (symfile_debug_free_objfile): Remove.
2325         (install_symfile_debug_logging, _initialize_symfile_debug):
2326         Update.
2327
2328 2019-05-08  Tom Tromey  <tom@tromey.com>
2329
2330         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2331         allocate_on_obstack.
2332         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2333         (get_dwarf2_per_objfile): Update.
2334         (set_dwarf2_per_objfile): Remove.
2335         (dwarf2_has_info, dwarf2_get_section_info): Update.
2336         (dwarf2_free_objfile): Remove.
2337         (_initialize_dwarf2_read): Update.
2338
2339 2019-05-08  Tom Tromey  <tom@tromey.com>
2340
2341         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2342         initializers.
2343         <unsupported_script_warning_printed,
2344         script_not_found_warning_printed>: Now bool.
2345         (auto_load_pspace_data): Change type.
2346         (~auto_load_pspace_info): Rename from
2347         auto_load_pspace_data_cleanup.
2348         (get_auto_load_pspace_data, init_loaded_scripts_info)
2349         (clear_section_scripts, maybe_print_unsupported_script_warning)
2350         (maybe_print_script_not_found_warning, _initialize_auto_load):
2351         Update.
2352
2353 2019-05-08  Tom Tromey  <tom@tromey.com>
2354
2355         * objfiles.c (objfile_pspace_info): Add destructor and
2356         initializers.
2357         (objfiles_pspace_data): Change type.
2358         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2359         (get_objfile_pspace_data): Update.
2360         (objfiles_bfd_data): Change type.
2361         (get_objfile_bfd_data): Update.
2362         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2363
2364 2019-05-08  Tom Tromey  <tom@tromey.com>
2365
2366         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2367         Change type.
2368         (get_catch_syscall_inferior_data): Update.
2369         (catch_syscall_inferior_data_cleanup): Remove.
2370         (_initialize_break_catch_syscall): Update.
2371
2372 2019-05-08  Tom Tromey  <tom@tromey.com>
2373
2374         * inflow.c (struct terminal_info): Add destructor and
2375         initializers.
2376         (inflow_inferior_data): Change type.
2377         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2378         (get_inflow_inferior_data, inflow_inferior_exit)
2379         (swap_terminal_info, _initialize_inflow): Update.
2380
2381 2019-05-08  Tom Tromey  <tom@tromey.com>
2382
2383         * target-dcache.c (target_dcache_cleanup): Remove.
2384         (target_dcache_aspace_key): Change type.
2385         (target_dcache_init_p, target_dcache_invalidate)
2386         (target_dcache_get, target_dcache_get_or_init)
2387         (_initialize_target_dcache): Update.
2388         * dcache.h (struct dcache_deleter): New.
2389
2390 2019-05-08  Tom Tromey  <tom@tromey.com>
2391
2392         * symtab.c (struct symbol_cache): Add destructor and
2393         initializers.
2394         (symbol_cache_key): Move.  Change type.
2395         (make_symbol_cache, free_symbol_cache): Remove.
2396         (get_symbol_cache): Update.
2397         (symbol_cache_cleanup): Remove.
2398         (ALL_PSPACES, symbol_cache_flush)
2399         (maintenance_print_symbol_cache)
2400         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2401         Update.
2402
2403 2019-05-08  Tom Tromey  <tom@tromey.com>
2404
2405         * symtab.c (struct main_info): Add destructor and initializers.
2406         (main_progspace_key): Move.  Change type.
2407         (get_main_info): Update.
2408         (main_info_cleanup): Remove.
2409         (_initialize_symtab): Update.
2410
2411 2019-05-08  Tom Tromey  <tom@tromey.com>
2412
2413         * registry.h (DECLARE_REGISTRY): Define the _key class.
2414
2415 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * NEWS: Merge two 'New commands' sections.
2418
2419 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2420
2421         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2422         parameter and use Ada language definition instead.
2423         (ada_val_print_ptr): Remove unused language parameter.
2424         (ada_val_print_num): Remove language parameter and use Ada language
2425         definition instead.
2426         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2427         parameter.
2428         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2429         parameter and use Ada language definition instead.
2430         (ada_val_print_1): Update all ada_val_print_xxx calls.
2431         Remove language parameter.
2432         (ada_val_print): Update ada_val_print_1 call.
2433
2434 2019-05-08  Tom Tromey  <tromey@adacore.com>
2435
2436         * remote.c (remote_hw_watchpoint_limit)
2437         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2438         Now static.
2439
2440 2019-05-08  Tom Tromey  <tromey@adacore.com>
2441
2442         * maint.c (_initialize_maint_cmds): Move initialization code to
2443         remote.c.
2444         (watchdog, show_watchdog): Move to remote.c.
2445         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2446         "watchdog" static.
2447         (_initialize_remote): Move initialization code from maint.c.
2448         * defs.h (watchdog): Don't declare.
2449
2450 2019-05-08  Tom Tromey  <tromey@adacore.com>
2451
2452         * tui/tui-interp.c: Include main.h.
2453         * interps.c: Include main.h.
2454         * main.h (interpreter_p): Declare.
2455         * defs.h (interpreter_p): Don't declare.
2456
2457 2019-05-08  Tom Tromey  <tromey@adacore.com>
2458
2459         * dwarf2loc.c: Include dwarf2read.h.
2460         * defs.h (read_unsigned_leb128): Don't declare.
2461         * dwarf2read.h (read_unsigned_leb128): Declare.
2462
2463 2019-05-08  Tom Tromey  <tromey@adacore.com>
2464
2465         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2466         method.
2467
2468 2019-05-08  Tom Tromey  <tromey@adacore.com>
2469
2470         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2471         when no wrap column is set.
2472
2473 2019-05-08  Tom Tromey  <tromey@adacore.com>
2474
2475         * c-lang.c (c_get_string): Handle non-C-style arrays.
2476
2477 2019-05-08  Tom Tromey  <tromey@adacore.com>
2478
2479         * typeprint.c (print_offset_data::update): Print the bit offset,
2480         not the number of bits remaining.
2481
2482 2019-05-08  Tom Tromey  <tromey@adacore.com>
2483
2484         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2485         padding at end of comment.
2486
2487 2019-05-08  Tom Tromey  <tromey@adacore.com>
2488
2489         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2490         Compare main types.
2491
2492 2019-05-06  Tom Tromey  <tom@tromey.com>
2493
2494         * common/scoped_mmap.c: Include common-defs.h.
2495         * common/scoped_mmap.h: Don't include config.h.
2496
2497 2019-05-04  Tom Tromey  <tom@tromey.com>
2498
2499         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2500         (struct aarch64_call_info): Add initializers.
2501         <si>: Now a std::vector.
2502         (pass_on_stack, aarch64_push_dummy_call): Update.
2503
2504 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2505             Tom Tromey  <tom@tromey.com>
2506
2507         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2508         (ppc_threads): Now a std::vector.  Now static.
2509         (hwdebug_find_thread_points_by_tid)
2510         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2511         Update.
2512
2513 2019-05-04  Tom Tromey  <tom@tromey.com>
2514
2515         * arc-tdep.c (arc_tdesc_init): Return bool.
2516
2517 2019-05-04  Tom Tromey  <tom@tromey.com>
2518
2519         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2520         Use gdb_assert_not_reached.
2521
2522 2019-05-04  Tom Tromey  <tom@tromey.com>
2523
2524         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2525         "false".
2526
2527 2019-05-04  Tom Tromey  <tom@tromey.com>
2528
2529         * arc-tdep.c (arc_tdesc_init): Use bool.
2530
2531 2019-05-04  Tom Tromey  <tom@tromey.com>
2532
2533         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2534
2535 2019-05-04  Tom Tromey  <tom@tromey.com>
2536
2537         * cli/cli-cmds.c (valid_command_p): Return bool.
2538
2539 2019-05-04  Tom Tromey  <tom@tromey.com>
2540
2541         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2542         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2543
2544 2019-05-04  Raul Tambre  <raul@tambre.ee>
2545
2546         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2547         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2548         operator for comparison.
2549
2550 2019-05-04  Tom Tromey  <tom@tromey.com>
2551
2552         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2553         (lookup_partial_symbol, print_partial_symbols)
2554         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2555         (psymbol_compare): Update.
2556         (add_psymbol_to_bcache): Clear the entire psymbol.
2557         (maintenance_check_psymtabs): Update.
2558         * psympriv.h (struct partial_symbol): Don't derive from
2559         general_symbol_info.
2560         <obj_section, unrelocated_address, address,
2561         set_unrelocated_address>: Update.
2562         <ginfo>: New member.
2563         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2564         (debug_names::write_psymbols): Update.
2565
2566 2019-05-04  Tom de Vries  <tdevries@suse.de>
2567
2568         * contrib/cc-with-tweaks.sh: Support -n arg.
2569
2570 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2571
2572         * corelow.c (core_target::detach): Ensure frame cache and
2573         register caches are cleared.
2574         inferior.c (exit_inferior_1): Likewise.
2575
2576 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2577             Tom Tromey  <tom@tromey.com>
2578
2579         * dictionary.c (collate_pending_symbols_by_language): Remove
2580         "struct" from foreach.
2581         * symtab.c (lookup_global_symbol_from_objfile)
2582         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2583         foreach.
2584         * ser-tcp.c (net_open): Remove "struct" from foreach.
2585         * objfiles.c (objfile_relocate, objfile_rebase)
2586         (objfile_has_symbols): Remove "struct" from foreach.
2587         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2588         from foreach.
2589         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2590         foreach.
2591         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2592         "struct" from foreach.
2593         * ada-lang.c (create_excep_cond_exprs)
2594         (ada_exception_catchpoint_cond_string): Remove "struct" from
2595         foreach.
2596
2597 2019-05-03  Tom Tromey  <tromey@adacore.com>
2598
2599         * ada-exp.y (convert_char_literal): Check suffix of each
2600         enumerator.
2601
2602 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2603
2604         PR ada/21406:
2605         * ada-exp.y (yywrap): Don't define.
2606         * ada-lex.l (%option): Add noyywrap
2607         (yywrap): Remove.
2608
2609 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2610
2611         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2612         _WIN32_WINNT to the XP level, unless already defined to a higher
2613         level.
2614
2615         * unittests/parse-connection-spec-selftests.c:
2616         * ser-tcp.c:
2617         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2618         override.
2619
2620         * symfile.c (find_separate_debug_file): Remove colon from the
2621         drive spec of DOS/Windows file names of the target, so that the
2622         file name produced from DEBUGDIR and the target's directory will
2623         be valid on DOS/Windows systems.
2624
2625 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * rust-lang.c (val_print_struct): Handle printing structures
2628         containing strings.
2629
2630 2019-05-02  Tom Tromey  <tromey@adacore.com>
2631
2632         * valarith.c (_initialize_valarith): Remove.
2633
2634 2019-05-01  Tom Tromey  <tromey@adacore.com>
2635
2636         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2637         bitfields.
2638
2639 2019-05-01  Tom Tromey  <tromey@adacore.com>
2640
2641         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2642         for big-endian copies.
2643
2644 2019-04-30  Ali Tamur  <tamur@google.com>
2645         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2646         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2647         (read_3_bytes): New function.
2648
2649 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2650
2651         * windows-nat.c (main_thread_id): Delete.
2652         (handle_output_debug_string): Replace main_thread_id by
2653         current_event.dwThreadId.
2654         (fake_create_process): Likewise.
2655         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2656         Do not set main_thread_id.
2657         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2658         current_event.dwThreadId.
2659         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2660
2661 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2662
2663         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2664         Use current_event.dwThreadId instead of main_thread_id.
2665
2666 2019-04-30  Tom Tromey  <tromey@adacore.com>
2667
2668         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2669         (create_excep_cond_exprs): Iterate over program spaces.
2670         (ada_exception_catchpoint_cond_string): Examine all minimal
2671         symbols for exception types.
2672
2673 2019-04-30  Tom Tromey  <tromey@adacore.com>
2674
2675         PR c++/24470:
2676         * dwarf2read.c (process_structure_scope): Handle case where type
2677         has template parameters but no symbol was created.
2678
2679 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2680             Chris January  <chris.january@arm.com>
2681
2682         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2683         qualifier.
2684         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2685
2686 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * f-typeprint.c (f_print_type): Update rules for printing
2689         whitespace.
2690         (f_type_print_varspec_suffix): Likewise.
2691
2692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2693             Chris January  <chris.january@arm.com>
2694
2695         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2696         function arguments.
2697
2698 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * f-lang.c (build_fortran_types): Change name of void type to
2701         lower case.
2702         * f-typeprint.c (f_type_print_base): Print the name of the void
2703         type, rather than a fixed string.
2704         * f-valprint.c (f_decorations): Use lower case void string.
2705
2706 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2707             Chris January  <chris.january@arm.com>
2708
2709         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2710         types for Fortran.
2711
2712 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2713             Chris January  <chris.january@arm.com>
2714             David Lecomber  <david.lecomber@arm.com>
2715
2716         * f-exp.y (BINOP_INTRINSIC): New token.
2717         (exp): New parser rule handling BINOP_INTRINSIC.
2718         (f77_keywords): Add new builtin procedures.
2719         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2720         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2721         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2722         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2723         (print_unop_subexp_f): New function.
2724         (print_binop_subexp_f): New function.
2725         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2726         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2727         (dump_subexp_body_f): Likewise.
2728         (operator_check_f): Likewise.
2729         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2730         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2731
2732 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2733
2734         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2735         UNOP_KIND.
2736         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2737         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2738         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2739         (operator_length_f): New fuction.
2740         (print_subexp_f): New function.
2741         (op_name_f): New function.
2742         (dump_subexp_body_f): New function.
2743         (operator_check_f): New function.
2744         (exp_descriptor_f): Replace standard expression handling functions
2745         with new functions.
2746         * gdb/fortran-operator.def: New file.
2747         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2748         * gdb/std-operator.def: Remove UNOP_KIND.
2749
2750 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * std-operator.def: Remove unbalanced, stray double quote
2753         character.
2754
2755 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2756             Chris January  <chris.january@arm.com>
2757             Daniel Everett  <daniel.everett@arm.com>
2758             Nick Forrington  <nick.forrington@arm.com>
2759             Richard Bunt  <richard.bunt@arm.com>
2760
2761         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2762         of depth when printing anonymous structs or unions.
2763         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2764         Don't print either the top-level value, or the children if the
2765         max-depth is exceeded.
2766         (ppscm_print_children): When printing the key of a map, allow one
2767         extra level of depth.
2768         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2769         print either the top-level value, or the children if the max-depth
2770         is exceeded.
2771         (print_children): When printing the key of a map, allow one extra
2772         level of depth.
2773         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2774         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2775         (user_print_options): Initialise max_depth field.
2776         (val_print_scalar_or_string_type_p): New function.
2777         (val_print): Check to see if the max depth has been reached.
2778         (val_print_check_max_depth): Define new function.
2779         (show_print_max_depth): New function.
2780         (_initialize_valprint): Add 'print max-depth' option.
2781         * valprint.h (struct value_print_options) <max_depth>: New field.
2782         (val_print_check_max_depth): Declare new function.
2783         * NEWS: Document new feature.
2784
2785 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * ada-lang.c (ada_language_defn): Initialise new field.
2788         * c-lang.c (c_is_string_type_p): New function.
2789         (c_language_defn): Initialise new field.
2790         (cplus_language_defn): Initialise new field.
2791         (asm_language_defn): Initialise new field.
2792         (minimal_language_defn): Initialise new field.
2793         * c-lang.h (c_is_string_type_p): Declare new function.
2794         * d-lang.c (d_language_defn): Initialise new field.
2795         * f-lang.c (f_is_string_type_p): New function.
2796         (f_language_defn): Initialise new field.
2797         * go-lang.c (go_is_string_type_p): New function.
2798         (go_language_defn): Initialise new field.
2799         * language.c (default_is_string_type_p): New function.
2800         (unknown_language_defn): Initialise new field.
2801         (auto_language_defn): Initialise new field.
2802         * language.h (struct language_defn) <la_is_string_type_p>: New
2803         member variable.
2804         (default_is_string_type_p): Declare new function.
2805         * m2-lang.c (m2_language_defn): Initialise new field.
2806         * objc-lang.c (objc_language_defn): Initialise new field.
2807         * opencl-lang.c (opencl_language_defn): Initialise new field.
2808         * p-lang.c (pascal_is_string_type_p): New function.
2809         (pascal_language_defn): Initialise new field.
2810         * rust-lang.c (rust_is_string_type_p): New function.
2811         (rust_language_defn): Initialise new field.
2812
2813 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2816         New field.
2817         * ada-lang.c (ada_language_defn): Initialise new field.
2818         * c-lang.c (c_language_defn): Likewise.
2819         (cplus_language_defn): Likewise.
2820         (asm_language_defn): Likewise.
2821         (minimal_language_defn): Likewise.
2822         * d-lang.c (d_language_defn): Likewise.
2823         * f-lang.c (f_language_defn): Likewise.
2824         * go-lang.c (go_language_defn): Likewise.
2825         * language.c (unknown_language_defn): Likewise.
2826         (auto_language_defn): Likewise.
2827         * m2-lang.c (m2_language_defn): Likewise.
2828         * objc-lang.c (objc_language_defn): Likewise.
2829         * opencl-lang.c (opencl_language_defn): Likewise.
2830         * p-lang.c (pascal_language_defn): Likewise.
2831         * rust-lang.c (rust_language_defn): Likewise.
2832
2833 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * ada-lang.c (ada_is_character_type): Change return type to bool.
2836         (ada_is_string_type): Likewise.
2837         * ada-lang.h (ada_is_character_type): Update declaration
2838         (ada_is_string_type): Likewise.
2839
2840 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2841
2842         Support style in 'frame|thread apply'
2843
2844         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2845         * record.c (record_start, record_stop): Update callers of
2846         execute_command_to_string with false.
2847         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2848         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2849         methods.
2850         (class string_file): New constructor with term_out parameter.
2851         Override methods term_out and can_emit_style_escape.  New member
2852         term_out.
2853         (class stdio_file): Override can_emit_style_escape.
2854         (class tee_file): Override term_out and can_emit_style_escape.
2855         * utils.h (can_emit_style_escape): Remove.
2856         * utils.c (can_emit_style_escape): Likewise.
2857         Update all callers of can_emit_style_escape (SOMESTREAM) to
2858         SOMESTREAM->can_emit_style_escape.
2859         * source-cache.c (source_cache::get_source_lines): Likewise.
2860         * stack.c (frame_apply_command_count): Call execute_command_to_string
2861         passing the term_out characteristic of the current gdb_stdout.
2862         * thread.c (thr_try_catch_cmd): Likewise.
2863         * top.c (execute_command_to_string): pass term_out parameter
2864         to construct the string_file for the command output.
2865         * ui-file.c (term_cli_styling): New function (most code moved
2866         from utils.c can_emit_style_escape).
2867         (string_file::string_file, string_file::can_emit_style_escape,
2868         stdio_file::can_emit_style_escape, tee_file::term_out,
2869         tee_file::can_emit_style_escape): New functions.
2870
2871 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2872
2873         * NEWS: Mention the new set|show may-call-functions.
2874         * infcall.c (may_call_functions_p): New variable.
2875         (show_may_call_functions_p): New function.
2876         (call_function_by_hand_dummy): Throws an error if not
2877         may-call-functions.
2878         (_initialize_infcall): Call add_setshow_boolean_cmd for
2879         may-call-functions.
2880
2881 2019-04-25  Keith Seitz  <keiths@redhat.com>
2882
2883         PR c++/24367
2884         * cp-support.c (inspect_type): Don't attempt substitutions
2885         of symbol with the same name.
2886
2887 2019-04-25  Tom Tromey  <tromey@adacore.com>
2888
2889         PR gdb/24475:
2890         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2891         static.
2892
2893 2019-04-25  Tom Tromey  <tromey@adacore.com>
2894
2895         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2896         rvalue reference.
2897         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2898         (gdb_xml_parser::parse): Use std::move.
2899         * python/python-internal.h (gdbpy_convert_exception): Take a const
2900         reference.
2901         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2902         std::move.
2903         * python/py-utils.c (gdbpy_convert_exception): Take a const
2904         reference.
2905         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2906         Use std::move.
2907         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2908         Use std::move.
2909         * mi/mi-main.c (mi_print_exception): Take a const reference.
2910         * main.c (handle_command_errors): Take a const reference.
2911         * linespec.c (parse_linespec): Use std::move.
2912         * infcall.c (run_inferior_call): Use std::move.
2913         (call_function_by_hand_dummy): Use std::move.
2914         * exec.c (try_open_exec_file): Use std::move.
2915         * exceptions.h (exception_print, exception_fprintf)
2916         (exception_print_same): Update.
2917         * exceptions.c (print_exception, exception_print)
2918         (exception_fprintf, exception_print_same): Change parameters to
2919         const reference.
2920         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2921         * common/new-op.c: Use std::move.
2922         * common/common-exceptions.h (struct gdb_exception): Add move
2923         constructor.
2924         (struct gdb_exception_error, struct gdb_exception_quit, struct
2925         gdb_quit_bad_alloc): Change constructor to move constructor.
2926         (throw_exception): Change parameter to rvalue reference.
2927         * common/common-exceptions.c (throw_exception): Take rvalue
2928         reference.
2929         * cli/cli-interp.c (safe_execute_command): Use std::move.
2930         * breakpoint.c (insert_bp_location, location_to_sals): Use
2931         std::move.
2932
2933 2019-04-25  Tom Tromey  <tromey@adacore.com>
2934
2935         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2936         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2937         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2938         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2939         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2940         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2941         guile/scm-value.c: Use unpack.
2942         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2943         gdbscm_gdb_exception.
2944         (gdbscm_throw_gdb_exception): Likewise.
2945         (struct gdbscm_gdb_exception): New.
2946         (unpack): New function.
2947         (gdbscm_wrap): Use unpack.
2948
2949 2019-04-25  Tom Tromey  <tromey@adacore.com>
2950
2951         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2952         (gdb_rl_callback_handler): Use std::move.
2953         * common/common-exceptions.h (struct gdb_exception): Add move
2954         assignment operator.
2955         (throw_exception_sjlj): Change "exception" to const reference.
2956         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2957         (throw_exception_sjlj): Change "exception" to const reference.
2958
2959 2019-04-25  Tom Tromey  <tromey@adacore.com>
2960
2961         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2962         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2963         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2964         Update.
2965         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2966         Update.
2967         * mi/mi-interp.c (mi_interp::exec): Update.
2968         * linespec.c (parse_linespec): Update.
2969         * infcall.c (run_inferior_call): Update.
2970         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2971         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2972         (gdbscm_lookup_global_symbol): Update.
2973         * guile/scm-param.c (gdbscm_parameter_value): Update.
2974         * guile/scm-frame.c (gdbscm_frame_read_register)
2975         (gdbscm_frame_read_var): Update.
2976         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2977         * exec.c (try_open_exec_file): Update.
2978         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2979         (gdb_rl_callback_handler): Update.
2980         * common/common-exceptions.h (exception_none): Don't declare.
2981         * common/common-exceptions.c (exception_none): Don't define.
2982         (struct catcher) <exception>: Update.
2983         * cli/cli-interp.c (safe_execute_command): Update.
2984         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2985
2986 2019-04-25  Ali Tamur  <tamur@google.com>
2987
2988         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2989         (read_attribute_value): Likewise.
2990         (dwarf2_read_addr_index): Update comment.
2991         (read_str_index): Add DW_FORM_strx.
2992         (dwarf2_string_attr): Likewise.
2993         (dwarf2_const_value_attr): Likewise.
2994         (dump_die_shallow): Likewise.
2995         (dwarf2_fetch_constant_bytes): Likewise.
2996         (skip_form_bytes): Likewise.
2997         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2998
2999 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3000
3001         PR corefiles/11608
3002         PR corefiles/18187
3003         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3004         OFFSET.  Verify if current mapping contains an ELF header.
3005         (linux_find_memory_regions_full): Adjust call to
3006         dump_mapping_p.
3007
3008 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3009             Kang Li <kanglictf@gmail.com>
3010
3011         PR gdb/21600
3012
3013         * dwarf2-frame.c (read_initial_length): Be consistent about using
3014         unsigned representation of length.
3015         (decode_frame_entry_1): Likewise.  Check for wraparound of
3016         end pointer as well as buffer overflow.
3017
3018 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3019
3020         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3021         "vq".
3022
3023 2019-04-24  Tom Tromey  <tromey@adacore.com>
3024
3025         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3026
3027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * s12z-tdep.c (s12z_unwind_pc): Delete.
3030         (s12z_unwind_sp): Delete.
3031         (s12z_gdbarch_init): Don't register deleted functions with
3032         gdbarch.
3033
3034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * rl78-tdep.c (rl78_unwind_sp): Delete.
3037         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3038
3039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3042         (xstormy16_unwind_pc): Delete.
3043         (xstormy16_dummy_id): Delete.
3044         (xstormy16_gdbarch_init): Don't register deleted functions with
3045         gdbarch.
3046
3047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3048
3049         * vax-tdep.c (vax_unwind_pc): Delete.
3050         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3051
3052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * v850-tdep.c (v850_unwind_sp): Delete.
3055         (v850_unwind_pc): Delete.
3056         (v850_dummy_id): Delete.
3057         (v850_gdbarch_init): Don't register deleted functions with
3058         gdbarch.
3059
3060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3063         (tilegx_unwind_pc): Delete.
3064         (tilegx_unwind_dummy_id): Delete.
3065         (tilegx_gdbarch_init): Don't register deleted functions with
3066         gdbarch.
3067
3068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3071         (tic6x_dummy_id): Delete.
3072         (tic6x_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * sparc-tdep.c (sparc_unwind_pc): Delete.
3078         (sparc32_gdbarch_init): Don't register deleted function with
3079         gdbarch.
3080
3081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * sh-tdep.c (sh_unwind_sp): Delete.
3084         (sh_unwind_pc): Delete.
3085         (sh_dummy_id): Delete.
3086         (sh_gdbarch_init): Don't register deleted functions with
3087         gdbarch.
3088
3089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3090
3091         * score-tdep.c (score_unwind_sp): Delete.
3092         (score_unwind_pc): Delete.
3093         (score_dummy_id): Delete.
3094         (score_gdbarch_init): Don't register deleted functions with
3095         gdbarch.
3096
3097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * rx-tdep.c (rx_unwind_pc): Delete.
3100         (rx_unwind_sp): Delete.
3101         (rx_dummy_id): Delete.
3102         (rx_gdbarch_init): Don't register deleted functions with
3103         gdbarch.  Update comment.
3104
3105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3108         (rs6000_dummy_id): Delete.
3109         (rs6000_gdbarch_init): Don't register deleted functions with
3110         gdbarch.
3111
3112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         * or1k-tdep.c (or1k_dummy_id): Delete.
3115         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3116
3117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * nios2-tdep.c (nios2_dummy_id): Delete.
3120         (nios2_unwind_sp): Delete.
3121         (nios2_gdbarch_init): Don't register deleted functions with
3122         gdbarch.
3123
3124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * nds32-tdep.c (nds32_dummy_id): Delete.
3127         (nds32_unwind_pc): Delete.
3128         (nds32_unwind_sp): Delete.
3129         (nds32_gdbarch_init): Don't register deleted functions with
3130         gdbarch.
3131
3132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * msp430-tdep.c (msp430_unwind_pc): Delete.
3135         (msp430_unwind_sp): Delete.
3136         (msp430_dummy_id): Delete.
3137         (msp430_gdbarch_init): Don't register deleted functions with
3138         gdbarch.
3139
3140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * moxie-tdep.c (moxie_unwind_sp): Delete.
3143         (moxie_unwind_pc): Delete.
3144         (moxie_dummy_id): Delete.
3145         (moxie_gdbarch_init): Don't register deleted functions with
3146         gdbarch.
3147
3148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3149
3150         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3151         (mn10300_unwind_pc): Delete.
3152         (mn10300_unwind_sp): Delete.
3153         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3154         mn10300_unwind_sp.
3155         (mn10300_frame_unwind_init): Don't register deleted functions with
3156         gdbarch.
3157
3158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3159
3160         * mep-tdep.c (mep_unwind_pc): Delete.
3161         (mep_unwind_sp): Delete.
3162         (mep_dummy_id): Delete.
3163         (mep_gdbarch_init): Don't register deleted functions with
3164         gdbarch.
3165
3166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3167
3168         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3169         (m68hc11_unwind_sp): Delete.
3170         (m68hc11_gdbarch_init): Don't register deleted functions with
3171         gdbarch.
3172
3173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * m32r-tdep.c (m32r_unwind_sp): Delete.
3176         (m32r_unwind_pc): Delete.
3177         (m32r_dummy_id): Delete.
3178         (m32r_gdbarch_init): Don't register deleted functions with
3179         gdbarch.
3180
3181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3182
3183         * m32c-tdep.c (m32c_unwind_pc): Delete.
3184         (m32c_unwind_sp): Delete.
3185         (m32c_dummy_id): Delete.
3186         (m32c_gdbarch_init): Don't register deleted functions with
3187         gdbarch.
3188
3189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3192         (lm32_unwind_pc): Delete.
3193         (lm32_dummy_id): Delete.
3194         (lm32_gdbarch_init): Don't register deleted functions with
3195         gdbarch.
3196
3197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3200         (iq2000_unwind_pc): Delete.
3201         (iq2000_dummy_id): Delete.
3202         (iq2000_gdbarch_init): Don't register deleted functions with
3203         gdbarch.
3204
3205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * nds32-tdep.c (nds32_type_align): Delete.
3208         (nds32_push_dummy_call): Use type_align instead.
3209
3210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * arm-tdep.c (arm_type_align): Only handle vector override case.
3213         (arm_push_dummy_call): Use type_align.
3214         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3215
3216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3217
3218         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3219         case.
3220         (pass_on_stack): Use type_align.
3221         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3222         function.
3223
3224 2019-04-23  Tom Tromey  <tromey@adacore.com>
3225
3226         * dwarf2read.c (line_header::file_name_at): Remove unused
3227         overload.
3228
3229 2019-04-23  Tom de Vries  <tdevries@suse.de>
3230
3231         PR gdb/24438
3232         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3233         invocation.
3234
3235
3236 2019-03-27  Ali Tamur  <tamur@google.com>
3237
3238         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3239         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3240         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3241         (dwarf_expr_context::get_addr_index): Likewise
3242         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3243         (symbol_needs_eval_context::get_addr_index): Likewise
3244         (disassemble_dwarf_expression): Add DW_OP_addrx
3245         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3246         (read_cutu_die_from_dwo): Update comment
3247         (skip_one_die): Add DW_FORM_addrx
3248         (read_attribute_value): Likewise
3249         (var_decode_location): Add DW_OP_addrx
3250         (dwarf2_const_value_attr): Add DW_FORM_addrx
3251         (dump_die_shallow): Likewise
3252         (dwarf2_fetch_constant_bytes): Likewise
3253         (decode_locdesc): Add DW_OP_addrx
3254         (skip_form_bytes): Add DW_FORM_addrx
3255
3256 2019-04-22  Ali Tamur  <tamur@google.com>
3257
3258         * MAINTAINERS (Write After Approval): Add self.
3259
3260 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3261
3262         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3263         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3264         (open_symbol_file_object): Likewise.
3265         (svr4_default_sos): Add info parameter.
3266         (svr4_read_so_list): Likewise.
3267         (svr4_current_sos_direct): Adjust functions calls to pass down
3268         info.
3269         (svr4_current_sos_1): Add info parameter.
3270         (svr4_current_sos): Call get_svr4_info, pass info down to
3271         svr4_current_sos_1.
3272         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3273         get_svr4_info.
3274         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3275         get_svr4_info.
3276         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3277         to get_svr4_info.
3278         (probes_table_remove_objfile_probes): Likewise.
3279         (register_solib_event_probe): Add info parameter.
3280         (solist_update_incremental): Pass info parameter down to
3281         svr4_read_so_list.
3282         (disable_probes_interface): Add info parameter.
3283         (svr4_handle_solib_event): Pass current_program_space to
3284         get_svr4_info.  Adjust disable_probes_interface cleanup.
3285         (svr4_create_probe_breakpoints): Add info parameter, pass it
3286         down to register_solib_event_probe.
3287         (svr4_create_solib_event_breakpoints): Add info parameter,
3288         pass it down to svr4_create_probe_breakpoints.
3289         (enable_break): Pass info down to
3290         svr4_create_solib_event_breakpoints.
3291         (svr4_solib_create_inferior_hook): Pass current_program_space to
3292         get_svr4_info.
3293         (svr4_clear_solib): Likewise.
3294
3295 2019-04-22  Pedro Alves  <palves@redhat.com>
3296
3297         * solib-svr4.c (svr4_free_objfile_observer): New.
3298         (probe_and_action::objfile): New field.
3299         (probes_table_htab_remove_objfile_probes)
3300         (probes_table_remove_objfile_probes): New functions.
3301         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3302         in the new probe_and_action.  Don't store the probe in 'lookup'.
3303         (svr4_create_probe_breakpoints): Pass objfile to
3304         register_solib_event_probe.
3305         (_initialize_svr4_solib): Register a free_objfile observer.
3306
3307 2019-04-19  Tom Tromey  <tom@tromey.com>
3308
3309         * common/queue.h: Remove.
3310
3311 2019-04-19  Tom Tromey  <tom@tromey.com>
3312
3313         * event-loop.c: Don't include "common/queue.h".
3314
3315 2019-04-19  Tom Tromey  <tom@tromey.com>
3316
3317         * remote.c (remote_target): Use delete.
3318         * remote-notif.h: Include <list>, not "common/queue.h".
3319         (notif_client_p): Remove typedef.
3320         (remote_notif_state): Add constructor, destructor, initializer.
3321         <notif_queue>: Now a std::list.
3322         (remote_notif_state_xfree): Don't declare.
3323         * remote-notif.c (remote_notif_process, handle_notification)
3324         (remote_notif_state_allocate): Update.
3325         (~remote_notif_state): Rename from remote_notif_state_xfree.
3326
3327 2019-04-19  Tom Tromey  <tom@tromey.com>
3328
3329         * symfile.c (reread_symbols): Update.
3330         * objfiles.c (objfile_register_static_link)
3331         (objfile_lookup_static_link): Update
3332         (~objfile) Don't delete static_links.
3333         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3334
3335 2019-04-19  Tom Tromey  <tom@tromey.com>
3336
3337         * type-stack.h (struct type_stack) <insert>: Constify string.
3338         * type-stack.c (type_stack::insert): Constify string.
3339         * gdbtypes.h (lookup_template_type): Update.
3340         (address_space_name_to_int): Update.
3341         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3342         const.
3343         (lookup_template_type): Make name const.
3344         * c-exp.y: Update rules.
3345         (lex_one_token, classify_name, classify_inner_name)
3346         (c_print_token): Update.
3347         * p-exp.y: Update rules.
3348         (yylex): Update.
3349         * f-exp.y: Update rules.
3350         (yylex): Update.
3351         * d-exp.y: Update rules.
3352         (lex_one_token, classify_name, classify_inner_name): Update.
3353         * parse.c (write_dollar_variable, copy_name): Return std::string.
3354         * parser-defs.h (copy_name): Change return type.
3355         * m2-exp.y: Update rules.
3356         (yylex): Update.
3357         * go-exp.y (lex_one_token): Update.
3358         Update rules.
3359         (classify_unsafe_function, classify_packaged_name)
3360         (classify_name, yylex): Update.
3361
3362 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3363
3364         * configure.ac: add --enable-source-highlight switch.
3365         * configure: Regenerate.
3366         * top.c (print_gdb_version): plumb --enable-source-highlight
3367         status to "show configuration".
3368
3369 2019-04-19  Tom Tromey  <tromey@adacore.com>
3370
3371         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3372         Check ADA_TYPE_P.
3373         (empty_record, ada_template_to_fixed_record_type_1)
3374         (template_to_static_fixed_type)
3375         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3376         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3377         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3378         macros.
3379
3380 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3381
3382         PR symtab/24423:
3383         * source.c (print_source_lines_base): Advance "iter" when a
3384         control character is seen.
3385
3386 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3387
3388         * inferior.h (struct infcall_suspend_state_deleter):
3389         Catch exception in destructor to avoid crash.
3390
3391 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3392
3393         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3394         close to the add_com "shell".
3395
3396 2019-04-18  Tom Tromey  <tromey@adacore.com>
3397
3398         * process-stratum-target.h (class process_stratum_target)
3399         <stratum>: Add "final".
3400
3401 2019-04-17  Tom Tromey  <tromey@adacore.com>
3402
3403         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3404         against nullptr before use.
3405
3406 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3407
3408         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3409
3410 2019-04-17  Jim Wilson  <jimw@sifive.com>
3411             Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3414         code read might fail, assume 4-byte breakpoint in that case.
3415
3416 2019-04-15  Leszek Swirski  <leszeks@google.com>
3417
3418         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3419         rather than a hand-rolled POD check when checking for forced MEMORY
3420         classification.
3421
3422 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3423
3424         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3425         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3426         function.
3427         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3428         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3429         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3430         declaration.
3431
3432 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3433
3434         * aarch64-linux-nat.c
3435         (aarch64_linux_nat_target::thread_architecture): Add override.
3436         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3437         each VQ.
3438
3439 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3440
3441         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3442
3443 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3444
3445         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3446         target types of size 96-bits, add some additional comments, and
3447         check that the builtin type we found was the correct size.
3448
3449 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3450
3451         * utils.c (prompt_for_continue): Don't restore the styling at the
3452         end, as applied_style has the wrong value.  This fixes styling in
3453         long lists of file names that are interrupted by the "Continue?"
3454         prompt.
3455
3456 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3459         * c-lang.c (c_language_defn): Likewise.
3460         (cplus_language_defn): Likewise.
3461         (asm_language_defn): Likewise.
3462         (minimal_language_defn): Likewise.
3463         * d-lang.c (d_language_defn): Likewise.
3464         * f-lang.c (f_language_defn): Likewise.
3465         * go-lang.c (go_language_defn): Likewise.
3466         * language.c (unknown_language_defn): Likewise.
3467         (auto_language_defn): Likewise.
3468         * language.h (struct language_defn): Remove la_magic field.
3469         (LANG_MAGIC): Delete.
3470         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3471         * objc-lang.c (objc_language_defn): Likewise.
3472         * opencl-lang.c (opencl_language_defn): Likewise.
3473         * p-lang.c (pascal_language_defn): Likewise.
3474         * rust-lang.c (rust_language_defn): Likewise.
3475
3476 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3477
3478         * riscv-tdep.c (riscv_type_align): New function.
3479         (riscv_type_alignment): Delete.
3480         (riscv_arg_location): Use 'type_align'.
3481         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3482
3483 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * gdbtypes.c (type_align): A struct with no non-static fields also
3486         has alignment of 1.
3487
3488 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3491         component to 0.
3492         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3493         member.
3494         (riscv_struct_info::analyse): New implementation using new
3495         analyse_inner member function.
3496         (riscv_struct_info::field_offset): New member function.
3497         (riscv_struct_info::m_offsets): New member variable.
3498         (riscv_struct_info::analyse_inner): New private member function,
3499         takes the old implementation of riscv_struct_info::analyse but
3500         extended to track field offsets.
3501         (riscv_call_arg_struct): Update the struct folding special cases
3502         to handle cases where empty C++ structs, which are non-zero
3503         length, are found.
3504         (riscv_arg_location): Initialise the length of each location, a
3505         non-zero length now indicates the location is in use.
3506         (riscv_push_dummy_call): Allow for the first location having a
3507         non-zero offset when setting up arguments.
3508         (riscv_return_value): Likewise, but for return values.
3509
3510 2019-04-11  Tom Tromey  <tromey@adacore.com>
3511
3512         * utils.c (internal_vproblem): Make "msg" const.
3513
3514 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3517         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3518         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3519         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3520
3521 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3522
3523         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3524         function.
3525         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3526         of amd64_collect_native_gregset.
3527         (amd64_linux_nat_target::store_registers): Likewise.
3528
3529 2019-04-10  Tom Tromey  <tom@tromey.com>
3530
3531         * symtab.c (lookup_global_symbol_from_objfile)
3532         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3533         * objfiles.h (class separate_debug_iterator): New.
3534         (class separate_debug_range): New.
3535         (struct objfile) <separate_debug_objfiles>: New method.
3536         (objfile_separate_debug_iterate): Don't declare.
3537         * objfiles.c (separate_debug_iterator::operator++): Rename from
3538         objfile_separate_debug_iterate.
3539         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3540         iterator.
3541         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3542         iterator.
3543
3544 2019-04-10  Tom Tromey  <tom@tromey.com>
3545
3546         * symfile.c (reread_symbols): Remove old comment.
3547         * objfiles.c (free_all_objfiles): Fix a typo.
3548
3549 2019-04-10  Tom Tromey  <tom@tromey.com>
3550
3551         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3552         * minsyms.c (lookup_minimal_symbol): Use foreach.
3553         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3554         (lookup_minimal_symbol_solib_trampoline): Likewise.
3555         * symfile.c (reread_symbols): Use foreach.
3556
3557 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3558             Tom Tromey  <tromey@adacore.com>
3559
3560         PR rust/24414:
3561         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3562         (rust_lex_int_test): Change "value" to be LONGEST.
3563         (rust_lex_tests): Add test for long integer literal.
3564
3565 2019-04-09  Tom Tromey  <tromey@adacore.com>
3566
3567         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3568         to bool.
3569         (extended_remote_target::attach): Update.
3570         (remote_target::remote_notice_new_inferior): Update.
3571         (remote_target::add_current_inferior_and_thread): Update.
3572         * inferior.c (exit_inferior_1): Use "false".
3573         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3574
3575 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3576
3577         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3578         the "start" command.
3579
3580 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3581
3582         * python/py-inferior.c (infpy_thread_from_thread_handle):
3583         Adjust comments to reflect renaming of thread_from_thread_handle
3584         to thread_from_handle.  Adjust keywords.  Fix type error message.
3585         (inferior_object_methods): Add thread_from_handle.  Retain
3586         thread_from_thread_handle, but mark it as deprecated.
3587
3588 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3589
3590         * gdbthread.h (find_thread_by_handle): Revise declaration.
3591         * thread.c (find_thread_by_handle): Likewise.  Adjust
3592         implementation too.
3593         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3594         support for buffer objects as handles.
3595
3596 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3597
3598         * python/py-infthread.c (thpy_thread_handle): New function.
3599         (thread_object_methods): Register thpy_thread_handle.
3600
3601 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3602
3603         * gdbthread.h (thread_to_thread_handle): Declare.
3604         * thread.c (gdbtypes.h): Include.
3605         (thread_to_thread_handle): New function.
3606
3607         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3608         (target_thread_info_to_thread_handle): Declare.
3609         * target.c (target_thread_info_to_thread_handle): New function.
3610         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3611         * target-delegates.c: Regenerate.
3612
3613         * linux-thread-db.c (class thread_db_target): Add method
3614         thread_info_to_thread_handle.
3615         (thread_db_target::thread_info_to_thread_handle): Define.
3616         * remote.c (class remote_target): Add new method
3617         thread_info_to_thread_handle.
3618         (remote_target::thread_info_to_thread_handle): Define.
3619
3620 2019-04-08  Pedro Alves  <palves@redhat.com>
3621
3622         * common/common-exceptions.c (throw_exception): Don't create
3623         named object to throw; throw directly.
3624         (throw_it): Likewise.  Don't initialize gdb_exception::message
3625         here, with new; pass FMT and AP to the ctor instead.
3626         * common/common-exceptions.h: Include <string>.
3627         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3628         const char *, va_list)): New ctor.  Use std::make_shared.
3629         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3630         errors)): Delete.
3631         (gdb_exception_error::gdb_exception_error(enum errors, const char
3632         *, va_list)): New.
3633         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3634         Add assertion.
3635         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3636         errors)): Delete.
3637         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3638         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3639         Add assertion.
3640
3641 2019-04-08  Tom Tromey  <tom@tromey.com>
3642
3643         * valops.c (value_rtti_indirect_type): Replace throw_exception
3644         with throw.
3645         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3646         with throw.
3647         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3648         throw.
3649         * target.c (target_translate_tls_address): Replace throw_exception
3650         with throw.
3651         * stack.c (frame_apply_command_count): Replace throw_exception
3652         with throw.
3653         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3654         throw.
3655         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3656         with throw.
3657         * rs6000-tdep.c (rs6000_frame_cache)
3658         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3659         * remote.c: Replace throw_exception with throw.
3660         * record-full.c (record_full_message, record_full_wait_1)
3661         (record_full_restore): Replace throw_exception with throw.
3662         * record-btrace.c:
3663         (get_thread_current_frame_id, record_btrace_start_replaying)
3664         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3665         (cmd_record_btrace_start): Replace throw_exception with throw.
3666         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3667         throw.
3668         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3669         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3670         * linespec.c:
3671         (find_linespec_symbols): Replace throw_exception with throw.
3672         * infrun.c (displaced_step_prepare, resume): Replace
3673         throw_exception with throw.
3674         * infcmd.c (post_create_inferior): Replace throw_exception with
3675         throw.
3676         * inf-loop.c (inferior_event_handler): Replace throw_exception
3677         with throw.
3678         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3679         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3680         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3681         (get_prev_frame_always, get_frame_pc_if_available)
3682         (get_frame_address_in_block_if_available, get_frame_language):
3683         Replace throw_exception with throw.
3684         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3685         throw_exception with throw.
3686         * eval.c (fetch_subexp_value, evaluate_var_value)
3687         (evaluate_funcall, evaluate_subexp_standard): Replace
3688         throw_exception with throw.
3689         * dwarf2loc.c (call_site_find_chain)
3690         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3691         Replace throw_exception with throw.
3692         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3693         with throw.
3694         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3695         throw.
3696         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3697         * completer.c (complete_line_internal): Replace throw_exception
3698         with throw.
3699         * compile/compile-object-run.c (compile_object_run): Replace
3700         throw_exception with throw.
3701         * cli/cli-script.c (process_next_line): Replace throw_exception
3702         with throw.
3703         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3704         (btrace_enable, btrace_maint_update_pt_packets): Replace
3705         throw_exception with throw.
3706         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3707         throw_exception with throw.
3708         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3709         throw_exception with throw.
3710         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3711         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3712         * aarch64-tdep.c (aarch64_make_prologue_cache)
3713         (aarch64_make_stub_cache): Replace throw_exception with throw.
3714
3715 2019-04-08  Tom Tromey  <tom@tromey.com>
3716
3717         * common/common-exceptions.c (throw_exception): Rename from
3718         throw_exception_cxx.  Remove old copy.  Make argument const.
3719         (throw_it): Create and throw exception objects directly.
3720         * common/common-exceptions.h (throw_exception): Make argument
3721         const.
3722         (struct gdb_exception_error): Add constructor.
3723         (struct gdb_exception_quit): Add constructor.
3724
3725 2019-04-08  Tom Tromey  <tom@tromey.com>
3726
3727         * common/common-exceptions.h (exception_rethrow): Don't declare.
3728         (TRY_SJLJ): Update comment.
3729         (TRY, CATCH, END_CATCH): Remove.
3730         * common/common-exceptions.c (exception_rethrow): Remove.
3731
3732 2019-04-08  Tom Tromey  <tom@tromey.com>
3733
3734         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3735         Remove.
3736         (gdb_exception_error): Rename from
3737         gdb_exception_RETURN_MASK_ERROR.
3738         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3739         (gdb_quit_bad_alloc): Update.
3740         * aarch64-tdep.c: Update.
3741         * ada-lang.c: Update.
3742         * ada-typeprint.c: Update.
3743         * ada-valprint.c: Update.
3744         * amd64-tdep.c: Update.
3745         * arch-utils.c: Update.
3746         * break-catch-throw.c: Update.
3747         * breakpoint.c: Update.
3748         * btrace.c: Update.
3749         * c-varobj.c: Update.
3750         * cli/cli-cmds.c: Update.
3751         * cli/cli-interp.c: Update.
3752         * cli/cli-script.c: Update.
3753         * common/common-exceptions.c: Update.
3754         * common/new-op.c: Update.
3755         * common/selftest.c: Update.
3756         * compile/compile-c-symbols.c: Update.
3757         * compile/compile-cplus-symbols.c: Update.
3758         * compile/compile-object-load.c: Update.
3759         * compile/compile-object-run.c: Update.
3760         * completer.c: Update.
3761         * corelow.c: Update.
3762         * cp-abi.c: Update.
3763         * cp-support.c: Update.
3764         * cp-valprint.c: Update.
3765         * darwin-nat.c: Update.
3766         * disasm-selftests.c: Update.
3767         * dtrace-probe.c: Update.
3768         * dwarf-index-cache.c: Update.
3769         * dwarf-index-write.c: Update.
3770         * dwarf2-frame-tailcall.c: Update.
3771         * dwarf2-frame.c: Update.
3772         * dwarf2loc.c: Update.
3773         * dwarf2read.c: Update.
3774         * eval.c: Update.
3775         * event-loop.c: Update.
3776         * event-top.c: Update.
3777         * exec.c: Update.
3778         * f-valprint.c: Update.
3779         * fbsd-tdep.c: Update.
3780         * frame-unwind.c: Update.
3781         * frame.c: Update.
3782         * gdbtypes.c: Update.
3783         * gnu-v3-abi.c: Update.
3784         * guile/guile-internal.h: Update.
3785         * guile/scm-block.c: Update.
3786         * guile/scm-breakpoint.c: Update.
3787         * guile/scm-cmd.c: Update.
3788         * guile/scm-disasm.c: Update.
3789         * guile/scm-frame.c: Update.
3790         * guile/scm-lazy-string.c: Update.
3791         * guile/scm-math.c: Update.
3792         * guile/scm-param.c: Update.
3793         * guile/scm-ports.c: Update.
3794         * guile/scm-pretty-print.c: Update.
3795         * guile/scm-symbol.c: Update.
3796         * guile/scm-symtab.c: Update.
3797         * guile/scm-type.c: Update.
3798         * guile/scm-value.c: Update.
3799         * i386-linux-tdep.c: Update.
3800         * i386-tdep.c: Update.
3801         * inf-loop.c: Update.
3802         * infcall.c: Update.
3803         * infcmd.c: Update.
3804         * infrun.c: Update.
3805         * jit.c: Update.
3806         * language.c: Update.
3807         * linespec.c: Update.
3808         * linux-fork.c: Update.
3809         * linux-nat.c: Update.
3810         * linux-tdep.c: Update.
3811         * linux-thread-db.c: Update.
3812         * main.c: Update.
3813         * mi/mi-cmd-break.c: Update.
3814         * mi/mi-cmd-stack.c: Update.
3815         * mi/mi-interp.c: Update.
3816         * mi/mi-main.c: Update.
3817         * objc-lang.c: Update.
3818         * p-valprint.c: Update.
3819         * parse.c: Update.
3820         * ppc-linux-tdep.c: Update.
3821         * printcmd.c: Update.
3822         * python/py-arch.c: Update.
3823         * python/py-breakpoint.c: Update.
3824         * python/py-cmd.c: Update.
3825         * python/py-finishbreakpoint.c: Update.
3826         * python/py-frame.c: Update.
3827         * python/py-framefilter.c: Update.
3828         * python/py-gdb-readline.c: Update.
3829         * python/py-inferior.c: Update.
3830         * python/py-infthread.c: Update.
3831         * python/py-lazy-string.c: Update.
3832         * python/py-linetable.c: Update.
3833         * python/py-objfile.c: Update.
3834         * python/py-param.c: Update.
3835         * python/py-prettyprint.c: Update.
3836         * python/py-progspace.c: Update.
3837         * python/py-record-btrace.c: Update.
3838         * python/py-record.c: Update.
3839         * python/py-symbol.c: Update.
3840         * python/py-type.c: Update.
3841         * python/py-unwind.c: Update.
3842         * python/py-utils.c: Update.
3843         * python/py-value.c: Update.
3844         * python/python.c: Update.
3845         * record-btrace.c: Update.
3846         * record-full.c: Update.
3847         * remote-fileio.c: Update.
3848         * remote.c: Update.
3849         * riscv-tdep.c: Update.
3850         * rs6000-aix-tdep.c: Update.
3851         * rs6000-tdep.c: Update.
3852         * rust-exp.y: Update.
3853         * rust-lang.c: Update.
3854         * s390-tdep.c: Update.
3855         * selftest-arch.c: Update.
3856         * solib-dsbt.c: Update.
3857         * solib-frv.c: Update.
3858         * solib-spu.c: Update.
3859         * solib-svr4.c: Update.
3860         * solib.c: Update.
3861         * sparc64-linux-tdep.c: Update.
3862         * stack.c: Update.
3863         * symfile-mem.c: Update.
3864         * symmisc.c: Update.
3865         * target.c: Update.
3866         * thread.c: Update.
3867         * top.c: Update.
3868         * tracefile-tfile.c: Update.
3869         * tui/tui.c: Update.
3870         * typeprint.c: Update.
3871         * unittests/cli-utils-selftests.c: Update.
3872         * unittests/parse-connection-spec-selftests.c: Update.
3873         * valops.c: Update.
3874         * valprint.c: Update.
3875         * value.c: Update.
3876         * varobj.c: Update.
3877         * windows-nat.c: Update.
3878         * x86-linux-nat.c: Update.
3879         * xml-support.c: Update.
3880
3881 2019-04-08  Tom Tromey  <tom@tromey.com>
3882
3883         * xml-support.c: Use C++ exception handling.
3884         * x86-linux-nat.c: Use C++ exception handling.
3885         * windows-nat.c: Use C++ exception handling.
3886         * varobj.c: Use C++ exception handling.
3887         * value.c: Use C++ exception handling.
3888         * valprint.c: Use C++ exception handling.
3889         * valops.c: Use C++ exception handling.
3890         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3891         handling.
3892         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3893         * typeprint.c: Use C++ exception handling.
3894         * tui/tui.c: Use C++ exception handling.
3895         * tracefile-tfile.c: Use C++ exception handling.
3896         * top.c: Use C++ exception handling.
3897         * thread.c: Use C++ exception handling.
3898         * target.c: Use C++ exception handling.
3899         * symmisc.c: Use C++ exception handling.
3900         * symfile-mem.c: Use C++ exception handling.
3901         * stack.c: Use C++ exception handling.
3902         * sparc64-linux-tdep.c: Use C++ exception handling.
3903         * solib.c: Use C++ exception handling.
3904         * solib-svr4.c: Use C++ exception handling.
3905         * solib-spu.c: Use C++ exception handling.
3906         * solib-frv.c: Use C++ exception handling.
3907         * solib-dsbt.c: Use C++ exception handling.
3908         * selftest-arch.c: Use C++ exception handling.
3909         * s390-tdep.c: Use C++ exception handling.
3910         * rust-lang.c: Use C++ exception handling.
3911         * rust-exp.y: Use C++ exception handling.
3912         * rs6000-tdep.c: Use C++ exception handling.
3913         * rs6000-aix-tdep.c: Use C++ exception handling.
3914         * riscv-tdep.c: Use C++ exception handling.
3915         * remote.c: Use C++ exception handling.
3916         * remote-fileio.c: Use C++ exception handling.
3917         * record-full.c: Use C++ exception handling.
3918         * record-btrace.c: Use C++ exception handling.
3919         * python/python.c: Use C++ exception handling.
3920         * python/py-value.c: Use C++ exception handling.
3921         * python/py-utils.c: Use C++ exception handling.
3922         * python/py-unwind.c: Use C++ exception handling.
3923         * python/py-type.c: Use C++ exception handling.
3924         * python/py-symbol.c: Use C++ exception handling.
3925         * python/py-record.c: Use C++ exception handling.
3926         * python/py-record-btrace.c: Use C++ exception handling.
3927         * python/py-progspace.c: Use C++ exception handling.
3928         * python/py-prettyprint.c: Use C++ exception handling.
3929         * python/py-param.c: Use C++ exception handling.
3930         * python/py-objfile.c: Use C++ exception handling.
3931         * python/py-linetable.c: Use C++ exception handling.
3932         * python/py-lazy-string.c: Use C++ exception handling.
3933         * python/py-infthread.c: Use C++ exception handling.
3934         * python/py-inferior.c: Use C++ exception handling.
3935         * python/py-gdb-readline.c: Use C++ exception handling.
3936         * python/py-framefilter.c: Use C++ exception handling.
3937         * python/py-frame.c: Use C++ exception handling.
3938         * python/py-finishbreakpoint.c: Use C++ exception handling.
3939         * python/py-cmd.c: Use C++ exception handling.
3940         * python/py-breakpoint.c: Use C++ exception handling.
3941         * python/py-arch.c: Use C++ exception handling.
3942         * printcmd.c: Use C++ exception handling.
3943         * ppc-linux-tdep.c: Use C++ exception handling.
3944         * parse.c: Use C++ exception handling.
3945         * p-valprint.c: Use C++ exception handling.
3946         * objc-lang.c: Use C++ exception handling.
3947         * mi/mi-main.c: Use C++ exception handling.
3948         * mi/mi-interp.c: Use C++ exception handling.
3949         * mi/mi-cmd-stack.c: Use C++ exception handling.
3950         * mi/mi-cmd-break.c: Use C++ exception handling.
3951         * main.c: Use C++ exception handling.
3952         * linux-thread-db.c: Use C++ exception handling.
3953         * linux-tdep.c: Use C++ exception handling.
3954         * linux-nat.c: Use C++ exception handling.
3955         * linux-fork.c: Use C++ exception handling.
3956         * linespec.c: Use C++ exception handling.
3957         * language.c: Use C++ exception handling.
3958         * jit.c: Use C++ exception handling.
3959         * infrun.c: Use C++ exception handling.
3960         * infcmd.c: Use C++ exception handling.
3961         * infcall.c: Use C++ exception handling.
3962         * inf-loop.c: Use C++ exception handling.
3963         * i386-tdep.c: Use C++ exception handling.
3964         * i386-linux-tdep.c: Use C++ exception handling.
3965         * guile/scm-value.c: Use C++ exception handling.
3966         * guile/scm-type.c: Use C++ exception handling.
3967         * guile/scm-symtab.c: Use C++ exception handling.
3968         * guile/scm-symbol.c: Use C++ exception handling.
3969         * guile/scm-pretty-print.c: Use C++ exception handling.
3970         * guile/scm-ports.c: Use C++ exception handling.
3971         * guile/scm-param.c: Use C++ exception handling.
3972         * guile/scm-math.c: Use C++ exception handling.
3973         * guile/scm-lazy-string.c: Use C++ exception handling.
3974         * guile/scm-frame.c: Use C++ exception handling.
3975         * guile/scm-disasm.c: Use C++ exception handling.
3976         * guile/scm-cmd.c: Use C++ exception handling.
3977         * guile/scm-breakpoint.c: Use C++ exception handling.
3978         * guile/scm-block.c: Use C++ exception handling.
3979         * guile/guile-internal.h: Use C++ exception handling.
3980         * gnu-v3-abi.c: Use C++ exception handling.
3981         * gdbtypes.c: Use C++ exception handling.
3982         * frame.c: Use C++ exception handling.
3983         * frame-unwind.c: Use C++ exception handling.
3984         * fbsd-tdep.c: Use C++ exception handling.
3985         * f-valprint.c: Use C++ exception handling.
3986         * exec.c: Use C++ exception handling.
3987         * event-top.c: Use C++ exception handling.
3988         * event-loop.c: Use C++ exception handling.
3989         * eval.c: Use C++ exception handling.
3990         * dwarf2read.c: Use C++ exception handling.
3991         * dwarf2loc.c: Use C++ exception handling.
3992         * dwarf2-frame.c: Use C++ exception handling.
3993         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3994         * dwarf-index-write.c: Use C++ exception handling.
3995         * dwarf-index-cache.c: Use C++ exception handling.
3996         * dtrace-probe.c: Use C++ exception handling.
3997         * disasm-selftests.c: Use C++ exception handling.
3998         * darwin-nat.c: Use C++ exception handling.
3999         * cp-valprint.c: Use C++ exception handling.
4000         * cp-support.c: Use C++ exception handling.
4001         * cp-abi.c: Use C++ exception handling.
4002         * corelow.c: Use C++ exception handling.
4003         * completer.c: Use C++ exception handling.
4004         * compile/compile-object-run.c: Use C++ exception handling.
4005         * compile/compile-object-load.c: Use C++ exception handling.
4006         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4007         * compile/compile-c-symbols.c: Use C++ exception handling.
4008         * common/selftest.c: Use C++ exception handling.
4009         * common/new-op.c: Use C++ exception handling.
4010         * cli/cli-script.c: Use C++ exception handling.
4011         * cli/cli-interp.c: Use C++ exception handling.
4012         * cli/cli-cmds.c: Use C++ exception handling.
4013         * c-varobj.c: Use C++ exception handling.
4014         * btrace.c: Use C++ exception handling.
4015         * breakpoint.c: Use C++ exception handling.
4016         * break-catch-throw.c: Use C++ exception handling.
4017         * arch-utils.c: Use C++ exception handling.
4018         * amd64-tdep.c: Use C++ exception handling.
4019         * ada-valprint.c: Use C++ exception handling.
4020         * ada-typeprint.c: Use C++ exception handling.
4021         * ada-lang.c: Use C++ exception handling.
4022         * aarch64-tdep.c: Use C++ exception handling.
4023
4024 2019-04-08  Tom Tromey  <tom@tromey.com>
4025
4026         * xml-support.c (gdb_xml_parser::parse): Update.
4027         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4028         * value.c (show_convenience): Update.
4029         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4030         (test_parse_flags_qcs): Update.
4031         * thread.c (thr_try_catch_cmd): Update.
4032         * target.c (target_translate_tls_address): Update.
4033         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4034         (info_frame_command_core, frame_apply_command_count): Update.
4035         * rust-exp.y (rust_lex_exception_test): Update.
4036         * riscv-tdep.c (riscv_print_one_register_info): Update.
4037         * remote.c (remote_target::enable_btrace): Update.
4038         * record-btrace.c (record_btrace_enable_warn): Update.
4039         * python/py-utils.c (gdbpy_convert_exception): Update.
4040         * printcmd.c (do_one_display, print_variable_and_value): Update.
4041         * mi/mi-main.c (mi_print_exception): Update.
4042         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4043         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4044         * linux-nat.c (linux_nat_target::attach): Update.
4045         * linux-fork.c (class scoped_switch_fork_info): Update.
4046         * infrun.c (displaced_step_prepare): Update.
4047         * infcall.c (call_function_by_hand_dummy): Update.
4048         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4049         * gnu-v3-abi.c (print_one_vtable): Update.
4050         * frame.c (get_prev_frame_always): Update.
4051         * f-valprint.c (info_common_command_for_block): Update.
4052         * exec.c (try_open_exec_file): Update.
4053         * exceptions.c (print_exception, exception_print)
4054         (exception_fprintf, exception_print_same): Update.
4055         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4056         * dwarf-index-cache.c (index_cache::store)
4057         (index_cache::lookup_gdb_index): Update.
4058         * darwin-nat.c (maybe_cache_shell): Update.
4059         * cp-valprint.c (cp_print_value_fields): Update.
4060         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4061         (gcc_cplus_symbol_address): Update.
4062         * compile/compile-c-symbols.c (gcc_convert_symbol)
4063         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4064         * common/selftest.c: Update.
4065         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4066         a std::string.
4067         (exception_try_scope_entry, exception_try_scope_exit): Don't
4068         declare.
4069         (struct exception_try_scope): Remove.
4070         (TRY): Don't use exception_try_scope.
4071         (struct gdb_exception): Add constructor, operator=.
4072         <what>: New method.
4073         (struct gdb_exception_RETURN_MASK_ALL)
4074         (struct gdb_exception_RETURN_MASK_ERROR)
4075         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4076         (struct gdb_quit_bad_alloc): Update.
4077         * common/common-exceptions.c (exception_none): Change
4078         initializer.
4079         (struct catcher) <state, exception>: Initialize inline.
4080         <prev>: Remove member.
4081         (current_catcher): Remove.
4082         (catchers): New global.
4083         (exceptions_state_mc_init): Simplify.
4084         (catcher_pop): Remove.
4085         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4086         (try_scope_depth, exception_try_scope_entry)
4087         (exception_try_scope_exit): Remove.
4088         (throw_exception_sjlj): Update.
4089         (exception_messages, exception_messages_size): Remove.
4090         (throw_it): Simplify.
4091         (gdb_exception_sliced_copy): Remove.
4092         (throw_exception_cxx): Update.
4093         * cli/cli-script.c (script_from_file): Update.
4094         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4095         Update.
4096         * ada-valprint.c (ada_val_print): Update.
4097         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4098         (create_excep_cond_exprs): Update.
4099
4100 2019-04-08  Tom Tromey  <tom@tromey.com>
4101
4102         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4103         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4104         (TRY, CATCH, END_CATCH): Remove some definitions.
4105         * common/common-exceptions.c: Don't use GDB_XCPT.
4106         (catcher_list_size): Remove.
4107         (throw_exception, throw_it): Simplify.
4108
4109 2019-04-05  Tom Tromey  <tom@tromey.com>
4110
4111         Revert the header-sorting patch.
4112         * ft32-tdep.c: Revert.
4113         * frv-tdep.c: Revert.
4114         * frv-linux-tdep.c: Revert.
4115         * frame.c: Revert.
4116         * frame-unwind.c: Revert.
4117         * frame-base.c: Revert.
4118         * fork-child.c: Revert.
4119         * findvar.c: Revert.
4120         * findcmd.c: Revert.
4121         * filesystem.c: Revert.
4122         * filename-seen-cache.h: Revert.
4123         * filename-seen-cache.c: Revert.
4124         * fbsd-tdep.c: Revert.
4125         * fbsd-nat.h: Revert.
4126         * fbsd-nat.c: Revert.
4127         * f-valprint.c: Revert.
4128         * f-typeprint.c: Revert.
4129         * f-lang.c: Revert.
4130         * extension.h: Revert.
4131         * extension.c: Revert.
4132         * extension-priv.h: Revert.
4133         * expprint.c: Revert.
4134         * exec.h: Revert.
4135         * exec.c: Revert.
4136         * exceptions.c: Revert.
4137         * event-top.c: Revert.
4138         * event-loop.c: Revert.
4139         * eval.c: Revert.
4140         * elfread.c: Revert.
4141         * dwarf2read.h: Revert.
4142         * dwarf2read.c: Revert.
4143         * dwarf2loc.c: Revert.
4144         * dwarf2expr.h: Revert.
4145         * dwarf2expr.c: Revert.
4146         * dwarf2-frame.c: Revert.
4147         * dwarf2-frame-tailcall.c: Revert.
4148         * dwarf-index-write.h: Revert.
4149         * dwarf-index-write.c: Revert.
4150         * dwarf-index-common.c: Revert.
4151         * dwarf-index-cache.h: Revert.
4152         * dwarf-index-cache.c: Revert.
4153         * dummy-frame.c: Revert.
4154         * dtrace-probe.c: Revert.
4155         * disasm.h: Revert.
4156         * disasm.c: Revert.
4157         * disasm-selftests.c: Revert.
4158         * dictionary.c: Revert.
4159         * dicos-tdep.c: Revert.
4160         * demangle.c: Revert.
4161         * dcache.h: Revert.
4162         * dcache.c: Revert.
4163         * darwin-nat.h: Revert.
4164         * darwin-nat.c: Revert.
4165         * darwin-nat-info.c: Revert.
4166         * d-valprint.c: Revert.
4167         * d-namespace.c: Revert.
4168         * d-lang.c: Revert.
4169         * ctf.c: Revert.
4170         * csky-tdep.c: Revert.
4171         * csky-linux-tdep.c: Revert.
4172         * cris-tdep.c: Revert.
4173         * cris-linux-tdep.c: Revert.
4174         * cp-valprint.c: Revert.
4175         * cp-support.c: Revert.
4176         * cp-namespace.c: Revert.
4177         * cp-abi.c: Revert.
4178         * corelow.c: Revert.
4179         * corefile.c: Revert.
4180         * continuations.c: Revert.
4181         * completer.h: Revert.
4182         * completer.c: Revert.
4183         * complaints.c: Revert.
4184         * coffread.c: Revert.
4185         * coff-pe-read.c: Revert.
4186         * cli-out.h: Revert.
4187         * cli-out.c: Revert.
4188         * charset.c: Revert.
4189         * c-varobj.c: Revert.
4190         * c-valprint.c: Revert.
4191         * c-typeprint.c: Revert.
4192         * c-lang.c: Revert.
4193         * buildsym.c: Revert.
4194         * buildsym-legacy.c: Revert.
4195         * build-id.h: Revert.
4196         * build-id.c: Revert.
4197         * btrace.c: Revert.
4198         * bsd-uthread.c: Revert.
4199         * breakpoint.h: Revert.
4200         * breakpoint.c: Revert.
4201         * break-catch-throw.c: Revert.
4202         * break-catch-syscall.c: Revert.
4203         * break-catch-sig.c: Revert.
4204         * blockframe.c: Revert.
4205         * block.c: Revert.
4206         * bfin-tdep.c: Revert.
4207         * bfin-linux-tdep.c: Revert.
4208         * bfd-target.c: Revert.
4209         * bcache.c: Revert.
4210         * ax-general.c: Revert.
4211         * ax-gdb.h: Revert.
4212         * ax-gdb.c: Revert.
4213         * avr-tdep.c: Revert.
4214         * auxv.c: Revert.
4215         * auto-load.c: Revert.
4216         * arm-wince-tdep.c: Revert.
4217         * arm-tdep.c: Revert.
4218         * arm-symbian-tdep.c: Revert.
4219         * arm-pikeos-tdep.c: Revert.
4220         * arm-obsd-tdep.c: Revert.
4221         * arm-nbsd-tdep.c: Revert.
4222         * arm-nbsd-nat.c: Revert.
4223         * arm-linux-tdep.c: Revert.
4224         * arm-linux-nat.c: Revert.
4225         * arm-fbsd-tdep.c: Revert.
4226         * arm-fbsd-nat.c: Revert.
4227         * arm-bsd-tdep.c: Revert.
4228         * arch-utils.c: Revert.
4229         * arc-tdep.c: Revert.
4230         * arc-newlib-tdep.c: Revert.
4231         * annotate.h: Revert.
4232         * annotate.c: Revert.
4233         * amd64-windows-tdep.c: Revert.
4234         * amd64-windows-nat.c: Revert.
4235         * amd64-tdep.c: Revert.
4236         * amd64-sol2-tdep.c: Revert.
4237         * amd64-obsd-tdep.c: Revert.
4238         * amd64-obsd-nat.c: Revert.
4239         * amd64-nbsd-tdep.c: Revert.
4240         * amd64-nbsd-nat.c: Revert.
4241         * amd64-nat.c: Revert.
4242         * amd64-linux-tdep.c: Revert.
4243         * amd64-linux-nat.c: Revert.
4244         * amd64-fbsd-tdep.c: Revert.
4245         * amd64-fbsd-nat.c: Revert.
4246         * amd64-dicos-tdep.c: Revert.
4247         * amd64-darwin-tdep.c: Revert.
4248         * amd64-bsd-nat.c: Revert.
4249         * alpha-tdep.c: Revert.
4250         * alpha-obsd-tdep.c: Revert.
4251         * alpha-nbsd-tdep.c: Revert.
4252         * alpha-mdebug-tdep.c: Revert.
4253         * alpha-linux-tdep.c: Revert.
4254         * alpha-linux-nat.c: Revert.
4255         * alpha-bsd-tdep.c: Revert.
4256         * alpha-bsd-nat.c: Revert.
4257         * aix-thread.c: Revert.
4258         * agent.c: Revert.
4259         * addrmap.c: Revert.
4260         * ada-varobj.c: Revert.
4261         * ada-valprint.c: Revert.
4262         * ada-typeprint.c: Revert.
4263         * ada-tasks.c: Revert.
4264         * ada-lang.c: Revert.
4265         * aarch64-tdep.c: Revert.
4266         * aarch64-ravenscar-thread.c: Revert.
4267         * aarch64-newlib-tdep.c: Revert.
4268         * aarch64-linux-tdep.c: Revert.
4269         * aarch64-linux-nat.c: Revert.
4270         * aarch64-fbsd-tdep.c: Revert.
4271         * aarch64-fbsd-nat.c: Revert.
4272         * aarch32-linux-nat.c: Revert.
4273
4274 2019-04-05  Tom Tromey  <tom@tromey.com>
4275
4276         * ft32-tdep.c: Sort headers.
4277         * frv-tdep.c: Sort headers.
4278         * frv-linux-tdep.c: Sort headers.
4279         * frame.c: Sort headers.
4280         * frame-unwind.c: Sort headers.
4281         * frame-base.c: Sort headers.
4282         * fork-child.c: Sort headers.
4283         * findvar.c: Sort headers.
4284         * findcmd.c: Sort headers.
4285         * filesystem.c: Sort headers.
4286         * filename-seen-cache.h: Sort headers.
4287         * filename-seen-cache.c: Sort headers.
4288         * fbsd-tdep.c: Sort headers.
4289         * fbsd-nat.h: Sort headers.
4290         * fbsd-nat.c: Sort headers.
4291         * f-valprint.c: Sort headers.
4292         * f-typeprint.c: Sort headers.
4293         * f-lang.c: Sort headers.
4294         * extension.h: Sort headers.
4295         * extension.c: Sort headers.
4296         * extension-priv.h: Sort headers.
4297         * expprint.c: Sort headers.
4298         * exec.h: Sort headers.
4299         * exec.c: Sort headers.
4300         * exceptions.c: Sort headers.
4301         * event-top.c: Sort headers.
4302         * event-loop.c: Sort headers.
4303         * eval.c: Sort headers.
4304         * elfread.c: Sort headers.
4305         * dwarf2read.h: Sort headers.
4306         * dwarf2read.c: Sort headers.
4307         * dwarf2loc.c: Sort headers.
4308         * dwarf2expr.h: Sort headers.
4309         * dwarf2expr.c: Sort headers.
4310         * dwarf2-frame.c: Sort headers.
4311         * dwarf2-frame-tailcall.c: Sort headers.
4312         * dwarf-index-write.h: Sort headers.
4313         * dwarf-index-write.c: Sort headers.
4314         * dwarf-index-common.c: Sort headers.
4315         * dwarf-index-cache.h: Sort headers.
4316         * dwarf-index-cache.c: Sort headers.
4317         * dummy-frame.c: Sort headers.
4318         * dtrace-probe.c: Sort headers.
4319         * disasm.h: Sort headers.
4320         * disasm.c: Sort headers.
4321         * disasm-selftests.c: Sort headers.
4322         * dictionary.c: Sort headers.
4323         * dicos-tdep.c: Sort headers.
4324         * demangle.c: Sort headers.
4325         * dcache.h: Sort headers.
4326         * dcache.c: Sort headers.
4327         * darwin-nat.h: Sort headers.
4328         * darwin-nat.c: Sort headers.
4329         * darwin-nat-info.c: Sort headers.
4330         * d-valprint.c: Sort headers.
4331         * d-namespace.c: Sort headers.
4332         * d-lang.c: Sort headers.
4333         * ctf.c: Sort headers.
4334         * csky-tdep.c: Sort headers.
4335         * csky-linux-tdep.c: Sort headers.
4336         * cris-tdep.c: Sort headers.
4337         * cris-linux-tdep.c: Sort headers.
4338         * cp-valprint.c: Sort headers.
4339         * cp-support.c: Sort headers.
4340         * cp-namespace.c: Sort headers.
4341         * cp-abi.c: Sort headers.
4342         * corelow.c: Sort headers.
4343         * corefile.c: Sort headers.
4344         * continuations.c: Sort headers.
4345         * completer.h: Sort headers.
4346         * completer.c: Sort headers.
4347         * complaints.c: Sort headers.
4348         * coffread.c: Sort headers.
4349         * coff-pe-read.c: Sort headers.
4350         * cli-out.h: Sort headers.
4351         * cli-out.c: Sort headers.
4352         * charset.c: Sort headers.
4353         * c-varobj.c: Sort headers.
4354         * c-valprint.c: Sort headers.
4355         * c-typeprint.c: Sort headers.
4356         * c-lang.c: Sort headers.
4357         * buildsym.c: Sort headers.
4358         * buildsym-legacy.c: Sort headers.
4359         * build-id.h: Sort headers.
4360         * build-id.c: Sort headers.
4361         * btrace.c: Sort headers.
4362         * bsd-uthread.c: Sort headers.
4363         * breakpoint.h: Sort headers.
4364         * breakpoint.c: Sort headers.
4365         * break-catch-throw.c: Sort headers.
4366         * break-catch-syscall.c: Sort headers.
4367         * break-catch-sig.c: Sort headers.
4368         * blockframe.c: Sort headers.
4369         * block.c: Sort headers.
4370         * bfin-tdep.c: Sort headers.
4371         * bfin-linux-tdep.c: Sort headers.
4372         * bfd-target.c: Sort headers.
4373         * bcache.c: Sort headers.
4374         * ax-general.c: Sort headers.
4375         * ax-gdb.h: Sort headers.
4376         * ax-gdb.c: Sort headers.
4377         * avr-tdep.c: Sort headers.
4378         * auxv.c: Sort headers.
4379         * auto-load.c: Sort headers.
4380         * arm-wince-tdep.c: Sort headers.
4381         * arm-tdep.c: Sort headers.
4382         * arm-symbian-tdep.c: Sort headers.
4383         * arm-pikeos-tdep.c: Sort headers.
4384         * arm-obsd-tdep.c: Sort headers.
4385         * arm-nbsd-tdep.c: Sort headers.
4386         * arm-nbsd-nat.c: Sort headers.
4387         * arm-linux-tdep.c: Sort headers.
4388         * arm-linux-nat.c: Sort headers.
4389         * arm-fbsd-tdep.c: Sort headers.
4390         * arm-fbsd-nat.c: Sort headers.
4391         * arm-bsd-tdep.c: Sort headers.
4392         * arch-utils.c: Sort headers.
4393         * arc-tdep.c: Sort headers.
4394         * arc-newlib-tdep.c: Sort headers.
4395         * annotate.h: Sort headers.
4396         * annotate.c: Sort headers.
4397         * amd64-windows-tdep.c: Sort headers.
4398         * amd64-windows-nat.c: Sort headers.
4399         * amd64-tdep.c: Sort headers.
4400         * amd64-sol2-tdep.c: Sort headers.
4401         * amd64-obsd-tdep.c: Sort headers.
4402         * amd64-obsd-nat.c: Sort headers.
4403         * amd64-nbsd-tdep.c: Sort headers.
4404         * amd64-nbsd-nat.c: Sort headers.
4405         * amd64-nat.c: Sort headers.
4406         * amd64-linux-tdep.c: Sort headers.
4407         * amd64-linux-nat.c: Sort headers.
4408         * amd64-fbsd-tdep.c: Sort headers.
4409         * amd64-fbsd-nat.c: Sort headers.
4410         * amd64-dicos-tdep.c: Sort headers.
4411         * amd64-darwin-tdep.c: Sort headers.
4412         * amd64-bsd-nat.c: Sort headers.
4413         * alpha-tdep.c: Sort headers.
4414         * alpha-obsd-tdep.c: Sort headers.
4415         * alpha-nbsd-tdep.c: Sort headers.
4416         * alpha-mdebug-tdep.c: Sort headers.
4417         * alpha-linux-tdep.c: Sort headers.
4418         * alpha-linux-nat.c: Sort headers.
4419         * alpha-bsd-tdep.c: Sort headers.
4420         * alpha-bsd-nat.c: Sort headers.
4421         * aix-thread.c: Sort headers.
4422         * agent.c: Sort headers.
4423         * addrmap.c: Sort headers.
4424         * ada-varobj.c: Sort headers.
4425         * ada-valprint.c: Sort headers.
4426         * ada-typeprint.c: Sort headers.
4427         * ada-tasks.c: Sort headers.
4428         * ada-lang.c: Sort headers.
4429         * aarch64-tdep.c: Sort headers.
4430         * aarch64-ravenscar-thread.c: Sort headers.
4431         * aarch64-newlib-tdep.c: Sort headers.
4432         * aarch64-linux-tdep.c: Sort headers.
4433         * aarch64-linux-nat.c: Sort headers.
4434         * aarch64-fbsd-tdep.c: Sort headers.
4435         * aarch64-fbsd-nat.c: Sort headers.
4436         * aarch32-linux-nat.c: Sort headers.
4437
4438 2019-04-04  Tom Tromey  <tom@tromey.com>
4439
4440         * varobj.c (varobj_create): Update.
4441         * rust-exp.y (struct rust_parser) <update_innermost_block,
4442         lookup_symbol>: New methods.
4443         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4444         Rename.
4445         (rust_parser::rust_lookup_type)
4446         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4447         * printcmd.c (display_command, do_one_display): Update.
4448         * parser-defs.h (struct parser_state) <parser_state>: Add
4449         "tracker" parameter.
4450         (block_tracker): New member.
4451         (class innermost_block_tracker) <innermost_block_tracker>: Add
4452         "types" parameter.
4453         <reset>: Remove method.
4454         (innermost_block): Don't declare.
4455         (null_post_parser): Update.
4456         * parse.c (innermost_block): Remove global.
4457         (write_dollar_variable): Update.
4458         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4459         Remove "tracker_types" parameter.
4460         (parse_expression): Add "tracker" parameter.
4461         (parse_expression_for_completion): Update.
4462         (null_post_parser): Add "tracker" parameter.
4463         * p-exp.y: Update rules.
4464         * m2-exp.y: Update rules.
4465         * language.h (struct language_defn) <la_post_parser>: Add
4466         "tracker" parameter.
4467         * go-exp.y: Update rules.
4468         * f-exp.y: Update rules.
4469         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4470         parameter.
4471         * d-exp.y: Update rules.
4472         * c-exp.y: Update rules.
4473         * breakpoint.c (set_breakpoint_condition): Create an
4474         innermost_block_tracker.
4475         (watch_command_1): Likewise.
4476         * ada-lang.c (resolve): Add "tracker" parameter.
4477         (resolve_subexp): Likewise.
4478         * ada-exp.y (write_var_from_sym): Update.
4479
4480 2019-04-04  Tom Tromey  <tom@tromey.com>
4481
4482         * type-stack.h: New file.
4483         * type-stack.c: New file.
4484         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4485         type-stack.h.
4486         (insert_into_type_stack, insert_type, push_type, push_type_int)
4487         (insert_type_address_space, pop_type, pop_type_int)
4488         (pop_typelist, pop_type_stack, append_type_stack)
4489         (push_type_stack, get_type_stack, push_typelist)
4490         (follow_type_instance_flags, follow_types): Don't declare.
4491         * parse.c (type_stack): Remove global.
4492         (parse_exp_in_context): Update.
4493         (insert_into_type_stack, insert_type, push_type, push_type_int)
4494         (insert_type_address_space, pop_type, pop_type_int)
4495         (pop_typelist, pop_type_stack, append_type_stack)
4496         (push_type_stack, get_type_stack, push_typelist)
4497         (follow_type_instance_flags, follow_types): Remove (moved to
4498         type-stack.c).
4499         * f-exp.y (type_stack): New global.
4500         Update rules.
4501         (push_kind_type, f_parse): Update.
4502         * d-exp.y (type_stack): New global.
4503         Update rules.
4504         (d_parse): Update.
4505         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4506         Update rules.
4507         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4508         (HFILES_NO_SRCDIR): Add type-stack.h.
4509
4510 2019-04-04  Tom Tromey  <tom@tromey.com>
4511
4512         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4513         (rust_parser::convert_ast_to_expression, rust_parse)
4514         (rust_lex_test_completion, rust_lex_tests): Update.
4515         * parser-defs.h (struct expr_completion_state): New.
4516         (struct parser_state) <parser_state>: Add completion parameter.
4517         <mark_struct_expression, mark_completion_tag>: New methods.
4518         <parse_completion, m_completion_state>: New members.
4519         (prefixify_expression, null_post_parser): Update.
4520         (mark_struct_expression, mark_completion_tag): Don't declare.
4521         * parse.c (parse_completion, expout_last_struct)
4522         (expout_tag_completion_type, expout_completion_name): Remove
4523         globals.
4524         (parser_state::mark_struct_expression)
4525         (parser_state::mark_completion_tag): Now methods.
4526         (prefixify_expression): Add last_struct parameter.
4527         (prefixify_subexp): Likewise.
4528         (parse_exp_1): Update.
4529         (parse_exp_in_context): Add cstate parameter.  Update.
4530         (parse_expression_for_completion): Create an
4531         expr_completion_state.
4532         (null_post_parser): Add "completion" parameter.
4533         * p-exp.y: Update rules.
4534         (yylex): Update.
4535         * language.h (struct language_defn) <la_post_parser>: Add
4536         "completing" parameter.
4537         * go-exp.y: Update rules.
4538         (lex_one_token): Update.
4539         * expression.h (parse_completion): Don't declare.
4540         * d-exp.y: Update rules.
4541         (lex_one_token): Update rules.
4542         * c-exp.y: Update rules.
4543         (lex_one_token): Update.
4544         * ada-lang.c (resolve): Add "parse_completion" parameter.
4545         (resolve_subexp): Likewise.
4546         (ada_resolve_function): Likewise.
4547
4548 2019-04-04  Tom Tromey  <tom@tromey.com>
4549
4550         * parser-defs.h (struct parser_state) <start_arglist,
4551         end_arglist>: New methods.
4552         <arglist_len, m_funcall_chain>: New members.
4553         (arglist_len, start_arglist, end_arglist): Don't declare.
4554         * parse.c (arglist_len, funcall_chain): Remove global.
4555         (start_arglist, end_arglist): Remove functions.
4556         (parse_exp_in_context): Update.
4557         * p-exp.y: Update rules.
4558         * m2-exp.y: Update rules.
4559         * go-exp.y: Update rules.
4560         * f-exp.y: Update rules.
4561         * d-exp.y: Update rules.
4562         * c-exp.y: Update rules.
4563
4564 2019-04-04  Tom Tromey  <tom@tromey.com>
4565
4566         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4567         lex_operator, push_back>: New methods.
4568         Update all rules.
4569         (rust_parser::lex_hex, lex_escape): Rename and update.
4570         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4571         (rust_parser::lex_operator): Rename and update.
4572         (rust_parser::lex_number, rustyylex, rustyyerror)
4573         (rust_lex_test_init, rust_lex_test_sequence)
4574         (rust_lex_test_push_back, rust_lex_tests): Update.
4575         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4576         parameter.
4577         <lexptr, prev_lexptr>: New members.
4578         (lexptr, prev_lexptr): Don't declare.
4579         * parse.c (lexptr, prev_lexptr): Remove globals.
4580         (parse_exp_in_context): Update.
4581         * p-exp.y (yylex, yyerror): Update.
4582         * m2-exp.y (parse_number, yylex, yyerror): Update.
4583         * go-exp.y (lex_one_token, yyerror): Update.
4584         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4585         * d-exp.y (lex_one_token, yyerror): Update.
4586         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4587         (lex_one_token, yyerror): Update.
4588         * ada-lex.l (YY_INPUT): Update.
4589         (rewind_to_char): Update.
4590         * ada-exp.y (yyerror): Update.
4591
4592 2019-04-04  Tom Tromey  <tom@tromey.com>
4593
4594         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4595         * parser-defs.h (struct parser_state) <parser_state>: Add new
4596         parameter.
4597         <comma_terminates>: New member.
4598         (comma_terminates): Don't declare global.
4599         * parse.c (comma_terminates): Remove global.
4600         (parse_exp_in_context): Update.
4601         * p-exp.y (yylex): Update.
4602         * m2-exp.y (yylex): Update.
4603         * go-exp.y (lex_one_token): Update.
4604         * f-exp.y (yylex): Update.
4605         * d-exp.y (lex_one_token): Update.
4606         * c-exp.y (lex_one_token): Update.
4607         * ada-lex.l: Update.
4608
4609 2019-04-04  Tom Tromey  <tom@tromey.com>
4610
4611         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4612         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4613         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4614         * parser-defs.h (paren_depth): Don't declare.
4615         * parse.c (paren_depth): Remove global.
4616         (parse_exp_in_context): Update.
4617         * p-exp.y (paren_depth): New global.
4618         (pascal_parse): Initialize it.
4619         * m2-exp.y (paren_depth): New global.
4620         (m2_parse): Initialize it.
4621         * go-exp.y (paren_depth): New global.
4622         (go_parse): Initialize it.
4623         * f-exp.y (paren_depth): New global.
4624         (f_parse): Initialize it.
4625         * d-exp.y (paren_depth): New global.
4626         (d_parse): Initialize it.
4627         * c-exp.y (paren_depth): New global.
4628         (c_parse): Initialize it.
4629         * ada-lex.l (paren_depth): New global.
4630         (lexer_init): Initialize it.
4631
4632 2019-04-04  Tom Tromey  <tom@tromey.com>
4633
4634         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4635         (rust_parser::convert_ast_to_type)
4636         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4637         * parser-defs.h (struct parser_state) <parser_state>: Add
4638         parameters.  Initialize new members.
4639         <expression_context_block, expression_context_pc>: New members.
4640         * parse.c (expression_context_block, expression_context_pc):
4641         Remove globals.
4642         (parse_exp_in_context): Update.
4643         * p-exp.y: Update all rules.
4644         (yylex): Update.
4645         * m2-exp.y: Update all rules.
4646         (yylex): Update.
4647         * go-exp.y (yylex): Update.
4648         * f-exp.y (yylex): Update.
4649         * d-exp.y: Update all rules.
4650         (yylex): Update.
4651         * c-exp.y: Update all rules.
4652         (lex_one_token, classify_name, yylex, c_parse): Update.
4653         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4654
4655 2019-04-04  Tom Tromey  <tom@tromey.com>
4656
4657         * gdbarch.h, gdbarch.c: Rebuild.
4658         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4659         * stap-probe.h:
4660         (struct stap_parse_info): Replace "parser_state" with
4661         "expr_builder".
4662         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4663         (parser_state): New class.
4664         * parse.c (expr_builder): Rename.
4665         (expr_builder::release): Rename.
4666         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4667         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4668         (write_exp_elt_longcst, write_exp_elt_floatcst)
4669         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4670         (write_exp_string_vector, write_exp_bitstring)
4671         (write_exp_msymbol, mark_struct_expression)
4672         (write_dollar_variable)
4673         (insert_type_address_space, increase_expout_size): Replace
4674         "parser_state" with "expr_builder".
4675         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4676         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4677         "parser_state" with "expr_builder".
4678
4679 2019-04-04  Tom Tromey  <tom@tromey.com>
4680
4681         * rust-exp.y: Replace "parse_language" with method call.
4682         * p-exp.y:
4683         (yylex): Replace "parse_language" with method call.
4684         * m2-exp.y:
4685         (yylex): Replace "parse_language" with method call.
4686         * go-exp.y (classify_name): Replace "parse_language" with method
4687         call.
4688         * f-exp.y (yylex): Replace "parse_language" with method call.
4689         * d-exp.y (lex_one_token): Replace "parse_language" with method
4690         call.
4691         * c-exp.y:
4692         (lex_one_token, classify_name, yylex): Replace "parse_language"
4693         with method call.
4694         * ada-exp.y (find_primitive_type, type_char)
4695         (type_system_address): Replace "parse_language" with method call.
4696
4697 2019-04-04  Tom Tromey  <tom@tromey.com>
4698
4699         * rust-exp.y: Replace "parse_gdbarch" with method call.
4700         * parse.c (write_dollar_variable, insert_type_address_space):
4701         Replace "parse_gdbarch" with method call.
4702         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4703         call.
4704         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4705         call.
4706         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4707         "parse_gdbarch" with method call.
4708         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4709         with method call.
4710         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4711         "parse_gdbarch" with method call.
4712         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4713         "parse_gdbarch" with method call.
4714         * c-exp.y (parse_type, parse_number, classify_name): Replace
4715         "parse_gdbarch" with method call.
4716         * ada-lex.l: Replace "parse_gdbarch" with method call.
4717         * ada-exp.y (parse_type, find_primitive_type, type_char)
4718         (type_system_address): Replace "parse_gdbarch" with method call.
4719
4720 2019-04-04  Tom Tromey  <tom@tromey.com>
4721
4722         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4723         * stap-probe.c (stap_parse_argument): Update.
4724         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4725         initial_size parameter.
4726         * rust-exp.y (rust_lex_tests): Update.
4727         * parse.c (parser_state): Update.
4728         (parse_exp_in_context): Update.
4729         * parser-defs.h (struct parser_state) <parser_state>: Remove
4730         "initial_size" parameter.
4731
4732 2019-04-04  Tom Tromey  <tom@tromey.com>
4733
4734         * parser-defs.h (increase_expout_size): Don't declare.
4735         * parse.c (increase_expout_size): Now static.
4736
4737 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4738
4739         * gnu-nat.c (gnu_nat_target::wait): Fix
4740         target_waitstatus_to_string call.
4741
4742 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * eval.c (evaluate_subexp_standard): Handle internal functions
4745         during Fortran function call handling.
4746
4747 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * NEWS: Mention new internal functions.
4750         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4751         (read_base_type): Use dwarf2_init_complex_target_type.
4752         * value.c (creal_internal_fn): New function.
4753         (cimag_internal_fn): New function.
4754         (_initialize_values): Register new internal functions.
4755
4756 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4757
4758         * infrun.c (stop_all_threads): If debug_infrun, always
4759         trace the wait status after wait_one, using
4760         target_waitstatus_to_string and target_pid_to_str.
4761         (handle_inferior_event): Replace various trace of
4762         wait status kind by a single trace.
4763         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4764         wait status kind image by target_waitstatus_to_string.
4765         * target/waitstatus.c (target_waitstatus_to_string): Fix
4766         obsolete comment.
4767
4768 2019-04-01  Tom Tromey  <tromey@adacore.com>
4769
4770         PR symtab/23331:
4771         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4772
4773 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4774             Pedro Alves  <palves@redhat.com>
4775
4776         * top.c (quit_force): Call 'finalize_values'.
4777         * value.c (finalize_values): New function.
4778         * value.h (finalize_values): Declare.
4779
4780 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4781
4782         * NEWS: Announce $_gdb_major and $_gdb_minor.
4783
4784         * top.c (init_gdb_version_vars): New function.
4785         (gdb_init): Call init_gdb_version_vars.
4786
4787 2019-03-29  Tom Tromey  <tromey@adacore.com>
4788
4789         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4790         help text.  Remove dead code.
4791
4792 2019-03-29  Keith Seitz  <keiths@redhat.com>
4793
4794         From Siddhesh Poyarekar:
4795         * f-lang.h (f77_get_upperbound): Return LONGEST.
4796         (f77_get_lowerbound): Likewise.
4797         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4798         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4799         print them.
4800         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4801         plongest to format print it.
4802         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4803         (f77_get_upperbound): Likewise.
4804         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4805         LOWER_BOUND to LONGEST.
4806         (f77_create_arrayprint_offset_tbl): Likewise.
4807
4808 2019-03-29  Keith Seitz  <keiths@redhat.com>
4809
4810         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4811         %s/pulongest for TYPE_LENGTH instead of %d in format
4812         strings.
4813         * ada-typerint.c (ada_print_type): Likewise.
4814         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4815         * compile/compile-c-support.c (generate_register_struct): Likewise.
4816         * gdbtypes.c (recursive_dump_type): Likewise.
4817         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4818         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4819         instead of %d in format strings.
4820         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4821         to std::min to ULONGEST.
4822         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4823         instead of %d in format strings.
4824         * tracepoint.c (info_scope_command): Likewise.
4825         * typeprint.c (print_offset_data::update)
4826         (print_offset_data::finish): Likewise.
4827         * xtensa-tdep.c (xtensa_store_return_value)
4828         (xtensa_push_dummy_call): Likewise.
4829
4830 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4831
4832         * windows-nat.c (display_selector): Fixed format specifications
4833         for 64-bit Cygwin.
4834
4835 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4838
4839 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4840
4841         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4842         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4843         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4844         (nios2_linux_init_abi): Install it.
4845
4846 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4847
4848         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4849
4850 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4851
4852         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4853
4854 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4855             Tom Tromey  <tromey@adacore.com>
4856
4857         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4858
4859 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4860
4861         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4862         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4863         method to compute the bounds of range types. Also print "[evaluated]"
4864         if the bounds' values come from a dynamic evaluation.
4865
4866 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4869         whitespace when pretty printing is on.
4870
4871 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4872
4873         * ppc-linux-nat.c: Add include.
4874
4875 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4876
4877         * NEWS: Mention AArch64 Pointer Authentication.
4878
4879 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4880
4881         * arm-linux-nat.c: Add include.
4882
4883 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4884
4885         * source-cache.c (source_cache::get_source_lines): Re-read
4886         fullname after calling open_source_file.
4887
4888 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4889
4890         * NEWS: Mention TLS support for FreeBSD.
4891
4892 2019-03-25  Tom Tromey  <tromey@adacore.com>
4893
4894         * minsyms.c (BUNCH_SIZE): Update comment.
4895         (~minimal_symbol_reader): Remove old comment.
4896         (compact_minimal_symbols): Update comment.
4897         (minimal_symbol_reader::install): Remove old comment.  Update
4898         other comments.
4899
4900 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4901
4902         * s390-linux-nat.c: Add include.
4903
4904 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4905
4906         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4907         Call linux_get_hwcap.
4908         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4909         Likewise.
4910         (aarch64_linux_get_hwcap): Remove function.
4911         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4912         declaration.
4913         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4914         linux_get_hwcap.
4915         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4916         * linux-tdep.c (linux_get_hwcap): Add function.
4917         (linux_get_hwcap2): Likewise.
4918         * linux-tdep.h (linux_get_hwcap): Add declaration.
4919         (linux_get_hwcap2): Likewise.
4920         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4921         (ppc_linux_get_hwcap2): Likewise.
4922         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4923         linux_get_hwcap.
4924         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4925         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4926         (ppc_linux_nat_target::read_description): Likewise.
4927         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4928         * s390-linux-nat.c: Likewise.
4929         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4930
4931 2019-03-24  Tom Tromey  <tom@tromey.com>
4932
4933         * ada-lang.c (standard_lookup): Simplify initialization.
4934         (ada_lookup_symbol_nonlocal): Simplify return.
4935         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4936         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4937         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4938         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4939         initialization.
4940         * solib.c (solib_global_lookup): Simplify.
4941         * symtab.c (null_block_symbol): Remove.
4942         (symbol_cache_lookup): Simplify returns.
4943         (lookup_language_this): Simplify returns.
4944         (lookup_symbol_aux): Simplify return.
4945         (lookup_local_symbol): Simplify returns.
4946         (lookup_global_symbol_from_objfile): Simplify return.
4947         (lookup_symbol_in_objfile_symtabs)
4948         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4949         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4950         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4951         * cp-namespace.c (cp_lookup_bare_symbol)
4952         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4953         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4954         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4955         (cp_lookup_symbol_via_imports): Simplify initialization.
4956         (find_symbol_in_baseclass): Likewise.
4957         * symtab.h (null_block_symbol): Remove.
4958         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4959         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4960         (d_lookup_symbol_module): Likewise.
4961         (find_symbol_in_baseclass): Simplify initialization.
4962
4963 2019-03-24  Tom Tromey  <tom@tromey.com>
4964
4965         * expression.h: Don't include symtab.h.
4966         (struct block): Forward declare.
4967
4968 2019-03-24  Tom Tromey  <tom@tromey.com>
4969
4970         * c-exp.y (typebase): Remove casts.
4971         * gdbtypes.c (lookup_unsigned_typename, )
4972         (lookup_signed_typename): Remove cast.
4973         * eval.c (parse_to_comma_and_eval): Remove cast.
4974         * parse.c (write_dollar_variable): Remove cast.
4975         * block.h (struct block) <superblock>: Now const.
4976         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4977         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4978         (map_block): Make "block" const.
4979         * symfile.h (struct quick_symbol_functions)
4980         <map_matching_symbols>: Constify block argument to "callback".
4981         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4982         const.
4983         (find_pc_sect_compunit_symtab): Make "b" const.
4984         (find_symbol_at_address): Likewise.
4985         (search_symbols): Likewise.
4986         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4987         (dw2_debug_names_lookup_symbol): Likewise.
4988         (dw2_map_matching_symbols): Update.
4989         * p-valprint.c (pascal_val_print): Remove "block".
4990         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4991         (aux_add_nonlocal_symbols): Make "block" const.
4992         (resolve_subexp): Remove cast.
4993         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4994         const.
4995         (iterate_over_file_blocks): Likewise.
4996         * f-exp.y (%union) <bval>: Remove.
4997         * coffread.c (patch_opaque_types): Make "b" const.
4998         * spu-tdep.c (spu_catch_start): Make "block" const.
4999         * c-valprint.c (print_unpacked_pointer): Remove "block".
5000         * symmisc.c (dump_symtab_1): Make "b" const.
5001         (block_depth): Make "block" const.
5002         * d-exp.y (%union) <bval>: Remove.
5003         * cp-support.h (cp_lookup_rtti_type): Update.
5004         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5005         * psymtab.c (psym_lookup_symbol): Make "block" const.
5006         (maintenance_check_psymtabs): Make "b" const.
5007         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5008         (enumerate_locals, enumerate_args): Update.
5009         * python/py-symtab.c (stpy_global_block): Make "block" const.
5010         (stpy_static_block): Likewise.
5011         * inline-frame.c (block_starting_point_at): Make "new_block"
5012         const.
5013         * block.c (find_block_in_blockvector): Make return type const.
5014         (blockvector_for_pc_sect): Make "b" const.
5015         (find_block_in_blockvector): Make "b" const.
5016
5017 2019-03-23  Tom Tromey  <tom@tromey.com>
5018
5019         * varobj.c (varobj_create): Update.
5020         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5021         * printcmd.c (display_command, do_one_display): Don't reset
5022         innermost_block.
5023         * parser-defs.h (enum innermost_block_tracker_type): Move to
5024         expression.h.
5025         (innermost_block): Update comment.
5026         * parse.c (parse_exp_1): Add tracker_types parameter.
5027         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5028         tracker_types parameter.  Reset innermost_block.
5029         (parse_exp_in_context): Remove.
5030         (parse_expression_for_completion): Update.
5031         * objfiles.c (~objfile): Don't reset expression_context_block or
5032         innermost_block.
5033         * expression.h (enum innermost_block_tracker_type): Move from
5034         parser-defs.h.
5035         (parse_exp_1): Add tracker_types parameter.
5036         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5037         reset innermost_block.
5038
5039 2019-03-23  Tom Tromey  <tom@tromey.com>
5040
5041         * objfiles.h: Include bcache.h.
5042
5043 2019-03-23  Tom Tromey  <tom@tromey.com>
5044
5045         * linespec.c (get_current_search_block): Use
5046         scoped_restore_current_language.
5047         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5048
5049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5050             Jiong Wang  <jiong.wang@arm.com>
5051
5052         * aarch64-linux-tdep.c
5053         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5054         section.
5055         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5056
5057 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5058             Jiong Wang  <jiong.wang@arm.com>
5059
5060         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5061         instructions.
5062         (aarch64_analyze_prologue_test): Add PACIASP test.
5063         (aarch64_prologue_prev_register): Unmask PC value.
5064
5065 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5066             Jiong Wang  <jiong.wang@arm.com>
5067
5068         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5069         (aarch64_dwarf2_prev_register): Unmask PC value.
5070         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5071         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5072         DW_CFA_AARCH64_negate_ra_state.
5073         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5074
5075 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5076             Jiong Wang  <jiong.wang@arm.com>
5077
5078         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5079         registers.
5080         (aarch64_pseudo_register_name): Likewise.
5081         (aarch64_pseudo_register_type): Likewise.
5082         (aarch64_pseudo_register_reggroup_p): Likewise.
5083         (aarch64_gdbarch_init): Add pauth registers.
5084         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5085         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5086         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5087         (struct gdbarch_tdep): Add regnum for ra_state.
5088
5089 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5090             Jiong Wang  <jiong.wang@arm.com>
5091
5092         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5093
5094 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5095             Jiong Wang  <jiong.wang@arm.com>
5096
5097         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5098         function.
5099         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5100         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5101         (aarch64_gdbarch_init): Add puth registers.
5102         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5103         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5104         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5105
5106 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5107             Jiong Wang  <jiong.wang@arm.com>
5108
5109         * aarch64-linux-nat.c
5110         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5111         * aarch64-linux-tdep.c
5112         (aarch64_linux_core_read_description): Likewise.
5113         (aarch64_linux_get_hwcap): New function.
5114         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5115         (aarch64_linux_get_hwcap): New declaration.
5116
5117 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5118             Jiong Wang  <jiong.wang@arm.com>
5119
5120         * aarch64-linux-nat.c
5121         (aarch64_linux_nat_target::read_description): Add pauth param.
5122         * aarch64-linux-tdep.c
5123         (aarch64_linux_core_read_description): Likewise.
5124         * aarch64-tdep.c (struct target_desc): Add in pauth.
5125         (aarch64_read_description): Add pauth param.
5126         (aarch64_gdbarch_init): Likewise.
5127         * aarch64-tdep.h (aarch64_read_description): Likewise.
5128         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5129         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5130         * features/Makefile: Add new files.
5131         * features/aarch64-pauth.c: New file.
5132         * features/aarch64-pauth.xml: New file.
5133
5134 2019-03-20  Tom Tromey  <tromey@adacore.com>
5135
5136         * infrun.c (handle_inferior_event): Rename from
5137         handle_inferior_event_1.  Create a scoped_value_mark.
5138         (handle_inferior_event): Remove.
5139
5140 2019-03-19  Tom Tromey  <tromey@adacore.com>
5141
5142         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5143         * infrun.h (print_stop_event): Add "displays" parameter.
5144         * infrun.c (print_stop_event): Add "displays" parameter.
5145
5146 2019-03-19  Pedro Alves  <palves@redhat.com>
5147
5148         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5149         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5150         to -1.  Fix TABs vs spaces.
5151         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5152         * tui/tui-out.h (tui_ui_out) Add intro comments.
5153         <m_line, m_start_of_line>: In-class initialize, and add describing
5154         comment.
5155
5156 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5157
5158         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5159         variable names.
5160         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5161
5162 2019-03-18  Pedro Alves  <palves@redhat.com>
5163             Eli Zaretskii <eliz@gnu.org>
5164
5165         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5166         m_line and m_start_of_line.
5167
5168 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5169
5170         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5171         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5172         it returns a newline.  This fixes a regression in TU mode, whereby
5173         the next line is output on the same screen line as the user input.
5174
5175 2019-03-18  Tom Tromey  <tromey@adacore.com>
5176
5177         * minsyms.c (minimal_symbol_reader::install): Remove call to
5178         obstack_blank.
5179
5180 2019-03-18  Pedro Alves  <palves@redhat.com>
5181
5182         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5183         New globals.
5184         (apply_style): New, factored out from ...
5185         (apply_ansi_escape): ... this.  Handle reverse video mode.
5186         (tui_set_reverse_mode): New function.
5187         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5188         * tui/tui-winsource.c (tui_show_source_line): Use
5189         tui_set_reverse_mode instead of setting A_STANDOUT.
5190         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5191         New setter methods.
5192
5193 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5194
5195         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5196         Handle tabs.
5197
5198 2019-03-18  Tom Tromey  <tromey@adacore.com>
5199
5200         * ada-lang.c (empty_array): Add "high" parameter.
5201         (ada_evaluate_subexp): Update.
5202
5203 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5204
5205         * unittests/string_view-selftests.c: Define
5206         _initialize_string_view_selftests unconditionally.
5207
5208 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5209
5210         PR gdb/24350
5211         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5212
5213 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5214
5215         PR gdb/24351
5216         * windows-nat.c (display_selector): Fix format specifiers.
5217
5218 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5219
5220         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5221         tui_refill_source_window instead of tui_refresh_win, to update the
5222         current execution line.  This fixes redisplay of the current line
5223         when stepping through the code with "next" or "step".
5224
5225 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5226
5227         * source-cache.c (source_cache::get_source_lines): Call
5228         find_source_lines to initialize s->nlines.  This fixes vertical
5229         scrolling of TUI source window when the DOWN arrow is pressed.
5230
5231 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5232
5233         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5234         linux-thread-db.c (_initialize_thread_db): Likewise.
5235
5236 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5237
5238         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5239         wclrtoeol in tui_show_source_line".  This reverts changes made in
5240         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5241
5242 2019-03-15  Tom Tromey  <tom@tromey.com>
5243
5244         * symtab.h (struct minimal_symbol): Derive from
5245         general_symbol_info.
5246         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5247         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5248         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5249         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5250         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5251         (MSYMBOL_SEARCH_NAME): Update.
5252         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5253         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5254         * minsyms.c (minimal_symbol_reader::record_full): Update.
5255
5256 2019-03-15  Tom Tromey  <tom@tromey.com>
5257
5258         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5259
5260 2019-03-15  Tom Tromey  <tom@tromey.com>
5261
5262         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5263         unique_xmalloc_ptr.
5264         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5265         Update.
5266         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5267         (build_minimal_symbol_hash_tables)
5268         (minimal_symbol_reader::install): Update.
5269
5270 2019-03-15  Tom Tromey  <tom@tromey.com>
5271
5272         * symtab.c (create_demangled_names_hash): Update.
5273         (symbol_set_names): Update.
5274         * objfiles.h (struct objfile_per_bfd_storage)
5275         <demangled_names_hash>: Now an htab_up.
5276         * objfiles.c (objfile_per_bfd_storage): Simplify.
5277
5278 2019-03-15  Tom Tromey  <tom@tromey.com>
5279
5280         * objfiles.h (struct objfile_per_bfd_storage): Declare
5281         destructor.
5282         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5283         New.
5284         (get_objfile_bfd_data): Use new.  Don't initialize
5285         language_of_main.
5286         (free_objfile_per_bfd_storage): Remove.
5287         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5288
5289 2019-03-15  Tom Tromey  <tom@tromey.com>
5290
5291         * symfile.c (reread_symbols): Update.
5292         * objfiles.c (objfile::objfile): Update.
5293         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5294         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5295         comment.
5296         (minimal_symbol_reader::install): Update.
5297         (terminate_minimal_symbol_table): Remove.
5298         * jit.c (jit_object_close_impl): Update.
5299
5300 2019-03-15  Tom Tromey  <tom@tromey.com>
5301
5302         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5303         initializations.
5304
5305 2019-03-15  Tom Tromey  <tom@tromey.com>
5306
5307         * objfiles.h (struct objfile_per_bfd_storage)
5308         <demangled_hash_languages>: Now a bitset.
5309         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5310         (lookup_minimal_symbol): Update.
5311
5312 2019-03-15  Tom Tromey  <tom@tromey.com>
5313
5314         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5315         Don't return the symbol.
5316         * coffread.c (record_minimal_symbol): Use record_full.
5317
5318 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5319
5320         The MS-Windows port of ncurses fails to switch to a color pair if
5321         one or both of the colors are the implicit default colors.  This
5322         change records the default colors when TUI is initialized, and
5323         then specifies them explicitly when a color pair uses the default
5324         colors.  This allows color styling in TUI mode on MS-Windows.
5325
5326         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5327         ncurses_norm_attr.
5328         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5329         colors in ncurses_norm_attr.
5330         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5331         "none", replace it with the default color recorded in
5332         ncurses_norm_attr.
5333
5334 2019-03-14  Tom Tromey  <tromey@adacore.com>
5335
5336         * source-cache.h (class source_cache) <get_source_lines>: Return
5337         std::string.
5338         * source-cache.c (source_cache::extract_lines): Handle case where
5339         first_pos==npos.  Return std::string.
5340         (source_cache::get_source_lines): Update.
5341
5342 2019-03-14  Tom Tromey  <tromey@adacore.com>
5343
5344         * NEWS: Add item for "style sources" commands.
5345         * source-cache.c (source_cache::get_source_lines): Check
5346         source_styling.
5347         * cli/cli-style.c (source_styling): New global.
5348         (_initialize_cli_style): Add "style sources" commands.
5349         (show_style_sources): New function.
5350         * cli/cli-style.h (source_styling): Declare.
5351
5352 2019-03-14  Pedro Alves  <palves@redhat.com>
5353             Tom Tromey  <tromey@adacore.com>
5354
5355         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5356         * tui/tui-winsource.c (tui_refill_source_window): New function,
5357         from...
5358         (tui_horizontal_source_scroll): ... here.  Move some logic.
5359         * cli/cli-style.c (set_style_enabled): Notify new observable.
5360         * tui/tui-hooks.c (tui_redisplay_source): New function.
5361         (tui_attach_detach_observers): Attach or detach
5362         tui_redisplay_source.
5363         * observable.h (source_styling_changed): New observable.
5364         * observable.c: Define source_styling_changed observable.
5365
5366 2019-03-13  Tom Tromey  <tromey@adacore.com>
5367
5368         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5369         (i386_gnu_nat_target::store_registers): Update.
5370         * target-debug.h (target_debug_print_std_string): New macro.
5371         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5372         * windows-tdep.c (display_one_tib): Update.
5373         * tui/tui-stack.c (tui_make_status_line): Update.
5374         * top.c (print_inferior_quit_action): Update.
5375         * thread.c (thr_try_catch_cmd): Update.
5376         (add_thread_with_info): Update.
5377         (thread_target_id_str): Update.
5378         (thr_try_catch_cmd): Update.
5379         (thread_command): Update.
5380         (thread_find_command): Update.
5381         * record-btrace.c (record_btrace_target::info_record)
5382         (record_btrace_resume_thread, record_btrace_target::resume)
5383         (record_btrace_cancel_resume, record_btrace_step_thread)
5384         (record_btrace_target::wait, record_btrace_target::wait)
5385         (record_btrace_target::wait, record_btrace_target::stop): Update.
5386         * progspace.c (print_program_space): Update.
5387         * process-stratum-target.c
5388         (process_stratum_target::thread_address_space): Update.
5389         * linux-fork.c (linux_fork_mourn_inferior)
5390         (detach_checkpoint_command, info_checkpoints_command)
5391         (linux_fork_context): Update.
5392         (linux_fork_detach): Update.
5393         (class scoped_switch_fork_info): Update.
5394         (delete_checkpoint_command): Update.
5395         * infrun.c (follow_fork_inferior): Update.
5396         (follow_fork_inferior): Update.
5397         (proceed_after_vfork_done): Update.
5398         (handle_vfork_child_exec_or_exit): Update.
5399         (follow_exec): Update.
5400         (displaced_step_prepare_throw): Update.
5401         (displaced_step_restore): Update.
5402         (start_step_over): Update.
5403         (resume_1): Update.
5404         (clear_proceed_status_thread): Update.
5405         (proceed): Update.
5406         (print_target_wait_results): Update.
5407         (do_target_wait): Update.
5408         (context_switch): Update.
5409         (stop_all_threads): Update.
5410         (restart_threads): Update.
5411         (finish_step_over): Update.
5412         (handle_signal_stop): Update.
5413         (switch_back_to_stepped_thread): Update.
5414         (keep_going_pass_signal): Update.
5415         (print_exited_reason): Update.
5416         (normal_stop): Update.
5417         * inferior.c (inferior_pid_to_str): Change return type.
5418         (print_selected_inferior): Update.
5419         (add_inferior): Update.
5420         (detach_inferior): Update.
5421         * dummy-frame.c (fprint_dummy_frames): Update.
5422         * dcache.c (dcache_info_1): Update.
5423         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5424         (btrace_fetch, btrace_clear): Update.
5425         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5426         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5427         type.
5428         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5429         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5430         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5431         * gdbarch.c, gdbarch.h: Rebuild.
5432         * gdbarch.sh (core_pid_to_str): Change return type.
5433         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5434         return type.
5435         (windows_nat_target::pid_to_str): Change return type.
5436         (windows_delete_thread): Update.
5437         (windows_nat_target::attach): Update.
5438         (windows_nat_target::files_info): Update.
5439         * target-delegates.c: Rebuild.
5440         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5441         return type.
5442         (sol_thread_target::pid_to_str): Change return type.
5443         * remote.c (class remote_target) <pid_to_str>: Change return
5444         type.
5445         (remote_target::pid_to_str): Change return type.
5446         (extended_remote_target::attach, remote_target::remote_stop_ns)
5447         (remote_target::remote_notif_remove_queued_reply)
5448         (remote_target::push_stop_reply, remote_target::disable_btrace):
5449         Update.
5450         (extended_remote_target::attach): Update.
5451         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5452         type.
5453         (gdbsim_target::pid_to_str): Change return type.
5454         * ravenscar-thread.c (struct ravenscar_thread_target)
5455         <pid_to_str>: Change return type.
5456         (ravenscar_thread_target::pid_to_str): Change return type.
5457         * procfs.c (class procfs_target) <pid_to_str>: Change return
5458         type.
5459         (procfs_target::pid_to_str): Change return type.
5460         (procfs_target::attach): Update.
5461         (procfs_target::detach): Update.
5462         (procfs_target::fetch_registers): Update.
5463         (procfs_target::store_registers): Update.
5464         (procfs_target::wait): Update.
5465         (procfs_target::files_info): Update.
5466         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5467         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5468         return type.
5469         (nto_procfs_target::pid_to_str): Change return type.
5470         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5471         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5472         return type.
5473         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5474         (exit_lwp): Update.
5475         (attach_proc_task_lwp_callback, get_detach_signal)
5476         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5477         (linux_nat_target::resume, wait_lwp, stop_callback)
5478         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5479         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5480         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5481         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5482         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5483         type.
5484         (inf_ptrace_target::attach): Update.
5485         (inf_ptrace_target::files_info): Update.
5486         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5487         type.
5488         (go32_nat_target::pid_to_str): Change return type.
5489         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5490         (gnu_nat_target::wait): Update.
5491         (gnu_nat_target::wait): Update.
5492         (gnu_nat_target::resume): Update.
5493         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5494         (fbsd_nat_target::wait): Update.
5495         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5496         type.
5497         (darwin_nat_target::attach): Update.
5498         * corelow.c (class core_target) <pid_to_str>: Change return type.
5499         (core_target::pid_to_str): Change return type.
5500         * target.c (normal_pid_to_str): Change return type.
5501         (default_pid_to_str): Likewise.
5502         (target_pid_to_str): Change return type.
5503         (target_translate_tls_address): Update.
5504         (target_announce_detach): Update.
5505         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5506         return type.
5507         (bsd_uthread_target::pid_to_str): Change return type.
5508         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5509         type.
5510         (bsd_kvm_target::pid_to_str): Change return type.
5511         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5512         return type.
5513         (aix_thread_target::pid_to_str): Change return type.
5514         * target.h (struct target_ops) <pid_to_str>: Change return type.
5515         (target_pid_to_str, normal_pid_to_str): Likewise.
5516         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5517         type.
5518         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5519         type.
5520         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5521         return type.
5522         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5523         type.
5524         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5525         type.
5526         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5527         return type.
5528
5529 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5530
5531         * NEWS: Mention that the new default MI version is 3.  Mention
5532         changes to the output of commands and events that deal with
5533         multi-location breakpoints.
5534         * breakpoint.c: Include "mi/mi-out.h".
5535         (print_one_breakpoint): Change output syntax if using MI version
5536         >= 3.
5537         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5538         New.
5539         (mi_multi_location_breakpoint_output_fixed): New.
5540         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5541         (mi_cmd_fix_multi_location_breakpoint_output): New.
5542         (mi_multi_location_breakpoint_output_fixed): New.
5543         * mi/mi-cmds.c (mi_cmds): Register command
5544         -fix-multi-location-breakpoint-output.
5545         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5546         interpreter "mi".
5547
5548 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5549
5550         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5551         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5552         instantiate mi_ui_out based on interpreter name.
5553         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5554         * mi/mi-main.c (mi_load_progress): Likewise.
5555
5556 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5557
5558         * NEWS: Combine separate "New targets" sections for 8.3.
5559
5560 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5561
5562         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5563         (ppcfbsd_init_abi): Install gdbarch
5564         "fetch_tls_load_module_address" and "get_thread_local_address"
5565         methods.
5566
5567 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5568
5569         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5570         (riscv_fbsd_init_abi): Install gdbarch
5571         "fetch_tls_load_module_address" and "get_thread_local_address"
5572         methods.
5573
5574 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5575
5576         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5577         (i386fbsd_init_abi): Install gdbarch
5578         "fetch_tls_load_module_address" and "get_thread_local_address"
5579         methods.
5580
5581 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5582
5583         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5584         (amd64fbsd_init_abi): Install gdbarch
5585         "fetch_tls_load_module_address" and "get_thread_local_address"
5586         methods.
5587
5588 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5589
5590         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5591         (struct fbsd_pspace_data): New type.
5592         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5593         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5594         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5595         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5596         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5597
5598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5599
5600         * gdbtypes.c (lookup_struct_elt): New function.
5601         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5602         * gdbtypes.h (struct struct_elt): New type.
5603         (lookup_struct_elt): New prototype.
5604
5605 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5606
5607         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5608         remove disabled code block.
5609
5610 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5611
5612         * gdbarch.sh (get_thread_local_address): New method.
5613         * gdbarch.h, gdbarch.c: Regenerate.
5614         * target.c (target_translate_tls_address): Use
5615         gdbarch_get_thread_local_address if present instead of
5616         target::get_thread_local_address.
5617
5618 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5619
5620         * target.h (target::get_thread_local_address): Update comment.
5621
5622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5623
5624         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5625         objfile->separate_debug_objfile_backlink if not NULL.
5626
5627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5628
5629         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5630         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5631         (amd64bsd_store_inferior_registers): Likewise.
5632         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5633         Enable segment base registers.
5634         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5635         PT_GETFSBASE and PT_GETGSBASE.
5636         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5637         PT_SETGSBASE.
5638         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5639         segment base registers.
5640         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5641
5642 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5643
5644         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5645         Update calls to i386_target_description to add 'segments'
5646         parameter.
5647         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5648         add segment base registers.
5649         * arch/i386.c (i386_create_target_description): Add 'segments'
5650         parameter to enable segment base registers.
5651         * arch/i386.h (i386_create_target_description): Likewise.
5652         * features/i386/32bit-segments.xml: New file.
5653         * features/i386/32bit-segments.c: Generate.
5654         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5655         call to i386_target_description to add 'segments' parameter.
5656         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5657         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5658         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5659         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5660         if feature is present.
5661         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5662         Add 'segments' parameter to call to i386_target_description.
5663         (i386_target_description): Add 'segments' parameter to enable
5664         segment base registers.
5665         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5666         to call to i386_target_description.
5667         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5668         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5669         Define I386_NUM_REGS.
5670         (i386_target_description): Add 'segments' parameter to enable
5671         segment base registers.
5672
5673 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5674
5675         PR/24325
5676         * source-cache.c: #undef open and close, to avoid unresolved
5677         externals during linking.
5678
5679 2019-03-12  Tom Tromey  <tromey@adacore.com>
5680
5681         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5682         const.  Add initializers.
5683         (_initialize_remote): Don't initialize ptid globals.
5684
5685 2019-03-12  Pedro Alves  <palves@redhat.com>
5686
5687         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5688
5689 2019-03-12  Pedro Alves  <palves@redhat.com>
5690
5691         * cp-name-parser.y (main): Remove unused 'len' variable.
5692
5693 2019-03-12  Tom Tromey  <tromey@adacore.com>
5694
5695         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5696         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5697
5698 2019-03-12  Tom Tromey  <tromey@adacore.com>
5699
5700         * linux-nat.c (iterate_over_lwps): Update.
5701         (stop_callback): Remove parameter.
5702         (stop_wait_callback, detach_callback, resume_set_callback)
5703         (select_singlestep_lwp_callback, set_ignore_sigint)
5704         (status_callback, resumed_callback, resume_clear_callback)
5705         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5706         data parameter.
5707         (linux_nat_target::detach, linux_nat_target::resume)
5708         (linux_stop_and_wait_all_lwps, select_event_lwp)
5709         (linux_nat_filter_event, linux_nat_wait_1)
5710         (linux_nat_target::kill, linux_nat_target::stop)
5711         (linux_nat_target::stop): Update.
5712         (linux_nat_resume_callback): Change type.
5713         (resume_stopped_resumed_lwps, count_events_callback)
5714         (select_event_lwp_callback): Likewise.
5715         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5716         * arm-linux-nat.c (struct update_registers_data): Remove.
5717         (update_registers_callback): Change type.
5718         (arm_linux_insert_hw_breakpoint1): Update.
5719         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5720         parameter.
5721         (x86_linux_dr_set_addr): Update.
5722         (x86_linux_dr_set_control): Update.
5723         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5724         (iterate_over_lwps): Use gdb::function_view.
5725         * nat/aarch64-linux-hw-point.c (struct
5726         aarch64_dr_update_callback_param): Remove.
5727         (debug_reg_change_callback): Change type.
5728         (aarch64_notify_debug_reg_change): Update.
5729         * s390-linux-nat.c (s390_refresh_per_info): Update.
5730
5731 2019-03-11  Tom Tromey  <tromey@adacore.com>
5732
5733         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5734         redundant assignment to "this_cu".
5735
5736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5737
5738         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5739
5740 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5741
5742         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5743         from...
5744         (rank_one_type): ... this.
5745
5746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5747
5748         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5749         from...
5750         (rank_one_type): ... this.
5751
5752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5753
5754         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5755         from...
5756         (rank_one_type): ... this.
5757
5758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5759
5760         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5761         from...
5762         (rank_one_type): ... this.
5763
5764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5765
5766         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5767         from...
5768         (rank_one_type): ... this.
5769
5770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5771
5772         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5773         from...
5774         (rank_one_type): ... this.
5775
5776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5777
5778         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5779         from...
5780         (rank_one_type): ... this.
5781
5782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5783
5784         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5785         from...
5786         (rank_one_type): ... this.
5787
5788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5789
5790         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5791         from...
5792         (rank_one_type): ... this.
5793
5794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5795
5796         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5797         from...
5798         (rank_one_type): ... this.
5799
5800 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5801
5802         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5803         from...
5804         (rank_one_type): ... this.
5805
5806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5807
5808         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5809         from...
5810         (rank_one_type): ... this.
5811
5812 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5813
5814         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5815         inferior-events' shows the example events.
5816
5817 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5818
5819         Support styling on native MS-Windows console
5820
5821         PR/24315
5822         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5823         on MS-Windows if $TERM is not defined.
5824
5825         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5826
5827         * posix-hdep.c (gdb_console_fputs):
5828         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5829         functions.
5830         * ui-file.h (gdb_console_fputs): Add prototype.
5831
5832         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5833         back to fputs only if the former returns zero.
5834
5835 2019-03-07  Tom Tromey  <tom@tromey.com>
5836
5837         * symmisc.c (print_symbol_bcache_statistics): Update.
5838         (print_objfile_statistics): Update.
5839         * symfile.c (allocate_symtab): Update.
5840         * stabsread.c: Don't include bcache.h.
5841         * psymtab.h (struct psymbol_bcache): Don't declare.
5842         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5843         (psymbol_bcache_init, psymbol_bcache_free)
5844         (psymbol_bcache_get_bcache): Don't declare.
5845         * psymtab.c (struct psymbol_bcache): Remove.
5846         (psymtab_storage::psymtab_storage): Update.
5847         (psymtab_storage::~psymtab_storage): Update.
5848         (psymbol_bcache_init, psymbol_bcache_free)
5849         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5850         (add_psymbol_to_bcache): Update.
5851         (allocate_psymtab): Update.
5852         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5853         macro_cache>: No longer pointers.
5854         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5855         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5856         * macrotab.c (macro_bcache): Update.
5857         * macroexp.c: Don't include bcache.h.
5858         * gdbtypes.c (check_types_worklist): Update.
5859         (types_deeply_equal): Remove TRY/CATCH.  Update.
5860         * elfread.c (elf_symtab_read): Update.
5861         * dwarf2read.c: Don't include bcache.h.
5862         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5863         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5864         (print_bcache_statistics, bcache_memory_used): Don't declare.
5865         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5866         methods.  Rename all data members.
5867         * bcache.c (struct bcache): Move to bcache.h.
5868         (bcache::expand_hash_table): Rename from expand_hash_table.
5869         (bcache): Remove.
5870         (bcache::insert): Rename from bcache_full.
5871         (bcache::compare): Rename from bcache_compare.
5872         (bcache_xmalloc): Remove.
5873         (bcache::~bcache): Rename from bcache_xfree.
5874         (bcache::print_statistics): Rename from print_bcache_statistics.
5875         (bcache::memory_used): Rename from bcache_memory_used.
5876
5877 2019-03-07  Pedro Alves  <palves@redhat.com>
5878
5879         * infrun.c (normal_stop): Also check for
5880         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5881
5882 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * f-lang.c (value_from_host_double): Moved to...
5885         * value.c (value_from_host_double): ...here.
5886         * value.h (value_from_host_double): Declare.
5887         * guile/scm-math.c (vlscm_convert_typed_number): Use
5888         value_from_host_double.
5889         (vlscm_convert_number): Likewise.
5890         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5891         * python/py-value.c (convert_value_from_python): Likewise.
5892
5893 2019-03-06  Tom Tromey  <tom@tromey.com>
5894
5895         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5896
5897 2019-03-06  Tom Tromey  <tom@tromey.com>
5898
5899         * utils.h (free_current_contents): Don't declare.
5900         * utils.c (free_current_contents): Remove.
5901
5902 2019-03-06  Tom Tromey  <tom@tromey.com>
5903
5904         * top.c (quit_force): Update.
5905         * main.c (captured_command_loop): Update.
5906         * common/new-op.c (operator new): Update.
5907         * common/common-exceptions.c (struct catcher)
5908         <save_cleanup_chain>: Remove member.
5909         (exceptions_state_mc_init): Update.
5910         (exception_try_scope_entry): Return nullptr.
5911         (exception_try_scope_exit, exception_rethrow)
5912         (throw_exception_sjlj, throw_exception_cxx): Update.
5913         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5914         (all_cleanups, do_cleanups, discard_cleanups)
5915         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5916         (restore_cleanups, restore_final_cleanups): Don't declare.
5917         (do_final_cleanups): Remove parameter.
5918         * common/cleanups.c (cleanup_chain, make_cleanup)
5919         (make_cleanup_dtor, all_cleanups, do_cleanups)
5920         (discard_my_cleanups, discard_cleanups)
5921         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5922         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5923         (null_cleanup): Remove.
5924         (do_final_cleanups): Remove parameter.
5925
5926 2019-03-06  Tom Tromey  <tom@tromey.com>
5927
5928         * remote.c (remote_target::remote_parse_stop_reply): Use
5929         unique_xmalloc_ptr.
5930
5931 2019-03-06  Tom Tromey  <tom@tromey.com>
5932
5933         * stabsread.c (struct stabs_field_info): Rename from field_info.
5934         <list, fnlist>: Add initializers.
5935         <obstack>: New member.
5936         (read_member_functions, read_struct_fields, read_baseclasses):
5937         Allocate on obstack.  Don't use cleanups.
5938         (read_one_struct_field, read_member_functions, read_struct_fields)
5939         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5940         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5941         (read_struct_type): Update.
5942
5943 2019-03-06  Tom Tromey  <tom@tromey.com>
5944
5945         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5946         * common/filestuff.h (make_cleanup_close): Don't declare.
5947         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5948         Remove.
5949
5950 2019-03-06  Tom Tromey  <tom@tromey.com>
5951
5952         * solib-aix.c: Use make_scope_exit.
5953
5954 2019-03-06  Tom Tromey  <tom@tromey.com>
5955
5956         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5957         Use make_scope_exit.
5958
5959 2019-03-06  Tom Tromey  <tom@tromey.com>
5960
5961         * solib-svr4.c (disable_probes_interface): Remove parameter.
5962         (svr4_handle_solib_event): Use make_scope_exit.
5963
5964 2019-03-06  Tom Tromey  <tom@tromey.com>
5965
5966         * remote.c (struct stop_reply_deleter): Remove.
5967         (stop_reply_up): Update.
5968         (struct stop_reply): Derive from notif_event.  Don't typedef.
5969         <regcache>: Now a std::vector.
5970         (stop_reply_xfree): Remove.
5971         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5972         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5973         (remote_target::discard_pending_stop_replies): Use delete.
5974         (remote_target::remote_parse_stop_reply): Update.
5975         (remote_target::process_stop_reply): Update.
5976         * remote-notif.h (struct notif_event): Add virtual destructor.
5977         Remove "dtr" member.
5978         (struct notif_client) <alloc_event>: Return a unique_ptr.
5979         (notif_event_xfree): Don't declare.
5980         (notif_event_up): New typedef.
5981         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5982         (notif_event_xfree, do_notif_event_xfree): Remove.
5983         (remote_notif_state_xfree): Update.
5984
5985 2019-03-06  Tom Tromey  <tom@tromey.com>
5986
5987         * infrun.c (displaced_step_clear_cleanup): Now a
5988         forward_scope_exit type.
5989         (displaced_step_prepare_throw): Update.
5990         (displaced_step_fixup): Update.
5991
5992 2019-03-06  Tom Tromey  <tom@tromey.com>
5993
5994         * inferior.h (class inferior): Update comment.
5995         * gdbthread.h (class thread_info): Update comment.
5996
5997 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5998             Tom Tromey  <tom@tromey.com>
5999
6000         * stabsread.h (struct stab_section_list): Remove.
6001         (coffstab_build_psymtabs): Update.
6002         * dbxread.c (symbuf_sections): Now a std::vector.
6003         (sect_idx): New global.
6004         (fill_symbuf): Update.
6005         (coffstab_build_psymtabs): Change type of stabsects parameter.
6006         Update.
6007         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6008         std::vector.
6009         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6010         (coff_locate_sections): Update.
6011         (coff_symfile_read): Remove cleanups.  Update.
6012         (init_stringtab): Add storage parameter.
6013         (free_stringtab, free_stringtab_cleanup): Remove.
6014         (init_lineno): Add storage parameter.
6015         (free_linetab, free_linetab_cleanup): Remove.
6016
6017 2019-03-06  Pedro Alves  <palves@redhat.com>
6018
6019         * linux-fork.c (fork_info::clobber_regs): Delete.
6020         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6021         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6022         comment.  Adjust.
6023         (scoped_switch_fork_info::scoped_switch_fork_info)
6024         (checkpoint_command, linux_fork_context): Adjust
6025         fork_save_infrun_state calls.
6026
6027 2019-03-06  Pedro Alves  <palves@redhat.com>
6028
6029         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6030         (inf_has_multiple_threads): Return 'bool' and rewrite using
6031         inferior_info::threads().
6032
6033 2019-03-06  Pedro Alves  <palves@redhat.com>
6034
6035         * linux-fork.c: Include <list>.
6036         (fork_list): Now a std::list instance.
6037         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6038         (forks_exist_p, find_last_fork): Adjust.
6039         (new_fork): Delete.
6040         (one_fork_p): New.
6041         (add_fork): Adjust.
6042         (free_fork): Delete, folded into fork_info::~fork_info().
6043         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6044         Adjust.
6045         (init_fork_list): Delete.
6046         (linux_fork_killall, linux_fork_mourn_inferior)
6047         (linux_fork_detach, info_checkpoints_command): Adjust.
6048         (_initialize_linux_fork): No longer call init_fork_list.
6049
6050 2019-03-06  Pedro Alves  <palves@redhat.com>
6051
6052         * linux-fork.c (new_fork): New, split out of ...
6053         (add_fork): ... this.  Return void.  Move "first fork" special
6054         case from here, to ...
6055         (checkpoint_command): ... here.
6056         * linux-linux.h (add_fork): Return void.
6057
6058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6061
6062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6063             Chris January  <chris.january@arm.com>
6064             David Lecomber  <david.lecomber@arm.com>
6065
6066         * f-exp.y: New token, UNOP_INTRINSIC.
6067         (exp): New pattern using UNOP_INTRINSIC token.
6068         (f77_keywords): Add 'abs' keyword.
6069         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6070         (value_from_host_double): New function.
6071         (evaluate_subexp_f): Support UNOP_ABS.
6072
6073 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6076         types.
6077
6078 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6081         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6082         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6083
6084 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6085
6086         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6087
6088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6089             Chris January  <chris.january@arm.com>
6090
6091         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6092         * f-exp.y: Define 'KIND' token.
6093         (exp): New pattern for KIND expressions.
6094         (ptype): Handle types with a kind extension.
6095         (direct_abs_decl): Extend to spot kind extensions.
6096         (f77_keywords): Add 'kind' to the list.
6097         (push_kind_type): New function.
6098         (convert_to_kind_type): New function.
6099         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6100         * parse.c (operator_length_standard): Likewise.
6101         * parser-defs.h (enum type_pieces): Add tp_kind.
6102         * std-operator.def: Add UNOP_KIND.
6103
6104 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6105
6106         * f-exp.y (f_parse): Set yydebug.
6107
6108 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * f-lang.c (evaluate_subexp_f): New function.
6111         (exp_descriptor_f): New global.
6112         (f_language_defn): Use exp_descriptor_f instead of
6113         exp_descriptor_standard.
6114
6115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6116
6117         * f-exp.y (struct token): Add comments.
6118         (dot_ops): Remove uppercase versions and the end marker.
6119         (f77_keywords): Likewise.
6120         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6121         entries in the dot_ops array are case insensitive, and use
6122         strncasecmp to compare strings.  Also some whitespace cleanup in
6123         this area.  Similar for the f77_keywords array, except entries in
6124         this list might be case sensitive.
6125
6126 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6127
6128         * f-exp.y (struct f77_boolean_val): Add comments.
6129         (boolean_values): Remove uppercase versions, and end marker.
6130         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6131         and use strncasecmp to achieve case insensitivity.  Additionally,
6132         perform whitespace cleanup around this code.
6133
6134 2019-03-06  Tom Tromey  <tromey@adacore.com>
6135
6136         * remote-sim.c (gdbsim_target_open): Use result of
6137         gdb_argv::release.
6138
6139 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6140         Dirk Schubert  <dirk.schubert@arm.com>
6141         Chris January  <chris.january@arm.com>
6142
6143         * eval.c (evaluate_subexp_standard): Call Fortran argument
6144         wrapping logic.
6145         * f-lang.c (struct value): A value which can be passed into a
6146         Fortran function call.
6147         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6148         where appropriate.
6149         (struct type): Value ready for a Fortran function call.
6150         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6151         is needed.
6152         * f-lang.h (fortran_argument_convert): Declaration.
6153         (fortran_preserve_arg_pointer): Declaration.
6154         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6155
6156 2019-03-05  Tom Tromey  <tromey@adacore.com>
6157
6158         * python/py-prettyprint.c (print_string_repr): Remove #if.
6159         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6160
6161 2019-03-05  Tom Tromey  <tromey@adacore.com>
6162
6163         * target.c (the_dummy_target): Move later.  Change type to
6164         "dummy_target".
6165         (initialize_targets): Don't initialize the_dummy_target.
6166
6167 2019-03-05  Tom Tromey  <tromey@adacore.com>
6168
6169         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6170         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6171
6172 2019-03-05  Tom Tromey  <tromey@adacore.com>
6173
6174         * windows-nat.c (windows_nat_target::attach)
6175         (windows_nat_target::detach): Don't call gdb_flush.
6176         * valprint.c (generic_val_print, val_print, val_print_string):
6177         Don't call gdb_flush.
6178         * utils.c (defaulted_query): Don't call gdb_flush.
6179         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6180         * target.c (target_announce_detach): Don't call gdb_flush.
6181         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6182         * remote.c (extended_remote_target::attach): Don't call
6183         gdb_flush.
6184         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6185         * printcmd.c (do_examine): Don't call gdb_flush.
6186         (info_display_command): Don't call gdb_flush.
6187         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6188         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6189         * memattr.c (info_mem_command): Don't call gdb_flush.
6190         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6191         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6192         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6193         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6194         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6195         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6196         (gnu_nat_target::detach): Don't call gdb_flush.
6197         * f-valprint.c (f_val_print): Don't call gdb_flush.
6198         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6199         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6200         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6201         gdb_flush.
6202         * c-valprint.c (c_val_print): Don't call gdb_flush.
6203         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6204
6205 2019-03-05  Tom Tromey  <tromey@adacore.com>
6206
6207         * varobj.c (update_dynamic_varobj_children): Update.
6208         (install_default_visualizer): Use reset, not release.
6209         * value.c (set_internalvar): Update.
6210         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6211         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6212         ATTRIBUTE_UNUSED_RESULT.
6213
6214 2019-03-05  Tom Tromey  <tromey@adacore.com>
6215
6216         * remote.c (class scoped_remote_fd) <release>: Add
6217         ATTRIBUTE_UNUSED_RESULT.
6218
6219 2019-03-05  Tom Tromey  <tromey@adacore.com>
6220
6221         * macroexp.c (struct macro_buffer) <release>: Add
6222         ATTRIBUTE_UNUSED_RESULT.
6223
6224 2019-03-05  Tom Tromey  <tromey@adacore.com>
6225
6226         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6227         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6228         ATTRIBUTE_UNUSED_RESULT.
6229
6230 2019-03-05  Tom Tromey  <tromey@adacore.com>
6231
6232         * common/scoped_fd.h (class scoped_fd) <release>: Add
6233         ATTRIBUTE_UNUSED_RESULT.
6234
6235 2019-03-05  Tom Tromey  <tromey@adacore.com>
6236
6237         * parser-defs.h (struct parser_state) <release>: Add
6238         ATTRIBUTE_UNUSED_RESULT.
6239
6240 2019-03-05  Tom Tromey  <tromey@adacore.com>
6241
6242         * utils.h (class gdb_argv) <release>: Add
6243         ATTRIBUTE_UNUSED_RESULT.
6244         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6245
6246 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6247
6248         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6249         for-loop range, to avoid compiler warnings.
6250
6251         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6252         avoid compiler warnings about unused variables.
6253
6254         * NEWS: Mention end of support for native debugging on MS-Windows
6255         before XP.
6256
6257         PR gdb/24292
6258         * common/netstuff.c:
6259         * gdbserver/gdbreplay.c
6260         * gdbserver/remote-utils.c:
6261         * ser-tcp.c:
6262         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6263         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6264         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6265         'getaddrinfo' and 'freeaddrinfo' were not available before
6266         Windows XP, and mingw.org's MinGW headers by default define
6267         _WIN32_WINNT to 0x500.
6268
6269 2019-03-01  Gary Benson <gbenson@redhat.com>
6270
6271         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6272
6273 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6274             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6275
6276         PR gdb/8527
6277         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6278         set_sigint_trap, clear_sigint_trap.
6279
6280 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6281
6282         * target.c (target_detach): Clear the regcache and the
6283         frame cache.
6284
6285 2019-02-27  Pedro Alves  <palves@redhat.com>
6286
6287         * utils.c (set_screen_size): When we cap the height/width sizes,
6288         tweak the corresponding command variable to show "unlimited":
6289
6290 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6291             Pedro Alves  <palves@redhat.com>
6292
6293         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6294         before calling rl_set_screen_size.
6295
6296 2019-02-27  Tom Tromey  <tromey@adacore.com>
6297
6298         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6299         define.
6300         * python/py-value.c: Remove Python 2.4 workaround.
6301         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6302         workaround.
6303         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6304         Python 2.4 workaround.
6305         * python/python-internal.h: Remove Python 2.4 comment.
6306         (Py_ssize_t): Don't define.
6307         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6308         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6309         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6310         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6311         * python/python.c (do_start_initialization): Remove Python 2.4
6312         workaround.
6313         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6314         (print_children): Remove Python 2.4 workaround.
6315         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6316         workaround.
6317         (CHARBUFFERPROC_NAME): Remove.
6318         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6319         Python 2.4 workaround.
6320
6321 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6322
6323         * NEWS: Note minimum Python version.
6324
6325 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6326
6327         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6328         code from these functions.  Remove corresponding ifdefs.  Use
6329         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6330         Remove gotos and target of gotos.
6331         (infpy_search_memory): Likewise.
6332
6333 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6336         (hppa_gdbarch_init): Don't register deleted functions with
6337         gdbarch.
6338
6339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6342         (h8300_unwind_sp): Delete.
6343         (h8300_dummy_id): Delete.
6344         (h8300_gdbarch_init): Don't register deleted functions with
6345         gdbarch.
6346
6347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6350         (ft32_unwind_pc): Delete.
6351         (ft32_unwind_sp): Delete.
6352         (ft32_gdbarch_init): Don't register deleted functions with
6353         gdbarch.
6354
6355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6356
6357         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6358         (frv_unwind_pc): Delete.
6359         (frv_unwind_sp): Delete.
6360         (frv_gdbarch_init): Don't register deleted functions with
6361         gdbarch.
6362
6363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6364
6365         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6366         (riscv_unwind_pc): Delete.
6367         (riscv_unwind_sp): Delete.
6368         (riscv_gdbarch_init): Don't register deleted functions with
6369         gdbarch.
6370
6371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6374         (csky_unwind_pc): Delete.
6375         (csky_unwind_sp): Delete.
6376         (csky_gdbarch_init): Don't register deleted functions with
6377         gdbarch.
6378
6379 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6382         (cris_unwind_pc): Delete.
6383         (cris_unwind_sp): Delete.
6384         (cris_gdbarch_init): Don't register deleted functions with
6385         gdbarch.
6386
6387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6388
6389         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6390         (bfin_unwind_pc): Delete.
6391         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6392
6393 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6394
6395         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6396         (arm_unwind_pc): Delete.
6397         (arm_unwind_sp): Delete.
6398         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6399
6400 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6403         (arc_unwind_pc): Delete.
6404         (arc_unwind_sp): Delete.
6405         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6406
6407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6410         (alpha_unwind_pc): Delete.
6411         (alpha_gdbarch_init): Don't register deleted functions with
6412         gdbarch.
6413
6414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6417         (aarch64_unwind_pc): Delete.
6418         (aarch64_unwind_sp): Delete.
6419         (aarch64_gdbarch_init): Don't register deleted functions with
6420         gdbarch.
6421
6422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * gdbtypes.c (type_align): Don't consider static members when
6425         computing structure alignment.
6426
6427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6428
6429         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6430         return 0 for other types.
6431         * arch-utils.c (default_type_align): Always return 0.
6432         * gdbarch.h: Regenerate.
6433         * gdbarch.sh (type_align): Extend comment.
6434         * gdbtypes.c (type_align): Add additional comments, always call
6435         gdbarch_type_align before applying the default rules.
6436         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6437         generic code will then apply a suitable default.
6438         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6439         types, return 0 for other types.
6440
6441 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6442
6443         * NEWS: Create a new section for the next release branch.
6444         Rename the section of the current branch, now that it has
6445         been cut.
6446
6447 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6448
6449         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6450         * version.in: Bump version to 8.3.50.DATE-git.
6451
6452 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6453
6454         * aix-thread.c (ptid_cmp): Remove unused variable.
6455         (get_signaled_thread): Likewise.
6456         (store_regs_user_thread): Likewise.
6457         (store_regs_kernel_thread): Likewise.
6458         (fetch_regs_kernel_thread): Remove shadowed variable.
6459
6460 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6461
6462         * features/riscv/32bit-cpu.xml: Add register numbers.
6463         * features/riscv/32bit-fpu.c: Regenerate.
6464         * features/riscv/32bit-fpu.xml: Add register numbers.
6465         * features/riscv/64bit-cpu.xml: Add register numbers.
6466         * features/riscv/64bit-fpu.c: Regenerate.
6467         * features/riscv/64bit-fpu.xml: Add register numbers.
6468
6469 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6470
6471         * NEWS: Mention two argument form of gdb.Value constructor.
6472         * python/py-value.c (convert_buffer_and_type_to_value): New
6473         function.
6474         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6475         Add support for handling an optional second argument.  Call
6476         convert_buffer_and_type_to_value as appropriate.
6477         * python/python-internal.h (Py_buffer_deleter): New struct.
6478         (Py_buffer_up): New typedef.
6479
6480 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6481
6482         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6483         instead of releasing ownership.
6484
6485 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6486
6487         * dwarf2read.c (open_and_init_dwp_file): Call
6488         elf_numsections instead of bfd_count_sections to initialize
6489         dwp_file->num_sections.
6490
6491 2019-02-25  Tom Tromey  <tromey@adacore.com>
6492
6493         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6494
6495 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6496
6497         * gcore.in: Add '--readnever' option when invoking GDB.
6498
6499 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6500
6501         * MAINTAINERS: Update my email address.
6502
6503 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6504
6505         * build-id.c (build_id_to_debug_bfd_1): New function.
6506         (build_id_to_debug_bfd): Look for separate debug file in
6507         sysroot.
6508
6509 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * gdbarch.sh: Update the copyright year range that is placed into
6512         generated files.
6513
6514 2019-02-22  Keith Seitz  <keiths@redhat.com>
6515
6516         PR symtab/23853
6517         * linespec.c (create_sals_line_offset): Search for the default
6518         symtab's filename instead of its fullname.
6519
6520 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6521
6522         * NEWS: Update style defaults.
6523
6524 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6525
6526         * main.c (captured_main_1): Disable styling in batch mode.
6527
6528 2019-02-20  Tom Tromey  <tom@tromey.com>
6529
6530         * symtab.c (symtab_symbol_info): Fix typos.
6531
6532 2019-02-20  Tom Tromey  <tromey@adacore.com>
6533
6534         * findcmd.c (_initialize_mem_search): Use upper case for
6535         metasyntactic variables.
6536
6537 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6538
6539         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6540         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6541
6542 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6543
6544         * top.h (source_file_name): Change to std::string.
6545         * top.c (source_file_name): Likewise.
6546         (command_line_input): Adjust.
6547         * cli/cli-script.c (script_from_file): Adjust.
6548
6549 2019-02-19  Tom Tromey  <tromey@adacore.com>
6550
6551         * ravenscar-thread.c
6552         (ravenscar_thread_target::update_thread_list): Don't call
6553         ada_build_task_list.
6554         * ada-lang.h (ada_build_task_list): Don't declare.
6555         * ada-tasks.c (struct ada_tasks_inferior_data)
6556         <task_list_valid_p>: Now bool.
6557         (read_known_tasks, ada_task_list_changed)
6558         (ada_tasks_invalidate_inferior_data): Update.
6559         (read_known_tasks_array): Return bool.
6560         (read_known_tasks_list): Likewise.
6561         (read_known_tasks): Return void.
6562         (ada_build_task_list): Now static.
6563
6564 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6567         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6568
6569 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6570
6571         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6572         variant for ada_tasks_pspace_data_handle and
6573         ada_tasks_inferior_data_handle.
6574         (ada_tasks_pspace_data_cleanup): New function.
6575         (ada_tasks_inferior_data_cleanup): New function.
6576
6577 2019-02-17  Tom Tromey  <tom@tromey.com>
6578
6579         * macrotab.h (macro_source_fullname): Return a std::string.
6580         * macrotab.c (macro_include, check_for_redefinition)
6581         (macro_undef, macro_lookup_definition, foreach_macro)
6582         (foreach_macro_in_scope): Update.
6583         (macro_source_fullname): Return a std::string.
6584         * macrocmd.c (show_pp_source_pos): Update.
6585
6586 2019-02-17  Tom Tromey  <tom@tromey.com>
6587
6588         * macrocmd.c (show_pp_source_pos): Style the file names.
6589
6590 2019-02-17  Tom Tromey  <tom@tromey.com>
6591
6592         PR tui/24197:
6593         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6594
6595 2019-02-17  Tom Tromey  <tom@tromey.com>
6596
6597         * ada-lang.c (user_select_syms): Use filtered printing.
6598         * utils.c (wrap_style): New global.
6599         (desired_style): Remove.
6600         (emit_style_escape): Add stream parameter.
6601         (set_output_style, reset_terminal_style, prompt_for_continue):
6602         Update.
6603         (flush_wrap_buffer): Only flush gdb_stdout.
6604         (wrap_here): Set wrap_style.
6605         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6606         treat escape sequences as a character.  Change when wrap buffer is
6607         flushed.
6608         (fputs_styled): Do not set the output style when the default is
6609         requested.
6610         * ui-style.h (struct ui_file_style) <is_default>: New method.
6611         * source.c (print_source_lines_base): Emit escape sequences in one
6612         piece.
6613
6614 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6615
6616         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6617         integers and enumeration types.
6618
6619 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6620
6621         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6622         instead of lookup_symbol_in_language
6623         (do_exact_match): New function.
6624         (ada_get_symbol_name_matcher): Return do_exact_match when
6625         doing a verbatim match.
6626
6627 2019-02-15  Tom Tromey  <tromey@adacore.com>
6628
6629         * ravenscar-thread.c (ravenscar_thread_target::resume)
6630         (ravenscar_thread_target::wait): Special case wildcard requests.
6631
6632 2019-02-15  Tom Tromey  <tromey@adacore.com>
6633
6634         * ravenscar-thread.c (base_ptid): Remove.
6635         (struct ravenscar_thread_target) <close>: New method.
6636         <m_base_ptid>: New member.
6637         <update_inferior_ptid, active_task, task_is_currently_active,
6638         runtime_initialized>: Declare methods.
6639         <ravenscar_thread_target>: Add constructor.
6640         (ravenscar_thread_target::task_is_currently_active)
6641         (ravenscar_thread_target::update_inferior_ptid)
6642         (ravenscar_runtime_initialized): Rename.  Now methods.
6643         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6644         (ravenscar_thread_target::update_thread_list): Update.
6645         (ravenscar_thread_target::active_task): Now method.
6646         (ravenscar_thread_target::store_registers)
6647         (ravenscar_thread_target::prepare_to_store)
6648         (ravenscar_thread_target::prepare_to_store)
6649         (ravenscar_thread_target::mourn_inferior): Update.
6650         (ravenscar_inferior_created): Use "new" to create target.
6651         (ravenscar_thread_target::get_ada_task_ptid): Update.
6652         (_initialize_ravenscar): Don't initialize base_ptid.
6653         (ravenscar_ops): Remove global.
6654
6655 2019-02-15  Tom Tromey  <tromey@adacore.com>
6656
6657         * target.h (push_target): Declare new overload.
6658         * target.c (push_target): New overload, taking an rvalue reference.
6659         * remote.c (remote_target::open_1): Use push_target overload.
6660         * corelow.c (core_target_open): Use push_target overload.
6661
6662 2019-02-15  Tom Tromey  <tromey@adacore.com>
6663
6664         * ravenscar-thread.c (is_ravenscar_task)
6665         (ravenscar_task_is_currently_active): Return bool.
6666         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6667         (_initialize_ravenscar): Remove "(void)".
6668         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6669         Return bool.
6670
6671 2019-02-15  Tom Tromey  <tromey@adacore.com>
6672
6673         * ravenscar-thread.c (ravenscar_runtime_initializer)
6674         (has_ravenscar_runtime, get_running_thread_id)
6675         (ravenscar_thread_target::resume): Fix indentation.
6676
6677 2019-02-15  Tom Tromey  <tromey@adacore.com>
6678
6679         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6680         from ravenscar_arch_ops.
6681         (sparc_ravenscar_ops::fetch_registers)
6682         (sparc_ravenscar_ops::store_registers): Now methods.
6683         (sparc_ravenscar_prepare_to_store): Remove.
6684         (sparc_ravenscar_ops): Redefine.
6685         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6686         methods and destructor.  Remove members.
6687         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6688         (ravenscar_thread_target::store_registers)
6689         (ravenscar_thread_target::prepare_to_store): Update.
6690         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6691         Remove.
6692         (struct ppc_ravenscar_powerpc_ops): Derive from
6693         ravenscar_arch_ops.
6694         (ppc_ravenscar_powerpc_ops::fetch_registers)
6695         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6696         (ppc_ravenscar_powerpc_ops): Redefine.
6697         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6698         (ppc_ravenscar_e500_ops::fetch_registers)
6699         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6700         (ppc_ravenscar_e500_ops): Redefine.
6701         * aarch64-ravenscar-thread.c
6702         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6703         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6704         (aarch64_ravenscar_fetch_registers)
6705         (aarch64_ravenscar_store_registers): Now methods.
6706         (aarch64_ravenscar_ops): Redefine.
6707
6708 2019-02-15  Tom Tromey  <tromey@adacore.com>
6709
6710         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6711         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6712         (ravenscar_thread_target::stopped_by_watchpoint)
6713         (ravenscar_thread_target::stopped_data_address)
6714         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6715
6716 2019-02-15  Tom Tromey  <tromey@adacore.com>
6717
6718         * ravenscar-thread.c: Fix some typos.
6719
6720 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6721             Tom Tromey  <tromey@adacore.com>
6722
6723         * ada-lang.c (ada_exception_sal): Change addr_string to a
6724         std::string.
6725         (create_ada_exception_catchpoint): Update.
6726
6727 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6728             Tom Tromey  <tromey@adacore.com>
6729
6730         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6731         (bp_location_ops): Remove.
6732         (base_breakpoint_allocate_location): Update.
6733         (free_bp_location): Update.
6734         * ada-lang.c (class ada_catchpoint_location)
6735         <ada_catchpoint_location>: Remove ops parameter.
6736         (ada_catchpoint_location_dtor): Remove.
6737         (ada_catchpoint_location_ops): Remove.
6738         (allocate_location_exception): Update.
6739         * breakpoint.h (struct bp_location_ops): Remove.
6740         (class bp_location) <bp_location>: Remove bp_location_ops
6741         parameter.
6742         <~bp_location>: Add destructor.
6743         <ops>: Remove.
6744
6745 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6746             Pedro Alves  <palves@redhat.com>
6747
6748         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6749         'PATH_MAX'.
6750
6751 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6752             Samuel Thibault  <samuel.thibault@gnu.org>
6753             Thomas Schwinge  <thomas@codesourcery.com>
6754
6755         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6756         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6757
6758 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6759
6760         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6761         (check_empty): Use "const char *".
6762
6763         * gnu-nat.c (gnu_nat_target::detach): Instead of
6764         'detach_inferior (pid)' call
6765         'detach_inferior (find_inferior_pid (pid))'.
6766
6767         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6768         'nat/fork-inferior.o'.
6769         * gnu-nat.c: #include "nat/fork-inferior.h".
6770
6771         * gnu-nat.c (gnu_nat_target::detach): Instead of
6772         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6773         * gnu-nat.h: #include "inf-child.h".
6774         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6775         'i386_gnu_nat_target::fetch_registers'.
6776         (gnu_store_registers): Rename/move to
6777         'i386_gnu_nat_target::store_registers'.
6778
6779         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6780         * gnu-nat.h (mach_thread_info): New function.
6781         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6782
6783         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6784
6785 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6786
6787         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6788
6789 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6790
6791         * windows-nat.c (windows_add_thread): Add new parameter
6792         "main_thread_p" with default value set to false.  Update
6793         function documentation as well as all callers.
6794         (windows_delete_thread): Likewise.
6795         (fake_create_process): Update call to windows_add_thread.
6796         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6797         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6798         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6799         call to windows_delete_thread.
6800
6801 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6802
6803         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6804
6805 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6806
6807         * symfile.c (find_separate_debug_file): Use canonical path of
6808         sysroot with child_path instead of gdb_sysroot if it is valid.
6809
6810 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6811
6812         * symfile.c (find_separate_debug_file): Use child_path to
6813         determine if an object file is under a sysroot.
6814
6815 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6816
6817         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6818         unittests/child-path-selftests.c.
6819         * common/pathstuff.c (child_path): New function.
6820         * common/pathstuff.h (child_path): New prototype.
6821         * unittests/child-path-selftests.c: New file.
6822
6823 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6824
6825         * symfile.c (find_separate_debug_file): Look for separate debug
6826         files in debug directories under the sysroot.
6827
6828 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6829
6830         * symtab.h (struct minimal_symbol data_p): New const method.
6831         (struct minimal_symbol text_p): Likewise.
6832         * symtab.c (output_source_filename): Use file name style
6833         to print file name.
6834         (print_symbol_info): Likewise.
6835         (print_msymbol_info): Use address style to print addresses.
6836         Use function name style to print executable text symbols.
6837         (expand_symtab_containing_pc): Use data_p.
6838         (find_pc_sect_compunit_symtab): Likewise.
6839
6840 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6841
6842         * breakpoint.c (describe_other_breakpoints): Use address style
6843         to print addresses.
6844         (say_where): Likewise.
6845
6846 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6847
6848         * ada-typeprint.c (print_func_type): Print function name
6849         style to print function name.
6850         * c-typeprint.c (c_print_type_1): Likewise.
6851
6852 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6853
6854         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6855         for execve.
6856
6857 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6858
6859         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6860         type_stack.
6861
6862 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6863
6864         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6865         TYPE_CODE_REF types.
6866
6867 2019-02-08  Jim Wilson  <jimw@sifive.com>
6868
6869         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6870         (riscv_linux_fregset): New.
6871         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6872
6873 2019-02-07  Tom Tromey  <tom@tromey.com>
6874
6875         * thread.c (thread_cancel_execution_command): Update.
6876         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6877         methods.
6878         (struct thread_fsm_ops): Remove.
6879         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6880         (thread_fsm_should_stop, thread_fsm_return_value)
6881         (thread_fsm_set_finished, thread_fsm_finished_p)
6882         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6883         Don't declare.
6884         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6885         * infrun.c (clear_proceed_status_thread)
6886         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6887         (print_stop_event): Update.
6888         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6889         Add constructor.
6890         (step_command_fsm_ops): Remove.
6891         (new_step_command_fsm): Remove.
6892         (step_1): Update.
6893         (step_command_fsm::should_stop): Rename from
6894         step_command_fsm_should_stop.
6895         (step_command_fsm::clean_up): Rename from
6896         step_command_fsm_clean_up.
6897         (step_command_fsm::do_async_reply_reason): Rename from
6898         step_command_fsm_async_reply_reason.
6899         (struct until_next_fsm): Inherit from thread_fsm.  Add
6900         constructor.
6901         (until_next_fsm_ops): Remove.
6902         (new_until_next_fsm): Remove.
6903         (until_next_fsm::should_stop): Rename from
6904         until_next_fsm_should_stop.
6905         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6906         (until_next_fsm::do_async_reply_reason): Rename from
6907         until_next_fsm_async_reply_reason.
6908         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6909         constructor.  Change type of breakpoint.
6910         (finish_command_fsm_ops): Remove.
6911         (new_finish_command_fsm): Remove.
6912         (finish_command_fsm::should_stop): Rename from
6913         finish_command_fsm_should_stop.
6914         (finish_command_fsm::clean_up): Rename from
6915         finish_command_fsm_clean_up.
6916         (finish_command_fsm::return_value): Rename from
6917         finish_command_fsm_return_value.
6918         (finish_command_fsm::do_async_reply_reason): Rename from
6919         finish_command_fsm_async_reply_reason.
6920         (finish_command): Update.
6921         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6922         Add constructor.
6923         (call_thread_fsm_ops): Remove.
6924         (call_thread_fsm::call_thread_fsm): Rename from
6925         new_call_thread_fsm.
6926         (call_thread_fsm::should_stop): Rename from
6927         call_thread_fsm_should_stop.
6928         (call_thread_fsm::should_notify_stop): Rename from
6929         call_thread_fsm_should_notify_stop.
6930         (run_inferior_call, call_function_by_hand_dummy): Update.
6931         * cli/cli-interp.c (should_print_stop_to_console): Update.
6932         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6933         Add constructor.  Change type of location_breakpoint,
6934         caller_breakpoint.
6935         (until_break_fsm_ops): Remove.
6936         (new_until_break_fsm): Remove.
6937         (until_break_fsm::should_stop): Rename from
6938         until_break_fsm_should_stop.
6939         (until_break_fsm::clean_up): Rename from
6940         until_break_fsm_clean_up.
6941         (until_break_fsm::do_async_reply_reason): Rename from
6942         until_break_fsm_async_reply_reason.
6943         (until_break_command): Update.
6944         * thread-fsm.c: Remove.
6945         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6946
6947 2019-02-07  Tom Tromey  <tom@tromey.com>
6948
6949         * yy-remap.h: Add include guard.
6950         * xtensa-tdep.h: Add include guard.
6951         * xcoffread.h: Rename include guard.
6952         * varobj-iter.h: Add include guard.
6953         * tui/tui.h: Rename include guard.
6954         * tui/tui-winsource.h: Rename include guard.
6955         * tui/tui-wingeneral.h: Rename include guard.
6956         * tui/tui-windata.h: Rename include guard.
6957         * tui/tui-win.h: Rename include guard.
6958         * tui/tui-stack.h: Rename include guard.
6959         * tui/tui-source.h: Rename include guard.
6960         * tui/tui-regs.h: Rename include guard.
6961         * tui/tui-out.h: Rename include guard.
6962         * tui/tui-layout.h: Rename include guard.
6963         * tui/tui-io.h: Rename include guard.
6964         * tui/tui-hooks.h: Rename include guard.
6965         * tui/tui-file.h: Rename include guard.
6966         * tui/tui-disasm.h: Rename include guard.
6967         * tui/tui-data.h: Rename include guard.
6968         * tui/tui-command.h: Rename include guard.
6969         * tic6x-tdep.h: Add include guard.
6970         * target/waitstatus.h: Rename include guard.
6971         * target/wait.h: Rename include guard.
6972         * target/target.h: Rename include guard.
6973         * target/resume.h: Rename include guard.
6974         * target-float.h: Rename include guard.
6975         * stabsread.h: Add include guard.
6976         * rs6000-tdep.h: Add include guard.
6977         * riscv-fbsd-tdep.h: Add include guard.
6978         * regformats/regdef.h: Rename include guard.
6979         * record.h: Rename include guard.
6980         * python/python.h: Rename include guard.
6981         * python/python-internal.h: Rename include guard.
6982         * python/py-stopevent.h: Rename include guard.
6983         * python/py-ref.h: Rename include guard.
6984         * python/py-record.h: Rename include guard.
6985         * python/py-record-full.h: Rename include guard.
6986         * python/py-record-btrace.h: Rename include guard.
6987         * python/py-instruction.h: Rename include guard.
6988         * python/py-events.h: Rename include guard.
6989         * python/py-event.h: Rename include guard.
6990         * procfs.h: Add include guard.
6991         * proc-utils.h: Add include guard.
6992         * p-lang.h: Add include guard.
6993         * or1k-tdep.h: Rename include guard.
6994         * observable.h: Rename include guard.
6995         * nto-tdep.h: Rename include guard.
6996         * nat/x86-linux.h: Rename include guard.
6997         * nat/x86-linux-dregs.h: Rename include guard.
6998         * nat/x86-gcc-cpuid.h: Add include guard.
6999         * nat/x86-dregs.h: Rename include guard.
7000         * nat/x86-cpuid.h: Rename include guard.
7001         * nat/ppc-linux.h: Rename include guard.
7002         * nat/mips-linux-watch.h: Rename include guard.
7003         * nat/linux-waitpid.h: Rename include guard.
7004         * nat/linux-ptrace.h: Rename include guard.
7005         * nat/linux-procfs.h: Rename include guard.
7006         * nat/linux-osdata.h: Rename include guard.
7007         * nat/linux-nat.h: Rename include guard.
7008         * nat/linux-namespaces.h: Rename include guard.
7009         * nat/linux-btrace.h: Rename include guard.
7010         * nat/glibc_thread_db.h: Rename include guard.
7011         * nat/gdb_thread_db.h: Rename include guard.
7012         * nat/gdb_ptrace.h: Rename include guard.
7013         * nat/fork-inferior.h: Rename include guard.
7014         * nat/amd64-linux-siginfo.h: Rename include guard.
7015         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7016         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7017         * nat/aarch64-linux.h: Rename include guard.
7018         * nat/aarch64-linux-hw-point.h: Rename include guard.
7019         * mn10300-tdep.h: Add include guard.
7020         * mips-linux-tdep.h: Add include guard.
7021         * mi/mi-parse.h: Rename include guard.
7022         * mi/mi-out.h: Rename include guard.
7023         * mi/mi-main.h: Rename include guard.
7024         * mi/mi-interp.h: Rename include guard.
7025         * mi/mi-getopt.h: Rename include guard.
7026         * mi/mi-console.h: Rename include guard.
7027         * mi/mi-common.h: Rename include guard.
7028         * mi/mi-cmds.h: Rename include guard.
7029         * mi/mi-cmd-break.h: Rename include guard.
7030         * m2-lang.h: Add include guard.
7031         * location.h: Rename include guard.
7032         * linux-record.h: Rename include guard.
7033         * linux-nat.h: Add include guard.
7034         * linux-fork.h: Add include guard.
7035         * i386-darwin-tdep.h: Rename include guard.
7036         * hppa-linux-offsets.h: Add include guard.
7037         * guile/guile.h: Rename include guard.
7038         * guile/guile-internal.h: Rename include guard.
7039         * gnu-nat.h: Rename include guard.
7040         * gdb-stabs.h: Rename include guard.
7041         * frv-tdep.h: Add include guard.
7042         * f-lang.h: Add include guard.
7043         * event-loop.h: Add include guard.
7044         * darwin-nat.h: Rename include guard.
7045         * cp-abi.h: Rename include guard.
7046         * config/sparc/nm-sol2.h: Rename include guard.
7047         * config/nm-nto.h: Rename include guard.
7048         * config/nm-linux.h: Add include guard.
7049         * config/i386/nm-i386gnu.h: Rename include guard.
7050         * config/djgpp/nl_types.h: Rename include guard.
7051         * config/djgpp/langinfo.h: Rename include guard.
7052         * compile/gcc-cp-plugin.h: Add include guard.
7053         * compile/gcc-c-plugin.h: Add include guard.
7054         * compile/compile.h: Rename include guard.
7055         * compile/compile-object-run.h: Rename include guard.
7056         * compile/compile-object-load.h: Rename include guard.
7057         * compile/compile-internal.h: Rename include guard.
7058         * compile/compile-cplus.h: Rename include guard.
7059         * compile/compile-c.h: Rename include guard.
7060         * common/xml-utils.h: Rename include guard.
7061         * common/x86-xstate.h: Rename include guard.
7062         * common/version.h: Rename include guard.
7063         * common/vec.h: Rename include guard.
7064         * common/tdesc.h: Rename include guard.
7065         * common/selftest.h: Rename include guard.
7066         * common/scoped_restore.h: Rename include guard.
7067         * common/scoped_mmap.h: Rename include guard.
7068         * common/scoped_fd.h: Rename include guard.
7069         * common/safe-iterator.h: Rename include guard.
7070         * common/run-time-clock.h: Rename include guard.
7071         * common/refcounted-object.h: Rename include guard.
7072         * common/queue.h: Rename include guard.
7073         * common/ptid.h: Rename include guard.
7074         * common/print-utils.h: Rename include guard.
7075         * common/preprocessor.h: Rename include guard.
7076         * common/pathstuff.h: Rename include guard.
7077         * common/observable.h: Rename include guard.
7078         * common/netstuff.h: Rename include guard.
7079         * common/job-control.h: Rename include guard.
7080         * common/host-defs.h: Rename include guard.
7081         * common/gdb_wait.h: Rename include guard.
7082         * common/gdb_vecs.h: Rename include guard.
7083         * common/gdb_unlinker.h: Rename include guard.
7084         * common/gdb_unique_ptr.h: Rename include guard.
7085         * common/gdb_tilde_expand.h: Rename include guard.
7086         * common/gdb_sys_time.h: Rename include guard.
7087         * common/gdb_string_view.h: Rename include guard.
7088         * common/gdb_splay_tree.h: Rename include guard.
7089         * common/gdb_setjmp.h: Rename include guard.
7090         * common/gdb_ref_ptr.h: Rename include guard.
7091         * common/gdb_optional.h: Rename include guard.
7092         * common/gdb_locale.h: Rename include guard.
7093         * common/gdb_assert.h: Rename include guard.
7094         * common/filtered-iterator.h: Rename include guard.
7095         * common/filestuff.h: Rename include guard.
7096         * common/fileio.h: Rename include guard.
7097         * common/environ.h: Rename include guard.
7098         * common/common-utils.h: Rename include guard.
7099         * common/common-types.h: Rename include guard.
7100         * common/common-regcache.h: Rename include guard.
7101         * common/common-inferior.h: Rename include guard.
7102         * common/common-gdbthread.h: Rename include guard.
7103         * common/common-exceptions.h: Rename include guard.
7104         * common/common-defs.h: Rename include guard.
7105         * common/common-debug.h: Rename include guard.
7106         * common/cleanups.h: Rename include guard.
7107         * common/buffer.h: Rename include guard.
7108         * common/btrace-common.h: Rename include guard.
7109         * common/break-common.h: Rename include guard.
7110         * cli/cli-utils.h: Rename include guard.
7111         * cli/cli-style.h: Rename include guard.
7112         * cli/cli-setshow.h: Rename include guard.
7113         * cli/cli-script.h: Rename include guard.
7114         * cli/cli-interp.h: Rename include guard.
7115         * cli/cli-decode.h: Rename include guard.
7116         * cli/cli-cmds.h: Rename include guard.
7117         * charset-list.h: Add include guard.
7118         * buildsym-legacy.h: Rename include guard.
7119         * bfin-tdep.h: Add include guard.
7120         * ax.h: Rename include guard.
7121         * arm-linux-tdep.h: Add include guard.
7122         * arm-fbsd-tdep.h: Add include guard.
7123         * arch/xtensa.h: Rename include guard.
7124         * arch/tic6x.h: Add include guard.
7125         * arch/i386.h: Add include guard.
7126         * arch/arm.h: Rename include guard.
7127         * arch/arm-linux.h: Rename include guard.
7128         * arch/arm-get-next-pcs.h: Rename include guard.
7129         * arch/amd64.h: Add include guard.
7130         * arch/aarch64-insn.h: Rename include guard.
7131         * arch-utils.h: Rename include guard.
7132         * annotate.h: Add include guard.
7133         * amd64-darwin-tdep.h: Rename include guard.
7134         * aarch64-linux-tdep.h: Add include guard.
7135         * aarch64-fbsd-tdep.h: Add include guard.
7136         * aarch32-linux-nat.h: Add include guard.
7137
7138 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7139
7140         * macrotab.c (macro_define_internal): New function that
7141         factorizes macro_define_object_internal and macro_define_function
7142         code.
7143         (macro_define_object_internal): Use macro_define_internal.
7144         (macro_define_function): Likewise.
7145
7146 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7147
7148         * macrocmd.c (extract_identifier): Return
7149         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7150         callers.
7151
7152 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7153
7154         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7155
7156 2019-02-05  Tom Tromey  <tom@tromey.com>
7157
7158         * target.c (target_stack::unpush): Move assertion earlier.
7159
7160 2019-01-30  Tom Tromey  <tom@tromey.com>
7161
7162         PR python/23615:
7163         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7164         (gdbpy_parse_and_eval): Likewise.
7165         * python/python-internal.h (gdbpy_allow_threads): New class.
7166
7167 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7168
7169         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7170         (aarch64_fbsd_fpregmap): Move earlier.
7171         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7172         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7173         instead of individual calls to trad_frame_set_reg_addr.
7174         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7175         earlier.
7176         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7177         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7178         instead of individual calls to trad_frame_set_reg_addr.
7179
7180 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7181
7182         * CONTRIBUTE: Replace contribution list with wiki link.
7183
7184 2019-01-25  Tom Tromey  <tom@tromey.com>
7185
7186         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7187
7188 2019-01-25  Tom Tromey  <tom@tromey.com>
7189
7190         * xtensa-linux-nat.c: Fix common/ includes.
7191         * xml-support.h: Fix common/ includes.
7192         * xml-support.c: Fix common/ includes.
7193         * x86-linux-nat.c: Fix common/ includes.
7194         * windows-nat.c: Fix common/ includes.
7195         * varobj.h: Fix common/ includes.
7196         * varobj.c: Fix common/ includes.
7197         * value.c: Fix common/ includes.
7198         * valops.c: Fix common/ includes.
7199         * utils.c: Fix common/ includes.
7200         * unittests/xml-utils-selftests.c: Fix common/ includes.
7201         * unittests/utils-selftests.c: Fix common/ includes.
7202         * unittests/unpack-selftests.c: Fix common/ includes.
7203         * unittests/tracepoint-selftests.c: Fix common/ includes.
7204         * unittests/style-selftests.c: Fix common/ includes.
7205         * unittests/string_view-selftests.c: Fix common/ includes.
7206         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7207         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7208         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7209         * unittests/rsp-low-selftests.c: Fix common/ includes.
7210         * unittests/parse-connection-spec-selftests.c: Fix common/
7211         includes.
7212         * unittests/optional-selftests.c: Fix common/ includes.
7213         * unittests/offset-type-selftests.c: Fix common/ includes.
7214         * unittests/observable-selftests.c: Fix common/ includes.
7215         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7216         * unittests/memrange-selftests.c: Fix common/ includes.
7217         * unittests/memory-map-selftests.c: Fix common/ includes.
7218         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7219         * unittests/function-view-selftests.c: Fix common/ includes.
7220         * unittests/environ-selftests.c: Fix common/ includes.
7221         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7222         * unittests/common-utils-selftests.c: Fix common/ includes.
7223         * unittests/cli-utils-selftests.c: Fix common/ includes.
7224         * unittests/array-view-selftests.c: Fix common/ includes.
7225         * ui-file.c: Fix common/ includes.
7226         * tui/tui-io.c: Fix common/ includes.
7227         * tracepoint.h: Fix common/ includes.
7228         * tracepoint.c: Fix common/ includes.
7229         * tracefile-tfile.c: Fix common/ includes.
7230         * top.h: Fix common/ includes.
7231         * top.c: Fix common/ includes.
7232         * thread.c: Fix common/ includes.
7233         * target/waitstatus.h: Fix common/ includes.
7234         * target/waitstatus.c: Fix common/ includes.
7235         * target.h: Fix common/ includes.
7236         * target.c: Fix common/ includes.
7237         * target-memory.c: Fix common/ includes.
7238         * target-descriptions.c: Fix common/ includes.
7239         * symtab.h: Fix common/ includes.
7240         * symfile.c: Fix common/ includes.
7241         * stap-probe.c: Fix common/ includes.
7242         * spu-linux-nat.c: Fix common/ includes.
7243         * sparc-nat.c: Fix common/ includes.
7244         * source.c: Fix common/ includes.
7245         * solib.c: Fix common/ includes.
7246         * solib-target.c: Fix common/ includes.
7247         * ser-unix.c: Fix common/ includes.
7248         * ser-tcp.c: Fix common/ includes.
7249         * ser-pipe.c: Fix common/ includes.
7250         * ser-base.c: Fix common/ includes.
7251         * selftest-arch.c: Fix common/ includes.
7252         * s12z-tdep.c: Fix common/ includes.
7253         * rust-exp.y: Fix common/ includes.
7254         * rs6000-aix-tdep.c: Fix common/ includes.
7255         * riscv-tdep.c: Fix common/ includes.
7256         * remote.c: Fix common/ includes.
7257         * remote-notif.h: Fix common/ includes.
7258         * remote-fileio.h: Fix common/ includes.
7259         * remote-fileio.c: Fix common/ includes.
7260         * regcache.h: Fix common/ includes.
7261         * regcache.c: Fix common/ includes.
7262         * record-btrace.c: Fix common/ includes.
7263         * python/python.c: Fix common/ includes.
7264         * python/py-type.c: Fix common/ includes.
7265         * python/py-inferior.c: Fix common/ includes.
7266         * progspace.h: Fix common/ includes.
7267         * producer.c: Fix common/ includes.
7268         * procfs.c: Fix common/ includes.
7269         * proc-api.c: Fix common/ includes.
7270         * printcmd.c: Fix common/ includes.
7271         * ppc-linux-nat.c: Fix common/ includes.
7272         * parser-defs.h: Fix common/ includes.
7273         * osdata.c: Fix common/ includes.
7274         * obsd-nat.c: Fix common/ includes.
7275         * nat/x86-linux.c: Fix common/ includes.
7276         * nat/x86-linux-dregs.c: Fix common/ includes.
7277         * nat/x86-dregs.h: Fix common/ includes.
7278         * nat/x86-dregs.c: Fix common/ includes.
7279         * nat/ppc-linux.c: Fix common/ includes.
7280         * nat/mips-linux-watch.h: Fix common/ includes.
7281         * nat/mips-linux-watch.c: Fix common/ includes.
7282         * nat/linux-waitpid.c: Fix common/ includes.
7283         * nat/linux-ptrace.h: Fix common/ includes.
7284         * nat/linux-ptrace.c: Fix common/ includes.
7285         * nat/linux-procfs.c: Fix common/ includes.
7286         * nat/linux-personality.c: Fix common/ includes.
7287         * nat/linux-osdata.c: Fix common/ includes.
7288         * nat/linux-namespaces.c: Fix common/ includes.
7289         * nat/linux-btrace.h: Fix common/ includes.
7290         * nat/linux-btrace.c: Fix common/ includes.
7291         * nat/fork-inferior.c: Fix common/ includes.
7292         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7293         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7294         * nat/aarch64-linux.c: Fix common/ includes.
7295         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7296         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7297         * namespace.h: Fix common/ includes.
7298         * mips-linux-tdep.c: Fix common/ includes.
7299         * minsyms.c: Fix common/ includes.
7300         * mi/mi-parse.h: Fix common/ includes.
7301         * mi/mi-main.c: Fix common/ includes.
7302         * mi/mi-cmd-env.c: Fix common/ includes.
7303         * memrange.h: Fix common/ includes.
7304         * memattr.c: Fix common/ includes.
7305         * maint.h: Fix common/ includes.
7306         * maint.c: Fix common/ includes.
7307         * main.c: Fix common/ includes.
7308         * machoread.c: Fix common/ includes.
7309         * location.c: Fix common/ includes.
7310         * linux-thread-db.c: Fix common/ includes.
7311         * linux-nat.c: Fix common/ includes.
7312         * linux-fork.c: Fix common/ includes.
7313         * inline-frame.c: Fix common/ includes.
7314         * infrun.c: Fix common/ includes.
7315         * inflow.c: Fix common/ includes.
7316         * inferior.h: Fix common/ includes.
7317         * inferior.c: Fix common/ includes.
7318         * infcmd.c: Fix common/ includes.
7319         * inf-ptrace.c: Fix common/ includes.
7320         * inf-child.c: Fix common/ includes.
7321         * ia64-linux-nat.c: Fix common/ includes.
7322         * i387-tdep.c: Fix common/ includes.
7323         * i386-tdep.c: Fix common/ includes.
7324         * i386-linux-tdep.c: Fix common/ includes.
7325         * i386-linux-nat.c: Fix common/ includes.
7326         * i386-go32-tdep.c: Fix common/ includes.
7327         * i386-fbsd-tdep.c: Fix common/ includes.
7328         * i386-fbsd-nat.c: Fix common/ includes.
7329         * guile/scm-type.c: Fix common/ includes.
7330         * guile/guile.c: Fix common/ includes.
7331         * go32-nat.c: Fix common/ includes.
7332         * gnu-nat.c: Fix common/ includes.
7333         * gdbthread.h: Fix common/ includes.
7334         * gdbarch-selftests.c: Fix common/ includes.
7335         * gdb_usleep.c: Fix common/ includes.
7336         * gdb_select.h: Fix common/ includes.
7337         * gdb_bfd.c: Fix common/ includes.
7338         * gcore.c: Fix common/ includes.
7339         * fork-child.c: Fix common/ includes.
7340         * findvar.c: Fix common/ includes.
7341         * fbsd-nat.c: Fix common/ includes.
7342         * event-top.c: Fix common/ includes.
7343         * event-loop.c: Fix common/ includes.
7344         * dwarf2read.c: Fix common/ includes.
7345         * dwarf2loc.c: Fix common/ includes.
7346         * dwarf2-frame.c: Fix common/ includes.
7347         * dwarf-index-cache.c: Fix common/ includes.
7348         * dtrace-probe.c: Fix common/ includes.
7349         * disasm-selftests.c: Fix common/ includes.
7350         * defs.h: Fix common/ includes.
7351         * csky-tdep.c: Fix common/ includes.
7352         * cp-valprint.c: Fix common/ includes.
7353         * cp-support.h: Fix common/ includes.
7354         * cp-support.c: Fix common/ includes.
7355         * corelow.c: Fix common/ includes.
7356         * completer.h: Fix common/ includes.
7357         * completer.c: Fix common/ includes.
7358         * compile/compile.c: Fix common/ includes.
7359         * compile/compile-loc2c.c: Fix common/ includes.
7360         * compile/compile-cplus-types.c: Fix common/ includes.
7361         * compile/compile-cplus-symbols.c: Fix common/ includes.
7362         * command.h: Fix common/ includes.
7363         * cli/cli-dump.c: Fix common/ includes.
7364         * cli/cli-cmds.c: Fix common/ includes.
7365         * charset.c: Fix common/ includes.
7366         * build-id.c: Fix common/ includes.
7367         * btrace.h: Fix common/ includes.
7368         * btrace.c: Fix common/ includes.
7369         * breakpoint.h: Fix common/ includes.
7370         * breakpoint.c: Fix common/ includes.
7371         * ax.h:
7372         (enum agent_op): Fix common/ includes.
7373         * ax-general.c (struct aop_map): Fix common/ includes.
7374         * ax-gdb.c: Fix common/ includes.
7375         * auxv.c: Fix common/ includes.
7376         * auto-load.c: Fix common/ includes.
7377         * arm-tdep.c: Fix common/ includes.
7378         * arch/riscv.c: Fix common/ includes.
7379         * arch/ppc-linux-common.c: Fix common/ includes.
7380         * arch/i386.c: Fix common/ includes.
7381         * arch/arm.c: Fix common/ includes.
7382         * arch/arm-linux.c: Fix common/ includes.
7383         * arch/arm-get-next-pcs.c: Fix common/ includes.
7384         * arch/amd64.c: Fix common/ includes.
7385         * arch/aarch64.c: Fix common/ includes.
7386         * arch/aarch64-insn.c: Fix common/ includes.
7387         * arch-utils.c: Fix common/ includes.
7388         * amd64-windows-tdep.c: Fix common/ includes.
7389         * amd64-tdep.c: Fix common/ includes.
7390         * amd64-sol2-tdep.c: Fix common/ includes.
7391         * amd64-obsd-tdep.c: Fix common/ includes.
7392         * amd64-nbsd-tdep.c: Fix common/ includes.
7393         * amd64-linux-tdep.c: Fix common/ includes.
7394         * amd64-linux-nat.c: Fix common/ includes.
7395         * amd64-fbsd-tdep.c: Fix common/ includes.
7396         * amd64-fbsd-nat.c: Fix common/ includes.
7397         * amd64-dicos-tdep.c: Fix common/ includes.
7398         * amd64-darwin-tdep.c: Fix common/ includes.
7399         * agent.c: Fix common/ includes.
7400         * ada-lang.h: Fix common/ includes.
7401         * ada-lang.c: Fix common/ includes.
7402         * aarch64-tdep.c: Fix common/ includes.
7403
7404 2019-01-25  Tom Tromey  <tom@tromey.com>
7405
7406         * common/create-version.sh: Use common/version.h.
7407
7408 2019-01-24  Pedro Alves  <palves@redhat.com>
7409
7410         * infrun.c (signal_stop, signal_print, signal_program)
7411         (signal_catch, signal_pass): Now arrays instead of pointers.
7412         (update_signals_program_target, do_target_resume)
7413         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7414         * linux-nat.c (linux_nat_target::pass_signals)
7415         (linux_nat_target::create_inferior, linux_nat_target::attach):
7416         Adjust.
7417         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7418         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7419         * procfs.c (procfs_target::pass_signals): Adjust.
7420         * record-full.c (record_full_target::resume): Adjust.
7421         * remote.c (remote_target::pass_signals)
7422         (remote_target::program_signals): Adjust.
7423         * target-debug.h (target_debug_print_signals): Now takes a
7424         gdb::array_view as parameter.  Adjust.
7425         * target.h (target_ops) <pass_signals, program_signals>: Replace
7426         pointer and length parameters with gdb::array_view.
7427         (target_pass_signals, target_program_signals): Likewise.
7428         * target-delegates.c: Regenerate.
7429
7430 2019-01-24  Pedro Alves  <palves@redhat.com>
7431
7432         * common/forward-scope-exit.h
7433         (forward_scope_exit::forward_scope_exit): Pass arguments to
7434         m_bind_function directly, instead of creating a std::bind and
7435         copying that.
7436
7437 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7438
7439         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7440         for static members.
7441         (pass_in_v_vfp_candidate): Likewise.
7442
7443 2019-01-23  Tom Tromey  <tom@tromey.com>
7444             Pedro Alves  <palves@redhat.com>
7445
7446         * regcache.c (class regcache_invalidator): Remove.
7447         (regcache::raw_write): Use make_scope_exit.
7448
7449 2019-01-23  Tom Tromey  <tom@tromey.com>
7450
7451         * ui-out.h (class ui_out_emit_type): Update comment.
7452
7453 2019-01-23  Tom Tromey  <tom@tromey.com>
7454
7455         * infrun.c (fetch_inferior_event): Update comment.
7456
7457 2019-01-23  Tom Tromey  <tom@tromey.com>
7458             Pedro Alves  <palves@redhat.com>
7459
7460         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7461         parameter.
7462         (fetch_inferior_event): Use SCOPE_EXIT.
7463
7464
7465 2019-01-23  Tom Tromey  <tom@tromey.com>
7466             Pedro Alves  <palves@redhat.com>
7467
7468         * infrun.c (disable_thread_events): Delete.
7469         (stop_all_threads): Use SCOPE_EXIT.
7470
7471 2019-01-23  Tom Tromey  <tom@tromey.com>
7472             Pedro Alves  <palves@redhat.com>
7473
7474         * symfile.c: Include forward-scope-exit.h.
7475         (clear_symtab_users_cleanup): Replace forward declaration with
7476         a FORWARD_SCOPE_EXIT.
7477         (syms_from_objfile_1): Use the forward_scope_exit and
7478         gdb::optional instead of cleanup_function.
7479         (reread_symbols): Use the forward_scope_exit instead of
7480         cleanup_function.
7481         (clear_symtab_users_cleanup): Remove function.
7482
7483 2019-01-23  Tom Tromey  <tom@tromey.com>
7484             Pedro Alves  <palves@redhat.com>
7485
7486         * linux-nat.c: Include scope-exit.h.
7487         (cleanup_target_stop): Remove.
7488         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7489         SCOPE_EXIT.
7490
7491 2019-01-23  Tom Tromey  <tom@tromey.com>
7492             Pedro Alves  <palves@redhat.com>
7493
7494         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7495         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7496
7497 2019-01-23  Tom Tromey  <tom@tromey.com>
7498             Andrew Burgess  <andrew.burgess@embecosm.com>
7499             Pedro Alves  <palves@redhat.com>
7500
7501         * infrun.c (fetch_inferior_event): Use scope_exit.
7502         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7503         * top.c (execute_command): Use scope_exit.
7504         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7505         * utils.c (do_bpstat_clear_actions_cleanup)
7506         (make_bpstat_clear_actions_cleanup): Remove.
7507
7508 2019-01-23  Tom Tromey  <tom@tromey.com>
7509             Pedro Alves  <palves@redhat.com>
7510
7511         * infrun.c: Include "common/scope-exit.h"
7512         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7513         (wait_for_inferior): Use SCOPE_EXIT.
7514         (fetch_inferior_event): Use scope_exit.
7515
7516 2019-01-23  Tom Tromey  <tom@tromey.com>
7517             Pedro Alves  <palves@redhat.com>
7518
7519         * breakpoint.c (create_breakpoint): Remove cleanup.
7520
7521 2019-01-23  Tom Tromey  <tom@tromey.com>
7522             Andrew Burgess  <andrew.burgess@embecosm.com>
7523             Pedro Alves  <palves@redhat.com>
7524
7525 2019-01-23  Pedro Alves  <palves@redhat.com>
7526
7527         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7528
7529 2019-01-23  Pedro Alves  <palves@redhat.com>
7530             Andrew Burgess  <andrew.burgess@embecosm.com>
7531
7532         * gdbthread.h: Include "common/forward-scope-exit.h".
7533         (scoped_finish_thread_state): Redefine custom class in terms of
7534         forward_scope_exit.
7535
7536 2019-01-23  Pedro Alves  <palves@redhat.com>
7537             Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * common/forward-scope-exit.h: New file.
7540
7541 2019-01-23  Pedro Alves  <palves@redhat.com>
7542             Andrew Burgess  <andrew.burgess@embecosm.com>
7543             Tom Tromey  <tom@tromey.com>
7544
7545         * common/scope-exit.h: New file.
7546
7547 2019-01-23  Pedro Alves  <palves@redhat.com>
7548
7549         * common/preprocessor.h (ESC): Rename to ...
7550         (ESC_PARENS): ... this.
7551         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7552         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7553
7554 2019-01-23  Tom Tromey  <tom@tromey.com>
7555
7556         * language.h (class scoped_switch_to_sym_language_if_auto):
7557         Initialize m_lang in both cases.
7558
7559 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7560
7561         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7562         with XCNEW.
7563
7564 2019-01-22  Tom Tromey  <tom@tromey.com>
7565
7566         * corelow.c: Do not include sys/file.h.
7567
7568 2019-01-22  Tom Tromey  <tom@tromey.com>
7569
7570         * tui/tui-wingeneral.h: Include gdb_curses.h.
7571
7572 2019-01-22  Tom Tromey  <tom@tromey.com>
7573
7574         * source-cache.h (class source_cache) <get_source_lines,
7575         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7576
7577 2019-01-22  Tom Tromey  <tom@tromey.com>
7578
7579         * remote-fileio.h (struct remote_target): Declare.
7580
7581 2019-01-22  Tom Tromey  <tom@tromey.com>
7582
7583         * python/py-arch.c: Do not include py-ref.h.
7584         * python/py-bpevent.c: Do not include py-ref.h.
7585         * python/py-cmd.c: Do not include py-ref.h.
7586         * python/py-continueevent.c: Do not include py-ref.h.
7587         * python/py-event.h: Do not include py-ref.h.
7588         * python/py-evtregistry.c: Do not include py-ref.h.
7589         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7590         * python/py-frame.c: Do not include py-ref.h.
7591         * python/py-framefilter.c: Do not include py-ref.h.
7592         * python/py-function.c: Do not include py-ref.h.
7593         * python/py-infevents.c: Do not include py-ref.h.
7594         * python/py-linetable.c: Do not include py-ref.h.
7595         * python/py-objfile.c: Do not include py-ref.h.
7596         * python/py-param.c: Do not include py-ref.h.
7597         * python/py-prettyprint.c: Do not include py-ref.h.
7598         * python/py-progspace.c: Do not include py-ref.h.
7599         * python/py-symbol.c: Do not include py-ref.h.
7600         * python/py-symtab.c: Do not include py-ref.h.
7601         * python/py-type.c: Do not include py-ref.h.
7602         * python/py-unwind.c: Do not include py-ref.h.
7603         * python/py-utils.c: Do not include py-ref.h.
7604         * python/py-value.c: Do not include py-ref.h.
7605         * python/py-varobj.c: Do not include py-ref.h.
7606         * python/py-xmethods.c: Do not include py-ref.h.
7607         * python/python.c: Do not include py-ref.h.
7608         * varobj.c: Do not include py-ref.h.
7609
7610 2019-01-22  Tom Tromey  <tom@tromey.com>
7611
7612         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7613         keyword for bcache.
7614
7615 2019-01-22  Tom Tromey  <tom@tromey.com>
7616
7617         * compile/compile-cplus-types.c: Remove a comment by #include.
7618
7619 2019-01-22  Tom Tromey  <tom@tromey.com>
7620
7621         * compile/gcc-c-plugin.h: Include compile-internal.h.
7622
7623 2019-01-22  Tom Tromey  <tom@tromey.com>
7624
7625         * stabsread.c (EXTERN): Do not define.
7626         (symnum, next_symbol_text_func, processing_gcc_compilation)
7627         (within_function, global_sym_chain, global_stabs)
7628         (previous_stab_code, this_object_header_files)
7629         (n_this_object_header_files)
7630         (n_allocated_this_object_header_files): Define.
7631         * stabsread.h (EXTERN): Never define.  Use "extern".
7632
7633 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7634
7635         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7636         history_value.
7637
7638 2019-01-21  Tom Tromey  <tom@tromey.com>
7639
7640         * ui-out.c: Fix includes.
7641         * tui/tui-source.c: Fix includes.
7642         * target.c: Fix includes.
7643         * remote.c: Fix includes.
7644         * regcache.c: Fix includes.
7645         * python/py-block.c: Fix includes.
7646         * printcmd.c: Fix includes.
7647         * or1k-tdep.c: Fix includes.
7648         * mi/mi-main.c: Fix includes.
7649         * m32r-tdep.c: Fix includes.
7650         * csky-tdep.c: Fix includes.
7651         * compile/compile-cplus-types.c: Fix includes.
7652         * cli/cli-interp.c: Fix includes.
7653
7654 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7657         for padding.
7658
7659 2019-01-16  Tom Tromey  <tom@tromey.com>
7660
7661         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7662         earlier.
7663         (struct objfile) <msymbols_range>: Move from top level.
7664         <msymbols>: New method.
7665         (class objfile_msymbols): Remove.
7666         * symtab.c (default_collect_symbol_completion_matches_break_on):
7667         Update.
7668         * symmisc.c (dump_msymbols): Update.
7669         * stabsread.c (scan_file_globals): Update.
7670         * objc-lang.c (info_selectors_command, info_classes_command)
7671         (find_methods): Update.
7672         * minsyms.c (find_solib_trampoline_target): Update.
7673         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7674         * coffread.c (coff_symfile_read): Update.
7675         * ada-lang.c (ada_lookup_simple_minsym)
7676         (ada_collect_symbol_completion_matches): Update.
7677
7678 2019-01-16  Tom Tromey  <tom@tromey.com>
7679
7680         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7681         type.  Remove no-argument constructor.
7682         <iterator::operator++>: Simplify.
7683         <begin>: Update.
7684         <end>: Use minimal_symbol_count.
7685
7686 2019-01-16  Tom Tromey  <tom@tromey.com>
7687
7688         * objfiles.h (struct objfile) <psymtabs>: New method.
7689         (class objfile_psymtabs): Remove.
7690         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7691         typedef.
7692         <range>: New method.
7693         (require_partial_symbols): Change return type.
7694         * psymtab.c (require_partial_symbols)
7695         (psym_expand_symtabs_matching): Update.
7696         * mdebugread.c (parse_partial_symbols): Update.
7697         * dbxread.c (dbx_end_psymtab): Update.
7698
7699 2019-01-15  Tom Tromey  <tom@tromey.com>
7700
7701         * symtab.c (lookup_objfile_from_block)
7702         (lookup_symbol_in_objfile_symtabs)
7703         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7704         (find_line_symtab, info_sources_command)
7705         (default_collect_symbol_completion_matches_break_on)
7706         (make_source_files_completion_list): Update.
7707         * symmisc.c (print_objfile_statistics, dump_objfile)
7708         (maintenance_print_symbols, maintenance_info_symtabs)
7709         (maintenance_check_symtabs, maintenance_info_line_tables):
7710         Update.
7711         * source.c (select_source_symtab)
7712         (forget_cached_source_info_for_objfile): Update.
7713         * objfiles.h (class objfile_compunits): Remove.
7714         (struct objfile) <compunits_range>: New typedef.
7715         (compunits): New method.
7716         * objfiles.c (objfile_relocate1): Update.
7717         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7718         * maint.c (count_symtabs_and_blocks): Update.
7719         * linespec.c (iterate_over_all_matching_symtabs): Update.
7720         * cp-support.c (add_symbol_overload_list_qualified): Update.
7721         * coffread.c (coff_symtab_read): Update.
7722         * ada-lang.c (add_nonlocal_symbols)
7723         (ada_collect_symbol_completion_matches)
7724         (ada_add_global_exceptions): Update.
7725
7726 2019-01-15  Tom Tromey  <tom@tromey.com>
7727
7728         * progspace.h (program_space) <objfiles_safe_range>: New
7729         typedef.
7730         <objfiles_safe>: New method.
7731         * objfiles.h (class all_objfiles_safe): Remove.
7732         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7733         * jit.c (jit_inferior_exit_hook): Update.
7734
7735 2019-01-17  Tom Tromey  <tom@tromey.com>
7736
7737         * progspace.h (program_space) <objfiles_range>: New typedef.
7738         <objfiles>: New method.
7739         <objfiles_head>: Rename from objfiles.
7740         (object_files): Update.
7741         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7742         * guile/scm-pretty-print.c
7743         (ppscm_find_pretty_printer_from_objfiles): Update.
7744         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7745         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7746         Update.
7747         * python/py-progspace.c (pspy_get_objfiles): Update.
7748         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7749         Update.
7750         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7751         (objfpy_lookup_objfile_by_build_id): Update.
7752         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7753         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7754         Update.
7755         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7756         (expand_symtab_containing_pc, lookup_objfile_from_block)
7757         (lookup_static_symbol, basic_lookup_transparent_type)
7758         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7759         (find_line_symtab, info_sources_command)
7760         (default_collect_symbol_completion_matches_break_on)
7761         (make_source_files_completion_list, find_main_name): Update.
7762         * symmisc.c (print_symbol_bcache_statistics)
7763         (print_objfile_statistics, maintenance_print_symbols)
7764         (maintenance_print_msymbols, maintenance_print_objfiles)
7765         (maintenance_info_symtabs, maintenance_check_symtabs)
7766         (maintenance_expand_symtabs, maintenance_info_line_tables):
7767         Update.
7768         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7769         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7770         (map_overlay_command, unmap_overlay_command)
7771         (simple_overlay_update, expand_symtabs_matching)
7772         (map_symbol_filenames): Update.
7773         * symfile-debug.c (set_debug_symfile): Update.
7774         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7775         Update.
7776         * source.c (select_source_symtab, forget_cached_source_info):
7777         Update.
7778         * solib.c (solib_read_symbols): Update.
7779         * solib-spu.c (append_ocl_sos): Update.
7780         * psymtab.c (maintenance_print_psymbols)
7781         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7782         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7783         * printcmd.c (info_symbol_command): Update.
7784         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7785         Update.
7786         * objfiles.h (class all_objfiles): Remove.
7787         * objfiles.c (have_partial_symbols, have_full_symbols)
7788         (have_minimal_symbols, qsort_cmp, update_section_map)
7789         (shared_objfile_contains_address_p)
7790         (default_iterate_over_objfiles_in_search_order): Update.
7791         * objc-lang.c (info_selectors_command, info_classes_command)
7792         (find_methods): Update.
7793         * minsyms.c (find_solib_trampoline_target): Update.
7794         * maint.c (maintenance_info_sections)
7795         (maintenance_translate_address, count_symtabs_and_blocks):
7796         Update.
7797         * main.c (captured_main_1): Update.
7798         * linux-thread-db.c (try_thread_db_load_from_pdir)
7799         (has_libpthread): Update.
7800         * linespec.c (iterate_over_all_matching_symtabs)
7801         (search_minsyms_for_name): Update.
7802         * jit.c (jit_find_objf_with_entry_addr): Update.
7803         * hppa-tdep.c (find_unwind_entry)
7804         (hppa_lookup_stub_minimal_symbol): Update.
7805         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7806         Update.
7807         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7808         (elf_gnu_ifunc_resolve_by_got): Update.
7809         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7810         * dwarf-index-write.c (save_gdb_index_command): Update.
7811         * cp-support.c (add_symbol_overload_list_qualified): Update.
7812         * breakpoint.c (create_overlay_event_breakpoint)
7813         (create_longjmp_master_breakpoint)
7814         (create_std_terminate_master_breakpoint)
7815         (create_exception_master_breakpoint): Update.
7816         * blockframe.c (find_pc_partial_function): Update.
7817         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7818         (ada_collect_symbol_completion_matches)
7819         (ada_add_global_exceptions): Update.
7820
7821 2019-01-17  Tom Tromey  <tom@tromey.com>
7822
7823         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7824         declare VEC.
7825         (solib_target_parse_libraries): Change return type.
7826         (library_list_start_segment, library_list_start_section)
7827         (library_list_end_library, library_list_start_library); Update.
7828         (solib_target_free_library_list): Remove.
7829         (solib_target_parse_libraries): Remove cleanup.  Change return
7830         type.
7831         (solib_target_current_sos): Update.
7832
7833 2019-01-17  Tom Tromey  <tromey@bapiya>
7834
7835         * valprint.c: Replace "the the" with "the".
7836         * symtab.c: Replace "the the" with "the".
7837         * solib.c: Replace "the the" with "the".
7838         * solib-dsbt.c: Replace "the the" with "the".
7839         * linespec.c: Replace "the the" with "the".
7840         * dwarf2loc.h: Replace "the the" with "the".
7841         * amd64-windows-tdep.c: Replace "the the" with "the".
7842         * aarch64-tdep.c: Replace "the the" with "the".
7843
7844 2019-01-16  Keith Seitz  <keiths@redhat.com>
7845
7846         PR gdb/23773
7847         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7848         <builder>: Rename to ..
7849         <m_builder>: ... this and make private.
7850         (dwarf2_cu::get_builder): New method.  Change all users of
7851         `builder' to use this method.
7852         (dwarf2_start_symtab): Move to ...
7853         (dwarf2_cu::start_symtab): ... here.  Update all callers
7854         (setup_type_unit_groups): Move to ...
7855         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7856         callers.
7857         (dwarf2_cu::reset_builder): New method.
7858         (process_full_compunit, process_full_type_unit): Use
7859         dwarf2_cu::reset_builder.
7860         (follow_die_offset): Record the ancestor CU if it is different
7861         from the followed DIE's CU.
7862         (follow_die_sig_1): Likewise.
7863
7864 2019-01-15  Tom Tromey  <tom@tromey.com>
7865
7866         * remote.c (class remote_state) <buf>: Now a char_vector.
7867         <buf_size>: Remove.
7868         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7869         parameter.
7870         (remote_target::getpkt_or_notif_sane_1)
7871         (remote_target::getpkt_sane)
7872         (remote_target::getpkt_or_notif_sane): Likewise.
7873         (class remote_target) <putpkt>: New overload.
7874         (remote_target::read_frame): Change type of "buf_p".  Remove
7875         sizeof_p parameter.
7876         (packet_ok): New overload.
7877         (packet_check_result): New overload.
7878         Update all uses.
7879
7880 2019-01-14  Tom Tromey  <tom@tromey.com>
7881
7882         * remote-notif.c (handle_notification, remote_notif_ack)
7883         (remote_notif_parse): Make "buf" const.
7884         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7885         const.
7886         (remote_notif_parse, remote_notif_ack, handle_notification):
7887         Likewise.
7888         * remote.c (remote_notif_stop_parse): Make "buf" const.
7889         (remote_target::remote_parse_stop_reply): Make "buf" const.
7890         (remote_notif_stop_ack): Make "buf" const.
7891
7892 2019-01-14  Tom Tromey  <tom@tromey.com>
7893
7894         * remote.c (remote_console_output): Make parameter const.
7895
7896 2019-01-14  Tom Tromey  <tom@tromey.com>
7897
7898         * target-debug.h (target_debug_print_signals): Constify.
7899         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7900         * procfs.c (procfs_target::pass_signals): Update.
7901         * linux-nat.c (linux_nat_target::pass_signals): Update.
7902         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7903         * target-delegates.c: Rebuild.
7904         * remote.c (remote_target::program_signals): Update.
7905         (remote_target::pass_signals): Update.
7906         * target.c (target_pass_signals): Constify argument.
7907         (target_program_signals): Likewise.
7908         * target.h (struct target_ops) <pass_signals, program_signals>:
7909         Constify argument.
7910         (target_pass_signals, target_program_signals): Constify argument.
7911
7912 2019-01-14  Tom Tromey  <tom@tromey.com>
7913
7914         PR tui/28819:
7915         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7916
7917 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7918
7919         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7920         field.
7921         * rs6000-tdep.c: Include reggroups.h.
7922         (IS_V_ALIAS_PSEUDOREG): Define.
7923         (rs6000_register_name): Return names for the "vX" aliases.
7924         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7925         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7926         aliases.  Call default_register_reggroup_p for all other
7927         pseudo-registers.
7928         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7929         New functions.
7930         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7931         Handle "vX" aliases.
7932         (v_alias_pseudo_register_collect): New function.
7933         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7934         (rs6000_gdbarch_init): Initialize "vX" aliases as
7935         pseudo-registers.  Restore registration of
7936         rs6000_pseudo_register_reggroup_p with
7937         set_tdesc_pseudo_register_reggroup_p.
7938
7939 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7940
7941         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7942         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7943         set_gdbarch_num_pseudo_regs.
7944
7945 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7946
7947         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7948         Remove arg prefixname, add do_set and do_show.
7949         Add member functions set_list and show_list.
7950         * cli/cli-style.c (class cli_style_option): Update accordingly.
7951         (style_set_list): Move to file scope.
7952         (style_show_list): Likewise.
7953         (set_style): Call help_list.
7954         (show_style): Call cmd_show_list.
7955         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7956         Update to use the new macro.
7957
7958 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7959
7960         * ada-lang.c (_initialize_ada_language): Expand the help text
7961         for the "catch exception" command.
7962
7963 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964
7965         * symtab.c (matching_obj_sections): Initialize obj,
7966         declare it closer to its usage.
7967
7968 2019-01-10  Tom Tromey  <tom@tromey.com>
7969
7970         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7971         (basic_inf_threads_range): Remove.
7972         (inf_threads_range, inf_non_exited_threads_range)
7973         (safe_inf_threads_range): Use next_adapter.
7974
7975 2019-01-10  Keith Seitz  <keiths@redhat.com>
7976
7977         PR gdb/23712
7978         PR symtab/23010
7979         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7980         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7981
7982 2019-01-10  Keith Seitz  <keiths@redhat.com>
7983
7984         PR gdb/23712
7985         PR symtab/23010
7986         * dictionary.c (pending_to_vector): Remove.
7987         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7988         Remove _1 suffix, replacing functions of the same name.  Update
7989         all callers.
7990         (dict_create_hashed, dict_create_hashed_expandable)
7991         (dict_create_linear, dict_create_linear_expandable, dict_free)
7992         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7993         Make functions static.
7994
7995 2019-01-10  Keith Seitz  <keiths@redhat.com>
7996
7997         PR gdb/23712
7998         PR symtab/23010
7999         * dictionary.h (struct dictionary): Replace declaration with
8000         multidictionary.
8001         (dict_create_hashed, dict_create_hashed_expandable)
8002         (dict_create_linear, dict_create_linear_expandable)
8003         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8004         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8005         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8006         taking multidictionary argument.
8007         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8008         * block.h (struct block) <dict>: Change to multidictionary
8009         and rename `multidict'.
8010         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8011         symmisc.c: Update all dictionary references to multidictionary.
8012
8013 2019-01-10  Keith Seitz  <keiths@redhat.com>
8014
8015         PR gdb/23712
8016         PR symtab/23010
8017         * dictionary.c: Include unordered_map.
8018         (pending_to_vector): New function.
8019         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8020         Rewrite the non-"_1" functions to take vector instead
8021         of linked list.
8022         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8023         "new" _1 versions of the same name.
8024         (multidictionary): Define.
8025         (std::hash<enum language): New definition.
8026         (collate_pending_symbols_by_language, mdict_create_hashed)
8027         (mdict_create_hashed_expandable, mdict_create_linear)
8028         (mdict_create_linear_expandable, mdict_free)
8029         (find_language_dictionary, create_new_language_dictionary)
8030         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8031         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8032         (mdict_size, mdict_empty): New functions.
8033         * dictionary.h (mdict_iterator): Define.
8034
8035 2019-01-10  Pedro Alves  <palves@redhat.com>
8036
8037         * breakpoint.c (read_uploaded_action)
8038         (create_tracepoint_from_upload): Adjust to use
8039         gdb::unique_xmalloc_ptr.
8040         * ctf.c (ctf_write_uploaded_tp):
8041         (SET_ARRAY_FIELD): Use emplace_back.
8042         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8043         * tracefile-tfile.c (tfile_write_uploaded_tp):
8044         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8045         gdb::unique_xmalloc_ptr.
8046         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8047         at_string, cond_string, cmd_strings>: Replace char pointers
8048         with gdb::unique_xmalloc_ptr.
8049
8050 2019-01-10  Pedro Alves  <palves@redhat.com>
8051
8052         * solib-target.c (library_list_start_library): Don't xstrdup name.
8053
8054 2019-01-10  Pedro Alves  <palves@redhat.com>
8055
8056         * mdebugread.c (parse_partial_symbols): Use
8057         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8058
8059 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8060
8061         * linux-fork.c (scoped_switch_fork_info)
8062         <~scoped_switch_fork_info>: Fix incorrect variable name.
8063
8064 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * linux-fork.c (scoped_switch_fork_info)
8067         <scoped_switch_fork_info>: Make explicit.
8068         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8069
8070 2019-01-10  Tom Tromey  <tom@tromey.com>
8071
8072         * objfiles.h (objfile::reset_psymtabs): Update.
8073         * objfiles.c (objfile::objfile): Update.
8074         * psymtab.h (psymtab_storage::obstack): Update.
8075         (psymtab_storage::m_obstack): Use gdb::optional.
8076         (class psymtab_storage): Update comment.  Remove objfile
8077         parameter.
8078         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8079
8080 2019-01-10  Tom Tromey  <tom@tromey.com>
8081
8082         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8083         <free_psymtabs>: Now private.
8084         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8085         (allocate_psymtab): Use new method.
8086
8087 2019-01-10  Tom Tromey  <tom@tromey.com>
8088
8089         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8090         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8091         * mdebugread.c (parse_partial_symbols): Use
8092         allocate_dependencies.
8093         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8094         allocate_dependencies.
8095         (process_psymtab_comp_unit_reader)
8096         (build_type_psymtab_dependencies): Likewise.
8097         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8098
8099 2019-01-10  Tom Tromey  <tom@tromey.com>
8100
8101         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8102         PSYMBOL_SET_LANGUAGE.
8103         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8104
8105 2019-01-10  Tom Tromey  <tom@tromey.com>
8106
8107         * psymtab.h (psymtab_storage::obstack): New method.
8108         <m_obstack>: Rename from obstack; now private.
8109         * psymtab.c (psymtab_storage): Update.
8110         * dwarf2read.c (create_addrmap_from_index)
8111         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8112         Update.
8113
8114 2019-01-10  Tom Tromey  <tom@tromey.com>
8115
8116         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8117         * objfiles.h (objfile::reset_psymtabs): New method.
8118
8119 2019-01-10  Tom Tromey  <tom@tromey.com>
8120
8121         * symmisc.c (print_symbol_bcache_statistics): Update.
8122         (print_objfile_statistics): Update.
8123         * symfile.c (reread_symbols): Update.
8124         * psymtab.h (class psymtab_storage): New.
8125         * psymtab.c (psymtab_storage): New constructor.
8126         (~psymtab_storage): New destructor.
8127         (require_partial_symbols): Update.
8128         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8129         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8130         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8131         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8132         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8133         (start_psymtab_common, end_psymtab_common)
8134         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8135         (allocate_psymtab): Update.
8136         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8137         Update.
8138         (dump_psymtab_addrmap, maintenance_print_psymbols)
8139         (maintenance_check_psymtabs): Update.
8140         (class objfile_psymtabs): Move to objfiles.h.
8141         * psympriv.h (discard_psymtab): Now inline.
8142         (psymtab_discarder::psymtab_discarder): Update.
8143         (psymtab_discarder::~psymtab_discarder): Update.
8144         (ALL_OBJFILE_PSYMTABS): Rewrite.
8145         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8146         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8147         Remove fields.
8148         <partial_symtabs>: New field.
8149         (class objfile_psymtabs): Move from psymtab.h.  Update.
8150         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8151         psymbol_cache.
8152         (objfile::~objfile): Don't destroy psymbol_cache.
8153         * mdebugread.c (parse_partial_symbols): Update.
8154         * dwarf2read.c (create_addrmap_from_index)
8155         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8156         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8157         (add_partial_subprogram, dwarf2_ranges_read): Update.
8158         * dwarf-index-write.c (write_address_map)
8159         (write_one_signatured_type, recursively_write_psymbols)
8160         (class debug_names, class debug_names, write_psymtabs_to_index):
8161         Update.
8162
8163 2019-01-10  Tom Tromey  <tom@tromey.com>
8164
8165         * symtab.h (SYMBOL_SET_NAMES): Update.
8166         (symbol_set_names): Update.
8167         (MSYMBOL_SET_NAMES): Update.
8168         * symtab.c (symbol_set_names): Change argument to be an
8169         objfile_per_bfd_storage.
8170         * psymtab.c (add_psymbol_to_bcache): Update.
8171         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8172
8173 2019-01-10  Tom Tromey  <tom@tromey.com>
8174
8175         * symtab.c (create_demangled_names_hash): Change argument to be an
8176         objfile_per_bfd_storage.
8177         (symbol_set_names): Update.
8178
8179 2019-01-10  Tom Tromey  <tom@tromey.com>
8180
8181         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8182         init_psymbol_list.
8183         * psymtab.c (init_psymbol_list): Do nothing if already called.
8184         * psympriv.h (init_psymbol_list): Add comment.
8185         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8186         init_psymbol_list.
8187         * dbxread.c (dbx_symfile_read): Unconditionally call
8188         init_psymbol_list.
8189
8190 2019-01-10  Tom Tromey  <tom@tromey.com>
8191
8192         * xcoffread.c (scan_xcoff_symtab): Update.
8193         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8194         "where".
8195         * mdebugread.c (parse_partial_symbols)
8196         (handle_psymbol_enumerators): Update.
8197         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8198         * dbxread.c (read_dbx_symtab): Update.
8199         * psympriv.h (psymbol_placement): New enum.
8200         (add_psymbol_to_list): Update.
8201
8202 2019-01-10  Tom Tromey  <tom@tromey.com>
8203
8204         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8205         static_psymbols parameters.
8206         (scan_xcoff_symtab): Update.
8207         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8208         static_psymbols parameters.
8209         * psympriv.h (start_psymtab_common): Update.
8210         * mdebugread.c (parse_partial_symbols): Update.
8211         * dwarf2read.c (create_partial_symtab): Update.
8212         * dbxread.c (read_dbx_symtab): Update.
8213         (start_psymtab): Remove global_psymbols and static_psymbols
8214         parameters.
8215
8216 2019-01-10  Tom Tromey  <tom@tromey.com>
8217
8218         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8219         * psymtab.c (allocate_psymtab): Add comment.
8220         * psympriv.h (allocate_psymtab): Add comment.
8221         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8222         initializations.
8223         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8224
8225 2019-01-10  Tom Tromey  <tom@tromey.com>
8226
8227         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8228         Don't declare.
8229         * mipsread.c: Include mdebugread.h.
8230         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8231         Declare.
8232         * elfread.c: Include mdebugread.h.
8233
8234 2019-01-09  Tom Tromey  <tom@tromey.com>
8235
8236         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8237         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8238         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8239         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8240         (psym_lookup_symbol, psym_find_last_source_symtab)
8241         (psym_forget_cached_source_info, psym_print_stats)
8242         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8243         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8244         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8245         (psym_find_compunit_symtab_by_address)
8246         (maintenance_print_psymbols, maintenance_info_psymtabs)
8247         (maintenance_check_psymtabs): Use ranged for.
8248         * psymtab.h (class objfile_psymtabs): New.
8249         (require_partial_symbols): Return objfile_psymtabs.
8250         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8251
8252 2019-01-09  Tom Tromey  <tom@tromey.com>
8253
8254         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8255         (find_pc_mapped_section, list_overlays_command)
8256         (map_overlay_command, unmap_overlay_command)
8257         (simple_overlay_update): Use all_objfiles.
8258         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8259         * printcmd.c (info_symbol_command): Use all_objfiles.
8260         * objfiles.h (ALL_OBJSECTIONS): Remove.
8261         * maint.c (maintenance_translate_address): Use all_objfiles.
8262         * gcore.c (gcore_create_callback): Use all_objfiles.
8263         (objfile_find_memory_regions): Likewise.
8264
8265 2019-01-09  Tom Tromey  <tom@tromey.com>
8266
8267         * symtab.c (find_line_symtab, info_sources_command)
8268         (make_source_files_completion_list): Use objfile_compunits.
8269         * source.c (select_source_symtab): Use objfile_compunits.
8270         * objfiles.h (struct objfile): Update comment.
8271         (ALL_OBJFILES): Remove.
8272         (ALL_FILETABS): Remove.
8273         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8274         objfile_compunits.
8275
8276 2019-01-09  Tom Tromey  <tom@tromey.com>
8277
8278         * symmisc.c (print_objfile_statistics, dump_objfile)
8279         (maintenance_print_symbols): Use compunit_filetabs.
8280         * source.c (forget_cached_source_info_for_objfile): Use
8281         compunit_filetabs.
8282         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8283         (ALL_FILETABS): Use compunit_filetabs.
8284         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8285         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8286
8287 2019-01-09  Tom Tromey  <tom@tromey.com>
8288
8289         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8290         (compunit_filetabs): New.
8291         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8292         compunit_filetabs.
8293         (info_sources_command, make_source_files_completion_list): Remove
8294         declaration.
8295         * symmisc.c (print_objfile_statistics, dump_objfile)
8296         (maintenance_print_symbols): Remove declaration.
8297         (maintenance_info_symtabs): Use compunit_filetabs.
8298         (maintenance_info_line_tables): Likewise.
8299         * source.c (select_source_symtab): Change local variable name.
8300         (forget_cached_source_info_for_objfile): Remove declaration.
8301         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8302         * objfiles.c (objfile_relocate1): Remove declaration.
8303         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8304         declaration.
8305         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8306         * coffread.c (coff_symtab_read): Remove declaration.
8307         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8308         compunit_filetabs.
8309
8310 2019-01-09  Tom Tromey  <tom@tromey.com>
8311
8312         * symtab.c (lookup_objfile_from_block)
8313         (find_pc_sect_compunit_symtab, search_symbols)
8314         (default_collect_symbol_completion_matches_break_on): Use
8315         objfile_compunits.
8316         * objfiles.h (ALL_COMPUNITS): Remove.
8317         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8318         * cp-support.c (add_symbol_overload_list_qualified): Use
8319         objfile_compunits.
8320         * ada-lang.c (ada_collect_symbol_completion_matches)
8321         (ada_add_global_exceptions): Use objfile_compunits.
8322
8323 2019-01-09  Tom Tromey  <tom@tromey.com>
8324
8325         * source.c (select_source_symtab)
8326         (forget_cached_source_info_for_objfile): Remove declaration.
8327         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8328         declaration.
8329         * maint.c (count_symtabs_and_blocks): Remove declaration.
8330         * cp-support.c (add_symbol_overload_list_qualified): Remove
8331         declaration.
8332         * coffread.c (coff_symtab_read): Remove declaration.
8333         * symtab.c (lookup_symbol_in_objfile_symtabs)
8334         (basic_lookup_transparent_type_1): Use objfile_compunits.
8335         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8336         (info_sources_command, search_symbols)
8337         (default_collect_symbol_completion_matches_break_on)
8338         (make_source_files_completion_list): Remove declaration.
8339         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8340         (ada_collect_symbol_completion_matches)
8341         (ada_add_global_exceptions): Remove declaration.
8342         * linespec.c (iterate_over_all_matching_symtabs): Use
8343         objfile_compunits.
8344         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8345         (class objfile_compunits): New.
8346         (ALL_COMPUNITS): Use objfile_compunits.
8347         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8348         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8349         objfile_compunits.
8350         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8351
8352 2019-01-09  Tom Tromey  <tom@tromey.com>
8353
8354         * symtab.c (search_symbols)
8355         (default_collect_symbol_completion_matches_break_on): Use
8356         objfile_msymbols.
8357         * ada-lang.c (ada_lookup_simple_minsym)
8358         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8359         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8360         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8361         objfile_msymbols.
8362         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8363         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8364         * objc-lang.c (find_methods): Use objfile_msymbols.
8365         (info_selectors_command, info_classes_command): Likewise.
8366         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8367         * objfiles.h (class objfile_msymbols): New.
8368         (ALL_OBJFILE_MSYMBOLS): Remove.
8369         (ALL_MSYMBOLS): Remove.
8370
8371 2019-01-09  Tom Tromey  <tom@tromey.com>
8372
8373         * common/next-iterator.h (next_adapter): Add Iterator template
8374         parameter.
8375         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8376         (class all_objfiles_safe): New.
8377         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8378         * objfiles.c (put_objfile_before): Update comment.
8379         (add_separate_debug_objfile): Likewise.
8380         (free_all_objfiles): Use all_objfiles_safe.
8381         (objfile_purge_solibs): Likewise.
8382
8383 2019-01-09  Tom Tromey  <tom@tromey.com>
8384
8385         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8386         (expand_symtab_containing_pc, lookup_static_symbol)
8387         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8388         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8389         all_objfiles.
8390         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8391         * breakpoint.c (create_overlay_event_breakpoint)
8392         (create_longjmp_master_breakpoint)
8393         (create_std_terminate_master_breakpoint)
8394         (create_exception_master_breakpoint): Use all_objfiles.
8395         * linux-thread-db.c (try_thread_db_load_from_pdir)
8396         (has_libpthread): Use all_objfiles.
8397         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8398         * linespec.c (iterate_over_all_matching_symtabs)
8399         (search_minsyms_for_name): Use all_objfiles.
8400         * maint.c (maintenance_info_sections): Use all_objfiles.
8401         * main.c (captured_main_1): Use all_objfiles.
8402         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8403         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8404         * guile/scm-pretty-print.c
8405         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8406         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8407         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8408         (maintenance_print_msymbols): Use all_objfiles.
8409         * source.c (select_source_symtab): Use all_objfiles.
8410         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8411         * symfile.c (remove_symbol_file_command)
8412         (expand_symtabs_matching, map_symbol_filenames): Use
8413         all_objfiles.
8414         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8415         all_objfiles.
8416         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8417         * objc-lang.c (find_methods): Use all_objfiles.
8418         * objfiles.c (have_partial_symbols, have_full_symbols)
8419         (have_minimal_symbols, qsort_cmp)
8420         (default_iterate_over_objfiles_in_search_order): Use
8421         all_objfiles.
8422         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8423         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8424         (maintenance_check_psymtabs): Use all_objfiles.
8425         (ALL_PSYMTABS): Remove.
8426         * compile/compile-object-run.c (do_module_cleanup): Use
8427         all_objfiles.
8428         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8429         * cp-support.c (add_symbol_overload_list_qualified): Use
8430         all_objfiles.
8431         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8432         Use all_objfiles.
8433         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8434         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8435         all_objfiles.
8436         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8437         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8438         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8439         Uses all_objfiles.
8440         * solib.c (solib_read_symbols): Use all_objfiles
8441
8442 2019-01-09  Tom Tromey  <tom@tromey.com>
8443
8444         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8445         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8446         all_objfiles.
8447         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8448         * symmisc.c (print_symbol_bcache_statistics)
8449         (print_objfile_statistics, maintenance_print_objfiles)
8450         (maintenance_info_symtabs, maintenance_check_symtabs)
8451         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8452         all_objfiles.
8453         * source.c (forget_cached_source_info): Use all_objfiles.
8454         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8455         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8456         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8457         * objfiles.c (update_section_map): Use all_objfiles.
8458         (shared_objfile_contains_address_p): Likewise.
8459         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8460         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8461
8462 2019-01-09  Tom Tromey  <tom@tromey.com>
8463
8464         * common/next-iterator.h: New file.
8465         * objfiles.h (class all_objfiles): New.
8466         (struct objfile_iterator): New.
8467
8468 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8469
8470         * NEWS: Move the description of the changed "frame", "select-frame",
8471          and "info frame" commands to the Changed commands section.
8472
8473 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8474
8475         * gdbtypes.c (check_stub_method_group): Remove handling of old
8476         mangling schemes.
8477         * linespec.c (find_methods): Likewise.
8478         * stabsread.c (read_member_functions): Likewise.
8479         * valops.c (search_struct_method): Likewise.
8480         (value_struct_elt_for_reference): Likewise.
8481         * NEWS: Mention this change.
8482
8483 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8484
8485         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8486         print_source_lines.
8487         * source.c (print_source_lines_base): Update line number check.
8488         (print_source_lines): New function.
8489         (source_lines_range::source_lines_range): New function.
8490         * source.h (class source_lines_range): New class.
8491         (print_source_lines): New declaration.
8492
8493 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8494
8495         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8496
8497 2019-01-08  Tom Tromey  <tom@tromey.com>
8498             Simon Marchi  <simon.marchi@ericsson.com>
8499
8500         PR gdb/24060
8501         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8502         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8503         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8504         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8505         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8506         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8507
8508 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * source.c (select_source_symtab): Move header comment to
8511         declaration in source.h.
8512         (forget_cached_source_info_for_objfile): Likewise.
8513         (forget_cached_source_info): Likewise.
8514         (identify_source_line): Likewise.
8515         * source.h (identify_source_line): Move declaration from symtab.h
8516         and add comment from source.c
8517         (print_source_lines): Likewise.
8518         (forget_cached_source_info_for_objfile): Likewise.
8519         (forget_cached_source_info): Likewise.
8520         (select_source_symtab): Likewise.
8521         (enum print_source_lines_flag): Move definition from symtab.h.
8522         * symtab.h (identify_source_line): Move declaration to source.h.
8523         (print_source_lines): Likewise.
8524         (forget_cached_source_info_for_objfile): Likewise.
8525         (forget_cached_source_info): Likewise.
8526         (select_source_symtab): Likewise.
8527         (enum print_source_lines_flag): Move definition to source.h.
8528         * tui/tui-hooks.c: Add 'source.h' include.
8529
8530 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * source.c (print_source_lines_base): Handle requests to print
8533         reverse line number sequences, and guard against empty lines
8534         string.
8535
8536 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8537
8538         * source.c (print_source_lines_base): Fix skip of '\r' if next
8539         character is '\n'.
8540
8541 2019-01-06  Tom Tromey  <tom@tromey.com>
8542
8543         * c-exp.y (struct c_parse_state) <macro_original_text,
8544         expansion_obstack>: New member.
8545         (macro_original_text, expansion_obstack): Remove globals.
8546         (scan_macro_expansion, scanning_macro_expansion)
8547         (finished_macro_expansion): Update.
8548         (scan_macro_cleanup): Remove.
8549         (yylex, c_parse): Update.
8550
8551 2019-01-06  Tom Tromey  <tom@tromey.com>
8552
8553         * c-exp.y (struct c_parse_state) <strings>: New member.
8554         (operator_stoken): Update.
8555
8556 2019-01-06  Tom Tromey  <tom@tromey.com>
8557
8558         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8559         (union type_stack_elt) <typelist_val>: Now a pointer to
8560         std::vector.
8561         (type_stack_cleanup): Don't declare.
8562         (push_typelist): Update.
8563         * parse.c (pop_typelist): Return a std::vector.
8564         (push_typelist): Take a std::vector.
8565         (follow_types): Update.  Do not free args.
8566         (type_stack_cleanup): Remove.
8567         * c-exp.y (struct c_parse_state): New.
8568         (cpstate): New global.
8569         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8570         (nonempty_typelist): Update.
8571         (func_mod): Create a new vector.
8572         (c_parse): Create a c_parse_state.
8573         (check_parameter_typelist): Do not delete params.
8574         (function_method): Update.  Do not delete type_list.
8575
8576 2019-01-06  Tom Tromey  <tom@tromey.com>
8577
8578         PR gdb/28155:
8579         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8580         check_typedef.
8581         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8582         (print_return_value): Likewise.
8583
8584 2019-01-05  Tom Tromey  <tom@tromey.com>
8585
8586         * contrib/cleanup_check.py: Remove.
8587         * contrib/gcc-with-excheck: Remove.
8588         * contrib/exsummary.py: Remove.
8589         * contrib/excheck.py: Remove.
8590
8591 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8592
8593         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8594         NULL. Initialize tpprev to NULL instead of assigning it
8595         to NULL on the next statement.
8596         * windows-nat.c (windows_delete_thread): Remove check for
8597         main_thread_id before printing thread exit notifications.
8598         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8599         Remove thread ID check against main_thread_id.
8600         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8601         windows_delete_thread.
8602         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8603
8604 2019-01-04  Tom Tromey  <tom@tromey.com>
8605
8606         * compile/compile.c (_initialize_compile): Use upper case for
8607         metasyntactic variables.
8608         * symmisc.c (_initialize_symmisc): Use upper case for
8609         metasyntactic variables.
8610         * psymtab.c (_initialize_psymtab): Use upper case for
8611         metasyntactic variables.
8612         * demangle.c (demangle_command): Use upper case for metasyntactic
8613         variables.
8614         (_initialize_demangler): Likewise.
8615         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8616         variables.
8617
8618 2019-01-03  Tom Tromey  <tom@tromey.com>
8619
8620         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8621
8622 2019-01-03  Tom Tromey  <tom@tromey.com>
8623
8624         * python/py-symtab.c (salpy_str): Update.
8625         (struct salpy_sal_object) <symtab>: Now a PyObject.
8626         (salpy_dealloc): Update.
8627         (del_objfile_sal): Use gdbpy_ref.
8628
8629 2019-01-03  Tom Tromey  <tom@tromey.com>
8630
8631         * python/py-type.c (convert_field): Use new_reference.  Return
8632         gdbpy_ref.
8633         (make_fielditem): Return gdbpy_ref.
8634         (typy_fields): Update.
8635         (typy_getitem): Update.
8636         (field_name): Return gdbpy_ref.  Use new_reference.
8637         (typy_iterator_iternext): Update.
8638
8639 2019-01-03  Tom Tromey  <tom@tromey.com>
8640
8641         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8642
8643 2019-01-03  Tom Tromey  <tom@tromey.com>
8644
8645         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8646         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8647         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8648         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8649         (pspy_set_type_printers): Likewise.
8650         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8651         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8652         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8653         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8654         (objfpy_set_type_printers): Likewise.
8655
8656 2019-01-03  Tom Tromey  <tom@tromey.com>
8657
8658         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8659         (gdbpy_print_stack): Use gdbpy_err_fetch.
8660         * python/python-internal.h (class gdbpy_err_fetch): New class.
8661         (class gdbpy_enter) <m_error_type, m_error_value,
8662         m_error_traceback>: Remove.
8663         <m_error>: New member.
8664         (gdbpy_exception_to_string): Don't declare.
8665         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8666         * python/py-value.c (convert_value_from_python): Use
8667         gdbpy_err_fetch.
8668         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8669         gdbpy_exception_to_string.
8670         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8671         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8672         gdbpy_err_fetch.
8673
8674 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8675
8676         * linux-nat.c (delete_lwp_cleanup): Delete.
8677         (struct lwp_deleter): New struct.
8678         (lwp_info_up): New typedef.
8679         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8680         lwp_info_up.
8681
8682 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8683
8684         * linux-fork.c (class scoped_switch_fork_info): New class.
8685         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8686
8687 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8688
8689         * valops.c (find_overload_match): Remove use of null_cleanup, and
8690         calls to do_cleanups.
8691
8692 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         * compile/compile-cplus-types.c
8695         (compile_cplus_instance::decl_name): Handle changes to
8696         cp_func_name.
8697         * cp-support.c (cp_func_name): Update header comment, update
8698         return type.
8699         * cp-support.h (cp_func_name): Update return type in declaration.
8700         * valops.c (find_overload_match): Move temp_func local to top
8701         level of function and change its type.  Use temp_func to hold and
8702         delete temporary string obtained from cp_func_name.
8703
8704 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8707         gdb::char_vector, remove cleanup, and update uses of `msg`.
8708
8709 2019-01-03  Jim Wilson  <jimw@sifive.com>
8710
8711         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8712
8713 2019-01-02  Tom Tromey  <tom@tromey.com>
8714
8715         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8716         (tdesc_parse_xml): Remove cleanups.
8717         * target-descriptions.h (make_cleanup_free_target_description):
8718         Don't declare.
8719         (target_desc_deleter): New struct.
8720         (target_desc_up): New typedef.
8721         * target-descriptions.c (target_desc_deleter::operator()): Rename
8722         from free_target_description.
8723         (make_cleanup_free_target_description): Remove.
8724
8725 2019-01-02  Tom Tromey  <tom@tromey.com>
8726
8727         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8728         constructor, destructor.
8729         (linespec_parser): Remove typedef.
8730         (~linespec_parser): Rename from linespec_parser_delete.
8731         (linespec_lex_to_end, linespec_complete_label)
8732         (linespec_complete): Update.
8733         (decode_line_full): Remove cleanups.
8734         (decode_line_1): Update.
8735
8736 2019-01-02  Tom Tromey  <tom@tromey.com>
8737
8738         * python/python-internal.h (inferior_to_inferior_object): Change
8739         return type.
8740         * python/py-exitedevent.c (create_exited_event_object): Update.
8741         * python/py-inferior.c (inferior_to_inferior_object): Return
8742         gdbpy_ref.
8743         (python_new_inferior, python_inferior_deleted)
8744         (thread_to_thread_object, delete_thread_object)
8745         (build_inferior_list, gdbpy_selected_inferior): Update.
8746         * python/py-infthread.c (create_thread_object): Update.  Also fail
8747         if inferior_to_inferior_object fails.
8748
8749 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8750
8751         * inferior.h (class inferior) <displaced_step_state>: New field.
8752         * infrun.h (struct displaced_step_state): Move here from
8753         infrun.c.  Initialize fields, add constructor.
8754         <inf>: Remove field.
8755         <reset>: New method.
8756         * infrun.c (struct displaced_step_inferior_state): Move to
8757         infrun.h.
8758         (displaced_step_inferior_states): Remove.
8759         (get_displaced_stepping_state): Adust.
8760         (displaced_step_in_progress_any_inferior): Adjust.
8761         (displaced_step_in_progress_thread): Adjust.
8762         (displaced_step_in_progress): Adjust.
8763         (add_displaced_stepping_state): Remove.
8764         (get_displaced_step_closure_by_addr): Adjust.
8765         (remove_displaced_stepping_state): Remove.
8766         (infrun_inferior_exit): Call displaced_step_state.reset.
8767         (use_displaced_stepping): Don't check for NULL.
8768         (displaced_step_prepare_throw): Call
8769         get_displaced_stepping_state.
8770         (displaced_step_fixup): Don't check for NULL.
8771         (prepare_for_detach): Don't check for NULL.
8772
8773 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8774
8775         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8776          in case of call that did not complete.
8777
8778 2019-01-02  Andrey Utkin  <autkin@undo.io>
8779
8780         * symfile.c (find_separate_debug_file): Fix search of debug files for
8781         remote debuggee.
8782
8783 2019-01-02  Tom Tromey  <tom@tromey.com>
8784
8785         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8786         indentation.
8787         * python/py-frame.c (frapy_older): Remove cast.
8788         (frapy_newer): Likewise.
8789         * python/py-breakpoint.c (local_setattro): Remove cast.
8790         * python/py-arch.c (archpy_name): Remove local variable.
8791         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8792
8793 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8794
8795         * unittests/basic_string_view/element_access/char/empty.cc:
8796         Fix year range in copyright header.
8797
8798 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8799
8800         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8801         Delete.
8802         <operator==>: Update with for removed field.
8803         <hash>: Likewise.
8804         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8805         <isa_features>: ...this.
8806         <abi_features>: New field.
8807         (riscv_isa_flen): Update comment.
8808         (riscv_abi_xlen): New declaration.
8809         (riscv_abi_flen): New declaration.
8810         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8811         isa_features.
8812         (riscv_abi_xlen): New function.
8813         (riscv_isa_flen): Update to get answer from isa_features.
8814         (riscv_abi_flen): New function.
8815         (riscv_has_fp_abi): Update to get answer from abi_features.
8816         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8817         xlen and flen.
8818         (riscv_call_info) <xlen, flen>: Update comment.
8819         (riscv_call_arg_struct): Remove invalid assertions
8820         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8821         is removed.
8822         (riscv_gdbarch_init): Gather isa features and abi features
8823         separately, ensure both match on the gdbarch when reusing an old
8824         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8825         a target with 64-bit float hardware.
8826
8827 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8828
8829         * source.c (search_command_helper): Stop reverse search
8830         when line 1 has been searched.
8831
8832 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8833
8834         * record-full.c (record_full_base_target::close): Rewrite
8835         record_full_core_buf_list free logic.
8836
8837 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8838
8839         * break-catch-syscall.c (print_one_catch_syscall): xfree
8840         the last text.
8841
8842 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8843
8844         * top.c (print_gdb_version): Update Copyright year in version
8845         message.
8846
8847 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8848
8849         Update copyright year range in all GDB files.
8850
8851 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8852
8853         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8854
8855 For older changes see ChangeLog-2018.
8856 \f
8857 Local Variables:
8858 mode: change-log
8859 left-margin: 8
8860 fill-column: 74
8861 version-control: never
8862 coding: utf-8
8863 End:
8864