gdb/ChangeLog

   1 2018-06-07  Pedro Alves  <palves@redhat.com>
   2
   3         * target.h (target_ops) <beneath>: Now a method.  All references
   4         updated.
   5         (target_ops) <m_beneath>: New.
   6         * target.c (target_ops::beneath): New.
   7         * corelow.c: Adjust all references to target_ops::beneath.
   8         * linux-thread-db.c: Likewise.
   9         * make-target-delegates: Likewise.
  10         * record-btrace.c: Likewise.
  11         * record-full.c: Likewise.
  12         * remote.c: Likewise.
  13         * target.c: Likewise.
  14         * target-delegates.c: Regenerate.
  15
  16 2018-06-07  Pedro Alves  <palves@redhat.com>
  17
  18         * target.h (target_stack): Delete.
  19         (current_top_target): Declare function.
  20         * target.c (target_stack): Delete.
  21         (g_current_top_target): New.
  22         (current_top_target): New function.
  23         * auxv.c: Use current_top_target instead of target_stack
  24         throughout.
  25         * avr-tdep.c: Likewise.
  26         * breakpoint.c: Likewise.
  27         * corefile.c: Likewise.
  28         * elfread.c: Likewise.
  29         * eval.c: Likewise.
  30         * exceptions.c: Likewise.
  31         * frame.c: Likewise.
  32         * gdbarch-selftests.c: Likewise.
  33         * gnu-v3-abi.c: Likewise.
  34         * ia64-tdep.c: Likewise.
  35         * ia64-vms-tdep.c: Likewise.
  36         * infcall.c: Likewise.
  37         * infcmd.c: Likewise.
  38         * infrun.c: Likewise.
  39         * linespec.c: Likewise.
  40         * linux-tdep.c: Likewise.
  41         * minsyms.c: Likewise.
  42         * ppc-linux-nat.c: Likewise.
  43         * ppc-linux-tdep.c: Likewise.
  44         * procfs.c: Likewise.
  45         * regcache.c: Likewise.
  46         * remote.c: Likewise.
  47         * rs6000-tdep.c: Likewise.
  48         * s390-linux-nat.c: Likewise.
  49         * s390-tdep.c: Likewise.
  50         * solib-aix.c: Likewise.
  51         * solib-darwin.c: Likewise.
  52         * solib-dsbt.c: Likewise.
  53         * solib-spu.c: Likewise.
  54         * solib-svr4.c: Likewise.
  55         * solib-target.c: Likewise.
  56         * sparc-tdep.c: Likewise.
  57         * sparc64-tdep.c: Likewise.
  58         * spu-tdep.c: Likewise.
  59         * symfile.c: Likewise.
  60         * symtab.c: Likewise.
  61         * target-descriptions.c: Likewise.
  62         * target-memory.c: Likewise.
  63         * target.c: Likewise.
  64         * target.h: Likewise.
  65         * tracefile-tfile.c: Likewise.
  66         * tracepoint.c: Likewise.
  67         * valops.c: Likewise.
  68         * valprint.c: Likewise.
  69         * value.c: Likewise.
  70         * windows-tdep.c: Likewise.
  71         * mi/mi-main.c: Likewise.
  72
  73 2018-06-07  Tom Tromey  <tom@tromey.com>
  74
  75         * valprint.h (build_address_symbolic): Declare.
  76         * printcmd.c (print_address_symbolic): Update.
  77         (build_address_symbolic): Change "name" and "filename" to
  78         std::string.
  79         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  80         Update.
  81         * defs.h (build_address_symbolic): Remove declaration.
  82
  83 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
  84
  85         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
  86         (aarch64_vnv_type): Add function.
  87         (aarch64_pseudo_register_name): Add V regs for SVE.
  88         (aarch64_pseudo_register_type): Likewise.
  89         (aarch64_pseudo_register_reggroup_p): Likewise.
  90         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
  91         (aarch64_pseudo_read_value): Add V regs for SVE.
  92         (aarch64_pseudo_write_2): Use V0 offset for SVE
  93         (aarch64_pseudo_write): Add V regs for SVE.
  94         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
  95
  96 2018-06-05  Tom Tromey  <tom@tromey.com>
  97
  98         * cli/cli-cmds.c (show_version): Update.
  99         * top.c (print_gdb_version): Add "interactive" parameter.
 100         Update.
 101         * main.c (captured_main_1): Update.
 102         * top.h (print_gdb_version): Add "interactive" parameter and a
 103         comment.
 104
 105 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
 106
 107         * common/enum-flags.h: Add trailing semicolon to example in
 108         comment.
 109
 110 2018-06-05  Tom Tromey  <tom@tromey.com>
 111
 112         PR cli/12326:
 113         * NEWS: Add entry about pager.
 114         * utils.c (pagination_disabled_for_command): New global.
 115         (prompt_for_continue): Allow "c" response to prompt.
 116         (reinitialize_more_filter): Clear
 117         pagination_disabled_for_command.
 118         (fputs_maybe_filtered): Check pagination_disabled_for_command.
 119
 120 2018-06-04  Tom Tromey  <tom@tromey.com>
 121
 122         * ada-lang.h (ada_lookup_symbol_list): Update.
 123         * ada-lang.c (resolve_subexp): Update.
 124         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
 125         parameter.
 126         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
 127         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
 128         results parameter to std::vector.
 129         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
 130         Update.
 131         * ada-exp.y (block_lookup): Update.
 132         (select_possible_type_sym): Change type of syms.  Remove nsyms
 133         parameter.
 134         (write_var_or_type, write_name_assoc): Update.
 135
 136 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
 137
 138         * windows-nat.c (windows_nat_target::xfer_partial): Return
 139         TARGET_XFER_E_IO if we need to delegate to the target beneath
 140         but BENEATH is NULL.
 141
 142 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
 143
 144         * Makefile.in (config.status): Add configure.nat as a
 145         dependency.
 146
 147 2018-06-04  Tom Tromey  <tom@tromey.com>
 148
 149         * cp-name-parser.y (cpname_state): Add method declarations.
 150         (HANDLE_QUAL): Update.
 151         (cpname_state::d_grab, cpname_state::fill_comp)
 152         (cpname_state::make_operator, cpname_state::make_dtor)
 153         (cpname_state::make_builtin_type, cpname_state::make_name)
 154         (cpname_state::d_qualify, cpname_state::d_int_type)
 155         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
 156         (%union): Move earlier.
 157
 158 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
 159
 160         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
 161
 162 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
 163
 164         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
 165         (aarch64_pseudo_write_1): Likewise.
 166         (aarch64_pseudo_read_value): Use helper.
 167         (aarch64_pseudo_write): Likewise.
 168
 169 2018-06-04  Pedro Alves  <palves@redhat.com>
 170
 171         * darwin-nat.c (darwin_ops): Delete.
 172         (darwin_attach_pid): Use get_native_target.
 173
 174 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
 175
 176         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
 177         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
 178
 179 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
 180
 181         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
 182         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
 183         (aarch64_gdbarch_init): Check for SVE.
 184         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
 185
 186 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
 187
 188         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
 189         * aarch64-tdep.h (aarch64_read_description): Likewise.
 190         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 191         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 192         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
 193         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
 194         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
 195
 196 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
 197
 198         * value.c (value_fetch_lazy_bitfield): New.
 199         (value_fetch_lazy_memory): New.
 200         (value_fetch_lazy_register): New.
 201         (value_fetch_lazy): Factor out to smaller functions.
 202
 203 2018-06-01  Tom Tromey  <tom@tromey.com>
 204
 205         * cp-name-parser.y (backslashable, represented): Now const.
 206
 207 2018-06-01  Tom Tromey  <tom@tromey.com>
 208
 209         * cp-name-parser.y: Include parser-defs.h.
 210         (parser_fprintf): Remove declaration.
 211
 212 2018-06-01  Tom Tromey  <tom@tromey.com>
 213
 214         * cp-name-parser.y: Use %pure-parser, %lex-param, and
 215         %parse-param.
 216         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
 217         (global_result): Remove globals.
 218         (struct cpname_state): New.
 219         (yyparse): Don't declare.
 220         (yylex, yyerror): Move declarations after %union.
 221         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
 222         (make_name): Add state parameter.
 223         Update all callers.
 224         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
 225         parameter.
 226         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
 227         Update.
 228         (yylex): Add lvalp, state parameters.
 229         (yyerror): Add state parameter.
 230         (cp_demangled_name_to_comp): Update.
 231
 232 2018-06-01  Tom Tromey  <tom@tromey.com>
 233
 234         * cp-name-parser.y (parser_fprintf): Declare.
 235         (GDB_YY_REMAP_PREFIX): Define.
 236         Include yy-remap.h.  Don't redefine yy* identifiers.
 237
 238 2018-06-01  Tom Tromey  <tom@tromey.com>
 239
 240         * python/py-type.c (typy_legacy_template_argument): Update.
 241         * cp-support.h (cp_demangled_name_to_comp): Update.
 242         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
 243         parameter to be a "std::string *".
 244         (main): Update.
 245
 246 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
 247
 248         * ada-lex.l: Include "diagnostics.h" instead of
 249         "common/diagnostics.h".
 250         * unittests/environ-selftests.c: Likewise.
 251         * common/diagnostics.h: Moved to ../include.
 252
 253 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
 254
 255         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
 256         to language_mode_manual while calling breakpoint_re_set_one.
 257
 258 2018-06-01  Tom Tromey  <tom@tromey.com>
 259
 260         * valops.c (value_cast_structs, destructor_name_p): Update.
 261         * symtab.c (gdb_mangle_name): Update.
 262         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
 263         Update.
 264         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
 265         (pascal_object_print_value_fields, pascal_object_print_value):
 266         Update.
 267         * p-typeprint.c (pascal_type_print_derivation_info): Update.
 268         * linespec.c (find_methods): Update.
 269         * gdbtypes.h (type_name_no_tag): Remove.
 270         (type_name_or_error): Rename from type_name_no_tag_or_error.
 271         * gdbtypes.c (type_name_no_tag): Remove.
 272         (type_name_or_error): Rename from type_name_no_tag_or_error.
 273         (lookup_struct_elt_type, check_typedef): Update.
 274         * expprint.c (print_subexp_standard): Update.
 275         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
 276         * d-namespace.c (d_lookup_nested_symbol): Update.
 277         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
 278         (cp_print_class_member): Update.
 279         * cp-namespace.c (cp_lookup_nested_symbol): Update.
 280         * completer.c (add_struct_fields): Update.
 281         * c-typeprint.c (cp_type_print_derivation_info)
 282         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
 283         Update.
 284         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
 285         (ada_prefer_type, ada_is_exception_sym): Update.
 286
 287 2018-06-01  Tom Tromey  <tom@tromey.com>
 288
 289         * valops.c (enum_constant_from_type, value_namespace_elt)
 290         (value_maybe_namespace_elt): Update.
 291         * valarith.c (find_size_for_pointer_math): Update.
 292         * target-descriptions.c (make_gdb_type): Update.
 293         * symmisc.c (print_symbol): Update.
 294         * stabsread.c (define_symbol, read_type)
 295         (complain_about_struct_wipeout, add_undefined_type)
 296         (cleanup_undefined_types_1): Update.
 297         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
 298         (rust_range_type_p, val_print_struct, rust_print_struct_def)
 299         (rust_internal_print_type, rust_composite_type)
 300         (rust_evaluate_funcall, rust_evaluate_subexp)
 301         (rust_inclusive_range_type_p): Update.
 302         * python/py-type.c (typy_get_tag): Update.
 303         * p-typeprint.c (pascal_type_print_base): Update.
 304         * mdebugread.c (parse_symbol, parse_type): Update.
 305         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
 306         Update.
 307         * guile/scm-type.c (gdbscm_type_tag): Update.
 308         * go-lang.c (sixg_string_p): Update.
 309         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
 310         Update.
 311         * gdbtypes.h (struct main_type) <tag_name>: Remove.
 312         (TYPE_TAG_NAME): Remove.
 313         * gdbtypes.c (type_name_no_tag): Simplify.
 314         (check_typedef, check_types_equal, recursive_dump_type)
 315         (copy_type_recursive, arch_composite_type): Update.
 316         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
 317         in summary mode when needed.
 318         * eval.c (evaluate_funcall): Update.
 319         * dwarf2read.c (fixup_go_packaging, read_structure_type)
 320         (process_structure_scope, read_enumeration_type)
 321         (read_namespace_type, read_module_type, determine_prefix): Update.
 322         * cp-support.c (inspect_type): Update.
 323         * coffread.c (process_coff_symbol, decode_base_type): Update.
 324         * c-varobj.c (c_is_path_expr_parent): Update.
 325         * c-typeprint.c (c_type_print_base_struct_union): Update.
 326         (c_type_print_base_1): Update.  Print struct/class/union/enum in
 327         summary when using C language.
 328         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
 329         (gen_maybe_namespace_elt): Update.
 330         * ada-lang.c (ada_type_name): Simplify.
 331         (empty_record, ada_template_to_fixed_record_type_1)
 332         (template_to_static_fixed_type)
 333         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
 334
 335 2018-06-01  Tom Tromey  <tom@tromey.com>
 336
 337         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
 338         c_print_type.
 339         * c-typeprint.c (c_print_type_1): Add "language" parameter.
 340         (c_print_type): Update.
 341         (c_print_type): New overload.
 342         (c_type_print_varspec_prefix, c_type_print_args)
 343         (c_type_print_varspec_suffix, c_print_type_no_offsets)
 344         (c_type_print_base_struct_union, c_type_print_base_1)
 345         (cp_type_print_method_args): Add "language" parameter.
 346         (c_type_print_base): Update.
 347         * c-lang.h (c_print_type): Add new overload.
 348
 349 2018-06-01  Tom Tromey  <tom@tromey.com>
 350
 351         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
 352         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
 353
 354 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
 355
 356         * aarch64-tdep.c (aarch64_sve_register_names): New const
 357         var.
 358         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
 359         (AARCH64_SVE_Z_REGS_NUM): New define.
 360         (AARCH64_SVE_P_REGS_NUM): Likewise.
 361         (AARCH64_SVE_NUM_REGS): Likewise.
 362
 363 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
 364
 365         * nat/linux-ptrace.h [__alpha__]
 366         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
 367         definitions.
 368
 369 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
 370
 371         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
 372         the endianness selected.
 373         * NEWS: Document `set endian auto' mode operation update.
 374
 375 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
 376
 377         * Makefile.in: Add new header.
 378         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
 379         (sve_vl_from_vg): Likewise.
 380         (sve_vq_from_vl): Likewise.
 381         (sve_vl_from_vq): Likewise.
 382         (sve_vq_from_vg): Likewise.
 383         (sve_vg_from_vq): Likewise.
 384         * configure.nat: Add new c file.
 385         * nat/aarch64-sve-linux-ptrace.c: New file.
 386         * nat/aarch64-sve-linux-ptrace.h: New file.
 387
 388 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
 389
 390         * aarch64-linux-nat.c (aarch64_linux_read_description):
 391         Add parmeter zero.
 392         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 393         Likewise.
 394         * aarch64-tdep.c (tdesc_aarch64_list): Add.
 395         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
 396         (aarch64_gdbarch_init): Add parmeter zero.
 397         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
 398         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
 399         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
 400         parmeter.
 401         * doc/gdb.texinfo: Describe SVE feature
 402         * features/aarch64-sve.c: New file.
 403
 404 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
 405
 406         PR gdb/23210
 407         * gdbarch.sh (significant_addr_bit): Default to zero when
 408         not set by target architecture.
 409         * gdbarch.c: Re-generated.
 410         * utils.c (address_significant): Update.
 411
 412 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
 413
 414         * stack.c (func_command): Remove trailing newline in call to error.
 415
 416 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 417
 418         * regcache.h (regcache_raw_collect): Remove, update callers to
 419         use regcache::raw_collect.
 420         * regcache.c (regcache_raw_collect): Remove.
 421
 422 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 423
 424         * regcache.h (regcache_raw_supply): Remove, update callers to
 425         use detached_regcache::raw_supply.
 426         * regcache.c (regcache_raw_supply): Remove.
 427
 428 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 429
 430         * regcache.h (regcache_cooked_write_part): Remove, update
 431         callers to use regcache::cooked_write_part.
 432         * regcache.c (regcache_cooked_write_part): Remove.
 433
 434 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 435
 436         * regcache.h (regcache_cooked_read_part): Remove, update callers
 437         to use readable_regcache::cooked_read_part.
 438         * regcache.c (regcache_cooked_read_part): Remove.
 439
 440 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 441
 442         * regcache.h (regcache_cooked_read_value): Remove, update
 443         callers to use readable_regcache::cooked_read_value.
 444         * regcache.c (regcache_cooked_read_value): Remove.
 445
 446 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 447
 448         * regcache.h (regcache_cooked_write): Remove, update callers to
 449         use regcache::cooked_write.
 450         * regcache.c (regcache_cooked_write): Remove.
 451
 452 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 453
 454         * regcache.h (regcache_invalidate): Remove, update callers to
 455         use detached_regcache::invalidate instead.
 456         * regcache.c (regcache_invalidate): Remove.
 457
 458 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 459
 460         * regcache.h (regcache_raw_write_part): Remove, update callers
 461         to use regcache::raw_write_part instead.
 462         * regcache.c (regcache_raw_write_part): Remove.
 463
 464 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 465
 466         * regcache.h (regcache_raw_read_part): Remove, update callers to
 467         use readable_regcache::raw_read_part instead.
 468         * regcache.c (regcache_raw_read_part): Remove.
 469
 470 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 471
 472         * regcache.h (regcache_cooked_read): Remove, update callers to
 473         use readable_regcache::cooked_read instead.
 474         * regcache.c (regcache_cooked_read): Remove.
 475
 476 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 477
 478         * regcache.h (regcache_raw_write): Remove, update callers to use
 479         regcache::raw_write instead.
 480         * regcache.c (regcache_raw_write): Remove.
 481
 482 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 483
 484         * regcache.h (regcache_raw_read): Remove, update callers to use
 485         readable_regcache::raw_read instead.
 486         * regcache.c (regcache_raw_read): Remove.
 487
 488 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 489
 490         * regcache.h (regcache_raw_update): Remove, update callers to
 491         use readable_regcache::raw_update instead.
 492         * regcache.c (regcache_raw_update): Remove.
 493
 494 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 495
 496         * regcache.h (regcache_register_status): Remove, update callers
 497         to use reg_buffer::get_register_status directly instead.
 498         * regcache.c (regcache_register_status): Remove.
 499
 500 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 501
 502         * regcache.h (regcache_get_ptid): Remove, update all callers to
 503         call regcache::ptid instead.
 504         * regcache.c (regcache_get_ptid): Remove.
 505
 506 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 507
 508         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
 509
 510 2018-05-30  Pedro Alves  <palves@redhat.com>
 511
 512         * common/common-exceptions.h (exception_rethrow): Use
 513         ATTRIBUTE_NORETURN.
 514
 515 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
 516
 517         * breakpoint.c (print_solib_event, check_status_catch_solib):
 518         Remove struct keyword in range-based for loops.
 519         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
 520         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
 521         Likewise.
 522         * linespec.c (find_superclass_methods, search_minsyms_for_name):
 523         Likewise.
 524         * symfile.c (addr_info_make_relative): Likewise.
 525         * thread.c (value_in_thread_stack_temporaries): Likewise.
 526
 527 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
 528
 529         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
 530         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
 531         * coff-pe-read.c (add_pe_forwarded_sym): Replace
 532         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
 533         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
 534         * jit.c (jit_breakpoint_re_set_internal): Likewise.
 535         * printcmd.c (info_address_command): Likewise.
 536
 537 2018-05-29  Tom Tromey  <tom@tromey.com>
 538
 539         * windows-nat.c (handle_exception): Update fall-through comment.
 540
 541 2018-05-29  Tom Tromey  <tom@tromey.com>
 542
 543         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
 544         (struct program_space) <added_solibs>: Now a std::vector.
 545         * breakpoint.c (print_solib_event): Update.
 546         (check_status_catch_solib): Update.
 547         * progspace.c (clear_program_space_solib_cache): Update.
 548         * solib.c (update_solib_list): Update.
 549
 550 2018-05-29  Tom Tromey  <tom@tromey.com>
 551
 552         * python/py-type.c (typy_richcompare): Update.
 553         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
 554         * gdbtypes.h (types_deeply_equal): Return bool.
 555         (types_equal): Likewise.
 556         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
 557         declare VEC.
 558         (check_types_equal): Change worklist to std::vector.  Return
 559         bool.
 560         (struct type_equality_entry): Add constructor.
 561         (compare_maybe_null_strings): Return bool.
 562         (check_types_worklist): Return bool.  Change worklist to
 563         std::vector.
 564         (types_deeply_equal): Use std::vector.
 565         (types_equal): Return bool.
 566         (compare_maybe_null_strings): Simplify.
 567
 568 2018-05-29  Tom Tromey  <tom@tromey.com>
 569
 570         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
 571
 572 2018-05-29  Tom Tromey  <tom@tromey.com>
 573
 574         * objc-lang.h: Don't include cp-support.h.
 575         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
 576         declare VEC.
 577
 578 2018-05-27  Tom Tromey  <tom@tromey.com>
 579
 580         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
 581
 582 2018-05-25  Tom Tromey  <tom@tromey.com>
 583
 584         * value.c (value::location): Initialize.
 585
 586 2018-05-25  Tom Tromey  <tom@tromey.com>
 587
 588         * dbxread.c (init_bincl_list): Remove.
 589         (bincl_list): Now a std::vector.
 590         (bincls_allocated, next_bincl): Remove.
 591         (free_bincl_list, do_free_bincl_list_cleanup)
 592         (make_cleanup_free_bincl_list): Remove.
 593         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
 594         unique_xmalloc_ptr.
 595         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
 596         (struct header_file_location): Add constructor.
 597         (add_bincl_to_list): Remove.
 598
 599 2018-05-25  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui.c (tui_enable): Update.
 602         * mi/mi-interp.c (mi_interp::init): Update.
 603         * interps.h (class interp) <name>: New method.
 604         <m_name>: Rename from name.
 605         (~scoped_restore_interp): Update.
 606         * interps.c (interp::interp): Update.
 607         (interp_add, interp_set, interp_lookup_existing)
 608         (current_interp_named_p): Update.
 609
 610 2018-05-25  Tom Tromey  <tom@tromey.com>
 611
 612         * interps.c (interp_name): Remove.
 613         * mi/mi-interp.c (mi_interp::init): Update.
 614         * interps.h (interp_name): Remove.
 615         (~scoped_restore_interp): Update.
 616         * tui/tui.c (tui_enable): Update.
 617
 618 2018-05-25  Tom Tromey  <tom@tromey.com>
 619
 620         * utils.c (fputs_maybe_filtered): Update.
 621         * linespec.c (decode_line_full): Update.
 622         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
 623         (mi_print_breakpoint_for_event, mi_solib_loaded)
 624         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
 625         (mi_user_selected_context_changed): Update.
 626         * mi/mi-main.c (mi_execute_command): Update.
 627         * cli/cli-script.c (execute_control_command): Update.
 628         * python/python.c (execute_gdb_command): Update.
 629         * solib.c (info_sharedlibrary_command): Update.
 630         * interps.c (interp_ui_out): Remove.
 631         * interps.h (interp_ui_out): Remove.
 632
 633 2018-05-25  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
 636         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
 637         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
 638
 639 2018-05-25  Tom Tromey  <tom@tromey.com>
 640
 641         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
 642         * interps.c (interp_exec): Use scoped_restore.
 643
 644 2018-05-25  Tom Tromey  <tom@tromey.com>
 645
 646         * remote.c (remote_target::remote_file_get): Use
 647         gdb::byte_vector.
 648         (remote_target::remote_file_put): Likewise.
 649
 650 2018-05-25  Tom Tromey  <tom@tromey.com>
 651
 652         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
 653         a std::string.
 654         (get_pe_section_index, add_pe_exported_sym): Update.
 655         (read_pe_exported_syms): Use gdb::def_vector.
 656
 657 2018-05-25  Tom Tromey  <tom@tromey.com>
 658
 659         * frame.c (remove_prev_frame): Remove.
 660         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
 661
 662 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
 663
 664         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
 665         Remove prototypes.
 666         * mips-linux-nat.c (supply_fpregset): Always call
 667         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
 668         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
 669         `mips_fill_fpregset'.
 670         * mips-linux-tdep.c (mips_supply_fpregset)
 671         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
 672         (mips_fill_fpregset_wrapper): Remove functions.
 673         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
 674         (mips_linux_fpregset): Remove variable.
 675         (mips_linux_iterate_over_regset_sections): Use
 676         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
 677         (mips_linux_o32_sigframe_init): Remove comment.
 678
 679 2018-05-25  Pedro Alves  <palves@redhat.com>
 680
 681         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
 682         (struct readahead_cache, struct packet_reg, struct
 683         remote_arch_state, class remote_state): Move higher up in the
 684         file.
 685         (remote_target::m_remote_state): Now an object instead of a pointer.
 686         (remote_target::get_remote_state): Adjust.
 687
 688 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 689
 690         * stack.c (select_and_print_frame): Delete.
 691         (struct function_bounds): Move struct within function.
 692         (func_command): Most content moved into new function
 693         find_frame_for_function, use new function, print result, add
 694         function comment.
 695         (find_frame_for_function): New function, now returns a result.
 696
 697 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 698
 699         * stack.c (iterate_over_block_arg_vars): Fix comment.
 700         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
 701
 702 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 703
 704         PR gdb/23203
 705         * frame.c
 706         (scoped_restore_selected_frame::scoped_restore_selected_frame):
 707         Define.
 708         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
 709         Define.
 710         * frame.h (class scoped_restore_selected_frame): New class.
 711         * stack.c (print_frame_local_vars): Remove catching and rethrowing
 712         of any exception, use scoped_restore_selected_frame to restore the
 713         frame instead.
 714
 715 2018-05-24  Pedro Alves  <palves@redhat.com>
 716
 717         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
 718         override.
 719
 720 2018-05-23  Tom Tromey  <tom@tromey.com>
 721
 722         * complaints.c (struct complaints): Remove.
 723         (symfile_complaint_book): Remove.
 724         (series): New global.
 725         (complaint_internal): Update.
 726         (clear_complaints): Update.
 727
 728 2018-05-23  Tom Tromey  <tom@tromey.com>
 729
 730         * complaints.c (counters): New global.
 731         (struct complain): Remove.
 732         (struct complaints) <root>: Remove.
 733         (complaint_sentinel): Remove.
 734         (symfile_complaint_book): Update.
 735         (find_complaint) Remove.
 736         (complaint_internal, clear_complaints): Update.
 737
 738 2018-05-23  Tom Tromey  <tom@tromey.com>
 739
 740         * complaints.c (struct complain) <file, line>: Remove.
 741         (find_complaint): Remove file, line parameters.
 742         (complaint_internal): Update.
 743
 744 2018-05-23  Tom Tromey  <tom@tromey.com>
 745
 746         * complaints.c (vcomplaint): Remove.
 747         (complaint_internal) Merge in contents of vcomplaint.
 748
 749 2018-05-23  Tom Tromey  <tom@tromey.com>
 750
 751         * complaints.c (struct complaints) <explanation>: Remove.
 752         (symfile_explanations): Remove.
 753         (symfile_complaint_book): Update.
 754         (vcomplaint): Update.
 755         (struct explanation): Remove.
 756
 757 2018-05-23  Tom Tromey  <tom@tromey.com>
 758
 759         * complaints.c (symfile_complaints): Remove.
 760         (complaint_internal): Remove "complaints" parameter.
 761         (clear_complaints, vcomplaint): Remove "c" parameter.
 762         (get_complaints): Remove.
 763         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
 764         (dwarf2_debug_line_missing_file_complaint)
 765         (dwarf2_debug_line_missing_end_sequence_complaint)
 766         (dwarf2_complex_location_expr_complaint)
 767         (dwarf2_const_value_length_mismatch_complaint)
 768         (dwarf2_section_buffer_overflow_complaint)
 769         (dwarf2_macro_malformed_definition_complaint)
 770         (dwarf2_invalid_attrib_class_complaint)
 771         (create_addrmap_from_index, dw2_symtab_iter_next)
 772         (dw2_expand_marked_cus)
 773         (dw2_debug_names_iterator::find_vec_in_debug_names)
 774         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
 775         (create_debug_type_hash_table, init_cutu_and_read_dies)
 776         (partial_die_parent_scope, add_partial_enumeration)
 777         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
 778         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
 779         (read_import_statement, read_file_scope, create_dwo_cu_reader)
 780         (create_cus_hash_table, create_dwp_hash_table)
 781         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
 782         (dwarf2_rnglists_process, dwarf2_ranges_process)
 783         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
 784         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
 785         (handle_struct_member_die, process_structure_scope)
 786         (read_array_type, read_common_block, read_module_type)
 787         (read_tag_pointer_type, read_typedef, read_base_type)
 788         (read_subrange_type, load_partial_dies, partial_die_info::read)
 789         (partial_die_info::read, partial_die_info::read)
 790         (partial_die_info::read, read_checked_initial_length_and_offset)
 791         (dwarf2_string_attr, read_formatted_entries)
 792         (dwarf_decode_line_header)
 793         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 794         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
 795         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
 796         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
 797         (get_signatured_type, get_DW_AT_signature_type)
 798         (decode_locdesc, file_file_name, consume_improper_spaces)
 799         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
 800         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 801         (dwarf2_symbol_mark_computed, set_die_type)
 802         (read_attribute_value): Update.
 803         * stap-probe.c (handle_stap_probe, get_stap_base_address):
 804         Update.
 805         * dbxread.c (unknown_symtype_complaint)
 806         (lbrac_mismatch_complaint, repeated_header_complaint)
 807         (set_namestring, function_outside_compilation_unit_complaint)
 808         (read_dbx_symtab, process_one_symbol): Update.
 809         * gdbtypes.c (stub_noname_complaint): Update.
 810         * windows-nat.c (handle_unload_dll): Update.
 811         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
 812         (decode_base_type): Update.
 813         * xcoffread.c (bf_notfound_complaint, ef_complaint)
 814         (eb_complaint, record_include_begin, record_include_end)
 815         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
 816         (process_xcoff_symbol, read_symbol)
 817         (function_outside_compilation_unit_complaint)
 818         (scan_xcoff_symtab): Update.
 819         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
 820         * buildsym.c (finish_block_internal, make_blockvector)
 821         (end_symtab_get_static_block, augment_type_symtab): Update.
 822         * dtrace-probe.c (dtrace_process_dof)
 823         (dtrace_static_probe_ops::get_probes): Update.
 824         * complaints.h (struct complaint): Don't declare.
 825         (symfile_complaints): Remove.
 826         (complaint_internal): Remove "complaints" parameter.
 827         (complaint): Likewise.
 828         (clear_complaints): Likewise.
 829         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 830         (reread_symbols): Update.
 831         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
 832         (dwarf2_frame_cache, decode_frame_entry): Update.
 833         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
 834         * objc-lang.c (lookup_objc_class, lookup_child_selector)
 835         (info_selectors_command): Update.
 836         * macrotab.c (macro_include, check_for_redefinition)
 837         (macro_undef): Update.
 838         * objfiles.c (filter_overlapping_sections): Update.
 839         * stabsread.c (invalid_cpp_abbrev_complaint)
 840         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
 841         (define_symbol, error_type, read_type, rs6000_builtin_type)
 842         (stabs_method_name_from_physname, read_member_functions)
 843         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
 844         (attach_fields_to_type, complain_about_struct_wipeout)
 845         (read_range_type, read_args, common_block_start)
 846         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
 847         Update.
 848         * mdebugread.c (index_complaint, unknown_ext_complaint)
 849         (basic_type_complaint, bad_tag_guess_complaint)
 850         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
 851         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
 852         (parse_procedure, parse_lines)
 853         (function_outside_compilation_unit_complaint)
 854         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
 855         (bad_tag_guess_complaint, reg_value_complaint): Update.
 856         * cp-support.c (demangled_name_complaint): Update.
 857         * macroscope.c (sal_macro_scope): Update.
 858         * dwarf-index-write.c (class debug_names): Update.
 859
 860 2018-05-23  Tom Tromey  <tom@tromey.com>
 861
 862         * complaints.c (clear_complaints): Remove "noisy" parameter.
 863         * complaints.h (clear_complaints): Update.
 864         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 865         (reread_symbols): Update.
 866
 867 2018-05-23  Tom Tromey  <tom@tromey.com>
 868
 869         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
 870         SUBSEQUENT_MESSAGE.
 871         (vcomplaint, clear_complaints): Update.
 872         (symfile_explanations): Remove some messages.
 873
 874 2018-05-23  Tom Tromey  <tom@tromey.com>
 875
 876         * complaints.c (internal_complaint): Remove.
 877         * complaints.h (internal_complaint): Remove.
 878
 879 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 880
 881         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
 882
 883 2018-05-22  Pedro Alves  <palves@redhat.com>
 884
 885         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
 886         (remote_fileio_badfd, remote_fileio_return_errno)
 887         (remote_fileio_return_success, remote_fileio_func_open)
 888         (remote_fileio_func_open, remote_fileio_func_close)
 889         (remote_fileio_func_read, remote_fileio_func_write)
 890         (remote_fileio_func_lseek, remote_fileio_func_rename)
 891         (remote_fileio_func_unlink, remote_fileio_func_stat)
 892         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
 893         (remote_fileio_func_isatty, remote_fileio_func_system): Add
 894         remote_target parameter.
 895         (remote_fio_func_map) <func>: Add remote_target parameter.
 896         (do_remote_fileio_request, remote_fileio_request):
 897         * remote-fileio.h (remote_fileio_request):
 898         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
 899         remote_target parameter.
 900         (remote_notif_process, handle_notification): Adjust to pass down
 901         the remote.
 902         (remote_notif_state_allocate): Add remote_target parameter.  Save
 903         it.
 904         * remote-notif.h (struct remote_target): Forward declare.
 905         (struct notif_client) <parse, ack, can_get_pending_events>: Add
 906         remote_target parameter.
 907         (struct remote_notif_state) <remote>: New field.
 908         (remote_notif_ack, remote_notif_parse): Add remote_target
 909         parameter.
 910         (remote_notif_state_allocate, remote_notif_state_allocate): Add
 911         remote_target parameter.
 912         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
 913         (threads_listing_context, rmt_thread_action, protocol_feature)
 914         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
 915         (packet_result, struct threads_listing_context, remote_state):
 916         Move definitions and declarations higher up.
 917         (remote_target) <~remote_target>: Declare.
 918         (remote_download_command_source, remote_file_put, remote_file_get)
 919         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
 920         (remote_hostio_pread_vFile, remote_hostio_send_command)
 921         (remote_hostio_set_filesystem, remote_hostio_open)
 922         (remote_hostio_close, remote_hostio_unlink, remote_state)
 923         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
 924         (get_memory_write_packet_size, get_memory_read_packet_size)
 925         (append_pending_thread_resumptions, remote_detach_1)
 926         (append_resumption, remote_resume_with_vcont)
 927         (add_current_inferior_and_thread, wait_ns, wait_as)
 928         (process_stop_reply, remote_notice_new_inferior)
 929         (process_initial_stop_replies, remote_add_thread)
 930         (btrace_sync_conf, remote_btrace_maybe_reopen)
 931         (remove_new_fork_children, kill_new_fork_children)
 932         (discard_pending_stop_replies, stop_reply_queue_length)
 933         (check_pending_events_prevent_wildcard_vcont)
 934         (discard_pending_stop_replies_in_queue, stop_reply)
 935         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
 936         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
 937         (remote_interrupt_as, remote_interrupt_ns)
 938         (remote_get_noisy_reply, remote_query_attached)
 939         (remote_add_inferior, remote_current_thread, get_current_thread)
 940         (set_thread, set_general_thread, set_continue_thread)
 941         (set_general_process, write_ptid)
 942         (remote_unpack_thread_info_response, remote_get_threadinfo)
 943         (parse_threadlist_response, remote_get_threadlist)
 944         (remote_threadlist_iterator, remote_get_threads_with_ql)
 945         (remote_get_threads_with_qxfer)
 946         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
 947         (get_offsets, remote_check_symbols, remote_supported_packet)
 948         (remote_query_supported, remote_packet_size)
 949         (remote_serial_quit_handler, remote_detach_pid)
 950         (remote_vcont_probe, remote_resume_with_hc)
 951         (send_interrupt_sequence, interrupt_query)
 952         (remote_notif_get_pending_events, fetch_register_using_p)
 953         (send_g_packet, process_g_packet, fetch_registers_using_g)
 954         (store_register_using_P, store_registers_using_G)
 955         (set_remote_traceframe, check_binary_download)
 956         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
 957         (remote_xfer_live_readonly_partial, remote_read_bytes)
 958         (remote_send_printf, remote_flash_write, readchar)
 959         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
 960         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
 961         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
 962         (extended_remote_disable_randomization, extended_remote_run)
 963         (send_environment_packet, extended_remote_environment_support)
 964         (extended_remote_set_inferior_cwd, remote_write_qxfer)
 965         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
 966         (packet_command): Now methods of ...
 967         (remote_target): ... this class.
 968         (m_remote_state) <remote_target>: New field.
 969         (struct remote_state) <stop_reply_queue,
 970         remote_async_inferior_event_token, wait_forever_enabled_p>: New
 971         fields.
 972         (remote_state::remote_state): Allocate stop_reply_queue.
 973         (remote_state): Delete global.
 974         (get_remote_state_raw): Delete.
 975         (remote_target::get_remote_state): Allocate m_remote_state on
 976         demand.
 977         (get_current_remote_target): New.
 978         (remote_ops, extended_remote_ops): Delete.
 979         (wait_forever_enabled_p, remote_async_inferior_event_token):
 980         Delete, moved to struct remote_state.
 981         (remote_target::close): Delete self.  Destruction bits split to
 982         ...
 983         (remote_target::~remote_target): ... this.
 984         (show_memory_packet_size): Adjust to use
 985         get_current_remote_target.
 986         (struct protocol_feature) <func>: Add remote_target parameter.
 987         All callers adjusted.
 988         (curr_quit_handler_target): New.
 989         (remote_serial_quit_handler): Reimplement.
 990         (remote_target::open_1): Adjust to use get_current_remote_target.
 991         Heap-allocate remote_target/extended_remote_target instances.
 992         (vcont_builder::vcont_builder): Add remote_target parameter, and
 993         save it in m_remote.  All callers adjusted.
 994         (vcont_builder::m_remote): New field.
 995         (vcont_builder::restart, vcont_builder::flush)
 996         (vcont_builder::push_action): Use it.
 997         (remote_target::commit_resume): Use it.
 998         (struct queue_iter_param) <remote>: New field.
 999         (remote_target::remove_new_fork_children): Fill in 'remote' field.
1000         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
1001         (check_pending_event_prevents_wildcard_vcont_callback)
1002         (remote_target::check_pending_events_prevent_wildcard_vcont)
1003         (remote_target::discard_pending_stop_replies)
1004         (remote_target::discard_pending_stop_replies_in_queue)
1005         (remote_target::remote_notif_remove_queued_reply): Fill in
1006         'remote' field.
1007         (remote_notif_get_pending_events): New.
1008         (remote_target::readchar, remote_target::remote_serial_write):
1009         Save/restore curr_quit_handler_target.
1010         (putpkt): New.
1011         (kill_new_fork_children): Fill in 'remote' field.
1012         (packet_command): Use get_current_remote_target, defer to
1013         remote_target method of same name.
1014         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
1015         parameter, and save it in m_remote.  All callers adjusted.
1016         (scoped_remote_fd::release): Use m_remote.
1017         (scoped_remote_fd::m_remote): New field.
1018         (remote_file_put, remote_file_get, remote_file_delete): Use
1019         get_current_remote_target, defer to remote_target method of same
1020         name.
1021         (remote_btrace_reset): Add remote_state paremeter.  Update all
1022         callers.
1023         (remote_async_inferior_event_handler). Pass down 'data'.
1024         (remote_new_objfile): Use get_current_remote_target.
1025         (remote_target::vcont_r_supported): New.
1026         (set_range_stepping): Use get_current_remote_target and
1027         remote_target::vcont_r_supported.
1028         (_initialize_remote): Don't allocate 'remote_state' and
1029         'stop_reply_queue' globals.
1030         * remote.h (struct remote_target): Forward declare.
1031         (getpkt, putpkt, remote_notif_get_pending_events): Add
1032         'remote_target' parameter.
1033
1034 2018-05-22  Pedro Alves  <palves@redhat.com>
1035
1036         * remote.c (vcont_builder): Now a class.  Make all data members
1037         private.
1038         (vcont_builder) <vcont_builder, restart, flush, push_action>:
1039         Declare methods.
1040         (vcont_builder_restart): Rename to ...
1041         (vcont_builder::restart): ... this.
1042         (vcont_builder_flush): Rename to ...
1043         (vcont_builder::flush): ... this.
1044         (vcont_builder_push_action): Rename to ...
1045         (vcont_builder::push_action): ... this.
1046         (remote_target::commit_resume): Adjust.
1047
1048 2018-05-22  Pedro Alves  <palves@redhat.com>
1049
1050         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
1051         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
1052         (get_fixed_memory_packet_size): New.
1053         (get_memory_packet_size): Use it.
1054         (set_memory_packet_size): Don't override the config size with
1055         DEFAULT_MAX_MEMORY_PACKET_SIZE.
1056         (show_memory_packet_size): Use get_fixed_memory_packet_size.
1057         Don't refer to get_memory_packet_size if not connected to a remote
1058         target.  Show "(default)" if configured size is 0.
1059
1060 2018-05-22  Pedro Alves  <palves@redhat.com>
1061
1062         * remote.c (remote_target::mourn_inferior): Move
1063         discard_pending_stop_replies call here from ...
1064         (_initialize_remote): ... here.
1065
1066 2018-05-22  Pedro Alves  <palves@redhat.com>
1067
1068         * remote.c (compare_section_command): Remove set_general_process
1069         call.
1070
1071 2018-05-22  Pedro Alves  <palves@redhat.com>
1072
1073         * remote.c (struct packet_reg, struct remote_arch_state):
1074         Move higher up in the file.
1075         (remote_state) <m_arch_states>: Store remote_arch_state values
1076         instead of remote_arch_state pointers.
1077         (remote_state::get_remote_arch_state): Adjust.
1078
1079 2018-05-22  Pedro Alves  <palves@redhat.com>
1080
1081         * remote.c: Include <unordered_map>.
1082         (remote_state): Now a class.
1083         (remote_state) <get_remote_arch_state>: Declare method.
1084         <get_remote_arch_state>: New field.
1085         (remote_arch_state) <remote_arch_state>: Declare ctor.
1086         <regs>: Now a unique_ptr.
1087         (remote_gdbarch_data_handle): Delete.
1088         (get_remote_arch_state): Delete.
1089         (remote_state::get_remote_arch_state): New.
1090         (get_remote_state): Adjust to call remote_state's
1091         get_remote_arch_state method.
1092         (init_remote_state): Delete, bits factored out to ...
1093         (remote_arch_state::remote_arch_state): ... this new method.
1094         (get_remote_packet_size, get_memory_packet_size)
1095         (process_g_packet, remote_target::fetch_registers)
1096         (remote_target::prepare_to_store, store_registers_using_G)
1097         (remote_target::store_registers, remote_target::get_trace_status):
1098         Adjust to call remote_state's method.
1099         (_initialize_remote): Remove reference to
1100         remote_gdbarch_data_handle.
1101
1102 2018-05-22  Pedro Alves  <palves@redhat.com>
1103
1104         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
1105         pread>: New method declarations.
1106         (remote_target::open_1): Adjust.
1107         (readahead_cache_invalidate): Rename to ...
1108         (readahead_cache::invalidate): ... this, and adjust to be a class
1109         method.
1110         (readahead_cache_invalidate_fd): Rename to ...
1111         (readahead_cache::invalidate_fd): ... this, and adjust to be a
1112         class method.
1113         (remote_hostio_pwrite): Adjust.
1114         (remote_hostio_pread_from_cache): Rename to ...
1115         (readahead_cache::pread): ... this, and adjust to be a class
1116         method.
1117         (remote_hostio_close): Adjust.
1118
1119 2018-05-22  Pedro Alves  <palves@redhat.com>
1120
1121         * remote.c (remote_hostio_close_cleanup): Delete.
1122         (class scoped_remote_fd): New.
1123         (remote_file_put, remote_file_get): Use it.
1124
1125 2018-05-22  Pedro Alves  <palves@redhat.com>
1126
1127         (struct vCont_action_support): Use bool and initialize all fields.
1128         (struct readahead_cache): Initialize all fields.
1129         (remote_state): Use bool and initialize all fields.
1130         (remote_state::remote_state, remote_state::~remote_state): New.
1131         (new_remote_state): Delete.
1132         (_initialize_remote): Use new to allocate remote_state.
1133
1134 2018-05-22  Pedro Alves  <palves@redhat.com>
1135             張俊芝  <zjz@zjz.name>
1136
1137         PR gdb/22973
1138         * c-exp.y: Include "c-support.h".
1139         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
1140         of tolower.  Use c_ident_is_alpha to scan names.
1141         * c-lang.c: Include "c-support.h".
1142         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
1143         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
1144         * c-support.h: New file, with bits factored out from ...
1145         * cp-name-parser.y: ... this file.
1146         Include "c-support.h".
1147         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
1148         c-support.h and renamed.
1149         (symbol_end, yylex): Adjust.
1150
1151 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1152
1153         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
1154         parameter type to CORE_ADDR.
1155         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
1156         parameter type in declaration to CORE_ADDR.
1157         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
1158         target_auxv_search to get AT_HWCAP and use the result to get the
1159         target description.
1160         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
1161         to CORE_ADDR. Remove the cast of the return value to unsigned
1162         long. Fix error predicate of target_auxv_search.
1163         (ppc_linux_nat_target::read_description): Change the type of the
1164         hwcap variable to CORE_ADDR.
1165
1166 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1167
1168         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
1169         if the size of fpscr is larger than 32 bits.
1170
1171 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1172
1173         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
1174         (ppc32_linux_vsxregmap): New global.
1175         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
1176         regcache_supply_regset, and regcache_collect_regset.
1177         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
1178         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
1179         (fetch_vsx_register, store_vsx_register): Remove.
1180         (fetch_vsx_registers): Add regno parameter. Get regset using
1181         ppc_linux_vsxregset. Use regset to supply registers.
1182         (store_vsx_registers): Add regno parameter. Get regset using
1183         ppc_linux_vsxregset. Use regset to collect registers.
1184         (fetch_register): Call fetch_vsx_registers instead of
1185         fetch_vsx_register.
1186         (store_register): Call store_vsx_registers instead of
1187         store_vsx_register.
1188         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
1189         new regno parameter.
1190         (store_ppc_registers): Call store_vsx_registers with -1 for the
1191         new regno parameter.
1192         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
1193         (ppc_collect_vsxregset): Remove.
1194
1195 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1196
1197         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
1198         offset fields.
1199         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
1200         for vector register offset fields.
1201         (ppc64_fbsd_reg_offsets): Likewise.
1202         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
1203         to vector register offset fields.
1204         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
1205         to vector register offset fields.
1206         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
1207         vector register offset fields.
1208         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
1209         initializers for vector register offset fields.
1210         (rs6000_aix64_reg_offsets): Likewise.
1211         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
1212         (ppc_supply_vrregset): Remove.
1213         (ppc_collect_vrregset): Remove.
1214         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
1215         (ppc_linux_vrregset) : New function.
1216         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
1217         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
1218         (ppc32_linux_vrregset): Remove.
1219         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
1220         and use result instead of ppc32_linux_vrregset.
1221         (ppc32_linux_reg_offsets): Remove initializers for vector register
1222         offset fields.
1223         (ppc64_linux_reg_offsets): Likewise.
1224         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
1225         * ppc-linux-nat.c: Include regset.h.
1226         (gdb_vrregset_t): Adjust comment to account for little-endian
1227         mode.
1228         (supply_vrregset, fill_vrregset): Remove.
1229         (fetch_altivec_register, store_altivec_register): Remove.
1230         (fetch_altivec_registers): Add regno parameter. Get regset using
1231         ppc_linux_vrregset. Use regset to supply registers.
1232         (store_altivec_registers): Add regno parameter. Get regset using
1233         ppc_linux_vrregset. Use regset to collect registers.
1234         (fetch_register): Call fetch_altivec_registers instead of
1235         fetch_altivec_register.
1236         (store_register): Call store_altivec_registers instead of
1237         store_altivec_register.
1238         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
1239         the new regno parameter.
1240         (store_ppc_registers): Call store_altivec_registers with -1 for
1241         the new regno parameter.
1242
1243 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1244
1245         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
1246         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
1247         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
1248         (gdb_vrregset_t): Change array type size to
1249         PPC_LINUX_SIZEOF_VRREGSET.
1250         (gdb_vsxregset_t): Change array type size to
1251         PPC_LINUX_SIZEOF_VSXREGSET.
1252         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
1253         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
1254         PPC_LINUX_SIZEOF_VSXREGSET.
1255
1256 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1257
1258         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
1259         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
1260         nat/ppc-linux.c.
1261         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
1262         ppc_linux_target_wordsize with tid.
1263         (ppc_linux_nat_target::read_description): Call ppc_linux_target
1264         wordsize with tid.
1265         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
1266         (ppc64_64bit_inferior_p): Add static and inline specifiers.
1267         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
1268         tid parameter. Remove static specifier.
1269         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
1270         (ppc_linux_target_wordsize): New declaration.
1271
1272 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1273
1274         * arch/ppc-linux-common.c: New file.
1275         * arch/ppc-linux-common.h: New file.
1276         * arch/ppc-linux-tdesc.h: New file.
1277         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
1278         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
1279         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
1280         arch/ppc-linux-tdesc.h.
1281         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
1282         arch/ppc-linux-tdesc.h.
1283         (ppc_linux_nat_target::read_description): Remove target
1284         description matching code. Fill a ppc_linux_features struct and
1285         call ppc_linux_match_description with it. Move comment about ISA
1286         2.05 to ppc-linux-common.c.
1287         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
1288         arch/ppc-linux-tdesc.h.
1289         (ppc_linux_core_read_description): Remove target description
1290         matching code. Fill a ppc_linux_features struct and call
1291         ppc_linux_match_description with it.
1292         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
1293         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
1294         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
1295         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
1296         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
1297         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
1298         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
1299         (tdesc_powerpc_e500l): Remove.
1300
1301 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
1302
1303         * ada-lang.c (catch_assert_command): Pass empty string instead
1304         of NULL for excep_string argument.
1305
1306 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
1307
1308         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
1309         the width of the requested register exceeds the width of the
1310         `ptrace' data type.
1311
1312 2018-05-21  Tom Tromey  <tom@tromey.com>
1313
1314         * printcmd.c (output_command): Remove.
1315         (output_command_const): Rename to output_command.
1316         * valprint.h (output_command): Rename from output_command_const.
1317         * tracepoint.c (trace_dump_actions): Call output_command.
1318
1319 2018-05-21  Tom Tromey  <tom@tromey.com>
1320
1321         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
1322         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
1323         * ada-lang.h (create_ada_exception_catchpoint): Update.
1324         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
1325         std::string.
1326         (create_excep_cond_exprs, ~ada_catchpoint)
1327         (should_stop_exception, print_one_exception)
1328         (print_mention_exception, print_recreate_exception): Update.
1329         (ada_get_next_arg): Remove.
1330         (catch_ada_exception_command_split): Use std::string.  Change type
1331         of "excep_string", "cond_string".
1332         (catch_ada_exception_command): Update.
1333         (create_ada_exception_catchpoint): Change type of excep_string.
1334         (ada_exception_sal): Remove excep_string parameter.
1335         (~ada_catchpoint): Remove.
1336
1337 2018-05-21  Tom Tromey  <tom@tromey.com>
1338
1339         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
1340         cleanup.
1341
1342 2018-05-21  Tom Tromey  <tom@tromey.com>
1343
1344         * ada-lang.c (ada_exception_message_1, ada_exception_message):
1345         Return unique_xmalloc_ptr.
1346         (print_it_exception): Update.
1347
1348 2018-05-21  Tom Tromey  <tom@tromey.com>
1349
1350         * tracepoint.c (trace_dump_actions): Use std::string.
1351
1352 2018-05-21  Tom Tromey  <tom@tromey.com>
1353
1354         * symfile.c (reread_symbols): Use std::string for original_name.
1355
1356 2018-05-21  Tom Tromey  <tom@tromey.com>
1357
1358         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
1359         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
1360         constructor.
1361
1362 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
1363
1364         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
1365         instance to...
1366         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
1367         * objfiles.c (get_objfile_bfd_data): Allocate
1368         objfile_per_bfd_storage with obstack_new when allocating on
1369         obstack.
1370
1371 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1372
1373         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
1374         OBSTACK_ZALLOC.
1375         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
1376         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
1377         * mdebugread.c (mdebug_build_psymtabs): Likewise.
1378         (add_pending): Likewise.
1379         (parse_symbol): Likewise.
1380         (parse_partial_symbols): Likewise.
1381         (psymtab_to_symtab_1): Likewise.
1382         (new_psymtab): Likewise.
1383         (elfmdebug_build_psymtabs): Likewise.
1384         * minsyms.c (terminate_minimal_symbol_table): Likewise.
1385         * objfiles.c (get_objfile_bfd_data): Likewise.
1386         (objfile_register_static_link): Likewise.
1387         * psymtab.c (allocate_psymtab): Likewise.
1388         * stabsread.c (read_member_functions): Likewise.
1389         * xcoffread.c (xcoff_end_psymtab): Likewise.
1390
1391 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1392
1393         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
1394         compiler supports std::is_trivially_constructible.
1395         * common/poison.h: Include obstack.h.
1396         (IsMallocable): Define to is_trivially_constructible if the
1397         compiler supports it, define to true_type otherwise.
1398         (xobnew): New.
1399         (XOBNEW): Redefine.
1400         (xobnewvec): New.
1401         (XOBNEWVEC): Redefine.
1402         * gdb_obstack.h (obstack_zalloc): New.
1403         (OBSTACK_ZALLOC): Redefine.
1404         (obstack_calloc): New.
1405         (OBSTACK_CALLOC): Redefine.
1406         (obstack_new): New.
1407         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
1408         (gdbarch_obstack): New declaration in gdbarch.h, definition in
1409         gdbarch.c.
1410         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
1411         obstack_calloc/obstack_zalloc.
1412         (gdbarch_obstack_zalloc): Remove.
1413         * target-descriptions.c (tdesc_data_init): Use obstack_new.
1414
1415 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1416
1417         * stack.c (backtrace_command_1): Remove useless variable int i.
1418
1419 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1420
1421         * stack.c (print_frame_info): Fix comment.
1422
1423 2018-05-18  Tom Tromey  <tom@tromey.com>
1424
1425         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
1426         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
1427         (~dwarf2_per_objfile): Update
1428         (dwarf2_get_dwz_file): Use new.
1429         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
1430         unique_ptr.
1431
1432 2018-05-18  Tom Tromey  <tom@tromey.com>
1433
1434         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
1435         unique_ptr.
1436         * dwarf2read.c (struct dwp_file): Add constructor and
1437         initializers.
1438         (open_and_init_dwp_file): Return a unique_ptr.
1439         (dwarf2_per_objfile, create_dwp_hash_table)
1440         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
1441         (lookup_dwo_unit_in_dwp): Update.
1442         (open_and_init_dwp_file, get_dwp_file): Update.
1443
1444 2018-05-18  Tom Tromey  <tom@tromey.com>
1445
1446         * dwarf2read.c (dwarf2_per_objfile): Update.
1447         (struct mapped_index): Add initializers.
1448         (dwarf2_read_index): Use new.
1449         (dw2_symtab_iter_init): Update.
1450         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
1451         unique_ptr.
1452
1453 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1454
1455         * dwarf2read.c (mapped_index) <total_size>: Remove.
1456
1457 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1458
1459         * unittests/format_pieces-selftests.c (test_format_specifier):
1460         Add ARI comments.
1461
1462 2018-05-18  Tom Tromey  <tom@tromey.com>
1463
1464         * c-typeprint.c (maybe_print_hole): New function.
1465         (c_print_type_struct_field_offset): Update.
1466         (c_type_print_base_struct_union): Call maybe_print_hole.
1467
1468 2018-05-17  Keith Seitz  <keiths@redhat.com>
1469
1470         * breakpoint.c (build_bpstat_chain): New function, moved from
1471         bpstat_stop_status.
1472         (bpstat_stop_status): Add optional parameter, `stop_chain'.
1473         If no stop chain is passed, call build_bpstat_chain to build it.
1474         * breakpoint.h (build_bpstat_chain): Declare.
1475         (bpstat_stop_status): Move documentation here from breakpoint.c.
1476         * infrun.c (handle_signal_stop): Before eliding inlined frames,
1477         build the stop chain and pass it to skip_inline_frames.
1478         Pass this stop chain to bpstat_stop_status.
1479         * inline-frame.c: Include breakpoint.h.
1480         (stopped_by_user_bp_inline_frame): New function.
1481         (skip_inline_frames): Add parameter `stop_chain'.
1482         Move documention to inline-frame.h.
1483         If non-NULL, use stopped_by_user_bp_inline_frame to determine
1484         whether the frame should be elided.
1485         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
1486         Add moved documentation and update for new parameter.
1487
1488 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1489
1490         PR cli/14975
1491         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1492         unittests/format_pieces-selftests.c.
1493         * common/format.h (format_piece) <operator==>: New.
1494         (format_pieces) <operator[]>: Remove.
1495         * common/format.c (format_pieces::format_pieces): Handle \e.
1496         * unittests/format_pieces-selftests.c: New.
1497
1498 2018-05-17  Tom Tromey  <tom@tromey.com>
1499
1500         PR symtab/23010:
1501         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
1502         (dw2_instantiate_symtab): Add skip_partial parameter.
1503         (dw2_find_last_source_symtab, dw2_map_expand_apply)
1504         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
1505         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
1506         (dw2_expand_symtabs_matching_one)
1507         (dw2_find_pc_sect_compunit_symtab)
1508         (dw2_debug_names_lookup_symbol)
1509         (dw2_debug_names_expand_symtabs_for_function): Update.
1510         (init_cutu_and_read_dies): Add skip_partial parameter.
1511         (process_psymtab_comp_unit, build_type_psymtabs_1)
1512         (process_skeletonless_type_unit, load_partial_comp_unit)
1513         (psymtab_to_symtab_1): Update.
1514         (load_full_comp_unit): Add skip_partial parameter.
1515         (process_imported_unit_die, dwarf2_read_addr_index)
1516         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
1517         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
1518         (read_signatured_type): Update.
1519
1520 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1521
1522         * value.c (release_value): Remove unused variable.
1523         (record_latest_value): Likewise.
1524         (access_value_history): Likewise.
1525         (preserve_values): Likewise.
1526
1527 2018-05-17  Tom Tromey  <tom@tromey.com>
1528
1529         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1530         Initialize.
1531
1532 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1533
1534         PR gdb/22286
1535         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1536         Also handle registers whose width is not a multiple of
1537         PTRACE_TYPE_RET.
1538         (linux_nat_trad_target::store_register): Likewise.
1539
1540 2018-05-16  Tom Tromey  <tom@tromey.com>
1541
1542         * gdbcore.h (core_bfd): Redefine.
1543         * corelow.c (core_target::close): Update.
1544         (core_target_open): Update.
1545         * progspace.h (struct program_space) <cbfd>: Now a
1546         gdb_bfd_ref_ptr.
1547
1548 2018-05-16  Tom Tromey  <tom@tromey.com>
1549
1550         PR cli/19551:
1551         * symfile-add-flags.h (enum symfile_add_flags)
1552         <SYMFILE_NOT_FILENAME>: New constant.
1553         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1554         objfile name from BFD.
1555         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1556         * minidebug.c (find_separate_debug_file_in_section): Put
1557         ".gnu_debugdata" into BFD's file name.
1558
1559 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1560
1561         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1562         Remove.
1563
1564 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1565
1566         PR binutils/21446
1567         * aarch64-tdep.c (aarch64_analyze_prologue,
1568         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1569         Indicate not interested in errors.
1570
1571 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1572
1573         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1574         Supply the MIPS_ZERO_REGNUM register.
1575
1576 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1577
1578         * mips-tdep.c (mask_address_var): Make variable static.
1579
1580 2018-05-14  Tom Tromey  <tom@tromey.com>
1581
1582         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1583
1584 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1587         FXSAVE_ADDR for the mxcsr register.
1588
1589 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1590
1591         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1592
1593 2018-05-11  Pedro Alves  <palves@redhat.com>
1594
1595         * corelow.c (core_target) <core_target>: No longer inline.
1596         Initialize m_core_gdbarch, m_core_vec and build the section table
1597         here.
1598         <~core_target>: New.
1599         <core_gdbarch, get_core_register_section>: New methods.
1600         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1601         factored out from ...
1602         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1603         (core_ops): Delete.
1604         (sniff_core_bfd): Add gdbarch parameter.
1605         (core_close): Delete, merged into ...
1606         (core_target::close): ... here.  Delete self.
1607         (core_close_cleanup): Delete.
1608         (core_target_open): Allocate a core_target on the heap.  Use a
1609         unique_ptr instead of a cleanup.  Bits moved into the core_target
1610         ctor.  Adjust to use core_target methods instead of globals.
1611         (get_core_register_section): Rename to ...
1612         (core_target::get_core_register_section): ... this and adjust.
1613         (struct get_core_registers_cb_data): New.
1614         (get_core_registers_cb): Use it.  Use bool.
1615         (core_target::fetch_registers, core_target::files_info)
1616         (core_target::xfer_partial, core_target::read_description)
1617         (core_target::pid_to, core_target::thread_name): Adjust to
1618         reference class fields instead of globals.
1619         * target.h (struct target_ops_deleter, target_ops_up): New.
1620
1621 2018-05-11  Pedro Alves  <palves@redhat.com>
1622
1623         * corefile.c (core_file_command): Move to corelow.c.
1624         * corelow.c (the_core_target): Delete.
1625         (core_file_command): Moved from corefile.c.  Check exec_bfd
1626         instead of the_core_target.  Use target_detach instead of calling
1627         into the_core_target directly.
1628         (maybe_say_no_core_file_now): New.
1629         (core_target::detach): Use it.
1630         (_initialize_corelow): Remove references to the_core_target.
1631         * gdbcore.h (the_core_target): Delete.
1632
1633 2018-05-11  Tom Tromey  <tromey@redhat.com>
1634             Pedro Alves  <palves@redhat.com>
1635
1636         * corefile.c (core_bfd): Remove.
1637         * gdbcore.h (core_bfd): Now a macro.
1638         * progspace.h (struct program_space) <cbfd>: New field.
1639
1640 2018-05-11  Tom Tromey  <tom@tromey.com>
1641
1642         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1643         gdb::def_vector.
1644
1645 2018-05-10  Tom Tromey  <tom@tromey.com>
1646
1647         * configure: Rebuild.
1648         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1649
1650 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1651
1652         PR server/23158:
1653         * regformats/regdat.sh: Adjust script, following the addition
1654         of the new expedite_regs parameter to init_target_desc.
1655
1656 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1657
1658         PR gdb/23127
1659         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1660         set_gdbarch_significant_addr_bit.
1661         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1662         set_gdbarch_significant_addr_bit.
1663         * utils.c (address_significant): Update to sign extend addr.
1664
1665 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1666
1667         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1668         (xtensa_linux_init_abi): Limit tdep->num_regs by
1669         tdep->num_nopriv_regs.
1670         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1671         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1672         not initialized.
1673
1674 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1675
1676         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1677
1678 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1681         (I387_MXCSR_INIT_VAL): New constant.
1682         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1683         buffer if it was supplied by the inferior.
1684         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1685         (i387_xsave_get_clear_bv): New function.
1686         (i387_supply_xsave): Only read x87 control registers from the
1687         xsave buffer if the feature is enabled, and the state will have
1688         been written, otherwise, provide a suitable default.
1689         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1690         including x87 control registers.  Update control registers if they
1691         have changed from the default value, and mark features as enabled
1692         as required.
1693         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1694
1695 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1696
1697         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1698
1699 2018-05-07  Tom Tromey  <tom@tromey.com>
1700
1701         * configure: Rebuild.
1702         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1703
1704 2018-05-07  Tom Tromey  <tom@tromey.com>
1705
1706         PR tdep/20362:
1707         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1708         bit.  Use correct value for VDIV.
1709
1710 2018-05-04  Tom Tromey  <tom@tromey.com>
1711
1712         * configure: Rebuild.
1713         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1714
1715 2018-05-04  Tom Tromey  <tom@tromey.com>
1716
1717         * linux-record.c (record_linux_system_call) <case
1718         RECORD_SYS_RECVFROM>: Add "break".
1719
1720 2018-05-04  Tom Tromey  <tom@tromey.com>
1721
1722         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1723         Add missing "break".
1724         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1725         Add missing "break".
1726
1727 2018-05-04  Tom Tromey  <tom@tromey.com>
1728
1729         * rs6000-tdep.c (ppc_process_record_op4)
1730         (ppc_process_record_op63): Add fall-through comment.
1731
1732 2018-05-04  Tom Tromey  <tom@tromey.com>
1733
1734         * i386-tdep.c (i386_process_record): Add fall-through comment.
1735
1736 2018-05-04  Tom Tromey  <tom@tromey.com>
1737
1738         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1739         comment.
1740
1741 2018-05-04  Tom Tromey  <tom@tromey.com>
1742
1743         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1744         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1745         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1746         comment.
1747         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1748         comment.
1749         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1750         comment.
1751
1752 2018-05-04  Tom Tromey  <tom@tromey.com>
1753
1754         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1755
1756 2018-05-04  Tom Tromey  <tom@tromey.com>
1757
1758         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1759         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1760         * symfile.c (section_is_mapped): Fix fall-through comment.
1761         * stabsread.c (define_symbol, read_member_functions): Fix
1762         fall-through comment.
1763         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1764         comment.
1765         * remote.c (remote_wait_as): Fix fall-through comment.
1766         * p-exp.y (yylex): Fix fall-through comment.
1767         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1768         comment.
1769         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1770         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1771         * jv-exp.y (yylex): Fix fall-through comment.
1772         * go-exp.y (lex_one_token): Fix fall-through comment.
1773         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1774         fall-through comment.
1775         * f-exp.y (yylex): Fix fall-through comment.
1776         * dwarf2read.c (process_die): Fix fall-through comments.
1777         * dbxread.c (process_one_symbol): Fix fall-through comment.
1778         * d-exp.y (lex_one_token): Fix fall-through comment.
1779         * cp-name-parser.y (yylex): Fix fall-through comment.
1780         * coffread.c (coff_symtab_read): Fix fall-through comment.
1781         * c-exp.y (lex_one_token): Fix fall-through comment.
1782         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1783         comment.
1784         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1785         comment.
1786
1787 2018-05-04  Tom Tromey  <tom@tromey.com>
1788
1789         PR python/22730:
1790         * NEWS: Mention gdb.execute change.
1791         * gdbcmd.h (execute_control_command): Don't declare.
1792         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1793         execute_control_commands, execute_control_commands_to_string.
1794         * cli/cli-script.h (execute_control_commands)
1795         (execute_control_commands_to_string): Declare.
1796         (execute_control_command): Add from_tty parameter.
1797         * cli/cli-script.c (execute_control_commands)
1798         (execute_control_commands_to_string): New functions.
1799         (execute_user_command): Use execute_control_commands.
1800         (execute_control_command_1): Add "from_tty" parameter.  Update.
1801         (execute_control_command): Likewise.
1802
1803 2018-05-04  Tom Tromey  <tom@tromey.com>
1804
1805         PR python/22731:
1806         * NEWS: Mention that breakpoint commands are writable.
1807         * python/py-breakpoint.c (bppy_set_commands): New function.
1808         (breakpoint_object_getset) <"commands">: Use it.
1809
1810 2018-05-04  Tom Tromey  <tom@tromey.com>
1811
1812         * tracepoint.c (actions_command): Update.
1813         * mi/mi-cmd-break.c (mi_command_line_array)
1814         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1815         (mi_read_next_line): Remove.
1816         (mi_cmd_break_commands): Update.
1817         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1818         function_view.
1819         * cli/cli-script.c (get_command_line): Update.
1820         (process_next_line): Use function_view.  Constify.
1821         (recurse_read_control_structure, read_command_lines)
1822         (read_command_lines_1): Change argument types to function_view.
1823         (do_define_command, document_command): Update.
1824         * breakpoint.h (check_tracepoint_command): Don't declare.
1825         * breakpoint.c (check_tracepoint_command): Remove.
1826         (commands_command_1, create_tracepoint_from_upload): Update.
1827
1828 2018-05-04  Tom Tromey  <tom@tromey.com>
1829
1830         PR gdb/11750:
1831         * cli/cli-script.h (enum command_control_type) <define_control>:
1832         New constant.
1833         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1834         (build_command_line, execute_control_command_1)
1835         (process_next_line): Likewise.
1836         (do_define_command): New function, extracted from define_command.
1837         (define_command): Use it.
1838
1839 2018-05-04  Tom Tromey  <tom@tromey.com>
1840
1841         * tracepoint.c (actions_command): Update.
1842         * cli/cli-script.h (read_command_lines): Update.
1843         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1844         (MAX_TMPBUF): Remove define.
1845         (define_command): Use string_printf.
1846         (document_command): Likewise.
1847         * breakpoint.c (commands_command_1): Update.
1848
1849 2018-05-04  Tom Tromey  <tom@tromey.com>
1850
1851         * top.c (execute_command): Update.
1852         * cli/cli-script.h (print_command_lines): Now varargs.
1853         * cli/cli-script.c (print_command_lines): Now varargs.
1854         (execute_control_command_1) <case while_control, case if_control>:
1855         Update.
1856
1857 2018-05-04  Tom Tromey  <tom@tromey.com>
1858
1859         * tracepoint.c (all_tracepoint_actions): Rename from
1860         all_tracepoint_actions_and_cleanup.  Change return type.
1861         (actions_command, encode_actions_1, encode_actions)
1862         (trace_dump_actions, tdump_command): Update.
1863         * remote.c (remote_download_command_source): Update.
1864         * python/python.c (gdbpy_eval_from_control_command)
1865         (python_command, python_interactive_command): Update.
1866         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1867         * guile/guile.c (guile_command)
1868         (gdbscm_eval_from_control_command, guile_command): Update.
1869         * compile/compile.c (compile_code_command)
1870         (compile_print_command, compile_to_object): Update.
1871         * cli/cli-script.h (struct command_lines_deleter): New.
1872         (counted_command_line): New typedef.
1873         (struct command_line): Add constructor, destructor.
1874         <body_list>: Remove.
1875         <body_list_0, body_list_1>: New members.
1876         (command_line_up): Remove typedef.
1877         (read_command_lines, read_command_lines_1, get_command_line):
1878         Update.
1879         (copy_command_lines): Don't declare.
1880         * cli/cli-script.c (build_command_line): Use "new".
1881         (get_command_line): Return counted_command_line.
1882         (print_command_lines, execute_user_command)
1883         (execute_control_command_1, while_command, if_command): Update.
1884         (realloc_body_list): Remove.
1885         (process_next_line, recurse_read_control_structure): Update.
1886         (read_command_lines, read_command_lines_1): Return counted_command_line.
1887         (free_command_lines): Use "delete".
1888         (copy_command_lines): Remove.
1889         (define_command, document_command, show_user_1): Update.
1890         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1891         a counted_command_line.
1892         * breakpoint.h (counted_command_line): Remove typedef.
1893         (breakpoint_set_commands): Update.
1894         * breakpoint.c (check_no_tracepoint_commands)
1895         (validate_commands_for_breakpoint): Update.
1896         (breakpoint_set_commands): Change commands to be a
1897         counted_command_line.
1898         (commands_command_1, update_dprintf_command_list)
1899         (create_tracepoint_from_upload): Update.
1900
1901 2018-05-04  Tom Tromey  <tom@tromey.com>
1902
1903         * cli/cli-decode.h (cmd_list_element): New constructor.
1904         (~cmd_list_element): New destructor.
1905         (struct cmd_list_element): Add initializers.
1906         * cli/cli-decode.c (do_add_cmd): Use "new".
1907         (delete_cmd): Use "delete".
1908
1909 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1910             Pedro Alves <palves@redhat.com>
1911
1912         PR breakpoints/19806 and support for PR external/20207.
1913         * NEWS: Mention Aarch64 watchpoint improvements.
1914         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1915         watchpoints and PR external/20207 watchpoints.
1916         * nat/aarch64-linux-hw-point.c
1917         (kernel_supports_any_contiguous_range): New.
1918         (aarch64_watchpoint_offset): New.
1919         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1920         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1921         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1922         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1923         next_addr_orig_p.  Support PR external/20207 watchpoints.
1924         (aarch64_downgrade_regs): New.
1925         (aarch64_dr_state_insert_one_point): New parameters offset and
1926         addr_orig.
1927         (aarch64_dr_state_remove_one_point): Likewise.
1928         (aarch64_handle_breakpoint): Update caller.
1929         (aarch64_handle_aligned_watchpoint): Likewise.
1930         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1931         aligned_offset.
1932         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1933         aarch64_downgrade_regs.
1934         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1935         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1936         (DR_CONTROL_MASK): ... this.
1937         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1938         (unsigned int aarch64_watchpoint_offset): New prototype.
1939         (aarch64_linux_set_debug_regs): Remove const from state.
1940         * utils.c (align_up, align_down): Move to ...
1941         * common/common-utils.c (align_up, align_down): ... here.
1942         * utils.h (align_up, align_down): Move to ...
1943         * common/common-utils.h (align_up, align_down): ... here.
1944
1945 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1946
1947         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1948         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1949         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1950         Re-implement to match the ABI as summarized in GCC's
1951         gcc/config/sparc/sparc.c.  All callers updated.
1952         (sparc32_store_arguments): Remove assertion.
1953
1954 2018-05-04  Tom Tromey  <tom@tromey.com>
1955
1956         * printcmd.c: Don't include tui.h.
1957         (decode_format): Use skip_spaces.
1958
1959 2018-05-04  Tom Tromey  <tom@tromey.com>
1960
1961         PR gdb/22619:
1962         * printcmd.c (last_count): New global.
1963         (x_command): Use saved count when repeating.
1964
1965 2018-05-04  Tom Tromey  <tom@tromey.com>
1966
1967         * nto-procfs.c (do_closedir_cleanup): Remove.
1968         (procfs_pidlist): Use gdb_dir_up.
1969         * procfs.c (do_closedir_cleanup): Remove.
1970         (proc_update_threads): Use gdb_dir_up.
1971         * common/filestuff.h (struct gdb_dir_deleter): New.
1972         (gdb_dir_up): New typedef.
1973
1974 2018-05-04  Tom Tromey  <tom@tromey.com>
1975
1976         * ada-lang.c (print_mention_exception): Use std::string.
1977
1978 2018-05-04  Tom Tromey  <tom@tromey.com>
1979
1980         * ada-lang.c (create_excep_cond_exprs): Update.
1981         (ada_exception_catchpoint_cond_string): Use std::string.
1982
1983 2018-05-04  Tom Tromey  <tom@tromey.com>
1984
1985         * ada-lang.c (xget_renaming_scope): Return std::string.
1986         (old_renaming_is_invisible): Update.
1987
1988 2018-05-04  Tom Tromey  <tom@tromey.com>
1989
1990         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1991         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1992
1993 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1994
1995         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1996
1997 2018-05-04  Tom Tromey  <tom@tromey.com>
1998
1999         * remote.c (remote_query_supported_append): Change type.
2000         (remote_check_symbols): Update.
2001
2002 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
2003
2004         PR gdb/11420
2005         * configure.ac: Prepend libpython.
2006         * python/python-config.py: Likewise.
2007         * configure: Regenerate.
2008
2009 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
2010
2011         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
2012
2013 2018-05-03  Pedro Alves  <palves@redhat.com>
2014
2015         * s390-linux-nat.c
2016         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
2017         override.  Write 'true' instead of '1'.
2018         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
2019         declaration.
2020
2021 2018-05-02  Pedro Alves  <palves@redhat.com>
2022
2023         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
2024         add_inf_child_target.
2025         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
2026         add_inf_child_target.
2027         * aix-thread.c (aix_thread_target_info): New.
2028         (aix_thread_target) <shortname, longname, doc>: Delete.
2029         <info>: New.
2030         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
2031         add_inf_child_target.
2032         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
2033         add_inf_child_target.
2034         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
2035         add_inf_child_target.
2036         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
2037         add_inf_child_target.
2038         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
2039         add_inf_child_target.
2040         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
2041         add_inf_child_target.
2042         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
2043         add_inf_child_target.
2044         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
2045         add_inf_child_target.
2046         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
2047         add_inf_child_target.
2048         * bfd-target.c (target_bfd_target_info): New.
2049         (target_bfd) <shortname, longname, doc>: Delete.
2050         <info>: New.
2051         * bsd-kvm.c (bsd_kvm_target_info): New.
2052         (bsd_kvm_target) <shortname, longname, doc>: Delete.
2053         <info>: New.
2054         (bsd_kvm_target::open): Rename to ...
2055         (bsd_kvm_target_open): ... this.  Adjust.
2056         * bsd-uthread.c (bsd_uthread_target_info): New.
2057         (bsd_uthread_target) <shortname, longname, doc>: Delete.
2058         <info>: New.
2059         * corefile.c (core_file_command): Adjust.
2060         * corelow.c (core_target_info): New.
2061         (core_target) <shortname, longname, doc>: Delete.
2062         <info>: New.
2063         (core_target::open): Rename to ...
2064         (core_target_open): ... this.  Adjust.
2065         * ctf.c (ctf_target_info): New.
2066         (ctf_target) <shortname, longname, doc>: Delete.
2067         <info>: New.
2068         (ctf_target::open): Rename to ...
2069         (ctf_target_open): ... this.
2070         (_initialize_ctf): Adjust.
2071         * exec.c (exec_target_info): New.
2072         (exec_target) <shortname, longname, doc>: Delete.
2073         <info>: New.
2074         (exec_target::open): Rename to ...
2075         (exec_target_open): ... this.
2076         * gdbcore.h (core_target_open): Declare.
2077         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
2078         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
2079         add_inf_child_target.
2080         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
2081         add_inf_child_target.
2082         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
2083         add_inf_child_target.
2084         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
2085         add_inf_child_target.
2086         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
2087         add_inf_child_target.
2088         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
2089         add_inf_child_target.
2090         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
2091         add_inf_child_target.
2092         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
2093         add_inf_child_target.
2094         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
2095         add_inf_child_target.
2096         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
2097         add_inf_child_target.
2098         * inf-child.c (inf_child_target_info): New.
2099         (inf_child_target::info): New.
2100         (inf_child_open_target): Remove 'target' parameter.  Use
2101         get_native_target instead.
2102         (inf_child_target::open): Delete.
2103         (add_inf_child_target): New.
2104         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
2105         Delete.
2106         <info>: New.
2107         (add_inf_child_target): Declare.
2108         (inf_child_open_target): Declare.
2109         * linux-thread-db.c (thread_db_target_info): New.
2110         (thread_db_target) <shortname, longname, doc>: Delete.
2111         <info>: New.
2112         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
2113         add_inf_child_target.
2114         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
2115         add_inf_child_target.
2116         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
2117         add_inf_child_target.
2118         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
2119         add_inf_child_target.
2120         * make-target-delegates (print_class): Adjust.
2121         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
2122         add_inf_child_target.
2123         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
2124         add_inf_child_target.
2125         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
2126         add_inf_child_target.
2127         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
2128         add_inf_child_target.
2129         * nto-procfs.c (nto_native_target_info): New.
2130         (nto_procfs_target_native) <shortname, longname, doc>:
2131         Delete.
2132         <info>: New.
2133         (nto_procfs_target_info): New.
2134         (nto_procfs_target_procfs) <shortname, longname, doc>:
2135         Delete.
2136         <info>: New.
2137         (init_procfs_targets): Adjust.
2138         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
2139         add_inf_child_target.
2140         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
2141         add_inf_child_target.
2142         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
2143         add_inf_child_target.
2144         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
2145         add_inf_child_target.
2146         * ravenscar-thread.c (ravenscar_target_info): New.
2147         (ravenscar_thread_target) <shortname, longname, doc>:
2148         Delete.
2149         <info>: New.
2150         * record-btrace.c (record_btrace_target_info):
2151         (record_btrace_target) <shortname, longname, doc>: Delete.
2152         <info>: New.
2153         (record_btrace_target::open): Rename to ...
2154         (record_btrace_target_open): ... this.  Adjust.
2155         * record-full.c (record_longname, record_doc): New.
2156         (record_full_base_target) <shortname, longname, doc>: Delete.
2157         <info>: New.
2158         (record_full_target_info): New.
2159         (record_full_target): <shortname>: Delete.
2160         <info>: New.
2161         (record_full_core_open_1, record_full_open_1): Update comments.
2162         (record_full_base_target::open): Rename to ...
2163         (record_full_open): ... this.
2164         (cmd_record_full_restore): Update.
2165         (_initialize_record_full): Update.
2166         * remote-sim.c (remote_sim_target_info): New.
2167         (gdbsim_target) <shortname, longname, doc>: Delete.
2168         <info>: New.
2169         (gdbsim_target::open): Rename to ...
2170         (gdbsim_target_open): ... this.
2171         (_initialize_remote_sim): Adjust.
2172         * remote.c (remote_doc): New.
2173         (remote_target_info): New.
2174         (remote_target) <shortname, longname, doc>: Delete.
2175         <info>: New.
2176         (extended_remote_target_info): New.
2177         (extended_remote_target) <shortname, longname, doc>: Delete.
2178         <info>: New.
2179         (remote_target::open_1): Make static.  Adjust.
2180         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
2181         * s390-linux-nat.c (_initialize_s390_nat): Use
2182         add_inf_child_target.
2183         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
2184         add_inf_child_target.
2185         * sol-thread.c (thread_db_target_info): New.
2186         (sol_thread_target) <shortname, longname, doc>: Delete.
2187         <info>: New.
2188         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
2189         add_inf_child_target.
2190         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
2191         add_inf_child_target.
2192         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
2193         add_inf_child_target.
2194         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
2195         add_inf_child_target.
2196         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
2197         add_inf_child_target.
2198         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
2199         add_inf_child_target.
2200         * spu-linux-nat.c (_initialize_spu_nat): Use
2201         add_inf_child_target.
2202         * spu-multiarch.c (spu_multiarch_target_info): New.
2203         (spu_multiarch_target) <shortname, longname, doc>: Delete.
2204         <info>: New.
2205         * target-delegates.c: Regenerate.
2206         * target.c: Include <unordered_map>.
2207         (target_ops_p): Delete.
2208         (DEF_VEC_P(target_ops_p)): Delete.
2209         (target_factories): New.
2210         (test_target_info): New.
2211         (test_target_ops::info): New.
2212         (open_target): Adjust to use target_factories.
2213         (add_target_with_completer): Rename to ...
2214         (add_target): ... this.  Change prototype.  Register target_info
2215         and open callback in target_factories.  Register target_info in
2216         command context instead of target_ops.
2217         (add_target): Delete old implementation.
2218         (add_deprecated_target_alias): Change prototype.  Adjust.
2219         (the_native_target): New.
2220         (set_native_target, get_native_target): New.
2221         (find_default_run_target): Use the_native_target.
2222         (find_attach_target, find_run_target): Simplify.
2223         (target_ops::open): Delete.
2224         (dummy_target_info): New.
2225         (dummy_target::shortname, dummy_target::longname)
2226         (dummy_target::doc): Delete.
2227         (dummy_target::info): New.
2228         (debug_target::shortname, debug_target::longname)
2229         (debug_target::doc): Delete.
2230         (debug_target::info): New.
2231         * target.h (struct target_info): New.
2232         (target_ops::~target_ops): Add comment.
2233         (target_ops::info): New.
2234         (target_ops::shortname, target_ops::longname, target_ops::doc): No
2235         longer virtual.  Implement in terms of target_info.
2236         (set_native_target, get_native_target): Declare.
2237         (target_open_ftype): New.
2238         (add_target, add_target_with_completer)
2239         (add_deprecated_target_alias): Change prototype.
2240         (test_target) <shortname, longname, doc>: Delete.
2241         <info>: New.
2242         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
2243         add_inf_child_target.
2244         * tracefile-tfile.c (tfile_target_info): New.
2245         (tfile_target) <shortname, longname, doc>: Delete.
2246         <info>: New.
2247         (tfile_target::open): Rename to ...
2248         (tfile_target_open): ... this.
2249         (_initialize_tracefile_tfile): Adjust.
2250         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
2251         add_inf_child_target.
2252         * windows-nat.c (_initialize_windows_nat): Use
2253         add_inf_child_target.
2254         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
2255         add_inf_child_target.
2256
2257 2018-05-02  Pedro Alves  <palves@redhat.com>
2258
2259         * linux-nat.h (linux_nat_target) <low_new_thread,
2260         low_delete_thread, low_new_fork, low_forget_process,
2261         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
2262         New virtual methods.
2263         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
2264         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
2265         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
2266         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
2267         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
2268         Delete.
2269         * linux-fork.c (delete_fork): Adjust to call low method.
2270         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
2271         (linux_nat_new_fork, linux_nat_forget_process_hook)
2272         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
2273         (linux_nat_status_is_event):
2274         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
2275         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
2276         to call low method.
2277         (sigtrap_is_event): Rename to ...
2278         (linux_nat_target::low_status_is_event): ... this.
2279         (linux_nat_set_status_is_event): Delete.
2280         (save_stop_reason, linux_nat_wait_1)
2281         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
2282         low methods.
2283         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
2284         (linux_nat_set_new_fork, linux_nat_set_forget_process)
2285         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
2286         (linux_nat_set_prepare_to_resume): Delete.
2287         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
2288         low virtual methods.
2289         * amd64-linux-nat.c: Likewise.
2290         * arm-linux-nat.c: Likewise.
2291         * i386-linux-nat.c: Likewise.
2292         * ia64-linux-nat.c: Likewise.
2293         * mips-linux-nat.c: Likewise.
2294         * ppc-linux-nat.c: Likewise.
2295         * s390-linux-nat.c: Likewise.
2296         * sparc64-linux-nat.c: Likewise.
2297         * x86-linux-nat.c: Likewise.
2298         * x86-linux-nat.h: Include "nat/x86-linux.h".
2299         (x86_linux_nat_target) <low_new_fork, low_forget_process,
2300         low_prepare_to_resume, low_new_thread, low_delete_thread>:
2301         Override methods.
2302
2303 2018-05-02  Pedro Alves  <palves@redhat.com>
2304
2305         * target.h (target_ops)
2306         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
2307         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
2308         stopped_by_watchpoint, have_continuable_watchpoint,
2309         stopped_data_address, watchpoint_addr_within_range,
2310         can_accel_watchpoint_condition, can_run, thread_alive,
2311         has_all_memory, has_memory, has_stack, has_registers,
2312         has_execution, can_async_p, is_async_p, supports_non_stop,
2313         always_non_stop_p, can_execute_reverse, supports_multi_process,
2314         supports_enable_disable_tracepoint,
2315         supports_disable_randomization, supports_string_tracing,
2316         supports_evaluation_of_breakpoint_conditions,
2317         can_run_breakpoint_commands, filesystem_is_local,
2318         can_download_tracepoint, get_trace_state_variable_value,
2319         set_trace_notes, get_tib_address, use_agent, can_use_agent,
2320         record_is_replaying, record_will_replay,
2321         augmented_libraries_svr4_read>: Adjust to return bool.
2322         * aarch64-linux-nat.c: All implementations adjusted.
2323         * aix-thread.c: All implementations adjusted.
2324         * arm-linux-nat.c: All implementations adjusted.
2325         * breakpoint.c: All implementations adjusted.
2326         * bsd-kvm.c: All implementations adjusted.
2327         * bsd-uthread.c: All implementations adjusted.
2328         * corelow.c: All implementations adjusted.
2329         * ctf.c: All implementations adjusted.
2330         * darwin-nat.c: All implementations adjusted.
2331         * darwin-nat.h: All implementations adjusted.
2332         * exec.c: All implementations adjusted.
2333         * fbsd-nat.c: All implementations adjusted.
2334         * fbsd-nat.h: All implementations adjusted.
2335         * gnu-nat.c: All implementations adjusted.
2336         * gnu-nat.h: All implementations adjusted.
2337         * go32-nat.c: All implementations adjusted.
2338         * ia64-linux-nat.c: All implementations adjusted.
2339         * inf-child.c: All implementations adjusted.
2340         * inf-child.h: All implementations adjusted.
2341         * inf-ptrace.c: All implementations adjusted.
2342         * inf-ptrace.h: All implementations adjusted.
2343         * linux-nat.c: All implementations adjusted.
2344         * linux-nat.h: All implementations adjusted.
2345         * mips-linux-nat.c: All implementations adjusted.
2346         * nto-procfs.c: All implementations adjusted.
2347         * ppc-linux-nat.c: All implementations adjusted.
2348         * procfs.c: All implementations adjusted.
2349         * ravenscar-thread.c: All implementations adjusted.
2350         * record-btrace.c: All implementations adjusted.
2351         * record-full.c: All implementations adjusted.
2352         * remote-sim.c: All implementations adjusted.
2353         * remote.c: All implementations adjusted.
2354         * s390-linux-nat.c: All implementations adjusted.
2355         * sol-thread.c: All implementations adjusted.
2356         * spu-multiarch.c: All implementations adjusted.
2357         * target-delegates.c: All implementations adjusted.
2358         * target.c: All implementations adjusted.
2359         * target.h: All implementations adjusted.
2360         * tracefile-tfile.c: All implementations adjusted.
2361         * tracefile.c: All implementations adjusted.
2362         * tracefile.h: All implementations adjusted.
2363         * windows-nat.c: All implementations adjusted.
2364         * x86-linux-nat.h: All implementations adjusted.
2365         * x86-nat.h: All implementations adjusted.
2366
2367 2018-05-02  Pedro Alves  <palves@redhat.com>
2368
2369         * make-target-delegates (scan_target_h): Don't trim lines here.
2370         Replace sequences of tabs and/or whitespace with a single
2371         whitespace.
2372         (top level, parsing methods): Trim each line before processing it
2373         here.
2374
2375 2018-05-02  Pedro Alves  <palves@redhat.com>
2376             John Baldwin  <jhb@freebsd.org>
2377
2378         * target.h (enum strata) <debug_stratum>: New.
2379         (struct target_ops) <all delegation methods>: Replace by C++
2380         virtual methods, and drop "to_" prefix.  All references updated
2381         throughout.
2382         <to_shortname, to_longname, to_doc, to_data,
2383         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
2384         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
2385         virtual methods.  All references updated throughout.
2386         <can_attach, supports_terminal_ours, can_create_inferior,
2387         get_thread_control_capabilities, attach_no_wait>: New
2388         virtual methods.
2389         <insert_breakpoint, remove_breakpoint>: Now
2390         TARGET_DEFAULT_NORETURN methods.
2391         <info_proc>: Now returns bool.
2392         <to_magic>: Delete.
2393         (OPS_MAGIC): Delete.
2394         (current_target): Delete.  All references replaced by references
2395         to ...
2396         (target_stack): ... this.  New.
2397         (target_shortname, target_longname): Adjust.
2398         (target_can_run): Now a function declaration.
2399         (default_child_has_all_memory, default_child_has_memory)
2400         (default_child_has_stack, default_child_has_registers)
2401         (default_child_has_execution): Remove target_ops parameter.
2402         (complete_target_initialization): Delete.
2403         (memory_breakpoint_target): New template class.
2404         (test_target_ops): Refactor as a C++ class with virtual methods.
2405         * make-target-delegates (NAME_PART): Tighten.
2406         (POINTER_PART, CP_SYMBOL): New.
2407         (SIMPLE_RETURN_PART): Reimplement.
2408         (VEC_RETURN_PART): Expect less.
2409         (RETURN_PART, VIRTUAL_PART): New.
2410         (METHOD): Adjust to C++ virtual methods.
2411         (scan_target_h): Remove reference to C99.
2412         (dname): Output "target_ops::" prefix.
2413         (write_function_header): Adjust to output a C++ class method.
2414         (write_declaration): New.
2415         (write_delegator): Adjust to output a C++ class method.
2416         (tdname): Output "dummy_target::" prefix.
2417         (write_tdefault, write_debugmethod): Adjust to output a C++ class
2418         method.
2419         (tdefault_names, debug_names): Delete.
2420         (return_types, tdefaults, styles, argtypes_array): New.
2421         (top level): All methods are delegators.
2422         (print_class): New.
2423         (top level): Print dummy_target and debug_target classes.
2424         * target-delegates.c: Regenerate.
2425         * target-debug.h (target_debug_print_enum_info_proc_what)
2426         (target_debug_print_thread_control_capabilities)
2427         (target_debug_print_thread_info_p): New.
2428         * target.c (dummy_target): Delete.
2429         (the_dummy_target, the_debug_target): New.
2430         (target_stack): Now extern.
2431         (set_targetdebug): Push/unpush debug target.
2432         (default_child_has_all_memory, default_child_has_memory)
2433         (default_child_has_stack, default_child_has_registers)
2434         (default_child_has_execution): Remove target_ops parameter.
2435         (complete_target_initialization): Delete.
2436         (add_target_with_completer): No longer call
2437         complete_target_initialization.
2438         (target_supports_terminal_ours): Use regular delegation.
2439         (update_current_target): Delete.
2440         (push_target): No longer check magic number.  Don't call
2441         update_current_target.
2442         (unpush_target): Don't call update_current_target.
2443         (target_is_pushed): No longer check magic number.
2444         (target_require_runnable): Skip for all stratums over
2445         process_stratum.
2446         (target_ops::info_proc): New.
2447         (target_info_proc): Use find_target_at and
2448         find_default_run_target.
2449         (target_supports_disable_randomization): Use regular delegation.
2450         (target_get_osdata): Use find_target_at.
2451         (target_ops::open, target_ops::close, target_ops::can_attach)
2452         (target_ops::attach, target_ops::can_create_inferior)
2453         (target_ops::create_inferior, target_ops::can_run)
2454         (target_can_run): New.
2455         (default_fileio_target): Use regular delegation.
2456         (target_ops::fileio_open, target_ops::fileio_pwrite)
2457         (target_ops::fileio_pread, target_ops::fileio_fstat)
2458         (target_ops::fileio_close, target_ops::fileio_unlink)
2459         (target_ops::fileio_readlink): New.
2460         (target_fileio_open_1, target_fileio_unlink)
2461         (target_fileio_readlink): Always call the target method.  Handle
2462         FILEIO_ENOSYS.
2463         (return_zero, return_zero_has_execution): Delete.
2464         (init_dummy_target): Delete.
2465         (dummy_target::dummy_target, dummy_target::shortname)
2466         (dummy_target::longname, dummy_target::doc)
2467         (debug_target::debug_target, debug_target::shortname)
2468         (debug_target::longname, debug_target::doc): New.
2469         (target_supports_delete_record): Use regular delegation.
2470         (setup_target_debug): Delete.
2471         (maintenance_print_target_stack): Skip debug_stratum.
2472         (initialize_targets): Instantiate the_dummy_target and
2473         the_debug_target.
2474         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
2475         use target_stack.
2476         (target_auxv_search, fprint_target_auxv): Adjust.
2477         (info_auxv_command): Adjust to use target_stack.
2478         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
2479         * exceptions.c (print_flush): Handle a NULL target_stack.
2480         * regcache.c (target_ops_no_register): Refactor as class with
2481         virtual methods.
2482
2483         * exec.c (exec_target): New class.
2484         (exec_ops): Now an exec_target.
2485         (exec_open, exec_close_1, exec_get_section_table)
2486         (exec_xfer_partial, exec_files_info, exec_has_memory)
2487         (exec_make_note_section): Refactor as exec_target methods.
2488         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
2489         Delete.
2490         (exec_target::find_memory_regions): New.
2491         (_initialize_exec): Don't call init_exec_ops.
2492         * gdbcore.h (exec_file_clear): Delete.
2493
2494         * corefile.c (core_target): Delete.
2495         (core_file_command): Adjust.
2496         * corelow.c (core_target): New class.
2497         (the_core_target): New.
2498         (core_close): Remove target_ops parameter.
2499         (core_close_cleanup): Adjust.
2500         (core_target::close): New.
2501         (core_open, core_detach, get_core_registers, core_files_info)
2502         (core_xfer_partial, core_thread_alive, core_read_description)
2503         (core_pid_to_str, core_thread_name, core_has_memory)
2504         (core_has_stack, core_has_registers, core_info_proc): Rework as
2505         core_target methods.
2506         (ignore, core_remove_breakpoint, init_core_ops): Delete.
2507         (_initialize_corelow): Initialize the_core_target.
2508         * gdbcore.h (core_target): Delete.
2509         (the_core_target): New.
2510
2511         * ctf.c: (ctf_target): New class.
2512         (ctf_ops): Now a ctf_target.
2513         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
2514         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
2515         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
2516         methods.
2517         (init_ctf_ops): Delete.
2518         (_initialize_ctf): Don't call it.
2519         * tracefile-tfile.c (tfile_target): New class.
2520         (tfile_ops): Now a tfile_target.
2521         (tfile_open, tfile_close, tfile_files_info)
2522         (tfile_get_tracepoint_status, tfile_trace_find)
2523         (tfile_fetch_registers, tfile_xfer_partial)
2524         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
2525         Refactor as tfile_target methods.
2526         (tfile_xfer_partial_features): Remove target_ops parameter.
2527         (init_tfile_ops): Delete.
2528         (_initialize_tracefile_tfile): Don't call it.
2529         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2530         (tracefile_has_stack, tracefile_has_registers)
2531         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2532         tracefile_target methods.
2533         (init_tracefile_ops): Delete.
2534         (tracefile_target::tracefile_target): New.
2535         * tracefile.h: Include "target.h".
2536         (tracefile_target): New class.
2537         (init_tracefile_ops): Delete.
2538
2539         * spu-multiarch.c (spu_multiarch_target): New class.
2540         (spu_ops): Now a spu_multiarch_target.
2541         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2542         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2543         (spu_search_memory, spu_mourn_inferior): Refactor as
2544         spu_multiarch_target methods.
2545         (init_spu_ops): Delete.
2546         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2547         complete_target_initialization.
2548
2549         * ravenscar-thread.c (ravenscar_thread_target): New class.
2550         (ravenscar_ops): Now a ravenscar_thread_target.
2551         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2552         (ravenscar_thread_alive, ravenscar_pid_to_str)
2553         (ravenscar_fetch_registers, ravenscar_store_registers)
2554         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2555         (ravenscar_stopped_by_hw_breakpoint)
2556         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2557         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2558         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2559         methods.
2560         (init_ravenscar_thread_ops): Delete.
2561         (_initialize_ravenscar): Remove references to
2562         init_ravenscar_thread_ops and complete_target_initialization.
2563
2564         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2565         (bsd_uthread_target): New class.
2566         (bsd_uthread_ops): Now a bsd_uthread_target.
2567         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2568         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2569         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2570         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2571         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2572         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2573         (bsd_uthread_target): Delete function.
2574         (_initialize_bsd_uthread): Remove reference to
2575         complete_target_initialization.
2576
2577         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2578         (target_bfd): ... this new class.
2579         (target_bfd_xfer_partial, target_bfd_get_section_table)
2580         (target_bfd_close): Refactor as target_bfd methods.
2581         (target_bfd::~target_bfd): New.
2582         (target_bfd_reopen): Adjust.
2583         (target_bfd::close): New.
2584
2585         * record-btrace.c (record_btrace_target): New class.
2586         (record_btrace_ops): Now a record_btrace_target.
2587         (record_btrace_open, record_btrace_stop_recording)
2588         (record_btrace_disconnect, record_btrace_close)
2589         (record_btrace_async, record_btrace_info)
2590         (record_btrace_insn_history, record_btrace_insn_history_range)
2591         (record_btrace_insn_history_from, record_btrace_call_history)
2592         (record_btrace_call_history_range)
2593         (record_btrace_call_history_from, record_btrace_record_method)
2594         (record_btrace_is_replaying, record_btrace_will_replay)
2595         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2596         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2597         (record_btrace_store_registers, record_btrace_prepare_to_store)
2598         (record_btrace_to_get_unwinder)
2599         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2600         (record_btrace_commit_resume, record_btrace_wait)
2601         (record_btrace_stop, record_btrace_can_execute_reverse)
2602         (record_btrace_stopped_by_sw_breakpoint)
2603         (record_btrace_supports_stopped_by_sw_breakpoint)
2604         (record_btrace_stopped_by_hw_breakpoint)
2605         (record_btrace_supports_stopped_by_hw_breakpoint)
2606         (record_btrace_update_thread_list, record_btrace_thread_alive)
2607         (record_btrace_goto_begin, record_btrace_goto_end)
2608         (record_btrace_goto, record_btrace_stop_replaying_all)
2609         (record_btrace_execution_direction)
2610         (record_btrace_prepare_to_generate_core)
2611         (record_btrace_done_generating_core): Refactor as
2612         record_btrace_target methods.
2613         (init_record_btrace_ops): Delete.
2614         (_initialize_record_btrace): Remove reference to
2615         init_record_btrace_ops.
2616         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2617         the execution_direction global.
2618         (record_full_base_target, record_full_target)
2619         (record_full_core_target): New classes.
2620         (record_full_ops): Now a record_full_target.
2621         (record_full_core_ops): Now a record_full_core_target.
2622         (record_full_target::detach, record_full_target::disconnect)
2623         (record_full_core_target::disconnect)
2624         (record_full_target::mourn_inferior, record_full_target::kill):
2625         New.
2626         (record_full_open, record_full_close, record_full_async): Refactor
2627         as methods of the record_full_base_target class.
2628         (record_full_resume, record_full_commit_resume): Refactor
2629         as methods of the record_full_target class.
2630         (record_full_wait, record_full_stopped_by_watchpoint)
2631         (record_full_stopped_data_address)
2632         (record_full_stopped_by_sw_breakpoint)
2633         (record_full_supports_stopped_by_sw_breakpoint)
2634         (record_full_stopped_by_hw_breakpoint)
2635         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2636         methods of the record_full_base_target class.
2637         (record_full_store_registers, record_full_xfer_partial)
2638         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2639         Refactor as methods of the record_full_target class.
2640         (record_full_can_execute_reverse, record_full_get_bookmark)
2641         (record_full_goto_bookmark, record_full_execution_direction)
2642         (record_full_record_method, record_full_info, record_full_delete)
2643         (record_full_is_replaying, record_full_will_replay)
2644         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2645         (record_full_stop_replaying): Refactor as methods of the
2646         record_full_base_target class.
2647         (record_full_core_resume, record_full_core_kill)
2648         (record_full_core_fetch_registers)
2649         (record_full_core_prepare_to_store)
2650         (record_full_core_store_registers, record_full_core_xfer_partial)
2651         (record_full_core_insert_breakpoint)
2652         (record_full_core_remove_breakpoint)
2653         (record_full_core_has_execution): Refactor
2654         as methods of the record_full_core_target class.
2655         (record_full_base_target::supports_delete_record): New.
2656         (init_record_full_ops): Delete.
2657         (init_record_full_core_ops): Delete.
2658         (record_full_save): Refactor as method of the
2659         record_full_base_target class.
2660         (_initialize_record_full): Remove references to
2661         init_record_full_ops and init_record_full_core_ops.
2662
2663         * remote.c (remote_target, extended_remote_target): New classes.
2664         (remote_ops): Now a remote_target.
2665         (extended_remote_ops): Now an extended_remote_target.
2666         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2667         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2668         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2669         (remote_pass_signals, remote_set_syscall_catchpoint)
2670         (remote_program_signals, )
2671         (remote_thread_always_alive): Remove target_ops parameter.
2672         (remote_thread_alive, remote_thread_name)
2673         (remote_update_thread_list, remote_threads_extra_info)
2674         (remote_static_tracepoint_marker_at)
2675         (remote_static_tracepoint_markers_by_strid)
2676         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2677         (remote_open): Refactor as methods of remote_target.
2678         (extended_remote_open, extended_remote_detach)
2679         (extended_remote_attach, extended_remote_post_attach):
2680         (extended_remote_supports_disable_randomization)
2681         (extended_remote_create_inferior): : Refactor as method of
2682         extended_remote_target.
2683         (remote_set_permissions, remote_open_1, remote_detach)
2684         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2685         (remote_resume, remote_commit_resume, remote_stop)
2686         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2687         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2688         (remote_prepare_to_store, remote_store_registers)
2689         (remote_flash_erase, remote_flash_done, remote_files_info)
2690         (remote_kill, remote_mourn, remote_insert_breakpoint)
2691         (remote_remove_breakpoint, remote_insert_watchpoint)
2692         (remote_watchpoint_addr_within_range)
2693         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2694         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2695         (remote_supports_stopped_by_sw_breakpoint)
2696         (remote_stopped_by_hw_breakpoint)
2697         (remote_supports_stopped_by_hw_breakpoint)
2698         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2699         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2700         (remote_verify_memory): Refactor as methods of remote_target.
2701         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2702         parameter.
2703         (remote_xfer_partial, remote_get_memory_xfer_limit)
2704         (remote_search_memory, remote_rcmd, remote_memory_map)
2705         (remote_pid_to_str, remote_get_thread_local_address)
2706         (remote_get_tib_address, remote_read_description): Refactor as
2707         methods of remote_target.
2708         (remote_target::fileio_open, remote_target::fileio_pwrite)
2709         (remote_target::fileio_pread, remote_target::fileio_close): New.
2710         (remote_hostio_readlink, remote_hostio_fstat)
2711         (remote_filesystem_is_local, remote_can_execute_reverse)
2712         (remote_supports_non_stop, remote_supports_disable_randomization)
2713         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2714         (remote_supports_enable_disable_tracepoint)
2715         (remote_supports_string_tracing)
2716         (remote_can_run_breakpoint_commands, remote_trace_init)
2717         (remote_download_tracepoint, remote_can_download_tracepoint)
2718         (remote_download_trace_state_variable, remote_enable_tracepoint)
2719         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2720         (remote_trace_start, remote_get_trace_status)
2721         (remote_get_tracepoint_status, remote_trace_stop)
2722         (remote_trace_find, remote_get_trace_state_variable_value)
2723         (remote_save_trace_data, remote_get_raw_trace_data)
2724         (remote_set_disconnected_tracing, remote_core_of_thread)
2725         (remote_set_circular_trace_buffer, remote_traceframe_info)
2726         (remote_get_min_fast_tracepoint_insn_len)
2727         (remote_set_trace_buffer_size, remote_set_trace_notes)
2728         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2729         (remote_disable_btrace, remote_teardown_btrace)
2730         (remote_read_btrace, remote_btrace_conf)
2731         (remote_augmented_libraries_svr4_read, remote_load)
2732         (remote_pid_to_exec_file, remote_can_do_single_step)
2733         (remote_execution_direction, remote_thread_handle_to_thread_info):
2734         Refactor as methods of remote_target.
2735         (init_remote_ops, init_extended_remote_ops): Delete.
2736         (remote_can_async_p, remote_is_async_p, remote_async)
2737         (remote_thread_events, remote_upload_tracepoints)
2738         (remote_upload_trace_state_variables): Refactor as methods of
2739         remote_target.
2740         (_initialize_remote): Remove references to init_remote_ops and
2741         init_extended_remote_ops.
2742
2743         * remote-sim.c (gdbsim_target): New class.
2744         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2745         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2746         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2747         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2748         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2749         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2750         Refactor as methods of gdbsim_target.
2751         (gdbsim_ops): Now a gdbsim_target.
2752         (init_gdbsim_ops): Delete.
2753         (gdbsim_cntrl_c): Adjust.
2754         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2755
2756         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2757         (the_amd64_linux_nat_target): New.
2758         (amd64_linux_fetch_inferior_registers)
2759         (amd64_linux_store_inferior_registers): Refactor as methods of
2760         amd64_linux_nat_target.
2761         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2762         * i386-linux-nat.c: Don't include "linux-nat.h".
2763         (i386_linux_nat_target): New class.
2764         (the_i386_linux_nat_target): New.
2765         (i386_linux_fetch_inferior_registers)
2766         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2767         as methods of i386_linux_nat_target.
2768         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2769         * inf-child.c (inf_child_ops): Delete.
2770         (inf_child_fetch_inferior_registers)
2771         (inf_child_store_inferior_registers): Delete.
2772         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2773         methods of inf_child_target.
2774         (inf_child_target::supports_terminal_ours)
2775         (inf_child_target::terminal_init)
2776         (inf_child_target::terminal_inferior)
2777         (inf_child_target::terminal_ours_for_output)
2778         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2779         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2780         New.
2781         (inf_child_open, inf_child_disconnect, inf_child_close)
2782         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2783         (inf_child_post_startup_inferior, inf_child_can_run)
2784         (inf_child_pid_to_exec_file): Refactor as methods of
2785         inf_child_target.
2786         (inf_child_follow_fork): Delete.
2787         (inf_child_target::can_create_inferior)
2788         (inf_child_target::can_attach): New.
2789         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2790         (inf_child_target::has_stack, inf_child_target::has_registers)
2791         (inf_child_target::has_execution): New.
2792         (inf_child_fileio_open, inf_child_fileio_pwrite)
2793         (inf_child_fileio_pread, inf_child_fileio_fstat)
2794         (inf_child_fileio_close, inf_child_fileio_unlink)
2795         (inf_child_fileio_readlink, inf_child_use_agent)
2796         (inf_child_can_use_agent): Refactor as methods of
2797         inf_child_target.
2798         (return_zero, inf_child_target): Delete.
2799         (inf_child_target::inf_child_target): New.
2800         * inf-child.h: Include "target.h".
2801         (inf_child_target): Delete function prototype.
2802         (inf_child_target): New class.
2803         (inf_child_open_target, inf_child_mourn_inferior)
2804         (inf_child_maybe_unpush_target): Delete.
2805         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2806         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2807         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2808         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2809         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2810         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2811         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2812         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2813         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2814         methods of inf_ptrace_target.
2815         (inf_ptrace_target): Delete function.
2816         * inf-ptrace.h: Include "inf-child.h".
2817         (inf_ptrace_target): Delete function declaration.
2818         (inf_ptrace_target): New class.
2819         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2820         * linux-nat.c (linux_target): New.
2821         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2822         (linux_nat_target::~linux_nat_target): New.
2823         (linux_child_post_attach, linux_child_post_startup_inferior)
2824         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2825         (linux_child_remove_fork_catchpoint)
2826         (linux_child_insert_vfork_catchpoint)
2827         (linux_child_remove_vfork_catchpoint)
2828         (linux_child_insert_exec_catchpoint)
2829         (linux_child_remove_exec_catchpoint)
2830         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2831         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2832         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2833         (linux_nat_stopped_data_address)
2834         (linux_nat_stopped_by_sw_breakpoint)
2835         (linux_nat_supports_stopped_by_sw_breakpoint)
2836         (linux_nat_stopped_by_hw_breakpoint)
2837         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2838         (linux_nat_kill, linux_nat_mourn_inferior)
2839         (linux_nat_xfer_partial, linux_nat_thread_alive)
2840         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2841         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2842         (linux_child_static_tracepoint_markers_by_strid)
2843         (linux_nat_is_async_p, linux_nat_can_async_p)
2844         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2845         (linux_nat_supports_multi_process)
2846         (linux_nat_supports_disable_randomization, linux_nat_async)
2847         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2848         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2849         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2850         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2851         methods of linux_nat_target.
2852         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2853         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2854         parameter.
2855         (check_stopped_by_watchpoint): Adjust.
2856         (linux_xfer_partial): Delete.
2857         (linux_target_install_ops, linux_target, linux_nat_add_target):
2858         Delete.
2859         (linux_nat_target::linux_nat_target): New.
2860         * linux-nat.h: Include "inf-ptrace.h".
2861         (linux_nat_target): New.
2862         (linux_target, linux_target_install_ops, linux_nat_add_target):
2863         Delete function declarations.
2864         (linux_target): Declare global.
2865         * linux-thread-db.c (thread_db_target): New.
2866         (thread_db_target::thread_db_target): New.
2867         (thread_db_ops): Delete.
2868         (the_thread_db_target): New.
2869         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2870         (thread_db_update_thread_list, thread_db_pid_to_str)
2871         (thread_db_extra_thread_info)
2872         (thread_db_thread_handle_to_thread_info)
2873         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2874         (thread_db_resume): Refactor as methods of thread_db_target.
2875         (init_thread_db_ops): Delete.
2876         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2877         * x86-linux-nat.c: Don't include "linux-nat.h".
2878         (super_post_startup_inferior): Delete.
2879         (x86_linux_nat_target::~x86_linux_nat_target): New.
2880         (x86_linux_child_post_startup_inferior)
2881         (x86_linux_read_description, x86_linux_enable_btrace)
2882         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2883         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2884         methods of x86_linux_nat_target.
2885         (x86_linux_create_target): Delete.  Bits folded ...
2886         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2887         pointer.
2888         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2889         (x86_linux_nat_target): New class.
2890         (x86_linux_create_target): Delete.
2891         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2892         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2893         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2894         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2895         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2896         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2897         make extern.
2898         (x86_use_watchpoints): Delete.
2899         * x86-nat.h: Include "breakpoint.h" and "target.h".
2900         (x86_use_watchpoints): Delete.
2901         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2902         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2903         (x86_insert_watchpoint, x86_remove_watchpoint)
2904         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2905         (x86_stopped_by_hw_breakpoint): New declarations.
2906         (x86_nat_target): New template class.
2907
2908         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2909         (the_ppc_linux_nat_target): New.
2910         (ppc_linux_fetch_inferior_registers)
2911         (ppc_linux_can_use_hw_breakpoint)
2912         (ppc_linux_region_ok_for_hw_watchpoint)
2913         (ppc_linux_ranged_break_num_registers)
2914         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2915         (ppc_linux_insert_mask_watchpoint)
2916         (ppc_linux_remove_mask_watchpoint)
2917         (ppc_linux_can_accel_watchpoint_condition)
2918         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2919         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2920         (ppc_linux_watchpoint_addr_within_range)
2921         (ppc_linux_masked_watch_num_registers)
2922         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2923         (ppc_linux_read_description): Refactor as methods of
2924         ppc_linux_nat_target.
2925         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2926
2927         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2928         (procfs_target): New class.
2929         (the_procfs_target): New.
2930         (procfs_target): Delete function.
2931         (procfs_auxv_parse, procfs_attach, procfs_detach)
2932         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2933         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2934         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2935         (procfs_create_inferior, procfs_update_thread_list)
2936         (procfs_thread_alive, procfs_pid_to_str)
2937         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2938         (procfs_stopped_data_address, procfs_insert_watchpoint)
2939         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2940         (proc_find_memory_regions, procfs_info_proc)
2941         (procfs_make_note_section): Refactor as methods of procfs_target.
2942         (_initialize_procfs): Adjust.
2943         * sol-thread.c (sol_thread_target): New class.
2944         (sol_thread_ops): Now a sol_thread_target.
2945         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2946         (sol_thread_fetch_registers, sol_thread_store_registers)
2947         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2948         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2949         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2950         (init_sol_thread_ops): Delete.
2951         (_initialize_sol_thread): Adjust.  Remove references to
2952         init_sol_thread_ops and complete_target_initialization.
2953
2954         * windows-nat.c (windows_nat_target): New class.
2955         (windows_fetch_inferior_registers)
2956         (windows_store_inferior_registers, windows_resume, windows_wait)
2957         (windows_attach, windows_detach, windows_pid_to_exec_file)
2958         (windows_files_info, windows_create_inferior)
2959         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2960         (windows_close, windows_pid_to_str, windows_xfer_partial)
2961         (windows_get_tib_address, windows_get_ada_task_ptid)
2962         (windows_thread_name, windows_thread_alive): Refactor as
2963         windows_nat_target methods.
2964         (do_initial_windows_stuff): Adjust.
2965         (windows_target): Delete function.
2966         (_initialize_windows_nat): Adjust.
2967
2968         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2969         (darwin_mourn_inferior, darwin_kill_inferior)
2970         (darwin_create_inferior, darwin_attach, darwin_detach)
2971         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2972         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2973         (darwin_supports_multi_process): Refactor as darwin_nat_target
2974         methods.
2975         (darwin_resume_to, darwin_files_info): Delete.
2976         (_initialize_darwin_inferior): Rename to ...
2977         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2978         * darwin-nat.h: Include "inf-child.h".
2979         (darwin_nat_target): New class.
2980         (darwin_complete_target): Delete.
2981         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2982         (darwin_target): New.
2983         (i386_darwin_fetch_inferior_registers)
2984         (i386_darwin_store_inferior_registers): Refactor as methods of
2985         darwin_nat_target.
2986         (darwin_complete_target): Delete, with ...
2987         (_initialize_i386_darwin_nat): ... bits factored out here.
2988
2989         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2990         (the_alpha_linux_nat_target): New.
2991         (alpha_linux_register_u_offset): Refactor as
2992         alpha_linux_nat_target method.
2993         (_initialize_alpha_linux_nat): Adjust.
2994         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2995         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2996         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2997         methods of linux_nat_trad_target.
2998         (linux_trad_target): Delete.
2999         * linux-nat-trad.h (linux_trad_target): Delete function.
3000         (linux_nat_trad_target): New class.
3001         * mips-linux-nat.c (mips_linux_nat_target): New class.
3002         (super_fetch_registers, super_store_registers, super_close):
3003         Delete.
3004         (the_mips_linux_nat_target): New.
3005         (mips64_linux_regsets_fetch_registers)
3006         (mips64_linux_regsets_store_registers)
3007         (mips64_linux_fetch_registers, mips64_linux_store_registers)
3008         (mips_linux_register_u_offset, mips_linux_read_description)
3009         (mips_linux_can_use_hw_breakpoint)
3010         (mips_linux_stopped_by_watchpoint)
3011         (mips_linux_stopped_data_address)
3012         (mips_linux_region_ok_for_hw_watchpoint)
3013         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
3014         (mips_linux_close): Refactor as methods of mips_linux_nat.
3015         (_initialize_mips_linux_nat): Adjust to C++ification.
3016
3017         * aix-thread.c (aix_thread_target): New class.
3018         (aix_thread_ops): Now an aix_thread_target.
3019         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
3020         (aix_thread_fetch_registers, aix_thread_store_registers)
3021         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
3022         (aix_thread_thread_alive, aix_thread_pid_to_str)
3023         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
3024         Refactor as methods of aix_thread_target.
3025         (init_aix_thread_ops): Delete.
3026         (_initialize_aix_thread): Remove references to init_aix_thread_ops
3027         and complete_target_initialization.
3028         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
3029         (rs6000_nat_target): New class.
3030         (the_rs6000_nat_target): New.
3031         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
3032         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
3033         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
3034         (super_create_inferior): Delete.
3035         (_initialize_rs6000_nat): Adjust to C++ification.
3036
3037         * arm-linux-nat.c (arm_linux_nat_target): New class.
3038         (the_arm_linux_nat_target): New.
3039         (arm_linux_fetch_inferior_registers)
3040         (arm_linux_store_inferior_registers, arm_linux_read_description)
3041         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
3042         (arm_linux_remove_hw_breakpoint)
3043         (arm_linux_region_ok_for_hw_watchpoint)
3044         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
3045         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
3046         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
3047         arm_linux_nat_target.
3048         (_initialize_arm_linux_nat): Adjust to C++ification.
3049
3050         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
3051         (the_aarch64_linux_nat_target): New.
3052         (aarch64_linux_fetch_inferior_registers)
3053         (aarch64_linux_store_inferior_registers)
3054         (aarch64_linux_child_post_startup_inferior)
3055         (aarch64_linux_read_description)
3056         (aarch64_linux_can_use_hw_breakpoint)
3057         (aarch64_linux_insert_hw_breakpoint)
3058         (aarch64_linux_remove_hw_breakpoint)
3059         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
3060         (aarch64_linux_region_ok_for_hw_watchpoint)
3061         (aarch64_linux_stopped_data_address)
3062         (aarch64_linux_stopped_by_watchpoint)
3063         (aarch64_linux_watchpoint_addr_within_range)
3064         (aarch64_linux_can_do_single_step): Refactor as methods of
3065         aarch64_linux_nat_target.
3066         (super_post_startup_inferior): Delete.
3067         (_initialize_aarch64_linux_nat): Adjust to C++ification.
3068
3069         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
3070         (the_hppa_linux_nat_target): New.
3071         (hppa_linux_fetch_inferior_registers)
3072         (hppa_linux_store_inferior_registers): Refactor as methods of
3073         hppa_linux_nat_target.
3074         (_initialize_hppa_linux_nat): Adjust to C++ification.
3075
3076         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
3077         (the_ia64_linux_nat_target): New.
3078         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
3079         (ia64_linux_stopped_data_address)
3080         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
3081         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
3082         ia64_linux_nat_target methods.
3083         (super_xfer_partial): Delete.
3084         (_initialize_ia64_linux_nat): Adjust to C++ification.
3085
3086         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
3087         (the_m32r_linux_nat_target): New.
3088         (m32r_linux_fetch_inferior_registers)
3089         (m32r_linux_store_inferior_registers): Refactor as
3090         m32r_linux_nat_target methods.
3091         (_initialize_m32r_linux_nat): Adjust to C++ification.
3092
3093         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
3094         (the_m68k_linux_nat_target): New.
3095         (m68k_linux_fetch_inferior_registers)
3096         (m68k_linux_store_inferior_registers): Refactor as
3097         m68k_linux_nat_target methods.
3098         (_initialize_m68k_linux_nat): Adjust to C++ification.
3099
3100         * s390-linux-nat.c (s390_linux_nat_target): New class.
3101         (the_s390_linux_nat_target): New.
3102         (s390_linux_fetch_inferior_registers)
3103         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
3104         (s390_insert_watchpoint, s390_remove_watchpoint)
3105         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
3106         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
3107         (s390_auxv_parse, s390_read_description): Refactor as methods of
3108         s390_linux_nat_target.
3109         (_initialize_s390_nat): Adjust to C++ification.
3110
3111         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
3112         (the_sparc_linux_nat_target): New.
3113         (_initialize_sparc_linux_nat): Adjust to C++ification.
3114         * sparc-nat.c (sparc_fetch_inferior_registers)
3115         (sparc_store_inferior_registers): Remove target_ops parameter.
3116         * sparc-nat.h (sparc_fetch_inferior_registers)
3117         (sparc_store_inferior_registers): Remove target_ops parameter.
3118         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
3119         (the_sparc64_linux_nat_target): New.
3120         (_initialize_sparc64_linux_nat): Adjust to C++ification.
3121
3122         * spu-linux-nat.c (spu_linux_nat_target): New class.
3123         (the_spu_linux_nat_target): New.
3124         (spu_child_post_startup_inferior, spu_child_post_attach)
3125         (spu_child_wait, spu_fetch_inferior_registers)
3126         (spu_store_inferior_registers, spu_xfer_partial)
3127         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
3128         methods.
3129         (_initialize_spu_nat): Adjust to C++ification.
3130
3131         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
3132         (the_tilegx_linux_nat_target): New.
3133         (fetch_inferior_registers, store_inferior_registers):
3134         Refactor as methods.
3135         (_initialize_tile_linux_nat): Adjust to C++ification.
3136
3137         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
3138         (the_xtensa_linux_nat_target): New.
3139         (xtensa_linux_fetch_inferior_registers)
3140         (xtensa_linux_store_inferior_registers): Refactor as
3141         xtensa_linux_nat_target methods.
3142         (_initialize_xtensa_linux_nat): Adjust to C++ification.
3143
3144         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
3145         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
3146         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
3147         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
3148         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
3149         (fbsd_stopped_by_sw_breakpoint)
3150         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
3151         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
3152         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
3153         (fbsd_post_startup_inferior, fbsd_post_attach)
3154         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
3155         (fbsd_set_syscall_catchpoint)
3156         (super_xfer_partial, super_resume, super_wait)
3157         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
3158         (fbsd_handle_debug_trap): Remove target_ops parameter.
3159         (fbsd_nat_add_target): Delete.
3160         * fbsd-nat.h: Include "inf-ptrace.h".
3161         (fbsd_nat_add_target): Delete.
3162         (USE_SIGTRAP_SIGINFO): Define.
3163         (fbsd_nat_target): New class.
3164
3165         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
3166         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
3167         (amd64bsd_target): Delete.
3168         * amd64-bsd-nat.h: New file.
3169         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
3170         "x86-bsd-nat.h".
3171         (amd64_fbsd_nat_target): New class.
3172         (the_amd64_fbsd_nat_target): New.
3173         (amd64fbsd_read_description): Refactor as method of
3174         amd64_fbsd_nat_target.
3175         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
3176         (_initialize_amd64fbsd_nat): Adjust to C++ification.
3177         * amd64-nat.h (amd64bsd_target): Delete function declaration.
3178         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
3179         (i386bsd_store_inferior_registers): Remove target_ops parameter.
3180         (i386bsd_target): Delete.
3181         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
3182         (i386bsd_fetch_inferior_registers)
3183         (i386bsd_store_inferior_registers): Declare.
3184         (i386_bsd_nat_target): New class.
3185         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
3186         (the_i386_fbsd_nat_target): New.
3187         (i386fbsd_resume, i386fbsd_read_description): Refactor as
3188         i386_fbsd_nat_target methods.
3189         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
3190         (_initialize_i386fbsd_nat): Adjust to C++ification.
3191         * x86-bsd-nat.c (super_mourn_inferior): Delete.
3192         (x86bsd_mourn_inferior, x86bsd_target): Delete.
3193         (_initialize_x86_bsd_nat): Adjust to C++ification.
3194         * x86-bsd-nat.h: Include "x86-nat.h".
3195         (x86bsd_target): Delete declaration.
3196         (x86bsd_nat_target): New class.
3197
3198         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
3199         (the_aarch64_fbsd_nat_target): New.
3200         (aarch64_fbsd_fetch_inferior_registers)
3201         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
3202         aarch64_fbsd_nat_target.
3203         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
3204         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
3205         (the_alpha_bsd_nat_target): New.
3206         (alphabsd_fetch_inferior_registers)
3207         (alphabsd_store_inferior_registers): Refactor as
3208         alpha_bsd_nat_target methods.
3209         (_initialize_alphabsd_nat): Refactor as methods of
3210         alpha_bsd_nat_target.
3211         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
3212         (the_amd64_nbsd_nat_target): New.
3213         (_initialize_amd64nbsd_nat): Adjust to C++ification.
3214         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
3215         (the_amd64_obsd_nat_target): New.
3216         (_initialize_amd64obsd_nat): Adjust to C++ification.
3217         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
3218         (the_arm_fbsd_nat_target): New.
3219         (arm_fbsd_fetch_inferior_registers)
3220         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
3221         (_initialize_arm_fbsd_nat): Refactor as methods of
3222         arm_fbsd_nat_target.
3223         (_initialize_arm_fbsd_nat): Adjust to C++ification.
3224         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
3225         (the_arm_netbsd_nat_target): New.
3226         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
3227         arm_netbsd_nat_target.
3228         (_initialize_arm_netbsd_nat): Adjust to C++ification.
3229         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
3230         (the_hppa_nbsd_nat_target): New.
3231         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
3232         hppa_nbsd_nat_target methods.
3233         (_initialize_hppanbsd_nat): Adjust to C++ification.
3234         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
3235         (the_hppa_obsd_nat_target): New.
3236         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
3237         methods of hppa_obsd_nat_target.
3238         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
3239         add_target.
3240         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
3241         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
3242         add_target.
3243         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
3244         (_initialize_i386obsd_nat): Use add_target.
3245         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
3246         (the_m68k_bsd_nat_target): New.
3247         (m68kbsd_fetch_inferior_registers)
3248         (m68kbsd_store_inferior_registers): Refactor as methods of
3249         m68k_bsd_nat_target.
3250         (_initialize_m68kbsd_nat): Adjust to C++ification.
3251         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
3252         (the_mips_fbsd_nat_target): New.
3253         (mips_fbsd_fetch_inferior_registers)
3254         (mips_fbsd_store_inferior_registers): Refactor as methods of
3255         mips_fbsd_nat_target.
3256         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
3257         add_target.
3258         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
3259         (the_mips_nbsd_nat_target): New.
3260         (mipsnbsd_fetch_inferior_registers)
3261         (mipsnbsd_store_inferior_registers): Refactor as methods of
3262         mips_nbsd_nat_target.
3263         (_initialize_mipsnbsd_nat): Adjust to C++ification.
3264         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
3265         (the_mips64_obsd_nat_target): New.
3266         (mips64obsd_fetch_inferior_registers)
3267         (mips64obsd_store_inferior_registers): Refactor as methods of
3268         mips64_obsd_nat_target.
3269         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
3270         add_target.
3271         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
3272         nbsd_nat_target.
3273         * nbsd-nat.h: Include "inf-ptrace.h".
3274         (nbsd_nat_target): New class.
3275         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
3276         (obsd_wait): Refactor as methods of obsd_nat_target.
3277         (obsd_add_target): Delete.
3278         * obsd-nat.h: Include "inf-ptrace.h".
3279         (obsd_nat_target): New class.
3280         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
3281         (the_ppc_fbsd_nat_target): New.
3282         (ppcfbsd_fetch_inferior_registers)
3283         (ppcfbsd_store_inferior_registers): Refactor as methods of
3284         ppc_fbsd_nat_target.
3285         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
3286         add_target.
3287         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
3288         (the_ppc_nbsd_nat_target): New.
3289         (ppcnbsd_fetch_inferior_registers)
3290         (ppcnbsd_store_inferior_registers): Refactor as methods of
3291         ppc_nbsd_nat_target.
3292         (_initialize_ppcnbsd_nat): Adjust to C++ification.
3293         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
3294         (the_ppc_obsd_nat_target): New.
3295         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
3296         methods of ppc_obsd_nat_target.
3297         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
3298         add_target.
3299         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
3300         (the_sh_nbsd_nat_target): New.
3301         (shnbsd_fetch_inferior_registers)
3302         (shnbsd_store_inferior_registers): Refactor as methods of
3303         sh_nbsd_nat_target.
3304         (_initialize_shnbsd_nat): Adjust to C++ification.
3305         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
3306         (inf_ptrace_xfer_partial): Delete.
3307         (sparc_xfer_partial, sparc_target): Delete.
3308         * sparc-nat.h (sparc_fetch_inferior_registers)
3309         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
3310         (sparc_target): Delete function declaration.
3311         (sparc_target): New template class.
3312         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
3313         (_initialize_sparcnbsd_nat): Adjust to C++ification.
3314         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
3315         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
3316         add_target.
3317         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
3318         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
3319         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
3320         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
3321         add_target.
3322         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
3323         (the_vax_bsd_nat_target): New.
3324         (vaxbsd_fetch_inferior_registers)
3325         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
3326         methods.
3327         (_initialize_vaxbsd_nat): Adjust to C++ification.
3328
3329         * bsd-kvm.c (bsd_kvm_target): New class.
3330         (bsd_kvm_ops): Now a bsd_kvm_target.
3331         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
3332         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
3333         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
3334         bsd_kvm_target.
3335         (bsd_kvm_return_one): Delete.
3336         (bsd_kvm_add_target): Adjust to C++ification.
3337
3338         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
3339         (nto_procfs_target_procfs): New classes.
3340         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
3341         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
3342         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
3343         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
3344         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
3345         (procfs_remove_hw_breakpoint, procfs_resume)
3346         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
3347         (procfs_kill_inferior, procfs_store_registers)
3348         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
3349         as methods of nto_procfs_target.
3350         (nto_procfs_ops): Now an nto_procfs_target_procfs.
3351         (nto_native_ops): Delete.
3352         (procfs_open, procfs_native_open): Delete.
3353         (nto_native_ops): Now an nto_procfs_target_native.
3354         (init_procfs_targets): Adjust to C++ification.
3355         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
3356         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
3357         Refactor as methods of nto_procfs_target.
3358
3359         * go32-nat.c (go32_nat_target): New class.
3360         (the_go32_nat_target): New.
3361         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
3362         (go32_store_registers, go32_xfer_partial, go32_files_info)
3363         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
3364         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
3365         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
3366         (go32_pid_to_str): Refactor as methods of go32_nat_target.
3367         (go32_target): Delete.
3368         (_initialize_go32_nat): Adjust to C++ification.
3369
3370         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
3371         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
3372         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
3373         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
3374         gnu_nat_target.
3375         (gnu_target): Delete.
3376         * gnu-nat.h (gnu_target): Delete.
3377         (gnu_nat_target): New class.
3378         * i386-gnu-nat.c (gnu_base_target): New.
3379         (i386_gnu_nat_target): New class.
3380         (the_i386_gnu_nat_target): New.
3381         (_initialize_i386gnu_nat): Adjust to C++ification.
3382
3383 2018-05-02  Pedro Alves  <palves@redhat.com>
3384
3385         * bfd-target.c (target_bfd_xclose): Rename to ...
3386         (target_bfd_close): ... this.
3387         (target_bfd_reopen): Adjust.
3388         * target.c (target_close): Remove references to to_xclose.
3389         * target.h (target_ops::to_xclose): Delete.
3390         (target_ops::to_close): Update comments.
3391
3392 2018-05-02  Pedro Alves  <palves@redhat.com>
3393
3394         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
3395         "linux-nat.h".
3396         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
3397         * inf-ptrace.c (inf_ptrace_register_u_offset)
3398         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
3399         (inf_ptrace_store_register, inf_ptrace_store_registers)
3400         (inf_ptrace_trad_target): Move to ...
3401         * linux-nat-trad.c: ... this new file.
3402         * linux-nat-trad.h: New file.
3403         * linux-nat.c (linux_target_install_ops): Make extern.
3404         (linux_trad_target): Delete.
3405         * linux-nat.h (linux_trad_target): Delete declaration.
3406         (linux_target_install_ops): Declare.
3407         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
3408         "linux-nat.h".
3409
3410 2018-05-02  Pedro Alves  <palves@redhat.com>
3411
3412         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3413         procfs_target/add_target here.
3414         * procfs.c (procfs_target): Make static.
3415         (_initialize_procfs): Call add_target here.
3416         * procfs.h (struct target_ops): Remove forward declaration.
3417         (procfs_target): Remove declaration.
3418         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
3419
3420 2018-05-02  Pedro Alves  <palves@redhat.com>
3421
3422         * procfs.c (procfs_stopped_by_watchpoint)
3423         (procfs_insert_watchpoint, procfs_remove_watchpoint)
3424         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
3425         Forward declare.
3426         (procfs_use_watchpoints): Delete, move contents...
3427         (procfs_target): ... here.
3428         * procfs.h (procfs_use_watchpoints): Delete declaration.
3429         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3430         procfs_use_watchpoints.
3431         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
3432         procfs_use_watchpoints.
3433
3434 2018-05-02  Tom Tromey  <tom@tromey.com>
3435
3436         PR python/20084:
3437         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
3438         and var_zuinteger_unlimited.
3439         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
3440         and PARAM_ZUINTEGER_UNLIMITED.
3441         (set_parameter_value): Handle var_zuinteger and
3442         var_zuinteger_unlimited.
3443         (add_setshow_generic): Likewise.
3444         (parmpy_init): Likewise.
3445
3446 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
3447
3448         PR rust/23124
3449         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
3450         pointer is not null before dereferencing it.
3451
3452 2018-04-30  Tom Tromey  <tom@tromey.com>
3453
3454         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
3455         is_mi_like_p.
3456
3457 2018-04-30  Tom Tromey  <tom@tromey.com>
3458
3459         * breakpoint.c (mention): Remove use of is_mi_like_p.
3460         (print_mention_ranged_breakpoint): Likewise.
3461         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
3462         of is_mi_like_p.
3463
3464 2018-04-30  Tom Tromey  <tom@tromey.com>
3465
3466         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
3467
3468 2018-04-30  Tom Tromey  <tom@tromey.com>
3469
3470         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
3471         (info_spu_event_command): Remove some uses of is_mi_like_p.
3472
3473 2018-04-30  Tom Tromey  <tom@tromey.com>
3474
3475         * python/py-framefilter.c (py_print_single_arg)
3476         (enumerate_locals, py_print_args, py_print_frame): Remove some
3477         uses of is_mi_like_p.
3478
3479 2018-04-30  Tom Tromey  <tom@tromey.com>
3480
3481         * ui-out.c: Update.
3482         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
3483         * ui-out.h (ui_out::is_mi_like_p): Now const.
3484         (ui_out::do_is_mi_like_p): Now const.
3485         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
3486
3487 2018-04-30  Tom Tromey  <tom@tromey.com>
3488
3489         * varobj.c (varobj_set_visualizer): Use new_reference.
3490         * python/python.c (gdbpy_decode_line): Use new_reference.
3491         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
3492         new_reference.
3493
3494 2018-04-30  Tom Tromey  <tom@tromey.com>
3495
3496         * varobj.c (install_new_value): Use new_reference.
3497         * value.h (value_incref): Return void.  Swap intro comment with
3498         value_decref.
3499         * value.c (set_value_parent): Use new_reference.
3500         (value_incref): Return void.  Update intro comment.
3501         (release_value): Use new_reference.
3502         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
3503
3504 2018-04-30  Tom Tromey  <tom@tromey.com>
3505
3506         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
3507         * gdb_bfd.h (new_bfd_ref): Remove.
3508         (gdb_bfd_open): Update comment.
3509         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
3510         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
3511         (gdb_bfd_fdopenr): Use new_reference.
3512         * exec.c (exec_file_attach): Use new_reference.
3513
3514 2018-04-30  Tom Tromey  <tom@tromey.com>
3515
3516         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
3517         method.
3518
3519 2018-04-30  Tom Tromey  <tom@tromey.com>
3520
3521         * jit.c (jit_read_code_entry): Use type_align.
3522         * i386-tdep.c (i386_gdbarch_init): Don't call
3523         set_gdbarch_long_long_align_bit.
3524         * gdbarch.sh: Remove long_long_align_bit.
3525         * gdbarch.c, gdbarch.h: Rebuild.
3526         * arc-tdep.c (arc_type_align): New function.
3527         (arc_gdbarch_init): Use arc_type_align.  Don't call
3528         set_gdbarch_long_long_align_bit.
3529
3530 2018-04-30  Tom Tromey  <tom@tromey.com>
3531
3532         * rust-lang.c (rust_type_alignment): Remove.
3533         (rust_composite_type): Use type_align.
3534
3535 2018-04-30  Tom Tromey  <tom@tromey.com>
3536
3537         * NEWS: Mention Type.align.
3538         * python/py-type.c (typy_get_alignof): New function.
3539         (type_object_getset): Add "alignof".
3540
3541 2018-04-30  Tom Tromey  <tom@tromey.com>
3542
3543         PR exp/17095:
3544         * NEWS: Update.
3545         * std-operator.def (UNOP_ALIGNOF): New operator.
3546         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3547         New.
3548         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3549         * c-lang.c (c_op_print_tab): Add alignof.
3550         * c-exp.y (ALIGNOF): New token.
3551         (exp): Add "ALIGNOF" production.
3552         (ident_tokens): Add _Alignof and alignof.
3553
3554 2018-04-30  Tom Tromey  <tom@tromey.com>
3555
3556         * i386-tdep.c (i386_type_align): New function.
3557         (i386_gdbarch_init): Update.
3558         * gdbarch.sh (type_align): New method.
3559         * gdbarch.c, gdbarch.h: Rebuild.
3560         * arch-utils.h (default_type_align): Declare.
3561         * arch-utils.c (default_type_align): New function.
3562         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3563         (struct type) <align_log2>: New field.
3564         <instance_flags>: Now a bitfield.
3565         (TYPE_RAW_ALIGN): New macro.
3566         (type_align, type_raw_align, set_type_align): Declare.
3567         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3568         functions.
3569         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3570         (get_alignment, maybe_set_alignment): New functions.
3571         (read_structure_type, read_enumeration_type, read_array_type)
3572         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3573         (read_subrange_type, read_base_type): Set type alignment.
3574
3575 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3576
3577         * dwarf2read.c (read_index_from_section): Use bool.
3578
3579 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3580
3581         PR gdb/22950
3582         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3583         with #ifdef.
3584
3585 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3586
3587         PR build/22873
3588         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3589         last step, and do it atomically.
3590
3591 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3592
3593         * compile/compile-c-types.c (convert_int, convert_float):
3594         Update for C FE v1.
3595
3596 2018-04-27  Tom Tromey  <tom@tromey.com>
3597
3598         PR rust/22545:
3599         * rust-lang.c (rust_inclusive_range_type_p): New function.
3600         (rust_range): Handle inclusive ranges.
3601         (rust_compute_range): Likewise.
3602         * rust-exp.y (struct rust_op) <inclusive>: New field.
3603         (DOTDOTEQ): New constant.
3604         (range_expr): Add "..=" productions.
3605         (operator_tokens): Add "..=" token.
3606         (ast_range): Add "inclusive" parameter.
3607         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3608         ranges.
3609         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3610         bounds values.
3611         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3612         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3613         Update comments.
3614         * expprint.c (print_subexp_standard): Handle new bounds values.
3615         (dump_subexp_body_standard): Likewise.
3616
3617 2018-04-27  Tom Tromey  <tom@tromey.com>
3618
3619         * configure: Rebuild.
3620         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3621         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3622         "OVERRIDE".
3623         (class symbol_needs_eval_context): Likewise.
3624         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3625         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3626         "virtual".
3627         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3628         "override".
3629         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3630         * aarch64-tdep.c (instruction_reader::read): Use "override".
3631         (instruction_reader_test::read): Likewise.
3632         * arm-tdep.c (instruction_reader::read): Use "override".
3633         (instruction_reader_thumb::read): Likewise.
3634
3635 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3636
3637         PR remote/9665
3638         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3639         instead of remote_send.
3640         (remote_send): Remove.
3641
3642 2018-04-26  Pedro Alves  <palves@redhat.com>
3643
3644         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3645         find_function_start_sal instead of find_pc_line.
3646
3647 2018-04-26  Pedro Alves  <palves@redhat.com>
3648
3649         * breakpoint.c (set_breakpoint_location_function): Handle
3650         mst_data_gnu_ifunc.
3651         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3652         * elfread.c (elf_symtab_read): Give data symbols with
3653         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3654         (elf_rel_plt_read): Update comment.
3655         * linespec.c (convert_linespec_to_sals): Handle
3656         mst_data_gnu_ifunc.
3657         (minsym_found): Handle mst_data_gnu_ifunc.
3658         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3659         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3660         * parse.c (find_minsym_type_and_address): Handle
3661         mst_data_gnu_ifunc.
3662         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3663         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3664         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3665         comment.
3666         <mst_data_gnu_ifunc>: New enumerator.
3667
3668 2018-04-26  Pedro Alves  <palves@redhat.com>
3669
3670         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3671         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3672         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3673         Handle it.
3674         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3675         (lookup_minimal_symbol_by_pc): Adjust.
3676         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3677         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3678         * minsyms.h (lookup_msym_prefer): New enum.
3679         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3680         parameter by a lookup_msym_prefer parameter.
3681
3682 2018-04-26  Pedro Alves  <palves@redhat.com>
3683
3684         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3685         ends in "@plt" instead of looking at the symbol's section.
3686
3687 2018-04-26  Pedro Alves  <palves@redhat.com>
3688
3689         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3690         all references.
3691         (find_pc_partial_function_gnu_ifunc): Rename to ...
3692         (find_pc_partial_function): ... this, and remove references to
3693         'is_gnu_ifunc_p'.
3694         (find_pc_partial_function): Delete old implementation.
3695         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3696
3697 2018-04-26  Pedro Alves  <palves@redhat.com>
3698
3699         * linespec.c (struct bound_minimal_symbol_search_key): New.
3700         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3701         skip first line if we found a GNU ifunc minimal symbol by name.
3702         (compare_msymbols): Change parameters to work with a destructured
3703         lhs minsym.
3704         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3705         functions.
3706
3707 2018-04-26  Pedro Alves  <palves@redhat.com>
3708
3709         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3710         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3711         address/name.
3712         (add_location_to_breakpoint): Store the minsym and the objfile in
3713         the breakpoint location.
3714         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3715         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3716         Record the minsym in the sal.
3717         * symtab.h (symtab_and_line) <msymbol>: New field.
3718
3719 2018-04-26  Pedro Alves  <palves@redhat.com>
3720
3721         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3722         unless we actually resolved the ifunc.
3723
3724 2018-04-26  Pedro Alves  <palves@redhat.com>
3725
3726         * c-exp.y (variable production): Prefer ifunc minsyms over
3727         regular function symbols.
3728         * symtab.c (find_gnu_ifunc): New function.
3729         * minsyms.h (lookup_msym_prefer): New enum.
3730         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3731         parameter by a lookup_msym_prefer parameter.
3732         * symtab.h (find_gnu_ifunc): New declaration.
3733
3734 2018-04-26  Pedro Alves  <palves@redhat.com>
3735
3736         * blockframe.c (find_gnu_ifunc_target_type): New function.
3737         (find_function_type): New.
3738         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3739         return a value with a memory address.
3740         (eval_call): For calls to GNU ifunc functions, try to find the
3741         type of the target function from the type that the resolver
3742         returns.
3743         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3744         symbols.
3745         * infcall.c (find_function_return_type): Delete.
3746         (find_function_addr): Add 'function_type' parameter.  For calls to
3747         GNU ifunc functions, try to find the type of the target function
3748         from the type that the resolver returns, and return it via
3749         FUNCTION_TYPE.
3750         (call_function_by_hand_dummy): Adjust to use the function type
3751         returned by find_function_addr.
3752         (find_function_addr): Add 'function_type' parameter and move
3753         description here.
3754         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3755         declarations.
3756
3757 2018-04-26  Pedro Alves  <palves@redhat.com>
3758
3759         * c-exp.y (variable production): Skip finding an alias for ifunc
3760         symbols.
3761
3762 2018-04-26  Pedro Alves  <palves@redhat.com>
3763
3764         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3765
3766 2018-04-25  Pedro Alves  <palves@redhat.com>
3767
3768         * infcmd.c (kill_command): Print the pid as string, not the whole
3769         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3770         message.
3771         * remote.c (remote_detach_1): Print the pid as string, not the
3772         whole thread's ptid.
3773
3774 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3775             Sergio Durigan Junior  <sergiodj@redhat.com>
3776             Pedro Alves  <palves@redhat.com>
3777
3778         * infcmd.c (kill_command): Print message when inferior has
3779         been killed.
3780         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3781         '1'.
3782         (add_inferior): Improve message printed when
3783         'print_inferior_events' is on.
3784         (exit_inferior): Remove message printed when
3785         'print_inferior_events' is on.
3786         (detach_inferior): Improve message printed when
3787         'print_inferior_events' is on.
3788         (initialize_inferiors): Use 'add_inferior_silent' to set
3789         'current_inferior_'.
3790         * inferior.h (print_inferior_events): Declare here as
3791         'extern'.
3792         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3793         '[Detaching...]' messages when 'print_inferior_events' is on.
3794         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3795         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3796         'Detaching after fork from child...', replace it by '... from
3797         parent...'.
3798         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3799         prefix/suffix when printing 'Detaching...' messages.  Print
3800         them when 'print_inferior_events' is on.
3801         * remote.c (remote_detach_1): Print message when detaching
3802         from inferior and '!is_fork_parent'.
3803
3804 2018-04-24  Tom Tromey  <tom@tromey.com>
3805
3806         * cli-out.h: Reindent.
3807
3808 2018-04-24  Tom Tromey  <tom@tromey.com>
3809
3810         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3811         (cli_ui_out::do_field_string): Use fputs_filtered.
3812         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3813
3814 2018-04-23  Tom Tromey  <tom@tromey.com>
3815
3816         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3817         gdb::unique_xmalloc_ptr.
3818
3819 2018-04-23  Tom Tromey  <tom@tromey.com>
3820
3821         * configure: Rebuild.
3822
3823 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3824
3825         PR gdb/23095
3826         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3827         prepare_for_testing.  Set normal_bp to r_debug_state if target
3828         is bsd.
3829
3830 2018-04-21  Pedro Alves  <palves@redhat.com>
3831             Rajendra SY  <rajendra.sy@gmail.com>
3832
3833         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3834         * remote.c (extended_remote_attach): In all-stop mode, mark the
3835         thread as executing.
3836
3837 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3838
3839         * thread.c (thread_apply_all_command): Fix comment.
3840         (thread_command): Fix comment.
3841
3842 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3843
3844         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3845         parameter.
3846         * features/aarch64-core.c (create_feature_aarch64_core):
3847         Regenerate.
3848         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3849         Likewise.
3850         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3851         Likewise.
3852         * features/i386/32bit-avx512.c
3853         (create_feature_i386_32bit_avx512): Likewise.
3854         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3855         Likewise.
3856         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3857         Likewise.
3858         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3859         Likewise.
3860         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3861         Likewise.
3862         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3863         Likewise.
3864         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3865         Likewise.
3866         * features/i386/64bit-avx512.c
3867         (create_feature_i386_64bit_avx512): Likewise.
3868         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3869         Likewise.
3870         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3871         Likewise.
3872         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3873         Likewise.
3874         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3875         Likewise.
3876         * features/i386/64bit-segments.c
3877         (create_feature_i386_64bit_segments): Likewise.
3878         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3879         Likewise.
3880         * features/i386/x32-core.c
3881         (create_feature_i386_x32_core): Likewise.
3882         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3883         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3884         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3885         * target-descriptions.c: In generated code, don't pass xml
3886         filename.
3887
3888 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3889
3890         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3891         (print_xml_feature::visit_post): Likewise.
3892         (print_xml_feature::visit): Likewise.
3893         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3894         (print_xml_feature): Add new class.
3895         * regformats/regdat.sh: Null xmltarget on feature targets.
3896         * target-descriptions.c (struct target_desc): Add xmltarget.
3897         (maintenance_check_tdesc_xml_convert): Add unittest function.
3898         (tdesc_get_features_xml): Add function to get xml.
3899         (maintenance_check_xml_descriptions): Test xml generation.
3900         * xml-tdesc.c (string_read_description_xml): Add function.
3901         * xml-tdesc.h (string_read_description_xml): Add declaration.
3902
3903 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3904
3905         * features/Makefile: Add feature marker to targets with new style
3906         target descriptions.
3907         * regformats/aarch64.dat: Regenerate.
3908         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3909         * regformats/i386/amd64-avx-linux.dat: Likewise.
3910         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3911         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3912         * regformats/i386/amd64-linux.dat: Likewise.
3913         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3914         * regformats/i386/amd64.dat: Likewise.
3915         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3916         * regformats/i386/i386-avx-linux.dat: Likewise.
3917         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3918         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3919         * regformats/i386/i386-linux.dat: Likewise.
3920         * regformats/i386/i386-mmx-linux.dat: Likewise.
3921         * regformats/i386/i386-mpx-linux.dat: Likewise.
3922         * regformats/i386/i386.dat: Likewise.
3923         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3924         * regformats/i386/x32-avx-linux.dat: Likewise.
3925         * regformats/i386/x32-linux.dat: Likewise.
3926         * regformats/tic6x-c62x-linux.dat: Likewise.
3927         * regformats/tic6x-c64x-linux.dat: Likewise.
3928         * regformats/tic6x-c64xp-linux.dat: Likewise.
3929         * regformats/regdat.sh: Parse feature marker.
3930
3931 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3932
3933         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3934         (tdesc_osabi_name): Likewise.
3935         * target-descriptions.c (tdesc_architecture_name): Add new
3936         function.
3937         (tdesc_osabi_name): Likewise.
3938
3939 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3940
3941         * common/tdesc.c (tdesc_predefined_type): Move to here.
3942         (tdesc_named_type): Likewise.
3943         (tdesc_create_vector): Likewise.
3944         (tdesc_create_struct): Likewise.
3945         (tdesc_set_struct_size): Likewise.
3946         (tdesc_create_union): Likewise.
3947         (tdesc_create_flags): Likewise.
3948         (tdesc_create_enum): Likewise.
3949         (tdesc_add_field): Likewise.
3950         (tdesc_add_typed_bitfield): Likewise.
3951         (tdesc_add_bitfield): Likewise.
3952         (tdesc_add_flag): Likewise.
3953         (tdesc_add_enum_value): Likewise.
3954         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3955         (struct tdesc_type_vector): Likewise.
3956         (struct tdesc_type_field): Likewise.
3957         (struct tdesc_type_with_fields): Likewise.
3958         (tdesc_create_enum): Add declaration.
3959         (tdesc_add_typed_bitfield): Likewise.
3960         (tdesc_add_enum_value): Likewise.
3961         * target-descriptions.c (tdesc_type_field): Move from here.
3962         (tdesc_type_builtin): Likewise.
3963         (tdesc_type_vector): Likewise.
3964         (tdesc_type_with_fields): Likewise.
3965         (tdesc_predefined_types): Likewise.
3966         (tdesc_named_type): Likewise.
3967         (tdesc_create_vector): Likewise.
3968         (tdesc_create_struct): Likewise.
3969         (tdesc_set_struct_size): Likewise.
3970         (tdesc_create_union): Likewise.
3971         (tdesc_create_flags): Likewise.
3972         (tdesc_create_enum): Likewise.
3973         (tdesc_add_field): Likewise.
3974         (tdesc_add_typed_bitfield): Likewise.
3975         (tdesc_add_bitfield): Likewise.
3976         (tdesc_add_flag): Likewise.
3977         (tdesc_add_enum_value): Likewise.
3978         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3979         (tdesc_add_typed_bitfield): Likewise.
3980         (tdesc_add_enum_value): Likewise.
3981
3982 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3983
3984         * common/tdesc.c (tdesc_feature::accept): Move to here.
3985         (tdesc_feature::operator==): Likewise.
3986         (tdesc_create_reg): Likewise.
3987         * common/tdesc.h (tdesc_type_kind): Likewise.
3988         (struct tdesc_type): Likewise.
3989         (struct tdesc_feature): Likewise.
3990         * regformats/regdat.sh: Create a feature.
3991         * target-descriptions.c (tdesc_type_kind): Move from here.
3992         (tdesc_type): Likewise.
3993         (tdesc_type_up): Likewise.
3994         (tdesc_feature): Likewise.
3995         (tdesc_create_reg): Likewise.
3996
3997 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3998
3999         * Makefile.in: Add arch/tdesc.c
4000         * common/tdesc.c: New file.
4001         * common/tdesc.h (tdesc_element_visitor): Move to here.
4002         (tdesc_element): Likewise.
4003         (tdesc_reg): Likewise.
4004         (tdesc_reg_up): Likewise.
4005         * regformats/regdef.h (reg): Add offset to constructors.
4006         * target-descriptions.c (tdesc_element_visitor): Move from here.
4007         (tdesc_element): Likewise.
4008         (tdesc_reg): Likewise.
4009         (tdesc_reg_up): Likewise.
4010
4011 2018-04-17  Tom Tromey  <tom@tromey.com>
4012
4013         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
4014         discriminant field.
4015
4016 2018-04-17  Tom Tromey  <tom@tromey.com>
4017
4018         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
4019
4020 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4021
4022         * symtab.c (print_symbol_info): Skip printing filename and line
4023         number when `last' is NULL.
4024         (symtab_symbol_info): Use empty string instead of NULL for first
4025         invocation of print_symbol_info.
4026         (rbreak_command): Pass NULL to `last' parameter of
4027         print_symbol_info.
4028
4029 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
4030
4031         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
4032         instead of nullptr.
4033
4034 2018-04-16  Pedro Alves  <palves@redhat.com>
4035
4036         * MAINTAINERS (sh): Remove.
4037         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
4038         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
4039         (ALLDEPFILES): Remove sh64-tdep.c.
4040         * NEWS: Mentions that support for SH-5/SH64 is removed.
4041         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
4042         (sh*-*-openbsd*): Ditto.
4043         (sh64-*-elf*): Remove.
4044         (sh*): Remove.
4045         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
4046         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
4047         * sh-tdep.c: No longer include "sh64-tdep.h".
4048         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
4049         * sh64-tdep.c, sh64-tdep.h: Remove files.
4050
4051 2018-04-16  Pedro Alves  <palves@redhat.com>
4052
4053         * MAINTAINERS: Remove m88k.
4054         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
4055         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
4056         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
4057         * NEWS: Mention that support for m88k was removed.
4058         * configure.host (m88*-*-*): Remove support.
4059         * configure.nat (m88k-*-*): Remove support.
4060         * configure.tgt (m88*-*-openbsd*): Remove.
4061         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
4062
4063 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
4064
4065         * configure.tgt (x86_tobjs): New variable.
4066         (amd64_tobjs, i386_tobjs): Use it.
4067
4068 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4069
4070         * symtab.c (print_symbol_info): Precede the symbol definition by
4071         the line number when available.
4072         * NEWS: Advertise this enhancement.
4073
4074 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4075
4076         * NEWS (New options): announce set/show record btrace cpu.
4077         * btrace.c: Include record-btrace.h.
4078         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
4079         the vendor is unknown.
4080         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
4081         Maybe overwrite the btrace configuration's cpu.
4082         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
4083         (btrace_fetch): Add cpu parameter.  Update callers.
4084         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
4085         Maybe overwrite the btrace configuration's cpu.  Skip enabling
4086         errata workarounds if the vendor is unknown.
4087         * python/py-record-btrace.c: Include record-btrace.h.
4088         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
4089         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
4090         * record-btrace.c (record_btrace_cpu_state_kind): New.
4091         (record_btrace_cpu): New.
4092         (set_record_btrace_cpu_cmdlist): New.
4093         (record_btrace_get_cpu): New.
4094         (require_btrace_thread, record_btrace_info)
4095         (record_btrace_resume_thread): Call record_btrace_get_cpu.
4096         (cmd_set_record_btrace_cpu_none): New.
4097         (cmd_set_record_btrace_cpu_auto): New.
4098         (cmd_set_record_btrace_cpu): New.
4099         (cmd_show_record_btrace_cpu): New.
4100         (_initialize_record_btrace): Initialize set/show record btrace cpu
4101         commands.
4102         * record-btrace.h (record_btrace_get_cpu): New.
4103
4104 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4105
4106         * record.c (set_record_command): Fix typo in message.
4107
4108 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4109
4110         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
4111
4112 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
4113
4114         * infrun.c (process_event_stop_test): Call
4115         gdbarch_in_indirect_branch_thunk.
4116         * gdbarch.sh (in_indirect_branch_thunk): New.
4117         * gdbarch.c: Regenerated.
4118         * gdbarch.h: Regenerated.
4119         * x86-tdep.h: New.
4120         * x86-tdep.c: New.
4121         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
4122         (HFILES_NO_SRCDIR): Add x86-tdep.h.
4123         (ALLDEPFILES): Add x86-tdep.c.
4124         * arch-utils.h (default_in_indirect_branch_thunk): New.
4125         * arch-utils.c (default_in_indirect_branch_thunk): New.
4126         * i386-tdep: Include x86-tdep.h.
4127         (i386_in_indirect_branch_thunk): New.
4128         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
4129         function.
4130         * amd64-tdep: Include x86-tdep.h.
4131         (amd64_in_indirect_branch_thunk): New.
4132         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
4133
4134 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
4135
4136         PR gdb/23053
4137         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
4138         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
4139         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
4140         regression.
4141
4142 2018-04-12  Tom Tromey  <tom@tromey.com>
4143
4144         * rust-lang.c (rust_print_struct_def): Remove univariant code.
4145         (rust_evaluate_subexp): Likewise.
4146
4147 2018-04-12  Pedro Alves  <palves@redhat.com>
4148
4149         * procfs.c (procfs_detach): Make forward declaration's prototype
4150         match definition's protototype.
4151         (proc_get_LDT_entry): Remove stale do_cleanups call.
4152
4153 2018-04-12  Pedro Alves  <palves@redhat.com>
4154
4155         * target.h (target_ops::to_has_exited): Delete.
4156         (target_has_exited): Delete.
4157         * target-delegates.c: Regenerate.
4158
4159 2018-04-11  Pedro Alves  <palves@redhat.com>
4160
4161         * target.c (fileio_fh_t::t): Add comment.
4162         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
4163         (target_fileio_close): Handle a NULL target.
4164         (invalidate_fileio_fh): New.
4165         (target_close): Call it.
4166         * remote.c (remote_hostio_send_command): No longer check whether
4167         remote_desc is open.
4168
4169 2018-04-11  Pedro Alves  <palves@redhat.com>
4170
4171         * target.c (fileio_fh_t): Make it a named struct instead of a
4172         typedef.
4173         (fileio_fh_t::is_closed): New method.
4174         (DEF_VEC_O (fileio_fh_t)): Remove.
4175         (fileio_fhandles): Now a std::vector.
4176         (is_closed_fileio_fh): Delete.
4177         (acquire_fileio_fd): Adjust.  Rename parameters.
4178         (release_fileio_fd): Adjust.
4179         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
4180         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
4181         (target_fileio_close): Adjust.
4182
4183 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
4184
4185         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
4186         index.
4187
4188 2018-04-10  Pedro Alves  <palves@redhat.com>
4189
4190         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
4191         (scoped_finish_thread_state): New class.
4192         * infcmd.c (run_command_1): Use it instead of finish_thread_state
4193         cleanup.
4194         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
4195         (fetch_inferior_event, normal_stop): Likewise.
4196         * thread.c (finish_thread_state_cleanup): Delete.
4197
4198 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4199             Pedro Alves  <palves@redhat.com>
4200
4201         * value.c: Include "selftest.h" and "common/array-view.h".
4202         (struct range) <operator ==>: New.
4203         (test_ranges_contain): New.
4204         (check_ranges_vector): New.
4205         (test_insert_into_bit_range_vector): New.
4206         (_initialize_values): Register selftests.
4207         * common/array-view.h (operator==, operator!=): New.
4208
4209 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4210
4211         * common/gdb_vecs.h (unordered_remove): Add overload that takes
4212         an iterator.
4213         * inline-frame.c: Include <algorithm>.
4214         (struct inline_state): Add constructor.
4215         (inline_state_s): Remove.
4216         (DEF_VEC_O(inline_state_s)): Remove.
4217         (inline_states): Change type to std::vector.
4218         (find_inline_frame_state): Adjust to std::vector.
4219         (allocate_inline_frame_state): Remove.
4220         (clear_inline_frame_state): Adjust to std::vector.
4221         (skip_inline_frames): Adjust to std::vector.
4222
4223 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4224
4225         * tracepoint.h (struct trace_state_variable): Add constructor.
4226         <name>: Change type to std::string.
4227         * tracepoint.c (tsv_s): Remove.
4228         (DEF_VEC_O(tsv_s)): Remove.
4229         (tvariables): Change to std::vector.
4230         (create_trace_state_variable): Adjust to std::vector.
4231         (find_trace_state_variable): Likewise.
4232         (find_trace_state_variable_by_number): Likewise.
4233         (delete_trace_state_variable): Likewise.
4234         (trace_variable_command): Adjust to std::string.
4235         (delete_trace_variable_command): Likewise.
4236         (tvariables_info_1): Adjust to std::vector.
4237         (save_trace_state_variables): Likewise.
4238         (start_tracing): Likewise.
4239         (merge_uploaded_trace_state_variables): Adjust to std::vector
4240         and std::string.
4241         * target.h (struct target_ops)
4242         <to_download_trace_state_variable>: Pass reference to
4243         trace_state_variable.
4244         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
4245         * target-delegates.c: Re-generate.
4246         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
4247         (mi_tsv_deleted): Likewise.
4248         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
4249         * remote.c (remote_download_trace_state_variable): Change
4250         pointer to reference and adjust.
4251         * make-target-delegates (parse_argtypes): Handle references.
4252         (write_function_header): Likewise.
4253         (munge_type): Likewise.
4254
4255 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4256
4257         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4258         string_view-selftests.c.
4259         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
4260         testsuite.
4261         * unittests/basic_string_view/cons/char/1.cc: Likewise.
4262         * unittests/basic_string_view/cons/char/2.cc: Likewise.
4263         * unittests/basic_string_view/cons/char/3.cc: Likewise.
4264         * unittests/basic_string_view/element_access/char/1.cc:
4265         Likewise.
4266         * unittests/basic_string_view/element_access/char/empty.cc:
4267         Likewise.
4268         * unittests/basic_string_view/element_access/char/front_back.cc:
4269         Likewise.
4270         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
4271         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
4272         Likewise.
4273         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
4274         Likewise.
4275         * unittests/basic_string_view/modifiers/swap/char/1.cc:
4276         Likewise.
4277         * unittests/basic_string_view/operations/compare/char/1.cc:
4278         Likewise.
4279         * unittests/basic_string_view/operations/compare/char/13650.cc:
4280         Likewise.
4281         * unittests/basic_string_view/operations/copy/char/1.cc:
4282         Likewise.
4283         * unittests/basic_string_view/operations/data/char/1.cc:
4284         Likewise.
4285         * unittests/basic_string_view/operations/find/char/1.cc:
4286         Likewise.
4287         * unittests/basic_string_view/operations/find/char/2.cc:
4288         Likewise.
4289         * unittests/basic_string_view/operations/find/char/3.cc:
4290         Likewise.
4291         * unittests/basic_string_view/operations/find/char/4.cc:
4292         Likewise.
4293         * unittests/basic_string_view/operations/rfind/char/1.cc:
4294         Likewise.
4295         * unittests/basic_string_view/operations/rfind/char/2.cc:
4296         Likewise.
4297         * unittests/basic_string_view/operations/rfind/char/3.cc:
4298         Likewise.
4299         * unittests/basic_string_view/operations/substr/char/1.cc:
4300         Likewise.
4301         * unittests/basic_string_view/operators/char/2.cc: Likewise.
4302         * unittests/string_view-selftests.c: New file.
4303
4304 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4305
4306         * unittests/basic_string_view/capacity/1.cc: New file.
4307         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
4308         * unittests/basic_string_view/cons/char/1.cc: New file.
4309         * unittests/basic_string_view/cons/char/2.cc: New file.
4310         * unittests/basic_string_view/cons/char/3.cc: New file.
4311         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
4312         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
4313         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
4314         * unittests/basic_string_view/element_access/char/1.cc: New file.
4315         * unittests/basic_string_view/element_access/char/2.cc: New file.
4316         * unittests/basic_string_view/element_access/char/empty.cc: New file.
4317         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
4318         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
4319         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
4320         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
4321         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
4322         * unittests/basic_string_view/include.cc: New file.
4323         * unittests/basic_string_view/inserters/char/1.cc: New file.
4324         * unittests/basic_string_view/inserters/char/2.cc: New file.
4325         * unittests/basic_string_view/inserters/char/3.cc: New file.
4326         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
4327         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
4328         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
4329         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
4330         * unittests/basic_string_view/literals/types.cc: New file.
4331         * unittests/basic_string_view/literals/values.cc: New file.
4332         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
4333         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
4334         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
4335         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
4336         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
4337         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
4338         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
4339         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
4340         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
4341         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
4342         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
4343         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
4344         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
4345         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
4346         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
4347         * unittests/basic_string_view/operations/data/char/1.cc: New file.
4348         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
4349         * unittests/basic_string_view/operations/find/char/1.cc: New file.
4350         * unittests/basic_string_view/operations/find/char/2.cc: New file.
4351         * unittests/basic_string_view/operations/find/char/3.cc: New file.
4352         * unittests/basic_string_view/operations/find/char/4.cc: New file.
4353         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
4354         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
4355         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
4356         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
4357         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
4358         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
4359         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
4360         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
4361         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
4362         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
4363         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
4364         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
4365         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
4366         * unittests/basic_string_view/operators/char/2.cc: New file.
4367         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
4368         * unittests/basic_string_view/range_access/char/1.cc: New file.
4369         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
4370         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
4371         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
4372         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
4373         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
4374         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
4375         * unittests/basic_string_view/requirements/typedefs.cc: New file.
4376         * unittests/basic_string_view/typedefs.cc: New file.
4377         * unittests/basic_string_view/types/1.cc: New file.
4378
4379 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4380
4381         * common/gdb_string_view.h: Remove libstdc++ implementation
4382         details, adjust to gdb reality.
4383         * common/gdb_string_view.tcc: Likewise.
4384         * cli/cli-script.c (struct string_view): Remove.
4385         (user_args) <m_args>: Change element type to gdb::string_view.
4386         (user_args::insert_args): Adjust.
4387
4388 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4389
4390         * common/gdb_string_view.h: New file.
4391         * common/gdb_string_view.tcc: New file.
4392
4393 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4394
4395         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
4396         * configure: Re-generate.
4397
4398 2018-04-09  Pedro Alves  <palves@redhat.com>
4399
4400         * gdbarch.sh: Include "observable.h" instead of "observer.h".
4401         (set_target_gdbarch): Call
4402         gdb::observers::architecture_changed.notify instead of
4403         observer_notify_architecture_changed.
4404
4405 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4406
4407         * tracepoint.c (struct current_traceframe_cleanup): Remove.
4408         (do_restore_current_traceframe_cleanup): Remove.
4409         (restore_current_traceframe_cleanup_dtor): Remove.
4410         (make_cleanup_restore_current_traceframe): Remove.
4411         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
4412         New.
4413         * tracepoint.h (struct scoped_restore_current_traceframe): New.
4414         * infrun.c (fetch_inferior_event): Use
4415         scoped_restore_current_traceframe.
4416
4417 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4418
4419         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
4420         Remove.
4421         <n_allocated_type_units>: Remove.
4422         <all_type_units>: Change to std::vector.
4423         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4424         to std::vector change.
4425         (dwarf2_per_objfile::get_cutu): Likewise.
4426         (dwarf2_per_objfile::get_tu): Likewise.
4427         (create_signatured_type_table_from_index): Likewise.
4428         (create_signatured_type_table_from_debug_names): Likewise.
4429         (dw2_symtab_iter_next): Likewise.
4430         (dw2_print_stats): Likewise.
4431         (dw2_expand_all_symtabs): Likewise.
4432         (dw2_expand_marked_cus): Likewise.
4433         (dw2_debug_names_iterator::next): Likewise.
4434         (dwarf2_initialize_objfile): Likewise.
4435         (add_signatured_type_cu_to_table): Likewise.
4436         (create_all_type_units): Likewise.
4437         (add_type_unit): Likewise.
4438         (struct tu_abbrev_offset): Add constructor.
4439         (build_type_psymtabs_1): Adjust to std::vector change.
4440         (print_tu_stats): Likewise.
4441         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4442         (write_debug_names): Likewise.
4443
4444 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4445
4446         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
4447         Make an std::vector.
4448         <n_comp_units>: Remove.
4449         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4450         to std::vector change.
4451         (dwarf2_per_objfile::get_cutu): Likewise.
4452         (dwarf2_per_objfile::get_cu): Likewise.
4453         (create_cus_from_index): Likewise.
4454         (create_addrmap_from_index): Likewise.
4455         (create_addrmap_from_aranges): Likewise.
4456         (dwarf2_read_index): Likewise.
4457         (dw2_find_last_source_symtab): Likewise.
4458         (dw2_map_symtabs_matching_filename): Likewise.
4459         (dw2_symtab_iter_next): Likewise.
4460         (dw2_print_stats): Likewise.
4461         (dw2_expand_all_symtabs): Likewise.
4462         (dw2_expand_symtabs_with_fullname): Likewise.
4463         (dw2_expand_marked_cus): Likewise.
4464         (dw2_map_symbol_filenames): Likewise.
4465         (create_cus_from_debug_names): Likewise.
4466         (dwarf2_read_debug_names): Likewise.
4467         (dw2_debug_names_iterator::next): Likewise.
4468         (dwarf2_initialize_objfile): Likewise.
4469         (set_partial_user): Likewise.
4470         (dwarf2_build_psymtabs_hard): Likewise.
4471         (read_comp_units_from_section): Remove arguments, adjust to
4472         std::vector change.
4473         (create_all_comp_units): Adjust to std::vector and
4474         read_comp_units_from_section changes.
4475         (dwarf2_find_containing_comp_unit): Adjust to std::vector
4476         change.
4477         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4478         (psyms_seen_size): Likewise.
4479         (write_gdbindex): Likewise.
4480         (write_debug_names): Likewise.
4481
4482 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4483
4484         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
4485         with dwarf2_per_objfile.
4486         (create_cus_from_index): Likewise.
4487         (create_signatured_type_table_from_index): Likewise.
4488         (dwarf2_read_index): Likewise.
4489         (dwarf2_initialize_objfile): Likewise.
4490         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
4491         per_cu rather than get_dwarf2_per_objfile.
4492
4493 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4494
4495         * dwarf2read.h (struct signatured_type): Forward declare.
4496         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
4497         New methods.
4498         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
4499         (dw2_get_cutu): ...this.
4500         (dwarf2_per_objfile::get_cu): Rename from...
4501         (dw2_get_cu): ...this.
4502         (dwarf2_per_objfile::get_tu): New.
4503         (create_addrmap_from_index): Adjust.
4504         (create_addrmap_from_aranges): Adjust.
4505         (dw2_find_last_source_symtab): Adjust.
4506         (dw2_map_symtabs_matching_filename): Adjust.
4507         (dw2_symtab_iter_next): Adjust.
4508         (dw2_print_stats): Adjust.
4509         (dw2_expand_all_symtabs): Adjust.
4510         (dw2_expand_symtabs_with_fullname): Adjust.
4511         (dw2_expand_marked_cus): Adjust.
4512         (dw_expand_symtabs_matching_file_matcher): Adjust.
4513         (dw2_map_symbol_filenames): Adjust.
4514         (dw2_debug_names_iterator::next): Adjust.
4515         (dwarf2_initialize_objfile): Adjust.
4516         (set_partial_user): Adjust.
4517         (dwarf2_build_psymtabs_hard): Adjust.
4518
4519 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4520
4521         * dwarf2read.c (create_signatured_type_table_from_debug_names):
4522         Remove unused variables.
4523         (dw2_map_symtabs_matching_filename): Likewise.
4524         (dwarf2_record_block_ranges): Likewise.
4525         (dwarf2_read_addr_index): Likewise.
4526         (follow_die_offset): Likewise.
4527
4528 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4529
4530         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4531         to symbol_file_add_main.
4532
4533 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4534
4535         PR mi/22299
4536         * mi/mi-console.c (do_fputc_async_safe): New.
4537         (mi_console_file::write_async_safe): New.
4538         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4539         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4540         New.
4541         * ui-file.c (ui_file::putstrn): Adjust call to
4542         fputstrn_unfiltered.
4543         * utils.c (printchar): Replace do_fputs and do_fprintf
4544         parameters by do_fputc.
4545         (fputstr_filtered): Adjust call to printchar.
4546         (fputstr_unfiltered): Likewise.
4547         (fputstrn_filtered): Likewise.
4548         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4549         printchar.
4550         * utils.h (do_fputc_ftype): New typedef.
4551         (fputstrn_unfiltered): Add do_fputc parameter.
4552
4553 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4554
4555         * regformats/i386/i386-avx.dat: Remove.
4556
4557 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4558
4559         PR gdb/22979
4560         * amd64-tdep.c (amd64_none_init_abi): New function.
4561         (amd64_x32_none_init_abi): New function.
4562         (_initialize_amd64_tdep): Register handlers for x86-64 and
4563         x64_32 with GDB_OSABI_NONE.
4564         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4565         GDB_OSABI_NONE osabi.
4566
4567 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4568
4569         PR gdb/22980
4570         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4571         GDB_OSABI_NONE.
4572         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4573         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4574
4575 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4576
4577         * common/byte-vector.h (char_vector): New type.
4578         * target.h (target_read_alloc): Return
4579         gdb::optional<byte_vector>.
4580         (target_read_stralloc): Return gdb::optional<char_vector>.
4581         (target_get_osdata): Return gdb::optional<char_vector>.
4582         * target.c (target_read_alloc_1): Templatize.  Replacement
4583         manual memory management with vector.
4584         (target_read_alloc): Change return type, adjust.
4585         (target_read_stralloc): Change return type, adjust.
4586         (target_get_osdata): Change return type, adjust.
4587         * auxv.c (struct auxv_info) <length>: Remove.
4588         <data>: Change type to gdb::optional<byte_vector>.
4589         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4590         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4591         (target_auxv_search): Adjust.
4592         (fprint_target_auxv): Adjust.
4593         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4594         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4595         (linux_make_corefile_notes): Adjust.
4596         * osdata.c (get_osdata): Adjust.
4597         * remote.c (remote_get_threads_with_qxfer): Adjust.
4598         (remote_memory_map): Adjust.
4599         (remote_traceframe_info): Adjust.
4600         (btrace_read_config): Adjust.
4601         (remote_read_btrace): Adjust.
4602         (remote_pid_to_exec_file): Adjust.
4603         * solib-aix.c (solib_aix_get_library_list): Adjust.
4604         * solib-dsbt.c (decode_loadmap): Don't free buf.
4605         (dsbt_get_initial_loadmaps): Adjust.
4606         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4607         * solib-target.c (solib_target_current_sos): Adjust.
4608         * tracepoint.c (sdata_make_value): Adjust.
4609         * xml-support.c (xinclude_start_include): Adjust.
4610         (xml_fetch_content_from_file): Adjust.
4611         * xml-support.h (xml_fetch_another): Change return type.
4612         (xml_fetch_content_from_file): Change return type.
4613         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4614         * xml-tdesc.c (file_read_description_xml): Adjust.
4615         (fetch_available_features_from_target): Change return type.
4616         (target_fetch_description_xml): Adjust.
4617         (target_read_description_xml): Adjust.
4618
4619 2018-04-06  Tom Tromey  <tom@tromey.com>
4620
4621         * value.c (~value): Update.
4622         (struct value) <contents>: Now unique_xmalloc_ptr.
4623         (value_contents_bits_eq, allocate_value_contents)
4624         (value_contents_raw, value_contents_all_raw)
4625         (value_contents_for_printing, value_contents_for_printing_const)
4626         (set_value_enclosing_type): Update.
4627
4628 2018-04-06  Tom Tromey  <tom@tromey.com>
4629
4630         * value.c (range_s): Remove typedef, VEC.
4631         (struct range): Add operator<.
4632         (range_lessthan): Remove.
4633         (ranges_contain): Change type.
4634         (~value): Update.
4635         (struct value) <unavailable, optimized_out>: Now std::vector.
4636         (value_entirely_available)
4637         (value_entirely_covered_by_range_vector)
4638         (value_entirely_unavailable, value_entirely_optimized_out):
4639         Update.
4640         (insert_into_bit_range_vector): Change argument type.
4641         (find_first_range_overlap): Likewise.
4642         (struct ranges_and_idx, value_contents_bits_eq)
4643         (require_not_optimized_out, require_available): Update.
4644         (ranges_copy_adjusted): Change argument types.
4645         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4646
4647 2018-04-06  Tom Tromey  <tom@tromey.com>
4648
4649         * value.c (~value): Update.
4650         (struct value) <parent>: Now a value_ref_ptr.
4651         (value_parent, set_value_parent, value_address, value_copy):
4652         Update.
4653
4654 2018-04-06  Tom Tromey  <tom@tromey.com>
4655
4656         * value.c (struct value): Add constructor, destructor, and member
4657         initializers.
4658         (allocate_value_lazy, value_decref): Update.
4659
4660 2018-04-06  Tom Tromey  <tom@tromey.com>
4661
4662         * value.c (struct value) <released, next>: Remove.
4663         (all_values): Now a std::vector.
4664         (allocate_value_lazy): Update.
4665         (value_next): Remove.
4666         (value_mark, value_free_to_mark, release_value)
4667         (value_release_to_mark): Update.
4668
4669 2018-04-06  Tom Tromey  <tom@tromey.com>
4670
4671         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4672         (free_value_chain): Remove.
4673         * value.c (free_value_chain): Remove.
4674         (value_release_to_mark): Return a std::vector.
4675         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4676         std::vector.
4677         (check_condition): Update.
4678         * eval.c (fetch_subexp_value): Change "val_chain" to a
4679         std::vector.
4680         * breakpoint.c (update_watchpoint): Update.
4681         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4682
4683 2018-04-06  Tom Tromey  <tom@tromey.com>
4684
4685         * value.h (free_all_values): Remove.
4686         * value.c (free_all_values): Remove.
4687
4688 2018-04-06  Tom Tromey  <tom@tromey.com>
4689
4690         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4691         (value_history_chain, value_history_count): Remove.
4692         (value_history): New global.
4693         (record_latest_value, access_value_history, show_values)
4694         (preserve_values): Update.
4695
4696 2018-04-06  Tom Tromey  <tom@tromey.com>
4697
4698         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4699         * varobj.c (varobj_set_display_format, varobj_set_value)
4700         (install_default_visualizer, construct_visualizer)
4701         (install_new_value, ~varobj, varobj_get_value_type)
4702         (my_value_of_variable, varobj_editable_p): Update.
4703         * c-varobj.c (c_describe_child, c_value_of_variable)
4704         (cplus_number_of_children, cplus_describe_child): Update.
4705         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4706         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4707         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4708
4709 2018-04-06  Tom Tromey  <tom@tromey.com>
4710
4711         * printcmd.c (last_examine_address): Change type to
4712         value_ref_ptr.
4713         (do_examine, x_command): Update.
4714
4715 2018-04-06  Tom Tromey  <tom@tromey.com>
4716
4717         * value.c (release_value): Update.
4718         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4719         (struct bpstats) <val>: Now a value_ref_ptr.
4720         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4721         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4722         (~watchpoint, print_it_watchpoint, watch_command_1)
4723         (invalidate_bp_value_on_memory_change): Update.
4724
4725 2018-04-06  Tom Tromey  <tom@tromey.com>
4726
4727         * varobj.c (varobj_clear_saved_item)
4728         (update_dynamic_varobj_children, install_new_value, ~varobj):
4729         Update.
4730         * value.h (value_incref): Move declaration earlier.
4731         (value_decref): Rename from value_free.
4732         (struct value_ref_policy): New.
4733         (value_ref_ptr): New typedef.
4734         (struct value_deleter): Remove.
4735         (gdb_value_up): Remove typedef.
4736         (release_value): Change return type.
4737         (release_value_or_incref): Remove.
4738         * value.c (set_value_parent): Update.
4739         (value_incref): Change return type.
4740         (value_decref): Rename from value_free.
4741         (value_free_to_mark, free_all_values, free_value_chain): Update.
4742         (release_value): Return value_ref_ptr.
4743         (release_value_or_incref): Remove.
4744         (record_latest_value, set_internalvar, clear_internalvar):
4745         Update.
4746         * stack.c (info_frame_command): Don't call value_free.
4747         * python/py-value.c (valpy_dealloc, valpy_new)
4748         (value_to_value_object): Update.
4749         * printcmd.c (do_examine): Update.
4750         * opencl-lang.c (lval_func_free_closure): Update.
4751         * mi/mi-main.c (register_changed_p): Don't call value_free.
4752         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4753         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4754         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4755         value_free.
4756         * guile/scm-value.c (vlscm_free_value_smob)
4757         (vlscm_scm_from_value): Update.
4758         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4759         (frame_unwind_register_unsigned, get_frame_register_bytes)
4760         (put_frame_register_bytes): Don't call value_free.
4761         * findvar.c (address_from_register): Don't call value_free.
4762         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4763         * dwarf2loc.c (entry_data_value_free_closure)
4764         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4765         (dwarf2_evaluate_loc_desc_full): Update.
4766         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4767         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4768         (~watchpoint, watch_command_1)
4769         (invalidate_bp_value_on_memory_change): Update.
4770         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4771
4772 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4773
4774         PR gdb/23022
4775         * warning.m4: Add -Wno-error=deprecated-register.
4776         * configure: Re-generate.
4777
4778 2018-04-05  Tom Tromey  <tom@tromey.com>
4779
4780         * linespec.h: Remove include of "vec.h".
4781
4782 2018-04-05  Tom Tromey  <tom@tromey.com>
4783
4784         * linespec.c (typep): Remove typedef.
4785         (find_methods, find_superclass_methods): Take a std::vector.
4786         (find_method): Use std::vector.
4787
4788 2018-04-05  Tom Tromey  <tom@tromey.com>
4789
4790         * utils.c (compare_strings): Remove.
4791         * utils.h (compare_strings): Remove.
4792         * objc-lang.h (find_imps): Update.
4793         * objc-lang.c (find_methods): Take a std::vector.
4794         (uniquify_strings, find_imps): Likewise.
4795         * linespec.c (find_methods): Take a std::vector.
4796         (decode_objc): Use std::vector.
4797         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4798         a std::vector.
4799         (find_method, find_function_symbols): Use std::vector.
4800
4801 2018-04-05  Tom Tromey  <tom@tromey.com>
4802
4803         * completer.c (completion_tracker::completion_tracker): Remove
4804         cast.
4805         (completion_tracker::discard_completions): Likewise.
4806         * breakpoint.c (ambiguous_names_p): Remove cast.
4807         * ada-lang.c (_initialize_ada_language): Remove cast.
4808         * utils.h (streq): Update.
4809         (streq_hash): Add new declaration.
4810         * utils.c (streq): Return bool.
4811         (streq_hash): New function.
4812
4813 2018-04-05  Tom Tromey  <tom@tromey.com>
4814
4815         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4816         Remove a string copy.
4817
4818 2018-04-05  Tom Tromey  <tom@tromey.com>
4819
4820         * linespec.c (filter_results): Use std::vector.
4821         (decode_line_2, decode_line_full): Update.
4822
4823 2018-04-05  Tom Tromey  <tom@tromey.com>
4824
4825         * linespec.c (canonical_to_fullform): Return std::string.
4826         (filter_results): Update.
4827         (struct decode_line_2_item): Add constructor.
4828         <fullform, displayform>: Now std::string.
4829         (decode_line_2_compare_items): Now a std::sort comparator.
4830         (decode_line_2): Update.
4831
4832 2018-04-05  Tom Tromey  <tom@tromey.com>
4833
4834         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4835         (unexpected_linespec_error): Update.
4836         (linespec_parse_basic, parse_linespec): Update.
4837
4838 2018-04-05  Tom Tromey  <tom@tromey.com>
4839
4840         * linespec.c (linespec_parse_basic): Reindent.
4841
4842 2018-04-05  Tom Tromey  <tom@tromey.com>
4843
4844         * minsyms.h (iterate_over_minimal_symbols): Update.
4845         * minsyms.c (iterate_over_minimal_symbols): Take a
4846         gdb::function_view.
4847         * linespec.c (struct collect_minsyms): Remove.
4848         (compare_msyms): Now a std::sort comparator.
4849         (add_minsym): Add parameters.
4850         (search_minsyms_for_name): Update.  Use std::vector.
4851
4852 2018-04-03  Tom Tromey  <tom@tromey.com>
4853
4854         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4855         gdb::byte_vector.
4856
4857 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4858
4859         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4860
4861 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4862
4863         PR gdb/16959
4864         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
4865         printing static type.
4866
4867 2018-04-01  Tom Tromey  <tom@tromey.com>
4868
4869         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4870         (rs6000_xfer_shared_libraries): Update.
4871
4872 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4873
4874         * common/gdb_vecs.h (char_ptr): Remove.
4875         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4876
4877 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4878
4879         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4880         with std::vector.
4881         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4882
4883 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4884
4885         * tracepoint.h (struct uploaded_tp): Initialize fields.
4886         <actions, step_actions, cmd_strings>: Change type to
4887         std::vector<char *>.
4888         * tracepoint.c (get_uploaded_tp): Allocate with new.
4889         (free_uploaded_tps): Free with delete.
4890         (parse_tracepoint_definition): Adjust to std::vector change.
4891         * breakpoint.c (read_uploaded_action): Likewise.
4892         (create_tracepoint_from_upload): Likewise.
4893         * ctf.c (ctf_write_uploaded_tp): Likewise.
4894         (SET_ARRAY_FIELD): Likewise.
4895         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4896
4897 2018-03-30  Tom Tromey  <tom@tromey.com>
4898
4899         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4900         std::unique_ptr.
4901         (svr4_keep_data_in_core): Update.
4902         (svr4_read_so_list): Update.
4903
4904 2018-03-30  Tom Tromey  <tom@tromey.com>
4905
4906         * windows-nat.c (handle_output_debug_string, handle_exception):
4907         Update.
4908         * target.h (target_read_string): Update.
4909         * target.c (target_read_string): Change "string" to
4910         unique_xmalloc_ptr.
4911         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4912         Update.
4913         * solib-frv.c (frv_current_sos): Update.
4914         * solib-dsbt.c (dsbt_current_sos): Update.
4915         * solib-darwin.c (darwin_current_sos): Update.
4916         * linux-thread-db.c (inferior_has_bug): Update.
4917         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4918         Update.  Remove alloca.
4919         * ada-lang.c (ada_main_name): Update.
4920
4921 2018-03-30  Tom Tromey  <tom@tromey.com>
4922
4923         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4924         (struct dwo_file_deleter): New.
4925         (dwo_file_up): New typedef.
4926         (open_and_init_dwo_file): Use dwo_file_up.
4927         (free_dwo_file_cleanup): Remove.
4928
4929 2018-03-30  Tom Tromey  <tom@tromey.com>
4930
4931         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4932         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4933
4934 2018-03-30  Tom Tromey  <tom@tromey.com>
4935
4936         * dwarf2read.c (class free_cached_comp_units): New class.
4937         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4938         (free_cached_comp_units): Remove function.
4939
4940 2018-03-30  Tom Tromey  <tom@tromey.com>
4941
4942         * utils.h (make_cleanup_unpush_target): Remove.
4943         * inf-ptrace.c (struct target_unpusher): New.
4944         (target_unpush_up) New typedef.
4945         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4946         target_unpush_up.
4947         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4948
4949 2018-03-27  Tom Tromey  <tom@tromey.com>
4950
4951         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4952
4953 2018-03-27  Pedro Alves  <palves@redhat.com>
4954             Tom Tromey  <tom@tromey.com>
4955
4956         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4957         destructor.  Now a class.
4958         (gdb_readline_wrapper_cleanup): Remove function.
4959         (gdb_readline_wrapper): Remove cleanups.
4960
4961 2018-03-27  Tom Tromey  <tom@tromey.com>
4962
4963         * typeprint.h (struct type_print_options) <local_typedefs,
4964         global_typedefs>: Remove "struct" keyword.
4965         (class typedef_hash_table): New class.
4966         (recursively_update_typedef_hash, add_template_parameters)
4967         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4968         (find_typedef_in_hash): Don't declare.
4969         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4970         (typedef_hash_table::recursively_update): Rename from
4971         recursively_update_typedef_hash.  Now a member.
4972         (typedef_hash_table::add_template_parameters): Rename from
4973         add_template_parameters.  Now a member.
4974         (typedef_hash_table::typedef_hash_table): Now a constructor;
4975         rename from create_typedef_hash.
4976         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4977         rename from free_typedef_hash.
4978         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4979         (do_free_global_table): Remove.
4980         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4981         from copy_type_recursive.
4982         (create_global_typedef_table): Remove.
4983         (typedef_hash_table::find_global_typedef): Now a member of
4984         typedef_hash_table.
4985         (typedef_hash_table::find_typedef): Rename from
4986         find_typedef_in_hash; now a member.
4987         (whatis_exp): Update.
4988         * extension.h (struct ext_lang_type_printers): Add constructor and
4989         destructor.
4990         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4991         declare.
4992         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4993         Now a constructor; rename from start_ext_lang_type_printers.
4994         (ext_lang_type_printers): Now a destructor; rename from
4995         free_ext_lang_type_printers.
4996         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4997         Update.
4998         (c_type_print_base_struct_union): Update.  Remove cleanups.
4999
5000 2018-03-27  Tom Tromey  <tom@tromey.com>
5001
5002         * dwarf-index-write.c: Include <cmath>.
5003
5004 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
5005
5006         * NEWS: Add entry describing new "set|show varsize-limit" command.
5007         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
5008         command.
5009         * printcmd.c (_initialize_printcmd): Add "set var" alias of
5010         "set variable".
5011
5012 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
5013
5014         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
5015         dwarf-index-write.c
5016         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
5017         * dwarf-index-common.c: New file.
5018         * dwarf-index-common.h: New file.
5019         * dwarf-index-write.c: New file.
5020         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
5021         (struct dwarf2_section_info): Move from here.
5022         (dwarf2_section_info_def): Likewise.
5023         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
5024         (offset_type): Likewise.
5025         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
5026         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
5027         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
5028         (byte_swap): Likewise.
5029         (MAYBE_SWAP): Likewise.
5030         (dwarf2_per_cu_ptr): Likewise.
5031         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
5032         (struct tu_stats): Likewise.
5033         (struct dwarf2_per_objfile): Likewise.
5034         (struct dwarf2_per_cu_data): Likewise.
5035         (struct signatured_type): Likewise.
5036         (sig_type_ptr): Likewise.
5037         (DEF_VEC_P (sig_type_ptr)): Likewise.
5038         (INDEX4_SUFFIX): Likewise.
5039         (INDEX5_SUFFIX): Likewise.
5040         (DEBUG_STR_SUFFIX): Likewise.
5041         (dwarf2_read_section): Make non-static.
5042         (mapped_index_string_hash): Move from here.
5043         (dwarf5_djb_hash): Likewise.
5044         (file_write): Likewise.
5045         (class data_buf): Likewise.
5046         (struct symtab_index_entry): Likewise.
5047         (struct mapped_symtab): Likewise.
5048         (find_slot): Likewise.
5049         (hash_expand): Likewise.
5050         (add_index_entry): Likewise.
5051         (uniquify_cu_indices): Likewise.
5052         (class c_str_view): Likewise.
5053         (class c_str_view_hasher): Likewise.
5054         (class vector_hasher): Likewise.
5055         (write_hash_table): Likewise.
5056         (psym_index_map): Likewise.
5057         (struct addrmap_index_data): Likewise.
5058         (add_address_entry): Likewise.
5059         (add_address_entry_worker): Likewise.
5060         (write_address_map): Likewise.
5061         (symbol_kind): Likewise.
5062         (write_psymbols): Likewise.
5063         (struct signatured_type_index_data): Likewise.
5064         (write_one_signatured_type): Likewise.
5065         (recursively_count_psymbols): Likewise.
5066         (recursively_write_psymbols): Likewise.
5067         (class debug_names): Likewise.
5068         (check_dwarf64_offsets): Likewise.
5069         (psyms_seen_size): Likewise.
5070         (write_gdbindex): Likewise.
5071         (write_debug_names): Likewise.
5072         (assert_file_size): Likewise.
5073         (write_psymtabs_to_index): Likewise.
5074         (save_gdb_index_command): Likewise.
5075         (_initialize_dwarf2_read): Don't register the "save gdb-index"
5076         command.
5077         * dwarf2read.h: New file.
5078
5079 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
5080
5081         PR gdb/22670
5082         * dwarf2read.c (dwarf2_physname): Do not return the demangled
5083         symbol name if the CU's language stores symbol names in linkage
5084         format.
5085         * language.h (struct language_defn)
5086         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
5087         all instances of this struct.
5088
5089 2018-03-26  Tom Tromey  <tom@tromey.com>
5090
5091         * stack.c (backtrace_command_1): Remove verbose code.
5092
5093 2018-03-26  Tom Tromey  <tom@tromey.com>
5094
5095         * python/py-framefilter.c (py_print_type): Don't catch
5096         exceptions.  Return void.
5097         (py_print_value): Likewise.
5098         (py_print_single_arg): Likewise.
5099         (enumerate_args): Don't catch exceptions.
5100         (py_print_args): Likewise.
5101         (py_print_frame): Likewise.
5102         (gdbpy_apply_frame_filter): Catch exceptions here.
5103
5104 2018-03-26  Tom Tromey  <tom@tromey.com>
5105
5106         * stack.c (_initialize_stack): Remove trailing newlines from help
5107         text.  Add "Usage" line to "backtrace" help.
5108
5109 2018-03-26  Tom Tromey  <tom@tromey.com>
5110
5111         PR python/16486:
5112         * python/py-framefilter.c (py_print_args): Call wrap_hint.
5113
5114 2018-03-26  Tom Tromey  <tom@tromey.com>
5115
5116         * python/py-framefilter.c (py_print_single_arg): Return
5117         EXT_LANG_BT_ERROR from catch.
5118
5119 2018-03-26  Tom Tromey  <tom@tromey.com>
5120
5121         PR backtrace/15584:
5122         * stack.c (backtrace_command_1): Move some code into no-filters
5123         "if".
5124
5125 2018-03-26  Tom Tromey  <tom@tromey.com>
5126
5127         * python/py-framefilter.c (throw_quit_or_print_exception): New
5128         function.
5129         (gdbpy_apply_frame_filter): Use it.
5130
5131 2018-03-26  Tom Tromey  <tom@tromey.com>
5132
5133         PR cli/17716:
5134         * python/py-framefilter.c (py_print_type, py_print_value)
5135         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
5136         RETURN_MASK_ERROR.
5137
5138 2018-03-26  Tom Tromey  <tom@tromey.com>
5139
5140         * python/py-framefilter.c (enumerate_args): Use
5141         gdb::unique_xmalloc_ptr.
5142
5143 2018-03-26  Tom Tromey  <tom@tromey.com>
5144
5145         * python/py-framefilter.c (py_print_frame): Return
5146         EXT_LANG_BT_OK.
5147         (gdbpy_apply_frame_filter): Update comment.
5148         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
5149         Remove.
5150         <EXT_LANG_BT_NO_FILTERS>: Change value.
5151
5152 2018-03-26  Tom Tromey  <tom@tromey.com>
5153
5154         PR backtrace/15582:
5155         * stack.c (backtrace_command): Parse "hide" argument.
5156         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
5157         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
5158         constant.
5159
5160 2018-03-26  Tom Tromey  <tom@tromey.com>
5161
5162         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
5163         add "flags".
5164         (backtrace_command): Remove "fulltrace", add "flags".
5165
5166 2018-03-26  Tom Tromey  <tom@tromey.com>
5167
5168         * stack.c (backtrace_command): Rewrite command line parsing.
5169
5170 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
5171
5172         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
5173
5174 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
5175
5176         * filename-seen-cache.h: Add include guard.
5177
5178 2018-03-26  Keith Seitz  <keiths@redhat.com>
5179
5180         * symfile.c (place_section): Remove "struct" from section_addr_info
5181         in comment.
5182         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
5183         "struct" keyword from section_addr_info.
5184
5185 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
5186
5187         * regformats/regdef.h (reg): Add constructors.
5188
5189 2018-03-25  Pedro Alves  <palves@redhat.com>
5190
5191         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
5192         if then/else bodies in var_func_name extraction.
5193
5194 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
5195
5196         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
5197         lookup_minimal_symbol() to find symbol entry.
5198         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
5199
5200 2018-03-23  Keith Seitz  <keiths@redhat.com>
5201
5202         PR c++/22968
5203         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
5204         nested type definitions for C++, too.
5205
5206 2018-03-23  Tom Tromey  <tom@tromey.com>
5207
5208         * machoread.c (struct oso_el): Add a constructor.  Don't define as
5209         a typedef.
5210         (macho_register_oso): Remove.
5211         (macho_symtab_read): Take a std::vector.
5212         (oso_el_compare_name): Now a std::sort comparator.
5213         (macho_symfile_read_all_oso): Take a std::vector.
5214         (macho_symfile_read): Use std::vector.  Remove cleanups.
5215
5216 2018-03-22  Tom Tromey  <tom@tromey.com>
5217
5218         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
5219         (record_full_goto_bookmark): Use std::string.
5220
5221 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5222
5223         PR tdep/18295
5224         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
5225         a single mask.
5226
5227 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5228
5229         * rs6000-tdep.c (store_insn_p): New function.
5230         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
5231         and cr_reg to their unshifted values. Use store_insn_p to
5232         match LR saves using either R1 or fdata->alloca_reg. Use
5233         store_insn_p to match CR saves. Set alloca_reg_offset
5234         when alloca_reg and framep are set. Remove lr_reg shift
5235         when assigning to fdata->lr_register.
5236
5237 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5238
5239         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
5240         command line args instead of emitting a warning.
5241
5242 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
5243
5244         * tracepoint.h (struct static_tracepoint_marker): Initialize
5245         fields, define default constructor, move constructor and move
5246         assignment, disable the rest.
5247         <str_id, extra>: Make std::string.
5248         (release_static_tracepoint_marker): Remove.
5249         (free_current_marker): Remove.
5250         * tracepoint.c (free_current_marker): Remove.
5251         (parse_static_tracepoint_marker_definition): Adjust to
5252         std::string, use new hex2str overload.
5253         (release_static_tracepoint_marker): Remove.
5254         (print_one_static_tracepoint_marker): Get marker by reference
5255         and adjust to std::string.
5256         (info_static_tracepoint_markers_command): Adjust to std::vector
5257         changes
5258         * target.h (static_tracepoint_marker_p): Remove typedef.
5259         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
5260         (struct target_ops) <to_static_tracepoint_marker_at>: Return
5261         bool.
5262         <to_static_tracepoint_markers_by_strid>: Return std::vector.
5263         * target-debug.h
5264         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
5265         (target_debug_print_std_vector_static_tracepoint_marker): New.
5266         (target_debug_print_struct_static_tracepoint_marker_p): Rename
5267         to...
5268         (target_debug_print_static_tracepoint_marker_p): ... this.
5269         * target-delegates.c: Re-generate.
5270         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
5271         Make std::string.
5272         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
5273         (decode_static_tracepoint_spec): Adjust to std::vector.
5274         (tracepoint_print_one_detail): Adjust to std::string.
5275         (strace_marker_decode_location): Adjust to std::string.
5276         (update_static_tracepoint): Adjust to std::string, remove call
5277         to release_static_tracepoint_marker.
5278         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
5279         Adjust to std::vector.
5280         * remote.c (remote_static_tracepoint_marker_at): Return bool.
5281         (remote_static_tracepoint_markers_by_strid): Adjust to
5282         std::vector.
5283         * common/rsp-low.h (hex2str): New overload with explicit count
5284         of bytes.
5285         * common/rsp-low.c (hex2str): New overload with explicit count
5286         of bytes.
5287         * unittests/rsp-low-selftests.c (test_hex2str): New function.
5288         (_initialize_rsp_low_selftests): Add test_hex2str test.
5289         * unittests/tracepoint-selftests.c
5290         (test_parse_static_tracepoint_marker_definition): Adjust to
5291         std::string.
5292
5293 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
5294
5295         * tracepoint.c (parse_static_tracepoint_marker_definition):
5296         Consider case where the definition is followed by more
5297         definitions.
5298         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5299         tracepoint-selftests.c.
5300         * unittests/tracepoint-selftests.c: New.
5301
5302 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
5303
5304         * MAINTAINERS (Write After Approval): Add Pedro Franco de
5305         Carvalho.
5306
5307 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
5308
5309         * symtab.c (find_pc_sect_line): fixed indentation.
5310
5311 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
5312
5313         * symtab.c (find_pc_sect_line): now uses binary search.
5314
5315 2018-03-19  Tom Tromey  <tom@tromey.com>
5316
5317         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
5318         "IDENT" production.
5319
5320 2018-03-19  Pedro Alves  <palves@redhat.com>
5321             Tom Tromey  <tom@tromey.com>
5322
5323         * unittests/observable-selftests.c: New file.
5324         * common/observable.h: New file.
5325         * observable.h: New file.
5326         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
5327         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
5328         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
5329         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
5330         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
5331         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
5332         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
5333         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
5334         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
5335         python/py-breakpoint.c, python/py-finishbreakpoint.c,
5336         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
5337         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
5338         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
5339         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
5340         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
5341         tui/tui-interp.c, valops.c: Update all users.
5342         * tui/tui-hooks.c (tui_bp_created_observer)
5343         (tui_bp_deleted_observer, tui_bp_modified_observer)
5344         (tui_inferior_exit_observer, tui_before_prompt_observer)
5345         (tui_normal_stop_observer, tui_register_changed_observer):
5346         Remove.
5347         (tui_observers_token): New global.
5348         (attach_or_detach, tui_attach_detach_observers): New functions.
5349         (tui_install_hooks, tui_remove_hooks): Use
5350         tui_attach_detach_observers.
5351         * record-btrace.c (record_btrace_thread_observer): Remove.
5352         (record_btrace_thread_observer_token): New global.
5353         * observer.sh: Remove.
5354         * observer.c: Rename to observable.c.
5355         * observable.c (namespace gdb_observers): Define new objects.
5356         (observer_debug): Move into gdb_observers namespace.
5357         (struct observer, struct observer_list, xalloc_observer_list_node)
5358         (xfree_observer_list_node, generic_observer_attach)
5359         (generic_observer_detach, generic_observer_notify): Remove.
5360         (_initialize_observer): Update.
5361         Don't include observer.inc.
5362         * Makefile.in (generated_files): Remove observer.h, observer.inc.
5363         (clean mostlyclean): Likewise.
5364         (observer.h, observer.inc): Remove targets.
5365         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
5366         (COMMON_SFILES): Use observable.c, not observer.c.
5367         * .gitignore: Remove observer.h.
5368
5369 2018-03-18  Tom Tromey  <tom@tromey.com>
5370
5371         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
5372         gdb::def_vector.
5373         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
5374
5375 2018-03-17  Tom Tromey  <tom@tromey.com>
5376
5377         * auto-load.c (auto_load_objfile_script_1): Use std::string.
5378
5379 2018-03-17  Tom Tromey  <tom@tromey.com>
5380
5381         * target.c (class scoped_target_fd): New.
5382         (target_fileio_close_cleanup): Remove.
5383         (target_fileio_read_alloc_1): Use scoped_target_fd.
5384
5385 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
5386
5387         * silent-rules.mk: New.
5388         * Makefile.in: Include silent-rules.mk
5389         (srcdir, VPATH, top_srcdir): Move up.
5390         (COMPILE): Add ECHO_CXX.
5391         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
5392         (init.c): Add ECHO_INIT_C.
5393         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
5394         (version.c): Add ECHO_GEN.
5395         (printcmd.o): Add ECHO_CXX.
5396         (target-float.o): Add ECHO_CXX.
5397         (ada-exp.o): Add ECHO_CXX.
5398         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
5399         (insight$(EXEEXT)): Add ECHO_CXXLD.
5400         * gnulib/configure.ac: Add AM_SILENT_RULES.
5401         * gnulib/aclocal.m4: Re-generate.
5402         * gnulib/configure: Re-generate.
5403         * gnulib/import/Makefile.in: Re-generate.
5404
5405 2018-03-16  Tom Tromey  <tom@tromey.com>
5406
5407         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
5408         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
5409         * utils.c (do_free_section_addr_info)
5410         (make_cleanup_free_section_addr_info): Remove.
5411         * symfile.h (struct other_sections): Add constructor.
5412         (struct section_addr_info): Remove.
5413         (section_addr_info): New typedef.
5414         (struct sym_fns) <sym_offsets>: Change type of parameter.
5415         (build_section_addr_info_from_objfile)
5416         (relative_addr_info_to_section_offsets, addr_info_make_relative)
5417         (default_symfile_offsets, symbol_file_add)
5418         (symbol_file_add_from_bfd)
5419         (build_section_addr_info_from_section_table): Update.
5420         (alloc_section_addr_info, free_section_addr_info): Don't declare.
5421         * symfile.c (alloc_section_addr_info): Remove.
5422         (build_section_addr_info_from_section_table): Change return type.
5423         Update.
5424         (build_section_addr_info_from_bfd)
5425         (build_section_addr_info_from_objfile): Likewise.
5426         (free_section_addr_info): Remove.
5427         (relative_addr_info_to_section_offsets): Change type of "addrs".
5428         (addrs_section_compar): Now a std::sort comparator.
5429         (addrs_section_sort): Change return type.
5430         (addr_info_make_relative): Change type of "addrs".  Update.
5431         (default_symfile_offsets, syms_from_objfile_1)
5432         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
5433         (symbol_file_add_separate): Update.
5434         (symbol_file_add): Change type of "addrs".  Update.
5435         (add_symbol_file_command): Update.  Remove cleanups.
5436         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
5437         cleanups.
5438         * symfile-debug.c (debug_sym_offsets): Change type of "info".
5439         * solib.c (solib_read_symbols): Update.
5440         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
5441         * machoread.c (macho_symfile_offsets): Update.
5442         * jit.c (jit_bfd_try_read_symtab): Update.
5443
5444 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
5445
5446         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5447         unittests/utils-selftests.c.
5448         * unittests/utils-selftests.c: New file.
5449
5450 2018-03-14  Tom Tromey  <tom@tromey.com>
5451
5452         PR cli/14977:
5453         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
5454         for NULL.
5455
5456 2018-03-14  Tom Tromey  <tom@tromey.com>
5457
5458         PR cli/19918:
5459         * printcmd.c (printf_pointer): Allow "-" in format.
5460
5461 2018-03-14  Tom Tromey  <tom@tromey.com>
5462
5463         * printcmd.c (_initialize_printcmd): Add usage to printf.
5464
5465 2018-03-14  Yao Qi  <qiyao@sourceware.org>
5466
5467         * MAINTAINERS: Update my email address.
5468
5469 2018-03-13  Tom Tromey  <tom@tromey.com>
5470
5471         * machoread.c (macho_check_dsym): Change filenamep to a
5472         std::string*.
5473         (macho_symfile_read): Update.
5474         * symfile.c (load_command): Use std::string.
5475
5476 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5477
5478         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
5479         to error message string.
5480         (riscv_register_name): Use xsnprintf instead of sprintf.
5481         (riscv_insn::fetch_instruction): Use gdb_assert instead of
5482         internal_error.
5483         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
5484         error.
5485         (riscv_push_dummy_call): Likewise.
5486
5487 2018-03-12  Tom Tromey  <tom@tromey.com>
5488
5489         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
5490         Use gdb::byte_vector.
5491         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
5492
5493 2018-03-12  Yao Qi  <yao.qi@linaro.org>
5494
5495         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
5496         parameter type to readable_regcache.
5497         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
5498         the declaration.
5499
5500 2018-03-11  Tom Tromey  <tom@tromey.com>
5501
5502         * dwarf2read.c (struct nextfield): Add initializers.
5503         (struct nextfnfield): Remove.
5504         (struct fnfieldlist): Add initializers.  Remove "length" and
5505         "head", use std::vector.
5506         (struct decl_field_list): Remove.
5507         (struct field_info): Add initializers.
5508         <fields, baseclasses>: Now std::vector.
5509         <nbaseclasses, nfnfields, typedef_field_list_count,
5510         nested_types_list_count>: Remove.
5511         (dwarf2_add_field, dwarf2_add_type_defn)
5512         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
5513         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
5514         (process_structure_scope): Update.
5515
5516 2018-03-11  Tom Tromey  <tom@tromey.com>
5517
5518         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
5519         for use by std::sort.
5520         (build_type_psymtabs_1): Use std::vector.
5521
5522 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
5523
5524         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
5525         and LIBMPFR in the printed configuration.
5526
5527 2018-03-08  Tom Tromey  <tom@tromey.com>
5528
5529         * source.c (get_filename_and_charpos): Use scoped_fd.
5530         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5531         (procfs_pidlist): Likewise.
5532         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5533         (iterate_over_mappings): Likewise.
5534
5535 2018-03-08  Tom Tromey  <tom@tromey.com>
5536
5537         * infcall.c (struct call_return_meta_info)
5538         <stack_temporaries_enabled>: Remove.
5539         (get_call_return_value, call_function_by_hand_dummy): Update.
5540         * thread.c (disable_thread_stack_temporaries): Remove.
5541         (enable_thread_stack_temporaries): Remove.
5542         (thread_stack_temporaries_enabled_p): Return bool.
5543         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5544         (get_last_thread_stack_temporary): Update.
5545         * eval.c (evaluate_subexp): Update.
5546         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5547         class, not a function.
5548         (value_ptr, value_vec): Remove typedefs.
5549         (class thread_info) <stack_temporaries_enabled>: Now bool.
5550         <stack_temporaries>: Now a std::vector.
5551         (thread_stack_temporaries_enabled_p)
5552         (value_in_thread_stack_temporaries): Return bool.
5553
5554 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5555
5556         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5557         (getpkt_or_notif_sane_1): Likewise.
5558
5559 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5560
5561         * build-id.c (build_id_to_debug_bfd): Use std::string.
5562
5563 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5564
5565         * build-id.c (find_separate_debug_file_by_buildid): Return
5566         std::string.
5567         * build-id.h (find_separate_debug_file_by_buildid): Return
5568         std::string.
5569         * coffread.c (coff_symfile_read): Adjust to std::string.
5570         * elfread.c (elf_symfile_read): Adjust to std::string.
5571         * symfile.c (separate_debug_file_exists): Change parameter to
5572         std::string.
5573         (find_separate_debug_file): Return std::string.
5574         (find_separate_debug_file_by_debuglink): Return std::string.
5575         * symfile.h (find_separate_debug_file_by_debuglink): Return
5576         std::string.
5577
5578 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5579
5580         * common/xml-utils.c (xml_escape_text): Move code to...
5581         (xml_escape_text_append): ... this new function.
5582         * common/xml-utils.h (xml_escape_text_append): New declaration.
5583         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5584         New function.
5585         (_initialize_xml_utils): register test_xml_escape_text_append as
5586         a selftest.
5587
5588 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5589
5590         * defs.h: Remove MAX_REGISTER_SIZE.
5591         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5592         asserts.
5593         * python/py-unwind.c (pyuw_sniffer): Likewise.
5594
5595 2018-03-07  Tom Tromey  <tom@tromey.com>
5596
5597         * linux-tdep.c (linux_info_proc): Update.
5598         * target.h (struct target_ops) <to_fileio_readlink>: Return
5599         optional<string>.
5600         (target_fileio_readlink): Return optional<string>.
5601         * remote.c (remote_hostio_readlink): Return optional<string>.
5602         * inf-child.c (inf_child_fileio_readlink): Return
5603         optional<string>.
5604         * target.c (target_fileio_readlink): Return optional<string>.
5605
5606 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5607
5608         * regcache.c (cooked_read_test): Add riscv to the list of
5609         architectures that have a save_reggroup.
5610
5611 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5612
5613         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5614         value is not a dynamic class object.
5615
5616 2018-03-06  Tom Tromey  <tom@tromey.com>
5617
5618         * rust-exp.y: Formatting fixes.
5619
5620 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5621
5622         * riscv-tdep.c (riscv_register_name): Remove target description
5623         support.
5624         (riscv_gdbarch_init): Remove target description check.
5625
5626 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5627
5628         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5629         comment.
5630         * riscv-tdep.h: Likewise.
5631
5632 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5635         (riscv_pseudo_register_write): Delete.
5636         (riscv_gdbarch_init): Remove all use of pseudo registers.
5637
5638 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5639
5640         * record-btrace.c (btrace_print_lines): Replace cleanup
5641         parameter with RAII equivalents.
5642         (btrace_insn_history): Replace cleanup with RAII equivalents.
5643         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5644         make_cleanup_ui_out_tuple_begin_end): Remove.
5645         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5646         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5647         make_cleanup_ui_out_list_begin_end): Remove.
5648
5649 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5650
5651         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5652         parameter types to std::vector.  Use bool.
5653         (record_btrace_wait): Replace VEC(tp_t) with
5654         std::vector<thread_info *>.
5655         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5656
5657 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5658
5659         * record-btrace.c (record_btrace_disable_callback): Remove.
5660         (struct scoped_btrace_disable): New.
5661         (record_btrace_open): Use scoped_btrace_disable.
5662
5663 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5666         reading values from registers.
5667
5668 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5671         where appropriate.
5672
5673 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5674
5675         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5676         change parameter type.  Use GDB's print functions, and use
5677         core_addr_to_string where appropriate.
5678         (riscv_push_dummy_call): Use core_addr_to_string where
5679         appropriate, update call to riscv_print_arg_location, and reindent
5680         a few lines.
5681         (riscv_return_value): Update call to riscv_print_arg_location.
5682
5683 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5684             Tim Newsome <tim@sifive.com>
5685             Albert Ou <a0u@eecs.berkeley.edu>
5686             Darius Rad <darius@bluespec.com>
5687
5688         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5689         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5690         (ALLDEPFILES): Add riscv-tdep.c
5691         * configure.tgt: Add riscv support.
5692         * riscv-tdep.c: New file.
5693         * riscv-tdep.h: New file.
5694         * NEWS: Mention new target.
5695         * MAINTAINERS: Add entry for riscv.
5696
5697 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5698
5699         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5700         fields within aggregates.
5701
5702 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5703
5704         * record-btrace.c (btrace_print_lines): Change type of flags to
5705         gdb_disassembly_flags.
5706
5707 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5708
5709         * fbsd-nat.c: Include "inf-ptrace.h".
5710         (USE_SIGTRAP_SIGINFO): Conditionally define.
5711         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5712         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5713         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5714         function.
5715         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5716         Likewise.
5717         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5718         Likewise.
5719         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5720         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5721         "supports_stopped_by_hw_breakpoint" target methods.
5722
5723 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5724
5725         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5726         * fbsd-nat.c (debug_fbsd_nat): New variable.
5727         (show_fbsd_nat_debug): New function.
5728         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5729         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5730
5731 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5732
5733         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5734         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5735         prototype.
5736         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5737         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5738         method.
5739
5740 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5741
5742         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5743         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5744
5745 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5746
5747         * charset.c (struct charset_vector): New.
5748         (charsets): Change type to charset_vector.
5749         (find_charset_names): Adjust.
5750         (add_one): Adjust.
5751         (_initialize_charset): Adjust.
5752
5753 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5754
5755         * progspace.h (struct program_space) <deleted_solibs>: Change
5756         type to std::vector<std::string>.
5757         * progspace.c (clear_program_space_solib_cache): Adjust.
5758         * breakpoint.c (print_solib_event): Adjust.
5759         (check_status_catch_solib): Adjust.
5760         * solib.c (update_solib_list): Adjust.
5761         * ui-out.h (class ui_out) <field_string>: New overload.
5762         * ui-out.c (ui_out::field_string): New overload.
5763
5764 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5765
5766         * progspace.h (struct program_space): Add constructor and
5767         destructor, initialize fields.
5768         (add_program_space): Remove.
5769         * progspace.c (add_program_space): Rename to...
5770         (program_space::program_space): ... this.
5771         (release_program_space): Rename to...
5772         (program_space::~program_space): ... this.
5773         (delete_program_space): Use delete to delete program_space.
5774         (initialize_progspace): Use new to allocate program_space.
5775         * inferior.c (add_inferior_with_spaces): Likewise.
5776         (clone_inferior_command): Likewise.
5777         * infrun.c (follow_fork_inferior): Likewise.
5778         (handle_vfork_child_exec_or_exit): Likewise.
5779
5780 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5781
5782         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5783         (delim_string_to_char_ptr_vec): Return std::vector of
5784         gdb::unique_xmalloc_ptr.
5785         (dirnames_to_char_ptr_vec_append): Take std::vector of
5786         gdb::unique_xmalloc_ptr.
5787         (dirnames_to_char_ptr_vec): Return std::vector of
5788         gdb::unique_xmalloc_ptr.
5789         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5790         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5791         (delim_string_to_char_ptr_vec): Return an std::vector of
5792         gdb::unique_xmalloc_ptr, adjust the code.
5793         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5794         gdb::unique_xmalloc_ptr, adjust the code.
5795         (dirnames_to_char_ptr_vec): Return an std::vector of
5796         gdb::unique_xmalloc_ptr, adjust the code.
5797         * auto-load.c (auto_load_safe_path_vec): Change type to
5798         std::vector of gdb::unique_xmalloc_ptr.
5799         (auto_load_expand_dir_vars): Return an std::vector of
5800         gdb::unique_xmalloc_ptr, adjust the code.
5801         (auto_load_safe_path_vec_update): Adjust.
5802         (filename_is_in_auto_load_safe_path_vec): Adjust.
5803         (auto_load_objfile_script_1): Adjust.
5804         * build-id.c (build_id_to_debug_bfd): Adjust.
5805         * linux-thread-db.c (thread_db_load_search): Adjust.
5806         * source.c (add_path): Adjust.
5807         (openp): Adjust.
5808         * symfile.c (find_separate_debug_file): Adjust.
5809         * utils.c (do_free_char_ptr_vec): Remove.
5810         (make_cleanup_free_char_ptr_vec): Remove.
5811
5812 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5813
5814         PR gdb/22907
5815         * common/pathstuff.c: Conditionally include "<windows.h>".
5816
5817 2018-03-01  Georg Sauthoff  <mail@georg.so>
5818
5819         PR gdb/22888
5820         * gcore.in: Quote variables and switch interpreter to bash.
5821
5822 2018-03-01  Tom Tromey  <tom@tromey.com>
5823
5824         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5825         assertion.  Add assertion for discriminant_index.
5826         (quirk_rust_enum): Use correct base type name in univariant case.
5827
5828 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5829
5830         * record.c (get_call_history_modifiers): Return a
5831         record_print_flags.
5832         (cmd_record_call_history): Adjust.
5833         * record-btrace.c (record_btrace_call_history): Adjust.
5834         (record_btrace_call_history_range): Adjust.
5835         (record_btrace_call_history_from): Adjust.
5836         * target-debug.h (target_debug_print_record_print_flags): New.
5837         * target-delegates.c: Re-generate.
5838         * target.c (target_call_history): Change flags type.
5839         (target_call_history_from): Likewise.
5840         (target_call_history_range): Likewise.
5841         * target.h (struct target_ops) <target_call_history>: Likewise.
5842         (target_call_history_from): Likewise.
5843         (target_call_history_range): Likewise.
5844
5845 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5846             Simon Marchi  <simon.marchi@polymtl.ca>
5847
5848         * common/common-utils.c: Include "sys/stat.h".
5849         (is_regular_file): Move here from "source.c"; change return
5850         type to "bool".
5851         * common/common-utils.h (is_regular_file): New prototype.
5852         * common/pathstuff.c (contains_dir_separator): New function.
5853         * common/pathstuff.h (contains_dir_separator): New prototype.
5854         * source.c: Don't include "sys/stat.h".
5855         (is_regular_file): Move to "common/common-utils.c".
5856
5857 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5858
5859         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5860         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5861         * auto-load.c: Include "common/pathstuff.h".
5862         * common/common-def.h (current_directory): Move here.
5863         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5864         function.
5865         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5866         prototype.
5867         * common/pathstuff.c: New file.
5868         * common/pathstuff.h: New file.
5869         * compile/compile.c: Include "common/pathstuff.h".
5870         * defs.h (current_directory): Move to "common/common-defs.h".
5871         * dwarf2read.c: Include "common/pathstuff.h".
5872         * exec.c: Likewise.
5873         * guile/scm-safe-call.c: Likewise.
5874         * linux-thread-db.c: Likewise.
5875         * main.c: Likewise.
5876         * nto-tdep.c: Likewise.
5877         * objfiles.c: Likewise.
5878         * source.c: Likewise.
5879         * symtab.c: Likewise.
5880         * utils.c: Include "common/pathstuff.h".
5881         (gdb_realpath): Move to "common/pathstuff.c".
5882         (gdb_realpath_keepfile): Likewise.
5883         (gdb_abspath): Likewise.
5884         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5885         (gdb_realpath_keepfile): Likewise.
5886         (gdb_abspath): Likewise.
5887
5888 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5889
5890         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5891         wildcard process pid for super_resume for kernels with a
5892         specific bug.
5893
5894 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5895
5896         * compile/compile.c (get_args): Add additional comments
5897         explaining function.
5898
5899 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5900             Tom Tromey  <tom@tromey.com>
5901
5902         * target.h (memory_write_request_s): Remove typedef.  Don't define
5903         VEC.
5904         (target_write_memory_blocks): Change argument to std::vector.
5905         (struct memory_write_request): Add constructor.
5906         * target-memory.c (compare_block_starting_address): Return bool.
5907         Change argument types.
5908         (claim_memory): Change arguments to use std::vector.
5909         (split_regular_and_flash_blocks, blocks_to_erase)
5910         (compute_garbled_blocks): Likewise.
5911         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5912         (target_write_memory_blocks): Change argument to std::vector.
5913         * symfile.c (struct load_section_data): Add constructor and
5914         destructor.  Use std::vector for "requests".
5915         (struct load_progress_data): Add initializers.
5916         (load_section_callback): Update.  Use "new".
5917         (clear_memory_write_data): Remove.
5918         (generic_load): Update.
5919
5920 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5921
5922         * arch/aarch64.h: Use common/tdesc.h.
5923
5924 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5925
5926         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5927         architecture with a 64-bit ABI.
5928
5929 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5930
5931         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5932         ahead of target description loading.
5933
5934 2018-02-26  Tom Tromey  <tom@tromey.com>
5935
5936         * stack.c (backtrace_command_1): Update.
5937         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5938         of "flags".
5939         * python/py-framefilter.c (py_print_frame)
5940         (gdbpy_apply_frame_filter): Change type of "flags".
5941         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5942         of "flags".
5943         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5944         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5945         * extension.h (enum frame_filter_flag): Rename from
5946         frame_filter_flags.
5947         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5948         (apply_ext_lang_frame_filter): Change type of "flags".
5949         * extension.c (apply_ext_lang_frame_filter): Change type of
5950         "flags".
5951         * extension-priv.h (struct extension_language_ops)
5952         <apply_frame_filter>: Change type of "flags".
5953
5954 2018-02-26  Tom Tromey  <tom@tromey.com>
5955
5956         PR python/16497:
5957         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5958         off-by-one in py_end computation.
5959         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5960         PRINT_MORE_FRAMES.
5961         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5962         constant.
5963
5964 2018-02-26  Tom Tromey  <tom@tromey.com>
5965
5966         * dwarf2read.c (struct variant_field): New.
5967         (struct nextfield) <variant>: New field.
5968         (dwarf2_add_field): Handle DW_TAG_variant_part.
5969         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5970         discriminated union.
5971         (read_structure_type): Handle DW_TAG_variant_part.
5972         (handle_struct_member_die): New function, extracted from
5973         process_structure_scope.  Handle DW_TAG_variant.
5974         (process_structure_scope): Handle discriminated unions.  Call
5975         handle_struct_member_die.
5976
5977 2018-02-26  Tom Tromey  <tom@tromey.com>
5978
5979         * rust-lang.h (rust_last_path_segment): Declare.
5980         * rust-lang.c (rust_last_path_segment): Now public.  Change
5981         contract.
5982         (struct disr_info): Remove.
5983         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5984         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5985         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5986         (rust_enum_p, rust_enum_variant): New function.
5987         (rust_underscore_fields): Remove "offset" parameter.
5988         (rust_print_enum): New function.
5989         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5990         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5991         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5992         enums.
5993         (rust_internal_print_type): New function, from rust_print_type.
5994         Remove enum code.
5995         (rust_print_type): Call rust_internal_print_type.
5996         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5997         Update enum handling.
5998         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5999         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
6000         (rust_union_quirks): New functions.
6001         (process_full_comp_unit, process_full_type_unit): Call
6002         rust_union_quirks.
6003         (process_structure_scope): Update rust_unions if necessary.
6004
6005 2018-02-26  Tom Tromey  <tom@tromey.com>
6006
6007         * value.h (value_union_variant): Declare.
6008         * valops.c (value_union_variant): New function.
6009         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
6010         (struct discriminant_info): New.
6011         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
6012         enumerator.
6013         (struct main_type) <flag_discriminated_union>: New field.
6014
6015 2018-02-26  Tom Tromey  <tom@tromey.com>
6016
6017         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6018         unittests/unpack-selftests.c.
6019         * unittests/unpack-selftests.c: New file.
6020         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
6021
6022 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6023
6024         * dwarf2read.c (struct partial_die_info) <read>: New method.
6025         (read_partial_die): Remove the declaration.
6026         (load_partial_dies): Update.
6027         (partial_die_info::partial_die_info):
6028         (read_partial_die): Change it to partial_die_info::read.
6029
6030 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6031
6032         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
6033         (fixup_partial_die): Remove declaration.
6034         (scan_partial_symbols): Update.
6035         (partial_die_parent_scope): Likewise.
6036         (partial_die_full_name): Likewise.
6037         (fixup_partial_die): Change it to partial_die_info::fixup.
6038
6039 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6040
6041         * dwarf2read.c (read_partial_die): Update the declaration.
6042         (load_partial_dies): Caller update.
6043         (read_partial_die): Remove one argument abbrev_len.
6044
6045 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6046
6047         * dwarf2read.c (struct partial_die_info): Add ctor, delete
6048         assignment operator.
6049         (load_partial_dies): Use ctor and copy ctor.
6050         (read_partial_die): Update.
6051         (dwarf2_cu::find_partial_die): Use ctor.
6052
6053 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6054
6055         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
6056         (find_partial_die_in_comp_unit): Change it to
6057         dwarf2_cu::find_partial_die.
6058         (find_partial_die): Update.
6059
6060 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6061
6062         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
6063         is NULL.
6064
6065 2018-02-26  Yao Qi  <yao.qi@linaro.org>
6066
6067         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
6068
6069 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
6070
6071         * arch/amd64.h: Use common/tdesc.h.
6072         * arch/i386.c: Likewise.
6073         * arch/i386.h: Likewise.
6074         * arch/tic6x.c: Likewise.
6075         * arch/tdesc.h: Move file from here...
6076         * common/tdesc.h: ...to here.
6077         * features/aarch64-core.c: Regenerate.
6078         * features/aarch64-fpu.c: Regenerate.
6079         * features/i386/32bit-avx.c: Regenerate.
6080         * features/i386/32bit-avx512.c: Regenerate.
6081         * features/i386/32bit-core.c: Regenerate.
6082         * features/i386/32bit-linux.c: Regenerate.
6083         * features/i386/32bit-mpx.c: Regenerate.
6084         * features/i386/32bit-pkeys.c: Regenerate.
6085         * features/i386/32bit-sse.c: Regenerate.
6086         * features/i386/64bit-avx.c: Regenerate.
6087         * features/i386/64bit-avx512.c: Regenerate.
6088         * features/i386/64bit-core.c: Regenerate.
6089         * features/i386/64bit-linux.c: Regenerate.
6090         * features/i386/64bit-mpx.c: Regenerate.
6091         * features/i386/64bit-pkeys.c: Regenerate.
6092         * features/i386/64bit-segments.c: Regenerate.
6093         * features/i386/64bit-sse.c: Regenerate.
6094         * features/i386/x32-core.c: Regenerate.
6095         * features/tic6x-c6xp.c: Regenerate.
6096         * features/tic6x-core.c: Regenerate.
6097         * features/tic6x-gp.c: Regenerate.
6098         * target-descriptions.c: Use common/tdesc.h.
6099         * target-descriptions.h: Likewise.
6100
6101 2018-02-24  Tom Tromey  <tom@tromey.com>
6102
6103         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
6104         (try_thread_db_load_from_dir, thread_db_load_search): Use
6105         std::string.
6106         (info_auto_load_libthread_db_compare): Return bool.  Change
6107         argument types.
6108         (info_auto_load_libthread_db): Use std::vector, std::string.
6109         Remove cleanups.
6110
6111 2018-02-24  Tom Tromey  <tom@tromey.com>
6112
6113         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
6114         std::string.
6115         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
6116         std::string*.
6117         * gdbarch.c: Rebuild.
6118         * gdbarch.h: Rebuild.
6119         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
6120         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
6121         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
6122         std::string*.
6123
6124 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
6125
6126         * gdbtypes.h (sect_offset): Change type to uint64_t.
6127         (sect_offset_str): New function.
6128         * dwarf2read.c (create_addrmap_from_aranges): Use
6129         sect_offset_str.
6130         (error_check_comp_unit_head): Likewise.
6131         (create_debug_type_hash_table): Likewise.
6132         (read_cutu_die_from_dwo): Likewise.
6133         (init_cutu_and_read_dies): Likewise.
6134         (init_cutu_and_read_dies_no_follow): Likewise.
6135         (process_psymtab_comp_unit_reader): Likewise.
6136         (partial_die_parent_scope): Likewise.
6137         (peek_die_abbrev): Likewise.
6138         (process_queue): Likewise.
6139         (dwarf2_physname): Likewise.
6140         (read_namespace_alias): Likewise.
6141         (read_import_statement): Likewise.
6142         (create_dwo_cu_reader): Likewise.
6143         (create_cus_hash_table): Likewise.
6144         (lookup_dwo_cutu): Likewise.
6145         (inherit_abstract_dies): Likewise.
6146         (read_func_scope): Likewise.
6147         (read_call_site_scope): Likewise.
6148         (dwarf2_add_member_fn): Likewise.
6149         (read_common_block): Likewise.
6150         (read_module_type): Likewise.
6151         (read_typedef): Likewise.
6152         (read_subrange_type): Likewise.
6153         (load_partial_dies): Likewise.
6154         (read_partial_die): Likewise.
6155         (find_partial_die): Likewise.
6156         (read_str_index): Likewise.
6157         (dwarf2_string_attr): Likewise.
6158         (build_error_marker_type): Likewise.
6159         (lookup_die_type): Likewise.
6160         (dump_die_shallow): Likewise.
6161         (follow_die_ref): Likewise.
6162         (dwarf2_fetch_die_loc_sect_off): Likewise.
6163         (dwarf2_fetch_constant_bytes): Likewise.
6164         (follow_die_sig): Likewise.
6165         (get_signatured_type): Likewise.
6166         (get_DW_AT_signature_type): Likewise.
6167         (dwarf2_find_containing_comp_unit): Likewise.
6168         (set_die_type): Likewise.
6169
6170 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
6171
6172         * arch/aarch64.c: Include "common-defs.h".
6173         * arch/amd64.c: Likewise.
6174         * arch/i386.c: Likewise.
6175
6176 2018-02-21  Tom Tromey  <tom@tromey.com>
6177
6178         * value.h: (extract_field_op): Update.
6179         * eval.c (extract_field_op): Return a const char *.
6180         * expression.h (parse_expression_for_completion): Update.
6181         * completer.c (complete_expression): Update.
6182         (add_struct_fields): Make fieldname const.
6183         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
6184         (mark_completion_tag, parse_exp_in_context_1): Update.
6185         (parse_expression_for_completion): Change "name" to
6186         unique_xmalloc_ptr*.
6187
6188 2018-02-21  Tom Tromey  <tom@tromey.com>
6189
6190         * infcall.c (call_function_by_hand_dummy): Use std::vector.
6191
6192 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6193
6194         * avr-tdep.c (avr_read_pc): Change parameter type to
6195         readable_regcache.
6196         * gdbarch.sh (read_pc): Likewise.
6197         * gdbarch.c: Re-generated.
6198         * gdbarch.h: Re-generated.
6199         * hppa-tdep.c (hppa_read_pc): Change parameter type to
6200         readable_regcache.
6201         * ia64-tdep.c (ia64_read_pc): Likewise.
6202         * mips-tdep.c (mips_read_pc): Likewise.
6203         * spu-tdep.c (spu_read_pc): Likewise.
6204
6205 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6206
6207         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
6208         * regcache-dump.c: New file.
6209         * regcache.c: Move register_dump to regcache-dump.c.
6210         (maintenance_print_registers): Likewise.
6211         (maintenance_print_raw_registers): Likewise.
6212         (maintenance_print_cooked_registers): Likewise.
6213         (maintenance_print_register_groups): Likewise.
6214         (maintenance_print_remote_registers): Likewise.
6215         (_initialize_regcache): Likewise.
6216         * regcache.h (register_dump): Moved from regcache.c.
6217
6218 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6219
6220         * regcache.c (regcache::regcache): Update.
6221         (regcache::invalidate): Move it to detached_regcache::invalidate.
6222         (get_thread_arch_aspace_regcache): Update.
6223         (regcache::raw_update): Update.
6224         (regcache::cooked_read): Remove some code.
6225         (regcache::cooked_read_value): Likewise.
6226         (regcache::raw_write): Remove assert on m_readonly_p.
6227         (regcache::raw_supply_integer): Move it to
6228         detached_regcache::raw_supply_integer.
6229         (regcache::raw_supply_zeroed): Likewise.
6230         * regcache.h (detached_regcache) <raw_supply_integer>: New
6231         declaration.
6232         <raw_supply_zeroed, invalidate>: Likewise.
6233         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
6234         <invalidate>: Likewise.
6235         <m_readonly_p>: Removed.
6236
6237 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6238
6239         * infcmd.c (get_return_value): Let stop_regs point to
6240         get_current_regcache.
6241         * regcache.c (regcache::regcache): Remove.
6242         (register_dump_reg_buffer): New class.
6243         (regcache_print): Adjust.
6244         * regcache.h (regcache): Remove constructors.
6245
6246 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6247
6248         * regcache.c (class register_dump): New class.
6249         (register_dump_regcache, register_dump_none): New class.
6250         (register_dump_remote, register_dump_groups): New class.
6251         (regcache_print): Update.
6252         * regcache.h (regcache_dump_what): Move it to regcache.c.
6253         (regcache) <dump>: Remove.
6254
6255 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6256
6257         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
6258          reg_buffer_rw *.
6259         (jit_unwind_reg_set_impl): Call raw_supply.
6260         (jit_frame_sniffer): Use reg_buffer_rw.
6261         * record-full.c (record_full_core_regbuf): Change its type.
6262         (record_full_core_open_1): Use reg_buffer_rw.
6263         (record_full_close): Likewise.
6264         (record_full_core_fetch_registers): Use regcache->raw_supply.
6265         (record_full_core_store_registers): Likewise.
6266         * regcache.c (regcache::get_register_status): Move it to
6267         reg_buffer.
6268         (regcache_raw_set_cached_value): Remove.
6269         (regcache::raw_set_cached_value): Remove.
6270         (regcache::raw_write): Call raw_supply.
6271         (regcache::raw_supply): Move it to reg_buffer_rw.
6272         * regcache.h (regcache_raw_set_cached_value): Remove.
6273         (reg_buffer_rw): New class.
6274
6275 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6276
6277         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
6278         readonly_detached_regcache.
6279         (dummy_frame_prev_register): Use regcache->cooked_read.
6280         * frame.c (frame_save_as_regcache): Change return type.
6281         (frame_pop): Update.
6282         * frame.h (frame_save_as_regcache): Update declaration.
6283         * inferior.h (get_infcall_suspend_state_regcache): Update
6284         declaration.
6285         * infrun.c (infcall_suspend_state) <registers>: use
6286         readonly_detached_regcache.
6287         (save_infcall_suspend_state): Don't use regcache_dup.
6288         (get_infcall_suspend_state_regcache): Change return type.
6289         * linux-fork.c (struct fork_info) <savedregs>: Change to
6290         readonly_detached_regcache.
6291         <pc>: New field.
6292         (fork_save_infrun_state): Don't use regcache_dup.
6293         (info_checkpoints_command): Adjust.
6294         * mi/mi-main.c (register_changed_p): Update declaration.
6295         (mi_cmd_data_list_changed_registers): Use
6296         readonly_detached_regcache.
6297         (register_changed_p): Change parameter type to
6298         readonly_detached_regcache.
6299         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
6300         readonly_detached_regcache.
6301         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
6302         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
6303         New.
6304         (regcache::save): Move it to reg_buffer.
6305         (regcache::restore): Change parameter type.
6306         (regcache_dup): Remove.
6307         * regcache.h (reg_buffer) <save>: New method.
6308         (readonly_detached_regcache): New class.
6309         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
6310         readonly_detached_regcache.
6311         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
6312
6313 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6314
6315         * frame.c (frame_save_as_regcache): Use regcache method save.
6316         (frame_pop): Use regcache method restore.
6317         * infrun.c (restore_infcall_suspend_state): Likewise.
6318         * linux-fork.c (fork_load_infrun_state): Likewise.
6319         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
6320         save.
6321         * regcache.c (regcache_save): Remove.
6322         (regcache::restore): More asserts.
6323         (regcache_cpy): Remove.
6324         * regcache.h (regcache_save): Remove the declaration.
6325         (regcache::restore): Move from private to public.
6326         Remove the friend declaration of regcache_cpy.
6327         (regcache_cpy): Remove declaration.
6328
6329 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6330
6331         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
6332         parameter type to 'readable_regcache *'.
6333         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6334         * arm-tdep.c (arm_neon_quad_read): Likewise.
6335         (arm_pseudo_read): Likewise.
6336         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6337         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6338         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6339         * gdbarch.c: Re-generated.
6340         * gdbarch.h: Re-generated.
6341         * gdbarch.sh (pseudo_register_read): Change parameter type to
6342         'readable_regcache *'.
6343         (pseudo_register_read_value): Likewise.
6344         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
6345         (h8300_pseudo_register_read): Likewise.
6346         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
6347         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6348         (i386_pseudo_register_read_into_value): Likewise.
6349         (i386_pseudo_register_read_value): Likewise.
6350         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
6351         declaration.
6352         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
6353         * m32c-tdep.c (m32c_raw_read): Likewise.
6354         (m32c_read_flg): Likewise.
6355         (m32c_banked_register): Likewise.
6356         (m32c_banked_read): Likewise.
6357         (m32c_sb_read): Likewise.
6358         (m32c_part_read): Likewise.
6359         (m32c_cat_read): Likewise.
6360         (m32c_r3r2r1r0_read): Likewise.
6361         (m32c_pseudo_register_read): Likewise.
6362         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6363         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6364         (mep_pseudo_cr64_read): Likewise.
6365         (mep_pseudo_register_read): Likewise.
6366         * mips-tdep.c (mips_pseudo_register_read): Likewise.
6367         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6368         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6369         * regcache.c (regcache::raw_read): Move it to readable_regcache.
6370         (regcache::cooked_read): Likewise.
6371         (regcache::cooked_read_value): Likewise.
6372         (regcache_cooked_read_signed):
6373         (regcache::cooked_read): Likewise.
6374         * regcache.h (readable_regcache): New class.
6375         (regcache): Inherit readable_regcache.  Move some methods to
6376         readable_regcache.
6377         * rl78-tdep.c (rl78_pseudo_register_read): Change
6378         parameter type to 'readable_regcache *'.
6379         * rs6000-tdep.c (do_regcache_raw_read): Remove.
6380         (e500_pseudo_register_read): Change parameter type to
6381         'readable_regcache *'.
6382         (dfp_pseudo_register_read): Likewise.
6383         (vsx_pseudo_register_read): Likewise.
6384         (efpr_pseudo_register_read): Likewise.
6385         * s390-tdep.c (s390_pseudo_register_read): Likewise.
6386         * sh-tdep.c (sh_pseudo_register_read): Likewise.
6387         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
6388         (sh64_pseudo_register_read): Likewise.
6389         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
6390         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6391         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
6392         (spu_pseudo_register_read): Likewise.
6393         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6394         (xtensa_pseudo_register_read): Likewise.
6395
6396 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6397
6398         * regcache.c (regcache::regcache): Call reg_buffer ctor.
6399         (regcache::arch): Move it to reg_buffer::arch.
6400         (regcache::register_buffer): Likewise.
6401         (regcache::assert_regnum): Likewise.
6402         (regcache::num_raw_registers): Likewise.
6403         * regcache.h (reg_buffer): New class.
6404         (regcache): Inherit reg_buffer.
6405
6406 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
6407
6408         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
6409         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
6410
6411 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
6412
6413         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
6414
6415 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
6416
6417         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
6418         (SFILES): Remove common/*.c files.
6419         (COMMON_OBS): Remove some *.o files built from common/*.c files.
6420         * common/common.host: Add common reference.
6421         * configure.ac: Likewise.
6422         * configure: Regenerate.
6423
6424 2018-02-16  Yao Qi  <yao.qi@linaro.org>
6425
6426         * block.c (block_namespace_info): Inherit allocate_on_obstack.
6427         (block_initialize_namespace): Use new.
6428         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
6429         (dwarf2_free_objfile): Use delete.
6430         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
6431         (copy_type_recursive): Use new.
6432         * gdb_obstack.h (allocate_on_obstack): New.
6433
6434 2018-02-15  Yao Qi  <yao.qi@linaro.org>
6435
6436         PR gdb/22849
6437         * inferior.c (exit_inferior_1): Reset inf->control.
6438
6439 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
6440
6441         * ada-lang.c (ada_to_fixed_value_create): Delete advance
6442         declaration.
6443
6444 2018-02-14  Pedro Alves  <palves@redhat.com>
6445
6446         * frame-unwind.c (frame_unwind_try_unwinder): Always call
6447         frame_cleanup_after_sniffer on exception.
6448
6449 2018-02-14  Tom Tromey  <tom@tromey.com>
6450
6451         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
6452         const.
6453         (solib_bfd_open): Make pathname const.
6454         * solib.c (solib_bfd_open): Make pathname const.
6455         * solib-spu.c (spu_bfd_fopen): Make name const.
6456         (spu_bfd_open): Make pathname const.
6457         * solib-darwin.c (darwin_bfd_open): Make pathname const.
6458         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
6459
6460 2018-02-14  Tom Tromey  <tom@tromey.com>
6461
6462         * symfile.c (symfile_bfd_open): Update.
6463         * source.h (openp, source_full_path_of, find_and_open_source):
6464         Change argument type to unique_xmalloc_ptr.
6465         * source.c (openp): Take a unique_xmalloc_ptr.
6466         (source_full_path_of, find_and_open_source): Likewise.
6467         (open_source_file, symtab_to_fullname): Update.
6468         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
6469         unique_xmalloc_ptr.
6470         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
6471         (exec_file_find): Update.
6472         * psymtab.c (psymtab_to_fullname): Update.
6473         * nto-tdep.h (nto_find_and_open_solib): Update.
6474         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
6475         unique_xmalloc_ptr.
6476         * exec.c (exec_file_attach): Update.
6477         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
6478         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
6479
6480 2018-02-14  Tom Tromey  <tom@tromey.com>
6481
6482         * solib.c: Include source.h.
6483         * nto-tdep.c: Include source.h.
6484         * mi/mi-cmd-env.c: Include source.h.
6485         * infcmd.c: Include source.h.
6486         * exec.c: Include source.h.
6487         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
6488         (add_path, directory_switch, source_path, init_source_path): Move
6489         declarations...
6490         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
6491         (add_path, directory_switch, source_path, init_source_path):
6492         ...here.
6493
6494 2018-02-14  Tom Tromey  <tom@tromey.com>
6495
6496         * solist.h (exec_file_find, solib_find): Return
6497         unique_xmalloc_ptr.
6498         (solib_bfd_fopen): Take a const char *.
6499         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
6500         (exec_file_find, solib_find): Likewise.
6501         (solib_bfd_fopen): Do not take ownership of "pathname".
6502         (solib_bfd_open): Use unique_xmalloc_ptr.
6503         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
6504         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
6505         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
6506         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
6507
6508 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
6509
6510         * ada-lang.c (name_match_type_from_name): Remove reference to
6511         ada_name_for_lookup in function's documentation.
6512         * ada-lang.h (ada_name_for_lookup): Delete declaration.
6513
6514 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6515
6516         * defs.h (enum openp_flags): New enum.
6517         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
6518         Move to enum openp_flags.
6519         (openp_flags): New enum flags.
6520         (openp): Change parameter type to openp_flags.
6521         * source.c (openp): Change parameter type to openp_flags.
6522         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
6523         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
6524
6525 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6526
6527         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6528         per-command.
6529
6530 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6533         into...
6534         (class dwarf2_queue_guard): ...the destructor of this new class.
6535         (dw2_do_instantiate_symtab): Create instance of the new class
6536         dwarf2_queue_guard, remove cleanup.
6537
6538 2018-02-09  Tom Tromey  <tom@tromey.com>
6539
6540         * source.c (find_source_lines): Don't reference past the end of
6541         the vector.
6542
6543 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6544
6545         * remote.c (remote_btrace_maybe_reopen): Change error message.
6546         * btrace.c (btrace_enable): Likewise.
6547         (parse_xml_btrace): Likewise.
6548         (parse_xml_btrace_conf): Likewise.
6549
6550 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6551
6552         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6553         (linux_enable_pt, linux_enable_bts): Call
6554         diagnose_perf_event_open_fail.
6555
6556 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6557
6558         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6559         Remove parameter and change return type.  Update callers.  Move it.
6560         (linux_enable_bts, linux_enable_pt): Improve error message.
6561         (linux_enable_pt): Remove zero buffer size check.
6562         (linux_enable_btrace): Improve error messages.  Remove NULL return
6563         check.
6564
6565 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6566
6567         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6568         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6569         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6570         (linux_supports_pt, linux_supports_btrace): Remove.
6571         (linux_enable_bts): Call cpu_supports_bts.
6572         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6573         * remote.c (remote_supports_btrace): Remove.
6574         (init_remote_ops): Remove remote_supports_btrace.
6575         * target-delegates.c: Regenerated.
6576         * target.c (target_supports_btrace): Remove.
6577         * target.h (target_ops) <to_supports_btrace>: Remove
6578         (target_supports_btrace): Remove.
6579         * x86-linux-nat.c (x86_linux_create_target): Remove
6580         linux_supports_btrace.
6581
6582 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6583
6584         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6585         btrace failed.
6586         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6587         exception and use message in own exception.
6588
6589 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6590
6591         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6592         (perf_event_pt_event_type): Use gdb_file_up.
6593         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6594         scoped_fd, and scoped_mmap.
6595
6596 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6597
6598         * common/scoped_mmap.h: New.
6599         * unittests/scoped_mmap-selftest.c: New.
6600         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6601         unittests/scoped_mmap-selftest.c.
6602
6603 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6604
6605         * common/scoped_fd.h: New.
6606         * unittests/scoped_fd-selftest.c: New.
6607         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6608         unittests/scoped_fd-selftest.c.
6609
6610 2018-02-09  Tom Tromey  <tom@tromey.com>
6611
6612         * auto-load.c (auto_load_section_scripts): Use
6613         gdb::unique_xmalloc_ptr.
6614
6615 2018-02-09  Tom Tromey  <tom@tromey.com>
6616
6617         * auto-load.c (execute_script_contents): Use std::string.
6618
6619 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6620
6621         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6622         Python function, rather than a new command.
6623
6624 2018-02-08  Tom Tromey  <tom@tromey.com>
6625
6626         * solib.c (solib_find_1): Use std::string.
6627         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6628
6629 2018-02-08  Tom Tromey  <tom@tromey.com>
6630
6631         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6632
6633 2018-02-08  Tom Tromey  <tom@tromey.com>
6634
6635         * source.c (find_source_lines): Use gdb::def_vector.
6636
6637 2018-02-08  Tom Tromey  <tom@tromey.com>
6638
6639         * macrocmd.c (struct temporary_macro_definition): New.
6640         (macro_define_command): Use temporary_macro_definition.  Remove
6641         cleanups.
6642         (free_macro_definition_ptr): Remove.
6643
6644 2018-02-08  Tom Tromey  <tom@tromey.com>
6645
6646         * macroexp.c (maybe_expand): Use std::string.
6647
6648 2018-02-08  Tom Tromey  <tom@tromey.com>
6649
6650         * macroexp.c (struct macro_buffer): Add initializers for some
6651         members.
6652         (init_buffer, init_shared_buffer, free_buffer)
6653         (free_buffer_return_text): Remove.
6654         (macro_buffer): New constructors.
6655         (~macro_buffer): New destructor.
6656         (macro_buffer::set_shared): New method.
6657         (macro_buffer::resize_buffer, macro_buffer::appendc)
6658         (macro_buffer::appendmem): Now methods, not free functions.
6659         (set_token, append_tokens_without_splicing, stringify)
6660         (macro_stringify): Update.
6661         (gather_arguments): Change return type.  Remove argc_p argument,
6662         add args_ptr argument.  Use std::vector.
6663         (substitute_args): Remove argc argument.  Accept std::vector.
6664         (expand): Update.  Use std::vector.
6665         (scan, macro_expand, macro_expand_next): Update.
6666
6667 2018-02-08  Tom Tromey  <tom@tromey.com>
6668
6669         * symtab.c (default_collect_symbol_completion_matches_break_on):
6670         Use unique_xmalloc_ptr.
6671         * macroscope.h: (sal_macro_scope, user_macro_scope)
6672         (default_macro_scope): Return unique_xmalloc_ptr.
6673         * macroscope.c (sal_macro_scope, user_macro_scope)
6674         (default_macro_scope): Return unique_xmalloc_ptr.
6675         * macroexp.h (macro_expand, macro_expand_once): Return
6676         unique_xmalloc_ptr.
6677         * macroexp.c (macro_expand, macro_expand_once): Return
6678         unique_xmalloc_ptr.
6679         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6680         (info_macro_command, info_macros_command): Use
6681         unique_xmalloc_ptr.
6682         * compile/compile-c-support.c (write_macro_definitions): Use
6683         unique_xmalloc_ptr.
6684         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6685
6686 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6687
6688         * value.c (value_static_field): Assign field type instead of
6689         containing type when returning an optimized out value.
6690
6691 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6692
6693         * ft32-tdep.c (ft32_read_pc): Remove.
6694         (ft32_write_pc): Remove.
6695         (ft32_gdbarch_init): Update.
6696         * m32r-tdep.c (m32r_read_pc): Remove.
6697         (m32r_gdbarch_init): Update.
6698         * mep-tdep.c (mep_read_pc): Remove.
6699         (mep_gdbarch_init): Update.
6700         * microblaze-tdep.c (microblaze_write_pc): Remove.
6701         (microblaze_gdbarch_init): Update.
6702         * mn10300-tdep.c (mn10300_read_pc): Remove.
6703         (mn10300_write_pc): Remove.
6704         (mn10300_gdbarch_init): Update.
6705         * moxie-tdep.c (moxie_read_pc): Remove.
6706         (moxie_write_pc): Remove.
6707         (moxie_gdbarch_init): Update.
6708
6709 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6710
6711         * expprint.c (print_subexp_standard): Handle
6712         OP_F77_UNDETERMINED_ARGLIST.
6713         (dump_subexp_body_standard): Likewise.
6714
6715 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6716
6717         * target-descriptions.c (tdesc_element_visitor) Add empty
6718         implementations.
6719         (tdesc_type): Move make_gdb_type from here.
6720         (tdesc_type_builtin): Likewise.
6721         (tdesc_type_vector): Likewise.
6722         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6723         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6724         (make_gdb_type_union): Likewise.
6725         (make_gdb_type_flags): Likewise.
6726         (make_gdb_type_enum): Likewise.
6727         (make_gdb_type): New function.
6728         (tdesc_register_type): Use static make_gdb_type.
6729
6730 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6731
6732         * infcmd.c (default_print_one_register_info): Align natural-format
6733         column values consistently one under another.
6734         (pad_to_column): New function.
6735
6736 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6737
6738         * dwarf2read.c (dwarf2_physname): Move commment.
6739
6740 2018-02-01  Leszek Swirski  <leszeks@google.com>
6741
6742         * varobj.c (varobj_formatted_print_options): Allow recursive
6743         pretty printing if pretty printing is enabled.
6744
6745 2018-02-01  Leszek Swirski  <leszeks@google.com>
6746
6747         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6748         names after a structop as a filename.
6749
6750 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6751
6752         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6753         (arm_record_coproc_data_proc): Likewise.
6754
6755 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6756
6757         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6758
6759 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6760
6761         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6762         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6763
6764 2018-01-31  Pedro Alves  <palves@redhat.com>
6765
6766         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6767         * inflow.c (child_terminal_save_inferior): Wrap reference to
6768         tcgetpgrp in HAVE_TERMIOS_H.
6769         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6770         _WIN32.
6771         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6772         always iterate over all inferiors.
6773         (gdbsim_cntrl_c): Adjust.
6774         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6775
6776 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6777
6778         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6779         index type is objfile-owned if the element type is as well.
6780
6781 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6782
6783         GDB 8.1 released.
6784
6785 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6786
6787         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6788         "features/s390x-linux64.c".
6789         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6790         s390_linux32 and s390x_linux64.
6791         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6792         default tdesc.
6793         * s390-tdep.c: Include "features/s390-linux32.c" and
6794         "features/s390x-linux64.c".
6795         (s390_tdesc_valid): Add check for tdesc_has_registers.
6796         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6797         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6798         tdesc_s390x_linux64.
6799         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6800         tdesc_s390x_linux64 to...
6801         * s390-tdep.h: ...here.
6802
6803 2018-01-30  Pedro Alves  <palves@redhat.com>
6804
6805         PR gdb/13211
6806         * config.in, configure: Regenerate.
6807         * configure.ac: Check for getpgid.
6808         * go32-nat.c (go32_pass_ctrlc): New.
6809         (go32_target): Install it.
6810         * inf-child.c (inf_child_target): Install
6811         child_terminal_save_inferior, child_pass_ctrlc and
6812         child_interrupt.
6813         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6814         (inf_ptrace_target): No longer install it.
6815         * infcmd.c (interrupt_target_1): Adjust.
6816         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6817         (child_interrupt): Declare.
6818         (inferior::terminal_state): New.
6819         * inflow.c (struct terminal_info): Update comments.
6820         (inferior_process_group): Delete.
6821         (terminal_is_ours): Delete.
6822         (gdb_tty_state): New.
6823         (child_terminal_init): Adjust.
6824         (is_gdb_terminal, sharing_input_terminal_1)
6825         (sharing_input_terminal): New functions.
6826         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6827         Set the process's actual process group in the foreground if
6828         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6829         mark terminal as the inferior's if not sharing GDB's terminal.
6830         Don't check attach_flag.
6831         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6832         pass down a target_terminal_state.
6833         (child_terminal_save_inferior): New, factored out from ...
6834         (child_terminal_ours_1): ... this.  Handle
6835         target_terminal_state::is_ours_for_output.
6836         (child_interrupt, child_pass_ctrlc): New.
6837         (inflow_inferior_exit): Clear the inferior's terminal_state.
6838         (copy_terminal_info): Copy the inferior's terminal state.
6839         (_initialize_inflow): Remove reference to terminal_is_ours.
6840         * inflow.h (inferior_process_group): Delete.
6841         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6842         * procfs.c (procfs_target): Don't install procfs_interrupt.
6843         (procfs_interrupt): Delete.
6844         * remote.c (remote_serial_quit_handler): Adjust.
6845         (remote_interrupt): Remove ptid parameter.  Adjust.
6846         * target-delegates.c: Regenerate.
6847         * target.c: Include "terminal.h".
6848         (target_terminal::terminal_state): Rename to ...
6849         (target_terminal::m_terminal_state): ... this.
6850         (target_terminal::init): Adjust.
6851         (target_terminal::inferior): Adjust to per-inferior
6852         terminal_state.
6853         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6854         (target_terminal::ours, target_terminal::ours_for_output): Use
6855         target_terminal_is_ours_kind.
6856         (target_interrupt): Remove ptid parameter.  Adjust.
6857         (default_target_pass_ctrlc): Adjust.
6858         * target.h (target_ops::to_terminal_save_inferior): New field.
6859         (target_ops::to_interrupt): Remove ptid_t parameter.
6860         (target_interrupt): Remove ptid_t parameter.  Update comment.
6861         (target_pass_ctrlc): Update comment.
6862         * target/target.h (target_terminal_state): New scoped enum,
6863         factored out of ...
6864         (target_terminal::terminal_state): ... here.
6865         (target_terminal::inferior): Update comments.
6866         (target_terminal::restore_inferior): New.
6867         (target_terminal::is_inferior, target_terminal::is_ours)
6868         (target_terminal::is_ours_for_output): Adjust.
6869         (target_terminal::scoped_restore_terminal_state): Adjust to
6870         rename, and call restore_inferior() instead of inferior().
6871         (target_terminal::scoped_restore_terminal_state::m_state): Change
6872         type.
6873         (target_terminal::terminal_state): Rename to ...
6874         (target_terminal::m_terminal_state): ... this and change type.
6875
6876 2018-01-30  Pedro Alves  <palves@redhat.com>
6877
6878         * linux-nat.c (wait_for_signal): New function.
6879         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6880         directly.
6881         (async_terminal_is_ours)
6882         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6883         (linux_nat_add_target): Don't override
6884         to_terminal_inferior/to_terminal_ours.
6885
6886 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6887
6888         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6889
6890 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6891
6892         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6893         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6894         dwarf2_per_objfile_free here.
6895         (dwarf2_per_objfile_free): Remove.
6896         (_initialize_dwarf2_read): Don't register
6897         dwarf2_per_objfile_free as a registry cleanup.
6898
6899 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6900
6901         Avoid compilation errors in MinGW native builds
6902
6903         The error is triggered by including python-internal.h, and the
6904         error message is:
6905
6906              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6907                       from build-gnulib/import/math.h:27,
6908                       from d:/usr/Python26/include/pyport.h:235,
6909                       from d:/usr/Python26/include/Python.h:58,
6910                       from python/python-internal.h:94,
6911                       from python/py-arch.c:24:
6912              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6913         using ::hypot;
6914                 ^~~~~
6915
6916         This happens because Python headers define 'hypot' to expand t
6917         '_hypot' in the Windows builds.
6918         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6919         'hypoth'.  This avoids a compilation error.
6920
6921 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6922
6923         * MAINTAINERS (Write After Approval): Fix ordering.
6924
6925 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6926
6927         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6928
6929 2018-01-26  Alan Modra  <amodra@gmail.com>
6930
6931         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6932         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6933         Remove nop.  Make const.  Comment.
6934         (powerpc32_plt_stub_so_2): New.
6935         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6936         Correct count.  Update uses.
6937         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6938         Move common code reading PLT entry word.  Correct
6939         powerpc32_plt_stub PLT address calculation.
6940         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6941         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6942         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6943         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6944         (ppc64_standard_linkage8): Likewise.
6945         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6946         Correct insns description.
6947         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6948
6949 2018-01-24  Pedro Alves  <palves@redhat.com>
6950
6951         GCC PR libstdc++/83906
6952         * gdbtypes.c (operator==(const dynamic_prop &,
6953         const dynamic_prop &)): New.
6954         (operator==(const range_bounds &, const range_bounds &)): New.
6955         (check_types_equal): Use them instead of memcmp.
6956         * gdbtypes.h (operator==(const dynamic_prop &,
6957         const dynamic_prop &)): Declare.
6958         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6959         (operator==(const range_bounds &, const range_bounds &)): Declare.
6960         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6961
6962 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6963
6964         * s390-linux-tdep.c (s390_record_address_mask)
6965         (s390_record_calc_disp_common, s390_record_calc_disp)
6966         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6967         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6968         (s390_process_record): Move to s390-tdep.c.
6969         (s390_linux_init_abi_any): Adjust.
6970         * s390-tdep.c (s390_record_address_mask)
6971         (s390_record_calc_disp_common, s390_record_calc_disp)
6972         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6973         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6974         (s390_process_record): Moved from s390-linux-tdep.c
6975         (s390_gdbarch_init): Adjust.
6976
6977 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6978
6979         * s390-linux-nat.c (s390-tdep.h): New include.
6980         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6981         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6982         (ALLDEPFILES): Add s390-tdep.c.
6983         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6984         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6985         * s390-tdep.h: ...this.  New file.
6986         * s390-linux-tdep.c (s390-tdep.h): New include.
6987         (_initialize_s390_tdep): Rename to...
6988         (_initialize_s390_linux_tdep): ...this and adjust.
6989         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6990         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6991         s390-tdep.h.
6992         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6993         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6994         (s390_is_partial_instruction, s390_software_single_step)
6995         (is_non_branch_ril, s390_displaced_step_copy_insn)
6996         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6997         (s390_prologue_data, s390_addr, s390_store, s390_load)
6998         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6999         (s390_register_call_saved, s390_guess_tracepoint_registers)
7000         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
7001         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
7002         (s390_pseudo_register_name, s390_pseudo_register_type)
7003         (s390_pseudo_register_read, s390_pseudo_register_write)
7004         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
7005         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
7006         (s390_addr_bits_remove, s390_address_class_type_flags)
7007         (s390_address_class_type_flags_to_name)
7008         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
7009         (s390_function_arg_float, s390_function_arg_vector)
7010         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
7011         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
7012         (s390_frame_align, s390_register_return_value, s390_return_value)
7013         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
7014         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
7015         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
7016         (s390_trad_frame_prev_register, s390_unwind_cache)
7017         (s390_prologue_frame_unwind_cache)
7018         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
7019         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
7020         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
7021         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
7022         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
7023         (s390_frame_base_address, s390_local_base_address)
7024         (s390_frame_base, s390_gcc_target_options)
7025         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
7026         (s390_validate_reg_range, s390_tdesc_valid)
7027         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
7028         * s390-tdep.c: ...this.  New file.
7029
7030 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7031
7032         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
7033         (s390_process_record, s390_gdbarch_tdep_alloc)
7034         (s390_linux_init_abi_any): Use/set new hook.
7035
7036 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7037
7038         * s390-linux-tdep.c (osabi.h): New include.
7039         (s390_linux_init_abi_31, s390_linux_init_abi_64)
7040         (s390_linux_init_abi_any): New functions.
7041         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
7042
7043 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7044
7045         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
7046         tdesc_has_registers check
7047
7048 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7049
7050         * s390-linux-tdep.c (s390_tdesc_valid): New function.
7051         (s390_validate_reg_range): New macro.
7052         (s390_gdbarch_init): Adjust.
7053
7054 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7055
7056         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
7057         (s390_gdbarch_tdep_alloc): Adjust.
7058         (s390_gdbarch_init): Adjust.
7059
7060 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7061
7062         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
7063         <have_tdb>: Change type to bool.
7064         (s390_gdbarch_tdep_alloc): Adjust.
7065         (s390_gdbarch_init): Adjust.
7066
7067 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7068
7069         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
7070         (gdbarch_tdep) <have_upper, have_vx>: New fields.
7071         (s390_gdbarch_tdep_alloc): New function.
7072         (s390_gdbarch_init): Allocate tdep at start and use its fields
7073         instead of separate variables.
7074
7075 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
7076
7077         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
7078         when looking for cached gdbarch and add comment for remaining.
7079
7080 2018-01-22  Pedro Alves  <palves@redhat.com>
7081             Sergio Durigan Junior  <sergiodj@redhat.com>
7082
7083         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
7084         case.
7085
7086 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
7087
7088         * MAINTAINERS: Update my company e-mail address.
7089
7090 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7091
7092         * regcache.c (cooked_write_test): New function.
7093         (_initialize_regcache): Register the test.
7094
7095 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7096
7097         * ia64-tdep.c (ia64_pseudo_register_read): Call
7098         regcache->cooked_read instead of regcache_cooked_read_unsigned.
7099         * m32c-tdep.c (m32c_cat_read): Likewise.
7100         (m32c_r3r2r1r0_read): Likewise.
7101         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
7102         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
7103
7104 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7105
7106         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
7107         method raw_read instead of regcache_raw_read.
7108         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
7109         * arm-tdep.c (arm_neon_quad_read): Likewise.
7110         * avr-tdep.c (avr_pseudo_register_read): Likewise.
7111         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
7112         * frv-tdep.c (frv_pseudo_register_read): Likewise.
7113         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
7114         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
7115         (i386_pseudo_register_read_into_value): Likewise.
7116         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
7117         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
7118         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
7119         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
7120         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
7121         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
7122         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
7123         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
7124         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
7125
7126 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7127
7128         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
7129         * configure.tgt: Remove target mt.
7130         * mt-tdep.c: Remove.
7131         * regcache.c (cooked_read_test): Remove the check for mt.
7132
7133 2018-01-22  Yao Qi  <yao.qi@linaro.org>
7134
7135         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
7136         instead of gdbarch_pseudo_register_read_value.
7137
7138 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
7139
7140         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
7141         language is Ada.
7142
7143 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
7144
7145         * linespec.c (create_sals_line_offset): Remove code that preserved
7146         the symtab_and_line's line number.
7147
7148 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7149
7150         * varobj.c (varobj_create): Don't set valid_block when creating a
7151         floating varobj.
7152
7153 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7154
7155         * varobj.c (varobj_create): Remove out of date comment.
7156
7157 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         PR mi/20395
7160         * ada-exp.y (write_var_from_sym): Pass extra parameter when
7161         updating innermost block.
7162         * parse.c (innermost_block_tracker::update): Take extra type
7163         parameter, and check types match before updating innermost block.
7164         (write_dollar_variable): Update innermost block for registers.
7165         * parser-defs.h (enum innermost_block_tracker_type): New enum.
7166         (innermost_block_tracker::innermost_block_tracker): Initialise
7167         m_types member.
7168         (innermost_block_tracker::reset): Take type parameter.
7169         (innermost_block_tracker::update): Take type parameter, and pass
7170         type through as needed.
7171         (innermost_block_tracker::m_types): New member.
7172         * varobj.c (varobj_create): Pass type when reseting innermost
7173         block.
7174
7175 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7176
7177         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
7178         * ada-lang.c (resolve_subexp): Likewise.
7179         * breakpoint.c (set_breakpoint_condition) Likewise.
7180         (watch_command_1) Likewise.
7181         * c-exp.y (variable): Likewise.
7182         * d-exp.y (PrimaryExpression): Likewise.
7183         * f-exp.y (variable): Likewise.
7184         * go-exp.y (variable): Likewise.
7185         * m2-exp.y (variable): Likewise.
7186         * objfiles.c (objfile::~objfile): Likewise.
7187         * p-exp.y (variable): Likewise.
7188         * parse.c (innermost_block): Change type.
7189         * parser-defs.h (class innermost_block_tracker): New.
7190         (innermost_block): Change to innermost_block_tracker.
7191         * printcmd.c (display_command): Switch to innermost_block API.
7192         (do_one_display): Likewise.
7193         * rust-exp.y (do_one_display): Likewise.
7194         * symfile.c (clear_symtab_users): Likewise.
7195         * varobj.c (varobj_create): Switch to innermost_block API, replace
7196         use of innermost_block with block stored on varobj object.
7197
7198 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7199
7200         * expression.h (innermost_block): Remove declaration.
7201         * varobj.c: Add 'parser-defs.h' include.
7202
7203 2018-01-19  Tom Tromey  <tom@tromey.com>
7204
7205         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
7206         symbols in the static and global blocks.
7207
7208 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
7209
7210         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
7211         gdb_ptrace.h, and move including gdb_wait.h ...
7212         * nat/linux-ptrace.h: ... to here.
7213
7214 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7215
7216         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
7217         inf_ptrace_detach_success.
7218         (inf_ptrace_detach_success): Add inferior parameter, use it
7219         instead of inferior_ptid, pass it to detach_inferior.
7220         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
7221         parameter.
7222         * inferior.c (detach_inferior): Add overload that takes an
7223         inferior object.
7224         * inferior.h (detach_inferior): Likewise.
7225         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
7226         use inferior_ptid, adjust call to inf_ptrace_detach_success.
7227         * linux-thread-db.c (thread_db_detach): Use inf parameter.
7228
7229 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7230
7231         * target.h (struct target_ops) <to_detach>: Add inferior
7232         parameter.
7233         (target_detach): Likewise.
7234         * target.c (dispose_inferior): Pass inferior down.
7235         (target_detach): Pass inferior down.  Assert that it is equal to
7236         the current inferior.
7237         * aix-thread.c (aix_thread_detach): Pass inferior down.
7238         * corefile.c (core_file_command): Pass current_inferior() down.
7239         * corelow.c (core_detach): Add inferior parameter.
7240         * darwin-nat.c (darwin_detach): Likewise.
7241         * gnu-nat.c (gnu_detach): Likewise.
7242         * inf-ptrace.c (inf_ptrace_detach): Likewise.
7243         * infcmd.c (detach_command): Pass current_inferior() down to
7244         target_detach.
7245         * infrun.c (follow_fork_inferior): Pass parent_inf to
7246         target_detach.
7247         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
7248         target_detach.
7249         * linux-nat.c (linux_nat_detach): Add inferior parameter.
7250         * linux-thread-db.c (thread_db_detach): Likewise.
7251         * nto-procfs.c (procfs_detach): Likewise.
7252         * procfs.c (procfs_detach): Likewise.
7253         * record.c (record_detach): Likewise.
7254         * record.h (struct inferior): Forward-declare.
7255         (record_detach): Add inferior parameter.
7256         * remote-sim.c (gdbsim_detach): Likewise.
7257         * remote.c (remote_detach_1): Likewise.
7258         (remote_detach): Likewise.
7259         (extended_remote_detach): Likewise.
7260         * sol-thread.c (sol_thread_detach): Likewise.
7261         * target-debug.h (target_debug_print_inferior_p): New macro.
7262         * target-delegates.c: Re-generate.
7263         * top.c (kill_or_detach): Pass inferior down to target_detach.
7264         * windows-nat.c (windows_detach): Add inferior parameter.
7265
7266 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
7267
7268         * target.h (struct target_ops) <to_detach>: Remove args
7269         parameter.
7270         (target_detach): Likewise.
7271         * target.c (dispose_inferior): Adjust.
7272         (target_detach): Remove args parameter, adjust.
7273         * aix-thread.c (aix_thread_detach): Adjust.
7274         * corefile.c (core_file_command): Adjust.
7275         * corelow.c (core_detach): Adjust.
7276         * darwin-nat.c (darwin_detach): Adjust.
7277         * gnu-nat.c (gnu_detach): Adjust.
7278         * inf-ptrace.c (inf_ptrace_detach): Adjust.
7279         * infcmd.c (detach_command): Adjust
7280         * infrun.c (follow_fork_inferior): Adjust.
7281         (handle_vfork_child_exec_or_exit): Adjust.
7282         * linux-fork.c (linux_fork_detach): Remove args parameter.
7283         * linux-fork.h (linux_fork_detach): Likewise.
7284         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
7285         * linux-thread-db.c (thread_db_detach): Likewise.
7286         * nto-procfs.c (procfs_detach): Likewise.
7287         * procfs.c (procfs_detach): Likewise.
7288         (do_detach): Remove signo parameter.
7289         * record.c (record_detach): Remove args parameter.
7290         * record.h (record_detach): Likewise.
7291         * remote-sim.c (gdbsim_detach): Likewise.
7292         * remote.c (remote_detach_1): Likewise.
7293         (remote_detach): Likewise.
7294         (extended_remote_detach): Likewise.
7295         * sol-thread.c (sol_thread_detach): Likewise.
7296         * target-delegates.c: Re-generate.
7297         * top.c (struct qt_args) <args>: Remove field.
7298         (kill_or_detach): Don't pass args.
7299         (quit_force): Don't set args.
7300         * windows-nat.c (windows_detach): Remove args parameter.
7301
7302 2018-01-19  Yao Qi  <yao.qi@linaro.org>
7303
7304         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
7305         (arm_linux_init_abi): Install it.
7306
7307 2018-01-19  Yao Qi  <yao.qi@linaro.org>
7308
7309         * osabi.c (gdb_osabi_names): Extend the regexp for
7310         arm-linux-gnueabihf.
7311
7312 2018-01-18  Yao Qi  <yao.qi@linaro.org>
7313
7314         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
7315         m_abbrevs.
7316         (abbrev_table::add_abbrev): Update.
7317         (abbrev_table::lookup_abbrev): Update.
7318
7319 2018-01-18  Yao Qi  <yao.qi@linaro.org>
7320
7321         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
7322
7323 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
7324
7325         * compile/compile.c (compile_to_object): Convert "triplet_rx"
7326         to "std::string".
7327
7328 2018-01-17  Tom Tromey  <tom@tromey.com>
7329
7330         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
7331
7332 2018-01-17  Tom Tromey  <tom@tromey.com>
7333
7334         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
7335         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
7336         (create_array_type_with_stride): Update.
7337         * dwarf2read.c (set_die_type): Update.
7338
7339 2018-01-17  Tom Tromey  <tom@tromey.com>
7340
7341         * dwarf2read.c (delayed_method_info): Remove typedef.
7342         (dwarf2_cu::method_info): Now a std::vector.
7343         (add_to_method_list): Update.
7344         (free_delayed_list): Remove.
7345         (compute_delayed_physnames): Update.
7346         (process_full_comp_unit, process_full_type_unit): Clear the method
7347         list.  Remove cleanups.
7348         (psymtab_include_file_name): Add name_holder parameter.  Use
7349         unique_xmalloc_ptr.
7350         (dwarf_decode_lines): Update.
7351
7352 2018-01-17  Tom Tromey  <tom@tromey.com>
7353             Simon Marchi  <simon.marchi@ericsson.com>
7354
7355         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
7356         (dwarf2_per_objfile::free_cached_comp_units)
7357         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7358         (init_cutu_and_read_dies_no_follow): Update.
7359         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
7360         (dwarf2_cu::~dwarf2_cu): New.
7361         (free_heap_comp_unit, free_stack_comp_unit): Remove.
7362         (age_cached_comp_units, free_one_cached_comp_unit): Update.
7363
7364 2018-01-17  Tom Tromey  <tom@tromey.com>
7365             Simon Marchi  <simon.marchi@ericsson.com>
7366
7367         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
7368         (struct die_reader_specs) <abbrev_table>: New member.
7369         (struct abbrev_table): Add constructor.
7370         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
7371         <abbrev_obstack>: Now an auto_obstack.
7372         (abbrev_table_up): New typedef.
7373         (init_cu_die_reader): Add abbrev_table parameter.
7374         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
7375         Add result_dwo_abbrev_table.
7376         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7377         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
7378         Update.
7379         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
7380         parameter.
7381         (skip_children): Update.
7382         (abbrev_table::alloc_abbrev): Rename from
7383         abbrev_table_alloc_abbrev.
7384         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
7385         (abbrev_table::lookup_abbrev): Rename from
7386         abbrev_table_lookup_abbrev.
7387         (abbrev_table_read_table): Return abbrev_table_up.
7388         (abbrev_table_free, abbrev_table_free_cleanup)
7389         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
7390         (load_partial_dies): Update.
7391
7392 2018-01-17  Tom Tromey  <tom@tromey.com>
7393
7394         * dwarf2read.c (dwarf2_compute_name): Update comment.
7395         (read_func_scope, read_variable): Update.
7396         (new_symbol): Remove.
7397         (new_symbol_full): Rename to new_symbol.
7398
7399 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
7400
7401         PR gdb/16577
7402         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
7403         a warning instead of throwing an error, set section size to 0 and return
7404         NULL.
7405         * gdb_bfd.h (gdb_bfd_map_section): Update description.
7406
7407 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7408
7409         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
7410         std::string.
7411         (linux_ptrace_attach_fail_reason_string): Likewise.
7412         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
7413         Likewise.
7414         (linux_ptrace_attach_fail_reason_string): Likewise.
7415         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
7416
7417 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7418
7419         * linux-nat.c (linux_nat_attach): Remove xstrdup.
7420
7421 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
7422
7423         PR gdb/21559
7424         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
7425         checking for fs_base/gs_base fields in struct user_regs_struct.
7426         * configure: Regenerate.
7427
7428 2018-01-17  Yao Qi  <yao.qi@linaro.org>
7429
7430         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
7431         function.
7432         (aarch64_linux_init_abi): Install it to gdbarch hook
7433         gcc_target_options.
7434
7435 2018-01-15  Pedro Alves  <palves@redhat.com>
7436
7437         * common/signals-state-save-restore.c
7438         (save_original_signals_state): Fix typos.
7439
7440 2017-01-12  Tom Tromey  <tom@tromey.com>
7441             Sergio Durigan Junior  <sergiodj@redhat.com>
7442
7443         * Makefile.in (install-only): Install gdb-add-index.
7444
7445 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
7446
7447         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
7448
7449 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7450
7451         * infrun.c (keep_going_pass_signal): Clear step-over info when
7452         insert_breakpoints fails.
7453
7454 2018-01-11  Pedro Alves  <palves@redhat.com>
7455
7456         PR gdb/22583
7457         * infrun.c (resume): Rename to ...
7458         (resume_1): ... this.
7459         (resume): Reimplement as wrapper around resume_1.
7460
7461 2018-01-11  Pedro Alves  <palves@redhat.com>
7462
7463         PR remote/22597
7464         * remote.c (remote_parse_stop_reply): Default to the last-set
7465         general thread instead of to 'magic_null_ptid'.
7466
7467 2018-01-10  Pedro Alves  <palves@redhat.com>
7468
7469         * language.h (language_get_symbol_name_matcher): Rename ...
7470         (get_symbol_name_matcher): ... this.
7471         * language.c (language_get_symbol_name_matcher): Ditto.
7472         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
7473         callers adjusted.
7474
7475 2018-01-10  Pedro Alves  <palves@redhat.com>
7476
7477         PR gdb/22670
7478         * dwarf2read.c
7479         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
7480         Adjust to use language_get_symbol_name_matcher instead of
7481         language_defn::la_get_symbol_name_matcher.
7482         * language.c (language_get_symbol_name_matcher): If in Ada mode
7483         and the lookup name is a verbatim match, return Ada's matcher.
7484         * language.h (language_get_symbol_name_matcher): Adjust comment.
7485         (ada_lookup_name_info::verbatim_p):: New method.
7486
7487 2018-01-10  Pedro Alves  <palves@redhat.com>
7488
7489         PR gdb/22670
7490         * ada-lang.c (ada_collect_symbol_completion_matches): If the
7491         minsym's language is language_auto or language_cplus, pass down
7492         language_ada instead.
7493         * symtab.c (compare_symbol_name): Don't frob symbol language here.
7494
7495 2018-01-10  Pedro Alves  <palves@redhat.com>
7496
7497         PR gdb/22670
7498         * minsyms.c (linkage_name_str): New function.
7499         (iterate_over_minimal_symbols): Use it.
7500
7501 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7502
7503         * NEWS: Document that 'info proc' now works on FreeBSD.
7504
7505 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7506
7507         * configure.ac: Check for kinfo_getfile in libutil.
7508         * configure: Regenerate.
7509         * config.in: Regenerate.
7510         * fbsd-nat.c: Include "fbsd-tdep.h".
7511         (fbsd_fetch_cmdline): New.
7512         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
7513         rather than calling error.
7514         (fbsd_info_proc): New.
7515         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
7516         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
7517         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
7518
7519 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7520
7521         * fbsd-nat.c (struct free_deleter): Remove.
7522         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
7523
7524 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7525
7526         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7527         NULL for an empty pathname.
7528
7529 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7530
7531         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7532         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7533         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7534         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7535         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7536         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7537         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7538         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7539         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7540         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7541         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7542         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7543         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7544         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7545         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7546
7547 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7548
7549         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7550         (gnu_xfer_auxv): New function.
7551         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7552         TARGET_OBJECT_AUXV.
7553
7554 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7555             Simon Marchi  <simon.marchi@ericsson.com>
7556
7557         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7558         common/selftest.c.
7559         (COMMON_OBS): Remove selftest.o.
7560         * configure.ac: Append selftest-arch.c and common/selftest.c to
7561         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7562         * configure: Re-generated.
7563         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7564         GDB_SELF_TEST.
7565         (maintenance_info_selftests): Likewise.
7566
7567 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7568
7569         * ada-valprint.c (val_print_packed_array_elements): Use
7570         proper number of elements when printing an array indexed
7571         by an enumeration type.
7572
7573 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7574
7575         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7576         (dw2_get_file_names_reader): Adjust.
7577         (lookup_dwo_signatured_type): Adjust.
7578         (lookup_dwp_signatured_type): Adjust.
7579         (lookup_signatured_type): Adjust.
7580         (create_type_unit_group): Adjust.
7581         (get_type_unit_group): Adjust.
7582         (process_psymtab_comp_unit_reader): Adjust.
7583         (build_type_psymtabs_reader): Adjust.
7584         (scan_partial_symbols): Adjust.
7585         (add_partial_symbol): Adjust.
7586         (add_partial_subprogram): Adjust.
7587         (peek_die_abbrev): Adjust.
7588         (fixup_go_packaging): Adjust.
7589         (process_imported_unit_die): Adjust.
7590         (dwarf2_compute_name): Adjust.
7591         (dwarf2_physname): Adjust.
7592         (read_import_statement): Adjust.
7593         (handle_DW_AT_stmt_list): Adjust.
7594         (read_file_scope): Adjust.
7595         (read_func_scope): Adjust.
7596         (read_lexical_block_scope): Adjust.
7597         (read_call_site_scope): Adjust.
7598         (read_variable): Adjust.
7599         (dwarf2_rnglists_process): Adjust.
7600         (dwarf2_ranges_process): Adjust.
7601         (dwarf2_ranges_read): Adjust.
7602         (dwarf2_get_pc_bounds): Adjust.
7603         (dwarf2_record_block_ranges): Adjust.
7604         (dwarf2_add_field): Adjust.
7605         (dwarf2_add_member_fn): Adjust.
7606         (read_structure_type): Adjust.
7607         (process_structure_scope): Adjust.
7608         (read_enumeration_type): Adjust.
7609         (read_array_type): Adjust.
7610         (mark_common_block_symbol_computed): Adjust.
7611         (read_common_block): Adjust.
7612         (read_namespace_type): Adjust.
7613         (read_namespace): Adjust.
7614         (read_module_type): Adjust.
7615         (read_tag_pointer_type): Adjust.
7616         (read_tag_ptr_to_member_type): Adjust.
7617         (read_tag_string_type): Adjust.
7618         (read_subroutine_type): Adjust.
7619         (read_typedef): Adjust.
7620         (read_base_type): Adjust.
7621         (attr_to_dynamic_prop): Adjust.
7622         (read_subrange_type): Adjust.
7623         (read_unspecified_type): Adjust.
7624         (dwarf2_read_abbrevs): Adjust.
7625         (load_partial_dies): Adjust.
7626         (read_partial_die): Adjust.
7627         (find_partial_die): Adjust.
7628         (guess_partial_die_structure_name): Adjust.
7629         (fixup_partial_die): Adjust.
7630         (read_attribute_value): Adjust.
7631         (read_addr_index): Adjust.
7632         (read_addr_index_from_leb128): Adjust.
7633         (read_str_index): Adjust.
7634         (dwarf2_string_attr): Adjust.
7635         (get_debug_line_section): Adjust.
7636         (dwarf_decode_line_header): Adjust.
7637         (lnp_state_machine::check_line_address): Adjust.
7638         (dwarf_decode_lines_1): Adjust.
7639         (dwarf_decode_lines): Adjust.
7640         (dwarf2_start_symtab): Adjust.
7641         (var_decode_location): Adjust.
7642         (new_symbol_full): Adjust.
7643         (dwarf2_const_value_data): Adjust.
7644         (dwarf2_const_value_attr): Adjust.
7645         (dwarf2_const_value): Adjust.
7646         (die_type): Adjust.
7647         (die_containing_type): Adjust.
7648         (build_error_marker_type): Adjust.
7649         (lookup_die_type): Adjust.
7650         (guess_full_die_structure_name): Adjust.
7651         (anonymous_struct_prefix): Adjust.
7652         (determine_prefix): Adjust.
7653         (dwarf2_name): Adjust.
7654         (follow_die_ref_or_sig): Adjust.
7655         (follow_die_offset): Adjust.
7656         (follow_die_ref): Adjust.
7657         (follow_die_sig_1): Adjust.
7658         (follow_die_sig): Adjust.
7659         (get_signatured_type): Adjust.
7660         (get_DW_AT_signature_type): Adjust.
7661         (decode_locdesc): Adjust.
7662         (dwarf_decode_macros): Adjust.
7663         (cu_debug_loc_section): Adjust.
7664         (fill_in_loclist_baton): Adjust.
7665         (dwarf2_symbol_mark_computed): Adjust.
7666         (init_one_comp_unit): Don't assign
7667         dwarf2_cu::dwarf2_per_objfile.
7668         (set_die_type): Adjust.
7669
7670 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7671
7672         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7673         <dwarf2_per_objfile>: New field.
7674         (dwarf2_per_objfile): Remove global.
7675         (get_dwarf2_per_objfile): New function.
7676         (set_dwarf2_per_objfile): New function.
7677         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7678         dwarf2_per_objfile.
7679         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7680         (read_abbrev_offset): Likewise.
7681         (read_indirect_string): Likewise.
7682         (read_indirect_line_string): Likewise.
7683         (read_indirect_string_at_offset): Likewise.
7684         (read_indirect_string_from_dwz): Likewise.
7685         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7686         dwarf2_per_objfile.
7687         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7688         (create_all_comp_units): Change objfile parameter to
7689         dwarf2_per_objfile.
7690         (create_all_type_units): Likewise.
7691         (process_queue): Add dwarf2_per_objfile parameter.
7692         (read_and_check_comp_unit_head): Likewise.
7693         (lookup_dwo_unit_in_dwp): Likewise.
7694         (get_dwp_file): Likewise.
7695         (process_cu_includes): Likewise.
7696         (struct free_dwo_file_cleanup_data): New struct.
7697         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7698         set_dwarf2_per_objfile.
7699         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7700         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7701         context, adjust calls.
7702         (dw2_instantiate_symtab): Likewise.
7703         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7704         (dw2_get_cu): Likewise.
7705         (create_cu_from_index_list): Change objfile parameter to
7706         dwarf2_per_objfile.
7707         (create_cus_from_index_list): Get dwarf2_per_objfile from
7708         context, adjust calls.
7709         (create_cus_from_index): Likewise.
7710         (create_signatured_type_table_from_index): Change objfile
7711         parameter to dwarf2_per_objfile.
7712         (create_signatured_type_table_from_debug_names): Change objfile
7713         parameter to dwarf2_per_objfile.
7714         (create_addrmap_from_index): Likewise.
7715         (create_addrmap_from_aranges): Likewise.
7716         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7717         (dw2_setup): Remove.
7718         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7719         context.
7720         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7721         get_dwarf2_per_objfile.
7722         (dw2_forget_cached_source_info): Likewise.
7723         (dw2_map_symtabs_matching_filename): Likewise.
7724         (struct dw2_symtab_iterator) <index>: Remove.
7725         <dwarf2_per_objfile>: New field.
7726         (dw2_symtab_iter_init): Replace index parameter with
7727         dwarf2_per_objfile.
7728         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7729         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7730         (dw2_print_stats): Likewise.
7731         (dw2_dump): Likewise.
7732         (dw2_expand_symtabs_for_function): Likewise.
7733         (dw2_expand_all_symtabs): Likewise.
7734         (dw2_expand_symtabs_with_fullname): Likewise.
7735         (dw2_expand_marked_cus): Replace index and objfile parameters
7736         with dwarf2_per_objfile.
7737         (dw_expand_symtabs_matching_file_matcher): Add
7738         dwarf2_per_objfile parameter and adjust calls.
7739         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7740         adjust calls.
7741         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7742         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7743         adjust calls.
7744         (create_cus_from_debug_names_list): Replace objfile parameter
7745         with dwarf2_per_objfile and adjust calls.
7746         (create_cus_from_debug_names): Likewise.
7747         (dwarf2_read_debug_names): Likewise.
7748         (mapped_debug_names::namei_to_name): Adjust call.
7749         (dw2_debug_names_iterator::next): Likewise.
7750         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7751         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7752         (dw2_debug_names_dump): Likewise.
7753         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7754         (dw2_debug_names_expand_symtabs_matching): Likewise.
7755         (dwarf2_initialize_objfile): Likewise.
7756         (dwarf2_build_psymtabs): Likewise.
7757         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7758         this_cu.
7759         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7760         (read_and_check_comp_unit_head): Likewise.
7761         (read_abbrev_offset): Likewise.
7762         (create_debug_type_hash_table): Likewise.
7763         (create_debug_types_hash_table): Likewise.
7764         (create_all_type_units): Replace objfile parameter with
7765         dwarf2_per_objfile.
7766         (add_type_unit): Add dwarf2_per_objfile parameter.
7767         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7768         with dwarf2_per_objfile.
7769         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7770         (lookup_dwp_signatured_type): Likewise.
7771         (lookup_signatured_type): Likewise.
7772         (read_cutu_die_from_dwo): Likewise.
7773         (init_tu_and_read_dwo_dies): Likewise.
7774         (init_cutu_and_read_dies): Likewise.
7775         (init_cutu_and_read_dies_no_follow): Likewise.
7776         (allocate_type_unit_groups_table): Add objfile parameter.
7777         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7778         (get_type_unit_group): Likewise.
7779         (process_psymtab_comp_unit): Update call.
7780         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7781         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7782         (print_tu_stats): Likewise.
7783         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7784         in void* parameter.
7785         (build_type_psymtabs): Change objfile parameter to
7786         dwarf2_per_objfile.
7787         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7788         passed in void* parameter.
7789         (process_skeletonless_type_units): Change objfile parameter to
7790         dwarf2_per_objfile.
7791         (set_partial_user): Likewise.
7792         (dwarf2_build_psymtabs_hard): Likewise.
7793         (read_comp_units_from_section): Likewise.
7794         (create_all_comp_units): Likewise.
7795         (scan_partial_symbols): Update calls.
7796         (add_partial_symbol): Likewise.
7797         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7798         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7799         (process_queue): Add dwarf2_per_objfile parameter.
7800         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7801         (compute_compunit_symtab_includes): Likewise.
7802         (process_cu_includes): Add dwarf2_per_objfile parameter.
7803         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7804         (process_full_type_unit): Likewise.
7805         (process_imported_unit_die): Update call.
7806         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7807         (read_file_scope): Likewise.
7808         (allocate_dwo_file_hash_table): Add objfile parameter.
7809         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7810         (create_cus_hash_table): Likewise.
7811         (create_dwp_hash_table): Likewise.
7812         (create_dwo_unit_in_dwp_v1): Likewise.
7813         (create_dwp_v2_section): Likewise.
7814         (create_dwo_unit_in_dwp_v2): Likewise.
7815         (lookup_dwo_unit_in_dwp): Likewise.
7816         (try_open_dwop_file): Likewise.
7817         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7818         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7819         cleanup to include a reference to dwarf2_per_objfile.
7820         (open_dwp_file): Add dwarf2_per_objfile parameter.
7821         (open_and_init_dwp_file): Likewise.
7822         (get_dwp_file): Likewise.
7823         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7824         (queue_and_load_all_dwo_tus): Update call.
7825         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7826         data.
7827         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7828         (dwarf2_ranges_process): Likewise.
7829         (dwarf2_get_pc_bounds): Likewise.
7830         (mark_common_block_symbol_computed): Likewise.
7831         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7832         (dwarf2_read_abbrevs): Update call.
7833         (read_partial_die): Use dwarf2_per_objfile from cu.
7834         (find_partial_die): Likewise.
7835         (fixup_partial_die): Likewise.
7836         (read_attribute_value): Likewise.
7837         (read_indirect_string_at_offset_from): Add objfile parameter.
7838         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7839         parameter.
7840         (read_indirect_string_from_dwz): Add objfile parameter.
7841         (read_indirect_string): Add objfile parameter.
7842         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7843         (read_addr_index): Use dwarf2_per_objfile from cu.
7844         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7845         call dw2_setup.
7846         (read_str_index): Use dwarf2_per_objfile from cu.
7847         (get_debug_line_section): Likewise.
7848         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7849         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7850         (new_symbol_full): Use dwarf2_per_objfile from cu.
7851         (build_error_marker_type): Likewise.
7852         (lookup_die_type): Likewise.
7853         (determine_prefix): Likewise.
7854         (follow_die_offset): Likewise.
7855         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7856         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7857         (dwarf2_fetch_die_type_sect_off): Likewise.
7858         (dwarf2_get_die_type): Likewise.
7859         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7860         (get_signatured_type): Likewise.
7861         (get_DW_AT_signature_type): Likewise.
7862         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7863         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7864         (cu_debug_loc_section): Likewise.
7865         (fill_in_loclist_baton): Likewise.
7866         (dwarf2_symbol_mark_computed): Likewise.
7867         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7868         dwarf2_per_objfile.
7869         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7870         parameter.
7871         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7872         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7873         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7874         (set_die_type): Use dwarf2_free_objfile from cu.
7875         (get_die_type_at_offset): Likewise.
7876         (dwarf2_per_objfile_free): Don't assign global variable.
7877         (debug_names) <constructor>: Add dwarf2_per_objfile
7878         parameter, update m_debugstrlookup construction.
7879         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7880         parameter.
7881         <m_dwarf2_per_objfile>: New field.
7882         <lookup>: Use m_dwarf2_per_objfile.
7883         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7884         (psyms_seen_size): Likewise.
7885         (write_gdbindex): Replace objfile parameter with
7886         dwarf2_per_objfile.
7887         (write_debug_names): Likewise.
7888         (write_psymtabs_to_index): Likewise.
7889         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7890         calls.
7891
7892 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7893
7894         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7895         <dwarf2_per_objfile>: New field.
7896         (struct dwarf2_per_cu_data) <objfile>: Remove.
7897         <dwarf2_per_objfile>: New field.
7898         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7899         of objfile.
7900         (create_signatured_type_table_from_index): Likewise.
7901         (create_debug_type_hash_table): Likewise.
7902         (fill_in_sig_entry_from_dwo_entry): Likewise.
7903         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7904         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7905         objfile.
7906         (create_partial_symtab): Access objfile through
7907         dwarf2_per_objfile.
7908         (process_psymtab_comp_unit_reader): Likewise.
7909         (read_comp_units_from_section): Likewise.
7910         (scan_partial_symbols): Likewise.
7911         (add_partial_symbol): Likewise.
7912         (add_partial_subprogram): Likewise.
7913         (peek_die_abbrev): Likewise.
7914         (fixup_go_packaging): Likewise.
7915         (process_full_comp_unit): Likewise.
7916         (process_full_type_unit): Likewise.
7917         (process_imported_unit_die): Likewise.
7918         (dwarf2_compute_name): Likewise.
7919         (dwarf2_physname): Likewise.
7920         (read_import_statement): Likewise.
7921         (create_cus_hash_table): Assign dwarf2_physname instead of
7922         objfile.
7923         (read_func_scope): Access objfile through dwarf2_per_objfile.
7924         (read_lexical_block_scope): Likewise.
7925         (read_call_site_scope): Likewise.
7926         (read_variable): Likewise.
7927         (dwarf2_rnglists_process): Likewise.
7928         (dwarf2_ranges_process): Likewise.
7929         (dwarf2_ranges_read): Likewise.
7930         (dwarf2_record_block_ranges): Likewise.
7931         (dwarf2_add_field): Likewise.
7932         (dwarf2_add_member_fn): Likewise.
7933         (read_structure_type): Likewise.
7934         (process_structure_scope): Likewise.
7935         (read_enumeration_type): Likewise.
7936         (read_array_type): Likewise.
7937         (read_common_block): Likewise.
7938         (read_namespace_type): Likewise.
7939         (read_namespace): Likewise.
7940         (read_module_type): Likewise.
7941         (read_tag_pointer_type): Likewise.
7942         (read_tag_ptr_to_member_type): Likewise.
7943         (read_tag_string_type): Likewise.
7944         (read_subroutine_type): Likewise.
7945         (read_typedef): Likewise.
7946         (read_base_type): Likewise.
7947         (attr_to_dynamic_prop): Likewise.
7948         (read_subrange_type): Likewise.
7949         (read_unspecified_type): Likewise.
7950         (load_partial_dies): Likewise.
7951         (read_partial_die): Likewise.
7952         (find_partial_die): Likewise.
7953         (guess_partial_die_structure_name): Likewise.
7954         (fixup_partial_die): Likewise.
7955         (read_attribute_value): Likewise.
7956         (read_addr_index_from_leb128): Likewise.
7957         (dwarf2_read_addr_index): Likewise.
7958         (dwarf2_string_attr): Likewise.
7959         (lnp_state_machine::check_line_address): Likewise.
7960         (dwarf_decode_lines_1): Likewise.
7961         (dwarf_decode_lines): Likewise.
7962         (dwarf2_start_symtab): Likewise.
7963         (var_decode_location): Likewise.
7964         (new_symbol_full): Likewise.
7965         (dwarf2_const_value_data): Likewise.
7966         (dwarf2_const_value_attr): Likewise.
7967         (dwarf2_const_value): Likewise.
7968         (die_type): Likewise.
7969         (die_containing_type): Likewise.
7970         (lookup_die_type): Likewise.
7971         (guess_full_die_structure_name): Likewise.
7972         (anonymous_struct_prefix): Likewise.
7973         (dwarf2_name): Likewise.
7974         (follow_die_ref_or_sig): Likewise.
7975         (follow_die_offset): Likewise.
7976         (follow_die_ref): Likewise.
7977         (dwarf2_fetch_die_loc_sect_off): Likewise.
7978         (dwarf2_fetch_constant_bytes): Likewise.
7979         (dwarf2_fetch_die_type_sect_off): Likewise.
7980         (dwarf2_get_die_type): Likewise.
7981         (follow_die_sig): Likewise.
7982         (decode_locdesc): Likewise.
7983         (dwarf2_per_cu_objfile): Likewise.
7984         (dwarf2_per_cu_text_offset): Likewise.
7985         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7986         objfile.
7987         (set_die_type): Access objfile through
7988         dwarf2_per_objfile.
7989
7990 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7991
7992         * valprint.c (converted_character_d): Remove typedef.
7993         (DEF_VEC_O (converted_character_d)): Remove.
7994         (count_next_character): Use std::vector.
7995         (print_converted_chars_to_obstack): Likewise.
7996         (generic_printstr): Likewise.
7997
7998 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7999
8000         * xml-support.h (struct gdb_xml_value): Add constructor.
8001         <value>: Change type to unique_xmalloc_ptr.
8002         (gdb_xml_value_s): Remove typedef.
8003         (DEF_VEC_O (gdb_xml_value_s)): Remove.
8004         (gdb_xml_element_start_handler): Change parameter type to
8005         std::vector.
8006         (xml_find_attribute): Likewise.
8007         * xml-support.c (xml_find_attribute): Change parameter type to
8008         std::vector and adjust.
8009         (gdb_xml_values_cleanup): Remove.
8010         (gdb_xml_parser::start_element): Adjust to std::vector.
8011         (xinclude_start_include): Change paraeter type to std::vector
8012         and adjust.
8013         * btrace.c (check_xml_btrace_version): Likewise.
8014         (parse_xml_btrace_block): Likewise.
8015         (parse_xml_btrace_pt_config_cpu): Likewise.
8016         (parse_xml_btrace_pt): Likewise.
8017         (parse_xml_btrace_conf_bts): Likewise.
8018         (parse_xml_btrace_conf_pt): Likewise.
8019         * memory-map.c (memory_map_start_memory): Likewise.
8020         (memory_map_start_property): Likewise.
8021         * osdata.c (osdata_start_osdata): Likewise.
8022         (osdata_start_item): Likewise.
8023         (osdata_start_column): Likewise.
8024         * remote.c (start_thread): Likewise.
8025         * solib-aix.c (library_list_start_library): Likewise.
8026         (library_list_start_list): Likewise.
8027         * solib-svr4.c (library_list_start_library): Likewise.
8028         (svr4_library_list_start_list): Likewise.
8029         * solib-target.c (library_list_start_segment): Likewise.
8030         (library_list_start_section): Likewise.
8031         (library_list_start_library): Likewise.
8032         (library_list_start_list): Likewise.
8033         * tracepoint.c (traceframe_info_start_memory): Likewise.
8034         (traceframe_info_start_tvar): Likewise.
8035         * xml-syscall.c (syscall_start_syscall): Likewise.
8036         * xml-tdesc.c (tdesc_start_target): Likewise.
8037         (tdesc_start_feature): Likewise.
8038         (tdesc_start_reg): Likewise.
8039         (tdesc_start_union): Likewise.
8040         (tdesc_start_struct): Likewise.
8041         (tdesc_start_flags): Likewise.
8042         (tdesc_start_enum): Likewise.
8043         (tdesc_start_field): Likewise.
8044         (tdesc_start_enum_value): Likewise.
8045         (tdesc_start_vector): Likewise.
8046
8047 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
8048
8049         * extension.h (struct xmethod_worker) <clone>: Remove.
8050         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
8051         Remove.
8052         (python_xmethod_worker::clone): Remove.
8053         * valops.c (find_overload_match): Use std::move instead of
8054         clone.
8055
8056 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
8057
8058         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
8059         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
8060         <free_xmethod_worker_data>: Remove.
8061         <get_matching_xmethod_workers>: Chance VEC to std::vector.
8062         <get_xmethod_arg_types>: Remove.
8063         <get_xmethod_result_type>: Remove.
8064         <invoke_xmethod>: Remove.
8065         * extension.c (new_xmethod_worker): Remove.
8066         (clone_xmethod_worker): Remove.
8067         (get_matching_xmethod_workers): Return void, pass std::vector by
8068         pointer.
8069         (get_xmethod_arg_types): Rename to...
8070         (xmethod_worker::get_arg_types): ... this, and adjust.
8071         (get_xmethod_result_type): Rename to...
8072         (xmethod_worker::get_result_type): ... this, and adjust.
8073         (invoke_xmethod): Remove.
8074         (free_xmethod_worker): Remove.
8075         (free_xmethod_worker_vec): Remove.
8076         * extension.h (enum ext_lang_rc): Move here from
8077         extension-priv.h.
8078         (struct xmethod_worker): Add constructor and destructor.
8079         <data>: Remove.
8080         <value>: Remove.
8081         <invoke, clone, do_get_result_type, do_get_arg_types>: New
8082         virtual pure methods.
8083         <get_arg_types, get_result_type>: New methods.
8084         (xmethod_worker_ptr): Remove typedef.
8085         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
8086         (xmethod_worker_vec): Remove typedef.
8087         (xmethod_worker_up): New typedef.
8088         (invoke_xmethod): Remove.
8089         (clone_xmethod_worker): Remove.
8090         (free_xmethod_worker): Remove.
8091         (free_xmethod_worker_vec): Remove.
8092         (get_xmethod_arg_types): Remove.
8093         (get_xmethod_result_type): Remove.
8094         * valops.c (find_method_list): Use std::vector, don't use
8095         intermediate vector.
8096         (value_find_oload_method_list): Use std::vector.
8097         (find_overload_match): Use std::vector.
8098         (find_oload_champ): Use std::vector.
8099         * value.c (value_free): Use operator delete.
8100         (value_of_xmethod): Rename to...
8101         (value_from_xmethod): ... this.  Don't assign
8102         xmethod_worker::value, take rvalue-reference.
8103         (result_type_of_xmethod): Adjust.
8104         (call_xmethod): Adjust.
8105         * value.h: Include extension.h.
8106         (struct xmethod_worker): Don't forward-declare.
8107         (value_of_xmethod): Rename to...
8108         (value_from_xmethod): ... this, take rvalue-reference.
8109         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
8110         (struct python_xmethod_worker): ... this, add constructor and
8111         destructor.
8112         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
8113         (gdbpy_free_xmethod_worker_data): Rename to...
8114         (python_xmethod_worker::~python_xmethod_worker): ... this and
8115         adjust.
8116         (gdbpy_clone_xmethod_worker_data): Rename to...
8117         (python_xmethod_worker::clone): ... this and adjust.
8118         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
8119         temporary vector.
8120         (gdbpy_get_xmethod_arg_types): Rename to...
8121         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
8122         (gdbpy_get_xmethod_result_type): Rename to...
8123         (python_xmethod_worker::do_get_result_type): ... this and
8124         adjust.
8125         (gdbpy_invoke_xmethod): Rename to...
8126         (python_xmethod_worker::invoke): ... this and adjust.
8127         (new_python_xmethod_worker): Rename to...
8128         (python_xmethod_worker::python_xmethod_worker): ... this and
8129         adjust.
8130         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
8131         Remove.
8132         (gdbpy_free_xmethod_worker_data): Remove.
8133         (gdbpy_get_matching_xmethod_workers): Use std::vector.
8134         (gdbpy_get_xmethod_arg_types): Remove.
8135         (gdbpy_get_xmethod_result_type): Remove.
8136         (gdbpy_invoke_xmethod): Remove.
8137         * python/python.c (python_extension_ops): Remove obsolete
8138         callbacks.
8139
8140 2018-01-05  Pedro Alves  <palves@redhat.com>
8141
8142         PR gdb/18653
8143         * common/signals-state-save-restore.c
8144         (save_original_signals_state): New parameter 'quiet'.  Warn if we
8145         find a custom handler preinstalled, instead of internal erroring.
8146         But only warn if !quiet.
8147         * common/signals-state-save-restore.h
8148         (save_original_signals_state): New parameter 'quiet'.
8149         * main.c (captured_main_1): Move save_original_signals_state call
8150         after option handling, and pass QUIET.
8151
8152 2018-01-05  Pedro Alves  <palves@redhat.com>
8153
8154         * spu-tdep.c (spu_catch_start): Pass
8155         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
8156
8157 2018-01-05  Pedro Alves  <palves@redhat.com>
8158
8159         PR gdb/22670
8160         * ada-lang.c (literal_symbol_name_matcher): New function.
8161         (ada_get_symbol_name_matcher): Use it for
8162         symbol_name_match_type::SEARCH_NAME.
8163         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
8164         it down instead of assuming symbol_name_match_type::FULL.
8165         * block.h (block_lookup_symbol): New parameter 'match_type'.
8166         * c-valprint.c (print_unpacked_pointer): Use
8167         lookup_symbol_search_name instead of lookup_symbol.
8168         * compile/compile-object-load.c (get_out_value_type): Pass down
8169         symbol_name_match_type::SEARCH_NAME.
8170         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
8171         symbol_name_match_type::FULL.
8172         * cp-support.c (cp_get_symbol_name_matcher): Handle
8173         symbol_name_match_type::SEARCH_NAME.
8174         * infrun.c (insert_exception_resume_breakpoint): Use
8175         lookup_symbol_search_name.
8176         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
8177         * psymtab.c (maintenance_check_psymtabs): Use
8178         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
8179         * stack.c (print_frame_args): Use lookup_symbol_search_name and
8180         SYMBOL_SEARCH_NAME.
8181         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
8182         if symbol_name_match_type::SEARCH_NAME.
8183         (lookup_symbol_in_language): Pass down
8184         symbol_name_match_type::FULL.
8185         (lookup_symbol_search_name): New.
8186         (lookup_language_this): Pass down
8187         symbol_name_match_type::SEARCH_NAME.
8188         (lookup_symbol_aux, lookup_local_symbol): New parameter
8189         'match_type'.  Pass it down.
8190         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
8191         (lookup_symbol_search_name): New declaration.
8192         (lookup_symbol_in_block): New 'match_type' parameter.
8193
8194 2018-01-05  Pedro Alves  <palves@redhat.com>
8195
8196         PR gdb/22670
8197         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
8198         ada_lookup_symbol.
8199         (ada_lookup_symbol): Reimplement in terms of
8200         ada_lookup_symbol_list, bits factored out from
8201         ada_lookup_encoded_symbol.
8202
8203 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8204
8205         * ada-exp.y (write_object_renaming): When subscripting an array
8206         using a symbol as the index, pass the block in call to
8207         ada_lookup_encoded_symbol when looking that symbol up.
8208
8209 2018-01-05  Jerome Guitton  <guitton@adacore.com>
8210
8211         * ada-lang.c (ada_array_length): Use ada_index_type instead of
8212         TYPE_INDEX_TYPE.
8213
8214 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8215
8216         * ada-lang.c (ada_to_fixed_value_create): Add handling of
8217         the case where VALUE_LVAL (val0) is not lval_memory.
8218
8219 2018-01-05  Xavier Roirand  <roirand@adacore.com>
8220
8221         * ada-valprint.c (print_optional_low_bound): Handle
8222         character-indexed array printing like boolean-indexed array
8223         printing.
8224
8225 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8226
8227         * NEWS: Create a new section for the next release branch.
8228         Rename the section of the current branch, now that it has
8229         been cut.
8230
8231 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
8232
8233         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
8234         * version.in: Bump version to 8.1.50.DATE-git.
8235
8236 2018-01-03  Xavier Roirand  <roirand@adacore.com>
8237
8238         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
8239         Add field.
8240         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
8241         Add field.
8242         (default_exception_support_info) <catch_handlers_sym>: Add field.
8243         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
8244         (ada_exception_name_addr_1): Add "catch handlers" handling.
8245         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
8246         Update all callers.
8247         (create_excep_cond_exprs) <ex>: Add parameter.
8248         (re_set_exception): Update create_excep_cond_exprs call.
8249         (print_it_exception, print_one_exception, print_mention_exception)
8250         (print_recreate_exception): Add "catch handler" handling.
8251         (allocate_location_catch_handlers, re_set_catch_handlers)
8252         (check_status_catch_handlers, print_it_catch_handlers)
8253         (print_one_catch_handlers, print_mention_catch_handlers)
8254         (print_recreate_catch_handlers): New function.
8255         (catch_handlers_breakpoint_ops): New variable.
8256         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
8257         Add parameter.  Add "catch handler" handling.
8258         (ada_exception_sym_name, ada_exception_breakpoint_ops):
8259         Add "catch handler" handling.
8260         (ada_exception_catchpoint_cond_string): Add "catch handler"
8261         handling.
8262         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
8263         call.
8264         (catch_ada_handlers_command): New function.
8265         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
8266         operations structure.
8267         (_initialize_ada_language): Add "catch handlers" command entry.
8268         * NEWS: Document "catch handlers" feature.
8269
8270 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8271
8272         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
8273         account when creating the array type of the slice.
8274         (ada_value_slice): Likewise.
8275
8276 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8277
8278         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
8279         New enum value.
8280         (create_array_type_with_stride): Add byte_stride_prop parameter.
8281         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
8282         New parameter.  Update all callers in this file.
8283         (array_type_has_dynamic_stride): New function.
8284         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
8285         of arrays with dynamic byte strides.
8286         * dwarf2read.c (read_array_type): Add support for dynamic
8287         DW_AT_byte_stride attributes.
8288
8289 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
8290
8291         * dwarf2read.c (read_unspecified_type): Treat
8292         DW_TAG_enumeration_type DIEs from Ada units as stubs.
8293
8294 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8295
8296         Update copyright year range in all GDB files.
8297
8298 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8299
8300         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
8301         and gdb/testsuite/gdb.base/step-line.c.
8302
8303 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8304
8305         * copyright.py (main): Dump the contents of
8306         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
8307         even if BY_HAND is empty.
8308
8309 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8310
8311         * top.c (print_gdb_version): Update Copyright year in version
8312         message.
8313
8314 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
8315
8316         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
8317
8318 For older changes see ChangeLog-2017.
8319 \f
8320 Local Variables:
8321 mode: change-log
8322 left-margin: 8
8323 fill-column: 74
8324 version-control: never
8325 coding: utf-8
8326 End: