gdb/ChangeLog

   1 2015-01-31  Doug Evans  <xdje42@gmail.com>
   2
   3         * gdbtypes.c (copy_type_recursive): Handle all TYPE_SPECIFIC_FIELD
   4         kinds.
   5
   6 2015-01-31  Gary Benson <gbenson@redhat.com>
   7             Doug Evans  <dje@google.com>
   8
   9         PR cli/9007
  10         PR cli/11920
  11         PR cli/15548
  12         * cli/cli-cmds.c (complete_command): Notify user if max-completions
  13         reached.
  14         * common/common-exceptions.h (enum errors)
  15         <MAX_COMPLETIONS_REACHED_ERROR>: New value.
  16         * completer.h (get_max_completions_reached_message): New declaration.
  17         (max_completions): Likewise.
  18         (completion_tracker_t): New typedef.
  19         (new_completion_tracker): New declaration.
  20         (make_cleanup_free_completion_tracker): Likewise.
  21         (maybe_add_completion_enum): New enum.
  22         (maybe_add_completion): New declaration.
  23         (throw_max_completions_reached_error): Likewise.
  24         * completer.c (max_completions): New global variable.
  25         (new_completion_tracker): New function.
  26         (free_completion_tracker): Likewise.
  27         (make_cleanup_free_completion_tracker): Likewise.
  28         (maybe_add_completions): Likewise.
  29         (throw_max_completions_reached_error): Likewise.
  30         (complete_line): Remove duplicates and limit result to max_completions
  31         entries.
  32         (get_max_completions_reached_message): New function.
  33         (gdb_display_match_list): Handle max_completions.
  34         (_initialize_completer): New declaration and function.
  35         * symtab.c: Include completer.h.
  36         (completion_tracker): New static variable.
  37         (completion_list_add_name): Call maybe_add_completion.
  38         (default_make_symbol_completion_list_break_on_1): Renamed from
  39         default_make_symbol_completion_list_break_on.  Maintain
  40         completion_tracker across calls to completion_list_add_name.
  41         (default_make_symbol_completion_list_break_on): New function.
  42         * top.c (init_main): Set rl_completion_display_matches_hook.
  43         * tui/tui-io.c: Include completer.h.
  44         (tui_old_rl_display_matches_hook): New static global.
  45         (tui_rl_display_match_list): Notify user if max-completions reached.
  46         (tui_setup_io): Save/restore rl_completion_display_matches_hook.
  47         * NEWS (New Options): Mention set/show max-completions.
  48
  49 2015-01-31  Gary Benson  <gbenson@redhat.com>
  50
  51         * symtab.c (struct add_name_data) <code>: New field.
  52         Updated comments.
  53         (add_symtab_completions): New function.
  54         (symtab_expansion_callback): Likewise.
  55         (default_make_symbol_completion_list_break_on): Set datum.code.
  56         Move minimal symbol scan before calling expand_symtabs_matching.
  57         Scan known primary symtabs for externs and statics before calling
  58         expand_symtabs_matching.  Pass symtab_expansion_callback as
  59         expansion_notify argument to expand_symtabs_matching.  Do not scan
  60         primary symtabs for externs and statics after calling
  61         expand_symtabs_matching.
  62
  63 2015-01-31  Gary Benson  <gbenson@redhat.com>
  64
  65         * symfile.h (expand_symtabs_exp_notify_ftype): New typedef.
  66         (struct quick_symbol_functions) <expand_symtabs_matching>:
  67         New argument expansion_notify.  All uses updated.
  68         (expand_symtabs_matching): New argument expansion_notify.
  69         All uses updated.
  70         * symfile-debug.c (debug_qf_expand_symtabs_matching):
  71         Also print expansion notify.
  72         * symtab.c (expand_symtabs_matching_via_partial): Call
  73         expansion_notify whenever a partial symbol table is expanded.
  74         * dwarf2read.c (dw2_expand_symtabs_matching): Call
  75         expansion_notify whenever a symbol table is instantiated.
  76
  77 2015-01-31  Doug Evans  <xdje42@gmail.com>
  78
  79         * cli-out.c: #include completer.h, readline/readline.h.
  80         (cli_mld_crlf, cli_mld_putch, cli_mld_puts): New functions.
  81         (cli_mld_flush, cld_mld_erase_entire_line): Ditto.
  82         (cli_mld_beep, cli_mld_read_key, cli_display_match_list): Ditto.
  83         * cli-out.h (cli_display_match_list): Declare.
  84         * completer.c (MB_INVALIDCH, MB_NULLWCH): New macros.
  85         (ELLIPSIS_LEN): Ditto.
  86         (gdb_get_y_or_n, gdb_display_match_list_pager): New functions.
  87         (gdb_path_isdir, gdb_printable_part, gdb_fnwidth): Ditto.
  88         (gdb_fnprint, gdb_print_filename): Ditto.
  89         (gdb_complete_get_screenwidth, gdb_display_match_list_1): Ditto.
  90         (gdb_display_match_list): Ditto.
  91         * completer.h (mld_crlf_ftype, mld_putch_ftype): New typedefs.
  92         (mld_puts_ftype, mld_flush_ftype, mld_erase_entire_line_ftype): Ditto.
  93         (mld_beep_ftype, mld_read_key_ftype): Ditto.
  94         (match_list_displayer): New struct.
  95         (gdb_display_match_list): Declare.
  96         * top.c (init_main): Set rl_completion_display_matches_hook.
  97         * tui/tui-io.c: #include completer.h.
  98         (printable_part, PUTX, print_filename, get_y_or_n): Delete.
  99         (tui_mld_crlf, tui_mld_putch, tui_mld_puts): New functions.
 100         (tui_mld_flush, tui_mld_erase_entire_line, tui_mld_beep): Ditto.
 101         (tui_mld_getc, tui_mld_read_key): Ditto.
 102         (tui_rl_display_match_list): Rewrite.
 103         (tui_handle_resize_during_io): New arg for_completion.  All callers
 104         updated.
 105
 106 2015-01-31  Doug Evans  <xdje42@gmail.com>
 107
 108         Add symbol lookup cache.
 109         * NEWS: Document new options and commands.
 110         * symtab.c (symbol_cache_key): New static global.
 111         (DEFAULT_SYMBOL_CACHE_SIZE, MAX_SYMBOL_CACHE_SIZE): New macros.
 112         (SYMBOL_LOOKUP_FAILED): New macro.
 113         (symbol_cache_slot_state): New enum.
 114         (block_symbol_cache): New struct.
 115         (symbol_cache): New struct.
 116         (new_symbol_cache_size, symbol_cache_size): New static globals.
 117         (hash_symbol_entry, eq_symbol_entry): New functions.
 118         (symbol_cache_byte_size, resize_symbol_cache): New functions.
 119         (make_symbol_cache, free_symbol_cache): New functions.
 120         (get_symbol_cache, symbol_cache_cleanup): New function.
 121         (set_symbol_cache_size, set_symbol_cache_size_handler): New functions.
 122         (symbol_cache_lookup, symbol_cache_clear_slot): New function.
 123         (symbol_cache_mark_found, symbol_cache_mark_not_found): New functions.
 124         (symbol_cache_flush, symbol_cache_dump): New functions.
 125         (maintenance_print_symbol_cache): New function.
 126         (maintenance_flush_symbol_cache): New function.
 127         (symbol_cache_stats): New function.
 128         (maintenance_print_symbol_cache_statistics): New function.
 129         (symtab_new_objfile_observer): New function.
 130         (symtab_free_objfile_observer): New function.
 131         (lookup_static_symbol, lookup_global_symbol): Use symbol cache.
 132         (_initialize_symtab): Init symbol_cache_key.  New parameter
 133         maint symbol-cache-size.  New maint commands print symbol-cache,
 134         print symbol-cache-statistics, flush-symbol-cache.
 135         Install new_objfile, free_objfile observers.
 136
 137 2015-01-31  Joel Brobecker  <brobecker@adacore.com>
 138
 139         PR symtab/17855
 140         * symfile.c (clear_symtab_users): Move call to breakpoint_re_set
 141         to end.
 142
 143 2015-01-31  Doug Evans  <xdje42@gmail.com>
 144
 145         * NEWS: Mention inlined scripts in .debug_gdb_scripts section.
 146         * auto-load.c: #include ctype.h.
 147         (struct auto_load_pspace_info): Replace member loaded_scripts with
 148         new members loaded_script_files, loaded_script_texts.
 149         (auto_load_pspace_data_cleanup): Update.
 150         (init_loaded_scripts_info): Update.
 151         (get_auto_load_pspace_data_for_loading): Update.
 152         (maybe_add_script_file): Renamed from maybe_add_script.  All callers
 153         updated.
 154         (maybe_add_script_text): New function.
 155         (clear_section_scripts): Update.
 156         (source_script_file, execute_script_contents): New functions.
 157         (source_section_scripts): Add support for
 158         SECTION_SCRIPT_ID_PYTHON_TEXT, SECTION_SCRIPT_ID_GUILE_TEXT.
 159         (print_scripts): New function.
 160         (auto_load_info_scripts): Also print inlined scripts.
 161         (maybe_print_unsupported_script_warning): Renamed from
 162         unsupported_script_warning_print.  All callers updated.
 163         (maybe_print_script_not_found_warning): Renamed from
 164         script_not_found_warning_print.  All callers updated.
 165         * extension-priv.h (struct extension_language_script_ops): New member
 166         objfile_script_executor.
 167         * extension.c (ext_lang_objfile_script_executor): New function.
 168         * extension.h (objfile_script_executor_func): New typedef.
 169         (ext_lang_objfile_script_executor): Declare.
 170         * guile/guile-internal.h (gdbscm_execute_objfile_script): Declare.
 171         * guile/guile.c (guile_extension_script_ops): Update.
 172         * guile/scm-objfile.c (gdbscm_execute_objfile_script): New function.
 173         * python/python.c (python_extension_script_ops): Update.
 174         (gdbpy_execute_objfile_script): New function.
 175
 176 2015-01-31  Eli Zaretskii  <eliz@gnu.org>
 177
 178         * tui/tui-io.c (tui_expand_tabs): New function.
 179         (tui_puts, tui_redisplay_readline): Expand TABs into the
 180         appropriate number of spaces.
 181         * tui/tui-regs.c: Include tui-io.h.
 182         (tui_register_format): Call tui_expand_tabs to expand TABs into
 183         the appropriate number of spaces.
 184         * tui/tui-io.h: Add prototype for tui_expand_tabs.
 185
 186 2015-01-30  Doug Evans  <dje@google.com>
 187
 188         * NEWS: "info source" command now display producer string if present.
 189         * source.c (source_info): Print producer string if present.
 190
 191 2015-01-30  Simon Marchi  <simon.marchi@ericsson.com>
 192
 193         * varobj.c (varobj_delete): Fix comment.
 194
 195 2015-01-30  Simon Marchi  <simon.marchi@ericsson.com>
 196
 197         * varobj.c (create_child): Modify comment.
 198
 199 2015-01-30  Simon Marchi  <simon.marchi@ericsson.com>
 200
 201         * ada-varobj.c (ada_number_of_children): Constify struct varobj *
 202         parameter.
 203         (ada_name_of_variable): Same.
 204         (ada_path_expr_of_child): Same.
 205         (ada_value_of_variable): Same.
 206         (ada_value_is_changeable_p): Same.
 207         (ada_value_has_mutated): Same.
 208         * c-varobj.c (varobj_is_anonymous_child): Same.
 209         (c_is_path_expr_parent): Same.
 210         (c_number_of_children): Same.
 211         (c_name_of_variable): Same.
 212         (c_path_expr_of_child): Same.
 213         (get_type): Same.
 214         (c_value_of_variable): Same.
 215         (cplus_number_of_children): Same.
 216         (cplus_name_of_variable): Same.
 217         (cplus_path_expr_of_child): Same.
 218         (cplus_value_of_variable): Same.
 219         * jv-varobj.c (java_number_of_children): Same.
 220         (java_name_of_variable): Same.
 221         (java_path_expr_of_child): Same.
 222         (java_value_of_variable): Same.
 223         * varobj.c (number_of_children): Same.
 224         (name_of_variable): Same.
 225         (is_root_p): Same.
 226         (varobj_ensure_python_env): Same.
 227         (varobj_get_objname): Same.
 228         (varobj_get_expression): Same.
 229         (varobj_get_display_format): Same.
 230         (varobj_get_display_hint): Same.
 231         (varobj_has_more): Same.
 232         (varobj_get_thread_id): Same.
 233         (varobj_get_frozen): Same.
 234         (dynamic_varobj_has_child_method): Same.
 235         (varobj_get_gdb_type): Same.
 236         (is_path_expr_parent): Same.
 237         (varobj_default_is_path_expr_parent): Same.
 238         (varobj_get_language): Same.
 239         (varobj_get_attributes): Same.
 240         (varobj_is_dynamic_p): Same.
 241         (varobj_get_child_range): Same.
 242         (varobj_value_has_mutated): Same.
 243         (varobj_get_value_type): Same.
 244         (number_of_children): Same.
 245         (name_of_variable): Same.
 246         (check_scope): Same.
 247         (varobj_editable_p): Same.
 248         (varobj_value_is_changeable_p): Same.
 249         (varobj_floating_p): Same.
 250         (varobj_default_value_is_changeable_p): Same.
 251
 252 2015-01-30  Simon Marchi  <simon.marchi@ericsson.com>
 253
 254         * varobj.c (varobj_get_path_expr): Set var->path_expr.
 255         * c-varobj.c (c_path_expr_of_child): Set local var instead of
 256         child->path_expr.
 257         (cplus_path_expr_of_child): Same.
 258
 259 2015-01-30  Simon Marchi  <simon.marchi@ericsson.com>
 260
 261         * mi-cmd-var.c (print_varobj): Free varobj_get_expression
 262         result.
 263         (mi_cmd_var_info_expression): Same.
 264         * varobj.c (varobj_get_expression): Mention in the comment that
 265         the result must by freed by the caller.
 266
 267 2015-01-30  Simon Marchi  <simon.marchi@ericsson.com>
 268
 269         * mi/mi-cmd-var.c (mi_cmd_var_info_type): Free result of
 270         varobj_get_type.
 271         (varobj_update_one): Same.
 272         * varobj.c (update_type_if_necessary): Free curr_type_str and
 273         new_type_str.
 274         (varobj_get_type): Specify in comment that the result needs to be
 275         freed by the caller.
 276
 277 2015-01-29  Doug Evans  <dje@google.com>
 278
 279         PR symtab/17890
 280         * dwarf2read.c (dwarf_decode_line_header): Punt if version > 4.
 281
 282 2015-01-25  Mark Wielaard  <mjw@redhat.com>
 283
 284         * dwarf2read.c (checkproducer): Call producer_is_gcc.
 285         * utils.c (producer_is_gcc_ge_4): Likewise.
 286         (producer_is_gcc): New function.
 287         * utils.h (producer_is_gcc): New declaration.
 288
 289 2015-01-29  Joel Brobecker  <brobecker@adacore.com>
 290
 291         * gdbtypes.h (struct dynamic_prop): New PROP_ADDR_OFFSET enum
 292         kind.
 293         * gdbtypes.c (resolve_dynamic_type_internal): Replace "addr"
 294         parameter by "addr_stack" parameter.
 295         (resolve_dynamic_range): Replace "addr" parameter by
 296         "stack_addr" parameter.  Update function documentation.
 297         Update code accordingly.
 298         (resolve_dynamic_array, resolve_dynamic_union)
 299         (resolve_dynamic_struct, resolve_dynamic_type_internal): Likewise.
 300         (resolve_dynamic_type): Update code, following the changes made
 301         to resolve_dynamic_type_internal's interface.
 302         * dwarf2loc.h (struct property_addr_info): New.
 303         (dwarf2_evaluate_property): Replace "address" parameter
 304         by "addr_stack" parameter.  Adjust function documentation.
 305         (struct dwarf2_offset_baton): New.
 306         (struct dwarf2_property_baton): Update documentation of
 307         field "referenced_type" to be more general. New field
 308         "offset_info" in union data field.
 309         * dwarf2loc.c (dwarf2_evaluate_property): Replace "address"
 310         parameter by "addr_stack" parameter.  Adjust code accordingly.
 311         Add support for PROP_ADDR_OFFSET properties.
 312         * dwarf2read.c (attr_to_dynamic_prop): Add support for
 313         DW_AT_data_member_location attributes as well.  Use case
 314         statements instead of if/else condition.
 315
 316 2015-01-29  Joel Brobecker  <brobecker@adacore.com>
 317
 318         * ada-varobj.c (ada_varobj_get_array_number_of_children):
 319         Return zero if PARENT_VALUE is NULL and parent_type's
 320         range type is dynamic.
 321
 322 2015-01-29  Joel Brobecker  <brobecker@adacore.com>
 323
 324         * gdbtypes.c (is_dynamic_type_internal) <TYPE_CODE_RANGE>: Return
 325         nonzero if the type's subtype is dynamic.
 326         (resolve_dynamic_range): Also resolve the range's subtype.
 327
 328 2015-01-29  Alexander Klimov  <alserkli@inbox.ru>  (tiny patch)
 329
 330         Pushed by Joel Brobecker  <brobecker@adacore.com>.
 331         * symfile.c (unmap_overlay_command): Initialize sec to NULL.
 332
 333 2015-01-27  Doug Evans  <dje@google.com>
 334
 335         * NEWS: Mention gdb.Objfile.username.
 336         * python/py-objfile.c (objfpy_get_username): New function.
 337         (objfile_getset): Add "username".
 338
 339 2015-01-24  Mark Wielaard  <mjw@redhat.com>
 340
 341         * stack.c (return_command): Markup warning message with _.
 342
 343 2015-01-24  Doug Evans  <xdje42@gmail.com>
 344
 345         * gdbtypes.h (TYPE_TYPE_SPECIFIC): Delete.
 346
 347 2015-01-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
 348
 349         Fix 100x slowdown regression on DWZ files.
 350         * dwarf2read.c (struct dwarf2_per_objfile): Add line_header_hash.
 351         (struct line_header): Add offset and offset_in_dwz.
 352         (dwarf_decode_lines): Add parameter decode_mapping to the declaration.
 353         (free_line_header_voidp): New declaration.
 354         (line_header_hash, line_header_hash_voidp, line_header_eq_voidp): New
 355         functions.
 356         (dwarf2_build_include_psymtabs): Update dwarf_decode_lines caller.
 357         (handle_DW_AT_stmt_list): Use line_header_hash.
 358         (free_line_header_voidp): New function.
 359         (dwarf_decode_line_header): Initialize offset and offset_in_dwz.
 360         (dwarf_decode_lines): New parameter decode_mapping, use it.
 361         (dwarf2_free_objfile): Free line_header_hash.
 362
 363 2015-01-23  Simon Marchi  <simon.marchi@ericsson.com>
 364
 365         PR gdb/17416
 366         * valops.c (value_rtti_indirect_type): Catch exception thrown by
 367         value_ind.
 368
 369 2015-01-15  Mark Wielaard  <mjw@redhat.com>
 370
 371         * dwarf2read.c (read_subroutine_type): Set TYPE_NO_RETURN from
 372         DW_AT_noreturn.
 373         * gdbtypes.h (struct func_type): Add is_noreturn field flag. Make
 374         calling_convention an 8 bit bit field.
 375         (TYPE_NO_RETURN): New macro.
 376         * infcmd.c (finish_command): Query if function does not return
 377         normally.
 378         * stack.c (return_command): Likewise.
 379
 380 2015-01-23  Pedro Alves  <palves@redhat.com>
 381
 382         * linux-nat.c (linux_is_async_p): New macro.
 383         (linux_nat_is_async_p):
 384         (linux_nat_terminal_inferior): Check whether the target can async
 385         instead of whether it is already async.
 386         (linux_nat_terminal_ours): Don't check whether the target is
 387         async.
 388         (linux_async_pipe): Use linux_is_async_p.
 389
 390 2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
 391
 392         * NEWS (Changes since GDB 7.9): Add 'thread apply all' option
 393         '-ascending'.
 394         * thread.c (tp_array_compar_ascending, tp_array_compar): New.
 395         (thread_apply_all_command): Parse CMD for tp_array_compar_ascending.
 396         Sort tp_array using tp_array_compar.
 397         (_initialize_thread): Extend thread_apply_all_command help.
 398
 399 2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
 400
 401         * corelow.c (core_open): Call also thread_command.
 402         * gdbthread.h (thread_command): New prototype moved from ...
 403         * thread.c (thread_command): ... here.
 404         (thread_command): Make it global.
 405
 406 2015-01-22  Pedro Alves  <palves@redhat.com>
 407
 408         * configure.ac [*mingw32*]: Check $curses_found instead of
 409         $prefer_curses.
 410         * configure: Regenerate.
 411         * windows-termcap.c: Remove HAVE_CURSES_H, HAVE_NCURSES_H and
 412         HAVE_NCURSES_NCURSES_H checks.
 413
 414 2015-01-22  Eli Zaretskii  <eliz@gnu.org>
 415
 416         * tui/tui.c (tui_enable) [__MINGW32__]: If the call to 'newterm'
 417         fails with the 1st arg NULL, try again with "unknown".  Don't test
 418         the "cup" capability: it isn't supported by the Windows port of
 419         ncurses, but the Windows console driver is still capable of
 420         supporting TUI.
 421
 422 2015-01-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
 423
 424         * compile/compile.c (_initialize_compile): Use -fPIE for compile_args.
 425
 426 2015-01-22  Eli Zaretskii  <eliz@gnu.org>
 427
 428         * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
 429         (ALLDEPFILES): Remove irix5-nat.c.  These two are part of the
 430         reason that "make TAGS" is broken.
 431
 432 2015-01-22  Chen Gang  <gang.chen.5i5j@gmail.com>
 433
 434         * hppa-tdep.c (inst_saves_gr): Fix logical working flow issues
 435         and check additional store instructions.
 436
 437 2015-01-21  Wei-cheng Wang  <cole945@gmail.com>
 438
 439         * MAINTAINERS (Write After Approval): Add "Wei-cheng Wang".
 440
 441 2015-01-21  Wei-cheng Wang  <cole945@gmail.com>
 442
 443         * ppc-linux-tdep.c (ppc_skip_trampoline_code,
 444         ppc_canonicalize_syscall, ppc_linux_syscall_record,
 445         ppc_linux_record_signal, ppc_init_linux_record_tdep): Add comments.
 446         * ppc64-tdep.c (ppc64_skip_trampoline_code): Likewise.
 447         * rs6000-tdep.c (rs6000_epilogue_frame_cache,
 448         rs6000_epilogue_frame_this_id, rs6000_epilogue_frame_prev_register,
 449         rs6000_epilogue_frame_sniffer, ppc_record_vsr, ppc_process_record_op4,
 450         ppc_process_record_op19, ppc_process_record_op31,
 451         ppc_process_record_op59, ppc_process_record_op60,
 452         ppc_process_record_op63): Likewise.
 453
 454 2015-01-20  Joel Brobecker  <brobecker@adacore.com>
 455
 456         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason_string)
 457         (linux_ptrace_test_ret_to_nx): Use safe_strerror instead of
 458         strerror.
 459
 460 2015-01-20  Wei-cheng Wang  <cole945@gmail.com>
 461
 462         * rs6000-tdep.c (ppc_process_record_op4, ppc_process_record_op19,
 463         ppc_process_record_op31, ppc_process_record_op59,
 464         ppc_process_record_op60, ppc_process_record_op63,
 465         ppc_process_record): Fix -Wformat warning.
 466         * rs6000-tdep.c (rs6000_epilogue_frame_cache, ppc_process_record_op60):
 467         Remove unused variables.
 468
 469 2015-01-20  Chen Gang  <gang.chen.5i5j@gmail.com>
 470
 471         * MAINTAINERS (Write After Approval): Add "Chen Gang".
 472
 473 2015-01-19  Eli Zaretskii  <eliz@gnu.org>
 474
 475         * configure.ac [*mingw32*]: Only add windows-termcap.o to
 476         CONFIG_OBS if not building with a curses library.
 477         * configure: Regenerate.
 478
 479         * windows-termcap.c: Include defs.h.  Make the whole body empty if
 480         either one of HAVE_CURSES_H or HAVE_NCURSES_H or
 481         HAVE_NCURSES_NCURSES_H is defined.
 482
 483 2015-01-19  Joel Brobecker  <brobecker@adacore.com>
 484
 485         * rs6000-tdep.c (rs6000_gdbarch_init): Move divide operator
 486         from end of line to start of next line.
 487
 488 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
 489
 490         * ppc-linux-tdep.c (ppc_skip_trampoline_code):
 491         Scan PLT stub backward for reverse debugging.
 492         * ppc64-tdep.c (ppc64_skip_trampoline_code): Likewise.
 493
 494 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
 495             Ulrich Weigand  <uweigand@de.ibm.com>
 496
 497         * configure.tgt (powerpc*-*-linux): Add linux-record.o to
 498         gdb_target_obs.
 499         (ppc_linux_record_tdep, ppc64_linux_record_tdep): New for linux syscall
 500         record.
 501         (ppc_canonicalize_syscall, ppc_linux_syscall_record,
 502         ppc_linux_record_signal, ppc_init_linux_record_tdep): New functions.
 503         (ppc_linux_init_abi): Set process_record, process_record_signal.
 504         * ppc-tdep.h (struct gdbarch_tdep): Add ppc_syscall_record and
 505         ppc_linux_record_tdep to gdbarch_tdep.
 506         (ppc_process_record): New declaration.
 507         * rs6000-tdep.c (ppc_record_vsr, ppc_process_record_op4,
 508         ppc_process_record_op19, ppc_process_record_op31,
 509         ppc_process_record_op59, ppc_process_record_op60,
 510         ppc_process_record_op63, ppc_process_record): New functions.
 511
 512 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
 513
 514         * rs6000-tdep.c (rs6000_in_function_epilogue_p): Rename to
 515         rs6000_in_function_epilogue_frame_p and add an argument
 516         for frame_info.
 517         (rs6000_epilogue_frame_cache, rs6000_epilogue_frame_this_id,
 518         rs6000_epilogue_frame_prev_register, rs6000_epilogue_frame_sniffer):
 519         New functions.
 520         (rs6000_epilogue_frame_unwind): New.
 521         (rs6000_gdbarch_init): Append epilogue unwinder.
 522
 523 2015-01-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 524
 525         * nat/linux-personality.c: Replace "#ifndef
 526         HAVE_DECL_ADDR_NO_RANDOMIZE" by "#if
 527         !HAVE_DECL_ADDR_NO_RANDOMIZE", fixing a regression in RHEL-5
 528         systems.
 529
 530 2015-01-16  Eli Zaretskii  <eliz@gnu.org>
 531
 532         * tui/tui-win.c (tui_rehighlight_all, tui_set_var_cmd): New
 533         functions.
 534         (_initialize_tui_win) <border-kind, border-mode>:
 535         <active-border-mode>: Use tui_set_var_cmd as the "set" function.
 536         (tui_set_tab_width_command): Fix the commentary.
 537
 538         * tui/tui-win.h: Add prototype for tui_rehighlight_all.
 539
 540         * tui/tui-win.c (tui_scroll_left_command, tui_scroll_right_command):
 541         Doc fix.
 542         (tui_set_tab_width_command): Delete and recreate the source and
 543         the disassembly windows, to show the effect of the changed tab
 544         size immediately.
 545
 546         * tui/tui-data.h (LINE_PREFIX): Make shorter
 547         (MAX_PID_WIDTH): Enlarge from 14 to 19, to leave enough space for
 548         "Thread NNNNN.XXXX" thread ID notation on Windows.
 549
 550 2015-01-16  Jan Kratochvil  <jan.kratochvil@redhat.com>
 551
 552         Fix gcc-5 compilation.
 553         * hppa-tdep.c (inst_saves_gr): Fix parentheses typo.
 554
 555 2015-01-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 556
 557         * Makefile.in (HFILES_NO_SRCDIR): Add nat/linux-personality.h.
 558         (linux-personality.o): New rule.
 559         * common/common-defs.h: Include <stdint.h>.
 560         * config/aarch64/linux.mh (NATDEPFILES): Include
 561         linux-personality.o.
 562         * config/alpha/alpha-linux.mh (NATDEPFILES): Likewise.
 563         * config/arm/linux.mh (NATDEPFILES): Likewise.
 564         * config/i386/linux64.mh (NATDEPFILES): Likewise.
 565         * config/i386/linux.mh (NATDEPFILES): Likewise.
 566         * config/ia64/linux.mh (NATDEPFILES): Likewise.
 567         * config/m32r/linux.mh (NATDEPFILES): Likewise.
 568         * config/m68k/linux.mh (NATDEPFILES): Likewise.
 569         * config/mips/linux.mh (NATDEPFILES): Likewise.
 570         * config/pa/linux.mh (NATDEPFILES): Likewise.
 571         * config/powerpc/linux.mh (NATDEPFILES): Likewise.
 572         * config/powerpc/ppc64-linux.mh (NATDEPFILES): Likewise.
 573         * config/powerpc/spu-linux.mh (NATDEPFILES): Likewise.
 574         * config/s390/linux.mh (NATDEPFILES): Likewise.
 575         * config/sparc/linux64.mh (NATDEPFILES): Likewise.
 576         * config/sparc/linux.mh (NATDEPFILES): Likewise.
 577         * config/tilegx/linux.mh (NATDEPFILES): Likewise.
 578         * config/xtensa/linux.mh (NATDEPFILES): Likewise.
 579         * defs.h: Remove #include <stdint.h> (moved to
 580         common/common-defs.h).
 581         * linux-nat.c: Include nat/linux-personality.h.  Remove #include
 582         <sys/personality.h>; do not define ADDR_NO_RANDOMIZE (moved to
 583         nat/linux-personality.c).
 584         (linux_nat_create_inferior): Remove code to disable address space
 585         randomization (moved to nat/linux-personality.c).  Create cleanup
 586         to disable address space randomization.
 587         * nat/linux-personality.c: New file.
 588         * nat/linux-personality.h: Likewise.
 589
 590 2015-01-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 591
 592         * Makefile.in (ALLDEPFILES): Including common/mingw-strerror.c and
 593         common/posix-strerror.c.
 594         (posix-strerror.o): New rule.
 595         (mingw-strerror.o): Likewise.
 596         * common/common-utils.h (safe_strerror): Move prototype to here,
 597         from utils.h.
 598         * common/common.host: New file.
 599         * common/mingw-strerror.c: Likewise.
 600         * common/posix-strerror.c: Likewise.
 601         * configure: Regenerated.
 602         * configure.ac: Source common/common.host.  Add variable
 603         common_host_obs to gdb_host_obs.
 604         * contrib/ari/gdb_ari.sh: Mention gdb/common/mingw-strerror.c and
 605         gdb/common/posix-strerror.c when warning about the use of
 606         strerror.
 607         * mingw-hdep.c (safe_strerror): Remove definition; move it to
 608         common/mingw-strerror.c.
 609         * posix-hdep.c (safe_strerror): Remove definition; move it to
 610         common/posix-hdep.c.
 611         * utils.h (safe_strerror): Remove prototype; move to
 612         common/common-utils.h.
 613
 614 2015-01-15  Joel Brobecker  <brobecker@adacore.com>
 615
 616         GDB 7.8.2 released.
 617
 618 2015-01-15  Joel Brobecker  <brobecker@adacore.com>
 619
 620         * ada-lang.c (ada_array_bound_from_type): Ignore array's parallel
 621         ___XA type if the array has already been fixed.
 622
 623 2015-01-14  Yao Qi  <yao@codesourcery.com>
 624
 625         * Makefile.in (ppc-linux.o): New rule.
 626         * config/powerpc/ppc64-linux.mh (NATDEPFILES): Add ppc-linux.o.
 627         * configure.ac: AC_CHECK_FUNCS(getauxval).
 628         * config.in: Re-generated.
 629         * configure: Re-generated.
 630         * nat/ppc-linux.h [__powerpc64__] (ppc64_64bit_inferior_p):
 631         Declare.
 632         * nat/ppc-linux.c: New file.
 633         * ppc-linux-nat.c (ppc_linux_target_wordsize) [__powerpc64__]:
 634         Call ppc64_64bit_inferior_p.
 635
 636 2015-01-14  Yao Qi  <yao@codesourcery.com>
 637
 638         * ppc-linux-nat.c (PT_ORIG_R3, PT_TRAP): Move to
 639         nat/ppc-linux.h.
 640         (PPC_FEATURE_CELL, PPC_FEATURE_BOOKE): Likewise.
 641         (PPC_FEATURE_HAS_DFP): Likewise.
 642         (PTRACE_GETVRREGS, PTRACE_SETVRREGS): Likewise.
 643         (PTRACE_GETVSXREGS, PTRACE_SETVSXREGS): Likewise.
 644         (PTRACE_GETEVRREGS, PTRACE_SETEVRREGS): Likewise.
 645         Include "nat/ppc-linux.h".
 646         * nat/ppc-linux.h: New file.
 647         * Makefile.in (HFILES_NO_SRCDIR): Add nat/ppc-linux.h.
 648
 649 2015-01-14  Pedro Alves  <palves@redhat.com>
 650
 651         PR gdb/17525
 652         * breakpoint.c: Include "interps.h".
 653         (bpstat_do_actions_1): Also check whether the interpreter is
 654         async.
 655
 656 2015-01-14  Pedro Alves  <palves@redhat.com>
 657
 658         PR cli/17828
 659         * infrun.c (reinstall_readline_callback_handler_cleanup): Don't
 660         reinstall if the interpreter is sync.
 661
 662 2015-01-13  Doug Evans  <dje@google.com>
 663
 664         * objfiles.c (objfile_filename): New function.
 665         * objfiles.h (objfile_filename): Declare it.
 666         (objfile_name): Add function comment.
 667         * python/py-objfile.c (objfpy_lookup_objfile_by_name): Try both the
 668         bfd file name (which may be realpath'd), and the original name.
 669
 670 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 671
 672         * NEWS: Create a new section for the next release branch.
 673         Rename the section of the current branch, now that it has
 674         been cut.
 675
 676 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 677
 678         GDB 7.9 branch created (92fc2e6978d9a7c8324c7e851dbee59e22ec7a37):
 679         * version.in: Bump version to 7.9.50.DATE-cvs.
 680
 681 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 682
 683         * nat/linux-procfs.c (linux_proc_attach_tgid_threads):
 684         Remove trailing new-line in argument of call to warning.
 685
 686 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 687
 688         * linux-nat.c (attach_proc_task_lwp_callback): Remove trailing
 689         new-line in argument of call to "warning".
 690
 691 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 692
 693         * ada-lang.c (ada_lookup_symbol_nonlocal): If name not found
 694         in static block, then try searching for primitive types.
 695
 696 2015-01-12  Patrick Palka  <patrick@parcs.ath.cx>
 697
 698         * top.h (gdb_add_history): Declare.
 699         * top.c (command_count): New variable.
 700         (gdb_add_history): New function.
 701         (gdb_safe_append_history): New static function.
 702         (quit_force): Call it.
 703         (command_line_input): Use gdb_add_history instead of
 704         add_history.
 705         * event-top.c (command_line_handler): Likewise.
 706
 707 2015-01-12  James Clarke  <jrtc27@jrtc27.com>  (tiny patch)
 708
 709         PR gdb/17046
 710         * darwin-nat.c: Replace <machine/setjmp.h> #include by
 711         <setjmp.h> #include.
 712
 713 2015-01-11  Doug Evans  <xdje42@gmail.com>
 714
 715         * dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
 716
 717 2015-01-11  Doug Evans  <xdje42@gmail.com>
 718
 719         PR gdb/15830
 720         * NEWS: The "maint demangle" command is renamed as "demangle".
 721         * demangle.c: #include cli/cli-utils.h, language.h.
 722         (demangle_command): New function.
 723         (_initialize_demangle): Add new command "demangle".
 724         * maint.c (maintenance_demangle): Stub out.
 725         (_initialize_maint_cmds): Update help text for "maint demangle",
 726         and mark as deprecated.
 727
 728 2015-01-11  Mark Kettenis  <kettenis@gnu.org>
 729
 730         * inf-ptrace.c (inf_ptrace_follow_fork): Adjust now that
 731         inferior_thread is a function.
 732
 733 2015-01-09  Patrick Palka  <patrick@parcs.ath.cx>
 734
 735         * Makefile.in (.y.c): Don't munge yacc's #line
 736         directives.
 737
 738 2015-01-09  Patrick Palka  <patrick@parcs.ath.cx>
 739
 740         * utils.c (defaulted_query): Rewrite to use gdb_readline_wrapper
 741         to prompt for input.
 742         * tui/tui-hooks.c (tui_query_hook): Remove.
 743         (tui_install_hooks): Don't set deprecated_query_hook.
 744         * tui/tui-io.c (tui_redisplay_readline): Fix off-by-one error in
 745         height calculation.  Always update the command window's cur_line.
 746
 747 2015-01-09  Pedro Alves  <palves@redhat.com>
 748
 749         * breakpoint.c (hardware_breakpoint_inserted_here_p): New
 750         function.
 751         * breakpoint.h (hardware_breakpoint_inserted_here_p): New
 752         declaration.
 753         * linux-nat.c (linux_nat_status_is_event): Move higher up in file.
 754         (linux_resume_one_lwp): Store the thread's PC.  Adjust to clear
 755         stop_reason.
 756         (check_stopped_by_watchpoint): New function.
 757         (save_sigtrap): Reimplement.
 758         (linux_nat_stopped_by_watchpoint): Adjust.
 759         (linux_nat_lp_status_is_event): Delete.
 760         (stop_wait_callback): Only call save_sigtrap after storing the
 761         pending status.
 762         (status_callback): If the thread had been stopped for a breakpoint
 763         that has since been removed, discard the event and resume the LWP.
 764         (count_events_callback, select_event_lwp_callback): Use
 765         lwp_status_pending_p instead of linux_nat_lp_status_is_event.
 766         (cancel_breakpoint): Rename to ...
 767         (check_stopped_by_breakpoint): ... this.  Record whether the LWP
 768         stopped for a software breakpoint or hardware breakpoint.
 769         (select_event_lwp): Only give preference to the stepping LWP in
 770         all-stop mode.  Adjust comments.
 771         (stop_and_resume_callback): Remove references to new_pending_p.
 772         (linux_nat_filter_event): Likewise.  Leave exit events of the
 773         leader thread pending here.  Handle signal short circuiting here.
 774         Only call save_sigtrap after storing the pending waitstatus.
 775         (linux_nat_wait_1): Remove 'retry' label.  Remove references to
 776         new_pending.  Don't handle leaving events the caller is not
 777         interested in pending here, nor handle signal short-circuiting
 778         here.  Also give equal priority to all LWPs that have had events
 779         in non-stop mode.  If reporting a software breakpoint event,
 780         unadjust the LWP's PC.
 781         * linux-nat.h (enum lwp_stop_reason): New.
 782         (struct lwp_info) <stop_pc>: New field.
 783         (struct lwp_info) <stopped_by_watchpoint>: Delete field.
 784         (struct lwp_info) <stop_reason>: New field.
 785         * x86-linux-nat.c (x86_linux_prepare_to_resume): Adjust.
 786
 787 2015-01-09  Pedro Alves  <palves@redhat.com>
 788
 789         * linux-nat.c (linux_handle_extended_wait) <PTRACE_EVENT_EXEC>:
 790         Set the LWP's 'resumed' flag.
 791
 792 2015-01-09  Pedro Alves  <palves@redhat.com>
 793
 794         * linux-nat.c (linux_resume_one_lwp): New function.
 795         (resume_lwp): Use lwp_status_pending_p and linux_resume_one_lwp.
 796         (linux_nat_resume): Use lwp_status_pending_p and
 797         linux_resume_one_lwp.
 798         (linux_handle_syscall_trap): Use linux_resume_one_lwp.
 799         (linux_handle_extended_wait): Use linux_resume_one_lwp.
 800         (status_callback, running_callback): Use lwp_status_pending_p.
 801         (lwp_status_pending_p): New function.
 802         (stop_and_resume_callback): Use lwp_status_pending_p.
 803         (linux_nat_filter_event): Use linux_resume_one_lwp.
 804         (linux_nat_wait_1): Always use status_callback to look for an LWP
 805         with a pending status.  Use linux_resume_one_lwp.
 806         (resume_stopped_resumed_lwps): Use lwp_status_pending_p and
 807         linux_resume_one_lwp.
 808
 809 2015-01-09  Pedro Alves  <palves@redhat.com>
 810
 811         * breakpoint.c (bp_location_inserted_here_p): New function,
 812         factored out from ...
 813         (breakpoint_inserted_here_p): ... here.  Use
 814         ALL_BP_LOCATIONS_AT_ADDR.
 815         (software_breakpoint_inserted_here_p): Use
 816         bp_location_inserted_here_p and ALL_BP_LOCATIONS_AT_ADDR.
 817
 818 2014-01-09  Pedro Alves  <palves@redhat.com>
 819
 820         Skip enabling event reporting if the kernel supports
 821         PTRACE_EVENT_CLONE.
 822         * linux-thread-db.c: Include "nat/linux-ptrace.h".
 823         (thread_db_use_events): New function.
 824         (try_thread_db_load_1): Check thread_db_use_events before enabling
 825         event reporting.
 826         (update_thread_state): New function.
 827         (attach_thread): Use it.  Check thread_db_use_events before
 828         enabling event reporting.
 829         (thread_db_detach): Check thread_db_use_events before disabling
 830         event reporting.
 831         (find_new_threads_callback): Check thread_db_use_events before
 832         enabling event reporting.  Update the thread's state if not using
 833         libthread_db events.
 834
 835 2015-01-09  Pedro Alves  <palves@redhat.com>
 836
 837         * linux-nat.c (lin_lwp_attach_lwp): Assert that the lwp id we're
 838         about to wait for is > 0.
 839         * linux-thread-db.c (find_new_threads_callback): Ignore thread if
 840         the kernel thread ID is -1.
 841
 842 2015-01-09  Pedro Alves  <palves@redhat.com>
 843
 844         * linux-nat.c (attach_proc_task_lwp_callback): New function.
 845         (linux_nat_attach): Use linux_proc_attach_tgid_threads.
 846         (wait_lwp, linux_nat_filter_event): If not set yet, set the lwp's
 847         ptrace option flags.
 848         * linux-nat.h (struct lwp_info) <must_set_ptrace_flags>: New
 849         field.
 850         * nat/linux-procfs.c: Include <dirent.h>.
 851         (linux_proc_get_int): New parameter "warn".  Handle it.
 852         (linux_proc_get_tgid): Adjust.
 853         (linux_proc_get_tracerpid): Rename to ...
 854         (linux_proc_get_tracerpid_nowarn): ... this.
 855         (linux_proc_pid_get_state): New function, factored out from
 856         (linux_proc_pid_has_state): ... this.  Add new parameter "warn"
 857         and handle it.
 858         (linux_proc_pid_is_gone): New function.
 859         (linux_proc_pid_is_stopped): Adjust.
 860         (linux_proc_pid_is_zombie_maybe_warn)
 861         (linux_proc_pid_is_zombie_nowarn): New functions.
 862         (linux_proc_pid_is_zombie): Use
 863         linux_proc_pid_is_zombie_maybe_warn.
 864         (linux_proc_attach_tgid_threads): New function.
 865         * nat/linux-procfs.h (linux_proc_get_tgid): Update comment.
 866         (linux_proc_get_tracerpid): Rename to ...
 867         (linux_proc_get_tracerpid_nowarn): ... this, and update comment.
 868         (linux_proc_pid_is_gone): New declaration.
 869         (linux_proc_pid_is_zombie): Update comment.
 870         (linux_proc_pid_is_zombie_nowarn): New declaration.
 871         (linux_proc_attach_lwp_func): New typedef.
 872         (linux_proc_attach_tgid_threads): New declaration.
 873         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason): Adjust to
 874         use nowarn functions.
 875         (linux_ptrace_attach_fail_reason_string): Move here from
 876         gdbserver/linux-low.c and rename.
 877         (ptrace_supports_feature): If the current ptrace options are not
 878         known yet, check them now, instead of asserting.
 879         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason_string):
 880         Declare.
 881
 882 2015-01-09  Pedro Alves  <palves@redhat.com>
 883
 884         * linux-thread-db.c (thread_db_find_new_threads_silently)
 885         (try_thread_db_load_1, try_thread_db_load, thread_db_load_search)
 886         (find_new_threads_once): Print debug output on gdb_stdlog.
 887
 888 2015-01-09  Chen Gang  <gang.chen.5i5j@gmail.com>
 889             Pedro Alves  <palves@redhat.com>
 890
 891         * compile/compile.c: Include "gdb_wait.h".
 892         (do_rmdir): Check return value, and free 'zap'.
 893
 894 2015-01-08  Pedro Alves  <palves@redhat.com>
 895             Yao Qi  <yao@codesourcery.com>
 896
 897         * dwarf2loc.c (indirect_pieced_value): Don't call
 898         gdb_sign_extend.  Call extract_signed_integer instead.
 899         * utils.c (gdb_sign_extend): Remove.
 900         * utils.h (gdb_sign_extend): Remove declaration.
 901
 902 2015-01-07  Pierre Muller  <muller@sourceware.org>
 903
 904         PR symtab/17811
 905         * stabsread.c (define_symbol): Set language for C++ special symbols.
 906
 907 2015-01-07  Patrick Palka  <patrick@parcs.ath.cx>
 908
 909         * inflow.c (initial_gdb_ttystate): Tweak comment.
 910
 911 2015-01-07  Joel Brobecker  <brobecker@adacore.com>
 912
 913         * inflow.c (set_initial_gdb_ttystate): Add empty line after
 914         comment documenting function.
 915
 916 2015-01-07  Patrick Palka  <patrick@parcs.ath.cx>
 917
 918         * terminal.h (set_initial_gdb_ttystate): Declare.
 919         * inflow.c (initial_gdb_ttystate): New static variable.
 920         (set_initial_gdb_ttystate): New setter.
 921         (child_terminal_init_with_pgrp): Copy initial_gdb_ttystate
 922         instead of our current terminal state.
 923         * top.c (gdb_init): Call set_initial_gdb_ttystate.
 924
 925 2015-01-07  Joel Brobecker  <brobecker@adacore.com>
 926
 927         * guile/scm-type.c (tyscm_array_1): Add comment.
 928         * python/py-type.c (typy_array_1): Add comment.
 929
 930 2015-01-06  Joel Brobecker  <brobecker@adacore.com>
 931
 932         * guile/scm-type.c (tyscm_array_1): Do not raise out-of-range
 933         error if N2 is equal to N1 - 1.
 934
 935 2015-01-06  Joel Brobecker  <brobecker@adacore.com>
 936
 937         * python/py-type.c (typy_array_1): Do not raise negative-length
 938         exception if N2 is equal to N1 - 1.
 939
 940 2015-01-03  Doug Evans  <xdje42@gmail.com>
 941
 942         * c-exp.y: Whitespace cleanup.
 943         (classify_inner_name): Remove extra ;.
 944
 945 2015-01-02  Maciej W. Rozycki  <macro@codesourcery.com>
 946
 947         * mips-tdep.c (mips32_scan_prologue): Keep the extracted stack
 948         offset signed.
 949
 950 2015-01-02  Doug Evans  <dje@google.com>
 951
 952         * dwarf2read.c (setup_type_unit_groups): Remove outdated comment.
 953
 954 2015-01-02  Doug Evans  <dje@google.com>
 955
 956         * symtab.h (struct symbol): Fix typo in comment.
 957
 958 2015-01-01  Joel Brobecker  <brobecker@adacore.com>
 959
 960         Update year range in copyright notice of all files.
 961
 962 2015-01-01  Joel Brobecker  <brobecker@adacore.com>
 963
 964         * top.c (print_gdb_version): Update copyright year to 2015.
 965
 966 2015-01-01  Joel Brobecker  <brobecker@adacore.com>
 967
 968         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2014.
 969
 970 For older changes see ChangeLog-2014.
 971 \f
 972 Local Variables:
 973 mode: change-log
 974 left-margin: 8
 975 fill-column: 74
 976 version-control: never
 977 coding: utf-8
 978 End: