gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * ada-lang.c (struct ada_inferior_data): Add initializers.
   4         (ada_inferior_data): Change type.
   5         (ada_inferior_data_cleanup): Remove.
   6         (get_ada_inferior_data, ada_inferior_exit)
   7         (struct ada_pspace_data): Add initializers, destructor.
   8         (ada_pspace_data_handle): Change type.
   9         (get_ada_pspace_data): Update.
  10         (ada_pspace_data_cleanup): Remove.
  11
  12 2019-05-08  Tom Tromey  <tom@tromey.com>
  13
  14         * coffread.c (struct coff_symfile_info): Add initializers.
  15         (coff_objfile_data_key): Move lower.  Change type.
  16         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  17         Update.
  18         (coff_free_info): Remove.
  19
  20 2019-05-08  Tom Tromey  <tom@tromey.com>
  21
  22         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  23         (fbsd_pspace_data_handle): Move lower.  Change type.
  24         (get_fbsd_pspace_data): Update.
  25         (fbsd_pspace_data_cleanup): Remove.
  26         (_initialize_fbsd_tdep): Update.
  27
  28 2019-05-08  Tom Tromey  <tom@tromey.com>
  29
  30         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  31         (get_ada_tasks_pspace_data): Update.
  32         (ada_tasks_pspace_data_cleanup): Remove.
  33         (_initialize_tasks): Update.
  34         (ada_tasks_inferior_data_handle): Change type.
  35         (get_ada_tasks_inferior_data): Update.
  36         (ada_tasks_inferior_data_cleanup): Remove.
  37         (struct ada_tasks_pspace_data): Add initializers.
  38
  39 2019-05-08  Tom Tromey  <tom@tromey.com>
  40
  41         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  42         * symfile-debug.c (debug_sym_get_probes): Change type.
  43         * stap-probe.c (handle_stap_probe):
  44         (stap_static_probe_ops::get_probes): Change type.
  45         * probe.h (class static_probe_ops) <get_probes>: Change type.
  46         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  47         (parse_probes_in_pspace): Update.
  48         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  49         Update.
  50         (any_static_probe_ops::get_probes): Change type.
  51         * elfread.c (elfread_data): New typedef.
  52         (probe_key): Change type.
  53         (elf_get_probes): Likewise.  Update.
  54         (probe_key_free): Remove.
  55         (_initialize_elfread): Update.
  56         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  57         Change type.
  58         (dtrace_process_dof_probe, dtrace_process_dof)
  59         (dtrace_static_probe_ops::get_probe): Change type.
  60
  61 2019-05-08  Tom Tromey  <tom@tromey.com>
  62
  63         * xcoffread.c (struct xcoff_symfile_info): Rename from
  64         coff_symfile_info.  Add initializers.
  65         (xcoff_objfile_data_key): Move lower.  Change type.
  66         (XCOFF_DATA): Rewrite.
  67         (xcoff_free_info): Remove.
  68         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  69         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  70         (xcoff_initial_scan): Update.
  71
  72 2019-05-08  Tom Tromey  <tom@tromey.com>
  73
  74         * solib-svr4.c (struct svr4_info): Add initializers and
  75         destructor.
  76         <probes_table>: Now an htab_up.
  77         (solib_svr4_pspace_data): Change type.
  78         (free_probes_table): Simplify.
  79         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  80         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  81         (probes_table_remove_objfile_probes, register_solib_event_probe)
  82         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  83         (_initialize_svr4_solib): Update.
  84
  85 2019-05-08  Tom Tromey  <tom@tromey.com>
  86
  87         * remote.c (remote_pspace_data): Change type.
  88         (remote_pspace_data_cleanup): Remove.
  89         (get_remote_exec_file, set_pspace_remote_exec_file)
  90         (_initialize_remote): Update.
  91
  92 2019-05-08  Tom Tromey  <tom@tromey.com>
  93
  94         * breakpoint.c (breakpoint_objfile_key): Change type.
  95         (get_breakpoint_objfile_data): Update.
  96         (free_breakpoint_objfile_data): Remove.
  97         (_initialize_breakpoint): Update.
  98
  99 2019-05-08  Tom Tromey  <tom@tromey.com>
 100
 101         * linux-tdep.c (struct linux_info): Add initializers.
 102         (linux_inferior_data): Move.  Change type.
 103         (invalidate_linux_cache_inf): Update.
 104         (linux_inferior_data_cleanup): Remove.
 105         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 106
 107 2019-05-08  Tom Tromey  <tom@tromey.com>
 108
 109         * auxv.c (auxv_inferior_data): Move.  Change type.
 110         (auxv_inferior_data_cleanup): Remove.
 111         (invalidate_auxv_cache_inf): Rewrite.
 112         (get_auxv_inferior_data, _initialize_auxv): Update.
 113
 114 2019-05-08  Tom Tromey  <tom@tromey.com>
 115
 116         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 117         (symfile_debug_objfile_data_key): Change type.
 118         (symfile_debug_installed, debug_qf_has_symbols)
 119         (debug_qf_find_last_source_symtab)
 120         (debug_qf_forget_cached_source_info)
 121         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 122         (debug_qf_print_stats, debug_qf_dump)
 123         (debug_qf_expand_symtabs_for_function)
 124         (debug_qf_expand_all_symtabs)
 125         (debug_qf_expand_symtabs_with_fullname)
 126         (debug_qf_map_matching_symbols)
 127         (debug_qf_expand_symtabs_matching)
 128         (debug_qf_find_pc_sect_compunit_symtab)
 129         (debug_qf_map_symbol_filenames)
 130         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 131         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 132         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 133         (debug_sym_read_linetable, debug_sym_relocate): Update.
 134         (symfile_debug_free_objfile): Remove.
 135         (install_symfile_debug_logging, _initialize_symfile_debug):
 136         Update.
 137
 138 2019-05-08  Tom Tromey  <tom@tromey.com>
 139
 140         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 141         allocate_on_obstack.
 142         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 143         (get_dwarf2_per_objfile): Update.
 144         (set_dwarf2_per_objfile): Remove.
 145         (dwarf2_has_info, dwarf2_get_section_info): Update.
 146         (dwarf2_free_objfile): Remove.
 147         (_initialize_dwarf2_read): Update.
 148
 149 2019-05-08  Tom Tromey  <tom@tromey.com>
 150
 151         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 152         initializers.
 153         <unsupported_script_warning_printed,
 154         script_not_found_warning_printed>: Now bool.
 155         (auto_load_pspace_data): Change type.
 156         (~auto_load_pspace_info): Rename from
 157         auto_load_pspace_data_cleanup.
 158         (get_auto_load_pspace_data, init_loaded_scripts_info)
 159         (clear_section_scripts, maybe_print_unsupported_script_warning)
 160         (maybe_print_script_not_found_warning, _initialize_auto_load):
 161         Update.
 162
 163 2019-05-08  Tom Tromey  <tom@tromey.com>
 164
 165         * objfiles.c (objfile_pspace_info): Add destructor and
 166         initializers.
 167         (objfiles_pspace_data): Change type.
 168         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 169         (get_objfile_pspace_data): Update.
 170         (objfiles_bfd_data): Change type.
 171         (get_objfile_bfd_data): Update.
 172         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 173
 174 2019-05-08  Tom Tromey  <tom@tromey.com>
 175
 176         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 177         Change type.
 178         (get_catch_syscall_inferior_data): Update.
 179         (catch_syscall_inferior_data_cleanup): Remove.
 180         (_initialize_break_catch_syscall): Update.
 181
 182 2019-05-08  Tom Tromey  <tom@tromey.com>
 183
 184         * inflow.c (struct terminal_info): Add destructor and
 185         initializers.
 186         (inflow_inferior_data): Change type.
 187         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 188         (get_inflow_inferior_data, inflow_inferior_exit)
 189         (swap_terminal_info, _initialize_inflow): Update.
 190
 191 2019-05-08  Tom Tromey  <tom@tromey.com>
 192
 193         * target-dcache.c (target_dcache_cleanup): Remove.
 194         (target_dcache_aspace_key): Change type.
 195         (target_dcache_init_p, target_dcache_invalidate)
 196         (target_dcache_get, target_dcache_get_or_init)
 197         (_initialize_target_dcache): Update.
 198         * dcache.h (struct dcache_deleter): New.
 199
 200 2019-05-08  Tom Tromey  <tom@tromey.com>
 201
 202         * symtab.c (struct symbol_cache): Add destructor and
 203         initializers.
 204         (symbol_cache_key): Move.  Change type.
 205         (make_symbol_cache, free_symbol_cache): Remove.
 206         (get_symbol_cache): Update.
 207         (symbol_cache_cleanup): Remove.
 208         (ALL_PSPACES, symbol_cache_flush)
 209         (maintenance_print_symbol_cache)
 210         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 211         Update.
 212
 213 2019-05-08  Tom Tromey  <tom@tromey.com>
 214
 215         * symtab.c (struct main_info): Add destructor and initializers.
 216         (main_progspace_key): Move.  Change type.
 217         (get_main_info): Update.
 218         (main_info_cleanup): Remove.
 219         (_initialize_symtab): Update.
 220
 221 2019-05-08  Tom Tromey  <tom@tromey.com>
 222
 223         * registry.h (DECLARE_REGISTRY): Define the _key class.
 224
 225 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * NEWS: Merge two 'New commands' sections.
 228
 229 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 230
 231         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 232         parameter and use Ada language definition instead.
 233         (ada_val_print_ptr): Remove unused language parameter.
 234         (ada_val_print_num): Remove language parameter and use Ada language
 235         definition instead.
 236         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 237         parameter.
 238         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 239         parameter and use Ada language definition instead.
 240         (ada_val_print_1): Update all ada_val_print_xxx calls.
 241         Remove language parameter.
 242         (ada_val_print): Update ada_val_print_1 call.
 243
 244 2019-05-08  Tom Tromey  <tromey@adacore.com>
 245
 246         * remote.c (remote_hw_watchpoint_limit)
 247         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 248         Now static.
 249
 250 2019-05-08  Tom Tromey  <tromey@adacore.com>
 251
 252         * maint.c (_initialize_maint_cmds): Move initialization code to
 253         remote.c.
 254         (watchdog, show_watchdog): Move to remote.c.
 255         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 256         "watchdog" static.
 257         (_initialize_remote): Move initialization code from maint.c.
 258         * defs.h (watchdog): Don't declare.
 259
 260 2019-05-08  Tom Tromey  <tromey@adacore.com>
 261
 262         * tui/tui-interp.c: Include main.h.
 263         * interps.c: Include main.h.
 264         * main.h (interpreter_p): Declare.
 265         * defs.h (interpreter_p): Don't declare.
 266
 267 2019-05-08  Tom Tromey  <tromey@adacore.com>
 268
 269         * dwarf2loc.c: Include dwarf2read.h.
 270         * defs.h (read_unsigned_leb128): Don't declare.
 271         * dwarf2read.h (read_unsigned_leb128): Declare.
 272
 273 2019-05-08  Tom Tromey  <tromey@adacore.com>
 274
 275         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 276         method.
 277
 278 2019-05-08  Tom Tromey  <tromey@adacore.com>
 279
 280         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 281         when no wrap column is set.
 282
 283 2019-05-08  Tom Tromey  <tromey@adacore.com>
 284
 285         * c-lang.c (c_get_string): Handle non-C-style arrays.
 286
 287 2019-05-08  Tom Tromey  <tromey@adacore.com>
 288
 289         * typeprint.c (print_offset_data::update): Print the bit offset,
 290         not the number of bits remaining.
 291
 292 2019-05-08  Tom Tromey  <tromey@adacore.com>
 293
 294         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 295         padding at end of comment.
 296
 297 2019-05-08  Tom Tromey  <tromey@adacore.com>
 298
 299         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 300         Compare main types.
 301
 302 2019-05-06  Tom Tromey  <tom@tromey.com>
 303
 304         * common/scoped_mmap.c: Include common-defs.h.
 305         * common/scoped_mmap.h: Don't include config.h.
 306
 307 2019-05-04  Tom Tromey  <tom@tromey.com>
 308
 309         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 310         (struct aarch64_call_info): Add initializers.
 311         <si>: Now a std::vector.
 312         (pass_on_stack, aarch64_push_dummy_call): Update.
 313
 314 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 315             Tom Tromey  <tom@tromey.com>
 316
 317         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 318         (ppc_threads): Now a std::vector.  Now static.
 319         (hwdebug_find_thread_points_by_tid)
 320         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 321         Update.
 322
 323 2019-05-04  Tom Tromey  <tom@tromey.com>
 324
 325         * arc-tdep.c (arc_tdesc_init): Return bool.
 326
 327 2019-05-04  Tom Tromey  <tom@tromey.com>
 328
 329         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 330         Use gdb_assert_not_reached.
 331
 332 2019-05-04  Tom Tromey  <tom@tromey.com>
 333
 334         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 335         "false".
 336
 337 2019-05-04  Tom Tromey  <tom@tromey.com>
 338
 339         * arc-tdep.c (arc_tdesc_init): Use bool.
 340
 341 2019-05-04  Tom Tromey  <tom@tromey.com>
 342
 343         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 344
 345 2019-05-04  Tom Tromey  <tom@tromey.com>
 346
 347         * cli/cli-cmds.c (valid_command_p): Return bool.
 348
 349 2019-05-04  Tom Tromey  <tom@tromey.com>
 350
 351         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 352         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 353
 354 2019-05-04  Raul Tambre  <raul@tambre.ee>
 355
 356         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 357         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 358         operator for comparison.
 359
 360 2019-05-04  Tom Tromey  <tom@tromey.com>
 361
 362         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 363         (lookup_partial_symbol, print_partial_symbols)
 364         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 365         (psymbol_compare): Update.
 366         (add_psymbol_to_bcache): Clear the entire psymbol.
 367         (maintenance_check_psymtabs): Update.
 368         * psympriv.h (struct partial_symbol): Don't derive from
 369         general_symbol_info.
 370         <obj_section, unrelocated_address, address,
 371         set_unrelocated_address>: Update.
 372         <ginfo>: New member.
 373         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 374         (debug_names::write_psymbols): Update.
 375
 376 2019-05-04  Tom de Vries  <tdevries@suse.de>
 377
 378         * contrib/cc-with-tweaks.sh: Support -n arg.
 379
 380 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 381
 382         * corelow.c (core_target::detach): Ensure frame cache and
 383         register caches are cleared.
 384         inferior.c (exit_inferior_1): Likewise.
 385
 386 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 387             Tom Tromey  <tom@tromey.com>
 388
 389         * dictionary.c (collate_pending_symbols_by_language): Remove
 390         "struct" from foreach.
 391         * symtab.c (lookup_global_symbol_from_objfile)
 392         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 393         foreach.
 394         * ser-tcp.c (net_open): Remove "struct" from foreach.
 395         * objfiles.c (objfile_relocate, objfile_rebase)
 396         (objfile_has_symbols): Remove "struct" from foreach.
 397         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 398         from foreach.
 399         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 400         foreach.
 401         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 402         "struct" from foreach.
 403         * ada-lang.c (create_excep_cond_exprs)
 404         (ada_exception_catchpoint_cond_string): Remove "struct" from
 405         foreach.
 406
 407 2019-05-03  Tom Tromey  <tromey@adacore.com>
 408
 409         * ada-exp.y (convert_char_literal): Check suffix of each
 410         enumerator.
 411
 412 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 413
 414         PR ada/21406:
 415         * ada-exp.y (yywrap): Don't define.
 416         * ada-lex.l (%option): Add noyywrap
 417         (yywrap): Remove.
 418
 419 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 420
 421         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 422         _WIN32_WINNT to the XP level, unless already defined to a higher
 423         level.
 424
 425         * unittests/parse-connection-spec-selftests.c:
 426         * ser-tcp.c:
 427         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 428         override.
 429
 430         * symfile.c (find_separate_debug_file): Remove colon from the
 431         drive spec of DOS/Windows file names of the target, so that the
 432         file name produced from DEBUGDIR and the target's directory will
 433         be valid on DOS/Windows systems.
 434
 435 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * rust-lang.c (val_print_struct): Handle printing structures
 438         containing strings.
 439
 440 2019-05-02  Tom Tromey  <tromey@adacore.com>
 441
 442         * valarith.c (_initialize_valarith): Remove.
 443
 444 2019-05-01  Tom Tromey  <tromey@adacore.com>
 445
 446         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 447         bitfields.
 448
 449 2019-05-01  Tom Tromey  <tromey@adacore.com>
 450
 451         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 452         for big-endian copies.
 453
 454 2019-04-30  Ali Tamur  <tamur@google.com>
 455         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 456         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 457         (read_3_bytes): New function.
 458
 459 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 460
 461         * windows-nat.c (main_thread_id): Delete.
 462         (handle_output_debug_string): Replace main_thread_id by
 463         current_event.dwThreadId.
 464         (fake_create_process): Likewise.
 465         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 466         Do not set main_thread_id.
 467         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 468         current_event.dwThreadId.
 469         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 470
 471 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 472
 473         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 474         Use current_event.dwThreadId instead of main_thread_id.
 475
 476 2019-04-30  Tom Tromey  <tromey@adacore.com>
 477
 478         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 479         (create_excep_cond_exprs): Iterate over program spaces.
 480         (ada_exception_catchpoint_cond_string): Examine all minimal
 481         symbols for exception types.
 482
 483 2019-04-30  Tom Tromey  <tromey@adacore.com>
 484
 485         PR c++/24470:
 486         * dwarf2read.c (process_structure_scope): Handle case where type
 487         has template parameters but no symbol was created.
 488
 489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 490             Chris January  <chris.january@arm.com>
 491
 492         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 493         qualifier.
 494         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 495
 496 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * f-typeprint.c (f_print_type): Update rules for printing
 499         whitespace.
 500         (f_type_print_varspec_suffix): Likewise.
 501
 502 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 503             Chris January  <chris.january@arm.com>
 504
 505         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 506         function arguments.
 507
 508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * f-lang.c (build_fortran_types): Change name of void type to
 511         lower case.
 512         * f-typeprint.c (f_type_print_base): Print the name of the void
 513         type, rather than a fixed string.
 514         * f-valprint.c (f_decorations): Use lower case void string.
 515
 516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 517             Chris January  <chris.january@arm.com>
 518
 519         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 520         types for Fortran.
 521
 522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 523             Chris January  <chris.january@arm.com>
 524             David Lecomber  <david.lecomber@arm.com>
 525
 526         * f-exp.y (BINOP_INTRINSIC): New token.
 527         (exp): New parser rule handling BINOP_INTRINSIC.
 528         (f77_keywords): Add new builtin procedures.
 529         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 530         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 531         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 532         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 533         (print_unop_subexp_f): New function.
 534         (print_binop_subexp_f): New function.
 535         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 536         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 537         (dump_subexp_body_f): Likewise.
 538         (operator_check_f): Likewise.
 539         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 540         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 541
 542 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 545         UNOP_KIND.
 546         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 547         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 548         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 549         (operator_length_f): New fuction.
 550         (print_subexp_f): New function.
 551         (op_name_f): New function.
 552         (dump_subexp_body_f): New function.
 553         (operator_check_f): New function.
 554         (exp_descriptor_f): Replace standard expression handling functions
 555         with new functions.
 556         * gdb/fortran-operator.def: New file.
 557         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 558         * gdb/std-operator.def: Remove UNOP_KIND.
 559
 560 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * std-operator.def: Remove unbalanced, stray double quote
 563         character.
 564
 565 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 566             Chris January  <chris.january@arm.com>
 567             Daniel Everett  <daniel.everett@arm.com>
 568             Nick Forrington  <nick.forrington@arm.com>
 569             Richard Bunt  <richard.bunt@arm.com>
 570
 571         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 572         of depth when printing anonymous structs or unions.
 573         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 574         Don't print either the top-level value, or the children if the
 575         max-depth is exceeded.
 576         (ppscm_print_children): When printing the key of a map, allow one
 577         extra level of depth.
 578         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 579         print either the top-level value, or the children if the max-depth
 580         is exceeded.
 581         (print_children): When printing the key of a map, allow one extra
 582         level of depth.
 583         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 584         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 585         (user_print_options): Initialise max_depth field.
 586         (val_print_scalar_or_string_type_p): New function.
 587         (val_print): Check to see if the max depth has been reached.
 588         (val_print_check_max_depth): Define new function.
 589         (show_print_max_depth): New function.
 590         (_initialize_valprint): Add 'print max-depth' option.
 591         * valprint.h (struct value_print_options) <max_depth>: New field.
 592         (val_print_check_max_depth): Declare new function.
 593         * NEWS: Document new feature.
 594
 595 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 596
 597         * ada-lang.c (ada_language_defn): Initialise new field.
 598         * c-lang.c (c_is_string_type_p): New function.
 599         (c_language_defn): Initialise new field.
 600         (cplus_language_defn): Initialise new field.
 601         (asm_language_defn): Initialise new field.
 602         (minimal_language_defn): Initialise new field.
 603         * c-lang.h (c_is_string_type_p): Declare new function.
 604         * d-lang.c (d_language_defn): Initialise new field.
 605         * f-lang.c (f_is_string_type_p): New function.
 606         (f_language_defn): Initialise new field.
 607         * go-lang.c (go_is_string_type_p): New function.
 608         (go_language_defn): Initialise new field.
 609         * language.c (default_is_string_type_p): New function.
 610         (unknown_language_defn): Initialise new field.
 611         (auto_language_defn): Initialise new field.
 612         * language.h (struct language_defn) <la_is_string_type_p>: New
 613         member variable.
 614         (default_is_string_type_p): Declare new function.
 615         * m2-lang.c (m2_language_defn): Initialise new field.
 616         * objc-lang.c (objc_language_defn): Initialise new field.
 617         * opencl-lang.c (opencl_language_defn): Initialise new field.
 618         * p-lang.c (pascal_is_string_type_p): New function.
 619         (pascal_language_defn): Initialise new field.
 620         * rust-lang.c (rust_is_string_type_p): New function.
 621         (rust_language_defn): Initialise new field.
 622
 623 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 624
 625         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 626         New field.
 627         * ada-lang.c (ada_language_defn): Initialise new field.
 628         * c-lang.c (c_language_defn): Likewise.
 629         (cplus_language_defn): Likewise.
 630         (asm_language_defn): Likewise.
 631         (minimal_language_defn): Likewise.
 632         * d-lang.c (d_language_defn): Likewise.
 633         * f-lang.c (f_language_defn): Likewise.
 634         * go-lang.c (go_language_defn): Likewise.
 635         * language.c (unknown_language_defn): Likewise.
 636         (auto_language_defn): Likewise.
 637         * m2-lang.c (m2_language_defn): Likewise.
 638         * objc-lang.c (objc_language_defn): Likewise.
 639         * opencl-lang.c (opencl_language_defn): Likewise.
 640         * p-lang.c (pascal_language_defn): Likewise.
 641         * rust-lang.c (rust_language_defn): Likewise.
 642
 643 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * ada-lang.c (ada_is_character_type): Change return type to bool.
 646         (ada_is_string_type): Likewise.
 647         * ada-lang.h (ada_is_character_type): Update declaration
 648         (ada_is_string_type): Likewise.
 649
 650 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 651
 652         Support style in 'frame|thread apply'
 653
 654         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 655         * record.c (record_start, record_stop): Update callers of
 656         execute_command_to_string with false.
 657         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 658         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 659         methods.
 660         (class string_file): New constructor with term_out parameter.
 661         Override methods term_out and can_emit_style_escape.  New member
 662         term_out.
 663         (class stdio_file): Override can_emit_style_escape.
 664         (class tee_file): Override term_out and can_emit_style_escape.
 665         * utils.h (can_emit_style_escape): Remove.
 666         * utils.c (can_emit_style_escape): Likewise.
 667         Update all callers of can_emit_style_escape (SOMESTREAM) to
 668         SOMESTREAM->can_emit_style_escape.
 669         * source-cache.c (source_cache::get_source_lines): Likewise.
 670         * stack.c (frame_apply_command_count): Call execute_command_to_string
 671         passing the term_out characteristic of the current gdb_stdout.
 672         * thread.c (thr_try_catch_cmd): Likewise.
 673         * top.c (execute_command_to_string): pass term_out parameter
 674         to construct the string_file for the command output.
 675         * ui-file.c (term_cli_styling): New function (most code moved
 676         from utils.c can_emit_style_escape).
 677         (string_file::string_file, string_file::can_emit_style_escape,
 678         stdio_file::can_emit_style_escape, tee_file::term_out,
 679         tee_file::can_emit_style_escape): New functions.
 680
 681 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 682
 683         * NEWS: Mention the new set|show may-call-functions.
 684         * infcall.c (may_call_functions_p): New variable.
 685         (show_may_call_functions_p): New function.
 686         (call_function_by_hand_dummy): Throws an error if not
 687         may-call-functions.
 688         (_initialize_infcall): Call add_setshow_boolean_cmd for
 689         may-call-functions.
 690
 691 2019-04-25  Keith Seitz  <keiths@redhat.com>
 692
 693         PR c++/24367
 694         * cp-support.c (inspect_type): Don't attempt substitutions
 695         of symbol with the same name.
 696
 697 2019-04-25  Tom Tromey  <tromey@adacore.com>
 698
 699         PR gdb/24475:
 700         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 701         static.
 702
 703 2019-04-25  Tom Tromey  <tromey@adacore.com>
 704
 705         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 706         rvalue reference.
 707         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 708         (gdb_xml_parser::parse): Use std::move.
 709         * python/python-internal.h (gdbpy_convert_exception): Take a const
 710         reference.
 711         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 712         std::move.
 713         * python/py-utils.c (gdbpy_convert_exception): Take a const
 714         reference.
 715         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 716         Use std::move.
 717         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 718         Use std::move.
 719         * mi/mi-main.c (mi_print_exception): Take a const reference.
 720         * main.c (handle_command_errors): Take a const reference.
 721         * linespec.c (parse_linespec): Use std::move.
 722         * infcall.c (run_inferior_call): Use std::move.
 723         (call_function_by_hand_dummy): Use std::move.
 724         * exec.c (try_open_exec_file): Use std::move.
 725         * exceptions.h (exception_print, exception_fprintf)
 726         (exception_print_same): Update.
 727         * exceptions.c (print_exception, exception_print)
 728         (exception_fprintf, exception_print_same): Change parameters to
 729         const reference.
 730         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 731         * common/new-op.c: Use std::move.
 732         * common/common-exceptions.h (struct gdb_exception): Add move
 733         constructor.
 734         (struct gdb_exception_error, struct gdb_exception_quit, struct
 735         gdb_quit_bad_alloc): Change constructor to move constructor.
 736         (throw_exception): Change parameter to rvalue reference.
 737         * common/common-exceptions.c (throw_exception): Take rvalue
 738         reference.
 739         * cli/cli-interp.c (safe_execute_command): Use std::move.
 740         * breakpoint.c (insert_bp_location, location_to_sals): Use
 741         std::move.
 742
 743 2019-04-25  Tom Tromey  <tromey@adacore.com>
 744
 745         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 746         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 747         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 748         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 749         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 750         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 751         guile/scm-value.c: Use unpack.
 752         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 753         gdbscm_gdb_exception.
 754         (gdbscm_throw_gdb_exception): Likewise.
 755         (struct gdbscm_gdb_exception): New.
 756         (unpack): New function.
 757         (gdbscm_wrap): Use unpack.
 758
 759 2019-04-25  Tom Tromey  <tromey@adacore.com>
 760
 761         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 762         (gdb_rl_callback_handler): Use std::move.
 763         * common/common-exceptions.h (struct gdb_exception): Add move
 764         assignment operator.
 765         (throw_exception_sjlj): Change "exception" to const reference.
 766         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 767         (throw_exception_sjlj): Change "exception" to const reference.
 768
 769 2019-04-25  Tom Tromey  <tromey@adacore.com>
 770
 771         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 772         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 773         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 774         Update.
 775         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 776         Update.
 777         * mi/mi-interp.c (mi_interp::exec): Update.
 778         * linespec.c (parse_linespec): Update.
 779         * infcall.c (run_inferior_call): Update.
 780         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 781         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 782         (gdbscm_lookup_global_symbol): Update.
 783         * guile/scm-param.c (gdbscm_parameter_value): Update.
 784         * guile/scm-frame.c (gdbscm_frame_read_register)
 785         (gdbscm_frame_read_var): Update.
 786         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 787         * exec.c (try_open_exec_file): Update.
 788         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 789         (gdb_rl_callback_handler): Update.
 790         * common/common-exceptions.h (exception_none): Don't declare.
 791         * common/common-exceptions.c (exception_none): Don't define.
 792         (struct catcher) <exception>: Update.
 793         * cli/cli-interp.c (safe_execute_command): Update.
 794         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 795
 796 2019-04-25  Ali Tamur  <tamur@google.com>
 797
 798         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 799         (read_attribute_value): Likewise.
 800         (dwarf2_read_addr_index): Update comment.
 801         (read_str_index): Add DW_FORM_strx.
 802         (dwarf2_string_attr): Likewise.
 803         (dwarf2_const_value_attr): Likewise.
 804         (dump_die_shallow): Likewise.
 805         (dwarf2_fetch_constant_bytes): Likewise.
 806         (skip_form_bytes): Likewise.
 807         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 808
 809 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 810
 811         PR corefiles/11608
 812         PR corefiles/18187
 813         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 814         OFFSET.  Verify if current mapping contains an ELF header.
 815         (linux_find_memory_regions_full): Adjust call to
 816         dump_mapping_p.
 817
 818 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 819             Kang Li <kanglictf@gmail.com>
 820
 821         PR gdb/21600
 822
 823         * dwarf2-frame.c (read_initial_length): Be consistent about using
 824         unsigned representation of length.
 825         (decode_frame_entry_1): Likewise.  Check for wraparound of
 826         end pointer as well as buffer overflow.
 827
 828 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 829
 830         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 831         "vq".
 832
 833 2019-04-24  Tom Tromey  <tromey@adacore.com>
 834
 835         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 836
 837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * s12z-tdep.c (s12z_unwind_pc): Delete.
 840         (s12z_unwind_sp): Delete.
 841         (s12z_gdbarch_init): Don't register deleted functions with
 842         gdbarch.
 843
 844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 845
 846         * rl78-tdep.c (rl78_unwind_sp): Delete.
 847         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 848
 849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 852         (xstormy16_unwind_pc): Delete.
 853         (xstormy16_dummy_id): Delete.
 854         (xstormy16_gdbarch_init): Don't register deleted functions with
 855         gdbarch.
 856
 857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * vax-tdep.c (vax_unwind_pc): Delete.
 860         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 861
 862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * v850-tdep.c (v850_unwind_sp): Delete.
 865         (v850_unwind_pc): Delete.
 866         (v850_dummy_id): Delete.
 867         (v850_gdbarch_init): Don't register deleted functions with
 868         gdbarch.
 869
 870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 873         (tilegx_unwind_pc): Delete.
 874         (tilegx_unwind_dummy_id): Delete.
 875         (tilegx_gdbarch_init): Don't register deleted functions with
 876         gdbarch.
 877
 878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 881         (tic6x_dummy_id): Delete.
 882         (tic6x_gdbarch_init): Don't register deleted functions with
 883         gdbarch.
 884
 885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * sparc-tdep.c (sparc_unwind_pc): Delete.
 888         (sparc32_gdbarch_init): Don't register deleted function with
 889         gdbarch.
 890
 891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 892
 893         * sh-tdep.c (sh_unwind_sp): Delete.
 894         (sh_unwind_pc): Delete.
 895         (sh_dummy_id): Delete.
 896         (sh_gdbarch_init): Don't register deleted functions with
 897         gdbarch.
 898
 899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * score-tdep.c (score_unwind_sp): Delete.
 902         (score_unwind_pc): Delete.
 903         (score_dummy_id): Delete.
 904         (score_gdbarch_init): Don't register deleted functions with
 905         gdbarch.
 906
 907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * rx-tdep.c (rx_unwind_pc): Delete.
 910         (rx_unwind_sp): Delete.
 911         (rx_dummy_id): Delete.
 912         (rx_gdbarch_init): Don't register deleted functions with
 913         gdbarch.  Update comment.
 914
 915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 918         (rs6000_dummy_id): Delete.
 919         (rs6000_gdbarch_init): Don't register deleted functions with
 920         gdbarch.
 921
 922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * or1k-tdep.c (or1k_dummy_id): Delete.
 925         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 926
 927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * nios2-tdep.c (nios2_dummy_id): Delete.
 930         (nios2_unwind_sp): Delete.
 931         (nios2_gdbarch_init): Don't register deleted functions with
 932         gdbarch.
 933
 934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * nds32-tdep.c (nds32_dummy_id): Delete.
 937         (nds32_unwind_pc): Delete.
 938         (nds32_unwind_sp): Delete.
 939         (nds32_gdbarch_init): Don't register deleted functions with
 940         gdbarch.
 941
 942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 943
 944         * msp430-tdep.c (msp430_unwind_pc): Delete.
 945         (msp430_unwind_sp): Delete.
 946         (msp430_dummy_id): Delete.
 947         (msp430_gdbarch_init): Don't register deleted functions with
 948         gdbarch.
 949
 950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * moxie-tdep.c (moxie_unwind_sp): Delete.
 953         (moxie_unwind_pc): Delete.
 954         (moxie_dummy_id): Delete.
 955         (moxie_gdbarch_init): Don't register deleted functions with
 956         gdbarch.
 957
 958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 961         (mn10300_unwind_pc): Delete.
 962         (mn10300_unwind_sp): Delete.
 963         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 964         mn10300_unwind_sp.
 965         (mn10300_frame_unwind_init): Don't register deleted functions with
 966         gdbarch.
 967
 968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * mep-tdep.c (mep_unwind_pc): Delete.
 971         (mep_unwind_sp): Delete.
 972         (mep_dummy_id): Delete.
 973         (mep_gdbarch_init): Don't register deleted functions with
 974         gdbarch.
 975
 976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 979         (m68hc11_unwind_sp): Delete.
 980         (m68hc11_gdbarch_init): Don't register deleted functions with
 981         gdbarch.
 982
 983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * m32r-tdep.c (m32r_unwind_sp): Delete.
 986         (m32r_unwind_pc): Delete.
 987         (m32r_dummy_id): Delete.
 988         (m32r_gdbarch_init): Don't register deleted functions with
 989         gdbarch.
 990
 991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * m32c-tdep.c (m32c_unwind_pc): Delete.
 994         (m32c_unwind_sp): Delete.
 995         (m32c_dummy_id): Delete.
 996         (m32c_gdbarch_init): Don't register deleted functions with
 997         gdbarch.
 998
 999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1002         (lm32_unwind_pc): Delete.
1003         (lm32_dummy_id): Delete.
1004         (lm32_gdbarch_init): Don't register deleted functions with
1005         gdbarch.
1006
1007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1010         (iq2000_unwind_pc): Delete.
1011         (iq2000_dummy_id): Delete.
1012         (iq2000_gdbarch_init): Don't register deleted functions with
1013         gdbarch.
1014
1015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * nds32-tdep.c (nds32_type_align): Delete.
1018         (nds32_push_dummy_call): Use type_align instead.
1019
1020 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * arm-tdep.c (arm_type_align): Only handle vector override case.
1023         (arm_push_dummy_call): Use type_align.
1024         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1025
1026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1029         case.
1030         (pass_on_stack): Use type_align.
1031         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1032         function.
1033
1034 2019-04-23  Tom Tromey  <tromey@adacore.com>
1035
1036         * dwarf2read.c (line_header::file_name_at): Remove unused
1037         overload.
1038
1039 2019-04-23  Tom de Vries  <tdevries@suse.de>
1040
1041         PR gdb/24438
1042         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1043         invocation.
1044
1045
1046 2019-03-27  Ali Tamur  <tamur@google.com>
1047
1048         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1049         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1050         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1051         (dwarf_expr_context::get_addr_index): Likewise
1052         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1053         (symbol_needs_eval_context::get_addr_index): Likewise
1054         (disassemble_dwarf_expression): Add DW_OP_addrx
1055         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1056         (read_cutu_die_from_dwo): Update comment
1057         (skip_one_die): Add DW_FORM_addrx
1058         (read_attribute_value): Likewise
1059         (var_decode_location): Add DW_OP_addrx
1060         (dwarf2_const_value_attr): Add DW_FORM_addrx
1061         (dump_die_shallow): Likewise
1062         (dwarf2_fetch_constant_bytes): Likewise
1063         (decode_locdesc): Add DW_OP_addrx
1064         (skip_form_bytes): Add DW_FORM_addrx
1065
1066 2019-04-22  Ali Tamur  <tamur@google.com>
1067
1068         * MAINTAINERS (Write After Approval): Add self.
1069
1070 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1071
1072         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1073         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1074         (open_symbol_file_object): Likewise.
1075         (svr4_default_sos): Add info parameter.
1076         (svr4_read_so_list): Likewise.
1077         (svr4_current_sos_direct): Adjust functions calls to pass down
1078         info.
1079         (svr4_current_sos_1): Add info parameter.
1080         (svr4_current_sos): Call get_svr4_info, pass info down to
1081         svr4_current_sos_1.
1082         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1083         get_svr4_info.
1084         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1085         get_svr4_info.
1086         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1087         to get_svr4_info.
1088         (probes_table_remove_objfile_probes): Likewise.
1089         (register_solib_event_probe): Add info parameter.
1090         (solist_update_incremental): Pass info parameter down to
1091         svr4_read_so_list.
1092         (disable_probes_interface): Add info parameter.
1093         (svr4_handle_solib_event): Pass current_program_space to
1094         get_svr4_info.  Adjust disable_probes_interface cleanup.
1095         (svr4_create_probe_breakpoints): Add info parameter, pass it
1096         down to register_solib_event_probe.
1097         (svr4_create_solib_event_breakpoints): Add info parameter,
1098         pass it down to svr4_create_probe_breakpoints.
1099         (enable_break): Pass info down to
1100         svr4_create_solib_event_breakpoints.
1101         (svr4_solib_create_inferior_hook): Pass current_program_space to
1102         get_svr4_info.
1103         (svr4_clear_solib): Likewise.
1104
1105 2019-04-22  Pedro Alves  <palves@redhat.com>
1106
1107         * solib-svr4.c (svr4_free_objfile_observer): New.
1108         (probe_and_action::objfile): New field.
1109         (probes_table_htab_remove_objfile_probes)
1110         (probes_table_remove_objfile_probes): New functions.
1111         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1112         in the new probe_and_action.  Don't store the probe in 'lookup'.
1113         (svr4_create_probe_breakpoints): Pass objfile to
1114         register_solib_event_probe.
1115         (_initialize_svr4_solib): Register a free_objfile observer.
1116
1117 2019-04-19  Tom Tromey  <tom@tromey.com>
1118
1119         * common/queue.h: Remove.
1120
1121 2019-04-19  Tom Tromey  <tom@tromey.com>
1122
1123         * event-loop.c: Don't include "common/queue.h".
1124
1125 2019-04-19  Tom Tromey  <tom@tromey.com>
1126
1127         * remote.c (remote_target): Use delete.
1128         * remote-notif.h: Include <list>, not "common/queue.h".
1129         (notif_client_p): Remove typedef.
1130         (remote_notif_state): Add constructor, destructor, initializer.
1131         <notif_queue>: Now a std::list.
1132         (remote_notif_state_xfree): Don't declare.
1133         * remote-notif.c (remote_notif_process, handle_notification)
1134         (remote_notif_state_allocate): Update.
1135         (~remote_notif_state): Rename from remote_notif_state_xfree.
1136
1137 2019-04-19  Tom Tromey  <tom@tromey.com>
1138
1139         * symfile.c (reread_symbols): Update.
1140         * objfiles.c (objfile_register_static_link)
1141         (objfile_lookup_static_link): Update
1142         (~objfile) Don't delete static_links.
1143         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1144
1145 2019-04-19  Tom Tromey  <tom@tromey.com>
1146
1147         * type-stack.h (struct type_stack) <insert>: Constify string.
1148         * type-stack.c (type_stack::insert): Constify string.
1149         * gdbtypes.h (lookup_template_type): Update.
1150         (address_space_name_to_int): Update.
1151         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1152         const.
1153         (lookup_template_type): Make name const.
1154         * c-exp.y: Update rules.
1155         (lex_one_token, classify_name, classify_inner_name)
1156         (c_print_token): Update.
1157         * p-exp.y: Update rules.
1158         (yylex): Update.
1159         * f-exp.y: Update rules.
1160         (yylex): Update.
1161         * d-exp.y: Update rules.
1162         (lex_one_token, classify_name, classify_inner_name): Update.
1163         * parse.c (write_dollar_variable, copy_name): Return std::string.
1164         * parser-defs.h (copy_name): Change return type.
1165         * m2-exp.y: Update rules.
1166         (yylex): Update.
1167         * go-exp.y (lex_one_token): Update.
1168         Update rules.
1169         (classify_unsafe_function, classify_packaged_name)
1170         (classify_name, yylex): Update.
1171
1172 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1173
1174         * configure.ac: add --enable-source-highlight switch.
1175         * configure: Regenerate.
1176         * top.c (print_gdb_version): plumb --enable-source-highlight
1177         status to "show configuration".
1178
1179 2019-04-19  Tom Tromey  <tromey@adacore.com>
1180
1181         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1182         Check ADA_TYPE_P.
1183         (empty_record, ada_template_to_fixed_record_type_1)
1184         (template_to_static_fixed_type)
1185         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1186         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1187         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1188         macros.
1189
1190 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1191
1192         PR symtab/24423:
1193         * source.c (print_source_lines_base): Advance "iter" when a
1194         control character is seen.
1195
1196 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1197
1198         * inferior.h (struct infcall_suspend_state_deleter):
1199         Catch exception in destructor to avoid crash.
1200
1201 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1202
1203         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1204         close to the add_com "shell".
1205
1206 2019-04-18  Tom Tromey  <tromey@adacore.com>
1207
1208         * process-stratum-target.h (class process_stratum_target)
1209         <stratum>: Add "final".
1210
1211 2019-04-17  Tom Tromey  <tromey@adacore.com>
1212
1213         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1214         against nullptr before use.
1215
1216 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1217
1218         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1219
1220 2019-04-17  Jim Wilson  <jimw@sifive.com>
1221             Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1224         code read might fail, assume 4-byte breakpoint in that case.
1225
1226 2019-04-15  Leszek Swirski  <leszeks@google.com>
1227
1228         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1229         rather than a hand-rolled POD check when checking for forced MEMORY
1230         classification.
1231
1232 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1233
1234         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1235         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1236         function.
1237         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1238         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1239         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1240         declaration.
1241
1242 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1243
1244         * aarch64-linux-nat.c
1245         (aarch64_linux_nat_target::thread_architecture): Add override.
1246         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1247         each VQ.
1248
1249 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1250
1251         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1252
1253 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1256         target types of size 96-bits, add some additional comments, and
1257         check that the builtin type we found was the correct size.
1258
1259 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1260
1261         * utils.c (prompt_for_continue): Don't restore the styling at the
1262         end, as applied_style has the wrong value.  This fixes styling in
1263         long lists of file names that are interrupted by the "Continue?"
1264         prompt.
1265
1266 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1269         * c-lang.c (c_language_defn): Likewise.
1270         (cplus_language_defn): Likewise.
1271         (asm_language_defn): Likewise.
1272         (minimal_language_defn): Likewise.
1273         * d-lang.c (d_language_defn): Likewise.
1274         * f-lang.c (f_language_defn): Likewise.
1275         * go-lang.c (go_language_defn): Likewise.
1276         * language.c (unknown_language_defn): Likewise.
1277         (auto_language_defn): Likewise.
1278         * language.h (struct language_defn): Remove la_magic field.
1279         (LANG_MAGIC): Delete.
1280         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1281         * objc-lang.c (objc_language_defn): Likewise.
1282         * opencl-lang.c (opencl_language_defn): Likewise.
1283         * p-lang.c (pascal_language_defn): Likewise.
1284         * rust-lang.c (rust_language_defn): Likewise.
1285
1286 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * riscv-tdep.c (riscv_type_align): New function.
1289         (riscv_type_alignment): Delete.
1290         (riscv_arg_location): Use 'type_align'.
1291         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1292
1293 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * gdbtypes.c (type_align): A struct with no non-static fields also
1296         has alignment of 1.
1297
1298 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1301         component to 0.
1302         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1303         member.
1304         (riscv_struct_info::analyse): New implementation using new
1305         analyse_inner member function.
1306         (riscv_struct_info::field_offset): New member function.
1307         (riscv_struct_info::m_offsets): New member variable.
1308         (riscv_struct_info::analyse_inner): New private member function,
1309         takes the old implementation of riscv_struct_info::analyse but
1310         extended to track field offsets.
1311         (riscv_call_arg_struct): Update the struct folding special cases
1312         to handle cases where empty C++ structs, which are non-zero
1313         length, are found.
1314         (riscv_arg_location): Initialise the length of each location, a
1315         non-zero length now indicates the location is in use.
1316         (riscv_push_dummy_call): Allow for the first location having a
1317         non-zero offset when setting up arguments.
1318         (riscv_return_value): Likewise, but for return values.
1319
1320 2019-04-11  Tom Tromey  <tromey@adacore.com>
1321
1322         * utils.c (internal_vproblem): Make "msg" const.
1323
1324 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1325
1326         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1327         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1328         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1329         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1330
1331 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1332
1333         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1334         function.
1335         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1336         of amd64_collect_native_gregset.
1337         (amd64_linux_nat_target::store_registers): Likewise.
1338
1339 2019-04-10  Tom Tromey  <tom@tromey.com>
1340
1341         * symtab.c (lookup_global_symbol_from_objfile)
1342         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1343         * objfiles.h (class separate_debug_iterator): New.
1344         (class separate_debug_range): New.
1345         (struct objfile) <separate_debug_objfiles>: New method.
1346         (objfile_separate_debug_iterate): Don't declare.
1347         * objfiles.c (separate_debug_iterator::operator++): Rename from
1348         objfile_separate_debug_iterate.
1349         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1350         iterator.
1351         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1352         iterator.
1353
1354 2019-04-10  Tom Tromey  <tom@tromey.com>
1355
1356         * symfile.c (reread_symbols): Remove old comment.
1357         * objfiles.c (free_all_objfiles): Fix a typo.
1358
1359 2019-04-10  Tom Tromey  <tom@tromey.com>
1360
1361         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1362         * minsyms.c (lookup_minimal_symbol): Use foreach.
1363         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1364         (lookup_minimal_symbol_solib_trampoline): Likewise.
1365         * symfile.c (reread_symbols): Use foreach.
1366
1367 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1368             Tom Tromey  <tromey@adacore.com>
1369
1370         PR rust/24414:
1371         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1372         (rust_lex_int_test): Change "value" to be LONGEST.
1373         (rust_lex_tests): Add test for long integer literal.
1374
1375 2019-04-09  Tom Tromey  <tromey@adacore.com>
1376
1377         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1378         to bool.
1379         (extended_remote_target::attach): Update.
1380         (remote_target::remote_notice_new_inferior): Update.
1381         (remote_target::add_current_inferior_and_thread): Update.
1382         * inferior.c (exit_inferior_1): Use "false".
1383         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1384
1385 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1386
1387         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1388         the "start" command.
1389
1390 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1391
1392         * python/py-inferior.c (infpy_thread_from_thread_handle):
1393         Adjust comments to reflect renaming of thread_from_thread_handle
1394         to thread_from_handle.  Adjust keywords.  Fix type error message.
1395         (inferior_object_methods): Add thread_from_handle.  Retain
1396         thread_from_thread_handle, but mark it as deprecated.
1397
1398 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1399
1400         * gdbthread.h (find_thread_by_handle): Revise declaration.
1401         * thread.c (find_thread_by_handle): Likewise.  Adjust
1402         implementation too.
1403         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1404         support for buffer objects as handles.
1405
1406 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1407
1408         * python/py-infthread.c (thpy_thread_handle): New function.
1409         (thread_object_methods): Register thpy_thread_handle.
1410
1411 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1412
1413         * gdbthread.h (thread_to_thread_handle): Declare.
1414         * thread.c (gdbtypes.h): Include.
1415         (thread_to_thread_handle): New function.
1416
1417         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1418         (target_thread_info_to_thread_handle): Declare.
1419         * target.c (target_thread_info_to_thread_handle): New function.
1420         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1421         * target-delegates.c: Regenerate.
1422
1423         * linux-thread-db.c (class thread_db_target): Add method
1424         thread_info_to_thread_handle.
1425         (thread_db_target::thread_info_to_thread_handle): Define.
1426         * remote.c (class remote_target): Add new method
1427         thread_info_to_thread_handle.
1428         (remote_target::thread_info_to_thread_handle): Define.
1429
1430 2019-04-08  Pedro Alves  <palves@redhat.com>
1431
1432         * common/common-exceptions.c (throw_exception): Don't create
1433         named object to throw; throw directly.
1434         (throw_it): Likewise.  Don't initialize gdb_exception::message
1435         here, with new; pass FMT and AP to the ctor instead.
1436         * common/common-exceptions.h: Include <string>.
1437         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1438         const char *, va_list)): New ctor.  Use std::make_shared.
1439         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1440         errors)): Delete.
1441         (gdb_exception_error::gdb_exception_error(enum errors, const char
1442         *, va_list)): New.
1443         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1444         Add assertion.
1445         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1446         errors)): Delete.
1447         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1448         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1449         Add assertion.
1450
1451 2019-04-08  Tom Tromey  <tom@tromey.com>
1452
1453         * valops.c (value_rtti_indirect_type): Replace throw_exception
1454         with throw.
1455         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1456         with throw.
1457         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1458         throw.
1459         * target.c (target_translate_tls_address): Replace throw_exception
1460         with throw.
1461         * stack.c (frame_apply_command_count): Replace throw_exception
1462         with throw.
1463         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1464         throw.
1465         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1466         with throw.
1467         * rs6000-tdep.c (rs6000_frame_cache)
1468         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1469         * remote.c: Replace throw_exception with throw.
1470         * record-full.c (record_full_message, record_full_wait_1)
1471         (record_full_restore): Replace throw_exception with throw.
1472         * record-btrace.c:
1473         (get_thread_current_frame_id, record_btrace_start_replaying)
1474         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1475         (cmd_record_btrace_start): Replace throw_exception with throw.
1476         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1477         throw.
1478         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1479         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1480         * linespec.c:
1481         (find_linespec_symbols): Replace throw_exception with throw.
1482         * infrun.c (displaced_step_prepare, resume): Replace
1483         throw_exception with throw.
1484         * infcmd.c (post_create_inferior): Replace throw_exception with
1485         throw.
1486         * inf-loop.c (inferior_event_handler): Replace throw_exception
1487         with throw.
1488         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1489         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1490         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1491         (get_prev_frame_always, get_frame_pc_if_available)
1492         (get_frame_address_in_block_if_available, get_frame_language):
1493         Replace throw_exception with throw.
1494         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1495         throw_exception with throw.
1496         * eval.c (fetch_subexp_value, evaluate_var_value)
1497         (evaluate_funcall, evaluate_subexp_standard): Replace
1498         throw_exception with throw.
1499         * dwarf2loc.c (call_site_find_chain)
1500         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1501         Replace throw_exception with throw.
1502         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1503         with throw.
1504         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1505         throw.
1506         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1507         * completer.c (complete_line_internal): Replace throw_exception
1508         with throw.
1509         * compile/compile-object-run.c (compile_object_run): Replace
1510         throw_exception with throw.
1511         * cli/cli-script.c (process_next_line): Replace throw_exception
1512         with throw.
1513         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1514         (btrace_enable, btrace_maint_update_pt_packets): Replace
1515         throw_exception with throw.
1516         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1517         throw_exception with throw.
1518         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1519         throw_exception with throw.
1520         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1521         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1522         * aarch64-tdep.c (aarch64_make_prologue_cache)
1523         (aarch64_make_stub_cache): Replace throw_exception with throw.
1524
1525 2019-04-08  Tom Tromey  <tom@tromey.com>
1526
1527         * common/common-exceptions.c (throw_exception): Rename from
1528         throw_exception_cxx.  Remove old copy.  Make argument const.
1529         (throw_it): Create and throw exception objects directly.
1530         * common/common-exceptions.h (throw_exception): Make argument
1531         const.
1532         (struct gdb_exception_error): Add constructor.
1533         (struct gdb_exception_quit): Add constructor.
1534
1535 2019-04-08  Tom Tromey  <tom@tromey.com>
1536
1537         * common/common-exceptions.h (exception_rethrow): Don't declare.
1538         (TRY_SJLJ): Update comment.
1539         (TRY, CATCH, END_CATCH): Remove.
1540         * common/common-exceptions.c (exception_rethrow): Remove.
1541
1542 2019-04-08  Tom Tromey  <tom@tromey.com>
1543
1544         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1545         Remove.
1546         (gdb_exception_error): Rename from
1547         gdb_exception_RETURN_MASK_ERROR.
1548         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1549         (gdb_quit_bad_alloc): Update.
1550         * aarch64-tdep.c: Update.
1551         * ada-lang.c: Update.
1552         * ada-typeprint.c: Update.
1553         * ada-valprint.c: Update.
1554         * amd64-tdep.c: Update.
1555         * arch-utils.c: Update.
1556         * break-catch-throw.c: Update.
1557         * breakpoint.c: Update.
1558         * btrace.c: Update.
1559         * c-varobj.c: Update.
1560         * cli/cli-cmds.c: Update.
1561         * cli/cli-interp.c: Update.
1562         * cli/cli-script.c: Update.
1563         * common/common-exceptions.c: Update.
1564         * common/new-op.c: Update.
1565         * common/selftest.c: Update.
1566         * compile/compile-c-symbols.c: Update.
1567         * compile/compile-cplus-symbols.c: Update.
1568         * compile/compile-object-load.c: Update.
1569         * compile/compile-object-run.c: Update.
1570         * completer.c: Update.
1571         * corelow.c: Update.
1572         * cp-abi.c: Update.
1573         * cp-support.c: Update.
1574         * cp-valprint.c: Update.
1575         * darwin-nat.c: Update.
1576         * disasm-selftests.c: Update.
1577         * dtrace-probe.c: Update.
1578         * dwarf-index-cache.c: Update.
1579         * dwarf-index-write.c: Update.
1580         * dwarf2-frame-tailcall.c: Update.
1581         * dwarf2-frame.c: Update.
1582         * dwarf2loc.c: Update.
1583         * dwarf2read.c: Update.
1584         * eval.c: Update.
1585         * event-loop.c: Update.
1586         * event-top.c: Update.
1587         * exec.c: Update.
1588         * f-valprint.c: Update.
1589         * fbsd-tdep.c: Update.
1590         * frame-unwind.c: Update.
1591         * frame.c: Update.
1592         * gdbtypes.c: Update.
1593         * gnu-v3-abi.c: Update.
1594         * guile/guile-internal.h: Update.
1595         * guile/scm-block.c: Update.
1596         * guile/scm-breakpoint.c: Update.
1597         * guile/scm-cmd.c: Update.
1598         * guile/scm-disasm.c: Update.
1599         * guile/scm-frame.c: Update.
1600         * guile/scm-lazy-string.c: Update.
1601         * guile/scm-math.c: Update.
1602         * guile/scm-param.c: Update.
1603         * guile/scm-ports.c: Update.
1604         * guile/scm-pretty-print.c: Update.
1605         * guile/scm-symbol.c: Update.
1606         * guile/scm-symtab.c: Update.
1607         * guile/scm-type.c: Update.
1608         * guile/scm-value.c: Update.
1609         * i386-linux-tdep.c: Update.
1610         * i386-tdep.c: Update.
1611         * inf-loop.c: Update.
1612         * infcall.c: Update.
1613         * infcmd.c: Update.
1614         * infrun.c: Update.
1615         * jit.c: Update.
1616         * language.c: Update.
1617         * linespec.c: Update.
1618         * linux-fork.c: Update.
1619         * linux-nat.c: Update.
1620         * linux-tdep.c: Update.
1621         * linux-thread-db.c: Update.
1622         * main.c: Update.
1623         * mi/mi-cmd-break.c: Update.
1624         * mi/mi-cmd-stack.c: Update.
1625         * mi/mi-interp.c: Update.
1626         * mi/mi-main.c: Update.
1627         * objc-lang.c: Update.
1628         * p-valprint.c: Update.
1629         * parse.c: Update.
1630         * ppc-linux-tdep.c: Update.
1631         * printcmd.c: Update.
1632         * python/py-arch.c: Update.
1633         * python/py-breakpoint.c: Update.
1634         * python/py-cmd.c: Update.
1635         * python/py-finishbreakpoint.c: Update.
1636         * python/py-frame.c: Update.
1637         * python/py-framefilter.c: Update.
1638         * python/py-gdb-readline.c: Update.
1639         * python/py-inferior.c: Update.
1640         * python/py-infthread.c: Update.
1641         * python/py-lazy-string.c: Update.
1642         * python/py-linetable.c: Update.
1643         * python/py-objfile.c: Update.
1644         * python/py-param.c: Update.
1645         * python/py-prettyprint.c: Update.
1646         * python/py-progspace.c: Update.
1647         * python/py-record-btrace.c: Update.
1648         * python/py-record.c: Update.
1649         * python/py-symbol.c: Update.
1650         * python/py-type.c: Update.
1651         * python/py-unwind.c: Update.
1652         * python/py-utils.c: Update.
1653         * python/py-value.c: Update.
1654         * python/python.c: Update.
1655         * record-btrace.c: Update.
1656         * record-full.c: Update.
1657         * remote-fileio.c: Update.
1658         * remote.c: Update.
1659         * riscv-tdep.c: Update.
1660         * rs6000-aix-tdep.c: Update.
1661         * rs6000-tdep.c: Update.
1662         * rust-exp.y: Update.
1663         * rust-lang.c: Update.
1664         * s390-tdep.c: Update.
1665         * selftest-arch.c: Update.
1666         * solib-dsbt.c: Update.
1667         * solib-frv.c: Update.
1668         * solib-spu.c: Update.
1669         * solib-svr4.c: Update.
1670         * solib.c: Update.
1671         * sparc64-linux-tdep.c: Update.
1672         * stack.c: Update.
1673         * symfile-mem.c: Update.
1674         * symmisc.c: Update.
1675         * target.c: Update.
1676         * thread.c: Update.
1677         * top.c: Update.
1678         * tracefile-tfile.c: Update.
1679         * tui/tui.c: Update.
1680         * typeprint.c: Update.
1681         * unittests/cli-utils-selftests.c: Update.
1682         * unittests/parse-connection-spec-selftests.c: Update.
1683         * valops.c: Update.
1684         * valprint.c: Update.
1685         * value.c: Update.
1686         * varobj.c: Update.
1687         * windows-nat.c: Update.
1688         * x86-linux-nat.c: Update.
1689         * xml-support.c: Update.
1690
1691 2019-04-08  Tom Tromey  <tom@tromey.com>
1692
1693         * xml-support.c: Use C++ exception handling.
1694         * x86-linux-nat.c: Use C++ exception handling.
1695         * windows-nat.c: Use C++ exception handling.
1696         * varobj.c: Use C++ exception handling.
1697         * value.c: Use C++ exception handling.
1698         * valprint.c: Use C++ exception handling.
1699         * valops.c: Use C++ exception handling.
1700         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1701         handling.
1702         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1703         * typeprint.c: Use C++ exception handling.
1704         * tui/tui.c: Use C++ exception handling.
1705         * tracefile-tfile.c: Use C++ exception handling.
1706         * top.c: Use C++ exception handling.
1707         * thread.c: Use C++ exception handling.
1708         * target.c: Use C++ exception handling.
1709         * symmisc.c: Use C++ exception handling.
1710         * symfile-mem.c: Use C++ exception handling.
1711         * stack.c: Use C++ exception handling.
1712         * sparc64-linux-tdep.c: Use C++ exception handling.
1713         * solib.c: Use C++ exception handling.
1714         * solib-svr4.c: Use C++ exception handling.
1715         * solib-spu.c: Use C++ exception handling.
1716         * solib-frv.c: Use C++ exception handling.
1717         * solib-dsbt.c: Use C++ exception handling.
1718         * selftest-arch.c: Use C++ exception handling.
1719         * s390-tdep.c: Use C++ exception handling.
1720         * rust-lang.c: Use C++ exception handling.
1721         * rust-exp.y: Use C++ exception handling.
1722         * rs6000-tdep.c: Use C++ exception handling.
1723         * rs6000-aix-tdep.c: Use C++ exception handling.
1724         * riscv-tdep.c: Use C++ exception handling.
1725         * remote.c: Use C++ exception handling.
1726         * remote-fileio.c: Use C++ exception handling.
1727         * record-full.c: Use C++ exception handling.
1728         * record-btrace.c: Use C++ exception handling.
1729         * python/python.c: Use C++ exception handling.
1730         * python/py-value.c: Use C++ exception handling.
1731         * python/py-utils.c: Use C++ exception handling.
1732         * python/py-unwind.c: Use C++ exception handling.
1733         * python/py-type.c: Use C++ exception handling.
1734         * python/py-symbol.c: Use C++ exception handling.
1735         * python/py-record.c: Use C++ exception handling.
1736         * python/py-record-btrace.c: Use C++ exception handling.
1737         * python/py-progspace.c: Use C++ exception handling.
1738         * python/py-prettyprint.c: Use C++ exception handling.
1739         * python/py-param.c: Use C++ exception handling.
1740         * python/py-objfile.c: Use C++ exception handling.
1741         * python/py-linetable.c: Use C++ exception handling.
1742         * python/py-lazy-string.c: Use C++ exception handling.
1743         * python/py-infthread.c: Use C++ exception handling.
1744         * python/py-inferior.c: Use C++ exception handling.
1745         * python/py-gdb-readline.c: Use C++ exception handling.
1746         * python/py-framefilter.c: Use C++ exception handling.
1747         * python/py-frame.c: Use C++ exception handling.
1748         * python/py-finishbreakpoint.c: Use C++ exception handling.
1749         * python/py-cmd.c: Use C++ exception handling.
1750         * python/py-breakpoint.c: Use C++ exception handling.
1751         * python/py-arch.c: Use C++ exception handling.
1752         * printcmd.c: Use C++ exception handling.
1753         * ppc-linux-tdep.c: Use C++ exception handling.
1754         * parse.c: Use C++ exception handling.
1755         * p-valprint.c: Use C++ exception handling.
1756         * objc-lang.c: Use C++ exception handling.
1757         * mi/mi-main.c: Use C++ exception handling.
1758         * mi/mi-interp.c: Use C++ exception handling.
1759         * mi/mi-cmd-stack.c: Use C++ exception handling.
1760         * mi/mi-cmd-break.c: Use C++ exception handling.
1761         * main.c: Use C++ exception handling.
1762         * linux-thread-db.c: Use C++ exception handling.
1763         * linux-tdep.c: Use C++ exception handling.
1764         * linux-nat.c: Use C++ exception handling.
1765         * linux-fork.c: Use C++ exception handling.
1766         * linespec.c: Use C++ exception handling.
1767         * language.c: Use C++ exception handling.
1768         * jit.c: Use C++ exception handling.
1769         * infrun.c: Use C++ exception handling.
1770         * infcmd.c: Use C++ exception handling.
1771         * infcall.c: Use C++ exception handling.
1772         * inf-loop.c: Use C++ exception handling.
1773         * i386-tdep.c: Use C++ exception handling.
1774         * i386-linux-tdep.c: Use C++ exception handling.
1775         * guile/scm-value.c: Use C++ exception handling.
1776         * guile/scm-type.c: Use C++ exception handling.
1777         * guile/scm-symtab.c: Use C++ exception handling.
1778         * guile/scm-symbol.c: Use C++ exception handling.
1779         * guile/scm-pretty-print.c: Use C++ exception handling.
1780         * guile/scm-ports.c: Use C++ exception handling.
1781         * guile/scm-param.c: Use C++ exception handling.
1782         * guile/scm-math.c: Use C++ exception handling.
1783         * guile/scm-lazy-string.c: Use C++ exception handling.
1784         * guile/scm-frame.c: Use C++ exception handling.
1785         * guile/scm-disasm.c: Use C++ exception handling.
1786         * guile/scm-cmd.c: Use C++ exception handling.
1787         * guile/scm-breakpoint.c: Use C++ exception handling.
1788         * guile/scm-block.c: Use C++ exception handling.
1789         * guile/guile-internal.h: Use C++ exception handling.
1790         * gnu-v3-abi.c: Use C++ exception handling.
1791         * gdbtypes.c: Use C++ exception handling.
1792         * frame.c: Use C++ exception handling.
1793         * frame-unwind.c: Use C++ exception handling.
1794         * fbsd-tdep.c: Use C++ exception handling.
1795         * f-valprint.c: Use C++ exception handling.
1796         * exec.c: Use C++ exception handling.
1797         * event-top.c: Use C++ exception handling.
1798         * event-loop.c: Use C++ exception handling.
1799         * eval.c: Use C++ exception handling.
1800         * dwarf2read.c: Use C++ exception handling.
1801         * dwarf2loc.c: Use C++ exception handling.
1802         * dwarf2-frame.c: Use C++ exception handling.
1803         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1804         * dwarf-index-write.c: Use C++ exception handling.
1805         * dwarf-index-cache.c: Use C++ exception handling.
1806         * dtrace-probe.c: Use C++ exception handling.
1807         * disasm-selftests.c: Use C++ exception handling.
1808         * darwin-nat.c: Use C++ exception handling.
1809         * cp-valprint.c: Use C++ exception handling.
1810         * cp-support.c: Use C++ exception handling.
1811         * cp-abi.c: Use C++ exception handling.
1812         * corelow.c: Use C++ exception handling.
1813         * completer.c: Use C++ exception handling.
1814         * compile/compile-object-run.c: Use C++ exception handling.
1815         * compile/compile-object-load.c: Use C++ exception handling.
1816         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1817         * compile/compile-c-symbols.c: Use C++ exception handling.
1818         * common/selftest.c: Use C++ exception handling.
1819         * common/new-op.c: Use C++ exception handling.
1820         * cli/cli-script.c: Use C++ exception handling.
1821         * cli/cli-interp.c: Use C++ exception handling.
1822         * cli/cli-cmds.c: Use C++ exception handling.
1823         * c-varobj.c: Use C++ exception handling.
1824         * btrace.c: Use C++ exception handling.
1825         * breakpoint.c: Use C++ exception handling.
1826         * break-catch-throw.c: Use C++ exception handling.
1827         * arch-utils.c: Use C++ exception handling.
1828         * amd64-tdep.c: Use C++ exception handling.
1829         * ada-valprint.c: Use C++ exception handling.
1830         * ada-typeprint.c: Use C++ exception handling.
1831         * ada-lang.c: Use C++ exception handling.
1832         * aarch64-tdep.c: Use C++ exception handling.
1833
1834 2019-04-08  Tom Tromey  <tom@tromey.com>
1835
1836         * xml-support.c (gdb_xml_parser::parse): Update.
1837         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1838         * value.c (show_convenience): Update.
1839         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1840         (test_parse_flags_qcs): Update.
1841         * thread.c (thr_try_catch_cmd): Update.
1842         * target.c (target_translate_tls_address): Update.
1843         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1844         (info_frame_command_core, frame_apply_command_count): Update.
1845         * rust-exp.y (rust_lex_exception_test): Update.
1846         * riscv-tdep.c (riscv_print_one_register_info): Update.
1847         * remote.c (remote_target::enable_btrace): Update.
1848         * record-btrace.c (record_btrace_enable_warn): Update.
1849         * python/py-utils.c (gdbpy_convert_exception): Update.
1850         * printcmd.c (do_one_display, print_variable_and_value): Update.
1851         * mi/mi-main.c (mi_print_exception): Update.
1852         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1853         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1854         * linux-nat.c (linux_nat_target::attach): Update.
1855         * linux-fork.c (class scoped_switch_fork_info): Update.
1856         * infrun.c (displaced_step_prepare): Update.
1857         * infcall.c (call_function_by_hand_dummy): Update.
1858         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1859         * gnu-v3-abi.c (print_one_vtable): Update.
1860         * frame.c (get_prev_frame_always): Update.
1861         * f-valprint.c (info_common_command_for_block): Update.
1862         * exec.c (try_open_exec_file): Update.
1863         * exceptions.c (print_exception, exception_print)
1864         (exception_fprintf, exception_print_same): Update.
1865         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1866         * dwarf-index-cache.c (index_cache::store)
1867         (index_cache::lookup_gdb_index): Update.
1868         * darwin-nat.c (maybe_cache_shell): Update.
1869         * cp-valprint.c (cp_print_value_fields): Update.
1870         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1871         (gcc_cplus_symbol_address): Update.
1872         * compile/compile-c-symbols.c (gcc_convert_symbol)
1873         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1874         * common/selftest.c: Update.
1875         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1876         a std::string.
1877         (exception_try_scope_entry, exception_try_scope_exit): Don't
1878         declare.
1879         (struct exception_try_scope): Remove.
1880         (TRY): Don't use exception_try_scope.
1881         (struct gdb_exception): Add constructor, operator=.
1882         <what>: New method.
1883         (struct gdb_exception_RETURN_MASK_ALL)
1884         (struct gdb_exception_RETURN_MASK_ERROR)
1885         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1886         (struct gdb_quit_bad_alloc): Update.
1887         * common/common-exceptions.c (exception_none): Change
1888         initializer.
1889         (struct catcher) <state, exception>: Initialize inline.
1890         <prev>: Remove member.
1891         (current_catcher): Remove.
1892         (catchers): New global.
1893         (exceptions_state_mc_init): Simplify.
1894         (catcher_pop): Remove.
1895         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1896         (try_scope_depth, exception_try_scope_entry)
1897         (exception_try_scope_exit): Remove.
1898         (throw_exception_sjlj): Update.
1899         (exception_messages, exception_messages_size): Remove.
1900         (throw_it): Simplify.
1901         (gdb_exception_sliced_copy): Remove.
1902         (throw_exception_cxx): Update.
1903         * cli/cli-script.c (script_from_file): Update.
1904         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1905         Update.
1906         * ada-valprint.c (ada_val_print): Update.
1907         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1908         (create_excep_cond_exprs): Update.
1909
1910 2019-04-08  Tom Tromey  <tom@tromey.com>
1911
1912         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1913         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1914         (TRY, CATCH, END_CATCH): Remove some definitions.
1915         * common/common-exceptions.c: Don't use GDB_XCPT.
1916         (catcher_list_size): Remove.
1917         (throw_exception, throw_it): Simplify.
1918
1919 2019-04-05  Tom Tromey  <tom@tromey.com>
1920
1921         Revert the header-sorting patch.
1922         * ft32-tdep.c: Revert.
1923         * frv-tdep.c: Revert.
1924         * frv-linux-tdep.c: Revert.
1925         * frame.c: Revert.
1926         * frame-unwind.c: Revert.
1927         * frame-base.c: Revert.
1928         * fork-child.c: Revert.
1929         * findvar.c: Revert.
1930         * findcmd.c: Revert.
1931         * filesystem.c: Revert.
1932         * filename-seen-cache.h: Revert.
1933         * filename-seen-cache.c: Revert.
1934         * fbsd-tdep.c: Revert.
1935         * fbsd-nat.h: Revert.
1936         * fbsd-nat.c: Revert.
1937         * f-valprint.c: Revert.
1938         * f-typeprint.c: Revert.
1939         * f-lang.c: Revert.
1940         * extension.h: Revert.
1941         * extension.c: Revert.
1942         * extension-priv.h: Revert.
1943         * expprint.c: Revert.
1944         * exec.h: Revert.
1945         * exec.c: Revert.
1946         * exceptions.c: Revert.
1947         * event-top.c: Revert.
1948         * event-loop.c: Revert.
1949         * eval.c: Revert.
1950         * elfread.c: Revert.
1951         * dwarf2read.h: Revert.
1952         * dwarf2read.c: Revert.
1953         * dwarf2loc.c: Revert.
1954         * dwarf2expr.h: Revert.
1955         * dwarf2expr.c: Revert.
1956         * dwarf2-frame.c: Revert.
1957         * dwarf2-frame-tailcall.c: Revert.
1958         * dwarf-index-write.h: Revert.
1959         * dwarf-index-write.c: Revert.
1960         * dwarf-index-common.c: Revert.
1961         * dwarf-index-cache.h: Revert.
1962         * dwarf-index-cache.c: Revert.
1963         * dummy-frame.c: Revert.
1964         * dtrace-probe.c: Revert.
1965         * disasm.h: Revert.
1966         * disasm.c: Revert.
1967         * disasm-selftests.c: Revert.
1968         * dictionary.c: Revert.
1969         * dicos-tdep.c: Revert.
1970         * demangle.c: Revert.
1971         * dcache.h: Revert.
1972         * dcache.c: Revert.
1973         * darwin-nat.h: Revert.
1974         * darwin-nat.c: Revert.
1975         * darwin-nat-info.c: Revert.
1976         * d-valprint.c: Revert.
1977         * d-namespace.c: Revert.
1978         * d-lang.c: Revert.
1979         * ctf.c: Revert.
1980         * csky-tdep.c: Revert.
1981         * csky-linux-tdep.c: Revert.
1982         * cris-tdep.c: Revert.
1983         * cris-linux-tdep.c: Revert.
1984         * cp-valprint.c: Revert.
1985         * cp-support.c: Revert.
1986         * cp-namespace.c: Revert.
1987         * cp-abi.c: Revert.
1988         * corelow.c: Revert.
1989         * corefile.c: Revert.
1990         * continuations.c: Revert.
1991         * completer.h: Revert.
1992         * completer.c: Revert.
1993         * complaints.c: Revert.
1994         * coffread.c: Revert.
1995         * coff-pe-read.c: Revert.
1996         * cli-out.h: Revert.
1997         * cli-out.c: Revert.
1998         * charset.c: Revert.
1999         * c-varobj.c: Revert.
2000         * c-valprint.c: Revert.
2001         * c-typeprint.c: Revert.
2002         * c-lang.c: Revert.
2003         * buildsym.c: Revert.
2004         * buildsym-legacy.c: Revert.
2005         * build-id.h: Revert.
2006         * build-id.c: Revert.
2007         * btrace.c: Revert.
2008         * bsd-uthread.c: Revert.
2009         * breakpoint.h: Revert.
2010         * breakpoint.c: Revert.
2011         * break-catch-throw.c: Revert.
2012         * break-catch-syscall.c: Revert.
2013         * break-catch-sig.c: Revert.
2014         * blockframe.c: Revert.
2015         * block.c: Revert.
2016         * bfin-tdep.c: Revert.
2017         * bfin-linux-tdep.c: Revert.
2018         * bfd-target.c: Revert.
2019         * bcache.c: Revert.
2020         * ax-general.c: Revert.
2021         * ax-gdb.h: Revert.
2022         * ax-gdb.c: Revert.
2023         * avr-tdep.c: Revert.
2024         * auxv.c: Revert.
2025         * auto-load.c: Revert.
2026         * arm-wince-tdep.c: Revert.
2027         * arm-tdep.c: Revert.
2028         * arm-symbian-tdep.c: Revert.
2029         * arm-pikeos-tdep.c: Revert.
2030         * arm-obsd-tdep.c: Revert.
2031         * arm-nbsd-tdep.c: Revert.
2032         * arm-nbsd-nat.c: Revert.
2033         * arm-linux-tdep.c: Revert.
2034         * arm-linux-nat.c: Revert.
2035         * arm-fbsd-tdep.c: Revert.
2036         * arm-fbsd-nat.c: Revert.
2037         * arm-bsd-tdep.c: Revert.
2038         * arch-utils.c: Revert.
2039         * arc-tdep.c: Revert.
2040         * arc-newlib-tdep.c: Revert.
2041         * annotate.h: Revert.
2042         * annotate.c: Revert.
2043         * amd64-windows-tdep.c: Revert.
2044         * amd64-windows-nat.c: Revert.
2045         * amd64-tdep.c: Revert.
2046         * amd64-sol2-tdep.c: Revert.
2047         * amd64-obsd-tdep.c: Revert.
2048         * amd64-obsd-nat.c: Revert.
2049         * amd64-nbsd-tdep.c: Revert.
2050         * amd64-nbsd-nat.c: Revert.
2051         * amd64-nat.c: Revert.
2052         * amd64-linux-tdep.c: Revert.
2053         * amd64-linux-nat.c: Revert.
2054         * amd64-fbsd-tdep.c: Revert.
2055         * amd64-fbsd-nat.c: Revert.
2056         * amd64-dicos-tdep.c: Revert.
2057         * amd64-darwin-tdep.c: Revert.
2058         * amd64-bsd-nat.c: Revert.
2059         * alpha-tdep.c: Revert.
2060         * alpha-obsd-tdep.c: Revert.
2061         * alpha-nbsd-tdep.c: Revert.
2062         * alpha-mdebug-tdep.c: Revert.
2063         * alpha-linux-tdep.c: Revert.
2064         * alpha-linux-nat.c: Revert.
2065         * alpha-bsd-tdep.c: Revert.
2066         * alpha-bsd-nat.c: Revert.
2067         * aix-thread.c: Revert.
2068         * agent.c: Revert.
2069         * addrmap.c: Revert.
2070         * ada-varobj.c: Revert.
2071         * ada-valprint.c: Revert.
2072         * ada-typeprint.c: Revert.
2073         * ada-tasks.c: Revert.
2074         * ada-lang.c: Revert.
2075         * aarch64-tdep.c: Revert.
2076         * aarch64-ravenscar-thread.c: Revert.
2077         * aarch64-newlib-tdep.c: Revert.
2078         * aarch64-linux-tdep.c: Revert.
2079         * aarch64-linux-nat.c: Revert.
2080         * aarch64-fbsd-tdep.c: Revert.
2081         * aarch64-fbsd-nat.c: Revert.
2082         * aarch32-linux-nat.c: Revert.
2083
2084 2019-04-05  Tom Tromey  <tom@tromey.com>
2085
2086         * ft32-tdep.c: Sort headers.
2087         * frv-tdep.c: Sort headers.
2088         * frv-linux-tdep.c: Sort headers.
2089         * frame.c: Sort headers.
2090         * frame-unwind.c: Sort headers.
2091         * frame-base.c: Sort headers.
2092         * fork-child.c: Sort headers.
2093         * findvar.c: Sort headers.
2094         * findcmd.c: Sort headers.
2095         * filesystem.c: Sort headers.
2096         * filename-seen-cache.h: Sort headers.
2097         * filename-seen-cache.c: Sort headers.
2098         * fbsd-tdep.c: Sort headers.
2099         * fbsd-nat.h: Sort headers.
2100         * fbsd-nat.c: Sort headers.
2101         * f-valprint.c: Sort headers.
2102         * f-typeprint.c: Sort headers.
2103         * f-lang.c: Sort headers.
2104         * extension.h: Sort headers.
2105         * extension.c: Sort headers.
2106         * extension-priv.h: Sort headers.
2107         * expprint.c: Sort headers.
2108         * exec.h: Sort headers.
2109         * exec.c: Sort headers.
2110         * exceptions.c: Sort headers.
2111         * event-top.c: Sort headers.
2112         * event-loop.c: Sort headers.
2113         * eval.c: Sort headers.
2114         * elfread.c: Sort headers.
2115         * dwarf2read.h: Sort headers.
2116         * dwarf2read.c: Sort headers.
2117         * dwarf2loc.c: Sort headers.
2118         * dwarf2expr.h: Sort headers.
2119         * dwarf2expr.c: Sort headers.
2120         * dwarf2-frame.c: Sort headers.
2121         * dwarf2-frame-tailcall.c: Sort headers.
2122         * dwarf-index-write.h: Sort headers.
2123         * dwarf-index-write.c: Sort headers.
2124         * dwarf-index-common.c: Sort headers.
2125         * dwarf-index-cache.h: Sort headers.
2126         * dwarf-index-cache.c: Sort headers.
2127         * dummy-frame.c: Sort headers.
2128         * dtrace-probe.c: Sort headers.
2129         * disasm.h: Sort headers.
2130         * disasm.c: Sort headers.
2131         * disasm-selftests.c: Sort headers.
2132         * dictionary.c: Sort headers.
2133         * dicos-tdep.c: Sort headers.
2134         * demangle.c: Sort headers.
2135         * dcache.h: Sort headers.
2136         * dcache.c: Sort headers.
2137         * darwin-nat.h: Sort headers.
2138         * darwin-nat.c: Sort headers.
2139         * darwin-nat-info.c: Sort headers.
2140         * d-valprint.c: Sort headers.
2141         * d-namespace.c: Sort headers.
2142         * d-lang.c: Sort headers.
2143         * ctf.c: Sort headers.
2144         * csky-tdep.c: Sort headers.
2145         * csky-linux-tdep.c: Sort headers.
2146         * cris-tdep.c: Sort headers.
2147         * cris-linux-tdep.c: Sort headers.
2148         * cp-valprint.c: Sort headers.
2149         * cp-support.c: Sort headers.
2150         * cp-namespace.c: Sort headers.
2151         * cp-abi.c: Sort headers.
2152         * corelow.c: Sort headers.
2153         * corefile.c: Sort headers.
2154         * continuations.c: Sort headers.
2155         * completer.h: Sort headers.
2156         * completer.c: Sort headers.
2157         * complaints.c: Sort headers.
2158         * coffread.c: Sort headers.
2159         * coff-pe-read.c: Sort headers.
2160         * cli-out.h: Sort headers.
2161         * cli-out.c: Sort headers.
2162         * charset.c: Sort headers.
2163         * c-varobj.c: Sort headers.
2164         * c-valprint.c: Sort headers.
2165         * c-typeprint.c: Sort headers.
2166         * c-lang.c: Sort headers.
2167         * buildsym.c: Sort headers.
2168         * buildsym-legacy.c: Sort headers.
2169         * build-id.h: Sort headers.
2170         * build-id.c: Sort headers.
2171         * btrace.c: Sort headers.
2172         * bsd-uthread.c: Sort headers.
2173         * breakpoint.h: Sort headers.
2174         * breakpoint.c: Sort headers.
2175         * break-catch-throw.c: Sort headers.
2176         * break-catch-syscall.c: Sort headers.
2177         * break-catch-sig.c: Sort headers.
2178         * blockframe.c: Sort headers.
2179         * block.c: Sort headers.
2180         * bfin-tdep.c: Sort headers.
2181         * bfin-linux-tdep.c: Sort headers.
2182         * bfd-target.c: Sort headers.
2183         * bcache.c: Sort headers.
2184         * ax-general.c: Sort headers.
2185         * ax-gdb.h: Sort headers.
2186         * ax-gdb.c: Sort headers.
2187         * avr-tdep.c: Sort headers.
2188         * auxv.c: Sort headers.
2189         * auto-load.c: Sort headers.
2190         * arm-wince-tdep.c: Sort headers.
2191         * arm-tdep.c: Sort headers.
2192         * arm-symbian-tdep.c: Sort headers.
2193         * arm-pikeos-tdep.c: Sort headers.
2194         * arm-obsd-tdep.c: Sort headers.
2195         * arm-nbsd-tdep.c: Sort headers.
2196         * arm-nbsd-nat.c: Sort headers.
2197         * arm-linux-tdep.c: Sort headers.
2198         * arm-linux-nat.c: Sort headers.
2199         * arm-fbsd-tdep.c: Sort headers.
2200         * arm-fbsd-nat.c: Sort headers.
2201         * arm-bsd-tdep.c: Sort headers.
2202         * arch-utils.c: Sort headers.
2203         * arc-tdep.c: Sort headers.
2204         * arc-newlib-tdep.c: Sort headers.
2205         * annotate.h: Sort headers.
2206         * annotate.c: Sort headers.
2207         * amd64-windows-tdep.c: Sort headers.
2208         * amd64-windows-nat.c: Sort headers.
2209         * amd64-tdep.c: Sort headers.
2210         * amd64-sol2-tdep.c: Sort headers.
2211         * amd64-obsd-tdep.c: Sort headers.
2212         * amd64-obsd-nat.c: Sort headers.
2213         * amd64-nbsd-tdep.c: Sort headers.
2214         * amd64-nbsd-nat.c: Sort headers.
2215         * amd64-nat.c: Sort headers.
2216         * amd64-linux-tdep.c: Sort headers.
2217         * amd64-linux-nat.c: Sort headers.
2218         * amd64-fbsd-tdep.c: Sort headers.
2219         * amd64-fbsd-nat.c: Sort headers.
2220         * amd64-dicos-tdep.c: Sort headers.
2221         * amd64-darwin-tdep.c: Sort headers.
2222         * amd64-bsd-nat.c: Sort headers.
2223         * alpha-tdep.c: Sort headers.
2224         * alpha-obsd-tdep.c: Sort headers.
2225         * alpha-nbsd-tdep.c: Sort headers.
2226         * alpha-mdebug-tdep.c: Sort headers.
2227         * alpha-linux-tdep.c: Sort headers.
2228         * alpha-linux-nat.c: Sort headers.
2229         * alpha-bsd-tdep.c: Sort headers.
2230         * alpha-bsd-nat.c: Sort headers.
2231         * aix-thread.c: Sort headers.
2232         * agent.c: Sort headers.
2233         * addrmap.c: Sort headers.
2234         * ada-varobj.c: Sort headers.
2235         * ada-valprint.c: Sort headers.
2236         * ada-typeprint.c: Sort headers.
2237         * ada-tasks.c: Sort headers.
2238         * ada-lang.c: Sort headers.
2239         * aarch64-tdep.c: Sort headers.
2240         * aarch64-ravenscar-thread.c: Sort headers.
2241         * aarch64-newlib-tdep.c: Sort headers.
2242         * aarch64-linux-tdep.c: Sort headers.
2243         * aarch64-linux-nat.c: Sort headers.
2244         * aarch64-fbsd-tdep.c: Sort headers.
2245         * aarch64-fbsd-nat.c: Sort headers.
2246         * aarch32-linux-nat.c: Sort headers.
2247
2248 2019-04-04  Tom Tromey  <tom@tromey.com>
2249
2250         * varobj.c (varobj_create): Update.
2251         * rust-exp.y (struct rust_parser) <update_innermost_block,
2252         lookup_symbol>: New methods.
2253         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2254         Rename.
2255         (rust_parser::rust_lookup_type)
2256         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2257         * printcmd.c (display_command, do_one_display): Update.
2258         * parser-defs.h (struct parser_state) <parser_state>: Add
2259         "tracker" parameter.
2260         (block_tracker): New member.
2261         (class innermost_block_tracker) <innermost_block_tracker>: Add
2262         "types" parameter.
2263         <reset>: Remove method.
2264         (innermost_block): Don't declare.
2265         (null_post_parser): Update.
2266         * parse.c (innermost_block): Remove global.
2267         (write_dollar_variable): Update.
2268         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2269         Remove "tracker_types" parameter.
2270         (parse_expression): Add "tracker" parameter.
2271         (parse_expression_for_completion): Update.
2272         (null_post_parser): Add "tracker" parameter.
2273         * p-exp.y: Update rules.
2274         * m2-exp.y: Update rules.
2275         * language.h (struct language_defn) <la_post_parser>: Add
2276         "tracker" parameter.
2277         * go-exp.y: Update rules.
2278         * f-exp.y: Update rules.
2279         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2280         parameter.
2281         * d-exp.y: Update rules.
2282         * c-exp.y: Update rules.
2283         * breakpoint.c (set_breakpoint_condition): Create an
2284         innermost_block_tracker.
2285         (watch_command_1): Likewise.
2286         * ada-lang.c (resolve): Add "tracker" parameter.
2287         (resolve_subexp): Likewise.
2288         * ada-exp.y (write_var_from_sym): Update.
2289
2290 2019-04-04  Tom Tromey  <tom@tromey.com>
2291
2292         * type-stack.h: New file.
2293         * type-stack.c: New file.
2294         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2295         type-stack.h.
2296         (insert_into_type_stack, insert_type, push_type, push_type_int)
2297         (insert_type_address_space, pop_type, pop_type_int)
2298         (pop_typelist, pop_type_stack, append_type_stack)
2299         (push_type_stack, get_type_stack, push_typelist)
2300         (follow_type_instance_flags, follow_types): Don't declare.
2301         * parse.c (type_stack): Remove global.
2302         (parse_exp_in_context): Update.
2303         (insert_into_type_stack, insert_type, push_type, push_type_int)
2304         (insert_type_address_space, pop_type, pop_type_int)
2305         (pop_typelist, pop_type_stack, append_type_stack)
2306         (push_type_stack, get_type_stack, push_typelist)
2307         (follow_type_instance_flags, follow_types): Remove (moved to
2308         type-stack.c).
2309         * f-exp.y (type_stack): New global.
2310         Update rules.
2311         (push_kind_type, f_parse): Update.
2312         * d-exp.y (type_stack): New global.
2313         Update rules.
2314         (d_parse): Update.
2315         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2316         Update rules.
2317         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2318         (HFILES_NO_SRCDIR): Add type-stack.h.
2319
2320 2019-04-04  Tom Tromey  <tom@tromey.com>
2321
2322         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2323         (rust_parser::convert_ast_to_expression, rust_parse)
2324         (rust_lex_test_completion, rust_lex_tests): Update.
2325         * parser-defs.h (struct expr_completion_state): New.
2326         (struct parser_state) <parser_state>: Add completion parameter.
2327         <mark_struct_expression, mark_completion_tag>: New methods.
2328         <parse_completion, m_completion_state>: New members.
2329         (prefixify_expression, null_post_parser): Update.
2330         (mark_struct_expression, mark_completion_tag): Don't declare.
2331         * parse.c (parse_completion, expout_last_struct)
2332         (expout_tag_completion_type, expout_completion_name): Remove
2333         globals.
2334         (parser_state::mark_struct_expression)
2335         (parser_state::mark_completion_tag): Now methods.
2336         (prefixify_expression): Add last_struct parameter.
2337         (prefixify_subexp): Likewise.
2338         (parse_exp_1): Update.
2339         (parse_exp_in_context): Add cstate parameter.  Update.
2340         (parse_expression_for_completion): Create an
2341         expr_completion_state.
2342         (null_post_parser): Add "completion" parameter.
2343         * p-exp.y: Update rules.
2344         (yylex): Update.
2345         * language.h (struct language_defn) <la_post_parser>: Add
2346         "completing" parameter.
2347         * go-exp.y: Update rules.
2348         (lex_one_token): Update.
2349         * expression.h (parse_completion): Don't declare.
2350         * d-exp.y: Update rules.
2351         (lex_one_token): Update rules.
2352         * c-exp.y: Update rules.
2353         (lex_one_token): Update.
2354         * ada-lang.c (resolve): Add "parse_completion" parameter.
2355         (resolve_subexp): Likewise.
2356         (ada_resolve_function): Likewise.
2357
2358 2019-04-04  Tom Tromey  <tom@tromey.com>
2359
2360         * parser-defs.h (struct parser_state) <start_arglist,
2361         end_arglist>: New methods.
2362         <arglist_len, m_funcall_chain>: New members.
2363         (arglist_len, start_arglist, end_arglist): Don't declare.
2364         * parse.c (arglist_len, funcall_chain): Remove global.
2365         (start_arglist, end_arglist): Remove functions.
2366         (parse_exp_in_context): Update.
2367         * p-exp.y: Update rules.
2368         * m2-exp.y: Update rules.
2369         * go-exp.y: Update rules.
2370         * f-exp.y: Update rules.
2371         * d-exp.y: Update rules.
2372         * c-exp.y: Update rules.
2373
2374 2019-04-04  Tom Tromey  <tom@tromey.com>
2375
2376         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2377         lex_operator, push_back>: New methods.
2378         Update all rules.
2379         (rust_parser::lex_hex, lex_escape): Rename and update.
2380         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2381         (rust_parser::lex_operator): Rename and update.
2382         (rust_parser::lex_number, rustyylex, rustyyerror)
2383         (rust_lex_test_init, rust_lex_test_sequence)
2384         (rust_lex_test_push_back, rust_lex_tests): Update.
2385         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2386         parameter.
2387         <lexptr, prev_lexptr>: New members.
2388         (lexptr, prev_lexptr): Don't declare.
2389         * parse.c (lexptr, prev_lexptr): Remove globals.
2390         (parse_exp_in_context): Update.
2391         * p-exp.y (yylex, yyerror): Update.
2392         * m2-exp.y (parse_number, yylex, yyerror): Update.
2393         * go-exp.y (lex_one_token, yyerror): Update.
2394         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2395         * d-exp.y (lex_one_token, yyerror): Update.
2396         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2397         (lex_one_token, yyerror): Update.
2398         * ada-lex.l (YY_INPUT): Update.
2399         (rewind_to_char): Update.
2400         * ada-exp.y (yyerror): Update.
2401
2402 2019-04-04  Tom Tromey  <tom@tromey.com>
2403
2404         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2405         * parser-defs.h (struct parser_state) <parser_state>: Add new
2406         parameter.
2407         <comma_terminates>: New member.
2408         (comma_terminates): Don't declare global.
2409         * parse.c (comma_terminates): Remove global.
2410         (parse_exp_in_context): Update.
2411         * p-exp.y (yylex): Update.
2412         * m2-exp.y (yylex): Update.
2413         * go-exp.y (lex_one_token): Update.
2414         * f-exp.y (yylex): Update.
2415         * d-exp.y (lex_one_token): Update.
2416         * c-exp.y (lex_one_token): Update.
2417         * ada-lex.l: Update.
2418
2419 2019-04-04  Tom Tromey  <tom@tromey.com>
2420
2421         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2422         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2423         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2424         * parser-defs.h (paren_depth): Don't declare.
2425         * parse.c (paren_depth): Remove global.
2426         (parse_exp_in_context): Update.
2427         * p-exp.y (paren_depth): New global.
2428         (pascal_parse): Initialize it.
2429         * m2-exp.y (paren_depth): New global.
2430         (m2_parse): Initialize it.
2431         * go-exp.y (paren_depth): New global.
2432         (go_parse): Initialize it.
2433         * f-exp.y (paren_depth): New global.
2434         (f_parse): Initialize it.
2435         * d-exp.y (paren_depth): New global.
2436         (d_parse): Initialize it.
2437         * c-exp.y (paren_depth): New global.
2438         (c_parse): Initialize it.
2439         * ada-lex.l (paren_depth): New global.
2440         (lexer_init): Initialize it.
2441
2442 2019-04-04  Tom Tromey  <tom@tromey.com>
2443
2444         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2445         (rust_parser::convert_ast_to_type)
2446         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2447         * parser-defs.h (struct parser_state) <parser_state>: Add
2448         parameters.  Initialize new members.
2449         <expression_context_block, expression_context_pc>: New members.
2450         * parse.c (expression_context_block, expression_context_pc):
2451         Remove globals.
2452         (parse_exp_in_context): Update.
2453         * p-exp.y: Update all rules.
2454         (yylex): Update.
2455         * m2-exp.y: Update all rules.
2456         (yylex): Update.
2457         * go-exp.y (yylex): Update.
2458         * f-exp.y (yylex): Update.
2459         * d-exp.y: Update all rules.
2460         (yylex): Update.
2461         * c-exp.y: Update all rules.
2462         (lex_one_token, classify_name, yylex, c_parse): Update.
2463         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2464
2465 2019-04-04  Tom Tromey  <tom@tromey.com>
2466
2467         * gdbarch.h, gdbarch.c: Rebuild.
2468         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2469         * stap-probe.h:
2470         (struct stap_parse_info): Replace "parser_state" with
2471         "expr_builder".
2472         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2473         (parser_state): New class.
2474         * parse.c (expr_builder): Rename.
2475         (expr_builder::release): Rename.
2476         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2477         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2478         (write_exp_elt_longcst, write_exp_elt_floatcst)
2479         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2480         (write_exp_string_vector, write_exp_bitstring)
2481         (write_exp_msymbol, mark_struct_expression)
2482         (write_dollar_variable)
2483         (insert_type_address_space, increase_expout_size): Replace
2484         "parser_state" with "expr_builder".
2485         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2486         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2487         "parser_state" with "expr_builder".
2488
2489 2019-04-04  Tom Tromey  <tom@tromey.com>
2490
2491         * rust-exp.y: Replace "parse_language" with method call.
2492         * p-exp.y:
2493         (yylex): Replace "parse_language" with method call.
2494         * m2-exp.y:
2495         (yylex): Replace "parse_language" with method call.
2496         * go-exp.y (classify_name): Replace "parse_language" with method
2497         call.
2498         * f-exp.y (yylex): Replace "parse_language" with method call.
2499         * d-exp.y (lex_one_token): Replace "parse_language" with method
2500         call.
2501         * c-exp.y:
2502         (lex_one_token, classify_name, yylex): Replace "parse_language"
2503         with method call.
2504         * ada-exp.y (find_primitive_type, type_char)
2505         (type_system_address): Replace "parse_language" with method call.
2506
2507 2019-04-04  Tom Tromey  <tom@tromey.com>
2508
2509         * rust-exp.y: Replace "parse_gdbarch" with method call.
2510         * parse.c (write_dollar_variable, insert_type_address_space):
2511         Replace "parse_gdbarch" with method call.
2512         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2513         call.
2514         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2515         call.
2516         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2517         "parse_gdbarch" with method call.
2518         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2519         with method call.
2520         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2521         "parse_gdbarch" with method call.
2522         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2523         "parse_gdbarch" with method call.
2524         * c-exp.y (parse_type, parse_number, classify_name): Replace
2525         "parse_gdbarch" with method call.
2526         * ada-lex.l: Replace "parse_gdbarch" with method call.
2527         * ada-exp.y (parse_type, find_primitive_type, type_char)
2528         (type_system_address): Replace "parse_gdbarch" with method call.
2529
2530 2019-04-04  Tom Tromey  <tom@tromey.com>
2531
2532         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2533         * stap-probe.c (stap_parse_argument): Update.
2534         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2535         initial_size parameter.
2536         * rust-exp.y (rust_lex_tests): Update.
2537         * parse.c (parser_state): Update.
2538         (parse_exp_in_context): Update.
2539         * parser-defs.h (struct parser_state) <parser_state>: Remove
2540         "initial_size" parameter.
2541
2542 2019-04-04  Tom Tromey  <tom@tromey.com>
2543
2544         * parser-defs.h (increase_expout_size): Don't declare.
2545         * parse.c (increase_expout_size): Now static.
2546
2547 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2548
2549         * gnu-nat.c (gnu_nat_target::wait): Fix
2550         target_waitstatus_to_string call.
2551
2552 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * eval.c (evaluate_subexp_standard): Handle internal functions
2555         during Fortran function call handling.
2556
2557 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * NEWS: Mention new internal functions.
2560         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2561         (read_base_type): Use dwarf2_init_complex_target_type.
2562         * value.c (creal_internal_fn): New function.
2563         (cimag_internal_fn): New function.
2564         (_initialize_values): Register new internal functions.
2565
2566 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2567
2568         * infrun.c (stop_all_threads): If debug_infrun, always
2569         trace the wait status after wait_one, using
2570         target_waitstatus_to_string and target_pid_to_str.
2571         (handle_inferior_event): Replace various trace of
2572         wait status kind by a single trace.
2573         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2574         wait status kind image by target_waitstatus_to_string.
2575         * target/waitstatus.c (target_waitstatus_to_string): Fix
2576         obsolete comment.
2577
2578 2019-04-01  Tom Tromey  <tromey@adacore.com>
2579
2580         PR symtab/23331:
2581         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2582
2583 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2584             Pedro Alves  <palves@redhat.com>
2585
2586         * top.c (quit_force): Call 'finalize_values'.
2587         * value.c (finalize_values): New function.
2588         * value.h (finalize_values): Declare.
2589
2590 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2591
2592         * NEWS: Announce $_gdb_major and $_gdb_minor.
2593
2594         * top.c (init_gdb_version_vars): New function.
2595         (gdb_init): Call init_gdb_version_vars.
2596
2597 2019-03-29  Tom Tromey  <tromey@adacore.com>
2598
2599         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2600         help text.  Remove dead code.
2601
2602 2019-03-29  Keith Seitz  <keiths@redhat.com>
2603
2604         From Siddhesh Poyarekar:
2605         * f-lang.h (f77_get_upperbound): Return LONGEST.
2606         (f77_get_lowerbound): Likewise.
2607         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2608         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2609         print them.
2610         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2611         plongest to format print it.
2612         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2613         (f77_get_upperbound): Likewise.
2614         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2615         LOWER_BOUND to LONGEST.
2616         (f77_create_arrayprint_offset_tbl): Likewise.
2617
2618 2019-03-29  Keith Seitz  <keiths@redhat.com>
2619
2620         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2621         %s/pulongest for TYPE_LENGTH instead of %d in format
2622         strings.
2623         * ada-typerint.c (ada_print_type): Likewise.
2624         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2625         * compile/compile-c-support.c (generate_register_struct): Likewise.
2626         * gdbtypes.c (recursive_dump_type): Likewise.
2627         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2628         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2629         instead of %d in format strings.
2630         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2631         to std::min to ULONGEST.
2632         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2633         instead of %d in format strings.
2634         * tracepoint.c (info_scope_command): Likewise.
2635         * typeprint.c (print_offset_data::update)
2636         (print_offset_data::finish): Likewise.
2637         * xtensa-tdep.c (xtensa_store_return_value)
2638         (xtensa_push_dummy_call): Likewise.
2639
2640 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2641
2642         * windows-nat.c (display_selector): Fixed format specifications
2643         for 64-bit Cygwin.
2644
2645 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2646
2647         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2648
2649 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2650
2651         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2652         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2653         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2654         (nios2_linux_init_abi): Install it.
2655
2656 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2659
2660 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2661
2662         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2663
2664 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2665             Tom Tromey  <tromey@adacore.com>
2666
2667         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2668
2669 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2670
2671         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2672         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2673         method to compute the bounds of range types. Also print "[evaluated]"
2674         if the bounds' values come from a dynamic evaluation.
2675
2676 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2679         whitespace when pretty printing is on.
2680
2681 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2682
2683         * ppc-linux-nat.c: Add include.
2684
2685 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2686
2687         * NEWS: Mention AArch64 Pointer Authentication.
2688
2689 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2690
2691         * arm-linux-nat.c: Add include.
2692
2693 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2694
2695         * source-cache.c (source_cache::get_source_lines): Re-read
2696         fullname after calling open_source_file.
2697
2698 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2699
2700         * NEWS: Mention TLS support for FreeBSD.
2701
2702 2019-03-25  Tom Tromey  <tromey@adacore.com>
2703
2704         * minsyms.c (BUNCH_SIZE): Update comment.
2705         (~minimal_symbol_reader): Remove old comment.
2706         (compact_minimal_symbols): Update comment.
2707         (minimal_symbol_reader::install): Remove old comment.  Update
2708         other comments.
2709
2710 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2711
2712         * s390-linux-nat.c: Add include.
2713
2714 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2717         Call linux_get_hwcap.
2718         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2719         Likewise.
2720         (aarch64_linux_get_hwcap): Remove function.
2721         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2722         declaration.
2723         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2724         linux_get_hwcap.
2725         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2726         * linux-tdep.c (linux_get_hwcap): Add function.
2727         (linux_get_hwcap2): Likewise.
2728         * linux-tdep.h (linux_get_hwcap): Add declaration.
2729         (linux_get_hwcap2): Likewise.
2730         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2731         (ppc_linux_get_hwcap2): Likewise.
2732         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2733         linux_get_hwcap.
2734         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2735         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2736         (ppc_linux_nat_target::read_description): Likewise.
2737         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2738         * s390-linux-nat.c: Likewise.
2739         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2740
2741 2019-03-24  Tom Tromey  <tom@tromey.com>
2742
2743         * ada-lang.c (standard_lookup): Simplify initialization.
2744         (ada_lookup_symbol_nonlocal): Simplify return.
2745         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2746         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2747         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2748         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2749         initialization.
2750         * solib.c (solib_global_lookup): Simplify.
2751         * symtab.c (null_block_symbol): Remove.
2752         (symbol_cache_lookup): Simplify returns.
2753         (lookup_language_this): Simplify returns.
2754         (lookup_symbol_aux): Simplify return.
2755         (lookup_local_symbol): Simplify returns.
2756         (lookup_global_symbol_from_objfile): Simplify return.
2757         (lookup_symbol_in_objfile_symtabs)
2758         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2759         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2760         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2761         * cp-namespace.c (cp_lookup_bare_symbol)
2762         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2763         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2764         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2765         (cp_lookup_symbol_via_imports): Simplify initialization.
2766         (find_symbol_in_baseclass): Likewise.
2767         * symtab.h (null_block_symbol): Remove.
2768         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2769         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2770         (d_lookup_symbol_module): Likewise.
2771         (find_symbol_in_baseclass): Simplify initialization.
2772
2773 2019-03-24  Tom Tromey  <tom@tromey.com>
2774
2775         * expression.h: Don't include symtab.h.
2776         (struct block): Forward declare.
2777
2778 2019-03-24  Tom Tromey  <tom@tromey.com>
2779
2780         * c-exp.y (typebase): Remove casts.
2781         * gdbtypes.c (lookup_unsigned_typename, )
2782         (lookup_signed_typename): Remove cast.
2783         * eval.c (parse_to_comma_and_eval): Remove cast.
2784         * parse.c (write_dollar_variable): Remove cast.
2785         * block.h (struct block) <superblock>: Now const.
2786         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2787         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2788         (map_block): Make "block" const.
2789         * symfile.h (struct quick_symbol_functions)
2790         <map_matching_symbols>: Constify block argument to "callback".
2791         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2792         const.
2793         (find_pc_sect_compunit_symtab): Make "b" const.
2794         (find_symbol_at_address): Likewise.
2795         (search_symbols): Likewise.
2796         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2797         (dw2_debug_names_lookup_symbol): Likewise.
2798         (dw2_map_matching_symbols): Update.
2799         * p-valprint.c (pascal_val_print): Remove "block".
2800         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2801         (aux_add_nonlocal_symbols): Make "block" const.
2802         (resolve_subexp): Remove cast.
2803         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2804         const.
2805         (iterate_over_file_blocks): Likewise.
2806         * f-exp.y (%union) <bval>: Remove.
2807         * coffread.c (patch_opaque_types): Make "b" const.
2808         * spu-tdep.c (spu_catch_start): Make "block" const.
2809         * c-valprint.c (print_unpacked_pointer): Remove "block".
2810         * symmisc.c (dump_symtab_1): Make "b" const.
2811         (block_depth): Make "block" const.
2812         * d-exp.y (%union) <bval>: Remove.
2813         * cp-support.h (cp_lookup_rtti_type): Update.
2814         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2815         * psymtab.c (psym_lookup_symbol): Make "block" const.
2816         (maintenance_check_psymtabs): Make "b" const.
2817         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2818         (enumerate_locals, enumerate_args): Update.
2819         * python/py-symtab.c (stpy_global_block): Make "block" const.
2820         (stpy_static_block): Likewise.
2821         * inline-frame.c (block_starting_point_at): Make "new_block"
2822         const.
2823         * block.c (find_block_in_blockvector): Make return type const.
2824         (blockvector_for_pc_sect): Make "b" const.
2825         (find_block_in_blockvector): Make "b" const.
2826
2827 2019-03-23  Tom Tromey  <tom@tromey.com>
2828
2829         * varobj.c (varobj_create): Update.
2830         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2831         * printcmd.c (display_command, do_one_display): Don't reset
2832         innermost_block.
2833         * parser-defs.h (enum innermost_block_tracker_type): Move to
2834         expression.h.
2835         (innermost_block): Update comment.
2836         * parse.c (parse_exp_1): Add tracker_types parameter.
2837         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2838         tracker_types parameter.  Reset innermost_block.
2839         (parse_exp_in_context): Remove.
2840         (parse_expression_for_completion): Update.
2841         * objfiles.c (~objfile): Don't reset expression_context_block or
2842         innermost_block.
2843         * expression.h (enum innermost_block_tracker_type): Move from
2844         parser-defs.h.
2845         (parse_exp_1): Add tracker_types parameter.
2846         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2847         reset innermost_block.
2848
2849 2019-03-23  Tom Tromey  <tom@tromey.com>
2850
2851         * objfiles.h: Include bcache.h.
2852
2853 2019-03-23  Tom Tromey  <tom@tromey.com>
2854
2855         * linespec.c (get_current_search_block): Use
2856         scoped_restore_current_language.
2857         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2858
2859 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2860             Jiong Wang  <jiong.wang@arm.com>
2861
2862         * aarch64-linux-tdep.c
2863         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2864         section.
2865         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2866
2867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2868             Jiong Wang  <jiong.wang@arm.com>
2869
2870         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2871         instructions.
2872         (aarch64_analyze_prologue_test): Add PACIASP test.
2873         (aarch64_prologue_prev_register): Unmask PC value.
2874
2875 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2876             Jiong Wang  <jiong.wang@arm.com>
2877
2878         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2879         (aarch64_dwarf2_prev_register): Unmask PC value.
2880         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2881         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2882         DW_CFA_AARCH64_negate_ra_state.
2883         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2884
2885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2886             Jiong Wang  <jiong.wang@arm.com>
2887
2888         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2889         registers.
2890         (aarch64_pseudo_register_name): Likewise.
2891         (aarch64_pseudo_register_type): Likewise.
2892         (aarch64_pseudo_register_reggroup_p): Likewise.
2893         (aarch64_gdbarch_init): Add pauth registers.
2894         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2895         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2896         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2897         (struct gdbarch_tdep): Add regnum for ra_state.
2898
2899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2900             Jiong Wang  <jiong.wang@arm.com>
2901
2902         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2903
2904 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2905             Jiong Wang  <jiong.wang@arm.com>
2906
2907         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2908         function.
2909         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2910         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2911         (aarch64_gdbarch_init): Add puth registers.
2912         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2913         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2914         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2915
2916 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2917             Jiong Wang  <jiong.wang@arm.com>
2918
2919         * aarch64-linux-nat.c
2920         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2921         * aarch64-linux-tdep.c
2922         (aarch64_linux_core_read_description): Likewise.
2923         (aarch64_linux_get_hwcap): New function.
2924         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2925         (aarch64_linux_get_hwcap): New declaration.
2926
2927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2928             Jiong Wang  <jiong.wang@arm.com>
2929
2930         * aarch64-linux-nat.c
2931         (aarch64_linux_nat_target::read_description): Add pauth param.
2932         * aarch64-linux-tdep.c
2933         (aarch64_linux_core_read_description): Likewise.
2934         * aarch64-tdep.c (struct target_desc): Add in pauth.
2935         (aarch64_read_description): Add pauth param.
2936         (aarch64_gdbarch_init): Likewise.
2937         * aarch64-tdep.h (aarch64_read_description): Likewise.
2938         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2939         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2940         * features/Makefile: Add new files.
2941         * features/aarch64-pauth.c: New file.
2942         * features/aarch64-pauth.xml: New file.
2943
2944 2019-03-20  Tom Tromey  <tromey@adacore.com>
2945
2946         * infrun.c (handle_inferior_event): Rename from
2947         handle_inferior_event_1.  Create a scoped_value_mark.
2948         (handle_inferior_event): Remove.
2949
2950 2019-03-19  Tom Tromey  <tromey@adacore.com>
2951
2952         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2953         * infrun.h (print_stop_event): Add "displays" parameter.
2954         * infrun.c (print_stop_event): Add "displays" parameter.
2955
2956 2019-03-19  Pedro Alves  <palves@redhat.com>
2957
2958         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2959         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2960         to -1.  Fix TABs vs spaces.
2961         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2962         * tui/tui-out.h (tui_ui_out) Add intro comments.
2963         <m_line, m_start_of_line>: In-class initialize, and add describing
2964         comment.
2965
2966 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2967
2968         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2969         variable names.
2970         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2971
2972 2019-03-18  Pedro Alves  <palves@redhat.com>
2973             Eli Zaretskii <eliz@gnu.org>
2974
2975         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2976         m_line and m_start_of_line.
2977
2978 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2979
2980         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2981         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2982         it returns a newline.  This fixes a regression in TU mode, whereby
2983         the next line is output on the same screen line as the user input.
2984
2985 2019-03-18  Tom Tromey  <tromey@adacore.com>
2986
2987         * minsyms.c (minimal_symbol_reader::install): Remove call to
2988         obstack_blank.
2989
2990 2019-03-18  Pedro Alves  <palves@redhat.com>
2991
2992         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2993         New globals.
2994         (apply_style): New, factored out from ...
2995         (apply_ansi_escape): ... this.  Handle reverse video mode.
2996         (tui_set_reverse_mode): New function.
2997         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2998         * tui/tui-winsource.c (tui_show_source_line): Use
2999         tui_set_reverse_mode instead of setting A_STANDOUT.
3000         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3001         New setter methods.
3002
3003 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3004
3005         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3006         Handle tabs.
3007
3008 2019-03-18  Tom Tromey  <tromey@adacore.com>
3009
3010         * ada-lang.c (empty_array): Add "high" parameter.
3011         (ada_evaluate_subexp): Update.
3012
3013 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3014
3015         * unittests/string_view-selftests.c: Define
3016         _initialize_string_view_selftests unconditionally.
3017
3018 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3019
3020         PR gdb/24350
3021         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3022
3023 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3024
3025         PR gdb/24351
3026         * windows-nat.c (display_selector): Fix format specifiers.
3027
3028 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3029
3030         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3031         tui_refill_source_window instead of tui_refresh_win, to update the
3032         current execution line.  This fixes redisplay of the current line
3033         when stepping through the code with "next" or "step".
3034
3035 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3036
3037         * source-cache.c (source_cache::get_source_lines): Call
3038         find_source_lines to initialize s->nlines.  This fixes vertical
3039         scrolling of TUI source window when the DOWN arrow is pressed.
3040
3041 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3042
3043         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3044         linux-thread-db.c (_initialize_thread_db): Likewise.
3045
3046 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3047
3048         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3049         wclrtoeol in tui_show_source_line".  This reverts changes made in
3050         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3051
3052 2019-03-15  Tom Tromey  <tom@tromey.com>
3053
3054         * symtab.h (struct minimal_symbol): Derive from
3055         general_symbol_info.
3056         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3057         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3058         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3059         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3060         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3061         (MSYMBOL_SEARCH_NAME): Update.
3062         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3063         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3064         * minsyms.c (minimal_symbol_reader::record_full): Update.
3065
3066 2019-03-15  Tom Tromey  <tom@tromey.com>
3067
3068         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3069
3070 2019-03-15  Tom Tromey  <tom@tromey.com>
3071
3072         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3073         unique_xmalloc_ptr.
3074         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3075         Update.
3076         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3077         (build_minimal_symbol_hash_tables)
3078         (minimal_symbol_reader::install): Update.
3079
3080 2019-03-15  Tom Tromey  <tom@tromey.com>
3081
3082         * symtab.c (create_demangled_names_hash): Update.
3083         (symbol_set_names): Update.
3084         * objfiles.h (struct objfile_per_bfd_storage)
3085         <demangled_names_hash>: Now an htab_up.
3086         * objfiles.c (objfile_per_bfd_storage): Simplify.
3087
3088 2019-03-15  Tom Tromey  <tom@tromey.com>
3089
3090         * objfiles.h (struct objfile_per_bfd_storage): Declare
3091         destructor.
3092         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3093         New.
3094         (get_objfile_bfd_data): Use new.  Don't initialize
3095         language_of_main.
3096         (free_objfile_per_bfd_storage): Remove.
3097         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3098
3099 2019-03-15  Tom Tromey  <tom@tromey.com>
3100
3101         * symfile.c (reread_symbols): Update.
3102         * objfiles.c (objfile::objfile): Update.
3103         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3104         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3105         comment.
3106         (minimal_symbol_reader::install): Update.
3107         (terminate_minimal_symbol_table): Remove.
3108         * jit.c (jit_object_close_impl): Update.
3109
3110 2019-03-15  Tom Tromey  <tom@tromey.com>
3111
3112         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3113         initializations.
3114
3115 2019-03-15  Tom Tromey  <tom@tromey.com>
3116
3117         * objfiles.h (struct objfile_per_bfd_storage)
3118         <demangled_hash_languages>: Now a bitset.
3119         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3120         (lookup_minimal_symbol): Update.
3121
3122 2019-03-15  Tom Tromey  <tom@tromey.com>
3123
3124         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3125         Don't return the symbol.
3126         * coffread.c (record_minimal_symbol): Use record_full.
3127
3128 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3129
3130         The MS-Windows port of ncurses fails to switch to a color pair if
3131         one or both of the colors are the implicit default colors.  This
3132         change records the default colors when TUI is initialized, and
3133         then specifies them explicitly when a color pair uses the default
3134         colors.  This allows color styling in TUI mode on MS-Windows.
3135
3136         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3137         ncurses_norm_attr.
3138         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3139         colors in ncurses_norm_attr.
3140         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3141         "none", replace it with the default color recorded in
3142         ncurses_norm_attr.
3143
3144 2019-03-14  Tom Tromey  <tromey@adacore.com>
3145
3146         * source-cache.h (class source_cache) <get_source_lines>: Return
3147         std::string.
3148         * source-cache.c (source_cache::extract_lines): Handle case where
3149         first_pos==npos.  Return std::string.
3150         (source_cache::get_source_lines): Update.
3151
3152 2019-03-14  Tom Tromey  <tromey@adacore.com>
3153
3154         * NEWS: Add item for "style sources" commands.
3155         * source-cache.c (source_cache::get_source_lines): Check
3156         source_styling.
3157         * cli/cli-style.c (source_styling): New global.
3158         (_initialize_cli_style): Add "style sources" commands.
3159         (show_style_sources): New function.
3160         * cli/cli-style.h (source_styling): Declare.
3161
3162 2019-03-14  Pedro Alves  <palves@redhat.com>
3163             Tom Tromey  <tromey@adacore.com>
3164
3165         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3166         * tui/tui-winsource.c (tui_refill_source_window): New function,
3167         from...
3168         (tui_horizontal_source_scroll): ... here.  Move some logic.
3169         * cli/cli-style.c (set_style_enabled): Notify new observable.
3170         * tui/tui-hooks.c (tui_redisplay_source): New function.
3171         (tui_attach_detach_observers): Attach or detach
3172         tui_redisplay_source.
3173         * observable.h (source_styling_changed): New observable.
3174         * observable.c: Define source_styling_changed observable.
3175
3176 2019-03-13  Tom Tromey  <tromey@adacore.com>
3177
3178         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3179         (i386_gnu_nat_target::store_registers): Update.
3180         * target-debug.h (target_debug_print_std_string): New macro.
3181         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3182         * windows-tdep.c (display_one_tib): Update.
3183         * tui/tui-stack.c (tui_make_status_line): Update.
3184         * top.c (print_inferior_quit_action): Update.
3185         * thread.c (thr_try_catch_cmd): Update.
3186         (add_thread_with_info): Update.
3187         (thread_target_id_str): Update.
3188         (thr_try_catch_cmd): Update.
3189         (thread_command): Update.
3190         (thread_find_command): Update.
3191         * record-btrace.c (record_btrace_target::info_record)
3192         (record_btrace_resume_thread, record_btrace_target::resume)
3193         (record_btrace_cancel_resume, record_btrace_step_thread)
3194         (record_btrace_target::wait, record_btrace_target::wait)
3195         (record_btrace_target::wait, record_btrace_target::stop): Update.
3196         * progspace.c (print_program_space): Update.
3197         * process-stratum-target.c
3198         (process_stratum_target::thread_address_space): Update.
3199         * linux-fork.c (linux_fork_mourn_inferior)
3200         (detach_checkpoint_command, info_checkpoints_command)
3201         (linux_fork_context): Update.
3202         (linux_fork_detach): Update.
3203         (class scoped_switch_fork_info): Update.
3204         (delete_checkpoint_command): Update.
3205         * infrun.c (follow_fork_inferior): Update.
3206         (follow_fork_inferior): Update.
3207         (proceed_after_vfork_done): Update.
3208         (handle_vfork_child_exec_or_exit): Update.
3209         (follow_exec): Update.
3210         (displaced_step_prepare_throw): Update.
3211         (displaced_step_restore): Update.
3212         (start_step_over): Update.
3213         (resume_1): Update.
3214         (clear_proceed_status_thread): Update.
3215         (proceed): Update.
3216         (print_target_wait_results): Update.
3217         (do_target_wait): Update.
3218         (context_switch): Update.
3219         (stop_all_threads): Update.
3220         (restart_threads): Update.
3221         (finish_step_over): Update.
3222         (handle_signal_stop): Update.
3223         (switch_back_to_stepped_thread): Update.
3224         (keep_going_pass_signal): Update.
3225         (print_exited_reason): Update.
3226         (normal_stop): Update.
3227         * inferior.c (inferior_pid_to_str): Change return type.
3228         (print_selected_inferior): Update.
3229         (add_inferior): Update.
3230         (detach_inferior): Update.
3231         * dummy-frame.c (fprint_dummy_frames): Update.
3232         * dcache.c (dcache_info_1): Update.
3233         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3234         (btrace_fetch, btrace_clear): Update.
3235         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3236         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3237         type.
3238         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3239         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3240         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3241         * gdbarch.c, gdbarch.h: Rebuild.
3242         * gdbarch.sh (core_pid_to_str): Change return type.
3243         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3244         return type.
3245         (windows_nat_target::pid_to_str): Change return type.
3246         (windows_delete_thread): Update.
3247         (windows_nat_target::attach): Update.
3248         (windows_nat_target::files_info): Update.
3249         * target-delegates.c: Rebuild.
3250         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3251         return type.
3252         (sol_thread_target::pid_to_str): Change return type.
3253         * remote.c (class remote_target) <pid_to_str>: Change return
3254         type.
3255         (remote_target::pid_to_str): Change return type.
3256         (extended_remote_target::attach, remote_target::remote_stop_ns)
3257         (remote_target::remote_notif_remove_queued_reply)
3258         (remote_target::push_stop_reply, remote_target::disable_btrace):
3259         Update.
3260         (extended_remote_target::attach): Update.
3261         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3262         type.
3263         (gdbsim_target::pid_to_str): Change return type.
3264         * ravenscar-thread.c (struct ravenscar_thread_target)
3265         <pid_to_str>: Change return type.
3266         (ravenscar_thread_target::pid_to_str): Change return type.
3267         * procfs.c (class procfs_target) <pid_to_str>: Change return
3268         type.
3269         (procfs_target::pid_to_str): Change return type.
3270         (procfs_target::attach): Update.
3271         (procfs_target::detach): Update.
3272         (procfs_target::fetch_registers): Update.
3273         (procfs_target::store_registers): Update.
3274         (procfs_target::wait): Update.
3275         (procfs_target::files_info): Update.
3276         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3277         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3278         return type.
3279         (nto_procfs_target::pid_to_str): Change return type.
3280         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3281         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3282         return type.
3283         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3284         (exit_lwp): Update.
3285         (attach_proc_task_lwp_callback, get_detach_signal)
3286         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3287         (linux_nat_target::resume, wait_lwp, stop_callback)
3288         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3289         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3290         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3291         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3292         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3293         type.
3294         (inf_ptrace_target::attach): Update.
3295         (inf_ptrace_target::files_info): Update.
3296         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3297         type.
3298         (go32_nat_target::pid_to_str): Change return type.
3299         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3300         (gnu_nat_target::wait): Update.
3301         (gnu_nat_target::wait): Update.
3302         (gnu_nat_target::resume): Update.
3303         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3304         (fbsd_nat_target::wait): Update.
3305         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3306         type.
3307         (darwin_nat_target::attach): Update.
3308         * corelow.c (class core_target) <pid_to_str>: Change return type.
3309         (core_target::pid_to_str): Change return type.
3310         * target.c (normal_pid_to_str): Change return type.
3311         (default_pid_to_str): Likewise.
3312         (target_pid_to_str): Change return type.
3313         (target_translate_tls_address): Update.
3314         (target_announce_detach): Update.
3315         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3316         return type.
3317         (bsd_uthread_target::pid_to_str): Change return type.
3318         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3319         type.
3320         (bsd_kvm_target::pid_to_str): Change return type.
3321         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3322         return type.
3323         (aix_thread_target::pid_to_str): Change return type.
3324         * target.h (struct target_ops) <pid_to_str>: Change return type.
3325         (target_pid_to_str, normal_pid_to_str): Likewise.
3326         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3327         type.
3328         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3329         type.
3330         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3331         return type.
3332         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3333         type.
3334         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3335         type.
3336         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3337         return type.
3338
3339 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3340
3341         * NEWS: Mention that the new default MI version is 3.  Mention
3342         changes to the output of commands and events that deal with
3343         multi-location breakpoints.
3344         * breakpoint.c: Include "mi/mi-out.h".
3345         (print_one_breakpoint): Change output syntax if using MI version
3346         >= 3.
3347         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3348         New.
3349         (mi_multi_location_breakpoint_output_fixed): New.
3350         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3351         (mi_cmd_fix_multi_location_breakpoint_output): New.
3352         (mi_multi_location_breakpoint_output_fixed): New.
3353         * mi/mi-cmds.c (mi_cmds): Register command
3354         -fix-multi-location-breakpoint-output.
3355         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3356         interpreter "mi".
3357
3358 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3359
3360         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3361         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3362         instantiate mi_ui_out based on interpreter name.
3363         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3364         * mi/mi-main.c (mi_load_progress): Likewise.
3365
3366 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3367
3368         * NEWS: Combine separate "New targets" sections for 8.3.
3369
3370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3371
3372         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3373         (ppcfbsd_init_abi): Install gdbarch
3374         "fetch_tls_load_module_address" and "get_thread_local_address"
3375         methods.
3376
3377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3378
3379         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3380         (riscv_fbsd_init_abi): Install gdbarch
3381         "fetch_tls_load_module_address" and "get_thread_local_address"
3382         methods.
3383
3384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3385
3386         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3387         (i386fbsd_init_abi): Install gdbarch
3388         "fetch_tls_load_module_address" and "get_thread_local_address"
3389         methods.
3390
3391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3392
3393         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3394         (amd64fbsd_init_abi): Install gdbarch
3395         "fetch_tls_load_module_address" and "get_thread_local_address"
3396         methods.
3397
3398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3399
3400         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3401         (struct fbsd_pspace_data): New type.
3402         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3403         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3404         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3405         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3406         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3407
3408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3409
3410         * gdbtypes.c (lookup_struct_elt): New function.
3411         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3412         * gdbtypes.h (struct struct_elt): New type.
3413         (lookup_struct_elt): New prototype.
3414
3415 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3416
3417         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3418         remove disabled code block.
3419
3420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3421
3422         * gdbarch.sh (get_thread_local_address): New method.
3423         * gdbarch.h, gdbarch.c: Regenerate.
3424         * target.c (target_translate_tls_address): Use
3425         gdbarch_get_thread_local_address if present instead of
3426         target::get_thread_local_address.
3427
3428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3429
3430         * target.h (target::get_thread_local_address): Update comment.
3431
3432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3433
3434         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3435         objfile->separate_debug_objfile_backlink if not NULL.
3436
3437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3438
3439         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3440         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3441         (amd64bsd_store_inferior_registers): Likewise.
3442         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3443         Enable segment base registers.
3444         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3445         PT_GETFSBASE and PT_GETGSBASE.
3446         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3447         PT_SETGSBASE.
3448         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3449         segment base registers.
3450         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3451
3452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3453
3454         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3455         Update calls to i386_target_description to add 'segments'
3456         parameter.
3457         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3458         add segment base registers.
3459         * arch/i386.c (i386_create_target_description): Add 'segments'
3460         parameter to enable segment base registers.
3461         * arch/i386.h (i386_create_target_description): Likewise.
3462         * features/i386/32bit-segments.xml: New file.
3463         * features/i386/32bit-segments.c: Generate.
3464         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3465         call to i386_target_description to add 'segments' parameter.
3466         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3467         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3468         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3469         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3470         if feature is present.
3471         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3472         Add 'segments' parameter to call to i386_target_description.
3473         (i386_target_description): Add 'segments' parameter to enable
3474         segment base registers.
3475         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3476         to call to i386_target_description.
3477         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3478         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3479         Define I386_NUM_REGS.
3480         (i386_target_description): Add 'segments' parameter to enable
3481         segment base registers.
3482
3483 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3484
3485         PR/24325
3486         * source-cache.c: #undef open and close, to avoid unresolved
3487         externals during linking.
3488
3489 2019-03-12  Tom Tromey  <tromey@adacore.com>
3490
3491         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3492         const.  Add initializers.
3493         (_initialize_remote): Don't initialize ptid globals.
3494
3495 2019-03-12  Pedro Alves  <palves@redhat.com>
3496
3497         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3498
3499 2019-03-12  Pedro Alves  <palves@redhat.com>
3500
3501         * cp-name-parser.y (main): Remove unused 'len' variable.
3502
3503 2019-03-12  Tom Tromey  <tromey@adacore.com>
3504
3505         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3506         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3507
3508 2019-03-12  Tom Tromey  <tromey@adacore.com>
3509
3510         * linux-nat.c (iterate_over_lwps): Update.
3511         (stop_callback): Remove parameter.
3512         (stop_wait_callback, detach_callback, resume_set_callback)
3513         (select_singlestep_lwp_callback, set_ignore_sigint)
3514         (status_callback, resumed_callback, resume_clear_callback)
3515         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3516         data parameter.
3517         (linux_nat_target::detach, linux_nat_target::resume)
3518         (linux_stop_and_wait_all_lwps, select_event_lwp)
3519         (linux_nat_filter_event, linux_nat_wait_1)
3520         (linux_nat_target::kill, linux_nat_target::stop)
3521         (linux_nat_target::stop): Update.
3522         (linux_nat_resume_callback): Change type.
3523         (resume_stopped_resumed_lwps, count_events_callback)
3524         (select_event_lwp_callback): Likewise.
3525         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3526         * arm-linux-nat.c (struct update_registers_data): Remove.
3527         (update_registers_callback): Change type.
3528         (arm_linux_insert_hw_breakpoint1): Update.
3529         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3530         parameter.
3531         (x86_linux_dr_set_addr): Update.
3532         (x86_linux_dr_set_control): Update.
3533         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3534         (iterate_over_lwps): Use gdb::function_view.
3535         * nat/aarch64-linux-hw-point.c (struct
3536         aarch64_dr_update_callback_param): Remove.
3537         (debug_reg_change_callback): Change type.
3538         (aarch64_notify_debug_reg_change): Update.
3539         * s390-linux-nat.c (s390_refresh_per_info): Update.
3540
3541 2019-03-11  Tom Tromey  <tromey@adacore.com>
3542
3543         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3544         redundant assignment to "this_cu".
3545
3546 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3547
3548         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3549
3550 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3551
3552         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3553         from...
3554         (rank_one_type): ... this.
3555
3556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3557
3558         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3559         from...
3560         (rank_one_type): ... this.
3561
3562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3563
3564         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3565         from...
3566         (rank_one_type): ... this.
3567
3568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3569
3570         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3571         from...
3572         (rank_one_type): ... this.
3573
3574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3575
3576         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3577         from...
3578         (rank_one_type): ... this.
3579
3580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3581
3582         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3583         from...
3584         (rank_one_type): ... this.
3585
3586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3587
3588         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3589         from...
3590         (rank_one_type): ... this.
3591
3592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3593
3594         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3595         from...
3596         (rank_one_type): ... this.
3597
3598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3599
3600         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3601         from...
3602         (rank_one_type): ... this.
3603
3604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3605
3606         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3607         from...
3608         (rank_one_type): ... this.
3609
3610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3611
3612         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3613         from...
3614         (rank_one_type): ... this.
3615
3616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3617
3618         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3619         from...
3620         (rank_one_type): ... this.
3621
3622 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3623
3624         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3625         inferior-events' shows the example events.
3626
3627 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3628
3629         Support styling on native MS-Windows console
3630
3631         PR/24315
3632         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3633         on MS-Windows if $TERM is not defined.
3634
3635         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3636
3637         * posix-hdep.c (gdb_console_fputs):
3638         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3639         functions.
3640         * ui-file.h (gdb_console_fputs): Add prototype.
3641
3642         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3643         back to fputs only if the former returns zero.
3644
3645 2019-03-07  Tom Tromey  <tom@tromey.com>
3646
3647         * symmisc.c (print_symbol_bcache_statistics): Update.
3648         (print_objfile_statistics): Update.
3649         * symfile.c (allocate_symtab): Update.
3650         * stabsread.c: Don't include bcache.h.
3651         * psymtab.h (struct psymbol_bcache): Don't declare.
3652         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3653         (psymbol_bcache_init, psymbol_bcache_free)
3654         (psymbol_bcache_get_bcache): Don't declare.
3655         * psymtab.c (struct psymbol_bcache): Remove.
3656         (psymtab_storage::psymtab_storage): Update.
3657         (psymtab_storage::~psymtab_storage): Update.
3658         (psymbol_bcache_init, psymbol_bcache_free)
3659         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3660         (add_psymbol_to_bcache): Update.
3661         (allocate_psymtab): Update.
3662         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3663         macro_cache>: No longer pointers.
3664         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3665         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3666         * macrotab.c (macro_bcache): Update.
3667         * macroexp.c: Don't include bcache.h.
3668         * gdbtypes.c (check_types_worklist): Update.
3669         (types_deeply_equal): Remove TRY/CATCH.  Update.
3670         * elfread.c (elf_symtab_read): Update.
3671         * dwarf2read.c: Don't include bcache.h.
3672         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3673         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3674         (print_bcache_statistics, bcache_memory_used): Don't declare.
3675         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3676         methods.  Rename all data members.
3677         * bcache.c (struct bcache): Move to bcache.h.
3678         (bcache::expand_hash_table): Rename from expand_hash_table.
3679         (bcache): Remove.
3680         (bcache::insert): Rename from bcache_full.
3681         (bcache::compare): Rename from bcache_compare.
3682         (bcache_xmalloc): Remove.
3683         (bcache::~bcache): Rename from bcache_xfree.
3684         (bcache::print_statistics): Rename from print_bcache_statistics.
3685         (bcache::memory_used): Rename from bcache_memory_used.
3686
3687 2019-03-07  Pedro Alves  <palves@redhat.com>
3688
3689         * infrun.c (normal_stop): Also check for
3690         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3691
3692 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * f-lang.c (value_from_host_double): Moved to...
3695         * value.c (value_from_host_double): ...here.
3696         * value.h (value_from_host_double): Declare.
3697         * guile/scm-math.c (vlscm_convert_typed_number): Use
3698         value_from_host_double.
3699         (vlscm_convert_number): Likewise.
3700         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3701         * python/py-value.c (convert_value_from_python): Likewise.
3702
3703 2019-03-06  Tom Tromey  <tom@tromey.com>
3704
3705         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3706
3707 2019-03-06  Tom Tromey  <tom@tromey.com>
3708
3709         * utils.h (free_current_contents): Don't declare.
3710         * utils.c (free_current_contents): Remove.
3711
3712 2019-03-06  Tom Tromey  <tom@tromey.com>
3713
3714         * top.c (quit_force): Update.
3715         * main.c (captured_command_loop): Update.
3716         * common/new-op.c (operator new): Update.
3717         * common/common-exceptions.c (struct catcher)
3718         <save_cleanup_chain>: Remove member.
3719         (exceptions_state_mc_init): Update.
3720         (exception_try_scope_entry): Return nullptr.
3721         (exception_try_scope_exit, exception_rethrow)
3722         (throw_exception_sjlj, throw_exception_cxx): Update.
3723         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3724         (all_cleanups, do_cleanups, discard_cleanups)
3725         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3726         (restore_cleanups, restore_final_cleanups): Don't declare.
3727         (do_final_cleanups): Remove parameter.
3728         * common/cleanups.c (cleanup_chain, make_cleanup)
3729         (make_cleanup_dtor, all_cleanups, do_cleanups)
3730         (discard_my_cleanups, discard_cleanups)
3731         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3732         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3733         (null_cleanup): Remove.
3734         (do_final_cleanups): Remove parameter.
3735
3736 2019-03-06  Tom Tromey  <tom@tromey.com>
3737
3738         * remote.c (remote_target::remote_parse_stop_reply): Use
3739         unique_xmalloc_ptr.
3740
3741 2019-03-06  Tom Tromey  <tom@tromey.com>
3742
3743         * stabsread.c (struct stabs_field_info): Rename from field_info.
3744         <list, fnlist>: Add initializers.
3745         <obstack>: New member.
3746         (read_member_functions, read_struct_fields, read_baseclasses):
3747         Allocate on obstack.  Don't use cleanups.
3748         (read_one_struct_field, read_member_functions, read_struct_fields)
3749         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3750         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3751         (read_struct_type): Update.
3752
3753 2019-03-06  Tom Tromey  <tom@tromey.com>
3754
3755         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3756         * common/filestuff.h (make_cleanup_close): Don't declare.
3757         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3758         Remove.
3759
3760 2019-03-06  Tom Tromey  <tom@tromey.com>
3761
3762         * solib-aix.c: Use make_scope_exit.
3763
3764 2019-03-06  Tom Tromey  <tom@tromey.com>
3765
3766         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3767         Use make_scope_exit.
3768
3769 2019-03-06  Tom Tromey  <tom@tromey.com>
3770
3771         * solib-svr4.c (disable_probes_interface): Remove parameter.
3772         (svr4_handle_solib_event): Use make_scope_exit.
3773
3774 2019-03-06  Tom Tromey  <tom@tromey.com>
3775
3776         * remote.c (struct stop_reply_deleter): Remove.
3777         (stop_reply_up): Update.
3778         (struct stop_reply): Derive from notif_event.  Don't typedef.
3779         <regcache>: Now a std::vector.
3780         (stop_reply_xfree): Remove.
3781         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3782         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3783         (remote_target::discard_pending_stop_replies): Use delete.
3784         (remote_target::remote_parse_stop_reply): Update.
3785         (remote_target::process_stop_reply): Update.
3786         * remote-notif.h (struct notif_event): Add virtual destructor.
3787         Remove "dtr" member.
3788         (struct notif_client) <alloc_event>: Return a unique_ptr.
3789         (notif_event_xfree): Don't declare.
3790         (notif_event_up): New typedef.
3791         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3792         (notif_event_xfree, do_notif_event_xfree): Remove.
3793         (remote_notif_state_xfree): Update.
3794
3795 2019-03-06  Tom Tromey  <tom@tromey.com>
3796
3797         * infrun.c (displaced_step_clear_cleanup): Now a
3798         forward_scope_exit type.
3799         (displaced_step_prepare_throw): Update.
3800         (displaced_step_fixup): Update.
3801
3802 2019-03-06  Tom Tromey  <tom@tromey.com>
3803
3804         * inferior.h (class inferior): Update comment.
3805         * gdbthread.h (class thread_info): Update comment.
3806
3807 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3808             Tom Tromey  <tom@tromey.com>
3809
3810         * stabsread.h (struct stab_section_list): Remove.
3811         (coffstab_build_psymtabs): Update.
3812         * dbxread.c (symbuf_sections): Now a std::vector.
3813         (sect_idx): New global.
3814         (fill_symbuf): Update.
3815         (coffstab_build_psymtabs): Change type of stabsects parameter.
3816         Update.
3817         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3818         std::vector.
3819         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3820         (coff_locate_sections): Update.
3821         (coff_symfile_read): Remove cleanups.  Update.
3822         (init_stringtab): Add storage parameter.
3823         (free_stringtab, free_stringtab_cleanup): Remove.
3824         (init_lineno): Add storage parameter.
3825         (free_linetab, free_linetab_cleanup): Remove.
3826
3827 2019-03-06  Pedro Alves  <palves@redhat.com>
3828
3829         * linux-fork.c (fork_info::clobber_regs): Delete.
3830         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3831         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3832         comment.  Adjust.
3833         (scoped_switch_fork_info::scoped_switch_fork_info)
3834         (checkpoint_command, linux_fork_context): Adjust
3835         fork_save_infrun_state calls.
3836
3837 2019-03-06  Pedro Alves  <palves@redhat.com>
3838
3839         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3840         (inf_has_multiple_threads): Return 'bool' and rewrite using
3841         inferior_info::threads().
3842
3843 2019-03-06  Pedro Alves  <palves@redhat.com>
3844
3845         * linux-fork.c: Include <list>.
3846         (fork_list): Now a std::list instance.
3847         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3848         (forks_exist_p, find_last_fork): Adjust.
3849         (new_fork): Delete.
3850         (one_fork_p): New.
3851         (add_fork): Adjust.
3852         (free_fork): Delete, folded into fork_info::~fork_info().
3853         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3854         Adjust.
3855         (init_fork_list): Delete.
3856         (linux_fork_killall, linux_fork_mourn_inferior)
3857         (linux_fork_detach, info_checkpoints_command): Adjust.
3858         (_initialize_linux_fork): No longer call init_fork_list.
3859
3860 2019-03-06  Pedro Alves  <palves@redhat.com>
3861
3862         * linux-fork.c (new_fork): New, split out of ...
3863         (add_fork): ... this.  Return void.  Move "first fork" special
3864         case from here, to ...
3865         (checkpoint_command): ... here.
3866         * linux-linux.h (add_fork): Return void.
3867
3868 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3871
3872 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3873             Chris January  <chris.january@arm.com>
3874             David Lecomber  <david.lecomber@arm.com>
3875
3876         * f-exp.y: New token, UNOP_INTRINSIC.
3877         (exp): New pattern using UNOP_INTRINSIC token.
3878         (f77_keywords): Add 'abs' keyword.
3879         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3880         (value_from_host_double): New function.
3881         (evaluate_subexp_f): Support UNOP_ABS.
3882
3883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3886         types.
3887
3888 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3891         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3892         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3893
3894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3895
3896         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3897
3898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3899             Chris January  <chris.january@arm.com>
3900
3901         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3902         * f-exp.y: Define 'KIND' token.
3903         (exp): New pattern for KIND expressions.
3904         (ptype): Handle types with a kind extension.
3905         (direct_abs_decl): Extend to spot kind extensions.
3906         (f77_keywords): Add 'kind' to the list.
3907         (push_kind_type): New function.
3908         (convert_to_kind_type): New function.
3909         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3910         * parse.c (operator_length_standard): Likewise.
3911         * parser-defs.h (enum type_pieces): Add tp_kind.
3912         * std-operator.def: Add UNOP_KIND.
3913
3914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * f-exp.y (f_parse): Set yydebug.
3917
3918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * f-lang.c (evaluate_subexp_f): New function.
3921         (exp_descriptor_f): New global.
3922         (f_language_defn): Use exp_descriptor_f instead of
3923         exp_descriptor_standard.
3924
3925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * f-exp.y (struct token): Add comments.
3928         (dot_ops): Remove uppercase versions and the end marker.
3929         (f77_keywords): Likewise.
3930         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3931         entries in the dot_ops array are case insensitive, and use
3932         strncasecmp to compare strings.  Also some whitespace cleanup in
3933         this area.  Similar for the f77_keywords array, except entries in
3934         this list might be case sensitive.
3935
3936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * f-exp.y (struct f77_boolean_val): Add comments.
3939         (boolean_values): Remove uppercase versions, and end marker.
3940         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3941         and use strncasecmp to achieve case insensitivity.  Additionally,
3942         perform whitespace cleanup around this code.
3943
3944 2019-03-06  Tom Tromey  <tromey@adacore.com>
3945
3946         * remote-sim.c (gdbsim_target_open): Use result of
3947         gdb_argv::release.
3948
3949 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3950         Dirk Schubert  <dirk.schubert@arm.com>
3951         Chris January  <chris.january@arm.com>
3952
3953         * eval.c (evaluate_subexp_standard): Call Fortran argument
3954         wrapping logic.
3955         * f-lang.c (struct value): A value which can be passed into a
3956         Fortran function call.
3957         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3958         where appropriate.
3959         (struct type): Value ready for a Fortran function call.
3960         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3961         is needed.
3962         * f-lang.h (fortran_argument_convert): Declaration.
3963         (fortran_preserve_arg_pointer): Declaration.
3964         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3965
3966 2019-03-05  Tom Tromey  <tromey@adacore.com>
3967
3968         * python/py-prettyprint.c (print_string_repr): Remove #if.
3969         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3970
3971 2019-03-05  Tom Tromey  <tromey@adacore.com>
3972
3973         * target.c (the_dummy_target): Move later.  Change type to
3974         "dummy_target".
3975         (initialize_targets): Don't initialize the_dummy_target.
3976
3977 2019-03-05  Tom Tromey  <tromey@adacore.com>
3978
3979         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3980         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3981
3982 2019-03-05  Tom Tromey  <tromey@adacore.com>
3983
3984         * windows-nat.c (windows_nat_target::attach)
3985         (windows_nat_target::detach): Don't call gdb_flush.
3986         * valprint.c (generic_val_print, val_print, val_print_string):
3987         Don't call gdb_flush.
3988         * utils.c (defaulted_query): Don't call gdb_flush.
3989         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3990         * target.c (target_announce_detach): Don't call gdb_flush.
3991         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3992         * remote.c (extended_remote_target::attach): Don't call
3993         gdb_flush.
3994         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3995         * printcmd.c (do_examine): Don't call gdb_flush.
3996         (info_display_command): Don't call gdb_flush.
3997         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3998         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3999         * memattr.c (info_mem_command): Don't call gdb_flush.
4000         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4001         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4002         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4003         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4004         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4005         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4006         (gnu_nat_target::detach): Don't call gdb_flush.
4007         * f-valprint.c (f_val_print): Don't call gdb_flush.
4008         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4009         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4010         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4011         gdb_flush.
4012         * c-valprint.c (c_val_print): Don't call gdb_flush.
4013         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4014
4015 2019-03-05  Tom Tromey  <tromey@adacore.com>
4016
4017         * varobj.c (update_dynamic_varobj_children): Update.
4018         (install_default_visualizer): Use reset, not release.
4019         * value.c (set_internalvar): Update.
4020         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4021         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4022         ATTRIBUTE_UNUSED_RESULT.
4023
4024 2019-03-05  Tom Tromey  <tromey@adacore.com>
4025
4026         * remote.c (class scoped_remote_fd) <release>: Add
4027         ATTRIBUTE_UNUSED_RESULT.
4028
4029 2019-03-05  Tom Tromey  <tromey@adacore.com>
4030
4031         * macroexp.c (struct macro_buffer) <release>: Add
4032         ATTRIBUTE_UNUSED_RESULT.
4033
4034 2019-03-05  Tom Tromey  <tromey@adacore.com>
4035
4036         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4037         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4038         ATTRIBUTE_UNUSED_RESULT.
4039
4040 2019-03-05  Tom Tromey  <tromey@adacore.com>
4041
4042         * common/scoped_fd.h (class scoped_fd) <release>: Add
4043         ATTRIBUTE_UNUSED_RESULT.
4044
4045 2019-03-05  Tom Tromey  <tromey@adacore.com>
4046
4047         * parser-defs.h (struct parser_state) <release>: Add
4048         ATTRIBUTE_UNUSED_RESULT.
4049
4050 2019-03-05  Tom Tromey  <tromey@adacore.com>
4051
4052         * utils.h (class gdb_argv) <release>: Add
4053         ATTRIBUTE_UNUSED_RESULT.
4054         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4055
4056 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4057
4058         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4059         for-loop range, to avoid compiler warnings.
4060
4061         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4062         avoid compiler warnings about unused variables.
4063
4064         * NEWS: Mention end of support for native debugging on MS-Windows
4065         before XP.
4066
4067         PR gdb/24292
4068         * common/netstuff.c:
4069         * gdbserver/gdbreplay.c
4070         * gdbserver/remote-utils.c:
4071         * ser-tcp.c:
4072         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4073         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4074         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4075         'getaddrinfo' and 'freeaddrinfo' were not available before
4076         Windows XP, and mingw.org's MinGW headers by default define
4077         _WIN32_WINNT to 0x500.
4078
4079 2019-03-01  Gary Benson <gbenson@redhat.com>
4080
4081         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4082
4083 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4084             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4085
4086         PR gdb/8527
4087         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4088         set_sigint_trap, clear_sigint_trap.
4089
4090 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4091
4092         * target.c (target_detach): Clear the regcache and the
4093         frame cache.
4094
4095 2019-02-27  Pedro Alves  <palves@redhat.com>
4096
4097         * utils.c (set_screen_size): When we cap the height/width sizes,
4098         tweak the corresponding command variable to show "unlimited":
4099
4100 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4101             Pedro Alves  <palves@redhat.com>
4102
4103         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4104         before calling rl_set_screen_size.
4105
4106 2019-02-27  Tom Tromey  <tromey@adacore.com>
4107
4108         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4109         define.
4110         * python/py-value.c: Remove Python 2.4 workaround.
4111         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4112         workaround.
4113         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4114         Python 2.4 workaround.
4115         * python/python-internal.h: Remove Python 2.4 comment.
4116         (Py_ssize_t): Don't define.
4117         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4118         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4119         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4120         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4121         * python/python.c (do_start_initialization): Remove Python 2.4
4122         workaround.
4123         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4124         (print_children): Remove Python 2.4 workaround.
4125         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4126         workaround.
4127         (CHARBUFFERPROC_NAME): Remove.
4128         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4129         Python 2.4 workaround.
4130
4131 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4132
4133         * NEWS: Note minimum Python version.
4134
4135 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4136
4137         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4138         code from these functions.  Remove corresponding ifdefs.  Use
4139         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4140         Remove gotos and target of gotos.
4141         (infpy_search_memory): Likewise.
4142
4143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4146         (hppa_gdbarch_init): Don't register deleted functions with
4147         gdbarch.
4148
4149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4152         (h8300_unwind_sp): Delete.
4153         (h8300_dummy_id): Delete.
4154         (h8300_gdbarch_init): Don't register deleted functions with
4155         gdbarch.
4156
4157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4160         (ft32_unwind_pc): Delete.
4161         (ft32_unwind_sp): Delete.
4162         (ft32_gdbarch_init): Don't register deleted functions with
4163         gdbarch.
4164
4165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4168         (frv_unwind_pc): Delete.
4169         (frv_unwind_sp): Delete.
4170         (frv_gdbarch_init): Don't register deleted functions with
4171         gdbarch.
4172
4173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4176         (riscv_unwind_pc): Delete.
4177         (riscv_unwind_sp): Delete.
4178         (riscv_gdbarch_init): Don't register deleted functions with
4179         gdbarch.
4180
4181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4184         (csky_unwind_pc): Delete.
4185         (csky_unwind_sp): Delete.
4186         (csky_gdbarch_init): Don't register deleted functions with
4187         gdbarch.
4188
4189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4192         (cris_unwind_pc): Delete.
4193         (cris_unwind_sp): Delete.
4194         (cris_gdbarch_init): Don't register deleted functions with
4195         gdbarch.
4196
4197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4200         (bfin_unwind_pc): Delete.
4201         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4202
4203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4206         (arm_unwind_pc): Delete.
4207         (arm_unwind_sp): Delete.
4208         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4209
4210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4211
4212         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4213         (arc_unwind_pc): Delete.
4214         (arc_unwind_sp): Delete.
4215         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4216
4217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4220         (alpha_unwind_pc): Delete.
4221         (alpha_gdbarch_init): Don't register deleted functions with
4222         gdbarch.
4223
4224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4227         (aarch64_unwind_pc): Delete.
4228         (aarch64_unwind_sp): Delete.
4229         (aarch64_gdbarch_init): Don't register deleted functions with
4230         gdbarch.
4231
4232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * gdbtypes.c (type_align): Don't consider static members when
4235         computing structure alignment.
4236
4237 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4240         return 0 for other types.
4241         * arch-utils.c (default_type_align): Always return 0.
4242         * gdbarch.h: Regenerate.
4243         * gdbarch.sh (type_align): Extend comment.
4244         * gdbtypes.c (type_align): Add additional comments, always call
4245         gdbarch_type_align before applying the default rules.
4246         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4247         generic code will then apply a suitable default.
4248         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4249         types, return 0 for other types.
4250
4251 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4252
4253         * NEWS: Create a new section for the next release branch.
4254         Rename the section of the current branch, now that it has
4255         been cut.
4256
4257 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4258
4259         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4260         * version.in: Bump version to 8.3.50.DATE-git.
4261
4262 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4263
4264         * aix-thread.c (ptid_cmp): Remove unused variable.
4265         (get_signaled_thread): Likewise.
4266         (store_regs_user_thread): Likewise.
4267         (store_regs_kernel_thread): Likewise.
4268         (fetch_regs_kernel_thread): Remove shadowed variable.
4269
4270 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * features/riscv/32bit-cpu.xml: Add register numbers.
4273         * features/riscv/32bit-fpu.c: Regenerate.
4274         * features/riscv/32bit-fpu.xml: Add register numbers.
4275         * features/riscv/64bit-cpu.xml: Add register numbers.
4276         * features/riscv/64bit-fpu.c: Regenerate.
4277         * features/riscv/64bit-fpu.xml: Add register numbers.
4278
4279 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4280
4281         * NEWS: Mention two argument form of gdb.Value constructor.
4282         * python/py-value.c (convert_buffer_and_type_to_value): New
4283         function.
4284         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4285         Add support for handling an optional second argument.  Call
4286         convert_buffer_and_type_to_value as appropriate.
4287         * python/python-internal.h (Py_buffer_deleter): New struct.
4288         (Py_buffer_up): New typedef.
4289
4290 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4291
4292         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4293         instead of releasing ownership.
4294
4295 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4296
4297         * dwarf2read.c (open_and_init_dwp_file): Call
4298         elf_numsections instead of bfd_count_sections to initialize
4299         dwp_file->num_sections.
4300
4301 2019-02-25  Tom Tromey  <tromey@adacore.com>
4302
4303         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4304
4305 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4306
4307         * gcore.in: Add '--readnever' option when invoking GDB.
4308
4309 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4310
4311         * MAINTAINERS: Update my email address.
4312
4313 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4314
4315         * build-id.c (build_id_to_debug_bfd_1): New function.
4316         (build_id_to_debug_bfd): Look for separate debug file in
4317         sysroot.
4318
4319 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4320
4321         * gdbarch.sh: Update the copyright year range that is placed into
4322         generated files.
4323
4324 2019-02-22  Keith Seitz  <keiths@redhat.com>
4325
4326         PR symtab/23853
4327         * linespec.c (create_sals_line_offset): Search for the default
4328         symtab's filename instead of its fullname.
4329
4330 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4331
4332         * NEWS: Update style defaults.
4333
4334 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4335
4336         * main.c (captured_main_1): Disable styling in batch mode.
4337
4338 2019-02-20  Tom Tromey  <tom@tromey.com>
4339
4340         * symtab.c (symtab_symbol_info): Fix typos.
4341
4342 2019-02-20  Tom Tromey  <tromey@adacore.com>
4343
4344         * findcmd.c (_initialize_mem_search): Use upper case for
4345         metasyntactic variables.
4346
4347 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4348
4349         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4350         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4351
4352 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4353
4354         * top.h (source_file_name): Change to std::string.
4355         * top.c (source_file_name): Likewise.
4356         (command_line_input): Adjust.
4357         * cli/cli-script.c (script_from_file): Adjust.
4358
4359 2019-02-19  Tom Tromey  <tromey@adacore.com>
4360
4361         * ravenscar-thread.c
4362         (ravenscar_thread_target::update_thread_list): Don't call
4363         ada_build_task_list.
4364         * ada-lang.h (ada_build_task_list): Don't declare.
4365         * ada-tasks.c (struct ada_tasks_inferior_data)
4366         <task_list_valid_p>: Now bool.
4367         (read_known_tasks, ada_task_list_changed)
4368         (ada_tasks_invalidate_inferior_data): Update.
4369         (read_known_tasks_array): Return bool.
4370         (read_known_tasks_list): Likewise.
4371         (read_known_tasks): Return void.
4372         (ada_build_task_list): Now static.
4373
4374 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4377         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4378
4379 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4380
4381         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4382         variant for ada_tasks_pspace_data_handle and
4383         ada_tasks_inferior_data_handle.
4384         (ada_tasks_pspace_data_cleanup): New function.
4385         (ada_tasks_inferior_data_cleanup): New function.
4386
4387 2019-02-17  Tom Tromey  <tom@tromey.com>
4388
4389         * macrotab.h (macro_source_fullname): Return a std::string.
4390         * macrotab.c (macro_include, check_for_redefinition)
4391         (macro_undef, macro_lookup_definition, foreach_macro)
4392         (foreach_macro_in_scope): Update.
4393         (macro_source_fullname): Return a std::string.
4394         * macrocmd.c (show_pp_source_pos): Update.
4395
4396 2019-02-17  Tom Tromey  <tom@tromey.com>
4397
4398         * macrocmd.c (show_pp_source_pos): Style the file names.
4399
4400 2019-02-17  Tom Tromey  <tom@tromey.com>
4401
4402         PR tui/24197:
4403         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4404
4405 2019-02-17  Tom Tromey  <tom@tromey.com>
4406
4407         * ada-lang.c (user_select_syms): Use filtered printing.
4408         * utils.c (wrap_style): New global.
4409         (desired_style): Remove.
4410         (emit_style_escape): Add stream parameter.
4411         (set_output_style, reset_terminal_style, prompt_for_continue):
4412         Update.
4413         (flush_wrap_buffer): Only flush gdb_stdout.
4414         (wrap_here): Set wrap_style.
4415         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4416         treat escape sequences as a character.  Change when wrap buffer is
4417         flushed.
4418         (fputs_styled): Do not set the output style when the default is
4419         requested.
4420         * ui-style.h (struct ui_file_style) <is_default>: New method.
4421         * source.c (print_source_lines_base): Emit escape sequences in one
4422         piece.
4423
4424 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4425
4426         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4427         integers and enumeration types.
4428
4429 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4430
4431         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4432         instead of lookup_symbol_in_language
4433         (do_exact_match): New function.
4434         (ada_get_symbol_name_matcher): Return do_exact_match when
4435         doing a verbatim match.
4436
4437 2019-02-15  Tom Tromey  <tromey@adacore.com>
4438
4439         * ravenscar-thread.c (ravenscar_thread_target::resume)
4440         (ravenscar_thread_target::wait): Special case wildcard requests.
4441
4442 2019-02-15  Tom Tromey  <tromey@adacore.com>
4443
4444         * ravenscar-thread.c (base_ptid): Remove.
4445         (struct ravenscar_thread_target) <close>: New method.
4446         <m_base_ptid>: New member.
4447         <update_inferior_ptid, active_task, task_is_currently_active,
4448         runtime_initialized>: Declare methods.
4449         <ravenscar_thread_target>: Add constructor.
4450         (ravenscar_thread_target::task_is_currently_active)
4451         (ravenscar_thread_target::update_inferior_ptid)
4452         (ravenscar_runtime_initialized): Rename.  Now methods.
4453         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4454         (ravenscar_thread_target::update_thread_list): Update.
4455         (ravenscar_thread_target::active_task): Now method.
4456         (ravenscar_thread_target::store_registers)
4457         (ravenscar_thread_target::prepare_to_store)
4458         (ravenscar_thread_target::prepare_to_store)
4459         (ravenscar_thread_target::mourn_inferior): Update.
4460         (ravenscar_inferior_created): Use "new" to create target.
4461         (ravenscar_thread_target::get_ada_task_ptid): Update.
4462         (_initialize_ravenscar): Don't initialize base_ptid.
4463         (ravenscar_ops): Remove global.
4464
4465 2019-02-15  Tom Tromey  <tromey@adacore.com>
4466
4467         * target.h (push_target): Declare new overload.
4468         * target.c (push_target): New overload, taking an rvalue reference.
4469         * remote.c (remote_target::open_1): Use push_target overload.
4470         * corelow.c (core_target_open): Use push_target overload.
4471
4472 2019-02-15  Tom Tromey  <tromey@adacore.com>
4473
4474         * ravenscar-thread.c (is_ravenscar_task)
4475         (ravenscar_task_is_currently_active): Return bool.
4476         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4477         (_initialize_ravenscar): Remove "(void)".
4478         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4479         Return bool.
4480
4481 2019-02-15  Tom Tromey  <tromey@adacore.com>
4482
4483         * ravenscar-thread.c (ravenscar_runtime_initializer)
4484         (has_ravenscar_runtime, get_running_thread_id)
4485         (ravenscar_thread_target::resume): Fix indentation.
4486
4487 2019-02-15  Tom Tromey  <tromey@adacore.com>
4488
4489         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4490         from ravenscar_arch_ops.
4491         (sparc_ravenscar_ops::fetch_registers)
4492         (sparc_ravenscar_ops::store_registers): Now methods.
4493         (sparc_ravenscar_prepare_to_store): Remove.
4494         (sparc_ravenscar_ops): Redefine.
4495         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4496         methods and destructor.  Remove members.
4497         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4498         (ravenscar_thread_target::store_registers)
4499         (ravenscar_thread_target::prepare_to_store): Update.
4500         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4501         Remove.
4502         (struct ppc_ravenscar_powerpc_ops): Derive from
4503         ravenscar_arch_ops.
4504         (ppc_ravenscar_powerpc_ops::fetch_registers)
4505         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4506         (ppc_ravenscar_powerpc_ops): Redefine.
4507         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4508         (ppc_ravenscar_e500_ops::fetch_registers)
4509         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4510         (ppc_ravenscar_e500_ops): Redefine.
4511         * aarch64-ravenscar-thread.c
4512         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4513         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4514         (aarch64_ravenscar_fetch_registers)
4515         (aarch64_ravenscar_store_registers): Now methods.
4516         (aarch64_ravenscar_ops): Redefine.
4517
4518 2019-02-15  Tom Tromey  <tromey@adacore.com>
4519
4520         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4521         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4522         (ravenscar_thread_target::stopped_by_watchpoint)
4523         (ravenscar_thread_target::stopped_data_address)
4524         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4525
4526 2019-02-15  Tom Tromey  <tromey@adacore.com>
4527
4528         * ravenscar-thread.c: Fix some typos.
4529
4530 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4531             Tom Tromey  <tromey@adacore.com>
4532
4533         * ada-lang.c (ada_exception_sal): Change addr_string to a
4534         std::string.
4535         (create_ada_exception_catchpoint): Update.
4536
4537 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4538             Tom Tromey  <tromey@adacore.com>
4539
4540         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4541         (bp_location_ops): Remove.
4542         (base_breakpoint_allocate_location): Update.
4543         (free_bp_location): Update.
4544         * ada-lang.c (class ada_catchpoint_location)
4545         <ada_catchpoint_location>: Remove ops parameter.
4546         (ada_catchpoint_location_dtor): Remove.
4547         (ada_catchpoint_location_ops): Remove.
4548         (allocate_location_exception): Update.
4549         * breakpoint.h (struct bp_location_ops): Remove.
4550         (class bp_location) <bp_location>: Remove bp_location_ops
4551         parameter.
4552         <~bp_location>: Add destructor.
4553         <ops>: Remove.
4554
4555 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4556             Pedro Alves  <palves@redhat.com>
4557
4558         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4559         'PATH_MAX'.
4560
4561 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4562             Samuel Thibault  <samuel.thibault@gnu.org>
4563             Thomas Schwinge  <thomas@codesourcery.com>
4564
4565         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4566         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4567
4568 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4569
4570         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4571         (check_empty): Use "const char *".
4572
4573         * gnu-nat.c (gnu_nat_target::detach): Instead of
4574         'detach_inferior (pid)' call
4575         'detach_inferior (find_inferior_pid (pid))'.
4576
4577         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4578         'nat/fork-inferior.o'.
4579         * gnu-nat.c: #include "nat/fork-inferior.h".
4580
4581         * gnu-nat.c (gnu_nat_target::detach): Instead of
4582         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4583         * gnu-nat.h: #include "inf-child.h".
4584         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4585         'i386_gnu_nat_target::fetch_registers'.
4586         (gnu_store_registers): Rename/move to
4587         'i386_gnu_nat_target::store_registers'.
4588
4589         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4590         * gnu-nat.h (mach_thread_info): New function.
4591         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4592
4593         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4594
4595 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4596
4597         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4598
4599 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4600
4601         * windows-nat.c (windows_add_thread): Add new parameter
4602         "main_thread_p" with default value set to false.  Update
4603         function documentation as well as all callers.
4604         (windows_delete_thread): Likewise.
4605         (fake_create_process): Update call to windows_add_thread.
4606         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4607         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4608         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4609         call to windows_delete_thread.
4610
4611 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4612
4613         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4614
4615 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4616
4617         * symfile.c (find_separate_debug_file): Use canonical path of
4618         sysroot with child_path instead of gdb_sysroot if it is valid.
4619
4620 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4621
4622         * symfile.c (find_separate_debug_file): Use child_path to
4623         determine if an object file is under a sysroot.
4624
4625 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4626
4627         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4628         unittests/child-path-selftests.c.
4629         * common/pathstuff.c (child_path): New function.
4630         * common/pathstuff.h (child_path): New prototype.
4631         * unittests/child-path-selftests.c: New file.
4632
4633 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4634
4635         * symfile.c (find_separate_debug_file): Look for separate debug
4636         files in debug directories under the sysroot.
4637
4638 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4639
4640         * symtab.h (struct minimal_symbol data_p): New const method.
4641         (struct minimal_symbol text_p): Likewise.
4642         * symtab.c (output_source_filename): Use file name style
4643         to print file name.
4644         (print_symbol_info): Likewise.
4645         (print_msymbol_info): Use address style to print addresses.
4646         Use function name style to print executable text symbols.
4647         (expand_symtab_containing_pc): Use data_p.
4648         (find_pc_sect_compunit_symtab): Likewise.
4649
4650 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4651
4652         * breakpoint.c (describe_other_breakpoints): Use address style
4653         to print addresses.
4654         (say_where): Likewise.
4655
4656 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4657
4658         * ada-typeprint.c (print_func_type): Print function name
4659         style to print function name.
4660         * c-typeprint.c (c_print_type_1): Likewise.
4661
4662 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4663
4664         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4665         for execve.
4666
4667 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4668
4669         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4670         type_stack.
4671
4672 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4673
4674         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4675         TYPE_CODE_REF types.
4676
4677 2019-02-08  Jim Wilson  <jimw@sifive.com>
4678
4679         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4680         (riscv_linux_fregset): New.
4681         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4682
4683 2019-02-07  Tom Tromey  <tom@tromey.com>
4684
4685         * thread.c (thread_cancel_execution_command): Update.
4686         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4687         methods.
4688         (struct thread_fsm_ops): Remove.
4689         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4690         (thread_fsm_should_stop, thread_fsm_return_value)
4691         (thread_fsm_set_finished, thread_fsm_finished_p)
4692         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4693         Don't declare.
4694         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4695         * infrun.c (clear_proceed_status_thread)
4696         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4697         (print_stop_event): Update.
4698         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4699         Add constructor.
4700         (step_command_fsm_ops): Remove.
4701         (new_step_command_fsm): Remove.
4702         (step_1): Update.
4703         (step_command_fsm::should_stop): Rename from
4704         step_command_fsm_should_stop.
4705         (step_command_fsm::clean_up): Rename from
4706         step_command_fsm_clean_up.
4707         (step_command_fsm::do_async_reply_reason): Rename from
4708         step_command_fsm_async_reply_reason.
4709         (struct until_next_fsm): Inherit from thread_fsm.  Add
4710         constructor.
4711         (until_next_fsm_ops): Remove.
4712         (new_until_next_fsm): Remove.
4713         (until_next_fsm::should_stop): Rename from
4714         until_next_fsm_should_stop.
4715         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4716         (until_next_fsm::do_async_reply_reason): Rename from
4717         until_next_fsm_async_reply_reason.
4718         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4719         constructor.  Change type of breakpoint.
4720         (finish_command_fsm_ops): Remove.
4721         (new_finish_command_fsm): Remove.
4722         (finish_command_fsm::should_stop): Rename from
4723         finish_command_fsm_should_stop.
4724         (finish_command_fsm::clean_up): Rename from
4725         finish_command_fsm_clean_up.
4726         (finish_command_fsm::return_value): Rename from
4727         finish_command_fsm_return_value.
4728         (finish_command_fsm::do_async_reply_reason): Rename from
4729         finish_command_fsm_async_reply_reason.
4730         (finish_command): Update.
4731         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4732         Add constructor.
4733         (call_thread_fsm_ops): Remove.
4734         (call_thread_fsm::call_thread_fsm): Rename from
4735         new_call_thread_fsm.
4736         (call_thread_fsm::should_stop): Rename from
4737         call_thread_fsm_should_stop.
4738         (call_thread_fsm::should_notify_stop): Rename from
4739         call_thread_fsm_should_notify_stop.
4740         (run_inferior_call, call_function_by_hand_dummy): Update.
4741         * cli/cli-interp.c (should_print_stop_to_console): Update.
4742         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4743         Add constructor.  Change type of location_breakpoint,
4744         caller_breakpoint.
4745         (until_break_fsm_ops): Remove.
4746         (new_until_break_fsm): Remove.
4747         (until_break_fsm::should_stop): Rename from
4748         until_break_fsm_should_stop.
4749         (until_break_fsm::clean_up): Rename from
4750         until_break_fsm_clean_up.
4751         (until_break_fsm::do_async_reply_reason): Rename from
4752         until_break_fsm_async_reply_reason.
4753         (until_break_command): Update.
4754         * thread-fsm.c: Remove.
4755         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4756
4757 2019-02-07  Tom Tromey  <tom@tromey.com>
4758
4759         * yy-remap.h: Add include guard.
4760         * xtensa-tdep.h: Add include guard.
4761         * xcoffread.h: Rename include guard.
4762         * varobj-iter.h: Add include guard.
4763         * tui/tui.h: Rename include guard.
4764         * tui/tui-winsource.h: Rename include guard.
4765         * tui/tui-wingeneral.h: Rename include guard.
4766         * tui/tui-windata.h: Rename include guard.
4767         * tui/tui-win.h: Rename include guard.
4768         * tui/tui-stack.h: Rename include guard.
4769         * tui/tui-source.h: Rename include guard.
4770         * tui/tui-regs.h: Rename include guard.
4771         * tui/tui-out.h: Rename include guard.
4772         * tui/tui-layout.h: Rename include guard.
4773         * tui/tui-io.h: Rename include guard.
4774         * tui/tui-hooks.h: Rename include guard.
4775         * tui/tui-file.h: Rename include guard.
4776         * tui/tui-disasm.h: Rename include guard.
4777         * tui/tui-data.h: Rename include guard.
4778         * tui/tui-command.h: Rename include guard.
4779         * tic6x-tdep.h: Add include guard.
4780         * target/waitstatus.h: Rename include guard.
4781         * target/wait.h: Rename include guard.
4782         * target/target.h: Rename include guard.
4783         * target/resume.h: Rename include guard.
4784         * target-float.h: Rename include guard.
4785         * stabsread.h: Add include guard.
4786         * rs6000-tdep.h: Add include guard.
4787         * riscv-fbsd-tdep.h: Add include guard.
4788         * regformats/regdef.h: Rename include guard.
4789         * record.h: Rename include guard.
4790         * python/python.h: Rename include guard.
4791         * python/python-internal.h: Rename include guard.
4792         * python/py-stopevent.h: Rename include guard.
4793         * python/py-ref.h: Rename include guard.
4794         * python/py-record.h: Rename include guard.
4795         * python/py-record-full.h: Rename include guard.
4796         * python/py-record-btrace.h: Rename include guard.
4797         * python/py-instruction.h: Rename include guard.
4798         * python/py-events.h: Rename include guard.
4799         * python/py-event.h: Rename include guard.
4800         * procfs.h: Add include guard.
4801         * proc-utils.h: Add include guard.
4802         * p-lang.h: Add include guard.
4803         * or1k-tdep.h: Rename include guard.
4804         * observable.h: Rename include guard.
4805         * nto-tdep.h: Rename include guard.
4806         * nat/x86-linux.h: Rename include guard.
4807         * nat/x86-linux-dregs.h: Rename include guard.
4808         * nat/x86-gcc-cpuid.h: Add include guard.
4809         * nat/x86-dregs.h: Rename include guard.
4810         * nat/x86-cpuid.h: Rename include guard.
4811         * nat/ppc-linux.h: Rename include guard.
4812         * nat/mips-linux-watch.h: Rename include guard.
4813         * nat/linux-waitpid.h: Rename include guard.
4814         * nat/linux-ptrace.h: Rename include guard.
4815         * nat/linux-procfs.h: Rename include guard.
4816         * nat/linux-osdata.h: Rename include guard.
4817         * nat/linux-nat.h: Rename include guard.
4818         * nat/linux-namespaces.h: Rename include guard.
4819         * nat/linux-btrace.h: Rename include guard.
4820         * nat/glibc_thread_db.h: Rename include guard.
4821         * nat/gdb_thread_db.h: Rename include guard.
4822         * nat/gdb_ptrace.h: Rename include guard.
4823         * nat/fork-inferior.h: Rename include guard.
4824         * nat/amd64-linux-siginfo.h: Rename include guard.
4825         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4826         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4827         * nat/aarch64-linux.h: Rename include guard.
4828         * nat/aarch64-linux-hw-point.h: Rename include guard.
4829         * mn10300-tdep.h: Add include guard.
4830         * mips-linux-tdep.h: Add include guard.
4831         * mi/mi-parse.h: Rename include guard.
4832         * mi/mi-out.h: Rename include guard.
4833         * mi/mi-main.h: Rename include guard.
4834         * mi/mi-interp.h: Rename include guard.
4835         * mi/mi-getopt.h: Rename include guard.
4836         * mi/mi-console.h: Rename include guard.
4837         * mi/mi-common.h: Rename include guard.
4838         * mi/mi-cmds.h: Rename include guard.
4839         * mi/mi-cmd-break.h: Rename include guard.
4840         * m2-lang.h: Add include guard.
4841         * location.h: Rename include guard.
4842         * linux-record.h: Rename include guard.
4843         * linux-nat.h: Add include guard.
4844         * linux-fork.h: Add include guard.
4845         * i386-darwin-tdep.h: Rename include guard.
4846         * hppa-linux-offsets.h: Add include guard.
4847         * guile/guile.h: Rename include guard.
4848         * guile/guile-internal.h: Rename include guard.
4849         * gnu-nat.h: Rename include guard.
4850         * gdb-stabs.h: Rename include guard.
4851         * frv-tdep.h: Add include guard.
4852         * f-lang.h: Add include guard.
4853         * event-loop.h: Add include guard.
4854         * darwin-nat.h: Rename include guard.
4855         * cp-abi.h: Rename include guard.
4856         * config/sparc/nm-sol2.h: Rename include guard.
4857         * config/nm-nto.h: Rename include guard.
4858         * config/nm-linux.h: Add include guard.
4859         * config/i386/nm-i386gnu.h: Rename include guard.
4860         * config/djgpp/nl_types.h: Rename include guard.
4861         * config/djgpp/langinfo.h: Rename include guard.
4862         * compile/gcc-cp-plugin.h: Add include guard.
4863         * compile/gcc-c-plugin.h: Add include guard.
4864         * compile/compile.h: Rename include guard.
4865         * compile/compile-object-run.h: Rename include guard.
4866         * compile/compile-object-load.h: Rename include guard.
4867         * compile/compile-internal.h: Rename include guard.
4868         * compile/compile-cplus.h: Rename include guard.
4869         * compile/compile-c.h: Rename include guard.
4870         * common/xml-utils.h: Rename include guard.
4871         * common/x86-xstate.h: Rename include guard.
4872         * common/version.h: Rename include guard.
4873         * common/vec.h: Rename include guard.
4874         * common/tdesc.h: Rename include guard.
4875         * common/selftest.h: Rename include guard.
4876         * common/scoped_restore.h: Rename include guard.
4877         * common/scoped_mmap.h: Rename include guard.
4878         * common/scoped_fd.h: Rename include guard.
4879         * common/safe-iterator.h: Rename include guard.
4880         * common/run-time-clock.h: Rename include guard.
4881         * common/refcounted-object.h: Rename include guard.
4882         * common/queue.h: Rename include guard.
4883         * common/ptid.h: Rename include guard.
4884         * common/print-utils.h: Rename include guard.
4885         * common/preprocessor.h: Rename include guard.
4886         * common/pathstuff.h: Rename include guard.
4887         * common/observable.h: Rename include guard.
4888         * common/netstuff.h: Rename include guard.
4889         * common/job-control.h: Rename include guard.
4890         * common/host-defs.h: Rename include guard.
4891         * common/gdb_wait.h: Rename include guard.
4892         * common/gdb_vecs.h: Rename include guard.
4893         * common/gdb_unlinker.h: Rename include guard.
4894         * common/gdb_unique_ptr.h: Rename include guard.
4895         * common/gdb_tilde_expand.h: Rename include guard.
4896         * common/gdb_sys_time.h: Rename include guard.
4897         * common/gdb_string_view.h: Rename include guard.
4898         * common/gdb_splay_tree.h: Rename include guard.
4899         * common/gdb_setjmp.h: Rename include guard.
4900         * common/gdb_ref_ptr.h: Rename include guard.
4901         * common/gdb_optional.h: Rename include guard.
4902         * common/gdb_locale.h: Rename include guard.
4903         * common/gdb_assert.h: Rename include guard.
4904         * common/filtered-iterator.h: Rename include guard.
4905         * common/filestuff.h: Rename include guard.
4906         * common/fileio.h: Rename include guard.
4907         * common/environ.h: Rename include guard.
4908         * common/common-utils.h: Rename include guard.
4909         * common/common-types.h: Rename include guard.
4910         * common/common-regcache.h: Rename include guard.
4911         * common/common-inferior.h: Rename include guard.
4912         * common/common-gdbthread.h: Rename include guard.
4913         * common/common-exceptions.h: Rename include guard.
4914         * common/common-defs.h: Rename include guard.
4915         * common/common-debug.h: Rename include guard.
4916         * common/cleanups.h: Rename include guard.
4917         * common/buffer.h: Rename include guard.
4918         * common/btrace-common.h: Rename include guard.
4919         * common/break-common.h: Rename include guard.
4920         * cli/cli-utils.h: Rename include guard.
4921         * cli/cli-style.h: Rename include guard.
4922         * cli/cli-setshow.h: Rename include guard.
4923         * cli/cli-script.h: Rename include guard.
4924         * cli/cli-interp.h: Rename include guard.
4925         * cli/cli-decode.h: Rename include guard.
4926         * cli/cli-cmds.h: Rename include guard.
4927         * charset-list.h: Add include guard.
4928         * buildsym-legacy.h: Rename include guard.
4929         * bfin-tdep.h: Add include guard.
4930         * ax.h: Rename include guard.
4931         * arm-linux-tdep.h: Add include guard.
4932         * arm-fbsd-tdep.h: Add include guard.
4933         * arch/xtensa.h: Rename include guard.
4934         * arch/tic6x.h: Add include guard.
4935         * arch/i386.h: Add include guard.
4936         * arch/arm.h: Rename include guard.
4937         * arch/arm-linux.h: Rename include guard.
4938         * arch/arm-get-next-pcs.h: Rename include guard.
4939         * arch/amd64.h: Add include guard.
4940         * arch/aarch64-insn.h: Rename include guard.
4941         * arch-utils.h: Rename include guard.
4942         * annotate.h: Add include guard.
4943         * amd64-darwin-tdep.h: Rename include guard.
4944         * aarch64-linux-tdep.h: Add include guard.
4945         * aarch64-fbsd-tdep.h: Add include guard.
4946         * aarch32-linux-nat.h: Add include guard.
4947
4948 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * macrotab.c (macro_define_internal): New function that
4951         factorizes macro_define_object_internal and macro_define_function
4952         code.
4953         (macro_define_object_internal): Use macro_define_internal.
4954         (macro_define_function): Likewise.
4955
4956 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4957
4958         * macrocmd.c (extract_identifier): Return
4959         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4960         callers.
4961
4962 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4963
4964         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4965
4966 2019-02-05  Tom Tromey  <tom@tromey.com>
4967
4968         * target.c (target_stack::unpush): Move assertion earlier.
4969
4970 2019-01-30  Tom Tromey  <tom@tromey.com>
4971
4972         PR python/23615:
4973         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4974         (gdbpy_parse_and_eval): Likewise.
4975         * python/python-internal.h (gdbpy_allow_threads): New class.
4976
4977 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4978
4979         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4980         (aarch64_fbsd_fpregmap): Move earlier.
4981         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4982         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4983         instead of individual calls to trad_frame_set_reg_addr.
4984         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4985         earlier.
4986         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4987         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4988         instead of individual calls to trad_frame_set_reg_addr.
4989
4990 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4991
4992         * CONTRIBUTE: Replace contribution list with wiki link.
4993
4994 2019-01-25  Tom Tromey  <tom@tromey.com>
4995
4996         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4997
4998 2019-01-25  Tom Tromey  <tom@tromey.com>
4999
5000         * xtensa-linux-nat.c: Fix common/ includes.
5001         * xml-support.h: Fix common/ includes.
5002         * xml-support.c: Fix common/ includes.
5003         * x86-linux-nat.c: Fix common/ includes.
5004         * windows-nat.c: Fix common/ includes.
5005         * varobj.h: Fix common/ includes.
5006         * varobj.c: Fix common/ includes.
5007         * value.c: Fix common/ includes.
5008         * valops.c: Fix common/ includes.
5009         * utils.c: Fix common/ includes.
5010         * unittests/xml-utils-selftests.c: Fix common/ includes.
5011         * unittests/utils-selftests.c: Fix common/ includes.
5012         * unittests/unpack-selftests.c: Fix common/ includes.
5013         * unittests/tracepoint-selftests.c: Fix common/ includes.
5014         * unittests/style-selftests.c: Fix common/ includes.
5015         * unittests/string_view-selftests.c: Fix common/ includes.
5016         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5017         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5018         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5019         * unittests/rsp-low-selftests.c: Fix common/ includes.
5020         * unittests/parse-connection-spec-selftests.c: Fix common/
5021         includes.
5022         * unittests/optional-selftests.c: Fix common/ includes.
5023         * unittests/offset-type-selftests.c: Fix common/ includes.
5024         * unittests/observable-selftests.c: Fix common/ includes.
5025         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5026         * unittests/memrange-selftests.c: Fix common/ includes.
5027         * unittests/memory-map-selftests.c: Fix common/ includes.
5028         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5029         * unittests/function-view-selftests.c: Fix common/ includes.
5030         * unittests/environ-selftests.c: Fix common/ includes.
5031         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5032         * unittests/common-utils-selftests.c: Fix common/ includes.
5033         * unittests/cli-utils-selftests.c: Fix common/ includes.
5034         * unittests/array-view-selftests.c: Fix common/ includes.
5035         * ui-file.c: Fix common/ includes.
5036         * tui/tui-io.c: Fix common/ includes.
5037         * tracepoint.h: Fix common/ includes.
5038         * tracepoint.c: Fix common/ includes.
5039         * tracefile-tfile.c: Fix common/ includes.
5040         * top.h: Fix common/ includes.
5041         * top.c: Fix common/ includes.
5042         * thread.c: Fix common/ includes.
5043         * target/waitstatus.h: Fix common/ includes.
5044         * target/waitstatus.c: Fix common/ includes.
5045         * target.h: Fix common/ includes.
5046         * target.c: Fix common/ includes.
5047         * target-memory.c: Fix common/ includes.
5048         * target-descriptions.c: Fix common/ includes.
5049         * symtab.h: Fix common/ includes.
5050         * symfile.c: Fix common/ includes.
5051         * stap-probe.c: Fix common/ includes.
5052         * spu-linux-nat.c: Fix common/ includes.
5053         * sparc-nat.c: Fix common/ includes.
5054         * source.c: Fix common/ includes.
5055         * solib.c: Fix common/ includes.
5056         * solib-target.c: Fix common/ includes.
5057         * ser-unix.c: Fix common/ includes.
5058         * ser-tcp.c: Fix common/ includes.
5059         * ser-pipe.c: Fix common/ includes.
5060         * ser-base.c: Fix common/ includes.
5061         * selftest-arch.c: Fix common/ includes.
5062         * s12z-tdep.c: Fix common/ includes.
5063         * rust-exp.y: Fix common/ includes.
5064         * rs6000-aix-tdep.c: Fix common/ includes.
5065         * riscv-tdep.c: Fix common/ includes.
5066         * remote.c: Fix common/ includes.
5067         * remote-notif.h: Fix common/ includes.
5068         * remote-fileio.h: Fix common/ includes.
5069         * remote-fileio.c: Fix common/ includes.
5070         * regcache.h: Fix common/ includes.
5071         * regcache.c: Fix common/ includes.
5072         * record-btrace.c: Fix common/ includes.
5073         * python/python.c: Fix common/ includes.
5074         * python/py-type.c: Fix common/ includes.
5075         * python/py-inferior.c: Fix common/ includes.
5076         * progspace.h: Fix common/ includes.
5077         * producer.c: Fix common/ includes.
5078         * procfs.c: Fix common/ includes.
5079         * proc-api.c: Fix common/ includes.
5080         * printcmd.c: Fix common/ includes.
5081         * ppc-linux-nat.c: Fix common/ includes.
5082         * parser-defs.h: Fix common/ includes.
5083         * osdata.c: Fix common/ includes.
5084         * obsd-nat.c: Fix common/ includes.
5085         * nat/x86-linux.c: Fix common/ includes.
5086         * nat/x86-linux-dregs.c: Fix common/ includes.
5087         * nat/x86-dregs.h: Fix common/ includes.
5088         * nat/x86-dregs.c: Fix common/ includes.
5089         * nat/ppc-linux.c: Fix common/ includes.
5090         * nat/mips-linux-watch.h: Fix common/ includes.
5091         * nat/mips-linux-watch.c: Fix common/ includes.
5092         * nat/linux-waitpid.c: Fix common/ includes.
5093         * nat/linux-ptrace.h: Fix common/ includes.
5094         * nat/linux-ptrace.c: Fix common/ includes.
5095         * nat/linux-procfs.c: Fix common/ includes.
5096         * nat/linux-personality.c: Fix common/ includes.
5097         * nat/linux-osdata.c: Fix common/ includes.
5098         * nat/linux-namespaces.c: Fix common/ includes.
5099         * nat/linux-btrace.h: Fix common/ includes.
5100         * nat/linux-btrace.c: Fix common/ includes.
5101         * nat/fork-inferior.c: Fix common/ includes.
5102         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5103         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5104         * nat/aarch64-linux.c: Fix common/ includes.
5105         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5106         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5107         * namespace.h: Fix common/ includes.
5108         * mips-linux-tdep.c: Fix common/ includes.
5109         * minsyms.c: Fix common/ includes.
5110         * mi/mi-parse.h: Fix common/ includes.
5111         * mi/mi-main.c: Fix common/ includes.
5112         * mi/mi-cmd-env.c: Fix common/ includes.
5113         * memrange.h: Fix common/ includes.
5114         * memattr.c: Fix common/ includes.
5115         * maint.h: Fix common/ includes.
5116         * maint.c: Fix common/ includes.
5117         * main.c: Fix common/ includes.
5118         * machoread.c: Fix common/ includes.
5119         * location.c: Fix common/ includes.
5120         * linux-thread-db.c: Fix common/ includes.
5121         * linux-nat.c: Fix common/ includes.
5122         * linux-fork.c: Fix common/ includes.
5123         * inline-frame.c: Fix common/ includes.
5124         * infrun.c: Fix common/ includes.
5125         * inflow.c: Fix common/ includes.
5126         * inferior.h: Fix common/ includes.
5127         * inferior.c: Fix common/ includes.
5128         * infcmd.c: Fix common/ includes.
5129         * inf-ptrace.c: Fix common/ includes.
5130         * inf-child.c: Fix common/ includes.
5131         * ia64-linux-nat.c: Fix common/ includes.
5132         * i387-tdep.c: Fix common/ includes.
5133         * i386-tdep.c: Fix common/ includes.
5134         * i386-linux-tdep.c: Fix common/ includes.
5135         * i386-linux-nat.c: Fix common/ includes.
5136         * i386-go32-tdep.c: Fix common/ includes.
5137         * i386-fbsd-tdep.c: Fix common/ includes.
5138         * i386-fbsd-nat.c: Fix common/ includes.
5139         * guile/scm-type.c: Fix common/ includes.
5140         * guile/guile.c: Fix common/ includes.
5141         * go32-nat.c: Fix common/ includes.
5142         * gnu-nat.c: Fix common/ includes.
5143         * gdbthread.h: Fix common/ includes.
5144         * gdbarch-selftests.c: Fix common/ includes.
5145         * gdb_usleep.c: Fix common/ includes.
5146         * gdb_select.h: Fix common/ includes.
5147         * gdb_bfd.c: Fix common/ includes.
5148         * gcore.c: Fix common/ includes.
5149         * fork-child.c: Fix common/ includes.
5150         * findvar.c: Fix common/ includes.
5151         * fbsd-nat.c: Fix common/ includes.
5152         * event-top.c: Fix common/ includes.
5153         * event-loop.c: Fix common/ includes.
5154         * dwarf2read.c: Fix common/ includes.
5155         * dwarf2loc.c: Fix common/ includes.
5156         * dwarf2-frame.c: Fix common/ includes.
5157         * dwarf-index-cache.c: Fix common/ includes.
5158         * dtrace-probe.c: Fix common/ includes.
5159         * disasm-selftests.c: Fix common/ includes.
5160         * defs.h: Fix common/ includes.
5161         * csky-tdep.c: Fix common/ includes.
5162         * cp-valprint.c: Fix common/ includes.
5163         * cp-support.h: Fix common/ includes.
5164         * cp-support.c: Fix common/ includes.
5165         * corelow.c: Fix common/ includes.
5166         * completer.h: Fix common/ includes.
5167         * completer.c: Fix common/ includes.
5168         * compile/compile.c: Fix common/ includes.
5169         * compile/compile-loc2c.c: Fix common/ includes.
5170         * compile/compile-cplus-types.c: Fix common/ includes.
5171         * compile/compile-cplus-symbols.c: Fix common/ includes.
5172         * command.h: Fix common/ includes.
5173         * cli/cli-dump.c: Fix common/ includes.
5174         * cli/cli-cmds.c: Fix common/ includes.
5175         * charset.c: Fix common/ includes.
5176         * build-id.c: Fix common/ includes.
5177         * btrace.h: Fix common/ includes.
5178         * btrace.c: Fix common/ includes.
5179         * breakpoint.h: Fix common/ includes.
5180         * breakpoint.c: Fix common/ includes.
5181         * ax.h:
5182         (enum agent_op): Fix common/ includes.
5183         * ax-general.c (struct aop_map): Fix common/ includes.
5184         * ax-gdb.c: Fix common/ includes.
5185         * auxv.c: Fix common/ includes.
5186         * auto-load.c: Fix common/ includes.
5187         * arm-tdep.c: Fix common/ includes.
5188         * arch/riscv.c: Fix common/ includes.
5189         * arch/ppc-linux-common.c: Fix common/ includes.
5190         * arch/i386.c: Fix common/ includes.
5191         * arch/arm.c: Fix common/ includes.
5192         * arch/arm-linux.c: Fix common/ includes.
5193         * arch/arm-get-next-pcs.c: Fix common/ includes.
5194         * arch/amd64.c: Fix common/ includes.
5195         * arch/aarch64.c: Fix common/ includes.
5196         * arch/aarch64-insn.c: Fix common/ includes.
5197         * arch-utils.c: Fix common/ includes.
5198         * amd64-windows-tdep.c: Fix common/ includes.
5199         * amd64-tdep.c: Fix common/ includes.
5200         * amd64-sol2-tdep.c: Fix common/ includes.
5201         * amd64-obsd-tdep.c: Fix common/ includes.
5202         * amd64-nbsd-tdep.c: Fix common/ includes.
5203         * amd64-linux-tdep.c: Fix common/ includes.
5204         * amd64-linux-nat.c: Fix common/ includes.
5205         * amd64-fbsd-tdep.c: Fix common/ includes.
5206         * amd64-fbsd-nat.c: Fix common/ includes.
5207         * amd64-dicos-tdep.c: Fix common/ includes.
5208         * amd64-darwin-tdep.c: Fix common/ includes.
5209         * agent.c: Fix common/ includes.
5210         * ada-lang.h: Fix common/ includes.
5211         * ada-lang.c: Fix common/ includes.
5212         * aarch64-tdep.c: Fix common/ includes.
5213
5214 2019-01-25  Tom Tromey  <tom@tromey.com>
5215
5216         * common/create-version.sh: Use common/version.h.
5217
5218 2019-01-24  Pedro Alves  <palves@redhat.com>
5219
5220         * infrun.c (signal_stop, signal_print, signal_program)
5221         (signal_catch, signal_pass): Now arrays instead of pointers.
5222         (update_signals_program_target, do_target_resume)
5223         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5224         * linux-nat.c (linux_nat_target::pass_signals)
5225         (linux_nat_target::create_inferior, linux_nat_target::attach):
5226         Adjust.
5227         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5228         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5229         * procfs.c (procfs_target::pass_signals): Adjust.
5230         * record-full.c (record_full_target::resume): Adjust.
5231         * remote.c (remote_target::pass_signals)
5232         (remote_target::program_signals): Adjust.
5233         * target-debug.h (target_debug_print_signals): Now takes a
5234         gdb::array_view as parameter.  Adjust.
5235         * target.h (target_ops) <pass_signals, program_signals>: Replace
5236         pointer and length parameters with gdb::array_view.
5237         (target_pass_signals, target_program_signals): Likewise.
5238         * target-delegates.c: Regenerate.
5239
5240 2019-01-24  Pedro Alves  <palves@redhat.com>
5241
5242         * common/forward-scope-exit.h
5243         (forward_scope_exit::forward_scope_exit): Pass arguments to
5244         m_bind_function directly, instead of creating a std::bind and
5245         copying that.
5246
5247 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5248
5249         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5250         for static members.
5251         (pass_in_v_vfp_candidate): Likewise.
5252
5253 2019-01-23  Tom Tromey  <tom@tromey.com>
5254             Pedro Alves  <palves@redhat.com>
5255
5256         * regcache.c (class regcache_invalidator): Remove.
5257         (regcache::raw_write): Use make_scope_exit.
5258
5259 2019-01-23  Tom Tromey  <tom@tromey.com>
5260
5261         * ui-out.h (class ui_out_emit_type): Update comment.
5262
5263 2019-01-23  Tom Tromey  <tom@tromey.com>
5264
5265         * infrun.c (fetch_inferior_event): Update comment.
5266
5267 2019-01-23  Tom Tromey  <tom@tromey.com>
5268             Pedro Alves  <palves@redhat.com>
5269
5270         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5271         parameter.
5272         (fetch_inferior_event): Use SCOPE_EXIT.
5273
5274
5275 2019-01-23  Tom Tromey  <tom@tromey.com>
5276             Pedro Alves  <palves@redhat.com>
5277
5278         * infrun.c (disable_thread_events): Delete.
5279         (stop_all_threads): Use SCOPE_EXIT.
5280
5281 2019-01-23  Tom Tromey  <tom@tromey.com>
5282             Pedro Alves  <palves@redhat.com>
5283
5284         * symfile.c: Include forward-scope-exit.h.
5285         (clear_symtab_users_cleanup): Replace forward declaration with
5286         a FORWARD_SCOPE_EXIT.
5287         (syms_from_objfile_1): Use the forward_scope_exit and
5288         gdb::optional instead of cleanup_function.
5289         (reread_symbols): Use the forward_scope_exit instead of
5290         cleanup_function.
5291         (clear_symtab_users_cleanup): Remove function.
5292
5293 2019-01-23  Tom Tromey  <tom@tromey.com>
5294             Pedro Alves  <palves@redhat.com>
5295
5296         * linux-nat.c: Include scope-exit.h.
5297         (cleanup_target_stop): Remove.
5298         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5299         SCOPE_EXIT.
5300
5301 2019-01-23  Tom Tromey  <tom@tromey.com>
5302             Pedro Alves  <palves@redhat.com>
5303
5304         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5305         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5306
5307 2019-01-23  Tom Tromey  <tom@tromey.com>
5308             Andrew Burgess  <andrew.burgess@embecosm.com>
5309             Pedro Alves  <palves@redhat.com>
5310
5311         * infrun.c (fetch_inferior_event): Use scope_exit.
5312         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5313         * top.c (execute_command): Use scope_exit.
5314         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5315         * utils.c (do_bpstat_clear_actions_cleanup)
5316         (make_bpstat_clear_actions_cleanup): Remove.
5317
5318 2019-01-23  Tom Tromey  <tom@tromey.com>
5319             Pedro Alves  <palves@redhat.com>
5320
5321         * infrun.c: Include "common/scope-exit.h"
5322         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5323         (wait_for_inferior): Use SCOPE_EXIT.
5324         (fetch_inferior_event): Use scope_exit.
5325
5326 2019-01-23  Tom Tromey  <tom@tromey.com>
5327             Pedro Alves  <palves@redhat.com>
5328
5329         * breakpoint.c (create_breakpoint): Remove cleanup.
5330
5331 2019-01-23  Tom Tromey  <tom@tromey.com>
5332             Andrew Burgess  <andrew.burgess@embecosm.com>
5333             Pedro Alves  <palves@redhat.com>
5334
5335 2019-01-23  Pedro Alves  <palves@redhat.com>
5336
5337         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5338
5339 2019-01-23  Pedro Alves  <palves@redhat.com>
5340             Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * gdbthread.h: Include "common/forward-scope-exit.h".
5343         (scoped_finish_thread_state): Redefine custom class in terms of
5344         forward_scope_exit.
5345
5346 2019-01-23  Pedro Alves  <palves@redhat.com>
5347             Andrew Burgess  <andrew.burgess@embecosm.com>
5348
5349         * common/forward-scope-exit.h: New file.
5350
5351 2019-01-23  Pedro Alves  <palves@redhat.com>
5352             Andrew Burgess  <andrew.burgess@embecosm.com>
5353             Tom Tromey  <tom@tromey.com>
5354
5355         * common/scope-exit.h: New file.
5356
5357 2019-01-23  Pedro Alves  <palves@redhat.com>
5358
5359         * common/preprocessor.h (ESC): Rename to ...
5360         (ESC_PARENS): ... this.
5361         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5362         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5363
5364 2019-01-23  Tom Tromey  <tom@tromey.com>
5365
5366         * language.h (class scoped_switch_to_sym_language_if_auto):
5367         Initialize m_lang in both cases.
5368
5369 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5370
5371         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5372         with XCNEW.
5373
5374 2019-01-22  Tom Tromey  <tom@tromey.com>
5375
5376         * corelow.c: Do not include sys/file.h.
5377
5378 2019-01-22  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-wingeneral.h: Include gdb_curses.h.
5381
5382 2019-01-22  Tom Tromey  <tom@tromey.com>
5383
5384         * source-cache.h (class source_cache) <get_source_lines,
5385         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5386
5387 2019-01-22  Tom Tromey  <tom@tromey.com>
5388
5389         * remote-fileio.h (struct remote_target): Declare.
5390
5391 2019-01-22  Tom Tromey  <tom@tromey.com>
5392
5393         * python/py-arch.c: Do not include py-ref.h.
5394         * python/py-bpevent.c: Do not include py-ref.h.
5395         * python/py-cmd.c: Do not include py-ref.h.
5396         * python/py-continueevent.c: Do not include py-ref.h.
5397         * python/py-event.h: Do not include py-ref.h.
5398         * python/py-evtregistry.c: Do not include py-ref.h.
5399         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5400         * python/py-frame.c: Do not include py-ref.h.
5401         * python/py-framefilter.c: Do not include py-ref.h.
5402         * python/py-function.c: Do not include py-ref.h.
5403         * python/py-infevents.c: Do not include py-ref.h.
5404         * python/py-linetable.c: Do not include py-ref.h.
5405         * python/py-objfile.c: Do not include py-ref.h.
5406         * python/py-param.c: Do not include py-ref.h.
5407         * python/py-prettyprint.c: Do not include py-ref.h.
5408         * python/py-progspace.c: Do not include py-ref.h.
5409         * python/py-symbol.c: Do not include py-ref.h.
5410         * python/py-symtab.c: Do not include py-ref.h.
5411         * python/py-type.c: Do not include py-ref.h.
5412         * python/py-unwind.c: Do not include py-ref.h.
5413         * python/py-utils.c: Do not include py-ref.h.
5414         * python/py-value.c: Do not include py-ref.h.
5415         * python/py-varobj.c: Do not include py-ref.h.
5416         * python/py-xmethods.c: Do not include py-ref.h.
5417         * python/python.c: Do not include py-ref.h.
5418         * varobj.c: Do not include py-ref.h.
5419
5420 2019-01-22  Tom Tromey  <tom@tromey.com>
5421
5422         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5423         keyword for bcache.
5424
5425 2019-01-22  Tom Tromey  <tom@tromey.com>
5426
5427         * compile/compile-cplus-types.c: Remove a comment by #include.
5428
5429 2019-01-22  Tom Tromey  <tom@tromey.com>
5430
5431         * compile/gcc-c-plugin.h: Include compile-internal.h.
5432
5433 2019-01-22  Tom Tromey  <tom@tromey.com>
5434
5435         * stabsread.c (EXTERN): Do not define.
5436         (symnum, next_symbol_text_func, processing_gcc_compilation)
5437         (within_function, global_sym_chain, global_stabs)
5438         (previous_stab_code, this_object_header_files)
5439         (n_this_object_header_files)
5440         (n_allocated_this_object_header_files): Define.
5441         * stabsread.h (EXTERN): Never define.  Use "extern".
5442
5443 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5444
5445         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5446         history_value.
5447
5448 2019-01-21  Tom Tromey  <tom@tromey.com>
5449
5450         * ui-out.c: Fix includes.
5451         * tui/tui-source.c: Fix includes.
5452         * target.c: Fix includes.
5453         * remote.c: Fix includes.
5454         * regcache.c: Fix includes.
5455         * python/py-block.c: Fix includes.
5456         * printcmd.c: Fix includes.
5457         * or1k-tdep.c: Fix includes.
5458         * mi/mi-main.c: Fix includes.
5459         * m32r-tdep.c: Fix includes.
5460         * csky-tdep.c: Fix includes.
5461         * compile/compile-cplus-types.c: Fix includes.
5462         * cli/cli-interp.c: Fix includes.
5463
5464 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5465
5466         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5467         for padding.
5468
5469 2019-01-16  Tom Tromey  <tom@tromey.com>
5470
5471         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5472         earlier.
5473         (struct objfile) <msymbols_range>: Move from top level.
5474         <msymbols>: New method.
5475         (class objfile_msymbols): Remove.
5476         * symtab.c (default_collect_symbol_completion_matches_break_on):
5477         Update.
5478         * symmisc.c (dump_msymbols): Update.
5479         * stabsread.c (scan_file_globals): Update.
5480         * objc-lang.c (info_selectors_command, info_classes_command)
5481         (find_methods): Update.
5482         * minsyms.c (find_solib_trampoline_target): Update.
5483         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5484         * coffread.c (coff_symfile_read): Update.
5485         * ada-lang.c (ada_lookup_simple_minsym)
5486         (ada_collect_symbol_completion_matches): Update.
5487
5488 2019-01-16  Tom Tromey  <tom@tromey.com>
5489
5490         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5491         type.  Remove no-argument constructor.
5492         <iterator::operator++>: Simplify.
5493         <begin>: Update.
5494         <end>: Use minimal_symbol_count.
5495
5496 2019-01-16  Tom Tromey  <tom@tromey.com>
5497
5498         * objfiles.h (struct objfile) <psymtabs>: New method.
5499         (class objfile_psymtabs): Remove.
5500         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5501         typedef.
5502         <range>: New method.
5503         (require_partial_symbols): Change return type.
5504         * psymtab.c (require_partial_symbols)
5505         (psym_expand_symtabs_matching): Update.
5506         * mdebugread.c (parse_partial_symbols): Update.
5507         * dbxread.c (dbx_end_psymtab): Update.
5508
5509 2019-01-15  Tom Tromey  <tom@tromey.com>
5510
5511         * symtab.c (lookup_objfile_from_block)
5512         (lookup_symbol_in_objfile_symtabs)
5513         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5514         (find_line_symtab, info_sources_command)
5515         (default_collect_symbol_completion_matches_break_on)
5516         (make_source_files_completion_list): Update.
5517         * symmisc.c (print_objfile_statistics, dump_objfile)
5518         (maintenance_print_symbols, maintenance_info_symtabs)
5519         (maintenance_check_symtabs, maintenance_info_line_tables):
5520         Update.
5521         * source.c (select_source_symtab)
5522         (forget_cached_source_info_for_objfile): Update.
5523         * objfiles.h (class objfile_compunits): Remove.
5524         (struct objfile) <compunits_range>: New typedef.
5525         (compunits): New method.
5526         * objfiles.c (objfile_relocate1): Update.
5527         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5528         * maint.c (count_symtabs_and_blocks): Update.
5529         * linespec.c (iterate_over_all_matching_symtabs): Update.
5530         * cp-support.c (add_symbol_overload_list_qualified): Update.
5531         * coffread.c (coff_symtab_read): Update.
5532         * ada-lang.c (add_nonlocal_symbols)
5533         (ada_collect_symbol_completion_matches)
5534         (ada_add_global_exceptions): Update.
5535
5536 2019-01-15  Tom Tromey  <tom@tromey.com>
5537
5538         * progspace.h (program_space) <objfiles_safe_range>: New
5539         typedef.
5540         <objfiles_safe>: New method.
5541         * objfiles.h (class all_objfiles_safe): Remove.
5542         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5543         * jit.c (jit_inferior_exit_hook): Update.
5544
5545 2019-01-17  Tom Tromey  <tom@tromey.com>
5546
5547         * progspace.h (program_space) <objfiles_range>: New typedef.
5548         <objfiles>: New method.
5549         <objfiles_head>: Rename from objfiles.
5550         (object_files): Update.
5551         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5552         * guile/scm-pretty-print.c
5553         (ppscm_find_pretty_printer_from_objfiles): Update.
5554         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5555         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5556         Update.
5557         * python/py-progspace.c (pspy_get_objfiles): Update.
5558         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5559         Update.
5560         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5561         (objfpy_lookup_objfile_by_build_id): Update.
5562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5563         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5564         Update.
5565         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5566         (expand_symtab_containing_pc, lookup_objfile_from_block)
5567         (lookup_static_symbol, basic_lookup_transparent_type)
5568         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5569         (find_line_symtab, info_sources_command)
5570         (default_collect_symbol_completion_matches_break_on)
5571         (make_source_files_completion_list, find_main_name): Update.
5572         * symmisc.c (print_symbol_bcache_statistics)
5573         (print_objfile_statistics, maintenance_print_symbols)
5574         (maintenance_print_msymbols, maintenance_print_objfiles)
5575         (maintenance_info_symtabs, maintenance_check_symtabs)
5576         (maintenance_expand_symtabs, maintenance_info_line_tables):
5577         Update.
5578         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5579         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5580         (map_overlay_command, unmap_overlay_command)
5581         (simple_overlay_update, expand_symtabs_matching)
5582         (map_symbol_filenames): Update.
5583         * symfile-debug.c (set_debug_symfile): Update.
5584         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5585         Update.
5586         * source.c (select_source_symtab, forget_cached_source_info):
5587         Update.
5588         * solib.c (solib_read_symbols): Update.
5589         * solib-spu.c (append_ocl_sos): Update.
5590         * psymtab.c (maintenance_print_psymbols)
5591         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5592         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5593         * printcmd.c (info_symbol_command): Update.
5594         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5595         Update.
5596         * objfiles.h (class all_objfiles): Remove.
5597         * objfiles.c (have_partial_symbols, have_full_symbols)
5598         (have_minimal_symbols, qsort_cmp, update_section_map)
5599         (shared_objfile_contains_address_p)
5600         (default_iterate_over_objfiles_in_search_order): Update.
5601         * objc-lang.c (info_selectors_command, info_classes_command)
5602         (find_methods): Update.
5603         * minsyms.c (find_solib_trampoline_target): Update.
5604         * maint.c (maintenance_info_sections)
5605         (maintenance_translate_address, count_symtabs_and_blocks):
5606         Update.
5607         * main.c (captured_main_1): Update.
5608         * linux-thread-db.c (try_thread_db_load_from_pdir)
5609         (has_libpthread): Update.
5610         * linespec.c (iterate_over_all_matching_symtabs)
5611         (search_minsyms_for_name): Update.
5612         * jit.c (jit_find_objf_with_entry_addr): Update.
5613         * hppa-tdep.c (find_unwind_entry)
5614         (hppa_lookup_stub_minimal_symbol): Update.
5615         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5616         Update.
5617         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5618         (elf_gnu_ifunc_resolve_by_got): Update.
5619         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5620         * dwarf-index-write.c (save_gdb_index_command): Update.
5621         * cp-support.c (add_symbol_overload_list_qualified): Update.
5622         * breakpoint.c (create_overlay_event_breakpoint)
5623         (create_longjmp_master_breakpoint)
5624         (create_std_terminate_master_breakpoint)
5625         (create_exception_master_breakpoint): Update.
5626         * blockframe.c (find_pc_partial_function): Update.
5627         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5628         (ada_collect_symbol_completion_matches)
5629         (ada_add_global_exceptions): Update.
5630
5631 2019-01-17  Tom Tromey  <tom@tromey.com>
5632
5633         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5634         declare VEC.
5635         (solib_target_parse_libraries): Change return type.
5636         (library_list_start_segment, library_list_start_section)
5637         (library_list_end_library, library_list_start_library); Update.
5638         (solib_target_free_library_list): Remove.
5639         (solib_target_parse_libraries): Remove cleanup.  Change return
5640         type.
5641         (solib_target_current_sos): Update.
5642
5643 2019-01-17  Tom Tromey  <tromey@bapiya>
5644
5645         * valprint.c: Replace "the the" with "the".
5646         * symtab.c: Replace "the the" with "the".
5647         * solib.c: Replace "the the" with "the".
5648         * solib-dsbt.c: Replace "the the" with "the".
5649         * linespec.c: Replace "the the" with "the".
5650         * dwarf2loc.h: Replace "the the" with "the".
5651         * amd64-windows-tdep.c: Replace "the the" with "the".
5652         * aarch64-tdep.c: Replace "the the" with "the".
5653
5654 2019-01-16  Keith Seitz  <keiths@redhat.com>
5655
5656         PR gdb/23773
5657         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5658         <builder>: Rename to ..
5659         <m_builder>: ... this and make private.
5660         (dwarf2_cu::get_builder): New method.  Change all users of
5661         `builder' to use this method.
5662         (dwarf2_start_symtab): Move to ...
5663         (dwarf2_cu::start_symtab): ... here.  Update all callers
5664         (setup_type_unit_groups): Move to ...
5665         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5666         callers.
5667         (dwarf2_cu::reset_builder): New method.
5668         (process_full_compunit, process_full_type_unit): Use
5669         dwarf2_cu::reset_builder.
5670         (follow_die_offset): Record the ancestor CU if it is different
5671         from the followed DIE's CU.
5672         (follow_die_sig_1): Likewise.
5673
5674 2019-01-15  Tom Tromey  <tom@tromey.com>
5675
5676         * remote.c (class remote_state) <buf>: Now a char_vector.
5677         <buf_size>: Remove.
5678         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5679         parameter.
5680         (remote_target::getpkt_or_notif_sane_1)
5681         (remote_target::getpkt_sane)
5682         (remote_target::getpkt_or_notif_sane): Likewise.
5683         (class remote_target) <putpkt>: New overload.
5684         (remote_target::read_frame): Change type of "buf_p".  Remove
5685         sizeof_p parameter.
5686         (packet_ok): New overload.
5687         (packet_check_result): New overload.
5688         Update all uses.
5689
5690 2019-01-14  Tom Tromey  <tom@tromey.com>
5691
5692         * remote-notif.c (handle_notification, remote_notif_ack)
5693         (remote_notif_parse): Make "buf" const.
5694         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5695         const.
5696         (remote_notif_parse, remote_notif_ack, handle_notification):
5697         Likewise.
5698         * remote.c (remote_notif_stop_parse): Make "buf" const.
5699         (remote_target::remote_parse_stop_reply): Make "buf" const.
5700         (remote_notif_stop_ack): Make "buf" const.
5701
5702 2019-01-14  Tom Tromey  <tom@tromey.com>
5703
5704         * remote.c (remote_console_output): Make parameter const.
5705
5706 2019-01-14  Tom Tromey  <tom@tromey.com>
5707
5708         * target-debug.h (target_debug_print_signals): Constify.
5709         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5710         * procfs.c (procfs_target::pass_signals): Update.
5711         * linux-nat.c (linux_nat_target::pass_signals): Update.
5712         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5713         * target-delegates.c: Rebuild.
5714         * remote.c (remote_target::program_signals): Update.
5715         (remote_target::pass_signals): Update.
5716         * target.c (target_pass_signals): Constify argument.
5717         (target_program_signals): Likewise.
5718         * target.h (struct target_ops) <pass_signals, program_signals>:
5719         Constify argument.
5720         (target_pass_signals, target_program_signals): Constify argument.
5721
5722 2019-01-14  Tom Tromey  <tom@tromey.com>
5723
5724         PR tui/28819:
5725         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5726
5727 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5728
5729         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5730         field.
5731         * rs6000-tdep.c: Include reggroups.h.
5732         (IS_V_ALIAS_PSEUDOREG): Define.
5733         (rs6000_register_name): Return names for the "vX" aliases.
5734         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5735         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5736         aliases.  Call default_register_reggroup_p for all other
5737         pseudo-registers.
5738         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5739         New functions.
5740         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5741         Handle "vX" aliases.
5742         (v_alias_pseudo_register_collect): New function.
5743         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5744         (rs6000_gdbarch_init): Initialize "vX" aliases as
5745         pseudo-registers.  Restore registration of
5746         rs6000_pseudo_register_reggroup_p with
5747         set_tdesc_pseudo_register_reggroup_p.
5748
5749 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5750
5751         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5752         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5753         set_gdbarch_num_pseudo_regs.
5754
5755 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5756
5757         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5758         Remove arg prefixname, add do_set and do_show.
5759         Add member functions set_list and show_list.
5760         * cli/cli-style.c (class cli_style_option): Update accordingly.
5761         (style_set_list): Move to file scope.
5762         (style_show_list): Likewise.
5763         (set_style): Call help_list.
5764         (show_style): Call cmd_show_list.
5765         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5766         Update to use the new macro.
5767
5768 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5769
5770         * ada-lang.c (_initialize_ada_language): Expand the help text
5771         for the "catch exception" command.
5772
5773 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5774
5775         * symtab.c (matching_obj_sections): Initialize obj,
5776         declare it closer to its usage.
5777
5778 2019-01-10  Tom Tromey  <tom@tromey.com>
5779
5780         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5781         (basic_inf_threads_range): Remove.
5782         (inf_threads_range, inf_non_exited_threads_range)
5783         (safe_inf_threads_range): Use next_adapter.
5784
5785 2019-01-10  Keith Seitz  <keiths@redhat.com>
5786
5787         PR gdb/23712
5788         PR symtab/23010
5789         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5790         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5791
5792 2019-01-10  Keith Seitz  <keiths@redhat.com>
5793
5794         PR gdb/23712
5795         PR symtab/23010
5796         * dictionary.c (pending_to_vector): Remove.
5797         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5798         Remove _1 suffix, replacing functions of the same name.  Update
5799         all callers.
5800         (dict_create_hashed, dict_create_hashed_expandable)
5801         (dict_create_linear, dict_create_linear_expandable, dict_free)
5802         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5803         Make functions static.
5804
5805 2019-01-10  Keith Seitz  <keiths@redhat.com>
5806
5807         PR gdb/23712
5808         PR symtab/23010
5809         * dictionary.h (struct dictionary): Replace declaration with
5810         multidictionary.
5811         (dict_create_hashed, dict_create_hashed_expandable)
5812         (dict_create_linear, dict_create_linear_expandable)
5813         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5814         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5815         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5816         taking multidictionary argument.
5817         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5818         * block.h (struct block) <dict>: Change to multidictionary
5819         and rename `multidict'.
5820         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5821         symmisc.c: Update all dictionary references to multidictionary.
5822
5823 2019-01-10  Keith Seitz  <keiths@redhat.com>
5824
5825         PR gdb/23712
5826         PR symtab/23010
5827         * dictionary.c: Include unordered_map.
5828         (pending_to_vector): New function.
5829         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5830         Rewrite the non-"_1" functions to take vector instead
5831         of linked list.
5832         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5833         "new" _1 versions of the same name.
5834         (multidictionary): Define.
5835         (std::hash<enum language): New definition.
5836         (collate_pending_symbols_by_language, mdict_create_hashed)
5837         (mdict_create_hashed_expandable, mdict_create_linear)
5838         (mdict_create_linear_expandable, mdict_free)
5839         (find_language_dictionary, create_new_language_dictionary)
5840         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5841         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5842         (mdict_size, mdict_empty): New functions.
5843         * dictionary.h (mdict_iterator): Define.
5844
5845 2019-01-10  Pedro Alves  <palves@redhat.com>
5846
5847         * breakpoint.c (read_uploaded_action)
5848         (create_tracepoint_from_upload): Adjust to use
5849         gdb::unique_xmalloc_ptr.
5850         * ctf.c (ctf_write_uploaded_tp):
5851         (SET_ARRAY_FIELD): Use emplace_back.
5852         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5853         * tracefile-tfile.c (tfile_write_uploaded_tp):
5854         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5855         gdb::unique_xmalloc_ptr.
5856         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5857         at_string, cond_string, cmd_strings>: Replace char pointers
5858         with gdb::unique_xmalloc_ptr.
5859
5860 2019-01-10  Pedro Alves  <palves@redhat.com>
5861
5862         * solib-target.c (library_list_start_library): Don't xstrdup name.
5863
5864 2019-01-10  Pedro Alves  <palves@redhat.com>
5865
5866         * mdebugread.c (parse_partial_symbols): Use
5867         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5868
5869 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * linux-fork.c (scoped_switch_fork_info)
5872         <~scoped_switch_fork_info>: Fix incorrect variable name.
5873
5874 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * linux-fork.c (scoped_switch_fork_info)
5877         <scoped_switch_fork_info>: Make explicit.
5878         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5879
5880 2019-01-10  Tom Tromey  <tom@tromey.com>
5881
5882         * objfiles.h (objfile::reset_psymtabs): Update.
5883         * objfiles.c (objfile::objfile): Update.
5884         * psymtab.h (psymtab_storage::obstack): Update.
5885         (psymtab_storage::m_obstack): Use gdb::optional.
5886         (class psymtab_storage): Update comment.  Remove objfile
5887         parameter.
5888         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5889
5890 2019-01-10  Tom Tromey  <tom@tromey.com>
5891
5892         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5893         <free_psymtabs>: Now private.
5894         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5895         (allocate_psymtab): Use new method.
5896
5897 2019-01-10  Tom Tromey  <tom@tromey.com>
5898
5899         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5900         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5901         * mdebugread.c (parse_partial_symbols): Use
5902         allocate_dependencies.
5903         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5904         allocate_dependencies.
5905         (process_psymtab_comp_unit_reader)
5906         (build_type_psymtab_dependencies): Likewise.
5907         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5908
5909 2019-01-10  Tom Tromey  <tom@tromey.com>
5910
5911         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5912         PSYMBOL_SET_LANGUAGE.
5913         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5914
5915 2019-01-10  Tom Tromey  <tom@tromey.com>
5916
5917         * psymtab.h (psymtab_storage::obstack): New method.
5918         <m_obstack>: Rename from obstack; now private.
5919         * psymtab.c (psymtab_storage): Update.
5920         * dwarf2read.c (create_addrmap_from_index)
5921         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5922         Update.
5923
5924 2019-01-10  Tom Tromey  <tom@tromey.com>
5925
5926         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5927         * objfiles.h (objfile::reset_psymtabs): New method.
5928
5929 2019-01-10  Tom Tromey  <tom@tromey.com>
5930
5931         * symmisc.c (print_symbol_bcache_statistics): Update.
5932         (print_objfile_statistics): Update.
5933         * symfile.c (reread_symbols): Update.
5934         * psymtab.h (class psymtab_storage): New.
5935         * psymtab.c (psymtab_storage): New constructor.
5936         (~psymtab_storage): New destructor.
5937         (require_partial_symbols): Update.
5938         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5939         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5940         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5941         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5942         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5943         (start_psymtab_common, end_psymtab_common)
5944         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5945         (allocate_psymtab): Update.
5946         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5947         Update.
5948         (dump_psymtab_addrmap, maintenance_print_psymbols)
5949         (maintenance_check_psymtabs): Update.
5950         (class objfile_psymtabs): Move to objfiles.h.
5951         * psympriv.h (discard_psymtab): Now inline.
5952         (psymtab_discarder::psymtab_discarder): Update.
5953         (psymtab_discarder::~psymtab_discarder): Update.
5954         (ALL_OBJFILE_PSYMTABS): Rewrite.
5955         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5956         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5957         Remove fields.
5958         <partial_symtabs>: New field.
5959         (class objfile_psymtabs): Move from psymtab.h.  Update.
5960         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5961         psymbol_cache.
5962         (objfile::~objfile): Don't destroy psymbol_cache.
5963         * mdebugread.c (parse_partial_symbols): Update.
5964         * dwarf2read.c (create_addrmap_from_index)
5965         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5966         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5967         (add_partial_subprogram, dwarf2_ranges_read): Update.
5968         * dwarf-index-write.c (write_address_map)
5969         (write_one_signatured_type, recursively_write_psymbols)
5970         (class debug_names, class debug_names, write_psymtabs_to_index):
5971         Update.
5972
5973 2019-01-10  Tom Tromey  <tom@tromey.com>
5974
5975         * symtab.h (SYMBOL_SET_NAMES): Update.
5976         (symbol_set_names): Update.
5977         (MSYMBOL_SET_NAMES): Update.
5978         * symtab.c (symbol_set_names): Change argument to be an
5979         objfile_per_bfd_storage.
5980         * psymtab.c (add_psymbol_to_bcache): Update.
5981         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5982
5983 2019-01-10  Tom Tromey  <tom@tromey.com>
5984
5985         * symtab.c (create_demangled_names_hash): Change argument to be an
5986         objfile_per_bfd_storage.
5987         (symbol_set_names): Update.
5988
5989 2019-01-10  Tom Tromey  <tom@tromey.com>
5990
5991         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5992         init_psymbol_list.
5993         * psymtab.c (init_psymbol_list): Do nothing if already called.
5994         * psympriv.h (init_psymbol_list): Add comment.
5995         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5996         init_psymbol_list.
5997         * dbxread.c (dbx_symfile_read): Unconditionally call
5998         init_psymbol_list.
5999
6000 2019-01-10  Tom Tromey  <tom@tromey.com>
6001
6002         * xcoffread.c (scan_xcoff_symtab): Update.
6003         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6004         "where".
6005         * mdebugread.c (parse_partial_symbols)
6006         (handle_psymbol_enumerators): Update.
6007         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6008         * dbxread.c (read_dbx_symtab): Update.
6009         * psympriv.h (psymbol_placement): New enum.
6010         (add_psymbol_to_list): Update.
6011
6012 2019-01-10  Tom Tromey  <tom@tromey.com>
6013
6014         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6015         static_psymbols parameters.
6016         (scan_xcoff_symtab): Update.
6017         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6018         static_psymbols parameters.
6019         * psympriv.h (start_psymtab_common): Update.
6020         * mdebugread.c (parse_partial_symbols): Update.
6021         * dwarf2read.c (create_partial_symtab): Update.
6022         * dbxread.c (read_dbx_symtab): Update.
6023         (start_psymtab): Remove global_psymbols and static_psymbols
6024         parameters.
6025
6026 2019-01-10  Tom Tromey  <tom@tromey.com>
6027
6028         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6029         * psymtab.c (allocate_psymtab): Add comment.
6030         * psympriv.h (allocate_psymtab): Add comment.
6031         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6032         initializations.
6033         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6034
6035 2019-01-10  Tom Tromey  <tom@tromey.com>
6036
6037         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6038         Don't declare.
6039         * mipsread.c: Include mdebugread.h.
6040         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6041         Declare.
6042         * elfread.c: Include mdebugread.h.
6043
6044 2019-01-09  Tom Tromey  <tom@tromey.com>
6045
6046         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6047         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6048         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6049         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6050         (psym_lookup_symbol, psym_find_last_source_symtab)
6051         (psym_forget_cached_source_info, psym_print_stats)
6052         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6053         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6054         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6055         (psym_find_compunit_symtab_by_address)
6056         (maintenance_print_psymbols, maintenance_info_psymtabs)
6057         (maintenance_check_psymtabs): Use ranged for.
6058         * psymtab.h (class objfile_psymtabs): New.
6059         (require_partial_symbols): Return objfile_psymtabs.
6060         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6061
6062 2019-01-09  Tom Tromey  <tom@tromey.com>
6063
6064         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6065         (find_pc_mapped_section, list_overlays_command)
6066         (map_overlay_command, unmap_overlay_command)
6067         (simple_overlay_update): Use all_objfiles.
6068         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6069         * printcmd.c (info_symbol_command): Use all_objfiles.
6070         * objfiles.h (ALL_OBJSECTIONS): Remove.
6071         * maint.c (maintenance_translate_address): Use all_objfiles.
6072         * gcore.c (gcore_create_callback): Use all_objfiles.
6073         (objfile_find_memory_regions): Likewise.
6074
6075 2019-01-09  Tom Tromey  <tom@tromey.com>
6076
6077         * symtab.c (find_line_symtab, info_sources_command)
6078         (make_source_files_completion_list): Use objfile_compunits.
6079         * source.c (select_source_symtab): Use objfile_compunits.
6080         * objfiles.h (struct objfile): Update comment.
6081         (ALL_OBJFILES): Remove.
6082         (ALL_FILETABS): Remove.
6083         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6084         objfile_compunits.
6085
6086 2019-01-09  Tom Tromey  <tom@tromey.com>
6087
6088         * symmisc.c (print_objfile_statistics, dump_objfile)
6089         (maintenance_print_symbols): Use compunit_filetabs.
6090         * source.c (forget_cached_source_info_for_objfile): Use
6091         compunit_filetabs.
6092         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6093         (ALL_FILETABS): Use compunit_filetabs.
6094         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6095         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6096
6097 2019-01-09  Tom Tromey  <tom@tromey.com>
6098
6099         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6100         (compunit_filetabs): New.
6101         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6102         compunit_filetabs.
6103         (info_sources_command, make_source_files_completion_list): Remove
6104         declaration.
6105         * symmisc.c (print_objfile_statistics, dump_objfile)
6106         (maintenance_print_symbols): Remove declaration.
6107         (maintenance_info_symtabs): Use compunit_filetabs.
6108         (maintenance_info_line_tables): Likewise.
6109         * source.c (select_source_symtab): Change local variable name.
6110         (forget_cached_source_info_for_objfile): Remove declaration.
6111         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6112         * objfiles.c (objfile_relocate1): Remove declaration.
6113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6114         declaration.
6115         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6116         * coffread.c (coff_symtab_read): Remove declaration.
6117         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6118         compunit_filetabs.
6119
6120 2019-01-09  Tom Tromey  <tom@tromey.com>
6121
6122         * symtab.c (lookup_objfile_from_block)
6123         (find_pc_sect_compunit_symtab, search_symbols)
6124         (default_collect_symbol_completion_matches_break_on): Use
6125         objfile_compunits.
6126         * objfiles.h (ALL_COMPUNITS): Remove.
6127         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6128         * cp-support.c (add_symbol_overload_list_qualified): Use
6129         objfile_compunits.
6130         * ada-lang.c (ada_collect_symbol_completion_matches)
6131         (ada_add_global_exceptions): Use objfile_compunits.
6132
6133 2019-01-09  Tom Tromey  <tom@tromey.com>
6134
6135         * source.c (select_source_symtab)
6136         (forget_cached_source_info_for_objfile): Remove declaration.
6137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6138         declaration.
6139         * maint.c (count_symtabs_and_blocks): Remove declaration.
6140         * cp-support.c (add_symbol_overload_list_qualified): Remove
6141         declaration.
6142         * coffread.c (coff_symtab_read): Remove declaration.
6143         * symtab.c (lookup_symbol_in_objfile_symtabs)
6144         (basic_lookup_transparent_type_1): Use objfile_compunits.
6145         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6146         (info_sources_command, search_symbols)
6147         (default_collect_symbol_completion_matches_break_on)
6148         (make_source_files_completion_list): Remove declaration.
6149         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6150         (ada_collect_symbol_completion_matches)
6151         (ada_add_global_exceptions): Remove declaration.
6152         * linespec.c (iterate_over_all_matching_symtabs): Use
6153         objfile_compunits.
6154         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6155         (class objfile_compunits): New.
6156         (ALL_COMPUNITS): Use objfile_compunits.
6157         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6158         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6159         objfile_compunits.
6160         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6161
6162 2019-01-09  Tom Tromey  <tom@tromey.com>
6163
6164         * symtab.c (search_symbols)
6165         (default_collect_symbol_completion_matches_break_on): Use
6166         objfile_msymbols.
6167         * ada-lang.c (ada_lookup_simple_minsym)
6168         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6169         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6170         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6171         objfile_msymbols.
6172         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6173         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6174         * objc-lang.c (find_methods): Use objfile_msymbols.
6175         (info_selectors_command, info_classes_command): Likewise.
6176         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6177         * objfiles.h (class objfile_msymbols): New.
6178         (ALL_OBJFILE_MSYMBOLS): Remove.
6179         (ALL_MSYMBOLS): Remove.
6180
6181 2019-01-09  Tom Tromey  <tom@tromey.com>
6182
6183         * common/next-iterator.h (next_adapter): Add Iterator template
6184         parameter.
6185         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6186         (class all_objfiles_safe): New.
6187         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6188         * objfiles.c (put_objfile_before): Update comment.
6189         (add_separate_debug_objfile): Likewise.
6190         (free_all_objfiles): Use all_objfiles_safe.
6191         (objfile_purge_solibs): Likewise.
6192
6193 2019-01-09  Tom Tromey  <tom@tromey.com>
6194
6195         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6196         (expand_symtab_containing_pc, lookup_static_symbol)
6197         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6198         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6199         all_objfiles.
6200         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6201         * breakpoint.c (create_overlay_event_breakpoint)
6202         (create_longjmp_master_breakpoint)
6203         (create_std_terminate_master_breakpoint)
6204         (create_exception_master_breakpoint): Use all_objfiles.
6205         * linux-thread-db.c (try_thread_db_load_from_pdir)
6206         (has_libpthread): Use all_objfiles.
6207         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6208         * linespec.c (iterate_over_all_matching_symtabs)
6209         (search_minsyms_for_name): Use all_objfiles.
6210         * maint.c (maintenance_info_sections): Use all_objfiles.
6211         * main.c (captured_main_1): Use all_objfiles.
6212         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6213         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6214         * guile/scm-pretty-print.c
6215         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6216         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6217         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6218         (maintenance_print_msymbols): Use all_objfiles.
6219         * source.c (select_source_symtab): Use all_objfiles.
6220         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6221         * symfile.c (remove_symbol_file_command)
6222         (expand_symtabs_matching, map_symbol_filenames): Use
6223         all_objfiles.
6224         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6225         all_objfiles.
6226         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6227         * objc-lang.c (find_methods): Use all_objfiles.
6228         * objfiles.c (have_partial_symbols, have_full_symbols)
6229         (have_minimal_symbols, qsort_cmp)
6230         (default_iterate_over_objfiles_in_search_order): Use
6231         all_objfiles.
6232         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6233         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6234         (maintenance_check_psymtabs): Use all_objfiles.
6235         (ALL_PSYMTABS): Remove.
6236         * compile/compile-object-run.c (do_module_cleanup): Use
6237         all_objfiles.
6238         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6239         * cp-support.c (add_symbol_overload_list_qualified): Use
6240         all_objfiles.
6241         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6242         Use all_objfiles.
6243         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6244         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6245         all_objfiles.
6246         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6247         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6248         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6249         Uses all_objfiles.
6250         * solib.c (solib_read_symbols): Use all_objfiles
6251
6252 2019-01-09  Tom Tromey  <tom@tromey.com>
6253
6254         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6255         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6256         all_objfiles.
6257         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6258         * symmisc.c (print_symbol_bcache_statistics)
6259         (print_objfile_statistics, maintenance_print_objfiles)
6260         (maintenance_info_symtabs, maintenance_check_symtabs)
6261         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6262         all_objfiles.
6263         * source.c (forget_cached_source_info): Use all_objfiles.
6264         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6265         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6266         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6267         * objfiles.c (update_section_map): Use all_objfiles.
6268         (shared_objfile_contains_address_p): Likewise.
6269         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6270         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6271
6272 2019-01-09  Tom Tromey  <tom@tromey.com>
6273
6274         * common/next-iterator.h: New file.
6275         * objfiles.h (class all_objfiles): New.
6276         (struct objfile_iterator): New.
6277
6278 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6279
6280         * NEWS: Move the description of the changed "frame", "select-frame",
6281          and "info frame" commands to the Changed commands section.
6282
6283 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6284
6285         * gdbtypes.c (check_stub_method_group): Remove handling of old
6286         mangling schemes.
6287         * linespec.c (find_methods): Likewise.
6288         * stabsread.c (read_member_functions): Likewise.
6289         * valops.c (search_struct_method): Likewise.
6290         (value_struct_elt_for_reference): Likewise.
6291         * NEWS: Mention this change.
6292
6293 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6294
6295         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6296         print_source_lines.
6297         * source.c (print_source_lines_base): Update line number check.
6298         (print_source_lines): New function.
6299         (source_lines_range::source_lines_range): New function.
6300         * source.h (class source_lines_range): New class.
6301         (print_source_lines): New declaration.
6302
6303 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6304
6305         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6306
6307 2019-01-08  Tom Tromey  <tom@tromey.com>
6308             Simon Marchi  <simon.marchi@ericsson.com>
6309
6310         PR gdb/24060
6311         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6312         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6313         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6314         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6315         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6316         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6317
6318 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6319
6320         * source.c (select_source_symtab): Move header comment to
6321         declaration in source.h.
6322         (forget_cached_source_info_for_objfile): Likewise.
6323         (forget_cached_source_info): Likewise.
6324         (identify_source_line): Likewise.
6325         * source.h (identify_source_line): Move declaration from symtab.h
6326         and add comment from source.c
6327         (print_source_lines): Likewise.
6328         (forget_cached_source_info_for_objfile): Likewise.
6329         (forget_cached_source_info): Likewise.
6330         (select_source_symtab): Likewise.
6331         (enum print_source_lines_flag): Move definition from symtab.h.
6332         * symtab.h (identify_source_line): Move declaration to source.h.
6333         (print_source_lines): Likewise.
6334         (forget_cached_source_info_for_objfile): Likewise.
6335         (forget_cached_source_info): Likewise.
6336         (select_source_symtab): Likewise.
6337         (enum print_source_lines_flag): Move definition to source.h.
6338         * tui/tui-hooks.c: Add 'source.h' include.
6339
6340 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * source.c (print_source_lines_base): Handle requests to print
6343         reverse line number sequences, and guard against empty lines
6344         string.
6345
6346 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6347
6348         * source.c (print_source_lines_base): Fix skip of '\r' if next
6349         character is '\n'.
6350
6351 2019-01-06  Tom Tromey  <tom@tromey.com>
6352
6353         * c-exp.y (struct c_parse_state) <macro_original_text,
6354         expansion_obstack>: New member.
6355         (macro_original_text, expansion_obstack): Remove globals.
6356         (scan_macro_expansion, scanning_macro_expansion)
6357         (finished_macro_expansion): Update.
6358         (scan_macro_cleanup): Remove.
6359         (yylex, c_parse): Update.
6360
6361 2019-01-06  Tom Tromey  <tom@tromey.com>
6362
6363         * c-exp.y (struct c_parse_state) <strings>: New member.
6364         (operator_stoken): Update.
6365
6366 2019-01-06  Tom Tromey  <tom@tromey.com>
6367
6368         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6369         (union type_stack_elt) <typelist_val>: Now a pointer to
6370         std::vector.
6371         (type_stack_cleanup): Don't declare.
6372         (push_typelist): Update.
6373         * parse.c (pop_typelist): Return a std::vector.
6374         (push_typelist): Take a std::vector.
6375         (follow_types): Update.  Do not free args.
6376         (type_stack_cleanup): Remove.
6377         * c-exp.y (struct c_parse_state): New.
6378         (cpstate): New global.
6379         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6380         (nonempty_typelist): Update.
6381         (func_mod): Create a new vector.
6382         (c_parse): Create a c_parse_state.
6383         (check_parameter_typelist): Do not delete params.
6384         (function_method): Update.  Do not delete type_list.
6385
6386 2019-01-06  Tom Tromey  <tom@tromey.com>
6387
6388         PR gdb/28155:
6389         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6390         check_typedef.
6391         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6392         (print_return_value): Likewise.
6393
6394 2019-01-05  Tom Tromey  <tom@tromey.com>
6395
6396         * contrib/cleanup_check.py: Remove.
6397         * contrib/gcc-with-excheck: Remove.
6398         * contrib/exsummary.py: Remove.
6399         * contrib/excheck.py: Remove.
6400
6401 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6402
6403         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6404         NULL. Initialize tpprev to NULL instead of assigning it
6405         to NULL on the next statement.
6406         * windows-nat.c (windows_delete_thread): Remove check for
6407         main_thread_id before printing thread exit notifications.
6408         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6409         Remove thread ID check against main_thread_id.
6410         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6411         windows_delete_thread.
6412         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6413
6414 2019-01-04  Tom Tromey  <tom@tromey.com>
6415
6416         * compile/compile.c (_initialize_compile): Use upper case for
6417         metasyntactic variables.
6418         * symmisc.c (_initialize_symmisc): Use upper case for
6419         metasyntactic variables.
6420         * psymtab.c (_initialize_psymtab): Use upper case for
6421         metasyntactic variables.
6422         * demangle.c (demangle_command): Use upper case for metasyntactic
6423         variables.
6424         (_initialize_demangler): Likewise.
6425         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6426         variables.
6427
6428 2019-01-03  Tom Tromey  <tom@tromey.com>
6429
6430         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6431
6432 2019-01-03  Tom Tromey  <tom@tromey.com>
6433
6434         * python/py-symtab.c (salpy_str): Update.
6435         (struct salpy_sal_object) <symtab>: Now a PyObject.
6436         (salpy_dealloc): Update.
6437         (del_objfile_sal): Use gdbpy_ref.
6438
6439 2019-01-03  Tom Tromey  <tom@tromey.com>
6440
6441         * python/py-type.c (convert_field): Use new_reference.  Return
6442         gdbpy_ref.
6443         (make_fielditem): Return gdbpy_ref.
6444         (typy_fields): Update.
6445         (typy_getitem): Update.
6446         (field_name): Return gdbpy_ref.  Use new_reference.
6447         (typy_iterator_iternext): Update.
6448
6449 2019-01-03  Tom Tromey  <tom@tromey.com>
6450
6451         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6452
6453 2019-01-03  Tom Tromey  <tom@tromey.com>
6454
6455         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6456         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6457         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6458         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6459         (pspy_set_type_printers): Likewise.
6460         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6461         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6462         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6463         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6464         (objfpy_set_type_printers): Likewise.
6465
6466 2019-01-03  Tom Tromey  <tom@tromey.com>
6467
6468         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6469         (gdbpy_print_stack): Use gdbpy_err_fetch.
6470         * python/python-internal.h (class gdbpy_err_fetch): New class.
6471         (class gdbpy_enter) <m_error_type, m_error_value,
6472         m_error_traceback>: Remove.
6473         <m_error>: New member.
6474         (gdbpy_exception_to_string): Don't declare.
6475         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6476         * python/py-value.c (convert_value_from_python): Use
6477         gdbpy_err_fetch.
6478         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6479         gdbpy_exception_to_string.
6480         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6481         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6482         gdbpy_err_fetch.
6483
6484 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6485
6486         * linux-nat.c (delete_lwp_cleanup): Delete.
6487         (struct lwp_deleter): New struct.
6488         (lwp_info_up): New typedef.
6489         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6490         lwp_info_up.
6491
6492 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * linux-fork.c (class scoped_switch_fork_info): New class.
6495         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6496
6497 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * valops.c (find_overload_match): Remove use of null_cleanup, and
6500         calls to do_cleanups.
6501
6502 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * compile/compile-cplus-types.c
6505         (compile_cplus_instance::decl_name): Handle changes to
6506         cp_func_name.
6507         * cp-support.c (cp_func_name): Update header comment, update
6508         return type.
6509         * cp-support.h (cp_func_name): Update return type in declaration.
6510         * valops.c (find_overload_match): Move temp_func local to top
6511         level of function and change its type.  Use temp_func to hold and
6512         delete temporary string obtained from cp_func_name.
6513
6514 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6517         gdb::char_vector, remove cleanup, and update uses of `msg`.
6518
6519 2019-01-03  Jim Wilson  <jimw@sifive.com>
6520
6521         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6522
6523 2019-01-02  Tom Tromey  <tom@tromey.com>
6524
6525         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6526         (tdesc_parse_xml): Remove cleanups.
6527         * target-descriptions.h (make_cleanup_free_target_description):
6528         Don't declare.
6529         (target_desc_deleter): New struct.
6530         (target_desc_up): New typedef.
6531         * target-descriptions.c (target_desc_deleter::operator()): Rename
6532         from free_target_description.
6533         (make_cleanup_free_target_description): Remove.
6534
6535 2019-01-02  Tom Tromey  <tom@tromey.com>
6536
6537         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6538         constructor, destructor.
6539         (linespec_parser): Remove typedef.
6540         (~linespec_parser): Rename from linespec_parser_delete.
6541         (linespec_lex_to_end, linespec_complete_label)
6542         (linespec_complete): Update.
6543         (decode_line_full): Remove cleanups.
6544         (decode_line_1): Update.
6545
6546 2019-01-02  Tom Tromey  <tom@tromey.com>
6547
6548         * python/python-internal.h (inferior_to_inferior_object): Change
6549         return type.
6550         * python/py-exitedevent.c (create_exited_event_object): Update.
6551         * python/py-inferior.c (inferior_to_inferior_object): Return
6552         gdbpy_ref.
6553         (python_new_inferior, python_inferior_deleted)
6554         (thread_to_thread_object, delete_thread_object)
6555         (build_inferior_list, gdbpy_selected_inferior): Update.
6556         * python/py-infthread.c (create_thread_object): Update.  Also fail
6557         if inferior_to_inferior_object fails.
6558
6559 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6560
6561         * inferior.h (class inferior) <displaced_step_state>: New field.
6562         * infrun.h (struct displaced_step_state): Move here from
6563         infrun.c.  Initialize fields, add constructor.
6564         <inf>: Remove field.
6565         <reset>: New method.
6566         * infrun.c (struct displaced_step_inferior_state): Move to
6567         infrun.h.
6568         (displaced_step_inferior_states): Remove.
6569         (get_displaced_stepping_state): Adust.
6570         (displaced_step_in_progress_any_inferior): Adjust.
6571         (displaced_step_in_progress_thread): Adjust.
6572         (displaced_step_in_progress): Adjust.
6573         (add_displaced_stepping_state): Remove.
6574         (get_displaced_step_closure_by_addr): Adjust.
6575         (remove_displaced_stepping_state): Remove.
6576         (infrun_inferior_exit): Call displaced_step_state.reset.
6577         (use_displaced_stepping): Don't check for NULL.
6578         (displaced_step_prepare_throw): Call
6579         get_displaced_stepping_state.
6580         (displaced_step_fixup): Don't check for NULL.
6581         (prepare_for_detach): Don't check for NULL.
6582
6583 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6584
6585         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6586          in case of call that did not complete.
6587
6588 2019-01-02  Andrey Utkin  <autkin@undo.io>
6589
6590         * symfile.c (find_separate_debug_file): Fix search of debug files for
6591         remote debuggee.
6592
6593 2019-01-02  Tom Tromey  <tom@tromey.com>
6594
6595         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6596         indentation.
6597         * python/py-frame.c (frapy_older): Remove cast.
6598         (frapy_newer): Likewise.
6599         * python/py-breakpoint.c (local_setattro): Remove cast.
6600         * python/py-arch.c (archpy_name): Remove local variable.
6601         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6602
6603 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6604
6605         * unittests/basic_string_view/element_access/char/empty.cc:
6606         Fix year range in copyright header.
6607
6608 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6609
6610         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6611         Delete.
6612         <operator==>: Update with for removed field.
6613         <hash>: Likewise.
6614         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6615         <isa_features>: ...this.
6616         <abi_features>: New field.
6617         (riscv_isa_flen): Update comment.
6618         (riscv_abi_xlen): New declaration.
6619         (riscv_abi_flen): New declaration.
6620         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6621         isa_features.
6622         (riscv_abi_xlen): New function.
6623         (riscv_isa_flen): Update to get answer from isa_features.
6624         (riscv_abi_flen): New function.
6625         (riscv_has_fp_abi): Update to get answer from abi_features.
6626         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6627         xlen and flen.
6628         (riscv_call_info) <xlen, flen>: Update comment.
6629         (riscv_call_arg_struct): Remove invalid assertions
6630         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6631         is removed.
6632         (riscv_gdbarch_init): Gather isa features and abi features
6633         separately, ensure both match on the gdbarch when reusing an old
6634         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6635         a target with 64-bit float hardware.
6636
6637 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6638
6639         * source.c (search_command_helper): Stop reverse search
6640         when line 1 has been searched.
6641
6642 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6643
6644         * record-full.c (record_full_base_target::close): Rewrite
6645         record_full_core_buf_list free logic.
6646
6647 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6648
6649         * break-catch-syscall.c (print_one_catch_syscall): xfree
6650         the last text.
6651
6652 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6653
6654         * top.c (print_gdb_version): Update Copyright year in version
6655         message.
6656
6657 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6658
6659         Update copyright year range in all GDB files.
6660
6661 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6662
6663         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6664
6665 For older changes see ChangeLog-2018.
6666 \f
6667 Local Variables:
6668 mode: change-log
6669 left-margin: 8
6670 fill-column: 74
6671 version-control: never
6672 coding: utf-8
6673 End:
6674