gdb/ChangeLog

   1 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
   4         (error_in_psymtab_expansion): Likewise.
   5         (lookup_symbol_via_quick_fns): Likewise.
   6         (basic_lookup_transparent_type_quick): Likewise.
   7         (basic_lookup_transparent_type_1): Likewise.
   8
   9 2019-08-06  Tom Tromey  <tromey@adacore.com>
  10
  11         * source.c (last_source_error): Now bool.
  12         (print_source_lines_base): Make "noprint" bool.  Only open
  13         source file when last_source_visited changes.
  14
  15 2019-08-06  Tom Tromey  <tromey@adacore.com>
  16
  17         * annotate.c (annotate_source_line): Use g_source_cache.
  18         * source-cache.c (source_cache::get_plain_source_lines): Change
  19         parameters.  Populate m_offset_cache.
  20         (source_cache::ensure): New method.
  21         (source_cache::get_line_charpos): New method.
  22         (extract_lines): Move lower.  Change parameters.
  23         (source_cache::get_source_lines): Move lower.
  24         * source-cache.h (class source_cache): Update comment.
  25         <get_line_charpos>: New method.
  26         <get_source_lines>: Update comment.
  27         <clear>: Clear m_offset_cache.
  28         <get_plain_source_lines>: Change parameters.
  29         <ensure>: New method
  30         <m_offset_cache>: New member.
  31         * source.c (forget_cached_source_info_for_objfile): Update.
  32         (info_source_command): Use g_source_cache.
  33         (find_source_lines, open_source_file_with_line_charpos): Remove.
  34         (print_source_lines_base, search_command_helper): Use g_source_cache.
  35         * source.h (open_source_file_with_line_charpos): Don't declare.
  36         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
  37         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
  38         Use g_source_cache.
  39
  40 2019-08-06  Tom Tromey  <tromey@adacore.com>
  41
  42         * source-cache.c (source_cache::get_plain_source_lines):
  43         Remove "first_line" and "last_line" parameters.
  44         (source_cache::get_source_lines): Cache plain text.
  45         * source-cache.h (class source_cache)
  46         <get_plain_source_lines>: Update.
  47
  48 2019-08-06  Tom Tromey  <tromey@adacore.com>
  49
  50         * source-cache.c (extract_lines): No longer a method.
  51         Changed type of parameter.  Include final newline.
  52         (selftests::extract_lines_test): New function.
  53         (_initialize_source_cache): Likewise.
  54         * source-cache.h (class source_cache)
  55         <extract_lines>: Don't declare.
  56
  57 2019-08-06  Tom Tromey  <tromey@adacore.com>
  58
  59         * breakpoint.c (init_breakpoint_sal): Update.
  60         (breakpoint): Update.
  61         * breakpoint.h (struct breakpoint) <filter>: Now a
  62         unique_xmalloc_ptr.
  63
  64 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  65
  66         * NEWS: Mention dictionary access on blocks.
  67         * python/py-block.c (blpy_getitem): New function.
  68         (block_object_as_mapping): New struct.
  69         (block_object_type): Use new struct for tp_as_mapping field.
  70
  71 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  72
  73         * objfiles.h (objfile): Add a comment describing partial symbols.
  74
  75 2019-08-05  Tom Tromey  <tromey@adacore.com>
  76
  77         * compile/compile.c (_initialize_compile): Use _(), not N_().
  78         * thread.c (_initialize_thread): Use _(), not N_().
  79         * stack.c (_initialize_stack): Use _(), not N_().
  80         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  81
  82 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  83
  84         * dwarf2read.c (struct dw2_symtab_iterator):
  85         <want_specific_block>: Remove.
  86         <block_index>: Change type to gdb::optional.
  87         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  88         change type of BLOCK_INDEX parameter to gdb::optional.
  89         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  90         (dw2_lookup_symbol): Don't pass argument for
  91         WANT_SPECIFIC_BLOCK.
  92         (dw2_expand_symtabs_for_function): Don't pass argument for
  93         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  94         (class dw2_debug_names_iterator)
  95         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  96         parameter, change BLOCK_INDEX type to gdb::optional.
  97         <m_want_specific_block>: Remove.
  98         <m_block_index>: Change type to gdb::optional.
  99         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 100         gdb::optional.  Re-write in function of gdb::optional.
 101         (dw2_debug_names_lookup_symbol): Don't pass argument for
 102         WANT_SPECIFIC_BLOCK.
 103         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 104         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 105         BLOCK_INDEX.
 106
 107 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 108
 109         * NEWS: Mention changes to "info sources" command.
 110
 111 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 112
 113         * symtab.c (filename_partial_match_opts): New struct type.
 114         (struct output_source_filename_data): New members
 115         regexp, c_regexp, partial_match.
 116         (output_source_filename): Use new members to decide to print file.
 117         (info_sources_option_defs): New variable.
 118         (make_info_sources_options_def_group, print_info_sources_header,
 119         info_sources_command_completer):
 120         New functions.
 121         (info_sources_command): Read new optional arguments.
 122         (_initialize_symtab): Update info sources help.
 123
 124 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 125
 126         * ada-lang.c (exception_support_info_v0): Renamed from...
 127         (default_exception_support_info): ... this.  Create new
 128         definition for v1.
 129         (ada_has_this_exception_support): Look up catch_handlers_sym.
 130         (ada_exception_support_info_sniffer): Try v0 after default.
 131
 132 2019-08-01  Tom Tromey  <tromey@adacore.com>
 133
 134         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 135         gdbarch.h.
 136
 137 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 138
 139         * s12z-tdep.c: Fix include path for s12z-opc.h.
 140
 141 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 142
 143         * NEWS: Require GNU make 3.82.
 144
 145 2019-07-16  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 148         declare.
 149
 150 2019-07-30  Tom Tromey  <tromey@adacore.com>
 151
 152         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 153
 154 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 155
 156         * printcmd.c (print_address_symbolic): Print negative offsets.
 157         (build_address_symbolic): Force signed arithmetic when computing
 158         offset.
 159
 160 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 161
 162         PR/24474: Add a function to lookup static variables.
 163         * NEWS: Mention this new function.
 164         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 165         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 166         * python/python.c (python_GdbMethods): Add new function.
 167
 168 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 171         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 172         (objfpy_lookup_static_symbol): New function.
 173         (objfile_object_methods): Add new functions.
 174
 175 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 176
 177         * NEWS: Mention 'set|show print frame-info'.  Mention new
 178         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 179         backtrace argument.  Mention that python frame filtering code
 180         is now consistent with what 'backtrace' command prints.
 181
 182 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 183
 184         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 185         comments.
 186         (print_frame_info_auto, print_frame_info_source_line,
 187         print_frame_info_location, print_frame_info_source_and_location,
 188         print_frame_info_location_and_address, print_frame_info_short_location):
 189         New declarations.
 190         (struct frame_print_options): New member print_frame_info.
 191         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 192         * stack.h (get_user_print_what_frame_info): New declaration.
 193         (frame_show_address): New declaration.
 194         * stack.c (print_frame_arguments_choices): New value 'presence'.
 195         (print_frame_info_auto, print_frame_info_source_line,
 196         print_frame_info_location, print_frame_info_source_and_location,
 197         print_frame_info_location_and_address, print_frame_info_short_location,
 198         print_frame_info_choices, print_frame_info_print_what): New definitions.
 199         (print_frame_args): Only print dots for args if print frame-arguments
 200         is 'presence'.
 201         (frame_print_option_defs): New element for "frame-info".
 202         (get_user_print_what_frame_info): New function.
 203         (frame_show_address): Make non static.  Move comment to stack.h.
 204         (print_frame_info_to_print_what): New function.
 205         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 206         to decide what to print.
 207         (backtrace_command_1): Handle the new print_frame_arguments_presence
 208         value.
 209         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 210         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 211         (py_print_frame): In non-mi mode, use LOCATION as default for
 212         print_what, similarly to frame information printed directly by
 213         backtrace command. Handle frame-info user option in non MI mode.
 214
 215 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 216
 217         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 218         Add case for debugging 32-bit target on 64-bit host.  Revise
 219         comment.
 220
 221 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 222
 223         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 224         instead of find_function_entry_range_from_pc.
 225
 226 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 227
 228         * stack.c (find_frame_funname): Remove code which preferred
 229         minsym over symtab sym in "certain pathological cases".
 230
 231         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 232         parameter.  Change type of "do_demangle" to bool.
 233         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 234         Pass suitable "prefer_sym_over_minsym" flag to
 235         build_address_symbolic().  Don't output "+" for negative offsets.
 236         * printcmd.c (print_address_symbolic): Update invocation of
 237         build_address_symbolic to include a "prefer_sym_over_minsym"
 238         flag.
 239         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 240         Restrict cases in which use of minimal symbol is preferred to that
 241         of a found symbol.  Update comments.
 242
 243         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 244         for entry pc when entry pc is out of range for that FDE.
 245
 246 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 247
 248         PR gdb/24839:
 249         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 250         type.
 251
 252 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 253
 254         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 255         this function's Python signature.
 256
 257
 258 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 259
 260         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 261         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 262         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 263         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 264         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 265
 266
 267 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 268
 269         * h8300-tdep.c (h8300_register_name_common): New.
 270         h8300_register_name): Use h8300_register_name_common.
 271         (h8300s_register_name): Likewise.
 272         (h8300sx_register_name): Likewise.
 273         (h8300h_register_nam): New.
 274         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 275
 276
 277 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 278
 279         * arm-tdep.c (arm_skip_cmse_entry): New function.
 280         (arm_is_sgstubs_section): New function.
 281         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 282
 283 2019-07-22  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 286         Don't self-assign.
 287
 288 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 289
 290         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 291         type_print.
 292
 293 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 296         so that GDB doesn't match any msymbols when searching in the
 297         TYPES_DOMAIN.
 298         (print_symbol_info): Print using typedef_print or type_print based
 299         on the type of the symbol.  Add updated FIXME comment moved from...
 300         (_initialize_symtab): ... move and update FIXME comment to above.
 301
 302 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 303
 304         * NEWS: Mention adding -q option to "info types".
 305         * symtab.c (struct info_types_options): New struct.
 306         (info_types_options_defs): New variable.
 307         (make_info_types_options_def_group): New function.
 308         (info_types_command): Use gdb::option framework to parse options.
 309         (info_types_command_completer): New function.
 310         (_initialize_symtab): Extend the help text on "info types" and
 311         register command completer.
 312
 313 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 314
 315         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 316         (lookup_symbol_in_objfile): Change int to block_enum and add a
 317         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 318
 319 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 320
 321         * MAINTAINERS (Write After Approval): Add self.
 322
 323 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 326         instruction to the dummy code region.
 327
 328 2019-07-19  Tom Tromey  <tromey@adacore.com>
 329
 330         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 331         (ARGSUSED, PARAMS, __func__): Remove rules.
 332
 333 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 334
 335         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 336         * features/arm/arm-with-iwmmxt.c: Remove.
 337         * features/arm/arm-with-iwmmxt.xml: Remove.
 338         * features/arm/arm-with-m-fpa-layout.c: Remove.
 339         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 340         * features/arm/arm-with-m-vfp-d16.c: Remove.
 341         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 342         * features/arm/arm-with-m.c: Remove.
 343         * features/arm/arm-with-m.xml: Remove.
 344         * features/arm/arm-with-neon.c: Remove.
 345         * features/arm/arm-with-neon.xml: Remove.
 346         * features/arm/arm-with-vfpv2.c: Remove.
 347         * features/arm/arm-with-vfpv2.xml: Remove.
 348         * features/arm/arm-with-vfpv3.c: Remove.
 349         * features/arm/arm-with-vfpv3.xml: Remove.
 350
 351 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 352
 353         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 354
 355 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 356
 357         * arch/aarch32.c (aarch32_create_target_description): Create
 358         target descriptions using features.
 359         * arch/arm.c (arm_create_target_description)
 360         (arm_create_mprofile_target_description): Likewise.
 361         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 362
 363 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 364
 365         * Makefile.in: Add new files.
 366         * aarch32-tdep.c: New file.
 367         * aarch32-tdep.h: New file.
 368         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 369         Call aarch32_read_description.
 370         * arch/aarch32.c: New file.
 371         * arch/aarch32.h: New file.
 372         * arch/arm.c (arm_create_target_description)
 373         (arm_create_mprofile_target_description): New function.
 374         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 375         (arm_create_target_description)
 376         (arm_create_mprofile_target_description): New declaration.
 377         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 378         read_description functions.
 379         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 380         Likewise.
 381         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 382         * arm-tdep.c (tdesc_arm_list): New variable.
 383         (arm_register_g_packet_guesses): Call create description functions.
 384         (arm_read_description) (arm_read_mprofile_description): New
 385         function.
 386         * arm-tdep.h (arm_read_description)
 387         (arm_read_mprofile_description): Add declaration.
 388         * configure.tgt: Add new files.
 389
 390 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 391
 392         * top.c (new_ui_command): Open specified terminal just once.
 393
 394 2019-07-18  Tom Tromey  <tromey@adacore.com>
 395
 396         * symtab.c (main_name): Constify return type.
 397         * symfile.c (set_initial_language): Update.
 398         * symtab.h (main_name): Constify return type.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.c (tui_update_source_window)
 403         (tui_update_source_window_as_is)
 404         (tui_update_source_windows_with_line): Remove return.
 405         * tui/tui-disasm.c (tui_show_disassem)
 406         (tui_show_disassem_and_update_source): Remove return.
 407         * tui/tui.c (tui_reset): Remove return.
 408         * tui/tui-wingeneral.c
 409         (tui_check_and_display_highlight_if_needed): Remove return.
 410
 411 2019-07-17  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 414
 415 2019-07-17  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.h (struct tui_exec_info_window)
 418         (struct tui_source_window_base): Move from tui-data.h.
 419         * tui/tui-winsource.c: Move many method definitions from
 420         elsewhere.  Remove "structuring" comments.
 421         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 422         (tui_source_window_base::refresh_window): Move to
 423         tui-winsource.c.
 424         * tui/tui-win.c (tui_source_window_base::refresh_all)
 425         (tui_source_window_base::update_tab_width)
 426         (tui_source_window_base::set_new_height)
 427         (tui_source_window_base::do_make_visible_with_new_height): Move to
 428         tui-winsource.c.
 429         * tui/tui-source.h: Update.
 430         * tui/tui-source.c (tui_source_window_base::reset): Move to
 431         tui-winsource.c.
 432         * tui/tui-disasm.h: Update.
 433         * tui/tui-data.h (struct tui_exec_info_window): Move to
 434         tui-winsource.h.
 435         (struct tui_source_window_base): Likewise.
 436         * tui/tui-data.c (tui_source_window_base::clear_detail)
 437         (tui_source_window_base, ~tui_source_window_base): Move to
 438         tui-winsource.c.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-win.c (tui_resize_all)
 443         (tui_source_window_base::update_tab_width)
 444         (tui_adjust_win_heights): Update.
 445         (tui_win_info::make_invisible_and_set_new_height): Rename from
 446         make_invisible_and_set_new_height.
 447         * tui/tui-data.h (struct tui_win_info)
 448         <make_invisible_and_set_new_height>: New method.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui.c: Update.
 453         * tui/tui-source.h (struct tui_source_window): Move from
 454         tui-data.h.
 455         * tui/tui-layout.c: Update.
 456         * tui/tui-disasm.c: Update.
 457         * tui/tui-data.h (struct tui_source_window): Move to
 458         tui-source.h.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 463         tui-data.h.
 464         * tui/tui-data.h (struct tui_disasm_window): Move to
 465         tui-disasm.h.
 466
 467 2019-07-17  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-regs.h (struct tui_data_item_window): Move from
 470         tui-data.h.
 471         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 472         * tui/tui-data.h (struct tui_data_item_window): Move to
 473         tui-regs.h.
 474         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 475
 476 2019-07-17  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui.c: Update.
 479         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 480         (tui_cmd_window::max_height): Move to tui-command.c.
 481         * tui/tui-layout.c: Update.
 482         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 483         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 484         tui-command.c.
 485         * tui/tui-command.h (struct tui_cmd_window): Move from
 486         tui-data.h.
 487         * tui/tui-command.c: Remove "structuring" comments.
 488         (tui_cmd_window::clear_detail)
 489         (tui_cmd_window::do_make_visible_with_new_height)
 490         (tui_cmd_window::max_height): Move from elsewhere.
 491
 492 2019-07-17  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 495         Now static.
 496         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 497         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui.c: Update.
 502         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 503         tui-regs.c.
 504         * tui/tui-windata.h: Remove file.
 505         * tui/tui-windata.c: Remove file.
 506         * tui/tui-win.c (tui_data_window::set_new_height)
 507         (tui_data_window::do_make_visible_with_new_height): Move to
 508         tui-regs.c.
 509         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 510         * tui/tui-regs.c: Remove "structuring" comments.
 511         (tui_data_window::first_data_item_displayed)
 512         (tui_data_window::delete_data_content_windows)
 513         (tui_data_window::erase_data_content)
 514         (tui_data_window::display_all_data)
 515         (tui_data_window::refresh_all)
 516         (tui_data_window::do_scroll_vertical)
 517         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 518         (tui_data_window::do_make_visible_with_new_height)
 519         (tui_data_window::refresh_window): Move from elsewhere.
 520         (_initialize_tui_regs): Move to end of file.
 521         * tui/tui-layout.c: Update.
 522         * tui/tui-hooks.c: Update.
 523         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 524         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 525         tui-regs.c.
 526         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 531         seen.
 532
 533 2019-07-17  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-win.c (tui_source_window_base::set_new_height)
 536         (tui_source_window_base::do_make_visible_with_new_height): Use
 537         m_has_locator field directly.
 538         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 539         method.
 540         (struct tui_source_window_base) <has_locator>: Likewise.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 545         Don't declare.
 546         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 547         Remove.
 548         * tui/tui-win.c (tui_source_window_base::set_new_height)
 549         (tui_source_window_base::set_new_height)
 550         (make_invisible_and_set_new_height)
 551         (tui_source_window_base::do_make_visible_with_new_height)
 552         (tui_source_window_base::do_make_visible_with_new_height):
 553         Update.
 554         * tui/tui-layout.c (show_source_disasm_command, show_data)
 555         (show_source_or_disasm_and_command): Update.
 556         * tui/tui-layout.c (show_layout): Update.
 557
 558 2019-07-17  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-layout.c (make_data_window): Remove.
 561         (show_data): Unify creation and re-initialization cases.
 562
 563 2019-07-17  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-layout.c (make_source_window, make_disasm_window):
 566         Remove.
 567         (show_data): Unify creation and re-initialization cases.
 568
 569 2019-07-17  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-layout.c (make_command_window): Remove.
 572         (show_source_disasm_command, show_source_or_disasm_and_command):
 573         Unify creation and re-initialization cases.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 578         creation and re-initialization cases.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-regs.c (tui_get_register): Return void.
 583
 584 2019-07-17  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 587         Simplify.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 592         resetting.
 593
 594 2019-07-17  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 597         * tui/tui-regs.c (tui_reg_layout): New function.
 598         (tui_show_registers, tui_reg_command): Use it.
 599         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 600         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 601         parameters.
 602         (tui_layout_command): Remove.
 603
 604 2019-07-17  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-layout.h (tui/tui-layout): Return void.
 607         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 608
 609 2019-07-17  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-layout.c (show_source_disasm_command, show_data):
 612         Update.
 613         (reset_locator): Remove.
 614         (show_source_or_disasm_and_command): Update.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-source.c (tui_source_window_base::reset): Remove
 619         win_type parameter.
 620         * tui/tui-layout.c (make_command_window, make_source_window)
 621         (make_disasm_window, make_data_window)
 622         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 623         (reset_locator, show_source_or_disasm_and_command): Update.
 624         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 625         win_type parameter.
 626         (struct tui_source_window_base) <reset>: Likewise.
 627
 628 2019-07-17  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-layout.c (show_source_disasm_command): Use
 631         reset_locator.
 632         (reset_locator): New function.
 633         (init_and_make_win): Remove.
 634         (show_source_or_disasm_and_command): Use reset_locator.
 635
 636 2019-07-17  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 639         condition.
 640         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 641         Remove condition.
 642         * tui/tui-source.c (tui_source_window_base::reset): New method.
 643         * tui/tui-layout.c (make_command_window): Don't call
 644         init_and_make_win.
 645         (make_source_window, make_disasm_window): Don't call
 646         make_source_or_disasm_window.
 647         (make_data_window): Don't call init_and_make_win.  Change calling
 648         convention.
 649         (show_source_disasm_command, show_data): Simplify.
 650         (make_source_or_disasm_window): Remove.
 651         (show_source_or_disasm_and_command): Simplify.
 652         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 653         (struct tui_source_window_base) <reset>: Likewise.
 654         <execution_info>: Remove initializer.
 655         * tui/tui-data.c (tui_source_window_base): Initialize
 656         execution_info.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 661         variable.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui.c (tui_rl_other_window): Update.
 666         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 667         superclass method first.  Always iterate over regs_content.
 668         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 669         method.
 670         * tui/tui-win.c (tui_set_focus_command): Update.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-win.c (tui_set_focus_command): Rename from
 675         tui_set_focus.  Call tui_enable.
 676         (tui_set_focus_command): Remove.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 681         refresh_window.
 682         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 683         touchwin.
 684         (tui_data_window::refresh_window): Call refresh_window on data
 685         items.  Always call superclass refresh_window.
 686         (tui_win_info::refresh): Remove.
 687         (tui_source_window_base::refresh_window): Update.
 688         (tui_refresh_all): Update.
 689         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 690         refresh_window.
 691         (show_source_or_disasm_and_command): Likewise.
 692         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 693         (struct tui_source_window_base) <refresh>: Likewise.
 694
 695 2019-07-17  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-winsource.c (tui_clear_source_content)
 698         (tui_show_source_content): Update.
 699         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 700         whether content is empty.
 701         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 702         Remove.
 703
 704 2019-07-17  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 707         window's contents.
 708         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 709         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 714         (struct tui_data_item_window): Update.
 715
 716 2019-07-17  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 719         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 720         defines.
 721
 722 2019-07-17  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-winsource.h (tui_erase_source_content)
 725         (tui_clear_source_content): Remove "display_prompt" parameter.
 726         * tui/tui-winsource.c (tui_update_source_window_as_is)
 727         (tui_update_source_windows_with_addr): Update.
 728         (tui_clear_source_content): Remove "display_prompt" parameter.
 729         (tui_erase_source_content): Likewise.  Simplify.
 730         (tui_show_source_content): Update.
 731         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 732         * tui/tui-stack.c (tui_show_frame_info): Update.
 733         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 734         Remove defines.
 735
 736 2019-07-17  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 739         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 740         parameter.
 741         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 742         parameter.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-winsource.c (tui_clear_source_content)
 747         (tui_show_source_content, tui_show_exec_info_content)
 748         (tui_clear_exec_info_content): Update.
 749         * tui/tui-stack.c (tui_show_locator_content): Update.
 750         (tui_show_frame_info): Update.
 751         * tui/tui-source.h (tui_source_window): Don't declare.
 752         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 753         from tui_source_is_displayed.
 754         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 755         Remove field.
 756         (struct tui_source_window_base) <content_in_use>: New field.  Now
 757         bool.
 758         (struct tui_source_window) <showing_source_p>: New method.
 759         (TUI_SRC_WIN): Change cast.
 760         * tui/tui-data.c (tui_initialize_static_data): Update.
 761
 762 2019-07-17  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 765         location_matches_p.
 766         * tui/tui-source.c (tui_source_window::location_matches_p): New
 767         method.
 768         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 769         method.
 770         * tui/tui-data.h (struct tui_source_window_base)
 771         <location_matches_p>: New method.
 772         (struct tui_source_window, struct tui_disasm_window)
 773         <location_matches_p>: Likewise.
 774
 775 2019-07-17  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-win.c (tui_set_win_height_command): Rename from
 778         tui_set_win_height.
 779         (tui_set_win_height_command): Remove.
 780
 781 2019-07-17  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-source.c (tui_source_window): New constructor.  Add
 784         observer.
 785         (~tui_source_window): New destructor.
 786         (tui_source_window::style_changed): New method.
 787         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 788         (tui_attach_detach_observers): Update.
 789         * tui/tui-data.h (struct tui_source_window): Make constructor not
 790         inline.  Add destructor.
 791         (struct tui_source_window) <style_changed>: New method.
 792         <m_observable>: New member.
 793
 794 2019-07-17  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 797         * tui/tui-win.c (tui_resize_all): Fix typo.
 798
 799 2019-07-17  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 802         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 803         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 804         * tui/tui-win.c (window_name_completer): Use foreach.
 805         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 806         (update_tab_width): Likewise.
 807         * tui/tui-layout.c (show_layout): Update.
 808         * tui/tui-data.h (class tui_window_iterator): New.
 809         (struct all_tui_windows): New.
 810         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 811
 812 2019-07-17  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 815         parameter.  Don't reference globals.
 816         (tui_reg_command): Update.
 817
 818 2019-07-17  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-regs.c (tui_show_registers): Simplify.
 821
 822 2019-07-17  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-regs.c (tui_show_registers): Update.
 825         (tui_show_register_group): Add win_info parameter.
 826
 827 2019-07-17  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 830         Rename from tui_display_reg_element_at_line.
 831         (tui_data_window::display_registers_from_line): Update.
 832         * tui/tui-data.h (struct tui_data_window)
 833         <display_reg_element_at_line>: New method.
 834
 835 2019-07-17  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-regs.h (tui_display_registers_from)
 838         (tui_display_registers_from_line): Don't declare.
 839         * tui/tui-windata.c (tui_data_window::display_all_data)
 840         (tui_data_window::refresh_all)
 841         (tui_data_window::do_scroll_vertical): Update.
 842         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 843         from tui_display_registers_from.
 844         (tui_display_reg_element_at_line): Update.
 845         (tui_data_window::display_registers_from_line): Rename from
 846         tui_display_registers_from_line.
 847         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 848         display_registers_from_line>: New methods.
 849
 850 2019-07-17  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 853         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 854         from tui_erase_data_content.
 855         (tui_data_window::display_all_data)
 856         (tui_data_window::refresh_all)
 857         (tui_data_window::do_scroll_vertical): Update.
 858         * tui/tui-regs.c (tui_show_registers): Update.
 859         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 860         New method.
 861
 862 2019-07-17  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 865         declare.
 866         * tui/tui-windata.c
 867         (tui_data_window::delete_data_content_windows): Rename from
 868         tui_delete_data_content_windows.
 869         (tui_data_window::display_all_data)
 870         (tui_data_window::do_scroll_vertical): Update.
 871         * tui/tui-data.h (struct tui_data_window)
 872         <delete_data_content_windows>: New method.
 873
 874 2019-07-17  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 877         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 878
 879 2019-07-17  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 882         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 883         from tui_display_all_data.
 884         * tui/tui-win.c
 885         (tui_data_window::do_make_visible_with_new_height): Update.
 886         * tui/tui-regs.c (tui_show_registers): Update.
 887         * tui/tui-layout.c (tui_set_layout): Update.
 888         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 889         method.
 890
 891 2019-07-17  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 894         * tui/tui-windata.c (tui_display_data_from): Remove.
 895         (tui_data_window::refresh_all): Update.
 896
 897 2019-07-17  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 900         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 901         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 902         tui_display_registers_from_line.
 903         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 904         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 905         "force_display" parameter.
 906
 907 2019-07-17  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 910         declare.
 911         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 912         Rename from tui_first_reg_element_no_inline.
 913         (tui_display_reg_element_at_line)
 914         (tui_display_registers_from_line): Update.
 915         * tui/tui-data.h (struct tui_data_window)
 916         <first_reg_element_no_inline>: New method.
 917
 918 2019-07-17  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-windata.c (tui_display_data_from)
 921         (tui_data_window::do_scroll_vertical): Update.
 922         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 923         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 924         Rename from tui_line_from_reg_element_no.
 925         (tui_display_registers_from_line): Update.
 926         * tui/tui-data.h (struct tui_data_window)
 927         <line_from_reg_element_no>: New method.
 928
 929 2019-07-17  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 932         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 933         tui_last_regs_line_no.
 934         (tui_display_reg_element_at_line)
 935         (tui_display_registers_from_line): Update.
 936         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 937         method.
 938
 939 2019-07-17  Tom Tromey  <tom@tromey.com>
 940
 941         PR tui/24722:
 942         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 943         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 944         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 945         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 946         (tui_update_breakpoint_info): Likewise.
 947         * tui/tui-hooks.c (tui_event_create_breakpoint)
 948         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 949         Update.
 950
 951 2019-07-17  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 954
 955 2019-07-17  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-winsource.c (tui_update_source_window_as_is)
 958         (tui_update_source_windows_with_addr): Update.
 959         * tui/tui-source.h (tui_set_source_content)
 960         (tui_show_symtab_source): Add "win_info" parameter.
 961         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 962         parameter.
 963         (tui_show_symtab_source): Likewise.
 964
 965 2019-07-17  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-wingeneral.c
 968         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 969
 970 2019-07-17  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 973         (struct tui_cmd_window) <can_scroll>: New method.
 974         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 975         method.
 976
 977 2019-07-17  Tom Tromey  <tromey@adacore.com>
 978
 979         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 980         do_field_signed>: Rename.  Change type of "value".
 981         * ui-out.c (ui_out::field_signed): Rename from field_int.
 982         Change type of "value".
 983         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 984         type of "value".
 985         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 986         do_field_int.  Change type of "value".
 987         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 988         do_field_int.  Change type of "value".
 989         * tracepoint.c (trace_status_mi, tfind_1)
 990         (print_one_static_tracepoint_marker): Update.
 991         * thread.c (print_thread_info_1, print_selected_thread_frame):
 992         Update.
 993         * stack.c (print_frame, print_frame_info): Update.
 994         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 995         Update.
 996         * source.c (print_source_lines_base): Update.
 997         * skip.c (info_skip_command): Update.
 998         * record-btrace.c (btrace_ui_out_decode_error)
 999         (btrace_call_history_src_line): Update.
1000         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1001         Update.
1002         * progspace.c (print_program_space): Update.
1003         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1004         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1005         do_field_int.  Change type of "value".
1006         * mi/mi-out.c (mi_ui_out::do_table_begin)
1007         (mi_ui_out::do_table_header): Update.
1008         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1009         type of "value".
1010         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1011         (mi_cmd_data_list_changed_registers, output_register)
1012         (mi_cmd_data_read_memory, mi_load_progress)
1013         (mi_cmd_trace_frame_collected): Update.
1014         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1015         Update.
1016         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1017         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1018         (mi_cmd_var_list_children, varobj_update_one): Update.
1019         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1020         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1022         * inferior.c (print_inferior): Update.
1023         * gdb_bfd.c (print_one_bfd): Update.
1024         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1025         Update.
1026         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1027         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1028         do_field_int.  Change type of "value".
1029         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1030         do_field_int.  Change type of "value".
1031         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1032         (print_one_breakpoint_location, print_it_catch_fork)
1033         (print_one_catch_fork, print_it_catch_vfork)
1034         (print_one_catch_vfork, print_it_catch_solib)
1035         (print_it_catch_exec, print_it_ranged_breakpoint)
1036         (print_mention_watchpoint, print_mention_masked_watchpoint)
1037         (bkpt_print_it, update_static_tracepoint): Update.
1038         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1039         * break-catch-syscall.c (print_it_catch_syscall): Update.
1040         * ada-tasks.c (print_ada_task_info): Update.
1041         * ada-lang.c (print_it_exception, print_mention_exception):
1042         Update.
1043
1044 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         PR breakpoints/24541
1047         * gdbarch.c: Regenerate.
1048         * gdbarch.h: Regenerate.
1049         * gdbarch.sh: Adjust return type and parameter types for
1050         'stap_adjust_register'.
1051         (i386_stap_adjust_register): Adjust signature and return new
1052         register name.
1053         * stap-probe.c (stap_parse_register_operand): Adjust use of
1054         'gdbarch_stap_adjust_register'.
1055
1056 2019-07-17  Tom Tromey  <tromey@adacore.com>
1057
1058         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1059         declare VEC.
1060         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1061         std::vector.
1062         (struct s390_process_info): Add initializers.
1063         (s390_add_process): Use new.
1064         (s390_linux_nat_target::low_forget_process): Use delete.
1065         (s390_linux_nat_target::low_new_fork)
1066         (s390_linux_nat_target::stopped_by_watchpoint)
1067         (s390_linux_nat_target::low_prepare_to_resume)
1068         (s390_linux_nat_target::insert_watchpoint)
1069         (s390_linux_nat_target::insert_hw_breakpoint)
1070         (s390_linux_nat_target::remove_watchpoint)
1071         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1072
1073 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1074
1075         * aarch64-fbsd-nat.c: Include regcache.h.
1076         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1077         argument.
1078         (aarch64_fbsd_nat_target::fetch_registers)
1079         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1080         variable.
1081         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1082
1083 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1084
1085         * fbsd-nat.c: Include gdbarch.h.
1086
1087 2019-07-15  Tom Tromey  <tromey@adacore.com>
1088
1089         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1090
1091 2019-07-15  Tom Tromey  <tromey@adacore.com>
1092
1093         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1094         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1095         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1096         * cli-out.c (cli_ui_out::do_field_int): New method.
1097         * ui-out.c (ui_out::field_unsigned): New method.
1098         * symfile.c (generic_load): Use field_unsigned.
1099         (print_transfer_performance): Likewise.
1100         * record-btrace.c (ui_out_field_uint): Remove.
1101         (btrace_call_history_insn_range, btrace_call_history): Use
1102         field_unsigned.
1103         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1104         field_unsigned.
1105         * ui-out.h (class ui_out) <field_unsigned>: New method.
1106         <do_field_unsigned>: Likewise.
1107
1108 2019-07-15  Tom Tromey  <tromey@adacore.com>
1109
1110         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1111         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1112         * target.c (flash_erase_command): Use field_string.
1113         * infrun.c (print_signal_received_reason): Use field_string.
1114         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1115         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1116         field_string.
1117         * ada-tasks.c (print_ada_task_info): Use field_string.
1118
1119 2019-07-15  Tom Tromey  <tromey@adacore.com>
1120
1121         * target.c (flash_erase_command): Use field_core_addr.
1122         * symfile.c (generic_load): Use field_core_addr.
1123         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1124         Use field_core_addr.
1125         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1126         field_core_addr.
1127
1128 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1131         value if its desired type is smaller than a CORE_ADDR and signed.
1132
1133 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1136         of changes to field names, and use new is_reference field to
1137         decide if a property is a reference or not.
1138         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1139         field.
1140         (struct dwarf2_property_baton): Update header comment, rename
1141         'referenced_type' to 'property_type' and update comments.
1142         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1143         default property type, store in property baton, update to take
1144         accound of renamed field.
1145         (read_func_scope): Update call to attr_to_dynamic_prop.
1146         (read_array_type): Likewise.
1147         (dwarf2_per_cu_addr_sized_int_type): New function.
1148         (read_subrange_index_type): Move type finding code to
1149         dwarf2_per_cu_addr_sized_int_type.
1150         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1151         (dwarf2_per_cu_addr_type): New function.
1152         (set_die_type): Update calls to attr_to_dynamic_prop.
1153
1154 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * dwarf2read.c (read_subrange_index_type): New function.
1157         (read_subrange_type): Move code into new function and call it.
1158         * gdbtypes.c (create_range_type): Add some asserts.
1159
1160 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1163         update return statements.
1164         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1165         declaration, and update comment to match.
1166         * gdbtypes.c (resolve_dynamic_array): Update call to
1167         dwarf2_evaluate_property to match new return type.
1168
1169 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * valarith.c (value_subscripted_rvalue): Change lowerbound
1172         parameter type from int to LONGEST.
1173         * value.h (value_subscripted_rvalue): Likewise in declaration.
1174
1175 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * cli/cli-utils.c (info_print_command_completer): New function.
1178         * cli/cli-utils.h: Add 'completer.h' include, and forward
1179         declaration for 'struct cmd_list_element'.
1180         (info_print_command_completer): Declare.
1181         * stack.c (_initialize_stack): Add completer for 'info locals' and
1182         'info args'.
1183         * symtab.c (_initialize_symtab): Add completer for 'info
1184         variables' and 'info functions'.
1185         * NEWS: Mention completion for additional info commands.
1186
1187 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * cli/cli-utils.c (extract_info_print_args): Delete.
1190         (extract_arg_maybe_quoted): Delete.
1191         (info_print_options_defs): New variable.
1192         (make_info_print_options_def_group): New function.
1193         (extract_info_print_options): Define new function.
1194         * cli/cli-utils.h (extract_info_print_args): Delete.
1195         (struct info_print_options): New structure.
1196         (extract_info_print_options): Declare new function.
1197         * stack.c (info_locals_command): Update to use new
1198         extract_info_print_options, also add a header comment.
1199         (info_args_command): Likewise.
1200         * symtab.c (info_variables_command): Likewise.
1201         (info_functions_command): Likewise.
1202
1203 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1206         to extract string arguments.
1207         * common/common-utils.c (extract_string_maybe_quoted): New function.
1208         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1209
1210 2019-07-11  Tom Tromey  <tromey@adacore.com>
1211
1212         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1213         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1214         * top.h (gdbinit): Don't declare.
1215         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1216         into...
1217         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1218         * top.c (gdb_init): Don't call init_cli_cmds.
1219         (gdbinit): Remove.
1220         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1221
1222 2019-07-11  Tom Tromey  <tromey@adacore.com>
1223
1224         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1225         after it has been moved.
1226
1227 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1228
1229         * valops.c (value_must_coerce_to_target): Change return type to
1230         bool.
1231         * value.h (value_must_coerce_to_target): Likewise.
1232
1233 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1234
1235         * breakpoint.c (is_hardware_watchpoint): Remove
1236         forward-declaration.
1237         (is_masked_watchpoint): Change return type to bool.
1238         (is_tracepoint): Likewise.
1239         (is_breakpoint): Likewise.
1240         (is_hardware_watchpoint): Likewise.
1241         (is_watchpoint): Likewise.
1242         (is_no_memory_software_watchpoint): Likewise.
1243         (is_catchpoint): Likewise.
1244         (breakpoint_1): Make FILTER parameter's return type bool.
1245         is_masked_watchpoint): Change return type to bool.
1246         (save_breakpoints): Make FILTER parameter's return type bool.
1247         * breakpoint.h (is_breakpoint): Change return type to bool.
1248         (is_watchpoint): Likewise.
1249         (is_catchpoint): Likewise.
1250         (is_tracepoint): Likewise.
1251
1252 2019-07-10  Tom Tromey  <tom@tromey.com>
1253
1254         * defs.h: Don't include gdbarch.h.
1255         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1256         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1257         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1258         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1259         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1260         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1261         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1262         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1263         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1264         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1265         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1266         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1267         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1268         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1269         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1270         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1271         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1272         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1273         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1274         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1275         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1276         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1277         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1278         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1279         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1280         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1281         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1282
1283 2019-07-10  Tom Tromey  <tromey@adacore.com>
1284
1285         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1286         * breakpoint.c (init_ada_exception_breakpoint): Register as
1287         bp_catchpoint.
1288         (print_one_breakpoint_location, print_one_breakpoint): Use
1289         is_ada_exception_catchpoint.
1290         * ada-lang.c (class ada_catchpoint_location): Pass
1291         bp_loc_software_breakpoint to bp_location constructor.
1292         (is_ada_exception_catchpoint): New function.
1293
1294 2019-07-10  Tom Tromey  <tromey@adacore.com>
1295
1296         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1297         VEC.
1298         (struct arm_exidx_entry): New method operator<.
1299         (struct arm_exidx_data) <section_maps>: Change type.
1300         (arm_exidx_data_free): Remove.
1301         (arm_exidx_data_key): Change type.  Move lower.
1302         (arm_exidx_new_objfile): Update.
1303         (arm_compare_exidx_entries): Remove.
1304         (arm_find_exidx_entry, _initialize_arm_tdep)
1305
1306 2019-07-10  Tom Tromey  <tromey@adacore.com>
1307
1308         * solib-spu.c (ocl_program_data_key): Change type.
1309         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1310         Update.
1311
1312 2019-07-10  Tom Tromey  <tromey@adacore.com>
1313
1314         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1315         (struct solib_aix_inferior_data) <library_list>: Change type.
1316         (solib_aix_inferior_data_handle): Change type.
1317         (get_solib_aix_inferior_data): Update.
1318         (solib_aix_free_library_list): Remove.
1319         (library_list_start_library): Update.
1320         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1321         return type.
1322         (solib_aix_get_library_list)
1323         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1324         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1325
1326 2019-07-10  Tom Tromey  <tromey@adacore.com>
1327
1328         * solib-dsbt.c (struct dsbt_info): Add initializers.
1329         (solib_dsbt_pspace_data): Change type.
1330         (dsbt_pspace_data_cleanup): Remove.
1331         (get_dsbt_info, _initialize_dsbt_solib): Update.
1332
1333 2019-07-10  Tom Tromey  <tromey@adacore.com>
1334
1335         * spu-tdep.c (spu_overlay_data): Change type.
1336         (spu_get_overlay_table, spu_overlay_new_objfile)
1337         (_initialize_spu_tdep): Update.
1338
1339 2019-07-10  Tom Tromey  <tromey@adacore.com>
1340
1341         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1342         destructor.
1343         (dbx_objfile_data_key): Change type and declare later.
1344         (DBX_SYMFILE_INFO): Rewrite.
1345         * dbxread.c (dbx_objfile_data_key): Change type.
1346         (dbx_symfile_init): Update.
1347         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1348         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1349         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1350
1351 2019-07-10  Tom Tromey  <tromey@adacore.com>
1352
1353         * jit.c (jit_program_space_key): Change type.  Move lower.
1354         (get_jit_program_space_data): Update.
1355         (jit_program_space_data_cleanup): Remove.
1356         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1357         Update.
1358         (struct jit_program_space_data): Add initializers.
1359
1360 2019-07-10  Tom Tromey  <tromey@adacore.com>
1361
1362         * solib-darwin.c (struct darwin_info): Add initializers.
1363         (solib_darwin_pspace_data): Change type.
1364         (darwin_pspace_data_cleanup): Remove.
1365         (get_darwin_info, _initialize_darwin_solib): Update.
1366
1367 2019-07-10  Tom Tromey  <tromey@adacore.com>
1368
1369         * remote-sim.c (struct sim_inferior_data): Add initializers,
1370         constructor, and destructor.
1371         (sim_inferior_data_key): Change type.  Move lower.
1372         (check_for_duplicate_sim_descriptor): Update.
1373         (get_sim_inferior_data): Use new.  Update.
1374         (~sim_inferior_data_cleanup): Rename from
1375         sim_inferior_data_cleanup.  Simplify.
1376         (gdbsim_close_inferior, simulator_command)
1377         (sim_command_completer, _initialize_remote_sim): Update.
1378         (next_pid, INITIAL_PID): Move earlier.
1379
1380 2019-07-10  Tom Tromey  <tromey@adacore.com>
1381
1382         * python/python-internal.h (create_thread_object): Return
1383         gdbpy_ref.
1384         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1385         * python/py-inferior.c (struct threadlist_entry): Add
1386         constructor.
1387         <thread_obj>: Now a gdbpy_ref.
1388         (thread_to_thread_object): Update.
1389         (add_thread_object): Use new.
1390         (delete_thread_object): Use delete.
1391         (infpy_threads): Update.
1392         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1393         GIL.
1394
1395 2019-07-10  Tom Tromey  <tromey@adacore.com>
1396
1397         * valops.c (value_cast): Specialize error message for Ada.
1398
1399 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1400
1401         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1402
1403 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1404
1405         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1406         bpstat_should_step): Return bool, adjust comments.
1407         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1408         bpstat_should_step): Likewise.
1409
1410 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1411
1412         * features/Makefile: Use feature target descriptions for Arm.
1413         * features/arm/arm-core.c: Generate new file.
1414         * features/arm/arm-fpa.c: Likewise.
1415         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1416         * features/arm/arm-m-profile.c: Likewise.
1417         * features/arm/arm-vfpv2.c: Likewise.
1418         * features/arm/arm-vfpv3.c: Likewise.
1419         * features/arm/xscale-iwmmxt.c: Likewise.
1420         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1421
1422 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1423
1424         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1425         ptrace earlier.
1426
1427 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1428
1429         * features/aarch64-pauth.c: Regenerate.
1430
1431 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1432
1433         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1434         bool.
1435         (bpstat_what): Use false instead of 0.
1436
1437 2019-07-09  Pedro Alves  <palves@redhat.com>
1438
1439         * break-catch-throw.c (is_exception_catchpoint): New.
1440         * breakpoint.c (print_one_breakpoint_location): New parameter
1441         'raw_loc'.  Handle it.  Use
1442         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1443         looking at the breakpoint's type.
1444         (print_one_breakpoint): If handling "maint info breakpoints", also
1445         print locations of exception catchpoints.
1446         * breakpoint.h (is_exception_catchpoint): Declare.
1447
1448 2019-07-09  Pedro Alves  <palves@redhat.com>
1449
1450         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1451         "addr" field.
1452         (allocate_location_exception_catchpoint): New.
1453         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1454         (initialize_throw_catchpoint_ops): Install
1455         allocate_location_exception_catchpoint as allocate_location
1456         method.
1457         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1458         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1459         bp_loc_other.
1460         (breakpoint_address_is_meaningful): Delete.
1461         (bl_address_is_meaningful): New.
1462         (breakpoint_locations_match): Adjust comment.
1463         (bp_location_from_bp_type): New, factored out of...
1464         (bp_location::bp_location(breakpoint *)): ... this.
1465         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1466         factored out of...
1467         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1468         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1469         breakpoint_address_is_meaningful.
1470         (bp_locations_compare): Adjust comment.
1471         (update_global_location_list): Use bl_address_is_meaningful
1472         instead of breakpoint_address_is_meaningful.
1473         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1474         explicit.
1475         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1476         * python/py-breakpoint.c (bppy_get_location): No longer check
1477         whether location is null.
1478
1479 2019-07-09  Pedro Alves  <palves@redhat.com>
1480
1481         PR c++/15468
1482         * breakpoint.c (print_one_breakpoint_location): Remove
1483         single-location assert.
1484
1485 2019-07-09  Tom Tromey  <tom@tromey.com>
1486
1487         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1488         * configure: Rebuild.
1489         * configure.ac: Change common to gdbsupport.
1490         * gdbsupport: Rename from common.
1491         * acinclude.m4: Change common to gdbsupport.
1492         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1493         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1494         gdbsupport.
1495         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1496         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1497         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1498         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1499         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1500         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1501         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1502         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1503         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1504         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1505         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1506         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1507         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1508         coff-pe-read.c, command.h, compile/compile-c-support.c,
1509         compile/compile-c.h, compile/compile-cplus-symbols.c,
1510         compile/compile-cplus-types.c, compile/compile-cplus.h,
1511         compile/compile-loc2c.c, compile/compile.c, completer.c,
1512         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1513         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1514         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1515         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1516         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1517         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1518         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1519         features/aarch64-core.c, features/aarch64-fpu.c,
1520         features/aarch64-pauth.c, features/aarch64-sve.c,
1521         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1522         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1523         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1524         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1525         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1526         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1527         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1528         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1529         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1530         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1531         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1532         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1533         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1534         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1535         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1536         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1537         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1538         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1539         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1540         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1541         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1542         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1543         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1544         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1545         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1546         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1547         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1548         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1549         minsyms.c, mips-linux-tdep.c, namespace.h,
1550         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1551         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1552         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1553         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1554         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1555         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1556         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1557         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1558         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1559         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1560         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1561         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1562         procfs.c, producer.c, progspace.h, psymtab.h,
1563         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1564         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1565         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1566         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1567         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1568         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1569         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1570         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1571         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1572         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1573         target-memory.c, target.c, target.h, target/waitstatus.c,
1574         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1575         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1576         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1577         unittests/array-view-selftests.c,
1578         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1579         unittests/common-utils-selftests.c,
1580         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1581         unittests/format_pieces-selftests.c,
1582         unittests/function-view-selftests.c,
1583         unittests/lookup_name_info-selftests.c,
1584         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1585         unittests/mkdir-recursive-selftests.c,
1586         unittests/observable-selftests.c,
1587         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1588         unittests/parse-connection-spec-selftests.c,
1589         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1590         unittests/scoped_fd-selftests.c,
1591         unittests/scoped_mmap-selftests.c,
1592         unittests/scoped_restore-selftests.c,
1593         unittests/string_view-selftests.c, unittests/style-selftests.c,
1594         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1595         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1596         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1597         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1598         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1599         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1600
1601 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1602
1603         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1604         bool value.
1605         (decode_digits_ordinary): Set explicit_line field in sal.
1606         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1607         symtab_and_line that was set on an explicit line number in
1608         assembler code.  Do always update the recorded symtab and line if
1609         we do skip the prologue.
1610
1611 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * breakpoint.c (set_breakpoint_location_function): Remove
1614         explicit_loc parameter.
1615         (momentary_breakpoint_from_master): Update call to
1616         set_breakpoint_location_function.
1617         (add_location_to_breakpoint): Likewise.
1618
1619 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1622         required features based on default bfd type when no specific bfd
1623         is present.
1624
1625 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1626
1627         * NEWS: Mention that GDB printf and eval commands can now print
1628         C-style and Ada-style convenience var strings without
1629         calling the inferior.
1630         * printcmd.c (printf_c_string): Locally print GDB internal var
1631         instead of transiting via the inferior.
1632         (printf_wide_c_string): Likewise.
1633
1634 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1635
1636         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1637
1638 2019-07-04  Tom Tromey  <tom@tromey.com>
1639
1640         PR tui/24724:
1641         * tui/tui-winsource.c (tui_clear_source_content): Update.
1642         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1643         (tui_update_breakpoint_info): Update.
1644         (tui_set_exec_info_content): Update.
1645         * tui/tui-source.c (tui_set_source_content_nil): Update.
1646         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1647         has_break.
1648         * tui/tui-data.h (enum tui_bp_flag): New.
1649         (tui_bp_flags): New enum flags type.
1650         (struct tui_source_element) <break_mode>: Change type.  Rename
1651         from has_break.
1652         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1653         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1654         constants.
1655         * tui/tui-winsource.h: Fix comment.
1656
1657 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1658
1659         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1660         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1661         (store_fpregs_to_thread)
1662         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1663         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1664         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1665         (IWMMXT_REGS_SIZE): Add define.
1666         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1667         (fetch_vfp_regs, store_vfp_regs)
1668         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1669         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1670
1671 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1674         defines.
1675         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1676         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1677         (ARM_INT_REGISTER_SIZE): ...to this.
1678         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1679         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1680         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1681         (arm_linux_collect_gregset, supply_nwfpe_register)
1682         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1683         defines.
1684         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1685         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1686         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1687         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1688         (arm_return_in_memory, arm_store_return_value)
1689         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1690         (arm_record_ld_st_multiple): Likewise.
1691         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1692         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1693
1694 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1695
1696         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1697         AARCH64_DISPLACED_MODIFIED_INSNS.
1698         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1699         (aarch64_displaced_step_copy_insn): Likewise.
1700         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1701         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1702         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1703         ARM_DISPLACED_MODIFIED_INSNS.
1704         * arm-tdep.c (arm_gdbarch_init): Likewise.
1705         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1706         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1707         (struct arm_displaced_step_closure): Use
1708         ARM_DISPLACED_MODIFIED_INSNS.
1709
1710 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1711
1712         * features/Makefile: Remove unused xml files.
1713         * features/aarch64.xml: Remove.
1714         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1715         * features/i386/amd64-avx-avx512.xml: Remove.
1716         * features/i386/amd64-avx-linux.xml: Remove.
1717         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1718         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1719         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1720         * features/i386/amd64-avx-mpx.xml: Remove.
1721         * features/i386/amd64-avx.xml: Remove.
1722         * features/i386/amd64-linux.xml: Remove.
1723         * features/i386/amd64-mpx-linux.xml: Remove.
1724         * features/i386/amd64-mpx.xml: Remove.
1725         * features/i386/amd64.xml: Remove.
1726         * features/i386/i386-avx-avx512-linux.xml: Remove.
1727         * features/i386/i386-avx-avx512.xml: Remove.
1728         * features/i386/i386-avx-linux.xml: Remove.
1729         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1730         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1731         * features/i386/i386-avx-mpx-linux.xml: Remove.
1732         * features/i386/i386-avx-mpx.xml: Remove.
1733         * features/i386/i386-avx.xml: Remove.
1734         * features/i386/i386-linux.xml: Remove.
1735         * features/i386/i386-mmx-linux.xml: Remove.
1736         * features/i386/i386-mmx.xml: Remove.
1737         * features/i386/i386-mpx-linux.xml: Remove.
1738         * features/i386/i386-mpx.xml: Remove.
1739         * features/i386/i386.xml: Remove.
1740         * features/i386/x32-avx-avx512-linux.xml: Remove.
1741         * features/i386/x32-avx-linux.xml: Remove.
1742         * features/i386/x32-linux.xml: Remove.
1743
1744 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1745
1746         * regformats/aarch64.dat: Remove.
1747         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1748         * regformats/i386/amd64-avx-linux.dat: Remove.
1749         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1750         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1751         * regformats/i386/amd64-linux.dat: Remove.
1752         * regformats/i386/amd64-mpx-linux.dat: Remove.
1753         * regformats/i386/amd64.dat: Remove.
1754         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1755         * regformats/i386/i386-avx-linux.dat: Remove.
1756         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1757         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1758         * regformats/i386/i386-linux.dat: Remove.
1759         * regformats/i386/i386-mmx-linux.dat: Remove.
1760         * regformats/i386/i386-mpx-linux.dat: Remove.
1761         * regformats/i386/i386.dat: Remove.
1762         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1763         * regformats/i386/x32-avx-linux.dat: Remove.
1764         * regformats/i386/x32-linux.dat: Remove.
1765
1766 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1767
1768         * aarch64-tdep.c: Remove xml self tests.
1769         * amd64-linux-tdep.c: Likewise.
1770         * amd64-tdep.c: Likewise.
1771         * i386-linux-tdep.c: Likewise.
1772         * i386-tdep.c: Likewise.
1773
1774 2019-07-03  Pedro Alves  <palves@redhat.com>
1775
1776         PR cli/24732
1777         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1778         (pipe_cmd_option_defs): New.
1779         (make_pipe_cmd_options_def_group): New.
1780         (pipe_command): Use gdb::option::process_options.
1781         (pipe_command_completer): New function.
1782         (_initialize_cli_cmds): Install completer for "pipe" command.
1783
1784 2019-07-03  Pedro Alves  <palves@redhat.com>
1785
1786         * cli/cli-option.c (union option_value) <string>: New field.
1787         (struct option_def_and_value): Add ctor, move ctor, dtor and
1788         use DISABLE_COPY_AND_ASSIGN.
1789         (option_def_and_value::clear_value): New.
1790         (parse_option, save_option_value_in_ctx, get_val_type_str)
1791         (add_setshow_cmds_for_options): Handle var_string.
1792         * cli-option.h (union option_def::var_address) <string>: New
1793         field.
1794         (struct string_option_def): New.
1795         * maint-test-options.c (struct test_options_opts): Add default
1796         ctor and use DISABLE_COPY_AND_ASSIGN.
1797         <string_opt>: New field.
1798         (test_options_opts::~test_options_opts): New.
1799         (test_options_opts::dump): Also dump "-string".
1800         (test_options_option_defs): Install "string.
1801
1802 2019-07-03  Pedro Alves  <palves@redhat.com>
1803
1804         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1805         option_value with a null enumeration.
1806         (complete_options): Save the option values in the context.
1807         (save_option_value_in_ctx): New, factored out from ...
1808         (process_options): ... here.
1809         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1810         of the function.
1811         * maint-test-options.c (test_options_opts::dump): New, factored
1812         out from ...
1813         (maintenance_test_options_command_mode): ... here.
1814         (maintenance_test_options_command_completion_result): Delete.
1815         (maintenance_test_options_command_completion_text): Update
1816         comment.
1817         (maintenance_show_test_options_completion_result): Change
1818         prototype.  Just print
1819         maintenance_test_options_command_completion_text.
1820         (save_completion_result): New.
1821         (maintenance_test_options_completer_mode): Pass options context to
1822         complete_options, and then save a dump.
1823         (_initialize_maint_test_options): Use add_cmd to install "maint
1824         show test-options-completion-result".
1825
1826 2019-07-03  Pedro Alves  <palves@redhat.com>
1827
1828         * NEWS (New commands): Mention "with" and "maint with".
1829         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1830         (with_command, with_command_completer): New.
1831         (pipe_command): Adjust to new repeat_previous
1832         interface.
1833         (_initialize_cli_cmds): Install the "with" command and its "w"
1834         alias.
1835         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1836         declarations.
1837         * cli/cli-setshow.c (parse_cli_var_uinteger)
1838         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1839         argument strings for all var_types.
1840         (get_setshow_command_value_string): New, factored out from ...
1841         (do_show_command): ... this.
1842         * cli/cli-setshow.h: Include <string>.
1843         (get_setshow_command_value_string): Declare.
1844         * command.h (repeat_previous): Now returns const char *.  Adjust
1845         comment.
1846         * maint.c: Include "cli/cli-cmds.h".
1847         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1848         (_initialize_maint_cmds): Register the "maintenance with" command.
1849         * top.c (repeat_previous): Move bits from pipe_command here:
1850         Return the saved command line, if any; error out if there's no
1851         command to relaunch.
1852
1853 2019-07-03  Pedro Alves  <palves@redhat.com>
1854
1855         * NEWS (New commands): Mention "maint set/show test-settings"
1856         instead of "maint test-settings".
1857         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1858         (maintenance_test_settings_set_list): Rename to ...
1859         (maintenance_set_test_settings_list): ... this.
1860         (maintenance_test_settings_show_list): Rename to  ...
1861         (maintenance_show_test_settings_list): ... this.
1862         (maintenance_test_settings_cmd): Delete.
1863         (maintenance_test_settings_set_cmd): ...
1864         (maintenance_set_test_settings_cmd): ... this.
1865         (maintenance_test_settings_show_cmd): ...
1866         (maintenance_show_test_settings_cmd): ... this.
1867         (maintenance_test_settings_show_value_cmd):
1868         (maintenance_show_test_settings_value_cmd): ... this.
1869         (_initialize_maint_test_settings): No longer install the "maint
1870         test-settings" prefix command.  Rename "maint test-settings set"
1871         to "maint set test-settings", and "maint test-settings show" to
1872         "maint show test-settings".  Adjust all subcommands.
1873
1874 2019-07-03  Pedro Alves  <palves@redhat.com>
1875
1876         * maint-test-settings.c: Fix file's intro comment.  Replace all
1877         references to "test-options" with references to "test-settings",
1878         in comments.
1879
1880 2019-07-03  Pedro Alves  <palves@redhat.com>
1881
1882         * maint-test-settings.c (maintenance_test_settings_xxx)
1883         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1884         New.
1885         (maintenance_test_settings_enums): Use them.
1886         (maintenance_test_settings_enum): Default to
1887         maintenance_test_settings_xxx.
1888         (_initialize_maint_test_settings): Initialize
1889         MAINTENANCE_TEST_SETTINGS_FILENAME.
1890
1891 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1892
1893         * breakpoint.h (remove_breakpoints_inf): Change return type to
1894         void, move function documentation here.
1895         * breakpoint.c (remove_breakpoints_inf): Change return type to
1896         void, move function documentation to header.
1897
1898 2019-07-02  Pedro Alves  <palves@redhat.com>
1899
1900         * NEWS (Completion improvements): Mention "info threads".
1901         * thread.c (struct info_threads_opts, info_threads_option_defs)
1902         (make_info_threads_options_def_group): New.
1903         (info_threads_command): Use gdb::option::process_options.
1904         (info_threads_command_completer): New.
1905         (_initialize_thread): Use gdb::option::build_help to build the
1906         help text for "info threads".
1907
1908 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1909
1910         * defs.h (generic_load): Move from here...
1911         * symfile.h (generic_load): ... to here.  Rename name parameter
1912         to args.
1913         * symfile.c (generic_load): Add comment.
1914
1915 2019-07-01  Tom Tromey  <tromey@adacore.com>
1916
1917         * dwarf2read.c
1918         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1919         declaration of without_params.  Fix formatting.
1920
1921 2019-07-01  Tom Tromey  <tromey@adacore.com>
1922
1923         * ada-exp.y (find_primitive_type): Update.
1924         * ada-lang.h (ada_lookup_symbol): Update.
1925         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1926         parameter.
1927         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1928
1929 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1930
1931         PR breakpoints/24541
1932         * gdbarch.c: Regenerate.
1933         * gdbarch.h: Regenerate.
1934         * gdbarch.sh: Add 'stap_adjust_register'.
1935         * i386-tdep.c: Include '<unordered_set>'.
1936         (i386_stap_adjust_register): New function.
1937         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1938         * stap-probe.c (stap_parse_register_operand): Call
1939         'gdbarch_stap_adjust_register'.
1940
1941 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1942
1943         PR python/24742
1944         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1945         * python/python.c (do_start_initialization): Use 'xmalloc'
1946         instead of 'PyMem_Malloc'.
1947
1948 2019-06-28  Tom Tromey  <tromey@adacore.com>
1949
1950         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1951         for Ada.
1952
1953 2019-06-27  Tom Tromey  <tromey@adacore.com>
1954
1955         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1956         objfile_key.
1957         (arm_find_mapping_symbol, arm_record_special_symbol)
1958         (_initialize_arm_tdep): Update.
1959         (arm_objfile_data_free): Remove.
1960
1961 2019-06-27  Tom Tromey  <tromey@adacore.com>
1962
1963         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1964         to cp_print_static_field.
1965
1966 2019-06-26  Tom Tromey  <tromey@adacore.com>
1967
1968         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1969         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1970         declare.
1971
1972 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1973
1974         * features/aarch64-core.c (create_feature_aarch64_core):
1975         Regenerate.
1976         * features/aarch64-core.xml: Add cpsr flags.
1977
1978 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1979
1980         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1981         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1982
1983 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1984
1985         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1986         field.
1987         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1988         use.
1989         (arm_record_special_symbol): Don't insert new symbol in sorted
1990         position, push it at the end.
1991
1992 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1993
1994         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1995         (arm_mapping_symbol_s): Remove.
1996         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1997         (arm_mapping_symbol_vec): New typedef.
1998         (struct arm_per_objfile): Add constructor.
1999         <section_maps>: Change type to
2000         std::unique_ptr<arm_mapping_symbol_vec[]>.
2001         (arm_compare_mapping_symbols): Remove.
2002         (arm_find_mapping_symbol): Adjust to section_maps type change.
2003         (arm_objfile_data_free): Call delete on arm_per_objfile.
2004         (arm_record_special_symbol): Adjust to section_maps type change.
2005         Allocate arm_per_objfile with new.
2006
2007 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2008
2009         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2010         with the command prefix.
2011
2012 2019-06-25  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2015         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2020         type.
2021         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2022         protected.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-winsource.c
2027         (tui_source_window_base::set_is_exec_point_at): Add check against
2028         LOA_ADDRESS.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-source.c (tui_set_source_content): Don't check before
2033         xfree.
2034         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-winsource.h (tui_update_source_window_as_is)
2039         (tui_alloc_source_buffer, tui_line_is_displayed)
2040         (tui_addr_is_displayed): Change type of win_info.
2041         * tui/tui-winsource.c (tui_update_source_window_as_is)
2042         (tui_clear_source_content, tui_show_source_line)
2043         (tui_show_source_content, tui_source_window_base::refill)
2044         (tui_source_window_base::set_is_exec_point_at)
2045         (tui_source_window_base::set_is_exec_point_at)
2046         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2047         (tui_alloc_source_buffer, tui_line_is_displayed)
2048         (tui_addr_is_displayed): Change type of win_info.  Update.
2049         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2050         (tui_source_window_base::do_make_visible_with_new_height):
2051         Update.
2052         * tui/tui-source.c (tui_set_source_content)
2053         (tui_set_source_content_nil)
2054         (tui_source_window::do_scroll_vertical): Update.
2055         * tui/tui-layout.c (show_layout): Update.
2056         * tui/tui-disasm.c (tui_set_disassem_content)
2057         (tui_disasm_window::do_scroll_vertical): Update.
2058         * tui/tui-data.h (tui_win_content): Remove.
2059         (struct tui_gen_win_info) <content, content_size>: Remove.
2060         (struct tui_source_element): Add initializers and destructor.
2061         (union tui_which_element, struct tui_win_element): Remove.
2062         (struct tui_source_window_base) <content>: New field.
2063         (struct tui_data_window): Remove destructor.
2064         (tui_alloc_content, tui_free_win_content)
2065         (tui_free_all_source_wins_content): Don't declare.
2066         * tui/tui-data.c (tui_initialize_static_data): Update.
2067         (init_content_element, tui_alloc_content): Remove.
2068         (~tui_gen_win_info): Update.
2069         (~tui_data_window, tui_free_all_source_wins_content)
2070         (tui_free_win_content, free_content, free_content_elements):
2071         Remove.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-winsource.h (tui_clear_source_content)
2076         (tui_erase_source_content, tui_show_source_content): Change type
2077         of win_info.
2078         * tui/tui-winsource.c (tui_clear_source_content)
2079         (tui_erase_source_content, tui_show_source_content): Change type
2080         of win_info.
2081         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2082         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2083         win_info.
2084         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2085         win_info.
2086         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2087
2088 2019-06-25  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-winsource.c (tui_clear_source_content)
2091         (tui_source_window_base::set_is_exec_point_at): Update.
2092         * tui/tui-source.c (tui_set_source_content_nil): Update.
2093         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2094         a bool.
2095         * tui/tui-data.c (init_content_element): Update.
2096
2097 2019-06-25  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2100         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2101         * tui/tui-layout.c (init_and_make_win): Update.
2102         * tui/tui.h (enum tui_win_type): Update.
2103         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2104         tui_win_is_auxillary.
2105         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2106         tui_win_is_auxillary.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2111         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2112         (tui_delete_data_content_windows, tui_display_all_data)
2113         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2114         Update.
2115         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2116         * tui/tui-regs.c (tui_last_regs_line_no)
2117         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2118         (tui_show_registers): Update.
2119         (tui_show_register_group): Return void.  Update.
2120         (tui_display_registers_from, tui_display_reg_element_at_line)
2121         (tui_display_registers_from_line, tui_check_register_values):
2122         Update.
2123         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2124         member.
2125         (struct tui_data_window) <regs_content>: Now a std::vector.
2126         <regs_content_count>: Remove.
2127         (tui_add_content_elements, tui_free_data_content): Don't declare.
2128         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2129         (init_content_element): Remove DATA_WIN case.  Add assert.
2130         (tui_add_content_elements): Remove.
2131         (tui_data_window): Update.
2132         (tui_free_data_content): Remove.
2133         (free_content_elements): Remove DATA_WIN case.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-data.c (tui_data_item_window): Update.
2138         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2139         * tui/tui-windata.c (tui_display_all_data)
2140         (tui_display_data_from_line): Update.
2141         (tui_check_data_values): Remove.
2142         * tui/tui-regs.c (tui_show_register_group)
2143         (tui_display_reg_element_at_line): Update.
2144         * tui/tui-hooks.c (tui_register_changed)
2145         (tui_refresh_frame_and_register_information): Call
2146         tui_check_register_values.
2147         * tui/tui-data.h (struct tui_data_window) <data_content,
2148         data_content_count, data_type>: Remove.
2149         (enum tui_data_type): Remove.
2150
2151         * tui/tui-data.c (tui_data_window::clear_detail)
2152         (~tui_data_window): Update.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2157         declare.
2158         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2159         Rename from tui_first_data_item_displayed.  Update.
2160         (tui_data_window::refresh_all)
2161         (tui_data_window::do_scroll_vertical): Update.
2162         * tui/tui-data.h (struct tui_data_window)
2163         <first_data_item_displayed>: Declare new method.
2164
2165 2019-06-25  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2168         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2169         contents...
2170         (tui_initialize_static_data): ...here.
2171
2172 2019-06-25  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2175         (tui_display_registers_from, tui_check_register_values): Update.
2176         (tui_display_register): Remove win_info parameter; update.
2177         (tui_get_register): Change type of parameters.
2178         * tui/tui-data.h (struct tui_data_element): Remove.
2179         (union tui_which_element) <data>: Remove.
2180         <data_window>: Change type.
2181         (struct tui_data_item_window): New.
2182         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2183         case.  Add assert.
2184         (~tui_data_item_window): New destructor.
2185         (free_content_elements): Remove DATA_ITEM_WIN case.
2186
2187 2019-06-25  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2190         Remove.
2191
2192 2019-06-25  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-data.h (struct tui_command_element): Remove.
2195         (union tui_which_element) <command>: Remove.
2196         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2197         assert.
2198         (free_content_elements): Remove CMD_WIN case.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-layout.c (tui_set_layout): Update.
2203         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2204         * tui/tui-data.c (layout_def): Update.
2205
2206 2019-06-25  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2210         (tui_source_window_base::set_new_height): Update.
2211         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2212         Update.
2213         (tui_set_locator_fullname, tui_set_locator_info)
2214         (tui_show_frame_info): Update.
2215         * tui/tui-source.c (tui_set_source_content)
2216         (tui_source_is_displayed): Update.
2217         * tui/tui-layout.c (show_source_disasm_command, show_data)
2218         (show_source_or_disasm_and_command): Update.
2219         * tui/tui-disasm.c (tui_set_disassem_content)
2220         (tui_get_begin_asm_address): Update.
2221         * tui/tui-data.h (struct tui_locator_element): Remove.
2222         (union tui_which_element) <locator>: Remove.
2223         (struct tui_locator_window): New.
2224         (tui_locator_win_info_ptr): Change return type.
2225         * tui/tui-data.c (_locator): Change type.
2226         (tui_locator_win_info_ptr): Change return type.
2227         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2228         (tui_alloc_content): Add assert.
2229
2230 2019-06-25  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-winsource.c
2233         (tui_exec_info_window::maybe_allocate_content): New method.
2234         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2235         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2236         (make_source_or_disasm_window): Add cast.
2237         * tui/tui-data.h (union tui_which_element) <simple_string>:
2238         Remove.
2239         (struct tui_source_info): New.
2240         (struct tui_source_window_base) <execution_info>: Change type.
2241         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2242         case, and add assert.
2243         (tui_alloc_content): Add assert.
2244
2245 2019-06-25  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2248         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2249         * tui/tui-data.c (tui_alloc_win_info): Remove.
2250
2251 2019-06-25  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2254         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2255         can_highlight.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2260         make_visible_with_new_height method.
2261         (tui_win_info::make_visible_with_new_height): New method.
2262         (tui_source_window_base::do_make_visible_with_new_height)
2263         (tui_data_window::do_make_visible_with_new_height)
2264         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2265         (make_visible_with_new_height): Remove.
2266         (tui_resize_all, tui_adjust_win_heights): Use
2267         make_visible_with_new_height method.
2268         * tui/tui-data.h (struct tui_win_info)
2269         <do_make_visible_with_new_height, make_visible_with_new_height>:
2270         New methods.
2271         (struct tui_source_window_base, struct tui_data_window)
2272         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2273         methods.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2278         method.
2279         (update_tab_width): Call update_tab_width method.
2280         * tui/tui-data.h (struct tui_win_info)
2281         (struct tui_source_window_base) <update_tab_width>: New methods.
2282
2283 2019-06-25  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2286         parameter.
2287         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2288         parameter.
2289         (tui_gen_win_info::make_visible): Update.
2290         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2291         parameter.
2292         * tui/tui-data.h (enum tui_box): New enum.
2293         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2294
2295 2019-06-25  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2298         init_and_make_win for EXEC_INFO_WIN.
2299         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2300         longer inline.
2301         (struct tui_win_info) <~tui_win_info>: Inline.
2302         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2303         Don't declare.
2304         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2305         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2306         Remove.
2307         (tui_initialize_static_data): Update.
2308         (~tui_gen_win_info): Handle more cleanup here.
2309         (~tui_source_window_base): Delete "execution_info".
2310         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2311
2312 2019-06-25  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-layout.c (make_command_window): Don't set
2315         can_highlight.
2316         (show_source_disasm_command): Call the reset method.
2317         (show_data): Don't set can_highlight.  Call the reset method.
2318         (tui_gen_win_info::reset): Rename from init_gen_win_info
2319         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2320         (show_source_or_disasm_and_command): Call the reset method.
2321         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2322         (struct tui_cmd_window): Set can_highlight.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2327         from make_visible.
2328         (tui_make_visible, tui_make_invisible): Rewrite.
2329         (tui_win_info::make_visible): Remove.
2330         (tui_source_window_base::make_visible): Update.
2331         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2332         method.  Moved from...
2333         (struct tui_win_info) <make_visible>: ...here.
2334
2335 2019-06-25  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-winsource.c
2338         (tui_source_window_base::do_scroll_horizontal): Remove direction
2339         parameter.
2340         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2341         direction parameter.
2342         * tui/tui-win.c (tui_win_info::forward_scroll)
2343         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2344         (tui_win_info::right_scroll): Update.
2345         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2346         direction parameter.
2347         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2348         direction parameter.
2349         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2350         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2351         Remove direction parameter.
2352         (struct tui_source_window_base, struct tui_source_window)
2353         (struct tui_disasm_window, struct tui_data_window)
2354         (struct tui_cmd_window): Update.
2355
2356 2019-06-25  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-winsource.h (tui_set_exec_info_content)
2359         (tui_show_exec_info_content, tui_erase_exec_info_content)
2360         (tui_clear_exec_info_content, tui_update_exec_info): Change
2361         argument to tui_source_window_base.
2362         * tui/tui-winsource.c (tui_set_exec_info_content)
2363         (tui_show_exec_info_content, tui_erase_exec_info_content)
2364         (tui_clear_exec_info_content, tui_update_exec_info): Change
2365         argument to tui_source_window_base.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2370         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2375         check.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2380         type to void.
2381         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2382         type to void.
2383         * tui/tui-source.c (tui_set_source_content): Update.
2384         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2385
2386 2019-06-25  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-win.c (window_name_completer, tui_set_focus)
2389         (tui_all_windows_info): Use name method.
2390         * tui/tui-data.h (struct tui_gen_win_info)
2391         (struct tui_source_window, struct tui_disasm_window)
2392         (struct tui_data_window, struct tui_cmd_window) <name>: New
2393         method.
2394         (tui_win_name): Don't declare.
2395         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2396         (tui_win_name): Remove.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-winsource.h (tui_update_source_window)
2401         (tui_update_source_window_as_is): Change parameter type.
2402         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2403         to be a tui_source_window_base.
2404         (tui_update_source_window_as_is): Likewise.
2405         * tui/tui-win.c (make_visible_with_new_height): Update.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-winsource.c (tui_erase_source_content)
2410         (tui_show_source_content, tui_show_exec_info_content)
2411         (tui_erase_exec_info_content): Use refresh_window method.
2412         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2413         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2414         from tui_refresh_win.
2415         (tui_data_window::refresh_window): New method.
2416         (tui_win_info::refresh, tui_source_window_base::refresh)
2417         (tui_refresh_all): Use refresh_window method.
2418         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2419         method.
2420         * tui/tui-regs.c (tui_display_register): Call refresh_window
2421         method.
2422         * tui/tui-layout.c (show_source_disasm_command)
2423         (show_source_or_disasm_and_command): Call refresh_window method.
2424         * tui/tui-data.h (struct tui_gen_win_info)
2425         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2426         New method.
2427
2428 2019-06-25  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui.c (tui_rl_other_window, tui_enable)
2431         (tui_is_window_visible, tui_get_command_dimension): Update.
2432         * tui/tui-winsource.c (tui_update_source_window_as_is)
2433         (tui_clear_source_content, tui_erase_source_content)
2434         (tui_show_source_line, tui_source_window_base::refill)
2435         (tui_source_window_base::do_scroll_horizontal)
2436         (tui_source_window_base::set_is_exec_point_at)
2437         (tui_update_breakpoint_info, tui_set_exec_info_content)
2438         (tui_alloc_source_buffer, tui_line_is_displayed)
2439         (tui_addr_is_displayed): Update.
2440         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2441         (tui_check_and_display_highlight_if_needed)
2442         (tui_win_info::make_visible, tui_win_info::refresh)
2443         (tui_refresh_all): Update.
2444         * tui/tui-windata.c (tui_first_data_item_displayed)
2445         (tui_delete_data_content_windows, tui_erase_data_content)
2446         (tui_display_all_data, tui_data_window::refresh_all)
2447         (tui_check_data_values): Update.
2448         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2449         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2450         (tui_win_info::backward_scroll, tui_refresh_all_win)
2451         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2452         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2453         (tui_source_window_base::set_new_height)
2454         (tui_data_window::set_new_height)
2455         (make_invisible_and_set_new_height)
2456         (make_visible_with_new_height, new_height_ok)
2457         (parse_scrolling_args): Update.
2458         * tui/tui-stack.c (tui_show_frame_info): Update.
2459         * tui/tui-source.c (tui_set_source_content)
2460         (tui_set_source_content_nil, tui_source_is_displayed)
2461         (tui_source_window::do_scroll_vertical): Update.
2462         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2463         (tui_display_registers_from, tui_display_reg_element_at_line)
2464         (tui_check_register_values, tui_reg_command): Update.
2465         * tui/tui-layout.c (tui_default_win_height)
2466         (show_source_disasm_command, show_data, init_and_make_win)
2467         (show_source_or_disasm_and_command): Update.
2468         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2469         (tui_redisplay_readline, tui_mld_flush)
2470         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2471         (tui_getc): Update.
2472         * tui/tui-disasm.c (tui_set_disassem_content)
2473         (tui_disasm_window::do_scroll_vertical): Update.
2474         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2475         Now virtual.
2476         (struct tui_win_info): Derive from tui_gen_win_info.
2477         <~tui_win_info>: Mark as override.
2478         <generic>: Remove member.
2479         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2480         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2481         (~tui_data_window, ~tui_win_info)
2482         (tui_free_all_source_wins_content): Update.
2483         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2484
2485 2019-06-25  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-layout.c (init_and_make_win): Use new.
2488         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2489         destructor, initializers.
2490         (tui_alloc_generic_win_info): Don't declare.
2491         * tui/tui-data.c (_locator): Add argument to constructor.
2492         (source_win, disasm_win): New globals.
2493         (exec_info): Remove.
2494         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2495         Update.
2496         (tui_alloc_generic_win_info): Remove.
2497         (init_content_element): Use new.
2498         (tui_win_info::tui_win_info): Update.
2499         (free_content_elements) <case DATA_WIN>: Use delete.
2500
2501 2019-06-25  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2504         * tui/tui-windata.c (tui_first_data_item_displayed)
2505         (tui_delete_data_content_windows): Update.
2506         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2507         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2508         (tui_display_registers_from, tui_check_register_values): Update.
2509         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2510         pointer.
2511         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2512         window.
2513         (tui_free_data_content): Update.
2514         (free_content_elements) <case DATA_WIN>: Free the window.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2519         Update.
2520         * tui/tui-layout.c (make_command_window)
2521         (show_source_disasm_command, show_data, init_and_make_win)
2522         (show_source_or_disasm_and_command): Update.
2523         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2524         method.
2525         <can_highight, is_highlighted>: Now bool.
2526         (tui_set_win_highlight): Don't declare.
2527         * tui/tui-data.c (tui_set_win_highlight): Remove.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-wingeneral.c (make_visible): Remove check of window
2532         type.
2533
2534 2019-06-25  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-win.c (tui_win_info::max_height)
2537         (tui_cmd_window::max_height): New methods.
2538         (new_height_ok): Call max_height.
2539         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2540         <max_height>: New method.
2541
2542 2019-06-25  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-win.c (tui_source_window_base::set_new_height)
2545         (tui_data_window::set_new_height): New methods.
2546         (make_invisible_and_set_new_height): Call set_new_height method.
2547         * tui/tui-data.h (struct tui_win_info)
2548         (struct tui_source_window_base, struct tui_data_window)
2549         <set_new_height>: New method.
2550
2551 2019-06-25  Tom Tromey  <tom@tromey.com>
2552
2553         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2554         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2555         tui_refresh_data_win.
2556         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2557         method.
2558         (tui_refresh_all_win): Call the refresh_all method.
2559         (tui_set_focus): Likewise.
2560         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2561         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2562         Likewise.
2563
2564 2019-06-25  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-winsource.h (tui_refill_source_window)
2567         (tui_set_is_exec_point_at): Don't declare.
2568         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2569         (tui_source_window_base::refill): Rename from
2570         tui_refill_source_window.
2571         (tui_source_window_base::do_scroll_horizontal): Update.
2572         (tui_source_window_base::set_is_exec_point_at): Rename from
2573         tui_set_is_exec_point_at.
2574         (tui_update_all_breakpoint_info): Update.
2575         * tui/tui-stack.c (tui_show_frame_info): Update.
2576         * tui/tui-layout.c (show_data): Add cast.
2577         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2578         * tui/tui-data.h (struct tui_source_window_base) <refill,
2579         set_is_exec_point_at>: New methods.
2580         (tui_source_windows, tui_add_to_source_windows): Update types.
2581         (tui_add_to_source_windows): Remove redundant declaration.
2582         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2583         (tui_source_windows): Change return type.
2584         (tui_clear_source_windows_detail): Update.
2585         (tui_add_to_source_windows): Change type of parameter.
2586         (tui_free_all_source_wins_content): Update.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-wingeneral.c (tui_win_info::refresh)
2591         (tui_source_window_base::refresh): New methods.
2592         (tui_refresh_all): Call the refresh method.
2593         * tui/tui-data.h (struct tui_win_info)
2594         (struct tui_source_window_base) <refresh>: New method.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui.h (tui_is_window_visible): Return bool.
2599         * tui/tui.c (tui_is_window_visible): Return bool.
2600         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2601         (tui_make_visible, tui_make_invisible)
2602         (tui_win_info::make_visible)
2603         (tui_source_window_base::make_visible, make_all_visible)
2604         (tui_make_all_visible, tui_make_all_invisible): Update.
2605         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2606         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2607         bool.
2608         (struct tui_win_info, struct tui_source_window_base)
2609         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2610         * tui/tui-data.c (tui_init_generic_part): Update.
2611
2612 2019-06-25  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2615         (tui_source_window_base::make_visible): New methods.
2616         (make_all_visible): Make method call.
2617         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2618         (struct tui_source_window_base, struct tui_cmd_window): Override
2619         make_visible.
2620         (tui_win_is_source_type): Don't declare.
2621         * tui/tui-data.c (tui_win_is_source_type): Remove.
2622
2623 2019-06-25  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2626         NULL check.
2627
2628 2019-06-25  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2631         Inline constructor.  Add initializers for members.
2632         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2633         constructors; now inline in class.
2634
2635 2019-06-25  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-regs.c (tui_show_registers): Update.
2638         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2639         bool.
2640         * tui/tui-data.c (tui_data_window::clear_detail)
2641         (tui_data_window): Update.
2642
2643 2019-06-25  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-windata.c (tui_display_all_data)
2646         (tui_display_data_from_line, tui_display_data_from)
2647         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2648         Update.
2649         * tui/tui-regs.c (tui_last_regs_line_no)
2650         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2651         (tui_show_registers, tui_show_register_group)
2652         (tui_display_registers_from, tui_display_reg_element_at_line)
2653         (tui_display_registers_from_line, tui_check_register_values)
2654         (tui_reg_next, tui_reg_prev): Update.
2655         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2656         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2657         tui_data_window.
2658         (struct tui_win_info) <detail>: Remove.  Add new fields from
2659         tui_data_info.
2660         (TUI_DATA_WIN): Add cast.
2661         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2662         (~tui_data_window): Simplify.
2663
2664 2019-06-25  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-layout.c (show_source_disasm_command)
2667         (show_source_or_disasm_and_command): Update.
2668         * tui/tui-io.c (update_cmdwin_start_line)
2669         (tui_redisplay_readline): Update.
2670         * tui/tui-data.h (struct tui_command_info): Remove.
2671         (struct tui_win_info) <detail>: Remove command_info member.
2672         (struct tui_data_window) <start_line>: New member, from
2673         tui_command_info.
2674         (TUI_CMD_WIN): Add casts.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-winsource.c (tui_update_source_window)
2679         (tui_refill_source_window)
2680         (tui_source_window_base::do_scroll_horizontal)
2681         (tui_update_breakpoint_info, tui_set_exec_info_content)
2682         (tui_show_exec_info_content, tui_erase_exec_info_content)
2683         (tui_clear_exec_info_content): Update.
2684         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2685         Update.
2686         * tui/tui-win.c (make_invisible_and_set_new_height)
2687         (make_visible_with_new_height): Update.
2688         * tui/tui-source.c (tui_set_source_content)
2689         (tui_show_symtab_source): Update.
2690         * tui/tui-layout.c (extract_display_start_addr)
2691         (show_source_disasm_command, show_data)
2692         (make_source_or_disasm_window)
2693         (show_source_or_disasm_and_command): Update.
2694         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2695         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2696         "gdbarch".
2697         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2698         to tui_source_window_base.
2699         (struct tui_win_info) <detail>: Remove source_info member.
2700         (struct tui_source_window_base) <has_locator>: Inline.
2701         Move contents from tui_source_info; rename has_locator member to
2702         m_has_locator.
2703         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2704         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2705         header file.
2706         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2707         Simplify.
2708         (tui_free_all_source_wins_content): Cast to
2709         tui_source_window_base.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-win.c (make_invisible_and_set_new_height)
2714         (make_visible_with_new_height): Call has_locator method.
2715         * tui/tui-layout.c (show_source_disasm_command, show_data)
2716         (show_source_or_disasm_and_command): Update for bool change.
2717         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2718         (tui_win_info) <has_locator>: New method.
2719         (struct tui_source_window_base) <has_locator>: New method.
2720         (tui_win_has_locator): Don't declare.
2721         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2722         from tui_win_has_locator.
2723         (tui_source_window_base): Use false, not FALSE.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2728         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2729         clear_detail method directly.
2730         (tui_clear_win_detail): Remove.
2731
2732 2019-06-25  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2735         "this", not TUI_DISASM_WIN.
2736
2737 2019-06-25  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2740         declare.
2741         * tui/tui-winsource.c
2742         (tui_source_window_base::do_scroll_horizontal): Rename from
2743         tui_horizontal_source_scroll.
2744         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2745         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2746         from tui_vertical_data_scroll.
2747         * tui/tui-win.h (tui_scroll): Don't declare.
2748         * tui/tui-win.c (tui_win_info::forward_scroll)
2749         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2750         (tui_win_info::right_scroll): Rename and update.
2751         (tui_scroll_forward_command, tui_scroll_backward_command)
2752         (tui_scroll_left_command, tui_scroll_right_command): Update.
2753         (tui_scroll): Remove.
2754         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2755         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2756         from tui_vertical_source_scroll.
2757         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2758         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2759         from tui_vertical_disassem_scroll.
2760         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2761         do_scroll_horizontal>: New methods.
2762         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2763         Likewise.
2764         (struct tui_source_window_base): Add do_scroll_horizontal.
2765         (struct tui_source_window, struct tui_disasm_window): Add
2766         do_scroll_vertical.
2767         (struct tui_data_window, struct tui_cmd_window): Add
2768         do_scroll_horizontal and do_scroll_vertical.
2769         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2770
2771 2019-06-25  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui-data.h (struct tui_source_window_base): New struct.
2774         (struct tui_source_window): Derive from tui_source_window_base.
2775         (struct tui_disasm_window): New struct.
2776         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2777         from tui_source_window::clear_detail.
2778         (tui_source_window_base): Rename from tui_source_window.
2779         (~tui_source_window_base): Rename from ~tui_source_window.
2780         (tui_alloc_win_info): Create a tui_disasm_window.
2781
2782 2019-06-25  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-data.h (struct tui_source_window)
2785         (struct tui_data_window): Declare destructors.
2786         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2787         destructors.
2788         (tui_win_info): Simplify.
2789
2790 2019-06-25  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-winsource.c (tui_display_main)
2793         (tui_update_source_windows_with_addr)
2794         (tui_update_all_breakpoint_info): Update.
2795         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2796         (new_height_ok, parse_scrolling_args): Update.
2797         * tui/tui-stack.c (tui_show_frame_info): Update.
2798         * tui/tui-data.h (struct tui_list): Remove.
2799         (tui_source_windows): Return a reference to a std::vector.
2800         * tui/tui-data.c (source_windows): Now a std::vector.
2801         (tui_source_windows): Change return type.
2802         (tui_clear_source_windows): Rewrite.
2803         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2804         (tui_free_all_source_wins_content): Rewrite.
2805
2806 2019-06-25  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2809         (struct tui_data_window, struct tui_cmd_window): Declare
2810         clear_detail method.
2811         * tui/tui-data.c (tui_source_window::clear_detail)
2812         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2813         methods.
2814         (tui_clear_win_detail): Simplify.
2815
2816 2019-06-25  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-layout.c (make_source_window, make_disasm_window)
2819         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2820         Return the new window.
2821         (show_source_disasm_command, show_data)
2822         (show_source_or_disasm_and_command): Update.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2827         parameter.  Return the new window.
2828         (show_source_disasm_command): Update and remove NULL check.
2829         (show_source_or_disasm_and_command): Update.
2830
2831 2019-06-25  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2834
2835 2019-06-25  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-data.h (struct tui_win_info): Make constructor
2838         protected.  Make destructor virtual.  Add initializers.
2839         (tui_source_window, tui_data_window, tui_cmd_window): New
2840         classes.
2841         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2842         constructor.  Add "type" parameter.
2843         (tui_source_window, tui_data_window, tui_cmd_window): New
2844         constructors.
2845         (tui_alloc_win_info): Instantiate the appropriate subclass.
2846
2847 2019-06-25  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui-win.c (tui_resize_all): Use delete.
2850         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2851         destructor.
2852         (tui_free_window): Don't declare.
2853         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2854         Update.
2855
2856 2019-06-25  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui-data.h (struct tui_win_info): Add constructor.
2859         * tui/tui-data.c (tui_alloc_win_info): Use new.
2860         (tui_free_window): Use delete.
2861
2862 2019-06-22  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2865         declare.
2866         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2867
2868 2019-06-22  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2871         declare.
2872         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2873
2874 2019-06-22  Tom de Vries  <tdevries@suse.de>
2875
2876         * dwarf2read.c (create_addrmap_from_aranges)
2877         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2878         instead of '%zu'.
2879
2880 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2881
2882         * dwarf2read.h (dwarf2_section_info_def): Remove.
2883         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2884         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2885         std::vector<dwarf2_section_info>.
2886         (struct dwo_file) <~dwo_file>: Remove.
2887         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2888         types field.
2889         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2890         (dwarf2_read_debug_names): Likewise.
2891         (create_debug_types_hash_table): Change parameter type to
2892         array_view, adjust code accordingly.
2893         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2894         (partial_die_info::fixup): Likewise.
2895         (determine_prefix): Likewise.
2896         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2897
2898 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2899
2900         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2901         gdb_bfd_ref_ptr.
2902         <~dwo_file>: Remove call to gdb_bfd_unref.
2903         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2904         gdb_bfd_ref_ptr::get.
2905
2906 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2907
2908         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2909         type to htab_up.
2910         * dwarf2read.c (struct dwo_file): Initialize fields.
2911         <~dwo_file>: New.
2912         (free_dwo_file): Remove, move content to ~dwo_file.
2913         (struct dwo_file_deleter): Remove.
2914         (dwo_file_up>: Remove custom deleter.
2915         (free_dwo_files): Remove.
2916         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2917         dwo_files.
2918         (process_skeletonless_type_units): Call unique_ptr::get.
2919         (allocate_dwo_file_hash_table): Add deleter to created hash
2920         table.  Change return type to htab_up.
2921         (lookup_dwo_file_slot): Don't memset dwo_file, call
2922         unique_ptr::get.
2923         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2924         (create_dwo_unit_in_dwp_v2): Likewise.
2925         (open_and_init_dwo_file): Likewise.
2926         (free_dwo_file_from_slot): Remove.
2927
2928 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2929
2930         * dwarf2read.h (struct dwarf2_section_info) <readin,
2931         is_virtual>: Change type to bool.
2932         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2933         true instead of 1.
2934
2935 2019-06-19  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-data.h (tui_init_content_element): Don't declare.
2938
2939 2019-06-19  Tom Tromey  <tom@tromey.com>
2940
2941         * tui/tui-data.h (tui_init_win_info): Don't declare.
2942
2943 2019-06-19  Tom de Vries  <tdevries@suse.de>
2944
2945         * dwarf2read.h (abstract_to_concrete): Change type to
2946         std::unordered_map<sect_offset, std::vector<sect_offset>,
2947         gdb::hash_enum<sect_offset>>.
2948
2949 2019-06-19  Tom Tromey  <tromey@adacore.com>
2950
2951         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2952         EVAL_AVOID_SIDE_EFFECTS specially.
2953
2954 2019-06-19  Tom Tromey  <tromey@adacore.com>
2955
2956         * source-cache.c (highlighter): New global.
2957         (source_cache::get_source_lines): Create a highlighter on demand.
2958
2959 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2960
2961         * defs.h (deprecated_interactive_hook): Delete declaration.
2962         * interps.c (clear_interpreter_hooks): Remove use of
2963         deprecated_interactive_hook.
2964         * top.c (deprecated_interactive_hook): Delete definition.
2965         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2966
2967 2019-06-18  Tom de Vries  <tdevries@suse.de>
2968
2969         PR gdb/24515
2970         * dwarf2read.h (abstract_to_concrete): Change type from
2971         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2972         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2973         * dwarf2read.c (read_variable): Update.
2974         (dwarf2_fetch_die_loc_sect_off): Update.
2975
2976 2019-06-17  Tom de Vries  <tdevries@suse.de>
2977
2978         PR gdb/24617
2979         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2980         accessing parent[parent_len - 1].
2981
2982 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2983
2984         PR gdb/24364
2985         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2986         call dtrace_process_dof with NULL dof.
2987
2988 2019-06-16  Tom de Vries  <tdevries@suse.de>
2989
2990         PR gdb/24445
2991         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2992
2993 2019-06-16  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2996         (make_all_visible): Use address of member.
2997
2998 2019-06-16  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3001         (tui_free_window, free_content, free_content_elements): Remove
3002         unnecessary cast.
3003         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3004         cast.
3005         * tui/tui-regs.c (tui_show_register_group)
3006         (tui_display_registers_from, tui_display_reg_element_at_line):
3007         Remove unnecessary cast.
3008
3009 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3010
3011         * linux-nat.c (normal_mask): Delete.
3012         (_initialize_linux_nat): Don't initialise normal_mask.
3013
3014 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3015
3016         PR gdb/24445
3017         * dwarf-index-write.h (write_psymtabs_to_index): Add
3018         dwz_basename parameter.
3019         * dwarf-index-write.c (write_gdbindex): Move file writing to
3020         write_gdbindex_1.  Change return type void.
3021         (assert_file_size): Move up, remove filename parameter.
3022         (write_gdbindex_1): New function.
3023         (write_debug_names): Change return type to void, call
3024         assert_file_size.
3025         (struct index_wip_file): New struct.
3026         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3027         file logic to index_wip_file.  Write index for dwz file if
3028         needed.
3029         (save_gdb_index_command): Pass basename of dwz file, if present.
3030         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3031         build-id of dwz file, if present.
3032         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3033         (dwarf2_get_dwz_file): Likewise.
3034         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3035         (dwarf2_get_dwz_file): Likewise.
3036
3037 2019-06-16  Tom Tromey  <tom@tromey.com>
3038
3039         * coffread.c (process_coff_symbol): Use xstrdup.
3040         * value.c (create_internalvar): Use xstrdup.
3041
3042 2019-06-16  Tom Tromey  <tom@tromey.com>
3043
3044         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3045         * breakpoint.c (stopin_command, stopat_command)
3046         (until_break_command, decode_location_default): Remove unnecessary
3047         cast.
3048         * utils.c (subset_compare): Remove unnecessary cast.
3049         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3050         cast.
3051         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3052         cast.
3053         * infcmd.c (path_command): Remove unnecessary cast.
3054         * coffread.c (decode_type): Remove unnecessary cast.
3055         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3056         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3057         * tui/tui-stack.c (tui_show_locator_content)
3058         (tui_show_frame_info): Remove unnecessary cast.
3059         * tui/tui-win.c (tui_scroll_forward_command)
3060         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3061         (parse_scrolling_args): Remove unnecessary cast.
3062         * tui/tui-data.c (init_win_info, tui_del_window)
3063         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3064         (free_content_elements): Remove unnecessary cast.
3065         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3066         unnecessary cast.
3067         * tui/tui-source.c (tui_set_source_content)
3068         (tui_vertical_source_scroll): Remove unnecessary cast.
3069         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3070         cast.
3071         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3072         * tui/tui-regs.c (tui_display_registers_from)
3073         (tui_display_register): Remove unnecessary cast.
3074         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3075         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3076         (make_visible): Remove unnecessary cast.
3077         * tui/tui-winsource.c (tui_erase_source_content)
3078         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3079         unnecessary cast.
3080         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3081         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3082         * stabsread.c (read_type, read_array_type, read_range_type):
3083         Remove unnecessary cast.
3084         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3085         (parse_symbol, parse_type, upgrade_type, parse_external)
3086         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3087         unnecessary cast.
3088         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3089
3090 2019-06-16  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-data.c (tui_alloc_generic_win_info)
3093         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3094         checks.
3095
3096 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3097             Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * f-typeprint.c (f_print_type): Don't return early for not
3100         associated or not allocated types.
3101         (f_type_print_varspec_suffix): Add print_rank parameter and print
3102         ranks of array types in case they dangling.
3103         (f_type_print_base): Add print_rank parameter.
3104
3105 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * NEWS: Mention new MI commands.
3108         * break-catch-throw.c (enum exception_event_kind): Move to
3109         breakpoint.h.
3110         (print_mention_exception_catchpoint): Output text as a single
3111         message.
3112         (catch_exception_command_1): Rename to...
3113         (catch_exception_event): ...this, make non-static, update header
3114         command, and change some parameter types.
3115         (catch_catch_command): Update for changes to
3116         catch_exception_command_1.
3117         (catch_throw_command): Likewise.
3118         (catch_rethrow_command): Likewise.
3119         * breakpoint.c (enum exception_event_kind): Delete.
3120         * breakpoint.h (enum exception_event_kind): Moved here from
3121         break-catch-throw.c.
3122         (catch_exception_event): Declare.
3123         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3124         (mi_cmd_catch_throw): New function.
3125         (mi_cmd_catch_rethrow): New function.
3126         (mi_cmd_catch_catch): New function.
3127         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3128         'catch-catch' entries.
3129         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3130         (mi_cmd_catch_rethrow): Declare.
3131         (mi_cmd_catch_catch): Declare.
3132
3133 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * annotate.c (annotate_source_line): Change return type to void,
3136         update implementation to match.
3137         * annotate.h (annotate_source_line): Change return type to void,
3138         update header comment.
3139         * stack.c (print_frame_info): Don't change what frame information
3140         is printed based on whether annotations are on or not.
3141
3142 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3145         (annotate_source): Make static.
3146         (annotate_source_line): Moved from source.c and renamed from
3147         identify_source_line.  Update the return type.
3148         * annotate.h (annotate_source): Delete declaration.
3149         (annotate_source_line): Declaration moved from source.h, and
3150         renamed from identify_source_line.  Return type updated.
3151         * source.c (identify_source_line): Moved to annotate.c and renamed
3152         to annotate_source_line.
3153         (info_line_command): Remove check of annotation_level.
3154         * source.h (identify_source_line): Move declaration to annotate.h
3155         and rename to annotate_source_line.
3156         * stack.c: Add 'annotate.h' include.
3157         (print_frame_info): Remove check of annotation_level before
3158         calling annotate_source_line.
3159
3160 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * source-cache.c (source_cache::get_plain_source_lines): Use
3163         open_source_file_with_line_charpos instead of just
3164         open_source_file, remove call to find_source_lines.
3165         (source_cache::get_source_lines): Likewise.
3166         * source.c (find_source_lines): Make static.
3167         (get_filename_and_charpos): Renamed into...
3168         (open_source_file_with_line_charpos): ..this along with changes to
3169         return a scoped_fd, and some other minor clean ups.
3170         (identify_source_line): Use open_source_file_with_line_charpos.
3171         (search_command_helper): Use open_source_file_with_line_charpos
3172         instead of just open_source_file, remove call to
3173         find_source_lines.
3174         * source.h (open_source_file_with_line_charpos): Declare new
3175         function.
3176         (find_source_lines): Delete declaration.
3177
3178 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * source.c (get_filename_and_charpos): Remove fullname
3181         parameter.
3182         (identify_source_line): Update call to get_filename_and_charpos.
3183
3184 2019-06-14  Tom Tromey  <tromey@adacore.com>
3185
3186         PR gdb/24502:
3187         * ui-style.h (skip_ansi_escape): Update comment.
3188         * ui-file.h (class no_terminal_escape_file): New class.
3189         * ui-file.c (no_terminal_escape_file::write)
3190         (no_terminal_escape_file::puts): New methods.
3191         * cli/cli-logging.c (handle_redirections): Use
3192         no_terminal_escape_file.
3193
3194 2019-06-14  Tom Tromey  <tromey@adacore.com>
3195
3196         * NEWS: Move convenience variable news above Python news.
3197
3198 2019-06-14  Tom Tromey  <tom@tromey.com>
3199
3200         * gnulib: Move directory to top-level.
3201         * configure.ac: Don't configure gnulib.
3202         * configure: Rebuild.
3203         * common/common-defs.h: Use new path to gnulib.
3204         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3205         (GNULIB_H): Remove.
3206         (INCGNU): Look in new gnulib location.
3207         (HFILES_NO_SRCDIR): Remove gnulib files.
3208         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3209         (generated_files): Remove GNULIB_H.
3210         ($(LIBGNU), all-lib): Remove targets.
3211         (distclean): Don't mention GNULIB_BUILDDIR.
3212         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3213
3214 2019-06-14  Tom Tromey  <tromey@adacore.com>
3215
3216         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3217         Warn if symbol file does not provide any symbols.
3218
3219 2019-06-14  Tom Tromey  <tromey@adacore.com>
3220
3221         * source.c (find_and_open_source): Respect basenames_may_differ.
3222
3223 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3224
3225         * annotate.c (annotate_breakpoints_invalid): Make use of
3226         scoped_restore_terminal_state.
3227         (annotate_frames_invalid): Likewise.
3228
3229 2019-06-14  Tom Tromey  <tromey@adacore.com>
3230
3231         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3232         allow assignment to an internalvar.
3233
3234 2019-06-14  Tom Tromey  <tromey@adacore.com>
3235
3236         * ada-lex.l: Allow "_" in attribute names.
3237
3238 2019-06-14  Tom Tromey  <tromey@adacore.com>
3239
3240         PR gdb/24653:
3241         * regcache.c (registers_changed): Don't call alloca.
3242         * top.c (execute_command): Don't call alloca.
3243
3244 2019-06-13  Pedro Alves  <palves@redhat.com>
3245
3246         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3247         'expression'.  When parsing an expression, error out if there's
3248         junk after "unlimited".
3249         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3250         (do_set_command): Adjust calls to is_unlimited_literal.
3251
3252 2019-06-13  Pedro Alves  <palves@redhat.com>
3253
3254         * compile/compile.c (make_compile_options_def_group): Add braces
3255         around array_view initializer.
3256         * thread.c (make_thread_apply_all_options_def_group)
3257         (make_thread_apply_all_options_def_group): Likewise.
3258
3259 2019-06-13  Pedro Alves  <palves@redhat.com>
3260
3261         * NEWS (New commands): Mention "maint test-options
3262         require-delimiter", "maint test-options unknown-is-error", "maint
3263         test-options unknown-is-operand" and "maint show
3264         test-options-completion-result".
3265         (New command options, command completion): New section.
3266         (Completion improvements): New section.
3267         Mention that you can abbreviate "unlimited".
3268
3269 2019-06-13  Pedro Alves  <palves@redhat.com>
3270
3271         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3272         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3273         * unittests/cli-utils-selftests.c (test_parse_flags)
3274         (test_parse_flags_qcs): Delete.
3275         (test_cli_utils): Don't call deleted functions.
3276
3277 2019-06-13  Pedro Alves  <palves@redhat.com>
3278
3279         * thread.c: Include "cli/cli-option.h".
3280         (tp_array_compar_ascending): Global.
3281         (tp_array_compar): Delete function.
3282         (tp_array_compar_ascending, tp_array_compar_descending): New
3283         functions.
3284         (ascending_option_def, qcs_flag_option_def)
3285         (thr_qcs_flags_option_defs)
3286         (make_thread_apply_all_options_def_group)
3287         (make_thread_apply_options_def_group): New.
3288         (thread_apply_all_command): Use gdb::option::process_options.
3289         (thread_apply_command_completer)
3290         (thread_apply_all_command_completer): New.
3291         (thread_apply_command): Use gdb::option::process_options.
3292         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3293         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3294         to generate help text of "thread apply".  Adjust "taas"'s help.
3295         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3296         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3297
3298 2019-06-13  Pedro Alves  <palves@redhat.com>
3299
3300         * thread.c (thread_apply_command): Check for invalid TID with
3301         isdigit instead of !isalpha.
3302
3303 2019-06-13  Pedro Alves  <palves@redhat.com>
3304
3305         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3306         (validate_flags_qcs): New.
3307         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3308         (validate_flags_qcs): Declare.
3309         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3310         (make_frame_apply_options_def_group): New.
3311         (frame_apply_command_count): Process options with
3312         gdb::option::process_options.
3313         (frame_apply_completer): New.
3314         (frame_apply_level_completer, frame_apply_all_completer)
3315         (frame_apply_completer): New.
3316         (_initialize_stack): Update help of "frame apply", "frame apply
3317         level", "frame apply all" and "faas" to mention supported options
3318         and install command completers.
3319         * stack.h (frame_apply_all_completer): Declare.
3320         * thread.c: Include "stack.h".
3321         (tfaas_command): Add "--".
3322         (_initialize_thread): Update help "tfaas" to mention supported
3323         options and install command completer.
3324
3325 2019-06-13  Pedro Alves  <palves@redhat.com>
3326
3327         * completer.c (complete_nested_command_line): New.
3328         (gdb_completion_word_break_characters_throw): Add assertion.
3329         * completer.h (complete_nested_command_line): Declare.
3330
3331 2019-06-13  Pedro Alves  <palves@redhat.com>
3332
3333         * stack.c (parse_backtrace_qualifiers): New.
3334         (backtrace_command): Use it.
3335         (backtrace_command_completer): Complete on qualifiers.
3336
3337 2019-06-13  Pedro Alves  <palves@redhat.com>
3338
3339         * frame.c: Include "cli/cli-option.h.
3340         (user_set_backtrace_options): New.
3341         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3342         Delete.
3343         (get_prev_frame): Adjust.
3344         (boolean_option_def, uinteger_option_def)
3345         (set_backtrace_option_defs): New.
3346         (_initialize_frame): Adjust and use
3347         gdb::option::add_setshow_cmds_for_options to install "set
3348         backtrace past-main" and "set backtrace past-entry".
3349         * frame.h: Include "cli/cli-option.h".
3350         (struct frame_print_options): Forward declare.
3351         (print_frame_arguments_all, print_frame_arguments_scalars)
3352         (print_frame_arguments_none): Declare.
3353         (print_entry_values): Delete declaration.
3354         (struct frame_print_options, user_frame_print_options): New.
3355         (struct set_backtrace_options): New.
3356         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3357         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3358         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3359         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3360         (list_args_or_locals): Add frame_print_options parameter.
3361         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3362         * python/py-framefilter.c (enumerate_args): Pass down
3363         USER_FRAME_PRINT_OPTIONS.
3364         * stack.c: Include "cli/cli-option.h".
3365         (print_frame_arguments_all, print_frame_arguments_scalars)
3366         (print_frame_arguments_none): Declare.
3367         (print_raw_frame_arguments, print_entry_values): Delete.
3368         (user_frame_print_options): New.
3369         (boolean_option_def, enum_option_def, frame_print_option_defs):
3370         New.
3371         (struct backtrace_cmd_options): New.
3372         (bt_flag_option_def): New.
3373         (backtrace_command_option_defs): New.
3374         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3375         (print_frame_arg, read_frame_arg, print_frame_args)
3376         (print_frame_info, print_frame): Add frame_print_options parameter
3377         and use it.
3378         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3379         (backtrace_command_1): Add frame_print_options and
3380         backtrace_cmd_options parameters and use them.
3381         (make_backtrace_options_def_group): New.
3382         (backtrace_command): Process command options with
3383         gdb::option::process_options.
3384         (backtrace_command_completer): New.
3385         (_initialize_stack): Extend "backtrace"'s help to mention
3386         supported options.  Install completer for "backtrace".
3387         Install some settings commands with add_setshow_cmds_for_options.
3388
3389 2019-06-13  Pedro Alves  <palves@redhat.com>
3390
3391         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3392         and that "set/show print raw frame-arguments" are now deprecated.
3393
3394         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3395         command.
3396         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3397         * stack.c (_initialize_stack): Install "set/show print
3398         raw-frame-arguments", and deprecate "set/show print raw
3399         frame-arguments".
3400         * valprint.c (_initialize_valprint): Deprecate "set/show print
3401         raw".
3402
3403 2019-06-13  Pedro Alves  <palves@redhat.com>
3404
3405         * compile/compile.c (struct compile_options): New.
3406         (compile_flag_option_def, compile_command_option_defs)
3407         (make_compile_options_def_group): New.
3408         (compile_file_command): Handle options with
3409         gdb::option::process_options.
3410         (compile_file_command_completer): New function.
3411         (compile_code_command): Handle options with
3412         gdb::option::process_options.
3413         (compile_code_command_completer): New function.
3414         (_initialize_compiler): Install completers for "compile code" and
3415         "compile file".  Mention available options in "compile code" and
3416         "compile code"'s help.
3417         * completer.c (advance_to_completion_word): New, factored out from
3418         ...
3419         (advance_to_expression_complete_word_point): ... this.
3420         (advance_to_filename_complete_word_point): New.
3421         * completer.h (advance_to_filename_complete_word_point): New
3422         declaration.
3423
3424 2019-06-13  Pedro Alves  <palves@redhat.com>
3425
3426         * compile/compile.c: Include "cli/cli-option.h".
3427         (compile_print_value): Scope data pointer is now a
3428         value_print_options pointer; adjust.
3429         (compile_print_command): Process options.  Scope data pointer is
3430         now a value_print_options pointer; adjust.
3431         (_initialize_compile): Update "compile print"'s help to include
3432         supported options.  Install a completer for "compile print".
3433         * cp-valprint.c (show_vtblprint, show_objectprint)
3434         (show_static_field_print): Delete.
3435         (_initialize_cp_valprint): Don't install "set print
3436         static-members", "set print vtbl", "set print object" here.
3437         * printcmd.c: Include "cli/cli-option.h" and
3438         "common/gdb_optional.h".
3439         (print_command_parse_format): Rework to fill in a
3440         value_print_options instead of a format_data.
3441         (print_value): Change parameter type from format_data pointer to
3442         value_print_options reference.  Adjust.
3443         (print_command_1): Process options.  Adjust to pass down a
3444         value_print_options.
3445         (print_command_completer): New.
3446         (_initialize_printcmd): Install print_command_completer as
3447         handle_brkchars completer for the "print" command.  Update
3448         "print"'s help to include supported options.
3449         * valprint.c: Include "cli/cli-option.h".
3450         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3451         here from cp-valprint.c.
3452         (boolean_option_def, uinteger_option_def)
3453         (value_print_option_defs, make_value_print_options_def_group):
3454         New.  Use gdb::option::add_setshow_cmds_for_options to install
3455         "set print elements", "set print null-stop", "set print repeats",
3456         "set print pretty", "set print union", "set print array", "set
3457         print address", "set print symbol", "set print array-indexes".
3458         * valprint.h: Include <string> and "cli/cli-option.h".
3459         (make_value_print_options_def_group): Declare.
3460         (print_value): Change parameter type from format_data pointer to
3461         value_print_options reference.
3462         (print_command_completer): Declare.
3463
3464 2019-06-13  Pedro Alves  <palves@redhat.com>
3465
3466         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3467         (COMMON_SFILES): Add maint-test-settings.c.
3468         * cli/cli-decode.c (boolean_enums): New global, factored out from
3469         ...
3470         (add_setshow_boolean_cmd): ... here.
3471         * cli/cli-decode.h (boolean_enums): Declare.
3472         * cli/cli-option.c: New file.
3473         * cli/cli-option.h: New file.
3474         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3475         factored out from ...
3476         (parse_cli_boolean_value(const char *)): ... this.
3477         (is_unlimited_literal): Change parameter type to pointer to
3478         pointer.  Adjust and advance ARG pointer.
3479         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3480         (parse_cli_var_enum): New, factored out from ...
3481         (do_set_command): ... this.  Adjust.
3482         * cli/cli-setshow.h (parse_cli_boolean_value)
3483         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3484         (parse_cli_var_enum): Declare.
3485         * cli/cli-utils.c: Include "cli/cli-option.h".
3486         (get_ulongest): New.
3487         * cli/cli-utils.h (get_ulongest): Declare.
3488         (check_for_argument): New overloads.
3489         * maint-test-options.c: New file.
3490
3491 2019-06-13  Pedro Alves  <palves@redhat.com>
3492
3493         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3494         parse a range if "-" is at the end of the string.
3495
3496 2019-06-13  Pedro Alves  <palves@redhat.com>
3497
3498         * cli/cli-setshow.c (parse_auto_binary_operation)
3499         (parse_cli_boolean_value): Don't allow "o".
3500
3501 2019-06-13  Pedro Alves  <palves@redhat.com>
3502
3503         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3504         * NEWS: Mention maint test-settings KIND.
3505         * maint-test-settings.c: New file.
3506
3507 2019-06-13  Pedro Alves  <palves@redhat.com>
3508
3509         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3510         completer.
3511         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3512         "set" completers.
3513
3514 2019-06-13  Pedro Alves  <palves@redhat.com>
3515
3516         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3517         after item.
3518
3519 2019-06-13  Pedro Alves  <palves@redhat.com>
3520
3521         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3522
3523 2019-06-13  Pedro Alves <palves@redhat.com>
3524
3525         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3526         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3527         call.
3528         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3529         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3530         calls.
3531         (check_for_argument): Skip spaces after argument.
3532
3533 2019-06-13  Pedro Alves  <palves@redhat.com>
3534
3535         * thread.c (thread_apply_command): Adjust TID parsing.
3536         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3537         detected before end of string.
3538         (tid_is_in_list): Error out if LIST is invalid.
3539
3540 2019-06-13  Pedro Alves  <palves@redhat.com>
3541
3542         * completer.c (complete_line_internal_1): Rewind completion word
3543         point.
3544         (completion_tracker::advance_custom_word_point_by): Change
3545         parameter type to int.
3546         * completer.h (completion_tracker::advance_custom_word_point_by):
3547         Likewise.
3548
3549 2019-06-13  Pedro Alves  <palves@redhat.com>
3550
3551         * completer.c (advance_to_completion_word): Handle delimiters.
3552
3553 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3554
3555         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3556
3557 2019-06-11  Tom Tromey  <tom@tromey.com>
3558
3559         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3560         (xmalloc_failed): Move to alloc.c.
3561         * alloc.c: New file.
3562         * Makefile.in (COMMON_SFILES): Add alloc.c.
3563
3564 2019-06-11  Tom Tromey  <tom@tromey.com>
3565
3566         * nat/linux-waitpid.c: Don't include server.h.
3567         (linux_debug): Remove.
3568         (my_waitpid): Update.
3569
3570 2019-06-11  Tom Tromey  <tromey@adacore.com>
3571
3572         * infcall.c (_initialize_infcall): Remove trailing newline from
3573         help.
3574         * user-regs.c (_initialize_user_regs): Remove trailing newline
3575         from help.
3576         * typeprint.c (_initialize_typeprint): Remove trailing newline
3577         from help.
3578         * reverse.c (_initialize_reverse): Remove trailing newlines from
3579         help.
3580         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3581         from help.
3582         * language.c (add_set_language_command): Remove trailing newline
3583         from help.
3584         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3585         help.
3586         * disasm.c (_initialize_disasm): Remove trailing newline from
3587         help.
3588         * top.c (init_main): Remove trailing newline from help.
3589         * interps.c (_initialize_interpreter): Remove trailing newline
3590         from help.
3591         * btrace.c (_initialize_btrace): Remove trailing newlines from
3592         help.
3593         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3594         from help.
3595         * python/python.c (_initialize_python): Remove trailing newline
3596         from help.
3597         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3598         help.
3599         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3600         from help.  Reformat some text.
3601         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3602         from help.
3603         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3604         newline from help.
3605
3606 2019-06-11  Tom Tromey  <tromey@adacore.com>
3607
3608         * darwin-nat.c (darwin_decode_exception_message)
3609         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3610
3611 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3612
3613         * valops.c (value_slice): Check for not allocated or not
3614         associated values.
3615
3616 2019-06-10  Tom de Vries  <tdevries@suse.de>
3617
3618         PR gdb/24618
3619         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3620         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3621         invalid.
3622
3623 2019-06-10  Tom de Vries  <tdevries@suse.de>
3624
3625         PR gdb/24611
3626         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3627         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3628
3629 2019-06-10  Tom de Vries  <tdevries@suse.de>
3630
3631         PR symtab/24545
3632         * symtab.c (struct demangled_name_entry): Add language field.
3633         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3634         static minimal symbol".  Set and use language field.
3635
3636 2019-06-10  Tom Tromey  <tromey@adacore.com>
3637
3638         * ada-lang.c (_initialize_ada_language): Update help text.
3639
3640 2019-06-10  Tom Tromey  <tromey@adacore.com>
3641
3642         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3643         with a newline.
3644         * guile/guile.c (handle_boot_error): Don't end warning with a
3645         newline.
3646         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3647         warning with a newline.
3648         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3649         newline.
3650         (s12z_frame_cache): Likewise.
3651         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3652         a newline.
3653         * solib-svr4.c (disable_probes_interface): Don't end warning with
3654         a newline.
3655         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3656         newline.
3657         * python/python.c (do_finish_initialization): Don't end warning
3658         with a newline.
3659
3660 2019-06-10  Tom Tromey  <tom@tromey.com>
3661
3662         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3663         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3664         gdbpy_enter.
3665
3666 2019-06-10  Tom Tromey  <tromey@adacore.com>
3667
3668         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3669         data.
3670         (elf_new_init): Don't call stabsread_new_init.
3671         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3672         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3673         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3674
3675 2019-06-10  Tom de Vries  <tdevries@suse.de>
3676
3677         PR symtab/16264
3678         PR symtab/24517
3679         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3680
3681 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3682
3683         * source.c (find_and_open_source): Also rewrite relative file
3684         names.
3685
3686 2019-04-26  Amos Bird  <amosbird@gmail.com>
3687
3688         * annotate.c (annotate_thread_exited): Add "thread-exited"
3689         annotation.
3690
3691 2019-06-06  Tom Tromey  <tromey@adacore.com>
3692
3693         * maint.h (class scoped_command_stats): Use
3694         DISABLE_COPY_AND_ASSIGN.
3695         <print_time>: New method.
3696         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3697         print_time.
3698         (scoped_command_stats::print_time): New method.
3699
3700 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3703         instructions of lengths 6 or 8 bytes.
3704
3705 2019-06-04  Pedro Alves  <palves@redhat.com>
3706
3707         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3708
3709         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3710         * breakpoint.c (condition_completer): Likewise.
3711         * cli/cli-dump.c (scan_expression): Likewise.
3712         * common/filestuff.c (mkdir_recursive): Likewise.
3713         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3714         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3715         (gdb_abspath): Likewise.
3716         * compile/compile-cplus-types.c
3717         (compile_cplus_instance::decl_name): Likewise.
3718         * completer.c (complete_explicit_location):
3719         (signal_completer, reg_or_group_completer_1): Likewise.
3720         * cp-support.c (cp_remove_params_if_any): Likewise.
3721         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3722         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3723         * infcmd.c (strip_bg_char): Likewise.
3724         * linespec.c (copy_token_string): Likewise.
3725         * mi/mi-main.c (output_cores): Likewise.
3726         * psymtab.c (psymtab_search_name):
3727         * symfile.c (test_set_ext_lang_command): Likewise.
3728         * target.c (target_fileio_read_stralloc): Likewise.
3729         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3730         * value.c (complete_internalvar): Likewise.
3731
3732 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3733
3734         Add objfile property to gdb.Type.
3735         * NEWS: Mention Python API addition.
3736         * python/py-type.c (typy_get_objfile): New method.
3737
3738 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3739
3740         * NEWS: Mention the new set|show style [title|highlight].
3741         Mention changes to "show style", "help" and "apropos".
3742
3743 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3744
3745         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3746         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3747         instead of print_help_for_command.
3748         (print_doc_of_command): New function.
3749         (help_list): Add 'apropos -v word' suggestion.
3750         (print_help_for_command): Style the command name using title style.
3751         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3752         (_initialize_cli_cmds): Describe -v in apropos_command help.
3753
3754 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3755
3756         * cli/cli-style.h (cli_style_option): Add name in constructor,
3757         add m_name class member, add constructor with intensity,
3758         add name class function.
3759         (cli_style_option::add_setshow_commands): Remove name argument.
3760         (highlight_style, title_style): New styles.
3761         * cli/cli-style.c (do_show): New function that shows a style
3762         characteristic styling the style name with itself.
3763         (set_style_name): New function.
3764         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3765         Update all callers according to the changes in cli/cli-style.h.
3766         * utils.h (fputs_highlighted): New function.
3767         * utils.c (fputs_highlighted): Likewise.
3768
3769 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3770
3771         * NEWS: Mention new pipe command and new convenience variables.
3772
3773 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3774
3775         * cli/cli-cmds.c (pipe_command): New function.
3776         (_initialize_cli_cmds): Call add_com for pipe_command.
3777         Define | as an alias for pipe.
3778         (exit_status_set_internal_vars): New function.
3779         (shell_escape): Call exit_status_set_internal_vars.
3780         cli/cli-decode.c (find_command_name_length): Recognize | as
3781         a single character command.
3782
3783 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3784
3785         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3786         top.c (execute_command_to_ui_file): New function, mostly a copy
3787         of execute_command_to_string.
3788         (execute_command_to_string): Implement by calling
3789         execute_command_to_ui_file.
3790
3791 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3792
3793         * top.h (saved_command_line): Remove declaration.
3794         * top.c (previous_saved_command_line, previous_repeat_arguments):
3795         New variables.
3796         (saved_command_line): Make static, define together with other
3797         'repeat variables'.
3798         (dont_repeat): Clear repeat_arguments.
3799         (repeat_previous, get_saved_command_line, save_command_line):
3800         New functions.
3801         (gdb_init): Initialize saved_command_line
3802         and previous_saved_command_line.
3803         * main.c (captured_main_1): Remove saved_command_line initialization.
3804         * event-top.c (handle_line_of_input): Update to use
3805         the new 'repeat' related functions instead of direct access to
3806         saved_command_line.
3807         * command.h (repeat_previous, get_saved_command_line,
3808         save_command_line): New declarations.
3809         (dont_repeat): Add comment.
3810
3811 2019-05-30  Tom Tromey  <tromey@adacore.com>
3812
3813         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3814         Fix comment.
3815         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3816
3817 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3818
3819         PR cli/24587
3820         * completer.c (complete): Initialize variable word.
3821
3822 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3823
3824         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3825         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3826         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3827         'body' is NULL to the outter 'if', protecting the '!is_define'
3828         situation as well.
3829
3830 2019-05-29  Tom Tromey  <tromey@adacore.com>
3831
3832         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3833         (dwarf_unknown): New function.
3834         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3835         (dwarf_type_encoding_name): Use dwarf_unknown.
3836
3837 2019-05-29  Tom Tromey  <tromey@adacore.com>
3838
3839         PR c++/20020:
3840         * cp-valprint.c (cp_print_value_fields): Call
3841         cp_print_static_field inside "try".
3842
3843 2019-05-29  Tom Tromey  <tromey@adacore.com>
3844
3845         * inflow.c (struct terminal_info): Add default operator=.
3846         * configure: Rebuild.
3847         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3848         -Wdeprecated-copy-dtor, -Wredundant-move.
3849
3850 2019-05-29  Tom Tromey  <tromey@adacore.com>
3851
3852         * NEWS: Add entry.
3853         * infcmd.c (print_return_value_1): Handle finish_print
3854         option.
3855         (show_print_finish): New function.
3856         (_initialize_infcmd): Add "set/show print finish" commands.
3857         * valprint.c (user_print_options): Initialize new member.
3858         * valprint.h (struct value_print_options) <finish_print>: New
3859         member.
3860
3861 2019-05-28  Tom Tromey  <tromey@adacore.com>
3862
3863         * ada-lang.c (ada_remove_Xbn_suffix)
3864         (find_old_style_renaming_symbol)
3865         (parse_old_style_renaming): Remove.
3866         (ada_find_renaming_symbol): Don't call
3867         find_old_style_renaming_symbol.
3868         (ada_is_renaming_symbol): Rename from
3869         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3870         bool.  Now static.
3871         (ada_read_var_value): Update and simplify.
3872         * ada-exp.y (write_var_or_type): Remove old code.
3873
3874 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3875
3876         * event-top.c: Remove include comment.
3877         * inflow.c (class scoped_ignore_sigttou): Move from here...
3878         * inflow.h (class scoped_ignore_sigttou): ...to here.
3879         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3880         * top.c:  Remove include comment.
3881
3882 2019-05-27  Tom Tromey  <tom@tromey.com>
3883
3884         * NEWS: Fix typo.
3885
3886 2019-05-22  Tom Tromey  <tromey@adacore.com>
3887
3888         * target.c (target_follow_exec): Constify parameter.
3889         * target-delegates.c: Rebuild.
3890         * remote.c (remote_target::follow_exec): Constify parameter.
3891         * infrun.c (follow_exec): Constify parameter.
3892         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3893         (target_follow_exec): Likewise.
3894
3895 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3896
3897         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3898         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3899
3900 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3901
3902         * NEWS: Add debugredirect and testsuite sections.
3903
3904 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3905
3906         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3907         target descriptions using exclusively floating point register name
3908         aliases.
3909
3910 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         PR gdb/18644:
3913         * f-lang.c (build_fortran_types): Handle the case where
3914         gdbarch_floatformat_for_type returns a nullptr.
3915
3916 2019-05-21  Tom de Vries  <tdevries@suse.de>
3917
3918         PR cli/24587
3919         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3920
3921 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         PR gdb/18644:
3924         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3925         16-byte floats.
3926         * i386-tdep.c (i386_floatformat_for_type): Use
3927         floatformats_ia64_quad for the 16-byte floating point component
3928         within a fortran 32-byte complex number.
3929
3930 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3933         delete default constructor.
3934         (find_partial_die): Update to return const struct.
3935         (partial_die_parent_scope): Move variable declaration into scope
3936         of its use and change its type to auto.
3937         (guess_partial_die_structure_name): Likewise.
3938         (partial_die_info::fixup): Likewise.
3939
3940 2019-05-17  Tom Tromey  <tromey@adacore.com>
3941
3942         * source.c (find_and_open_source): Remove cast.
3943
3944 2019-05-17  Tom Tromey  <tromey@adacore.com>
3945
3946         * annotate.c (annotate_source): Make "filename" const.
3947         * annotate.h (annotate_source): Use const.
3948
3949 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3950
3951         * disasm.c (set_disassembler_options): Send errors to stderr.
3952
3953 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3954
3955         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3956         (cli_interp_base::set_logging): Check debug_redirect.
3957         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3958         * cli/cli-logging.c (debug_redirect): Add static variable.
3959         (pop_output_files): Add default param.
3960         (handle_redirections): Print debug setting.
3961         (show_logging_command): Likewise.
3962         (_initialize_cli_logging): Add debugredirect command.
3963         * interps.c (current_interp_set_logging): Add debug_redirect
3964         parameter.
3965         * interps.h (set_logging): Add debug_redirect parameter.
3966         (current_interp_set_logging): Likewise.
3967         * mi/mi-common.h: Likewise.
3968         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3969
3970 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3971             Tom Tromey  <tromey@adacore.com>
3972
3973         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3974         directly.
3975         * cli/cli-interp.h (make_logging_output): Remove declaration.
3976         * cli/cli-logging.c (make_logging_output): Remove function.
3977         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3978         directly.
3979         * ui-file.c (tee_file::tee_file): Remove bools.
3980         (tee_file::~tee_file): Remove deletes.
3981         * ui-file.h (tee_file): Remove bools.
3982
3983 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3984
3985         * mi/mi-cmds.h (mi_cmd_complete): New function.
3986         * mi/mi-main.c (mi_cmd_complete): Likewise.
3987         * mi/mi-cmds.c: Define new MI command -complete.
3988         * NEWS: Mention new -complete command.
3989
3990 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3991
3992         * completer.h (complete): New function.
3993         * completer.c (complete): Likewise.
3994         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3995         function defined in completer.h.
3996
3997 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3998
3999         * MAINTAINERS (Write After Approval): Add myself.
4000
4001 2019-05-17  Tom de Vries  <tdevries@suse.de>
4002
4003         PR gdb/24094
4004         * dwarf2read.c (struct cu_partial_die_info): New struct.
4005         (find_partial_die): Return cu_partial_die_info.
4006         (partial_die_parent_scope, guess_partial_die_structure_name)
4007         (partial_die_info::fixup): Handle new return type of find_partial_die.
4008
4009 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4010
4011         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4012         "std::string", simplifying the algorithm.
4013
4014 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4015
4016         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4017         (stap_static_probe_ops::get_probes): Likewise.
4018
4019 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4020
4021         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4022         '-')" and "else if".
4023         (stap_parse_single_operand): Join checks for
4024         "gdbarch_stap_parse_special_token_p" and
4025         "gdbarch_stap_parse_special_token" in the same "if" statement.
4026         Invert check when verifying for operation on register
4027         displacement.
4028
4029 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4030
4031         * stap-probe.c (stap_get_opcode): Update comment.
4032         (stap_get_expected_argument_type): Likewise.
4033         (handle_stap_probe): Likewise.
4034
4035 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4036
4037         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4038         return type to 'bool'.  Adjust comment.  Use 'bool' when
4039         appropriate.
4040         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4041         * stap-probe.c (stap_parse_argument_1): Likewise.
4042         (stap_is_operator): Likewise.
4043         (stap_is_generic_prefix): Likewise.
4044         (stap_is_register_prefix): Likewise.
4045         (stap_is_register_indirection_prefix): Likewise.
4046         (stap_is_integer_prefix): Likewise.
4047         (stap_generic_check_suffix): Likewise.
4048         (stap_check_integer_suffix): Likewise.
4049         (stap_check_register_suffix): Likewise.
4050         (stap_check_register_indirection_suffix): Likewise.
4051         (stap_parse_register_operand): Likewise.
4052         (stap_parse_single_operand): Likewise.
4053         (stap_parse_argument_1): Likewise.
4054         (stap_probe::get_argument_count): Likewise.
4055         (stap_is_operator): Likewise.
4056
4057 2019-05-16  Tom Tromey  <tromey@adacore.com>
4058
4059         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4060         keyword to foreach.
4061
4062 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4063
4064         * linux-thread-db.c (try_thread_db_load_1): Change return type
4065         to bool.
4066         (try_thread_db_load): Likewise.
4067         (try_thread_db_load_from_pdir_1): Likewise.
4068         (try_thread_db_load_from_pdir): Likewise.
4069         (try_thread_db_load_from_sdir): Likewise.
4070         (try_thread_db_load_from_dir): Likewise.
4071         (thread_db_load_search): Likewise.
4072         (has_libpthread): Likewise.
4073         (thread_db_load): Likewise.
4074
4075 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4076
4077         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4078         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4079         NULL, and complain/return if that's the case.
4080
4081 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4082
4083         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4084         (advance, posn, abstract_read_memory): New functions.
4085         [struct mem_read_abstraction]: New struct.
4086         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4087
4088 2019-05-14  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4091         value is not lval_memory.
4092
4093 2019-05-14  Tom Tromey  <tromey@adacore.com>
4094
4095         * solib.c (info_sharedlibrary_command): Style the file name.
4096
4097 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4098
4099         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4100         (aarch64_vnv_type): Likewise.
4101         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4102         * common/tdesc.c: Likewise.
4103         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4104         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4105         * features/aarch64-fpu.xml: Add ieee half view.
4106         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4107         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4108         * gdbtypes.h (struct builtin_type): Likewise.
4109         (struct objfile_type): Likewise.
4110
4111 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4112
4113         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4114         typo.
4115         * location.h (string_to_event_location): Likewise.
4116
4117 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4118
4119         GDB 8.3 released.
4120
4121 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4122
4123         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4124         New variable declaration.
4125         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4126         New variable.
4127         (print_one_breakpoint): Use ui_out::test_flags and new global
4128         variable to compute use_fixed_output.
4129         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4130         Remove.
4131         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4132         (mi_multi_location_breakpoint_output_fixed): Remove.
4133         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4134         new variable.
4135         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4136         fix_multi_location_breakpoint_output flag if version >= 3.
4137         * ui-out.h (enum ui_out_flag)
4138         <fix_multi_location_breakpoint_output>: New enumerator.
4139
4140 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4141
4142         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4143
4144 2019-05-10  Tom Tromey  <tromey@adacore.com>
4145
4146         * ada-lang.c (catch_ada_completer): New function.
4147         (_initialize_ada_language): Use it.
4148
4149 2019-05-10  Tom Tromey  <tromey@adacore.com>
4150
4151         * thread.c (print_thread_info): Make "requested_threads" const.
4152         * gdbthread.h (print_thread_info): Make "requested_threads"
4153         const.
4154         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4155         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4156
4157 2019-05-08  Tom Tromey  <tom@tromey.com>
4158
4159         * gdbtypes.c (objfile_type_data): Change type.
4160         (objfile_type, _initialize_gdbtypes): Update.
4161
4162 2019-05-08  Tom Tromey  <tom@tromey.com>
4163
4164         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4165         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4166         (_initialize_dwarf2_frame): Update.
4167
4168 2019-05-08  Tom Tromey  <tom@tromey.com>
4169
4170         * objc-lang.c (objc_objfile_data): Change type.
4171         (find_methods): Update.
4172         (_initialize_objc_lang): Remove.
4173
4174 2019-05-08  Tom Tromey  <tom@tromey.com>
4175
4176         * stabsread.c (rs6000_builtin_type_data): Change type.
4177         (rs6000_builtin_type, _initialize_stabsread): Update.
4178
4179 2019-05-08  Tom Tromey  <tom@tromey.com>
4180
4181         * mips-tdep.c (mips_pdr_data): Remove.
4182         (_initialize_mips_tdep): Update.
4183
4184 2019-05-08  Tom Tromey  <tom@tromey.com>
4185
4186         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4187         (hppa_init_objfile_priv_data, read_unwind_info)
4188         (find_unwind_entry, _initialize_hppa_tdep): Update.
4189
4190 2019-05-08  Tom Tromey  <tom@tromey.com>
4191
4192         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4193         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4194         on obstack.
4195         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4196
4197 2019-05-08  Tom Tromey  <tom@tromey.com>
4198
4199         * mdebugread.c (basic_type_data): Change type.
4200         (basic_type, _initialize_mdebugread): Update.
4201
4202 2019-05-08  Tom Tromey  <tom@tromey.com>
4203
4204         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4205
4206 2019-05-08  Tom Tromey  <tom@tromey.com>
4207
4208         * nto-tdep.c (nto_inferior_data_reg): Change type.
4209         (nto_inferior_data): Update.
4210         (nto_inferior_data_cleanup, nto_new_inferior_data)
4211         (_initialize_nto_tdep): Remove.
4212         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4213
4214 2019-05-08  Tom Tromey  <tom@tromey.com>
4215
4216         * ada-lang.c (struct ada_inferior_data): Add initializers.
4217         (ada_inferior_data): Change type.
4218         (ada_inferior_data_cleanup): Remove.
4219         (get_ada_inferior_data, ada_inferior_exit)
4220         (struct ada_pspace_data): Add initializers, destructor.
4221         (ada_pspace_data_handle): Change type.
4222         (get_ada_pspace_data): Update.
4223         (ada_pspace_data_cleanup): Remove.
4224
4225 2019-05-08  Tom Tromey  <tom@tromey.com>
4226
4227         * coffread.c (struct coff_symfile_info): Add initializers.
4228         (coff_objfile_data_key): Move lower.  Change type.
4229         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4230         Update.
4231         (coff_free_info): Remove.
4232
4233 2019-05-08  Tom Tromey  <tom@tromey.com>
4234
4235         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4236         (fbsd_pspace_data_handle): Move lower.  Change type.
4237         (get_fbsd_pspace_data): Update.
4238         (fbsd_pspace_data_cleanup): Remove.
4239         (_initialize_fbsd_tdep): Update.
4240
4241 2019-05-08  Tom Tromey  <tom@tromey.com>
4242
4243         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4244         (get_ada_tasks_pspace_data): Update.
4245         (ada_tasks_pspace_data_cleanup): Remove.
4246         (_initialize_tasks): Update.
4247         (ada_tasks_inferior_data_handle): Change type.
4248         (get_ada_tasks_inferior_data): Update.
4249         (ada_tasks_inferior_data_cleanup): Remove.
4250         (struct ada_tasks_pspace_data): Add initializers.
4251
4252 2019-05-08  Tom Tromey  <tom@tromey.com>
4253
4254         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4255         * symfile-debug.c (debug_sym_get_probes): Change type.
4256         * stap-probe.c (handle_stap_probe):
4257         (stap_static_probe_ops::get_probes): Change type.
4258         * probe.h (class static_probe_ops) <get_probes>: Change type.
4259         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4260         (parse_probes_in_pspace): Update.
4261         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4262         Update.
4263         (any_static_probe_ops::get_probes): Change type.
4264         * elfread.c (elfread_data): New typedef.
4265         (probe_key): Change type.
4266         (elf_get_probes): Likewise.  Update.
4267         (probe_key_free): Remove.
4268         (_initialize_elfread): Update.
4269         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4270         Change type.
4271         (dtrace_process_dof_probe, dtrace_process_dof)
4272         (dtrace_static_probe_ops::get_probe): Change type.
4273
4274 2019-05-08  Tom Tromey  <tom@tromey.com>
4275
4276         * xcoffread.c (struct xcoff_symfile_info): Rename from
4277         coff_symfile_info.  Add initializers.
4278         (xcoff_objfile_data_key): Move lower.  Change type.
4279         (XCOFF_DATA): Rewrite.
4280         (xcoff_free_info): Remove.
4281         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4282         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4283         (xcoff_initial_scan): Update.
4284
4285 2019-05-08  Tom Tromey  <tom@tromey.com>
4286
4287         * solib-svr4.c (struct svr4_info): Add initializers and
4288         destructor.
4289         <probes_table>: Now an htab_up.
4290         (solib_svr4_pspace_data): Change type.
4291         (free_probes_table): Simplify.
4292         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4293         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4294         (probes_table_remove_objfile_probes, register_solib_event_probe)
4295         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4296         (_initialize_svr4_solib): Update.
4297
4298 2019-05-08  Tom Tromey  <tom@tromey.com>
4299
4300         * remote.c (remote_pspace_data): Change type.
4301         (remote_pspace_data_cleanup): Remove.
4302         (get_remote_exec_file, set_pspace_remote_exec_file)
4303         (_initialize_remote): Update.
4304
4305 2019-05-08  Tom Tromey  <tom@tromey.com>
4306
4307         * breakpoint.c (breakpoint_objfile_key): Change type.
4308         (get_breakpoint_objfile_data): Update.
4309         (free_breakpoint_objfile_data): Remove.
4310         (_initialize_breakpoint): Update.
4311
4312 2019-05-08  Tom Tromey  <tom@tromey.com>
4313
4314         * linux-tdep.c (struct linux_info): Add initializers.
4315         (linux_inferior_data): Move.  Change type.
4316         (invalidate_linux_cache_inf): Update.
4317         (linux_inferior_data_cleanup): Remove.
4318         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4319
4320 2019-05-08  Tom Tromey  <tom@tromey.com>
4321
4322         * auxv.c (auxv_inferior_data): Move.  Change type.
4323         (auxv_inferior_data_cleanup): Remove.
4324         (invalidate_auxv_cache_inf): Rewrite.
4325         (get_auxv_inferior_data, _initialize_auxv): Update.
4326
4327 2019-05-08  Tom Tromey  <tom@tromey.com>
4328
4329         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4330         (symfile_debug_objfile_data_key): Change type.
4331         (symfile_debug_installed, debug_qf_has_symbols)
4332         (debug_qf_find_last_source_symtab)
4333         (debug_qf_forget_cached_source_info)
4334         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4335         (debug_qf_print_stats, debug_qf_dump)
4336         (debug_qf_expand_symtabs_for_function)
4337         (debug_qf_expand_all_symtabs)
4338         (debug_qf_expand_symtabs_with_fullname)
4339         (debug_qf_map_matching_symbols)
4340         (debug_qf_expand_symtabs_matching)
4341         (debug_qf_find_pc_sect_compunit_symtab)
4342         (debug_qf_map_symbol_filenames)
4343         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4344         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4345         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4346         (debug_sym_read_linetable, debug_sym_relocate): Update.
4347         (symfile_debug_free_objfile): Remove.
4348         (install_symfile_debug_logging, _initialize_symfile_debug):
4349         Update.
4350
4351 2019-05-08  Tom Tromey  <tom@tromey.com>
4352
4353         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4354         allocate_on_obstack.
4355         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4356         (get_dwarf2_per_objfile): Update.
4357         (set_dwarf2_per_objfile): Remove.
4358         (dwarf2_has_info, dwarf2_get_section_info): Update.
4359         (dwarf2_free_objfile): Remove.
4360         (_initialize_dwarf2_read): Update.
4361
4362 2019-05-08  Tom Tromey  <tom@tromey.com>
4363
4364         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4365         initializers.
4366         <unsupported_script_warning_printed,
4367         script_not_found_warning_printed>: Now bool.
4368         (auto_load_pspace_data): Change type.
4369         (~auto_load_pspace_info): Rename from
4370         auto_load_pspace_data_cleanup.
4371         (get_auto_load_pspace_data, init_loaded_scripts_info)
4372         (clear_section_scripts, maybe_print_unsupported_script_warning)
4373         (maybe_print_script_not_found_warning, _initialize_auto_load):
4374         Update.
4375
4376 2019-05-08  Tom Tromey  <tom@tromey.com>
4377
4378         * objfiles.c (objfile_pspace_info): Add destructor and
4379         initializers.
4380         (objfiles_pspace_data): Change type.
4381         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4382         (get_objfile_pspace_data): Update.
4383         (objfiles_bfd_data): Change type.
4384         (get_objfile_bfd_data): Update.
4385         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4386
4387 2019-05-08  Tom Tromey  <tom@tromey.com>
4388
4389         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4390         Change type.
4391         (get_catch_syscall_inferior_data): Update.
4392         (catch_syscall_inferior_data_cleanup): Remove.
4393         (_initialize_break_catch_syscall): Update.
4394
4395 2019-05-08  Tom Tromey  <tom@tromey.com>
4396
4397         * inflow.c (struct terminal_info): Add destructor and
4398         initializers.
4399         (inflow_inferior_data): Change type.
4400         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4401         (get_inflow_inferior_data, inflow_inferior_exit)
4402         (swap_terminal_info, _initialize_inflow): Update.
4403
4404 2019-05-08  Tom Tromey  <tom@tromey.com>
4405
4406         * target-dcache.c (target_dcache_cleanup): Remove.
4407         (target_dcache_aspace_key): Change type.
4408         (target_dcache_init_p, target_dcache_invalidate)
4409         (target_dcache_get, target_dcache_get_or_init)
4410         (_initialize_target_dcache): Update.
4411         * dcache.h (struct dcache_deleter): New.
4412
4413 2019-05-08  Tom Tromey  <tom@tromey.com>
4414
4415         * symtab.c (struct symbol_cache): Add destructor and
4416         initializers.
4417         (symbol_cache_key): Move.  Change type.
4418         (make_symbol_cache, free_symbol_cache): Remove.
4419         (get_symbol_cache): Update.
4420         (symbol_cache_cleanup): Remove.
4421         (ALL_PSPACES, symbol_cache_flush)
4422         (maintenance_print_symbol_cache)
4423         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4424         Update.
4425
4426 2019-05-08  Tom Tromey  <tom@tromey.com>
4427
4428         * symtab.c (struct main_info): Add destructor and initializers.
4429         (main_progspace_key): Move.  Change type.
4430         (get_main_info): Update.
4431         (main_info_cleanup): Remove.
4432         (_initialize_symtab): Update.
4433
4434 2019-05-08  Tom Tromey  <tom@tromey.com>
4435
4436         * registry.h (DECLARE_REGISTRY): Define the _key class.
4437
4438 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * NEWS: Merge two 'New commands' sections.
4441
4442 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4443
4444         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4445         parameter and use Ada language definition instead.
4446         (ada_val_print_ptr): Remove unused language parameter.
4447         (ada_val_print_num): Remove language parameter and use Ada language
4448         definition instead.
4449         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4450         parameter.
4451         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4452         parameter and use Ada language definition instead.
4453         (ada_val_print_1): Update all ada_val_print_xxx calls.
4454         Remove language parameter.
4455         (ada_val_print): Update ada_val_print_1 call.
4456
4457 2019-05-08  Tom Tromey  <tromey@adacore.com>
4458
4459         * remote.c (remote_hw_watchpoint_limit)
4460         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4461         Now static.
4462
4463 2019-05-08  Tom Tromey  <tromey@adacore.com>
4464
4465         * maint.c (_initialize_maint_cmds): Move initialization code to
4466         remote.c.
4467         (watchdog, show_watchdog): Move to remote.c.
4468         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4469         "watchdog" static.
4470         (_initialize_remote): Move initialization code from maint.c.
4471         * defs.h (watchdog): Don't declare.
4472
4473 2019-05-08  Tom Tromey  <tromey@adacore.com>
4474
4475         * tui/tui-interp.c: Include main.h.
4476         * interps.c: Include main.h.
4477         * main.h (interpreter_p): Declare.
4478         * defs.h (interpreter_p): Don't declare.
4479
4480 2019-05-08  Tom Tromey  <tromey@adacore.com>
4481
4482         * dwarf2loc.c: Include dwarf2read.h.
4483         * defs.h (read_unsigned_leb128): Don't declare.
4484         * dwarf2read.h (read_unsigned_leb128): Declare.
4485
4486 2019-05-08  Tom Tromey  <tromey@adacore.com>
4487
4488         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4489         method.
4490
4491 2019-05-08  Tom Tromey  <tromey@adacore.com>
4492
4493         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4494         when no wrap column is set.
4495
4496 2019-05-08  Tom Tromey  <tromey@adacore.com>
4497
4498         * c-lang.c (c_get_string): Handle non-C-style arrays.
4499
4500 2019-05-08  Tom Tromey  <tromey@adacore.com>
4501
4502         * typeprint.c (print_offset_data::update): Print the bit offset,
4503         not the number of bits remaining.
4504
4505 2019-05-08  Tom Tromey  <tromey@adacore.com>
4506
4507         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4508         padding at end of comment.
4509
4510 2019-05-08  Tom Tromey  <tromey@adacore.com>
4511
4512         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4513         Compare main types.
4514
4515 2019-05-06  Tom Tromey  <tom@tromey.com>
4516
4517         * common/scoped_mmap.c: Include common-defs.h.
4518         * common/scoped_mmap.h: Don't include config.h.
4519
4520 2019-05-04  Tom Tromey  <tom@tromey.com>
4521
4522         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4523         (struct aarch64_call_info): Add initializers.
4524         <si>: Now a std::vector.
4525         (pass_on_stack, aarch64_push_dummy_call): Update.
4526
4527 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4528             Tom Tromey  <tom@tromey.com>
4529
4530         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4531         (ppc_threads): Now a std::vector.  Now static.
4532         (hwdebug_find_thread_points_by_tid)
4533         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4534         Update.
4535
4536 2019-05-04  Tom Tromey  <tom@tromey.com>
4537
4538         * arc-tdep.c (arc_tdesc_init): Return bool.
4539
4540 2019-05-04  Tom Tromey  <tom@tromey.com>
4541
4542         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4543         Use gdb_assert_not_reached.
4544
4545 2019-05-04  Tom Tromey  <tom@tromey.com>
4546
4547         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4548         "false".
4549
4550 2019-05-04  Tom Tromey  <tom@tromey.com>
4551
4552         * arc-tdep.c (arc_tdesc_init): Use bool.
4553
4554 2019-05-04  Tom Tromey  <tom@tromey.com>
4555
4556         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4557
4558 2019-05-04  Tom Tromey  <tom@tromey.com>
4559
4560         * cli/cli-cmds.c (valid_command_p): Return bool.
4561
4562 2019-05-04  Tom Tromey  <tom@tromey.com>
4563
4564         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4565         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4566
4567 2019-05-04  Raul Tambre  <raul@tambre.ee>
4568
4569         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4570         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4571         operator for comparison.
4572
4573 2019-05-04  Tom Tromey  <tom@tromey.com>
4574
4575         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4576         (lookup_partial_symbol, print_partial_symbols)
4577         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4578         (psymbol_compare): Update.
4579         (add_psymbol_to_bcache): Clear the entire psymbol.
4580         (maintenance_check_psymtabs): Update.
4581         * psympriv.h (struct partial_symbol): Don't derive from
4582         general_symbol_info.
4583         <obj_section, unrelocated_address, address,
4584         set_unrelocated_address>: Update.
4585         <ginfo>: New member.
4586         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4587         (debug_names::write_psymbols): Update.
4588
4589 2019-05-04  Tom de Vries  <tdevries@suse.de>
4590
4591         * contrib/cc-with-tweaks.sh: Support -n arg.
4592
4593 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4594
4595         * corelow.c (core_target::detach): Ensure frame cache and
4596         register caches are cleared.
4597         inferior.c (exit_inferior_1): Likewise.
4598
4599 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4600             Tom Tromey  <tom@tromey.com>
4601
4602         * dictionary.c (collate_pending_symbols_by_language): Remove
4603         "struct" from foreach.
4604         * symtab.c (lookup_global_symbol_from_objfile)
4605         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4606         foreach.
4607         * ser-tcp.c (net_open): Remove "struct" from foreach.
4608         * objfiles.c (objfile_relocate, objfile_rebase)
4609         (objfile_has_symbols): Remove "struct" from foreach.
4610         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4611         from foreach.
4612         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4613         foreach.
4614         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4615         "struct" from foreach.
4616         * ada-lang.c (create_excep_cond_exprs)
4617         (ada_exception_catchpoint_cond_string): Remove "struct" from
4618         foreach.
4619
4620 2019-05-03  Tom Tromey  <tromey@adacore.com>
4621
4622         * ada-exp.y (convert_char_literal): Check suffix of each
4623         enumerator.
4624
4625 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4626
4627         PR ada/21406:
4628         * ada-exp.y (yywrap): Don't define.
4629         * ada-lex.l (%option): Add noyywrap
4630         (yywrap): Remove.
4631
4632 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4633
4634         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4635         _WIN32_WINNT to the XP level, unless already defined to a higher
4636         level.
4637
4638         * unittests/parse-connection-spec-selftests.c:
4639         * ser-tcp.c:
4640         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4641         override.
4642
4643         * symfile.c (find_separate_debug_file): Remove colon from the
4644         drive spec of DOS/Windows file names of the target, so that the
4645         file name produced from DEBUGDIR and the target's directory will
4646         be valid on DOS/Windows systems.
4647
4648 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4649
4650         * rust-lang.c (val_print_struct): Handle printing structures
4651         containing strings.
4652
4653 2019-05-02  Tom Tromey  <tromey@adacore.com>
4654
4655         * valarith.c (_initialize_valarith): Remove.
4656
4657 2019-05-01  Tom Tromey  <tromey@adacore.com>
4658
4659         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4660         bitfields.
4661
4662 2019-05-01  Tom Tromey  <tromey@adacore.com>
4663
4664         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4665         for big-endian copies.
4666
4667 2019-04-30  Ali Tamur  <tamur@google.com>
4668         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4669         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4670         (read_3_bytes): New function.
4671
4672 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4673
4674         * windows-nat.c (main_thread_id): Delete.
4675         (handle_output_debug_string): Replace main_thread_id by
4676         current_event.dwThreadId.
4677         (fake_create_process): Likewise.
4678         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4679         Do not set main_thread_id.
4680         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4681         current_event.dwThreadId.
4682         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4683
4684 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4685
4686         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4687         Use current_event.dwThreadId instead of main_thread_id.
4688
4689 2019-04-30  Tom Tromey  <tromey@adacore.com>
4690
4691         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4692         (create_excep_cond_exprs): Iterate over program spaces.
4693         (ada_exception_catchpoint_cond_string): Examine all minimal
4694         symbols for exception types.
4695
4696 2019-04-30  Tom Tromey  <tromey@adacore.com>
4697
4698         PR c++/24470:
4699         * dwarf2read.c (process_structure_scope): Handle case where type
4700         has template parameters but no symbol was created.
4701
4702 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4703             Chris January  <chris.january@arm.com>
4704
4705         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4706         qualifier.
4707         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4708
4709 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4710
4711         * f-typeprint.c (f_print_type): Update rules for printing
4712         whitespace.
4713         (f_type_print_varspec_suffix): Likewise.
4714
4715 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4716             Chris January  <chris.january@arm.com>
4717
4718         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4719         function arguments.
4720
4721 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * f-lang.c (build_fortran_types): Change name of void type to
4724         lower case.
4725         * f-typeprint.c (f_type_print_base): Print the name of the void
4726         type, rather than a fixed string.
4727         * f-valprint.c (f_decorations): Use lower case void string.
4728
4729 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4730             Chris January  <chris.january@arm.com>
4731
4732         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4733         types for Fortran.
4734
4735 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4736             Chris January  <chris.january@arm.com>
4737             David Lecomber  <david.lecomber@arm.com>
4738
4739         * f-exp.y (BINOP_INTRINSIC): New token.
4740         (exp): New parser rule handling BINOP_INTRINSIC.
4741         (f77_keywords): Add new builtin procedures.
4742         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4743         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4744         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4745         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4746         (print_unop_subexp_f): New function.
4747         (print_binop_subexp_f): New function.
4748         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4749         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4750         (dump_subexp_body_f): Likewise.
4751         (operator_check_f): Likewise.
4752         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4753         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4754
4755 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4758         UNOP_KIND.
4759         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4760         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4761         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4762         (operator_length_f): New fuction.
4763         (print_subexp_f): New function.
4764         (op_name_f): New function.
4765         (dump_subexp_body_f): New function.
4766         (operator_check_f): New function.
4767         (exp_descriptor_f): Replace standard expression handling functions
4768         with new functions.
4769         * gdb/fortran-operator.def: New file.
4770         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4771         * gdb/std-operator.def: Remove UNOP_KIND.
4772
4773 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * std-operator.def: Remove unbalanced, stray double quote
4776         character.
4777
4778 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4779             Chris January  <chris.january@arm.com>
4780             Daniel Everett  <daniel.everett@arm.com>
4781             Nick Forrington  <nick.forrington@arm.com>
4782             Richard Bunt  <richard.bunt@arm.com>
4783
4784         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4785         of depth when printing anonymous structs or unions.
4786         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4787         Don't print either the top-level value, or the children if the
4788         max-depth is exceeded.
4789         (ppscm_print_children): When printing the key of a map, allow one
4790         extra level of depth.
4791         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4792         print either the top-level value, or the children if the max-depth
4793         is exceeded.
4794         (print_children): When printing the key of a map, allow one extra
4795         level of depth.
4796         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4797         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4798         (user_print_options): Initialise max_depth field.
4799         (val_print_scalar_or_string_type_p): New function.
4800         (val_print): Check to see if the max depth has been reached.
4801         (val_print_check_max_depth): Define new function.
4802         (show_print_max_depth): New function.
4803         (_initialize_valprint): Add 'print max-depth' option.
4804         * valprint.h (struct value_print_options) <max_depth>: New field.
4805         (val_print_check_max_depth): Declare new function.
4806         * NEWS: Document new feature.
4807
4808 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * ada-lang.c (ada_language_defn): Initialise new field.
4811         * c-lang.c (c_is_string_type_p): New function.
4812         (c_language_defn): Initialise new field.
4813         (cplus_language_defn): Initialise new field.
4814         (asm_language_defn): Initialise new field.
4815         (minimal_language_defn): Initialise new field.
4816         * c-lang.h (c_is_string_type_p): Declare new function.
4817         * d-lang.c (d_language_defn): Initialise new field.
4818         * f-lang.c (f_is_string_type_p): New function.
4819         (f_language_defn): Initialise new field.
4820         * go-lang.c (go_is_string_type_p): New function.
4821         (go_language_defn): Initialise new field.
4822         * language.c (default_is_string_type_p): New function.
4823         (unknown_language_defn): Initialise new field.
4824         (auto_language_defn): Initialise new field.
4825         * language.h (struct language_defn) <la_is_string_type_p>: New
4826         member variable.
4827         (default_is_string_type_p): Declare new function.
4828         * m2-lang.c (m2_language_defn): Initialise new field.
4829         * objc-lang.c (objc_language_defn): Initialise new field.
4830         * opencl-lang.c (opencl_language_defn): Initialise new field.
4831         * p-lang.c (pascal_is_string_type_p): New function.
4832         (pascal_language_defn): Initialise new field.
4833         * rust-lang.c (rust_is_string_type_p): New function.
4834         (rust_language_defn): Initialise new field.
4835
4836 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4839         New field.
4840         * ada-lang.c (ada_language_defn): Initialise new field.
4841         * c-lang.c (c_language_defn): Likewise.
4842         (cplus_language_defn): Likewise.
4843         (asm_language_defn): Likewise.
4844         (minimal_language_defn): Likewise.
4845         * d-lang.c (d_language_defn): Likewise.
4846         * f-lang.c (f_language_defn): Likewise.
4847         * go-lang.c (go_language_defn): Likewise.
4848         * language.c (unknown_language_defn): Likewise.
4849         (auto_language_defn): Likewise.
4850         * m2-lang.c (m2_language_defn): Likewise.
4851         * objc-lang.c (objc_language_defn): Likewise.
4852         * opencl-lang.c (opencl_language_defn): Likewise.
4853         * p-lang.c (pascal_language_defn): Likewise.
4854         * rust-lang.c (rust_language_defn): Likewise.
4855
4856 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4857
4858         * ada-lang.c (ada_is_character_type): Change return type to bool.
4859         (ada_is_string_type): Likewise.
4860         * ada-lang.h (ada_is_character_type): Update declaration
4861         (ada_is_string_type): Likewise.
4862
4863 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4864
4865         Support style in 'frame|thread apply'
4866
4867         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4868         * record.c (record_start, record_stop): Update callers of
4869         execute_command_to_string with false.
4870         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4871         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4872         methods.
4873         (class string_file): New constructor with term_out parameter.
4874         Override methods term_out and can_emit_style_escape.  New member
4875         term_out.
4876         (class stdio_file): Override can_emit_style_escape.
4877         (class tee_file): Override term_out and can_emit_style_escape.
4878         * utils.h (can_emit_style_escape): Remove.
4879         * utils.c (can_emit_style_escape): Likewise.
4880         Update all callers of can_emit_style_escape (SOMESTREAM) to
4881         SOMESTREAM->can_emit_style_escape.
4882         * source-cache.c (source_cache::get_source_lines): Likewise.
4883         * stack.c (frame_apply_command_count): Call execute_command_to_string
4884         passing the term_out characteristic of the current gdb_stdout.
4885         * thread.c (thr_try_catch_cmd): Likewise.
4886         * top.c (execute_command_to_string): pass term_out parameter
4887         to construct the string_file for the command output.
4888         * ui-file.c (term_cli_styling): New function (most code moved
4889         from utils.c can_emit_style_escape).
4890         (string_file::string_file, string_file::can_emit_style_escape,
4891         stdio_file::can_emit_style_escape, tee_file::term_out,
4892         tee_file::can_emit_style_escape): New functions.
4893
4894 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4895
4896         * NEWS: Mention the new set|show may-call-functions.
4897         * infcall.c (may_call_functions_p): New variable.
4898         (show_may_call_functions_p): New function.
4899         (call_function_by_hand_dummy): Throws an error if not
4900         may-call-functions.
4901         (_initialize_infcall): Call add_setshow_boolean_cmd for
4902         may-call-functions.
4903
4904 2019-04-25  Keith Seitz  <keiths@redhat.com>
4905
4906         PR c++/24367
4907         * cp-support.c (inspect_type): Don't attempt substitutions
4908         of symbol with the same name.
4909
4910 2019-04-25  Tom Tromey  <tromey@adacore.com>
4911
4912         PR gdb/24475:
4913         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4914         static.
4915
4916 2019-04-25  Tom Tromey  <tromey@adacore.com>
4917
4918         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4919         rvalue reference.
4920         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4921         (gdb_xml_parser::parse): Use std::move.
4922         * python/python-internal.h (gdbpy_convert_exception): Take a const
4923         reference.
4924         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4925         std::move.
4926         * python/py-utils.c (gdbpy_convert_exception): Take a const
4927         reference.
4928         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4929         Use std::move.
4930         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4931         Use std::move.
4932         * mi/mi-main.c (mi_print_exception): Take a const reference.
4933         * main.c (handle_command_errors): Take a const reference.
4934         * linespec.c (parse_linespec): Use std::move.
4935         * infcall.c (run_inferior_call): Use std::move.
4936         (call_function_by_hand_dummy): Use std::move.
4937         * exec.c (try_open_exec_file): Use std::move.
4938         * exceptions.h (exception_print, exception_fprintf)
4939         (exception_print_same): Update.
4940         * exceptions.c (print_exception, exception_print)
4941         (exception_fprintf, exception_print_same): Change parameters to
4942         const reference.
4943         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4944         * common/new-op.c: Use std::move.
4945         * common/common-exceptions.h (struct gdb_exception): Add move
4946         constructor.
4947         (struct gdb_exception_error, struct gdb_exception_quit, struct
4948         gdb_quit_bad_alloc): Change constructor to move constructor.
4949         (throw_exception): Change parameter to rvalue reference.
4950         * common/common-exceptions.c (throw_exception): Take rvalue
4951         reference.
4952         * cli/cli-interp.c (safe_execute_command): Use std::move.
4953         * breakpoint.c (insert_bp_location, location_to_sals): Use
4954         std::move.
4955
4956 2019-04-25  Tom Tromey  <tromey@adacore.com>
4957
4958         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4959         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4960         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4961         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4962         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4963         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4964         guile/scm-value.c: Use unpack.
4965         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4966         gdbscm_gdb_exception.
4967         (gdbscm_throw_gdb_exception): Likewise.
4968         (struct gdbscm_gdb_exception): New.
4969         (unpack): New function.
4970         (gdbscm_wrap): Use unpack.
4971
4972 2019-04-25  Tom Tromey  <tromey@adacore.com>
4973
4974         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4975         (gdb_rl_callback_handler): Use std::move.
4976         * common/common-exceptions.h (struct gdb_exception): Add move
4977         assignment operator.
4978         (throw_exception_sjlj): Change "exception" to const reference.
4979         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4980         (throw_exception_sjlj): Change "exception" to const reference.
4981
4982 2019-04-25  Tom Tromey  <tromey@adacore.com>
4983
4984         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4985         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4986         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4987         Update.
4988         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4989         Update.
4990         * mi/mi-interp.c (mi_interp::exec): Update.
4991         * linespec.c (parse_linespec): Update.
4992         * infcall.c (run_inferior_call): Update.
4993         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4994         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4995         (gdbscm_lookup_global_symbol): Update.
4996         * guile/scm-param.c (gdbscm_parameter_value): Update.
4997         * guile/scm-frame.c (gdbscm_frame_read_register)
4998         (gdbscm_frame_read_var): Update.
4999         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5000         * exec.c (try_open_exec_file): Update.
5001         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5002         (gdb_rl_callback_handler): Update.
5003         * common/common-exceptions.h (exception_none): Don't declare.
5004         * common/common-exceptions.c (exception_none): Don't define.
5005         (struct catcher) <exception>: Update.
5006         * cli/cli-interp.c (safe_execute_command): Update.
5007         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5008
5009 2019-04-25  Ali Tamur  <tamur@google.com>
5010
5011         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5012         (read_attribute_value): Likewise.
5013         (dwarf2_read_addr_index): Update comment.
5014         (read_str_index): Add DW_FORM_strx.
5015         (dwarf2_string_attr): Likewise.
5016         (dwarf2_const_value_attr): Likewise.
5017         (dump_die_shallow): Likewise.
5018         (dwarf2_fetch_constant_bytes): Likewise.
5019         (skip_form_bytes): Likewise.
5020         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5021
5022 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5023
5024         PR corefiles/11608
5025         PR corefiles/18187
5026         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5027         OFFSET.  Verify if current mapping contains an ELF header.
5028         (linux_find_memory_regions_full): Adjust call to
5029         dump_mapping_p.
5030
5031 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5032             Kang Li <kanglictf@gmail.com>
5033
5034         PR gdb/21600
5035
5036         * dwarf2-frame.c (read_initial_length): Be consistent about using
5037         unsigned representation of length.
5038         (decode_frame_entry_1): Likewise.  Check for wraparound of
5039         end pointer as well as buffer overflow.
5040
5041 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5042
5043         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5044         "vq".
5045
5046 2019-04-24  Tom Tromey  <tromey@adacore.com>
5047
5048         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5049
5050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * s12z-tdep.c (s12z_unwind_pc): Delete.
5053         (s12z_unwind_sp): Delete.
5054         (s12z_gdbarch_init): Don't register deleted functions with
5055         gdbarch.
5056
5057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * rl78-tdep.c (rl78_unwind_sp): Delete.
5060         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5061
5062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5063
5064         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5065         (xstormy16_unwind_pc): Delete.
5066         (xstormy16_dummy_id): Delete.
5067         (xstormy16_gdbarch_init): Don't register deleted functions with
5068         gdbarch.
5069
5070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5071
5072         * vax-tdep.c (vax_unwind_pc): Delete.
5073         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5074
5075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5076
5077         * v850-tdep.c (v850_unwind_sp): Delete.
5078         (v850_unwind_pc): Delete.
5079         (v850_dummy_id): Delete.
5080         (v850_gdbarch_init): Don't register deleted functions with
5081         gdbarch.
5082
5083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5084
5085         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5086         (tilegx_unwind_pc): Delete.
5087         (tilegx_unwind_dummy_id): Delete.
5088         (tilegx_gdbarch_init): Don't register deleted functions with
5089         gdbarch.
5090
5091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5092
5093         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5094         (tic6x_dummy_id): Delete.
5095         (tic6x_gdbarch_init): Don't register deleted functions with
5096         gdbarch.
5097
5098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * sparc-tdep.c (sparc_unwind_pc): Delete.
5101         (sparc32_gdbarch_init): Don't register deleted function with
5102         gdbarch.
5103
5104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         * sh-tdep.c (sh_unwind_sp): Delete.
5107         (sh_unwind_pc): Delete.
5108         (sh_dummy_id): Delete.
5109         (sh_gdbarch_init): Don't register deleted functions with
5110         gdbarch.
5111
5112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * score-tdep.c (score_unwind_sp): Delete.
5115         (score_unwind_pc): Delete.
5116         (score_dummy_id): Delete.
5117         (score_gdbarch_init): Don't register deleted functions with
5118         gdbarch.
5119
5120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * rx-tdep.c (rx_unwind_pc): Delete.
5123         (rx_unwind_sp): Delete.
5124         (rx_dummy_id): Delete.
5125         (rx_gdbarch_init): Don't register deleted functions with
5126         gdbarch.  Update comment.
5127
5128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5131         (rs6000_dummy_id): Delete.
5132         (rs6000_gdbarch_init): Don't register deleted functions with
5133         gdbarch.
5134
5135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * or1k-tdep.c (or1k_dummy_id): Delete.
5138         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5139
5140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * nios2-tdep.c (nios2_dummy_id): Delete.
5143         (nios2_unwind_sp): Delete.
5144         (nios2_gdbarch_init): Don't register deleted functions with
5145         gdbarch.
5146
5147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * nds32-tdep.c (nds32_dummy_id): Delete.
5150         (nds32_unwind_pc): Delete.
5151         (nds32_unwind_sp): Delete.
5152         (nds32_gdbarch_init): Don't register deleted functions with
5153         gdbarch.
5154
5155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * msp430-tdep.c (msp430_unwind_pc): Delete.
5158         (msp430_unwind_sp): Delete.
5159         (msp430_dummy_id): Delete.
5160         (msp430_gdbarch_init): Don't register deleted functions with
5161         gdbarch.
5162
5163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * moxie-tdep.c (moxie_unwind_sp): Delete.
5166         (moxie_unwind_pc): Delete.
5167         (moxie_dummy_id): Delete.
5168         (moxie_gdbarch_init): Don't register deleted functions with
5169         gdbarch.
5170
5171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5172
5173         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5174         (mn10300_unwind_pc): Delete.
5175         (mn10300_unwind_sp): Delete.
5176         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5177         mn10300_unwind_sp.
5178         (mn10300_frame_unwind_init): Don't register deleted functions with
5179         gdbarch.
5180
5181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * mep-tdep.c (mep_unwind_pc): Delete.
5184         (mep_unwind_sp): Delete.
5185         (mep_dummy_id): Delete.
5186         (mep_gdbarch_init): Don't register deleted functions with
5187         gdbarch.
5188
5189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5192         (m68hc11_unwind_sp): Delete.
5193         (m68hc11_gdbarch_init): Don't register deleted functions with
5194         gdbarch.
5195
5196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * m32r-tdep.c (m32r_unwind_sp): Delete.
5199         (m32r_unwind_pc): Delete.
5200         (m32r_dummy_id): Delete.
5201         (m32r_gdbarch_init): Don't register deleted functions with
5202         gdbarch.
5203
5204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5205
5206         * m32c-tdep.c (m32c_unwind_pc): Delete.
5207         (m32c_unwind_sp): Delete.
5208         (m32c_dummy_id): Delete.
5209         (m32c_gdbarch_init): Don't register deleted functions with
5210         gdbarch.
5211
5212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5213
5214         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5215         (lm32_unwind_pc): Delete.
5216         (lm32_dummy_id): Delete.
5217         (lm32_gdbarch_init): Don't register deleted functions with
5218         gdbarch.
5219
5220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5221
5222         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5223         (iq2000_unwind_pc): Delete.
5224         (iq2000_dummy_id): Delete.
5225         (iq2000_gdbarch_init): Don't register deleted functions with
5226         gdbarch.
5227
5228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5229
5230         * nds32-tdep.c (nds32_type_align): Delete.
5231         (nds32_push_dummy_call): Use type_align instead.
5232
5233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * arm-tdep.c (arm_type_align): Only handle vector override case.
5236         (arm_push_dummy_call): Use type_align.
5237         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5238
5239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5242         case.
5243         (pass_on_stack): Use type_align.
5244         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5245         function.
5246
5247 2019-04-23  Tom Tromey  <tromey@adacore.com>
5248
5249         * dwarf2read.c (line_header::file_name_at): Remove unused
5250         overload.
5251
5252 2019-04-23  Tom de Vries  <tdevries@suse.de>
5253
5254         PR gdb/24438
5255         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5256         invocation.
5257
5258
5259 2019-03-27  Ali Tamur  <tamur@google.com>
5260
5261         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5262         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5263         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5264         (dwarf_expr_context::get_addr_index): Likewise
5265         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5266         (symbol_needs_eval_context::get_addr_index): Likewise
5267         (disassemble_dwarf_expression): Add DW_OP_addrx
5268         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5269         (read_cutu_die_from_dwo): Update comment
5270         (skip_one_die): Add DW_FORM_addrx
5271         (read_attribute_value): Likewise
5272         (var_decode_location): Add DW_OP_addrx
5273         (dwarf2_const_value_attr): Add DW_FORM_addrx
5274         (dump_die_shallow): Likewise
5275         (dwarf2_fetch_constant_bytes): Likewise
5276         (decode_locdesc): Add DW_OP_addrx
5277         (skip_form_bytes): Add DW_FORM_addrx
5278
5279 2019-04-22  Ali Tamur  <tamur@google.com>
5280
5281         * MAINTAINERS (Write After Approval): Add self.
5282
5283 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5284
5285         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5286         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5287         (open_symbol_file_object): Likewise.
5288         (svr4_default_sos): Add info parameter.
5289         (svr4_read_so_list): Likewise.
5290         (svr4_current_sos_direct): Adjust functions calls to pass down
5291         info.
5292         (svr4_current_sos_1): Add info parameter.
5293         (svr4_current_sos): Call get_svr4_info, pass info down to
5294         svr4_current_sos_1.
5295         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5296         get_svr4_info.
5297         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5298         get_svr4_info.
5299         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5300         to get_svr4_info.
5301         (probes_table_remove_objfile_probes): Likewise.
5302         (register_solib_event_probe): Add info parameter.
5303         (solist_update_incremental): Pass info parameter down to
5304         svr4_read_so_list.
5305         (disable_probes_interface): Add info parameter.
5306         (svr4_handle_solib_event): Pass current_program_space to
5307         get_svr4_info.  Adjust disable_probes_interface cleanup.
5308         (svr4_create_probe_breakpoints): Add info parameter, pass it
5309         down to register_solib_event_probe.
5310         (svr4_create_solib_event_breakpoints): Add info parameter,
5311         pass it down to svr4_create_probe_breakpoints.
5312         (enable_break): Pass info down to
5313         svr4_create_solib_event_breakpoints.
5314         (svr4_solib_create_inferior_hook): Pass current_program_space to
5315         get_svr4_info.
5316         (svr4_clear_solib): Likewise.
5317
5318 2019-04-22  Pedro Alves  <palves@redhat.com>
5319
5320         * solib-svr4.c (svr4_free_objfile_observer): New.
5321         (probe_and_action::objfile): New field.
5322         (probes_table_htab_remove_objfile_probes)
5323         (probes_table_remove_objfile_probes): New functions.
5324         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5325         in the new probe_and_action.  Don't store the probe in 'lookup'.
5326         (svr4_create_probe_breakpoints): Pass objfile to
5327         register_solib_event_probe.
5328         (_initialize_svr4_solib): Register a free_objfile observer.
5329
5330 2019-04-19  Tom Tromey  <tom@tromey.com>
5331
5332         * common/queue.h: Remove.
5333
5334 2019-04-19  Tom Tromey  <tom@tromey.com>
5335
5336         * event-loop.c: Don't include "common/queue.h".
5337
5338 2019-04-19  Tom Tromey  <tom@tromey.com>
5339
5340         * remote.c (remote_target): Use delete.
5341         * remote-notif.h: Include <list>, not "common/queue.h".
5342         (notif_client_p): Remove typedef.
5343         (remote_notif_state): Add constructor, destructor, initializer.
5344         <notif_queue>: Now a std::list.
5345         (remote_notif_state_xfree): Don't declare.
5346         * remote-notif.c (remote_notif_process, handle_notification)
5347         (remote_notif_state_allocate): Update.
5348         (~remote_notif_state): Rename from remote_notif_state_xfree.
5349
5350 2019-04-19  Tom Tromey  <tom@tromey.com>
5351
5352         * symfile.c (reread_symbols): Update.
5353         * objfiles.c (objfile_register_static_link)
5354         (objfile_lookup_static_link): Update
5355         (~objfile) Don't delete static_links.
5356         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5357
5358 2019-04-19  Tom Tromey  <tom@tromey.com>
5359
5360         * type-stack.h (struct type_stack) <insert>: Constify string.
5361         * type-stack.c (type_stack::insert): Constify string.
5362         * gdbtypes.h (lookup_template_type): Update.
5363         (address_space_name_to_int): Update.
5364         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5365         const.
5366         (lookup_template_type): Make name const.
5367         * c-exp.y: Update rules.
5368         (lex_one_token, classify_name, classify_inner_name)
5369         (c_print_token): Update.
5370         * p-exp.y: Update rules.
5371         (yylex): Update.
5372         * f-exp.y: Update rules.
5373         (yylex): Update.
5374         * d-exp.y: Update rules.
5375         (lex_one_token, classify_name, classify_inner_name): Update.
5376         * parse.c (write_dollar_variable, copy_name): Return std::string.
5377         * parser-defs.h (copy_name): Change return type.
5378         * m2-exp.y: Update rules.
5379         (yylex): Update.
5380         * go-exp.y (lex_one_token): Update.
5381         Update rules.
5382         (classify_unsafe_function, classify_packaged_name)
5383         (classify_name, yylex): Update.
5384
5385 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5386
5387         * configure.ac: add --enable-source-highlight switch.
5388         * configure: Regenerate.
5389         * top.c (print_gdb_version): plumb --enable-source-highlight
5390         status to "show configuration".
5391
5392 2019-04-19  Tom Tromey  <tromey@adacore.com>
5393
5394         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5395         Check ADA_TYPE_P.
5396         (empty_record, ada_template_to_fixed_record_type_1)
5397         (template_to_static_fixed_type)
5398         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5399         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5400         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5401         macros.
5402
5403 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5404
5405         PR symtab/24423:
5406         * source.c (print_source_lines_base): Advance "iter" when a
5407         control character is seen.
5408
5409 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5410
5411         * inferior.h (struct infcall_suspend_state_deleter):
5412         Catch exception in destructor to avoid crash.
5413
5414 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5415
5416         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5417         close to the add_com "shell".
5418
5419 2019-04-18  Tom Tromey  <tromey@adacore.com>
5420
5421         * process-stratum-target.h (class process_stratum_target)
5422         <stratum>: Add "final".
5423
5424 2019-04-17  Tom Tromey  <tromey@adacore.com>
5425
5426         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5427         against nullptr before use.
5428
5429 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5430
5431         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5432
5433 2019-04-17  Jim Wilson  <jimw@sifive.com>
5434             Andrew Burgess  <andrew.burgess@embecosm.com>
5435
5436         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5437         code read might fail, assume 4-byte breakpoint in that case.
5438
5439 2019-04-15  Leszek Swirski  <leszeks@google.com>
5440
5441         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5442         rather than a hand-rolled POD check when checking for forced MEMORY
5443         classification.
5444
5445 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5446
5447         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5448         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5449         function.
5450         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5451         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5452         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5453         declaration.
5454
5455 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5456
5457         * aarch64-linux-nat.c
5458         (aarch64_linux_nat_target::thread_architecture): Add override.
5459         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5460         each VQ.
5461
5462 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5463
5464         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5465
5466 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5467
5468         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5469         target types of size 96-bits, add some additional comments, and
5470         check that the builtin type we found was the correct size.
5471
5472 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5473
5474         * utils.c (prompt_for_continue): Don't restore the styling at the
5475         end, as applied_style has the wrong value.  This fixes styling in
5476         long lists of file names that are interrupted by the "Continue?"
5477         prompt.
5478
5479 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5482         * c-lang.c (c_language_defn): Likewise.
5483         (cplus_language_defn): Likewise.
5484         (asm_language_defn): Likewise.
5485         (minimal_language_defn): Likewise.
5486         * d-lang.c (d_language_defn): Likewise.
5487         * f-lang.c (f_language_defn): Likewise.
5488         * go-lang.c (go_language_defn): Likewise.
5489         * language.c (unknown_language_defn): Likewise.
5490         (auto_language_defn): Likewise.
5491         * language.h (struct language_defn): Remove la_magic field.
5492         (LANG_MAGIC): Delete.
5493         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5494         * objc-lang.c (objc_language_defn): Likewise.
5495         * opencl-lang.c (opencl_language_defn): Likewise.
5496         * p-lang.c (pascal_language_defn): Likewise.
5497         * rust-lang.c (rust_language_defn): Likewise.
5498
5499 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * riscv-tdep.c (riscv_type_align): New function.
5502         (riscv_type_alignment): Delete.
5503         (riscv_arg_location): Use 'type_align'.
5504         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5505
5506 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * gdbtypes.c (type_align): A struct with no non-static fields also
5509         has alignment of 1.
5510
5511 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5514         component to 0.
5515         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5516         member.
5517         (riscv_struct_info::analyse): New implementation using new
5518         analyse_inner member function.
5519         (riscv_struct_info::field_offset): New member function.
5520         (riscv_struct_info::m_offsets): New member variable.
5521         (riscv_struct_info::analyse_inner): New private member function,
5522         takes the old implementation of riscv_struct_info::analyse but
5523         extended to track field offsets.
5524         (riscv_call_arg_struct): Update the struct folding special cases
5525         to handle cases where empty C++ structs, which are non-zero
5526         length, are found.
5527         (riscv_arg_location): Initialise the length of each location, a
5528         non-zero length now indicates the location is in use.
5529         (riscv_push_dummy_call): Allow for the first location having a
5530         non-zero offset when setting up arguments.
5531         (riscv_return_value): Likewise, but for return values.
5532
5533 2019-04-11  Tom Tromey  <tromey@adacore.com>
5534
5535         * utils.c (internal_vproblem): Make "msg" const.
5536
5537 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5538
5539         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5540         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5541         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5542         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5543
5544 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5545
5546         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5547         function.
5548         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5549         of amd64_collect_native_gregset.
5550         (amd64_linux_nat_target::store_registers): Likewise.
5551
5552 2019-04-10  Tom Tromey  <tom@tromey.com>
5553
5554         * symtab.c (lookup_global_symbol_from_objfile)
5555         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5556         * objfiles.h (class separate_debug_iterator): New.
5557         (class separate_debug_range): New.
5558         (struct objfile) <separate_debug_objfiles>: New method.
5559         (objfile_separate_debug_iterate): Don't declare.
5560         * objfiles.c (separate_debug_iterator::operator++): Rename from
5561         objfile_separate_debug_iterate.
5562         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5563         iterator.
5564         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5565         iterator.
5566
5567 2019-04-10  Tom Tromey  <tom@tromey.com>
5568
5569         * symfile.c (reread_symbols): Remove old comment.
5570         * objfiles.c (free_all_objfiles): Fix a typo.
5571
5572 2019-04-10  Tom Tromey  <tom@tromey.com>
5573
5574         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5575         * minsyms.c (lookup_minimal_symbol): Use foreach.
5576         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5577         (lookup_minimal_symbol_solib_trampoline): Likewise.
5578         * symfile.c (reread_symbols): Use foreach.
5579
5580 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5581             Tom Tromey  <tromey@adacore.com>
5582
5583         PR rust/24414:
5584         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5585         (rust_lex_int_test): Change "value" to be LONGEST.
5586         (rust_lex_tests): Add test for long integer literal.
5587
5588 2019-04-09  Tom Tromey  <tromey@adacore.com>
5589
5590         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5591         to bool.
5592         (extended_remote_target::attach): Update.
5593         (remote_target::remote_notice_new_inferior): Update.
5594         (remote_target::add_current_inferior_and_thread): Update.
5595         * inferior.c (exit_inferior_1): Use "false".
5596         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5597
5598 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5599
5600         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5601         the "start" command.
5602
5603 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5604
5605         * python/py-inferior.c (infpy_thread_from_thread_handle):
5606         Adjust comments to reflect renaming of thread_from_thread_handle
5607         to thread_from_handle.  Adjust keywords.  Fix type error message.
5608         (inferior_object_methods): Add thread_from_handle.  Retain
5609         thread_from_thread_handle, but mark it as deprecated.
5610
5611 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5612
5613         * gdbthread.h (find_thread_by_handle): Revise declaration.
5614         * thread.c (find_thread_by_handle): Likewise.  Adjust
5615         implementation too.
5616         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5617         support for buffer objects as handles.
5618
5619 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5620
5621         * python/py-infthread.c (thpy_thread_handle): New function.
5622         (thread_object_methods): Register thpy_thread_handle.
5623
5624 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5625
5626         * gdbthread.h (thread_to_thread_handle): Declare.
5627         * thread.c (gdbtypes.h): Include.
5628         (thread_to_thread_handle): New function.
5629
5630         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5631         (target_thread_info_to_thread_handle): Declare.
5632         * target.c (target_thread_info_to_thread_handle): New function.
5633         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5634         * target-delegates.c: Regenerate.
5635
5636         * linux-thread-db.c (class thread_db_target): Add method
5637         thread_info_to_thread_handle.
5638         (thread_db_target::thread_info_to_thread_handle): Define.
5639         * remote.c (class remote_target): Add new method
5640         thread_info_to_thread_handle.
5641         (remote_target::thread_info_to_thread_handle): Define.
5642
5643 2019-04-08  Pedro Alves  <palves@redhat.com>
5644
5645         * common/common-exceptions.c (throw_exception): Don't create
5646         named object to throw; throw directly.
5647         (throw_it): Likewise.  Don't initialize gdb_exception::message
5648         here, with new; pass FMT and AP to the ctor instead.
5649         * common/common-exceptions.h: Include <string>.
5650         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5651         const char *, va_list)): New ctor.  Use std::make_shared.
5652         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5653         errors)): Delete.
5654         (gdb_exception_error::gdb_exception_error(enum errors, const char
5655         *, va_list)): New.
5656         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5657         Add assertion.
5658         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5659         errors)): Delete.
5660         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5661         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5662         Add assertion.
5663
5664 2019-04-08  Tom Tromey  <tom@tromey.com>
5665
5666         * valops.c (value_rtti_indirect_type): Replace throw_exception
5667         with throw.
5668         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5669         with throw.
5670         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5671         throw.
5672         * target.c (target_translate_tls_address): Replace throw_exception
5673         with throw.
5674         * stack.c (frame_apply_command_count): Replace throw_exception
5675         with throw.
5676         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5677         throw.
5678         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5679         with throw.
5680         * rs6000-tdep.c (rs6000_frame_cache)
5681         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5682         * remote.c: Replace throw_exception with throw.
5683         * record-full.c (record_full_message, record_full_wait_1)
5684         (record_full_restore): Replace throw_exception with throw.
5685         * record-btrace.c:
5686         (get_thread_current_frame_id, record_btrace_start_replaying)
5687         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5688         (cmd_record_btrace_start): Replace throw_exception with throw.
5689         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5690         throw.
5691         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5692         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5693         * linespec.c:
5694         (find_linespec_symbols): Replace throw_exception with throw.
5695         * infrun.c (displaced_step_prepare, resume): Replace
5696         throw_exception with throw.
5697         * infcmd.c (post_create_inferior): Replace throw_exception with
5698         throw.
5699         * inf-loop.c (inferior_event_handler): Replace throw_exception
5700         with throw.
5701         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5702         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5703         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5704         (get_prev_frame_always, get_frame_pc_if_available)
5705         (get_frame_address_in_block_if_available, get_frame_language):
5706         Replace throw_exception with throw.
5707         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5708         throw_exception with throw.
5709         * eval.c (fetch_subexp_value, evaluate_var_value)
5710         (evaluate_funcall, evaluate_subexp_standard): Replace
5711         throw_exception with throw.
5712         * dwarf2loc.c (call_site_find_chain)
5713         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5714         Replace throw_exception with throw.
5715         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5716         with throw.
5717         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5718         throw.
5719         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5720         * completer.c (complete_line_internal): Replace throw_exception
5721         with throw.
5722         * compile/compile-object-run.c (compile_object_run): Replace
5723         throw_exception with throw.
5724         * cli/cli-script.c (process_next_line): Replace throw_exception
5725         with throw.
5726         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5727         (btrace_enable, btrace_maint_update_pt_packets): Replace
5728         throw_exception with throw.
5729         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5730         throw_exception with throw.
5731         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5732         throw_exception with throw.
5733         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5734         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5735         * aarch64-tdep.c (aarch64_make_prologue_cache)
5736         (aarch64_make_stub_cache): Replace throw_exception with throw.
5737
5738 2019-04-08  Tom Tromey  <tom@tromey.com>
5739
5740         * common/common-exceptions.c (throw_exception): Rename from
5741         throw_exception_cxx.  Remove old copy.  Make argument const.
5742         (throw_it): Create and throw exception objects directly.
5743         * common/common-exceptions.h (throw_exception): Make argument
5744         const.
5745         (struct gdb_exception_error): Add constructor.
5746         (struct gdb_exception_quit): Add constructor.
5747
5748 2019-04-08  Tom Tromey  <tom@tromey.com>
5749
5750         * common/common-exceptions.h (exception_rethrow): Don't declare.
5751         (TRY_SJLJ): Update comment.
5752         (TRY, CATCH, END_CATCH): Remove.
5753         * common/common-exceptions.c (exception_rethrow): Remove.
5754
5755 2019-04-08  Tom Tromey  <tom@tromey.com>
5756
5757         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5758         Remove.
5759         (gdb_exception_error): Rename from
5760         gdb_exception_RETURN_MASK_ERROR.
5761         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5762         (gdb_quit_bad_alloc): Update.
5763         * aarch64-tdep.c: Update.
5764         * ada-lang.c: Update.
5765         * ada-typeprint.c: Update.
5766         * ada-valprint.c: Update.
5767         * amd64-tdep.c: Update.
5768         * arch-utils.c: Update.
5769         * break-catch-throw.c: Update.
5770         * breakpoint.c: Update.
5771         * btrace.c: Update.
5772         * c-varobj.c: Update.
5773         * cli/cli-cmds.c: Update.
5774         * cli/cli-interp.c: Update.
5775         * cli/cli-script.c: Update.
5776         * common/common-exceptions.c: Update.
5777         * common/new-op.c: Update.
5778         * common/selftest.c: Update.
5779         * compile/compile-c-symbols.c: Update.
5780         * compile/compile-cplus-symbols.c: Update.
5781         * compile/compile-object-load.c: Update.
5782         * compile/compile-object-run.c: Update.
5783         * completer.c: Update.
5784         * corelow.c: Update.
5785         * cp-abi.c: Update.
5786         * cp-support.c: Update.
5787         * cp-valprint.c: Update.
5788         * darwin-nat.c: Update.
5789         * disasm-selftests.c: Update.
5790         * dtrace-probe.c: Update.
5791         * dwarf-index-cache.c: Update.
5792         * dwarf-index-write.c: Update.
5793         * dwarf2-frame-tailcall.c: Update.
5794         * dwarf2-frame.c: Update.
5795         * dwarf2loc.c: Update.
5796         * dwarf2read.c: Update.
5797         * eval.c: Update.
5798         * event-loop.c: Update.
5799         * event-top.c: Update.
5800         * exec.c: Update.
5801         * f-valprint.c: Update.
5802         * fbsd-tdep.c: Update.
5803         * frame-unwind.c: Update.
5804         * frame.c: Update.
5805         * gdbtypes.c: Update.
5806         * gnu-v3-abi.c: Update.
5807         * guile/guile-internal.h: Update.
5808         * guile/scm-block.c: Update.
5809         * guile/scm-breakpoint.c: Update.
5810         * guile/scm-cmd.c: Update.
5811         * guile/scm-disasm.c: Update.
5812         * guile/scm-frame.c: Update.
5813         * guile/scm-lazy-string.c: Update.
5814         * guile/scm-math.c: Update.
5815         * guile/scm-param.c: Update.
5816         * guile/scm-ports.c: Update.
5817         * guile/scm-pretty-print.c: Update.
5818         * guile/scm-symbol.c: Update.
5819         * guile/scm-symtab.c: Update.
5820         * guile/scm-type.c: Update.
5821         * guile/scm-value.c: Update.
5822         * i386-linux-tdep.c: Update.
5823         * i386-tdep.c: Update.
5824         * inf-loop.c: Update.
5825         * infcall.c: Update.
5826         * infcmd.c: Update.
5827         * infrun.c: Update.
5828         * jit.c: Update.
5829         * language.c: Update.
5830         * linespec.c: Update.
5831         * linux-fork.c: Update.
5832         * linux-nat.c: Update.
5833         * linux-tdep.c: Update.
5834         * linux-thread-db.c: Update.
5835         * main.c: Update.
5836         * mi/mi-cmd-break.c: Update.
5837         * mi/mi-cmd-stack.c: Update.
5838         * mi/mi-interp.c: Update.
5839         * mi/mi-main.c: Update.
5840         * objc-lang.c: Update.
5841         * p-valprint.c: Update.
5842         * parse.c: Update.
5843         * ppc-linux-tdep.c: Update.
5844         * printcmd.c: Update.
5845         * python/py-arch.c: Update.
5846         * python/py-breakpoint.c: Update.
5847         * python/py-cmd.c: Update.
5848         * python/py-finishbreakpoint.c: Update.
5849         * python/py-frame.c: Update.
5850         * python/py-framefilter.c: Update.
5851         * python/py-gdb-readline.c: Update.
5852         * python/py-inferior.c: Update.
5853         * python/py-infthread.c: Update.
5854         * python/py-lazy-string.c: Update.
5855         * python/py-linetable.c: Update.
5856         * python/py-objfile.c: Update.
5857         * python/py-param.c: Update.
5858         * python/py-prettyprint.c: Update.
5859         * python/py-progspace.c: Update.
5860         * python/py-record-btrace.c: Update.
5861         * python/py-record.c: Update.
5862         * python/py-symbol.c: Update.
5863         * python/py-type.c: Update.
5864         * python/py-unwind.c: Update.
5865         * python/py-utils.c: Update.
5866         * python/py-value.c: Update.
5867         * python/python.c: Update.
5868         * record-btrace.c: Update.
5869         * record-full.c: Update.
5870         * remote-fileio.c: Update.
5871         * remote.c: Update.
5872         * riscv-tdep.c: Update.
5873         * rs6000-aix-tdep.c: Update.
5874         * rs6000-tdep.c: Update.
5875         * rust-exp.y: Update.
5876         * rust-lang.c: Update.
5877         * s390-tdep.c: Update.
5878         * selftest-arch.c: Update.
5879         * solib-dsbt.c: Update.
5880         * solib-frv.c: Update.
5881         * solib-spu.c: Update.
5882         * solib-svr4.c: Update.
5883         * solib.c: Update.
5884         * sparc64-linux-tdep.c: Update.
5885         * stack.c: Update.
5886         * symfile-mem.c: Update.
5887         * symmisc.c: Update.
5888         * target.c: Update.
5889         * thread.c: Update.
5890         * top.c: Update.
5891         * tracefile-tfile.c: Update.
5892         * tui/tui.c: Update.
5893         * typeprint.c: Update.
5894         * unittests/cli-utils-selftests.c: Update.
5895         * unittests/parse-connection-spec-selftests.c: Update.
5896         * valops.c: Update.
5897         * valprint.c: Update.
5898         * value.c: Update.
5899         * varobj.c: Update.
5900         * windows-nat.c: Update.
5901         * x86-linux-nat.c: Update.
5902         * xml-support.c: Update.
5903
5904 2019-04-08  Tom Tromey  <tom@tromey.com>
5905
5906         * xml-support.c: Use C++ exception handling.
5907         * x86-linux-nat.c: Use C++ exception handling.
5908         * windows-nat.c: Use C++ exception handling.
5909         * varobj.c: Use C++ exception handling.
5910         * value.c: Use C++ exception handling.
5911         * valprint.c: Use C++ exception handling.
5912         * valops.c: Use C++ exception handling.
5913         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5914         handling.
5915         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5916         * typeprint.c: Use C++ exception handling.
5917         * tui/tui.c: Use C++ exception handling.
5918         * tracefile-tfile.c: Use C++ exception handling.
5919         * top.c: Use C++ exception handling.
5920         * thread.c: Use C++ exception handling.
5921         * target.c: Use C++ exception handling.
5922         * symmisc.c: Use C++ exception handling.
5923         * symfile-mem.c: Use C++ exception handling.
5924         * stack.c: Use C++ exception handling.
5925         * sparc64-linux-tdep.c: Use C++ exception handling.
5926         * solib.c: Use C++ exception handling.
5927         * solib-svr4.c: Use C++ exception handling.
5928         * solib-spu.c: Use C++ exception handling.
5929         * solib-frv.c: Use C++ exception handling.
5930         * solib-dsbt.c: Use C++ exception handling.
5931         * selftest-arch.c: Use C++ exception handling.
5932         * s390-tdep.c: Use C++ exception handling.
5933         * rust-lang.c: Use C++ exception handling.
5934         * rust-exp.y: Use C++ exception handling.
5935         * rs6000-tdep.c: Use C++ exception handling.
5936         * rs6000-aix-tdep.c: Use C++ exception handling.
5937         * riscv-tdep.c: Use C++ exception handling.
5938         * remote.c: Use C++ exception handling.
5939         * remote-fileio.c: Use C++ exception handling.
5940         * record-full.c: Use C++ exception handling.
5941         * record-btrace.c: Use C++ exception handling.
5942         * python/python.c: Use C++ exception handling.
5943         * python/py-value.c: Use C++ exception handling.
5944         * python/py-utils.c: Use C++ exception handling.
5945         * python/py-unwind.c: Use C++ exception handling.
5946         * python/py-type.c: Use C++ exception handling.
5947         * python/py-symbol.c: Use C++ exception handling.
5948         * python/py-record.c: Use C++ exception handling.
5949         * python/py-record-btrace.c: Use C++ exception handling.
5950         * python/py-progspace.c: Use C++ exception handling.
5951         * python/py-prettyprint.c: Use C++ exception handling.
5952         * python/py-param.c: Use C++ exception handling.
5953         * python/py-objfile.c: Use C++ exception handling.
5954         * python/py-linetable.c: Use C++ exception handling.
5955         * python/py-lazy-string.c: Use C++ exception handling.
5956         * python/py-infthread.c: Use C++ exception handling.
5957         * python/py-inferior.c: Use C++ exception handling.
5958         * python/py-gdb-readline.c: Use C++ exception handling.
5959         * python/py-framefilter.c: Use C++ exception handling.
5960         * python/py-frame.c: Use C++ exception handling.
5961         * python/py-finishbreakpoint.c: Use C++ exception handling.
5962         * python/py-cmd.c: Use C++ exception handling.
5963         * python/py-breakpoint.c: Use C++ exception handling.
5964         * python/py-arch.c: Use C++ exception handling.
5965         * printcmd.c: Use C++ exception handling.
5966         * ppc-linux-tdep.c: Use C++ exception handling.
5967         * parse.c: Use C++ exception handling.
5968         * p-valprint.c: Use C++ exception handling.
5969         * objc-lang.c: Use C++ exception handling.
5970         * mi/mi-main.c: Use C++ exception handling.
5971         * mi/mi-interp.c: Use C++ exception handling.
5972         * mi/mi-cmd-stack.c: Use C++ exception handling.
5973         * mi/mi-cmd-break.c: Use C++ exception handling.
5974         * main.c: Use C++ exception handling.
5975         * linux-thread-db.c: Use C++ exception handling.
5976         * linux-tdep.c: Use C++ exception handling.
5977         * linux-nat.c: Use C++ exception handling.
5978         * linux-fork.c: Use C++ exception handling.
5979         * linespec.c: Use C++ exception handling.
5980         * language.c: Use C++ exception handling.
5981         * jit.c: Use C++ exception handling.
5982         * infrun.c: Use C++ exception handling.
5983         * infcmd.c: Use C++ exception handling.
5984         * infcall.c: Use C++ exception handling.
5985         * inf-loop.c: Use C++ exception handling.
5986         * i386-tdep.c: Use C++ exception handling.
5987         * i386-linux-tdep.c: Use C++ exception handling.
5988         * guile/scm-value.c: Use C++ exception handling.
5989         * guile/scm-type.c: Use C++ exception handling.
5990         * guile/scm-symtab.c: Use C++ exception handling.
5991         * guile/scm-symbol.c: Use C++ exception handling.
5992         * guile/scm-pretty-print.c: Use C++ exception handling.
5993         * guile/scm-ports.c: Use C++ exception handling.
5994         * guile/scm-param.c: Use C++ exception handling.
5995         * guile/scm-math.c: Use C++ exception handling.
5996         * guile/scm-lazy-string.c: Use C++ exception handling.
5997         * guile/scm-frame.c: Use C++ exception handling.
5998         * guile/scm-disasm.c: Use C++ exception handling.
5999         * guile/scm-cmd.c: Use C++ exception handling.
6000         * guile/scm-breakpoint.c: Use C++ exception handling.
6001         * guile/scm-block.c: Use C++ exception handling.
6002         * guile/guile-internal.h: Use C++ exception handling.
6003         * gnu-v3-abi.c: Use C++ exception handling.
6004         * gdbtypes.c: Use C++ exception handling.
6005         * frame.c: Use C++ exception handling.
6006         * frame-unwind.c: Use C++ exception handling.
6007         * fbsd-tdep.c: Use C++ exception handling.
6008         * f-valprint.c: Use C++ exception handling.
6009         * exec.c: Use C++ exception handling.
6010         * event-top.c: Use C++ exception handling.
6011         * event-loop.c: Use C++ exception handling.
6012         * eval.c: Use C++ exception handling.
6013         * dwarf2read.c: Use C++ exception handling.
6014         * dwarf2loc.c: Use C++ exception handling.
6015         * dwarf2-frame.c: Use C++ exception handling.
6016         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6017         * dwarf-index-write.c: Use C++ exception handling.
6018         * dwarf-index-cache.c: Use C++ exception handling.
6019         * dtrace-probe.c: Use C++ exception handling.
6020         * disasm-selftests.c: Use C++ exception handling.
6021         * darwin-nat.c: Use C++ exception handling.
6022         * cp-valprint.c: Use C++ exception handling.
6023         * cp-support.c: Use C++ exception handling.
6024         * cp-abi.c: Use C++ exception handling.
6025         * corelow.c: Use C++ exception handling.
6026         * completer.c: Use C++ exception handling.
6027         * compile/compile-object-run.c: Use C++ exception handling.
6028         * compile/compile-object-load.c: Use C++ exception handling.
6029         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6030         * compile/compile-c-symbols.c: Use C++ exception handling.
6031         * common/selftest.c: Use C++ exception handling.
6032         * common/new-op.c: Use C++ exception handling.
6033         * cli/cli-script.c: Use C++ exception handling.
6034         * cli/cli-interp.c: Use C++ exception handling.
6035         * cli/cli-cmds.c: Use C++ exception handling.
6036         * c-varobj.c: Use C++ exception handling.
6037         * btrace.c: Use C++ exception handling.
6038         * breakpoint.c: Use C++ exception handling.
6039         * break-catch-throw.c: Use C++ exception handling.
6040         * arch-utils.c: Use C++ exception handling.
6041         * amd64-tdep.c: Use C++ exception handling.
6042         * ada-valprint.c: Use C++ exception handling.
6043         * ada-typeprint.c: Use C++ exception handling.
6044         * ada-lang.c: Use C++ exception handling.
6045         * aarch64-tdep.c: Use C++ exception handling.
6046
6047 2019-04-08  Tom Tromey  <tom@tromey.com>
6048
6049         * xml-support.c (gdb_xml_parser::parse): Update.
6050         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6051         * value.c (show_convenience): Update.
6052         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6053         (test_parse_flags_qcs): Update.
6054         * thread.c (thr_try_catch_cmd): Update.
6055         * target.c (target_translate_tls_address): Update.
6056         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6057         (info_frame_command_core, frame_apply_command_count): Update.
6058         * rust-exp.y (rust_lex_exception_test): Update.
6059         * riscv-tdep.c (riscv_print_one_register_info): Update.
6060         * remote.c (remote_target::enable_btrace): Update.
6061         * record-btrace.c (record_btrace_enable_warn): Update.
6062         * python/py-utils.c (gdbpy_convert_exception): Update.
6063         * printcmd.c (do_one_display, print_variable_and_value): Update.
6064         * mi/mi-main.c (mi_print_exception): Update.
6065         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6066         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6067         * linux-nat.c (linux_nat_target::attach): Update.
6068         * linux-fork.c (class scoped_switch_fork_info): Update.
6069         * infrun.c (displaced_step_prepare): Update.
6070         * infcall.c (call_function_by_hand_dummy): Update.
6071         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6072         * gnu-v3-abi.c (print_one_vtable): Update.
6073         * frame.c (get_prev_frame_always): Update.
6074         * f-valprint.c (info_common_command_for_block): Update.
6075         * exec.c (try_open_exec_file): Update.
6076         * exceptions.c (print_exception, exception_print)
6077         (exception_fprintf, exception_print_same): Update.
6078         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6079         * dwarf-index-cache.c (index_cache::store)
6080         (index_cache::lookup_gdb_index): Update.
6081         * darwin-nat.c (maybe_cache_shell): Update.
6082         * cp-valprint.c (cp_print_value_fields): Update.
6083         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6084         (gcc_cplus_symbol_address): Update.
6085         * compile/compile-c-symbols.c (gcc_convert_symbol)
6086         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6087         * common/selftest.c: Update.
6088         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6089         a std::string.
6090         (exception_try_scope_entry, exception_try_scope_exit): Don't
6091         declare.
6092         (struct exception_try_scope): Remove.
6093         (TRY): Don't use exception_try_scope.
6094         (struct gdb_exception): Add constructor, operator=.
6095         <what>: New method.
6096         (struct gdb_exception_RETURN_MASK_ALL)
6097         (struct gdb_exception_RETURN_MASK_ERROR)
6098         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6099         (struct gdb_quit_bad_alloc): Update.
6100         * common/common-exceptions.c (exception_none): Change
6101         initializer.
6102         (struct catcher) <state, exception>: Initialize inline.
6103         <prev>: Remove member.
6104         (current_catcher): Remove.
6105         (catchers): New global.
6106         (exceptions_state_mc_init): Simplify.
6107         (catcher_pop): Remove.
6108         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6109         (try_scope_depth, exception_try_scope_entry)
6110         (exception_try_scope_exit): Remove.
6111         (throw_exception_sjlj): Update.
6112         (exception_messages, exception_messages_size): Remove.
6113         (throw_it): Simplify.
6114         (gdb_exception_sliced_copy): Remove.
6115         (throw_exception_cxx): Update.
6116         * cli/cli-script.c (script_from_file): Update.
6117         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6118         Update.
6119         * ada-valprint.c (ada_val_print): Update.
6120         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6121         (create_excep_cond_exprs): Update.
6122
6123 2019-04-08  Tom Tromey  <tom@tromey.com>
6124
6125         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6126         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6127         (TRY, CATCH, END_CATCH): Remove some definitions.
6128         * common/common-exceptions.c: Don't use GDB_XCPT.
6129         (catcher_list_size): Remove.
6130         (throw_exception, throw_it): Simplify.
6131
6132 2019-04-05  Tom Tromey  <tom@tromey.com>
6133
6134         Revert the header-sorting patch.
6135         * ft32-tdep.c: Revert.
6136         * frv-tdep.c: Revert.
6137         * frv-linux-tdep.c: Revert.
6138         * frame.c: Revert.
6139         * frame-unwind.c: Revert.
6140         * frame-base.c: Revert.
6141         * fork-child.c: Revert.
6142         * findvar.c: Revert.
6143         * findcmd.c: Revert.
6144         * filesystem.c: Revert.
6145         * filename-seen-cache.h: Revert.
6146         * filename-seen-cache.c: Revert.
6147         * fbsd-tdep.c: Revert.
6148         * fbsd-nat.h: Revert.
6149         * fbsd-nat.c: Revert.
6150         * f-valprint.c: Revert.
6151         * f-typeprint.c: Revert.
6152         * f-lang.c: Revert.
6153         * extension.h: Revert.
6154         * extension.c: Revert.
6155         * extension-priv.h: Revert.
6156         * expprint.c: Revert.
6157         * exec.h: Revert.
6158         * exec.c: Revert.
6159         * exceptions.c: Revert.
6160         * event-top.c: Revert.
6161         * event-loop.c: Revert.
6162         * eval.c: Revert.
6163         * elfread.c: Revert.
6164         * dwarf2read.h: Revert.
6165         * dwarf2read.c: Revert.
6166         * dwarf2loc.c: Revert.
6167         * dwarf2expr.h: Revert.
6168         * dwarf2expr.c: Revert.
6169         * dwarf2-frame.c: Revert.
6170         * dwarf2-frame-tailcall.c: Revert.
6171         * dwarf-index-write.h: Revert.
6172         * dwarf-index-write.c: Revert.
6173         * dwarf-index-common.c: Revert.
6174         * dwarf-index-cache.h: Revert.
6175         * dwarf-index-cache.c: Revert.
6176         * dummy-frame.c: Revert.
6177         * dtrace-probe.c: Revert.
6178         * disasm.h: Revert.
6179         * disasm.c: Revert.
6180         * disasm-selftests.c: Revert.
6181         * dictionary.c: Revert.
6182         * dicos-tdep.c: Revert.
6183         * demangle.c: Revert.
6184         * dcache.h: Revert.
6185         * dcache.c: Revert.
6186         * darwin-nat.h: Revert.
6187         * darwin-nat.c: Revert.
6188         * darwin-nat-info.c: Revert.
6189         * d-valprint.c: Revert.
6190         * d-namespace.c: Revert.
6191         * d-lang.c: Revert.
6192         * ctf.c: Revert.
6193         * csky-tdep.c: Revert.
6194         * csky-linux-tdep.c: Revert.
6195         * cris-tdep.c: Revert.
6196         * cris-linux-tdep.c: Revert.
6197         * cp-valprint.c: Revert.
6198         * cp-support.c: Revert.
6199         * cp-namespace.c: Revert.
6200         * cp-abi.c: Revert.
6201         * corelow.c: Revert.
6202         * corefile.c: Revert.
6203         * continuations.c: Revert.
6204         * completer.h: Revert.
6205         * completer.c: Revert.
6206         * complaints.c: Revert.
6207         * coffread.c: Revert.
6208         * coff-pe-read.c: Revert.
6209         * cli-out.h: Revert.
6210         * cli-out.c: Revert.
6211         * charset.c: Revert.
6212         * c-varobj.c: Revert.
6213         * c-valprint.c: Revert.
6214         * c-typeprint.c: Revert.
6215         * c-lang.c: Revert.
6216         * buildsym.c: Revert.
6217         * buildsym-legacy.c: Revert.
6218         * build-id.h: Revert.
6219         * build-id.c: Revert.
6220         * btrace.c: Revert.
6221         * bsd-uthread.c: Revert.
6222         * breakpoint.h: Revert.
6223         * breakpoint.c: Revert.
6224         * break-catch-throw.c: Revert.
6225         * break-catch-syscall.c: Revert.
6226         * break-catch-sig.c: Revert.
6227         * blockframe.c: Revert.
6228         * block.c: Revert.
6229         * bfin-tdep.c: Revert.
6230         * bfin-linux-tdep.c: Revert.
6231         * bfd-target.c: Revert.
6232         * bcache.c: Revert.
6233         * ax-general.c: Revert.
6234         * ax-gdb.h: Revert.
6235         * ax-gdb.c: Revert.
6236         * avr-tdep.c: Revert.
6237         * auxv.c: Revert.
6238         * auto-load.c: Revert.
6239         * arm-wince-tdep.c: Revert.
6240         * arm-tdep.c: Revert.
6241         * arm-symbian-tdep.c: Revert.
6242         * arm-pikeos-tdep.c: Revert.
6243         * arm-obsd-tdep.c: Revert.
6244         * arm-nbsd-tdep.c: Revert.
6245         * arm-nbsd-nat.c: Revert.
6246         * arm-linux-tdep.c: Revert.
6247         * arm-linux-nat.c: Revert.
6248         * arm-fbsd-tdep.c: Revert.
6249         * arm-fbsd-nat.c: Revert.
6250         * arm-bsd-tdep.c: Revert.
6251         * arch-utils.c: Revert.
6252         * arc-tdep.c: Revert.
6253         * arc-newlib-tdep.c: Revert.
6254         * annotate.h: Revert.
6255         * annotate.c: Revert.
6256         * amd64-windows-tdep.c: Revert.
6257         * amd64-windows-nat.c: Revert.
6258         * amd64-tdep.c: Revert.
6259         * amd64-sol2-tdep.c: Revert.
6260         * amd64-obsd-tdep.c: Revert.
6261         * amd64-obsd-nat.c: Revert.
6262         * amd64-nbsd-tdep.c: Revert.
6263         * amd64-nbsd-nat.c: Revert.
6264         * amd64-nat.c: Revert.
6265         * amd64-linux-tdep.c: Revert.
6266         * amd64-linux-nat.c: Revert.
6267         * amd64-fbsd-tdep.c: Revert.
6268         * amd64-fbsd-nat.c: Revert.
6269         * amd64-dicos-tdep.c: Revert.
6270         * amd64-darwin-tdep.c: Revert.
6271         * amd64-bsd-nat.c: Revert.
6272         * alpha-tdep.c: Revert.
6273         * alpha-obsd-tdep.c: Revert.
6274         * alpha-nbsd-tdep.c: Revert.
6275         * alpha-mdebug-tdep.c: Revert.
6276         * alpha-linux-tdep.c: Revert.
6277         * alpha-linux-nat.c: Revert.
6278         * alpha-bsd-tdep.c: Revert.
6279         * alpha-bsd-nat.c: Revert.
6280         * aix-thread.c: Revert.
6281         * agent.c: Revert.
6282         * addrmap.c: Revert.
6283         * ada-varobj.c: Revert.
6284         * ada-valprint.c: Revert.
6285         * ada-typeprint.c: Revert.
6286         * ada-tasks.c: Revert.
6287         * ada-lang.c: Revert.
6288         * aarch64-tdep.c: Revert.
6289         * aarch64-ravenscar-thread.c: Revert.
6290         * aarch64-newlib-tdep.c: Revert.
6291         * aarch64-linux-tdep.c: Revert.
6292         * aarch64-linux-nat.c: Revert.
6293         * aarch64-fbsd-tdep.c: Revert.
6294         * aarch64-fbsd-nat.c: Revert.
6295         * aarch32-linux-nat.c: Revert.
6296
6297 2019-04-05  Tom Tromey  <tom@tromey.com>
6298
6299         * ft32-tdep.c: Sort headers.
6300         * frv-tdep.c: Sort headers.
6301         * frv-linux-tdep.c: Sort headers.
6302         * frame.c: Sort headers.
6303         * frame-unwind.c: Sort headers.
6304         * frame-base.c: Sort headers.
6305         * fork-child.c: Sort headers.
6306         * findvar.c: Sort headers.
6307         * findcmd.c: Sort headers.
6308         * filesystem.c: Sort headers.
6309         * filename-seen-cache.h: Sort headers.
6310         * filename-seen-cache.c: Sort headers.
6311         * fbsd-tdep.c: Sort headers.
6312         * fbsd-nat.h: Sort headers.
6313         * fbsd-nat.c: Sort headers.
6314         * f-valprint.c: Sort headers.
6315         * f-typeprint.c: Sort headers.
6316         * f-lang.c: Sort headers.
6317         * extension.h: Sort headers.
6318         * extension.c: Sort headers.
6319         * extension-priv.h: Sort headers.
6320         * expprint.c: Sort headers.
6321         * exec.h: Sort headers.
6322         * exec.c: Sort headers.
6323         * exceptions.c: Sort headers.
6324         * event-top.c: Sort headers.
6325         * event-loop.c: Sort headers.
6326         * eval.c: Sort headers.
6327         * elfread.c: Sort headers.
6328         * dwarf2read.h: Sort headers.
6329         * dwarf2read.c: Sort headers.
6330         * dwarf2loc.c: Sort headers.
6331         * dwarf2expr.h: Sort headers.
6332         * dwarf2expr.c: Sort headers.
6333         * dwarf2-frame.c: Sort headers.
6334         * dwarf2-frame-tailcall.c: Sort headers.
6335         * dwarf-index-write.h: Sort headers.
6336         * dwarf-index-write.c: Sort headers.
6337         * dwarf-index-common.c: Sort headers.
6338         * dwarf-index-cache.h: Sort headers.
6339         * dwarf-index-cache.c: Sort headers.
6340         * dummy-frame.c: Sort headers.
6341         * dtrace-probe.c: Sort headers.
6342         * disasm.h: Sort headers.
6343         * disasm.c: Sort headers.
6344         * disasm-selftests.c: Sort headers.
6345         * dictionary.c: Sort headers.
6346         * dicos-tdep.c: Sort headers.
6347         * demangle.c: Sort headers.
6348         * dcache.h: Sort headers.
6349         * dcache.c: Sort headers.
6350         * darwin-nat.h: Sort headers.
6351         * darwin-nat.c: Sort headers.
6352         * darwin-nat-info.c: Sort headers.
6353         * d-valprint.c: Sort headers.
6354         * d-namespace.c: Sort headers.
6355         * d-lang.c: Sort headers.
6356         * ctf.c: Sort headers.
6357         * csky-tdep.c: Sort headers.
6358         * csky-linux-tdep.c: Sort headers.
6359         * cris-tdep.c: Sort headers.
6360         * cris-linux-tdep.c: Sort headers.
6361         * cp-valprint.c: Sort headers.
6362         * cp-support.c: Sort headers.
6363         * cp-namespace.c: Sort headers.
6364         * cp-abi.c: Sort headers.
6365         * corelow.c: Sort headers.
6366         * corefile.c: Sort headers.
6367         * continuations.c: Sort headers.
6368         * completer.h: Sort headers.
6369         * completer.c: Sort headers.
6370         * complaints.c: Sort headers.
6371         * coffread.c: Sort headers.
6372         * coff-pe-read.c: Sort headers.
6373         * cli-out.h: Sort headers.
6374         * cli-out.c: Sort headers.
6375         * charset.c: Sort headers.
6376         * c-varobj.c: Sort headers.
6377         * c-valprint.c: Sort headers.
6378         * c-typeprint.c: Sort headers.
6379         * c-lang.c: Sort headers.
6380         * buildsym.c: Sort headers.
6381         * buildsym-legacy.c: Sort headers.
6382         * build-id.h: Sort headers.
6383         * build-id.c: Sort headers.
6384         * btrace.c: Sort headers.
6385         * bsd-uthread.c: Sort headers.
6386         * breakpoint.h: Sort headers.
6387         * breakpoint.c: Sort headers.
6388         * break-catch-throw.c: Sort headers.
6389         * break-catch-syscall.c: Sort headers.
6390         * break-catch-sig.c: Sort headers.
6391         * blockframe.c: Sort headers.
6392         * block.c: Sort headers.
6393         * bfin-tdep.c: Sort headers.
6394         * bfin-linux-tdep.c: Sort headers.
6395         * bfd-target.c: Sort headers.
6396         * bcache.c: Sort headers.
6397         * ax-general.c: Sort headers.
6398         * ax-gdb.h: Sort headers.
6399         * ax-gdb.c: Sort headers.
6400         * avr-tdep.c: Sort headers.
6401         * auxv.c: Sort headers.
6402         * auto-load.c: Sort headers.
6403         * arm-wince-tdep.c: Sort headers.
6404         * arm-tdep.c: Sort headers.
6405         * arm-symbian-tdep.c: Sort headers.
6406         * arm-pikeos-tdep.c: Sort headers.
6407         * arm-obsd-tdep.c: Sort headers.
6408         * arm-nbsd-tdep.c: Sort headers.
6409         * arm-nbsd-nat.c: Sort headers.
6410         * arm-linux-tdep.c: Sort headers.
6411         * arm-linux-nat.c: Sort headers.
6412         * arm-fbsd-tdep.c: Sort headers.
6413         * arm-fbsd-nat.c: Sort headers.
6414         * arm-bsd-tdep.c: Sort headers.
6415         * arch-utils.c: Sort headers.
6416         * arc-tdep.c: Sort headers.
6417         * arc-newlib-tdep.c: Sort headers.
6418         * annotate.h: Sort headers.
6419         * annotate.c: Sort headers.
6420         * amd64-windows-tdep.c: Sort headers.
6421         * amd64-windows-nat.c: Sort headers.
6422         * amd64-tdep.c: Sort headers.
6423         * amd64-sol2-tdep.c: Sort headers.
6424         * amd64-obsd-tdep.c: Sort headers.
6425         * amd64-obsd-nat.c: Sort headers.
6426         * amd64-nbsd-tdep.c: Sort headers.
6427         * amd64-nbsd-nat.c: Sort headers.
6428         * amd64-nat.c: Sort headers.
6429         * amd64-linux-tdep.c: Sort headers.
6430         * amd64-linux-nat.c: Sort headers.
6431         * amd64-fbsd-tdep.c: Sort headers.
6432         * amd64-fbsd-nat.c: Sort headers.
6433         * amd64-dicos-tdep.c: Sort headers.
6434         * amd64-darwin-tdep.c: Sort headers.
6435         * amd64-bsd-nat.c: Sort headers.
6436         * alpha-tdep.c: Sort headers.
6437         * alpha-obsd-tdep.c: Sort headers.
6438         * alpha-nbsd-tdep.c: Sort headers.
6439         * alpha-mdebug-tdep.c: Sort headers.
6440         * alpha-linux-tdep.c: Sort headers.
6441         * alpha-linux-nat.c: Sort headers.
6442         * alpha-bsd-tdep.c: Sort headers.
6443         * alpha-bsd-nat.c: Sort headers.
6444         * aix-thread.c: Sort headers.
6445         * agent.c: Sort headers.
6446         * addrmap.c: Sort headers.
6447         * ada-varobj.c: Sort headers.
6448         * ada-valprint.c: Sort headers.
6449         * ada-typeprint.c: Sort headers.
6450         * ada-tasks.c: Sort headers.
6451         * ada-lang.c: Sort headers.
6452         * aarch64-tdep.c: Sort headers.
6453         * aarch64-ravenscar-thread.c: Sort headers.
6454         * aarch64-newlib-tdep.c: Sort headers.
6455         * aarch64-linux-tdep.c: Sort headers.
6456         * aarch64-linux-nat.c: Sort headers.
6457         * aarch64-fbsd-tdep.c: Sort headers.
6458         * aarch64-fbsd-nat.c: Sort headers.
6459         * aarch32-linux-nat.c: Sort headers.
6460
6461 2019-04-04  Tom Tromey  <tom@tromey.com>
6462
6463         * varobj.c (varobj_create): Update.
6464         * rust-exp.y (struct rust_parser) <update_innermost_block,
6465         lookup_symbol>: New methods.
6466         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6467         Rename.
6468         (rust_parser::rust_lookup_type)
6469         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6470         * printcmd.c (display_command, do_one_display): Update.
6471         * parser-defs.h (struct parser_state) <parser_state>: Add
6472         "tracker" parameter.
6473         (block_tracker): New member.
6474         (class innermost_block_tracker) <innermost_block_tracker>: Add
6475         "types" parameter.
6476         <reset>: Remove method.
6477         (innermost_block): Don't declare.
6478         (null_post_parser): Update.
6479         * parse.c (innermost_block): Remove global.
6480         (write_dollar_variable): Update.
6481         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6482         Remove "tracker_types" parameter.
6483         (parse_expression): Add "tracker" parameter.
6484         (parse_expression_for_completion): Update.
6485         (null_post_parser): Add "tracker" parameter.
6486         * p-exp.y: Update rules.
6487         * m2-exp.y: Update rules.
6488         * language.h (struct language_defn) <la_post_parser>: Add
6489         "tracker" parameter.
6490         * go-exp.y: Update rules.
6491         * f-exp.y: Update rules.
6492         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6493         parameter.
6494         * d-exp.y: Update rules.
6495         * c-exp.y: Update rules.
6496         * breakpoint.c (set_breakpoint_condition): Create an
6497         innermost_block_tracker.
6498         (watch_command_1): Likewise.
6499         * ada-lang.c (resolve): Add "tracker" parameter.
6500         (resolve_subexp): Likewise.
6501         * ada-exp.y (write_var_from_sym): Update.
6502
6503 2019-04-04  Tom Tromey  <tom@tromey.com>
6504
6505         * type-stack.h: New file.
6506         * type-stack.c: New file.
6507         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6508         type-stack.h.
6509         (insert_into_type_stack, insert_type, push_type, push_type_int)
6510         (insert_type_address_space, pop_type, pop_type_int)
6511         (pop_typelist, pop_type_stack, append_type_stack)
6512         (push_type_stack, get_type_stack, push_typelist)
6513         (follow_type_instance_flags, follow_types): Don't declare.
6514         * parse.c (type_stack): Remove global.
6515         (parse_exp_in_context): Update.
6516         (insert_into_type_stack, insert_type, push_type, push_type_int)
6517         (insert_type_address_space, pop_type, pop_type_int)
6518         (pop_typelist, pop_type_stack, append_type_stack)
6519         (push_type_stack, get_type_stack, push_typelist)
6520         (follow_type_instance_flags, follow_types): Remove (moved to
6521         type-stack.c).
6522         * f-exp.y (type_stack): New global.
6523         Update rules.
6524         (push_kind_type, f_parse): Update.
6525         * d-exp.y (type_stack): New global.
6526         Update rules.
6527         (d_parse): Update.
6528         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6529         Update rules.
6530         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6531         (HFILES_NO_SRCDIR): Add type-stack.h.
6532
6533 2019-04-04  Tom Tromey  <tom@tromey.com>
6534
6535         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6536         (rust_parser::convert_ast_to_expression, rust_parse)
6537         (rust_lex_test_completion, rust_lex_tests): Update.
6538         * parser-defs.h (struct expr_completion_state): New.
6539         (struct parser_state) <parser_state>: Add completion parameter.
6540         <mark_struct_expression, mark_completion_tag>: New methods.
6541         <parse_completion, m_completion_state>: New members.
6542         (prefixify_expression, null_post_parser): Update.
6543         (mark_struct_expression, mark_completion_tag): Don't declare.
6544         * parse.c (parse_completion, expout_last_struct)
6545         (expout_tag_completion_type, expout_completion_name): Remove
6546         globals.
6547         (parser_state::mark_struct_expression)
6548         (parser_state::mark_completion_tag): Now methods.
6549         (prefixify_expression): Add last_struct parameter.
6550         (prefixify_subexp): Likewise.
6551         (parse_exp_1): Update.
6552         (parse_exp_in_context): Add cstate parameter.  Update.
6553         (parse_expression_for_completion): Create an
6554         expr_completion_state.
6555         (null_post_parser): Add "completion" parameter.
6556         * p-exp.y: Update rules.
6557         (yylex): Update.
6558         * language.h (struct language_defn) <la_post_parser>: Add
6559         "completing" parameter.
6560         * go-exp.y: Update rules.
6561         (lex_one_token): Update.
6562         * expression.h (parse_completion): Don't declare.
6563         * d-exp.y: Update rules.
6564         (lex_one_token): Update rules.
6565         * c-exp.y: Update rules.
6566         (lex_one_token): Update.
6567         * ada-lang.c (resolve): Add "parse_completion" parameter.
6568         (resolve_subexp): Likewise.
6569         (ada_resolve_function): Likewise.
6570
6571 2019-04-04  Tom Tromey  <tom@tromey.com>
6572
6573         * parser-defs.h (struct parser_state) <start_arglist,
6574         end_arglist>: New methods.
6575         <arglist_len, m_funcall_chain>: New members.
6576         (arglist_len, start_arglist, end_arglist): Don't declare.
6577         * parse.c (arglist_len, funcall_chain): Remove global.
6578         (start_arglist, end_arglist): Remove functions.
6579         (parse_exp_in_context): Update.
6580         * p-exp.y: Update rules.
6581         * m2-exp.y: Update rules.
6582         * go-exp.y: Update rules.
6583         * f-exp.y: Update rules.
6584         * d-exp.y: Update rules.
6585         * c-exp.y: Update rules.
6586
6587 2019-04-04  Tom Tromey  <tom@tromey.com>
6588
6589         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6590         lex_operator, push_back>: New methods.
6591         Update all rules.
6592         (rust_parser::lex_hex, lex_escape): Rename and update.
6593         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6594         (rust_parser::lex_operator): Rename and update.
6595         (rust_parser::lex_number, rustyylex, rustyyerror)
6596         (rust_lex_test_init, rust_lex_test_sequence)
6597         (rust_lex_test_push_back, rust_lex_tests): Update.
6598         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6599         parameter.
6600         <lexptr, prev_lexptr>: New members.
6601         (lexptr, prev_lexptr): Don't declare.
6602         * parse.c (lexptr, prev_lexptr): Remove globals.
6603         (parse_exp_in_context): Update.
6604         * p-exp.y (yylex, yyerror): Update.
6605         * m2-exp.y (parse_number, yylex, yyerror): Update.
6606         * go-exp.y (lex_one_token, yyerror): Update.
6607         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6608         * d-exp.y (lex_one_token, yyerror): Update.
6609         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6610         (lex_one_token, yyerror): Update.
6611         * ada-lex.l (YY_INPUT): Update.
6612         (rewind_to_char): Update.
6613         * ada-exp.y (yyerror): Update.
6614
6615 2019-04-04  Tom Tromey  <tom@tromey.com>
6616
6617         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6618         * parser-defs.h (struct parser_state) <parser_state>: Add new
6619         parameter.
6620         <comma_terminates>: New member.
6621         (comma_terminates): Don't declare global.
6622         * parse.c (comma_terminates): Remove global.
6623         (parse_exp_in_context): Update.
6624         * p-exp.y (yylex): Update.
6625         * m2-exp.y (yylex): Update.
6626         * go-exp.y (lex_one_token): Update.
6627         * f-exp.y (yylex): Update.
6628         * d-exp.y (lex_one_token): Update.
6629         * c-exp.y (lex_one_token): Update.
6630         * ada-lex.l: Update.
6631
6632 2019-04-04  Tom Tromey  <tom@tromey.com>
6633
6634         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6635         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6636         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6637         * parser-defs.h (paren_depth): Don't declare.
6638         * parse.c (paren_depth): Remove global.
6639         (parse_exp_in_context): Update.
6640         * p-exp.y (paren_depth): New global.
6641         (pascal_parse): Initialize it.
6642         * m2-exp.y (paren_depth): New global.
6643         (m2_parse): Initialize it.
6644         * go-exp.y (paren_depth): New global.
6645         (go_parse): Initialize it.
6646         * f-exp.y (paren_depth): New global.
6647         (f_parse): Initialize it.
6648         * d-exp.y (paren_depth): New global.
6649         (d_parse): Initialize it.
6650         * c-exp.y (paren_depth): New global.
6651         (c_parse): Initialize it.
6652         * ada-lex.l (paren_depth): New global.
6653         (lexer_init): Initialize it.
6654
6655 2019-04-04  Tom Tromey  <tom@tromey.com>
6656
6657         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6658         (rust_parser::convert_ast_to_type)
6659         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6660         * parser-defs.h (struct parser_state) <parser_state>: Add
6661         parameters.  Initialize new members.
6662         <expression_context_block, expression_context_pc>: New members.
6663         * parse.c (expression_context_block, expression_context_pc):
6664         Remove globals.
6665         (parse_exp_in_context): Update.
6666         * p-exp.y: Update all rules.
6667         (yylex): Update.
6668         * m2-exp.y: Update all rules.
6669         (yylex): Update.
6670         * go-exp.y (yylex): Update.
6671         * f-exp.y (yylex): Update.
6672         * d-exp.y: Update all rules.
6673         (yylex): Update.
6674         * c-exp.y: Update all rules.
6675         (lex_one_token, classify_name, yylex, c_parse): Update.
6676         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6677
6678 2019-04-04  Tom Tromey  <tom@tromey.com>
6679
6680         * gdbarch.h, gdbarch.c: Rebuild.
6681         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6682         * stap-probe.h:
6683         (struct stap_parse_info): Replace "parser_state" with
6684         "expr_builder".
6685         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6686         (parser_state): New class.
6687         * parse.c (expr_builder): Rename.
6688         (expr_builder::release): Rename.
6689         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6690         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6691         (write_exp_elt_longcst, write_exp_elt_floatcst)
6692         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6693         (write_exp_string_vector, write_exp_bitstring)
6694         (write_exp_msymbol, mark_struct_expression)
6695         (write_dollar_variable)
6696         (insert_type_address_space, increase_expout_size): Replace
6697         "parser_state" with "expr_builder".
6698         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6699         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6700         "parser_state" with "expr_builder".
6701
6702 2019-04-04  Tom Tromey  <tom@tromey.com>
6703
6704         * rust-exp.y: Replace "parse_language" with method call.
6705         * p-exp.y:
6706         (yylex): Replace "parse_language" with method call.
6707         * m2-exp.y:
6708         (yylex): Replace "parse_language" with method call.
6709         * go-exp.y (classify_name): Replace "parse_language" with method
6710         call.
6711         * f-exp.y (yylex): Replace "parse_language" with method call.
6712         * d-exp.y (lex_one_token): Replace "parse_language" with method
6713         call.
6714         * c-exp.y:
6715         (lex_one_token, classify_name, yylex): Replace "parse_language"
6716         with method call.
6717         * ada-exp.y (find_primitive_type, type_char)
6718         (type_system_address): Replace "parse_language" with method call.
6719
6720 2019-04-04  Tom Tromey  <tom@tromey.com>
6721
6722         * rust-exp.y: Replace "parse_gdbarch" with method call.
6723         * parse.c (write_dollar_variable, insert_type_address_space):
6724         Replace "parse_gdbarch" with method call.
6725         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6726         call.
6727         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6728         call.
6729         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6730         "parse_gdbarch" with method call.
6731         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6732         with method call.
6733         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6734         "parse_gdbarch" with method call.
6735         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6736         "parse_gdbarch" with method call.
6737         * c-exp.y (parse_type, parse_number, classify_name): Replace
6738         "parse_gdbarch" with method call.
6739         * ada-lex.l: Replace "parse_gdbarch" with method call.
6740         * ada-exp.y (parse_type, find_primitive_type, type_char)
6741         (type_system_address): Replace "parse_gdbarch" with method call.
6742
6743 2019-04-04  Tom Tromey  <tom@tromey.com>
6744
6745         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6746         * stap-probe.c (stap_parse_argument): Update.
6747         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6748         initial_size parameter.
6749         * rust-exp.y (rust_lex_tests): Update.
6750         * parse.c (parser_state): Update.
6751         (parse_exp_in_context): Update.
6752         * parser-defs.h (struct parser_state) <parser_state>: Remove
6753         "initial_size" parameter.
6754
6755 2019-04-04  Tom Tromey  <tom@tromey.com>
6756
6757         * parser-defs.h (increase_expout_size): Don't declare.
6758         * parse.c (increase_expout_size): Now static.
6759
6760 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6761
6762         * gnu-nat.c (gnu_nat_target::wait): Fix
6763         target_waitstatus_to_string call.
6764
6765 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6766
6767         * eval.c (evaluate_subexp_standard): Handle internal functions
6768         during Fortran function call handling.
6769
6770 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6771
6772         * NEWS: Mention new internal functions.
6773         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6774         (read_base_type): Use dwarf2_init_complex_target_type.
6775         * value.c (creal_internal_fn): New function.
6776         (cimag_internal_fn): New function.
6777         (_initialize_values): Register new internal functions.
6778
6779 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6780
6781         * infrun.c (stop_all_threads): If debug_infrun, always
6782         trace the wait status after wait_one, using
6783         target_waitstatus_to_string and target_pid_to_str.
6784         (handle_inferior_event): Replace various trace of
6785         wait status kind by a single trace.
6786         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6787         wait status kind image by target_waitstatus_to_string.
6788         * target/waitstatus.c (target_waitstatus_to_string): Fix
6789         obsolete comment.
6790
6791 2019-04-01  Tom Tromey  <tromey@adacore.com>
6792
6793         PR symtab/23331:
6794         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6795
6796 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6797             Pedro Alves  <palves@redhat.com>
6798
6799         * top.c (quit_force): Call 'finalize_values'.
6800         * value.c (finalize_values): New function.
6801         * value.h (finalize_values): Declare.
6802
6803 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6804
6805         * NEWS: Announce $_gdb_major and $_gdb_minor.
6806
6807         * top.c (init_gdb_version_vars): New function.
6808         (gdb_init): Call init_gdb_version_vars.
6809
6810 2019-03-29  Tom Tromey  <tromey@adacore.com>
6811
6812         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6813         help text.  Remove dead code.
6814
6815 2019-03-29  Keith Seitz  <keiths@redhat.com>
6816
6817         From Siddhesh Poyarekar:
6818         * f-lang.h (f77_get_upperbound): Return LONGEST.
6819         (f77_get_lowerbound): Likewise.
6820         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6821         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6822         print them.
6823         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6824         plongest to format print it.
6825         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6826         (f77_get_upperbound): Likewise.
6827         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6828         LOWER_BOUND to LONGEST.
6829         (f77_create_arrayprint_offset_tbl): Likewise.
6830
6831 2019-03-29  Keith Seitz  <keiths@redhat.com>
6832
6833         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6834         %s/pulongest for TYPE_LENGTH instead of %d in format
6835         strings.
6836         * ada-typerint.c (ada_print_type): Likewise.
6837         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6838         * compile/compile-c-support.c (generate_register_struct): Likewise.
6839         * gdbtypes.c (recursive_dump_type): Likewise.
6840         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6841         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6842         instead of %d in format strings.
6843         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6844         to std::min to ULONGEST.
6845         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6846         instead of %d in format strings.
6847         * tracepoint.c (info_scope_command): Likewise.
6848         * typeprint.c (print_offset_data::update)
6849         (print_offset_data::finish): Likewise.
6850         * xtensa-tdep.c (xtensa_store_return_value)
6851         (xtensa_push_dummy_call): Likewise.
6852
6853 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6854
6855         * windows-nat.c (display_selector): Fixed format specifications
6856         for 64-bit Cygwin.
6857
6858 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6859
6860         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6861
6862 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6863
6864         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6865         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6866         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6867         (nios2_linux_init_abi): Install it.
6868
6869 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6870
6871         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6872
6873 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6874
6875         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6876
6877 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6878             Tom Tromey  <tromey@adacore.com>
6879
6880         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6881
6882 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6883
6884         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6885         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6886         method to compute the bounds of range types. Also print "[evaluated]"
6887         if the bounds' values come from a dynamic evaluation.
6888
6889 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6892         whitespace when pretty printing is on.
6893
6894 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6895
6896         * ppc-linux-nat.c: Add include.
6897
6898 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6899
6900         * NEWS: Mention AArch64 Pointer Authentication.
6901
6902 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6903
6904         * arm-linux-nat.c: Add include.
6905
6906 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6907
6908         * source-cache.c (source_cache::get_source_lines): Re-read
6909         fullname after calling open_source_file.
6910
6911 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6912
6913         * NEWS: Mention TLS support for FreeBSD.
6914
6915 2019-03-25  Tom Tromey  <tromey@adacore.com>
6916
6917         * minsyms.c (BUNCH_SIZE): Update comment.
6918         (~minimal_symbol_reader): Remove old comment.
6919         (compact_minimal_symbols): Update comment.
6920         (minimal_symbol_reader::install): Remove old comment.  Update
6921         other comments.
6922
6923 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6924
6925         * s390-linux-nat.c: Add include.
6926
6927 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6928
6929         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6930         Call linux_get_hwcap.
6931         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6932         Likewise.
6933         (aarch64_linux_get_hwcap): Remove function.
6934         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6935         declaration.
6936         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6937         linux_get_hwcap.
6938         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6939         * linux-tdep.c (linux_get_hwcap): Add function.
6940         (linux_get_hwcap2): Likewise.
6941         * linux-tdep.h (linux_get_hwcap): Add declaration.
6942         (linux_get_hwcap2): Likewise.
6943         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6944         (ppc_linux_get_hwcap2): Likewise.
6945         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6946         linux_get_hwcap.
6947         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6948         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6949         (ppc_linux_nat_target::read_description): Likewise.
6950         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6951         * s390-linux-nat.c: Likewise.
6952         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6953
6954 2019-03-24  Tom Tromey  <tom@tromey.com>
6955
6956         * ada-lang.c (standard_lookup): Simplify initialization.
6957         (ada_lookup_symbol_nonlocal): Simplify return.
6958         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6959         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6960         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6961         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6962         initialization.
6963         * solib.c (solib_global_lookup): Simplify.
6964         * symtab.c (null_block_symbol): Remove.
6965         (symbol_cache_lookup): Simplify returns.
6966         (lookup_language_this): Simplify returns.
6967         (lookup_symbol_aux): Simplify return.
6968         (lookup_local_symbol): Simplify returns.
6969         (lookup_global_symbol_from_objfile): Simplify return.
6970         (lookup_symbol_in_objfile_symtabs)
6971         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6972         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6973         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6974         * cp-namespace.c (cp_lookup_bare_symbol)
6975         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6976         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6977         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6978         (cp_lookup_symbol_via_imports): Simplify initialization.
6979         (find_symbol_in_baseclass): Likewise.
6980         * symtab.h (null_block_symbol): Remove.
6981         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6982         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6983         (d_lookup_symbol_module): Likewise.
6984         (find_symbol_in_baseclass): Simplify initialization.
6985
6986 2019-03-24  Tom Tromey  <tom@tromey.com>
6987
6988         * expression.h: Don't include symtab.h.
6989         (struct block): Forward declare.
6990
6991 2019-03-24  Tom Tromey  <tom@tromey.com>
6992
6993         * c-exp.y (typebase): Remove casts.
6994         * gdbtypes.c (lookup_unsigned_typename, )
6995         (lookup_signed_typename): Remove cast.
6996         * eval.c (parse_to_comma_and_eval): Remove cast.
6997         * parse.c (write_dollar_variable): Remove cast.
6998         * block.h (struct block) <superblock>: Now const.
6999         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7000         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7001         (map_block): Make "block" const.
7002         * symfile.h (struct quick_symbol_functions)
7003         <map_matching_symbols>: Constify block argument to "callback".
7004         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7005         const.
7006         (find_pc_sect_compunit_symtab): Make "b" const.
7007         (find_symbol_at_address): Likewise.
7008         (search_symbols): Likewise.
7009         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7010         (dw2_debug_names_lookup_symbol): Likewise.
7011         (dw2_map_matching_symbols): Update.
7012         * p-valprint.c (pascal_val_print): Remove "block".
7013         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7014         (aux_add_nonlocal_symbols): Make "block" const.
7015         (resolve_subexp): Remove cast.
7016         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7017         const.
7018         (iterate_over_file_blocks): Likewise.
7019         * f-exp.y (%union) <bval>: Remove.
7020         * coffread.c (patch_opaque_types): Make "b" const.
7021         * spu-tdep.c (spu_catch_start): Make "block" const.
7022         * c-valprint.c (print_unpacked_pointer): Remove "block".
7023         * symmisc.c (dump_symtab_1): Make "b" const.
7024         (block_depth): Make "block" const.
7025         * d-exp.y (%union) <bval>: Remove.
7026         * cp-support.h (cp_lookup_rtti_type): Update.
7027         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7028         * psymtab.c (psym_lookup_symbol): Make "block" const.
7029         (maintenance_check_psymtabs): Make "b" const.
7030         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7031         (enumerate_locals, enumerate_args): Update.
7032         * python/py-symtab.c (stpy_global_block): Make "block" const.
7033         (stpy_static_block): Likewise.
7034         * inline-frame.c (block_starting_point_at): Make "new_block"
7035         const.
7036         * block.c (find_block_in_blockvector): Make return type const.
7037         (blockvector_for_pc_sect): Make "b" const.
7038         (find_block_in_blockvector): Make "b" const.
7039
7040 2019-03-23  Tom Tromey  <tom@tromey.com>
7041
7042         * varobj.c (varobj_create): Update.
7043         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7044         * printcmd.c (display_command, do_one_display): Don't reset
7045         innermost_block.
7046         * parser-defs.h (enum innermost_block_tracker_type): Move to
7047         expression.h.
7048         (innermost_block): Update comment.
7049         * parse.c (parse_exp_1): Add tracker_types parameter.
7050         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7051         tracker_types parameter.  Reset innermost_block.
7052         (parse_exp_in_context): Remove.
7053         (parse_expression_for_completion): Update.
7054         * objfiles.c (~objfile): Don't reset expression_context_block or
7055         innermost_block.
7056         * expression.h (enum innermost_block_tracker_type): Move from
7057         parser-defs.h.
7058         (parse_exp_1): Add tracker_types parameter.
7059         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7060         reset innermost_block.
7061
7062 2019-03-23  Tom Tromey  <tom@tromey.com>
7063
7064         * objfiles.h: Include bcache.h.
7065
7066 2019-03-23  Tom Tromey  <tom@tromey.com>
7067
7068         * linespec.c (get_current_search_block): Use
7069         scoped_restore_current_language.
7070         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7071
7072 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7073             Jiong Wang  <jiong.wang@arm.com>
7074
7075         * aarch64-linux-tdep.c
7076         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7077         section.
7078         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7079
7080 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7081             Jiong Wang  <jiong.wang@arm.com>
7082
7083         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7084         instructions.
7085         (aarch64_analyze_prologue_test): Add PACIASP test.
7086         (aarch64_prologue_prev_register): Unmask PC value.
7087
7088 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7089             Jiong Wang  <jiong.wang@arm.com>
7090
7091         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7092         (aarch64_dwarf2_prev_register): Unmask PC value.
7093         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7094         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7095         DW_CFA_AARCH64_negate_ra_state.
7096         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7097
7098 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7099             Jiong Wang  <jiong.wang@arm.com>
7100
7101         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7102         registers.
7103         (aarch64_pseudo_register_name): Likewise.
7104         (aarch64_pseudo_register_type): Likewise.
7105         (aarch64_pseudo_register_reggroup_p): Likewise.
7106         (aarch64_gdbarch_init): Add pauth registers.
7107         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7108         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7109         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7110         (struct gdbarch_tdep): Add regnum for ra_state.
7111
7112 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7113             Jiong Wang  <jiong.wang@arm.com>
7114
7115         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7116
7117 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7118             Jiong Wang  <jiong.wang@arm.com>
7119
7120         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7121         function.
7122         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7123         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7124         (aarch64_gdbarch_init): Add puth registers.
7125         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7126         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7127         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7128
7129 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7130             Jiong Wang  <jiong.wang@arm.com>
7131
7132         * aarch64-linux-nat.c
7133         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7134         * aarch64-linux-tdep.c
7135         (aarch64_linux_core_read_description): Likewise.
7136         (aarch64_linux_get_hwcap): New function.
7137         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7138         (aarch64_linux_get_hwcap): New declaration.
7139
7140 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7141             Jiong Wang  <jiong.wang@arm.com>
7142
7143         * aarch64-linux-nat.c
7144         (aarch64_linux_nat_target::read_description): Add pauth param.
7145         * aarch64-linux-tdep.c
7146         (aarch64_linux_core_read_description): Likewise.
7147         * aarch64-tdep.c (struct target_desc): Add in pauth.
7148         (aarch64_read_description): Add pauth param.
7149         (aarch64_gdbarch_init): Likewise.
7150         * aarch64-tdep.h (aarch64_read_description): Likewise.
7151         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7152         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7153         * features/Makefile: Add new files.
7154         * features/aarch64-pauth.c: New file.
7155         * features/aarch64-pauth.xml: New file.
7156
7157 2019-03-20  Tom Tromey  <tromey@adacore.com>
7158
7159         * infrun.c (handle_inferior_event): Rename from
7160         handle_inferior_event_1.  Create a scoped_value_mark.
7161         (handle_inferior_event): Remove.
7162
7163 2019-03-19  Tom Tromey  <tromey@adacore.com>
7164
7165         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7166         * infrun.h (print_stop_event): Add "displays" parameter.
7167         * infrun.c (print_stop_event): Add "displays" parameter.
7168
7169 2019-03-19  Pedro Alves  <palves@redhat.com>
7170
7171         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7172         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7173         to -1.  Fix TABs vs spaces.
7174         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7175         * tui/tui-out.h (tui_ui_out) Add intro comments.
7176         <m_line, m_start_of_line>: In-class initialize, and add describing
7177         comment.
7178
7179 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7180
7181         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7182         variable names.
7183         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7184
7185 2019-03-18  Pedro Alves  <palves@redhat.com>
7186             Eli Zaretskii <eliz@gnu.org>
7187
7188         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7189         m_line and m_start_of_line.
7190
7191 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7192
7193         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7194         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7195         it returns a newline.  This fixes a regression in TU mode, whereby
7196         the next line is output on the same screen line as the user input.
7197
7198 2019-03-18  Tom Tromey  <tromey@adacore.com>
7199
7200         * minsyms.c (minimal_symbol_reader::install): Remove call to
7201         obstack_blank.
7202
7203 2019-03-18  Pedro Alves  <palves@redhat.com>
7204
7205         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7206         New globals.
7207         (apply_style): New, factored out from ...
7208         (apply_ansi_escape): ... this.  Handle reverse video mode.
7209         (tui_set_reverse_mode): New function.
7210         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7211         * tui/tui-winsource.c (tui_show_source_line): Use
7212         tui_set_reverse_mode instead of setting A_STANDOUT.
7213         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7214         New setter methods.
7215
7216 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7217
7218         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7219         Handle tabs.
7220
7221 2019-03-18  Tom Tromey  <tromey@adacore.com>
7222
7223         * ada-lang.c (empty_array): Add "high" parameter.
7224         (ada_evaluate_subexp): Update.
7225
7226 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7227
7228         * unittests/string_view-selftests.c: Define
7229         _initialize_string_view_selftests unconditionally.
7230
7231 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7232
7233         PR gdb/24350
7234         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7235
7236 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7237
7238         PR gdb/24351
7239         * windows-nat.c (display_selector): Fix format specifiers.
7240
7241 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7242
7243         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7244         tui_refill_source_window instead of tui_refresh_win, to update the
7245         current execution line.  This fixes redisplay of the current line
7246         when stepping through the code with "next" or "step".
7247
7248 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7249
7250         * source-cache.c (source_cache::get_source_lines): Call
7251         find_source_lines to initialize s->nlines.  This fixes vertical
7252         scrolling of TUI source window when the DOWN arrow is pressed.
7253
7254 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7255
7256         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7257         linux-thread-db.c (_initialize_thread_db): Likewise.
7258
7259 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7260
7261         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7262         wclrtoeol in tui_show_source_line".  This reverts changes made in
7263         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7264
7265 2019-03-15  Tom Tromey  <tom@tromey.com>
7266
7267         * symtab.h (struct minimal_symbol): Derive from
7268         general_symbol_info.
7269         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7270         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7271         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7272         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7273         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7274         (MSYMBOL_SEARCH_NAME): Update.
7275         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7276         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7277         * minsyms.c (minimal_symbol_reader::record_full): Update.
7278
7279 2019-03-15  Tom Tromey  <tom@tromey.com>
7280
7281         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7282
7283 2019-03-15  Tom Tromey  <tom@tromey.com>
7284
7285         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7286         unique_xmalloc_ptr.
7287         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7288         Update.
7289         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7290         (build_minimal_symbol_hash_tables)
7291         (minimal_symbol_reader::install): Update.
7292
7293 2019-03-15  Tom Tromey  <tom@tromey.com>
7294
7295         * symtab.c (create_demangled_names_hash): Update.
7296         (symbol_set_names): Update.
7297         * objfiles.h (struct objfile_per_bfd_storage)
7298         <demangled_names_hash>: Now an htab_up.
7299         * objfiles.c (objfile_per_bfd_storage): Simplify.
7300
7301 2019-03-15  Tom Tromey  <tom@tromey.com>
7302
7303         * objfiles.h (struct objfile_per_bfd_storage): Declare
7304         destructor.
7305         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7306         New.
7307         (get_objfile_bfd_data): Use new.  Don't initialize
7308         language_of_main.
7309         (free_objfile_per_bfd_storage): Remove.
7310         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7311
7312 2019-03-15  Tom Tromey  <tom@tromey.com>
7313
7314         * symfile.c (reread_symbols): Update.
7315         * objfiles.c (objfile::objfile): Update.
7316         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7317         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7318         comment.
7319         (minimal_symbol_reader::install): Update.
7320         (terminate_minimal_symbol_table): Remove.
7321         * jit.c (jit_object_close_impl): Update.
7322
7323 2019-03-15  Tom Tromey  <tom@tromey.com>
7324
7325         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7326         initializations.
7327
7328 2019-03-15  Tom Tromey  <tom@tromey.com>
7329
7330         * objfiles.h (struct objfile_per_bfd_storage)
7331         <demangled_hash_languages>: Now a bitset.
7332         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7333         (lookup_minimal_symbol): Update.
7334
7335 2019-03-15  Tom Tromey  <tom@tromey.com>
7336
7337         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7338         Don't return the symbol.
7339         * coffread.c (record_minimal_symbol): Use record_full.
7340
7341 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7342
7343         The MS-Windows port of ncurses fails to switch to a color pair if
7344         one or both of the colors are the implicit default colors.  This
7345         change records the default colors when TUI is initialized, and
7346         then specifies them explicitly when a color pair uses the default
7347         colors.  This allows color styling in TUI mode on MS-Windows.
7348
7349         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7350         ncurses_norm_attr.
7351         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7352         colors in ncurses_norm_attr.
7353         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7354         "none", replace it with the default color recorded in
7355         ncurses_norm_attr.
7356
7357 2019-03-14  Tom Tromey  <tromey@adacore.com>
7358
7359         * source-cache.h (class source_cache) <get_source_lines>: Return
7360         std::string.
7361         * source-cache.c (source_cache::extract_lines): Handle case where
7362         first_pos==npos.  Return std::string.
7363         (source_cache::get_source_lines): Update.
7364
7365 2019-03-14  Tom Tromey  <tromey@adacore.com>
7366
7367         * NEWS: Add item for "style sources" commands.
7368         * source-cache.c (source_cache::get_source_lines): Check
7369         source_styling.
7370         * cli/cli-style.c (source_styling): New global.
7371         (_initialize_cli_style): Add "style sources" commands.
7372         (show_style_sources): New function.
7373         * cli/cli-style.h (source_styling): Declare.
7374
7375 2019-03-14  Pedro Alves  <palves@redhat.com>
7376             Tom Tromey  <tromey@adacore.com>
7377
7378         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7379         * tui/tui-winsource.c (tui_refill_source_window): New function,
7380         from...
7381         (tui_horizontal_source_scroll): ... here.  Move some logic.
7382         * cli/cli-style.c (set_style_enabled): Notify new observable.
7383         * tui/tui-hooks.c (tui_redisplay_source): New function.
7384         (tui_attach_detach_observers): Attach or detach
7385         tui_redisplay_source.
7386         * observable.h (source_styling_changed): New observable.
7387         * observable.c: Define source_styling_changed observable.
7388
7389 2019-03-13  Tom Tromey  <tromey@adacore.com>
7390
7391         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7392         (i386_gnu_nat_target::store_registers): Update.
7393         * target-debug.h (target_debug_print_std_string): New macro.
7394         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7395         * windows-tdep.c (display_one_tib): Update.
7396         * tui/tui-stack.c (tui_make_status_line): Update.
7397         * top.c (print_inferior_quit_action): Update.
7398         * thread.c (thr_try_catch_cmd): Update.
7399         (add_thread_with_info): Update.
7400         (thread_target_id_str): Update.
7401         (thr_try_catch_cmd): Update.
7402         (thread_command): Update.
7403         (thread_find_command): Update.
7404         * record-btrace.c (record_btrace_target::info_record)
7405         (record_btrace_resume_thread, record_btrace_target::resume)
7406         (record_btrace_cancel_resume, record_btrace_step_thread)
7407         (record_btrace_target::wait, record_btrace_target::wait)
7408         (record_btrace_target::wait, record_btrace_target::stop): Update.
7409         * progspace.c (print_program_space): Update.
7410         * process-stratum-target.c
7411         (process_stratum_target::thread_address_space): Update.
7412         * linux-fork.c (linux_fork_mourn_inferior)
7413         (detach_checkpoint_command, info_checkpoints_command)
7414         (linux_fork_context): Update.
7415         (linux_fork_detach): Update.
7416         (class scoped_switch_fork_info): Update.
7417         (delete_checkpoint_command): Update.
7418         * infrun.c (follow_fork_inferior): Update.
7419         (follow_fork_inferior): Update.
7420         (proceed_after_vfork_done): Update.
7421         (handle_vfork_child_exec_or_exit): Update.
7422         (follow_exec): Update.
7423         (displaced_step_prepare_throw): Update.
7424         (displaced_step_restore): Update.
7425         (start_step_over): Update.
7426         (resume_1): Update.
7427         (clear_proceed_status_thread): Update.
7428         (proceed): Update.
7429         (print_target_wait_results): Update.
7430         (do_target_wait): Update.
7431         (context_switch): Update.
7432         (stop_all_threads): Update.
7433         (restart_threads): Update.
7434         (finish_step_over): Update.
7435         (handle_signal_stop): Update.
7436         (switch_back_to_stepped_thread): Update.
7437         (keep_going_pass_signal): Update.
7438         (print_exited_reason): Update.
7439         (normal_stop): Update.
7440         * inferior.c (inferior_pid_to_str): Change return type.
7441         (print_selected_inferior): Update.
7442         (add_inferior): Update.
7443         (detach_inferior): Update.
7444         * dummy-frame.c (fprint_dummy_frames): Update.
7445         * dcache.c (dcache_info_1): Update.
7446         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7447         (btrace_fetch, btrace_clear): Update.
7448         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7449         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7450         type.
7451         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7452         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7453         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7454         * gdbarch.c, gdbarch.h: Rebuild.
7455         * gdbarch.sh (core_pid_to_str): Change return type.
7456         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7457         return type.
7458         (windows_nat_target::pid_to_str): Change return type.
7459         (windows_delete_thread): Update.
7460         (windows_nat_target::attach): Update.
7461         (windows_nat_target::files_info): Update.
7462         * target-delegates.c: Rebuild.
7463         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7464         return type.
7465         (sol_thread_target::pid_to_str): Change return type.
7466         * remote.c (class remote_target) <pid_to_str>: Change return
7467         type.
7468         (remote_target::pid_to_str): Change return type.
7469         (extended_remote_target::attach, remote_target::remote_stop_ns)
7470         (remote_target::remote_notif_remove_queued_reply)
7471         (remote_target::push_stop_reply, remote_target::disable_btrace):
7472         Update.
7473         (extended_remote_target::attach): Update.
7474         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7475         type.
7476         (gdbsim_target::pid_to_str): Change return type.
7477         * ravenscar-thread.c (struct ravenscar_thread_target)
7478         <pid_to_str>: Change return type.
7479         (ravenscar_thread_target::pid_to_str): Change return type.
7480         * procfs.c (class procfs_target) <pid_to_str>: Change return
7481         type.
7482         (procfs_target::pid_to_str): Change return type.
7483         (procfs_target::attach): Update.
7484         (procfs_target::detach): Update.
7485         (procfs_target::fetch_registers): Update.
7486         (procfs_target::store_registers): Update.
7487         (procfs_target::wait): Update.
7488         (procfs_target::files_info): Update.
7489         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7490         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7491         return type.
7492         (nto_procfs_target::pid_to_str): Change return type.
7493         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7494         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7495         return type.
7496         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7497         (exit_lwp): Update.
7498         (attach_proc_task_lwp_callback, get_detach_signal)
7499         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7500         (linux_nat_target::resume, wait_lwp, stop_callback)
7501         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7502         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7503         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7504         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7505         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7506         type.
7507         (inf_ptrace_target::attach): Update.
7508         (inf_ptrace_target::files_info): Update.
7509         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7510         type.
7511         (go32_nat_target::pid_to_str): Change return type.
7512         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7513         (gnu_nat_target::wait): Update.
7514         (gnu_nat_target::wait): Update.
7515         (gnu_nat_target::resume): Update.
7516         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7517         (fbsd_nat_target::wait): Update.
7518         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7519         type.
7520         (darwin_nat_target::attach): Update.
7521         * corelow.c (class core_target) <pid_to_str>: Change return type.
7522         (core_target::pid_to_str): Change return type.
7523         * target.c (normal_pid_to_str): Change return type.
7524         (default_pid_to_str): Likewise.
7525         (target_pid_to_str): Change return type.
7526         (target_translate_tls_address): Update.
7527         (target_announce_detach): Update.
7528         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7529         return type.
7530         (bsd_uthread_target::pid_to_str): Change return type.
7531         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7532         type.
7533         (bsd_kvm_target::pid_to_str): Change return type.
7534         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7535         return type.
7536         (aix_thread_target::pid_to_str): Change return type.
7537         * target.h (struct target_ops) <pid_to_str>: Change return type.
7538         (target_pid_to_str, normal_pid_to_str): Likewise.
7539         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7540         type.
7541         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7542         type.
7543         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7544         return type.
7545         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7546         type.
7547         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7548         type.
7549         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7550         return type.
7551
7552 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7553
7554         * NEWS: Mention that the new default MI version is 3.  Mention
7555         changes to the output of commands and events that deal with
7556         multi-location breakpoints.
7557         * breakpoint.c: Include "mi/mi-out.h".
7558         (print_one_breakpoint): Change output syntax if using MI version
7559         >= 3.
7560         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7561         New.
7562         (mi_multi_location_breakpoint_output_fixed): New.
7563         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7564         (mi_cmd_fix_multi_location_breakpoint_output): New.
7565         (mi_multi_location_breakpoint_output_fixed): New.
7566         * mi/mi-cmds.c (mi_cmds): Register command
7567         -fix-multi-location-breakpoint-output.
7568         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7569         interpreter "mi".
7570
7571 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7572
7573         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7574         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7575         instantiate mi_ui_out based on interpreter name.
7576         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7577         * mi/mi-main.c (mi_load_progress): Likewise.
7578
7579 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7580
7581         * NEWS: Combine separate "New targets" sections for 8.3.
7582
7583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7584
7585         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7586         (ppcfbsd_init_abi): Install gdbarch
7587         "fetch_tls_load_module_address" and "get_thread_local_address"
7588         methods.
7589
7590 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7591
7592         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7593         (riscv_fbsd_init_abi): Install gdbarch
7594         "fetch_tls_load_module_address" and "get_thread_local_address"
7595         methods.
7596
7597 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7598
7599         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7600         (i386fbsd_init_abi): Install gdbarch
7601         "fetch_tls_load_module_address" and "get_thread_local_address"
7602         methods.
7603
7604 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7605
7606         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7607         (amd64fbsd_init_abi): Install gdbarch
7608         "fetch_tls_load_module_address" and "get_thread_local_address"
7609         methods.
7610
7611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7612
7613         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7614         (struct fbsd_pspace_data): New type.
7615         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7616         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7617         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7618         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7619         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7620
7621 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7622
7623         * gdbtypes.c (lookup_struct_elt): New function.
7624         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7625         * gdbtypes.h (struct struct_elt): New type.
7626         (lookup_struct_elt): New prototype.
7627
7628 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7629
7630         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7631         remove disabled code block.
7632
7633 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7634
7635         * gdbarch.sh (get_thread_local_address): New method.
7636         * gdbarch.h, gdbarch.c: Regenerate.
7637         * target.c (target_translate_tls_address): Use
7638         gdbarch_get_thread_local_address if present instead of
7639         target::get_thread_local_address.
7640
7641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7642
7643         * target.h (target::get_thread_local_address): Update comment.
7644
7645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7646
7647         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7648         objfile->separate_debug_objfile_backlink if not NULL.
7649
7650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7651
7652         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7653         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7654         (amd64bsd_store_inferior_registers): Likewise.
7655         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7656         Enable segment base registers.
7657         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7658         PT_GETFSBASE and PT_GETGSBASE.
7659         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7660         PT_SETGSBASE.
7661         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7662         segment base registers.
7663         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7664
7665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7666
7667         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7668         Update calls to i386_target_description to add 'segments'
7669         parameter.
7670         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7671         add segment base registers.
7672         * arch/i386.c (i386_create_target_description): Add 'segments'
7673         parameter to enable segment base registers.
7674         * arch/i386.h (i386_create_target_description): Likewise.
7675         * features/i386/32bit-segments.xml: New file.
7676         * features/i386/32bit-segments.c: Generate.
7677         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7678         call to i386_target_description to add 'segments' parameter.
7679         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7680         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7681         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7682         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7683         if feature is present.
7684         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7685         Add 'segments' parameter to call to i386_target_description.
7686         (i386_target_description): Add 'segments' parameter to enable
7687         segment base registers.
7688         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7689         to call to i386_target_description.
7690         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7691         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7692         Define I386_NUM_REGS.
7693         (i386_target_description): Add 'segments' parameter to enable
7694         segment base registers.
7695
7696 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7697
7698         PR/24325
7699         * source-cache.c: #undef open and close, to avoid unresolved
7700         externals during linking.
7701
7702 2019-03-12  Tom Tromey  <tromey@adacore.com>
7703
7704         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7705         const.  Add initializers.
7706         (_initialize_remote): Don't initialize ptid globals.
7707
7708 2019-03-12  Pedro Alves  <palves@redhat.com>
7709
7710         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7711
7712 2019-03-12  Pedro Alves  <palves@redhat.com>
7713
7714         * cp-name-parser.y (main): Remove unused 'len' variable.
7715
7716 2019-03-12  Tom Tromey  <tromey@adacore.com>
7717
7718         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7719         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7720
7721 2019-03-12  Tom Tromey  <tromey@adacore.com>
7722
7723         * linux-nat.c (iterate_over_lwps): Update.
7724         (stop_callback): Remove parameter.
7725         (stop_wait_callback, detach_callback, resume_set_callback)
7726         (select_singlestep_lwp_callback, set_ignore_sigint)
7727         (status_callback, resumed_callback, resume_clear_callback)
7728         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7729         data parameter.
7730         (linux_nat_target::detach, linux_nat_target::resume)
7731         (linux_stop_and_wait_all_lwps, select_event_lwp)
7732         (linux_nat_filter_event, linux_nat_wait_1)
7733         (linux_nat_target::kill, linux_nat_target::stop)
7734         (linux_nat_target::stop): Update.
7735         (linux_nat_resume_callback): Change type.
7736         (resume_stopped_resumed_lwps, count_events_callback)
7737         (select_event_lwp_callback): Likewise.
7738         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7739         * arm-linux-nat.c (struct update_registers_data): Remove.
7740         (update_registers_callback): Change type.
7741         (arm_linux_insert_hw_breakpoint1): Update.
7742         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7743         parameter.
7744         (x86_linux_dr_set_addr): Update.
7745         (x86_linux_dr_set_control): Update.
7746         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7747         (iterate_over_lwps): Use gdb::function_view.
7748         * nat/aarch64-linux-hw-point.c (struct
7749         aarch64_dr_update_callback_param): Remove.
7750         (debug_reg_change_callback): Change type.
7751         (aarch64_notify_debug_reg_change): Update.
7752         * s390-linux-nat.c (s390_refresh_per_info): Update.
7753
7754 2019-03-11  Tom Tromey  <tromey@adacore.com>
7755
7756         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7757         redundant assignment to "this_cu".
7758
7759 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7760
7761         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7762
7763 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7764
7765         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7766         from...
7767         (rank_one_type): ... this.
7768
7769 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7770
7771         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7772         from...
7773         (rank_one_type): ... this.
7774
7775 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7776
7777         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7778         from...
7779         (rank_one_type): ... this.
7780
7781 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7782
7783         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7784         from...
7785         (rank_one_type): ... this.
7786
7787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7788
7789         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7790         from...
7791         (rank_one_type): ... this.
7792
7793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7794
7795         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7796         from...
7797         (rank_one_type): ... this.
7798
7799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7800
7801         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7802         from...
7803         (rank_one_type): ... this.
7804
7805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7806
7807         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7808         from...
7809         (rank_one_type): ... this.
7810
7811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7812
7813         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7814         from...
7815         (rank_one_type): ... this.
7816
7817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7818
7819         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7820         from...
7821         (rank_one_type): ... this.
7822
7823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7824
7825         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7826         from...
7827         (rank_one_type): ... this.
7828
7829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7830
7831         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7832         from...
7833         (rank_one_type): ... this.
7834
7835 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7836
7837         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7838         inferior-events' shows the example events.
7839
7840 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7841
7842         Support styling on native MS-Windows console
7843
7844         PR/24315
7845         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7846         on MS-Windows if $TERM is not defined.
7847
7848         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7849
7850         * posix-hdep.c (gdb_console_fputs):
7851         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7852         functions.
7853         * ui-file.h (gdb_console_fputs): Add prototype.
7854
7855         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7856         back to fputs only if the former returns zero.
7857
7858 2019-03-07  Tom Tromey  <tom@tromey.com>
7859
7860         * symmisc.c (print_symbol_bcache_statistics): Update.
7861         (print_objfile_statistics): Update.
7862         * symfile.c (allocate_symtab): Update.
7863         * stabsread.c: Don't include bcache.h.
7864         * psymtab.h (struct psymbol_bcache): Don't declare.
7865         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7866         (psymbol_bcache_init, psymbol_bcache_free)
7867         (psymbol_bcache_get_bcache): Don't declare.
7868         * psymtab.c (struct psymbol_bcache): Remove.
7869         (psymtab_storage::psymtab_storage): Update.
7870         (psymtab_storage::~psymtab_storage): Update.
7871         (psymbol_bcache_init, psymbol_bcache_free)
7872         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7873         (add_psymbol_to_bcache): Update.
7874         (allocate_psymtab): Update.
7875         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7876         macro_cache>: No longer pointers.
7877         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7878         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7879         * macrotab.c (macro_bcache): Update.
7880         * macroexp.c: Don't include bcache.h.
7881         * gdbtypes.c (check_types_worklist): Update.
7882         (types_deeply_equal): Remove TRY/CATCH.  Update.
7883         * elfread.c (elf_symtab_read): Update.
7884         * dwarf2read.c: Don't include bcache.h.
7885         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7886         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7887         (print_bcache_statistics, bcache_memory_used): Don't declare.
7888         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7889         methods.  Rename all data members.
7890         * bcache.c (struct bcache): Move to bcache.h.
7891         (bcache::expand_hash_table): Rename from expand_hash_table.
7892         (bcache): Remove.
7893         (bcache::insert): Rename from bcache_full.
7894         (bcache::compare): Rename from bcache_compare.
7895         (bcache_xmalloc): Remove.
7896         (bcache::~bcache): Rename from bcache_xfree.
7897         (bcache::print_statistics): Rename from print_bcache_statistics.
7898         (bcache::memory_used): Rename from bcache_memory_used.
7899
7900 2019-03-07  Pedro Alves  <palves@redhat.com>
7901
7902         * infrun.c (normal_stop): Also check for
7903         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7904
7905 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7906
7907         * f-lang.c (value_from_host_double): Moved to...
7908         * value.c (value_from_host_double): ...here.
7909         * value.h (value_from_host_double): Declare.
7910         * guile/scm-math.c (vlscm_convert_typed_number): Use
7911         value_from_host_double.
7912         (vlscm_convert_number): Likewise.
7913         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7914         * python/py-value.c (convert_value_from_python): Likewise.
7915
7916 2019-03-06  Tom Tromey  <tom@tromey.com>
7917
7918         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7919
7920 2019-03-06  Tom Tromey  <tom@tromey.com>
7921
7922         * utils.h (free_current_contents): Don't declare.
7923         * utils.c (free_current_contents): Remove.
7924
7925 2019-03-06  Tom Tromey  <tom@tromey.com>
7926
7927         * top.c (quit_force): Update.
7928         * main.c (captured_command_loop): Update.
7929         * common/new-op.c (operator new): Update.
7930         * common/common-exceptions.c (struct catcher)
7931         <save_cleanup_chain>: Remove member.
7932         (exceptions_state_mc_init): Update.
7933         (exception_try_scope_entry): Return nullptr.
7934         (exception_try_scope_exit, exception_rethrow)
7935         (throw_exception_sjlj, throw_exception_cxx): Update.
7936         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7937         (all_cleanups, do_cleanups, discard_cleanups)
7938         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7939         (restore_cleanups, restore_final_cleanups): Don't declare.
7940         (do_final_cleanups): Remove parameter.
7941         * common/cleanups.c (cleanup_chain, make_cleanup)
7942         (make_cleanup_dtor, all_cleanups, do_cleanups)
7943         (discard_my_cleanups, discard_cleanups)
7944         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7945         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7946         (null_cleanup): Remove.
7947         (do_final_cleanups): Remove parameter.
7948
7949 2019-03-06  Tom Tromey  <tom@tromey.com>
7950
7951         * remote.c (remote_target::remote_parse_stop_reply): Use
7952         unique_xmalloc_ptr.
7953
7954 2019-03-06  Tom Tromey  <tom@tromey.com>
7955
7956         * stabsread.c (struct stabs_field_info): Rename from field_info.
7957         <list, fnlist>: Add initializers.
7958         <obstack>: New member.
7959         (read_member_functions, read_struct_fields, read_baseclasses):
7960         Allocate on obstack.  Don't use cleanups.
7961         (read_one_struct_field, read_member_functions, read_struct_fields)
7962         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7963         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7964         (read_struct_type): Update.
7965
7966 2019-03-06  Tom Tromey  <tom@tromey.com>
7967
7968         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7969         * common/filestuff.h (make_cleanup_close): Don't declare.
7970         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7971         Remove.
7972
7973 2019-03-06  Tom Tromey  <tom@tromey.com>
7974
7975         * solib-aix.c: Use make_scope_exit.
7976
7977 2019-03-06  Tom Tromey  <tom@tromey.com>
7978
7979         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7980         Use make_scope_exit.
7981
7982 2019-03-06  Tom Tromey  <tom@tromey.com>
7983
7984         * solib-svr4.c (disable_probes_interface): Remove parameter.
7985         (svr4_handle_solib_event): Use make_scope_exit.
7986
7987 2019-03-06  Tom Tromey  <tom@tromey.com>
7988
7989         * remote.c (struct stop_reply_deleter): Remove.
7990         (stop_reply_up): Update.
7991         (struct stop_reply): Derive from notif_event.  Don't typedef.
7992         <regcache>: Now a std::vector.
7993         (stop_reply_xfree): Remove.
7994         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7995         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7996         (remote_target::discard_pending_stop_replies): Use delete.
7997         (remote_target::remote_parse_stop_reply): Update.
7998         (remote_target::process_stop_reply): Update.
7999         * remote-notif.h (struct notif_event): Add virtual destructor.
8000         Remove "dtr" member.
8001         (struct notif_client) <alloc_event>: Return a unique_ptr.
8002         (notif_event_xfree): Don't declare.
8003         (notif_event_up): New typedef.
8004         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8005         (notif_event_xfree, do_notif_event_xfree): Remove.
8006         (remote_notif_state_xfree): Update.
8007
8008 2019-03-06  Tom Tromey  <tom@tromey.com>
8009
8010         * infrun.c (displaced_step_clear_cleanup): Now a
8011         forward_scope_exit type.
8012         (displaced_step_prepare_throw): Update.
8013         (displaced_step_fixup): Update.
8014
8015 2019-03-06  Tom Tromey  <tom@tromey.com>
8016
8017         * inferior.h (class inferior): Update comment.
8018         * gdbthread.h (class thread_info): Update comment.
8019
8020 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8021             Tom Tromey  <tom@tromey.com>
8022
8023         * stabsread.h (struct stab_section_list): Remove.
8024         (coffstab_build_psymtabs): Update.
8025         * dbxread.c (symbuf_sections): Now a std::vector.
8026         (sect_idx): New global.
8027         (fill_symbuf): Update.
8028         (coffstab_build_psymtabs): Change type of stabsects parameter.
8029         Update.
8030         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8031         std::vector.
8032         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8033         (coff_locate_sections): Update.
8034         (coff_symfile_read): Remove cleanups.  Update.
8035         (init_stringtab): Add storage parameter.
8036         (free_stringtab, free_stringtab_cleanup): Remove.
8037         (init_lineno): Add storage parameter.
8038         (free_linetab, free_linetab_cleanup): Remove.
8039
8040 2019-03-06  Pedro Alves  <palves@redhat.com>
8041
8042         * linux-fork.c (fork_info::clobber_regs): Delete.
8043         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8044         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8045         comment.  Adjust.
8046         (scoped_switch_fork_info::scoped_switch_fork_info)
8047         (checkpoint_command, linux_fork_context): Adjust
8048         fork_save_infrun_state calls.
8049
8050 2019-03-06  Pedro Alves  <palves@redhat.com>
8051
8052         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8053         (inf_has_multiple_threads): Return 'bool' and rewrite using
8054         inferior_info::threads().
8055
8056 2019-03-06  Pedro Alves  <palves@redhat.com>
8057
8058         * linux-fork.c: Include <list>.
8059         (fork_list): Now a std::list instance.
8060         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8061         (forks_exist_p, find_last_fork): Adjust.
8062         (new_fork): Delete.
8063         (one_fork_p): New.
8064         (add_fork): Adjust.
8065         (free_fork): Delete, folded into fork_info::~fork_info().
8066         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8067         Adjust.
8068         (init_fork_list): Delete.
8069         (linux_fork_killall, linux_fork_mourn_inferior)
8070         (linux_fork_detach, info_checkpoints_command): Adjust.
8071         (_initialize_linux_fork): No longer call init_fork_list.
8072
8073 2019-03-06  Pedro Alves  <palves@redhat.com>
8074
8075         * linux-fork.c (new_fork): New, split out of ...
8076         (add_fork): ... this.  Return void.  Move "first fork" special
8077         case from here, to ...
8078         (checkpoint_command): ... here.
8079         * linux-linux.h (add_fork): Return void.
8080
8081 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8084
8085 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8086             Chris January  <chris.january@arm.com>
8087             David Lecomber  <david.lecomber@arm.com>
8088
8089         * f-exp.y: New token, UNOP_INTRINSIC.
8090         (exp): New pattern using UNOP_INTRINSIC token.
8091         (f77_keywords): Add 'abs' keyword.
8092         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8093         (value_from_host_double): New function.
8094         (evaluate_subexp_f): Support UNOP_ABS.
8095
8096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8099         types.
8100
8101 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8104         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8105         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8106
8107 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8108
8109         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8110
8111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8112             Chris January  <chris.january@arm.com>
8113
8114         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8115         * f-exp.y: Define 'KIND' token.
8116         (exp): New pattern for KIND expressions.
8117         (ptype): Handle types with a kind extension.
8118         (direct_abs_decl): Extend to spot kind extensions.
8119         (f77_keywords): Add 'kind' to the list.
8120         (push_kind_type): New function.
8121         (convert_to_kind_type): New function.
8122         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8123         * parse.c (operator_length_standard): Likewise.
8124         * parser-defs.h (enum type_pieces): Add tp_kind.
8125         * std-operator.def: Add UNOP_KIND.
8126
8127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8128
8129         * f-exp.y (f_parse): Set yydebug.
8130
8131 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8132
8133         * f-lang.c (evaluate_subexp_f): New function.
8134         (exp_descriptor_f): New global.
8135         (f_language_defn): Use exp_descriptor_f instead of
8136         exp_descriptor_standard.
8137
8138 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * f-exp.y (struct token): Add comments.
8141         (dot_ops): Remove uppercase versions and the end marker.
8142         (f77_keywords): Likewise.
8143         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8144         entries in the dot_ops array are case insensitive, and use
8145         strncasecmp to compare strings.  Also some whitespace cleanup in
8146         this area.  Similar for the f77_keywords array, except entries in
8147         this list might be case sensitive.
8148
8149 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8150
8151         * f-exp.y (struct f77_boolean_val): Add comments.
8152         (boolean_values): Remove uppercase versions, and end marker.
8153         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8154         and use strncasecmp to achieve case insensitivity.  Additionally,
8155         perform whitespace cleanup around this code.
8156
8157 2019-03-06  Tom Tromey  <tromey@adacore.com>
8158
8159         * remote-sim.c (gdbsim_target_open): Use result of
8160         gdb_argv::release.
8161
8162 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8163         Dirk Schubert  <dirk.schubert@arm.com>
8164         Chris January  <chris.january@arm.com>
8165
8166         * eval.c (evaluate_subexp_standard): Call Fortran argument
8167         wrapping logic.
8168         * f-lang.c (struct value): A value which can be passed into a
8169         Fortran function call.
8170         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8171         where appropriate.
8172         (struct type): Value ready for a Fortran function call.
8173         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8174         is needed.
8175         * f-lang.h (fortran_argument_convert): Declaration.
8176         (fortran_preserve_arg_pointer): Declaration.
8177         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8178
8179 2019-03-05  Tom Tromey  <tromey@adacore.com>
8180
8181         * python/py-prettyprint.c (print_string_repr): Remove #if.
8182         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8183
8184 2019-03-05  Tom Tromey  <tromey@adacore.com>
8185
8186         * target.c (the_dummy_target): Move later.  Change type to
8187         "dummy_target".
8188         (initialize_targets): Don't initialize the_dummy_target.
8189
8190 2019-03-05  Tom Tromey  <tromey@adacore.com>
8191
8192         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8193         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8194
8195 2019-03-05  Tom Tromey  <tromey@adacore.com>
8196
8197         * windows-nat.c (windows_nat_target::attach)
8198         (windows_nat_target::detach): Don't call gdb_flush.
8199         * valprint.c (generic_val_print, val_print, val_print_string):
8200         Don't call gdb_flush.
8201         * utils.c (defaulted_query): Don't call gdb_flush.
8202         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8203         * target.c (target_announce_detach): Don't call gdb_flush.
8204         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8205         * remote.c (extended_remote_target::attach): Don't call
8206         gdb_flush.
8207         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8208         * printcmd.c (do_examine): Don't call gdb_flush.
8209         (info_display_command): Don't call gdb_flush.
8210         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8211         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8212         * memattr.c (info_mem_command): Don't call gdb_flush.
8213         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8214         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8215         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8216         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8217         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8218         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8219         (gnu_nat_target::detach): Don't call gdb_flush.
8220         * f-valprint.c (f_val_print): Don't call gdb_flush.
8221         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8222         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8223         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8224         gdb_flush.
8225         * c-valprint.c (c_val_print): Don't call gdb_flush.
8226         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8227
8228 2019-03-05  Tom Tromey  <tromey@adacore.com>
8229
8230         * varobj.c (update_dynamic_varobj_children): Update.
8231         (install_default_visualizer): Use reset, not release.
8232         * value.c (set_internalvar): Update.
8233         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8234         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8235         ATTRIBUTE_UNUSED_RESULT.
8236
8237 2019-03-05  Tom Tromey  <tromey@adacore.com>
8238
8239         * remote.c (class scoped_remote_fd) <release>: Add
8240         ATTRIBUTE_UNUSED_RESULT.
8241
8242 2019-03-05  Tom Tromey  <tromey@adacore.com>
8243
8244         * macroexp.c (struct macro_buffer) <release>: Add
8245         ATTRIBUTE_UNUSED_RESULT.
8246
8247 2019-03-05  Tom Tromey  <tromey@adacore.com>
8248
8249         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8250         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8251         ATTRIBUTE_UNUSED_RESULT.
8252
8253 2019-03-05  Tom Tromey  <tromey@adacore.com>
8254
8255         * common/scoped_fd.h (class scoped_fd) <release>: Add
8256         ATTRIBUTE_UNUSED_RESULT.
8257
8258 2019-03-05  Tom Tromey  <tromey@adacore.com>
8259
8260         * parser-defs.h (struct parser_state) <release>: Add
8261         ATTRIBUTE_UNUSED_RESULT.
8262
8263 2019-03-05  Tom Tromey  <tromey@adacore.com>
8264
8265         * utils.h (class gdb_argv) <release>: Add
8266         ATTRIBUTE_UNUSED_RESULT.
8267         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8268
8269 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8270
8271         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8272         for-loop range, to avoid compiler warnings.
8273
8274         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8275         avoid compiler warnings about unused variables.
8276
8277         * NEWS: Mention end of support for native debugging on MS-Windows
8278         before XP.
8279
8280         PR gdb/24292
8281         * common/netstuff.c:
8282         * gdbserver/gdbreplay.c
8283         * gdbserver/remote-utils.c:
8284         * ser-tcp.c:
8285         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8286         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8287         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8288         'getaddrinfo' and 'freeaddrinfo' were not available before
8289         Windows XP, and mingw.org's MinGW headers by default define
8290         _WIN32_WINNT to 0x500.
8291
8292 2019-03-01  Gary Benson <gbenson@redhat.com>
8293
8294         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8295
8296 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8297             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8298
8299         PR gdb/8527
8300         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8301         set_sigint_trap, clear_sigint_trap.
8302
8303 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8304
8305         * target.c (target_detach): Clear the regcache and the
8306         frame cache.
8307
8308 2019-02-27  Pedro Alves  <palves@redhat.com>
8309
8310         * utils.c (set_screen_size): When we cap the height/width sizes,
8311         tweak the corresponding command variable to show "unlimited":
8312
8313 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8314             Pedro Alves  <palves@redhat.com>
8315
8316         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8317         before calling rl_set_screen_size.
8318
8319 2019-02-27  Tom Tromey  <tromey@adacore.com>
8320
8321         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8322         define.
8323         * python/py-value.c: Remove Python 2.4 workaround.
8324         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8325         workaround.
8326         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8327         Python 2.4 workaround.
8328         * python/python-internal.h: Remove Python 2.4 comment.
8329         (Py_ssize_t): Don't define.
8330         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8331         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8332         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8333         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8334         * python/python.c (do_start_initialization): Remove Python 2.4
8335         workaround.
8336         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8337         (print_children): Remove Python 2.4 workaround.
8338         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8339         workaround.
8340         (CHARBUFFERPROC_NAME): Remove.
8341         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8342         Python 2.4 workaround.
8343
8344 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8345
8346         * NEWS: Note minimum Python version.
8347
8348 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8349
8350         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8351         code from these functions.  Remove corresponding ifdefs.  Use
8352         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8353         Remove gotos and target of gotos.
8354         (infpy_search_memory): Likewise.
8355
8356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8357
8358         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8359         (hppa_gdbarch_init): Don't register deleted functions with
8360         gdbarch.
8361
8362 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8363
8364         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8365         (h8300_unwind_sp): Delete.
8366         (h8300_dummy_id): Delete.
8367         (h8300_gdbarch_init): Don't register deleted functions with
8368         gdbarch.
8369
8370 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8371
8372         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8373         (ft32_unwind_pc): Delete.
8374         (ft32_unwind_sp): Delete.
8375         (ft32_gdbarch_init): Don't register deleted functions with
8376         gdbarch.
8377
8378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8379
8380         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8381         (frv_unwind_pc): Delete.
8382         (frv_unwind_sp): Delete.
8383         (frv_gdbarch_init): Don't register deleted functions with
8384         gdbarch.
8385
8386 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8387
8388         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8389         (riscv_unwind_pc): Delete.
8390         (riscv_unwind_sp): Delete.
8391         (riscv_gdbarch_init): Don't register deleted functions with
8392         gdbarch.
8393
8394 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8397         (csky_unwind_pc): Delete.
8398         (csky_unwind_sp): Delete.
8399         (csky_gdbarch_init): Don't register deleted functions with
8400         gdbarch.
8401
8402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8403
8404         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8405         (cris_unwind_pc): Delete.
8406         (cris_unwind_sp): Delete.
8407         (cris_gdbarch_init): Don't register deleted functions with
8408         gdbarch.
8409
8410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8413         (bfin_unwind_pc): Delete.
8414         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8415
8416 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8419         (arm_unwind_pc): Delete.
8420         (arm_unwind_sp): Delete.
8421         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8422
8423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8424
8425         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8426         (arc_unwind_pc): Delete.
8427         (arc_unwind_sp): Delete.
8428         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8429
8430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8431
8432         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8433         (alpha_unwind_pc): Delete.
8434         (alpha_gdbarch_init): Don't register deleted functions with
8435         gdbarch.
8436
8437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8438
8439         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8440         (aarch64_unwind_pc): Delete.
8441         (aarch64_unwind_sp): Delete.
8442         (aarch64_gdbarch_init): Don't register deleted functions with
8443         gdbarch.
8444
8445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8446
8447         * gdbtypes.c (type_align): Don't consider static members when
8448         computing structure alignment.
8449
8450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8451
8452         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8453         return 0 for other types.
8454         * arch-utils.c (default_type_align): Always return 0.
8455         * gdbarch.h: Regenerate.
8456         * gdbarch.sh (type_align): Extend comment.
8457         * gdbtypes.c (type_align): Add additional comments, always call
8458         gdbarch_type_align before applying the default rules.
8459         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8460         generic code will then apply a suitable default.
8461         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8462         types, return 0 for other types.
8463
8464 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8465
8466         * NEWS: Create a new section for the next release branch.
8467         Rename the section of the current branch, now that it has
8468         been cut.
8469
8470 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8471
8472         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8473         * version.in: Bump version to 8.3.50.DATE-git.
8474
8475 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8476
8477         * aix-thread.c (ptid_cmp): Remove unused variable.
8478         (get_signaled_thread): Likewise.
8479         (store_regs_user_thread): Likewise.
8480         (store_regs_kernel_thread): Likewise.
8481         (fetch_regs_kernel_thread): Remove shadowed variable.
8482
8483 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8484
8485         * features/riscv/32bit-cpu.xml: Add register numbers.
8486         * features/riscv/32bit-fpu.c: Regenerate.
8487         * features/riscv/32bit-fpu.xml: Add register numbers.
8488         * features/riscv/64bit-cpu.xml: Add register numbers.
8489         * features/riscv/64bit-fpu.c: Regenerate.
8490         * features/riscv/64bit-fpu.xml: Add register numbers.
8491
8492 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8493
8494         * NEWS: Mention two argument form of gdb.Value constructor.
8495         * python/py-value.c (convert_buffer_and_type_to_value): New
8496         function.
8497         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8498         Add support for handling an optional second argument.  Call
8499         convert_buffer_and_type_to_value as appropriate.
8500         * python/python-internal.h (Py_buffer_deleter): New struct.
8501         (Py_buffer_up): New typedef.
8502
8503 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8504
8505         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8506         instead of releasing ownership.
8507
8508 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8509
8510         * dwarf2read.c (open_and_init_dwp_file): Call
8511         elf_numsections instead of bfd_count_sections to initialize
8512         dwp_file->num_sections.
8513
8514 2019-02-25  Tom Tromey  <tromey@adacore.com>
8515
8516         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8517
8518 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8519
8520         * gcore.in: Add '--readnever' option when invoking GDB.
8521
8522 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8523
8524         * MAINTAINERS: Update my email address.
8525
8526 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8527
8528         * build-id.c (build_id_to_debug_bfd_1): New function.
8529         (build_id_to_debug_bfd): Look for separate debug file in
8530         sysroot.
8531
8532 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * gdbarch.sh: Update the copyright year range that is placed into
8535         generated files.
8536
8537 2019-02-22  Keith Seitz  <keiths@redhat.com>
8538
8539         PR symtab/23853
8540         * linespec.c (create_sals_line_offset): Search for the default
8541         symtab's filename instead of its fullname.
8542
8543 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8544
8545         * NEWS: Update style defaults.
8546
8547 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8548
8549         * main.c (captured_main_1): Disable styling in batch mode.
8550
8551 2019-02-20  Tom Tromey  <tom@tromey.com>
8552
8553         * symtab.c (symtab_symbol_info): Fix typos.
8554
8555 2019-02-20  Tom Tromey  <tromey@adacore.com>
8556
8557         * findcmd.c (_initialize_mem_search): Use upper case for
8558         metasyntactic variables.
8559
8560 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8561
8562         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8563         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8564
8565 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8566
8567         * top.h (source_file_name): Change to std::string.
8568         * top.c (source_file_name): Likewise.
8569         (command_line_input): Adjust.
8570         * cli/cli-script.c (script_from_file): Adjust.
8571
8572 2019-02-19  Tom Tromey  <tromey@adacore.com>
8573
8574         * ravenscar-thread.c
8575         (ravenscar_thread_target::update_thread_list): Don't call
8576         ada_build_task_list.
8577         * ada-lang.h (ada_build_task_list): Don't declare.
8578         * ada-tasks.c (struct ada_tasks_inferior_data)
8579         <task_list_valid_p>: Now bool.
8580         (read_known_tasks, ada_task_list_changed)
8581         (ada_tasks_invalidate_inferior_data): Update.
8582         (read_known_tasks_array): Return bool.
8583         (read_known_tasks_list): Likewise.
8584         (read_known_tasks): Return void.
8585         (ada_build_task_list): Now static.
8586
8587 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8588
8589         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8590         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8591
8592 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8593
8594         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8595         variant for ada_tasks_pspace_data_handle and
8596         ada_tasks_inferior_data_handle.
8597         (ada_tasks_pspace_data_cleanup): New function.
8598         (ada_tasks_inferior_data_cleanup): New function.
8599
8600 2019-02-17  Tom Tromey  <tom@tromey.com>
8601
8602         * macrotab.h (macro_source_fullname): Return a std::string.
8603         * macrotab.c (macro_include, check_for_redefinition)
8604         (macro_undef, macro_lookup_definition, foreach_macro)
8605         (foreach_macro_in_scope): Update.
8606         (macro_source_fullname): Return a std::string.
8607         * macrocmd.c (show_pp_source_pos): Update.
8608
8609 2019-02-17  Tom Tromey  <tom@tromey.com>
8610
8611         * macrocmd.c (show_pp_source_pos): Style the file names.
8612
8613 2019-02-17  Tom Tromey  <tom@tromey.com>
8614
8615         PR tui/24197:
8616         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8617
8618 2019-02-17  Tom Tromey  <tom@tromey.com>
8619
8620         * ada-lang.c (user_select_syms): Use filtered printing.
8621         * utils.c (wrap_style): New global.
8622         (desired_style): Remove.
8623         (emit_style_escape): Add stream parameter.
8624         (set_output_style, reset_terminal_style, prompt_for_continue):
8625         Update.
8626         (flush_wrap_buffer): Only flush gdb_stdout.
8627         (wrap_here): Set wrap_style.
8628         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8629         treat escape sequences as a character.  Change when wrap buffer is
8630         flushed.
8631         (fputs_styled): Do not set the output style when the default is
8632         requested.
8633         * ui-style.h (struct ui_file_style) <is_default>: New method.
8634         * source.c (print_source_lines_base): Emit escape sequences in one
8635         piece.
8636
8637 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8638
8639         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8640         integers and enumeration types.
8641
8642 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8643
8644         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8645         instead of lookup_symbol_in_language
8646         (do_exact_match): New function.
8647         (ada_get_symbol_name_matcher): Return do_exact_match when
8648         doing a verbatim match.
8649
8650 2019-02-15  Tom Tromey  <tromey@adacore.com>
8651
8652         * ravenscar-thread.c (ravenscar_thread_target::resume)
8653         (ravenscar_thread_target::wait): Special case wildcard requests.
8654
8655 2019-02-15  Tom Tromey  <tromey@adacore.com>
8656
8657         * ravenscar-thread.c (base_ptid): Remove.
8658         (struct ravenscar_thread_target) <close>: New method.
8659         <m_base_ptid>: New member.
8660         <update_inferior_ptid, active_task, task_is_currently_active,
8661         runtime_initialized>: Declare methods.
8662         <ravenscar_thread_target>: Add constructor.
8663         (ravenscar_thread_target::task_is_currently_active)
8664         (ravenscar_thread_target::update_inferior_ptid)
8665         (ravenscar_runtime_initialized): Rename.  Now methods.
8666         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8667         (ravenscar_thread_target::update_thread_list): Update.
8668         (ravenscar_thread_target::active_task): Now method.
8669         (ravenscar_thread_target::store_registers)
8670         (ravenscar_thread_target::prepare_to_store)
8671         (ravenscar_thread_target::prepare_to_store)
8672         (ravenscar_thread_target::mourn_inferior): Update.
8673         (ravenscar_inferior_created): Use "new" to create target.
8674         (ravenscar_thread_target::get_ada_task_ptid): Update.
8675         (_initialize_ravenscar): Don't initialize base_ptid.
8676         (ravenscar_ops): Remove global.
8677
8678 2019-02-15  Tom Tromey  <tromey@adacore.com>
8679
8680         * target.h (push_target): Declare new overload.
8681         * target.c (push_target): New overload, taking an rvalue reference.
8682         * remote.c (remote_target::open_1): Use push_target overload.
8683         * corelow.c (core_target_open): Use push_target overload.
8684
8685 2019-02-15  Tom Tromey  <tromey@adacore.com>
8686
8687         * ravenscar-thread.c (is_ravenscar_task)
8688         (ravenscar_task_is_currently_active): Return bool.
8689         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8690         (_initialize_ravenscar): Remove "(void)".
8691         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8692         Return bool.
8693
8694 2019-02-15  Tom Tromey  <tromey@adacore.com>
8695
8696         * ravenscar-thread.c (ravenscar_runtime_initializer)
8697         (has_ravenscar_runtime, get_running_thread_id)
8698         (ravenscar_thread_target::resume): Fix indentation.
8699
8700 2019-02-15  Tom Tromey  <tromey@adacore.com>
8701
8702         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8703         from ravenscar_arch_ops.
8704         (sparc_ravenscar_ops::fetch_registers)
8705         (sparc_ravenscar_ops::store_registers): Now methods.
8706         (sparc_ravenscar_prepare_to_store): Remove.
8707         (sparc_ravenscar_ops): Redefine.
8708         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8709         methods and destructor.  Remove members.
8710         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8711         (ravenscar_thread_target::store_registers)
8712         (ravenscar_thread_target::prepare_to_store): Update.
8713         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8714         Remove.
8715         (struct ppc_ravenscar_powerpc_ops): Derive from
8716         ravenscar_arch_ops.
8717         (ppc_ravenscar_powerpc_ops::fetch_registers)
8718         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8719         (ppc_ravenscar_powerpc_ops): Redefine.
8720         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8721         (ppc_ravenscar_e500_ops::fetch_registers)
8722         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8723         (ppc_ravenscar_e500_ops): Redefine.
8724         * aarch64-ravenscar-thread.c
8725         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8726         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8727         (aarch64_ravenscar_fetch_registers)
8728         (aarch64_ravenscar_store_registers): Now methods.
8729         (aarch64_ravenscar_ops): Redefine.
8730
8731 2019-02-15  Tom Tromey  <tromey@adacore.com>
8732
8733         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8734         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8735         (ravenscar_thread_target::stopped_by_watchpoint)
8736         (ravenscar_thread_target::stopped_data_address)
8737         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8738
8739 2019-02-15  Tom Tromey  <tromey@adacore.com>
8740
8741         * ravenscar-thread.c: Fix some typos.
8742
8743 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8744             Tom Tromey  <tromey@adacore.com>
8745
8746         * ada-lang.c (ada_exception_sal): Change addr_string to a
8747         std::string.
8748         (create_ada_exception_catchpoint): Update.
8749
8750 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8751             Tom Tromey  <tromey@adacore.com>
8752
8753         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8754         (bp_location_ops): Remove.
8755         (base_breakpoint_allocate_location): Update.
8756         (free_bp_location): Update.
8757         * ada-lang.c (class ada_catchpoint_location)
8758         <ada_catchpoint_location>: Remove ops parameter.
8759         (ada_catchpoint_location_dtor): Remove.
8760         (ada_catchpoint_location_ops): Remove.
8761         (allocate_location_exception): Update.
8762         * breakpoint.h (struct bp_location_ops): Remove.
8763         (class bp_location) <bp_location>: Remove bp_location_ops
8764         parameter.
8765         <~bp_location>: Add destructor.
8766         <ops>: Remove.
8767
8768 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8769             Pedro Alves  <palves@redhat.com>
8770
8771         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8772         'PATH_MAX'.
8773
8774 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8775             Samuel Thibault  <samuel.thibault@gnu.org>
8776             Thomas Schwinge  <thomas@codesourcery.com>
8777
8778         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8779         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8780
8781 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8782
8783         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8784         (check_empty): Use "const char *".
8785
8786         * gnu-nat.c (gnu_nat_target::detach): Instead of
8787         'detach_inferior (pid)' call
8788         'detach_inferior (find_inferior_pid (pid))'.
8789
8790         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8791         'nat/fork-inferior.o'.
8792         * gnu-nat.c: #include "nat/fork-inferior.h".
8793
8794         * gnu-nat.c (gnu_nat_target::detach): Instead of
8795         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8796         * gnu-nat.h: #include "inf-child.h".
8797         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8798         'i386_gnu_nat_target::fetch_registers'.
8799         (gnu_store_registers): Rename/move to
8800         'i386_gnu_nat_target::store_registers'.
8801
8802         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8803         * gnu-nat.h (mach_thread_info): New function.
8804         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8805
8806         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8807
8808 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8809
8810         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8811
8812 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8813
8814         * windows-nat.c (windows_add_thread): Add new parameter
8815         "main_thread_p" with default value set to false.  Update
8816         function documentation as well as all callers.
8817         (windows_delete_thread): Likewise.
8818         (fake_create_process): Update call to windows_add_thread.
8819         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8820         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8821         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8822         call to windows_delete_thread.
8823
8824 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8825
8826         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8827
8828 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8829
8830         * symfile.c (find_separate_debug_file): Use canonical path of
8831         sysroot with child_path instead of gdb_sysroot if it is valid.
8832
8833 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8834
8835         * symfile.c (find_separate_debug_file): Use child_path to
8836         determine if an object file is under a sysroot.
8837
8838 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8839
8840         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8841         unittests/child-path-selftests.c.
8842         * common/pathstuff.c (child_path): New function.
8843         * common/pathstuff.h (child_path): New prototype.
8844         * unittests/child-path-selftests.c: New file.
8845
8846 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8847
8848         * symfile.c (find_separate_debug_file): Look for separate debug
8849         files in debug directories under the sysroot.
8850
8851 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8852
8853         * symtab.h (struct minimal_symbol data_p): New const method.
8854         (struct minimal_symbol text_p): Likewise.
8855         * symtab.c (output_source_filename): Use file name style
8856         to print file name.
8857         (print_symbol_info): Likewise.
8858         (print_msymbol_info): Use address style to print addresses.
8859         Use function name style to print executable text symbols.
8860         (expand_symtab_containing_pc): Use data_p.
8861         (find_pc_sect_compunit_symtab): Likewise.
8862
8863 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8864
8865         * breakpoint.c (describe_other_breakpoints): Use address style
8866         to print addresses.
8867         (say_where): Likewise.
8868
8869 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8870
8871         * ada-typeprint.c (print_func_type): Print function name
8872         style to print function name.
8873         * c-typeprint.c (c_print_type_1): Likewise.
8874
8875 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8876
8877         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8878         for execve.
8879
8880 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8881
8882         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8883         type_stack.
8884
8885 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8886
8887         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8888         TYPE_CODE_REF types.
8889
8890 2019-02-08  Jim Wilson  <jimw@sifive.com>
8891
8892         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8893         (riscv_linux_fregset): New.
8894         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8895
8896 2019-02-07  Tom Tromey  <tom@tromey.com>
8897
8898         * thread.c (thread_cancel_execution_command): Update.
8899         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8900         methods.
8901         (struct thread_fsm_ops): Remove.
8902         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8903         (thread_fsm_should_stop, thread_fsm_return_value)
8904         (thread_fsm_set_finished, thread_fsm_finished_p)
8905         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8906         Don't declare.
8907         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8908         * infrun.c (clear_proceed_status_thread)
8909         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8910         (print_stop_event): Update.
8911         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8912         Add constructor.
8913         (step_command_fsm_ops): Remove.
8914         (new_step_command_fsm): Remove.
8915         (step_1): Update.
8916         (step_command_fsm::should_stop): Rename from
8917         step_command_fsm_should_stop.
8918         (step_command_fsm::clean_up): Rename from
8919         step_command_fsm_clean_up.
8920         (step_command_fsm::do_async_reply_reason): Rename from
8921         step_command_fsm_async_reply_reason.
8922         (struct until_next_fsm): Inherit from thread_fsm.  Add
8923         constructor.
8924         (until_next_fsm_ops): Remove.
8925         (new_until_next_fsm): Remove.
8926         (until_next_fsm::should_stop): Rename from
8927         until_next_fsm_should_stop.
8928         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8929         (until_next_fsm::do_async_reply_reason): Rename from
8930         until_next_fsm_async_reply_reason.
8931         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8932         constructor.  Change type of breakpoint.
8933         (finish_command_fsm_ops): Remove.
8934         (new_finish_command_fsm): Remove.
8935         (finish_command_fsm::should_stop): Rename from
8936         finish_command_fsm_should_stop.
8937         (finish_command_fsm::clean_up): Rename from
8938         finish_command_fsm_clean_up.
8939         (finish_command_fsm::return_value): Rename from
8940         finish_command_fsm_return_value.
8941         (finish_command_fsm::do_async_reply_reason): Rename from
8942         finish_command_fsm_async_reply_reason.
8943         (finish_command): Update.
8944         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8945         Add constructor.
8946         (call_thread_fsm_ops): Remove.
8947         (call_thread_fsm::call_thread_fsm): Rename from
8948         new_call_thread_fsm.
8949         (call_thread_fsm::should_stop): Rename from
8950         call_thread_fsm_should_stop.
8951         (call_thread_fsm::should_notify_stop): Rename from
8952         call_thread_fsm_should_notify_stop.
8953         (run_inferior_call, call_function_by_hand_dummy): Update.
8954         * cli/cli-interp.c (should_print_stop_to_console): Update.
8955         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8956         Add constructor.  Change type of location_breakpoint,
8957         caller_breakpoint.
8958         (until_break_fsm_ops): Remove.
8959         (new_until_break_fsm): Remove.
8960         (until_break_fsm::should_stop): Rename from
8961         until_break_fsm_should_stop.
8962         (until_break_fsm::clean_up): Rename from
8963         until_break_fsm_clean_up.
8964         (until_break_fsm::do_async_reply_reason): Rename from
8965         until_break_fsm_async_reply_reason.
8966         (until_break_command): Update.
8967         * thread-fsm.c: Remove.
8968         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8969
8970 2019-02-07  Tom Tromey  <tom@tromey.com>
8971
8972         * yy-remap.h: Add include guard.
8973         * xtensa-tdep.h: Add include guard.
8974         * xcoffread.h: Rename include guard.
8975         * varobj-iter.h: Add include guard.
8976         * tui/tui.h: Rename include guard.
8977         * tui/tui-winsource.h: Rename include guard.
8978         * tui/tui-wingeneral.h: Rename include guard.
8979         * tui/tui-windata.h: Rename include guard.
8980         * tui/tui-win.h: Rename include guard.
8981         * tui/tui-stack.h: Rename include guard.
8982         * tui/tui-source.h: Rename include guard.
8983         * tui/tui-regs.h: Rename include guard.
8984         * tui/tui-out.h: Rename include guard.
8985         * tui/tui-layout.h: Rename include guard.
8986         * tui/tui-io.h: Rename include guard.
8987         * tui/tui-hooks.h: Rename include guard.
8988         * tui/tui-file.h: Rename include guard.
8989         * tui/tui-disasm.h: Rename include guard.
8990         * tui/tui-data.h: Rename include guard.
8991         * tui/tui-command.h: Rename include guard.
8992         * tic6x-tdep.h: Add include guard.
8993         * target/waitstatus.h: Rename include guard.
8994         * target/wait.h: Rename include guard.
8995         * target/target.h: Rename include guard.
8996         * target/resume.h: Rename include guard.
8997         * target-float.h: Rename include guard.
8998         * stabsread.h: Add include guard.
8999         * rs6000-tdep.h: Add include guard.
9000         * riscv-fbsd-tdep.h: Add include guard.
9001         * regformats/regdef.h: Rename include guard.
9002         * record.h: Rename include guard.
9003         * python/python.h: Rename include guard.
9004         * python/python-internal.h: Rename include guard.
9005         * python/py-stopevent.h: Rename include guard.
9006         * python/py-ref.h: Rename include guard.
9007         * python/py-record.h: Rename include guard.
9008         * python/py-record-full.h: Rename include guard.
9009         * python/py-record-btrace.h: Rename include guard.
9010         * python/py-instruction.h: Rename include guard.
9011         * python/py-events.h: Rename include guard.
9012         * python/py-event.h: Rename include guard.
9013         * procfs.h: Add include guard.
9014         * proc-utils.h: Add include guard.
9015         * p-lang.h: Add include guard.
9016         * or1k-tdep.h: Rename include guard.
9017         * observable.h: Rename include guard.
9018         * nto-tdep.h: Rename include guard.
9019         * nat/x86-linux.h: Rename include guard.
9020         * nat/x86-linux-dregs.h: Rename include guard.
9021         * nat/x86-gcc-cpuid.h: Add include guard.
9022         * nat/x86-dregs.h: Rename include guard.
9023         * nat/x86-cpuid.h: Rename include guard.
9024         * nat/ppc-linux.h: Rename include guard.
9025         * nat/mips-linux-watch.h: Rename include guard.
9026         * nat/linux-waitpid.h: Rename include guard.
9027         * nat/linux-ptrace.h: Rename include guard.
9028         * nat/linux-procfs.h: Rename include guard.
9029         * nat/linux-osdata.h: Rename include guard.
9030         * nat/linux-nat.h: Rename include guard.
9031         * nat/linux-namespaces.h: Rename include guard.
9032         * nat/linux-btrace.h: Rename include guard.
9033         * nat/glibc_thread_db.h: Rename include guard.
9034         * nat/gdb_thread_db.h: Rename include guard.
9035         * nat/gdb_ptrace.h: Rename include guard.
9036         * nat/fork-inferior.h: Rename include guard.
9037         * nat/amd64-linux-siginfo.h: Rename include guard.
9038         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9039         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9040         * nat/aarch64-linux.h: Rename include guard.
9041         * nat/aarch64-linux-hw-point.h: Rename include guard.
9042         * mn10300-tdep.h: Add include guard.
9043         * mips-linux-tdep.h: Add include guard.
9044         * mi/mi-parse.h: Rename include guard.
9045         * mi/mi-out.h: Rename include guard.
9046         * mi/mi-main.h: Rename include guard.
9047         * mi/mi-interp.h: Rename include guard.
9048         * mi/mi-getopt.h: Rename include guard.
9049         * mi/mi-console.h: Rename include guard.
9050         * mi/mi-common.h: Rename include guard.
9051         * mi/mi-cmds.h: Rename include guard.
9052         * mi/mi-cmd-break.h: Rename include guard.
9053         * m2-lang.h: Add include guard.
9054         * location.h: Rename include guard.
9055         * linux-record.h: Rename include guard.
9056         * linux-nat.h: Add include guard.
9057         * linux-fork.h: Add include guard.
9058         * i386-darwin-tdep.h: Rename include guard.
9059         * hppa-linux-offsets.h: Add include guard.
9060         * guile/guile.h: Rename include guard.
9061         * guile/guile-internal.h: Rename include guard.
9062         * gnu-nat.h: Rename include guard.
9063         * gdb-stabs.h: Rename include guard.
9064         * frv-tdep.h: Add include guard.
9065         * f-lang.h: Add include guard.
9066         * event-loop.h: Add include guard.
9067         * darwin-nat.h: Rename include guard.
9068         * cp-abi.h: Rename include guard.
9069         * config/sparc/nm-sol2.h: Rename include guard.
9070         * config/nm-nto.h: Rename include guard.
9071         * config/nm-linux.h: Add include guard.
9072         * config/i386/nm-i386gnu.h: Rename include guard.
9073         * config/djgpp/nl_types.h: Rename include guard.
9074         * config/djgpp/langinfo.h: Rename include guard.
9075         * compile/gcc-cp-plugin.h: Add include guard.
9076         * compile/gcc-c-plugin.h: Add include guard.
9077         * compile/compile.h: Rename include guard.
9078         * compile/compile-object-run.h: Rename include guard.
9079         * compile/compile-object-load.h: Rename include guard.
9080         * compile/compile-internal.h: Rename include guard.
9081         * compile/compile-cplus.h: Rename include guard.
9082         * compile/compile-c.h: Rename include guard.
9083         * common/xml-utils.h: Rename include guard.
9084         * common/x86-xstate.h: Rename include guard.
9085         * common/version.h: Rename include guard.
9086         * common/vec.h: Rename include guard.
9087         * common/tdesc.h: Rename include guard.
9088         * common/selftest.h: Rename include guard.
9089         * common/scoped_restore.h: Rename include guard.
9090         * common/scoped_mmap.h: Rename include guard.
9091         * common/scoped_fd.h: Rename include guard.
9092         * common/safe-iterator.h: Rename include guard.
9093         * common/run-time-clock.h: Rename include guard.
9094         * common/refcounted-object.h: Rename include guard.
9095         * common/queue.h: Rename include guard.
9096         * common/ptid.h: Rename include guard.
9097         * common/print-utils.h: Rename include guard.
9098         * common/preprocessor.h: Rename include guard.
9099         * common/pathstuff.h: Rename include guard.
9100         * common/observable.h: Rename include guard.
9101         * common/netstuff.h: Rename include guard.
9102         * common/job-control.h: Rename include guard.
9103         * common/host-defs.h: Rename include guard.
9104         * common/gdb_wait.h: Rename include guard.
9105         * common/gdb_vecs.h: Rename include guard.
9106         * common/gdb_unlinker.h: Rename include guard.
9107         * common/gdb_unique_ptr.h: Rename include guard.
9108         * common/gdb_tilde_expand.h: Rename include guard.
9109         * common/gdb_sys_time.h: Rename include guard.
9110         * common/gdb_string_view.h: Rename include guard.
9111         * common/gdb_splay_tree.h: Rename include guard.
9112         * common/gdb_setjmp.h: Rename include guard.
9113         * common/gdb_ref_ptr.h: Rename include guard.
9114         * common/gdb_optional.h: Rename include guard.
9115         * common/gdb_locale.h: Rename include guard.
9116         * common/gdb_assert.h: Rename include guard.
9117         * common/filtered-iterator.h: Rename include guard.
9118         * common/filestuff.h: Rename include guard.
9119         * common/fileio.h: Rename include guard.
9120         * common/environ.h: Rename include guard.
9121         * common/common-utils.h: Rename include guard.
9122         * common/common-types.h: Rename include guard.
9123         * common/common-regcache.h: Rename include guard.
9124         * common/common-inferior.h: Rename include guard.
9125         * common/common-gdbthread.h: Rename include guard.
9126         * common/common-exceptions.h: Rename include guard.
9127         * common/common-defs.h: Rename include guard.
9128         * common/common-debug.h: Rename include guard.
9129         * common/cleanups.h: Rename include guard.
9130         * common/buffer.h: Rename include guard.
9131         * common/btrace-common.h: Rename include guard.
9132         * common/break-common.h: Rename include guard.
9133         * cli/cli-utils.h: Rename include guard.
9134         * cli/cli-style.h: Rename include guard.
9135         * cli/cli-setshow.h: Rename include guard.
9136         * cli/cli-script.h: Rename include guard.
9137         * cli/cli-interp.h: Rename include guard.
9138         * cli/cli-decode.h: Rename include guard.
9139         * cli/cli-cmds.h: Rename include guard.
9140         * charset-list.h: Add include guard.
9141         * buildsym-legacy.h: Rename include guard.
9142         * bfin-tdep.h: Add include guard.
9143         * ax.h: Rename include guard.
9144         * arm-linux-tdep.h: Add include guard.
9145         * arm-fbsd-tdep.h: Add include guard.
9146         * arch/xtensa.h: Rename include guard.
9147         * arch/tic6x.h: Add include guard.
9148         * arch/i386.h: Add include guard.
9149         * arch/arm.h: Rename include guard.
9150         * arch/arm-linux.h: Rename include guard.
9151         * arch/arm-get-next-pcs.h: Rename include guard.
9152         * arch/amd64.h: Add include guard.
9153         * arch/aarch64-insn.h: Rename include guard.
9154         * arch-utils.h: Rename include guard.
9155         * annotate.h: Add include guard.
9156         * amd64-darwin-tdep.h: Rename include guard.
9157         * aarch64-linux-tdep.h: Add include guard.
9158         * aarch64-fbsd-tdep.h: Add include guard.
9159         * aarch32-linux-nat.h: Add include guard.
9160
9161 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9162
9163         * macrotab.c (macro_define_internal): New function that
9164         factorizes macro_define_object_internal and macro_define_function
9165         code.
9166         (macro_define_object_internal): Use macro_define_internal.
9167         (macro_define_function): Likewise.
9168
9169 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9170
9171         * macrocmd.c (extract_identifier): Return
9172         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9173         callers.
9174
9175 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9176
9177         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9178
9179 2019-02-05  Tom Tromey  <tom@tromey.com>
9180
9181         * target.c (target_stack::unpush): Move assertion earlier.
9182
9183 2019-01-30  Tom Tromey  <tom@tromey.com>
9184
9185         PR python/23615:
9186         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9187         (gdbpy_parse_and_eval): Likewise.
9188         * python/python-internal.h (gdbpy_allow_threads): New class.
9189
9190 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9191
9192         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9193         (aarch64_fbsd_fpregmap): Move earlier.
9194         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9195         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9196         instead of individual calls to trad_frame_set_reg_addr.
9197         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9198         earlier.
9199         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9200         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9201         instead of individual calls to trad_frame_set_reg_addr.
9202
9203 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9204
9205         * CONTRIBUTE: Replace contribution list with wiki link.
9206
9207 2019-01-25  Tom Tromey  <tom@tromey.com>
9208
9209         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9210
9211 2019-01-25  Tom Tromey  <tom@tromey.com>
9212
9213         * xtensa-linux-nat.c: Fix common/ includes.
9214         * xml-support.h: Fix common/ includes.
9215         * xml-support.c: Fix common/ includes.
9216         * x86-linux-nat.c: Fix common/ includes.
9217         * windows-nat.c: Fix common/ includes.
9218         * varobj.h: Fix common/ includes.
9219         * varobj.c: Fix common/ includes.
9220         * value.c: Fix common/ includes.
9221         * valops.c: Fix common/ includes.
9222         * utils.c: Fix common/ includes.
9223         * unittests/xml-utils-selftests.c: Fix common/ includes.
9224         * unittests/utils-selftests.c: Fix common/ includes.
9225         * unittests/unpack-selftests.c: Fix common/ includes.
9226         * unittests/tracepoint-selftests.c: Fix common/ includes.
9227         * unittests/style-selftests.c: Fix common/ includes.
9228         * unittests/string_view-selftests.c: Fix common/ includes.
9229         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9230         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9231         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9232         * unittests/rsp-low-selftests.c: Fix common/ includes.
9233         * unittests/parse-connection-spec-selftests.c: Fix common/
9234         includes.
9235         * unittests/optional-selftests.c: Fix common/ includes.
9236         * unittests/offset-type-selftests.c: Fix common/ includes.
9237         * unittests/observable-selftests.c: Fix common/ includes.
9238         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9239         * unittests/memrange-selftests.c: Fix common/ includes.
9240         * unittests/memory-map-selftests.c: Fix common/ includes.
9241         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9242         * unittests/function-view-selftests.c: Fix common/ includes.
9243         * unittests/environ-selftests.c: Fix common/ includes.
9244         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9245         * unittests/common-utils-selftests.c: Fix common/ includes.
9246         * unittests/cli-utils-selftests.c: Fix common/ includes.
9247         * unittests/array-view-selftests.c: Fix common/ includes.
9248         * ui-file.c: Fix common/ includes.
9249         * tui/tui-io.c: Fix common/ includes.
9250         * tracepoint.h: Fix common/ includes.
9251         * tracepoint.c: Fix common/ includes.
9252         * tracefile-tfile.c: Fix common/ includes.
9253         * top.h: Fix common/ includes.
9254         * top.c: Fix common/ includes.
9255         * thread.c: Fix common/ includes.
9256         * target/waitstatus.h: Fix common/ includes.
9257         * target/waitstatus.c: Fix common/ includes.
9258         * target.h: Fix common/ includes.
9259         * target.c: Fix common/ includes.
9260         * target-memory.c: Fix common/ includes.
9261         * target-descriptions.c: Fix common/ includes.
9262         * symtab.h: Fix common/ includes.
9263         * symfile.c: Fix common/ includes.
9264         * stap-probe.c: Fix common/ includes.
9265         * spu-linux-nat.c: Fix common/ includes.
9266         * sparc-nat.c: Fix common/ includes.
9267         * source.c: Fix common/ includes.
9268         * solib.c: Fix common/ includes.
9269         * solib-target.c: Fix common/ includes.
9270         * ser-unix.c: Fix common/ includes.
9271         * ser-tcp.c: Fix common/ includes.
9272         * ser-pipe.c: Fix common/ includes.
9273         * ser-base.c: Fix common/ includes.
9274         * selftest-arch.c: Fix common/ includes.
9275         * s12z-tdep.c: Fix common/ includes.
9276         * rust-exp.y: Fix common/ includes.
9277         * rs6000-aix-tdep.c: Fix common/ includes.
9278         * riscv-tdep.c: Fix common/ includes.
9279         * remote.c: Fix common/ includes.
9280         * remote-notif.h: Fix common/ includes.
9281         * remote-fileio.h: Fix common/ includes.
9282         * remote-fileio.c: Fix common/ includes.
9283         * regcache.h: Fix common/ includes.
9284         * regcache.c: Fix common/ includes.
9285         * record-btrace.c: Fix common/ includes.
9286         * python/python.c: Fix common/ includes.
9287         * python/py-type.c: Fix common/ includes.
9288         * python/py-inferior.c: Fix common/ includes.
9289         * progspace.h: Fix common/ includes.
9290         * producer.c: Fix common/ includes.
9291         * procfs.c: Fix common/ includes.
9292         * proc-api.c: Fix common/ includes.
9293         * printcmd.c: Fix common/ includes.
9294         * ppc-linux-nat.c: Fix common/ includes.
9295         * parser-defs.h: Fix common/ includes.
9296         * osdata.c: Fix common/ includes.
9297         * obsd-nat.c: Fix common/ includes.
9298         * nat/x86-linux.c: Fix common/ includes.
9299         * nat/x86-linux-dregs.c: Fix common/ includes.
9300         * nat/x86-dregs.h: Fix common/ includes.
9301         * nat/x86-dregs.c: Fix common/ includes.
9302         * nat/ppc-linux.c: Fix common/ includes.
9303         * nat/mips-linux-watch.h: Fix common/ includes.
9304         * nat/mips-linux-watch.c: Fix common/ includes.
9305         * nat/linux-waitpid.c: Fix common/ includes.
9306         * nat/linux-ptrace.h: Fix common/ includes.
9307         * nat/linux-ptrace.c: Fix common/ includes.
9308         * nat/linux-procfs.c: Fix common/ includes.
9309         * nat/linux-personality.c: Fix common/ includes.
9310         * nat/linux-osdata.c: Fix common/ includes.
9311         * nat/linux-namespaces.c: Fix common/ includes.
9312         * nat/linux-btrace.h: Fix common/ includes.
9313         * nat/linux-btrace.c: Fix common/ includes.
9314         * nat/fork-inferior.c: Fix common/ includes.
9315         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9316         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9317         * nat/aarch64-linux.c: Fix common/ includes.
9318         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9319         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9320         * namespace.h: Fix common/ includes.
9321         * mips-linux-tdep.c: Fix common/ includes.
9322         * minsyms.c: Fix common/ includes.
9323         * mi/mi-parse.h: Fix common/ includes.
9324         * mi/mi-main.c: Fix common/ includes.
9325         * mi/mi-cmd-env.c: Fix common/ includes.
9326         * memrange.h: Fix common/ includes.
9327         * memattr.c: Fix common/ includes.
9328         * maint.h: Fix common/ includes.
9329         * maint.c: Fix common/ includes.
9330         * main.c: Fix common/ includes.
9331         * machoread.c: Fix common/ includes.
9332         * location.c: Fix common/ includes.
9333         * linux-thread-db.c: Fix common/ includes.
9334         * linux-nat.c: Fix common/ includes.
9335         * linux-fork.c: Fix common/ includes.
9336         * inline-frame.c: Fix common/ includes.
9337         * infrun.c: Fix common/ includes.
9338         * inflow.c: Fix common/ includes.
9339         * inferior.h: Fix common/ includes.
9340         * inferior.c: Fix common/ includes.
9341         * infcmd.c: Fix common/ includes.
9342         * inf-ptrace.c: Fix common/ includes.
9343         * inf-child.c: Fix common/ includes.
9344         * ia64-linux-nat.c: Fix common/ includes.
9345         * i387-tdep.c: Fix common/ includes.
9346         * i386-tdep.c: Fix common/ includes.
9347         * i386-linux-tdep.c: Fix common/ includes.
9348         * i386-linux-nat.c: Fix common/ includes.
9349         * i386-go32-tdep.c: Fix common/ includes.
9350         * i386-fbsd-tdep.c: Fix common/ includes.
9351         * i386-fbsd-nat.c: Fix common/ includes.
9352         * guile/scm-type.c: Fix common/ includes.
9353         * guile/guile.c: Fix common/ includes.
9354         * go32-nat.c: Fix common/ includes.
9355         * gnu-nat.c: Fix common/ includes.
9356         * gdbthread.h: Fix common/ includes.
9357         * gdbarch-selftests.c: Fix common/ includes.
9358         * gdb_usleep.c: Fix common/ includes.
9359         * gdb_select.h: Fix common/ includes.
9360         * gdb_bfd.c: Fix common/ includes.
9361         * gcore.c: Fix common/ includes.
9362         * fork-child.c: Fix common/ includes.
9363         * findvar.c: Fix common/ includes.
9364         * fbsd-nat.c: Fix common/ includes.
9365         * event-top.c: Fix common/ includes.
9366         * event-loop.c: Fix common/ includes.
9367         * dwarf2read.c: Fix common/ includes.
9368         * dwarf2loc.c: Fix common/ includes.
9369         * dwarf2-frame.c: Fix common/ includes.
9370         * dwarf-index-cache.c: Fix common/ includes.
9371         * dtrace-probe.c: Fix common/ includes.
9372         * disasm-selftests.c: Fix common/ includes.
9373         * defs.h: Fix common/ includes.
9374         * csky-tdep.c: Fix common/ includes.
9375         * cp-valprint.c: Fix common/ includes.
9376         * cp-support.h: Fix common/ includes.
9377         * cp-support.c: Fix common/ includes.
9378         * corelow.c: Fix common/ includes.
9379         * completer.h: Fix common/ includes.
9380         * completer.c: Fix common/ includes.
9381         * compile/compile.c: Fix common/ includes.
9382         * compile/compile-loc2c.c: Fix common/ includes.
9383         * compile/compile-cplus-types.c: Fix common/ includes.
9384         * compile/compile-cplus-symbols.c: Fix common/ includes.
9385         * command.h: Fix common/ includes.
9386         * cli/cli-dump.c: Fix common/ includes.
9387         * cli/cli-cmds.c: Fix common/ includes.
9388         * charset.c: Fix common/ includes.
9389         * build-id.c: Fix common/ includes.
9390         * btrace.h: Fix common/ includes.
9391         * btrace.c: Fix common/ includes.
9392         * breakpoint.h: Fix common/ includes.
9393         * breakpoint.c: Fix common/ includes.
9394         * ax.h:
9395         (enum agent_op): Fix common/ includes.
9396         * ax-general.c (struct aop_map): Fix common/ includes.
9397         * ax-gdb.c: Fix common/ includes.
9398         * auxv.c: Fix common/ includes.
9399         * auto-load.c: Fix common/ includes.
9400         * arm-tdep.c: Fix common/ includes.
9401         * arch/riscv.c: Fix common/ includes.
9402         * arch/ppc-linux-common.c: Fix common/ includes.
9403         * arch/i386.c: Fix common/ includes.
9404         * arch/arm.c: Fix common/ includes.
9405         * arch/arm-linux.c: Fix common/ includes.
9406         * arch/arm-get-next-pcs.c: Fix common/ includes.
9407         * arch/amd64.c: Fix common/ includes.
9408         * arch/aarch64.c: Fix common/ includes.
9409         * arch/aarch64-insn.c: Fix common/ includes.
9410         * arch-utils.c: Fix common/ includes.
9411         * amd64-windows-tdep.c: Fix common/ includes.
9412         * amd64-tdep.c: Fix common/ includes.
9413         * amd64-sol2-tdep.c: Fix common/ includes.
9414         * amd64-obsd-tdep.c: Fix common/ includes.
9415         * amd64-nbsd-tdep.c: Fix common/ includes.
9416         * amd64-linux-tdep.c: Fix common/ includes.
9417         * amd64-linux-nat.c: Fix common/ includes.
9418         * amd64-fbsd-tdep.c: Fix common/ includes.
9419         * amd64-fbsd-nat.c: Fix common/ includes.
9420         * amd64-dicos-tdep.c: Fix common/ includes.
9421         * amd64-darwin-tdep.c: Fix common/ includes.
9422         * agent.c: Fix common/ includes.
9423         * ada-lang.h: Fix common/ includes.
9424         * ada-lang.c: Fix common/ includes.
9425         * aarch64-tdep.c: Fix common/ includes.
9426
9427 2019-01-25  Tom Tromey  <tom@tromey.com>
9428
9429         * common/create-version.sh: Use common/version.h.
9430
9431 2019-01-24  Pedro Alves  <palves@redhat.com>
9432
9433         * infrun.c (signal_stop, signal_print, signal_program)
9434         (signal_catch, signal_pass): Now arrays instead of pointers.
9435         (update_signals_program_target, do_target_resume)
9436         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9437         * linux-nat.c (linux_nat_target::pass_signals)
9438         (linux_nat_target::create_inferior, linux_nat_target::attach):
9439         Adjust.
9440         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9441         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9442         * procfs.c (procfs_target::pass_signals): Adjust.
9443         * record-full.c (record_full_target::resume): Adjust.
9444         * remote.c (remote_target::pass_signals)
9445         (remote_target::program_signals): Adjust.
9446         * target-debug.h (target_debug_print_signals): Now takes a
9447         gdb::array_view as parameter.  Adjust.
9448         * target.h (target_ops) <pass_signals, program_signals>: Replace
9449         pointer and length parameters with gdb::array_view.
9450         (target_pass_signals, target_program_signals): Likewise.
9451         * target-delegates.c: Regenerate.
9452
9453 2019-01-24  Pedro Alves  <palves@redhat.com>
9454
9455         * common/forward-scope-exit.h
9456         (forward_scope_exit::forward_scope_exit): Pass arguments to
9457         m_bind_function directly, instead of creating a std::bind and
9458         copying that.
9459
9460 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9461
9462         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9463         for static members.
9464         (pass_in_v_vfp_candidate): Likewise.
9465
9466 2019-01-23  Tom Tromey  <tom@tromey.com>
9467             Pedro Alves  <palves@redhat.com>
9468
9469         * regcache.c (class regcache_invalidator): Remove.
9470         (regcache::raw_write): Use make_scope_exit.
9471
9472 2019-01-23  Tom Tromey  <tom@tromey.com>
9473
9474         * ui-out.h (class ui_out_emit_type): Update comment.
9475
9476 2019-01-23  Tom Tromey  <tom@tromey.com>
9477
9478         * infrun.c (fetch_inferior_event): Update comment.
9479
9480 2019-01-23  Tom Tromey  <tom@tromey.com>
9481             Pedro Alves  <palves@redhat.com>
9482
9483         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9484         parameter.
9485         (fetch_inferior_event): Use SCOPE_EXIT.
9486
9487
9488 2019-01-23  Tom Tromey  <tom@tromey.com>
9489             Pedro Alves  <palves@redhat.com>
9490
9491         * infrun.c (disable_thread_events): Delete.
9492         (stop_all_threads): Use SCOPE_EXIT.
9493
9494 2019-01-23  Tom Tromey  <tom@tromey.com>
9495             Pedro Alves  <palves@redhat.com>
9496
9497         * symfile.c: Include forward-scope-exit.h.
9498         (clear_symtab_users_cleanup): Replace forward declaration with
9499         a FORWARD_SCOPE_EXIT.
9500         (syms_from_objfile_1): Use the forward_scope_exit and
9501         gdb::optional instead of cleanup_function.
9502         (reread_symbols): Use the forward_scope_exit instead of
9503         cleanup_function.
9504         (clear_symtab_users_cleanup): Remove function.
9505
9506 2019-01-23  Tom Tromey  <tom@tromey.com>
9507             Pedro Alves  <palves@redhat.com>
9508
9509         * linux-nat.c: Include scope-exit.h.
9510         (cleanup_target_stop): Remove.
9511         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9512         SCOPE_EXIT.
9513
9514 2019-01-23  Tom Tromey  <tom@tromey.com>
9515             Pedro Alves  <palves@redhat.com>
9516
9517         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9518         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9519
9520 2019-01-23  Tom Tromey  <tom@tromey.com>
9521             Andrew Burgess  <andrew.burgess@embecosm.com>
9522             Pedro Alves  <palves@redhat.com>
9523
9524         * infrun.c (fetch_inferior_event): Use scope_exit.
9525         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9526         * top.c (execute_command): Use scope_exit.
9527         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9528         * utils.c (do_bpstat_clear_actions_cleanup)
9529         (make_bpstat_clear_actions_cleanup): Remove.
9530
9531 2019-01-23  Tom Tromey  <tom@tromey.com>
9532             Pedro Alves  <palves@redhat.com>
9533
9534         * infrun.c: Include "common/scope-exit.h"
9535         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9536         (wait_for_inferior): Use SCOPE_EXIT.
9537         (fetch_inferior_event): Use scope_exit.
9538
9539 2019-01-23  Tom Tromey  <tom@tromey.com>
9540             Pedro Alves  <palves@redhat.com>
9541
9542         * breakpoint.c (create_breakpoint): Remove cleanup.
9543
9544 2019-01-23  Tom Tromey  <tom@tromey.com>
9545             Andrew Burgess  <andrew.burgess@embecosm.com>
9546             Pedro Alves  <palves@redhat.com>
9547
9548 2019-01-23  Pedro Alves  <palves@redhat.com>
9549
9550         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9551
9552 2019-01-23  Pedro Alves  <palves@redhat.com>
9553             Andrew Burgess  <andrew.burgess@embecosm.com>
9554
9555         * gdbthread.h: Include "common/forward-scope-exit.h".
9556         (scoped_finish_thread_state): Redefine custom class in terms of
9557         forward_scope_exit.
9558
9559 2019-01-23  Pedro Alves  <palves@redhat.com>
9560             Andrew Burgess  <andrew.burgess@embecosm.com>
9561
9562         * common/forward-scope-exit.h: New file.
9563
9564 2019-01-23  Pedro Alves  <palves@redhat.com>
9565             Andrew Burgess  <andrew.burgess@embecosm.com>
9566             Tom Tromey  <tom@tromey.com>
9567
9568         * common/scope-exit.h: New file.
9569
9570 2019-01-23  Pedro Alves  <palves@redhat.com>
9571
9572         * common/preprocessor.h (ESC): Rename to ...
9573         (ESC_PARENS): ... this.
9574         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9575         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9576
9577 2019-01-23  Tom Tromey  <tom@tromey.com>
9578
9579         * language.h (class scoped_switch_to_sym_language_if_auto):
9580         Initialize m_lang in both cases.
9581
9582 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9583
9584         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9585         with XCNEW.
9586
9587 2019-01-22  Tom Tromey  <tom@tromey.com>
9588
9589         * corelow.c: Do not include sys/file.h.
9590
9591 2019-01-22  Tom Tromey  <tom@tromey.com>
9592
9593         * tui/tui-wingeneral.h: Include gdb_curses.h.
9594
9595 2019-01-22  Tom Tromey  <tom@tromey.com>
9596
9597         * source-cache.h (class source_cache) <get_source_lines,
9598         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9599
9600 2019-01-22  Tom Tromey  <tom@tromey.com>
9601
9602         * remote-fileio.h (struct remote_target): Declare.
9603
9604 2019-01-22  Tom Tromey  <tom@tromey.com>
9605
9606         * python/py-arch.c: Do not include py-ref.h.
9607         * python/py-bpevent.c: Do not include py-ref.h.
9608         * python/py-cmd.c: Do not include py-ref.h.
9609         * python/py-continueevent.c: Do not include py-ref.h.
9610         * python/py-event.h: Do not include py-ref.h.
9611         * python/py-evtregistry.c: Do not include py-ref.h.
9612         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9613         * python/py-frame.c: Do not include py-ref.h.
9614         * python/py-framefilter.c: Do not include py-ref.h.
9615         * python/py-function.c: Do not include py-ref.h.
9616         * python/py-infevents.c: Do not include py-ref.h.
9617         * python/py-linetable.c: Do not include py-ref.h.
9618         * python/py-objfile.c: Do not include py-ref.h.
9619         * python/py-param.c: Do not include py-ref.h.
9620         * python/py-prettyprint.c: Do not include py-ref.h.
9621         * python/py-progspace.c: Do not include py-ref.h.
9622         * python/py-symbol.c: Do not include py-ref.h.
9623         * python/py-symtab.c: Do not include py-ref.h.
9624         * python/py-type.c: Do not include py-ref.h.
9625         * python/py-unwind.c: Do not include py-ref.h.
9626         * python/py-utils.c: Do not include py-ref.h.
9627         * python/py-value.c: Do not include py-ref.h.
9628         * python/py-varobj.c: Do not include py-ref.h.
9629         * python/py-xmethods.c: Do not include py-ref.h.
9630         * python/python.c: Do not include py-ref.h.
9631         * varobj.c: Do not include py-ref.h.
9632
9633 2019-01-22  Tom Tromey  <tom@tromey.com>
9634
9635         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9636         keyword for bcache.
9637
9638 2019-01-22  Tom Tromey  <tom@tromey.com>
9639
9640         * compile/compile-cplus-types.c: Remove a comment by #include.
9641
9642 2019-01-22  Tom Tromey  <tom@tromey.com>
9643
9644         * compile/gcc-c-plugin.h: Include compile-internal.h.
9645
9646 2019-01-22  Tom Tromey  <tom@tromey.com>
9647
9648         * stabsread.c (EXTERN): Do not define.
9649         (symnum, next_symbol_text_func, processing_gcc_compilation)
9650         (within_function, global_sym_chain, global_stabs)
9651         (previous_stab_code, this_object_header_files)
9652         (n_this_object_header_files)
9653         (n_allocated_this_object_header_files): Define.
9654         * stabsread.h (EXTERN): Never define.  Use "extern".
9655
9656 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9657
9658         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9659         history_value.
9660
9661 2019-01-21  Tom Tromey  <tom@tromey.com>
9662
9663         * ui-out.c: Fix includes.
9664         * tui/tui-source.c: Fix includes.
9665         * target.c: Fix includes.
9666         * remote.c: Fix includes.
9667         * regcache.c: Fix includes.
9668         * python/py-block.c: Fix includes.
9669         * printcmd.c: Fix includes.
9670         * or1k-tdep.c: Fix includes.
9671         * mi/mi-main.c: Fix includes.
9672         * m32r-tdep.c: Fix includes.
9673         * csky-tdep.c: Fix includes.
9674         * compile/compile-cplus-types.c: Fix includes.
9675         * cli/cli-interp.c: Fix includes.
9676
9677 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9678
9679         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9680         for padding.
9681
9682 2019-01-16  Tom Tromey  <tom@tromey.com>
9683
9684         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9685         earlier.
9686         (struct objfile) <msymbols_range>: Move from top level.
9687         <msymbols>: New method.
9688         (class objfile_msymbols): Remove.
9689         * symtab.c (default_collect_symbol_completion_matches_break_on):
9690         Update.
9691         * symmisc.c (dump_msymbols): Update.
9692         * stabsread.c (scan_file_globals): Update.
9693         * objc-lang.c (info_selectors_command, info_classes_command)
9694         (find_methods): Update.
9695         * minsyms.c (find_solib_trampoline_target): Update.
9696         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9697         * coffread.c (coff_symfile_read): Update.
9698         * ada-lang.c (ada_lookup_simple_minsym)
9699         (ada_collect_symbol_completion_matches): Update.
9700
9701 2019-01-16  Tom Tromey  <tom@tromey.com>
9702
9703         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9704         type.  Remove no-argument constructor.
9705         <iterator::operator++>: Simplify.
9706         <begin>: Update.
9707         <end>: Use minimal_symbol_count.
9708
9709 2019-01-16  Tom Tromey  <tom@tromey.com>
9710
9711         * objfiles.h (struct objfile) <psymtabs>: New method.
9712         (class objfile_psymtabs): Remove.
9713         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9714         typedef.
9715         <range>: New method.
9716         (require_partial_symbols): Change return type.
9717         * psymtab.c (require_partial_symbols)
9718         (psym_expand_symtabs_matching): Update.
9719         * mdebugread.c (parse_partial_symbols): Update.
9720         * dbxread.c (dbx_end_psymtab): Update.
9721
9722 2019-01-15  Tom Tromey  <tom@tromey.com>
9723
9724         * symtab.c (lookup_objfile_from_block)
9725         (lookup_symbol_in_objfile_symtabs)
9726         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9727         (find_line_symtab, info_sources_command)
9728         (default_collect_symbol_completion_matches_break_on)
9729         (make_source_files_completion_list): Update.
9730         * symmisc.c (print_objfile_statistics, dump_objfile)
9731         (maintenance_print_symbols, maintenance_info_symtabs)
9732         (maintenance_check_symtabs, maintenance_info_line_tables):
9733         Update.
9734         * source.c (select_source_symtab)
9735         (forget_cached_source_info_for_objfile): Update.
9736         * objfiles.h (class objfile_compunits): Remove.
9737         (struct objfile) <compunits_range>: New typedef.
9738         (compunits): New method.
9739         * objfiles.c (objfile_relocate1): Update.
9740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9741         * maint.c (count_symtabs_and_blocks): Update.
9742         * linespec.c (iterate_over_all_matching_symtabs): Update.
9743         * cp-support.c (add_symbol_overload_list_qualified): Update.
9744         * coffread.c (coff_symtab_read): Update.
9745         * ada-lang.c (add_nonlocal_symbols)
9746         (ada_collect_symbol_completion_matches)
9747         (ada_add_global_exceptions): Update.
9748
9749 2019-01-15  Tom Tromey  <tom@tromey.com>
9750
9751         * progspace.h (program_space) <objfiles_safe_range>: New
9752         typedef.
9753         <objfiles_safe>: New method.
9754         * objfiles.h (class all_objfiles_safe): Remove.
9755         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9756         * jit.c (jit_inferior_exit_hook): Update.
9757
9758 2019-01-17  Tom Tromey  <tom@tromey.com>
9759
9760         * progspace.h (program_space) <objfiles_range>: New typedef.
9761         <objfiles>: New method.
9762         <objfiles_head>: Rename from objfiles.
9763         (object_files): Update.
9764         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9765         * guile/scm-pretty-print.c
9766         (ppscm_find_pretty_printer_from_objfiles): Update.
9767         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9768         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9769         Update.
9770         * python/py-progspace.c (pspy_get_objfiles): Update.
9771         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9772         Update.
9773         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9774         (objfpy_lookup_objfile_by_build_id): Update.
9775         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9776         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9777         Update.
9778         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9779         (expand_symtab_containing_pc, lookup_objfile_from_block)
9780         (lookup_static_symbol, basic_lookup_transparent_type)
9781         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9782         (find_line_symtab, info_sources_command)
9783         (default_collect_symbol_completion_matches_break_on)
9784         (make_source_files_completion_list, find_main_name): Update.
9785         * symmisc.c (print_symbol_bcache_statistics)
9786         (print_objfile_statistics, maintenance_print_symbols)
9787         (maintenance_print_msymbols, maintenance_print_objfiles)
9788         (maintenance_info_symtabs, maintenance_check_symtabs)
9789         (maintenance_expand_symtabs, maintenance_info_line_tables):
9790         Update.
9791         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9792         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9793         (map_overlay_command, unmap_overlay_command)
9794         (simple_overlay_update, expand_symtabs_matching)
9795         (map_symbol_filenames): Update.
9796         * symfile-debug.c (set_debug_symfile): Update.
9797         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9798         Update.
9799         * source.c (select_source_symtab, forget_cached_source_info):
9800         Update.
9801         * solib.c (solib_read_symbols): Update.
9802         * solib-spu.c (append_ocl_sos): Update.
9803         * psymtab.c (maintenance_print_psymbols)
9804         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9805         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9806         * printcmd.c (info_symbol_command): Update.
9807         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9808         Update.
9809         * objfiles.h (class all_objfiles): Remove.
9810         * objfiles.c (have_partial_symbols, have_full_symbols)
9811         (have_minimal_symbols, qsort_cmp, update_section_map)
9812         (shared_objfile_contains_address_p)
9813         (default_iterate_over_objfiles_in_search_order): Update.
9814         * objc-lang.c (info_selectors_command, info_classes_command)
9815         (find_methods): Update.
9816         * minsyms.c (find_solib_trampoline_target): Update.
9817         * maint.c (maintenance_info_sections)
9818         (maintenance_translate_address, count_symtabs_and_blocks):
9819         Update.
9820         * main.c (captured_main_1): Update.
9821         * linux-thread-db.c (try_thread_db_load_from_pdir)
9822         (has_libpthread): Update.
9823         * linespec.c (iterate_over_all_matching_symtabs)
9824         (search_minsyms_for_name): Update.
9825         * jit.c (jit_find_objf_with_entry_addr): Update.
9826         * hppa-tdep.c (find_unwind_entry)
9827         (hppa_lookup_stub_minimal_symbol): Update.
9828         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9829         Update.
9830         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9831         (elf_gnu_ifunc_resolve_by_got): Update.
9832         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9833         * dwarf-index-write.c (save_gdb_index_command): Update.
9834         * cp-support.c (add_symbol_overload_list_qualified): Update.
9835         * breakpoint.c (create_overlay_event_breakpoint)
9836         (create_longjmp_master_breakpoint)
9837         (create_std_terminate_master_breakpoint)
9838         (create_exception_master_breakpoint): Update.
9839         * blockframe.c (find_pc_partial_function): Update.
9840         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9841         (ada_collect_symbol_completion_matches)
9842         (ada_add_global_exceptions): Update.
9843
9844 2019-01-17  Tom Tromey  <tom@tromey.com>
9845
9846         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9847         declare VEC.
9848         (solib_target_parse_libraries): Change return type.
9849         (library_list_start_segment, library_list_start_section)
9850         (library_list_end_library, library_list_start_library); Update.
9851         (solib_target_free_library_list): Remove.
9852         (solib_target_parse_libraries): Remove cleanup.  Change return
9853         type.
9854         (solib_target_current_sos): Update.
9855
9856 2019-01-17  Tom Tromey  <tromey@bapiya>
9857
9858         * valprint.c: Replace "the the" with "the".
9859         * symtab.c: Replace "the the" with "the".
9860         * solib.c: Replace "the the" with "the".
9861         * solib-dsbt.c: Replace "the the" with "the".
9862         * linespec.c: Replace "the the" with "the".
9863         * dwarf2loc.h: Replace "the the" with "the".
9864         * amd64-windows-tdep.c: Replace "the the" with "the".
9865         * aarch64-tdep.c: Replace "the the" with "the".
9866
9867 2019-01-16  Keith Seitz  <keiths@redhat.com>
9868
9869         PR gdb/23773
9870         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9871         <builder>: Rename to ..
9872         <m_builder>: ... this and make private.
9873         (dwarf2_cu::get_builder): New method.  Change all users of
9874         `builder' to use this method.
9875         (dwarf2_start_symtab): Move to ...
9876         (dwarf2_cu::start_symtab): ... here.  Update all callers
9877         (setup_type_unit_groups): Move to ...
9878         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9879         callers.
9880         (dwarf2_cu::reset_builder): New method.
9881         (process_full_compunit, process_full_type_unit): Use
9882         dwarf2_cu::reset_builder.
9883         (follow_die_offset): Record the ancestor CU if it is different
9884         from the followed DIE's CU.
9885         (follow_die_sig_1): Likewise.
9886
9887 2019-01-15  Tom Tromey  <tom@tromey.com>
9888
9889         * remote.c (class remote_state) <buf>: Now a char_vector.
9890         <buf_size>: Remove.
9891         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9892         parameter.
9893         (remote_target::getpkt_or_notif_sane_1)
9894         (remote_target::getpkt_sane)
9895         (remote_target::getpkt_or_notif_sane): Likewise.
9896         (class remote_target) <putpkt>: New overload.
9897         (remote_target::read_frame): Change type of "buf_p".  Remove
9898         sizeof_p parameter.
9899         (packet_ok): New overload.
9900         (packet_check_result): New overload.
9901         Update all uses.
9902
9903 2019-01-14  Tom Tromey  <tom@tromey.com>
9904
9905         * remote-notif.c (handle_notification, remote_notif_ack)
9906         (remote_notif_parse): Make "buf" const.
9907         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9908         const.
9909         (remote_notif_parse, remote_notif_ack, handle_notification):
9910         Likewise.
9911         * remote.c (remote_notif_stop_parse): Make "buf" const.
9912         (remote_target::remote_parse_stop_reply): Make "buf" const.
9913         (remote_notif_stop_ack): Make "buf" const.
9914
9915 2019-01-14  Tom Tromey  <tom@tromey.com>
9916
9917         * remote.c (remote_console_output): Make parameter const.
9918
9919 2019-01-14  Tom Tromey  <tom@tromey.com>
9920
9921         * target-debug.h (target_debug_print_signals): Constify.
9922         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9923         * procfs.c (procfs_target::pass_signals): Update.
9924         * linux-nat.c (linux_nat_target::pass_signals): Update.
9925         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9926         * target-delegates.c: Rebuild.
9927         * remote.c (remote_target::program_signals): Update.
9928         (remote_target::pass_signals): Update.
9929         * target.c (target_pass_signals): Constify argument.
9930         (target_program_signals): Likewise.
9931         * target.h (struct target_ops) <pass_signals, program_signals>:
9932         Constify argument.
9933         (target_pass_signals, target_program_signals): Constify argument.
9934
9935 2019-01-14  Tom Tromey  <tom@tromey.com>
9936
9937         PR tui/28819:
9938         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9939
9940 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9941
9942         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9943         field.
9944         * rs6000-tdep.c: Include reggroups.h.
9945         (IS_V_ALIAS_PSEUDOREG): Define.
9946         (rs6000_register_name): Return names for the "vX" aliases.
9947         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9948         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9949         aliases.  Call default_register_reggroup_p for all other
9950         pseudo-registers.
9951         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9952         New functions.
9953         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9954         Handle "vX" aliases.
9955         (v_alias_pseudo_register_collect): New function.
9956         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9957         (rs6000_gdbarch_init): Initialize "vX" aliases as
9958         pseudo-registers.  Restore registration of
9959         rs6000_pseudo_register_reggroup_p with
9960         set_tdesc_pseudo_register_reggroup_p.
9961
9962 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9963
9964         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9965         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9966         set_gdbarch_num_pseudo_regs.
9967
9968 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9969
9970         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9971         Remove arg prefixname, add do_set and do_show.
9972         Add member functions set_list and show_list.
9973         * cli/cli-style.c (class cli_style_option): Update accordingly.
9974         (style_set_list): Move to file scope.
9975         (style_show_list): Likewise.
9976         (set_style): Call help_list.
9977         (show_style): Call cmd_show_list.
9978         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9979         Update to use the new macro.
9980
9981 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9982
9983         * ada-lang.c (_initialize_ada_language): Expand the help text
9984         for the "catch exception" command.
9985
9986 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9987
9988         * symtab.c (matching_obj_sections): Initialize obj,
9989         declare it closer to its usage.
9990
9991 2019-01-10  Tom Tromey  <tom@tromey.com>
9992
9993         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9994         (basic_inf_threads_range): Remove.
9995         (inf_threads_range, inf_non_exited_threads_range)
9996         (safe_inf_threads_range): Use next_adapter.
9997
9998 2019-01-10  Keith Seitz  <keiths@redhat.com>
9999
10000         PR gdb/23712
10001         PR symtab/23010
10002         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10003         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10004
10005 2019-01-10  Keith Seitz  <keiths@redhat.com>
10006
10007         PR gdb/23712
10008         PR symtab/23010
10009         * dictionary.c (pending_to_vector): Remove.
10010         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10011         Remove _1 suffix, replacing functions of the same name.  Update
10012         all callers.
10013         (dict_create_hashed, dict_create_hashed_expandable)
10014         (dict_create_linear, dict_create_linear_expandable, dict_free)
10015         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10016         Make functions static.
10017
10018 2019-01-10  Keith Seitz  <keiths@redhat.com>
10019
10020         PR gdb/23712
10021         PR symtab/23010
10022         * dictionary.h (struct dictionary): Replace declaration with
10023         multidictionary.
10024         (dict_create_hashed, dict_create_hashed_expandable)
10025         (dict_create_linear, dict_create_linear_expandable)
10026         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10027         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10028         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10029         taking multidictionary argument.
10030         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10031         * block.h (struct block) <dict>: Change to multidictionary
10032         and rename `multidict'.
10033         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10034         symmisc.c: Update all dictionary references to multidictionary.
10035
10036 2019-01-10  Keith Seitz  <keiths@redhat.com>
10037
10038         PR gdb/23712
10039         PR symtab/23010
10040         * dictionary.c: Include unordered_map.
10041         (pending_to_vector): New function.
10042         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10043         Rewrite the non-"_1" functions to take vector instead
10044         of linked list.
10045         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10046         "new" _1 versions of the same name.
10047         (multidictionary): Define.
10048         (std::hash<enum language): New definition.
10049         (collate_pending_symbols_by_language, mdict_create_hashed)
10050         (mdict_create_hashed_expandable, mdict_create_linear)
10051         (mdict_create_linear_expandable, mdict_free)
10052         (find_language_dictionary, create_new_language_dictionary)
10053         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10054         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10055         (mdict_size, mdict_empty): New functions.
10056         * dictionary.h (mdict_iterator): Define.
10057
10058 2019-01-10  Pedro Alves  <palves@redhat.com>
10059
10060         * breakpoint.c (read_uploaded_action)
10061         (create_tracepoint_from_upload): Adjust to use
10062         gdb::unique_xmalloc_ptr.
10063         * ctf.c (ctf_write_uploaded_tp):
10064         (SET_ARRAY_FIELD): Use emplace_back.
10065         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10066         * tracefile-tfile.c (tfile_write_uploaded_tp):
10067         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10068         gdb::unique_xmalloc_ptr.
10069         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10070         at_string, cond_string, cmd_strings>: Replace char pointers
10071         with gdb::unique_xmalloc_ptr.
10072
10073 2019-01-10  Pedro Alves  <palves@redhat.com>
10074
10075         * solib-target.c (library_list_start_library): Don't xstrdup name.
10076
10077 2019-01-10  Pedro Alves  <palves@redhat.com>
10078
10079         * mdebugread.c (parse_partial_symbols): Use
10080         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10081
10082 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10083
10084         * linux-fork.c (scoped_switch_fork_info)
10085         <~scoped_switch_fork_info>: Fix incorrect variable name.
10086
10087 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10088
10089         * linux-fork.c (scoped_switch_fork_info)
10090         <scoped_switch_fork_info>: Make explicit.
10091         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10092
10093 2019-01-10  Tom Tromey  <tom@tromey.com>
10094
10095         * objfiles.h (objfile::reset_psymtabs): Update.
10096         * objfiles.c (objfile::objfile): Update.
10097         * psymtab.h (psymtab_storage::obstack): Update.
10098         (psymtab_storage::m_obstack): Use gdb::optional.
10099         (class psymtab_storage): Update comment.  Remove objfile
10100         parameter.
10101         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10102
10103 2019-01-10  Tom Tromey  <tom@tromey.com>
10104
10105         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10106         <free_psymtabs>: Now private.
10107         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10108         (allocate_psymtab): Use new method.
10109
10110 2019-01-10  Tom Tromey  <tom@tromey.com>
10111
10112         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10113         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10114         * mdebugread.c (parse_partial_symbols): Use
10115         allocate_dependencies.
10116         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10117         allocate_dependencies.
10118         (process_psymtab_comp_unit_reader)
10119         (build_type_psymtab_dependencies): Likewise.
10120         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10121
10122 2019-01-10  Tom Tromey  <tom@tromey.com>
10123
10124         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10125         PSYMBOL_SET_LANGUAGE.
10126         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10127
10128 2019-01-10  Tom Tromey  <tom@tromey.com>
10129
10130         * psymtab.h (psymtab_storage::obstack): New method.
10131         <m_obstack>: Rename from obstack; now private.
10132         * psymtab.c (psymtab_storage): Update.
10133         * dwarf2read.c (create_addrmap_from_index)
10134         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10135         Update.
10136
10137 2019-01-10  Tom Tromey  <tom@tromey.com>
10138
10139         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10140         * objfiles.h (objfile::reset_psymtabs): New method.
10141
10142 2019-01-10  Tom Tromey  <tom@tromey.com>
10143
10144         * symmisc.c (print_symbol_bcache_statistics): Update.
10145         (print_objfile_statistics): Update.
10146         * symfile.c (reread_symbols): Update.
10147         * psymtab.h (class psymtab_storage): New.
10148         * psymtab.c (psymtab_storage): New constructor.
10149         (~psymtab_storage): New destructor.
10150         (require_partial_symbols): Update.
10151         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10152         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10153         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10154         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10155         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10156         (start_psymtab_common, end_psymtab_common)
10157         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10158         (allocate_psymtab): Update.
10159         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10160         Update.
10161         (dump_psymtab_addrmap, maintenance_print_psymbols)
10162         (maintenance_check_psymtabs): Update.
10163         (class objfile_psymtabs): Move to objfiles.h.
10164         * psympriv.h (discard_psymtab): Now inline.
10165         (psymtab_discarder::psymtab_discarder): Update.
10166         (psymtab_discarder::~psymtab_discarder): Update.
10167         (ALL_OBJFILE_PSYMTABS): Rewrite.
10168         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10169         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10170         Remove fields.
10171         <partial_symtabs>: New field.
10172         (class objfile_psymtabs): Move from psymtab.h.  Update.
10173         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10174         psymbol_cache.
10175         (objfile::~objfile): Don't destroy psymbol_cache.
10176         * mdebugread.c (parse_partial_symbols): Update.
10177         * dwarf2read.c (create_addrmap_from_index)
10178         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10179         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10180         (add_partial_subprogram, dwarf2_ranges_read): Update.
10181         * dwarf-index-write.c (write_address_map)
10182         (write_one_signatured_type, recursively_write_psymbols)
10183         (class debug_names, class debug_names, write_psymtabs_to_index):
10184         Update.
10185
10186 2019-01-10  Tom Tromey  <tom@tromey.com>
10187
10188         * symtab.h (SYMBOL_SET_NAMES): Update.
10189         (symbol_set_names): Update.
10190         (MSYMBOL_SET_NAMES): Update.
10191         * symtab.c (symbol_set_names): Change argument to be an
10192         objfile_per_bfd_storage.
10193         * psymtab.c (add_psymbol_to_bcache): Update.
10194         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10195
10196 2019-01-10  Tom Tromey  <tom@tromey.com>
10197
10198         * symtab.c (create_demangled_names_hash): Change argument to be an
10199         objfile_per_bfd_storage.
10200         (symbol_set_names): Update.
10201
10202 2019-01-10  Tom Tromey  <tom@tromey.com>
10203
10204         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10205         init_psymbol_list.
10206         * psymtab.c (init_psymbol_list): Do nothing if already called.
10207         * psympriv.h (init_psymbol_list): Add comment.
10208         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10209         init_psymbol_list.
10210         * dbxread.c (dbx_symfile_read): Unconditionally call
10211         init_psymbol_list.
10212
10213 2019-01-10  Tom Tromey  <tom@tromey.com>
10214
10215         * xcoffread.c (scan_xcoff_symtab): Update.
10216         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10217         "where".
10218         * mdebugread.c (parse_partial_symbols)
10219         (handle_psymbol_enumerators): Update.
10220         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10221         * dbxread.c (read_dbx_symtab): Update.
10222         * psympriv.h (psymbol_placement): New enum.
10223         (add_psymbol_to_list): Update.
10224
10225 2019-01-10  Tom Tromey  <tom@tromey.com>
10226
10227         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10228         static_psymbols parameters.
10229         (scan_xcoff_symtab): Update.
10230         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10231         static_psymbols parameters.
10232         * psympriv.h (start_psymtab_common): Update.
10233         * mdebugread.c (parse_partial_symbols): Update.
10234         * dwarf2read.c (create_partial_symtab): Update.
10235         * dbxread.c (read_dbx_symtab): Update.
10236         (start_psymtab): Remove global_psymbols and static_psymbols
10237         parameters.
10238
10239 2019-01-10  Tom Tromey  <tom@tromey.com>
10240
10241         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10242         * psymtab.c (allocate_psymtab): Add comment.
10243         * psympriv.h (allocate_psymtab): Add comment.
10244         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10245         initializations.
10246         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10247
10248 2019-01-10  Tom Tromey  <tom@tromey.com>
10249
10250         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10251         Don't declare.
10252         * mipsread.c: Include mdebugread.h.
10253         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10254         Declare.
10255         * elfread.c: Include mdebugread.h.
10256
10257 2019-01-09  Tom Tromey  <tom@tromey.com>
10258
10259         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10260         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10261         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10262         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10263         (psym_lookup_symbol, psym_find_last_source_symtab)
10264         (psym_forget_cached_source_info, psym_print_stats)
10265         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10266         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10267         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10268         (psym_find_compunit_symtab_by_address)
10269         (maintenance_print_psymbols, maintenance_info_psymtabs)
10270         (maintenance_check_psymtabs): Use ranged for.
10271         * psymtab.h (class objfile_psymtabs): New.
10272         (require_partial_symbols): Return objfile_psymtabs.
10273         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10274
10275 2019-01-09  Tom Tromey  <tom@tromey.com>
10276
10277         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10278         (find_pc_mapped_section, list_overlays_command)
10279         (map_overlay_command, unmap_overlay_command)
10280         (simple_overlay_update): Use all_objfiles.
10281         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10282         * printcmd.c (info_symbol_command): Use all_objfiles.
10283         * objfiles.h (ALL_OBJSECTIONS): Remove.
10284         * maint.c (maintenance_translate_address): Use all_objfiles.
10285         * gcore.c (gcore_create_callback): Use all_objfiles.
10286         (objfile_find_memory_regions): Likewise.
10287
10288 2019-01-09  Tom Tromey  <tom@tromey.com>
10289
10290         * symtab.c (find_line_symtab, info_sources_command)
10291         (make_source_files_completion_list): Use objfile_compunits.
10292         * source.c (select_source_symtab): Use objfile_compunits.
10293         * objfiles.h (struct objfile): Update comment.
10294         (ALL_OBJFILES): Remove.
10295         (ALL_FILETABS): Remove.
10296         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10297         objfile_compunits.
10298
10299 2019-01-09  Tom Tromey  <tom@tromey.com>
10300
10301         * symmisc.c (print_objfile_statistics, dump_objfile)
10302         (maintenance_print_symbols): Use compunit_filetabs.
10303         * source.c (forget_cached_source_info_for_objfile): Use
10304         compunit_filetabs.
10305         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10306         (ALL_FILETABS): Use compunit_filetabs.
10307         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10308         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10309
10310 2019-01-09  Tom Tromey  <tom@tromey.com>
10311
10312         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10313         (compunit_filetabs): New.
10314         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10315         compunit_filetabs.
10316         (info_sources_command, make_source_files_completion_list): Remove
10317         declaration.
10318         * symmisc.c (print_objfile_statistics, dump_objfile)
10319         (maintenance_print_symbols): Remove declaration.
10320         (maintenance_info_symtabs): Use compunit_filetabs.
10321         (maintenance_info_line_tables): Likewise.
10322         * source.c (select_source_symtab): Change local variable name.
10323         (forget_cached_source_info_for_objfile): Remove declaration.
10324         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10325         * objfiles.c (objfile_relocate1): Remove declaration.
10326         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10327         declaration.
10328         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10329         * coffread.c (coff_symtab_read): Remove declaration.
10330         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10331         compunit_filetabs.
10332
10333 2019-01-09  Tom Tromey  <tom@tromey.com>
10334
10335         * symtab.c (lookup_objfile_from_block)
10336         (find_pc_sect_compunit_symtab, search_symbols)
10337         (default_collect_symbol_completion_matches_break_on): Use
10338         objfile_compunits.
10339         * objfiles.h (ALL_COMPUNITS): Remove.
10340         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10341         * cp-support.c (add_symbol_overload_list_qualified): Use
10342         objfile_compunits.
10343         * ada-lang.c (ada_collect_symbol_completion_matches)
10344         (ada_add_global_exceptions): Use objfile_compunits.
10345
10346 2019-01-09  Tom Tromey  <tom@tromey.com>
10347
10348         * source.c (select_source_symtab)
10349         (forget_cached_source_info_for_objfile): Remove declaration.
10350         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10351         declaration.
10352         * maint.c (count_symtabs_and_blocks): Remove declaration.
10353         * cp-support.c (add_symbol_overload_list_qualified): Remove
10354         declaration.
10355         * coffread.c (coff_symtab_read): Remove declaration.
10356         * symtab.c (lookup_symbol_in_objfile_symtabs)
10357         (basic_lookup_transparent_type_1): Use objfile_compunits.
10358         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10359         (info_sources_command, search_symbols)
10360         (default_collect_symbol_completion_matches_break_on)
10361         (make_source_files_completion_list): Remove declaration.
10362         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10363         (ada_collect_symbol_completion_matches)
10364         (ada_add_global_exceptions): Remove declaration.
10365         * linespec.c (iterate_over_all_matching_symtabs): Use
10366         objfile_compunits.
10367         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10368         (class objfile_compunits): New.
10369         (ALL_COMPUNITS): Use objfile_compunits.
10370         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10371         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10372         objfile_compunits.
10373         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10374
10375 2019-01-09  Tom Tromey  <tom@tromey.com>
10376
10377         * symtab.c (search_symbols)
10378         (default_collect_symbol_completion_matches_break_on): Use
10379         objfile_msymbols.
10380         * ada-lang.c (ada_lookup_simple_minsym)
10381         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10382         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10383         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10384         objfile_msymbols.
10385         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10386         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10387         * objc-lang.c (find_methods): Use objfile_msymbols.
10388         (info_selectors_command, info_classes_command): Likewise.
10389         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10390         * objfiles.h (class objfile_msymbols): New.
10391         (ALL_OBJFILE_MSYMBOLS): Remove.
10392         (ALL_MSYMBOLS): Remove.
10393
10394 2019-01-09  Tom Tromey  <tom@tromey.com>
10395
10396         * common/next-iterator.h (next_adapter): Add Iterator template
10397         parameter.
10398         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10399         (class all_objfiles_safe): New.
10400         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10401         * objfiles.c (put_objfile_before): Update comment.
10402         (add_separate_debug_objfile): Likewise.
10403         (free_all_objfiles): Use all_objfiles_safe.
10404         (objfile_purge_solibs): Likewise.
10405
10406 2019-01-09  Tom Tromey  <tom@tromey.com>
10407
10408         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10409         (expand_symtab_containing_pc, lookup_static_symbol)
10410         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10411         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10412         all_objfiles.
10413         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10414         * breakpoint.c (create_overlay_event_breakpoint)
10415         (create_longjmp_master_breakpoint)
10416         (create_std_terminate_master_breakpoint)
10417         (create_exception_master_breakpoint): Use all_objfiles.
10418         * linux-thread-db.c (try_thread_db_load_from_pdir)
10419         (has_libpthread): Use all_objfiles.
10420         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10421         * linespec.c (iterate_over_all_matching_symtabs)
10422         (search_minsyms_for_name): Use all_objfiles.
10423         * maint.c (maintenance_info_sections): Use all_objfiles.
10424         * main.c (captured_main_1): Use all_objfiles.
10425         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10426         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10427         * guile/scm-pretty-print.c
10428         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10429         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10430         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10431         (maintenance_print_msymbols): Use all_objfiles.
10432         * source.c (select_source_symtab): Use all_objfiles.
10433         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10434         * symfile.c (remove_symbol_file_command)
10435         (expand_symtabs_matching, map_symbol_filenames): Use
10436         all_objfiles.
10437         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10438         all_objfiles.
10439         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10440         * objc-lang.c (find_methods): Use all_objfiles.
10441         * objfiles.c (have_partial_symbols, have_full_symbols)
10442         (have_minimal_symbols, qsort_cmp)
10443         (default_iterate_over_objfiles_in_search_order): Use
10444         all_objfiles.
10445         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10446         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10447         (maintenance_check_psymtabs): Use all_objfiles.
10448         (ALL_PSYMTABS): Remove.
10449         * compile/compile-object-run.c (do_module_cleanup): Use
10450         all_objfiles.
10451         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10452         * cp-support.c (add_symbol_overload_list_qualified): Use
10453         all_objfiles.
10454         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10455         Use all_objfiles.
10456         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10457         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10458         all_objfiles.
10459         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10460         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10461         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10462         Uses all_objfiles.
10463         * solib.c (solib_read_symbols): Use all_objfiles
10464
10465 2019-01-09  Tom Tromey  <tom@tromey.com>
10466
10467         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10468         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10469         all_objfiles.
10470         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10471         * symmisc.c (print_symbol_bcache_statistics)
10472         (print_objfile_statistics, maintenance_print_objfiles)
10473         (maintenance_info_symtabs, maintenance_check_symtabs)
10474         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10475         all_objfiles.
10476         * source.c (forget_cached_source_info): Use all_objfiles.
10477         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10478         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10479         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10480         * objfiles.c (update_section_map): Use all_objfiles.
10481         (shared_objfile_contains_address_p): Likewise.
10482         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10483         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10484
10485 2019-01-09  Tom Tromey  <tom@tromey.com>
10486
10487         * common/next-iterator.h: New file.
10488         * objfiles.h (class all_objfiles): New.
10489         (struct objfile_iterator): New.
10490
10491 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10492
10493         * NEWS: Move the description of the changed "frame", "select-frame",
10494          and "info frame" commands to the Changed commands section.
10495
10496 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10497
10498         * gdbtypes.c (check_stub_method_group): Remove handling of old
10499         mangling schemes.
10500         * linespec.c (find_methods): Likewise.
10501         * stabsread.c (read_member_functions): Likewise.
10502         * valops.c (search_struct_method): Likewise.
10503         (value_struct_elt_for_reference): Likewise.
10504         * NEWS: Mention this change.
10505
10506 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10507
10508         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10509         print_source_lines.
10510         * source.c (print_source_lines_base): Update line number check.
10511         (print_source_lines): New function.
10512         (source_lines_range::source_lines_range): New function.
10513         * source.h (class source_lines_range): New class.
10514         (print_source_lines): New declaration.
10515
10516 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10517
10518         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10519
10520 2019-01-08  Tom Tromey  <tom@tromey.com>
10521             Simon Marchi  <simon.marchi@ericsson.com>
10522
10523         PR gdb/24060
10524         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10525         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10526         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10527         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10528         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10529         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10530
10531 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10532
10533         * source.c (select_source_symtab): Move header comment to
10534         declaration in source.h.
10535         (forget_cached_source_info_for_objfile): Likewise.
10536         (forget_cached_source_info): Likewise.
10537         (identify_source_line): Likewise.
10538         * source.h (identify_source_line): Move declaration from symtab.h
10539         and add comment from source.c
10540         (print_source_lines): Likewise.
10541         (forget_cached_source_info_for_objfile): Likewise.
10542         (forget_cached_source_info): Likewise.
10543         (select_source_symtab): Likewise.
10544         (enum print_source_lines_flag): Move definition from symtab.h.
10545         * symtab.h (identify_source_line): Move declaration to source.h.
10546         (print_source_lines): Likewise.
10547         (forget_cached_source_info_for_objfile): Likewise.
10548         (forget_cached_source_info): Likewise.
10549         (select_source_symtab): Likewise.
10550         (enum print_source_lines_flag): Move definition to source.h.
10551         * tui/tui-hooks.c: Add 'source.h' include.
10552
10553 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10554
10555         * source.c (print_source_lines_base): Handle requests to print
10556         reverse line number sequences, and guard against empty lines
10557         string.
10558
10559 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10560
10561         * source.c (print_source_lines_base): Fix skip of '\r' if next
10562         character is '\n'.
10563
10564 2019-01-06  Tom Tromey  <tom@tromey.com>
10565
10566         * c-exp.y (struct c_parse_state) <macro_original_text,
10567         expansion_obstack>: New member.
10568         (macro_original_text, expansion_obstack): Remove globals.
10569         (scan_macro_expansion, scanning_macro_expansion)
10570         (finished_macro_expansion): Update.
10571         (scan_macro_cleanup): Remove.
10572         (yylex, c_parse): Update.
10573
10574 2019-01-06  Tom Tromey  <tom@tromey.com>
10575
10576         * c-exp.y (struct c_parse_state) <strings>: New member.
10577         (operator_stoken): Update.
10578
10579 2019-01-06  Tom Tromey  <tom@tromey.com>
10580
10581         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10582         (union type_stack_elt) <typelist_val>: Now a pointer to
10583         std::vector.
10584         (type_stack_cleanup): Don't declare.
10585         (push_typelist): Update.
10586         * parse.c (pop_typelist): Return a std::vector.
10587         (push_typelist): Take a std::vector.
10588         (follow_types): Update.  Do not free args.
10589         (type_stack_cleanup): Remove.
10590         * c-exp.y (struct c_parse_state): New.
10591         (cpstate): New global.
10592         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10593         (nonempty_typelist): Update.
10594         (func_mod): Create a new vector.
10595         (c_parse): Create a c_parse_state.
10596         (check_parameter_typelist): Do not delete params.
10597         (function_method): Update.  Do not delete type_list.
10598
10599 2019-01-06  Tom Tromey  <tom@tromey.com>
10600
10601         PR gdb/28155:
10602         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10603         check_typedef.
10604         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10605         (print_return_value): Likewise.
10606
10607 2019-01-05  Tom Tromey  <tom@tromey.com>
10608
10609         * contrib/cleanup_check.py: Remove.
10610         * contrib/gcc-with-excheck: Remove.
10611         * contrib/exsummary.py: Remove.
10612         * contrib/excheck.py: Remove.
10613
10614 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10615
10616         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10617         NULL. Initialize tpprev to NULL instead of assigning it
10618         to NULL on the next statement.
10619         * windows-nat.c (windows_delete_thread): Remove check for
10620         main_thread_id before printing thread exit notifications.
10621         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10622         Remove thread ID check against main_thread_id.
10623         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10624         windows_delete_thread.
10625         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10626
10627 2019-01-04  Tom Tromey  <tom@tromey.com>
10628
10629         * compile/compile.c (_initialize_compile): Use upper case for
10630         metasyntactic variables.
10631         * symmisc.c (_initialize_symmisc): Use upper case for
10632         metasyntactic variables.
10633         * psymtab.c (_initialize_psymtab): Use upper case for
10634         metasyntactic variables.
10635         * demangle.c (demangle_command): Use upper case for metasyntactic
10636         variables.
10637         (_initialize_demangler): Likewise.
10638         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10639         variables.
10640
10641 2019-01-03  Tom Tromey  <tom@tromey.com>
10642
10643         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10644
10645 2019-01-03  Tom Tromey  <tom@tromey.com>
10646
10647         * python/py-symtab.c (salpy_str): Update.
10648         (struct salpy_sal_object) <symtab>: Now a PyObject.
10649         (salpy_dealloc): Update.
10650         (del_objfile_sal): Use gdbpy_ref.
10651
10652 2019-01-03  Tom Tromey  <tom@tromey.com>
10653
10654         * python/py-type.c (convert_field): Use new_reference.  Return
10655         gdbpy_ref.
10656         (make_fielditem): Return gdbpy_ref.
10657         (typy_fields): Update.
10658         (typy_getitem): Update.
10659         (field_name): Return gdbpy_ref.  Use new_reference.
10660         (typy_iterator_iternext): Update.
10661
10662 2019-01-03  Tom Tromey  <tom@tromey.com>
10663
10664         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10665
10666 2019-01-03  Tom Tromey  <tom@tromey.com>
10667
10668         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10669         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10670         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10671         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10672         (pspy_set_type_printers): Likewise.
10673         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10674         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10675         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10676         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10677         (objfpy_set_type_printers): Likewise.
10678
10679 2019-01-03  Tom Tromey  <tom@tromey.com>
10680
10681         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10682         (gdbpy_print_stack): Use gdbpy_err_fetch.
10683         * python/python-internal.h (class gdbpy_err_fetch): New class.
10684         (class gdbpy_enter) <m_error_type, m_error_value,
10685         m_error_traceback>: Remove.
10686         <m_error>: New member.
10687         (gdbpy_exception_to_string): Don't declare.
10688         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10689         * python/py-value.c (convert_value_from_python): Use
10690         gdbpy_err_fetch.
10691         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10692         gdbpy_exception_to_string.
10693         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10694         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10695         gdbpy_err_fetch.
10696
10697 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10698
10699         * linux-nat.c (delete_lwp_cleanup): Delete.
10700         (struct lwp_deleter): New struct.
10701         (lwp_info_up): New typedef.
10702         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10703         lwp_info_up.
10704
10705 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10706
10707         * linux-fork.c (class scoped_switch_fork_info): New class.
10708         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10709
10710 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10711
10712         * valops.c (find_overload_match): Remove use of null_cleanup, and
10713         calls to do_cleanups.
10714
10715 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10716
10717         * compile/compile-cplus-types.c
10718         (compile_cplus_instance::decl_name): Handle changes to
10719         cp_func_name.
10720         * cp-support.c (cp_func_name): Update header comment, update
10721         return type.
10722         * cp-support.h (cp_func_name): Update return type in declaration.
10723         * valops.c (find_overload_match): Move temp_func local to top
10724         level of function and change its type.  Use temp_func to hold and
10725         delete temporary string obtained from cp_func_name.
10726
10727 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10728
10729         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10730         gdb::char_vector, remove cleanup, and update uses of `msg`.
10731
10732 2019-01-03  Jim Wilson  <jimw@sifive.com>
10733
10734         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10735
10736 2019-01-02  Tom Tromey  <tom@tromey.com>
10737
10738         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10739         (tdesc_parse_xml): Remove cleanups.
10740         * target-descriptions.h (make_cleanup_free_target_description):
10741         Don't declare.
10742         (target_desc_deleter): New struct.
10743         (target_desc_up): New typedef.
10744         * target-descriptions.c (target_desc_deleter::operator()): Rename
10745         from free_target_description.
10746         (make_cleanup_free_target_description): Remove.
10747
10748 2019-01-02  Tom Tromey  <tom@tromey.com>
10749
10750         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10751         constructor, destructor.
10752         (linespec_parser): Remove typedef.
10753         (~linespec_parser): Rename from linespec_parser_delete.
10754         (linespec_lex_to_end, linespec_complete_label)
10755         (linespec_complete): Update.
10756         (decode_line_full): Remove cleanups.
10757         (decode_line_1): Update.
10758
10759 2019-01-02  Tom Tromey  <tom@tromey.com>
10760
10761         * python/python-internal.h (inferior_to_inferior_object): Change
10762         return type.
10763         * python/py-exitedevent.c (create_exited_event_object): Update.
10764         * python/py-inferior.c (inferior_to_inferior_object): Return
10765         gdbpy_ref.
10766         (python_new_inferior, python_inferior_deleted)
10767         (thread_to_thread_object, delete_thread_object)
10768         (build_inferior_list, gdbpy_selected_inferior): Update.
10769         * python/py-infthread.c (create_thread_object): Update.  Also fail
10770         if inferior_to_inferior_object fails.
10771
10772 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10773
10774         * inferior.h (class inferior) <displaced_step_state>: New field.
10775         * infrun.h (struct displaced_step_state): Move here from
10776         infrun.c.  Initialize fields, add constructor.
10777         <inf>: Remove field.
10778         <reset>: New method.
10779         * infrun.c (struct displaced_step_inferior_state): Move to
10780         infrun.h.
10781         (displaced_step_inferior_states): Remove.
10782         (get_displaced_stepping_state): Adust.
10783         (displaced_step_in_progress_any_inferior): Adjust.
10784         (displaced_step_in_progress_thread): Adjust.
10785         (displaced_step_in_progress): Adjust.
10786         (add_displaced_stepping_state): Remove.
10787         (get_displaced_step_closure_by_addr): Adjust.
10788         (remove_displaced_stepping_state): Remove.
10789         (infrun_inferior_exit): Call displaced_step_state.reset.
10790         (use_displaced_stepping): Don't check for NULL.
10791         (displaced_step_prepare_throw): Call
10792         get_displaced_stepping_state.
10793         (displaced_step_fixup): Don't check for NULL.
10794         (prepare_for_detach): Don't check for NULL.
10795
10796 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10797
10798         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10799          in case of call that did not complete.
10800
10801 2019-01-02  Andrey Utkin  <autkin@undo.io>
10802
10803         * symfile.c (find_separate_debug_file): Fix search of debug files for
10804         remote debuggee.
10805
10806 2019-01-02  Tom Tromey  <tom@tromey.com>
10807
10808         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10809         indentation.
10810         * python/py-frame.c (frapy_older): Remove cast.
10811         (frapy_newer): Likewise.
10812         * python/py-breakpoint.c (local_setattro): Remove cast.
10813         * python/py-arch.c (archpy_name): Remove local variable.
10814         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10815
10816 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10817
10818         * unittests/basic_string_view/element_access/char/empty.cc:
10819         Fix year range in copyright header.
10820
10821 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10822
10823         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10824         Delete.
10825         <operator==>: Update with for removed field.
10826         <hash>: Likewise.
10827         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10828         <isa_features>: ...this.
10829         <abi_features>: New field.
10830         (riscv_isa_flen): Update comment.
10831         (riscv_abi_xlen): New declaration.
10832         (riscv_abi_flen): New declaration.
10833         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10834         isa_features.
10835         (riscv_abi_xlen): New function.
10836         (riscv_isa_flen): Update to get answer from isa_features.
10837         (riscv_abi_flen): New function.
10838         (riscv_has_fp_abi): Update to get answer from abi_features.
10839         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10840         xlen and flen.
10841         (riscv_call_info) <xlen, flen>: Update comment.
10842         (riscv_call_arg_struct): Remove invalid assertions
10843         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10844         is removed.
10845         (riscv_gdbarch_init): Gather isa features and abi features
10846         separately, ensure both match on the gdbarch when reusing an old
10847         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10848         a target with 64-bit float hardware.
10849
10850 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10851
10852         * source.c (search_command_helper): Stop reverse search
10853         when line 1 has been searched.
10854
10855 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10856
10857         * record-full.c (record_full_base_target::close): Rewrite
10858         record_full_core_buf_list free logic.
10859
10860 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10861
10862         * break-catch-syscall.c (print_one_catch_syscall): xfree
10863         the last text.
10864
10865 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10866
10867         * top.c (print_gdb_version): Update Copyright year in version
10868         message.
10869
10870 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10871
10872         Update copyright year range in all GDB files.
10873
10874 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10875
10876         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10877
10878 For older changes see ChangeLog-2018.
10879 \f
10880 Local Variables:
10881 mode: change-log
10882 left-margin: 8
10883 fill-column: 74
10884 version-control: never
10885 coding: utf-8
10886 End:
10887