gdb/ChangeLog

   1 2019-06-13  Pedro Alves <palves@redhat.com>
   2
   3         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
   4         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
   5         call.
   6         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
   7         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
   8         calls.
   9         (check_for_argument): Skip spaces after argument.
  10
  11 2019-06-13  Pedro Alves  <palves@redhat.com>
  12
  13         * thread.c (thread_apply_command): Adjust TID parsing.
  14         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
  15         detected before end of string.
  16         (tid_is_in_list): Error out if LIST is invalid.
  17
  18 2019-06-13  Pedro Alves  <palves@redhat.com>
  19
  20         * completer.c (complete_line_internal_1): Rewind completion word
  21         point.
  22         (completion_tracker::advance_custom_word_point_by): Change
  23         parameter type to int.
  24         * completer.h (completion_tracker::advance_custom_word_point_by):
  25         Likewise.
  26
  27 2019-06-13  Pedro Alves  <palves@redhat.com>
  28
  29         * completer.c (advance_to_completion_word): Handle delimiters.
  30
  31 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
  32
  33         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
  34
  35 2019-06-11  Tom Tromey  <tom@tromey.com>
  36
  37         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
  38         (xmalloc_failed): Move to alloc.c.
  39         * alloc.c: New file.
  40         * Makefile.in (COMMON_SFILES): Add alloc.c.
  41
  42 2019-06-11  Tom Tromey  <tom@tromey.com>
  43
  44         * nat/linux-waitpid.c: Don't include server.h.
  45         (linux_debug): Remove.
  46         (my_waitpid): Update.
  47
  48 2019-06-11  Tom Tromey  <tromey@adacore.com>
  49
  50         * infcall.c (_initialize_infcall): Remove trailing newline from
  51         help.
  52         * user-regs.c (_initialize_user_regs): Remove trailing newline
  53         from help.
  54         * typeprint.c (_initialize_typeprint): Remove trailing newline
  55         from help.
  56         * reverse.c (_initialize_reverse): Remove trailing newlines from
  57         help.
  58         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
  59         from help.
  60         * language.c (add_set_language_command): Remove trailing newline
  61         from help.
  62         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
  63         help.
  64         * disasm.c (_initialize_disasm): Remove trailing newline from
  65         help.
  66         * top.c (init_main): Remove trailing newline from help.
  67         * interps.c (_initialize_interpreter): Remove trailing newline
  68         from help.
  69         * btrace.c (_initialize_btrace): Remove trailing newlines from
  70         help.
  71         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
  72         from help.
  73         * python/python.c (_initialize_python): Remove trailing newline
  74         from help.
  75         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
  76         help.
  77         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
  78         from help.  Reformat some text.
  79         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
  80         from help.
  81         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
  82         newline from help.
  83
  84 2019-06-11  Tom Tromey  <tromey@adacore.com>
  85
  86         * darwin-nat.c (darwin_decode_exception_message)
  87         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
  88
  89 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         * valops.c (value_slice): Check for not allocated or not
  92         associated values.
  93
  94 2019-06-10  Tom de Vries  <tdevries@suse.de>
  95
  96         PR gdb/24618
  97         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
  98         sure an empty slot (defined by a 32-bit zero pair) is recognized as
  99         invalid.
 100
 101 2019-06-10  Tom de Vries  <tdevries@suse.de>
 102
 103         PR gdb/24611
 104         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 105         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 106
 107 2019-06-10  Tom de Vries  <tdevries@suse.de>
 108
 109         PR symtab/24545
 110         * symtab.c (struct demangled_name_entry): Add language field.
 111         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 112         static minimal symbol".  Set and use language field.
 113
 114 2019-06-10  Tom Tromey  <tromey@adacore.com>
 115
 116         * ada-lang.c (_initialize_ada_language): Update help text.
 117
 118 2019-06-10  Tom Tromey  <tromey@adacore.com>
 119
 120         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 121         with a newline.
 122         * guile/guile.c (handle_boot_error): Don't end warning with a
 123         newline.
 124         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 125         warning with a newline.
 126         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 127         newline.
 128         (s12z_frame_cache): Likewise.
 129         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 130         a newline.
 131         * solib-svr4.c (disable_probes_interface): Don't end warning with
 132         a newline.
 133         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 134         newline.
 135         * python/python.c (do_finish_initialization): Don't end warning
 136         with a newline.
 137
 138 2019-06-10  Tom Tromey  <tom@tromey.com>
 139
 140         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 141         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 142         gdbpy_enter.
 143
 144 2019-06-10  Tom Tromey  <tromey@adacore.com>
 145
 146         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 147         data.
 148         (elf_new_init): Don't call stabsread_new_init.
 149         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 150         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 151         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 152
 153 2019-06-10  Tom de Vries  <tdevries@suse.de>
 154
 155         PR symtab/16264
 156         PR symtab/24517
 157         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 158
 159 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 160
 161         * source.c (find_and_open_source): Also rewrite relative file
 162         names.
 163
 164 2019-04-26  Amos Bird  <amosbird@gmail.com>
 165
 166         * annotate.c (annotate_thread_exited): Add "thread-exited"
 167         annotation.
 168
 169 2019-06-06  Tom Tromey  <tromey@adacore.com>
 170
 171         * maint.h (class scoped_command_stats): Use
 172         DISABLE_COPY_AND_ASSIGN.
 173         <print_time>: New method.
 174         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 175         print_time.
 176         (scoped_command_stats::print_time): New method.
 177
 178 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 181         instructions of lengths 6 or 8 bytes.
 182
 183 2019-06-04  Pedro Alves  <palves@redhat.com>
 184
 185         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 186
 187         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 188         * breakpoint.c (condition_completer): Likewise.
 189         * cli/cli-dump.c (scan_expression): Likewise.
 190         * common/filestuff.c (mkdir_recursive): Likewise.
 191         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 192         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 193         (gdb_abspath): Likewise.
 194         * compile/compile-cplus-types.c
 195         (compile_cplus_instance::decl_name): Likewise.
 196         * completer.c (complete_explicit_location):
 197         (signal_completer, reg_or_group_completer_1): Likewise.
 198         * cp-support.c (cp_remove_params_if_any): Likewise.
 199         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 200         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 201         * infcmd.c (strip_bg_char): Likewise.
 202         * linespec.c (copy_token_string): Likewise.
 203         * mi/mi-main.c (output_cores): Likewise.
 204         * psymtab.c (psymtab_search_name):
 205         * symfile.c (test_set_ext_lang_command): Likewise.
 206         * target.c (target_fileio_read_stralloc): Likewise.
 207         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 208         * value.c (complete_internalvar): Likewise.
 209
 210 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 211
 212         Add objfile property to gdb.Type.
 213         * NEWS: Mention Python API addition.
 214         * python/py-type.c (typy_get_objfile): New method.
 215
 216 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 217
 218         * NEWS: Mention the new set|show style [title|highlight].
 219         Mention changes to "show style", "help" and "apropos".
 220
 221 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 222
 223         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 224         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 225         instead of print_help_for_command.
 226         (print_doc_of_command): New function.
 227         (help_list): Add 'apropos -v word' suggestion.
 228         (print_help_for_command): Style the command name using title style.
 229         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 230         (_initialize_cli_cmds): Describe -v in apropos_command help.
 231
 232 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 233
 234         * cli/cli-style.h (cli_style_option): Add name in constructor,
 235         add m_name class member, add constructor with intensity,
 236         add name class function.
 237         (cli_style_option::add_setshow_commands): Remove name argument.
 238         (highlight_style, title_style): New styles.
 239         * cli/cli-style.c (do_show): New function that shows a style
 240         characteristic styling the style name with itself.
 241         (set_style_name): New function.
 242         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 243         Update all callers according to the changes in cli/cli-style.h.
 244         * utils.h (fputs_highlighted): New function.
 245         * utils.c (fputs_highlighted): Likewise.
 246
 247 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 248
 249         * NEWS: Mention new pipe command and new convenience variables.
 250
 251 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 252
 253         * cli/cli-cmds.c (pipe_command): New function.
 254         (_initialize_cli_cmds): Call add_com for pipe_command.
 255         Define | as an alias for pipe.
 256         (exit_status_set_internal_vars): New function.
 257         (shell_escape): Call exit_status_set_internal_vars.
 258         cli/cli-decode.c (find_command_name_length): Recognize | as
 259         a single character command.
 260
 261 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 262
 263         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 264         top.c (execute_command_to_ui_file): New function, mostly a copy
 265         of execute_command_to_string.
 266         (execute_command_to_string): Implement by calling
 267         execute_command_to_ui_file.
 268
 269 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 270
 271         * top.h (saved_command_line): Remove declaration.
 272         * top.c (previous_saved_command_line, previous_repeat_arguments):
 273         New variables.
 274         (saved_command_line): Make static, define together with other
 275         'repeat variables'.
 276         (dont_repeat): Clear repeat_arguments.
 277         (repeat_previous, get_saved_command_line, save_command_line):
 278         New functions.
 279         (gdb_init): Initialize saved_command_line
 280         and previous_saved_command_line.
 281         * main.c (captured_main_1): Remove saved_command_line initialization.
 282         * event-top.c (handle_line_of_input): Update to use
 283         the new 'repeat' related functions instead of direct access to
 284         saved_command_line.
 285         * command.h (repeat_previous, get_saved_command_line,
 286         save_command_line): New declarations.
 287         (dont_repeat): Add comment.
 288
 289 2019-05-30  Tom Tromey  <tromey@adacore.com>
 290
 291         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 292         Fix comment.
 293         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 294
 295 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 296
 297         PR cli/24587
 298         * completer.c (complete): Initialize variable word.
 299
 300 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 301
 302         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 303         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 304         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 305         'body' is NULL to the outter 'if', protecting the '!is_define'
 306         situation as well.
 307
 308 2019-05-29  Tom Tromey  <tromey@adacore.com>
 309
 310         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 311         (dwarf_unknown): New function.
 312         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 313         (dwarf_type_encoding_name): Use dwarf_unknown.
 314
 315 2019-05-29  Tom Tromey  <tromey@adacore.com>
 316
 317         PR c++/20020:
 318         * cp-valprint.c (cp_print_value_fields): Call
 319         cp_print_static_field inside "try".
 320
 321 2019-05-29  Tom Tromey  <tromey@adacore.com>
 322
 323         * inflow.c (struct terminal_info): Add default operator=.
 324         * configure: Rebuild.
 325         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 326         -Wdeprecated-copy-dtor, -Wredundant-move.
 327
 328 2019-05-29  Tom Tromey  <tromey@adacore.com>
 329
 330         * NEWS: Add entry.
 331         * infcmd.c (print_return_value_1): Handle finish_print
 332         option.
 333         (show_print_finish): New function.
 334         (_initialize_infcmd): Add "set/show print finish" commands.
 335         * valprint.c (user_print_options): Initialize new member.
 336         * valprint.h (struct value_print_options) <finish_print>: New
 337         member.
 338
 339 2019-05-28  Tom Tromey  <tromey@adacore.com>
 340
 341         * ada-lang.c (ada_remove_Xbn_suffix)
 342         (find_old_style_renaming_symbol)
 343         (parse_old_style_renaming): Remove.
 344         (ada_find_renaming_symbol): Don't call
 345         find_old_style_renaming_symbol.
 346         (ada_is_renaming_symbol): Rename from
 347         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 348         bool.  Now static.
 349         (ada_read_var_value): Update and simplify.
 350         * ada-exp.y (write_var_or_type): Remove old code.
 351
 352 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 353
 354         * event-top.c: Remove include comment.
 355         * inflow.c (class scoped_ignore_sigttou): Move from here...
 356         * inflow.h (class scoped_ignore_sigttou): ...to here.
 357         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 358         * top.c:  Remove include comment.
 359
 360 2019-05-27  Tom Tromey  <tom@tromey.com>
 361
 362         * NEWS: Fix typo.
 363
 364 2019-05-22  Tom Tromey  <tromey@adacore.com>
 365
 366         * target.c (target_follow_exec): Constify parameter.
 367         * target-delegates.c: Rebuild.
 368         * remote.c (remote_target::follow_exec): Constify parameter.
 369         * infrun.c (follow_exec): Constify parameter.
 370         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 371         (target_follow_exec): Likewise.
 372
 373 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 374
 375         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 376         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 377
 378 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 379
 380         * NEWS: Add debugredirect and testsuite sections.
 381
 382 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 383
 384         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 385         target descriptions using exclusively floating point register name
 386         aliases.
 387
 388 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 389
 390         PR gdb/18644:
 391         * f-lang.c (build_fortran_types): Handle the case where
 392         gdbarch_floatformat_for_type returns a nullptr.
 393
 394 2019-05-21  Tom de Vries  <tdevries@suse.de>
 395
 396         PR cli/24587
 397         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 398
 399 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 400
 401         PR gdb/18644:
 402         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 403         16-byte floats.
 404         * i386-tdep.c (i386_floatformat_for_type): Use
 405         floatformats_ia64_quad for the 16-byte floating point component
 406         within a fortran 32-byte complex number.
 407
 408 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 411         delete default constructor.
 412         (find_partial_die): Update to return const struct.
 413         (partial_die_parent_scope): Move variable declaration into scope
 414         of its use and change its type to auto.
 415         (guess_partial_die_structure_name): Likewise.
 416         (partial_die_info::fixup): Likewise.
 417
 418 2019-05-17  Tom Tromey  <tromey@adacore.com>
 419
 420         * source.c (find_and_open_source): Remove cast.
 421
 422 2019-05-17  Tom Tromey  <tromey@adacore.com>
 423
 424         * annotate.c (annotate_source): Make "filename" const.
 425         * annotate.h (annotate_source): Use const.
 426
 427 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 428
 429         * disasm.c (set_disassembler_options): Send errors to stderr.
 430
 431 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 432
 433         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 434         (cli_interp_base::set_logging): Check debug_redirect.
 435         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 436         * cli/cli-logging.c (debug_redirect): Add static variable.
 437         (pop_output_files): Add default param.
 438         (handle_redirections): Print debug setting.
 439         (show_logging_command): Likewise.
 440         (_initialize_cli_logging): Add debugredirect command.
 441         * interps.c (current_interp_set_logging): Add debug_redirect
 442         parameter.
 443         * interps.h (set_logging): Add debug_redirect parameter.
 444         (current_interp_set_logging): Likewise.
 445         * mi/mi-common.h: Likewise.
 446         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 447
 448 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 449             Tom Tromey  <tromey@adacore.com>
 450
 451         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 452         directly.
 453         * cli/cli-interp.h (make_logging_output): Remove declaration.
 454         * cli/cli-logging.c (make_logging_output): Remove function.
 455         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 456         directly.
 457         * ui-file.c (tee_file::tee_file): Remove bools.
 458         (tee_file::~tee_file): Remove deletes.
 459         * ui-file.h (tee_file): Remove bools.
 460
 461 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 462
 463         * mi/mi-cmds.h (mi_cmd_complete): New function.
 464         * mi/mi-main.c (mi_cmd_complete): Likewise.
 465         * mi/mi-cmds.c: Define new MI command -complete.
 466         * NEWS: Mention new -complete command.
 467
 468 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 469
 470         * completer.h (complete): New function.
 471         * completer.c (complete): Likewise.
 472         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 473         function defined in completer.h.
 474
 475 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 476
 477        * MAINTAINERS (Write After Approval): Add myself.
 478
 479 2019-05-17  Tom de Vries  <tdevries@suse.de>
 480
 481         PR gdb/24094
 482         * dwarf2read.c (struct cu_partial_die_info): New struct.
 483         (find_partial_die): Return cu_partial_die_info.
 484         (partial_die_parent_scope, guess_partial_die_structure_name)
 485         (partial_die_info::fixup): Handle new return type of find_partial_die.
 486
 487 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 488
 489         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 490         "std::string", simplifying the algorithm.
 491
 492 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 493
 494         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 495         (stap_static_probe_ops::get_probes): Likewise.
 496
 497 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 498
 499         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 500         '-')" and "else if".
 501         (stap_parse_single_operand): Join checks for
 502         "gdbarch_stap_parse_special_token_p" and
 503         "gdbarch_stap_parse_special_token" in the same "if" statement.
 504         Invert check when verifying for operation on register
 505         displacement.
 506
 507 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 508
 509         * stap-probe.c (stap_get_opcode): Update comment.
 510         (stap_get_expected_argument_type): Likewise.
 511         (handle_stap_probe): Likewise.
 512
 513 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 514
 515         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 516         return type to 'bool'.  Adjust comment.  Use 'bool' when
 517         appropriate.
 518         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 519         * stap-probe.c (stap_parse_argument_1): Likewise.
 520         (stap_is_operator): Likewise.
 521         (stap_is_generic_prefix): Likewise.
 522         (stap_is_register_prefix): Likewise.
 523         (stap_is_register_indirection_prefix): Likewise.
 524         (stap_is_integer_prefix): Likewise.
 525         (stap_generic_check_suffix): Likewise.
 526         (stap_check_integer_suffix): Likewise.
 527         (stap_check_register_suffix): Likewise.
 528         (stap_check_register_indirection_suffix): Likewise.
 529         (stap_parse_register_operand): Likewise.
 530         (stap_parse_single_operand): Likewise.
 531         (stap_parse_argument_1): Likewise.
 532         (stap_probe::get_argument_count): Likewise.
 533         (stap_is_operator): Likewise.
 534
 535 2019-05-16  Tom Tromey  <tromey@adacore.com>
 536
 537         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 538         keyword to foreach.
 539
 540 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 541
 542         * linux-thread-db.c (try_thread_db_load_1): Change return type
 543         to bool.
 544         (try_thread_db_load): Likewise.
 545         (try_thread_db_load_from_pdir_1): Likewise.
 546         (try_thread_db_load_from_pdir): Likewise.
 547         (try_thread_db_load_from_sdir): Likewise.
 548         (try_thread_db_load_from_dir): Likewise.
 549         (thread_db_load_search): Likewise.
 550         (has_libpthread): Likewise.
 551         (thread_db_load): Likewise.
 552
 553 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 554
 555         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 556         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 557         NULL, and complain/return if that's the case.
 558
 559 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 560
 561         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 562         (advance, posn, abstract_read_memory): New functions.
 563         [struct mem_read_abstraction]: New struct.
 564         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 565
 566 2019-05-14  Tom Tromey  <tromey@adacore.com>
 567
 568         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 569         value is not lval_memory.
 570
 571 2019-05-14  Tom Tromey  <tromey@adacore.com>
 572
 573         * solib.c (info_sharedlibrary_command): Style the file name.
 574
 575 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 576
 577         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 578         (aarch64_vnv_type): Likewise.
 579         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 580         * common/tdesc.c: Likewise.
 581         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 582         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 583         * features/aarch64-fpu.xml: Add ieee half view.
 584         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 585         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 586         * gdbtypes.h (struct builtin_type): Likewise.
 587         (struct objfile_type): Likewise.
 588
 589 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 590
 591         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 592         typo.
 593         * location.h (string_to_event_location): Likewise.
 594
 595 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 596
 597         GDB 8.3 released.
 598
 599 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 600
 601         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 602         New variable declaration.
 603         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 604         New variable.
 605         (print_one_breakpoint): Use ui_out::test_flags and new global
 606         variable to compute use_fixed_output.
 607         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 608         Remove.
 609         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 610         (mi_multi_location_breakpoint_output_fixed): Remove.
 611         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 612         new variable.
 613         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 614         fix_multi_location_breakpoint_output flag if version >= 3.
 615         * ui-out.h (enum ui_out_flag)
 616         <fix_multi_location_breakpoint_output>: New enumerator.
 617
 618 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 619
 620         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 621
 622 2019-05-10  Tom Tromey  <tromey@adacore.com>
 623
 624         * ada-lang.c (catch_ada_completer): New function.
 625         (_initialize_ada_language): Use it.
 626
 627 2019-05-10  Tom Tromey  <tromey@adacore.com>
 628
 629         * thread.c (print_thread_info): Make "requested_threads" const.
 630         * gdbthread.h (print_thread_info): Make "requested_threads"
 631         const.
 632         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 633         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 634
 635 2019-05-08  Tom Tromey  <tom@tromey.com>
 636
 637         * gdbtypes.c (objfile_type_data): Change type.
 638         (objfile_type, _initialize_gdbtypes): Update.
 639
 640 2019-05-08  Tom Tromey  <tom@tromey.com>
 641
 642         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 643         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 644         (_initialize_dwarf2_frame): Update.
 645
 646 2019-05-08  Tom Tromey  <tom@tromey.com>
 647
 648         * objc-lang.c (objc_objfile_data): Change type.
 649         (find_methods): Update.
 650         (_initialize_objc_lang): Remove.
 651
 652 2019-05-08  Tom Tromey  <tom@tromey.com>
 653
 654         * stabsread.c (rs6000_builtin_type_data): Change type.
 655         (rs6000_builtin_type, _initialize_stabsread): Update.
 656
 657 2019-05-08  Tom Tromey  <tom@tromey.com>
 658
 659         * mips-tdep.c (mips_pdr_data): Remove.
 660         (_initialize_mips_tdep): Update.
 661
 662 2019-05-08  Tom Tromey  <tom@tromey.com>
 663
 664         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 665         (hppa_init_objfile_priv_data, read_unwind_info)
 666         (find_unwind_entry, _initialize_hppa_tdep): Update.
 667
 668 2019-05-08  Tom Tromey  <tom@tromey.com>
 669
 670         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 671         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 672         on obstack.
 673         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 674
 675 2019-05-08  Tom Tromey  <tom@tromey.com>
 676
 677         * mdebugread.c (basic_type_data): Change type.
 678         (basic_type, _initialize_mdebugread): Update.
 679
 680 2019-05-08  Tom Tromey  <tom@tromey.com>
 681
 682         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 683
 684 2019-05-08  Tom Tromey  <tom@tromey.com>
 685
 686         * nto-tdep.c (nto_inferior_data_reg): Change type.
 687         (nto_inferior_data): Update.
 688         (nto_inferior_data_cleanup, nto_new_inferior_data)
 689         (_initialize_nto_tdep): Remove.
 690         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 691
 692 2019-05-08  Tom Tromey  <tom@tromey.com>
 693
 694         * ada-lang.c (struct ada_inferior_data): Add initializers.
 695         (ada_inferior_data): Change type.
 696         (ada_inferior_data_cleanup): Remove.
 697         (get_ada_inferior_data, ada_inferior_exit)
 698         (struct ada_pspace_data): Add initializers, destructor.
 699         (ada_pspace_data_handle): Change type.
 700         (get_ada_pspace_data): Update.
 701         (ada_pspace_data_cleanup): Remove.
 702
 703 2019-05-08  Tom Tromey  <tom@tromey.com>
 704
 705         * coffread.c (struct coff_symfile_info): Add initializers.
 706         (coff_objfile_data_key): Move lower.  Change type.
 707         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 708         Update.
 709         (coff_free_info): Remove.
 710
 711 2019-05-08  Tom Tromey  <tom@tromey.com>
 712
 713         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 714         (fbsd_pspace_data_handle): Move lower.  Change type.
 715         (get_fbsd_pspace_data): Update.
 716         (fbsd_pspace_data_cleanup): Remove.
 717         (_initialize_fbsd_tdep): Update.
 718
 719 2019-05-08  Tom Tromey  <tom@tromey.com>
 720
 721         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 722         (get_ada_tasks_pspace_data): Update.
 723         (ada_tasks_pspace_data_cleanup): Remove.
 724         (_initialize_tasks): Update.
 725         (ada_tasks_inferior_data_handle): Change type.
 726         (get_ada_tasks_inferior_data): Update.
 727         (ada_tasks_inferior_data_cleanup): Remove.
 728         (struct ada_tasks_pspace_data): Add initializers.
 729
 730 2019-05-08  Tom Tromey  <tom@tromey.com>
 731
 732         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 733         * symfile-debug.c (debug_sym_get_probes): Change type.
 734         * stap-probe.c (handle_stap_probe):
 735         (stap_static_probe_ops::get_probes): Change type.
 736         * probe.h (class static_probe_ops) <get_probes>: Change type.
 737         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 738         (parse_probes_in_pspace): Update.
 739         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 740         Update.
 741         (any_static_probe_ops::get_probes): Change type.
 742         * elfread.c (elfread_data): New typedef.
 743         (probe_key): Change type.
 744         (elf_get_probes): Likewise.  Update.
 745         (probe_key_free): Remove.
 746         (_initialize_elfread): Update.
 747         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 748         Change type.
 749         (dtrace_process_dof_probe, dtrace_process_dof)
 750         (dtrace_static_probe_ops::get_probe): Change type.
 751
 752 2019-05-08  Tom Tromey  <tom@tromey.com>
 753
 754         * xcoffread.c (struct xcoff_symfile_info): Rename from
 755         coff_symfile_info.  Add initializers.
 756         (xcoff_objfile_data_key): Move lower.  Change type.
 757         (XCOFF_DATA): Rewrite.
 758         (xcoff_free_info): Remove.
 759         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 760         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 761         (xcoff_initial_scan): Update.
 762
 763 2019-05-08  Tom Tromey  <tom@tromey.com>
 764
 765         * solib-svr4.c (struct svr4_info): Add initializers and
 766         destructor.
 767         <probes_table>: Now an htab_up.
 768         (solib_svr4_pspace_data): Change type.
 769         (free_probes_table): Simplify.
 770         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 771         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 772         (probes_table_remove_objfile_probes, register_solib_event_probe)
 773         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 774         (_initialize_svr4_solib): Update.
 775
 776 2019-05-08  Tom Tromey  <tom@tromey.com>
 777
 778         * remote.c (remote_pspace_data): Change type.
 779         (remote_pspace_data_cleanup): Remove.
 780         (get_remote_exec_file, set_pspace_remote_exec_file)
 781         (_initialize_remote): Update.
 782
 783 2019-05-08  Tom Tromey  <tom@tromey.com>
 784
 785         * breakpoint.c (breakpoint_objfile_key): Change type.
 786         (get_breakpoint_objfile_data): Update.
 787         (free_breakpoint_objfile_data): Remove.
 788         (_initialize_breakpoint): Update.
 789
 790 2019-05-08  Tom Tromey  <tom@tromey.com>
 791
 792         * linux-tdep.c (struct linux_info): Add initializers.
 793         (linux_inferior_data): Move.  Change type.
 794         (invalidate_linux_cache_inf): Update.
 795         (linux_inferior_data_cleanup): Remove.
 796         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 797
 798 2019-05-08  Tom Tromey  <tom@tromey.com>
 799
 800         * auxv.c (auxv_inferior_data): Move.  Change type.
 801         (auxv_inferior_data_cleanup): Remove.
 802         (invalidate_auxv_cache_inf): Rewrite.
 803         (get_auxv_inferior_data, _initialize_auxv): Update.
 804
 805 2019-05-08  Tom Tromey  <tom@tromey.com>
 806
 807         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 808         (symfile_debug_objfile_data_key): Change type.
 809         (symfile_debug_installed, debug_qf_has_symbols)
 810         (debug_qf_find_last_source_symtab)
 811         (debug_qf_forget_cached_source_info)
 812         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 813         (debug_qf_print_stats, debug_qf_dump)
 814         (debug_qf_expand_symtabs_for_function)
 815         (debug_qf_expand_all_symtabs)
 816         (debug_qf_expand_symtabs_with_fullname)
 817         (debug_qf_map_matching_symbols)
 818         (debug_qf_expand_symtabs_matching)
 819         (debug_qf_find_pc_sect_compunit_symtab)
 820         (debug_qf_map_symbol_filenames)
 821         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 822         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 823         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 824         (debug_sym_read_linetable, debug_sym_relocate): Update.
 825         (symfile_debug_free_objfile): Remove.
 826         (install_symfile_debug_logging, _initialize_symfile_debug):
 827         Update.
 828
 829 2019-05-08  Tom Tromey  <tom@tromey.com>
 830
 831         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 832         allocate_on_obstack.
 833         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 834         (get_dwarf2_per_objfile): Update.
 835         (set_dwarf2_per_objfile): Remove.
 836         (dwarf2_has_info, dwarf2_get_section_info): Update.
 837         (dwarf2_free_objfile): Remove.
 838         (_initialize_dwarf2_read): Update.
 839
 840 2019-05-08  Tom Tromey  <tom@tromey.com>
 841
 842         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 843         initializers.
 844         <unsupported_script_warning_printed,
 845         script_not_found_warning_printed>: Now bool.
 846         (auto_load_pspace_data): Change type.
 847         (~auto_load_pspace_info): Rename from
 848         auto_load_pspace_data_cleanup.
 849         (get_auto_load_pspace_data, init_loaded_scripts_info)
 850         (clear_section_scripts, maybe_print_unsupported_script_warning)
 851         (maybe_print_script_not_found_warning, _initialize_auto_load):
 852         Update.
 853
 854 2019-05-08  Tom Tromey  <tom@tromey.com>
 855
 856         * objfiles.c (objfile_pspace_info): Add destructor and
 857         initializers.
 858         (objfiles_pspace_data): Change type.
 859         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 860         (get_objfile_pspace_data): Update.
 861         (objfiles_bfd_data): Change type.
 862         (get_objfile_bfd_data): Update.
 863         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 864
 865 2019-05-08  Tom Tromey  <tom@tromey.com>
 866
 867         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 868         Change type.
 869         (get_catch_syscall_inferior_data): Update.
 870         (catch_syscall_inferior_data_cleanup): Remove.
 871         (_initialize_break_catch_syscall): Update.
 872
 873 2019-05-08  Tom Tromey  <tom@tromey.com>
 874
 875         * inflow.c (struct terminal_info): Add destructor and
 876         initializers.
 877         (inflow_inferior_data): Change type.
 878         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 879         (get_inflow_inferior_data, inflow_inferior_exit)
 880         (swap_terminal_info, _initialize_inflow): Update.
 881
 882 2019-05-08  Tom Tromey  <tom@tromey.com>
 883
 884         * target-dcache.c (target_dcache_cleanup): Remove.
 885         (target_dcache_aspace_key): Change type.
 886         (target_dcache_init_p, target_dcache_invalidate)
 887         (target_dcache_get, target_dcache_get_or_init)
 888         (_initialize_target_dcache): Update.
 889         * dcache.h (struct dcache_deleter): New.
 890
 891 2019-05-08  Tom Tromey  <tom@tromey.com>
 892
 893         * symtab.c (struct symbol_cache): Add destructor and
 894         initializers.
 895         (symbol_cache_key): Move.  Change type.
 896         (make_symbol_cache, free_symbol_cache): Remove.
 897         (get_symbol_cache): Update.
 898         (symbol_cache_cleanup): Remove.
 899         (ALL_PSPACES, symbol_cache_flush)
 900         (maintenance_print_symbol_cache)
 901         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 902         Update.
 903
 904 2019-05-08  Tom Tromey  <tom@tromey.com>
 905
 906         * symtab.c (struct main_info): Add destructor and initializers.
 907         (main_progspace_key): Move.  Change type.
 908         (get_main_info): Update.
 909         (main_info_cleanup): Remove.
 910         (_initialize_symtab): Update.
 911
 912 2019-05-08  Tom Tromey  <tom@tromey.com>
 913
 914         * registry.h (DECLARE_REGISTRY): Define the _key class.
 915
 916 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * NEWS: Merge two 'New commands' sections.
 919
 920 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 921
 922         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 923         parameter and use Ada language definition instead.
 924         (ada_val_print_ptr): Remove unused language parameter.
 925         (ada_val_print_num): Remove language parameter and use Ada language
 926         definition instead.
 927         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 928         parameter.
 929         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 930         parameter and use Ada language definition instead.
 931         (ada_val_print_1): Update all ada_val_print_xxx calls.
 932         Remove language parameter.
 933         (ada_val_print): Update ada_val_print_1 call.
 934
 935 2019-05-08  Tom Tromey  <tromey@adacore.com>
 936
 937         * remote.c (remote_hw_watchpoint_limit)
 938         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 939         Now static.
 940
 941 2019-05-08  Tom Tromey  <tromey@adacore.com>
 942
 943         * maint.c (_initialize_maint_cmds): Move initialization code to
 944         remote.c.
 945         (watchdog, show_watchdog): Move to remote.c.
 946         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 947         "watchdog" static.
 948         (_initialize_remote): Move initialization code from maint.c.
 949         * defs.h (watchdog): Don't declare.
 950
 951 2019-05-08  Tom Tromey  <tromey@adacore.com>
 952
 953         * tui/tui-interp.c: Include main.h.
 954         * interps.c: Include main.h.
 955         * main.h (interpreter_p): Declare.
 956         * defs.h (interpreter_p): Don't declare.
 957
 958 2019-05-08  Tom Tromey  <tromey@adacore.com>
 959
 960         * dwarf2loc.c: Include dwarf2read.h.
 961         * defs.h (read_unsigned_leb128): Don't declare.
 962         * dwarf2read.h (read_unsigned_leb128): Declare.
 963
 964 2019-05-08  Tom Tromey  <tromey@adacore.com>
 965
 966         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 967         method.
 968
 969 2019-05-08  Tom Tromey  <tromey@adacore.com>
 970
 971         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 972         when no wrap column is set.
 973
 974 2019-05-08  Tom Tromey  <tromey@adacore.com>
 975
 976         * c-lang.c (c_get_string): Handle non-C-style arrays.
 977
 978 2019-05-08  Tom Tromey  <tromey@adacore.com>
 979
 980         * typeprint.c (print_offset_data::update): Print the bit offset,
 981         not the number of bits remaining.
 982
 983 2019-05-08  Tom Tromey  <tromey@adacore.com>
 984
 985         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 986         padding at end of comment.
 987
 988 2019-05-08  Tom Tromey  <tromey@adacore.com>
 989
 990         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 991         Compare main types.
 992
 993 2019-05-06  Tom Tromey  <tom@tromey.com>
 994
 995         * common/scoped_mmap.c: Include common-defs.h.
 996         * common/scoped_mmap.h: Don't include config.h.
 997
 998 2019-05-04  Tom Tromey  <tom@tromey.com>
 999
1000         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1001         (struct aarch64_call_info): Add initializers.
1002         <si>: Now a std::vector.
1003         (pass_on_stack, aarch64_push_dummy_call): Update.
1004
1005 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1006             Tom Tromey  <tom@tromey.com>
1007
1008         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1009         (ppc_threads): Now a std::vector.  Now static.
1010         (hwdebug_find_thread_points_by_tid)
1011         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1012         Update.
1013
1014 2019-05-04  Tom Tromey  <tom@tromey.com>
1015
1016         * arc-tdep.c (arc_tdesc_init): Return bool.
1017
1018 2019-05-04  Tom Tromey  <tom@tromey.com>
1019
1020         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1021         Use gdb_assert_not_reached.
1022
1023 2019-05-04  Tom Tromey  <tom@tromey.com>
1024
1025         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1026         "false".
1027
1028 2019-05-04  Tom Tromey  <tom@tromey.com>
1029
1030         * arc-tdep.c (arc_tdesc_init): Use bool.
1031
1032 2019-05-04  Tom Tromey  <tom@tromey.com>
1033
1034         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1035
1036 2019-05-04  Tom Tromey  <tom@tromey.com>
1037
1038         * cli/cli-cmds.c (valid_command_p): Return bool.
1039
1040 2019-05-04  Tom Tromey  <tom@tromey.com>
1041
1042         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1043         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1044
1045 2019-05-04  Raul Tambre  <raul@tambre.ee>
1046
1047         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1048         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1049         operator for comparison.
1050
1051 2019-05-04  Tom Tromey  <tom@tromey.com>
1052
1053         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1054         (lookup_partial_symbol, print_partial_symbols)
1055         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1056         (psymbol_compare): Update.
1057         (add_psymbol_to_bcache): Clear the entire psymbol.
1058         (maintenance_check_psymtabs): Update.
1059         * psympriv.h (struct partial_symbol): Don't derive from
1060         general_symbol_info.
1061         <obj_section, unrelocated_address, address,
1062         set_unrelocated_address>: Update.
1063         <ginfo>: New member.
1064         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1065         (debug_names::write_psymbols): Update.
1066
1067 2019-05-04  Tom de Vries  <tdevries@suse.de>
1068
1069         * contrib/cc-with-tweaks.sh: Support -n arg.
1070
1071 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1072
1073         * corelow.c (core_target::detach): Ensure frame cache and
1074         register caches are cleared.
1075         inferior.c (exit_inferior_1): Likewise.
1076
1077 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1078             Tom Tromey  <tom@tromey.com>
1079
1080         * dictionary.c (collate_pending_symbols_by_language): Remove
1081         "struct" from foreach.
1082         * symtab.c (lookup_global_symbol_from_objfile)
1083         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1084         foreach.
1085         * ser-tcp.c (net_open): Remove "struct" from foreach.
1086         * objfiles.c (objfile_relocate, objfile_rebase)
1087         (objfile_has_symbols): Remove "struct" from foreach.
1088         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1089         from foreach.
1090         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1091         foreach.
1092         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1093         "struct" from foreach.
1094         * ada-lang.c (create_excep_cond_exprs)
1095         (ada_exception_catchpoint_cond_string): Remove "struct" from
1096         foreach.
1097
1098 2019-05-03  Tom Tromey  <tromey@adacore.com>
1099
1100         * ada-exp.y (convert_char_literal): Check suffix of each
1101         enumerator.
1102
1103 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1104
1105         PR ada/21406:
1106         * ada-exp.y (yywrap): Don't define.
1107         * ada-lex.l (%option): Add noyywrap
1108         (yywrap): Remove.
1109
1110 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1111
1112         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1113         _WIN32_WINNT to the XP level, unless already defined to a higher
1114         level.
1115
1116         * unittests/parse-connection-spec-selftests.c:
1117         * ser-tcp.c:
1118         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1119         override.
1120
1121         * symfile.c (find_separate_debug_file): Remove colon from the
1122         drive spec of DOS/Windows file names of the target, so that the
1123         file name produced from DEBUGDIR and the target's directory will
1124         be valid on DOS/Windows systems.
1125
1126 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * rust-lang.c (val_print_struct): Handle printing structures
1129         containing strings.
1130
1131 2019-05-02  Tom Tromey  <tromey@adacore.com>
1132
1133         * valarith.c (_initialize_valarith): Remove.
1134
1135 2019-05-01  Tom Tromey  <tromey@adacore.com>
1136
1137         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1138         bitfields.
1139
1140 2019-05-01  Tom Tromey  <tromey@adacore.com>
1141
1142         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1143         for big-endian copies.
1144
1145 2019-04-30  Ali Tamur  <tamur@google.com>
1146         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1147         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1148         (read_3_bytes): New function.
1149
1150 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1151
1152         * windows-nat.c (main_thread_id): Delete.
1153         (handle_output_debug_string): Replace main_thread_id by
1154         current_event.dwThreadId.
1155         (fake_create_process): Likewise.
1156         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1157         Do not set main_thread_id.
1158         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1159         current_event.dwThreadId.
1160         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1161
1162 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1163
1164         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1165         Use current_event.dwThreadId instead of main_thread_id.
1166
1167 2019-04-30  Tom Tromey  <tromey@adacore.com>
1168
1169         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1170         (create_excep_cond_exprs): Iterate over program spaces.
1171         (ada_exception_catchpoint_cond_string): Examine all minimal
1172         symbols for exception types.
1173
1174 2019-04-30  Tom Tromey  <tromey@adacore.com>
1175
1176         PR c++/24470:
1177         * dwarf2read.c (process_structure_scope): Handle case where type
1178         has template parameters but no symbol was created.
1179
1180 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1181             Chris January  <chris.january@arm.com>
1182
1183         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1184         qualifier.
1185         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1186
1187 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * f-typeprint.c (f_print_type): Update rules for printing
1190         whitespace.
1191         (f_type_print_varspec_suffix): Likewise.
1192
1193 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1194             Chris January  <chris.january@arm.com>
1195
1196         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1197         function arguments.
1198
1199 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * f-lang.c (build_fortran_types): Change name of void type to
1202         lower case.
1203         * f-typeprint.c (f_type_print_base): Print the name of the void
1204         type, rather than a fixed string.
1205         * f-valprint.c (f_decorations): Use lower case void string.
1206
1207 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1208             Chris January  <chris.january@arm.com>
1209
1210         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1211         types for Fortran.
1212
1213 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1214             Chris January  <chris.january@arm.com>
1215             David Lecomber  <david.lecomber@arm.com>
1216
1217         * f-exp.y (BINOP_INTRINSIC): New token.
1218         (exp): New parser rule handling BINOP_INTRINSIC.
1219         (f77_keywords): Add new builtin procedures.
1220         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1221         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1222         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1223         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1224         (print_unop_subexp_f): New function.
1225         (print_binop_subexp_f): New function.
1226         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1227         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1228         (dump_subexp_body_f): Likewise.
1229         (operator_check_f): Likewise.
1230         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1231         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1232
1233 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1236         UNOP_KIND.
1237         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1238         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1239         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1240         (operator_length_f): New fuction.
1241         (print_subexp_f): New function.
1242         (op_name_f): New function.
1243         (dump_subexp_body_f): New function.
1244         (operator_check_f): New function.
1245         (exp_descriptor_f): Replace standard expression handling functions
1246         with new functions.
1247         * gdb/fortran-operator.def: New file.
1248         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1249         * gdb/std-operator.def: Remove UNOP_KIND.
1250
1251 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * std-operator.def: Remove unbalanced, stray double quote
1254         character.
1255
1256 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1257             Chris January  <chris.january@arm.com>
1258             Daniel Everett  <daniel.everett@arm.com>
1259             Nick Forrington  <nick.forrington@arm.com>
1260             Richard Bunt  <richard.bunt@arm.com>
1261
1262         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1263         of depth when printing anonymous structs or unions.
1264         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1265         Don't print either the top-level value, or the children if the
1266         max-depth is exceeded.
1267         (ppscm_print_children): When printing the key of a map, allow one
1268         extra level of depth.
1269         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1270         print either the top-level value, or the children if the max-depth
1271         is exceeded.
1272         (print_children): When printing the key of a map, allow one extra
1273         level of depth.
1274         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1275         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1276         (user_print_options): Initialise max_depth field.
1277         (val_print_scalar_or_string_type_p): New function.
1278         (val_print): Check to see if the max depth has been reached.
1279         (val_print_check_max_depth): Define new function.
1280         (show_print_max_depth): New function.
1281         (_initialize_valprint): Add 'print max-depth' option.
1282         * valprint.h (struct value_print_options) <max_depth>: New field.
1283         (val_print_check_max_depth): Declare new function.
1284         * NEWS: Document new feature.
1285
1286 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * ada-lang.c (ada_language_defn): Initialise new field.
1289         * c-lang.c (c_is_string_type_p): New function.
1290         (c_language_defn): Initialise new field.
1291         (cplus_language_defn): Initialise new field.
1292         (asm_language_defn): Initialise new field.
1293         (minimal_language_defn): Initialise new field.
1294         * c-lang.h (c_is_string_type_p): Declare new function.
1295         * d-lang.c (d_language_defn): Initialise new field.
1296         * f-lang.c (f_is_string_type_p): New function.
1297         (f_language_defn): Initialise new field.
1298         * go-lang.c (go_is_string_type_p): New function.
1299         (go_language_defn): Initialise new field.
1300         * language.c (default_is_string_type_p): New function.
1301         (unknown_language_defn): Initialise new field.
1302         (auto_language_defn): Initialise new field.
1303         * language.h (struct language_defn) <la_is_string_type_p>: New
1304         member variable.
1305         (default_is_string_type_p): Declare new function.
1306         * m2-lang.c (m2_language_defn): Initialise new field.
1307         * objc-lang.c (objc_language_defn): Initialise new field.
1308         * opencl-lang.c (opencl_language_defn): Initialise new field.
1309         * p-lang.c (pascal_is_string_type_p): New function.
1310         (pascal_language_defn): Initialise new field.
1311         * rust-lang.c (rust_is_string_type_p): New function.
1312         (rust_language_defn): Initialise new field.
1313
1314 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1317         New field.
1318         * ada-lang.c (ada_language_defn): Initialise new field.
1319         * c-lang.c (c_language_defn): Likewise.
1320         (cplus_language_defn): Likewise.
1321         (asm_language_defn): Likewise.
1322         (minimal_language_defn): Likewise.
1323         * d-lang.c (d_language_defn): Likewise.
1324         * f-lang.c (f_language_defn): Likewise.
1325         * go-lang.c (go_language_defn): Likewise.
1326         * language.c (unknown_language_defn): Likewise.
1327         (auto_language_defn): Likewise.
1328         * m2-lang.c (m2_language_defn): Likewise.
1329         * objc-lang.c (objc_language_defn): Likewise.
1330         * opencl-lang.c (opencl_language_defn): Likewise.
1331         * p-lang.c (pascal_language_defn): Likewise.
1332         * rust-lang.c (rust_language_defn): Likewise.
1333
1334 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * ada-lang.c (ada_is_character_type): Change return type to bool.
1337         (ada_is_string_type): Likewise.
1338         * ada-lang.h (ada_is_character_type): Update declaration
1339         (ada_is_string_type): Likewise.
1340
1341 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1342
1343         Support style in 'frame|thread apply'
1344
1345         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1346         * record.c (record_start, record_stop): Update callers of
1347         execute_command_to_string with false.
1348         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1349         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1350         methods.
1351         (class string_file): New constructor with term_out parameter.
1352         Override methods term_out and can_emit_style_escape.  New member
1353         term_out.
1354         (class stdio_file): Override can_emit_style_escape.
1355         (class tee_file): Override term_out and can_emit_style_escape.
1356         * utils.h (can_emit_style_escape): Remove.
1357         * utils.c (can_emit_style_escape): Likewise.
1358         Update all callers of can_emit_style_escape (SOMESTREAM) to
1359         SOMESTREAM->can_emit_style_escape.
1360         * source-cache.c (source_cache::get_source_lines): Likewise.
1361         * stack.c (frame_apply_command_count): Call execute_command_to_string
1362         passing the term_out characteristic of the current gdb_stdout.
1363         * thread.c (thr_try_catch_cmd): Likewise.
1364         * top.c (execute_command_to_string): pass term_out parameter
1365         to construct the string_file for the command output.
1366         * ui-file.c (term_cli_styling): New function (most code moved
1367         from utils.c can_emit_style_escape).
1368         (string_file::string_file, string_file::can_emit_style_escape,
1369         stdio_file::can_emit_style_escape, tee_file::term_out,
1370         tee_file::can_emit_style_escape): New functions.
1371
1372 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * NEWS: Mention the new set|show may-call-functions.
1375         * infcall.c (may_call_functions_p): New variable.
1376         (show_may_call_functions_p): New function.
1377         (call_function_by_hand_dummy): Throws an error if not
1378         may-call-functions.
1379         (_initialize_infcall): Call add_setshow_boolean_cmd for
1380         may-call-functions.
1381
1382 2019-04-25  Keith Seitz  <keiths@redhat.com>
1383
1384         PR c++/24367
1385         * cp-support.c (inspect_type): Don't attempt substitutions
1386         of symbol with the same name.
1387
1388 2019-04-25  Tom Tromey  <tromey@adacore.com>
1389
1390         PR gdb/24475:
1391         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1392         static.
1393
1394 2019-04-25  Tom Tromey  <tromey@adacore.com>
1395
1396         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1397         rvalue reference.
1398         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1399         (gdb_xml_parser::parse): Use std::move.
1400         * python/python-internal.h (gdbpy_convert_exception): Take a const
1401         reference.
1402         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1403         std::move.
1404         * python/py-utils.c (gdbpy_convert_exception): Take a const
1405         reference.
1406         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1407         Use std::move.
1408         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1409         Use std::move.
1410         * mi/mi-main.c (mi_print_exception): Take a const reference.
1411         * main.c (handle_command_errors): Take a const reference.
1412         * linespec.c (parse_linespec): Use std::move.
1413         * infcall.c (run_inferior_call): Use std::move.
1414         (call_function_by_hand_dummy): Use std::move.
1415         * exec.c (try_open_exec_file): Use std::move.
1416         * exceptions.h (exception_print, exception_fprintf)
1417         (exception_print_same): Update.
1418         * exceptions.c (print_exception, exception_print)
1419         (exception_fprintf, exception_print_same): Change parameters to
1420         const reference.
1421         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1422         * common/new-op.c: Use std::move.
1423         * common/common-exceptions.h (struct gdb_exception): Add move
1424         constructor.
1425         (struct gdb_exception_error, struct gdb_exception_quit, struct
1426         gdb_quit_bad_alloc): Change constructor to move constructor.
1427         (throw_exception): Change parameter to rvalue reference.
1428         * common/common-exceptions.c (throw_exception): Take rvalue
1429         reference.
1430         * cli/cli-interp.c (safe_execute_command): Use std::move.
1431         * breakpoint.c (insert_bp_location, location_to_sals): Use
1432         std::move.
1433
1434 2019-04-25  Tom Tromey  <tromey@adacore.com>
1435
1436         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1437         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1438         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1439         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1440         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1441         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1442         guile/scm-value.c: Use unpack.
1443         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1444         gdbscm_gdb_exception.
1445         (gdbscm_throw_gdb_exception): Likewise.
1446         (struct gdbscm_gdb_exception): New.
1447         (unpack): New function.
1448         (gdbscm_wrap): Use unpack.
1449
1450 2019-04-25  Tom Tromey  <tromey@adacore.com>
1451
1452         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1453         (gdb_rl_callback_handler): Use std::move.
1454         * common/common-exceptions.h (struct gdb_exception): Add move
1455         assignment operator.
1456         (throw_exception_sjlj): Change "exception" to const reference.
1457         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1458         (throw_exception_sjlj): Change "exception" to const reference.
1459
1460 2019-04-25  Tom Tromey  <tromey@adacore.com>
1461
1462         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1463         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1464         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1465         Update.
1466         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1467         Update.
1468         * mi/mi-interp.c (mi_interp::exec): Update.
1469         * linespec.c (parse_linespec): Update.
1470         * infcall.c (run_inferior_call): Update.
1471         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1472         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1473         (gdbscm_lookup_global_symbol): Update.
1474         * guile/scm-param.c (gdbscm_parameter_value): Update.
1475         * guile/scm-frame.c (gdbscm_frame_read_register)
1476         (gdbscm_frame_read_var): Update.
1477         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1478         * exec.c (try_open_exec_file): Update.
1479         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1480         (gdb_rl_callback_handler): Update.
1481         * common/common-exceptions.h (exception_none): Don't declare.
1482         * common/common-exceptions.c (exception_none): Don't define.
1483         (struct catcher) <exception>: Update.
1484         * cli/cli-interp.c (safe_execute_command): Update.
1485         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1486
1487 2019-04-25  Ali Tamur  <tamur@google.com>
1488
1489         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1490         (read_attribute_value): Likewise.
1491         (dwarf2_read_addr_index): Update comment.
1492         (read_str_index): Add DW_FORM_strx.
1493         (dwarf2_string_attr): Likewise.
1494         (dwarf2_const_value_attr): Likewise.
1495         (dump_die_shallow): Likewise.
1496         (dwarf2_fetch_constant_bytes): Likewise.
1497         (skip_form_bytes): Likewise.
1498         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1499
1500 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1501
1502         PR corefiles/11608
1503         PR corefiles/18187
1504         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1505         OFFSET.  Verify if current mapping contains an ELF header.
1506         (linux_find_memory_regions_full): Adjust call to
1507         dump_mapping_p.
1508
1509 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1510             Kang Li <kanglictf@gmail.com>
1511
1512         PR gdb/21600
1513
1514         * dwarf2-frame.c (read_initial_length): Be consistent about using
1515         unsigned representation of length.
1516         (decode_frame_entry_1): Likewise.  Check for wraparound of
1517         end pointer as well as buffer overflow.
1518
1519 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1520
1521         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1522         "vq".
1523
1524 2019-04-24  Tom Tromey  <tromey@adacore.com>
1525
1526         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1527
1528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * s12z-tdep.c (s12z_unwind_pc): Delete.
1531         (s12z_unwind_sp): Delete.
1532         (s12z_gdbarch_init): Don't register deleted functions with
1533         gdbarch.
1534
1535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * rl78-tdep.c (rl78_unwind_sp): Delete.
1538         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1539
1540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1543         (xstormy16_unwind_pc): Delete.
1544         (xstormy16_dummy_id): Delete.
1545         (xstormy16_gdbarch_init): Don't register deleted functions with
1546         gdbarch.
1547
1548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * vax-tdep.c (vax_unwind_pc): Delete.
1551         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1552
1553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * v850-tdep.c (v850_unwind_sp): Delete.
1556         (v850_unwind_pc): Delete.
1557         (v850_dummy_id): Delete.
1558         (v850_gdbarch_init): Don't register deleted functions with
1559         gdbarch.
1560
1561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1564         (tilegx_unwind_pc): Delete.
1565         (tilegx_unwind_dummy_id): Delete.
1566         (tilegx_gdbarch_init): Don't register deleted functions with
1567         gdbarch.
1568
1569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1572         (tic6x_dummy_id): Delete.
1573         (tic6x_gdbarch_init): Don't register deleted functions with
1574         gdbarch.
1575
1576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * sparc-tdep.c (sparc_unwind_pc): Delete.
1579         (sparc32_gdbarch_init): Don't register deleted function with
1580         gdbarch.
1581
1582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1583
1584         * sh-tdep.c (sh_unwind_sp): Delete.
1585         (sh_unwind_pc): Delete.
1586         (sh_dummy_id): Delete.
1587         (sh_gdbarch_init): Don't register deleted functions with
1588         gdbarch.
1589
1590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * score-tdep.c (score_unwind_sp): Delete.
1593         (score_unwind_pc): Delete.
1594         (score_dummy_id): Delete.
1595         (score_gdbarch_init): Don't register deleted functions with
1596         gdbarch.
1597
1598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         * rx-tdep.c (rx_unwind_pc): Delete.
1601         (rx_unwind_sp): Delete.
1602         (rx_dummy_id): Delete.
1603         (rx_gdbarch_init): Don't register deleted functions with
1604         gdbarch.  Update comment.
1605
1606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1609         (rs6000_dummy_id): Delete.
1610         (rs6000_gdbarch_init): Don't register deleted functions with
1611         gdbarch.
1612
1613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * or1k-tdep.c (or1k_dummy_id): Delete.
1616         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1617
1618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * nios2-tdep.c (nios2_dummy_id): Delete.
1621         (nios2_unwind_sp): Delete.
1622         (nios2_gdbarch_init): Don't register deleted functions with
1623         gdbarch.
1624
1625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * nds32-tdep.c (nds32_dummy_id): Delete.
1628         (nds32_unwind_pc): Delete.
1629         (nds32_unwind_sp): Delete.
1630         (nds32_gdbarch_init): Don't register deleted functions with
1631         gdbarch.
1632
1633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * msp430-tdep.c (msp430_unwind_pc): Delete.
1636         (msp430_unwind_sp): Delete.
1637         (msp430_dummy_id): Delete.
1638         (msp430_gdbarch_init): Don't register deleted functions with
1639         gdbarch.
1640
1641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * moxie-tdep.c (moxie_unwind_sp): Delete.
1644         (moxie_unwind_pc): Delete.
1645         (moxie_dummy_id): Delete.
1646         (moxie_gdbarch_init): Don't register deleted functions with
1647         gdbarch.
1648
1649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1650
1651         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1652         (mn10300_unwind_pc): Delete.
1653         (mn10300_unwind_sp): Delete.
1654         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1655         mn10300_unwind_sp.
1656         (mn10300_frame_unwind_init): Don't register deleted functions with
1657         gdbarch.
1658
1659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * mep-tdep.c (mep_unwind_pc): Delete.
1662         (mep_unwind_sp): Delete.
1663         (mep_dummy_id): Delete.
1664         (mep_gdbarch_init): Don't register deleted functions with
1665         gdbarch.
1666
1667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1668
1669         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1670         (m68hc11_unwind_sp): Delete.
1671         (m68hc11_gdbarch_init): Don't register deleted functions with
1672         gdbarch.
1673
1674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * m32r-tdep.c (m32r_unwind_sp): Delete.
1677         (m32r_unwind_pc): Delete.
1678         (m32r_dummy_id): Delete.
1679         (m32r_gdbarch_init): Don't register deleted functions with
1680         gdbarch.
1681
1682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * m32c-tdep.c (m32c_unwind_pc): Delete.
1685         (m32c_unwind_sp): Delete.
1686         (m32c_dummy_id): Delete.
1687         (m32c_gdbarch_init): Don't register deleted functions with
1688         gdbarch.
1689
1690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1691
1692         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1693         (lm32_unwind_pc): Delete.
1694         (lm32_dummy_id): Delete.
1695         (lm32_gdbarch_init): Don't register deleted functions with
1696         gdbarch.
1697
1698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1699
1700         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1701         (iq2000_unwind_pc): Delete.
1702         (iq2000_dummy_id): Delete.
1703         (iq2000_gdbarch_init): Don't register deleted functions with
1704         gdbarch.
1705
1706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1707
1708         * nds32-tdep.c (nds32_type_align): Delete.
1709         (nds32_push_dummy_call): Use type_align instead.
1710
1711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1712
1713         * arm-tdep.c (arm_type_align): Only handle vector override case.
1714         (arm_push_dummy_call): Use type_align.
1715         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1716
1717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1718
1719         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1720         case.
1721         (pass_on_stack): Use type_align.
1722         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1723         function.
1724
1725 2019-04-23  Tom Tromey  <tromey@adacore.com>
1726
1727         * dwarf2read.c (line_header::file_name_at): Remove unused
1728         overload.
1729
1730 2019-04-23  Tom de Vries  <tdevries@suse.de>
1731
1732         PR gdb/24438
1733         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1734         invocation.
1735
1736
1737 2019-03-27  Ali Tamur  <tamur@google.com>
1738
1739         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1740         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1741         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1742         (dwarf_expr_context::get_addr_index): Likewise
1743         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1744         (symbol_needs_eval_context::get_addr_index): Likewise
1745         (disassemble_dwarf_expression): Add DW_OP_addrx
1746         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1747         (read_cutu_die_from_dwo): Update comment
1748         (skip_one_die): Add DW_FORM_addrx
1749         (read_attribute_value): Likewise
1750         (var_decode_location): Add DW_OP_addrx
1751         (dwarf2_const_value_attr): Add DW_FORM_addrx
1752         (dump_die_shallow): Likewise
1753         (dwarf2_fetch_constant_bytes): Likewise
1754         (decode_locdesc): Add DW_OP_addrx
1755         (skip_form_bytes): Add DW_FORM_addrx
1756
1757 2019-04-22  Ali Tamur  <tamur@google.com>
1758
1759         * MAINTAINERS (Write After Approval): Add self.
1760
1761 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1762
1763         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1764         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1765         (open_symbol_file_object): Likewise.
1766         (svr4_default_sos): Add info parameter.
1767         (svr4_read_so_list): Likewise.
1768         (svr4_current_sos_direct): Adjust functions calls to pass down
1769         info.
1770         (svr4_current_sos_1): Add info parameter.
1771         (svr4_current_sos): Call get_svr4_info, pass info down to
1772         svr4_current_sos_1.
1773         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1774         get_svr4_info.
1775         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1776         get_svr4_info.
1777         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1778         to get_svr4_info.
1779         (probes_table_remove_objfile_probes): Likewise.
1780         (register_solib_event_probe): Add info parameter.
1781         (solist_update_incremental): Pass info parameter down to
1782         svr4_read_so_list.
1783         (disable_probes_interface): Add info parameter.
1784         (svr4_handle_solib_event): Pass current_program_space to
1785         get_svr4_info.  Adjust disable_probes_interface cleanup.
1786         (svr4_create_probe_breakpoints): Add info parameter, pass it
1787         down to register_solib_event_probe.
1788         (svr4_create_solib_event_breakpoints): Add info parameter,
1789         pass it down to svr4_create_probe_breakpoints.
1790         (enable_break): Pass info down to
1791         svr4_create_solib_event_breakpoints.
1792         (svr4_solib_create_inferior_hook): Pass current_program_space to
1793         get_svr4_info.
1794         (svr4_clear_solib): Likewise.
1795
1796 2019-04-22  Pedro Alves  <palves@redhat.com>
1797
1798         * solib-svr4.c (svr4_free_objfile_observer): New.
1799         (probe_and_action::objfile): New field.
1800         (probes_table_htab_remove_objfile_probes)
1801         (probes_table_remove_objfile_probes): New functions.
1802         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1803         in the new probe_and_action.  Don't store the probe in 'lookup'.
1804         (svr4_create_probe_breakpoints): Pass objfile to
1805         register_solib_event_probe.
1806         (_initialize_svr4_solib): Register a free_objfile observer.
1807
1808 2019-04-19  Tom Tromey  <tom@tromey.com>
1809
1810         * common/queue.h: Remove.
1811
1812 2019-04-19  Tom Tromey  <tom@tromey.com>
1813
1814         * event-loop.c: Don't include "common/queue.h".
1815
1816 2019-04-19  Tom Tromey  <tom@tromey.com>
1817
1818         * remote.c (remote_target): Use delete.
1819         * remote-notif.h: Include <list>, not "common/queue.h".
1820         (notif_client_p): Remove typedef.
1821         (remote_notif_state): Add constructor, destructor, initializer.
1822         <notif_queue>: Now a std::list.
1823         (remote_notif_state_xfree): Don't declare.
1824         * remote-notif.c (remote_notif_process, handle_notification)
1825         (remote_notif_state_allocate): Update.
1826         (~remote_notif_state): Rename from remote_notif_state_xfree.
1827
1828 2019-04-19  Tom Tromey  <tom@tromey.com>
1829
1830         * symfile.c (reread_symbols): Update.
1831         * objfiles.c (objfile_register_static_link)
1832         (objfile_lookup_static_link): Update
1833         (~objfile) Don't delete static_links.
1834         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1835
1836 2019-04-19  Tom Tromey  <tom@tromey.com>
1837
1838         * type-stack.h (struct type_stack) <insert>: Constify string.
1839         * type-stack.c (type_stack::insert): Constify string.
1840         * gdbtypes.h (lookup_template_type): Update.
1841         (address_space_name_to_int): Update.
1842         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1843         const.
1844         (lookup_template_type): Make name const.
1845         * c-exp.y: Update rules.
1846         (lex_one_token, classify_name, classify_inner_name)
1847         (c_print_token): Update.
1848         * p-exp.y: Update rules.
1849         (yylex): Update.
1850         * f-exp.y: Update rules.
1851         (yylex): Update.
1852         * d-exp.y: Update rules.
1853         (lex_one_token, classify_name, classify_inner_name): Update.
1854         * parse.c (write_dollar_variable, copy_name): Return std::string.
1855         * parser-defs.h (copy_name): Change return type.
1856         * m2-exp.y: Update rules.
1857         (yylex): Update.
1858         * go-exp.y (lex_one_token): Update.
1859         Update rules.
1860         (classify_unsafe_function, classify_packaged_name)
1861         (classify_name, yylex): Update.
1862
1863 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1864
1865         * configure.ac: add --enable-source-highlight switch.
1866         * configure: Regenerate.
1867         * top.c (print_gdb_version): plumb --enable-source-highlight
1868         status to "show configuration".
1869
1870 2019-04-19  Tom Tromey  <tromey@adacore.com>
1871
1872         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1873         Check ADA_TYPE_P.
1874         (empty_record, ada_template_to_fixed_record_type_1)
1875         (template_to_static_fixed_type)
1876         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1877         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1878         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1879         macros.
1880
1881 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1882
1883         PR symtab/24423:
1884         * source.c (print_source_lines_base): Advance "iter" when a
1885         control character is seen.
1886
1887 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1888
1889         * inferior.h (struct infcall_suspend_state_deleter):
1890         Catch exception in destructor to avoid crash.
1891
1892 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1893
1894         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1895         close to the add_com "shell".
1896
1897 2019-04-18  Tom Tromey  <tromey@adacore.com>
1898
1899         * process-stratum-target.h (class process_stratum_target)
1900         <stratum>: Add "final".
1901
1902 2019-04-17  Tom Tromey  <tromey@adacore.com>
1903
1904         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1905         against nullptr before use.
1906
1907 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1908
1909         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1910
1911 2019-04-17  Jim Wilson  <jimw@sifive.com>
1912             Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1915         code read might fail, assume 4-byte breakpoint in that case.
1916
1917 2019-04-15  Leszek Swirski  <leszeks@google.com>
1918
1919         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1920         rather than a hand-rolled POD check when checking for forced MEMORY
1921         classification.
1922
1923 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1924
1925         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1926         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1927         function.
1928         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1929         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1930         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1931         declaration.
1932
1933 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1934
1935         * aarch64-linux-nat.c
1936         (aarch64_linux_nat_target::thread_architecture): Add override.
1937         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1938         each VQ.
1939
1940 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1941
1942         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1943
1944 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1947         target types of size 96-bits, add some additional comments, and
1948         check that the builtin type we found was the correct size.
1949
1950 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1951
1952         * utils.c (prompt_for_continue): Don't restore the styling at the
1953         end, as applied_style has the wrong value.  This fixes styling in
1954         long lists of file names that are interrupted by the "Continue?"
1955         prompt.
1956
1957 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1960         * c-lang.c (c_language_defn): Likewise.
1961         (cplus_language_defn): Likewise.
1962         (asm_language_defn): Likewise.
1963         (minimal_language_defn): Likewise.
1964         * d-lang.c (d_language_defn): Likewise.
1965         * f-lang.c (f_language_defn): Likewise.
1966         * go-lang.c (go_language_defn): Likewise.
1967         * language.c (unknown_language_defn): Likewise.
1968         (auto_language_defn): Likewise.
1969         * language.h (struct language_defn): Remove la_magic field.
1970         (LANG_MAGIC): Delete.
1971         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1972         * objc-lang.c (objc_language_defn): Likewise.
1973         * opencl-lang.c (opencl_language_defn): Likewise.
1974         * p-lang.c (pascal_language_defn): Likewise.
1975         * rust-lang.c (rust_language_defn): Likewise.
1976
1977 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1978
1979         * riscv-tdep.c (riscv_type_align): New function.
1980         (riscv_type_alignment): Delete.
1981         (riscv_arg_location): Use 'type_align'.
1982         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1983
1984 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1985
1986         * gdbtypes.c (type_align): A struct with no non-static fields also
1987         has alignment of 1.
1988
1989 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1992         component to 0.
1993         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1994         member.
1995         (riscv_struct_info::analyse): New implementation using new
1996         analyse_inner member function.
1997         (riscv_struct_info::field_offset): New member function.
1998         (riscv_struct_info::m_offsets): New member variable.
1999         (riscv_struct_info::analyse_inner): New private member function,
2000         takes the old implementation of riscv_struct_info::analyse but
2001         extended to track field offsets.
2002         (riscv_call_arg_struct): Update the struct folding special cases
2003         to handle cases where empty C++ structs, which are non-zero
2004         length, are found.
2005         (riscv_arg_location): Initialise the length of each location, a
2006         non-zero length now indicates the location is in use.
2007         (riscv_push_dummy_call): Allow for the first location having a
2008         non-zero offset when setting up arguments.
2009         (riscv_return_value): Likewise, but for return values.
2010
2011 2019-04-11  Tom Tromey  <tromey@adacore.com>
2012
2013         * utils.c (internal_vproblem): Make "msg" const.
2014
2015 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2016
2017         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2018         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2019         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2020         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2021
2022 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2023
2024         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2025         function.
2026         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2027         of amd64_collect_native_gregset.
2028         (amd64_linux_nat_target::store_registers): Likewise.
2029
2030 2019-04-10  Tom Tromey  <tom@tromey.com>
2031
2032         * symtab.c (lookup_global_symbol_from_objfile)
2033         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2034         * objfiles.h (class separate_debug_iterator): New.
2035         (class separate_debug_range): New.
2036         (struct objfile) <separate_debug_objfiles>: New method.
2037         (objfile_separate_debug_iterate): Don't declare.
2038         * objfiles.c (separate_debug_iterator::operator++): Rename from
2039         objfile_separate_debug_iterate.
2040         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2041         iterator.
2042         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2043         iterator.
2044
2045 2019-04-10  Tom Tromey  <tom@tromey.com>
2046
2047         * symfile.c (reread_symbols): Remove old comment.
2048         * objfiles.c (free_all_objfiles): Fix a typo.
2049
2050 2019-04-10  Tom Tromey  <tom@tromey.com>
2051
2052         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2053         * minsyms.c (lookup_minimal_symbol): Use foreach.
2054         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2055         (lookup_minimal_symbol_solib_trampoline): Likewise.
2056         * symfile.c (reread_symbols): Use foreach.
2057
2058 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2059             Tom Tromey  <tromey@adacore.com>
2060
2061         PR rust/24414:
2062         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2063         (rust_lex_int_test): Change "value" to be LONGEST.
2064         (rust_lex_tests): Add test for long integer literal.
2065
2066 2019-04-09  Tom Tromey  <tromey@adacore.com>
2067
2068         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2069         to bool.
2070         (extended_remote_target::attach): Update.
2071         (remote_target::remote_notice_new_inferior): Update.
2072         (remote_target::add_current_inferior_and_thread): Update.
2073         * inferior.c (exit_inferior_1): Use "false".
2074         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2075
2076 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2077
2078         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2079         the "start" command.
2080
2081 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2082
2083         * python/py-inferior.c (infpy_thread_from_thread_handle):
2084         Adjust comments to reflect renaming of thread_from_thread_handle
2085         to thread_from_handle.  Adjust keywords.  Fix type error message.
2086         (inferior_object_methods): Add thread_from_handle.  Retain
2087         thread_from_thread_handle, but mark it as deprecated.
2088
2089 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2090
2091         * gdbthread.h (find_thread_by_handle): Revise declaration.
2092         * thread.c (find_thread_by_handle): Likewise.  Adjust
2093         implementation too.
2094         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2095         support for buffer objects as handles.
2096
2097 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2098
2099         * python/py-infthread.c (thpy_thread_handle): New function.
2100         (thread_object_methods): Register thpy_thread_handle.
2101
2102 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2103
2104         * gdbthread.h (thread_to_thread_handle): Declare.
2105         * thread.c (gdbtypes.h): Include.
2106         (thread_to_thread_handle): New function.
2107
2108         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2109         (target_thread_info_to_thread_handle): Declare.
2110         * target.c (target_thread_info_to_thread_handle): New function.
2111         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2112         * target-delegates.c: Regenerate.
2113
2114         * linux-thread-db.c (class thread_db_target): Add method
2115         thread_info_to_thread_handle.
2116         (thread_db_target::thread_info_to_thread_handle): Define.
2117         * remote.c (class remote_target): Add new method
2118         thread_info_to_thread_handle.
2119         (remote_target::thread_info_to_thread_handle): Define.
2120
2121 2019-04-08  Pedro Alves  <palves@redhat.com>
2122
2123         * common/common-exceptions.c (throw_exception): Don't create
2124         named object to throw; throw directly.
2125         (throw_it): Likewise.  Don't initialize gdb_exception::message
2126         here, with new; pass FMT and AP to the ctor instead.
2127         * common/common-exceptions.h: Include <string>.
2128         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2129         const char *, va_list)): New ctor.  Use std::make_shared.
2130         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2131         errors)): Delete.
2132         (gdb_exception_error::gdb_exception_error(enum errors, const char
2133         *, va_list)): New.
2134         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2135         Add assertion.
2136         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2137         errors)): Delete.
2138         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2139         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2140         Add assertion.
2141
2142 2019-04-08  Tom Tromey  <tom@tromey.com>
2143
2144         * valops.c (value_rtti_indirect_type): Replace throw_exception
2145         with throw.
2146         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2147         with throw.
2148         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2149         throw.
2150         * target.c (target_translate_tls_address): Replace throw_exception
2151         with throw.
2152         * stack.c (frame_apply_command_count): Replace throw_exception
2153         with throw.
2154         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2155         throw.
2156         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2157         with throw.
2158         * rs6000-tdep.c (rs6000_frame_cache)
2159         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2160         * remote.c: Replace throw_exception with throw.
2161         * record-full.c (record_full_message, record_full_wait_1)
2162         (record_full_restore): Replace throw_exception with throw.
2163         * record-btrace.c:
2164         (get_thread_current_frame_id, record_btrace_start_replaying)
2165         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2166         (cmd_record_btrace_start): Replace throw_exception with throw.
2167         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2168         throw.
2169         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2170         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2171         * linespec.c:
2172         (find_linespec_symbols): Replace throw_exception with throw.
2173         * infrun.c (displaced_step_prepare, resume): Replace
2174         throw_exception with throw.
2175         * infcmd.c (post_create_inferior): Replace throw_exception with
2176         throw.
2177         * inf-loop.c (inferior_event_handler): Replace throw_exception
2178         with throw.
2179         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2180         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2181         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2182         (get_prev_frame_always, get_frame_pc_if_available)
2183         (get_frame_address_in_block_if_available, get_frame_language):
2184         Replace throw_exception with throw.
2185         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2186         throw_exception with throw.
2187         * eval.c (fetch_subexp_value, evaluate_var_value)
2188         (evaluate_funcall, evaluate_subexp_standard): Replace
2189         throw_exception with throw.
2190         * dwarf2loc.c (call_site_find_chain)
2191         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2192         Replace throw_exception with throw.
2193         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2194         with throw.
2195         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2196         throw.
2197         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2198         * completer.c (complete_line_internal): Replace throw_exception
2199         with throw.
2200         * compile/compile-object-run.c (compile_object_run): Replace
2201         throw_exception with throw.
2202         * cli/cli-script.c (process_next_line): Replace throw_exception
2203         with throw.
2204         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2205         (btrace_enable, btrace_maint_update_pt_packets): Replace
2206         throw_exception with throw.
2207         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2208         throw_exception with throw.
2209         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2210         throw_exception with throw.
2211         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2212         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2213         * aarch64-tdep.c (aarch64_make_prologue_cache)
2214         (aarch64_make_stub_cache): Replace throw_exception with throw.
2215
2216 2019-04-08  Tom Tromey  <tom@tromey.com>
2217
2218         * common/common-exceptions.c (throw_exception): Rename from
2219         throw_exception_cxx.  Remove old copy.  Make argument const.
2220         (throw_it): Create and throw exception objects directly.
2221         * common/common-exceptions.h (throw_exception): Make argument
2222         const.
2223         (struct gdb_exception_error): Add constructor.
2224         (struct gdb_exception_quit): Add constructor.
2225
2226 2019-04-08  Tom Tromey  <tom@tromey.com>
2227
2228         * common/common-exceptions.h (exception_rethrow): Don't declare.
2229         (TRY_SJLJ): Update comment.
2230         (TRY, CATCH, END_CATCH): Remove.
2231         * common/common-exceptions.c (exception_rethrow): Remove.
2232
2233 2019-04-08  Tom Tromey  <tom@tromey.com>
2234
2235         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2236         Remove.
2237         (gdb_exception_error): Rename from
2238         gdb_exception_RETURN_MASK_ERROR.
2239         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2240         (gdb_quit_bad_alloc): Update.
2241         * aarch64-tdep.c: Update.
2242         * ada-lang.c: Update.
2243         * ada-typeprint.c: Update.
2244         * ada-valprint.c: Update.
2245         * amd64-tdep.c: Update.
2246         * arch-utils.c: Update.
2247         * break-catch-throw.c: Update.
2248         * breakpoint.c: Update.
2249         * btrace.c: Update.
2250         * c-varobj.c: Update.
2251         * cli/cli-cmds.c: Update.
2252         * cli/cli-interp.c: Update.
2253         * cli/cli-script.c: Update.
2254         * common/common-exceptions.c: Update.
2255         * common/new-op.c: Update.
2256         * common/selftest.c: Update.
2257         * compile/compile-c-symbols.c: Update.
2258         * compile/compile-cplus-symbols.c: Update.
2259         * compile/compile-object-load.c: Update.
2260         * compile/compile-object-run.c: Update.
2261         * completer.c: Update.
2262         * corelow.c: Update.
2263         * cp-abi.c: Update.
2264         * cp-support.c: Update.
2265         * cp-valprint.c: Update.
2266         * darwin-nat.c: Update.
2267         * disasm-selftests.c: Update.
2268         * dtrace-probe.c: Update.
2269         * dwarf-index-cache.c: Update.
2270         * dwarf-index-write.c: Update.
2271         * dwarf2-frame-tailcall.c: Update.
2272         * dwarf2-frame.c: Update.
2273         * dwarf2loc.c: Update.
2274         * dwarf2read.c: Update.
2275         * eval.c: Update.
2276         * event-loop.c: Update.
2277         * event-top.c: Update.
2278         * exec.c: Update.
2279         * f-valprint.c: Update.
2280         * fbsd-tdep.c: Update.
2281         * frame-unwind.c: Update.
2282         * frame.c: Update.
2283         * gdbtypes.c: Update.
2284         * gnu-v3-abi.c: Update.
2285         * guile/guile-internal.h: Update.
2286         * guile/scm-block.c: Update.
2287         * guile/scm-breakpoint.c: Update.
2288         * guile/scm-cmd.c: Update.
2289         * guile/scm-disasm.c: Update.
2290         * guile/scm-frame.c: Update.
2291         * guile/scm-lazy-string.c: Update.
2292         * guile/scm-math.c: Update.
2293         * guile/scm-param.c: Update.
2294         * guile/scm-ports.c: Update.
2295         * guile/scm-pretty-print.c: Update.
2296         * guile/scm-symbol.c: Update.
2297         * guile/scm-symtab.c: Update.
2298         * guile/scm-type.c: Update.
2299         * guile/scm-value.c: Update.
2300         * i386-linux-tdep.c: Update.
2301         * i386-tdep.c: Update.
2302         * inf-loop.c: Update.
2303         * infcall.c: Update.
2304         * infcmd.c: Update.
2305         * infrun.c: Update.
2306         * jit.c: Update.
2307         * language.c: Update.
2308         * linespec.c: Update.
2309         * linux-fork.c: Update.
2310         * linux-nat.c: Update.
2311         * linux-tdep.c: Update.
2312         * linux-thread-db.c: Update.
2313         * main.c: Update.
2314         * mi/mi-cmd-break.c: Update.
2315         * mi/mi-cmd-stack.c: Update.
2316         * mi/mi-interp.c: Update.
2317         * mi/mi-main.c: Update.
2318         * objc-lang.c: Update.
2319         * p-valprint.c: Update.
2320         * parse.c: Update.
2321         * ppc-linux-tdep.c: Update.
2322         * printcmd.c: Update.
2323         * python/py-arch.c: Update.
2324         * python/py-breakpoint.c: Update.
2325         * python/py-cmd.c: Update.
2326         * python/py-finishbreakpoint.c: Update.
2327         * python/py-frame.c: Update.
2328         * python/py-framefilter.c: Update.
2329         * python/py-gdb-readline.c: Update.
2330         * python/py-inferior.c: Update.
2331         * python/py-infthread.c: Update.
2332         * python/py-lazy-string.c: Update.
2333         * python/py-linetable.c: Update.
2334         * python/py-objfile.c: Update.
2335         * python/py-param.c: Update.
2336         * python/py-prettyprint.c: Update.
2337         * python/py-progspace.c: Update.
2338         * python/py-record-btrace.c: Update.
2339         * python/py-record.c: Update.
2340         * python/py-symbol.c: Update.
2341         * python/py-type.c: Update.
2342         * python/py-unwind.c: Update.
2343         * python/py-utils.c: Update.
2344         * python/py-value.c: Update.
2345         * python/python.c: Update.
2346         * record-btrace.c: Update.
2347         * record-full.c: Update.
2348         * remote-fileio.c: Update.
2349         * remote.c: Update.
2350         * riscv-tdep.c: Update.
2351         * rs6000-aix-tdep.c: Update.
2352         * rs6000-tdep.c: Update.
2353         * rust-exp.y: Update.
2354         * rust-lang.c: Update.
2355         * s390-tdep.c: Update.
2356         * selftest-arch.c: Update.
2357         * solib-dsbt.c: Update.
2358         * solib-frv.c: Update.
2359         * solib-spu.c: Update.
2360         * solib-svr4.c: Update.
2361         * solib.c: Update.
2362         * sparc64-linux-tdep.c: Update.
2363         * stack.c: Update.
2364         * symfile-mem.c: Update.
2365         * symmisc.c: Update.
2366         * target.c: Update.
2367         * thread.c: Update.
2368         * top.c: Update.
2369         * tracefile-tfile.c: Update.
2370         * tui/tui.c: Update.
2371         * typeprint.c: Update.
2372         * unittests/cli-utils-selftests.c: Update.
2373         * unittests/parse-connection-spec-selftests.c: Update.
2374         * valops.c: Update.
2375         * valprint.c: Update.
2376         * value.c: Update.
2377         * varobj.c: Update.
2378         * windows-nat.c: Update.
2379         * x86-linux-nat.c: Update.
2380         * xml-support.c: Update.
2381
2382 2019-04-08  Tom Tromey  <tom@tromey.com>
2383
2384         * xml-support.c: Use C++ exception handling.
2385         * x86-linux-nat.c: Use C++ exception handling.
2386         * windows-nat.c: Use C++ exception handling.
2387         * varobj.c: Use C++ exception handling.
2388         * value.c: Use C++ exception handling.
2389         * valprint.c: Use C++ exception handling.
2390         * valops.c: Use C++ exception handling.
2391         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2392         handling.
2393         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2394         * typeprint.c: Use C++ exception handling.
2395         * tui/tui.c: Use C++ exception handling.
2396         * tracefile-tfile.c: Use C++ exception handling.
2397         * top.c: Use C++ exception handling.
2398         * thread.c: Use C++ exception handling.
2399         * target.c: Use C++ exception handling.
2400         * symmisc.c: Use C++ exception handling.
2401         * symfile-mem.c: Use C++ exception handling.
2402         * stack.c: Use C++ exception handling.
2403         * sparc64-linux-tdep.c: Use C++ exception handling.
2404         * solib.c: Use C++ exception handling.
2405         * solib-svr4.c: Use C++ exception handling.
2406         * solib-spu.c: Use C++ exception handling.
2407         * solib-frv.c: Use C++ exception handling.
2408         * solib-dsbt.c: Use C++ exception handling.
2409         * selftest-arch.c: Use C++ exception handling.
2410         * s390-tdep.c: Use C++ exception handling.
2411         * rust-lang.c: Use C++ exception handling.
2412         * rust-exp.y: Use C++ exception handling.
2413         * rs6000-tdep.c: Use C++ exception handling.
2414         * rs6000-aix-tdep.c: Use C++ exception handling.
2415         * riscv-tdep.c: Use C++ exception handling.
2416         * remote.c: Use C++ exception handling.
2417         * remote-fileio.c: Use C++ exception handling.
2418         * record-full.c: Use C++ exception handling.
2419         * record-btrace.c: Use C++ exception handling.
2420         * python/python.c: Use C++ exception handling.
2421         * python/py-value.c: Use C++ exception handling.
2422         * python/py-utils.c: Use C++ exception handling.
2423         * python/py-unwind.c: Use C++ exception handling.
2424         * python/py-type.c: Use C++ exception handling.
2425         * python/py-symbol.c: Use C++ exception handling.
2426         * python/py-record.c: Use C++ exception handling.
2427         * python/py-record-btrace.c: Use C++ exception handling.
2428         * python/py-progspace.c: Use C++ exception handling.
2429         * python/py-prettyprint.c: Use C++ exception handling.
2430         * python/py-param.c: Use C++ exception handling.
2431         * python/py-objfile.c: Use C++ exception handling.
2432         * python/py-linetable.c: Use C++ exception handling.
2433         * python/py-lazy-string.c: Use C++ exception handling.
2434         * python/py-infthread.c: Use C++ exception handling.
2435         * python/py-inferior.c: Use C++ exception handling.
2436         * python/py-gdb-readline.c: Use C++ exception handling.
2437         * python/py-framefilter.c: Use C++ exception handling.
2438         * python/py-frame.c: Use C++ exception handling.
2439         * python/py-finishbreakpoint.c: Use C++ exception handling.
2440         * python/py-cmd.c: Use C++ exception handling.
2441         * python/py-breakpoint.c: Use C++ exception handling.
2442         * python/py-arch.c: Use C++ exception handling.
2443         * printcmd.c: Use C++ exception handling.
2444         * ppc-linux-tdep.c: Use C++ exception handling.
2445         * parse.c: Use C++ exception handling.
2446         * p-valprint.c: Use C++ exception handling.
2447         * objc-lang.c: Use C++ exception handling.
2448         * mi/mi-main.c: Use C++ exception handling.
2449         * mi/mi-interp.c: Use C++ exception handling.
2450         * mi/mi-cmd-stack.c: Use C++ exception handling.
2451         * mi/mi-cmd-break.c: Use C++ exception handling.
2452         * main.c: Use C++ exception handling.
2453         * linux-thread-db.c: Use C++ exception handling.
2454         * linux-tdep.c: Use C++ exception handling.
2455         * linux-nat.c: Use C++ exception handling.
2456         * linux-fork.c: Use C++ exception handling.
2457         * linespec.c: Use C++ exception handling.
2458         * language.c: Use C++ exception handling.
2459         * jit.c: Use C++ exception handling.
2460         * infrun.c: Use C++ exception handling.
2461         * infcmd.c: Use C++ exception handling.
2462         * infcall.c: Use C++ exception handling.
2463         * inf-loop.c: Use C++ exception handling.
2464         * i386-tdep.c: Use C++ exception handling.
2465         * i386-linux-tdep.c: Use C++ exception handling.
2466         * guile/scm-value.c: Use C++ exception handling.
2467         * guile/scm-type.c: Use C++ exception handling.
2468         * guile/scm-symtab.c: Use C++ exception handling.
2469         * guile/scm-symbol.c: Use C++ exception handling.
2470         * guile/scm-pretty-print.c: Use C++ exception handling.
2471         * guile/scm-ports.c: Use C++ exception handling.
2472         * guile/scm-param.c: Use C++ exception handling.
2473         * guile/scm-math.c: Use C++ exception handling.
2474         * guile/scm-lazy-string.c: Use C++ exception handling.
2475         * guile/scm-frame.c: Use C++ exception handling.
2476         * guile/scm-disasm.c: Use C++ exception handling.
2477         * guile/scm-cmd.c: Use C++ exception handling.
2478         * guile/scm-breakpoint.c: Use C++ exception handling.
2479         * guile/scm-block.c: Use C++ exception handling.
2480         * guile/guile-internal.h: Use C++ exception handling.
2481         * gnu-v3-abi.c: Use C++ exception handling.
2482         * gdbtypes.c: Use C++ exception handling.
2483         * frame.c: Use C++ exception handling.
2484         * frame-unwind.c: Use C++ exception handling.
2485         * fbsd-tdep.c: Use C++ exception handling.
2486         * f-valprint.c: Use C++ exception handling.
2487         * exec.c: Use C++ exception handling.
2488         * event-top.c: Use C++ exception handling.
2489         * event-loop.c: Use C++ exception handling.
2490         * eval.c: Use C++ exception handling.
2491         * dwarf2read.c: Use C++ exception handling.
2492         * dwarf2loc.c: Use C++ exception handling.
2493         * dwarf2-frame.c: Use C++ exception handling.
2494         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2495         * dwarf-index-write.c: Use C++ exception handling.
2496         * dwarf-index-cache.c: Use C++ exception handling.
2497         * dtrace-probe.c: Use C++ exception handling.
2498         * disasm-selftests.c: Use C++ exception handling.
2499         * darwin-nat.c: Use C++ exception handling.
2500         * cp-valprint.c: Use C++ exception handling.
2501         * cp-support.c: Use C++ exception handling.
2502         * cp-abi.c: Use C++ exception handling.
2503         * corelow.c: Use C++ exception handling.
2504         * completer.c: Use C++ exception handling.
2505         * compile/compile-object-run.c: Use C++ exception handling.
2506         * compile/compile-object-load.c: Use C++ exception handling.
2507         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2508         * compile/compile-c-symbols.c: Use C++ exception handling.
2509         * common/selftest.c: Use C++ exception handling.
2510         * common/new-op.c: Use C++ exception handling.
2511         * cli/cli-script.c: Use C++ exception handling.
2512         * cli/cli-interp.c: Use C++ exception handling.
2513         * cli/cli-cmds.c: Use C++ exception handling.
2514         * c-varobj.c: Use C++ exception handling.
2515         * btrace.c: Use C++ exception handling.
2516         * breakpoint.c: Use C++ exception handling.
2517         * break-catch-throw.c: Use C++ exception handling.
2518         * arch-utils.c: Use C++ exception handling.
2519         * amd64-tdep.c: Use C++ exception handling.
2520         * ada-valprint.c: Use C++ exception handling.
2521         * ada-typeprint.c: Use C++ exception handling.
2522         * ada-lang.c: Use C++ exception handling.
2523         * aarch64-tdep.c: Use C++ exception handling.
2524
2525 2019-04-08  Tom Tromey  <tom@tromey.com>
2526
2527         * xml-support.c (gdb_xml_parser::parse): Update.
2528         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2529         * value.c (show_convenience): Update.
2530         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2531         (test_parse_flags_qcs): Update.
2532         * thread.c (thr_try_catch_cmd): Update.
2533         * target.c (target_translate_tls_address): Update.
2534         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2535         (info_frame_command_core, frame_apply_command_count): Update.
2536         * rust-exp.y (rust_lex_exception_test): Update.
2537         * riscv-tdep.c (riscv_print_one_register_info): Update.
2538         * remote.c (remote_target::enable_btrace): Update.
2539         * record-btrace.c (record_btrace_enable_warn): Update.
2540         * python/py-utils.c (gdbpy_convert_exception): Update.
2541         * printcmd.c (do_one_display, print_variable_and_value): Update.
2542         * mi/mi-main.c (mi_print_exception): Update.
2543         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2544         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2545         * linux-nat.c (linux_nat_target::attach): Update.
2546         * linux-fork.c (class scoped_switch_fork_info): Update.
2547         * infrun.c (displaced_step_prepare): Update.
2548         * infcall.c (call_function_by_hand_dummy): Update.
2549         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2550         * gnu-v3-abi.c (print_one_vtable): Update.
2551         * frame.c (get_prev_frame_always): Update.
2552         * f-valprint.c (info_common_command_for_block): Update.
2553         * exec.c (try_open_exec_file): Update.
2554         * exceptions.c (print_exception, exception_print)
2555         (exception_fprintf, exception_print_same): Update.
2556         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2557         * dwarf-index-cache.c (index_cache::store)
2558         (index_cache::lookup_gdb_index): Update.
2559         * darwin-nat.c (maybe_cache_shell): Update.
2560         * cp-valprint.c (cp_print_value_fields): Update.
2561         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2562         (gcc_cplus_symbol_address): Update.
2563         * compile/compile-c-symbols.c (gcc_convert_symbol)
2564         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2565         * common/selftest.c: Update.
2566         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2567         a std::string.
2568         (exception_try_scope_entry, exception_try_scope_exit): Don't
2569         declare.
2570         (struct exception_try_scope): Remove.
2571         (TRY): Don't use exception_try_scope.
2572         (struct gdb_exception): Add constructor, operator=.
2573         <what>: New method.
2574         (struct gdb_exception_RETURN_MASK_ALL)
2575         (struct gdb_exception_RETURN_MASK_ERROR)
2576         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2577         (struct gdb_quit_bad_alloc): Update.
2578         * common/common-exceptions.c (exception_none): Change
2579         initializer.
2580         (struct catcher) <state, exception>: Initialize inline.
2581         <prev>: Remove member.
2582         (current_catcher): Remove.
2583         (catchers): New global.
2584         (exceptions_state_mc_init): Simplify.
2585         (catcher_pop): Remove.
2586         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2587         (try_scope_depth, exception_try_scope_entry)
2588         (exception_try_scope_exit): Remove.
2589         (throw_exception_sjlj): Update.
2590         (exception_messages, exception_messages_size): Remove.
2591         (throw_it): Simplify.
2592         (gdb_exception_sliced_copy): Remove.
2593         (throw_exception_cxx): Update.
2594         * cli/cli-script.c (script_from_file): Update.
2595         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2596         Update.
2597         * ada-valprint.c (ada_val_print): Update.
2598         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2599         (create_excep_cond_exprs): Update.
2600
2601 2019-04-08  Tom Tromey  <tom@tromey.com>
2602
2603         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2604         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2605         (TRY, CATCH, END_CATCH): Remove some definitions.
2606         * common/common-exceptions.c: Don't use GDB_XCPT.
2607         (catcher_list_size): Remove.
2608         (throw_exception, throw_it): Simplify.
2609
2610 2019-04-05  Tom Tromey  <tom@tromey.com>
2611
2612         Revert the header-sorting patch.
2613         * ft32-tdep.c: Revert.
2614         * frv-tdep.c: Revert.
2615         * frv-linux-tdep.c: Revert.
2616         * frame.c: Revert.
2617         * frame-unwind.c: Revert.
2618         * frame-base.c: Revert.
2619         * fork-child.c: Revert.
2620         * findvar.c: Revert.
2621         * findcmd.c: Revert.
2622         * filesystem.c: Revert.
2623         * filename-seen-cache.h: Revert.
2624         * filename-seen-cache.c: Revert.
2625         * fbsd-tdep.c: Revert.
2626         * fbsd-nat.h: Revert.
2627         * fbsd-nat.c: Revert.
2628         * f-valprint.c: Revert.
2629         * f-typeprint.c: Revert.
2630         * f-lang.c: Revert.
2631         * extension.h: Revert.
2632         * extension.c: Revert.
2633         * extension-priv.h: Revert.
2634         * expprint.c: Revert.
2635         * exec.h: Revert.
2636         * exec.c: Revert.
2637         * exceptions.c: Revert.
2638         * event-top.c: Revert.
2639         * event-loop.c: Revert.
2640         * eval.c: Revert.
2641         * elfread.c: Revert.
2642         * dwarf2read.h: Revert.
2643         * dwarf2read.c: Revert.
2644         * dwarf2loc.c: Revert.
2645         * dwarf2expr.h: Revert.
2646         * dwarf2expr.c: Revert.
2647         * dwarf2-frame.c: Revert.
2648         * dwarf2-frame-tailcall.c: Revert.
2649         * dwarf-index-write.h: Revert.
2650         * dwarf-index-write.c: Revert.
2651         * dwarf-index-common.c: Revert.
2652         * dwarf-index-cache.h: Revert.
2653         * dwarf-index-cache.c: Revert.
2654         * dummy-frame.c: Revert.
2655         * dtrace-probe.c: Revert.
2656         * disasm.h: Revert.
2657         * disasm.c: Revert.
2658         * disasm-selftests.c: Revert.
2659         * dictionary.c: Revert.
2660         * dicos-tdep.c: Revert.
2661         * demangle.c: Revert.
2662         * dcache.h: Revert.
2663         * dcache.c: Revert.
2664         * darwin-nat.h: Revert.
2665         * darwin-nat.c: Revert.
2666         * darwin-nat-info.c: Revert.
2667         * d-valprint.c: Revert.
2668         * d-namespace.c: Revert.
2669         * d-lang.c: Revert.
2670         * ctf.c: Revert.
2671         * csky-tdep.c: Revert.
2672         * csky-linux-tdep.c: Revert.
2673         * cris-tdep.c: Revert.
2674         * cris-linux-tdep.c: Revert.
2675         * cp-valprint.c: Revert.
2676         * cp-support.c: Revert.
2677         * cp-namespace.c: Revert.
2678         * cp-abi.c: Revert.
2679         * corelow.c: Revert.
2680         * corefile.c: Revert.
2681         * continuations.c: Revert.
2682         * completer.h: Revert.
2683         * completer.c: Revert.
2684         * complaints.c: Revert.
2685         * coffread.c: Revert.
2686         * coff-pe-read.c: Revert.
2687         * cli-out.h: Revert.
2688         * cli-out.c: Revert.
2689         * charset.c: Revert.
2690         * c-varobj.c: Revert.
2691         * c-valprint.c: Revert.
2692         * c-typeprint.c: Revert.
2693         * c-lang.c: Revert.
2694         * buildsym.c: Revert.
2695         * buildsym-legacy.c: Revert.
2696         * build-id.h: Revert.
2697         * build-id.c: Revert.
2698         * btrace.c: Revert.
2699         * bsd-uthread.c: Revert.
2700         * breakpoint.h: Revert.
2701         * breakpoint.c: Revert.
2702         * break-catch-throw.c: Revert.
2703         * break-catch-syscall.c: Revert.
2704         * break-catch-sig.c: Revert.
2705         * blockframe.c: Revert.
2706         * block.c: Revert.
2707         * bfin-tdep.c: Revert.
2708         * bfin-linux-tdep.c: Revert.
2709         * bfd-target.c: Revert.
2710         * bcache.c: Revert.
2711         * ax-general.c: Revert.
2712         * ax-gdb.h: Revert.
2713         * ax-gdb.c: Revert.
2714         * avr-tdep.c: Revert.
2715         * auxv.c: Revert.
2716         * auto-load.c: Revert.
2717         * arm-wince-tdep.c: Revert.
2718         * arm-tdep.c: Revert.
2719         * arm-symbian-tdep.c: Revert.
2720         * arm-pikeos-tdep.c: Revert.
2721         * arm-obsd-tdep.c: Revert.
2722         * arm-nbsd-tdep.c: Revert.
2723         * arm-nbsd-nat.c: Revert.
2724         * arm-linux-tdep.c: Revert.
2725         * arm-linux-nat.c: Revert.
2726         * arm-fbsd-tdep.c: Revert.
2727         * arm-fbsd-nat.c: Revert.
2728         * arm-bsd-tdep.c: Revert.
2729         * arch-utils.c: Revert.
2730         * arc-tdep.c: Revert.
2731         * arc-newlib-tdep.c: Revert.
2732         * annotate.h: Revert.
2733         * annotate.c: Revert.
2734         * amd64-windows-tdep.c: Revert.
2735         * amd64-windows-nat.c: Revert.
2736         * amd64-tdep.c: Revert.
2737         * amd64-sol2-tdep.c: Revert.
2738         * amd64-obsd-tdep.c: Revert.
2739         * amd64-obsd-nat.c: Revert.
2740         * amd64-nbsd-tdep.c: Revert.
2741         * amd64-nbsd-nat.c: Revert.
2742         * amd64-nat.c: Revert.
2743         * amd64-linux-tdep.c: Revert.
2744         * amd64-linux-nat.c: Revert.
2745         * amd64-fbsd-tdep.c: Revert.
2746         * amd64-fbsd-nat.c: Revert.
2747         * amd64-dicos-tdep.c: Revert.
2748         * amd64-darwin-tdep.c: Revert.
2749         * amd64-bsd-nat.c: Revert.
2750         * alpha-tdep.c: Revert.
2751         * alpha-obsd-tdep.c: Revert.
2752         * alpha-nbsd-tdep.c: Revert.
2753         * alpha-mdebug-tdep.c: Revert.
2754         * alpha-linux-tdep.c: Revert.
2755         * alpha-linux-nat.c: Revert.
2756         * alpha-bsd-tdep.c: Revert.
2757         * alpha-bsd-nat.c: Revert.
2758         * aix-thread.c: Revert.
2759         * agent.c: Revert.
2760         * addrmap.c: Revert.
2761         * ada-varobj.c: Revert.
2762         * ada-valprint.c: Revert.
2763         * ada-typeprint.c: Revert.
2764         * ada-tasks.c: Revert.
2765         * ada-lang.c: Revert.
2766         * aarch64-tdep.c: Revert.
2767         * aarch64-ravenscar-thread.c: Revert.
2768         * aarch64-newlib-tdep.c: Revert.
2769         * aarch64-linux-tdep.c: Revert.
2770         * aarch64-linux-nat.c: Revert.
2771         * aarch64-fbsd-tdep.c: Revert.
2772         * aarch64-fbsd-nat.c: Revert.
2773         * aarch32-linux-nat.c: Revert.
2774
2775 2019-04-05  Tom Tromey  <tom@tromey.com>
2776
2777         * ft32-tdep.c: Sort headers.
2778         * frv-tdep.c: Sort headers.
2779         * frv-linux-tdep.c: Sort headers.
2780         * frame.c: Sort headers.
2781         * frame-unwind.c: Sort headers.
2782         * frame-base.c: Sort headers.
2783         * fork-child.c: Sort headers.
2784         * findvar.c: Sort headers.
2785         * findcmd.c: Sort headers.
2786         * filesystem.c: Sort headers.
2787         * filename-seen-cache.h: Sort headers.
2788         * filename-seen-cache.c: Sort headers.
2789         * fbsd-tdep.c: Sort headers.
2790         * fbsd-nat.h: Sort headers.
2791         * fbsd-nat.c: Sort headers.
2792         * f-valprint.c: Sort headers.
2793         * f-typeprint.c: Sort headers.
2794         * f-lang.c: Sort headers.
2795         * extension.h: Sort headers.
2796         * extension.c: Sort headers.
2797         * extension-priv.h: Sort headers.
2798         * expprint.c: Sort headers.
2799         * exec.h: Sort headers.
2800         * exec.c: Sort headers.
2801         * exceptions.c: Sort headers.
2802         * event-top.c: Sort headers.
2803         * event-loop.c: Sort headers.
2804         * eval.c: Sort headers.
2805         * elfread.c: Sort headers.
2806         * dwarf2read.h: Sort headers.
2807         * dwarf2read.c: Sort headers.
2808         * dwarf2loc.c: Sort headers.
2809         * dwarf2expr.h: Sort headers.
2810         * dwarf2expr.c: Sort headers.
2811         * dwarf2-frame.c: Sort headers.
2812         * dwarf2-frame-tailcall.c: Sort headers.
2813         * dwarf-index-write.h: Sort headers.
2814         * dwarf-index-write.c: Sort headers.
2815         * dwarf-index-common.c: Sort headers.
2816         * dwarf-index-cache.h: Sort headers.
2817         * dwarf-index-cache.c: Sort headers.
2818         * dummy-frame.c: Sort headers.
2819         * dtrace-probe.c: Sort headers.
2820         * disasm.h: Sort headers.
2821         * disasm.c: Sort headers.
2822         * disasm-selftests.c: Sort headers.
2823         * dictionary.c: Sort headers.
2824         * dicos-tdep.c: Sort headers.
2825         * demangle.c: Sort headers.
2826         * dcache.h: Sort headers.
2827         * dcache.c: Sort headers.
2828         * darwin-nat.h: Sort headers.
2829         * darwin-nat.c: Sort headers.
2830         * darwin-nat-info.c: Sort headers.
2831         * d-valprint.c: Sort headers.
2832         * d-namespace.c: Sort headers.
2833         * d-lang.c: Sort headers.
2834         * ctf.c: Sort headers.
2835         * csky-tdep.c: Sort headers.
2836         * csky-linux-tdep.c: Sort headers.
2837         * cris-tdep.c: Sort headers.
2838         * cris-linux-tdep.c: Sort headers.
2839         * cp-valprint.c: Sort headers.
2840         * cp-support.c: Sort headers.
2841         * cp-namespace.c: Sort headers.
2842         * cp-abi.c: Sort headers.
2843         * corelow.c: Sort headers.
2844         * corefile.c: Sort headers.
2845         * continuations.c: Sort headers.
2846         * completer.h: Sort headers.
2847         * completer.c: Sort headers.
2848         * complaints.c: Sort headers.
2849         * coffread.c: Sort headers.
2850         * coff-pe-read.c: Sort headers.
2851         * cli-out.h: Sort headers.
2852         * cli-out.c: Sort headers.
2853         * charset.c: Sort headers.
2854         * c-varobj.c: Sort headers.
2855         * c-valprint.c: Sort headers.
2856         * c-typeprint.c: Sort headers.
2857         * c-lang.c: Sort headers.
2858         * buildsym.c: Sort headers.
2859         * buildsym-legacy.c: Sort headers.
2860         * build-id.h: Sort headers.
2861         * build-id.c: Sort headers.
2862         * btrace.c: Sort headers.
2863         * bsd-uthread.c: Sort headers.
2864         * breakpoint.h: Sort headers.
2865         * breakpoint.c: Sort headers.
2866         * break-catch-throw.c: Sort headers.
2867         * break-catch-syscall.c: Sort headers.
2868         * break-catch-sig.c: Sort headers.
2869         * blockframe.c: Sort headers.
2870         * block.c: Sort headers.
2871         * bfin-tdep.c: Sort headers.
2872         * bfin-linux-tdep.c: Sort headers.
2873         * bfd-target.c: Sort headers.
2874         * bcache.c: Sort headers.
2875         * ax-general.c: Sort headers.
2876         * ax-gdb.h: Sort headers.
2877         * ax-gdb.c: Sort headers.
2878         * avr-tdep.c: Sort headers.
2879         * auxv.c: Sort headers.
2880         * auto-load.c: Sort headers.
2881         * arm-wince-tdep.c: Sort headers.
2882         * arm-tdep.c: Sort headers.
2883         * arm-symbian-tdep.c: Sort headers.
2884         * arm-pikeos-tdep.c: Sort headers.
2885         * arm-obsd-tdep.c: Sort headers.
2886         * arm-nbsd-tdep.c: Sort headers.
2887         * arm-nbsd-nat.c: Sort headers.
2888         * arm-linux-tdep.c: Sort headers.
2889         * arm-linux-nat.c: Sort headers.
2890         * arm-fbsd-tdep.c: Sort headers.
2891         * arm-fbsd-nat.c: Sort headers.
2892         * arm-bsd-tdep.c: Sort headers.
2893         * arch-utils.c: Sort headers.
2894         * arc-tdep.c: Sort headers.
2895         * arc-newlib-tdep.c: Sort headers.
2896         * annotate.h: Sort headers.
2897         * annotate.c: Sort headers.
2898         * amd64-windows-tdep.c: Sort headers.
2899         * amd64-windows-nat.c: Sort headers.
2900         * amd64-tdep.c: Sort headers.
2901         * amd64-sol2-tdep.c: Sort headers.
2902         * amd64-obsd-tdep.c: Sort headers.
2903         * amd64-obsd-nat.c: Sort headers.
2904         * amd64-nbsd-tdep.c: Sort headers.
2905         * amd64-nbsd-nat.c: Sort headers.
2906         * amd64-nat.c: Sort headers.
2907         * amd64-linux-tdep.c: Sort headers.
2908         * amd64-linux-nat.c: Sort headers.
2909         * amd64-fbsd-tdep.c: Sort headers.
2910         * amd64-fbsd-nat.c: Sort headers.
2911         * amd64-dicos-tdep.c: Sort headers.
2912         * amd64-darwin-tdep.c: Sort headers.
2913         * amd64-bsd-nat.c: Sort headers.
2914         * alpha-tdep.c: Sort headers.
2915         * alpha-obsd-tdep.c: Sort headers.
2916         * alpha-nbsd-tdep.c: Sort headers.
2917         * alpha-mdebug-tdep.c: Sort headers.
2918         * alpha-linux-tdep.c: Sort headers.
2919         * alpha-linux-nat.c: Sort headers.
2920         * alpha-bsd-tdep.c: Sort headers.
2921         * alpha-bsd-nat.c: Sort headers.
2922         * aix-thread.c: Sort headers.
2923         * agent.c: Sort headers.
2924         * addrmap.c: Sort headers.
2925         * ada-varobj.c: Sort headers.
2926         * ada-valprint.c: Sort headers.
2927         * ada-typeprint.c: Sort headers.
2928         * ada-tasks.c: Sort headers.
2929         * ada-lang.c: Sort headers.
2930         * aarch64-tdep.c: Sort headers.
2931         * aarch64-ravenscar-thread.c: Sort headers.
2932         * aarch64-newlib-tdep.c: Sort headers.
2933         * aarch64-linux-tdep.c: Sort headers.
2934         * aarch64-linux-nat.c: Sort headers.
2935         * aarch64-fbsd-tdep.c: Sort headers.
2936         * aarch64-fbsd-nat.c: Sort headers.
2937         * aarch32-linux-nat.c: Sort headers.
2938
2939 2019-04-04  Tom Tromey  <tom@tromey.com>
2940
2941         * varobj.c (varobj_create): Update.
2942         * rust-exp.y (struct rust_parser) <update_innermost_block,
2943         lookup_symbol>: New methods.
2944         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2945         Rename.
2946         (rust_parser::rust_lookup_type)
2947         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2948         * printcmd.c (display_command, do_one_display): Update.
2949         * parser-defs.h (struct parser_state) <parser_state>: Add
2950         "tracker" parameter.
2951         (block_tracker): New member.
2952         (class innermost_block_tracker) <innermost_block_tracker>: Add
2953         "types" parameter.
2954         <reset>: Remove method.
2955         (innermost_block): Don't declare.
2956         (null_post_parser): Update.
2957         * parse.c (innermost_block): Remove global.
2958         (write_dollar_variable): Update.
2959         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2960         Remove "tracker_types" parameter.
2961         (parse_expression): Add "tracker" parameter.
2962         (parse_expression_for_completion): Update.
2963         (null_post_parser): Add "tracker" parameter.
2964         * p-exp.y: Update rules.
2965         * m2-exp.y: Update rules.
2966         * language.h (struct language_defn) <la_post_parser>: Add
2967         "tracker" parameter.
2968         * go-exp.y: Update rules.
2969         * f-exp.y: Update rules.
2970         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2971         parameter.
2972         * d-exp.y: Update rules.
2973         * c-exp.y: Update rules.
2974         * breakpoint.c (set_breakpoint_condition): Create an
2975         innermost_block_tracker.
2976         (watch_command_1): Likewise.
2977         * ada-lang.c (resolve): Add "tracker" parameter.
2978         (resolve_subexp): Likewise.
2979         * ada-exp.y (write_var_from_sym): Update.
2980
2981 2019-04-04  Tom Tromey  <tom@tromey.com>
2982
2983         * type-stack.h: New file.
2984         * type-stack.c: New file.
2985         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2986         type-stack.h.
2987         (insert_into_type_stack, insert_type, push_type, push_type_int)
2988         (insert_type_address_space, pop_type, pop_type_int)
2989         (pop_typelist, pop_type_stack, append_type_stack)
2990         (push_type_stack, get_type_stack, push_typelist)
2991         (follow_type_instance_flags, follow_types): Don't declare.
2992         * parse.c (type_stack): Remove global.
2993         (parse_exp_in_context): Update.
2994         (insert_into_type_stack, insert_type, push_type, push_type_int)
2995         (insert_type_address_space, pop_type, pop_type_int)
2996         (pop_typelist, pop_type_stack, append_type_stack)
2997         (push_type_stack, get_type_stack, push_typelist)
2998         (follow_type_instance_flags, follow_types): Remove (moved to
2999         type-stack.c).
3000         * f-exp.y (type_stack): New global.
3001         Update rules.
3002         (push_kind_type, f_parse): Update.
3003         * d-exp.y (type_stack): New global.
3004         Update rules.
3005         (d_parse): Update.
3006         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3007         Update rules.
3008         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3009         (HFILES_NO_SRCDIR): Add type-stack.h.
3010
3011 2019-04-04  Tom Tromey  <tom@tromey.com>
3012
3013         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3014         (rust_parser::convert_ast_to_expression, rust_parse)
3015         (rust_lex_test_completion, rust_lex_tests): Update.
3016         * parser-defs.h (struct expr_completion_state): New.
3017         (struct parser_state) <parser_state>: Add completion parameter.
3018         <mark_struct_expression, mark_completion_tag>: New methods.
3019         <parse_completion, m_completion_state>: New members.
3020         (prefixify_expression, null_post_parser): Update.
3021         (mark_struct_expression, mark_completion_tag): Don't declare.
3022         * parse.c (parse_completion, expout_last_struct)
3023         (expout_tag_completion_type, expout_completion_name): Remove
3024         globals.
3025         (parser_state::mark_struct_expression)
3026         (parser_state::mark_completion_tag): Now methods.
3027         (prefixify_expression): Add last_struct parameter.
3028         (prefixify_subexp): Likewise.
3029         (parse_exp_1): Update.
3030         (parse_exp_in_context): Add cstate parameter.  Update.
3031         (parse_expression_for_completion): Create an
3032         expr_completion_state.
3033         (null_post_parser): Add "completion" parameter.
3034         * p-exp.y: Update rules.
3035         (yylex): Update.
3036         * language.h (struct language_defn) <la_post_parser>: Add
3037         "completing" parameter.
3038         * go-exp.y: Update rules.
3039         (lex_one_token): Update.
3040         * expression.h (parse_completion): Don't declare.
3041         * d-exp.y: Update rules.
3042         (lex_one_token): Update rules.
3043         * c-exp.y: Update rules.
3044         (lex_one_token): Update.
3045         * ada-lang.c (resolve): Add "parse_completion" parameter.
3046         (resolve_subexp): Likewise.
3047         (ada_resolve_function): Likewise.
3048
3049 2019-04-04  Tom Tromey  <tom@tromey.com>
3050
3051         * parser-defs.h (struct parser_state) <start_arglist,
3052         end_arglist>: New methods.
3053         <arglist_len, m_funcall_chain>: New members.
3054         (arglist_len, start_arglist, end_arglist): Don't declare.
3055         * parse.c (arglist_len, funcall_chain): Remove global.
3056         (start_arglist, end_arglist): Remove functions.
3057         (parse_exp_in_context): Update.
3058         * p-exp.y: Update rules.
3059         * m2-exp.y: Update rules.
3060         * go-exp.y: Update rules.
3061         * f-exp.y: Update rules.
3062         * d-exp.y: Update rules.
3063         * c-exp.y: Update rules.
3064
3065 2019-04-04  Tom Tromey  <tom@tromey.com>
3066
3067         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3068         lex_operator, push_back>: New methods.
3069         Update all rules.
3070         (rust_parser::lex_hex, lex_escape): Rename and update.
3071         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3072         (rust_parser::lex_operator): Rename and update.
3073         (rust_parser::lex_number, rustyylex, rustyyerror)
3074         (rust_lex_test_init, rust_lex_test_sequence)
3075         (rust_lex_test_push_back, rust_lex_tests): Update.
3076         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3077         parameter.
3078         <lexptr, prev_lexptr>: New members.
3079         (lexptr, prev_lexptr): Don't declare.
3080         * parse.c (lexptr, prev_lexptr): Remove globals.
3081         (parse_exp_in_context): Update.
3082         * p-exp.y (yylex, yyerror): Update.
3083         * m2-exp.y (parse_number, yylex, yyerror): Update.
3084         * go-exp.y (lex_one_token, yyerror): Update.
3085         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3086         * d-exp.y (lex_one_token, yyerror): Update.
3087         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3088         (lex_one_token, yyerror): Update.
3089         * ada-lex.l (YY_INPUT): Update.
3090         (rewind_to_char): Update.
3091         * ada-exp.y (yyerror): Update.
3092
3093 2019-04-04  Tom Tromey  <tom@tromey.com>
3094
3095         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3096         * parser-defs.h (struct parser_state) <parser_state>: Add new
3097         parameter.
3098         <comma_terminates>: New member.
3099         (comma_terminates): Don't declare global.
3100         * parse.c (comma_terminates): Remove global.
3101         (parse_exp_in_context): Update.
3102         * p-exp.y (yylex): Update.
3103         * m2-exp.y (yylex): Update.
3104         * go-exp.y (lex_one_token): Update.
3105         * f-exp.y (yylex): Update.
3106         * d-exp.y (lex_one_token): Update.
3107         * c-exp.y (lex_one_token): Update.
3108         * ada-lex.l: Update.
3109
3110 2019-04-04  Tom Tromey  <tom@tromey.com>
3111
3112         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3113         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3114         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3115         * parser-defs.h (paren_depth): Don't declare.
3116         * parse.c (paren_depth): Remove global.
3117         (parse_exp_in_context): Update.
3118         * p-exp.y (paren_depth): New global.
3119         (pascal_parse): Initialize it.
3120         * m2-exp.y (paren_depth): New global.
3121         (m2_parse): Initialize it.
3122         * go-exp.y (paren_depth): New global.
3123         (go_parse): Initialize it.
3124         * f-exp.y (paren_depth): New global.
3125         (f_parse): Initialize it.
3126         * d-exp.y (paren_depth): New global.
3127         (d_parse): Initialize it.
3128         * c-exp.y (paren_depth): New global.
3129         (c_parse): Initialize it.
3130         * ada-lex.l (paren_depth): New global.
3131         (lexer_init): Initialize it.
3132
3133 2019-04-04  Tom Tromey  <tom@tromey.com>
3134
3135         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3136         (rust_parser::convert_ast_to_type)
3137         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3138         * parser-defs.h (struct parser_state) <parser_state>: Add
3139         parameters.  Initialize new members.
3140         <expression_context_block, expression_context_pc>: New members.
3141         * parse.c (expression_context_block, expression_context_pc):
3142         Remove globals.
3143         (parse_exp_in_context): Update.
3144         * p-exp.y: Update all rules.
3145         (yylex): Update.
3146         * m2-exp.y: Update all rules.
3147         (yylex): Update.
3148         * go-exp.y (yylex): Update.
3149         * f-exp.y (yylex): Update.
3150         * d-exp.y: Update all rules.
3151         (yylex): Update.
3152         * c-exp.y: Update all rules.
3153         (lex_one_token, classify_name, yylex, c_parse): Update.
3154         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3155
3156 2019-04-04  Tom Tromey  <tom@tromey.com>
3157
3158         * gdbarch.h, gdbarch.c: Rebuild.
3159         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3160         * stap-probe.h:
3161         (struct stap_parse_info): Replace "parser_state" with
3162         "expr_builder".
3163         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3164         (parser_state): New class.
3165         * parse.c (expr_builder): Rename.
3166         (expr_builder::release): Rename.
3167         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3168         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3169         (write_exp_elt_longcst, write_exp_elt_floatcst)
3170         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3171         (write_exp_string_vector, write_exp_bitstring)
3172         (write_exp_msymbol, mark_struct_expression)
3173         (write_dollar_variable)
3174         (insert_type_address_space, increase_expout_size): Replace
3175         "parser_state" with "expr_builder".
3176         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3177         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3178         "parser_state" with "expr_builder".
3179
3180 2019-04-04  Tom Tromey  <tom@tromey.com>
3181
3182         * rust-exp.y: Replace "parse_language" with method call.
3183         * p-exp.y:
3184         (yylex): Replace "parse_language" with method call.
3185         * m2-exp.y:
3186         (yylex): Replace "parse_language" with method call.
3187         * go-exp.y (classify_name): Replace "parse_language" with method
3188         call.
3189         * f-exp.y (yylex): Replace "parse_language" with method call.
3190         * d-exp.y (lex_one_token): Replace "parse_language" with method
3191         call.
3192         * c-exp.y:
3193         (lex_one_token, classify_name, yylex): Replace "parse_language"
3194         with method call.
3195         * ada-exp.y (find_primitive_type, type_char)
3196         (type_system_address): Replace "parse_language" with method call.
3197
3198 2019-04-04  Tom Tromey  <tom@tromey.com>
3199
3200         * rust-exp.y: Replace "parse_gdbarch" with method call.
3201         * parse.c (write_dollar_variable, insert_type_address_space):
3202         Replace "parse_gdbarch" with method call.
3203         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3204         call.
3205         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3206         call.
3207         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3208         "parse_gdbarch" with method call.
3209         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3210         with method call.
3211         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3212         "parse_gdbarch" with method call.
3213         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3214         "parse_gdbarch" with method call.
3215         * c-exp.y (parse_type, parse_number, classify_name): Replace
3216         "parse_gdbarch" with method call.
3217         * ada-lex.l: Replace "parse_gdbarch" with method call.
3218         * ada-exp.y (parse_type, find_primitive_type, type_char)
3219         (type_system_address): Replace "parse_gdbarch" with method call.
3220
3221 2019-04-04  Tom Tromey  <tom@tromey.com>
3222
3223         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3224         * stap-probe.c (stap_parse_argument): Update.
3225         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3226         initial_size parameter.
3227         * rust-exp.y (rust_lex_tests): Update.
3228         * parse.c (parser_state): Update.
3229         (parse_exp_in_context): Update.
3230         * parser-defs.h (struct parser_state) <parser_state>: Remove
3231         "initial_size" parameter.
3232
3233 2019-04-04  Tom Tromey  <tom@tromey.com>
3234
3235         * parser-defs.h (increase_expout_size): Don't declare.
3236         * parse.c (increase_expout_size): Now static.
3237
3238 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3239
3240         * gnu-nat.c (gnu_nat_target::wait): Fix
3241         target_waitstatus_to_string call.
3242
3243 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * eval.c (evaluate_subexp_standard): Handle internal functions
3246         during Fortran function call handling.
3247
3248 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         * NEWS: Mention new internal functions.
3251         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3252         (read_base_type): Use dwarf2_init_complex_target_type.
3253         * value.c (creal_internal_fn): New function.
3254         (cimag_internal_fn): New function.
3255         (_initialize_values): Register new internal functions.
3256
3257 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3258
3259         * infrun.c (stop_all_threads): If debug_infrun, always
3260         trace the wait status after wait_one, using
3261         target_waitstatus_to_string and target_pid_to_str.
3262         (handle_inferior_event): Replace various trace of
3263         wait status kind by a single trace.
3264         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3265         wait status kind image by target_waitstatus_to_string.
3266         * target/waitstatus.c (target_waitstatus_to_string): Fix
3267         obsolete comment.
3268
3269 2019-04-01  Tom Tromey  <tromey@adacore.com>
3270
3271         PR symtab/23331:
3272         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3273
3274 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3275             Pedro Alves  <palves@redhat.com>
3276
3277         * top.c (quit_force): Call 'finalize_values'.
3278         * value.c (finalize_values): New function.
3279         * value.h (finalize_values): Declare.
3280
3281 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3282
3283         * NEWS: Announce $_gdb_major and $_gdb_minor.
3284
3285         * top.c (init_gdb_version_vars): New function.
3286         (gdb_init): Call init_gdb_version_vars.
3287
3288 2019-03-29  Tom Tromey  <tromey@adacore.com>
3289
3290         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3291         help text.  Remove dead code.
3292
3293 2019-03-29  Keith Seitz  <keiths@redhat.com>
3294
3295         From Siddhesh Poyarekar:
3296         * f-lang.h (f77_get_upperbound): Return LONGEST.
3297         (f77_get_lowerbound): Likewise.
3298         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3299         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3300         print them.
3301         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3302         plongest to format print it.
3303         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3304         (f77_get_upperbound): Likewise.
3305         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3306         LOWER_BOUND to LONGEST.
3307         (f77_create_arrayprint_offset_tbl): Likewise.
3308
3309 2019-03-29  Keith Seitz  <keiths@redhat.com>
3310
3311         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3312         %s/pulongest for TYPE_LENGTH instead of %d in format
3313         strings.
3314         * ada-typerint.c (ada_print_type): Likewise.
3315         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3316         * compile/compile-c-support.c (generate_register_struct): Likewise.
3317         * gdbtypes.c (recursive_dump_type): Likewise.
3318         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3319         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3320         instead of %d in format strings.
3321         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3322         to std::min to ULONGEST.
3323         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3324         instead of %d in format strings.
3325         * tracepoint.c (info_scope_command): Likewise.
3326         * typeprint.c (print_offset_data::update)
3327         (print_offset_data::finish): Likewise.
3328         * xtensa-tdep.c (xtensa_store_return_value)
3329         (xtensa_push_dummy_call): Likewise.
3330
3331 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3332
3333         * windows-nat.c (display_selector): Fixed format specifications
3334         for 64-bit Cygwin.
3335
3336 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3337
3338         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3339
3340 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3341
3342         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3343         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3344         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3345         (nios2_linux_init_abi): Install it.
3346
3347 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3348
3349         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3350
3351 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3352
3353         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3354
3355 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3356             Tom Tromey  <tromey@adacore.com>
3357
3358         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3359
3360 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3361
3362         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3363         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3364         method to compute the bounds of range types. Also print "[evaluated]"
3365         if the bounds' values come from a dynamic evaluation.
3366
3367 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3368
3369         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3370         whitespace when pretty printing is on.
3371
3372 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3373
3374         * ppc-linux-nat.c: Add include.
3375
3376 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3377
3378         * NEWS: Mention AArch64 Pointer Authentication.
3379
3380 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3381
3382         * arm-linux-nat.c: Add include.
3383
3384 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3385
3386         * source-cache.c (source_cache::get_source_lines): Re-read
3387         fullname after calling open_source_file.
3388
3389 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3390
3391         * NEWS: Mention TLS support for FreeBSD.
3392
3393 2019-03-25  Tom Tromey  <tromey@adacore.com>
3394
3395         * minsyms.c (BUNCH_SIZE): Update comment.
3396         (~minimal_symbol_reader): Remove old comment.
3397         (compact_minimal_symbols): Update comment.
3398         (minimal_symbol_reader::install): Remove old comment.  Update
3399         other comments.
3400
3401 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3402
3403         * s390-linux-nat.c: Add include.
3404
3405 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3406
3407         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3408         Call linux_get_hwcap.
3409         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3410         Likewise.
3411         (aarch64_linux_get_hwcap): Remove function.
3412         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3413         declaration.
3414         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3415         linux_get_hwcap.
3416         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3417         * linux-tdep.c (linux_get_hwcap): Add function.
3418         (linux_get_hwcap2): Likewise.
3419         * linux-tdep.h (linux_get_hwcap): Add declaration.
3420         (linux_get_hwcap2): Likewise.
3421         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3422         (ppc_linux_get_hwcap2): Likewise.
3423         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3424         linux_get_hwcap.
3425         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3426         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3427         (ppc_linux_nat_target::read_description): Likewise.
3428         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3429         * s390-linux-nat.c: Likewise.
3430         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3431
3432 2019-03-24  Tom Tromey  <tom@tromey.com>
3433
3434         * ada-lang.c (standard_lookup): Simplify initialization.
3435         (ada_lookup_symbol_nonlocal): Simplify return.
3436         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3437         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3438         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3439         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3440         initialization.
3441         * solib.c (solib_global_lookup): Simplify.
3442         * symtab.c (null_block_symbol): Remove.
3443         (symbol_cache_lookup): Simplify returns.
3444         (lookup_language_this): Simplify returns.
3445         (lookup_symbol_aux): Simplify return.
3446         (lookup_local_symbol): Simplify returns.
3447         (lookup_global_symbol_from_objfile): Simplify return.
3448         (lookup_symbol_in_objfile_symtabs)
3449         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3450         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3451         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3452         * cp-namespace.c (cp_lookup_bare_symbol)
3453         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3454         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3455         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3456         (cp_lookup_symbol_via_imports): Simplify initialization.
3457         (find_symbol_in_baseclass): Likewise.
3458         * symtab.h (null_block_symbol): Remove.
3459         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3460         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3461         (d_lookup_symbol_module): Likewise.
3462         (find_symbol_in_baseclass): Simplify initialization.
3463
3464 2019-03-24  Tom Tromey  <tom@tromey.com>
3465
3466         * expression.h: Don't include symtab.h.
3467         (struct block): Forward declare.
3468
3469 2019-03-24  Tom Tromey  <tom@tromey.com>
3470
3471         * c-exp.y (typebase): Remove casts.
3472         * gdbtypes.c (lookup_unsigned_typename, )
3473         (lookup_signed_typename): Remove cast.
3474         * eval.c (parse_to_comma_and_eval): Remove cast.
3475         * parse.c (write_dollar_variable): Remove cast.
3476         * block.h (struct block) <superblock>: Now const.
3477         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3478         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3479         (map_block): Make "block" const.
3480         * symfile.h (struct quick_symbol_functions)
3481         <map_matching_symbols>: Constify block argument to "callback".
3482         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3483         const.
3484         (find_pc_sect_compunit_symtab): Make "b" const.
3485         (find_symbol_at_address): Likewise.
3486         (search_symbols): Likewise.
3487         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3488         (dw2_debug_names_lookup_symbol): Likewise.
3489         (dw2_map_matching_symbols): Update.
3490         * p-valprint.c (pascal_val_print): Remove "block".
3491         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3492         (aux_add_nonlocal_symbols): Make "block" const.
3493         (resolve_subexp): Remove cast.
3494         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3495         const.
3496         (iterate_over_file_blocks): Likewise.
3497         * f-exp.y (%union) <bval>: Remove.
3498         * coffread.c (patch_opaque_types): Make "b" const.
3499         * spu-tdep.c (spu_catch_start): Make "block" const.
3500         * c-valprint.c (print_unpacked_pointer): Remove "block".
3501         * symmisc.c (dump_symtab_1): Make "b" const.
3502         (block_depth): Make "block" const.
3503         * d-exp.y (%union) <bval>: Remove.
3504         * cp-support.h (cp_lookup_rtti_type): Update.
3505         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3506         * psymtab.c (psym_lookup_symbol): Make "block" const.
3507         (maintenance_check_psymtabs): Make "b" const.
3508         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3509         (enumerate_locals, enumerate_args): Update.
3510         * python/py-symtab.c (stpy_global_block): Make "block" const.
3511         (stpy_static_block): Likewise.
3512         * inline-frame.c (block_starting_point_at): Make "new_block"
3513         const.
3514         * block.c (find_block_in_blockvector): Make return type const.
3515         (blockvector_for_pc_sect): Make "b" const.
3516         (find_block_in_blockvector): Make "b" const.
3517
3518 2019-03-23  Tom Tromey  <tom@tromey.com>
3519
3520         * varobj.c (varobj_create): Update.
3521         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3522         * printcmd.c (display_command, do_one_display): Don't reset
3523         innermost_block.
3524         * parser-defs.h (enum innermost_block_tracker_type): Move to
3525         expression.h.
3526         (innermost_block): Update comment.
3527         * parse.c (parse_exp_1): Add tracker_types parameter.
3528         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3529         tracker_types parameter.  Reset innermost_block.
3530         (parse_exp_in_context): Remove.
3531         (parse_expression_for_completion): Update.
3532         * objfiles.c (~objfile): Don't reset expression_context_block or
3533         innermost_block.
3534         * expression.h (enum innermost_block_tracker_type): Move from
3535         parser-defs.h.
3536         (parse_exp_1): Add tracker_types parameter.
3537         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3538         reset innermost_block.
3539
3540 2019-03-23  Tom Tromey  <tom@tromey.com>
3541
3542         * objfiles.h: Include bcache.h.
3543
3544 2019-03-23  Tom Tromey  <tom@tromey.com>
3545
3546         * linespec.c (get_current_search_block): Use
3547         scoped_restore_current_language.
3548         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3549
3550 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3551             Jiong Wang  <jiong.wang@arm.com>
3552
3553         * aarch64-linux-tdep.c
3554         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3555         section.
3556         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3557
3558 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3559             Jiong Wang  <jiong.wang@arm.com>
3560
3561         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3562         instructions.
3563         (aarch64_analyze_prologue_test): Add PACIASP test.
3564         (aarch64_prologue_prev_register): Unmask PC value.
3565
3566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3567             Jiong Wang  <jiong.wang@arm.com>
3568
3569         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3570         (aarch64_dwarf2_prev_register): Unmask PC value.
3571         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3572         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3573         DW_CFA_AARCH64_negate_ra_state.
3574         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3575
3576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3577             Jiong Wang  <jiong.wang@arm.com>
3578
3579         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3580         registers.
3581         (aarch64_pseudo_register_name): Likewise.
3582         (aarch64_pseudo_register_type): Likewise.
3583         (aarch64_pseudo_register_reggroup_p): Likewise.
3584         (aarch64_gdbarch_init): Add pauth registers.
3585         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3586         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3587         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3588         (struct gdbarch_tdep): Add regnum for ra_state.
3589
3590 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3591             Jiong Wang  <jiong.wang@arm.com>
3592
3593         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3594
3595 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3596             Jiong Wang  <jiong.wang@arm.com>
3597
3598         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3599         function.
3600         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3601         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3602         (aarch64_gdbarch_init): Add puth registers.
3603         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3604         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3605         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3606
3607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3608             Jiong Wang  <jiong.wang@arm.com>
3609
3610         * aarch64-linux-nat.c
3611         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3612         * aarch64-linux-tdep.c
3613         (aarch64_linux_core_read_description): Likewise.
3614         (aarch64_linux_get_hwcap): New function.
3615         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3616         (aarch64_linux_get_hwcap): New declaration.
3617
3618 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3619             Jiong Wang  <jiong.wang@arm.com>
3620
3621         * aarch64-linux-nat.c
3622         (aarch64_linux_nat_target::read_description): Add pauth param.
3623         * aarch64-linux-tdep.c
3624         (aarch64_linux_core_read_description): Likewise.
3625         * aarch64-tdep.c (struct target_desc): Add in pauth.
3626         (aarch64_read_description): Add pauth param.
3627         (aarch64_gdbarch_init): Likewise.
3628         * aarch64-tdep.h (aarch64_read_description): Likewise.
3629         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3630         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3631         * features/Makefile: Add new files.
3632         * features/aarch64-pauth.c: New file.
3633         * features/aarch64-pauth.xml: New file.
3634
3635 2019-03-20  Tom Tromey  <tromey@adacore.com>
3636
3637         * infrun.c (handle_inferior_event): Rename from
3638         handle_inferior_event_1.  Create a scoped_value_mark.
3639         (handle_inferior_event): Remove.
3640
3641 2019-03-19  Tom Tromey  <tromey@adacore.com>
3642
3643         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3644         * infrun.h (print_stop_event): Add "displays" parameter.
3645         * infrun.c (print_stop_event): Add "displays" parameter.
3646
3647 2019-03-19  Pedro Alves  <palves@redhat.com>
3648
3649         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3650         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3651         to -1.  Fix TABs vs spaces.
3652         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3653         * tui/tui-out.h (tui_ui_out) Add intro comments.
3654         <m_line, m_start_of_line>: In-class initialize, and add describing
3655         comment.
3656
3657 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3658
3659         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3660         variable names.
3661         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3662
3663 2019-03-18  Pedro Alves  <palves@redhat.com>
3664             Eli Zaretskii <eliz@gnu.org>
3665
3666         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3667         m_line and m_start_of_line.
3668
3669 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3670
3671         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3672         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3673         it returns a newline.  This fixes a regression in TU mode, whereby
3674         the next line is output on the same screen line as the user input.
3675
3676 2019-03-18  Tom Tromey  <tromey@adacore.com>
3677
3678         * minsyms.c (minimal_symbol_reader::install): Remove call to
3679         obstack_blank.
3680
3681 2019-03-18  Pedro Alves  <palves@redhat.com>
3682
3683         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3684         New globals.
3685         (apply_style): New, factored out from ...
3686         (apply_ansi_escape): ... this.  Handle reverse video mode.
3687         (tui_set_reverse_mode): New function.
3688         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3689         * tui/tui-winsource.c (tui_show_source_line): Use
3690         tui_set_reverse_mode instead of setting A_STANDOUT.
3691         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3692         New setter methods.
3693
3694 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3695
3696         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3697         Handle tabs.
3698
3699 2019-03-18  Tom Tromey  <tromey@adacore.com>
3700
3701         * ada-lang.c (empty_array): Add "high" parameter.
3702         (ada_evaluate_subexp): Update.
3703
3704 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3705
3706         * unittests/string_view-selftests.c: Define
3707         _initialize_string_view_selftests unconditionally.
3708
3709 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3710
3711         PR gdb/24350
3712         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3713
3714 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3715
3716         PR gdb/24351
3717         * windows-nat.c (display_selector): Fix format specifiers.
3718
3719 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3720
3721         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3722         tui_refill_source_window instead of tui_refresh_win, to update the
3723         current execution line.  This fixes redisplay of the current line
3724         when stepping through the code with "next" or "step".
3725
3726 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3727
3728         * source-cache.c (source_cache::get_source_lines): Call
3729         find_source_lines to initialize s->nlines.  This fixes vertical
3730         scrolling of TUI source window when the DOWN arrow is pressed.
3731
3732 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3733
3734         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3735         linux-thread-db.c (_initialize_thread_db): Likewise.
3736
3737 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3738
3739         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3740         wclrtoeol in tui_show_source_line".  This reverts changes made in
3741         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3742
3743 2019-03-15  Tom Tromey  <tom@tromey.com>
3744
3745         * symtab.h (struct minimal_symbol): Derive from
3746         general_symbol_info.
3747         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3748         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3749         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3750         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3751         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3752         (MSYMBOL_SEARCH_NAME): Update.
3753         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3754         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3755         * minsyms.c (minimal_symbol_reader::record_full): Update.
3756
3757 2019-03-15  Tom Tromey  <tom@tromey.com>
3758
3759         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3760
3761 2019-03-15  Tom Tromey  <tom@tromey.com>
3762
3763         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3764         unique_xmalloc_ptr.
3765         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3766         Update.
3767         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3768         (build_minimal_symbol_hash_tables)
3769         (minimal_symbol_reader::install): Update.
3770
3771 2019-03-15  Tom Tromey  <tom@tromey.com>
3772
3773         * symtab.c (create_demangled_names_hash): Update.
3774         (symbol_set_names): Update.
3775         * objfiles.h (struct objfile_per_bfd_storage)
3776         <demangled_names_hash>: Now an htab_up.
3777         * objfiles.c (objfile_per_bfd_storage): Simplify.
3778
3779 2019-03-15  Tom Tromey  <tom@tromey.com>
3780
3781         * objfiles.h (struct objfile_per_bfd_storage): Declare
3782         destructor.
3783         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3784         New.
3785         (get_objfile_bfd_data): Use new.  Don't initialize
3786         language_of_main.
3787         (free_objfile_per_bfd_storage): Remove.
3788         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3789
3790 2019-03-15  Tom Tromey  <tom@tromey.com>
3791
3792         * symfile.c (reread_symbols): Update.
3793         * objfiles.c (objfile::objfile): Update.
3794         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3795         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3796         comment.
3797         (minimal_symbol_reader::install): Update.
3798         (terminate_minimal_symbol_table): Remove.
3799         * jit.c (jit_object_close_impl): Update.
3800
3801 2019-03-15  Tom Tromey  <tom@tromey.com>
3802
3803         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3804         initializations.
3805
3806 2019-03-15  Tom Tromey  <tom@tromey.com>
3807
3808         * objfiles.h (struct objfile_per_bfd_storage)
3809         <demangled_hash_languages>: Now a bitset.
3810         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3811         (lookup_minimal_symbol): Update.
3812
3813 2019-03-15  Tom Tromey  <tom@tromey.com>
3814
3815         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3816         Don't return the symbol.
3817         * coffread.c (record_minimal_symbol): Use record_full.
3818
3819 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3820
3821         The MS-Windows port of ncurses fails to switch to a color pair if
3822         one or both of the colors are the implicit default colors.  This
3823         change records the default colors when TUI is initialized, and
3824         then specifies them explicitly when a color pair uses the default
3825         colors.  This allows color styling in TUI mode on MS-Windows.
3826
3827         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3828         ncurses_norm_attr.
3829         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3830         colors in ncurses_norm_attr.
3831         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3832         "none", replace it with the default color recorded in
3833         ncurses_norm_attr.
3834
3835 2019-03-14  Tom Tromey  <tromey@adacore.com>
3836
3837         * source-cache.h (class source_cache) <get_source_lines>: Return
3838         std::string.
3839         * source-cache.c (source_cache::extract_lines): Handle case where
3840         first_pos==npos.  Return std::string.
3841         (source_cache::get_source_lines): Update.
3842
3843 2019-03-14  Tom Tromey  <tromey@adacore.com>
3844
3845         * NEWS: Add item for "style sources" commands.
3846         * source-cache.c (source_cache::get_source_lines): Check
3847         source_styling.
3848         * cli/cli-style.c (source_styling): New global.
3849         (_initialize_cli_style): Add "style sources" commands.
3850         (show_style_sources): New function.
3851         * cli/cli-style.h (source_styling): Declare.
3852
3853 2019-03-14  Pedro Alves  <palves@redhat.com>
3854             Tom Tromey  <tromey@adacore.com>
3855
3856         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3857         * tui/tui-winsource.c (tui_refill_source_window): New function,
3858         from...
3859         (tui_horizontal_source_scroll): ... here.  Move some logic.
3860         * cli/cli-style.c (set_style_enabled): Notify new observable.
3861         * tui/tui-hooks.c (tui_redisplay_source): New function.
3862         (tui_attach_detach_observers): Attach or detach
3863         tui_redisplay_source.
3864         * observable.h (source_styling_changed): New observable.
3865         * observable.c: Define source_styling_changed observable.
3866
3867 2019-03-13  Tom Tromey  <tromey@adacore.com>
3868
3869         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3870         (i386_gnu_nat_target::store_registers): Update.
3871         * target-debug.h (target_debug_print_std_string): New macro.
3872         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3873         * windows-tdep.c (display_one_tib): Update.
3874         * tui/tui-stack.c (tui_make_status_line): Update.
3875         * top.c (print_inferior_quit_action): Update.
3876         * thread.c (thr_try_catch_cmd): Update.
3877         (add_thread_with_info): Update.
3878         (thread_target_id_str): Update.
3879         (thr_try_catch_cmd): Update.
3880         (thread_command): Update.
3881         (thread_find_command): Update.
3882         * record-btrace.c (record_btrace_target::info_record)
3883         (record_btrace_resume_thread, record_btrace_target::resume)
3884         (record_btrace_cancel_resume, record_btrace_step_thread)
3885         (record_btrace_target::wait, record_btrace_target::wait)
3886         (record_btrace_target::wait, record_btrace_target::stop): Update.
3887         * progspace.c (print_program_space): Update.
3888         * process-stratum-target.c
3889         (process_stratum_target::thread_address_space): Update.
3890         * linux-fork.c (linux_fork_mourn_inferior)
3891         (detach_checkpoint_command, info_checkpoints_command)
3892         (linux_fork_context): Update.
3893         (linux_fork_detach): Update.
3894         (class scoped_switch_fork_info): Update.
3895         (delete_checkpoint_command): Update.
3896         * infrun.c (follow_fork_inferior): Update.
3897         (follow_fork_inferior): Update.
3898         (proceed_after_vfork_done): Update.
3899         (handle_vfork_child_exec_or_exit): Update.
3900         (follow_exec): Update.
3901         (displaced_step_prepare_throw): Update.
3902         (displaced_step_restore): Update.
3903         (start_step_over): Update.
3904         (resume_1): Update.
3905         (clear_proceed_status_thread): Update.
3906         (proceed): Update.
3907         (print_target_wait_results): Update.
3908         (do_target_wait): Update.
3909         (context_switch): Update.
3910         (stop_all_threads): Update.
3911         (restart_threads): Update.
3912         (finish_step_over): Update.
3913         (handle_signal_stop): Update.
3914         (switch_back_to_stepped_thread): Update.
3915         (keep_going_pass_signal): Update.
3916         (print_exited_reason): Update.
3917         (normal_stop): Update.
3918         * inferior.c (inferior_pid_to_str): Change return type.
3919         (print_selected_inferior): Update.
3920         (add_inferior): Update.
3921         (detach_inferior): Update.
3922         * dummy-frame.c (fprint_dummy_frames): Update.
3923         * dcache.c (dcache_info_1): Update.
3924         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3925         (btrace_fetch, btrace_clear): Update.
3926         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3927         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3928         type.
3929         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3930         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3931         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3932         * gdbarch.c, gdbarch.h: Rebuild.
3933         * gdbarch.sh (core_pid_to_str): Change return type.
3934         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3935         return type.
3936         (windows_nat_target::pid_to_str): Change return type.
3937         (windows_delete_thread): Update.
3938         (windows_nat_target::attach): Update.
3939         (windows_nat_target::files_info): Update.
3940         * target-delegates.c: Rebuild.
3941         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3942         return type.
3943         (sol_thread_target::pid_to_str): Change return type.
3944         * remote.c (class remote_target) <pid_to_str>: Change return
3945         type.
3946         (remote_target::pid_to_str): Change return type.
3947         (extended_remote_target::attach, remote_target::remote_stop_ns)
3948         (remote_target::remote_notif_remove_queued_reply)
3949         (remote_target::push_stop_reply, remote_target::disable_btrace):
3950         Update.
3951         (extended_remote_target::attach): Update.
3952         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3953         type.
3954         (gdbsim_target::pid_to_str): Change return type.
3955         * ravenscar-thread.c (struct ravenscar_thread_target)
3956         <pid_to_str>: Change return type.
3957         (ravenscar_thread_target::pid_to_str): Change return type.
3958         * procfs.c (class procfs_target) <pid_to_str>: Change return
3959         type.
3960         (procfs_target::pid_to_str): Change return type.
3961         (procfs_target::attach): Update.
3962         (procfs_target::detach): Update.
3963         (procfs_target::fetch_registers): Update.
3964         (procfs_target::store_registers): Update.
3965         (procfs_target::wait): Update.
3966         (procfs_target::files_info): Update.
3967         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3968         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3969         return type.
3970         (nto_procfs_target::pid_to_str): Change return type.
3971         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3972         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3973         return type.
3974         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3975         (exit_lwp): Update.
3976         (attach_proc_task_lwp_callback, get_detach_signal)
3977         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3978         (linux_nat_target::resume, wait_lwp, stop_callback)
3979         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3980         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3981         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3982         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3983         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3984         type.
3985         (inf_ptrace_target::attach): Update.
3986         (inf_ptrace_target::files_info): Update.
3987         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3988         type.
3989         (go32_nat_target::pid_to_str): Change return type.
3990         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3991         (gnu_nat_target::wait): Update.
3992         (gnu_nat_target::wait): Update.
3993         (gnu_nat_target::resume): Update.
3994         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3995         (fbsd_nat_target::wait): Update.
3996         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3997         type.
3998         (darwin_nat_target::attach): Update.
3999         * corelow.c (class core_target) <pid_to_str>: Change return type.
4000         (core_target::pid_to_str): Change return type.
4001         * target.c (normal_pid_to_str): Change return type.
4002         (default_pid_to_str): Likewise.
4003         (target_pid_to_str): Change return type.
4004         (target_translate_tls_address): Update.
4005         (target_announce_detach): Update.
4006         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4007         return type.
4008         (bsd_uthread_target::pid_to_str): Change return type.
4009         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4010         type.
4011         (bsd_kvm_target::pid_to_str): Change return type.
4012         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4013         return type.
4014         (aix_thread_target::pid_to_str): Change return type.
4015         * target.h (struct target_ops) <pid_to_str>: Change return type.
4016         (target_pid_to_str, normal_pid_to_str): Likewise.
4017         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4018         type.
4019         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4020         type.
4021         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4022         return type.
4023         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4024         type.
4025         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4026         type.
4027         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4028         return type.
4029
4030 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4031
4032         * NEWS: Mention that the new default MI version is 3.  Mention
4033         changes to the output of commands and events that deal with
4034         multi-location breakpoints.
4035         * breakpoint.c: Include "mi/mi-out.h".
4036         (print_one_breakpoint): Change output syntax if using MI version
4037         >= 3.
4038         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4039         New.
4040         (mi_multi_location_breakpoint_output_fixed): New.
4041         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4042         (mi_cmd_fix_multi_location_breakpoint_output): New.
4043         (mi_multi_location_breakpoint_output_fixed): New.
4044         * mi/mi-cmds.c (mi_cmds): Register command
4045         -fix-multi-location-breakpoint-output.
4046         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4047         interpreter "mi".
4048
4049 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4050
4051         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4052         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4053         instantiate mi_ui_out based on interpreter name.
4054         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4055         * mi/mi-main.c (mi_load_progress): Likewise.
4056
4057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4058
4059         * NEWS: Combine separate "New targets" sections for 8.3.
4060
4061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4062
4063         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4064         (ppcfbsd_init_abi): Install gdbarch
4065         "fetch_tls_load_module_address" and "get_thread_local_address"
4066         methods.
4067
4068 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4069
4070         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4071         (riscv_fbsd_init_abi): Install gdbarch
4072         "fetch_tls_load_module_address" and "get_thread_local_address"
4073         methods.
4074
4075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4076
4077         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4078         (i386fbsd_init_abi): Install gdbarch
4079         "fetch_tls_load_module_address" and "get_thread_local_address"
4080         methods.
4081
4082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4083
4084         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4085         (amd64fbsd_init_abi): Install gdbarch
4086         "fetch_tls_load_module_address" and "get_thread_local_address"
4087         methods.
4088
4089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4090
4091         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4092         (struct fbsd_pspace_data): New type.
4093         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4094         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4095         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4096         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4097         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4098
4099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4100
4101         * gdbtypes.c (lookup_struct_elt): New function.
4102         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4103         * gdbtypes.h (struct struct_elt): New type.
4104         (lookup_struct_elt): New prototype.
4105
4106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4107
4108         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4109         remove disabled code block.
4110
4111 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4112
4113         * gdbarch.sh (get_thread_local_address): New method.
4114         * gdbarch.h, gdbarch.c: Regenerate.
4115         * target.c (target_translate_tls_address): Use
4116         gdbarch_get_thread_local_address if present instead of
4117         target::get_thread_local_address.
4118
4119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4120
4121         * target.h (target::get_thread_local_address): Update comment.
4122
4123 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4124
4125         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4126         objfile->separate_debug_objfile_backlink if not NULL.
4127
4128 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4129
4130         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4131         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4132         (amd64bsd_store_inferior_registers): Likewise.
4133         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4134         Enable segment base registers.
4135         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4136         PT_GETFSBASE and PT_GETGSBASE.
4137         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4138         PT_SETGSBASE.
4139         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4140         segment base registers.
4141         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4142
4143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4144
4145         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4146         Update calls to i386_target_description to add 'segments'
4147         parameter.
4148         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4149         add segment base registers.
4150         * arch/i386.c (i386_create_target_description): Add 'segments'
4151         parameter to enable segment base registers.
4152         * arch/i386.h (i386_create_target_description): Likewise.
4153         * features/i386/32bit-segments.xml: New file.
4154         * features/i386/32bit-segments.c: Generate.
4155         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4156         call to i386_target_description to add 'segments' parameter.
4157         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4158         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4159         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4160         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4161         if feature is present.
4162         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4163         Add 'segments' parameter to call to i386_target_description.
4164         (i386_target_description): Add 'segments' parameter to enable
4165         segment base registers.
4166         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4167         to call to i386_target_description.
4168         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4169         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4170         Define I386_NUM_REGS.
4171         (i386_target_description): Add 'segments' parameter to enable
4172         segment base registers.
4173
4174 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4175
4176         PR/24325
4177         * source-cache.c: #undef open and close, to avoid unresolved
4178         externals during linking.
4179
4180 2019-03-12  Tom Tromey  <tromey@adacore.com>
4181
4182         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4183         const.  Add initializers.
4184         (_initialize_remote): Don't initialize ptid globals.
4185
4186 2019-03-12  Pedro Alves  <palves@redhat.com>
4187
4188         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4189
4190 2019-03-12  Pedro Alves  <palves@redhat.com>
4191
4192         * cp-name-parser.y (main): Remove unused 'len' variable.
4193
4194 2019-03-12  Tom Tromey  <tromey@adacore.com>
4195
4196         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4197         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4198
4199 2019-03-12  Tom Tromey  <tromey@adacore.com>
4200
4201         * linux-nat.c (iterate_over_lwps): Update.
4202         (stop_callback): Remove parameter.
4203         (stop_wait_callback, detach_callback, resume_set_callback)
4204         (select_singlestep_lwp_callback, set_ignore_sigint)
4205         (status_callback, resumed_callback, resume_clear_callback)
4206         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4207         data parameter.
4208         (linux_nat_target::detach, linux_nat_target::resume)
4209         (linux_stop_and_wait_all_lwps, select_event_lwp)
4210         (linux_nat_filter_event, linux_nat_wait_1)
4211         (linux_nat_target::kill, linux_nat_target::stop)
4212         (linux_nat_target::stop): Update.
4213         (linux_nat_resume_callback): Change type.
4214         (resume_stopped_resumed_lwps, count_events_callback)
4215         (select_event_lwp_callback): Likewise.
4216         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4217         * arm-linux-nat.c (struct update_registers_data): Remove.
4218         (update_registers_callback): Change type.
4219         (arm_linux_insert_hw_breakpoint1): Update.
4220         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4221         parameter.
4222         (x86_linux_dr_set_addr): Update.
4223         (x86_linux_dr_set_control): Update.
4224         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4225         (iterate_over_lwps): Use gdb::function_view.
4226         * nat/aarch64-linux-hw-point.c (struct
4227         aarch64_dr_update_callback_param): Remove.
4228         (debug_reg_change_callback): Change type.
4229         (aarch64_notify_debug_reg_change): Update.
4230         * s390-linux-nat.c (s390_refresh_per_info): Update.
4231
4232 2019-03-11  Tom Tromey  <tromey@adacore.com>
4233
4234         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4235         redundant assignment to "this_cu".
4236
4237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4238
4239         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4240
4241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4242
4243         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4244         from...
4245         (rank_one_type): ... this.
4246
4247 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4248
4249         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4250         from...
4251         (rank_one_type): ... this.
4252
4253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4254
4255         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4256         from...
4257         (rank_one_type): ... this.
4258
4259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4260
4261         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4262         from...
4263         (rank_one_type): ... this.
4264
4265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4266
4267         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4268         from...
4269         (rank_one_type): ... this.
4270
4271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4272
4273         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4274         from...
4275         (rank_one_type): ... this.
4276
4277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4278
4279         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4280         from...
4281         (rank_one_type): ... this.
4282
4283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4284
4285         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4286         from...
4287         (rank_one_type): ... this.
4288
4289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4290
4291         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4292         from...
4293         (rank_one_type): ... this.
4294
4295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4296
4297         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4298         from...
4299         (rank_one_type): ... this.
4300
4301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4302
4303         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4304         from...
4305         (rank_one_type): ... this.
4306
4307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4308
4309         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4310         from...
4311         (rank_one_type): ... this.
4312
4313 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4314
4315         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4316         inferior-events' shows the example events.
4317
4318 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4319
4320         Support styling on native MS-Windows console
4321
4322         PR/24315
4323         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4324         on MS-Windows if $TERM is not defined.
4325
4326         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4327
4328         * posix-hdep.c (gdb_console_fputs):
4329         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4330         functions.
4331         * ui-file.h (gdb_console_fputs): Add prototype.
4332
4333         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4334         back to fputs only if the former returns zero.
4335
4336 2019-03-07  Tom Tromey  <tom@tromey.com>
4337
4338         * symmisc.c (print_symbol_bcache_statistics): Update.
4339         (print_objfile_statistics): Update.
4340         * symfile.c (allocate_symtab): Update.
4341         * stabsread.c: Don't include bcache.h.
4342         * psymtab.h (struct psymbol_bcache): Don't declare.
4343         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4344         (psymbol_bcache_init, psymbol_bcache_free)
4345         (psymbol_bcache_get_bcache): Don't declare.
4346         * psymtab.c (struct psymbol_bcache): Remove.
4347         (psymtab_storage::psymtab_storage): Update.
4348         (psymtab_storage::~psymtab_storage): Update.
4349         (psymbol_bcache_init, psymbol_bcache_free)
4350         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4351         (add_psymbol_to_bcache): Update.
4352         (allocate_psymtab): Update.
4353         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4354         macro_cache>: No longer pointers.
4355         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4356         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4357         * macrotab.c (macro_bcache): Update.
4358         * macroexp.c: Don't include bcache.h.
4359         * gdbtypes.c (check_types_worklist): Update.
4360         (types_deeply_equal): Remove TRY/CATCH.  Update.
4361         * elfread.c (elf_symtab_read): Update.
4362         * dwarf2read.c: Don't include bcache.h.
4363         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4364         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4365         (print_bcache_statistics, bcache_memory_used): Don't declare.
4366         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4367         methods.  Rename all data members.
4368         * bcache.c (struct bcache): Move to bcache.h.
4369         (bcache::expand_hash_table): Rename from expand_hash_table.
4370         (bcache): Remove.
4371         (bcache::insert): Rename from bcache_full.
4372         (bcache::compare): Rename from bcache_compare.
4373         (bcache_xmalloc): Remove.
4374         (bcache::~bcache): Rename from bcache_xfree.
4375         (bcache::print_statistics): Rename from print_bcache_statistics.
4376         (bcache::memory_used): Rename from bcache_memory_used.
4377
4378 2019-03-07  Pedro Alves  <palves@redhat.com>
4379
4380         * infrun.c (normal_stop): Also check for
4381         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4382
4383 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * f-lang.c (value_from_host_double): Moved to...
4386         * value.c (value_from_host_double): ...here.
4387         * value.h (value_from_host_double): Declare.
4388         * guile/scm-math.c (vlscm_convert_typed_number): Use
4389         value_from_host_double.
4390         (vlscm_convert_number): Likewise.
4391         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4392         * python/py-value.c (convert_value_from_python): Likewise.
4393
4394 2019-03-06  Tom Tromey  <tom@tromey.com>
4395
4396         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4397
4398 2019-03-06  Tom Tromey  <tom@tromey.com>
4399
4400         * utils.h (free_current_contents): Don't declare.
4401         * utils.c (free_current_contents): Remove.
4402
4403 2019-03-06  Tom Tromey  <tom@tromey.com>
4404
4405         * top.c (quit_force): Update.
4406         * main.c (captured_command_loop): Update.
4407         * common/new-op.c (operator new): Update.
4408         * common/common-exceptions.c (struct catcher)
4409         <save_cleanup_chain>: Remove member.
4410         (exceptions_state_mc_init): Update.
4411         (exception_try_scope_entry): Return nullptr.
4412         (exception_try_scope_exit, exception_rethrow)
4413         (throw_exception_sjlj, throw_exception_cxx): Update.
4414         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4415         (all_cleanups, do_cleanups, discard_cleanups)
4416         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4417         (restore_cleanups, restore_final_cleanups): Don't declare.
4418         (do_final_cleanups): Remove parameter.
4419         * common/cleanups.c (cleanup_chain, make_cleanup)
4420         (make_cleanup_dtor, all_cleanups, do_cleanups)
4421         (discard_my_cleanups, discard_cleanups)
4422         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4423         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4424         (null_cleanup): Remove.
4425         (do_final_cleanups): Remove parameter.
4426
4427 2019-03-06  Tom Tromey  <tom@tromey.com>
4428
4429         * remote.c (remote_target::remote_parse_stop_reply): Use
4430         unique_xmalloc_ptr.
4431
4432 2019-03-06  Tom Tromey  <tom@tromey.com>
4433
4434         * stabsread.c (struct stabs_field_info): Rename from field_info.
4435         <list, fnlist>: Add initializers.
4436         <obstack>: New member.
4437         (read_member_functions, read_struct_fields, read_baseclasses):
4438         Allocate on obstack.  Don't use cleanups.
4439         (read_one_struct_field, read_member_functions, read_struct_fields)
4440         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4441         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4442         (read_struct_type): Update.
4443
4444 2019-03-06  Tom Tromey  <tom@tromey.com>
4445
4446         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4447         * common/filestuff.h (make_cleanup_close): Don't declare.
4448         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4449         Remove.
4450
4451 2019-03-06  Tom Tromey  <tom@tromey.com>
4452
4453         * solib-aix.c: Use make_scope_exit.
4454
4455 2019-03-06  Tom Tromey  <tom@tromey.com>
4456
4457         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4458         Use make_scope_exit.
4459
4460 2019-03-06  Tom Tromey  <tom@tromey.com>
4461
4462         * solib-svr4.c (disable_probes_interface): Remove parameter.
4463         (svr4_handle_solib_event): Use make_scope_exit.
4464
4465 2019-03-06  Tom Tromey  <tom@tromey.com>
4466
4467         * remote.c (struct stop_reply_deleter): Remove.
4468         (stop_reply_up): Update.
4469         (struct stop_reply): Derive from notif_event.  Don't typedef.
4470         <regcache>: Now a std::vector.
4471         (stop_reply_xfree): Remove.
4472         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4473         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4474         (remote_target::discard_pending_stop_replies): Use delete.
4475         (remote_target::remote_parse_stop_reply): Update.
4476         (remote_target::process_stop_reply): Update.
4477         * remote-notif.h (struct notif_event): Add virtual destructor.
4478         Remove "dtr" member.
4479         (struct notif_client) <alloc_event>: Return a unique_ptr.
4480         (notif_event_xfree): Don't declare.
4481         (notif_event_up): New typedef.
4482         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4483         (notif_event_xfree, do_notif_event_xfree): Remove.
4484         (remote_notif_state_xfree): Update.
4485
4486 2019-03-06  Tom Tromey  <tom@tromey.com>
4487
4488         * infrun.c (displaced_step_clear_cleanup): Now a
4489         forward_scope_exit type.
4490         (displaced_step_prepare_throw): Update.
4491         (displaced_step_fixup): Update.
4492
4493 2019-03-06  Tom Tromey  <tom@tromey.com>
4494
4495         * inferior.h (class inferior): Update comment.
4496         * gdbthread.h (class thread_info): Update comment.
4497
4498 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4499             Tom Tromey  <tom@tromey.com>
4500
4501         * stabsread.h (struct stab_section_list): Remove.
4502         (coffstab_build_psymtabs): Update.
4503         * dbxread.c (symbuf_sections): Now a std::vector.
4504         (sect_idx): New global.
4505         (fill_symbuf): Update.
4506         (coffstab_build_psymtabs): Change type of stabsects parameter.
4507         Update.
4508         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4509         std::vector.
4510         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4511         (coff_locate_sections): Update.
4512         (coff_symfile_read): Remove cleanups.  Update.
4513         (init_stringtab): Add storage parameter.
4514         (free_stringtab, free_stringtab_cleanup): Remove.
4515         (init_lineno): Add storage parameter.
4516         (free_linetab, free_linetab_cleanup): Remove.
4517
4518 2019-03-06  Pedro Alves  <palves@redhat.com>
4519
4520         * linux-fork.c (fork_info::clobber_regs): Delete.
4521         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4522         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4523         comment.  Adjust.
4524         (scoped_switch_fork_info::scoped_switch_fork_info)
4525         (checkpoint_command, linux_fork_context): Adjust
4526         fork_save_infrun_state calls.
4527
4528 2019-03-06  Pedro Alves  <palves@redhat.com>
4529
4530         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4531         (inf_has_multiple_threads): Return 'bool' and rewrite using
4532         inferior_info::threads().
4533
4534 2019-03-06  Pedro Alves  <palves@redhat.com>
4535
4536         * linux-fork.c: Include <list>.
4537         (fork_list): Now a std::list instance.
4538         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4539         (forks_exist_p, find_last_fork): Adjust.
4540         (new_fork): Delete.
4541         (one_fork_p): New.
4542         (add_fork): Adjust.
4543         (free_fork): Delete, folded into fork_info::~fork_info().
4544         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4545         Adjust.
4546         (init_fork_list): Delete.
4547         (linux_fork_killall, linux_fork_mourn_inferior)
4548         (linux_fork_detach, info_checkpoints_command): Adjust.
4549         (_initialize_linux_fork): No longer call init_fork_list.
4550
4551 2019-03-06  Pedro Alves  <palves@redhat.com>
4552
4553         * linux-fork.c (new_fork): New, split out of ...
4554         (add_fork): ... this.  Return void.  Move "first fork" special
4555         case from here, to ...
4556         (checkpoint_command): ... here.
4557         * linux-linux.h (add_fork): Return void.
4558
4559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4562
4563 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4564             Chris January  <chris.january@arm.com>
4565             David Lecomber  <david.lecomber@arm.com>
4566
4567         * f-exp.y: New token, UNOP_INTRINSIC.
4568         (exp): New pattern using UNOP_INTRINSIC token.
4569         (f77_keywords): Add 'abs' keyword.
4570         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4571         (value_from_host_double): New function.
4572         (evaluate_subexp_f): Support UNOP_ABS.
4573
4574 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4577         types.
4578
4579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4582         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4583         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4584
4585 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4588
4589 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4590             Chris January  <chris.january@arm.com>
4591
4592         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4593         * f-exp.y: Define 'KIND' token.
4594         (exp): New pattern for KIND expressions.
4595         (ptype): Handle types with a kind extension.
4596         (direct_abs_decl): Extend to spot kind extensions.
4597         (f77_keywords): Add 'kind' to the list.
4598         (push_kind_type): New function.
4599         (convert_to_kind_type): New function.
4600         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4601         * parse.c (operator_length_standard): Likewise.
4602         * parser-defs.h (enum type_pieces): Add tp_kind.
4603         * std-operator.def: Add UNOP_KIND.
4604
4605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * f-exp.y (f_parse): Set yydebug.
4608
4609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * f-lang.c (evaluate_subexp_f): New function.
4612         (exp_descriptor_f): New global.
4613         (f_language_defn): Use exp_descriptor_f instead of
4614         exp_descriptor_standard.
4615
4616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * f-exp.y (struct token): Add comments.
4619         (dot_ops): Remove uppercase versions and the end marker.
4620         (f77_keywords): Likewise.
4621         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4622         entries in the dot_ops array are case insensitive, and use
4623         strncasecmp to compare strings.  Also some whitespace cleanup in
4624         this area.  Similar for the f77_keywords array, except entries in
4625         this list might be case sensitive.
4626
4627 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4628
4629         * f-exp.y (struct f77_boolean_val): Add comments.
4630         (boolean_values): Remove uppercase versions, and end marker.
4631         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4632         and use strncasecmp to achieve case insensitivity.  Additionally,
4633         perform whitespace cleanup around this code.
4634
4635 2019-03-06  Tom Tromey  <tromey@adacore.com>
4636
4637         * remote-sim.c (gdbsim_target_open): Use result of
4638         gdb_argv::release.
4639
4640 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4641         Dirk Schubert  <dirk.schubert@arm.com>
4642         Chris January  <chris.january@arm.com>
4643
4644         * eval.c (evaluate_subexp_standard): Call Fortran argument
4645         wrapping logic.
4646         * f-lang.c (struct value): A value which can be passed into a
4647         Fortran function call.
4648         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4649         where appropriate.
4650         (struct type): Value ready for a Fortran function call.
4651         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4652         is needed.
4653         * f-lang.h (fortran_argument_convert): Declaration.
4654         (fortran_preserve_arg_pointer): Declaration.
4655         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4656
4657 2019-03-05  Tom Tromey  <tromey@adacore.com>
4658
4659         * python/py-prettyprint.c (print_string_repr): Remove #if.
4660         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4661
4662 2019-03-05  Tom Tromey  <tromey@adacore.com>
4663
4664         * target.c (the_dummy_target): Move later.  Change type to
4665         "dummy_target".
4666         (initialize_targets): Don't initialize the_dummy_target.
4667
4668 2019-03-05  Tom Tromey  <tromey@adacore.com>
4669
4670         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4671         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4672
4673 2019-03-05  Tom Tromey  <tromey@adacore.com>
4674
4675         * windows-nat.c (windows_nat_target::attach)
4676         (windows_nat_target::detach): Don't call gdb_flush.
4677         * valprint.c (generic_val_print, val_print, val_print_string):
4678         Don't call gdb_flush.
4679         * utils.c (defaulted_query): Don't call gdb_flush.
4680         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4681         * target.c (target_announce_detach): Don't call gdb_flush.
4682         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4683         * remote.c (extended_remote_target::attach): Don't call
4684         gdb_flush.
4685         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4686         * printcmd.c (do_examine): Don't call gdb_flush.
4687         (info_display_command): Don't call gdb_flush.
4688         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4689         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4690         * memattr.c (info_mem_command): Don't call gdb_flush.
4691         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4692         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4693         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4694         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4695         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4696         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4697         (gnu_nat_target::detach): Don't call gdb_flush.
4698         * f-valprint.c (f_val_print): Don't call gdb_flush.
4699         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4700         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4701         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4702         gdb_flush.
4703         * c-valprint.c (c_val_print): Don't call gdb_flush.
4704         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4705
4706 2019-03-05  Tom Tromey  <tromey@adacore.com>
4707
4708         * varobj.c (update_dynamic_varobj_children): Update.
4709         (install_default_visualizer): Use reset, not release.
4710         * value.c (set_internalvar): Update.
4711         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4712         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4713         ATTRIBUTE_UNUSED_RESULT.
4714
4715 2019-03-05  Tom Tromey  <tromey@adacore.com>
4716
4717         * remote.c (class scoped_remote_fd) <release>: Add
4718         ATTRIBUTE_UNUSED_RESULT.
4719
4720 2019-03-05  Tom Tromey  <tromey@adacore.com>
4721
4722         * macroexp.c (struct macro_buffer) <release>: Add
4723         ATTRIBUTE_UNUSED_RESULT.
4724
4725 2019-03-05  Tom Tromey  <tromey@adacore.com>
4726
4727         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4728         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4729         ATTRIBUTE_UNUSED_RESULT.
4730
4731 2019-03-05  Tom Tromey  <tromey@adacore.com>
4732
4733         * common/scoped_fd.h (class scoped_fd) <release>: Add
4734         ATTRIBUTE_UNUSED_RESULT.
4735
4736 2019-03-05  Tom Tromey  <tromey@adacore.com>
4737
4738         * parser-defs.h (struct parser_state) <release>: Add
4739         ATTRIBUTE_UNUSED_RESULT.
4740
4741 2019-03-05  Tom Tromey  <tromey@adacore.com>
4742
4743         * utils.h (class gdb_argv) <release>: Add
4744         ATTRIBUTE_UNUSED_RESULT.
4745         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4746
4747 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4748
4749         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4750         for-loop range, to avoid compiler warnings.
4751
4752         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4753         avoid compiler warnings about unused variables.
4754
4755         * NEWS: Mention end of support for native debugging on MS-Windows
4756         before XP.
4757
4758         PR gdb/24292
4759         * common/netstuff.c:
4760         * gdbserver/gdbreplay.c
4761         * gdbserver/remote-utils.c:
4762         * ser-tcp.c:
4763         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4764         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4765         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4766         'getaddrinfo' and 'freeaddrinfo' were not available before
4767         Windows XP, and mingw.org's MinGW headers by default define
4768         _WIN32_WINNT to 0x500.
4769
4770 2019-03-01  Gary Benson <gbenson@redhat.com>
4771
4772         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4773
4774 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4775             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4776
4777         PR gdb/8527
4778         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4779         set_sigint_trap, clear_sigint_trap.
4780
4781 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4782
4783         * target.c (target_detach): Clear the regcache and the
4784         frame cache.
4785
4786 2019-02-27  Pedro Alves  <palves@redhat.com>
4787
4788         * utils.c (set_screen_size): When we cap the height/width sizes,
4789         tweak the corresponding command variable to show "unlimited":
4790
4791 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4792             Pedro Alves  <palves@redhat.com>
4793
4794         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4795         before calling rl_set_screen_size.
4796
4797 2019-02-27  Tom Tromey  <tromey@adacore.com>
4798
4799         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4800         define.
4801         * python/py-value.c: Remove Python 2.4 workaround.
4802         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4803         workaround.
4804         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4805         Python 2.4 workaround.
4806         * python/python-internal.h: Remove Python 2.4 comment.
4807         (Py_ssize_t): Don't define.
4808         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4809         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4810         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4811         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4812         * python/python.c (do_start_initialization): Remove Python 2.4
4813         workaround.
4814         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4815         (print_children): Remove Python 2.4 workaround.
4816         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4817         workaround.
4818         (CHARBUFFERPROC_NAME): Remove.
4819         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4820         Python 2.4 workaround.
4821
4822 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4823
4824         * NEWS: Note minimum Python version.
4825
4826 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4827
4828         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4829         code from these functions.  Remove corresponding ifdefs.  Use
4830         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4831         Remove gotos and target of gotos.
4832         (infpy_search_memory): Likewise.
4833
4834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4837         (hppa_gdbarch_init): Don't register deleted functions with
4838         gdbarch.
4839
4840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4843         (h8300_unwind_sp): Delete.
4844         (h8300_dummy_id): Delete.
4845         (h8300_gdbarch_init): Don't register deleted functions with
4846         gdbarch.
4847
4848 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4851         (ft32_unwind_pc): Delete.
4852         (ft32_unwind_sp): Delete.
4853         (ft32_gdbarch_init): Don't register deleted functions with
4854         gdbarch.
4855
4856 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4857
4858         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4859         (frv_unwind_pc): Delete.
4860         (frv_unwind_sp): Delete.
4861         (frv_gdbarch_init): Don't register deleted functions with
4862         gdbarch.
4863
4864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4867         (riscv_unwind_pc): Delete.
4868         (riscv_unwind_sp): Delete.
4869         (riscv_gdbarch_init): Don't register deleted functions with
4870         gdbarch.
4871
4872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4875         (csky_unwind_pc): Delete.
4876         (csky_unwind_sp): Delete.
4877         (csky_gdbarch_init): Don't register deleted functions with
4878         gdbarch.
4879
4880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4883         (cris_unwind_pc): Delete.
4884         (cris_unwind_sp): Delete.
4885         (cris_gdbarch_init): Don't register deleted functions with
4886         gdbarch.
4887
4888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4891         (bfin_unwind_pc): Delete.
4892         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4893
4894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4897         (arm_unwind_pc): Delete.
4898         (arm_unwind_sp): Delete.
4899         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4900
4901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4902
4903         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4904         (arc_unwind_pc): Delete.
4905         (arc_unwind_sp): Delete.
4906         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4907
4908 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4911         (alpha_unwind_pc): Delete.
4912         (alpha_gdbarch_init): Don't register deleted functions with
4913         gdbarch.
4914
4915 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4918         (aarch64_unwind_pc): Delete.
4919         (aarch64_unwind_sp): Delete.
4920         (aarch64_gdbarch_init): Don't register deleted functions with
4921         gdbarch.
4922
4923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * gdbtypes.c (type_align): Don't consider static members when
4926         computing structure alignment.
4927
4928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4931         return 0 for other types.
4932         * arch-utils.c (default_type_align): Always return 0.
4933         * gdbarch.h: Regenerate.
4934         * gdbarch.sh (type_align): Extend comment.
4935         * gdbtypes.c (type_align): Add additional comments, always call
4936         gdbarch_type_align before applying the default rules.
4937         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4938         generic code will then apply a suitable default.
4939         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4940         types, return 0 for other types.
4941
4942 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4943
4944         * NEWS: Create a new section for the next release branch.
4945         Rename the section of the current branch, now that it has
4946         been cut.
4947
4948 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4949
4950         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4951         * version.in: Bump version to 8.3.50.DATE-git.
4952
4953 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4954
4955         * aix-thread.c (ptid_cmp): Remove unused variable.
4956         (get_signaled_thread): Likewise.
4957         (store_regs_user_thread): Likewise.
4958         (store_regs_kernel_thread): Likewise.
4959         (fetch_regs_kernel_thread): Remove shadowed variable.
4960
4961 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * features/riscv/32bit-cpu.xml: Add register numbers.
4964         * features/riscv/32bit-fpu.c: Regenerate.
4965         * features/riscv/32bit-fpu.xml: Add register numbers.
4966         * features/riscv/64bit-cpu.xml: Add register numbers.
4967         * features/riscv/64bit-fpu.c: Regenerate.
4968         * features/riscv/64bit-fpu.xml: Add register numbers.
4969
4970 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4971
4972         * NEWS: Mention two argument form of gdb.Value constructor.
4973         * python/py-value.c (convert_buffer_and_type_to_value): New
4974         function.
4975         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4976         Add support for handling an optional second argument.  Call
4977         convert_buffer_and_type_to_value as appropriate.
4978         * python/python-internal.h (Py_buffer_deleter): New struct.
4979         (Py_buffer_up): New typedef.
4980
4981 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4982
4983         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4984         instead of releasing ownership.
4985
4986 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4987
4988         * dwarf2read.c (open_and_init_dwp_file): Call
4989         elf_numsections instead of bfd_count_sections to initialize
4990         dwp_file->num_sections.
4991
4992 2019-02-25  Tom Tromey  <tromey@adacore.com>
4993
4994         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4995
4996 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4997
4998         * gcore.in: Add '--readnever' option when invoking GDB.
4999
5000 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5001
5002         * MAINTAINERS: Update my email address.
5003
5004 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5005
5006         * build-id.c (build_id_to_debug_bfd_1): New function.
5007         (build_id_to_debug_bfd): Look for separate debug file in
5008         sysroot.
5009
5010 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * gdbarch.sh: Update the copyright year range that is placed into
5013         generated files.
5014
5015 2019-02-22  Keith Seitz  <keiths@redhat.com>
5016
5017         PR symtab/23853
5018         * linespec.c (create_sals_line_offset): Search for the default
5019         symtab's filename instead of its fullname.
5020
5021 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5022
5023         * NEWS: Update style defaults.
5024
5025 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5026
5027         * main.c (captured_main_1): Disable styling in batch mode.
5028
5029 2019-02-20  Tom Tromey  <tom@tromey.com>
5030
5031         * symtab.c (symtab_symbol_info): Fix typos.
5032
5033 2019-02-20  Tom Tromey  <tromey@adacore.com>
5034
5035         * findcmd.c (_initialize_mem_search): Use upper case for
5036         metasyntactic variables.
5037
5038 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5039
5040         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5041         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5042
5043 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5044
5045         * top.h (source_file_name): Change to std::string.
5046         * top.c (source_file_name): Likewise.
5047         (command_line_input): Adjust.
5048         * cli/cli-script.c (script_from_file): Adjust.
5049
5050 2019-02-19  Tom Tromey  <tromey@adacore.com>
5051
5052         * ravenscar-thread.c
5053         (ravenscar_thread_target::update_thread_list): Don't call
5054         ada_build_task_list.
5055         * ada-lang.h (ada_build_task_list): Don't declare.
5056         * ada-tasks.c (struct ada_tasks_inferior_data)
5057         <task_list_valid_p>: Now bool.
5058         (read_known_tasks, ada_task_list_changed)
5059         (ada_tasks_invalidate_inferior_data): Update.
5060         (read_known_tasks_array): Return bool.
5061         (read_known_tasks_list): Likewise.
5062         (read_known_tasks): Return void.
5063         (ada_build_task_list): Now static.
5064
5065 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5068         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5069
5070 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5071
5072         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5073         variant for ada_tasks_pspace_data_handle and
5074         ada_tasks_inferior_data_handle.
5075         (ada_tasks_pspace_data_cleanup): New function.
5076         (ada_tasks_inferior_data_cleanup): New function.
5077
5078 2019-02-17  Tom Tromey  <tom@tromey.com>
5079
5080         * macrotab.h (macro_source_fullname): Return a std::string.
5081         * macrotab.c (macro_include, check_for_redefinition)
5082         (macro_undef, macro_lookup_definition, foreach_macro)
5083         (foreach_macro_in_scope): Update.
5084         (macro_source_fullname): Return a std::string.
5085         * macrocmd.c (show_pp_source_pos): Update.
5086
5087 2019-02-17  Tom Tromey  <tom@tromey.com>
5088
5089         * macrocmd.c (show_pp_source_pos): Style the file names.
5090
5091 2019-02-17  Tom Tromey  <tom@tromey.com>
5092
5093         PR tui/24197:
5094         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5095
5096 2019-02-17  Tom Tromey  <tom@tromey.com>
5097
5098         * ada-lang.c (user_select_syms): Use filtered printing.
5099         * utils.c (wrap_style): New global.
5100         (desired_style): Remove.
5101         (emit_style_escape): Add stream parameter.
5102         (set_output_style, reset_terminal_style, prompt_for_continue):
5103         Update.
5104         (flush_wrap_buffer): Only flush gdb_stdout.
5105         (wrap_here): Set wrap_style.
5106         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5107         treat escape sequences as a character.  Change when wrap buffer is
5108         flushed.
5109         (fputs_styled): Do not set the output style when the default is
5110         requested.
5111         * ui-style.h (struct ui_file_style) <is_default>: New method.
5112         * source.c (print_source_lines_base): Emit escape sequences in one
5113         piece.
5114
5115 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5116
5117         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5118         integers and enumeration types.
5119
5120 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5121
5122         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5123         instead of lookup_symbol_in_language
5124         (do_exact_match): New function.
5125         (ada_get_symbol_name_matcher): Return do_exact_match when
5126         doing a verbatim match.
5127
5128 2019-02-15  Tom Tromey  <tromey@adacore.com>
5129
5130         * ravenscar-thread.c (ravenscar_thread_target::resume)
5131         (ravenscar_thread_target::wait): Special case wildcard requests.
5132
5133 2019-02-15  Tom Tromey  <tromey@adacore.com>
5134
5135         * ravenscar-thread.c (base_ptid): Remove.
5136         (struct ravenscar_thread_target) <close>: New method.
5137         <m_base_ptid>: New member.
5138         <update_inferior_ptid, active_task, task_is_currently_active,
5139         runtime_initialized>: Declare methods.
5140         <ravenscar_thread_target>: Add constructor.
5141         (ravenscar_thread_target::task_is_currently_active)
5142         (ravenscar_thread_target::update_inferior_ptid)
5143         (ravenscar_runtime_initialized): Rename.  Now methods.
5144         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5145         (ravenscar_thread_target::update_thread_list): Update.
5146         (ravenscar_thread_target::active_task): Now method.
5147         (ravenscar_thread_target::store_registers)
5148         (ravenscar_thread_target::prepare_to_store)
5149         (ravenscar_thread_target::prepare_to_store)
5150         (ravenscar_thread_target::mourn_inferior): Update.
5151         (ravenscar_inferior_created): Use "new" to create target.
5152         (ravenscar_thread_target::get_ada_task_ptid): Update.
5153         (_initialize_ravenscar): Don't initialize base_ptid.
5154         (ravenscar_ops): Remove global.
5155
5156 2019-02-15  Tom Tromey  <tromey@adacore.com>
5157
5158         * target.h (push_target): Declare new overload.
5159         * target.c (push_target): New overload, taking an rvalue reference.
5160         * remote.c (remote_target::open_1): Use push_target overload.
5161         * corelow.c (core_target_open): Use push_target overload.
5162
5163 2019-02-15  Tom Tromey  <tromey@adacore.com>
5164
5165         * ravenscar-thread.c (is_ravenscar_task)
5166         (ravenscar_task_is_currently_active): Return bool.
5167         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5168         (_initialize_ravenscar): Remove "(void)".
5169         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5170         Return bool.
5171
5172 2019-02-15  Tom Tromey  <tromey@adacore.com>
5173
5174         * ravenscar-thread.c (ravenscar_runtime_initializer)
5175         (has_ravenscar_runtime, get_running_thread_id)
5176         (ravenscar_thread_target::resume): Fix indentation.
5177
5178 2019-02-15  Tom Tromey  <tromey@adacore.com>
5179
5180         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5181         from ravenscar_arch_ops.
5182         (sparc_ravenscar_ops::fetch_registers)
5183         (sparc_ravenscar_ops::store_registers): Now methods.
5184         (sparc_ravenscar_prepare_to_store): Remove.
5185         (sparc_ravenscar_ops): Redefine.
5186         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5187         methods and destructor.  Remove members.
5188         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5189         (ravenscar_thread_target::store_registers)
5190         (ravenscar_thread_target::prepare_to_store): Update.
5191         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5192         Remove.
5193         (struct ppc_ravenscar_powerpc_ops): Derive from
5194         ravenscar_arch_ops.
5195         (ppc_ravenscar_powerpc_ops::fetch_registers)
5196         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5197         (ppc_ravenscar_powerpc_ops): Redefine.
5198         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5199         (ppc_ravenscar_e500_ops::fetch_registers)
5200         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5201         (ppc_ravenscar_e500_ops): Redefine.
5202         * aarch64-ravenscar-thread.c
5203         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5204         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5205         (aarch64_ravenscar_fetch_registers)
5206         (aarch64_ravenscar_store_registers): Now methods.
5207         (aarch64_ravenscar_ops): Redefine.
5208
5209 2019-02-15  Tom Tromey  <tromey@adacore.com>
5210
5211         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5212         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5213         (ravenscar_thread_target::stopped_by_watchpoint)
5214         (ravenscar_thread_target::stopped_data_address)
5215         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5216
5217 2019-02-15  Tom Tromey  <tromey@adacore.com>
5218
5219         * ravenscar-thread.c: Fix some typos.
5220
5221 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5222             Tom Tromey  <tromey@adacore.com>
5223
5224         * ada-lang.c (ada_exception_sal): Change addr_string to a
5225         std::string.
5226         (create_ada_exception_catchpoint): Update.
5227
5228 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5229             Tom Tromey  <tromey@adacore.com>
5230
5231         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5232         (bp_location_ops): Remove.
5233         (base_breakpoint_allocate_location): Update.
5234         (free_bp_location): Update.
5235         * ada-lang.c (class ada_catchpoint_location)
5236         <ada_catchpoint_location>: Remove ops parameter.
5237         (ada_catchpoint_location_dtor): Remove.
5238         (ada_catchpoint_location_ops): Remove.
5239         (allocate_location_exception): Update.
5240         * breakpoint.h (struct bp_location_ops): Remove.
5241         (class bp_location) <bp_location>: Remove bp_location_ops
5242         parameter.
5243         <~bp_location>: Add destructor.
5244         <ops>: Remove.
5245
5246 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5247             Pedro Alves  <palves@redhat.com>
5248
5249         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5250         'PATH_MAX'.
5251
5252 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5253             Samuel Thibault  <samuel.thibault@gnu.org>
5254             Thomas Schwinge  <thomas@codesourcery.com>
5255
5256         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5257         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5258
5259 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5260
5261         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5262         (check_empty): Use "const char *".
5263
5264         * gnu-nat.c (gnu_nat_target::detach): Instead of
5265         'detach_inferior (pid)' call
5266         'detach_inferior (find_inferior_pid (pid))'.
5267
5268         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5269         'nat/fork-inferior.o'.
5270         * gnu-nat.c: #include "nat/fork-inferior.h".
5271
5272         * gnu-nat.c (gnu_nat_target::detach): Instead of
5273         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5274         * gnu-nat.h: #include "inf-child.h".
5275         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5276         'i386_gnu_nat_target::fetch_registers'.
5277         (gnu_store_registers): Rename/move to
5278         'i386_gnu_nat_target::store_registers'.
5279
5280         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5281         * gnu-nat.h (mach_thread_info): New function.
5282         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5283
5284         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5285
5286 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5287
5288         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5289
5290 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5291
5292         * windows-nat.c (windows_add_thread): Add new parameter
5293         "main_thread_p" with default value set to false.  Update
5294         function documentation as well as all callers.
5295         (windows_delete_thread): Likewise.
5296         (fake_create_process): Update call to windows_add_thread.
5297         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5298         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5299         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5300         call to windows_delete_thread.
5301
5302 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5303
5304         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5305
5306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5307
5308         * symfile.c (find_separate_debug_file): Use canonical path of
5309         sysroot with child_path instead of gdb_sysroot if it is valid.
5310
5311 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5312
5313         * symfile.c (find_separate_debug_file): Use child_path to
5314         determine if an object file is under a sysroot.
5315
5316 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5317
5318         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5319         unittests/child-path-selftests.c.
5320         * common/pathstuff.c (child_path): New function.
5321         * common/pathstuff.h (child_path): New prototype.
5322         * unittests/child-path-selftests.c: New file.
5323
5324 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5325
5326         * symfile.c (find_separate_debug_file): Look for separate debug
5327         files in debug directories under the sysroot.
5328
5329 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5330
5331         * symtab.h (struct minimal_symbol data_p): New const method.
5332         (struct minimal_symbol text_p): Likewise.
5333         * symtab.c (output_source_filename): Use file name style
5334         to print file name.
5335         (print_symbol_info): Likewise.
5336         (print_msymbol_info): Use address style to print addresses.
5337         Use function name style to print executable text symbols.
5338         (expand_symtab_containing_pc): Use data_p.
5339         (find_pc_sect_compunit_symtab): Likewise.
5340
5341 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5342
5343         * breakpoint.c (describe_other_breakpoints): Use address style
5344         to print addresses.
5345         (say_where): Likewise.
5346
5347 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5348
5349         * ada-typeprint.c (print_func_type): Print function name
5350         style to print function name.
5351         * c-typeprint.c (c_print_type_1): Likewise.
5352
5353 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5354
5355         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5356         for execve.
5357
5358 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5359
5360         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5361         type_stack.
5362
5363 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5364
5365         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5366         TYPE_CODE_REF types.
5367
5368 2019-02-08  Jim Wilson  <jimw@sifive.com>
5369
5370         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5371         (riscv_linux_fregset): New.
5372         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5373
5374 2019-02-07  Tom Tromey  <tom@tromey.com>
5375
5376         * thread.c (thread_cancel_execution_command): Update.
5377         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5378         methods.
5379         (struct thread_fsm_ops): Remove.
5380         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5381         (thread_fsm_should_stop, thread_fsm_return_value)
5382         (thread_fsm_set_finished, thread_fsm_finished_p)
5383         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5384         Don't declare.
5385         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5386         * infrun.c (clear_proceed_status_thread)
5387         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5388         (print_stop_event): Update.
5389         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5390         Add constructor.
5391         (step_command_fsm_ops): Remove.
5392         (new_step_command_fsm): Remove.
5393         (step_1): Update.
5394         (step_command_fsm::should_stop): Rename from
5395         step_command_fsm_should_stop.
5396         (step_command_fsm::clean_up): Rename from
5397         step_command_fsm_clean_up.
5398         (step_command_fsm::do_async_reply_reason): Rename from
5399         step_command_fsm_async_reply_reason.
5400         (struct until_next_fsm): Inherit from thread_fsm.  Add
5401         constructor.
5402         (until_next_fsm_ops): Remove.
5403         (new_until_next_fsm): Remove.
5404         (until_next_fsm::should_stop): Rename from
5405         until_next_fsm_should_stop.
5406         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5407         (until_next_fsm::do_async_reply_reason): Rename from
5408         until_next_fsm_async_reply_reason.
5409         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5410         constructor.  Change type of breakpoint.
5411         (finish_command_fsm_ops): Remove.
5412         (new_finish_command_fsm): Remove.
5413         (finish_command_fsm::should_stop): Rename from
5414         finish_command_fsm_should_stop.
5415         (finish_command_fsm::clean_up): Rename from
5416         finish_command_fsm_clean_up.
5417         (finish_command_fsm::return_value): Rename from
5418         finish_command_fsm_return_value.
5419         (finish_command_fsm::do_async_reply_reason): Rename from
5420         finish_command_fsm_async_reply_reason.
5421         (finish_command): Update.
5422         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5423         Add constructor.
5424         (call_thread_fsm_ops): Remove.
5425         (call_thread_fsm::call_thread_fsm): Rename from
5426         new_call_thread_fsm.
5427         (call_thread_fsm::should_stop): Rename from
5428         call_thread_fsm_should_stop.
5429         (call_thread_fsm::should_notify_stop): Rename from
5430         call_thread_fsm_should_notify_stop.
5431         (run_inferior_call, call_function_by_hand_dummy): Update.
5432         * cli/cli-interp.c (should_print_stop_to_console): Update.
5433         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5434         Add constructor.  Change type of location_breakpoint,
5435         caller_breakpoint.
5436         (until_break_fsm_ops): Remove.
5437         (new_until_break_fsm): Remove.
5438         (until_break_fsm::should_stop): Rename from
5439         until_break_fsm_should_stop.
5440         (until_break_fsm::clean_up): Rename from
5441         until_break_fsm_clean_up.
5442         (until_break_fsm::do_async_reply_reason): Rename from
5443         until_break_fsm_async_reply_reason.
5444         (until_break_command): Update.
5445         * thread-fsm.c: Remove.
5446         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5447
5448 2019-02-07  Tom Tromey  <tom@tromey.com>
5449
5450         * yy-remap.h: Add include guard.
5451         * xtensa-tdep.h: Add include guard.
5452         * xcoffread.h: Rename include guard.
5453         * varobj-iter.h: Add include guard.
5454         * tui/tui.h: Rename include guard.
5455         * tui/tui-winsource.h: Rename include guard.
5456         * tui/tui-wingeneral.h: Rename include guard.
5457         * tui/tui-windata.h: Rename include guard.
5458         * tui/tui-win.h: Rename include guard.
5459         * tui/tui-stack.h: Rename include guard.
5460         * tui/tui-source.h: Rename include guard.
5461         * tui/tui-regs.h: Rename include guard.
5462         * tui/tui-out.h: Rename include guard.
5463         * tui/tui-layout.h: Rename include guard.
5464         * tui/tui-io.h: Rename include guard.
5465         * tui/tui-hooks.h: Rename include guard.
5466         * tui/tui-file.h: Rename include guard.
5467         * tui/tui-disasm.h: Rename include guard.
5468         * tui/tui-data.h: Rename include guard.
5469         * tui/tui-command.h: Rename include guard.
5470         * tic6x-tdep.h: Add include guard.
5471         * target/waitstatus.h: Rename include guard.
5472         * target/wait.h: Rename include guard.
5473         * target/target.h: Rename include guard.
5474         * target/resume.h: Rename include guard.
5475         * target-float.h: Rename include guard.
5476         * stabsread.h: Add include guard.
5477         * rs6000-tdep.h: Add include guard.
5478         * riscv-fbsd-tdep.h: Add include guard.
5479         * regformats/regdef.h: Rename include guard.
5480         * record.h: Rename include guard.
5481         * python/python.h: Rename include guard.
5482         * python/python-internal.h: Rename include guard.
5483         * python/py-stopevent.h: Rename include guard.
5484         * python/py-ref.h: Rename include guard.
5485         * python/py-record.h: Rename include guard.
5486         * python/py-record-full.h: Rename include guard.
5487         * python/py-record-btrace.h: Rename include guard.
5488         * python/py-instruction.h: Rename include guard.
5489         * python/py-events.h: Rename include guard.
5490         * python/py-event.h: Rename include guard.
5491         * procfs.h: Add include guard.
5492         * proc-utils.h: Add include guard.
5493         * p-lang.h: Add include guard.
5494         * or1k-tdep.h: Rename include guard.
5495         * observable.h: Rename include guard.
5496         * nto-tdep.h: Rename include guard.
5497         * nat/x86-linux.h: Rename include guard.
5498         * nat/x86-linux-dregs.h: Rename include guard.
5499         * nat/x86-gcc-cpuid.h: Add include guard.
5500         * nat/x86-dregs.h: Rename include guard.
5501         * nat/x86-cpuid.h: Rename include guard.
5502         * nat/ppc-linux.h: Rename include guard.
5503         * nat/mips-linux-watch.h: Rename include guard.
5504         * nat/linux-waitpid.h: Rename include guard.
5505         * nat/linux-ptrace.h: Rename include guard.
5506         * nat/linux-procfs.h: Rename include guard.
5507         * nat/linux-osdata.h: Rename include guard.
5508         * nat/linux-nat.h: Rename include guard.
5509         * nat/linux-namespaces.h: Rename include guard.
5510         * nat/linux-btrace.h: Rename include guard.
5511         * nat/glibc_thread_db.h: Rename include guard.
5512         * nat/gdb_thread_db.h: Rename include guard.
5513         * nat/gdb_ptrace.h: Rename include guard.
5514         * nat/fork-inferior.h: Rename include guard.
5515         * nat/amd64-linux-siginfo.h: Rename include guard.
5516         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5517         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5518         * nat/aarch64-linux.h: Rename include guard.
5519         * nat/aarch64-linux-hw-point.h: Rename include guard.
5520         * mn10300-tdep.h: Add include guard.
5521         * mips-linux-tdep.h: Add include guard.
5522         * mi/mi-parse.h: Rename include guard.
5523         * mi/mi-out.h: Rename include guard.
5524         * mi/mi-main.h: Rename include guard.
5525         * mi/mi-interp.h: Rename include guard.
5526         * mi/mi-getopt.h: Rename include guard.
5527         * mi/mi-console.h: Rename include guard.
5528         * mi/mi-common.h: Rename include guard.
5529         * mi/mi-cmds.h: Rename include guard.
5530         * mi/mi-cmd-break.h: Rename include guard.
5531         * m2-lang.h: Add include guard.
5532         * location.h: Rename include guard.
5533         * linux-record.h: Rename include guard.
5534         * linux-nat.h: Add include guard.
5535         * linux-fork.h: Add include guard.
5536         * i386-darwin-tdep.h: Rename include guard.
5537         * hppa-linux-offsets.h: Add include guard.
5538         * guile/guile.h: Rename include guard.
5539         * guile/guile-internal.h: Rename include guard.
5540         * gnu-nat.h: Rename include guard.
5541         * gdb-stabs.h: Rename include guard.
5542         * frv-tdep.h: Add include guard.
5543         * f-lang.h: Add include guard.
5544         * event-loop.h: Add include guard.
5545         * darwin-nat.h: Rename include guard.
5546         * cp-abi.h: Rename include guard.
5547         * config/sparc/nm-sol2.h: Rename include guard.
5548         * config/nm-nto.h: Rename include guard.
5549         * config/nm-linux.h: Add include guard.
5550         * config/i386/nm-i386gnu.h: Rename include guard.
5551         * config/djgpp/nl_types.h: Rename include guard.
5552         * config/djgpp/langinfo.h: Rename include guard.
5553         * compile/gcc-cp-plugin.h: Add include guard.
5554         * compile/gcc-c-plugin.h: Add include guard.
5555         * compile/compile.h: Rename include guard.
5556         * compile/compile-object-run.h: Rename include guard.
5557         * compile/compile-object-load.h: Rename include guard.
5558         * compile/compile-internal.h: Rename include guard.
5559         * compile/compile-cplus.h: Rename include guard.
5560         * compile/compile-c.h: Rename include guard.
5561         * common/xml-utils.h: Rename include guard.
5562         * common/x86-xstate.h: Rename include guard.
5563         * common/version.h: Rename include guard.
5564         * common/vec.h: Rename include guard.
5565         * common/tdesc.h: Rename include guard.
5566         * common/selftest.h: Rename include guard.
5567         * common/scoped_restore.h: Rename include guard.
5568         * common/scoped_mmap.h: Rename include guard.
5569         * common/scoped_fd.h: Rename include guard.
5570         * common/safe-iterator.h: Rename include guard.
5571         * common/run-time-clock.h: Rename include guard.
5572         * common/refcounted-object.h: Rename include guard.
5573         * common/queue.h: Rename include guard.
5574         * common/ptid.h: Rename include guard.
5575         * common/print-utils.h: Rename include guard.
5576         * common/preprocessor.h: Rename include guard.
5577         * common/pathstuff.h: Rename include guard.
5578         * common/observable.h: Rename include guard.
5579         * common/netstuff.h: Rename include guard.
5580         * common/job-control.h: Rename include guard.
5581         * common/host-defs.h: Rename include guard.
5582         * common/gdb_wait.h: Rename include guard.
5583         * common/gdb_vecs.h: Rename include guard.
5584         * common/gdb_unlinker.h: Rename include guard.
5585         * common/gdb_unique_ptr.h: Rename include guard.
5586         * common/gdb_tilde_expand.h: Rename include guard.
5587         * common/gdb_sys_time.h: Rename include guard.
5588         * common/gdb_string_view.h: Rename include guard.
5589         * common/gdb_splay_tree.h: Rename include guard.
5590         * common/gdb_setjmp.h: Rename include guard.
5591         * common/gdb_ref_ptr.h: Rename include guard.
5592         * common/gdb_optional.h: Rename include guard.
5593         * common/gdb_locale.h: Rename include guard.
5594         * common/gdb_assert.h: Rename include guard.
5595         * common/filtered-iterator.h: Rename include guard.
5596         * common/filestuff.h: Rename include guard.
5597         * common/fileio.h: Rename include guard.
5598         * common/environ.h: Rename include guard.
5599         * common/common-utils.h: Rename include guard.
5600         * common/common-types.h: Rename include guard.
5601         * common/common-regcache.h: Rename include guard.
5602         * common/common-inferior.h: Rename include guard.
5603         * common/common-gdbthread.h: Rename include guard.
5604         * common/common-exceptions.h: Rename include guard.
5605         * common/common-defs.h: Rename include guard.
5606         * common/common-debug.h: Rename include guard.
5607         * common/cleanups.h: Rename include guard.
5608         * common/buffer.h: Rename include guard.
5609         * common/btrace-common.h: Rename include guard.
5610         * common/break-common.h: Rename include guard.
5611         * cli/cli-utils.h: Rename include guard.
5612         * cli/cli-style.h: Rename include guard.
5613         * cli/cli-setshow.h: Rename include guard.
5614         * cli/cli-script.h: Rename include guard.
5615         * cli/cli-interp.h: Rename include guard.
5616         * cli/cli-decode.h: Rename include guard.
5617         * cli/cli-cmds.h: Rename include guard.
5618         * charset-list.h: Add include guard.
5619         * buildsym-legacy.h: Rename include guard.
5620         * bfin-tdep.h: Add include guard.
5621         * ax.h: Rename include guard.
5622         * arm-linux-tdep.h: Add include guard.
5623         * arm-fbsd-tdep.h: Add include guard.
5624         * arch/xtensa.h: Rename include guard.
5625         * arch/tic6x.h: Add include guard.
5626         * arch/i386.h: Add include guard.
5627         * arch/arm.h: Rename include guard.
5628         * arch/arm-linux.h: Rename include guard.
5629         * arch/arm-get-next-pcs.h: Rename include guard.
5630         * arch/amd64.h: Add include guard.
5631         * arch/aarch64-insn.h: Rename include guard.
5632         * arch-utils.h: Rename include guard.
5633         * annotate.h: Add include guard.
5634         * amd64-darwin-tdep.h: Rename include guard.
5635         * aarch64-linux-tdep.h: Add include guard.
5636         * aarch64-fbsd-tdep.h: Add include guard.
5637         * aarch32-linux-nat.h: Add include guard.
5638
5639 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5640
5641         * macrotab.c (macro_define_internal): New function that
5642         factorizes macro_define_object_internal and macro_define_function
5643         code.
5644         (macro_define_object_internal): Use macro_define_internal.
5645         (macro_define_function): Likewise.
5646
5647 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5648
5649         * macrocmd.c (extract_identifier): Return
5650         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5651         callers.
5652
5653 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5654
5655         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5656
5657 2019-02-05  Tom Tromey  <tom@tromey.com>
5658
5659         * target.c (target_stack::unpush): Move assertion earlier.
5660
5661 2019-01-30  Tom Tromey  <tom@tromey.com>
5662
5663         PR python/23615:
5664         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5665         (gdbpy_parse_and_eval): Likewise.
5666         * python/python-internal.h (gdbpy_allow_threads): New class.
5667
5668 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5669
5670         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5671         (aarch64_fbsd_fpregmap): Move earlier.
5672         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5673         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5674         instead of individual calls to trad_frame_set_reg_addr.
5675         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5676         earlier.
5677         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5678         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5679         instead of individual calls to trad_frame_set_reg_addr.
5680
5681 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5682
5683         * CONTRIBUTE: Replace contribution list with wiki link.
5684
5685 2019-01-25  Tom Tromey  <tom@tromey.com>
5686
5687         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5688
5689 2019-01-25  Tom Tromey  <tom@tromey.com>
5690
5691         * xtensa-linux-nat.c: Fix common/ includes.
5692         * xml-support.h: Fix common/ includes.
5693         * xml-support.c: Fix common/ includes.
5694         * x86-linux-nat.c: Fix common/ includes.
5695         * windows-nat.c: Fix common/ includes.
5696         * varobj.h: Fix common/ includes.
5697         * varobj.c: Fix common/ includes.
5698         * value.c: Fix common/ includes.
5699         * valops.c: Fix common/ includes.
5700         * utils.c: Fix common/ includes.
5701         * unittests/xml-utils-selftests.c: Fix common/ includes.
5702         * unittests/utils-selftests.c: Fix common/ includes.
5703         * unittests/unpack-selftests.c: Fix common/ includes.
5704         * unittests/tracepoint-selftests.c: Fix common/ includes.
5705         * unittests/style-selftests.c: Fix common/ includes.
5706         * unittests/string_view-selftests.c: Fix common/ includes.
5707         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5708         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5709         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5710         * unittests/rsp-low-selftests.c: Fix common/ includes.
5711         * unittests/parse-connection-spec-selftests.c: Fix common/
5712         includes.
5713         * unittests/optional-selftests.c: Fix common/ includes.
5714         * unittests/offset-type-selftests.c: Fix common/ includes.
5715         * unittests/observable-selftests.c: Fix common/ includes.
5716         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5717         * unittests/memrange-selftests.c: Fix common/ includes.
5718         * unittests/memory-map-selftests.c: Fix common/ includes.
5719         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5720         * unittests/function-view-selftests.c: Fix common/ includes.
5721         * unittests/environ-selftests.c: Fix common/ includes.
5722         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5723         * unittests/common-utils-selftests.c: Fix common/ includes.
5724         * unittests/cli-utils-selftests.c: Fix common/ includes.
5725         * unittests/array-view-selftests.c: Fix common/ includes.
5726         * ui-file.c: Fix common/ includes.
5727         * tui/tui-io.c: Fix common/ includes.
5728         * tracepoint.h: Fix common/ includes.
5729         * tracepoint.c: Fix common/ includes.
5730         * tracefile-tfile.c: Fix common/ includes.
5731         * top.h: Fix common/ includes.
5732         * top.c: Fix common/ includes.
5733         * thread.c: Fix common/ includes.
5734         * target/waitstatus.h: Fix common/ includes.
5735         * target/waitstatus.c: Fix common/ includes.
5736         * target.h: Fix common/ includes.
5737         * target.c: Fix common/ includes.
5738         * target-memory.c: Fix common/ includes.
5739         * target-descriptions.c: Fix common/ includes.
5740         * symtab.h: Fix common/ includes.
5741         * symfile.c: Fix common/ includes.
5742         * stap-probe.c: Fix common/ includes.
5743         * spu-linux-nat.c: Fix common/ includes.
5744         * sparc-nat.c: Fix common/ includes.
5745         * source.c: Fix common/ includes.
5746         * solib.c: Fix common/ includes.
5747         * solib-target.c: Fix common/ includes.
5748         * ser-unix.c: Fix common/ includes.
5749         * ser-tcp.c: Fix common/ includes.
5750         * ser-pipe.c: Fix common/ includes.
5751         * ser-base.c: Fix common/ includes.
5752         * selftest-arch.c: Fix common/ includes.
5753         * s12z-tdep.c: Fix common/ includes.
5754         * rust-exp.y: Fix common/ includes.
5755         * rs6000-aix-tdep.c: Fix common/ includes.
5756         * riscv-tdep.c: Fix common/ includes.
5757         * remote.c: Fix common/ includes.
5758         * remote-notif.h: Fix common/ includes.
5759         * remote-fileio.h: Fix common/ includes.
5760         * remote-fileio.c: Fix common/ includes.
5761         * regcache.h: Fix common/ includes.
5762         * regcache.c: Fix common/ includes.
5763         * record-btrace.c: Fix common/ includes.
5764         * python/python.c: Fix common/ includes.
5765         * python/py-type.c: Fix common/ includes.
5766         * python/py-inferior.c: Fix common/ includes.
5767         * progspace.h: Fix common/ includes.
5768         * producer.c: Fix common/ includes.
5769         * procfs.c: Fix common/ includes.
5770         * proc-api.c: Fix common/ includes.
5771         * printcmd.c: Fix common/ includes.
5772         * ppc-linux-nat.c: Fix common/ includes.
5773         * parser-defs.h: Fix common/ includes.
5774         * osdata.c: Fix common/ includes.
5775         * obsd-nat.c: Fix common/ includes.
5776         * nat/x86-linux.c: Fix common/ includes.
5777         * nat/x86-linux-dregs.c: Fix common/ includes.
5778         * nat/x86-dregs.h: Fix common/ includes.
5779         * nat/x86-dregs.c: Fix common/ includes.
5780         * nat/ppc-linux.c: Fix common/ includes.
5781         * nat/mips-linux-watch.h: Fix common/ includes.
5782         * nat/mips-linux-watch.c: Fix common/ includes.
5783         * nat/linux-waitpid.c: Fix common/ includes.
5784         * nat/linux-ptrace.h: Fix common/ includes.
5785         * nat/linux-ptrace.c: Fix common/ includes.
5786         * nat/linux-procfs.c: Fix common/ includes.
5787         * nat/linux-personality.c: Fix common/ includes.
5788         * nat/linux-osdata.c: Fix common/ includes.
5789         * nat/linux-namespaces.c: Fix common/ includes.
5790         * nat/linux-btrace.h: Fix common/ includes.
5791         * nat/linux-btrace.c: Fix common/ includes.
5792         * nat/fork-inferior.c: Fix common/ includes.
5793         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5794         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5795         * nat/aarch64-linux.c: Fix common/ includes.
5796         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5797         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5798         * namespace.h: Fix common/ includes.
5799         * mips-linux-tdep.c: Fix common/ includes.
5800         * minsyms.c: Fix common/ includes.
5801         * mi/mi-parse.h: Fix common/ includes.
5802         * mi/mi-main.c: Fix common/ includes.
5803         * mi/mi-cmd-env.c: Fix common/ includes.
5804         * memrange.h: Fix common/ includes.
5805         * memattr.c: Fix common/ includes.
5806         * maint.h: Fix common/ includes.
5807         * maint.c: Fix common/ includes.
5808         * main.c: Fix common/ includes.
5809         * machoread.c: Fix common/ includes.
5810         * location.c: Fix common/ includes.
5811         * linux-thread-db.c: Fix common/ includes.
5812         * linux-nat.c: Fix common/ includes.
5813         * linux-fork.c: Fix common/ includes.
5814         * inline-frame.c: Fix common/ includes.
5815         * infrun.c: Fix common/ includes.
5816         * inflow.c: Fix common/ includes.
5817         * inferior.h: Fix common/ includes.
5818         * inferior.c: Fix common/ includes.
5819         * infcmd.c: Fix common/ includes.
5820         * inf-ptrace.c: Fix common/ includes.
5821         * inf-child.c: Fix common/ includes.
5822         * ia64-linux-nat.c: Fix common/ includes.
5823         * i387-tdep.c: Fix common/ includes.
5824         * i386-tdep.c: Fix common/ includes.
5825         * i386-linux-tdep.c: Fix common/ includes.
5826         * i386-linux-nat.c: Fix common/ includes.
5827         * i386-go32-tdep.c: Fix common/ includes.
5828         * i386-fbsd-tdep.c: Fix common/ includes.
5829         * i386-fbsd-nat.c: Fix common/ includes.
5830         * guile/scm-type.c: Fix common/ includes.
5831         * guile/guile.c: Fix common/ includes.
5832         * go32-nat.c: Fix common/ includes.
5833         * gnu-nat.c: Fix common/ includes.
5834         * gdbthread.h: Fix common/ includes.
5835         * gdbarch-selftests.c: Fix common/ includes.
5836         * gdb_usleep.c: Fix common/ includes.
5837         * gdb_select.h: Fix common/ includes.
5838         * gdb_bfd.c: Fix common/ includes.
5839         * gcore.c: Fix common/ includes.
5840         * fork-child.c: Fix common/ includes.
5841         * findvar.c: Fix common/ includes.
5842         * fbsd-nat.c: Fix common/ includes.
5843         * event-top.c: Fix common/ includes.
5844         * event-loop.c: Fix common/ includes.
5845         * dwarf2read.c: Fix common/ includes.
5846         * dwarf2loc.c: Fix common/ includes.
5847         * dwarf2-frame.c: Fix common/ includes.
5848         * dwarf-index-cache.c: Fix common/ includes.
5849         * dtrace-probe.c: Fix common/ includes.
5850         * disasm-selftests.c: Fix common/ includes.
5851         * defs.h: Fix common/ includes.
5852         * csky-tdep.c: Fix common/ includes.
5853         * cp-valprint.c: Fix common/ includes.
5854         * cp-support.h: Fix common/ includes.
5855         * cp-support.c: Fix common/ includes.
5856         * corelow.c: Fix common/ includes.
5857         * completer.h: Fix common/ includes.
5858         * completer.c: Fix common/ includes.
5859         * compile/compile.c: Fix common/ includes.
5860         * compile/compile-loc2c.c: Fix common/ includes.
5861         * compile/compile-cplus-types.c: Fix common/ includes.
5862         * compile/compile-cplus-symbols.c: Fix common/ includes.
5863         * command.h: Fix common/ includes.
5864         * cli/cli-dump.c: Fix common/ includes.
5865         * cli/cli-cmds.c: Fix common/ includes.
5866         * charset.c: Fix common/ includes.
5867         * build-id.c: Fix common/ includes.
5868         * btrace.h: Fix common/ includes.
5869         * btrace.c: Fix common/ includes.
5870         * breakpoint.h: Fix common/ includes.
5871         * breakpoint.c: Fix common/ includes.
5872         * ax.h:
5873         (enum agent_op): Fix common/ includes.
5874         * ax-general.c (struct aop_map): Fix common/ includes.
5875         * ax-gdb.c: Fix common/ includes.
5876         * auxv.c: Fix common/ includes.
5877         * auto-load.c: Fix common/ includes.
5878         * arm-tdep.c: Fix common/ includes.
5879         * arch/riscv.c: Fix common/ includes.
5880         * arch/ppc-linux-common.c: Fix common/ includes.
5881         * arch/i386.c: Fix common/ includes.
5882         * arch/arm.c: Fix common/ includes.
5883         * arch/arm-linux.c: Fix common/ includes.
5884         * arch/arm-get-next-pcs.c: Fix common/ includes.
5885         * arch/amd64.c: Fix common/ includes.
5886         * arch/aarch64.c: Fix common/ includes.
5887         * arch/aarch64-insn.c: Fix common/ includes.
5888         * arch-utils.c: Fix common/ includes.
5889         * amd64-windows-tdep.c: Fix common/ includes.
5890         * amd64-tdep.c: Fix common/ includes.
5891         * amd64-sol2-tdep.c: Fix common/ includes.
5892         * amd64-obsd-tdep.c: Fix common/ includes.
5893         * amd64-nbsd-tdep.c: Fix common/ includes.
5894         * amd64-linux-tdep.c: Fix common/ includes.
5895         * amd64-linux-nat.c: Fix common/ includes.
5896         * amd64-fbsd-tdep.c: Fix common/ includes.
5897         * amd64-fbsd-nat.c: Fix common/ includes.
5898         * amd64-dicos-tdep.c: Fix common/ includes.
5899         * amd64-darwin-tdep.c: Fix common/ includes.
5900         * agent.c: Fix common/ includes.
5901         * ada-lang.h: Fix common/ includes.
5902         * ada-lang.c: Fix common/ includes.
5903         * aarch64-tdep.c: Fix common/ includes.
5904
5905 2019-01-25  Tom Tromey  <tom@tromey.com>
5906
5907         * common/create-version.sh: Use common/version.h.
5908
5909 2019-01-24  Pedro Alves  <palves@redhat.com>
5910
5911         * infrun.c (signal_stop, signal_print, signal_program)
5912         (signal_catch, signal_pass): Now arrays instead of pointers.
5913         (update_signals_program_target, do_target_resume)
5914         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5915         * linux-nat.c (linux_nat_target::pass_signals)
5916         (linux_nat_target::create_inferior, linux_nat_target::attach):
5917         Adjust.
5918         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5919         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5920         * procfs.c (procfs_target::pass_signals): Adjust.
5921         * record-full.c (record_full_target::resume): Adjust.
5922         * remote.c (remote_target::pass_signals)
5923         (remote_target::program_signals): Adjust.
5924         * target-debug.h (target_debug_print_signals): Now takes a
5925         gdb::array_view as parameter.  Adjust.
5926         * target.h (target_ops) <pass_signals, program_signals>: Replace
5927         pointer and length parameters with gdb::array_view.
5928         (target_pass_signals, target_program_signals): Likewise.
5929         * target-delegates.c: Regenerate.
5930
5931 2019-01-24  Pedro Alves  <palves@redhat.com>
5932
5933         * common/forward-scope-exit.h
5934         (forward_scope_exit::forward_scope_exit): Pass arguments to
5935         m_bind_function directly, instead of creating a std::bind and
5936         copying that.
5937
5938 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5939
5940         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5941         for static members.
5942         (pass_in_v_vfp_candidate): Likewise.
5943
5944 2019-01-23  Tom Tromey  <tom@tromey.com>
5945             Pedro Alves  <palves@redhat.com>
5946
5947         * regcache.c (class regcache_invalidator): Remove.
5948         (regcache::raw_write): Use make_scope_exit.
5949
5950 2019-01-23  Tom Tromey  <tom@tromey.com>
5951
5952         * ui-out.h (class ui_out_emit_type): Update comment.
5953
5954 2019-01-23  Tom Tromey  <tom@tromey.com>
5955
5956         * infrun.c (fetch_inferior_event): Update comment.
5957
5958 2019-01-23  Tom Tromey  <tom@tromey.com>
5959             Pedro Alves  <palves@redhat.com>
5960
5961         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5962         parameter.
5963         (fetch_inferior_event): Use SCOPE_EXIT.
5964
5965
5966 2019-01-23  Tom Tromey  <tom@tromey.com>
5967             Pedro Alves  <palves@redhat.com>
5968
5969         * infrun.c (disable_thread_events): Delete.
5970         (stop_all_threads): Use SCOPE_EXIT.
5971
5972 2019-01-23  Tom Tromey  <tom@tromey.com>
5973             Pedro Alves  <palves@redhat.com>
5974
5975         * symfile.c: Include forward-scope-exit.h.
5976         (clear_symtab_users_cleanup): Replace forward declaration with
5977         a FORWARD_SCOPE_EXIT.
5978         (syms_from_objfile_1): Use the forward_scope_exit and
5979         gdb::optional instead of cleanup_function.
5980         (reread_symbols): Use the forward_scope_exit instead of
5981         cleanup_function.
5982         (clear_symtab_users_cleanup): Remove function.
5983
5984 2019-01-23  Tom Tromey  <tom@tromey.com>
5985             Pedro Alves  <palves@redhat.com>
5986
5987         * linux-nat.c: Include scope-exit.h.
5988         (cleanup_target_stop): Remove.
5989         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5990         SCOPE_EXIT.
5991
5992 2019-01-23  Tom Tromey  <tom@tromey.com>
5993             Pedro Alves  <palves@redhat.com>
5994
5995         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5996         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5997
5998 2019-01-23  Tom Tromey  <tom@tromey.com>
5999             Andrew Burgess  <andrew.burgess@embecosm.com>
6000             Pedro Alves  <palves@redhat.com>
6001
6002         * infrun.c (fetch_inferior_event): Use scope_exit.
6003         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6004         * top.c (execute_command): Use scope_exit.
6005         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6006         * utils.c (do_bpstat_clear_actions_cleanup)
6007         (make_bpstat_clear_actions_cleanup): Remove.
6008
6009 2019-01-23  Tom Tromey  <tom@tromey.com>
6010             Pedro Alves  <palves@redhat.com>
6011
6012         * infrun.c: Include "common/scope-exit.h"
6013         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6014         (wait_for_inferior): Use SCOPE_EXIT.
6015         (fetch_inferior_event): Use scope_exit.
6016
6017 2019-01-23  Tom Tromey  <tom@tromey.com>
6018             Pedro Alves  <palves@redhat.com>
6019
6020         * breakpoint.c (create_breakpoint): Remove cleanup.
6021
6022 2019-01-23  Tom Tromey  <tom@tromey.com>
6023             Andrew Burgess  <andrew.burgess@embecosm.com>
6024             Pedro Alves  <palves@redhat.com>
6025
6026 2019-01-23  Pedro Alves  <palves@redhat.com>
6027
6028         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6029
6030 2019-01-23  Pedro Alves  <palves@redhat.com>
6031             Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * gdbthread.h: Include "common/forward-scope-exit.h".
6034         (scoped_finish_thread_state): Redefine custom class in terms of
6035         forward_scope_exit.
6036
6037 2019-01-23  Pedro Alves  <palves@redhat.com>
6038             Andrew Burgess  <andrew.burgess@embecosm.com>
6039
6040         * common/forward-scope-exit.h: New file.
6041
6042 2019-01-23  Pedro Alves  <palves@redhat.com>
6043             Andrew Burgess  <andrew.burgess@embecosm.com>
6044             Tom Tromey  <tom@tromey.com>
6045
6046         * common/scope-exit.h: New file.
6047
6048 2019-01-23  Pedro Alves  <palves@redhat.com>
6049
6050         * common/preprocessor.h (ESC): Rename to ...
6051         (ESC_PARENS): ... this.
6052         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6053         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6054
6055 2019-01-23  Tom Tromey  <tom@tromey.com>
6056
6057         * language.h (class scoped_switch_to_sym_language_if_auto):
6058         Initialize m_lang in both cases.
6059
6060 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6061
6062         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6063         with XCNEW.
6064
6065 2019-01-22  Tom Tromey  <tom@tromey.com>
6066
6067         * corelow.c: Do not include sys/file.h.
6068
6069 2019-01-22  Tom Tromey  <tom@tromey.com>
6070
6071         * tui/tui-wingeneral.h: Include gdb_curses.h.
6072
6073 2019-01-22  Tom Tromey  <tom@tromey.com>
6074
6075         * source-cache.h (class source_cache) <get_source_lines,
6076         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6077
6078 2019-01-22  Tom Tromey  <tom@tromey.com>
6079
6080         * remote-fileio.h (struct remote_target): Declare.
6081
6082 2019-01-22  Tom Tromey  <tom@tromey.com>
6083
6084         * python/py-arch.c: Do not include py-ref.h.
6085         * python/py-bpevent.c: Do not include py-ref.h.
6086         * python/py-cmd.c: Do not include py-ref.h.
6087         * python/py-continueevent.c: Do not include py-ref.h.
6088         * python/py-event.h: Do not include py-ref.h.
6089         * python/py-evtregistry.c: Do not include py-ref.h.
6090         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6091         * python/py-frame.c: Do not include py-ref.h.
6092         * python/py-framefilter.c: Do not include py-ref.h.
6093         * python/py-function.c: Do not include py-ref.h.
6094         * python/py-infevents.c: Do not include py-ref.h.
6095         * python/py-linetable.c: Do not include py-ref.h.
6096         * python/py-objfile.c: Do not include py-ref.h.
6097         * python/py-param.c: Do not include py-ref.h.
6098         * python/py-prettyprint.c: Do not include py-ref.h.
6099         * python/py-progspace.c: Do not include py-ref.h.
6100         * python/py-symbol.c: Do not include py-ref.h.
6101         * python/py-symtab.c: Do not include py-ref.h.
6102         * python/py-type.c: Do not include py-ref.h.
6103         * python/py-unwind.c: Do not include py-ref.h.
6104         * python/py-utils.c: Do not include py-ref.h.
6105         * python/py-value.c: Do not include py-ref.h.
6106         * python/py-varobj.c: Do not include py-ref.h.
6107         * python/py-xmethods.c: Do not include py-ref.h.
6108         * python/python.c: Do not include py-ref.h.
6109         * varobj.c: Do not include py-ref.h.
6110
6111 2019-01-22  Tom Tromey  <tom@tromey.com>
6112
6113         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6114         keyword for bcache.
6115
6116 2019-01-22  Tom Tromey  <tom@tromey.com>
6117
6118         * compile/compile-cplus-types.c: Remove a comment by #include.
6119
6120 2019-01-22  Tom Tromey  <tom@tromey.com>
6121
6122         * compile/gcc-c-plugin.h: Include compile-internal.h.
6123
6124 2019-01-22  Tom Tromey  <tom@tromey.com>
6125
6126         * stabsread.c (EXTERN): Do not define.
6127         (symnum, next_symbol_text_func, processing_gcc_compilation)
6128         (within_function, global_sym_chain, global_stabs)
6129         (previous_stab_code, this_object_header_files)
6130         (n_this_object_header_files)
6131         (n_allocated_this_object_header_files): Define.
6132         * stabsread.h (EXTERN): Never define.  Use "extern".
6133
6134 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6135
6136         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6137         history_value.
6138
6139 2019-01-21  Tom Tromey  <tom@tromey.com>
6140
6141         * ui-out.c: Fix includes.
6142         * tui/tui-source.c: Fix includes.
6143         * target.c: Fix includes.
6144         * remote.c: Fix includes.
6145         * regcache.c: Fix includes.
6146         * python/py-block.c: Fix includes.
6147         * printcmd.c: Fix includes.
6148         * or1k-tdep.c: Fix includes.
6149         * mi/mi-main.c: Fix includes.
6150         * m32r-tdep.c: Fix includes.
6151         * csky-tdep.c: Fix includes.
6152         * compile/compile-cplus-types.c: Fix includes.
6153         * cli/cli-interp.c: Fix includes.
6154
6155 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6156
6157         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6158         for padding.
6159
6160 2019-01-16  Tom Tromey  <tom@tromey.com>
6161
6162         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6163         earlier.
6164         (struct objfile) <msymbols_range>: Move from top level.
6165         <msymbols>: New method.
6166         (class objfile_msymbols): Remove.
6167         * symtab.c (default_collect_symbol_completion_matches_break_on):
6168         Update.
6169         * symmisc.c (dump_msymbols): Update.
6170         * stabsread.c (scan_file_globals): Update.
6171         * objc-lang.c (info_selectors_command, info_classes_command)
6172         (find_methods): Update.
6173         * minsyms.c (find_solib_trampoline_target): Update.
6174         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6175         * coffread.c (coff_symfile_read): Update.
6176         * ada-lang.c (ada_lookup_simple_minsym)
6177         (ada_collect_symbol_completion_matches): Update.
6178
6179 2019-01-16  Tom Tromey  <tom@tromey.com>
6180
6181         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6182         type.  Remove no-argument constructor.
6183         <iterator::operator++>: Simplify.
6184         <begin>: Update.
6185         <end>: Use minimal_symbol_count.
6186
6187 2019-01-16  Tom Tromey  <tom@tromey.com>
6188
6189         * objfiles.h (struct objfile) <psymtabs>: New method.
6190         (class objfile_psymtabs): Remove.
6191         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6192         typedef.
6193         <range>: New method.
6194         (require_partial_symbols): Change return type.
6195         * psymtab.c (require_partial_symbols)
6196         (psym_expand_symtabs_matching): Update.
6197         * mdebugread.c (parse_partial_symbols): Update.
6198         * dbxread.c (dbx_end_psymtab): Update.
6199
6200 2019-01-15  Tom Tromey  <tom@tromey.com>
6201
6202         * symtab.c (lookup_objfile_from_block)
6203         (lookup_symbol_in_objfile_symtabs)
6204         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6205         (find_line_symtab, info_sources_command)
6206         (default_collect_symbol_completion_matches_break_on)
6207         (make_source_files_completion_list): Update.
6208         * symmisc.c (print_objfile_statistics, dump_objfile)
6209         (maintenance_print_symbols, maintenance_info_symtabs)
6210         (maintenance_check_symtabs, maintenance_info_line_tables):
6211         Update.
6212         * source.c (select_source_symtab)
6213         (forget_cached_source_info_for_objfile): Update.
6214         * objfiles.h (class objfile_compunits): Remove.
6215         (struct objfile) <compunits_range>: New typedef.
6216         (compunits): New method.
6217         * objfiles.c (objfile_relocate1): Update.
6218         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6219         * maint.c (count_symtabs_and_blocks): Update.
6220         * linespec.c (iterate_over_all_matching_symtabs): Update.
6221         * cp-support.c (add_symbol_overload_list_qualified): Update.
6222         * coffread.c (coff_symtab_read): Update.
6223         * ada-lang.c (add_nonlocal_symbols)
6224         (ada_collect_symbol_completion_matches)
6225         (ada_add_global_exceptions): Update.
6226
6227 2019-01-15  Tom Tromey  <tom@tromey.com>
6228
6229         * progspace.h (program_space) <objfiles_safe_range>: New
6230         typedef.
6231         <objfiles_safe>: New method.
6232         * objfiles.h (class all_objfiles_safe): Remove.
6233         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6234         * jit.c (jit_inferior_exit_hook): Update.
6235
6236 2019-01-17  Tom Tromey  <tom@tromey.com>
6237
6238         * progspace.h (program_space) <objfiles_range>: New typedef.
6239         <objfiles>: New method.
6240         <objfiles_head>: Rename from objfiles.
6241         (object_files): Update.
6242         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6243         * guile/scm-pretty-print.c
6244         (ppscm_find_pretty_printer_from_objfiles): Update.
6245         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6246         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6247         Update.
6248         * python/py-progspace.c (pspy_get_objfiles): Update.
6249         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6250         Update.
6251         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6252         (objfpy_lookup_objfile_by_build_id): Update.
6253         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6254         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6255         Update.
6256         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6257         (expand_symtab_containing_pc, lookup_objfile_from_block)
6258         (lookup_static_symbol, basic_lookup_transparent_type)
6259         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6260         (find_line_symtab, info_sources_command)
6261         (default_collect_symbol_completion_matches_break_on)
6262         (make_source_files_completion_list, find_main_name): Update.
6263         * symmisc.c (print_symbol_bcache_statistics)
6264         (print_objfile_statistics, maintenance_print_symbols)
6265         (maintenance_print_msymbols, maintenance_print_objfiles)
6266         (maintenance_info_symtabs, maintenance_check_symtabs)
6267         (maintenance_expand_symtabs, maintenance_info_line_tables):
6268         Update.
6269         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6270         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6271         (map_overlay_command, unmap_overlay_command)
6272         (simple_overlay_update, expand_symtabs_matching)
6273         (map_symbol_filenames): Update.
6274         * symfile-debug.c (set_debug_symfile): Update.
6275         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6276         Update.
6277         * source.c (select_source_symtab, forget_cached_source_info):
6278         Update.
6279         * solib.c (solib_read_symbols): Update.
6280         * solib-spu.c (append_ocl_sos): Update.
6281         * psymtab.c (maintenance_print_psymbols)
6282         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6283         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6284         * printcmd.c (info_symbol_command): Update.
6285         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6286         Update.
6287         * objfiles.h (class all_objfiles): Remove.
6288         * objfiles.c (have_partial_symbols, have_full_symbols)
6289         (have_minimal_symbols, qsort_cmp, update_section_map)
6290         (shared_objfile_contains_address_p)
6291         (default_iterate_over_objfiles_in_search_order): Update.
6292         * objc-lang.c (info_selectors_command, info_classes_command)
6293         (find_methods): Update.
6294         * minsyms.c (find_solib_trampoline_target): Update.
6295         * maint.c (maintenance_info_sections)
6296         (maintenance_translate_address, count_symtabs_and_blocks):
6297         Update.
6298         * main.c (captured_main_1): Update.
6299         * linux-thread-db.c (try_thread_db_load_from_pdir)
6300         (has_libpthread): Update.
6301         * linespec.c (iterate_over_all_matching_symtabs)
6302         (search_minsyms_for_name): Update.
6303         * jit.c (jit_find_objf_with_entry_addr): Update.
6304         * hppa-tdep.c (find_unwind_entry)
6305         (hppa_lookup_stub_minimal_symbol): Update.
6306         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6307         Update.
6308         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6309         (elf_gnu_ifunc_resolve_by_got): Update.
6310         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6311         * dwarf-index-write.c (save_gdb_index_command): Update.
6312         * cp-support.c (add_symbol_overload_list_qualified): Update.
6313         * breakpoint.c (create_overlay_event_breakpoint)
6314         (create_longjmp_master_breakpoint)
6315         (create_std_terminate_master_breakpoint)
6316         (create_exception_master_breakpoint): Update.
6317         * blockframe.c (find_pc_partial_function): Update.
6318         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6319         (ada_collect_symbol_completion_matches)
6320         (ada_add_global_exceptions): Update.
6321
6322 2019-01-17  Tom Tromey  <tom@tromey.com>
6323
6324         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6325         declare VEC.
6326         (solib_target_parse_libraries): Change return type.
6327         (library_list_start_segment, library_list_start_section)
6328         (library_list_end_library, library_list_start_library); Update.
6329         (solib_target_free_library_list): Remove.
6330         (solib_target_parse_libraries): Remove cleanup.  Change return
6331         type.
6332         (solib_target_current_sos): Update.
6333
6334 2019-01-17  Tom Tromey  <tromey@bapiya>
6335
6336         * valprint.c: Replace "the the" with "the".
6337         * symtab.c: Replace "the the" with "the".
6338         * solib.c: Replace "the the" with "the".
6339         * solib-dsbt.c: Replace "the the" with "the".
6340         * linespec.c: Replace "the the" with "the".
6341         * dwarf2loc.h: Replace "the the" with "the".
6342         * amd64-windows-tdep.c: Replace "the the" with "the".
6343         * aarch64-tdep.c: Replace "the the" with "the".
6344
6345 2019-01-16  Keith Seitz  <keiths@redhat.com>
6346
6347         PR gdb/23773
6348         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6349         <builder>: Rename to ..
6350         <m_builder>: ... this and make private.
6351         (dwarf2_cu::get_builder): New method.  Change all users of
6352         `builder' to use this method.
6353         (dwarf2_start_symtab): Move to ...
6354         (dwarf2_cu::start_symtab): ... here.  Update all callers
6355         (setup_type_unit_groups): Move to ...
6356         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6357         callers.
6358         (dwarf2_cu::reset_builder): New method.
6359         (process_full_compunit, process_full_type_unit): Use
6360         dwarf2_cu::reset_builder.
6361         (follow_die_offset): Record the ancestor CU if it is different
6362         from the followed DIE's CU.
6363         (follow_die_sig_1): Likewise.
6364
6365 2019-01-15  Tom Tromey  <tom@tromey.com>
6366
6367         * remote.c (class remote_state) <buf>: Now a char_vector.
6368         <buf_size>: Remove.
6369         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6370         parameter.
6371         (remote_target::getpkt_or_notif_sane_1)
6372         (remote_target::getpkt_sane)
6373         (remote_target::getpkt_or_notif_sane): Likewise.
6374         (class remote_target) <putpkt>: New overload.
6375         (remote_target::read_frame): Change type of "buf_p".  Remove
6376         sizeof_p parameter.
6377         (packet_ok): New overload.
6378         (packet_check_result): New overload.
6379         Update all uses.
6380
6381 2019-01-14  Tom Tromey  <tom@tromey.com>
6382
6383         * remote-notif.c (handle_notification, remote_notif_ack)
6384         (remote_notif_parse): Make "buf" const.
6385         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6386         const.
6387         (remote_notif_parse, remote_notif_ack, handle_notification):
6388         Likewise.
6389         * remote.c (remote_notif_stop_parse): Make "buf" const.
6390         (remote_target::remote_parse_stop_reply): Make "buf" const.
6391         (remote_notif_stop_ack): Make "buf" const.
6392
6393 2019-01-14  Tom Tromey  <tom@tromey.com>
6394
6395         * remote.c (remote_console_output): Make parameter const.
6396
6397 2019-01-14  Tom Tromey  <tom@tromey.com>
6398
6399         * target-debug.h (target_debug_print_signals): Constify.
6400         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6401         * procfs.c (procfs_target::pass_signals): Update.
6402         * linux-nat.c (linux_nat_target::pass_signals): Update.
6403         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6404         * target-delegates.c: Rebuild.
6405         * remote.c (remote_target::program_signals): Update.
6406         (remote_target::pass_signals): Update.
6407         * target.c (target_pass_signals): Constify argument.
6408         (target_program_signals): Likewise.
6409         * target.h (struct target_ops) <pass_signals, program_signals>:
6410         Constify argument.
6411         (target_pass_signals, target_program_signals): Constify argument.
6412
6413 2019-01-14  Tom Tromey  <tom@tromey.com>
6414
6415         PR tui/28819:
6416         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6417
6418 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6419
6420         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6421         field.
6422         * rs6000-tdep.c: Include reggroups.h.
6423         (IS_V_ALIAS_PSEUDOREG): Define.
6424         (rs6000_register_name): Return names for the "vX" aliases.
6425         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6426         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6427         aliases.  Call default_register_reggroup_p for all other
6428         pseudo-registers.
6429         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6430         New functions.
6431         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6432         Handle "vX" aliases.
6433         (v_alias_pseudo_register_collect): New function.
6434         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6435         (rs6000_gdbarch_init): Initialize "vX" aliases as
6436         pseudo-registers.  Restore registration of
6437         rs6000_pseudo_register_reggroup_p with
6438         set_tdesc_pseudo_register_reggroup_p.
6439
6440 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6441
6442         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6443         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6444         set_gdbarch_num_pseudo_regs.
6445
6446 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6447
6448         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6449         Remove arg prefixname, add do_set and do_show.
6450         Add member functions set_list and show_list.
6451         * cli/cli-style.c (class cli_style_option): Update accordingly.
6452         (style_set_list): Move to file scope.
6453         (style_show_list): Likewise.
6454         (set_style): Call help_list.
6455         (show_style): Call cmd_show_list.
6456         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6457         Update to use the new macro.
6458
6459 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6460
6461         * ada-lang.c (_initialize_ada_language): Expand the help text
6462         for the "catch exception" command.
6463
6464 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6465
6466         * symtab.c (matching_obj_sections): Initialize obj,
6467         declare it closer to its usage.
6468
6469 2019-01-10  Tom Tromey  <tom@tromey.com>
6470
6471         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6472         (basic_inf_threads_range): Remove.
6473         (inf_threads_range, inf_non_exited_threads_range)
6474         (safe_inf_threads_range): Use next_adapter.
6475
6476 2019-01-10  Keith Seitz  <keiths@redhat.com>
6477
6478         PR gdb/23712
6479         PR symtab/23010
6480         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6481         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6482
6483 2019-01-10  Keith Seitz  <keiths@redhat.com>
6484
6485         PR gdb/23712
6486         PR symtab/23010
6487         * dictionary.c (pending_to_vector): Remove.
6488         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6489         Remove _1 suffix, replacing functions of the same name.  Update
6490         all callers.
6491         (dict_create_hashed, dict_create_hashed_expandable)
6492         (dict_create_linear, dict_create_linear_expandable, dict_free)
6493         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6494         Make functions static.
6495
6496 2019-01-10  Keith Seitz  <keiths@redhat.com>
6497
6498         PR gdb/23712
6499         PR symtab/23010
6500         * dictionary.h (struct dictionary): Replace declaration with
6501         multidictionary.
6502         (dict_create_hashed, dict_create_hashed_expandable)
6503         (dict_create_linear, dict_create_linear_expandable)
6504         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6505         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6506         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6507         taking multidictionary argument.
6508         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6509         * block.h (struct block) <dict>: Change to multidictionary
6510         and rename `multidict'.
6511         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6512         symmisc.c: Update all dictionary references to multidictionary.
6513
6514 2019-01-10  Keith Seitz  <keiths@redhat.com>
6515
6516         PR gdb/23712
6517         PR symtab/23010
6518         * dictionary.c: Include unordered_map.
6519         (pending_to_vector): New function.
6520         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6521         Rewrite the non-"_1" functions to take vector instead
6522         of linked list.
6523         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6524         "new" _1 versions of the same name.
6525         (multidictionary): Define.
6526         (std::hash<enum language): New definition.
6527         (collate_pending_symbols_by_language, mdict_create_hashed)
6528         (mdict_create_hashed_expandable, mdict_create_linear)
6529         (mdict_create_linear_expandable, mdict_free)
6530         (find_language_dictionary, create_new_language_dictionary)
6531         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6532         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6533         (mdict_size, mdict_empty): New functions.
6534         * dictionary.h (mdict_iterator): Define.
6535
6536 2019-01-10  Pedro Alves  <palves@redhat.com>
6537
6538         * breakpoint.c (read_uploaded_action)
6539         (create_tracepoint_from_upload): Adjust to use
6540         gdb::unique_xmalloc_ptr.
6541         * ctf.c (ctf_write_uploaded_tp):
6542         (SET_ARRAY_FIELD): Use emplace_back.
6543         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6544         * tracefile-tfile.c (tfile_write_uploaded_tp):
6545         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6546         gdb::unique_xmalloc_ptr.
6547         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6548         at_string, cond_string, cmd_strings>: Replace char pointers
6549         with gdb::unique_xmalloc_ptr.
6550
6551 2019-01-10  Pedro Alves  <palves@redhat.com>
6552
6553         * solib-target.c (library_list_start_library): Don't xstrdup name.
6554
6555 2019-01-10  Pedro Alves  <palves@redhat.com>
6556
6557         * mdebugread.c (parse_partial_symbols): Use
6558         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6559
6560 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6561
6562         * linux-fork.c (scoped_switch_fork_info)
6563         <~scoped_switch_fork_info>: Fix incorrect variable name.
6564
6565 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6566
6567         * linux-fork.c (scoped_switch_fork_info)
6568         <scoped_switch_fork_info>: Make explicit.
6569         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6570
6571 2019-01-10  Tom Tromey  <tom@tromey.com>
6572
6573         * objfiles.h (objfile::reset_psymtabs): Update.
6574         * objfiles.c (objfile::objfile): Update.
6575         * psymtab.h (psymtab_storage::obstack): Update.
6576         (psymtab_storage::m_obstack): Use gdb::optional.
6577         (class psymtab_storage): Update comment.  Remove objfile
6578         parameter.
6579         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6580
6581 2019-01-10  Tom Tromey  <tom@tromey.com>
6582
6583         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6584         <free_psymtabs>: Now private.
6585         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6586         (allocate_psymtab): Use new method.
6587
6588 2019-01-10  Tom Tromey  <tom@tromey.com>
6589
6590         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6591         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6592         * mdebugread.c (parse_partial_symbols): Use
6593         allocate_dependencies.
6594         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6595         allocate_dependencies.
6596         (process_psymtab_comp_unit_reader)
6597         (build_type_psymtab_dependencies): Likewise.
6598         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6599
6600 2019-01-10  Tom Tromey  <tom@tromey.com>
6601
6602         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6603         PSYMBOL_SET_LANGUAGE.
6604         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6605
6606 2019-01-10  Tom Tromey  <tom@tromey.com>
6607
6608         * psymtab.h (psymtab_storage::obstack): New method.
6609         <m_obstack>: Rename from obstack; now private.
6610         * psymtab.c (psymtab_storage): Update.
6611         * dwarf2read.c (create_addrmap_from_index)
6612         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6613         Update.
6614
6615 2019-01-10  Tom Tromey  <tom@tromey.com>
6616
6617         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6618         * objfiles.h (objfile::reset_psymtabs): New method.
6619
6620 2019-01-10  Tom Tromey  <tom@tromey.com>
6621
6622         * symmisc.c (print_symbol_bcache_statistics): Update.
6623         (print_objfile_statistics): Update.
6624         * symfile.c (reread_symbols): Update.
6625         * psymtab.h (class psymtab_storage): New.
6626         * psymtab.c (psymtab_storage): New constructor.
6627         (~psymtab_storage): New destructor.
6628         (require_partial_symbols): Update.
6629         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6630         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6631         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6632         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6633         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6634         (start_psymtab_common, end_psymtab_common)
6635         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6636         (allocate_psymtab): Update.
6637         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6638         Update.
6639         (dump_psymtab_addrmap, maintenance_print_psymbols)
6640         (maintenance_check_psymtabs): Update.
6641         (class objfile_psymtabs): Move to objfiles.h.
6642         * psympriv.h (discard_psymtab): Now inline.
6643         (psymtab_discarder::psymtab_discarder): Update.
6644         (psymtab_discarder::~psymtab_discarder): Update.
6645         (ALL_OBJFILE_PSYMTABS): Rewrite.
6646         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6647         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6648         Remove fields.
6649         <partial_symtabs>: New field.
6650         (class objfile_psymtabs): Move from psymtab.h.  Update.
6651         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6652         psymbol_cache.
6653         (objfile::~objfile): Don't destroy psymbol_cache.
6654         * mdebugread.c (parse_partial_symbols): Update.
6655         * dwarf2read.c (create_addrmap_from_index)
6656         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6657         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6658         (add_partial_subprogram, dwarf2_ranges_read): Update.
6659         * dwarf-index-write.c (write_address_map)
6660         (write_one_signatured_type, recursively_write_psymbols)
6661         (class debug_names, class debug_names, write_psymtabs_to_index):
6662         Update.
6663
6664 2019-01-10  Tom Tromey  <tom@tromey.com>
6665
6666         * symtab.h (SYMBOL_SET_NAMES): Update.
6667         (symbol_set_names): Update.
6668         (MSYMBOL_SET_NAMES): Update.
6669         * symtab.c (symbol_set_names): Change argument to be an
6670         objfile_per_bfd_storage.
6671         * psymtab.c (add_psymbol_to_bcache): Update.
6672         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6673
6674 2019-01-10  Tom Tromey  <tom@tromey.com>
6675
6676         * symtab.c (create_demangled_names_hash): Change argument to be an
6677         objfile_per_bfd_storage.
6678         (symbol_set_names): Update.
6679
6680 2019-01-10  Tom Tromey  <tom@tromey.com>
6681
6682         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6683         init_psymbol_list.
6684         * psymtab.c (init_psymbol_list): Do nothing if already called.
6685         * psympriv.h (init_psymbol_list): Add comment.
6686         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6687         init_psymbol_list.
6688         * dbxread.c (dbx_symfile_read): Unconditionally call
6689         init_psymbol_list.
6690
6691 2019-01-10  Tom Tromey  <tom@tromey.com>
6692
6693         * xcoffread.c (scan_xcoff_symtab): Update.
6694         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6695         "where".
6696         * mdebugread.c (parse_partial_symbols)
6697         (handle_psymbol_enumerators): Update.
6698         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6699         * dbxread.c (read_dbx_symtab): Update.
6700         * psympriv.h (psymbol_placement): New enum.
6701         (add_psymbol_to_list): Update.
6702
6703 2019-01-10  Tom Tromey  <tom@tromey.com>
6704
6705         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6706         static_psymbols parameters.
6707         (scan_xcoff_symtab): Update.
6708         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6709         static_psymbols parameters.
6710         * psympriv.h (start_psymtab_common): Update.
6711         * mdebugread.c (parse_partial_symbols): Update.
6712         * dwarf2read.c (create_partial_symtab): Update.
6713         * dbxread.c (read_dbx_symtab): Update.
6714         (start_psymtab): Remove global_psymbols and static_psymbols
6715         parameters.
6716
6717 2019-01-10  Tom Tromey  <tom@tromey.com>
6718
6719         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6720         * psymtab.c (allocate_psymtab): Add comment.
6721         * psympriv.h (allocate_psymtab): Add comment.
6722         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6723         initializations.
6724         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6725
6726 2019-01-10  Tom Tromey  <tom@tromey.com>
6727
6728         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6729         Don't declare.
6730         * mipsread.c: Include mdebugread.h.
6731         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6732         Declare.
6733         * elfread.c: Include mdebugread.h.
6734
6735 2019-01-09  Tom Tromey  <tom@tromey.com>
6736
6737         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6738         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6739         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6740         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6741         (psym_lookup_symbol, psym_find_last_source_symtab)
6742         (psym_forget_cached_source_info, psym_print_stats)
6743         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6744         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6745         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6746         (psym_find_compunit_symtab_by_address)
6747         (maintenance_print_psymbols, maintenance_info_psymtabs)
6748         (maintenance_check_psymtabs): Use ranged for.
6749         * psymtab.h (class objfile_psymtabs): New.
6750         (require_partial_symbols): Return objfile_psymtabs.
6751         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6752
6753 2019-01-09  Tom Tromey  <tom@tromey.com>
6754
6755         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6756         (find_pc_mapped_section, list_overlays_command)
6757         (map_overlay_command, unmap_overlay_command)
6758         (simple_overlay_update): Use all_objfiles.
6759         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6760         * printcmd.c (info_symbol_command): Use all_objfiles.
6761         * objfiles.h (ALL_OBJSECTIONS): Remove.
6762         * maint.c (maintenance_translate_address): Use all_objfiles.
6763         * gcore.c (gcore_create_callback): Use all_objfiles.
6764         (objfile_find_memory_regions): Likewise.
6765
6766 2019-01-09  Tom Tromey  <tom@tromey.com>
6767
6768         * symtab.c (find_line_symtab, info_sources_command)
6769         (make_source_files_completion_list): Use objfile_compunits.
6770         * source.c (select_source_symtab): Use objfile_compunits.
6771         * objfiles.h (struct objfile): Update comment.
6772         (ALL_OBJFILES): Remove.
6773         (ALL_FILETABS): Remove.
6774         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6775         objfile_compunits.
6776
6777 2019-01-09  Tom Tromey  <tom@tromey.com>
6778
6779         * symmisc.c (print_objfile_statistics, dump_objfile)
6780         (maintenance_print_symbols): Use compunit_filetabs.
6781         * source.c (forget_cached_source_info_for_objfile): Use
6782         compunit_filetabs.
6783         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6784         (ALL_FILETABS): Use compunit_filetabs.
6785         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6786         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6787
6788 2019-01-09  Tom Tromey  <tom@tromey.com>
6789
6790         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6791         (compunit_filetabs): New.
6792         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6793         compunit_filetabs.
6794         (info_sources_command, make_source_files_completion_list): Remove
6795         declaration.
6796         * symmisc.c (print_objfile_statistics, dump_objfile)
6797         (maintenance_print_symbols): Remove declaration.
6798         (maintenance_info_symtabs): Use compunit_filetabs.
6799         (maintenance_info_line_tables): Likewise.
6800         * source.c (select_source_symtab): Change local variable name.
6801         (forget_cached_source_info_for_objfile): Remove declaration.
6802         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6803         * objfiles.c (objfile_relocate1): Remove declaration.
6804         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6805         declaration.
6806         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6807         * coffread.c (coff_symtab_read): Remove declaration.
6808         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6809         compunit_filetabs.
6810
6811 2019-01-09  Tom Tromey  <tom@tromey.com>
6812
6813         * symtab.c (lookup_objfile_from_block)
6814         (find_pc_sect_compunit_symtab, search_symbols)
6815         (default_collect_symbol_completion_matches_break_on): Use
6816         objfile_compunits.
6817         * objfiles.h (ALL_COMPUNITS): Remove.
6818         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6819         * cp-support.c (add_symbol_overload_list_qualified): Use
6820         objfile_compunits.
6821         * ada-lang.c (ada_collect_symbol_completion_matches)
6822         (ada_add_global_exceptions): Use objfile_compunits.
6823
6824 2019-01-09  Tom Tromey  <tom@tromey.com>
6825
6826         * source.c (select_source_symtab)
6827         (forget_cached_source_info_for_objfile): Remove declaration.
6828         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6829         declaration.
6830         * maint.c (count_symtabs_and_blocks): Remove declaration.
6831         * cp-support.c (add_symbol_overload_list_qualified): Remove
6832         declaration.
6833         * coffread.c (coff_symtab_read): Remove declaration.
6834         * symtab.c (lookup_symbol_in_objfile_symtabs)
6835         (basic_lookup_transparent_type_1): Use objfile_compunits.
6836         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6837         (info_sources_command, search_symbols)
6838         (default_collect_symbol_completion_matches_break_on)
6839         (make_source_files_completion_list): Remove declaration.
6840         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6841         (ada_collect_symbol_completion_matches)
6842         (ada_add_global_exceptions): Remove declaration.
6843         * linespec.c (iterate_over_all_matching_symtabs): Use
6844         objfile_compunits.
6845         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6846         (class objfile_compunits): New.
6847         (ALL_COMPUNITS): Use objfile_compunits.
6848         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6849         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6850         objfile_compunits.
6851         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6852
6853 2019-01-09  Tom Tromey  <tom@tromey.com>
6854
6855         * symtab.c (search_symbols)
6856         (default_collect_symbol_completion_matches_break_on): Use
6857         objfile_msymbols.
6858         * ada-lang.c (ada_lookup_simple_minsym)
6859         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6860         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6861         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6862         objfile_msymbols.
6863         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6864         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6865         * objc-lang.c (find_methods): Use objfile_msymbols.
6866         (info_selectors_command, info_classes_command): Likewise.
6867         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6868         * objfiles.h (class objfile_msymbols): New.
6869         (ALL_OBJFILE_MSYMBOLS): Remove.
6870         (ALL_MSYMBOLS): Remove.
6871
6872 2019-01-09  Tom Tromey  <tom@tromey.com>
6873
6874         * common/next-iterator.h (next_adapter): Add Iterator template
6875         parameter.
6876         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6877         (class all_objfiles_safe): New.
6878         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6879         * objfiles.c (put_objfile_before): Update comment.
6880         (add_separate_debug_objfile): Likewise.
6881         (free_all_objfiles): Use all_objfiles_safe.
6882         (objfile_purge_solibs): Likewise.
6883
6884 2019-01-09  Tom Tromey  <tom@tromey.com>
6885
6886         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6887         (expand_symtab_containing_pc, lookup_static_symbol)
6888         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6889         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6890         all_objfiles.
6891         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6892         * breakpoint.c (create_overlay_event_breakpoint)
6893         (create_longjmp_master_breakpoint)
6894         (create_std_terminate_master_breakpoint)
6895         (create_exception_master_breakpoint): Use all_objfiles.
6896         * linux-thread-db.c (try_thread_db_load_from_pdir)
6897         (has_libpthread): Use all_objfiles.
6898         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6899         * linespec.c (iterate_over_all_matching_symtabs)
6900         (search_minsyms_for_name): Use all_objfiles.
6901         * maint.c (maintenance_info_sections): Use all_objfiles.
6902         * main.c (captured_main_1): Use all_objfiles.
6903         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6904         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6905         * guile/scm-pretty-print.c
6906         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6907         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6908         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6909         (maintenance_print_msymbols): Use all_objfiles.
6910         * source.c (select_source_symtab): Use all_objfiles.
6911         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6912         * symfile.c (remove_symbol_file_command)
6913         (expand_symtabs_matching, map_symbol_filenames): Use
6914         all_objfiles.
6915         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6916         all_objfiles.
6917         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6918         * objc-lang.c (find_methods): Use all_objfiles.
6919         * objfiles.c (have_partial_symbols, have_full_symbols)
6920         (have_minimal_symbols, qsort_cmp)
6921         (default_iterate_over_objfiles_in_search_order): Use
6922         all_objfiles.
6923         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6924         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6925         (maintenance_check_psymtabs): Use all_objfiles.
6926         (ALL_PSYMTABS): Remove.
6927         * compile/compile-object-run.c (do_module_cleanup): Use
6928         all_objfiles.
6929         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6930         * cp-support.c (add_symbol_overload_list_qualified): Use
6931         all_objfiles.
6932         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6933         Use all_objfiles.
6934         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6935         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6936         all_objfiles.
6937         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6938         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6939         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6940         Uses all_objfiles.
6941         * solib.c (solib_read_symbols): Use all_objfiles
6942
6943 2019-01-09  Tom Tromey  <tom@tromey.com>
6944
6945         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6946         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6947         all_objfiles.
6948         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6949         * symmisc.c (print_symbol_bcache_statistics)
6950         (print_objfile_statistics, maintenance_print_objfiles)
6951         (maintenance_info_symtabs, maintenance_check_symtabs)
6952         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6953         all_objfiles.
6954         * source.c (forget_cached_source_info): Use all_objfiles.
6955         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6956         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6957         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6958         * objfiles.c (update_section_map): Use all_objfiles.
6959         (shared_objfile_contains_address_p): Likewise.
6960         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6961         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6962
6963 2019-01-09  Tom Tromey  <tom@tromey.com>
6964
6965         * common/next-iterator.h: New file.
6966         * objfiles.h (class all_objfiles): New.
6967         (struct objfile_iterator): New.
6968
6969 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6970
6971         * NEWS: Move the description of the changed "frame", "select-frame",
6972          and "info frame" commands to the Changed commands section.
6973
6974 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6975
6976         * gdbtypes.c (check_stub_method_group): Remove handling of old
6977         mangling schemes.
6978         * linespec.c (find_methods): Likewise.
6979         * stabsread.c (read_member_functions): Likewise.
6980         * valops.c (search_struct_method): Likewise.
6981         (value_struct_elt_for_reference): Likewise.
6982         * NEWS: Mention this change.
6983
6984 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6987         print_source_lines.
6988         * source.c (print_source_lines_base): Update line number check.
6989         (print_source_lines): New function.
6990         (source_lines_range::source_lines_range): New function.
6991         * source.h (class source_lines_range): New class.
6992         (print_source_lines): New declaration.
6993
6994 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6995
6996         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6997
6998 2019-01-08  Tom Tromey  <tom@tromey.com>
6999             Simon Marchi  <simon.marchi@ericsson.com>
7000
7001         PR gdb/24060
7002         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7003         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7004         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7005         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7006         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7007         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7008
7009 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * source.c (select_source_symtab): Move header comment to
7012         declaration in source.h.
7013         (forget_cached_source_info_for_objfile): Likewise.
7014         (forget_cached_source_info): Likewise.
7015         (identify_source_line): Likewise.
7016         * source.h (identify_source_line): Move declaration from symtab.h
7017         and add comment from source.c
7018         (print_source_lines): Likewise.
7019         (forget_cached_source_info_for_objfile): Likewise.
7020         (forget_cached_source_info): Likewise.
7021         (select_source_symtab): Likewise.
7022         (enum print_source_lines_flag): Move definition from symtab.h.
7023         * symtab.h (identify_source_line): Move declaration to source.h.
7024         (print_source_lines): Likewise.
7025         (forget_cached_source_info_for_objfile): Likewise.
7026         (forget_cached_source_info): Likewise.
7027         (select_source_symtab): Likewise.
7028         (enum print_source_lines_flag): Move definition to source.h.
7029         * tui/tui-hooks.c: Add 'source.h' include.
7030
7031 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * source.c (print_source_lines_base): Handle requests to print
7034         reverse line number sequences, and guard against empty lines
7035         string.
7036
7037 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * source.c (print_source_lines_base): Fix skip of '\r' if next
7040         character is '\n'.
7041
7042 2019-01-06  Tom Tromey  <tom@tromey.com>
7043
7044         * c-exp.y (struct c_parse_state) <macro_original_text,
7045         expansion_obstack>: New member.
7046         (macro_original_text, expansion_obstack): Remove globals.
7047         (scan_macro_expansion, scanning_macro_expansion)
7048         (finished_macro_expansion): Update.
7049         (scan_macro_cleanup): Remove.
7050         (yylex, c_parse): Update.
7051
7052 2019-01-06  Tom Tromey  <tom@tromey.com>
7053
7054         * c-exp.y (struct c_parse_state) <strings>: New member.
7055         (operator_stoken): Update.
7056
7057 2019-01-06  Tom Tromey  <tom@tromey.com>
7058
7059         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7060         (union type_stack_elt) <typelist_val>: Now a pointer to
7061         std::vector.
7062         (type_stack_cleanup): Don't declare.
7063         (push_typelist): Update.
7064         * parse.c (pop_typelist): Return a std::vector.
7065         (push_typelist): Take a std::vector.
7066         (follow_types): Update.  Do not free args.
7067         (type_stack_cleanup): Remove.
7068         * c-exp.y (struct c_parse_state): New.
7069         (cpstate): New global.
7070         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7071         (nonempty_typelist): Update.
7072         (func_mod): Create a new vector.
7073         (c_parse): Create a c_parse_state.
7074         (check_parameter_typelist): Do not delete params.
7075         (function_method): Update.  Do not delete type_list.
7076
7077 2019-01-06  Tom Tromey  <tom@tromey.com>
7078
7079         PR gdb/28155:
7080         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7081         check_typedef.
7082         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7083         (print_return_value): Likewise.
7084
7085 2019-01-05  Tom Tromey  <tom@tromey.com>
7086
7087         * contrib/cleanup_check.py: Remove.
7088         * contrib/gcc-with-excheck: Remove.
7089         * contrib/exsummary.py: Remove.
7090         * contrib/excheck.py: Remove.
7091
7092 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7093
7094         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7095         NULL. Initialize tpprev to NULL instead of assigning it
7096         to NULL on the next statement.
7097         * windows-nat.c (windows_delete_thread): Remove check for
7098         main_thread_id before printing thread exit notifications.
7099         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7100         Remove thread ID check against main_thread_id.
7101         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7102         windows_delete_thread.
7103         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7104
7105 2019-01-04  Tom Tromey  <tom@tromey.com>
7106
7107         * compile/compile.c (_initialize_compile): Use upper case for
7108         metasyntactic variables.
7109         * symmisc.c (_initialize_symmisc): Use upper case for
7110         metasyntactic variables.
7111         * psymtab.c (_initialize_psymtab): Use upper case for
7112         metasyntactic variables.
7113         * demangle.c (demangle_command): Use upper case for metasyntactic
7114         variables.
7115         (_initialize_demangler): Likewise.
7116         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7117         variables.
7118
7119 2019-01-03  Tom Tromey  <tom@tromey.com>
7120
7121         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7122
7123 2019-01-03  Tom Tromey  <tom@tromey.com>
7124
7125         * python/py-symtab.c (salpy_str): Update.
7126         (struct salpy_sal_object) <symtab>: Now a PyObject.
7127         (salpy_dealloc): Update.
7128         (del_objfile_sal): Use gdbpy_ref.
7129
7130 2019-01-03  Tom Tromey  <tom@tromey.com>
7131
7132         * python/py-type.c (convert_field): Use new_reference.  Return
7133         gdbpy_ref.
7134         (make_fielditem): Return gdbpy_ref.
7135         (typy_fields): Update.
7136         (typy_getitem): Update.
7137         (field_name): Return gdbpy_ref.  Use new_reference.
7138         (typy_iterator_iternext): Update.
7139
7140 2019-01-03  Tom Tromey  <tom@tromey.com>
7141
7142         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7143
7144 2019-01-03  Tom Tromey  <tom@tromey.com>
7145
7146         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7147         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7148         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7149         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7150         (pspy_set_type_printers): Likewise.
7151         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7152         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7153         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7154         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7155         (objfpy_set_type_printers): Likewise.
7156
7157 2019-01-03  Tom Tromey  <tom@tromey.com>
7158
7159         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7160         (gdbpy_print_stack): Use gdbpy_err_fetch.
7161         * python/python-internal.h (class gdbpy_err_fetch): New class.
7162         (class gdbpy_enter) <m_error_type, m_error_value,
7163         m_error_traceback>: Remove.
7164         <m_error>: New member.
7165         (gdbpy_exception_to_string): Don't declare.
7166         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7167         * python/py-value.c (convert_value_from_python): Use
7168         gdbpy_err_fetch.
7169         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7170         gdbpy_exception_to_string.
7171         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7172         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7173         gdbpy_err_fetch.
7174
7175 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7176
7177         * linux-nat.c (delete_lwp_cleanup): Delete.
7178         (struct lwp_deleter): New struct.
7179         (lwp_info_up): New typedef.
7180         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7181         lwp_info_up.
7182
7183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7184
7185         * linux-fork.c (class scoped_switch_fork_info): New class.
7186         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7187
7188 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7189
7190         * valops.c (find_overload_match): Remove use of null_cleanup, and
7191         calls to do_cleanups.
7192
7193 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * compile/compile-cplus-types.c
7196         (compile_cplus_instance::decl_name): Handle changes to
7197         cp_func_name.
7198         * cp-support.c (cp_func_name): Update header comment, update
7199         return type.
7200         * cp-support.h (cp_func_name): Update return type in declaration.
7201         * valops.c (find_overload_match): Move temp_func local to top
7202         level of function and change its type.  Use temp_func to hold and
7203         delete temporary string obtained from cp_func_name.
7204
7205 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7206
7207         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7208         gdb::char_vector, remove cleanup, and update uses of `msg`.
7209
7210 2019-01-03  Jim Wilson  <jimw@sifive.com>
7211
7212         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7213
7214 2019-01-02  Tom Tromey  <tom@tromey.com>
7215
7216         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7217         (tdesc_parse_xml): Remove cleanups.
7218         * target-descriptions.h (make_cleanup_free_target_description):
7219         Don't declare.
7220         (target_desc_deleter): New struct.
7221         (target_desc_up): New typedef.
7222         * target-descriptions.c (target_desc_deleter::operator()): Rename
7223         from free_target_description.
7224         (make_cleanup_free_target_description): Remove.
7225
7226 2019-01-02  Tom Tromey  <tom@tromey.com>
7227
7228         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7229         constructor, destructor.
7230         (linespec_parser): Remove typedef.
7231         (~linespec_parser): Rename from linespec_parser_delete.
7232         (linespec_lex_to_end, linespec_complete_label)
7233         (linespec_complete): Update.
7234         (decode_line_full): Remove cleanups.
7235         (decode_line_1): Update.
7236
7237 2019-01-02  Tom Tromey  <tom@tromey.com>
7238
7239         * python/python-internal.h (inferior_to_inferior_object): Change
7240         return type.
7241         * python/py-exitedevent.c (create_exited_event_object): Update.
7242         * python/py-inferior.c (inferior_to_inferior_object): Return
7243         gdbpy_ref.
7244         (python_new_inferior, python_inferior_deleted)
7245         (thread_to_thread_object, delete_thread_object)
7246         (build_inferior_list, gdbpy_selected_inferior): Update.
7247         * python/py-infthread.c (create_thread_object): Update.  Also fail
7248         if inferior_to_inferior_object fails.
7249
7250 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7251
7252         * inferior.h (class inferior) <displaced_step_state>: New field.
7253         * infrun.h (struct displaced_step_state): Move here from
7254         infrun.c.  Initialize fields, add constructor.
7255         <inf>: Remove field.
7256         <reset>: New method.
7257         * infrun.c (struct displaced_step_inferior_state): Move to
7258         infrun.h.
7259         (displaced_step_inferior_states): Remove.
7260         (get_displaced_stepping_state): Adust.
7261         (displaced_step_in_progress_any_inferior): Adjust.
7262         (displaced_step_in_progress_thread): Adjust.
7263         (displaced_step_in_progress): Adjust.
7264         (add_displaced_stepping_state): Remove.
7265         (get_displaced_step_closure_by_addr): Adjust.
7266         (remove_displaced_stepping_state): Remove.
7267         (infrun_inferior_exit): Call displaced_step_state.reset.
7268         (use_displaced_stepping): Don't check for NULL.
7269         (displaced_step_prepare_throw): Call
7270         get_displaced_stepping_state.
7271         (displaced_step_fixup): Don't check for NULL.
7272         (prepare_for_detach): Don't check for NULL.
7273
7274 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7275
7276         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7277          in case of call that did not complete.
7278
7279 2019-01-02  Andrey Utkin  <autkin@undo.io>
7280
7281         * symfile.c (find_separate_debug_file): Fix search of debug files for
7282         remote debuggee.
7283
7284 2019-01-02  Tom Tromey  <tom@tromey.com>
7285
7286         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7287         indentation.
7288         * python/py-frame.c (frapy_older): Remove cast.
7289         (frapy_newer): Likewise.
7290         * python/py-breakpoint.c (local_setattro): Remove cast.
7291         * python/py-arch.c (archpy_name): Remove local variable.
7292         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7293
7294 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7295
7296         * unittests/basic_string_view/element_access/char/empty.cc:
7297         Fix year range in copyright header.
7298
7299 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7300
7301         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7302         Delete.
7303         <operator==>: Update with for removed field.
7304         <hash>: Likewise.
7305         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7306         <isa_features>: ...this.
7307         <abi_features>: New field.
7308         (riscv_isa_flen): Update comment.
7309         (riscv_abi_xlen): New declaration.
7310         (riscv_abi_flen): New declaration.
7311         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7312         isa_features.
7313         (riscv_abi_xlen): New function.
7314         (riscv_isa_flen): Update to get answer from isa_features.
7315         (riscv_abi_flen): New function.
7316         (riscv_has_fp_abi): Update to get answer from abi_features.
7317         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7318         xlen and flen.
7319         (riscv_call_info) <xlen, flen>: Update comment.
7320         (riscv_call_arg_struct): Remove invalid assertions
7321         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7322         is removed.
7323         (riscv_gdbarch_init): Gather isa features and abi features
7324         separately, ensure both match on the gdbarch when reusing an old
7325         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7326         a target with 64-bit float hardware.
7327
7328 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7329
7330         * source.c (search_command_helper): Stop reverse search
7331         when line 1 has been searched.
7332
7333 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7334
7335         * record-full.c (record_full_base_target::close): Rewrite
7336         record_full_core_buf_list free logic.
7337
7338 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7339
7340         * break-catch-syscall.c (print_one_catch_syscall): xfree
7341         the last text.
7342
7343 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7344
7345         * top.c (print_gdb_version): Update Copyright year in version
7346         message.
7347
7348 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7349
7350         Update copyright year range in all GDB files.
7351
7352 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7353
7354         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7355
7356 For older changes see ChangeLog-2018.
7357 \f
7358 Local Variables:
7359 mode: change-log
7360 left-margin: 8
7361 fill-column: 74
7362 version-control: never
7363 coding: utf-8
7364 End:
7365