gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
   4
   5 2019-08-15  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-wingeneral.c: Include tui-stack.h.
   8         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
   9         (struct tui_locator_window): Move from tui-data.h.
  10         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
  11         (tui_initialize_static_data): Move from tui-data.c.
  12         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
  13         (struct tui_locator_window): Move to tui-stack.c.
  14         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
  15         (tui_initialize_static_data): Move to tui-stack.c.
  16
  17 2019-08-15  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-layout.c (show_source_disasm_command)
  20         (show_source_or_disasm_and_command): Use make_visible method, not
  21         tui_make_window.
  22         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
  23         Remove.
  24
  25 2019-08-15  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-wingeneral.h (tui_make_window): Update.
  28         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
  29         parameter.
  30         (tui_gen_win_info::make_visible): Update.
  31         * tui/tui-regs.c (tui_data_window::display_registers_from):
  32         Update.
  33         * tui/tui-layout.c (show_source_disasm_command)
  34         (show_source_or_disasm_and_command): Update.
  35         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  36         (enum tui_box): Remove.
  37         (struct tui_win_info) <can_box>: New method.
  38         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
  39         method.
  40
  41 2019-08-15  Tom de Vries  <tdevries@suse.de>
  42
  43         * linux-nat-trad.c: Include gdbarch.h.
  44
  45 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
  46
  47         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
  48         register sizes.
  49
  50 2019-08-14  Tom Tromey  <tromey@adacore.com>
  51
  52         * darwin-nat.c: Include gdbarch.h.
  53         * darwin-nat-info.c: Include gdbarch.h.
  54
  55 2019-08-13  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
  58         Remove.
  59         * tui/tui-data.c (tui_initialize_static_data): Update.
  60
  61 2019-08-13  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-winsource.h (struct tui_exec_info_window)
  64         <~tui_exec_info_window, maybe_allocate_content, get_content,
  65         m_content>: Remove.
  66         (struct tui_source_window_base) <set_exec_info_content,
  67         show_exec_info_content>: Don't declare.
  68         * tui/tui-winsource.c
  69         (tui_exec_info_window::maybe_allocate_content): Remove.
  70         (tui_source_window_base::update_exec_info): Rename from
  71         set_exec_info_content.
  72         (tui_source_window_base::show_exec_info_content)
  73         (tui_source_window_base::update_exec_info): Remove.
  74
  75 2019-08-13  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
  78         declare.
  79         * tui/tui-winsource.c (tui_update_source_window_as_is)
  80         (tui_update_source_windows_with_addr, tui_erase_source_content):
  81         Update.
  82         (tui_clear_exec_info_content): Remove.
  83
  84 2019-08-13  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
  87         declare.
  88         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
  89         call tui_erase_exec_info_content.
  90         (tui_clear_exec_info_content): Rename from
  91         tui_erase_exec_info_content.
  92         (tui_clear_exec_info_content): Delete.
  93
  94 2019-08-13  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-winsource.h (struct tui_source_window_base)
  97         <show_exec_info_content>: Declare.
  98         (tui_show_exec_info_content): Don't declare.
  99         * tui/tui-winsource.c
 100         (tui_source_window_base::show_exec_info_content): Rename from
 101         tui_show_exec_info_content.
 102         (tui_source_window_base::update_exec_info): Update.
 103
 104 2019-08-13  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 107         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 108         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 109         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 110         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 111         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 112         ... here.
 113
 114 2019-08-13  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-winsource.h (struct tui_source_window_base)
 117         <update_exec_info>: Declare.
 118         (tui_update_exec_info): Don't declare.
 119         * tui/tui-winsource.c (tui_update_source_window_as_is)
 120         (tui_source_window_base::refresh_all)
 121         (tui_update_all_breakpoint_info): Update.
 122         (tui_source_window_base::update_exec_info): Rename from
 123         tui_update_exec_info.
 124         * tui/tui-stack.c (tui_show_frame_info): Update.
 125
 126 2019-08-13  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-winsource.h (struct tui_source_window_base)
 129         <set_exec_info_content>: Declare.
 130         (tui_set_exec_info_content): Don't declare.
 131         * tui/tui-winsource.c
 132         (tui_source_window_base::set_exec_info_content): Rename from
 133         tui_set_exec_info_content.
 134         (tui_update_exec_info): Update.
 135
 136 2019-08-13  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.h (struct tui_source_window_base)
 139         <show_source_content>: Declare.
 140         (tui_show_source_content): Don't declare.
 141         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 142         (tui_source_window_base::show_source_content): Rename from
 143         tui_show_source_content.
 144         (tui_source_window_base::refresh_all): Update.
 145         * tui/tui-layout.c (show_source_disasm_command)
 146         (show_source_or_disasm_and_command): Update.
 147
 148 2019-08-13  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-winsource.c (tui_erase_source_content)
 151         (tui_show_source_content, tui_source_window_base::refresh_all):
 152         Update.
 153         * tui/tui-wingeneral.h
 154         (tui_check_and_display_highlight_if_needed): Don't declare.
 155         * tui/tui-wingeneral.c
 156         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 157         check_and_display_highlight_if_needed.
 158         * tui/tui-win.c (tui_rehighlight_all)
 159         (tui_win_info::make_visible_with_new_height): Update.
 160         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 161         (tui_data_window::erase_data_content)
 162         (tui_data_window::display_all_data): Update.
 163         * tui/tui-data.h (struct tui_win_info)
 164         <check_and_display_highlight_if_needed>: Declare.
 165
 166 2019-08-13  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-win.c (tui_resize_all): Call
 169         tui_delete_invisible_windows.
 170         * tui/tui-layout.c (show_layout): Call
 171         tui_delete_invisible_windows.
 172         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 173         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 174
 175 2019-08-13  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 178         tui_add_win_to_layout.
 179
 180 2019-08-13  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 183         * tui/tui-layout.c (tui_default_win_height): Now static.
 184
 185 2019-08-13  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 188         single switch.
 189         (show_source_disasm_command, show_source_or_disasm_and_command):
 190         Don't check current layout.
 191
 192 2019-08-13  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-wingeneral.c (make_all_visible): Remove.
 195         (tui_make_all_invisible): Simplify.
 196         * tui/tui-layout.c (tui_make_all_invisible): Move from
 197         tui-wingeneral.c; simplify.
 198         (show_layout): Hoist call to tui_make_all_invisible.
 199         (show_data): Don't call tui_make_all_invisible.
 200
 201 2019-08-13  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 204         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 205
 206 2019-08-13  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 209         tui-data.c.
 210         (show_source_disasm_command, show_data)
 211         (show_source_or_disasm_and_command): Don't use
 212         tui_set_current_layout_to.
 213         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 214         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 215         tui-layout.c.
 216         (tui_set_current_layout_to): Remove.
 217
 218 2019-08-13  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-layout.c (tui_set_layout): Update.
 221         * tui/tui-data.h (struct tui_layout_def): Remove.
 222         (tui_layout_def): Don't declare.
 223         * tui/tui-data.c (layout_def): Remove.
 224         (tui_layout_def): Remove.
 225
 226 2019-08-13  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-winsource.h (struct tui_source_window_base)
 229         <clear_detail>: No longer "override".
 230         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 231         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 232         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 233         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 234         Remove.
 235         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 236
 237 2019-08-13  Tom Tromey  <tromey@adacore.com>
 238
 239         * tracepoint.c: Don't include readline.h or history.h.
 240
 241 2019-08-12  Tom Tromey  <tom@tromey.com>
 242
 243         * configure: Rebuild.
 244         * configure.ac: Check for readline 7.
 245         * NEWS: Mention readline 7 requirement.
 246         * README: Update.
 247
 248 2019-08-12  Tom Tromey  <tom@tromey.com>
 249
 250         * mingw-hdep.c (gdb_select): Remove readline hack.
 251
 252 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 253
 254         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 255         when the function fails.
 256
 257 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 258
 259         * s390-tdep.c (s390_type_align): New function.
 260         (s390_gdbarch_init): Set it as type_align gdbarch method.
 261
 262 2019-08-09  Tom de Vries  <tdevries@suse.de>
 263
 264         PR gdb/24591
 265         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 266         pc_low with relocation offset.
 267
 268 2019-08-07  Tom Tromey  <tromey@adacore.com>
 269
 270         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 271         (print_frame_args): Update.
 272         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 273         Update.
 274         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 275         * frame.h (struct frame_arg): Add initializers.
 276         <error>: Now a unique_xmalloc_ptr.
 277
 278 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 279
 280         * NEWS: Expand the Pointer Authentication entry.
 281         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 282         (aarch64_frame_unmask_lr): ... to this.
 283         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 284         Call aarch64_frame_unmask_lr.
 285         * frame.c (struct frame_info): Add "masked" variable.
 286         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 287         (fprint_frame): Check for masked pc.
 288         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 289         declarations.
 290         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 291         * stack.c (print_frame): Check for masked pc.
 292
 293 2019-08-06  Tom Tromey  <tom@tromey.com>
 294
 295         * stabsread.c (patch_block_stabs, read_one_struct_field)
 296         (read_enum_type): Use obstack_strndup.
 297         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 298         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 299         * dwarf2read.c (guess_full_die_structure_name)
 300         (anonymous_struct_prefix): Use obstack_strndup.
 301         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 302         * c-exp.y (yylex): Use obstack_strndup.
 303         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 304         (write_var_or_type): Use obstack_strndup.
 305
 306 2019-08-06  Tom Tromey  <tom@tromey.com>
 307
 308         * symfile.c (reread_symbols): Use obstack_strdup.
 309         * stabsread.c (read_type): Use obstack_strdup.
 310         * gdb_obstack.h (obstack_strdup): New overload.
 311         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 312         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 313         (dwarf2_canonicalize_name): Use obstack_strdup.
 314         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 315         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 316         Use obstack_strdup.
 317
 318 2019-08-06  Tom Tromey  <tom@tromey.com>
 319
 320         * gdb_obstack.h (obstack_strdup): Define.
 321         * gdb_obstack.c (obstack_strdup): Don't define.
 322
 323 2019-08-06  Tom Tromey  <tom@tromey.com>
 324
 325         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 326         obstack_strdup.
 327         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 328         obstack_strdup.
 329         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 330         * stabsread.c (common_block_start): Use obstack_strdup.
 331         * objfiles.c (set_objfile_main_name, objfile): Use
 332         obstack_strdup.
 333         * namespace.c (add_using_directive): Use obstack_strdup.
 334         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 335         * jit.c (finalize_symtab): Use obstack_strdup.
 336         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 337         (guess_partial_die_structure_name, partial_die_info::fixup)
 338         (dwarf2_name): Use obstack_strdup.
 339         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 340         obstack_strdup.
 341         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 342         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 343         obstack_strdup.
 344         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 345
 346 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 347
 348         * unittests/help-doc-selftests.c: New file.
 349         * Makefile.in: Add the new file.
 350
 351 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 352
 353         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 354         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 355         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 356         the trailing '.' is not output, and the first character is uppercased.
 357         (print_help_for_command): Update call to print_doc_line.
 358         (print_doc_of_command): Likewise.
 359         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 360         * cli/cli-option.c (append_indented_doc): Do not append newline.
 361         (build_help_option): Append newline after first appended_indented_doc
 362         only if a second call is done.
 363         (build_help): Append 2 new lines before each option, except the first
 364         one.
 365         * compile/compile.c (_initialize_compile): Add new lines after
 366         %OPTIONS%, when not at the end of the help.
 367         Change help doc or code
 368         producing the help doc to respect the invariants.
 369         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 370         Also removed the new line after 'Options:', as all other commands
 371         do not put an empty line between 'Options:' and the first option.
 372         * printcmd.c (_initialize_printcmd): Likewise.
 373         * stack.c (_initialize_stack): Likewise.
 374         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 375         incorrectly telling COMMAND is optional.
 376         * ada-lang.c (_initialize_ada_language): Change help doc or code
 377         producing the help doc to respect the invariants.
 378         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 379         * breakpoint.c (_initialize_breakpoint): Likewise.
 380         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 381         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 382         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 383         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 384         _initialize_cli_style): Likewise.
 385         * corelow.c (core_target_info): Likewise.
 386         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 387         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 388         * filesystem.c (_initialize_filesystem): Likewise.
 389         * frame.c (_initialize_frame): Likewise.
 390         * gnu-nat.c (add_task_commands): Likewise.
 391         * infcall.c (_initialize_infcall): Likewise.
 392         * infcmd.c (_initialize_infcmd): Likewise.
 393         * interps.c (_initialize_interpreter): Likewise.
 394         * language.c (_initialize_language): Likewise.
 395         * linux-fork.c (_initialize_linux_fork): Likewise.
 396         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 397         * maint.c (_initialize_maint_cmds): Likewise.
 398         * memattr.c (_initialize_mem): Likewise.
 399         * printcmd.c (_initialize_printcmd): Likewise.
 400         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 401         _RegEx): Likewise.
 402         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 403         * record-btrace.c (_initialize_record_btrace): Likewise.
 404         * record-full.c (_initialize_record_full): Likewise.
 405         * record.c (_initialize_record): Likewise.
 406         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 407         * regcache.c (_initialize_regcache): Likewise.
 408         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 409         _initialize_remote): Likewise.
 410         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 411         * serial.c (_initialize_serial): Likewise.
 412         * skip.c (_initialize_step_skip): Likewise.
 413         * source.c (_initialize_source): Likewise.
 414         * stack.c (_initialize_stack): Likewise.
 415         * symfile.c (_initialize_symfile): Likewise.
 416         * symtab.c (_initialize_symtab): Likewise.
 417         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 418         * top.c (init_main): Likewise.
 419         * tracefile-tfile.c (tfile_target_info): Likewise.
 420         * tracepoint.c (_initialize_tracepoint): Likewise.
 421         * tui/tui-win.c (_initialize_tui_win): Likewise.
 422         * utils.c (add_internal_problem_command): Likewise.
 423         * valprint.c (value_print_option_defs): Likewise.
 424
 425 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 426
 427         PR build/24886
 428         * configure.ac: Drop enable-libmcheck support.
 429         * configure, config.in: Rebuild.
 430         * libmcheck.m4: Remove.
 431         * acinclude.m4: Don't include it.
 432         * Makefile.in: Don't distribute it.
 433         * top.c (print_gdb_configuration): Don't mention it.
 434
 435 2019-08-06  Tom Tromey  <tom@tromey.com>
 436
 437         * utils.c (set_output_style): Sometimes pass stream to
 438         emit_style_escape.
 439         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 440         * record-btrace.c (btrace_insn_history): Update.
 441         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 442         method.
 443         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 444         Update initializers.
 445         <m_uiout>: New field.
 446         <m_di>: Move lower.
 447         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 448         Remove "uiout" parameter.
 449         (dump_insns): Update.
 450         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 451         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 452
 453 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 454
 455         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 456         (error_in_psymtab_expansion): Likewise.
 457         (lookup_symbol_via_quick_fns): Likewise.
 458         (basic_lookup_transparent_type_quick): Likewise.
 459         (basic_lookup_transparent_type_1): Likewise.
 460
 461 2019-08-06  Tom Tromey  <tromey@adacore.com>
 462
 463         * source.c (last_source_error): Now bool.
 464         (print_source_lines_base): Make "noprint" bool.  Only open
 465         source file when last_source_visited changes.
 466
 467 2019-08-06  Tom Tromey  <tromey@adacore.com>
 468
 469         * annotate.c (annotate_source_line): Use g_source_cache.
 470         * source-cache.c (source_cache::get_plain_source_lines): Change
 471         parameters.  Populate m_offset_cache.
 472         (source_cache::ensure): New method.
 473         (source_cache::get_line_charpos): New method.
 474         (extract_lines): Move lower.  Change parameters.
 475         (source_cache::get_source_lines): Move lower.
 476         * source-cache.h (class source_cache): Update comment.
 477         <get_line_charpos>: New method.
 478         <get_source_lines>: Update comment.
 479         <clear>: Clear m_offset_cache.
 480         <get_plain_source_lines>: Change parameters.
 481         <ensure>: New method
 482         <m_offset_cache>: New member.
 483         * source.c (forget_cached_source_info_for_objfile): Update.
 484         (info_source_command): Use g_source_cache.
 485         (find_source_lines, open_source_file_with_line_charpos): Remove.
 486         (print_source_lines_base, search_command_helper): Use g_source_cache.
 487         * source.h (open_source_file_with_line_charpos): Don't declare.
 488         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 489         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 490         Use g_source_cache.
 491
 492 2019-08-06  Tom Tromey  <tromey@adacore.com>
 493
 494         * source-cache.c (source_cache::get_plain_source_lines):
 495         Remove "first_line" and "last_line" parameters.
 496         (source_cache::get_source_lines): Cache plain text.
 497         * source-cache.h (class source_cache)
 498         <get_plain_source_lines>: Update.
 499
 500 2019-08-06  Tom Tromey  <tromey@adacore.com>
 501
 502         * source-cache.c (extract_lines): No longer a method.
 503         Changed type of parameter.  Include final newline.
 504         (selftests::extract_lines_test): New function.
 505         (_initialize_source_cache): Likewise.
 506         * source-cache.h (class source_cache)
 507         <extract_lines>: Don't declare.
 508
 509 2019-08-06  Tom Tromey  <tromey@adacore.com>
 510
 511         * breakpoint.c (init_breakpoint_sal): Update.
 512         (breakpoint): Update.
 513         * breakpoint.h (struct breakpoint) <filter>: Now a
 514         unique_xmalloc_ptr.
 515
 516 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 517
 518         * NEWS: Mention dictionary access on blocks.
 519         * python/py-block.c (blpy_getitem): New function.
 520         (block_object_as_mapping): New struct.
 521         (block_object_type): Use new struct for tp_as_mapping field.
 522
 523 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 524
 525         * objfiles.h (objfile): Add a comment describing partial symbols.
 526
 527 2019-08-05  Tom Tromey  <tromey@adacore.com>
 528
 529         * compile/compile.c (_initialize_compile): Use _(), not N_().
 530         * thread.c (_initialize_thread): Use _(), not N_().
 531         * stack.c (_initialize_stack): Use _(), not N_().
 532         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 533
 534 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 535
 536         * dwarf2read.c (struct dw2_symtab_iterator):
 537         <want_specific_block>: Remove.
 538         <block_index>: Change type to gdb::optional.
 539         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 540         change type of BLOCK_INDEX parameter to gdb::optional.
 541         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 542         (dw2_lookup_symbol): Don't pass argument for
 543         WANT_SPECIFIC_BLOCK.
 544         (dw2_expand_symtabs_for_function): Don't pass argument for
 545         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 546         (class dw2_debug_names_iterator)
 547         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 548         parameter, change BLOCK_INDEX type to gdb::optional.
 549         <m_want_specific_block>: Remove.
 550         <m_block_index>: Change type to gdb::optional.
 551         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 552         gdb::optional.  Re-write in function of gdb::optional.
 553         (dw2_debug_names_lookup_symbol): Don't pass argument for
 554         WANT_SPECIFIC_BLOCK.
 555         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 556         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 557         BLOCK_INDEX.
 558
 559 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 560
 561         * NEWS: Mention changes to "info sources" command.
 562
 563 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 564
 565         * symtab.c (filename_partial_match_opts): New struct type.
 566         (struct output_source_filename_data): New members
 567         regexp, c_regexp, partial_match.
 568         (output_source_filename): Use new members to decide to print file.
 569         (info_sources_option_defs): New variable.
 570         (make_info_sources_options_def_group, print_info_sources_header,
 571         info_sources_command_completer):
 572         New functions.
 573         (info_sources_command): Read new optional arguments.
 574         (_initialize_symtab): Update info sources help.
 575
 576 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 577
 578         * ada-lang.c (exception_support_info_v0): Renamed from...
 579         (default_exception_support_info): ... this.  Create new
 580         definition for v1.
 581         (ada_has_this_exception_support): Look up catch_handlers_sym.
 582         (ada_exception_support_info_sniffer): Try v0 after default.
 583
 584 2019-08-01  Tom Tromey  <tromey@adacore.com>
 585
 586         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 587         gdbarch.h.
 588
 589 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 590
 591         * s12z-tdep.c: Fix include path for s12z-opc.h.
 592
 593 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 594
 595         * NEWS: Require GNU make 3.82.
 596
 597 2019-07-16  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 600         declare.
 601
 602 2019-07-30  Tom Tromey  <tromey@adacore.com>
 603
 604         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 605
 606 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 607
 608         * printcmd.c (print_address_symbolic): Print negative offsets.
 609         (build_address_symbolic): Force signed arithmetic when computing
 610         offset.
 611
 612 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 613
 614         PR/24474: Add a function to lookup static variables.
 615         * NEWS: Mention this new function.
 616         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 617         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 618         * python/python.c (python_GdbMethods): Add new function.
 619
 620 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 621
 622         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 623         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 624         (objfpy_lookup_static_symbol): New function.
 625         (objfile_object_methods): Add new functions.
 626
 627 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 628
 629         * NEWS: Mention 'set|show print frame-info'.  Mention new
 630         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 631         backtrace argument.  Mention that python frame filtering code
 632         is now consistent with what 'backtrace' command prints.
 633
 634 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 635
 636         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 637         comments.
 638         (print_frame_info_auto, print_frame_info_source_line,
 639         print_frame_info_location, print_frame_info_source_and_location,
 640         print_frame_info_location_and_address, print_frame_info_short_location):
 641         New declarations.
 642         (struct frame_print_options): New member print_frame_info.
 643         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 644         * stack.h (get_user_print_what_frame_info): New declaration.
 645         (frame_show_address): New declaration.
 646         * stack.c (print_frame_arguments_choices): New value 'presence'.
 647         (print_frame_info_auto, print_frame_info_source_line,
 648         print_frame_info_location, print_frame_info_source_and_location,
 649         print_frame_info_location_and_address, print_frame_info_short_location,
 650         print_frame_info_choices, print_frame_info_print_what): New definitions.
 651         (print_frame_args): Only print dots for args if print frame-arguments
 652         is 'presence'.
 653         (frame_print_option_defs): New element for "frame-info".
 654         (get_user_print_what_frame_info): New function.
 655         (frame_show_address): Make non static.  Move comment to stack.h.
 656         (print_frame_info_to_print_what): New function.
 657         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 658         to decide what to print.
 659         (backtrace_command_1): Handle the new print_frame_arguments_presence
 660         value.
 661         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 662         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 663         (py_print_frame): In non-mi mode, use LOCATION as default for
 664         print_what, similarly to frame information printed directly by
 665         backtrace command. Handle frame-info user option in non MI mode.
 666
 667 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 668
 669         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 670         Add case for debugging 32-bit target on 64-bit host.  Revise
 671         comment.
 672
 673 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 674
 675         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 676         instead of find_function_entry_range_from_pc.
 677
 678 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 679
 680         * stack.c (find_frame_funname): Remove code which preferred
 681         minsym over symtab sym in "certain pathological cases".
 682
 683         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 684         parameter.  Change type of "do_demangle" to bool.
 685         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 686         Pass suitable "prefer_sym_over_minsym" flag to
 687         build_address_symbolic().  Don't output "+" for negative offsets.
 688         * printcmd.c (print_address_symbolic): Update invocation of
 689         build_address_symbolic to include a "prefer_sym_over_minsym"
 690         flag.
 691         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 692         Restrict cases in which use of minimal symbol is preferred to that
 693         of a found symbol.  Update comments.
 694
 695         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 696         for entry pc when entry pc is out of range for that FDE.
 697
 698 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 699
 700         PR gdb/24839:
 701         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 702         type.
 703
 704 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 705
 706         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 707         this function's Python signature.
 708
 709
 710 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 711
 712         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 713         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 714         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 715         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 716         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 717
 718
 719 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 720
 721         * h8300-tdep.c (h8300_register_name_common): New.
 722         h8300_register_name): Use h8300_register_name_common.
 723         (h8300s_register_name): Likewise.
 724         (h8300sx_register_name): Likewise.
 725         (h8300h_register_nam): New.
 726         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 727
 728
 729 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 730
 731         * arm-tdep.c (arm_skip_cmse_entry): New function.
 732         (arm_is_sgstubs_section): New function.
 733         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 734
 735 2019-07-22  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 738         Don't self-assign.
 739
 740 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 743         type_print.
 744
 745 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 748         so that GDB doesn't match any msymbols when searching in the
 749         TYPES_DOMAIN.
 750         (print_symbol_info): Print using typedef_print or type_print based
 751         on the type of the symbol.  Add updated FIXME comment moved from...
 752         (_initialize_symtab): ... move and update FIXME comment to above.
 753
 754 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * NEWS: Mention adding -q option to "info types".
 757         * symtab.c (struct info_types_options): New struct.
 758         (info_types_options_defs): New variable.
 759         (make_info_types_options_def_group): New function.
 760         (info_types_command): Use gdb::option framework to parse options.
 761         (info_types_command_completer): New function.
 762         (_initialize_symtab): Extend the help text on "info types" and
 763         register command completer.
 764
 765 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 766
 767         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 768         (lookup_symbol_in_objfile): Change int to block_enum and add a
 769         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 770
 771 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 772
 773         * MAINTAINERS (Write After Approval): Add self.
 774
 775 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 778         instruction to the dummy code region.
 779
 780 2019-07-19  Tom Tromey  <tromey@adacore.com>
 781
 782         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 783         (ARGSUSED, PARAMS, __func__): Remove rules.
 784
 785 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 786
 787         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 788         * features/arm/arm-with-iwmmxt.c: Remove.
 789         * features/arm/arm-with-iwmmxt.xml: Remove.
 790         * features/arm/arm-with-m-fpa-layout.c: Remove.
 791         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 792         * features/arm/arm-with-m-vfp-d16.c: Remove.
 793         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 794         * features/arm/arm-with-m.c: Remove.
 795         * features/arm/arm-with-m.xml: Remove.
 796         * features/arm/arm-with-neon.c: Remove.
 797         * features/arm/arm-with-neon.xml: Remove.
 798         * features/arm/arm-with-vfpv2.c: Remove.
 799         * features/arm/arm-with-vfpv2.xml: Remove.
 800         * features/arm/arm-with-vfpv3.c: Remove.
 801         * features/arm/arm-with-vfpv3.xml: Remove.
 802
 803 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 804
 805         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 806
 807 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 808
 809         * arch/aarch32.c (aarch32_create_target_description): Create
 810         target descriptions using features.
 811         * arch/arm.c (arm_create_target_description)
 812         (arm_create_mprofile_target_description): Likewise.
 813         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 814
 815 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 816
 817         * Makefile.in: Add new files.
 818         * aarch32-tdep.c: New file.
 819         * aarch32-tdep.h: New file.
 820         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 821         Call aarch32_read_description.
 822         * arch/aarch32.c: New file.
 823         * arch/aarch32.h: New file.
 824         * arch/arm.c (arm_create_target_description)
 825         (arm_create_mprofile_target_description): New function.
 826         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 827         (arm_create_target_description)
 828         (arm_create_mprofile_target_description): New declaration.
 829         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 830         read_description functions.
 831         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 832         Likewise.
 833         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 834         * arm-tdep.c (tdesc_arm_list): New variable.
 835         (arm_register_g_packet_guesses): Call create description functions.
 836         (arm_read_description) (arm_read_mprofile_description): New
 837         function.
 838         * arm-tdep.h (arm_read_description)
 839         (arm_read_mprofile_description): Add declaration.
 840         * configure.tgt: Add new files.
 841
 842 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 843
 844         * top.c (new_ui_command): Open specified terminal just once.
 845
 846 2019-07-18  Tom Tromey  <tromey@adacore.com>
 847
 848         * symtab.c (main_name): Constify return type.
 849         * symfile.c (set_initial_language): Update.
 850         * symtab.h (main_name): Constify return type.
 851
 852 2019-07-17  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-winsource.c (tui_update_source_window)
 855         (tui_update_source_window_as_is)
 856         (tui_update_source_windows_with_line): Remove return.
 857         * tui/tui-disasm.c (tui_show_disassem)
 858         (tui_show_disassem_and_update_source): Remove return.
 859         * tui/tui.c (tui_reset): Remove return.
 860         * tui/tui-wingeneral.c
 861         (tui_check_and_display_highlight_if_needed): Remove return.
 862
 863 2019-07-17  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 866
 867 2019-07-17  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-winsource.h (struct tui_exec_info_window)
 870         (struct tui_source_window_base): Move from tui-data.h.
 871         * tui/tui-winsource.c: Move many method definitions from
 872         elsewhere.  Remove "structuring" comments.
 873         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 874         (tui_source_window_base::refresh_window): Move to
 875         tui-winsource.c.
 876         * tui/tui-win.c (tui_source_window_base::refresh_all)
 877         (tui_source_window_base::update_tab_width)
 878         (tui_source_window_base::set_new_height)
 879         (tui_source_window_base::do_make_visible_with_new_height): Move to
 880         tui-winsource.c.
 881         * tui/tui-source.h: Update.
 882         * tui/tui-source.c (tui_source_window_base::reset): Move to
 883         tui-winsource.c.
 884         * tui/tui-disasm.h: Update.
 885         * tui/tui-data.h (struct tui_exec_info_window): Move to
 886         tui-winsource.h.
 887         (struct tui_source_window_base): Likewise.
 888         * tui/tui-data.c (tui_source_window_base::clear_detail)
 889         (tui_source_window_base, ~tui_source_window_base): Move to
 890         tui-winsource.c.
 891
 892 2019-07-17  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-win.c (tui_resize_all)
 895         (tui_source_window_base::update_tab_width)
 896         (tui_adjust_win_heights): Update.
 897         (tui_win_info::make_invisible_and_set_new_height): Rename from
 898         make_invisible_and_set_new_height.
 899         * tui/tui-data.h (struct tui_win_info)
 900         <make_invisible_and_set_new_height>: New method.
 901
 902 2019-07-17  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui.c: Update.
 905         * tui/tui-source.h (struct tui_source_window): Move from
 906         tui-data.h.
 907         * tui/tui-layout.c: Update.
 908         * tui/tui-disasm.c: Update.
 909         * tui/tui-data.h (struct tui_source_window): Move to
 910         tui-source.h.
 911
 912 2019-07-17  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 915         tui-data.h.
 916         * tui/tui-data.h (struct tui_disasm_window): Move to
 917         tui-disasm.h.
 918
 919 2019-07-17  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-regs.h (struct tui_data_item_window): Move from
 922         tui-data.h.
 923         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 924         * tui/tui-data.h (struct tui_data_item_window): Move to
 925         tui-regs.h.
 926         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 927
 928 2019-07-17  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui.c: Update.
 931         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 932         (tui_cmd_window::max_height): Move to tui-command.c.
 933         * tui/tui-layout.c: Update.
 934         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 935         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 936         tui-command.c.
 937         * tui/tui-command.h (struct tui_cmd_window): Move from
 938         tui-data.h.
 939         * tui/tui-command.c: Remove "structuring" comments.
 940         (tui_cmd_window::clear_detail)
 941         (tui_cmd_window::do_make_visible_with_new_height)
 942         (tui_cmd_window::max_height): Move from elsewhere.
 943
 944 2019-07-17  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 947         Now static.
 948         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 949         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 950
 951 2019-07-17  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui.c: Update.
 954         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 955         tui-regs.c.
 956         * tui/tui-windata.h: Remove file.
 957         * tui/tui-windata.c: Remove file.
 958         * tui/tui-win.c (tui_data_window::set_new_height)
 959         (tui_data_window::do_make_visible_with_new_height): Move to
 960         tui-regs.c.
 961         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 962         * tui/tui-regs.c: Remove "structuring" comments.
 963         (tui_data_window::first_data_item_displayed)
 964         (tui_data_window::delete_data_content_windows)
 965         (tui_data_window::erase_data_content)
 966         (tui_data_window::display_all_data)
 967         (tui_data_window::refresh_all)
 968         (tui_data_window::do_scroll_vertical)
 969         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 970         (tui_data_window::do_make_visible_with_new_height)
 971         (tui_data_window::refresh_window): Move from elsewhere.
 972         (_initialize_tui_regs): Move to end of file.
 973         * tui/tui-layout.c: Update.
 974         * tui/tui-hooks.c: Update.
 975         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 976         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 977         tui-regs.c.
 978         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 979
 980 2019-07-17  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 983         seen.
 984
 985 2019-07-17  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-win.c (tui_source_window_base::set_new_height)
 988         (tui_source_window_base::do_make_visible_with_new_height): Use
 989         m_has_locator field directly.
 990         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 991         method.
 992         (struct tui_source_window_base) <has_locator>: Likewise.
 993
 994 2019-07-17  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 997         Don't declare.
 998         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 999         Remove.
1000         * tui/tui-win.c (tui_source_window_base::set_new_height)
1001         (tui_source_window_base::set_new_height)
1002         (make_invisible_and_set_new_height)
1003         (tui_source_window_base::do_make_visible_with_new_height)
1004         (tui_source_window_base::do_make_visible_with_new_height):
1005         Update.
1006         * tui/tui-layout.c (show_source_disasm_command, show_data)
1007         (show_source_or_disasm_and_command): Update.
1008         * tui/tui-layout.c (show_layout): Update.
1009
1010 2019-07-17  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-layout.c (make_data_window): Remove.
1013         (show_data): Unify creation and re-initialization cases.
1014
1015 2019-07-17  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-layout.c (make_source_window, make_disasm_window):
1018         Remove.
1019         (show_data): Unify creation and re-initialization cases.
1020
1021 2019-07-17  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-layout.c (make_command_window): Remove.
1024         (show_source_disasm_command, show_source_or_disasm_and_command):
1025         Unify creation and re-initialization cases.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1030         creation and re-initialization cases.
1031
1032 2019-07-17  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-regs.c (tui_get_register): Return void.
1035
1036 2019-07-17  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1039         Simplify.
1040
1041 2019-07-17  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1044         resetting.
1045
1046 2019-07-17  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1049         * tui/tui-regs.c (tui_reg_layout): New function.
1050         (tui_show_registers, tui_reg_command): Use it.
1051         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1052         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1053         parameters.
1054         (tui_layout_command): Remove.
1055
1056 2019-07-17  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-layout.h (tui/tui-layout): Return void.
1059         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1060
1061 2019-07-17  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-layout.c (show_source_disasm_command, show_data):
1064         Update.
1065         (reset_locator): Remove.
1066         (show_source_or_disasm_and_command): Update.
1067
1068 2019-07-17  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-source.c (tui_source_window_base::reset): Remove
1071         win_type parameter.
1072         * tui/tui-layout.c (make_command_window, make_source_window)
1073         (make_disasm_window, make_data_window)
1074         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1075         (reset_locator, show_source_or_disasm_and_command): Update.
1076         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1077         win_type parameter.
1078         (struct tui_source_window_base) <reset>: Likewise.
1079
1080 2019-07-17  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-layout.c (show_source_disasm_command): Use
1083         reset_locator.
1084         (reset_locator): New function.
1085         (init_and_make_win): Remove.
1086         (show_source_or_disasm_and_command): Use reset_locator.
1087
1088 2019-07-17  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1091         condition.
1092         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1093         Remove condition.
1094         * tui/tui-source.c (tui_source_window_base::reset): New method.
1095         * tui/tui-layout.c (make_command_window): Don't call
1096         init_and_make_win.
1097         (make_source_window, make_disasm_window): Don't call
1098         make_source_or_disasm_window.
1099         (make_data_window): Don't call init_and_make_win.  Change calling
1100         convention.
1101         (show_source_disasm_command, show_data): Simplify.
1102         (make_source_or_disasm_window): Remove.
1103         (show_source_or_disasm_and_command): Simplify.
1104         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1105         (struct tui_source_window_base) <reset>: Likewise.
1106         <execution_info>: Remove initializer.
1107         * tui/tui-data.c (tui_source_window_base): Initialize
1108         execution_info.
1109
1110 2019-07-17  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1113         variable.
1114
1115 2019-07-17  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui.c (tui_rl_other_window): Update.
1118         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1119         superclass method first.  Always iterate over regs_content.
1120         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1121         method.
1122         * tui/tui-win.c (tui_set_focus_command): Update.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-win.c (tui_set_focus_command): Rename from
1127         tui_set_focus.  Call tui_enable.
1128         (tui_set_focus_command): Remove.
1129
1130 2019-07-17  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1133         refresh_window.
1134         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1135         touchwin.
1136         (tui_data_window::refresh_window): Call refresh_window on data
1137         items.  Always call superclass refresh_window.
1138         (tui_win_info::refresh): Remove.
1139         (tui_source_window_base::refresh_window): Update.
1140         (tui_refresh_all): Update.
1141         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1142         refresh_window.
1143         (show_source_or_disasm_and_command): Likewise.
1144         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1145         (struct tui_source_window_base) <refresh>: Likewise.
1146
1147 2019-07-17  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-winsource.c (tui_clear_source_content)
1150         (tui_show_source_content): Update.
1151         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1152         whether content is empty.
1153         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1154         Remove.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1159         window's contents.
1160         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1161         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1162
1163 2019-07-17  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1166         (struct tui_data_item_window): Update.
1167
1168 2019-07-17  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1171         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1172         defines.
1173
1174 2019-07-17  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-winsource.h (tui_erase_source_content)
1177         (tui_clear_source_content): Remove "display_prompt" parameter.
1178         * tui/tui-winsource.c (tui_update_source_window_as_is)
1179         (tui_update_source_windows_with_addr): Update.
1180         (tui_clear_source_content): Remove "display_prompt" parameter.
1181         (tui_erase_source_content): Likewise.  Simplify.
1182         (tui_show_source_content): Update.
1183         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1184         * tui/tui-stack.c (tui_show_frame_info): Update.
1185         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1186         Remove defines.
1187
1188 2019-07-17  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1191         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1192         parameter.
1193         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1194         parameter.
1195
1196 2019-07-17  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-winsource.c (tui_clear_source_content)
1199         (tui_show_source_content, tui_show_exec_info_content)
1200         (tui_clear_exec_info_content): Update.
1201         * tui/tui-stack.c (tui_show_locator_content): Update.
1202         (tui_show_frame_info): Update.
1203         * tui/tui-source.h (tui_source_window): Don't declare.
1204         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1205         from tui_source_is_displayed.
1206         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1207         Remove field.
1208         (struct tui_source_window_base) <content_in_use>: New field.  Now
1209         bool.
1210         (struct tui_source_window) <showing_source_p>: New method.
1211         (TUI_SRC_WIN): Change cast.
1212         * tui/tui-data.c (tui_initialize_static_data): Update.
1213
1214 2019-07-17  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1217         location_matches_p.
1218         * tui/tui-source.c (tui_source_window::location_matches_p): New
1219         method.
1220         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1221         method.
1222         * tui/tui-data.h (struct tui_source_window_base)
1223         <location_matches_p>: New method.
1224         (struct tui_source_window, struct tui_disasm_window)
1225         <location_matches_p>: Likewise.
1226
1227 2019-07-17  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-win.c (tui_set_win_height_command): Rename from
1230         tui_set_win_height.
1231         (tui_set_win_height_command): Remove.
1232
1233 2019-07-17  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-source.c (tui_source_window): New constructor.  Add
1236         observer.
1237         (~tui_source_window): New destructor.
1238         (tui_source_window::style_changed): New method.
1239         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1240         (tui_attach_detach_observers): Update.
1241         * tui/tui-data.h (struct tui_source_window): Make constructor not
1242         inline.  Add destructor.
1243         (struct tui_source_window) <style_changed>: New method.
1244         <m_observable>: New member.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1249         * tui/tui-win.c (tui_resize_all): Fix typo.
1250
1251 2019-07-17  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1254         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1255         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1256         * tui/tui-win.c (window_name_completer): Use foreach.
1257         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1258         (update_tab_width): Likewise.
1259         * tui/tui-layout.c (show_layout): Update.
1260         * tui/tui-data.h (class tui_window_iterator): New.
1261         (struct all_tui_windows): New.
1262         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1263
1264 2019-07-17  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1267         parameter.  Don't reference globals.
1268         (tui_reg_command): Update.
1269
1270 2019-07-17  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-regs.c (tui_show_registers): Simplify.
1273
1274 2019-07-17  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-regs.c (tui_show_registers): Update.
1277         (tui_show_register_group): Add win_info parameter.
1278
1279 2019-07-17  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1282         Rename from tui_display_reg_element_at_line.
1283         (tui_data_window::display_registers_from_line): Update.
1284         * tui/tui-data.h (struct tui_data_window)
1285         <display_reg_element_at_line>: New method.
1286
1287 2019-07-17  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-regs.h (tui_display_registers_from)
1290         (tui_display_registers_from_line): Don't declare.
1291         * tui/tui-windata.c (tui_data_window::display_all_data)
1292         (tui_data_window::refresh_all)
1293         (tui_data_window::do_scroll_vertical): Update.
1294         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1295         from tui_display_registers_from.
1296         (tui_display_reg_element_at_line): Update.
1297         (tui_data_window::display_registers_from_line): Rename from
1298         tui_display_registers_from_line.
1299         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1300         display_registers_from_line>: New methods.
1301
1302 2019-07-17  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1305         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1306         from tui_erase_data_content.
1307         (tui_data_window::display_all_data)
1308         (tui_data_window::refresh_all)
1309         (tui_data_window::do_scroll_vertical): Update.
1310         * tui/tui-regs.c (tui_show_registers): Update.
1311         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1312         New method.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1317         declare.
1318         * tui/tui-windata.c
1319         (tui_data_window::delete_data_content_windows): Rename from
1320         tui_delete_data_content_windows.
1321         (tui_data_window::display_all_data)
1322         (tui_data_window::do_scroll_vertical): Update.
1323         * tui/tui-data.h (struct tui_data_window)
1324         <delete_data_content_windows>: New method.
1325
1326 2019-07-17  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1329         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1330
1331 2019-07-17  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1334         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1335         from tui_display_all_data.
1336         * tui/tui-win.c
1337         (tui_data_window::do_make_visible_with_new_height): Update.
1338         * tui/tui-regs.c (tui_show_registers): Update.
1339         * tui/tui-layout.c (tui_set_layout): Update.
1340         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1341         method.
1342
1343 2019-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1346         * tui/tui-windata.c (tui_display_data_from): Remove.
1347         (tui_data_window::refresh_all): Update.
1348
1349 2019-07-17  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1352         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1353         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1354         tui_display_registers_from_line.
1355         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1356         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1357         "force_display" parameter.
1358
1359 2019-07-17  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1362         declare.
1363         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1364         Rename from tui_first_reg_element_no_inline.
1365         (tui_display_reg_element_at_line)
1366         (tui_display_registers_from_line): Update.
1367         * tui/tui-data.h (struct tui_data_window)
1368         <first_reg_element_no_inline>: New method.
1369
1370 2019-07-17  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-windata.c (tui_display_data_from)
1373         (tui_data_window::do_scroll_vertical): Update.
1374         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1375         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1376         Rename from tui_line_from_reg_element_no.
1377         (tui_display_registers_from_line): Update.
1378         * tui/tui-data.h (struct tui_data_window)
1379         <line_from_reg_element_no>: New method.
1380
1381 2019-07-17  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1384         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1385         tui_last_regs_line_no.
1386         (tui_display_reg_element_at_line)
1387         (tui_display_registers_from_line): Update.
1388         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1389         method.
1390
1391 2019-07-17  Tom Tromey  <tom@tromey.com>
1392
1393         PR tui/24722:
1394         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1395         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1396         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1397         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1398         (tui_update_breakpoint_info): Likewise.
1399         * tui/tui-hooks.c (tui_event_create_breakpoint)
1400         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1401         Update.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1406
1407 2019-07-17  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-winsource.c (tui_update_source_window_as_is)
1410         (tui_update_source_windows_with_addr): Update.
1411         * tui/tui-source.h (tui_set_source_content)
1412         (tui_show_symtab_source): Add "win_info" parameter.
1413         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1414         parameter.
1415         (tui_show_symtab_source): Likewise.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-wingeneral.c
1420         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1421
1422 2019-07-17  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1425         (struct tui_cmd_window) <can_scroll>: New method.
1426         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1427         method.
1428
1429 2019-07-17  Tom Tromey  <tromey@adacore.com>
1430
1431         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1432         do_field_signed>: Rename.  Change type of "value".
1433         * ui-out.c (ui_out::field_signed): Rename from field_int.
1434         Change type of "value".
1435         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1436         type of "value".
1437         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1438         do_field_int.  Change type of "value".
1439         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1440         do_field_int.  Change type of "value".
1441         * tracepoint.c (trace_status_mi, tfind_1)
1442         (print_one_static_tracepoint_marker): Update.
1443         * thread.c (print_thread_info_1, print_selected_thread_frame):
1444         Update.
1445         * stack.c (print_frame, print_frame_info): Update.
1446         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1447         Update.
1448         * source.c (print_source_lines_base): Update.
1449         * skip.c (info_skip_command): Update.
1450         * record-btrace.c (btrace_ui_out_decode_error)
1451         (btrace_call_history_src_line): Update.
1452         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1453         Update.
1454         * progspace.c (print_program_space): Update.
1455         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1456         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1457         do_field_int.  Change type of "value".
1458         * mi/mi-out.c (mi_ui_out::do_table_begin)
1459         (mi_ui_out::do_table_header): Update.
1460         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1461         type of "value".
1462         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1463         (mi_cmd_data_list_changed_registers, output_register)
1464         (mi_cmd_data_read_memory, mi_load_progress)
1465         (mi_cmd_trace_frame_collected): Update.
1466         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1467         Update.
1468         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1469         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1470         (mi_cmd_var_list_children, varobj_update_one): Update.
1471         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1472         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1473         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1474         * inferior.c (print_inferior): Update.
1475         * gdb_bfd.c (print_one_bfd): Update.
1476         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1477         Update.
1478         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1479         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1480         do_field_int.  Change type of "value".
1481         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1482         do_field_int.  Change type of "value".
1483         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1484         (print_one_breakpoint_location, print_it_catch_fork)
1485         (print_one_catch_fork, print_it_catch_vfork)
1486         (print_one_catch_vfork, print_it_catch_solib)
1487         (print_it_catch_exec, print_it_ranged_breakpoint)
1488         (print_mention_watchpoint, print_mention_masked_watchpoint)
1489         (bkpt_print_it, update_static_tracepoint): Update.
1490         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1491         * break-catch-syscall.c (print_it_catch_syscall): Update.
1492         * ada-tasks.c (print_ada_task_info): Update.
1493         * ada-lang.c (print_it_exception, print_mention_exception):
1494         Update.
1495
1496 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         PR breakpoints/24541
1499         * gdbarch.c: Regenerate.
1500         * gdbarch.h: Regenerate.
1501         * gdbarch.sh: Adjust return type and parameter types for
1502         'stap_adjust_register'.
1503         (i386_stap_adjust_register): Adjust signature and return new
1504         register name.
1505         * stap-probe.c (stap_parse_register_operand): Adjust use of
1506         'gdbarch_stap_adjust_register'.
1507
1508 2019-07-17  Tom Tromey  <tromey@adacore.com>
1509
1510         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1511         declare VEC.
1512         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1513         std::vector.
1514         (struct s390_process_info): Add initializers.
1515         (s390_add_process): Use new.
1516         (s390_linux_nat_target::low_forget_process): Use delete.
1517         (s390_linux_nat_target::low_new_fork)
1518         (s390_linux_nat_target::stopped_by_watchpoint)
1519         (s390_linux_nat_target::low_prepare_to_resume)
1520         (s390_linux_nat_target::insert_watchpoint)
1521         (s390_linux_nat_target::insert_hw_breakpoint)
1522         (s390_linux_nat_target::remove_watchpoint)
1523         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1524
1525 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1526
1527         * aarch64-fbsd-nat.c: Include regcache.h.
1528         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1529         argument.
1530         (aarch64_fbsd_nat_target::fetch_registers)
1531         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1532         variable.
1533         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1534
1535 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1536
1537         * fbsd-nat.c: Include gdbarch.h.
1538
1539 2019-07-15  Tom Tromey  <tromey@adacore.com>
1540
1541         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1542
1543 2019-07-15  Tom Tromey  <tromey@adacore.com>
1544
1545         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1546         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1547         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1548         * cli-out.c (cli_ui_out::do_field_int): New method.
1549         * ui-out.c (ui_out::field_unsigned): New method.
1550         * symfile.c (generic_load): Use field_unsigned.
1551         (print_transfer_performance): Likewise.
1552         * record-btrace.c (ui_out_field_uint): Remove.
1553         (btrace_call_history_insn_range, btrace_call_history): Use
1554         field_unsigned.
1555         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1556         field_unsigned.
1557         * ui-out.h (class ui_out) <field_unsigned>: New method.
1558         <do_field_unsigned>: Likewise.
1559
1560 2019-07-15  Tom Tromey  <tromey@adacore.com>
1561
1562         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1563         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1564         * target.c (flash_erase_command): Use field_string.
1565         * infrun.c (print_signal_received_reason): Use field_string.
1566         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1567         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1568         field_string.
1569         * ada-tasks.c (print_ada_task_info): Use field_string.
1570
1571 2019-07-15  Tom Tromey  <tromey@adacore.com>
1572
1573         * target.c (flash_erase_command): Use field_core_addr.
1574         * symfile.c (generic_load): Use field_core_addr.
1575         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1576         Use field_core_addr.
1577         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1578         field_core_addr.
1579
1580 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1583         value if its desired type is smaller than a CORE_ADDR and signed.
1584
1585 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1588         of changes to field names, and use new is_reference field to
1589         decide if a property is a reference or not.
1590         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1591         field.
1592         (struct dwarf2_property_baton): Update header comment, rename
1593         'referenced_type' to 'property_type' and update comments.
1594         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1595         default property type, store in property baton, update to take
1596         accound of renamed field.
1597         (read_func_scope): Update call to attr_to_dynamic_prop.
1598         (read_array_type): Likewise.
1599         (dwarf2_per_cu_addr_sized_int_type): New function.
1600         (read_subrange_index_type): Move type finding code to
1601         dwarf2_per_cu_addr_sized_int_type.
1602         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1603         (dwarf2_per_cu_addr_type): New function.
1604         (set_die_type): Update calls to attr_to_dynamic_prop.
1605
1606 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * dwarf2read.c (read_subrange_index_type): New function.
1609         (read_subrange_type): Move code into new function and call it.
1610         * gdbtypes.c (create_range_type): Add some asserts.
1611
1612 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1613
1614         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1615         update return statements.
1616         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1617         declaration, and update comment to match.
1618         * gdbtypes.c (resolve_dynamic_array): Update call to
1619         dwarf2_evaluate_property to match new return type.
1620
1621 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * valarith.c (value_subscripted_rvalue): Change lowerbound
1624         parameter type from int to LONGEST.
1625         * value.h (value_subscripted_rvalue): Likewise in declaration.
1626
1627 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * cli/cli-utils.c (info_print_command_completer): New function.
1630         * cli/cli-utils.h: Add 'completer.h' include, and forward
1631         declaration for 'struct cmd_list_element'.
1632         (info_print_command_completer): Declare.
1633         * stack.c (_initialize_stack): Add completer for 'info locals' and
1634         'info args'.
1635         * symtab.c (_initialize_symtab): Add completer for 'info
1636         variables' and 'info functions'.
1637         * NEWS: Mention completion for additional info commands.
1638
1639 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * cli/cli-utils.c (extract_info_print_args): Delete.
1642         (extract_arg_maybe_quoted): Delete.
1643         (info_print_options_defs): New variable.
1644         (make_info_print_options_def_group): New function.
1645         (extract_info_print_options): Define new function.
1646         * cli/cli-utils.h (extract_info_print_args): Delete.
1647         (struct info_print_options): New structure.
1648         (extract_info_print_options): Declare new function.
1649         * stack.c (info_locals_command): Update to use new
1650         extract_info_print_options, also add a header comment.
1651         (info_args_command): Likewise.
1652         * symtab.c (info_variables_command): Likewise.
1653         (info_functions_command): Likewise.
1654
1655 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1656
1657         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1658         to extract string arguments.
1659         * common/common-utils.c (extract_string_maybe_quoted): New function.
1660         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1661
1662 2019-07-11  Tom Tromey  <tromey@adacore.com>
1663
1664         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1665         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1666         * top.h (gdbinit): Don't declare.
1667         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1668         into...
1669         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1670         * top.c (gdb_init): Don't call init_cli_cmds.
1671         (gdbinit): Remove.
1672         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1673
1674 2019-07-11  Tom Tromey  <tromey@adacore.com>
1675
1676         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1677         after it has been moved.
1678
1679 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1680
1681         * valops.c (value_must_coerce_to_target): Change return type to
1682         bool.
1683         * value.h (value_must_coerce_to_target): Likewise.
1684
1685 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1686
1687         * breakpoint.c (is_hardware_watchpoint): Remove
1688         forward-declaration.
1689         (is_masked_watchpoint): Change return type to bool.
1690         (is_tracepoint): Likewise.
1691         (is_breakpoint): Likewise.
1692         (is_hardware_watchpoint): Likewise.
1693         (is_watchpoint): Likewise.
1694         (is_no_memory_software_watchpoint): Likewise.
1695         (is_catchpoint): Likewise.
1696         (breakpoint_1): Make FILTER parameter's return type bool.
1697         is_masked_watchpoint): Change return type to bool.
1698         (save_breakpoints): Make FILTER parameter's return type bool.
1699         * breakpoint.h (is_breakpoint): Change return type to bool.
1700         (is_watchpoint): Likewise.
1701         (is_catchpoint): Likewise.
1702         (is_tracepoint): Likewise.
1703
1704 2019-07-10  Tom Tromey  <tom@tromey.com>
1705
1706         * defs.h: Don't include gdbarch.h.
1707         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1708         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1709         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1710         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1711         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1712         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1713         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1714         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1715         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1716         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1717         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1718         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1719         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1720         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1721         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1722         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1723         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1724         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1725         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1726         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1727         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1728         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1729         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1730         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1731         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1732         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1733         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1734
1735 2019-07-10  Tom Tromey  <tromey@adacore.com>
1736
1737         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1738         * breakpoint.c (init_ada_exception_breakpoint): Register as
1739         bp_catchpoint.
1740         (print_one_breakpoint_location, print_one_breakpoint): Use
1741         is_ada_exception_catchpoint.
1742         * ada-lang.c (class ada_catchpoint_location): Pass
1743         bp_loc_software_breakpoint to bp_location constructor.
1744         (is_ada_exception_catchpoint): New function.
1745
1746 2019-07-10  Tom Tromey  <tromey@adacore.com>
1747
1748         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1749         VEC.
1750         (struct arm_exidx_entry): New method operator<.
1751         (struct arm_exidx_data) <section_maps>: Change type.
1752         (arm_exidx_data_free): Remove.
1753         (arm_exidx_data_key): Change type.  Move lower.
1754         (arm_exidx_new_objfile): Update.
1755         (arm_compare_exidx_entries): Remove.
1756         (arm_find_exidx_entry, _initialize_arm_tdep)
1757
1758 2019-07-10  Tom Tromey  <tromey@adacore.com>
1759
1760         * solib-spu.c (ocl_program_data_key): Change type.
1761         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1762         Update.
1763
1764 2019-07-10  Tom Tromey  <tromey@adacore.com>
1765
1766         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1767         (struct solib_aix_inferior_data) <library_list>: Change type.
1768         (solib_aix_inferior_data_handle): Change type.
1769         (get_solib_aix_inferior_data): Update.
1770         (solib_aix_free_library_list): Remove.
1771         (library_list_start_library): Update.
1772         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1773         return type.
1774         (solib_aix_get_library_list)
1775         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1776         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1777
1778 2019-07-10  Tom Tromey  <tromey@adacore.com>
1779
1780         * solib-dsbt.c (struct dsbt_info): Add initializers.
1781         (solib_dsbt_pspace_data): Change type.
1782         (dsbt_pspace_data_cleanup): Remove.
1783         (get_dsbt_info, _initialize_dsbt_solib): Update.
1784
1785 2019-07-10  Tom Tromey  <tromey@adacore.com>
1786
1787         * spu-tdep.c (spu_overlay_data): Change type.
1788         (spu_get_overlay_table, spu_overlay_new_objfile)
1789         (_initialize_spu_tdep): Update.
1790
1791 2019-07-10  Tom Tromey  <tromey@adacore.com>
1792
1793         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1794         destructor.
1795         (dbx_objfile_data_key): Change type and declare later.
1796         (DBX_SYMFILE_INFO): Rewrite.
1797         * dbxread.c (dbx_objfile_data_key): Change type.
1798         (dbx_symfile_init): Update.
1799         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1800         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1801         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1802
1803 2019-07-10  Tom Tromey  <tromey@adacore.com>
1804
1805         * jit.c (jit_program_space_key): Change type.  Move lower.
1806         (get_jit_program_space_data): Update.
1807         (jit_program_space_data_cleanup): Remove.
1808         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1809         Update.
1810         (struct jit_program_space_data): Add initializers.
1811
1812 2019-07-10  Tom Tromey  <tromey@adacore.com>
1813
1814         * solib-darwin.c (struct darwin_info): Add initializers.
1815         (solib_darwin_pspace_data): Change type.
1816         (darwin_pspace_data_cleanup): Remove.
1817         (get_darwin_info, _initialize_darwin_solib): Update.
1818
1819 2019-07-10  Tom Tromey  <tromey@adacore.com>
1820
1821         * remote-sim.c (struct sim_inferior_data): Add initializers,
1822         constructor, and destructor.
1823         (sim_inferior_data_key): Change type.  Move lower.
1824         (check_for_duplicate_sim_descriptor): Update.
1825         (get_sim_inferior_data): Use new.  Update.
1826         (~sim_inferior_data_cleanup): Rename from
1827         sim_inferior_data_cleanup.  Simplify.
1828         (gdbsim_close_inferior, simulator_command)
1829         (sim_command_completer, _initialize_remote_sim): Update.
1830         (next_pid, INITIAL_PID): Move earlier.
1831
1832 2019-07-10  Tom Tromey  <tromey@adacore.com>
1833
1834         * python/python-internal.h (create_thread_object): Return
1835         gdbpy_ref.
1836         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1837         * python/py-inferior.c (struct threadlist_entry): Add
1838         constructor.
1839         <thread_obj>: Now a gdbpy_ref.
1840         (thread_to_thread_object): Update.
1841         (add_thread_object): Use new.
1842         (delete_thread_object): Use delete.
1843         (infpy_threads): Update.
1844         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1845         GIL.
1846
1847 2019-07-10  Tom Tromey  <tromey@adacore.com>
1848
1849         * valops.c (value_cast): Specialize error message for Ada.
1850
1851 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1852
1853         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1854
1855 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1856
1857         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1858         bpstat_should_step): Return bool, adjust comments.
1859         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1860         bpstat_should_step): Likewise.
1861
1862 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1863
1864         * features/Makefile: Use feature target descriptions for Arm.
1865         * features/arm/arm-core.c: Generate new file.
1866         * features/arm/arm-fpa.c: Likewise.
1867         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1868         * features/arm/arm-m-profile.c: Likewise.
1869         * features/arm/arm-vfpv2.c: Likewise.
1870         * features/arm/arm-vfpv3.c: Likewise.
1871         * features/arm/xscale-iwmmxt.c: Likewise.
1872         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1873
1874 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1875
1876         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1877         ptrace earlier.
1878
1879 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1880
1881         * features/aarch64-pauth.c: Regenerate.
1882
1883 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1884
1885         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1886         bool.
1887         (bpstat_what): Use false instead of 0.
1888
1889 2019-07-09  Pedro Alves  <palves@redhat.com>
1890
1891         * break-catch-throw.c (is_exception_catchpoint): New.
1892         * breakpoint.c (print_one_breakpoint_location): New parameter
1893         'raw_loc'.  Handle it.  Use
1894         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1895         looking at the breakpoint's type.
1896         (print_one_breakpoint): If handling "maint info breakpoints", also
1897         print locations of exception catchpoints.
1898         * breakpoint.h (is_exception_catchpoint): Declare.
1899
1900 2019-07-09  Pedro Alves  <palves@redhat.com>
1901
1902         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1903         "addr" field.
1904         (allocate_location_exception_catchpoint): New.
1905         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1906         (initialize_throw_catchpoint_ops): Install
1907         allocate_location_exception_catchpoint as allocate_location
1908         method.
1909         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1910         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1911         bp_loc_other.
1912         (breakpoint_address_is_meaningful): Delete.
1913         (bl_address_is_meaningful): New.
1914         (breakpoint_locations_match): Adjust comment.
1915         (bp_location_from_bp_type): New, factored out of...
1916         (bp_location::bp_location(breakpoint *)): ... this.
1917         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1918         factored out of...
1919         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1920         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1921         breakpoint_address_is_meaningful.
1922         (bp_locations_compare): Adjust comment.
1923         (update_global_location_list): Use bl_address_is_meaningful
1924         instead of breakpoint_address_is_meaningful.
1925         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1926         explicit.
1927         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1928         * python/py-breakpoint.c (bppy_get_location): No longer check
1929         whether location is null.
1930
1931 2019-07-09  Pedro Alves  <palves@redhat.com>
1932
1933         PR c++/15468
1934         * breakpoint.c (print_one_breakpoint_location): Remove
1935         single-location assert.
1936
1937 2019-07-09  Tom Tromey  <tom@tromey.com>
1938
1939         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1940         * configure: Rebuild.
1941         * configure.ac: Change common to gdbsupport.
1942         * gdbsupport: Rename from common.
1943         * acinclude.m4: Change common to gdbsupport.
1944         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1945         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1946         gdbsupport.
1947         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1948         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1949         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1950         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1951         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1952         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1953         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1954         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1955         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1956         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1957         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1958         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1959         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1960         coff-pe-read.c, command.h, compile/compile-c-support.c,
1961         compile/compile-c.h, compile/compile-cplus-symbols.c,
1962         compile/compile-cplus-types.c, compile/compile-cplus.h,
1963         compile/compile-loc2c.c, compile/compile.c, completer.c,
1964         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1965         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1966         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1967         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1968         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1969         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1970         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1971         features/aarch64-core.c, features/aarch64-fpu.c,
1972         features/aarch64-pauth.c, features/aarch64-sve.c,
1973         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1974         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1975         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1976         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1977         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1978         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1979         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1980         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1981         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1982         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1983         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1984         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1985         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1986         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1987         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1988         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1989         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1990         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1991         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1992         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1993         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1994         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1995         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1996         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1997         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1998         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1999         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2000         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2001         minsyms.c, mips-linux-tdep.c, namespace.h,
2002         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2003         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2004         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2005         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2006         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2007         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2008         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2009         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2010         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2011         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2012         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2013         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2014         procfs.c, producer.c, progspace.h, psymtab.h,
2015         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2016         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2017         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2018         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2019         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2020         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2021         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2022         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2023         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2024         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2025         target-memory.c, target.c, target.h, target/waitstatus.c,
2026         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2027         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2028         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2029         unittests/array-view-selftests.c,
2030         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2031         unittests/common-utils-selftests.c,
2032         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2033         unittests/format_pieces-selftests.c,
2034         unittests/function-view-selftests.c,
2035         unittests/lookup_name_info-selftests.c,
2036         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2037         unittests/mkdir-recursive-selftests.c,
2038         unittests/observable-selftests.c,
2039         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2040         unittests/parse-connection-spec-selftests.c,
2041         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2042         unittests/scoped_fd-selftests.c,
2043         unittests/scoped_mmap-selftests.c,
2044         unittests/scoped_restore-selftests.c,
2045         unittests/string_view-selftests.c, unittests/style-selftests.c,
2046         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2047         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2048         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2049         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2050         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2051         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2052
2053 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2054
2055         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2056         bool value.
2057         (decode_digits_ordinary): Set explicit_line field in sal.
2058         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2059         symtab_and_line that was set on an explicit line number in
2060         assembler code.  Do always update the recorded symtab and line if
2061         we do skip the prologue.
2062
2063 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * breakpoint.c (set_breakpoint_location_function): Remove
2066         explicit_loc parameter.
2067         (momentary_breakpoint_from_master): Update call to
2068         set_breakpoint_location_function.
2069         (add_location_to_breakpoint): Likewise.
2070
2071 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2072
2073         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2074         required features based on default bfd type when no specific bfd
2075         is present.
2076
2077 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2078
2079         * NEWS: Mention that GDB printf and eval commands can now print
2080         C-style and Ada-style convenience var strings without
2081         calling the inferior.
2082         * printcmd.c (printf_c_string): Locally print GDB internal var
2083         instead of transiting via the inferior.
2084         (printf_wide_c_string): Likewise.
2085
2086 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2087
2088         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2089
2090 2019-07-04  Tom Tromey  <tom@tromey.com>
2091
2092         PR tui/24724:
2093         * tui/tui-winsource.c (tui_clear_source_content): Update.
2094         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2095         (tui_update_breakpoint_info): Update.
2096         (tui_set_exec_info_content): Update.
2097         * tui/tui-source.c (tui_set_source_content_nil): Update.
2098         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2099         has_break.
2100         * tui/tui-data.h (enum tui_bp_flag): New.
2101         (tui_bp_flags): New enum flags type.
2102         (struct tui_source_element) <break_mode>: Change type.  Rename
2103         from has_break.
2104         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2105         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2106         constants.
2107         * tui/tui-winsource.h: Fix comment.
2108
2109 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2110
2111         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2112         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2113         (store_fpregs_to_thread)
2114         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2115         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2116         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2117         (IWMMXT_REGS_SIZE): Add define.
2118         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2119         (fetch_vfp_regs, store_vfp_regs)
2120         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2121         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2122
2123 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2124
2125         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2126         defines.
2127         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2128         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2129         (ARM_INT_REGISTER_SIZE): ...to this.
2130         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2131         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2132         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2133         (arm_linux_collect_gregset, supply_nwfpe_register)
2134         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2135         defines.
2136         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2137         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2138         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2139         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2140         (arm_return_in_memory, arm_store_return_value)
2141         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2142         (arm_record_ld_st_multiple): Likewise.
2143         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2144         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2145
2146 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2147
2148         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2149         AARCH64_DISPLACED_MODIFIED_INSNS.
2150         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2151         (aarch64_displaced_step_copy_insn): Likewise.
2152         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2153         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2154         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2155         ARM_DISPLACED_MODIFIED_INSNS.
2156         * arm-tdep.c (arm_gdbarch_init): Likewise.
2157         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2158         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2159         (struct arm_displaced_step_closure): Use
2160         ARM_DISPLACED_MODIFIED_INSNS.
2161
2162 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2163
2164         * features/Makefile: Remove unused xml files.
2165         * features/aarch64.xml: Remove.
2166         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2167         * features/i386/amd64-avx-avx512.xml: Remove.
2168         * features/i386/amd64-avx-linux.xml: Remove.
2169         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2170         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2171         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2172         * features/i386/amd64-avx-mpx.xml: Remove.
2173         * features/i386/amd64-avx.xml: Remove.
2174         * features/i386/amd64-linux.xml: Remove.
2175         * features/i386/amd64-mpx-linux.xml: Remove.
2176         * features/i386/amd64-mpx.xml: Remove.
2177         * features/i386/amd64.xml: Remove.
2178         * features/i386/i386-avx-avx512-linux.xml: Remove.
2179         * features/i386/i386-avx-avx512.xml: Remove.
2180         * features/i386/i386-avx-linux.xml: Remove.
2181         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2182         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2183         * features/i386/i386-avx-mpx-linux.xml: Remove.
2184         * features/i386/i386-avx-mpx.xml: Remove.
2185         * features/i386/i386-avx.xml: Remove.
2186         * features/i386/i386-linux.xml: Remove.
2187         * features/i386/i386-mmx-linux.xml: Remove.
2188         * features/i386/i386-mmx.xml: Remove.
2189         * features/i386/i386-mpx-linux.xml: Remove.
2190         * features/i386/i386-mpx.xml: Remove.
2191         * features/i386/i386.xml: Remove.
2192         * features/i386/x32-avx-avx512-linux.xml: Remove.
2193         * features/i386/x32-avx-linux.xml: Remove.
2194         * features/i386/x32-linux.xml: Remove.
2195
2196 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2197
2198         * regformats/aarch64.dat: Remove.
2199         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2200         * regformats/i386/amd64-avx-linux.dat: Remove.
2201         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2202         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2203         * regformats/i386/amd64-linux.dat: Remove.
2204         * regformats/i386/amd64-mpx-linux.dat: Remove.
2205         * regformats/i386/amd64.dat: Remove.
2206         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2207         * regformats/i386/i386-avx-linux.dat: Remove.
2208         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2209         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2210         * regformats/i386/i386-linux.dat: Remove.
2211         * regformats/i386/i386-mmx-linux.dat: Remove.
2212         * regformats/i386/i386-mpx-linux.dat: Remove.
2213         * regformats/i386/i386.dat: Remove.
2214         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2215         * regformats/i386/x32-avx-linux.dat: Remove.
2216         * regformats/i386/x32-linux.dat: Remove.
2217
2218 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2219
2220         * aarch64-tdep.c: Remove xml self tests.
2221         * amd64-linux-tdep.c: Likewise.
2222         * amd64-tdep.c: Likewise.
2223         * i386-linux-tdep.c: Likewise.
2224         * i386-tdep.c: Likewise.
2225
2226 2019-07-03  Pedro Alves  <palves@redhat.com>
2227
2228         PR cli/24732
2229         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2230         (pipe_cmd_option_defs): New.
2231         (make_pipe_cmd_options_def_group): New.
2232         (pipe_command): Use gdb::option::process_options.
2233         (pipe_command_completer): New function.
2234         (_initialize_cli_cmds): Install completer for "pipe" command.
2235
2236 2019-07-03  Pedro Alves  <palves@redhat.com>
2237
2238         * cli/cli-option.c (union option_value) <string>: New field.
2239         (struct option_def_and_value): Add ctor, move ctor, dtor and
2240         use DISABLE_COPY_AND_ASSIGN.
2241         (option_def_and_value::clear_value): New.
2242         (parse_option, save_option_value_in_ctx, get_val_type_str)
2243         (add_setshow_cmds_for_options): Handle var_string.
2244         * cli-option.h (union option_def::var_address) <string>: New
2245         field.
2246         (struct string_option_def): New.
2247         * maint-test-options.c (struct test_options_opts): Add default
2248         ctor and use DISABLE_COPY_AND_ASSIGN.
2249         <string_opt>: New field.
2250         (test_options_opts::~test_options_opts): New.
2251         (test_options_opts::dump): Also dump "-string".
2252         (test_options_option_defs): Install "string.
2253
2254 2019-07-03  Pedro Alves  <palves@redhat.com>
2255
2256         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2257         option_value with a null enumeration.
2258         (complete_options): Save the option values in the context.
2259         (save_option_value_in_ctx): New, factored out from ...
2260         (process_options): ... here.
2261         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2262         of the function.
2263         * maint-test-options.c (test_options_opts::dump): New, factored
2264         out from ...
2265         (maintenance_test_options_command_mode): ... here.
2266         (maintenance_test_options_command_completion_result): Delete.
2267         (maintenance_test_options_command_completion_text): Update
2268         comment.
2269         (maintenance_show_test_options_completion_result): Change
2270         prototype.  Just print
2271         maintenance_test_options_command_completion_text.
2272         (save_completion_result): New.
2273         (maintenance_test_options_completer_mode): Pass options context to
2274         complete_options, and then save a dump.
2275         (_initialize_maint_test_options): Use add_cmd to install "maint
2276         show test-options-completion-result".
2277
2278 2019-07-03  Pedro Alves  <palves@redhat.com>
2279
2280         * NEWS (New commands): Mention "with" and "maint with".
2281         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2282         (with_command, with_command_completer): New.
2283         (pipe_command): Adjust to new repeat_previous
2284         interface.
2285         (_initialize_cli_cmds): Install the "with" command and its "w"
2286         alias.
2287         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2288         declarations.
2289         * cli/cli-setshow.c (parse_cli_var_uinteger)
2290         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2291         argument strings for all var_types.
2292         (get_setshow_command_value_string): New, factored out from ...
2293         (do_show_command): ... this.
2294         * cli/cli-setshow.h: Include <string>.
2295         (get_setshow_command_value_string): Declare.
2296         * command.h (repeat_previous): Now returns const char *.  Adjust
2297         comment.
2298         * maint.c: Include "cli/cli-cmds.h".
2299         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2300         (_initialize_maint_cmds): Register the "maintenance with" command.
2301         * top.c (repeat_previous): Move bits from pipe_command here:
2302         Return the saved command line, if any; error out if there's no
2303         command to relaunch.
2304
2305 2019-07-03  Pedro Alves  <palves@redhat.com>
2306
2307         * NEWS (New commands): Mention "maint set/show test-settings"
2308         instead of "maint test-settings".
2309         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2310         (maintenance_test_settings_set_list): Rename to ...
2311         (maintenance_set_test_settings_list): ... this.
2312         (maintenance_test_settings_show_list): Rename to  ...
2313         (maintenance_show_test_settings_list): ... this.
2314         (maintenance_test_settings_cmd): Delete.
2315         (maintenance_test_settings_set_cmd): ...
2316         (maintenance_set_test_settings_cmd): ... this.
2317         (maintenance_test_settings_show_cmd): ...
2318         (maintenance_show_test_settings_cmd): ... this.
2319         (maintenance_test_settings_show_value_cmd):
2320         (maintenance_show_test_settings_value_cmd): ... this.
2321         (_initialize_maint_test_settings): No longer install the "maint
2322         test-settings" prefix command.  Rename "maint test-settings set"
2323         to "maint set test-settings", and "maint test-settings show" to
2324         "maint show test-settings".  Adjust all subcommands.
2325
2326 2019-07-03  Pedro Alves  <palves@redhat.com>
2327
2328         * maint-test-settings.c: Fix file's intro comment.  Replace all
2329         references to "test-options" with references to "test-settings",
2330         in comments.
2331
2332 2019-07-03  Pedro Alves  <palves@redhat.com>
2333
2334         * maint-test-settings.c (maintenance_test_settings_xxx)
2335         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2336         New.
2337         (maintenance_test_settings_enums): Use them.
2338         (maintenance_test_settings_enum): Default to
2339         maintenance_test_settings_xxx.
2340         (_initialize_maint_test_settings): Initialize
2341         MAINTENANCE_TEST_SETTINGS_FILENAME.
2342
2343 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2344
2345         * breakpoint.h (remove_breakpoints_inf): Change return type to
2346         void, move function documentation here.
2347         * breakpoint.c (remove_breakpoints_inf): Change return type to
2348         void, move function documentation to header.
2349
2350 2019-07-02  Pedro Alves  <palves@redhat.com>
2351
2352         * NEWS (Completion improvements): Mention "info threads".
2353         * thread.c (struct info_threads_opts, info_threads_option_defs)
2354         (make_info_threads_options_def_group): New.
2355         (info_threads_command): Use gdb::option::process_options.
2356         (info_threads_command_completer): New.
2357         (_initialize_thread): Use gdb::option::build_help to build the
2358         help text for "info threads".
2359
2360 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2361
2362         * defs.h (generic_load): Move from here...
2363         * symfile.h (generic_load): ... to here.  Rename name parameter
2364         to args.
2365         * symfile.c (generic_load): Add comment.
2366
2367 2019-07-01  Tom Tromey  <tromey@adacore.com>
2368
2369         * dwarf2read.c
2370         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2371         declaration of without_params.  Fix formatting.
2372
2373 2019-07-01  Tom Tromey  <tromey@adacore.com>
2374
2375         * ada-exp.y (find_primitive_type): Update.
2376         * ada-lang.h (ada_lookup_symbol): Update.
2377         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2378         parameter.
2379         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2380
2381 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2382
2383         PR breakpoints/24541
2384         * gdbarch.c: Regenerate.
2385         * gdbarch.h: Regenerate.
2386         * gdbarch.sh: Add 'stap_adjust_register'.
2387         * i386-tdep.c: Include '<unordered_set>'.
2388         (i386_stap_adjust_register): New function.
2389         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2390         * stap-probe.c (stap_parse_register_operand): Call
2391         'gdbarch_stap_adjust_register'.
2392
2393 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2394
2395         PR python/24742
2396         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2397         * python/python.c (do_start_initialization): Use 'xmalloc'
2398         instead of 'PyMem_Malloc'.
2399
2400 2019-06-28  Tom Tromey  <tromey@adacore.com>
2401
2402         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2403         for Ada.
2404
2405 2019-06-27  Tom Tromey  <tromey@adacore.com>
2406
2407         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2408         objfile_key.
2409         (arm_find_mapping_symbol, arm_record_special_symbol)
2410         (_initialize_arm_tdep): Update.
2411         (arm_objfile_data_free): Remove.
2412
2413 2019-06-27  Tom Tromey  <tromey@adacore.com>
2414
2415         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2416         to cp_print_static_field.
2417
2418 2019-06-26  Tom Tromey  <tromey@adacore.com>
2419
2420         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2421         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2422         declare.
2423
2424 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2425
2426         * features/aarch64-core.c (create_feature_aarch64_core):
2427         Regenerate.
2428         * features/aarch64-core.xml: Add cpsr flags.
2429
2430 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2431
2432         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2433         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2434
2435 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2436
2437         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2438         field.
2439         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2440         use.
2441         (arm_record_special_symbol): Don't insert new symbol in sorted
2442         position, push it at the end.
2443
2444 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2445
2446         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2447         (arm_mapping_symbol_s): Remove.
2448         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2449         (arm_mapping_symbol_vec): New typedef.
2450         (struct arm_per_objfile): Add constructor.
2451         <section_maps>: Change type to
2452         std::unique_ptr<arm_mapping_symbol_vec[]>.
2453         (arm_compare_mapping_symbols): Remove.
2454         (arm_find_mapping_symbol): Adjust to section_maps type change.
2455         (arm_objfile_data_free): Call delete on arm_per_objfile.
2456         (arm_record_special_symbol): Adjust to section_maps type change.
2457         Allocate arm_per_objfile with new.
2458
2459 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2460
2461         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2462         with the command prefix.
2463
2464 2019-06-25  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2467         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2468
2469 2019-06-25  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2472         type.
2473         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2474         protected.
2475
2476 2019-06-25  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-winsource.c
2479         (tui_source_window_base::set_is_exec_point_at): Add check against
2480         LOA_ADDRESS.
2481
2482 2019-06-25  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-source.c (tui_set_source_content): Don't check before
2485         xfree.
2486         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-winsource.h (tui_update_source_window_as_is)
2491         (tui_alloc_source_buffer, tui_line_is_displayed)
2492         (tui_addr_is_displayed): Change type of win_info.
2493         * tui/tui-winsource.c (tui_update_source_window_as_is)
2494         (tui_clear_source_content, tui_show_source_line)
2495         (tui_show_source_content, tui_source_window_base::refill)
2496         (tui_source_window_base::set_is_exec_point_at)
2497         (tui_source_window_base::set_is_exec_point_at)
2498         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2499         (tui_alloc_source_buffer, tui_line_is_displayed)
2500         (tui_addr_is_displayed): Change type of win_info.  Update.
2501         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2502         (tui_source_window_base::do_make_visible_with_new_height):
2503         Update.
2504         * tui/tui-source.c (tui_set_source_content)
2505         (tui_set_source_content_nil)
2506         (tui_source_window::do_scroll_vertical): Update.
2507         * tui/tui-layout.c (show_layout): Update.
2508         * tui/tui-disasm.c (tui_set_disassem_content)
2509         (tui_disasm_window::do_scroll_vertical): Update.
2510         * tui/tui-data.h (tui_win_content): Remove.
2511         (struct tui_gen_win_info) <content, content_size>: Remove.
2512         (struct tui_source_element): Add initializers and destructor.
2513         (union tui_which_element, struct tui_win_element): Remove.
2514         (struct tui_source_window_base) <content>: New field.
2515         (struct tui_data_window): Remove destructor.
2516         (tui_alloc_content, tui_free_win_content)
2517         (tui_free_all_source_wins_content): Don't declare.
2518         * tui/tui-data.c (tui_initialize_static_data): Update.
2519         (init_content_element, tui_alloc_content): Remove.
2520         (~tui_gen_win_info): Update.
2521         (~tui_data_window, tui_free_all_source_wins_content)
2522         (tui_free_win_content, free_content, free_content_elements):
2523         Remove.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-winsource.h (tui_clear_source_content)
2528         (tui_erase_source_content, tui_show_source_content): Change type
2529         of win_info.
2530         * tui/tui-winsource.c (tui_clear_source_content)
2531         (tui_erase_source_content, tui_show_source_content): Change type
2532         of win_info.
2533         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2534         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2535         win_info.
2536         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2537         win_info.
2538         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-winsource.c (tui_clear_source_content)
2543         (tui_source_window_base::set_is_exec_point_at): Update.
2544         * tui/tui-source.c (tui_set_source_content_nil): Update.
2545         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2546         a bool.
2547         * tui/tui-data.c (init_content_element): Update.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2552         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2553         * tui/tui-layout.c (init_and_make_win): Update.
2554         * tui/tui.h (enum tui_win_type): Update.
2555         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2556         tui_win_is_auxillary.
2557         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2558         tui_win_is_auxillary.
2559
2560 2019-06-25  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2563         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2564         (tui_delete_data_content_windows, tui_display_all_data)
2565         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2566         Update.
2567         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2568         * tui/tui-regs.c (tui_last_regs_line_no)
2569         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2570         (tui_show_registers): Update.
2571         (tui_show_register_group): Return void.  Update.
2572         (tui_display_registers_from, tui_display_reg_element_at_line)
2573         (tui_display_registers_from_line, tui_check_register_values):
2574         Update.
2575         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2576         member.
2577         (struct tui_data_window) <regs_content>: Now a std::vector.
2578         <regs_content_count>: Remove.
2579         (tui_add_content_elements, tui_free_data_content): Don't declare.
2580         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2581         (init_content_element): Remove DATA_WIN case.  Add assert.
2582         (tui_add_content_elements): Remove.
2583         (tui_data_window): Update.
2584         (tui_free_data_content): Remove.
2585         (free_content_elements): Remove DATA_WIN case.
2586
2587 2019-06-25  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-data.c (tui_data_item_window): Update.
2590         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2591         * tui/tui-windata.c (tui_display_all_data)
2592         (tui_display_data_from_line): Update.
2593         (tui_check_data_values): Remove.
2594         * tui/tui-regs.c (tui_show_register_group)
2595         (tui_display_reg_element_at_line): Update.
2596         * tui/tui-hooks.c (tui_register_changed)
2597         (tui_refresh_frame_and_register_information): Call
2598         tui_check_register_values.
2599         * tui/tui-data.h (struct tui_data_window) <data_content,
2600         data_content_count, data_type>: Remove.
2601         (enum tui_data_type): Remove.
2602
2603         * tui/tui-data.c (tui_data_window::clear_detail)
2604         (~tui_data_window): Update.
2605
2606 2019-06-25  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2609         declare.
2610         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2611         Rename from tui_first_data_item_displayed.  Update.
2612         (tui_data_window::refresh_all)
2613         (tui_data_window::do_scroll_vertical): Update.
2614         * tui/tui-data.h (struct tui_data_window)
2615         <first_data_item_displayed>: Declare new method.
2616
2617 2019-06-25  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2620         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2621         contents...
2622         (tui_initialize_static_data): ...here.
2623
2624 2019-06-25  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2627         (tui_display_registers_from, tui_check_register_values): Update.
2628         (tui_display_register): Remove win_info parameter; update.
2629         (tui_get_register): Change type of parameters.
2630         * tui/tui-data.h (struct tui_data_element): Remove.
2631         (union tui_which_element) <data>: Remove.
2632         <data_window>: Change type.
2633         (struct tui_data_item_window): New.
2634         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2635         case.  Add assert.
2636         (~tui_data_item_window): New destructor.
2637         (free_content_elements): Remove DATA_ITEM_WIN case.
2638
2639 2019-06-25  Tom Tromey  <tom@tromey.com>
2640
2641         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2642         Remove.
2643
2644 2019-06-25  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-data.h (struct tui_command_element): Remove.
2647         (union tui_which_element) <command>: Remove.
2648         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2649         assert.
2650         (free_content_elements): Remove CMD_WIN case.
2651
2652 2019-06-25  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-layout.c (tui_set_layout): Update.
2655         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2656         * tui/tui-data.c (layout_def): Update.
2657
2658 2019-06-25  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2661         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2662         (tui_source_window_base::set_new_height): Update.
2663         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2664         Update.
2665         (tui_set_locator_fullname, tui_set_locator_info)
2666         (tui_show_frame_info): Update.
2667         * tui/tui-source.c (tui_set_source_content)
2668         (tui_source_is_displayed): Update.
2669         * tui/tui-layout.c (show_source_disasm_command, show_data)
2670         (show_source_or_disasm_and_command): Update.
2671         * tui/tui-disasm.c (tui_set_disassem_content)
2672         (tui_get_begin_asm_address): Update.
2673         * tui/tui-data.h (struct tui_locator_element): Remove.
2674         (union tui_which_element) <locator>: Remove.
2675         (struct tui_locator_window): New.
2676         (tui_locator_win_info_ptr): Change return type.
2677         * tui/tui-data.c (_locator): Change type.
2678         (tui_locator_win_info_ptr): Change return type.
2679         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2680         (tui_alloc_content): Add assert.
2681
2682 2019-06-25  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-winsource.c
2685         (tui_exec_info_window::maybe_allocate_content): New method.
2686         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2687         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2688         (make_source_or_disasm_window): Add cast.
2689         * tui/tui-data.h (union tui_which_element) <simple_string>:
2690         Remove.
2691         (struct tui_source_info): New.
2692         (struct tui_source_window_base) <execution_info>: Change type.
2693         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2694         case, and add assert.
2695         (tui_alloc_content): Add assert.
2696
2697 2019-06-25  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2700         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2701         * tui/tui-data.c (tui_alloc_win_info): Remove.
2702
2703 2019-06-25  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2706         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2707         can_highlight.
2708
2709 2019-06-25  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2712         make_visible_with_new_height method.
2713         (tui_win_info::make_visible_with_new_height): New method.
2714         (tui_source_window_base::do_make_visible_with_new_height)
2715         (tui_data_window::do_make_visible_with_new_height)
2716         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2717         (make_visible_with_new_height): Remove.
2718         (tui_resize_all, tui_adjust_win_heights): Use
2719         make_visible_with_new_height method.
2720         * tui/tui-data.h (struct tui_win_info)
2721         <do_make_visible_with_new_height, make_visible_with_new_height>:
2722         New methods.
2723         (struct tui_source_window_base, struct tui_data_window)
2724         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2725         methods.
2726
2727 2019-06-25  Tom Tromey  <tom@tromey.com>
2728
2729         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2730         method.
2731         (update_tab_width): Call update_tab_width method.
2732         * tui/tui-data.h (struct tui_win_info)
2733         (struct tui_source_window_base) <update_tab_width>: New methods.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2738         parameter.
2739         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2740         parameter.
2741         (tui_gen_win_info::make_visible): Update.
2742         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2743         parameter.
2744         * tui/tui-data.h (enum tui_box): New enum.
2745         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2750         init_and_make_win for EXEC_INFO_WIN.
2751         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2752         longer inline.
2753         (struct tui_win_info) <~tui_win_info>: Inline.
2754         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2755         Don't declare.
2756         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2757         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2758         Remove.
2759         (tui_initialize_static_data): Update.
2760         (~tui_gen_win_info): Handle more cleanup here.
2761         (~tui_source_window_base): Delete "execution_info".
2762         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2763
2764 2019-06-25  Tom Tromey  <tom@tromey.com>
2765
2766         * tui/tui-layout.c (make_command_window): Don't set
2767         can_highlight.
2768         (show_source_disasm_command): Call the reset method.
2769         (show_data): Don't set can_highlight.  Call the reset method.
2770         (tui_gen_win_info::reset): Rename from init_gen_win_info
2771         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2772         (show_source_or_disasm_and_command): Call the reset method.
2773         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2774         (struct tui_cmd_window): Set can_highlight.
2775
2776 2019-06-25  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2779         from make_visible.
2780         (tui_make_visible, tui_make_invisible): Rewrite.
2781         (tui_win_info::make_visible): Remove.
2782         (tui_source_window_base::make_visible): Update.
2783         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2784         method.  Moved from...
2785         (struct tui_win_info) <make_visible>: ...here.
2786
2787 2019-06-25  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-winsource.c
2790         (tui_source_window_base::do_scroll_horizontal): Remove direction
2791         parameter.
2792         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2793         direction parameter.
2794         * tui/tui-win.c (tui_win_info::forward_scroll)
2795         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2796         (tui_win_info::right_scroll): Update.
2797         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2798         direction parameter.
2799         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2800         direction parameter.
2801         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2802         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2803         Remove direction parameter.
2804         (struct tui_source_window_base, struct tui_source_window)
2805         (struct tui_disasm_window, struct tui_data_window)
2806         (struct tui_cmd_window): Update.
2807
2808 2019-06-25  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-winsource.h (tui_set_exec_info_content)
2811         (tui_show_exec_info_content, tui_erase_exec_info_content)
2812         (tui_clear_exec_info_content, tui_update_exec_info): Change
2813         argument to tui_source_window_base.
2814         * tui/tui-winsource.c (tui_set_exec_info_content)
2815         (tui_show_exec_info_content, tui_erase_exec_info_content)
2816         (tui_clear_exec_info_content, tui_update_exec_info): Change
2817         argument to tui_source_window_base.
2818
2819 2019-06-25  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2822         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2827         check.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2832         type to void.
2833         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2834         type to void.
2835         * tui/tui-source.c (tui_set_source_content): Update.
2836         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2837
2838 2019-06-25  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-win.c (window_name_completer, tui_set_focus)
2841         (tui_all_windows_info): Use name method.
2842         * tui/tui-data.h (struct tui_gen_win_info)
2843         (struct tui_source_window, struct tui_disasm_window)
2844         (struct tui_data_window, struct tui_cmd_window) <name>: New
2845         method.
2846         (tui_win_name): Don't declare.
2847         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2848         (tui_win_name): Remove.
2849
2850 2019-06-25  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-winsource.h (tui_update_source_window)
2853         (tui_update_source_window_as_is): Change parameter type.
2854         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2855         to be a tui_source_window_base.
2856         (tui_update_source_window_as_is): Likewise.
2857         * tui/tui-win.c (make_visible_with_new_height): Update.
2858
2859 2019-06-25  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-winsource.c (tui_erase_source_content)
2862         (tui_show_source_content, tui_show_exec_info_content)
2863         (tui_erase_exec_info_content): Use refresh_window method.
2864         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2865         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2866         from tui_refresh_win.
2867         (tui_data_window::refresh_window): New method.
2868         (tui_win_info::refresh, tui_source_window_base::refresh)
2869         (tui_refresh_all): Use refresh_window method.
2870         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2871         method.
2872         * tui/tui-regs.c (tui_display_register): Call refresh_window
2873         method.
2874         * tui/tui-layout.c (show_source_disasm_command)
2875         (show_source_or_disasm_and_command): Call refresh_window method.
2876         * tui/tui-data.h (struct tui_gen_win_info)
2877         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2878         New method.
2879
2880 2019-06-25  Tom Tromey  <tom@tromey.com>
2881
2882         * tui/tui.c (tui_rl_other_window, tui_enable)
2883         (tui_is_window_visible, tui_get_command_dimension): Update.
2884         * tui/tui-winsource.c (tui_update_source_window_as_is)
2885         (tui_clear_source_content, tui_erase_source_content)
2886         (tui_show_source_line, tui_source_window_base::refill)
2887         (tui_source_window_base::do_scroll_horizontal)
2888         (tui_source_window_base::set_is_exec_point_at)
2889         (tui_update_breakpoint_info, tui_set_exec_info_content)
2890         (tui_alloc_source_buffer, tui_line_is_displayed)
2891         (tui_addr_is_displayed): Update.
2892         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2893         (tui_check_and_display_highlight_if_needed)
2894         (tui_win_info::make_visible, tui_win_info::refresh)
2895         (tui_refresh_all): Update.
2896         * tui/tui-windata.c (tui_first_data_item_displayed)
2897         (tui_delete_data_content_windows, tui_erase_data_content)
2898         (tui_display_all_data, tui_data_window::refresh_all)
2899         (tui_check_data_values): Update.
2900         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2901         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2902         (tui_win_info::backward_scroll, tui_refresh_all_win)
2903         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2904         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2905         (tui_source_window_base::set_new_height)
2906         (tui_data_window::set_new_height)
2907         (make_invisible_and_set_new_height)
2908         (make_visible_with_new_height, new_height_ok)
2909         (parse_scrolling_args): Update.
2910         * tui/tui-stack.c (tui_show_frame_info): Update.
2911         * tui/tui-source.c (tui_set_source_content)
2912         (tui_set_source_content_nil, tui_source_is_displayed)
2913         (tui_source_window::do_scroll_vertical): Update.
2914         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2915         (tui_display_registers_from, tui_display_reg_element_at_line)
2916         (tui_check_register_values, tui_reg_command): Update.
2917         * tui/tui-layout.c (tui_default_win_height)
2918         (show_source_disasm_command, show_data, init_and_make_win)
2919         (show_source_or_disasm_and_command): Update.
2920         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2921         (tui_redisplay_readline, tui_mld_flush)
2922         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2923         (tui_getc): Update.
2924         * tui/tui-disasm.c (tui_set_disassem_content)
2925         (tui_disasm_window::do_scroll_vertical): Update.
2926         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2927         Now virtual.
2928         (struct tui_win_info): Derive from tui_gen_win_info.
2929         <~tui_win_info>: Mark as override.
2930         <generic>: Remove member.
2931         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2932         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2933         (~tui_data_window, ~tui_win_info)
2934         (tui_free_all_source_wins_content): Update.
2935         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-layout.c (init_and_make_win): Use new.
2940         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2941         destructor, initializers.
2942         (tui_alloc_generic_win_info): Don't declare.
2943         * tui/tui-data.c (_locator): Add argument to constructor.
2944         (source_win, disasm_win): New globals.
2945         (exec_info): Remove.
2946         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2947         Update.
2948         (tui_alloc_generic_win_info): Remove.
2949         (init_content_element): Use new.
2950         (tui_win_info::tui_win_info): Update.
2951         (free_content_elements) <case DATA_WIN>: Use delete.
2952
2953 2019-06-25  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2956         * tui/tui-windata.c (tui_first_data_item_displayed)
2957         (tui_delete_data_content_windows): Update.
2958         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2959         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2960         (tui_display_registers_from, tui_check_register_values): Update.
2961         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2962         pointer.
2963         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2964         window.
2965         (tui_free_data_content): Update.
2966         (free_content_elements) <case DATA_WIN>: Free the window.
2967
2968 2019-06-25  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2971         Update.
2972         * tui/tui-layout.c (make_command_window)
2973         (show_source_disasm_command, show_data, init_and_make_win)
2974         (show_source_or_disasm_and_command): Update.
2975         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2976         method.
2977         <can_highight, is_highlighted>: Now bool.
2978         (tui_set_win_highlight): Don't declare.
2979         * tui/tui-data.c (tui_set_win_highlight): Remove.
2980
2981 2019-06-25  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-wingeneral.c (make_visible): Remove check of window
2984         type.
2985
2986 2019-06-25  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-win.c (tui_win_info::max_height)
2989         (tui_cmd_window::max_height): New methods.
2990         (new_height_ok): Call max_height.
2991         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2992         <max_height>: New method.
2993
2994 2019-06-25  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-win.c (tui_source_window_base::set_new_height)
2997         (tui_data_window::set_new_height): New methods.
2998         (make_invisible_and_set_new_height): Call set_new_height method.
2999         * tui/tui-data.h (struct tui_win_info)
3000         (struct tui_source_window_base, struct tui_data_window)
3001         <set_new_height>: New method.
3002
3003 2019-06-25  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3006         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3007         tui_refresh_data_win.
3008         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3009         method.
3010         (tui_refresh_all_win): Call the refresh_all method.
3011         (tui_set_focus): Likewise.
3012         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3013         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3014         Likewise.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-winsource.h (tui_refill_source_window)
3019         (tui_set_is_exec_point_at): Don't declare.
3020         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3021         (tui_source_window_base::refill): Rename from
3022         tui_refill_source_window.
3023         (tui_source_window_base::do_scroll_horizontal): Update.
3024         (tui_source_window_base::set_is_exec_point_at): Rename from
3025         tui_set_is_exec_point_at.
3026         (tui_update_all_breakpoint_info): Update.
3027         * tui/tui-stack.c (tui_show_frame_info): Update.
3028         * tui/tui-layout.c (show_data): Add cast.
3029         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3030         * tui/tui-data.h (struct tui_source_window_base) <refill,
3031         set_is_exec_point_at>: New methods.
3032         (tui_source_windows, tui_add_to_source_windows): Update types.
3033         (tui_add_to_source_windows): Remove redundant declaration.
3034         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3035         (tui_source_windows): Change return type.
3036         (tui_clear_source_windows_detail): Update.
3037         (tui_add_to_source_windows): Change type of parameter.
3038         (tui_free_all_source_wins_content): Update.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-wingeneral.c (tui_win_info::refresh)
3043         (tui_source_window_base::refresh): New methods.
3044         (tui_refresh_all): Call the refresh method.
3045         * tui/tui-data.h (struct tui_win_info)
3046         (struct tui_source_window_base) <refresh>: New method.
3047
3048 2019-06-25  Tom Tromey  <tom@tromey.com>
3049
3050         * tui/tui.h (tui_is_window_visible): Return bool.
3051         * tui/tui.c (tui_is_window_visible): Return bool.
3052         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3053         (tui_make_visible, tui_make_invisible)
3054         (tui_win_info::make_visible)
3055         (tui_source_window_base::make_visible, make_all_visible)
3056         (tui_make_all_visible, tui_make_all_invisible): Update.
3057         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3058         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3059         bool.
3060         (struct tui_win_info, struct tui_source_window_base)
3061         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3062         * tui/tui-data.c (tui_init_generic_part): Update.
3063
3064 2019-06-25  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3067         (tui_source_window_base::make_visible): New methods.
3068         (make_all_visible): Make method call.
3069         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3070         (struct tui_source_window_base, struct tui_cmd_window): Override
3071         make_visible.
3072         (tui_win_is_source_type): Don't declare.
3073         * tui/tui-data.c (tui_win_is_source_type): Remove.
3074
3075 2019-06-25  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3078         NULL check.
3079
3080 2019-06-25  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3083         Inline constructor.  Add initializers for members.
3084         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3085         constructors; now inline in class.
3086
3087 2019-06-25  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-regs.c (tui_show_registers): Update.
3090         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3091         bool.
3092         * tui/tui-data.c (tui_data_window::clear_detail)
3093         (tui_data_window): Update.
3094
3095 2019-06-25  Tom Tromey  <tom@tromey.com>
3096
3097         * tui/tui-windata.c (tui_display_all_data)
3098         (tui_display_data_from_line, tui_display_data_from)
3099         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3100         Update.
3101         * tui/tui-regs.c (tui_last_regs_line_no)
3102         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3103         (tui_show_registers, tui_show_register_group)
3104         (tui_display_registers_from, tui_display_reg_element_at_line)
3105         (tui_display_registers_from_line, tui_check_register_values)
3106         (tui_reg_next, tui_reg_prev): Update.
3107         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3108         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3109         tui_data_window.
3110         (struct tui_win_info) <detail>: Remove.  Add new fields from
3111         tui_data_info.
3112         (TUI_DATA_WIN): Add cast.
3113         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3114         (~tui_data_window): Simplify.
3115
3116 2019-06-25  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-layout.c (show_source_disasm_command)
3119         (show_source_or_disasm_and_command): Update.
3120         * tui/tui-io.c (update_cmdwin_start_line)
3121         (tui_redisplay_readline): Update.
3122         * tui/tui-data.h (struct tui_command_info): Remove.
3123         (struct tui_win_info) <detail>: Remove command_info member.
3124         (struct tui_data_window) <start_line>: New member, from
3125         tui_command_info.
3126         (TUI_CMD_WIN): Add casts.
3127
3128 2019-06-25  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-winsource.c (tui_update_source_window)
3131         (tui_refill_source_window)
3132         (tui_source_window_base::do_scroll_horizontal)
3133         (tui_update_breakpoint_info, tui_set_exec_info_content)
3134         (tui_show_exec_info_content, tui_erase_exec_info_content)
3135         (tui_clear_exec_info_content): Update.
3136         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3137         Update.
3138         * tui/tui-win.c (make_invisible_and_set_new_height)
3139         (make_visible_with_new_height): Update.
3140         * tui/tui-source.c (tui_set_source_content)
3141         (tui_show_symtab_source): Update.
3142         * tui/tui-layout.c (extract_display_start_addr)
3143         (show_source_disasm_command, show_data)
3144         (make_source_or_disasm_window)
3145         (show_source_or_disasm_and_command): Update.
3146         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3147         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3148         "gdbarch".
3149         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3150         to tui_source_window_base.
3151         (struct tui_win_info) <detail>: Remove source_info member.
3152         (struct tui_source_window_base) <has_locator>: Inline.
3153         Move contents from tui_source_info; rename has_locator member to
3154         m_has_locator.
3155         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3156         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3157         header file.
3158         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3159         Simplify.
3160         (tui_free_all_source_wins_content): Cast to
3161         tui_source_window_base.
3162
3163 2019-06-25  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-win.c (make_invisible_and_set_new_height)
3166         (make_visible_with_new_height): Call has_locator method.
3167         * tui/tui-layout.c (show_source_disasm_command, show_data)
3168         (show_source_or_disasm_and_command): Update for bool change.
3169         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3170         (tui_win_info) <has_locator>: New method.
3171         (struct tui_source_window_base) <has_locator>: New method.
3172         (tui_win_has_locator): Don't declare.
3173         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3174         from tui_win_has_locator.
3175         (tui_source_window_base): Use false, not FALSE.
3176
3177 2019-06-25  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3180         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3181         clear_detail method directly.
3182         (tui_clear_win_detail): Remove.
3183
3184 2019-06-25  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3187         "this", not TUI_DISASM_WIN.
3188
3189 2019-06-25  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3192         declare.
3193         * tui/tui-winsource.c
3194         (tui_source_window_base::do_scroll_horizontal): Rename from
3195         tui_horizontal_source_scroll.
3196         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3197         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3198         from tui_vertical_data_scroll.
3199         * tui/tui-win.h (tui_scroll): Don't declare.
3200         * tui/tui-win.c (tui_win_info::forward_scroll)
3201         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3202         (tui_win_info::right_scroll): Rename and update.
3203         (tui_scroll_forward_command, tui_scroll_backward_command)
3204         (tui_scroll_left_command, tui_scroll_right_command): Update.
3205         (tui_scroll): Remove.
3206         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3207         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3208         from tui_vertical_source_scroll.
3209         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3210         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3211         from tui_vertical_disassem_scroll.
3212         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3213         do_scroll_horizontal>: New methods.
3214         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3215         Likewise.
3216         (struct tui_source_window_base): Add do_scroll_horizontal.
3217         (struct tui_source_window, struct tui_disasm_window): Add
3218         do_scroll_vertical.
3219         (struct tui_data_window, struct tui_cmd_window): Add
3220         do_scroll_horizontal and do_scroll_vertical.
3221         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3222
3223 2019-06-25  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-data.h (struct tui_source_window_base): New struct.
3226         (struct tui_source_window): Derive from tui_source_window_base.
3227         (struct tui_disasm_window): New struct.
3228         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3229         from tui_source_window::clear_detail.
3230         (tui_source_window_base): Rename from tui_source_window.
3231         (~tui_source_window_base): Rename from ~tui_source_window.
3232         (tui_alloc_win_info): Create a tui_disasm_window.
3233
3234 2019-06-25  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-data.h (struct tui_source_window)
3237         (struct tui_data_window): Declare destructors.
3238         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3239         destructors.
3240         (tui_win_info): Simplify.
3241
3242 2019-06-25  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-winsource.c (tui_display_main)
3245         (tui_update_source_windows_with_addr)
3246         (tui_update_all_breakpoint_info): Update.
3247         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3248         (new_height_ok, parse_scrolling_args): Update.
3249         * tui/tui-stack.c (tui_show_frame_info): Update.
3250         * tui/tui-data.h (struct tui_list): Remove.
3251         (tui_source_windows): Return a reference to a std::vector.
3252         * tui/tui-data.c (source_windows): Now a std::vector.
3253         (tui_source_windows): Change return type.
3254         (tui_clear_source_windows): Rewrite.
3255         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3256         (tui_free_all_source_wins_content): Rewrite.
3257
3258 2019-06-25  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3261         (struct tui_data_window, struct tui_cmd_window): Declare
3262         clear_detail method.
3263         * tui/tui-data.c (tui_source_window::clear_detail)
3264         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3265         methods.
3266         (tui_clear_win_detail): Simplify.
3267
3268 2019-06-25  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-layout.c (make_source_window, make_disasm_window)
3271         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3272         Return the new window.
3273         (show_source_disasm_command, show_data)
3274         (show_source_or_disasm_and_command): Update.
3275
3276 2019-06-25  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3279         parameter.  Return the new window.
3280         (show_source_disasm_command): Update and remove NULL check.
3281         (show_source_or_disasm_and_command): Update.
3282
3283 2019-06-25  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3286
3287 2019-06-25  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-data.h (struct tui_win_info): Make constructor
3290         protected.  Make destructor virtual.  Add initializers.
3291         (tui_source_window, tui_data_window, tui_cmd_window): New
3292         classes.
3293         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3294         constructor.  Add "type" parameter.
3295         (tui_source_window, tui_data_window, tui_cmd_window): New
3296         constructors.
3297         (tui_alloc_win_info): Instantiate the appropriate subclass.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-win.c (tui_resize_all): Use delete.
3302         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3303         destructor.
3304         (tui_free_window): Don't declare.
3305         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3306         Update.
3307
3308 2019-06-25  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-data.h (struct tui_win_info): Add constructor.
3311         * tui/tui-data.c (tui_alloc_win_info): Use new.
3312         (tui_free_window): Use delete.
3313
3314 2019-06-22  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3317         declare.
3318         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3319
3320 2019-06-22  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3323         declare.
3324         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3325
3326 2019-06-22  Tom de Vries  <tdevries@suse.de>
3327
3328         * dwarf2read.c (create_addrmap_from_aranges)
3329         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3330         instead of '%zu'.
3331
3332 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3333
3334         * dwarf2read.h (dwarf2_section_info_def): Remove.
3335         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3336         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3337         std::vector<dwarf2_section_info>.
3338         (struct dwo_file) <~dwo_file>: Remove.
3339         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3340         types field.
3341         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3342         (dwarf2_read_debug_names): Likewise.
3343         (create_debug_types_hash_table): Change parameter type to
3344         array_view, adjust code accordingly.
3345         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3346         (partial_die_info::fixup): Likewise.
3347         (determine_prefix): Likewise.
3348         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3349
3350 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3351
3352         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3353         gdb_bfd_ref_ptr.
3354         <~dwo_file>: Remove call to gdb_bfd_unref.
3355         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3356         gdb_bfd_ref_ptr::get.
3357
3358 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3359
3360         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3361         type to htab_up.
3362         * dwarf2read.c (struct dwo_file): Initialize fields.
3363         <~dwo_file>: New.
3364         (free_dwo_file): Remove, move content to ~dwo_file.
3365         (struct dwo_file_deleter): Remove.
3366         (dwo_file_up>: Remove custom deleter.
3367         (free_dwo_files): Remove.
3368         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3369         dwo_files.
3370         (process_skeletonless_type_units): Call unique_ptr::get.
3371         (allocate_dwo_file_hash_table): Add deleter to created hash
3372         table.  Change return type to htab_up.
3373         (lookup_dwo_file_slot): Don't memset dwo_file, call
3374         unique_ptr::get.
3375         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3376         (create_dwo_unit_in_dwp_v2): Likewise.
3377         (open_and_init_dwo_file): Likewise.
3378         (free_dwo_file_from_slot): Remove.
3379
3380 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3381
3382         * dwarf2read.h (struct dwarf2_section_info) <readin,
3383         is_virtual>: Change type to bool.
3384         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3385         true instead of 1.
3386
3387 2019-06-19  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-data.h (tui_init_content_element): Don't declare.
3390
3391 2019-06-19  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-data.h (tui_init_win_info): Don't declare.
3394
3395 2019-06-19  Tom de Vries  <tdevries@suse.de>
3396
3397         * dwarf2read.h (abstract_to_concrete): Change type to
3398         std::unordered_map<sect_offset, std::vector<sect_offset>,
3399         gdb::hash_enum<sect_offset>>.
3400
3401 2019-06-19  Tom Tromey  <tromey@adacore.com>
3402
3403         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3404         EVAL_AVOID_SIDE_EFFECTS specially.
3405
3406 2019-06-19  Tom Tromey  <tromey@adacore.com>
3407
3408         * source-cache.c (highlighter): New global.
3409         (source_cache::get_source_lines): Create a highlighter on demand.
3410
3411 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * defs.h (deprecated_interactive_hook): Delete declaration.
3414         * interps.c (clear_interpreter_hooks): Remove use of
3415         deprecated_interactive_hook.
3416         * top.c (deprecated_interactive_hook): Delete definition.
3417         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3418
3419 2019-06-18  Tom de Vries  <tdevries@suse.de>
3420
3421         PR gdb/24515
3422         * dwarf2read.h (abstract_to_concrete): Change type from
3423         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3424         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3425         * dwarf2read.c (read_variable): Update.
3426         (dwarf2_fetch_die_loc_sect_off): Update.
3427
3428 2019-06-17  Tom de Vries  <tdevries@suse.de>
3429
3430         PR gdb/24617
3431         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3432         accessing parent[parent_len - 1].
3433
3434 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3435
3436         PR gdb/24364
3437         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3438         call dtrace_process_dof with NULL dof.
3439
3440 2019-06-16  Tom de Vries  <tdevries@suse.de>
3441
3442         PR gdb/24445
3443         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3444
3445 2019-06-16  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3448         (make_all_visible): Use address of member.
3449
3450 2019-06-16  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3453         (tui_free_window, free_content, free_content_elements): Remove
3454         unnecessary cast.
3455         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3456         cast.
3457         * tui/tui-regs.c (tui_show_register_group)
3458         (tui_display_registers_from, tui_display_reg_element_at_line):
3459         Remove unnecessary cast.
3460
3461 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         * linux-nat.c (normal_mask): Delete.
3464         (_initialize_linux_nat): Don't initialise normal_mask.
3465
3466 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3467
3468         PR gdb/24445
3469         * dwarf-index-write.h (write_psymtabs_to_index): Add
3470         dwz_basename parameter.
3471         * dwarf-index-write.c (write_gdbindex): Move file writing to
3472         write_gdbindex_1.  Change return type void.
3473         (assert_file_size): Move up, remove filename parameter.
3474         (write_gdbindex_1): New function.
3475         (write_debug_names): Change return type to void, call
3476         assert_file_size.
3477         (struct index_wip_file): New struct.
3478         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3479         file logic to index_wip_file.  Write index for dwz file if
3480         needed.
3481         (save_gdb_index_command): Pass basename of dwz file, if present.
3482         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3483         build-id of dwz file, if present.
3484         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3485         (dwarf2_get_dwz_file): Likewise.
3486         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3487         (dwarf2_get_dwz_file): Likewise.
3488
3489 2019-06-16  Tom Tromey  <tom@tromey.com>
3490
3491         * coffread.c (process_coff_symbol): Use xstrdup.
3492         * value.c (create_internalvar): Use xstrdup.
3493
3494 2019-06-16  Tom Tromey  <tom@tromey.com>
3495
3496         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3497         * breakpoint.c (stopin_command, stopat_command)
3498         (until_break_command, decode_location_default): Remove unnecessary
3499         cast.
3500         * utils.c (subset_compare): Remove unnecessary cast.
3501         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3502         cast.
3503         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3504         cast.
3505         * infcmd.c (path_command): Remove unnecessary cast.
3506         * coffread.c (decode_type): Remove unnecessary cast.
3507         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3508         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3509         * tui/tui-stack.c (tui_show_locator_content)
3510         (tui_show_frame_info): Remove unnecessary cast.
3511         * tui/tui-win.c (tui_scroll_forward_command)
3512         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3513         (parse_scrolling_args): Remove unnecessary cast.
3514         * tui/tui-data.c (init_win_info, tui_del_window)
3515         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3516         (free_content_elements): Remove unnecessary cast.
3517         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3518         unnecessary cast.
3519         * tui/tui-source.c (tui_set_source_content)
3520         (tui_vertical_source_scroll): Remove unnecessary cast.
3521         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3522         cast.
3523         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3524         * tui/tui-regs.c (tui_display_registers_from)
3525         (tui_display_register): Remove unnecessary cast.
3526         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3527         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3528         (make_visible): Remove unnecessary cast.
3529         * tui/tui-winsource.c (tui_erase_source_content)
3530         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3531         unnecessary cast.
3532         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3533         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3534         * stabsread.c (read_type, read_array_type, read_range_type):
3535         Remove unnecessary cast.
3536         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3537         (parse_symbol, parse_type, upgrade_type, parse_external)
3538         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3539         unnecessary cast.
3540         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3541
3542 2019-06-16  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-data.c (tui_alloc_generic_win_info)
3545         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3546         checks.
3547
3548 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3549             Andrew Burgess  <andrew.burgess@embecosm.com>
3550
3551         * f-typeprint.c (f_print_type): Don't return early for not
3552         associated or not allocated types.
3553         (f_type_print_varspec_suffix): Add print_rank parameter and print
3554         ranks of array types in case they dangling.
3555         (f_type_print_base): Add print_rank parameter.
3556
3557 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * NEWS: Mention new MI commands.
3560         * break-catch-throw.c (enum exception_event_kind): Move to
3561         breakpoint.h.
3562         (print_mention_exception_catchpoint): Output text as a single
3563         message.
3564         (catch_exception_command_1): Rename to...
3565         (catch_exception_event): ...this, make non-static, update header
3566         command, and change some parameter types.
3567         (catch_catch_command): Update for changes to
3568         catch_exception_command_1.
3569         (catch_throw_command): Likewise.
3570         (catch_rethrow_command): Likewise.
3571         * breakpoint.c (enum exception_event_kind): Delete.
3572         * breakpoint.h (enum exception_event_kind): Moved here from
3573         break-catch-throw.c.
3574         (catch_exception_event): Declare.
3575         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3576         (mi_cmd_catch_throw): New function.
3577         (mi_cmd_catch_rethrow): New function.
3578         (mi_cmd_catch_catch): New function.
3579         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3580         'catch-catch' entries.
3581         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3582         (mi_cmd_catch_rethrow): Declare.
3583         (mi_cmd_catch_catch): Declare.
3584
3585 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3586
3587         * annotate.c (annotate_source_line): Change return type to void,
3588         update implementation to match.
3589         * annotate.h (annotate_source_line): Change return type to void,
3590         update header comment.
3591         * stack.c (print_frame_info): Don't change what frame information
3592         is printed based on whether annotations are on or not.
3593
3594 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3597         (annotate_source): Make static.
3598         (annotate_source_line): Moved from source.c and renamed from
3599         identify_source_line.  Update the return type.
3600         * annotate.h (annotate_source): Delete declaration.
3601         (annotate_source_line): Declaration moved from source.h, and
3602         renamed from identify_source_line.  Return type updated.
3603         * source.c (identify_source_line): Moved to annotate.c and renamed
3604         to annotate_source_line.
3605         (info_line_command): Remove check of annotation_level.
3606         * source.h (identify_source_line): Move declaration to annotate.h
3607         and rename to annotate_source_line.
3608         * stack.c: Add 'annotate.h' include.
3609         (print_frame_info): Remove check of annotation_level before
3610         calling annotate_source_line.
3611
3612 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * source-cache.c (source_cache::get_plain_source_lines): Use
3615         open_source_file_with_line_charpos instead of just
3616         open_source_file, remove call to find_source_lines.
3617         (source_cache::get_source_lines): Likewise.
3618         * source.c (find_source_lines): Make static.
3619         (get_filename_and_charpos): Renamed into...
3620         (open_source_file_with_line_charpos): ..this along with changes to
3621         return a scoped_fd, and some other minor clean ups.
3622         (identify_source_line): Use open_source_file_with_line_charpos.
3623         (search_command_helper): Use open_source_file_with_line_charpos
3624         instead of just open_source_file, remove call to
3625         find_source_lines.
3626         * source.h (open_source_file_with_line_charpos): Declare new
3627         function.
3628         (find_source_lines): Delete declaration.
3629
3630 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * source.c (get_filename_and_charpos): Remove fullname
3633         parameter.
3634         (identify_source_line): Update call to get_filename_and_charpos.
3635
3636 2019-06-14  Tom Tromey  <tromey@adacore.com>
3637
3638         PR gdb/24502:
3639         * ui-style.h (skip_ansi_escape): Update comment.
3640         * ui-file.h (class no_terminal_escape_file): New class.
3641         * ui-file.c (no_terminal_escape_file::write)
3642         (no_terminal_escape_file::puts): New methods.
3643         * cli/cli-logging.c (handle_redirections): Use
3644         no_terminal_escape_file.
3645
3646 2019-06-14  Tom Tromey  <tromey@adacore.com>
3647
3648         * NEWS: Move convenience variable news above Python news.
3649
3650 2019-06-14  Tom Tromey  <tom@tromey.com>
3651
3652         * gnulib: Move directory to top-level.
3653         * configure.ac: Don't configure gnulib.
3654         * configure: Rebuild.
3655         * common/common-defs.h: Use new path to gnulib.
3656         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3657         (GNULIB_H): Remove.
3658         (INCGNU): Look in new gnulib location.
3659         (HFILES_NO_SRCDIR): Remove gnulib files.
3660         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3661         (generated_files): Remove GNULIB_H.
3662         ($(LIBGNU), all-lib): Remove targets.
3663         (distclean): Don't mention GNULIB_BUILDDIR.
3664         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3665
3666 2019-06-14  Tom Tromey  <tromey@adacore.com>
3667
3668         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3669         Warn if symbol file does not provide any symbols.
3670
3671 2019-06-14  Tom Tromey  <tromey@adacore.com>
3672
3673         * source.c (find_and_open_source): Respect basenames_may_differ.
3674
3675 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3676
3677         * annotate.c (annotate_breakpoints_invalid): Make use of
3678         scoped_restore_terminal_state.
3679         (annotate_frames_invalid): Likewise.
3680
3681 2019-06-14  Tom Tromey  <tromey@adacore.com>
3682
3683         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3684         allow assignment to an internalvar.
3685
3686 2019-06-14  Tom Tromey  <tromey@adacore.com>
3687
3688         * ada-lex.l: Allow "_" in attribute names.
3689
3690 2019-06-14  Tom Tromey  <tromey@adacore.com>
3691
3692         PR gdb/24653:
3693         * regcache.c (registers_changed): Don't call alloca.
3694         * top.c (execute_command): Don't call alloca.
3695
3696 2019-06-13  Pedro Alves  <palves@redhat.com>
3697
3698         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3699         'expression'.  When parsing an expression, error out if there's
3700         junk after "unlimited".
3701         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3702         (do_set_command): Adjust calls to is_unlimited_literal.
3703
3704 2019-06-13  Pedro Alves  <palves@redhat.com>
3705
3706         * compile/compile.c (make_compile_options_def_group): Add braces
3707         around array_view initializer.
3708         * thread.c (make_thread_apply_all_options_def_group)
3709         (make_thread_apply_all_options_def_group): Likewise.
3710
3711 2019-06-13  Pedro Alves  <palves@redhat.com>
3712
3713         * NEWS (New commands): Mention "maint test-options
3714         require-delimiter", "maint test-options unknown-is-error", "maint
3715         test-options unknown-is-operand" and "maint show
3716         test-options-completion-result".
3717         (New command options, command completion): New section.
3718         (Completion improvements): New section.
3719         Mention that you can abbreviate "unlimited".
3720
3721 2019-06-13  Pedro Alves  <palves@redhat.com>
3722
3723         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3724         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3725         * unittests/cli-utils-selftests.c (test_parse_flags)
3726         (test_parse_flags_qcs): Delete.
3727         (test_cli_utils): Don't call deleted functions.
3728
3729 2019-06-13  Pedro Alves  <palves@redhat.com>
3730
3731         * thread.c: Include "cli/cli-option.h".
3732         (tp_array_compar_ascending): Global.
3733         (tp_array_compar): Delete function.
3734         (tp_array_compar_ascending, tp_array_compar_descending): New
3735         functions.
3736         (ascending_option_def, qcs_flag_option_def)
3737         (thr_qcs_flags_option_defs)
3738         (make_thread_apply_all_options_def_group)
3739         (make_thread_apply_options_def_group): New.
3740         (thread_apply_all_command): Use gdb::option::process_options.
3741         (thread_apply_command_completer)
3742         (thread_apply_all_command_completer): New.
3743         (thread_apply_command): Use gdb::option::process_options.
3744         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3745         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3746         to generate help text of "thread apply".  Adjust "taas"'s help.
3747         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3748         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3749
3750 2019-06-13  Pedro Alves  <palves@redhat.com>
3751
3752         * thread.c (thread_apply_command): Check for invalid TID with
3753         isdigit instead of !isalpha.
3754
3755 2019-06-13  Pedro Alves  <palves@redhat.com>
3756
3757         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3758         (validate_flags_qcs): New.
3759         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3760         (validate_flags_qcs): Declare.
3761         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3762         (make_frame_apply_options_def_group): New.
3763         (frame_apply_command_count): Process options with
3764         gdb::option::process_options.
3765         (frame_apply_completer): New.
3766         (frame_apply_level_completer, frame_apply_all_completer)
3767         (frame_apply_completer): New.
3768         (_initialize_stack): Update help of "frame apply", "frame apply
3769         level", "frame apply all" and "faas" to mention supported options
3770         and install command completers.
3771         * stack.h (frame_apply_all_completer): Declare.
3772         * thread.c: Include "stack.h".
3773         (tfaas_command): Add "--".
3774         (_initialize_thread): Update help "tfaas" to mention supported
3775         options and install command completer.
3776
3777 2019-06-13  Pedro Alves  <palves@redhat.com>
3778
3779         * completer.c (complete_nested_command_line): New.
3780         (gdb_completion_word_break_characters_throw): Add assertion.
3781         * completer.h (complete_nested_command_line): Declare.
3782
3783 2019-06-13  Pedro Alves  <palves@redhat.com>
3784
3785         * stack.c (parse_backtrace_qualifiers): New.
3786         (backtrace_command): Use it.
3787         (backtrace_command_completer): Complete on qualifiers.
3788
3789 2019-06-13  Pedro Alves  <palves@redhat.com>
3790
3791         * frame.c: Include "cli/cli-option.h.
3792         (user_set_backtrace_options): New.
3793         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3794         Delete.
3795         (get_prev_frame): Adjust.
3796         (boolean_option_def, uinteger_option_def)
3797         (set_backtrace_option_defs): New.
3798         (_initialize_frame): Adjust and use
3799         gdb::option::add_setshow_cmds_for_options to install "set
3800         backtrace past-main" and "set backtrace past-entry".
3801         * frame.h: Include "cli/cli-option.h".
3802         (struct frame_print_options): Forward declare.
3803         (print_frame_arguments_all, print_frame_arguments_scalars)
3804         (print_frame_arguments_none): Declare.
3805         (print_entry_values): Delete declaration.
3806         (struct frame_print_options, user_frame_print_options): New.
3807         (struct set_backtrace_options): New.
3808         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3809         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3810         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3811         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3812         (list_args_or_locals): Add frame_print_options parameter.
3813         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3814         * python/py-framefilter.c (enumerate_args): Pass down
3815         USER_FRAME_PRINT_OPTIONS.
3816         * stack.c: Include "cli/cli-option.h".
3817         (print_frame_arguments_all, print_frame_arguments_scalars)
3818         (print_frame_arguments_none): Declare.
3819         (print_raw_frame_arguments, print_entry_values): Delete.
3820         (user_frame_print_options): New.
3821         (boolean_option_def, enum_option_def, frame_print_option_defs):
3822         New.
3823         (struct backtrace_cmd_options): New.
3824         (bt_flag_option_def): New.
3825         (backtrace_command_option_defs): New.
3826         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3827         (print_frame_arg, read_frame_arg, print_frame_args)
3828         (print_frame_info, print_frame): Add frame_print_options parameter
3829         and use it.
3830         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3831         (backtrace_command_1): Add frame_print_options and
3832         backtrace_cmd_options parameters and use them.
3833         (make_backtrace_options_def_group): New.
3834         (backtrace_command): Process command options with
3835         gdb::option::process_options.
3836         (backtrace_command_completer): New.
3837         (_initialize_stack): Extend "backtrace"'s help to mention
3838         supported options.  Install completer for "backtrace".
3839         Install some settings commands with add_setshow_cmds_for_options.
3840
3841 2019-06-13  Pedro Alves  <palves@redhat.com>
3842
3843         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3844         and that "set/show print raw frame-arguments" are now deprecated.
3845
3846         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3847         command.
3848         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3849         * stack.c (_initialize_stack): Install "set/show print
3850         raw-frame-arguments", and deprecate "set/show print raw
3851         frame-arguments".
3852         * valprint.c (_initialize_valprint): Deprecate "set/show print
3853         raw".
3854
3855 2019-06-13  Pedro Alves  <palves@redhat.com>
3856
3857         * compile/compile.c (struct compile_options): New.
3858         (compile_flag_option_def, compile_command_option_defs)
3859         (make_compile_options_def_group): New.
3860         (compile_file_command): Handle options with
3861         gdb::option::process_options.
3862         (compile_file_command_completer): New function.
3863         (compile_code_command): Handle options with
3864         gdb::option::process_options.
3865         (compile_code_command_completer): New function.
3866         (_initialize_compiler): Install completers for "compile code" and
3867         "compile file".  Mention available options in "compile code" and
3868         "compile code"'s help.
3869         * completer.c (advance_to_completion_word): New, factored out from
3870         ...
3871         (advance_to_expression_complete_word_point): ... this.
3872         (advance_to_filename_complete_word_point): New.
3873         * completer.h (advance_to_filename_complete_word_point): New
3874         declaration.
3875
3876 2019-06-13  Pedro Alves  <palves@redhat.com>
3877
3878         * compile/compile.c: Include "cli/cli-option.h".
3879         (compile_print_value): Scope data pointer is now a
3880         value_print_options pointer; adjust.
3881         (compile_print_command): Process options.  Scope data pointer is
3882         now a value_print_options pointer; adjust.
3883         (_initialize_compile): Update "compile print"'s help to include
3884         supported options.  Install a completer for "compile print".
3885         * cp-valprint.c (show_vtblprint, show_objectprint)
3886         (show_static_field_print): Delete.
3887         (_initialize_cp_valprint): Don't install "set print
3888         static-members", "set print vtbl", "set print object" here.
3889         * printcmd.c: Include "cli/cli-option.h" and
3890         "common/gdb_optional.h".
3891         (print_command_parse_format): Rework to fill in a
3892         value_print_options instead of a format_data.
3893         (print_value): Change parameter type from format_data pointer to
3894         value_print_options reference.  Adjust.
3895         (print_command_1): Process options.  Adjust to pass down a
3896         value_print_options.
3897         (print_command_completer): New.
3898         (_initialize_printcmd): Install print_command_completer as
3899         handle_brkchars completer for the "print" command.  Update
3900         "print"'s help to include supported options.
3901         * valprint.c: Include "cli/cli-option.h".
3902         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3903         here from cp-valprint.c.
3904         (boolean_option_def, uinteger_option_def)
3905         (value_print_option_defs, make_value_print_options_def_group):
3906         New.  Use gdb::option::add_setshow_cmds_for_options to install
3907         "set print elements", "set print null-stop", "set print repeats",
3908         "set print pretty", "set print union", "set print array", "set
3909         print address", "set print symbol", "set print array-indexes".
3910         * valprint.h: Include <string> and "cli/cli-option.h".
3911         (make_value_print_options_def_group): Declare.
3912         (print_value): Change parameter type from format_data pointer to
3913         value_print_options reference.
3914         (print_command_completer): Declare.
3915
3916 2019-06-13  Pedro Alves  <palves@redhat.com>
3917
3918         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3919         (COMMON_SFILES): Add maint-test-settings.c.
3920         * cli/cli-decode.c (boolean_enums): New global, factored out from
3921         ...
3922         (add_setshow_boolean_cmd): ... here.
3923         * cli/cli-decode.h (boolean_enums): Declare.
3924         * cli/cli-option.c: New file.
3925         * cli/cli-option.h: New file.
3926         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3927         factored out from ...
3928         (parse_cli_boolean_value(const char *)): ... this.
3929         (is_unlimited_literal): Change parameter type to pointer to
3930         pointer.  Adjust and advance ARG pointer.
3931         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3932         (parse_cli_var_enum): New, factored out from ...
3933         (do_set_command): ... this.  Adjust.
3934         * cli/cli-setshow.h (parse_cli_boolean_value)
3935         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3936         (parse_cli_var_enum): Declare.
3937         * cli/cli-utils.c: Include "cli/cli-option.h".
3938         (get_ulongest): New.
3939         * cli/cli-utils.h (get_ulongest): Declare.
3940         (check_for_argument): New overloads.
3941         * maint-test-options.c: New file.
3942
3943 2019-06-13  Pedro Alves  <palves@redhat.com>
3944
3945         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3946         parse a range if "-" is at the end of the string.
3947
3948 2019-06-13  Pedro Alves  <palves@redhat.com>
3949
3950         * cli/cli-setshow.c (parse_auto_binary_operation)
3951         (parse_cli_boolean_value): Don't allow "o".
3952
3953 2019-06-13  Pedro Alves  <palves@redhat.com>
3954
3955         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3956         * NEWS: Mention maint test-settings KIND.
3957         * maint-test-settings.c: New file.
3958
3959 2019-06-13  Pedro Alves  <palves@redhat.com>
3960
3961         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3962         completer.
3963         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3964         "set" completers.
3965
3966 2019-06-13  Pedro Alves  <palves@redhat.com>
3967
3968         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3969         after item.
3970
3971 2019-06-13  Pedro Alves  <palves@redhat.com>
3972
3973         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3974
3975 2019-06-13  Pedro Alves <palves@redhat.com>
3976
3977         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3978         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3979         call.
3980         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3981         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3982         calls.
3983         (check_for_argument): Skip spaces after argument.
3984
3985 2019-06-13  Pedro Alves  <palves@redhat.com>
3986
3987         * thread.c (thread_apply_command): Adjust TID parsing.
3988         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3989         detected before end of string.
3990         (tid_is_in_list): Error out if LIST is invalid.
3991
3992 2019-06-13  Pedro Alves  <palves@redhat.com>
3993
3994         * completer.c (complete_line_internal_1): Rewind completion word
3995         point.
3996         (completion_tracker::advance_custom_word_point_by): Change
3997         parameter type to int.
3998         * completer.h (completion_tracker::advance_custom_word_point_by):
3999         Likewise.
4000
4001 2019-06-13  Pedro Alves  <palves@redhat.com>
4002
4003         * completer.c (advance_to_completion_word): Handle delimiters.
4004
4005 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4006
4007         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4008
4009 2019-06-11  Tom Tromey  <tom@tromey.com>
4010
4011         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4012         (xmalloc_failed): Move to alloc.c.
4013         * alloc.c: New file.
4014         * Makefile.in (COMMON_SFILES): Add alloc.c.
4015
4016 2019-06-11  Tom Tromey  <tom@tromey.com>
4017
4018         * nat/linux-waitpid.c: Don't include server.h.
4019         (linux_debug): Remove.
4020         (my_waitpid): Update.
4021
4022 2019-06-11  Tom Tromey  <tromey@adacore.com>
4023
4024         * infcall.c (_initialize_infcall): Remove trailing newline from
4025         help.
4026         * user-regs.c (_initialize_user_regs): Remove trailing newline
4027         from help.
4028         * typeprint.c (_initialize_typeprint): Remove trailing newline
4029         from help.
4030         * reverse.c (_initialize_reverse): Remove trailing newlines from
4031         help.
4032         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4033         from help.
4034         * language.c (add_set_language_command): Remove trailing newline
4035         from help.
4036         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4037         help.
4038         * disasm.c (_initialize_disasm): Remove trailing newline from
4039         help.
4040         * top.c (init_main): Remove trailing newline from help.
4041         * interps.c (_initialize_interpreter): Remove trailing newline
4042         from help.
4043         * btrace.c (_initialize_btrace): Remove trailing newlines from
4044         help.
4045         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4046         from help.
4047         * python/python.c (_initialize_python): Remove trailing newline
4048         from help.
4049         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4050         help.
4051         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4052         from help.  Reformat some text.
4053         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4054         from help.
4055         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4056         newline from help.
4057
4058 2019-06-11  Tom Tromey  <tromey@adacore.com>
4059
4060         * darwin-nat.c (darwin_decode_exception_message)
4061         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4062
4063 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * valops.c (value_slice): Check for not allocated or not
4066         associated values.
4067
4068 2019-06-10  Tom de Vries  <tdevries@suse.de>
4069
4070         PR gdb/24618
4071         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4072         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4073         invalid.
4074
4075 2019-06-10  Tom de Vries  <tdevries@suse.de>
4076
4077         PR gdb/24611
4078         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4079         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4080
4081 2019-06-10  Tom de Vries  <tdevries@suse.de>
4082
4083         PR symtab/24545
4084         * symtab.c (struct demangled_name_entry): Add language field.
4085         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4086         static minimal symbol".  Set and use language field.
4087
4088 2019-06-10  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-lang.c (_initialize_ada_language): Update help text.
4091
4092 2019-06-10  Tom Tromey  <tromey@adacore.com>
4093
4094         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4095         with a newline.
4096         * guile/guile.c (handle_boot_error): Don't end warning with a
4097         newline.
4098         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4099         warning with a newline.
4100         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4101         newline.
4102         (s12z_frame_cache): Likewise.
4103         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4104         a newline.
4105         * solib-svr4.c (disable_probes_interface): Don't end warning with
4106         a newline.
4107         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4108         newline.
4109         * python/python.c (do_finish_initialization): Don't end warning
4110         with a newline.
4111
4112 2019-06-10  Tom Tromey  <tom@tromey.com>
4113
4114         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4115         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4116         gdbpy_enter.
4117
4118 2019-06-10  Tom Tromey  <tromey@adacore.com>
4119
4120         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4121         data.
4122         (elf_new_init): Don't call stabsread_new_init.
4123         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4124         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4125         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4126
4127 2019-06-10  Tom de Vries  <tdevries@suse.de>
4128
4129         PR symtab/16264
4130         PR symtab/24517
4131         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4132
4133 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4134
4135         * source.c (find_and_open_source): Also rewrite relative file
4136         names.
4137
4138 2019-04-26  Amos Bird  <amosbird@gmail.com>
4139
4140         * annotate.c (annotate_thread_exited): Add "thread-exited"
4141         annotation.
4142
4143 2019-06-06  Tom Tromey  <tromey@adacore.com>
4144
4145         * maint.h (class scoped_command_stats): Use
4146         DISABLE_COPY_AND_ASSIGN.
4147         <print_time>: New method.
4148         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4149         print_time.
4150         (scoped_command_stats::print_time): New method.
4151
4152 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4155         instructions of lengths 6 or 8 bytes.
4156
4157 2019-06-04  Pedro Alves  <palves@redhat.com>
4158
4159         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4160
4161         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4162         * breakpoint.c (condition_completer): Likewise.
4163         * cli/cli-dump.c (scan_expression): Likewise.
4164         * common/filestuff.c (mkdir_recursive): Likewise.
4165         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4166         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4167         (gdb_abspath): Likewise.
4168         * compile/compile-cplus-types.c
4169         (compile_cplus_instance::decl_name): Likewise.
4170         * completer.c (complete_explicit_location):
4171         (signal_completer, reg_or_group_completer_1): Likewise.
4172         * cp-support.c (cp_remove_params_if_any): Likewise.
4173         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4174         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4175         * infcmd.c (strip_bg_char): Likewise.
4176         * linespec.c (copy_token_string): Likewise.
4177         * mi/mi-main.c (output_cores): Likewise.
4178         * psymtab.c (psymtab_search_name):
4179         * symfile.c (test_set_ext_lang_command): Likewise.
4180         * target.c (target_fileio_read_stralloc): Likewise.
4181         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4182         * value.c (complete_internalvar): Likewise.
4183
4184 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4185
4186         Add objfile property to gdb.Type.
4187         * NEWS: Mention Python API addition.
4188         * python/py-type.c (typy_get_objfile): New method.
4189
4190 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4191
4192         * NEWS: Mention the new set|show style [title|highlight].
4193         Mention changes to "show style", "help" and "apropos".
4194
4195 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4196
4197         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4198         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4199         instead of print_help_for_command.
4200         (print_doc_of_command): New function.
4201         (help_list): Add 'apropos -v word' suggestion.
4202         (print_help_for_command): Style the command name using title style.
4203         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4204         (_initialize_cli_cmds): Describe -v in apropos_command help.
4205
4206 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4207
4208         * cli/cli-style.h (cli_style_option): Add name in constructor,
4209         add m_name class member, add constructor with intensity,
4210         add name class function.
4211         (cli_style_option::add_setshow_commands): Remove name argument.
4212         (highlight_style, title_style): New styles.
4213         * cli/cli-style.c (do_show): New function that shows a style
4214         characteristic styling the style name with itself.
4215         (set_style_name): New function.
4216         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4217         Update all callers according to the changes in cli/cli-style.h.
4218         * utils.h (fputs_highlighted): New function.
4219         * utils.c (fputs_highlighted): Likewise.
4220
4221 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4222
4223         * NEWS: Mention new pipe command and new convenience variables.
4224
4225 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4226
4227         * cli/cli-cmds.c (pipe_command): New function.
4228         (_initialize_cli_cmds): Call add_com for pipe_command.
4229         Define | as an alias for pipe.
4230         (exit_status_set_internal_vars): New function.
4231         (shell_escape): Call exit_status_set_internal_vars.
4232         cli/cli-decode.c (find_command_name_length): Recognize | as
4233         a single character command.
4234
4235 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4236
4237         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4238         top.c (execute_command_to_ui_file): New function, mostly a copy
4239         of execute_command_to_string.
4240         (execute_command_to_string): Implement by calling
4241         execute_command_to_ui_file.
4242
4243 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4244
4245         * top.h (saved_command_line): Remove declaration.
4246         * top.c (previous_saved_command_line, previous_repeat_arguments):
4247         New variables.
4248         (saved_command_line): Make static, define together with other
4249         'repeat variables'.
4250         (dont_repeat): Clear repeat_arguments.
4251         (repeat_previous, get_saved_command_line, save_command_line):
4252         New functions.
4253         (gdb_init): Initialize saved_command_line
4254         and previous_saved_command_line.
4255         * main.c (captured_main_1): Remove saved_command_line initialization.
4256         * event-top.c (handle_line_of_input): Update to use
4257         the new 'repeat' related functions instead of direct access to
4258         saved_command_line.
4259         * command.h (repeat_previous, get_saved_command_line,
4260         save_command_line): New declarations.
4261         (dont_repeat): Add comment.
4262
4263 2019-05-30  Tom Tromey  <tromey@adacore.com>
4264
4265         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4266         Fix comment.
4267         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4268
4269 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4270
4271         PR cli/24587
4272         * completer.c (complete): Initialize variable word.
4273
4274 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4275
4276         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4277         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4278         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4279         'body' is NULL to the outter 'if', protecting the '!is_define'
4280         situation as well.
4281
4282 2019-05-29  Tom Tromey  <tromey@adacore.com>
4283
4284         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4285         (dwarf_unknown): New function.
4286         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4287         (dwarf_type_encoding_name): Use dwarf_unknown.
4288
4289 2019-05-29  Tom Tromey  <tromey@adacore.com>
4290
4291         PR c++/20020:
4292         * cp-valprint.c (cp_print_value_fields): Call
4293         cp_print_static_field inside "try".
4294
4295 2019-05-29  Tom Tromey  <tromey@adacore.com>
4296
4297         * inflow.c (struct terminal_info): Add default operator=.
4298         * configure: Rebuild.
4299         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4300         -Wdeprecated-copy-dtor, -Wredundant-move.
4301
4302 2019-05-29  Tom Tromey  <tromey@adacore.com>
4303
4304         * NEWS: Add entry.
4305         * infcmd.c (print_return_value_1): Handle finish_print
4306         option.
4307         (show_print_finish): New function.
4308         (_initialize_infcmd): Add "set/show print finish" commands.
4309         * valprint.c (user_print_options): Initialize new member.
4310         * valprint.h (struct value_print_options) <finish_print>: New
4311         member.
4312
4313 2019-05-28  Tom Tromey  <tromey@adacore.com>
4314
4315         * ada-lang.c (ada_remove_Xbn_suffix)
4316         (find_old_style_renaming_symbol)
4317         (parse_old_style_renaming): Remove.
4318         (ada_find_renaming_symbol): Don't call
4319         find_old_style_renaming_symbol.
4320         (ada_is_renaming_symbol): Rename from
4321         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4322         bool.  Now static.
4323         (ada_read_var_value): Update and simplify.
4324         * ada-exp.y (write_var_or_type): Remove old code.
4325
4326 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4327
4328         * event-top.c: Remove include comment.
4329         * inflow.c (class scoped_ignore_sigttou): Move from here...
4330         * inflow.h (class scoped_ignore_sigttou): ...to here.
4331         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4332         * top.c:  Remove include comment.
4333
4334 2019-05-27  Tom Tromey  <tom@tromey.com>
4335
4336         * NEWS: Fix typo.
4337
4338 2019-05-22  Tom Tromey  <tromey@adacore.com>
4339
4340         * target.c (target_follow_exec): Constify parameter.
4341         * target-delegates.c: Rebuild.
4342         * remote.c (remote_target::follow_exec): Constify parameter.
4343         * infrun.c (follow_exec): Constify parameter.
4344         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4345         (target_follow_exec): Likewise.
4346
4347 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4348
4349         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4350         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4351
4352 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4353
4354         * NEWS: Add debugredirect and testsuite sections.
4355
4356 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4357
4358         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4359         target descriptions using exclusively floating point register name
4360         aliases.
4361
4362 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         PR gdb/18644:
4365         * f-lang.c (build_fortran_types): Handle the case where
4366         gdbarch_floatformat_for_type returns a nullptr.
4367
4368 2019-05-21  Tom de Vries  <tdevries@suse.de>
4369
4370         PR cli/24587
4371         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4372
4373 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         PR gdb/18644:
4376         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4377         16-byte floats.
4378         * i386-tdep.c (i386_floatformat_for_type): Use
4379         floatformats_ia64_quad for the 16-byte floating point component
4380         within a fortran 32-byte complex number.
4381
4382 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4383
4384         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4385         delete default constructor.
4386         (find_partial_die): Update to return const struct.
4387         (partial_die_parent_scope): Move variable declaration into scope
4388         of its use and change its type to auto.
4389         (guess_partial_die_structure_name): Likewise.
4390         (partial_die_info::fixup): Likewise.
4391
4392 2019-05-17  Tom Tromey  <tromey@adacore.com>
4393
4394         * source.c (find_and_open_source): Remove cast.
4395
4396 2019-05-17  Tom Tromey  <tromey@adacore.com>
4397
4398         * annotate.c (annotate_source): Make "filename" const.
4399         * annotate.h (annotate_source): Use const.
4400
4401 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4402
4403         * disasm.c (set_disassembler_options): Send errors to stderr.
4404
4405 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4406
4407         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4408         (cli_interp_base::set_logging): Check debug_redirect.
4409         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4410         * cli/cli-logging.c (debug_redirect): Add static variable.
4411         (pop_output_files): Add default param.
4412         (handle_redirections): Print debug setting.
4413         (show_logging_command): Likewise.
4414         (_initialize_cli_logging): Add debugredirect command.
4415         * interps.c (current_interp_set_logging): Add debug_redirect
4416         parameter.
4417         * interps.h (set_logging): Add debug_redirect parameter.
4418         (current_interp_set_logging): Likewise.
4419         * mi/mi-common.h: Likewise.
4420         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4421
4422 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4423             Tom Tromey  <tromey@adacore.com>
4424
4425         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4426         directly.
4427         * cli/cli-interp.h (make_logging_output): Remove declaration.
4428         * cli/cli-logging.c (make_logging_output): Remove function.
4429         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4430         directly.
4431         * ui-file.c (tee_file::tee_file): Remove bools.
4432         (tee_file::~tee_file): Remove deletes.
4433         * ui-file.h (tee_file): Remove bools.
4434
4435 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4436
4437         * mi/mi-cmds.h (mi_cmd_complete): New function.
4438         * mi/mi-main.c (mi_cmd_complete): Likewise.
4439         * mi/mi-cmds.c: Define new MI command -complete.
4440         * NEWS: Mention new -complete command.
4441
4442 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4443
4444         * completer.h (complete): New function.
4445         * completer.c (complete): Likewise.
4446         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4447         function defined in completer.h.
4448
4449 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4450
4451         * MAINTAINERS (Write After Approval): Add myself.
4452
4453 2019-05-17  Tom de Vries  <tdevries@suse.de>
4454
4455         PR gdb/24094
4456         * dwarf2read.c (struct cu_partial_die_info): New struct.
4457         (find_partial_die): Return cu_partial_die_info.
4458         (partial_die_parent_scope, guess_partial_die_structure_name)
4459         (partial_die_info::fixup): Handle new return type of find_partial_die.
4460
4461 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4462
4463         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4464         "std::string", simplifying the algorithm.
4465
4466 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4467
4468         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4469         (stap_static_probe_ops::get_probes): Likewise.
4470
4471 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4472
4473         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4474         '-')" and "else if".
4475         (stap_parse_single_operand): Join checks for
4476         "gdbarch_stap_parse_special_token_p" and
4477         "gdbarch_stap_parse_special_token" in the same "if" statement.
4478         Invert check when verifying for operation on register
4479         displacement.
4480
4481 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4482
4483         * stap-probe.c (stap_get_opcode): Update comment.
4484         (stap_get_expected_argument_type): Likewise.
4485         (handle_stap_probe): Likewise.
4486
4487 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4488
4489         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4490         return type to 'bool'.  Adjust comment.  Use 'bool' when
4491         appropriate.
4492         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4493         * stap-probe.c (stap_parse_argument_1): Likewise.
4494         (stap_is_operator): Likewise.
4495         (stap_is_generic_prefix): Likewise.
4496         (stap_is_register_prefix): Likewise.
4497         (stap_is_register_indirection_prefix): Likewise.
4498         (stap_is_integer_prefix): Likewise.
4499         (stap_generic_check_suffix): Likewise.
4500         (stap_check_integer_suffix): Likewise.
4501         (stap_check_register_suffix): Likewise.
4502         (stap_check_register_indirection_suffix): Likewise.
4503         (stap_parse_register_operand): Likewise.
4504         (stap_parse_single_operand): Likewise.
4505         (stap_parse_argument_1): Likewise.
4506         (stap_probe::get_argument_count): Likewise.
4507         (stap_is_operator): Likewise.
4508
4509 2019-05-16  Tom Tromey  <tromey@adacore.com>
4510
4511         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4512         keyword to foreach.
4513
4514 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4515
4516         * linux-thread-db.c (try_thread_db_load_1): Change return type
4517         to bool.
4518         (try_thread_db_load): Likewise.
4519         (try_thread_db_load_from_pdir_1): Likewise.
4520         (try_thread_db_load_from_pdir): Likewise.
4521         (try_thread_db_load_from_sdir): Likewise.
4522         (try_thread_db_load_from_dir): Likewise.
4523         (thread_db_load_search): Likewise.
4524         (has_libpthread): Likewise.
4525         (thread_db_load): Likewise.
4526
4527 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4528
4529         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4530         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4531         NULL, and complain/return if that's the case.
4532
4533 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4534
4535         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4536         (advance, posn, abstract_read_memory): New functions.
4537         [struct mem_read_abstraction]: New struct.
4538         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4539
4540 2019-05-14  Tom Tromey  <tromey@adacore.com>
4541
4542         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4543         value is not lval_memory.
4544
4545 2019-05-14  Tom Tromey  <tromey@adacore.com>
4546
4547         * solib.c (info_sharedlibrary_command): Style the file name.
4548
4549 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4550
4551         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4552         (aarch64_vnv_type): Likewise.
4553         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4554         * common/tdesc.c: Likewise.
4555         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4556         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4557         * features/aarch64-fpu.xml: Add ieee half view.
4558         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4559         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4560         * gdbtypes.h (struct builtin_type): Likewise.
4561         (struct objfile_type): Likewise.
4562
4563 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4564
4565         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4566         typo.
4567         * location.h (string_to_event_location): Likewise.
4568
4569 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4570
4571         GDB 8.3 released.
4572
4573 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4574
4575         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4576         New variable declaration.
4577         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4578         New variable.
4579         (print_one_breakpoint): Use ui_out::test_flags and new global
4580         variable to compute use_fixed_output.
4581         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4582         Remove.
4583         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4584         (mi_multi_location_breakpoint_output_fixed): Remove.
4585         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4586         new variable.
4587         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4588         fix_multi_location_breakpoint_output flag if version >= 3.
4589         * ui-out.h (enum ui_out_flag)
4590         <fix_multi_location_breakpoint_output>: New enumerator.
4591
4592 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4593
4594         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4595
4596 2019-05-10  Tom Tromey  <tromey@adacore.com>
4597
4598         * ada-lang.c (catch_ada_completer): New function.
4599         (_initialize_ada_language): Use it.
4600
4601 2019-05-10  Tom Tromey  <tromey@adacore.com>
4602
4603         * thread.c (print_thread_info): Make "requested_threads" const.
4604         * gdbthread.h (print_thread_info): Make "requested_threads"
4605         const.
4606         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4607         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4608
4609 2019-05-08  Tom Tromey  <tom@tromey.com>
4610
4611         * gdbtypes.c (objfile_type_data): Change type.
4612         (objfile_type, _initialize_gdbtypes): Update.
4613
4614 2019-05-08  Tom Tromey  <tom@tromey.com>
4615
4616         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4617         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4618         (_initialize_dwarf2_frame): Update.
4619
4620 2019-05-08  Tom Tromey  <tom@tromey.com>
4621
4622         * objc-lang.c (objc_objfile_data): Change type.
4623         (find_methods): Update.
4624         (_initialize_objc_lang): Remove.
4625
4626 2019-05-08  Tom Tromey  <tom@tromey.com>
4627
4628         * stabsread.c (rs6000_builtin_type_data): Change type.
4629         (rs6000_builtin_type, _initialize_stabsread): Update.
4630
4631 2019-05-08  Tom Tromey  <tom@tromey.com>
4632
4633         * mips-tdep.c (mips_pdr_data): Remove.
4634         (_initialize_mips_tdep): Update.
4635
4636 2019-05-08  Tom Tromey  <tom@tromey.com>
4637
4638         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4639         (hppa_init_objfile_priv_data, read_unwind_info)
4640         (find_unwind_entry, _initialize_hppa_tdep): Update.
4641
4642 2019-05-08  Tom Tromey  <tom@tromey.com>
4643
4644         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4645         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4646         on obstack.
4647         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4648
4649 2019-05-08  Tom Tromey  <tom@tromey.com>
4650
4651         * mdebugread.c (basic_type_data): Change type.
4652         (basic_type, _initialize_mdebugread): Update.
4653
4654 2019-05-08  Tom Tromey  <tom@tromey.com>
4655
4656         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4657
4658 2019-05-08  Tom Tromey  <tom@tromey.com>
4659
4660         * nto-tdep.c (nto_inferior_data_reg): Change type.
4661         (nto_inferior_data): Update.
4662         (nto_inferior_data_cleanup, nto_new_inferior_data)
4663         (_initialize_nto_tdep): Remove.
4664         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4665
4666 2019-05-08  Tom Tromey  <tom@tromey.com>
4667
4668         * ada-lang.c (struct ada_inferior_data): Add initializers.
4669         (ada_inferior_data): Change type.
4670         (ada_inferior_data_cleanup): Remove.
4671         (get_ada_inferior_data, ada_inferior_exit)
4672         (struct ada_pspace_data): Add initializers, destructor.
4673         (ada_pspace_data_handle): Change type.
4674         (get_ada_pspace_data): Update.
4675         (ada_pspace_data_cleanup): Remove.
4676
4677 2019-05-08  Tom Tromey  <tom@tromey.com>
4678
4679         * coffread.c (struct coff_symfile_info): Add initializers.
4680         (coff_objfile_data_key): Move lower.  Change type.
4681         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4682         Update.
4683         (coff_free_info): Remove.
4684
4685 2019-05-08  Tom Tromey  <tom@tromey.com>
4686
4687         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4688         (fbsd_pspace_data_handle): Move lower.  Change type.
4689         (get_fbsd_pspace_data): Update.
4690         (fbsd_pspace_data_cleanup): Remove.
4691         (_initialize_fbsd_tdep): Update.
4692
4693 2019-05-08  Tom Tromey  <tom@tromey.com>
4694
4695         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4696         (get_ada_tasks_pspace_data): Update.
4697         (ada_tasks_pspace_data_cleanup): Remove.
4698         (_initialize_tasks): Update.
4699         (ada_tasks_inferior_data_handle): Change type.
4700         (get_ada_tasks_inferior_data): Update.
4701         (ada_tasks_inferior_data_cleanup): Remove.
4702         (struct ada_tasks_pspace_data): Add initializers.
4703
4704 2019-05-08  Tom Tromey  <tom@tromey.com>
4705
4706         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4707         * symfile-debug.c (debug_sym_get_probes): Change type.
4708         * stap-probe.c (handle_stap_probe):
4709         (stap_static_probe_ops::get_probes): Change type.
4710         * probe.h (class static_probe_ops) <get_probes>: Change type.
4711         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4712         (parse_probes_in_pspace): Update.
4713         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4714         Update.
4715         (any_static_probe_ops::get_probes): Change type.
4716         * elfread.c (elfread_data): New typedef.
4717         (probe_key): Change type.
4718         (elf_get_probes): Likewise.  Update.
4719         (probe_key_free): Remove.
4720         (_initialize_elfread): Update.
4721         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4722         Change type.
4723         (dtrace_process_dof_probe, dtrace_process_dof)
4724         (dtrace_static_probe_ops::get_probe): Change type.
4725
4726 2019-05-08  Tom Tromey  <tom@tromey.com>
4727
4728         * xcoffread.c (struct xcoff_symfile_info): Rename from
4729         coff_symfile_info.  Add initializers.
4730         (xcoff_objfile_data_key): Move lower.  Change type.
4731         (XCOFF_DATA): Rewrite.
4732         (xcoff_free_info): Remove.
4733         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4734         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4735         (xcoff_initial_scan): Update.
4736
4737 2019-05-08  Tom Tromey  <tom@tromey.com>
4738
4739         * solib-svr4.c (struct svr4_info): Add initializers and
4740         destructor.
4741         <probes_table>: Now an htab_up.
4742         (solib_svr4_pspace_data): Change type.
4743         (free_probes_table): Simplify.
4744         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4745         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4746         (probes_table_remove_objfile_probes, register_solib_event_probe)
4747         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4748         (_initialize_svr4_solib): Update.
4749
4750 2019-05-08  Tom Tromey  <tom@tromey.com>
4751
4752         * remote.c (remote_pspace_data): Change type.
4753         (remote_pspace_data_cleanup): Remove.
4754         (get_remote_exec_file, set_pspace_remote_exec_file)
4755         (_initialize_remote): Update.
4756
4757 2019-05-08  Tom Tromey  <tom@tromey.com>
4758
4759         * breakpoint.c (breakpoint_objfile_key): Change type.
4760         (get_breakpoint_objfile_data): Update.
4761         (free_breakpoint_objfile_data): Remove.
4762         (_initialize_breakpoint): Update.
4763
4764 2019-05-08  Tom Tromey  <tom@tromey.com>
4765
4766         * linux-tdep.c (struct linux_info): Add initializers.
4767         (linux_inferior_data): Move.  Change type.
4768         (invalidate_linux_cache_inf): Update.
4769         (linux_inferior_data_cleanup): Remove.
4770         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4771
4772 2019-05-08  Tom Tromey  <tom@tromey.com>
4773
4774         * auxv.c (auxv_inferior_data): Move.  Change type.
4775         (auxv_inferior_data_cleanup): Remove.
4776         (invalidate_auxv_cache_inf): Rewrite.
4777         (get_auxv_inferior_data, _initialize_auxv): Update.
4778
4779 2019-05-08  Tom Tromey  <tom@tromey.com>
4780
4781         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4782         (symfile_debug_objfile_data_key): Change type.
4783         (symfile_debug_installed, debug_qf_has_symbols)
4784         (debug_qf_find_last_source_symtab)
4785         (debug_qf_forget_cached_source_info)
4786         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4787         (debug_qf_print_stats, debug_qf_dump)
4788         (debug_qf_expand_symtabs_for_function)
4789         (debug_qf_expand_all_symtabs)
4790         (debug_qf_expand_symtabs_with_fullname)
4791         (debug_qf_map_matching_symbols)
4792         (debug_qf_expand_symtabs_matching)
4793         (debug_qf_find_pc_sect_compunit_symtab)
4794         (debug_qf_map_symbol_filenames)
4795         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4796         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4797         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4798         (debug_sym_read_linetable, debug_sym_relocate): Update.
4799         (symfile_debug_free_objfile): Remove.
4800         (install_symfile_debug_logging, _initialize_symfile_debug):
4801         Update.
4802
4803 2019-05-08  Tom Tromey  <tom@tromey.com>
4804
4805         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4806         allocate_on_obstack.
4807         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4808         (get_dwarf2_per_objfile): Update.
4809         (set_dwarf2_per_objfile): Remove.
4810         (dwarf2_has_info, dwarf2_get_section_info): Update.
4811         (dwarf2_free_objfile): Remove.
4812         (_initialize_dwarf2_read): Update.
4813
4814 2019-05-08  Tom Tromey  <tom@tromey.com>
4815
4816         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4817         initializers.
4818         <unsupported_script_warning_printed,
4819         script_not_found_warning_printed>: Now bool.
4820         (auto_load_pspace_data): Change type.
4821         (~auto_load_pspace_info): Rename from
4822         auto_load_pspace_data_cleanup.
4823         (get_auto_load_pspace_data, init_loaded_scripts_info)
4824         (clear_section_scripts, maybe_print_unsupported_script_warning)
4825         (maybe_print_script_not_found_warning, _initialize_auto_load):
4826         Update.
4827
4828 2019-05-08  Tom Tromey  <tom@tromey.com>
4829
4830         * objfiles.c (objfile_pspace_info): Add destructor and
4831         initializers.
4832         (objfiles_pspace_data): Change type.
4833         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4834         (get_objfile_pspace_data): Update.
4835         (objfiles_bfd_data): Change type.
4836         (get_objfile_bfd_data): Update.
4837         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4838
4839 2019-05-08  Tom Tromey  <tom@tromey.com>
4840
4841         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4842         Change type.
4843         (get_catch_syscall_inferior_data): Update.
4844         (catch_syscall_inferior_data_cleanup): Remove.
4845         (_initialize_break_catch_syscall): Update.
4846
4847 2019-05-08  Tom Tromey  <tom@tromey.com>
4848
4849         * inflow.c (struct terminal_info): Add destructor and
4850         initializers.
4851         (inflow_inferior_data): Change type.
4852         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4853         (get_inflow_inferior_data, inflow_inferior_exit)
4854         (swap_terminal_info, _initialize_inflow): Update.
4855
4856 2019-05-08  Tom Tromey  <tom@tromey.com>
4857
4858         * target-dcache.c (target_dcache_cleanup): Remove.
4859         (target_dcache_aspace_key): Change type.
4860         (target_dcache_init_p, target_dcache_invalidate)
4861         (target_dcache_get, target_dcache_get_or_init)
4862         (_initialize_target_dcache): Update.
4863         * dcache.h (struct dcache_deleter): New.
4864
4865 2019-05-08  Tom Tromey  <tom@tromey.com>
4866
4867         * symtab.c (struct symbol_cache): Add destructor and
4868         initializers.
4869         (symbol_cache_key): Move.  Change type.
4870         (make_symbol_cache, free_symbol_cache): Remove.
4871         (get_symbol_cache): Update.
4872         (symbol_cache_cleanup): Remove.
4873         (ALL_PSPACES, symbol_cache_flush)
4874         (maintenance_print_symbol_cache)
4875         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4876         Update.
4877
4878 2019-05-08  Tom Tromey  <tom@tromey.com>
4879
4880         * symtab.c (struct main_info): Add destructor and initializers.
4881         (main_progspace_key): Move.  Change type.
4882         (get_main_info): Update.
4883         (main_info_cleanup): Remove.
4884         (_initialize_symtab): Update.
4885
4886 2019-05-08  Tom Tromey  <tom@tromey.com>
4887
4888         * registry.h (DECLARE_REGISTRY): Define the _key class.
4889
4890 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * NEWS: Merge two 'New commands' sections.
4893
4894 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4895
4896         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4897         parameter and use Ada language definition instead.
4898         (ada_val_print_ptr): Remove unused language parameter.
4899         (ada_val_print_num): Remove language parameter and use Ada language
4900         definition instead.
4901         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4902         parameter.
4903         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4904         parameter and use Ada language definition instead.
4905         (ada_val_print_1): Update all ada_val_print_xxx calls.
4906         Remove language parameter.
4907         (ada_val_print): Update ada_val_print_1 call.
4908
4909 2019-05-08  Tom Tromey  <tromey@adacore.com>
4910
4911         * remote.c (remote_hw_watchpoint_limit)
4912         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4913         Now static.
4914
4915 2019-05-08  Tom Tromey  <tromey@adacore.com>
4916
4917         * maint.c (_initialize_maint_cmds): Move initialization code to
4918         remote.c.
4919         (watchdog, show_watchdog): Move to remote.c.
4920         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4921         "watchdog" static.
4922         (_initialize_remote): Move initialization code from maint.c.
4923         * defs.h (watchdog): Don't declare.
4924
4925 2019-05-08  Tom Tromey  <tromey@adacore.com>
4926
4927         * tui/tui-interp.c: Include main.h.
4928         * interps.c: Include main.h.
4929         * main.h (interpreter_p): Declare.
4930         * defs.h (interpreter_p): Don't declare.
4931
4932 2019-05-08  Tom Tromey  <tromey@adacore.com>
4933
4934         * dwarf2loc.c: Include dwarf2read.h.
4935         * defs.h (read_unsigned_leb128): Don't declare.
4936         * dwarf2read.h (read_unsigned_leb128): Declare.
4937
4938 2019-05-08  Tom Tromey  <tromey@adacore.com>
4939
4940         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4941         method.
4942
4943 2019-05-08  Tom Tromey  <tromey@adacore.com>
4944
4945         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4946         when no wrap column is set.
4947
4948 2019-05-08  Tom Tromey  <tromey@adacore.com>
4949
4950         * c-lang.c (c_get_string): Handle non-C-style arrays.
4951
4952 2019-05-08  Tom Tromey  <tromey@adacore.com>
4953
4954         * typeprint.c (print_offset_data::update): Print the bit offset,
4955         not the number of bits remaining.
4956
4957 2019-05-08  Tom Tromey  <tromey@adacore.com>
4958
4959         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4960         padding at end of comment.
4961
4962 2019-05-08  Tom Tromey  <tromey@adacore.com>
4963
4964         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4965         Compare main types.
4966
4967 2019-05-06  Tom Tromey  <tom@tromey.com>
4968
4969         * common/scoped_mmap.c: Include common-defs.h.
4970         * common/scoped_mmap.h: Don't include config.h.
4971
4972 2019-05-04  Tom Tromey  <tom@tromey.com>
4973
4974         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4975         (struct aarch64_call_info): Add initializers.
4976         <si>: Now a std::vector.
4977         (pass_on_stack, aarch64_push_dummy_call): Update.
4978
4979 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4980             Tom Tromey  <tom@tromey.com>
4981
4982         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4983         (ppc_threads): Now a std::vector.  Now static.
4984         (hwdebug_find_thread_points_by_tid)
4985         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4986         Update.
4987
4988 2019-05-04  Tom Tromey  <tom@tromey.com>
4989
4990         * arc-tdep.c (arc_tdesc_init): Return bool.
4991
4992 2019-05-04  Tom Tromey  <tom@tromey.com>
4993
4994         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4995         Use gdb_assert_not_reached.
4996
4997 2019-05-04  Tom Tromey  <tom@tromey.com>
4998
4999         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5000         "false".
5001
5002 2019-05-04  Tom Tromey  <tom@tromey.com>
5003
5004         * arc-tdep.c (arc_tdesc_init): Use bool.
5005
5006 2019-05-04  Tom Tromey  <tom@tromey.com>
5007
5008         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5009
5010 2019-05-04  Tom Tromey  <tom@tromey.com>
5011
5012         * cli/cli-cmds.c (valid_command_p): Return bool.
5013
5014 2019-05-04  Tom Tromey  <tom@tromey.com>
5015
5016         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5017         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5018
5019 2019-05-04  Raul Tambre  <raul@tambre.ee>
5020
5021         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5022         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5023         operator for comparison.
5024
5025 2019-05-04  Tom Tromey  <tom@tromey.com>
5026
5027         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5028         (lookup_partial_symbol, print_partial_symbols)
5029         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5030         (psymbol_compare): Update.
5031         (add_psymbol_to_bcache): Clear the entire psymbol.
5032         (maintenance_check_psymtabs): Update.
5033         * psympriv.h (struct partial_symbol): Don't derive from
5034         general_symbol_info.
5035         <obj_section, unrelocated_address, address,
5036         set_unrelocated_address>: Update.
5037         <ginfo>: New member.
5038         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5039         (debug_names::write_psymbols): Update.
5040
5041 2019-05-04  Tom de Vries  <tdevries@suse.de>
5042
5043         * contrib/cc-with-tweaks.sh: Support -n arg.
5044
5045 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5046
5047         * corelow.c (core_target::detach): Ensure frame cache and
5048         register caches are cleared.
5049         inferior.c (exit_inferior_1): Likewise.
5050
5051 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5052             Tom Tromey  <tom@tromey.com>
5053
5054         * dictionary.c (collate_pending_symbols_by_language): Remove
5055         "struct" from foreach.
5056         * symtab.c (lookup_global_symbol_from_objfile)
5057         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5058         foreach.
5059         * ser-tcp.c (net_open): Remove "struct" from foreach.
5060         * objfiles.c (objfile_relocate, objfile_rebase)
5061         (objfile_has_symbols): Remove "struct" from foreach.
5062         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5063         from foreach.
5064         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5065         foreach.
5066         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5067         "struct" from foreach.
5068         * ada-lang.c (create_excep_cond_exprs)
5069         (ada_exception_catchpoint_cond_string): Remove "struct" from
5070         foreach.
5071
5072 2019-05-03  Tom Tromey  <tromey@adacore.com>
5073
5074         * ada-exp.y (convert_char_literal): Check suffix of each
5075         enumerator.
5076
5077 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5078
5079         PR ada/21406:
5080         * ada-exp.y (yywrap): Don't define.
5081         * ada-lex.l (%option): Add noyywrap
5082         (yywrap): Remove.
5083
5084 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5085
5086         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5087         _WIN32_WINNT to the XP level, unless already defined to a higher
5088         level.
5089
5090         * unittests/parse-connection-spec-selftests.c:
5091         * ser-tcp.c:
5092         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5093         override.
5094
5095         * symfile.c (find_separate_debug_file): Remove colon from the
5096         drive spec of DOS/Windows file names of the target, so that the
5097         file name produced from DEBUGDIR and the target's directory will
5098         be valid on DOS/Windows systems.
5099
5100 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * rust-lang.c (val_print_struct): Handle printing structures
5103         containing strings.
5104
5105 2019-05-02  Tom Tromey  <tromey@adacore.com>
5106
5107         * valarith.c (_initialize_valarith): Remove.
5108
5109 2019-05-01  Tom Tromey  <tromey@adacore.com>
5110
5111         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5112         bitfields.
5113
5114 2019-05-01  Tom Tromey  <tromey@adacore.com>
5115
5116         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5117         for big-endian copies.
5118
5119 2019-04-30  Ali Tamur  <tamur@google.com>
5120         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5121         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5122         (read_3_bytes): New function.
5123
5124 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5125
5126         * windows-nat.c (main_thread_id): Delete.
5127         (handle_output_debug_string): Replace main_thread_id by
5128         current_event.dwThreadId.
5129         (fake_create_process): Likewise.
5130         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5131         Do not set main_thread_id.
5132         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5133         current_event.dwThreadId.
5134         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5135
5136 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5137
5138         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5139         Use current_event.dwThreadId instead of main_thread_id.
5140
5141 2019-04-30  Tom Tromey  <tromey@adacore.com>
5142
5143         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5144         (create_excep_cond_exprs): Iterate over program spaces.
5145         (ada_exception_catchpoint_cond_string): Examine all minimal
5146         symbols for exception types.
5147
5148 2019-04-30  Tom Tromey  <tromey@adacore.com>
5149
5150         PR c++/24470:
5151         * dwarf2read.c (process_structure_scope): Handle case where type
5152         has template parameters but no symbol was created.
5153
5154 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5155             Chris January  <chris.january@arm.com>
5156
5157         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5158         qualifier.
5159         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5160
5161 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5162
5163         * f-typeprint.c (f_print_type): Update rules for printing
5164         whitespace.
5165         (f_type_print_varspec_suffix): Likewise.
5166
5167 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5168             Chris January  <chris.january@arm.com>
5169
5170         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5171         function arguments.
5172
5173 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * f-lang.c (build_fortran_types): Change name of void type to
5176         lower case.
5177         * f-typeprint.c (f_type_print_base): Print the name of the void
5178         type, rather than a fixed string.
5179         * f-valprint.c (f_decorations): Use lower case void string.
5180
5181 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5182             Chris January  <chris.january@arm.com>
5183
5184         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5185         types for Fortran.
5186
5187 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5188             Chris January  <chris.january@arm.com>
5189             David Lecomber  <david.lecomber@arm.com>
5190
5191         * f-exp.y (BINOP_INTRINSIC): New token.
5192         (exp): New parser rule handling BINOP_INTRINSIC.
5193         (f77_keywords): Add new builtin procedures.
5194         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5195         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5196         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5197         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5198         (print_unop_subexp_f): New function.
5199         (print_binop_subexp_f): New function.
5200         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5201         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5202         (dump_subexp_body_f): Likewise.
5203         (operator_check_f): Likewise.
5204         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5205         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5206
5207 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5208
5209         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5210         UNOP_KIND.
5211         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5212         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5213         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5214         (operator_length_f): New fuction.
5215         (print_subexp_f): New function.
5216         (op_name_f): New function.
5217         (dump_subexp_body_f): New function.
5218         (operator_check_f): New function.
5219         (exp_descriptor_f): Replace standard expression handling functions
5220         with new functions.
5221         * gdb/fortran-operator.def: New file.
5222         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5223         * gdb/std-operator.def: Remove UNOP_KIND.
5224
5225 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * std-operator.def: Remove unbalanced, stray double quote
5228         character.
5229
5230 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5231             Chris January  <chris.january@arm.com>
5232             Daniel Everett  <daniel.everett@arm.com>
5233             Nick Forrington  <nick.forrington@arm.com>
5234             Richard Bunt  <richard.bunt@arm.com>
5235
5236         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5237         of depth when printing anonymous structs or unions.
5238         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5239         Don't print either the top-level value, or the children if the
5240         max-depth is exceeded.
5241         (ppscm_print_children): When printing the key of a map, allow one
5242         extra level of depth.
5243         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5244         print either the top-level value, or the children if the max-depth
5245         is exceeded.
5246         (print_children): When printing the key of a map, allow one extra
5247         level of depth.
5248         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5249         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5250         (user_print_options): Initialise max_depth field.
5251         (val_print_scalar_or_string_type_p): New function.
5252         (val_print): Check to see if the max depth has been reached.
5253         (val_print_check_max_depth): Define new function.
5254         (show_print_max_depth): New function.
5255         (_initialize_valprint): Add 'print max-depth' option.
5256         * valprint.h (struct value_print_options) <max_depth>: New field.
5257         (val_print_check_max_depth): Declare new function.
5258         * NEWS: Document new feature.
5259
5260 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * ada-lang.c (ada_language_defn): Initialise new field.
5263         * c-lang.c (c_is_string_type_p): New function.
5264         (c_language_defn): Initialise new field.
5265         (cplus_language_defn): Initialise new field.
5266         (asm_language_defn): Initialise new field.
5267         (minimal_language_defn): Initialise new field.
5268         * c-lang.h (c_is_string_type_p): Declare new function.
5269         * d-lang.c (d_language_defn): Initialise new field.
5270         * f-lang.c (f_is_string_type_p): New function.
5271         (f_language_defn): Initialise new field.
5272         * go-lang.c (go_is_string_type_p): New function.
5273         (go_language_defn): Initialise new field.
5274         * language.c (default_is_string_type_p): New function.
5275         (unknown_language_defn): Initialise new field.
5276         (auto_language_defn): Initialise new field.
5277         * language.h (struct language_defn) <la_is_string_type_p>: New
5278         member variable.
5279         (default_is_string_type_p): Declare new function.
5280         * m2-lang.c (m2_language_defn): Initialise new field.
5281         * objc-lang.c (objc_language_defn): Initialise new field.
5282         * opencl-lang.c (opencl_language_defn): Initialise new field.
5283         * p-lang.c (pascal_is_string_type_p): New function.
5284         (pascal_language_defn): Initialise new field.
5285         * rust-lang.c (rust_is_string_type_p): New function.
5286         (rust_language_defn): Initialise new field.
5287
5288 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5289
5290         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5291         New field.
5292         * ada-lang.c (ada_language_defn): Initialise new field.
5293         * c-lang.c (c_language_defn): Likewise.
5294         (cplus_language_defn): Likewise.
5295         (asm_language_defn): Likewise.
5296         (minimal_language_defn): Likewise.
5297         * d-lang.c (d_language_defn): Likewise.
5298         * f-lang.c (f_language_defn): Likewise.
5299         * go-lang.c (go_language_defn): Likewise.
5300         * language.c (unknown_language_defn): Likewise.
5301         (auto_language_defn): Likewise.
5302         * m2-lang.c (m2_language_defn): Likewise.
5303         * objc-lang.c (objc_language_defn): Likewise.
5304         * opencl-lang.c (opencl_language_defn): Likewise.
5305         * p-lang.c (pascal_language_defn): Likewise.
5306         * rust-lang.c (rust_language_defn): Likewise.
5307
5308 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5309
5310         * ada-lang.c (ada_is_character_type): Change return type to bool.
5311         (ada_is_string_type): Likewise.
5312         * ada-lang.h (ada_is_character_type): Update declaration
5313         (ada_is_string_type): Likewise.
5314
5315 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5316
5317         Support style in 'frame|thread apply'
5318
5319         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5320         * record.c (record_start, record_stop): Update callers of
5321         execute_command_to_string with false.
5322         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5323         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5324         methods.
5325         (class string_file): New constructor with term_out parameter.
5326         Override methods term_out and can_emit_style_escape.  New member
5327         term_out.
5328         (class stdio_file): Override can_emit_style_escape.
5329         (class tee_file): Override term_out and can_emit_style_escape.
5330         * utils.h (can_emit_style_escape): Remove.
5331         * utils.c (can_emit_style_escape): Likewise.
5332         Update all callers of can_emit_style_escape (SOMESTREAM) to
5333         SOMESTREAM->can_emit_style_escape.
5334         * source-cache.c (source_cache::get_source_lines): Likewise.
5335         * stack.c (frame_apply_command_count): Call execute_command_to_string
5336         passing the term_out characteristic of the current gdb_stdout.
5337         * thread.c (thr_try_catch_cmd): Likewise.
5338         * top.c (execute_command_to_string): pass term_out parameter
5339         to construct the string_file for the command output.
5340         * ui-file.c (term_cli_styling): New function (most code moved
5341         from utils.c can_emit_style_escape).
5342         (string_file::string_file, string_file::can_emit_style_escape,
5343         stdio_file::can_emit_style_escape, tee_file::term_out,
5344         tee_file::can_emit_style_escape): New functions.
5345
5346 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5347
5348         * NEWS: Mention the new set|show may-call-functions.
5349         * infcall.c (may_call_functions_p): New variable.
5350         (show_may_call_functions_p): New function.
5351         (call_function_by_hand_dummy): Throws an error if not
5352         may-call-functions.
5353         (_initialize_infcall): Call add_setshow_boolean_cmd for
5354         may-call-functions.
5355
5356 2019-04-25  Keith Seitz  <keiths@redhat.com>
5357
5358         PR c++/24367
5359         * cp-support.c (inspect_type): Don't attempt substitutions
5360         of symbol with the same name.
5361
5362 2019-04-25  Tom Tromey  <tromey@adacore.com>
5363
5364         PR gdb/24475:
5365         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5366         static.
5367
5368 2019-04-25  Tom Tromey  <tromey@adacore.com>
5369
5370         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5371         rvalue reference.
5372         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5373         (gdb_xml_parser::parse): Use std::move.
5374         * python/python-internal.h (gdbpy_convert_exception): Take a const
5375         reference.
5376         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5377         std::move.
5378         * python/py-utils.c (gdbpy_convert_exception): Take a const
5379         reference.
5380         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5381         Use std::move.
5382         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5383         Use std::move.
5384         * mi/mi-main.c (mi_print_exception): Take a const reference.
5385         * main.c (handle_command_errors): Take a const reference.
5386         * linespec.c (parse_linespec): Use std::move.
5387         * infcall.c (run_inferior_call): Use std::move.
5388         (call_function_by_hand_dummy): Use std::move.
5389         * exec.c (try_open_exec_file): Use std::move.
5390         * exceptions.h (exception_print, exception_fprintf)
5391         (exception_print_same): Update.
5392         * exceptions.c (print_exception, exception_print)
5393         (exception_fprintf, exception_print_same): Change parameters to
5394         const reference.
5395         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5396         * common/new-op.c: Use std::move.
5397         * common/common-exceptions.h (struct gdb_exception): Add move
5398         constructor.
5399         (struct gdb_exception_error, struct gdb_exception_quit, struct
5400         gdb_quit_bad_alloc): Change constructor to move constructor.
5401         (throw_exception): Change parameter to rvalue reference.
5402         * common/common-exceptions.c (throw_exception): Take rvalue
5403         reference.
5404         * cli/cli-interp.c (safe_execute_command): Use std::move.
5405         * breakpoint.c (insert_bp_location, location_to_sals): Use
5406         std::move.
5407
5408 2019-04-25  Tom Tromey  <tromey@adacore.com>
5409
5410         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5411         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5412         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5413         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5414         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5415         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5416         guile/scm-value.c: Use unpack.
5417         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5418         gdbscm_gdb_exception.
5419         (gdbscm_throw_gdb_exception): Likewise.
5420         (struct gdbscm_gdb_exception): New.
5421         (unpack): New function.
5422         (gdbscm_wrap): Use unpack.
5423
5424 2019-04-25  Tom Tromey  <tromey@adacore.com>
5425
5426         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5427         (gdb_rl_callback_handler): Use std::move.
5428         * common/common-exceptions.h (struct gdb_exception): Add move
5429         assignment operator.
5430         (throw_exception_sjlj): Change "exception" to const reference.
5431         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5432         (throw_exception_sjlj): Change "exception" to const reference.
5433
5434 2019-04-25  Tom Tromey  <tromey@adacore.com>
5435
5436         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5437         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5438         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5439         Update.
5440         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5441         Update.
5442         * mi/mi-interp.c (mi_interp::exec): Update.
5443         * linespec.c (parse_linespec): Update.
5444         * infcall.c (run_inferior_call): Update.
5445         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5446         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5447         (gdbscm_lookup_global_symbol): Update.
5448         * guile/scm-param.c (gdbscm_parameter_value): Update.
5449         * guile/scm-frame.c (gdbscm_frame_read_register)
5450         (gdbscm_frame_read_var): Update.
5451         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5452         * exec.c (try_open_exec_file): Update.
5453         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5454         (gdb_rl_callback_handler): Update.
5455         * common/common-exceptions.h (exception_none): Don't declare.
5456         * common/common-exceptions.c (exception_none): Don't define.
5457         (struct catcher) <exception>: Update.
5458         * cli/cli-interp.c (safe_execute_command): Update.
5459         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5460
5461 2019-04-25  Ali Tamur  <tamur@google.com>
5462
5463         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5464         (read_attribute_value): Likewise.
5465         (dwarf2_read_addr_index): Update comment.
5466         (read_str_index): Add DW_FORM_strx.
5467         (dwarf2_string_attr): Likewise.
5468         (dwarf2_const_value_attr): Likewise.
5469         (dump_die_shallow): Likewise.
5470         (dwarf2_fetch_constant_bytes): Likewise.
5471         (skip_form_bytes): Likewise.
5472         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5473
5474 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5475
5476         PR corefiles/11608
5477         PR corefiles/18187
5478         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5479         OFFSET.  Verify if current mapping contains an ELF header.
5480         (linux_find_memory_regions_full): Adjust call to
5481         dump_mapping_p.
5482
5483 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5484             Kang Li <kanglictf@gmail.com>
5485
5486         PR gdb/21600
5487
5488         * dwarf2-frame.c (read_initial_length): Be consistent about using
5489         unsigned representation of length.
5490         (decode_frame_entry_1): Likewise.  Check for wraparound of
5491         end pointer as well as buffer overflow.
5492
5493 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5494
5495         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5496         "vq".
5497
5498 2019-04-24  Tom Tromey  <tromey@adacore.com>
5499
5500         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5501
5502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5503
5504         * s12z-tdep.c (s12z_unwind_pc): Delete.
5505         (s12z_unwind_sp): Delete.
5506         (s12z_gdbarch_init): Don't register deleted functions with
5507         gdbarch.
5508
5509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5510
5511         * rl78-tdep.c (rl78_unwind_sp): Delete.
5512         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5513
5514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5515
5516         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5517         (xstormy16_unwind_pc): Delete.
5518         (xstormy16_dummy_id): Delete.
5519         (xstormy16_gdbarch_init): Don't register deleted functions with
5520         gdbarch.
5521
5522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5523
5524         * vax-tdep.c (vax_unwind_pc): Delete.
5525         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5526
5527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5528
5529         * v850-tdep.c (v850_unwind_sp): Delete.
5530         (v850_unwind_pc): Delete.
5531         (v850_dummy_id): Delete.
5532         (v850_gdbarch_init): Don't register deleted functions with
5533         gdbarch.
5534
5535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5538         (tilegx_unwind_pc): Delete.
5539         (tilegx_unwind_dummy_id): Delete.
5540         (tilegx_gdbarch_init): Don't register deleted functions with
5541         gdbarch.
5542
5543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5546         (tic6x_dummy_id): Delete.
5547         (tic6x_gdbarch_init): Don't register deleted functions with
5548         gdbarch.
5549
5550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * sparc-tdep.c (sparc_unwind_pc): Delete.
5553         (sparc32_gdbarch_init): Don't register deleted function with
5554         gdbarch.
5555
5556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * sh-tdep.c (sh_unwind_sp): Delete.
5559         (sh_unwind_pc): Delete.
5560         (sh_dummy_id): Delete.
5561         (sh_gdbarch_init): Don't register deleted functions with
5562         gdbarch.
5563
5564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * score-tdep.c (score_unwind_sp): Delete.
5567         (score_unwind_pc): Delete.
5568         (score_dummy_id): Delete.
5569         (score_gdbarch_init): Don't register deleted functions with
5570         gdbarch.
5571
5572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5573
5574         * rx-tdep.c (rx_unwind_pc): Delete.
5575         (rx_unwind_sp): Delete.
5576         (rx_dummy_id): Delete.
5577         (rx_gdbarch_init): Don't register deleted functions with
5578         gdbarch.  Update comment.
5579
5580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5581
5582         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5583         (rs6000_dummy_id): Delete.
5584         (rs6000_gdbarch_init): Don't register deleted functions with
5585         gdbarch.
5586
5587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5588
5589         * or1k-tdep.c (or1k_dummy_id): Delete.
5590         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5591
5592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * nios2-tdep.c (nios2_dummy_id): Delete.
5595         (nios2_unwind_sp): Delete.
5596         (nios2_gdbarch_init): Don't register deleted functions with
5597         gdbarch.
5598
5599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * nds32-tdep.c (nds32_dummy_id): Delete.
5602         (nds32_unwind_pc): Delete.
5603         (nds32_unwind_sp): Delete.
5604         (nds32_gdbarch_init): Don't register deleted functions with
5605         gdbarch.
5606
5607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5608
5609         * msp430-tdep.c (msp430_unwind_pc): Delete.
5610         (msp430_unwind_sp): Delete.
5611         (msp430_dummy_id): Delete.
5612         (msp430_gdbarch_init): Don't register deleted functions with
5613         gdbarch.
5614
5615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5616
5617         * moxie-tdep.c (moxie_unwind_sp): Delete.
5618         (moxie_unwind_pc): Delete.
5619         (moxie_dummy_id): Delete.
5620         (moxie_gdbarch_init): Don't register deleted functions with
5621         gdbarch.
5622
5623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5624
5625         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5626         (mn10300_unwind_pc): Delete.
5627         (mn10300_unwind_sp): Delete.
5628         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5629         mn10300_unwind_sp.
5630         (mn10300_frame_unwind_init): Don't register deleted functions with
5631         gdbarch.
5632
5633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5634
5635         * mep-tdep.c (mep_unwind_pc): Delete.
5636         (mep_unwind_sp): Delete.
5637         (mep_dummy_id): Delete.
5638         (mep_gdbarch_init): Don't register deleted functions with
5639         gdbarch.
5640
5641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5644         (m68hc11_unwind_sp): Delete.
5645         (m68hc11_gdbarch_init): Don't register deleted functions with
5646         gdbarch.
5647
5648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * m32r-tdep.c (m32r_unwind_sp): Delete.
5651         (m32r_unwind_pc): Delete.
5652         (m32r_dummy_id): Delete.
5653         (m32r_gdbarch_init): Don't register deleted functions with
5654         gdbarch.
5655
5656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * m32c-tdep.c (m32c_unwind_pc): Delete.
5659         (m32c_unwind_sp): Delete.
5660         (m32c_dummy_id): Delete.
5661         (m32c_gdbarch_init): Don't register deleted functions with
5662         gdbarch.
5663
5664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5665
5666         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5667         (lm32_unwind_pc): Delete.
5668         (lm32_dummy_id): Delete.
5669         (lm32_gdbarch_init): Don't register deleted functions with
5670         gdbarch.
5671
5672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5673
5674         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5675         (iq2000_unwind_pc): Delete.
5676         (iq2000_dummy_id): Delete.
5677         (iq2000_gdbarch_init): Don't register deleted functions with
5678         gdbarch.
5679
5680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * nds32-tdep.c (nds32_type_align): Delete.
5683         (nds32_push_dummy_call): Use type_align instead.
5684
5685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5686
5687         * arm-tdep.c (arm_type_align): Only handle vector override case.
5688         (arm_push_dummy_call): Use type_align.
5689         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5690
5691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5692
5693         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5694         case.
5695         (pass_on_stack): Use type_align.
5696         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5697         function.
5698
5699 2019-04-23  Tom Tromey  <tromey@adacore.com>
5700
5701         * dwarf2read.c (line_header::file_name_at): Remove unused
5702         overload.
5703
5704 2019-04-23  Tom de Vries  <tdevries@suse.de>
5705
5706         PR gdb/24438
5707         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5708         invocation.
5709
5710
5711 2019-03-27  Ali Tamur  <tamur@google.com>
5712
5713         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5714         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5715         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5716         (dwarf_expr_context::get_addr_index): Likewise
5717         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5718         (symbol_needs_eval_context::get_addr_index): Likewise
5719         (disassemble_dwarf_expression): Add DW_OP_addrx
5720         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5721         (read_cutu_die_from_dwo): Update comment
5722         (skip_one_die): Add DW_FORM_addrx
5723         (read_attribute_value): Likewise
5724         (var_decode_location): Add DW_OP_addrx
5725         (dwarf2_const_value_attr): Add DW_FORM_addrx
5726         (dump_die_shallow): Likewise
5727         (dwarf2_fetch_constant_bytes): Likewise
5728         (decode_locdesc): Add DW_OP_addrx
5729         (skip_form_bytes): Add DW_FORM_addrx
5730
5731 2019-04-22  Ali Tamur  <tamur@google.com>
5732
5733         * MAINTAINERS (Write After Approval): Add self.
5734
5735 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5736
5737         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5738         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5739         (open_symbol_file_object): Likewise.
5740         (svr4_default_sos): Add info parameter.
5741         (svr4_read_so_list): Likewise.
5742         (svr4_current_sos_direct): Adjust functions calls to pass down
5743         info.
5744         (svr4_current_sos_1): Add info parameter.
5745         (svr4_current_sos): Call get_svr4_info, pass info down to
5746         svr4_current_sos_1.
5747         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5748         get_svr4_info.
5749         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5750         get_svr4_info.
5751         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5752         to get_svr4_info.
5753         (probes_table_remove_objfile_probes): Likewise.
5754         (register_solib_event_probe): Add info parameter.
5755         (solist_update_incremental): Pass info parameter down to
5756         svr4_read_so_list.
5757         (disable_probes_interface): Add info parameter.
5758         (svr4_handle_solib_event): Pass current_program_space to
5759         get_svr4_info.  Adjust disable_probes_interface cleanup.
5760         (svr4_create_probe_breakpoints): Add info parameter, pass it
5761         down to register_solib_event_probe.
5762         (svr4_create_solib_event_breakpoints): Add info parameter,
5763         pass it down to svr4_create_probe_breakpoints.
5764         (enable_break): Pass info down to
5765         svr4_create_solib_event_breakpoints.
5766         (svr4_solib_create_inferior_hook): Pass current_program_space to
5767         get_svr4_info.
5768         (svr4_clear_solib): Likewise.
5769
5770 2019-04-22  Pedro Alves  <palves@redhat.com>
5771
5772         * solib-svr4.c (svr4_free_objfile_observer): New.
5773         (probe_and_action::objfile): New field.
5774         (probes_table_htab_remove_objfile_probes)
5775         (probes_table_remove_objfile_probes): New functions.
5776         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5777         in the new probe_and_action.  Don't store the probe in 'lookup'.
5778         (svr4_create_probe_breakpoints): Pass objfile to
5779         register_solib_event_probe.
5780         (_initialize_svr4_solib): Register a free_objfile observer.
5781
5782 2019-04-19  Tom Tromey  <tom@tromey.com>
5783
5784         * common/queue.h: Remove.
5785
5786 2019-04-19  Tom Tromey  <tom@tromey.com>
5787
5788         * event-loop.c: Don't include "common/queue.h".
5789
5790 2019-04-19  Tom Tromey  <tom@tromey.com>
5791
5792         * remote.c (remote_target): Use delete.
5793         * remote-notif.h: Include <list>, not "common/queue.h".
5794         (notif_client_p): Remove typedef.
5795         (remote_notif_state): Add constructor, destructor, initializer.
5796         <notif_queue>: Now a std::list.
5797         (remote_notif_state_xfree): Don't declare.
5798         * remote-notif.c (remote_notif_process, handle_notification)
5799         (remote_notif_state_allocate): Update.
5800         (~remote_notif_state): Rename from remote_notif_state_xfree.
5801
5802 2019-04-19  Tom Tromey  <tom@tromey.com>
5803
5804         * symfile.c (reread_symbols): Update.
5805         * objfiles.c (objfile_register_static_link)
5806         (objfile_lookup_static_link): Update
5807         (~objfile) Don't delete static_links.
5808         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5809
5810 2019-04-19  Tom Tromey  <tom@tromey.com>
5811
5812         * type-stack.h (struct type_stack) <insert>: Constify string.
5813         * type-stack.c (type_stack::insert): Constify string.
5814         * gdbtypes.h (lookup_template_type): Update.
5815         (address_space_name_to_int): Update.
5816         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5817         const.
5818         (lookup_template_type): Make name const.
5819         * c-exp.y: Update rules.
5820         (lex_one_token, classify_name, classify_inner_name)
5821         (c_print_token): Update.
5822         * p-exp.y: Update rules.
5823         (yylex): Update.
5824         * f-exp.y: Update rules.
5825         (yylex): Update.
5826         * d-exp.y: Update rules.
5827         (lex_one_token, classify_name, classify_inner_name): Update.
5828         * parse.c (write_dollar_variable, copy_name): Return std::string.
5829         * parser-defs.h (copy_name): Change return type.
5830         * m2-exp.y: Update rules.
5831         (yylex): Update.
5832         * go-exp.y (lex_one_token): Update.
5833         Update rules.
5834         (classify_unsafe_function, classify_packaged_name)
5835         (classify_name, yylex): Update.
5836
5837 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5838
5839         * configure.ac: add --enable-source-highlight switch.
5840         * configure: Regenerate.
5841         * top.c (print_gdb_version): plumb --enable-source-highlight
5842         status to "show configuration".
5843
5844 2019-04-19  Tom Tromey  <tromey@adacore.com>
5845
5846         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5847         Check ADA_TYPE_P.
5848         (empty_record, ada_template_to_fixed_record_type_1)
5849         (template_to_static_fixed_type)
5850         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5851         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5852         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5853         macros.
5854
5855 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5856
5857         PR symtab/24423:
5858         * source.c (print_source_lines_base): Advance "iter" when a
5859         control character is seen.
5860
5861 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5862
5863         * inferior.h (struct infcall_suspend_state_deleter):
5864         Catch exception in destructor to avoid crash.
5865
5866 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5867
5868         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5869         close to the add_com "shell".
5870
5871 2019-04-18  Tom Tromey  <tromey@adacore.com>
5872
5873         * process-stratum-target.h (class process_stratum_target)
5874         <stratum>: Add "final".
5875
5876 2019-04-17  Tom Tromey  <tromey@adacore.com>
5877
5878         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5879         against nullptr before use.
5880
5881 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5882
5883         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5884
5885 2019-04-17  Jim Wilson  <jimw@sifive.com>
5886             Andrew Burgess  <andrew.burgess@embecosm.com>
5887
5888         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5889         code read might fail, assume 4-byte breakpoint in that case.
5890
5891 2019-04-15  Leszek Swirski  <leszeks@google.com>
5892
5893         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5894         rather than a hand-rolled POD check when checking for forced MEMORY
5895         classification.
5896
5897 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5898
5899         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5900         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5901         function.
5902         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5903         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5904         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5905         declaration.
5906
5907 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5908
5909         * aarch64-linux-nat.c
5910         (aarch64_linux_nat_target::thread_architecture): Add override.
5911         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5912         each VQ.
5913
5914 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5915
5916         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5917
5918 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5919
5920         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5921         target types of size 96-bits, add some additional comments, and
5922         check that the builtin type we found was the correct size.
5923
5924 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5925
5926         * utils.c (prompt_for_continue): Don't restore the styling at the
5927         end, as applied_style has the wrong value.  This fixes styling in
5928         long lists of file names that are interrupted by the "Continue?"
5929         prompt.
5930
5931 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5934         * c-lang.c (c_language_defn): Likewise.
5935         (cplus_language_defn): Likewise.
5936         (asm_language_defn): Likewise.
5937         (minimal_language_defn): Likewise.
5938         * d-lang.c (d_language_defn): Likewise.
5939         * f-lang.c (f_language_defn): Likewise.
5940         * go-lang.c (go_language_defn): Likewise.
5941         * language.c (unknown_language_defn): Likewise.
5942         (auto_language_defn): Likewise.
5943         * language.h (struct language_defn): Remove la_magic field.
5944         (LANG_MAGIC): Delete.
5945         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5946         * objc-lang.c (objc_language_defn): Likewise.
5947         * opencl-lang.c (opencl_language_defn): Likewise.
5948         * p-lang.c (pascal_language_defn): Likewise.
5949         * rust-lang.c (rust_language_defn): Likewise.
5950
5951 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5952
5953         * riscv-tdep.c (riscv_type_align): New function.
5954         (riscv_type_alignment): Delete.
5955         (riscv_arg_location): Use 'type_align'.
5956         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5957
5958 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * gdbtypes.c (type_align): A struct with no non-static fields also
5961         has alignment of 1.
5962
5963 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5964
5965         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5966         component to 0.
5967         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5968         member.
5969         (riscv_struct_info::analyse): New implementation using new
5970         analyse_inner member function.
5971         (riscv_struct_info::field_offset): New member function.
5972         (riscv_struct_info::m_offsets): New member variable.
5973         (riscv_struct_info::analyse_inner): New private member function,
5974         takes the old implementation of riscv_struct_info::analyse but
5975         extended to track field offsets.
5976         (riscv_call_arg_struct): Update the struct folding special cases
5977         to handle cases where empty C++ structs, which are non-zero
5978         length, are found.
5979         (riscv_arg_location): Initialise the length of each location, a
5980         non-zero length now indicates the location is in use.
5981         (riscv_push_dummy_call): Allow for the first location having a
5982         non-zero offset when setting up arguments.
5983         (riscv_return_value): Likewise, but for return values.
5984
5985 2019-04-11  Tom Tromey  <tromey@adacore.com>
5986
5987         * utils.c (internal_vproblem): Make "msg" const.
5988
5989 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5990
5991         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5992         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5993         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5994         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5995
5996 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5997
5998         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5999         function.
6000         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6001         of amd64_collect_native_gregset.
6002         (amd64_linux_nat_target::store_registers): Likewise.
6003
6004 2019-04-10  Tom Tromey  <tom@tromey.com>
6005
6006         * symtab.c (lookup_global_symbol_from_objfile)
6007         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6008         * objfiles.h (class separate_debug_iterator): New.
6009         (class separate_debug_range): New.
6010         (struct objfile) <separate_debug_objfiles>: New method.
6011         (objfile_separate_debug_iterate): Don't declare.
6012         * objfiles.c (separate_debug_iterator::operator++): Rename from
6013         objfile_separate_debug_iterate.
6014         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6015         iterator.
6016         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6017         iterator.
6018
6019 2019-04-10  Tom Tromey  <tom@tromey.com>
6020
6021         * symfile.c (reread_symbols): Remove old comment.
6022         * objfiles.c (free_all_objfiles): Fix a typo.
6023
6024 2019-04-10  Tom Tromey  <tom@tromey.com>
6025
6026         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6027         * minsyms.c (lookup_minimal_symbol): Use foreach.
6028         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6029         (lookup_minimal_symbol_solib_trampoline): Likewise.
6030         * symfile.c (reread_symbols): Use foreach.
6031
6032 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6033             Tom Tromey  <tromey@adacore.com>
6034
6035         PR rust/24414:
6036         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6037         (rust_lex_int_test): Change "value" to be LONGEST.
6038         (rust_lex_tests): Add test for long integer literal.
6039
6040 2019-04-09  Tom Tromey  <tromey@adacore.com>
6041
6042         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6043         to bool.
6044         (extended_remote_target::attach): Update.
6045         (remote_target::remote_notice_new_inferior): Update.
6046         (remote_target::add_current_inferior_and_thread): Update.
6047         * inferior.c (exit_inferior_1): Use "false".
6048         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6049
6050 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6051
6052         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6053         the "start" command.
6054
6055 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6056
6057         * python/py-inferior.c (infpy_thread_from_thread_handle):
6058         Adjust comments to reflect renaming of thread_from_thread_handle
6059         to thread_from_handle.  Adjust keywords.  Fix type error message.
6060         (inferior_object_methods): Add thread_from_handle.  Retain
6061         thread_from_thread_handle, but mark it as deprecated.
6062
6063 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6064
6065         * gdbthread.h (find_thread_by_handle): Revise declaration.
6066         * thread.c (find_thread_by_handle): Likewise.  Adjust
6067         implementation too.
6068         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6069         support for buffer objects as handles.
6070
6071 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6072
6073         * python/py-infthread.c (thpy_thread_handle): New function.
6074         (thread_object_methods): Register thpy_thread_handle.
6075
6076 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6077
6078         * gdbthread.h (thread_to_thread_handle): Declare.
6079         * thread.c (gdbtypes.h): Include.
6080         (thread_to_thread_handle): New function.
6081
6082         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6083         (target_thread_info_to_thread_handle): Declare.
6084         * target.c (target_thread_info_to_thread_handle): New function.
6085         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6086         * target-delegates.c: Regenerate.
6087
6088         * linux-thread-db.c (class thread_db_target): Add method
6089         thread_info_to_thread_handle.
6090         (thread_db_target::thread_info_to_thread_handle): Define.
6091         * remote.c (class remote_target): Add new method
6092         thread_info_to_thread_handle.
6093         (remote_target::thread_info_to_thread_handle): Define.
6094
6095 2019-04-08  Pedro Alves  <palves@redhat.com>
6096
6097         * common/common-exceptions.c (throw_exception): Don't create
6098         named object to throw; throw directly.
6099         (throw_it): Likewise.  Don't initialize gdb_exception::message
6100         here, with new; pass FMT and AP to the ctor instead.
6101         * common/common-exceptions.h: Include <string>.
6102         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6103         const char *, va_list)): New ctor.  Use std::make_shared.
6104         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6105         errors)): Delete.
6106         (gdb_exception_error::gdb_exception_error(enum errors, const char
6107         *, va_list)): New.
6108         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6109         Add assertion.
6110         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6111         errors)): Delete.
6112         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6113         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6114         Add assertion.
6115
6116 2019-04-08  Tom Tromey  <tom@tromey.com>
6117
6118         * valops.c (value_rtti_indirect_type): Replace throw_exception
6119         with throw.
6120         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6121         with throw.
6122         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6123         throw.
6124         * target.c (target_translate_tls_address): Replace throw_exception
6125         with throw.
6126         * stack.c (frame_apply_command_count): Replace throw_exception
6127         with throw.
6128         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6129         throw.
6130         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6131         with throw.
6132         * rs6000-tdep.c (rs6000_frame_cache)
6133         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6134         * remote.c: Replace throw_exception with throw.
6135         * record-full.c (record_full_message, record_full_wait_1)
6136         (record_full_restore): Replace throw_exception with throw.
6137         * record-btrace.c:
6138         (get_thread_current_frame_id, record_btrace_start_replaying)
6139         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6140         (cmd_record_btrace_start): Replace throw_exception with throw.
6141         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6142         throw.
6143         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6144         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6145         * linespec.c:
6146         (find_linespec_symbols): Replace throw_exception with throw.
6147         * infrun.c (displaced_step_prepare, resume): Replace
6148         throw_exception with throw.
6149         * infcmd.c (post_create_inferior): Replace throw_exception with
6150         throw.
6151         * inf-loop.c (inferior_event_handler): Replace throw_exception
6152         with throw.
6153         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6154         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6155         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6156         (get_prev_frame_always, get_frame_pc_if_available)
6157         (get_frame_address_in_block_if_available, get_frame_language):
6158         Replace throw_exception with throw.
6159         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6160         throw_exception with throw.
6161         * eval.c (fetch_subexp_value, evaluate_var_value)
6162         (evaluate_funcall, evaluate_subexp_standard): Replace
6163         throw_exception with throw.
6164         * dwarf2loc.c (call_site_find_chain)
6165         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6166         Replace throw_exception with throw.
6167         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6168         with throw.
6169         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6170         throw.
6171         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6172         * completer.c (complete_line_internal): Replace throw_exception
6173         with throw.
6174         * compile/compile-object-run.c (compile_object_run): Replace
6175         throw_exception with throw.
6176         * cli/cli-script.c (process_next_line): Replace throw_exception
6177         with throw.
6178         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6179         (btrace_enable, btrace_maint_update_pt_packets): Replace
6180         throw_exception with throw.
6181         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6182         throw_exception with throw.
6183         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6184         throw_exception with throw.
6185         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6186         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6187         * aarch64-tdep.c (aarch64_make_prologue_cache)
6188         (aarch64_make_stub_cache): Replace throw_exception with throw.
6189
6190 2019-04-08  Tom Tromey  <tom@tromey.com>
6191
6192         * common/common-exceptions.c (throw_exception): Rename from
6193         throw_exception_cxx.  Remove old copy.  Make argument const.
6194         (throw_it): Create and throw exception objects directly.
6195         * common/common-exceptions.h (throw_exception): Make argument
6196         const.
6197         (struct gdb_exception_error): Add constructor.
6198         (struct gdb_exception_quit): Add constructor.
6199
6200 2019-04-08  Tom Tromey  <tom@tromey.com>
6201
6202         * common/common-exceptions.h (exception_rethrow): Don't declare.
6203         (TRY_SJLJ): Update comment.
6204         (TRY, CATCH, END_CATCH): Remove.
6205         * common/common-exceptions.c (exception_rethrow): Remove.
6206
6207 2019-04-08  Tom Tromey  <tom@tromey.com>
6208
6209         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6210         Remove.
6211         (gdb_exception_error): Rename from
6212         gdb_exception_RETURN_MASK_ERROR.
6213         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6214         (gdb_quit_bad_alloc): Update.
6215         * aarch64-tdep.c: Update.
6216         * ada-lang.c: Update.
6217         * ada-typeprint.c: Update.
6218         * ada-valprint.c: Update.
6219         * amd64-tdep.c: Update.
6220         * arch-utils.c: Update.
6221         * break-catch-throw.c: Update.
6222         * breakpoint.c: Update.
6223         * btrace.c: Update.
6224         * c-varobj.c: Update.
6225         * cli/cli-cmds.c: Update.
6226         * cli/cli-interp.c: Update.
6227         * cli/cli-script.c: Update.
6228         * common/common-exceptions.c: Update.
6229         * common/new-op.c: Update.
6230         * common/selftest.c: Update.
6231         * compile/compile-c-symbols.c: Update.
6232         * compile/compile-cplus-symbols.c: Update.
6233         * compile/compile-object-load.c: Update.
6234         * compile/compile-object-run.c: Update.
6235         * completer.c: Update.
6236         * corelow.c: Update.
6237         * cp-abi.c: Update.
6238         * cp-support.c: Update.
6239         * cp-valprint.c: Update.
6240         * darwin-nat.c: Update.
6241         * disasm-selftests.c: Update.
6242         * dtrace-probe.c: Update.
6243         * dwarf-index-cache.c: Update.
6244         * dwarf-index-write.c: Update.
6245         * dwarf2-frame-tailcall.c: Update.
6246         * dwarf2-frame.c: Update.
6247         * dwarf2loc.c: Update.
6248         * dwarf2read.c: Update.
6249         * eval.c: Update.
6250         * event-loop.c: Update.
6251         * event-top.c: Update.
6252         * exec.c: Update.
6253         * f-valprint.c: Update.
6254         * fbsd-tdep.c: Update.
6255         * frame-unwind.c: Update.
6256         * frame.c: Update.
6257         * gdbtypes.c: Update.
6258         * gnu-v3-abi.c: Update.
6259         * guile/guile-internal.h: Update.
6260         * guile/scm-block.c: Update.
6261         * guile/scm-breakpoint.c: Update.
6262         * guile/scm-cmd.c: Update.
6263         * guile/scm-disasm.c: Update.
6264         * guile/scm-frame.c: Update.
6265         * guile/scm-lazy-string.c: Update.
6266         * guile/scm-math.c: Update.
6267         * guile/scm-param.c: Update.
6268         * guile/scm-ports.c: Update.
6269         * guile/scm-pretty-print.c: Update.
6270         * guile/scm-symbol.c: Update.
6271         * guile/scm-symtab.c: Update.
6272         * guile/scm-type.c: Update.
6273         * guile/scm-value.c: Update.
6274         * i386-linux-tdep.c: Update.
6275         * i386-tdep.c: Update.
6276         * inf-loop.c: Update.
6277         * infcall.c: Update.
6278         * infcmd.c: Update.
6279         * infrun.c: Update.
6280         * jit.c: Update.
6281         * language.c: Update.
6282         * linespec.c: Update.
6283         * linux-fork.c: Update.
6284         * linux-nat.c: Update.
6285         * linux-tdep.c: Update.
6286         * linux-thread-db.c: Update.
6287         * main.c: Update.
6288         * mi/mi-cmd-break.c: Update.
6289         * mi/mi-cmd-stack.c: Update.
6290         * mi/mi-interp.c: Update.
6291         * mi/mi-main.c: Update.
6292         * objc-lang.c: Update.
6293         * p-valprint.c: Update.
6294         * parse.c: Update.
6295         * ppc-linux-tdep.c: Update.
6296         * printcmd.c: Update.
6297         * python/py-arch.c: Update.
6298         * python/py-breakpoint.c: Update.
6299         * python/py-cmd.c: Update.
6300         * python/py-finishbreakpoint.c: Update.
6301         * python/py-frame.c: Update.
6302         * python/py-framefilter.c: Update.
6303         * python/py-gdb-readline.c: Update.
6304         * python/py-inferior.c: Update.
6305         * python/py-infthread.c: Update.
6306         * python/py-lazy-string.c: Update.
6307         * python/py-linetable.c: Update.
6308         * python/py-objfile.c: Update.
6309         * python/py-param.c: Update.
6310         * python/py-prettyprint.c: Update.
6311         * python/py-progspace.c: Update.
6312         * python/py-record-btrace.c: Update.
6313         * python/py-record.c: Update.
6314         * python/py-symbol.c: Update.
6315         * python/py-type.c: Update.
6316         * python/py-unwind.c: Update.
6317         * python/py-utils.c: Update.
6318         * python/py-value.c: Update.
6319         * python/python.c: Update.
6320         * record-btrace.c: Update.
6321         * record-full.c: Update.
6322         * remote-fileio.c: Update.
6323         * remote.c: Update.
6324         * riscv-tdep.c: Update.
6325         * rs6000-aix-tdep.c: Update.
6326         * rs6000-tdep.c: Update.
6327         * rust-exp.y: Update.
6328         * rust-lang.c: Update.
6329         * s390-tdep.c: Update.
6330         * selftest-arch.c: Update.
6331         * solib-dsbt.c: Update.
6332         * solib-frv.c: Update.
6333         * solib-spu.c: Update.
6334         * solib-svr4.c: Update.
6335         * solib.c: Update.
6336         * sparc64-linux-tdep.c: Update.
6337         * stack.c: Update.
6338         * symfile-mem.c: Update.
6339         * symmisc.c: Update.
6340         * target.c: Update.
6341         * thread.c: Update.
6342         * top.c: Update.
6343         * tracefile-tfile.c: Update.
6344         * tui/tui.c: Update.
6345         * typeprint.c: Update.
6346         * unittests/cli-utils-selftests.c: Update.
6347         * unittests/parse-connection-spec-selftests.c: Update.
6348         * valops.c: Update.
6349         * valprint.c: Update.
6350         * value.c: Update.
6351         * varobj.c: Update.
6352         * windows-nat.c: Update.
6353         * x86-linux-nat.c: Update.
6354         * xml-support.c: Update.
6355
6356 2019-04-08  Tom Tromey  <tom@tromey.com>
6357
6358         * xml-support.c: Use C++ exception handling.
6359         * x86-linux-nat.c: Use C++ exception handling.
6360         * windows-nat.c: Use C++ exception handling.
6361         * varobj.c: Use C++ exception handling.
6362         * value.c: Use C++ exception handling.
6363         * valprint.c: Use C++ exception handling.
6364         * valops.c: Use C++ exception handling.
6365         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6366         handling.
6367         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6368         * typeprint.c: Use C++ exception handling.
6369         * tui/tui.c: Use C++ exception handling.
6370         * tracefile-tfile.c: Use C++ exception handling.
6371         * top.c: Use C++ exception handling.
6372         * thread.c: Use C++ exception handling.
6373         * target.c: Use C++ exception handling.
6374         * symmisc.c: Use C++ exception handling.
6375         * symfile-mem.c: Use C++ exception handling.
6376         * stack.c: Use C++ exception handling.
6377         * sparc64-linux-tdep.c: Use C++ exception handling.
6378         * solib.c: Use C++ exception handling.
6379         * solib-svr4.c: Use C++ exception handling.
6380         * solib-spu.c: Use C++ exception handling.
6381         * solib-frv.c: Use C++ exception handling.
6382         * solib-dsbt.c: Use C++ exception handling.
6383         * selftest-arch.c: Use C++ exception handling.
6384         * s390-tdep.c: Use C++ exception handling.
6385         * rust-lang.c: Use C++ exception handling.
6386         * rust-exp.y: Use C++ exception handling.
6387         * rs6000-tdep.c: Use C++ exception handling.
6388         * rs6000-aix-tdep.c: Use C++ exception handling.
6389         * riscv-tdep.c: Use C++ exception handling.
6390         * remote.c: Use C++ exception handling.
6391         * remote-fileio.c: Use C++ exception handling.
6392         * record-full.c: Use C++ exception handling.
6393         * record-btrace.c: Use C++ exception handling.
6394         * python/python.c: Use C++ exception handling.
6395         * python/py-value.c: Use C++ exception handling.
6396         * python/py-utils.c: Use C++ exception handling.
6397         * python/py-unwind.c: Use C++ exception handling.
6398         * python/py-type.c: Use C++ exception handling.
6399         * python/py-symbol.c: Use C++ exception handling.
6400         * python/py-record.c: Use C++ exception handling.
6401         * python/py-record-btrace.c: Use C++ exception handling.
6402         * python/py-progspace.c: Use C++ exception handling.
6403         * python/py-prettyprint.c: Use C++ exception handling.
6404         * python/py-param.c: Use C++ exception handling.
6405         * python/py-objfile.c: Use C++ exception handling.
6406         * python/py-linetable.c: Use C++ exception handling.
6407         * python/py-lazy-string.c: Use C++ exception handling.
6408         * python/py-infthread.c: Use C++ exception handling.
6409         * python/py-inferior.c: Use C++ exception handling.
6410         * python/py-gdb-readline.c: Use C++ exception handling.
6411         * python/py-framefilter.c: Use C++ exception handling.
6412         * python/py-frame.c: Use C++ exception handling.
6413         * python/py-finishbreakpoint.c: Use C++ exception handling.
6414         * python/py-cmd.c: Use C++ exception handling.
6415         * python/py-breakpoint.c: Use C++ exception handling.
6416         * python/py-arch.c: Use C++ exception handling.
6417         * printcmd.c: Use C++ exception handling.
6418         * ppc-linux-tdep.c: Use C++ exception handling.
6419         * parse.c: Use C++ exception handling.
6420         * p-valprint.c: Use C++ exception handling.
6421         * objc-lang.c: Use C++ exception handling.
6422         * mi/mi-main.c: Use C++ exception handling.
6423         * mi/mi-interp.c: Use C++ exception handling.
6424         * mi/mi-cmd-stack.c: Use C++ exception handling.
6425         * mi/mi-cmd-break.c: Use C++ exception handling.
6426         * main.c: Use C++ exception handling.
6427         * linux-thread-db.c: Use C++ exception handling.
6428         * linux-tdep.c: Use C++ exception handling.
6429         * linux-nat.c: Use C++ exception handling.
6430         * linux-fork.c: Use C++ exception handling.
6431         * linespec.c: Use C++ exception handling.
6432         * language.c: Use C++ exception handling.
6433         * jit.c: Use C++ exception handling.
6434         * infrun.c: Use C++ exception handling.
6435         * infcmd.c: Use C++ exception handling.
6436         * infcall.c: Use C++ exception handling.
6437         * inf-loop.c: Use C++ exception handling.
6438         * i386-tdep.c: Use C++ exception handling.
6439         * i386-linux-tdep.c: Use C++ exception handling.
6440         * guile/scm-value.c: Use C++ exception handling.
6441         * guile/scm-type.c: Use C++ exception handling.
6442         * guile/scm-symtab.c: Use C++ exception handling.
6443         * guile/scm-symbol.c: Use C++ exception handling.
6444         * guile/scm-pretty-print.c: Use C++ exception handling.
6445         * guile/scm-ports.c: Use C++ exception handling.
6446         * guile/scm-param.c: Use C++ exception handling.
6447         * guile/scm-math.c: Use C++ exception handling.
6448         * guile/scm-lazy-string.c: Use C++ exception handling.
6449         * guile/scm-frame.c: Use C++ exception handling.
6450         * guile/scm-disasm.c: Use C++ exception handling.
6451         * guile/scm-cmd.c: Use C++ exception handling.
6452         * guile/scm-breakpoint.c: Use C++ exception handling.
6453         * guile/scm-block.c: Use C++ exception handling.
6454         * guile/guile-internal.h: Use C++ exception handling.
6455         * gnu-v3-abi.c: Use C++ exception handling.
6456         * gdbtypes.c: Use C++ exception handling.
6457         * frame.c: Use C++ exception handling.
6458         * frame-unwind.c: Use C++ exception handling.
6459         * fbsd-tdep.c: Use C++ exception handling.
6460         * f-valprint.c: Use C++ exception handling.
6461         * exec.c: Use C++ exception handling.
6462         * event-top.c: Use C++ exception handling.
6463         * event-loop.c: Use C++ exception handling.
6464         * eval.c: Use C++ exception handling.
6465         * dwarf2read.c: Use C++ exception handling.
6466         * dwarf2loc.c: Use C++ exception handling.
6467         * dwarf2-frame.c: Use C++ exception handling.
6468         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6469         * dwarf-index-write.c: Use C++ exception handling.
6470         * dwarf-index-cache.c: Use C++ exception handling.
6471         * dtrace-probe.c: Use C++ exception handling.
6472         * disasm-selftests.c: Use C++ exception handling.
6473         * darwin-nat.c: Use C++ exception handling.
6474         * cp-valprint.c: Use C++ exception handling.
6475         * cp-support.c: Use C++ exception handling.
6476         * cp-abi.c: Use C++ exception handling.
6477         * corelow.c: Use C++ exception handling.
6478         * completer.c: Use C++ exception handling.
6479         * compile/compile-object-run.c: Use C++ exception handling.
6480         * compile/compile-object-load.c: Use C++ exception handling.
6481         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6482         * compile/compile-c-symbols.c: Use C++ exception handling.
6483         * common/selftest.c: Use C++ exception handling.
6484         * common/new-op.c: Use C++ exception handling.
6485         * cli/cli-script.c: Use C++ exception handling.
6486         * cli/cli-interp.c: Use C++ exception handling.
6487         * cli/cli-cmds.c: Use C++ exception handling.
6488         * c-varobj.c: Use C++ exception handling.
6489         * btrace.c: Use C++ exception handling.
6490         * breakpoint.c: Use C++ exception handling.
6491         * break-catch-throw.c: Use C++ exception handling.
6492         * arch-utils.c: Use C++ exception handling.
6493         * amd64-tdep.c: Use C++ exception handling.
6494         * ada-valprint.c: Use C++ exception handling.
6495         * ada-typeprint.c: Use C++ exception handling.
6496         * ada-lang.c: Use C++ exception handling.
6497         * aarch64-tdep.c: Use C++ exception handling.
6498
6499 2019-04-08  Tom Tromey  <tom@tromey.com>
6500
6501         * xml-support.c (gdb_xml_parser::parse): Update.
6502         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6503         * value.c (show_convenience): Update.
6504         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6505         (test_parse_flags_qcs): Update.
6506         * thread.c (thr_try_catch_cmd): Update.
6507         * target.c (target_translate_tls_address): Update.
6508         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6509         (info_frame_command_core, frame_apply_command_count): Update.
6510         * rust-exp.y (rust_lex_exception_test): Update.
6511         * riscv-tdep.c (riscv_print_one_register_info): Update.
6512         * remote.c (remote_target::enable_btrace): Update.
6513         * record-btrace.c (record_btrace_enable_warn): Update.
6514         * python/py-utils.c (gdbpy_convert_exception): Update.
6515         * printcmd.c (do_one_display, print_variable_and_value): Update.
6516         * mi/mi-main.c (mi_print_exception): Update.
6517         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6518         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6519         * linux-nat.c (linux_nat_target::attach): Update.
6520         * linux-fork.c (class scoped_switch_fork_info): Update.
6521         * infrun.c (displaced_step_prepare): Update.
6522         * infcall.c (call_function_by_hand_dummy): Update.
6523         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6524         * gnu-v3-abi.c (print_one_vtable): Update.
6525         * frame.c (get_prev_frame_always): Update.
6526         * f-valprint.c (info_common_command_for_block): Update.
6527         * exec.c (try_open_exec_file): Update.
6528         * exceptions.c (print_exception, exception_print)
6529         (exception_fprintf, exception_print_same): Update.
6530         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6531         * dwarf-index-cache.c (index_cache::store)
6532         (index_cache::lookup_gdb_index): Update.
6533         * darwin-nat.c (maybe_cache_shell): Update.
6534         * cp-valprint.c (cp_print_value_fields): Update.
6535         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6536         (gcc_cplus_symbol_address): Update.
6537         * compile/compile-c-symbols.c (gcc_convert_symbol)
6538         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6539         * common/selftest.c: Update.
6540         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6541         a std::string.
6542         (exception_try_scope_entry, exception_try_scope_exit): Don't
6543         declare.
6544         (struct exception_try_scope): Remove.
6545         (TRY): Don't use exception_try_scope.
6546         (struct gdb_exception): Add constructor, operator=.
6547         <what>: New method.
6548         (struct gdb_exception_RETURN_MASK_ALL)
6549         (struct gdb_exception_RETURN_MASK_ERROR)
6550         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6551         (struct gdb_quit_bad_alloc): Update.
6552         * common/common-exceptions.c (exception_none): Change
6553         initializer.
6554         (struct catcher) <state, exception>: Initialize inline.
6555         <prev>: Remove member.
6556         (current_catcher): Remove.
6557         (catchers): New global.
6558         (exceptions_state_mc_init): Simplify.
6559         (catcher_pop): Remove.
6560         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6561         (try_scope_depth, exception_try_scope_entry)
6562         (exception_try_scope_exit): Remove.
6563         (throw_exception_sjlj): Update.
6564         (exception_messages, exception_messages_size): Remove.
6565         (throw_it): Simplify.
6566         (gdb_exception_sliced_copy): Remove.
6567         (throw_exception_cxx): Update.
6568         * cli/cli-script.c (script_from_file): Update.
6569         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6570         Update.
6571         * ada-valprint.c (ada_val_print): Update.
6572         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6573         (create_excep_cond_exprs): Update.
6574
6575 2019-04-08  Tom Tromey  <tom@tromey.com>
6576
6577         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6578         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6579         (TRY, CATCH, END_CATCH): Remove some definitions.
6580         * common/common-exceptions.c: Don't use GDB_XCPT.
6581         (catcher_list_size): Remove.
6582         (throw_exception, throw_it): Simplify.
6583
6584 2019-04-05  Tom Tromey  <tom@tromey.com>
6585
6586         Revert the header-sorting patch.
6587         * ft32-tdep.c: Revert.
6588         * frv-tdep.c: Revert.
6589         * frv-linux-tdep.c: Revert.
6590         * frame.c: Revert.
6591         * frame-unwind.c: Revert.
6592         * frame-base.c: Revert.
6593         * fork-child.c: Revert.
6594         * findvar.c: Revert.
6595         * findcmd.c: Revert.
6596         * filesystem.c: Revert.
6597         * filename-seen-cache.h: Revert.
6598         * filename-seen-cache.c: Revert.
6599         * fbsd-tdep.c: Revert.
6600         * fbsd-nat.h: Revert.
6601         * fbsd-nat.c: Revert.
6602         * f-valprint.c: Revert.
6603         * f-typeprint.c: Revert.
6604         * f-lang.c: Revert.
6605         * extension.h: Revert.
6606         * extension.c: Revert.
6607         * extension-priv.h: Revert.
6608         * expprint.c: Revert.
6609         * exec.h: Revert.
6610         * exec.c: Revert.
6611         * exceptions.c: Revert.
6612         * event-top.c: Revert.
6613         * event-loop.c: Revert.
6614         * eval.c: Revert.
6615         * elfread.c: Revert.
6616         * dwarf2read.h: Revert.
6617         * dwarf2read.c: Revert.
6618         * dwarf2loc.c: Revert.
6619         * dwarf2expr.h: Revert.
6620         * dwarf2expr.c: Revert.
6621         * dwarf2-frame.c: Revert.
6622         * dwarf2-frame-tailcall.c: Revert.
6623         * dwarf-index-write.h: Revert.
6624         * dwarf-index-write.c: Revert.
6625         * dwarf-index-common.c: Revert.
6626         * dwarf-index-cache.h: Revert.
6627         * dwarf-index-cache.c: Revert.
6628         * dummy-frame.c: Revert.
6629         * dtrace-probe.c: Revert.
6630         * disasm.h: Revert.
6631         * disasm.c: Revert.
6632         * disasm-selftests.c: Revert.
6633         * dictionary.c: Revert.
6634         * dicos-tdep.c: Revert.
6635         * demangle.c: Revert.
6636         * dcache.h: Revert.
6637         * dcache.c: Revert.
6638         * darwin-nat.h: Revert.
6639         * darwin-nat.c: Revert.
6640         * darwin-nat-info.c: Revert.
6641         * d-valprint.c: Revert.
6642         * d-namespace.c: Revert.
6643         * d-lang.c: Revert.
6644         * ctf.c: Revert.
6645         * csky-tdep.c: Revert.
6646         * csky-linux-tdep.c: Revert.
6647         * cris-tdep.c: Revert.
6648         * cris-linux-tdep.c: Revert.
6649         * cp-valprint.c: Revert.
6650         * cp-support.c: Revert.
6651         * cp-namespace.c: Revert.
6652         * cp-abi.c: Revert.
6653         * corelow.c: Revert.
6654         * corefile.c: Revert.
6655         * continuations.c: Revert.
6656         * completer.h: Revert.
6657         * completer.c: Revert.
6658         * complaints.c: Revert.
6659         * coffread.c: Revert.
6660         * coff-pe-read.c: Revert.
6661         * cli-out.h: Revert.
6662         * cli-out.c: Revert.
6663         * charset.c: Revert.
6664         * c-varobj.c: Revert.
6665         * c-valprint.c: Revert.
6666         * c-typeprint.c: Revert.
6667         * c-lang.c: Revert.
6668         * buildsym.c: Revert.
6669         * buildsym-legacy.c: Revert.
6670         * build-id.h: Revert.
6671         * build-id.c: Revert.
6672         * btrace.c: Revert.
6673         * bsd-uthread.c: Revert.
6674         * breakpoint.h: Revert.
6675         * breakpoint.c: Revert.
6676         * break-catch-throw.c: Revert.
6677         * break-catch-syscall.c: Revert.
6678         * break-catch-sig.c: Revert.
6679         * blockframe.c: Revert.
6680         * block.c: Revert.
6681         * bfin-tdep.c: Revert.
6682         * bfin-linux-tdep.c: Revert.
6683         * bfd-target.c: Revert.
6684         * bcache.c: Revert.
6685         * ax-general.c: Revert.
6686         * ax-gdb.h: Revert.
6687         * ax-gdb.c: Revert.
6688         * avr-tdep.c: Revert.
6689         * auxv.c: Revert.
6690         * auto-load.c: Revert.
6691         * arm-wince-tdep.c: Revert.
6692         * arm-tdep.c: Revert.
6693         * arm-symbian-tdep.c: Revert.
6694         * arm-pikeos-tdep.c: Revert.
6695         * arm-obsd-tdep.c: Revert.
6696         * arm-nbsd-tdep.c: Revert.
6697         * arm-nbsd-nat.c: Revert.
6698         * arm-linux-tdep.c: Revert.
6699         * arm-linux-nat.c: Revert.
6700         * arm-fbsd-tdep.c: Revert.
6701         * arm-fbsd-nat.c: Revert.
6702         * arm-bsd-tdep.c: Revert.
6703         * arch-utils.c: Revert.
6704         * arc-tdep.c: Revert.
6705         * arc-newlib-tdep.c: Revert.
6706         * annotate.h: Revert.
6707         * annotate.c: Revert.
6708         * amd64-windows-tdep.c: Revert.
6709         * amd64-windows-nat.c: Revert.
6710         * amd64-tdep.c: Revert.
6711         * amd64-sol2-tdep.c: Revert.
6712         * amd64-obsd-tdep.c: Revert.
6713         * amd64-obsd-nat.c: Revert.
6714         * amd64-nbsd-tdep.c: Revert.
6715         * amd64-nbsd-nat.c: Revert.
6716         * amd64-nat.c: Revert.
6717         * amd64-linux-tdep.c: Revert.
6718         * amd64-linux-nat.c: Revert.
6719         * amd64-fbsd-tdep.c: Revert.
6720         * amd64-fbsd-nat.c: Revert.
6721         * amd64-dicos-tdep.c: Revert.
6722         * amd64-darwin-tdep.c: Revert.
6723         * amd64-bsd-nat.c: Revert.
6724         * alpha-tdep.c: Revert.
6725         * alpha-obsd-tdep.c: Revert.
6726         * alpha-nbsd-tdep.c: Revert.
6727         * alpha-mdebug-tdep.c: Revert.
6728         * alpha-linux-tdep.c: Revert.
6729         * alpha-linux-nat.c: Revert.
6730         * alpha-bsd-tdep.c: Revert.
6731         * alpha-bsd-nat.c: Revert.
6732         * aix-thread.c: Revert.
6733         * agent.c: Revert.
6734         * addrmap.c: Revert.
6735         * ada-varobj.c: Revert.
6736         * ada-valprint.c: Revert.
6737         * ada-typeprint.c: Revert.
6738         * ada-tasks.c: Revert.
6739         * ada-lang.c: Revert.
6740         * aarch64-tdep.c: Revert.
6741         * aarch64-ravenscar-thread.c: Revert.
6742         * aarch64-newlib-tdep.c: Revert.
6743         * aarch64-linux-tdep.c: Revert.
6744         * aarch64-linux-nat.c: Revert.
6745         * aarch64-fbsd-tdep.c: Revert.
6746         * aarch64-fbsd-nat.c: Revert.
6747         * aarch32-linux-nat.c: Revert.
6748
6749 2019-04-05  Tom Tromey  <tom@tromey.com>
6750
6751         * ft32-tdep.c: Sort headers.
6752         * frv-tdep.c: Sort headers.
6753         * frv-linux-tdep.c: Sort headers.
6754         * frame.c: Sort headers.
6755         * frame-unwind.c: Sort headers.
6756         * frame-base.c: Sort headers.
6757         * fork-child.c: Sort headers.
6758         * findvar.c: Sort headers.
6759         * findcmd.c: Sort headers.
6760         * filesystem.c: Sort headers.
6761         * filename-seen-cache.h: Sort headers.
6762         * filename-seen-cache.c: Sort headers.
6763         * fbsd-tdep.c: Sort headers.
6764         * fbsd-nat.h: Sort headers.
6765         * fbsd-nat.c: Sort headers.
6766         * f-valprint.c: Sort headers.
6767         * f-typeprint.c: Sort headers.
6768         * f-lang.c: Sort headers.
6769         * extension.h: Sort headers.
6770         * extension.c: Sort headers.
6771         * extension-priv.h: Sort headers.
6772         * expprint.c: Sort headers.
6773         * exec.h: Sort headers.
6774         * exec.c: Sort headers.
6775         * exceptions.c: Sort headers.
6776         * event-top.c: Sort headers.
6777         * event-loop.c: Sort headers.
6778         * eval.c: Sort headers.
6779         * elfread.c: Sort headers.
6780         * dwarf2read.h: Sort headers.
6781         * dwarf2read.c: Sort headers.
6782         * dwarf2loc.c: Sort headers.
6783         * dwarf2expr.h: Sort headers.
6784         * dwarf2expr.c: Sort headers.
6785         * dwarf2-frame.c: Sort headers.
6786         * dwarf2-frame-tailcall.c: Sort headers.
6787         * dwarf-index-write.h: Sort headers.
6788         * dwarf-index-write.c: Sort headers.
6789         * dwarf-index-common.c: Sort headers.
6790         * dwarf-index-cache.h: Sort headers.
6791         * dwarf-index-cache.c: Sort headers.
6792         * dummy-frame.c: Sort headers.
6793         * dtrace-probe.c: Sort headers.
6794         * disasm.h: Sort headers.
6795         * disasm.c: Sort headers.
6796         * disasm-selftests.c: Sort headers.
6797         * dictionary.c: Sort headers.
6798         * dicos-tdep.c: Sort headers.
6799         * demangle.c: Sort headers.
6800         * dcache.h: Sort headers.
6801         * dcache.c: Sort headers.
6802         * darwin-nat.h: Sort headers.
6803         * darwin-nat.c: Sort headers.
6804         * darwin-nat-info.c: Sort headers.
6805         * d-valprint.c: Sort headers.
6806         * d-namespace.c: Sort headers.
6807         * d-lang.c: Sort headers.
6808         * ctf.c: Sort headers.
6809         * csky-tdep.c: Sort headers.
6810         * csky-linux-tdep.c: Sort headers.
6811         * cris-tdep.c: Sort headers.
6812         * cris-linux-tdep.c: Sort headers.
6813         * cp-valprint.c: Sort headers.
6814         * cp-support.c: Sort headers.
6815         * cp-namespace.c: Sort headers.
6816         * cp-abi.c: Sort headers.
6817         * corelow.c: Sort headers.
6818         * corefile.c: Sort headers.
6819         * continuations.c: Sort headers.
6820         * completer.h: Sort headers.
6821         * completer.c: Sort headers.
6822         * complaints.c: Sort headers.
6823         * coffread.c: Sort headers.
6824         * coff-pe-read.c: Sort headers.
6825         * cli-out.h: Sort headers.
6826         * cli-out.c: Sort headers.
6827         * charset.c: Sort headers.
6828         * c-varobj.c: Sort headers.
6829         * c-valprint.c: Sort headers.
6830         * c-typeprint.c: Sort headers.
6831         * c-lang.c: Sort headers.
6832         * buildsym.c: Sort headers.
6833         * buildsym-legacy.c: Sort headers.
6834         * build-id.h: Sort headers.
6835         * build-id.c: Sort headers.
6836         * btrace.c: Sort headers.
6837         * bsd-uthread.c: Sort headers.
6838         * breakpoint.h: Sort headers.
6839         * breakpoint.c: Sort headers.
6840         * break-catch-throw.c: Sort headers.
6841         * break-catch-syscall.c: Sort headers.
6842         * break-catch-sig.c: Sort headers.
6843         * blockframe.c: Sort headers.
6844         * block.c: Sort headers.
6845         * bfin-tdep.c: Sort headers.
6846         * bfin-linux-tdep.c: Sort headers.
6847         * bfd-target.c: Sort headers.
6848         * bcache.c: Sort headers.
6849         * ax-general.c: Sort headers.
6850         * ax-gdb.h: Sort headers.
6851         * ax-gdb.c: Sort headers.
6852         * avr-tdep.c: Sort headers.
6853         * auxv.c: Sort headers.
6854         * auto-load.c: Sort headers.
6855         * arm-wince-tdep.c: Sort headers.
6856         * arm-tdep.c: Sort headers.
6857         * arm-symbian-tdep.c: Sort headers.
6858         * arm-pikeos-tdep.c: Sort headers.
6859         * arm-obsd-tdep.c: Sort headers.
6860         * arm-nbsd-tdep.c: Sort headers.
6861         * arm-nbsd-nat.c: Sort headers.
6862         * arm-linux-tdep.c: Sort headers.
6863         * arm-linux-nat.c: Sort headers.
6864         * arm-fbsd-tdep.c: Sort headers.
6865         * arm-fbsd-nat.c: Sort headers.
6866         * arm-bsd-tdep.c: Sort headers.
6867         * arch-utils.c: Sort headers.
6868         * arc-tdep.c: Sort headers.
6869         * arc-newlib-tdep.c: Sort headers.
6870         * annotate.h: Sort headers.
6871         * annotate.c: Sort headers.
6872         * amd64-windows-tdep.c: Sort headers.
6873         * amd64-windows-nat.c: Sort headers.
6874         * amd64-tdep.c: Sort headers.
6875         * amd64-sol2-tdep.c: Sort headers.
6876         * amd64-obsd-tdep.c: Sort headers.
6877         * amd64-obsd-nat.c: Sort headers.
6878         * amd64-nbsd-tdep.c: Sort headers.
6879         * amd64-nbsd-nat.c: Sort headers.
6880         * amd64-nat.c: Sort headers.
6881         * amd64-linux-tdep.c: Sort headers.
6882         * amd64-linux-nat.c: Sort headers.
6883         * amd64-fbsd-tdep.c: Sort headers.
6884         * amd64-fbsd-nat.c: Sort headers.
6885         * amd64-dicos-tdep.c: Sort headers.
6886         * amd64-darwin-tdep.c: Sort headers.
6887         * amd64-bsd-nat.c: Sort headers.
6888         * alpha-tdep.c: Sort headers.
6889         * alpha-obsd-tdep.c: Sort headers.
6890         * alpha-nbsd-tdep.c: Sort headers.
6891         * alpha-mdebug-tdep.c: Sort headers.
6892         * alpha-linux-tdep.c: Sort headers.
6893         * alpha-linux-nat.c: Sort headers.
6894         * alpha-bsd-tdep.c: Sort headers.
6895         * alpha-bsd-nat.c: Sort headers.
6896         * aix-thread.c: Sort headers.
6897         * agent.c: Sort headers.
6898         * addrmap.c: Sort headers.
6899         * ada-varobj.c: Sort headers.
6900         * ada-valprint.c: Sort headers.
6901         * ada-typeprint.c: Sort headers.
6902         * ada-tasks.c: Sort headers.
6903         * ada-lang.c: Sort headers.
6904         * aarch64-tdep.c: Sort headers.
6905         * aarch64-ravenscar-thread.c: Sort headers.
6906         * aarch64-newlib-tdep.c: Sort headers.
6907         * aarch64-linux-tdep.c: Sort headers.
6908         * aarch64-linux-nat.c: Sort headers.
6909         * aarch64-fbsd-tdep.c: Sort headers.
6910         * aarch64-fbsd-nat.c: Sort headers.
6911         * aarch32-linux-nat.c: Sort headers.
6912
6913 2019-04-04  Tom Tromey  <tom@tromey.com>
6914
6915         * varobj.c (varobj_create): Update.
6916         * rust-exp.y (struct rust_parser) <update_innermost_block,
6917         lookup_symbol>: New methods.
6918         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6919         Rename.
6920         (rust_parser::rust_lookup_type)
6921         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6922         * printcmd.c (display_command, do_one_display): Update.
6923         * parser-defs.h (struct parser_state) <parser_state>: Add
6924         "tracker" parameter.
6925         (block_tracker): New member.
6926         (class innermost_block_tracker) <innermost_block_tracker>: Add
6927         "types" parameter.
6928         <reset>: Remove method.
6929         (innermost_block): Don't declare.
6930         (null_post_parser): Update.
6931         * parse.c (innermost_block): Remove global.
6932         (write_dollar_variable): Update.
6933         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6934         Remove "tracker_types" parameter.
6935         (parse_expression): Add "tracker" parameter.
6936         (parse_expression_for_completion): Update.
6937         (null_post_parser): Add "tracker" parameter.
6938         * p-exp.y: Update rules.
6939         * m2-exp.y: Update rules.
6940         * language.h (struct language_defn) <la_post_parser>: Add
6941         "tracker" parameter.
6942         * go-exp.y: Update rules.
6943         * f-exp.y: Update rules.
6944         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6945         parameter.
6946         * d-exp.y: Update rules.
6947         * c-exp.y: Update rules.
6948         * breakpoint.c (set_breakpoint_condition): Create an
6949         innermost_block_tracker.
6950         (watch_command_1): Likewise.
6951         * ada-lang.c (resolve): Add "tracker" parameter.
6952         (resolve_subexp): Likewise.
6953         * ada-exp.y (write_var_from_sym): Update.
6954
6955 2019-04-04  Tom Tromey  <tom@tromey.com>
6956
6957         * type-stack.h: New file.
6958         * type-stack.c: New file.
6959         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6960         type-stack.h.
6961         (insert_into_type_stack, insert_type, push_type, push_type_int)
6962         (insert_type_address_space, pop_type, pop_type_int)
6963         (pop_typelist, pop_type_stack, append_type_stack)
6964         (push_type_stack, get_type_stack, push_typelist)
6965         (follow_type_instance_flags, follow_types): Don't declare.
6966         * parse.c (type_stack): Remove global.
6967         (parse_exp_in_context): Update.
6968         (insert_into_type_stack, insert_type, push_type, push_type_int)
6969         (insert_type_address_space, pop_type, pop_type_int)
6970         (pop_typelist, pop_type_stack, append_type_stack)
6971         (push_type_stack, get_type_stack, push_typelist)
6972         (follow_type_instance_flags, follow_types): Remove (moved to
6973         type-stack.c).
6974         * f-exp.y (type_stack): New global.
6975         Update rules.
6976         (push_kind_type, f_parse): Update.
6977         * d-exp.y (type_stack): New global.
6978         Update rules.
6979         (d_parse): Update.
6980         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6981         Update rules.
6982         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6983         (HFILES_NO_SRCDIR): Add type-stack.h.
6984
6985 2019-04-04  Tom Tromey  <tom@tromey.com>
6986
6987         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6988         (rust_parser::convert_ast_to_expression, rust_parse)
6989         (rust_lex_test_completion, rust_lex_tests): Update.
6990         * parser-defs.h (struct expr_completion_state): New.
6991         (struct parser_state) <parser_state>: Add completion parameter.
6992         <mark_struct_expression, mark_completion_tag>: New methods.
6993         <parse_completion, m_completion_state>: New members.
6994         (prefixify_expression, null_post_parser): Update.
6995         (mark_struct_expression, mark_completion_tag): Don't declare.
6996         * parse.c (parse_completion, expout_last_struct)
6997         (expout_tag_completion_type, expout_completion_name): Remove
6998         globals.
6999         (parser_state::mark_struct_expression)
7000         (parser_state::mark_completion_tag): Now methods.
7001         (prefixify_expression): Add last_struct parameter.
7002         (prefixify_subexp): Likewise.
7003         (parse_exp_1): Update.
7004         (parse_exp_in_context): Add cstate parameter.  Update.
7005         (parse_expression_for_completion): Create an
7006         expr_completion_state.
7007         (null_post_parser): Add "completion" parameter.
7008         * p-exp.y: Update rules.
7009         (yylex): Update.
7010         * language.h (struct language_defn) <la_post_parser>: Add
7011         "completing" parameter.
7012         * go-exp.y: Update rules.
7013         (lex_one_token): Update.
7014         * expression.h (parse_completion): Don't declare.
7015         * d-exp.y: Update rules.
7016         (lex_one_token): Update rules.
7017         * c-exp.y: Update rules.
7018         (lex_one_token): Update.
7019         * ada-lang.c (resolve): Add "parse_completion" parameter.
7020         (resolve_subexp): Likewise.
7021         (ada_resolve_function): Likewise.
7022
7023 2019-04-04  Tom Tromey  <tom@tromey.com>
7024
7025         * parser-defs.h (struct parser_state) <start_arglist,
7026         end_arglist>: New methods.
7027         <arglist_len, m_funcall_chain>: New members.
7028         (arglist_len, start_arglist, end_arglist): Don't declare.
7029         * parse.c (arglist_len, funcall_chain): Remove global.
7030         (start_arglist, end_arglist): Remove functions.
7031         (parse_exp_in_context): Update.
7032         * p-exp.y: Update rules.
7033         * m2-exp.y: Update rules.
7034         * go-exp.y: Update rules.
7035         * f-exp.y: Update rules.
7036         * d-exp.y: Update rules.
7037         * c-exp.y: Update rules.
7038
7039 2019-04-04  Tom Tromey  <tom@tromey.com>
7040
7041         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7042         lex_operator, push_back>: New methods.
7043         Update all rules.
7044         (rust_parser::lex_hex, lex_escape): Rename and update.
7045         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7046         (rust_parser::lex_operator): Rename and update.
7047         (rust_parser::lex_number, rustyylex, rustyyerror)
7048         (rust_lex_test_init, rust_lex_test_sequence)
7049         (rust_lex_test_push_back, rust_lex_tests): Update.
7050         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7051         parameter.
7052         <lexptr, prev_lexptr>: New members.
7053         (lexptr, prev_lexptr): Don't declare.
7054         * parse.c (lexptr, prev_lexptr): Remove globals.
7055         (parse_exp_in_context): Update.
7056         * p-exp.y (yylex, yyerror): Update.
7057         * m2-exp.y (parse_number, yylex, yyerror): Update.
7058         * go-exp.y (lex_one_token, yyerror): Update.
7059         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7060         * d-exp.y (lex_one_token, yyerror): Update.
7061         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7062         (lex_one_token, yyerror): Update.
7063         * ada-lex.l (YY_INPUT): Update.
7064         (rewind_to_char): Update.
7065         * ada-exp.y (yyerror): Update.
7066
7067 2019-04-04  Tom Tromey  <tom@tromey.com>
7068
7069         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7070         * parser-defs.h (struct parser_state) <parser_state>: Add new
7071         parameter.
7072         <comma_terminates>: New member.
7073         (comma_terminates): Don't declare global.
7074         * parse.c (comma_terminates): Remove global.
7075         (parse_exp_in_context): Update.
7076         * p-exp.y (yylex): Update.
7077         * m2-exp.y (yylex): Update.
7078         * go-exp.y (lex_one_token): Update.
7079         * f-exp.y (yylex): Update.
7080         * d-exp.y (lex_one_token): Update.
7081         * c-exp.y (lex_one_token): Update.
7082         * ada-lex.l: Update.
7083
7084 2019-04-04  Tom Tromey  <tom@tromey.com>
7085
7086         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7087         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7088         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7089         * parser-defs.h (paren_depth): Don't declare.
7090         * parse.c (paren_depth): Remove global.
7091         (parse_exp_in_context): Update.
7092         * p-exp.y (paren_depth): New global.
7093         (pascal_parse): Initialize it.
7094         * m2-exp.y (paren_depth): New global.
7095         (m2_parse): Initialize it.
7096         * go-exp.y (paren_depth): New global.
7097         (go_parse): Initialize it.
7098         * f-exp.y (paren_depth): New global.
7099         (f_parse): Initialize it.
7100         * d-exp.y (paren_depth): New global.
7101         (d_parse): Initialize it.
7102         * c-exp.y (paren_depth): New global.
7103         (c_parse): Initialize it.
7104         * ada-lex.l (paren_depth): New global.
7105         (lexer_init): Initialize it.
7106
7107 2019-04-04  Tom Tromey  <tom@tromey.com>
7108
7109         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7110         (rust_parser::convert_ast_to_type)
7111         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7112         * parser-defs.h (struct parser_state) <parser_state>: Add
7113         parameters.  Initialize new members.
7114         <expression_context_block, expression_context_pc>: New members.
7115         * parse.c (expression_context_block, expression_context_pc):
7116         Remove globals.
7117         (parse_exp_in_context): Update.
7118         * p-exp.y: Update all rules.
7119         (yylex): Update.
7120         * m2-exp.y: Update all rules.
7121         (yylex): Update.
7122         * go-exp.y (yylex): Update.
7123         * f-exp.y (yylex): Update.
7124         * d-exp.y: Update all rules.
7125         (yylex): Update.
7126         * c-exp.y: Update all rules.
7127         (lex_one_token, classify_name, yylex, c_parse): Update.
7128         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7129
7130 2019-04-04  Tom Tromey  <tom@tromey.com>
7131
7132         * gdbarch.h, gdbarch.c: Rebuild.
7133         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7134         * stap-probe.h:
7135         (struct stap_parse_info): Replace "parser_state" with
7136         "expr_builder".
7137         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7138         (parser_state): New class.
7139         * parse.c (expr_builder): Rename.
7140         (expr_builder::release): Rename.
7141         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7142         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7143         (write_exp_elt_longcst, write_exp_elt_floatcst)
7144         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7145         (write_exp_string_vector, write_exp_bitstring)
7146         (write_exp_msymbol, mark_struct_expression)
7147         (write_dollar_variable)
7148         (insert_type_address_space, increase_expout_size): Replace
7149         "parser_state" with "expr_builder".
7150         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7151         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7152         "parser_state" with "expr_builder".
7153
7154 2019-04-04  Tom Tromey  <tom@tromey.com>
7155
7156         * rust-exp.y: Replace "parse_language" with method call.
7157         * p-exp.y:
7158         (yylex): Replace "parse_language" with method call.
7159         * m2-exp.y:
7160         (yylex): Replace "parse_language" with method call.
7161         * go-exp.y (classify_name): Replace "parse_language" with method
7162         call.
7163         * f-exp.y (yylex): Replace "parse_language" with method call.
7164         * d-exp.y (lex_one_token): Replace "parse_language" with method
7165         call.
7166         * c-exp.y:
7167         (lex_one_token, classify_name, yylex): Replace "parse_language"
7168         with method call.
7169         * ada-exp.y (find_primitive_type, type_char)
7170         (type_system_address): Replace "parse_language" with method call.
7171
7172 2019-04-04  Tom Tromey  <tom@tromey.com>
7173
7174         * rust-exp.y: Replace "parse_gdbarch" with method call.
7175         * parse.c (write_dollar_variable, insert_type_address_space):
7176         Replace "parse_gdbarch" with method call.
7177         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7178         call.
7179         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7180         call.
7181         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7182         "parse_gdbarch" with method call.
7183         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7184         with method call.
7185         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7186         "parse_gdbarch" with method call.
7187         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7188         "parse_gdbarch" with method call.
7189         * c-exp.y (parse_type, parse_number, classify_name): Replace
7190         "parse_gdbarch" with method call.
7191         * ada-lex.l: Replace "parse_gdbarch" with method call.
7192         * ada-exp.y (parse_type, find_primitive_type, type_char)
7193         (type_system_address): Replace "parse_gdbarch" with method call.
7194
7195 2019-04-04  Tom Tromey  <tom@tromey.com>
7196
7197         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7198         * stap-probe.c (stap_parse_argument): Update.
7199         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7200         initial_size parameter.
7201         * rust-exp.y (rust_lex_tests): Update.
7202         * parse.c (parser_state): Update.
7203         (parse_exp_in_context): Update.
7204         * parser-defs.h (struct parser_state) <parser_state>: Remove
7205         "initial_size" parameter.
7206
7207 2019-04-04  Tom Tromey  <tom@tromey.com>
7208
7209         * parser-defs.h (increase_expout_size): Don't declare.
7210         * parse.c (increase_expout_size): Now static.
7211
7212 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7213
7214         * gnu-nat.c (gnu_nat_target::wait): Fix
7215         target_waitstatus_to_string call.
7216
7217 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7218
7219         * eval.c (evaluate_subexp_standard): Handle internal functions
7220         during Fortran function call handling.
7221
7222 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7223
7224         * NEWS: Mention new internal functions.
7225         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7226         (read_base_type): Use dwarf2_init_complex_target_type.
7227         * value.c (creal_internal_fn): New function.
7228         (cimag_internal_fn): New function.
7229         (_initialize_values): Register new internal functions.
7230
7231 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7232
7233         * infrun.c (stop_all_threads): If debug_infrun, always
7234         trace the wait status after wait_one, using
7235         target_waitstatus_to_string and target_pid_to_str.
7236         (handle_inferior_event): Replace various trace of
7237         wait status kind by a single trace.
7238         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7239         wait status kind image by target_waitstatus_to_string.
7240         * target/waitstatus.c (target_waitstatus_to_string): Fix
7241         obsolete comment.
7242
7243 2019-04-01  Tom Tromey  <tromey@adacore.com>
7244
7245         PR symtab/23331:
7246         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7247
7248 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7249             Pedro Alves  <palves@redhat.com>
7250
7251         * top.c (quit_force): Call 'finalize_values'.
7252         * value.c (finalize_values): New function.
7253         * value.h (finalize_values): Declare.
7254
7255 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7256
7257         * NEWS: Announce $_gdb_major and $_gdb_minor.
7258
7259         * top.c (init_gdb_version_vars): New function.
7260         (gdb_init): Call init_gdb_version_vars.
7261
7262 2019-03-29  Tom Tromey  <tromey@adacore.com>
7263
7264         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7265         help text.  Remove dead code.
7266
7267 2019-03-29  Keith Seitz  <keiths@redhat.com>
7268
7269         From Siddhesh Poyarekar:
7270         * f-lang.h (f77_get_upperbound): Return LONGEST.
7271         (f77_get_lowerbound): Likewise.
7272         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7273         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7274         print them.
7275         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7276         plongest to format print it.
7277         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7278         (f77_get_upperbound): Likewise.
7279         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7280         LOWER_BOUND to LONGEST.
7281         (f77_create_arrayprint_offset_tbl): Likewise.
7282
7283 2019-03-29  Keith Seitz  <keiths@redhat.com>
7284
7285         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7286         %s/pulongest for TYPE_LENGTH instead of %d in format
7287         strings.
7288         * ada-typerint.c (ada_print_type): Likewise.
7289         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7290         * compile/compile-c-support.c (generate_register_struct): Likewise.
7291         * gdbtypes.c (recursive_dump_type): Likewise.
7292         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7293         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7294         instead of %d in format strings.
7295         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7296         to std::min to ULONGEST.
7297         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7298         instead of %d in format strings.
7299         * tracepoint.c (info_scope_command): Likewise.
7300         * typeprint.c (print_offset_data::update)
7301         (print_offset_data::finish): Likewise.
7302         * xtensa-tdep.c (xtensa_store_return_value)
7303         (xtensa_push_dummy_call): Likewise.
7304
7305 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7306
7307         * windows-nat.c (display_selector): Fixed format specifications
7308         for 64-bit Cygwin.
7309
7310 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7311
7312         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7313
7314 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7315
7316         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7317         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7318         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7319         (nios2_linux_init_abi): Install it.
7320
7321 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7322
7323         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7324
7325 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7326
7327         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7328
7329 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7330             Tom Tromey  <tromey@adacore.com>
7331
7332         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7333
7334 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7335
7336         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7337         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7338         method to compute the bounds of range types. Also print "[evaluated]"
7339         if the bounds' values come from a dynamic evaluation.
7340
7341 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7342
7343         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7344         whitespace when pretty printing is on.
7345
7346 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7347
7348         * ppc-linux-nat.c: Add include.
7349
7350 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7351
7352         * NEWS: Mention AArch64 Pointer Authentication.
7353
7354 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7355
7356         * arm-linux-nat.c: Add include.
7357
7358 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7359
7360         * source-cache.c (source_cache::get_source_lines): Re-read
7361         fullname after calling open_source_file.
7362
7363 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7364
7365         * NEWS: Mention TLS support for FreeBSD.
7366
7367 2019-03-25  Tom Tromey  <tromey@adacore.com>
7368
7369         * minsyms.c (BUNCH_SIZE): Update comment.
7370         (~minimal_symbol_reader): Remove old comment.
7371         (compact_minimal_symbols): Update comment.
7372         (minimal_symbol_reader::install): Remove old comment.  Update
7373         other comments.
7374
7375 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7376
7377         * s390-linux-nat.c: Add include.
7378
7379 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7380
7381         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7382         Call linux_get_hwcap.
7383         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7384         Likewise.
7385         (aarch64_linux_get_hwcap): Remove function.
7386         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7387         declaration.
7388         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7389         linux_get_hwcap.
7390         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7391         * linux-tdep.c (linux_get_hwcap): Add function.
7392         (linux_get_hwcap2): Likewise.
7393         * linux-tdep.h (linux_get_hwcap): Add declaration.
7394         (linux_get_hwcap2): Likewise.
7395         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7396         (ppc_linux_get_hwcap2): Likewise.
7397         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7398         linux_get_hwcap.
7399         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7400         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7401         (ppc_linux_nat_target::read_description): Likewise.
7402         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7403         * s390-linux-nat.c: Likewise.
7404         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7405
7406 2019-03-24  Tom Tromey  <tom@tromey.com>
7407
7408         * ada-lang.c (standard_lookup): Simplify initialization.
7409         (ada_lookup_symbol_nonlocal): Simplify return.
7410         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7411         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7412         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7413         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7414         initialization.
7415         * solib.c (solib_global_lookup): Simplify.
7416         * symtab.c (null_block_symbol): Remove.
7417         (symbol_cache_lookup): Simplify returns.
7418         (lookup_language_this): Simplify returns.
7419         (lookup_symbol_aux): Simplify return.
7420         (lookup_local_symbol): Simplify returns.
7421         (lookup_global_symbol_from_objfile): Simplify return.
7422         (lookup_symbol_in_objfile_symtabs)
7423         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7424         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7425         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7426         * cp-namespace.c (cp_lookup_bare_symbol)
7427         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7428         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7429         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7430         (cp_lookup_symbol_via_imports): Simplify initialization.
7431         (find_symbol_in_baseclass): Likewise.
7432         * symtab.h (null_block_symbol): Remove.
7433         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7434         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7435         (d_lookup_symbol_module): Likewise.
7436         (find_symbol_in_baseclass): Simplify initialization.
7437
7438 2019-03-24  Tom Tromey  <tom@tromey.com>
7439
7440         * expression.h: Don't include symtab.h.
7441         (struct block): Forward declare.
7442
7443 2019-03-24  Tom Tromey  <tom@tromey.com>
7444
7445         * c-exp.y (typebase): Remove casts.
7446         * gdbtypes.c (lookup_unsigned_typename, )
7447         (lookup_signed_typename): Remove cast.
7448         * eval.c (parse_to_comma_and_eval): Remove cast.
7449         * parse.c (write_dollar_variable): Remove cast.
7450         * block.h (struct block) <superblock>: Now const.
7451         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7452         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7453         (map_block): Make "block" const.
7454         * symfile.h (struct quick_symbol_functions)
7455         <map_matching_symbols>: Constify block argument to "callback".
7456         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7457         const.
7458         (find_pc_sect_compunit_symtab): Make "b" const.
7459         (find_symbol_at_address): Likewise.
7460         (search_symbols): Likewise.
7461         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7462         (dw2_debug_names_lookup_symbol): Likewise.
7463         (dw2_map_matching_symbols): Update.
7464         * p-valprint.c (pascal_val_print): Remove "block".
7465         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7466         (aux_add_nonlocal_symbols): Make "block" const.
7467         (resolve_subexp): Remove cast.
7468         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7469         const.
7470         (iterate_over_file_blocks): Likewise.
7471         * f-exp.y (%union) <bval>: Remove.
7472         * coffread.c (patch_opaque_types): Make "b" const.
7473         * spu-tdep.c (spu_catch_start): Make "block" const.
7474         * c-valprint.c (print_unpacked_pointer): Remove "block".
7475         * symmisc.c (dump_symtab_1): Make "b" const.
7476         (block_depth): Make "block" const.
7477         * d-exp.y (%union) <bval>: Remove.
7478         * cp-support.h (cp_lookup_rtti_type): Update.
7479         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7480         * psymtab.c (psym_lookup_symbol): Make "block" const.
7481         (maintenance_check_psymtabs): Make "b" const.
7482         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7483         (enumerate_locals, enumerate_args): Update.
7484         * python/py-symtab.c (stpy_global_block): Make "block" const.
7485         (stpy_static_block): Likewise.
7486         * inline-frame.c (block_starting_point_at): Make "new_block"
7487         const.
7488         * block.c (find_block_in_blockvector): Make return type const.
7489         (blockvector_for_pc_sect): Make "b" const.
7490         (find_block_in_blockvector): Make "b" const.
7491
7492 2019-03-23  Tom Tromey  <tom@tromey.com>
7493
7494         * varobj.c (varobj_create): Update.
7495         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7496         * printcmd.c (display_command, do_one_display): Don't reset
7497         innermost_block.
7498         * parser-defs.h (enum innermost_block_tracker_type): Move to
7499         expression.h.
7500         (innermost_block): Update comment.
7501         * parse.c (parse_exp_1): Add tracker_types parameter.
7502         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7503         tracker_types parameter.  Reset innermost_block.
7504         (parse_exp_in_context): Remove.
7505         (parse_expression_for_completion): Update.
7506         * objfiles.c (~objfile): Don't reset expression_context_block or
7507         innermost_block.
7508         * expression.h (enum innermost_block_tracker_type): Move from
7509         parser-defs.h.
7510         (parse_exp_1): Add tracker_types parameter.
7511         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7512         reset innermost_block.
7513
7514 2019-03-23  Tom Tromey  <tom@tromey.com>
7515
7516         * objfiles.h: Include bcache.h.
7517
7518 2019-03-23  Tom Tromey  <tom@tromey.com>
7519
7520         * linespec.c (get_current_search_block): Use
7521         scoped_restore_current_language.
7522         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7523
7524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7525             Jiong Wang  <jiong.wang@arm.com>
7526
7527         * aarch64-linux-tdep.c
7528         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7529         section.
7530         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7531
7532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7533             Jiong Wang  <jiong.wang@arm.com>
7534
7535         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7536         instructions.
7537         (aarch64_analyze_prologue_test): Add PACIASP test.
7538         (aarch64_prologue_prev_register): Unmask PC value.
7539
7540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7541             Jiong Wang  <jiong.wang@arm.com>
7542
7543         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7544         (aarch64_dwarf2_prev_register): Unmask PC value.
7545         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7546         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7547         DW_CFA_AARCH64_negate_ra_state.
7548         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7549
7550 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7551             Jiong Wang  <jiong.wang@arm.com>
7552
7553         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7554         registers.
7555         (aarch64_pseudo_register_name): Likewise.
7556         (aarch64_pseudo_register_type): Likewise.
7557         (aarch64_pseudo_register_reggroup_p): Likewise.
7558         (aarch64_gdbarch_init): Add pauth registers.
7559         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7560         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7561         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7562         (struct gdbarch_tdep): Add regnum for ra_state.
7563
7564 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7565             Jiong Wang  <jiong.wang@arm.com>
7566
7567         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7568
7569 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7570             Jiong Wang  <jiong.wang@arm.com>
7571
7572         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7573         function.
7574         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7575         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7576         (aarch64_gdbarch_init): Add puth registers.
7577         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7578         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7579         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7580
7581 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7582             Jiong Wang  <jiong.wang@arm.com>
7583
7584         * aarch64-linux-nat.c
7585         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7586         * aarch64-linux-tdep.c
7587         (aarch64_linux_core_read_description): Likewise.
7588         (aarch64_linux_get_hwcap): New function.
7589         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7590         (aarch64_linux_get_hwcap): New declaration.
7591
7592 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7593             Jiong Wang  <jiong.wang@arm.com>
7594
7595         * aarch64-linux-nat.c
7596         (aarch64_linux_nat_target::read_description): Add pauth param.
7597         * aarch64-linux-tdep.c
7598         (aarch64_linux_core_read_description): Likewise.
7599         * aarch64-tdep.c (struct target_desc): Add in pauth.
7600         (aarch64_read_description): Add pauth param.
7601         (aarch64_gdbarch_init): Likewise.
7602         * aarch64-tdep.h (aarch64_read_description): Likewise.
7603         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7604         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7605         * features/Makefile: Add new files.
7606         * features/aarch64-pauth.c: New file.
7607         * features/aarch64-pauth.xml: New file.
7608
7609 2019-03-20  Tom Tromey  <tromey@adacore.com>
7610
7611         * infrun.c (handle_inferior_event): Rename from
7612         handle_inferior_event_1.  Create a scoped_value_mark.
7613         (handle_inferior_event): Remove.
7614
7615 2019-03-19  Tom Tromey  <tromey@adacore.com>
7616
7617         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7618         * infrun.h (print_stop_event): Add "displays" parameter.
7619         * infrun.c (print_stop_event): Add "displays" parameter.
7620
7621 2019-03-19  Pedro Alves  <palves@redhat.com>
7622
7623         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7624         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7625         to -1.  Fix TABs vs spaces.
7626         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7627         * tui/tui-out.h (tui_ui_out) Add intro comments.
7628         <m_line, m_start_of_line>: In-class initialize, and add describing
7629         comment.
7630
7631 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7632
7633         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7634         variable names.
7635         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7636
7637 2019-03-18  Pedro Alves  <palves@redhat.com>
7638             Eli Zaretskii <eliz@gnu.org>
7639
7640         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7641         m_line and m_start_of_line.
7642
7643 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7644
7645         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7646         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7647         it returns a newline.  This fixes a regression in TU mode, whereby
7648         the next line is output on the same screen line as the user input.
7649
7650 2019-03-18  Tom Tromey  <tromey@adacore.com>
7651
7652         * minsyms.c (minimal_symbol_reader::install): Remove call to
7653         obstack_blank.
7654
7655 2019-03-18  Pedro Alves  <palves@redhat.com>
7656
7657         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7658         New globals.
7659         (apply_style): New, factored out from ...
7660         (apply_ansi_escape): ... this.  Handle reverse video mode.
7661         (tui_set_reverse_mode): New function.
7662         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7663         * tui/tui-winsource.c (tui_show_source_line): Use
7664         tui_set_reverse_mode instead of setting A_STANDOUT.
7665         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7666         New setter methods.
7667
7668 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7669
7670         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7671         Handle tabs.
7672
7673 2019-03-18  Tom Tromey  <tromey@adacore.com>
7674
7675         * ada-lang.c (empty_array): Add "high" parameter.
7676         (ada_evaluate_subexp): Update.
7677
7678 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7679
7680         * unittests/string_view-selftests.c: Define
7681         _initialize_string_view_selftests unconditionally.
7682
7683 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7684
7685         PR gdb/24350
7686         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7687
7688 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7689
7690         PR gdb/24351
7691         * windows-nat.c (display_selector): Fix format specifiers.
7692
7693 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7694
7695         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7696         tui_refill_source_window instead of tui_refresh_win, to update the
7697         current execution line.  This fixes redisplay of the current line
7698         when stepping through the code with "next" or "step".
7699
7700 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7701
7702         * source-cache.c (source_cache::get_source_lines): Call
7703         find_source_lines to initialize s->nlines.  This fixes vertical
7704         scrolling of TUI source window when the DOWN arrow is pressed.
7705
7706 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7707
7708         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7709         linux-thread-db.c (_initialize_thread_db): Likewise.
7710
7711 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7712
7713         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7714         wclrtoeol in tui_show_source_line".  This reverts changes made in
7715         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7716
7717 2019-03-15  Tom Tromey  <tom@tromey.com>
7718
7719         * symtab.h (struct minimal_symbol): Derive from
7720         general_symbol_info.
7721         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7722         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7723         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7724         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7725         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7726         (MSYMBOL_SEARCH_NAME): Update.
7727         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7728         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7729         * minsyms.c (minimal_symbol_reader::record_full): Update.
7730
7731 2019-03-15  Tom Tromey  <tom@tromey.com>
7732
7733         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7734
7735 2019-03-15  Tom Tromey  <tom@tromey.com>
7736
7737         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7738         unique_xmalloc_ptr.
7739         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7740         Update.
7741         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7742         (build_minimal_symbol_hash_tables)
7743         (minimal_symbol_reader::install): Update.
7744
7745 2019-03-15  Tom Tromey  <tom@tromey.com>
7746
7747         * symtab.c (create_demangled_names_hash): Update.
7748         (symbol_set_names): Update.
7749         * objfiles.h (struct objfile_per_bfd_storage)
7750         <demangled_names_hash>: Now an htab_up.
7751         * objfiles.c (objfile_per_bfd_storage): Simplify.
7752
7753 2019-03-15  Tom Tromey  <tom@tromey.com>
7754
7755         * objfiles.h (struct objfile_per_bfd_storage): Declare
7756         destructor.
7757         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7758         New.
7759         (get_objfile_bfd_data): Use new.  Don't initialize
7760         language_of_main.
7761         (free_objfile_per_bfd_storage): Remove.
7762         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7763
7764 2019-03-15  Tom Tromey  <tom@tromey.com>
7765
7766         * symfile.c (reread_symbols): Update.
7767         * objfiles.c (objfile::objfile): Update.
7768         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7769         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7770         comment.
7771         (minimal_symbol_reader::install): Update.
7772         (terminate_minimal_symbol_table): Remove.
7773         * jit.c (jit_object_close_impl): Update.
7774
7775 2019-03-15  Tom Tromey  <tom@tromey.com>
7776
7777         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7778         initializations.
7779
7780 2019-03-15  Tom Tromey  <tom@tromey.com>
7781
7782         * objfiles.h (struct objfile_per_bfd_storage)
7783         <demangled_hash_languages>: Now a bitset.
7784         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7785         (lookup_minimal_symbol): Update.
7786
7787 2019-03-15  Tom Tromey  <tom@tromey.com>
7788
7789         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7790         Don't return the symbol.
7791         * coffread.c (record_minimal_symbol): Use record_full.
7792
7793 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7794
7795         The MS-Windows port of ncurses fails to switch to a color pair if
7796         one or both of the colors are the implicit default colors.  This
7797         change records the default colors when TUI is initialized, and
7798         then specifies them explicitly when a color pair uses the default
7799         colors.  This allows color styling in TUI mode on MS-Windows.
7800
7801         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7802         ncurses_norm_attr.
7803         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7804         colors in ncurses_norm_attr.
7805         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7806         "none", replace it with the default color recorded in
7807         ncurses_norm_attr.
7808
7809 2019-03-14  Tom Tromey  <tromey@adacore.com>
7810
7811         * source-cache.h (class source_cache) <get_source_lines>: Return
7812         std::string.
7813         * source-cache.c (source_cache::extract_lines): Handle case where
7814         first_pos==npos.  Return std::string.
7815         (source_cache::get_source_lines): Update.
7816
7817 2019-03-14  Tom Tromey  <tromey@adacore.com>
7818
7819         * NEWS: Add item for "style sources" commands.
7820         * source-cache.c (source_cache::get_source_lines): Check
7821         source_styling.
7822         * cli/cli-style.c (source_styling): New global.
7823         (_initialize_cli_style): Add "style sources" commands.
7824         (show_style_sources): New function.
7825         * cli/cli-style.h (source_styling): Declare.
7826
7827 2019-03-14  Pedro Alves  <palves@redhat.com>
7828             Tom Tromey  <tromey@adacore.com>
7829
7830         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7831         * tui/tui-winsource.c (tui_refill_source_window): New function,
7832         from...
7833         (tui_horizontal_source_scroll): ... here.  Move some logic.
7834         * cli/cli-style.c (set_style_enabled): Notify new observable.
7835         * tui/tui-hooks.c (tui_redisplay_source): New function.
7836         (tui_attach_detach_observers): Attach or detach
7837         tui_redisplay_source.
7838         * observable.h (source_styling_changed): New observable.
7839         * observable.c: Define source_styling_changed observable.
7840
7841 2019-03-13  Tom Tromey  <tromey@adacore.com>
7842
7843         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7844         (i386_gnu_nat_target::store_registers): Update.
7845         * target-debug.h (target_debug_print_std_string): New macro.
7846         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7847         * windows-tdep.c (display_one_tib): Update.
7848         * tui/tui-stack.c (tui_make_status_line): Update.
7849         * top.c (print_inferior_quit_action): Update.
7850         * thread.c (thr_try_catch_cmd): Update.
7851         (add_thread_with_info): Update.
7852         (thread_target_id_str): Update.
7853         (thr_try_catch_cmd): Update.
7854         (thread_command): Update.
7855         (thread_find_command): Update.
7856         * record-btrace.c (record_btrace_target::info_record)
7857         (record_btrace_resume_thread, record_btrace_target::resume)
7858         (record_btrace_cancel_resume, record_btrace_step_thread)
7859         (record_btrace_target::wait, record_btrace_target::wait)
7860         (record_btrace_target::wait, record_btrace_target::stop): Update.
7861         * progspace.c (print_program_space): Update.
7862         * process-stratum-target.c
7863         (process_stratum_target::thread_address_space): Update.
7864         * linux-fork.c (linux_fork_mourn_inferior)
7865         (detach_checkpoint_command, info_checkpoints_command)
7866         (linux_fork_context): Update.
7867         (linux_fork_detach): Update.
7868         (class scoped_switch_fork_info): Update.
7869         (delete_checkpoint_command): Update.
7870         * infrun.c (follow_fork_inferior): Update.
7871         (follow_fork_inferior): Update.
7872         (proceed_after_vfork_done): Update.
7873         (handle_vfork_child_exec_or_exit): Update.
7874         (follow_exec): Update.
7875         (displaced_step_prepare_throw): Update.
7876         (displaced_step_restore): Update.
7877         (start_step_over): Update.
7878         (resume_1): Update.
7879         (clear_proceed_status_thread): Update.
7880         (proceed): Update.
7881         (print_target_wait_results): Update.
7882         (do_target_wait): Update.
7883         (context_switch): Update.
7884         (stop_all_threads): Update.
7885         (restart_threads): Update.
7886         (finish_step_over): Update.
7887         (handle_signal_stop): Update.
7888         (switch_back_to_stepped_thread): Update.
7889         (keep_going_pass_signal): Update.
7890         (print_exited_reason): Update.
7891         (normal_stop): Update.
7892         * inferior.c (inferior_pid_to_str): Change return type.
7893         (print_selected_inferior): Update.
7894         (add_inferior): Update.
7895         (detach_inferior): Update.
7896         * dummy-frame.c (fprint_dummy_frames): Update.
7897         * dcache.c (dcache_info_1): Update.
7898         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7899         (btrace_fetch, btrace_clear): Update.
7900         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7901         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7902         type.
7903         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7904         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7905         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7906         * gdbarch.c, gdbarch.h: Rebuild.
7907         * gdbarch.sh (core_pid_to_str): Change return type.
7908         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7909         return type.
7910         (windows_nat_target::pid_to_str): Change return type.
7911         (windows_delete_thread): Update.
7912         (windows_nat_target::attach): Update.
7913         (windows_nat_target::files_info): Update.
7914         * target-delegates.c: Rebuild.
7915         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7916         return type.
7917         (sol_thread_target::pid_to_str): Change return type.
7918         * remote.c (class remote_target) <pid_to_str>: Change return
7919         type.
7920         (remote_target::pid_to_str): Change return type.
7921         (extended_remote_target::attach, remote_target::remote_stop_ns)
7922         (remote_target::remote_notif_remove_queued_reply)
7923         (remote_target::push_stop_reply, remote_target::disable_btrace):
7924         Update.
7925         (extended_remote_target::attach): Update.
7926         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7927         type.
7928         (gdbsim_target::pid_to_str): Change return type.
7929         * ravenscar-thread.c (struct ravenscar_thread_target)
7930         <pid_to_str>: Change return type.
7931         (ravenscar_thread_target::pid_to_str): Change return type.
7932         * procfs.c (class procfs_target) <pid_to_str>: Change return
7933         type.
7934         (procfs_target::pid_to_str): Change return type.
7935         (procfs_target::attach): Update.
7936         (procfs_target::detach): Update.
7937         (procfs_target::fetch_registers): Update.
7938         (procfs_target::store_registers): Update.
7939         (procfs_target::wait): Update.
7940         (procfs_target::files_info): Update.
7941         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7942         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7943         return type.
7944         (nto_procfs_target::pid_to_str): Change return type.
7945         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7946         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7947         return type.
7948         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7949         (exit_lwp): Update.
7950         (attach_proc_task_lwp_callback, get_detach_signal)
7951         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7952         (linux_nat_target::resume, wait_lwp, stop_callback)
7953         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7954         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7955         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7956         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7957         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7958         type.
7959         (inf_ptrace_target::attach): Update.
7960         (inf_ptrace_target::files_info): Update.
7961         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7962         type.
7963         (go32_nat_target::pid_to_str): Change return type.
7964         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7965         (gnu_nat_target::wait): Update.
7966         (gnu_nat_target::wait): Update.
7967         (gnu_nat_target::resume): Update.
7968         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7969         (fbsd_nat_target::wait): Update.
7970         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7971         type.
7972         (darwin_nat_target::attach): Update.
7973         * corelow.c (class core_target) <pid_to_str>: Change return type.
7974         (core_target::pid_to_str): Change return type.
7975         * target.c (normal_pid_to_str): Change return type.
7976         (default_pid_to_str): Likewise.
7977         (target_pid_to_str): Change return type.
7978         (target_translate_tls_address): Update.
7979         (target_announce_detach): Update.
7980         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7981         return type.
7982         (bsd_uthread_target::pid_to_str): Change return type.
7983         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7984         type.
7985         (bsd_kvm_target::pid_to_str): Change return type.
7986         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7987         return type.
7988         (aix_thread_target::pid_to_str): Change return type.
7989         * target.h (struct target_ops) <pid_to_str>: Change return type.
7990         (target_pid_to_str, normal_pid_to_str): Likewise.
7991         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7992         type.
7993         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7994         type.
7995         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7996         return type.
7997         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7998         type.
7999         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8000         type.
8001         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8002         return type.
8003
8004 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8005
8006         * NEWS: Mention that the new default MI version is 3.  Mention
8007         changes to the output of commands and events that deal with
8008         multi-location breakpoints.
8009         * breakpoint.c: Include "mi/mi-out.h".
8010         (print_one_breakpoint): Change output syntax if using MI version
8011         >= 3.
8012         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8013         New.
8014         (mi_multi_location_breakpoint_output_fixed): New.
8015         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8016         (mi_cmd_fix_multi_location_breakpoint_output): New.
8017         (mi_multi_location_breakpoint_output_fixed): New.
8018         * mi/mi-cmds.c (mi_cmds): Register command
8019         -fix-multi-location-breakpoint-output.
8020         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8021         interpreter "mi".
8022
8023 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8024
8025         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8026         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8027         instantiate mi_ui_out based on interpreter name.
8028         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8029         * mi/mi-main.c (mi_load_progress): Likewise.
8030
8031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8032
8033         * NEWS: Combine separate "New targets" sections for 8.3.
8034
8035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8036
8037         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8038         (ppcfbsd_init_abi): Install gdbarch
8039         "fetch_tls_load_module_address" and "get_thread_local_address"
8040         methods.
8041
8042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8043
8044         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8045         (riscv_fbsd_init_abi): Install gdbarch
8046         "fetch_tls_load_module_address" and "get_thread_local_address"
8047         methods.
8048
8049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8050
8051         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8052         (i386fbsd_init_abi): Install gdbarch
8053         "fetch_tls_load_module_address" and "get_thread_local_address"
8054         methods.
8055
8056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8057
8058         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8059         (amd64fbsd_init_abi): Install gdbarch
8060         "fetch_tls_load_module_address" and "get_thread_local_address"
8061         methods.
8062
8063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8064
8065         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8066         (struct fbsd_pspace_data): New type.
8067         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8068         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8069         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8070         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8071         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8072
8073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8074
8075         * gdbtypes.c (lookup_struct_elt): New function.
8076         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8077         * gdbtypes.h (struct struct_elt): New type.
8078         (lookup_struct_elt): New prototype.
8079
8080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8081
8082         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8083         remove disabled code block.
8084
8085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8086
8087         * gdbarch.sh (get_thread_local_address): New method.
8088         * gdbarch.h, gdbarch.c: Regenerate.
8089         * target.c (target_translate_tls_address): Use
8090         gdbarch_get_thread_local_address if present instead of
8091         target::get_thread_local_address.
8092
8093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8094
8095         * target.h (target::get_thread_local_address): Update comment.
8096
8097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8098
8099         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8100         objfile->separate_debug_objfile_backlink if not NULL.
8101
8102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8103
8104         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8105         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8106         (amd64bsd_store_inferior_registers): Likewise.
8107         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8108         Enable segment base registers.
8109         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8110         PT_GETFSBASE and PT_GETGSBASE.
8111         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8112         PT_SETGSBASE.
8113         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8114         segment base registers.
8115         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8116
8117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8118
8119         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8120         Update calls to i386_target_description to add 'segments'
8121         parameter.
8122         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8123         add segment base registers.
8124         * arch/i386.c (i386_create_target_description): Add 'segments'
8125         parameter to enable segment base registers.
8126         * arch/i386.h (i386_create_target_description): Likewise.
8127         * features/i386/32bit-segments.xml: New file.
8128         * features/i386/32bit-segments.c: Generate.
8129         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8130         call to i386_target_description to add 'segments' parameter.
8131         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8132         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8133         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8134         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8135         if feature is present.
8136         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8137         Add 'segments' parameter to call to i386_target_description.
8138         (i386_target_description): Add 'segments' parameter to enable
8139         segment base registers.
8140         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8141         to call to i386_target_description.
8142         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8143         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8144         Define I386_NUM_REGS.
8145         (i386_target_description): Add 'segments' parameter to enable
8146         segment base registers.
8147
8148 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8149
8150         PR/24325
8151         * source-cache.c: #undef open and close, to avoid unresolved
8152         externals during linking.
8153
8154 2019-03-12  Tom Tromey  <tromey@adacore.com>
8155
8156         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8157         const.  Add initializers.
8158         (_initialize_remote): Don't initialize ptid globals.
8159
8160 2019-03-12  Pedro Alves  <palves@redhat.com>
8161
8162         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8163
8164 2019-03-12  Pedro Alves  <palves@redhat.com>
8165
8166         * cp-name-parser.y (main): Remove unused 'len' variable.
8167
8168 2019-03-12  Tom Tromey  <tromey@adacore.com>
8169
8170         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8171         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8172
8173 2019-03-12  Tom Tromey  <tromey@adacore.com>
8174
8175         * linux-nat.c (iterate_over_lwps): Update.
8176         (stop_callback): Remove parameter.
8177         (stop_wait_callback, detach_callback, resume_set_callback)
8178         (select_singlestep_lwp_callback, set_ignore_sigint)
8179         (status_callback, resumed_callback, resume_clear_callback)
8180         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8181         data parameter.
8182         (linux_nat_target::detach, linux_nat_target::resume)
8183         (linux_stop_and_wait_all_lwps, select_event_lwp)
8184         (linux_nat_filter_event, linux_nat_wait_1)
8185         (linux_nat_target::kill, linux_nat_target::stop)
8186         (linux_nat_target::stop): Update.
8187         (linux_nat_resume_callback): Change type.
8188         (resume_stopped_resumed_lwps, count_events_callback)
8189         (select_event_lwp_callback): Likewise.
8190         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8191         * arm-linux-nat.c (struct update_registers_data): Remove.
8192         (update_registers_callback): Change type.
8193         (arm_linux_insert_hw_breakpoint1): Update.
8194         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8195         parameter.
8196         (x86_linux_dr_set_addr): Update.
8197         (x86_linux_dr_set_control): Update.
8198         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8199         (iterate_over_lwps): Use gdb::function_view.
8200         * nat/aarch64-linux-hw-point.c (struct
8201         aarch64_dr_update_callback_param): Remove.
8202         (debug_reg_change_callback): Change type.
8203         (aarch64_notify_debug_reg_change): Update.
8204         * s390-linux-nat.c (s390_refresh_per_info): Update.
8205
8206 2019-03-11  Tom Tromey  <tromey@adacore.com>
8207
8208         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8209         redundant assignment to "this_cu".
8210
8211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8212
8213         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8214
8215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8216
8217         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8218         from...
8219         (rank_one_type): ... this.
8220
8221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8222
8223         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8224         from...
8225         (rank_one_type): ... this.
8226
8227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8228
8229         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8230         from...
8231         (rank_one_type): ... this.
8232
8233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8234
8235         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8236         from...
8237         (rank_one_type): ... this.
8238
8239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8240
8241         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8242         from...
8243         (rank_one_type): ... this.
8244
8245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8246
8247         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8248         from...
8249         (rank_one_type): ... this.
8250
8251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8252
8253         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8254         from...
8255         (rank_one_type): ... this.
8256
8257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8258
8259         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8260         from...
8261         (rank_one_type): ... this.
8262
8263 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8264
8265         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8266         from...
8267         (rank_one_type): ... this.
8268
8269 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8270
8271         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8272         from...
8273         (rank_one_type): ... this.
8274
8275 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8276
8277         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8278         from...
8279         (rank_one_type): ... this.
8280
8281 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8282
8283         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8284         from...
8285         (rank_one_type): ... this.
8286
8287 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8288
8289         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8290         inferior-events' shows the example events.
8291
8292 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8293
8294         Support styling on native MS-Windows console
8295
8296         PR/24315
8297         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8298         on MS-Windows if $TERM is not defined.
8299
8300         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8301
8302         * posix-hdep.c (gdb_console_fputs):
8303         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8304         functions.
8305         * ui-file.h (gdb_console_fputs): Add prototype.
8306
8307         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8308         back to fputs only if the former returns zero.
8309
8310 2019-03-07  Tom Tromey  <tom@tromey.com>
8311
8312         * symmisc.c (print_symbol_bcache_statistics): Update.
8313         (print_objfile_statistics): Update.
8314         * symfile.c (allocate_symtab): Update.
8315         * stabsread.c: Don't include bcache.h.
8316         * psymtab.h (struct psymbol_bcache): Don't declare.
8317         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8318         (psymbol_bcache_init, psymbol_bcache_free)
8319         (psymbol_bcache_get_bcache): Don't declare.
8320         * psymtab.c (struct psymbol_bcache): Remove.
8321         (psymtab_storage::psymtab_storage): Update.
8322         (psymtab_storage::~psymtab_storage): Update.
8323         (psymbol_bcache_init, psymbol_bcache_free)
8324         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8325         (add_psymbol_to_bcache): Update.
8326         (allocate_psymtab): Update.
8327         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8328         macro_cache>: No longer pointers.
8329         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8330         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8331         * macrotab.c (macro_bcache): Update.
8332         * macroexp.c: Don't include bcache.h.
8333         * gdbtypes.c (check_types_worklist): Update.
8334         (types_deeply_equal): Remove TRY/CATCH.  Update.
8335         * elfread.c (elf_symtab_read): Update.
8336         * dwarf2read.c: Don't include bcache.h.
8337         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8338         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8339         (print_bcache_statistics, bcache_memory_used): Don't declare.
8340         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8341         methods.  Rename all data members.
8342         * bcache.c (struct bcache): Move to bcache.h.
8343         (bcache::expand_hash_table): Rename from expand_hash_table.
8344         (bcache): Remove.
8345         (bcache::insert): Rename from bcache_full.
8346         (bcache::compare): Rename from bcache_compare.
8347         (bcache_xmalloc): Remove.
8348         (bcache::~bcache): Rename from bcache_xfree.
8349         (bcache::print_statistics): Rename from print_bcache_statistics.
8350         (bcache::memory_used): Rename from bcache_memory_used.
8351
8352 2019-03-07  Pedro Alves  <palves@redhat.com>
8353
8354         * infrun.c (normal_stop): Also check for
8355         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8356
8357 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8358
8359         * f-lang.c (value_from_host_double): Moved to...
8360         * value.c (value_from_host_double): ...here.
8361         * value.h (value_from_host_double): Declare.
8362         * guile/scm-math.c (vlscm_convert_typed_number): Use
8363         value_from_host_double.
8364         (vlscm_convert_number): Likewise.
8365         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8366         * python/py-value.c (convert_value_from_python): Likewise.
8367
8368 2019-03-06  Tom Tromey  <tom@tromey.com>
8369
8370         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8371
8372 2019-03-06  Tom Tromey  <tom@tromey.com>
8373
8374         * utils.h (free_current_contents): Don't declare.
8375         * utils.c (free_current_contents): Remove.
8376
8377 2019-03-06  Tom Tromey  <tom@tromey.com>
8378
8379         * top.c (quit_force): Update.
8380         * main.c (captured_command_loop): Update.
8381         * common/new-op.c (operator new): Update.
8382         * common/common-exceptions.c (struct catcher)
8383         <save_cleanup_chain>: Remove member.
8384         (exceptions_state_mc_init): Update.
8385         (exception_try_scope_entry): Return nullptr.
8386         (exception_try_scope_exit, exception_rethrow)
8387         (throw_exception_sjlj, throw_exception_cxx): Update.
8388         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8389         (all_cleanups, do_cleanups, discard_cleanups)
8390         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8391         (restore_cleanups, restore_final_cleanups): Don't declare.
8392         (do_final_cleanups): Remove parameter.
8393         * common/cleanups.c (cleanup_chain, make_cleanup)
8394         (make_cleanup_dtor, all_cleanups, do_cleanups)
8395         (discard_my_cleanups, discard_cleanups)
8396         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8397         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8398         (null_cleanup): Remove.
8399         (do_final_cleanups): Remove parameter.
8400
8401 2019-03-06  Tom Tromey  <tom@tromey.com>
8402
8403         * remote.c (remote_target::remote_parse_stop_reply): Use
8404         unique_xmalloc_ptr.
8405
8406 2019-03-06  Tom Tromey  <tom@tromey.com>
8407
8408         * stabsread.c (struct stabs_field_info): Rename from field_info.
8409         <list, fnlist>: Add initializers.
8410         <obstack>: New member.
8411         (read_member_functions, read_struct_fields, read_baseclasses):
8412         Allocate on obstack.  Don't use cleanups.
8413         (read_one_struct_field, read_member_functions, read_struct_fields)
8414         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8415         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8416         (read_struct_type): Update.
8417
8418 2019-03-06  Tom Tromey  <tom@tromey.com>
8419
8420         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8421         * common/filestuff.h (make_cleanup_close): Don't declare.
8422         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8423         Remove.
8424
8425 2019-03-06  Tom Tromey  <tom@tromey.com>
8426
8427         * solib-aix.c: Use make_scope_exit.
8428
8429 2019-03-06  Tom Tromey  <tom@tromey.com>
8430
8431         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8432         Use make_scope_exit.
8433
8434 2019-03-06  Tom Tromey  <tom@tromey.com>
8435
8436         * solib-svr4.c (disable_probes_interface): Remove parameter.
8437         (svr4_handle_solib_event): Use make_scope_exit.
8438
8439 2019-03-06  Tom Tromey  <tom@tromey.com>
8440
8441         * remote.c (struct stop_reply_deleter): Remove.
8442         (stop_reply_up): Update.
8443         (struct stop_reply): Derive from notif_event.  Don't typedef.
8444         <regcache>: Now a std::vector.
8445         (stop_reply_xfree): Remove.
8446         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8447         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8448         (remote_target::discard_pending_stop_replies): Use delete.
8449         (remote_target::remote_parse_stop_reply): Update.
8450         (remote_target::process_stop_reply): Update.
8451         * remote-notif.h (struct notif_event): Add virtual destructor.
8452         Remove "dtr" member.
8453         (struct notif_client) <alloc_event>: Return a unique_ptr.
8454         (notif_event_xfree): Don't declare.
8455         (notif_event_up): New typedef.
8456         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8457         (notif_event_xfree, do_notif_event_xfree): Remove.
8458         (remote_notif_state_xfree): Update.
8459
8460 2019-03-06  Tom Tromey  <tom@tromey.com>
8461
8462         * infrun.c (displaced_step_clear_cleanup): Now a
8463         forward_scope_exit type.
8464         (displaced_step_prepare_throw): Update.
8465         (displaced_step_fixup): Update.
8466
8467 2019-03-06  Tom Tromey  <tom@tromey.com>
8468
8469         * inferior.h (class inferior): Update comment.
8470         * gdbthread.h (class thread_info): Update comment.
8471
8472 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8473             Tom Tromey  <tom@tromey.com>
8474
8475         * stabsread.h (struct stab_section_list): Remove.
8476         (coffstab_build_psymtabs): Update.
8477         * dbxread.c (symbuf_sections): Now a std::vector.
8478         (sect_idx): New global.
8479         (fill_symbuf): Update.
8480         (coffstab_build_psymtabs): Change type of stabsects parameter.
8481         Update.
8482         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8483         std::vector.
8484         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8485         (coff_locate_sections): Update.
8486         (coff_symfile_read): Remove cleanups.  Update.
8487         (init_stringtab): Add storage parameter.
8488         (free_stringtab, free_stringtab_cleanup): Remove.
8489         (init_lineno): Add storage parameter.
8490         (free_linetab, free_linetab_cleanup): Remove.
8491
8492 2019-03-06  Pedro Alves  <palves@redhat.com>
8493
8494         * linux-fork.c (fork_info::clobber_regs): Delete.
8495         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8496         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8497         comment.  Adjust.
8498         (scoped_switch_fork_info::scoped_switch_fork_info)
8499         (checkpoint_command, linux_fork_context): Adjust
8500         fork_save_infrun_state calls.
8501
8502 2019-03-06  Pedro Alves  <palves@redhat.com>
8503
8504         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8505         (inf_has_multiple_threads): Return 'bool' and rewrite using
8506         inferior_info::threads().
8507
8508 2019-03-06  Pedro Alves  <palves@redhat.com>
8509
8510         * linux-fork.c: Include <list>.
8511         (fork_list): Now a std::list instance.
8512         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8513         (forks_exist_p, find_last_fork): Adjust.
8514         (new_fork): Delete.
8515         (one_fork_p): New.
8516         (add_fork): Adjust.
8517         (free_fork): Delete, folded into fork_info::~fork_info().
8518         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8519         Adjust.
8520         (init_fork_list): Delete.
8521         (linux_fork_killall, linux_fork_mourn_inferior)
8522         (linux_fork_detach, info_checkpoints_command): Adjust.
8523         (_initialize_linux_fork): No longer call init_fork_list.
8524
8525 2019-03-06  Pedro Alves  <palves@redhat.com>
8526
8527         * linux-fork.c (new_fork): New, split out of ...
8528         (add_fork): ... this.  Return void.  Move "first fork" special
8529         case from here, to ...
8530         (checkpoint_command): ... here.
8531         * linux-linux.h (add_fork): Return void.
8532
8533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8534
8535         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8536
8537 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8538             Chris January  <chris.january@arm.com>
8539             David Lecomber  <david.lecomber@arm.com>
8540
8541         * f-exp.y: New token, UNOP_INTRINSIC.
8542         (exp): New pattern using UNOP_INTRINSIC token.
8543         (f77_keywords): Add 'abs' keyword.
8544         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8545         (value_from_host_double): New function.
8546         (evaluate_subexp_f): Support UNOP_ABS.
8547
8548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8551         types.
8552
8553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8554
8555         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8556         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8557         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8558
8559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8562
8563 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8564             Chris January  <chris.january@arm.com>
8565
8566         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8567         * f-exp.y: Define 'KIND' token.
8568         (exp): New pattern for KIND expressions.
8569         (ptype): Handle types with a kind extension.
8570         (direct_abs_decl): Extend to spot kind extensions.
8571         (f77_keywords): Add 'kind' to the list.
8572         (push_kind_type): New function.
8573         (convert_to_kind_type): New function.
8574         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8575         * parse.c (operator_length_standard): Likewise.
8576         * parser-defs.h (enum type_pieces): Add tp_kind.
8577         * std-operator.def: Add UNOP_KIND.
8578
8579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * f-exp.y (f_parse): Set yydebug.
8582
8583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * f-lang.c (evaluate_subexp_f): New function.
8586         (exp_descriptor_f): New global.
8587         (f_language_defn): Use exp_descriptor_f instead of
8588         exp_descriptor_standard.
8589
8590 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8591
8592         * f-exp.y (struct token): Add comments.
8593         (dot_ops): Remove uppercase versions and the end marker.
8594         (f77_keywords): Likewise.
8595         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8596         entries in the dot_ops array are case insensitive, and use
8597         strncasecmp to compare strings.  Also some whitespace cleanup in
8598         this area.  Similar for the f77_keywords array, except entries in
8599         this list might be case sensitive.
8600
8601 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8602
8603         * f-exp.y (struct f77_boolean_val): Add comments.
8604         (boolean_values): Remove uppercase versions, and end marker.
8605         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8606         and use strncasecmp to achieve case insensitivity.  Additionally,
8607         perform whitespace cleanup around this code.
8608
8609 2019-03-06  Tom Tromey  <tromey@adacore.com>
8610
8611         * remote-sim.c (gdbsim_target_open): Use result of
8612         gdb_argv::release.
8613
8614 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8615         Dirk Schubert  <dirk.schubert@arm.com>
8616         Chris January  <chris.january@arm.com>
8617
8618         * eval.c (evaluate_subexp_standard): Call Fortran argument
8619         wrapping logic.
8620         * f-lang.c (struct value): A value which can be passed into a
8621         Fortran function call.
8622         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8623         where appropriate.
8624         (struct type): Value ready for a Fortran function call.
8625         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8626         is needed.
8627         * f-lang.h (fortran_argument_convert): Declaration.
8628         (fortran_preserve_arg_pointer): Declaration.
8629         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8630
8631 2019-03-05  Tom Tromey  <tromey@adacore.com>
8632
8633         * python/py-prettyprint.c (print_string_repr): Remove #if.
8634         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8635
8636 2019-03-05  Tom Tromey  <tromey@adacore.com>
8637
8638         * target.c (the_dummy_target): Move later.  Change type to
8639         "dummy_target".
8640         (initialize_targets): Don't initialize the_dummy_target.
8641
8642 2019-03-05  Tom Tromey  <tromey@adacore.com>
8643
8644         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8645         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8646
8647 2019-03-05  Tom Tromey  <tromey@adacore.com>
8648
8649         * windows-nat.c (windows_nat_target::attach)
8650         (windows_nat_target::detach): Don't call gdb_flush.
8651         * valprint.c (generic_val_print, val_print, val_print_string):
8652         Don't call gdb_flush.
8653         * utils.c (defaulted_query): Don't call gdb_flush.
8654         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8655         * target.c (target_announce_detach): Don't call gdb_flush.
8656         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8657         * remote.c (extended_remote_target::attach): Don't call
8658         gdb_flush.
8659         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8660         * printcmd.c (do_examine): Don't call gdb_flush.
8661         (info_display_command): Don't call gdb_flush.
8662         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8663         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8664         * memattr.c (info_mem_command): Don't call gdb_flush.
8665         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8666         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8667         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8668         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8669         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8670         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8671         (gnu_nat_target::detach): Don't call gdb_flush.
8672         * f-valprint.c (f_val_print): Don't call gdb_flush.
8673         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8674         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8675         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8676         gdb_flush.
8677         * c-valprint.c (c_val_print): Don't call gdb_flush.
8678         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8679
8680 2019-03-05  Tom Tromey  <tromey@adacore.com>
8681
8682         * varobj.c (update_dynamic_varobj_children): Update.
8683         (install_default_visualizer): Use reset, not release.
8684         * value.c (set_internalvar): Update.
8685         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8686         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8687         ATTRIBUTE_UNUSED_RESULT.
8688
8689 2019-03-05  Tom Tromey  <tromey@adacore.com>
8690
8691         * remote.c (class scoped_remote_fd) <release>: Add
8692         ATTRIBUTE_UNUSED_RESULT.
8693
8694 2019-03-05  Tom Tromey  <tromey@adacore.com>
8695
8696         * macroexp.c (struct macro_buffer) <release>: Add
8697         ATTRIBUTE_UNUSED_RESULT.
8698
8699 2019-03-05  Tom Tromey  <tromey@adacore.com>
8700
8701         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8702         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8703         ATTRIBUTE_UNUSED_RESULT.
8704
8705 2019-03-05  Tom Tromey  <tromey@adacore.com>
8706
8707         * common/scoped_fd.h (class scoped_fd) <release>: Add
8708         ATTRIBUTE_UNUSED_RESULT.
8709
8710 2019-03-05  Tom Tromey  <tromey@adacore.com>
8711
8712         * parser-defs.h (struct parser_state) <release>: Add
8713         ATTRIBUTE_UNUSED_RESULT.
8714
8715 2019-03-05  Tom Tromey  <tromey@adacore.com>
8716
8717         * utils.h (class gdb_argv) <release>: Add
8718         ATTRIBUTE_UNUSED_RESULT.
8719         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8720
8721 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8722
8723         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8724         for-loop range, to avoid compiler warnings.
8725
8726         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8727         avoid compiler warnings about unused variables.
8728
8729         * NEWS: Mention end of support for native debugging on MS-Windows
8730         before XP.
8731
8732         PR gdb/24292
8733         * common/netstuff.c:
8734         * gdbserver/gdbreplay.c
8735         * gdbserver/remote-utils.c:
8736         * ser-tcp.c:
8737         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8738         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8739         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8740         'getaddrinfo' and 'freeaddrinfo' were not available before
8741         Windows XP, and mingw.org's MinGW headers by default define
8742         _WIN32_WINNT to 0x500.
8743
8744 2019-03-01  Gary Benson <gbenson@redhat.com>
8745
8746         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8747
8748 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8749             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8750
8751         PR gdb/8527
8752         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8753         set_sigint_trap, clear_sigint_trap.
8754
8755 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8756
8757         * target.c (target_detach): Clear the regcache and the
8758         frame cache.
8759
8760 2019-02-27  Pedro Alves  <palves@redhat.com>
8761
8762         * utils.c (set_screen_size): When we cap the height/width sizes,
8763         tweak the corresponding command variable to show "unlimited":
8764
8765 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8766             Pedro Alves  <palves@redhat.com>
8767
8768         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8769         before calling rl_set_screen_size.
8770
8771 2019-02-27  Tom Tromey  <tromey@adacore.com>
8772
8773         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8774         define.
8775         * python/py-value.c: Remove Python 2.4 workaround.
8776         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8777         workaround.
8778         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8779         Python 2.4 workaround.
8780         * python/python-internal.h: Remove Python 2.4 comment.
8781         (Py_ssize_t): Don't define.
8782         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8783         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8784         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8785         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8786         * python/python.c (do_start_initialization): Remove Python 2.4
8787         workaround.
8788         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8789         (print_children): Remove Python 2.4 workaround.
8790         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8791         workaround.
8792         (CHARBUFFERPROC_NAME): Remove.
8793         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8794         Python 2.4 workaround.
8795
8796 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8797
8798         * NEWS: Note minimum Python version.
8799
8800 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8801
8802         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8803         code from these functions.  Remove corresponding ifdefs.  Use
8804         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8805         Remove gotos and target of gotos.
8806         (infpy_search_memory): Likewise.
8807
8808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8809
8810         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8811         (hppa_gdbarch_init): Don't register deleted functions with
8812         gdbarch.
8813
8814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8817         (h8300_unwind_sp): Delete.
8818         (h8300_dummy_id): Delete.
8819         (h8300_gdbarch_init): Don't register deleted functions with
8820         gdbarch.
8821
8822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8825         (ft32_unwind_pc): Delete.
8826         (ft32_unwind_sp): Delete.
8827         (ft32_gdbarch_init): Don't register deleted functions with
8828         gdbarch.
8829
8830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8833         (frv_unwind_pc): Delete.
8834         (frv_unwind_sp): Delete.
8835         (frv_gdbarch_init): Don't register deleted functions with
8836         gdbarch.
8837
8838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8841         (riscv_unwind_pc): Delete.
8842         (riscv_unwind_sp): Delete.
8843         (riscv_gdbarch_init): Don't register deleted functions with
8844         gdbarch.
8845
8846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8847
8848         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8849         (csky_unwind_pc): Delete.
8850         (csky_unwind_sp): Delete.
8851         (csky_gdbarch_init): Don't register deleted functions with
8852         gdbarch.
8853
8854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8855
8856         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8857         (cris_unwind_pc): Delete.
8858         (cris_unwind_sp): Delete.
8859         (cris_gdbarch_init): Don't register deleted functions with
8860         gdbarch.
8861
8862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8863
8864         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8865         (bfin_unwind_pc): Delete.
8866         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8867
8868 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8869
8870         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8871         (arm_unwind_pc): Delete.
8872         (arm_unwind_sp): Delete.
8873         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8874
8875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8878         (arc_unwind_pc): Delete.
8879         (arc_unwind_sp): Delete.
8880         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8881
8882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8885         (alpha_unwind_pc): Delete.
8886         (alpha_gdbarch_init): Don't register deleted functions with
8887         gdbarch.
8888
8889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8892         (aarch64_unwind_pc): Delete.
8893         (aarch64_unwind_sp): Delete.
8894         (aarch64_gdbarch_init): Don't register deleted functions with
8895         gdbarch.
8896
8897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * gdbtypes.c (type_align): Don't consider static members when
8900         computing structure alignment.
8901
8902 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8905         return 0 for other types.
8906         * arch-utils.c (default_type_align): Always return 0.
8907         * gdbarch.h: Regenerate.
8908         * gdbarch.sh (type_align): Extend comment.
8909         * gdbtypes.c (type_align): Add additional comments, always call
8910         gdbarch_type_align before applying the default rules.
8911         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8912         generic code will then apply a suitable default.
8913         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8914         types, return 0 for other types.
8915
8916 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8917
8918         * NEWS: Create a new section for the next release branch.
8919         Rename the section of the current branch, now that it has
8920         been cut.
8921
8922 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8923
8924         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8925         * version.in: Bump version to 8.3.50.DATE-git.
8926
8927 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8928
8929         * aix-thread.c (ptid_cmp): Remove unused variable.
8930         (get_signaled_thread): Likewise.
8931         (store_regs_user_thread): Likewise.
8932         (store_regs_kernel_thread): Likewise.
8933         (fetch_regs_kernel_thread): Remove shadowed variable.
8934
8935 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8936
8937         * features/riscv/32bit-cpu.xml: Add register numbers.
8938         * features/riscv/32bit-fpu.c: Regenerate.
8939         * features/riscv/32bit-fpu.xml: Add register numbers.
8940         * features/riscv/64bit-cpu.xml: Add register numbers.
8941         * features/riscv/64bit-fpu.c: Regenerate.
8942         * features/riscv/64bit-fpu.xml: Add register numbers.
8943
8944 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8945
8946         * NEWS: Mention two argument form of gdb.Value constructor.
8947         * python/py-value.c (convert_buffer_and_type_to_value): New
8948         function.
8949         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8950         Add support for handling an optional second argument.  Call
8951         convert_buffer_and_type_to_value as appropriate.
8952         * python/python-internal.h (Py_buffer_deleter): New struct.
8953         (Py_buffer_up): New typedef.
8954
8955 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8956
8957         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8958         instead of releasing ownership.
8959
8960 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8961
8962         * dwarf2read.c (open_and_init_dwp_file): Call
8963         elf_numsections instead of bfd_count_sections to initialize
8964         dwp_file->num_sections.
8965
8966 2019-02-25  Tom Tromey  <tromey@adacore.com>
8967
8968         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8969
8970 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8971
8972         * gcore.in: Add '--readnever' option when invoking GDB.
8973
8974 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8975
8976         * MAINTAINERS: Update my email address.
8977
8978 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8979
8980         * build-id.c (build_id_to_debug_bfd_1): New function.
8981         (build_id_to_debug_bfd): Look for separate debug file in
8982         sysroot.
8983
8984 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8985
8986         * gdbarch.sh: Update the copyright year range that is placed into
8987         generated files.
8988
8989 2019-02-22  Keith Seitz  <keiths@redhat.com>
8990
8991         PR symtab/23853
8992         * linespec.c (create_sals_line_offset): Search for the default
8993         symtab's filename instead of its fullname.
8994
8995 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8996
8997         * NEWS: Update style defaults.
8998
8999 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9000
9001         * main.c (captured_main_1): Disable styling in batch mode.
9002
9003 2019-02-20  Tom Tromey  <tom@tromey.com>
9004
9005         * symtab.c (symtab_symbol_info): Fix typos.
9006
9007 2019-02-20  Tom Tromey  <tromey@adacore.com>
9008
9009         * findcmd.c (_initialize_mem_search): Use upper case for
9010         metasyntactic variables.
9011
9012 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9013
9014         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9015         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9016
9017 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9018
9019         * top.h (source_file_name): Change to std::string.
9020         * top.c (source_file_name): Likewise.
9021         (command_line_input): Adjust.
9022         * cli/cli-script.c (script_from_file): Adjust.
9023
9024 2019-02-19  Tom Tromey  <tromey@adacore.com>
9025
9026         * ravenscar-thread.c
9027         (ravenscar_thread_target::update_thread_list): Don't call
9028         ada_build_task_list.
9029         * ada-lang.h (ada_build_task_list): Don't declare.
9030         * ada-tasks.c (struct ada_tasks_inferior_data)
9031         <task_list_valid_p>: Now bool.
9032         (read_known_tasks, ada_task_list_changed)
9033         (ada_tasks_invalidate_inferior_data): Update.
9034         (read_known_tasks_array): Return bool.
9035         (read_known_tasks_list): Likewise.
9036         (read_known_tasks): Return void.
9037         (ada_build_task_list): Now static.
9038
9039 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9040
9041         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9042         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9043
9044 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9045
9046         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9047         variant for ada_tasks_pspace_data_handle and
9048         ada_tasks_inferior_data_handle.
9049         (ada_tasks_pspace_data_cleanup): New function.
9050         (ada_tasks_inferior_data_cleanup): New function.
9051
9052 2019-02-17  Tom Tromey  <tom@tromey.com>
9053
9054         * macrotab.h (macro_source_fullname): Return a std::string.
9055         * macrotab.c (macro_include, check_for_redefinition)
9056         (macro_undef, macro_lookup_definition, foreach_macro)
9057         (foreach_macro_in_scope): Update.
9058         (macro_source_fullname): Return a std::string.
9059         * macrocmd.c (show_pp_source_pos): Update.
9060
9061 2019-02-17  Tom Tromey  <tom@tromey.com>
9062
9063         * macrocmd.c (show_pp_source_pos): Style the file names.
9064
9065 2019-02-17  Tom Tromey  <tom@tromey.com>
9066
9067         PR tui/24197:
9068         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9069
9070 2019-02-17  Tom Tromey  <tom@tromey.com>
9071
9072         * ada-lang.c (user_select_syms): Use filtered printing.
9073         * utils.c (wrap_style): New global.
9074         (desired_style): Remove.
9075         (emit_style_escape): Add stream parameter.
9076         (set_output_style, reset_terminal_style, prompt_for_continue):
9077         Update.
9078         (flush_wrap_buffer): Only flush gdb_stdout.
9079         (wrap_here): Set wrap_style.
9080         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9081         treat escape sequences as a character.  Change when wrap buffer is
9082         flushed.
9083         (fputs_styled): Do not set the output style when the default is
9084         requested.
9085         * ui-style.h (struct ui_file_style) <is_default>: New method.
9086         * source.c (print_source_lines_base): Emit escape sequences in one
9087         piece.
9088
9089 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9090
9091         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9092         integers and enumeration types.
9093
9094 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9095
9096         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9097         instead of lookup_symbol_in_language
9098         (do_exact_match): New function.
9099         (ada_get_symbol_name_matcher): Return do_exact_match when
9100         doing a verbatim match.
9101
9102 2019-02-15  Tom Tromey  <tromey@adacore.com>
9103
9104         * ravenscar-thread.c (ravenscar_thread_target::resume)
9105         (ravenscar_thread_target::wait): Special case wildcard requests.
9106
9107 2019-02-15  Tom Tromey  <tromey@adacore.com>
9108
9109         * ravenscar-thread.c (base_ptid): Remove.
9110         (struct ravenscar_thread_target) <close>: New method.
9111         <m_base_ptid>: New member.
9112         <update_inferior_ptid, active_task, task_is_currently_active,
9113         runtime_initialized>: Declare methods.
9114         <ravenscar_thread_target>: Add constructor.
9115         (ravenscar_thread_target::task_is_currently_active)
9116         (ravenscar_thread_target::update_inferior_ptid)
9117         (ravenscar_runtime_initialized): Rename.  Now methods.
9118         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9119         (ravenscar_thread_target::update_thread_list): Update.
9120         (ravenscar_thread_target::active_task): Now method.
9121         (ravenscar_thread_target::store_registers)
9122         (ravenscar_thread_target::prepare_to_store)
9123         (ravenscar_thread_target::prepare_to_store)
9124         (ravenscar_thread_target::mourn_inferior): Update.
9125         (ravenscar_inferior_created): Use "new" to create target.
9126         (ravenscar_thread_target::get_ada_task_ptid): Update.
9127         (_initialize_ravenscar): Don't initialize base_ptid.
9128         (ravenscar_ops): Remove global.
9129
9130 2019-02-15  Tom Tromey  <tromey@adacore.com>
9131
9132         * target.h (push_target): Declare new overload.
9133         * target.c (push_target): New overload, taking an rvalue reference.
9134         * remote.c (remote_target::open_1): Use push_target overload.
9135         * corelow.c (core_target_open): Use push_target overload.
9136
9137 2019-02-15  Tom Tromey  <tromey@adacore.com>
9138
9139         * ravenscar-thread.c (is_ravenscar_task)
9140         (ravenscar_task_is_currently_active): Return bool.
9141         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9142         (_initialize_ravenscar): Remove "(void)".
9143         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9144         Return bool.
9145
9146 2019-02-15  Tom Tromey  <tromey@adacore.com>
9147
9148         * ravenscar-thread.c (ravenscar_runtime_initializer)
9149         (has_ravenscar_runtime, get_running_thread_id)
9150         (ravenscar_thread_target::resume): Fix indentation.
9151
9152 2019-02-15  Tom Tromey  <tromey@adacore.com>
9153
9154         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9155         from ravenscar_arch_ops.
9156         (sparc_ravenscar_ops::fetch_registers)
9157         (sparc_ravenscar_ops::store_registers): Now methods.
9158         (sparc_ravenscar_prepare_to_store): Remove.
9159         (sparc_ravenscar_ops): Redefine.
9160         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9161         methods and destructor.  Remove members.
9162         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9163         (ravenscar_thread_target::store_registers)
9164         (ravenscar_thread_target::prepare_to_store): Update.
9165         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9166         Remove.
9167         (struct ppc_ravenscar_powerpc_ops): Derive from
9168         ravenscar_arch_ops.
9169         (ppc_ravenscar_powerpc_ops::fetch_registers)
9170         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9171         (ppc_ravenscar_powerpc_ops): Redefine.
9172         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9173         (ppc_ravenscar_e500_ops::fetch_registers)
9174         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9175         (ppc_ravenscar_e500_ops): Redefine.
9176         * aarch64-ravenscar-thread.c
9177         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9178         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9179         (aarch64_ravenscar_fetch_registers)
9180         (aarch64_ravenscar_store_registers): Now methods.
9181         (aarch64_ravenscar_ops): Redefine.
9182
9183 2019-02-15  Tom Tromey  <tromey@adacore.com>
9184
9185         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9186         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9187         (ravenscar_thread_target::stopped_by_watchpoint)
9188         (ravenscar_thread_target::stopped_data_address)
9189         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9190
9191 2019-02-15  Tom Tromey  <tromey@adacore.com>
9192
9193         * ravenscar-thread.c: Fix some typos.
9194
9195 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9196             Tom Tromey  <tromey@adacore.com>
9197
9198         * ada-lang.c (ada_exception_sal): Change addr_string to a
9199         std::string.
9200         (create_ada_exception_catchpoint): Update.
9201
9202 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9203             Tom Tromey  <tromey@adacore.com>
9204
9205         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9206         (bp_location_ops): Remove.
9207         (base_breakpoint_allocate_location): Update.
9208         (free_bp_location): Update.
9209         * ada-lang.c (class ada_catchpoint_location)
9210         <ada_catchpoint_location>: Remove ops parameter.
9211         (ada_catchpoint_location_dtor): Remove.
9212         (ada_catchpoint_location_ops): Remove.
9213         (allocate_location_exception): Update.
9214         * breakpoint.h (struct bp_location_ops): Remove.
9215         (class bp_location) <bp_location>: Remove bp_location_ops
9216         parameter.
9217         <~bp_location>: Add destructor.
9218         <ops>: Remove.
9219
9220 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9221             Pedro Alves  <palves@redhat.com>
9222
9223         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9224         'PATH_MAX'.
9225
9226 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9227             Samuel Thibault  <samuel.thibault@gnu.org>
9228             Thomas Schwinge  <thomas@codesourcery.com>
9229
9230         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9231         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9232
9233 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9234
9235         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9236         (check_empty): Use "const char *".
9237
9238         * gnu-nat.c (gnu_nat_target::detach): Instead of
9239         'detach_inferior (pid)' call
9240         'detach_inferior (find_inferior_pid (pid))'.
9241
9242         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9243         'nat/fork-inferior.o'.
9244         * gnu-nat.c: #include "nat/fork-inferior.h".
9245
9246         * gnu-nat.c (gnu_nat_target::detach): Instead of
9247         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9248         * gnu-nat.h: #include "inf-child.h".
9249         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9250         'i386_gnu_nat_target::fetch_registers'.
9251         (gnu_store_registers): Rename/move to
9252         'i386_gnu_nat_target::store_registers'.
9253
9254         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9255         * gnu-nat.h (mach_thread_info): New function.
9256         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9257
9258         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9259
9260 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9261
9262         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9263
9264 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9265
9266         * windows-nat.c (windows_add_thread): Add new parameter
9267         "main_thread_p" with default value set to false.  Update
9268         function documentation as well as all callers.
9269         (windows_delete_thread): Likewise.
9270         (fake_create_process): Update call to windows_add_thread.
9271         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9272         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9273         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9274         call to windows_delete_thread.
9275
9276 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9277
9278         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9279
9280 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9281
9282         * symfile.c (find_separate_debug_file): Use canonical path of
9283         sysroot with child_path instead of gdb_sysroot if it is valid.
9284
9285 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9286
9287         * symfile.c (find_separate_debug_file): Use child_path to
9288         determine if an object file is under a sysroot.
9289
9290 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9291
9292         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9293         unittests/child-path-selftests.c.
9294         * common/pathstuff.c (child_path): New function.
9295         * common/pathstuff.h (child_path): New prototype.
9296         * unittests/child-path-selftests.c: New file.
9297
9298 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9299
9300         * symfile.c (find_separate_debug_file): Look for separate debug
9301         files in debug directories under the sysroot.
9302
9303 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9304
9305         * symtab.h (struct minimal_symbol data_p): New const method.
9306         (struct minimal_symbol text_p): Likewise.
9307         * symtab.c (output_source_filename): Use file name style
9308         to print file name.
9309         (print_symbol_info): Likewise.
9310         (print_msymbol_info): Use address style to print addresses.
9311         Use function name style to print executable text symbols.
9312         (expand_symtab_containing_pc): Use data_p.
9313         (find_pc_sect_compunit_symtab): Likewise.
9314
9315 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9316
9317         * breakpoint.c (describe_other_breakpoints): Use address style
9318         to print addresses.
9319         (say_where): Likewise.
9320
9321 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9322
9323         * ada-typeprint.c (print_func_type): Print function name
9324         style to print function name.
9325         * c-typeprint.c (c_print_type_1): Likewise.
9326
9327 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9328
9329         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9330         for execve.
9331
9332 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9333
9334         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9335         type_stack.
9336
9337 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9338
9339         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9340         TYPE_CODE_REF types.
9341
9342 2019-02-08  Jim Wilson  <jimw@sifive.com>
9343
9344         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9345         (riscv_linux_fregset): New.
9346         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9347
9348 2019-02-07  Tom Tromey  <tom@tromey.com>
9349
9350         * thread.c (thread_cancel_execution_command): Update.
9351         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9352         methods.
9353         (struct thread_fsm_ops): Remove.
9354         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9355         (thread_fsm_should_stop, thread_fsm_return_value)
9356         (thread_fsm_set_finished, thread_fsm_finished_p)
9357         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9358         Don't declare.
9359         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9360         * infrun.c (clear_proceed_status_thread)
9361         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9362         (print_stop_event): Update.
9363         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9364         Add constructor.
9365         (step_command_fsm_ops): Remove.
9366         (new_step_command_fsm): Remove.
9367         (step_1): Update.
9368         (step_command_fsm::should_stop): Rename from
9369         step_command_fsm_should_stop.
9370         (step_command_fsm::clean_up): Rename from
9371         step_command_fsm_clean_up.
9372         (step_command_fsm::do_async_reply_reason): Rename from
9373         step_command_fsm_async_reply_reason.
9374         (struct until_next_fsm): Inherit from thread_fsm.  Add
9375         constructor.
9376         (until_next_fsm_ops): Remove.
9377         (new_until_next_fsm): Remove.
9378         (until_next_fsm::should_stop): Rename from
9379         until_next_fsm_should_stop.
9380         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9381         (until_next_fsm::do_async_reply_reason): Rename from
9382         until_next_fsm_async_reply_reason.
9383         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9384         constructor.  Change type of breakpoint.
9385         (finish_command_fsm_ops): Remove.
9386         (new_finish_command_fsm): Remove.
9387         (finish_command_fsm::should_stop): Rename from
9388         finish_command_fsm_should_stop.
9389         (finish_command_fsm::clean_up): Rename from
9390         finish_command_fsm_clean_up.
9391         (finish_command_fsm::return_value): Rename from
9392         finish_command_fsm_return_value.
9393         (finish_command_fsm::do_async_reply_reason): Rename from
9394         finish_command_fsm_async_reply_reason.
9395         (finish_command): Update.
9396         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9397         Add constructor.
9398         (call_thread_fsm_ops): Remove.
9399         (call_thread_fsm::call_thread_fsm): Rename from
9400         new_call_thread_fsm.
9401         (call_thread_fsm::should_stop): Rename from
9402         call_thread_fsm_should_stop.
9403         (call_thread_fsm::should_notify_stop): Rename from
9404         call_thread_fsm_should_notify_stop.
9405         (run_inferior_call, call_function_by_hand_dummy): Update.
9406         * cli/cli-interp.c (should_print_stop_to_console): Update.
9407         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9408         Add constructor.  Change type of location_breakpoint,
9409         caller_breakpoint.
9410         (until_break_fsm_ops): Remove.
9411         (new_until_break_fsm): Remove.
9412         (until_break_fsm::should_stop): Rename from
9413         until_break_fsm_should_stop.
9414         (until_break_fsm::clean_up): Rename from
9415         until_break_fsm_clean_up.
9416         (until_break_fsm::do_async_reply_reason): Rename from
9417         until_break_fsm_async_reply_reason.
9418         (until_break_command): Update.
9419         * thread-fsm.c: Remove.
9420         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9421
9422 2019-02-07  Tom Tromey  <tom@tromey.com>
9423
9424         * yy-remap.h: Add include guard.
9425         * xtensa-tdep.h: Add include guard.
9426         * xcoffread.h: Rename include guard.
9427         * varobj-iter.h: Add include guard.
9428         * tui/tui.h: Rename include guard.
9429         * tui/tui-winsource.h: Rename include guard.
9430         * tui/tui-wingeneral.h: Rename include guard.
9431         * tui/tui-windata.h: Rename include guard.
9432         * tui/tui-win.h: Rename include guard.
9433         * tui/tui-stack.h: Rename include guard.
9434         * tui/tui-source.h: Rename include guard.
9435         * tui/tui-regs.h: Rename include guard.
9436         * tui/tui-out.h: Rename include guard.
9437         * tui/tui-layout.h: Rename include guard.
9438         * tui/tui-io.h: Rename include guard.
9439         * tui/tui-hooks.h: Rename include guard.
9440         * tui/tui-file.h: Rename include guard.
9441         * tui/tui-disasm.h: Rename include guard.
9442         * tui/tui-data.h: Rename include guard.
9443         * tui/tui-command.h: Rename include guard.
9444         * tic6x-tdep.h: Add include guard.
9445         * target/waitstatus.h: Rename include guard.
9446         * target/wait.h: Rename include guard.
9447         * target/target.h: Rename include guard.
9448         * target/resume.h: Rename include guard.
9449         * target-float.h: Rename include guard.
9450         * stabsread.h: Add include guard.
9451         * rs6000-tdep.h: Add include guard.
9452         * riscv-fbsd-tdep.h: Add include guard.
9453         * regformats/regdef.h: Rename include guard.
9454         * record.h: Rename include guard.
9455         * python/python.h: Rename include guard.
9456         * python/python-internal.h: Rename include guard.
9457         * python/py-stopevent.h: Rename include guard.
9458         * python/py-ref.h: Rename include guard.
9459         * python/py-record.h: Rename include guard.
9460         * python/py-record-full.h: Rename include guard.
9461         * python/py-record-btrace.h: Rename include guard.
9462         * python/py-instruction.h: Rename include guard.
9463         * python/py-events.h: Rename include guard.
9464         * python/py-event.h: Rename include guard.
9465         * procfs.h: Add include guard.
9466         * proc-utils.h: Add include guard.
9467         * p-lang.h: Add include guard.
9468         * or1k-tdep.h: Rename include guard.
9469         * observable.h: Rename include guard.
9470         * nto-tdep.h: Rename include guard.
9471         * nat/x86-linux.h: Rename include guard.
9472         * nat/x86-linux-dregs.h: Rename include guard.
9473         * nat/x86-gcc-cpuid.h: Add include guard.
9474         * nat/x86-dregs.h: Rename include guard.
9475         * nat/x86-cpuid.h: Rename include guard.
9476         * nat/ppc-linux.h: Rename include guard.
9477         * nat/mips-linux-watch.h: Rename include guard.
9478         * nat/linux-waitpid.h: Rename include guard.
9479         * nat/linux-ptrace.h: Rename include guard.
9480         * nat/linux-procfs.h: Rename include guard.
9481         * nat/linux-osdata.h: Rename include guard.
9482         * nat/linux-nat.h: Rename include guard.
9483         * nat/linux-namespaces.h: Rename include guard.
9484         * nat/linux-btrace.h: Rename include guard.
9485         * nat/glibc_thread_db.h: Rename include guard.
9486         * nat/gdb_thread_db.h: Rename include guard.
9487         * nat/gdb_ptrace.h: Rename include guard.
9488         * nat/fork-inferior.h: Rename include guard.
9489         * nat/amd64-linux-siginfo.h: Rename include guard.
9490         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9491         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9492         * nat/aarch64-linux.h: Rename include guard.
9493         * nat/aarch64-linux-hw-point.h: Rename include guard.
9494         * mn10300-tdep.h: Add include guard.
9495         * mips-linux-tdep.h: Add include guard.
9496         * mi/mi-parse.h: Rename include guard.
9497         * mi/mi-out.h: Rename include guard.
9498         * mi/mi-main.h: Rename include guard.
9499         * mi/mi-interp.h: Rename include guard.
9500         * mi/mi-getopt.h: Rename include guard.
9501         * mi/mi-console.h: Rename include guard.
9502         * mi/mi-common.h: Rename include guard.
9503         * mi/mi-cmds.h: Rename include guard.
9504         * mi/mi-cmd-break.h: Rename include guard.
9505         * m2-lang.h: Add include guard.
9506         * location.h: Rename include guard.
9507         * linux-record.h: Rename include guard.
9508         * linux-nat.h: Add include guard.
9509         * linux-fork.h: Add include guard.
9510         * i386-darwin-tdep.h: Rename include guard.
9511         * hppa-linux-offsets.h: Add include guard.
9512         * guile/guile.h: Rename include guard.
9513         * guile/guile-internal.h: Rename include guard.
9514         * gnu-nat.h: Rename include guard.
9515         * gdb-stabs.h: Rename include guard.
9516         * frv-tdep.h: Add include guard.
9517         * f-lang.h: Add include guard.
9518         * event-loop.h: Add include guard.
9519         * darwin-nat.h: Rename include guard.
9520         * cp-abi.h: Rename include guard.
9521         * config/sparc/nm-sol2.h: Rename include guard.
9522         * config/nm-nto.h: Rename include guard.
9523         * config/nm-linux.h: Add include guard.
9524         * config/i386/nm-i386gnu.h: Rename include guard.
9525         * config/djgpp/nl_types.h: Rename include guard.
9526         * config/djgpp/langinfo.h: Rename include guard.
9527         * compile/gcc-cp-plugin.h: Add include guard.
9528         * compile/gcc-c-plugin.h: Add include guard.
9529         * compile/compile.h: Rename include guard.
9530         * compile/compile-object-run.h: Rename include guard.
9531         * compile/compile-object-load.h: Rename include guard.
9532         * compile/compile-internal.h: Rename include guard.
9533         * compile/compile-cplus.h: Rename include guard.
9534         * compile/compile-c.h: Rename include guard.
9535         * common/xml-utils.h: Rename include guard.
9536         * common/x86-xstate.h: Rename include guard.
9537         * common/version.h: Rename include guard.
9538         * common/vec.h: Rename include guard.
9539         * common/tdesc.h: Rename include guard.
9540         * common/selftest.h: Rename include guard.
9541         * common/scoped_restore.h: Rename include guard.
9542         * common/scoped_mmap.h: Rename include guard.
9543         * common/scoped_fd.h: Rename include guard.
9544         * common/safe-iterator.h: Rename include guard.
9545         * common/run-time-clock.h: Rename include guard.
9546         * common/refcounted-object.h: Rename include guard.
9547         * common/queue.h: Rename include guard.
9548         * common/ptid.h: Rename include guard.
9549         * common/print-utils.h: Rename include guard.
9550         * common/preprocessor.h: Rename include guard.
9551         * common/pathstuff.h: Rename include guard.
9552         * common/observable.h: Rename include guard.
9553         * common/netstuff.h: Rename include guard.
9554         * common/job-control.h: Rename include guard.
9555         * common/host-defs.h: Rename include guard.
9556         * common/gdb_wait.h: Rename include guard.
9557         * common/gdb_vecs.h: Rename include guard.
9558         * common/gdb_unlinker.h: Rename include guard.
9559         * common/gdb_unique_ptr.h: Rename include guard.
9560         * common/gdb_tilde_expand.h: Rename include guard.
9561         * common/gdb_sys_time.h: Rename include guard.
9562         * common/gdb_string_view.h: Rename include guard.
9563         * common/gdb_splay_tree.h: Rename include guard.
9564         * common/gdb_setjmp.h: Rename include guard.
9565         * common/gdb_ref_ptr.h: Rename include guard.
9566         * common/gdb_optional.h: Rename include guard.
9567         * common/gdb_locale.h: Rename include guard.
9568         * common/gdb_assert.h: Rename include guard.
9569         * common/filtered-iterator.h: Rename include guard.
9570         * common/filestuff.h: Rename include guard.
9571         * common/fileio.h: Rename include guard.
9572         * common/environ.h: Rename include guard.
9573         * common/common-utils.h: Rename include guard.
9574         * common/common-types.h: Rename include guard.
9575         * common/common-regcache.h: Rename include guard.
9576         * common/common-inferior.h: Rename include guard.
9577         * common/common-gdbthread.h: Rename include guard.
9578         * common/common-exceptions.h: Rename include guard.
9579         * common/common-defs.h: Rename include guard.
9580         * common/common-debug.h: Rename include guard.
9581         * common/cleanups.h: Rename include guard.
9582         * common/buffer.h: Rename include guard.
9583         * common/btrace-common.h: Rename include guard.
9584         * common/break-common.h: Rename include guard.
9585         * cli/cli-utils.h: Rename include guard.
9586         * cli/cli-style.h: Rename include guard.
9587         * cli/cli-setshow.h: Rename include guard.
9588         * cli/cli-script.h: Rename include guard.
9589         * cli/cli-interp.h: Rename include guard.
9590         * cli/cli-decode.h: Rename include guard.
9591         * cli/cli-cmds.h: Rename include guard.
9592         * charset-list.h: Add include guard.
9593         * buildsym-legacy.h: Rename include guard.
9594         * bfin-tdep.h: Add include guard.
9595         * ax.h: Rename include guard.
9596         * arm-linux-tdep.h: Add include guard.
9597         * arm-fbsd-tdep.h: Add include guard.
9598         * arch/xtensa.h: Rename include guard.
9599         * arch/tic6x.h: Add include guard.
9600         * arch/i386.h: Add include guard.
9601         * arch/arm.h: Rename include guard.
9602         * arch/arm-linux.h: Rename include guard.
9603         * arch/arm-get-next-pcs.h: Rename include guard.
9604         * arch/amd64.h: Add include guard.
9605         * arch/aarch64-insn.h: Rename include guard.
9606         * arch-utils.h: Rename include guard.
9607         * annotate.h: Add include guard.
9608         * amd64-darwin-tdep.h: Rename include guard.
9609         * aarch64-linux-tdep.h: Add include guard.
9610         * aarch64-fbsd-tdep.h: Add include guard.
9611         * aarch32-linux-nat.h: Add include guard.
9612
9613 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9614
9615         * macrotab.c (macro_define_internal): New function that
9616         factorizes macro_define_object_internal and macro_define_function
9617         code.
9618         (macro_define_object_internal): Use macro_define_internal.
9619         (macro_define_function): Likewise.
9620
9621 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9622
9623         * macrocmd.c (extract_identifier): Return
9624         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9625         callers.
9626
9627 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9628
9629         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9630
9631 2019-02-05  Tom Tromey  <tom@tromey.com>
9632
9633         * target.c (target_stack::unpush): Move assertion earlier.
9634
9635 2019-01-30  Tom Tromey  <tom@tromey.com>
9636
9637         PR python/23615:
9638         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9639         (gdbpy_parse_and_eval): Likewise.
9640         * python/python-internal.h (gdbpy_allow_threads): New class.
9641
9642 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9643
9644         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9645         (aarch64_fbsd_fpregmap): Move earlier.
9646         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9647         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9648         instead of individual calls to trad_frame_set_reg_addr.
9649         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9650         earlier.
9651         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9652         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9653         instead of individual calls to trad_frame_set_reg_addr.
9654
9655 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9656
9657         * CONTRIBUTE: Replace contribution list with wiki link.
9658
9659 2019-01-25  Tom Tromey  <tom@tromey.com>
9660
9661         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9662
9663 2019-01-25  Tom Tromey  <tom@tromey.com>
9664
9665         * xtensa-linux-nat.c: Fix common/ includes.
9666         * xml-support.h: Fix common/ includes.
9667         * xml-support.c: Fix common/ includes.
9668         * x86-linux-nat.c: Fix common/ includes.
9669         * windows-nat.c: Fix common/ includes.
9670         * varobj.h: Fix common/ includes.
9671         * varobj.c: Fix common/ includes.
9672         * value.c: Fix common/ includes.
9673         * valops.c: Fix common/ includes.
9674         * utils.c: Fix common/ includes.
9675         * unittests/xml-utils-selftests.c: Fix common/ includes.
9676         * unittests/utils-selftests.c: Fix common/ includes.
9677         * unittests/unpack-selftests.c: Fix common/ includes.
9678         * unittests/tracepoint-selftests.c: Fix common/ includes.
9679         * unittests/style-selftests.c: Fix common/ includes.
9680         * unittests/string_view-selftests.c: Fix common/ includes.
9681         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9682         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9683         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9684         * unittests/rsp-low-selftests.c: Fix common/ includes.
9685         * unittests/parse-connection-spec-selftests.c: Fix common/
9686         includes.
9687         * unittests/optional-selftests.c: Fix common/ includes.
9688         * unittests/offset-type-selftests.c: Fix common/ includes.
9689         * unittests/observable-selftests.c: Fix common/ includes.
9690         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9691         * unittests/memrange-selftests.c: Fix common/ includes.
9692         * unittests/memory-map-selftests.c: Fix common/ includes.
9693         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9694         * unittests/function-view-selftests.c: Fix common/ includes.
9695         * unittests/environ-selftests.c: Fix common/ includes.
9696         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9697         * unittests/common-utils-selftests.c: Fix common/ includes.
9698         * unittests/cli-utils-selftests.c: Fix common/ includes.
9699         * unittests/array-view-selftests.c: Fix common/ includes.
9700         * ui-file.c: Fix common/ includes.
9701         * tui/tui-io.c: Fix common/ includes.
9702         * tracepoint.h: Fix common/ includes.
9703         * tracepoint.c: Fix common/ includes.
9704         * tracefile-tfile.c: Fix common/ includes.
9705         * top.h: Fix common/ includes.
9706         * top.c: Fix common/ includes.
9707         * thread.c: Fix common/ includes.
9708         * target/waitstatus.h: Fix common/ includes.
9709         * target/waitstatus.c: Fix common/ includes.
9710         * target.h: Fix common/ includes.
9711         * target.c: Fix common/ includes.
9712         * target-memory.c: Fix common/ includes.
9713         * target-descriptions.c: Fix common/ includes.
9714         * symtab.h: Fix common/ includes.
9715         * symfile.c: Fix common/ includes.
9716         * stap-probe.c: Fix common/ includes.
9717         * spu-linux-nat.c: Fix common/ includes.
9718         * sparc-nat.c: Fix common/ includes.
9719         * source.c: Fix common/ includes.
9720         * solib.c: Fix common/ includes.
9721         * solib-target.c: Fix common/ includes.
9722         * ser-unix.c: Fix common/ includes.
9723         * ser-tcp.c: Fix common/ includes.
9724         * ser-pipe.c: Fix common/ includes.
9725         * ser-base.c: Fix common/ includes.
9726         * selftest-arch.c: Fix common/ includes.
9727         * s12z-tdep.c: Fix common/ includes.
9728         * rust-exp.y: Fix common/ includes.
9729         * rs6000-aix-tdep.c: Fix common/ includes.
9730         * riscv-tdep.c: Fix common/ includes.
9731         * remote.c: Fix common/ includes.
9732         * remote-notif.h: Fix common/ includes.
9733         * remote-fileio.h: Fix common/ includes.
9734         * remote-fileio.c: Fix common/ includes.
9735         * regcache.h: Fix common/ includes.
9736         * regcache.c: Fix common/ includes.
9737         * record-btrace.c: Fix common/ includes.
9738         * python/python.c: Fix common/ includes.
9739         * python/py-type.c: Fix common/ includes.
9740         * python/py-inferior.c: Fix common/ includes.
9741         * progspace.h: Fix common/ includes.
9742         * producer.c: Fix common/ includes.
9743         * procfs.c: Fix common/ includes.
9744         * proc-api.c: Fix common/ includes.
9745         * printcmd.c: Fix common/ includes.
9746         * ppc-linux-nat.c: Fix common/ includes.
9747         * parser-defs.h: Fix common/ includes.
9748         * osdata.c: Fix common/ includes.
9749         * obsd-nat.c: Fix common/ includes.
9750         * nat/x86-linux.c: Fix common/ includes.
9751         * nat/x86-linux-dregs.c: Fix common/ includes.
9752         * nat/x86-dregs.h: Fix common/ includes.
9753         * nat/x86-dregs.c: Fix common/ includes.
9754         * nat/ppc-linux.c: Fix common/ includes.
9755         * nat/mips-linux-watch.h: Fix common/ includes.
9756         * nat/mips-linux-watch.c: Fix common/ includes.
9757         * nat/linux-waitpid.c: Fix common/ includes.
9758         * nat/linux-ptrace.h: Fix common/ includes.
9759         * nat/linux-ptrace.c: Fix common/ includes.
9760         * nat/linux-procfs.c: Fix common/ includes.
9761         * nat/linux-personality.c: Fix common/ includes.
9762         * nat/linux-osdata.c: Fix common/ includes.
9763         * nat/linux-namespaces.c: Fix common/ includes.
9764         * nat/linux-btrace.h: Fix common/ includes.
9765         * nat/linux-btrace.c: Fix common/ includes.
9766         * nat/fork-inferior.c: Fix common/ includes.
9767         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9768         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9769         * nat/aarch64-linux.c: Fix common/ includes.
9770         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9771         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9772         * namespace.h: Fix common/ includes.
9773         * mips-linux-tdep.c: Fix common/ includes.
9774         * minsyms.c: Fix common/ includes.
9775         * mi/mi-parse.h: Fix common/ includes.
9776         * mi/mi-main.c: Fix common/ includes.
9777         * mi/mi-cmd-env.c: Fix common/ includes.
9778         * memrange.h: Fix common/ includes.
9779         * memattr.c: Fix common/ includes.
9780         * maint.h: Fix common/ includes.
9781         * maint.c: Fix common/ includes.
9782         * main.c: Fix common/ includes.
9783         * machoread.c: Fix common/ includes.
9784         * location.c: Fix common/ includes.
9785         * linux-thread-db.c: Fix common/ includes.
9786         * linux-nat.c: Fix common/ includes.
9787         * linux-fork.c: Fix common/ includes.
9788         * inline-frame.c: Fix common/ includes.
9789         * infrun.c: Fix common/ includes.
9790         * inflow.c: Fix common/ includes.
9791         * inferior.h: Fix common/ includes.
9792         * inferior.c: Fix common/ includes.
9793         * infcmd.c: Fix common/ includes.
9794         * inf-ptrace.c: Fix common/ includes.
9795         * inf-child.c: Fix common/ includes.
9796         * ia64-linux-nat.c: Fix common/ includes.
9797         * i387-tdep.c: Fix common/ includes.
9798         * i386-tdep.c: Fix common/ includes.
9799         * i386-linux-tdep.c: Fix common/ includes.
9800         * i386-linux-nat.c: Fix common/ includes.
9801         * i386-go32-tdep.c: Fix common/ includes.
9802         * i386-fbsd-tdep.c: Fix common/ includes.
9803         * i386-fbsd-nat.c: Fix common/ includes.
9804         * guile/scm-type.c: Fix common/ includes.
9805         * guile/guile.c: Fix common/ includes.
9806         * go32-nat.c: Fix common/ includes.
9807         * gnu-nat.c: Fix common/ includes.
9808         * gdbthread.h: Fix common/ includes.
9809         * gdbarch-selftests.c: Fix common/ includes.
9810         * gdb_usleep.c: Fix common/ includes.
9811         * gdb_select.h: Fix common/ includes.
9812         * gdb_bfd.c: Fix common/ includes.
9813         * gcore.c: Fix common/ includes.
9814         * fork-child.c: Fix common/ includes.
9815         * findvar.c: Fix common/ includes.
9816         * fbsd-nat.c: Fix common/ includes.
9817         * event-top.c: Fix common/ includes.
9818         * event-loop.c: Fix common/ includes.
9819         * dwarf2read.c: Fix common/ includes.
9820         * dwarf2loc.c: Fix common/ includes.
9821         * dwarf2-frame.c: Fix common/ includes.
9822         * dwarf-index-cache.c: Fix common/ includes.
9823         * dtrace-probe.c: Fix common/ includes.
9824         * disasm-selftests.c: Fix common/ includes.
9825         * defs.h: Fix common/ includes.
9826         * csky-tdep.c: Fix common/ includes.
9827         * cp-valprint.c: Fix common/ includes.
9828         * cp-support.h: Fix common/ includes.
9829         * cp-support.c: Fix common/ includes.
9830         * corelow.c: Fix common/ includes.
9831         * completer.h: Fix common/ includes.
9832         * completer.c: Fix common/ includes.
9833         * compile/compile.c: Fix common/ includes.
9834         * compile/compile-loc2c.c: Fix common/ includes.
9835         * compile/compile-cplus-types.c: Fix common/ includes.
9836         * compile/compile-cplus-symbols.c: Fix common/ includes.
9837         * command.h: Fix common/ includes.
9838         * cli/cli-dump.c: Fix common/ includes.
9839         * cli/cli-cmds.c: Fix common/ includes.
9840         * charset.c: Fix common/ includes.
9841         * build-id.c: Fix common/ includes.
9842         * btrace.h: Fix common/ includes.
9843         * btrace.c: Fix common/ includes.
9844         * breakpoint.h: Fix common/ includes.
9845         * breakpoint.c: Fix common/ includes.
9846         * ax.h:
9847         (enum agent_op): Fix common/ includes.
9848         * ax-general.c (struct aop_map): Fix common/ includes.
9849         * ax-gdb.c: Fix common/ includes.
9850         * auxv.c: Fix common/ includes.
9851         * auto-load.c: Fix common/ includes.
9852         * arm-tdep.c: Fix common/ includes.
9853         * arch/riscv.c: Fix common/ includes.
9854         * arch/ppc-linux-common.c: Fix common/ includes.
9855         * arch/i386.c: Fix common/ includes.
9856         * arch/arm.c: Fix common/ includes.
9857         * arch/arm-linux.c: Fix common/ includes.
9858         * arch/arm-get-next-pcs.c: Fix common/ includes.
9859         * arch/amd64.c: Fix common/ includes.
9860         * arch/aarch64.c: Fix common/ includes.
9861         * arch/aarch64-insn.c: Fix common/ includes.
9862         * arch-utils.c: Fix common/ includes.
9863         * amd64-windows-tdep.c: Fix common/ includes.
9864         * amd64-tdep.c: Fix common/ includes.
9865         * amd64-sol2-tdep.c: Fix common/ includes.
9866         * amd64-obsd-tdep.c: Fix common/ includes.
9867         * amd64-nbsd-tdep.c: Fix common/ includes.
9868         * amd64-linux-tdep.c: Fix common/ includes.
9869         * amd64-linux-nat.c: Fix common/ includes.
9870         * amd64-fbsd-tdep.c: Fix common/ includes.
9871         * amd64-fbsd-nat.c: Fix common/ includes.
9872         * amd64-dicos-tdep.c: Fix common/ includes.
9873         * amd64-darwin-tdep.c: Fix common/ includes.
9874         * agent.c: Fix common/ includes.
9875         * ada-lang.h: Fix common/ includes.
9876         * ada-lang.c: Fix common/ includes.
9877         * aarch64-tdep.c: Fix common/ includes.
9878
9879 2019-01-25  Tom Tromey  <tom@tromey.com>
9880
9881         * common/create-version.sh: Use common/version.h.
9882
9883 2019-01-24  Pedro Alves  <palves@redhat.com>
9884
9885         * infrun.c (signal_stop, signal_print, signal_program)
9886         (signal_catch, signal_pass): Now arrays instead of pointers.
9887         (update_signals_program_target, do_target_resume)
9888         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9889         * linux-nat.c (linux_nat_target::pass_signals)
9890         (linux_nat_target::create_inferior, linux_nat_target::attach):
9891         Adjust.
9892         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9893         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9894         * procfs.c (procfs_target::pass_signals): Adjust.
9895         * record-full.c (record_full_target::resume): Adjust.
9896         * remote.c (remote_target::pass_signals)
9897         (remote_target::program_signals): Adjust.
9898         * target-debug.h (target_debug_print_signals): Now takes a
9899         gdb::array_view as parameter.  Adjust.
9900         * target.h (target_ops) <pass_signals, program_signals>: Replace
9901         pointer and length parameters with gdb::array_view.
9902         (target_pass_signals, target_program_signals): Likewise.
9903         * target-delegates.c: Regenerate.
9904
9905 2019-01-24  Pedro Alves  <palves@redhat.com>
9906
9907         * common/forward-scope-exit.h
9908         (forward_scope_exit::forward_scope_exit): Pass arguments to
9909         m_bind_function directly, instead of creating a std::bind and
9910         copying that.
9911
9912 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9913
9914         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9915         for static members.
9916         (pass_in_v_vfp_candidate): Likewise.
9917
9918 2019-01-23  Tom Tromey  <tom@tromey.com>
9919             Pedro Alves  <palves@redhat.com>
9920
9921         * regcache.c (class regcache_invalidator): Remove.
9922         (regcache::raw_write): Use make_scope_exit.
9923
9924 2019-01-23  Tom Tromey  <tom@tromey.com>
9925
9926         * ui-out.h (class ui_out_emit_type): Update comment.
9927
9928 2019-01-23  Tom Tromey  <tom@tromey.com>
9929
9930         * infrun.c (fetch_inferior_event): Update comment.
9931
9932 2019-01-23  Tom Tromey  <tom@tromey.com>
9933             Pedro Alves  <palves@redhat.com>
9934
9935         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9936         parameter.
9937         (fetch_inferior_event): Use SCOPE_EXIT.
9938
9939
9940 2019-01-23  Tom Tromey  <tom@tromey.com>
9941             Pedro Alves  <palves@redhat.com>
9942
9943         * infrun.c (disable_thread_events): Delete.
9944         (stop_all_threads): Use SCOPE_EXIT.
9945
9946 2019-01-23  Tom Tromey  <tom@tromey.com>
9947             Pedro Alves  <palves@redhat.com>
9948
9949         * symfile.c: Include forward-scope-exit.h.
9950         (clear_symtab_users_cleanup): Replace forward declaration with
9951         a FORWARD_SCOPE_EXIT.
9952         (syms_from_objfile_1): Use the forward_scope_exit and
9953         gdb::optional instead of cleanup_function.
9954         (reread_symbols): Use the forward_scope_exit instead of
9955         cleanup_function.
9956         (clear_symtab_users_cleanup): Remove function.
9957
9958 2019-01-23  Tom Tromey  <tom@tromey.com>
9959             Pedro Alves  <palves@redhat.com>
9960
9961         * linux-nat.c: Include scope-exit.h.
9962         (cleanup_target_stop): Remove.
9963         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9964         SCOPE_EXIT.
9965
9966 2019-01-23  Tom Tromey  <tom@tromey.com>
9967             Pedro Alves  <palves@redhat.com>
9968
9969         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9970         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9971
9972 2019-01-23  Tom Tromey  <tom@tromey.com>
9973             Andrew Burgess  <andrew.burgess@embecosm.com>
9974             Pedro Alves  <palves@redhat.com>
9975
9976         * infrun.c (fetch_inferior_event): Use scope_exit.
9977         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9978         * top.c (execute_command): Use scope_exit.
9979         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9980         * utils.c (do_bpstat_clear_actions_cleanup)
9981         (make_bpstat_clear_actions_cleanup): Remove.
9982
9983 2019-01-23  Tom Tromey  <tom@tromey.com>
9984             Pedro Alves  <palves@redhat.com>
9985
9986         * infrun.c: Include "common/scope-exit.h"
9987         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9988         (wait_for_inferior): Use SCOPE_EXIT.
9989         (fetch_inferior_event): Use scope_exit.
9990
9991 2019-01-23  Tom Tromey  <tom@tromey.com>
9992             Pedro Alves  <palves@redhat.com>
9993
9994         * breakpoint.c (create_breakpoint): Remove cleanup.
9995
9996 2019-01-23  Tom Tromey  <tom@tromey.com>
9997             Andrew Burgess  <andrew.burgess@embecosm.com>
9998             Pedro Alves  <palves@redhat.com>
9999
10000 2019-01-23  Pedro Alves  <palves@redhat.com>
10001
10002         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10003
10004 2019-01-23  Pedro Alves  <palves@redhat.com>
10005             Andrew Burgess  <andrew.burgess@embecosm.com>
10006
10007         * gdbthread.h: Include "common/forward-scope-exit.h".
10008         (scoped_finish_thread_state): Redefine custom class in terms of
10009         forward_scope_exit.
10010
10011 2019-01-23  Pedro Alves  <palves@redhat.com>
10012             Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * common/forward-scope-exit.h: New file.
10015
10016 2019-01-23  Pedro Alves  <palves@redhat.com>
10017             Andrew Burgess  <andrew.burgess@embecosm.com>
10018             Tom Tromey  <tom@tromey.com>
10019
10020         * common/scope-exit.h: New file.
10021
10022 2019-01-23  Pedro Alves  <palves@redhat.com>
10023
10024         * common/preprocessor.h (ESC): Rename to ...
10025         (ESC_PARENS): ... this.
10026         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10027         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10028
10029 2019-01-23  Tom Tromey  <tom@tromey.com>
10030
10031         * language.h (class scoped_switch_to_sym_language_if_auto):
10032         Initialize m_lang in both cases.
10033
10034 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10035
10036         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10037         with XCNEW.
10038
10039 2019-01-22  Tom Tromey  <tom@tromey.com>
10040
10041         * corelow.c: Do not include sys/file.h.
10042
10043 2019-01-22  Tom Tromey  <tom@tromey.com>
10044
10045         * tui/tui-wingeneral.h: Include gdb_curses.h.
10046
10047 2019-01-22  Tom Tromey  <tom@tromey.com>
10048
10049         * source-cache.h (class source_cache) <get_source_lines,
10050         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10051
10052 2019-01-22  Tom Tromey  <tom@tromey.com>
10053
10054         * remote-fileio.h (struct remote_target): Declare.
10055
10056 2019-01-22  Tom Tromey  <tom@tromey.com>
10057
10058         * python/py-arch.c: Do not include py-ref.h.
10059         * python/py-bpevent.c: Do not include py-ref.h.
10060         * python/py-cmd.c: Do not include py-ref.h.
10061         * python/py-continueevent.c: Do not include py-ref.h.
10062         * python/py-event.h: Do not include py-ref.h.
10063         * python/py-evtregistry.c: Do not include py-ref.h.
10064         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10065         * python/py-frame.c: Do not include py-ref.h.
10066         * python/py-framefilter.c: Do not include py-ref.h.
10067         * python/py-function.c: Do not include py-ref.h.
10068         * python/py-infevents.c: Do not include py-ref.h.
10069         * python/py-linetable.c: Do not include py-ref.h.
10070         * python/py-objfile.c: Do not include py-ref.h.
10071         * python/py-param.c: Do not include py-ref.h.
10072         * python/py-prettyprint.c: Do not include py-ref.h.
10073         * python/py-progspace.c: Do not include py-ref.h.
10074         * python/py-symbol.c: Do not include py-ref.h.
10075         * python/py-symtab.c: Do not include py-ref.h.
10076         * python/py-type.c: Do not include py-ref.h.
10077         * python/py-unwind.c: Do not include py-ref.h.
10078         * python/py-utils.c: Do not include py-ref.h.
10079         * python/py-value.c: Do not include py-ref.h.
10080         * python/py-varobj.c: Do not include py-ref.h.
10081         * python/py-xmethods.c: Do not include py-ref.h.
10082         * python/python.c: Do not include py-ref.h.
10083         * varobj.c: Do not include py-ref.h.
10084
10085 2019-01-22  Tom Tromey  <tom@tromey.com>
10086
10087         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10088         keyword for bcache.
10089
10090 2019-01-22  Tom Tromey  <tom@tromey.com>
10091
10092         * compile/compile-cplus-types.c: Remove a comment by #include.
10093
10094 2019-01-22  Tom Tromey  <tom@tromey.com>
10095
10096         * compile/gcc-c-plugin.h: Include compile-internal.h.
10097
10098 2019-01-22  Tom Tromey  <tom@tromey.com>
10099
10100         * stabsread.c (EXTERN): Do not define.
10101         (symnum, next_symbol_text_func, processing_gcc_compilation)
10102         (within_function, global_sym_chain, global_stabs)
10103         (previous_stab_code, this_object_header_files)
10104         (n_this_object_header_files)
10105         (n_allocated_this_object_header_files): Define.
10106         * stabsread.h (EXTERN): Never define.  Use "extern".
10107
10108 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10109
10110         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10111         history_value.
10112
10113 2019-01-21  Tom Tromey  <tom@tromey.com>
10114
10115         * ui-out.c: Fix includes.
10116         * tui/tui-source.c: Fix includes.
10117         * target.c: Fix includes.
10118         * remote.c: Fix includes.
10119         * regcache.c: Fix includes.
10120         * python/py-block.c: Fix includes.
10121         * printcmd.c: Fix includes.
10122         * or1k-tdep.c: Fix includes.
10123         * mi/mi-main.c: Fix includes.
10124         * m32r-tdep.c: Fix includes.
10125         * csky-tdep.c: Fix includes.
10126         * compile/compile-cplus-types.c: Fix includes.
10127         * cli/cli-interp.c: Fix includes.
10128
10129 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10130
10131         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10132         for padding.
10133
10134 2019-01-16  Tom Tromey  <tom@tromey.com>
10135
10136         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10137         earlier.
10138         (struct objfile) <msymbols_range>: Move from top level.
10139         <msymbols>: New method.
10140         (class objfile_msymbols): Remove.
10141         * symtab.c (default_collect_symbol_completion_matches_break_on):
10142         Update.
10143         * symmisc.c (dump_msymbols): Update.
10144         * stabsread.c (scan_file_globals): Update.
10145         * objc-lang.c (info_selectors_command, info_classes_command)
10146         (find_methods): Update.
10147         * minsyms.c (find_solib_trampoline_target): Update.
10148         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10149         * coffread.c (coff_symfile_read): Update.
10150         * ada-lang.c (ada_lookup_simple_minsym)
10151         (ada_collect_symbol_completion_matches): Update.
10152
10153 2019-01-16  Tom Tromey  <tom@tromey.com>
10154
10155         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10156         type.  Remove no-argument constructor.
10157         <iterator::operator++>: Simplify.
10158         <begin>: Update.
10159         <end>: Use minimal_symbol_count.
10160
10161 2019-01-16  Tom Tromey  <tom@tromey.com>
10162
10163         * objfiles.h (struct objfile) <psymtabs>: New method.
10164         (class objfile_psymtabs): Remove.
10165         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10166         typedef.
10167         <range>: New method.
10168         (require_partial_symbols): Change return type.
10169         * psymtab.c (require_partial_symbols)
10170         (psym_expand_symtabs_matching): Update.
10171         * mdebugread.c (parse_partial_symbols): Update.
10172         * dbxread.c (dbx_end_psymtab): Update.
10173
10174 2019-01-15  Tom Tromey  <tom@tromey.com>
10175
10176         * symtab.c (lookup_objfile_from_block)
10177         (lookup_symbol_in_objfile_symtabs)
10178         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10179         (find_line_symtab, info_sources_command)
10180         (default_collect_symbol_completion_matches_break_on)
10181         (make_source_files_completion_list): Update.
10182         * symmisc.c (print_objfile_statistics, dump_objfile)
10183         (maintenance_print_symbols, maintenance_info_symtabs)
10184         (maintenance_check_symtabs, maintenance_info_line_tables):
10185         Update.
10186         * source.c (select_source_symtab)
10187         (forget_cached_source_info_for_objfile): Update.
10188         * objfiles.h (class objfile_compunits): Remove.
10189         (struct objfile) <compunits_range>: New typedef.
10190         (compunits): New method.
10191         * objfiles.c (objfile_relocate1): Update.
10192         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10193         * maint.c (count_symtabs_and_blocks): Update.
10194         * linespec.c (iterate_over_all_matching_symtabs): Update.
10195         * cp-support.c (add_symbol_overload_list_qualified): Update.
10196         * coffread.c (coff_symtab_read): Update.
10197         * ada-lang.c (add_nonlocal_symbols)
10198         (ada_collect_symbol_completion_matches)
10199         (ada_add_global_exceptions): Update.
10200
10201 2019-01-15  Tom Tromey  <tom@tromey.com>
10202
10203         * progspace.h (program_space) <objfiles_safe_range>: New
10204         typedef.
10205         <objfiles_safe>: New method.
10206         * objfiles.h (class all_objfiles_safe): Remove.
10207         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10208         * jit.c (jit_inferior_exit_hook): Update.
10209
10210 2019-01-17  Tom Tromey  <tom@tromey.com>
10211
10212         * progspace.h (program_space) <objfiles_range>: New typedef.
10213         <objfiles>: New method.
10214         <objfiles_head>: Rename from objfiles.
10215         (object_files): Update.
10216         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10217         * guile/scm-pretty-print.c
10218         (ppscm_find_pretty_printer_from_objfiles): Update.
10219         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10220         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10221         Update.
10222         * python/py-progspace.c (pspy_get_objfiles): Update.
10223         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10224         Update.
10225         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10226         (objfpy_lookup_objfile_by_build_id): Update.
10227         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10228         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10229         Update.
10230         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10231         (expand_symtab_containing_pc, lookup_objfile_from_block)
10232         (lookup_static_symbol, basic_lookup_transparent_type)
10233         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10234         (find_line_symtab, info_sources_command)
10235         (default_collect_symbol_completion_matches_break_on)
10236         (make_source_files_completion_list, find_main_name): Update.
10237         * symmisc.c (print_symbol_bcache_statistics)
10238         (print_objfile_statistics, maintenance_print_symbols)
10239         (maintenance_print_msymbols, maintenance_print_objfiles)
10240         (maintenance_info_symtabs, maintenance_check_symtabs)
10241         (maintenance_expand_symtabs, maintenance_info_line_tables):
10242         Update.
10243         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10244         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10245         (map_overlay_command, unmap_overlay_command)
10246         (simple_overlay_update, expand_symtabs_matching)
10247         (map_symbol_filenames): Update.
10248         * symfile-debug.c (set_debug_symfile): Update.
10249         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10250         Update.
10251         * source.c (select_source_symtab, forget_cached_source_info):
10252         Update.
10253         * solib.c (solib_read_symbols): Update.
10254         * solib-spu.c (append_ocl_sos): Update.
10255         * psymtab.c (maintenance_print_psymbols)
10256         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10257         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10258         * printcmd.c (info_symbol_command): Update.
10259         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10260         Update.
10261         * objfiles.h (class all_objfiles): Remove.
10262         * objfiles.c (have_partial_symbols, have_full_symbols)
10263         (have_minimal_symbols, qsort_cmp, update_section_map)
10264         (shared_objfile_contains_address_p)
10265         (default_iterate_over_objfiles_in_search_order): Update.
10266         * objc-lang.c (info_selectors_command, info_classes_command)
10267         (find_methods): Update.
10268         * minsyms.c (find_solib_trampoline_target): Update.
10269         * maint.c (maintenance_info_sections)
10270         (maintenance_translate_address, count_symtabs_and_blocks):
10271         Update.
10272         * main.c (captured_main_1): Update.
10273         * linux-thread-db.c (try_thread_db_load_from_pdir)
10274         (has_libpthread): Update.
10275         * linespec.c (iterate_over_all_matching_symtabs)
10276         (search_minsyms_for_name): Update.
10277         * jit.c (jit_find_objf_with_entry_addr): Update.
10278         * hppa-tdep.c (find_unwind_entry)
10279         (hppa_lookup_stub_minimal_symbol): Update.
10280         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10281         Update.
10282         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10283         (elf_gnu_ifunc_resolve_by_got): Update.
10284         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10285         * dwarf-index-write.c (save_gdb_index_command): Update.
10286         * cp-support.c (add_symbol_overload_list_qualified): Update.
10287         * breakpoint.c (create_overlay_event_breakpoint)
10288         (create_longjmp_master_breakpoint)
10289         (create_std_terminate_master_breakpoint)
10290         (create_exception_master_breakpoint): Update.
10291         * blockframe.c (find_pc_partial_function): Update.
10292         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10293         (ada_collect_symbol_completion_matches)
10294         (ada_add_global_exceptions): Update.
10295
10296 2019-01-17  Tom Tromey  <tom@tromey.com>
10297
10298         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10299         declare VEC.
10300         (solib_target_parse_libraries): Change return type.
10301         (library_list_start_segment, library_list_start_section)
10302         (library_list_end_library, library_list_start_library); Update.
10303         (solib_target_free_library_list): Remove.
10304         (solib_target_parse_libraries): Remove cleanup.  Change return
10305         type.
10306         (solib_target_current_sos): Update.
10307
10308 2019-01-17  Tom Tromey  <tromey@bapiya>
10309
10310         * valprint.c: Replace "the the" with "the".
10311         * symtab.c: Replace "the the" with "the".
10312         * solib.c: Replace "the the" with "the".
10313         * solib-dsbt.c: Replace "the the" with "the".
10314         * linespec.c: Replace "the the" with "the".
10315         * dwarf2loc.h: Replace "the the" with "the".
10316         * amd64-windows-tdep.c: Replace "the the" with "the".
10317         * aarch64-tdep.c: Replace "the the" with "the".
10318
10319 2019-01-16  Keith Seitz  <keiths@redhat.com>
10320
10321         PR gdb/23773
10322         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10323         <builder>: Rename to ..
10324         <m_builder>: ... this and make private.
10325         (dwarf2_cu::get_builder): New method.  Change all users of
10326         `builder' to use this method.
10327         (dwarf2_start_symtab): Move to ...
10328         (dwarf2_cu::start_symtab): ... here.  Update all callers
10329         (setup_type_unit_groups): Move to ...
10330         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10331         callers.
10332         (dwarf2_cu::reset_builder): New method.
10333         (process_full_compunit, process_full_type_unit): Use
10334         dwarf2_cu::reset_builder.
10335         (follow_die_offset): Record the ancestor CU if it is different
10336         from the followed DIE's CU.
10337         (follow_die_sig_1): Likewise.
10338
10339 2019-01-15  Tom Tromey  <tom@tromey.com>
10340
10341         * remote.c (class remote_state) <buf>: Now a char_vector.
10342         <buf_size>: Remove.
10343         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10344         parameter.
10345         (remote_target::getpkt_or_notif_sane_1)
10346         (remote_target::getpkt_sane)
10347         (remote_target::getpkt_or_notif_sane): Likewise.
10348         (class remote_target) <putpkt>: New overload.
10349         (remote_target::read_frame): Change type of "buf_p".  Remove
10350         sizeof_p parameter.
10351         (packet_ok): New overload.
10352         (packet_check_result): New overload.
10353         Update all uses.
10354
10355 2019-01-14  Tom Tromey  <tom@tromey.com>
10356
10357         * remote-notif.c (handle_notification, remote_notif_ack)
10358         (remote_notif_parse): Make "buf" const.
10359         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10360         const.
10361         (remote_notif_parse, remote_notif_ack, handle_notification):
10362         Likewise.
10363         * remote.c (remote_notif_stop_parse): Make "buf" const.
10364         (remote_target::remote_parse_stop_reply): Make "buf" const.
10365         (remote_notif_stop_ack): Make "buf" const.
10366
10367 2019-01-14  Tom Tromey  <tom@tromey.com>
10368
10369         * remote.c (remote_console_output): Make parameter const.
10370
10371 2019-01-14  Tom Tromey  <tom@tromey.com>
10372
10373         * target-debug.h (target_debug_print_signals): Constify.
10374         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10375         * procfs.c (procfs_target::pass_signals): Update.
10376         * linux-nat.c (linux_nat_target::pass_signals): Update.
10377         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10378         * target-delegates.c: Rebuild.
10379         * remote.c (remote_target::program_signals): Update.
10380         (remote_target::pass_signals): Update.
10381         * target.c (target_pass_signals): Constify argument.
10382         (target_program_signals): Likewise.
10383         * target.h (struct target_ops) <pass_signals, program_signals>:
10384         Constify argument.
10385         (target_pass_signals, target_program_signals): Constify argument.
10386
10387 2019-01-14  Tom Tromey  <tom@tromey.com>
10388
10389         PR tui/28819:
10390         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10391
10392 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10393
10394         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10395         field.
10396         * rs6000-tdep.c: Include reggroups.h.
10397         (IS_V_ALIAS_PSEUDOREG): Define.
10398         (rs6000_register_name): Return names for the "vX" aliases.
10399         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10400         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10401         aliases.  Call default_register_reggroup_p for all other
10402         pseudo-registers.
10403         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10404         New functions.
10405         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10406         Handle "vX" aliases.
10407         (v_alias_pseudo_register_collect): New function.
10408         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10409         (rs6000_gdbarch_init): Initialize "vX" aliases as
10410         pseudo-registers.  Restore registration of
10411         rs6000_pseudo_register_reggroup_p with
10412         set_tdesc_pseudo_register_reggroup_p.
10413
10414 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10415
10416         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10417         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10418         set_gdbarch_num_pseudo_regs.
10419
10420 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10421
10422         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10423         Remove arg prefixname, add do_set and do_show.
10424         Add member functions set_list and show_list.
10425         * cli/cli-style.c (class cli_style_option): Update accordingly.
10426         (style_set_list): Move to file scope.
10427         (style_show_list): Likewise.
10428         (set_style): Call help_list.
10429         (show_style): Call cmd_show_list.
10430         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10431         Update to use the new macro.
10432
10433 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10434
10435         * ada-lang.c (_initialize_ada_language): Expand the help text
10436         for the "catch exception" command.
10437
10438 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10439
10440         * symtab.c (matching_obj_sections): Initialize obj,
10441         declare it closer to its usage.
10442
10443 2019-01-10  Tom Tromey  <tom@tromey.com>
10444
10445         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10446         (basic_inf_threads_range): Remove.
10447         (inf_threads_range, inf_non_exited_threads_range)
10448         (safe_inf_threads_range): Use next_adapter.
10449
10450 2019-01-10  Keith Seitz  <keiths@redhat.com>
10451
10452         PR gdb/23712
10453         PR symtab/23010
10454         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10455         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10456
10457 2019-01-10  Keith Seitz  <keiths@redhat.com>
10458
10459         PR gdb/23712
10460         PR symtab/23010
10461         * dictionary.c (pending_to_vector): Remove.
10462         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10463         Remove _1 suffix, replacing functions of the same name.  Update
10464         all callers.
10465         (dict_create_hashed, dict_create_hashed_expandable)
10466         (dict_create_linear, dict_create_linear_expandable, dict_free)
10467         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10468         Make functions static.
10469
10470 2019-01-10  Keith Seitz  <keiths@redhat.com>
10471
10472         PR gdb/23712
10473         PR symtab/23010
10474         * dictionary.h (struct dictionary): Replace declaration with
10475         multidictionary.
10476         (dict_create_hashed, dict_create_hashed_expandable)
10477         (dict_create_linear, dict_create_linear_expandable)
10478         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10479         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10480         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10481         taking multidictionary argument.
10482         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10483         * block.h (struct block) <dict>: Change to multidictionary
10484         and rename `multidict'.
10485         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10486         symmisc.c: Update all dictionary references to multidictionary.
10487
10488 2019-01-10  Keith Seitz  <keiths@redhat.com>
10489
10490         PR gdb/23712
10491         PR symtab/23010
10492         * dictionary.c: Include unordered_map.
10493         (pending_to_vector): New function.
10494         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10495         Rewrite the non-"_1" functions to take vector instead
10496         of linked list.
10497         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10498         "new" _1 versions of the same name.
10499         (multidictionary): Define.
10500         (std::hash<enum language): New definition.
10501         (collate_pending_symbols_by_language, mdict_create_hashed)
10502         (mdict_create_hashed_expandable, mdict_create_linear)
10503         (mdict_create_linear_expandable, mdict_free)
10504         (find_language_dictionary, create_new_language_dictionary)
10505         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10506         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10507         (mdict_size, mdict_empty): New functions.
10508         * dictionary.h (mdict_iterator): Define.
10509
10510 2019-01-10  Pedro Alves  <palves@redhat.com>
10511
10512         * breakpoint.c (read_uploaded_action)
10513         (create_tracepoint_from_upload): Adjust to use
10514         gdb::unique_xmalloc_ptr.
10515         * ctf.c (ctf_write_uploaded_tp):
10516         (SET_ARRAY_FIELD): Use emplace_back.
10517         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10518         * tracefile-tfile.c (tfile_write_uploaded_tp):
10519         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10520         gdb::unique_xmalloc_ptr.
10521         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10522         at_string, cond_string, cmd_strings>: Replace char pointers
10523         with gdb::unique_xmalloc_ptr.
10524
10525 2019-01-10  Pedro Alves  <palves@redhat.com>
10526
10527         * solib-target.c (library_list_start_library): Don't xstrdup name.
10528
10529 2019-01-10  Pedro Alves  <palves@redhat.com>
10530
10531         * mdebugread.c (parse_partial_symbols): Use
10532         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10533
10534 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10535
10536         * linux-fork.c (scoped_switch_fork_info)
10537         <~scoped_switch_fork_info>: Fix incorrect variable name.
10538
10539 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10540
10541         * linux-fork.c (scoped_switch_fork_info)
10542         <scoped_switch_fork_info>: Make explicit.
10543         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10544
10545 2019-01-10  Tom Tromey  <tom@tromey.com>
10546
10547         * objfiles.h (objfile::reset_psymtabs): Update.
10548         * objfiles.c (objfile::objfile): Update.
10549         * psymtab.h (psymtab_storage::obstack): Update.
10550         (psymtab_storage::m_obstack): Use gdb::optional.
10551         (class psymtab_storage): Update comment.  Remove objfile
10552         parameter.
10553         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10554
10555 2019-01-10  Tom Tromey  <tom@tromey.com>
10556
10557         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10558         <free_psymtabs>: Now private.
10559         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10560         (allocate_psymtab): Use new method.
10561
10562 2019-01-10  Tom Tromey  <tom@tromey.com>
10563
10564         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10565         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10566         * mdebugread.c (parse_partial_symbols): Use
10567         allocate_dependencies.
10568         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10569         allocate_dependencies.
10570         (process_psymtab_comp_unit_reader)
10571         (build_type_psymtab_dependencies): Likewise.
10572         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10573
10574 2019-01-10  Tom Tromey  <tom@tromey.com>
10575
10576         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10577         PSYMBOL_SET_LANGUAGE.
10578         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10579
10580 2019-01-10  Tom Tromey  <tom@tromey.com>
10581
10582         * psymtab.h (psymtab_storage::obstack): New method.
10583         <m_obstack>: Rename from obstack; now private.
10584         * psymtab.c (psymtab_storage): Update.
10585         * dwarf2read.c (create_addrmap_from_index)
10586         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10587         Update.
10588
10589 2019-01-10  Tom Tromey  <tom@tromey.com>
10590
10591         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10592         * objfiles.h (objfile::reset_psymtabs): New method.
10593
10594 2019-01-10  Tom Tromey  <tom@tromey.com>
10595
10596         * symmisc.c (print_symbol_bcache_statistics): Update.
10597         (print_objfile_statistics): Update.
10598         * symfile.c (reread_symbols): Update.
10599         * psymtab.h (class psymtab_storage): New.
10600         * psymtab.c (psymtab_storage): New constructor.
10601         (~psymtab_storage): New destructor.
10602         (require_partial_symbols): Update.
10603         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10604         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10605         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10606         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10607         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10608         (start_psymtab_common, end_psymtab_common)
10609         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10610         (allocate_psymtab): Update.
10611         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10612         Update.
10613         (dump_psymtab_addrmap, maintenance_print_psymbols)
10614         (maintenance_check_psymtabs): Update.
10615         (class objfile_psymtabs): Move to objfiles.h.
10616         * psympriv.h (discard_psymtab): Now inline.
10617         (psymtab_discarder::psymtab_discarder): Update.
10618         (psymtab_discarder::~psymtab_discarder): Update.
10619         (ALL_OBJFILE_PSYMTABS): Rewrite.
10620         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10621         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10622         Remove fields.
10623         <partial_symtabs>: New field.
10624         (class objfile_psymtabs): Move from psymtab.h.  Update.
10625         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10626         psymbol_cache.
10627         (objfile::~objfile): Don't destroy psymbol_cache.
10628         * mdebugread.c (parse_partial_symbols): Update.
10629         * dwarf2read.c (create_addrmap_from_index)
10630         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10631         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10632         (add_partial_subprogram, dwarf2_ranges_read): Update.
10633         * dwarf-index-write.c (write_address_map)
10634         (write_one_signatured_type, recursively_write_psymbols)
10635         (class debug_names, class debug_names, write_psymtabs_to_index):
10636         Update.
10637
10638 2019-01-10  Tom Tromey  <tom@tromey.com>
10639
10640         * symtab.h (SYMBOL_SET_NAMES): Update.
10641         (symbol_set_names): Update.
10642         (MSYMBOL_SET_NAMES): Update.
10643         * symtab.c (symbol_set_names): Change argument to be an
10644         objfile_per_bfd_storage.
10645         * psymtab.c (add_psymbol_to_bcache): Update.
10646         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10647
10648 2019-01-10  Tom Tromey  <tom@tromey.com>
10649
10650         * symtab.c (create_demangled_names_hash): Change argument to be an
10651         objfile_per_bfd_storage.
10652         (symbol_set_names): Update.
10653
10654 2019-01-10  Tom Tromey  <tom@tromey.com>
10655
10656         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10657         init_psymbol_list.
10658         * psymtab.c (init_psymbol_list): Do nothing if already called.
10659         * psympriv.h (init_psymbol_list): Add comment.
10660         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10661         init_psymbol_list.
10662         * dbxread.c (dbx_symfile_read): Unconditionally call
10663         init_psymbol_list.
10664
10665 2019-01-10  Tom Tromey  <tom@tromey.com>
10666
10667         * xcoffread.c (scan_xcoff_symtab): Update.
10668         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10669         "where".
10670         * mdebugread.c (parse_partial_symbols)
10671         (handle_psymbol_enumerators): Update.
10672         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10673         * dbxread.c (read_dbx_symtab): Update.
10674         * psympriv.h (psymbol_placement): New enum.
10675         (add_psymbol_to_list): Update.
10676
10677 2019-01-10  Tom Tromey  <tom@tromey.com>
10678
10679         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10680         static_psymbols parameters.
10681         (scan_xcoff_symtab): Update.
10682         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10683         static_psymbols parameters.
10684         * psympriv.h (start_psymtab_common): Update.
10685         * mdebugread.c (parse_partial_symbols): Update.
10686         * dwarf2read.c (create_partial_symtab): Update.
10687         * dbxread.c (read_dbx_symtab): Update.
10688         (start_psymtab): Remove global_psymbols and static_psymbols
10689         parameters.
10690
10691 2019-01-10  Tom Tromey  <tom@tromey.com>
10692
10693         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10694         * psymtab.c (allocate_psymtab): Add comment.
10695         * psympriv.h (allocate_psymtab): Add comment.
10696         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10697         initializations.
10698         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10699
10700 2019-01-10  Tom Tromey  <tom@tromey.com>
10701
10702         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10703         Don't declare.
10704         * mipsread.c: Include mdebugread.h.
10705         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10706         Declare.
10707         * elfread.c: Include mdebugread.h.
10708
10709 2019-01-09  Tom Tromey  <tom@tromey.com>
10710
10711         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10712         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10713         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10714         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10715         (psym_lookup_symbol, psym_find_last_source_symtab)
10716         (psym_forget_cached_source_info, psym_print_stats)
10717         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10718         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10719         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10720         (psym_find_compunit_symtab_by_address)
10721         (maintenance_print_psymbols, maintenance_info_psymtabs)
10722         (maintenance_check_psymtabs): Use ranged for.
10723         * psymtab.h (class objfile_psymtabs): New.
10724         (require_partial_symbols): Return objfile_psymtabs.
10725         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10726
10727 2019-01-09  Tom Tromey  <tom@tromey.com>
10728
10729         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10730         (find_pc_mapped_section, list_overlays_command)
10731         (map_overlay_command, unmap_overlay_command)
10732         (simple_overlay_update): Use all_objfiles.
10733         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10734         * printcmd.c (info_symbol_command): Use all_objfiles.
10735         * objfiles.h (ALL_OBJSECTIONS): Remove.
10736         * maint.c (maintenance_translate_address): Use all_objfiles.
10737         * gcore.c (gcore_create_callback): Use all_objfiles.
10738         (objfile_find_memory_regions): Likewise.
10739
10740 2019-01-09  Tom Tromey  <tom@tromey.com>
10741
10742         * symtab.c (find_line_symtab, info_sources_command)
10743         (make_source_files_completion_list): Use objfile_compunits.
10744         * source.c (select_source_symtab): Use objfile_compunits.
10745         * objfiles.h (struct objfile): Update comment.
10746         (ALL_OBJFILES): Remove.
10747         (ALL_FILETABS): Remove.
10748         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10749         objfile_compunits.
10750
10751 2019-01-09  Tom Tromey  <tom@tromey.com>
10752
10753         * symmisc.c (print_objfile_statistics, dump_objfile)
10754         (maintenance_print_symbols): Use compunit_filetabs.
10755         * source.c (forget_cached_source_info_for_objfile): Use
10756         compunit_filetabs.
10757         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10758         (ALL_FILETABS): Use compunit_filetabs.
10759         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10760         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10761
10762 2019-01-09  Tom Tromey  <tom@tromey.com>
10763
10764         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10765         (compunit_filetabs): New.
10766         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10767         compunit_filetabs.
10768         (info_sources_command, make_source_files_completion_list): Remove
10769         declaration.
10770         * symmisc.c (print_objfile_statistics, dump_objfile)
10771         (maintenance_print_symbols): Remove declaration.
10772         (maintenance_info_symtabs): Use compunit_filetabs.
10773         (maintenance_info_line_tables): Likewise.
10774         * source.c (select_source_symtab): Change local variable name.
10775         (forget_cached_source_info_for_objfile): Remove declaration.
10776         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10777         * objfiles.c (objfile_relocate1): Remove declaration.
10778         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10779         declaration.
10780         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10781         * coffread.c (coff_symtab_read): Remove declaration.
10782         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10783         compunit_filetabs.
10784
10785 2019-01-09  Tom Tromey  <tom@tromey.com>
10786
10787         * symtab.c (lookup_objfile_from_block)
10788         (find_pc_sect_compunit_symtab, search_symbols)
10789         (default_collect_symbol_completion_matches_break_on): Use
10790         objfile_compunits.
10791         * objfiles.h (ALL_COMPUNITS): Remove.
10792         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10793         * cp-support.c (add_symbol_overload_list_qualified): Use
10794         objfile_compunits.
10795         * ada-lang.c (ada_collect_symbol_completion_matches)
10796         (ada_add_global_exceptions): Use objfile_compunits.
10797
10798 2019-01-09  Tom Tromey  <tom@tromey.com>
10799
10800         * source.c (select_source_symtab)
10801         (forget_cached_source_info_for_objfile): Remove declaration.
10802         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10803         declaration.
10804         * maint.c (count_symtabs_and_blocks): Remove declaration.
10805         * cp-support.c (add_symbol_overload_list_qualified): Remove
10806         declaration.
10807         * coffread.c (coff_symtab_read): Remove declaration.
10808         * symtab.c (lookup_symbol_in_objfile_symtabs)
10809         (basic_lookup_transparent_type_1): Use objfile_compunits.
10810         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10811         (info_sources_command, search_symbols)
10812         (default_collect_symbol_completion_matches_break_on)
10813         (make_source_files_completion_list): Remove declaration.
10814         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10815         (ada_collect_symbol_completion_matches)
10816         (ada_add_global_exceptions): Remove declaration.
10817         * linespec.c (iterate_over_all_matching_symtabs): Use
10818         objfile_compunits.
10819         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10820         (class objfile_compunits): New.
10821         (ALL_COMPUNITS): Use objfile_compunits.
10822         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10823         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10824         objfile_compunits.
10825         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10826
10827 2019-01-09  Tom Tromey  <tom@tromey.com>
10828
10829         * symtab.c (search_symbols)
10830         (default_collect_symbol_completion_matches_break_on): Use
10831         objfile_msymbols.
10832         * ada-lang.c (ada_lookup_simple_minsym)
10833         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10834         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10835         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10836         objfile_msymbols.
10837         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10838         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10839         * objc-lang.c (find_methods): Use objfile_msymbols.
10840         (info_selectors_command, info_classes_command): Likewise.
10841         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10842         * objfiles.h (class objfile_msymbols): New.
10843         (ALL_OBJFILE_MSYMBOLS): Remove.
10844         (ALL_MSYMBOLS): Remove.
10845
10846 2019-01-09  Tom Tromey  <tom@tromey.com>
10847
10848         * common/next-iterator.h (next_adapter): Add Iterator template
10849         parameter.
10850         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10851         (class all_objfiles_safe): New.
10852         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10853         * objfiles.c (put_objfile_before): Update comment.
10854         (add_separate_debug_objfile): Likewise.
10855         (free_all_objfiles): Use all_objfiles_safe.
10856         (objfile_purge_solibs): Likewise.
10857
10858 2019-01-09  Tom Tromey  <tom@tromey.com>
10859
10860         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10861         (expand_symtab_containing_pc, lookup_static_symbol)
10862         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10863         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10864         all_objfiles.
10865         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10866         * breakpoint.c (create_overlay_event_breakpoint)
10867         (create_longjmp_master_breakpoint)
10868         (create_std_terminate_master_breakpoint)
10869         (create_exception_master_breakpoint): Use all_objfiles.
10870         * linux-thread-db.c (try_thread_db_load_from_pdir)
10871         (has_libpthread): Use all_objfiles.
10872         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10873         * linespec.c (iterate_over_all_matching_symtabs)
10874         (search_minsyms_for_name): Use all_objfiles.
10875         * maint.c (maintenance_info_sections): Use all_objfiles.
10876         * main.c (captured_main_1): Use all_objfiles.
10877         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10878         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10879         * guile/scm-pretty-print.c
10880         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10881         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10882         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10883         (maintenance_print_msymbols): Use all_objfiles.
10884         * source.c (select_source_symtab): Use all_objfiles.
10885         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10886         * symfile.c (remove_symbol_file_command)
10887         (expand_symtabs_matching, map_symbol_filenames): Use
10888         all_objfiles.
10889         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10890         all_objfiles.
10891         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10892         * objc-lang.c (find_methods): Use all_objfiles.
10893         * objfiles.c (have_partial_symbols, have_full_symbols)
10894         (have_minimal_symbols, qsort_cmp)
10895         (default_iterate_over_objfiles_in_search_order): Use
10896         all_objfiles.
10897         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10898         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10899         (maintenance_check_psymtabs): Use all_objfiles.
10900         (ALL_PSYMTABS): Remove.
10901         * compile/compile-object-run.c (do_module_cleanup): Use
10902         all_objfiles.
10903         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10904         * cp-support.c (add_symbol_overload_list_qualified): Use
10905         all_objfiles.
10906         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10907         Use all_objfiles.
10908         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10909         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10910         all_objfiles.
10911         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10912         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10913         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10914         Uses all_objfiles.
10915         * solib.c (solib_read_symbols): Use all_objfiles
10916
10917 2019-01-09  Tom Tromey  <tom@tromey.com>
10918
10919         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10920         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10921         all_objfiles.
10922         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10923         * symmisc.c (print_symbol_bcache_statistics)
10924         (print_objfile_statistics, maintenance_print_objfiles)
10925         (maintenance_info_symtabs, maintenance_check_symtabs)
10926         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10927         all_objfiles.
10928         * source.c (forget_cached_source_info): Use all_objfiles.
10929         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10930         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10931         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10932         * objfiles.c (update_section_map): Use all_objfiles.
10933         (shared_objfile_contains_address_p): Likewise.
10934         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10935         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10936
10937 2019-01-09  Tom Tromey  <tom@tromey.com>
10938
10939         * common/next-iterator.h: New file.
10940         * objfiles.h (class all_objfiles): New.
10941         (struct objfile_iterator): New.
10942
10943 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10944
10945         * NEWS: Move the description of the changed "frame", "select-frame",
10946          and "info frame" commands to the Changed commands section.
10947
10948 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10949
10950         * gdbtypes.c (check_stub_method_group): Remove handling of old
10951         mangling schemes.
10952         * linespec.c (find_methods): Likewise.
10953         * stabsread.c (read_member_functions): Likewise.
10954         * valops.c (search_struct_method): Likewise.
10955         (value_struct_elt_for_reference): Likewise.
10956         * NEWS: Mention this change.
10957
10958 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10959
10960         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10961         print_source_lines.
10962         * source.c (print_source_lines_base): Update line number check.
10963         (print_source_lines): New function.
10964         (source_lines_range::source_lines_range): New function.
10965         * source.h (class source_lines_range): New class.
10966         (print_source_lines): New declaration.
10967
10968 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10969
10970         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10971
10972 2019-01-08  Tom Tromey  <tom@tromey.com>
10973             Simon Marchi  <simon.marchi@ericsson.com>
10974
10975         PR gdb/24060
10976         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10977         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10978         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10979         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10980         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10981         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10982
10983 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10984
10985         * source.c (select_source_symtab): Move header comment to
10986         declaration in source.h.
10987         (forget_cached_source_info_for_objfile): Likewise.
10988         (forget_cached_source_info): Likewise.
10989         (identify_source_line): Likewise.
10990         * source.h (identify_source_line): Move declaration from symtab.h
10991         and add comment from source.c
10992         (print_source_lines): Likewise.
10993         (forget_cached_source_info_for_objfile): Likewise.
10994         (forget_cached_source_info): Likewise.
10995         (select_source_symtab): Likewise.
10996         (enum print_source_lines_flag): Move definition from symtab.h.
10997         * symtab.h (identify_source_line): Move declaration to source.h.
10998         (print_source_lines): Likewise.
10999         (forget_cached_source_info_for_objfile): Likewise.
11000         (forget_cached_source_info): Likewise.
11001         (select_source_symtab): Likewise.
11002         (enum print_source_lines_flag): Move definition to source.h.
11003         * tui/tui-hooks.c: Add 'source.h' include.
11004
11005 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11006
11007         * source.c (print_source_lines_base): Handle requests to print
11008         reverse line number sequences, and guard against empty lines
11009         string.
11010
11011 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11012
11013         * source.c (print_source_lines_base): Fix skip of '\r' if next
11014         character is '\n'.
11015
11016 2019-01-06  Tom Tromey  <tom@tromey.com>
11017
11018         * c-exp.y (struct c_parse_state) <macro_original_text,
11019         expansion_obstack>: New member.
11020         (macro_original_text, expansion_obstack): Remove globals.
11021         (scan_macro_expansion, scanning_macro_expansion)
11022         (finished_macro_expansion): Update.
11023         (scan_macro_cleanup): Remove.
11024         (yylex, c_parse): Update.
11025
11026 2019-01-06  Tom Tromey  <tom@tromey.com>
11027
11028         * c-exp.y (struct c_parse_state) <strings>: New member.
11029         (operator_stoken): Update.
11030
11031 2019-01-06  Tom Tromey  <tom@tromey.com>
11032
11033         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11034         (union type_stack_elt) <typelist_val>: Now a pointer to
11035         std::vector.
11036         (type_stack_cleanup): Don't declare.
11037         (push_typelist): Update.
11038         * parse.c (pop_typelist): Return a std::vector.
11039         (push_typelist): Take a std::vector.
11040         (follow_types): Update.  Do not free args.
11041         (type_stack_cleanup): Remove.
11042         * c-exp.y (struct c_parse_state): New.
11043         (cpstate): New global.
11044         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11045         (nonempty_typelist): Update.
11046         (func_mod): Create a new vector.
11047         (c_parse): Create a c_parse_state.
11048         (check_parameter_typelist): Do not delete params.
11049         (function_method): Update.  Do not delete type_list.
11050
11051 2019-01-06  Tom Tromey  <tom@tromey.com>
11052
11053         PR gdb/28155:
11054         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11055         check_typedef.
11056         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11057         (print_return_value): Likewise.
11058
11059 2019-01-05  Tom Tromey  <tom@tromey.com>
11060
11061         * contrib/cleanup_check.py: Remove.
11062         * contrib/gcc-with-excheck: Remove.
11063         * contrib/exsummary.py: Remove.
11064         * contrib/excheck.py: Remove.
11065
11066 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11067
11068         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11069         NULL. Initialize tpprev to NULL instead of assigning it
11070         to NULL on the next statement.
11071         * windows-nat.c (windows_delete_thread): Remove check for
11072         main_thread_id before printing thread exit notifications.
11073         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11074         Remove thread ID check against main_thread_id.
11075         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11076         windows_delete_thread.
11077         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11078
11079 2019-01-04  Tom Tromey  <tom@tromey.com>
11080
11081         * compile/compile.c (_initialize_compile): Use upper case for
11082         metasyntactic variables.
11083         * symmisc.c (_initialize_symmisc): Use upper case for
11084         metasyntactic variables.
11085         * psymtab.c (_initialize_psymtab): Use upper case for
11086         metasyntactic variables.
11087         * demangle.c (demangle_command): Use upper case for metasyntactic
11088         variables.
11089         (_initialize_demangler): Likewise.
11090         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11091         variables.
11092
11093 2019-01-03  Tom Tromey  <tom@tromey.com>
11094
11095         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11096
11097 2019-01-03  Tom Tromey  <tom@tromey.com>
11098
11099         * python/py-symtab.c (salpy_str): Update.
11100         (struct salpy_sal_object) <symtab>: Now a PyObject.
11101         (salpy_dealloc): Update.
11102         (del_objfile_sal): Use gdbpy_ref.
11103
11104 2019-01-03  Tom Tromey  <tom@tromey.com>
11105
11106         * python/py-type.c (convert_field): Use new_reference.  Return
11107         gdbpy_ref.
11108         (make_fielditem): Return gdbpy_ref.
11109         (typy_fields): Update.
11110         (typy_getitem): Update.
11111         (field_name): Return gdbpy_ref.  Use new_reference.
11112         (typy_iterator_iternext): Update.
11113
11114 2019-01-03  Tom Tromey  <tom@tromey.com>
11115
11116         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11117
11118 2019-01-03  Tom Tromey  <tom@tromey.com>
11119
11120         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11121         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11122         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11123         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11124         (pspy_set_type_printers): Likewise.
11125         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11126         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11127         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11128         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11129         (objfpy_set_type_printers): Likewise.
11130
11131 2019-01-03  Tom Tromey  <tom@tromey.com>
11132
11133         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11134         (gdbpy_print_stack): Use gdbpy_err_fetch.
11135         * python/python-internal.h (class gdbpy_err_fetch): New class.
11136         (class gdbpy_enter) <m_error_type, m_error_value,
11137         m_error_traceback>: Remove.
11138         <m_error>: New member.
11139         (gdbpy_exception_to_string): Don't declare.
11140         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11141         * python/py-value.c (convert_value_from_python): Use
11142         gdbpy_err_fetch.
11143         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11144         gdbpy_exception_to_string.
11145         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11146         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11147         gdbpy_err_fetch.
11148
11149 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11150
11151         * linux-nat.c (delete_lwp_cleanup): Delete.
11152         (struct lwp_deleter): New struct.
11153         (lwp_info_up): New typedef.
11154         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11155         lwp_info_up.
11156
11157 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11158
11159         * linux-fork.c (class scoped_switch_fork_info): New class.
11160         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11161
11162 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11163
11164         * valops.c (find_overload_match): Remove use of null_cleanup, and
11165         calls to do_cleanups.
11166
11167 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11168
11169         * compile/compile-cplus-types.c
11170         (compile_cplus_instance::decl_name): Handle changes to
11171         cp_func_name.
11172         * cp-support.c (cp_func_name): Update header comment, update
11173         return type.
11174         * cp-support.h (cp_func_name): Update return type in declaration.
11175         * valops.c (find_overload_match): Move temp_func local to top
11176         level of function and change its type.  Use temp_func to hold and
11177         delete temporary string obtained from cp_func_name.
11178
11179 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11182         gdb::char_vector, remove cleanup, and update uses of `msg`.
11183
11184 2019-01-03  Jim Wilson  <jimw@sifive.com>
11185
11186         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11187
11188 2019-01-02  Tom Tromey  <tom@tromey.com>
11189
11190         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11191         (tdesc_parse_xml): Remove cleanups.
11192         * target-descriptions.h (make_cleanup_free_target_description):
11193         Don't declare.
11194         (target_desc_deleter): New struct.
11195         (target_desc_up): New typedef.
11196         * target-descriptions.c (target_desc_deleter::operator()): Rename
11197         from free_target_description.
11198         (make_cleanup_free_target_description): Remove.
11199
11200 2019-01-02  Tom Tromey  <tom@tromey.com>
11201
11202         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11203         constructor, destructor.
11204         (linespec_parser): Remove typedef.
11205         (~linespec_parser): Rename from linespec_parser_delete.
11206         (linespec_lex_to_end, linespec_complete_label)
11207         (linespec_complete): Update.
11208         (decode_line_full): Remove cleanups.
11209         (decode_line_1): Update.
11210
11211 2019-01-02  Tom Tromey  <tom@tromey.com>
11212
11213         * python/python-internal.h (inferior_to_inferior_object): Change
11214         return type.
11215         * python/py-exitedevent.c (create_exited_event_object): Update.
11216         * python/py-inferior.c (inferior_to_inferior_object): Return
11217         gdbpy_ref.
11218         (python_new_inferior, python_inferior_deleted)
11219         (thread_to_thread_object, delete_thread_object)
11220         (build_inferior_list, gdbpy_selected_inferior): Update.
11221         * python/py-infthread.c (create_thread_object): Update.  Also fail
11222         if inferior_to_inferior_object fails.
11223
11224 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11225
11226         * inferior.h (class inferior) <displaced_step_state>: New field.
11227         * infrun.h (struct displaced_step_state): Move here from
11228         infrun.c.  Initialize fields, add constructor.
11229         <inf>: Remove field.
11230         <reset>: New method.
11231         * infrun.c (struct displaced_step_inferior_state): Move to
11232         infrun.h.
11233         (displaced_step_inferior_states): Remove.
11234         (get_displaced_stepping_state): Adust.
11235         (displaced_step_in_progress_any_inferior): Adjust.
11236         (displaced_step_in_progress_thread): Adjust.
11237         (displaced_step_in_progress): Adjust.
11238         (add_displaced_stepping_state): Remove.
11239         (get_displaced_step_closure_by_addr): Adjust.
11240         (remove_displaced_stepping_state): Remove.
11241         (infrun_inferior_exit): Call displaced_step_state.reset.
11242         (use_displaced_stepping): Don't check for NULL.
11243         (displaced_step_prepare_throw): Call
11244         get_displaced_stepping_state.
11245         (displaced_step_fixup): Don't check for NULL.
11246         (prepare_for_detach): Don't check for NULL.
11247
11248 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11249
11250         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11251          in case of call that did not complete.
11252
11253 2019-01-02  Andrey Utkin  <autkin@undo.io>
11254
11255         * symfile.c (find_separate_debug_file): Fix search of debug files for
11256         remote debuggee.
11257
11258 2019-01-02  Tom Tromey  <tom@tromey.com>
11259
11260         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11261         indentation.
11262         * python/py-frame.c (frapy_older): Remove cast.
11263         (frapy_newer): Likewise.
11264         * python/py-breakpoint.c (local_setattro): Remove cast.
11265         * python/py-arch.c (archpy_name): Remove local variable.
11266         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11267
11268 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11269
11270         * unittests/basic_string_view/element_access/char/empty.cc:
11271         Fix year range in copyright header.
11272
11273 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11274
11275         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11276         Delete.
11277         <operator==>: Update with for removed field.
11278         <hash>: Likewise.
11279         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11280         <isa_features>: ...this.
11281         <abi_features>: New field.
11282         (riscv_isa_flen): Update comment.
11283         (riscv_abi_xlen): New declaration.
11284         (riscv_abi_flen): New declaration.
11285         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11286         isa_features.
11287         (riscv_abi_xlen): New function.
11288         (riscv_isa_flen): Update to get answer from isa_features.
11289         (riscv_abi_flen): New function.
11290         (riscv_has_fp_abi): Update to get answer from abi_features.
11291         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11292         xlen and flen.
11293         (riscv_call_info) <xlen, flen>: Update comment.
11294         (riscv_call_arg_struct): Remove invalid assertions
11295         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11296         is removed.
11297         (riscv_gdbarch_init): Gather isa features and abi features
11298         separately, ensure both match on the gdbarch when reusing an old
11299         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11300         a target with 64-bit float hardware.
11301
11302 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11303
11304         * source.c (search_command_helper): Stop reverse search
11305         when line 1 has been searched.
11306
11307 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11308
11309         * record-full.c (record_full_base_target::close): Rewrite
11310         record_full_core_buf_list free logic.
11311
11312 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11313
11314         * break-catch-syscall.c (print_one_catch_syscall): xfree
11315         the last text.
11316
11317 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11318
11319         * top.c (print_gdb_version): Update Copyright year in version
11320         message.
11321
11322 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11323
11324         Update copyright year range in all GDB files.
11325
11326 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11327
11328         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11329
11330 For older changes see ChangeLog-2018.
11331 \f
11332 Local Variables:
11333 mode: change-log
11334 left-margin: 8
11335 fill-column: 74
11336 version-control: never
11337 coding: utf-8
11338 End:
11339