gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
   4         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
   5         tui_refresh_data_win.
   6         * tui/tui-win.c (tui_source_window_base::refresh_all): New
   7         method.
   8         (tui_refresh_all_win): Call the refresh_all method.
   9         (tui_set_focus): Likewise.
  10         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
  11         (struct tui_source_window_base, struct tui_data_window) <refresh>:
  12         Likewise.
  13
  14 2019-06-25  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-winsource.h (tui_refill_source_window)
  17         (tui_set_is_exec_point_at): Don't declare.
  18         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  19         (tui_source_window_base::refill): Rename from
  20         tui_refill_source_window.
  21         (tui_source_window_base::do_scroll_horizontal): Update.
  22         (tui_source_window_base::set_is_exec_point_at): Rename from
  23         tui_set_is_exec_point_at.
  24         (tui_update_all_breakpoint_info): Update.
  25         * tui/tui-stack.c (tui_show_frame_info): Update.
  26         * tui/tui-layout.c (show_data): Add cast.
  27         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
  28         * tui/tui-data.h (struct tui_source_window_base) <refill,
  29         set_is_exec_point_at>: New methods.
  30         (tui_source_windows, tui_add_to_source_windows): Update types.
  31         (tui_add_to_source_windows): Remove redundant declaration.
  32         * tui/tui-data.c (source_windows): Store tui_source_window_base.
  33         (tui_source_windows): Change return type.
  34         (tui_clear_source_windows_detail): Update.
  35         (tui_add_to_source_windows): Change type of parameter.
  36         (tui_free_all_source_wins_content): Update.
  37
  38 2019-06-25  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-wingeneral.c (tui_win_info::refresh)
  41         (tui_source_window_base::refresh): New methods.
  42         (tui_refresh_all): Call the refresh method.
  43         * tui/tui-data.h (struct tui_win_info)
  44         (struct tui_source_window_base) <refresh>: New method.
  45
  46 2019-06-25  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui.h (tui_is_window_visible): Return bool.
  49         * tui/tui.c (tui_is_window_visible): Return bool.
  50         * tui/tui-wingeneral.c (tui_make_window, make_visible)
  51         (tui_make_visible, tui_make_invisible)
  52         (tui_win_info::make_visible)
  53         (tui_source_window_base::make_visible, make_all_visible)
  54         (tui_make_all_visible, tui_make_all_invisible): Update.
  55         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
  56         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
  57         bool.
  58         (struct tui_win_info, struct tui_source_window_base)
  59         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
  60         * tui/tui-data.c (tui_init_generic_part): Update.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-wingeneral.c (tui_win_info::make_visible)
  65         (tui_source_window_base::make_visible): New methods.
  66         (make_all_visible): Make method call.
  67         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
  68         (struct tui_source_window_base, struct tui_cmd_window): Override
  69         make_visible.
  70         (tui_win_is_source_type): Don't declare.
  71         * tui/tui-data.c (tui_win_is_source_type): Remove.
  72
  73 2019-06-25  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
  76         NULL check.
  77
  78 2019-06-25  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
  81         Inline constructor.  Add initializers for members.
  82         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
  83         constructors; now inline in class.
  84
  85 2019-06-25  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui-regs.c (tui_show_registers): Update.
  88         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
  89         bool.
  90         * tui/tui-data.c (tui_data_window::clear_detail)
  91         (tui_data_window): Update.
  92
  93 2019-06-25  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-windata.c (tui_display_all_data)
  96         (tui_display_data_from_line, tui_display_data_from)
  97         (tui_check_data_values, tui_data_window::do_scroll_vertical):
  98         Update.
  99         * tui/tui-regs.c (tui_last_regs_line_no)
 100         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 101         (tui_show_registers, tui_show_register_group)
 102         (tui_display_registers_from, tui_display_reg_element_at_line)
 103         (tui_display_registers_from_line, tui_check_register_values)
 104         (tui_reg_next, tui_reg_prev): Update.
 105         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 106         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 107         tui_data_window.
 108         (struct tui_win_info) <detail>: Remove.  Add new fields from
 109         tui_data_info.
 110         (TUI_DATA_WIN): Add cast.
 111         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 112         (~tui_data_window): Simplify.
 113
 114 2019-06-25  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-layout.c (show_source_disasm_command)
 117         (show_source_or_disasm_and_command): Update.
 118         * tui/tui-io.c (update_cmdwin_start_line)
 119         (tui_redisplay_readline): Update.
 120         * tui/tui-data.h (struct tui_command_info): Remove.
 121         (struct tui_win_info) <detail>: Remove command_info member.
 122         (struct tui_data_window) <start_line>: New member, from
 123         tui_command_info.
 124         (TUI_CMD_WIN): Add casts.
 125
 126 2019-06-25  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-winsource.c (tui_update_source_window)
 129         (tui_refill_source_window)
 130         (tui_source_window_base::do_scroll_horizontal)
 131         (tui_update_breakpoint_info, tui_set_exec_info_content)
 132         (tui_show_exec_info_content, tui_erase_exec_info_content)
 133         (tui_clear_exec_info_content): Update.
 134         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 135         Update.
 136         * tui/tui-win.c (make_invisible_and_set_new_height)
 137         (make_visible_with_new_height): Update.
 138         * tui/tui-source.c (tui_set_source_content)
 139         (tui_show_symtab_source): Update.
 140         * tui/tui-layout.c (extract_display_start_addr)
 141         (show_source_disasm_command, show_data)
 142         (make_source_or_disasm_window)
 143         (show_source_or_disasm_and_command): Update.
 144         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 145         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 146         "gdbarch".
 147         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 148         to tui_source_window_base.
 149         (struct tui_win_info) <detail>: Remove source_info member.
 150         (struct tui_source_window_base) <has_locator>: Inline.
 151         Move contents from tui_source_info; rename has_locator member to
 152         m_has_locator.
 153         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 154         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 155         header file.
 156         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 157         Simplify.
 158         (tui_free_all_source_wins_content): Cast to
 159         tui_source_window_base.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-win.c (make_invisible_and_set_new_height)
 164         (make_visible_with_new_height): Call has_locator method.
 165         * tui/tui-layout.c (show_source_disasm_command, show_data)
 166         (show_source_or_disasm_and_command): Update for bool change.
 167         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 168         (tui_win_info) <has_locator>: New method.
 169         (struct tui_source_window_base) <has_locator>: New method.
 170         (tui_win_has_locator): Don't declare.
 171         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 172         from tui_win_has_locator.
 173         (tui_source_window_base): Use false, not FALSE.
 174
 175 2019-06-25  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 178         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 179         clear_detail method directly.
 180         (tui_clear_win_detail): Remove.
 181
 182 2019-06-25  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 185         "this", not TUI_DISASM_WIN.
 186
 187 2019-06-25  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 190         declare.
 191         * tui/tui-winsource.c
 192         (tui_source_window_base::do_scroll_horizontal): Rename from
 193         tui_horizontal_source_scroll.
 194         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 195         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 196         from tui_vertical_data_scroll.
 197         * tui/tui-win.h (tui_scroll): Don't declare.
 198         * tui/tui-win.c (tui_win_info::forward_scroll)
 199         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 200         (tui_win_info::right_scroll): Rename and update.
 201         (tui_scroll_forward_command, tui_scroll_backward_command)
 202         (tui_scroll_left_command, tui_scroll_right_command): Update.
 203         (tui_scroll): Remove.
 204         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 205         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 206         from tui_vertical_source_scroll.
 207         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 208         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 209         from tui_vertical_disassem_scroll.
 210         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 211         do_scroll_horizontal>: New methods.
 212         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 213         Likewise.
 214         (struct tui_source_window_base): Add do_scroll_horizontal.
 215         (struct tui_source_window, struct tui_disasm_window): Add
 216         do_scroll_vertical.
 217         (struct tui_data_window, struct tui_cmd_window): Add
 218         do_scroll_horizontal and do_scroll_vertical.
 219         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 220
 221 2019-06-25  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-data.h (struct tui_source_window_base): New struct.
 224         (struct tui_source_window): Derive from tui_source_window_base.
 225         (struct tui_disasm_window): New struct.
 226         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 227         from tui_source_window::clear_detail.
 228         (tui_source_window_base): Rename from tui_source_window.
 229         (~tui_source_window_base): Rename from ~tui_source_window.
 230         (tui_alloc_win_info): Create a tui_disasm_window.
 231
 232 2019-06-25  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-data.h (struct tui_source_window)
 235         (struct tui_data_window): Declare destructors.
 236         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 237         destructors.
 238         (tui_win_info): Simplify.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-winsource.c (tui_display_main)
 243         (tui_update_source_windows_with_addr)
 244         (tui_update_all_breakpoint_info): Update.
 245         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 246         (new_height_ok, parse_scrolling_args): Update.
 247         * tui/tui-stack.c (tui_show_frame_info): Update.
 248         * tui/tui-data.h (struct tui_list): Remove.
 249         (tui_source_windows): Return a reference to a std::vector.
 250         * tui/tui-data.c (source_windows): Now a std::vector.
 251         (tui_source_windows): Change return type.
 252         (tui_clear_source_windows): Rewrite.
 253         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 254         (tui_free_all_source_wins_content): Rewrite.
 255
 256 2019-06-25  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 259         (struct tui_data_window, struct tui_cmd_window): Declare
 260         clear_detail method.
 261         * tui/tui-data.c (tui_source_window::clear_detail)
 262         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 263         methods.
 264         (tui_clear_win_detail): Simplify.
 265
 266 2019-06-25  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-layout.c (make_source_window, make_disasm_window)
 269         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 270         Return the new window.
 271         (show_source_disasm_command, show_data)
 272         (show_source_or_disasm_and_command): Update.
 273
 274 2019-06-25  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 277         parameter.  Return the new window.
 278         (show_source_disasm_command): Update and remove NULL check.
 279         (show_source_or_disasm_and_command): Update.
 280
 281 2019-06-25  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 284
 285 2019-06-25  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-data.h (struct tui_win_info): Make constructor
 288         protected.  Make destructor virtual.  Add initializers.
 289         (tui_source_window, tui_data_window, tui_cmd_window): New
 290         classes.
 291         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 292         constructor.  Add "type" parameter.
 293         (tui_source_window, tui_data_window, tui_cmd_window): New
 294         constructors.
 295         (tui_alloc_win_info): Instantiate the appropriate subclass.
 296
 297 2019-06-25  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-win.c (tui_resize_all): Use delete.
 300         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 301         destructor.
 302         (tui_free_window): Don't declare.
 303         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 304         Update.
 305
 306 2019-06-25  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-data.h (struct tui_win_info): Add constructor.
 309         * tui/tui-data.c (tui_alloc_win_info): Use new.
 310         (tui_free_window): Use delete.
 311
 312 2019-06-22  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 315         declare.
 316         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 317
 318 2019-06-22  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 321         declare.
 322         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 323
 324 2019-06-22  Tom de Vries  <tdevries@suse.de>
 325
 326         * dwarf2read.c (create_addrmap_from_aranges)
 327         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 328         instead of '%zu'.
 329
 330 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 331
 332         * dwarf2read.h (dwarf2_section_info_def): Remove.
 333         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 334         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 335         std::vector<dwarf2_section_info>.
 336         (struct dwo_file) <~dwo_file>: Remove.
 337         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 338         types field.
 339         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 340         (dwarf2_read_debug_names): Likewise.
 341         (create_debug_types_hash_table): Change parameter type to
 342         array_view, adjust code accordingly.
 343         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 344         (partial_die_info::fixup): Likewise.
 345         (determine_prefix): Likewise.
 346         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 347
 348 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 349
 350         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 351         gdb_bfd_ref_ptr.
 352         <~dwo_file>: Remove call to gdb_bfd_unref.
 353         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 354         gdb_bfd_ref_ptr::get.
 355
 356 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 357
 358         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 359         type to htab_up.
 360         * dwarf2read.c (struct dwo_file): Initialize fields.
 361         <~dwo_file>: New.
 362         (free_dwo_file): Remove, move content to ~dwo_file.
 363         (struct dwo_file_deleter): Remove.
 364         (dwo_file_up>: Remove custom deleter.
 365         (free_dwo_files): Remove.
 366         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 367         dwo_files.
 368         (process_skeletonless_type_units): Call unique_ptr::get.
 369         (allocate_dwo_file_hash_table): Add deleter to created hash
 370         table.  Change return type to htab_up.
 371         (lookup_dwo_file_slot): Don't memset dwo_file, call
 372         unique_ptr::get.
 373         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 374         (create_dwo_unit_in_dwp_v2): Likewise.
 375         (open_and_init_dwo_file): Likewise.
 376         (free_dwo_file_from_slot): Remove.
 377
 378 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 379
 380         * dwarf2read.h (struct dwarf2_section_info) <readin,
 381         is_virtual>: Change type to bool.
 382         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 383         true instead of 1.
 384
 385 2019-06-19  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-data.h (tui_init_content_element): Don't declare.
 388
 389 2019-06-19  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-data.h (tui_init_win_info): Don't declare.
 392
 393 2019-06-19  Tom de Vries  <tdevries@suse.de>
 394
 395         * dwarf2read.h (abstract_to_concrete): Change type to
 396         std::unordered_map<sect_offset, std::vector<sect_offset>,
 397         gdb::hash_enum<sect_offset>>.
 398
 399 2019-06-19  Tom Tromey  <tromey@adacore.com>
 400
 401         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 402         EVAL_AVOID_SIDE_EFFECTS specially.
 403
 404 2019-06-19  Tom Tromey  <tromey@adacore.com>
 405
 406         * source-cache.c (highlighter): New global.
 407         (source_cache::get_source_lines): Create a highlighter on demand.
 408
 409 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         * defs.h (deprecated_interactive_hook): Delete declaration.
 412         * interps.c (clear_interpreter_hooks): Remove use of
 413         deprecated_interactive_hook.
 414         * top.c (deprecated_interactive_hook): Delete definition.
 415         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 416
 417 2019-06-18  Tom de Vries  <tdevries@suse.de>
 418
 419         PR gdb/24515
 420         * dwarf2read.h (abstract_to_concrete): Change type from
 421         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 422         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 423         * dwarf2read.c (read_variable): Update.
 424         (dwarf2_fetch_die_loc_sect_off): Update.
 425
 426 2019-06-17  Tom de Vries  <tdevries@suse.de>
 427
 428         PR gdb/24617
 429         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 430         accessing parent[parent_len - 1].
 431
 432 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 433
 434         PR gdb/24364
 435         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 436         call dtrace_process_dof with NULL dof.
 437
 438 2019-06-16  Tom de Vries  <tdevries@suse.de>
 439
 440         PR gdb/24445
 441         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 442
 443 2019-06-16  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 446         (make_all_visible): Use address of member.
 447
 448 2019-06-16  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 451         (tui_free_window, free_content, free_content_elements): Remove
 452         unnecessary cast.
 453         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 454         cast.
 455         * tui/tui-regs.c (tui_show_register_group)
 456         (tui_display_registers_from, tui_display_reg_element_at_line):
 457         Remove unnecessary cast.
 458
 459 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * linux-nat.c (normal_mask): Delete.
 462         (_initialize_linux_nat): Don't initialise normal_mask.
 463
 464 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 465
 466         PR gdb/24445
 467         * dwarf-index-write.h (write_psymtabs_to_index): Add
 468         dwz_basename parameter.
 469         * dwarf-index-write.c (write_gdbindex): Move file writing to
 470         write_gdbindex_1.  Change return type void.
 471         (assert_file_size): Move up, remove filename parameter.
 472         (write_gdbindex_1): New function.
 473         (write_debug_names): Change return type to void, call
 474         assert_file_size.
 475         (struct index_wip_file): New struct.
 476         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 477         file logic to index_wip_file.  Write index for dwz file if
 478         needed.
 479         (save_gdb_index_command): Pass basename of dwz file, if present.
 480         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 481         build-id of dwz file, if present.
 482         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 483         (dwarf2_get_dwz_file): Likewise.
 484         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 485         (dwarf2_get_dwz_file): Likewise.
 486
 487 2019-06-16  Tom Tromey  <tom@tromey.com>
 488
 489         * coffread.c (process_coff_symbol): Use xstrdup.
 490         * value.c (create_internalvar): Use xstrdup.
 491
 492 2019-06-16  Tom Tromey  <tom@tromey.com>
 493
 494         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 495         * breakpoint.c (stopin_command, stopat_command)
 496         (until_break_command, decode_location_default): Remove unnecessary
 497         cast.
 498         * utils.c (subset_compare): Remove unnecessary cast.
 499         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 500         cast.
 501         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 502         cast.
 503         * infcmd.c (path_command): Remove unnecessary cast.
 504         * coffread.c (decode_type): Remove unnecessary cast.
 505         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 506         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 507         * tui/tui-stack.c (tui_show_locator_content)
 508         (tui_show_frame_info): Remove unnecessary cast.
 509         * tui/tui-win.c (tui_scroll_forward_command)
 510         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 511         (parse_scrolling_args): Remove unnecessary cast.
 512         * tui/tui-data.c (init_win_info, tui_del_window)
 513         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 514         (free_content_elements): Remove unnecessary cast.
 515         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 516         unnecessary cast.
 517         * tui/tui-source.c (tui_set_source_content)
 518         (tui_vertical_source_scroll): Remove unnecessary cast.
 519         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 520         cast.
 521         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 522         * tui/tui-regs.c (tui_display_registers_from)
 523         (tui_display_register): Remove unnecessary cast.
 524         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 525         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 526         (make_visible): Remove unnecessary cast.
 527         * tui/tui-winsource.c (tui_erase_source_content)
 528         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 529         unnecessary cast.
 530         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 531         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 532         * stabsread.c (read_type, read_array_type, read_range_type):
 533         Remove unnecessary cast.
 534         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 535         (parse_symbol, parse_type, upgrade_type, parse_external)
 536         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 537         unnecessary cast.
 538         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 539
 540 2019-06-16  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-data.c (tui_alloc_generic_win_info)
 543         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 544         checks.
 545
 546 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 547             Andrew Burgess  <andrew.burgess@embecosm.com>
 548
 549         * f-typeprint.c (f_print_type): Don't return early for not
 550         associated or not allocated types.
 551         (f_type_print_varspec_suffix): Add print_rank parameter and print
 552         ranks of array types in case they dangling.
 553         (f_type_print_base): Add print_rank parameter.
 554
 555 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 556
 557         * NEWS: Mention new MI commands.
 558         * break-catch-throw.c (enum exception_event_kind): Move to
 559         breakpoint.h.
 560         (print_mention_exception_catchpoint): Output text as a single
 561         message.
 562         (catch_exception_command_1): Rename to...
 563         (catch_exception_event): ...this, make non-static, update header
 564         command, and change some parameter types.
 565         (catch_catch_command): Update for changes to
 566         catch_exception_command_1.
 567         (catch_throw_command): Likewise.
 568         (catch_rethrow_command): Likewise.
 569         * breakpoint.c (enum exception_event_kind): Delete.
 570         * breakpoint.h (enum exception_event_kind): Moved here from
 571         break-catch-throw.c.
 572         (catch_exception_event): Declare.
 573         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 574         (mi_cmd_catch_throw): New function.
 575         (mi_cmd_catch_rethrow): New function.
 576         (mi_cmd_catch_catch): New function.
 577         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 578         'catch-catch' entries.
 579         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 580         (mi_cmd_catch_rethrow): Declare.
 581         (mi_cmd_catch_catch): Declare.
 582
 583 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * annotate.c (annotate_source_line): Change return type to void,
 586         update implementation to match.
 587         * annotate.h (annotate_source_line): Change return type to void,
 588         update header comment.
 589         * stack.c (print_frame_info): Don't change what frame information
 590         is printed based on whether annotations are on or not.
 591
 592 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 595         (annotate_source): Make static.
 596         (annotate_source_line): Moved from source.c and renamed from
 597         identify_source_line.  Update the return type.
 598         * annotate.h (annotate_source): Delete declaration.
 599         (annotate_source_line): Declaration moved from source.h, and
 600         renamed from identify_source_line.  Return type updated.
 601         * source.c (identify_source_line): Moved to annotate.c and renamed
 602         to annotate_source_line.
 603         (info_line_command): Remove check of annotation_level.
 604         * source.h (identify_source_line): Move declaration to annotate.h
 605         and rename to annotate_source_line.
 606         * stack.c: Add 'annotate.h' include.
 607         (print_frame_info): Remove check of annotation_level before
 608         calling annotate_source_line.
 609
 610 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 611
 612         * source-cache.c (source_cache::get_plain_source_lines): Use
 613         open_source_file_with_line_charpos instead of just
 614         open_source_file, remove call to find_source_lines.
 615         (source_cache::get_source_lines): Likewise.
 616         * source.c (find_source_lines): Make static.
 617         (get_filename_and_charpos): Renamed into...
 618         (open_source_file_with_line_charpos): ..this along with changes to
 619         return a scoped_fd, and some other minor clean ups.
 620         (identify_source_line): Use open_source_file_with_line_charpos.
 621         (search_command_helper): Use open_source_file_with_line_charpos
 622         instead of just open_source_file, remove call to
 623         find_source_lines.
 624         * source.h (open_source_file_with_line_charpos): Declare new
 625         function.
 626         (find_source_lines): Delete declaration.
 627
 628 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * source.c (get_filename_and_charpos): Remove fullname
 631         parameter.
 632         (identify_source_line): Update call to get_filename_and_charpos.
 633
 634 2019-06-14  Tom Tromey  <tromey@adacore.com>
 635
 636         PR gdb/24502:
 637         * ui-style.h (skip_ansi_escape): Update comment.
 638         * ui-file.h (class no_terminal_escape_file): New class.
 639         * ui-file.c (no_terminal_escape_file::write)
 640         (no_terminal_escape_file::puts): New methods.
 641         * cli/cli-logging.c (handle_redirections): Use
 642         no_terminal_escape_file.
 643
 644 2019-06-14  Tom Tromey  <tromey@adacore.com>
 645
 646         * NEWS: Move convenience variable news above Python news.
 647
 648 2019-06-14  Tom Tromey  <tom@tromey.com>
 649
 650         * gnulib: Move directory to top-level.
 651         * configure.ac: Don't configure gnulib.
 652         * configure: Rebuild.
 653         * common/common-defs.h: Use new path to gnulib.
 654         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 655         (GNULIB_H): Remove.
 656         (INCGNU): Look in new gnulib location.
 657         (HFILES_NO_SRCDIR): Remove gnulib files.
 658         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 659         (generated_files): Remove GNULIB_H.
 660         ($(LIBGNU), all-lib): Remove targets.
 661         (distclean): Don't mention GNULIB_BUILDDIR.
 662         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 663
 664 2019-06-14  Tom Tromey  <tromey@adacore.com>
 665
 666         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 667         Warn if symbol file does not provide any symbols.
 668
 669 2019-06-14  Tom Tromey  <tromey@adacore.com>
 670
 671         * source.c (find_and_open_source): Respect basenames_may_differ.
 672
 673 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * annotate.c (annotate_breakpoints_invalid): Make use of
 676         scoped_restore_terminal_state.
 677         (annotate_frames_invalid): Likewise.
 678
 679 2019-06-14  Tom Tromey  <tromey@adacore.com>
 680
 681         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 682         allow assignment to an internalvar.
 683
 684 2019-06-14  Tom Tromey  <tromey@adacore.com>
 685
 686         * ada-lex.l: Allow "_" in attribute names.
 687
 688 2019-06-14  Tom Tromey  <tromey@adacore.com>
 689
 690         PR gdb/24653:
 691         * regcache.c (registers_changed): Don't call alloca.
 692         * top.c (execute_command): Don't call alloca.
 693
 694 2019-06-13  Pedro Alves  <palves@redhat.com>
 695
 696         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 697         'expression'.  When parsing an expression, error out if there's
 698         junk after "unlimited".
 699         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 700         (do_set_command): Adjust calls to is_unlimited_literal.
 701
 702 2019-06-13  Pedro Alves  <palves@redhat.com>
 703
 704         * compile/compile.c (make_compile_options_def_group): Add braces
 705         around array_view initializer.
 706         * thread.c (make_thread_apply_all_options_def_group)
 707         (make_thread_apply_all_options_def_group): Likewise.
 708
 709 2019-06-13  Pedro Alves  <palves@redhat.com>
 710
 711         * NEWS (New commands): Mention "maint test-options
 712         require-delimiter", "maint test-options unknown-is-error", "maint
 713         test-options unknown-is-operand" and "maint show
 714         test-options-completion-result".
 715         (New command options, command completion): New section.
 716         (Completion improvements): New section.
 717         Mention that you can abbreviate "unlimited".
 718
 719 2019-06-13  Pedro Alves  <palves@redhat.com>
 720
 721         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 722         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 723         * unittests/cli-utils-selftests.c (test_parse_flags)
 724         (test_parse_flags_qcs): Delete.
 725         (test_cli_utils): Don't call deleted functions.
 726
 727 2019-06-13  Pedro Alves  <palves@redhat.com>
 728
 729         * thread.c: Include "cli/cli-option.h".
 730         (tp_array_compar_ascending): Global.
 731         (tp_array_compar): Delete function.
 732         (tp_array_compar_ascending, tp_array_compar_descending): New
 733         functions.
 734         (ascending_option_def, qcs_flag_option_def)
 735         (thr_qcs_flags_option_defs)
 736         (make_thread_apply_all_options_def_group)
 737         (make_thread_apply_options_def_group): New.
 738         (thread_apply_all_command): Use gdb::option::process_options.
 739         (thread_apply_command_completer)
 740         (thread_apply_all_command_completer): New.
 741         (thread_apply_command): Use gdb::option::process_options.
 742         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 743         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 744         to generate help text of "thread apply".  Adjust "taas"'s help.
 745         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 746         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 747
 748 2019-06-13  Pedro Alves  <palves@redhat.com>
 749
 750         * thread.c (thread_apply_command): Check for invalid TID with
 751         isdigit instead of !isalpha.
 752
 753 2019-06-13  Pedro Alves  <palves@redhat.com>
 754
 755         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 756         (validate_flags_qcs): New.
 757         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 758         (validate_flags_qcs): Declare.
 759         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 760         (make_frame_apply_options_def_group): New.
 761         (frame_apply_command_count): Process options with
 762         gdb::option::process_options.
 763         (frame_apply_completer): New.
 764         (frame_apply_level_completer, frame_apply_all_completer)
 765         (frame_apply_completer): New.
 766         (_initialize_stack): Update help of "frame apply", "frame apply
 767         level", "frame apply all" and "faas" to mention supported options
 768         and install command completers.
 769         * stack.h (frame_apply_all_completer): Declare.
 770         * thread.c: Include "stack.h".
 771         (tfaas_command): Add "--".
 772         (_initialize_thread): Update help "tfaas" to mention supported
 773         options and install command completer.
 774
 775 2019-06-13  Pedro Alves  <palves@redhat.com>
 776
 777         * completer.c (complete_nested_command_line): New.
 778         (gdb_completion_word_break_characters_throw): Add assertion.
 779         * completer.h (complete_nested_command_line): Declare.
 780
 781 2019-06-13  Pedro Alves  <palves@redhat.com>
 782
 783         * stack.c (parse_backtrace_qualifiers): New.
 784         (backtrace_command): Use it.
 785         (backtrace_command_completer): Complete on qualifiers.
 786
 787 2019-06-13  Pedro Alves  <palves@redhat.com>
 788
 789         * frame.c: Include "cli/cli-option.h.
 790         (user_set_backtrace_options): New.
 791         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 792         Delete.
 793         (get_prev_frame): Adjust.
 794         (boolean_option_def, uinteger_option_def)
 795         (set_backtrace_option_defs): New.
 796         (_initialize_frame): Adjust and use
 797         gdb::option::add_setshow_cmds_for_options to install "set
 798         backtrace past-main" and "set backtrace past-entry".
 799         * frame.h: Include "cli/cli-option.h".
 800         (struct frame_print_options): Forward declare.
 801         (print_frame_arguments_all, print_frame_arguments_scalars)
 802         (print_frame_arguments_none): Declare.
 803         (print_entry_values): Delete declaration.
 804         (struct frame_print_options, user_frame_print_options): New.
 805         (struct set_backtrace_options): New.
 806         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 807         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 808         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 809         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 810         (list_args_or_locals): Add frame_print_options parameter.
 811         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 812         * python/py-framefilter.c (enumerate_args): Pass down
 813         USER_FRAME_PRINT_OPTIONS.
 814         * stack.c: Include "cli/cli-option.h".
 815         (print_frame_arguments_all, print_frame_arguments_scalars)
 816         (print_frame_arguments_none): Declare.
 817         (print_raw_frame_arguments, print_entry_values): Delete.
 818         (user_frame_print_options): New.
 819         (boolean_option_def, enum_option_def, frame_print_option_defs):
 820         New.
 821         (struct backtrace_cmd_options): New.
 822         (bt_flag_option_def): New.
 823         (backtrace_command_option_defs): New.
 824         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 825         (print_frame_arg, read_frame_arg, print_frame_args)
 826         (print_frame_info, print_frame): Add frame_print_options parameter
 827         and use it.
 828         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 829         (backtrace_command_1): Add frame_print_options and
 830         backtrace_cmd_options parameters and use them.
 831         (make_backtrace_options_def_group): New.
 832         (backtrace_command): Process command options with
 833         gdb::option::process_options.
 834         (backtrace_command_completer): New.
 835         (_initialize_stack): Extend "backtrace"'s help to mention
 836         supported options.  Install completer for "backtrace".
 837         Install some settings commands with add_setshow_cmds_for_options.
 838
 839 2019-06-13  Pedro Alves  <palves@redhat.com>
 840
 841         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 842         and that "set/show print raw frame-arguments" are now deprecated.
 843
 844         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 845         command.
 846         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 847         * stack.c (_initialize_stack): Install "set/show print
 848         raw-frame-arguments", and deprecate "set/show print raw
 849         frame-arguments".
 850         * valprint.c (_initialize_valprint): Deprecate "set/show print
 851         raw".
 852
 853 2019-06-13  Pedro Alves  <palves@redhat.com>
 854
 855         * compile/compile.c (struct compile_options): New.
 856         (compile_flag_option_def, compile_command_option_defs)
 857         (make_compile_options_def_group): New.
 858         (compile_file_command): Handle options with
 859         gdb::option::process_options.
 860         (compile_file_command_completer): New function.
 861         (compile_code_command): Handle options with
 862         gdb::option::process_options.
 863         (compile_code_command_completer): New function.
 864         (_initialize_compiler): Install completers for "compile code" and
 865         "compile file".  Mention available options in "compile code" and
 866         "compile code"'s help.
 867         * completer.c (advance_to_completion_word): New, factored out from
 868         ...
 869         (advance_to_expression_complete_word_point): ... this.
 870         (advance_to_filename_complete_word_point): New.
 871         * completer.h (advance_to_filename_complete_word_point): New
 872         declaration.
 873
 874 2019-06-13  Pedro Alves  <palves@redhat.com>
 875
 876         * compile/compile.c: Include "cli/cli-option.h".
 877         (compile_print_value): Scope data pointer is now a
 878         value_print_options pointer; adjust.
 879         (compile_print_command): Process options.  Scope data pointer is
 880         now a value_print_options pointer; adjust.
 881         (_initialize_compile): Update "compile print"'s help to include
 882         supported options.  Install a completer for "compile print".
 883         * cp-valprint.c (show_vtblprint, show_objectprint)
 884         (show_static_field_print): Delete.
 885         (_initialize_cp_valprint): Don't install "set print
 886         static-members", "set print vtbl", "set print object" here.
 887         * printcmd.c: Include "cli/cli-option.h" and
 888         "common/gdb_optional.h".
 889         (print_command_parse_format): Rework to fill in a
 890         value_print_options instead of a format_data.
 891         (print_value): Change parameter type from format_data pointer to
 892         value_print_options reference.  Adjust.
 893         (print_command_1): Process options.  Adjust to pass down a
 894         value_print_options.
 895         (print_command_completer): New.
 896         (_initialize_printcmd): Install print_command_completer as
 897         handle_brkchars completer for the "print" command.  Update
 898         "print"'s help to include supported options.
 899         * valprint.c: Include "cli/cli-option.h".
 900         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 901         here from cp-valprint.c.
 902         (boolean_option_def, uinteger_option_def)
 903         (value_print_option_defs, make_value_print_options_def_group):
 904         New.  Use gdb::option::add_setshow_cmds_for_options to install
 905         "set print elements", "set print null-stop", "set print repeats",
 906         "set print pretty", "set print union", "set print array", "set
 907         print address", "set print symbol", "set print array-indexes".
 908         * valprint.h: Include <string> and "cli/cli-option.h".
 909         (make_value_print_options_def_group): Declare.
 910         (print_value): Change parameter type from format_data pointer to
 911         value_print_options reference.
 912         (print_command_completer): Declare.
 913
 914 2019-06-13  Pedro Alves  <palves@redhat.com>
 915
 916         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 917         (COMMON_SFILES): Add maint-test-settings.c.
 918         * cli/cli-decode.c (boolean_enums): New global, factored out from
 919         ...
 920         (add_setshow_boolean_cmd): ... here.
 921         * cli/cli-decode.h (boolean_enums): Declare.
 922         * cli/cli-option.c: New file.
 923         * cli/cli-option.h: New file.
 924         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 925         factored out from ...
 926         (parse_cli_boolean_value(const char *)): ... this.
 927         (is_unlimited_literal): Change parameter type to pointer to
 928         pointer.  Adjust and advance ARG pointer.
 929         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 930         (parse_cli_var_enum): New, factored out from ...
 931         (do_set_command): ... this.  Adjust.
 932         * cli/cli-setshow.h (parse_cli_boolean_value)
 933         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 934         (parse_cli_var_enum): Declare.
 935         * cli/cli-utils.c: Include "cli/cli-option.h".
 936         (get_ulongest): New.
 937         * cli/cli-utils.h (get_ulongest): Declare.
 938         (check_for_argument): New overloads.
 939         * maint-test-options.c: New file.
 940
 941 2019-06-13  Pedro Alves  <palves@redhat.com>
 942
 943         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 944         parse a range if "-" is at the end of the string.
 945
 946 2019-06-13  Pedro Alves  <palves@redhat.com>
 947
 948         * cli/cli-setshow.c (parse_auto_binary_operation)
 949         (parse_cli_boolean_value): Don't allow "o".
 950
 951 2019-06-13  Pedro Alves  <palves@redhat.com>
 952
 953         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 954         * NEWS: Mention maint test-settings KIND.
 955         * maint-test-settings.c: New file.
 956
 957 2019-06-13  Pedro Alves  <palves@redhat.com>
 958
 959         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 960         completer.
 961         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 962         "set" completers.
 963
 964 2019-06-13  Pedro Alves  <palves@redhat.com>
 965
 966         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 967         after item.
 968
 969 2019-06-13  Pedro Alves  <palves@redhat.com>
 970
 971         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 972
 973 2019-06-13  Pedro Alves <palves@redhat.com>
 974
 975         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 976         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 977         call.
 978         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 979         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 980         calls.
 981         (check_for_argument): Skip spaces after argument.
 982
 983 2019-06-13  Pedro Alves  <palves@redhat.com>
 984
 985         * thread.c (thread_apply_command): Adjust TID parsing.
 986         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 987         detected before end of string.
 988         (tid_is_in_list): Error out if LIST is invalid.
 989
 990 2019-06-13  Pedro Alves  <palves@redhat.com>
 991
 992         * completer.c (complete_line_internal_1): Rewind completion word
 993         point.
 994         (completion_tracker::advance_custom_word_point_by): Change
 995         parameter type to int.
 996         * completer.h (completion_tracker::advance_custom_word_point_by):
 997         Likewise.
 998
 999 2019-06-13  Pedro Alves  <palves@redhat.com>
1000
1001         * completer.c (advance_to_completion_word): Handle delimiters.
1002
1003 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1004
1005         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1006
1007 2019-06-11  Tom Tromey  <tom@tromey.com>
1008
1009         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1010         (xmalloc_failed): Move to alloc.c.
1011         * alloc.c: New file.
1012         * Makefile.in (COMMON_SFILES): Add alloc.c.
1013
1014 2019-06-11  Tom Tromey  <tom@tromey.com>
1015
1016         * nat/linux-waitpid.c: Don't include server.h.
1017         (linux_debug): Remove.
1018         (my_waitpid): Update.
1019
1020 2019-06-11  Tom Tromey  <tromey@adacore.com>
1021
1022         * infcall.c (_initialize_infcall): Remove trailing newline from
1023         help.
1024         * user-regs.c (_initialize_user_regs): Remove trailing newline
1025         from help.
1026         * typeprint.c (_initialize_typeprint): Remove trailing newline
1027         from help.
1028         * reverse.c (_initialize_reverse): Remove trailing newlines from
1029         help.
1030         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1031         from help.
1032         * language.c (add_set_language_command): Remove trailing newline
1033         from help.
1034         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1035         help.
1036         * disasm.c (_initialize_disasm): Remove trailing newline from
1037         help.
1038         * top.c (init_main): Remove trailing newline from help.
1039         * interps.c (_initialize_interpreter): Remove trailing newline
1040         from help.
1041         * btrace.c (_initialize_btrace): Remove trailing newlines from
1042         help.
1043         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1044         from help.
1045         * python/python.c (_initialize_python): Remove trailing newline
1046         from help.
1047         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1048         help.
1049         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1050         from help.  Reformat some text.
1051         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1052         from help.
1053         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1054         newline from help.
1055
1056 2019-06-11  Tom Tromey  <tromey@adacore.com>
1057
1058         * darwin-nat.c (darwin_decode_exception_message)
1059         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1060
1061 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * valops.c (value_slice): Check for not allocated or not
1064         associated values.
1065
1066 2019-06-10  Tom de Vries  <tdevries@suse.de>
1067
1068         PR gdb/24618
1069         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1070         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1071         invalid.
1072
1073 2019-06-10  Tom de Vries  <tdevries@suse.de>
1074
1075         PR gdb/24611
1076         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1077         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1078
1079 2019-06-10  Tom de Vries  <tdevries@suse.de>
1080
1081         PR symtab/24545
1082         * symtab.c (struct demangled_name_entry): Add language field.
1083         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1084         static minimal symbol".  Set and use language field.
1085
1086 2019-06-10  Tom Tromey  <tromey@adacore.com>
1087
1088         * ada-lang.c (_initialize_ada_language): Update help text.
1089
1090 2019-06-10  Tom Tromey  <tromey@adacore.com>
1091
1092         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1093         with a newline.
1094         * guile/guile.c (handle_boot_error): Don't end warning with a
1095         newline.
1096         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1097         warning with a newline.
1098         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1099         newline.
1100         (s12z_frame_cache): Likewise.
1101         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1102         a newline.
1103         * solib-svr4.c (disable_probes_interface): Don't end warning with
1104         a newline.
1105         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1106         newline.
1107         * python/python.c (do_finish_initialization): Don't end warning
1108         with a newline.
1109
1110 2019-06-10  Tom Tromey  <tom@tromey.com>
1111
1112         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1113         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1114         gdbpy_enter.
1115
1116 2019-06-10  Tom Tromey  <tromey@adacore.com>
1117
1118         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1119         data.
1120         (elf_new_init): Don't call stabsread_new_init.
1121         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1122         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1123         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1124
1125 2019-06-10  Tom de Vries  <tdevries@suse.de>
1126
1127         PR symtab/16264
1128         PR symtab/24517
1129         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1130
1131 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1132
1133         * source.c (find_and_open_source): Also rewrite relative file
1134         names.
1135
1136 2019-04-26  Amos Bird  <amosbird@gmail.com>
1137
1138         * annotate.c (annotate_thread_exited): Add "thread-exited"
1139         annotation.
1140
1141 2019-06-06  Tom Tromey  <tromey@adacore.com>
1142
1143         * maint.h (class scoped_command_stats): Use
1144         DISABLE_COPY_AND_ASSIGN.
1145         <print_time>: New method.
1146         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1147         print_time.
1148         (scoped_command_stats::print_time): New method.
1149
1150 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1153         instructions of lengths 6 or 8 bytes.
1154
1155 2019-06-04  Pedro Alves  <palves@redhat.com>
1156
1157         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1158
1159         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1160         * breakpoint.c (condition_completer): Likewise.
1161         * cli/cli-dump.c (scan_expression): Likewise.
1162         * common/filestuff.c (mkdir_recursive): Likewise.
1163         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1164         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1165         (gdb_abspath): Likewise.
1166         * compile/compile-cplus-types.c
1167         (compile_cplus_instance::decl_name): Likewise.
1168         * completer.c (complete_explicit_location):
1169         (signal_completer, reg_or_group_completer_1): Likewise.
1170         * cp-support.c (cp_remove_params_if_any): Likewise.
1171         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1172         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1173         * infcmd.c (strip_bg_char): Likewise.
1174         * linespec.c (copy_token_string): Likewise.
1175         * mi/mi-main.c (output_cores): Likewise.
1176         * psymtab.c (psymtab_search_name):
1177         * symfile.c (test_set_ext_lang_command): Likewise.
1178         * target.c (target_fileio_read_stralloc): Likewise.
1179         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1180         * value.c (complete_internalvar): Likewise.
1181
1182 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1183
1184         Add objfile property to gdb.Type.
1185         * NEWS: Mention Python API addition.
1186         * python/py-type.c (typy_get_objfile): New method.
1187
1188 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1189
1190         * NEWS: Mention the new set|show style [title|highlight].
1191         Mention changes to "show style", "help" and "apropos".
1192
1193 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1194
1195         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1196         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1197         instead of print_help_for_command.
1198         (print_doc_of_command): New function.
1199         (help_list): Add 'apropos -v word' suggestion.
1200         (print_help_for_command): Style the command name using title style.
1201         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1202         (_initialize_cli_cmds): Describe -v in apropos_command help.
1203
1204 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1205
1206         * cli/cli-style.h (cli_style_option): Add name in constructor,
1207         add m_name class member, add constructor with intensity,
1208         add name class function.
1209         (cli_style_option::add_setshow_commands): Remove name argument.
1210         (highlight_style, title_style): New styles.
1211         * cli/cli-style.c (do_show): New function that shows a style
1212         characteristic styling the style name with itself.
1213         (set_style_name): New function.
1214         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1215         Update all callers according to the changes in cli/cli-style.h.
1216         * utils.h (fputs_highlighted): New function.
1217         * utils.c (fputs_highlighted): Likewise.
1218
1219 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * NEWS: Mention new pipe command and new convenience variables.
1222
1223 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1224
1225         * cli/cli-cmds.c (pipe_command): New function.
1226         (_initialize_cli_cmds): Call add_com for pipe_command.
1227         Define | as an alias for pipe.
1228         (exit_status_set_internal_vars): New function.
1229         (shell_escape): Call exit_status_set_internal_vars.
1230         cli/cli-decode.c (find_command_name_length): Recognize | as
1231         a single character command.
1232
1233 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1234
1235         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1236         top.c (execute_command_to_ui_file): New function, mostly a copy
1237         of execute_command_to_string.
1238         (execute_command_to_string): Implement by calling
1239         execute_command_to_ui_file.
1240
1241 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1242
1243         * top.h (saved_command_line): Remove declaration.
1244         * top.c (previous_saved_command_line, previous_repeat_arguments):
1245         New variables.
1246         (saved_command_line): Make static, define together with other
1247         'repeat variables'.
1248         (dont_repeat): Clear repeat_arguments.
1249         (repeat_previous, get_saved_command_line, save_command_line):
1250         New functions.
1251         (gdb_init): Initialize saved_command_line
1252         and previous_saved_command_line.
1253         * main.c (captured_main_1): Remove saved_command_line initialization.
1254         * event-top.c (handle_line_of_input): Update to use
1255         the new 'repeat' related functions instead of direct access to
1256         saved_command_line.
1257         * command.h (repeat_previous, get_saved_command_line,
1258         save_command_line): New declarations.
1259         (dont_repeat): Add comment.
1260
1261 2019-05-30  Tom Tromey  <tromey@adacore.com>
1262
1263         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1264         Fix comment.
1265         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1266
1267 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1268
1269         PR cli/24587
1270         * completer.c (complete): Initialize variable word.
1271
1272 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1273
1274         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1275         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1276         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1277         'body' is NULL to the outter 'if', protecting the '!is_define'
1278         situation as well.
1279
1280 2019-05-29  Tom Tromey  <tromey@adacore.com>
1281
1282         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1283         (dwarf_unknown): New function.
1284         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1285         (dwarf_type_encoding_name): Use dwarf_unknown.
1286
1287 2019-05-29  Tom Tromey  <tromey@adacore.com>
1288
1289         PR c++/20020:
1290         * cp-valprint.c (cp_print_value_fields): Call
1291         cp_print_static_field inside "try".
1292
1293 2019-05-29  Tom Tromey  <tromey@adacore.com>
1294
1295         * inflow.c (struct terminal_info): Add default operator=.
1296         * configure: Rebuild.
1297         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1298         -Wdeprecated-copy-dtor, -Wredundant-move.
1299
1300 2019-05-29  Tom Tromey  <tromey@adacore.com>
1301
1302         * NEWS: Add entry.
1303         * infcmd.c (print_return_value_1): Handle finish_print
1304         option.
1305         (show_print_finish): New function.
1306         (_initialize_infcmd): Add "set/show print finish" commands.
1307         * valprint.c (user_print_options): Initialize new member.
1308         * valprint.h (struct value_print_options) <finish_print>: New
1309         member.
1310
1311 2019-05-28  Tom Tromey  <tromey@adacore.com>
1312
1313         * ada-lang.c (ada_remove_Xbn_suffix)
1314         (find_old_style_renaming_symbol)
1315         (parse_old_style_renaming): Remove.
1316         (ada_find_renaming_symbol): Don't call
1317         find_old_style_renaming_symbol.
1318         (ada_is_renaming_symbol): Rename from
1319         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1320         bool.  Now static.
1321         (ada_read_var_value): Update and simplify.
1322         * ada-exp.y (write_var_or_type): Remove old code.
1323
1324 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1325
1326         * event-top.c: Remove include comment.
1327         * inflow.c (class scoped_ignore_sigttou): Move from here...
1328         * inflow.h (class scoped_ignore_sigttou): ...to here.
1329         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1330         * top.c:  Remove include comment.
1331
1332 2019-05-27  Tom Tromey  <tom@tromey.com>
1333
1334         * NEWS: Fix typo.
1335
1336 2019-05-22  Tom Tromey  <tromey@adacore.com>
1337
1338         * target.c (target_follow_exec): Constify parameter.
1339         * target-delegates.c: Rebuild.
1340         * remote.c (remote_target::follow_exec): Constify parameter.
1341         * infrun.c (follow_exec): Constify parameter.
1342         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1343         (target_follow_exec): Likewise.
1344
1345 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1348         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1349
1350 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1351
1352         * NEWS: Add debugredirect and testsuite sections.
1353
1354 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1355
1356         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1357         target descriptions using exclusively floating point register name
1358         aliases.
1359
1360 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         PR gdb/18644:
1363         * f-lang.c (build_fortran_types): Handle the case where
1364         gdbarch_floatformat_for_type returns a nullptr.
1365
1366 2019-05-21  Tom de Vries  <tdevries@suse.de>
1367
1368         PR cli/24587
1369         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1370
1371 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         PR gdb/18644:
1374         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1375         16-byte floats.
1376         * i386-tdep.c (i386_floatformat_for_type): Use
1377         floatformats_ia64_quad for the 16-byte floating point component
1378         within a fortran 32-byte complex number.
1379
1380 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1383         delete default constructor.
1384         (find_partial_die): Update to return const struct.
1385         (partial_die_parent_scope): Move variable declaration into scope
1386         of its use and change its type to auto.
1387         (guess_partial_die_structure_name): Likewise.
1388         (partial_die_info::fixup): Likewise.
1389
1390 2019-05-17  Tom Tromey  <tromey@adacore.com>
1391
1392         * source.c (find_and_open_source): Remove cast.
1393
1394 2019-05-17  Tom Tromey  <tromey@adacore.com>
1395
1396         * annotate.c (annotate_source): Make "filename" const.
1397         * annotate.h (annotate_source): Use const.
1398
1399 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1400
1401         * disasm.c (set_disassembler_options): Send errors to stderr.
1402
1403 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1404
1405         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1406         (cli_interp_base::set_logging): Check debug_redirect.
1407         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1408         * cli/cli-logging.c (debug_redirect): Add static variable.
1409         (pop_output_files): Add default param.
1410         (handle_redirections): Print debug setting.
1411         (show_logging_command): Likewise.
1412         (_initialize_cli_logging): Add debugredirect command.
1413         * interps.c (current_interp_set_logging): Add debug_redirect
1414         parameter.
1415         * interps.h (set_logging): Add debug_redirect parameter.
1416         (current_interp_set_logging): Likewise.
1417         * mi/mi-common.h: Likewise.
1418         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1419
1420 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1421             Tom Tromey  <tromey@adacore.com>
1422
1423         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1424         directly.
1425         * cli/cli-interp.h (make_logging_output): Remove declaration.
1426         * cli/cli-logging.c (make_logging_output): Remove function.
1427         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1428         directly.
1429         * ui-file.c (tee_file::tee_file): Remove bools.
1430         (tee_file::~tee_file): Remove deletes.
1431         * ui-file.h (tee_file): Remove bools.
1432
1433 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1434
1435         * mi/mi-cmds.h (mi_cmd_complete): New function.
1436         * mi/mi-main.c (mi_cmd_complete): Likewise.
1437         * mi/mi-cmds.c: Define new MI command -complete.
1438         * NEWS: Mention new -complete command.
1439
1440 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1441
1442         * completer.h (complete): New function.
1443         * completer.c (complete): Likewise.
1444         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1445         function defined in completer.h.
1446
1447 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1448
1449         * MAINTAINERS (Write After Approval): Add myself.
1450
1451 2019-05-17  Tom de Vries  <tdevries@suse.de>
1452
1453         PR gdb/24094
1454         * dwarf2read.c (struct cu_partial_die_info): New struct.
1455         (find_partial_die): Return cu_partial_die_info.
1456         (partial_die_parent_scope, guess_partial_die_structure_name)
1457         (partial_die_info::fixup): Handle new return type of find_partial_die.
1458
1459 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1460
1461         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1462         "std::string", simplifying the algorithm.
1463
1464 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1465
1466         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1467         (stap_static_probe_ops::get_probes): Likewise.
1468
1469 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1470
1471         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1472         '-')" and "else if".
1473         (stap_parse_single_operand): Join checks for
1474         "gdbarch_stap_parse_special_token_p" and
1475         "gdbarch_stap_parse_special_token" in the same "if" statement.
1476         Invert check when verifying for operation on register
1477         displacement.
1478
1479 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1480
1481         * stap-probe.c (stap_get_opcode): Update comment.
1482         (stap_get_expected_argument_type): Likewise.
1483         (handle_stap_probe): Likewise.
1484
1485 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1486
1487         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1488         return type to 'bool'.  Adjust comment.  Use 'bool' when
1489         appropriate.
1490         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1491         * stap-probe.c (stap_parse_argument_1): Likewise.
1492         (stap_is_operator): Likewise.
1493         (stap_is_generic_prefix): Likewise.
1494         (stap_is_register_prefix): Likewise.
1495         (stap_is_register_indirection_prefix): Likewise.
1496         (stap_is_integer_prefix): Likewise.
1497         (stap_generic_check_suffix): Likewise.
1498         (stap_check_integer_suffix): Likewise.
1499         (stap_check_register_suffix): Likewise.
1500         (stap_check_register_indirection_suffix): Likewise.
1501         (stap_parse_register_operand): Likewise.
1502         (stap_parse_single_operand): Likewise.
1503         (stap_parse_argument_1): Likewise.
1504         (stap_probe::get_argument_count): Likewise.
1505         (stap_is_operator): Likewise.
1506
1507 2019-05-16  Tom Tromey  <tromey@adacore.com>
1508
1509         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1510         keyword to foreach.
1511
1512 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1513
1514         * linux-thread-db.c (try_thread_db_load_1): Change return type
1515         to bool.
1516         (try_thread_db_load): Likewise.
1517         (try_thread_db_load_from_pdir_1): Likewise.
1518         (try_thread_db_load_from_pdir): Likewise.
1519         (try_thread_db_load_from_sdir): Likewise.
1520         (try_thread_db_load_from_dir): Likewise.
1521         (thread_db_load_search): Likewise.
1522         (has_libpthread): Likewise.
1523         (thread_db_load): Likewise.
1524
1525 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1526
1527         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1528         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1529         NULL, and complain/return if that's the case.
1530
1531 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1532
1533         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1534         (advance, posn, abstract_read_memory): New functions.
1535         [struct mem_read_abstraction]: New struct.
1536         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1537
1538 2019-05-14  Tom Tromey  <tromey@adacore.com>
1539
1540         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1541         value is not lval_memory.
1542
1543 2019-05-14  Tom Tromey  <tromey@adacore.com>
1544
1545         * solib.c (info_sharedlibrary_command): Style the file name.
1546
1547 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1550         (aarch64_vnv_type): Likewise.
1551         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1552         * common/tdesc.c: Likewise.
1553         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1554         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1555         * features/aarch64-fpu.xml: Add ieee half view.
1556         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1557         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1558         * gdbtypes.h (struct builtin_type): Likewise.
1559         (struct objfile_type): Likewise.
1560
1561 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1562
1563         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1564         typo.
1565         * location.h (string_to_event_location): Likewise.
1566
1567 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1568
1569         GDB 8.3 released.
1570
1571 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1572
1573         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1574         New variable declaration.
1575         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1576         New variable.
1577         (print_one_breakpoint): Use ui_out::test_flags and new global
1578         variable to compute use_fixed_output.
1579         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1580         Remove.
1581         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1582         (mi_multi_location_breakpoint_output_fixed): Remove.
1583         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1584         new variable.
1585         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1586         fix_multi_location_breakpoint_output flag if version >= 3.
1587         * ui-out.h (enum ui_out_flag)
1588         <fix_multi_location_breakpoint_output>: New enumerator.
1589
1590 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1591
1592         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1593
1594 2019-05-10  Tom Tromey  <tromey@adacore.com>
1595
1596         * ada-lang.c (catch_ada_completer): New function.
1597         (_initialize_ada_language): Use it.
1598
1599 2019-05-10  Tom Tromey  <tromey@adacore.com>
1600
1601         * thread.c (print_thread_info): Make "requested_threads" const.
1602         * gdbthread.h (print_thread_info): Make "requested_threads"
1603         const.
1604         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1605         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1606
1607 2019-05-08  Tom Tromey  <tom@tromey.com>
1608
1609         * gdbtypes.c (objfile_type_data): Change type.
1610         (objfile_type, _initialize_gdbtypes): Update.
1611
1612 2019-05-08  Tom Tromey  <tom@tromey.com>
1613
1614         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1615         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1616         (_initialize_dwarf2_frame): Update.
1617
1618 2019-05-08  Tom Tromey  <tom@tromey.com>
1619
1620         * objc-lang.c (objc_objfile_data): Change type.
1621         (find_methods): Update.
1622         (_initialize_objc_lang): Remove.
1623
1624 2019-05-08  Tom Tromey  <tom@tromey.com>
1625
1626         * stabsread.c (rs6000_builtin_type_data): Change type.
1627         (rs6000_builtin_type, _initialize_stabsread): Update.
1628
1629 2019-05-08  Tom Tromey  <tom@tromey.com>
1630
1631         * mips-tdep.c (mips_pdr_data): Remove.
1632         (_initialize_mips_tdep): Update.
1633
1634 2019-05-08  Tom Tromey  <tom@tromey.com>
1635
1636         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1637         (hppa_init_objfile_priv_data, read_unwind_info)
1638         (find_unwind_entry, _initialize_hppa_tdep): Update.
1639
1640 2019-05-08  Tom Tromey  <tom@tromey.com>
1641
1642         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1643         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1644         on obstack.
1645         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1646
1647 2019-05-08  Tom Tromey  <tom@tromey.com>
1648
1649         * mdebugread.c (basic_type_data): Change type.
1650         (basic_type, _initialize_mdebugread): Update.
1651
1652 2019-05-08  Tom Tromey  <tom@tromey.com>
1653
1654         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1655
1656 2019-05-08  Tom Tromey  <tom@tromey.com>
1657
1658         * nto-tdep.c (nto_inferior_data_reg): Change type.
1659         (nto_inferior_data): Update.
1660         (nto_inferior_data_cleanup, nto_new_inferior_data)
1661         (_initialize_nto_tdep): Remove.
1662         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1663
1664 2019-05-08  Tom Tromey  <tom@tromey.com>
1665
1666         * ada-lang.c (struct ada_inferior_data): Add initializers.
1667         (ada_inferior_data): Change type.
1668         (ada_inferior_data_cleanup): Remove.
1669         (get_ada_inferior_data, ada_inferior_exit)
1670         (struct ada_pspace_data): Add initializers, destructor.
1671         (ada_pspace_data_handle): Change type.
1672         (get_ada_pspace_data): Update.
1673         (ada_pspace_data_cleanup): Remove.
1674
1675 2019-05-08  Tom Tromey  <tom@tromey.com>
1676
1677         * coffread.c (struct coff_symfile_info): Add initializers.
1678         (coff_objfile_data_key): Move lower.  Change type.
1679         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1680         Update.
1681         (coff_free_info): Remove.
1682
1683 2019-05-08  Tom Tromey  <tom@tromey.com>
1684
1685         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1686         (fbsd_pspace_data_handle): Move lower.  Change type.
1687         (get_fbsd_pspace_data): Update.
1688         (fbsd_pspace_data_cleanup): Remove.
1689         (_initialize_fbsd_tdep): Update.
1690
1691 2019-05-08  Tom Tromey  <tom@tromey.com>
1692
1693         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1694         (get_ada_tasks_pspace_data): Update.
1695         (ada_tasks_pspace_data_cleanup): Remove.
1696         (_initialize_tasks): Update.
1697         (ada_tasks_inferior_data_handle): Change type.
1698         (get_ada_tasks_inferior_data): Update.
1699         (ada_tasks_inferior_data_cleanup): Remove.
1700         (struct ada_tasks_pspace_data): Add initializers.
1701
1702 2019-05-08  Tom Tromey  <tom@tromey.com>
1703
1704         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1705         * symfile-debug.c (debug_sym_get_probes): Change type.
1706         * stap-probe.c (handle_stap_probe):
1707         (stap_static_probe_ops::get_probes): Change type.
1708         * probe.h (class static_probe_ops) <get_probes>: Change type.
1709         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1710         (parse_probes_in_pspace): Update.
1711         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1712         Update.
1713         (any_static_probe_ops::get_probes): Change type.
1714         * elfread.c (elfread_data): New typedef.
1715         (probe_key): Change type.
1716         (elf_get_probes): Likewise.  Update.
1717         (probe_key_free): Remove.
1718         (_initialize_elfread): Update.
1719         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1720         Change type.
1721         (dtrace_process_dof_probe, dtrace_process_dof)
1722         (dtrace_static_probe_ops::get_probe): Change type.
1723
1724 2019-05-08  Tom Tromey  <tom@tromey.com>
1725
1726         * xcoffread.c (struct xcoff_symfile_info): Rename from
1727         coff_symfile_info.  Add initializers.
1728         (xcoff_objfile_data_key): Move lower.  Change type.
1729         (XCOFF_DATA): Rewrite.
1730         (xcoff_free_info): Remove.
1731         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1732         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1733         (xcoff_initial_scan): Update.
1734
1735 2019-05-08  Tom Tromey  <tom@tromey.com>
1736
1737         * solib-svr4.c (struct svr4_info): Add initializers and
1738         destructor.
1739         <probes_table>: Now an htab_up.
1740         (solib_svr4_pspace_data): Change type.
1741         (free_probes_table): Simplify.
1742         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1743         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1744         (probes_table_remove_objfile_probes, register_solib_event_probe)
1745         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1746         (_initialize_svr4_solib): Update.
1747
1748 2019-05-08  Tom Tromey  <tom@tromey.com>
1749
1750         * remote.c (remote_pspace_data): Change type.
1751         (remote_pspace_data_cleanup): Remove.
1752         (get_remote_exec_file, set_pspace_remote_exec_file)
1753         (_initialize_remote): Update.
1754
1755 2019-05-08  Tom Tromey  <tom@tromey.com>
1756
1757         * breakpoint.c (breakpoint_objfile_key): Change type.
1758         (get_breakpoint_objfile_data): Update.
1759         (free_breakpoint_objfile_data): Remove.
1760         (_initialize_breakpoint): Update.
1761
1762 2019-05-08  Tom Tromey  <tom@tromey.com>
1763
1764         * linux-tdep.c (struct linux_info): Add initializers.
1765         (linux_inferior_data): Move.  Change type.
1766         (invalidate_linux_cache_inf): Update.
1767         (linux_inferior_data_cleanup): Remove.
1768         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1769
1770 2019-05-08  Tom Tromey  <tom@tromey.com>
1771
1772         * auxv.c (auxv_inferior_data): Move.  Change type.
1773         (auxv_inferior_data_cleanup): Remove.
1774         (invalidate_auxv_cache_inf): Rewrite.
1775         (get_auxv_inferior_data, _initialize_auxv): Update.
1776
1777 2019-05-08  Tom Tromey  <tom@tromey.com>
1778
1779         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1780         (symfile_debug_objfile_data_key): Change type.
1781         (symfile_debug_installed, debug_qf_has_symbols)
1782         (debug_qf_find_last_source_symtab)
1783         (debug_qf_forget_cached_source_info)
1784         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1785         (debug_qf_print_stats, debug_qf_dump)
1786         (debug_qf_expand_symtabs_for_function)
1787         (debug_qf_expand_all_symtabs)
1788         (debug_qf_expand_symtabs_with_fullname)
1789         (debug_qf_map_matching_symbols)
1790         (debug_qf_expand_symtabs_matching)
1791         (debug_qf_find_pc_sect_compunit_symtab)
1792         (debug_qf_map_symbol_filenames)
1793         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1794         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1795         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1796         (debug_sym_read_linetable, debug_sym_relocate): Update.
1797         (symfile_debug_free_objfile): Remove.
1798         (install_symfile_debug_logging, _initialize_symfile_debug):
1799         Update.
1800
1801 2019-05-08  Tom Tromey  <tom@tromey.com>
1802
1803         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1804         allocate_on_obstack.
1805         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1806         (get_dwarf2_per_objfile): Update.
1807         (set_dwarf2_per_objfile): Remove.
1808         (dwarf2_has_info, dwarf2_get_section_info): Update.
1809         (dwarf2_free_objfile): Remove.
1810         (_initialize_dwarf2_read): Update.
1811
1812 2019-05-08  Tom Tromey  <tom@tromey.com>
1813
1814         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1815         initializers.
1816         <unsupported_script_warning_printed,
1817         script_not_found_warning_printed>: Now bool.
1818         (auto_load_pspace_data): Change type.
1819         (~auto_load_pspace_info): Rename from
1820         auto_load_pspace_data_cleanup.
1821         (get_auto_load_pspace_data, init_loaded_scripts_info)
1822         (clear_section_scripts, maybe_print_unsupported_script_warning)
1823         (maybe_print_script_not_found_warning, _initialize_auto_load):
1824         Update.
1825
1826 2019-05-08  Tom Tromey  <tom@tromey.com>
1827
1828         * objfiles.c (objfile_pspace_info): Add destructor and
1829         initializers.
1830         (objfiles_pspace_data): Change type.
1831         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1832         (get_objfile_pspace_data): Update.
1833         (objfiles_bfd_data): Change type.
1834         (get_objfile_bfd_data): Update.
1835         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1836
1837 2019-05-08  Tom Tromey  <tom@tromey.com>
1838
1839         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1840         Change type.
1841         (get_catch_syscall_inferior_data): Update.
1842         (catch_syscall_inferior_data_cleanup): Remove.
1843         (_initialize_break_catch_syscall): Update.
1844
1845 2019-05-08  Tom Tromey  <tom@tromey.com>
1846
1847         * inflow.c (struct terminal_info): Add destructor and
1848         initializers.
1849         (inflow_inferior_data): Change type.
1850         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1851         (get_inflow_inferior_data, inflow_inferior_exit)
1852         (swap_terminal_info, _initialize_inflow): Update.
1853
1854 2019-05-08  Tom Tromey  <tom@tromey.com>
1855
1856         * target-dcache.c (target_dcache_cleanup): Remove.
1857         (target_dcache_aspace_key): Change type.
1858         (target_dcache_init_p, target_dcache_invalidate)
1859         (target_dcache_get, target_dcache_get_or_init)
1860         (_initialize_target_dcache): Update.
1861         * dcache.h (struct dcache_deleter): New.
1862
1863 2019-05-08  Tom Tromey  <tom@tromey.com>
1864
1865         * symtab.c (struct symbol_cache): Add destructor and
1866         initializers.
1867         (symbol_cache_key): Move.  Change type.
1868         (make_symbol_cache, free_symbol_cache): Remove.
1869         (get_symbol_cache): Update.
1870         (symbol_cache_cleanup): Remove.
1871         (ALL_PSPACES, symbol_cache_flush)
1872         (maintenance_print_symbol_cache)
1873         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1874         Update.
1875
1876 2019-05-08  Tom Tromey  <tom@tromey.com>
1877
1878         * symtab.c (struct main_info): Add destructor and initializers.
1879         (main_progspace_key): Move.  Change type.
1880         (get_main_info): Update.
1881         (main_info_cleanup): Remove.
1882         (_initialize_symtab): Update.
1883
1884 2019-05-08  Tom Tromey  <tom@tromey.com>
1885
1886         * registry.h (DECLARE_REGISTRY): Define the _key class.
1887
1888 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * NEWS: Merge two 'New commands' sections.
1891
1892 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1893
1894         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1895         parameter and use Ada language definition instead.
1896         (ada_val_print_ptr): Remove unused language parameter.
1897         (ada_val_print_num): Remove language parameter and use Ada language
1898         definition instead.
1899         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1900         parameter.
1901         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1902         parameter and use Ada language definition instead.
1903         (ada_val_print_1): Update all ada_val_print_xxx calls.
1904         Remove language parameter.
1905         (ada_val_print): Update ada_val_print_1 call.
1906
1907 2019-05-08  Tom Tromey  <tromey@adacore.com>
1908
1909         * remote.c (remote_hw_watchpoint_limit)
1910         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1911         Now static.
1912
1913 2019-05-08  Tom Tromey  <tromey@adacore.com>
1914
1915         * maint.c (_initialize_maint_cmds): Move initialization code to
1916         remote.c.
1917         (watchdog, show_watchdog): Move to remote.c.
1918         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1919         "watchdog" static.
1920         (_initialize_remote): Move initialization code from maint.c.
1921         * defs.h (watchdog): Don't declare.
1922
1923 2019-05-08  Tom Tromey  <tromey@adacore.com>
1924
1925         * tui/tui-interp.c: Include main.h.
1926         * interps.c: Include main.h.
1927         * main.h (interpreter_p): Declare.
1928         * defs.h (interpreter_p): Don't declare.
1929
1930 2019-05-08  Tom Tromey  <tromey@adacore.com>
1931
1932         * dwarf2loc.c: Include dwarf2read.h.
1933         * defs.h (read_unsigned_leb128): Don't declare.
1934         * dwarf2read.h (read_unsigned_leb128): Declare.
1935
1936 2019-05-08  Tom Tromey  <tromey@adacore.com>
1937
1938         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1939         method.
1940
1941 2019-05-08  Tom Tromey  <tromey@adacore.com>
1942
1943         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1944         when no wrap column is set.
1945
1946 2019-05-08  Tom Tromey  <tromey@adacore.com>
1947
1948         * c-lang.c (c_get_string): Handle non-C-style arrays.
1949
1950 2019-05-08  Tom Tromey  <tromey@adacore.com>
1951
1952         * typeprint.c (print_offset_data::update): Print the bit offset,
1953         not the number of bits remaining.
1954
1955 2019-05-08  Tom Tromey  <tromey@adacore.com>
1956
1957         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1958         padding at end of comment.
1959
1960 2019-05-08  Tom Tromey  <tromey@adacore.com>
1961
1962         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1963         Compare main types.
1964
1965 2019-05-06  Tom Tromey  <tom@tromey.com>
1966
1967         * common/scoped_mmap.c: Include common-defs.h.
1968         * common/scoped_mmap.h: Don't include config.h.
1969
1970 2019-05-04  Tom Tromey  <tom@tromey.com>
1971
1972         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1973         (struct aarch64_call_info): Add initializers.
1974         <si>: Now a std::vector.
1975         (pass_on_stack, aarch64_push_dummy_call): Update.
1976
1977 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1978             Tom Tromey  <tom@tromey.com>
1979
1980         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1981         (ppc_threads): Now a std::vector.  Now static.
1982         (hwdebug_find_thread_points_by_tid)
1983         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1984         Update.
1985
1986 2019-05-04  Tom Tromey  <tom@tromey.com>
1987
1988         * arc-tdep.c (arc_tdesc_init): Return bool.
1989
1990 2019-05-04  Tom Tromey  <tom@tromey.com>
1991
1992         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1993         Use gdb_assert_not_reached.
1994
1995 2019-05-04  Tom Tromey  <tom@tromey.com>
1996
1997         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1998         "false".
1999
2000 2019-05-04  Tom Tromey  <tom@tromey.com>
2001
2002         * arc-tdep.c (arc_tdesc_init): Use bool.
2003
2004 2019-05-04  Tom Tromey  <tom@tromey.com>
2005
2006         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2007
2008 2019-05-04  Tom Tromey  <tom@tromey.com>
2009
2010         * cli/cli-cmds.c (valid_command_p): Return bool.
2011
2012 2019-05-04  Tom Tromey  <tom@tromey.com>
2013
2014         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2015         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2016
2017 2019-05-04  Raul Tambre  <raul@tambre.ee>
2018
2019         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2020         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2021         operator for comparison.
2022
2023 2019-05-04  Tom Tromey  <tom@tromey.com>
2024
2025         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2026         (lookup_partial_symbol, print_partial_symbols)
2027         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2028         (psymbol_compare): Update.
2029         (add_psymbol_to_bcache): Clear the entire psymbol.
2030         (maintenance_check_psymtabs): Update.
2031         * psympriv.h (struct partial_symbol): Don't derive from
2032         general_symbol_info.
2033         <obj_section, unrelocated_address, address,
2034         set_unrelocated_address>: Update.
2035         <ginfo>: New member.
2036         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2037         (debug_names::write_psymbols): Update.
2038
2039 2019-05-04  Tom de Vries  <tdevries@suse.de>
2040
2041         * contrib/cc-with-tweaks.sh: Support -n arg.
2042
2043 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2044
2045         * corelow.c (core_target::detach): Ensure frame cache and
2046         register caches are cleared.
2047         inferior.c (exit_inferior_1): Likewise.
2048
2049 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2050             Tom Tromey  <tom@tromey.com>
2051
2052         * dictionary.c (collate_pending_symbols_by_language): Remove
2053         "struct" from foreach.
2054         * symtab.c (lookup_global_symbol_from_objfile)
2055         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2056         foreach.
2057         * ser-tcp.c (net_open): Remove "struct" from foreach.
2058         * objfiles.c (objfile_relocate, objfile_rebase)
2059         (objfile_has_symbols): Remove "struct" from foreach.
2060         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2061         from foreach.
2062         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2063         foreach.
2064         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2065         "struct" from foreach.
2066         * ada-lang.c (create_excep_cond_exprs)
2067         (ada_exception_catchpoint_cond_string): Remove "struct" from
2068         foreach.
2069
2070 2019-05-03  Tom Tromey  <tromey@adacore.com>
2071
2072         * ada-exp.y (convert_char_literal): Check suffix of each
2073         enumerator.
2074
2075 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2076
2077         PR ada/21406:
2078         * ada-exp.y (yywrap): Don't define.
2079         * ada-lex.l (%option): Add noyywrap
2080         (yywrap): Remove.
2081
2082 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2083
2084         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2085         _WIN32_WINNT to the XP level, unless already defined to a higher
2086         level.
2087
2088         * unittests/parse-connection-spec-selftests.c:
2089         * ser-tcp.c:
2090         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2091         override.
2092
2093         * symfile.c (find_separate_debug_file): Remove colon from the
2094         drive spec of DOS/Windows file names of the target, so that the
2095         file name produced from DEBUGDIR and the target's directory will
2096         be valid on DOS/Windows systems.
2097
2098 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * rust-lang.c (val_print_struct): Handle printing structures
2101         containing strings.
2102
2103 2019-05-02  Tom Tromey  <tromey@adacore.com>
2104
2105         * valarith.c (_initialize_valarith): Remove.
2106
2107 2019-05-01  Tom Tromey  <tromey@adacore.com>
2108
2109         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2110         bitfields.
2111
2112 2019-05-01  Tom Tromey  <tromey@adacore.com>
2113
2114         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2115         for big-endian copies.
2116
2117 2019-04-30  Ali Tamur  <tamur@google.com>
2118         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2119         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2120         (read_3_bytes): New function.
2121
2122 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2123
2124         * windows-nat.c (main_thread_id): Delete.
2125         (handle_output_debug_string): Replace main_thread_id by
2126         current_event.dwThreadId.
2127         (fake_create_process): Likewise.
2128         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2129         Do not set main_thread_id.
2130         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2131         current_event.dwThreadId.
2132         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2133
2134 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2135
2136         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2137         Use current_event.dwThreadId instead of main_thread_id.
2138
2139 2019-04-30  Tom Tromey  <tromey@adacore.com>
2140
2141         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2142         (create_excep_cond_exprs): Iterate over program spaces.
2143         (ada_exception_catchpoint_cond_string): Examine all minimal
2144         symbols for exception types.
2145
2146 2019-04-30  Tom Tromey  <tromey@adacore.com>
2147
2148         PR c++/24470:
2149         * dwarf2read.c (process_structure_scope): Handle case where type
2150         has template parameters but no symbol was created.
2151
2152 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2153             Chris January  <chris.january@arm.com>
2154
2155         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2156         qualifier.
2157         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2158
2159 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2160
2161         * f-typeprint.c (f_print_type): Update rules for printing
2162         whitespace.
2163         (f_type_print_varspec_suffix): Likewise.
2164
2165 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2166             Chris January  <chris.january@arm.com>
2167
2168         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2169         function arguments.
2170
2171 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2172
2173         * f-lang.c (build_fortran_types): Change name of void type to
2174         lower case.
2175         * f-typeprint.c (f_type_print_base): Print the name of the void
2176         type, rather than a fixed string.
2177         * f-valprint.c (f_decorations): Use lower case void string.
2178
2179 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2180             Chris January  <chris.january@arm.com>
2181
2182         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2183         types for Fortran.
2184
2185 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2186             Chris January  <chris.january@arm.com>
2187             David Lecomber  <david.lecomber@arm.com>
2188
2189         * f-exp.y (BINOP_INTRINSIC): New token.
2190         (exp): New parser rule handling BINOP_INTRINSIC.
2191         (f77_keywords): Add new builtin procedures.
2192         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2193         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2194         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2195         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2196         (print_unop_subexp_f): New function.
2197         (print_binop_subexp_f): New function.
2198         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2199         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2200         (dump_subexp_body_f): Likewise.
2201         (operator_check_f): Likewise.
2202         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2203         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2204
2205 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2206
2207         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2208         UNOP_KIND.
2209         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2210         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2211         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2212         (operator_length_f): New fuction.
2213         (print_subexp_f): New function.
2214         (op_name_f): New function.
2215         (dump_subexp_body_f): New function.
2216         (operator_check_f): New function.
2217         (exp_descriptor_f): Replace standard expression handling functions
2218         with new functions.
2219         * gdb/fortran-operator.def: New file.
2220         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2221         * gdb/std-operator.def: Remove UNOP_KIND.
2222
2223 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * std-operator.def: Remove unbalanced, stray double quote
2226         character.
2227
2228 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2229             Chris January  <chris.january@arm.com>
2230             Daniel Everett  <daniel.everett@arm.com>
2231             Nick Forrington  <nick.forrington@arm.com>
2232             Richard Bunt  <richard.bunt@arm.com>
2233
2234         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2235         of depth when printing anonymous structs or unions.
2236         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2237         Don't print either the top-level value, or the children if the
2238         max-depth is exceeded.
2239         (ppscm_print_children): When printing the key of a map, allow one
2240         extra level of depth.
2241         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2242         print either the top-level value, or the children if the max-depth
2243         is exceeded.
2244         (print_children): When printing the key of a map, allow one extra
2245         level of depth.
2246         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2247         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2248         (user_print_options): Initialise max_depth field.
2249         (val_print_scalar_or_string_type_p): New function.
2250         (val_print): Check to see if the max depth has been reached.
2251         (val_print_check_max_depth): Define new function.
2252         (show_print_max_depth): New function.
2253         (_initialize_valprint): Add 'print max-depth' option.
2254         * valprint.h (struct value_print_options) <max_depth>: New field.
2255         (val_print_check_max_depth): Declare new function.
2256         * NEWS: Document new feature.
2257
2258 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * ada-lang.c (ada_language_defn): Initialise new field.
2261         * c-lang.c (c_is_string_type_p): New function.
2262         (c_language_defn): Initialise new field.
2263         (cplus_language_defn): Initialise new field.
2264         (asm_language_defn): Initialise new field.
2265         (minimal_language_defn): Initialise new field.
2266         * c-lang.h (c_is_string_type_p): Declare new function.
2267         * d-lang.c (d_language_defn): Initialise new field.
2268         * f-lang.c (f_is_string_type_p): New function.
2269         (f_language_defn): Initialise new field.
2270         * go-lang.c (go_is_string_type_p): New function.
2271         (go_language_defn): Initialise new field.
2272         * language.c (default_is_string_type_p): New function.
2273         (unknown_language_defn): Initialise new field.
2274         (auto_language_defn): Initialise new field.
2275         * language.h (struct language_defn) <la_is_string_type_p>: New
2276         member variable.
2277         (default_is_string_type_p): Declare new function.
2278         * m2-lang.c (m2_language_defn): Initialise new field.
2279         * objc-lang.c (objc_language_defn): Initialise new field.
2280         * opencl-lang.c (opencl_language_defn): Initialise new field.
2281         * p-lang.c (pascal_is_string_type_p): New function.
2282         (pascal_language_defn): Initialise new field.
2283         * rust-lang.c (rust_is_string_type_p): New function.
2284         (rust_language_defn): Initialise new field.
2285
2286 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2289         New field.
2290         * ada-lang.c (ada_language_defn): Initialise new field.
2291         * c-lang.c (c_language_defn): Likewise.
2292         (cplus_language_defn): Likewise.
2293         (asm_language_defn): Likewise.
2294         (minimal_language_defn): Likewise.
2295         * d-lang.c (d_language_defn): Likewise.
2296         * f-lang.c (f_language_defn): Likewise.
2297         * go-lang.c (go_language_defn): Likewise.
2298         * language.c (unknown_language_defn): Likewise.
2299         (auto_language_defn): Likewise.
2300         * m2-lang.c (m2_language_defn): Likewise.
2301         * objc-lang.c (objc_language_defn): Likewise.
2302         * opencl-lang.c (opencl_language_defn): Likewise.
2303         * p-lang.c (pascal_language_defn): Likewise.
2304         * rust-lang.c (rust_language_defn): Likewise.
2305
2306 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * ada-lang.c (ada_is_character_type): Change return type to bool.
2309         (ada_is_string_type): Likewise.
2310         * ada-lang.h (ada_is_character_type): Update declaration
2311         (ada_is_string_type): Likewise.
2312
2313 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2314
2315         Support style in 'frame|thread apply'
2316
2317         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2318         * record.c (record_start, record_stop): Update callers of
2319         execute_command_to_string with false.
2320         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2321         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2322         methods.
2323         (class string_file): New constructor with term_out parameter.
2324         Override methods term_out and can_emit_style_escape.  New member
2325         term_out.
2326         (class stdio_file): Override can_emit_style_escape.
2327         (class tee_file): Override term_out and can_emit_style_escape.
2328         * utils.h (can_emit_style_escape): Remove.
2329         * utils.c (can_emit_style_escape): Likewise.
2330         Update all callers of can_emit_style_escape (SOMESTREAM) to
2331         SOMESTREAM->can_emit_style_escape.
2332         * source-cache.c (source_cache::get_source_lines): Likewise.
2333         * stack.c (frame_apply_command_count): Call execute_command_to_string
2334         passing the term_out characteristic of the current gdb_stdout.
2335         * thread.c (thr_try_catch_cmd): Likewise.
2336         * top.c (execute_command_to_string): pass term_out parameter
2337         to construct the string_file for the command output.
2338         * ui-file.c (term_cli_styling): New function (most code moved
2339         from utils.c can_emit_style_escape).
2340         (string_file::string_file, string_file::can_emit_style_escape,
2341         stdio_file::can_emit_style_escape, tee_file::term_out,
2342         tee_file::can_emit_style_escape): New functions.
2343
2344 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2345
2346         * NEWS: Mention the new set|show may-call-functions.
2347         * infcall.c (may_call_functions_p): New variable.
2348         (show_may_call_functions_p): New function.
2349         (call_function_by_hand_dummy): Throws an error if not
2350         may-call-functions.
2351         (_initialize_infcall): Call add_setshow_boolean_cmd for
2352         may-call-functions.
2353
2354 2019-04-25  Keith Seitz  <keiths@redhat.com>
2355
2356         PR c++/24367
2357         * cp-support.c (inspect_type): Don't attempt substitutions
2358         of symbol with the same name.
2359
2360 2019-04-25  Tom Tromey  <tromey@adacore.com>
2361
2362         PR gdb/24475:
2363         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2364         static.
2365
2366 2019-04-25  Tom Tromey  <tromey@adacore.com>
2367
2368         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2369         rvalue reference.
2370         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2371         (gdb_xml_parser::parse): Use std::move.
2372         * python/python-internal.h (gdbpy_convert_exception): Take a const
2373         reference.
2374         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2375         std::move.
2376         * python/py-utils.c (gdbpy_convert_exception): Take a const
2377         reference.
2378         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2379         Use std::move.
2380         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2381         Use std::move.
2382         * mi/mi-main.c (mi_print_exception): Take a const reference.
2383         * main.c (handle_command_errors): Take a const reference.
2384         * linespec.c (parse_linespec): Use std::move.
2385         * infcall.c (run_inferior_call): Use std::move.
2386         (call_function_by_hand_dummy): Use std::move.
2387         * exec.c (try_open_exec_file): Use std::move.
2388         * exceptions.h (exception_print, exception_fprintf)
2389         (exception_print_same): Update.
2390         * exceptions.c (print_exception, exception_print)
2391         (exception_fprintf, exception_print_same): Change parameters to
2392         const reference.
2393         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2394         * common/new-op.c: Use std::move.
2395         * common/common-exceptions.h (struct gdb_exception): Add move
2396         constructor.
2397         (struct gdb_exception_error, struct gdb_exception_quit, struct
2398         gdb_quit_bad_alloc): Change constructor to move constructor.
2399         (throw_exception): Change parameter to rvalue reference.
2400         * common/common-exceptions.c (throw_exception): Take rvalue
2401         reference.
2402         * cli/cli-interp.c (safe_execute_command): Use std::move.
2403         * breakpoint.c (insert_bp_location, location_to_sals): Use
2404         std::move.
2405
2406 2019-04-25  Tom Tromey  <tromey@adacore.com>
2407
2408         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2409         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2410         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2411         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2412         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2413         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2414         guile/scm-value.c: Use unpack.
2415         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2416         gdbscm_gdb_exception.
2417         (gdbscm_throw_gdb_exception): Likewise.
2418         (struct gdbscm_gdb_exception): New.
2419         (unpack): New function.
2420         (gdbscm_wrap): Use unpack.
2421
2422 2019-04-25  Tom Tromey  <tromey@adacore.com>
2423
2424         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2425         (gdb_rl_callback_handler): Use std::move.
2426         * common/common-exceptions.h (struct gdb_exception): Add move
2427         assignment operator.
2428         (throw_exception_sjlj): Change "exception" to const reference.
2429         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2430         (throw_exception_sjlj): Change "exception" to const reference.
2431
2432 2019-04-25  Tom Tromey  <tromey@adacore.com>
2433
2434         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2435         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2436         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2437         Update.
2438         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2439         Update.
2440         * mi/mi-interp.c (mi_interp::exec): Update.
2441         * linespec.c (parse_linespec): Update.
2442         * infcall.c (run_inferior_call): Update.
2443         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2444         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2445         (gdbscm_lookup_global_symbol): Update.
2446         * guile/scm-param.c (gdbscm_parameter_value): Update.
2447         * guile/scm-frame.c (gdbscm_frame_read_register)
2448         (gdbscm_frame_read_var): Update.
2449         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2450         * exec.c (try_open_exec_file): Update.
2451         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2452         (gdb_rl_callback_handler): Update.
2453         * common/common-exceptions.h (exception_none): Don't declare.
2454         * common/common-exceptions.c (exception_none): Don't define.
2455         (struct catcher) <exception>: Update.
2456         * cli/cli-interp.c (safe_execute_command): Update.
2457         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2458
2459 2019-04-25  Ali Tamur  <tamur@google.com>
2460
2461         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2462         (read_attribute_value): Likewise.
2463         (dwarf2_read_addr_index): Update comment.
2464         (read_str_index): Add DW_FORM_strx.
2465         (dwarf2_string_attr): Likewise.
2466         (dwarf2_const_value_attr): Likewise.
2467         (dump_die_shallow): Likewise.
2468         (dwarf2_fetch_constant_bytes): Likewise.
2469         (skip_form_bytes): Likewise.
2470         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2471
2472 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2473
2474         PR corefiles/11608
2475         PR corefiles/18187
2476         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2477         OFFSET.  Verify if current mapping contains an ELF header.
2478         (linux_find_memory_regions_full): Adjust call to
2479         dump_mapping_p.
2480
2481 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2482             Kang Li <kanglictf@gmail.com>
2483
2484         PR gdb/21600
2485
2486         * dwarf2-frame.c (read_initial_length): Be consistent about using
2487         unsigned representation of length.
2488         (decode_frame_entry_1): Likewise.  Check for wraparound of
2489         end pointer as well as buffer overflow.
2490
2491 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2492
2493         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2494         "vq".
2495
2496 2019-04-24  Tom Tromey  <tromey@adacore.com>
2497
2498         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2499
2500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * s12z-tdep.c (s12z_unwind_pc): Delete.
2503         (s12z_unwind_sp): Delete.
2504         (s12z_gdbarch_init): Don't register deleted functions with
2505         gdbarch.
2506
2507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * rl78-tdep.c (rl78_unwind_sp): Delete.
2510         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2511
2512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2515         (xstormy16_unwind_pc): Delete.
2516         (xstormy16_dummy_id): Delete.
2517         (xstormy16_gdbarch_init): Don't register deleted functions with
2518         gdbarch.
2519
2520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * vax-tdep.c (vax_unwind_pc): Delete.
2523         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2524
2525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * v850-tdep.c (v850_unwind_sp): Delete.
2528         (v850_unwind_pc): Delete.
2529         (v850_dummy_id): Delete.
2530         (v850_gdbarch_init): Don't register deleted functions with
2531         gdbarch.
2532
2533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2536         (tilegx_unwind_pc): Delete.
2537         (tilegx_unwind_dummy_id): Delete.
2538         (tilegx_gdbarch_init): Don't register deleted functions with
2539         gdbarch.
2540
2541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2544         (tic6x_dummy_id): Delete.
2545         (tic6x_gdbarch_init): Don't register deleted functions with
2546         gdbarch.
2547
2548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * sparc-tdep.c (sparc_unwind_pc): Delete.
2551         (sparc32_gdbarch_init): Don't register deleted function with
2552         gdbarch.
2553
2554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2555
2556         * sh-tdep.c (sh_unwind_sp): Delete.
2557         (sh_unwind_pc): Delete.
2558         (sh_dummy_id): Delete.
2559         (sh_gdbarch_init): Don't register deleted functions with
2560         gdbarch.
2561
2562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * score-tdep.c (score_unwind_sp): Delete.
2565         (score_unwind_pc): Delete.
2566         (score_dummy_id): Delete.
2567         (score_gdbarch_init): Don't register deleted functions with
2568         gdbarch.
2569
2570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * rx-tdep.c (rx_unwind_pc): Delete.
2573         (rx_unwind_sp): Delete.
2574         (rx_dummy_id): Delete.
2575         (rx_gdbarch_init): Don't register deleted functions with
2576         gdbarch.  Update comment.
2577
2578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2581         (rs6000_dummy_id): Delete.
2582         (rs6000_gdbarch_init): Don't register deleted functions with
2583         gdbarch.
2584
2585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * or1k-tdep.c (or1k_dummy_id): Delete.
2588         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2589
2590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2591
2592         * nios2-tdep.c (nios2_dummy_id): Delete.
2593         (nios2_unwind_sp): Delete.
2594         (nios2_gdbarch_init): Don't register deleted functions with
2595         gdbarch.
2596
2597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * nds32-tdep.c (nds32_dummy_id): Delete.
2600         (nds32_unwind_pc): Delete.
2601         (nds32_unwind_sp): Delete.
2602         (nds32_gdbarch_init): Don't register deleted functions with
2603         gdbarch.
2604
2605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * msp430-tdep.c (msp430_unwind_pc): Delete.
2608         (msp430_unwind_sp): Delete.
2609         (msp430_dummy_id): Delete.
2610         (msp430_gdbarch_init): Don't register deleted functions with
2611         gdbarch.
2612
2613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * moxie-tdep.c (moxie_unwind_sp): Delete.
2616         (moxie_unwind_pc): Delete.
2617         (moxie_dummy_id): Delete.
2618         (moxie_gdbarch_init): Don't register deleted functions with
2619         gdbarch.
2620
2621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2622
2623         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2624         (mn10300_unwind_pc): Delete.
2625         (mn10300_unwind_sp): Delete.
2626         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2627         mn10300_unwind_sp.
2628         (mn10300_frame_unwind_init): Don't register deleted functions with
2629         gdbarch.
2630
2631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * mep-tdep.c (mep_unwind_pc): Delete.
2634         (mep_unwind_sp): Delete.
2635         (mep_dummy_id): Delete.
2636         (mep_gdbarch_init): Don't register deleted functions with
2637         gdbarch.
2638
2639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2642         (m68hc11_unwind_sp): Delete.
2643         (m68hc11_gdbarch_init): Don't register deleted functions with
2644         gdbarch.
2645
2646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * m32r-tdep.c (m32r_unwind_sp): Delete.
2649         (m32r_unwind_pc): Delete.
2650         (m32r_dummy_id): Delete.
2651         (m32r_gdbarch_init): Don't register deleted functions with
2652         gdbarch.
2653
2654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2655
2656         * m32c-tdep.c (m32c_unwind_pc): Delete.
2657         (m32c_unwind_sp): Delete.
2658         (m32c_dummy_id): Delete.
2659         (m32c_gdbarch_init): Don't register deleted functions with
2660         gdbarch.
2661
2662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2663
2664         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2665         (lm32_unwind_pc): Delete.
2666         (lm32_dummy_id): Delete.
2667         (lm32_gdbarch_init): Don't register deleted functions with
2668         gdbarch.
2669
2670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2671
2672         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2673         (iq2000_unwind_pc): Delete.
2674         (iq2000_dummy_id): Delete.
2675         (iq2000_gdbarch_init): Don't register deleted functions with
2676         gdbarch.
2677
2678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * nds32-tdep.c (nds32_type_align): Delete.
2681         (nds32_push_dummy_call): Use type_align instead.
2682
2683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * arm-tdep.c (arm_type_align): Only handle vector override case.
2686         (arm_push_dummy_call): Use type_align.
2687         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2688
2689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2692         case.
2693         (pass_on_stack): Use type_align.
2694         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2695         function.
2696
2697 2019-04-23  Tom Tromey  <tromey@adacore.com>
2698
2699         * dwarf2read.c (line_header::file_name_at): Remove unused
2700         overload.
2701
2702 2019-04-23  Tom de Vries  <tdevries@suse.de>
2703
2704         PR gdb/24438
2705         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2706         invocation.
2707
2708
2709 2019-03-27  Ali Tamur  <tamur@google.com>
2710
2711         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2712         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2713         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2714         (dwarf_expr_context::get_addr_index): Likewise
2715         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2716         (symbol_needs_eval_context::get_addr_index): Likewise
2717         (disassemble_dwarf_expression): Add DW_OP_addrx
2718         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2719         (read_cutu_die_from_dwo): Update comment
2720         (skip_one_die): Add DW_FORM_addrx
2721         (read_attribute_value): Likewise
2722         (var_decode_location): Add DW_OP_addrx
2723         (dwarf2_const_value_attr): Add DW_FORM_addrx
2724         (dump_die_shallow): Likewise
2725         (dwarf2_fetch_constant_bytes): Likewise
2726         (decode_locdesc): Add DW_OP_addrx
2727         (skip_form_bytes): Add DW_FORM_addrx
2728
2729 2019-04-22  Ali Tamur  <tamur@google.com>
2730
2731         * MAINTAINERS (Write After Approval): Add self.
2732
2733 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2734
2735         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2736         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2737         (open_symbol_file_object): Likewise.
2738         (svr4_default_sos): Add info parameter.
2739         (svr4_read_so_list): Likewise.
2740         (svr4_current_sos_direct): Adjust functions calls to pass down
2741         info.
2742         (svr4_current_sos_1): Add info parameter.
2743         (svr4_current_sos): Call get_svr4_info, pass info down to
2744         svr4_current_sos_1.
2745         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2746         get_svr4_info.
2747         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2748         get_svr4_info.
2749         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2750         to get_svr4_info.
2751         (probes_table_remove_objfile_probes): Likewise.
2752         (register_solib_event_probe): Add info parameter.
2753         (solist_update_incremental): Pass info parameter down to
2754         svr4_read_so_list.
2755         (disable_probes_interface): Add info parameter.
2756         (svr4_handle_solib_event): Pass current_program_space to
2757         get_svr4_info.  Adjust disable_probes_interface cleanup.
2758         (svr4_create_probe_breakpoints): Add info parameter, pass it
2759         down to register_solib_event_probe.
2760         (svr4_create_solib_event_breakpoints): Add info parameter,
2761         pass it down to svr4_create_probe_breakpoints.
2762         (enable_break): Pass info down to
2763         svr4_create_solib_event_breakpoints.
2764         (svr4_solib_create_inferior_hook): Pass current_program_space to
2765         get_svr4_info.
2766         (svr4_clear_solib): Likewise.
2767
2768 2019-04-22  Pedro Alves  <palves@redhat.com>
2769
2770         * solib-svr4.c (svr4_free_objfile_observer): New.
2771         (probe_and_action::objfile): New field.
2772         (probes_table_htab_remove_objfile_probes)
2773         (probes_table_remove_objfile_probes): New functions.
2774         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2775         in the new probe_and_action.  Don't store the probe in 'lookup'.
2776         (svr4_create_probe_breakpoints): Pass objfile to
2777         register_solib_event_probe.
2778         (_initialize_svr4_solib): Register a free_objfile observer.
2779
2780 2019-04-19  Tom Tromey  <tom@tromey.com>
2781
2782         * common/queue.h: Remove.
2783
2784 2019-04-19  Tom Tromey  <tom@tromey.com>
2785
2786         * event-loop.c: Don't include "common/queue.h".
2787
2788 2019-04-19  Tom Tromey  <tom@tromey.com>
2789
2790         * remote.c (remote_target): Use delete.
2791         * remote-notif.h: Include <list>, not "common/queue.h".
2792         (notif_client_p): Remove typedef.
2793         (remote_notif_state): Add constructor, destructor, initializer.
2794         <notif_queue>: Now a std::list.
2795         (remote_notif_state_xfree): Don't declare.
2796         * remote-notif.c (remote_notif_process, handle_notification)
2797         (remote_notif_state_allocate): Update.
2798         (~remote_notif_state): Rename from remote_notif_state_xfree.
2799
2800 2019-04-19  Tom Tromey  <tom@tromey.com>
2801
2802         * symfile.c (reread_symbols): Update.
2803         * objfiles.c (objfile_register_static_link)
2804         (objfile_lookup_static_link): Update
2805         (~objfile) Don't delete static_links.
2806         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2807
2808 2019-04-19  Tom Tromey  <tom@tromey.com>
2809
2810         * type-stack.h (struct type_stack) <insert>: Constify string.
2811         * type-stack.c (type_stack::insert): Constify string.
2812         * gdbtypes.h (lookup_template_type): Update.
2813         (address_space_name_to_int): Update.
2814         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2815         const.
2816         (lookup_template_type): Make name const.
2817         * c-exp.y: Update rules.
2818         (lex_one_token, classify_name, classify_inner_name)
2819         (c_print_token): Update.
2820         * p-exp.y: Update rules.
2821         (yylex): Update.
2822         * f-exp.y: Update rules.
2823         (yylex): Update.
2824         * d-exp.y: Update rules.
2825         (lex_one_token, classify_name, classify_inner_name): Update.
2826         * parse.c (write_dollar_variable, copy_name): Return std::string.
2827         * parser-defs.h (copy_name): Change return type.
2828         * m2-exp.y: Update rules.
2829         (yylex): Update.
2830         * go-exp.y (lex_one_token): Update.
2831         Update rules.
2832         (classify_unsafe_function, classify_packaged_name)
2833         (classify_name, yylex): Update.
2834
2835 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2836
2837         * configure.ac: add --enable-source-highlight switch.
2838         * configure: Regenerate.
2839         * top.c (print_gdb_version): plumb --enable-source-highlight
2840         status to "show configuration".
2841
2842 2019-04-19  Tom Tromey  <tromey@adacore.com>
2843
2844         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2845         Check ADA_TYPE_P.
2846         (empty_record, ada_template_to_fixed_record_type_1)
2847         (template_to_static_fixed_type)
2848         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2849         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2850         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2851         macros.
2852
2853 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2854
2855         PR symtab/24423:
2856         * source.c (print_source_lines_base): Advance "iter" when a
2857         control character is seen.
2858
2859 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2860
2861         * inferior.h (struct infcall_suspend_state_deleter):
2862         Catch exception in destructor to avoid crash.
2863
2864 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2865
2866         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2867         close to the add_com "shell".
2868
2869 2019-04-18  Tom Tromey  <tromey@adacore.com>
2870
2871         * process-stratum-target.h (class process_stratum_target)
2872         <stratum>: Add "final".
2873
2874 2019-04-17  Tom Tromey  <tromey@adacore.com>
2875
2876         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2877         against nullptr before use.
2878
2879 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2880
2881         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2882
2883 2019-04-17  Jim Wilson  <jimw@sifive.com>
2884             Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2887         code read might fail, assume 4-byte breakpoint in that case.
2888
2889 2019-04-15  Leszek Swirski  <leszeks@google.com>
2890
2891         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2892         rather than a hand-rolled POD check when checking for forced MEMORY
2893         classification.
2894
2895 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2896
2897         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2898         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2899         function.
2900         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2901         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2902         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2903         declaration.
2904
2905 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * aarch64-linux-nat.c
2908         (aarch64_linux_nat_target::thread_architecture): Add override.
2909         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2910         each VQ.
2911
2912 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2913
2914         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2915
2916 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2919         target types of size 96-bits, add some additional comments, and
2920         check that the builtin type we found was the correct size.
2921
2922 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2923
2924         * utils.c (prompt_for_continue): Don't restore the styling at the
2925         end, as applied_style has the wrong value.  This fixes styling in
2926         long lists of file names that are interrupted by the "Continue?"
2927         prompt.
2928
2929 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2932         * c-lang.c (c_language_defn): Likewise.
2933         (cplus_language_defn): Likewise.
2934         (asm_language_defn): Likewise.
2935         (minimal_language_defn): Likewise.
2936         * d-lang.c (d_language_defn): Likewise.
2937         * f-lang.c (f_language_defn): Likewise.
2938         * go-lang.c (go_language_defn): Likewise.
2939         * language.c (unknown_language_defn): Likewise.
2940         (auto_language_defn): Likewise.
2941         * language.h (struct language_defn): Remove la_magic field.
2942         (LANG_MAGIC): Delete.
2943         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2944         * objc-lang.c (objc_language_defn): Likewise.
2945         * opencl-lang.c (opencl_language_defn): Likewise.
2946         * p-lang.c (pascal_language_defn): Likewise.
2947         * rust-lang.c (rust_language_defn): Likewise.
2948
2949 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * riscv-tdep.c (riscv_type_align): New function.
2952         (riscv_type_alignment): Delete.
2953         (riscv_arg_location): Use 'type_align'.
2954         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2955
2956 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2957
2958         * gdbtypes.c (type_align): A struct with no non-static fields also
2959         has alignment of 1.
2960
2961 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2964         component to 0.
2965         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2966         member.
2967         (riscv_struct_info::analyse): New implementation using new
2968         analyse_inner member function.
2969         (riscv_struct_info::field_offset): New member function.
2970         (riscv_struct_info::m_offsets): New member variable.
2971         (riscv_struct_info::analyse_inner): New private member function,
2972         takes the old implementation of riscv_struct_info::analyse but
2973         extended to track field offsets.
2974         (riscv_call_arg_struct): Update the struct folding special cases
2975         to handle cases where empty C++ structs, which are non-zero
2976         length, are found.
2977         (riscv_arg_location): Initialise the length of each location, a
2978         non-zero length now indicates the location is in use.
2979         (riscv_push_dummy_call): Allow for the first location having a
2980         non-zero offset when setting up arguments.
2981         (riscv_return_value): Likewise, but for return values.
2982
2983 2019-04-11  Tom Tromey  <tromey@adacore.com>
2984
2985         * utils.c (internal_vproblem): Make "msg" const.
2986
2987 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2988
2989         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2990         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2991         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2992         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2993
2994 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2995
2996         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2997         function.
2998         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2999         of amd64_collect_native_gregset.
3000         (amd64_linux_nat_target::store_registers): Likewise.
3001
3002 2019-04-10  Tom Tromey  <tom@tromey.com>
3003
3004         * symtab.c (lookup_global_symbol_from_objfile)
3005         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3006         * objfiles.h (class separate_debug_iterator): New.
3007         (class separate_debug_range): New.
3008         (struct objfile) <separate_debug_objfiles>: New method.
3009         (objfile_separate_debug_iterate): Don't declare.
3010         * objfiles.c (separate_debug_iterator::operator++): Rename from
3011         objfile_separate_debug_iterate.
3012         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3013         iterator.
3014         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3015         iterator.
3016
3017 2019-04-10  Tom Tromey  <tom@tromey.com>
3018
3019         * symfile.c (reread_symbols): Remove old comment.
3020         * objfiles.c (free_all_objfiles): Fix a typo.
3021
3022 2019-04-10  Tom Tromey  <tom@tromey.com>
3023
3024         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3025         * minsyms.c (lookup_minimal_symbol): Use foreach.
3026         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3027         (lookup_minimal_symbol_solib_trampoline): Likewise.
3028         * symfile.c (reread_symbols): Use foreach.
3029
3030 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3031             Tom Tromey  <tromey@adacore.com>
3032
3033         PR rust/24414:
3034         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3035         (rust_lex_int_test): Change "value" to be LONGEST.
3036         (rust_lex_tests): Add test for long integer literal.
3037
3038 2019-04-09  Tom Tromey  <tromey@adacore.com>
3039
3040         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3041         to bool.
3042         (extended_remote_target::attach): Update.
3043         (remote_target::remote_notice_new_inferior): Update.
3044         (remote_target::add_current_inferior_and_thread): Update.
3045         * inferior.c (exit_inferior_1): Use "false".
3046         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3047
3048 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3049
3050         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3051         the "start" command.
3052
3053 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3054
3055         * python/py-inferior.c (infpy_thread_from_thread_handle):
3056         Adjust comments to reflect renaming of thread_from_thread_handle
3057         to thread_from_handle.  Adjust keywords.  Fix type error message.
3058         (inferior_object_methods): Add thread_from_handle.  Retain
3059         thread_from_thread_handle, but mark it as deprecated.
3060
3061 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3062
3063         * gdbthread.h (find_thread_by_handle): Revise declaration.
3064         * thread.c (find_thread_by_handle): Likewise.  Adjust
3065         implementation too.
3066         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3067         support for buffer objects as handles.
3068
3069 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3070
3071         * python/py-infthread.c (thpy_thread_handle): New function.
3072         (thread_object_methods): Register thpy_thread_handle.
3073
3074 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3075
3076         * gdbthread.h (thread_to_thread_handle): Declare.
3077         * thread.c (gdbtypes.h): Include.
3078         (thread_to_thread_handle): New function.
3079
3080         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3081         (target_thread_info_to_thread_handle): Declare.
3082         * target.c (target_thread_info_to_thread_handle): New function.
3083         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3084         * target-delegates.c: Regenerate.
3085
3086         * linux-thread-db.c (class thread_db_target): Add method
3087         thread_info_to_thread_handle.
3088         (thread_db_target::thread_info_to_thread_handle): Define.
3089         * remote.c (class remote_target): Add new method
3090         thread_info_to_thread_handle.
3091         (remote_target::thread_info_to_thread_handle): Define.
3092
3093 2019-04-08  Pedro Alves  <palves@redhat.com>
3094
3095         * common/common-exceptions.c (throw_exception): Don't create
3096         named object to throw; throw directly.
3097         (throw_it): Likewise.  Don't initialize gdb_exception::message
3098         here, with new; pass FMT and AP to the ctor instead.
3099         * common/common-exceptions.h: Include <string>.
3100         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3101         const char *, va_list)): New ctor.  Use std::make_shared.
3102         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3103         errors)): Delete.
3104         (gdb_exception_error::gdb_exception_error(enum errors, const char
3105         *, va_list)): New.
3106         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3107         Add assertion.
3108         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3109         errors)): Delete.
3110         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3111         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3112         Add assertion.
3113
3114 2019-04-08  Tom Tromey  <tom@tromey.com>
3115
3116         * valops.c (value_rtti_indirect_type): Replace throw_exception
3117         with throw.
3118         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3119         with throw.
3120         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3121         throw.
3122         * target.c (target_translate_tls_address): Replace throw_exception
3123         with throw.
3124         * stack.c (frame_apply_command_count): Replace throw_exception
3125         with throw.
3126         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3127         throw.
3128         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3129         with throw.
3130         * rs6000-tdep.c (rs6000_frame_cache)
3131         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3132         * remote.c: Replace throw_exception with throw.
3133         * record-full.c (record_full_message, record_full_wait_1)
3134         (record_full_restore): Replace throw_exception with throw.
3135         * record-btrace.c:
3136         (get_thread_current_frame_id, record_btrace_start_replaying)
3137         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3138         (cmd_record_btrace_start): Replace throw_exception with throw.
3139         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3140         throw.
3141         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3142         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3143         * linespec.c:
3144         (find_linespec_symbols): Replace throw_exception with throw.
3145         * infrun.c (displaced_step_prepare, resume): Replace
3146         throw_exception with throw.
3147         * infcmd.c (post_create_inferior): Replace throw_exception with
3148         throw.
3149         * inf-loop.c (inferior_event_handler): Replace throw_exception
3150         with throw.
3151         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3152         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3153         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3154         (get_prev_frame_always, get_frame_pc_if_available)
3155         (get_frame_address_in_block_if_available, get_frame_language):
3156         Replace throw_exception with throw.
3157         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3158         throw_exception with throw.
3159         * eval.c (fetch_subexp_value, evaluate_var_value)
3160         (evaluate_funcall, evaluate_subexp_standard): Replace
3161         throw_exception with throw.
3162         * dwarf2loc.c (call_site_find_chain)
3163         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3164         Replace throw_exception with throw.
3165         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3166         with throw.
3167         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3168         throw.
3169         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3170         * completer.c (complete_line_internal): Replace throw_exception
3171         with throw.
3172         * compile/compile-object-run.c (compile_object_run): Replace
3173         throw_exception with throw.
3174         * cli/cli-script.c (process_next_line): Replace throw_exception
3175         with throw.
3176         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3177         (btrace_enable, btrace_maint_update_pt_packets): Replace
3178         throw_exception with throw.
3179         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3180         throw_exception with throw.
3181         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3182         throw_exception with throw.
3183         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3184         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3185         * aarch64-tdep.c (aarch64_make_prologue_cache)
3186         (aarch64_make_stub_cache): Replace throw_exception with throw.
3187
3188 2019-04-08  Tom Tromey  <tom@tromey.com>
3189
3190         * common/common-exceptions.c (throw_exception): Rename from
3191         throw_exception_cxx.  Remove old copy.  Make argument const.
3192         (throw_it): Create and throw exception objects directly.
3193         * common/common-exceptions.h (throw_exception): Make argument
3194         const.
3195         (struct gdb_exception_error): Add constructor.
3196         (struct gdb_exception_quit): Add constructor.
3197
3198 2019-04-08  Tom Tromey  <tom@tromey.com>
3199
3200         * common/common-exceptions.h (exception_rethrow): Don't declare.
3201         (TRY_SJLJ): Update comment.
3202         (TRY, CATCH, END_CATCH): Remove.
3203         * common/common-exceptions.c (exception_rethrow): Remove.
3204
3205 2019-04-08  Tom Tromey  <tom@tromey.com>
3206
3207         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3208         Remove.
3209         (gdb_exception_error): Rename from
3210         gdb_exception_RETURN_MASK_ERROR.
3211         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3212         (gdb_quit_bad_alloc): Update.
3213         * aarch64-tdep.c: Update.
3214         * ada-lang.c: Update.
3215         * ada-typeprint.c: Update.
3216         * ada-valprint.c: Update.
3217         * amd64-tdep.c: Update.
3218         * arch-utils.c: Update.
3219         * break-catch-throw.c: Update.
3220         * breakpoint.c: Update.
3221         * btrace.c: Update.
3222         * c-varobj.c: Update.
3223         * cli/cli-cmds.c: Update.
3224         * cli/cli-interp.c: Update.
3225         * cli/cli-script.c: Update.
3226         * common/common-exceptions.c: Update.
3227         * common/new-op.c: Update.
3228         * common/selftest.c: Update.
3229         * compile/compile-c-symbols.c: Update.
3230         * compile/compile-cplus-symbols.c: Update.
3231         * compile/compile-object-load.c: Update.
3232         * compile/compile-object-run.c: Update.
3233         * completer.c: Update.
3234         * corelow.c: Update.
3235         * cp-abi.c: Update.
3236         * cp-support.c: Update.
3237         * cp-valprint.c: Update.
3238         * darwin-nat.c: Update.
3239         * disasm-selftests.c: Update.
3240         * dtrace-probe.c: Update.
3241         * dwarf-index-cache.c: Update.
3242         * dwarf-index-write.c: Update.
3243         * dwarf2-frame-tailcall.c: Update.
3244         * dwarf2-frame.c: Update.
3245         * dwarf2loc.c: Update.
3246         * dwarf2read.c: Update.
3247         * eval.c: Update.
3248         * event-loop.c: Update.
3249         * event-top.c: Update.
3250         * exec.c: Update.
3251         * f-valprint.c: Update.
3252         * fbsd-tdep.c: Update.
3253         * frame-unwind.c: Update.
3254         * frame.c: Update.
3255         * gdbtypes.c: Update.
3256         * gnu-v3-abi.c: Update.
3257         * guile/guile-internal.h: Update.
3258         * guile/scm-block.c: Update.
3259         * guile/scm-breakpoint.c: Update.
3260         * guile/scm-cmd.c: Update.
3261         * guile/scm-disasm.c: Update.
3262         * guile/scm-frame.c: Update.
3263         * guile/scm-lazy-string.c: Update.
3264         * guile/scm-math.c: Update.
3265         * guile/scm-param.c: Update.
3266         * guile/scm-ports.c: Update.
3267         * guile/scm-pretty-print.c: Update.
3268         * guile/scm-symbol.c: Update.
3269         * guile/scm-symtab.c: Update.
3270         * guile/scm-type.c: Update.
3271         * guile/scm-value.c: Update.
3272         * i386-linux-tdep.c: Update.
3273         * i386-tdep.c: Update.
3274         * inf-loop.c: Update.
3275         * infcall.c: Update.
3276         * infcmd.c: Update.
3277         * infrun.c: Update.
3278         * jit.c: Update.
3279         * language.c: Update.
3280         * linespec.c: Update.
3281         * linux-fork.c: Update.
3282         * linux-nat.c: Update.
3283         * linux-tdep.c: Update.
3284         * linux-thread-db.c: Update.
3285         * main.c: Update.
3286         * mi/mi-cmd-break.c: Update.
3287         * mi/mi-cmd-stack.c: Update.
3288         * mi/mi-interp.c: Update.
3289         * mi/mi-main.c: Update.
3290         * objc-lang.c: Update.
3291         * p-valprint.c: Update.
3292         * parse.c: Update.
3293         * ppc-linux-tdep.c: Update.
3294         * printcmd.c: Update.
3295         * python/py-arch.c: Update.
3296         * python/py-breakpoint.c: Update.
3297         * python/py-cmd.c: Update.
3298         * python/py-finishbreakpoint.c: Update.
3299         * python/py-frame.c: Update.
3300         * python/py-framefilter.c: Update.
3301         * python/py-gdb-readline.c: Update.
3302         * python/py-inferior.c: Update.
3303         * python/py-infthread.c: Update.
3304         * python/py-lazy-string.c: Update.
3305         * python/py-linetable.c: Update.
3306         * python/py-objfile.c: Update.
3307         * python/py-param.c: Update.
3308         * python/py-prettyprint.c: Update.
3309         * python/py-progspace.c: Update.
3310         * python/py-record-btrace.c: Update.
3311         * python/py-record.c: Update.
3312         * python/py-symbol.c: Update.
3313         * python/py-type.c: Update.
3314         * python/py-unwind.c: Update.
3315         * python/py-utils.c: Update.
3316         * python/py-value.c: Update.
3317         * python/python.c: Update.
3318         * record-btrace.c: Update.
3319         * record-full.c: Update.
3320         * remote-fileio.c: Update.
3321         * remote.c: Update.
3322         * riscv-tdep.c: Update.
3323         * rs6000-aix-tdep.c: Update.
3324         * rs6000-tdep.c: Update.
3325         * rust-exp.y: Update.
3326         * rust-lang.c: Update.
3327         * s390-tdep.c: Update.
3328         * selftest-arch.c: Update.
3329         * solib-dsbt.c: Update.
3330         * solib-frv.c: Update.
3331         * solib-spu.c: Update.
3332         * solib-svr4.c: Update.
3333         * solib.c: Update.
3334         * sparc64-linux-tdep.c: Update.
3335         * stack.c: Update.
3336         * symfile-mem.c: Update.
3337         * symmisc.c: Update.
3338         * target.c: Update.
3339         * thread.c: Update.
3340         * top.c: Update.
3341         * tracefile-tfile.c: Update.
3342         * tui/tui.c: Update.
3343         * typeprint.c: Update.
3344         * unittests/cli-utils-selftests.c: Update.
3345         * unittests/parse-connection-spec-selftests.c: Update.
3346         * valops.c: Update.
3347         * valprint.c: Update.
3348         * value.c: Update.
3349         * varobj.c: Update.
3350         * windows-nat.c: Update.
3351         * x86-linux-nat.c: Update.
3352         * xml-support.c: Update.
3353
3354 2019-04-08  Tom Tromey  <tom@tromey.com>
3355
3356         * xml-support.c: Use C++ exception handling.
3357         * x86-linux-nat.c: Use C++ exception handling.
3358         * windows-nat.c: Use C++ exception handling.
3359         * varobj.c: Use C++ exception handling.
3360         * value.c: Use C++ exception handling.
3361         * valprint.c: Use C++ exception handling.
3362         * valops.c: Use C++ exception handling.
3363         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3364         handling.
3365         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3366         * typeprint.c: Use C++ exception handling.
3367         * tui/tui.c: Use C++ exception handling.
3368         * tracefile-tfile.c: Use C++ exception handling.
3369         * top.c: Use C++ exception handling.
3370         * thread.c: Use C++ exception handling.
3371         * target.c: Use C++ exception handling.
3372         * symmisc.c: Use C++ exception handling.
3373         * symfile-mem.c: Use C++ exception handling.
3374         * stack.c: Use C++ exception handling.
3375         * sparc64-linux-tdep.c: Use C++ exception handling.
3376         * solib.c: Use C++ exception handling.
3377         * solib-svr4.c: Use C++ exception handling.
3378         * solib-spu.c: Use C++ exception handling.
3379         * solib-frv.c: Use C++ exception handling.
3380         * solib-dsbt.c: Use C++ exception handling.
3381         * selftest-arch.c: Use C++ exception handling.
3382         * s390-tdep.c: Use C++ exception handling.
3383         * rust-lang.c: Use C++ exception handling.
3384         * rust-exp.y: Use C++ exception handling.
3385         * rs6000-tdep.c: Use C++ exception handling.
3386         * rs6000-aix-tdep.c: Use C++ exception handling.
3387         * riscv-tdep.c: Use C++ exception handling.
3388         * remote.c: Use C++ exception handling.
3389         * remote-fileio.c: Use C++ exception handling.
3390         * record-full.c: Use C++ exception handling.
3391         * record-btrace.c: Use C++ exception handling.
3392         * python/python.c: Use C++ exception handling.
3393         * python/py-value.c: Use C++ exception handling.
3394         * python/py-utils.c: Use C++ exception handling.
3395         * python/py-unwind.c: Use C++ exception handling.
3396         * python/py-type.c: Use C++ exception handling.
3397         * python/py-symbol.c: Use C++ exception handling.
3398         * python/py-record.c: Use C++ exception handling.
3399         * python/py-record-btrace.c: Use C++ exception handling.
3400         * python/py-progspace.c: Use C++ exception handling.
3401         * python/py-prettyprint.c: Use C++ exception handling.
3402         * python/py-param.c: Use C++ exception handling.
3403         * python/py-objfile.c: Use C++ exception handling.
3404         * python/py-linetable.c: Use C++ exception handling.
3405         * python/py-lazy-string.c: Use C++ exception handling.
3406         * python/py-infthread.c: Use C++ exception handling.
3407         * python/py-inferior.c: Use C++ exception handling.
3408         * python/py-gdb-readline.c: Use C++ exception handling.
3409         * python/py-framefilter.c: Use C++ exception handling.
3410         * python/py-frame.c: Use C++ exception handling.
3411         * python/py-finishbreakpoint.c: Use C++ exception handling.
3412         * python/py-cmd.c: Use C++ exception handling.
3413         * python/py-breakpoint.c: Use C++ exception handling.
3414         * python/py-arch.c: Use C++ exception handling.
3415         * printcmd.c: Use C++ exception handling.
3416         * ppc-linux-tdep.c: Use C++ exception handling.
3417         * parse.c: Use C++ exception handling.
3418         * p-valprint.c: Use C++ exception handling.
3419         * objc-lang.c: Use C++ exception handling.
3420         * mi/mi-main.c: Use C++ exception handling.
3421         * mi/mi-interp.c: Use C++ exception handling.
3422         * mi/mi-cmd-stack.c: Use C++ exception handling.
3423         * mi/mi-cmd-break.c: Use C++ exception handling.
3424         * main.c: Use C++ exception handling.
3425         * linux-thread-db.c: Use C++ exception handling.
3426         * linux-tdep.c: Use C++ exception handling.
3427         * linux-nat.c: Use C++ exception handling.
3428         * linux-fork.c: Use C++ exception handling.
3429         * linespec.c: Use C++ exception handling.
3430         * language.c: Use C++ exception handling.
3431         * jit.c: Use C++ exception handling.
3432         * infrun.c: Use C++ exception handling.
3433         * infcmd.c: Use C++ exception handling.
3434         * infcall.c: Use C++ exception handling.
3435         * inf-loop.c: Use C++ exception handling.
3436         * i386-tdep.c: Use C++ exception handling.
3437         * i386-linux-tdep.c: Use C++ exception handling.
3438         * guile/scm-value.c: Use C++ exception handling.
3439         * guile/scm-type.c: Use C++ exception handling.
3440         * guile/scm-symtab.c: Use C++ exception handling.
3441         * guile/scm-symbol.c: Use C++ exception handling.
3442         * guile/scm-pretty-print.c: Use C++ exception handling.
3443         * guile/scm-ports.c: Use C++ exception handling.
3444         * guile/scm-param.c: Use C++ exception handling.
3445         * guile/scm-math.c: Use C++ exception handling.
3446         * guile/scm-lazy-string.c: Use C++ exception handling.
3447         * guile/scm-frame.c: Use C++ exception handling.
3448         * guile/scm-disasm.c: Use C++ exception handling.
3449         * guile/scm-cmd.c: Use C++ exception handling.
3450         * guile/scm-breakpoint.c: Use C++ exception handling.
3451         * guile/scm-block.c: Use C++ exception handling.
3452         * guile/guile-internal.h: Use C++ exception handling.
3453         * gnu-v3-abi.c: Use C++ exception handling.
3454         * gdbtypes.c: Use C++ exception handling.
3455         * frame.c: Use C++ exception handling.
3456         * frame-unwind.c: Use C++ exception handling.
3457         * fbsd-tdep.c: Use C++ exception handling.
3458         * f-valprint.c: Use C++ exception handling.
3459         * exec.c: Use C++ exception handling.
3460         * event-top.c: Use C++ exception handling.
3461         * event-loop.c: Use C++ exception handling.
3462         * eval.c: Use C++ exception handling.
3463         * dwarf2read.c: Use C++ exception handling.
3464         * dwarf2loc.c: Use C++ exception handling.
3465         * dwarf2-frame.c: Use C++ exception handling.
3466         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3467         * dwarf-index-write.c: Use C++ exception handling.
3468         * dwarf-index-cache.c: Use C++ exception handling.
3469         * dtrace-probe.c: Use C++ exception handling.
3470         * disasm-selftests.c: Use C++ exception handling.
3471         * darwin-nat.c: Use C++ exception handling.
3472         * cp-valprint.c: Use C++ exception handling.
3473         * cp-support.c: Use C++ exception handling.
3474         * cp-abi.c: Use C++ exception handling.
3475         * corelow.c: Use C++ exception handling.
3476         * completer.c: Use C++ exception handling.
3477         * compile/compile-object-run.c: Use C++ exception handling.
3478         * compile/compile-object-load.c: Use C++ exception handling.
3479         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3480         * compile/compile-c-symbols.c: Use C++ exception handling.
3481         * common/selftest.c: Use C++ exception handling.
3482         * common/new-op.c: Use C++ exception handling.
3483         * cli/cli-script.c: Use C++ exception handling.
3484         * cli/cli-interp.c: Use C++ exception handling.
3485         * cli/cli-cmds.c: Use C++ exception handling.
3486         * c-varobj.c: Use C++ exception handling.
3487         * btrace.c: Use C++ exception handling.
3488         * breakpoint.c: Use C++ exception handling.
3489         * break-catch-throw.c: Use C++ exception handling.
3490         * arch-utils.c: Use C++ exception handling.
3491         * amd64-tdep.c: Use C++ exception handling.
3492         * ada-valprint.c: Use C++ exception handling.
3493         * ada-typeprint.c: Use C++ exception handling.
3494         * ada-lang.c: Use C++ exception handling.
3495         * aarch64-tdep.c: Use C++ exception handling.
3496
3497 2019-04-08  Tom Tromey  <tom@tromey.com>
3498
3499         * xml-support.c (gdb_xml_parser::parse): Update.
3500         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3501         * value.c (show_convenience): Update.
3502         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3503         (test_parse_flags_qcs): Update.
3504         * thread.c (thr_try_catch_cmd): Update.
3505         * target.c (target_translate_tls_address): Update.
3506         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3507         (info_frame_command_core, frame_apply_command_count): Update.
3508         * rust-exp.y (rust_lex_exception_test): Update.
3509         * riscv-tdep.c (riscv_print_one_register_info): Update.
3510         * remote.c (remote_target::enable_btrace): Update.
3511         * record-btrace.c (record_btrace_enable_warn): Update.
3512         * python/py-utils.c (gdbpy_convert_exception): Update.
3513         * printcmd.c (do_one_display, print_variable_and_value): Update.
3514         * mi/mi-main.c (mi_print_exception): Update.
3515         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3516         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3517         * linux-nat.c (linux_nat_target::attach): Update.
3518         * linux-fork.c (class scoped_switch_fork_info): Update.
3519         * infrun.c (displaced_step_prepare): Update.
3520         * infcall.c (call_function_by_hand_dummy): Update.
3521         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3522         * gnu-v3-abi.c (print_one_vtable): Update.
3523         * frame.c (get_prev_frame_always): Update.
3524         * f-valprint.c (info_common_command_for_block): Update.
3525         * exec.c (try_open_exec_file): Update.
3526         * exceptions.c (print_exception, exception_print)
3527         (exception_fprintf, exception_print_same): Update.
3528         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3529         * dwarf-index-cache.c (index_cache::store)
3530         (index_cache::lookup_gdb_index): Update.
3531         * darwin-nat.c (maybe_cache_shell): Update.
3532         * cp-valprint.c (cp_print_value_fields): Update.
3533         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3534         (gcc_cplus_symbol_address): Update.
3535         * compile/compile-c-symbols.c (gcc_convert_symbol)
3536         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3537         * common/selftest.c: Update.
3538         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3539         a std::string.
3540         (exception_try_scope_entry, exception_try_scope_exit): Don't
3541         declare.
3542         (struct exception_try_scope): Remove.
3543         (TRY): Don't use exception_try_scope.
3544         (struct gdb_exception): Add constructor, operator=.
3545         <what>: New method.
3546         (struct gdb_exception_RETURN_MASK_ALL)
3547         (struct gdb_exception_RETURN_MASK_ERROR)
3548         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3549         (struct gdb_quit_bad_alloc): Update.
3550         * common/common-exceptions.c (exception_none): Change
3551         initializer.
3552         (struct catcher) <state, exception>: Initialize inline.
3553         <prev>: Remove member.
3554         (current_catcher): Remove.
3555         (catchers): New global.
3556         (exceptions_state_mc_init): Simplify.
3557         (catcher_pop): Remove.
3558         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3559         (try_scope_depth, exception_try_scope_entry)
3560         (exception_try_scope_exit): Remove.
3561         (throw_exception_sjlj): Update.
3562         (exception_messages, exception_messages_size): Remove.
3563         (throw_it): Simplify.
3564         (gdb_exception_sliced_copy): Remove.
3565         (throw_exception_cxx): Update.
3566         * cli/cli-script.c (script_from_file): Update.
3567         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3568         Update.
3569         * ada-valprint.c (ada_val_print): Update.
3570         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3571         (create_excep_cond_exprs): Update.
3572
3573 2019-04-08  Tom Tromey  <tom@tromey.com>
3574
3575         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3576         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3577         (TRY, CATCH, END_CATCH): Remove some definitions.
3578         * common/common-exceptions.c: Don't use GDB_XCPT.
3579         (catcher_list_size): Remove.
3580         (throw_exception, throw_it): Simplify.
3581
3582 2019-04-05  Tom Tromey  <tom@tromey.com>
3583
3584         Revert the header-sorting patch.
3585         * ft32-tdep.c: Revert.
3586         * frv-tdep.c: Revert.
3587         * frv-linux-tdep.c: Revert.
3588         * frame.c: Revert.
3589         * frame-unwind.c: Revert.
3590         * frame-base.c: Revert.
3591         * fork-child.c: Revert.
3592         * findvar.c: Revert.
3593         * findcmd.c: Revert.
3594         * filesystem.c: Revert.
3595         * filename-seen-cache.h: Revert.
3596         * filename-seen-cache.c: Revert.
3597         * fbsd-tdep.c: Revert.
3598         * fbsd-nat.h: Revert.
3599         * fbsd-nat.c: Revert.
3600         * f-valprint.c: Revert.
3601         * f-typeprint.c: Revert.
3602         * f-lang.c: Revert.
3603         * extension.h: Revert.
3604         * extension.c: Revert.
3605         * extension-priv.h: Revert.
3606         * expprint.c: Revert.
3607         * exec.h: Revert.
3608         * exec.c: Revert.
3609         * exceptions.c: Revert.
3610         * event-top.c: Revert.
3611         * event-loop.c: Revert.
3612         * eval.c: Revert.
3613         * elfread.c: Revert.
3614         * dwarf2read.h: Revert.
3615         * dwarf2read.c: Revert.
3616         * dwarf2loc.c: Revert.
3617         * dwarf2expr.h: Revert.
3618         * dwarf2expr.c: Revert.
3619         * dwarf2-frame.c: Revert.
3620         * dwarf2-frame-tailcall.c: Revert.
3621         * dwarf-index-write.h: Revert.
3622         * dwarf-index-write.c: Revert.
3623         * dwarf-index-common.c: Revert.
3624         * dwarf-index-cache.h: Revert.
3625         * dwarf-index-cache.c: Revert.
3626         * dummy-frame.c: Revert.
3627         * dtrace-probe.c: Revert.
3628         * disasm.h: Revert.
3629         * disasm.c: Revert.
3630         * disasm-selftests.c: Revert.
3631         * dictionary.c: Revert.
3632         * dicos-tdep.c: Revert.
3633         * demangle.c: Revert.
3634         * dcache.h: Revert.
3635         * dcache.c: Revert.
3636         * darwin-nat.h: Revert.
3637         * darwin-nat.c: Revert.
3638         * darwin-nat-info.c: Revert.
3639         * d-valprint.c: Revert.
3640         * d-namespace.c: Revert.
3641         * d-lang.c: Revert.
3642         * ctf.c: Revert.
3643         * csky-tdep.c: Revert.
3644         * csky-linux-tdep.c: Revert.
3645         * cris-tdep.c: Revert.
3646         * cris-linux-tdep.c: Revert.
3647         * cp-valprint.c: Revert.
3648         * cp-support.c: Revert.
3649         * cp-namespace.c: Revert.
3650         * cp-abi.c: Revert.
3651         * corelow.c: Revert.
3652         * corefile.c: Revert.
3653         * continuations.c: Revert.
3654         * completer.h: Revert.
3655         * completer.c: Revert.
3656         * complaints.c: Revert.
3657         * coffread.c: Revert.
3658         * coff-pe-read.c: Revert.
3659         * cli-out.h: Revert.
3660         * cli-out.c: Revert.
3661         * charset.c: Revert.
3662         * c-varobj.c: Revert.
3663         * c-valprint.c: Revert.
3664         * c-typeprint.c: Revert.
3665         * c-lang.c: Revert.
3666         * buildsym.c: Revert.
3667         * buildsym-legacy.c: Revert.
3668         * build-id.h: Revert.
3669         * build-id.c: Revert.
3670         * btrace.c: Revert.
3671         * bsd-uthread.c: Revert.
3672         * breakpoint.h: Revert.
3673         * breakpoint.c: Revert.
3674         * break-catch-throw.c: Revert.
3675         * break-catch-syscall.c: Revert.
3676         * break-catch-sig.c: Revert.
3677         * blockframe.c: Revert.
3678         * block.c: Revert.
3679         * bfin-tdep.c: Revert.
3680         * bfin-linux-tdep.c: Revert.
3681         * bfd-target.c: Revert.
3682         * bcache.c: Revert.
3683         * ax-general.c: Revert.
3684         * ax-gdb.h: Revert.
3685         * ax-gdb.c: Revert.
3686         * avr-tdep.c: Revert.
3687         * auxv.c: Revert.
3688         * auto-load.c: Revert.
3689         * arm-wince-tdep.c: Revert.
3690         * arm-tdep.c: Revert.
3691         * arm-symbian-tdep.c: Revert.
3692         * arm-pikeos-tdep.c: Revert.
3693         * arm-obsd-tdep.c: Revert.
3694         * arm-nbsd-tdep.c: Revert.
3695         * arm-nbsd-nat.c: Revert.
3696         * arm-linux-tdep.c: Revert.
3697         * arm-linux-nat.c: Revert.
3698         * arm-fbsd-tdep.c: Revert.
3699         * arm-fbsd-nat.c: Revert.
3700         * arm-bsd-tdep.c: Revert.
3701         * arch-utils.c: Revert.
3702         * arc-tdep.c: Revert.
3703         * arc-newlib-tdep.c: Revert.
3704         * annotate.h: Revert.
3705         * annotate.c: Revert.
3706         * amd64-windows-tdep.c: Revert.
3707         * amd64-windows-nat.c: Revert.
3708         * amd64-tdep.c: Revert.
3709         * amd64-sol2-tdep.c: Revert.
3710         * amd64-obsd-tdep.c: Revert.
3711         * amd64-obsd-nat.c: Revert.
3712         * amd64-nbsd-tdep.c: Revert.
3713         * amd64-nbsd-nat.c: Revert.
3714         * amd64-nat.c: Revert.
3715         * amd64-linux-tdep.c: Revert.
3716         * amd64-linux-nat.c: Revert.
3717         * amd64-fbsd-tdep.c: Revert.
3718         * amd64-fbsd-nat.c: Revert.
3719         * amd64-dicos-tdep.c: Revert.
3720         * amd64-darwin-tdep.c: Revert.
3721         * amd64-bsd-nat.c: Revert.
3722         * alpha-tdep.c: Revert.
3723         * alpha-obsd-tdep.c: Revert.
3724         * alpha-nbsd-tdep.c: Revert.
3725         * alpha-mdebug-tdep.c: Revert.
3726         * alpha-linux-tdep.c: Revert.
3727         * alpha-linux-nat.c: Revert.
3728         * alpha-bsd-tdep.c: Revert.
3729         * alpha-bsd-nat.c: Revert.
3730         * aix-thread.c: Revert.
3731         * agent.c: Revert.
3732         * addrmap.c: Revert.
3733         * ada-varobj.c: Revert.
3734         * ada-valprint.c: Revert.
3735         * ada-typeprint.c: Revert.
3736         * ada-tasks.c: Revert.
3737         * ada-lang.c: Revert.
3738         * aarch64-tdep.c: Revert.
3739         * aarch64-ravenscar-thread.c: Revert.
3740         * aarch64-newlib-tdep.c: Revert.
3741         * aarch64-linux-tdep.c: Revert.
3742         * aarch64-linux-nat.c: Revert.
3743         * aarch64-fbsd-tdep.c: Revert.
3744         * aarch64-fbsd-nat.c: Revert.
3745         * aarch32-linux-nat.c: Revert.
3746
3747 2019-04-05  Tom Tromey  <tom@tromey.com>
3748
3749         * ft32-tdep.c: Sort headers.
3750         * frv-tdep.c: Sort headers.
3751         * frv-linux-tdep.c: Sort headers.
3752         * frame.c: Sort headers.
3753         * frame-unwind.c: Sort headers.
3754         * frame-base.c: Sort headers.
3755         * fork-child.c: Sort headers.
3756         * findvar.c: Sort headers.
3757         * findcmd.c: Sort headers.
3758         * filesystem.c: Sort headers.
3759         * filename-seen-cache.h: Sort headers.
3760         * filename-seen-cache.c: Sort headers.
3761         * fbsd-tdep.c: Sort headers.
3762         * fbsd-nat.h: Sort headers.
3763         * fbsd-nat.c: Sort headers.
3764         * f-valprint.c: Sort headers.
3765         * f-typeprint.c: Sort headers.
3766         * f-lang.c: Sort headers.
3767         * extension.h: Sort headers.
3768         * extension.c: Sort headers.
3769         * extension-priv.h: Sort headers.
3770         * expprint.c: Sort headers.
3771         * exec.h: Sort headers.
3772         * exec.c: Sort headers.
3773         * exceptions.c: Sort headers.
3774         * event-top.c: Sort headers.
3775         * event-loop.c: Sort headers.
3776         * eval.c: Sort headers.
3777         * elfread.c: Sort headers.
3778         * dwarf2read.h: Sort headers.
3779         * dwarf2read.c: Sort headers.
3780         * dwarf2loc.c: Sort headers.
3781         * dwarf2expr.h: Sort headers.
3782         * dwarf2expr.c: Sort headers.
3783         * dwarf2-frame.c: Sort headers.
3784         * dwarf2-frame-tailcall.c: Sort headers.
3785         * dwarf-index-write.h: Sort headers.
3786         * dwarf-index-write.c: Sort headers.
3787         * dwarf-index-common.c: Sort headers.
3788         * dwarf-index-cache.h: Sort headers.
3789         * dwarf-index-cache.c: Sort headers.
3790         * dummy-frame.c: Sort headers.
3791         * dtrace-probe.c: Sort headers.
3792         * disasm.h: Sort headers.
3793         * disasm.c: Sort headers.
3794         * disasm-selftests.c: Sort headers.
3795         * dictionary.c: Sort headers.
3796         * dicos-tdep.c: Sort headers.
3797         * demangle.c: Sort headers.
3798         * dcache.h: Sort headers.
3799         * dcache.c: Sort headers.
3800         * darwin-nat.h: Sort headers.
3801         * darwin-nat.c: Sort headers.
3802         * darwin-nat-info.c: Sort headers.
3803         * d-valprint.c: Sort headers.
3804         * d-namespace.c: Sort headers.
3805         * d-lang.c: Sort headers.
3806         * ctf.c: Sort headers.
3807         * csky-tdep.c: Sort headers.
3808         * csky-linux-tdep.c: Sort headers.
3809         * cris-tdep.c: Sort headers.
3810         * cris-linux-tdep.c: Sort headers.
3811         * cp-valprint.c: Sort headers.
3812         * cp-support.c: Sort headers.
3813         * cp-namespace.c: Sort headers.
3814         * cp-abi.c: Sort headers.
3815         * corelow.c: Sort headers.
3816         * corefile.c: Sort headers.
3817         * continuations.c: Sort headers.
3818         * completer.h: Sort headers.
3819         * completer.c: Sort headers.
3820         * complaints.c: Sort headers.
3821         * coffread.c: Sort headers.
3822         * coff-pe-read.c: Sort headers.
3823         * cli-out.h: Sort headers.
3824         * cli-out.c: Sort headers.
3825         * charset.c: Sort headers.
3826         * c-varobj.c: Sort headers.
3827         * c-valprint.c: Sort headers.
3828         * c-typeprint.c: Sort headers.
3829         * c-lang.c: Sort headers.
3830         * buildsym.c: Sort headers.
3831         * buildsym-legacy.c: Sort headers.
3832         * build-id.h: Sort headers.
3833         * build-id.c: Sort headers.
3834         * btrace.c: Sort headers.
3835         * bsd-uthread.c: Sort headers.
3836         * breakpoint.h: Sort headers.
3837         * breakpoint.c: Sort headers.
3838         * break-catch-throw.c: Sort headers.
3839         * break-catch-syscall.c: Sort headers.
3840         * break-catch-sig.c: Sort headers.
3841         * blockframe.c: Sort headers.
3842         * block.c: Sort headers.
3843         * bfin-tdep.c: Sort headers.
3844         * bfin-linux-tdep.c: Sort headers.
3845         * bfd-target.c: Sort headers.
3846         * bcache.c: Sort headers.
3847         * ax-general.c: Sort headers.
3848         * ax-gdb.h: Sort headers.
3849         * ax-gdb.c: Sort headers.
3850         * avr-tdep.c: Sort headers.
3851         * auxv.c: Sort headers.
3852         * auto-load.c: Sort headers.
3853         * arm-wince-tdep.c: Sort headers.
3854         * arm-tdep.c: Sort headers.
3855         * arm-symbian-tdep.c: Sort headers.
3856         * arm-pikeos-tdep.c: Sort headers.
3857         * arm-obsd-tdep.c: Sort headers.
3858         * arm-nbsd-tdep.c: Sort headers.
3859         * arm-nbsd-nat.c: Sort headers.
3860         * arm-linux-tdep.c: Sort headers.
3861         * arm-linux-nat.c: Sort headers.
3862         * arm-fbsd-tdep.c: Sort headers.
3863         * arm-fbsd-nat.c: Sort headers.
3864         * arm-bsd-tdep.c: Sort headers.
3865         * arch-utils.c: Sort headers.
3866         * arc-tdep.c: Sort headers.
3867         * arc-newlib-tdep.c: Sort headers.
3868         * annotate.h: Sort headers.
3869         * annotate.c: Sort headers.
3870         * amd64-windows-tdep.c: Sort headers.
3871         * amd64-windows-nat.c: Sort headers.
3872         * amd64-tdep.c: Sort headers.
3873         * amd64-sol2-tdep.c: Sort headers.
3874         * amd64-obsd-tdep.c: Sort headers.
3875         * amd64-obsd-nat.c: Sort headers.
3876         * amd64-nbsd-tdep.c: Sort headers.
3877         * amd64-nbsd-nat.c: Sort headers.
3878         * amd64-nat.c: Sort headers.
3879         * amd64-linux-tdep.c: Sort headers.
3880         * amd64-linux-nat.c: Sort headers.
3881         * amd64-fbsd-tdep.c: Sort headers.
3882         * amd64-fbsd-nat.c: Sort headers.
3883         * amd64-dicos-tdep.c: Sort headers.
3884         * amd64-darwin-tdep.c: Sort headers.
3885         * amd64-bsd-nat.c: Sort headers.
3886         * alpha-tdep.c: Sort headers.
3887         * alpha-obsd-tdep.c: Sort headers.
3888         * alpha-nbsd-tdep.c: Sort headers.
3889         * alpha-mdebug-tdep.c: Sort headers.
3890         * alpha-linux-tdep.c: Sort headers.
3891         * alpha-linux-nat.c: Sort headers.
3892         * alpha-bsd-tdep.c: Sort headers.
3893         * alpha-bsd-nat.c: Sort headers.
3894         * aix-thread.c: Sort headers.
3895         * agent.c: Sort headers.
3896         * addrmap.c: Sort headers.
3897         * ada-varobj.c: Sort headers.
3898         * ada-valprint.c: Sort headers.
3899         * ada-typeprint.c: Sort headers.
3900         * ada-tasks.c: Sort headers.
3901         * ada-lang.c: Sort headers.
3902         * aarch64-tdep.c: Sort headers.
3903         * aarch64-ravenscar-thread.c: Sort headers.
3904         * aarch64-newlib-tdep.c: Sort headers.
3905         * aarch64-linux-tdep.c: Sort headers.
3906         * aarch64-linux-nat.c: Sort headers.
3907         * aarch64-fbsd-tdep.c: Sort headers.
3908         * aarch64-fbsd-nat.c: Sort headers.
3909         * aarch32-linux-nat.c: Sort headers.
3910
3911 2019-04-04  Tom Tromey  <tom@tromey.com>
3912
3913         * varobj.c (varobj_create): Update.
3914         * rust-exp.y (struct rust_parser) <update_innermost_block,
3915         lookup_symbol>: New methods.
3916         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3917         Rename.
3918         (rust_parser::rust_lookup_type)
3919         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3920         * printcmd.c (display_command, do_one_display): Update.
3921         * parser-defs.h (struct parser_state) <parser_state>: Add
3922         "tracker" parameter.
3923         (block_tracker): New member.
3924         (class innermost_block_tracker) <innermost_block_tracker>: Add
3925         "types" parameter.
3926         <reset>: Remove method.
3927         (innermost_block): Don't declare.
3928         (null_post_parser): Update.
3929         * parse.c (innermost_block): Remove global.
3930         (write_dollar_variable): Update.
3931         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3932         Remove "tracker_types" parameter.
3933         (parse_expression): Add "tracker" parameter.
3934         (parse_expression_for_completion): Update.
3935         (null_post_parser): Add "tracker" parameter.
3936         * p-exp.y: Update rules.
3937         * m2-exp.y: Update rules.
3938         * language.h (struct language_defn) <la_post_parser>: Add
3939         "tracker" parameter.
3940         * go-exp.y: Update rules.
3941         * f-exp.y: Update rules.
3942         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3943         parameter.
3944         * d-exp.y: Update rules.
3945         * c-exp.y: Update rules.
3946         * breakpoint.c (set_breakpoint_condition): Create an
3947         innermost_block_tracker.
3948         (watch_command_1): Likewise.
3949         * ada-lang.c (resolve): Add "tracker" parameter.
3950         (resolve_subexp): Likewise.
3951         * ada-exp.y (write_var_from_sym): Update.
3952
3953 2019-04-04  Tom Tromey  <tom@tromey.com>
3954
3955         * type-stack.h: New file.
3956         * type-stack.c: New file.
3957         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3958         type-stack.h.
3959         (insert_into_type_stack, insert_type, push_type, push_type_int)
3960         (insert_type_address_space, pop_type, pop_type_int)
3961         (pop_typelist, pop_type_stack, append_type_stack)
3962         (push_type_stack, get_type_stack, push_typelist)
3963         (follow_type_instance_flags, follow_types): Don't declare.
3964         * parse.c (type_stack): Remove global.
3965         (parse_exp_in_context): Update.
3966         (insert_into_type_stack, insert_type, push_type, push_type_int)
3967         (insert_type_address_space, pop_type, pop_type_int)
3968         (pop_typelist, pop_type_stack, append_type_stack)
3969         (push_type_stack, get_type_stack, push_typelist)
3970         (follow_type_instance_flags, follow_types): Remove (moved to
3971         type-stack.c).
3972         * f-exp.y (type_stack): New global.
3973         Update rules.
3974         (push_kind_type, f_parse): Update.
3975         * d-exp.y (type_stack): New global.
3976         Update rules.
3977         (d_parse): Update.
3978         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3979         Update rules.
3980         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3981         (HFILES_NO_SRCDIR): Add type-stack.h.
3982
3983 2019-04-04  Tom Tromey  <tom@tromey.com>
3984
3985         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3986         (rust_parser::convert_ast_to_expression, rust_parse)
3987         (rust_lex_test_completion, rust_lex_tests): Update.
3988         * parser-defs.h (struct expr_completion_state): New.
3989         (struct parser_state) <parser_state>: Add completion parameter.
3990         <mark_struct_expression, mark_completion_tag>: New methods.
3991         <parse_completion, m_completion_state>: New members.
3992         (prefixify_expression, null_post_parser): Update.
3993         (mark_struct_expression, mark_completion_tag): Don't declare.
3994         * parse.c (parse_completion, expout_last_struct)
3995         (expout_tag_completion_type, expout_completion_name): Remove
3996         globals.
3997         (parser_state::mark_struct_expression)
3998         (parser_state::mark_completion_tag): Now methods.
3999         (prefixify_expression): Add last_struct parameter.
4000         (prefixify_subexp): Likewise.
4001         (parse_exp_1): Update.
4002         (parse_exp_in_context): Add cstate parameter.  Update.
4003         (parse_expression_for_completion): Create an
4004         expr_completion_state.
4005         (null_post_parser): Add "completion" parameter.
4006         * p-exp.y: Update rules.
4007         (yylex): Update.
4008         * language.h (struct language_defn) <la_post_parser>: Add
4009         "completing" parameter.
4010         * go-exp.y: Update rules.
4011         (lex_one_token): Update.
4012         * expression.h (parse_completion): Don't declare.
4013         * d-exp.y: Update rules.
4014         (lex_one_token): Update rules.
4015         * c-exp.y: Update rules.
4016         (lex_one_token): Update.
4017         * ada-lang.c (resolve): Add "parse_completion" parameter.
4018         (resolve_subexp): Likewise.
4019         (ada_resolve_function): Likewise.
4020
4021 2019-04-04  Tom Tromey  <tom@tromey.com>
4022
4023         * parser-defs.h (struct parser_state) <start_arglist,
4024         end_arglist>: New methods.
4025         <arglist_len, m_funcall_chain>: New members.
4026         (arglist_len, start_arglist, end_arglist): Don't declare.
4027         * parse.c (arglist_len, funcall_chain): Remove global.
4028         (start_arglist, end_arglist): Remove functions.
4029         (parse_exp_in_context): Update.
4030         * p-exp.y: Update rules.
4031         * m2-exp.y: Update rules.
4032         * go-exp.y: Update rules.
4033         * f-exp.y: Update rules.
4034         * d-exp.y: Update rules.
4035         * c-exp.y: Update rules.
4036
4037 2019-04-04  Tom Tromey  <tom@tromey.com>
4038
4039         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4040         lex_operator, push_back>: New methods.
4041         Update all rules.
4042         (rust_parser::lex_hex, lex_escape): Rename and update.
4043         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4044         (rust_parser::lex_operator): Rename and update.
4045         (rust_parser::lex_number, rustyylex, rustyyerror)
4046         (rust_lex_test_init, rust_lex_test_sequence)
4047         (rust_lex_test_push_back, rust_lex_tests): Update.
4048         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4049         parameter.
4050         <lexptr, prev_lexptr>: New members.
4051         (lexptr, prev_lexptr): Don't declare.
4052         * parse.c (lexptr, prev_lexptr): Remove globals.
4053         (parse_exp_in_context): Update.
4054         * p-exp.y (yylex, yyerror): Update.
4055         * m2-exp.y (parse_number, yylex, yyerror): Update.
4056         * go-exp.y (lex_one_token, yyerror): Update.
4057         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4058         * d-exp.y (lex_one_token, yyerror): Update.
4059         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4060         (lex_one_token, yyerror): Update.
4061         * ada-lex.l (YY_INPUT): Update.
4062         (rewind_to_char): Update.
4063         * ada-exp.y (yyerror): Update.
4064
4065 2019-04-04  Tom Tromey  <tom@tromey.com>
4066
4067         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4068         * parser-defs.h (struct parser_state) <parser_state>: Add new
4069         parameter.
4070         <comma_terminates>: New member.
4071         (comma_terminates): Don't declare global.
4072         * parse.c (comma_terminates): Remove global.
4073         (parse_exp_in_context): Update.
4074         * p-exp.y (yylex): Update.
4075         * m2-exp.y (yylex): Update.
4076         * go-exp.y (lex_one_token): Update.
4077         * f-exp.y (yylex): Update.
4078         * d-exp.y (lex_one_token): Update.
4079         * c-exp.y (lex_one_token): Update.
4080         * ada-lex.l: Update.
4081
4082 2019-04-04  Tom Tromey  <tom@tromey.com>
4083
4084         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4085         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4086         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4087         * parser-defs.h (paren_depth): Don't declare.
4088         * parse.c (paren_depth): Remove global.
4089         (parse_exp_in_context): Update.
4090         * p-exp.y (paren_depth): New global.
4091         (pascal_parse): Initialize it.
4092         * m2-exp.y (paren_depth): New global.
4093         (m2_parse): Initialize it.
4094         * go-exp.y (paren_depth): New global.
4095         (go_parse): Initialize it.
4096         * f-exp.y (paren_depth): New global.
4097         (f_parse): Initialize it.
4098         * d-exp.y (paren_depth): New global.
4099         (d_parse): Initialize it.
4100         * c-exp.y (paren_depth): New global.
4101         (c_parse): Initialize it.
4102         * ada-lex.l (paren_depth): New global.
4103         (lexer_init): Initialize it.
4104
4105 2019-04-04  Tom Tromey  <tom@tromey.com>
4106
4107         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4108         (rust_parser::convert_ast_to_type)
4109         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4110         * parser-defs.h (struct parser_state) <parser_state>: Add
4111         parameters.  Initialize new members.
4112         <expression_context_block, expression_context_pc>: New members.
4113         * parse.c (expression_context_block, expression_context_pc):
4114         Remove globals.
4115         (parse_exp_in_context): Update.
4116         * p-exp.y: Update all rules.
4117         (yylex): Update.
4118         * m2-exp.y: Update all rules.
4119         (yylex): Update.
4120         * go-exp.y (yylex): Update.
4121         * f-exp.y (yylex): Update.
4122         * d-exp.y: Update all rules.
4123         (yylex): Update.
4124         * c-exp.y: Update all rules.
4125         (lex_one_token, classify_name, yylex, c_parse): Update.
4126         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4127
4128 2019-04-04  Tom Tromey  <tom@tromey.com>
4129
4130         * gdbarch.h, gdbarch.c: Rebuild.
4131         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4132         * stap-probe.h:
4133         (struct stap_parse_info): Replace "parser_state" with
4134         "expr_builder".
4135         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4136         (parser_state): New class.
4137         * parse.c (expr_builder): Rename.
4138         (expr_builder::release): Rename.
4139         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4140         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4141         (write_exp_elt_longcst, write_exp_elt_floatcst)
4142         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4143         (write_exp_string_vector, write_exp_bitstring)
4144         (write_exp_msymbol, mark_struct_expression)
4145         (write_dollar_variable)
4146         (insert_type_address_space, increase_expout_size): Replace
4147         "parser_state" with "expr_builder".
4148         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4149         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4150         "parser_state" with "expr_builder".
4151
4152 2019-04-04  Tom Tromey  <tom@tromey.com>
4153
4154         * rust-exp.y: Replace "parse_language" with method call.
4155         * p-exp.y:
4156         (yylex): Replace "parse_language" with method call.
4157         * m2-exp.y:
4158         (yylex): Replace "parse_language" with method call.
4159         * go-exp.y (classify_name): Replace "parse_language" with method
4160         call.
4161         * f-exp.y (yylex): Replace "parse_language" with method call.
4162         * d-exp.y (lex_one_token): Replace "parse_language" with method
4163         call.
4164         * c-exp.y:
4165         (lex_one_token, classify_name, yylex): Replace "parse_language"
4166         with method call.
4167         * ada-exp.y (find_primitive_type, type_char)
4168         (type_system_address): Replace "parse_language" with method call.
4169
4170 2019-04-04  Tom Tromey  <tom@tromey.com>
4171
4172         * rust-exp.y: Replace "parse_gdbarch" with method call.
4173         * parse.c (write_dollar_variable, insert_type_address_space):
4174         Replace "parse_gdbarch" with method call.
4175         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4176         call.
4177         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4178         call.
4179         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4180         "parse_gdbarch" with method call.
4181         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4182         with method call.
4183         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4184         "parse_gdbarch" with method call.
4185         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4186         "parse_gdbarch" with method call.
4187         * c-exp.y (parse_type, parse_number, classify_name): Replace
4188         "parse_gdbarch" with method call.
4189         * ada-lex.l: Replace "parse_gdbarch" with method call.
4190         * ada-exp.y (parse_type, find_primitive_type, type_char)
4191         (type_system_address): Replace "parse_gdbarch" with method call.
4192
4193 2019-04-04  Tom Tromey  <tom@tromey.com>
4194
4195         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4196         * stap-probe.c (stap_parse_argument): Update.
4197         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4198         initial_size parameter.
4199         * rust-exp.y (rust_lex_tests): Update.
4200         * parse.c (parser_state): Update.
4201         (parse_exp_in_context): Update.
4202         * parser-defs.h (struct parser_state) <parser_state>: Remove
4203         "initial_size" parameter.
4204
4205 2019-04-04  Tom Tromey  <tom@tromey.com>
4206
4207         * parser-defs.h (increase_expout_size): Don't declare.
4208         * parse.c (increase_expout_size): Now static.
4209
4210 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4211
4212         * gnu-nat.c (gnu_nat_target::wait): Fix
4213         target_waitstatus_to_string call.
4214
4215 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * eval.c (evaluate_subexp_standard): Handle internal functions
4218         during Fortran function call handling.
4219
4220 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * NEWS: Mention new internal functions.
4223         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4224         (read_base_type): Use dwarf2_init_complex_target_type.
4225         * value.c (creal_internal_fn): New function.
4226         (cimag_internal_fn): New function.
4227         (_initialize_values): Register new internal functions.
4228
4229 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4230
4231         * infrun.c (stop_all_threads): If debug_infrun, always
4232         trace the wait status after wait_one, using
4233         target_waitstatus_to_string and target_pid_to_str.
4234         (handle_inferior_event): Replace various trace of
4235         wait status kind by a single trace.
4236         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4237         wait status kind image by target_waitstatus_to_string.
4238         * target/waitstatus.c (target_waitstatus_to_string): Fix
4239         obsolete comment.
4240
4241 2019-04-01  Tom Tromey  <tromey@adacore.com>
4242
4243         PR symtab/23331:
4244         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4245
4246 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4247             Pedro Alves  <palves@redhat.com>
4248
4249         * top.c (quit_force): Call 'finalize_values'.
4250         * value.c (finalize_values): New function.
4251         * value.h (finalize_values): Declare.
4252
4253 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4254
4255         * NEWS: Announce $_gdb_major and $_gdb_minor.
4256
4257         * top.c (init_gdb_version_vars): New function.
4258         (gdb_init): Call init_gdb_version_vars.
4259
4260 2019-03-29  Tom Tromey  <tromey@adacore.com>
4261
4262         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4263         help text.  Remove dead code.
4264
4265 2019-03-29  Keith Seitz  <keiths@redhat.com>
4266
4267         From Siddhesh Poyarekar:
4268         * f-lang.h (f77_get_upperbound): Return LONGEST.
4269         (f77_get_lowerbound): Likewise.
4270         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4271         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4272         print them.
4273         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4274         plongest to format print it.
4275         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4276         (f77_get_upperbound): Likewise.
4277         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4278         LOWER_BOUND to LONGEST.
4279         (f77_create_arrayprint_offset_tbl): Likewise.
4280
4281 2019-03-29  Keith Seitz  <keiths@redhat.com>
4282
4283         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4284         %s/pulongest for TYPE_LENGTH instead of %d in format
4285         strings.
4286         * ada-typerint.c (ada_print_type): Likewise.
4287         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4288         * compile/compile-c-support.c (generate_register_struct): Likewise.
4289         * gdbtypes.c (recursive_dump_type): Likewise.
4290         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4291         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4292         instead of %d in format strings.
4293         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4294         to std::min to ULONGEST.
4295         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4296         instead of %d in format strings.
4297         * tracepoint.c (info_scope_command): Likewise.
4298         * typeprint.c (print_offset_data::update)
4299         (print_offset_data::finish): Likewise.
4300         * xtensa-tdep.c (xtensa_store_return_value)
4301         (xtensa_push_dummy_call): Likewise.
4302
4303 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4304
4305         * windows-nat.c (display_selector): Fixed format specifications
4306         for 64-bit Cygwin.
4307
4308 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4309
4310         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4311
4312 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4313
4314         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4315         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4316         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4317         (nios2_linux_init_abi): Install it.
4318
4319 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4320
4321         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4322
4323 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4324
4325         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4326
4327 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4328             Tom Tromey  <tromey@adacore.com>
4329
4330         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4331
4332 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4333
4334         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4335         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4336         method to compute the bounds of range types. Also print "[evaluated]"
4337         if the bounds' values come from a dynamic evaluation.
4338
4339 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4340
4341         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4342         whitespace when pretty printing is on.
4343
4344 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4345
4346         * ppc-linux-nat.c: Add include.
4347
4348 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4349
4350         * NEWS: Mention AArch64 Pointer Authentication.
4351
4352 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4353
4354         * arm-linux-nat.c: Add include.
4355
4356 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4357
4358         * source-cache.c (source_cache::get_source_lines): Re-read
4359         fullname after calling open_source_file.
4360
4361 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4362
4363         * NEWS: Mention TLS support for FreeBSD.
4364
4365 2019-03-25  Tom Tromey  <tromey@adacore.com>
4366
4367         * minsyms.c (BUNCH_SIZE): Update comment.
4368         (~minimal_symbol_reader): Remove old comment.
4369         (compact_minimal_symbols): Update comment.
4370         (minimal_symbol_reader::install): Remove old comment.  Update
4371         other comments.
4372
4373 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4374
4375         * s390-linux-nat.c: Add include.
4376
4377 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4378
4379         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4380         Call linux_get_hwcap.
4381         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4382         Likewise.
4383         (aarch64_linux_get_hwcap): Remove function.
4384         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4385         declaration.
4386         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4387         linux_get_hwcap.
4388         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4389         * linux-tdep.c (linux_get_hwcap): Add function.
4390         (linux_get_hwcap2): Likewise.
4391         * linux-tdep.h (linux_get_hwcap): Add declaration.
4392         (linux_get_hwcap2): Likewise.
4393         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4394         (ppc_linux_get_hwcap2): Likewise.
4395         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4396         linux_get_hwcap.
4397         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4398         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4399         (ppc_linux_nat_target::read_description): Likewise.
4400         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4401         * s390-linux-nat.c: Likewise.
4402         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4403
4404 2019-03-24  Tom Tromey  <tom@tromey.com>
4405
4406         * ada-lang.c (standard_lookup): Simplify initialization.
4407         (ada_lookup_symbol_nonlocal): Simplify return.
4408         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4409         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4410         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4411         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4412         initialization.
4413         * solib.c (solib_global_lookup): Simplify.
4414         * symtab.c (null_block_symbol): Remove.
4415         (symbol_cache_lookup): Simplify returns.
4416         (lookup_language_this): Simplify returns.
4417         (lookup_symbol_aux): Simplify return.
4418         (lookup_local_symbol): Simplify returns.
4419         (lookup_global_symbol_from_objfile): Simplify return.
4420         (lookup_symbol_in_objfile_symtabs)
4421         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4422         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4423         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4424         * cp-namespace.c (cp_lookup_bare_symbol)
4425         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4426         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4427         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4428         (cp_lookup_symbol_via_imports): Simplify initialization.
4429         (find_symbol_in_baseclass): Likewise.
4430         * symtab.h (null_block_symbol): Remove.
4431         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4432         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4433         (d_lookup_symbol_module): Likewise.
4434         (find_symbol_in_baseclass): Simplify initialization.
4435
4436 2019-03-24  Tom Tromey  <tom@tromey.com>
4437
4438         * expression.h: Don't include symtab.h.
4439         (struct block): Forward declare.
4440
4441 2019-03-24  Tom Tromey  <tom@tromey.com>
4442
4443         * c-exp.y (typebase): Remove casts.
4444         * gdbtypes.c (lookup_unsigned_typename, )
4445         (lookup_signed_typename): Remove cast.
4446         * eval.c (parse_to_comma_and_eval): Remove cast.
4447         * parse.c (write_dollar_variable): Remove cast.
4448         * block.h (struct block) <superblock>: Now const.
4449         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4450         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4451         (map_block): Make "block" const.
4452         * symfile.h (struct quick_symbol_functions)
4453         <map_matching_symbols>: Constify block argument to "callback".
4454         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4455         const.
4456         (find_pc_sect_compunit_symtab): Make "b" const.
4457         (find_symbol_at_address): Likewise.
4458         (search_symbols): Likewise.
4459         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4460         (dw2_debug_names_lookup_symbol): Likewise.
4461         (dw2_map_matching_symbols): Update.
4462         * p-valprint.c (pascal_val_print): Remove "block".
4463         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4464         (aux_add_nonlocal_symbols): Make "block" const.
4465         (resolve_subexp): Remove cast.
4466         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4467         const.
4468         (iterate_over_file_blocks): Likewise.
4469         * f-exp.y (%union) <bval>: Remove.
4470         * coffread.c (patch_opaque_types): Make "b" const.
4471         * spu-tdep.c (spu_catch_start): Make "block" const.
4472         * c-valprint.c (print_unpacked_pointer): Remove "block".
4473         * symmisc.c (dump_symtab_1): Make "b" const.
4474         (block_depth): Make "block" const.
4475         * d-exp.y (%union) <bval>: Remove.
4476         * cp-support.h (cp_lookup_rtti_type): Update.
4477         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4478         * psymtab.c (psym_lookup_symbol): Make "block" const.
4479         (maintenance_check_psymtabs): Make "b" const.
4480         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4481         (enumerate_locals, enumerate_args): Update.
4482         * python/py-symtab.c (stpy_global_block): Make "block" const.
4483         (stpy_static_block): Likewise.
4484         * inline-frame.c (block_starting_point_at): Make "new_block"
4485         const.
4486         * block.c (find_block_in_blockvector): Make return type const.
4487         (blockvector_for_pc_sect): Make "b" const.
4488         (find_block_in_blockvector): Make "b" const.
4489
4490 2019-03-23  Tom Tromey  <tom@tromey.com>
4491
4492         * varobj.c (varobj_create): Update.
4493         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4494         * printcmd.c (display_command, do_one_display): Don't reset
4495         innermost_block.
4496         * parser-defs.h (enum innermost_block_tracker_type): Move to
4497         expression.h.
4498         (innermost_block): Update comment.
4499         * parse.c (parse_exp_1): Add tracker_types parameter.
4500         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4501         tracker_types parameter.  Reset innermost_block.
4502         (parse_exp_in_context): Remove.
4503         (parse_expression_for_completion): Update.
4504         * objfiles.c (~objfile): Don't reset expression_context_block or
4505         innermost_block.
4506         * expression.h (enum innermost_block_tracker_type): Move from
4507         parser-defs.h.
4508         (parse_exp_1): Add tracker_types parameter.
4509         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4510         reset innermost_block.
4511
4512 2019-03-23  Tom Tromey  <tom@tromey.com>
4513
4514         * objfiles.h: Include bcache.h.
4515
4516 2019-03-23  Tom Tromey  <tom@tromey.com>
4517
4518         * linespec.c (get_current_search_block): Use
4519         scoped_restore_current_language.
4520         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4521
4522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4523             Jiong Wang  <jiong.wang@arm.com>
4524
4525         * aarch64-linux-tdep.c
4526         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4527         section.
4528         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4529
4530 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4531             Jiong Wang  <jiong.wang@arm.com>
4532
4533         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4534         instructions.
4535         (aarch64_analyze_prologue_test): Add PACIASP test.
4536         (aarch64_prologue_prev_register): Unmask PC value.
4537
4538 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4539             Jiong Wang  <jiong.wang@arm.com>
4540
4541         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4542         (aarch64_dwarf2_prev_register): Unmask PC value.
4543         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4544         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4545         DW_CFA_AARCH64_negate_ra_state.
4546         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4547
4548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4549             Jiong Wang  <jiong.wang@arm.com>
4550
4551         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4552         registers.
4553         (aarch64_pseudo_register_name): Likewise.
4554         (aarch64_pseudo_register_type): Likewise.
4555         (aarch64_pseudo_register_reggroup_p): Likewise.
4556         (aarch64_gdbarch_init): Add pauth registers.
4557         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4558         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4559         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4560         (struct gdbarch_tdep): Add regnum for ra_state.
4561
4562 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4563             Jiong Wang  <jiong.wang@arm.com>
4564
4565         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4566
4567 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4568             Jiong Wang  <jiong.wang@arm.com>
4569
4570         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4571         function.
4572         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4573         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4574         (aarch64_gdbarch_init): Add puth registers.
4575         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4576         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4577         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4578
4579 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4580             Jiong Wang  <jiong.wang@arm.com>
4581
4582         * aarch64-linux-nat.c
4583         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4584         * aarch64-linux-tdep.c
4585         (aarch64_linux_core_read_description): Likewise.
4586         (aarch64_linux_get_hwcap): New function.
4587         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4588         (aarch64_linux_get_hwcap): New declaration.
4589
4590 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4591             Jiong Wang  <jiong.wang@arm.com>
4592
4593         * aarch64-linux-nat.c
4594         (aarch64_linux_nat_target::read_description): Add pauth param.
4595         * aarch64-linux-tdep.c
4596         (aarch64_linux_core_read_description): Likewise.
4597         * aarch64-tdep.c (struct target_desc): Add in pauth.
4598         (aarch64_read_description): Add pauth param.
4599         (aarch64_gdbarch_init): Likewise.
4600         * aarch64-tdep.h (aarch64_read_description): Likewise.
4601         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4602         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4603         * features/Makefile: Add new files.
4604         * features/aarch64-pauth.c: New file.
4605         * features/aarch64-pauth.xml: New file.
4606
4607 2019-03-20  Tom Tromey  <tromey@adacore.com>
4608
4609         * infrun.c (handle_inferior_event): Rename from
4610         handle_inferior_event_1.  Create a scoped_value_mark.
4611         (handle_inferior_event): Remove.
4612
4613 2019-03-19  Tom Tromey  <tromey@adacore.com>
4614
4615         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4616         * infrun.h (print_stop_event): Add "displays" parameter.
4617         * infrun.c (print_stop_event): Add "displays" parameter.
4618
4619 2019-03-19  Pedro Alves  <palves@redhat.com>
4620
4621         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4622         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4623         to -1.  Fix TABs vs spaces.
4624         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4625         * tui/tui-out.h (tui_ui_out) Add intro comments.
4626         <m_line, m_start_of_line>: In-class initialize, and add describing
4627         comment.
4628
4629 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4630
4631         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4632         variable names.
4633         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4634
4635 2019-03-18  Pedro Alves  <palves@redhat.com>
4636             Eli Zaretskii <eliz@gnu.org>
4637
4638         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4639         m_line and m_start_of_line.
4640
4641 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4642
4643         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4644         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4645         it returns a newline.  This fixes a regression in TU mode, whereby
4646         the next line is output on the same screen line as the user input.
4647
4648 2019-03-18  Tom Tromey  <tromey@adacore.com>
4649
4650         * minsyms.c (minimal_symbol_reader::install): Remove call to
4651         obstack_blank.
4652
4653 2019-03-18  Pedro Alves  <palves@redhat.com>
4654
4655         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4656         New globals.
4657         (apply_style): New, factored out from ...
4658         (apply_ansi_escape): ... this.  Handle reverse video mode.
4659         (tui_set_reverse_mode): New function.
4660         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4661         * tui/tui-winsource.c (tui_show_source_line): Use
4662         tui_set_reverse_mode instead of setting A_STANDOUT.
4663         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4664         New setter methods.
4665
4666 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4667
4668         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4669         Handle tabs.
4670
4671 2019-03-18  Tom Tromey  <tromey@adacore.com>
4672
4673         * ada-lang.c (empty_array): Add "high" parameter.
4674         (ada_evaluate_subexp): Update.
4675
4676 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4677
4678         * unittests/string_view-selftests.c: Define
4679         _initialize_string_view_selftests unconditionally.
4680
4681 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4682
4683         PR gdb/24350
4684         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4685
4686 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4687
4688         PR gdb/24351
4689         * windows-nat.c (display_selector): Fix format specifiers.
4690
4691 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4692
4693         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4694         tui_refill_source_window instead of tui_refresh_win, to update the
4695         current execution line.  This fixes redisplay of the current line
4696         when stepping through the code with "next" or "step".
4697
4698 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4699
4700         * source-cache.c (source_cache::get_source_lines): Call
4701         find_source_lines to initialize s->nlines.  This fixes vertical
4702         scrolling of TUI source window when the DOWN arrow is pressed.
4703
4704 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4705
4706         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4707         linux-thread-db.c (_initialize_thread_db): Likewise.
4708
4709 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4710
4711         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4712         wclrtoeol in tui_show_source_line".  This reverts changes made in
4713         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4714
4715 2019-03-15  Tom Tromey  <tom@tromey.com>
4716
4717         * symtab.h (struct minimal_symbol): Derive from
4718         general_symbol_info.
4719         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4720         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4721         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4722         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4723         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4724         (MSYMBOL_SEARCH_NAME): Update.
4725         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4726         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4727         * minsyms.c (minimal_symbol_reader::record_full): Update.
4728
4729 2019-03-15  Tom Tromey  <tom@tromey.com>
4730
4731         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4732
4733 2019-03-15  Tom Tromey  <tom@tromey.com>
4734
4735         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4736         unique_xmalloc_ptr.
4737         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4738         Update.
4739         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4740         (build_minimal_symbol_hash_tables)
4741         (minimal_symbol_reader::install): Update.
4742
4743 2019-03-15  Tom Tromey  <tom@tromey.com>
4744
4745         * symtab.c (create_demangled_names_hash): Update.
4746         (symbol_set_names): Update.
4747         * objfiles.h (struct objfile_per_bfd_storage)
4748         <demangled_names_hash>: Now an htab_up.
4749         * objfiles.c (objfile_per_bfd_storage): Simplify.
4750
4751 2019-03-15  Tom Tromey  <tom@tromey.com>
4752
4753         * objfiles.h (struct objfile_per_bfd_storage): Declare
4754         destructor.
4755         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4756         New.
4757         (get_objfile_bfd_data): Use new.  Don't initialize
4758         language_of_main.
4759         (free_objfile_per_bfd_storage): Remove.
4760         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4761
4762 2019-03-15  Tom Tromey  <tom@tromey.com>
4763
4764         * symfile.c (reread_symbols): Update.
4765         * objfiles.c (objfile::objfile): Update.
4766         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4767         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4768         comment.
4769         (minimal_symbol_reader::install): Update.
4770         (terminate_minimal_symbol_table): Remove.
4771         * jit.c (jit_object_close_impl): Update.
4772
4773 2019-03-15  Tom Tromey  <tom@tromey.com>
4774
4775         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4776         initializations.
4777
4778 2019-03-15  Tom Tromey  <tom@tromey.com>
4779
4780         * objfiles.h (struct objfile_per_bfd_storage)
4781         <demangled_hash_languages>: Now a bitset.
4782         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4783         (lookup_minimal_symbol): Update.
4784
4785 2019-03-15  Tom Tromey  <tom@tromey.com>
4786
4787         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4788         Don't return the symbol.
4789         * coffread.c (record_minimal_symbol): Use record_full.
4790
4791 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4792
4793         The MS-Windows port of ncurses fails to switch to a color pair if
4794         one or both of the colors are the implicit default colors.  This
4795         change records the default colors when TUI is initialized, and
4796         then specifies them explicitly when a color pair uses the default
4797         colors.  This allows color styling in TUI mode on MS-Windows.
4798
4799         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4800         ncurses_norm_attr.
4801         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4802         colors in ncurses_norm_attr.
4803         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4804         "none", replace it with the default color recorded in
4805         ncurses_norm_attr.
4806
4807 2019-03-14  Tom Tromey  <tromey@adacore.com>
4808
4809         * source-cache.h (class source_cache) <get_source_lines>: Return
4810         std::string.
4811         * source-cache.c (source_cache::extract_lines): Handle case where
4812         first_pos==npos.  Return std::string.
4813         (source_cache::get_source_lines): Update.
4814
4815 2019-03-14  Tom Tromey  <tromey@adacore.com>
4816
4817         * NEWS: Add item for "style sources" commands.
4818         * source-cache.c (source_cache::get_source_lines): Check
4819         source_styling.
4820         * cli/cli-style.c (source_styling): New global.
4821         (_initialize_cli_style): Add "style sources" commands.
4822         (show_style_sources): New function.
4823         * cli/cli-style.h (source_styling): Declare.
4824
4825 2019-03-14  Pedro Alves  <palves@redhat.com>
4826             Tom Tromey  <tromey@adacore.com>
4827
4828         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4829         * tui/tui-winsource.c (tui_refill_source_window): New function,
4830         from...
4831         (tui_horizontal_source_scroll): ... here.  Move some logic.
4832         * cli/cli-style.c (set_style_enabled): Notify new observable.
4833         * tui/tui-hooks.c (tui_redisplay_source): New function.
4834         (tui_attach_detach_observers): Attach or detach
4835         tui_redisplay_source.
4836         * observable.h (source_styling_changed): New observable.
4837         * observable.c: Define source_styling_changed observable.
4838
4839 2019-03-13  Tom Tromey  <tromey@adacore.com>
4840
4841         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4842         (i386_gnu_nat_target::store_registers): Update.
4843         * target-debug.h (target_debug_print_std_string): New macro.
4844         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4845         * windows-tdep.c (display_one_tib): Update.
4846         * tui/tui-stack.c (tui_make_status_line): Update.
4847         * top.c (print_inferior_quit_action): Update.
4848         * thread.c (thr_try_catch_cmd): Update.
4849         (add_thread_with_info): Update.
4850         (thread_target_id_str): Update.
4851         (thr_try_catch_cmd): Update.
4852         (thread_command): Update.
4853         (thread_find_command): Update.
4854         * record-btrace.c (record_btrace_target::info_record)
4855         (record_btrace_resume_thread, record_btrace_target::resume)
4856         (record_btrace_cancel_resume, record_btrace_step_thread)
4857         (record_btrace_target::wait, record_btrace_target::wait)
4858         (record_btrace_target::wait, record_btrace_target::stop): Update.
4859         * progspace.c (print_program_space): Update.
4860         * process-stratum-target.c
4861         (process_stratum_target::thread_address_space): Update.
4862         * linux-fork.c (linux_fork_mourn_inferior)
4863         (detach_checkpoint_command, info_checkpoints_command)
4864         (linux_fork_context): Update.
4865         (linux_fork_detach): Update.
4866         (class scoped_switch_fork_info): Update.
4867         (delete_checkpoint_command): Update.
4868         * infrun.c (follow_fork_inferior): Update.
4869         (follow_fork_inferior): Update.
4870         (proceed_after_vfork_done): Update.
4871         (handle_vfork_child_exec_or_exit): Update.
4872         (follow_exec): Update.
4873         (displaced_step_prepare_throw): Update.
4874         (displaced_step_restore): Update.
4875         (start_step_over): Update.
4876         (resume_1): Update.
4877         (clear_proceed_status_thread): Update.
4878         (proceed): Update.
4879         (print_target_wait_results): Update.
4880         (do_target_wait): Update.
4881         (context_switch): Update.
4882         (stop_all_threads): Update.
4883         (restart_threads): Update.
4884         (finish_step_over): Update.
4885         (handle_signal_stop): Update.
4886         (switch_back_to_stepped_thread): Update.
4887         (keep_going_pass_signal): Update.
4888         (print_exited_reason): Update.
4889         (normal_stop): Update.
4890         * inferior.c (inferior_pid_to_str): Change return type.
4891         (print_selected_inferior): Update.
4892         (add_inferior): Update.
4893         (detach_inferior): Update.
4894         * dummy-frame.c (fprint_dummy_frames): Update.
4895         * dcache.c (dcache_info_1): Update.
4896         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4897         (btrace_fetch, btrace_clear): Update.
4898         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4899         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4900         type.
4901         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4902         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4903         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4904         * gdbarch.c, gdbarch.h: Rebuild.
4905         * gdbarch.sh (core_pid_to_str): Change return type.
4906         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4907         return type.
4908         (windows_nat_target::pid_to_str): Change return type.
4909         (windows_delete_thread): Update.
4910         (windows_nat_target::attach): Update.
4911         (windows_nat_target::files_info): Update.
4912         * target-delegates.c: Rebuild.
4913         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4914         return type.
4915         (sol_thread_target::pid_to_str): Change return type.
4916         * remote.c (class remote_target) <pid_to_str>: Change return
4917         type.
4918         (remote_target::pid_to_str): Change return type.
4919         (extended_remote_target::attach, remote_target::remote_stop_ns)
4920         (remote_target::remote_notif_remove_queued_reply)
4921         (remote_target::push_stop_reply, remote_target::disable_btrace):
4922         Update.
4923         (extended_remote_target::attach): Update.
4924         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4925         type.
4926         (gdbsim_target::pid_to_str): Change return type.
4927         * ravenscar-thread.c (struct ravenscar_thread_target)
4928         <pid_to_str>: Change return type.
4929         (ravenscar_thread_target::pid_to_str): Change return type.
4930         * procfs.c (class procfs_target) <pid_to_str>: Change return
4931         type.
4932         (procfs_target::pid_to_str): Change return type.
4933         (procfs_target::attach): Update.
4934         (procfs_target::detach): Update.
4935         (procfs_target::fetch_registers): Update.
4936         (procfs_target::store_registers): Update.
4937         (procfs_target::wait): Update.
4938         (procfs_target::files_info): Update.
4939         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4940         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4941         return type.
4942         (nto_procfs_target::pid_to_str): Change return type.
4943         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4944         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4945         return type.
4946         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4947         (exit_lwp): Update.
4948         (attach_proc_task_lwp_callback, get_detach_signal)
4949         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4950         (linux_nat_target::resume, wait_lwp, stop_callback)
4951         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4952         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4953         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4954         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4955         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4956         type.
4957         (inf_ptrace_target::attach): Update.
4958         (inf_ptrace_target::files_info): Update.
4959         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4960         type.
4961         (go32_nat_target::pid_to_str): Change return type.
4962         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4963         (gnu_nat_target::wait): Update.
4964         (gnu_nat_target::wait): Update.
4965         (gnu_nat_target::resume): Update.
4966         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4967         (fbsd_nat_target::wait): Update.
4968         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4969         type.
4970         (darwin_nat_target::attach): Update.
4971         * corelow.c (class core_target) <pid_to_str>: Change return type.
4972         (core_target::pid_to_str): Change return type.
4973         * target.c (normal_pid_to_str): Change return type.
4974         (default_pid_to_str): Likewise.
4975         (target_pid_to_str): Change return type.
4976         (target_translate_tls_address): Update.
4977         (target_announce_detach): Update.
4978         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4979         return type.
4980         (bsd_uthread_target::pid_to_str): Change return type.
4981         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4982         type.
4983         (bsd_kvm_target::pid_to_str): Change return type.
4984         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4985         return type.
4986         (aix_thread_target::pid_to_str): Change return type.
4987         * target.h (struct target_ops) <pid_to_str>: Change return type.
4988         (target_pid_to_str, normal_pid_to_str): Likewise.
4989         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4990         type.
4991         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4992         type.
4993         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4994         return type.
4995         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4996         type.
4997         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4998         type.
4999         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5000         return type.
5001
5002 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5003
5004         * NEWS: Mention that the new default MI version is 3.  Mention
5005         changes to the output of commands and events that deal with
5006         multi-location breakpoints.
5007         * breakpoint.c: Include "mi/mi-out.h".
5008         (print_one_breakpoint): Change output syntax if using MI version
5009         >= 3.
5010         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5011         New.
5012         (mi_multi_location_breakpoint_output_fixed): New.
5013         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5014         (mi_cmd_fix_multi_location_breakpoint_output): New.
5015         (mi_multi_location_breakpoint_output_fixed): New.
5016         * mi/mi-cmds.c (mi_cmds): Register command
5017         -fix-multi-location-breakpoint-output.
5018         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5019         interpreter "mi".
5020
5021 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5022
5023         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5024         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5025         instantiate mi_ui_out based on interpreter name.
5026         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5027         * mi/mi-main.c (mi_load_progress): Likewise.
5028
5029 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5030
5031         * NEWS: Combine separate "New targets" sections for 8.3.
5032
5033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5034
5035         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5036         (ppcfbsd_init_abi): Install gdbarch
5037         "fetch_tls_load_module_address" and "get_thread_local_address"
5038         methods.
5039
5040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5041
5042         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5043         (riscv_fbsd_init_abi): Install gdbarch
5044         "fetch_tls_load_module_address" and "get_thread_local_address"
5045         methods.
5046
5047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5048
5049         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5050         (i386fbsd_init_abi): Install gdbarch
5051         "fetch_tls_load_module_address" and "get_thread_local_address"
5052         methods.
5053
5054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5055
5056         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5057         (amd64fbsd_init_abi): Install gdbarch
5058         "fetch_tls_load_module_address" and "get_thread_local_address"
5059         methods.
5060
5061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5062
5063         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5064         (struct fbsd_pspace_data): New type.
5065         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5066         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5067         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5068         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5069         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5070
5071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5072
5073         * gdbtypes.c (lookup_struct_elt): New function.
5074         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5075         * gdbtypes.h (struct struct_elt): New type.
5076         (lookup_struct_elt): New prototype.
5077
5078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5079
5080         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5081         remove disabled code block.
5082
5083 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5084
5085         * gdbarch.sh (get_thread_local_address): New method.
5086         * gdbarch.h, gdbarch.c: Regenerate.
5087         * target.c (target_translate_tls_address): Use
5088         gdbarch_get_thread_local_address if present instead of
5089         target::get_thread_local_address.
5090
5091 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5092
5093         * target.h (target::get_thread_local_address): Update comment.
5094
5095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5096
5097         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5098         objfile->separate_debug_objfile_backlink if not NULL.
5099
5100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5101
5102         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5103         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5104         (amd64bsd_store_inferior_registers): Likewise.
5105         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5106         Enable segment base registers.
5107         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5108         PT_GETFSBASE and PT_GETGSBASE.
5109         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5110         PT_SETGSBASE.
5111         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5112         segment base registers.
5113         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5114
5115 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5116
5117         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5118         Update calls to i386_target_description to add 'segments'
5119         parameter.
5120         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5121         add segment base registers.
5122         * arch/i386.c (i386_create_target_description): Add 'segments'
5123         parameter to enable segment base registers.
5124         * arch/i386.h (i386_create_target_description): Likewise.
5125         * features/i386/32bit-segments.xml: New file.
5126         * features/i386/32bit-segments.c: Generate.
5127         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5128         call to i386_target_description to add 'segments' parameter.
5129         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5130         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5131         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5132         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5133         if feature is present.
5134         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5135         Add 'segments' parameter to call to i386_target_description.
5136         (i386_target_description): Add 'segments' parameter to enable
5137         segment base registers.
5138         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5139         to call to i386_target_description.
5140         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5141         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5142         Define I386_NUM_REGS.
5143         (i386_target_description): Add 'segments' parameter to enable
5144         segment base registers.
5145
5146 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5147
5148         PR/24325
5149         * source-cache.c: #undef open and close, to avoid unresolved
5150         externals during linking.
5151
5152 2019-03-12  Tom Tromey  <tromey@adacore.com>
5153
5154         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5155         const.  Add initializers.
5156         (_initialize_remote): Don't initialize ptid globals.
5157
5158 2019-03-12  Pedro Alves  <palves@redhat.com>
5159
5160         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5161
5162 2019-03-12  Pedro Alves  <palves@redhat.com>
5163
5164         * cp-name-parser.y (main): Remove unused 'len' variable.
5165
5166 2019-03-12  Tom Tromey  <tromey@adacore.com>
5167
5168         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5169         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5170
5171 2019-03-12  Tom Tromey  <tromey@adacore.com>
5172
5173         * linux-nat.c (iterate_over_lwps): Update.
5174         (stop_callback): Remove parameter.
5175         (stop_wait_callback, detach_callback, resume_set_callback)
5176         (select_singlestep_lwp_callback, set_ignore_sigint)
5177         (status_callback, resumed_callback, resume_clear_callback)
5178         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5179         data parameter.
5180         (linux_nat_target::detach, linux_nat_target::resume)
5181         (linux_stop_and_wait_all_lwps, select_event_lwp)
5182         (linux_nat_filter_event, linux_nat_wait_1)
5183         (linux_nat_target::kill, linux_nat_target::stop)
5184         (linux_nat_target::stop): Update.
5185         (linux_nat_resume_callback): Change type.
5186         (resume_stopped_resumed_lwps, count_events_callback)
5187         (select_event_lwp_callback): Likewise.
5188         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5189         * arm-linux-nat.c (struct update_registers_data): Remove.
5190         (update_registers_callback): Change type.
5191         (arm_linux_insert_hw_breakpoint1): Update.
5192         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5193         parameter.
5194         (x86_linux_dr_set_addr): Update.
5195         (x86_linux_dr_set_control): Update.
5196         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5197         (iterate_over_lwps): Use gdb::function_view.
5198         * nat/aarch64-linux-hw-point.c (struct
5199         aarch64_dr_update_callback_param): Remove.
5200         (debug_reg_change_callback): Change type.
5201         (aarch64_notify_debug_reg_change): Update.
5202         * s390-linux-nat.c (s390_refresh_per_info): Update.
5203
5204 2019-03-11  Tom Tromey  <tromey@adacore.com>
5205
5206         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5207         redundant assignment to "this_cu".
5208
5209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5210
5211         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5212
5213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5214
5215         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5216         from...
5217         (rank_one_type): ... this.
5218
5219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5220
5221         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5222         from...
5223         (rank_one_type): ... this.
5224
5225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5226
5227         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5228         from...
5229         (rank_one_type): ... this.
5230
5231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5232
5233         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5234         from...
5235         (rank_one_type): ... this.
5236
5237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5238
5239         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5240         from...
5241         (rank_one_type): ... this.
5242
5243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5244
5245         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5246         from...
5247         (rank_one_type): ... this.
5248
5249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5250
5251         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5252         from...
5253         (rank_one_type): ... this.
5254
5255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5256
5257         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5258         from...
5259         (rank_one_type): ... this.
5260
5261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5262
5263         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5264         from...
5265         (rank_one_type): ... this.
5266
5267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5268
5269         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5270         from...
5271         (rank_one_type): ... this.
5272
5273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5274
5275         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5276         from...
5277         (rank_one_type): ... this.
5278
5279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5280
5281         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5282         from...
5283         (rank_one_type): ... this.
5284
5285 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5286
5287         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5288         inferior-events' shows the example events.
5289
5290 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5291
5292         Support styling on native MS-Windows console
5293
5294         PR/24315
5295         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5296         on MS-Windows if $TERM is not defined.
5297
5298         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5299
5300         * posix-hdep.c (gdb_console_fputs):
5301         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5302         functions.
5303         * ui-file.h (gdb_console_fputs): Add prototype.
5304
5305         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5306         back to fputs only if the former returns zero.
5307
5308 2019-03-07  Tom Tromey  <tom@tromey.com>
5309
5310         * symmisc.c (print_symbol_bcache_statistics): Update.
5311         (print_objfile_statistics): Update.
5312         * symfile.c (allocate_symtab): Update.
5313         * stabsread.c: Don't include bcache.h.
5314         * psymtab.h (struct psymbol_bcache): Don't declare.
5315         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5316         (psymbol_bcache_init, psymbol_bcache_free)
5317         (psymbol_bcache_get_bcache): Don't declare.
5318         * psymtab.c (struct psymbol_bcache): Remove.
5319         (psymtab_storage::psymtab_storage): Update.
5320         (psymtab_storage::~psymtab_storage): Update.
5321         (psymbol_bcache_init, psymbol_bcache_free)
5322         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5323         (add_psymbol_to_bcache): Update.
5324         (allocate_psymtab): Update.
5325         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5326         macro_cache>: No longer pointers.
5327         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5328         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5329         * macrotab.c (macro_bcache): Update.
5330         * macroexp.c: Don't include bcache.h.
5331         * gdbtypes.c (check_types_worklist): Update.
5332         (types_deeply_equal): Remove TRY/CATCH.  Update.
5333         * elfread.c (elf_symtab_read): Update.
5334         * dwarf2read.c: Don't include bcache.h.
5335         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5336         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5337         (print_bcache_statistics, bcache_memory_used): Don't declare.
5338         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5339         methods.  Rename all data members.
5340         * bcache.c (struct bcache): Move to bcache.h.
5341         (bcache::expand_hash_table): Rename from expand_hash_table.
5342         (bcache): Remove.
5343         (bcache::insert): Rename from bcache_full.
5344         (bcache::compare): Rename from bcache_compare.
5345         (bcache_xmalloc): Remove.
5346         (bcache::~bcache): Rename from bcache_xfree.
5347         (bcache::print_statistics): Rename from print_bcache_statistics.
5348         (bcache::memory_used): Rename from bcache_memory_used.
5349
5350 2019-03-07  Pedro Alves  <palves@redhat.com>
5351
5352         * infrun.c (normal_stop): Also check for
5353         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5354
5355 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5356
5357         * f-lang.c (value_from_host_double): Moved to...
5358         * value.c (value_from_host_double): ...here.
5359         * value.h (value_from_host_double): Declare.
5360         * guile/scm-math.c (vlscm_convert_typed_number): Use
5361         value_from_host_double.
5362         (vlscm_convert_number): Likewise.
5363         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5364         * python/py-value.c (convert_value_from_python): Likewise.
5365
5366 2019-03-06  Tom Tromey  <tom@tromey.com>
5367
5368         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5369
5370 2019-03-06  Tom Tromey  <tom@tromey.com>
5371
5372         * utils.h (free_current_contents): Don't declare.
5373         * utils.c (free_current_contents): Remove.
5374
5375 2019-03-06  Tom Tromey  <tom@tromey.com>
5376
5377         * top.c (quit_force): Update.
5378         * main.c (captured_command_loop): Update.
5379         * common/new-op.c (operator new): Update.
5380         * common/common-exceptions.c (struct catcher)
5381         <save_cleanup_chain>: Remove member.
5382         (exceptions_state_mc_init): Update.
5383         (exception_try_scope_entry): Return nullptr.
5384         (exception_try_scope_exit, exception_rethrow)
5385         (throw_exception_sjlj, throw_exception_cxx): Update.
5386         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5387         (all_cleanups, do_cleanups, discard_cleanups)
5388         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5389         (restore_cleanups, restore_final_cleanups): Don't declare.
5390         (do_final_cleanups): Remove parameter.
5391         * common/cleanups.c (cleanup_chain, make_cleanup)
5392         (make_cleanup_dtor, all_cleanups, do_cleanups)
5393         (discard_my_cleanups, discard_cleanups)
5394         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5395         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5396         (null_cleanup): Remove.
5397         (do_final_cleanups): Remove parameter.
5398
5399 2019-03-06  Tom Tromey  <tom@tromey.com>
5400
5401         * remote.c (remote_target::remote_parse_stop_reply): Use
5402         unique_xmalloc_ptr.
5403
5404 2019-03-06  Tom Tromey  <tom@tromey.com>
5405
5406         * stabsread.c (struct stabs_field_info): Rename from field_info.
5407         <list, fnlist>: Add initializers.
5408         <obstack>: New member.
5409         (read_member_functions, read_struct_fields, read_baseclasses):
5410         Allocate on obstack.  Don't use cleanups.
5411         (read_one_struct_field, read_member_functions, read_struct_fields)
5412         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5413         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5414         (read_struct_type): Update.
5415
5416 2019-03-06  Tom Tromey  <tom@tromey.com>
5417
5418         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5419         * common/filestuff.h (make_cleanup_close): Don't declare.
5420         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5421         Remove.
5422
5423 2019-03-06  Tom Tromey  <tom@tromey.com>
5424
5425         * solib-aix.c: Use make_scope_exit.
5426
5427 2019-03-06  Tom Tromey  <tom@tromey.com>
5428
5429         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5430         Use make_scope_exit.
5431
5432 2019-03-06  Tom Tromey  <tom@tromey.com>
5433
5434         * solib-svr4.c (disable_probes_interface): Remove parameter.
5435         (svr4_handle_solib_event): Use make_scope_exit.
5436
5437 2019-03-06  Tom Tromey  <tom@tromey.com>
5438
5439         * remote.c (struct stop_reply_deleter): Remove.
5440         (stop_reply_up): Update.
5441         (struct stop_reply): Derive from notif_event.  Don't typedef.
5442         <regcache>: Now a std::vector.
5443         (stop_reply_xfree): Remove.
5444         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5445         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5446         (remote_target::discard_pending_stop_replies): Use delete.
5447         (remote_target::remote_parse_stop_reply): Update.
5448         (remote_target::process_stop_reply): Update.
5449         * remote-notif.h (struct notif_event): Add virtual destructor.
5450         Remove "dtr" member.
5451         (struct notif_client) <alloc_event>: Return a unique_ptr.
5452         (notif_event_xfree): Don't declare.
5453         (notif_event_up): New typedef.
5454         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5455         (notif_event_xfree, do_notif_event_xfree): Remove.
5456         (remote_notif_state_xfree): Update.
5457
5458 2019-03-06  Tom Tromey  <tom@tromey.com>
5459
5460         * infrun.c (displaced_step_clear_cleanup): Now a
5461         forward_scope_exit type.
5462         (displaced_step_prepare_throw): Update.
5463         (displaced_step_fixup): Update.
5464
5465 2019-03-06  Tom Tromey  <tom@tromey.com>
5466
5467         * inferior.h (class inferior): Update comment.
5468         * gdbthread.h (class thread_info): Update comment.
5469
5470 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5471             Tom Tromey  <tom@tromey.com>
5472
5473         * stabsread.h (struct stab_section_list): Remove.
5474         (coffstab_build_psymtabs): Update.
5475         * dbxread.c (symbuf_sections): Now a std::vector.
5476         (sect_idx): New global.
5477         (fill_symbuf): Update.
5478         (coffstab_build_psymtabs): Change type of stabsects parameter.
5479         Update.
5480         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5481         std::vector.
5482         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5483         (coff_locate_sections): Update.
5484         (coff_symfile_read): Remove cleanups.  Update.
5485         (init_stringtab): Add storage parameter.
5486         (free_stringtab, free_stringtab_cleanup): Remove.
5487         (init_lineno): Add storage parameter.
5488         (free_linetab, free_linetab_cleanup): Remove.
5489
5490 2019-03-06  Pedro Alves  <palves@redhat.com>
5491
5492         * linux-fork.c (fork_info::clobber_regs): Delete.
5493         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5494         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5495         comment.  Adjust.
5496         (scoped_switch_fork_info::scoped_switch_fork_info)
5497         (checkpoint_command, linux_fork_context): Adjust
5498         fork_save_infrun_state calls.
5499
5500 2019-03-06  Pedro Alves  <palves@redhat.com>
5501
5502         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5503         (inf_has_multiple_threads): Return 'bool' and rewrite using
5504         inferior_info::threads().
5505
5506 2019-03-06  Pedro Alves  <palves@redhat.com>
5507
5508         * linux-fork.c: Include <list>.
5509         (fork_list): Now a std::list instance.
5510         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5511         (forks_exist_p, find_last_fork): Adjust.
5512         (new_fork): Delete.
5513         (one_fork_p): New.
5514         (add_fork): Adjust.
5515         (free_fork): Delete, folded into fork_info::~fork_info().
5516         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5517         Adjust.
5518         (init_fork_list): Delete.
5519         (linux_fork_killall, linux_fork_mourn_inferior)
5520         (linux_fork_detach, info_checkpoints_command): Adjust.
5521         (_initialize_linux_fork): No longer call init_fork_list.
5522
5523 2019-03-06  Pedro Alves  <palves@redhat.com>
5524
5525         * linux-fork.c (new_fork): New, split out of ...
5526         (add_fork): ... this.  Return void.  Move "first fork" special
5527         case from here, to ...
5528         (checkpoint_command): ... here.
5529         * linux-linux.h (add_fork): Return void.
5530
5531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5534
5535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5536             Chris January  <chris.january@arm.com>
5537             David Lecomber  <david.lecomber@arm.com>
5538
5539         * f-exp.y: New token, UNOP_INTRINSIC.
5540         (exp): New pattern using UNOP_INTRINSIC token.
5541         (f77_keywords): Add 'abs' keyword.
5542         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5543         (value_from_host_double): New function.
5544         (evaluate_subexp_f): Support UNOP_ABS.
5545
5546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5547
5548         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5549         types.
5550
5551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5552
5553         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5554         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5555         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5556
5557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5560
5561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5562             Chris January  <chris.january@arm.com>
5563
5564         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5565         * f-exp.y: Define 'KIND' token.
5566         (exp): New pattern for KIND expressions.
5567         (ptype): Handle types with a kind extension.
5568         (direct_abs_decl): Extend to spot kind extensions.
5569         (f77_keywords): Add 'kind' to the list.
5570         (push_kind_type): New function.
5571         (convert_to_kind_type): New function.
5572         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5573         * parse.c (operator_length_standard): Likewise.
5574         * parser-defs.h (enum type_pieces): Add tp_kind.
5575         * std-operator.def: Add UNOP_KIND.
5576
5577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5578
5579         * f-exp.y (f_parse): Set yydebug.
5580
5581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * f-lang.c (evaluate_subexp_f): New function.
5584         (exp_descriptor_f): New global.
5585         (f_language_defn): Use exp_descriptor_f instead of
5586         exp_descriptor_standard.
5587
5588 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5589
5590         * f-exp.y (struct token): Add comments.
5591         (dot_ops): Remove uppercase versions and the end marker.
5592         (f77_keywords): Likewise.
5593         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5594         entries in the dot_ops array are case insensitive, and use
5595         strncasecmp to compare strings.  Also some whitespace cleanup in
5596         this area.  Similar for the f77_keywords array, except entries in
5597         this list might be case sensitive.
5598
5599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * f-exp.y (struct f77_boolean_val): Add comments.
5602         (boolean_values): Remove uppercase versions, and end marker.
5603         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5604         and use strncasecmp to achieve case insensitivity.  Additionally,
5605         perform whitespace cleanup around this code.
5606
5607 2019-03-06  Tom Tromey  <tromey@adacore.com>
5608
5609         * remote-sim.c (gdbsim_target_open): Use result of
5610         gdb_argv::release.
5611
5612 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5613         Dirk Schubert  <dirk.schubert@arm.com>
5614         Chris January  <chris.january@arm.com>
5615
5616         * eval.c (evaluate_subexp_standard): Call Fortran argument
5617         wrapping logic.
5618         * f-lang.c (struct value): A value which can be passed into a
5619         Fortran function call.
5620         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5621         where appropriate.
5622         (struct type): Value ready for a Fortran function call.
5623         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5624         is needed.
5625         * f-lang.h (fortran_argument_convert): Declaration.
5626         (fortran_preserve_arg_pointer): Declaration.
5627         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5628
5629 2019-03-05  Tom Tromey  <tromey@adacore.com>
5630
5631         * python/py-prettyprint.c (print_string_repr): Remove #if.
5632         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5633
5634 2019-03-05  Tom Tromey  <tromey@adacore.com>
5635
5636         * target.c (the_dummy_target): Move later.  Change type to
5637         "dummy_target".
5638         (initialize_targets): Don't initialize the_dummy_target.
5639
5640 2019-03-05  Tom Tromey  <tromey@adacore.com>
5641
5642         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5643         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5644
5645 2019-03-05  Tom Tromey  <tromey@adacore.com>
5646
5647         * windows-nat.c (windows_nat_target::attach)
5648         (windows_nat_target::detach): Don't call gdb_flush.
5649         * valprint.c (generic_val_print, val_print, val_print_string):
5650         Don't call gdb_flush.
5651         * utils.c (defaulted_query): Don't call gdb_flush.
5652         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5653         * target.c (target_announce_detach): Don't call gdb_flush.
5654         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5655         * remote.c (extended_remote_target::attach): Don't call
5656         gdb_flush.
5657         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5658         * printcmd.c (do_examine): Don't call gdb_flush.
5659         (info_display_command): Don't call gdb_flush.
5660         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5661         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5662         * memattr.c (info_mem_command): Don't call gdb_flush.
5663         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5664         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5665         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5666         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5667         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5668         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5669         (gnu_nat_target::detach): Don't call gdb_flush.
5670         * f-valprint.c (f_val_print): Don't call gdb_flush.
5671         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5672         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5673         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5674         gdb_flush.
5675         * c-valprint.c (c_val_print): Don't call gdb_flush.
5676         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5677
5678 2019-03-05  Tom Tromey  <tromey@adacore.com>
5679
5680         * varobj.c (update_dynamic_varobj_children): Update.
5681         (install_default_visualizer): Use reset, not release.
5682         * value.c (set_internalvar): Update.
5683         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5684         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5685         ATTRIBUTE_UNUSED_RESULT.
5686
5687 2019-03-05  Tom Tromey  <tromey@adacore.com>
5688
5689         * remote.c (class scoped_remote_fd) <release>: Add
5690         ATTRIBUTE_UNUSED_RESULT.
5691
5692 2019-03-05  Tom Tromey  <tromey@adacore.com>
5693
5694         * macroexp.c (struct macro_buffer) <release>: Add
5695         ATTRIBUTE_UNUSED_RESULT.
5696
5697 2019-03-05  Tom Tromey  <tromey@adacore.com>
5698
5699         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5700         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5701         ATTRIBUTE_UNUSED_RESULT.
5702
5703 2019-03-05  Tom Tromey  <tromey@adacore.com>
5704
5705         * common/scoped_fd.h (class scoped_fd) <release>: Add
5706         ATTRIBUTE_UNUSED_RESULT.
5707
5708 2019-03-05  Tom Tromey  <tromey@adacore.com>
5709
5710         * parser-defs.h (struct parser_state) <release>: Add
5711         ATTRIBUTE_UNUSED_RESULT.
5712
5713 2019-03-05  Tom Tromey  <tromey@adacore.com>
5714
5715         * utils.h (class gdb_argv) <release>: Add
5716         ATTRIBUTE_UNUSED_RESULT.
5717         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5718
5719 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5720
5721         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5722         for-loop range, to avoid compiler warnings.
5723
5724         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5725         avoid compiler warnings about unused variables.
5726
5727         * NEWS: Mention end of support for native debugging on MS-Windows
5728         before XP.
5729
5730         PR gdb/24292
5731         * common/netstuff.c:
5732         * gdbserver/gdbreplay.c
5733         * gdbserver/remote-utils.c:
5734         * ser-tcp.c:
5735         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5736         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5737         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5738         'getaddrinfo' and 'freeaddrinfo' were not available before
5739         Windows XP, and mingw.org's MinGW headers by default define
5740         _WIN32_WINNT to 0x500.
5741
5742 2019-03-01  Gary Benson <gbenson@redhat.com>
5743
5744         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5745
5746 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5747             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5748
5749         PR gdb/8527
5750         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5751         set_sigint_trap, clear_sigint_trap.
5752
5753 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5754
5755         * target.c (target_detach): Clear the regcache and the
5756         frame cache.
5757
5758 2019-02-27  Pedro Alves  <palves@redhat.com>
5759
5760         * utils.c (set_screen_size): When we cap the height/width sizes,
5761         tweak the corresponding command variable to show "unlimited":
5762
5763 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5764             Pedro Alves  <palves@redhat.com>
5765
5766         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5767         before calling rl_set_screen_size.
5768
5769 2019-02-27  Tom Tromey  <tromey@adacore.com>
5770
5771         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5772         define.
5773         * python/py-value.c: Remove Python 2.4 workaround.
5774         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5775         workaround.
5776         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5777         Python 2.4 workaround.
5778         * python/python-internal.h: Remove Python 2.4 comment.
5779         (Py_ssize_t): Don't define.
5780         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5781         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5782         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5783         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5784         * python/python.c (do_start_initialization): Remove Python 2.4
5785         workaround.
5786         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5787         (print_children): Remove Python 2.4 workaround.
5788         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5789         workaround.
5790         (CHARBUFFERPROC_NAME): Remove.
5791         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5792         Python 2.4 workaround.
5793
5794 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5795
5796         * NEWS: Note minimum Python version.
5797
5798 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5799
5800         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5801         code from these functions.  Remove corresponding ifdefs.  Use
5802         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5803         Remove gotos and target of gotos.
5804         (infpy_search_memory): Likewise.
5805
5806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5809         (hppa_gdbarch_init): Don't register deleted functions with
5810         gdbarch.
5811
5812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5813
5814         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5815         (h8300_unwind_sp): Delete.
5816         (h8300_dummy_id): Delete.
5817         (h8300_gdbarch_init): Don't register deleted functions with
5818         gdbarch.
5819
5820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5821
5822         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5823         (ft32_unwind_pc): Delete.
5824         (ft32_unwind_sp): Delete.
5825         (ft32_gdbarch_init): Don't register deleted functions with
5826         gdbarch.
5827
5828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5831         (frv_unwind_pc): Delete.
5832         (frv_unwind_sp): Delete.
5833         (frv_gdbarch_init): Don't register deleted functions with
5834         gdbarch.
5835
5836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5837
5838         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5839         (riscv_unwind_pc): Delete.
5840         (riscv_unwind_sp): Delete.
5841         (riscv_gdbarch_init): Don't register deleted functions with
5842         gdbarch.
5843
5844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5845
5846         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5847         (csky_unwind_pc): Delete.
5848         (csky_unwind_sp): Delete.
5849         (csky_gdbarch_init): Don't register deleted functions with
5850         gdbarch.
5851
5852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5853
5854         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5855         (cris_unwind_pc): Delete.
5856         (cris_unwind_sp): Delete.
5857         (cris_gdbarch_init): Don't register deleted functions with
5858         gdbarch.
5859
5860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5863         (bfin_unwind_pc): Delete.
5864         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5865
5866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5869         (arm_unwind_pc): Delete.
5870         (arm_unwind_sp): Delete.
5871         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5872
5873 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5874
5875         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5876         (arc_unwind_pc): Delete.
5877         (arc_unwind_sp): Delete.
5878         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5879
5880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5883         (alpha_unwind_pc): Delete.
5884         (alpha_gdbarch_init): Don't register deleted functions with
5885         gdbarch.
5886
5887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5890         (aarch64_unwind_pc): Delete.
5891         (aarch64_unwind_sp): Delete.
5892         (aarch64_gdbarch_init): Don't register deleted functions with
5893         gdbarch.
5894
5895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5896
5897         * gdbtypes.c (type_align): Don't consider static members when
5898         computing structure alignment.
5899
5900 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5901
5902         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5903         return 0 for other types.
5904         * arch-utils.c (default_type_align): Always return 0.
5905         * gdbarch.h: Regenerate.
5906         * gdbarch.sh (type_align): Extend comment.
5907         * gdbtypes.c (type_align): Add additional comments, always call
5908         gdbarch_type_align before applying the default rules.
5909         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5910         generic code will then apply a suitable default.
5911         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5912         types, return 0 for other types.
5913
5914 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5915
5916         * NEWS: Create a new section for the next release branch.
5917         Rename the section of the current branch, now that it has
5918         been cut.
5919
5920 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5921
5922         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5923         * version.in: Bump version to 8.3.50.DATE-git.
5924
5925 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5926
5927         * aix-thread.c (ptid_cmp): Remove unused variable.
5928         (get_signaled_thread): Likewise.
5929         (store_regs_user_thread): Likewise.
5930         (store_regs_kernel_thread): Likewise.
5931         (fetch_regs_kernel_thread): Remove shadowed variable.
5932
5933 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * features/riscv/32bit-cpu.xml: Add register numbers.
5936         * features/riscv/32bit-fpu.c: Regenerate.
5937         * features/riscv/32bit-fpu.xml: Add register numbers.
5938         * features/riscv/64bit-cpu.xml: Add register numbers.
5939         * features/riscv/64bit-fpu.c: Regenerate.
5940         * features/riscv/64bit-fpu.xml: Add register numbers.
5941
5942 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5943
5944         * NEWS: Mention two argument form of gdb.Value constructor.
5945         * python/py-value.c (convert_buffer_and_type_to_value): New
5946         function.
5947         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5948         Add support for handling an optional second argument.  Call
5949         convert_buffer_and_type_to_value as appropriate.
5950         * python/python-internal.h (Py_buffer_deleter): New struct.
5951         (Py_buffer_up): New typedef.
5952
5953 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5954
5955         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5956         instead of releasing ownership.
5957
5958 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5959
5960         * dwarf2read.c (open_and_init_dwp_file): Call
5961         elf_numsections instead of bfd_count_sections to initialize
5962         dwp_file->num_sections.
5963
5964 2019-02-25  Tom Tromey  <tromey@adacore.com>
5965
5966         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5967
5968 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5969
5970         * gcore.in: Add '--readnever' option when invoking GDB.
5971
5972 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5973
5974         * MAINTAINERS: Update my email address.
5975
5976 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5977
5978         * build-id.c (build_id_to_debug_bfd_1): New function.
5979         (build_id_to_debug_bfd): Look for separate debug file in
5980         sysroot.
5981
5982 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * gdbarch.sh: Update the copyright year range that is placed into
5985         generated files.
5986
5987 2019-02-22  Keith Seitz  <keiths@redhat.com>
5988
5989         PR symtab/23853
5990         * linespec.c (create_sals_line_offset): Search for the default
5991         symtab's filename instead of its fullname.
5992
5993 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5994
5995         * NEWS: Update style defaults.
5996
5997 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5998
5999         * main.c (captured_main_1): Disable styling in batch mode.
6000
6001 2019-02-20  Tom Tromey  <tom@tromey.com>
6002
6003         * symtab.c (symtab_symbol_info): Fix typos.
6004
6005 2019-02-20  Tom Tromey  <tromey@adacore.com>
6006
6007         * findcmd.c (_initialize_mem_search): Use upper case for
6008         metasyntactic variables.
6009
6010 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6011
6012         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6013         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6014
6015 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6016
6017         * top.h (source_file_name): Change to std::string.
6018         * top.c (source_file_name): Likewise.
6019         (command_line_input): Adjust.
6020         * cli/cli-script.c (script_from_file): Adjust.
6021
6022 2019-02-19  Tom Tromey  <tromey@adacore.com>
6023
6024         * ravenscar-thread.c
6025         (ravenscar_thread_target::update_thread_list): Don't call
6026         ada_build_task_list.
6027         * ada-lang.h (ada_build_task_list): Don't declare.
6028         * ada-tasks.c (struct ada_tasks_inferior_data)
6029         <task_list_valid_p>: Now bool.
6030         (read_known_tasks, ada_task_list_changed)
6031         (ada_tasks_invalidate_inferior_data): Update.
6032         (read_known_tasks_array): Return bool.
6033         (read_known_tasks_list): Likewise.
6034         (read_known_tasks): Return void.
6035         (ada_build_task_list): Now static.
6036
6037 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6038
6039         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6040         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6041
6042 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6043
6044         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6045         variant for ada_tasks_pspace_data_handle and
6046         ada_tasks_inferior_data_handle.
6047         (ada_tasks_pspace_data_cleanup): New function.
6048         (ada_tasks_inferior_data_cleanup): New function.
6049
6050 2019-02-17  Tom Tromey  <tom@tromey.com>
6051
6052         * macrotab.h (macro_source_fullname): Return a std::string.
6053         * macrotab.c (macro_include, check_for_redefinition)
6054         (macro_undef, macro_lookup_definition, foreach_macro)
6055         (foreach_macro_in_scope): Update.
6056         (macro_source_fullname): Return a std::string.
6057         * macrocmd.c (show_pp_source_pos): Update.
6058
6059 2019-02-17  Tom Tromey  <tom@tromey.com>
6060
6061         * macrocmd.c (show_pp_source_pos): Style the file names.
6062
6063 2019-02-17  Tom Tromey  <tom@tromey.com>
6064
6065         PR tui/24197:
6066         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6067
6068 2019-02-17  Tom Tromey  <tom@tromey.com>
6069
6070         * ada-lang.c (user_select_syms): Use filtered printing.
6071         * utils.c (wrap_style): New global.
6072         (desired_style): Remove.
6073         (emit_style_escape): Add stream parameter.
6074         (set_output_style, reset_terminal_style, prompt_for_continue):
6075         Update.
6076         (flush_wrap_buffer): Only flush gdb_stdout.
6077         (wrap_here): Set wrap_style.
6078         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6079         treat escape sequences as a character.  Change when wrap buffer is
6080         flushed.
6081         (fputs_styled): Do not set the output style when the default is
6082         requested.
6083         * ui-style.h (struct ui_file_style) <is_default>: New method.
6084         * source.c (print_source_lines_base): Emit escape sequences in one
6085         piece.
6086
6087 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6088
6089         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6090         integers and enumeration types.
6091
6092 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6093
6094         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6095         instead of lookup_symbol_in_language
6096         (do_exact_match): New function.
6097         (ada_get_symbol_name_matcher): Return do_exact_match when
6098         doing a verbatim match.
6099
6100 2019-02-15  Tom Tromey  <tromey@adacore.com>
6101
6102         * ravenscar-thread.c (ravenscar_thread_target::resume)
6103         (ravenscar_thread_target::wait): Special case wildcard requests.
6104
6105 2019-02-15  Tom Tromey  <tromey@adacore.com>
6106
6107         * ravenscar-thread.c (base_ptid): Remove.
6108         (struct ravenscar_thread_target) <close>: New method.
6109         <m_base_ptid>: New member.
6110         <update_inferior_ptid, active_task, task_is_currently_active,
6111         runtime_initialized>: Declare methods.
6112         <ravenscar_thread_target>: Add constructor.
6113         (ravenscar_thread_target::task_is_currently_active)
6114         (ravenscar_thread_target::update_inferior_ptid)
6115         (ravenscar_runtime_initialized): Rename.  Now methods.
6116         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6117         (ravenscar_thread_target::update_thread_list): Update.
6118         (ravenscar_thread_target::active_task): Now method.
6119         (ravenscar_thread_target::store_registers)
6120         (ravenscar_thread_target::prepare_to_store)
6121         (ravenscar_thread_target::prepare_to_store)
6122         (ravenscar_thread_target::mourn_inferior): Update.
6123         (ravenscar_inferior_created): Use "new" to create target.
6124         (ravenscar_thread_target::get_ada_task_ptid): Update.
6125         (_initialize_ravenscar): Don't initialize base_ptid.
6126         (ravenscar_ops): Remove global.
6127
6128 2019-02-15  Tom Tromey  <tromey@adacore.com>
6129
6130         * target.h (push_target): Declare new overload.
6131         * target.c (push_target): New overload, taking an rvalue reference.
6132         * remote.c (remote_target::open_1): Use push_target overload.
6133         * corelow.c (core_target_open): Use push_target overload.
6134
6135 2019-02-15  Tom Tromey  <tromey@adacore.com>
6136
6137         * ravenscar-thread.c (is_ravenscar_task)
6138         (ravenscar_task_is_currently_active): Return bool.
6139         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6140         (_initialize_ravenscar): Remove "(void)".
6141         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6142         Return bool.
6143
6144 2019-02-15  Tom Tromey  <tromey@adacore.com>
6145
6146         * ravenscar-thread.c (ravenscar_runtime_initializer)
6147         (has_ravenscar_runtime, get_running_thread_id)
6148         (ravenscar_thread_target::resume): Fix indentation.
6149
6150 2019-02-15  Tom Tromey  <tromey@adacore.com>
6151
6152         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6153         from ravenscar_arch_ops.
6154         (sparc_ravenscar_ops::fetch_registers)
6155         (sparc_ravenscar_ops::store_registers): Now methods.
6156         (sparc_ravenscar_prepare_to_store): Remove.
6157         (sparc_ravenscar_ops): Redefine.
6158         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6159         methods and destructor.  Remove members.
6160         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6161         (ravenscar_thread_target::store_registers)
6162         (ravenscar_thread_target::prepare_to_store): Update.
6163         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6164         Remove.
6165         (struct ppc_ravenscar_powerpc_ops): Derive from
6166         ravenscar_arch_ops.
6167         (ppc_ravenscar_powerpc_ops::fetch_registers)
6168         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6169         (ppc_ravenscar_powerpc_ops): Redefine.
6170         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6171         (ppc_ravenscar_e500_ops::fetch_registers)
6172         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6173         (ppc_ravenscar_e500_ops): Redefine.
6174         * aarch64-ravenscar-thread.c
6175         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6176         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6177         (aarch64_ravenscar_fetch_registers)
6178         (aarch64_ravenscar_store_registers): Now methods.
6179         (aarch64_ravenscar_ops): Redefine.
6180
6181 2019-02-15  Tom Tromey  <tromey@adacore.com>
6182
6183         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6184         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6185         (ravenscar_thread_target::stopped_by_watchpoint)
6186         (ravenscar_thread_target::stopped_data_address)
6187         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6188
6189 2019-02-15  Tom Tromey  <tromey@adacore.com>
6190
6191         * ravenscar-thread.c: Fix some typos.
6192
6193 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6194             Tom Tromey  <tromey@adacore.com>
6195
6196         * ada-lang.c (ada_exception_sal): Change addr_string to a
6197         std::string.
6198         (create_ada_exception_catchpoint): Update.
6199
6200 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6201             Tom Tromey  <tromey@adacore.com>
6202
6203         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6204         (bp_location_ops): Remove.
6205         (base_breakpoint_allocate_location): Update.
6206         (free_bp_location): Update.
6207         * ada-lang.c (class ada_catchpoint_location)
6208         <ada_catchpoint_location>: Remove ops parameter.
6209         (ada_catchpoint_location_dtor): Remove.
6210         (ada_catchpoint_location_ops): Remove.
6211         (allocate_location_exception): Update.
6212         * breakpoint.h (struct bp_location_ops): Remove.
6213         (class bp_location) <bp_location>: Remove bp_location_ops
6214         parameter.
6215         <~bp_location>: Add destructor.
6216         <ops>: Remove.
6217
6218 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6219             Pedro Alves  <palves@redhat.com>
6220
6221         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6222         'PATH_MAX'.
6223
6224 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6225             Samuel Thibault  <samuel.thibault@gnu.org>
6226             Thomas Schwinge  <thomas@codesourcery.com>
6227
6228         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6229         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6230
6231 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6232
6233         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6234         (check_empty): Use "const char *".
6235
6236         * gnu-nat.c (gnu_nat_target::detach): Instead of
6237         'detach_inferior (pid)' call
6238         'detach_inferior (find_inferior_pid (pid))'.
6239
6240         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6241         'nat/fork-inferior.o'.
6242         * gnu-nat.c: #include "nat/fork-inferior.h".
6243
6244         * gnu-nat.c (gnu_nat_target::detach): Instead of
6245         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6246         * gnu-nat.h: #include "inf-child.h".
6247         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6248         'i386_gnu_nat_target::fetch_registers'.
6249         (gnu_store_registers): Rename/move to
6250         'i386_gnu_nat_target::store_registers'.
6251
6252         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6253         * gnu-nat.h (mach_thread_info): New function.
6254         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6255
6256         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6257
6258 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6259
6260         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6261
6262 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6263
6264         * windows-nat.c (windows_add_thread): Add new parameter
6265         "main_thread_p" with default value set to false.  Update
6266         function documentation as well as all callers.
6267         (windows_delete_thread): Likewise.
6268         (fake_create_process): Update call to windows_add_thread.
6269         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6270         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6271         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6272         call to windows_delete_thread.
6273
6274 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6275
6276         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6277
6278 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6279
6280         * symfile.c (find_separate_debug_file): Use canonical path of
6281         sysroot with child_path instead of gdb_sysroot if it is valid.
6282
6283 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6284
6285         * symfile.c (find_separate_debug_file): Use child_path to
6286         determine if an object file is under a sysroot.
6287
6288 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6289
6290         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6291         unittests/child-path-selftests.c.
6292         * common/pathstuff.c (child_path): New function.
6293         * common/pathstuff.h (child_path): New prototype.
6294         * unittests/child-path-selftests.c: New file.
6295
6296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6297
6298         * symfile.c (find_separate_debug_file): Look for separate debug
6299         files in debug directories under the sysroot.
6300
6301 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6302
6303         * symtab.h (struct minimal_symbol data_p): New const method.
6304         (struct minimal_symbol text_p): Likewise.
6305         * symtab.c (output_source_filename): Use file name style
6306         to print file name.
6307         (print_symbol_info): Likewise.
6308         (print_msymbol_info): Use address style to print addresses.
6309         Use function name style to print executable text symbols.
6310         (expand_symtab_containing_pc): Use data_p.
6311         (find_pc_sect_compunit_symtab): Likewise.
6312
6313 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6314
6315         * breakpoint.c (describe_other_breakpoints): Use address style
6316         to print addresses.
6317         (say_where): Likewise.
6318
6319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6320
6321         * ada-typeprint.c (print_func_type): Print function name
6322         style to print function name.
6323         * c-typeprint.c (c_print_type_1): Likewise.
6324
6325 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6326
6327         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6328         for execve.
6329
6330 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6331
6332         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6333         type_stack.
6334
6335 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6336
6337         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6338         TYPE_CODE_REF types.
6339
6340 2019-02-08  Jim Wilson  <jimw@sifive.com>
6341
6342         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6343         (riscv_linux_fregset): New.
6344         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6345
6346 2019-02-07  Tom Tromey  <tom@tromey.com>
6347
6348         * thread.c (thread_cancel_execution_command): Update.
6349         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6350         methods.
6351         (struct thread_fsm_ops): Remove.
6352         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6353         (thread_fsm_should_stop, thread_fsm_return_value)
6354         (thread_fsm_set_finished, thread_fsm_finished_p)
6355         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6356         Don't declare.
6357         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6358         * infrun.c (clear_proceed_status_thread)
6359         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6360         (print_stop_event): Update.
6361         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6362         Add constructor.
6363         (step_command_fsm_ops): Remove.
6364         (new_step_command_fsm): Remove.
6365         (step_1): Update.
6366         (step_command_fsm::should_stop): Rename from
6367         step_command_fsm_should_stop.
6368         (step_command_fsm::clean_up): Rename from
6369         step_command_fsm_clean_up.
6370         (step_command_fsm::do_async_reply_reason): Rename from
6371         step_command_fsm_async_reply_reason.
6372         (struct until_next_fsm): Inherit from thread_fsm.  Add
6373         constructor.
6374         (until_next_fsm_ops): Remove.
6375         (new_until_next_fsm): Remove.
6376         (until_next_fsm::should_stop): Rename from
6377         until_next_fsm_should_stop.
6378         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6379         (until_next_fsm::do_async_reply_reason): Rename from
6380         until_next_fsm_async_reply_reason.
6381         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6382         constructor.  Change type of breakpoint.
6383         (finish_command_fsm_ops): Remove.
6384         (new_finish_command_fsm): Remove.
6385         (finish_command_fsm::should_stop): Rename from
6386         finish_command_fsm_should_stop.
6387         (finish_command_fsm::clean_up): Rename from
6388         finish_command_fsm_clean_up.
6389         (finish_command_fsm::return_value): Rename from
6390         finish_command_fsm_return_value.
6391         (finish_command_fsm::do_async_reply_reason): Rename from
6392         finish_command_fsm_async_reply_reason.
6393         (finish_command): Update.
6394         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6395         Add constructor.
6396         (call_thread_fsm_ops): Remove.
6397         (call_thread_fsm::call_thread_fsm): Rename from
6398         new_call_thread_fsm.
6399         (call_thread_fsm::should_stop): Rename from
6400         call_thread_fsm_should_stop.
6401         (call_thread_fsm::should_notify_stop): Rename from
6402         call_thread_fsm_should_notify_stop.
6403         (run_inferior_call, call_function_by_hand_dummy): Update.
6404         * cli/cli-interp.c (should_print_stop_to_console): Update.
6405         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6406         Add constructor.  Change type of location_breakpoint,
6407         caller_breakpoint.
6408         (until_break_fsm_ops): Remove.
6409         (new_until_break_fsm): Remove.
6410         (until_break_fsm::should_stop): Rename from
6411         until_break_fsm_should_stop.
6412         (until_break_fsm::clean_up): Rename from
6413         until_break_fsm_clean_up.
6414         (until_break_fsm::do_async_reply_reason): Rename from
6415         until_break_fsm_async_reply_reason.
6416         (until_break_command): Update.
6417         * thread-fsm.c: Remove.
6418         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6419
6420 2019-02-07  Tom Tromey  <tom@tromey.com>
6421
6422         * yy-remap.h: Add include guard.
6423         * xtensa-tdep.h: Add include guard.
6424         * xcoffread.h: Rename include guard.
6425         * varobj-iter.h: Add include guard.
6426         * tui/tui.h: Rename include guard.
6427         * tui/tui-winsource.h: Rename include guard.
6428         * tui/tui-wingeneral.h: Rename include guard.
6429         * tui/tui-windata.h: Rename include guard.
6430         * tui/tui-win.h: Rename include guard.
6431         * tui/tui-stack.h: Rename include guard.
6432         * tui/tui-source.h: Rename include guard.
6433         * tui/tui-regs.h: Rename include guard.
6434         * tui/tui-out.h: Rename include guard.
6435         * tui/tui-layout.h: Rename include guard.
6436         * tui/tui-io.h: Rename include guard.
6437         * tui/tui-hooks.h: Rename include guard.
6438         * tui/tui-file.h: Rename include guard.
6439         * tui/tui-disasm.h: Rename include guard.
6440         * tui/tui-data.h: Rename include guard.
6441         * tui/tui-command.h: Rename include guard.
6442         * tic6x-tdep.h: Add include guard.
6443         * target/waitstatus.h: Rename include guard.
6444         * target/wait.h: Rename include guard.
6445         * target/target.h: Rename include guard.
6446         * target/resume.h: Rename include guard.
6447         * target-float.h: Rename include guard.
6448         * stabsread.h: Add include guard.
6449         * rs6000-tdep.h: Add include guard.
6450         * riscv-fbsd-tdep.h: Add include guard.
6451         * regformats/regdef.h: Rename include guard.
6452         * record.h: Rename include guard.
6453         * python/python.h: Rename include guard.
6454         * python/python-internal.h: Rename include guard.
6455         * python/py-stopevent.h: Rename include guard.
6456         * python/py-ref.h: Rename include guard.
6457         * python/py-record.h: Rename include guard.
6458         * python/py-record-full.h: Rename include guard.
6459         * python/py-record-btrace.h: Rename include guard.
6460         * python/py-instruction.h: Rename include guard.
6461         * python/py-events.h: Rename include guard.
6462         * python/py-event.h: Rename include guard.
6463         * procfs.h: Add include guard.
6464         * proc-utils.h: Add include guard.
6465         * p-lang.h: Add include guard.
6466         * or1k-tdep.h: Rename include guard.
6467         * observable.h: Rename include guard.
6468         * nto-tdep.h: Rename include guard.
6469         * nat/x86-linux.h: Rename include guard.
6470         * nat/x86-linux-dregs.h: Rename include guard.
6471         * nat/x86-gcc-cpuid.h: Add include guard.
6472         * nat/x86-dregs.h: Rename include guard.
6473         * nat/x86-cpuid.h: Rename include guard.
6474         * nat/ppc-linux.h: Rename include guard.
6475         * nat/mips-linux-watch.h: Rename include guard.
6476         * nat/linux-waitpid.h: Rename include guard.
6477         * nat/linux-ptrace.h: Rename include guard.
6478         * nat/linux-procfs.h: Rename include guard.
6479         * nat/linux-osdata.h: Rename include guard.
6480         * nat/linux-nat.h: Rename include guard.
6481         * nat/linux-namespaces.h: Rename include guard.
6482         * nat/linux-btrace.h: Rename include guard.
6483         * nat/glibc_thread_db.h: Rename include guard.
6484         * nat/gdb_thread_db.h: Rename include guard.
6485         * nat/gdb_ptrace.h: Rename include guard.
6486         * nat/fork-inferior.h: Rename include guard.
6487         * nat/amd64-linux-siginfo.h: Rename include guard.
6488         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6489         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6490         * nat/aarch64-linux.h: Rename include guard.
6491         * nat/aarch64-linux-hw-point.h: Rename include guard.
6492         * mn10300-tdep.h: Add include guard.
6493         * mips-linux-tdep.h: Add include guard.
6494         * mi/mi-parse.h: Rename include guard.
6495         * mi/mi-out.h: Rename include guard.
6496         * mi/mi-main.h: Rename include guard.
6497         * mi/mi-interp.h: Rename include guard.
6498         * mi/mi-getopt.h: Rename include guard.
6499         * mi/mi-console.h: Rename include guard.
6500         * mi/mi-common.h: Rename include guard.
6501         * mi/mi-cmds.h: Rename include guard.
6502         * mi/mi-cmd-break.h: Rename include guard.
6503         * m2-lang.h: Add include guard.
6504         * location.h: Rename include guard.
6505         * linux-record.h: Rename include guard.
6506         * linux-nat.h: Add include guard.
6507         * linux-fork.h: Add include guard.
6508         * i386-darwin-tdep.h: Rename include guard.
6509         * hppa-linux-offsets.h: Add include guard.
6510         * guile/guile.h: Rename include guard.
6511         * guile/guile-internal.h: Rename include guard.
6512         * gnu-nat.h: Rename include guard.
6513         * gdb-stabs.h: Rename include guard.
6514         * frv-tdep.h: Add include guard.
6515         * f-lang.h: Add include guard.
6516         * event-loop.h: Add include guard.
6517         * darwin-nat.h: Rename include guard.
6518         * cp-abi.h: Rename include guard.
6519         * config/sparc/nm-sol2.h: Rename include guard.
6520         * config/nm-nto.h: Rename include guard.
6521         * config/nm-linux.h: Add include guard.
6522         * config/i386/nm-i386gnu.h: Rename include guard.
6523         * config/djgpp/nl_types.h: Rename include guard.
6524         * config/djgpp/langinfo.h: Rename include guard.
6525         * compile/gcc-cp-plugin.h: Add include guard.
6526         * compile/gcc-c-plugin.h: Add include guard.
6527         * compile/compile.h: Rename include guard.
6528         * compile/compile-object-run.h: Rename include guard.
6529         * compile/compile-object-load.h: Rename include guard.
6530         * compile/compile-internal.h: Rename include guard.
6531         * compile/compile-cplus.h: Rename include guard.
6532         * compile/compile-c.h: Rename include guard.
6533         * common/xml-utils.h: Rename include guard.
6534         * common/x86-xstate.h: Rename include guard.
6535         * common/version.h: Rename include guard.
6536         * common/vec.h: Rename include guard.
6537         * common/tdesc.h: Rename include guard.
6538         * common/selftest.h: Rename include guard.
6539         * common/scoped_restore.h: Rename include guard.
6540         * common/scoped_mmap.h: Rename include guard.
6541         * common/scoped_fd.h: Rename include guard.
6542         * common/safe-iterator.h: Rename include guard.
6543         * common/run-time-clock.h: Rename include guard.
6544         * common/refcounted-object.h: Rename include guard.
6545         * common/queue.h: Rename include guard.
6546         * common/ptid.h: Rename include guard.
6547         * common/print-utils.h: Rename include guard.
6548         * common/preprocessor.h: Rename include guard.
6549         * common/pathstuff.h: Rename include guard.
6550         * common/observable.h: Rename include guard.
6551         * common/netstuff.h: Rename include guard.
6552         * common/job-control.h: Rename include guard.
6553         * common/host-defs.h: Rename include guard.
6554         * common/gdb_wait.h: Rename include guard.
6555         * common/gdb_vecs.h: Rename include guard.
6556         * common/gdb_unlinker.h: Rename include guard.
6557         * common/gdb_unique_ptr.h: Rename include guard.
6558         * common/gdb_tilde_expand.h: Rename include guard.
6559         * common/gdb_sys_time.h: Rename include guard.
6560         * common/gdb_string_view.h: Rename include guard.
6561         * common/gdb_splay_tree.h: Rename include guard.
6562         * common/gdb_setjmp.h: Rename include guard.
6563         * common/gdb_ref_ptr.h: Rename include guard.
6564         * common/gdb_optional.h: Rename include guard.
6565         * common/gdb_locale.h: Rename include guard.
6566         * common/gdb_assert.h: Rename include guard.
6567         * common/filtered-iterator.h: Rename include guard.
6568         * common/filestuff.h: Rename include guard.
6569         * common/fileio.h: Rename include guard.
6570         * common/environ.h: Rename include guard.
6571         * common/common-utils.h: Rename include guard.
6572         * common/common-types.h: Rename include guard.
6573         * common/common-regcache.h: Rename include guard.
6574         * common/common-inferior.h: Rename include guard.
6575         * common/common-gdbthread.h: Rename include guard.
6576         * common/common-exceptions.h: Rename include guard.
6577         * common/common-defs.h: Rename include guard.
6578         * common/common-debug.h: Rename include guard.
6579         * common/cleanups.h: Rename include guard.
6580         * common/buffer.h: Rename include guard.
6581         * common/btrace-common.h: Rename include guard.
6582         * common/break-common.h: Rename include guard.
6583         * cli/cli-utils.h: Rename include guard.
6584         * cli/cli-style.h: Rename include guard.
6585         * cli/cli-setshow.h: Rename include guard.
6586         * cli/cli-script.h: Rename include guard.
6587         * cli/cli-interp.h: Rename include guard.
6588         * cli/cli-decode.h: Rename include guard.
6589         * cli/cli-cmds.h: Rename include guard.
6590         * charset-list.h: Add include guard.
6591         * buildsym-legacy.h: Rename include guard.
6592         * bfin-tdep.h: Add include guard.
6593         * ax.h: Rename include guard.
6594         * arm-linux-tdep.h: Add include guard.
6595         * arm-fbsd-tdep.h: Add include guard.
6596         * arch/xtensa.h: Rename include guard.
6597         * arch/tic6x.h: Add include guard.
6598         * arch/i386.h: Add include guard.
6599         * arch/arm.h: Rename include guard.
6600         * arch/arm-linux.h: Rename include guard.
6601         * arch/arm-get-next-pcs.h: Rename include guard.
6602         * arch/amd64.h: Add include guard.
6603         * arch/aarch64-insn.h: Rename include guard.
6604         * arch-utils.h: Rename include guard.
6605         * annotate.h: Add include guard.
6606         * amd64-darwin-tdep.h: Rename include guard.
6607         * aarch64-linux-tdep.h: Add include guard.
6608         * aarch64-fbsd-tdep.h: Add include guard.
6609         * aarch32-linux-nat.h: Add include guard.
6610
6611 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6612
6613         * macrotab.c (macro_define_internal): New function that
6614         factorizes macro_define_object_internal and macro_define_function
6615         code.
6616         (macro_define_object_internal): Use macro_define_internal.
6617         (macro_define_function): Likewise.
6618
6619 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6620
6621         * macrocmd.c (extract_identifier): Return
6622         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6623         callers.
6624
6625 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6626
6627         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6628
6629 2019-02-05  Tom Tromey  <tom@tromey.com>
6630
6631         * target.c (target_stack::unpush): Move assertion earlier.
6632
6633 2019-01-30  Tom Tromey  <tom@tromey.com>
6634
6635         PR python/23615:
6636         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6637         (gdbpy_parse_and_eval): Likewise.
6638         * python/python-internal.h (gdbpy_allow_threads): New class.
6639
6640 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6641
6642         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6643         (aarch64_fbsd_fpregmap): Move earlier.
6644         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6645         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6646         instead of individual calls to trad_frame_set_reg_addr.
6647         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6648         earlier.
6649         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6650         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6651         instead of individual calls to trad_frame_set_reg_addr.
6652
6653 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * CONTRIBUTE: Replace contribution list with wiki link.
6656
6657 2019-01-25  Tom Tromey  <tom@tromey.com>
6658
6659         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6660
6661 2019-01-25  Tom Tromey  <tom@tromey.com>
6662
6663         * xtensa-linux-nat.c: Fix common/ includes.
6664         * xml-support.h: Fix common/ includes.
6665         * xml-support.c: Fix common/ includes.
6666         * x86-linux-nat.c: Fix common/ includes.
6667         * windows-nat.c: Fix common/ includes.
6668         * varobj.h: Fix common/ includes.
6669         * varobj.c: Fix common/ includes.
6670         * value.c: Fix common/ includes.
6671         * valops.c: Fix common/ includes.
6672         * utils.c: Fix common/ includes.
6673         * unittests/xml-utils-selftests.c: Fix common/ includes.
6674         * unittests/utils-selftests.c: Fix common/ includes.
6675         * unittests/unpack-selftests.c: Fix common/ includes.
6676         * unittests/tracepoint-selftests.c: Fix common/ includes.
6677         * unittests/style-selftests.c: Fix common/ includes.
6678         * unittests/string_view-selftests.c: Fix common/ includes.
6679         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6680         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6681         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6682         * unittests/rsp-low-selftests.c: Fix common/ includes.
6683         * unittests/parse-connection-spec-selftests.c: Fix common/
6684         includes.
6685         * unittests/optional-selftests.c: Fix common/ includes.
6686         * unittests/offset-type-selftests.c: Fix common/ includes.
6687         * unittests/observable-selftests.c: Fix common/ includes.
6688         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6689         * unittests/memrange-selftests.c: Fix common/ includes.
6690         * unittests/memory-map-selftests.c: Fix common/ includes.
6691         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6692         * unittests/function-view-selftests.c: Fix common/ includes.
6693         * unittests/environ-selftests.c: Fix common/ includes.
6694         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6695         * unittests/common-utils-selftests.c: Fix common/ includes.
6696         * unittests/cli-utils-selftests.c: Fix common/ includes.
6697         * unittests/array-view-selftests.c: Fix common/ includes.
6698         * ui-file.c: Fix common/ includes.
6699         * tui/tui-io.c: Fix common/ includes.
6700         * tracepoint.h: Fix common/ includes.
6701         * tracepoint.c: Fix common/ includes.
6702         * tracefile-tfile.c: Fix common/ includes.
6703         * top.h: Fix common/ includes.
6704         * top.c: Fix common/ includes.
6705         * thread.c: Fix common/ includes.
6706         * target/waitstatus.h: Fix common/ includes.
6707         * target/waitstatus.c: Fix common/ includes.
6708         * target.h: Fix common/ includes.
6709         * target.c: Fix common/ includes.
6710         * target-memory.c: Fix common/ includes.
6711         * target-descriptions.c: Fix common/ includes.
6712         * symtab.h: Fix common/ includes.
6713         * symfile.c: Fix common/ includes.
6714         * stap-probe.c: Fix common/ includes.
6715         * spu-linux-nat.c: Fix common/ includes.
6716         * sparc-nat.c: Fix common/ includes.
6717         * source.c: Fix common/ includes.
6718         * solib.c: Fix common/ includes.
6719         * solib-target.c: Fix common/ includes.
6720         * ser-unix.c: Fix common/ includes.
6721         * ser-tcp.c: Fix common/ includes.
6722         * ser-pipe.c: Fix common/ includes.
6723         * ser-base.c: Fix common/ includes.
6724         * selftest-arch.c: Fix common/ includes.
6725         * s12z-tdep.c: Fix common/ includes.
6726         * rust-exp.y: Fix common/ includes.
6727         * rs6000-aix-tdep.c: Fix common/ includes.
6728         * riscv-tdep.c: Fix common/ includes.
6729         * remote.c: Fix common/ includes.
6730         * remote-notif.h: Fix common/ includes.
6731         * remote-fileio.h: Fix common/ includes.
6732         * remote-fileio.c: Fix common/ includes.
6733         * regcache.h: Fix common/ includes.
6734         * regcache.c: Fix common/ includes.
6735         * record-btrace.c: Fix common/ includes.
6736         * python/python.c: Fix common/ includes.
6737         * python/py-type.c: Fix common/ includes.
6738         * python/py-inferior.c: Fix common/ includes.
6739         * progspace.h: Fix common/ includes.
6740         * producer.c: Fix common/ includes.
6741         * procfs.c: Fix common/ includes.
6742         * proc-api.c: Fix common/ includes.
6743         * printcmd.c: Fix common/ includes.
6744         * ppc-linux-nat.c: Fix common/ includes.
6745         * parser-defs.h: Fix common/ includes.
6746         * osdata.c: Fix common/ includes.
6747         * obsd-nat.c: Fix common/ includes.
6748         * nat/x86-linux.c: Fix common/ includes.
6749         * nat/x86-linux-dregs.c: Fix common/ includes.
6750         * nat/x86-dregs.h: Fix common/ includes.
6751         * nat/x86-dregs.c: Fix common/ includes.
6752         * nat/ppc-linux.c: Fix common/ includes.
6753         * nat/mips-linux-watch.h: Fix common/ includes.
6754         * nat/mips-linux-watch.c: Fix common/ includes.
6755         * nat/linux-waitpid.c: Fix common/ includes.
6756         * nat/linux-ptrace.h: Fix common/ includes.
6757         * nat/linux-ptrace.c: Fix common/ includes.
6758         * nat/linux-procfs.c: Fix common/ includes.
6759         * nat/linux-personality.c: Fix common/ includes.
6760         * nat/linux-osdata.c: Fix common/ includes.
6761         * nat/linux-namespaces.c: Fix common/ includes.
6762         * nat/linux-btrace.h: Fix common/ includes.
6763         * nat/linux-btrace.c: Fix common/ includes.
6764         * nat/fork-inferior.c: Fix common/ includes.
6765         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6766         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6767         * nat/aarch64-linux.c: Fix common/ includes.
6768         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6769         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6770         * namespace.h: Fix common/ includes.
6771         * mips-linux-tdep.c: Fix common/ includes.
6772         * minsyms.c: Fix common/ includes.
6773         * mi/mi-parse.h: Fix common/ includes.
6774         * mi/mi-main.c: Fix common/ includes.
6775         * mi/mi-cmd-env.c: Fix common/ includes.
6776         * memrange.h: Fix common/ includes.
6777         * memattr.c: Fix common/ includes.
6778         * maint.h: Fix common/ includes.
6779         * maint.c: Fix common/ includes.
6780         * main.c: Fix common/ includes.
6781         * machoread.c: Fix common/ includes.
6782         * location.c: Fix common/ includes.
6783         * linux-thread-db.c: Fix common/ includes.
6784         * linux-nat.c: Fix common/ includes.
6785         * linux-fork.c: Fix common/ includes.
6786         * inline-frame.c: Fix common/ includes.
6787         * infrun.c: Fix common/ includes.
6788         * inflow.c: Fix common/ includes.
6789         * inferior.h: Fix common/ includes.
6790         * inferior.c: Fix common/ includes.
6791         * infcmd.c: Fix common/ includes.
6792         * inf-ptrace.c: Fix common/ includes.
6793         * inf-child.c: Fix common/ includes.
6794         * ia64-linux-nat.c: Fix common/ includes.
6795         * i387-tdep.c: Fix common/ includes.
6796         * i386-tdep.c: Fix common/ includes.
6797         * i386-linux-tdep.c: Fix common/ includes.
6798         * i386-linux-nat.c: Fix common/ includes.
6799         * i386-go32-tdep.c: Fix common/ includes.
6800         * i386-fbsd-tdep.c: Fix common/ includes.
6801         * i386-fbsd-nat.c: Fix common/ includes.
6802         * guile/scm-type.c: Fix common/ includes.
6803         * guile/guile.c: Fix common/ includes.
6804         * go32-nat.c: Fix common/ includes.
6805         * gnu-nat.c: Fix common/ includes.
6806         * gdbthread.h: Fix common/ includes.
6807         * gdbarch-selftests.c: Fix common/ includes.
6808         * gdb_usleep.c: Fix common/ includes.
6809         * gdb_select.h: Fix common/ includes.
6810         * gdb_bfd.c: Fix common/ includes.
6811         * gcore.c: Fix common/ includes.
6812         * fork-child.c: Fix common/ includes.
6813         * findvar.c: Fix common/ includes.
6814         * fbsd-nat.c: Fix common/ includes.
6815         * event-top.c: Fix common/ includes.
6816         * event-loop.c: Fix common/ includes.
6817         * dwarf2read.c: Fix common/ includes.
6818         * dwarf2loc.c: Fix common/ includes.
6819         * dwarf2-frame.c: Fix common/ includes.
6820         * dwarf-index-cache.c: Fix common/ includes.
6821         * dtrace-probe.c: Fix common/ includes.
6822         * disasm-selftests.c: Fix common/ includes.
6823         * defs.h: Fix common/ includes.
6824         * csky-tdep.c: Fix common/ includes.
6825         * cp-valprint.c: Fix common/ includes.
6826         * cp-support.h: Fix common/ includes.
6827         * cp-support.c: Fix common/ includes.
6828         * corelow.c: Fix common/ includes.
6829         * completer.h: Fix common/ includes.
6830         * completer.c: Fix common/ includes.
6831         * compile/compile.c: Fix common/ includes.
6832         * compile/compile-loc2c.c: Fix common/ includes.
6833         * compile/compile-cplus-types.c: Fix common/ includes.
6834         * compile/compile-cplus-symbols.c: Fix common/ includes.
6835         * command.h: Fix common/ includes.
6836         * cli/cli-dump.c: Fix common/ includes.
6837         * cli/cli-cmds.c: Fix common/ includes.
6838         * charset.c: Fix common/ includes.
6839         * build-id.c: Fix common/ includes.
6840         * btrace.h: Fix common/ includes.
6841         * btrace.c: Fix common/ includes.
6842         * breakpoint.h: Fix common/ includes.
6843         * breakpoint.c: Fix common/ includes.
6844         * ax.h:
6845         (enum agent_op): Fix common/ includes.
6846         * ax-general.c (struct aop_map): Fix common/ includes.
6847         * ax-gdb.c: Fix common/ includes.
6848         * auxv.c: Fix common/ includes.
6849         * auto-load.c: Fix common/ includes.
6850         * arm-tdep.c: Fix common/ includes.
6851         * arch/riscv.c: Fix common/ includes.
6852         * arch/ppc-linux-common.c: Fix common/ includes.
6853         * arch/i386.c: Fix common/ includes.
6854         * arch/arm.c: Fix common/ includes.
6855         * arch/arm-linux.c: Fix common/ includes.
6856         * arch/arm-get-next-pcs.c: Fix common/ includes.
6857         * arch/amd64.c: Fix common/ includes.
6858         * arch/aarch64.c: Fix common/ includes.
6859         * arch/aarch64-insn.c: Fix common/ includes.
6860         * arch-utils.c: Fix common/ includes.
6861         * amd64-windows-tdep.c: Fix common/ includes.
6862         * amd64-tdep.c: Fix common/ includes.
6863         * amd64-sol2-tdep.c: Fix common/ includes.
6864         * amd64-obsd-tdep.c: Fix common/ includes.
6865         * amd64-nbsd-tdep.c: Fix common/ includes.
6866         * amd64-linux-tdep.c: Fix common/ includes.
6867         * amd64-linux-nat.c: Fix common/ includes.
6868         * amd64-fbsd-tdep.c: Fix common/ includes.
6869         * amd64-fbsd-nat.c: Fix common/ includes.
6870         * amd64-dicos-tdep.c: Fix common/ includes.
6871         * amd64-darwin-tdep.c: Fix common/ includes.
6872         * agent.c: Fix common/ includes.
6873         * ada-lang.h: Fix common/ includes.
6874         * ada-lang.c: Fix common/ includes.
6875         * aarch64-tdep.c: Fix common/ includes.
6876
6877 2019-01-25  Tom Tromey  <tom@tromey.com>
6878
6879         * common/create-version.sh: Use common/version.h.
6880
6881 2019-01-24  Pedro Alves  <palves@redhat.com>
6882
6883         * infrun.c (signal_stop, signal_print, signal_program)
6884         (signal_catch, signal_pass): Now arrays instead of pointers.
6885         (update_signals_program_target, do_target_resume)
6886         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6887         * linux-nat.c (linux_nat_target::pass_signals)
6888         (linux_nat_target::create_inferior, linux_nat_target::attach):
6889         Adjust.
6890         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6891         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6892         * procfs.c (procfs_target::pass_signals): Adjust.
6893         * record-full.c (record_full_target::resume): Adjust.
6894         * remote.c (remote_target::pass_signals)
6895         (remote_target::program_signals): Adjust.
6896         * target-debug.h (target_debug_print_signals): Now takes a
6897         gdb::array_view as parameter.  Adjust.
6898         * target.h (target_ops) <pass_signals, program_signals>: Replace
6899         pointer and length parameters with gdb::array_view.
6900         (target_pass_signals, target_program_signals): Likewise.
6901         * target-delegates.c: Regenerate.
6902
6903 2019-01-24  Pedro Alves  <palves@redhat.com>
6904
6905         * common/forward-scope-exit.h
6906         (forward_scope_exit::forward_scope_exit): Pass arguments to
6907         m_bind_function directly, instead of creating a std::bind and
6908         copying that.
6909
6910 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6911
6912         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6913         for static members.
6914         (pass_in_v_vfp_candidate): Likewise.
6915
6916 2019-01-23  Tom Tromey  <tom@tromey.com>
6917             Pedro Alves  <palves@redhat.com>
6918
6919         * regcache.c (class regcache_invalidator): Remove.
6920         (regcache::raw_write): Use make_scope_exit.
6921
6922 2019-01-23  Tom Tromey  <tom@tromey.com>
6923
6924         * ui-out.h (class ui_out_emit_type): Update comment.
6925
6926 2019-01-23  Tom Tromey  <tom@tromey.com>
6927
6928         * infrun.c (fetch_inferior_event): Update comment.
6929
6930 2019-01-23  Tom Tromey  <tom@tromey.com>
6931             Pedro Alves  <palves@redhat.com>
6932
6933         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6934         parameter.
6935         (fetch_inferior_event): Use SCOPE_EXIT.
6936
6937
6938 2019-01-23  Tom Tromey  <tom@tromey.com>
6939             Pedro Alves  <palves@redhat.com>
6940
6941         * infrun.c (disable_thread_events): Delete.
6942         (stop_all_threads): Use SCOPE_EXIT.
6943
6944 2019-01-23  Tom Tromey  <tom@tromey.com>
6945             Pedro Alves  <palves@redhat.com>
6946
6947         * symfile.c: Include forward-scope-exit.h.
6948         (clear_symtab_users_cleanup): Replace forward declaration with
6949         a FORWARD_SCOPE_EXIT.
6950         (syms_from_objfile_1): Use the forward_scope_exit and
6951         gdb::optional instead of cleanup_function.
6952         (reread_symbols): Use the forward_scope_exit instead of
6953         cleanup_function.
6954         (clear_symtab_users_cleanup): Remove function.
6955
6956 2019-01-23  Tom Tromey  <tom@tromey.com>
6957             Pedro Alves  <palves@redhat.com>
6958
6959         * linux-nat.c: Include scope-exit.h.
6960         (cleanup_target_stop): Remove.
6961         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6962         SCOPE_EXIT.
6963
6964 2019-01-23  Tom Tromey  <tom@tromey.com>
6965             Pedro Alves  <palves@redhat.com>
6966
6967         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6968         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6969
6970 2019-01-23  Tom Tromey  <tom@tromey.com>
6971             Andrew Burgess  <andrew.burgess@embecosm.com>
6972             Pedro Alves  <palves@redhat.com>
6973
6974         * infrun.c (fetch_inferior_event): Use scope_exit.
6975         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6976         * top.c (execute_command): Use scope_exit.
6977         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6978         * utils.c (do_bpstat_clear_actions_cleanup)
6979         (make_bpstat_clear_actions_cleanup): Remove.
6980
6981 2019-01-23  Tom Tromey  <tom@tromey.com>
6982             Pedro Alves  <palves@redhat.com>
6983
6984         * infrun.c: Include "common/scope-exit.h"
6985         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6986         (wait_for_inferior): Use SCOPE_EXIT.
6987         (fetch_inferior_event): Use scope_exit.
6988
6989 2019-01-23  Tom Tromey  <tom@tromey.com>
6990             Pedro Alves  <palves@redhat.com>
6991
6992         * breakpoint.c (create_breakpoint): Remove cleanup.
6993
6994 2019-01-23  Tom Tromey  <tom@tromey.com>
6995             Andrew Burgess  <andrew.burgess@embecosm.com>
6996             Pedro Alves  <palves@redhat.com>
6997
6998 2019-01-23  Pedro Alves  <palves@redhat.com>
6999
7000         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7001
7002 2019-01-23  Pedro Alves  <palves@redhat.com>
7003             Andrew Burgess  <andrew.burgess@embecosm.com>
7004
7005         * gdbthread.h: Include "common/forward-scope-exit.h".
7006         (scoped_finish_thread_state): Redefine custom class in terms of
7007         forward_scope_exit.
7008
7009 2019-01-23  Pedro Alves  <palves@redhat.com>
7010             Andrew Burgess  <andrew.burgess@embecosm.com>
7011
7012         * common/forward-scope-exit.h: New file.
7013
7014 2019-01-23  Pedro Alves  <palves@redhat.com>
7015             Andrew Burgess  <andrew.burgess@embecosm.com>
7016             Tom Tromey  <tom@tromey.com>
7017
7018         * common/scope-exit.h: New file.
7019
7020 2019-01-23  Pedro Alves  <palves@redhat.com>
7021
7022         * common/preprocessor.h (ESC): Rename to ...
7023         (ESC_PARENS): ... this.
7024         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7025         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7026
7027 2019-01-23  Tom Tromey  <tom@tromey.com>
7028
7029         * language.h (class scoped_switch_to_sym_language_if_auto):
7030         Initialize m_lang in both cases.
7031
7032 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7033
7034         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7035         with XCNEW.
7036
7037 2019-01-22  Tom Tromey  <tom@tromey.com>
7038
7039         * corelow.c: Do not include sys/file.h.
7040
7041 2019-01-22  Tom Tromey  <tom@tromey.com>
7042
7043         * tui/tui-wingeneral.h: Include gdb_curses.h.
7044
7045 2019-01-22  Tom Tromey  <tom@tromey.com>
7046
7047         * source-cache.h (class source_cache) <get_source_lines,
7048         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7049
7050 2019-01-22  Tom Tromey  <tom@tromey.com>
7051
7052         * remote-fileio.h (struct remote_target): Declare.
7053
7054 2019-01-22  Tom Tromey  <tom@tromey.com>
7055
7056         * python/py-arch.c: Do not include py-ref.h.
7057         * python/py-bpevent.c: Do not include py-ref.h.
7058         * python/py-cmd.c: Do not include py-ref.h.
7059         * python/py-continueevent.c: Do not include py-ref.h.
7060         * python/py-event.h: Do not include py-ref.h.
7061         * python/py-evtregistry.c: Do not include py-ref.h.
7062         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7063         * python/py-frame.c: Do not include py-ref.h.
7064         * python/py-framefilter.c: Do not include py-ref.h.
7065         * python/py-function.c: Do not include py-ref.h.
7066         * python/py-infevents.c: Do not include py-ref.h.
7067         * python/py-linetable.c: Do not include py-ref.h.
7068         * python/py-objfile.c: Do not include py-ref.h.
7069         * python/py-param.c: Do not include py-ref.h.
7070         * python/py-prettyprint.c: Do not include py-ref.h.
7071         * python/py-progspace.c: Do not include py-ref.h.
7072         * python/py-symbol.c: Do not include py-ref.h.
7073         * python/py-symtab.c: Do not include py-ref.h.
7074         * python/py-type.c: Do not include py-ref.h.
7075         * python/py-unwind.c: Do not include py-ref.h.
7076         * python/py-utils.c: Do not include py-ref.h.
7077         * python/py-value.c: Do not include py-ref.h.
7078         * python/py-varobj.c: Do not include py-ref.h.
7079         * python/py-xmethods.c: Do not include py-ref.h.
7080         * python/python.c: Do not include py-ref.h.
7081         * varobj.c: Do not include py-ref.h.
7082
7083 2019-01-22  Tom Tromey  <tom@tromey.com>
7084
7085         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7086         keyword for bcache.
7087
7088 2019-01-22  Tom Tromey  <tom@tromey.com>
7089
7090         * compile/compile-cplus-types.c: Remove a comment by #include.
7091
7092 2019-01-22  Tom Tromey  <tom@tromey.com>
7093
7094         * compile/gcc-c-plugin.h: Include compile-internal.h.
7095
7096 2019-01-22  Tom Tromey  <tom@tromey.com>
7097
7098         * stabsread.c (EXTERN): Do not define.
7099         (symnum, next_symbol_text_func, processing_gcc_compilation)
7100         (within_function, global_sym_chain, global_stabs)
7101         (previous_stab_code, this_object_header_files)
7102         (n_this_object_header_files)
7103         (n_allocated_this_object_header_files): Define.
7104         * stabsread.h (EXTERN): Never define.  Use "extern".
7105
7106 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7107
7108         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7109         history_value.
7110
7111 2019-01-21  Tom Tromey  <tom@tromey.com>
7112
7113         * ui-out.c: Fix includes.
7114         * tui/tui-source.c: Fix includes.
7115         * target.c: Fix includes.
7116         * remote.c: Fix includes.
7117         * regcache.c: Fix includes.
7118         * python/py-block.c: Fix includes.
7119         * printcmd.c: Fix includes.
7120         * or1k-tdep.c: Fix includes.
7121         * mi/mi-main.c: Fix includes.
7122         * m32r-tdep.c: Fix includes.
7123         * csky-tdep.c: Fix includes.
7124         * compile/compile-cplus-types.c: Fix includes.
7125         * cli/cli-interp.c: Fix includes.
7126
7127 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7128
7129         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7130         for padding.
7131
7132 2019-01-16  Tom Tromey  <tom@tromey.com>
7133
7134         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7135         earlier.
7136         (struct objfile) <msymbols_range>: Move from top level.
7137         <msymbols>: New method.
7138         (class objfile_msymbols): Remove.
7139         * symtab.c (default_collect_symbol_completion_matches_break_on):
7140         Update.
7141         * symmisc.c (dump_msymbols): Update.
7142         * stabsread.c (scan_file_globals): Update.
7143         * objc-lang.c (info_selectors_command, info_classes_command)
7144         (find_methods): Update.
7145         * minsyms.c (find_solib_trampoline_target): Update.
7146         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7147         * coffread.c (coff_symfile_read): Update.
7148         * ada-lang.c (ada_lookup_simple_minsym)
7149         (ada_collect_symbol_completion_matches): Update.
7150
7151 2019-01-16  Tom Tromey  <tom@tromey.com>
7152
7153         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7154         type.  Remove no-argument constructor.
7155         <iterator::operator++>: Simplify.
7156         <begin>: Update.
7157         <end>: Use minimal_symbol_count.
7158
7159 2019-01-16  Tom Tromey  <tom@tromey.com>
7160
7161         * objfiles.h (struct objfile) <psymtabs>: New method.
7162         (class objfile_psymtabs): Remove.
7163         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7164         typedef.
7165         <range>: New method.
7166         (require_partial_symbols): Change return type.
7167         * psymtab.c (require_partial_symbols)
7168         (psym_expand_symtabs_matching): Update.
7169         * mdebugread.c (parse_partial_symbols): Update.
7170         * dbxread.c (dbx_end_psymtab): Update.
7171
7172 2019-01-15  Tom Tromey  <tom@tromey.com>
7173
7174         * symtab.c (lookup_objfile_from_block)
7175         (lookup_symbol_in_objfile_symtabs)
7176         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7177         (find_line_symtab, info_sources_command)
7178         (default_collect_symbol_completion_matches_break_on)
7179         (make_source_files_completion_list): Update.
7180         * symmisc.c (print_objfile_statistics, dump_objfile)
7181         (maintenance_print_symbols, maintenance_info_symtabs)
7182         (maintenance_check_symtabs, maintenance_info_line_tables):
7183         Update.
7184         * source.c (select_source_symtab)
7185         (forget_cached_source_info_for_objfile): Update.
7186         * objfiles.h (class objfile_compunits): Remove.
7187         (struct objfile) <compunits_range>: New typedef.
7188         (compunits): New method.
7189         * objfiles.c (objfile_relocate1): Update.
7190         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7191         * maint.c (count_symtabs_and_blocks): Update.
7192         * linespec.c (iterate_over_all_matching_symtabs): Update.
7193         * cp-support.c (add_symbol_overload_list_qualified): Update.
7194         * coffread.c (coff_symtab_read): Update.
7195         * ada-lang.c (add_nonlocal_symbols)
7196         (ada_collect_symbol_completion_matches)
7197         (ada_add_global_exceptions): Update.
7198
7199 2019-01-15  Tom Tromey  <tom@tromey.com>
7200
7201         * progspace.h (program_space) <objfiles_safe_range>: New
7202         typedef.
7203         <objfiles_safe>: New method.
7204         * objfiles.h (class all_objfiles_safe): Remove.
7205         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7206         * jit.c (jit_inferior_exit_hook): Update.
7207
7208 2019-01-17  Tom Tromey  <tom@tromey.com>
7209
7210         * progspace.h (program_space) <objfiles_range>: New typedef.
7211         <objfiles>: New method.
7212         <objfiles_head>: Rename from objfiles.
7213         (object_files): Update.
7214         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7215         * guile/scm-pretty-print.c
7216         (ppscm_find_pretty_printer_from_objfiles): Update.
7217         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7218         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7219         Update.
7220         * python/py-progspace.c (pspy_get_objfiles): Update.
7221         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7222         Update.
7223         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7224         (objfpy_lookup_objfile_by_build_id): Update.
7225         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7226         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7227         Update.
7228         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7229         (expand_symtab_containing_pc, lookup_objfile_from_block)
7230         (lookup_static_symbol, basic_lookup_transparent_type)
7231         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7232         (find_line_symtab, info_sources_command)
7233         (default_collect_symbol_completion_matches_break_on)
7234         (make_source_files_completion_list, find_main_name): Update.
7235         * symmisc.c (print_symbol_bcache_statistics)
7236         (print_objfile_statistics, maintenance_print_symbols)
7237         (maintenance_print_msymbols, maintenance_print_objfiles)
7238         (maintenance_info_symtabs, maintenance_check_symtabs)
7239         (maintenance_expand_symtabs, maintenance_info_line_tables):
7240         Update.
7241         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7242         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7243         (map_overlay_command, unmap_overlay_command)
7244         (simple_overlay_update, expand_symtabs_matching)
7245         (map_symbol_filenames): Update.
7246         * symfile-debug.c (set_debug_symfile): Update.
7247         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7248         Update.
7249         * source.c (select_source_symtab, forget_cached_source_info):
7250         Update.
7251         * solib.c (solib_read_symbols): Update.
7252         * solib-spu.c (append_ocl_sos): Update.
7253         * psymtab.c (maintenance_print_psymbols)
7254         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7255         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7256         * printcmd.c (info_symbol_command): Update.
7257         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7258         Update.
7259         * objfiles.h (class all_objfiles): Remove.
7260         * objfiles.c (have_partial_symbols, have_full_symbols)
7261         (have_minimal_symbols, qsort_cmp, update_section_map)
7262         (shared_objfile_contains_address_p)
7263         (default_iterate_over_objfiles_in_search_order): Update.
7264         * objc-lang.c (info_selectors_command, info_classes_command)
7265         (find_methods): Update.
7266         * minsyms.c (find_solib_trampoline_target): Update.
7267         * maint.c (maintenance_info_sections)
7268         (maintenance_translate_address, count_symtabs_and_blocks):
7269         Update.
7270         * main.c (captured_main_1): Update.
7271         * linux-thread-db.c (try_thread_db_load_from_pdir)
7272         (has_libpthread): Update.
7273         * linespec.c (iterate_over_all_matching_symtabs)
7274         (search_minsyms_for_name): Update.
7275         * jit.c (jit_find_objf_with_entry_addr): Update.
7276         * hppa-tdep.c (find_unwind_entry)
7277         (hppa_lookup_stub_minimal_symbol): Update.
7278         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7279         Update.
7280         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7281         (elf_gnu_ifunc_resolve_by_got): Update.
7282         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7283         * dwarf-index-write.c (save_gdb_index_command): Update.
7284         * cp-support.c (add_symbol_overload_list_qualified): Update.
7285         * breakpoint.c (create_overlay_event_breakpoint)
7286         (create_longjmp_master_breakpoint)
7287         (create_std_terminate_master_breakpoint)
7288         (create_exception_master_breakpoint): Update.
7289         * blockframe.c (find_pc_partial_function): Update.
7290         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7291         (ada_collect_symbol_completion_matches)
7292         (ada_add_global_exceptions): Update.
7293
7294 2019-01-17  Tom Tromey  <tom@tromey.com>
7295
7296         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7297         declare VEC.
7298         (solib_target_parse_libraries): Change return type.
7299         (library_list_start_segment, library_list_start_section)
7300         (library_list_end_library, library_list_start_library); Update.
7301         (solib_target_free_library_list): Remove.
7302         (solib_target_parse_libraries): Remove cleanup.  Change return
7303         type.
7304         (solib_target_current_sos): Update.
7305
7306 2019-01-17  Tom Tromey  <tromey@bapiya>
7307
7308         * valprint.c: Replace "the the" with "the".
7309         * symtab.c: Replace "the the" with "the".
7310         * solib.c: Replace "the the" with "the".
7311         * solib-dsbt.c: Replace "the the" with "the".
7312         * linespec.c: Replace "the the" with "the".
7313         * dwarf2loc.h: Replace "the the" with "the".
7314         * amd64-windows-tdep.c: Replace "the the" with "the".
7315         * aarch64-tdep.c: Replace "the the" with "the".
7316
7317 2019-01-16  Keith Seitz  <keiths@redhat.com>
7318
7319         PR gdb/23773
7320         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7321         <builder>: Rename to ..
7322         <m_builder>: ... this and make private.
7323         (dwarf2_cu::get_builder): New method.  Change all users of
7324         `builder' to use this method.
7325         (dwarf2_start_symtab): Move to ...
7326         (dwarf2_cu::start_symtab): ... here.  Update all callers
7327         (setup_type_unit_groups): Move to ...
7328         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7329         callers.
7330         (dwarf2_cu::reset_builder): New method.
7331         (process_full_compunit, process_full_type_unit): Use
7332         dwarf2_cu::reset_builder.
7333         (follow_die_offset): Record the ancestor CU if it is different
7334         from the followed DIE's CU.
7335         (follow_die_sig_1): Likewise.
7336
7337 2019-01-15  Tom Tromey  <tom@tromey.com>
7338
7339         * remote.c (class remote_state) <buf>: Now a char_vector.
7340         <buf_size>: Remove.
7341         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7342         parameter.
7343         (remote_target::getpkt_or_notif_sane_1)
7344         (remote_target::getpkt_sane)
7345         (remote_target::getpkt_or_notif_sane): Likewise.
7346         (class remote_target) <putpkt>: New overload.
7347         (remote_target::read_frame): Change type of "buf_p".  Remove
7348         sizeof_p parameter.
7349         (packet_ok): New overload.
7350         (packet_check_result): New overload.
7351         Update all uses.
7352
7353 2019-01-14  Tom Tromey  <tom@tromey.com>
7354
7355         * remote-notif.c (handle_notification, remote_notif_ack)
7356         (remote_notif_parse): Make "buf" const.
7357         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7358         const.
7359         (remote_notif_parse, remote_notif_ack, handle_notification):
7360         Likewise.
7361         * remote.c (remote_notif_stop_parse): Make "buf" const.
7362         (remote_target::remote_parse_stop_reply): Make "buf" const.
7363         (remote_notif_stop_ack): Make "buf" const.
7364
7365 2019-01-14  Tom Tromey  <tom@tromey.com>
7366
7367         * remote.c (remote_console_output): Make parameter const.
7368
7369 2019-01-14  Tom Tromey  <tom@tromey.com>
7370
7371         * target-debug.h (target_debug_print_signals): Constify.
7372         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7373         * procfs.c (procfs_target::pass_signals): Update.
7374         * linux-nat.c (linux_nat_target::pass_signals): Update.
7375         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7376         * target-delegates.c: Rebuild.
7377         * remote.c (remote_target::program_signals): Update.
7378         (remote_target::pass_signals): Update.
7379         * target.c (target_pass_signals): Constify argument.
7380         (target_program_signals): Likewise.
7381         * target.h (struct target_ops) <pass_signals, program_signals>:
7382         Constify argument.
7383         (target_pass_signals, target_program_signals): Constify argument.
7384
7385 2019-01-14  Tom Tromey  <tom@tromey.com>
7386
7387         PR tui/28819:
7388         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7389
7390 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7391
7392         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7393         field.
7394         * rs6000-tdep.c: Include reggroups.h.
7395         (IS_V_ALIAS_PSEUDOREG): Define.
7396         (rs6000_register_name): Return names for the "vX" aliases.
7397         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7398         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7399         aliases.  Call default_register_reggroup_p for all other
7400         pseudo-registers.
7401         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7402         New functions.
7403         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7404         Handle "vX" aliases.
7405         (v_alias_pseudo_register_collect): New function.
7406         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7407         (rs6000_gdbarch_init): Initialize "vX" aliases as
7408         pseudo-registers.  Restore registration of
7409         rs6000_pseudo_register_reggroup_p with
7410         set_tdesc_pseudo_register_reggroup_p.
7411
7412 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7413
7414         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7415         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7416         set_gdbarch_num_pseudo_regs.
7417
7418 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419
7420         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7421         Remove arg prefixname, add do_set and do_show.
7422         Add member functions set_list and show_list.
7423         * cli/cli-style.c (class cli_style_option): Update accordingly.
7424         (style_set_list): Move to file scope.
7425         (style_show_list): Likewise.
7426         (set_style): Call help_list.
7427         (show_style): Call cmd_show_list.
7428         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7429         Update to use the new macro.
7430
7431 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7432
7433         * ada-lang.c (_initialize_ada_language): Expand the help text
7434         for the "catch exception" command.
7435
7436 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7437
7438         * symtab.c (matching_obj_sections): Initialize obj,
7439         declare it closer to its usage.
7440
7441 2019-01-10  Tom Tromey  <tom@tromey.com>
7442
7443         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7444         (basic_inf_threads_range): Remove.
7445         (inf_threads_range, inf_non_exited_threads_range)
7446         (safe_inf_threads_range): Use next_adapter.
7447
7448 2019-01-10  Keith Seitz  <keiths@redhat.com>
7449
7450         PR gdb/23712
7451         PR symtab/23010
7452         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7453         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7454
7455 2019-01-10  Keith Seitz  <keiths@redhat.com>
7456
7457         PR gdb/23712
7458         PR symtab/23010
7459         * dictionary.c (pending_to_vector): Remove.
7460         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7461         Remove _1 suffix, replacing functions of the same name.  Update
7462         all callers.
7463         (dict_create_hashed, dict_create_hashed_expandable)
7464         (dict_create_linear, dict_create_linear_expandable, dict_free)
7465         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7466         Make functions static.
7467
7468 2019-01-10  Keith Seitz  <keiths@redhat.com>
7469
7470         PR gdb/23712
7471         PR symtab/23010
7472         * dictionary.h (struct dictionary): Replace declaration with
7473         multidictionary.
7474         (dict_create_hashed, dict_create_hashed_expandable)
7475         (dict_create_linear, dict_create_linear_expandable)
7476         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7477         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7478         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7479         taking multidictionary argument.
7480         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7481         * block.h (struct block) <dict>: Change to multidictionary
7482         and rename `multidict'.
7483         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7484         symmisc.c: Update all dictionary references to multidictionary.
7485
7486 2019-01-10  Keith Seitz  <keiths@redhat.com>
7487
7488         PR gdb/23712
7489         PR symtab/23010
7490         * dictionary.c: Include unordered_map.
7491         (pending_to_vector): New function.
7492         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7493         Rewrite the non-"_1" functions to take vector instead
7494         of linked list.
7495         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7496         "new" _1 versions of the same name.
7497         (multidictionary): Define.
7498         (std::hash<enum language): New definition.
7499         (collate_pending_symbols_by_language, mdict_create_hashed)
7500         (mdict_create_hashed_expandable, mdict_create_linear)
7501         (mdict_create_linear_expandable, mdict_free)
7502         (find_language_dictionary, create_new_language_dictionary)
7503         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7504         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7505         (mdict_size, mdict_empty): New functions.
7506         * dictionary.h (mdict_iterator): Define.
7507
7508 2019-01-10  Pedro Alves  <palves@redhat.com>
7509
7510         * breakpoint.c (read_uploaded_action)
7511         (create_tracepoint_from_upload): Adjust to use
7512         gdb::unique_xmalloc_ptr.
7513         * ctf.c (ctf_write_uploaded_tp):
7514         (SET_ARRAY_FIELD): Use emplace_back.
7515         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7516         * tracefile-tfile.c (tfile_write_uploaded_tp):
7517         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7518         gdb::unique_xmalloc_ptr.
7519         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7520         at_string, cond_string, cmd_strings>: Replace char pointers
7521         with gdb::unique_xmalloc_ptr.
7522
7523 2019-01-10  Pedro Alves  <palves@redhat.com>
7524
7525         * solib-target.c (library_list_start_library): Don't xstrdup name.
7526
7527 2019-01-10  Pedro Alves  <palves@redhat.com>
7528
7529         * mdebugread.c (parse_partial_symbols): Use
7530         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7531
7532 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7533
7534         * linux-fork.c (scoped_switch_fork_info)
7535         <~scoped_switch_fork_info>: Fix incorrect variable name.
7536
7537 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * linux-fork.c (scoped_switch_fork_info)
7540         <scoped_switch_fork_info>: Make explicit.
7541         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7542
7543 2019-01-10  Tom Tromey  <tom@tromey.com>
7544
7545         * objfiles.h (objfile::reset_psymtabs): Update.
7546         * objfiles.c (objfile::objfile): Update.
7547         * psymtab.h (psymtab_storage::obstack): Update.
7548         (psymtab_storage::m_obstack): Use gdb::optional.
7549         (class psymtab_storage): Update comment.  Remove objfile
7550         parameter.
7551         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7552
7553 2019-01-10  Tom Tromey  <tom@tromey.com>
7554
7555         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7556         <free_psymtabs>: Now private.
7557         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7558         (allocate_psymtab): Use new method.
7559
7560 2019-01-10  Tom Tromey  <tom@tromey.com>
7561
7562         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7563         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7564         * mdebugread.c (parse_partial_symbols): Use
7565         allocate_dependencies.
7566         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7567         allocate_dependencies.
7568         (process_psymtab_comp_unit_reader)
7569         (build_type_psymtab_dependencies): Likewise.
7570         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7571
7572 2019-01-10  Tom Tromey  <tom@tromey.com>
7573
7574         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7575         PSYMBOL_SET_LANGUAGE.
7576         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7577
7578 2019-01-10  Tom Tromey  <tom@tromey.com>
7579
7580         * psymtab.h (psymtab_storage::obstack): New method.
7581         <m_obstack>: Rename from obstack; now private.
7582         * psymtab.c (psymtab_storage): Update.
7583         * dwarf2read.c (create_addrmap_from_index)
7584         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7585         Update.
7586
7587 2019-01-10  Tom Tromey  <tom@tromey.com>
7588
7589         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7590         * objfiles.h (objfile::reset_psymtabs): New method.
7591
7592 2019-01-10  Tom Tromey  <tom@tromey.com>
7593
7594         * symmisc.c (print_symbol_bcache_statistics): Update.
7595         (print_objfile_statistics): Update.
7596         * symfile.c (reread_symbols): Update.
7597         * psymtab.h (class psymtab_storage): New.
7598         * psymtab.c (psymtab_storage): New constructor.
7599         (~psymtab_storage): New destructor.
7600         (require_partial_symbols): Update.
7601         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7602         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7603         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7604         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7605         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7606         (start_psymtab_common, end_psymtab_common)
7607         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7608         (allocate_psymtab): Update.
7609         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7610         Update.
7611         (dump_psymtab_addrmap, maintenance_print_psymbols)
7612         (maintenance_check_psymtabs): Update.
7613         (class objfile_psymtabs): Move to objfiles.h.
7614         * psympriv.h (discard_psymtab): Now inline.
7615         (psymtab_discarder::psymtab_discarder): Update.
7616         (psymtab_discarder::~psymtab_discarder): Update.
7617         (ALL_OBJFILE_PSYMTABS): Rewrite.
7618         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7619         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7620         Remove fields.
7621         <partial_symtabs>: New field.
7622         (class objfile_psymtabs): Move from psymtab.h.  Update.
7623         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7624         psymbol_cache.
7625         (objfile::~objfile): Don't destroy psymbol_cache.
7626         * mdebugread.c (parse_partial_symbols): Update.
7627         * dwarf2read.c (create_addrmap_from_index)
7628         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7629         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7630         (add_partial_subprogram, dwarf2_ranges_read): Update.
7631         * dwarf-index-write.c (write_address_map)
7632         (write_one_signatured_type, recursively_write_psymbols)
7633         (class debug_names, class debug_names, write_psymtabs_to_index):
7634         Update.
7635
7636 2019-01-10  Tom Tromey  <tom@tromey.com>
7637
7638         * symtab.h (SYMBOL_SET_NAMES): Update.
7639         (symbol_set_names): Update.
7640         (MSYMBOL_SET_NAMES): Update.
7641         * symtab.c (symbol_set_names): Change argument to be an
7642         objfile_per_bfd_storage.
7643         * psymtab.c (add_psymbol_to_bcache): Update.
7644         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7645
7646 2019-01-10  Tom Tromey  <tom@tromey.com>
7647
7648         * symtab.c (create_demangled_names_hash): Change argument to be an
7649         objfile_per_bfd_storage.
7650         (symbol_set_names): Update.
7651
7652 2019-01-10  Tom Tromey  <tom@tromey.com>
7653
7654         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7655         init_psymbol_list.
7656         * psymtab.c (init_psymbol_list): Do nothing if already called.
7657         * psympriv.h (init_psymbol_list): Add comment.
7658         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7659         init_psymbol_list.
7660         * dbxread.c (dbx_symfile_read): Unconditionally call
7661         init_psymbol_list.
7662
7663 2019-01-10  Tom Tromey  <tom@tromey.com>
7664
7665         * xcoffread.c (scan_xcoff_symtab): Update.
7666         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7667         "where".
7668         * mdebugread.c (parse_partial_symbols)
7669         (handle_psymbol_enumerators): Update.
7670         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7671         * dbxread.c (read_dbx_symtab): Update.
7672         * psympriv.h (psymbol_placement): New enum.
7673         (add_psymbol_to_list): Update.
7674
7675 2019-01-10  Tom Tromey  <tom@tromey.com>
7676
7677         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7678         static_psymbols parameters.
7679         (scan_xcoff_symtab): Update.
7680         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7681         static_psymbols parameters.
7682         * psympriv.h (start_psymtab_common): Update.
7683         * mdebugread.c (parse_partial_symbols): Update.
7684         * dwarf2read.c (create_partial_symtab): Update.
7685         * dbxread.c (read_dbx_symtab): Update.
7686         (start_psymtab): Remove global_psymbols and static_psymbols
7687         parameters.
7688
7689 2019-01-10  Tom Tromey  <tom@tromey.com>
7690
7691         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7692         * psymtab.c (allocate_psymtab): Add comment.
7693         * psympriv.h (allocate_psymtab): Add comment.
7694         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7695         initializations.
7696         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7697
7698 2019-01-10  Tom Tromey  <tom@tromey.com>
7699
7700         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7701         Don't declare.
7702         * mipsread.c: Include mdebugread.h.
7703         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7704         Declare.
7705         * elfread.c: Include mdebugread.h.
7706
7707 2019-01-09  Tom Tromey  <tom@tromey.com>
7708
7709         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7710         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7711         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7712         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7713         (psym_lookup_symbol, psym_find_last_source_symtab)
7714         (psym_forget_cached_source_info, psym_print_stats)
7715         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7716         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7717         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7718         (psym_find_compunit_symtab_by_address)
7719         (maintenance_print_psymbols, maintenance_info_psymtabs)
7720         (maintenance_check_psymtabs): Use ranged for.
7721         * psymtab.h (class objfile_psymtabs): New.
7722         (require_partial_symbols): Return objfile_psymtabs.
7723         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7724
7725 2019-01-09  Tom Tromey  <tom@tromey.com>
7726
7727         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7728         (find_pc_mapped_section, list_overlays_command)
7729         (map_overlay_command, unmap_overlay_command)
7730         (simple_overlay_update): Use all_objfiles.
7731         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7732         * printcmd.c (info_symbol_command): Use all_objfiles.
7733         * objfiles.h (ALL_OBJSECTIONS): Remove.
7734         * maint.c (maintenance_translate_address): Use all_objfiles.
7735         * gcore.c (gcore_create_callback): Use all_objfiles.
7736         (objfile_find_memory_regions): Likewise.
7737
7738 2019-01-09  Tom Tromey  <tom@tromey.com>
7739
7740         * symtab.c (find_line_symtab, info_sources_command)
7741         (make_source_files_completion_list): Use objfile_compunits.
7742         * source.c (select_source_symtab): Use objfile_compunits.
7743         * objfiles.h (struct objfile): Update comment.
7744         (ALL_OBJFILES): Remove.
7745         (ALL_FILETABS): Remove.
7746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7747         objfile_compunits.
7748
7749 2019-01-09  Tom Tromey  <tom@tromey.com>
7750
7751         * symmisc.c (print_objfile_statistics, dump_objfile)
7752         (maintenance_print_symbols): Use compunit_filetabs.
7753         * source.c (forget_cached_source_info_for_objfile): Use
7754         compunit_filetabs.
7755         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7756         (ALL_FILETABS): Use compunit_filetabs.
7757         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7758         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7759
7760 2019-01-09  Tom Tromey  <tom@tromey.com>
7761
7762         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7763         (compunit_filetabs): New.
7764         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7765         compunit_filetabs.
7766         (info_sources_command, make_source_files_completion_list): Remove
7767         declaration.
7768         * symmisc.c (print_objfile_statistics, dump_objfile)
7769         (maintenance_print_symbols): Remove declaration.
7770         (maintenance_info_symtabs): Use compunit_filetabs.
7771         (maintenance_info_line_tables): Likewise.
7772         * source.c (select_source_symtab): Change local variable name.
7773         (forget_cached_source_info_for_objfile): Remove declaration.
7774         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7775         * objfiles.c (objfile_relocate1): Remove declaration.
7776         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7777         declaration.
7778         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7779         * coffread.c (coff_symtab_read): Remove declaration.
7780         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7781         compunit_filetabs.
7782
7783 2019-01-09  Tom Tromey  <tom@tromey.com>
7784
7785         * symtab.c (lookup_objfile_from_block)
7786         (find_pc_sect_compunit_symtab, search_symbols)
7787         (default_collect_symbol_completion_matches_break_on): Use
7788         objfile_compunits.
7789         * objfiles.h (ALL_COMPUNITS): Remove.
7790         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7791         * cp-support.c (add_symbol_overload_list_qualified): Use
7792         objfile_compunits.
7793         * ada-lang.c (ada_collect_symbol_completion_matches)
7794         (ada_add_global_exceptions): Use objfile_compunits.
7795
7796 2019-01-09  Tom Tromey  <tom@tromey.com>
7797
7798         * source.c (select_source_symtab)
7799         (forget_cached_source_info_for_objfile): Remove declaration.
7800         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7801         declaration.
7802         * maint.c (count_symtabs_and_blocks): Remove declaration.
7803         * cp-support.c (add_symbol_overload_list_qualified): Remove
7804         declaration.
7805         * coffread.c (coff_symtab_read): Remove declaration.
7806         * symtab.c (lookup_symbol_in_objfile_symtabs)
7807         (basic_lookup_transparent_type_1): Use objfile_compunits.
7808         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7809         (info_sources_command, search_symbols)
7810         (default_collect_symbol_completion_matches_break_on)
7811         (make_source_files_completion_list): Remove declaration.
7812         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7813         (ada_collect_symbol_completion_matches)
7814         (ada_add_global_exceptions): Remove declaration.
7815         * linespec.c (iterate_over_all_matching_symtabs): Use
7816         objfile_compunits.
7817         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7818         (class objfile_compunits): New.
7819         (ALL_COMPUNITS): Use objfile_compunits.
7820         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7821         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7822         objfile_compunits.
7823         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7824
7825 2019-01-09  Tom Tromey  <tom@tromey.com>
7826
7827         * symtab.c (search_symbols)
7828         (default_collect_symbol_completion_matches_break_on): Use
7829         objfile_msymbols.
7830         * ada-lang.c (ada_lookup_simple_minsym)
7831         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7832         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7833         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7834         objfile_msymbols.
7835         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7836         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7837         * objc-lang.c (find_methods): Use objfile_msymbols.
7838         (info_selectors_command, info_classes_command): Likewise.
7839         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7840         * objfiles.h (class objfile_msymbols): New.
7841         (ALL_OBJFILE_MSYMBOLS): Remove.
7842         (ALL_MSYMBOLS): Remove.
7843
7844 2019-01-09  Tom Tromey  <tom@tromey.com>
7845
7846         * common/next-iterator.h (next_adapter): Add Iterator template
7847         parameter.
7848         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7849         (class all_objfiles_safe): New.
7850         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7851         * objfiles.c (put_objfile_before): Update comment.
7852         (add_separate_debug_objfile): Likewise.
7853         (free_all_objfiles): Use all_objfiles_safe.
7854         (objfile_purge_solibs): Likewise.
7855
7856 2019-01-09  Tom Tromey  <tom@tromey.com>
7857
7858         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7859         (expand_symtab_containing_pc, lookup_static_symbol)
7860         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7861         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7862         all_objfiles.
7863         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7864         * breakpoint.c (create_overlay_event_breakpoint)
7865         (create_longjmp_master_breakpoint)
7866         (create_std_terminate_master_breakpoint)
7867         (create_exception_master_breakpoint): Use all_objfiles.
7868         * linux-thread-db.c (try_thread_db_load_from_pdir)
7869         (has_libpthread): Use all_objfiles.
7870         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7871         * linespec.c (iterate_over_all_matching_symtabs)
7872         (search_minsyms_for_name): Use all_objfiles.
7873         * maint.c (maintenance_info_sections): Use all_objfiles.
7874         * main.c (captured_main_1): Use all_objfiles.
7875         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7876         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7877         * guile/scm-pretty-print.c
7878         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7879         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7880         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7881         (maintenance_print_msymbols): Use all_objfiles.
7882         * source.c (select_source_symtab): Use all_objfiles.
7883         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7884         * symfile.c (remove_symbol_file_command)
7885         (expand_symtabs_matching, map_symbol_filenames): Use
7886         all_objfiles.
7887         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7888         all_objfiles.
7889         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7890         * objc-lang.c (find_methods): Use all_objfiles.
7891         * objfiles.c (have_partial_symbols, have_full_symbols)
7892         (have_minimal_symbols, qsort_cmp)
7893         (default_iterate_over_objfiles_in_search_order): Use
7894         all_objfiles.
7895         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7896         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7897         (maintenance_check_psymtabs): Use all_objfiles.
7898         (ALL_PSYMTABS): Remove.
7899         * compile/compile-object-run.c (do_module_cleanup): Use
7900         all_objfiles.
7901         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7902         * cp-support.c (add_symbol_overload_list_qualified): Use
7903         all_objfiles.
7904         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7905         Use all_objfiles.
7906         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7907         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7908         all_objfiles.
7909         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7910         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7911         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7912         Uses all_objfiles.
7913         * solib.c (solib_read_symbols): Use all_objfiles
7914
7915 2019-01-09  Tom Tromey  <tom@tromey.com>
7916
7917         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7918         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7919         all_objfiles.
7920         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7921         * symmisc.c (print_symbol_bcache_statistics)
7922         (print_objfile_statistics, maintenance_print_objfiles)
7923         (maintenance_info_symtabs, maintenance_check_symtabs)
7924         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7925         all_objfiles.
7926         * source.c (forget_cached_source_info): Use all_objfiles.
7927         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7928         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7929         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7930         * objfiles.c (update_section_map): Use all_objfiles.
7931         (shared_objfile_contains_address_p): Likewise.
7932         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7933         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7934
7935 2019-01-09  Tom Tromey  <tom@tromey.com>
7936
7937         * common/next-iterator.h: New file.
7938         * objfiles.h (class all_objfiles): New.
7939         (struct objfile_iterator): New.
7940
7941 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7942
7943         * NEWS: Move the description of the changed "frame", "select-frame",
7944          and "info frame" commands to the Changed commands section.
7945
7946 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7947
7948         * gdbtypes.c (check_stub_method_group): Remove handling of old
7949         mangling schemes.
7950         * linespec.c (find_methods): Likewise.
7951         * stabsread.c (read_member_functions): Likewise.
7952         * valops.c (search_struct_method): Likewise.
7953         (value_struct_elt_for_reference): Likewise.
7954         * NEWS: Mention this change.
7955
7956 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7957
7958         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7959         print_source_lines.
7960         * source.c (print_source_lines_base): Update line number check.
7961         (print_source_lines): New function.
7962         (source_lines_range::source_lines_range): New function.
7963         * source.h (class source_lines_range): New class.
7964         (print_source_lines): New declaration.
7965
7966 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7967
7968         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7969
7970 2019-01-08  Tom Tromey  <tom@tromey.com>
7971             Simon Marchi  <simon.marchi@ericsson.com>
7972
7973         PR gdb/24060
7974         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7975         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7976         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7977         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7978         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7979         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7980
7981 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * source.c (select_source_symtab): Move header comment to
7984         declaration in source.h.
7985         (forget_cached_source_info_for_objfile): Likewise.
7986         (forget_cached_source_info): Likewise.
7987         (identify_source_line): Likewise.
7988         * source.h (identify_source_line): Move declaration from symtab.h
7989         and add comment from source.c
7990         (print_source_lines): Likewise.
7991         (forget_cached_source_info_for_objfile): Likewise.
7992         (forget_cached_source_info): Likewise.
7993         (select_source_symtab): Likewise.
7994         (enum print_source_lines_flag): Move definition from symtab.h.
7995         * symtab.h (identify_source_line): Move declaration to source.h.
7996         (print_source_lines): Likewise.
7997         (forget_cached_source_info_for_objfile): Likewise.
7998         (forget_cached_source_info): Likewise.
7999         (select_source_symtab): Likewise.
8000         (enum print_source_lines_flag): Move definition to source.h.
8001         * tui/tui-hooks.c: Add 'source.h' include.
8002
8003 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8004
8005         * source.c (print_source_lines_base): Handle requests to print
8006         reverse line number sequences, and guard against empty lines
8007         string.
8008
8009 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8010
8011         * source.c (print_source_lines_base): Fix skip of '\r' if next
8012         character is '\n'.
8013
8014 2019-01-06  Tom Tromey  <tom@tromey.com>
8015
8016         * c-exp.y (struct c_parse_state) <macro_original_text,
8017         expansion_obstack>: New member.
8018         (macro_original_text, expansion_obstack): Remove globals.
8019         (scan_macro_expansion, scanning_macro_expansion)
8020         (finished_macro_expansion): Update.
8021         (scan_macro_cleanup): Remove.
8022         (yylex, c_parse): Update.
8023
8024 2019-01-06  Tom Tromey  <tom@tromey.com>
8025
8026         * c-exp.y (struct c_parse_state) <strings>: New member.
8027         (operator_stoken): Update.
8028
8029 2019-01-06  Tom Tromey  <tom@tromey.com>
8030
8031         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8032         (union type_stack_elt) <typelist_val>: Now a pointer to
8033         std::vector.
8034         (type_stack_cleanup): Don't declare.
8035         (push_typelist): Update.
8036         * parse.c (pop_typelist): Return a std::vector.
8037         (push_typelist): Take a std::vector.
8038         (follow_types): Update.  Do not free args.
8039         (type_stack_cleanup): Remove.
8040         * c-exp.y (struct c_parse_state): New.
8041         (cpstate): New global.
8042         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8043         (nonempty_typelist): Update.
8044         (func_mod): Create a new vector.
8045         (c_parse): Create a c_parse_state.
8046         (check_parameter_typelist): Do not delete params.
8047         (function_method): Update.  Do not delete type_list.
8048
8049 2019-01-06  Tom Tromey  <tom@tromey.com>
8050
8051         PR gdb/28155:
8052         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8053         check_typedef.
8054         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8055         (print_return_value): Likewise.
8056
8057 2019-01-05  Tom Tromey  <tom@tromey.com>
8058
8059         * contrib/cleanup_check.py: Remove.
8060         * contrib/gcc-with-excheck: Remove.
8061         * contrib/exsummary.py: Remove.
8062         * contrib/excheck.py: Remove.
8063
8064 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8065
8066         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8067         NULL. Initialize tpprev to NULL instead of assigning it
8068         to NULL on the next statement.
8069         * windows-nat.c (windows_delete_thread): Remove check for
8070         main_thread_id before printing thread exit notifications.
8071         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8072         Remove thread ID check against main_thread_id.
8073         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8074         windows_delete_thread.
8075         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8076
8077 2019-01-04  Tom Tromey  <tom@tromey.com>
8078
8079         * compile/compile.c (_initialize_compile): Use upper case for
8080         metasyntactic variables.
8081         * symmisc.c (_initialize_symmisc): Use upper case for
8082         metasyntactic variables.
8083         * psymtab.c (_initialize_psymtab): Use upper case for
8084         metasyntactic variables.
8085         * demangle.c (demangle_command): Use upper case for metasyntactic
8086         variables.
8087         (_initialize_demangler): Likewise.
8088         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8089         variables.
8090
8091 2019-01-03  Tom Tromey  <tom@tromey.com>
8092
8093         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8094
8095 2019-01-03  Tom Tromey  <tom@tromey.com>
8096
8097         * python/py-symtab.c (salpy_str): Update.
8098         (struct salpy_sal_object) <symtab>: Now a PyObject.
8099         (salpy_dealloc): Update.
8100         (del_objfile_sal): Use gdbpy_ref.
8101
8102 2019-01-03  Tom Tromey  <tom@tromey.com>
8103
8104         * python/py-type.c (convert_field): Use new_reference.  Return
8105         gdbpy_ref.
8106         (make_fielditem): Return gdbpy_ref.
8107         (typy_fields): Update.
8108         (typy_getitem): Update.
8109         (field_name): Return gdbpy_ref.  Use new_reference.
8110         (typy_iterator_iternext): Update.
8111
8112 2019-01-03  Tom Tromey  <tom@tromey.com>
8113
8114         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8115
8116 2019-01-03  Tom Tromey  <tom@tromey.com>
8117
8118         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8119         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8120         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8121         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8122         (pspy_set_type_printers): Likewise.
8123         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8124         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8125         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8126         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8127         (objfpy_set_type_printers): Likewise.
8128
8129 2019-01-03  Tom Tromey  <tom@tromey.com>
8130
8131         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8132         (gdbpy_print_stack): Use gdbpy_err_fetch.
8133         * python/python-internal.h (class gdbpy_err_fetch): New class.
8134         (class gdbpy_enter) <m_error_type, m_error_value,
8135         m_error_traceback>: Remove.
8136         <m_error>: New member.
8137         (gdbpy_exception_to_string): Don't declare.
8138         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8139         * python/py-value.c (convert_value_from_python): Use
8140         gdbpy_err_fetch.
8141         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8142         gdbpy_exception_to_string.
8143         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8144         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8145         gdbpy_err_fetch.
8146
8147 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8148
8149         * linux-nat.c (delete_lwp_cleanup): Delete.
8150         (struct lwp_deleter): New struct.
8151         (lwp_info_up): New typedef.
8152         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8153         lwp_info_up.
8154
8155 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * linux-fork.c (class scoped_switch_fork_info): New class.
8158         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8159
8160 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8161
8162         * valops.c (find_overload_match): Remove use of null_cleanup, and
8163         calls to do_cleanups.
8164
8165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8166
8167         * compile/compile-cplus-types.c
8168         (compile_cplus_instance::decl_name): Handle changes to
8169         cp_func_name.
8170         * cp-support.c (cp_func_name): Update header comment, update
8171         return type.
8172         * cp-support.h (cp_func_name): Update return type in declaration.
8173         * valops.c (find_overload_match): Move temp_func local to top
8174         level of function and change its type.  Use temp_func to hold and
8175         delete temporary string obtained from cp_func_name.
8176
8177 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8180         gdb::char_vector, remove cleanup, and update uses of `msg`.
8181
8182 2019-01-03  Jim Wilson  <jimw@sifive.com>
8183
8184         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8185
8186 2019-01-02  Tom Tromey  <tom@tromey.com>
8187
8188         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8189         (tdesc_parse_xml): Remove cleanups.
8190         * target-descriptions.h (make_cleanup_free_target_description):
8191         Don't declare.
8192         (target_desc_deleter): New struct.
8193         (target_desc_up): New typedef.
8194         * target-descriptions.c (target_desc_deleter::operator()): Rename
8195         from free_target_description.
8196         (make_cleanup_free_target_description): Remove.
8197
8198 2019-01-02  Tom Tromey  <tom@tromey.com>
8199
8200         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8201         constructor, destructor.
8202         (linespec_parser): Remove typedef.
8203         (~linespec_parser): Rename from linespec_parser_delete.
8204         (linespec_lex_to_end, linespec_complete_label)
8205         (linespec_complete): Update.
8206         (decode_line_full): Remove cleanups.
8207         (decode_line_1): Update.
8208
8209 2019-01-02  Tom Tromey  <tom@tromey.com>
8210
8211         * python/python-internal.h (inferior_to_inferior_object): Change
8212         return type.
8213         * python/py-exitedevent.c (create_exited_event_object): Update.
8214         * python/py-inferior.c (inferior_to_inferior_object): Return
8215         gdbpy_ref.
8216         (python_new_inferior, python_inferior_deleted)
8217         (thread_to_thread_object, delete_thread_object)
8218         (build_inferior_list, gdbpy_selected_inferior): Update.
8219         * python/py-infthread.c (create_thread_object): Update.  Also fail
8220         if inferior_to_inferior_object fails.
8221
8222 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8223
8224         * inferior.h (class inferior) <displaced_step_state>: New field.
8225         * infrun.h (struct displaced_step_state): Move here from
8226         infrun.c.  Initialize fields, add constructor.
8227         <inf>: Remove field.
8228         <reset>: New method.
8229         * infrun.c (struct displaced_step_inferior_state): Move to
8230         infrun.h.
8231         (displaced_step_inferior_states): Remove.
8232         (get_displaced_stepping_state): Adust.
8233         (displaced_step_in_progress_any_inferior): Adjust.
8234         (displaced_step_in_progress_thread): Adjust.
8235         (displaced_step_in_progress): Adjust.
8236         (add_displaced_stepping_state): Remove.
8237         (get_displaced_step_closure_by_addr): Adjust.
8238         (remove_displaced_stepping_state): Remove.
8239         (infrun_inferior_exit): Call displaced_step_state.reset.
8240         (use_displaced_stepping): Don't check for NULL.
8241         (displaced_step_prepare_throw): Call
8242         get_displaced_stepping_state.
8243         (displaced_step_fixup): Don't check for NULL.
8244         (prepare_for_detach): Don't check for NULL.
8245
8246 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8247
8248         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8249          in case of call that did not complete.
8250
8251 2019-01-02  Andrey Utkin  <autkin@undo.io>
8252
8253         * symfile.c (find_separate_debug_file): Fix search of debug files for
8254         remote debuggee.
8255
8256 2019-01-02  Tom Tromey  <tom@tromey.com>
8257
8258         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8259         indentation.
8260         * python/py-frame.c (frapy_older): Remove cast.
8261         (frapy_newer): Likewise.
8262         * python/py-breakpoint.c (local_setattro): Remove cast.
8263         * python/py-arch.c (archpy_name): Remove local variable.
8264         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8265
8266 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8267
8268         * unittests/basic_string_view/element_access/char/empty.cc:
8269         Fix year range in copyright header.
8270
8271 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8274         Delete.
8275         <operator==>: Update with for removed field.
8276         <hash>: Likewise.
8277         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8278         <isa_features>: ...this.
8279         <abi_features>: New field.
8280         (riscv_isa_flen): Update comment.
8281         (riscv_abi_xlen): New declaration.
8282         (riscv_abi_flen): New declaration.
8283         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8284         isa_features.
8285         (riscv_abi_xlen): New function.
8286         (riscv_isa_flen): Update to get answer from isa_features.
8287         (riscv_abi_flen): New function.
8288         (riscv_has_fp_abi): Update to get answer from abi_features.
8289         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8290         xlen and flen.
8291         (riscv_call_info) <xlen, flen>: Update comment.
8292         (riscv_call_arg_struct): Remove invalid assertions
8293         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8294         is removed.
8295         (riscv_gdbarch_init): Gather isa features and abi features
8296         separately, ensure both match on the gdbarch when reusing an old
8297         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8298         a target with 64-bit float hardware.
8299
8300 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8301
8302         * source.c (search_command_helper): Stop reverse search
8303         when line 1 has been searched.
8304
8305 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8306
8307         * record-full.c (record_full_base_target::close): Rewrite
8308         record_full_core_buf_list free logic.
8309
8310 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8311
8312         * break-catch-syscall.c (print_one_catch_syscall): xfree
8313         the last text.
8314
8315 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8316
8317         * top.c (print_gdb_version): Update Copyright year in version
8318         message.
8319
8320 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8321
8322         Update copyright year range in all GDB files.
8323
8324 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8325
8326         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8327
8328 For older changes see ChangeLog-2018.
8329 \f
8330 Local Variables:
8331 mode: change-log
8332 left-margin: 8
8333 fill-column: 74
8334 version-control: never
8335 coding: utf-8
8336 End:
8337