gdb/ChangeLog

   1 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * NEWS: Mention new --with-system-gdbinit-dir option.
   4         * config.in: Regenerate.
   5         * configure: Regenerate.
   6         * configure.ac: Add new option --with-system-gdbinit-dir.
   7         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
   8         for a ".gdb" suffix.
   9         * main.c (get_init_files): Change system_gdbinit argument to
  10         a vector and return the files in SYSTEM_GDBINIT_DIR in
  11         addition to SYSTEM_GDBINIT.
  12         (captured_main_1): Update.
  13         (print_gdb_help): Update.
  14         * top.c (print_gdb_configuration): Also print the value of
  15         SYSTEM_GDBINIT_DIR.
  16
  17 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * gdbsupport/common-utils.h (startswith): Add an overloaded version
  20         that takes gdb::string_view arguments.
  21
  22 2019-10-26  Tom de Vries  <tdevries@suse.de>
  23
  24         * aarch64-linux-tdep.c: Fix typos in comments.
  25         * aarch64-tdep.c: Same.
  26         * ada-lang.c: Same.
  27         * amd64-nat.c: Same.
  28         * arc-tdep.c: Same.
  29         * arch/aarch64-insn.c: Same.
  30         * block.c: Same.
  31         * breakpoint.h: Same.
  32         * btrace.h: Same.
  33         * c-varobj.c: Same.
  34         * cli/cli-decode.c: Same.
  35         * cli/cli-script.c: Same.
  36         * cli/cli-utils.h: Same.
  37         * coff-pe-read.c: Same.
  38         * coffread.c: Same.
  39         * compile/compile-cplus-symbols.c: Same.
  40         * compile/compile-object-run.c: Same.
  41         * completer.c: Same.
  42         * corelow.c: Same.
  43         * cp-support.c: Same.
  44         * demangle.c: Same.
  45         * dwarf-index-write.c: Same.
  46         * dwarf2-frame.c: Same.
  47         * dwarf2-frame.h: Same.
  48         * eval.c: Same.
  49         * frame-base.h: Same.
  50         * frame.h: Same.
  51         * gdbcmd.h: Same.
  52         * gdbtypes.h: Same.
  53         * gnu-nat.c: Same.
  54         * guile/scm-objfile.c: Same.
  55         * i386-tdep.c: Same.
  56         * i386-tdep.h: Same.
  57         * infcall.c: Same.
  58         * infcall.h: Same.
  59         * linux-nat.c: Same.
  60         * m68k-tdep.c: Same.
  61         * macroexp.c: Same.
  62         * memattr.c: Same.
  63         * mi/mi-cmd-disas.c: Same.
  64         * mi/mi-getopt.h: Same.
  65         * mi/mi-main.c: Same.
  66         * minsyms.c: Same.
  67         * nat/aarch64-sve-linux-sigcontext.h: Same.
  68         * objfiles.h: Same.
  69         * ppc-linux-nat.c: Same.
  70         * ppc-linux-tdep.c: Same.
  71         * ppc-tdep.h: Same.
  72         * progspace.h: Same.
  73         * prologue-value.h: Same.
  74         * python/py-evtregistry.c: Same.
  75         * python/py-instruction.h: Same.
  76         * record-btrace.c: Same.
  77         * record-full.c: Same.
  78         * remote.c: Same.
  79         * rs6000-tdep.c: Same.
  80         * ser-tcp.c: Same.
  81         * sol-thread.c: Same.
  82         * sparc-sol2-tdep.c: Same.
  83         * sparc64-tdep.c: Same.
  84         * stabsread.c: Same.
  85         * symfile.c: Same.
  86         * symtab.h: Same.
  87         * target.c: Same.
  88         * tracepoint.c: Same.
  89         * tui/tui-data.h: Same.
  90         * tui/tui-io.c: Same.
  91         * tui/tui-win.c: Same.
  92         * tui/tui.c: Same.
  93         * unittests/rsp-low-selftests.c: Same.
  94         * user-regs.h: Same.
  95         * utils.c: Same.
  96         * utils.h: Same.
  97         * valarith.c: Same.
  98         * valops.c: Same.
  99         * valprint.c: Same.
 100         * valprint.h: Same.
 101         * value.c: Same.
 102         * value.h: Same.
 103         * varobj.c: Same.
 104         * x86-nat.h: Same.
 105         * xtensa-tdep.c: Same.
 106
 107 2019-10-25  Ali Tamur <tamur@google.com>
 108
 109         * charset.c (find_charset_names): Reflect API change.
 110
 111 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 112
 113         * symtab.c (struct demangled_name_entry): Change demangled name
 114         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 115         part of the struct anymore.
 116         (symbol_set_names): No longer obstack allocate + copy the demangled
 117         name, just store the allocated name from bfd.
 118
 119 2019-10-25  Tom Tromey  <tromey@adacore.com>
 120
 121         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 122         (bsearch_cie_cmp, add_cie): Remove.
 123         (find_cie): Reimplement.
 124         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 125         (dwarf2_build_frame_info): Update.
 126
 127 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 128
 129         PR gdb/25126
 130         * symfile.c (reread_symbols): Call forget_cached_source_info to
 131         clear the stale source cache.
 132
 133 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 134
 135         * configure: Regenerate.
 136         * configure.ac: Remove code that sets python_has_threads.
 137
 138 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 139
 140         * config.in: Regenerate.
 141         * configure: Regenerate.
 142         * configure.ac: Remove the code that uses sed to get the python
 143         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 144
 145 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 146
 147         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 148         error paths.
 149
 150 2019-10-23  Tom Tromey  <tom@tromey.com>
 151
 152         * arc-tdep.c: Remove ".." from include.
 153         * frv-tdep.c: Remove ".." from include.
 154         * lm32-tdep.c: Remove ".." from include.
 155         * microblaze-tdep.c: Remove ".." from include.
 156         * or1k-tdep.h: Remove ".." from include.
 157         * s12z-tdep.c: Remove ".." from include.
 158         * Makefile.in (OPCODES_CFLAGS): Add comment.
 159         (TOP_CFLAGS): New variable.
 160         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 161
 162 2019-10-23  Tom Tromey  <tom@tromey.com>
 163
 164         * Makefile.in (READLINE_DIR): Update.
 165
 166 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 167
 168         * infcall.c (call_function_by_hand_dummy): Fix the function
 169         comment.  And extract out a code section into...
 170         (reserve_stack_space): ...this new function.
 171
 172 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 173
 174         * infcall.c (value_arg_coerce): Remove an unused parameter.
 175         (call_function_by_hand_dummy): Update the call to
 176         'value_arg_coerce'.
 177
 178 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 179
 180         * infcall.c (call_function_by_hand_dummy): Refactor.
 181
 182 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 183
 184         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 185
 186 2019-10-23  Tom Tromey  <tom@tromey.com>
 187
 188         * configure: Rebuild.
 189         * configure.ac: Don't check for sigprocmask.
 190         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 191
 192 2019-10-23  Tom Tromey  <tom@tromey.com>
 193
 194         * configure: Rebuild.
 195         * acinclude.m4: Use m4_include, not sinclude.
 196
 197 2019-10-23  Tom de Vries  <tdevries@suse.de>
 198
 199         PR breakpoints/24687
 200         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 201
 202 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 203
 204         * symtab.c (struct demangled_name_entry) <language>: Change from
 205         bitfield to regular variable.
 206
 207 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 208
 209         * symtab.c (struct demangled_name_entry): Add a constructor.
 210         (free_demangled_name_entry): New function to call the destructor
 211         for demangled_name_entry.
 212         (create_demangled_names_hash): Pass free_demangled_name_entry to
 213         htab_create_alloc.
 214         (symbol_set_names): Call placement new for demangled_name_entry.
 215         * utils.c: No longer include xxhash.h here, now that fast_hash
 216         is inlined in the header.
 217         * utils.h: Instead, include it here.
 218
 219 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 220
 221         * Makefile.in: Link with libxxhash.
 222         * config.in: Regenerate.
 223         * configure: Regenerate.
 224         * configure.ac: Search for libxxhash.
 225         * utils.c (fast_hash): Use xxhash if present.
 226
 227 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 228
 229         * utils.h (fast_hash): New function.
 230         * symtab.c (hash_demangled_name_entry): Call new function
 231         fast_hash.
 232
 233 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 234
 235         * symtab.c (struct demangled_name_entry): Change type of mangled
 236         to gdb::string_view. Also adds a constructor that takes the
 237         mangled name.
 238         (hash_demangled_name_entry): Update.
 239         (eq_demangled_name_entry): Update.
 240         (free_demangled_name_entry): New function to call the destructor
 241         now that this is not a POD anymore.
 242         (create_demangled_names_hash): Pass free_demangled_name_entry to
 243         htab_create_alloc.
 244         (symbol_set_names): Update.
 245
 246 2019-10-21  Ali Tamur  <tamu@google.com>
 247
 248         * dwarf2read.c (dir_index): Change type.
 249         (file_name_index): Likewise.
 250         (line_header::include_dir_at): Change comment and implementation on
 251         whether it is DWARF 5.
 252         (line_header::is_valid_file_index): New function.
 253         (line_header::file_name_at): Change comment and implementation on
 254         whether it is DWARF 5.
 255         (line_header::file_names): Change to private field renamed as
 256         m_file_names and introduce a new accessor method.
 257         (line_header::file_names_size): New method.
 258         (line_header::include_dirs): Change to private field and rename as
 259         m_include_dirs.
 260         (dw2_get_file_names_reader): Define local var at a smaller scope and
 261         reflect API change.
 262         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 263         (process_structure_scope): Likewise.
 264         (line_header::add_include_dir): Change message and reflect renaming.
 265         (line_header::add_file_name): Likewise.
 266         (read_formatted_entries): Handle DW_FORM_data16.
 267         (dwarf_decode_line_header): Fix line header length calculation.
 268         (psymtab_include_file_name): Change comment and API.
 269         (lnp_state_machine::m_file): Update comment and reflect type change.
 270         (lnp_state_machine::record_line): Reflect type change.
 271         (dwarf_decode_lines): Reflect API change.
 272         (file_file_name): Likewise.
 273         (file_full_name): Likewise.
 274
 275 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 278
 279 2019-10-21  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 282
 283 2019-10-21  Tom Tromey  <tom@tromey.com>
 284
 285         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 286         NM_H.   Use AC_CONFIG_LINKS.
 287         * configure: Rebuild.
 288         * Makefile.in (NM_H): New variable.
 289         (generated_files): Add NM_H.  Remove gcore.
 290         (nm.h, stamp-nmh): New targets.
 291
 292 2019-10-20  Tom Tromey  <tom@tromey.com>
 293
 294         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 295         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 296         obsolete comment.
 297         (put_objfile_before): Now static.
 298
 299 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 300
 301         * gdbsupport/common-utils.h (startswith): Change return type to
 302         bool.
 303
 304 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 305
 306         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 307         * breakpoint.c (bp_locations_compare): Rename to...
 308         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 309         (update_global_location_list): Use std::sort instead of qsort.
 310         * buildsym.c (compare_line_numbers): Rename to...
 311         (lte_is_less_than): ...this, and change to std::sort semantics.
 312         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 313         instead of qsort.
 314         * disasm.c (compare_lines): Rename to...
 315         (line_is_less_than): ...this, and change to std::sort semantics.
 316         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 317         of qsort.
 318         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 319         (fde_is_less_than): ...this, and change to std::sort semantics.
 320         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 321         * mdebugread.c (compare_blocks):
 322         (block_is_less_than): ...this, and change to std::sort semantics.
 323         (sort_blocks): Call std::sort instead of qsort.
 324         * objfiles.c (qsort_cmp): Rename to...
 325         (sort_cmp): ...this, and change to std::sort semantics.
 326         (update_section_map): Call std::sort instead of qsort.
 327         * remote.c (compare_pnums): Remove.
 328         (map_regcache_remote_table): Call std::sort instead of qsort.
 329         * utils.c (compare_positive_ints): Remove.
 330         * utils.h (compare_positive_ints): Remove.
 331         * xcoffread.c (compare_lte): Remove.
 332         (arrange_linetable): Call std::sort instead of qsort.
 333
 334 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 335
 336         * symfile.c (init_entry_point_info): Fix typo.
 337         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 338
 339 2019-10-18  Tom de Vries  <tdevries@suse.de>
 340
 341         * aarch64-tdep.c: Fix typos in comments.
 342         * ada-lang.c: Same.
 343         * ada-tasks.c: Same.
 344         * alpha-tdep.c: Same.
 345         * alpha-tdep.h: Same.
 346         * amd64-nat.c: Same.
 347         * amd64-windows-tdep.c: Same.
 348         * arc-tdep.c: Same.
 349         * arc-tdep.h: Same.
 350         * arch-utils.c: Same.
 351         * arm-nbsd-tdep.c: Same.
 352         * arm-tdep.c: Same.
 353         * ax-gdb.c: Same.
 354         * blockframe.c: Same.
 355         * btrace.c: Same.
 356         * c-varobj.c: Same.
 357         * coff-pe-read.c: Same.
 358         * coffread.c: Same.
 359         * cris-tdep.c: Same.
 360         * darwin-nat.c: Same.
 361         * dbxread.c: Same.
 362         * dcache.c: Same.
 363         * disasm.c: Same.
 364         * dtrace-probe.c: Same.
 365         * dwarf-index-write.c: Same.
 366         * dwarf2-frame-tailcall.c: Same.
 367         * dwarf2-frame.c: Same.
 368         * dwarf2read.c: Same.
 369         * eval.c: Same.
 370         * exceptions.c: Same.
 371         * fbsd-tdep.c: Same.
 372         * findvar.c: Same.
 373         * frame.c: Same.
 374         * frv-tdep.c: Same.
 375         * gnu-v3-abi.c: Same.
 376         * go32-nat.c: Same.
 377         * h8300-tdep.c: Same.
 378         * hppa-tdep.c: Same.
 379         * i386-linux-tdep.c: Same.
 380         * i386-tdep.c: Same.
 381         * ia64-libunwind-tdep.c: Same.
 382         * ia64-tdep.c: Same.
 383         * infcmd.c: Same.
 384         * infrun.c: Same.
 385         * linespec.c: Same.
 386         * linux-nat.c: Same.
 387         * linux-thread-db.c: Same.
 388         * machoread.c: Same.
 389         * mdebugread.c: Same.
 390         * mep-tdep.c: Same.
 391         * mn10300-tdep.c: Same.
 392         * namespace.c: Same.
 393         * objfiles.c: Same.
 394         * opencl-lang.c: Same.
 395         * or1k-tdep.c: Same.
 396         * osabi.c: Same.
 397         * ppc-linux-nat.c: Same.
 398         * ppc-linux-tdep.c: Same.
 399         * ppc-sysv-tdep.c: Same.
 400         * printcmd.c: Same.
 401         * procfs.c: Same.
 402         * record-btrace.c: Same.
 403         * record-full.c: Same.
 404         * remote-fileio.c: Same.
 405         * remote.c: Same.
 406         * rs6000-tdep.c: Same.
 407         * s12z-tdep.c: Same.
 408         * score-tdep.c: Same.
 409         * ser-base.c: Same.
 410         * ser-go32.c: Same.
 411         * skip.c: Same.
 412         * sol-thread.c: Same.
 413         * solib-svr4.c: Same.
 414         * solib.c: Same.
 415         * source.c: Same.
 416         * sparc-nat.c: Same.
 417         * sparc-sol2-tdep.c: Same.
 418         * sparc-tdep.c: Same.
 419         * sparc64-tdep.c: Same.
 420         * stabsread.c: Same.
 421         * stack.c: Same.
 422         * symfile.c: Same.
 423         * symtab.c: Same.
 424         * target-descriptions.c: Same.
 425         * target-float.c: Same.
 426         * thread.c: Same.
 427         * utils.c: Same.
 428         * valops.c: Same.
 429         * valprint.c: Same.
 430         * value.c: Same.
 431         * varobj.c: Same.
 432         * windows-nat.c: Same.
 433         * xcoffread.c: Same.
 434         * xstormy16-tdep.c: Same.
 435         * xtensa-tdep.c: Same.
 436
 437 2019-10-17  Tom Tromey  <tromey@adacore.com>
 438
 439         * configure: Rebuild.
 440         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 441         in AC_CONFIG_FILES invocation.
 442         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 443         new-style config.status invocation.
 444
 445 2019-10-17  Tom de Vries  <tdevries@suse.de>
 446
 447         * arm-nbsd-nat.c: Fix typos in comments.
 448         * arm-tdep.c: Same.
 449         * darwin-nat-info.c: Same.
 450         * dwarf2read.c: Same.
 451         * elfread.c: Same.
 452         * event-top.c: Same.
 453         * findvar.c: Same.
 454         * gdbtypes.c: Same.
 455         * hppa-tdep.c: Same.
 456         * i386-tdep.c: Same.
 457         * jit.c: Same.
 458         * main.c: Same.
 459         * mdebugread.c: Same.
 460         * moxie-tdep.c: Same.
 461         * nto-procfs.c: Same.
 462         * osabi.c: Same.
 463         * ppc-linux-tdep.c: Same.
 464         * remote.c: Same.
 465         * riscv-tdep.c: Same.
 466         * s390-tdep.c: Same.
 467         * sh-tdep.c: Same.
 468         * sparc-linux-tdep.c: Same.
 469         * sparc-nat.c: Same.
 470         * stack.c: Same.
 471         * target-descriptions.c: Same.
 472         * top.c: Same.
 473         * varobj.c: Same.
 474
 475 2019-10-16  Tom Tromey  <tom@tromey.com>
 476
 477         * objfiles.h (struct objfile) <original_name>: Now const.
 478
 479 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 482         pass on to sigsetjmp's second argument.
 483         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 484
 485 2019-10-16  Keith Seitz  <keiths@redhat.com>
 486
 487         PR gdb/23567
 488         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 489         sections whose size is greater than the file size.
 490
 491 2019-10-16  Jim Wilson  <jimw@sifive.com>
 492
 493         * riscv-tdep.c (riscv_gcc_target_options): New.
 494         (riscv_gnu_triplet_regexp): New.
 495         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 496         set_gdbarch_gnu_triplet_regexp.
 497
 498 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 499
 500         * Makefile.in: Add xml-builtin.h.
 501         * features/feature_to_c.sh: Add an include for xml-builtin.h
 502         to ensure that the compiler checks that the types match.
 503         * xml-builtin.h: New file.
 504         * xml-support.c (fetch_xml_builtin): Add missing const.
 505         * xml-support.h: Remove declaration of xml_builtins.
 506
 507 2019-10-16  Tom de Vries  <tdevries@suse.de>
 508
 509         PR tdep/25096
 510         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 511         (amd64_classify_aggregate): ... here.
 512         (amd64_classify_aggregate_field): Handled fiels of nested structs
 513         recursively.
 514
 515 2019-10-16  Tom de Vries  <tdevries@suse.de>
 516
 517         PR tdep/24104
 518         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 519         that handles 'theclass'.
 520
 521 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 522
 523         * linespec.c (decode_digits_ordinary): Update comment.
 524         * make-target-delegates: No longer need to handle VEC case.
 525         * memrange.c (normalize_mem_ranges): Update comment.
 526         * namespace.c (add_using_directive): Update comment.
 527         * objc-lang.c (uniquify_strings): Update comment.
 528         * ppc-linux-nat.c (struct thread_points): Update comment.
 529         * probe.h (find_probes_in_objfile): Update comment.
 530         * target.h (enum flash_preserve_mode): Update comment.
 531         * varobj.c (varobj_restrict_range): Update comment.
 532         * varobj.h (varobj_list_children): Update comment.
 533
 534 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 535
 536         * Makefile.in: Remove references to vec.h and vec.c.
 537         * aarch64-tdep.c: No longer include vec.h.
 538         * ada-lang.c: Likewise.
 539         * ada-lang.h: Likewise.
 540         * arm-tdep.c: Likewise.
 541         * ax.h: Likewise.
 542         * breakpoint.h: Likewise.
 543         * charset.c: Likewise.
 544         * cp-support.h: Likewise.
 545         * dtrace-probe.c: Likewise.
 546         * dwarf2read.c: Likewise.
 547         * extension.h: Likewise.
 548         * gdb_bfd.c: Likewise.
 549         * gdbsupport/gdb_vecs.h: Likewise.
 550         * gdbsupport/vec.c: Remove.
 551         * gdbsupport/vec.h: Remove.
 552         * gdbthread.h: Likewise.
 553         * guile/scm-type.c: Likewise.
 554         * inline-frame.c: Likewise.
 555         * machoread.c: Likewise.
 556         * memattr.c: Likewise.
 557         * memrange.h: Likewise.
 558         * namespace.h: Likewise.
 559         * nat/linux-btrace.h: Likewise.
 560         * osdata.c: Likewise.
 561         * parser-defs.h: Likewise.
 562         * progspace.h: Likewise.
 563         * python/py-type.c: Likewise.
 564         * record-btrace.c: Likewise.
 565         * rust-exp.y: Likewise.
 566         * solib-target.c: Likewise.
 567         * stap-probe.c: Likewise.
 568         * target-descriptions.c: Likewise.
 569         * target-memory.c: Likewise.
 570         * target.h: Likewise.
 571         * varobj.c: Likewise.
 572         * varobj.h: Likewise.
 573         * xml-support.h: Likewise.
 574
 575 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 578         Update for new std::vector based implementation.
 579         (process_psymtab_comp_unit_reader): Likewise.
 580         (scan_partial_symbols): Likewise.
 581         (recursively_compute_inclusions): Likewise.
 582         (compute_compunit_symtab_includes): Likewise.
 583         (process_imported_unit_die): Likewise.
 584         (queue_and_load_dwo_tu): Likewise.
 585         (follow_die_sig_1): Likewise.
 586         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 587         (typedef dwarf2_per_cu_ptr): Remove.
 588         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 589         function.
 590         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 591         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 592         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 593         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 594         std::vector.
 595
 596 2019-10-15  Tom Tromey  <tromey@adacore.com>
 597
 598         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 599         TID.
 600
 601 2019-10-15  Tom Tromey  <tromey@adacore.com>
 602
 603         * windows-nat.c (windows_nat_target::fetch_registers)
 604         (windows_nat_target::store_registers): Rename "pid" to "tid".
 605
 606 2019-10-15  Tom Tromey  <tromey@adacore.com>
 607
 608         * gdbarch.h, gdbarch.c: Rebuild.
 609         * gdbarch.sh (gcc_target_options): Change return type to
 610         std::string.
 611         * compile/compile.c (get_args): Update.
 612         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 613         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 614         std::string.
 615         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 616         std::string.
 617         * arch-utils.c (default_gcc_target_options): Return std::string.
 618         * arch-utils.h (default_gcc_target_options): Return std::string.
 619         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 620
 621 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 622
 623         * breakpoint.c (breakpoint_chain): Make static.
 624         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 625         of accessing breakpoint_chain.
 626
 627 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 628
 629         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 630         to a gdb::function_view and return value to bool.
 631         * breakpoint.h (iterate_over_breakpoints): Likewise.
 632         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 633         (pop_dummy_frame): Update.
 634         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 635         (gdbscm_breakpoints): Update.
 636         * python/py-breakpoint.c (build_bp_list): Update.
 637         (gdbpy_breakpoints): Update.
 638         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 639         Update.
 640         (bpfinishpy_handle_stop): Update.
 641         (bpfinishpy_handle_exit): Update.
 642         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 643         (svr4_update_solib_event_breakpoints): Update.
 644
 645 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 646
 647         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 648         when unwrapping single-field structs.
 649
 650 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 651
 652         * dwarf2read.c: Remove includes.
 653
 654 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 655
 656         * ui-out.c (ui_out::call_do_message): Silence
 657         -Wformat-nonliteral warning.
 658
 659 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 660
 661         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 662         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 663         include: readline/tilde.h.
 664
 665 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 666
 667         * remote.c (remote_target::get_trace_status): Remove declaration of
 668         trace_regblock_size.
 669
 670 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 671
 672         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 673         (show_user): Remove declaration of cmdlist.
 674         * cli/cli-cmds.h (max_user_call_depth): Declare.
 675         * cli/cli-script.c (execute_user_command): Remove declaration
 676         of max_user_call_depth.
 677
 678 2019-10-11  Jim Wilson  <jimw@sifive.com>
 679
 680         * gdbsupport/print-utils.h (pulongest): Fix comment.
 681         (plongest): Likewise.
 682         (phex): Add missing comment, mention leading zeros.
 683         (phex_nz): Add mention of no leading zeros to comment.
 684
 685         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 686         plongest instead of unsigned long long cast.
 687
 688 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 689
 690         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 691         for external_editor_command and gdbtk_test.
 692
 693 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 694
 695         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 696         * varobj.c (varobjdebug): Move comment to...
 697         * varobj.h (varobjdebug): ...here, and declare.
 698
 699 2019-10-09  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 702         erase_data_content.
 703
 704 2019-10-09  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 707         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 708         * tui/tui-command.c (tui_cmd_window::resize)
 709         (tui_refresh_cmd_win): Update.
 710         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 711         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 712         * tui/tui-data.c (~tui_gen_win_info): Remove.
 713         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 714         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 715         (tui_redisplay_readline, tui_mld_flush)
 716         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 717         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 718         (tui_data_window::erase_data_content)
 719         (tui_data_item_window::rerender)
 720         (tui_data_item_window::refresh_window): Update.
 721         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 722         (box_win, tui_gen_win_info::make_window)
 723         (tui_gen_win_info::make_visible): Update.
 724         (tui_delete_win): Remove.
 725         * tui/tui-winsource.c
 726         (tui_source_window_base::do_erase_source_content): Update.
 727         (tui_show_source_line, tui_source_window_base::update_tab_width)
 728         (tui_source_window_base::update_exec_info): Update.
 729         * tui/tui-data.h (struct curses_deleter): New.
 730         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 731         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 732
 733 2019-10-09  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 736
 737 2019-10-09  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 740         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 741
 742 2019-10-09  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 745         window height directly.
 746         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 747         declare.
 748         * tui/tui-layout.c (tui_default_win_height): Remove.
 749         (tui_default_win_viewport_height): Remove.
 750
 751 2019-10-09  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui.h: Remove comments.
 754
 755 2019-10-09  Tom de Vries  <tdevries@suse.de>
 756
 757         * python/lib/gdb/printer/bound_registers.py: Use
 758         '^builtin_type_bound128' as regexp argument for
 759         add_builtin_pretty_printer.
 760
 761 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 762
 763         * guile/guile.c (guile_extension_script_ops): Remove forward
 764         declaration and mark as static.
 765         (guile_script_ops): Likewise.
 766         (extension_language_guile): Move further down in the file so
 767         it can reference the definitions for guile_{extension_,}script_ops.
 768
 769 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 770
 771         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 772         except SORTL, DFLTCC, and KDSA.
 773
 774 2019-10-08  Tom Tromey  <tromey@adacore.com>
 775
 776         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 777         (struct safe_symbol_file_add_args): Remove.
 778
 779 2019-10-08  Tom Tromey  <tromey@adacore.com>
 780
 781         * windows-nat.c: Don't include buildsym-legacy.h.
 782
 783 2019-10-08  Tom Tromey  <tromey@adacore.com>
 784
 785         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 786
 787 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 788
 789         * gdbtypes.c (overload_debug): Move comment to header.
 790         * gdbtypes.h (overload_debug): Declare.
 791         * valops.c: Remove declaration of overload_debug, instead
 792         include gdbtypes.h.
 793
 794 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 795
 796         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 797         through _().
 798         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 799         move comment...
 800         * language.h (lang_frame_mismatch_warn): ... here. Also add
 801         declaration.
 802         * top.c (lang_frame_mismatch_warn): Remove declaration.
 803         (check_frame_language_change): Pass lang_frame_mismatch_warn
 804         through _().
 805
 806 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 807
 808         * c-lang.h (vtbl_ptr_name): Declare.
 809         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 810         it from the header.
 811         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 812
 813 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 814
 815         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 816         gdb_static_assert.
 817
 818 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 819
 820         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 821         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 822         * ctfread.c: New file.
 823         * ctfread.h: New file.
 824         * elfread.c: Include ctfread.h.
 825         (struct elfinfo text_p): New member ctfsect.
 826         (elf_locate_sections): Mark CTF section.
 827         (elf_symfile_read): Call elfctf_build_psymtabs.
 828         * Makefile.in (LIBCTF): Add.
 829         (CLIBS): Use it.
 830         (CDEPS): Likewise.
 831         (DIST): Add ctfread.c.
 832
 833 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * ctfread.c (struct nextfield): Renamed to ...
 836         (struct ctf_nextfield): ... this.
 837         (struct field_info): Renamed to ...
 838         (strut ctf_field_info): ... this.
 839         (attach_fields_to_type): Update for renamed structures.
 840         (ctf_add_member_cb): Likewise.
 841         (ctf_add_enum_member_cb): Likewise.
 842         (process_struct_members): Likewise.
 843         (process_enum_type): Likewise.
 844
 845 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 846
 847         * tracectf.h: Rename, was ctf.h.
 848         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 849         * tracefile.c: Likewise.
 850         * tracepoint.c: Remove unused include ctf.h.
 851         * mi/mi-main.c: Likewise.
 852         * Makefile.in Replace ctf.c with tracectf.c.
 853
 854 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 855
 856         * version.in: Change version number to "9.0.50.DATE-git".
 857
 858 2019-10-03  Tom Tromey  <tom@tromey.com>
 859
 860         PR rust/24976:
 861         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 862
 863 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 866         cp_search_name_hash.
 867         * NEWS: Add entry about nested function support.
 868
 869 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 870             Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 873         for nested static variables when searchin VAR_DOMAIN.
 874         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 875         global scope, update comment.
 876         (add_partial_subprogram): Call add_partial_subprogram recursively
 877         for nested subroutines when processinng Fortran.
 878         (load_partial_dies): Process the child entities of a subprogram
 879         when processing Fortran.
 880         (partial_die_parent_scope): Handle building scope
 881         for Fortran nested functions.
 882         (process_die): Record that nested functions have a scope.
 883         (new_symbol): Always record Fortran subprograms on the global
 884         symbol list.
 885         (determine_prefix): How to build the prefix for Fortran
 886         subprograms.
 887
 888 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 891         have just sent the thread a SIGSTOP and are waiting for it to
 892         arrive.
 893
 894 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * btrace.c (btrace_add_pc): Remove whitespace before the template
 897         parameter in 'std::vector <...>'.
 898         (parse_xml_btrace_block): Likewise.
 899         (btrace_maint_decode_pt): Likewise.
 900         (btrace_maint_update_packets): Likewise.
 901         (btrace_maint_print_packets): Likewise.
 902         * btrace.h (struct btrace_maint_info): Likewise.
 903         * dwarf2read.c (struct type_unit_group): Likewise.
 904         (build_type_psymtabs_reader): Likewise.
 905         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 906         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 907         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 908
 909 2019-10-03  Tom de Vries  <tdevries@suse.de>
 910
 911         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 912         the first line of the help text for set/show style metadata.
 913
 914 2019-10-02  Tom Tromey  <tromey@adacore.com>
 915
 916         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 917         * gdbsupport/common-inferior.c: New file.
 918         * infcmd.c (startup_with_shell): Don't define.
 919         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 920         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 921         * inferior.h (startup_with_shell): Don't declare.
 922
 923 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 924
 925         * gdbsupport/gdb_assert.h: Include errors.h.
 926         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 927
 928 2019-10-02  Tom Tromey  <tromey@adacore.com>
 929
 930         * NEWS: Add $_ada_exception entry.
 931         * ada-lang.c (struct ada_catchpoint): Add constructor.
 932         <m_kind>: New member.
 933         (allocate_location_exception, re_set_exception): Remove
 934         "ex" parameter.
 935         (should_stop_exception): Compute $_ada_exception.
 936         (check_status_exception, print_it_exception)
 937         (print_one_exception, print_mention_exception): Remove
 938         "ex" parameter.
 939         (allocate_location_catch_exception, re_set_catch_exception)
 940         (check_status_exception, print_it_catch_exception)
 941         (print_one_catch_exception, print_mention_catch_exception)
 942         (print_recreate_catch_exception)
 943         (allocate_location_catch_exception_unhandled)
 944         (re_set_catch_exception_unhandled)
 945         (check_status_exception, print_it_catch_exception_unhandled)
 946         (print_one_catch_exception_unhandled)
 947         (print_mention_catch_exception_unhandled)
 948         (print_recreate_catch_exception_unhandled)
 949         (allocate_location_catch_assert, re_set_catch_assert)
 950         (check_status_assert, print_it_catch_assert)
 951         (print_one_catch_assert, print_mention_catch_assert)
 952         (print_recreate_catch_assert)
 953         (allocate_location_catch_handlers, re_set_catch_handlers)
 954         (check_status_handlers, print_it_catch_handlers)
 955         (print_one_catch_handlers, print_mention_catch_handlers)
 956         (print_recreate_catch_handlers): Remove.
 957         (create_ada_exception_catchpoint): Update.
 958         (initialize_ada_catchpoint_ops): Update.
 959
 960 2019-10-02  Tom Tromey  <tromey@adacore.com>
 961
 962         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 963         (create_excep_cond_exprs): Simplify exception string computation.
 964         (ada_exception_catchpoint_cond_string): Likewise.
 965
 966 2019-10-02  Tom Tromey  <tromey@adacore.com>
 967
 968         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 969         * ada-lang.c (lesseq_defined_than): Handle
 970         LOC_STATIC.
 971         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 972         parameter.
 973         (dwarf2_has_info): Likewise.
 974         (new_symbol): Set maybe_copied on symbol when
 975         appropriate.
 976         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 977         parameter.
 978         <can_copy>: New member.
 979         * elfread.c (record_minimal_symbol): Set maybe_copied
 980         on symbol when appropriate.
 981         (elf_symfile_read): Update call to dwarf2_has_info.
 982         * minsyms.c (lookup_minimal_symbol_linkage): New
 983         function.
 984         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 985         * symtab.c (get_symbol_address, get_msymbol_address):
 986         New functions.
 987         * symtab.h (get_symbol_address, get_msymbol_address):
 988         Declare.
 989         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 990         maybe_copied.
 991         (struct symbol, struct minimal_symbol) <maybe_copied>:
 992         New member.
 993
 994 2019-10-02  Tom Tromey  <tromey@adacore.com>
 995
 996         * source.c (struct current_source_location): New.
 997         (current_source_key): New global.
 998         (current_source_symtab, current_source_line)
 999         (current_source_pspace): Remove.
1000         (get_source_location): New function.
1001         (get_current_source_symtab_and_line)
1002         (set_default_source_symtab_and_line)
1003         (set_current_source_symtab_and_line)
1004         (clear_current_source_symtab_and_line, select_source_symtab)
1005         (info_source_command, print_source_lines_base)
1006         (info_line_command, search_command_helper, _initialize_source):
1007         Update.
1008
1009 2019-10-02  Tom Tromey  <tromey@adacore.com>
1010
1011         * source.c (select_source_symtab): Don't call
1012         decode_line_with_current_source.
1013
1014 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * symtab.c (lookup_global_symbol): Search global block.
1017
1018 2019-10-02  Tom Tromey  <tromey@adacore.com>
1019
1020         * coffread.c (process_coff_symbol): Update.
1021         * dwarf2read.c (var_decode_location, new_symbol): Update.
1022         * mdebugread.c (parse_symbol): Update.
1023         * objfiles.c (relocate_one_symbol): Update.
1024         * stabsread.c (define_symbol, fix_common_block)
1025         (scan_file_globals): Update.
1026         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1027         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1028         * xcoffread.c (process_xcoff_symbol): Update.
1029
1030 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1031
1032         * MAINTAINERS: Update my email address.
1033
1034 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1037         std::vector.
1038         (build_type_psymtabs_reader): Update for std::vector.
1039         (build_type_psymtab_dependencies): Likewise.
1040         * dwarf2read.h: Remove use of DEF_VEC_P.
1041         (typedef sig_type_ptr): Delete.
1042
1043 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1046         to std::vector.
1047         (btrace_maint_decode_pt): Likewise, and move allocation of the
1048         vector outside of the loop.
1049         (btrace_maint_update_packets): Update to handle change from VEC to
1050         std::vector.
1051         (btrace_maint_print_packets): Likewise.
1052         (maint_info_btrace_cmd): Likewise.
1053         * btrace.h: Remove use of DEF_VEC_O.
1054         (typedef btrace_pt_packet_s): Delete.
1055         (struct btrace_maint_info) <packets>: Change fromm VEC to
1056         std::vector.
1057         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1058
1059 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1062         make accesses into the vector constant references.
1063         (btrace_add_pc): Update for std::vector.
1064         (btrace_stitch_bts): Likewise.
1065         (parse_xml_btrace_block): Likewise.
1066         (btrace_maint_update_packets): Likewise.
1067         (btrace_maint_print_packets): Likewise.
1068         (maint_info_btrace_cmd): Likewise.
1069         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1070         std::vector.
1071         (btrace_data::empty): Likewise.
1072         (btrace_data_append): Likewise.
1073         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1074         (typedef btrace_block_s): Delete.
1075         (struct btrace_block): Add constructor.
1076         (struct btrace_data_bts) <blocks>: Change to std::vector.
1077         * nat/linux-btrace.c (perf_event_read_bts): Update for
1078         std::vector.
1079         (linux_read_bts): Likewise.
1080
1081 2019-10-01  Tom Tromey  <tom@tromey.com>
1082
1083         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1084
1085 2019-10-01  Tom Tromey  <tom@tromey.com>
1086
1087         * stack.c (print_frame, info_frame_command_core): Use
1088         styled_string.
1089         * linux-thread-db.c (try_thread_db_load_1)
1090         (try_thread_db_load_from_pdir_1): Use styled_string.
1091         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1092         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1093         (maybe_print_unsupported_script_warning)
1094         (maybe_print_script_not_found_warning): Use styled_string.
1095         * ada-lang.c (user_select_syms): Use styled_string.
1096
1097 2019-10-01  Tom Tromey  <tom@tromey.com>
1098
1099         * p-lang.c (pascal_printstr): Use metadata style.
1100         * value.c (show_convenience): Use metadata style.
1101         * valprint.c (valprint_check_validity, val_print_optimized_out)
1102         (val_print_not_saved, val_print_unavailable)
1103         (val_print_invalid_address, generic_val_print, val_print)
1104         (value_check_printable, val_print_array_elements): Use metadata
1105         style.
1106         * ui-out.h (class ui_out) <field_fmt>: New overload.
1107         <do_field_fmt>: Add style parameter.
1108         * ui-out.c (ui_out::field_fmt): New overload.
1109         * typeprint.c (type_print_unknown_return_type)
1110         (val_print_not_allocated, val_print_not_associated): Use metadata
1111         style.
1112         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1113         parameter.
1114         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1115         * tracepoint.c (tvariables_info_1): Use metadata style.
1116         * stack.c (print_frame_arg, print_frame_info, print_frame)
1117         (info_frame_command_core): Use metadata style.
1118         * skip.c (info_skip_command): Use metadata style.
1119         * rust-lang.c (rust_print_enum): Use metadata style.
1120         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1121         metadata style.
1122         * python/py-framefilter.c (py_print_single_arg): Use metadata
1123         style.
1124         * printcmd.c (do_one_display, print_variable_and_value): Use
1125         metadata style.
1126         * p-valprint.c (pascal_val_print)
1127         (pascal_object_print_value_fields): Use metadata style.
1128         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1129         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1130         parameter.
1131         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1132         * m2-valprint.c (m2_print_long_set): Use metadata style.
1133         * m2-typeprint.c (m2_print_type): Use metadata style.
1134         * infcmd.c (print_return_value_1): Use metadata style.
1135         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1136         * f-valprint.c (info_common_command_for_block): Use metadata
1137         style.
1138         * f-typeprint.c (f_type_print_base): Use metadata style.
1139         * expprint.c (print_subexp_standard): Use metadata style.
1140         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1141         * cli/cli-style.h (class cli_style_option): Add constructor.
1142         (metadata_style): Declare.
1143         * cli/cli-style.c (metadata_style): New global.
1144         (_initialize_cli_style): Register metadata style.
1145         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1146         parameter.
1147         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1148         * c-typeprint.c (c_type_print_base_struct_union)
1149         (c_type_print_base_1): Use metadata style.
1150         * breakpoint.c (watchpoint_value_print)
1151         (print_one_breakpoint_location): Use metadata style.
1152         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1153         style.
1154         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1155         style.
1156         * ada-valprint.c (val_print_packed_array_elements, printstr)
1157         (print_field_values, ada_val_print_ref, ada_val_print): Use
1158         metadata style.
1159         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1160         style.
1161         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1162         style.
1163         * ada-lang.c (user_select_syms): Use metadata style.
1164
1165 2019-10-01  Tom Tromey  <tom@tromey.com>
1166
1167         * cli/cli-cmds.c (pwd_command): Style output.
1168
1169 2019-10-01  Pedro Alves  <palves@redhat.com>
1170             Tom Tromey  <tom@tromey.com>
1171
1172         * symtab.c (print_symbol_info): Use %ps.
1173         (print_msymbol_info): Use %ps.
1174         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1175         * printcmd.c (print_variable_and_value): Use %ps.
1176         * macrocmd.c (show_pp_source_pos): Use %ps.
1177         * infrun.c (print_exited_reason): Use ui_out::message.
1178         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1179         (describe_other_breakpoints): Use ui_out::message and new
1180         formats.
1181         (say_where): Use new formats.
1182         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1183         and new formats.
1184
1185 2019-10-01  Pedro Alves  <palves@redhat.com>
1186             Tom Tromey  <tom@tromey.com>
1187
1188         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1189         (test_gdb_formats): New function.
1190         (run_tests): Call it.
1191         (test_format_specifier): Update.
1192         * utils.h (fputs_filtered): Update comment.
1193         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1194         (fputs_styled_unfiltered): Declare.
1195         * utils.c (fputs_styled_unfiltered): New function.
1196         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1197         (vfprintf_filtered): Update.
1198         (vfprintf_unfiltered, vprintf_filtered): Update.
1199         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1200         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1201         disallow_ui_out_field>: New constants.
1202         (enum class field_kind): New.
1203         (struct base_field_s, struct signed_field_s): New.
1204         (signed_field): New function.
1205         (struct string_field_s): New.
1206         (string_field): New function.
1207         (struct styled_string_s): New.
1208         (styled_string): New function.
1209         (class ui_out) <message>: Add comment.
1210         <vmessage, call_do_message>: New methods.
1211         <do_message>: Add style parameter.
1212         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1213         methods.
1214         (ui_out::message): Rewrite.
1215         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1216         parameter.
1217         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1218         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1219         gdb_extensions parameter.
1220         (class format_piece): Add parameter to constructor.
1221         (n_int_args): New field.
1222         * gdbsupport/format.c (format_pieces::format_pieces): Add
1223         gdb_extensions parameter.  Handle '*'.
1224         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1225         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1226         vfprintf_styled_no_gdbfmt.
1227         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1228         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1229         unfiltered output.
1230         * ui-style.h (struct ui_file_style) <ptr>: New method.
1231
1232 2019-10-01  Tom Tromey  <tom@tromey.com>
1233
1234         * unittests/format_pieces-selftests.c: Update.  Add final format.
1235         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1236         empty literal pieces.
1237
1238 2019-10-01  Tom Tromey  <tom@tromey.com>
1239
1240         * ui-out.h (enum class ui_out_style_kind): Remove.
1241         (class ui_out) <field_string, field_stsream, do_field_string>:
1242         Change type of "style".
1243         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1244         (ui_out::field_string): Update.
1245         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1246         of "style".
1247         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1248         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1249         * stack.c (print_frame_arg, print_frame_info, print_frame):
1250         Update.
1251         * source.c (print_source_lines_base): Update.
1252         * solib.c (info_sharedlibrary_command): Update.
1253         * skip.c (info_skip_command): Update.
1254         * record-btrace.c (btrace_call_history_src_line)
1255         (btrace_call_history): Update.
1256         * python/py-framefilter.c (py_print_frame): Update.
1257         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1258         "style".
1259         * mi/mi-out.c (mi_ui_out::do_table_header)
1260         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1261         (mi_ui_out::do_field_string): Update.
1262         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1263         Update.
1264         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1265         "style".
1266         * cli-out.c (cli_ui_out::do_table_header)
1267         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1268         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1269         (cli_ui_out::do_field_fmt): Update.
1270         * breakpoint.c (print_breakpoint_location): Update.
1271         (update_static_tracepoint): Update.
1272
1273 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1274
1275         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1276         conversion of gdb_datadir.
1277         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1278         remove not needed c_str ().
1279
1280 2019-09-30  Ali Tamur <tamur@google.com>
1281
1282         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1283         (dwarf2_string_attr): Likewise.
1284
1285 2019-09-30  Ali Tamur <tamur@google.com>
1286
1287         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1288         (process_full_type_unit): Likewise.
1289         (dump_die_shallow): Likewise.
1290         (cu_debug_loc_section): Likewise.
1291
1292 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1293
1294         * minsyms.c (compare_minimal_symbols): Rename to...
1295         (minimal_symbol_is_less_than): ...this, and adjust to STL
1296         conventions (return bool, take arguments as references)
1297         (minimal_symbol_reader::install): Call std::sort instead
1298         of qsort.
1299
1300 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1301
1302         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1303         hash and why.
1304         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1305         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1306
1307 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1308
1309         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1310         * psympriv.h (add_psymbol_to_list): Move comment here and update
1311         it.
1312
1313 2019-09-29  Tom de Vries  <tdevries@suse.de>
1314
1315         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1316         Use $tmpdir/$(basename "$output_file").dwz instead of
1317         "${output_file}.dwz".
1318
1319 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1320
1321         PR gdb/25045
1322         * hppa-linux-nat.c: Include gdbarch.h.
1323
1324 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1325
1326         * blockframe.c (find_pc_partial_function): Change return type to bool.
1327         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1328         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1329         (stub_gnu_ifunc_resolve_name): Likewise.
1330         * symtab.c (compare_filenames_for_search): Likewise.
1331         (compare_glob_filenames_for_search): Likewise.
1332         (matching_obj_sections): Likewise.
1333         (symbol_matches_domain): Likewise.
1334         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1335         (find_line_pc): Change return type to bool.
1336         (find_line_pc_range): Likewise.
1337         (producer_is_realview): Likewise.
1338         * symtab.h (symbol_matches_domain): Likewise.
1339         (find_pc_partial_function): Likewise.
1340         (find_pc_line_pc_range): Likewise.
1341         (in_gnu_ifunc_stub): Likewise.
1342         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1343         (find_line_pc): Likewise.
1344         (find_line_pc_range): Likewise.
1345         (matching_obj_sections): Likewise.
1346         (find_line_symtab): Change out parameter to bool.
1347         (producer_is_realview): Change return type to bool.
1348         (compare_filenames_for_search): Likewise.
1349         (compare_glob_filenames_for_search): Likewise.
1350
1351 2019-09-26  Tom Tromey  <tom@tromey.com>
1352
1353         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1354         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1355         * gdb_usleep.h: Remove.
1356         * gdb_usleep.c: Remove.
1357         * utils.c: Don't include gdb_usleep.h.
1358
1359 2019-09-26  Tom Tromey  <tromey@adacore.com>
1360
1361         * python/py-type.c (type_to_type_object): Call check_typedef
1362         for stub types.
1363
1364 2019-09-26  Tom Tromey  <tom@tromey.com>
1365
1366         * utils.h (initialize_utils): Don't declare.
1367         * top.c (gdb_init): Don't call initialize_utils.
1368         * utils.c (initialize_utils): Remove.  Move contents...
1369         (_initialize_utils): ... here.
1370
1371 2019-09-25  Tom Tromey  <tom@tromey.com>
1372
1373         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1374         * utils.h (make_hex_string): Don't declare.
1375         * utils.c (make_hex_string): Remove.
1376
1377 2019-09-24  Tom de Vries  <tdevries@suse.de>
1378
1379         PR gdb/23815
1380         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1381         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1382
1383 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1384
1385         * NEWS: Mention new simulator port for PRU.
1386
1387 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1388
1389         * ada-exp.y (write_object_remaining): Update.
1390         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1391         and eliminate the static buffer.
1392         (ada_decode_symbol): Update.
1393         (ada_la_decode): Update.
1394         (ada_sniff_from_mangled_name): Update.
1395         (is_valid_name_for_wild_match): Update.
1396         (ada_lookup_name_info::matches): Update and simplify.
1397         (name_matches_regex): Update.
1398         (ada_add_global_exceptions): Update.
1399         * ada-lang.h (ada_decode): Update signature.
1400         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1401         * dwarf-index-write.c (debug_names::insert): Update.
1402
1403 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1404
1405         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1406         formatting.
1407
1408 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1409
1410         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1411         Change "nonzero" to "true" in documentation.
1412
1413 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1414
1415         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1416         (_initialize_darwin_solib): Don't set
1417         darwin_so_ops.lookup_lib_global_symbol.
1418         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1419         set_gdbarch_iterate_over_objfiles_in_search_order.
1420         (elf_lookup_lib_symbol): Rename to...
1421         (svr4_iterate_over_objfiles_in_search_order): this, and update
1422         to iterate semantics.
1423         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1424         * solib.c (solib_global_lookup): Remove.
1425         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1426         (solib_global_lookup): Remove.
1427         * symtab.c (lookup_global_or_static_symbol): Remove call to
1428         solib_global_lookup.
1429
1430 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1431
1432         * NEWS: Move entries about default MI version now being
1433         version 3, and about the GDB/MI fix for multi-location
1434         breakpoints to the "since GDB 8.3" section.
1435
1436 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1437
1438         GDB 8.3.1 released.
1439
1440 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1441
1442         * NEWS: Mention that Cell/B.E. debugging support was removed.
1443         * MAINTAINERS: Remove spu target.
1444
1445         * config/djgpp/fnchange.lst: Remove entries for removed files.
1446
1447         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1448         spu-multiarch.o, and spu-tdep.o.
1449         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1450         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1451         spu-multiarch.c, and spu-tdep.c.
1452         * spu-linux-nat.c: Remove file.
1453         * spu-multiarch.c: Remove file.
1454         * spu-tdep.c: Remove file.
1455         * spu-tdep.h: Remove file.
1456         * solib-spu.c: Remove file.
1457         * solib-spu.h: Remove file.
1458
1459         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1460         * configure.nat (spu-linux): Remove.
1461         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1462         solib-multiarch.o from gdb_target_obs.
1463         (spu*-*-*): Remove.
1464
1465         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1466         feature flag.
1467         (ppc_linux_no_features): Update.
1468         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1469         Cell/B.E. support.
1470         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1471         (tdesc_powerpc_cell64l): Likewise.
1472         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1473         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1474         Cell/B.E. support.
1475         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1476         Do not include "features/rs6000/powerpc-cell32l.c" or
1477         "features/rs6000/powerpc-cell64l.c".
1478         (ppc_linux_spu_section): Remove.
1479         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1480         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1481         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1482         (ppc_linux_spe_context_lookup): Remove.
1483         (ppc_linux_spe_context_inferior_created): Remove.
1484         (ppc_linux_spe_context_solib_loaded): Remove.
1485         (ppc_linux_spe_context_solib_unloaded): Remove.
1486         (ppc_linux_spe_context): Remove.
1487         (struct ppu2spu_cache): Remove.
1488         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1489         (struct ppu2spu_data): Remove.
1490         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1491         ppu2spu_unwind): Remove.
1492         (ppc_linux_init_abi): Remove Cell/B.E. support.
1493         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1494
1495         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1496         (rs6000/powerpc-cell64l-expedite): Likewise
1497         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1498         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1499         rs6000/powerpc-cell64l.xml.
1500         * features/rs6000/powerpc-cell32l.xml: Remove.
1501         * features/rs6000/powerpc-cell64l.xml: Likewise.
1502         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1503         * features/rs6000/powerpc-cell64l.c: Likewise.
1504         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1505         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1506         * regformats/reg-spu.dat: Remove.
1507
1508         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1509         * corelow.c (struct spuid_list): Remove.
1510         (add_to_spuid_list): Remove.
1511         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1512         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1513         (remote_protocol_features): Remove associated entries.
1514         (_initialize_remote): No longer initialize them.
1515         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1516         * linux-nat.c (SPUFS_MAGIC): Remove.
1517         (linux_proc_xfer_spu): Remove.
1518         (spu_enumerate_spu_ids): Remove.
1519         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1520         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1521         (linux_make_corefile_notes): No longer call it.
1522
1523         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1524         (cooked_write_test): Likewise.
1525
1526 2019-09-20  Tom Tromey  <tom@tromey.com>
1527
1528         * NEWS: Mention case-sensitivity of TUI commands.
1529         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1530         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1531         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1532
1533 2019-09-20  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-source.c (tui_source_window::set_contents): Use
1536         make_unique_xstrdup.
1537         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1538         make_unique_xstrdup.
1539
1540 2019-09-20  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-data.c: Remove separator comments.
1543         * tui/tui-layout.c: Remove separator comments.
1544         * tui/tui-win.c: Remove separator comments.
1545         * tui/tui-wingeneral.c: Remove separator comments.
1546
1547 2019-09-20  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui.h (strcat_to_buf): Don't declare.
1550         * tui/tui.c (strcat_to_buf): Remove.
1551
1552 2019-09-20  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1555         from "fullname".
1556         * tui/tui-source.c (tui_source_window::set_contents)
1557         (tui_source_window::location_matches_p)
1558         (tui_source_window::maybe_update): Update.
1559
1560 2019-09-20  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1563         Update.
1564         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1565         prefix.
1566         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1567         (tui_data_window::line_from_reg_element_no)
1568         (tui_data_window::first_reg_element_no_inline)
1569         (tui_data_window::show_registers)
1570         (tui_data_window::show_register_group)
1571         (tui_data_window::display_registers_from)
1572         (tui_data_window::display_registers_from_line)
1573         (tui_data_window::first_data_item_displayed)
1574         (tui_data_window::delete_data_content_windows)
1575         (tui_data_window::erase_data_content)
1576         (tui_data_window::do_scroll_vertical)
1577         (tui_data_window::refresh_window)
1578         (tui_data_window::check_register_values): Update.
1579
1580 2019-09-20  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1583         (struct tui_locator_window) <full_name, proc_name>: Now
1584         std::string.
1585         * tui/tui-stack.c (tui_locator_window::make_status_line)
1586         (tui_locator_window::set_locator_fullname)
1587         (tui_locator_window::set_locator_info): Update.
1588         * tui/tui-source.c (tui_source_window::set_contents)
1589         (tui_source_window::showing_source_p): Update.
1590
1591 2019-09-20  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1594         Don't call tui_locator_win_info_ptr.
1595
1596 2019-09-20  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1599
1600 2019-09-20  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1603         height for locator.
1604         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1605         * tui/tui-layout.c (show_source_disasm_command, show_data)
1606         (show_source_or_disasm_and_command): Use 1 as height for locator.
1607
1608 2019-09-20  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui.c (tui_enable): Update.
1611         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1612         Update.
1613         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1614         Update.
1615         * tui/tui-data.c (win_resized): Now bool.
1616         (tui_win_resized): Return bool.
1617         (tui_set_win_resized_to): Accept a bool.
1618
1619 2019-09-20  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1622         Change type of "refresh_values_only".
1623         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1624         type of "refresh_values_only".
1625
1626 2019-09-20  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1629         std::string.
1630         (tui_disassemble): Add "pos" parameter.
1631         (tui_disasm_window::set_contents): Simplify.
1632
1633 2019-09-20  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-winsource.h (struct tui_source_window_base)
1636         <show_source_content>: Now private.
1637         * tui/tui-winsource.c
1638         (tui_source_window_base::show_source_content): Don't handle empty
1639         content case.
1640
1641 2019-09-20  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-layout.c (show_source_disasm_command)
1644         (show_source_or_disasm_and_command): Don't call
1645         show_source_content.
1646
1647 2019-09-20  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1650         Declare.
1651         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1652         from tui_make_status_line.
1653         (tui_locator_window::rerender): Update.
1654
1655 2019-09-20  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1658         (tui_locator_window::rerender): Update.
1659
1660 2019-09-20  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-winsource.h (struct tui_source_window_base)
1663         <~tui_source_window_base>: Don't declare.
1664         <fullname>: Remove.
1665         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1666         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1667         member.
1668         * tui/tui-source.c (tui_source_window::set_contents): Update.
1669         (tui_source_window::location_matches_p)
1670         (tui_source_window::maybe_update): Update.
1671
1672 2019-09-20  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-winsource.h (~tui_source_element): Remove.
1675         (tui_source_element): Update.
1676         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1677         * tui/tui-winsource.c (tui_show_source_line): Update.
1678         * tui/tui-source.c (tui_source_window::set_contents): Update.
1679         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1680
1681 2019-09-20  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1684         declare.
1685         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1686         tui_clear_source_windows_detail.
1687         * tui/tui-winsource.h (struct tui_source_window_base)
1688         <clear_detail>: Don't declare.
1689         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1690         Remove.
1691         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1692
1693 2019-09-20  Tom Tromey  <tromey@adacore.com>
1694
1695         PR ada/24919:
1696         * block.c (contained_in): Fix final return value.
1697
1698 2019-09-20  Alan Modra  <amodra@gmail.com>
1699
1700         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1701         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1702         (read_indirect_string_from_dwz): Use bfd accessor.
1703         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1704         * machoread.c (macho_symfile_read_all_oso): Likewise.
1705         * solib.c (solib_bfd_open): Likewise.
1706
1707 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1708
1709         * eval.c: Move declaration of overload_resolution to...
1710         * value.h: ...here.
1711
1712 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1715         * arm-linux-tdep.c: Likewise.
1716         * arm-nbsd-nat.c: Likewise.
1717         * arm-tdep.h: Declare arm_apcs_32.
1718         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1719
1720 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1721
1722         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1723         * dwarf2read.h: Declare dwarf_always_disassemble.
1724
1725 2019-09-19  Tom de Vries  <tdevries@suse.de>
1726
1727         PR gdb/25009
1728         * source-cache.c (source_cache::ensure): Catch exception thrown during
1729         construction of the highlighter.
1730
1731 2019-09-18  Alan Modra  <amodra@gmail.com>
1732
1733         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1734         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1735         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1736         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1737         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1738         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1739         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1740         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1741         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1742         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1743         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1744         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1745         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1746         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1747         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1748         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1749         * mi/mi-interp.c: Update throughout for bfd section macro and
1750         function changes.
1751         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1752         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1753
1754 2019-09-18  Tom Tromey  <tom@tromey.com>
1755
1756         * NEWS: Add entry.
1757         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1758         call rl_initialize.
1759         (tui_enable): Do not call rl_initialize.
1760
1761 2019-09-18  Christian Groessler  <chris@groessler.org>
1762
1763         * alpha-linux-nat.c: Include gdbarch.h.
1764
1765 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1766
1767         * ui-file.c: Include cli/cli-style.h.
1768         (term_cli_styling): Remove cli_styling declaration.
1769
1770 2019-09-18  Alan Modra  <amodra@gmail.com>
1771
1772         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1773         to bfd_asymbol_section.
1774
1775 2019-09-18  Alan Modra  <amodra@gmail.com>
1776
1777         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1778         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1779         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1780
1781 2019-09-18  Alan Modra  <amodra@gmail.com>
1782
1783         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1784         * spu-linux-nat.c (spu_bfd_open): Likewise.
1785
1786 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1787
1788         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1789         to bool to match definition in dwarf2read.c.
1790
1791 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1792
1793         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1794         (print_signatures): Likewise.
1795         (trust_pad_over_xvs): Likewise.
1796         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1797         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1798         * arm-linux-nat.c (arm_apcs_32): Likewise.
1799         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1800         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1801         * arm-tdep.c (arm_debug): Likewise.
1802         (arm_apcs_32): Likewise.
1803         * auto-load.c (debug_auto_load): Likewise.
1804         (auto_load_gdb_scripts): Likewise.
1805         (global_auto_load): Likewise.
1806         (auto_load_local_gdbinit): Likewise.
1807         (auto_load_local_gdbinit_loaded): Likewise.
1808         * auto-load.h (global_auto_load): Likewise.
1809         (auto_load_local_gdbinit): Likewise.
1810         (auto_load_local_gdbinit_loaded): Likewise.
1811         * breakpoint.c (disconnected_dprintf): Likewise.
1812         (breakpoint_proceeded): Likewise.
1813         (automatic_hardware_breakpoints): Likewise.
1814         (always_inserted_mode): Likewise.
1815         (target_exact_watchpoints): Likewise.
1816         (_initialize_breakpoint): Update.
1817         * breakpoint.h (target_exact_watchpoints): Change to bool.
1818         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1819         * cli/cli-cmds.c (trace_commands): Likewise.
1820         * cli/cli-cmds.h (trace_commands): Likewise.
1821         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1822         to bool*.
1823         * cli/cli-logging.c (logging_overwrite): Change to bool.
1824         (logging_redirect): Likewise.
1825         (debug_redirect): Likewise.
1826         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1827         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1828         to bool.
1829         <boolean_option_def>: Update.
1830         (struct flag_option_def): Change default type of Context to bool
1831         from int.
1832         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1833         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1834         (get_setshow_command_value_string): Likewise.
1835         * cli/cli-style.c (cli_styling): Change to bool.
1836         (source_styling): Likewise.
1837         * cli/cli-style.h (source_styling): Likewise.
1838         (cli_styling): Likewise.
1839         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1840         to bool.
1841         * command.h (var_types): Update comment.
1842         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1843         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1844         bool.
1845         (debug_compile_cplus_scopes): Likewise.
1846         * compile/compile-internal.h (compile_debug): Likewise.
1847         * compile/compile.c (compile_debug): Likewise.
1848         (struct compile_options) <raw>: Likewise.
1849         * cp-support.c (catch_demangler_crashes): Likewise.
1850         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1851         (usr_cmd_cris_dwarf2_cfi): Likewise.
1852         * csky-tdep.c (csky_debug): Likewise.
1853         * darwin-nat.c (enable_mach_exceptions): Likewise.
1854         * dcache.c (dcache_enabled_p): Likewise.
1855         * defs.h (info_verbose): Likewise.
1856         * demangle.c (demangle): Likewise.
1857         (asm_demangle): Likewise.
1858         * dwarf-index-cache.c (debug_index_cache): Likewise.
1859         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1860         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1861         * dwarf2read.c (check_physname): Likewise.
1862         (use_deprecated_index_sections): Likewise.
1863         (dwarf_always_disassemble): Likewise.
1864         * eval.c (overload_resolution): Likewise.
1865         * event-top.c (set_editing_cmd_var): Likewise.
1866         (exec_done_display_p): Likewise.
1867         * event-top.h (set_editing_cmd_var): Likewise.
1868         (exec_done_display_p): Likewise.
1869         * exec.c (write_files): Likewise.
1870         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1871         (debug_fbsd_nat): Likewise.
1872         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1873         Likewise.
1874         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1875         <backtrace_past_entry> Likewise.
1876         * gdb-demangle.h (demangle): Likewise.
1877         (asm_demangle): Likewise.
1878         * gdb_bfd.c (bfd_sharing): Likewise.
1879         * gdbcore.h (write_files): Likewise.
1880         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1881         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1882         * gdbthread.h (print_thread_events): Likewise.
1883         * gdbtypes.c (opaque_type_resolution): Likewise.
1884         (strict_type_checking): Likewise.
1885         * gnu-nat.c (gnu_debug_flag): Likewise.
1886         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1887         * guile/scm-param.c (pascm_variable): Add boolval.
1888         (add_setshow_generic): Update.
1889         (pascm_param_value): Update.
1890         (pascm_set_param_value_x): Update.
1891         * hppa-tdep.c (hppa_debug): Change to bool..
1892         * infcall.c (may_call_functions_p): Likewise.
1893         (coerce_float_to_double_p): Likewise.
1894         (unwind_on_signal_p): Likewise.
1895         (unwind_on_terminating_exception_p): Likewise.
1896         * infcmd.c (startup_with_shell): Likewise.
1897         * inferior.c (print_inferior_events): Likewise.
1898         * inferior.h (startup_with_shell): Likewise.
1899         (print_inferior_events): Likewise.
1900         * infrun.c (step_stop_if_no_debug): Likewise.
1901         (detach_fork): Likewise.
1902         (debug_displaced): Likewise.
1903         (disable_randomization): Likewise.
1904         (non_stop): Likewise.
1905         (non_stop_1): Likewise.
1906         (observer_mode): Likewise.
1907         (observer_mode_1): Likewise.
1908         (set_observer_mode): Update.
1909         (sched_multi): Change to bool.
1910         * infrun.h (debug_displaced): Likewise.
1911         (sched_multi): Likewise.
1912         (step_stop_if_no_debug): Likewise.
1913         (non_stop): Likewise.
1914         (disable_randomization): Likewise.
1915         * linux-tdep.c (use_coredump_filter): Likewise.
1916         (dump_excluded_mappings): Likewise.
1917         * linux-thread-db.c (auto_load_thread_db): Likewise.
1918         (check_thread_db_on_load): Likewise.
1919         * main.c (captured_main_1): Update.
1920         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1921         xx2_opt, boolean_opt>: Change to bool.
1922         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1923         * maint.c (maintenance_profile_p): Likewise.
1924         (per_command_time): Likewise.
1925         (per_command_space): Likewise.
1926         (per_command_symtab): Likewise.
1927         * memattr.c (inaccessible_by_default): Likewise.
1928         * mi/mi-main.c (mi_async): Likewise.
1929         (mi_async_1): Likewise.
1930         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1931         * nat/fork-inferior.h (startup_with_shell): Likewise.
1932         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1933         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1934         * nios2-tdep.c (nios2_debug): Likewise.
1935         * or1k-tdep.c (or1k_debug): Likewise.
1936         * parse.c (parser_debug): Likewise.
1937         * parser-defs.h (parser_debug): Likewise.
1938         * printcmd.c (print_symbol_filename): Likewise.
1939         * proc-api.c (procfs_trace): Likewise.
1940         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1941         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1942         (set_parameter_value): Update.
1943         (add_setshow_generic): Update.
1944         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1945         to bool*.
1946         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1947         int*.
1948         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1949         * record-btrace.c (record_btrace_target::store_registers): Update.
1950         * record-full.c (record_full_memory_query): Change to bool.
1951         (record_full_stop_at_limit): Likewise.
1952         * record-full.h (record_full_memory_query): Likewise.
1953         * remote-notif.c (notif_debug): Likewise.
1954         * remote-notif.h (notif_debug): Likewise.
1955         * remote.c (use_range_stepping): Likewise.
1956         (interrupt_on_connect): Likewise.
1957         (remote_break): Likewise.
1958         * ser-tcp.c (tcp_auto_retry): Likewise.
1959         * ser-unix.c (serial_hwflow): Likewise.
1960         * skip.c (debug_skip): Likewise.
1961         * solib-aix.c (solib_aix_debug): Likewise.
1962         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1963         (spu_auto_flush_cache_p): Likewise.
1964         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1965         Likewise.
1966         (struct info_print_options) <quiet>: Likewise.
1967         * symfile-debug.c (debug_symfile): Likewise.
1968         * symfile.c (auto_solib_add): Likewise.
1969         (separate_debug_file_debug): Likewise.
1970         * symfile.h (auto_solib_add): Likewise.
1971         (separate_debug_file_debug): Likewise.
1972         * symtab.c (basenames_may_differ): Likewise.
1973         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1974         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1975         (struct info_types_options) <quiet>: Likewise.
1976         * symtab.h (demangle): Likewise.
1977         (basenames_may_differ): Likewise.
1978         * target-dcache.c (stack_cache_enabled_1): Likewise.
1979         (code_cache_enabled_1): Likewise.
1980         * target.c (trust_readonly): Likewise.
1981         (may_write_registers): Likewise.
1982         (may_write_memory): Likewise.
1983         (may_insert_breakpoints): Likewise.
1984         (may_insert_tracepoints): Likewise.
1985         (may_insert_fast_tracepoints): Likewise.
1986         (may_stop): Likewise.
1987         (auto_connect_native_target): Likewise.
1988         (target_stop_and_wait): Update.
1989         (target_async_permitted): Change to bool.
1990         (target_async_permitted_1): Likewise.
1991         (may_write_registers_1): Likewise.
1992         (may_write_memory_1): Likewise.
1993         (may_insert_breakpoints_1): Likewise.
1994         (may_insert_tracepoints_1): Likewise.
1995         (may_insert_fast_tracepoints_1): Likewise.
1996         (may_stop_1): Likewise.
1997         * target.h (target_async_permitted): Likewise.
1998         (may_write_registers): Likewise.
1999         (may_write_memory): Likewise.
2000         (may_insert_breakpoints): Likewise.
2001         (may_insert_tracepoints): Likewise.
2002         (may_insert_fast_tracepoints): Likewise.
2003         (may_stop): Likewise.
2004         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2005         (make_thread_apply_all_options_def_group): Change argument from int*
2006         to bool*.
2007         (thread_apply_all_command): Update.
2008         (print_thread_events): Change to bool.
2009         * top.c (confirm): Likewise.
2010         (command_editing_p): Likewise.
2011         (history_expansion_p): Likewise.
2012         (write_history_p): Likewise.
2013         (info_verbose): Likewise.
2014         * top.h (confirm): Likewise.
2015         (history_expansion_p): Likewise.
2016         * tracepoint.c (disconnected_tracing): Likewise.
2017         (circular_trace_buffer): Likewise.
2018         * typeprint.c (print_methods): Likewise.
2019         (print_typedefs): Likewise.
2020         * utils.c (debug_timestamp): Likewise.
2021         (sevenbit_strings): Likewise.
2022         (pagination_enabled): Likewise.
2023         * utils.h (sevenbit_strings): Likewise.
2024         (pagination_enabled): Likewise.
2025         * valops.c (overload_resolution): Likewise.
2026         * valprint.h (struct value_print_options) <prettyformat_arrays,
2027         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2028         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2029         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2030         Likewise.
2031         * windows-nat.c (new_console): Likewise.
2032         (cygwin_exceptions): Likewise.
2033         (new_group): Likewise.
2034         (debug_exec): Likewise.
2035         (debug_events): Likewise.
2036         (debug_memory): Likewise.
2037         (debug_exceptions): Likewise.
2038         (useshell): Likewise.
2039         * windows-tdep.c (maint_display_all_tib): Likewise.
2040         * xml-support.c (debug_xml): Likewise.
2041
2042 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2043
2044         * source.c (prepare_path_for_appending): New function.
2045         (openp): Make use of new function.
2046         (find_and_open_source): Search for the compilation directory and
2047         source file as a relative path beneath the directory search path.
2048
2049 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * source-cache.c (source_cache::get_line_charpos): Catch
2052         exceptions and return false, this matches the behaviour documented
2053         in the header file.
2054
2055 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2056
2057         * ada-tasks.c (info_task): Remove quoting of the task's name.
2058
2059 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2060
2061         * symfile.c (auto_solib_add): Replace comment with a reference
2062         to the header file.
2063
2064 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2065
2066         * NEWS: Mention that gdb can now be compiled with Python 3
2067         on Windows.
2068
2069 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * maint.c (maint_print_section_data::maint_print_section_data):
2072         Force use of 'float log10 (float)' by casting the argument to
2073         float.
2074
2075 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2076
2077         * maint.c: Add 'cmath' include.
2078         (struct maint_print_section_data): New structure.
2079         (print_section_index): New function.
2080         (print_bfd_section_info): Add header comment, small whitespace
2081         cleanup, and update to call new print_section_index function.
2082         (print_objfile_section_info): Likewise.
2083         (maint_obj_section_from_bfd_section): New function.
2084         (print_bfd_section_info_maybe_relocated): New function.
2085         (maintenance_info_sections): Add header comment, always use
2086         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2087
2088 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2091         inner scope, add check that the objfile has psymtabs before
2092         checking psymtabs_addrmap.
2093         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2094
2095 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2096
2097         * NEWS: Announce that Ada task names are now shown at more places,
2098         and between quotes (except in info task output).
2099         * gdb/ada-tasks.c (task_to_str): New function.
2100         (display_current_task_id): Call task_to_str.
2101         (task_command_1): Likewise.
2102         (print_ada_task_info): In non-mi mode, Properly align headers and data
2103         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2104
2105 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2106
2107         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2108         prstatus.pr_lwp.pr_info instead of making it up.
2109
2110 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2111
2112         * auto-load.c (auto_load_expand_dir_vars): Update.
2113         * defs.h (gdb_datadir): Change to std::string.
2114         (python_libdir): Likewise.
2115         (relocate_gdb_directory): Change return type to std::string.
2116         * guile/guile.c (gdbscm_data_directory): Update.
2117         (initialize_scheme_side): Update.
2118         * jit.c (jit_reader_dir): Change to std::string.
2119         (jit_reader_load_command): Update.
2120         * main.c (gdb_datadir): Change to std::string.
2121         (python_libdir): Likewise.
2122         (set_gdb_data_directory): Update.
2123         (relocate_path): Change to return std::string.
2124         (relocate_gdb_directory): Change to return std::string.
2125         (relocate_gdbinit_path_maybe_in_datadir): Update.
2126         (captured_main_1): Update.
2127         * python/python.c (do_start_initialization): Update.
2128         * top.c (show_gdb_datadir): Update.
2129         * xml-syscall.c (xml_init_syscalls_info): Update.
2130         (init_syscalls_info): Update.
2131
2132 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2133
2134         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2135         out of get_init_files.
2136         (get_init_files): Update.
2137
2138 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2139
2140         * main.c (get_init_files): Change to use std::string.
2141         (captured_main_1): Update.
2142         (print_gdb_help): Update.
2143
2144 2019-09-11  Ali Tamur  <tamur@google.com>
2145
2146         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2147         implementation.
2148
2149 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2150
2151         * dbxread.c (read_dbx_symtab): Update.
2152         * dwarf2read.c (load_partial_dies): Update.
2153         * mdebugread.c (parse_partial_symbols): Update.
2154         (handle_psymbol_enumerators): Update.
2155         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2156         * psymtab.c (add_psymbol_to_bcache): Likewise.
2157         (add_psymbol_to_list): Likewise.
2158         * symtab.c (symbol_set_names): Likewise.
2159         * symtab.h (symbol_set_names): Likewise.
2160         * xcoffread.c (scan_xcoff_symtab): Update.
2161
2162 2019-09-11  Tom Tromey  <tom@tromey.com>
2163
2164         * symfile-mem.c (symbol_file_add_from_memory): Use
2165         bfd_set_filename.
2166         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2167         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2168
2169 2019-09-10  Tom Tromey  <tromey@adacore.com>
2170
2171         * dwarf-index-write.c (write_psymbols): Extend error message.
2172         (debug_names::insert): Add Ada code.
2173         (debug_names::write_psymbols): Remove Ada check.
2174         (debug_names) <m_string_obstack>: New member.
2175         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2176         (gdb_index_symbol_name_matcher::matches): Remove.
2177         (mapped_index_base::find_name_components_bounds): Add "lang"
2178         parameter.
2179         (mapped_index_base::build_name_components): Also split names
2180         according to Ada syntax.
2181         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2182         type of "match_callback".
2183         (check_match, check_find_bounds_finds)
2184         (dw2_expand_symtabs_matching): Update.
2185         (dw2_debug_names_iterator): Add new constructor.
2186         (dw2_debug_names_map_matching_symbols): New function.
2187         (dw2_debug_names_expand_symtabs_matching): Update.
2188         (dwarf2_debug_names_functions): Use
2189         dw2_debug_names_map_matching_symbols.
2190
2191 2019-09-10  Tom Tromey  <tromey@adacore.com>
2192
2193         * dwarf2read.c (dw2_get_file_names_reader): Add the
2194         CU's file name to the results.
2195
2196 2019-09-10  Tom Tromey  <tromey@adacore.com>
2197
2198         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2199         map_matching_symbols.  Update.
2200         * dwarf2read.c (dw2_map_matching_symbols): Update.
2201         * psymtab.c (match_partial_symbol): Change type; update.
2202         (psym_map_matching_symbols): Likewise.
2203         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2204         type; update.
2205         * symfile.h (struct quick_symbol_functions)
2206         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2207         Remove "match".
2208
2209 2019-09-10  Tom Tromey  <tromey@adacore.com>
2210
2211         * psymtab.c (map_block): Remove.
2212         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2213         * symtab.c (iterate_over_symbols_terminated): New function.
2214         * symtab.c (iterate_over_symbols_terminated): Declare.
2215
2216 2019-09-10  Tom Tromey  <tromey@adacore.com>
2217
2218         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2219         * language.h (struct language_defn) <la_iterate_over_symbols>:
2220         Return bool.
2221         * symtab.c (iterate_over_symbols): Return bool.
2222         * symtab.h (iterate_over_symbols): Return bool.
2223
2224 2019-09-10  Tom Tromey  <tromey@adacore.com>
2225
2226         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2227         (add_nonlocal_symbols): Update.
2228         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2229         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2230         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2231         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2232         Change type of "callback".  Remove "data".
2233
2234
2235 2019-09-09  Ali Tamur  <tamur@google.com>
2236
2237         * dwarf2read.c (comp_unit_head): Update comment.
2238         (dwarf2_dwo_name): New function declaration.
2239         (dwarf_unit_type_name): New function declaration.
2240         (read_comp_unit_head): Add support for new compilation units,
2241         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2242         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2243         (currently named as "signature") in their header. Also clarify error
2244         messages.
2245         (lookup_dwo_id): New function. Returns the dwo id of the given
2246         compile unit.
2247         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2248         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2249         functions.
2250         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2251         (dwarf2_dwo_name): Get the dwo name if present.
2252         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2253         purposes.
2254
2255 2019-09-09  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2258
2259 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2260
2261         * python/python.c (do_start_initialization): Make progname_copy static,
2262         to avoid a leak report.
2263
2264 2019-09-08  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2267
2268 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2269
2270         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2271         Change type to gdb::optional<block_enum>.
2272         (dw2_symtab_iter_init): Change block_index parameter type
2273         to gdb::optional<block_enum>.
2274         (dw2_lookup_symbol): Change block_index parameter
2275         type to block_enum.c
2276         (dw2_debug_names_lookup_symbol): Likewise.
2277         * psymtab.c (psym_lookup_symbol): Likewise.
2278         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2279         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2280         Likewise.
2281
2282 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2283
2284         * defs.h (relocate_gdb_directory): Change int to bool in
2285         signature and rename flag to relocatable.
2286         * main.c (relocate_path): Likewise.
2287         (relocate_gdb_directory): Likewise.
2288
2289 2019-09-06  Alan Modra  <amodra@gmail.com>
2290
2291         * coffread.c (coff_symfile_read): Constify filename variable.
2292         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2293         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2294         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2295         * solib.c (reload_shared_libraries_1): Likewise.
2296         * symfile.c (reread_symbols): Likewise.
2297         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2298         * solib-darwin.c (darwin_bfd_open): Likewise.
2299         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2300
2301 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2302
2303         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2304         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2305
2306 2019-09-03  Tom Tromey  <tromey@adacore.com>
2307
2308         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2309         types.
2310         (has_negatives): Unbias a range type bound.
2311         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2312         * gdbtypes.c (operator==): Handle new field.
2313         (create_range_type): Add "bias" parameter.
2314         (create_static_range_type, resolve_dynamic_range): Update.
2315         * gdbtypes.h (struct range_bounds) <bias>: New member.
2316         (create_range_type): Add bias parameter.
2317         * printcmd.c (print_scalar_formatted): Unbias range types.
2318         * value.c (unpack_long): Unbias range types.
2319         (pack_long): Bias range types.
2320
2321 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2322
2323         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2324         probe arguments.
2325
2326 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2327
2328         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2329         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2330         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2331         (compile_probe_arg): Likewise.
2332         * probe.h (get_argument_count): Likewise.
2333         * solib-svr4.c (solib_event_probe_action): Likewise.
2334         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2335
2336 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2337
2338         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2339         code to here...
2340         (svr4_create_solib_event_breakpoints): ...from here.
2341
2342 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2343
2344         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2345         suffix from warning message.
2346
2347 2019-08-30  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-winsource.h (struct tui_source_window_base)
2350         <refresh_all>: Don't declare.
2351         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2352         Remove.
2353         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2354         tui_show_locator_content.
2355         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2356         declare.
2357         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2358         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2359         declare.
2360
2361 2019-08-30  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2364
2365 2019-08-30  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2368         Remove unnecessary forward declarations.
2369
2370 2019-08-30  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2373         rerender.
2374         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2375         tui_show_locator_content.
2376
2377 2019-08-30  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2380         (tui_locator_window::rerender): Rewrite using body of previous
2381         tui_show_locator_content.
2382
2383 2019-08-30  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2386         set_locator_fullname>: New methods.
2387         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2388         Rename from tui_set_locator_fullname.
2389         (tui_locator_window::set_locator_info): Rename from
2390         tui_set_locator_info.  Return bool.
2391         (tui_update_locator_fullname, tui_show_frame_info): Update.
2392
2393 2019-08-30  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2396
2397 2019-08-30  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2400         call touchwin.
2401
2402 2019-08-30  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-wingeneral.c (box_win): Assume win_info and
2405         win_info->handle cannot be NULL.
2406
2407 2019-08-30  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2410         refresh_window>: Declare.
2411         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2412         resize.
2413         (tui_data_item_window::rerender): Rename from
2414         tui_display_register.
2415         (tui_data_item_window::refresh_window): New method.
2416         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2417         no-op.
2418
2419 2019-08-30  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2422         regs_column_count, current_group>: Move later.  Now private.
2423         <get_current_group>: New method.
2424         * tui/tui-regs.c (tui_reg_command): Update.
2425         * tui/tui-layout.c (tui_set_layout): Update.
2426
2427 2019-08-30  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2430         (tui_data_window::rerender): Don't call
2431         check_and_display_highlight_if_needed.
2432         (tui_data_window::refresh_all): Remove call to
2433         erase_data_content.
2434
2435 2019-08-30  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2438         (tui_data_window::display_registers_from)
2439         (tui_data_window::display_reg_element_at_line)
2440         (tui_data_window::display_registers_from_line): Remove checks of
2441         "empty".
2442
2443 2019-08-30  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2446         Don't declare.
2447         * tui/tui-regs.c (tui_data_window::show_registers): Call
2448         rerender.
2449         (tui_data_window::rerender): Rename from display_all_data.
2450         (tui_data_window::rerender): Remove old implementation.
2451
2452 2019-08-30  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2455         text.
2456         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2457
2458 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2459             Sergio Durigan Junior  <sergiodj@redhat.com>
2460
2461         PR win32/24284
2462         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2463
2464 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2465
2466         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2467         when searching for types.
2468
2469 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * f-lang.c (f_language_defn): Use f_print_typedef.
2472         * f-lang.h (f_print_typedef): Declare.
2473         * f-typeprint.c (f_print_typedef): Define.
2474
2475 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2476
2477         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2478
2479 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * cli/cli-utils.c (info_print_options_defs): Delete.
2482         (make_info_print_options_def_group): Delete.
2483         (extract_info_print_options): Delete.
2484         (info_print_command_completer): Delete.
2485         (info_print_args_help): Add extra parameter, and optionally
2486         include text about -n flag.
2487         * cli/cli-utils.h (struct info_print_options): Delete.
2488         (extract_info_print_options): Delete declaration.
2489         (info_print_command_completer): Delete declaration.
2490         (info_print_args_help): Add extra parameter, extend header
2491         comment.
2492         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2493         search_symbols.
2494         * stack.c (struct info_print_options): New type.
2495         (info_print_options_defs): New file scoped variable.
2496         (make_info_print_options_def_group): New static function.
2497         (info_print_command_completer): New static function.
2498         (info_locals_command): Update to use new local functions.
2499         (info_args_command): Likewise.
2500         (_initialize_stack): Add extra parameter to calls to
2501         info_print_args_help.
2502         * symtab.c (search_symbols): Add extra parameter, use this to
2503         possibly excluse non-debug symbols.
2504         (symtab_symbol_info): Add extra parameter, which is passed on to
2505         search_symbols.
2506         (struct info_print_options): New type.
2507         (info_print_options_defs): New file scoped variable.
2508         (make_info_print_options_def_group): New static function.
2509         (info_print_command_completer): New static function.
2510         (info_variables_command): Update to use local functions, and pass
2511         extra parameter through to symtab_symbol_info.
2512         (info_functions_command): Likewise.
2513         (info_types_command): Pass additional argument through to
2514         symtab_symbol_info.
2515         (rbreak_command): Pass extra argument to search_symbols.
2516         (_initialize_symtab): Add extra arguments for calls to
2517         info_print_args_help, and update help text for 'info variables',
2518         'whereis', and 'info functions' commands.
2519         * symtab.h (search_symbols): Add extra argument to declaration.
2520         * NEWS: Mention new flags.
2521
2522 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2523
2524         * symtab.c (lookup_static_symbol): Call the new function (and move
2525         it down to be next to lookup_global_symbol).
2526         (struct global_sym_lookup_data): Add block_enum member and rename to...
2527         (struct global_or_static_sym_lookup_data): ...this.
2528         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2529         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2530         (lookup_symbol_global_or_static_iterator_cb): ...this.
2531         (lookup_global_or_static_symbol): New function.
2532         (lookup_global_symbol): Call new function.
2533
2534 2019-08-26  Tom de Vries  <tdevries@suse.de>
2535
2536         PR c++/24852
2537         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2538         when pc_probe.prob == NULL.
2539
2540 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2541
2542         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2543         variable symbol_linkage to symbol_linkage_.
2544
2545 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2546
2547         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2548         represent whether the symbol is static, dynamic, or we don't
2549         know.
2550
2551 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2552
2553         * gdb/rx-tdep.c (rx_register_names): New.
2554         (rx_register_name): Delete.
2555         (rx_psw_type): Delete.
2556         (rx_fpsw_type): Delete.
2557         (rx_register_type): Delete.
2558         (rx_gdbarch_init): Convert target-descriptions.
2559         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2560         * gdb/features/Makefile: Add rx.xml.
2561         * gdb/features/rx.xml: New.
2562         * gdb/features/rx.c: Generated.
2563         * gdb/NEWS: Mention target description support.
2564
2565 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2566
2567         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2568         *slot_ptr.
2569
2570 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2571
2572         * configure.ac: Don't check for 'dlfcn.h' (moved to
2573         gdbsupport/common.m4).
2574         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2575         'gdbsupport/'.
2576         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2577         * compile/compile-c-support.c: Include
2578         'gdbsupport/gdb-dlfcn.h'.
2579         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2580         * gdb-dlfcn.c: Move to...
2581         * gdbsupport/gdb-dlfcn.c: ... here.
2582         * gdb-dlfcn.h: Move to...
2583         * gdbsupport/gdb-dlfcn.h: ... here.
2584
2585 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2586
2587         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2588         the offset field signed.
2589
2590 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2591
2592         * python/lib/gdb/__init__.py (_execute_file): New function.
2593         * python/python.c (python_run_simple_file): Call gdb._execute_file
2594         on Windows.
2595
2596 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2597
2598         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2599         all uses as this was never set to anything but a zero value.
2600
2601 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2602
2603         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2604
2605 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2606
2607         * tui/tui-data.h (tui_gen_win_info): Add an =default
2608         move constructor, required by some GCC versions.
2609
2610 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2611
2612         * go32-nat.c (go32_sysinfo): Add hygon_p.
2613
2614 2019-08-20  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2617         line_from_reg_element_no, first_reg_element_no_inline,
2618         display_all_data, delete_data_content_windows,
2619         erase_data_content>: Now private.
2620
2621 2019-08-20  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2624         (tui_unhighlight_win, tui_highlight_win)
2625         (tui_win_info::make_window): Update.
2626         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2627
2628 2019-08-20  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2631         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2632         (MAX_PID_WIDTH): Move to tui-stack.c.
2633         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2634         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2635         (MAX_PID_WIDTH): Move from tui-data.h.
2636
2637 2019-08-20  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2640         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2641         (box_win): Update.
2642         (tui_gen_win_info::make_window): Rename from tui_make_window.
2643         (tui_win_info::make_window): New method.
2644         (tui_gen_win_info::make_visible): Update.
2645         * tui/tui-source.c (tui_source_window::set_contents): Update.
2646         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2647         (tui_data_window::display_registers_from): Update.
2648         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2649         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2650         Declare.
2651         <can_box>: Remove.
2652         <title>: Remove.
2653         (struct tui_win_info) <make_window>: Declare.
2654         <can_box>: Now virtual.
2655         <title>: New member.
2656         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2657         * tui/tui-command.c (tui_cmd_window::resize): Update.
2658
2659 2019-08-20  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2662         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2663         (tui_data_window::check_register_values): Update.
2664
2665 2019-08-20  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-regs.h (struct tui_data_window): Use
2668         DISABLE_COPY_AND_ASSIGN.
2669         <regs_content>: Change type, removing unique_ptr.
2670         <tui_data_window>: Add move constructor.
2671         * tui/tui-regs.c (tui_data_window::show_registers)
2672         (tui_data_window::show_register_group)
2673         (tui_data_window::display_registers_from)
2674         (tui_data_window::display_registers_from)
2675         (tui_data_window::first_data_item_displayed)
2676         (tui_data_window::delete_data_content_windows)
2677         (tui_data_window::rerender, tui_data_window::refresh_window)
2678         (tui_data_window::check_register_values): Update.
2679
2680 2019-08-20  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2683         show_register_group>: Declare.
2684         (tui_show_register_group): Don't declare.
2685         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2686         tui_show_registers.
2687         (tui_data_window::show_register_group): Rename from
2688         tui_show_register_group.
2689         (tui_data_window::check_register_values, tui_reg_command):
2690         Update.
2691         * tui/tui-layout.c (tui_set_layout): Update.
2692
2693 2019-08-20  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2696         Declare.
2697         (tui_check_register_values): Don't declare.
2698         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2699         from tui_check_register_values.
2700         * tui/tui-hooks.c (tui_register_changed): Update.
2701
2702 2019-08-20  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-regs.c (tui_reg_layout): Move later.
2705         (tui_show_registers): Don't enable TUI mode or change layout.
2706
2707 2019-08-20  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-regs.h (struct tui_data_item_window)
2710         <~tui_data_item_window>: Remove.
2711         <content>: Now a unique_xmalloc_ptr.
2712         * tui/tui-regs.c (tui_register_format): Return a
2713         unique_xmalloc_ptr.
2714         (tui_get_register): Update.
2715         (~tui_data_item_window): Remove.
2716         (tui_data_window::display_registers_from, tui_display_register):
2717         Update.
2718         * tui/tui-io.h (tui_expand_tabs): Update.
2719         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2720         Remove "col" parameter.
2721
2722 2019-08-20  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2725         field.
2726         * tui/tui-regs.c (~tui_data_item_window): Update.
2727
2728 2019-08-20  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2731         earlier.
2732
2733 2019-08-20  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2736
2737 2019-08-20  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-source.h (struct tui_source_window): Update.
2740         * tui/tui-regs.c (tui_show_registers): Update.
2741         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2742         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2743         (NO_REGS_STRING): Remove defines.
2744
2745 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2746
2747         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2748         unnecessary thread walk if remote doesn't support the packet.
2749
2750 2019-08-19  Tom Tromey  <tromey@adacore.com>
2751
2752         * python/py-value.c (value_has_field): Fix indentation.
2753
2754 2019-08-19  Tom Tromey  <tromey@adacore.com>
2755
2756         * printcmd.c (do_one_display, info_display_command): Update.
2757         * block.h (contained_in): Return bool.  Add allow_nested
2758         parameter.
2759         * block.c (contained_in): Return bool.  Add allow_nested
2760         parameter.
2761
2762 2019-08-19  Tom Tromey  <tom@tromey.com>
2763
2764         * configure: Rebuild.
2765         * configure.ac: Disallow the combination of -static-libstdc++ and
2766         source highlight.
2767         * source-cache.c (get_language_name): Handle rust.
2768         (source_cache::get_source_lines): Ignore highlighting exceptions.
2769
2770 2019-08-16  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2773         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2774         (struct tui_source_window_base) <make_visible, refresh_window,
2775         resize>: Remove methods.
2776         <execution_info>: Remove field.
2777         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2778         (tui_show_source_line, tui_source_window_base)
2779         (~tui_source_window_base): Update.
2780         (tui_source_window_base::resize)
2781         (tui_source_window_base::make_visible)
2782         (tui_source_window_base::refresh_window): Remove.
2783         (tui_source_window_base::update_exec_info): Update.
2784         * tui/tui-source.c (tui_source_window::set_contents): Update.
2785         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2786
2787 2019-08-16  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2790         deprecated_query_hook.
2791
2792 2019-08-16  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2795         (tui_update_source_windows_with_line): Update.
2796         * tui/tui-source.h (struct tui_source_window)
2797         <show_symtab_source>: Declare.
2798         (tui_show_symtab_source): Don't declare.
2799         * tui/tui-source.c (tui_show_symtab_source): Rename from
2800         tui_show_symtab_source.
2801
2802 2019-08-16  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-winsource.h (struct tui_source_window_base)
2805         <set_contents>: Declare.
2806         * tui/tui-winsource.c
2807         (tui_source_window_base::update_source_window_as_is): Update.
2808         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2809         Declare.
2810         (tui_set_source_content): Don't declare.
2811         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2812         tui_set_source_content.
2813         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2814         Declare.
2815         (tui_set_disassem_content): Don't declare.
2816         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2817         tui_set_disassem_content.
2818
2819 2019-08-16  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-winsource.h (struct tui_source_window_base)
2822         <update_breakpoint_info>: Declare.
2823         (tui_update_breakpoint_info): Don't declare.
2824         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2825         (tui_update_all_breakpoint_info): Update.
2826         (tui_source_window_base::update_breakpoint_info): Rename from
2827         tui_update_breakpoint_info.
2828         (tui_source_window_base::update_exec_info): Update.
2829
2830 2019-08-16  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-winsource.h (struct tui_source_window_base)
2833         <update_source_window>: Declare.
2834         (tui_update_source_window): Don't declare.
2835         * tui/tui-winsource.c
2836         (tui_source_window_base::update_source_window): Rename from
2837         tui_update_source_window.
2838         (tui_source_window_base::rerender): Update.
2839         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2840         * tui/tui-disasm.c (tui_show_disassem)
2841         (tui_show_disassem_and_update_source)
2842         (tui_disasm_window::maybe_update): Update.
2843
2844 2019-08-16  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-winsource.h (struct tui_source_window_base)
2847         <update_source_window_as_is>: Declare.
2848         (tui_update_source_window_as_is): Don't declare.
2849         * tui/tui-winsource.c (tui_update_source_window): Update
2850         (tui_source_window_base::update_source_window_as_is): Rename from
2851         tui_update_source_window_as_is.
2852         (tui_source_window_base::refill): Update.
2853         * tui/tui-source.c (tui_show_symtab_source): Update.
2854         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2855         Update.
2856
2857 2019-08-16  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-winsource.h (tui_update_source_window)
2860         (tui_update_source_window_as_is): Remove "noerror" parameter.
2861         * tui/tui-winsource.c (tui_update_source_window)
2862         (tui_update_source_window_as_is): Remove "noerror" parameter.
2863         (tui_update_source_windows_with_addr)
2864         (tui_update_source_windows_with_line)
2865         (tui_source_window_base::rerender)
2866         (tui_source_window_base::refill): Update.
2867         * tui/tui-source.h (tui_set_source_content)
2868         (tui_show_symtab_source): Remove "noerror" parameter.
2869         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2870         parameter.
2871         (tui_show_symtab_source): Likewise.
2872         (tui_source_window::maybe_update): Update.
2873         * tui/tui-disasm.c (tui_show_disassem)
2874         (tui_show_disassem_and_update_source)
2875         (tui_disasm_window::do_scroll_vertical)
2876         (tui_disasm_window::maybe_update): Update.
2877
2878 2019-08-16  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui.c (tui_is_window_visible): Update.
2881         * tui/tui-wingeneral.c (tui_make_window)
2882         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2883         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2884         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2885         (tui_set_win_height_command, parse_scrolling_args): Update.
2886         * tui/tui-source.c (tui_source_window::style_changed): Update.
2887         * tui/tui-regs.c (tui_show_registers)
2888         (tui_data_window::first_data_item_displayed)
2889         (tui_data_window::delete_data_content_windows)
2890         (tui_check_register_values, tui_reg_command): Update.
2891         * tui/tui-disasm.c (tui_show_disassem): Update.
2892         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2893         method.
2894         <is_visible>: Remove field.
2895         * tui/tui-data.c (tui_next_win, tui_prev_win)
2896         (tui_delete_invisible_windows): Update.
2897
2898 2019-08-16  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-winsource.h (struct tui_source_window_base)
2901         <m_has_locator>: Remove.
2902         * tui/tui-layout.c (show_source_disasm_command, show_data)
2903         (show_source_or_disasm_and_command): Update.
2904
2905 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * NEWS (Other MI changes): New subsection.
2908         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2909         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2910         * arch-utils.c (default_get_pc_address_flags): New function.
2911         * arch-utils.h (default_get_pc_address_flags): New declaration.
2912         * gdbarch.sh: Add get_pc_address_flags.
2913         * gdbarch.c: Regenerate.
2914         * gdbarch.h: Likewise.
2915         * stack.c (print_pc): New function.
2916         (print_frame_info) (print_frame): Call print_pc.
2917
2918 2019-08-16  Tom de Vries  <tdevries@suse.de>
2919
2920         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2921         print_objfile_section_info.
2922
2923 2019-08-15  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2926         calling update_cmdwin_start_line.
2927         * tui/tui-winsource.h (struct tui_source_window_base)
2928         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2929         <rerender>: Declare.
2930         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2931         Call rerender.
2932         (tui_source_window_base::set_new_height): Remove.
2933         (tui_source_window_base::rerender): Rename from
2934         do_make_visible_with_new_height.
2935         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2936         resize method.
2937         (tui_win_info::make_invisible_and_set_new_height)
2938         (tui_win_info::make_visible_with_new_height): Remove.
2939         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2940         Declare.
2941         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2942         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2943         do_make_visible_with_new_height>: Don't declare.
2944         <rerender>: Declare.
2945         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2946         set_new_height.
2947         (tui_data_window::do_make_visible_with_new_height): Remove.
2948         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2949         call tui_show_locator_content.
2950         (tui_gen_win_info::resize): Call rerender.
2951         (show_source_or_disasm_and_command): Don't call
2952         tui_show_locator_content.
2953         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2954         method.
2955         (struct tui_win_info) <rerender>: Declare.
2956         <set_new_height, make_invisible_and_set_new_height,
2957         make_visible_with_new_height>: Don't declare.
2958         * tui/tui-data.c (tui_win_list::rerender): New method.
2959         * tui/tui-command.h (struct tui_cmd_window)
2960         <do_make_visible_with_new_height>: Don't declare.
2961         * tui/tui-command.c
2962         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2963
2964 2019-08-15  Tom Tromey  <tromey@adacore.com>
2965
2966         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2967         * ada-lang.c (ada_enum_name): Likewise.
2968
2969 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2970
2971         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2972         leading underscore.
2973         (GdbOutputErrorFile): Likewise.
2974         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2975         accordingly.
2976         (execute_unwinders): Rename to have a leading underscore.
2977         (auto_load_packages): Likewise.
2978         (global scope): Adjust call to auto_load_packages accordingly.
2979         (GdbSetPythonDirectory): Likewise.
2980         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2981         instead of execute_unwinders.
2982
2983 2019-08-15  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2986         (show_data): Don't change window visibility.
2987         (tui_gen_win_info::resize): Remove special case for command
2988         window.  Use wresize, when available.
2989         (show_source_or_disasm_and_command): Don't change window
2990         visibility.
2991         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2992         <make_visible>: New method.
2993         * tui/tui-command.c (tui_cmd_window::resize): New method.
2994
2995 2019-08-15  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2998         (struct tui_source_windows): New.
2999         * tui/tui-winsource.c (tui_display_main): Update.
3000         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3001         (new_height_ok, parse_scrolling_args): Update.
3002         * tui/tui-layout.c (show_layout, show_data): Update.
3003         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3004         (tui_add_to_source_windows): Don't declare.
3005         * tui/tui-data.c (source_windows, tui_source_windows)
3006         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3007
3008 2019-08-15  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3011         Rename from reset.
3012         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3013         * tui/tui-layout.c (show_source_disasm_command, show_data):
3014         Update.
3015         (tui_gen_win_info::resize): Rename.
3016         (show_source_or_disasm_and_command): Update.
3017         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3018         reset.
3019
3020 2019-08-15  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3023         * tui/tui-interp.c (tui_interp::init): Don't call
3024         tui_initialize_static_data.
3025         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3026
3027 2019-08-15  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3030         examine tui_win_list.
3031
3032 2019-08-15  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3035         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3036         tui_clear_source_content.
3037         (tui_clear_source_content): Remove.
3038         (tui_source_window_base::do_erase_source_content): Hoist call to
3039         content.clear().
3040         * tui/tui-stack.c (tui_show_frame_info): Don't call
3041         tui_clear_source_content.
3042
3043 2019-08-15  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-winsource.h (struct tui_source_window_base)
3046         <do_erase_source_content>: New method.
3047         <erase_source_content>: New method.
3048         (tui_erase_source_content): Don't declare.
3049         * tui/tui-winsource.c (tui_clear_source_content): Update.
3050         (tui_source_window_base::do_erase_source_content): Rename from
3051         tui_erase_source_content.
3052         (tui_source_window_base::show_source_content): Update.
3053         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3054         * tui/tui-source.h (struct tui_source_window)
3055         <erase_source_content>: New method.
3056         * tui/tui-disasm.h (struct tui_disasm_window)
3057         <erase_source_content>: New method.
3058
3059 2019-08-15  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3062         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3063         constructor.
3064         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3065         * tui/tui-source.c (tui_set_source_content): Update.
3066         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3067
3068 2019-08-15  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3071         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3072         tui-source.c.
3073         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3074         Declare.
3075         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3076         method.
3077         (tui_source_window::maybe_update): Update.
3078
3079 2019-08-15  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3082         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3083         tui-disasm.c.
3084         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3085         Declare.
3086         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3087         method.
3088         (tui_disasm_window::maybe_update): Update.
3089
3090 2019-08-15  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-winsource.h (struct tui_source_window_base)
3093         <maybe_update>: Declare.
3094         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3095         method.
3096         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3097         Declare.
3098         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3099         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3100         Declare.
3101         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3102
3103 2019-08-15  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3106
3107 2019-08-15  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-wingeneral.c: Include tui-stack.h.
3110         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3111         (struct tui_locator_window): Move from tui-data.h.
3112         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3113         (tui_initialize_static_data): Move from tui-data.c.
3114         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3115         (struct tui_locator_window): Move to tui-stack.c.
3116         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3117         (tui_initialize_static_data): Move to tui-stack.c.
3118
3119 2019-08-15  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-layout.c (show_source_disasm_command)
3122         (show_source_or_disasm_and_command): Use make_visible method, not
3123         tui_make_window.
3124         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3125         Remove.
3126
3127 2019-08-15  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-wingeneral.h (tui_make_window): Update.
3130         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3131         parameter.
3132         (tui_gen_win_info::make_visible): Update.
3133         * tui/tui-regs.c (tui_data_window::display_registers_from):
3134         Update.
3135         * tui/tui-layout.c (show_source_disasm_command)
3136         (show_source_or_disasm_and_command): Update.
3137         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3138         (enum tui_box): Remove.
3139         (struct tui_win_info) <can_box>: New method.
3140         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3141         method.
3142
3143 2019-08-15  Tom de Vries  <tdevries@suse.de>
3144
3145         * linux-nat-trad.c: Include gdbarch.h.
3146
3147 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3148
3149         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3150         register sizes.
3151
3152 2019-08-14  Tom Tromey  <tromey@adacore.com>
3153
3154         * darwin-nat.c: Include gdbarch.h.
3155         * darwin-nat-info.c: Include gdbarch.h.
3156
3157 2019-08-13  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3160         Remove.
3161         * tui/tui-data.c (tui_initialize_static_data): Update.
3162
3163 2019-08-13  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-winsource.h (struct tui_exec_info_window)
3166         <~tui_exec_info_window, maybe_allocate_content, get_content,
3167         m_content>: Remove.
3168         (struct tui_source_window_base) <set_exec_info_content,
3169         show_exec_info_content>: Don't declare.
3170         * tui/tui-winsource.c
3171         (tui_exec_info_window::maybe_allocate_content): Remove.
3172         (tui_source_window_base::update_exec_info): Rename from
3173         set_exec_info_content.
3174         (tui_source_window_base::show_exec_info_content)
3175         (tui_source_window_base::update_exec_info): Remove.
3176
3177 2019-08-13  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3180         declare.
3181         * tui/tui-winsource.c (tui_update_source_window_as_is)
3182         (tui_update_source_windows_with_addr, tui_erase_source_content):
3183         Update.
3184         (tui_clear_exec_info_content): Remove.
3185
3186 2019-08-13  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3189         declare.
3190         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3191         call tui_erase_exec_info_content.
3192         (tui_clear_exec_info_content): Rename from
3193         tui_erase_exec_info_content.
3194         (tui_clear_exec_info_content): Delete.
3195
3196 2019-08-13  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-winsource.h (struct tui_source_window_base)
3199         <show_exec_info_content>: Declare.
3200         (tui_show_exec_info_content): Don't declare.
3201         * tui/tui-winsource.c
3202         (tui_source_window_base::show_exec_info_content): Rename from
3203         tui_show_exec_info_content.
3204         (tui_source_window_base::update_exec_info): Update.
3205
3206 2019-08-13  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3209         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3210         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3211         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3212         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3213         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3214         ... here.
3215
3216 2019-08-13  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-winsource.h (struct tui_source_window_base)
3219         <update_exec_info>: Declare.
3220         (tui_update_exec_info): Don't declare.
3221         * tui/tui-winsource.c (tui_update_source_window_as_is)
3222         (tui_source_window_base::refresh_all)
3223         (tui_update_all_breakpoint_info): Update.
3224         (tui_source_window_base::update_exec_info): Rename from
3225         tui_update_exec_info.
3226         * tui/tui-stack.c (tui_show_frame_info): Update.
3227
3228 2019-08-13  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-winsource.h (struct tui_source_window_base)
3231         <set_exec_info_content>: Declare.
3232         (tui_set_exec_info_content): Don't declare.
3233         * tui/tui-winsource.c
3234         (tui_source_window_base::set_exec_info_content): Rename from
3235         tui_set_exec_info_content.
3236         (tui_update_exec_info): Update.
3237
3238 2019-08-13  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-winsource.h (struct tui_source_window_base)
3241         <show_source_content>: Declare.
3242         (tui_show_source_content): Don't declare.
3243         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3244         (tui_source_window_base::show_source_content): Rename from
3245         tui_show_source_content.
3246         (tui_source_window_base::refresh_all): Update.
3247         * tui/tui-layout.c (show_source_disasm_command)
3248         (show_source_or_disasm_and_command): Update.
3249
3250 2019-08-13  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-winsource.c (tui_erase_source_content)
3253         (tui_show_source_content, tui_source_window_base::refresh_all):
3254         Update.
3255         * tui/tui-wingeneral.h
3256         (tui_check_and_display_highlight_if_needed): Don't declare.
3257         * tui/tui-wingeneral.c
3258         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3259         check_and_display_highlight_if_needed.
3260         * tui/tui-win.c (tui_rehighlight_all)
3261         (tui_win_info::make_visible_with_new_height): Update.
3262         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3263         (tui_data_window::erase_data_content)
3264         (tui_data_window::display_all_data): Update.
3265         * tui/tui-data.h (struct tui_win_info)
3266         <check_and_display_highlight_if_needed>: Declare.
3267
3268 2019-08-13  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-win.c (tui_resize_all): Call
3271         tui_delete_invisible_windows.
3272         * tui/tui-layout.c (show_layout): Call
3273         tui_delete_invisible_windows.
3274         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3275         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3276
3277 2019-08-13  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3280         tui_add_win_to_layout.
3281
3282 2019-08-13  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3285         * tui/tui-layout.c (tui_default_win_height): Now static.
3286
3287 2019-08-13  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3290         single switch.
3291         (show_source_disasm_command, show_source_or_disasm_and_command):
3292         Don't check current layout.
3293
3294 2019-08-13  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-wingeneral.c (make_all_visible): Remove.
3297         (tui_make_all_invisible): Simplify.
3298         * tui/tui-layout.c (tui_make_all_invisible): Move from
3299         tui-wingeneral.c; simplify.
3300         (show_layout): Hoist call to tui_make_all_invisible.
3301         (show_data): Don't call tui_make_all_invisible.
3302
3303 2019-08-13  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3306         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3307
3308 2019-08-13  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3311         tui-data.c.
3312         (show_source_disasm_command, show_data)
3313         (show_source_or_disasm_and_command): Don't use
3314         tui_set_current_layout_to.
3315         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3316         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3317         tui-layout.c.
3318         (tui_set_current_layout_to): Remove.
3319
3320 2019-08-13  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-layout.c (tui_set_layout): Update.
3323         * tui/tui-data.h (struct tui_layout_def): Remove.
3324         (tui_layout_def): Don't declare.
3325         * tui/tui-data.c (layout_def): Remove.
3326         (tui_layout_def): Remove.
3327
3328 2019-08-13  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-winsource.h (struct tui_source_window_base)
3331         <clear_detail>: No longer "override".
3332         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3333         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3334         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3335         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3336         Remove.
3337         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3338
3339 2019-08-13  Tom Tromey  <tromey@adacore.com>
3340
3341         * tracepoint.c: Don't include readline.h or history.h.
3342
3343 2019-08-12  Tom Tromey  <tom@tromey.com>
3344
3345         * configure: Rebuild.
3346         * configure.ac: Check for readline 7.
3347         * NEWS: Mention readline 7 requirement.
3348         * README: Update.
3349
3350 2019-08-12  Tom Tromey  <tom@tromey.com>
3351
3352         * mingw-hdep.c (gdb_select): Remove readline hack.
3353
3354 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3355
3356         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3357         when the function fails.
3358
3359 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3360
3361         * s390-tdep.c (s390_type_align): New function.
3362         (s390_gdbarch_init): Set it as type_align gdbarch method.
3363
3364 2019-08-09  Tom de Vries  <tdevries@suse.de>
3365
3366         PR gdb/24591
3367         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3368         pc_low with relocation offset.
3369
3370 2019-08-07  Tom Tromey  <tromey@adacore.com>
3371
3372         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3373         (print_frame_args): Update.
3374         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3375         Update.
3376         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3377         * frame.h (struct frame_arg): Add initializers.
3378         <error>: Now a unique_xmalloc_ptr.
3379
3380 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3381
3382         * NEWS: Expand the Pointer Authentication entry.
3383         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3384         (aarch64_frame_unmask_lr): ... to this.
3385         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3386         Call aarch64_frame_unmask_lr.
3387         * frame.c (struct frame_info): Add "masked" variable.
3388         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3389         (fprint_frame): Check for masked pc.
3390         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3391         declarations.
3392         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3393         * stack.c (print_frame): Check for masked pc.
3394
3395 2019-08-06  Tom Tromey  <tom@tromey.com>
3396
3397         * stabsread.c (patch_block_stabs, read_one_struct_field)
3398         (read_enum_type): Use obstack_strndup.
3399         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3400         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3401         * dwarf2read.c (guess_full_die_structure_name)
3402         (anonymous_struct_prefix): Use obstack_strndup.
3403         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3404         * c-exp.y (yylex): Use obstack_strndup.
3405         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3406         (write_var_or_type): Use obstack_strndup.
3407
3408 2019-08-06  Tom Tromey  <tom@tromey.com>
3409
3410         * symfile.c (reread_symbols): Use obstack_strdup.
3411         * stabsread.c (read_type): Use obstack_strdup.
3412         * gdb_obstack.h (obstack_strdup): New overload.
3413         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3414         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3415         (dwarf2_canonicalize_name): Use obstack_strdup.
3416         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3417         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3418         Use obstack_strdup.
3419
3420 2019-08-06  Tom Tromey  <tom@tromey.com>
3421
3422         * gdb_obstack.h (obstack_strdup): Define.
3423         * gdb_obstack.c (obstack_strdup): Don't define.
3424
3425 2019-08-06  Tom Tromey  <tom@tromey.com>
3426
3427         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3428         obstack_strdup.
3429         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3430         obstack_strdup.
3431         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3432         * stabsread.c (common_block_start): Use obstack_strdup.
3433         * objfiles.c (set_objfile_main_name, objfile): Use
3434         obstack_strdup.
3435         * namespace.c (add_using_directive): Use obstack_strdup.
3436         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3437         * jit.c (finalize_symtab): Use obstack_strdup.
3438         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3439         (guess_partial_die_structure_name, partial_die_info::fixup)
3440         (dwarf2_name): Use obstack_strdup.
3441         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3442         obstack_strdup.
3443         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3444         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3445         obstack_strdup.
3446         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3447
3448 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3449
3450         * unittests/help-doc-selftests.c: New file.
3451         * Makefile.in: Add the new file.
3452
3453 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3454
3455         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3456         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3457         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3458         the trailing '.' is not output, and the first character is uppercased.
3459         (print_help_for_command): Update call to print_doc_line.
3460         (print_doc_of_command): Likewise.
3461         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3462         * cli/cli-option.c (append_indented_doc): Do not append newline.
3463         (build_help_option): Append newline after first appended_indented_doc
3464         only if a second call is done.
3465         (build_help): Append 2 new lines before each option, except the first
3466         one.
3467         * compile/compile.c (_initialize_compile): Add new lines after
3468         %OPTIONS%, when not at the end of the help.
3469         Change help doc or code
3470         producing the help doc to respect the invariants.
3471         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3472         Also removed the new line after 'Options:', as all other commands
3473         do not put an empty line between 'Options:' and the first option.
3474         * printcmd.c (_initialize_printcmd): Likewise.
3475         * stack.c (_initialize_stack): Likewise.
3476         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3477         incorrectly telling COMMAND is optional.
3478         * ada-lang.c (_initialize_ada_language): Change help doc or code
3479         producing the help doc to respect the invariants.
3480         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3481         * breakpoint.c (_initialize_breakpoint): Likewise.
3482         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3483         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3484         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3485         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3486         _initialize_cli_style): Likewise.
3487         * corelow.c (core_target_info): Likewise.
3488         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3489         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3490         * filesystem.c (_initialize_filesystem): Likewise.
3491         * frame.c (_initialize_frame): Likewise.
3492         * gnu-nat.c (add_task_commands): Likewise.
3493         * infcall.c (_initialize_infcall): Likewise.
3494         * infcmd.c (_initialize_infcmd): Likewise.
3495         * interps.c (_initialize_interpreter): Likewise.
3496         * language.c (_initialize_language): Likewise.
3497         * linux-fork.c (_initialize_linux_fork): Likewise.
3498         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3499         * maint.c (_initialize_maint_cmds): Likewise.
3500         * memattr.c (_initialize_mem): Likewise.
3501         * printcmd.c (_initialize_printcmd): Likewise.
3502         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3503         _RegEx): Likewise.
3504         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3505         * record-btrace.c (_initialize_record_btrace): Likewise.
3506         * record-full.c (_initialize_record_full): Likewise.
3507         * record.c (_initialize_record): Likewise.
3508         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3509         * regcache.c (_initialize_regcache): Likewise.
3510         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3511         _initialize_remote): Likewise.
3512         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3513         * serial.c (_initialize_serial): Likewise.
3514         * skip.c (_initialize_step_skip): Likewise.
3515         * source.c (_initialize_source): Likewise.
3516         * stack.c (_initialize_stack): Likewise.
3517         * symfile.c (_initialize_symfile): Likewise.
3518         * symtab.c (_initialize_symtab): Likewise.
3519         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3520         * top.c (init_main): Likewise.
3521         * tracefile-tfile.c (tfile_target_info): Likewise.
3522         * tracepoint.c (_initialize_tracepoint): Likewise.
3523         * tui/tui-win.c (_initialize_tui_win): Likewise.
3524         * utils.c (add_internal_problem_command): Likewise.
3525         * valprint.c (value_print_option_defs): Likewise.
3526
3527 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3528
3529         PR build/24886
3530         * configure.ac: Drop enable-libmcheck support.
3531         * configure, config.in: Rebuild.
3532         * libmcheck.m4: Remove.
3533         * acinclude.m4: Don't include it.
3534         * Makefile.in: Don't distribute it.
3535         * top.c (print_gdb_configuration): Don't mention it.
3536
3537 2019-08-06  Tom Tromey  <tom@tromey.com>
3538
3539         * utils.c (set_output_style): Sometimes pass stream to
3540         emit_style_escape.
3541         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3542         * record-btrace.c (btrace_insn_history): Update.
3543         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3544         method.
3545         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3546         Update initializers.
3547         <m_uiout>: New field.
3548         <m_di>: Move lower.
3549         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3550         Remove "uiout" parameter.
3551         (dump_insns): Update.
3552         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3553         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3554
3555 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3556
3557         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3558         (error_in_psymtab_expansion): Likewise.
3559         (lookup_symbol_via_quick_fns): Likewise.
3560         (basic_lookup_transparent_type_quick): Likewise.
3561         (basic_lookup_transparent_type_1): Likewise.
3562
3563 2019-08-06  Tom Tromey  <tromey@adacore.com>
3564
3565         * source.c (last_source_error): Now bool.
3566         (print_source_lines_base): Make "noprint" bool.  Only open
3567         source file when last_source_visited changes.
3568
3569 2019-08-06  Tom Tromey  <tromey@adacore.com>
3570
3571         * annotate.c (annotate_source_line): Use g_source_cache.
3572         * source-cache.c (source_cache::get_plain_source_lines): Change
3573         parameters.  Populate m_offset_cache.
3574         (source_cache::ensure): New method.
3575         (source_cache::get_line_charpos): New method.
3576         (extract_lines): Move lower.  Change parameters.
3577         (source_cache::get_source_lines): Move lower.
3578         * source-cache.h (class source_cache): Update comment.
3579         <get_line_charpos>: New method.
3580         <get_source_lines>: Update comment.
3581         <clear>: Clear m_offset_cache.
3582         <get_plain_source_lines>: Change parameters.
3583         <ensure>: New method
3584         <m_offset_cache>: New member.
3585         * source.c (forget_cached_source_info_for_objfile): Update.
3586         (info_source_command): Use g_source_cache.
3587         (find_source_lines, open_source_file_with_line_charpos): Remove.
3588         (print_source_lines_base, search_command_helper): Use g_source_cache.
3589         * source.h (open_source_file_with_line_charpos): Don't declare.
3590         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3591         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3592         Use g_source_cache.
3593
3594 2019-08-06  Tom Tromey  <tromey@adacore.com>
3595
3596         * source-cache.c (source_cache::get_plain_source_lines):
3597         Remove "first_line" and "last_line" parameters.
3598         (source_cache::get_source_lines): Cache plain text.
3599         * source-cache.h (class source_cache)
3600         <get_plain_source_lines>: Update.
3601
3602 2019-08-06  Tom Tromey  <tromey@adacore.com>
3603
3604         * source-cache.c (extract_lines): No longer a method.
3605         Changed type of parameter.  Include final newline.
3606         (selftests::extract_lines_test): New function.
3607         (_initialize_source_cache): Likewise.
3608         * source-cache.h (class source_cache)
3609         <extract_lines>: Don't declare.
3610
3611 2019-08-06  Tom Tromey  <tromey@adacore.com>
3612
3613         * breakpoint.c (init_breakpoint_sal): Update.
3614         (breakpoint): Update.
3615         * breakpoint.h (struct breakpoint) <filter>: Now a
3616         unique_xmalloc_ptr.
3617
3618 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3619
3620         * NEWS: Mention dictionary access on blocks.
3621         * python/py-block.c (blpy_getitem): New function.
3622         (block_object_as_mapping): New struct.
3623         (block_object_type): Use new struct for tp_as_mapping field.
3624
3625 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3626
3627         * objfiles.h (objfile): Add a comment describing partial symbols.
3628
3629 2019-08-05  Tom Tromey  <tromey@adacore.com>
3630
3631         * compile/compile.c (_initialize_compile): Use _(), not N_().
3632         * thread.c (_initialize_thread): Use _(), not N_().
3633         * stack.c (_initialize_stack): Use _(), not N_().
3634         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3635
3636 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3637
3638         * dwarf2read.c (struct dw2_symtab_iterator):
3639         <want_specific_block>: Remove.
3640         <block_index>: Change type to gdb::optional.
3641         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3642         change type of BLOCK_INDEX parameter to gdb::optional.
3643         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3644         (dw2_lookup_symbol): Don't pass argument for
3645         WANT_SPECIFIC_BLOCK.
3646         (dw2_expand_symtabs_for_function): Don't pass argument for
3647         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3648         (class dw2_debug_names_iterator)
3649         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3650         parameter, change BLOCK_INDEX type to gdb::optional.
3651         <m_want_specific_block>: Remove.
3652         <m_block_index>: Change type to gdb::optional.
3653         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3654         gdb::optional.  Re-write in function of gdb::optional.
3655         (dw2_debug_names_lookup_symbol): Don't pass argument for
3656         WANT_SPECIFIC_BLOCK.
3657         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3658         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3659         BLOCK_INDEX.
3660
3661 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3662
3663         * NEWS: Mention changes to "info sources" command.
3664
3665 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3666
3667         * symtab.c (filename_partial_match_opts): New struct type.
3668         (struct output_source_filename_data): New members
3669         regexp, c_regexp, partial_match.
3670         (output_source_filename): Use new members to decide to print file.
3671         (info_sources_option_defs): New variable.
3672         (make_info_sources_options_def_group, print_info_sources_header,
3673         info_sources_command_completer):
3674         New functions.
3675         (info_sources_command): Read new optional arguments.
3676         (_initialize_symtab): Update info sources help.
3677
3678 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3679
3680         * ada-lang.c (exception_support_info_v0): Renamed from...
3681         (default_exception_support_info): ... this.  Create new
3682         definition for v1.
3683         (ada_has_this_exception_support): Look up catch_handlers_sym.
3684         (ada_exception_support_info_sniffer): Try v0 after default.
3685
3686 2019-08-01  Tom Tromey  <tromey@adacore.com>
3687
3688         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3689         gdbarch.h.
3690
3691 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3692
3693         * s12z-tdep.c: Fix include path for s12z-opc.h.
3694
3695 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3696
3697         * NEWS: Require GNU make 3.82.
3698
3699 2019-07-16  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3702         declare.
3703
3704 2019-07-30  Tom Tromey  <tromey@adacore.com>
3705
3706         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3707
3708 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3709
3710         * printcmd.c (print_address_symbolic): Print negative offsets.
3711         (build_address_symbolic): Force signed arithmetic when computing
3712         offset.
3713
3714 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3715
3716         PR/24474: Add a function to lookup static variables.
3717         * NEWS: Mention this new function.
3718         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3719         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3720         * python/python.c (python_GdbMethods): Add new function.
3721
3722 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3723
3724         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3725         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3726         (objfpy_lookup_static_symbol): New function.
3727         (objfile_object_methods): Add new functions.
3728
3729 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3730
3731         * NEWS: Mention 'set|show print frame-info'.  Mention new
3732         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3733         backtrace argument.  Mention that python frame filtering code
3734         is now consistent with what 'backtrace' command prints.
3735
3736 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3737
3738         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3739         comments.
3740         (print_frame_info_auto, print_frame_info_source_line,
3741         print_frame_info_location, print_frame_info_source_and_location,
3742         print_frame_info_location_and_address, print_frame_info_short_location):
3743         New declarations.
3744         (struct frame_print_options): New member print_frame_info.
3745         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3746         * stack.h (get_user_print_what_frame_info): New declaration.
3747         (frame_show_address): New declaration.
3748         * stack.c (print_frame_arguments_choices): New value 'presence'.
3749         (print_frame_info_auto, print_frame_info_source_line,
3750         print_frame_info_location, print_frame_info_source_and_location,
3751         print_frame_info_location_and_address, print_frame_info_short_location,
3752         print_frame_info_choices, print_frame_info_print_what): New definitions.
3753         (print_frame_args): Only print dots for args if print frame-arguments
3754         is 'presence'.
3755         (frame_print_option_defs): New element for "frame-info".
3756         (get_user_print_what_frame_info): New function.
3757         (frame_show_address): Make non static.  Move comment to stack.h.
3758         (print_frame_info_to_print_what): New function.
3759         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3760         to decide what to print.
3761         (backtrace_command_1): Handle the new print_frame_arguments_presence
3762         value.
3763         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3764         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3765         (py_print_frame): In non-mi mode, use LOCATION as default for
3766         print_what, similarly to frame information printed directly by
3767         backtrace command. Handle frame-info user option in non MI mode.
3768
3769 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3770
3771         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3772         Add case for debugging 32-bit target on 64-bit host.  Revise
3773         comment.
3774
3775 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3776
3777         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3778         instead of find_function_entry_range_from_pc.
3779
3780 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3781
3782         * stack.c (find_frame_funname): Remove code which preferred
3783         minsym over symtab sym in "certain pathological cases".
3784
3785         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3786         parameter.  Change type of "do_demangle" to bool.
3787         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3788         Pass suitable "prefer_sym_over_minsym" flag to
3789         build_address_symbolic().  Don't output "+" for negative offsets.
3790         * printcmd.c (print_address_symbolic): Update invocation of
3791         build_address_symbolic to include a "prefer_sym_over_minsym"
3792         flag.
3793         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3794         Restrict cases in which use of minimal symbol is preferred to that
3795         of a found symbol.  Update comments.
3796
3797         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3798         for entry pc when entry pc is out of range for that FDE.
3799
3800 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3801
3802         PR gdb/24839:
3803         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3804         type.
3805
3806 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3807
3808         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3809         this function's Python signature.
3810
3811
3812 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3813
3814         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3815         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3816         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3817         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3818         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3819
3820
3821 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3822
3823         * h8300-tdep.c (h8300_register_name_common): New.
3824         h8300_register_name): Use h8300_register_name_common.
3825         (h8300s_register_name): Likewise.
3826         (h8300sx_register_name): Likewise.
3827         (h8300h_register_nam): New.
3828         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3829
3830
3831 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3832
3833         * arm-tdep.c (arm_skip_cmse_entry): New function.
3834         (arm_is_sgstubs_section): New function.
3835         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3836
3837 2019-07-22  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3840         Don't self-assign.
3841
3842 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3845         type_print.
3846
3847 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3850         so that GDB doesn't match any msymbols when searching in the
3851         TYPES_DOMAIN.
3852         (print_symbol_info): Print using typedef_print or type_print based
3853         on the type of the symbol.  Add updated FIXME comment moved from...
3854         (_initialize_symtab): ... move and update FIXME comment to above.
3855
3856 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * NEWS: Mention adding -q option to "info types".
3859         * symtab.c (struct info_types_options): New struct.
3860         (info_types_options_defs): New variable.
3861         (make_info_types_options_def_group): New function.
3862         (info_types_command): Use gdb::option framework to parse options.
3863         (info_types_command_completer): New function.
3864         (_initialize_symtab): Extend the help text on "info types" and
3865         register command completer.
3866
3867 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3868
3869         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3870         (lookup_symbol_in_objfile): Change int to block_enum and add a
3871         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3872
3873 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3874
3875         * MAINTAINERS (Write After Approval): Add self.
3876
3877 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3880         instruction to the dummy code region.
3881
3882 2019-07-19  Tom Tromey  <tromey@adacore.com>
3883
3884         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3885         (ARGSUSED, PARAMS, __func__): Remove rules.
3886
3887 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3888
3889         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3890         * features/arm/arm-with-iwmmxt.c: Remove.
3891         * features/arm/arm-with-iwmmxt.xml: Remove.
3892         * features/arm/arm-with-m-fpa-layout.c: Remove.
3893         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3894         * features/arm/arm-with-m-vfp-d16.c: Remove.
3895         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3896         * features/arm/arm-with-m.c: Remove.
3897         * features/arm/arm-with-m.xml: Remove.
3898         * features/arm/arm-with-neon.c: Remove.
3899         * features/arm/arm-with-neon.xml: Remove.
3900         * features/arm/arm-with-vfpv2.c: Remove.
3901         * features/arm/arm-with-vfpv2.xml: Remove.
3902         * features/arm/arm-with-vfpv3.c: Remove.
3903         * features/arm/arm-with-vfpv3.xml: Remove.
3904
3905 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3906
3907         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3908
3909 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3910
3911         * arch/aarch32.c (aarch32_create_target_description): Create
3912         target descriptions using features.
3913         * arch/arm.c (arm_create_target_description)
3914         (arm_create_mprofile_target_description): Likewise.
3915         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3916
3917 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3918
3919         * Makefile.in: Add new files.
3920         * aarch32-tdep.c: New file.
3921         * aarch32-tdep.h: New file.
3922         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3923         Call aarch32_read_description.
3924         * arch/aarch32.c: New file.
3925         * arch/aarch32.h: New file.
3926         * arch/arm.c (arm_create_target_description)
3927         (arm_create_mprofile_target_description): New function.
3928         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3929         (arm_create_target_description)
3930         (arm_create_mprofile_target_description): New declaration.
3931         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3932         read_description functions.
3933         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3934         Likewise.
3935         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3936         * arm-tdep.c (tdesc_arm_list): New variable.
3937         (arm_register_g_packet_guesses): Call create description functions.
3938         (arm_read_description) (arm_read_mprofile_description): New
3939         function.
3940         * arm-tdep.h (arm_read_description)
3941         (arm_read_mprofile_description): Add declaration.
3942         * configure.tgt: Add new files.
3943
3944 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3945
3946         * top.c (new_ui_command): Open specified terminal just once.
3947
3948 2019-07-18  Tom Tromey  <tromey@adacore.com>
3949
3950         * symtab.c (main_name): Constify return type.
3951         * symfile.c (set_initial_language): Update.
3952         * symtab.h (main_name): Constify return type.
3953
3954 2019-07-17  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-winsource.c (tui_update_source_window)
3957         (tui_update_source_window_as_is)
3958         (tui_update_source_windows_with_line): Remove return.
3959         * tui/tui-disasm.c (tui_show_disassem)
3960         (tui_show_disassem_and_update_source): Remove return.
3961         * tui/tui.c (tui_reset): Remove return.
3962         * tui/tui-wingeneral.c
3963         (tui_check_and_display_highlight_if_needed): Remove return.
3964
3965 2019-07-17  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3968
3969 2019-07-17  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-winsource.h (struct tui_exec_info_window)
3972         (struct tui_source_window_base): Move from tui-data.h.
3973         * tui/tui-winsource.c: Move many method definitions from
3974         elsewhere.  Remove "structuring" comments.
3975         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3976         (tui_source_window_base::refresh_window): Move to
3977         tui-winsource.c.
3978         * tui/tui-win.c (tui_source_window_base::refresh_all)
3979         (tui_source_window_base::update_tab_width)
3980         (tui_source_window_base::set_new_height)
3981         (tui_source_window_base::do_make_visible_with_new_height): Move to
3982         tui-winsource.c.
3983         * tui/tui-source.h: Update.
3984         * tui/tui-source.c (tui_source_window_base::reset): Move to
3985         tui-winsource.c.
3986         * tui/tui-disasm.h: Update.
3987         * tui/tui-data.h (struct tui_exec_info_window): Move to
3988         tui-winsource.h.
3989         (struct tui_source_window_base): Likewise.
3990         * tui/tui-data.c (tui_source_window_base::clear_detail)
3991         (tui_source_window_base, ~tui_source_window_base): Move to
3992         tui-winsource.c.
3993
3994 2019-07-17  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-win.c (tui_resize_all)
3997         (tui_source_window_base::update_tab_width)
3998         (tui_adjust_win_heights): Update.
3999         (tui_win_info::make_invisible_and_set_new_height): Rename from
4000         make_invisible_and_set_new_height.
4001         * tui/tui-data.h (struct tui_win_info)
4002         <make_invisible_and_set_new_height>: New method.
4003
4004 2019-07-17  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui.c: Update.
4007         * tui/tui-source.h (struct tui_source_window): Move from
4008         tui-data.h.
4009         * tui/tui-layout.c: Update.
4010         * tui/tui-disasm.c: Update.
4011         * tui/tui-data.h (struct tui_source_window): Move to
4012         tui-source.h.
4013
4014 2019-07-17  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4017         tui-data.h.
4018         * tui/tui-data.h (struct tui_disasm_window): Move to
4019         tui-disasm.h.
4020
4021 2019-07-17  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-regs.h (struct tui_data_item_window): Move from
4024         tui-data.h.
4025         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4026         * tui/tui-data.h (struct tui_data_item_window): Move to
4027         tui-regs.h.
4028         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4029
4030 2019-07-17  Tom Tromey  <tom@tromey.com>
4031
4032         * tui/tui.c: Update.
4033         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4034         (tui_cmd_window::max_height): Move to tui-command.c.
4035         * tui/tui-layout.c: Update.
4036         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4037         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4038         tui-command.c.
4039         * tui/tui-command.h (struct tui_cmd_window): Move from
4040         tui-data.h.
4041         * tui/tui-command.c: Remove "structuring" comments.
4042         (tui_cmd_window::clear_detail)
4043         (tui_cmd_window::do_make_visible_with_new_height)
4044         (tui_cmd_window::max_height): Move from elsewhere.
4045
4046 2019-07-17  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4049         Now static.
4050         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4051         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4052
4053 2019-07-17  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui.c: Update.
4056         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4057         tui-regs.c.
4058         * tui/tui-windata.h: Remove file.
4059         * tui/tui-windata.c: Remove file.
4060         * tui/tui-win.c (tui_data_window::set_new_height)
4061         (tui_data_window::do_make_visible_with_new_height): Move to
4062         tui-regs.c.
4063         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4064         * tui/tui-regs.c: Remove "structuring" comments.
4065         (tui_data_window::first_data_item_displayed)
4066         (tui_data_window::delete_data_content_windows)
4067         (tui_data_window::erase_data_content)
4068         (tui_data_window::display_all_data)
4069         (tui_data_window::refresh_all)
4070         (tui_data_window::do_scroll_vertical)
4071         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4072         (tui_data_window::do_make_visible_with_new_height)
4073         (tui_data_window::refresh_window): Move from elsewhere.
4074         (_initialize_tui_regs): Move to end of file.
4075         * tui/tui-layout.c: Update.
4076         * tui/tui-hooks.c: Update.
4077         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4078         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4079         tui-regs.c.
4080         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4081
4082 2019-07-17  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4085         seen.
4086
4087 2019-07-17  Tom Tromey  <tom@tromey.com>
4088
4089         * tui/tui-win.c (tui_source_window_base::set_new_height)
4090         (tui_source_window_base::do_make_visible_with_new_height): Use
4091         m_has_locator field directly.
4092         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4093         method.
4094         (struct tui_source_window_base) <has_locator>: Likewise.
4095
4096 2019-07-17  Tom Tromey  <tom@tromey.com>
4097
4098         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4099         Don't declare.
4100         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4101         Remove.
4102         * tui/tui-win.c (tui_source_window_base::set_new_height)
4103         (tui_source_window_base::set_new_height)
4104         (make_invisible_and_set_new_height)
4105         (tui_source_window_base::do_make_visible_with_new_height)
4106         (tui_source_window_base::do_make_visible_with_new_height):
4107         Update.
4108         * tui/tui-layout.c (show_source_disasm_command, show_data)
4109         (show_source_or_disasm_and_command): Update.
4110         * tui/tui-layout.c (show_layout): Update.
4111
4112 2019-07-17  Tom Tromey  <tom@tromey.com>
4113
4114         * tui/tui-layout.c (make_data_window): Remove.
4115         (show_data): Unify creation and re-initialization cases.
4116
4117 2019-07-17  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-layout.c (make_source_window, make_disasm_window):
4120         Remove.
4121         (show_data): Unify creation and re-initialization cases.
4122
4123 2019-07-17  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui-layout.c (make_command_window): Remove.
4126         (show_source_disasm_command, show_source_or_disasm_and_command):
4127         Unify creation and re-initialization cases.
4128
4129 2019-07-17  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4132         creation and re-initialization cases.
4133
4134 2019-07-17  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-regs.c (tui_get_register): Return void.
4137
4138 2019-07-17  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4141         Simplify.
4142
4143 2019-07-17  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4146         resetting.
4147
4148 2019-07-17  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4151         * tui/tui-regs.c (tui_reg_layout): New function.
4152         (tui_show_registers, tui_reg_command): Use it.
4153         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4154         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4155         parameters.
4156         (tui_layout_command): Remove.
4157
4158 2019-07-17  Tom Tromey  <tom@tromey.com>
4159
4160         * tui/tui-layout.h (tui/tui-layout): Return void.
4161         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4162
4163 2019-07-17  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-layout.c (show_source_disasm_command, show_data):
4166         Update.
4167         (reset_locator): Remove.
4168         (show_source_or_disasm_and_command): Update.
4169
4170 2019-07-17  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-source.c (tui_source_window_base::reset): Remove
4173         win_type parameter.
4174         * tui/tui-layout.c (make_command_window, make_source_window)
4175         (make_disasm_window, make_data_window)
4176         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4177         (reset_locator, show_source_or_disasm_and_command): Update.
4178         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4179         win_type parameter.
4180         (struct tui_source_window_base) <reset>: Likewise.
4181
4182 2019-07-17  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui-layout.c (show_source_disasm_command): Use
4185         reset_locator.
4186         (reset_locator): New function.
4187         (init_and_make_win): Remove.
4188         (show_source_or_disasm_and_command): Use reset_locator.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4193         condition.
4194         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4195         Remove condition.
4196         * tui/tui-source.c (tui_source_window_base::reset): New method.
4197         * tui/tui-layout.c (make_command_window): Don't call
4198         init_and_make_win.
4199         (make_source_window, make_disasm_window): Don't call
4200         make_source_or_disasm_window.
4201         (make_data_window): Don't call init_and_make_win.  Change calling
4202         convention.
4203         (show_source_disasm_command, show_data): Simplify.
4204         (make_source_or_disasm_window): Remove.
4205         (show_source_or_disasm_and_command): Simplify.
4206         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4207         (struct tui_source_window_base) <reset>: Likewise.
4208         <execution_info>: Remove initializer.
4209         * tui/tui-data.c (tui_source_window_base): Initialize
4210         execution_info.
4211
4212 2019-07-17  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4215         variable.
4216
4217 2019-07-17  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui.c (tui_rl_other_window): Update.
4220         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4221         superclass method first.  Always iterate over regs_content.
4222         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4223         method.
4224         * tui/tui-win.c (tui_set_focus_command): Update.
4225
4226 2019-07-17  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-win.c (tui_set_focus_command): Rename from
4229         tui_set_focus.  Call tui_enable.
4230         (tui_set_focus_command): Remove.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4235         refresh_window.
4236         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4237         touchwin.
4238         (tui_data_window::refresh_window): Call refresh_window on data
4239         items.  Always call superclass refresh_window.
4240         (tui_win_info::refresh): Remove.
4241         (tui_source_window_base::refresh_window): Update.
4242         (tui_refresh_all): Update.
4243         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4244         refresh_window.
4245         (show_source_or_disasm_and_command): Likewise.
4246         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4247         (struct tui_source_window_base) <refresh>: Likewise.
4248
4249 2019-07-17  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui-winsource.c (tui_clear_source_content)
4252         (tui_show_source_content): Update.
4253         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4254         whether content is empty.
4255         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4256         Remove.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4261         window's contents.
4262         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4263         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4264
4265 2019-07-17  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4268         (struct tui_data_item_window): Update.
4269
4270 2019-07-17  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4273         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4274         defines.
4275
4276 2019-07-17  Tom Tromey  <tom@tromey.com>
4277
4278         * tui/tui-winsource.h (tui_erase_source_content)
4279         (tui_clear_source_content): Remove "display_prompt" parameter.
4280         * tui/tui-winsource.c (tui_update_source_window_as_is)
4281         (tui_update_source_windows_with_addr): Update.
4282         (tui_clear_source_content): Remove "display_prompt" parameter.
4283         (tui_erase_source_content): Likewise.  Simplify.
4284         (tui_show_source_content): Update.
4285         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4286         * tui/tui-stack.c (tui_show_frame_info): Update.
4287         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4288         Remove defines.
4289
4290 2019-07-17  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4293         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4294         parameter.
4295         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4296         parameter.
4297
4298 2019-07-17  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-winsource.c (tui_clear_source_content)
4301         (tui_show_source_content, tui_show_exec_info_content)
4302         (tui_clear_exec_info_content): Update.
4303         * tui/tui-stack.c (tui_show_locator_content): Update.
4304         (tui_show_frame_info): Update.
4305         * tui/tui-source.h (tui_source_window): Don't declare.
4306         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4307         from tui_source_is_displayed.
4308         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4309         Remove field.
4310         (struct tui_source_window_base) <content_in_use>: New field.  Now
4311         bool.
4312         (struct tui_source_window) <showing_source_p>: New method.
4313         (TUI_SRC_WIN): Change cast.
4314         * tui/tui-data.c (tui_initialize_static_data): Update.
4315
4316 2019-07-17  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4319         location_matches_p.
4320         * tui/tui-source.c (tui_source_window::location_matches_p): New
4321         method.
4322         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4323         method.
4324         * tui/tui-data.h (struct tui_source_window_base)
4325         <location_matches_p>: New method.
4326         (struct tui_source_window, struct tui_disasm_window)
4327         <location_matches_p>: Likewise.
4328
4329 2019-07-17  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-win.c (tui_set_win_height_command): Rename from
4332         tui_set_win_height.
4333         (tui_set_win_height_command): Remove.
4334
4335 2019-07-17  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-source.c (tui_source_window): New constructor.  Add
4338         observer.
4339         (~tui_source_window): New destructor.
4340         (tui_source_window::style_changed): New method.
4341         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4342         (tui_attach_detach_observers): Update.
4343         * tui/tui-data.h (struct tui_source_window): Make constructor not
4344         inline.  Add destructor.
4345         (struct tui_source_window) <style_changed>: New method.
4346         <m_observable>: New member.
4347
4348 2019-07-17  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4351         * tui/tui-win.c (tui_resize_all): Fix typo.
4352
4353 2019-07-17  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4356         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4357         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4358         * tui/tui-win.c (window_name_completer): Use foreach.
4359         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4360         (update_tab_width): Likewise.
4361         * tui/tui-layout.c (show_layout): Update.
4362         * tui/tui-data.h (class tui_window_iterator): New.
4363         (struct all_tui_windows): New.
4364         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4365
4366 2019-07-17  Tom Tromey  <tom@tromey.com>
4367
4368         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4369         parameter.  Don't reference globals.
4370         (tui_reg_command): Update.
4371
4372 2019-07-17  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-regs.c (tui_show_registers): Simplify.
4375
4376 2019-07-17  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui-regs.c (tui_show_registers): Update.
4379         (tui_show_register_group): Add win_info parameter.
4380
4381 2019-07-17  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4384         Rename from tui_display_reg_element_at_line.
4385         (tui_data_window::display_registers_from_line): Update.
4386         * tui/tui-data.h (struct tui_data_window)
4387         <display_reg_element_at_line>: New method.
4388
4389 2019-07-17  Tom Tromey  <tom@tromey.com>
4390
4391         * tui/tui-regs.h (tui_display_registers_from)
4392         (tui_display_registers_from_line): Don't declare.
4393         * tui/tui-windata.c (tui_data_window::display_all_data)
4394         (tui_data_window::refresh_all)
4395         (tui_data_window::do_scroll_vertical): Update.
4396         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4397         from tui_display_registers_from.
4398         (tui_display_reg_element_at_line): Update.
4399         (tui_data_window::display_registers_from_line): Rename from
4400         tui_display_registers_from_line.
4401         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4402         display_registers_from_line>: New methods.
4403
4404 2019-07-17  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4407         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4408         from tui_erase_data_content.
4409         (tui_data_window::display_all_data)
4410         (tui_data_window::refresh_all)
4411         (tui_data_window::do_scroll_vertical): Update.
4412         * tui/tui-regs.c (tui_show_registers): Update.
4413         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4414         New method.
4415
4416 2019-07-17  Tom Tromey  <tom@tromey.com>
4417
4418         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4419         declare.
4420         * tui/tui-windata.c
4421         (tui_data_window::delete_data_content_windows): Rename from
4422         tui_delete_data_content_windows.
4423         (tui_data_window::display_all_data)
4424         (tui_data_window::do_scroll_vertical): Update.
4425         * tui/tui-data.h (struct tui_data_window)
4426         <delete_data_content_windows>: New method.
4427
4428 2019-07-17  Tom Tromey  <tom@tromey.com>
4429
4430         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4431         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4432
4433 2019-07-17  Tom Tromey  <tom@tromey.com>
4434
4435         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4436         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4437         from tui_display_all_data.
4438         * tui/tui-win.c
4439         (tui_data_window::do_make_visible_with_new_height): Update.
4440         * tui/tui-regs.c (tui_show_registers): Update.
4441         * tui/tui-layout.c (tui_set_layout): Update.
4442         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4443         method.
4444
4445 2019-07-17  Tom Tromey  <tom@tromey.com>
4446
4447         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4448         * tui/tui-windata.c (tui_display_data_from): Remove.
4449         (tui_data_window::refresh_all): Update.
4450
4451 2019-07-17  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4454         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4455         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4456         tui_display_registers_from_line.
4457         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4458         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4459         "force_display" parameter.
4460
4461 2019-07-17  Tom Tromey  <tom@tromey.com>
4462
4463         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4464         declare.
4465         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4466         Rename from tui_first_reg_element_no_inline.
4467         (tui_display_reg_element_at_line)
4468         (tui_display_registers_from_line): Update.
4469         * tui/tui-data.h (struct tui_data_window)
4470         <first_reg_element_no_inline>: New method.
4471
4472 2019-07-17  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-windata.c (tui_display_data_from)
4475         (tui_data_window::do_scroll_vertical): Update.
4476         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4477         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4478         Rename from tui_line_from_reg_element_no.
4479         (tui_display_registers_from_line): Update.
4480         * tui/tui-data.h (struct tui_data_window)
4481         <line_from_reg_element_no>: New method.
4482
4483 2019-07-17  Tom Tromey  <tom@tromey.com>
4484
4485         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4486         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4487         tui_last_regs_line_no.
4488         (tui_display_reg_element_at_line)
4489         (tui_display_registers_from_line): Update.
4490         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4491         method.
4492
4493 2019-07-17  Tom Tromey  <tom@tromey.com>
4494
4495         PR tui/24722:
4496         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4497         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4498         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4499         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4500         (tui_update_breakpoint_info): Likewise.
4501         * tui/tui-hooks.c (tui_event_create_breakpoint)
4502         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4503         Update.
4504
4505 2019-07-17  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4508
4509 2019-07-17  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-winsource.c (tui_update_source_window_as_is)
4512         (tui_update_source_windows_with_addr): Update.
4513         * tui/tui-source.h (tui_set_source_content)
4514         (tui_show_symtab_source): Add "win_info" parameter.
4515         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4516         parameter.
4517         (tui_show_symtab_source): Likewise.
4518
4519 2019-07-17  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-wingeneral.c
4522         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4523
4524 2019-07-17  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4527         (struct tui_cmd_window) <can_scroll>: New method.
4528         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4529         method.
4530
4531 2019-07-17  Tom Tromey  <tromey@adacore.com>
4532
4533         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4534         do_field_signed>: Rename.  Change type of "value".
4535         * ui-out.c (ui_out::field_signed): Rename from field_int.
4536         Change type of "value".
4537         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4538         type of "value".
4539         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4540         do_field_int.  Change type of "value".
4541         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4542         do_field_int.  Change type of "value".
4543         * tracepoint.c (trace_status_mi, tfind_1)
4544         (print_one_static_tracepoint_marker): Update.
4545         * thread.c (print_thread_info_1, print_selected_thread_frame):
4546         Update.
4547         * stack.c (print_frame, print_frame_info): Update.
4548         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4549         Update.
4550         * source.c (print_source_lines_base): Update.
4551         * skip.c (info_skip_command): Update.
4552         * record-btrace.c (btrace_ui_out_decode_error)
4553         (btrace_call_history_src_line): Update.
4554         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4555         Update.
4556         * progspace.c (print_program_space): Update.
4557         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4558         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4559         do_field_int.  Change type of "value".
4560         * mi/mi-out.c (mi_ui_out::do_table_begin)
4561         (mi_ui_out::do_table_header): Update.
4562         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4563         type of "value".
4564         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4565         (mi_cmd_data_list_changed_registers, output_register)
4566         (mi_cmd_data_read_memory, mi_load_progress)
4567         (mi_cmd_trace_frame_collected): Update.
4568         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4569         Update.
4570         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4571         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4572         (mi_cmd_var_list_children, varobj_update_one): Update.
4573         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4574         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4575         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4576         * inferior.c (print_inferior): Update.
4577         * gdb_bfd.c (print_one_bfd): Update.
4578         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4579         Update.
4580         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4581         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4582         do_field_int.  Change type of "value".
4583         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4584         do_field_int.  Change type of "value".
4585         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4586         (print_one_breakpoint_location, print_it_catch_fork)
4587         (print_one_catch_fork, print_it_catch_vfork)
4588         (print_one_catch_vfork, print_it_catch_solib)
4589         (print_it_catch_exec, print_it_ranged_breakpoint)
4590         (print_mention_watchpoint, print_mention_masked_watchpoint)
4591         (bkpt_print_it, update_static_tracepoint): Update.
4592         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4593         * break-catch-syscall.c (print_it_catch_syscall): Update.
4594         * ada-tasks.c (print_ada_task_info): Update.
4595         * ada-lang.c (print_it_exception, print_mention_exception):
4596         Update.
4597
4598 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         PR breakpoints/24541
4601         * gdbarch.c: Regenerate.
4602         * gdbarch.h: Regenerate.
4603         * gdbarch.sh: Adjust return type and parameter types for
4604         'stap_adjust_register'.
4605         (i386_stap_adjust_register): Adjust signature and return new
4606         register name.
4607         * stap-probe.c (stap_parse_register_operand): Adjust use of
4608         'gdbarch_stap_adjust_register'.
4609
4610 2019-07-17  Tom Tromey  <tromey@adacore.com>
4611
4612         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4613         declare VEC.
4614         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4615         std::vector.
4616         (struct s390_process_info): Add initializers.
4617         (s390_add_process): Use new.
4618         (s390_linux_nat_target::low_forget_process): Use delete.
4619         (s390_linux_nat_target::low_new_fork)
4620         (s390_linux_nat_target::stopped_by_watchpoint)
4621         (s390_linux_nat_target::low_prepare_to_resume)
4622         (s390_linux_nat_target::insert_watchpoint)
4623         (s390_linux_nat_target::insert_hw_breakpoint)
4624         (s390_linux_nat_target::remove_watchpoint)
4625         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4626
4627 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4628
4629         * aarch64-fbsd-nat.c: Include regcache.h.
4630         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4631         argument.
4632         (aarch64_fbsd_nat_target::fetch_registers)
4633         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4634         variable.
4635         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4636
4637 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * fbsd-nat.c: Include gdbarch.h.
4640
4641 2019-07-15  Tom Tromey  <tromey@adacore.com>
4642
4643         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4644
4645 2019-07-15  Tom Tromey  <tromey@adacore.com>
4646
4647         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4648         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4649         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4650         * cli-out.c (cli_ui_out::do_field_int): New method.
4651         * ui-out.c (ui_out::field_unsigned): New method.
4652         * symfile.c (generic_load): Use field_unsigned.
4653         (print_transfer_performance): Likewise.
4654         * record-btrace.c (ui_out_field_uint): Remove.
4655         (btrace_call_history_insn_range, btrace_call_history): Use
4656         field_unsigned.
4657         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4658         field_unsigned.
4659         * ui-out.h (class ui_out) <field_unsigned>: New method.
4660         <do_field_unsigned>: Likewise.
4661
4662 2019-07-15  Tom Tromey  <tromey@adacore.com>
4663
4664         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4665         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4666         * target.c (flash_erase_command): Use field_string.
4667         * infrun.c (print_signal_received_reason): Use field_string.
4668         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4669         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4670         field_string.
4671         * ada-tasks.c (print_ada_task_info): Use field_string.
4672
4673 2019-07-15  Tom Tromey  <tromey@adacore.com>
4674
4675         * target.c (flash_erase_command): Use field_core_addr.
4676         * symfile.c (generic_load): Use field_core_addr.
4677         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4678         Use field_core_addr.
4679         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4680         field_core_addr.
4681
4682 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4683
4684         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4685         value if its desired type is smaller than a CORE_ADDR and signed.
4686
4687 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4688
4689         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4690         of changes to field names, and use new is_reference field to
4691         decide if a property is a reference or not.
4692         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4693         field.
4694         (struct dwarf2_property_baton): Update header comment, rename
4695         'referenced_type' to 'property_type' and update comments.
4696         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4697         default property type, store in property baton, update to take
4698         accound of renamed field.
4699         (read_func_scope): Update call to attr_to_dynamic_prop.
4700         (read_array_type): Likewise.
4701         (dwarf2_per_cu_addr_sized_int_type): New function.
4702         (read_subrange_index_type): Move type finding code to
4703         dwarf2_per_cu_addr_sized_int_type.
4704         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4705         (dwarf2_per_cu_addr_type): New function.
4706         (set_die_type): Update calls to attr_to_dynamic_prop.
4707
4708 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * dwarf2read.c (read_subrange_index_type): New function.
4711         (read_subrange_type): Move code into new function and call it.
4712         * gdbtypes.c (create_range_type): Add some asserts.
4713
4714 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4717         update return statements.
4718         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4719         declaration, and update comment to match.
4720         * gdbtypes.c (resolve_dynamic_array): Update call to
4721         dwarf2_evaluate_property to match new return type.
4722
4723 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * valarith.c (value_subscripted_rvalue): Change lowerbound
4726         parameter type from int to LONGEST.
4727         * value.h (value_subscripted_rvalue): Likewise in declaration.
4728
4729 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * cli/cli-utils.c (info_print_command_completer): New function.
4732         * cli/cli-utils.h: Add 'completer.h' include, and forward
4733         declaration for 'struct cmd_list_element'.
4734         (info_print_command_completer): Declare.
4735         * stack.c (_initialize_stack): Add completer for 'info locals' and
4736         'info args'.
4737         * symtab.c (_initialize_symtab): Add completer for 'info
4738         variables' and 'info functions'.
4739         * NEWS: Mention completion for additional info commands.
4740
4741 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * cli/cli-utils.c (extract_info_print_args): Delete.
4744         (extract_arg_maybe_quoted): Delete.
4745         (info_print_options_defs): New variable.
4746         (make_info_print_options_def_group): New function.
4747         (extract_info_print_options): Define new function.
4748         * cli/cli-utils.h (extract_info_print_args): Delete.
4749         (struct info_print_options): New structure.
4750         (extract_info_print_options): Declare new function.
4751         * stack.c (info_locals_command): Update to use new
4752         extract_info_print_options, also add a header comment.
4753         (info_args_command): Likewise.
4754         * symtab.c (info_variables_command): Likewise.
4755         (info_functions_command): Likewise.
4756
4757 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4758
4759         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4760         to extract string arguments.
4761         * common/common-utils.c (extract_string_maybe_quoted): New function.
4762         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4763
4764 2019-07-11  Tom Tromey  <tromey@adacore.com>
4765
4766         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4767         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4768         * top.h (gdbinit): Don't declare.
4769         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4770         into...
4771         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4772         * top.c (gdb_init): Don't call init_cli_cmds.
4773         (gdbinit): Remove.
4774         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4775
4776 2019-07-11  Tom Tromey  <tromey@adacore.com>
4777
4778         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4779         after it has been moved.
4780
4781 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4782
4783         * valops.c (value_must_coerce_to_target): Change return type to
4784         bool.
4785         * value.h (value_must_coerce_to_target): Likewise.
4786
4787 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4788
4789         * breakpoint.c (is_hardware_watchpoint): Remove
4790         forward-declaration.
4791         (is_masked_watchpoint): Change return type to bool.
4792         (is_tracepoint): Likewise.
4793         (is_breakpoint): Likewise.
4794         (is_hardware_watchpoint): Likewise.
4795         (is_watchpoint): Likewise.
4796         (is_no_memory_software_watchpoint): Likewise.
4797         (is_catchpoint): Likewise.
4798         (breakpoint_1): Make FILTER parameter's return type bool.
4799         is_masked_watchpoint): Change return type to bool.
4800         (save_breakpoints): Make FILTER parameter's return type bool.
4801         * breakpoint.h (is_breakpoint): Change return type to bool.
4802         (is_watchpoint): Likewise.
4803         (is_catchpoint): Likewise.
4804         (is_tracepoint): Likewise.
4805
4806 2019-07-10  Tom Tromey  <tom@tromey.com>
4807
4808         * defs.h: Don't include gdbarch.h.
4809         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4810         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4811         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4812         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4813         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4814         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4815         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4816         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4817         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4818         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4819         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4820         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4821         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4822         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4823         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4824         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4825         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4826         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4827         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4828         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4829         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4830         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4831         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4832         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4833         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4834         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4835         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4836
4837 2019-07-10  Tom Tromey  <tromey@adacore.com>
4838
4839         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4840         * breakpoint.c (init_ada_exception_breakpoint): Register as
4841         bp_catchpoint.
4842         (print_one_breakpoint_location, print_one_breakpoint): Use
4843         is_ada_exception_catchpoint.
4844         * ada-lang.c (class ada_catchpoint_location): Pass
4845         bp_loc_software_breakpoint to bp_location constructor.
4846         (is_ada_exception_catchpoint): New function.
4847
4848 2019-07-10  Tom Tromey  <tromey@adacore.com>
4849
4850         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4851         VEC.
4852         (struct arm_exidx_entry): New method operator<.
4853         (struct arm_exidx_data) <section_maps>: Change type.
4854         (arm_exidx_data_free): Remove.
4855         (arm_exidx_data_key): Change type.  Move lower.
4856         (arm_exidx_new_objfile): Update.
4857         (arm_compare_exidx_entries): Remove.
4858         (arm_find_exidx_entry, _initialize_arm_tdep)
4859
4860 2019-07-10  Tom Tromey  <tromey@adacore.com>
4861
4862         * solib-spu.c (ocl_program_data_key): Change type.
4863         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4864         Update.
4865
4866 2019-07-10  Tom Tromey  <tromey@adacore.com>
4867
4868         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4869         (struct solib_aix_inferior_data) <library_list>: Change type.
4870         (solib_aix_inferior_data_handle): Change type.
4871         (get_solib_aix_inferior_data): Update.
4872         (solib_aix_free_library_list): Remove.
4873         (library_list_start_library): Update.
4874         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4875         return type.
4876         (solib_aix_get_library_list)
4877         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4878         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4879
4880 2019-07-10  Tom Tromey  <tromey@adacore.com>
4881
4882         * solib-dsbt.c (struct dsbt_info): Add initializers.
4883         (solib_dsbt_pspace_data): Change type.
4884         (dsbt_pspace_data_cleanup): Remove.
4885         (get_dsbt_info, _initialize_dsbt_solib): Update.
4886
4887 2019-07-10  Tom Tromey  <tromey@adacore.com>
4888
4889         * spu-tdep.c (spu_overlay_data): Change type.
4890         (spu_get_overlay_table, spu_overlay_new_objfile)
4891         (_initialize_spu_tdep): Update.
4892
4893 2019-07-10  Tom Tromey  <tromey@adacore.com>
4894
4895         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4896         destructor.
4897         (dbx_objfile_data_key): Change type and declare later.
4898         (DBX_SYMFILE_INFO): Rewrite.
4899         * dbxread.c (dbx_objfile_data_key): Change type.
4900         (dbx_symfile_init): Update.
4901         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4902         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4903         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4904
4905 2019-07-10  Tom Tromey  <tromey@adacore.com>
4906
4907         * jit.c (jit_program_space_key): Change type.  Move lower.
4908         (get_jit_program_space_data): Update.
4909         (jit_program_space_data_cleanup): Remove.
4910         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4911         Update.
4912         (struct jit_program_space_data): Add initializers.
4913
4914 2019-07-10  Tom Tromey  <tromey@adacore.com>
4915
4916         * solib-darwin.c (struct darwin_info): Add initializers.
4917         (solib_darwin_pspace_data): Change type.
4918         (darwin_pspace_data_cleanup): Remove.
4919         (get_darwin_info, _initialize_darwin_solib): Update.
4920
4921 2019-07-10  Tom Tromey  <tromey@adacore.com>
4922
4923         * remote-sim.c (struct sim_inferior_data): Add initializers,
4924         constructor, and destructor.
4925         (sim_inferior_data_key): Change type.  Move lower.
4926         (check_for_duplicate_sim_descriptor): Update.
4927         (get_sim_inferior_data): Use new.  Update.
4928         (~sim_inferior_data_cleanup): Rename from
4929         sim_inferior_data_cleanup.  Simplify.
4930         (gdbsim_close_inferior, simulator_command)
4931         (sim_command_completer, _initialize_remote_sim): Update.
4932         (next_pid, INITIAL_PID): Move earlier.
4933
4934 2019-07-10  Tom Tromey  <tromey@adacore.com>
4935
4936         * python/python-internal.h (create_thread_object): Return
4937         gdbpy_ref.
4938         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4939         * python/py-inferior.c (struct threadlist_entry): Add
4940         constructor.
4941         <thread_obj>: Now a gdbpy_ref.
4942         (thread_to_thread_object): Update.
4943         (add_thread_object): Use new.
4944         (delete_thread_object): Use delete.
4945         (infpy_threads): Update.
4946         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4947         GIL.
4948
4949 2019-07-10  Tom Tromey  <tromey@adacore.com>
4950
4951         * valops.c (value_cast): Specialize error message for Ada.
4952
4953 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4954
4955         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4956
4957 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4958
4959         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4960         bpstat_should_step): Return bool, adjust comments.
4961         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4962         bpstat_should_step): Likewise.
4963
4964 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4965
4966         * features/Makefile: Use feature target descriptions for Arm.
4967         * features/arm/arm-core.c: Generate new file.
4968         * features/arm/arm-fpa.c: Likewise.
4969         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4970         * features/arm/arm-m-profile.c: Likewise.
4971         * features/arm/arm-vfpv2.c: Likewise.
4972         * features/arm/arm-vfpv3.c: Likewise.
4973         * features/arm/xscale-iwmmxt.c: Likewise.
4974         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4975
4976 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4977
4978         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4979         ptrace earlier.
4980
4981 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4982
4983         * features/aarch64-pauth.c: Regenerate.
4984
4985 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4986
4987         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4988         bool.
4989         (bpstat_what): Use false instead of 0.
4990
4991 2019-07-09  Pedro Alves  <palves@redhat.com>
4992
4993         * break-catch-throw.c (is_exception_catchpoint): New.
4994         * breakpoint.c (print_one_breakpoint_location): New parameter
4995         'raw_loc'.  Handle it.  Use
4996         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4997         looking at the breakpoint's type.
4998         (print_one_breakpoint): If handling "maint info breakpoints", also
4999         print locations of exception catchpoints.
5000         * breakpoint.h (is_exception_catchpoint): Declare.
5001
5002 2019-07-09  Pedro Alves  <palves@redhat.com>
5003
5004         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5005         "addr" field.
5006         (allocate_location_exception_catchpoint): New.
5007         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5008         (initialize_throw_catchpoint_ops): Install
5009         allocate_location_exception_catchpoint as allocate_location
5010         method.
5011         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5012         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5013         bp_loc_other.
5014         (breakpoint_address_is_meaningful): Delete.
5015         (bl_address_is_meaningful): New.
5016         (breakpoint_locations_match): Adjust comment.
5017         (bp_location_from_bp_type): New, factored out of...
5018         (bp_location::bp_location(breakpoint *)): ... this.
5019         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5020         factored out of...
5021         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5022         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5023         breakpoint_address_is_meaningful.
5024         (bp_locations_compare): Adjust comment.
5025         (update_global_location_list): Use bl_address_is_meaningful
5026         instead of breakpoint_address_is_meaningful.
5027         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5028         explicit.
5029         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5030         * python/py-breakpoint.c (bppy_get_location): No longer check
5031         whether location is null.
5032
5033 2019-07-09  Pedro Alves  <palves@redhat.com>
5034
5035         PR c++/15468
5036         * breakpoint.c (print_one_breakpoint_location): Remove
5037         single-location assert.
5038
5039 2019-07-09  Tom Tromey  <tom@tromey.com>
5040
5041         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5042         * configure: Rebuild.
5043         * configure.ac: Change common to gdbsupport.
5044         * gdbsupport: Rename from common.
5045         * acinclude.m4: Change common to gdbsupport.
5046         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5047         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5048         gdbsupport.
5049         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5050         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5051         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5052         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5053         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5054         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5055         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5056         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5057         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5058         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5059         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5060         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5061         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5062         coff-pe-read.c, command.h, compile/compile-c-support.c,
5063         compile/compile-c.h, compile/compile-cplus-symbols.c,
5064         compile/compile-cplus-types.c, compile/compile-cplus.h,
5065         compile/compile-loc2c.c, compile/compile.c, completer.c,
5066         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5067         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5068         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5069         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5070         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5071         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5072         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5073         features/aarch64-core.c, features/aarch64-fpu.c,
5074         features/aarch64-pauth.c, features/aarch64-sve.c,
5075         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5076         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5077         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5078         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5079         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5080         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5081         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5082         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5083         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5084         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5085         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5086         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5087         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5088         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5089         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5090         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5091         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5092         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5093         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5094         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5095         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5096         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5097         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5098         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5099         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5100         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5101         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5102         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5103         minsyms.c, mips-linux-tdep.c, namespace.h,
5104         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5105         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5106         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5107         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5108         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5109         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5110         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5111         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5112         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5113         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5114         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5115         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5116         procfs.c, producer.c, progspace.h, psymtab.h,
5117         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5118         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5119         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5120         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5121         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5122         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5123         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5124         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5125         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5126         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5127         target-memory.c, target.c, target.h, target/waitstatus.c,
5128         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5129         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5130         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5131         unittests/array-view-selftests.c,
5132         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5133         unittests/common-utils-selftests.c,
5134         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5135         unittests/format_pieces-selftests.c,
5136         unittests/function-view-selftests.c,
5137         unittests/lookup_name_info-selftests.c,
5138         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5139         unittests/mkdir-recursive-selftests.c,
5140         unittests/observable-selftests.c,
5141         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5142         unittests/parse-connection-spec-selftests.c,
5143         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5144         unittests/scoped_fd-selftests.c,
5145         unittests/scoped_mmap-selftests.c,
5146         unittests/scoped_restore-selftests.c,
5147         unittests/string_view-selftests.c, unittests/style-selftests.c,
5148         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5149         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5150         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5151         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5152         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5153         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5154
5155 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5158         bool value.
5159         (decode_digits_ordinary): Set explicit_line field in sal.
5160         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5161         symtab_and_line that was set on an explicit line number in
5162         assembler code.  Do always update the recorded symtab and line if
5163         we do skip the prologue.
5164
5165 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * breakpoint.c (set_breakpoint_location_function): Remove
5168         explicit_loc parameter.
5169         (momentary_breakpoint_from_master): Update call to
5170         set_breakpoint_location_function.
5171         (add_location_to_breakpoint): Likewise.
5172
5173 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5176         required features based on default bfd type when no specific bfd
5177         is present.
5178
5179 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5180
5181         * NEWS: Mention that GDB printf and eval commands can now print
5182         C-style and Ada-style convenience var strings without
5183         calling the inferior.
5184         * printcmd.c (printf_c_string): Locally print GDB internal var
5185         instead of transiting via the inferior.
5186         (printf_wide_c_string): Likewise.
5187
5188 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5189
5190         PR breakpoints/25011
5191         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5192
5193 2019-07-04  Tom Tromey  <tom@tromey.com>
5194
5195         PR tui/24724:
5196         * tui/tui-winsource.c (tui_clear_source_content): Update.
5197         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5198         (tui_update_breakpoint_info): Update.
5199         (tui_set_exec_info_content): Update.
5200         * tui/tui-source.c (tui_set_source_content_nil): Update.
5201         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5202         has_break.
5203         * tui/tui-data.h (enum tui_bp_flag): New.
5204         (tui_bp_flags): New enum flags type.
5205         (struct tui_source_element) <break_mode>: Change type.  Rename
5206         from has_break.
5207         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5208         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5209         constants.
5210         * tui/tui-winsource.h: Fix comment.
5211
5212 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5213
5214         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5215         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5216         (store_fpregs_to_thread)
5217         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5218         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5219         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5220         (IWMMXT_REGS_SIZE): Add define.
5221         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5222         (fetch_vfp_regs, store_vfp_regs)
5223         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5224         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5225
5226 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5227
5228         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5229         defines.
5230         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5231         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5232         (ARM_INT_REGISTER_SIZE): ...to this.
5233         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5234         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5235         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5236         (arm_linux_collect_gregset, supply_nwfpe_register)
5237         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5238         defines.
5239         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5240         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5241         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5242         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5243         (arm_return_in_memory, arm_store_return_value)
5244         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5245         (arm_record_ld_st_multiple): Likewise.
5246         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5247         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5248
5249 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5250
5251         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5252         AARCH64_DISPLACED_MODIFIED_INSNS.
5253         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5254         (aarch64_displaced_step_copy_insn): Likewise.
5255         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5256         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5257         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5258         ARM_DISPLACED_MODIFIED_INSNS.
5259         * arm-tdep.c (arm_gdbarch_init): Likewise.
5260         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5261         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5262         (struct arm_displaced_step_closure): Use
5263         ARM_DISPLACED_MODIFIED_INSNS.
5264
5265 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5266
5267         * features/Makefile: Remove unused xml files.
5268         * features/aarch64.xml: Remove.
5269         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5270         * features/i386/amd64-avx-avx512.xml: Remove.
5271         * features/i386/amd64-avx-linux.xml: Remove.
5272         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5273         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5274         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5275         * features/i386/amd64-avx-mpx.xml: Remove.
5276         * features/i386/amd64-avx.xml: Remove.
5277         * features/i386/amd64-linux.xml: Remove.
5278         * features/i386/amd64-mpx-linux.xml: Remove.
5279         * features/i386/amd64-mpx.xml: Remove.
5280         * features/i386/amd64.xml: Remove.
5281         * features/i386/i386-avx-avx512-linux.xml: Remove.
5282         * features/i386/i386-avx-avx512.xml: Remove.
5283         * features/i386/i386-avx-linux.xml: Remove.
5284         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5285         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5286         * features/i386/i386-avx-mpx-linux.xml: Remove.
5287         * features/i386/i386-avx-mpx.xml: Remove.
5288         * features/i386/i386-avx.xml: Remove.
5289         * features/i386/i386-linux.xml: Remove.
5290         * features/i386/i386-mmx-linux.xml: Remove.
5291         * features/i386/i386-mmx.xml: Remove.
5292         * features/i386/i386-mpx-linux.xml: Remove.
5293         * features/i386/i386-mpx.xml: Remove.
5294         * features/i386/i386.xml: Remove.
5295         * features/i386/x32-avx-avx512-linux.xml: Remove.
5296         * features/i386/x32-avx-linux.xml: Remove.
5297         * features/i386/x32-linux.xml: Remove.
5298
5299 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5300
5301         * regformats/aarch64.dat: Remove.
5302         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5303         * regformats/i386/amd64-avx-linux.dat: Remove.
5304         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5305         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5306         * regformats/i386/amd64-linux.dat: Remove.
5307         * regformats/i386/amd64-mpx-linux.dat: Remove.
5308         * regformats/i386/amd64.dat: Remove.
5309         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5310         * regformats/i386/i386-avx-linux.dat: Remove.
5311         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5312         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5313         * regformats/i386/i386-linux.dat: Remove.
5314         * regformats/i386/i386-mmx-linux.dat: Remove.
5315         * regformats/i386/i386-mpx-linux.dat: Remove.
5316         * regformats/i386/i386.dat: Remove.
5317         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5318         * regformats/i386/x32-avx-linux.dat: Remove.
5319         * regformats/i386/x32-linux.dat: Remove.
5320
5321 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5322
5323         * aarch64-tdep.c: Remove xml self tests.
5324         * amd64-linux-tdep.c: Likewise.
5325         * amd64-tdep.c: Likewise.
5326         * i386-linux-tdep.c: Likewise.
5327         * i386-tdep.c: Likewise.
5328
5329 2019-07-03  Pedro Alves  <palves@redhat.com>
5330
5331         PR cli/24732
5332         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5333         (pipe_cmd_option_defs): New.
5334         (make_pipe_cmd_options_def_group): New.
5335         (pipe_command): Use gdb::option::process_options.
5336         (pipe_command_completer): New function.
5337         (_initialize_cli_cmds): Install completer for "pipe" command.
5338
5339 2019-07-03  Pedro Alves  <palves@redhat.com>
5340
5341         * cli/cli-option.c (union option_value) <string>: New field.
5342         (struct option_def_and_value): Add ctor, move ctor, dtor and
5343         use DISABLE_COPY_AND_ASSIGN.
5344         (option_def_and_value::clear_value): New.
5345         (parse_option, save_option_value_in_ctx, get_val_type_str)
5346         (add_setshow_cmds_for_options): Handle var_string.
5347         * cli-option.h (union option_def::var_address) <string>: New
5348         field.
5349         (struct string_option_def): New.
5350         * maint-test-options.c (struct test_options_opts): Add default
5351         ctor and use DISABLE_COPY_AND_ASSIGN.
5352         <string_opt>: New field.
5353         (test_options_opts::~test_options_opts): New.
5354         (test_options_opts::dump): Also dump "-string".
5355         (test_options_option_defs): Install "string.
5356
5357 2019-07-03  Pedro Alves  <palves@redhat.com>
5358
5359         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5360         option_value with a null enumeration.
5361         (complete_options): Save the option values in the context.
5362         (save_option_value_in_ctx): New, factored out from ...
5363         (process_options): ... here.
5364         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5365         of the function.
5366         * maint-test-options.c (test_options_opts::dump): New, factored
5367         out from ...
5368         (maintenance_test_options_command_mode): ... here.
5369         (maintenance_test_options_command_completion_result): Delete.
5370         (maintenance_test_options_command_completion_text): Update
5371         comment.
5372         (maintenance_show_test_options_completion_result): Change
5373         prototype.  Just print
5374         maintenance_test_options_command_completion_text.
5375         (save_completion_result): New.
5376         (maintenance_test_options_completer_mode): Pass options context to
5377         complete_options, and then save a dump.
5378         (_initialize_maint_test_options): Use add_cmd to install "maint
5379         show test-options-completion-result".
5380
5381 2019-07-03  Pedro Alves  <palves@redhat.com>
5382
5383         * NEWS (New commands): Mention "with" and "maint with".
5384         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5385         (with_command, with_command_completer): New.
5386         (pipe_command): Adjust to new repeat_previous
5387         interface.
5388         (_initialize_cli_cmds): Install the "with" command and its "w"
5389         alias.
5390         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5391         declarations.
5392         * cli/cli-setshow.c (parse_cli_var_uinteger)
5393         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5394         argument strings for all var_types.
5395         (get_setshow_command_value_string): New, factored out from ...
5396         (do_show_command): ... this.
5397         * cli/cli-setshow.h: Include <string>.
5398         (get_setshow_command_value_string): Declare.
5399         * command.h (repeat_previous): Now returns const char *.  Adjust
5400         comment.
5401         * maint.c: Include "cli/cli-cmds.h".
5402         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5403         (_initialize_maint_cmds): Register the "maintenance with" command.
5404         * top.c (repeat_previous): Move bits from pipe_command here:
5405         Return the saved command line, if any; error out if there's no
5406         command to relaunch.
5407
5408 2019-07-03  Pedro Alves  <palves@redhat.com>
5409
5410         * NEWS (New commands): Mention "maint set/show test-settings"
5411         instead of "maint test-settings".
5412         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5413         (maintenance_test_settings_set_list): Rename to ...
5414         (maintenance_set_test_settings_list): ... this.
5415         (maintenance_test_settings_show_list): Rename to  ...
5416         (maintenance_show_test_settings_list): ... this.
5417         (maintenance_test_settings_cmd): Delete.
5418         (maintenance_test_settings_set_cmd): ...
5419         (maintenance_set_test_settings_cmd): ... this.
5420         (maintenance_test_settings_show_cmd): ...
5421         (maintenance_show_test_settings_cmd): ... this.
5422         (maintenance_test_settings_show_value_cmd):
5423         (maintenance_show_test_settings_value_cmd): ... this.
5424         (_initialize_maint_test_settings): No longer install the "maint
5425         test-settings" prefix command.  Rename "maint test-settings set"
5426         to "maint set test-settings", and "maint test-settings show" to
5427         "maint show test-settings".  Adjust all subcommands.
5428
5429 2019-07-03  Pedro Alves  <palves@redhat.com>
5430
5431         * maint-test-settings.c: Fix file's intro comment.  Replace all
5432         references to "test-options" with references to "test-settings",
5433         in comments.
5434
5435 2019-07-03  Pedro Alves  <palves@redhat.com>
5436
5437         * maint-test-settings.c (maintenance_test_settings_xxx)
5438         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5439         New.
5440         (maintenance_test_settings_enums): Use them.
5441         (maintenance_test_settings_enum): Default to
5442         maintenance_test_settings_xxx.
5443         (_initialize_maint_test_settings): Initialize
5444         MAINTENANCE_TEST_SETTINGS_FILENAME.
5445
5446 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5447
5448         * breakpoint.h (remove_breakpoints_inf): Change return type to
5449         void, move function documentation here.
5450         * breakpoint.c (remove_breakpoints_inf): Change return type to
5451         void, move function documentation to header.
5452
5453 2019-07-02  Pedro Alves  <palves@redhat.com>
5454
5455         * NEWS (Completion improvements): Mention "info threads".
5456         * thread.c (struct info_threads_opts, info_threads_option_defs)
5457         (make_info_threads_options_def_group): New.
5458         (info_threads_command): Use gdb::option::process_options.
5459         (info_threads_command_completer): New.
5460         (_initialize_thread): Use gdb::option::build_help to build the
5461         help text for "info threads".
5462
5463 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5464
5465         * defs.h (generic_load): Move from here...
5466         * symfile.h (generic_load): ... to here.  Rename name parameter
5467         to args.
5468         * symfile.c (generic_load): Add comment.
5469
5470 2019-07-01  Tom Tromey  <tromey@adacore.com>
5471
5472         * dwarf2read.c
5473         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5474         declaration of without_params.  Fix formatting.
5475
5476 2019-07-01  Tom Tromey  <tromey@adacore.com>
5477
5478         * ada-exp.y (find_primitive_type): Update.
5479         * ada-lang.h (ada_lookup_symbol): Update.
5480         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5481         parameter.
5482         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5483
5484 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5485
5486         PR breakpoints/24541
5487         * gdbarch.c: Regenerate.
5488         * gdbarch.h: Regenerate.
5489         * gdbarch.sh: Add 'stap_adjust_register'.
5490         * i386-tdep.c: Include '<unordered_set>'.
5491         (i386_stap_adjust_register): New function.
5492         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5493         * stap-probe.c (stap_parse_register_operand): Call
5494         'gdbarch_stap_adjust_register'.
5495
5496 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5497
5498         PR python/24742
5499         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5500         * python/python.c (do_start_initialization): Use 'xmalloc'
5501         instead of 'PyMem_Malloc'.
5502
5503 2019-06-28  Tom Tromey  <tromey@adacore.com>
5504
5505         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5506         for Ada.
5507
5508 2019-06-27  Tom Tromey  <tromey@adacore.com>
5509
5510         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5511         objfile_key.
5512         (arm_find_mapping_symbol, arm_record_special_symbol)
5513         (_initialize_arm_tdep): Update.
5514         (arm_objfile_data_free): Remove.
5515
5516 2019-06-27  Tom Tromey  <tromey@adacore.com>
5517
5518         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5519         to cp_print_static_field.
5520
5521 2019-06-26  Tom Tromey  <tromey@adacore.com>
5522
5523         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5524         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5525         declare.
5526
5527 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5528
5529         * features/aarch64-core.c (create_feature_aarch64_core):
5530         Regenerate.
5531         * features/aarch64-core.xml: Add cpsr flags.
5532
5533 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5534
5535         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5536         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5537
5538 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5539
5540         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5541         field.
5542         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5543         use.
5544         (arm_record_special_symbol): Don't insert new symbol in sorted
5545         position, push it at the end.
5546
5547 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5548
5549         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5550         (arm_mapping_symbol_s): Remove.
5551         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5552         (arm_mapping_symbol_vec): New typedef.
5553         (struct arm_per_objfile): Add constructor.
5554         <section_maps>: Change type to
5555         std::unique_ptr<arm_mapping_symbol_vec[]>.
5556         (arm_compare_mapping_symbols): Remove.
5557         (arm_find_mapping_symbol): Adjust to section_maps type change.
5558         (arm_objfile_data_free): Call delete on arm_per_objfile.
5559         (arm_record_special_symbol): Adjust to section_maps type change.
5560         Allocate arm_per_objfile with new.
5561
5562 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5563
5564         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5565         with the command prefix.
5566
5567 2019-06-25  Tom Tromey  <tom@tromey.com>
5568
5569         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5570         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5575         type.
5576         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5577         protected.
5578
5579 2019-06-25  Tom Tromey  <tom@tromey.com>
5580
5581         * tui/tui-winsource.c
5582         (tui_source_window_base::set_is_exec_point_at): Add check against
5583         LOA_ADDRESS.
5584
5585 2019-06-25  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-source.c (tui_set_source_content): Don't check before
5588         xfree.
5589         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5590
5591 2019-06-25  Tom Tromey  <tom@tromey.com>
5592
5593         * tui/tui-winsource.h (tui_update_source_window_as_is)
5594         (tui_alloc_source_buffer, tui_line_is_displayed)
5595         (tui_addr_is_displayed): Change type of win_info.
5596         * tui/tui-winsource.c (tui_update_source_window_as_is)
5597         (tui_clear_source_content, tui_show_source_line)
5598         (tui_show_source_content, tui_source_window_base::refill)
5599         (tui_source_window_base::set_is_exec_point_at)
5600         (tui_source_window_base::set_is_exec_point_at)
5601         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5602         (tui_alloc_source_buffer, tui_line_is_displayed)
5603         (tui_addr_is_displayed): Change type of win_info.  Update.
5604         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5605         (tui_source_window_base::do_make_visible_with_new_height):
5606         Update.
5607         * tui/tui-source.c (tui_set_source_content)
5608         (tui_set_source_content_nil)
5609         (tui_source_window::do_scroll_vertical): Update.
5610         * tui/tui-layout.c (show_layout): Update.
5611         * tui/tui-disasm.c (tui_set_disassem_content)
5612         (tui_disasm_window::do_scroll_vertical): Update.
5613         * tui/tui-data.h (tui_win_content): Remove.
5614         (struct tui_gen_win_info) <content, content_size>: Remove.
5615         (struct tui_source_element): Add initializers and destructor.
5616         (union tui_which_element, struct tui_win_element): Remove.
5617         (struct tui_source_window_base) <content>: New field.
5618         (struct tui_data_window): Remove destructor.
5619         (tui_alloc_content, tui_free_win_content)
5620         (tui_free_all_source_wins_content): Don't declare.
5621         * tui/tui-data.c (tui_initialize_static_data): Update.
5622         (init_content_element, tui_alloc_content): Remove.
5623         (~tui_gen_win_info): Update.
5624         (~tui_data_window, tui_free_all_source_wins_content)
5625         (tui_free_win_content, free_content, free_content_elements):
5626         Remove.
5627
5628 2019-06-25  Tom Tromey  <tom@tromey.com>
5629
5630         * tui/tui-winsource.h (tui_clear_source_content)
5631         (tui_erase_source_content, tui_show_source_content): Change type
5632         of win_info.
5633         * tui/tui-winsource.c (tui_clear_source_content)
5634         (tui_erase_source_content, tui_show_source_content): Change type
5635         of win_info.
5636         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5637         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5638         win_info.
5639         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5640         win_info.
5641         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5642
5643 2019-06-25  Tom Tromey  <tom@tromey.com>
5644
5645         * tui/tui-winsource.c (tui_clear_source_content)
5646         (tui_source_window_base::set_is_exec_point_at): Update.
5647         * tui/tui-source.c (tui_set_source_content_nil): Update.
5648         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5649         a bool.
5650         * tui/tui-data.c (init_content_element): Update.
5651
5652 2019-06-25  Tom Tromey  <tom@tromey.com>
5653
5654         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5655         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5656         * tui/tui-layout.c (init_and_make_win): Update.
5657         * tui/tui.h (enum tui_win_type): Update.
5658         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5659         tui_win_is_auxillary.
5660         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5661         tui_win_is_auxillary.
5662
5663 2019-06-25  Tom Tromey  <tom@tromey.com>
5664
5665         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5666         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5667         (tui_delete_data_content_windows, tui_display_all_data)
5668         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5669         Update.
5670         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5671         * tui/tui-regs.c (tui_last_regs_line_no)
5672         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5673         (tui_show_registers): Update.
5674         (tui_show_register_group): Return void.  Update.
5675         (tui_display_registers_from, tui_display_reg_element_at_line)
5676         (tui_display_registers_from_line, tui_check_register_values):
5677         Update.
5678         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5679         member.
5680         (struct tui_data_window) <regs_content>: Now a std::vector.
5681         <regs_content_count>: Remove.
5682         (tui_add_content_elements, tui_free_data_content): Don't declare.
5683         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5684         (init_content_element): Remove DATA_WIN case.  Add assert.
5685         (tui_add_content_elements): Remove.
5686         (tui_data_window): Update.
5687         (tui_free_data_content): Remove.
5688         (free_content_elements): Remove DATA_WIN case.
5689
5690 2019-06-25  Tom Tromey  <tom@tromey.com>
5691
5692         * tui/tui-data.c (tui_data_item_window): Update.
5693         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5694         * tui/tui-windata.c (tui_display_all_data)
5695         (tui_display_data_from_line): Update.
5696         (tui_check_data_values): Remove.
5697         * tui/tui-regs.c (tui_show_register_group)
5698         (tui_display_reg_element_at_line): Update.
5699         * tui/tui-hooks.c (tui_register_changed)
5700         (tui_refresh_frame_and_register_information): Call
5701         tui_check_register_values.
5702         * tui/tui-data.h (struct tui_data_window) <data_content,
5703         data_content_count, data_type>: Remove.
5704         (enum tui_data_type): Remove.
5705
5706         * tui/tui-data.c (tui_data_window::clear_detail)
5707         (~tui_data_window): Update.
5708
5709 2019-06-25  Tom Tromey  <tom@tromey.com>
5710
5711         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5712         declare.
5713         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5714         Rename from tui_first_data_item_displayed.  Update.
5715         (tui_data_window::refresh_all)
5716         (tui_data_window::do_scroll_vertical): Update.
5717         * tui/tui-data.h (struct tui_data_window)
5718         <first_data_item_displayed>: Declare new method.
5719
5720 2019-06-25  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5723         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5724         contents...
5725         (tui_initialize_static_data): ...here.
5726
5727 2019-06-25  Tom Tromey  <tom@tromey.com>
5728
5729         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5730         (tui_display_registers_from, tui_check_register_values): Update.
5731         (tui_display_register): Remove win_info parameter; update.
5732         (tui_get_register): Change type of parameters.
5733         * tui/tui-data.h (struct tui_data_element): Remove.
5734         (union tui_which_element) <data>: Remove.
5735         <data_window>: Change type.
5736         (struct tui_data_item_window): New.
5737         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5738         case.  Add assert.
5739         (~tui_data_item_window): New destructor.
5740         (free_content_elements): Remove DATA_ITEM_WIN case.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5745         Remove.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-data.h (struct tui_command_element): Remove.
5750         (union tui_which_element) <command>: Remove.
5751         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5752         assert.
5753         (free_content_elements): Remove CMD_WIN case.
5754
5755 2019-06-25  Tom Tromey  <tom@tromey.com>
5756
5757         * tui/tui-layout.c (tui_set_layout): Update.
5758         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5759         * tui/tui-data.c (layout_def): Update.
5760
5761 2019-06-25  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5764         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5765         (tui_source_window_base::set_new_height): Update.
5766         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5767         Update.
5768         (tui_set_locator_fullname, tui_set_locator_info)
5769         (tui_show_frame_info): Update.
5770         * tui/tui-source.c (tui_set_source_content)
5771         (tui_source_is_displayed): Update.
5772         * tui/tui-layout.c (show_source_disasm_command, show_data)
5773         (show_source_or_disasm_and_command): Update.
5774         * tui/tui-disasm.c (tui_set_disassem_content)
5775         (tui_get_begin_asm_address): Update.
5776         * tui/tui-data.h (struct tui_locator_element): Remove.
5777         (union tui_which_element) <locator>: Remove.
5778         (struct tui_locator_window): New.
5779         (tui_locator_win_info_ptr): Change return type.
5780         * tui/tui-data.c (_locator): Change type.
5781         (tui_locator_win_info_ptr): Change return type.
5782         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5783         (tui_alloc_content): Add assert.
5784
5785 2019-06-25  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-winsource.c
5788         (tui_exec_info_window::maybe_allocate_content): New method.
5789         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5790         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5791         (make_source_or_disasm_window): Add cast.
5792         * tui/tui-data.h (union tui_which_element) <simple_string>:
5793         Remove.
5794         (struct tui_source_info): New.
5795         (struct tui_source_window_base) <execution_info>: Change type.
5796         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5797         case, and add assert.
5798         (tui_alloc_content): Add assert.
5799
5800 2019-06-25  Tom Tromey  <tom@tromey.com>
5801
5802         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5803         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5804         * tui/tui-data.c (tui_alloc_win_info): Remove.
5805
5806 2019-06-25  Tom Tromey  <tom@tromey.com>
5807
5808         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5809         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5810         can_highlight.
5811
5812 2019-06-25  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5815         make_visible_with_new_height method.
5816         (tui_win_info::make_visible_with_new_height): New method.
5817         (tui_source_window_base::do_make_visible_with_new_height)
5818         (tui_data_window::do_make_visible_with_new_height)
5819         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5820         (make_visible_with_new_height): Remove.
5821         (tui_resize_all, tui_adjust_win_heights): Use
5822         make_visible_with_new_height method.
5823         * tui/tui-data.h (struct tui_win_info)
5824         <do_make_visible_with_new_height, make_visible_with_new_height>:
5825         New methods.
5826         (struct tui_source_window_base, struct tui_data_window)
5827         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5828         methods.
5829
5830 2019-06-25  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5833         method.
5834         (update_tab_width): Call update_tab_width method.
5835         * tui/tui-data.h (struct tui_win_info)
5836         (struct tui_source_window_base) <update_tab_width>: New methods.
5837
5838 2019-06-25  Tom Tromey  <tom@tromey.com>
5839
5840         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5841         parameter.
5842         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5843         parameter.
5844         (tui_gen_win_info::make_visible): Update.
5845         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5846         parameter.
5847         * tui/tui-data.h (enum tui_box): New enum.
5848         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5849
5850 2019-06-25  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5853         init_and_make_win for EXEC_INFO_WIN.
5854         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5855         longer inline.
5856         (struct tui_win_info) <~tui_win_info>: Inline.
5857         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5858         Don't declare.
5859         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5860         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5861         Remove.
5862         (tui_initialize_static_data): Update.
5863         (~tui_gen_win_info): Handle more cleanup here.
5864         (~tui_source_window_base): Delete "execution_info".
5865         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5866
5867 2019-06-25  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-layout.c (make_command_window): Don't set
5870         can_highlight.
5871         (show_source_disasm_command): Call the reset method.
5872         (show_data): Don't set can_highlight.  Call the reset method.
5873         (tui_gen_win_info::reset): Rename from init_gen_win_info
5874         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5875         (show_source_or_disasm_and_command): Call the reset method.
5876         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5877         (struct tui_cmd_window): Set can_highlight.
5878
5879 2019-06-25  Tom Tromey  <tom@tromey.com>
5880
5881         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5882         from make_visible.
5883         (tui_make_visible, tui_make_invisible): Rewrite.
5884         (tui_win_info::make_visible): Remove.
5885         (tui_source_window_base::make_visible): Update.
5886         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5887         method.  Moved from...
5888         (struct tui_win_info) <make_visible>: ...here.
5889
5890 2019-06-25  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-winsource.c
5893         (tui_source_window_base::do_scroll_horizontal): Remove direction
5894         parameter.
5895         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5896         direction parameter.
5897         * tui/tui-win.c (tui_win_info::forward_scroll)
5898         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5899         (tui_win_info::right_scroll): Update.
5900         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5901         direction parameter.
5902         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5903         direction parameter.
5904         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5905         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5906         Remove direction parameter.
5907         (struct tui_source_window_base, struct tui_source_window)
5908         (struct tui_disasm_window, struct tui_data_window)
5909         (struct tui_cmd_window): Update.
5910
5911 2019-06-25  Tom Tromey  <tom@tromey.com>
5912
5913         * tui/tui-winsource.h (tui_set_exec_info_content)
5914         (tui_show_exec_info_content, tui_erase_exec_info_content)
5915         (tui_clear_exec_info_content, tui_update_exec_info): Change
5916         argument to tui_source_window_base.
5917         * tui/tui-winsource.c (tui_set_exec_info_content)
5918         (tui_show_exec_info_content, tui_erase_exec_info_content)
5919         (tui_clear_exec_info_content, tui_update_exec_info): Change
5920         argument to tui_source_window_base.
5921
5922 2019-06-25  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5925         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5926
5927 2019-06-25  Tom Tromey  <tom@tromey.com>
5928
5929         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5930         check.
5931
5932 2019-06-25  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5935         type to void.
5936         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5937         type to void.
5938         * tui/tui-source.c (tui_set_source_content): Update.
5939         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5940
5941 2019-06-25  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-win.c (window_name_completer, tui_set_focus)
5944         (tui_all_windows_info): Use name method.
5945         * tui/tui-data.h (struct tui_gen_win_info)
5946         (struct tui_source_window, struct tui_disasm_window)
5947         (struct tui_data_window, struct tui_cmd_window) <name>: New
5948         method.
5949         (tui_win_name): Don't declare.
5950         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5951         (tui_win_name): Remove.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-winsource.h (tui_update_source_window)
5956         (tui_update_source_window_as_is): Change parameter type.
5957         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5958         to be a tui_source_window_base.
5959         (tui_update_source_window_as_is): Likewise.
5960         * tui/tui-win.c (make_visible_with_new_height): Update.
5961
5962 2019-06-25  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-winsource.c (tui_erase_source_content)
5965         (tui_show_source_content, tui_show_exec_info_content)
5966         (tui_erase_exec_info_content): Use refresh_window method.
5967         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5968         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5969         from tui_refresh_win.
5970         (tui_data_window::refresh_window): New method.
5971         (tui_win_info::refresh, tui_source_window_base::refresh)
5972         (tui_refresh_all): Use refresh_window method.
5973         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5974         method.
5975         * tui/tui-regs.c (tui_display_register): Call refresh_window
5976         method.
5977         * tui/tui-layout.c (show_source_disasm_command)
5978         (show_source_or_disasm_and_command): Call refresh_window method.
5979         * tui/tui-data.h (struct tui_gen_win_info)
5980         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5981         New method.
5982
5983 2019-06-25  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui.c (tui_rl_other_window, tui_enable)
5986         (tui_is_window_visible, tui_get_command_dimension): Update.
5987         * tui/tui-winsource.c (tui_update_source_window_as_is)
5988         (tui_clear_source_content, tui_erase_source_content)
5989         (tui_show_source_line, tui_source_window_base::refill)
5990         (tui_source_window_base::do_scroll_horizontal)
5991         (tui_source_window_base::set_is_exec_point_at)
5992         (tui_update_breakpoint_info, tui_set_exec_info_content)
5993         (tui_alloc_source_buffer, tui_line_is_displayed)
5994         (tui_addr_is_displayed): Update.
5995         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5996         (tui_check_and_display_highlight_if_needed)
5997         (tui_win_info::make_visible, tui_win_info::refresh)
5998         (tui_refresh_all): Update.
5999         * tui/tui-windata.c (tui_first_data_item_displayed)
6000         (tui_delete_data_content_windows, tui_erase_data_content)
6001         (tui_display_all_data, tui_data_window::refresh_all)
6002         (tui_check_data_values): Update.
6003         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6004         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6005         (tui_win_info::backward_scroll, tui_refresh_all_win)
6006         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6007         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6008         (tui_source_window_base::set_new_height)
6009         (tui_data_window::set_new_height)
6010         (make_invisible_and_set_new_height)
6011         (make_visible_with_new_height, new_height_ok)
6012         (parse_scrolling_args): Update.
6013         * tui/tui-stack.c (tui_show_frame_info): Update.
6014         * tui/tui-source.c (tui_set_source_content)
6015         (tui_set_source_content_nil, tui_source_is_displayed)
6016         (tui_source_window::do_scroll_vertical): Update.
6017         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6018         (tui_display_registers_from, tui_display_reg_element_at_line)
6019         (tui_check_register_values, tui_reg_command): Update.
6020         * tui/tui-layout.c (tui_default_win_height)
6021         (show_source_disasm_command, show_data, init_and_make_win)
6022         (show_source_or_disasm_and_command): Update.
6023         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6024         (tui_redisplay_readline, tui_mld_flush)
6025         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6026         (tui_getc): Update.
6027         * tui/tui-disasm.c (tui_set_disassem_content)
6028         (tui_disasm_window::do_scroll_vertical): Update.
6029         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6030         Now virtual.
6031         (struct tui_win_info): Derive from tui_gen_win_info.
6032         <~tui_win_info>: Mark as override.
6033         <generic>: Remove member.
6034         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6035         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6036         (~tui_data_window, ~tui_win_info)
6037         (tui_free_all_source_wins_content): Update.
6038         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6039
6040 2019-06-25  Tom Tromey  <tom@tromey.com>
6041
6042         * tui/tui-layout.c (init_and_make_win): Use new.
6043         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6044         destructor, initializers.
6045         (tui_alloc_generic_win_info): Don't declare.
6046         * tui/tui-data.c (_locator): Add argument to constructor.
6047         (source_win, disasm_win): New globals.
6048         (exec_info): Remove.
6049         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6050         Update.
6051         (tui_alloc_generic_win_info): Remove.
6052         (init_content_element): Use new.
6053         (tui_win_info::tui_win_info): Update.
6054         (free_content_elements) <case DATA_WIN>: Use delete.
6055
6056 2019-06-25  Tom Tromey  <tom@tromey.com>
6057
6058         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6059         * tui/tui-windata.c (tui_first_data_item_displayed)
6060         (tui_delete_data_content_windows): Update.
6061         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6062         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6063         (tui_display_registers_from, tui_check_register_values): Update.
6064         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6065         pointer.
6066         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6067         window.
6068         (tui_free_data_content): Update.
6069         (free_content_elements) <case DATA_WIN>: Free the window.
6070
6071 2019-06-25  Tom Tromey  <tom@tromey.com>
6072
6073         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6074         Update.
6075         * tui/tui-layout.c (make_command_window)
6076         (show_source_disasm_command, show_data, init_and_make_win)
6077         (show_source_or_disasm_and_command): Update.
6078         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6079         method.
6080         <can_highight, is_highlighted>: Now bool.
6081         (tui_set_win_highlight): Don't declare.
6082         * tui/tui-data.c (tui_set_win_highlight): Remove.
6083
6084 2019-06-25  Tom Tromey  <tom@tromey.com>
6085
6086         * tui/tui-wingeneral.c (make_visible): Remove check of window
6087         type.
6088
6089 2019-06-25  Tom Tromey  <tom@tromey.com>
6090
6091         * tui/tui-win.c (tui_win_info::max_height)
6092         (tui_cmd_window::max_height): New methods.
6093         (new_height_ok): Call max_height.
6094         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6095         <max_height>: New method.
6096
6097 2019-06-25  Tom Tromey  <tom@tromey.com>
6098
6099         * tui/tui-win.c (tui_source_window_base::set_new_height)
6100         (tui_data_window::set_new_height): New methods.
6101         (make_invisible_and_set_new_height): Call set_new_height method.
6102         * tui/tui-data.h (struct tui_win_info)
6103         (struct tui_source_window_base, struct tui_data_window)
6104         <set_new_height>: New method.
6105
6106 2019-06-25  Tom Tromey  <tom@tromey.com>
6107
6108         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6109         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6110         tui_refresh_data_win.
6111         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6112         method.
6113         (tui_refresh_all_win): Call the refresh_all method.
6114         (tui_set_focus): Likewise.
6115         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6116         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6117         Likewise.
6118
6119 2019-06-25  Tom Tromey  <tom@tromey.com>
6120
6121         * tui/tui-winsource.h (tui_refill_source_window)
6122         (tui_set_is_exec_point_at): Don't declare.
6123         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6124         (tui_source_window_base::refill): Rename from
6125         tui_refill_source_window.
6126         (tui_source_window_base::do_scroll_horizontal): Update.
6127         (tui_source_window_base::set_is_exec_point_at): Rename from
6128         tui_set_is_exec_point_at.
6129         (tui_update_all_breakpoint_info): Update.
6130         * tui/tui-stack.c (tui_show_frame_info): Update.
6131         * tui/tui-layout.c (show_data): Add cast.
6132         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6133         * tui/tui-data.h (struct tui_source_window_base) <refill,
6134         set_is_exec_point_at>: New methods.
6135         (tui_source_windows, tui_add_to_source_windows): Update types.
6136         (tui_add_to_source_windows): Remove redundant declaration.
6137         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6138         (tui_source_windows): Change return type.
6139         (tui_clear_source_windows_detail): Update.
6140         (tui_add_to_source_windows): Change type of parameter.
6141         (tui_free_all_source_wins_content): Update.
6142
6143 2019-06-25  Tom Tromey  <tom@tromey.com>
6144
6145         * tui/tui-wingeneral.c (tui_win_info::refresh)
6146         (tui_source_window_base::refresh): New methods.
6147         (tui_refresh_all): Call the refresh method.
6148         * tui/tui-data.h (struct tui_win_info)
6149         (struct tui_source_window_base) <refresh>: New method.
6150
6151 2019-06-25  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui.h (tui_is_window_visible): Return bool.
6154         * tui/tui.c (tui_is_window_visible): Return bool.
6155         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6156         (tui_make_visible, tui_make_invisible)
6157         (tui_win_info::make_visible)
6158         (tui_source_window_base::make_visible, make_all_visible)
6159         (tui_make_all_visible, tui_make_all_invisible): Update.
6160         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6161         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6162         bool.
6163         (struct tui_win_info, struct tui_source_window_base)
6164         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6165         * tui/tui-data.c (tui_init_generic_part): Update.
6166
6167 2019-06-25  Tom Tromey  <tom@tromey.com>
6168
6169         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6170         (tui_source_window_base::make_visible): New methods.
6171         (make_all_visible): Make method call.
6172         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6173         (struct tui_source_window_base, struct tui_cmd_window): Override
6174         make_visible.
6175         (tui_win_is_source_type): Don't declare.
6176         * tui/tui-data.c (tui_win_is_source_type): Remove.
6177
6178 2019-06-25  Tom Tromey  <tom@tromey.com>
6179
6180         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6181         NULL check.
6182
6183 2019-06-25  Tom Tromey  <tom@tromey.com>
6184
6185         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6186         Inline constructor.  Add initializers for members.
6187         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6188         constructors; now inline in class.
6189
6190 2019-06-25  Tom Tromey  <tom@tromey.com>
6191
6192         * tui/tui-regs.c (tui_show_registers): Update.
6193         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6194         bool.
6195         * tui/tui-data.c (tui_data_window::clear_detail)
6196         (tui_data_window): Update.
6197
6198 2019-06-25  Tom Tromey  <tom@tromey.com>
6199
6200         * tui/tui-windata.c (tui_display_all_data)
6201         (tui_display_data_from_line, tui_display_data_from)
6202         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6203         Update.
6204         * tui/tui-regs.c (tui_last_regs_line_no)
6205         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6206         (tui_show_registers, tui_show_register_group)
6207         (tui_display_registers_from, tui_display_reg_element_at_line)
6208         (tui_display_registers_from_line, tui_check_register_values)
6209         (tui_reg_next, tui_reg_prev): Update.
6210         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6211         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6212         tui_data_window.
6213         (struct tui_win_info) <detail>: Remove.  Add new fields from
6214         tui_data_info.
6215         (TUI_DATA_WIN): Add cast.
6216         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6217         (~tui_data_window): Simplify.
6218
6219 2019-06-25  Tom Tromey  <tom@tromey.com>
6220
6221         * tui/tui-layout.c (show_source_disasm_command)
6222         (show_source_or_disasm_and_command): Update.
6223         * tui/tui-io.c (update_cmdwin_start_line)
6224         (tui_redisplay_readline): Update.
6225         * tui/tui-data.h (struct tui_command_info): Remove.
6226         (struct tui_win_info) <detail>: Remove command_info member.
6227         (struct tui_data_window) <start_line>: New member, from
6228         tui_command_info.
6229         (TUI_CMD_WIN): Add casts.
6230
6231 2019-06-25  Tom Tromey  <tom@tromey.com>
6232
6233         * tui/tui-winsource.c (tui_update_source_window)
6234         (tui_refill_source_window)
6235         (tui_source_window_base::do_scroll_horizontal)
6236         (tui_update_breakpoint_info, tui_set_exec_info_content)
6237         (tui_show_exec_info_content, tui_erase_exec_info_content)
6238         (tui_clear_exec_info_content): Update.
6239         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6240         Update.
6241         * tui/tui-win.c (make_invisible_and_set_new_height)
6242         (make_visible_with_new_height): Update.
6243         * tui/tui-source.c (tui_set_source_content)
6244         (tui_show_symtab_source): Update.
6245         * tui/tui-layout.c (extract_display_start_addr)
6246         (show_source_disasm_command, show_data)
6247         (make_source_or_disasm_window)
6248         (show_source_or_disasm_and_command): Update.
6249         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6250         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6251         "gdbarch".
6252         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6253         to tui_source_window_base.
6254         (struct tui_win_info) <detail>: Remove source_info member.
6255         (struct tui_source_window_base) <has_locator>: Inline.
6256         Move contents from tui_source_info; rename has_locator member to
6257         m_has_locator.
6258         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6259         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6260         header file.
6261         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6262         Simplify.
6263         (tui_free_all_source_wins_content): Cast to
6264         tui_source_window_base.
6265
6266 2019-06-25  Tom Tromey  <tom@tromey.com>
6267
6268         * tui/tui-win.c (make_invisible_and_set_new_height)
6269         (make_visible_with_new_height): Call has_locator method.
6270         * tui/tui-layout.c (show_source_disasm_command, show_data)
6271         (show_source_or_disasm_and_command): Update for bool change.
6272         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6273         (tui_win_info) <has_locator>: New method.
6274         (struct tui_source_window_base) <has_locator>: New method.
6275         (tui_win_has_locator): Don't declare.
6276         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6277         from tui_win_has_locator.
6278         (tui_source_window_base): Use false, not FALSE.
6279
6280 2019-06-25  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6283         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6284         clear_detail method directly.
6285         (tui_clear_win_detail): Remove.
6286
6287 2019-06-25  Tom Tromey  <tom@tromey.com>
6288
6289         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6290         "this", not TUI_DISASM_WIN.
6291
6292 2019-06-25  Tom Tromey  <tom@tromey.com>
6293
6294         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6295         declare.
6296         * tui/tui-winsource.c
6297         (tui_source_window_base::do_scroll_horizontal): Rename from
6298         tui_horizontal_source_scroll.
6299         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6300         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6301         from tui_vertical_data_scroll.
6302         * tui/tui-win.h (tui_scroll): Don't declare.
6303         * tui/tui-win.c (tui_win_info::forward_scroll)
6304         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6305         (tui_win_info::right_scroll): Rename and update.
6306         (tui_scroll_forward_command, tui_scroll_backward_command)
6307         (tui_scroll_left_command, tui_scroll_right_command): Update.
6308         (tui_scroll): Remove.
6309         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6310         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6311         from tui_vertical_source_scroll.
6312         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6313         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6314         from tui_vertical_disassem_scroll.
6315         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6316         do_scroll_horizontal>: New methods.
6317         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6318         Likewise.
6319         (struct tui_source_window_base): Add do_scroll_horizontal.
6320         (struct tui_source_window, struct tui_disasm_window): Add
6321         do_scroll_vertical.
6322         (struct tui_data_window, struct tui_cmd_window): Add
6323         do_scroll_horizontal and do_scroll_vertical.
6324         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6325
6326 2019-06-25  Tom Tromey  <tom@tromey.com>
6327
6328         * tui/tui-data.h (struct tui_source_window_base): New struct.
6329         (struct tui_source_window): Derive from tui_source_window_base.
6330         (struct tui_disasm_window): New struct.
6331         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6332         from tui_source_window::clear_detail.
6333         (tui_source_window_base): Rename from tui_source_window.
6334         (~tui_source_window_base): Rename from ~tui_source_window.
6335         (tui_alloc_win_info): Create a tui_disasm_window.
6336
6337 2019-06-25  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-data.h (struct tui_source_window)
6340         (struct tui_data_window): Declare destructors.
6341         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6342         destructors.
6343         (tui_win_info): Simplify.
6344
6345 2019-06-25  Tom Tromey  <tom@tromey.com>
6346
6347         * tui/tui-winsource.c (tui_display_main)
6348         (tui_update_source_windows_with_addr)
6349         (tui_update_all_breakpoint_info): Update.
6350         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6351         (new_height_ok, parse_scrolling_args): Update.
6352         * tui/tui-stack.c (tui_show_frame_info): Update.
6353         * tui/tui-data.h (struct tui_list): Remove.
6354         (tui_source_windows): Return a reference to a std::vector.
6355         * tui/tui-data.c (source_windows): Now a std::vector.
6356         (tui_source_windows): Change return type.
6357         (tui_clear_source_windows): Rewrite.
6358         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6359         (tui_free_all_source_wins_content): Rewrite.
6360
6361 2019-06-25  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6364         (struct tui_data_window, struct tui_cmd_window): Declare
6365         clear_detail method.
6366         * tui/tui-data.c (tui_source_window::clear_detail)
6367         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6368         methods.
6369         (tui_clear_win_detail): Simplify.
6370
6371 2019-06-25  Tom Tromey  <tom@tromey.com>
6372
6373         * tui/tui-layout.c (make_source_window, make_disasm_window)
6374         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6375         Return the new window.
6376         (show_source_disasm_command, show_data)
6377         (show_source_or_disasm_and_command): Update.
6378
6379 2019-06-25  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6382         parameter.  Return the new window.
6383         (show_source_disasm_command): Update and remove NULL check.
6384         (show_source_or_disasm_and_command): Update.
6385
6386 2019-06-25  Tom Tromey  <tom@tromey.com>
6387
6388         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6389
6390 2019-06-25  Tom Tromey  <tom@tromey.com>
6391
6392         * tui/tui-data.h (struct tui_win_info): Make constructor
6393         protected.  Make destructor virtual.  Add initializers.
6394         (tui_source_window, tui_data_window, tui_cmd_window): New
6395         classes.
6396         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6397         constructor.  Add "type" parameter.
6398         (tui_source_window, tui_data_window, tui_cmd_window): New
6399         constructors.
6400         (tui_alloc_win_info): Instantiate the appropriate subclass.
6401
6402 2019-06-25  Tom Tromey  <tom@tromey.com>
6403
6404         * tui/tui-win.c (tui_resize_all): Use delete.
6405         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6406         destructor.
6407         (tui_free_window): Don't declare.
6408         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6409         Update.
6410
6411 2019-06-25  Tom Tromey  <tom@tromey.com>
6412
6413         * tui/tui-data.h (struct tui_win_info): Add constructor.
6414         * tui/tui-data.c (tui_alloc_win_info): Use new.
6415         (tui_free_window): Use delete.
6416
6417 2019-06-22  Tom Tromey  <tom@tromey.com>
6418
6419         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6420         declare.
6421         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6422
6423 2019-06-22  Tom Tromey  <tom@tromey.com>
6424
6425         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6426         declare.
6427         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6428
6429 2019-06-22  Tom de Vries  <tdevries@suse.de>
6430
6431         * dwarf2read.c (create_addrmap_from_aranges)
6432         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6433         instead of '%zu'.
6434
6435 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6436
6437         * dwarf2read.h (dwarf2_section_info_def): Remove.
6438         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6439         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6440         std::vector<dwarf2_section_info>.
6441         (struct dwo_file) <~dwo_file>: Remove.
6442         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6443         types field.
6444         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6445         (dwarf2_read_debug_names): Likewise.
6446         (create_debug_types_hash_table): Change parameter type to
6447         array_view, adjust code accordingly.
6448         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6449         (partial_die_info::fixup): Likewise.
6450         (determine_prefix): Likewise.
6451         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6452
6453 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6454
6455         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6456         gdb_bfd_ref_ptr.
6457         <~dwo_file>: Remove call to gdb_bfd_unref.
6458         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6459         gdb_bfd_ref_ptr::get.
6460
6461 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6462
6463         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6464         type to htab_up.
6465         * dwarf2read.c (struct dwo_file): Initialize fields.
6466         <~dwo_file>: New.
6467         (free_dwo_file): Remove, move content to ~dwo_file.
6468         (struct dwo_file_deleter): Remove.
6469         (dwo_file_up>: Remove custom deleter.
6470         (free_dwo_files): Remove.
6471         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6472         dwo_files.
6473         (process_skeletonless_type_units): Call unique_ptr::get.
6474         (allocate_dwo_file_hash_table): Add deleter to created hash
6475         table.  Change return type to htab_up.
6476         (lookup_dwo_file_slot): Don't memset dwo_file, call
6477         unique_ptr::get.
6478         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6479         (create_dwo_unit_in_dwp_v2): Likewise.
6480         (open_and_init_dwo_file): Likewise.
6481         (free_dwo_file_from_slot): Remove.
6482
6483 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6484
6485         * dwarf2read.h (struct dwarf2_section_info) <readin,
6486         is_virtual>: Change type to bool.
6487         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6488         true instead of 1.
6489
6490 2019-06-19  Tom Tromey  <tom@tromey.com>
6491
6492         * tui/tui-data.h (tui_init_content_element): Don't declare.
6493
6494 2019-06-19  Tom Tromey  <tom@tromey.com>
6495
6496         * tui/tui-data.h (tui_init_win_info): Don't declare.
6497
6498 2019-06-19  Tom de Vries  <tdevries@suse.de>
6499
6500         * dwarf2read.h (abstract_to_concrete): Change type to
6501         std::unordered_map<sect_offset, std::vector<sect_offset>,
6502         gdb::hash_enum<sect_offset>>.
6503
6504 2019-06-19  Tom Tromey  <tromey@adacore.com>
6505
6506         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6507         EVAL_AVOID_SIDE_EFFECTS specially.
6508
6509 2019-06-19  Tom Tromey  <tromey@adacore.com>
6510
6511         * source-cache.c (highlighter): New global.
6512         (source_cache::get_source_lines): Create a highlighter on demand.
6513
6514 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * defs.h (deprecated_interactive_hook): Delete declaration.
6517         * interps.c (clear_interpreter_hooks): Remove use of
6518         deprecated_interactive_hook.
6519         * top.c (deprecated_interactive_hook): Delete definition.
6520         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6521
6522 2019-06-18  Tom de Vries  <tdevries@suse.de>
6523
6524         PR gdb/24515
6525         * dwarf2read.h (abstract_to_concrete): Change type from
6526         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6527         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6528         * dwarf2read.c (read_variable): Update.
6529         (dwarf2_fetch_die_loc_sect_off): Update.
6530
6531 2019-06-17  Tom de Vries  <tdevries@suse.de>
6532
6533         PR gdb/24617
6534         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6535         accessing parent[parent_len - 1].
6536
6537 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6538
6539         PR gdb/24364
6540         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6541         call dtrace_process_dof with NULL dof.
6542
6543 2019-06-16  Tom de Vries  <tdevries@suse.de>
6544
6545         PR gdb/24445
6546         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6547
6548 2019-06-16  Tom Tromey  <tom@tromey.com>
6549
6550         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6551         (make_all_visible): Use address of member.
6552
6553 2019-06-16  Tom Tromey  <tom@tromey.com>
6554
6555         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6556         (tui_free_window, free_content, free_content_elements): Remove
6557         unnecessary cast.
6558         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6559         cast.
6560         * tui/tui-regs.c (tui_show_register_group)
6561         (tui_display_registers_from, tui_display_reg_element_at_line):
6562         Remove unnecessary cast.
6563
6564 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * linux-nat.c (normal_mask): Delete.
6567         (_initialize_linux_nat): Don't initialise normal_mask.
6568
6569 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6570
6571         PR gdb/24445
6572         * dwarf-index-write.h (write_psymtabs_to_index): Add
6573         dwz_basename parameter.
6574         * dwarf-index-write.c (write_gdbindex): Move file writing to
6575         write_gdbindex_1.  Change return type void.
6576         (assert_file_size): Move up, remove filename parameter.
6577         (write_gdbindex_1): New function.
6578         (write_debug_names): Change return type to void, call
6579         assert_file_size.
6580         (struct index_wip_file): New struct.
6581         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6582         file logic to index_wip_file.  Write index for dwz file if
6583         needed.
6584         (save_gdb_index_command): Pass basename of dwz file, if present.
6585         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6586         build-id of dwz file, if present.
6587         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6588         (dwarf2_get_dwz_file): Likewise.
6589         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6590         (dwarf2_get_dwz_file): Likewise.
6591
6592 2019-06-16  Tom Tromey  <tom@tromey.com>
6593
6594         * coffread.c (process_coff_symbol): Use xstrdup.
6595         * value.c (create_internalvar): Use xstrdup.
6596
6597 2019-06-16  Tom Tromey  <tom@tromey.com>
6598
6599         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6600         * breakpoint.c (stopin_command, stopat_command)
6601         (until_break_command, decode_location_default): Remove unnecessary
6602         cast.
6603         * utils.c (subset_compare): Remove unnecessary cast.
6604         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6605         cast.
6606         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6607         cast.
6608         * infcmd.c (path_command): Remove unnecessary cast.
6609         * coffread.c (decode_type): Remove unnecessary cast.
6610         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6611         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6612         * tui/tui-stack.c (tui_show_locator_content)
6613         (tui_show_frame_info): Remove unnecessary cast.
6614         * tui/tui-win.c (tui_scroll_forward_command)
6615         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6616         (parse_scrolling_args): Remove unnecessary cast.
6617         * tui/tui-data.c (init_win_info, tui_del_window)
6618         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6619         (free_content_elements): Remove unnecessary cast.
6620         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6621         unnecessary cast.
6622         * tui/tui-source.c (tui_set_source_content)
6623         (tui_vertical_source_scroll): Remove unnecessary cast.
6624         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6625         cast.
6626         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6627         * tui/tui-regs.c (tui_display_registers_from)
6628         (tui_display_register): Remove unnecessary cast.
6629         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6630         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6631         (make_visible): Remove unnecessary cast.
6632         * tui/tui-winsource.c (tui_erase_source_content)
6633         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6634         unnecessary cast.
6635         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6636         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6637         * stabsread.c (read_type, read_array_type, read_range_type):
6638         Remove unnecessary cast.
6639         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6640         (parse_symbol, parse_type, upgrade_type, parse_external)
6641         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6642         unnecessary cast.
6643         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6644
6645 2019-06-16  Tom Tromey  <tom@tromey.com>
6646
6647         * tui/tui-data.c (tui_alloc_generic_win_info)
6648         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6649         checks.
6650
6651 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6652             Andrew Burgess  <andrew.burgess@embecosm.com>
6653
6654         * f-typeprint.c (f_print_type): Don't return early for not
6655         associated or not allocated types.
6656         (f_type_print_varspec_suffix): Add print_rank parameter and print
6657         ranks of array types in case they dangling.
6658         (f_type_print_base): Add print_rank parameter.
6659
6660 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * NEWS: Mention new MI commands.
6663         * break-catch-throw.c (enum exception_event_kind): Move to
6664         breakpoint.h.
6665         (print_mention_exception_catchpoint): Output text as a single
6666         message.
6667         (catch_exception_command_1): Rename to...
6668         (catch_exception_event): ...this, make non-static, update header
6669         command, and change some parameter types.
6670         (catch_catch_command): Update for changes to
6671         catch_exception_command_1.
6672         (catch_throw_command): Likewise.
6673         (catch_rethrow_command): Likewise.
6674         * breakpoint.c (enum exception_event_kind): Delete.
6675         * breakpoint.h (enum exception_event_kind): Moved here from
6676         break-catch-throw.c.
6677         (catch_exception_event): Declare.
6678         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6679         (mi_cmd_catch_throw): New function.
6680         (mi_cmd_catch_rethrow): New function.
6681         (mi_cmd_catch_catch): New function.
6682         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6683         'catch-catch' entries.
6684         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6685         (mi_cmd_catch_rethrow): Declare.
6686         (mi_cmd_catch_catch): Declare.
6687
6688 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6689
6690         * annotate.c (annotate_source_line): Change return type to void,
6691         update implementation to match.
6692         * annotate.h (annotate_source_line): Change return type to void,
6693         update header comment.
6694         * stack.c (print_frame_info): Don't change what frame information
6695         is printed based on whether annotations are on or not.
6696
6697 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6698
6699         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6700         (annotate_source): Make static.
6701         (annotate_source_line): Moved from source.c and renamed from
6702         identify_source_line.  Update the return type.
6703         * annotate.h (annotate_source): Delete declaration.
6704         (annotate_source_line): Declaration moved from source.h, and
6705         renamed from identify_source_line.  Return type updated.
6706         * source.c (identify_source_line): Moved to annotate.c and renamed
6707         to annotate_source_line.
6708         (info_line_command): Remove check of annotation_level.
6709         * source.h (identify_source_line): Move declaration to annotate.h
6710         and rename to annotate_source_line.
6711         * stack.c: Add 'annotate.h' include.
6712         (print_frame_info): Remove check of annotation_level before
6713         calling annotate_source_line.
6714
6715 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6716
6717         * source-cache.c (source_cache::get_plain_source_lines): Use
6718         open_source_file_with_line_charpos instead of just
6719         open_source_file, remove call to find_source_lines.
6720         (source_cache::get_source_lines): Likewise.
6721         * source.c (find_source_lines): Make static.
6722         (get_filename_and_charpos): Renamed into...
6723         (open_source_file_with_line_charpos): ..this along with changes to
6724         return a scoped_fd, and some other minor clean ups.
6725         (identify_source_line): Use open_source_file_with_line_charpos.
6726         (search_command_helper): Use open_source_file_with_line_charpos
6727         instead of just open_source_file, remove call to
6728         find_source_lines.
6729         * source.h (open_source_file_with_line_charpos): Declare new
6730         function.
6731         (find_source_lines): Delete declaration.
6732
6733 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * source.c (get_filename_and_charpos): Remove fullname
6736         parameter.
6737         (identify_source_line): Update call to get_filename_and_charpos.
6738
6739 2019-06-14  Tom Tromey  <tromey@adacore.com>
6740
6741         PR gdb/24502:
6742         * ui-style.h (skip_ansi_escape): Update comment.
6743         * ui-file.h (class no_terminal_escape_file): New class.
6744         * ui-file.c (no_terminal_escape_file::write)
6745         (no_terminal_escape_file::puts): New methods.
6746         * cli/cli-logging.c (handle_redirections): Use
6747         no_terminal_escape_file.
6748
6749 2019-06-14  Tom Tromey  <tromey@adacore.com>
6750
6751         * NEWS: Move convenience variable news above Python news.
6752
6753 2019-06-14  Tom Tromey  <tom@tromey.com>
6754
6755         * gnulib: Move directory to top-level.
6756         * configure.ac: Don't configure gnulib.
6757         * configure: Rebuild.
6758         * common/common-defs.h: Use new path to gnulib.
6759         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6760         (GNULIB_H): Remove.
6761         (INCGNU): Look in new gnulib location.
6762         (HFILES_NO_SRCDIR): Remove gnulib files.
6763         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6764         (generated_files): Remove GNULIB_H.
6765         ($(LIBGNU), all-lib): Remove targets.
6766         (distclean): Don't mention GNULIB_BUILDDIR.
6767         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6768
6769 2019-06-14  Tom Tromey  <tromey@adacore.com>
6770
6771         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6772         Warn if symbol file does not provide any symbols.
6773
6774 2019-06-14  Tom Tromey  <tromey@adacore.com>
6775
6776         * source.c (find_and_open_source): Respect basenames_may_differ.
6777
6778 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * annotate.c (annotate_breakpoints_invalid): Make use of
6781         scoped_restore_terminal_state.
6782         (annotate_frames_invalid): Likewise.
6783
6784 2019-06-14  Tom Tromey  <tromey@adacore.com>
6785
6786         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6787         allow assignment to an internalvar.
6788
6789 2019-06-14  Tom Tromey  <tromey@adacore.com>
6790
6791         * ada-lex.l: Allow "_" in attribute names.
6792
6793 2019-06-14  Tom Tromey  <tromey@adacore.com>
6794
6795         PR gdb/24653:
6796         * regcache.c (registers_changed): Don't call alloca.
6797         * top.c (execute_command): Don't call alloca.
6798
6799 2019-06-13  Pedro Alves  <palves@redhat.com>
6800
6801         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6802         'expression'.  When parsing an expression, error out if there's
6803         junk after "unlimited".
6804         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6805         (do_set_command): Adjust calls to is_unlimited_literal.
6806
6807 2019-06-13  Pedro Alves  <palves@redhat.com>
6808
6809         * compile/compile.c (make_compile_options_def_group): Add braces
6810         around array_view initializer.
6811         * thread.c (make_thread_apply_all_options_def_group)
6812         (make_thread_apply_all_options_def_group): Likewise.
6813
6814 2019-06-13  Pedro Alves  <palves@redhat.com>
6815
6816         * NEWS (New commands): Mention "maint test-options
6817         require-delimiter", "maint test-options unknown-is-error", "maint
6818         test-options unknown-is-operand" and "maint show
6819         test-options-completion-result".
6820         (New command options, command completion): New section.
6821         (Completion improvements): New section.
6822         Mention that you can abbreviate "unlimited".
6823
6824 2019-06-13  Pedro Alves  <palves@redhat.com>
6825
6826         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6827         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6828         * unittests/cli-utils-selftests.c (test_parse_flags)
6829         (test_parse_flags_qcs): Delete.
6830         (test_cli_utils): Don't call deleted functions.
6831
6832 2019-06-13  Pedro Alves  <palves@redhat.com>
6833
6834         * thread.c: Include "cli/cli-option.h".
6835         (tp_array_compar_ascending): Global.
6836         (tp_array_compar): Delete function.
6837         (tp_array_compar_ascending, tp_array_compar_descending): New
6838         functions.
6839         (ascending_option_def, qcs_flag_option_def)
6840         (thr_qcs_flags_option_defs)
6841         (make_thread_apply_all_options_def_group)
6842         (make_thread_apply_options_def_group): New.
6843         (thread_apply_all_command): Use gdb::option::process_options.
6844         (thread_apply_command_completer)
6845         (thread_apply_all_command_completer): New.
6846         (thread_apply_command): Use gdb::option::process_options.
6847         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6848         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6849         to generate help text of "thread apply".  Adjust "taas"'s help.
6850         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6851         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6852
6853 2019-06-13  Pedro Alves  <palves@redhat.com>
6854
6855         * thread.c (thread_apply_command): Check for invalid TID with
6856         isdigit instead of !isalpha.
6857
6858 2019-06-13  Pedro Alves  <palves@redhat.com>
6859
6860         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6861         (validate_flags_qcs): New.
6862         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6863         (validate_flags_qcs): Declare.
6864         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6865         (make_frame_apply_options_def_group): New.
6866         (frame_apply_command_count): Process options with
6867         gdb::option::process_options.
6868         (frame_apply_completer): New.
6869         (frame_apply_level_completer, frame_apply_all_completer)
6870         (frame_apply_completer): New.
6871         (_initialize_stack): Update help of "frame apply", "frame apply
6872         level", "frame apply all" and "faas" to mention supported options
6873         and install command completers.
6874         * stack.h (frame_apply_all_completer): Declare.
6875         * thread.c: Include "stack.h".
6876         (tfaas_command): Add "--".
6877         (_initialize_thread): Update help "tfaas" to mention supported
6878         options and install command completer.
6879
6880 2019-06-13  Pedro Alves  <palves@redhat.com>
6881
6882         * completer.c (complete_nested_command_line): New.
6883         (gdb_completion_word_break_characters_throw): Add assertion.
6884         * completer.h (complete_nested_command_line): Declare.
6885
6886 2019-06-13  Pedro Alves  <palves@redhat.com>
6887
6888         * stack.c (parse_backtrace_qualifiers): New.
6889         (backtrace_command): Use it.
6890         (backtrace_command_completer): Complete on qualifiers.
6891
6892 2019-06-13  Pedro Alves  <palves@redhat.com>
6893
6894         * frame.c: Include "cli/cli-option.h.
6895         (user_set_backtrace_options): New.
6896         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6897         Delete.
6898         (get_prev_frame): Adjust.
6899         (boolean_option_def, uinteger_option_def)
6900         (set_backtrace_option_defs): New.
6901         (_initialize_frame): Adjust and use
6902         gdb::option::add_setshow_cmds_for_options to install "set
6903         backtrace past-main" and "set backtrace past-entry".
6904         * frame.h: Include "cli/cli-option.h".
6905         (struct frame_print_options): Forward declare.
6906         (print_frame_arguments_all, print_frame_arguments_scalars)
6907         (print_frame_arguments_none): Declare.
6908         (print_entry_values): Delete declaration.
6909         (struct frame_print_options, user_frame_print_options): New.
6910         (struct set_backtrace_options): New.
6911         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6912         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6913         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6914         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6915         (list_args_or_locals): Add frame_print_options parameter.
6916         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6917         * python/py-framefilter.c (enumerate_args): Pass down
6918         USER_FRAME_PRINT_OPTIONS.
6919         * stack.c: Include "cli/cli-option.h".
6920         (print_frame_arguments_all, print_frame_arguments_scalars)
6921         (print_frame_arguments_none): Declare.
6922         (print_raw_frame_arguments, print_entry_values): Delete.
6923         (user_frame_print_options): New.
6924         (boolean_option_def, enum_option_def, frame_print_option_defs):
6925         New.
6926         (struct backtrace_cmd_options): New.
6927         (bt_flag_option_def): New.
6928         (backtrace_command_option_defs): New.
6929         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6930         (print_frame_arg, read_frame_arg, print_frame_args)
6931         (print_frame_info, print_frame): Add frame_print_options parameter
6932         and use it.
6933         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6934         (backtrace_command_1): Add frame_print_options and
6935         backtrace_cmd_options parameters and use them.
6936         (make_backtrace_options_def_group): New.
6937         (backtrace_command): Process command options with
6938         gdb::option::process_options.
6939         (backtrace_command_completer): New.
6940         (_initialize_stack): Extend "backtrace"'s help to mention
6941         supported options.  Install completer for "backtrace".
6942         Install some settings commands with add_setshow_cmds_for_options.
6943
6944 2019-06-13  Pedro Alves  <palves@redhat.com>
6945
6946         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6947         and that "set/show print raw frame-arguments" are now deprecated.
6948
6949         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6950         command.
6951         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6952         * stack.c (_initialize_stack): Install "set/show print
6953         raw-frame-arguments", and deprecate "set/show print raw
6954         frame-arguments".
6955         * valprint.c (_initialize_valprint): Deprecate "set/show print
6956         raw".
6957
6958 2019-06-13  Pedro Alves  <palves@redhat.com>
6959
6960         * compile/compile.c (struct compile_options): New.
6961         (compile_flag_option_def, compile_command_option_defs)
6962         (make_compile_options_def_group): New.
6963         (compile_file_command): Handle options with
6964         gdb::option::process_options.
6965         (compile_file_command_completer): New function.
6966         (compile_code_command): Handle options with
6967         gdb::option::process_options.
6968         (compile_code_command_completer): New function.
6969         (_initialize_compiler): Install completers for "compile code" and
6970         "compile file".  Mention available options in "compile code" and
6971         "compile code"'s help.
6972         * completer.c (advance_to_completion_word): New, factored out from
6973         ...
6974         (advance_to_expression_complete_word_point): ... this.
6975         (advance_to_filename_complete_word_point): New.
6976         * completer.h (advance_to_filename_complete_word_point): New
6977         declaration.
6978
6979 2019-06-13  Pedro Alves  <palves@redhat.com>
6980
6981         * compile/compile.c: Include "cli/cli-option.h".
6982         (compile_print_value): Scope data pointer is now a
6983         value_print_options pointer; adjust.
6984         (compile_print_command): Process options.  Scope data pointer is
6985         now a value_print_options pointer; adjust.
6986         (_initialize_compile): Update "compile print"'s help to include
6987         supported options.  Install a completer for "compile print".
6988         * cp-valprint.c (show_vtblprint, show_objectprint)
6989         (show_static_field_print): Delete.
6990         (_initialize_cp_valprint): Don't install "set print
6991         static-members", "set print vtbl", "set print object" here.
6992         * printcmd.c: Include "cli/cli-option.h" and
6993         "common/gdb_optional.h".
6994         (print_command_parse_format): Rework to fill in a
6995         value_print_options instead of a format_data.
6996         (print_value): Change parameter type from format_data pointer to
6997         value_print_options reference.  Adjust.
6998         (print_command_1): Process options.  Adjust to pass down a
6999         value_print_options.
7000         (print_command_completer): New.
7001         (_initialize_printcmd): Install print_command_completer as
7002         handle_brkchars completer for the "print" command.  Update
7003         "print"'s help to include supported options.
7004         * valprint.c: Include "cli/cli-option.h".
7005         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7006         here from cp-valprint.c.
7007         (boolean_option_def, uinteger_option_def)
7008         (value_print_option_defs, make_value_print_options_def_group):
7009         New.  Use gdb::option::add_setshow_cmds_for_options to install
7010         "set print elements", "set print null-stop", "set print repeats",
7011         "set print pretty", "set print union", "set print array", "set
7012         print address", "set print symbol", "set print array-indexes".
7013         * valprint.h: Include <string> and "cli/cli-option.h".
7014         (make_value_print_options_def_group): Declare.
7015         (print_value): Change parameter type from format_data pointer to
7016         value_print_options reference.
7017         (print_command_completer): Declare.
7018
7019 2019-06-13  Pedro Alves  <palves@redhat.com>
7020
7021         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7022         (COMMON_SFILES): Add maint-test-settings.c.
7023         * cli/cli-decode.c (boolean_enums): New global, factored out from
7024         ...
7025         (add_setshow_boolean_cmd): ... here.
7026         * cli/cli-decode.h (boolean_enums): Declare.
7027         * cli/cli-option.c: New file.
7028         * cli/cli-option.h: New file.
7029         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7030         factored out from ...
7031         (parse_cli_boolean_value(const char *)): ... this.
7032         (is_unlimited_literal): Change parameter type to pointer to
7033         pointer.  Adjust and advance ARG pointer.
7034         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7035         (parse_cli_var_enum): New, factored out from ...
7036         (do_set_command): ... this.  Adjust.
7037         * cli/cli-setshow.h (parse_cli_boolean_value)
7038         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7039         (parse_cli_var_enum): Declare.
7040         * cli/cli-utils.c: Include "cli/cli-option.h".
7041         (get_ulongest): New.
7042         * cli/cli-utils.h (get_ulongest): Declare.
7043         (check_for_argument): New overloads.
7044         * maint-test-options.c: New file.
7045
7046 2019-06-13  Pedro Alves  <palves@redhat.com>
7047
7048         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7049         parse a range if "-" is at the end of the string.
7050
7051 2019-06-13  Pedro Alves  <palves@redhat.com>
7052
7053         * cli/cli-setshow.c (parse_auto_binary_operation)
7054         (parse_cli_boolean_value): Don't allow "o".
7055
7056 2019-06-13  Pedro Alves  <palves@redhat.com>
7057
7058         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7059         * NEWS: Mention maint test-settings KIND.
7060         * maint-test-settings.c: New file.
7061
7062 2019-06-13  Pedro Alves  <palves@redhat.com>
7063
7064         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7065         completer.
7066         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7067         "set" completers.
7068
7069 2019-06-13  Pedro Alves  <palves@redhat.com>
7070
7071         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7072         after item.
7073
7074 2019-06-13  Pedro Alves  <palves@redhat.com>
7075
7076         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7077
7078 2019-06-13  Pedro Alves <palves@redhat.com>
7079
7080         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7081         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7082         call.
7083         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7084         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7085         calls.
7086         (check_for_argument): Skip spaces after argument.
7087
7088 2019-06-13  Pedro Alves  <palves@redhat.com>
7089
7090         * thread.c (thread_apply_command): Adjust TID parsing.
7091         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7092         detected before end of string.
7093         (tid_is_in_list): Error out if LIST is invalid.
7094
7095 2019-06-13  Pedro Alves  <palves@redhat.com>
7096
7097         * completer.c (complete_line_internal_1): Rewind completion word
7098         point.
7099         (completion_tracker::advance_custom_word_point_by): Change
7100         parameter type to int.
7101         * completer.h (completion_tracker::advance_custom_word_point_by):
7102         Likewise.
7103
7104 2019-06-13  Pedro Alves  <palves@redhat.com>
7105
7106         * completer.c (advance_to_completion_word): Handle delimiters.
7107
7108 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7109
7110         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7111
7112 2019-06-11  Tom Tromey  <tom@tromey.com>
7113
7114         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7115         (xmalloc_failed): Move to alloc.c.
7116         * alloc.c: New file.
7117         * Makefile.in (COMMON_SFILES): Add alloc.c.
7118
7119 2019-06-11  Tom Tromey  <tom@tromey.com>
7120
7121         * nat/linux-waitpid.c: Don't include server.h.
7122         (linux_debug): Remove.
7123         (my_waitpid): Update.
7124
7125 2019-06-11  Tom Tromey  <tromey@adacore.com>
7126
7127         * infcall.c (_initialize_infcall): Remove trailing newline from
7128         help.
7129         * user-regs.c (_initialize_user_regs): Remove trailing newline
7130         from help.
7131         * typeprint.c (_initialize_typeprint): Remove trailing newline
7132         from help.
7133         * reverse.c (_initialize_reverse): Remove trailing newlines from
7134         help.
7135         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7136         from help.
7137         * language.c (add_set_language_command): Remove trailing newline
7138         from help.
7139         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7140         help.
7141         * disasm.c (_initialize_disasm): Remove trailing newline from
7142         help.
7143         * top.c (init_main): Remove trailing newline from help.
7144         * interps.c (_initialize_interpreter): Remove trailing newline
7145         from help.
7146         * btrace.c (_initialize_btrace): Remove trailing newlines from
7147         help.
7148         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7149         from help.
7150         * python/python.c (_initialize_python): Remove trailing newline
7151         from help.
7152         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7153         help.
7154         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7155         from help.  Reformat some text.
7156         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7157         from help.
7158         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7159         newline from help.
7160
7161 2019-06-11  Tom Tromey  <tromey@adacore.com>
7162
7163         * darwin-nat.c (darwin_decode_exception_message)
7164         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7165
7166 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7167
7168         * valops.c (value_slice): Check for not allocated or not
7169         associated values.
7170
7171 2019-06-10  Tom de Vries  <tdevries@suse.de>
7172
7173         PR gdb/24618
7174         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7175         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7176         invalid.
7177
7178 2019-06-10  Tom de Vries  <tdevries@suse.de>
7179
7180         PR gdb/24611
7181         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7182         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7183
7184 2019-06-10  Tom de Vries  <tdevries@suse.de>
7185
7186         PR symtab/24545
7187         * symtab.c (struct demangled_name_entry): Add language field.
7188         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7189         static minimal symbol".  Set and use language field.
7190
7191 2019-06-10  Tom Tromey  <tromey@adacore.com>
7192
7193         * ada-lang.c (_initialize_ada_language): Update help text.
7194
7195 2019-06-10  Tom Tromey  <tromey@adacore.com>
7196
7197         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7198         with a newline.
7199         * guile/guile.c (handle_boot_error): Don't end warning with a
7200         newline.
7201         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7202         warning with a newline.
7203         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7204         newline.
7205         (s12z_frame_cache): Likewise.
7206         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7207         a newline.
7208         * solib-svr4.c (disable_probes_interface): Don't end warning with
7209         a newline.
7210         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7211         newline.
7212         * python/python.c (do_finish_initialization): Don't end warning
7213         with a newline.
7214
7215 2019-06-10  Tom Tromey  <tom@tromey.com>
7216
7217         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7218         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7219         gdbpy_enter.
7220
7221 2019-06-10  Tom Tromey  <tromey@adacore.com>
7222
7223         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7224         data.
7225         (elf_new_init): Don't call stabsread_new_init.
7226         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7227         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7228         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7229
7230 2019-06-10  Tom de Vries  <tdevries@suse.de>
7231
7232         PR symtab/16264
7233         PR symtab/24517
7234         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7235
7236 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7237
7238         * source.c (find_and_open_source): Also rewrite relative file
7239         names.
7240
7241 2019-04-26  Amos Bird  <amosbird@gmail.com>
7242
7243         * annotate.c (annotate_thread_exited): Add "thread-exited"
7244         annotation.
7245
7246 2019-06-06  Tom Tromey  <tromey@adacore.com>
7247
7248         * maint.h (class scoped_command_stats): Use
7249         DISABLE_COPY_AND_ASSIGN.
7250         <print_time>: New method.
7251         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7252         print_time.
7253         (scoped_command_stats::print_time): New method.
7254
7255 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7258         instructions of lengths 6 or 8 bytes.
7259
7260 2019-06-04  Pedro Alves  <palves@redhat.com>
7261
7262         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7263
7264         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7265         * breakpoint.c (condition_completer): Likewise.
7266         * cli/cli-dump.c (scan_expression): Likewise.
7267         * common/filestuff.c (mkdir_recursive): Likewise.
7268         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7269         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7270         (gdb_abspath): Likewise.
7271         * compile/compile-cplus-types.c
7272         (compile_cplus_instance::decl_name): Likewise.
7273         * completer.c (complete_explicit_location):
7274         (signal_completer, reg_or_group_completer_1): Likewise.
7275         * cp-support.c (cp_remove_params_if_any): Likewise.
7276         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7277         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7278         * infcmd.c (strip_bg_char): Likewise.
7279         * linespec.c (copy_token_string): Likewise.
7280         * mi/mi-main.c (output_cores): Likewise.
7281         * psymtab.c (psymtab_search_name):
7282         * symfile.c (test_set_ext_lang_command): Likewise.
7283         * target.c (target_fileio_read_stralloc): Likewise.
7284         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7285         * value.c (complete_internalvar): Likewise.
7286
7287 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7288
7289         Add objfile property to gdb.Type.
7290         * NEWS: Mention Python API addition.
7291         * python/py-type.c (typy_get_objfile): New method.
7292
7293 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7294
7295         * NEWS: Mention the new set|show style [title|highlight].
7296         Mention changes to "show style", "help" and "apropos".
7297
7298 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7299
7300         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7301         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7302         instead of print_help_for_command.
7303         (print_doc_of_command): New function.
7304         (help_list): Add 'apropos -v word' suggestion.
7305         (print_help_for_command): Style the command name using title style.
7306         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7307         (_initialize_cli_cmds): Describe -v in apropos_command help.
7308
7309 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7310
7311         * cli/cli-style.h (cli_style_option): Add name in constructor,
7312         add m_name class member, add constructor with intensity,
7313         add name class function.
7314         (cli_style_option::add_setshow_commands): Remove name argument.
7315         (highlight_style, title_style): New styles.
7316         * cli/cli-style.c (do_show): New function that shows a style
7317         characteristic styling the style name with itself.
7318         (set_style_name): New function.
7319         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7320         Update all callers according to the changes in cli/cli-style.h.
7321         * utils.h (fputs_highlighted): New function.
7322         * utils.c (fputs_highlighted): Likewise.
7323
7324 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7325
7326         * NEWS: Mention new pipe command and new convenience variables.
7327
7328 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7329
7330         * cli/cli-cmds.c (pipe_command): New function.
7331         (_initialize_cli_cmds): Call add_com for pipe_command.
7332         Define | as an alias for pipe.
7333         (exit_status_set_internal_vars): New function.
7334         (shell_escape): Call exit_status_set_internal_vars.
7335         cli/cli-decode.c (find_command_name_length): Recognize | as
7336         a single character command.
7337
7338 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7339
7340         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7341         top.c (execute_command_to_ui_file): New function, mostly a copy
7342         of execute_command_to_string.
7343         (execute_command_to_string): Implement by calling
7344         execute_command_to_ui_file.
7345
7346 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7347
7348         * top.h (saved_command_line): Remove declaration.
7349         * top.c (previous_saved_command_line, previous_repeat_arguments):
7350         New variables.
7351         (saved_command_line): Make static, define together with other
7352         'repeat variables'.
7353         (dont_repeat): Clear repeat_arguments.
7354         (repeat_previous, get_saved_command_line, save_command_line):
7355         New functions.
7356         (gdb_init): Initialize saved_command_line
7357         and previous_saved_command_line.
7358         * main.c (captured_main_1): Remove saved_command_line initialization.
7359         * event-top.c (handle_line_of_input): Update to use
7360         the new 'repeat' related functions instead of direct access to
7361         saved_command_line.
7362         * command.h (repeat_previous, get_saved_command_line,
7363         save_command_line): New declarations.
7364         (dont_repeat): Add comment.
7365
7366 2019-05-30  Tom Tromey  <tromey@adacore.com>
7367
7368         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7369         Fix comment.
7370         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7371
7372 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7373
7374         PR cli/24587
7375         * completer.c (complete): Initialize variable word.
7376
7377 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7378
7379         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7380         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7381         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7382         'body' is NULL to the outter 'if', protecting the '!is_define'
7383         situation as well.
7384
7385 2019-05-29  Tom Tromey  <tromey@adacore.com>
7386
7387         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7388         (dwarf_unknown): New function.
7389         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7390         (dwarf_type_encoding_name): Use dwarf_unknown.
7391
7392 2019-05-29  Tom Tromey  <tromey@adacore.com>
7393
7394         PR c++/20020:
7395         * cp-valprint.c (cp_print_value_fields): Call
7396         cp_print_static_field inside "try".
7397
7398 2019-05-29  Tom Tromey  <tromey@adacore.com>
7399
7400         * inflow.c (struct terminal_info): Add default operator=.
7401         * configure: Rebuild.
7402         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7403         -Wdeprecated-copy-dtor, -Wredundant-move.
7404
7405 2019-05-29  Tom Tromey  <tromey@adacore.com>
7406
7407         * NEWS: Add entry.
7408         * infcmd.c (print_return_value_1): Handle finish_print
7409         option.
7410         (show_print_finish): New function.
7411         (_initialize_infcmd): Add "set/show print finish" commands.
7412         * valprint.c (user_print_options): Initialize new member.
7413         * valprint.h (struct value_print_options) <finish_print>: New
7414         member.
7415
7416 2019-05-28  Tom Tromey  <tromey@adacore.com>
7417
7418         * ada-lang.c (ada_remove_Xbn_suffix)
7419         (find_old_style_renaming_symbol)
7420         (parse_old_style_renaming): Remove.
7421         (ada_find_renaming_symbol): Don't call
7422         find_old_style_renaming_symbol.
7423         (ada_is_renaming_symbol): Rename from
7424         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7425         bool.  Now static.
7426         (ada_read_var_value): Update and simplify.
7427         * ada-exp.y (write_var_or_type): Remove old code.
7428
7429 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7430
7431         PR gdb/25010
7432         * event-top.c: Remove include comment.
7433         * inflow.c (class scoped_ignore_sigttou): Move from here...
7434         * inflow.h (class scoped_ignore_sigttou): ...to here.
7435         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7436         * top.c:  Remove include comment.
7437
7438 2019-05-27  Tom Tromey  <tom@tromey.com>
7439
7440         * NEWS: Fix typo.
7441
7442 2019-05-22  Tom Tromey  <tromey@adacore.com>
7443
7444         * target.c (target_follow_exec): Constify parameter.
7445         * target-delegates.c: Rebuild.
7446         * remote.c (remote_target::follow_exec): Constify parameter.
7447         * infrun.c (follow_exec): Constify parameter.
7448         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7449         (target_follow_exec): Likewise.
7450
7451 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7452
7453         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7454         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7455
7456 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7457
7458         * NEWS: Add debugredirect and testsuite sections.
7459
7460 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7461
7462         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7463         target descriptions using exclusively floating point register name
7464         aliases.
7465
7466 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         PR gdb/18644:
7469         * f-lang.c (build_fortran_types): Handle the case where
7470         gdbarch_floatformat_for_type returns a nullptr.
7471
7472 2019-05-21  Tom de Vries  <tdevries@suse.de>
7473
7474         PR cli/24587
7475         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7476
7477 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7478
7479         PR gdb/18644:
7480         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7481         16-byte floats.
7482         * i386-tdep.c (i386_floatformat_for_type): Use
7483         floatformats_ia64_quad for the 16-byte floating point component
7484         within a fortran 32-byte complex number.
7485
7486 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7487
7488         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7489         delete default constructor.
7490         (find_partial_die): Update to return const struct.
7491         (partial_die_parent_scope): Move variable declaration into scope
7492         of its use and change its type to auto.
7493         (guess_partial_die_structure_name): Likewise.
7494         (partial_die_info::fixup): Likewise.
7495
7496 2019-05-17  Tom Tromey  <tromey@adacore.com>
7497
7498         * source.c (find_and_open_source): Remove cast.
7499
7500 2019-05-17  Tom Tromey  <tromey@adacore.com>
7501
7502         * annotate.c (annotate_source): Make "filename" const.
7503         * annotate.h (annotate_source): Use const.
7504
7505 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7506
7507         * disasm.c (set_disassembler_options): Send errors to stderr.
7508
7509 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7510
7511         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7512         (cli_interp_base::set_logging): Check debug_redirect.
7513         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7514         * cli/cli-logging.c (debug_redirect): Add static variable.
7515         (pop_output_files): Add default param.
7516         (handle_redirections): Print debug setting.
7517         (show_logging_command): Likewise.
7518         (_initialize_cli_logging): Add debugredirect command.
7519         * interps.c (current_interp_set_logging): Add debug_redirect
7520         parameter.
7521         * interps.h (set_logging): Add debug_redirect parameter.
7522         (current_interp_set_logging): Likewise.
7523         * mi/mi-common.h: Likewise.
7524         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7525
7526 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7527             Tom Tromey  <tromey@adacore.com>
7528
7529         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7530         directly.
7531         * cli/cli-interp.h (make_logging_output): Remove declaration.
7532         * cli/cli-logging.c (make_logging_output): Remove function.
7533         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7534         directly.
7535         * ui-file.c (tee_file::tee_file): Remove bools.
7536         (tee_file::~tee_file): Remove deletes.
7537         * ui-file.h (tee_file): Remove bools.
7538
7539 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7540
7541         * mi/mi-cmds.h (mi_cmd_complete): New function.
7542         * mi/mi-main.c (mi_cmd_complete): Likewise.
7543         * mi/mi-cmds.c: Define new MI command -complete.
7544         * NEWS: Mention new -complete command.
7545
7546 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7547
7548         * completer.h (complete): New function.
7549         * completer.c (complete): Likewise.
7550         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7551         function defined in completer.h.
7552
7553 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7554
7555         * MAINTAINERS (Write After Approval): Add myself.
7556
7557 2019-05-17  Tom de Vries  <tdevries@suse.de>
7558
7559         PR gdb/24094
7560         * dwarf2read.c (struct cu_partial_die_info): New struct.
7561         (find_partial_die): Return cu_partial_die_info.
7562         (partial_die_parent_scope, guess_partial_die_structure_name)
7563         (partial_die_info::fixup): Handle new return type of find_partial_die.
7564
7565 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7566
7567         PR breakpoints/24541
7568         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7569         "std::string", simplifying the algorithm.
7570
7571 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7572
7573         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7574         (stap_static_probe_ops::get_probes): Likewise.
7575
7576 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7577
7578         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7579         '-')" and "else if".
7580         (stap_parse_single_operand): Join checks for
7581         "gdbarch_stap_parse_special_token_p" and
7582         "gdbarch_stap_parse_special_token" in the same "if" statement.
7583         Invert check when verifying for operation on register
7584         displacement.
7585
7586 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7587
7588         * stap-probe.c (stap_get_opcode): Update comment.
7589         (stap_get_expected_argument_type): Likewise.
7590         (handle_stap_probe): Likewise.
7591
7592 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7593
7594         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7595         return type to 'bool'.  Adjust comment.  Use 'bool' when
7596         appropriate.
7597         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7598         * stap-probe.c (stap_parse_argument_1): Likewise.
7599         (stap_is_operator): Likewise.
7600         (stap_is_generic_prefix): Likewise.
7601         (stap_is_register_prefix): Likewise.
7602         (stap_is_register_indirection_prefix): Likewise.
7603         (stap_is_integer_prefix): Likewise.
7604         (stap_generic_check_suffix): Likewise.
7605         (stap_check_integer_suffix): Likewise.
7606         (stap_check_register_suffix): Likewise.
7607         (stap_check_register_indirection_suffix): Likewise.
7608         (stap_parse_register_operand): Likewise.
7609         (stap_parse_single_operand): Likewise.
7610         (stap_parse_argument_1): Likewise.
7611         (stap_probe::get_argument_count): Likewise.
7612         (stap_is_operator): Likewise.
7613
7614 2019-05-16  Tom Tromey  <tromey@adacore.com>
7615
7616         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7617         keyword to foreach.
7618
7619 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7620
7621         * linux-thread-db.c (try_thread_db_load_1): Change return type
7622         to bool.
7623         (try_thread_db_load): Likewise.
7624         (try_thread_db_load_from_pdir_1): Likewise.
7625         (try_thread_db_load_from_pdir): Likewise.
7626         (try_thread_db_load_from_sdir): Likewise.
7627         (try_thread_db_load_from_dir): Likewise.
7628         (thread_db_load_search): Likewise.
7629         (has_libpthread): Likewise.
7630         (thread_db_load): Likewise.
7631
7632 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7633
7634         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7635         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7636         NULL, and complain/return if that's the case.
7637
7638 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7639
7640         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7641         (advance, posn, abstract_read_memory): New functions.
7642         [struct mem_read_abstraction]: New struct.
7643         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7644
7645 2019-05-14  Tom Tromey  <tromey@adacore.com>
7646
7647         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7648         value is not lval_memory.
7649
7650 2019-05-14  Tom Tromey  <tromey@adacore.com>
7651
7652         * solib.c (info_sharedlibrary_command): Style the file name.
7653
7654 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7657         (aarch64_vnv_type): Likewise.
7658         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7659         * common/tdesc.c: Likewise.
7660         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7661         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7662         * features/aarch64-fpu.xml: Add ieee half view.
7663         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7664         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7665         * gdbtypes.h (struct builtin_type): Likewise.
7666         (struct objfile_type): Likewise.
7667
7668 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7669
7670         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7671         typo.
7672         * location.h (string_to_event_location): Likewise.
7673
7674 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7675
7676         GDB 8.3 released.
7677
7678 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7679
7680         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7681         New variable declaration.
7682         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7683         New variable.
7684         (print_one_breakpoint): Use ui_out::test_flags and new global
7685         variable to compute use_fixed_output.
7686         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7687         Remove.
7688         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7689         (mi_multi_location_breakpoint_output_fixed): Remove.
7690         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7691         new variable.
7692         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7693         fix_multi_location_breakpoint_output flag if version >= 3.
7694         * ui-out.h (enum ui_out_flag)
7695         <fix_multi_location_breakpoint_output>: New enumerator.
7696
7697 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7698
7699         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7700
7701 2019-05-10  Tom Tromey  <tromey@adacore.com>
7702
7703         * ada-lang.c (catch_ada_completer): New function.
7704         (_initialize_ada_language): Use it.
7705
7706 2019-05-10  Tom Tromey  <tromey@adacore.com>
7707
7708         * thread.c (print_thread_info): Make "requested_threads" const.
7709         * gdbthread.h (print_thread_info): Make "requested_threads"
7710         const.
7711         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7712         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7713
7714 2019-05-08  Tom Tromey  <tom@tromey.com>
7715
7716         * gdbtypes.c (objfile_type_data): Change type.
7717         (objfile_type, _initialize_gdbtypes): Update.
7718
7719 2019-05-08  Tom Tromey  <tom@tromey.com>
7720
7721         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7722         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7723         (_initialize_dwarf2_frame): Update.
7724
7725 2019-05-08  Tom Tromey  <tom@tromey.com>
7726
7727         * objc-lang.c (objc_objfile_data): Change type.
7728         (find_methods): Update.
7729         (_initialize_objc_lang): Remove.
7730
7731 2019-05-08  Tom Tromey  <tom@tromey.com>
7732
7733         * stabsread.c (rs6000_builtin_type_data): Change type.
7734         (rs6000_builtin_type, _initialize_stabsread): Update.
7735
7736 2019-05-08  Tom Tromey  <tom@tromey.com>
7737
7738         * mips-tdep.c (mips_pdr_data): Remove.
7739         (_initialize_mips_tdep): Update.
7740
7741 2019-05-08  Tom Tromey  <tom@tromey.com>
7742
7743         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7744         (hppa_init_objfile_priv_data, read_unwind_info)
7745         (find_unwind_entry, _initialize_hppa_tdep): Update.
7746
7747 2019-05-08  Tom Tromey  <tom@tromey.com>
7748
7749         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7750         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7751         on obstack.
7752         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7753
7754 2019-05-08  Tom Tromey  <tom@tromey.com>
7755
7756         * mdebugread.c (basic_type_data): Change type.
7757         (basic_type, _initialize_mdebugread): Update.
7758
7759 2019-05-08  Tom Tromey  <tom@tromey.com>
7760
7761         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7762
7763 2019-05-08  Tom Tromey  <tom@tromey.com>
7764
7765         * nto-tdep.c (nto_inferior_data_reg): Change type.
7766         (nto_inferior_data): Update.
7767         (nto_inferior_data_cleanup, nto_new_inferior_data)
7768         (_initialize_nto_tdep): Remove.
7769         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7770
7771 2019-05-08  Tom Tromey  <tom@tromey.com>
7772
7773         * ada-lang.c (struct ada_inferior_data): Add initializers.
7774         (ada_inferior_data): Change type.
7775         (ada_inferior_data_cleanup): Remove.
7776         (get_ada_inferior_data, ada_inferior_exit)
7777         (struct ada_pspace_data): Add initializers, destructor.
7778         (ada_pspace_data_handle): Change type.
7779         (get_ada_pspace_data): Update.
7780         (ada_pspace_data_cleanup): Remove.
7781
7782 2019-05-08  Tom Tromey  <tom@tromey.com>
7783
7784         * coffread.c (struct coff_symfile_info): Add initializers.
7785         (coff_objfile_data_key): Move lower.  Change type.
7786         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7787         Update.
7788         (coff_free_info): Remove.
7789
7790 2019-05-08  Tom Tromey  <tom@tromey.com>
7791
7792         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7793         (fbsd_pspace_data_handle): Move lower.  Change type.
7794         (get_fbsd_pspace_data): Update.
7795         (fbsd_pspace_data_cleanup): Remove.
7796         (_initialize_fbsd_tdep): Update.
7797
7798 2019-05-08  Tom Tromey  <tom@tromey.com>
7799
7800         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7801         (get_ada_tasks_pspace_data): Update.
7802         (ada_tasks_pspace_data_cleanup): Remove.
7803         (_initialize_tasks): Update.
7804         (ada_tasks_inferior_data_handle): Change type.
7805         (get_ada_tasks_inferior_data): Update.
7806         (ada_tasks_inferior_data_cleanup): Remove.
7807         (struct ada_tasks_pspace_data): Add initializers.
7808
7809 2019-05-08  Tom Tromey  <tom@tromey.com>
7810
7811         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7812         * symfile-debug.c (debug_sym_get_probes): Change type.
7813         * stap-probe.c (handle_stap_probe):
7814         (stap_static_probe_ops::get_probes): Change type.
7815         * probe.h (class static_probe_ops) <get_probes>: Change type.
7816         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7817         (parse_probes_in_pspace): Update.
7818         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7819         Update.
7820         (any_static_probe_ops::get_probes): Change type.
7821         * elfread.c (elfread_data): New typedef.
7822         (probe_key): Change type.
7823         (elf_get_probes): Likewise.  Update.
7824         (probe_key_free): Remove.
7825         (_initialize_elfread): Update.
7826         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7827         Change type.
7828         (dtrace_process_dof_probe, dtrace_process_dof)
7829         (dtrace_static_probe_ops::get_probe): Change type.
7830
7831 2019-05-08  Tom Tromey  <tom@tromey.com>
7832
7833         * xcoffread.c (struct xcoff_symfile_info): Rename from
7834         coff_symfile_info.  Add initializers.
7835         (xcoff_objfile_data_key): Move lower.  Change type.
7836         (XCOFF_DATA): Rewrite.
7837         (xcoff_free_info): Remove.
7838         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7839         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7840         (xcoff_initial_scan): Update.
7841
7842 2019-05-08  Tom Tromey  <tom@tromey.com>
7843
7844         * solib-svr4.c (struct svr4_info): Add initializers and
7845         destructor.
7846         <probes_table>: Now an htab_up.
7847         (solib_svr4_pspace_data): Change type.
7848         (free_probes_table): Simplify.
7849         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7850         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7851         (probes_table_remove_objfile_probes, register_solib_event_probe)
7852         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7853         (_initialize_svr4_solib): Update.
7854
7855 2019-05-08  Tom Tromey  <tom@tromey.com>
7856
7857         * remote.c (remote_pspace_data): Change type.
7858         (remote_pspace_data_cleanup): Remove.
7859         (get_remote_exec_file, set_pspace_remote_exec_file)
7860         (_initialize_remote): Update.
7861
7862 2019-05-08  Tom Tromey  <tom@tromey.com>
7863
7864         * breakpoint.c (breakpoint_objfile_key): Change type.
7865         (get_breakpoint_objfile_data): Update.
7866         (free_breakpoint_objfile_data): Remove.
7867         (_initialize_breakpoint): Update.
7868
7869 2019-05-08  Tom Tromey  <tom@tromey.com>
7870
7871         * linux-tdep.c (struct linux_info): Add initializers.
7872         (linux_inferior_data): Move.  Change type.
7873         (invalidate_linux_cache_inf): Update.
7874         (linux_inferior_data_cleanup): Remove.
7875         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7876
7877 2019-05-08  Tom Tromey  <tom@tromey.com>
7878
7879         * auxv.c (auxv_inferior_data): Move.  Change type.
7880         (auxv_inferior_data_cleanup): Remove.
7881         (invalidate_auxv_cache_inf): Rewrite.
7882         (get_auxv_inferior_data, _initialize_auxv): Update.
7883
7884 2019-05-08  Tom Tromey  <tom@tromey.com>
7885
7886         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7887         (symfile_debug_objfile_data_key): Change type.
7888         (symfile_debug_installed, debug_qf_has_symbols)
7889         (debug_qf_find_last_source_symtab)
7890         (debug_qf_forget_cached_source_info)
7891         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7892         (debug_qf_print_stats, debug_qf_dump)
7893         (debug_qf_expand_symtabs_for_function)
7894         (debug_qf_expand_all_symtabs)
7895         (debug_qf_expand_symtabs_with_fullname)
7896         (debug_qf_map_matching_symbols)
7897         (debug_qf_expand_symtabs_matching)
7898         (debug_qf_find_pc_sect_compunit_symtab)
7899         (debug_qf_map_symbol_filenames)
7900         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7901         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7902         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7903         (debug_sym_read_linetable, debug_sym_relocate): Update.
7904         (symfile_debug_free_objfile): Remove.
7905         (install_symfile_debug_logging, _initialize_symfile_debug):
7906         Update.
7907
7908 2019-05-08  Tom Tromey  <tom@tromey.com>
7909
7910         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7911         allocate_on_obstack.
7912         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7913         (get_dwarf2_per_objfile): Update.
7914         (set_dwarf2_per_objfile): Remove.
7915         (dwarf2_has_info, dwarf2_get_section_info): Update.
7916         (dwarf2_free_objfile): Remove.
7917         (_initialize_dwarf2_read): Update.
7918
7919 2019-05-08  Tom Tromey  <tom@tromey.com>
7920
7921         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7922         initializers.
7923         <unsupported_script_warning_printed,
7924         script_not_found_warning_printed>: Now bool.
7925         (auto_load_pspace_data): Change type.
7926         (~auto_load_pspace_info): Rename from
7927         auto_load_pspace_data_cleanup.
7928         (get_auto_load_pspace_data, init_loaded_scripts_info)
7929         (clear_section_scripts, maybe_print_unsupported_script_warning)
7930         (maybe_print_script_not_found_warning, _initialize_auto_load):
7931         Update.
7932
7933 2019-05-08  Tom Tromey  <tom@tromey.com>
7934
7935         * objfiles.c (objfile_pspace_info): Add destructor and
7936         initializers.
7937         (objfiles_pspace_data): Change type.
7938         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7939         (get_objfile_pspace_data): Update.
7940         (objfiles_bfd_data): Change type.
7941         (get_objfile_bfd_data): Update.
7942         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7943
7944 2019-05-08  Tom Tromey  <tom@tromey.com>
7945
7946         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7947         Change type.
7948         (get_catch_syscall_inferior_data): Update.
7949         (catch_syscall_inferior_data_cleanup): Remove.
7950         (_initialize_break_catch_syscall): Update.
7951
7952 2019-05-08  Tom Tromey  <tom@tromey.com>
7953
7954         * inflow.c (struct terminal_info): Add destructor and
7955         initializers.
7956         (inflow_inferior_data): Change type.
7957         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7958         (get_inflow_inferior_data, inflow_inferior_exit)
7959         (swap_terminal_info, _initialize_inflow): Update.
7960
7961 2019-05-08  Tom Tromey  <tom@tromey.com>
7962
7963         * target-dcache.c (target_dcache_cleanup): Remove.
7964         (target_dcache_aspace_key): Change type.
7965         (target_dcache_init_p, target_dcache_invalidate)
7966         (target_dcache_get, target_dcache_get_or_init)
7967         (_initialize_target_dcache): Update.
7968         * dcache.h (struct dcache_deleter): New.
7969
7970 2019-05-08  Tom Tromey  <tom@tromey.com>
7971
7972         * symtab.c (struct symbol_cache): Add destructor and
7973         initializers.
7974         (symbol_cache_key): Move.  Change type.
7975         (make_symbol_cache, free_symbol_cache): Remove.
7976         (get_symbol_cache): Update.
7977         (symbol_cache_cleanup): Remove.
7978         (ALL_PSPACES, symbol_cache_flush)
7979         (maintenance_print_symbol_cache)
7980         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7981         Update.
7982
7983 2019-05-08  Tom Tromey  <tom@tromey.com>
7984
7985         * symtab.c (struct main_info): Add destructor and initializers.
7986         (main_progspace_key): Move.  Change type.
7987         (get_main_info): Update.
7988         (main_info_cleanup): Remove.
7989         (_initialize_symtab): Update.
7990
7991 2019-05-08  Tom Tromey  <tom@tromey.com>
7992
7993         * registry.h (DECLARE_REGISTRY): Define the _key class.
7994
7995 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7996
7997         * NEWS: Merge two 'New commands' sections.
7998
7999 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8000
8001         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8002         parameter and use Ada language definition instead.
8003         (ada_val_print_ptr): Remove unused language parameter.
8004         (ada_val_print_num): Remove language parameter and use Ada language
8005         definition instead.
8006         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8007         parameter.
8008         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8009         parameter and use Ada language definition instead.
8010         (ada_val_print_1): Update all ada_val_print_xxx calls.
8011         Remove language parameter.
8012         (ada_val_print): Update ada_val_print_1 call.
8013
8014 2019-05-08  Tom Tromey  <tromey@adacore.com>
8015
8016         * remote.c (remote_hw_watchpoint_limit)
8017         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8018         Now static.
8019
8020 2019-05-08  Tom Tromey  <tromey@adacore.com>
8021
8022         * maint.c (_initialize_maint_cmds): Move initialization code to
8023         remote.c.
8024         (watchdog, show_watchdog): Move to remote.c.
8025         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8026         "watchdog" static.
8027         (_initialize_remote): Move initialization code from maint.c.
8028         * defs.h (watchdog): Don't declare.
8029
8030 2019-05-08  Tom Tromey  <tromey@adacore.com>
8031
8032         * tui/tui-interp.c: Include main.h.
8033         * interps.c: Include main.h.
8034         * main.h (interpreter_p): Declare.
8035         * defs.h (interpreter_p): Don't declare.
8036
8037 2019-05-08  Tom Tromey  <tromey@adacore.com>
8038
8039         * dwarf2loc.c: Include dwarf2read.h.
8040         * defs.h (read_unsigned_leb128): Don't declare.
8041         * dwarf2read.h (read_unsigned_leb128): Declare.
8042
8043 2019-05-08  Tom Tromey  <tromey@adacore.com>
8044
8045         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8046         method.
8047
8048 2019-05-08  Tom Tromey  <tromey@adacore.com>
8049
8050         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8051         when no wrap column is set.
8052
8053 2019-05-08  Tom Tromey  <tromey@adacore.com>
8054
8055         * c-lang.c (c_get_string): Handle non-C-style arrays.
8056
8057 2019-05-08  Tom Tromey  <tromey@adacore.com>
8058
8059         * typeprint.c (print_offset_data::update): Print the bit offset,
8060         not the number of bits remaining.
8061
8062 2019-05-08  Tom Tromey  <tromey@adacore.com>
8063
8064         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8065         padding at end of comment.
8066
8067 2019-05-08  Tom Tromey  <tromey@adacore.com>
8068
8069         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8070         Compare main types.
8071
8072 2019-05-06  Tom Tromey  <tom@tromey.com>
8073
8074         * common/scoped_mmap.c: Include common-defs.h.
8075         * common/scoped_mmap.h: Don't include config.h.
8076
8077 2019-05-04  Tom Tromey  <tom@tromey.com>
8078
8079         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8080         (struct aarch64_call_info): Add initializers.
8081         <si>: Now a std::vector.
8082         (pass_on_stack, aarch64_push_dummy_call): Update.
8083
8084 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8085             Tom Tromey  <tom@tromey.com>
8086
8087         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8088         (ppc_threads): Now a std::vector.  Now static.
8089         (hwdebug_find_thread_points_by_tid)
8090         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8091         Update.
8092
8093 2019-05-04  Tom Tromey  <tom@tromey.com>
8094
8095         * arc-tdep.c (arc_tdesc_init): Return bool.
8096
8097 2019-05-04  Tom Tromey  <tom@tromey.com>
8098
8099         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8100         Use gdb_assert_not_reached.
8101
8102 2019-05-04  Tom Tromey  <tom@tromey.com>
8103
8104         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8105         "false".
8106
8107 2019-05-04  Tom Tromey  <tom@tromey.com>
8108
8109         * arc-tdep.c (arc_tdesc_init): Use bool.
8110
8111 2019-05-04  Tom Tromey  <tom@tromey.com>
8112
8113         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8114
8115 2019-05-04  Tom Tromey  <tom@tromey.com>
8116
8117         * cli/cli-cmds.c (valid_command_p): Return bool.
8118
8119 2019-05-04  Tom Tromey  <tom@tromey.com>
8120
8121         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8122         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8123
8124 2019-05-04  Raul Tambre  <raul@tambre.ee>
8125
8126         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8127         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8128         operator for comparison.
8129
8130 2019-05-04  Tom Tromey  <tom@tromey.com>
8131
8132         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8133         (lookup_partial_symbol, print_partial_symbols)
8134         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8135         (psymbol_compare): Update.
8136         (add_psymbol_to_bcache): Clear the entire psymbol.
8137         (maintenance_check_psymtabs): Update.
8138         * psympriv.h (struct partial_symbol): Don't derive from
8139         general_symbol_info.
8140         <obj_section, unrelocated_address, address,
8141         set_unrelocated_address>: Update.
8142         <ginfo>: New member.
8143         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8144         (debug_names::write_psymbols): Update.
8145
8146 2019-05-04  Tom de Vries  <tdevries@suse.de>
8147
8148         * contrib/cc-with-tweaks.sh: Support -n arg.
8149
8150 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8151
8152         * corelow.c (core_target::detach): Ensure frame cache and
8153         register caches are cleared.
8154         inferior.c (exit_inferior_1): Likewise.
8155
8156 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8157             Tom Tromey  <tom@tromey.com>
8158
8159         * dictionary.c (collate_pending_symbols_by_language): Remove
8160         "struct" from foreach.
8161         * symtab.c (lookup_global_symbol_from_objfile)
8162         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8163         foreach.
8164         * ser-tcp.c (net_open): Remove "struct" from foreach.
8165         * objfiles.c (objfile_relocate, objfile_rebase)
8166         (objfile_has_symbols): Remove "struct" from foreach.
8167         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8168         from foreach.
8169         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8170         foreach.
8171         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8172         "struct" from foreach.
8173         * ada-lang.c (create_excep_cond_exprs)
8174         (ada_exception_catchpoint_cond_string): Remove "struct" from
8175         foreach.
8176
8177 2019-05-03  Tom Tromey  <tromey@adacore.com>
8178
8179         * ada-exp.y (convert_char_literal): Check suffix of each
8180         enumerator.
8181
8182 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8183
8184         PR ada/21406:
8185         * ada-exp.y (yywrap): Don't define.
8186         * ada-lex.l (%option): Add noyywrap
8187         (yywrap): Remove.
8188
8189 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8190
8191         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8192         _WIN32_WINNT to the XP level, unless already defined to a higher
8193         level.
8194
8195         * unittests/parse-connection-spec-selftests.c:
8196         * ser-tcp.c:
8197         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8198         override.
8199
8200         * symfile.c (find_separate_debug_file): Remove colon from the
8201         drive spec of DOS/Windows file names of the target, so that the
8202         file name produced from DEBUGDIR and the target's directory will
8203         be valid on DOS/Windows systems.
8204
8205 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8206
8207         * rust-lang.c (val_print_struct): Handle printing structures
8208         containing strings.
8209
8210 2019-05-02  Tom Tromey  <tromey@adacore.com>
8211
8212         * valarith.c (_initialize_valarith): Remove.
8213
8214 2019-05-01  Tom Tromey  <tromey@adacore.com>
8215
8216         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8217         bitfields.
8218
8219 2019-05-01  Tom Tromey  <tromey@adacore.com>
8220
8221         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8222         for big-endian copies.
8223
8224 2019-04-30  Ali Tamur  <tamur@google.com>
8225         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8226         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8227         (read_3_bytes): New function.
8228
8229 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8230
8231         * windows-nat.c (main_thread_id): Delete.
8232         (handle_output_debug_string): Replace main_thread_id by
8233         current_event.dwThreadId.
8234         (fake_create_process): Likewise.
8235         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8236         Do not set main_thread_id.
8237         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8238         current_event.dwThreadId.
8239         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8240
8241 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8242
8243         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8244         Use current_event.dwThreadId instead of main_thread_id.
8245
8246 2019-04-30  Tom Tromey  <tromey@adacore.com>
8247
8248         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8249         (create_excep_cond_exprs): Iterate over program spaces.
8250         (ada_exception_catchpoint_cond_string): Examine all minimal
8251         symbols for exception types.
8252
8253 2019-04-30  Tom Tromey  <tromey@adacore.com>
8254
8255         PR c++/24470:
8256         * dwarf2read.c (process_structure_scope): Handle case where type
8257         has template parameters but no symbol was created.
8258
8259 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8260             Chris January  <chris.january@arm.com>
8261
8262         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8263         qualifier.
8264         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8265
8266 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8267
8268         * f-typeprint.c (f_print_type): Update rules for printing
8269         whitespace.
8270         (f_type_print_varspec_suffix): Likewise.
8271
8272 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8273             Chris January  <chris.january@arm.com>
8274
8275         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8276         function arguments.
8277
8278 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8279
8280         * f-lang.c (build_fortran_types): Change name of void type to
8281         lower case.
8282         * f-typeprint.c (f_type_print_base): Print the name of the void
8283         type, rather than a fixed string.
8284         * f-valprint.c (f_decorations): Use lower case void string.
8285
8286 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8287             Chris January  <chris.january@arm.com>
8288
8289         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8290         types for Fortran.
8291
8292 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8293             Chris January  <chris.january@arm.com>
8294             David Lecomber  <david.lecomber@arm.com>
8295
8296         * f-exp.y (BINOP_INTRINSIC): New token.
8297         (exp): New parser rule handling BINOP_INTRINSIC.
8298         (f77_keywords): Add new builtin procedures.
8299         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8300         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8301         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8302         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8303         (print_unop_subexp_f): New function.
8304         (print_binop_subexp_f): New function.
8305         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8306         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8307         (dump_subexp_body_f): Likewise.
8308         (operator_check_f): Likewise.
8309         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8310         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8311
8312 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8315         UNOP_KIND.
8316         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8317         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8318         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8319         (operator_length_f): New fuction.
8320         (print_subexp_f): New function.
8321         (op_name_f): New function.
8322         (dump_subexp_body_f): New function.
8323         (operator_check_f): New function.
8324         (exp_descriptor_f): Replace standard expression handling functions
8325         with new functions.
8326         * gdb/fortran-operator.def: New file.
8327         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8328         * gdb/std-operator.def: Remove UNOP_KIND.
8329
8330 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8331
8332         * std-operator.def: Remove unbalanced, stray double quote
8333         character.
8334
8335 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8336             Chris January  <chris.january@arm.com>
8337             Daniel Everett  <daniel.everett@arm.com>
8338             Nick Forrington  <nick.forrington@arm.com>
8339             Richard Bunt  <richard.bunt@arm.com>
8340
8341         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8342         of depth when printing anonymous structs or unions.
8343         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8344         Don't print either the top-level value, or the children if the
8345         max-depth is exceeded.
8346         (ppscm_print_children): When printing the key of a map, allow one
8347         extra level of depth.
8348         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8349         print either the top-level value, or the children if the max-depth
8350         is exceeded.
8351         (print_children): When printing the key of a map, allow one extra
8352         level of depth.
8353         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8354         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8355         (user_print_options): Initialise max_depth field.
8356         (val_print_scalar_or_string_type_p): New function.
8357         (val_print): Check to see if the max depth has been reached.
8358         (val_print_check_max_depth): Define new function.
8359         (show_print_max_depth): New function.
8360         (_initialize_valprint): Add 'print max-depth' option.
8361         * valprint.h (struct value_print_options) <max_depth>: New field.
8362         (val_print_check_max_depth): Declare new function.
8363         * NEWS: Document new feature.
8364
8365 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8366
8367         * ada-lang.c (ada_language_defn): Initialise new field.
8368         * c-lang.c (c_is_string_type_p): New function.
8369         (c_language_defn): Initialise new field.
8370         (cplus_language_defn): Initialise new field.
8371         (asm_language_defn): Initialise new field.
8372         (minimal_language_defn): Initialise new field.
8373         * c-lang.h (c_is_string_type_p): Declare new function.
8374         * d-lang.c (d_language_defn): Initialise new field.
8375         * f-lang.c (f_is_string_type_p): New function.
8376         (f_language_defn): Initialise new field.
8377         * go-lang.c (go_is_string_type_p): New function.
8378         (go_language_defn): Initialise new field.
8379         * language.c (default_is_string_type_p): New function.
8380         (unknown_language_defn): Initialise new field.
8381         (auto_language_defn): Initialise new field.
8382         * language.h (struct language_defn) <la_is_string_type_p>: New
8383         member variable.
8384         (default_is_string_type_p): Declare new function.
8385         * m2-lang.c (m2_language_defn): Initialise new field.
8386         * objc-lang.c (objc_language_defn): Initialise new field.
8387         * opencl-lang.c (opencl_language_defn): Initialise new field.
8388         * p-lang.c (pascal_is_string_type_p): New function.
8389         (pascal_language_defn): Initialise new field.
8390         * rust-lang.c (rust_is_string_type_p): New function.
8391         (rust_language_defn): Initialise new field.
8392
8393 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8394
8395         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8396         New field.
8397         * ada-lang.c (ada_language_defn): Initialise new field.
8398         * c-lang.c (c_language_defn): Likewise.
8399         (cplus_language_defn): Likewise.
8400         (asm_language_defn): Likewise.
8401         (minimal_language_defn): Likewise.
8402         * d-lang.c (d_language_defn): Likewise.
8403         * f-lang.c (f_language_defn): Likewise.
8404         * go-lang.c (go_language_defn): Likewise.
8405         * language.c (unknown_language_defn): Likewise.
8406         (auto_language_defn): Likewise.
8407         * m2-lang.c (m2_language_defn): Likewise.
8408         * objc-lang.c (objc_language_defn): Likewise.
8409         * opencl-lang.c (opencl_language_defn): Likewise.
8410         * p-lang.c (pascal_language_defn): Likewise.
8411         * rust-lang.c (rust_language_defn): Likewise.
8412
8413 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8414
8415         * ada-lang.c (ada_is_character_type): Change return type to bool.
8416         (ada_is_string_type): Likewise.
8417         * ada-lang.h (ada_is_character_type): Update declaration
8418         (ada_is_string_type): Likewise.
8419
8420 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8421
8422         Support style in 'frame|thread apply'
8423
8424         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8425         * record.c (record_start, record_stop): Update callers of
8426         execute_command_to_string with false.
8427         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8428         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8429         methods.
8430         (class string_file): New constructor with term_out parameter.
8431         Override methods term_out and can_emit_style_escape.  New member
8432         term_out.
8433         (class stdio_file): Override can_emit_style_escape.
8434         (class tee_file): Override term_out and can_emit_style_escape.
8435         * utils.h (can_emit_style_escape): Remove.
8436         * utils.c (can_emit_style_escape): Likewise.
8437         Update all callers of can_emit_style_escape (SOMESTREAM) to
8438         SOMESTREAM->can_emit_style_escape.
8439         * source-cache.c (source_cache::get_source_lines): Likewise.
8440         * stack.c (frame_apply_command_count): Call execute_command_to_string
8441         passing the term_out characteristic of the current gdb_stdout.
8442         * thread.c (thr_try_catch_cmd): Likewise.
8443         * top.c (execute_command_to_string): pass term_out parameter
8444         to construct the string_file for the command output.
8445         * ui-file.c (term_cli_styling): New function (most code moved
8446         from utils.c can_emit_style_escape).
8447         (string_file::string_file, string_file::can_emit_style_escape,
8448         stdio_file::can_emit_style_escape, tee_file::term_out,
8449         tee_file::can_emit_style_escape): New functions.
8450
8451 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8452
8453         * NEWS: Mention the new set|show may-call-functions.
8454         * infcall.c (may_call_functions_p): New variable.
8455         (show_may_call_functions_p): New function.
8456         (call_function_by_hand_dummy): Throws an error if not
8457         may-call-functions.
8458         (_initialize_infcall): Call add_setshow_boolean_cmd for
8459         may-call-functions.
8460
8461 2019-04-25  Keith Seitz  <keiths@redhat.com>
8462
8463         PR c++/24367
8464         * cp-support.c (inspect_type): Don't attempt substitutions
8465         of symbol with the same name.
8466
8467 2019-04-25  Tom Tromey  <tromey@adacore.com>
8468
8469         PR gdb/24475:
8470         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8471         static.
8472
8473 2019-04-25  Tom Tromey  <tromey@adacore.com>
8474
8475         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8476         rvalue reference.
8477         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8478         (gdb_xml_parser::parse): Use std::move.
8479         * python/python-internal.h (gdbpy_convert_exception): Take a const
8480         reference.
8481         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8482         std::move.
8483         * python/py-utils.c (gdbpy_convert_exception): Take a const
8484         reference.
8485         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8486         Use std::move.
8487         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8488         Use std::move.
8489         * mi/mi-main.c (mi_print_exception): Take a const reference.
8490         * main.c (handle_command_errors): Take a const reference.
8491         * linespec.c (parse_linespec): Use std::move.
8492         * infcall.c (run_inferior_call): Use std::move.
8493         (call_function_by_hand_dummy): Use std::move.
8494         * exec.c (try_open_exec_file): Use std::move.
8495         * exceptions.h (exception_print, exception_fprintf)
8496         (exception_print_same): Update.
8497         * exceptions.c (print_exception, exception_print)
8498         (exception_fprintf, exception_print_same): Change parameters to
8499         const reference.
8500         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8501         * common/new-op.c: Use std::move.
8502         * common/common-exceptions.h (struct gdb_exception): Add move
8503         constructor.
8504         (struct gdb_exception_error, struct gdb_exception_quit, struct
8505         gdb_quit_bad_alloc): Change constructor to move constructor.
8506         (throw_exception): Change parameter to rvalue reference.
8507         * common/common-exceptions.c (throw_exception): Take rvalue
8508         reference.
8509         * cli/cli-interp.c (safe_execute_command): Use std::move.
8510         * breakpoint.c (insert_bp_location, location_to_sals): Use
8511         std::move.
8512
8513 2019-04-25  Tom Tromey  <tromey@adacore.com>
8514
8515         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8516         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8517         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8518         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8519         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8520         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8521         guile/scm-value.c: Use unpack.
8522         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8523         gdbscm_gdb_exception.
8524         (gdbscm_throw_gdb_exception): Likewise.
8525         (struct gdbscm_gdb_exception): New.
8526         (unpack): New function.
8527         (gdbscm_wrap): Use unpack.
8528
8529 2019-04-25  Tom Tromey  <tromey@adacore.com>
8530
8531         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8532         (gdb_rl_callback_handler): Use std::move.
8533         * common/common-exceptions.h (struct gdb_exception): Add move
8534         assignment operator.
8535         (throw_exception_sjlj): Change "exception" to const reference.
8536         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8537         (throw_exception_sjlj): Change "exception" to const reference.
8538
8539 2019-04-25  Tom Tromey  <tromey@adacore.com>
8540
8541         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8542         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8543         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8544         Update.
8545         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8546         Update.
8547         * mi/mi-interp.c (mi_interp::exec): Update.
8548         * linespec.c (parse_linespec): Update.
8549         * infcall.c (run_inferior_call): Update.
8550         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8551         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8552         (gdbscm_lookup_global_symbol): Update.
8553         * guile/scm-param.c (gdbscm_parameter_value): Update.
8554         * guile/scm-frame.c (gdbscm_frame_read_register)
8555         (gdbscm_frame_read_var): Update.
8556         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8557         * exec.c (try_open_exec_file): Update.
8558         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8559         (gdb_rl_callback_handler): Update.
8560         * common/common-exceptions.h (exception_none): Don't declare.
8561         * common/common-exceptions.c (exception_none): Don't define.
8562         (struct catcher) <exception>: Update.
8563         * cli/cli-interp.c (safe_execute_command): Update.
8564         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8565
8566 2019-04-25  Ali Tamur  <tamur@google.com>
8567
8568         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8569         (read_attribute_value): Likewise.
8570         (dwarf2_read_addr_index): Update comment.
8571         (read_str_index): Add DW_FORM_strx.
8572         (dwarf2_string_attr): Likewise.
8573         (dwarf2_const_value_attr): Likewise.
8574         (dump_die_shallow): Likewise.
8575         (dwarf2_fetch_constant_bytes): Likewise.
8576         (skip_form_bytes): Likewise.
8577         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8578
8579 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8580
8581         PR corefiles/11608
8582         PR corefiles/18187
8583         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8584         OFFSET.  Verify if current mapping contains an ELF header.
8585         (linux_find_memory_regions_full): Adjust call to
8586         dump_mapping_p.
8587
8588 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8589             Kang Li <kanglictf@gmail.com>
8590
8591         PR gdb/21600
8592
8593         * dwarf2-frame.c (read_initial_length): Be consistent about using
8594         unsigned representation of length.
8595         (decode_frame_entry_1): Likewise.  Check for wraparound of
8596         end pointer as well as buffer overflow.
8597
8598 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8599
8600         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8601         "vq".
8602
8603 2019-04-24  Tom Tromey  <tromey@adacore.com>
8604
8605         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8606
8607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8608
8609         * s12z-tdep.c (s12z_unwind_pc): Delete.
8610         (s12z_unwind_sp): Delete.
8611         (s12z_gdbarch_init): Don't register deleted functions with
8612         gdbarch.
8613
8614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8615
8616         * rl78-tdep.c (rl78_unwind_sp): Delete.
8617         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8618
8619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8620
8621         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8622         (xstormy16_unwind_pc): Delete.
8623         (xstormy16_dummy_id): Delete.
8624         (xstormy16_gdbarch_init): Don't register deleted functions with
8625         gdbarch.
8626
8627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8628
8629         * vax-tdep.c (vax_unwind_pc): Delete.
8630         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8631
8632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8633
8634         * v850-tdep.c (v850_unwind_sp): Delete.
8635         (v850_unwind_pc): Delete.
8636         (v850_dummy_id): Delete.
8637         (v850_gdbarch_init): Don't register deleted functions with
8638         gdbarch.
8639
8640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8641
8642         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8643         (tilegx_unwind_pc): Delete.
8644         (tilegx_unwind_dummy_id): Delete.
8645         (tilegx_gdbarch_init): Don't register deleted functions with
8646         gdbarch.
8647
8648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8649
8650         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8651         (tic6x_dummy_id): Delete.
8652         (tic6x_gdbarch_init): Don't register deleted functions with
8653         gdbarch.
8654
8655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8656
8657         * sparc-tdep.c (sparc_unwind_pc): Delete.
8658         (sparc32_gdbarch_init): Don't register deleted function with
8659         gdbarch.
8660
8661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8662
8663         * sh-tdep.c (sh_unwind_sp): Delete.
8664         (sh_unwind_pc): Delete.
8665         (sh_dummy_id): Delete.
8666         (sh_gdbarch_init): Don't register deleted functions with
8667         gdbarch.
8668
8669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8670
8671         * score-tdep.c (score_unwind_sp): Delete.
8672         (score_unwind_pc): Delete.
8673         (score_dummy_id): Delete.
8674         (score_gdbarch_init): Don't register deleted functions with
8675         gdbarch.
8676
8677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8678
8679         * rx-tdep.c (rx_unwind_pc): Delete.
8680         (rx_unwind_sp): Delete.
8681         (rx_dummy_id): Delete.
8682         (rx_gdbarch_init): Don't register deleted functions with
8683         gdbarch.  Update comment.
8684
8685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8686
8687         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8688         (rs6000_dummy_id): Delete.
8689         (rs6000_gdbarch_init): Don't register deleted functions with
8690         gdbarch.
8691
8692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         * or1k-tdep.c (or1k_dummy_id): Delete.
8695         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8696
8697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8698
8699         * nios2-tdep.c (nios2_dummy_id): Delete.
8700         (nios2_unwind_sp): Delete.
8701         (nios2_gdbarch_init): Don't register deleted functions with
8702         gdbarch.
8703
8704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * nds32-tdep.c (nds32_dummy_id): Delete.
8707         (nds32_unwind_pc): Delete.
8708         (nds32_unwind_sp): Delete.
8709         (nds32_gdbarch_init): Don't register deleted functions with
8710         gdbarch.
8711
8712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8713
8714         * msp430-tdep.c (msp430_unwind_pc): Delete.
8715         (msp430_unwind_sp): Delete.
8716         (msp430_dummy_id): Delete.
8717         (msp430_gdbarch_init): Don't register deleted functions with
8718         gdbarch.
8719
8720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8721
8722         * moxie-tdep.c (moxie_unwind_sp): Delete.
8723         (moxie_unwind_pc): Delete.
8724         (moxie_dummy_id): Delete.
8725         (moxie_gdbarch_init): Don't register deleted functions with
8726         gdbarch.
8727
8728 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8731         (mn10300_unwind_pc): Delete.
8732         (mn10300_unwind_sp): Delete.
8733         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8734         mn10300_unwind_sp.
8735         (mn10300_frame_unwind_init): Don't register deleted functions with
8736         gdbarch.
8737
8738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8739
8740         * mep-tdep.c (mep_unwind_pc): Delete.
8741         (mep_unwind_sp): Delete.
8742         (mep_dummy_id): Delete.
8743         (mep_gdbarch_init): Don't register deleted functions with
8744         gdbarch.
8745
8746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8747
8748         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8749         (m68hc11_unwind_sp): Delete.
8750         (m68hc11_gdbarch_init): Don't register deleted functions with
8751         gdbarch.
8752
8753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * m32r-tdep.c (m32r_unwind_sp): Delete.
8756         (m32r_unwind_pc): Delete.
8757         (m32r_dummy_id): Delete.
8758         (m32r_gdbarch_init): Don't register deleted functions with
8759         gdbarch.
8760
8761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8762
8763         * m32c-tdep.c (m32c_unwind_pc): Delete.
8764         (m32c_unwind_sp): Delete.
8765         (m32c_dummy_id): Delete.
8766         (m32c_gdbarch_init): Don't register deleted functions with
8767         gdbarch.
8768
8769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8772         (lm32_unwind_pc): Delete.
8773         (lm32_dummy_id): Delete.
8774         (lm32_gdbarch_init): Don't register deleted functions with
8775         gdbarch.
8776
8777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8780         (iq2000_unwind_pc): Delete.
8781         (iq2000_dummy_id): Delete.
8782         (iq2000_gdbarch_init): Don't register deleted functions with
8783         gdbarch.
8784
8785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8786
8787         * nds32-tdep.c (nds32_type_align): Delete.
8788         (nds32_push_dummy_call): Use type_align instead.
8789
8790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * arm-tdep.c (arm_type_align): Only handle vector override case.
8793         (arm_push_dummy_call): Use type_align.
8794         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8795
8796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8797
8798         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8799         case.
8800         (pass_on_stack): Use type_align.
8801         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8802         function.
8803
8804 2019-04-23  Tom Tromey  <tromey@adacore.com>
8805
8806         * dwarf2read.c (line_header::file_name_at): Remove unused
8807         overload.
8808
8809 2019-04-23  Tom de Vries  <tdevries@suse.de>
8810
8811         PR gdb/24438
8812         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8813         invocation.
8814
8815
8816 2019-03-27  Ali Tamur  <tamur@google.com>
8817
8818         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8819         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8820         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8821         (dwarf_expr_context::get_addr_index): Likewise
8822         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8823         (symbol_needs_eval_context::get_addr_index): Likewise
8824         (disassemble_dwarf_expression): Add DW_OP_addrx
8825         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8826         (read_cutu_die_from_dwo): Update comment
8827         (skip_one_die): Add DW_FORM_addrx
8828         (read_attribute_value): Likewise
8829         (var_decode_location): Add DW_OP_addrx
8830         (dwarf2_const_value_attr): Add DW_FORM_addrx
8831         (dump_die_shallow): Likewise
8832         (dwarf2_fetch_constant_bytes): Likewise
8833         (decode_locdesc): Add DW_OP_addrx
8834         (skip_form_bytes): Add DW_FORM_addrx
8835
8836 2019-04-22  Ali Tamur  <tamur@google.com>
8837
8838         * MAINTAINERS (Write After Approval): Add self.
8839
8840 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8841
8842         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8843         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8844         (open_symbol_file_object): Likewise.
8845         (svr4_default_sos): Add info parameter.
8846         (svr4_read_so_list): Likewise.
8847         (svr4_current_sos_direct): Adjust functions calls to pass down
8848         info.
8849         (svr4_current_sos_1): Add info parameter.
8850         (svr4_current_sos): Call get_svr4_info, pass info down to
8851         svr4_current_sos_1.
8852         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8853         get_svr4_info.
8854         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8855         get_svr4_info.
8856         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8857         to get_svr4_info.
8858         (probes_table_remove_objfile_probes): Likewise.
8859         (register_solib_event_probe): Add info parameter.
8860         (solist_update_incremental): Pass info parameter down to
8861         svr4_read_so_list.
8862         (disable_probes_interface): Add info parameter.
8863         (svr4_handle_solib_event): Pass current_program_space to
8864         get_svr4_info.  Adjust disable_probes_interface cleanup.
8865         (svr4_create_probe_breakpoints): Add info parameter, pass it
8866         down to register_solib_event_probe.
8867         (svr4_create_solib_event_breakpoints): Add info parameter,
8868         pass it down to svr4_create_probe_breakpoints.
8869         (enable_break): Pass info down to
8870         svr4_create_solib_event_breakpoints.
8871         (svr4_solib_create_inferior_hook): Pass current_program_space to
8872         get_svr4_info.
8873         (svr4_clear_solib): Likewise.
8874
8875 2019-04-22  Pedro Alves  <palves@redhat.com>
8876
8877         * solib-svr4.c (svr4_free_objfile_observer): New.
8878         (probe_and_action::objfile): New field.
8879         (probes_table_htab_remove_objfile_probes)
8880         (probes_table_remove_objfile_probes): New functions.
8881         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8882         in the new probe_and_action.  Don't store the probe in 'lookup'.
8883         (svr4_create_probe_breakpoints): Pass objfile to
8884         register_solib_event_probe.
8885         (_initialize_svr4_solib): Register a free_objfile observer.
8886
8887 2019-04-19  Tom Tromey  <tom@tromey.com>
8888
8889         * common/queue.h: Remove.
8890
8891 2019-04-19  Tom Tromey  <tom@tromey.com>
8892
8893         * event-loop.c: Don't include "common/queue.h".
8894
8895 2019-04-19  Tom Tromey  <tom@tromey.com>
8896
8897         * remote.c (remote_target): Use delete.
8898         * remote-notif.h: Include <list>, not "common/queue.h".
8899         (notif_client_p): Remove typedef.
8900         (remote_notif_state): Add constructor, destructor, initializer.
8901         <notif_queue>: Now a std::list.
8902         (remote_notif_state_xfree): Don't declare.
8903         * remote-notif.c (remote_notif_process, handle_notification)
8904         (remote_notif_state_allocate): Update.
8905         (~remote_notif_state): Rename from remote_notif_state_xfree.
8906
8907 2019-04-19  Tom Tromey  <tom@tromey.com>
8908
8909         * symfile.c (reread_symbols): Update.
8910         * objfiles.c (objfile_register_static_link)
8911         (objfile_lookup_static_link): Update
8912         (~objfile) Don't delete static_links.
8913         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8914
8915 2019-04-19  Tom Tromey  <tom@tromey.com>
8916
8917         * type-stack.h (struct type_stack) <insert>: Constify string.
8918         * type-stack.c (type_stack::insert): Constify string.
8919         * gdbtypes.h (lookup_template_type): Update.
8920         (address_space_name_to_int): Update.
8921         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8922         const.
8923         (lookup_template_type): Make name const.
8924         * c-exp.y: Update rules.
8925         (lex_one_token, classify_name, classify_inner_name)
8926         (c_print_token): Update.
8927         * p-exp.y: Update rules.
8928         (yylex): Update.
8929         * f-exp.y: Update rules.
8930         (yylex): Update.
8931         * d-exp.y: Update rules.
8932         (lex_one_token, classify_name, classify_inner_name): Update.
8933         * parse.c (write_dollar_variable, copy_name): Return std::string.
8934         * parser-defs.h (copy_name): Change return type.
8935         * m2-exp.y: Update rules.
8936         (yylex): Update.
8937         * go-exp.y (lex_one_token): Update.
8938         Update rules.
8939         (classify_unsafe_function, classify_packaged_name)
8940         (classify_name, yylex): Update.
8941
8942 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8943
8944         * configure.ac: add --enable-source-highlight switch.
8945         * configure: Regenerate.
8946         * top.c (print_gdb_version): plumb --enable-source-highlight
8947         status to "show configuration".
8948
8949 2019-04-19  Tom Tromey  <tromey@adacore.com>
8950
8951         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8952         Check ADA_TYPE_P.
8953         (empty_record, ada_template_to_fixed_record_type_1)
8954         (template_to_static_fixed_type)
8955         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8956         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8957         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8958         macros.
8959
8960 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8961
8962         PR symtab/24423:
8963         * source.c (print_source_lines_base): Advance "iter" when a
8964         control character is seen.
8965
8966 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8967
8968         * inferior.h (struct infcall_suspend_state_deleter):
8969         Catch exception in destructor to avoid crash.
8970
8971 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8972
8973         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8974         close to the add_com "shell".
8975
8976 2019-04-18  Tom Tromey  <tromey@adacore.com>
8977
8978         * process-stratum-target.h (class process_stratum_target)
8979         <stratum>: Add "final".
8980
8981 2019-04-17  Tom Tromey  <tromey@adacore.com>
8982
8983         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8984         against nullptr before use.
8985
8986 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8987
8988         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8989
8990 2019-04-17  Jim Wilson  <jimw@sifive.com>
8991             Andrew Burgess  <andrew.burgess@embecosm.com>
8992
8993         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8994         code read might fail, assume 4-byte breakpoint in that case.
8995
8996 2019-04-15  Leszek Swirski  <leszeks@google.com>
8997
8998         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8999         rather than a hand-rolled POD check when checking for forced MEMORY
9000         classification.
9001
9002 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9003
9004         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9005         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9006         function.
9007         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9008         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9009         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9010         declaration.
9011
9012 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9013
9014         * aarch64-linux-nat.c
9015         (aarch64_linux_nat_target::thread_architecture): Add override.
9016         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9017         each VQ.
9018
9019 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9020
9021         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9022
9023 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9024
9025         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9026         target types of size 96-bits, add some additional comments, and
9027         check that the builtin type we found was the correct size.
9028
9029 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9030
9031         * utils.c (prompt_for_continue): Don't restore the styling at the
9032         end, as applied_style has the wrong value.  This fixes styling in
9033         long lists of file names that are interrupted by the "Continue?"
9034         prompt.
9035
9036 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9037
9038         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9039         * c-lang.c (c_language_defn): Likewise.
9040         (cplus_language_defn): Likewise.
9041         (asm_language_defn): Likewise.
9042         (minimal_language_defn): Likewise.
9043         * d-lang.c (d_language_defn): Likewise.
9044         * f-lang.c (f_language_defn): Likewise.
9045         * go-lang.c (go_language_defn): Likewise.
9046         * language.c (unknown_language_defn): Likewise.
9047         (auto_language_defn): Likewise.
9048         * language.h (struct language_defn): Remove la_magic field.
9049         (LANG_MAGIC): Delete.
9050         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9051         * objc-lang.c (objc_language_defn): Likewise.
9052         * opencl-lang.c (opencl_language_defn): Likewise.
9053         * p-lang.c (pascal_language_defn): Likewise.
9054         * rust-lang.c (rust_language_defn): Likewise.
9055
9056 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9057
9058         * riscv-tdep.c (riscv_type_align): New function.
9059         (riscv_type_alignment): Delete.
9060         (riscv_arg_location): Use 'type_align'.
9061         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9062
9063 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9064
9065         * gdbtypes.c (type_align): A struct with no non-static fields also
9066         has alignment of 1.
9067
9068 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9069
9070         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9071         component to 0.
9072         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9073         member.
9074         (riscv_struct_info::analyse): New implementation using new
9075         analyse_inner member function.
9076         (riscv_struct_info::field_offset): New member function.
9077         (riscv_struct_info::m_offsets): New member variable.
9078         (riscv_struct_info::analyse_inner): New private member function,
9079         takes the old implementation of riscv_struct_info::analyse but
9080         extended to track field offsets.
9081         (riscv_call_arg_struct): Update the struct folding special cases
9082         to handle cases where empty C++ structs, which are non-zero
9083         length, are found.
9084         (riscv_arg_location): Initialise the length of each location, a
9085         non-zero length now indicates the location is in use.
9086         (riscv_push_dummy_call): Allow for the first location having a
9087         non-zero offset when setting up arguments.
9088         (riscv_return_value): Likewise, but for return values.
9089
9090 2019-04-11  Tom Tromey  <tromey@adacore.com>
9091
9092         * utils.c (internal_vproblem): Make "msg" const.
9093
9094 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9095
9096         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9097         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9098         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9099         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9100
9101 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9102
9103         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9104         function.
9105         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9106         of amd64_collect_native_gregset.
9107         (amd64_linux_nat_target::store_registers): Likewise.
9108
9109 2019-04-10  Tom Tromey  <tom@tromey.com>
9110
9111         * symtab.c (lookup_global_symbol_from_objfile)
9112         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9113         * objfiles.h (class separate_debug_iterator): New.
9114         (class separate_debug_range): New.
9115         (struct objfile) <separate_debug_objfiles>: New method.
9116         (objfile_separate_debug_iterate): Don't declare.
9117         * objfiles.c (separate_debug_iterator::operator++): Rename from
9118         objfile_separate_debug_iterate.
9119         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9120         iterator.
9121         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9122         iterator.
9123
9124 2019-04-10  Tom Tromey  <tom@tromey.com>
9125
9126         * symfile.c (reread_symbols): Remove old comment.
9127         * objfiles.c (free_all_objfiles): Fix a typo.
9128
9129 2019-04-10  Tom Tromey  <tom@tromey.com>
9130
9131         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9132         * minsyms.c (lookup_minimal_symbol): Use foreach.
9133         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9134         (lookup_minimal_symbol_solib_trampoline): Likewise.
9135         * symfile.c (reread_symbols): Use foreach.
9136
9137 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9138             Tom Tromey  <tromey@adacore.com>
9139
9140         PR rust/24414:
9141         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9142         (rust_lex_int_test): Change "value" to be LONGEST.
9143         (rust_lex_tests): Add test for long integer literal.
9144
9145 2019-04-09  Tom Tromey  <tromey@adacore.com>
9146
9147         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9148         to bool.
9149         (extended_remote_target::attach): Update.
9150         (remote_target::remote_notice_new_inferior): Update.
9151         (remote_target::add_current_inferior_and_thread): Update.
9152         * inferior.c (exit_inferior_1): Use "false".
9153         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9154
9155 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9156
9157         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9158         the "start" command.
9159
9160 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9161
9162         * python/py-inferior.c (infpy_thread_from_thread_handle):
9163         Adjust comments to reflect renaming of thread_from_thread_handle
9164         to thread_from_handle.  Adjust keywords.  Fix type error message.
9165         (inferior_object_methods): Add thread_from_handle.  Retain
9166         thread_from_thread_handle, but mark it as deprecated.
9167
9168 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9169
9170         * gdbthread.h (find_thread_by_handle): Revise declaration.
9171         * thread.c (find_thread_by_handle): Likewise.  Adjust
9172         implementation too.
9173         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9174         support for buffer objects as handles.
9175
9176 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9177
9178         * python/py-infthread.c (thpy_thread_handle): New function.
9179         (thread_object_methods): Register thpy_thread_handle.
9180
9181 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9182
9183         * gdbthread.h (thread_to_thread_handle): Declare.
9184         * thread.c (gdbtypes.h): Include.
9185         (thread_to_thread_handle): New function.
9186
9187         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9188         (target_thread_info_to_thread_handle): Declare.
9189         * target.c (target_thread_info_to_thread_handle): New function.
9190         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9191         * target-delegates.c: Regenerate.
9192
9193         * linux-thread-db.c (class thread_db_target): Add method
9194         thread_info_to_thread_handle.
9195         (thread_db_target::thread_info_to_thread_handle): Define.
9196         * remote.c (class remote_target): Add new method
9197         thread_info_to_thread_handle.
9198         (remote_target::thread_info_to_thread_handle): Define.
9199
9200 2019-04-08  Pedro Alves  <palves@redhat.com>
9201
9202         * common/common-exceptions.c (throw_exception): Don't create
9203         named object to throw; throw directly.
9204         (throw_it): Likewise.  Don't initialize gdb_exception::message
9205         here, with new; pass FMT and AP to the ctor instead.
9206         * common/common-exceptions.h: Include <string>.
9207         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9208         const char *, va_list)): New ctor.  Use std::make_shared.
9209         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9210         errors)): Delete.
9211         (gdb_exception_error::gdb_exception_error(enum errors, const char
9212         *, va_list)): New.
9213         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9214         Add assertion.
9215         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9216         errors)): Delete.
9217         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9218         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9219         Add assertion.
9220
9221 2019-04-08  Tom Tromey  <tom@tromey.com>
9222
9223         * valops.c (value_rtti_indirect_type): Replace throw_exception
9224         with throw.
9225         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9226         with throw.
9227         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9228         throw.
9229         * target.c (target_translate_tls_address): Replace throw_exception
9230         with throw.
9231         * stack.c (frame_apply_command_count): Replace throw_exception
9232         with throw.
9233         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9234         throw.
9235         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9236         with throw.
9237         * rs6000-tdep.c (rs6000_frame_cache)
9238         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9239         * remote.c: Replace throw_exception with throw.
9240         * record-full.c (record_full_message, record_full_wait_1)
9241         (record_full_restore): Replace throw_exception with throw.
9242         * record-btrace.c:
9243         (get_thread_current_frame_id, record_btrace_start_replaying)
9244         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9245         (cmd_record_btrace_start): Replace throw_exception with throw.
9246         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9247         throw.
9248         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9249         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9250         * linespec.c:
9251         (find_linespec_symbols): Replace throw_exception with throw.
9252         * infrun.c (displaced_step_prepare, resume): Replace
9253         throw_exception with throw.
9254         * infcmd.c (post_create_inferior): Replace throw_exception with
9255         throw.
9256         * inf-loop.c (inferior_event_handler): Replace throw_exception
9257         with throw.
9258         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9259         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9260         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9261         (get_prev_frame_always, get_frame_pc_if_available)
9262         (get_frame_address_in_block_if_available, get_frame_language):
9263         Replace throw_exception with throw.
9264         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9265         throw_exception with throw.
9266         * eval.c (fetch_subexp_value, evaluate_var_value)
9267         (evaluate_funcall, evaluate_subexp_standard): Replace
9268         throw_exception with throw.
9269         * dwarf2loc.c (call_site_find_chain)
9270         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9271         Replace throw_exception with throw.
9272         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9273         with throw.
9274         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9275         throw.
9276         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9277         * completer.c (complete_line_internal): Replace throw_exception
9278         with throw.
9279         * compile/compile-object-run.c (compile_object_run): Replace
9280         throw_exception with throw.
9281         * cli/cli-script.c (process_next_line): Replace throw_exception
9282         with throw.
9283         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9284         (btrace_enable, btrace_maint_update_pt_packets): Replace
9285         throw_exception with throw.
9286         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9287         throw_exception with throw.
9288         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9289         throw_exception with throw.
9290         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9291         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9292         * aarch64-tdep.c (aarch64_make_prologue_cache)
9293         (aarch64_make_stub_cache): Replace throw_exception with throw.
9294
9295 2019-04-08  Tom Tromey  <tom@tromey.com>
9296
9297         * common/common-exceptions.c (throw_exception): Rename from
9298         throw_exception_cxx.  Remove old copy.  Make argument const.
9299         (throw_it): Create and throw exception objects directly.
9300         * common/common-exceptions.h (throw_exception): Make argument
9301         const.
9302         (struct gdb_exception_error): Add constructor.
9303         (struct gdb_exception_quit): Add constructor.
9304
9305 2019-04-08  Tom Tromey  <tom@tromey.com>
9306
9307         * common/common-exceptions.h (exception_rethrow): Don't declare.
9308         (TRY_SJLJ): Update comment.
9309         (TRY, CATCH, END_CATCH): Remove.
9310         * common/common-exceptions.c (exception_rethrow): Remove.
9311
9312 2019-04-08  Tom Tromey  <tom@tromey.com>
9313
9314         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9315         Remove.
9316         (gdb_exception_error): Rename from
9317         gdb_exception_RETURN_MASK_ERROR.
9318         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9319         (gdb_quit_bad_alloc): Update.
9320         * aarch64-tdep.c: Update.
9321         * ada-lang.c: Update.
9322         * ada-typeprint.c: Update.
9323         * ada-valprint.c: Update.
9324         * amd64-tdep.c: Update.
9325         * arch-utils.c: Update.
9326         * break-catch-throw.c: Update.
9327         * breakpoint.c: Update.
9328         * btrace.c: Update.
9329         * c-varobj.c: Update.
9330         * cli/cli-cmds.c: Update.
9331         * cli/cli-interp.c: Update.
9332         * cli/cli-script.c: Update.
9333         * common/common-exceptions.c: Update.
9334         * common/new-op.c: Update.
9335         * common/selftest.c: Update.
9336         * compile/compile-c-symbols.c: Update.
9337         * compile/compile-cplus-symbols.c: Update.
9338         * compile/compile-object-load.c: Update.
9339         * compile/compile-object-run.c: Update.
9340         * completer.c: Update.
9341         * corelow.c: Update.
9342         * cp-abi.c: Update.
9343         * cp-support.c: Update.
9344         * cp-valprint.c: Update.
9345         * darwin-nat.c: Update.
9346         * disasm-selftests.c: Update.
9347         * dtrace-probe.c: Update.
9348         * dwarf-index-cache.c: Update.
9349         * dwarf-index-write.c: Update.
9350         * dwarf2-frame-tailcall.c: Update.
9351         * dwarf2-frame.c: Update.
9352         * dwarf2loc.c: Update.
9353         * dwarf2read.c: Update.
9354         * eval.c: Update.
9355         * event-loop.c: Update.
9356         * event-top.c: Update.
9357         * exec.c: Update.
9358         * f-valprint.c: Update.
9359         * fbsd-tdep.c: Update.
9360         * frame-unwind.c: Update.
9361         * frame.c: Update.
9362         * gdbtypes.c: Update.
9363         * gnu-v3-abi.c: Update.
9364         * guile/guile-internal.h: Update.
9365         * guile/scm-block.c: Update.
9366         * guile/scm-breakpoint.c: Update.
9367         * guile/scm-cmd.c: Update.
9368         * guile/scm-disasm.c: Update.
9369         * guile/scm-frame.c: Update.
9370         * guile/scm-lazy-string.c: Update.
9371         * guile/scm-math.c: Update.
9372         * guile/scm-param.c: Update.
9373         * guile/scm-ports.c: Update.
9374         * guile/scm-pretty-print.c: Update.
9375         * guile/scm-symbol.c: Update.
9376         * guile/scm-symtab.c: Update.
9377         * guile/scm-type.c: Update.
9378         * guile/scm-value.c: Update.
9379         * i386-linux-tdep.c: Update.
9380         * i386-tdep.c: Update.
9381         * inf-loop.c: Update.
9382         * infcall.c: Update.
9383         * infcmd.c: Update.
9384         * infrun.c: Update.
9385         * jit.c: Update.
9386         * language.c: Update.
9387         * linespec.c: Update.
9388         * linux-fork.c: Update.
9389         * linux-nat.c: Update.
9390         * linux-tdep.c: Update.
9391         * linux-thread-db.c: Update.
9392         * main.c: Update.
9393         * mi/mi-cmd-break.c: Update.
9394         * mi/mi-cmd-stack.c: Update.
9395         * mi/mi-interp.c: Update.
9396         * mi/mi-main.c: Update.
9397         * objc-lang.c: Update.
9398         * p-valprint.c: Update.
9399         * parse.c: Update.
9400         * ppc-linux-tdep.c: Update.
9401         * printcmd.c: Update.
9402         * python/py-arch.c: Update.
9403         * python/py-breakpoint.c: Update.
9404         * python/py-cmd.c: Update.
9405         * python/py-finishbreakpoint.c: Update.
9406         * python/py-frame.c: Update.
9407         * python/py-framefilter.c: Update.
9408         * python/py-gdb-readline.c: Update.
9409         * python/py-inferior.c: Update.
9410         * python/py-infthread.c: Update.
9411         * python/py-lazy-string.c: Update.
9412         * python/py-linetable.c: Update.
9413         * python/py-objfile.c: Update.
9414         * python/py-param.c: Update.
9415         * python/py-prettyprint.c: Update.
9416         * python/py-progspace.c: Update.
9417         * python/py-record-btrace.c: Update.
9418         * python/py-record.c: Update.
9419         * python/py-symbol.c: Update.
9420         * python/py-type.c: Update.
9421         * python/py-unwind.c: Update.
9422         * python/py-utils.c: Update.
9423         * python/py-value.c: Update.
9424         * python/python.c: Update.
9425         * record-btrace.c: Update.
9426         * record-full.c: Update.
9427         * remote-fileio.c: Update.
9428         * remote.c: Update.
9429         * riscv-tdep.c: Update.
9430         * rs6000-aix-tdep.c: Update.
9431         * rs6000-tdep.c: Update.
9432         * rust-exp.y: Update.
9433         * rust-lang.c: Update.
9434         * s390-tdep.c: Update.
9435         * selftest-arch.c: Update.
9436         * solib-dsbt.c: Update.
9437         * solib-frv.c: Update.
9438         * solib-spu.c: Update.
9439         * solib-svr4.c: Update.
9440         * solib.c: Update.
9441         * sparc64-linux-tdep.c: Update.
9442         * stack.c: Update.
9443         * symfile-mem.c: Update.
9444         * symmisc.c: Update.
9445         * target.c: Update.
9446         * thread.c: Update.
9447         * top.c: Update.
9448         * tracefile-tfile.c: Update.
9449         * tui/tui.c: Update.
9450         * typeprint.c: Update.
9451         * unittests/cli-utils-selftests.c: Update.
9452         * unittests/parse-connection-spec-selftests.c: Update.
9453         * valops.c: Update.
9454         * valprint.c: Update.
9455         * value.c: Update.
9456         * varobj.c: Update.
9457         * windows-nat.c: Update.
9458         * x86-linux-nat.c: Update.
9459         * xml-support.c: Update.
9460
9461 2019-04-08  Tom Tromey  <tom@tromey.com>
9462
9463         * xml-support.c: Use C++ exception handling.
9464         * x86-linux-nat.c: Use C++ exception handling.
9465         * windows-nat.c: Use C++ exception handling.
9466         * varobj.c: Use C++ exception handling.
9467         * value.c: Use C++ exception handling.
9468         * valprint.c: Use C++ exception handling.
9469         * valops.c: Use C++ exception handling.
9470         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9471         handling.
9472         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9473         * typeprint.c: Use C++ exception handling.
9474         * tui/tui.c: Use C++ exception handling.
9475         * tracefile-tfile.c: Use C++ exception handling.
9476         * top.c: Use C++ exception handling.
9477         * thread.c: Use C++ exception handling.
9478         * target.c: Use C++ exception handling.
9479         * symmisc.c: Use C++ exception handling.
9480         * symfile-mem.c: Use C++ exception handling.
9481         * stack.c: Use C++ exception handling.
9482         * sparc64-linux-tdep.c: Use C++ exception handling.
9483         * solib.c: Use C++ exception handling.
9484         * solib-svr4.c: Use C++ exception handling.
9485         * solib-spu.c: Use C++ exception handling.
9486         * solib-frv.c: Use C++ exception handling.
9487         * solib-dsbt.c: Use C++ exception handling.
9488         * selftest-arch.c: Use C++ exception handling.
9489         * s390-tdep.c: Use C++ exception handling.
9490         * rust-lang.c: Use C++ exception handling.
9491         * rust-exp.y: Use C++ exception handling.
9492         * rs6000-tdep.c: Use C++ exception handling.
9493         * rs6000-aix-tdep.c: Use C++ exception handling.
9494         * riscv-tdep.c: Use C++ exception handling.
9495         * remote.c: Use C++ exception handling.
9496         * remote-fileio.c: Use C++ exception handling.
9497         * record-full.c: Use C++ exception handling.
9498         * record-btrace.c: Use C++ exception handling.
9499         * python/python.c: Use C++ exception handling.
9500         * python/py-value.c: Use C++ exception handling.
9501         * python/py-utils.c: Use C++ exception handling.
9502         * python/py-unwind.c: Use C++ exception handling.
9503         * python/py-type.c: Use C++ exception handling.
9504         * python/py-symbol.c: Use C++ exception handling.
9505         * python/py-record.c: Use C++ exception handling.
9506         * python/py-record-btrace.c: Use C++ exception handling.
9507         * python/py-progspace.c: Use C++ exception handling.
9508         * python/py-prettyprint.c: Use C++ exception handling.
9509         * python/py-param.c: Use C++ exception handling.
9510         * python/py-objfile.c: Use C++ exception handling.
9511         * python/py-linetable.c: Use C++ exception handling.
9512         * python/py-lazy-string.c: Use C++ exception handling.
9513         * python/py-infthread.c: Use C++ exception handling.
9514         * python/py-inferior.c: Use C++ exception handling.
9515         * python/py-gdb-readline.c: Use C++ exception handling.
9516         * python/py-framefilter.c: Use C++ exception handling.
9517         * python/py-frame.c: Use C++ exception handling.
9518         * python/py-finishbreakpoint.c: Use C++ exception handling.
9519         * python/py-cmd.c: Use C++ exception handling.
9520         * python/py-breakpoint.c: Use C++ exception handling.
9521         * python/py-arch.c: Use C++ exception handling.
9522         * printcmd.c: Use C++ exception handling.
9523         * ppc-linux-tdep.c: Use C++ exception handling.
9524         * parse.c: Use C++ exception handling.
9525         * p-valprint.c: Use C++ exception handling.
9526         * objc-lang.c: Use C++ exception handling.
9527         * mi/mi-main.c: Use C++ exception handling.
9528         * mi/mi-interp.c: Use C++ exception handling.
9529         * mi/mi-cmd-stack.c: Use C++ exception handling.
9530         * mi/mi-cmd-break.c: Use C++ exception handling.
9531         * main.c: Use C++ exception handling.
9532         * linux-thread-db.c: Use C++ exception handling.
9533         * linux-tdep.c: Use C++ exception handling.
9534         * linux-nat.c: Use C++ exception handling.
9535         * linux-fork.c: Use C++ exception handling.
9536         * linespec.c: Use C++ exception handling.
9537         * language.c: Use C++ exception handling.
9538         * jit.c: Use C++ exception handling.
9539         * infrun.c: Use C++ exception handling.
9540         * infcmd.c: Use C++ exception handling.
9541         * infcall.c: Use C++ exception handling.
9542         * inf-loop.c: Use C++ exception handling.
9543         * i386-tdep.c: Use C++ exception handling.
9544         * i386-linux-tdep.c: Use C++ exception handling.
9545         * guile/scm-value.c: Use C++ exception handling.
9546         * guile/scm-type.c: Use C++ exception handling.
9547         * guile/scm-symtab.c: Use C++ exception handling.
9548         * guile/scm-symbol.c: Use C++ exception handling.
9549         * guile/scm-pretty-print.c: Use C++ exception handling.
9550         * guile/scm-ports.c: Use C++ exception handling.
9551         * guile/scm-param.c: Use C++ exception handling.
9552         * guile/scm-math.c: Use C++ exception handling.
9553         * guile/scm-lazy-string.c: Use C++ exception handling.
9554         * guile/scm-frame.c: Use C++ exception handling.
9555         * guile/scm-disasm.c: Use C++ exception handling.
9556         * guile/scm-cmd.c: Use C++ exception handling.
9557         * guile/scm-breakpoint.c: Use C++ exception handling.
9558         * guile/scm-block.c: Use C++ exception handling.
9559         * guile/guile-internal.h: Use C++ exception handling.
9560         * gnu-v3-abi.c: Use C++ exception handling.
9561         * gdbtypes.c: Use C++ exception handling.
9562         * frame.c: Use C++ exception handling.
9563         * frame-unwind.c: Use C++ exception handling.
9564         * fbsd-tdep.c: Use C++ exception handling.
9565         * f-valprint.c: Use C++ exception handling.
9566         * exec.c: Use C++ exception handling.
9567         * event-top.c: Use C++ exception handling.
9568         * event-loop.c: Use C++ exception handling.
9569         * eval.c: Use C++ exception handling.
9570         * dwarf2read.c: Use C++ exception handling.
9571         * dwarf2loc.c: Use C++ exception handling.
9572         * dwarf2-frame.c: Use C++ exception handling.
9573         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9574         * dwarf-index-write.c: Use C++ exception handling.
9575         * dwarf-index-cache.c: Use C++ exception handling.
9576         * dtrace-probe.c: Use C++ exception handling.
9577         * disasm-selftests.c: Use C++ exception handling.
9578         * darwin-nat.c: Use C++ exception handling.
9579         * cp-valprint.c: Use C++ exception handling.
9580         * cp-support.c: Use C++ exception handling.
9581         * cp-abi.c: Use C++ exception handling.
9582         * corelow.c: Use C++ exception handling.
9583         * completer.c: Use C++ exception handling.
9584         * compile/compile-object-run.c: Use C++ exception handling.
9585         * compile/compile-object-load.c: Use C++ exception handling.
9586         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9587         * compile/compile-c-symbols.c: Use C++ exception handling.
9588         * common/selftest.c: Use C++ exception handling.
9589         * common/new-op.c: Use C++ exception handling.
9590         * cli/cli-script.c: Use C++ exception handling.
9591         * cli/cli-interp.c: Use C++ exception handling.
9592         * cli/cli-cmds.c: Use C++ exception handling.
9593         * c-varobj.c: Use C++ exception handling.
9594         * btrace.c: Use C++ exception handling.
9595         * breakpoint.c: Use C++ exception handling.
9596         * break-catch-throw.c: Use C++ exception handling.
9597         * arch-utils.c: Use C++ exception handling.
9598         * amd64-tdep.c: Use C++ exception handling.
9599         * ada-valprint.c: Use C++ exception handling.
9600         * ada-typeprint.c: Use C++ exception handling.
9601         * ada-lang.c: Use C++ exception handling.
9602         * aarch64-tdep.c: Use C++ exception handling.
9603
9604 2019-04-08  Tom Tromey  <tom@tromey.com>
9605
9606         * xml-support.c (gdb_xml_parser::parse): Update.
9607         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9608         * value.c (show_convenience): Update.
9609         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9610         (test_parse_flags_qcs): Update.
9611         * thread.c (thr_try_catch_cmd): Update.
9612         * target.c (target_translate_tls_address): Update.
9613         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9614         (info_frame_command_core, frame_apply_command_count): Update.
9615         * rust-exp.y (rust_lex_exception_test): Update.
9616         * riscv-tdep.c (riscv_print_one_register_info): Update.
9617         * remote.c (remote_target::enable_btrace): Update.
9618         * record-btrace.c (record_btrace_enable_warn): Update.
9619         * python/py-utils.c (gdbpy_convert_exception): Update.
9620         * printcmd.c (do_one_display, print_variable_and_value): Update.
9621         * mi/mi-main.c (mi_print_exception): Update.
9622         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9623         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9624         * linux-nat.c (linux_nat_target::attach): Update.
9625         * linux-fork.c (class scoped_switch_fork_info): Update.
9626         * infrun.c (displaced_step_prepare): Update.
9627         * infcall.c (call_function_by_hand_dummy): Update.
9628         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9629         * gnu-v3-abi.c (print_one_vtable): Update.
9630         * frame.c (get_prev_frame_always): Update.
9631         * f-valprint.c (info_common_command_for_block): Update.
9632         * exec.c (try_open_exec_file): Update.
9633         * exceptions.c (print_exception, exception_print)
9634         (exception_fprintf, exception_print_same): Update.
9635         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9636         * dwarf-index-cache.c (index_cache::store)
9637         (index_cache::lookup_gdb_index): Update.
9638         * darwin-nat.c (maybe_cache_shell): Update.
9639         * cp-valprint.c (cp_print_value_fields): Update.
9640         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9641         (gcc_cplus_symbol_address): Update.
9642         * compile/compile-c-symbols.c (gcc_convert_symbol)
9643         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9644         * common/selftest.c: Update.
9645         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9646         a std::string.
9647         (exception_try_scope_entry, exception_try_scope_exit): Don't
9648         declare.
9649         (struct exception_try_scope): Remove.
9650         (TRY): Don't use exception_try_scope.
9651         (struct gdb_exception): Add constructor, operator=.
9652         <what>: New method.
9653         (struct gdb_exception_RETURN_MASK_ALL)
9654         (struct gdb_exception_RETURN_MASK_ERROR)
9655         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9656         (struct gdb_quit_bad_alloc): Update.
9657         * common/common-exceptions.c (exception_none): Change
9658         initializer.
9659         (struct catcher) <state, exception>: Initialize inline.
9660         <prev>: Remove member.
9661         (current_catcher): Remove.
9662         (catchers): New global.
9663         (exceptions_state_mc_init): Simplify.
9664         (catcher_pop): Remove.
9665         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9666         (try_scope_depth, exception_try_scope_entry)
9667         (exception_try_scope_exit): Remove.
9668         (throw_exception_sjlj): Update.
9669         (exception_messages, exception_messages_size): Remove.
9670         (throw_it): Simplify.
9671         (gdb_exception_sliced_copy): Remove.
9672         (throw_exception_cxx): Update.
9673         * cli/cli-script.c (script_from_file): Update.
9674         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9675         Update.
9676         * ada-valprint.c (ada_val_print): Update.
9677         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9678         (create_excep_cond_exprs): Update.
9679
9680 2019-04-08  Tom Tromey  <tom@tromey.com>
9681
9682         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9683         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9684         (TRY, CATCH, END_CATCH): Remove some definitions.
9685         * common/common-exceptions.c: Don't use GDB_XCPT.
9686         (catcher_list_size): Remove.
9687         (throw_exception, throw_it): Simplify.
9688
9689 2019-04-05  Tom Tromey  <tom@tromey.com>
9690
9691         Revert the header-sorting patch.
9692         * ft32-tdep.c: Revert.
9693         * frv-tdep.c: Revert.
9694         * frv-linux-tdep.c: Revert.
9695         * frame.c: Revert.
9696         * frame-unwind.c: Revert.
9697         * frame-base.c: Revert.
9698         * fork-child.c: Revert.
9699         * findvar.c: Revert.
9700         * findcmd.c: Revert.
9701         * filesystem.c: Revert.
9702         * filename-seen-cache.h: Revert.
9703         * filename-seen-cache.c: Revert.
9704         * fbsd-tdep.c: Revert.
9705         * fbsd-nat.h: Revert.
9706         * fbsd-nat.c: Revert.
9707         * f-valprint.c: Revert.
9708         * f-typeprint.c: Revert.
9709         * f-lang.c: Revert.
9710         * extension.h: Revert.
9711         * extension.c: Revert.
9712         * extension-priv.h: Revert.
9713         * expprint.c: Revert.
9714         * exec.h: Revert.
9715         * exec.c: Revert.
9716         * exceptions.c: Revert.
9717         * event-top.c: Revert.
9718         * event-loop.c: Revert.
9719         * eval.c: Revert.
9720         * elfread.c: Revert.
9721         * dwarf2read.h: Revert.
9722         * dwarf2read.c: Revert.
9723         * dwarf2loc.c: Revert.
9724         * dwarf2expr.h: Revert.
9725         * dwarf2expr.c: Revert.
9726         * dwarf2-frame.c: Revert.
9727         * dwarf2-frame-tailcall.c: Revert.
9728         * dwarf-index-write.h: Revert.
9729         * dwarf-index-write.c: Revert.
9730         * dwarf-index-common.c: Revert.
9731         * dwarf-index-cache.h: Revert.
9732         * dwarf-index-cache.c: Revert.
9733         * dummy-frame.c: Revert.
9734         * dtrace-probe.c: Revert.
9735         * disasm.h: Revert.
9736         * disasm.c: Revert.
9737         * disasm-selftests.c: Revert.
9738         * dictionary.c: Revert.
9739         * dicos-tdep.c: Revert.
9740         * demangle.c: Revert.
9741         * dcache.h: Revert.
9742         * dcache.c: Revert.
9743         * darwin-nat.h: Revert.
9744         * darwin-nat.c: Revert.
9745         * darwin-nat-info.c: Revert.
9746         * d-valprint.c: Revert.
9747         * d-namespace.c: Revert.
9748         * d-lang.c: Revert.
9749         * ctf.c: Revert.
9750         * csky-tdep.c: Revert.
9751         * csky-linux-tdep.c: Revert.
9752         * cris-tdep.c: Revert.
9753         * cris-linux-tdep.c: Revert.
9754         * cp-valprint.c: Revert.
9755         * cp-support.c: Revert.
9756         * cp-namespace.c: Revert.
9757         * cp-abi.c: Revert.
9758         * corelow.c: Revert.
9759         * corefile.c: Revert.
9760         * continuations.c: Revert.
9761         * completer.h: Revert.
9762         * completer.c: Revert.
9763         * complaints.c: Revert.
9764         * coffread.c: Revert.
9765         * coff-pe-read.c: Revert.
9766         * cli-out.h: Revert.
9767         * cli-out.c: Revert.
9768         * charset.c: Revert.
9769         * c-varobj.c: Revert.
9770         * c-valprint.c: Revert.
9771         * c-typeprint.c: Revert.
9772         * c-lang.c: Revert.
9773         * buildsym.c: Revert.
9774         * buildsym-legacy.c: Revert.
9775         * build-id.h: Revert.
9776         * build-id.c: Revert.
9777         * btrace.c: Revert.
9778         * bsd-uthread.c: Revert.
9779         * breakpoint.h: Revert.
9780         * breakpoint.c: Revert.
9781         * break-catch-throw.c: Revert.
9782         * break-catch-syscall.c: Revert.
9783         * break-catch-sig.c: Revert.
9784         * blockframe.c: Revert.
9785         * block.c: Revert.
9786         * bfin-tdep.c: Revert.
9787         * bfin-linux-tdep.c: Revert.
9788         * bfd-target.c: Revert.
9789         * bcache.c: Revert.
9790         * ax-general.c: Revert.
9791         * ax-gdb.h: Revert.
9792         * ax-gdb.c: Revert.
9793         * avr-tdep.c: Revert.
9794         * auxv.c: Revert.
9795         * auto-load.c: Revert.
9796         * arm-wince-tdep.c: Revert.
9797         * arm-tdep.c: Revert.
9798         * arm-symbian-tdep.c: Revert.
9799         * arm-pikeos-tdep.c: Revert.
9800         * arm-obsd-tdep.c: Revert.
9801         * arm-nbsd-tdep.c: Revert.
9802         * arm-nbsd-nat.c: Revert.
9803         * arm-linux-tdep.c: Revert.
9804         * arm-linux-nat.c: Revert.
9805         * arm-fbsd-tdep.c: Revert.
9806         * arm-fbsd-nat.c: Revert.
9807         * arm-bsd-tdep.c: Revert.
9808         * arch-utils.c: Revert.
9809         * arc-tdep.c: Revert.
9810         * arc-newlib-tdep.c: Revert.
9811         * annotate.h: Revert.
9812         * annotate.c: Revert.
9813         * amd64-windows-tdep.c: Revert.
9814         * amd64-windows-nat.c: Revert.
9815         * amd64-tdep.c: Revert.
9816         * amd64-sol2-tdep.c: Revert.
9817         * amd64-obsd-tdep.c: Revert.
9818         * amd64-obsd-nat.c: Revert.
9819         * amd64-nbsd-tdep.c: Revert.
9820         * amd64-nbsd-nat.c: Revert.
9821         * amd64-nat.c: Revert.
9822         * amd64-linux-tdep.c: Revert.
9823         * amd64-linux-nat.c: Revert.
9824         * amd64-fbsd-tdep.c: Revert.
9825         * amd64-fbsd-nat.c: Revert.
9826         * amd64-dicos-tdep.c: Revert.
9827         * amd64-darwin-tdep.c: Revert.
9828         * amd64-bsd-nat.c: Revert.
9829         * alpha-tdep.c: Revert.
9830         * alpha-obsd-tdep.c: Revert.
9831         * alpha-nbsd-tdep.c: Revert.
9832         * alpha-mdebug-tdep.c: Revert.
9833         * alpha-linux-tdep.c: Revert.
9834         * alpha-linux-nat.c: Revert.
9835         * alpha-bsd-tdep.c: Revert.
9836         * alpha-bsd-nat.c: Revert.
9837         * aix-thread.c: Revert.
9838         * agent.c: Revert.
9839         * addrmap.c: Revert.
9840         * ada-varobj.c: Revert.
9841         * ada-valprint.c: Revert.
9842         * ada-typeprint.c: Revert.
9843         * ada-tasks.c: Revert.
9844         * ada-lang.c: Revert.
9845         * aarch64-tdep.c: Revert.
9846         * aarch64-ravenscar-thread.c: Revert.
9847         * aarch64-newlib-tdep.c: Revert.
9848         * aarch64-linux-tdep.c: Revert.
9849         * aarch64-linux-nat.c: Revert.
9850         * aarch64-fbsd-tdep.c: Revert.
9851         * aarch64-fbsd-nat.c: Revert.
9852         * aarch32-linux-nat.c: Revert.
9853
9854 2019-04-05  Tom Tromey  <tom@tromey.com>
9855
9856         * ft32-tdep.c: Sort headers.
9857         * frv-tdep.c: Sort headers.
9858         * frv-linux-tdep.c: Sort headers.
9859         * frame.c: Sort headers.
9860         * frame-unwind.c: Sort headers.
9861         * frame-base.c: Sort headers.
9862         * fork-child.c: Sort headers.
9863         * findvar.c: Sort headers.
9864         * findcmd.c: Sort headers.
9865         * filesystem.c: Sort headers.
9866         * filename-seen-cache.h: Sort headers.
9867         * filename-seen-cache.c: Sort headers.
9868         * fbsd-tdep.c: Sort headers.
9869         * fbsd-nat.h: Sort headers.
9870         * fbsd-nat.c: Sort headers.
9871         * f-valprint.c: Sort headers.
9872         * f-typeprint.c: Sort headers.
9873         * f-lang.c: Sort headers.
9874         * extension.h: Sort headers.
9875         * extension.c: Sort headers.
9876         * extension-priv.h: Sort headers.
9877         * expprint.c: Sort headers.
9878         * exec.h: Sort headers.
9879         * exec.c: Sort headers.
9880         * exceptions.c: Sort headers.
9881         * event-top.c: Sort headers.
9882         * event-loop.c: Sort headers.
9883         * eval.c: Sort headers.
9884         * elfread.c: Sort headers.
9885         * dwarf2read.h: Sort headers.
9886         * dwarf2read.c: Sort headers.
9887         * dwarf2loc.c: Sort headers.
9888         * dwarf2expr.h: Sort headers.
9889         * dwarf2expr.c: Sort headers.
9890         * dwarf2-frame.c: Sort headers.
9891         * dwarf2-frame-tailcall.c: Sort headers.
9892         * dwarf-index-write.h: Sort headers.
9893         * dwarf-index-write.c: Sort headers.
9894         * dwarf-index-common.c: Sort headers.
9895         * dwarf-index-cache.h: Sort headers.
9896         * dwarf-index-cache.c: Sort headers.
9897         * dummy-frame.c: Sort headers.
9898         * dtrace-probe.c: Sort headers.
9899         * disasm.h: Sort headers.
9900         * disasm.c: Sort headers.
9901         * disasm-selftests.c: Sort headers.
9902         * dictionary.c: Sort headers.
9903         * dicos-tdep.c: Sort headers.
9904         * demangle.c: Sort headers.
9905         * dcache.h: Sort headers.
9906         * dcache.c: Sort headers.
9907         * darwin-nat.h: Sort headers.
9908         * darwin-nat.c: Sort headers.
9909         * darwin-nat-info.c: Sort headers.
9910         * d-valprint.c: Sort headers.
9911         * d-namespace.c: Sort headers.
9912         * d-lang.c: Sort headers.
9913         * ctf.c: Sort headers.
9914         * csky-tdep.c: Sort headers.
9915         * csky-linux-tdep.c: Sort headers.
9916         * cris-tdep.c: Sort headers.
9917         * cris-linux-tdep.c: Sort headers.
9918         * cp-valprint.c: Sort headers.
9919         * cp-support.c: Sort headers.
9920         * cp-namespace.c: Sort headers.
9921         * cp-abi.c: Sort headers.
9922         * corelow.c: Sort headers.
9923         * corefile.c: Sort headers.
9924         * continuations.c: Sort headers.
9925         * completer.h: Sort headers.
9926         * completer.c: Sort headers.
9927         * complaints.c: Sort headers.
9928         * coffread.c: Sort headers.
9929         * coff-pe-read.c: Sort headers.
9930         * cli-out.h: Sort headers.
9931         * cli-out.c: Sort headers.
9932         * charset.c: Sort headers.
9933         * c-varobj.c: Sort headers.
9934         * c-valprint.c: Sort headers.
9935         * c-typeprint.c: Sort headers.
9936         * c-lang.c: Sort headers.
9937         * buildsym.c: Sort headers.
9938         * buildsym-legacy.c: Sort headers.
9939         * build-id.h: Sort headers.
9940         * build-id.c: Sort headers.
9941         * btrace.c: Sort headers.
9942         * bsd-uthread.c: Sort headers.
9943         * breakpoint.h: Sort headers.
9944         * breakpoint.c: Sort headers.
9945         * break-catch-throw.c: Sort headers.
9946         * break-catch-syscall.c: Sort headers.
9947         * break-catch-sig.c: Sort headers.
9948         * blockframe.c: Sort headers.
9949         * block.c: Sort headers.
9950         * bfin-tdep.c: Sort headers.
9951         * bfin-linux-tdep.c: Sort headers.
9952         * bfd-target.c: Sort headers.
9953         * bcache.c: Sort headers.
9954         * ax-general.c: Sort headers.
9955         * ax-gdb.h: Sort headers.
9956         * ax-gdb.c: Sort headers.
9957         * avr-tdep.c: Sort headers.
9958         * auxv.c: Sort headers.
9959         * auto-load.c: Sort headers.
9960         * arm-wince-tdep.c: Sort headers.
9961         * arm-tdep.c: Sort headers.
9962         * arm-symbian-tdep.c: Sort headers.
9963         * arm-pikeos-tdep.c: Sort headers.
9964         * arm-obsd-tdep.c: Sort headers.
9965         * arm-nbsd-tdep.c: Sort headers.
9966         * arm-nbsd-nat.c: Sort headers.
9967         * arm-linux-tdep.c: Sort headers.
9968         * arm-linux-nat.c: Sort headers.
9969         * arm-fbsd-tdep.c: Sort headers.
9970         * arm-fbsd-nat.c: Sort headers.
9971         * arm-bsd-tdep.c: Sort headers.
9972         * arch-utils.c: Sort headers.
9973         * arc-tdep.c: Sort headers.
9974         * arc-newlib-tdep.c: Sort headers.
9975         * annotate.h: Sort headers.
9976         * annotate.c: Sort headers.
9977         * amd64-windows-tdep.c: Sort headers.
9978         * amd64-windows-nat.c: Sort headers.
9979         * amd64-tdep.c: Sort headers.
9980         * amd64-sol2-tdep.c: Sort headers.
9981         * amd64-obsd-tdep.c: Sort headers.
9982         * amd64-obsd-nat.c: Sort headers.
9983         * amd64-nbsd-tdep.c: Sort headers.
9984         * amd64-nbsd-nat.c: Sort headers.
9985         * amd64-nat.c: Sort headers.
9986         * amd64-linux-tdep.c: Sort headers.
9987         * amd64-linux-nat.c: Sort headers.
9988         * amd64-fbsd-tdep.c: Sort headers.
9989         * amd64-fbsd-nat.c: Sort headers.
9990         * amd64-dicos-tdep.c: Sort headers.
9991         * amd64-darwin-tdep.c: Sort headers.
9992         * amd64-bsd-nat.c: Sort headers.
9993         * alpha-tdep.c: Sort headers.
9994         * alpha-obsd-tdep.c: Sort headers.
9995         * alpha-nbsd-tdep.c: Sort headers.
9996         * alpha-mdebug-tdep.c: Sort headers.
9997         * alpha-linux-tdep.c: Sort headers.
9998         * alpha-linux-nat.c: Sort headers.
9999         * alpha-bsd-tdep.c: Sort headers.
10000         * alpha-bsd-nat.c: Sort headers.
10001         * aix-thread.c: Sort headers.
10002         * agent.c: Sort headers.
10003         * addrmap.c: Sort headers.
10004         * ada-varobj.c: Sort headers.
10005         * ada-valprint.c: Sort headers.
10006         * ada-typeprint.c: Sort headers.
10007         * ada-tasks.c: Sort headers.
10008         * ada-lang.c: Sort headers.
10009         * aarch64-tdep.c: Sort headers.
10010         * aarch64-ravenscar-thread.c: Sort headers.
10011         * aarch64-newlib-tdep.c: Sort headers.
10012         * aarch64-linux-tdep.c: Sort headers.
10013         * aarch64-linux-nat.c: Sort headers.
10014         * aarch64-fbsd-tdep.c: Sort headers.
10015         * aarch64-fbsd-nat.c: Sort headers.
10016         * aarch32-linux-nat.c: Sort headers.
10017
10018 2019-04-04  Tom Tromey  <tom@tromey.com>
10019
10020         * varobj.c (varobj_create): Update.
10021         * rust-exp.y (struct rust_parser) <update_innermost_block,
10022         lookup_symbol>: New methods.
10023         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10024         Rename.
10025         (rust_parser::rust_lookup_type)
10026         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10027         * printcmd.c (display_command, do_one_display): Update.
10028         * parser-defs.h (struct parser_state) <parser_state>: Add
10029         "tracker" parameter.
10030         (block_tracker): New member.
10031         (class innermost_block_tracker) <innermost_block_tracker>: Add
10032         "types" parameter.
10033         <reset>: Remove method.
10034         (innermost_block): Don't declare.
10035         (null_post_parser): Update.
10036         * parse.c (innermost_block): Remove global.
10037         (write_dollar_variable): Update.
10038         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10039         Remove "tracker_types" parameter.
10040         (parse_expression): Add "tracker" parameter.
10041         (parse_expression_for_completion): Update.
10042         (null_post_parser): Add "tracker" parameter.
10043         * p-exp.y: Update rules.
10044         * m2-exp.y: Update rules.
10045         * language.h (struct language_defn) <la_post_parser>: Add
10046         "tracker" parameter.
10047         * go-exp.y: Update rules.
10048         * f-exp.y: Update rules.
10049         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10050         parameter.
10051         * d-exp.y: Update rules.
10052         * c-exp.y: Update rules.
10053         * breakpoint.c (set_breakpoint_condition): Create an
10054         innermost_block_tracker.
10055         (watch_command_1): Likewise.
10056         * ada-lang.c (resolve): Add "tracker" parameter.
10057         (resolve_subexp): Likewise.
10058         * ada-exp.y (write_var_from_sym): Update.
10059
10060 2019-04-04  Tom Tromey  <tom@tromey.com>
10061
10062         * type-stack.h: New file.
10063         * type-stack.c: New file.
10064         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10065         type-stack.h.
10066         (insert_into_type_stack, insert_type, push_type, push_type_int)
10067         (insert_type_address_space, pop_type, pop_type_int)
10068         (pop_typelist, pop_type_stack, append_type_stack)
10069         (push_type_stack, get_type_stack, push_typelist)
10070         (follow_type_instance_flags, follow_types): Don't declare.
10071         * parse.c (type_stack): Remove global.
10072         (parse_exp_in_context): Update.
10073         (insert_into_type_stack, insert_type, push_type, push_type_int)
10074         (insert_type_address_space, pop_type, pop_type_int)
10075         (pop_typelist, pop_type_stack, append_type_stack)
10076         (push_type_stack, get_type_stack, push_typelist)
10077         (follow_type_instance_flags, follow_types): Remove (moved to
10078         type-stack.c).
10079         * f-exp.y (type_stack): New global.
10080         Update rules.
10081         (push_kind_type, f_parse): Update.
10082         * d-exp.y (type_stack): New global.
10083         Update rules.
10084         (d_parse): Update.
10085         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10086         Update rules.
10087         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10088         (HFILES_NO_SRCDIR): Add type-stack.h.
10089
10090 2019-04-04  Tom Tromey  <tom@tromey.com>
10091
10092         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10093         (rust_parser::convert_ast_to_expression, rust_parse)
10094         (rust_lex_test_completion, rust_lex_tests): Update.
10095         * parser-defs.h (struct expr_completion_state): New.
10096         (struct parser_state) <parser_state>: Add completion parameter.
10097         <mark_struct_expression, mark_completion_tag>: New methods.
10098         <parse_completion, m_completion_state>: New members.
10099         (prefixify_expression, null_post_parser): Update.
10100         (mark_struct_expression, mark_completion_tag): Don't declare.
10101         * parse.c (parse_completion, expout_last_struct)
10102         (expout_tag_completion_type, expout_completion_name): Remove
10103         globals.
10104         (parser_state::mark_struct_expression)
10105         (parser_state::mark_completion_tag): Now methods.
10106         (prefixify_expression): Add last_struct parameter.
10107         (prefixify_subexp): Likewise.
10108         (parse_exp_1): Update.
10109         (parse_exp_in_context): Add cstate parameter.  Update.
10110         (parse_expression_for_completion): Create an
10111         expr_completion_state.
10112         (null_post_parser): Add "completion" parameter.
10113         * p-exp.y: Update rules.
10114         (yylex): Update.
10115         * language.h (struct language_defn) <la_post_parser>: Add
10116         "completing" parameter.
10117         * go-exp.y: Update rules.
10118         (lex_one_token): Update.
10119         * expression.h (parse_completion): Don't declare.
10120         * d-exp.y: Update rules.
10121         (lex_one_token): Update rules.
10122         * c-exp.y: Update rules.
10123         (lex_one_token): Update.
10124         * ada-lang.c (resolve): Add "parse_completion" parameter.
10125         (resolve_subexp): Likewise.
10126         (ada_resolve_function): Likewise.
10127
10128 2019-04-04  Tom Tromey  <tom@tromey.com>
10129
10130         * parser-defs.h (struct parser_state) <start_arglist,
10131         end_arglist>: New methods.
10132         <arglist_len, m_funcall_chain>: New members.
10133         (arglist_len, start_arglist, end_arglist): Don't declare.
10134         * parse.c (arglist_len, funcall_chain): Remove global.
10135         (start_arglist, end_arglist): Remove functions.
10136         (parse_exp_in_context): Update.
10137         * p-exp.y: Update rules.
10138         * m2-exp.y: Update rules.
10139         * go-exp.y: Update rules.
10140         * f-exp.y: Update rules.
10141         * d-exp.y: Update rules.
10142         * c-exp.y: Update rules.
10143
10144 2019-04-04  Tom Tromey  <tom@tromey.com>
10145
10146         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10147         lex_operator, push_back>: New methods.
10148         Update all rules.
10149         (rust_parser::lex_hex, lex_escape): Rename and update.
10150         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10151         (rust_parser::lex_operator): Rename and update.
10152         (rust_parser::lex_number, rustyylex, rustyyerror)
10153         (rust_lex_test_init, rust_lex_test_sequence)
10154         (rust_lex_test_push_back, rust_lex_tests): Update.
10155         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10156         parameter.
10157         <lexptr, prev_lexptr>: New members.
10158         (lexptr, prev_lexptr): Don't declare.
10159         * parse.c (lexptr, prev_lexptr): Remove globals.
10160         (parse_exp_in_context): Update.
10161         * p-exp.y (yylex, yyerror): Update.
10162         * m2-exp.y (parse_number, yylex, yyerror): Update.
10163         * go-exp.y (lex_one_token, yyerror): Update.
10164         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10165         * d-exp.y (lex_one_token, yyerror): Update.
10166         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10167         (lex_one_token, yyerror): Update.
10168         * ada-lex.l (YY_INPUT): Update.
10169         (rewind_to_char): Update.
10170         * ada-exp.y (yyerror): Update.
10171
10172 2019-04-04  Tom Tromey  <tom@tromey.com>
10173
10174         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10175         * parser-defs.h (struct parser_state) <parser_state>: Add new
10176         parameter.
10177         <comma_terminates>: New member.
10178         (comma_terminates): Don't declare global.
10179         * parse.c (comma_terminates): Remove global.
10180         (parse_exp_in_context): Update.
10181         * p-exp.y (yylex): Update.
10182         * m2-exp.y (yylex): Update.
10183         * go-exp.y (lex_one_token): Update.
10184         * f-exp.y (yylex): Update.
10185         * d-exp.y (lex_one_token): Update.
10186         * c-exp.y (lex_one_token): Update.
10187         * ada-lex.l: Update.
10188
10189 2019-04-04  Tom Tromey  <tom@tromey.com>
10190
10191         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10192         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10193         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10194         * parser-defs.h (paren_depth): Don't declare.
10195         * parse.c (paren_depth): Remove global.
10196         (parse_exp_in_context): Update.
10197         * p-exp.y (paren_depth): New global.
10198         (pascal_parse): Initialize it.
10199         * m2-exp.y (paren_depth): New global.
10200         (m2_parse): Initialize it.
10201         * go-exp.y (paren_depth): New global.
10202         (go_parse): Initialize it.
10203         * f-exp.y (paren_depth): New global.
10204         (f_parse): Initialize it.
10205         * d-exp.y (paren_depth): New global.
10206         (d_parse): Initialize it.
10207         * c-exp.y (paren_depth): New global.
10208         (c_parse): Initialize it.
10209         * ada-lex.l (paren_depth): New global.
10210         (lexer_init): Initialize it.
10211
10212 2019-04-04  Tom Tromey  <tom@tromey.com>
10213
10214         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10215         (rust_parser::convert_ast_to_type)
10216         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10217         * parser-defs.h (struct parser_state) <parser_state>: Add
10218         parameters.  Initialize new members.
10219         <expression_context_block, expression_context_pc>: New members.
10220         * parse.c (expression_context_block, expression_context_pc):
10221         Remove globals.
10222         (parse_exp_in_context): Update.
10223         * p-exp.y: Update all rules.
10224         (yylex): Update.
10225         * m2-exp.y: Update all rules.
10226         (yylex): Update.
10227         * go-exp.y (yylex): Update.
10228         * f-exp.y (yylex): Update.
10229         * d-exp.y: Update all rules.
10230         (yylex): Update.
10231         * c-exp.y: Update all rules.
10232         (lex_one_token, classify_name, yylex, c_parse): Update.
10233         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10234
10235 2019-04-04  Tom Tromey  <tom@tromey.com>
10236
10237         * gdbarch.h, gdbarch.c: Rebuild.
10238         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10239         * stap-probe.h:
10240         (struct stap_parse_info): Replace "parser_state" with
10241         "expr_builder".
10242         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10243         (parser_state): New class.
10244         * parse.c (expr_builder): Rename.
10245         (expr_builder::release): Rename.
10246         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10247         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10248         (write_exp_elt_longcst, write_exp_elt_floatcst)
10249         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10250         (write_exp_string_vector, write_exp_bitstring)
10251         (write_exp_msymbol, mark_struct_expression)
10252         (write_dollar_variable)
10253         (insert_type_address_space, increase_expout_size): Replace
10254         "parser_state" with "expr_builder".
10255         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10256         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10257         "parser_state" with "expr_builder".
10258
10259 2019-04-04  Tom Tromey  <tom@tromey.com>
10260
10261         * rust-exp.y: Replace "parse_language" with method call.
10262         * p-exp.y:
10263         (yylex): Replace "parse_language" with method call.
10264         * m2-exp.y:
10265         (yylex): Replace "parse_language" with method call.
10266         * go-exp.y (classify_name): Replace "parse_language" with method
10267         call.
10268         * f-exp.y (yylex): Replace "parse_language" with method call.
10269         * d-exp.y (lex_one_token): Replace "parse_language" with method
10270         call.
10271         * c-exp.y:
10272         (lex_one_token, classify_name, yylex): Replace "parse_language"
10273         with method call.
10274         * ada-exp.y (find_primitive_type, type_char)
10275         (type_system_address): Replace "parse_language" with method call.
10276
10277 2019-04-04  Tom Tromey  <tom@tromey.com>
10278
10279         * rust-exp.y: Replace "parse_gdbarch" with method call.
10280         * parse.c (write_dollar_variable, insert_type_address_space):
10281         Replace "parse_gdbarch" with method call.
10282         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10283         call.
10284         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10285         call.
10286         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10287         "parse_gdbarch" with method call.
10288         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10289         with method call.
10290         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10291         "parse_gdbarch" with method call.
10292         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10293         "parse_gdbarch" with method call.
10294         * c-exp.y (parse_type, parse_number, classify_name): Replace
10295         "parse_gdbarch" with method call.
10296         * ada-lex.l: Replace "parse_gdbarch" with method call.
10297         * ada-exp.y (parse_type, find_primitive_type, type_char)
10298         (type_system_address): Replace "parse_gdbarch" with method call.
10299
10300 2019-04-04  Tom Tromey  <tom@tromey.com>
10301
10302         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10303         * stap-probe.c (stap_parse_argument): Update.
10304         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10305         initial_size parameter.
10306         * rust-exp.y (rust_lex_tests): Update.
10307         * parse.c (parser_state): Update.
10308         (parse_exp_in_context): Update.
10309         * parser-defs.h (struct parser_state) <parser_state>: Remove
10310         "initial_size" parameter.
10311
10312 2019-04-04  Tom Tromey  <tom@tromey.com>
10313
10314         * parser-defs.h (increase_expout_size): Don't declare.
10315         * parse.c (increase_expout_size): Now static.
10316
10317 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10318
10319         * gnu-nat.c (gnu_nat_target::wait): Fix
10320         target_waitstatus_to_string call.
10321
10322 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10323
10324         * eval.c (evaluate_subexp_standard): Handle internal functions
10325         during Fortran function call handling.
10326
10327 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10328
10329         * NEWS: Mention new internal functions.
10330         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10331         (read_base_type): Use dwarf2_init_complex_target_type.
10332         * value.c (creal_internal_fn): New function.
10333         (cimag_internal_fn): New function.
10334         (_initialize_values): Register new internal functions.
10335
10336 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10337
10338         * infrun.c (stop_all_threads): If debug_infrun, always
10339         trace the wait status after wait_one, using
10340         target_waitstatus_to_string and target_pid_to_str.
10341         (handle_inferior_event): Replace various trace of
10342         wait status kind by a single trace.
10343         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10344         wait status kind image by target_waitstatus_to_string.
10345         * target/waitstatus.c (target_waitstatus_to_string): Fix
10346         obsolete comment.
10347
10348 2019-04-01  Tom Tromey  <tromey@adacore.com>
10349
10350         PR symtab/23331:
10351         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10352
10353 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10354             Pedro Alves  <palves@redhat.com>
10355
10356         * top.c (quit_force): Call 'finalize_values'.
10357         * value.c (finalize_values): New function.
10358         * value.h (finalize_values): Declare.
10359
10360 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10361
10362         * NEWS: Announce $_gdb_major and $_gdb_minor.
10363
10364         * top.c (init_gdb_version_vars): New function.
10365         (gdb_init): Call init_gdb_version_vars.
10366
10367 2019-03-29  Tom Tromey  <tromey@adacore.com>
10368
10369         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10370         help text.  Remove dead code.
10371
10372 2019-03-29  Keith Seitz  <keiths@redhat.com>
10373
10374         From Siddhesh Poyarekar:
10375         * f-lang.h (f77_get_upperbound): Return LONGEST.
10376         (f77_get_lowerbound): Likewise.
10377         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10378         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10379         print them.
10380         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10381         plongest to format print it.
10382         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10383         (f77_get_upperbound): Likewise.
10384         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10385         LOWER_BOUND to LONGEST.
10386         (f77_create_arrayprint_offset_tbl): Likewise.
10387
10388 2019-03-29  Keith Seitz  <keiths@redhat.com>
10389
10390         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10391         %s/pulongest for TYPE_LENGTH instead of %d in format
10392         strings.
10393         * ada-typerint.c (ada_print_type): Likewise.
10394         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10395         * compile/compile-c-support.c (generate_register_struct): Likewise.
10396         * gdbtypes.c (recursive_dump_type): Likewise.
10397         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10398         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10399         instead of %d in format strings.
10400         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10401         to std::min to ULONGEST.
10402         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10403         instead of %d in format strings.
10404         * tracepoint.c (info_scope_command): Likewise.
10405         * typeprint.c (print_offset_data::update)
10406         (print_offset_data::finish): Likewise.
10407         * xtensa-tdep.c (xtensa_store_return_value)
10408         (xtensa_push_dummy_call): Likewise.
10409
10410 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10411
10412         * windows-nat.c (display_selector): Fixed format specifications
10413         for 64-bit Cygwin.
10414
10415 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10416
10417         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10418
10419 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10420
10421         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10422         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10423         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10424         (nios2_linux_init_abi): Install it.
10425
10426 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10427
10428         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10429
10430 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10431
10432         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10433
10434 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10435             Tom Tromey  <tromey@adacore.com>
10436
10437         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10438
10439 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10440
10441         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10442         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10443         method to compute the bounds of range types. Also print "[evaluated]"
10444         if the bounds' values come from a dynamic evaluation.
10445
10446 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10449         whitespace when pretty printing is on.
10450
10451 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10452
10453         * ppc-linux-nat.c: Add include.
10454
10455 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10456
10457         * NEWS: Mention AArch64 Pointer Authentication.
10458
10459 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10460
10461         * arm-linux-nat.c: Add include.
10462
10463 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10464
10465         * source-cache.c (source_cache::get_source_lines): Re-read
10466         fullname after calling open_source_file.
10467
10468 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10469
10470         * NEWS: Mention TLS support for FreeBSD.
10471
10472 2019-03-25  Tom Tromey  <tromey@adacore.com>
10473
10474         * minsyms.c (BUNCH_SIZE): Update comment.
10475         (~minimal_symbol_reader): Remove old comment.
10476         (compact_minimal_symbols): Update comment.
10477         (minimal_symbol_reader::install): Remove old comment.  Update
10478         other comments.
10479
10480 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10481
10482         * s390-linux-nat.c: Add include.
10483
10484 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10485
10486         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10487         Call linux_get_hwcap.
10488         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10489         Likewise.
10490         (aarch64_linux_get_hwcap): Remove function.
10491         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10492         declaration.
10493         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10494         linux_get_hwcap.
10495         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10496         * linux-tdep.c (linux_get_hwcap): Add function.
10497         (linux_get_hwcap2): Likewise.
10498         * linux-tdep.h (linux_get_hwcap): Add declaration.
10499         (linux_get_hwcap2): Likewise.
10500         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10501         (ppc_linux_get_hwcap2): Likewise.
10502         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10503         linux_get_hwcap.
10504         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10505         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10506         (ppc_linux_nat_target::read_description): Likewise.
10507         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10508         * s390-linux-nat.c: Likewise.
10509         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10510
10511 2019-03-24  Tom Tromey  <tom@tromey.com>
10512
10513         * ada-lang.c (standard_lookup): Simplify initialization.
10514         (ada_lookup_symbol_nonlocal): Simplify return.
10515         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10516         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10517         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10518         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10519         initialization.
10520         * solib.c (solib_global_lookup): Simplify.
10521         * symtab.c (null_block_symbol): Remove.
10522         (symbol_cache_lookup): Simplify returns.
10523         (lookup_language_this): Simplify returns.
10524         (lookup_symbol_aux): Simplify return.
10525         (lookup_local_symbol): Simplify returns.
10526         (lookup_global_symbol_from_objfile): Simplify return.
10527         (lookup_symbol_in_objfile_symtabs)
10528         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10529         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10530         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10531         * cp-namespace.c (cp_lookup_bare_symbol)
10532         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10533         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10534         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10535         (cp_lookup_symbol_via_imports): Simplify initialization.
10536         (find_symbol_in_baseclass): Likewise.
10537         * symtab.h (null_block_symbol): Remove.
10538         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10539         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10540         (d_lookup_symbol_module): Likewise.
10541         (find_symbol_in_baseclass): Simplify initialization.
10542
10543 2019-03-24  Tom Tromey  <tom@tromey.com>
10544
10545         * expression.h: Don't include symtab.h.
10546         (struct block): Forward declare.
10547
10548 2019-03-24  Tom Tromey  <tom@tromey.com>
10549
10550         * c-exp.y (typebase): Remove casts.
10551         * gdbtypes.c (lookup_unsigned_typename, )
10552         (lookup_signed_typename): Remove cast.
10553         * eval.c (parse_to_comma_and_eval): Remove cast.
10554         * parse.c (write_dollar_variable): Remove cast.
10555         * block.h (struct block) <superblock>: Now const.
10556         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10557         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10558         (map_block): Make "block" const.
10559         * symfile.h (struct quick_symbol_functions)
10560         <map_matching_symbols>: Constify block argument to "callback".
10561         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10562         const.
10563         (find_pc_sect_compunit_symtab): Make "b" const.
10564         (find_symbol_at_address): Likewise.
10565         (search_symbols): Likewise.
10566         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10567         (dw2_debug_names_lookup_symbol): Likewise.
10568         (dw2_map_matching_symbols): Update.
10569         * p-valprint.c (pascal_val_print): Remove "block".
10570         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10571         (aux_add_nonlocal_symbols): Make "block" const.
10572         (resolve_subexp): Remove cast.
10573         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10574         const.
10575         (iterate_over_file_blocks): Likewise.
10576         * f-exp.y (%union) <bval>: Remove.
10577         * coffread.c (patch_opaque_types): Make "b" const.
10578         * spu-tdep.c (spu_catch_start): Make "block" const.
10579         * c-valprint.c (print_unpacked_pointer): Remove "block".
10580         * symmisc.c (dump_symtab_1): Make "b" const.
10581         (block_depth): Make "block" const.
10582         * d-exp.y (%union) <bval>: Remove.
10583         * cp-support.h (cp_lookup_rtti_type): Update.
10584         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10585         * psymtab.c (psym_lookup_symbol): Make "block" const.
10586         (maintenance_check_psymtabs): Make "b" const.
10587         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10588         (enumerate_locals, enumerate_args): Update.
10589         * python/py-symtab.c (stpy_global_block): Make "block" const.
10590         (stpy_static_block): Likewise.
10591         * inline-frame.c (block_starting_point_at): Make "new_block"
10592         const.
10593         * block.c (find_block_in_blockvector): Make return type const.
10594         (blockvector_for_pc_sect): Make "b" const.
10595         (find_block_in_blockvector): Make "b" const.
10596
10597 2019-03-23  Tom Tromey  <tom@tromey.com>
10598
10599         * varobj.c (varobj_create): Update.
10600         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10601         * printcmd.c (display_command, do_one_display): Don't reset
10602         innermost_block.
10603         * parser-defs.h (enum innermost_block_tracker_type): Move to
10604         expression.h.
10605         (innermost_block): Update comment.
10606         * parse.c (parse_exp_1): Add tracker_types parameter.
10607         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10608         tracker_types parameter.  Reset innermost_block.
10609         (parse_exp_in_context): Remove.
10610         (parse_expression_for_completion): Update.
10611         * objfiles.c (~objfile): Don't reset expression_context_block or
10612         innermost_block.
10613         * expression.h (enum innermost_block_tracker_type): Move from
10614         parser-defs.h.
10615         (parse_exp_1): Add tracker_types parameter.
10616         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10617         reset innermost_block.
10618
10619 2019-03-23  Tom Tromey  <tom@tromey.com>
10620
10621         * objfiles.h: Include bcache.h.
10622
10623 2019-03-23  Tom Tromey  <tom@tromey.com>
10624
10625         * linespec.c (get_current_search_block): Use
10626         scoped_restore_current_language.
10627         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10628
10629 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10630             Jiong Wang  <jiong.wang@arm.com>
10631
10632         * aarch64-linux-tdep.c
10633         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10634         section.
10635         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10636
10637 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10638             Jiong Wang  <jiong.wang@arm.com>
10639
10640         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10641         instructions.
10642         (aarch64_analyze_prologue_test): Add PACIASP test.
10643         (aarch64_prologue_prev_register): Unmask PC value.
10644
10645 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10646             Jiong Wang  <jiong.wang@arm.com>
10647
10648         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10649         (aarch64_dwarf2_prev_register): Unmask PC value.
10650         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10651         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10652         DW_CFA_AARCH64_negate_ra_state.
10653         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10654
10655 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10656             Jiong Wang  <jiong.wang@arm.com>
10657
10658         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10659         registers.
10660         (aarch64_pseudo_register_name): Likewise.
10661         (aarch64_pseudo_register_type): Likewise.
10662         (aarch64_pseudo_register_reggroup_p): Likewise.
10663         (aarch64_gdbarch_init): Add pauth registers.
10664         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10665         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10666         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10667         (struct gdbarch_tdep): Add regnum for ra_state.
10668
10669 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10670             Jiong Wang  <jiong.wang@arm.com>
10671
10672         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10673
10674 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10675             Jiong Wang  <jiong.wang@arm.com>
10676
10677         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10678         function.
10679         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10680         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10681         (aarch64_gdbarch_init): Add puth registers.
10682         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10683         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10684         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10685
10686 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10687             Jiong Wang  <jiong.wang@arm.com>
10688
10689         * aarch64-linux-nat.c
10690         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10691         * aarch64-linux-tdep.c
10692         (aarch64_linux_core_read_description): Likewise.
10693         (aarch64_linux_get_hwcap): New function.
10694         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10695         (aarch64_linux_get_hwcap): New declaration.
10696
10697 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10698             Jiong Wang  <jiong.wang@arm.com>
10699
10700         * aarch64-linux-nat.c
10701         (aarch64_linux_nat_target::read_description): Add pauth param.
10702         * aarch64-linux-tdep.c
10703         (aarch64_linux_core_read_description): Likewise.
10704         * aarch64-tdep.c (struct target_desc): Add in pauth.
10705         (aarch64_read_description): Add pauth param.
10706         (aarch64_gdbarch_init): Likewise.
10707         * aarch64-tdep.h (aarch64_read_description): Likewise.
10708         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10709         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10710         * features/Makefile: Add new files.
10711         * features/aarch64-pauth.c: New file.
10712         * features/aarch64-pauth.xml: New file.
10713
10714 2019-03-20  Tom Tromey  <tromey@adacore.com>
10715
10716         * infrun.c (handle_inferior_event): Rename from
10717         handle_inferior_event_1.  Create a scoped_value_mark.
10718         (handle_inferior_event): Remove.
10719
10720 2019-03-19  Tom Tromey  <tromey@adacore.com>
10721
10722         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10723         * infrun.h (print_stop_event): Add "displays" parameter.
10724         * infrun.c (print_stop_event): Add "displays" parameter.
10725
10726 2019-03-19  Pedro Alves  <palves@redhat.com>
10727
10728         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10729         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10730         to -1.  Fix TABs vs spaces.
10731         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10732         * tui/tui-out.h (tui_ui_out) Add intro comments.
10733         <m_line, m_start_of_line>: In-class initialize, and add describing
10734         comment.
10735
10736 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10737
10738         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10739         variable names.
10740         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10741
10742 2019-03-18  Pedro Alves  <palves@redhat.com>
10743             Eli Zaretskii <eliz@gnu.org>
10744
10745         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10746         m_line and m_start_of_line.
10747
10748 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10749
10750         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10751         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10752         it returns a newline.  This fixes a regression in TU mode, whereby
10753         the next line is output on the same screen line as the user input.
10754
10755 2019-03-18  Tom Tromey  <tromey@adacore.com>
10756
10757         * minsyms.c (minimal_symbol_reader::install): Remove call to
10758         obstack_blank.
10759
10760 2019-03-18  Pedro Alves  <palves@redhat.com>
10761
10762         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10763         New globals.
10764         (apply_style): New, factored out from ...
10765         (apply_ansi_escape): ... this.  Handle reverse video mode.
10766         (tui_set_reverse_mode): New function.
10767         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10768         * tui/tui-winsource.c (tui_show_source_line): Use
10769         tui_set_reverse_mode instead of setting A_STANDOUT.
10770         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10771         New setter methods.
10772
10773 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10774
10775         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10776         Handle tabs.
10777
10778 2019-03-18  Tom Tromey  <tromey@adacore.com>
10779
10780         * ada-lang.c (empty_array): Add "high" parameter.
10781         (ada_evaluate_subexp): Update.
10782
10783 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10784
10785         * unittests/string_view-selftests.c: Define
10786         _initialize_string_view_selftests unconditionally.
10787
10788 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10789
10790         PR gdb/24350
10791         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10792
10793 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10794
10795         PR gdb/24351
10796         * windows-nat.c (display_selector): Fix format specifiers.
10797
10798 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10799
10800         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10801         tui_refill_source_window instead of tui_refresh_win, to update the
10802         current execution line.  This fixes redisplay of the current line
10803         when stepping through the code with "next" or "step".
10804
10805 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10806
10807         * source-cache.c (source_cache::get_source_lines): Call
10808         find_source_lines to initialize s->nlines.  This fixes vertical
10809         scrolling of TUI source window when the DOWN arrow is pressed.
10810
10811 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10812
10813         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10814         linux-thread-db.c (_initialize_thread_db): Likewise.
10815
10816 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10817
10818         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10819         wclrtoeol in tui_show_source_line".  This reverts changes made in
10820         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10821
10822 2019-03-15  Tom Tromey  <tom@tromey.com>
10823
10824         * symtab.h (struct minimal_symbol): Derive from
10825         general_symbol_info.
10826         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10827         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10828         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10829         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10830         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10831         (MSYMBOL_SEARCH_NAME): Update.
10832         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10833         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10834         * minsyms.c (minimal_symbol_reader::record_full): Update.
10835
10836 2019-03-15  Tom Tromey  <tom@tromey.com>
10837
10838         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10839
10840 2019-03-15  Tom Tromey  <tom@tromey.com>
10841
10842         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10843         unique_xmalloc_ptr.
10844         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10845         Update.
10846         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10847         (build_minimal_symbol_hash_tables)
10848         (minimal_symbol_reader::install): Update.
10849
10850 2019-03-15  Tom Tromey  <tom@tromey.com>
10851
10852         * symtab.c (create_demangled_names_hash): Update.
10853         (symbol_set_names): Update.
10854         * objfiles.h (struct objfile_per_bfd_storage)
10855         <demangled_names_hash>: Now an htab_up.
10856         * objfiles.c (objfile_per_bfd_storage): Simplify.
10857
10858 2019-03-15  Tom Tromey  <tom@tromey.com>
10859
10860         * objfiles.h (struct objfile_per_bfd_storage): Declare
10861         destructor.
10862         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10863         New.
10864         (get_objfile_bfd_data): Use new.  Don't initialize
10865         language_of_main.
10866         (free_objfile_per_bfd_storage): Remove.
10867         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10868
10869 2019-03-15  Tom Tromey  <tom@tromey.com>
10870
10871         * symfile.c (reread_symbols): Update.
10872         * objfiles.c (objfile::objfile): Update.
10873         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10874         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10875         comment.
10876         (minimal_symbol_reader::install): Update.
10877         (terminate_minimal_symbol_table): Remove.
10878         * jit.c (jit_object_close_impl): Update.
10879
10880 2019-03-15  Tom Tromey  <tom@tromey.com>
10881
10882         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10883         initializations.
10884
10885 2019-03-15  Tom Tromey  <tom@tromey.com>
10886
10887         * objfiles.h (struct objfile_per_bfd_storage)
10888         <demangled_hash_languages>: Now a bitset.
10889         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10890         (lookup_minimal_symbol): Update.
10891
10892 2019-03-15  Tom Tromey  <tom@tromey.com>
10893
10894         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10895         Don't return the symbol.
10896         * coffread.c (record_minimal_symbol): Use record_full.
10897
10898 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10899
10900         The MS-Windows port of ncurses fails to switch to a color pair if
10901         one or both of the colors are the implicit default colors.  This
10902         change records the default colors when TUI is initialized, and
10903         then specifies them explicitly when a color pair uses the default
10904         colors.  This allows color styling in TUI mode on MS-Windows.
10905
10906         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10907         ncurses_norm_attr.
10908         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10909         colors in ncurses_norm_attr.
10910         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10911         "none", replace it with the default color recorded in
10912         ncurses_norm_attr.
10913
10914 2019-03-14  Tom Tromey  <tromey@adacore.com>
10915
10916         * source-cache.h (class source_cache) <get_source_lines>: Return
10917         std::string.
10918         * source-cache.c (source_cache::extract_lines): Handle case where
10919         first_pos==npos.  Return std::string.
10920         (source_cache::get_source_lines): Update.
10921
10922 2019-03-14  Tom Tromey  <tromey@adacore.com>
10923
10924         * NEWS: Add item for "style sources" commands.
10925         * source-cache.c (source_cache::get_source_lines): Check
10926         source_styling.
10927         * cli/cli-style.c (source_styling): New global.
10928         (_initialize_cli_style): Add "style sources" commands.
10929         (show_style_sources): New function.
10930         * cli/cli-style.h (source_styling): Declare.
10931
10932 2019-03-14  Pedro Alves  <palves@redhat.com>
10933             Tom Tromey  <tromey@adacore.com>
10934
10935         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10936         * tui/tui-winsource.c (tui_refill_source_window): New function,
10937         from...
10938         (tui_horizontal_source_scroll): ... here.  Move some logic.
10939         * cli/cli-style.c (set_style_enabled): Notify new observable.
10940         * tui/tui-hooks.c (tui_redisplay_source): New function.
10941         (tui_attach_detach_observers): Attach or detach
10942         tui_redisplay_source.
10943         * observable.h (source_styling_changed): New observable.
10944         * observable.c: Define source_styling_changed observable.
10945
10946 2019-03-13  Tom Tromey  <tromey@adacore.com>
10947
10948         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10949         (i386_gnu_nat_target::store_registers): Update.
10950         * target-debug.h (target_debug_print_std_string): New macro.
10951         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10952         * windows-tdep.c (display_one_tib): Update.
10953         * tui/tui-stack.c (tui_make_status_line): Update.
10954         * top.c (print_inferior_quit_action): Update.
10955         * thread.c (thr_try_catch_cmd): Update.
10956         (add_thread_with_info): Update.
10957         (thread_target_id_str): Update.
10958         (thr_try_catch_cmd): Update.
10959         (thread_command): Update.
10960         (thread_find_command): Update.
10961         * record-btrace.c (record_btrace_target::info_record)
10962         (record_btrace_resume_thread, record_btrace_target::resume)
10963         (record_btrace_cancel_resume, record_btrace_step_thread)
10964         (record_btrace_target::wait, record_btrace_target::wait)
10965         (record_btrace_target::wait, record_btrace_target::stop): Update.
10966         * progspace.c (print_program_space): Update.
10967         * process-stratum-target.c
10968         (process_stratum_target::thread_address_space): Update.
10969         * linux-fork.c (linux_fork_mourn_inferior)
10970         (detach_checkpoint_command, info_checkpoints_command)
10971         (linux_fork_context): Update.
10972         (linux_fork_detach): Update.
10973         (class scoped_switch_fork_info): Update.
10974         (delete_checkpoint_command): Update.
10975         * infrun.c (follow_fork_inferior): Update.
10976         (follow_fork_inferior): Update.
10977         (proceed_after_vfork_done): Update.
10978         (handle_vfork_child_exec_or_exit): Update.
10979         (follow_exec): Update.
10980         (displaced_step_prepare_throw): Update.
10981         (displaced_step_restore): Update.
10982         (start_step_over): Update.
10983         (resume_1): Update.
10984         (clear_proceed_status_thread): Update.
10985         (proceed): Update.
10986         (print_target_wait_results): Update.
10987         (do_target_wait): Update.
10988         (context_switch): Update.
10989         (stop_all_threads): Update.
10990         (restart_threads): Update.
10991         (finish_step_over): Update.
10992         (handle_signal_stop): Update.
10993         (switch_back_to_stepped_thread): Update.
10994         (keep_going_pass_signal): Update.
10995         (print_exited_reason): Update.
10996         (normal_stop): Update.
10997         * inferior.c (inferior_pid_to_str): Change return type.
10998         (print_selected_inferior): Update.
10999         (add_inferior): Update.
11000         (detach_inferior): Update.
11001         * dummy-frame.c (fprint_dummy_frames): Update.
11002         * dcache.c (dcache_info_1): Update.
11003         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11004         (btrace_fetch, btrace_clear): Update.
11005         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11006         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11007         type.
11008         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11009         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11010         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11011         * gdbarch.c, gdbarch.h: Rebuild.
11012         * gdbarch.sh (core_pid_to_str): Change return type.
11013         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11014         return type.
11015         (windows_nat_target::pid_to_str): Change return type.
11016         (windows_delete_thread): Update.
11017         (windows_nat_target::attach): Update.
11018         (windows_nat_target::files_info): Update.
11019         * target-delegates.c: Rebuild.
11020         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11021         return type.
11022         (sol_thread_target::pid_to_str): Change return type.
11023         * remote.c (class remote_target) <pid_to_str>: Change return
11024         type.
11025         (remote_target::pid_to_str): Change return type.
11026         (extended_remote_target::attach, remote_target::remote_stop_ns)
11027         (remote_target::remote_notif_remove_queued_reply)
11028         (remote_target::push_stop_reply, remote_target::disable_btrace):
11029         Update.
11030         (extended_remote_target::attach): Update.
11031         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11032         type.
11033         (gdbsim_target::pid_to_str): Change return type.
11034         * ravenscar-thread.c (struct ravenscar_thread_target)
11035         <pid_to_str>: Change return type.
11036         (ravenscar_thread_target::pid_to_str): Change return type.
11037         * procfs.c (class procfs_target) <pid_to_str>: Change return
11038         type.
11039         (procfs_target::pid_to_str): Change return type.
11040         (procfs_target::attach): Update.
11041         (procfs_target::detach): Update.
11042         (procfs_target::fetch_registers): Update.
11043         (procfs_target::store_registers): Update.
11044         (procfs_target::wait): Update.
11045         (procfs_target::files_info): Update.
11046         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11047         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11048         return type.
11049         (nto_procfs_target::pid_to_str): Change return type.
11050         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11051         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11052         return type.
11053         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11054         (exit_lwp): Update.
11055         (attach_proc_task_lwp_callback, get_detach_signal)
11056         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11057         (linux_nat_target::resume, wait_lwp, stop_callback)
11058         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11059         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11060         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11061         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11062         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11063         type.
11064         (inf_ptrace_target::attach): Update.
11065         (inf_ptrace_target::files_info): Update.
11066         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11067         type.
11068         (go32_nat_target::pid_to_str): Change return type.
11069         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11070         (gnu_nat_target::wait): Update.
11071         (gnu_nat_target::wait): Update.
11072         (gnu_nat_target::resume): Update.
11073         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11074         (fbsd_nat_target::wait): Update.
11075         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11076         type.
11077         (darwin_nat_target::attach): Update.
11078         * corelow.c (class core_target) <pid_to_str>: Change return type.
11079         (core_target::pid_to_str): Change return type.
11080         * target.c (normal_pid_to_str): Change return type.
11081         (default_pid_to_str): Likewise.
11082         (target_pid_to_str): Change return type.
11083         (target_translate_tls_address): Update.
11084         (target_announce_detach): Update.
11085         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11086         return type.
11087         (bsd_uthread_target::pid_to_str): Change return type.
11088         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11089         type.
11090         (bsd_kvm_target::pid_to_str): Change return type.
11091         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11092         return type.
11093         (aix_thread_target::pid_to_str): Change return type.
11094         * target.h (struct target_ops) <pid_to_str>: Change return type.
11095         (target_pid_to_str, normal_pid_to_str): Likewise.
11096         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11097         type.
11098         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11099         type.
11100         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11101         return type.
11102         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11103         type.
11104         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11105         type.
11106         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11107         return type.
11108
11109 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11110
11111         * NEWS: Mention that the new default MI version is 3.  Mention
11112         changes to the output of commands and events that deal with
11113         multi-location breakpoints.
11114         * breakpoint.c: Include "mi/mi-out.h".
11115         (print_one_breakpoint): Change output syntax if using MI version
11116         >= 3.
11117         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11118         New.
11119         (mi_multi_location_breakpoint_output_fixed): New.
11120         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11121         (mi_cmd_fix_multi_location_breakpoint_output): New.
11122         (mi_multi_location_breakpoint_output_fixed): New.
11123         * mi/mi-cmds.c (mi_cmds): Register command
11124         -fix-multi-location-breakpoint-output.
11125         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11126         interpreter "mi".
11127
11128 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11129
11130         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11131         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11132         instantiate mi_ui_out based on interpreter name.
11133         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11134         * mi/mi-main.c (mi_load_progress): Likewise.
11135
11136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11137
11138         * NEWS: Combine separate "New targets" sections for 8.3.
11139
11140 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11141
11142         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11143         (ppcfbsd_init_abi): Install gdbarch
11144         "fetch_tls_load_module_address" and "get_thread_local_address"
11145         methods.
11146
11147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11148
11149         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11150         (riscv_fbsd_init_abi): Install gdbarch
11151         "fetch_tls_load_module_address" and "get_thread_local_address"
11152         methods.
11153
11154 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11155
11156         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11157         (i386fbsd_init_abi): Install gdbarch
11158         "fetch_tls_load_module_address" and "get_thread_local_address"
11159         methods.
11160
11161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11162
11163         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11164         (amd64fbsd_init_abi): Install gdbarch
11165         "fetch_tls_load_module_address" and "get_thread_local_address"
11166         methods.
11167
11168 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11169
11170         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11171         (struct fbsd_pspace_data): New type.
11172         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11173         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11174         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11175         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11176         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11177
11178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11179
11180         * gdbtypes.c (lookup_struct_elt): New function.
11181         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11182         * gdbtypes.h (struct struct_elt): New type.
11183         (lookup_struct_elt): New prototype.
11184
11185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11186
11187         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11188         remove disabled code block.
11189
11190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11191
11192         * gdbarch.sh (get_thread_local_address): New method.
11193         * gdbarch.h, gdbarch.c: Regenerate.
11194         * target.c (target_translate_tls_address): Use
11195         gdbarch_get_thread_local_address if present instead of
11196         target::get_thread_local_address.
11197
11198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11199
11200         * target.h (target::get_thread_local_address): Update comment.
11201
11202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11203
11204         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11205         objfile->separate_debug_objfile_backlink if not NULL.
11206
11207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11208
11209         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11210         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11211         (amd64bsd_store_inferior_registers): Likewise.
11212         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11213         Enable segment base registers.
11214         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11215         PT_GETFSBASE and PT_GETGSBASE.
11216         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11217         PT_SETGSBASE.
11218         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11219         segment base registers.
11220         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11221
11222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11223
11224         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11225         Update calls to i386_target_description to add 'segments'
11226         parameter.
11227         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11228         add segment base registers.
11229         * arch/i386.c (i386_create_target_description): Add 'segments'
11230         parameter to enable segment base registers.
11231         * arch/i386.h (i386_create_target_description): Likewise.
11232         * features/i386/32bit-segments.xml: New file.
11233         * features/i386/32bit-segments.c: Generate.
11234         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11235         call to i386_target_description to add 'segments' parameter.
11236         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11237         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11238         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11239         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11240         if feature is present.
11241         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11242         Add 'segments' parameter to call to i386_target_description.
11243         (i386_target_description): Add 'segments' parameter to enable
11244         segment base registers.
11245         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11246         to call to i386_target_description.
11247         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11248         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11249         Define I386_NUM_REGS.
11250         (i386_target_description): Add 'segments' parameter to enable
11251         segment base registers.
11252
11253 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11254
11255         PR/24325
11256         * source-cache.c: #undef open and close, to avoid unresolved
11257         externals during linking.
11258
11259 2019-03-12  Tom Tromey  <tromey@adacore.com>
11260
11261         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11262         const.  Add initializers.
11263         (_initialize_remote): Don't initialize ptid globals.
11264
11265 2019-03-12  Pedro Alves  <palves@redhat.com>
11266
11267         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11268
11269 2019-03-12  Pedro Alves  <palves@redhat.com>
11270
11271         * cp-name-parser.y (main): Remove unused 'len' variable.
11272
11273 2019-03-12  Tom Tromey  <tromey@adacore.com>
11274
11275         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11276         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11277
11278 2019-03-12  Tom Tromey  <tromey@adacore.com>
11279
11280         * linux-nat.c (iterate_over_lwps): Update.
11281         (stop_callback): Remove parameter.
11282         (stop_wait_callback, detach_callback, resume_set_callback)
11283         (select_singlestep_lwp_callback, set_ignore_sigint)
11284         (status_callback, resumed_callback, resume_clear_callback)
11285         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11286         data parameter.
11287         (linux_nat_target::detach, linux_nat_target::resume)
11288         (linux_stop_and_wait_all_lwps, select_event_lwp)
11289         (linux_nat_filter_event, linux_nat_wait_1)
11290         (linux_nat_target::kill, linux_nat_target::stop)
11291         (linux_nat_target::stop): Update.
11292         (linux_nat_resume_callback): Change type.
11293         (resume_stopped_resumed_lwps, count_events_callback)
11294         (select_event_lwp_callback): Likewise.
11295         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11296         * arm-linux-nat.c (struct update_registers_data): Remove.
11297         (update_registers_callback): Change type.
11298         (arm_linux_insert_hw_breakpoint1): Update.
11299         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11300         parameter.
11301         (x86_linux_dr_set_addr): Update.
11302         (x86_linux_dr_set_control): Update.
11303         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11304         (iterate_over_lwps): Use gdb::function_view.
11305         * nat/aarch64-linux-hw-point.c (struct
11306         aarch64_dr_update_callback_param): Remove.
11307         (debug_reg_change_callback): Change type.
11308         (aarch64_notify_debug_reg_change): Update.
11309         * s390-linux-nat.c (s390_refresh_per_info): Update.
11310
11311 2019-03-11  Tom Tromey  <tromey@adacore.com>
11312
11313         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11314         redundant assignment to "this_cu".
11315
11316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11317
11318         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11319
11320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11321
11322         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11323         from...
11324         (rank_one_type): ... this.
11325
11326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11327
11328         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11329         from...
11330         (rank_one_type): ... this.
11331
11332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11333
11334         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11335         from...
11336         (rank_one_type): ... this.
11337
11338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11339
11340         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11341         from...
11342         (rank_one_type): ... this.
11343
11344 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11345
11346         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11347         from...
11348         (rank_one_type): ... this.
11349
11350 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11351
11352         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11353         from...
11354         (rank_one_type): ... this.
11355
11356 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11357
11358         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11359         from...
11360         (rank_one_type): ... this.
11361
11362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11363
11364         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11365         from...
11366         (rank_one_type): ... this.
11367
11368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11369
11370         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11371         from...
11372         (rank_one_type): ... this.
11373
11374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11375
11376         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11377         from...
11378         (rank_one_type): ... this.
11379
11380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11381
11382         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11383         from...
11384         (rank_one_type): ... this.
11385
11386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11387
11388         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11389         from...
11390         (rank_one_type): ... this.
11391
11392 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11393
11394         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11395         inferior-events' shows the example events.
11396
11397 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11398
11399         Support styling on native MS-Windows console
11400
11401         PR/24315
11402         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11403         on MS-Windows if $TERM is not defined.
11404
11405         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11406
11407         * posix-hdep.c (gdb_console_fputs):
11408         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11409         functions.
11410         * ui-file.h (gdb_console_fputs): Add prototype.
11411
11412         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11413         back to fputs only if the former returns zero.
11414
11415 2019-03-07  Tom Tromey  <tom@tromey.com>
11416
11417         * symmisc.c (print_symbol_bcache_statistics): Update.
11418         (print_objfile_statistics): Update.
11419         * symfile.c (allocate_symtab): Update.
11420         * stabsread.c: Don't include bcache.h.
11421         * psymtab.h (struct psymbol_bcache): Don't declare.
11422         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11423         (psymbol_bcache_init, psymbol_bcache_free)
11424         (psymbol_bcache_get_bcache): Don't declare.
11425         * psymtab.c (struct psymbol_bcache): Remove.
11426         (psymtab_storage::psymtab_storage): Update.
11427         (psymtab_storage::~psymtab_storage): Update.
11428         (psymbol_bcache_init, psymbol_bcache_free)
11429         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11430         (add_psymbol_to_bcache): Update.
11431         (allocate_psymtab): Update.
11432         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11433         macro_cache>: No longer pointers.
11434         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11435         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11436         * macrotab.c (macro_bcache): Update.
11437         * macroexp.c: Don't include bcache.h.
11438         * gdbtypes.c (check_types_worklist): Update.
11439         (types_deeply_equal): Remove TRY/CATCH.  Update.
11440         * elfread.c (elf_symtab_read): Update.
11441         * dwarf2read.c: Don't include bcache.h.
11442         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11443         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11444         (print_bcache_statistics, bcache_memory_used): Don't declare.
11445         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11446         methods.  Rename all data members.
11447         * bcache.c (struct bcache): Move to bcache.h.
11448         (bcache::expand_hash_table): Rename from expand_hash_table.
11449         (bcache): Remove.
11450         (bcache::insert): Rename from bcache_full.
11451         (bcache::compare): Rename from bcache_compare.
11452         (bcache_xmalloc): Remove.
11453         (bcache::~bcache): Rename from bcache_xfree.
11454         (bcache::print_statistics): Rename from print_bcache_statistics.
11455         (bcache::memory_used): Rename from bcache_memory_used.
11456
11457 2019-03-07  Pedro Alves  <palves@redhat.com>
11458
11459         * infrun.c (normal_stop): Also check for
11460         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11461
11462 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11463
11464         * f-lang.c (value_from_host_double): Moved to...
11465         * value.c (value_from_host_double): ...here.
11466         * value.h (value_from_host_double): Declare.
11467         * guile/scm-math.c (vlscm_convert_typed_number): Use
11468         value_from_host_double.
11469         (vlscm_convert_number): Likewise.
11470         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11471         * python/py-value.c (convert_value_from_python): Likewise.
11472
11473 2019-03-06  Tom Tromey  <tom@tromey.com>
11474
11475         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11476
11477 2019-03-06  Tom Tromey  <tom@tromey.com>
11478
11479         * utils.h (free_current_contents): Don't declare.
11480         * utils.c (free_current_contents): Remove.
11481
11482 2019-03-06  Tom Tromey  <tom@tromey.com>
11483
11484         * top.c (quit_force): Update.
11485         * main.c (captured_command_loop): Update.
11486         * common/new-op.c (operator new): Update.
11487         * common/common-exceptions.c (struct catcher)
11488         <save_cleanup_chain>: Remove member.
11489         (exceptions_state_mc_init): Update.
11490         (exception_try_scope_entry): Return nullptr.
11491         (exception_try_scope_exit, exception_rethrow)
11492         (throw_exception_sjlj, throw_exception_cxx): Update.
11493         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11494         (all_cleanups, do_cleanups, discard_cleanups)
11495         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11496         (restore_cleanups, restore_final_cleanups): Don't declare.
11497         (do_final_cleanups): Remove parameter.
11498         * common/cleanups.c (cleanup_chain, make_cleanup)
11499         (make_cleanup_dtor, all_cleanups, do_cleanups)
11500         (discard_my_cleanups, discard_cleanups)
11501         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11502         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11503         (null_cleanup): Remove.
11504         (do_final_cleanups): Remove parameter.
11505
11506 2019-03-06  Tom Tromey  <tom@tromey.com>
11507
11508         * remote.c (remote_target::remote_parse_stop_reply): Use
11509         unique_xmalloc_ptr.
11510
11511 2019-03-06  Tom Tromey  <tom@tromey.com>
11512
11513         * stabsread.c (struct stabs_field_info): Rename from field_info.
11514         <list, fnlist>: Add initializers.
11515         <obstack>: New member.
11516         (read_member_functions, read_struct_fields, read_baseclasses):
11517         Allocate on obstack.  Don't use cleanups.
11518         (read_one_struct_field, read_member_functions, read_struct_fields)
11519         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11520         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11521         (read_struct_type): Update.
11522
11523 2019-03-06  Tom Tromey  <tom@tromey.com>
11524
11525         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11526         * common/filestuff.h (make_cleanup_close): Don't declare.
11527         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11528         Remove.
11529
11530 2019-03-06  Tom Tromey  <tom@tromey.com>
11531
11532         * solib-aix.c: Use make_scope_exit.
11533
11534 2019-03-06  Tom Tromey  <tom@tromey.com>
11535
11536         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11537         Use make_scope_exit.
11538
11539 2019-03-06  Tom Tromey  <tom@tromey.com>
11540
11541         * solib-svr4.c (disable_probes_interface): Remove parameter.
11542         (svr4_handle_solib_event): Use make_scope_exit.
11543
11544 2019-03-06  Tom Tromey  <tom@tromey.com>
11545
11546         * remote.c (struct stop_reply_deleter): Remove.
11547         (stop_reply_up): Update.
11548         (struct stop_reply): Derive from notif_event.  Don't typedef.
11549         <regcache>: Now a std::vector.
11550         (stop_reply_xfree): Remove.
11551         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11552         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11553         (remote_target::discard_pending_stop_replies): Use delete.
11554         (remote_target::remote_parse_stop_reply): Update.
11555         (remote_target::process_stop_reply): Update.
11556         * remote-notif.h (struct notif_event): Add virtual destructor.
11557         Remove "dtr" member.
11558         (struct notif_client) <alloc_event>: Return a unique_ptr.
11559         (notif_event_xfree): Don't declare.
11560         (notif_event_up): New typedef.
11561         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11562         (notif_event_xfree, do_notif_event_xfree): Remove.
11563         (remote_notif_state_xfree): Update.
11564
11565 2019-03-06  Tom Tromey  <tom@tromey.com>
11566
11567         * infrun.c (displaced_step_clear_cleanup): Now a
11568         forward_scope_exit type.
11569         (displaced_step_prepare_throw): Update.
11570         (displaced_step_fixup): Update.
11571
11572 2019-03-06  Tom Tromey  <tom@tromey.com>
11573
11574         * inferior.h (class inferior): Update comment.
11575         * gdbthread.h (class thread_info): Update comment.
11576
11577 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11578             Tom Tromey  <tom@tromey.com>
11579
11580         * stabsread.h (struct stab_section_list): Remove.
11581         (coffstab_build_psymtabs): Update.
11582         * dbxread.c (symbuf_sections): Now a std::vector.
11583         (sect_idx): New global.
11584         (fill_symbuf): Update.
11585         (coffstab_build_psymtabs): Change type of stabsects parameter.
11586         Update.
11587         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11588         std::vector.
11589         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11590         (coff_locate_sections): Update.
11591         (coff_symfile_read): Remove cleanups.  Update.
11592         (init_stringtab): Add storage parameter.
11593         (free_stringtab, free_stringtab_cleanup): Remove.
11594         (init_lineno): Add storage parameter.
11595         (free_linetab, free_linetab_cleanup): Remove.
11596
11597 2019-03-06  Pedro Alves  <palves@redhat.com>
11598
11599         * linux-fork.c (fork_info::clobber_regs): Delete.
11600         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11601         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11602         comment.  Adjust.
11603         (scoped_switch_fork_info::scoped_switch_fork_info)
11604         (checkpoint_command, linux_fork_context): Adjust
11605         fork_save_infrun_state calls.
11606
11607 2019-03-06  Pedro Alves  <palves@redhat.com>
11608
11609         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11610         (inf_has_multiple_threads): Return 'bool' and rewrite using
11611         inferior_info::threads().
11612
11613 2019-03-06  Pedro Alves  <palves@redhat.com>
11614
11615         * linux-fork.c: Include <list>.
11616         (fork_list): Now a std::list instance.
11617         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11618         (forks_exist_p, find_last_fork): Adjust.
11619         (new_fork): Delete.
11620         (one_fork_p): New.
11621         (add_fork): Adjust.
11622         (free_fork): Delete, folded into fork_info::~fork_info().
11623         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11624         Adjust.
11625         (init_fork_list): Delete.
11626         (linux_fork_killall, linux_fork_mourn_inferior)
11627         (linux_fork_detach, info_checkpoints_command): Adjust.
11628         (_initialize_linux_fork): No longer call init_fork_list.
11629
11630 2019-03-06  Pedro Alves  <palves@redhat.com>
11631
11632         * linux-fork.c (new_fork): New, split out of ...
11633         (add_fork): ... this.  Return void.  Move "first fork" special
11634         case from here, to ...
11635         (checkpoint_command): ... here.
11636         * linux-linux.h (add_fork): Return void.
11637
11638 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11639
11640         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11641
11642 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11643             Chris January  <chris.january@arm.com>
11644             David Lecomber  <david.lecomber@arm.com>
11645
11646         * f-exp.y: New token, UNOP_INTRINSIC.
11647         (exp): New pattern using UNOP_INTRINSIC token.
11648         (f77_keywords): Add 'abs' keyword.
11649         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11650         (value_from_host_double): New function.
11651         (evaluate_subexp_f): Support UNOP_ABS.
11652
11653 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11654
11655         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11656         types.
11657
11658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11659
11660         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11661         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11662         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11663
11664 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11665
11666         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11667
11668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11669             Chris January  <chris.january@arm.com>
11670
11671         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11672         * f-exp.y: Define 'KIND' token.
11673         (exp): New pattern for KIND expressions.
11674         (ptype): Handle types with a kind extension.
11675         (direct_abs_decl): Extend to spot kind extensions.
11676         (f77_keywords): Add 'kind' to the list.
11677         (push_kind_type): New function.
11678         (convert_to_kind_type): New function.
11679         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11680         * parse.c (operator_length_standard): Likewise.
11681         * parser-defs.h (enum type_pieces): Add tp_kind.
11682         * std-operator.def: Add UNOP_KIND.
11683
11684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11685
11686         * f-exp.y (f_parse): Set yydebug.
11687
11688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11689
11690         * f-lang.c (evaluate_subexp_f): New function.
11691         (exp_descriptor_f): New global.
11692         (f_language_defn): Use exp_descriptor_f instead of
11693         exp_descriptor_standard.
11694
11695 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11696
11697         * f-exp.y (struct token): Add comments.
11698         (dot_ops): Remove uppercase versions and the end marker.
11699         (f77_keywords): Likewise.
11700         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11701         entries in the dot_ops array are case insensitive, and use
11702         strncasecmp to compare strings.  Also some whitespace cleanup in
11703         this area.  Similar for the f77_keywords array, except entries in
11704         this list might be case sensitive.
11705
11706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11707
11708         * f-exp.y (struct f77_boolean_val): Add comments.
11709         (boolean_values): Remove uppercase versions, and end marker.
11710         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11711         and use strncasecmp to achieve case insensitivity.  Additionally,
11712         perform whitespace cleanup around this code.
11713
11714 2019-03-06  Tom Tromey  <tromey@adacore.com>
11715
11716         * remote-sim.c (gdbsim_target_open): Use result of
11717         gdb_argv::release.
11718
11719 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11720         Dirk Schubert  <dirk.schubert@arm.com>
11721         Chris January  <chris.january@arm.com>
11722
11723         * eval.c (evaluate_subexp_standard): Call Fortran argument
11724         wrapping logic.
11725         * f-lang.c (struct value): A value which can be passed into a
11726         Fortran function call.
11727         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11728         where appropriate.
11729         (struct type): Value ready for a Fortran function call.
11730         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11731         is needed.
11732         * f-lang.h (fortran_argument_convert): Declaration.
11733         (fortran_preserve_arg_pointer): Declaration.
11734         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11735
11736 2019-03-05  Tom Tromey  <tromey@adacore.com>
11737
11738         * python/py-prettyprint.c (print_string_repr): Remove #if.
11739         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11740
11741 2019-03-05  Tom Tromey  <tromey@adacore.com>
11742
11743         * target.c (the_dummy_target): Move later.  Change type to
11744         "dummy_target".
11745         (initialize_targets): Don't initialize the_dummy_target.
11746
11747 2019-03-05  Tom Tromey  <tromey@adacore.com>
11748
11749         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11750         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11751
11752 2019-03-05  Tom Tromey  <tromey@adacore.com>
11753
11754         * windows-nat.c (windows_nat_target::attach)
11755         (windows_nat_target::detach): Don't call gdb_flush.
11756         * valprint.c (generic_val_print, val_print, val_print_string):
11757         Don't call gdb_flush.
11758         * utils.c (defaulted_query): Don't call gdb_flush.
11759         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11760         * target.c (target_announce_detach): Don't call gdb_flush.
11761         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11762         * remote.c (extended_remote_target::attach): Don't call
11763         gdb_flush.
11764         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11765         * printcmd.c (do_examine): Don't call gdb_flush.
11766         (info_display_command): Don't call gdb_flush.
11767         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11768         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11769         * memattr.c (info_mem_command): Don't call gdb_flush.
11770         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11771         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11772         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11773         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11774         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11775         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11776         (gnu_nat_target::detach): Don't call gdb_flush.
11777         * f-valprint.c (f_val_print): Don't call gdb_flush.
11778         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11779         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11780         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11781         gdb_flush.
11782         * c-valprint.c (c_val_print): Don't call gdb_flush.
11783         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11784
11785 2019-03-05  Tom Tromey  <tromey@adacore.com>
11786
11787         * varobj.c (update_dynamic_varobj_children): Update.
11788         (install_default_visualizer): Use reset, not release.
11789         * value.c (set_internalvar): Update.
11790         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11791         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11792         ATTRIBUTE_UNUSED_RESULT.
11793
11794 2019-03-05  Tom Tromey  <tromey@adacore.com>
11795
11796         * remote.c (class scoped_remote_fd) <release>: Add
11797         ATTRIBUTE_UNUSED_RESULT.
11798
11799 2019-03-05  Tom Tromey  <tromey@adacore.com>
11800
11801         * macroexp.c (struct macro_buffer) <release>: Add
11802         ATTRIBUTE_UNUSED_RESULT.
11803
11804 2019-03-05  Tom Tromey  <tromey@adacore.com>
11805
11806         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11807         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11808         ATTRIBUTE_UNUSED_RESULT.
11809
11810 2019-03-05  Tom Tromey  <tromey@adacore.com>
11811
11812         * common/scoped_fd.h (class scoped_fd) <release>: Add
11813         ATTRIBUTE_UNUSED_RESULT.
11814
11815 2019-03-05  Tom Tromey  <tromey@adacore.com>
11816
11817         * parser-defs.h (struct parser_state) <release>: Add
11818         ATTRIBUTE_UNUSED_RESULT.
11819
11820 2019-03-05  Tom Tromey  <tromey@adacore.com>
11821
11822         * utils.h (class gdb_argv) <release>: Add
11823         ATTRIBUTE_UNUSED_RESULT.
11824         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11825
11826 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11827
11828         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11829         for-loop range, to avoid compiler warnings.
11830
11831         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11832         avoid compiler warnings about unused variables.
11833
11834         * NEWS: Mention end of support for native debugging on MS-Windows
11835         before XP.
11836
11837         PR gdb/24292
11838         * common/netstuff.c:
11839         * gdbserver/gdbreplay.c
11840         * gdbserver/remote-utils.c:
11841         * ser-tcp.c:
11842         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11843         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11844         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11845         'getaddrinfo' and 'freeaddrinfo' were not available before
11846         Windows XP, and mingw.org's MinGW headers by default define
11847         _WIN32_WINNT to 0x500.
11848
11849 2019-03-01  Gary Benson <gbenson@redhat.com>
11850
11851         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11852
11853 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11854             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11855
11856         PR gdb/8527
11857         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11858         set_sigint_trap, clear_sigint_trap.
11859
11860 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11861
11862         * target.c (target_detach): Clear the regcache and the
11863         frame cache.
11864
11865 2019-02-27  Pedro Alves  <palves@redhat.com>
11866
11867         * utils.c (set_screen_size): When we cap the height/width sizes,
11868         tweak the corresponding command variable to show "unlimited":
11869
11870 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11871             Pedro Alves  <palves@redhat.com>
11872
11873         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11874         before calling rl_set_screen_size.
11875
11876 2019-02-27  Tom Tromey  <tromey@adacore.com>
11877
11878         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11879         define.
11880         * python/py-value.c: Remove Python 2.4 workaround.
11881         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11882         workaround.
11883         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11884         Python 2.4 workaround.
11885         * python/python-internal.h: Remove Python 2.4 comment.
11886         (Py_ssize_t): Don't define.
11887         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11888         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11889         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11890         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11891         * python/python.c (do_start_initialization): Remove Python 2.4
11892         workaround.
11893         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11894         (print_children): Remove Python 2.4 workaround.
11895         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11896         workaround.
11897         (CHARBUFFERPROC_NAME): Remove.
11898         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11899         Python 2.4 workaround.
11900
11901 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11902
11903         * NEWS: Note minimum Python version.
11904
11905 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11906
11907         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11908         code from these functions.  Remove corresponding ifdefs.  Use
11909         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11910         Remove gotos and target of gotos.
11911         (infpy_search_memory): Likewise.
11912
11913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11914
11915         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11916         (hppa_gdbarch_init): Don't register deleted functions with
11917         gdbarch.
11918
11919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11920
11921         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11922         (h8300_unwind_sp): Delete.
11923         (h8300_dummy_id): Delete.
11924         (h8300_gdbarch_init): Don't register deleted functions with
11925         gdbarch.
11926
11927 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11928
11929         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11930         (ft32_unwind_pc): Delete.
11931         (ft32_unwind_sp): Delete.
11932         (ft32_gdbarch_init): Don't register deleted functions with
11933         gdbarch.
11934
11935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11936
11937         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11938         (frv_unwind_pc): Delete.
11939         (frv_unwind_sp): Delete.
11940         (frv_gdbarch_init): Don't register deleted functions with
11941         gdbarch.
11942
11943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11944
11945         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11946         (riscv_unwind_pc): Delete.
11947         (riscv_unwind_sp): Delete.
11948         (riscv_gdbarch_init): Don't register deleted functions with
11949         gdbarch.
11950
11951 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11952
11953         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11954         (csky_unwind_pc): Delete.
11955         (csky_unwind_sp): Delete.
11956         (csky_gdbarch_init): Don't register deleted functions with
11957         gdbarch.
11958
11959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11962         (cris_unwind_pc): Delete.
11963         (cris_unwind_sp): Delete.
11964         (cris_gdbarch_init): Don't register deleted functions with
11965         gdbarch.
11966
11967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11968
11969         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11970         (bfin_unwind_pc): Delete.
11971         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11972
11973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11974
11975         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11976         (arm_unwind_pc): Delete.
11977         (arm_unwind_sp): Delete.
11978         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11979
11980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11981
11982         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11983         (arc_unwind_pc): Delete.
11984         (arc_unwind_sp): Delete.
11985         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11986
11987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11988
11989         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11990         (alpha_unwind_pc): Delete.
11991         (alpha_gdbarch_init): Don't register deleted functions with
11992         gdbarch.
11993
11994 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11995
11996         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11997         (aarch64_unwind_pc): Delete.
11998         (aarch64_unwind_sp): Delete.
11999         (aarch64_gdbarch_init): Don't register deleted functions with
12000         gdbarch.
12001
12002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12003
12004         * gdbtypes.c (type_align): Don't consider static members when
12005         computing structure alignment.
12006
12007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12008
12009         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12010         return 0 for other types.
12011         * arch-utils.c (default_type_align): Always return 0.
12012         * gdbarch.h: Regenerate.
12013         * gdbarch.sh (type_align): Extend comment.
12014         * gdbtypes.c (type_align): Add additional comments, always call
12015         gdbarch_type_align before applying the default rules.
12016         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12017         generic code will then apply a suitable default.
12018         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12019         types, return 0 for other types.
12020
12021 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12022
12023         * NEWS: Create a new section for the next release branch.
12024         Rename the section of the current branch, now that it has
12025         been cut.
12026
12027 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12028
12029         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12030         * version.in: Bump version to 8.3.50.DATE-git.
12031
12032 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12033
12034         * aix-thread.c (ptid_cmp): Remove unused variable.
12035         (get_signaled_thread): Likewise.
12036         (store_regs_user_thread): Likewise.
12037         (store_regs_kernel_thread): Likewise.
12038         (fetch_regs_kernel_thread): Remove shadowed variable.
12039
12040 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12041
12042         * features/riscv/32bit-cpu.xml: Add register numbers.
12043         * features/riscv/32bit-fpu.c: Regenerate.
12044         * features/riscv/32bit-fpu.xml: Add register numbers.
12045         * features/riscv/64bit-cpu.xml: Add register numbers.
12046         * features/riscv/64bit-fpu.c: Regenerate.
12047         * features/riscv/64bit-fpu.xml: Add register numbers.
12048
12049 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12050
12051         * NEWS: Mention two argument form of gdb.Value constructor.
12052         * python/py-value.c (convert_buffer_and_type_to_value): New
12053         function.
12054         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12055         Add support for handling an optional second argument.  Call
12056         convert_buffer_and_type_to_value as appropriate.
12057         * python/python-internal.h (Py_buffer_deleter): New struct.
12058         (Py_buffer_up): New typedef.
12059
12060 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12061
12062         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12063         instead of releasing ownership.
12064
12065 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12066
12067         * dwarf2read.c (open_and_init_dwp_file): Call
12068         elf_numsections instead of bfd_count_sections to initialize
12069         dwp_file->num_sections.
12070
12071 2019-02-25  Tom Tromey  <tromey@adacore.com>
12072
12073         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12074
12075 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12076
12077         * gcore.in: Add '--readnever' option when invoking GDB.
12078
12079 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12080
12081         * MAINTAINERS: Update my email address.
12082
12083 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12084
12085         * build-id.c (build_id_to_debug_bfd_1): New function.
12086         (build_id_to_debug_bfd): Look for separate debug file in
12087         sysroot.
12088
12089 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12090
12091         * gdbarch.sh: Update the copyright year range that is placed into
12092         generated files.
12093
12094 2019-02-22  Keith Seitz  <keiths@redhat.com>
12095
12096         PR symtab/23853
12097         * linespec.c (create_sals_line_offset): Search for the default
12098         symtab's filename instead of its fullname.
12099
12100 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12101
12102         * NEWS: Update style defaults.
12103
12104 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12105
12106         * main.c (captured_main_1): Disable styling in batch mode.
12107
12108 2019-02-20  Tom Tromey  <tom@tromey.com>
12109
12110         * symtab.c (symtab_symbol_info): Fix typos.
12111
12112 2019-02-20  Tom Tromey  <tromey@adacore.com>
12113
12114         * findcmd.c (_initialize_mem_search): Use upper case for
12115         metasyntactic variables.
12116
12117 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12118
12119         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12120         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12121
12122 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12123
12124         * top.h (source_file_name): Change to std::string.
12125         * top.c (source_file_name): Likewise.
12126         (command_line_input): Adjust.
12127         * cli/cli-script.c (script_from_file): Adjust.
12128
12129 2019-02-19  Tom Tromey  <tromey@adacore.com>
12130
12131         * ravenscar-thread.c
12132         (ravenscar_thread_target::update_thread_list): Don't call
12133         ada_build_task_list.
12134         * ada-lang.h (ada_build_task_list): Don't declare.
12135         * ada-tasks.c (struct ada_tasks_inferior_data)
12136         <task_list_valid_p>: Now bool.
12137         (read_known_tasks, ada_task_list_changed)
12138         (ada_tasks_invalidate_inferior_data): Update.
12139         (read_known_tasks_array): Return bool.
12140         (read_known_tasks_list): Likewise.
12141         (read_known_tasks): Return void.
12142         (ada_build_task_list): Now static.
12143
12144 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12145
12146         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12147         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12148
12149 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12150
12151         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12152         variant for ada_tasks_pspace_data_handle and
12153         ada_tasks_inferior_data_handle.
12154         (ada_tasks_pspace_data_cleanup): New function.
12155         (ada_tasks_inferior_data_cleanup): New function.
12156
12157 2019-02-17  Tom Tromey  <tom@tromey.com>
12158
12159         * macrotab.h (macro_source_fullname): Return a std::string.
12160         * macrotab.c (macro_include, check_for_redefinition)
12161         (macro_undef, macro_lookup_definition, foreach_macro)
12162         (foreach_macro_in_scope): Update.
12163         (macro_source_fullname): Return a std::string.
12164         * macrocmd.c (show_pp_source_pos): Update.
12165
12166 2019-02-17  Tom Tromey  <tom@tromey.com>
12167
12168         * macrocmd.c (show_pp_source_pos): Style the file names.
12169
12170 2019-02-17  Tom Tromey  <tom@tromey.com>
12171
12172         PR tui/24197:
12173         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12174
12175 2019-02-17  Tom Tromey  <tom@tromey.com>
12176
12177         * ada-lang.c (user_select_syms): Use filtered printing.
12178         * utils.c (wrap_style): New global.
12179         (desired_style): Remove.
12180         (emit_style_escape): Add stream parameter.
12181         (set_output_style, reset_terminal_style, prompt_for_continue):
12182         Update.
12183         (flush_wrap_buffer): Only flush gdb_stdout.
12184         (wrap_here): Set wrap_style.
12185         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12186         treat escape sequences as a character.  Change when wrap buffer is
12187         flushed.
12188         (fputs_styled): Do not set the output style when the default is
12189         requested.
12190         * ui-style.h (struct ui_file_style) <is_default>: New method.
12191         * source.c (print_source_lines_base): Emit escape sequences in one
12192         piece.
12193
12194 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12195
12196         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12197         integers and enumeration types.
12198
12199 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12200
12201         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12202         instead of lookup_symbol_in_language
12203         (do_exact_match): New function.
12204         (ada_get_symbol_name_matcher): Return do_exact_match when
12205         doing a verbatim match.
12206
12207 2019-02-15  Tom Tromey  <tromey@adacore.com>
12208
12209         * ravenscar-thread.c (ravenscar_thread_target::resume)
12210         (ravenscar_thread_target::wait): Special case wildcard requests.
12211
12212 2019-02-15  Tom Tromey  <tromey@adacore.com>
12213
12214         * ravenscar-thread.c (base_ptid): Remove.
12215         (struct ravenscar_thread_target) <close>: New method.
12216         <m_base_ptid>: New member.
12217         <update_inferior_ptid, active_task, task_is_currently_active,
12218         runtime_initialized>: Declare methods.
12219         <ravenscar_thread_target>: Add constructor.
12220         (ravenscar_thread_target::task_is_currently_active)
12221         (ravenscar_thread_target::update_inferior_ptid)
12222         (ravenscar_runtime_initialized): Rename.  Now methods.
12223         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12224         (ravenscar_thread_target::update_thread_list): Update.
12225         (ravenscar_thread_target::active_task): Now method.
12226         (ravenscar_thread_target::store_registers)
12227         (ravenscar_thread_target::prepare_to_store)
12228         (ravenscar_thread_target::prepare_to_store)
12229         (ravenscar_thread_target::mourn_inferior): Update.
12230         (ravenscar_inferior_created): Use "new" to create target.
12231         (ravenscar_thread_target::get_ada_task_ptid): Update.
12232         (_initialize_ravenscar): Don't initialize base_ptid.
12233         (ravenscar_ops): Remove global.
12234
12235 2019-02-15  Tom Tromey  <tromey@adacore.com>
12236
12237         * target.h (push_target): Declare new overload.
12238         * target.c (push_target): New overload, taking an rvalue reference.
12239         * remote.c (remote_target::open_1): Use push_target overload.
12240         * corelow.c (core_target_open): Use push_target overload.
12241
12242 2019-02-15  Tom Tromey  <tromey@adacore.com>
12243
12244         * ravenscar-thread.c (is_ravenscar_task)
12245         (ravenscar_task_is_currently_active): Return bool.
12246         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12247         (_initialize_ravenscar): Remove "(void)".
12248         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12249         Return bool.
12250
12251 2019-02-15  Tom Tromey  <tromey@adacore.com>
12252
12253         * ravenscar-thread.c (ravenscar_runtime_initializer)
12254         (has_ravenscar_runtime, get_running_thread_id)
12255         (ravenscar_thread_target::resume): Fix indentation.
12256
12257 2019-02-15  Tom Tromey  <tromey@adacore.com>
12258
12259         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12260         from ravenscar_arch_ops.
12261         (sparc_ravenscar_ops::fetch_registers)
12262         (sparc_ravenscar_ops::store_registers): Now methods.
12263         (sparc_ravenscar_prepare_to_store): Remove.
12264         (sparc_ravenscar_ops): Redefine.
12265         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12266         methods and destructor.  Remove members.
12267         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12268         (ravenscar_thread_target::store_registers)
12269         (ravenscar_thread_target::prepare_to_store): Update.
12270         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12271         Remove.
12272         (struct ppc_ravenscar_powerpc_ops): Derive from
12273         ravenscar_arch_ops.
12274         (ppc_ravenscar_powerpc_ops::fetch_registers)
12275         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12276         (ppc_ravenscar_powerpc_ops): Redefine.
12277         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12278         (ppc_ravenscar_e500_ops::fetch_registers)
12279         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12280         (ppc_ravenscar_e500_ops): Redefine.
12281         * aarch64-ravenscar-thread.c
12282         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12283         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12284         (aarch64_ravenscar_fetch_registers)
12285         (aarch64_ravenscar_store_registers): Now methods.
12286         (aarch64_ravenscar_ops): Redefine.
12287
12288 2019-02-15  Tom Tromey  <tromey@adacore.com>
12289
12290         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12291         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12292         (ravenscar_thread_target::stopped_by_watchpoint)
12293         (ravenscar_thread_target::stopped_data_address)
12294         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12295
12296 2019-02-15  Tom Tromey  <tromey@adacore.com>
12297
12298         * ravenscar-thread.c: Fix some typos.
12299
12300 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12301             Tom Tromey  <tromey@adacore.com>
12302
12303         * ada-lang.c (ada_exception_sal): Change addr_string to a
12304         std::string.
12305         (create_ada_exception_catchpoint): Update.
12306
12307 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12308             Tom Tromey  <tromey@adacore.com>
12309
12310         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12311         (bp_location_ops): Remove.
12312         (base_breakpoint_allocate_location): Update.
12313         (free_bp_location): Update.
12314         * ada-lang.c (class ada_catchpoint_location)
12315         <ada_catchpoint_location>: Remove ops parameter.
12316         (ada_catchpoint_location_dtor): Remove.
12317         (ada_catchpoint_location_ops): Remove.
12318         (allocate_location_exception): Update.
12319         * breakpoint.h (struct bp_location_ops): Remove.
12320         (class bp_location) <bp_location>: Remove bp_location_ops
12321         parameter.
12322         <~bp_location>: Add destructor.
12323         <ops>: Remove.
12324
12325 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12326             Pedro Alves  <palves@redhat.com>
12327
12328         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12329         'PATH_MAX'.
12330
12331 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12332             Samuel Thibault  <samuel.thibault@gnu.org>
12333             Thomas Schwinge  <thomas@codesourcery.com>
12334
12335         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12336         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12337
12338 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12339
12340         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12341         (check_empty): Use "const char *".
12342
12343         * gnu-nat.c (gnu_nat_target::detach): Instead of
12344         'detach_inferior (pid)' call
12345         'detach_inferior (find_inferior_pid (pid))'.
12346
12347         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12348         'nat/fork-inferior.o'.
12349         * gnu-nat.c: #include "nat/fork-inferior.h".
12350
12351         * gnu-nat.c (gnu_nat_target::detach): Instead of
12352         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12353         * gnu-nat.h: #include "inf-child.h".
12354         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12355         'i386_gnu_nat_target::fetch_registers'.
12356         (gnu_store_registers): Rename/move to
12357         'i386_gnu_nat_target::store_registers'.
12358
12359         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12360         * gnu-nat.h (mach_thread_info): New function.
12361         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12362
12363         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12364
12365 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12366
12367         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12368
12369 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12370
12371         * windows-nat.c (windows_add_thread): Add new parameter
12372         "main_thread_p" with default value set to false.  Update
12373         function documentation as well as all callers.
12374         (windows_delete_thread): Likewise.
12375         (fake_create_process): Update call to windows_add_thread.
12376         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12377         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12378         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12379         call to windows_delete_thread.
12380
12381 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12382
12383         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12384
12385 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12386
12387         * symfile.c (find_separate_debug_file): Use canonical path of
12388         sysroot with child_path instead of gdb_sysroot if it is valid.
12389
12390 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12391
12392         * symfile.c (find_separate_debug_file): Use child_path to
12393         determine if an object file is under a sysroot.
12394
12395 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12396
12397         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12398         unittests/child-path-selftests.c.
12399         * common/pathstuff.c (child_path): New function.
12400         * common/pathstuff.h (child_path): New prototype.
12401         * unittests/child-path-selftests.c: New file.
12402
12403 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12404
12405         * symfile.c (find_separate_debug_file): Look for separate debug
12406         files in debug directories under the sysroot.
12407
12408 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12409
12410         * symtab.h (struct minimal_symbol data_p): New const method.
12411         (struct minimal_symbol text_p): Likewise.
12412         * symtab.c (output_source_filename): Use file name style
12413         to print file name.
12414         (print_symbol_info): Likewise.
12415         (print_msymbol_info): Use address style to print addresses.
12416         Use function name style to print executable text symbols.
12417         (expand_symtab_containing_pc): Use data_p.
12418         (find_pc_sect_compunit_symtab): Likewise.
12419
12420 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12421
12422         * breakpoint.c (describe_other_breakpoints): Use address style
12423         to print addresses.
12424         (say_where): Likewise.
12425
12426 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12427
12428         * ada-typeprint.c (print_func_type): Print function name
12429         style to print function name.
12430         * c-typeprint.c (c_print_type_1): Likewise.
12431
12432 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12433
12434         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12435         for execve.
12436
12437 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12438
12439         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12440         type_stack.
12441
12442 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12443
12444         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12445         TYPE_CODE_REF types.
12446
12447 2019-02-08  Jim Wilson  <jimw@sifive.com>
12448
12449         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12450         (riscv_linux_fregset): New.
12451         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12452
12453 2019-02-07  Tom Tromey  <tom@tromey.com>
12454
12455         * thread.c (thread_cancel_execution_command): Update.
12456         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12457         methods.
12458         (struct thread_fsm_ops): Remove.
12459         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12460         (thread_fsm_should_stop, thread_fsm_return_value)
12461         (thread_fsm_set_finished, thread_fsm_finished_p)
12462         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12463         Don't declare.
12464         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12465         * infrun.c (clear_proceed_status_thread)
12466         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12467         (print_stop_event): Update.
12468         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12469         Add constructor.
12470         (step_command_fsm_ops): Remove.
12471         (new_step_command_fsm): Remove.
12472         (step_1): Update.
12473         (step_command_fsm::should_stop): Rename from
12474         step_command_fsm_should_stop.
12475         (step_command_fsm::clean_up): Rename from
12476         step_command_fsm_clean_up.
12477         (step_command_fsm::do_async_reply_reason): Rename from
12478         step_command_fsm_async_reply_reason.
12479         (struct until_next_fsm): Inherit from thread_fsm.  Add
12480         constructor.
12481         (until_next_fsm_ops): Remove.
12482         (new_until_next_fsm): Remove.
12483         (until_next_fsm::should_stop): Rename from
12484         until_next_fsm_should_stop.
12485         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12486         (until_next_fsm::do_async_reply_reason): Rename from
12487         until_next_fsm_async_reply_reason.
12488         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12489         constructor.  Change type of breakpoint.
12490         (finish_command_fsm_ops): Remove.
12491         (new_finish_command_fsm): Remove.
12492         (finish_command_fsm::should_stop): Rename from
12493         finish_command_fsm_should_stop.
12494         (finish_command_fsm::clean_up): Rename from
12495         finish_command_fsm_clean_up.
12496         (finish_command_fsm::return_value): Rename from
12497         finish_command_fsm_return_value.
12498         (finish_command_fsm::do_async_reply_reason): Rename from
12499         finish_command_fsm_async_reply_reason.
12500         (finish_command): Update.
12501         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12502         Add constructor.
12503         (call_thread_fsm_ops): Remove.
12504         (call_thread_fsm::call_thread_fsm): Rename from
12505         new_call_thread_fsm.
12506         (call_thread_fsm::should_stop): Rename from
12507         call_thread_fsm_should_stop.
12508         (call_thread_fsm::should_notify_stop): Rename from
12509         call_thread_fsm_should_notify_stop.
12510         (run_inferior_call, call_function_by_hand_dummy): Update.
12511         * cli/cli-interp.c (should_print_stop_to_console): Update.
12512         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12513         Add constructor.  Change type of location_breakpoint,
12514         caller_breakpoint.
12515         (until_break_fsm_ops): Remove.
12516         (new_until_break_fsm): Remove.
12517         (until_break_fsm::should_stop): Rename from
12518         until_break_fsm_should_stop.
12519         (until_break_fsm::clean_up): Rename from
12520         until_break_fsm_clean_up.
12521         (until_break_fsm::do_async_reply_reason): Rename from
12522         until_break_fsm_async_reply_reason.
12523         (until_break_command): Update.
12524         * thread-fsm.c: Remove.
12525         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12526
12527 2019-02-07  Tom Tromey  <tom@tromey.com>
12528
12529         * yy-remap.h: Add include guard.
12530         * xtensa-tdep.h: Add include guard.
12531         * xcoffread.h: Rename include guard.
12532         * varobj-iter.h: Add include guard.
12533         * tui/tui.h: Rename include guard.
12534         * tui/tui-winsource.h: Rename include guard.
12535         * tui/tui-wingeneral.h: Rename include guard.
12536         * tui/tui-windata.h: Rename include guard.
12537         * tui/tui-win.h: Rename include guard.
12538         * tui/tui-stack.h: Rename include guard.
12539         * tui/tui-source.h: Rename include guard.
12540         * tui/tui-regs.h: Rename include guard.
12541         * tui/tui-out.h: Rename include guard.
12542         * tui/tui-layout.h: Rename include guard.
12543         * tui/tui-io.h: Rename include guard.
12544         * tui/tui-hooks.h: Rename include guard.
12545         * tui/tui-file.h: Rename include guard.
12546         * tui/tui-disasm.h: Rename include guard.
12547         * tui/tui-data.h: Rename include guard.
12548         * tui/tui-command.h: Rename include guard.
12549         * tic6x-tdep.h: Add include guard.
12550         * target/waitstatus.h: Rename include guard.
12551         * target/wait.h: Rename include guard.
12552         * target/target.h: Rename include guard.
12553         * target/resume.h: Rename include guard.
12554         * target-float.h: Rename include guard.
12555         * stabsread.h: Add include guard.
12556         * rs6000-tdep.h: Add include guard.
12557         * riscv-fbsd-tdep.h: Add include guard.
12558         * regformats/regdef.h: Rename include guard.
12559         * record.h: Rename include guard.
12560         * python/python.h: Rename include guard.
12561         * python/python-internal.h: Rename include guard.
12562         * python/py-stopevent.h: Rename include guard.
12563         * python/py-ref.h: Rename include guard.
12564         * python/py-record.h: Rename include guard.
12565         * python/py-record-full.h: Rename include guard.
12566         * python/py-record-btrace.h: Rename include guard.
12567         * python/py-instruction.h: Rename include guard.
12568         * python/py-events.h: Rename include guard.
12569         * python/py-event.h: Rename include guard.
12570         * procfs.h: Add include guard.
12571         * proc-utils.h: Add include guard.
12572         * p-lang.h: Add include guard.
12573         * or1k-tdep.h: Rename include guard.
12574         * observable.h: Rename include guard.
12575         * nto-tdep.h: Rename include guard.
12576         * nat/x86-linux.h: Rename include guard.
12577         * nat/x86-linux-dregs.h: Rename include guard.
12578         * nat/x86-gcc-cpuid.h: Add include guard.
12579         * nat/x86-dregs.h: Rename include guard.
12580         * nat/x86-cpuid.h: Rename include guard.
12581         * nat/ppc-linux.h: Rename include guard.
12582         * nat/mips-linux-watch.h: Rename include guard.
12583         * nat/linux-waitpid.h: Rename include guard.
12584         * nat/linux-ptrace.h: Rename include guard.
12585         * nat/linux-procfs.h: Rename include guard.
12586         * nat/linux-osdata.h: Rename include guard.
12587         * nat/linux-nat.h: Rename include guard.
12588         * nat/linux-namespaces.h: Rename include guard.
12589         * nat/linux-btrace.h: Rename include guard.
12590         * nat/glibc_thread_db.h: Rename include guard.
12591         * nat/gdb_thread_db.h: Rename include guard.
12592         * nat/gdb_ptrace.h: Rename include guard.
12593         * nat/fork-inferior.h: Rename include guard.
12594         * nat/amd64-linux-siginfo.h: Rename include guard.
12595         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12596         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12597         * nat/aarch64-linux.h: Rename include guard.
12598         * nat/aarch64-linux-hw-point.h: Rename include guard.
12599         * mn10300-tdep.h: Add include guard.
12600         * mips-linux-tdep.h: Add include guard.
12601         * mi/mi-parse.h: Rename include guard.
12602         * mi/mi-out.h: Rename include guard.
12603         * mi/mi-main.h: Rename include guard.
12604         * mi/mi-interp.h: Rename include guard.
12605         * mi/mi-getopt.h: Rename include guard.
12606         * mi/mi-console.h: Rename include guard.
12607         * mi/mi-common.h: Rename include guard.
12608         * mi/mi-cmds.h: Rename include guard.
12609         * mi/mi-cmd-break.h: Rename include guard.
12610         * m2-lang.h: Add include guard.
12611         * location.h: Rename include guard.
12612         * linux-record.h: Rename include guard.
12613         * linux-nat.h: Add include guard.
12614         * linux-fork.h: Add include guard.
12615         * i386-darwin-tdep.h: Rename include guard.
12616         * hppa-linux-offsets.h: Add include guard.
12617         * guile/guile.h: Rename include guard.
12618         * guile/guile-internal.h: Rename include guard.
12619         * gnu-nat.h: Rename include guard.
12620         * gdb-stabs.h: Rename include guard.
12621         * frv-tdep.h: Add include guard.
12622         * f-lang.h: Add include guard.
12623         * event-loop.h: Add include guard.
12624         * darwin-nat.h: Rename include guard.
12625         * cp-abi.h: Rename include guard.
12626         * config/sparc/nm-sol2.h: Rename include guard.
12627         * config/nm-nto.h: Rename include guard.
12628         * config/nm-linux.h: Add include guard.
12629         * config/i386/nm-i386gnu.h: Rename include guard.
12630         * config/djgpp/nl_types.h: Rename include guard.
12631         * config/djgpp/langinfo.h: Rename include guard.
12632         * compile/gcc-cp-plugin.h: Add include guard.
12633         * compile/gcc-c-plugin.h: Add include guard.
12634         * compile/compile.h: Rename include guard.
12635         * compile/compile-object-run.h: Rename include guard.
12636         * compile/compile-object-load.h: Rename include guard.
12637         * compile/compile-internal.h: Rename include guard.
12638         * compile/compile-cplus.h: Rename include guard.
12639         * compile/compile-c.h: Rename include guard.
12640         * common/xml-utils.h: Rename include guard.
12641         * common/x86-xstate.h: Rename include guard.
12642         * common/version.h: Rename include guard.
12643         * common/vec.h: Rename include guard.
12644         * common/tdesc.h: Rename include guard.
12645         * common/selftest.h: Rename include guard.
12646         * common/scoped_restore.h: Rename include guard.
12647         * common/scoped_mmap.h: Rename include guard.
12648         * common/scoped_fd.h: Rename include guard.
12649         * common/safe-iterator.h: Rename include guard.
12650         * common/run-time-clock.h: Rename include guard.
12651         * common/refcounted-object.h: Rename include guard.
12652         * common/queue.h: Rename include guard.
12653         * common/ptid.h: Rename include guard.
12654         * common/print-utils.h: Rename include guard.
12655         * common/preprocessor.h: Rename include guard.
12656         * common/pathstuff.h: Rename include guard.
12657         * common/observable.h: Rename include guard.
12658         * common/netstuff.h: Rename include guard.
12659         * common/job-control.h: Rename include guard.
12660         * common/host-defs.h: Rename include guard.
12661         * common/gdb_wait.h: Rename include guard.
12662         * common/gdb_vecs.h: Rename include guard.
12663         * common/gdb_unlinker.h: Rename include guard.
12664         * common/gdb_unique_ptr.h: Rename include guard.
12665         * common/gdb_tilde_expand.h: Rename include guard.
12666         * common/gdb_sys_time.h: Rename include guard.
12667         * common/gdb_string_view.h: Rename include guard.
12668         * common/gdb_splay_tree.h: Rename include guard.
12669         * common/gdb_setjmp.h: Rename include guard.
12670         * common/gdb_ref_ptr.h: Rename include guard.
12671         * common/gdb_optional.h: Rename include guard.
12672         * common/gdb_locale.h: Rename include guard.
12673         * common/gdb_assert.h: Rename include guard.
12674         * common/filtered-iterator.h: Rename include guard.
12675         * common/filestuff.h: Rename include guard.
12676         * common/fileio.h: Rename include guard.
12677         * common/environ.h: Rename include guard.
12678         * common/common-utils.h: Rename include guard.
12679         * common/common-types.h: Rename include guard.
12680         * common/common-regcache.h: Rename include guard.
12681         * common/common-inferior.h: Rename include guard.
12682         * common/common-gdbthread.h: Rename include guard.
12683         * common/common-exceptions.h: Rename include guard.
12684         * common/common-defs.h: Rename include guard.
12685         * common/common-debug.h: Rename include guard.
12686         * common/cleanups.h: Rename include guard.
12687         * common/buffer.h: Rename include guard.
12688         * common/btrace-common.h: Rename include guard.
12689         * common/break-common.h: Rename include guard.
12690         * cli/cli-utils.h: Rename include guard.
12691         * cli/cli-style.h: Rename include guard.
12692         * cli/cli-setshow.h: Rename include guard.
12693         * cli/cli-script.h: Rename include guard.
12694         * cli/cli-interp.h: Rename include guard.
12695         * cli/cli-decode.h: Rename include guard.
12696         * cli/cli-cmds.h: Rename include guard.
12697         * charset-list.h: Add include guard.
12698         * buildsym-legacy.h: Rename include guard.
12699         * bfin-tdep.h: Add include guard.
12700         * ax.h: Rename include guard.
12701         * arm-linux-tdep.h: Add include guard.
12702         * arm-fbsd-tdep.h: Add include guard.
12703         * arch/xtensa.h: Rename include guard.
12704         * arch/tic6x.h: Add include guard.
12705         * arch/i386.h: Add include guard.
12706         * arch/arm.h: Rename include guard.
12707         * arch/arm-linux.h: Rename include guard.
12708         * arch/arm-get-next-pcs.h: Rename include guard.
12709         * arch/amd64.h: Add include guard.
12710         * arch/aarch64-insn.h: Rename include guard.
12711         * arch-utils.h: Rename include guard.
12712         * annotate.h: Add include guard.
12713         * amd64-darwin-tdep.h: Rename include guard.
12714         * aarch64-linux-tdep.h: Add include guard.
12715         * aarch64-fbsd-tdep.h: Add include guard.
12716         * aarch32-linux-nat.h: Add include guard.
12717
12718 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12719
12720         * macrotab.c (macro_define_internal): New function that
12721         factorizes macro_define_object_internal and macro_define_function
12722         code.
12723         (macro_define_object_internal): Use macro_define_internal.
12724         (macro_define_function): Likewise.
12725
12726 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12727
12728         * macrocmd.c (extract_identifier): Return
12729         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12730         callers.
12731
12732 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12733
12734         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12735
12736 2019-02-05  Tom Tromey  <tom@tromey.com>
12737
12738         * target.c (target_stack::unpush): Move assertion earlier.
12739
12740 2019-01-30  Tom Tromey  <tom@tromey.com>
12741
12742         PR python/23615:
12743         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12744         (gdbpy_parse_and_eval): Likewise.
12745         * python/python-internal.h (gdbpy_allow_threads): New class.
12746
12747 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12748
12749         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12750         (aarch64_fbsd_fpregmap): Move earlier.
12751         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12752         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12753         instead of individual calls to trad_frame_set_reg_addr.
12754         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12755         earlier.
12756         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12757         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12758         instead of individual calls to trad_frame_set_reg_addr.
12759
12760 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12761
12762         * CONTRIBUTE: Replace contribution list with wiki link.
12763
12764 2019-01-25  Tom Tromey  <tom@tromey.com>
12765
12766         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12767
12768 2019-01-25  Tom Tromey  <tom@tromey.com>
12769
12770         * xtensa-linux-nat.c: Fix common/ includes.
12771         * xml-support.h: Fix common/ includes.
12772         * xml-support.c: Fix common/ includes.
12773         * x86-linux-nat.c: Fix common/ includes.
12774         * windows-nat.c: Fix common/ includes.
12775         * varobj.h: Fix common/ includes.
12776         * varobj.c: Fix common/ includes.
12777         * value.c: Fix common/ includes.
12778         * valops.c: Fix common/ includes.
12779         * utils.c: Fix common/ includes.
12780         * unittests/xml-utils-selftests.c: Fix common/ includes.
12781         * unittests/utils-selftests.c: Fix common/ includes.
12782         * unittests/unpack-selftests.c: Fix common/ includes.
12783         * unittests/tracepoint-selftests.c: Fix common/ includes.
12784         * unittests/style-selftests.c: Fix common/ includes.
12785         * unittests/string_view-selftests.c: Fix common/ includes.
12786         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12787         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12788         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12789         * unittests/rsp-low-selftests.c: Fix common/ includes.
12790         * unittests/parse-connection-spec-selftests.c: Fix common/
12791         includes.
12792         * unittests/optional-selftests.c: Fix common/ includes.
12793         * unittests/offset-type-selftests.c: Fix common/ includes.
12794         * unittests/observable-selftests.c: Fix common/ includes.
12795         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12796         * unittests/memrange-selftests.c: Fix common/ includes.
12797         * unittests/memory-map-selftests.c: Fix common/ includes.
12798         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12799         * unittests/function-view-selftests.c: Fix common/ includes.
12800         * unittests/environ-selftests.c: Fix common/ includes.
12801         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12802         * unittests/common-utils-selftests.c: Fix common/ includes.
12803         * unittests/cli-utils-selftests.c: Fix common/ includes.
12804         * unittests/array-view-selftests.c: Fix common/ includes.
12805         * ui-file.c: Fix common/ includes.
12806         * tui/tui-io.c: Fix common/ includes.
12807         * tracepoint.h: Fix common/ includes.
12808         * tracepoint.c: Fix common/ includes.
12809         * tracefile-tfile.c: Fix common/ includes.
12810         * top.h: Fix common/ includes.
12811         * top.c: Fix common/ includes.
12812         * thread.c: Fix common/ includes.
12813         * target/waitstatus.h: Fix common/ includes.
12814         * target/waitstatus.c: Fix common/ includes.
12815         * target.h: Fix common/ includes.
12816         * target.c: Fix common/ includes.
12817         * target-memory.c: Fix common/ includes.
12818         * target-descriptions.c: Fix common/ includes.
12819         * symtab.h: Fix common/ includes.
12820         * symfile.c: Fix common/ includes.
12821         * stap-probe.c: Fix common/ includes.
12822         * spu-linux-nat.c: Fix common/ includes.
12823         * sparc-nat.c: Fix common/ includes.
12824         * source.c: Fix common/ includes.
12825         * solib.c: Fix common/ includes.
12826         * solib-target.c: Fix common/ includes.
12827         * ser-unix.c: Fix common/ includes.
12828         * ser-tcp.c: Fix common/ includes.
12829         * ser-pipe.c: Fix common/ includes.
12830         * ser-base.c: Fix common/ includes.
12831         * selftest-arch.c: Fix common/ includes.
12832         * s12z-tdep.c: Fix common/ includes.
12833         * rust-exp.y: Fix common/ includes.
12834         * rs6000-aix-tdep.c: Fix common/ includes.
12835         * riscv-tdep.c: Fix common/ includes.
12836         * remote.c: Fix common/ includes.
12837         * remote-notif.h: Fix common/ includes.
12838         * remote-fileio.h: Fix common/ includes.
12839         * remote-fileio.c: Fix common/ includes.
12840         * regcache.h: Fix common/ includes.
12841         * regcache.c: Fix common/ includes.
12842         * record-btrace.c: Fix common/ includes.
12843         * python/python.c: Fix common/ includes.
12844         * python/py-type.c: Fix common/ includes.
12845         * python/py-inferior.c: Fix common/ includes.
12846         * progspace.h: Fix common/ includes.
12847         * producer.c: Fix common/ includes.
12848         * procfs.c: Fix common/ includes.
12849         * proc-api.c: Fix common/ includes.
12850         * printcmd.c: Fix common/ includes.
12851         * ppc-linux-nat.c: Fix common/ includes.
12852         * parser-defs.h: Fix common/ includes.
12853         * osdata.c: Fix common/ includes.
12854         * obsd-nat.c: Fix common/ includes.
12855         * nat/x86-linux.c: Fix common/ includes.
12856         * nat/x86-linux-dregs.c: Fix common/ includes.
12857         * nat/x86-dregs.h: Fix common/ includes.
12858         * nat/x86-dregs.c: Fix common/ includes.
12859         * nat/ppc-linux.c: Fix common/ includes.
12860         * nat/mips-linux-watch.h: Fix common/ includes.
12861         * nat/mips-linux-watch.c: Fix common/ includes.
12862         * nat/linux-waitpid.c: Fix common/ includes.
12863         * nat/linux-ptrace.h: Fix common/ includes.
12864         * nat/linux-ptrace.c: Fix common/ includes.
12865         * nat/linux-procfs.c: Fix common/ includes.
12866         * nat/linux-personality.c: Fix common/ includes.
12867         * nat/linux-osdata.c: Fix common/ includes.
12868         * nat/linux-namespaces.c: Fix common/ includes.
12869         * nat/linux-btrace.h: Fix common/ includes.
12870         * nat/linux-btrace.c: Fix common/ includes.
12871         * nat/fork-inferior.c: Fix common/ includes.
12872         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12873         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12874         * nat/aarch64-linux.c: Fix common/ includes.
12875         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12876         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12877         * namespace.h: Fix common/ includes.
12878         * mips-linux-tdep.c: Fix common/ includes.
12879         * minsyms.c: Fix common/ includes.
12880         * mi/mi-parse.h: Fix common/ includes.
12881         * mi/mi-main.c: Fix common/ includes.
12882         * mi/mi-cmd-env.c: Fix common/ includes.
12883         * memrange.h: Fix common/ includes.
12884         * memattr.c: Fix common/ includes.
12885         * maint.h: Fix common/ includes.
12886         * maint.c: Fix common/ includes.
12887         * main.c: Fix common/ includes.
12888         * machoread.c: Fix common/ includes.
12889         * location.c: Fix common/ includes.
12890         * linux-thread-db.c: Fix common/ includes.
12891         * linux-nat.c: Fix common/ includes.
12892         * linux-fork.c: Fix common/ includes.
12893         * inline-frame.c: Fix common/ includes.
12894         * infrun.c: Fix common/ includes.
12895         * inflow.c: Fix common/ includes.
12896         * inferior.h: Fix common/ includes.
12897         * inferior.c: Fix common/ includes.
12898         * infcmd.c: Fix common/ includes.
12899         * inf-ptrace.c: Fix common/ includes.
12900         * inf-child.c: Fix common/ includes.
12901         * ia64-linux-nat.c: Fix common/ includes.
12902         * i387-tdep.c: Fix common/ includes.
12903         * i386-tdep.c: Fix common/ includes.
12904         * i386-linux-tdep.c: Fix common/ includes.
12905         * i386-linux-nat.c: Fix common/ includes.
12906         * i386-go32-tdep.c: Fix common/ includes.
12907         * i386-fbsd-tdep.c: Fix common/ includes.
12908         * i386-fbsd-nat.c: Fix common/ includes.
12909         * guile/scm-type.c: Fix common/ includes.
12910         * guile/guile.c: Fix common/ includes.
12911         * go32-nat.c: Fix common/ includes.
12912         * gnu-nat.c: Fix common/ includes.
12913         * gdbthread.h: Fix common/ includes.
12914         * gdbarch-selftests.c: Fix common/ includes.
12915         * gdb_usleep.c: Fix common/ includes.
12916         * gdb_select.h: Fix common/ includes.
12917         * gdb_bfd.c: Fix common/ includes.
12918         * gcore.c: Fix common/ includes.
12919         * fork-child.c: Fix common/ includes.
12920         * findvar.c: Fix common/ includes.
12921         * fbsd-nat.c: Fix common/ includes.
12922         * event-top.c: Fix common/ includes.
12923         * event-loop.c: Fix common/ includes.
12924         * dwarf2read.c: Fix common/ includes.
12925         * dwarf2loc.c: Fix common/ includes.
12926         * dwarf2-frame.c: Fix common/ includes.
12927         * dwarf-index-cache.c: Fix common/ includes.
12928         * dtrace-probe.c: Fix common/ includes.
12929         * disasm-selftests.c: Fix common/ includes.
12930         * defs.h: Fix common/ includes.
12931         * csky-tdep.c: Fix common/ includes.
12932         * cp-valprint.c: Fix common/ includes.
12933         * cp-support.h: Fix common/ includes.
12934         * cp-support.c: Fix common/ includes.
12935         * corelow.c: Fix common/ includes.
12936         * completer.h: Fix common/ includes.
12937         * completer.c: Fix common/ includes.
12938         * compile/compile.c: Fix common/ includes.
12939         * compile/compile-loc2c.c: Fix common/ includes.
12940         * compile/compile-cplus-types.c: Fix common/ includes.
12941         * compile/compile-cplus-symbols.c: Fix common/ includes.
12942         * command.h: Fix common/ includes.
12943         * cli/cli-dump.c: Fix common/ includes.
12944         * cli/cli-cmds.c: Fix common/ includes.
12945         * charset.c: Fix common/ includes.
12946         * build-id.c: Fix common/ includes.
12947         * btrace.h: Fix common/ includes.
12948         * btrace.c: Fix common/ includes.
12949         * breakpoint.h: Fix common/ includes.
12950         * breakpoint.c: Fix common/ includes.
12951         * ax.h:
12952         (enum agent_op): Fix common/ includes.
12953         * ax-general.c (struct aop_map): Fix common/ includes.
12954         * ax-gdb.c: Fix common/ includes.
12955         * auxv.c: Fix common/ includes.
12956         * auto-load.c: Fix common/ includes.
12957         * arm-tdep.c: Fix common/ includes.
12958         * arch/riscv.c: Fix common/ includes.
12959         * arch/ppc-linux-common.c: Fix common/ includes.
12960         * arch/i386.c: Fix common/ includes.
12961         * arch/arm.c: Fix common/ includes.
12962         * arch/arm-linux.c: Fix common/ includes.
12963         * arch/arm-get-next-pcs.c: Fix common/ includes.
12964         * arch/amd64.c: Fix common/ includes.
12965         * arch/aarch64.c: Fix common/ includes.
12966         * arch/aarch64-insn.c: Fix common/ includes.
12967         * arch-utils.c: Fix common/ includes.
12968         * amd64-windows-tdep.c: Fix common/ includes.
12969         * amd64-tdep.c: Fix common/ includes.
12970         * amd64-sol2-tdep.c: Fix common/ includes.
12971         * amd64-obsd-tdep.c: Fix common/ includes.
12972         * amd64-nbsd-tdep.c: Fix common/ includes.
12973         * amd64-linux-tdep.c: Fix common/ includes.
12974         * amd64-linux-nat.c: Fix common/ includes.
12975         * amd64-fbsd-tdep.c: Fix common/ includes.
12976         * amd64-fbsd-nat.c: Fix common/ includes.
12977         * amd64-dicos-tdep.c: Fix common/ includes.
12978         * amd64-darwin-tdep.c: Fix common/ includes.
12979         * agent.c: Fix common/ includes.
12980         * ada-lang.h: Fix common/ includes.
12981         * ada-lang.c: Fix common/ includes.
12982         * aarch64-tdep.c: Fix common/ includes.
12983
12984 2019-01-25  Tom Tromey  <tom@tromey.com>
12985
12986         * common/create-version.sh: Use common/version.h.
12987
12988 2019-01-24  Pedro Alves  <palves@redhat.com>
12989
12990         * infrun.c (signal_stop, signal_print, signal_program)
12991         (signal_catch, signal_pass): Now arrays instead of pointers.
12992         (update_signals_program_target, do_target_resume)
12993         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12994         * linux-nat.c (linux_nat_target::pass_signals)
12995         (linux_nat_target::create_inferior, linux_nat_target::attach):
12996         Adjust.
12997         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12998         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12999         * procfs.c (procfs_target::pass_signals): Adjust.
13000         * record-full.c (record_full_target::resume): Adjust.
13001         * remote.c (remote_target::pass_signals)
13002         (remote_target::program_signals): Adjust.
13003         * target-debug.h (target_debug_print_signals): Now takes a
13004         gdb::array_view as parameter.  Adjust.
13005         * target.h (target_ops) <pass_signals, program_signals>: Replace
13006         pointer and length parameters with gdb::array_view.
13007         (target_pass_signals, target_program_signals): Likewise.
13008         * target-delegates.c: Regenerate.
13009
13010 2019-01-24  Pedro Alves  <palves@redhat.com>
13011
13012         * common/forward-scope-exit.h
13013         (forward_scope_exit::forward_scope_exit): Pass arguments to
13014         m_bind_function directly, instead of creating a std::bind and
13015         copying that.
13016
13017 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13018
13019         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13020         for static members.
13021         (pass_in_v_vfp_candidate): Likewise.
13022
13023 2019-01-23  Tom Tromey  <tom@tromey.com>
13024             Pedro Alves  <palves@redhat.com>
13025
13026         * regcache.c (class regcache_invalidator): Remove.
13027         (regcache::raw_write): Use make_scope_exit.
13028
13029 2019-01-23  Tom Tromey  <tom@tromey.com>
13030
13031         * ui-out.h (class ui_out_emit_type): Update comment.
13032
13033 2019-01-23  Tom Tromey  <tom@tromey.com>
13034
13035         * infrun.c (fetch_inferior_event): Update comment.
13036
13037 2019-01-23  Tom Tromey  <tom@tromey.com>
13038             Pedro Alves  <palves@redhat.com>
13039
13040         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13041         parameter.
13042         (fetch_inferior_event): Use SCOPE_EXIT.
13043
13044
13045 2019-01-23  Tom Tromey  <tom@tromey.com>
13046             Pedro Alves  <palves@redhat.com>
13047
13048         * infrun.c (disable_thread_events): Delete.
13049         (stop_all_threads): Use SCOPE_EXIT.
13050
13051 2019-01-23  Tom Tromey  <tom@tromey.com>
13052             Pedro Alves  <palves@redhat.com>
13053
13054         * symfile.c: Include forward-scope-exit.h.
13055         (clear_symtab_users_cleanup): Replace forward declaration with
13056         a FORWARD_SCOPE_EXIT.
13057         (syms_from_objfile_1): Use the forward_scope_exit and
13058         gdb::optional instead of cleanup_function.
13059         (reread_symbols): Use the forward_scope_exit instead of
13060         cleanup_function.
13061         (clear_symtab_users_cleanup): Remove function.
13062
13063 2019-01-23  Tom Tromey  <tom@tromey.com>
13064             Pedro Alves  <palves@redhat.com>
13065
13066         * linux-nat.c: Include scope-exit.h.
13067         (cleanup_target_stop): Remove.
13068         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13069         SCOPE_EXIT.
13070
13071 2019-01-23  Tom Tromey  <tom@tromey.com>
13072             Pedro Alves  <palves@redhat.com>
13073
13074         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13075         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13076
13077 2019-01-23  Tom Tromey  <tom@tromey.com>
13078             Andrew Burgess  <andrew.burgess@embecosm.com>
13079             Pedro Alves  <palves@redhat.com>
13080
13081         * infrun.c (fetch_inferior_event): Use scope_exit.
13082         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13083         * top.c (execute_command): Use scope_exit.
13084         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13085         * utils.c (do_bpstat_clear_actions_cleanup)
13086         (make_bpstat_clear_actions_cleanup): Remove.
13087
13088 2019-01-23  Tom Tromey  <tom@tromey.com>
13089             Pedro Alves  <palves@redhat.com>
13090
13091         * infrun.c: Include "common/scope-exit.h"
13092         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13093         (wait_for_inferior): Use SCOPE_EXIT.
13094         (fetch_inferior_event): Use scope_exit.
13095
13096 2019-01-23  Tom Tromey  <tom@tromey.com>
13097             Pedro Alves  <palves@redhat.com>
13098
13099         * breakpoint.c (create_breakpoint): Remove cleanup.
13100
13101 2019-01-23  Tom Tromey  <tom@tromey.com>
13102             Andrew Burgess  <andrew.burgess@embecosm.com>
13103             Pedro Alves  <palves@redhat.com>
13104
13105 2019-01-23  Pedro Alves  <palves@redhat.com>
13106
13107         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13108
13109 2019-01-23  Pedro Alves  <palves@redhat.com>
13110             Andrew Burgess  <andrew.burgess@embecosm.com>
13111
13112         * gdbthread.h: Include "common/forward-scope-exit.h".
13113         (scoped_finish_thread_state): Redefine custom class in terms of
13114         forward_scope_exit.
13115
13116 2019-01-23  Pedro Alves  <palves@redhat.com>
13117             Andrew Burgess  <andrew.burgess@embecosm.com>
13118
13119         * common/forward-scope-exit.h: New file.
13120
13121 2019-01-23  Pedro Alves  <palves@redhat.com>
13122             Andrew Burgess  <andrew.burgess@embecosm.com>
13123             Tom Tromey  <tom@tromey.com>
13124
13125         * common/scope-exit.h: New file.
13126
13127 2019-01-23  Pedro Alves  <palves@redhat.com>
13128
13129         * common/preprocessor.h (ESC): Rename to ...
13130         (ESC_PARENS): ... this.
13131         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13132         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13133
13134 2019-01-23  Tom Tromey  <tom@tromey.com>
13135
13136         * language.h (class scoped_switch_to_sym_language_if_auto):
13137         Initialize m_lang in both cases.
13138
13139 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13140
13141         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13142         with XCNEW.
13143
13144 2019-01-22  Tom Tromey  <tom@tromey.com>
13145
13146         * corelow.c: Do not include sys/file.h.
13147
13148 2019-01-22  Tom Tromey  <tom@tromey.com>
13149
13150         * tui/tui-wingeneral.h: Include gdb_curses.h.
13151
13152 2019-01-22  Tom Tromey  <tom@tromey.com>
13153
13154         * source-cache.h (class source_cache) <get_source_lines,
13155         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13156
13157 2019-01-22  Tom Tromey  <tom@tromey.com>
13158
13159         * remote-fileio.h (struct remote_target): Declare.
13160
13161 2019-01-22  Tom Tromey  <tom@tromey.com>
13162
13163         * python/py-arch.c: Do not include py-ref.h.
13164         * python/py-bpevent.c: Do not include py-ref.h.
13165         * python/py-cmd.c: Do not include py-ref.h.
13166         * python/py-continueevent.c: Do not include py-ref.h.
13167         * python/py-event.h: Do not include py-ref.h.
13168         * python/py-evtregistry.c: Do not include py-ref.h.
13169         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13170         * python/py-frame.c: Do not include py-ref.h.
13171         * python/py-framefilter.c: Do not include py-ref.h.
13172         * python/py-function.c: Do not include py-ref.h.
13173         * python/py-infevents.c: Do not include py-ref.h.
13174         * python/py-linetable.c: Do not include py-ref.h.
13175         * python/py-objfile.c: Do not include py-ref.h.
13176         * python/py-param.c: Do not include py-ref.h.
13177         * python/py-prettyprint.c: Do not include py-ref.h.
13178         * python/py-progspace.c: Do not include py-ref.h.
13179         * python/py-symbol.c: Do not include py-ref.h.
13180         * python/py-symtab.c: Do not include py-ref.h.
13181         * python/py-type.c: Do not include py-ref.h.
13182         * python/py-unwind.c: Do not include py-ref.h.
13183         * python/py-utils.c: Do not include py-ref.h.
13184         * python/py-value.c: Do not include py-ref.h.
13185         * python/py-varobj.c: Do not include py-ref.h.
13186         * python/py-xmethods.c: Do not include py-ref.h.
13187         * python/python.c: Do not include py-ref.h.
13188         * varobj.c: Do not include py-ref.h.
13189
13190 2019-01-22  Tom Tromey  <tom@tromey.com>
13191
13192         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13193         keyword for bcache.
13194
13195 2019-01-22  Tom Tromey  <tom@tromey.com>
13196
13197         * compile/compile-cplus-types.c: Remove a comment by #include.
13198
13199 2019-01-22  Tom Tromey  <tom@tromey.com>
13200
13201         * compile/gcc-c-plugin.h: Include compile-internal.h.
13202
13203 2019-01-22  Tom Tromey  <tom@tromey.com>
13204
13205         * stabsread.c (EXTERN): Do not define.
13206         (symnum, next_symbol_text_func, processing_gcc_compilation)
13207         (within_function, global_sym_chain, global_stabs)
13208         (previous_stab_code, this_object_header_files)
13209         (n_this_object_header_files)
13210         (n_allocated_this_object_header_files): Define.
13211         * stabsread.h (EXTERN): Never define.  Use "extern".
13212
13213 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13214
13215         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13216         history_value.
13217
13218 2019-01-21  Tom Tromey  <tom@tromey.com>
13219
13220         * ui-out.c: Fix includes.
13221         * tui/tui-source.c: Fix includes.
13222         * target.c: Fix includes.
13223         * remote.c: Fix includes.
13224         * regcache.c: Fix includes.
13225         * python/py-block.c: Fix includes.
13226         * printcmd.c: Fix includes.
13227         * or1k-tdep.c: Fix includes.
13228         * mi/mi-main.c: Fix includes.
13229         * m32r-tdep.c: Fix includes.
13230         * csky-tdep.c: Fix includes.
13231         * compile/compile-cplus-types.c: Fix includes.
13232         * cli/cli-interp.c: Fix includes.
13233
13234 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13235
13236         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13237         for padding.
13238
13239 2019-01-16  Tom Tromey  <tom@tromey.com>
13240
13241         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13242         earlier.
13243         (struct objfile) <msymbols_range>: Move from top level.
13244         <msymbols>: New method.
13245         (class objfile_msymbols): Remove.
13246         * symtab.c (default_collect_symbol_completion_matches_break_on):
13247         Update.
13248         * symmisc.c (dump_msymbols): Update.
13249         * stabsread.c (scan_file_globals): Update.
13250         * objc-lang.c (info_selectors_command, info_classes_command)
13251         (find_methods): Update.
13252         * minsyms.c (find_solib_trampoline_target): Update.
13253         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13254         * coffread.c (coff_symfile_read): Update.
13255         * ada-lang.c (ada_lookup_simple_minsym)
13256         (ada_collect_symbol_completion_matches): Update.
13257
13258 2019-01-16  Tom Tromey  <tom@tromey.com>
13259
13260         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13261         type.  Remove no-argument constructor.
13262         <iterator::operator++>: Simplify.
13263         <begin>: Update.
13264         <end>: Use minimal_symbol_count.
13265
13266 2019-01-16  Tom Tromey  <tom@tromey.com>
13267
13268         * objfiles.h (struct objfile) <psymtabs>: New method.
13269         (class objfile_psymtabs): Remove.
13270         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13271         typedef.
13272         <range>: New method.
13273         (require_partial_symbols): Change return type.
13274         * psymtab.c (require_partial_symbols)
13275         (psym_expand_symtabs_matching): Update.
13276         * mdebugread.c (parse_partial_symbols): Update.
13277         * dbxread.c (dbx_end_psymtab): Update.
13278
13279 2019-01-15  Tom Tromey  <tom@tromey.com>
13280
13281         * symtab.c (lookup_objfile_from_block)
13282         (lookup_symbol_in_objfile_symtabs)
13283         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13284         (find_line_symtab, info_sources_command)
13285         (default_collect_symbol_completion_matches_break_on)
13286         (make_source_files_completion_list): Update.
13287         * symmisc.c (print_objfile_statistics, dump_objfile)
13288         (maintenance_print_symbols, maintenance_info_symtabs)
13289         (maintenance_check_symtabs, maintenance_info_line_tables):
13290         Update.
13291         * source.c (select_source_symtab)
13292         (forget_cached_source_info_for_objfile): Update.
13293         * objfiles.h (class objfile_compunits): Remove.
13294         (struct objfile) <compunits_range>: New typedef.
13295         (compunits): New method.
13296         * objfiles.c (objfile_relocate1): Update.
13297         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13298         * maint.c (count_symtabs_and_blocks): Update.
13299         * linespec.c (iterate_over_all_matching_symtabs): Update.
13300         * cp-support.c (add_symbol_overload_list_qualified): Update.
13301         * coffread.c (coff_symtab_read): Update.
13302         * ada-lang.c (add_nonlocal_symbols)
13303         (ada_collect_symbol_completion_matches)
13304         (ada_add_global_exceptions): Update.
13305
13306 2019-01-15  Tom Tromey  <tom@tromey.com>
13307
13308         * progspace.h (program_space) <objfiles_safe_range>: New
13309         typedef.
13310         <objfiles_safe>: New method.
13311         * objfiles.h (class all_objfiles_safe): Remove.
13312         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13313         * jit.c (jit_inferior_exit_hook): Update.
13314
13315 2019-01-17  Tom Tromey  <tom@tromey.com>
13316
13317         * progspace.h (program_space) <objfiles_range>: New typedef.
13318         <objfiles>: New method.
13319         <objfiles_head>: Rename from objfiles.
13320         (object_files): Update.
13321         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13322         * guile/scm-pretty-print.c
13323         (ppscm_find_pretty_printer_from_objfiles): Update.
13324         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13325         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13326         Update.
13327         * python/py-progspace.c (pspy_get_objfiles): Update.
13328         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13329         Update.
13330         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13331         (objfpy_lookup_objfile_by_build_id): Update.
13332         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13333         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13334         Update.
13335         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13336         (expand_symtab_containing_pc, lookup_objfile_from_block)
13337         (lookup_static_symbol, basic_lookup_transparent_type)
13338         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13339         (find_line_symtab, info_sources_command)
13340         (default_collect_symbol_completion_matches_break_on)
13341         (make_source_files_completion_list, find_main_name): Update.
13342         * symmisc.c (print_symbol_bcache_statistics)
13343         (print_objfile_statistics, maintenance_print_symbols)
13344         (maintenance_print_msymbols, maintenance_print_objfiles)
13345         (maintenance_info_symtabs, maintenance_check_symtabs)
13346         (maintenance_expand_symtabs, maintenance_info_line_tables):
13347         Update.
13348         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13349         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13350         (map_overlay_command, unmap_overlay_command)
13351         (simple_overlay_update, expand_symtabs_matching)
13352         (map_symbol_filenames): Update.
13353         * symfile-debug.c (set_debug_symfile): Update.
13354         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13355         Update.
13356         * source.c (select_source_symtab, forget_cached_source_info):
13357         Update.
13358         * solib.c (solib_read_symbols): Update.
13359         * solib-spu.c (append_ocl_sos): Update.
13360         * psymtab.c (maintenance_print_psymbols)
13361         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13362         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13363         * printcmd.c (info_symbol_command): Update.
13364         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13365         Update.
13366         * objfiles.h (class all_objfiles): Remove.
13367         * objfiles.c (have_partial_symbols, have_full_symbols)
13368         (have_minimal_symbols, qsort_cmp, update_section_map)
13369         (shared_objfile_contains_address_p)
13370         (default_iterate_over_objfiles_in_search_order): Update.
13371         * objc-lang.c (info_selectors_command, info_classes_command)
13372         (find_methods): Update.
13373         * minsyms.c (find_solib_trampoline_target): Update.
13374         * maint.c (maintenance_info_sections)
13375         (maintenance_translate_address, count_symtabs_and_blocks):
13376         Update.
13377         * main.c (captured_main_1): Update.
13378         * linux-thread-db.c (try_thread_db_load_from_pdir)
13379         (has_libpthread): Update.
13380         * linespec.c (iterate_over_all_matching_symtabs)
13381         (search_minsyms_for_name): Update.
13382         * jit.c (jit_find_objf_with_entry_addr): Update.
13383         * hppa-tdep.c (find_unwind_entry)
13384         (hppa_lookup_stub_minimal_symbol): Update.
13385         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13386         Update.
13387         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13388         (elf_gnu_ifunc_resolve_by_got): Update.
13389         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13390         * dwarf-index-write.c (save_gdb_index_command): Update.
13391         * cp-support.c (add_symbol_overload_list_qualified): Update.
13392         * breakpoint.c (create_overlay_event_breakpoint)
13393         (create_longjmp_master_breakpoint)
13394         (create_std_terminate_master_breakpoint)
13395         (create_exception_master_breakpoint): Update.
13396         * blockframe.c (find_pc_partial_function): Update.
13397         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13398         (ada_collect_symbol_completion_matches)
13399         (ada_add_global_exceptions): Update.
13400
13401 2019-01-17  Tom Tromey  <tom@tromey.com>
13402
13403         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13404         declare VEC.
13405         (solib_target_parse_libraries): Change return type.
13406         (library_list_start_segment, library_list_start_section)
13407         (library_list_end_library, library_list_start_library); Update.
13408         (solib_target_free_library_list): Remove.
13409         (solib_target_parse_libraries): Remove cleanup.  Change return
13410         type.
13411         (solib_target_current_sos): Update.
13412
13413 2019-01-17  Tom Tromey  <tromey@bapiya>
13414
13415         * valprint.c: Replace "the the" with "the".
13416         * symtab.c: Replace "the the" with "the".
13417         * solib.c: Replace "the the" with "the".
13418         * solib-dsbt.c: Replace "the the" with "the".
13419         * linespec.c: Replace "the the" with "the".
13420         * dwarf2loc.h: Replace "the the" with "the".
13421         * amd64-windows-tdep.c: Replace "the the" with "the".
13422         * aarch64-tdep.c: Replace "the the" with "the".
13423
13424 2019-01-16  Keith Seitz  <keiths@redhat.com>
13425
13426         PR gdb/23773
13427         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13428         <builder>: Rename to ..
13429         <m_builder>: ... this and make private.
13430         (dwarf2_cu::get_builder): New method.  Change all users of
13431         `builder' to use this method.
13432         (dwarf2_start_symtab): Move to ...
13433         (dwarf2_cu::start_symtab): ... here.  Update all callers
13434         (setup_type_unit_groups): Move to ...
13435         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13436         callers.
13437         (dwarf2_cu::reset_builder): New method.
13438         (process_full_compunit, process_full_type_unit): Use
13439         dwarf2_cu::reset_builder.
13440         (follow_die_offset): Record the ancestor CU if it is different
13441         from the followed DIE's CU.
13442         (follow_die_sig_1): Likewise.
13443
13444 2019-01-15  Tom Tromey  <tom@tromey.com>
13445
13446         * remote.c (class remote_state) <buf>: Now a char_vector.
13447         <buf_size>: Remove.
13448         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13449         parameter.
13450         (remote_target::getpkt_or_notif_sane_1)
13451         (remote_target::getpkt_sane)
13452         (remote_target::getpkt_or_notif_sane): Likewise.
13453         (class remote_target) <putpkt>: New overload.
13454         (remote_target::read_frame): Change type of "buf_p".  Remove
13455         sizeof_p parameter.
13456         (packet_ok): New overload.
13457         (packet_check_result): New overload.
13458         Update all uses.
13459
13460 2019-01-14  Tom Tromey  <tom@tromey.com>
13461
13462         * remote-notif.c (handle_notification, remote_notif_ack)
13463         (remote_notif_parse): Make "buf" const.
13464         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13465         const.
13466         (remote_notif_parse, remote_notif_ack, handle_notification):
13467         Likewise.
13468         * remote.c (remote_notif_stop_parse): Make "buf" const.
13469         (remote_target::remote_parse_stop_reply): Make "buf" const.
13470         (remote_notif_stop_ack): Make "buf" const.
13471
13472 2019-01-14  Tom Tromey  <tom@tromey.com>
13473
13474         * remote.c (remote_console_output): Make parameter const.
13475
13476 2019-01-14  Tom Tromey  <tom@tromey.com>
13477
13478         * target-debug.h (target_debug_print_signals): Constify.
13479         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13480         * procfs.c (procfs_target::pass_signals): Update.
13481         * linux-nat.c (linux_nat_target::pass_signals): Update.
13482         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13483         * target-delegates.c: Rebuild.
13484         * remote.c (remote_target::program_signals): Update.
13485         (remote_target::pass_signals): Update.
13486         * target.c (target_pass_signals): Constify argument.
13487         (target_program_signals): Likewise.
13488         * target.h (struct target_ops) <pass_signals, program_signals>:
13489         Constify argument.
13490         (target_pass_signals, target_program_signals): Constify argument.
13491
13492 2019-01-14  Tom Tromey  <tom@tromey.com>
13493
13494         PR tui/28819:
13495         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13496
13497 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13498
13499         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13500         field.
13501         * rs6000-tdep.c: Include reggroups.h.
13502         (IS_V_ALIAS_PSEUDOREG): Define.
13503         (rs6000_register_name): Return names for the "vX" aliases.
13504         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13505         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13506         aliases.  Call default_register_reggroup_p for all other
13507         pseudo-registers.
13508         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13509         New functions.
13510         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13511         Handle "vX" aliases.
13512         (v_alias_pseudo_register_collect): New function.
13513         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13514         (rs6000_gdbarch_init): Initialize "vX" aliases as
13515         pseudo-registers.  Restore registration of
13516         rs6000_pseudo_register_reggroup_p with
13517         set_tdesc_pseudo_register_reggroup_p.
13518
13519 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13520
13521         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13522         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13523         set_gdbarch_num_pseudo_regs.
13524
13525 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13526
13527         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13528         Remove arg prefixname, add do_set and do_show.
13529         Add member functions set_list and show_list.
13530         * cli/cli-style.c (class cli_style_option): Update accordingly.
13531         (style_set_list): Move to file scope.
13532         (style_show_list): Likewise.
13533         (set_style): Call help_list.
13534         (show_style): Call cmd_show_list.
13535         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13536         Update to use the new macro.
13537
13538 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13539
13540         * ada-lang.c (_initialize_ada_language): Expand the help text
13541         for the "catch exception" command.
13542
13543 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13544
13545         * symtab.c (matching_obj_sections): Initialize obj,
13546         declare it closer to its usage.
13547
13548 2019-01-10  Tom Tromey  <tom@tromey.com>
13549
13550         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13551         (basic_inf_threads_range): Remove.
13552         (inf_threads_range, inf_non_exited_threads_range)
13553         (safe_inf_threads_range): Use next_adapter.
13554
13555 2019-01-10  Keith Seitz  <keiths@redhat.com>
13556
13557         PR gdb/23712
13558         PR symtab/23010
13559         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13560         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13561
13562 2019-01-10  Keith Seitz  <keiths@redhat.com>
13563
13564         PR gdb/23712
13565         PR symtab/23010
13566         * dictionary.c (pending_to_vector): Remove.
13567         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13568         Remove _1 suffix, replacing functions of the same name.  Update
13569         all callers.
13570         (dict_create_hashed, dict_create_hashed_expandable)
13571         (dict_create_linear, dict_create_linear_expandable, dict_free)
13572         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13573         Make functions static.
13574
13575 2019-01-10  Keith Seitz  <keiths@redhat.com>
13576
13577         PR gdb/23712
13578         PR symtab/23010
13579         * dictionary.h (struct dictionary): Replace declaration with
13580         multidictionary.
13581         (dict_create_hashed, dict_create_hashed_expandable)
13582         (dict_create_linear, dict_create_linear_expandable)
13583         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13584         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13585         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13586         taking multidictionary argument.
13587         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13588         * block.h (struct block) <dict>: Change to multidictionary
13589         and rename `multidict'.
13590         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13591         symmisc.c: Update all dictionary references to multidictionary.
13592
13593 2019-01-10  Keith Seitz  <keiths@redhat.com>
13594
13595         PR gdb/23712
13596         PR symtab/23010
13597         * dictionary.c: Include unordered_map.
13598         (pending_to_vector): New function.
13599         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13600         Rewrite the non-"_1" functions to take vector instead
13601         of linked list.
13602         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13603         "new" _1 versions of the same name.
13604         (multidictionary): Define.
13605         (std::hash<enum language): New definition.
13606         (collate_pending_symbols_by_language, mdict_create_hashed)
13607         (mdict_create_hashed_expandable, mdict_create_linear)
13608         (mdict_create_linear_expandable, mdict_free)
13609         (find_language_dictionary, create_new_language_dictionary)
13610         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13611         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13612         (mdict_size, mdict_empty): New functions.
13613         * dictionary.h (mdict_iterator): Define.
13614
13615 2019-01-10  Pedro Alves  <palves@redhat.com>
13616
13617         * breakpoint.c (read_uploaded_action)
13618         (create_tracepoint_from_upload): Adjust to use
13619         gdb::unique_xmalloc_ptr.
13620         * ctf.c (ctf_write_uploaded_tp):
13621         (SET_ARRAY_FIELD): Use emplace_back.
13622         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13623         * tracefile-tfile.c (tfile_write_uploaded_tp):
13624         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13625         gdb::unique_xmalloc_ptr.
13626         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13627         at_string, cond_string, cmd_strings>: Replace char pointers
13628         with gdb::unique_xmalloc_ptr.
13629
13630 2019-01-10  Pedro Alves  <palves@redhat.com>
13631
13632         * solib-target.c (library_list_start_library): Don't xstrdup name.
13633
13634 2019-01-10  Pedro Alves  <palves@redhat.com>
13635
13636         * mdebugread.c (parse_partial_symbols): Use
13637         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13638
13639 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13640
13641         * linux-fork.c (scoped_switch_fork_info)
13642         <~scoped_switch_fork_info>: Fix incorrect variable name.
13643
13644 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13645
13646         * linux-fork.c (scoped_switch_fork_info)
13647         <scoped_switch_fork_info>: Make explicit.
13648         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13649
13650 2019-01-10  Tom Tromey  <tom@tromey.com>
13651
13652         * objfiles.h (objfile::reset_psymtabs): Update.
13653         * objfiles.c (objfile::objfile): Update.
13654         * psymtab.h (psymtab_storage::obstack): Update.
13655         (psymtab_storage::m_obstack): Use gdb::optional.
13656         (class psymtab_storage): Update comment.  Remove objfile
13657         parameter.
13658         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13659
13660 2019-01-10  Tom Tromey  <tom@tromey.com>
13661
13662         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13663         <free_psymtabs>: Now private.
13664         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13665         (allocate_psymtab): Use new method.
13666
13667 2019-01-10  Tom Tromey  <tom@tromey.com>
13668
13669         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13670         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13671         * mdebugread.c (parse_partial_symbols): Use
13672         allocate_dependencies.
13673         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13674         allocate_dependencies.
13675         (process_psymtab_comp_unit_reader)
13676         (build_type_psymtab_dependencies): Likewise.
13677         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13678
13679 2019-01-10  Tom Tromey  <tom@tromey.com>
13680
13681         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13682         PSYMBOL_SET_LANGUAGE.
13683         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13684
13685 2019-01-10  Tom Tromey  <tom@tromey.com>
13686
13687         * psymtab.h (psymtab_storage::obstack): New method.
13688         <m_obstack>: Rename from obstack; now private.
13689         * psymtab.c (psymtab_storage): Update.
13690         * dwarf2read.c (create_addrmap_from_index)
13691         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13692         Update.
13693
13694 2019-01-10  Tom Tromey  <tom@tromey.com>
13695
13696         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13697         * objfiles.h (objfile::reset_psymtabs): New method.
13698
13699 2019-01-10  Tom Tromey  <tom@tromey.com>
13700
13701         * symmisc.c (print_symbol_bcache_statistics): Update.
13702         (print_objfile_statistics): Update.
13703         * symfile.c (reread_symbols): Update.
13704         * psymtab.h (class psymtab_storage): New.
13705         * psymtab.c (psymtab_storage): New constructor.
13706         (~psymtab_storage): New destructor.
13707         (require_partial_symbols): Update.
13708         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13709         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13710         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13711         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13712         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13713         (start_psymtab_common, end_psymtab_common)
13714         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13715         (allocate_psymtab): Update.
13716         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13717         Update.
13718         (dump_psymtab_addrmap, maintenance_print_psymbols)
13719         (maintenance_check_psymtabs): Update.
13720         (class objfile_psymtabs): Move to objfiles.h.
13721         * psympriv.h (discard_psymtab): Now inline.
13722         (psymtab_discarder::psymtab_discarder): Update.
13723         (psymtab_discarder::~psymtab_discarder): Update.
13724         (ALL_OBJFILE_PSYMTABS): Rewrite.
13725         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13726         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13727         Remove fields.
13728         <partial_symtabs>: New field.
13729         (class objfile_psymtabs): Move from psymtab.h.  Update.
13730         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13731         psymbol_cache.
13732         (objfile::~objfile): Don't destroy psymbol_cache.
13733         * mdebugread.c (parse_partial_symbols): Update.
13734         * dwarf2read.c (create_addrmap_from_index)
13735         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13736         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13737         (add_partial_subprogram, dwarf2_ranges_read): Update.
13738         * dwarf-index-write.c (write_address_map)
13739         (write_one_signatured_type, recursively_write_psymbols)
13740         (class debug_names, class debug_names, write_psymtabs_to_index):
13741         Update.
13742
13743 2019-01-10  Tom Tromey  <tom@tromey.com>
13744
13745         * symtab.h (SYMBOL_SET_NAMES): Update.
13746         (symbol_set_names): Update.
13747         (MSYMBOL_SET_NAMES): Update.
13748         * symtab.c (symbol_set_names): Change argument to be an
13749         objfile_per_bfd_storage.
13750         * psymtab.c (add_psymbol_to_bcache): Update.
13751         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13752
13753 2019-01-10  Tom Tromey  <tom@tromey.com>
13754
13755         * symtab.c (create_demangled_names_hash): Change argument to be an
13756         objfile_per_bfd_storage.
13757         (symbol_set_names): Update.
13758
13759 2019-01-10  Tom Tromey  <tom@tromey.com>
13760
13761         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13762         init_psymbol_list.
13763         * psymtab.c (init_psymbol_list): Do nothing if already called.
13764         * psympriv.h (init_psymbol_list): Add comment.
13765         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13766         init_psymbol_list.
13767         * dbxread.c (dbx_symfile_read): Unconditionally call
13768         init_psymbol_list.
13769
13770 2019-01-10  Tom Tromey  <tom@tromey.com>
13771
13772         * xcoffread.c (scan_xcoff_symtab): Update.
13773         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13774         "where".
13775         * mdebugread.c (parse_partial_symbols)
13776         (handle_psymbol_enumerators): Update.
13777         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13778         * dbxread.c (read_dbx_symtab): Update.
13779         * psympriv.h (psymbol_placement): New enum.
13780         (add_psymbol_to_list): Update.
13781
13782 2019-01-10  Tom Tromey  <tom@tromey.com>
13783
13784         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13785         static_psymbols parameters.
13786         (scan_xcoff_symtab): Update.
13787         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13788         static_psymbols parameters.
13789         * psympriv.h (start_psymtab_common): Update.
13790         * mdebugread.c (parse_partial_symbols): Update.
13791         * dwarf2read.c (create_partial_symtab): Update.
13792         * dbxread.c (read_dbx_symtab): Update.
13793         (start_psymtab): Remove global_psymbols and static_psymbols
13794         parameters.
13795
13796 2019-01-10  Tom Tromey  <tom@tromey.com>
13797
13798         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13799         * psymtab.c (allocate_psymtab): Add comment.
13800         * psympriv.h (allocate_psymtab): Add comment.
13801         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13802         initializations.
13803         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13804
13805 2019-01-10  Tom Tromey  <tom@tromey.com>
13806
13807         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13808         Don't declare.
13809         * mipsread.c: Include mdebugread.h.
13810         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13811         Declare.
13812         * elfread.c: Include mdebugread.h.
13813
13814 2019-01-09  Tom Tromey  <tom@tromey.com>
13815
13816         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13817         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13818         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13819         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13820         (psym_lookup_symbol, psym_find_last_source_symtab)
13821         (psym_forget_cached_source_info, psym_print_stats)
13822         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13823         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13824         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13825         (psym_find_compunit_symtab_by_address)
13826         (maintenance_print_psymbols, maintenance_info_psymtabs)
13827         (maintenance_check_psymtabs): Use ranged for.
13828         * psymtab.h (class objfile_psymtabs): New.
13829         (require_partial_symbols): Return objfile_psymtabs.
13830         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13831
13832 2019-01-09  Tom Tromey  <tom@tromey.com>
13833
13834         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13835         (find_pc_mapped_section, list_overlays_command)
13836         (map_overlay_command, unmap_overlay_command)
13837         (simple_overlay_update): Use all_objfiles.
13838         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13839         * printcmd.c (info_symbol_command): Use all_objfiles.
13840         * objfiles.h (ALL_OBJSECTIONS): Remove.
13841         * maint.c (maintenance_translate_address): Use all_objfiles.
13842         * gcore.c (gcore_create_callback): Use all_objfiles.
13843         (objfile_find_memory_regions): Likewise.
13844
13845 2019-01-09  Tom Tromey  <tom@tromey.com>
13846
13847         * symtab.c (find_line_symtab, info_sources_command)
13848         (make_source_files_completion_list): Use objfile_compunits.
13849         * source.c (select_source_symtab): Use objfile_compunits.
13850         * objfiles.h (struct objfile): Update comment.
13851         (ALL_OBJFILES): Remove.
13852         (ALL_FILETABS): Remove.
13853         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13854         objfile_compunits.
13855
13856 2019-01-09  Tom Tromey  <tom@tromey.com>
13857
13858         * symmisc.c (print_objfile_statistics, dump_objfile)
13859         (maintenance_print_symbols): Use compunit_filetabs.
13860         * source.c (forget_cached_source_info_for_objfile): Use
13861         compunit_filetabs.
13862         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13863         (ALL_FILETABS): Use compunit_filetabs.
13864         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13865         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13866
13867 2019-01-09  Tom Tromey  <tom@tromey.com>
13868
13869         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13870         (compunit_filetabs): New.
13871         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13872         compunit_filetabs.
13873         (info_sources_command, make_source_files_completion_list): Remove
13874         declaration.
13875         * symmisc.c (print_objfile_statistics, dump_objfile)
13876         (maintenance_print_symbols): Remove declaration.
13877         (maintenance_info_symtabs): Use compunit_filetabs.
13878         (maintenance_info_line_tables): Likewise.
13879         * source.c (select_source_symtab): Change local variable name.
13880         (forget_cached_source_info_for_objfile): Remove declaration.
13881         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13882         * objfiles.c (objfile_relocate1): Remove declaration.
13883         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13884         declaration.
13885         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13886         * coffread.c (coff_symtab_read): Remove declaration.
13887         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13888         compunit_filetabs.
13889
13890 2019-01-09  Tom Tromey  <tom@tromey.com>
13891
13892         * symtab.c (lookup_objfile_from_block)
13893         (find_pc_sect_compunit_symtab, search_symbols)
13894         (default_collect_symbol_completion_matches_break_on): Use
13895         objfile_compunits.
13896         * objfiles.h (ALL_COMPUNITS): Remove.
13897         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13898         * cp-support.c (add_symbol_overload_list_qualified): Use
13899         objfile_compunits.
13900         * ada-lang.c (ada_collect_symbol_completion_matches)
13901         (ada_add_global_exceptions): Use objfile_compunits.
13902
13903 2019-01-09  Tom Tromey  <tom@tromey.com>
13904
13905         * source.c (select_source_symtab)
13906         (forget_cached_source_info_for_objfile): Remove declaration.
13907         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13908         declaration.
13909         * maint.c (count_symtabs_and_blocks): Remove declaration.
13910         * cp-support.c (add_symbol_overload_list_qualified): Remove
13911         declaration.
13912         * coffread.c (coff_symtab_read): Remove declaration.
13913         * symtab.c (lookup_symbol_in_objfile_symtabs)
13914         (basic_lookup_transparent_type_1): Use objfile_compunits.
13915         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13916         (info_sources_command, search_symbols)
13917         (default_collect_symbol_completion_matches_break_on)
13918         (make_source_files_completion_list): Remove declaration.
13919         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13920         (ada_collect_symbol_completion_matches)
13921         (ada_add_global_exceptions): Remove declaration.
13922         * linespec.c (iterate_over_all_matching_symtabs): Use
13923         objfile_compunits.
13924         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13925         (class objfile_compunits): New.
13926         (ALL_COMPUNITS): Use objfile_compunits.
13927         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13928         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13929         objfile_compunits.
13930         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13931
13932 2019-01-09  Tom Tromey  <tom@tromey.com>
13933
13934         * symtab.c (search_symbols)
13935         (default_collect_symbol_completion_matches_break_on): Use
13936         objfile_msymbols.
13937         * ada-lang.c (ada_lookup_simple_minsym)
13938         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13939         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13940         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13941         objfile_msymbols.
13942         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13943         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13944         * objc-lang.c (find_methods): Use objfile_msymbols.
13945         (info_selectors_command, info_classes_command): Likewise.
13946         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13947         * objfiles.h (class objfile_msymbols): New.
13948         (ALL_OBJFILE_MSYMBOLS): Remove.
13949         (ALL_MSYMBOLS): Remove.
13950
13951 2019-01-09  Tom Tromey  <tom@tromey.com>
13952
13953         * common/next-iterator.h (next_adapter): Add Iterator template
13954         parameter.
13955         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13956         (class all_objfiles_safe): New.
13957         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13958         * objfiles.c (put_objfile_before): Update comment.
13959         (add_separate_debug_objfile): Likewise.
13960         (free_all_objfiles): Use all_objfiles_safe.
13961         (objfile_purge_solibs): Likewise.
13962
13963 2019-01-09  Tom Tromey  <tom@tromey.com>
13964
13965         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13966         (expand_symtab_containing_pc, lookup_static_symbol)
13967         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13968         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13969         all_objfiles.
13970         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13971         * breakpoint.c (create_overlay_event_breakpoint)
13972         (create_longjmp_master_breakpoint)
13973         (create_std_terminate_master_breakpoint)
13974         (create_exception_master_breakpoint): Use all_objfiles.
13975         * linux-thread-db.c (try_thread_db_load_from_pdir)
13976         (has_libpthread): Use all_objfiles.
13977         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13978         * linespec.c (iterate_over_all_matching_symtabs)
13979         (search_minsyms_for_name): Use all_objfiles.
13980         * maint.c (maintenance_info_sections): Use all_objfiles.
13981         * main.c (captured_main_1): Use all_objfiles.
13982         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13983         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13984         * guile/scm-pretty-print.c
13985         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13986         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13987         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13988         (maintenance_print_msymbols): Use all_objfiles.
13989         * source.c (select_source_symtab): Use all_objfiles.
13990         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13991         * symfile.c (remove_symbol_file_command)
13992         (expand_symtabs_matching, map_symbol_filenames): Use
13993         all_objfiles.
13994         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13995         all_objfiles.
13996         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13997         * objc-lang.c (find_methods): Use all_objfiles.
13998         * objfiles.c (have_partial_symbols, have_full_symbols)
13999         (have_minimal_symbols, qsort_cmp)
14000         (default_iterate_over_objfiles_in_search_order): Use
14001         all_objfiles.
14002         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14003         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14004         (maintenance_check_psymtabs): Use all_objfiles.
14005         (ALL_PSYMTABS): Remove.
14006         * compile/compile-object-run.c (do_module_cleanup): Use
14007         all_objfiles.
14008         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14009         * cp-support.c (add_symbol_overload_list_qualified): Use
14010         all_objfiles.
14011         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14012         Use all_objfiles.
14013         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14014         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14015         all_objfiles.
14016         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14017         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14018         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14019         Uses all_objfiles.
14020         * solib.c (solib_read_symbols): Use all_objfiles
14021
14022 2019-01-09  Tom Tromey  <tom@tromey.com>
14023
14024         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14025         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14026         all_objfiles.
14027         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14028         * symmisc.c (print_symbol_bcache_statistics)
14029         (print_objfile_statistics, maintenance_print_objfiles)
14030         (maintenance_info_symtabs, maintenance_check_symtabs)
14031         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14032         all_objfiles.
14033         * source.c (forget_cached_source_info): Use all_objfiles.
14034         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14035         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14036         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14037         * objfiles.c (update_section_map): Use all_objfiles.
14038         (shared_objfile_contains_address_p): Likewise.
14039         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14040         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14041
14042 2019-01-09  Tom Tromey  <tom@tromey.com>
14043
14044         * common/next-iterator.h: New file.
14045         * objfiles.h (class all_objfiles): New.
14046         (struct objfile_iterator): New.
14047
14048 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14049
14050         * NEWS: Move the description of the changed "frame", "select-frame",
14051          and "info frame" commands to the Changed commands section.
14052
14053 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14054
14055         * gdbtypes.c (check_stub_method_group): Remove handling of old
14056         mangling schemes.
14057         * linespec.c (find_methods): Likewise.
14058         * stabsread.c (read_member_functions): Likewise.
14059         * valops.c (search_struct_method): Likewise.
14060         (value_struct_elt_for_reference): Likewise.
14061         * NEWS: Mention this change.
14062
14063 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14064
14065         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14066         print_source_lines.
14067         * source.c (print_source_lines_base): Update line number check.
14068         (print_source_lines): New function.
14069         (source_lines_range::source_lines_range): New function.
14070         * source.h (class source_lines_range): New class.
14071         (print_source_lines): New declaration.
14072
14073 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14074
14075         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14076
14077 2019-01-08  Tom Tromey  <tom@tromey.com>
14078             Simon Marchi  <simon.marchi@ericsson.com>
14079
14080         PR gdb/24060
14081         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14082         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14083         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14084         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14085         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14086         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14087
14088 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14089
14090         * source.c (select_source_symtab): Move header comment to
14091         declaration in source.h.
14092         (forget_cached_source_info_for_objfile): Likewise.
14093         (forget_cached_source_info): Likewise.
14094         (identify_source_line): Likewise.
14095         * source.h (identify_source_line): Move declaration from symtab.h
14096         and add comment from source.c
14097         (print_source_lines): Likewise.
14098         (forget_cached_source_info_for_objfile): Likewise.
14099         (forget_cached_source_info): Likewise.
14100         (select_source_symtab): Likewise.
14101         (enum print_source_lines_flag): Move definition from symtab.h.
14102         * symtab.h (identify_source_line): Move declaration to source.h.
14103         (print_source_lines): Likewise.
14104         (forget_cached_source_info_for_objfile): Likewise.
14105         (forget_cached_source_info): Likewise.
14106         (select_source_symtab): Likewise.
14107         (enum print_source_lines_flag): Move definition to source.h.
14108         * tui/tui-hooks.c: Add 'source.h' include.
14109
14110 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14111
14112         * source.c (print_source_lines_base): Handle requests to print
14113         reverse line number sequences, and guard against empty lines
14114         string.
14115
14116 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14117
14118         * source.c (print_source_lines_base): Fix skip of '\r' if next
14119         character is '\n'.
14120
14121 2019-01-06  Tom Tromey  <tom@tromey.com>
14122
14123         * c-exp.y (struct c_parse_state) <macro_original_text,
14124         expansion_obstack>: New member.
14125         (macro_original_text, expansion_obstack): Remove globals.
14126         (scan_macro_expansion, scanning_macro_expansion)
14127         (finished_macro_expansion): Update.
14128         (scan_macro_cleanup): Remove.
14129         (yylex, c_parse): Update.
14130
14131 2019-01-06  Tom Tromey  <tom@tromey.com>
14132
14133         * c-exp.y (struct c_parse_state) <strings>: New member.
14134         (operator_stoken): Update.
14135
14136 2019-01-06  Tom Tromey  <tom@tromey.com>
14137
14138         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14139         (union type_stack_elt) <typelist_val>: Now a pointer to
14140         std::vector.
14141         (type_stack_cleanup): Don't declare.
14142         (push_typelist): Update.
14143         * parse.c (pop_typelist): Return a std::vector.
14144         (push_typelist): Take a std::vector.
14145         (follow_types): Update.  Do not free args.
14146         (type_stack_cleanup): Remove.
14147         * c-exp.y (struct c_parse_state): New.
14148         (cpstate): New global.
14149         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14150         (nonempty_typelist): Update.
14151         (func_mod): Create a new vector.
14152         (c_parse): Create a c_parse_state.
14153         (check_parameter_typelist): Do not delete params.
14154         (function_method): Update.  Do not delete type_list.
14155
14156 2019-01-06  Tom Tromey  <tom@tromey.com>
14157
14158         PR gdb/28155:
14159         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14160         check_typedef.
14161         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14162         (print_return_value): Likewise.
14163
14164 2019-01-05  Tom Tromey  <tom@tromey.com>
14165
14166         * contrib/cleanup_check.py: Remove.
14167         * contrib/gcc-with-excheck: Remove.
14168         * contrib/exsummary.py: Remove.
14169         * contrib/excheck.py: Remove.
14170
14171 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14172
14173         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14174         NULL. Initialize tpprev to NULL instead of assigning it
14175         to NULL on the next statement.
14176         * windows-nat.c (windows_delete_thread): Remove check for
14177         main_thread_id before printing thread exit notifications.
14178         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14179         Remove thread ID check against main_thread_id.
14180         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14181         windows_delete_thread.
14182         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14183
14184 2019-01-04  Tom Tromey  <tom@tromey.com>
14185
14186         * compile/compile.c (_initialize_compile): Use upper case for
14187         metasyntactic variables.
14188         * symmisc.c (_initialize_symmisc): Use upper case for
14189         metasyntactic variables.
14190         * psymtab.c (_initialize_psymtab): Use upper case for
14191         metasyntactic variables.
14192         * demangle.c (demangle_command): Use upper case for metasyntactic
14193         variables.
14194         (_initialize_demangler): Likewise.
14195         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14196         variables.
14197
14198 2019-01-03  Tom Tromey  <tom@tromey.com>
14199
14200         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14201
14202 2019-01-03  Tom Tromey  <tom@tromey.com>
14203
14204         * python/py-symtab.c (salpy_str): Update.
14205         (struct salpy_sal_object) <symtab>: Now a PyObject.
14206         (salpy_dealloc): Update.
14207         (del_objfile_sal): Use gdbpy_ref.
14208
14209 2019-01-03  Tom Tromey  <tom@tromey.com>
14210
14211         * python/py-type.c (convert_field): Use new_reference.  Return
14212         gdbpy_ref.
14213         (make_fielditem): Return gdbpy_ref.
14214         (typy_fields): Update.
14215         (typy_getitem): Update.
14216         (field_name): Return gdbpy_ref.  Use new_reference.
14217         (typy_iterator_iternext): Update.
14218
14219 2019-01-03  Tom Tromey  <tom@tromey.com>
14220
14221         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14222
14223 2019-01-03  Tom Tromey  <tom@tromey.com>
14224
14225         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14226         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14227         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14228         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14229         (pspy_set_type_printers): Likewise.
14230         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14231         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14232         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14233         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14234         (objfpy_set_type_printers): Likewise.
14235
14236 2019-01-03  Tom Tromey  <tom@tromey.com>
14237
14238         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14239         (gdbpy_print_stack): Use gdbpy_err_fetch.
14240         * python/python-internal.h (class gdbpy_err_fetch): New class.
14241         (class gdbpy_enter) <m_error_type, m_error_value,
14242         m_error_traceback>: Remove.
14243         <m_error>: New member.
14244         (gdbpy_exception_to_string): Don't declare.
14245         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14246         * python/py-value.c (convert_value_from_python): Use
14247         gdbpy_err_fetch.
14248         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14249         gdbpy_exception_to_string.
14250         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14251         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14252         gdbpy_err_fetch.
14253
14254 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14255
14256         * linux-nat.c (delete_lwp_cleanup): Delete.
14257         (struct lwp_deleter): New struct.
14258         (lwp_info_up): New typedef.
14259         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14260         lwp_info_up.
14261
14262 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14263
14264         * linux-fork.c (class scoped_switch_fork_info): New class.
14265         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14266
14267 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14268
14269         * valops.c (find_overload_match): Remove use of null_cleanup, and
14270         calls to do_cleanups.
14271
14272 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14273
14274         * compile/compile-cplus-types.c
14275         (compile_cplus_instance::decl_name): Handle changes to
14276         cp_func_name.
14277         * cp-support.c (cp_func_name): Update header comment, update
14278         return type.
14279         * cp-support.h (cp_func_name): Update return type in declaration.
14280         * valops.c (find_overload_match): Move temp_func local to top
14281         level of function and change its type.  Use temp_func to hold and
14282         delete temporary string obtained from cp_func_name.
14283
14284 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14285
14286         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14287         gdb::char_vector, remove cleanup, and update uses of `msg`.
14288
14289 2019-01-03  Jim Wilson  <jimw@sifive.com>
14290
14291         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14292
14293 2019-01-02  Tom Tromey  <tom@tromey.com>
14294
14295         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14296         (tdesc_parse_xml): Remove cleanups.
14297         * target-descriptions.h (make_cleanup_free_target_description):
14298         Don't declare.
14299         (target_desc_deleter): New struct.
14300         (target_desc_up): New typedef.
14301         * target-descriptions.c (target_desc_deleter::operator()): Rename
14302         from free_target_description.
14303         (make_cleanup_free_target_description): Remove.
14304
14305 2019-01-02  Tom Tromey  <tom@tromey.com>
14306
14307         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14308         constructor, destructor.
14309         (linespec_parser): Remove typedef.
14310         (~linespec_parser): Rename from linespec_parser_delete.
14311         (linespec_lex_to_end, linespec_complete_label)
14312         (linespec_complete): Update.
14313         (decode_line_full): Remove cleanups.
14314         (decode_line_1): Update.
14315
14316 2019-01-02  Tom Tromey  <tom@tromey.com>
14317
14318         * python/python-internal.h (inferior_to_inferior_object): Change
14319         return type.
14320         * python/py-exitedevent.c (create_exited_event_object): Update.
14321         * python/py-inferior.c (inferior_to_inferior_object): Return
14322         gdbpy_ref.
14323         (python_new_inferior, python_inferior_deleted)
14324         (thread_to_thread_object, delete_thread_object)
14325         (build_inferior_list, gdbpy_selected_inferior): Update.
14326         * python/py-infthread.c (create_thread_object): Update.  Also fail
14327         if inferior_to_inferior_object fails.
14328
14329 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14330
14331         * inferior.h (class inferior) <displaced_step_state>: New field.
14332         * infrun.h (struct displaced_step_state): Move here from
14333         infrun.c.  Initialize fields, add constructor.
14334         <inf>: Remove field.
14335         <reset>: New method.
14336         * infrun.c (struct displaced_step_inferior_state): Move to
14337         infrun.h.
14338         (displaced_step_inferior_states): Remove.
14339         (get_displaced_stepping_state): Adust.
14340         (displaced_step_in_progress_any_inferior): Adjust.
14341         (displaced_step_in_progress_thread): Adjust.
14342         (displaced_step_in_progress): Adjust.
14343         (add_displaced_stepping_state): Remove.
14344         (get_displaced_step_closure_by_addr): Adjust.
14345         (remove_displaced_stepping_state): Remove.
14346         (infrun_inferior_exit): Call displaced_step_state.reset.
14347         (use_displaced_stepping): Don't check for NULL.
14348         (displaced_step_prepare_throw): Call
14349         get_displaced_stepping_state.
14350         (displaced_step_fixup): Don't check for NULL.
14351         (prepare_for_detach): Don't check for NULL.
14352
14353 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14354
14355         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14356          in case of call that did not complete.
14357
14358 2019-01-02  Andrey Utkin  <autkin@undo.io>
14359
14360         * symfile.c (find_separate_debug_file): Fix search of debug files for
14361         remote debuggee.
14362
14363 2019-01-02  Tom Tromey  <tom@tromey.com>
14364
14365         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14366         indentation.
14367         * python/py-frame.c (frapy_older): Remove cast.
14368         (frapy_newer): Likewise.
14369         * python/py-breakpoint.c (local_setattro): Remove cast.
14370         * python/py-arch.c (archpy_name): Remove local variable.
14371         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14372
14373 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14374
14375         * unittests/basic_string_view/element_access/char/empty.cc:
14376         Fix year range in copyright header.
14377
14378 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14379
14380         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14381         Delete.
14382         <operator==>: Update with for removed field.
14383         <hash>: Likewise.
14384         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14385         <isa_features>: ...this.
14386         <abi_features>: New field.
14387         (riscv_isa_flen): Update comment.
14388         (riscv_abi_xlen): New declaration.
14389         (riscv_abi_flen): New declaration.
14390         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14391         isa_features.
14392         (riscv_abi_xlen): New function.
14393         (riscv_isa_flen): Update to get answer from isa_features.
14394         (riscv_abi_flen): New function.
14395         (riscv_has_fp_abi): Update to get answer from abi_features.
14396         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14397         xlen and flen.
14398         (riscv_call_info) <xlen, flen>: Update comment.
14399         (riscv_call_arg_struct): Remove invalid assertions
14400         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14401         is removed.
14402         (riscv_gdbarch_init): Gather isa features and abi features
14403         separately, ensure both match on the gdbarch when reusing an old
14404         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14405         a target with 64-bit float hardware.
14406
14407 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14408
14409         * source.c (search_command_helper): Stop reverse search
14410         when line 1 has been searched.
14411
14412 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14413
14414         * record-full.c (record_full_base_target::close): Rewrite
14415         record_full_core_buf_list free logic.
14416
14417 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14418
14419         * break-catch-syscall.c (print_one_catch_syscall): xfree
14420         the last text.
14421
14422 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14423
14424         * top.c (print_gdb_version): Update Copyright year in version
14425         message.
14426
14427 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14428
14429         Update copyright year range in all GDB files.
14430
14431 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14432
14433         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14434
14435 For older changes see ChangeLog-2018.
14436 \f
14437 Local Variables:
14438 mode: change-log
14439 left-margin: 8
14440 fill-column: 74
14441 version-control: never
14442 coding: utf-8
14443 End:
14444